[Gnus] Miscellaneous fixes by Dave Abrahams
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4e0f6479
DA
12012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Change struct frame bitfields from unsigned char to unsigned.
4 * frame.h (struct frame): Change type of 'display_preempted',
5 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
6 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
7 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
8 bitfields from unsigned char to unsigned.
9
8b96a52c
DA
102012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
11
12 Remove unused member of struct x_output and struct w32_output.
13 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
14 * w32term.h (struct w32_output): Likewise.
15
b4444c8a
JD
162012-08-30 Jan Djärv <jan.h.d@swipnet.se>
17
18 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
19 does not become zero (Bug#12234).
20
b98521db
PE
212012-08-30 Paul Eggert <eggert@cs.ucla.edu>
22
23 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
24 for GCC 4.7.1 x86-64.
25
31d02438
GM
262012-08-30 Glenn Morris <rgm@gnu.org>
27
28 * lread.c (init_lread): For out-of-tree builds, only add the
29 source directory's site-lisp dir to the load-path if it exists,
30 consistent with in-tree builds. (Bug#12302)
31
7f8941d8
JD
322012-08-28 Jan Djärv <jan.h.d@swipnet.se>
33
34 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
35 button_values to NULL. Call setStykeMask so dialogs get a close button.
36 (windowShouldClose:): Set window_closed.
37 (dealloc): New member, free button_values.
38 (process_dialog:): Make member function. Remove window argument,
39 replace window with self. Count buttons and allocate and store values
40 in button_values.
41 (addButton:value:row:): value is int with the name tag. Call setTag
42 with tag. Remove return self, declare return value as void.
43 (addString:row:): Remove return self, declare return value as void.
44 (addSplit): Remove return self, declare return value as void.
45 (clicked:): Remove return self, declare return value as void.
46 Set dialog_return to button_values[seltag]. Code formatting change.
47 (initFromContents:isQuestion:): Adjust call to process_dialog.
48 Code formatting change.
49 (timeout_handler:): Set timer_fired to YES.
50 (runDialogAt:): Set timer_fired to NO.
51 Handle click on close button as quit.
52
53 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
54 Add window_closed and button_values. Add void as return value for
55 add(Button|String|Split). addButton takes int instead of Lisp_Object.
56 Add process_dialog as new member.
57
eada0861 582012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 59
eada0861
GM
60 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
61 is not one of the heaps we manage. (Bug#12242)
62
632012-08-28 Glenn Morris <rgm@gnu.org>
64
65 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
66
457294dd
MR
672012-08-28 Martin Rudalics <rudalics@gmx.at>
68
69 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
70 auto-buffer-name window parameter. Install revision of reverted
71 fix.
457294dd 72
4f2daf31
DA
732012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
74
75 Do not allow to set major mode for a dead buffer.
76 * buffer.c (Fset_buffer_major_mode): Signal an error
77 if the buffer is dead.
78 (Fother_buffer, other_buffer_safely): Remove redundant
79 nested declaration.
80
66322887
DA
812012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
82
83 Always use set_buffer_if_live to restore original buffer at unwind.
84 * buffer.h (record_unwind_current_buffer): New function.
85 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
86 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
87 * undo.c, window.c: Adjust users.
88 * buffer.c (set_buffer_if_live): Fix comment.
89
a3d794a1
DA
902012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
91
92 Fix usage of set_buffer_internal.
93 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
94 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
95 * coding.c (decode_coding): Omit redundant test.
96 * fileio.c (decide_coding_unwind): Likewise.
97 * fns.c (secure_hash): Likewise.
98 * insdel.c (modify_region): Likewise.
99 * keyboard.c (command_loop_1): Likewise.
100 * print.c (PRINTFINISH): Likewise.
101 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
102
59ea14cd
PE
1032012-08-27 Paul Eggert <eggert@cs.ucla.edu>
104
105 * dispnew.c: Use bool for boolean.
106 (frame_garbaged, display_completed, delayed_size_change)
107 (fonts_changed_p, add_window_display_history)
108 (add_frame_display_history, verify_row_hash)
109 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
110 (row_equal_p, realloc_glyph_pool)
111 (allocate_matrices_for_frame_redisplay)
112 (showing_window_margins_p)
113 (adjust_frame_glyphs_for_frame_redisplay)
114 (build_frame_matrix_from_leaf_window, make_current)
115 (mirrored_line_dance, mirror_line_dance, update_frame)
116 (update_window_tree, update_single_window)
117 (check_current_matrix_flags, update_window, update_text_area)
118 (update_window_line, set_window_update_flags, scrolling_window)
119 (update_frame_1, scrolling, buffer_posn_from_coords)
120 (do_pending_window_change, change_frame_size)
121 (change_frame_size_1, sit_for):
122 Use bool for boolean.
123 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
124 and remove last int (actually boolean) argument, which was always 0.
125 All callers changed.
126 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
127 * dispextern.h (struct composition_it): Use bool for boolean.
128 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
129 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
130 * dired.c (file_name_completion):
131 Use bool for boolean. (This was missed in an earlier change.)
132
95072a94
MR
1332012-08-27 Martin Rudalics <rudalics@gmx.at>
134
135 * window.c (Fset_window_configuration): Revert first part of
136 last change.
137
0f19feff
JD
1382012-08-27 Jan Djärv <jan.h.d@swipnet.se>
139
140 * nsterm.h (NSPanel): New class variable dialog_return.
141
142 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
143 dialog_return.
144 (windowShouldClose:): Use stop instead of stopModalWithCode.
145 (clicked:): Ditto, and also set dialog_return (Bug#12258).
146 (timeout_handler:): Use stop instead of abortModal. Send a dummy
147 event.
148 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
149 modal loop returns.
150
f10fe38f
PE
1512012-08-27 Paul Eggert <eggert@cs.ucla.edu>
152
de1339b0
PE
153 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
154 * composite.c (find_composition, composition_gstring_p)
155 (composition_reseat_it, find_automatic_composition):
156 * data.c (let_shadows_buffer_binding_p)
157 (let_shadows_global_binding_p, set_internal, make_blv)
158 (Fmake_variable_buffer_local, Fmake_local_variable)
159 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
160 (cons_to_signed, arith_driver):
161 * dbusbind.c (xd_in_read_queued_messages):
162 * dired.c (directory_files_internal, file_name_completion):
163 Use bool for booleans.
164 * dired.c (file_name_completion):
165 * process.h (fd_callback):
166 Omit int (actually boolean) argument. It wasn't being used.
167 All uses changed.
168 * composite.h, lisp.h: Reflect above API changes.
169
f10fe38f
PE
170 * cmds.c, coding.c: Use bool for booleans.
171 * cmds.c (move_point, Fself_insert_command):
172 * coding.h (struct composition status, struct coding_system):
173 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
174 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
175 (emacs_mule_char, decode_coding_emacs_mule)
176 (encode_coding_emacs_mule, detect_coding_iso_2022)
177 (decode_coding_iso_2022, encode_invocation_designation)
178 (encode_designation_at_bol, encode_coding_iso_2022)
179 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
180 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
181 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
182 (encode_coding_raw_text, detect_coding_charset)
183 (decode_coding_charset, encode_coding_charset, detect_eol)
184 (detect_coding, get_translation_table, produce_chars)
185 (consume_chars, reused_workbuf_in_use)
186 (make_conversion_work_buffer, code_conversion_save)
187 (decode_coding_object, encode_coding_object)
188 (detect_coding_system, char_encodable_p)
189 (Funencodable_char_position, code_convert_region)
190 (code_convert_string, code_convert_string_norecord)
191 (Fset_coding_system_priority):
192 * fileio.c (Finsert_file_contents):
193 Use bool for booleans.
194 * coding.h, lisp.h: Reflect above API changes.
195 * coding.c: Remove unnecessary static function decls.
196 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
197 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
198 not a boolean 'int', since callers never look at the return value.
199 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
200 * coding.h (decoding_buffer_size, encoding_buffer_size)
201 (emacs_mule_string_char): Remove unused extern decls.
202 (struct iso_2022_spec, struct coding_system):
203 Use 'unsigned int : 1' for boolean fields, since there's more than one.
204 (struct emacs_mule_spec): Remove unused field 'full_support'.
205 All initializations removed.
206 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
207
5474c384
DA
2082012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
209
f10fe38f 210 Fix spare memory change (Bug#12286).
5474c384
DA
211 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
212 (valid_lisp_object_p): Likewise.
213
c4b6914d
MR
2142012-08-27 Martin Rudalics <rudalics@gmx.at>
215
216 * window.c (Fset_window_configuration): Record any window's old
217 buffer if it's replaced (see Bug#8789). If the new current
218 buffer doesn't appear in the selected window, go to its old
219 point (Bug#12208).
220
35aaa1ea
DA
2212012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
222
223 Special MEM_TYPE_SPARE to denote reserved memory.
224 * alloc.c (enum mem_type): New memory type.
225 (refill_memory_reserve): Use new type for spare memory.
226 This prevents live_cons_p and live_string_p from incorrect
227 detection of uninitialized objects from spare memory as live.
228
6af64513
PE
2292012-08-26 Paul Eggert <eggert@cs.ucla.edu>
230
8b2e00a3
PE
231 Spelling fixes.
232 * Makefile.in (.PHONY): versioclean -> versionclean.
233
b52d6985
PE
234 Remove unused external symbols.
235 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
236 * window.c (Qwindow_valid_p, decode_valid_window):
237 Now static, not extern.
238 * data.c (Qinterval): Remove; unused.
239 (syms_of_data): Do not define 'interval'.
240 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
241 * window.h (decode_valid_window):
242 Remove decls.
243
d5172d4f
PE
244 * character.c, charset.c, chartab.c: Use bool for booleans.
245 * character.c (lisp_string_width, string_count_byte8)
246 (string_escape_byte8):
247 * charset.c (charset_map_loaded, load_charset_map, read_hex):
248 (load_charset_map_from_file, map_charset_chars)
249 (Fdefine_charset_internal, define_charset_internal)
250 (Fdeclare_equiv_charset, find_charsets_in_text)
251 (Ffind_charset_region, char_charset, Fiso_charset):
252 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
253 (sub_char_table_set, sub_char_table_set_range)
254 (char_table_set_range, optimize_sub_char_table)
255 (map_sub_char_table):
256 Use bool for boolean.
257 * character.c (str_to_unibyte): Omit last boolean argument; it was
258 always 0. All callers changed.
259 * character.h, charset.h: Adjust to match previous changes.
260 * character.h (char_printable_p): Remove decl of nonexistent function.
261 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
262 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
263 are all boolean, so make them single-bit bitfields.
264
6af64513
PE
265 * lisp.h (ASET): Remove attempt to detect side effects.
266 It was meant to be temporary and it often doesn't work,
267 because when IDX has side effects the behavior of IDX==IDX
268 is undefined. See Stefan Monnier in
269 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
270
e1f29348
BR
2712012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
272
273 * lisp.h (functionp): New function (extracted from Ffunctionp).
274 (FUNCTIONP): Use it.
275 * eval.c (Ffunctionp): Use it.
276
17c05d74
PE
2772012-08-25 Paul Eggert <eggert@cs.ucla.edu>
278
0f46bc75
PE
279 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
280 as that's faster and simpler than static storage. Don't bother
281 with the g_main_context_query overhead if g_main_context_pending
282 says no events are pending.
283 (gfds, gfds_size): Remove these static vars.
284 (xgselect_initialize): Remove; no longer needed.
285 All uses and decls removed.
286
ee4c0f69
PE
287 * emacs.c (fatal_error_signal_hook): Remove.
288 All uses removed. This leftover from old code was always 0.
289
17c05d74
PE
290 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
291 * casefiddle.c (casify_object, casify_region):
292 * casetab.c (set_case_table):
293 * category.c, category.h (word_boundary_p):
294 * category.h (CHAR_HAS_CATEGORY):
295 Use bool for booleans, instead of int.
296
391ceac5
EZ
2972012-08-25 Eli Zaretskii <eliz@gnu.org>
298
299 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
300
2f221583
PE
3012012-08-25 Paul Eggert <eggert@cs.ucla.edu>
302
f4a681b0
PE
303 On assertion failure, print backtrace if available.
304 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
305 (die) [ENABLE_CHECKING]: Print a backtrace if available.
306 * Makefile.in (LIB_EXECINFO): New macro.
307 (LIBES): Use it.
308
2f221583
PE
309 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
310 * bytecode.c (exec_byte_code):
311 * callint.c (check_mark, Fcall_interactively):
312 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
313 (getenv_internal, sync_process_alive, call_process_exited):
314 * lisp.h (USE_SAFE_ALLOCA):
315 Use bool for booleans, instead of int.
316 * lisp.h, process.h: Adjust prototypes to match above changes.
317 * callint.c (Fcall_interactively): Don't assume the mark's
318 offset fits in 'int'.
319
37ef52bb
PE
3202012-08-24 Paul Eggert <eggert@cs.ucla.edu>
321
322 * buffer.c, buffer.h: Use bool for boolean.
323 * buffer.c (reset_buffer_local_variables)
324 (buffer_lisp_local_variables, Fset_buffer_modified_p)
325 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
326 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
327 (overlay_touches_p, overlay_strings, Foverlay_put)
328 (report_overlay_modification, call_overlay_mod_hooks):
329 (mmap_enlarge, mmap_set_vars):
330 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
331 Use bool for booleans, instead of int.
332 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
333 since the 1-or-0 return value is always ignored anyway.
334 (mmap_initialized_p):
335 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
336 * buffer.h, lisp.h: Adjust prototypes to match above changes.
337
2cc21167
PE
3382012-08-23 Paul Eggert <eggert@cs.ucla.edu>
339
340 * bidi.c: Use bool for boolean.
341 This is a bit more readable, and makes the text segment of bidi.o
342 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
343 Presumably it's faster too.
344 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
345 Now bool.
346 (bidi_cache_find_level_change, bidi_cache_iterator_state)
347 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
348 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
349 (bidi_explicit_dir_char, bidi_level_of_next_char)
350 (bidi_find_other_level_edge, bidi_move_to_visually_next):
351 Use bool for booleans, instead of int.
352 * dispextern.h (bidi_init_it, bidi_paragraph_init)
353 (bidi_unshelve_cache): Adjust decls to match code.
354
7db4ddf4
MR
3552012-08-23 Martin Rudalics <rudalics@gmx.at>
356
357 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
358 argument.
359
b1bb8011
PE
3602012-08-23 Paul Eggert <eggert@cs.ucla.edu>
361
362 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
363 * atimer.h: Include <stdbool.h>.
364
ff687885
DN
3652012-08-22 Dan Nicolaescu <dann@gnu.org>
366
367 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
368 compile time tests instead of run time tests on systems that do
369 not use them.
370 (FRAME_MAC_P): Remove leftover from deleted code.
371 * frame.c (syms_of_frame): Remove leftover from deleted code.
372
4ce7a138
JD
3732012-08-22 Jan Djärv <jan.h.d@swipnet.se>
374
375 * nsterm.m (insertText:): Don't clear modifiers if code is space.
376
d733ec6d
PE
3772012-08-22 Paul Eggert <eggert@cs.ucla.edu>
378
379 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
380 Otherwise, the compiler complains about (A?B:C) where B is void
381 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
382 (fontset_add): Return void, for FONTSET_ADD.
383
d0d2d26f
PE
3842012-08-21 Paul Eggert <eggert@cs.ucla.edu>
385
fce31d69
PE
386 * alloc.c: Use bool for booleans.
387 (gc_in_progress, abort_on_gc)
388 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
389 (dont_register_blocks) [GC_MALLOC_CHECK]:
390 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
391 (check_string_bytes, make_specified_string, memory_full)
392 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
393 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
394 (mark_stack, valid_pointer_p, make_pure_string)
395 (Fgarbage_collect, survives_gc_p, gc_sweep):
396 Use bool for booleans, instead of int.
397 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
398 Remove unused local.
399 * alloc.c (PURE_POINTER_P):
400 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
401 * editfns.c (Fformat):
402 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
403 (Fdo_auto_save):
404 * fns.c (sweep_weak_table):
405 * lisp.h (suppress_checking, push_message, survives_gc_p)
406 (make_pure_string, gc_in_progress, abort_on_gc):
407 * lread.c (readchar, read1):
408 * print.c (Fprin1_to_string):
409 * xdisp.c (push_message):
410 Use bool for booleans affected directly or indirectly by
411 alloc.c's changes.
412
d0d2d26f
PE
413 Make recently-introduced setters macros.
414 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
415 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
416 (set_fontset_default, set_fontset_fallback): Rename from their
417 upper-case counterparts, and make them functions rather than macros.
418 This is more consistent with the other recently-introduced setters.
419 These don't need to be inline, since they're local.
420
d18e2bb6
JD
4212012-08-21 Jan Djärv <jan.h.d@swipnet.se>
422
423 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
424 the loop (Bug#12247).
425
1b9d9d16
PE
4262012-08-21 Paul Eggert <eggert@cs.ucla.edu>
427
428 * lisp.h (vcopy): Use memcpy rather than our own loop.
429 This fixes a performance regression introduced by the recent
430 addition of vcopy. This means 'vcopy' will need to be modified
431 for a copying collector, but that's OK. Also, tighten the
432 checking in the assertion.
433
b2f09701
EZ
4342012-08-21 Eli Zaretskii <eliz@gnu.org>
435
436 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
437 components for RTL text (Bug#11860). Adjust X-OFFSET of each
438 non-base glyph for the width of the base character, according to
e1f29348
BR
439 what x_draw_composite_glyph_string_foreground expects.
440 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
441 expectations, to produce correct width of the composed character.
442 Reverse the sign of the DU offset produced by ScriptPlace.
443
9b994fed
PE
4442012-08-21 Paul Eggert <eggert@cs.ucla.edu>
445
446 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
447
086ca913
DA
4482012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
449
450 Avoid direct writes to contents member of struct Lisp_Vector.
451 * lisp.h (vcopy): New function to copy data into vector.
452 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
453 * fns.c (Ffillarray): Use ASET.
454 * keyboard.c (timer_check_2): Use AREF and ASET.
455 (append_tool_bar_item, Frecent_keys): Use vcopy.
456 * lread.c (read_vector): Use ASET.
457 * msdos.c (Frecent_doskeys): Use vcopy.
458 * xface.c (Finternal_copy_lisp_face): Use vcopy.
459 (Finternal_merge_in_global_face): Use ASET and vcopy.
460 * xfont.c (xfont_list_pattern): Likewise.
461
5481664a
MR
4622012-08-21 Martin Rudalics <rudalics@gmx.at>
463
464 * window.c (Fwindow_point): For the selected window always return
465 the position of its buffer's point.
466 (Fset_window_point): For the selected window always go in its
467 buffer to the specified position.
468
6d470bdd
DA
4692012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
470
471 Setter macros for fontsets.
472 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
473 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
474 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
475 Adjust users.
476
24564fe1
GM
4772012-08-20 Glenn Morris <rgm@gnu.org>
478
479 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
480 Don't assume that `ln -f' works.
481
0a05a035
EZ
4822012-08-20 Eli Zaretskii <eliz@gnu.org>
483
484 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
485 and later about non-assignments with no effect. See discussion at
486 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
487 details.
488
e46f2325
DA
4892012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
490
491 Inline setter functions for Lisp_Objects slots of struct specbinding.
492 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
493 Adjust users.
494
734fbd86
MR
4952012-08-20 Martin Rudalics <rudalics@gmx.at>
496
497 * window.c (select_window): Always make selected window's buffer
498 current.
499
f1a95992
DA
5002012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
501
502 Use AREF and ASET for docstrings of category tables.
503 * category.h (CATEGORY_DOCSTRING): Use AREF.
504 (SET_CATEGORY_DOCSTRING): Use ASET.
505 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
506
e83064be
DA
5072012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
508
509 Inline setter functions for hash table members.
510 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
511 (set_hash_hash, set_hash_index): Rename with _slot suffix.
512 (set_hash_key_and_value, set_hash_index, set_hash_next)
513 (set_hash_hash): New functions.
514 * charset.c, fns.c: Adjust users.
515
4ce60d2e
DA
5162012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
517
518 Inline getter and setter functions for per-buffer values.
519 * buffer.h (per_buffer_default, set_per_buffer_default)
520 (per_buffer_value, set_per_buffer_value): New functions.
521 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
522 * buffer.c, data.c: Adjust users.
523
c06c9690
JB
5242012-08-20 Juanma Barranquero <lekktu@gmail.com>
525
526 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
527
32bd4250
PE
5282012-08-19 Paul Eggert <eggert@cs.ucla.edu>
529
bad03192 530 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
531 as gnulib does this if the system doesn't.
532 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
533 Remove declaration. MS-Windows declares it on stdlib.h which is
534 included by conf_post.h.
b69a6d22
PE
535 * emacs.c (environ) [DOUG_LEA_MALLOC]:
536 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
537 * vm-limit.c: Include <unistd.h>, for 'environ'.
538
22d7feb2
PE
539 * unexaix.c, unexcoff.c: Include "mem-limits.h".
540 (start_of_data): Remove decl; mem-limits.h provides it.
541
32bd4250
PE
542 * xdisp.c (handle_invisible_prop): Make it a bit faster
543 and avoid a gcc -Wmaybe-uninitialized diagnostic.
544
450809af
CY
5452012-08-19 Chong Yidong <cyd@gnu.org>
546
547 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
548 ends (Bug#3874).
549
9e677988
AS
5502012-08-19 Andreas Schwab <schwab@linux-m68k.org>
551
6b1319ce
AS
552 * .gdbinit: Use call instead of set when calling a function in the
553 inferior.
554
9e677988
AS
555 * data.c (set_internal): Don't use set_blv_found.
556 (Fkill_local_variable): Likewise.
557
d7191076
AA
5582012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
559
560 * nsfont.m (ns_ascii_average_width): Ensure the string
561 ascii_printable is initialized with a null-terminated character
562 array. Otherwise, it can contain undesired extra characters.
563
e757f1c6
PE
5642012-08-18 Paul Eggert <eggert@cs.ucla.edu>
565
566 port new setting code to Sun C 5.8 2005/10/13
567 * chartab.c, lisp.h (char_table_set, char_table_set_range):
568 Return void, not Lisp_Object. Otherwise, the compiler
569 complains about (A?B:C) where B is void and C is Lisp_Object
570 when compiling CHAR_TABLE_SET, due to the recent change to
571 the API of sub_char_table_set_contents.
572
a999ce26
CY
5732012-08-18 Chong Yidong <cyd@gnu.org>
574
575 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
576 for the string case (Bug#3874).
577
3f22b86f
PE
5782012-08-18 Paul Eggert <eggert@cs.ucla.edu>
579
39eb03f1
PE
580 * buffer.h (BSET): Remove (Bug#12215).
581 Replace all uses with calls to new setter functions.
582 (bset_bidi_paragraph_direction, bset_case_canon_table)
583 (bset_case_eqv_table, bset_directory, bset_display_count)
584 (bset_display_time, bset_downcase_table)
585 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
586 (bset_last_selected_window, bset_local_var_alist)
587 (bset_mark_active, bset_point_before_scroll, bset_read_only)
588 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
589 (bset_width_table):
590 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
591 (bset_auto_fill_function, bset_auto_save_file_format)
592 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
593 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
594 (bset_cache_long_line_scans, bset_case_fold_search)
595 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
596 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
597 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
598 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
599 (bset_header_line_format, bset_indicate_buffer_boundaries)
600 (bset_indicate_empty_lines, bset_invisibility_spec)
601 (bset_left_fringe_width, bset_major_mode, bset_mark)
602 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
603 (bset_name, bset_overwrite_mode, bset_pt_marker)
604 (bset_right_fringe_width, bset_save_length)
605 (bset_scroll_bar_width, bset_scroll_down_aggressively)
606 (bset_scroll_up_aggressively, bset_selective_display)
607 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
608 (bset_word_wrap, bset_zv_marker):
609 * category.c (bset_category_table):
610 * syntax.c (bset_syntax_table):
611 New setter functions.
612
6a09a33b
PE
613 * process.h (PSET): Remove (Bug#12215).
614 Replace all uses with calls to new setter functions.
615 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
616 (PROCESS_INLINE): New macro.
617 (pset_childp): New setter function.
618 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
619 * process.c (PROCESS_INLINE):
620 Define to EXTERN_INLINE, so that the corresponding functions
621 are compiled into code.
622 (pset_buffer, pset_command, pset_decode_coding_system)
623 (pset_decoding_buf, pset_encode_coding_system)
624 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
625 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
626 (pset_type, pset_write_queue): New setter functions.
627
e8c17b81
PE
628 * window.h (WSET): Remove (Bug#12215).
629 Replace all uses with calls to new setter functions.
630 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
631 (WINDOW_INLINE): New macro.
632 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
633 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
634 (wset_total_lines, wset_vertical_scroll_bar)
635 (wset_window_end_pos, wset_window_end_valid)
636 (wset_window_end_vpos): New setter functions.
637 * window.c (WINDOW_INLINE):
638 Define to EXTERN_INLINE, so that the corresponding functions
639 are compiled into code.
640 (wset_combination_limit, wset_dedicated, wset_display_table)
641 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
642 (wset_new_normal, wset_new_total, wset_next_buffers)
643 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
644 (wset_prev_buffers, wset_right_fringe_width)
645 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
646 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
647 (wset_window_parameters):
648 * xdisp.c (wset_base_line_number, wset_base_line_pos)
649 (wset_column_number_displayed, wset_region_showing):
650 New setter functions.
651
3f22b86f
PE
652 * termhooks.h (TSET): Remove (Bug#12215).
653 Replace all uses with calls to new setter functions.
654 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
655 (TERMHOOKS_INLINE): New macro.
656 (tset_charset_list, tset_selection_alist): New setter functions.
657 * terminal.c (TERMHOOKS_INLINE):
658 Define to EXTERN_INLINE, so that the corresponding functions
659 are compiled into code.
660 (tset_param_alist): New setter function.
661
742af32f
PE
6622012-08-17 Paul Eggert <eggert@cs.ucla.edu>
663
15dbb4d6
PE
664 * keyboard.h (KSET): Remove (Bug#12215).
665 Replace all uses with calls to new setter functions.
666 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
667 (KEYBOARD_INLINE): New macro.
668 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
669 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
670 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
671 New setter functions.
672 * keyboard.c (KEYBOARD_INLINE):
673 Define to EXTERN_INLINE, so that the corresponding functions
674 are compiled into code.
675 (kset_echo_string, kset_kbd_queue)
676 (kset_keyboard_translate_table, kset_last_prefix_arg)
677 (kset_last_repeatable_command, kset_local_function_key_map)
678 (kset_overriding_terminal_local_map, kset_real_last_command)
679 (kset_system_key_syms): New setter functions.
680
f00af5b1
PE
681 * frame.h (FSET): Remove (Bug#12215).
682 Replace all uses with calls to new setter functions.
683 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
684 (FRAME_INLINE): New macro.
685 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
686 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
687 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
688 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
689 (fset_param_alist, fset_root_window, fset_scroll_bars)
690 (fset_selected_window, fset_title, fset_tool_bar_items)
691 (fset_tool_bar_position, fset_tool_bar_window): New functions.
692 * frame.c (FRAME_INLINE):
693 Define to EXTERN_INLINE, so that the corresponding functions
694 are compiled into code.
695 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
696
0c94c8d6
PE
697 A few more naming-convention fixes for getters and setters.
698 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
699 and rename from buffer_overlays_set_before.
700 (set_buffer_overlays_after): Move here from buffer.h, and rename
701 from buffer_overlays_set_after.
702 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
703 All uses changed.
704 (set_buffer_intervals): Rename from buffer_set_intervals.
705 * intervals.c (set_interval_object): Move here from intervals.h,
706 and rename from interval_set_object.
707 (set_interval_left): Move here from intervals.h, and rename from
708 interval_set_left.
709 (set_interval_right): Move here from intervals.h, and rename from
710 interval_set_right.
711 (copy_interval_parent): Move here from intervals.h, and rename from
712 interval_copy_parent.
713 * intervals.h (set_interval_parent): Rename from interval_set_parent.
714 (set_interval_plist): Rename from interval_set_plist.
715 Return void, not Lisp_Object, since no caller uses the result.
716 * lisp.h (string_intervals): Rename from string_get_intervals.
717 (set_string_intervals): Rename from string_set_intervals.
718
34dabdb7
PE
719 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
720 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 721 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
722 All uses changed. See the end of
723 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
724
742af32f
PE
725 * lisp.h (CSET): Remove (Bug#12215).
726 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
727 (set_char_table_purpose): New functions,
728 replacing CSET. All uses changed. For example, replace
729 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 730 "set_char_table_parent (char_table, parent);".
742af32f
PE
731 The old version was confusing because it used the same name
732 'parent' for two different things.
733
a04e2c62
DA
7342012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
735
736 Functions to get and set Lisp_Object fields of buffer-local variables.
737 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
738 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
739 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
740 * data.c, eval.c, frame.c: Adjust users.
741
383dcbf9
CY
7422012-08-17 Chong Yidong <cyd@gnu.org>
743
744 * xfaces.c (merge_face_vectors): If the target font specfies a
745 font spec, make the font's attributes take precedence over
746 directly-specified attributes.
747 (merge_face_ref): Recognize :font.
748
44386687
DA
7492012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
750
751 Do not use memcpy for copying intervals.
752 * intervals.c (reproduce_interval): New function.
753 (reproduce_tree, reproduce_tree_obj): Use it.
754 (reproduce_tree_obj): Remove prototype.
755
927c7216
PE
7562012-08-17 Paul Eggert <eggert@cs.ucla.edu>
757
758 * lisp.h (duration_to_sec_usec): Remove unused decl.
759
93044f7b
AA
7602012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
761
762 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
763 to an allocated instance of NSString, not to the class itself.
764
9851e4a5
JB
7652012-08-17 Juanma Barranquero <lekktu@gmail.com>
766
767 * makefile.w32-in (C_CTYPE_H): New macro.
768 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
769 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
770 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
771
620f13b0
PE
7722012-08-16 Paul Eggert <eggert@cs.ucla.edu>
773
774 Use ASCII tests for character types.
775 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
776 * xfns.c, xterm.c:
777 Don't include <ctype.h>; was not needed.
778 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
779 * sysdep.c, xfaces.c:
780 Include <c-ctype.h> instead of <ctype.h>.
781 * nsterm.m: Include <c-ctype.h>.
782 * charset.c (read_hex):
783 * doc.c (Fsnarf_documentation):
784 * fileio.c (IS_DRIVE) [WINDOWSNT]:
785 (DRIVE_LETTER) [DOS_NT]:
786 (Ffile_name_directory, Fexpand_file_name)
787 (Fsubstitute_in_file_name):
788 * font.c (font_parse_xlfd, font_parse_fcname):
789 * frame.c (x_set_font_backend):
790 * gtkutil.c (xg_get_font):
791 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
792 * nsimage.m (hexchar):
793 * nsterm.m (ns_xlfd_to_fontname):
794 * sysdep.c (system_process_attributes):
795 * xfaces.c (hash_string_case_insensitive):
796 Use C-locale tests instead of locale-specific tests for character
797 types, since we want the ASCII interpretation here, not the
798 interpretation suitable for whatever happens to be the current locale.
799
52162052
MR
8002012-08-16 Martin Rudalics <rudalics@gmx.at>
801
802 Consistently check windows for validity/liveness
803 (Bug#11984, Bug#12025, Bug#12026).
804 * lisp.h (CHECK_VALID_WINDOW): New macro.
805 * window.c (decode_window): Rename to decode_live_window.
806 (decode_valid_window, Fwindow_valid_p): New functions.
807 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
808 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
809 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
810 (Fwindow_prev_sibling, Fwindow_combination_limit)
811 (Fset_window_combination_limit, Fwindow_use_time)
812 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
813 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
814 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
815 (Fwindow_hscroll, Fset_window_hscroll)
816 (Fwindow_redisplay_end_trigger)
817 (Fset_window_redisplay_end_trigger, Fwindow_edges)
818 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
819 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
820 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
821 (Fwindow_end, Fset_window_point, Fset_window_start)
822 (Fpos_visible_in_window_p, Fwindow_line_height)
823 (Fwindow_dedicated_p, Fset_window_dedicated_p)
824 (Fwindow_prev_buffers, Fset_window_prev_buffers)
825 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
826 (Fset_window_parameter, Fwindow_display_table)
827 (Fset_window_display_table, Fdelete_other_windows_internal)
828 (Fset_window_buffer, Fset_window_new_total)
829 (Fset_window_new_normal, Fdelete_window_internal)
830 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
831 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
832 (Fwindow_scroll_bars): Check whether argument window is a valid or
833 live window. Update doc-strings.
834 (syms_of_window): New symbol Qwindow_valid_p.
835 * keyboard.c (Fposn_at_x_y): Check whether argument
836 frame_or_window denotes a valid window.
837
2751c80f
DA
8382012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
839
840 Fix previous char table change.
841 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
842 * chartab.c (optimize_sub_char_table): Likewise.
843
032a42c8
CY
8442012-08-16 Chong Yidong <cyd@gnu.org>
845
a2d19368
CY
846 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
847
032a42c8
CY
848 * xfont.c (xfont_open):
849 * xftfont.c (xftfont_open): Set the font's max_width field.
850
851 * nsfont.m (nsfont_open): Similar to the Xft backend, set
852 min_width to space_width and average_width to the average over
853 printable ASCII characters.
854 (ns_char_width): Code cleanup.
855 (ns_ascii_average_width): New utility function.
856
857 * font.h (struct font): Update comments.
858
a098c930
DA
8592012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
860
032a42c8 861 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
862 * lisp.h (CSET): New macro.
863 (char_table_set_extras, char_table_set_contents)
864 (sub_char_table_set_contents): New function.
865 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
866 * syntax.c: Adjust users.
867
8be3a09c
SM
8682012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
869
870 * eval.c (eval_sub): Bind lexical-binding.
871 * lread.c (Qlexical_binding): Make non-static.
872
ac4845a6
JD
8732012-08-15 Jan Djärv <jan.h.d@swipnet.se>
874
ddee6515
JD
875 * nsmenu.m (popupSession): Remove.
876 (pop_down_menu): Remove endModalSession.
877 (timeout_handler:): New method.
878 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
879 Call runModalForWindow. Check timer_fired when it returns.
880 If not set, cancel timer and break out of loop.
881 Otherwise loop again, with a new timeout.
882
883 * nsterm.m: Include fcntl.h if present.
884 (fd_entry, t_readfds, inNsSelect): Remove.
885 (select_writefds, select_valid, select_timeout, selfds)
886 (select_mutex, apploopnr): Add.
887 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
888 Otherwise call kbd_buffer_store_event.
889 (ns_send_appdefined): Remove release of fd_entry.
890 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
891 Increment and decrement apploopnr.
892 (ns_select): If no file descriptors, just do a NSTimer.
893 Otherwise copy read/write masks and start select thread (fd_handler).
894 Start main loop and wait for application defined event.
895 Inform select thread to stop selecting after main loop is exited.
896 (ns_term_init): Create selfds pipe and set non-blocking.
897 Initialize select_mutex. Start the select thread (fd_handler).
898 (fd_handler:): Loop forever, wait for info from the main thread
899 to either start or stop selecting. When select returns, send
900 and appdefined event.
901 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
902 If not call kbd_buffer_store_event.
903
904 * nsterm.h (EmacsApp): fd_handler takes id argument.
905 (EmacsDialogPanel): Add timer_fired and timeout_handler.
906
ac4845a6
JD
907 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
908
eb424fe3
EZ
9092012-08-15 Eli Zaretskii <eliz@gnu.org>
910
911 * region-cache.c (move_cache_gap): Update gap_len using the actual
912 growth of the boundaries array. Do not change cache_len.
913 (Bug#12196)
914
4e6a86c6
DA
9152012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
916
917 Generalize and cleanup font subsystem checks.
918 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
919 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
920 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 921
5bf192ca
DA
9222012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
923
924 * gtkutil.c (xg_get_font): Use pango_units_to_double.
925
f2045622
CY
9262012-08-15 Chong Yidong <cyd@gnu.org>
927
8be3a09c
SM
928 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
929 When using the new font chooser, use gtk_font_chooser_get_font_desc to
930 extract the font descriptor instead of just the font name.
931 In that case, return a font spec instead of a string.
f2045622
CY
932 (x_last_font_name): Move to this file from xfns.c.
933
934 * xfns.c (Fx_select_font): The return value can also be a font
935 spec. Move x_last_font_name management to gtkutil.c.
936
937 * xfaces.c: Make font weight and style symbols non-static.
938
7f6feb56
SM
9392012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
940
941 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
942 (bug#12117).
943
fecbd8ff
SM
9442012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
945
946 * alloc.c (Fgarbage_collect): Use plural form consistently.
947
9b8d5165
EZ
9482012-08-14 Eli Zaretskii <eliz@gnu.org>
949
950 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
951 iteration through the command loop. Fixes a problem whereby mouse
952 movements are ignored until the first mouse click.
953
f5d9e83a
PE
9542012-08-14 Paul Eggert <eggert@cs.ucla.edu>
955
956 Use bool, not int, for Lisp booleans.
957 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
958 makes Emacs a bit smaller and presumably a bit faster.
959 * lisp.h: Include <stdbool.h>.
960 (struct Lisp_Boolfwd, defvar_bool):
961 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
962 * regex.c [!emacs]: Include <stdbool.h>.
963 (false, true): Remove; <stdbool.h> does this for us now.
964
55802e4a
CY
9652012-08-14 Chong Yidong <cyd@gnu.org>
966
4abcdac8
CY
967 * character.c (Fcharacterp): Doc fix (Bug#12076).
968
969 * data.c (Findirect_variable): Doc fix (Bug#11040).
970
55802e4a
CY
971 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
972
973 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 974 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 975
8e99d072
BR
9762012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
977
978 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
979 (bug#12022).
980
08908aca
MR
9812012-08-14 Martin Rudalics <rudalics@gmx.at>
982
983 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
984 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
985 * minibuf.c (choose_minibuf_frame, read_minibuf):
986 * w32fns.c (x_create_tip_frame):
987 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
988 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
989
56120d6f
PE
9902012-08-14 Paul Eggert <eggert@cs.ucla.edu>
991
992 * intervals.c (offset_intervals): Remove obsolete comment.
993
67b77c0b
AS
9942012-08-14 Andreas Schwab <schwab@linux-m68k.org>
995
996 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
997
f48b82fd
GR
9982012-08-14 Gergely Risko <gergely@risko.hu>
999
1000 * coding.c (decode_coding): Record buffer modification before
1001 disabling undo_list (Bug#11773).
1002
fd318b54
DA
10032012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1004
1005 Revert and cleanup some recent overlay changes.
1006 * buffer.h (enum overlay_type): Remove.
1007 (buffer_get_overlays, buffer_set_overlays): Likewise.
1008 (buffer_set_overlays_before, buffer_set_overlays_after):
1009 New function. Adjust users.
1010 (unchain_both): Add eassert.
1011
41a62dd9
DA
10122012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
1013
1014 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
1015
5884c324
PE
10162012-08-14 Paul Eggert <eggert@cs.ucla.edu>
1017
1018 * gtkutil.c (xg_mark_data): Don't assume C99.
1019
ca06f160
JD
10202012-08-13 Jan Djärv <jan.h.d@swipnet.se>
1021
1022 * gtkutil.c (xg_frame_tb_info): New struct.
1023 (TB_INFO_KEY): New define.
1024 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
1025 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
1026 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
1027 if not present.
1028 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
1029 is up to date. Otherwise store new data.
1030 (free_frame_tool_bar): Free xg_frame_tb_info if present.
1031
7864a3f7
DA
10322012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1033
1034 Use KSET for write access to Lisp_Object members of struct kboard.
1035 * keyboard.h (KSET): New macro.
1036 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
1037 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
1038 * xterm.c: Adjust users.
1039
4c31be61
DA
10402012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
1041
1042 Use BSET for write access to Lisp_Object members of struct buffer.
1043 * buffer.h (BSET): New macro.
1044 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
1045 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
1046 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
1047 * window.c, xdisp.c, xfns.c: Adjust users.
1048
14ae4239
BT
10492012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
1050
1051 * lread.c (syms_of_lread): Initialize Vlexical_binding.
1052
32bcadb4
JD
10532012-08-11 Jan Djärv <jan.h.d@swipnet.se>
1054
3d29b2ce
JD
1055 * nsterm.m (not_in_argv): New function.
1056 (application:openFile, application:openTempFile:):
1057 (application:openFileWithoutUI:, application:openFiles:): Open file
1058 if not_in_argv returns non-zero (bug#12171).
1059
32bcadb4 1060 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
1061 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
1062 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
1063 (xg_get_font_name): Use those functions/macros here.
1064 Reported by Frans Oilinki <moilinki@gmail.com>.
1065
9ff9402d 10662012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
1067
1068 * unexmacosx.c (copy_data_segment): Copy initialized data in
1069 statically linked libraries from input file rather than memory.
1070
db74a5fc
YM
1071 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
1072 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
1073 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
1074
25e65510
GM
10752012-08-10 Glenn Morris <rgm@gnu.org>
1076
1077 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
1078 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
1079
7961135c
DA
10802012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1081
1082 Fix last change to allow compilation with low optimization levels.
1083 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
1084 Reported by Jan Djärv <jan.h.d@swipnet.se>.
1085
42b3a444
DA
10862012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1087
1088 Use common inline syntax in intervals.h.
1089 * intervals.h (INTERVALS_INLINE): New macro.
1090 Change all users from LISP_INLINE.
1091
9fb0c957
DA
10922012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1093
1094 Define Qnone once for all platforms.
1095 * frame.c (Qnone): Define here.
1096 (syms_of_frame): DEFSYM it.
1097 * lisp.h (Qnone): New declaration.
1098 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
1099 * xfns.c: Remove duplication. Adjust users.
1100
65e8ee52
DA
11012012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
1102
1103 Remove unused macros from intervals.h.
1104 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
1105 * intervals.c: Adjust comment.
1106
9b855fd6
EZ
11072012-08-10 Eli Zaretskii <eliz@gnu.org>
1108
1109 * w32fns.c <w32_unicode_gui>: New static variable.
1110 (globals_of_w32fns): Initialize it according to os_subtype.
1111 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
1112 testing os_subtype.
1113
39cb9e56 11142012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
1115 Eli Zaretskii <eliz@gnu.org>
1116
1117 Fix bug #10299 with Unicode characters sent by customized
1118 keyboards created by MSKLC.
1119 * w32fns.c (INIT_WINDOW_CLASS): New macro.
1120 (w32_init_class): Use it to initialize the Emacs class with either
1121 ANSI or Unicode API calls.
1122 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
1123 later.
1124 (w32_wnd_proc): If the character code sent by WM_CHAR or
1125 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
1126 original message. Call DefWindowProcW on NT and later.
1127
9374581a
GM
11282012-08-10 Glenn Morris <rgm@gnu.org>
1129
4b94e8cf
GM
1130 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
1131
9374581a
GM
1132 * lisp.h (DIRECTORY_SEP): Let configure set it.
1133
a2752828
DA
11342012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1135
1136 Use TSET for write access to Lisp_Object slots of struct terminal.
1137 * termhooks.h (TSET): New macro.
1138 * coding.c, terminal.c, xselect.c: Adjust users.
1139
cc92c454
SM
11402012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
1141
1142 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
1143 the failing expression, include them in the error message.
1144 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
1145 * lisp.h (internal_condition_case_n): Update declaration.
1146
4cb3e6b3
DA
11472012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1148
1149 Inline functions to examine and change buffer overlays.
1150 * buffer.c (unchain_both): New function.
1151 * buffer.h (buffer_get_overlays, buffer_set_overlays):
1152 (buffer_has_overlays): New function.
1153 (enum overlay_type): New enum.
1154 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
1155 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
1156
8707c1e5
DA
11572012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1158
1159 Inline functions to examine and change buffer intervals.
1160 * alloc.c (mark_interval_tree): Remove.
1161 (MARK_INTERVAL_TREE): Simplify.
1162 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
1163 * intervals.c (buffer_balance_intervals): New function.
1164 (graft_intervals_into_buffer): Adjust indentation.
1165 (set_intervals_multibyte): Simplify.
1166 * buffer.h (BUF_INTERVALS): Remove.
1167 (buffer_get_intervals, buffer_set_intervals): New function.
1168 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
1169 * intervals.c, textprop.c: Adjust users.
1170
ad8c997f
DA
11712012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1172
1173 Inline functions to examine and change string intervals.
1174 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
1175 (string_get_intervals, string_set_intervals): New function.
1176 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1177 * lread.c, print.c, textprop.c: Adjust users.
1178
32ac3a6b
GM
11792012-08-08 Glenn Morris <rgm@gnu.org>
1180
1181 * lisp.mk (lisp): Remove language/persian.elc.
1182
77c7bcb1
DA
11832012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1184
1185 Cleanup intervals.
1186 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
1187 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
1188 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
1189 Adjust comment. Move under #if 0.
77c7bcb1
DA
1190 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
1191 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
1192
9c08a8d4
DA
11932012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1194
1195 Check total length of intervals with eassert.
1196 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
1197 * intervals.c: Change all users to eassert.
1198
26d16b35
EZ
11992012-08-07 Eli Zaretskii <eliz@gnu.org>
1200
14ae4239
BT
1201 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
1202 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
1203 INTERNAL_FIELD in Lisp_Cons.
1204
c644523b
DA
12052012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
1208 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
1209 name since all xname users are fixed long time ago. Do not
1210 use INTERNAL_FIELD.
1211 (set_symbol_name, set_symbol_function, set_symbol_plist):
1212 (set_symbol_next, set_overlay_plist): New function.
1213 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
1214 (struct Lisp_Overlay): Likewise.
1215 (CVAR, MVAR, SVAR): Remove.
1216 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
1217 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
1218 * xterm.c: Adjust users.
1219 * .gdbinit: Change to use name field of struct Lisp_Symbol
1220 where appropriate.
1221
6a3d20cc
DA
12222012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 Basic functions to set Lisp_Object and pointer slots of intervals.
1225 * intervals.h (interval_set_parent, interval_set_object):
1226 (interval_set_left, interval_set_right, interval_set_plist):
1227 (interval_copy_parent): New function.
1228 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
1229 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
1230 Adjust indentation.
6a3d20cc
DA
1231 (INTERVAL_SIZE): Remove. Adjust users.
1232 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
1233
4d2b044c
DA
12342012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1235
1236 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
1237 * process.h (PGET): Remove.
1238 (struct Lisp_Process): Do not use INTERNAL_FIELD.
1239 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1240
d3d50620
DA
12412012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1242
1243 Drop WGET and revert read access to Lisp_Objects slots of struct window.
1244 * window.h (WGET): Remove.
1245 (struct window): Do not use INTERNAL_FIELD.
1246 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1247 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1248 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1249 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1250 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1251 Adjust users.
1252
d10a51dc
CY
12532012-08-07 Chong Yidong <cyd@gnu.org>
1254
1255 * window.c (Fwindow_edges, Fwindow_pixel_edges)
1256 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
1257 (Fdelete_window_internal): Signal an error if the window is not on
1258 a live frame (Bug#12025).
1259
e69b0960
DA
12602012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1261
1262 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
1263 * frame.h (FGET): Remove.
1264 (struct frame): Do not use INTERNAL_FIELD.
1265 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1266 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1267 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1268 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1269
25a20a3a
JB
12702012-08-06 Juanma Barranquero <lekktu@gmail.com>
1271
1272 * w32.c: Silence compiler warnings.
1273 (map_w32_filename): Remove unused variable `is_fat'.
1274 (chase_symlinks): Add parentheses around expression.
1275
1c6f11f4
GM
12762012-08-06 Glenn Morris <rgm@gnu.org>
1277
1db4583a
GM
1278 * sysdep.c: Respect BROKEN_GETWD.
1279
1c6f11f4
GM
1280 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
1281 Let configure handle it.
1282 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
1283
2b90362b
DA
12842012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1285
1286 Use GCALIGNMENT where appropriate.
1287 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
1288 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
1289 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
1290
5f50daf2
EZ
12912012-08-06 Eli Zaretskii <eliz@gnu.org>
1292
14ae4239
BT
1293 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
1294 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 1295
cbcc7007
SM
12962012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
1297
1298 * buffer.h (struct buffer): Revert `indirections' to a simple int;
1299 that should be sufficient for everyone.
1300
4d365fa4
JD
13012012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1302
1303 * keyboard.c (timer_check_2): Add break so timer_check returns next
1304 timeout.
1305
dd86bd82
DA
13062012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1307
1308 Fix Windows build errors introduced after converting to WGET and WSET.
1309 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
1310 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1311
054e1668
JD
13122012-08-06 Jan Djärv <jan.h.d@swipnet.se>
1313
1314 * nsterm.m (ns_frame_rehighlight): Use FSET.
1315
1316 * nsmenu.m (ns_update_menubar): Use FSET.
1317
21238f11
DA
13182012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1319
1320 Separate read and write access to Lisp_Object slots of Lisp_Process.
1321 * process.h (PGET, PSET): New macros similar to AREF and ASET.
1322 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
1323
077288cf
DA
13242012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1325
1326 Separate read and write access to Lisp_Object slots of struct window.
1327 * window.h (WGET, WSET): New macros similar to AREF and ASET.
1328 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1329 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1330 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
1331 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
1332 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
1333 Adjust users.
1334
71688bd7
DA
13352012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1336
1337 Fix Windows build errors introduced after converting to FGET and FSET.
1338 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
1339 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
1340 (w32_judge_scroll_bars): Change to use FSET.
1341 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
1342
f99bac93
DA
13432012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1344
1345 Fix replacement typo.
1346 * window.c (replace_window): Set root_window instead of
1347 selected_window. This fixes a total window subsystem
1348 malfunction reported by Bastien Guerry <bzg@gnu.org>.
1349
8c2a0f2d
GM
13502012-08-06 Glenn Morris <rgm@gnu.org>
1351
1352 * lisp.mk (lisp): Add language/persian.elc.
1353
edd74c35
DA
13542012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1355
1356 Separate read and write access to Lisp_Object slots of struct frame.
1357 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
1358 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
1359 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
1360 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
1361 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
1362
8671676c
AS
13632012-08-05 Andreas Schwab <schwab@linux-m68k.org>
1364
1365 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
1366
663e2b3f
DA
13672012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 Generalize common compile-time constants.
1370 * lisp.h (header_size, bool_header_size, word_size): Now here.
1371 (struct Lisp_Vector): Add comment.
1372 (struct Lisp_Bool_Vector): Move up to define handy constants.
1373 (VECSIZE, PSEUDOVECSIZE): Simplify.
1374 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
1375 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
1376 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
1377 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
1378 * xfont.c, xmenu.c: Use word_size where appropriate.
1379
d32e47af
LM
13802012-08-05 Lawrence Mitchell <wence@gmx.li>
1381
1382 * search.c (Freplace_match): Treat \? in the replacement text
1383 literally (Bug#8161).
1384
e5d9c0d1
CY
13852012-08-05 Chong Yidong <cyd@gnu.org>
1386
1387 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
1388 * frame.c (Vdelete_frame_functions):
1389 * emacs.c (Vkill_emacs_hook): Doc fix.
1390
8da0576b
EZ
13912012-08-04 Eli Zaretskii <eliz@gnu.org>
1392
1393 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
1394 --with-x-toolkit=no builds.
1395 Reported by Carsten Mattner <carstenmattner@gmail.com>.
1396
02676e5d
CY
13972012-08-04 Chong Yidong <cyd@gnu.org>
1398
1399 * syntax.c (Fmodify_syntax_entry): Doc fix.
1400
97147da9
EZ
14012012-08-04 Eli Zaretskii <eliz@gnu.org>
1402
76151e2c
EZ
1403 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
1404 * w32.c (init_environment): Change the default values of many
1405 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
1406 them into environment when they were not already defined.
1407 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 1408 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
1409 (check_windows_init_file): Now external, not static.
1410 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
1411 called when Vload_path is already set up.
1412
1413 * w32.h (check_windows_init_file): Add prototype.
1414
1415 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
1416 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
1417 compatibility with Posix platforms.
1418 (main): Move the call to check_windows_init_file to here from
1419 w32.c.
1420 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
1421 any, in the DEFALT argument into the root of the Emacs build or
1422 installation tree, as appropriate.
1423
1424 * callproc.c (init_callproc_1): Call decode_env_path instead of
1425 doing its equivalent by hand.
1426 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
1427 the code that sets Vexec_path run on MS-Windows.
1428
1429 * lread.c (init_lread): Add comments to #ifdef's.
1430
97147da9
EZ
1431 * msdos.c (dos_set_window_size, IT_update_begin)
1432 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
1433 instead of direct references.
1434
185ee146
PE
14352012-08-04 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 Export DEFAULT_REHASH_* to GDB.
1438 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
1439 Now constants, not macros.
1440
8834c57a
PE
14412012-08-03 Paul Eggert <eggert@cs.ucla.edu>
1442
98c6f1e3
PE
1443 Remove unnecessary casts involving pointers.
1444 These casts are no longer needed now that we assume C89 or later,
1445 since they involve casting to or from void *.
1446 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
1447 (make_pure_float, make_pure_vector):
1448 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
1449 * macros.c (Fstart_kbd_macro):
1450 * menu.c (find_and_return_menu_selection):
1451 * minibuf.c (read_minibuf_noninteractive):
1452 * sysdep.c (closedir):
1453 * xdisp.c (x_produce_glyphs):
1454 * xfaces.c (compare_fonts_by_sort_order):
1455 * xfns.c (x_real_positions, select_visual):
1456 * xselect.c (x_stop_queuing_selection_requests)
1457 (x_get_window_property, x_get_window_property_as_lisp_data):
1458 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
1459 Remove unnecessary pointer casts.
1460 * alloc.c (record_xmalloc): New function.
1461 * lisp.h (record_xmalloc): New decl.
1462 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
1463 more like a function. This is because the pointer cast is not
1464 needed. All uses changed.
1465 * print.c (print_string, print_error_message): Avoid length recalc.
1466
8834c57a
PE
1467 Improve fix for macroexp crash with debugging (Bug#12118).
1468 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
1469 ARRAY_MARK_FLAG when checking subscripts, because ASET is
1470 not supposed to be invoked from the garbage collector.
1471 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
1472 (gc_aset): New function, which is like ASET but can be
1473 used in the garbage collector.
1474 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1475 (set_hash_index): Use it instead of ASET.
1476
6dad7178
EZ
14772012-08-03 Eli Zaretskii <eliz@gnu.org>
1478
1479 Support symlinks on latest versions of MS-Windows.
1480 * w32.c: Include winioctl.h and aclapi.h.
1481 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
1482 (revert_to_self): Forward declarations of static functions.
1483 <static BOOL g_b_init_get_security_info>:
1484 <g_b_init_create_symbolic_link>: New static flags.
1485 (globals_of_w32): Initialize them to zero.
1486 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
1487 (map_w32_filename): Improve commentary. Simplify switch.
1488 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
1489 headers (most versions of MinGW w32api don't).
1490 (get_security_info, create_symbolic_link)
1491 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
1492 New functions.
1493 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
1494 in the argument file name.
1495 (sys_access): Call unc_volume_file_attributes only if
1496 GetFileAttributes fails with network-related error codes.
1497 (sys_rename): Diagnose renaming of a symlink when the user doesn't
1498 have the required privileges.
14ae4239 1499 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
1500 get_file_security_desc.
1501 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
1502 with addition of handling of symlinks and support for 'lstat'.
1503 If possible, get file's attributes and security information by
6dad7178
EZ
1504 handle, not by name. Produce S_IFLNK bit for symlinks, when
1505 called from 'lstat'.
1506 (stat, lstat): New functions, call 'stat_worker'.
1507 (symlink, readlink, careadlinkat): Rewritten to create and resolve
1508 symlinks when the underlying filesystem supports them.
1509
f162bcc3
PE
15102012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1511
79ea6c20
PE
1512 Fix macroexp crash on Windows with debugging (Bug#12118).
1513 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
1514 checking subscripts; problem introduced with the recent
1515 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
1516 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
1517 since it's used in non-static inline functions now.
1518
c0ce93fd
PE
1519 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
1520 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 1521
f162bcc3
PE
1522 Use C99-style 'extern inline' if available.
1523 * buffer.h (BUFFER_INLINE):
1524 * category.h (CATEGORY_INLINE):
1525 * character.h (CHARACTER_INLINE):
1526 * charset.h (CHARSET_INLINE):
1527 * composite.h (COMPOSITE_INLINE):
1528 * dispextern.h (DISPEXTERN_INLINE):
1529 * lisp.h (LISP_INLINE):
1530 * systime.h (SYSTIME_INLINE):
1531 New macro, replacing 'static inline' in this header.
1532 * buffer.h, category.h, character.h, charset.h, composite.h:
1533 * dispextern.h, lisp.h, systime.h:
1534 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1535 * alloc.c (LISP_INLINE):
1536 * buffer.c (BUFFER_INLINE):
1537 * category.c (CATEGORY_INLINE):
1538 * character.c (CHARACTER_INLINE):
1539 * charset.c (CHARSET_INLINE):
1540 * composite.c (COMPOSITE_INLINE):
1541 * dispnew.c (DISPEXTERN_INLINE):
1542 * sysdep.c (SYSTIME_INLINE):
1543 Define to EXTERN_INLINE, so that the corresponding functions
1544 are compiled into code.
1545 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
1546 (INLINE_HEADER_END): New macros.
1547 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
1548 since it's used in non-static inline functions now.
a8333d03 1549 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 1550
837b365b
GM
15512012-08-02 Glenn Morris <rgm@gnu.org>
1552
d66b744d
GM
1553 * s/: Remove empty directory.
1554
837b365b
GM
1555 * s/ms-w32.h: Move to ../nt/inc.
1556 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
1557 Update for new ms-w32.h location.
1558
13294f95
PE
15592012-08-02 Paul Eggert <eggert@cs.ucla.edu>
1560
1561 Port to Solaris 8.
1562 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
1563
90df0db3
GM
15642012-08-02 Glenn Morris <rgm@gnu.org>
1565
1566 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
1567 hard-coding the path separator.
1568
4939150c
PE
15692012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
1572 This how ASET and AREF are supposed to work, and makes
1573 it easier to think about future improvements. See
1574 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
1575 * charset.h (set_charset_attr): New function.
1576 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
1577 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
1578 (aref_addr): New function. All uses of &AREF(...) changed.
1579 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
1580 (set_hash_index): New functions. All lvalue-style uses of
1581 HASH_KEY etc. changed.
1582 * keyboard.c (set_prop): New function. All lvalue-style uses
1583 of PROP changed.
1584
947b2afd
AA
15852012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
1586
1587 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
1588 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
1589 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
1590 * nsfns.m (ns_set_name_as_filename): Likewise.
1591 * nsmenu.m (ns_update_menubar): Likewise.
1592 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
1593
4f5d0325
EZ
15942012-08-01 Eli Zaretskii <eliz@gnu.org>
1595
2008beae
EZ
1596 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
1597 Adapt to latest changes in field names of the corresponding Lisp
288479f6 1598 objects.
2008beae 1599
4f5d0325
EZ
1600 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
1601
fe3cc771
GM
16022012-08-01 Glenn Morris <rgm@gnu.org>
1603
1604 * s/msdos.h: Remove file.
1605 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
1606 * Makefile.in (S_FILE): Remove.
1607 (config_h): Remove S_FILE.
1608
c90acc54
JB
16092012-08-01 Juanma Barranquero <lekktu@gmail.com>
1610
1611 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
1612 Remove; moved to nt/config.nt.
1613
d8a05828
DA
16142012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1615
1616 Use INTERNAL_FIELD for conses and overlays.
1617 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
1618 Remove obsolete comment.
1619 (MVAR): New macro.
1620 (struct Lisp_Overlay): Use INTERNAL_FIELD.
1621 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
1622
8271d590
DA
16232012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1624
1625 Use INTERNAL_FIELD for symbols.
1626 * lisp.h (SVAR): New macro. Adjust users.
1627 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
1628 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
1629
3193acd2
DA
16302012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1631
1632 Use INTERNAL_FIELD for processes.
1633 * process.h (PVAR): New macro. Adjust style.
1634 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
1635 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
1636
3a45383a
DA
16372012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1638
1639 Use INTERNAL_FIELD for windows.
1640 * window.h (WVAR): New macro.
1641 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
1642 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
1643 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
1644 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
1645 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
1646 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1647
c1dbc63c
PE
16482012-08-01 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
1651
5c0c0e8a
GM
16522012-08-01 Glenn Morris <rgm@gnu.org>
1653
1654 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
1655 Move to configure.ac.
1656
552a99b4
JB
16572012-08-01 Juanma Barranquero <lekktu@gmail.com>
1658
1659 * makefile.w32-in (CONFIG_H): Update dependencies.
1660 (CONF_POST_H): New macro.
1661
1662 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
1663
8d8e2dfe
GM
16642012-07-31 Glenn Morris <rgm@gnu.org>
1665
bc96620a
GM
1666 * Makefile.in (S_FILE): No longer set by configure.
1667
476b1b2d
GM
1668 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
1669 is available.
1670 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
1671
b2c7a106
GM
1672 * process.h (NULL_DEVICE):
1673 * emacs.c (SEPCHAR):
1674 * editfns.c (USER_FULL_NAME): Let configure set them.
1675
d53d062a
GM
1676 * s/README, s/template.h: Remove files.
1677
4515017f
GM
1678 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
1679
8d8e2dfe
GM
1680 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
1681 Move to configure.ac.
1682
5b20b3cc
EZ
16832012-07-31 Eli Zaretskii <eliz@gnu.org>
1684
1e0afd9a
EZ
1685 * .gdbinit (xframe): Adapt to introduction of FVAR and the
1686 resulting renaming of 'struct frame' members.
1687
5b20b3cc
EZ
1688 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
1689
1690 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
1691 after introduction of FVAR.
1692
f1310128
JD
16932012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1694
79e721e0
JD
1695 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
1696
1697 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
1698 instead of compositeToPoint.
1699 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
1700
8d7c7eed 1701 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 1702
e34f7f79
DA
17032012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1704
1705 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
1706 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 1707 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
1708 (BVAR): Change to use INTERNAL_FIELD.
1709 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
1710 (KVAR): Change to use INTERNAL_FIELD.
1711 * frame.h (FVAR): New macro.
1712 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
1713 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
1714 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
1715 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
1716 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
1717
c09bfb2f
DA
17182012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1719
1720 Miscellaneous fixes for non-default X toolkits.
1721 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
1722 * xterm.c (x_frame_of_widget): Remove redundant prototype.
1723 Move under #ifdef USE_LUCID.
1724 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
1725 definition and usage to avoid warnings.
1726
14c114ae
JD
17272012-07-31 Jan Djärv <jan.h.d@swipnet.se>
1728
1729 * nsterm.m (openFiles): Fix previous checkin.
1730
3bd21e82
PE
17312012-07-31 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 * indent.c (compute_motion): Remove unused local.
1734
c1529ded
GM
17352012-07-31 Glenn Morris <rgm@gnu.org>
1736
400d5621
GM
1737 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
1738
268e2432
GM
1739 * conf_post.h [USG5_4]:
1740 Move remaining contents of s/usg5-4-common.h here.
1741 * s/usg5-4-common.h: Remove file.
1742
7552f3ee
GM
1743 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
1744 * s/irix6-5.h: Remove file.
1745
6a381852
GM
1746 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
1747 * s/darwin.h: Remove file.
1748
c1529ded
GM
1749 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
1750 * s/hpux10-20.h: Remove file, which is now empty.
1751
b429a4ee
GM
17522012-07-30 Glenn Morris <rgm@gnu.org>
1753
1754 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
1755 * Makefile.in (config_h): Add conf_post.h.
1756 * makefile.w32-in (CONFIG_H): Add conf_post.h.
1757
adff3182
JD
17582012-07-30 Jan Djärv <jan.h.d@swipnet.se>
1759
1760 * nsterm.m (ns_do_open_file): New variable.
b9031d69 1761 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
1762 (openFile, openTempFile, openFileWithoutUI, openFiles):
1763 Open files only if ns_do_open_file.
adff3182 1764
c32af1e4
PE
17652012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1766
7393bcbb
PE
1767 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
1768 This no-op macro hasn't been needed for many years.
1769 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
1770
c32af1e4
PE
1771 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
1772 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
1773 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
1774 gdb_make_enums_visible.
1775 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
1776 (DIRECTORY_SEP): Now a constant, not a macro.
1777
302fc036
EZ
17782012-07-30 Eli Zaretskii <eliz@gnu.org>
1779
1780 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
1781 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
1782
1783 * w32term.c <w32_keyboard_codepage>: Renamed from
1784 keyboard_codepage and now external. All users changed.
1785
1786 * w32term.h: Add declaration of w32_keyboard_codepage.
1787
1788 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
1789 the codepage to translate keys to Unicode. If this argument is
1790 -1, use the value returned by GetConsoleCP. All callers changed.
1791
88fb40b4
PE
17922012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1793
0aee6912
PE
1794 Update .PHONY listings in makefiles.
1795 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
1796 bootstrap-clean, distclean, maintainer-clean, versioclean,
1797 extraclean, frc.
1798
88fb40b4
PE
1799 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1800 This is a bit clearer. Fix some commentary typos.
1801
0a763bd1
GM
18022012-07-30 Glenn Morris <rgm@gnu.org>
1803
32bac6d6
GM
1804 * s/netbsd.h: Let configure include signal.h if needed.
1805 Remove file, which is now empty.
1806
b65e7c46
GM
1807 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1808 Let configure set them.
1809 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1810 No more need to undefine.
0a763bd1 1811
169304bd
AS
18122012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1813
1814 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1815 non-single-byte char when adding meta modifier. (Bug#12090)
1816
6cd7a139
DA
18172012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1818
1819 Convert safe_call to use variable number of arguments.
1820 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1821 (safe_call2): Fix comment.
1822 * lisp.h (safe_call): Adjust prototype.
1823 * coding.c (encode_coding_object): Change to use safe_call2.
1824 * xfaces.c (merge_face_heights): Change to use safe_call1.
1825
d34d6ffc
GM
18262012-07-30 Glenn Morris <rgm@gnu.org>
1827
7b8a48e4 1828 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1829 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1830
d34d6ffc
GM
1831 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1832 Remove empty files.
1833
03a660a6
PE
18342012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1835
1836 Export to GDB most of lisp.h's remaining object-like macros.
1837 * lisp.h (min, max): Move earlier, because they're used earlier now.
1838 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1839 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1840 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1841 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1842 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1843 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1844 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1845 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1846 Now constants, for GDB. They need not be macros.
1847 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1848 Now constants, for GDB, as well as macros, for static initializers.
1849 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1850 Move to after the definition of struct Lisp_Char_Table,
1851 since the former now needs that type defined.
1852 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1853 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1854 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1855 New enums, for gdb_make_enums_visible.
1856 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1857 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1858 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1859 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1860 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1861 enum maxargs, enum MAX_ALLOCA.
1862 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1863 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1864 no longer needed, now that they are done in lisp.h.
1865
e499d0ee
DA
18662012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1867
1868 Cleanup string bytes checking.
1869 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1870 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1871 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1872 (check_sblock, compact_small_strings): Simplify.
1873
d5040d2d
PE
18742012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1875
1876 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1877 These macros are confusing and no longer need to be defined, as
1878 the enum values now suffice. All uses replaced with definiens.
1879 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1880
7f259ae6
JB
18812012-07-29 Juanma Barranquero <lekktu@gmail.com>
1882
1883 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1884 ($(BLD)/w32console.$(O)): Update dependencies.
1885
7e63e0c3
DA
18862012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1887
1888 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1889 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1890 time. Adjust users.
1891 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1892
ffd817eb
JD
18932012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1894
1895 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1896 setting sitelisp (Bug#12010).
1897
417a7a0e
EZ
18982012-07-29 Eli Zaretskii <eliz@gnu.org>
1899
14ae4239 1900 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1901
1902 * w32heap.c (cache_system_info):
1903 * w32.c (sys_rename):
1904 * w32proc.c (find_child_console, sys_kill): All users changed.
1905
387d4d92
PE
19062012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1907
1908 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1909
55a6cca6
EZ
19102012-07-29 Eli Zaretskii <eliz@gnu.org>
1911
1912 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1913
dbcf001c
DA
19142012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1915
1916 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1917 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1918 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1919
e2688e4a
DA
19202012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1921
1922 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1923 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1924 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1925 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1926 (replace_range, replace_range_2, del_range_2): Change to eassert.
1927 * marker.c (byte_char_debug_check): Adjust style.
1928
b46a6a83
PE
19292012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1932 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1933 long-ago-commented-out code that talks about "WIN32".
1934 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1935 All uses changed.
1936
e32a5799
PE
19372012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1938
1939 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1940 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1941 Simplify by using alignof.
1942 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1943 * lisp.h: Include <stdalign.h>.
1944 (GCALIGNMENT): New macro and constant.
1945 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1946 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1947 (stdalign): New macro, if not already defined.
1948
df81cd29
EZ
19492012-07-28 Eli Zaretskii <eliz@gnu.org>
1950
01bd1b0d
EZ
1951 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1952 * w32inevt.c: Include w32inevt.h.
1953 (w32_read_console_input): New inline function, calls either
1954 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1955 w32_console_unicode_input.
1956 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1957 (w32_kbd_patch_key, key_event): Use the codepage returned by
1958 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1959 (key_event): use uChar.UnicodeChar only if
1960 w32_console_unicode_input is non-zero.
1961
1962 * w32console.c: Include w32heap.h.
1963 <w32_console_unicode_input>: New global variable.
1964 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1965 family of Windows, zero otherwise.
1966
1967 * w32inevt.h: Declare w32_console_unicode_input.
1968
df81cd29
EZ
1969 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1970 --without-x. (Bug#11742)
1971
c20fdd9e
PE
19722012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 Adjust GDB to reflect pvec_type changes (Bug#12036).
1975 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1976 2012-07-04 changes to pseudovector representation.
1977 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1978
32770973 19792012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1980
1981 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1982 bus address.
1983 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1984
3438fe21
EZ
19852012-07-27 Eli Zaretskii <eliz@gnu.org>
1986
bcfbc9de
EZ
1987 * alloc.c (listn): Fix the order the arguments are consed onto the
1988 list.
1989
3438fe21
EZ
1990 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1991 enumeration constants, as PURE and HEAP are too general, and clash
1992 with other headers and sources, such as gmalloc.c and the
1993 MS-Windows system headers. All users changed.
1994
eeaea515
DA
19952012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1996
1997 Revert last save_excursion_save and save_excursion_restore changes.
1998 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1999 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
2000
073c88c2
DA
20012012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2002
2003 Fix recently-introduced typos in Windows port.
2004 Reported by Martin Rudalics <rudalics@gmx.at>.
2005 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 2006 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 2007
4706125e
PE
20082012-07-27 Paul Eggert <eggert@cs.ucla.edu>
2009
2010 Improve GDB symbol export (Bug#12036).
2011 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
2012 arms of an 'if', not using conditional expressions; otherwise GDB
2013 complains about the types in the unevaluated arm when the argument
2014 is an integer literal.
2015 (xgetint): Simplify expression.
2016 * alloc.c (gdb_make_enums_visible): New constant. This ports to
2017 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
2018 Zaretskii in <http://bugs.gnu.org/12036#13>.
2019 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
2020 needed now that we have gdb_make_enums_visible.
2021 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
2022 (enum enum_USE_LSB_TAG):
2023 New enum types, packaging up enums that need to be exported to GDB.
2024
694b6c97
DA
20252012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2026
2027 Utility function to make a list from specified amount of objects.
2028 * lisp.h (enum constype): New datatype.
2029 (listn): New prototype.
2030 * alloc.c (listn): New function.
2031 (Fmemory_use_count, syms_of_alloc): Use it.
2032 * buffer.c (syms_of_buffer): Likewise.
2033 * callint.c (syms_of_callint): Likewise.
2034 * charset.c (define_charset_internal): Likewise.
2035 * coding.c (syms_of_coding): Likewise.
2036 * keymap.c (syms_of_keymap): Likewise.
2037 * search.c (syms_of_search): Likewise.
2038 * syntax.c (syms_of_syntax): Likewise.
2039 * w32.c (init_environment): Likewise.
2040 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
2041 * xdisp.c (syms_of_xdisp): Likewise.
2042 * xfns.c (syms_of_xfns): Likewise.
2043
6195f384
DA
20442012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2045
2046 Fast save_excursion_save and save_excursion_restore.
2047 * lisp.h (struct Lisp_Excursion): New data type.
2048 (PVEC_EXCURSION): New pseudovector type.
2049 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
2050 to deal with it. Adjust comments.
2051 (init_marker, attach_marker): New prototype.
2052 (unchain_marker): Adjust prototype.
2053 * marker.c (attach_marker): Change to global.
2054 (init_marker): New function.
2055 * alloc.c (Fmake_marker, build_marker): Use it.
2056 (build_marker): More easserts.
2057 (mark_object): Handle struct Lisp_Excursion.
2058 * editfns.c (save_excursion_save, save_excursion_restore):
2059 Reimplement to use struct Lisp_Excursion. Add comments.
2060
5eceb8fb
PE
20612012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 Fix export of symbols to GDB (Bug#12036).
2064 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
2065 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
2066 emacs.c, as this is a more-suitable home. Had this been done earlier
2067 the fix for 12036 would have avoided some of the problems noted in
2068 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
2069 would have been more obvious.
562157c8
PE
2070 * emacs.c: Do not include <verify.h>; no longer needed.
2071 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
2072 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
2073 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2074 Remove; now done in lisp.h.
2075 * lisp.h (PUBLISH_TO_GDB): New macro.
2076 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
2077 (DATA_SEG_BITS): Use it.
2078 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
2079 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
2080 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
2081 not be usable in #if. This simplifies things.
2082
d6749401
JB
20832012-07-26 Juanma Barranquero <lekktu@gmail.com>
2084
2085 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
2086
1781b9e9
PE
20872012-07-26 Paul Eggert <eggert@cs.ucla.edu>
2088
d89518db 2089 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
2090 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
2091 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
2092 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
2093 Adjust to changes in lisp.h and emacs.c, by using
2094 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
2095 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
2096 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
2097 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
2098 instead of gdb_valbits.
2099 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
2100 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
2101 instead of gdb_array_mark_flag.
2102 (xboolvector): Get size from $->size, not $->header.size.
2103 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
2104 (xreload, hook-run, hookpost-run): Remove.
2105 * emacs.c: Include <verify.h>.
2106 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
2107 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
2108 Remove.
2109 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
2110 (gdb_USE_LSB_TAG): New enum constants.
2111 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
2112 Also define these as enum constants, so they're visible to GDB.
2113 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
2114 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
2115 as constants, so they're visible to GDB.
2116 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
2117 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
2118 Now enum constants, not macros, so they're visible to GDB.
2119 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
2120 more convenient now. All uses changed.
2121 (VALMASK) [USE_LSB_TAG]: Also define in this case.
2122 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
2123
3628596a
DA
21242012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
2125
2126 Explicitly free restriction data that are not needed anymore.
2127 * editfns.c (save_restriction_restore): Free restriction data.
2128
7abaf5cc
SM
21292012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
2130
2131 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
2132 add argument, tune behavior, and adjust all callers.
2133
71f88e00
PE
21342012-07-25 Paul Eggert <eggert@cs.ucla.edu>
2135
2136 Use typedef for EMACS_INT, EMACS_UINT.
2137 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
2138 than macros. This simplifies debugging in the usual case, since
2139 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
2140 and it allows expressions involving EMACS_INT casts.
2141 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
2142
57ec3034
JD
21432012-07-25 Jan Djärv <jan.h.d@swipnet.se>
2144
2145 * nsterm.m (ns_read_socket): Return early if there is a modal
2146 window (Bug#12043).
2147
8137e7b3
MR
21482012-07-25 Martin Rudalics <rudalics@gmx.at>
2149
2150 * frame.c (Fredirect_frame_focus): In doc-string don't mention
2151 that FOCUS-FRAME can be omitted.
2152
04e9897c
DA
21532012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
2154
2155 Adjust buffer text indirection counters at the end of Fkill_buffer.
2156 * buffer.c (Fkill_buffer): Adjust indirection counters when the
2157 buffer is definitely dead. This should really fix an issue reported
2158 by Christoph Scholtes again. (Bug#12007).
2159 (init_buffer_once): Initialize indirection counters of
2160 buffer_defaults and buffer_local_symbols (for sanity and safety).
2161
8a0484e1
EZ
21622012-07-24 Eli Zaretskii <eliz@gnu.org>
2163
2164 * xdisp.c (init_iterator): Don't compute dimensions of truncation
2165 and continuation glyphs on tooltip frames, leave them at zero.
2166 Avoids continued lines in tooltips. (Bug#11832)
2167
fa691a83
DA
21682012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
2169
2170 Simplify copy_overlay.
04e9897c 2171 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
2172 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
2173
436bc8e0
EZ
21742012-07-23 Eli Zaretskii <eliz@gnu.org>
2175
2176 * print.c (print_object): Don't crash when a frame's name is nil
2177 or invalid. (Bug#12025)
2178
2179 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
2180 it signals an error when a tooltip frame is being created.
2181
d7a7fda3
DA
21822012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
2183
2184 Cleanup miscellaneous objects allocation and initialization.
2185 * alloc.c (allocate_misc): Change to static. Add argument to
2186 specify the subtype. Adjust comment and users.
2187 (build_overlay): New function.
2188 * buffer.c (copy_overlays, Fmake_overlay): Use it.
2189 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
2190 (allocate_misc): Remove prototype.
2191 (build_overlay): Add prototype.
2192
21932012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
2194
2195 Swap buffer text indirection counters in Fbuffer_swap_text.
2196 * buffer.c (Fbuffer_swap_text): Swap indirections too.
2197 This avoids crash reported by Christoph Scholtes at
2198 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
2199
9d7fa573
JD
22002012-07-22 Jan Djärv <jan.h.d@swipnet.se>
2201
2202 * nsmenu.m (Popdown_data): New struct.
2203 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
2204 free Popdown_data.
2205 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
2206 (initWithContentRect): Make imgView and contentView non-static
2207 and autorelease them. Also autorelease img and matrix (Bug#12005).
2208 (dealloc): Remove (Bug#12005).
2209
0dd6d66d
DA
22102012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2211
2212 Adjust consing_since_gc when objects are explicitly freed.
2213 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
2214 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
2215 (free_cons, free_misc): Subtract object size from consing_since_gc.
2216
d36d71df
DA
22172012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
2218
2219 Simplify and cleanup markers positioning code.
2220 * marker.c (attach_marker): More useful eassert.
2221 (live_buffer, set_marker_internal): New function.
2222 (Fset_marker, set_marker_restricted): Use set_marker_internal.
2223 (set_marker_both, set_marker_restricted_both): Use live_buffer.
2224
fb9ea40f
PE
22252012-07-22 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
2228 as it's limited by the amount of memory, not by INT_MAX.
2229
2d5c5f7d
EZ
22302012-07-21 Eli Zaretskii <eliz@gnu.org>
2231
07fb592e
EZ
2232 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
2233 in special-event-map. See the discussion at
2234 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
2235 for the reasons.
2236
37a9eac8 2237 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
2238 info.dwItemData. Fixes crashes on 64-bit Windows.
2239 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 2240
c4328746
JD
22412012-07-21 Jan Djärv <jan.h.d@swipnet.se>
2242
2243 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 2244 (conversationIdentifier): Return value is NSInteger.
784051c4 2245 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 2246
6e5d1c12
CY
22472012-07-21 Chong Yidong <cyd@gnu.org>
2248
2249 * window.c (decode_any_window): Signal an error if the window is
2250 on a dead frame (Bug#11984).
2251
9928463d
DA
22522012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2253
2254 Add indirection counting to speed up Fkill_buffer.
2255 * buffer.h (struct buffer): New member.
2256 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
2257 (Fmake_indirect_buffer): Set indirection counter to -1, increment
2258 base buffer indirection counter.
2259 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
2260 (Fkill_buffer): Adjust indirection counters as needed, don't walk
2261 through buffer list if indirection counter is 0.
2262
f8643a6b
DA
22632012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2264
2265 Extend the value returned by Fgarbage_collect with heap statistics.
2266 * alloc.c (Qheap): New symbol.
2267 (syms_of_alloc): DEFSYM it.
2268 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
2269 (Fmemory_free): Remove.
2270 (syms_of_alloc): Don't defsubr it.
2271 * buffer.c (Fcompact_buffer): Remove.
2272 (syms_of_buffer): Don't defsubr it.
2273
dac616ff
DA
22742012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2275
2276 Make maybe_gc inline.
2277 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
2278 * lisp.h (consing_since_gc, gc_relative_threshold)
2279 (memory_full_cons_threshold): Revert declaration.
2280 (maybe_gc): Remove prototype, define as inline.
2281 * alloc.c: Remove old commented-out code.
2282 (consing_since_gc, gc_relative_threshold)
2283 (memory_full_cons_threshold): Revert to global.
2284 (maybe_gc): Remove.
2285
d7ea76b4
DA
22862012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2287
2288 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
2289 * lisp.h (build_unibyte_string): New function.
2290 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
2291 * sysdep.c, w32fns.c, xfns.c: Use it.
2292 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
2293 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
2294 Adjust users accordingly.
2295 * font.h (font_open_by_name): Adjust prototype.
2296
765e61e3
DA
22972012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
2298
2299 Cleanup calls to Fgarbage_collect.
2300 * lisp.h (maybe_gc): New prototype.
2301 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2302 Remove declarations.
2303 * alloc.c (maybe_gc): New function.
2304 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
2305 Make them static.
2306 * bytecode.c (MAYBE_GC): Use maybe_gc.
2307 * eval.c (eval_sub, Ffuncall): Likewise.
2308 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
2309 to avoid dependency from auto-save feature.
2310
52b852c7
PE
23112012-07-19 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
2314 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
2315 'for_each_per_buffer_object_at'.
2316 All uses changed. It's better to use upper-case for macros that
2317 cannot be implemented as functions, to give the reader a clue
2318 that they're special.
2319
5db81e33
SM
23202012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
2321
2322 * alloc.c (Fgarbage_collect): Tweak docstring.
2323
5b835e1d
DA
23242012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2325
2326 Tweak the value returned from Fgarbage_collect again.
2327 * alloc.c (Fgarbage_collect): New return value, as confirmed in
2328 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
2329 Adjust documentation.
2330 (total_vector_bytes): Rename to total_vector_slots, adjust
2331 accounting.
2332 (total_free_vector_bytes): Rename to total_free_vector_slots,
2333 adjust accounting.
2334 (Qstring_bytes, Qvector_slots): New symbols.
2335 (syms_of_alloc): DEFSYM them.
2336
9cd47b72
DA
23372012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2338
2339 Buffer compaction primitive which may be used from Lisp.
2340 * buffer.c (compact_buffer, Fcompact_buffer): New function.
2341 (syms_of_buffer): Register Fcompact_buffer.
2342 * alloc.c (Fgarbage_collect): Use compact_buffer.
2343 * buffer.h (compact_buffer): New prototype.
2344 (struct buffer_text): New member.
2345
d17337e5
DA
23462012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
2347
2348 New macro to iterate over all buffers, miscellaneous cleanups.
2349 * lisp.h (all_buffers): Remove declaration.
2350 * buffer.h (all_buffers): Add declaration, with comment.
2351 (for_each_buffer): New macro.
2352 * alloc.c (Fgarbage_collect, mark_object): Use it.
2353 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
2354 (init_buffer): Likewise.
2355 * data.c (Fset_default): Likewise.
2356 * coding.c (code_conversion_restore): Remove redundant check
2357 for dead buffer.
2358 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
2359
60cfd278
AS
23602012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2361
2362 Fix bug that created negative-length intervals.
2363 * intervals.c (merge_interval_right, merge_interval_left):
2364 Do not zero out this interval if it is absorbed by its children,
2365 as this interval's total length doesn't change in that case. See
2366 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
2367
d06714cb
PE
23682012-07-18 Paul Eggert <eggert@cs.ucla.edu>
2369
83713154
PE
2370 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
2371 when invoking (make-bool-vector N t) and N is a positive
2372 multiple of 8 -- the last 8 bits were mistakenly cleared.
2373
d06714cb
PE
2374 Remove some struct layout assumptions in bool vectors.
2375 * alloc.c (bool_header_size): New constant.
2376 (header_size, word_size): Move earlier, as they're now used earlier.
2377 Use 'word_size' in a few more places, where it's appropriate.
2378 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
2379 padding before the data member of a bool vector.
2380 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
2381 than doing the check by hand with an abort ().
2382
464d5a5e
SM
23832012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2384
5fbc0409
SM
2385 * eval.c (Fdefvar): Don't check constants since we only set the var if
2386 it's not yet defined anyway (bug#11904).
2387
464d5a5e
SM
2388 * lisp.h (last_undo_boundary): Declare new var.
2389 * keyboard.c (command_loop_1): Set it.
2390 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
2391 were auto-added by the command loop (bug#11774).
2392
8dc2e44a
AS
23932012-07-18 Andreas Schwab <schwab@linux-m68k.org>
2394
2395 * w32font.c (Qsymbol): Remove local definition.
2396 (syms_of_w32font): Don't DEFSYM it.
2397
169925ec
DA
23982012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2399
2400 Fix sweep_vectors to handle large bool vectors correctly.
2401 * alloc.c (sweep_vectors): Account total_vector_bytes for
2402 bool vectors larger than VBLOCK_BYTES_MAX.
2403
5fbfb018
CY
24042012-07-18 Chong Yidong <cyd@gnu.org>
2405
2406 * frame.c (x_set_frame_parameters): Revert bogus change introduced
2407 in 2012-05-25 commit by Paul Eggert (Bug#11738).
2408
3ab6e069
DA
24092012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2410
2411 Return more descriptive data from Fgarbage_collect.
2412 Suggested by Stefan Monnier in
2413 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
2414 * alloc.c (bounded_number): New function.
2415 (total_buffers, total_vectors): New variable.
2416 (total_string_size): Rename to total_string_bytes, adjust users.
2417 (total_vector_size): Rename to total_vector_bytes, adjust users.
2418 (sweep_vectors): Account total_vectors and total_vector_bytes.
2419 (Fgarbage_collect): New return value. Adjust documentation.
2420 (gc_sweep): Account total_buffers.
2421 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
2422 (VECTOR_SIZE): Remove.
2423 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
2424 (Qinterval, Qmisc): New symbols.
2425 (syms_of_data): Initialize them.
2426 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
2427 (Qcons, Qbuffer): New declarations.
2428
6d02fe5b
PE
24292012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 * alloc.c (Fmemory_free): Account for memory-free's own storage.
2432 Round up, not down. Improve doc.
2433
b7ffe040
DA
24342012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2435
2436 Restore old code in allocate_string_data to avoid Faset breakage.
2437 Reported by Julien Danjou <julien@danjou.info> in
2438 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
2439 * alloc.c (allocate_string_data): Restore old code with minor
2440 adjustments, fix comment to explain this subtle issue.
2441
4dc7c8d5
SM
24422012-07-17 Eli Zaretskii <eliz@gnu.org>
2443
2444 Remove FILE_SYSTEM_CASE.
2445 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
2446
2447 * fileio.c (FILE_SYSTEM_CASE): Don't define.
2448 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
2449 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
2450 call-process-region passes it through expand-file-name.
2451
2452 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
2453
24542012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2455
2456 Fix crash when creating indirect buffer (Bug#11917)
2457 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
2458 Don't handle unbound variables specially if non-zero.
2459 (Fbuffer_local_variables): Pass zero.
2460 (clone_per_buffer_values): Pass non-zero.
2461
24622012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2463
2464 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
2465 to make the loop interruptible.
2466
24672012-07-17 Andreas Schwab <schwab@linux-m68k.org>
2468
2469 * gnutls.c (emacs_gnutls_handshake): Only retry if
2470 GNUTLS_E_INTERRUPTED.
2471
cce7fefc
DA
24722012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2473
2474 Cleanup and convert miscellaneous checks to eassert.
2475 * alloc.c (mark_interval): Fix comment, partially rephrase
2476 old comment from intervals.h (see below).
2477 * intervals.c (find_interval, adjust_intervals_for_insertion)
2478 (delete_interval, adjust_intervals_for_deletion)
2479 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
2480 Convert to eassert.
2481 (adjust_intervals_for_insertion, make_new_interval):
2482 Remove obsolete and unused code.
2483 * intervals.h (struct interval): Remove obsolete comment.
2484 * textprotp.c (erase_properties): Remove unused code.
2485 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
2486 (Fremove_list_of_text_properties): Convert to eassert.
2487
9ea10cc3
CY
24882012-07-17 Chong Yidong <cyd@gnu.org>
2489
2490 * editfns.c (Finsert_char): Doc fix.
2491
3900d5de
DA
24922012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2493
2494 Fix previous change to make Fmemory_free always accurate.
2495 * alloc.c (make_interval): Update total_free_intervals.
2496 (make_float): Likewise for total_free_floats.
2497 (free_cons, Fcons): Likewise for total_free_conses.
2498 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
2499 Likewise for total_free_vector_bytes.
2500 (Fmake_symbol): Likewise for total_free_symbols.
2501 (bytes_free): Remove.
2502
7098646f
DA
25032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2504
2505 Simple free memory accounting feature.
2506 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
2507 (sweep_vectors): Accumulate size of free vectors.
2508 (Fgarbage_collect): Setup bytes_free.
2509 (Fmemory_free): New function.
2510 (syms_of_alloc): Register it.
2511
22657b40
DA
25122012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
2513
2514 Cleanup overlays checking.
2515 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
2516 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
2517 eassert and OVERLAYP.
2518 (sort_overlays): Change to use OVERLAYP.
2519
ddfc8813
RK
25202012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
2521
2522 * editfns.c (Finsert_char): Make it interactive, and make the
2523 second arg optional. Copy interactive spec and docstring from
2524 ucs-insert.
2525
7c26cf3c
PE
25262012-07-17 Paul Eggert <eggert@cs.ucla.edu>
2527
2528 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
2529 Unlike the other wrapped functions, fabs has an unspecified
2530 effect on errno.
2531
5d127af9
JD
25322012-07-16 Jan Djärv <jan.h.d@swipnet.se>
2533
2534 * nsterm.m (keyDown): Interpret flags without left/right bits
2535 as the left key (Bug#11670).
2536
6a0dd1d7
DA
25372012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2538
2539 Remove empty and useless init functions.
2540 * lisp.h (init_character_once, init_fns, init_image)
2541 (init_filelock, init_sound): Remove prototype.
2542 * character.c (init_character_once): Remove.
2543 * filelock.c (init_filelock): Likewise.
2544 * fns.c (init_fns): Likewise.
2545 * image.c (init_image): Likewise.
2546 * sound.c (init_sound): Likewise.
2547 * emacs.c (main): Adjust accordingly.
2548
7a6136fd
DA
25492012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
2550
2551 * gtkutil.h: Tiny cleanups.
2552 (use_old_gtk_file_dialog): Remove useless declaration.
2553 (xg_uses_old_file_dialog): Add suggested const attribute.
2554
ce811ad9
EZ
25552012-07-15 Eli Zaretskii <eliz@gnu.org>
2556
2557 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
2558 (bidi_paragraph_init): Use it to limit search forward for a strong
2559 directional character in abnormally large paragraphs full of
2560 neutral or weak characters. (Bug#11943)
2561
c9adfeaa
SF
25622012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
2563
2564 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
2565 the toolbar (Bug#9451).
2566 (xg_make_tool_item): Give the widget event box a transparent
2567 background.
2568
fff62aa9
DA
25692012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2570
2571 Cleanup basic allocation variables and functions.
2572 * alloc.c (ignore_warnings, init_intervals, init_float)
2573 (init_cons, init_symbol, init_marker): Remove.
2574 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
2575 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
2576 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
2577 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
2578 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
2579 (staticidx, init_alloc_once, init_strings, free_ablock):
2580 Remove redundant initialization.
2581 * fns.c (init_weak_hash_tables): Remove.
2582 * lisp.h (init_weak_hash_tables): Remove prototype.
2583
9730daca
DA
25842012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
2585
2586 Use zero_vector where appropriate.
2587 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
2588 accordingly.
2589 * lisp.h (zero_vector): New declaration.
2590 * font.c (null_vector): Remove.
2591 (syms_of_font): Remove initialization and staticpro.
2592 (font_list_entities, font_find_for_lface): Change to use zero_vector.
2593 * keymap.c (Faccessible_keymaps): Likewise.
2594
2e2d2a13
LL
25952012-07-15 Leo Liu <sdl.web@gmail.com>
2596
2597 * fringe.c: Fix typo in comments.
2598
cd276f6e
LL
25992012-07-14 Leo Liu <sdl.web@gmail.com>
2600
2601 * fringe.c: Add a new bitmap exclamation-mark.
2602
5a1131d9
EZ
26032012-07-14 Eli Zaretskii <eliz@gnu.org>
2604
2605 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
2606
2607 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
2608 (HAVE_MENUS): Don't define, defined by editing config.in with
2609 msdos/sed2v2.inp.
2610 (GMALLOC_INHIBIT_VALLOC): Don't define.
2611 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
2612
22e983b7
JB
26132012-07-14 Juanma Barranquero <lekktu@gmail.com>
2614
2615 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
2616
5b3f250f
GM
26172012-07-14 Glenn Morris <rgm@gnu.org>
2618
2619 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
2620 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
2621 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
2622
33d63ff4
GM
26232012-07-13 Glenn Morris <rgm@gnu.org>
2624
5b633342
GM
2625 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
2626
33d63ff4
GM
2627 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
2628 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
2629
b55b9f85
JD
26302012-07-13 Jan Djärv <jan.h.d@swipnet.se>
2631
0dc8cf50
JD
2632 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
2633 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
2634 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
2635 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
2636 where appropriate.
2637 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
2638 as boolean expression.
2639 (x_set_window_size): Remove unused variable toolbar.
2640 (ns_get_color_default, ns_mod_to_lisp): Remove.
2641 (ns_mouse_position): Remove unused variables xchar and ychar.
2642 (ns_compute_glyph_string_overhangs): Remove unused variable face.
2643 (ns_set_vertical_scroll_bar): Remove unused variable count.
2644 (ns_delete_terminal): Remove unused variable i.
2645 (ns_term_init): Remove unused variables r, g and b.
2646 (mouseDown): Remove unused variable window.
2647 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
2648 (initFrameFromEmacs): Remove unused variable vbextra.
2649 (mouseEntered): Remove unused variables p and dpyinfo.
2650 (mouseExited): Remove unused variables p and r.
2651 (ns_define_frame_cursor, ns_clear_frame_area)
2652 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
2653 (menuDown): Assign [sender tag] to variable and cast the variable.
2654
2655 * nsterm.h (menuDown): Add id as type to argument sender.
2656 (ns_display_info_for_name): Add Lisp_Object argument.
2657 (ns_term_init): Add Lisp_Object argument.
2658 (ns_map_event_to_object): Add void argument.
2659 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
2660 prototype with arguments and only declare if __OBJC__.
2661 (nxatoms_of_nsselect): Add void argument.
2662 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
2663 (ns_alloc_autorelease_pool): Add void argument.
2664 (ns_release_autorelease_pool): Add void* argument.
2665 (ns_get_defaults_value): Add const char* argument.
2666
2667 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
2668 (initFromContents): Use SSDATA where appropriate.
2669 (ns_update_menubar): Add braces to ambigous if-else.
2670 (initWithTitle): Put () around assignment in if statement.
2671 (ns_menu_show): Remove unused variables window and keymap.
2672 (update_frame_tool_bar): Remove unused variable selected_p.
2673 (initWithContentRect): Remove unused variable this_cmd_name.
2674
2675 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
2676 appropriate.
2677 (setXBMColor): Remove unused variable len.
2678 (setPixmapData): Put () around assignment in loop statement.
2679
2680 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
2681 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
2682 where appropriate.
2683 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
2684 around assignment in loop statement.
2685 (nsfont_open): Remove unused variable i.
2686 (nsfont_open): Remove unused variable len.
2687 (nsfont_draw): Remove unused variable cs.
2688
2689 * nsfns.m (x_set_icon_name, ns_set_name_internal)
2690 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
2691 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
2692 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
2693 (Fns_font_name, Fns_perform_service)
2694 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
2695 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
2696 (ns_set_name): Remove unused variable view.
2697 (x_set_menu_bar_lines): Remove unused variable olines.
2698 (x_set_tool_bar_lines): Remove unused variable root_window.
2699 (Fns_list_colors): Put () around assignment in while statement.
2700 (Fns_perform_service): Remove unused variable len.
2701 (Fns_display_usable_bounds): Remove unused variable top.
2702 (syms_of_nsfns): Remove unused variable i.
2703
b55b9f85
JD
2704 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
2705 memcpy (Bug#11907).
2706
ed9265fc 27072012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
2708
2709 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
2710 and free it with DestroyExceptionInfo (Bug#11558).
2711
ef099b57
JB
27122012-07-13 Juanma Barranquero <lekktu@gmail.com>
2713
2714 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
2715 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
2716 Set here, not in nt/config.nt.
2717
ea814a5d
EZ
27182012-07-13 Eli Zaretskii <eliz@gnu.org>
2719
2720 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
2721 cursor overflow into the last glyph on display line when the right
2722 fringe is off. (Bug#11832)
2723
1a952767
PE
27242012-07-13 Paul Eggert <eggert@cs.ucla.edu>
2725
2726 * xdisp.c (produce_special_glyphs): Now static.
2727 * dispextern.h (produce_special_glyphs): Remove decl.
2728
983188fd
GM
27292012-07-13 Glenn Morris <rgm@gnu.org>
2730
8d7c7eed 2731 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
2732 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
2733
983188fd
GM
2734 * s/usg5-4-common.h (USG, USG5):
2735 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
2736 * s/sol2-6.h (SOLARIS2):
2737 * s/irix6-5.h (IRIX6_5):
2738 * s/hpux10-20.h (USG, USG5, HPUX):
2739 * s/gnu-linux.h (USG, GNU_LINUX):
2740 * s/freebsd.h (BSD_SYSTEM):
2741 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
2742 * s/cygwin.h (CYGWIN):
2743 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
2744 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
2745
d1e68667 27462012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2747
2748 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 2749
6de0e799
GM
27502012-07-13 Glenn Morris <rgm@gnu.org>
2751
739ae010
GM
2752 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
2753
dbee5793
GM
2754 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
2755
6de0e799
GM
2756 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
2757 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
2758
b82da769
GM
27592012-07-12 Glenn Morris <rgm@gnu.org>
2760
4fae5a7a 2761 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
2762
2763 * process.c (init_process_emacs): Rename from init_process.
2764 The old name is also the name of a Mach system call.
2765 * lisp.h, emacs.c: Update for this name change.
2766 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
2767 longer needed.
2768
5a979817
EZ
27692012-07-12 Eli Zaretskii <eliz@gnu.org>
2770
2771 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
2772 memmove call that removes glyphs covered by the left truncation
2773 glyph. Improve commentary.
2774 (display_line): Fix display of continuation glyphs on GUI frames
2775 when the right fringe is turned off and variable-size fonts are
2776 used in the window. Move the code that appends a stretch glyph to
2777 produce_special_glyphs, so that it could be used for truncation
2778 and continuation glyphs alike.
2779 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
2780 glyph of a suitably computed width, to align the special glyphs at
2781 the window margin. Code moved from display_line. (Bug#11832)
2782
3e91a053
GM
27832012-07-12 Glenn Morris <rgm@gnu.org>
2784
ba9e4b84
GM
2785 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
2786
2787 * s/gnu-linux.h, s/hpux10-20.h:
2788 Do not unconditionally define HAVE_XRMSETDATABASE.
2789
3e91a053
GM
2790 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
2791
b300b1f4
PE
27922012-07-12 Paul Eggert <eggert@cs.ucla.edu>
2793
2794 Fix typos that broke OS X build.
2795 Reported by Randal L. Schwartz in
2796 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
2797 * nsterm.m (ns_timeout): Add missing local decl.
2798 (ns_get_color): snprintf -> sprintf, to fix typo.
2799
6e777848
GM
28002012-07-12 Glenn Morris <rgm@gnu.org>
2801
3f922c37
GM
2802 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2803 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2804 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2805 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2806
0ab7b23a
GM
2807 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2808 Move PTY_OPEN to configure.
2809
6e777848
GM
2810 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2811 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2812 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2813
4a7edc24
DA
28142012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2815
2816 Use empty_unibyte_string where applicable.
2817 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2818 * lread.c (read1): Likewise.
2819 * xsettings.c (syms_of_xsettings): Likewise.
2820
308aab79
GM
28212012-07-12 Glenn Morris <rgm@gnu.org>
2822
42bd1719
GM
2823 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2824 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2825 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2826 * s/hpux10-20.h (RUN_TIME_REMAP):
2827 * s/bsd-common.h (TABDLY): Move to configure.
2828
2829 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2830
2831 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2832
ea0bbd17 2833 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2834 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2835
2836 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2837
308aab79
GM
2838 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2839 * s/template.h: Move NARROWPROTO to configure.
2840
ee1cf5cf
GM
28412012-07-11 Glenn Morris <rgm@gnu.org>
2842
30fe9bf4
GM
2843 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2844 unused since 2011-01-17 change to systty.h.
2845
ee1cf5cf
GM
2846 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2847 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2848 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2849
63e47e07
PE
28502012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2851
2852 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2853
c43fb4c3
GM
28542012-07-11 Glenn Morris <rgm@gnu.org>
2855
2856 * s/darwin.h, s/gnu-linux.h, s/template.h:
2857 Move INTERRUPT_INPUT to configure.
2858
e8df9267
DA
28592012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2860
2861 Minor adjustments to interning code.
2862 * lisp.h (intern, intern_c_string): Redefine as static inline
2863 wrappers for intern_1 and intern_c_string_1, respectively.
2864 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2865 * lread.c (intern_1, intern_c_string_1, oblookup):
2866 Simplify Vobarray checking.
e8df9267
DA
2867 * font.c (font_intern_prop): Likewise. Adjust comment.
2868 * w32font.c (intern_font_name): Likewise.
2869
34348bd4
AS
28702012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2871
d96a1e0c
AS
2872 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2873
34348bd4
AS
2874 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2875 of Fcar/Fcdr if possible.
2876 * font.c (check_otf_features): Likewise.
2877 * fontset.c (Fnew_fontset): Likewise.
2878 * gnutls.c (Fgnutls_boot): Likewise.
2879 * minibuf.c (read_minibuf): Likewise.
2880 * msdos.c (IT_set_frame_parameters): Likewise.
2881 * xmenu.c (Fx_popup_dialog): Likewise.
2882 * w32menu.c (Fx_popup_dialog): Likewise.
2883
c8add24e
GM
28842012-07-11 Glenn Morris <rgm@gnu.org>
2885
4b575b3c
GM
2886 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2887 since nothing has defined it on these platforms.
2888
09f4e3b0
GM
2889 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2890 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2891
172bedef
GM
2892 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2893 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2894 Move CLASH_DETECTION to configure.
2895
249685df
GM
2896 * s/gnu.h: Remove file, which is now empty.
2897
c8add24e
GM
2898 * s/gnu.h, s/gnu-linux.h:
2899 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2900
b41253a3
JW
29012012-07-11 John Wiegley <johnw@newartisans.com>
2902
2903 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2904 function attribute, so we only use it if it exists in the
2905 compiler.
2906
d923b542
DA
29072012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2908
2909 Avoid call to strlen in fast_c_string_match_ignore_case.
2910 * search.c (fast_c_string_match_ignore_case): Change to use
2911 length argument. Adjust users accordingly.
2912 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2913
5ebbef1d
PE
29142012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2915
bb352260
PE
2916 Assume mkdir, rmdir.
2917 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2918 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2919
57054ddd
PE
2920 Assume rename.
2921 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2922
b747d3f7
PE
2923 Assume perror.
2924 * s/hpux10-20.h (HAVE_PERROR): Remove.
2925 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2926 Remove dummy definition, as this problem was obsolete long ago.
2927
5ebbef1d
PE
2928 Assume strerror.
2929 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2930
984e7f30
DA
29312012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2932
2933 Avoid calls to strlen in font processing functions.
2934 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2935 (font_open_by_name): Change to use length argument.
2936 Adjust users accordingly.
d923b542
DA
2937 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2938 Adjust prototypes.
2939 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2940 Change to return ptrdiff_t.
984e7f30
DA
2941 (xfont_list_pattern, xfont_match): Use length returned by
2942 xfont_decode_coding_xlfd.
2943 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2944
20e94fdd
GM
29452012-07-11 Glenn Morris <rgm@gnu.org>
2946
9d596af3
GM
2947 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2948 Move DONT_REOPEN_PTY to configure.
2949
20e94fdd
GM
2950 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2951 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2952
e99a530f
PE
29532012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2954
22ffb973
PE
2955 Remove "#define unix" that is no longer needed (Bug#11905).
2956 * s/aix4-2.h (unix): Remove; no longer needed.
2957
e9a9ae03
PE
2958 EMACS_TIME simplification (Bug#11875).
2959 This replaces macros (which typically do not work in GDB)
2960 with functions, typedefs and enums, making the code easier to debug.
2961 The functional style also makes code easier to read and maintain.
2962 * systime.h: Include <sys/time.h> on all hosts, not just if
2963 WINDOWSNT, since 'struct timeval' is needed in general.
2964 (EMACS_TIME): Now a typedef, not a macro.
2965 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2966 not macros.
2967 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2968 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2969 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2970 (EMACS_TIME_LE): Now functions, not macros.
2971 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2972 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2973 which are not functions. All uses rewritten to use:
2974 (make_emacs_time): New function.
2975 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2976 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2977 not functions. All uses rewritten to use the following, respectively:
2978 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2979 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2980 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2981 * fileio.c (Fcopy_file):
2982 * xterm.c (XTflash): Get the current time closer to when it's used.
2983 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2984
ffacb126
PE
2985 * bytecode.c (targets): Suppress -Woverride-init warnings.
2986
e99a530f
PE
2987 Simplify by avoiding confusing use of strncpy etc.
2988 * doc.c (Fsnarf_documentation):
2989 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2990 * frame.c (Fmake_terminal_frame):
2991 * gtkutil.c (get_utf8_string):
2992 * lread.c (openp):
2993 * nsmenu.m (ns_update_menubar):
2994 * regex.c (regerror):
2995 Prefer memcpy to strncpy and strncat when either will do.
2996 * fileio.c (Fsubstitute_in_file_name):
2997 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2998 (menu_separator_name_p):
2999 * nsmenu.m (ns_update_menubar):
3000 Prefer memcmp to strncmp when either will do.
3001 * nsterm.m: Include <ftoastr.h>.
3002 (ns_get_color):
3003 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
3004 Prefer snprintf to strncpy.
3005 * nsterm.m (ns_term_init):
3006 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
3007 * nsterm.m (ns_term_init):
3008 Avoid the need for strncpy, by using build_string or
3009 make_unibyte_string directly. Use dtoastr, not snprintf.
3010 * process.c (Fmake_network_process): Diagnose service names that
3011 are too long, rather than silently truncating them or creating
3012 non-null-terminated names.
3013 (Fnetwork_interface_info): Likewise, for interface names.
3014 * sysdep.c (system_process_attributes) [GNU_LINUX]:
3015 Prefer sprintf to strncat.
3016 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
3017 Prefer vsnprintf to vsprintf + strncpy.
3018
c59592b3
GM
30192012-07-10 Glenn Morris <rgm@gnu.org>
3020
3021 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
3022 Clarify fallback case.
3023
7d7bbefd
DA
30242012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3025
3026 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
3027 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
3028 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 3029 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
3030 where argument type is known to be a Lisp_Cons.
3031
3a4c8000
TT
30322012-07-10 Tom Tromey <tromey@redhat.com>
3033
3034 * bytecode.c (BYTE_CODE_THREADED): New macro.
3035 (BYTE_CODES): New macro. Replaces all old byte-code defines.
3036 (enum byte_code_op): New type.
3037 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
3038 (exec_byte_code): Use them. Use token threading when applicable.
3039
2a0213a6
DA
30402012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3041
3042 Optimize pure C strings initialization.
3043 * lisp.h (make_pure_string): Fix prototype.
3044 (build_pure_c_string): New function, defined as static inline. This
3045 provides a better opportunity to optimize away calls to strlen when
3046 the function is called with compile-time constant argument.
3047 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
3048 argument, adjust users accordingly. Use build_pure_c_string where
3049 appropriate.
3050 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
3051 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
3052 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
3053
cb1caeaf
DA
30542012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3055
3056 Avoid calls to strlen in miscellaneous functions.
3057 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
3058 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
3059 * lread.c (openp): Likewise.
3060
c293e30c
DA
30612012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3062
3063 Avoid calls to strlen in path processing functions.
3064 * fileio.c (file_name_as_directory): Add comment. Change to add
3065 srclen argument and return the length of result. Adjust users
3066 accordingly.
3067 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
3068 swap 1st and 2nd arguments to obey the common convention.
3069 Adjust users accordingly.
c293e30c
DA
3070 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
3071
9e059e3f
GM
30722012-07-10 Glenn Morris <rgm@gnu.org>
3073
d02eb359
GM
3074 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
3075 Move PENDING_OUTPUT_COUNT definition to configure.
3076
882cf227
GM
3077 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
3078 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
3079 * s/gnu.h (DATA_START): Move definitions to configure.
3080
af6e839f
GM
3081 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
3082 We include usg5-4-common.h, which defines them both.
3083
40289a12
GM
3084 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
3085 O_RDONLY already includes it).
3086
9e059e3f
GM
3087 Stop ns builds setting the EMACSLOADPATH environment variable.
3088 * nsterm.m (ns_load_path): Rename from ns_init_paths.
3089 Now it does not set EMACSLOADPATH, just returns the load-path string.
3090 * nsterm.h: Update accordingly.
3091 * lread.c [HAVE_NS]: Include nsterm.h.
3092 (init_lread) [HAVE_NS]: Use ns_load_path.
3093 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
3094
7c4e8ec0
GM
30952012-07-09 Glenn Morris <rgm@gnu.org>
3096
d4f600ff
GM
3097 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
3098 since the included bsd-common.h does so.
3099
cbb31951
GM
3100 Stop ns builds setting the EMACSPATH environment variable.
3101 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
3102 (ns_init_paths): Do not set EMACSPATH.
3103 * nsterm.h (ns_exec_path): Add it.
3104 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
3105 Use ns_exec_path.
3106
7c4e8ec0
GM
3107 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
3108
26bccfae
PE
31092012-07-09 Paul Eggert <eggert@cs.ucla.edu>
3110
a0bee46f
PE
3111 * process.c (wait_reading_process_output): 'waitchannels' was unset
3112 when read_kbd || !NILP (wait_for_cell); fix this.
3113
5994c183
PE
3114 Add GCC-style 'const' attribute to functions that can use it.
3115 * character.h (char_resolve_modifier_mask):
3116 * keyboard.h (make_ctrl_char):
3117 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
3118 (init_character_once, next_almost_prime, init_fns, init_image)
3119 (flush_pending_output, init_sound):
3120 * mem-limits.h (start_of_data):
3121 * menu.h (finish_menu_items):
3122 Add ATTRIBUTE_CONST.
3123 * emacs.c (DEFINE_DUMMY_FUNCTION):
3124 Declare the dummy function with ATTRIBUTE_CONST.
3125 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
3126 Add decls with ATTRIBUTE_CONST.
3127
26bccfae
PE
3128 Minor improvements to make_formatted_string.
3129 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
3130 where int is good enough, as vsprintf returns an int.
3131 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
3132
a8290ec3
DA
31332012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3134
3135 Use make_formatted_string to avoid double length calculation.
3136 * lisp.h (make_formatted_string): New prototype.
3137 * alloc.c (make_formatted_string): New function.
3138 * buffer.c (Fgenerate_new_buffer_name): Use it.
3139 * dbus.c (syms_of_dbusbind): Likewise.
3140 * editfns.c (Fcurrent_time_zone): Likewise.
3141 * filelock.c (get_boot_time): Likewise.
3142 * frame.c (make_terminal_frame, set_term_frame_name)
3143 (x_report_frame_params): Likewise.
3144 * image.c (gs_load): Likewise.
3145 * minibuf.c (get_minibuffer): Likewise.
3146 * msdos.c (dos_set_window_size): Likewise.
3147 * process.c (make_process): Likewise.
3148 * xdisp.c (ensure_echo_area_buffers): Likewise.
3149 * xsettings.c (apply_xft_settings): Likewise.
3150
d01ba2f1
GM
31512012-07-09 Glenn Morris <rgm@gnu.org>
3152
3153 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
3154 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
3155 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
3156 * nsterm.h (ns_etc_directory): Add it.
3157 * callproc.c [HAVE_NS]: Include nsterm.h.
3158 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
3159
f1f924b6
DA
31602012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
3161
3162 Move marker debugging code under MARKER_DEBUG.
3163 * marker.c (MARKER_DEBUG): Move marker debugging code under
3164 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
3165 for bootstrap with --enable-checking (~3x slowdown reported
3166 by Juanma Barranquero <lekktu@gmail.com>).
3167 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
3168
ab531b66
PE
31692012-07-08 Paul Eggert <eggert@cs.ucla.edu>
3170
3171 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
3172 See <http://bugs.gnu.org/11825#29>.
3173
c4b3bc8a
EZ
31742012-07-08 Eli Zaretskii <eliz@gnu.org>
3175
3176 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
3177 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
3178 (display_line): Add commentary about displaying truncation glyphs
3179 on GUI frames.
3180 (produce_special_glyphs): Move here from term.c.
3181
3182 * term.c (produce_special_glyphs): Move to xdisp.c.
3183
3184 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
3185 section.
c4b3bc8a 3186
b676b881
AS
31872012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3188
f17c5273
AS
3189 * xdisp.c (display_line): Avoid warning about implicit declaration
3190 of FRAME_FONT.
3191
298819b9
AS
3192 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
3193
b676b881
AS
3194 * lisp.h: Remove empty conditional.
3195
6045c4fd
PE
31962012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3197
b3350bf9
PE
3198 * lread.c (load_path_check): Now static.
3199
6045c4fd
PE
3200 Fix some minor --with-ns problems found by static checking.
3201 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
3202 (x_set_font) [!HAVE_X_WINDOWS]:
3203 * image.c (xpm_load_image) [HAVE_NS]:
3204 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
3205 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
3206 Remove unused local.
3207 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
3208 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
3209 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
3210 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
3211 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
3212 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
3213 Fix pointer signedness problem.
3214 * xfaces.c (FRAME_X_FONT_TABLE):
3215 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
3216
929e7845
GM
32172012-07-07 Glenn Morris <rgm@gnu.org>
3218
3219 * lread.c (load_path_check): New function, split from init_lread.
3220 (init_lread): Reorganize. Motivation:
3221 If EMACSLOADPATH is set, check/warn about that rather than the
3222 defaults, which we are not going to use. Hence we can remove
3223 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
3224 Don't warn if site-lisp directories are missing.
3225 If not installed, start from a blank load-path, since
3226 PATH_LOADSEARCH refers to the eventual installation directories.
3227
58dd0aa4
EZ
32282012-07-07 Eli Zaretskii <eliz@gnu.org>
3229
3230 Support truncation and continuation glyphs on GUI frames, when
3231 fringes are disabled. (Bug#11832)
3232 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
3233 continuation glyphs even if on GUI frames.
3234 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
3235 or both, are absent.
3236 (start_display, move_it_in_display_line_to): Handle the case of a
3237 GUI frame without a fringe to display continuation or truncation
3238 glyphs.
3239 (insert_left_trunc_glyphs): Support GUI frames: make sure
3240 truncation glyphs overwrite enough glyphs from the current line to
3241 have sufficient space in pixels.
3242 (display_line): Support truncation and continuation glyphs on GUI
3243 frames. If some spare pixels are left on the line after inserting
3244 the truncation glyphs, fill that space with a stretch glyph of a
3245 suitably computed width.
3246
3247 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
3248 produce_glyphs, to support GUI sessions.
3249
31571fd7
PE
32502012-07-07 Paul Eggert <eggert@cs.ucla.edu>
3251
5a16b9bc
PE
3252 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
3253
f3047c75
PE
3254 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
3255
31571fd7
PE
3256 Do not require float-time's arg to fit in time_t (Bug#11825).
3257 This works better on hosts where time_t is unsigned, and where
3258 float-time is applied to the (negative) difference between two times.
3259 * editfns.c (decode_time_components): Last arg is now double *,
3260 not int *, and means to store all the result as a double, without
3261 worrying about whether the seconds part fits in time_t.
3262 All callers changed.
3263 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
3264 All callers changed.
3265 (Ffloat_time): Do not fail merely because the specified time falls
3266 outside of time_t range.
3267
4516fbef
GM
32682012-07-07 Glenn Morris <rgm@gnu.org>
3269
3270 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
3271 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
3272 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
3273
07adc2c6
JB
32742012-07-07 Juanma Barranquero <lekktu@gmail.com>
3275
3276 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
3277 Update dependencies.
3278
3279 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
3280
fd573f31
PE
32812012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3282
fee5959d
PE
3283 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
3284 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
3285 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
3286 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
3287 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
3288 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
3289
fd573f31
PE
3290 * xfont.c (compare_font_names): Redo to omit the need for casts.
3291
ddadbc0e
AS
32922012-07-06 Andreas Schwab <schwab@linux-m68k.org>
3293
fca8d6b6
AS
3294 * xfns.c (Fx_change_window_property): Doc fix.
3295 * w32fns.c (Fx_change_window_property): Doc fix.
3296
ddadbc0e
AS
3297 * w32fns.c (Fx_window_property): Accept the same arguments as the
3298 X Windows version. Doc fix.
3299 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
3300
ed9265fc 33012012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
3302 Eli Zaretskii <eliz@gnu.org>
3303
3304 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
3305 Windows-specific code from nt/config.nt moved here.
3306 Obsolete settings removed.
3307
216ee680
PE
33082012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 * process.c: Avoid unnecessary calls to gettime.
3311 (wait_reading_process_output): Don't get the time of day
3312 when gobbling data immediately and not waiting, as there's no need
3313 for it in that case. This removes a FIXME.
3314
bdd091e4
JD
33152012-07-06 Jan Djärv <jan.h.d@swipnet.se>
3316
3317 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
3318 is defined (Bug#11768).
3319
9d44f8ce
DA
33202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3321
3322 Fix marker debugging code.
3323 * marker.c (byte_char_debug_check): Do not perform the check
3324 if buffer is not multibyte.
090bd7cb
JB
3325 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3326 Call byte_char_debug_check with correct arguments.
9d44f8ce 3327
90fc4786
DA
33282012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3329
3330 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
3331 * marker.c (byte_char_debug_check, count_markers):
3332 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
3333 (byte_debug_flag): Remove.
3334 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
3335 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
3336
7b7ae965
DA
33372012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3338
4e57b342
DA
3339 Avoid code repetition in marker-related functions.
3340 * marker.c (attach_marker): New function.
3341 (Fset_marker, set_marker_restricted, set_marker_both)
3342 (set_marker_restricted_both): Use it.
3343 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
3344 Consistently rename charno to charpos.
3345 (marker_position): Add eassert.
3346 (marker_byte_position): Convert to eassert.
3347
33482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3349
3350 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 3351 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 3352 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 3353
657924ff
DA
33542012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3355
3356 Introduce fast path for the widely used marker operation.
3357 * alloc.c (build_marker): New function.
3358 * lisp.h (build_marker): New prototype.
3359 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
3360 * composite.c (autocmp_chars): Likewise.
3361 * editfns.c (buildmark): Remove.
3362 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
3363 (save_restriction_save): Use build_marker.
3364 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
3365 * window.c (save_window_save): Likewise.
3366
041a49a6
DA
33672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3368
3369 Do not use Fdelete_overlay in delete_all_overlays
3370 to avoid redundant calls to unchain_overlay.
3371 * buffer.c (drop_overlay): New function.
3372 (delete_all_overlays, Fdelete_overlay): Use it.
3373 * minibuf.c (get_minibuffer): Fix comment.
3374
7dca65a4
PE
33752012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 Port to OpenBSD 5.1 amd64.
3378 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
3379 This is needed for OpenBSD, and should be harmless on all BSD systems.
3380 Also, include <sys/sysctl.h>, as it should be available on all
3381 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
3382 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
3383 use p_pid member, not kp_proc.pid.
3384
8eb876e2
GM
33852012-07-06 Glenn Morris <rgm@gnu.org>
3386
3387 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
3388
38182d90
PE
33892012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 More xmalloc and related cleanup.
3392 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
3393 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
3394 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
3395 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
3396 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
3397 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
3398 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
3399 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
3400 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
3401 * xterm.c:
3402 Omit needless casts involving void * pointers and allocation.
3403 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
3404 as the former is more robust if P's type is changed.
3405 Prefer xzalloc to xmalloc + memset 0.
3406 Simplify malloc-or-realloc to realloc.
3407 Don't worry about xmalloc returning a null pointer.
3408 Prefer xstrdup to xmalloc + strcpy.
3409 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
3410 growing it.
3411 * keyboard.c (apply_modifiers_uncached): Prefer local array to
3412 alloca of a constant.
3413
6dd5a677
EZ
34142012-07-05 Eli Zaretskii <eliz@gnu.org>
3415
3416 * xdisp.c (display_line): Fix horizontal pixel coordinates when
3417 hscroll is larger than the line width. Fixes long and futile
3418 looping inside extend_face_to_end_of_line (on a TTY) producing
3419 glyphs that are not needed and thrown away.
3420
6b312f0f
DA
34212012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3422
3423 * marker.c (set_marker_restricted_both): Simplify by using
3424 clip_to_bounds.
3425
f520ef9b
PE
34262012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3427
3428 * editfns.c (region_limit): Simplify by using clip_to_bounds.
3429
383b7c95
JD
34302012-07-05 Jan Djärv <jan.h.d@swipnet.se>
3431
3432 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
3433 not defined (Bug#11768).
3434 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
3435 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
3436 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
3437 followed by gtk_box_set_homogeneous (Bug#11768).
3438 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
3439 (update_theme_scrollbar_width, xg_create_scroll_bar):
3440 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
3441 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
3442 (is_box_type): New function (Bug#11768).
3443 (xg_tool_item_stale_p): Call is_box_type.
5293d758 3444 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
3445 with default display (Bug#11768).
3446
d6e7bf45
EZ
34472012-07-05 Eli Zaretskii <eliz@gnu.org>
3448
3449 * xdisp.c (window_hscroll_limited): New function.
3450 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
3451 coordinates when window's hscroll is set to insanely large
3452 values. (Bug#11857)
3453
431391ec
JB
34542012-07-05 Juanma Barranquero <lekktu@gmail.com>
3455
3456 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
3457 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
3458
23f86fce
DA
34592012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
3460
3461 Cleanup xmalloc.
3462 * lisp.h (xzalloc): New prototype. Omit needless casts.
3463 * alloc.c (xzalloc): New function. Omit needless casts.
3464 * charset.c: Omit needless casts. Convert all calls to
3465 xmalloc with following memset to xzalloc.
3466 * dispnew.c: Likewise.
3467 * fringe.c: Likewise.
3468 * image.c: Likewise.
3469 * sound.c: Likewise.
3470 * term.c: Likewise.
3471 * w32fns.c: Likewise.
3472 * w32font.c: Likewise.
3473 * w32term.c: Likewise.
3474 * xfaces.c: Likewise.
3475 * xfns.c: Likewise.
3476 * xterm.c: Likewise.
3477 * atimer.c: Omit needless casts.
3478 * buffer.c: Likewise.
3479 * callproc.c: Likewise.
3480 * ccl.c: Likewise.
3481 * coding.c: Likewise.
3482 * composite.c: Likewise.
3483 * doc.c: Likewise.
3484 * doprnt.c: Likewise.
3485 * editfns.c: Likewise.
3486 * emacs.c: Likewise.
3487 * eval.c: Likewise.
3488 * filelock.c: Likewise.
3489 * fns.c: Likewise.
3490 * gtkutil.c: Likewise.
3491 * keyboard.c: Likewise.
3492 * lisp.h: Likewise.
3493 * lread.c: Likewise.
3494 * minibuf.c: Likewise.
3495 * msdos.c: Likewise.
3496 * print.c: Likewise.
3497 * process.c: Likewise.
3498 * region-cache.c: Likewise.
3499 * search.c: Likewise.
3500 * sysdep.c: Likewise.
3501 * termcap.c: Likewise.
3502 * terminal.c: Likewise.
3503 * tparam.c: Likewise.
3504 * w16select.c: Likewise.
3505 * w32.c: Likewise.
3506 * w32reg.c: Likewise.
3507 * w32select.c: Likewise.
3508 * w32uniscribe.c: Likewise.
3509 * widget.c: Likewise.
3510 * xdisp.c: Likewise.
3511 * xmenu.c: Likewise.
3512 * xrdb.c: Likewise.
3513 * xselect.c: Likewise.
3514
0497dc44
PE
35152012-07-05 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 * fileio.c (time_error_value): Check the right error number.
3518 Problem reported by Troels Nielsen in
3519 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
3520
356e7178
PE
35212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3522
4e71fd89
PE
3523 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
3524 This should be fixed in a better way; see Eli Zaretskii in
3525 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
3526 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
3527
f0941253
PE
3528 * fileio.c (time_error_value): Rename from special_mtime.
3529 The old name's problems were noted by Eli Zaretskii in
3530 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
3531
065c9eb4
PE
3532 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
3533 This variable's comment says Emacs needs at least one GDB-visible
3534 symbol of type enum pvec_type, to work around GDB problems.
3535 The symbol's value doesn't matter.
3536
356e7178
PE
3537 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
3538 that causes compilation to fail on pre-C99 compilers.
3539
ed9265fc 35402012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
3541
3542 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
3543 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
3544
3884d954
DA
35452012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3546
d209e2fb 3547 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
3548 headers for buffer_defaults and buffer_local_symbols.
3549 Reported by Juanma Barranquero <lekktu@gmail.com>.
3550
ee28be33
SM
35512012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3552
3553 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
3554 * lisp.h (enum pvec_type): Use fewer bits.
3555 (PSEUDOVECTOR_SIZE_BITS): New constant.
3556 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
3557 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
3558 change in pvec_type.
3559 (PSEUDOVECTOR_TYPEP): New macro.
3560 (TYPED_PSEUDOVECTORP): Use it.
3561 * fns.c (internal_equal): Adapt code to extract pvectype.
3562 * emacs.c (gdb_pvec_type): Update type.
3563 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
3564 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
3565 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
3566 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
3567 (sweep_vectors): Use it. Use local var `total_bytes' instead of
3568 abusing vector->header.next.nbytes.
3569 (live_vector_p): Use PVEC_TYPE.
3570 (mark_object): Adapt code to extract pvectype. Use switch.
3571
c7f2cd7f
PE
35722012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3573
3574 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
3575 Tighten new eassert a bit.
3576
8ce70ed2
DA
35772012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3578
3579 Fix compilation with --enable-gcc-warnings and -O1
3580 optimization level.
3581 * doprnt.c (doprnt): Change type of tem to int, initialize
3582 to avoid compiler warning. Add eassert.
3583 * search.c (simple_search): Initialize match_byte to avoid
3584 compiler warning. Add eassert.
3585
dea7f1e5
PE
35862012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3587
24a212eb
PE
3588 Avoid weird behavior with large horizontal scrolls.
3589 Without this change, for example, large hscroll values would
3590 mess up Emacs's display on Fedora 15 x86, presumably due to
3591 overflows in int calculations in the display code.
3592 Also, if buffers had long lines, Emacs would freeze.
3593 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
3594 (set_window_hscroll): New function, containing the old guts of
3595 Fset_window_hscroll. Return the clipped value.
3596 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
3597 This avoids the need to check against PTRDIFF_MAX.
3598
dea7f1e5
PE
3599 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
3600
76046526
DA
36012012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
3602
3603 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
3604
39adff0d
PE
36052012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3606
63807d47
PE
3607 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
3608 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
3609 since GCC 4.4.6 issues a bogus warning for them.
3610
39adff0d
PE
3611 Fix bugs in file timestamp newness comparisons.
3612 * fileio.c (Ffile_newer_than_file_p):
3613 * lread.c (Fload): Use full timestamp resolution of files,
3614 not just the 1-second resolution, so that files that are only
3615 slightly newer still count as newer.
3616 * fileio.c (Ffile_newer_than_file_p): Don't assume file
3617 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
3618
dbeed9a6
PE
36192012-07-03 Paul Eggert <eggert@cs.ucla.edu>
3620
3621 * fileio.c: Improve handling of file time marker. (Bug#11852)
3622 (special_mtime): New function.
3623 (Finsert_file_contents, Fverify_visited_file_modtime):
3624 Use it to set special mtime values consistently.
3625
636334d6
AS
36262012-07-03 Andreas Schwab <schwab@linux-m68k.org>
3627
3628 * fileio.c (Finsert_file_contents): Properly handle st_mtime
3629 marker for non-existing file. (Bug#11852)
3630
e2017fe2
GM
36312012-07-03 Glenn Morris <rgm@gnu.org>
3632
3633 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
3634 and did not make it into globals.h).
3635
404dbd37
TT
36362012-07-03 Tom Tromey <tromey@redhat.com>
3637
3638 * window.c (Fset_window_margins, Fset_window_fringes)
3639 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
3640 * textprop.c (Fprevious_property_change): No longer static.
3641 * syntax.c (Fsyntax_table_p): No longer static.
3642 * process.c (Fget_process, Fprocess_datagram_address): No longer
3643 static.
3644 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
3645 * keyboard.c (Fcommand_execute): No longer static.
3646 Remove EXFUN.
3647 * insdel.c (Fcombine_after_change_execute): No longer static.
3648 * image.c (Finit_image_library): No longer static.
3649 * fileio.c (Fmake_symbolic_link): No longer static.
3650 * eval.c (Ffetch_bytecode): No longer static.
3651 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
3652 * doc.c (Fdocumentation_property, Fsnarf_documentation):
3653 No longer static.
404dbd37
TT
3654 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
3655 static.
3656 * dired.c (Ffile_attributes): No longer static.
3657 * composite.c (Fcomposition_get_gstring): No longer static.
3658 * callproc.c (Fgetenv_internal): No longer static.
3659
3660 * ccl.h: Remove EXFUNs.
3661 * buffer.h: Remove EXFUNs.
3662 * dispextern.h: Remove EXFUNs.
3663 * intervals.h: Remove EXFUNs.
3664 * fontset.h: Remove EXFUN.
3665 * font.h: Remove EXFUNs.
3666 * dosfns.c (system_process_attributes): Remove EXFUN.
3667 * keymap.h: Remove EXFUNs.
3668 * lisp.h: Remove EXFUNs.
3669 * w32term.h: Remove EXFUNs.
3670 * window.h: Remove EXFUNs.
3671 * xsettings.h: Remove EXFUN.
3672 * xterm.h: Remove EXFUN.
3673
8e4fd1e1
GM
36742012-07-03 Glenn Morris <rgm@gnu.org>
3675
3676 * lisp.h (Frandom): Make it visible to C.
3677 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
3678 buffer for invisible buffers. (Bug#1229)
3679
ca95b3eb
DA
36802012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3681
3682 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
3683 values which aren't power of 2.
14ae4239
BT
3684 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
3685 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
3686 accordingly.
3687
7555c33f
SM
36882012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
3689
3690 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
3691
3692 * alloc.c (mark_object): Revert part of last patch to use `switch'.
3693
d12e8f5a
DA
36942012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3695
3696 * alloc.c (allocate_vector_block): Remove redundant
3697 calls to mallopt if DOUG_LEA_MALLOC is defined.
3698 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
3699 avoid calls to mallopt if zero_vector is returned.
3700
296094c3
DA
37012012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3702
3703 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
3704 is enabled, avoid dereferencing NULL current_sblock if
3705 running undumped.
3706
36429c89
DA
37072012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
3708
3709 Cleanup basic buffer management.
3710 * buffer.h (struct buffer): Change layout to use generic vector
3711 marking code. Fix some comments. Change type of 'clip_changed'
3712 to bitfield. Remove unused #ifndef old.
3713 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
3714 (GET_OVERLAYS_AT): Fix indentation.
3715 (for_each_per_buffer_object_at): New macro.
3716 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
3717 (Fbuffer_local_variables): Use it.
3718 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
3719 * alloc.c (allocate_buffer): Adjust to match new layout of
3720 struct buffer. Fix comment.
3721 (mark_overlay): New function.
3722 (mark_buffer): Use it. Use mark_vectorlike to mark normal
3723 Lisp area of struct buffer.
3724 (mark_object): Use it. Adjust marking of misc objects
3725 and related comments.
3726
3b3e4cac
PE
37272012-07-02 Paul Eggert <eggert@cs.ucla.edu>
3728
3729 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
3730 wrapper that is not needed because the wrapped code is a no-op (zero
3731 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
3732 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
3733
cf5c0175
DA
37342012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
3735
3736 * alloc.c (mark_buffer): Simplify. Remove prototype.
3737 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 3738 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
3739 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
3740 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 3741
ca26824c
GM
37422012-06-30 Glenn Morris <rgm@gnu.org>
3743
2e4c5312
GM
3744 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
3745
ca26824c
GM
3746 * epaths.in (PATH_SITELOADSEARCH): New.
3747 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
3748 This is rather than relying on --enable-locallisppath elements
3749 having "site-lisp" in their names. (Bug#10208#25, 11658)
3750
0d23c240
EZ
37512012-06-30 Eli Zaretskii <eliz@gnu.org>
3752
c9240d7a
EZ
3753 * w32proc.c (sys_select): Accept and ignore one more argument.
3754
3755 * w32.c (emacs_gnutls_pull): Call select with one more argument.
3756
0d23c240 3757 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 3758 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
3759
3760 * sysdep.c: Don't include dos.h and dosfns.h.
3761
3762 * process.c (sys_select):
3763 * msdos.c (sys_select): Accept one more argument and ignore it.
3764
3765 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
3766 adapt data types and code to that.
3767
3768 * dosfns.c:
3769 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
3770 which clashes with the gnulib function of the same name.
3771
af5a5a98
AS
37722012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3773
c5e4379c
AS
3774 * font.c (font_style_to_value, font_style_symbolic)
3775 (font_prop_validate_style): Add type checks for values in
3776 font_style_table.
3777
af5a5a98
AS
3778 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
3779 argument.
3780 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
3781 uses.
3782
8d38f461
EZ
37832012-06-29 Eli Zaretskii <eliz@gnu.org>
3784
2e5a6631
EZ
3785 * xdisp.c (try_window_id): Undo last change.
3786
8d38f461
EZ
3787 * w32.c (getwd): Adjust commentary about startup_dir.
3788 (init_environment): Always call sys_access, even in non-MSVC
3789 builds. Don't chdir to the directory of the Emacs executable.
3790 This undoes code from 1997 which was justified by the need to
3791 "avoid conflicts when removing and renaming directories". But its
3792 downside was that every relative file name was being interpreted
3793 relative to the directory of the Emacs executable, which can never
3794 be TRT. In particular, it broke sys_access when called with
3795 relative file names.
3796 (sys_access): Map GetLastError to errno.
3797
2af3565e
DA
37982012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3799
3800 * window.h (struct window): Change type of 'fringes_outside_margins'
3801 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3802 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3803 Adjust comment.
3804 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3805 to ptrdiff_t.
3806
c8d3a25c 38072012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3808
c8d3a25c
GM
3809 * gnutls.c (emacs_gnutls_handshake):
3810 Add QUIT to make the loop interruptible.
57570cd3 3811
c8d3a25c 38122012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3813
c8d3a25c
GM
3814 * charset.c (init_charset): Make lack of etc/charsets fatal.
3815
3e984ee8
DA
38162012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3817
3818 * editfns.c (region_limit): Fix type mismatch.
3819
ef884f23
DA
38202012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3821
3822 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3823 undefined. Convert from xassert to eassert.
3824 * nsmenu.m: Convert from xassert to eassert.
3825 * nsterm.m: Likewise.
3826
7d7e0027
SM
38272012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3828
3829 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3830
aa754e6a
PE
38312012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3832
3833 Avoid integer overflow on scroll-left and scroll-right.
3834 * window.c (HSCROLL_MAX): New macro.
3835 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3836 overflow when requested scroll falls outside ptrdiff_t range.
3837
80b00b08
DA
38382012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3839
3840 * window.h (struct window): Change type of 'hscroll',
3841 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3842 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3843 Adjust users accordingly.
3844 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3845 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3846 from EMACS_INT to ptrdiff_t.
3847 (make_window): Omit redundant initialization.
3848
62b2bcf6
JB
38492012-06-28 Juanma Barranquero <lekktu@gmail.com>
3850
3851 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3852
45942c7d
DA
38532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3854
3855 * window.h (struct window): Change type of 'use_time' and
3856 'sequence_number' from Lisp_Object to int.
3857 * frame.c (make_frame): Adjust users accordingly.
3858 * print.c (print_object): Likewise.
3859 * window.c (select_window, Fwindow_use_time, make_parent_window)
3860 (make_window): Likewise.
3861
e509cfa6
DA
38622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3863
3864 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3865 enabled with --enable-checking=[all,glyphs] configure option.
3866 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3867 adjust comments accordingly.
3868 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3869 undefined, adjust comments accordingly.
3870 * image.c: Likewise.
3871 * scroll.c: Likewise.
3872 * w32fns.c: Likewise.
3873 * w32term.c: Likewise.
3874 * xdisp.c: Likewise.
3875 * xfaces.c: Likewise.
3876 * xfns.c: Likewise.
3877 * xterm.c: Likewise.
3878
a54e2c05
DA
38792012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3880
3881 Generalize run-time debugging checks.
3882 * dispextern.h (XASSERTS): Remove.
3883 * fontset.c (xassert): Remove.
3884 Convert from xassert to eassert.
3885 * alloc.c: Convert from xassert to eassert.
3886 * bidi.c: Likewise.
3887 * dispnew.c: Likewise.
3888 * fns.c: Likewise.
3889 * fringe.c: Likewise.
3890 * ftfont.c: Likewise.
3891 * gtkutil.c: Likewise.
3892 * image.c: Likewise.
3893 * keyboard.c: Likewise.
3894 * menu.c: Likewise.
3895 * process.c: Likewise.
3896 * scroll.c: Likewise.
3897 * sound.c: Likewise.
3898 * term.c: Likewise.
3899 * w32console.c: Likewise.
3900 * w32fns.c: Likewise.
3901 * w32term.c: Likewise.
3902 * window.c: Likewise.
3903 * xdisp.c: Likewise.
3904 * xfaces.c: Likewise.
3905 * xfns.c: Likewise.
3906 * xselect.c: Likewise.
3907 * xterm.c: Likewise.
3908
1ec4b7b2
SM
39092012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3910
3911 * fns.c (maybe_resize_hash_table): Output message when growing the
3912 purify-hashtable.
3913
2014308a
DA
39142012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3915
3916 * alloc.c (allocate_string_data): Remove dead code.
3917 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3918 avoid GCC warning about unused macro.
3919
246155eb
DA
39202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3921
3922 * alloc.c (allocate_string): Omit intervals initialization.
3923 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3924 as in make_pure_string and make_pure_c_string.
3925
43184b7b
DA
39262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3927
d209e2fb 3928 * alloc.c (allocate_string): Fix last change.
43184b7b 3929
3fe6dd74
DA
39302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3931
d209e2fb 3932 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3933 to memset, add explicit initialization where appropriate.
3934
1ba6038a
GM
39352012-06-27 Glenn Morris <rgm@gnu.org>
3936
3937 * lisp.mk (lisp): Remove paths.elc.
3938
c89926a5
CY
39392012-06-27 Chong Yidong <cyd@gnu.org>
3940
3941 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3942
ed6b3510
JW
39432012-06-26 John Wiegley <johnw@newartisans.com>
3944
1ec4b7b2 3945 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3946 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3947
ed6b3510
JW
3948 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3949 when building with Clang.
3950
8edd4a2b
SM
39512012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3952
3953 * eval.c (Fapply): Allow calling it with a single argument.
3954
f6f62d1b
EZ
39552012-06-26 Eli Zaretskii <eliz@gnu.org>
3956
3957 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3958 _stricmp and _strnicmp.
3959 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3960
62efea5e
DA
39612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3962
3963 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3964 allocated window.
3965 (allocate_process): Likewise for new process.
8edd4a2b 3966 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3967 (allocate_frame): Likewise.
3968 * frame.c (make_frame): Omit redundant initialization.
3969 * window.c (make_parent_window): Use memset.
3970 (make_window): Omit redundant initialization.
3971 * process.c (make_process): Omit redundant initialization.
3972 * terminal.c (create_terminal): Likewise.
3973
42997f4d
DA
39742012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3975
3976 * term.c (delete_tty): Remove redundant call to memset.
3977
1130ecfc
DA
39782012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3979
3980 * alloc.c: Remove build_string.
3981 * lisp.h: Define build_string as static inline. This provides
3982 a better opportunity to optimize away calls to strlen when the
3983 function is called with compile-time constant argument.
3984 * image.c (imagemagick_error): Convert to build_string.
3985 * w32proc.c (sys_spawnve): Likewise.
3986 * xterm.c (x_term_init): Likewise.
3987
cf38a720
PE
39882012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3989
99027bdd
PE
3990 Use sprintf return value instead of invoking strlen on result.
3991 In the old days this wasn't portable, since some sprintf
3992 implementations returned char *. But they died out years ago and
3993 Emacs already assumes sprintf returns int.
3994 Similarly for float_to_string.
3995 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3996 * ccl.c (ccl_driver):
3997 * character.c (string_escape_byte8):
3998 * data.c (Fnumber_to_string):
3999 * doprnt.c (doprnt):
4000 * print.c (print_object):
4001 * xdisp.c (message_dolog):
4002 * xfns.c (syms_of_xfns):
4003 Use sprintf or float_to_string result to avoid need to call strlen.
4004 * data.c (Fnumber_to_string):
4005 Use make_unibyte_string, since the string must be ASCII.
4006 * lisp.h, print.c (float_to_string): Now returns int length.
4007 * term.c (produce_glyphless_glyph):
4008 Use sprintf result rather than recomputing it.
4009
cf38a720
PE
4010 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
4011 * Makefile.in (ALL_CFLAGS):
4012 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
4013 * gmalloc.c, regex.c: Include <config.h> unconditionally.
4014
3511c784
DA
40152012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4016
0a08eb21 4017 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
4018 strcasecmp if available.
4019 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
4020
fb7da12e
AS
40212012-06-25 Andreas Schwab <schwab@linux-m68k.org>
4022
4023 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
4024 Avoid comma operator.
4025 * menu.c (push_submenu_start, push_submenu_end)
4026 (push_left_right_boundary, push_menu_pane): Likewise.
4027 * msdos.c (dos_rawgetc): Likewise.
4028
afa2ffd8
DA
40292012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4030
4031 * xfns.c (xic_create_fontsetname): Remove redundant calls
4032 to memset.
4033
b3b4476b
PE
40342012-06-25 Paul Eggert <eggert@cs.ucla.edu>
4035
4495ff38
PE
4036 * gtkutil.c (get_utf8_string): Remove redundant assignment.
4037 sprintf already null-terminates its output.
4038
b3b4476b
PE
4039 * xfns.c (x_window): Remove redundant cast.
4040
b00876c9
DA
40412012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
4042
4043 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
4044 `const char *' to `char *' to avoid compiler warning.
4045
d188e26b
PE
40462012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4047
885d1d74
PE
4048 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4049 instead of truncating it to 63 (admittedly a generous limit).
4050
d188e26b
PE
4051 * process.c: Fix spelling and caps in comments.
4052
e2f560b1
DN
40532012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
4054
e86db54b 4055 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
4056 * sysdep.c (setpgrp): Remove definition, not used in this file.
4057
7583a3a1
JB
40582012-06-24 Juanma Barranquero <lekktu@gmail.com>
4059
4060 * makefile.w32-in: Update dependencies.
4061
696056c2
EZ
40622012-06-24 Eli Zaretskii <eliz@gnu.org>
4063
4064 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
4065 (SYSTIME_H): Add nt/inc/sys/time.h.
4066
4067 * systime.h [WINDOWSNT]: Include sys/time.h.
4068
4069 * s/ms-w32.h (struct timespec): Definition moved from
4070 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
4071
845ca893
PE
40722012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4073
4074 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
4075 * buffer.h (buffer_slot_type_mismatch):
4076 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4077 * eval.c (unwind_to_catch):
4078 * image.c (my_png_error, my_error_exit):
4079 * keyboard.c (quit_throw_to_read_char, user_error)
4080 (Fexit_recursive_edit, Fabort_recursive_edit):
4081 * lisp.h (die, args_out_of_range, args_out_of_range_3)
4082 (wrong_type_argument, buffer_overflow, __executable_start)
4083 (memory_full, buffer_memory_full, string_overflow, Fthrow)
4084 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
4085 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
4086 (fatal):
4087 (child_setup) [!DOS_NT]:
4088 * lread.c (end_of_file_error, invalid_syntax):
4089 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
4090 * puresize.h (pure_write_error):
4091 * search.c (matcher_overflow):
4092 * sound.c (sound_perror, alsa_sound_perror):
4093 * sysdep.c, syssignal.h (croak):
4094 * term.c (maybe_fatal, vfatal):
4095 * textprop.c (text_read_only):
4096 * undo.c (user_error):
4097 * unexmacosx.c (unexec_error):
4098 * xterm.c (x_ins_del_lines, x_delete_glyphs):
4099 Use _Noreturn rather than NO_RETURN.
4100 No need for separate decl merely because of _Noreturn.
4101 * sound.c (sound_warning, parse_sound):
4102 Remove unnecessary forward decls.
4103
f1dd8073
PE
41042012-06-24 Paul Eggert <eggert@cs.ucla.edu>
4105
4106 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
4107 * lisp.h (WAIT_READING_MAX): New macro.
4108 * dispnew.c (Fsleep_for, sit_for):
4109 * keyboard.c (kbd_buffer_get_event):
4110 * process.c (Faccept_process_output):
4111 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
4112 This improves on the previous patch, which introduced a bug
4113 when time_t is unsigned and as wide as intmax_t.
4114 See <http://bugs.gnu.org/9000#51>.
4115
b82c1755
EZ
41162012-06-23 Eli Zaretskii <eliz@gnu.org>
4117
4118 * dispnew.c (sit_for, Fsleep_for):
4119 * keyboard.c (kbd_buffer_get_event):
4120 * process.c (Faccept_process_output): Avoid compiler warnings when
4121 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
4122
ca300656
JB
41232012-06-23 Juanma Barranquero <lekktu@gmail.com>
4124
049ec95b
JB
4125 * makefile.w32-in: Update dependencies.
4126
ca300656
JB
4127 * w32.c (ltime): Add return type and declare static.
4128 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
4129
db7b8d06
PE
41302012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4131
4132 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4133 Privately reported by Herbert J. Skuhra.
4134 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
4135 All uses changed.
4136 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
4137 not make_lisp_timeval, when the argument is of type EMACS_TIME.
4138
0bd8297f
EZ
41392012-06-23 Eli Zaretskii <eliz@gnu.org>
4140
96512555
EZ
4141 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
4142 last argument of make_unibyte_string.
4143
0bd8297f
EZ
4144 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
4145 language ID in the event parameters.
4146
4147 * w32term.c (w32_read_socket): Put the new keyboard codepage into
4148 event.code, not the obscure "character set ID".
4149
63def6b6
CY
41502012-06-23 Chong Yidong <cyd@gnu.org>
4151
4152 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
4153
e8a02204
EZ
41542012-06-23 Eli Zaretskii <eliz@gnu.org>
4155
388cdec0
EZ
4156 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
4157 * w32.c (fdutimens): New function.
4158
4159 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
4160
4161 * s/ms-w32.h (pselect): Redirect to sys_select.
4162
4163 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
4164
e8a02204
EZ
4165 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
4166 in the logic of incrementing and decrementing the value of
4167 use_relocatable_buffers.
4168
d054f3fb
PE
41692012-06-23 Paul Eggert <eggert@cs.ucla.edu>
4170
4171 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
4172 Privately reported by Herbert J. Skuhra.
4173 [__FreeBSD__]: Remove "*/" typo after "#include".
4174 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
4175 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
4176 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
4177 Don't assume EMACS_TIME and struct timeval are the same type.
4178
d35af63c
PE
41792012-06-22 Paul Eggert <eggert@cs.ucla.edu>
4180
4181 Support higher-resolution time stamps (Bug#9000).
4182 The time stamps are only nanosecond-resolution at the C level,
4183 since that's the best that any real-world system supports now.
4184 But they are picosecond-resolution at the Lisp level, as that's
4185 easy, and leaves room for future OS improvements.
4186
4187 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
4188 (LIBES): Use it.
4189
4190 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
4191 Don't get current time unless it's needed.
4192
4193 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
4194 now provides it if it's absent.
4195 (start_atimer): Port to higher-res time stamps.
4196 Check for time stamp overflow. Don't get current time more
4197 often than is needed.
4198
4199 * buffer.h (struct buffer): Buffer modtime now has high resolution.
4200 Include systime.h, not time.h.
4201 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
4202
4203 * dired.c: Include stat-time.h.
4204 (Ffile-attributes): File times now have higher resolution.
4205
4206 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
4207 (struct image): Timestamp now has higher resolution.
4208
4209 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
4210 has at least microseconds now. All uses removed.
4211 (update_frame, update_single_window, update_window, update_frame_1)
4212 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 4213 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
4214
4215 * editfns.c (time_overflow): Now extern.
4216 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
4217 (float-time, Fformat_time_string, Fcurrent_time_string)
4218 (Fcurrent_time_zone): Accept and generate higher-resolution
4219 time stamps.
4220 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
4221 (decode_time_components, lisp_seconds_argument): New functions.
4222 (make_time): Now static.
4223 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
4224 Report an error if the time is invalid, rather than having the caller
4225 do that.
4226
4227 * fileio.c: Include <stat-time.h>
4228 (Fcopy_file): Copy higher-resolution time stamps.
4229 Prefer to set the time stamp via a file descriptor if that works.
4230 (Fset_file_times, Finsert_file_contents, Fwrite_region)
4231 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
4232 (Fvisited_file_modtime, Fset_visited_file_modtime):
4233 Support higher-resolution time stamps.
4234
4235 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
4236
4237 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
4238
4239 * image.c (prepare_image_for_display, clear_image_cache)
4240 (lookup_image): Port to higer-resolution time stamps.
4241
4242 * keyboard.c (start_polling, bind_polling_period):
4243 Check for time stamp overflow.
4244 (read_char, kbd_buffer_get_event, timer_start_idle)
4245 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
4246 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
4247 Port to higher-resolution time stamps. Do not assume time_t is signed.
4248 (decode_timer): New function. Timers are now vectors of length 9,
4249 not 8, to accommodate the picosecond component.
4250 (timer_check_2): Use it.
4251
4252 * nsterm.m (select_timeout, timeval_subtract): Remove.
4253 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
4254 as they're a bit more accurate and handle overflow better.
4255 (ns_select): Change prototype to be compatible with pselect.
4256 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
4257 * nsterm.h (ns_select): Adjust prototype.
4258
4259 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
4260 us-resolution time stamps.
4261 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
4262
4263 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
4264
4265 * lisp.h (time_overflow): New decl.
4266 (wait_reading_process_output): First arg is now intmax_t, not int,
4267 to accommodate larger waits.
4268
4269 * process.h (struct Lisp_Process.read_output_delay):
4270 Now counts nanoseconds, not microseconds.
4271 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
4272 EMACS_HAS_USECS.
4273 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
4274 (wait_reading_process_output):
4275 Port to ns-resolution time stamps.
4276 (Faccept_process_output, wait_reading_process_output):
4277 Check for time stamp overflow. Do not assume time_t is signed.
4278 (select_wrapper): Remove; we now use pselect.
4279 (Fprocess_attributes): Now generates ns-resolution time stamps.
4280
4281 * sysdep.c: Include utimens.h. Don't include utime.h
4282 or worry about struct utimbuf; gnulib does that for us now.
4283 (gettimeofday): Remove; gnulib provides a substitute.
4284 (make_timeval): New function.
4285 (set_file_times): Now sets ns-resolution time stamps.
4286 New arg FD; all uses changed.
4287 (time_from_jiffies, ltime_from_jiffies, get_up_time)
4288 (system_process_attributes):
4289 Now returns ns-resolution time stamp. All uses changed.
4290 Check for time stamp overflow.
4291
4292 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
4293 provides a substitute now.
4294
4295 * systime.h: Include timespec.h rather than sys/time.h and time.h,
4296 since it guarantees struct timespec.
4297 (EMACS_TIME): Now struct timespec, so that we can support
4298 ns-resolution time stamps.
4299 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
4300 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
4301 (EMACS_USECS): Remove.
4302 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
4303 so multiply the arg by 1000 before storing it.
4304 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
4305 New macros.
4306 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
4307 Port to ns-resolution time stamps.
4308 (EMACS_TIME_NEG_P): Remove; replaced by....
4309 (EMACS_TIME_SIGN): New macro.
4310 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
4311 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
4312 (set_file_times, make_time, lisp_time_argument): Adjust signature.
4313 (make_timeval, make_lisp_time, decode_time_components): New decls.
4314 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
4315 that it mishandled time_t overflow. You can't compare by subtracting!
4316 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
4317 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
4318
4319 * term.c: Include <sys/time.h>.
4320 (timeval_to_Time): New function, for proper overflow wraparound.
4321 (term_mouse_position, term_mouse_click): Use it.
4322
4323 * undo.c (record_first_change): Support higher-resolution time stamps
4324 in the undo buffer.
4325 (Fprimitive_undo): Use them when restoring time stamps.
4326
4327 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
4328 (w32_get_internal_run_time):
4329 Port to higher-resolution Emacs time stamps.
4330 (ltime): Now accepts single 64-bit integer, as that's more convenient
4331 for callers.
4332
4333 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
4334
4335 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
4336 for compatibility with pselect. Support ns-resolution time stamps.
4337
4338 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
4339
4340 * xselect.c (wait_for_property_change, x_get_foreign_selection):
4341 Check for time stamp overflow, and support ns-resolution time stamps.
4342
4343 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
4344 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
4345 (timeval_subtract): Remove; no longer needed.
4346 (XTflash, XTring_bell, x_wait_for_event):
4347 Port to ns-resolution time stamps. Don't assume time_t is signed.
4348
b6a92dfe
CY
43492012-06-22 Chong Yidong <cyd@gnu.org>
4350
4351 * xdisp.c (x_consider_frame_title): Revert last change.
4352
d251c37c
EZ
43532012-06-22 Eli Zaretskii <eliz@gnu.org>
4354
4355 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
4356 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
4357 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
4358 staticidx goes up to 1597 out of 1600 = 0x640.)
4359
f10deafb
PE
43602012-06-20 Paul Eggert <eggert@cs.ucla.edu>
4361
4362 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
4363 Otherwise, the umask might be mistakenly 0 while handling input signals.
4364
ec6de1e2
SM
43652012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
4366
4367 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
4368
28be1ada
DA
43692012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
4370
4371 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
4372 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
4373 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
4374 access to `contents' member of Lisp_Vector objects with AREF and ASET
4375 where appropriate.
4376
c6bf3022
CY
43772012-06-19 Chong Yidong <cyd@gnu.org>
4378
4379 * frame.c (delete_frame): When selecting a frame on a different
4380 text terminal, do not alter the terminal's top-frame.
4381
4382 * xdisp.c (format_mode_line_unwind_data): Record the target
4383 frame's selected window and its terminal's top-frame.
4384 (unwind_format_mode_line): Restore them.
4385 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
4386 Callers changed.
4387 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
4388 since tty frames can be explicitly named.
4389 (prepare_menu_bars): Likewise.
4390
4391 * term.c (Ftty_top_frame): New function.
4392
defd4196
PE
43932012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4394
4395 Port byte-code-meter to modern targets.
4396 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
4397 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 4398 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
4399 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
4400 (METER_1, METER_2): Simplify.
4401
1053a871
SM
44022012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
4403
4404 * data.c (Fdefalias): Return `symbol' (bug#11686).
4405
b7e8d081
MR
44062012-06-18 Martin Rudalics <rudalics@gmx.at>
4407
4408 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
4409 gets killed during executing of this function (Bug#11665).
4410 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
4411 (Vkill_buffer_query_functions): In doc-string say that functions
4412 run by this hook should not change the current buffer.
4413
7ea2b339
PE
44142012-06-18 Paul Eggert <eggert@cs.ucla.edu>
4415
4416 Fix recently-introduced process.c problems found by static checking.
4417 * process.c (write_queue_push, write_queue_pop, send_process):
4418 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
4419 (write_queue_pop): Fix pointer signedness problem.
4420 (send_process): Remove unused local.
4421
96a313a1
CY
44222012-06-17 Chong Yidong <cyd@gnu.org>
4423
4424 * xdisp.c (redisplay_internal): No need to redisplay terminal
4425 frames that are not on top.
4426
20ca2e94
TN
44272012-06-17 Troels Nielsen <bn.troels@gmail.com>
4428
4429 * process.c (make_process): Initialize write_queue.
4430 (write_queue_push, write_queue_pop): New functions.
4431 (send_process): Use them to maintain correct ordering of process
4432 writes (Bug#10815).
4433
9a900ca9
PE
44342012-06-17 Paul Eggert <eggert@cs.ucla.edu>
4435
310fbfa8
PE
4436 * lisp.h (eassert): Assume C89 or later.
4437 This removes the need for CHECK.
4438 (CHECK): Remove. Its comments about always evaluating its
4439 argument were confusing, as 'eassert' typically does not evaluate
4440 its argument.
4441
27bb1ca4
PE
4442 * coding.c (produce_chars): Use ptrdiff_t, not int.
4443
9a900ca9
PE
4444 * xterm.c (x_draw_underwave): Check for integer overflow.
4445 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
4446
41b7f8bc 44472012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
4448
4449 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
4450 referenced (Bug#11583).
4451
9b0e3eba
AA
44522012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
4453
4454 Implement wave-style variant of underlining.
4455 * dispextern.h (face_underline_type): New enum.
4456 (face): Add field for underline type.
4457 * nsterm.m (ns_draw_underwave): New function.
4458 (ns_draw_text_decoration): Use it.
4459 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
4460 New functions.
4461 (x_draw_glyph_string): Use them.
4462 * xfaces.c (Qline, Qwave): New Lisp objects.
4463 (check_lface_attrs, merge_face_ref)
1053a871
SM
4464 (Finternal_set_lisp_face_attribute, realize_x_face):
4465 Handle wave-style underline face attributes.
9b0e3eba
AA
4466 * xterm.c (x_draw_underwave): New function.
4467 (x_draw_glyph_string): Use it.
4468
0fb52f11
JB
44692012-06-16 Juanma Barranquero <lekktu@gmail.com>
4470
4471 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
4472 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
4473 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
4474 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
4475 ($(BLD)/w32select.$(O)): Update dependencies.
4476
e5560ff7
AS
44772012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4478
4479 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
4480 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
4481 * character.c (_fetch_multibyte_char_p): Remove.
4482 * alloc.c: Include "character.h" before "buffer.h".
4483 * bidi.c: Likewise.
4484 * buffer.c: Likewise.
4485 * bytecode.c: Likewise.
4486 * callint.c: Likewise.
4487 * callproc.c: Likewise.
4488 * casefiddle.c: Likewise.
4489 * casetab.c: Likewise.
4490 * category.c: Likewise.
4491 * cmds.c: Likewise.
4492 * coding.c: Likewise.
4493 * composite.c: Likewise.
4494 * dired.c: Likewise.
4495 * dispnew.c: Likewise.
4496 * doc.c: Likewise.
4497 * dosfns.c: Likewise.
4498 * editfns.c: Likewise.
4499 * emacs.c: Likewise.
4500 * fileio.c: Likewise.
4501 * filelock.c: Likewise.
4502 * font.c: Likewise.
4503 * fontset.c: Likewise.
4504 * fringe.c: Likewise.
4505 * indent.c: Likewise.
4506 * insdel.c: Likewise.
4507 * intervals.c: Likewise.
4508 * keyboard.c: Likewise.
4509 * keymap.c: Likewise.
4510 * lread.c: Likewise.
4511 * macros.c: Likewise.
4512 * marker.c: Likewise.
4513 * minibuf.c: Likewise.
4514 * nsfns.m: Likewise.
4515 * nsmenu.m: Likewise.
4516 * print.c: Likewise.
4517 * process.c: Likewise.
4518 * regex.c: Likewise.
4519 * region-cache.c: Likewise.
4520 * search.c: Likewise.
4521 * syntax.c: Likewise.
4522 * term.c: Likewise.
4523 * textprop.c: Likewise.
4524 * undo.c: Likewise.
4525 * unexsol.c: Likewise.
4526 * w16select.c: Likewise.
4527 * w32fns.c: Likewise.
4528 * w32menu.c: Likewise.
4529 * window.c: Likewise.
4530 * xdisp.c: Likewise.
4531 * xfns.c: Likewise.
4532 * xmenu.c: Likewise.
4533 * xml.c: Likewise.
4534 * xselect.c: Likewise.
4535
2f07e6af
EZ
45362012-06-16 Eli Zaretskii <eliz@gnu.org>
4537
1053a871
SM
4538 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
4539 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 4540 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
4541 row.
4542 (handle_face_prop): Use chunk-relative overlay string index when
4543 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
4544 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
4545 the rightmost. (Bug#11720)
2f07e6af 4546
29b83cec
AS
45472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
4548
4549 * category.h (CHAR_HAS_CATEGORY): Define as inline.
4550 (CATEGORY_MEMBER): Enforce 1/0 value.
4551 * category.c (_temp_category_set): Remove.
4552
4c5501e9
EZ
45532012-06-16 Eli Zaretskii <eliz@gnu.org>
4554
4555 * window.c (Fdelete_other_windows_internal)
4556 (Fdelete_window_internal): Don't access frame's mouse highlight
4557 info of the initial frame. (Bug#11677)
4558
2b570124
PE
45592012-06-14 Paul Eggert <eggert@cs.ucla.edu>
4560
e93864f9
PE
4561 * .gdbinit (xgetint): Fix recently-introduced paren typo.
4562 Assume USE_2_TAGS_FOR_INTS.
4563 (xreload): Adjust $tagmask width to match recent lisp.h change.
4564
2b570124
PE
4565 Simplify lisp.h in minor ways that should not affect code.
4566 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
4567 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
4568 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
4569 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
4570 (INTTYPEBITS): New macro, for clarity.
4571 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
4572 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
4573 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
4574 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
4575 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
4576
81755f69
JB
45772012-06-13 Juanma Barranquero <lekktu@gmail.com>
4578
4579 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
4580
16192a57
GM
45812012-06-13 Glenn Morris <rgm@gnu.org>
4582
4583 * s/bsd-common.h (BSD4_3):
4584 * s/usg5-4-common.h (USG5_4): No longer define; unused.
4585
646b5f55
AS
45862012-06-13 Andreas Schwab <schwab@linux-m68k.org>
4587
4588 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
4589 instead of union.
4590 (XLI, XIL): Define.
1053a871
SM
4591 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
4592 Use them.
4593 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 4594 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 4595 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
4596 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
4597 * frame.c (delete_frame): Remove outdated comment.
4598 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
4599 USE_LISP_UNION_TYPE.
4600 (Fw32_unregister_hot_key): Likewise.
4601 (Fw32_toggle_lock_key): Likewise.
4602 * w32menu.c (add_menu_item): Likewise.
4603 (w32_menu_display_help): Use XIL instead of checking
4604 USE_LISP_UNION_TYPE.
4605 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
4606 (init_heap): Likewise.
4607 * w32term.c (w32_read_socket): Update comment.
4608
1d3823c9
GM
46092012-06-13 Glenn Morris <rgm@gnu.org>
4610
c62ff706
GM
4611 * s/usg5-4-common.h, src/s/unixware.h:
4612 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
4613
1d3823c9
GM
4614 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
4615
bfe3e0a2
PE
46162012-06-13 Paul Eggert <eggert@cs.ucla.edu>
4617
4618 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
4619 * alloc.c (make_number) [!defined make_number]:
4620 Remove, as lisp.h always defines this now.
4621 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
4622 (roundup_size): Verify that it is a power of 2.
4623 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
4624 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
4625 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
4626 -DUSE_LSB_TAG=0, to override the automatically-selected default.
4627 USE_LSB_TAG now is always defined to be either 0 or 1.
4628 All uses changed.
4629 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
4630 code works fine either way, and efficiency is not a concern here,
4631 as the union type is for debugging, not for production.
4632 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
4633 Use an inline function on all platforms when using the union type,
4634 since this is simpler and 'static inline' can be used portably
4635 within Emacs now.
4636 (LISP_INITIALLY_ZERO): New macro.
4637 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
4638 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
4639
45fa9c0f
GM
46402012-06-12 Glenn Morris <rgm@gnu.org>
4641
b4492cba
GM
4642 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
4643
4644 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 4645
45fa9c0f
GM
4646 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
4647 Move BROKEN_SIGIO to configure.
4648
4649 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
4650 Move NO_TERMIO to configure.
4651
0e25d334
CY
46522012-06-12 Chong Yidong <cyd@gnu.org>
4653
4654 * image.c (imagemagick_load_image): Use MagickFlattenImage if
4655 MagickMergeImageLayers is undefined. Use pixel pusher loop if
4656 MagickExportImagePixels is undefined.
4657
43682bb6
PE
46582012-06-12 Paul Eggert <eggert@cs.ucla.edu>
4659
4660 * image.c (imagemagick_load_image): Remove unused label.
4661
a9be7d2b
GM
46622012-06-11 Glenn Morris <rgm@gnu.org>
4663
4664 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4665 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
4666 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
4667 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
4668
3017f87f
SM
46692012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
4670
4671 * alloc.c (make_byte_code): New function.
4672 (Fmake_byte_code): Use it. Don't purify here.
4673 * lread.c (read1): Use it as well to avoid extra allocation.
4674
1b9b4cf4
CY
46752012-06-11 Chong Yidong <cyd@gnu.org>
4676
4677 * image.c (imagemagick_load_image): Implement transparency.
4678
95988fcf
AS
46792012-06-10 Andreas Schwab <schwab@linux-m68k.org>
4680
4681 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
4682 account for preceding backslashes. (Bug#11663)
4683
cd4eb164
CY
46842012-06-09 Chong Yidong <cyd@gnu.org>
4685
4686 * term.c: Support italics in capable terminals (Bug#9652).
4687 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
4688 (turn_on_face): Output using TS_enter_italic_mode if available.
4689 Don't handle unused blinking and alt-charset cases.
4690 (turn_off_face): Handle italic case; discard unused tty_blinking_p
4691 and tty_alt_charset_p cases.
4692 (tty_capable_p, init_tty): Support italics.
4693
4694 * termchar.h (struct tty_display_info): Add field for italics.
4695 Remove unused blink field.
4696
4697 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
4698 Handle slant.
4699
4700 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
4701 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
4702 tty_alt_charset_p. Add tty_italic_p.
4703
ff88beb8
MA
47042012-06-09 Michael Albinus <michael.albinus@gmx.de>
4705
4706 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
4707 dbus_type_is_basic if available.
4708 (xd_extract_signed, xd_extract_unsigned): Rename from
4709 extract_signed and extract_unsigned, respectively. Adapt callers.
4710
44286096
CY
47112012-06-09 Chong Yidong <cyd@gnu.org>
4712
1682701f
CY
4713 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
4714
44286096
CY
4715 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
4716 case (Bug#9752).
4717
d86feb17
PE
47182012-06-08 Paul Eggert <eggert@cs.ucla.edu>
4719
4720 * xdisp.c (vmessage): Treat frame message as multibyte.
4721 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
4722 would generate the diagnostic "Making \302\247 buffer-local while
4723 let-bound!".
4724
d5c20fe8
EZ
47252012-06-08 Eli Zaretskii <eliz@gnu.org>
4726
4727 * dispnew.c (showing_window_margins_p): Undo last change, which
4728 was done due to an inadvertent commit.
4729 (adjust_frame_glyphs_for_frame_redisplay): Do call
4730 showing_window_margins_p.
4731
513749ee
SM
47322012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4733
4734 * eval.c (Fmake_var_non_special): New primitive.
4735 (syms_of_eval): Defsubr it.
4736 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
4737
d4a8f5c1
JB
47382012-06-08 Juanma Barranquero <lekktu@gmail.com>
4739
4740 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
4741 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
4742
8bbbc977
EZ
47432012-06-08 Eli Zaretskii <eliz@gnu.org>
4744
4745 * alloc.c (allocate_vectorlike): Fix last change.
4746
f3372c87
DA
47472012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
4748
4749 Block-based vector allocation of small vectors.
4750 * lisp.h (struct vectorlike_header): New field `nbytes',
4751 adjust comment accordingly.
4752 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
4753 to denote vector blocks. Adjust users (live_vector_p,
4754 mark_maybe_pointer, valid_lisp_object_p) accordingly.
4755 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
4756 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
4757 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
4758 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
4759 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
4760 (roundup_size): New constant.
4761 (struct vector_block): New data type.
4762 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 4763 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
4764 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
4765 (sweep_vectors): New functions.
4766 (allocate_vectorlike): Return `zero_vector' as the only vector of
4767 0 items. Allocate new vector from block if vector size is less than
4768 or equal to VBLOCK_BYTES_MAX.
4769 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
4770 (init_alloc_once): Add call to init_vectors.
4771
4f18a4ed
SM
47722012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
4773
4774 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
4775
86f158bc
PE
47762012-06-07 Paul Eggert <eggert@cs.ucla.edu>
4777
4778 * doprnt.c (doprnt): Truncate multibyte char correctly.
4779 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
4780 would mishandle a string argument "Xc" if X was a multibyte
4781 character of length 2: it would truncate after X's first byte
4782 rather than including all of X.
4783
c5cfcbe0
CY
47842012-06-06 Chong Yidong <cyd@gnu.org>
4785
4786 * buffer.c (word_wrap): Doc fix.
4787
c05cf390
PE
47882012-06-04 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
4791
0c3461de
GM
47922012-06-03 Glenn Morris <rgm@gnu.org>
4793
4794 * xdisp.c (tool-bar-style): Doc fix.
4795
c71232db
UM
47962012-06-03 Ulrich Müller <ulm@gentoo.org>
4797
4798 * Makefile.in (PAXCTL): Define.
4799 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4800 binary via PaX flags if the paxctl utility is available.
4801 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4802 Restore PaX flags to their default. (Bug#11398)
4803
383f7350
CY
48042012-06-03 Chong Yidong <cyd@gnu.org>
4805
4806 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4807 buffer (Bug#11226).
4808
5f2c76c6
CY
48092012-06-03 Chong Yidong <cyd@gnu.org>
4810
4811 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4812 (note_mode_line_or_margin_highlight): If there is no help echo,
4813 use mode-line-default-help-echo. Handle the case where the mouse
4814 position is past the end of the mode line string.
4815
4816 * buffer.c (buffer_local_value_1): New function, split from
4817 Fbuffer_local_value; can return Qunbound.
4818 (Fbuffer_local_value): Use it.
4819 (Vmode_line_format): Docstring tweaks.
4820
773d47f6
PE
48212012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4822
4823 * sysdep.c (system_process_attributes): Improve comment.
4824
f2d6a3df
SM
48252012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4826
4827 * keyboard.c: Export real-this-command to Elisp.
4828 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4829 and DEFVAR it. Update all users.
4830
63810350
PE
48312012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4832
7bd5c1f4
PE
4833 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4834
63810350
PE
4835 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4836 Convert pctcpu and pctmem to Lisp float properly.
4837 Let the compiler fold better, as 100.0/0x8000 is exact.
4838
a2821611
AS
48392012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4840
4841 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4842 cons_block.
4843
5fceba1d
PE
48442012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4845
4846 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4847
c98ff5dd
DA
48482012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4849
4850 For a 'struct window', replace some Lisp_Object fields to
4851 bitfields where appropriate, remove unused fields.
4852 * window.h (struct window): Remove unused 'last_mark_x' and
4853 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4854 change it's type from Lisp_Object to bitfield.
4855 Change type of 'force_start', 'optional_new_start',
4856 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4857 fields from Lisp_Object to bitfield. Adjust users accordingly.
4858
ca34e0be
PE
48592012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4860
4861 Pacify gcc -Wdouble-precision when using Xaw.
4862 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4863 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4864 Use 'float' consistently, rather than 'float' in most places
4865 and 'double' in a couple of places.
4866
efc00ab1 48672012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4868
4869 * xdisp.c (handle_stop): Detect whether we have overlay strings
4870 loaded by testing it->current.overlay_string_index to be
4871 non-negative, instead of checking whether n_overlay_strings is
4872 positive. (Bug#11587)
4873
efc00ab1 48742012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4875
4876 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4877
4878 * doc.c (Fsubstitute_command_keys): Doc fix.
4879
efc00ab1 48802012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4881
4882 * search.c (search_buffer): Remove calls to
4883 r_alloc_inhibit_buffer_relocation, as it is now called by
4884 maybe_unify_char, which was the cause of relocation of buffer text
4885 in bug#11519.
4886
efc00ab1 48872012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4888
4889 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4890 for the duration of call to load_charset, to avoid problems with
4891 callers of maybe_unify_char that access buffer text through C
4892 pointers.
4893
4894 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4895 decrement the inhibition flag, instead of just setting or
4896 resetting it.
4897
ba93a187
PE
48982012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4899
4900 Remove obsolete '#define static' cruft.
4901 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4902 This #undef was "temporary" in 2000; it is no longer needed
4903 now that '#define static' has gone away.
4904 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4905 (gray_bitmap_bits): Remove; no longer needed.
4906 All uses replaced with definiens.
4907 * xterm.c: Include "bitmaps/gray.xbm".
4908
9e4bf381
PE
49092012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4910
4911 Clean up __executable_start, monstartup when --enable-profiling.
4912 The following changes affect the code only when profiling.
4913 * dispnew.c (__executable_start): Rename from safe_bcopy.
4914 Define only on platforms that need it.
4915 * emacs.c: Include <sys/gmon.h> when profiling.
4916 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4917 (__executable_start): Remove decl, since lisp.h does it now.
4918 (safe_bcopy): Remove decl; no longer has that name.
4919 (main): Coalesce #if into single bit of code, for simplicity.
4920 Cast pointers to uintptr_t, since standard libraries want integers
4921 and not pointers.
4922 * lisp.h (__executable_start): New decl.
4923
32d72c2f
GM
49242012-05-31 Glenn Morris <rgm@gnu.org>
4925
4926 * image.c (Fimagemagick_types): Doc fix.
4927
baac5bc7
JM
49282012-05-30 Jim Meyering <meyering@redhat.com>
4929
4930 * callproc.c (Fcall_process_region): Include directory component
4931 in mkstemp error message (Bug#11586).
4932
72cb32cf
PE
49332012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4934
4935 * alloc.c, lisp.h (make_pure_vector): Now static.
4936
61b108cc
SM
49372012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4938
4939 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4940 Move to byte-run.el.
4941 (Fautoload): Do the hash-doc more carefully.
4942 * data.c (Fdefalias): Purify definition, except for keymaps.
4943 (Qdefun): Move from eval.c.
4944 * lisp.h (Qdefun): Remove.
4945 * lread.c (read1): Tiny simplification.
4946
471fe23d
TN
49472012-05-29 Troels Nielsen <bn.troels@gmail.com>
4948
934f3f58 4949 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4950 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4951 Bug#9642, but explicitly check that the buffer the overlay would
4952 be moved to is live and rearrange lines to make sure that errors
4953 will not put the overlay in an inconsistent state.
4954 (Fdelete_overlay): Cosmetics.
4955
85d0efd1
EZ
49562012-05-28 Eli Zaretskii <eliz@gnu.org>
4957
4958 * w32term.c (my_bring_window_to_top): New function.
4959 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4960 could be different from the original one.
4961 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4962 (Bug#11513)
4963
4964 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4965 by calling BringWindowToTop.
4966
4967 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4968 (WM_EMACS_END): Increase by one.
4969
da92a98c
PE
49702012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4971
4972 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4973 This avoids undefined behavior that might cause the eassert
4974 to not catch an out-of-range value.
4975
74d1f848
JB
49762012-05-28 Juanma Barranquero <lekktu@gmail.com>
4977
4978 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4979 Update dependencies.
4980
9e1a06fc
EZ
49812012-05-27 Eli Zaretskii <eliz@gnu.org>
4982
4983 * bidi.c (bidi_mirror_char): Fix last change.
4984
f3dd7312
AS
49852012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4986
4987 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4988 when referring to sectname field in printf format.
4989
81899c91
PE
49902012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4991
57b81a9f
PE
4992 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4993 Only r_alloc_inhibit_buffer_relocation needed to be added;
4994 the others were already declared.
4995
81899c91
PE
4996 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4997 before checking whether it's out of range. Put the check inside
4998 eassert. See
4999 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
5000
33017faf 50012012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
5002
5003 * callproc.c (Fcall_process): Restore a line that was accidentally
5004 commented out in the 2011-02-13 change (bug#11547).
5005
33017faf 50062012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
5007
5008 * lisp.h [REL_ALLOC]: Add prototypes for external functions
5009 defined on ralloc.c.
5010
5011 * buffer.c [REL_ALLOC]: Remove prototypes of
5012 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
5013 they are now on lisp.h.
5014
5015 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
5016
5017 * search.c (search_buffer): Use it to inhibit relocation of buffer
5018 text while re_search_2 is doing its job, because re_search_2 is
5019 passed C pointers to buffer text. (Bug#11519)
5020
23415acf
EZ
5021 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
5022 Update value to 24.
5023
44e27368
EZ
5024 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
5025 state after an additional call to move_it_in_display_line_to, keep
5026 the values of it->max_ascent and it->max_descent found for the
5027 entire line.
5028 (pos_visible_p): Revert the comparison against bottom_y to what it
5029 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
5030 (Bug#11464)
5031
c1892f11
PE
50322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5033
5034 Fix coding-related core dumps with gcc -ftrapv.
5035 The code was computing A - B, where A and B are pointers, and B is
5036 random garbage. This can lead to core dumps on platforms that
5037 have special pointer registers, and it also leads to core dumps on
5038 x86-64 when compiled with gcc -ftrapv. The fix is to compute
5039 A - B only when B is initialized properly.
5040 * coding.c (coding_set_source, coding_set_destination): Return void.
5041 (coding_change_source, coding_change_destinations): New functions,
5042 with the old behaviors of coding_set_source and coding_set_destination.
5043 All callers that need an offset changed to use these new functions.
5044
eb7afdad
GM
50452012-05-26 Glenn Morris <rgm@gnu.org>
5046
5047 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
5048
f12fdf02
EZ
50492012-05-26 Eli Zaretskii <eliz@gnu.org>
5050
53a63be6 5051 Extend mouse support on W32 text-mode console.
61b108cc
SM
5052 * xdisp.c (draw_row_with_mouse_face):
5053 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 5054
eb3f6f01 5055 * w32console.c: Include window.h.
61b108cc
SM
5056 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
5057 New functions.
eb3f6f01
EZ
5058 (initialize_w32_display): Initialize mouse-highlight data.
5059
53a63be6
EZ
5060 * w32inevt.c: Include termchar.h and window.h.
5061 (do_mouse_event): Support mouse-autoselect-window. When the mouse
5062 moves, call note_mouse_highlight. If help_echo changed, call
5063 gen_help_event to produce help-echo message in the echo area.
5064 Call clear_mouse_face if mouse_face_hidden is set in the mouse
5065 highlight info.
5066
4cfd81f6
PE
50672012-05-26 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 * lread.c (read1): Simplify slightly to avoid an overflow warning
5070 with GCC 4.7.0 on x86-64.
5071
4446092a
EZ
50722012-05-26 Eli Zaretskii <eliz@gnu.org>
5073
5074 * bidi.c (bidi_mirror_char): Revert last change: an int is
5075 definitely wide enough here.
5076
42b2a986 50772012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 5078
42b2a986 5079 Fix integer width and related bugs (Bug#9874).
eb106a49 5080 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
5081 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5082 (string_bytes, check_sblock, allocate_string_data):
5083 (compact_small_strings, Fmake_bool_vector, make_string)
5084 (make_unibyte_string, make_multibyte_string)
5085 (make_string_from_bytes, make_specified_string)
5086 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
5087 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
5088 (mark_vectorlike):
5089 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5090 (allocate_pseudovector):
5091 Use int, not EMACS_INT, where int is wide enough.
5092 (inhibit_garbage_collection, Fgarbage_collect):
5093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5094 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
5095 int might not be wide enough.
5096 (bidi_cache_search, bidi_cache_find, bidi_init_it)
5097 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
5098 (bidi_at_paragraph_end, bidi_find_paragraph_start)
5099 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5100 (bidi_level_of_next_char, bidi_move_to_visually_next):
5101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5102 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
5103 (Fkill_buffer, Fset_buffer_major_mode)
5104 (advance_to_char_boundary, Fbuffer_swap_text)
5105 (Fset_buffer_multibyte, overlays_at, overlays_in)
5106 (overlay_touches_p, struct sortvec, record_overlay_string)
5107 (overlay_strings, recenter_overlay_lists)
5108 (adjust_overlays_for_insert, adjust_overlays_for_delete)
5109 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
5110 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
5111 (Foverlay_recenter, last_overlay_modification_hooks_used)
5112 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
5113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
5114 (validate_region): Omit unnecessary test for b <= e,
5115 since that's guaranteed by the previous test.
d311d28c
PE
5116 (adjust_overlays_for_delete): Avoid pos + length overflow.
5117 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
5118 (report_overlay_modification):
5119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5120 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
5121 Omit pointer cast, which isn't needed anyway, and doesn't work
5122 after the EMACS_INT -> ptrdiff_t change.
02481186 5123 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
5124 * buffer.h: Adjust decls to match defn changes elsewhere.
5125 (struct buffer_text, struct buffer):
5126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5127 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
5128 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
5129 not int, to avoid needless 32-bit limit on 64-bit hosts.
5130 (exec_byte_code): Use tighter memory-full test, one that checks
5131 for alloca overflow. Don't compute the address of the object just
5132 before an array, as that's not portable. Use EMACS_INT, not
5133 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
5134 * callint.c (Fcall_interactively):
5135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5136 * callproc.c (call_process_kill, Fcall_process):
5137 Don't assume pid_t fits into an Emacs fixnum.
5138 (call_process_cleanup, Fcall_process, child_setup):
5139 Don't assume pid_t fits into int.
5140 (call_process_cleanup, Fcall_process, delete_temp_file)
5141 (Fcall_process_region):
5142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5143 (Fcall_process): Simplify handling of volatile integers.
5144 Use int, not EMACS_INT, where int will do.
5145 * casefiddle.c (casify_object, casify_region, operate_on_word)
5146 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
5147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5148 (casify_object): Avoid integer overflow when overallocating buffer.
5149 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 5150 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
5151 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
5152 * category.h (CATEGORYP): Don't assume arg is nonnegative.
5153 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
5154 integers are now checked earlier. All uses replaced with XINT.
5155 (ccl_driver):
5156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5157 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
5158 (ccl_driver, Fregister_code_conversion_map):
5159 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
5160 (resolve_symbol_ccl_program): Check that vector header is in range.
5161 Always copy the vector, so that we can check its contents reliably
5162 now rather than having to recheck each instruction as it's being
5163 executed. Check that vector words fit in 'int'.
5164 (ccl_get_compiled_code, Fregister_ccl_program)
5165 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
5166 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
5167 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
5168 contents are in range.
5169 (Fccl_execute_on_string): Check that status is in range.
5170 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
5171 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
5172 Accept and return EMACS_INT, not int, because callers can pass values
5173 out of 'int' range.
5174 (c_string_width, strwidth, lisp_string_width, chars_in_text)
5175 (multibyte_chars_in_text, parse_str_as_multibyte)
5176 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
5177 (str_as_unibyte, str_to_unibyte, string_count_byte8)
5178 (string_escape_byte8, Fget_byte):
5179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 5180 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
5181 avoid mishandling large integers.
5182 * character.h: Adjust decls to match defn changes elsewhere.
5183 * charset.c (load_charset_map_from_file, find_charsets_in_text)
5184 (Ffind_charset_region):
5185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5186 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
5187 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 5188 Don't assume fixnum fits in int.
d311d28c
PE
5189 (load_charset_map_from_vector, Fmap_charset_chars):
5190 Remove now-unnecessary CHECK_NATNUMs.
5191 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
5192 Don't rely on undefined behavior with signed left shift overflow.
5193 Don't assume unsigned int fits into fixnum, or that fixnum fits
5194 into unsigned int. Don't require max_code to be a valid fixnum;
5195 that's not true for gb10830 4-byte on a 32-bit host. Allow
5196 invalid_code to be a cons, for the same reason. Require code_offset
5197 to be a character. Avoid int overflow if max_char is close
5198 to INT_MAX.
5199 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
5200 this is intended anyway and avoids some undefined behavior.
5201 (load_charset_map): Pass unsigned, not int, as 2nd arg of
5202 INDEX_TO_CODE_POINT, as that's what it expects.
5203 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
5204 * charset.h (DECODE_CHAR): Return int, not unsigned;
5205 this is what was intended anyway, and it avoids undefined behavior.
5206 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
5207 integer-overflow issues.
5208 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
5209 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
5210 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
5211 * chartab.c (Fmake_char_table, Fset_char_table_range)
5212 (uniprop_get_decoder, uniprop_get_encoder):
5213 Don't assume fixnum fits in int.
5214 * cmds.c (move_point): New function, that does the gist of
5215 Fforward_char and Fbackward_char, but does so while checking
5216 for integer overflow more accurately.
c96e5d6a 5217 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
5218 (Fforward_line, Fend_of_line, internal_self_insert)
5219 (internal_self_insert):
5220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5221 Fix a FIXME, by checking for integer overflow when calculating
5222 target_clm and actual_clm.
5223 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 5224 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
5225 (ASSURE_DESTINATION, coding_alloc_by_realloc)
5226 (coding_alloc_by_making_gap, alloc_destination)
5227 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
5228 (encode_coding_utf_16, detect_coding_emacs_mule)
5229 (decode_coding_emacs_mule, encode_coding_emacs_mule)
5230 (detect_coding_iso_2022, decode_coding_iso_2022)
5231 (encode_invocation_designation, encode_designation_at_bol)
5232 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5233 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
5234 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
5235 (encode_coding_ccl, encode_coding_raw_text)
5236 (detect_coding_charset, decode_coding_charset)
5237 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
5238 (produce_composition, produce_charset, produce_annotation)
5239 (decode_coding, handle_composition_annotation)
5240 (handle_charset_annotation, consume_chars, decode_coding_gap)
5241 (decode_coding_object, encode_coding_object, detect_coding_system)
5242 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
5243 (code_convert_region, code_convert_string)
8f50130c
PE
5244 (Fdefine_coding_system_internal)
5245 (coding_set_source, coding_set_destination):
d311d28c
PE
5246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5247 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
5248 (Fdefine_coding_system_internal):
5249 Don't assume fixnums fit in int.
5250 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 5251 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
5252 (Funencodable_char_position, Fcheck_coding_systems_region)
5253 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 5254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 5255 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 5256 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 5257 Don't access memory outside of the args array.
d311d28c 5258 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
5259 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
5260 result of ENCODE_CHAR.
d311d28c
PE
5261 * coding.h: Adjust decls to match defn changes elsewhere.
5262 (struct coding_system):
5263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5264 * composite.c (get_composition_id, find_composition)
5265 (run_composition_function, update_compositions)
5266 (compose_text, composition_gstring_put_cache)
5267 (composition_gstring_p, composition_gstring_width)
5268 (fill_gstring_header, fill_gstring_body, autocmp_chars)
5269 (composition_compute_stop_pos, composition_reseat_it)
5270 (composition_update_it, struct position_record)
5271 (find_automatic_composition, composition_adjust_point)
5272 (Fcomposition_get_gstring, Ffind_composition_internal):
5273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5274 (update_compositions):
5275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5276 * composite.h: Adjust decls to match defn changes elsewhere.
5277 (struct composition):
5278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5279 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
5280 Do not attempt to compute the address of the object just before a
5281 buffer; this is not portable.
5282 (Faref, Faset):
5283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5284 (Faset): Use int, not EMACS_INT, where int is wide enough.
5285 (Fstring_to_number): Don't assume fixnums fit in int.
5286 (Frem): Don't assume arg is nonnegative.
5287 * dbusbind.c (xd_append_arg): Check for integers out of range.
5288 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 5289 (extract_signed, extract_unsigned): New functions.
243e0530
PE
5290 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
5291 (xd_get_connection_references): Return ptrdiff_t, not int.
5292 All uses changed.
5293 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
5294 (xd_read_message_1):
5295 Use int, not unsigned, where the dbus API uses int.
5296 (Fdbus_message_internal): Don't overflow mtype.
5297 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
5298 * dired.c (directory_files_internal, file_name_completion, scmp)
5299 (file_name_completion_stat):
5300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5301 (file_name_completion): Don't overflow matchcount.
5302 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
5303 * dispextern.h: Adjust decls to match defn changes elsewhere.
5304 (struct text_pos, struct glyph, struct bidi_saved_info)
5305 (struct bidi_string_data, struct bidi_it, struct composition_it)
5306 (struct it):
5307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5308 (struct display_pos, struct composition_it, struct it):
5309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5310 * dispnew.c (increment_matrix_positions)
5311 (increment_row_positions, mode_line_string)
5312 (marginal_area_string):
5313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 5314 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
5315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5316 (duration_to_sec_usec): New function, to check for overflow better.
5317 (Fsleep_for, sit_for): Use it.
5318 * doc.c (get_doc_string, store_function_docstring):
5319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5320 (get_doc_string, Fsnarf_documentation):
5321 Use int, not EMACS_INT, where int is wide enough.
5322 (get_doc_string):
5323 Use SAFE_ALLOCA, not alloca.
5324 Check for overflow when converting EMACS_INT to off_t.
5325 * doprnt.c (doprnt):
5326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5327 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
5328 Don't assume uid_t fits into fixnum.
5329 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
5330 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
5331 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
5332 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
5333 (general_insert_function)
5334 (Finsert_char, make_buffer_string, make_buffer_string_both)
5335 (update_buffer_properties, Fbuffer_substring)
5336 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
5337 (Fsubst_char_in_region, check_translation)
5338 (Ftranslate_region_internal, save_restriction_restore, Fformat)
5339 (transpose_markers, Ftranspose_regions):
5340 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5341 (clip_to_bounds): Move to lisp.h as an inline function).
5342 (Fconstrain_to_field): Don't assume integers are nonnegative.
5343 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
5344 (Fsubst_char_in_region, Fsave_restriction):
5345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5346 (Femacs_pid): Don't assume pid_t fits into fixnum.
5347 (lo_time): Use int, not EMACS_INT, when int suffices.
5348 (lisp_time_argument): Check for usec out of range.
5349 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
5350 (Fuser_login_name, Fuser_full_name): Signal an error
5351 if a uid argument is out of range, rather than relying on
5352 undefined behavior.
c8d5c857
PE
5353 (Fformat_time_string): Remove now-unnecessary check.
5354 lisp_time_argument checks for out-of-range usec now.
243e0530 5355 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
5356 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
5357 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
5358 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
5359 (init_cmdargs, Fdump_emacs):
5360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5361 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
5362 the bottom (typically) 32 bits of the fixnum.
5363 * eval.c (specpdl_size, call_debugger):
5364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5365 (when_entered_debugger, Fbacktrace_debug):
5366 Don't assume fixnum can fit in int.
5367 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
5368 the object just before a buffer; this is not portable.
5369 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
5370 (grow_specpdl, unbind_to):
5371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5372 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
5373 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 5374 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
5375 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
5376 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
5377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5378 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
5379 (a_write, e_write):
5380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5381 (Fcopy_file, non_regular_nbytes, read_non_regular)
5382 (Finsert_file_contents):
5383 Use int, not EMACS_INT, where int is wide enough.
5384 (READ_BUF_SIZE): Verify that it fits in int.
5385 (Finsert_file_contents): Check that counts are in proper range,
5386 rather than assuming fixnums fit into ptrdiff_t etc.
5387 Don't assume fixnums fit into int.
125b3835 5388 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
5389 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
5390 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
5391 (string_char_to_byte, string_byte_to_char)
5392 (string_make_multibyte, string_to_multibyte)
5393 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
5394 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
5395 (substring_both, Fdelete, internal_equal, Ffillarray)
5396 (Fclear_string, mapcar1)
5397 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
5398 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
5399 (larger_vector, make_hash_table, maybe_resize_hash_table)
5400 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
5401 (Fmaphash, secure_hash):
5402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5403 (concat): Check for string index and length overflow.
5404 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
5405 (Frequire):
5406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5407 (larger_vector): New API (vec, incr_min, size_max) replaces old
5408 one (vec, new_size, init). This catches size overflow.
5409 INIT was removed because it was always Qnil.
5410 All callers changed.
5411 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
5412 the upper bound on a hash table index size.
5413 (make_hash_table, maybe_resize_hash_table): Use it.
5414 (secure_hash): Computer start_byte and end_byte only after
5415 they're known to be in ptrdiff_t range.
5416 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
5417 (Ffont_get_glyphs, Ffont_at):
5418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5419 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
5420 (Flist_fonts, Fopen_font):
5421 Don't assume fixnum can fit in int.
5422 (check_gstring): Don't assume index can fit in int.
5423 (font_match_p): Check that fixnum is a character, not a nonnegative
5424 fixnum, since the later code needs to stuff it into an int.
5425 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
5426 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
5427 conversion overflow issues.
5428 (Fopen_font): Check for integer out of range.
5429 (Ffont_get_glyphs): Don't assume index can fit in int.
5430 * font.h: Adjust decls to match defn changes elsewhere.
5431 * fontset.c (reorder_font_vector): Redo score calculation to avoid
5432 integer overflow.
5433 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
5434 printmax_t, where ptrdiff_t is wide enough.
5435 (Finternal_char_font):
5436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5437 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
5438 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
5439 (Fset_frame_position, x_set_frame_parameters)
5440 (x_set_line_spacing, x_set_border_width)
5441 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
5442 Check that fixnums are in proper range for system types.
5443 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
5444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5445 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
5446 Use SAFE_ALLOCA_LISP, not alloca.
5447 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
5448 intptr_t is wide enough.
5449 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
5450 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
5451 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
5452 Check for fixnum out of range.
5453 * ftfont.c (ftfont_list): Don't assume index fits in int.
5454 Check that fixnums are in proper range for system types.
5455 (ftfont_shape_by_flt):
5456 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
5457 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5459 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
5460 Check that fixnums are in proper range for system types.
5461 * gnutls.h: Adjust decls to match defn changes elsewhere.
5462 * gtkutil.c (xg_dialog_run):
5463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5464 (update_frame_tool_bar):
5465 Check that fixnums are in proper range for system types.
5466 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 5467 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
5468 * indent.c (last_known_column, last_known_column_point):
5469 (current_column_bol_cache):
5470 (skip_invisible, current_column, check_display_width):
5471 (check_display_width, scan_for_column, current_column_1)
5472 (Findent_to, Fcurrent_indentation, position_indentation)
5473 (indented_beyond_p, Fmove_to_column, compute_motion):
5474 (Fcompute_motion, Fvertical_motion):
5475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5476 (last_known_column_modified): Use EMACS_INT, not int.
5477 (check_display_width):
5478 (Fcompute_motion):
5479 Check that fixnums and floats are in proper range for system types.
5480 (compute_motion): Don't assume index or fixnum fits in int.
5481 (compute_motion, Fcompute_motion):
5482 Use int, not EMACS_INT, when it is wide enough.
5483 (vmotion): Omit local var start_hpos that is always 0; that way
5484 we don't need to worry about overflow in expressions involving it.
5485 * indent.h: Adjust decls to match defn changes elsewhere.
5486 (struct position):
5487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5488 Use int, not EMACS_INT, where int is wide enough.
5489 Remove unused members ovstring_chars_done and tab_offset;
5490 all uses removed.
5491 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
5492 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
5493 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
5494 (make_gap, copy_text, insert, insert_and_inherit)
5495 (insert_before_markers, insert_before_markers_and_inherit)
5496 (insert_1, count_combining_before, count_combining_after)
5497 (insert_1_both, insert_from_string)
5498 (insert_from_string_before_markers, insert_from_string_1)
5499 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
5500 (adjust_after_replace, adjust_after_insert, replace_range)
5501 (replace_range_2, del_range, del_range_1, del_range_byte)
5502 (del_range_both, del_range_2, modify_region)
5503 (prepare_to_modify_buffer, signal_before_change)
5504 (signal_after_change, Fcombine_after_change_execute):
5505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5506 * intervals.c (traverse_intervals, rotate_right, rotate_left)
5507 (balance_an_interval, split_interval_right, split_interval_left)
5508 (find_interval, next_interval, update_interval)
5509 (adjust_intervals_for_insertion, delete_node, delete_interval)
5510 (interval_deletion_adjustment, adjust_intervals_for_deletion)
5511 (static_offset_intervals, offset_intervals)
5512 (merge_interval_right, merge_interval_left, make_new_interval)
5513 (graft_intervals_into_buffer, temp_set_point_both)
5514 (temp_set_point, set_point, adjust_for_invis_intang)
5515 (set_point_both, move_if_not_intangible, get_property_and_range)
5516 (get_local_map, copy_intervals, copy_intervals_to_string)
5517 (compare_string_intervals, set_intervals_multibyte_1):
5518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5519 * intervals.h: Adjust decls to match defn changes elsewhere.
5520 (struct interval):
5521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5522 * keyboard.c (this_command_key_count, this_single_command_key_start)
5523 (before_command_key_count, before_command_echo_length, echo_now)
5524 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
5525 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
5526 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
5527 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
5528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5529 (last_non_minibuf_size, last_point_position, echo_truncate)
5530 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
5531 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
5532 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
5533 (stuff_buffered_input):
5534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5535 (last_auto_save, command_loop_1, read_char):
5536 Use EMACS_INT, not int, to avoid integer overflow.
5537 (record_char): Avoid overflow in total_keys computation.
5538 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
5539 * keyboard.h: Adjust decls to match defn changes elsewhere.
5540 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
5541 (Fkey_description, Fdescribe_vector, Flookup_key):
5542 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5543 (click_position): New function, to check that positions are in range.
5544 (Fcurrent_active_maps):
5545 (describe_command):
5546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5547 (Faccessible_keymaps, Fkey_description):
5548 (preferred_sequence_p):
5549 Don't assume fixnum can fit into int.
5550 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
5551 Check for integer overflow in size calculations.
5552 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
5553 avoid mishandling large integers.
5554 * lisp.h: Adjust decls to match defn changes elsewhere.
5555 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
5556 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
5557 (struct Lisp_Marker):
5558 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5559 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
5560 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
5561 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
5562 All callers changed.
5563 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
5564 Assume the arg has valid form, since it always does.
5565 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
5566 unsigned integer system type.
5567 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
5568 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
5569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5570 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
5571 (duration_to_sec_usec): New decl.
5572 * lread.c (read_from_string_index, read_from_string_index_byte)
5573 (read_from_string_limit, readchar, unreadchar, openp)
5574 (read_internal_start, read1, oblookup):
5575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5576 (Fload, readevalloop, Feval_buffer, Feval_region):
5577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5578 (openp): Check for out-of-range argument to 'access'.
5579 (read1): Use int, not EMACS_INT, where int is wide enough.
5580 Don't assume fixnum fits into int.
6efdadfd 5581 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
5582 (read_filtered_event): Use duration_to_sec_usec
5583 to do proper overflow checking on durations.
d311d28c
PE
5584 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
5585 in size calculation.
5586 (Fexecute_kbd_macro):
5587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5588 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
5589 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
5590 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
5591 (set_marker_both, set_marker_restricted_both, marker_position)
5592 (marker_byte_position, Fbuffer_has_markers_at):
5593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5594 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 5595 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
5596 It now merely ensures that the menu is large enough, without
5597 necessarily growing it, as this avoids some integer overflow issues.
5598 All callers changed.
5599 (keymap_panes, parse_single_submenu, Fx_popup_menu):
5600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5601 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
5602 Use SAFE_ALLOCA_LISP, not alloca.
5603 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
5604 to EMACS_INT. Check that fixnums are in proper range for system types.
5605 * minibuf.c (minibuf_prompt_width, string_to_object)
5606 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
5607 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
5608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5609 (get_minibuffer, read_minibuf_unwind):
5610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5611 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
5612 this simplifies overflow checking. All callers changed.
5613 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
5614 (Ftest_completion):
5615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5616 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
5617 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
5618 Check that fixnums are in proper range for system types.
5619 (Fx_create_frame, Fx_show_tip):
5620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5621 * nsfont.m (ns_findfonts, nsfont_list_family):
5622 Don't assume fixnum fits in long.
5623 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
5624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5625 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
5626 wide enough.
17fdb222 5627 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
5628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5629 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
5630 (PRINTDECLARE, PRINTPREPARE):
5631 (strout, print_string):
5632 (print, print_preprocess, print_check_string_charset_prop)
5633 (print_object):
5634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5635 (PRINTDECLARE):
5636 (temp_output_buffer_setup, Fprin1_to_string, print_object):
5637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5638 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 5639 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 5640 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
5641 (print_error_message): Use SAFE_ALLOCA, not alloca.
5642 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
5643 (print_depth, new_backquote_output, print_number_index):
5644 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
5645 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
5646 (Fset_process_window_size, Fformat_network_address)
5647 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 5648 (sigchld_handler):
d311d28c 5649 Check that fixnums are in proper range for system types.
d44287d4 5650 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
5651 Check for process-ids out of pid_t range rather than relying on
5652 undefined behavior.
e4d81efc 5653 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
5654 (Fformat_network_address, read_process_output, send_process)
5655 (Fprocess_send_region, status_notify):
5656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5657 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
5658 (wait_reading_process_output, read_process_output, exec_sentinel):
5659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5660 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
5661 (Faccept_process_output): Use duration_to_sec_usec to do proper
5662 overflow checking on durations.
dde14581
PE
5663 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
5664 Don't assume pid_t fits in int.
02481186
PE
5665 * process.h (struct Lisp_Process): Members tick and update_tick
5666 are now of type EMACS_INT, not int.
b62b53e8
PE
5667 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
5668 configured --with-wide-int.
d311d28c
PE
5669 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
5670 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
5671 * search.c (looking_at_1, string_match_1):
5672 (fast_string_match, fast_c_string_match_ignore_case)
5673 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
5674 (scan_newline, find_before_next_newline, search_command)
5675 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
5676 (set_search_regs, wordify):
5677 (Freplace_match):
5678 (Fmatch_data):
5679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5680 (string_match_1, search_buffer, set_search_regs):
5681 (Fmatch_data):
5682 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5683 (wordify): Check for overflow in size calculation.
5684 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
5685 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
5686 Check that fixnums are in proper range for system types.
5687 * sound.c (struct sound_device)
5688 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
5689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5690 (Fplay_sound_internal):
5691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 5692 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
5693 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
5694 (Fparse_partial_sexp):
5695 Don't assume fixnums can fit in int.
5696 (struct lisp_parse_state, find_start_pos, find_start_value)
5697 (find_start_value_byte, find_start_begv)
5698 (update_syntax_table, char_quoted, dec_bytepos)
5699 (find_defun_start, prev_char_comend_first, back_comment):
5700 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
5701 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
5702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5703 (Finternal_describe_syntax_value): Check that match_lisp is a
5704 character, not an integer, since the code stuffs it into int.
5705 (scan_words, scan_sexps_forward):
5706 Check that fixnums are in proper range for system types.
5707 (Fforward_word):
5708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5709 (scan_sexps_forward):
5710 Use CHARACTERP, not INTEGERP, since the value must fit into int.
5711 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
5712 * syntax.h: Adjust decls to match defn changes elsewhere.
5713 (struct gl_state_s):
5714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
5715 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
5716 MOST_POSITIVE_FIXNUM.
d311d28c
PE
5717 * sysdep.c (wait_for_termination_1, wait_for_termination)
5718 (interruptible_wait_for_termination, mkdir):
5719 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
5720 (emacs_read, emacs_write):
5721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
5722 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
5723 and double all fit in int.
d311d28c
PE
5724 * term.c (set_tty_color_mode):
5725 Check that fixnums are in proper range for system types.
5726 * termhooks.h (struct input_event):
5727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5728 * textprop.c (validate_interval_range, interval_of)
5729 (Fadd_text_properties, set_text_properties_1)
5730 (Fremove_text_properties, Fremove_list_of_text_properties)
5731 (Ftext_property_any, Ftext_property_not_all)
5732 (copy_text_properties, text_property_list, extend_property_ranges)
5733 (verify_interval_modification):
5734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5735 (Fnext_single_char_property_change)
5736 (Fprevious_single_char_property_change):
5737 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
5738 (copy_text_properties):
5739 Check for integer overflow in index calculation.
d311d28c
PE
5740 * undo.c (last_boundary_position, record_point, record_insert)
5741 (record_delete, record_marker_adjustment, record_change)
5742 (record_property_change):
5743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5744 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
5745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5746 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5747 (Fx_hide_tip, Fx_file_dialog):
5748 * w32menu.c (set_frame_menubar):
5749 Use ptrdiff_t, not int, for consistency with rest of code.
5750 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
5751 (select_window, Fdelete_other_windows_internal)
5752 (window_scroll_pixel_based, window_scroll_line_based)
5753 (Frecenter, Fset_window_configuration):
5754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5755 (Fset_window_hscroll, run_window_configuration_change_hook)
5756 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 5757 (Fscroll_other_window, Frecenter):
d311d28c
PE
5758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5759 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
5760 Don't assume fixnum fits in int.
5761 (Fset_window_scroll_bars):
5762 Check that fixnums are in proper range for system types.
5763 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
5764 (string_pos, c_string_pos, number_of_chars, init_iterator)
5765 (in_ellipses_for_invisible_text_p, init_from_display_pos)
5766 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
5767 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
5768 (face_before_or_after_it_pos, handle_invisible_prop)
5769 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
5770 (display_prop_intangible_p, string_buffer_position_lim)
5771 (string_buffer_position, handle_composition_prop, load_overlay_strings)
5772 (get_overlay_strings_1, get_overlay_strings)
5773 (iterate_out_of_display_property, forward_to_next_line_start)
5774 (back_to_previous_visible_line_start, reseat, reseat_to_string)
5775 (get_next_display_element, set_iterator_to_next)
5776 (get_visually_first_element, compute_stop_pos_backwards)
5777 (handle_stop_backwards, next_element_from_buffer)
5778 (move_it_in_display_line_to, move_it_in_display_line)
5779 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5780 (add_to_log, message_dolog, message_log_check_duplicate)
5781 (message2, message2_nolog, message3, message3_nolog
5782 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
5783 (current_message_1, truncate_echo_area, truncate_message_1)
5784 (set_message, set_message_1, store_mode_line_noprop)
5785 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
5786 (text_outside_line_unchanged_p, check_point_in_composition)
5787 (reconsider_clip_changes)
5788 (redisplay_internal, set_cursor_from_row, try_scrolling)
5789 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
5790 (redisplay_window, find_last_unchanged_at_beg_row)
5791 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
5792 (trailing_whitespace_p, find_row_edges, display_line)
5793 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
5794 (display_mode_element, store_mode_line_string)
5795 (pint2str, pint2hrstr, decode_mode_spec)
5796 (display_count_lines, display_string, draw_glyphs)
5797 (x_produce_glyphs, x_insert_glyphs)
5798 (rows_from_pos_range, mouse_face_from_buffer_pos)
5799 (fast_find_string_pos, mouse_face_from_string_pos)
5800 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5802 (safe_call, init_from_display_pos, handle_fontified_prop)
5803 (handle_single_display_spec, load_overlay_strings)
5804 (with_echo_area_buffer, setup_echo_area_for_printing)
5805 (display_echo_area, echo_area_display)
5806 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5807 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5808 (redisplay_window, dump_glyph_row, display_mode_line)
5809 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5810 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5812 (handle_single_display_spec, build_desired_tool_bar_string)
5813 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5814 (get_specified_cursor_type):
5815 Check that fixnums are in proper range for system types.
5816 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5817 (Flookup_image_map):
5818 Don't assume fixnums fit in int.
5819 (compare_overlay_entries):
5820 Avoid mishandling comparisons due to subtraction overflow.
5821 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5822 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5823 (handle_tool_bar_click):
5824 Use int, not unsigned, since we prefer signed and the signedness
5825 doesn't matter here.
5826 (get_next_display_element, next_element_from_display_vector):
5827 Use int, not EMACS_INT, when int is wide enough.
5828 (start_hourglass): Use duration_to_sec_usec to do proper
5829 overflow checking on durations.
5830 * xfaces.c (Fbitmap_spec_p):
5831 Check that fixnums are in proper range for system types.
5832 (compare_fonts_by_sort_order):
5833 Avoid mishandling comparisons due to subtraction overflow.
5834 (Fx_family_fonts, realize_basic_faces):
5835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5836 (Fx_family_fonts):
5837 Don't assume fixnum fits in int.
5838 Use SAFE_ALLOCA_LISP, not alloca.
5839 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5840 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5841 (face_at_buffer_position, face_for_overlay_string)
5842 (face_at_string_position):
5843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5844 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5845 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5846 (Fx_show_tip):
5847 Check that fixnums are in proper range for system types.
5848 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5849 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5851 (Fx_change_window_property): Don't assume fixnums fit in int.
5852 * xfont.c (xfont_chars_supported):
5853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5854 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5855 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5857 * xml.c (parse_region):
5858 * xrdb.c (magic_file_p):
5859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5860 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5861 (x_get_local_selection, x_reply_selection_request)
5862 (x_handle_selection_request, wait_for_property_change):
5863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5864 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5865 short is wide enough.
5866 (x_send_client_event): Don't assume fixnum fits in int.
5867 * xterm.c (x_x_to_emacs_modifiers):
5868 Don't assume EMACS_INT overflows nicely into int.
5869 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5870 may come from Lisp.
5871 (handle_one_xevent): NATNUMP can eval its arg twice.
5872 (x_connection_closed):
5873 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5874 * xterm.h: Adjust decls to match defn changes elsewhere.
5875 (struct scroll_bar): Use struct vectorlike_header
5876 rather than rolling our own approximation.
5877 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5878
c6574eb5
GM
58792012-05-25 Glenn Morris <rgm@gnu.org>
5880
5881 * lisp.mk (lisp): Update for more files being compiled now.
5882
e8d32c7e
SM
58832012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5884
48def666
SM
5885 * lread.c: Remove `read_pure' which makes no difference.
5886 (read_pure): Remove var.
5887 (unreadpure): Remove function.
5888 (readevalloop): Don't call read_list with -1 flag.
5889 (read1, read_vector): Don't test read_pure any more.
5890 (read_list): Simplify.
5891
e8d32c7e
SM
5892 * fileio.c, character.h: Minor style tweaks.
5893
4b2addb7
DA
58942012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5895
5896 * window.h (clip_changed): Remove useless declaration.
5897
584461b2
JB
58982012-05-22 Juanma Barranquero <lekktu@gmail.com>
5899
5900 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5901 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5902
34374650
PE
59032012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5904
5905 Remove src/m/*.
5906 This directory predates autoconf and is no longer needed nowadays.
5907 Move its few remaining bits of functionality to where they're needed.
5908 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5909 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5910 * m/template.h: Remove.
5911 * Makefile.in (M_FILE): Remove. All uses removed.
5912 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5913 * lisp.h (USE_LSB_TAG):
5914 * mem-limits.h (EXCEEDS_LISP_PTR):
5915 Use VAL_MAX, not VALBITS, in #if.
5916 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5917 (EMACS_UINT): Define unconditionally now.
5918 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5919 (BITS_PER_EMACS_INT): New constants, replacing
5920 what used to be in config.h, but not useful in #if.
5921 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5922 define them any more.
5923 (VAL_MAX): New macro.
5924 (VALMASK): Use it.
5925 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5926 BITS_PER_EMACS_INT, in #if.
5927 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5928 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5929 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5930 * s/ms-w32.h (DATA_START):
5931 Move here from removed file m/intel386.h.
5932 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5933 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5934
261cb4bb
PE
59352012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5936
5937 Assume C89 or later.
5938 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5939 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5940 (xrealloc):
5941 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5942 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5943 * textprop.c, tparam.c (NULL): Remove.
5944 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5945 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5946 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5947 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5948 * xterm.c (input_signal_count): Assume volatile works.
5949
ff23cd9f
KB
59502012-05-21 Ken Brown <kbrown@cornell.edu>
5951
5952 * xgselect.c (xg_select): Fix first argument in call to 'select'
5953 (bug#11508).
5954
1b170bc6
KB
59552012-05-20 Ken Brown <kbrown@cornell.edu>
5956
5957 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5958 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5959
b2f4d39f
KB
59602012-05-19 Ken Brown <kbrown@cornell.edu>
5961
5962 * xfns.c (x_in_use): Remove `static' qualifier.
5963 * xterm.h (x_in_use): Declare.
5964 * xgselect.c: Include xterm.h.
5965 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5966 and `display_arg' (bug#9754).
5967
003fdae2
PE
59682012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5969
9232a6d9
PE
5970 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5971
003fdae2
PE
5972 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5973 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5974
784b56e2
EZ
59752012-05-18 Eli Zaretskii <eliz@gnu.org>
5976
5977 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5978
5979 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5980 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5981
5982 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5983 reference to image_cache->refcount.
5984 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5985
a0a79cde
JL
59862012-05-17 Juri Linkov <juri@jurta.org>
5987
5988 * search.c (Fword_search_regexp, Fword_search_backward)
5989 (Fword_search_forward, Fword_search_backward_lax)
5990 (Fword_search_forward_lax): Move functions to isearch.el
5991 (bug#10145, bug#11381).
5992
b0572523
PE
59932012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5994
5995 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5996
9660f5fc
SM
59972012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5998
5999 * lread.c (init_obarray): Declare Qt and Qnil as special.
6000
4374de83
GM
60012012-05-14 Glenn Morris <rgm@gnu.org>
6002
6003 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 6004 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 6005
dc44c39a
PE
60062012-05-14 Paul Eggert <eggert@cs.ucla.edu>
6007
078c97cb
PE
6008 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
6009
dc44c39a
PE
6010 * unexaix.c: Port to more-recent AIX compilers.
6011 (report_error, report_error_1, make_hdr, copy_sym)
6012 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
6013 Make arguments const char *, not char *, to avoid violations of C
6014 standard and to fix some AIX warnings reported by Gilles Pion.
6015
e18afed7 60162012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
6017
6018 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
6019 already have overlays loaded.
6020 (handle_single_display_spec): Before returning without displaying
6021 fringe bitmap, synchronize the bidi iterator with the main display
6022 iterator, by calling iterate_out_of_display_property.
6023 (iterate_out_of_display_property): Detect buffer iteration by
6024 testing that it->string is a Lisp string.
6025 (get_next_display_element): When the current object is exhausted,
6026 and there's something on it->stack, call set_iterator_to_next to
6027 proceed with what's on the stack, instead of returning zero.
6028 (set_iterator_to_next): If called at the end of a Lisp string,
6029 proceed to consider_string_end without incrementing string
6030 position. Don't increment display vector index past the end of
6031 the display vector. (Bug#11417)
c8fb9dc6
EZ
6032 (pos_visible_p): Don't report a position visible when move_it_to
6033 stopped at the last line of window, which happens to be scanned
6034 backwards by the bidi iteration. (Bug#11464)
ac268e67 6035
e18afed7 60362012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
6037
6038 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
6039 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
6040 are on a TTY, and thus unable to display on the fringes.
6041 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
6042 so we need to signal to the caller that this is a "replacing"
6043 display spec. This fixes display when the spec is invalid or we
6044 are on a TTY.
6045
e18afed7 60462012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
6047
6048 * unexaix.c (make_hdr): Fix typo in prototype.
6049 This bug broke the build on AIX. Problem reported by Gilles Pion.
6050
9d0a235a
MA
60512012-05-14 Michael Albinus <michael.albinus@gmx.de>
6052
6053 * keyboard.c (kbd_buffer_get_event): Read special events also in
6054 batch mode. (Bug#11415)
6055
9e6b06ed
GM
60562012-05-12 Glenn Morris <rgm@gnu.org>
6057
6058 * ns.mk: Update for ns_appbindir no longer having trailing "/".
6059
c1a1d7a3
EZ
60602012-05-12 Eli Zaretskii <eliz@gnu.org>
6061
6062 * lisp.mk (lisp): Add newcomment.elc.
6063
3fe7cdc8
GM
60642012-05-12 Glenn Morris <rgm@gnu.org>
6065
6066 * Makefile.in (MKDIR_P): New, set by configure.
6067 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
6068
53f7d2c0
PE
60692012-05-11 Paul Eggert <eggert@cs.ucla.edu>
6070
6071 Remove unused function hourglass_started.
6072 * dispextern.h (hourglass_started):
6073 * w32fns.c (hourglass_started):
6074 * xdisp.c (hourglass_started): Remove.
6075
75aafb17
JB
60762012-05-10 Juanma Barranquero <lekktu@gmail.com>
6077
6078 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
6079 Update dependencies.
6080
12959e8e
PE
60812012-05-10 Paul Eggert <eggert@cs.ucla.edu>
6082
97107e2e
PE
6083 * xgselect.c (xg_select): Put maxfds+1 into a var.
6084 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
6085
12959e8e
PE
6086 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
6087
836d29b3
DA
60882012-05-10 Dave Abrahams <dave@boostpro.com>
6089
6090 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
6091 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
6092
5cb67954
MA
60932012-05-09 Michael Albinus <michael.albinus@gmx.de>
6094
6095 * dbusbind.c (xd_registered_buses): New internal Lisp object.
6096 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
6097 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
6098 Initialize xd_registered_buses.
6099
3478ec45
PE
61002012-05-09 Paul Eggert <eggert@cs.ucla.edu>
6101
b263a6b0
PE
6102 Untag more efficiently if USE_LSB_TAG.
6103 This is based on a proposal by YAMAMOTO Mitsuharu in
6104 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
6105 For an admittedly artificial (nth 8000 longlist) benchmark on
6106 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
6107 Emacs's overall text size by 1%.
6108 * lisp.h (XUNTAG): New macro.
6109 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
6110 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
6111 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
6112 * eval.c (Fautoload):
6113 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
6114 * frame.h (XFRAME): Use XUNTAG.
6115
3478ec45
PE
6116 Port recent dbusbind.c changes to 32-bit --with-wide-int.
6117 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
6118 Remove unportable assumptions about print widths of types like
6119 dbus_uint32_t.
6120 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
6121 intptr_t when converting between pointer and integer, to avoid GCC
6122 warnings about wrong width.
6123
666b903b 61242012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
6125
6126 * w32proc.c (new_child): Force Windows to reserve only 64KB of
6127 stack for each reader_thread, instead of defaulting to 8MB
6128 determined by the linker. This avoids failures in creating
6129 subprocesses on Windows 7, see the discussion in this thread:
6130 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
6131
b120cc17
JC
61322012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
6133
6134 Fix up display of the *Minibuf-0* buffer in the mini window.
6135 * keyboard.c (read_char): Don't clear the echo area if there's no
6136 message to clear.
6137 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 6138 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 6139
9a4b36f8
MA
61402012-05-07 Michael Albinus <michael.albinus@gmx.de>
6141
6142 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
6143 batch mode.
6144
e5f9458f
CY
61452012-05-06 Chong Yidong <cyd@gnu.org>
6146
6147 * lisp.mk (lisp): Update.
6148
eceeb5fc 61492012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
6150
6151 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
6152
71873e2b
SM
61532012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
6154
6155 * data.c (PUT_ERROR): New macro.
6156 (syms_of_data): Use it. Add new error type `user-error'.
6157 * undo.c (user_error): New function.
6158 (Fprimitive_undo): Use it.
6159 * print.c (print_error_message): Adjust print style for `user-error'.
6160 * keyboard.c (user_error): New function.
6161 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
6162
ab0fa4e4
PE
61632012-05-03 Paul Eggert <eggert@cs.ucla.edu>
6164
6165 Do not limit current-time-string to years 1000..9999.
6166 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
6167 (Fcurrent_time_string): Support any year that is supported by the
6168 underlying localtime representation. Don't use asctime, as it
6169 has undefined behavior for years outside the range -999..9999.
6170
7ed806a7
PE
61712012-05-02 Paul Eggert <eggert@cs.ucla.edu>
6172
6173 Fix race conditions involving setenv, gmtime, localtime, asctime.
6174 Without this fix, interrupts could mess up code that uses these
6175 nonreentrant functions, since setting TZ invalidates existing
6176 tm_zone or tzname values, and since most of these functions return
6177 pointers to static storage.
6178 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
6179 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
6180 Grow the critical sections to include not just invoking
6181 localtime/gmtime, but also accessing these functions' results
6182 including their tm_zone values if any, and any related TZ setting.
6183 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
6184 so that the struct tm is saved in the critical section.
6185 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
6186 motivated by the fact that memory allocation needs to be outside
6187 the critical section.
6188
0c16dfed
DA
61892012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
6190
6191 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
6192 with RESET_INTERVAL.
6193
6194 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6195 Remove duplicated buffer name initialization.
6196
3f83ace8
JM
61972012-05-02 Jim Meyering <jim@meyering.net>
6198
6199 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
6200
c7b8541e
JM
6201 * xfns.c (x_window): Use xstrdup (Bug#11375).
6202
90207a15 62032012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
6204
6205 * xdisp.c (pos_visible_p): If already at a newline from the
6206 display string before the 'while' loop, don't walk back the glyphs
6207 from it3.glyph_row. Solves assertion violation when the display
6208 string begins with a newline (egg.el). (Bug#11367)
6209
b593d6a9
AH
62102012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
6211
6212 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
6213 Move to simple.el.
6214
4737362e
GM
62152012-05-01 Glenn Morris <rgm@gnu.org>
6216
99cf43f9
GM
6217 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
6218 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
6219 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
6220 All were removed before 23.1.
6221
9311dcff
GM
6222 * dispnew.c: Remove HAVE_LIBNCURSES test;
6223 it is always true on relevant platforms.
6224
4d5c6349
GM
6225 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
6226 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
6227
4737362e
GM
6228 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
6229
74dd3a6b
AS
62302012-04-30 Andreas Schwab <schwab@linux-m68k.org>
6231
6232 * .gdbinit (xpr): Remove checks for no longer existing misc types.
6233 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
6234 Remove.
6235
13c379ee
PE
62362012-04-28 Paul Eggert <eggert@cs.ucla.edu>
6237
6238 Do not avoid creating empty evaporating overlays (Bug#9642).
6239 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
6240 That is, do not delete an evaporating overlay if it becomes
6241 empty after its bounds are adjusted to fit within its buffer.
6242 This fix caused other problems, and I'm reverting it until we get
6243 to the bottom of them.
6244
a8e7d6d7 62452012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
6246
6247 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
6248
a8e7d6d7 62492012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
6250
6251 * xdisp.c (pos_visible_p): If the window start position is beyond
6252 ZV, start the display from buffer beginning. Prevents assertion
6253 violation in init_iterator when the minibuffer window is scrolled
6254 via the scroll bar.
6255
6256 * window.c (window_scroll_pixel_based): Likewise.
6257
a8e7d6d7 62582012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
6259
6260 * keymap.c (where_is_internal): Doc fix (Bug#10872).
6261
a8e7d6d7 62622012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
6263
6264 * fileio.c (Fcopy_file, Fset_file_selinux_context):
6265 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
6266
a8e7d6d7 62672012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 6268
b593d6a9
AH
6269 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
6270 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 6271
1c6900d9
EZ
62722012-04-26 Eli Zaretskii <eliz@gnu.org>
6273
4c3fa1d9
EZ
6274 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
6275 display element, check also the underlying string or buffer
6276 character. (Bug#11341)
6277
1c6900d9
EZ
6278 * w32menu.c: Include w32heap.h.
6279 (add_menu_item): If the call to AppendMenuW (via
6280 unicode_append_menu) fails, disable Unicode menus only if we are
6281 running on Windows 9X/Me.
6282
42bf8205
AS
62832012-04-24 Andreas Schwab <schwab@linux-m68k.org>
6284
6285 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
6286 (xgetint): Add missing shift for LSB tags.
6287
b1bac16e
MR
62882012-04-24 Martin Rudalics <rudalics@gmx.at>
6289
6290 * keyboard.c (read_char): Don't wipe echo area for select window
6291 events: These might get delayed via `mouse-autoselect-window'
6292 (Bug#11304).
6293
d69621cc
JB
62942012-04-24 Juanma Barranquero <lekktu@gmail.com>
6295
6296 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
6297 manipulation of :loaded-from data.
6298
02fd101b
JB
62992012-04-23 Juanma Barranquero <lekktu@gmail.com>
6300
6301 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
6302 now a cons (bug#11311).
6303
888bec30
PE
63042012-04-23 Paul Eggert <eggert@cs.ucla.edu>
6305
89a438bd
PE
6306 Do not create empty overlays with the evaporate property (Bug#9642).
6307 * buffer.c (Fmove_overlay): Delete an evaporating overlay
6308 if it becomes empty after its bounds are adjusted to fit within
6309 its buffer. Without this fix, in a nonempty buffer (let ((o
6310 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
6311 yields an empty overlay that has the evaporate property, which is
6312 not supposed to happen.
6313
1068fe4d
PE
6314 Fix minor GTK3 problems found by static checking.
6315 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6316 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6317 (struct _EmacsFixedClass, emacs_fixed_get_type):
6318 Move decls here from emacsgtkfixed.h, since they needn't be public.
6319 (emacs_fixed_get_type): Now static.
6320 (emacs_fixed_class_init): Omit unused local.
6321 (emacs_fixed_child_type): Remove; unused.
6322 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
6323 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
6324 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
6325 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
6326 (EMACS_FIXED_GET_CLASS): Remove; unused.
6327 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
6328
888bec30
PE
6329 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
6330 Problem reported by Juanma Barranquero for Windows -Wunused-function.
6331
de85e130
PE
63322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6333
d0baac98 6334 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 6335 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
6336 (__malloc_size_t, __malloc_ptrdiff_t):
6337 Remove. All uses removed, replaced by the definiens if needed,
6338 since we can assume C89 or better now.
6339 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
6340 (protect_malloc_state, align, get_contiguous_space)
6341 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
6342 (malloc_atfork_handler_child, malloc_enable_thread)
6343 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
6344 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
6345 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
6346 (special_realloc, _realloc_internal_nolock, _realloc_internal)
6347 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
6348 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
6349 Define using prototypes, not old style.
6350 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
6351 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
6352 (align): Don't assume that signed integer overflow wraps around.
6353 Omit unused local var.
6354 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
6355 (_free_internal_nolock, memalign, mallochook, reallochook):
6356 Omit no-longer-needed casts.
6357 (valloc): Use getpagesize, not __getpagesize.
6358 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
6359 (struct hdr): The 'magic' member is now size_t, not unsigned long.
6360
de85e130
PE
6361 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
6362
dcbf5805
MA
63632012-04-22 Michael Albinus <michael.albinus@gmx.de>
6364
6365 Move functions from C to Lisp. Make non-blocking method calls
6366 the default. Implement further D-Bus standard interfaces.
6367
6368 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
6369 (QCdbus_request_name_allow_replacement)
6370 (QCdbus_request_name_replace_existing)
6371 (QCdbus_request_name_do_not_queue)
6372 (QCdbus_request_name_reply_primary_owner)
6373 (QCdbus_request_name_reply_in_queue)
6374 (QCdbus_request_name_reply_exists)
6375 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
6376 (QCdbus_registered_serial, QCdbus_registered_method)
6377 (QCdbus_registered_signal): New Lisp objects.
6378 (XD_DEBUG_MESSAGE): Use sizeof.
6379 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
6380 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
6381 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
6382 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
6383 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
6384 (xd_signature, xd_append_arg): Allow float for integer types.
6385 (xd_get_connection_references): New function.
b593d6a9
AH
6386 (xd_get_connection_address): Rename from xd_initialize.
6387 Return cached address.
dcbf5805
MA
6388 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
6389 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
6390 level.
6391 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 6392 Return number of refcounts.
dcbf5805
MA
6393 (Fdbus_get_unique_name): Make stronger parameter check.
6394 (Fdbus_message_internal): New defun.
6395 (Fdbus_call_method, Fdbus_call_method_asynchronously)
6396 (Fdbus_method_return_internal, Fdbus_method_error_internal)
6397 (Fdbus_send_signal, Fdbus_register_service)
6398 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
6399 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
6400 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
6401 (Vdbus_compiled_version, Vdbus_runtime_version)
6402 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
6403 (Vdbus_message_type_method_return, Vdbus_message_type_error)
6404 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
6405 (Vdbus_registered_buses, Vdbus_registered_objects_table):
6406 Adapt docstring.
dcbf5805 6407
52828e02
PE
64082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6409
da05bc4c
PE
6410 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
6411 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
6412 Do not assume ptrdiff_t is the same width as 'int'.
6413
52828e02
PE
6414 * alloc.c: Handle unusual debugging option combinations.
6415 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
6416 since the two debugging options are incompatible.
6417 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
6418 is defined.
6419 (mem_init, mem_insert, mem_insert_fixup):
6420 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
6421 (NEED_MEM_INSERT): Remove; no longer needed.
6422
f01769f9
LL
64232012-04-22 Leo Liu <sdl.web@gmail.com>
6424
6425 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
6426
5790543d
PE
64272012-04-22 Paul Eggert <eggert@cs.ucla.edu>
6428
6429 * sysdep.c [__FreeBSD__]: Minor cleanups.
6430 (list_system_processes, system_process_attributes) [__FreeBSD__]:
6431 Use Emacs indenting style more consistently. Avoid some casts.
6432 Use 'double' consistently rather than mixing 'float' and 'double'.
6433
b91b7e4d
EW
64342012-04-21 Eduard Wiebe <usenet@pusto.de>
6435
b593d6a9
AH
6436 * sysdep.c (list_system_processes, system_process_attributes):
6437 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 6438
6114eb15
AS
64392012-04-21 Andreas Schwab <schwab@linux-m68k.org>
6440
6441 * lisp.mk (lisp): Update.
6442
2f38dff7
PE
64432012-04-20 Paul Eggert <eggert@cs.ucla.edu>
6444
6445 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
6446 It is never used otherwise.
6447
4ae29f89
SM
64482012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
6449
6450 * print.c (print_preprocess): Only check print_depth if print-circle
6451 is nil.
6452 (print_object): Check for cycles even when print-circle is nil and
6453 print-gensym is t, but only check print_depth if print-circle is nil.
6454
f30d612a
CY
64552012-04-20 Chong Yidong <cyd@gnu.org>
6456
6457 * process.c (wait_reading_process_output): If EIO occurs on a pty,
6458 set the status to "failed" and ensure that sentinel is run.
6459
c07a4c0b 64602012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
6461
6462 * process.c (Fset_process_inherit_coding_system_flag)
6463 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 6464 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 6465
c07a4c0b 64662012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
6467
6468 * xdisp.c (string_buffer_position_lim): Limit starting position to
6469 BEGV.
6470 (set_cursor_from_row): If called for a mode-line or header-line
6471 row, return zero immediately.
6472 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
6473 farther than the first row after the header line, if any.
6474 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
6475 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
6476
c07a4c0b 64772012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6478
4ae29f89
SM
6479 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
6480 (bug#11238).
ad3a2b41 6481
c07a4c0b 64822012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 64832012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
6484
6485 configure: new option --enable-gcc-warnings (Bug#11207)
6486 * Makefile.in (C_WARNINGS_SWITCH): Remove.
6487 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
6488 (ALL_CFLAGS): Use new macros rather than old.
6489 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
6490 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
6491 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
6492 -Wunused-result, -Wunused-variable. This should go away once
6493 the Emacs and Gnulib regex code is merged.
6494 (xmalloc, xrealloc): Now static.
6495
aba027e8
PE
64962012-04-17 Paul Eggert <eggert@cs.ucla.edu>
6497
6498 * dired.c (Fsystem_groups): Remove unused local.
6499
e5a36063
GM
65002012-04-17 Glenn Morris <rgm@gnu.org>
6501
6502 * dired.c (Fsystem_users): Doc fix.
6503
316411f0
DA
65042012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
6505
6506 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
6507 (syms_of_dired): Add them.
6508
9426aba4
PE
65092012-04-16 Paul Eggert <eggert@cs.ucla.edu>
6510
b62a57be
PE
6511 Fix minor alloc.c problems found by static checking.
6512 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
6513 New extern decls, to avoid calling undeclared functions.
6514 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
6515 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
6516 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
6517 (NEED_MEM_INSERT): New macro.
6518 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 6519 Remove one incorrect comment and fix another.
b62a57be 6520
3539f31f
PE
6521 Fix minor ralloc.c problems found by static checking.
6522 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6523 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6524 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
6525 (r_alloc_sbrk): Now static.
6526
a041960a
PE
6527 Improve ralloc.c interface checking.
6528 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
6529 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
6530 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
6531 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
6532 [REL_ALLOC]: ... to here, to check interface.
6533 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
6534 Remove decls. This fixes an "It stinks!".
6535
9426aba4
PE
6536 * alloc.c (which_symbols): Fix alignment issue / type clash.
6537
d55c12ed
AS
65382012-04-15 Andreas Schwab <schwab@linux-m68k.org>
6539
6540 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
6541 (struct Lisp_Misc_Any): Likewise.
6542 (struct Lisp_Free): Likewise.
6543 * alloc.c (union aligned_Lisp_Symbol): Define.
6544 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
6545 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
6546 (union aligned_Lisp_Misc): Define.
6547 (MARKER_BLOCK_SIZE, struct marker_block): Use union
6548 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 6549 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 6550
b948ce8b
PE
65512012-04-14 Paul Eggert <eggert@cs.ucla.edu>
6552
6553 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
6554 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
6555 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
6556 * s/netbsd.h, s/sol2-6.h:
6557 Remove definition of GC_MARK_STACK, since the default now works.
6558 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
6559 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
6560 no longer the default.
6561 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
6562
35dc09a1 65632012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 6564
35dc09a1
GM
6565 * lread.c (lisp_file_lexically_bound_p):
6566 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 6567
35dc09a1
GM
65682012-04-14 Eli Zaretskii <eliz@gnu.org>
6569
6570 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
6571 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
6572
65732012-04-14 Jan Djärv <jan.h.d@swipnet.se>
6574
6575 * nsterm.m (constrainFrameRect): Always constrain when there is only
6576 one screen (Bug#10962).
6577
bcd86815
KB
65782012-04-13 Ken Brown <kbrown@cornell.edu>
6579
6580 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
6581
c25df26e
RT
65822012-04-13 Reuben Thomas <rrt@sc3d.org>
6583
6584 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
6585
0fc59f1e
DC
65862012-04-11 Daniel Colascione <dancol@dancol.org>
6587
6588 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
6589 against is gone. It's better to use vfork now so that when Cygwin
6590 gains a new, working vfork, we use it automatically (bug#10398).
6591
de8c03dc
SM
65922012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6593
6594 * window.c (save_window_save): Obey window-point-insertion-type.
6595
2f097256
GM
65962012-04-11 Glenn Morris <rgm@gnu.org>
6597
6598 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
6599
453b951e
SM
66002012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
6601
6602 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
6603
75f1671a 66042012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
6605
6606 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
6607 (force_quit_count): New var.
6608 (handle_interrupt): Use it.
6609
2a8ce227
JB
66102012-04-10 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * w32.c (w32_delayed_load): Record the full path of the library
6613 being loaded (bug#10424).
6614
935396c0
GM
66152012-04-09 Glenn Morris <rgm@gnu.org>
6616
05920a43
GM
6617 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
6618 not just in the obarray, before snarfing them. (Bug#11036)
6619
935396c0
GM
6620 * Makefile.in ($(leimdir)/leim-list.el):
6621 Pass EMACS rather than BUILT_EMACS.
6622
a18ecafa
TZ
66232012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
6624
6625 * process.c (make_process):
6626 * process.h: Add integer `gnutls_handshakes_tried' member to
6627 process struct.
6628
6bbef4e5
JC
6629 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
6630 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
6631
6632 * gnutls.c (gnutls_log_function2i): Convenience log function.
6633 (emacs_gnutls_read): Use new log functions,
6634 `gnutls_handshakes_tried' process member, and
6635 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
6636 attempts per process (connection).
6637
b4d3bc10
CY
66382012-04-09 Chong Yidong <cyd@gnu.org>
6639
6640 * eval.c (Fuser_variable_p, user_variable_p_eh)
6641 (lisp_indirect_variable): Functions deleted.
6642 (Fdefvar): Caller changed.
6643
6644 * callint.c (Finteractive, Fcall_interactively):
6645 * minibuf.c (Fread_variable): Callers changed.
6646
70f4d973
EZ
66472012-04-09 Eli Zaretskii <eliz@gnu.org>
6648
6649 * xdisp.c (set_cursor_from_row): If the display string appears in
6650 the buffer at position that is closer to point than the position
6651 after the display string, display the cursor on the first glyph of
6652 the display string. Fixes cursor display when a 'display' text
6653 property immediately follows invisible text. (Bug#11094)
6654
cb3c2e3e
PE
66552012-04-09 Paul Eggert <eggert@cs.ucla.edu>
6656
6657 composite.c: use 'double' consistently
6658 * composite.c (get_composition_id): Use 'double' consistently
6659 instead of converting 'float' to 'double' and vice versa; this is
6660 easier to understand and avoids a GCC warning.
6661
fd06db5d
GM
66622012-04-09 Glenn Morris <rgm@gnu.org>
6663
50fe702a
GM
6664 * Makefile.in: Generate leim-list with bootstrap-emacs, in
6665 preparation for dumping it with emacs. (Bug#4789)
6666 (leimdir): New variable.
6667 ($(leimdir)/leim-list.el): New rule.
6668 (emacs$(EXEEXT)): Depend on leim-list.el.
6669
fd06db5d
GM
6670 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
6671 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
6672 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
6673
55c131ee
AS
66742012-04-08 Andreas Schwab <schwab@linux-m68k.org>
6675
6676 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
6677 proper alignment.
6678
9209588f
JB
66792012-04-07 Juanma Barranquero <lekktu@gmail.com>
6680
6681 * xml.c (init_libxml2_functions) [WINDOWSNT]:
6682 Remove unused local variable.
6683
e3fb2efb
PE
66842012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6685
6686 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
6687 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
6688 (mark_memory): Mark Lisp_Objects only if pointers might hide in
6689 objects, as mark_maybe_pointer will catch them otherwise.
6690 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
6691 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
6692
b5385551
PE
66932012-04-07 Paul Eggert <eggert@cs.ucla.edu>
6694
6695 Fix typo that broke non-Windows builds.
6696 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
6697
9078ead6
EZ
66982012-04-07 Eli Zaretskii <eliz@gnu.org>
6699
6700 Support building on MS-Windows with libxml2.
6701
6702 * makefile.w32-in (OBJ2): Add xml.$(O).
6703 (GLOBAL_SOURCES): Add xml.c.
6704 ($(BLD)/xml.$(O)): New dependency list.
6705
6706 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
6707 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
6708 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
6709 [!WINDOWSNT]: New macros.
6710 (init_libxml2_functions, libxml2_loaded_p): New functions.
6711 (parse_region): Call fn_xmlCheckVersion instead of using the macro
6712 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
6713 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
6714 Calls xmlCleanupParser only if libxml2 was loaded (or statically
6715 linked in).
6bbef4e5
JC
6716 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
6717 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
6718 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
6719
6720 * emacs.c: Don't include libxml/parser.h.
6721 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
6722 xmlCleanupParser directly.
6723
6724 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
6725
3811fdf3
EZ
67262012-04-07 Eli Zaretskii <eliz@gnu.org>
6727
6728 * indent.c (Fvertical_motion): If there is a display string at
6729 point, use it.vpos to compute how many lines to backtrack after
6730 move_it_to point. (Bug#11133)
6731
2f8e16b2
EZ
67322012-04-06 Eli Zaretskii <eliz@gnu.org>
6733
6734 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
6735 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
6736 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6737 macros related to unification of CJK characters. For the details,
6738 see the discussion following the message here:
6739 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
6740
3d439cd1
CY
67412012-04-04 Chong Yidong <cyd@gnu.org>
6742
6743 * keyboard.c (Vdelayed_warnings_list): Doc fix.
6744
8bc53d00
EZ
67452012-04-01 Eli Zaretskii <eliz@gnu.org>
6746
6747 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
6748 instead of alloca. (Bug#11138)
6749
3b0512a3
AS
67502012-04-01 Andreas Schwab <schwab@linux-m68k.org>
6751
6752 * w32menu.c (is_simple_dialog): Properly check lisp types.
6753 (Bug#11141)
6754
8427ddd2
EZ
67552012-03-31 Eli Zaretskii <eliz@gnu.org>
6756
979022ef
EZ
6757 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
6758 position we get to after a call to move_it_to fails the
6759 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
6760 only if we wind up in a string from display property. (Bug#11063)
6761
a6b1c7cc
EZ
6762 * window.c (Fdelete_other_windows_internal): Invalidate the row
6763 and column information about mouse highlight, so that redisplay
6764 restores it after reallocating the glyph matrices. (Bug#7464)
6765
8427ddd2
EZ
6766 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
6767 string comes from a `display' text property, use the buffer
6768 position of that property as if we actually saw that position in
6769 the row's glyphs.
697ba24b
EZ
6770 (move_it_by_lines): Remove the assertion that
6771 "it->current_x == 0 && it->hpos == 0" which can be legitimately
6772 violated when there's a before-string at the beginning of a line.
6773 (Bug#11063)
8427ddd2 6774
65a0a738
EZ
67752012-03-30 Eli Zaretskii <eliz@gnu.org>
6776
6777 * xdisp.c (append_space_for_newline): If the default face was
6778 remapped, use the remapped face for the appended newline.
6779 (extend_face_to_end_of_line): Use the remapped default face for
6780 extending the face to the end of the line.
6781 (display_line): Call extend_face_to_end_of_line when the default
6782 face was remapped. (Bug#11068)
6783
581355cc
EZ
67842012-03-29 Eli Zaretskii <eliz@gnu.org>
6785
6786 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
6787
e8fc049f
SM
67882012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6789
6790 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
6791
4fb9a543
GM
67922012-03-27 Glenn Morris <rgm@gnu.org>
6793
6794 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
6795 Doc fixes.
6796
679910f1
KH
67972012-03-26 Kenichi Handa <handa@m17n.org>
6798
6799 * dispextern.h (struct glyph): Fix previous change. Change the
6800 bit length of glyphless.ch to 25 (Bug#11082).
6801
90d49b7f
CY
68022012-03-26 Chong Yidong <cyd@gnu.org>
6803
6804 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6805 (command_loop_1): Use it; inhibit selection update for
6806 handle-select-window too (Bug#8996).
6807
f514f6f0
FP
68082012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6809
e8fc049f 6810 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6811
bf43fa51
KH
68122012-03-25 Kenichi Handa <handa@m17n.org>
6813
6814 * dispextern.h (struct glyph): Change the bit length of
6815 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6816
8a0c01dd
EZ
68172012-03-24 Eli Zaretskii <eliz@gnu.org>
6818
6819 * s/ms-w32.h (tzname): Include time.h before redirecting to
6820 _tzname. Fixes the MSVC build. (Bug#9960)
6821
7d1c3a76
AS
68222012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6823
8ed79523
AS
6824 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6825 characters.
6826
7d1c3a76
AS
6827 * xterm.c (XTread_socket): Only modify handling_signal if
6828 !SYNC_INPUT. (Bug#11080)
6829
e99a9b8b
EZ
68302012-03-23 Eli Zaretskii <eliz@gnu.org>
6831
6832 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6833 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6834 when fetching a multibyte character consumes more bytes than
6835 CHAR_BYTES returns, due to unification of CJK characters in
6836 string_char. (Bug#11073)
6837
5063c0e1
TN
68382012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6839
6840 * process.c (wait_reading_process_output): Handle pty disconnect
6841 by refraining from sending oneself a SIGCHLD (bug#10933).
6842
9f851fbd
CY
68432012-03-22 Chong Yidong <cyd@gnu.org>
6844
6845 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6846
5063c0e1 6847 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6848 Mark string as coming from a prefix property.
6849 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6850 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6851
fb5b8aca
CY
68522012-03-21 Chong Yidong <cyd@gnu.org>
6853
6854 * xfaces.c (Vface_remapping_alist): Doc fix.
6855
62356a1b
EZ
68562012-03-20 Eli Zaretskii <eliz@gnu.org>
6857
6858 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6859 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6860 Doc fixes.
62356a1b 6861
025de85b
CY
68622012-03-20 Chong Yidong <cyd@gnu.org>
6863
6864 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6865 to reflect default non-nil value of redisplay-dont-pause.
6866
4827f94e
KH
68672012-03-19 Kenichi Handa <handa@m17n.org>
6868
6869 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6870 it fit in a valid range (Bug#11003).
6871
e50a24a2
EZ
68722012-03-18 Eli Zaretskii <eliz@gnu.org>
6873
6874 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6875 that is not from display property, accept the row as a "cursor
6876 row" if one of the string's character has a non-nil `cursor'
6877 property. Fixes cursor positioning when there are newlines in
6878 overlay strings, e.g. in icomplete.el. (Bug#11035)
6879
9af5ed87
PE
68802012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6881
6882 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6883
d1f55f16
CY
68842012-03-12 Chong Yidong <cyd@gnu.org>
6885
6886 * eval.c (inhibit_lisp_code): Rename from
6887 inhibit_window_configuration_change_hook; move from window.c.
6888
6889 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6890 * window.c (run_window_configuration_change_hook)
6891 (syms_of_window): Callers changed.
6892
66c5eebd
CY
68932012-03-11 Chong Yidong <cyd@gnu.org>
6894
413df973
CY
6895 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6896
66c5eebd
CY
6897 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6898
1de11f56
CY
68992012-03-10 Chong Yidong <cyd@gnu.org>
6900
6901 * frame.c (other_visible_frames): Don't assume the selected frame
6902 is visible (Bug#10955).
6903
cae07000
SM
69042012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6905
6906 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6907
89c94350
JD
69082012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6909
6910 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6911 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6912 zero (Bug#10954).
6913
999dd333
GM
69142012-03-03 Glenn Morris <rgm@gnu.org>
6915
01a6dcc8 6916 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6917
de0100f2
EZ
69182012-03-02 Eli Zaretskii <eliz@gnu.org>
6919
6920 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6921 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6922 (redisplay_window, next_element_from_string): Fix typos in
6923 comments.
3e441275
EZ
6924 (redisplay_window): Pass to move_it_vertically the margin in
6925 pixels, not in screen lines.
de0100f2 6926
96a72ee9
GM
69272012-03-02 Glenn Morris <rgm@gnu.org>
6928
6929 * buffer.c (buffer-list-update-hook): Doc fix.
6930
312508d7
EZ
69312012-02-29 Eli Zaretskii <eliz@gnu.org>
6932
6933 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6934 push_it before setting up the iterator for the first overlay
6935 string, even if we have an empty string loaded.
6936 (next_overlay_string): If there's an empty string on the iterator
6937 stack, pop the stack. (Bug#10903)
6938
27f3c637
PE
69392012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6940
6941 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6942 Suggested by Stefan Monnier in
6943 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6944 * alloc.c (widen_to_Lisp_Object): New static function.
6945 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6946 and widening them to Lisp_Objects. This would work even if
6947 USE_LSB_TAG is defined and wide integers are used, which might
6948 happen in a future version of Emacs.
6949
3c9dfce6
CY
69502012-02-25 Chong Yidong <cyd@gnu.org>
6951
fa74b241
CY
6952 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6953 Doc fix.
6954
3c9dfce6
CY
6955 * xselect.c (Fx_selection_exists_p): Doc fix.
6956 (x_clipboard_manager_save_all): Print an informative message
6957 before saving to clipboard manager.
6958
9486df08
CY
69592012-02-24 Chong Yidong <cyd@gnu.org>
6960
6961 * keyboard.c (process_special_events): Handle all X selection
6962 requests in kbd_buffer, not just the next one (Bug#8869).
6963
f01d3321
CY
69642012-02-23 Chong Yidong <cyd@gnu.org>
6965
6966 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6967 call when setting menu-bar-lines and tool-bar-lines parameters.
6968 (unwind_create_frame_1): New helper function.
6969
6970 * window.c (inhibit_window_configuration_change_hook): New var.
6971 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6972 (syms_of_window): Initialize it.
f01d3321 6973
86b847b6
CY
69742012-02-22 Chong Yidong <cyd@gnu.org>
6975
6976 * xterm.c (x_draw_image_relief): Add missing type check for
6977 Vtool_bar_button_margin (Bug#10743).
6978
a59225b1
CY
69792012-02-21 Chong Yidong <cyd@gnu.org>
6980
6981 * fileio.c (Vfile_name_handler_alist): Doc fix.
6982
6983 * buffer.c (Fget_file_buffer): Protect against invalid file
6984 handler return value.
6985
310f5bd4
PE
69862012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6987
cb3a28cc
PE
6988 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6989 when computing $valmask.
6990
310f5bd4
PE
6991 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6992 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6993 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6994 It's useless in that case, and it can cause problems on hosts
6995 that allocate halves of EMACS_INT values separately.
6996 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6997 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6998 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6999 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
7000 it avoids undefined behavior on hosts where shifting right by more
7001 than the word width has undefined behavior.
7002
2375c96a
CY
70032012-02-19 Chong Yidong <cyd@gnu.org>
7004
7005 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
7006 (Funhandled_file_name_directory, Ffile_name_as_directory)
7007 (Fdirectory_file_name, Fexpand_file_name)
7008 (Fsubstitute_in_file_name): Protect against invalid file handler
7009 return values (Bug#10845).
7010
3eb49e71
EZ
70112012-02-18 Eli Zaretskii <eliz@gnu.org>
7012
7013 * .gdbinit (pitx): Fix incorrect references to fields of the
7014 iterator stack.
7015
7b926f3f
CY
70162012-02-17 Chong Yidong <cyd@gnu.org>
7017
7018 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
7019
11273115
PE
70202012-02-15 Paul Eggert <eggert@cs.ucla.edu>
7021
7022 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
7023 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
7024
c3a70e2b
CY
70252012-02-15 Chong Yidong <cyd@gnu.org>
7026
7027 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
7028 marked as special. Also, starting docstrings with * is obsolete.
7029
0ca43699
AS
70302012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7031
7032 * gnutls.c (emacs_gnutls_write): Fix last change.
7033
2e8f3c56
LI
70342012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
7035
7036 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
7037 send_process.
7038
af70074f
SM
70392012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
7040
7041 * keymap.c (Fsingle_key_description): Handle char ranges.
7042
95986d52
CY
70432012-02-12 Chong Yidong <cyd@gnu.org>
7044
afd83bd1
CY
7045 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
7046 as that creates a dangerous corner case.
7047
95986d52
CY
7048 * window.c (Fdelete_window_internal): Invalidate the mouse
7049 highlight (Bug#9904).
7050
bd7da63e
GM
70512012-02-12 Glenn Morris <rgm@gnu.org>
7052
7053 * xselect.c (Fx_own_selection_internal)
7054 (Fx_get_selection_internal, Fx_disown_selection_internal)
7055 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
7056 * nsselect.m (Fx_own_selection_internal)
7057 (Fx_disown_selection_internal, Fx_selection_exists_p)
7058 (Fx_selection_owner_p, Fx_get_selection_internal):
7059 Sync docs and argument specs with the xselect.c versions.
7060
77abcbc2
LI
70612012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
7062
7063 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
7064
90b671e2
EZ
70652012-02-11 Eli Zaretskii <eliz@gnu.org>
7066
1c0ca0b7
EZ
7067 * w32select.c (Fx_selection_exists_p): Sync doc string and
7068 argument list with xselect.c. (Bug#10783)
7069
7070 * w16select.c (Fx_selection_exists_p): Sync doc string and
7071 argument list with xselect.c. (Bug#10783)
90b671e2 7072
49241268
GM
70732012-02-10 Glenn Morris <rgm@gnu.org>
7074
7075 * fns.c (Fsecure_hash): Doc fix.
7076
f998bbe7 70772012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
7078
7079 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
7080
0992bd9c
CY
70812012-02-07 Chong Yidong <cyd@gnu.org>
7082
7083 * buffer.c (Fbuffer_local_variables)
7084 (buffer_lisp_local_variables): Handle unbound vars correctly;
7085 don't let Qunbound leak into Lisp.
7086
af008560
GM
70872012-02-07 Glenn Morris <rgm@gnu.org>
7088
dd605cc4
GM
7089 * image.c (Fimagemagick_types): Doc fix.
7090
af008560
GM
7091 * image.c (imagemagick-render-type): Change it from a lisp object
7092 to an integer. Move the doc here from the lisp manual.
7093 Treat all values not equal to 0 the same.
7094
1449fa1d
CY
70952012-02-06 Chong Yidong <cyd@gnu.org>
7096
7097 * doc.c (store_function_docstring): Avoid applying docstring of
7098 alias to base function (Bug#2603).
7099
3723ec07
AS
71002012-02-04 Andreas Schwab <schwab@linux-m68k.org>
7101
7102 * .gdbinit (pp1, pv1): Remove redundant defines.
7103 (pr): Use pp.
7104
79c1cc1e
CY
71052012-02-04 Chong Yidong <cyd@gnu.org>
7106
7107 * nsterm.m: Declare a global (Bug#10694).
7108
d7f29f8e
EZ
71092012-02-04 Eli Zaretskii <eliz@gnu.org>
7110
cae07000
SM
7111 * w32.c (get_emacs_configuration_options):
7112 Include --enable-checking, if specified, in the return value.
d7f29f8e 7113
3b95a6f9
MR
71142012-02-04 Martin Rudalics <rudalics@gmx.at>
7115
7116 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
7117 after rounding frame sizes. (Bug#9723)
7118
d6fa96a6
EZ
71192012-02-04 Eli Zaretskii <eliz@gnu.org>
7120
7121 * keyboard.c (adjust_point_for_property): Don't position point
7122 before BEGV. (Bug#10696)
7123
df0b2940
PE
71242012-02-03 Paul Eggert <eggert@cs.ucla.edu>
7125
7126 Handle overflow when computing char display width (Bug#9496).
7127 * character.c (char_width): Return EMACS_INT, not int.
7128 (char_width, c_string_width): Check for overflow when
7129 computing the width; this is possible now that individual
7130 characters can have unbounded width. Problem introduced
7131 by merge from Emacs 23 on 2012-01-19.
7132
6bee44d6
MA
71332012-02-02 Michael Albinus <michael.albinus@gmx.de>
7134
7135 * dbusbind.c (Fdbus_register_method): Mention the return value
7136 :ignore in the docstring.
7137
44f92739
GM
71382012-02-02 Glenn Morris <rgm@gnu.org>
7139
1b9f60cc
GM
7140 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
7141
44f92739
GM
7142 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7143 Unconditionally set to t. (Bug#10673)
7144 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
7145 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
7146 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
7147
c5d3843c
KH
71482012-02-02 Kenichi Handa <handa@m17n.org>
7149
7150 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
7151 0, do not call append_composite_glyph.
7152
159462d4 71532012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
7154
7155 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
7156 NULL (Bug#6988).
7157 (x_produce_glyphs): If the component of a composition is a null
7158 string, set it->pixel_width to 1 to avoid zero-width glyph.
7159
78cef877
EZ
71602012-02-01 Eli Zaretskii <eliz@gnu.org>
7161
7162 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
7163 first 2 arguments are identical. This makes inserting large
7164 output from a subprocess an order of magnitude faster on
7165 MS-Windows, where all sbrk'ed memory is always contiguous.
7166
97897668
GM
71672012-01-31 Glenn Morris <rgm@gnu.org>
7168
7169 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 7170 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
7171 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
7172
31fd3586
GM
71732012-01-29 Glenn Morris <rgm@gnu.org>
7174
7175 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
7176
0e24a8b2
CY
71772012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
7178
7179 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
7180
cc0adcb0
CY
71812012-01-28 Chong Yidong <cyd@gnu.org>
7182
7183 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
7184
acc28cb9
CY
71852012-01-26 Chong Yidong <cyd@gnu.org>
7186
9c69cfb7
CY
7187 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
7188
acc28cb9
CY
7189 * search.c (Fsearch_forward, Fsearch_backward): Document negative
7190 repeat counts (Bug#10507).
7191
48da7392
GM
71922012-01-26 Glenn Morris <rgm@gnu.org>
7193
7194 * lread.c (syms_of_lread): Doc fix.
7195
14af5f7f
CY
71962012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
7197
7198 * coding.c (encode_designation_at_bol): Change return value to
7199 EMACS_INT.
7200
0b21c100
CY
72012012-01-25 Chong Yidong <cyd@gnu.org>
7202
7203 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
7204
3c2907f7
CY
72052012-01-21 Chong Yidong <cyd@gnu.org>
7206
7207 * floatfns.c (Fcopysign): Make the second argument non-optional,
7208 since nil is not allowed anyway.
7209
959ad23f
AS
72102012-01-21 Andreas Schwab <schwab@linux-m68k.org>
7211
7212 * process.c (read_process_output): Use p instead of XPROCESS (proc).
7213 (send_process): Likewise.
7214
34a02f46
MR
72152012-01-19 Martin Rudalics <rudalics@gmx.at>
7216
7217 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
7218 (Vwindow_persistent_parameters): Do not use Qstate.
7219 Rewrite doc-strings.
34a02f46 7220
1259009a 72212012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
7222
7223 * character.c (char_width): New function.
70d4fdf6
GM
7224 (Fchar_width, c_string_width, lisp_string_width):
7225 Use char_width (Bug#9496).
25ed9e61 7226
6a6ee00d
MR
72272012-01-16 Martin Rudalics <rudalics@gmx.at>
7228
7229 * window.c (Vwindow_persistent_parameters): New variable.
7230 (Fset_window_configuration, save_window_save): Handle persistent
7231 window parameters.
7232
c85efaf7
EZ
72332012-01-14 Eli Zaretskii <eliz@gnu.org>
7234
7235 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
7236 thrashing the stack of the thread. (Bug#9087)
7237
5944709e
PE
72382012-01-12 Paul Eggert <eggert@cs.ucla.edu>
7239
7240 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
7241
e71f5d99
EZ
72422012-01-11 Eli Zaretskii <eliz@gnu.org>
7243
7244 * xdisp.c (rows_from_pos_range): Handle the case where the
7245 highlight ends on a newline. (Bug#10464)
7246 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
7247 he end column for display of highlight that ends on a newline
7248 before a R2L line.
7249
ce316182
GM
72502012-01-11 Glenn Morris <rgm@gnu.org>
7251
7252 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
7253 from load-path also when installation-directory is nil. (Bug#10208)
7254
5b43da69
GM
72552012-01-10 Glenn Morris <rgm@gnu.org>
7256
74cc8ff9
GM
7257 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
7258
7d8d6e4e
GM
7259 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
7260 Update template values to be closer to their typical values these days.
5b43da69 7261
a0db8d43
EZ
72622012-01-09 Eli Zaretskii <eliz@gnu.org>
7263
7264 * xdisp.c (rows_from_pos_range): Accept additional argument
7265 DISP_STRING, and accept any glyph in a row whose object is that
7266 string as eligible for mouse highlight. Fixes mouse highlight of
7267 display strings from overlays. (Bug#10464)
7268
9a0115ab 72692012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 7270
b9110d6a 7271 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
7272 * fileio.c (auto_saving_dir_umask): New static var.
7273 (Fmake_directory_internal): Use it.
7274 (do_auto_save_make_dir): Set it, instead of invoking chmod after
7275 creating the directory. The old code temporarily assigns
7276 too-generous permissions to the directory.
7277 (do_auto_save_eh): Clear it.
b9110d6a 7278 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
7279 that the var is always cleared.
7280
6c1bd3f3
EZ
72812012-01-07 Eli Zaretskii <eliz@gnu.org>
7282
7283 * search.c (scan_buffer): Pass character positions to
7284 know_region_cache, not byte positions. (Bug#6540)
7285
069d2b50
L
72862012-01-07 LynX <_LynX@bk.ru> (tiny change)
7287
7288 * w32.c (sys_rename): Report EXDEV when rename of a directory
7289 fails because the target is on another logical disk. (Bug#10284)
7290
75bf0d33
DB
72912012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
7292
7293 * xterm.c (x_embed_request_focus): New function.
7294
7295 * xterm.h: Add prototype.
7296
7297 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
7298
1c6e5a32
GM
72992012-01-05 Glenn Morris <rgm@gnu.org>
7300
7301 * emacs.c (emacs_copyright): Update short copyright year to 2012.
7302
651e947e
EZ
73032012-01-01 Eli Zaretskii <eliz@gnu.org>
7304
7305 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
7306 Load gnutls_transport_set_lowat only if GnuTLS version is below
7307 2.11.1.
7308 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
7309 GnuTLS versions below 2.11.1.
7310
3778cdd8
AL
73112011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
7312
7313 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
7314 to the doc string advising against its use for altering the way
7315 windows are scrolled.
7316
0e5317f7
KH
73172011-12-28 Kenichi Handa <handa@m17n.org>
7318
7319 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
7320 coding-system ASCII compatible only when it does not produce BOM
7321 on encoding (Bug#10383).
7322
93d5ca1f
JD
73232011-12-26 Jan Djärv <jan.h.d@swipnet.se>
7324
7325 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
7326 can scroll.
7327 (create_and_show_popup_menu): Always use menu_position_func for
7328 Gtk3 (Bug#10361).
7329
ca22b785
AS
73302011-12-24 Andreas Schwab <schwab@linux-m68k.org>
7331
7332 * callint.c (Fcall_interactively): Don't truncate prompt string.
7333
d048e1e6
EZ
73342011-12-23 Eli Zaretskii <eliz@gnu.org>
7335
7336 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
7337 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 7338 resumed from there (after widening). (Bug#10360)
d048e1e6 7339
5ccaba1f
JD
73402011-12-22 Jan Djärv <jan.h.d@swipnet.se>
7341
7342 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
7343
204ee57f
JD
73442011-12-21 Jan Djärv <jan.h.d@swipnet.se>
7345
b81d40f0
JB
7346 * nsterm.m (x_free_frame_resources):
7347 Release f->output_data.ns->miniimage.
204ee57f
JD
7348 (ns_index_color): Fix indentation. Do not retain
7349 color_table->colors[i].
7350
7351 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
7352 before returning.
7353
7354 * nsfns.m (x_set_background_color): Assign return value from
7355 ns_index_color to face-background instead of NSColor*.
7356 (ns_implicitly_set_icon_type): Fix indentation.
7357 Change assignment in for loop to comparison.
7358
7359 * emacs.c (ns_pool): New variable.
7360 (main): Assign ns_pool.
7361 (Fkill_emacs): Call ns_release_autorelease_pool.
7362
7363 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
7364 autorelease fdesc, release fdAttrs and tdict.
7365 (ns_get_covering_families): Release charset.
7366 (ns_findfonts): Release NSFontDescriptor created with new.
7367 (ns_uni_to_glyphs): Fix indentation.
7368 (setString): Release attrStr before assigning new value.
7369
c803b2b7
JD
73702011-12-18 Jan Djärv <jan.h.d@swipnet.se>
7371
678f4426
JD
7372 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
7373 and NS_IMPL_COCOA.
7374 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
7375 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
7376
cd394be1 73772011-12-18 David Reitter <reitter@cmu.edu>
678f4426 7378
5fecd5fc
JD
7379 * nsterm.m (ns_term_init): Subscribe for notifications
7380 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
7381 to method trackingNotification in EmacsMenu.
7382
7383 * nsmenu.m (trackingMenu): New variable.
3771cb17 7384 (trackingNotification): New method (from Aquamacs).
5fecd5fc 7385 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 7386 from Aquamacs (Bug#7030).
678f4426
JD
7387
73882011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 7389
c803b2b7
JD
7390 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
7391 (symbol_to_nsstring): Fix indentation.
7392 (ns_symbol_to_pb): New function.
cae07000
SM
7393 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
7394 (Fns_rotate_cut_buffers_internal): Remove.
7395 (Fns_store_selection_internal): Rename from
c803b2b7
JD
7396 Fns_store_cut_buffer_internal.
7397 (ns_get_foreign_selection, Fx_own_selection_internal)
7398 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
7399 (Fns_get_selection_internal, Fns_store_selection_internal):
7400 Use ns_symbol_to_pb and check if return value is nil.
7401 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
7402 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
7403 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
7404 renamed to Sns_store_selection_internal.
7405 (ns_handle_selection_request): Move code to Fx_own_selection_internal
7406 and remove this function.
7407 (ns_handle_selection_clear): Remove, never used.
7408 (Fx_own_selection_internal): Move code from ns_handle_selection_request
7409 here.
7410
e1b01a3a
KB
74112011-12-17 Ken Brown <kbrown@cornell.edu>
7412
7413 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
7414 GID is unknown (Bug#10257).
7415
2adb6e85
PE
74162011-12-17 Paul Eggert <eggert@cs.ucla.edu>
7417
7418 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
7419 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
7420 which caused a build failure on GNU/Linux IA-64. This problem was
7421 introduced by my 2011-10-07 patch.
7422
d1d7b339
JL
74232011-12-15 Juri Linkov <juri@jurta.org>
7424
7425 * image.c (imagemagick_error): New function. (Bug#10112)
7426 (imagemagick_load_image): Comment out `MagickSetResolution' call.
7427 Use `imagemagick_error' where ImageMagick functions return
7428 `MagickFalse'.
7429 (Fimagemagick_types): Add `Fnreverse' to return the list in the
7430 proper order.
7431
100d5755
KH
74322011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7433
7434 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
7435 fill background (Bug#8992).
7436
454592a6
MR
74372011-12-13 Martin Rudalics <rudalics@gmx.at>
7438
7439 * window.c (Vwindow_combination_resize)
7440 (Vwindow_combination_limit): Use t instead of non-nil in
7441 doc-strings.
61d4b438
MR
7442 (Vrecenter_redisplay): Add first sentence of doc-string on
7443 separate line.
53524d93 7444 (Frecenter): Fix doc-string typo.
454592a6 7445
3633e3aa
KH
74462011-12-11 Kenichi Handa <handa@m17n.org>
7447
7448 * coding.c (Funencodable_char_position): Pay attention to the
7449 buffer text relocation (Bug#9389).
7450
7b9d523a 74512011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 7452
7b9d523a
JD
7453 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
7454 gtk_init (Bug#10100).
7455
b73189c6
EZ
74562011-12-10 Eli Zaretskii <eliz@gnu.org>
7457
7458 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
7459 IT->string is nil. (Bug#10263)
7460
f7dfe5d6
JD
74612011-12-10 Jan Djärv <jan.h.d@swipnet.se>
7462
83faebb4
JD
7463 * nsterm.h (x_free_frame_resources): Declare.
7464
f7dfe5d6
JD
7465 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
7466 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
7467
7468 * nsterm.h (ns_get_defaults_value): Declare.
7469
7470 * nsterm.m (ns_default): Call ns_get_defaults_value.
7471
7cd4e72c
EZ
74722011-12-09 Eli Zaretskii <eliz@gnu.org>
7473
7474 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
7475 (Bug#10170)
7476
b34d7317
YM
74772011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7478
7479 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
7480 that where the value of an _OBJC_* symbol points to is in the .bss
7481 section (Bug#10240).
7482
76470ad1
KH
74832011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7484
7485 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 7486 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 7487
745fff94
KH
74882011-12-08 Kenichi Handa <handa@m17n.org>
7489
7490 * ftfont.c (get_adstyle_property): Fix previous change
7491 (Bug#10233).
7492
6e44397c
JB
74932011-12-07 Juanma Barranquero <lekktu@gmail.com>
7494
7495 * w32.c (init_environment): If no_site_lisp, remove site-lisp
7496 dirs from the default value of EMACSLOADPATH (bug#10208).
7497
7efa6272
GM
74982011-12-07 Glenn Morris <rgm@gnu.org>
7499
7500 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
7501 installation and source directories as well. (Bug#10208)
7502
f6fc4d87
CY
75032011-12-06 Chong Yidong <cyd@gnu.org>
7504
7505 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
7506
2bf26180
GM
75072011-12-06 Glenn Morris <rgm@gnu.org>
7508
7509 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
7510 as an error, not just -1. (Bug#10217)
7511
3a6ad4f0
CY
75122011-12-05 Chong Yidong <cyd@gnu.org>
7513
7514 * keyboard.c (process_special_events): New function.
7515 (swallow_events, Finput_pending_p): Use it (Bug#10195).
7516
75a3b399
PE
75172011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7518
7519 * coding.c (encode_designation_at_bol): Don't use uninitialized
7520 local variable (Bug#9318).
7521
c3c9e25e
KH
75222011-12-05 Kenichi Handa <handa@m17n.org>
7523
7524 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
7525 return Qnil (Bug#8046, Bug#10193).
7526
5eb05ea3
KH
75272011-12-05 Kenichi Handa <handa@m17n.org>
7528
7529 * coding.c (encode_designation_at_bol): New args charbuf_end and
7530 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
7531 (coding_set_source): Return how many bytes coding->source was
7532 relocated.
7533 (coding_set_destination): Return how many bytes
7534 coding->destination was relocated.
7535 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 7536 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
7537
75382011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
7539
7540 * coding.c (CODING_CHAR_CHARSET_P): New macro.
7541 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
7542 macro (Bug#9318).
7543
75442011-12-05 Andreas Schwab <schwab@linux-m68k.org>
7545
7546 The following changes are to fix Bug#9318.
7547
a79703f5 7548 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
7549 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
7550 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 7551 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 7552
7dbda6df
JB
75532011-12-05 Juanma Barranquero <lekktu@gmail.com>
7554
7555 * lisp.h (process_quit_flag): Fix external declaration.
7556
6d5eb5b0
SM
75572011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
7558
7559 Don't macro-inline non-performance-critical code.
7560 * eval.c (process_quit_flag): New function.
7561 * lisp.h (QUIT): Use it.
7562
a0c3fad0
JD
75632011-12-04 Jan Djärv <jan.h.d@swipnet.se>
7564
7565 * nsfns.m (get_geometry_from_preferences): New function.
7566 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
7567
6c07aac2
AS
75682011-12-04 Andreas Schwab <schwab@linux-m68k.org>
7569
7570 * emacs.c (Qkill_emacs): Define.
7571 (syms_of_emacs): Initialize it.
7572 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
7573 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
7574 (quit_throw_to_read_char): Add parameter `from_signal'.
7575 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
7576 * lisp.h (QUIT): Call Fkill_emacs if requested.
7577
c052ead4
JD
75782011-12-03 Jan Djärv <jan.h.d@swipnet.se>
7579
7580 * widget.c (update_wm_hints): Return if wmshell is null.
7581 (widget_update_wm_size_hints): New function.
7582
7583 * widget.h (widget_update_wm_size_hints): Declare.
7584
7585 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
7586 widget_update_wm_size_hints (Bug#10104).
7587
9e49252b
EZ
75882011-12-03 Eli Zaretskii <eliz@gnu.org>
7589
7590 * xdisp.c (handle_invisible_prop): If the invisible text ends just
7591 before a newline, prepare the bidi iterator for consuming the
7592 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 7593 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7594
02b16839
JL
75952011-12-02 Juri Linkov <juri@jurta.org>
7596
7597 * search.c (Fword_search_regexp): New Lisp function created from
7598 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
7599 (Fword_search_backward, Fword_search_forward)
7600 (Fword_search_backward_lax, Fword_search_forward_lax):
7601 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
7602 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
7603
0068070e
SM
76042011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
7605
7606 * fileio.c (Finsert_file_contents): Move after-change-function call
7607 to before the "handled:" label, since all "goto handled" appear in
7608 cases where the *-change-functions have already been properly called
7609 (bug#10117).
7610
3360a3fc
AS
76112011-12-01 Andreas Schwab <schwab@linux-m68k.org>
7612
7613 * keyboard.c (interrupt_signal): Don't call kill-emacs when
7614 waiting for input. (Bug#10169)
7615
73d6c093
EZ
76162011-11-30 Eli Zaretskii <eliz@gnu.org>
7617
7618 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
7619 verifies glyph row's hash code--we have just reallocated the
7620 glyphs, so their contents can be complete garbage. (Bug#10164)
7621
febe6bea
JB
76222011-11-30 Juanma Barranquero <lekktu@gmail.com>
7623
7624 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
7625
801a4313
EZ
76262011-11-30 Eli Zaretskii <eliz@gnu.org>
7627
7628 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
7629 attributes are tested _before_ calling verify_row_hash, to protect
7630 against GCC re-ordering of the tests. (Bug#10164)
7631
2b56b87e
JD
76322011-11-29 Jan Djärv <jan.h.d@swipnet.se>
7633
7634 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
7635
7636 * xterm.c (handle_one_xevent): Only set async_visible and friends
7637 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 7638 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
7639 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
7640
dbf31225
PE
76412011-11-28 Paul Eggert <eggert@cs.ucla.edu>
7642
7643 Remove GCPRO-related macros that exist only to avoid shadowing locals.
7644 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
7645 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
7646 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7647 All uses changed to use GCPRO1 etc.
7648 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
7649 Revert to old implementation (i.e., before 2011-03-11).
7650
1305621b
YM
76512011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7652
7653 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
7654 of scroll runs so as to avoid assigning disabled bogus rows and
7655 unnecessary graphics copy operations.
7656
8c9afb46
EZ
76572011-11-27 Eli Zaretskii <eliz@gnu.org>
7658
7659 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
7660 (snprintf) [_MSC_VER]: Redirect to _snprintf.
7661 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
7662 (malloc, free, realloc, calloc): Redirect to e_* only when
7663 compiling Emacs.
7664
7665 * lisp.h (GCTYPEBITS): Move before first use.
7666 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
7667 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
7668 this macro definition.
7669
7670 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
7671 _MSC_VER.
7672
54e9e3bf
JD
76732011-11-27 Jan Djärv <jan.h.d@swipnet.se>
7674
6d5eb5b0
SM
7675 * gtkutil.c (xg_create_frame_widgets):
7676 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
7677 present with Gtk+ 2.0.
7678
83aca1cb
PE
76792011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7680
7681 * fileio.c (Finsert_file_contents): Undo previous change; see
7682 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7683
5b76caa4
PE
76842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
7685
7686 Rename locals to avoid shadowing.
7687 * fileio.c (Finsert_file_contents):
7688 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
7689 * process.c (wait_reading_process_output):
7690 Rename inner 'proc' to 'p' to avoid shadowing.
7691 Indent for consistency with usual Emacs style.
7692
8c535114
EZ
76932011-11-25 Eli Zaretskii <eliz@gnu.org>
7694
7695 * xdisp.c (redisplay_window): If cursor row is not fully visible
7696 after recentering, and scroll-conservatively is set to a large
7697 number, scroll window by a few more lines to make the cursor fully
7698 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
7699 (start_display): Don't move to the next line if the display should
7700 start at a newline that is part of a display vector or an overlay
7701 string. (Bug#10119)
8c535114 7702
fa4fdb5c
JL
77032011-11-24 Juri Linkov <juri@jurta.org>
7704
7705 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
7706 after the `MagickPingImage' call. (Bug#10112)
7707
90ec88df
CY
77082011-11-23 Chong Yidong <cyd@gnu.org>
7709
7710 * window.c (Fcoordinates_in_window_p): Accept only live windows.
7711
56e2e794
MR
77122011-11-23 Martin Rudalics <rudalics@gmx.at>
7713
7714 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
7715 making another buffer current. (Bug#10114)
7716
b6e64c41
GM
77172011-11-23 Glenn Morris <rgm@gnu.org>
7718
7719 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
7720
6b21de18
CY
77212011-11-23 Chong Yidong <cyd@gnu.org>
7722
7723 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
7724 using it (Bug#5984).
7725
b12cd789
EZ
77262011-11-22 Eli Zaretskii <eliz@gnu.org>
7727
7728 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
7729 and header-lines, as they don't have one computed for them.
7730 (Bug#10098)
7731
7732 * .gdbinit (prow): Make displayed values more self-explaining.
7733 Add row's hash code.
7734
261b6fd4
LMI
77352011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
7736
7737 * process.c (wait_reading_process_output): Fix asynchrounous
7738 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 7739 (wait_reading_process_output): Add comment and URL.
261b6fd4 7740
e7cfd277
JD
77412011-11-21 Jan Djärv <jan.h.d@swipnet.se>
7742
7743 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
7744
a9b9b7f5
CY
77452011-11-21 Chong Yidong <cyd@gnu.org>
7746
7747 * window.c (Fnext_window, Fprevious_window): Doc fix.
7748
b0d15b4f
SM
77492011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7750
7751 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
7752
fe7a3057
JB
77532011-11-20 Juanma Barranquero <lekktu@gmail.com>
7754
7755 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
7756
d2999b1a
MR
77572011-11-20 Martin Rudalics <rudalics@gmx.at>
7758
7759 * window.c (Fset_window_combination_limit): Rename argument
7760 STATUS to LIMIT.
7761 (Vwindow_combination_limit): Remove "status" from doc-string.
7762
d5ff9cd0
AS
77632011-11-20 Andreas Schwab <schwab@linux-m68k.org>
7764
7765 * m/ibms390.h: Remove.
7766 * m/ibms390x.h: Don't include "ibms390.h".
7767
a5bb9bd3
SM
77682011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7769
7770 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
7771 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
7772
cd1181db
JB
77732011-11-20 Juanma Barranquero <lekktu@gmail.com>
7774
7775 * casetab.c (Fset_case_table):
7776 * charset.c (Fcharset_after): Fix typos.
7777
615a3b8d 77782011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 7779
17e845af
PE
7780 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
7781 Otherwise, valgrind does not work on some platforms.
7782 Problem reported by Andreas Schwab in
6a0bf43d
PE
7783 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
7784 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
7785 is set, removing the need for VIRT_ADDRESS_VARIES.
7786 (PURE_P): Use a more-efficient implementation that needs just one
7787 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
7788 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
7789 to 4 (xorl, subq, cmpq, setbe).
7790 * alloc.c (pure): Always extern now, since that's the
7791 VIRT_ADDR_VARIES behavior.
7792 (PURE_POINTER_P): Use a single comparison, not two, for
7793 consistency with the new puresize.h.
7794 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
7795 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
7796 Remove VIRT_ADDR_VARIES no longer needed.
7797
f8fe6f96
EZ
77982011-11-19 Eli Zaretskii <eliz@gnu.org>
7799
7800 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7801 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7802 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7803 behave as if the cursor position were at the window margin.
7804
7805 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7806 and the cursor position is out of bounds, behave as if the cursor
7807 position were at the window margin. (Bug#10075)
7808
df05a53c
CY
78092011-11-18 Chong Yidong <cyd@gnu.org>
7810
7811 * window.c (Fwindow_combination_limit): Make first argument
7812 non-optional, since it is meaningless for live windows like the
7813 selected window.
61ccba97 7814
2071918e
DA
78152011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7816
7817 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7818
b50a28de
SM
78192011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7820
7821 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7822 (graft_intervals_into_buffer): Simplify.
7823
015137db
EZ
78242011-11-18 Eli Zaretskii <eliz@gnu.org>
7825
7826 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7827 hash values of the two rows.
7828 (copy_row_except_pointers): Preserve the used[] arrays and the
7829 hash values of the two rows. (Bug#10035)
68c95424 7830 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7831
7832 * xdisp.c (row_hash): New function, body extracted from
7833 compute_line_metrics.
7834 (compute_line_metrics): Call row_hash, instead of computing the
7835 hash code inline.
7836
7837 * dispnew.c (verify_row_hash): Call row_hash for computing the
7838 hash code of a row, instead of duplicating code from xdisp.c.
7839
7840 * dispextern.h (row_hash): Add prototype.
7841
a2addb04
TH
78422011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7843
7844 * frame.c (delete_frame): Don't delete the terminal when the last
7845 X frame is closed if emacs is built with GTK toolkit.
7846
df85d315
JB
78472011-11-17 Juanma Barranquero <lekktu@gmail.com>
7848
7849 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7850
a0c2d0ae
MR
78512011-11-17 Martin Rudalics <rudalics@gmx.at>
7852
7853 * window.c (Vwindow_splits): Rename to
7854 Vwindow_combination_resize. Suggested by Juri Linkov.
7855 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7856 of Vwindow_splits.
7857
58179cce
JB
78582011-11-16 Juanma Barranquero <lekktu@gmail.com>
7859
7877f373
JB
7860 * nsfns.m (Fns_font_name):
7861 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7862
b6f67890
MR
78632011-11-16 Martin Rudalics <rudalics@gmx.at>
7864
7865 * window.h (window): Rename slot "nest" to "combination_limit".
7866 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7867 (Fset_window_nest): Rename to Fset_window_combination_limit.
7868 (Vwindow_nest): Rename to Vwindow_combination_limit.
7869 (recombine_windows, make_parent_window, make_window)
7870 (Fsplit_window_internal, saved_window)
7871 (Fset_window_configuration, save_window_save): Rename all
7872 occurrences of window_nest to window_combination_limit.
7873
c7015153
JB
78742011-11-15 Juanma Barranquero <lekktu@gmail.com>
7875
7876 * image.c (imagemagick_load_image): Fix typo.
7877
322ad6ec
EZ
78782011-11-14 Eli Zaretskii <eliz@gnu.org>
7879
7880 * xdisp.c (display_line): Move the call to
7881 highlight_trailing_whitespace before the call to
7882 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7883 faces of all the glyphs to compute ROW's hash value.
7884 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7885
f067b8ec
JB
78862011-11-14 Juanma Barranquero <lekktu@gmail.com>
7887
7888 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7889 just return (bug#10044).
7890
1e5b2111
EZ
78912011-11-12 Eli Zaretskii <eliz@gnu.org>
7892
7ef3cbd5
EZ
7893 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7894 with user-defined heap size. Bump the default size of the temacs
7895 heap to 27MB, to avoid memory warning when running temacs.
7896 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7897
1e5b2111
EZ
7898 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7899 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7900 (verify_row_hash) [XASSERTS]: New function.
7901 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7902 that the hash value of glyph rows is correct.
1e5b2111 7903
89d61221
MR
79042011-11-12 Martin Rudalics <rudalics@gmx.at>
7905
7906 * window.h (window): Remove splits slot.
7907 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7908 (Fdelete_other_windows_internal, make_parent_window)
7909 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7910 (Fset_window_configuration, save_window_save): Don't deal with
7911 split status of windows.
7912 (saved_window): Remove splits slot.
7913 (Vwindow_splits): Rewrite doc-string.
7914
97f18cc8
JD
79152011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7916
7917 * xfns.c (unwind_create_frame):
7918 * nsfns.m (unwind_create_frame):
7919 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7920 Vframe_list (Bug#9999).
7921
22a648b4
DA
79222011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7923
0b381c7e 7924 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7925
659afede
KH
79262011-11-11 Kenichi Handa <handa@m17n.org>
7927
7928 * callproc.c (Fcall_process): Set the member dst_multibyte of
7929 process_coding.
7930
9ac0394b
KH
79312011-11-11 Johan Bockgård <bojohan@gnu.org>
7932
7933 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7934 avoid a crash (bug#9496).
7935
2fbdc249
CY
79362011-11-09 Chong Yidong <cyd@gnu.org>
7937
7938 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7939 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7940
ac6b1f81
PE
79412011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7942
7943 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7944
09db192c
PE
79452011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7946
7947 Avoid some portability problems by eschewing 'extern inline' functions.
7948 The trivial performance wins aren't worth the portability hassles; see
7949 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7950 et seq.
7951 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7952 (window_box_width, window_box_left, window_box_left_offset)
7953 (window_box_right, window_box_right_offset): Undo previous change,
7954 by removing the "extern"s.
7955 * intervals.c (adjust_intervals_for_insertion)
7956 (adjust_intervals_for_deletion): Undo previous change,
7957 making these static again.
7958 (offset_intervals, temp_set_point_both, temp_set_point)
7959 (copy_intervals_to_string): No longer inline.
7960 * xdisp.c (window_text_bottom_y, window_box_width)
7961 (window_box_height, window_box_left_offset)
7962 (window_box_right_offset, window_box_left, window_box_right)
7963 (window_box): No longer inline.
7964
105216ed
CY
79652011-11-08 Chong Yidong <cyd@gnu.org>
7966
7967 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7968 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7969 Signal an error if not a live window.
105216ed
CY
7970 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7971 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7972
ae9e237f
JB
79732011-11-07 Juanma Barranquero <lekktu@gmail.com>
7974
7975 * lisp.h (syms_of_abbrev): Remove declaration.
7976 Reported by CHENG Gao <chenggao@royau.me>.
7977
c7aa8333
EZ
79782011-11-07 Eli Zaretskii <eliz@gnu.org>
7979
7980 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7981 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7982 of temacs in GUI mode.
7983
be7f5545
MR
79842011-11-07 Martin Rudalics <rudalics@gmx.at>
7985
7986 * window.h: Declare delete_all_child_windows instead of
7987 delete_all_subwindows.
7988 * window.c (Fwindow_nest, Fset_window_nest)
7989 (Fset_window_new_total, Fset_window_new_normal)
7990 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7991 (delete_all_subwindows): Rename to delete_all_child_windows.
7992 (Fdelete_other_windows_internal, Fset_window_configuration):
7993 Call delete_all_child_windows instead of delete_all_subwindows.
7994 * frame.c (delete_frame): Call delete_all_child_windows instead
7995 of delete_all_subwindows.
7996
ca78dc43
PE
79972011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7998
7999 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
8000 This is also needed for porting to any host where GC_MARK_STACK is
8001 not GC_MAKE_GCPROS_NOOPS.
8002 (which_symbols): Use it.
8003
a0241d01
KH
80042011-11-07 Kenichi Handa <handa@m17n.org>
8005
8006 * coding.c (coding_set_destination): Check coding->src_pos only
8007 when coding->src_object is a buffer (bug#9910).
8008
8009 * process.c (send_process): Set the member src_multibyte of coding
8010 to 0 (bug#9911) when sending a unibyte text.
8011
8012 * callproc.c (Fcall_process): Set the member src_multibyte of
8013 process_coding to 0 (bug#9912).
8014
a64bfdfa 80152011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
8016
8017 * xmenu.c (cleanup_widget_value_tree): New function.
8018 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
8019 calling free_menubar_widget_value_tree directly (Bug#9830).
8020
cb41b32a
PE
80212011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8022
8023 Fix some portability problems with 'inline'.
8024 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
8025 (window_box_width, window_box_left, window_box_left_offset)
8026 (window_box_right, window_box_right_offset): Declare extern.
8027 Otherwise, these inline functions do not conform to C99 and
8028 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
8029 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
8030 * intervals.c (adjust_intervals_for_insertion)
8031 (adjust_intervals_for_deletion): Now extern, because otherwise the
8032 extern inline functions 'offset_intervals' couldn't refer to it.
8033 (static_offset_intervals): Remove.
8034 (offset_intervals): Rewrite using the old contents of
8035 static_offset_intervals. The old version didn't conform to C99
8036 because an extern inline function contained a reference to an
8037 identifier with static linkage.
8038
b7041366
AS
80392011-11-06 Andreas Schwab <schwab@linux-m68k.org>
8040
8041 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
8042 GC.
8043
88a37c4d
EZ
80442011-11-06 Eli Zaretskii <eliz@gnu.org>
8045
8046 * xdisp.c (init_iterator, reseat_to_string): Don't set the
8047 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
8048 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
8049 return Qleft_to_right.
8050
49745b39
CY
80512011-11-06 Chong Yidong <cyd@gnu.org>
8052
8053 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
8054 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
8055 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
8056 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
8057 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
8058 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
8059 (Fwindow_vscroll): Doc fix.
8060 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
8061 argument, since it makes no sense to pass a live window and for
8062 consistency with window-child.
8063
1f05cd82
CS
80642011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
8065
8066 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
8067 support MSVC.
8068
22610910
JR
80692011-11-05 Jason Rumney <jasonr@gnu.org>
8070
8071 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
8072 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
8073 fonts (Bug#6029).
8074 (add_font_entity_to_list): Fix logic errors in mixed boolean and
8075 bitwise arithmetic preventing use of unicode-sip and non-truetype
8076 opentype fonts.
8077
a06776b2
EZ
80782011-11-05 Eli Zaretskii <eliz@gnu.org>
8079
3ad924ba
EZ
8080 * s/ms-w32.h (fstat, stat, utime): Move redirections to
8081 "emacs"-only part.
8082
a06776b2
EZ
8083 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
8084 initialization code to keep similarity to xfns.c after changes
8085 from 2011-11-05.
8086
c9e7db78
JD
80872011-11-05 Jan Djärv <jan.h.d@swipnet.se>
8088
a97f8f3f
JD
8089 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
8090 (unwind_create_frame): New function (Bug#9943).
8091 (Fx_create_frame): Restructure code to be more similar to the one in
8092 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
8093 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8094 Move terminal->reference_count++ just before making the frame official
8095 (Bug#9943).
8096
8097 * nsterm.m (x_free_frame_resources): New function.
8098 (x_destroy_window): Move code to x_free_frame_resources.
8099
c9e7db78 8100 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
8101 (Fx_create_frame, x_create_tip_frame):
8102 Move terminal->reference_count++ just before making the frame
75f1671a 8103 official. Move initialization of image_cache_refcount and
c9e7db78
JD
8104 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
8105
a6fc3b5c
EZ
81062011-11-05 Eli Zaretskii <eliz@gnu.org>
8107
8108 Support MSVC build with newer versions of Visual Studio.
8109 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
8110 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8111 nt/gmake.defs.
8112
8113 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
8114 which are not supported by MSVC.
8115 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
8116 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
8117 bitfields.
8118 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
8119 types in bitfields.
8120 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
8121
8122 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
8123
58179cce 81242011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
8125
8126 Support MSVC build with newer versions of Visual Studio.
8127 * w32.c: Don't include w32api.h for MSVC.
8128 (init_environment) [_MSC_VER]: Call sys_access, not _access.
8129
8130 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
8131 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
8132 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
8133 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
8134 e_* cousins.
8135 (alloca) [_MSC_VER]: Define to _alloca.
8136
8137 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
8138
8139 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
8140
a58c13ed
EZ
81412011-11-04 Eli Zaretskii <eliz@gnu.org>
8142
8143 * xdisp.c (note_mouse_highlight): If either of
8144 previous/next-single-property-change returns nil, treat that as
8145 the beginning or the end of the buffer. (Bug#9955)
8146
fe0b6370
JD
81472011-11-04 Jan Djärv <jan.h.d@swipnet.se>
8148
a58c13ed 8149 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
8150 label is not null (Bug#9951).
8151 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
8152 may be NULL.
8153
89bd5ee1
EZ
81542011-11-04 Eli Zaretskii <eliz@gnu.org>
8155
8156 * window.c (Fwindow_body_size): Mention in the doc string that the
8157 return value is in frame's canonical units. (Bug#9949)
8158
84c3edb9
EZ
81592011-11-03 Eli Zaretskii <eliz@gnu.org>
8160
4e2fb5c7
EZ
8161 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
8162
84c3edb9 8163 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 8164 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 8165 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 8166
bc17a887
EZ
81672011-11-01 Eli Zaretskii <eliz@gnu.org>
8168
8169 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
8170 Don't stop backward scan on the continuation glyph, even though
8171 its CHARPOS is positive.
6d5eb5b0
SM
8172 (mouse_face_from_buffer_pos, note_mouse_highlight):
8173 Rename cover_string to disp_string.
bc17a887 8174
4ee88440
MR
81752011-11-01 Martin Rudalics <rudalics@gmx.at>
8176
8177 * window.c (temp_output_buffer_show): Don't use
8178 Vtemp_buffer_show_specifiers.
8179 (Vtemp_buffer_show_specifiers): Remove unused variable.
8180
c2ff3c02
EZ
81812011-10-30 Eli Zaretskii <eliz@gnu.org>
8182
8183 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
8184 past the beginning of the current glyph matrix.
8185
58179cce 81862011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
8187
8188 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
8189 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
8190 HAVE_GTK3 (Bug#9869).
b77a6a7f 8191
3b574623
JD
8192 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
8193 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
8194
b77a6a7f
JD
8195 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
8196
8197 * xterm.c: Declare x_handle_net_wm_state to return int.
8198 (handle_one_xevent): Check if we are iconified but don't have
8199 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
8200 (get_current_wm_state): Return non-zero if not hidden,
8201 check for _NET_WM_STATE_HIDDEN (Bug#9893).
8202 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
8203 (x_handle_net_wm_state): Return what get_current_wm_state returns.
8204 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
8205
196e41e4
PE
82062011-10-29 Paul Eggert <eggert@cs.ucla.edu>
8207
8208 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
8209 so that this new function doesn't get optimized away by a
8210 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
8211
021f2e1a
AS
82122011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8213
8214 * frame.h (MOUSE_HL_INFO): Remove excess parens.
8215
8b058d44
EZ
82162011-10-29 Eli Zaretskii <eliz@gnu.org>
8217
8218 Fix the `xbytecode' command.
8219 * .gdbinit (xprintbytestr): New command.
b50a28de 8220 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
8221 (xbytecode): Print the byte-code string as well.
8222
4452fb80
EZ
82232011-10-29 Kim Storm <storm@cua.dk>
8224
8b058d44
EZ
8225 * alloc.c (which_symbols): New function.
8226
21b72067
AS
82272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
8228
8229 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
8230 line. (Bug#9903)
8231
83ed7b5c
GM
82322011-10-29 Glenn Morris <rgm@gnu.org>
8233
8234 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
8235 Not clear what it was for, and it causes various bugs. (Bug#9839)
8236
5a7a728b
EZ
82372011-10-28 Eli Zaretskii <eliz@gnu.org>
8238
8239 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
8240 possible random value that matches one of those tested as
8241 condition to clear the mouse face.
8242
d3d0842f
CY
82432011-10-28 Chong Yidong <cyd@gnu.org>
8244
8245 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
8246
31b39d13
DN
82472011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
8248
8249 * window.c (make_window): Initialize phys_cursor_on_p.
8250
9aba6043
SM
82512011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
8252
8253 * lisp.h (struct Lisp_Symbol): Update comments.
8254
c20992f4
JB
82552011-10-28 Juanma Barranquero <lekktu@gmail.com>
8256
8257 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
8258
db4f02f2
EZ
82592011-10-28 Eli Zaretskii <eliz@gnu.org>
8260
8261 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
8262 <oslsachem@gmail.com> for helping to debug this.
8263
8264 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
8265 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
8266 (g_b_init_get_glyph_outline_w): New static variables.
8267 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
8268 (GetGlyphOutlineW_Proc): New typedefs.
8269 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
8270 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
8271 New functions.
8272 (w32font_open_internal, compute_metrics):
8273 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
8274 instead of calling the "wide" APIs directly.
8275
8276 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
8277
8278 * w32.h (syms_of_w32font): Add prototype.
8279
87e68db4
JB
82802011-10-27 Juanma Barranquero <lekktu@gmail.com>
8281
8282 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
8283 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
8284 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
8285 (Fmove_to_window_line): Doc fix.
8286
435c1d67
CY
82872011-10-27 Chong Yidong <cyd@gnu.org>
8288
8289 * process.c (make_process): Set gnutls_state to NULL.
8290
8291 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
8292 non-NULL, regardless of GNUTLS_INITSTAGE.
8293 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
8294 an error. Set process slots as soon as we allocate them.
8295
8296 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
8297
9c6c6f49
CY
82982011-10-27 Chong Yidong <cyd@gnu.org>
8299
9aba6043
SM
8300 * gnutls.c (emacs_gnutls_deinit): New function.
8301 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
8302 (Fgnutls_deinit, Fgnutls_boot): Use it.
8303
8304 * process.c (make_process): Initialize GnuTLS credentials to NULL.
8305 (deactivate_process): Call emacs_gnutls_deinit.
8306
657d08d3
JB
83072011-10-27 Juanma Barranquero <lekktu@gmail.com>
8308
8309 * image.c (x_create_x_image_and_pixmap):
8310 * w32.c (sys_rename, w32_delayed_load):
8311 * w32font.c (fill_in_logfont):
8312 * w32reg.c (x_get_string_resource): Silence compiler warnings.
8313
5430d399
JB
83142011-10-26 Juanma Barranquero <lekktu@gmail.com>
8315
8316 * w32fns.c (w32_default_color_map): New function,
8317 extracted from Fw32_default_color_map.
a7ef684b 8318 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 8319
fe0055fa
PE
83202011-10-25 Paul Eggert <eggert@cs.ucla.edu>
8321
8322 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
8323
e6346438
SM
83242011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
8325
8326 * keyboard.c (test_undefined): New function (bug#9751).
8327 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
8328
e112cc37
ET
83292011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
8330
8331 * sysdep.c (init_sys_modes): Fix the check for the controlling
8332 terminal (Bug#6649).
8333
7b5d6677
EZ
83342011-10-20 Eli Zaretskii <eliz@gnu.org>
8335
8336 * dispextern.h (struct bidi_it): New member next_en_type.
8337
8338 * bidi.c (bidi_line_init): Initialize the next_en_type member.
8339 (bidi_resolve_explicit_1): When next_en_pos is valid for the
8340 current character, check also for next_en_type being WEAK_EN.
8341 (bidi_resolve_weak): Don't enter the expensive loop if the current
8342 position is before next_en_pos. Record the bidi type of the first
8343 non-ET, non-BN character we find, in addition to its position.
8344 (bidi_level_of_next_char): Invalidate next_en_type when
8345 next_en_pos is over-stepped.
8346
7da0b018
PE
83472011-10-20 Paul Eggert <eggert@cs.ucla.edu>
8348
8349 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
8350 * editfns.c: Rewrite current-time-zone so that it invokes
8351 the equivalent of (format-time-string "%Z") to get the time zone name.
8352 This fixes a bug when the time zone name contains characters that
8353 need converting from the system time locale to Emacs internal format.
8354 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
8355 that patch fixed format-time-string to do the conversion, but
8356 I forgot to fix current-time-zone.
8357 (format_time_string): New function, containing most of
8358 what Fformat_time_string used to contain.
8359 (Fformat_time_string): Rewrite in terms of format_time_string.
8360 This doesn't change this function's behavior.
8361 (current-time-zone): Rewrite to use format_time_string.
8362 This fixes the bug reported by Michael Schierl in
8363 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
8364 Jason Rumney's 2007-06-07 change worked around this bug, but
8365 didn't fix it.
8366 * systime.h (tzname, timezone): Remove no-longer-used declarations.
8367
8547b010
EZ
83682011-10-19 Eli Zaretskii <eliz@gnu.org>
8369
8370 * xdisp.c (start_display): If the character at POS is displayed
8371 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
8372 (try_window_reusing_current_matrix): If a line ends in a display
8373 vector or the next line starts in a display vector, continue
8374 redrawing the window even though the character position of
8375 start_row was reached.
8547b010
EZ
8376 (Bug#9771, part 2)
8377
4e948d15
CY
83782011-10-18 Chong Yidong <cyd@gnu.org>
8379
8380 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
8381 with nobreak-char-display too.
8382
4787455f
EZ
83832011-10-18 Eli Zaretskii <eliz@gnu.org>
8384
8385 Fix part 3 of bug#9771.
8386 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
8387 (bidi_resolve_neutral): Don't enter the expensive loop looking for
8388 non-neutral characters if the current character is a paragraph
8389 separator (a.k.a. Newline). This avoids running the same
8390 expensive loop twice, once when we consume the preceding newline
8391 and the other time when the line actually needs to be displayed.
8392 Avoid the loop when we see neutrals on the base embedding level
8393 following a character whose directionality is the same as the
8394 paragraph's. This avoids running the expensive loop when a line
8395 ends in a long sequence of neutrals, like control characters.
8396 Add assertion against STRONG_AL type. Slightly rearrange code
8397 that determines the type of a neutral given the first non-neutral
8398 that follows it.
8399 (bidi_level_of_next_char): Set next_en_pos to zero when
8400 invalidating its info.
8401
2c91f553
EZ
84022011-10-17 Eli Zaretskii <eliz@gnu.org>
8403
8404 * xdisp.c (push_display_prop): Determine whether to record string
8405 or buffer position by IT->string, not by IT->method. Allow
8406 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
8407 (move_it_vertically_backward): Don't look for character position
8408 immediately after the newline when in a continuation line.
8409 (Bug#9771, part 1)
2c91f553 8410
c7b08b0d
MR
84112011-10-15 Martin Rudalics <rudalics@gmx.at>
8412
8413 * window.c (coordinates_in_window): Rewrite and delabelize
8414 vertical border check. (Bug#5357) (Bug#9618)
8415
6b02f655
SM
84162011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
8417
8418 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
8419 errors in XSetWindowBorder (bug#9310).
8420
81d40c92
DA
84212011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
8422
8423 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
8424 avoid crash when xmalloc overrun checking is enabled.
8425
d4172c3b
EZ
84262011-10-13 Eli Zaretskii <eliz@gnu.org>
8427
8428 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
8429 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
8430 cursor motion with <left> and <right> arrow keys.
8431
8432 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
8433 some callers set that themselves.
8434
b00eea75
EZ
84352011-10-12 Eli Zaretskii <eliz@gnu.org>
8436
8437 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
8438 display string and the previous row comes from the same string and
8439 is empty. (Bug#9739) (Bug#9738)
8440
8fe012c4
SM
84412011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
8442
8443 * doc.c (get_doc_string): Encode file name (bug#9735).
8444
0074aef2
EZ
84452011-10-12 Eli Zaretskii <eliz@gnu.org>
8446
79beb178
EZ
8447 * bidi.c (bidi_level_of_next_char):
8448 * xdisp.c (get_visually_first_element): Remove old incorrect
8449 comments regarding the Unicode Line Separator character.
8450
0074aef2
EZ
8451 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
8452
6e4b3fbe
DA
84532011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
8454
8455 * alloc.c (Fgc_status): Do not access beyond zombies array
8456 boundary if nzombies > MAX_ZOMBIES.
8457 * alloc.c (dump_zombies): Add missing format specifier.
8458
0324f3af
PE
84592011-10-12 Paul Eggert <eggert@cs.ucla.edu>
8460
b5525cac
PE
8461 * xdisp.c (set_cursor_from_row): Simplify conditionals,
8462 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
8463
0324f3af
PE
8464 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
8465 Some packages use them to denote characters with modifiers.
8466
e9b5f888
AS
84672011-10-11 Andreas Schwab <schwab@linux-m68k.org>
8468
8469 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
8470 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
8471 matching a pp-number. Rename parameter var to var1.
8472
127827c0
SM
84732011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
8474
8475 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
8476
c8fd3bd0
GM
84772011-10-08 Glenn Morris <rgm@gnu.org>
8478
8479 * callint.c (Fcall_interactively): Give a more explicit error for the
8480 'c' case with a non-character input. (Bug#8479)
8481
352ec8ff
EZ
84822011-10-08 Eli Zaretskii <eliz@gnu.org>
8483
03669ccb
EZ
8484 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
8485 lines.
7061c986
EZ
8486 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
8487 lines that are hscrolled on the left.
03669ccb 8488
352ec8ff
EZ
8489 * dispnew.c (buffer_posn_from_coords): Account for a possible
8490 presence of header-line. (Bug#4426)
8491
a66cfb1c
SM
84922011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
8493
6b02f655
SM
8494 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
8495 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 8496
7c5ee88e
PE
84972011-10-07 Paul Eggert <eggert@cs.ucla.edu>
8498
8499 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
8500 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
8501 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
8502 this makes Emacs dump core during garbage collection on rare
8503 occasions. sizeof is obviously inferior to offsetof here, so
8504 stick with offsetof.
8505 (GC_POINTER_ALIGNMENT): New macro.
8506 (mark_memory): Omit 3rd (offset) arg; caller changed.
8507 Don't assume EMACS_INT alignment is the same as pointer alignment.
8508
df1bbe5b
SM
85092011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
8510
8511 * keyboard.c (read_key_sequence_remapped): New var.
8512 (read_key_sequence): Compute remapping in the right buffer.
8513 (command_loop_1): Use read_key_sequence's remapping directly.
8514
51553db6
SM
85152011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
8516
32c1fffd
SM
8517 * dired.c (file_name_completion): Don't expand file name.
8518 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
8519 before checking file name handler.
8520
51553db6
SM
8521 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
8522 they've been requested explicitly (bug#9591).
8523
b6bd1599 85242011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
8525
8526 * keymap.c (Fsingle_key_description): Use make_specified_string
8527 instead of build_string to build string from push_key_description.
8528 (Bug#5193)
8529
f701dc2a
PE
85302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8531
4222c55d
PE
8532 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
8533 This fixes a Y2038 bug on 64-bit hosts.
8534 * buffer.c (reset_buffer):
8535 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
8536 (Fclear_buffer_auto_save_failure):
8537 Use 0, not -1, to represent an unset failure time, since time_t
8538 might not be signed.
8539
f701dc2a
PE
8540 Remove dependency on glibc malloc internals.
8541 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8542 Move back here from lisp.h, but with their new implementations.
8543 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8544 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
8545 * charset.c (charset_table_init): New static var.
8546 (syms_of_charset): Use it instead of xmalloc. This removes a
8547 dependency on glibc malloc internals. See Eli Zaretskii's comment in
8548 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
8549 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8550 Move back to alloc.c.
8551 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8552 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
8553
9ceebf39
JD
85542011-09-30 Jan Djärv <jan.h.d@swipnet.se>
8555
8556 * nsterm.m (windowDidResize): Call x_set_window_size only when
8557 ns_in_resize is true. Otherwise set pixelwidth/height and
8558 call change_frame_size (Bug#9628).
8559
cb993c58
PE
85602011-09-30 Paul Eggert <eggert@cs.ucla.edu>
8561
3930c88b
PE
8562 Port --enable-checking=all to Fedora 14 x86-64.
8563 * charset.c (syms_of_charset): Also account for glibc malloc's
8564 internal overhead when calculating the initial malloc maximum.
8565
cb993c58
PE
8566 Port --enable-checking=all to Fedora 14 x86.
8567 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8568 Move to lisp.h.
8569 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
8570 (overrun_check_realloc, overrun_check_free):
8571 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
8572 That way, xmalloc returns a properly-aligned pointer even if
8573 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
8574 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
8575 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
8576 into account when calculating the initial malloc maximum.
8577 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
8578 Move here from alloc.c, so that charset.c can use it too.
8579 Properly align; the old code wasn't right for common 32-bit hosts
8580 when configured with --enable-checking=all.
8581 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
8582 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
8583
31bed486
EZ
85842011-09-29 Eli Zaretskii <eliz@gnu.org>
8585
04c70788 8586 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
8587 use EDOM.
8588
fbcaa2f3
EZ
85892011-09-28 Eli Zaretskii <eliz@gnu.org>
8590
8591 * xdisp.c (compute_display_string_end): If there's no display
8592 string at CHARPOS, return -1.
8593
8594 * bidi.c (bidi_fetch_char): When compute_display_string_end
8595 returns a negative value, treat the character as a normal
8596 character not covered by a display string. (Bug#9624)
8597
a239d4e9
JB
85982011-09-28 Juanma Barranquero <lekktu@gmail.com>
8599
8600 * lread.c (Fread_from_string): Fix typo in docstring.
8601
88652fd5
EZ
86022011-09-27 Eli Zaretskii <eliz@gnu.org>
8603
8604 * xdisp.c (handle_invisible_prop): If invisible text ends on a
8605 newline, reseat the iterator instead of bidi-iterating there one
8606 character at a time. (Bug#9610)
32c1fffd
SM
8607 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
8608 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 8609
ed497dd4
AS
86102011-09-27 Andreas Schwab <schwab@linux-m68k.org>
8611
8612 * lread.c (readevalloop): Use correct code for NBSP.
8613 (read1): Likewise. (Bug#9608)
8614
b2bf61aa
MA
86152011-09-25 Michael Albinus <michael.albinus@gmx.de>
8616
8617 * dbusbind.c (Fdbus_register_signal): When service is not
8618 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
8619
32bbb17c
GM
86202011-09-25 Glenn Morris <rgm@gnu.org>
8621
8622 * buffer.c (truncate-lines): Doc fix.
8623
94e0933e
CY
86242011-09-24 Chong Yidong <cyd@stupidchicken.com>
8625
8626 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
8627 (Fset_window_next_buffers): Doc fix.
8628
cddde921
GM
86292011-09-24 Glenn Morris <rgm@gnu.org>
8630
8631 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
8632
1260aef1
PE
86332011-09-24 Paul Eggert <eggert@cs.ucla.edu>
8634
25b4bfa0
PE
8635 Fix minor problems found by static checking.
8636 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
8637 * indent.c (Fvertical_motion): Fix == vs = typo.
8638
e3cbd34b
EZ
86392011-09-24 Eli Zaretskii <eliz@gnu.org>
8640
a66cfb1c
SM
8641 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
8642 Default value is now t. Doc fix.
6bf7006f 8643
e3cbd34b 8644 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 8645 logic when moving up, not only when moving down. Fix the
e3cbd34b 8646 confusing name and values of the it_overshoot_expected variable;
32c1fffd 8647 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
8648
8649 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
8650 CHARPOS is covered by a display string which includes newlines.
8651 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
8652 is covered by a display string with embedded newlines.
8653
a3de0cbd
MA
86542011-09-24 Michael Albinus <michael.albinus@gmx.de>
8655
8656 * dbusbind.c (Fdbus_register_signal): Add match rule to
8657 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
8658 (Fdbus_register_method, Vdbus_registered_objects_table):
8659 Fix docstring.
a3de0cbd 8660
b260039d
JM
86612011-09-24 Jim Meyering <meyering@redhat.com>
8662
32c1fffd 8663 do not ignore write error for any output size
b260039d
JM
8664 The previous change was incomplete.
8665 While it makes emacs --batch detect the vast majority of stdout
8666 write failures, errors were still ignored whenever the output size is
8667 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8668 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
8669 && echo FAIL: ignored write error
8670 FAIL: ignored write error
8671 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
8672 && echo FAIL: ignored write error
8673 FAIL: ignored write error
8674 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
8675
8eca8a7c
AS
86762011-09-23 Andreas Schwab <schwab@linux-m68k.org>
8677
8678 * emacs.c (Fkill_emacs): In noninteractive mode exit
8679 non-successfully if a write error occurred on stdout. (Bug#9574)
8680
3341db62
EZ
86812011-09-21 Eli Zaretskii <eliz@gnu.org>
8682
8683 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
8684 the xassert test.
8685
8686 * dispextern.h (struct it): Update the comment documenting what
8687 can it->OBJECT be.
8688
8c203dbf
EZ
86892011-09-20 Eli Zaretskii <eliz@gnu.org>
8690
8691 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
8692 a display string, extend search for cursor position to end of row.
8693 (find_row_edges): If the row ends in a newline from a display
8694 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
8695 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
8696 (Fcurrent_bidi_paragraph_direction): Fix search for previous
8697 non-empty line. Fixes confusing cursor motion with arrow keys at
8698 the beginning of a line that starts with whitespace.
8c203dbf 8699
a4824228
LMI
87002011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8701
8702 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
8703 (bug#9493).
8704
33ed493b
CY
87052011-09-18 Chong Yidong <cyd@stupidchicken.com>
8706
8707 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
8708 boolean (Bug#9154).
8709
56cd55c8
EZ
87102011-09-18 Eli Zaretskii <eliz@gnu.org>
8711
8712 * xdisp.c (display_line): Record maximum and minimum buffer
8713 positions even if no glyphs were produced (e.g., by a zero-width
8714 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
8715 buffer positions that will be removed from the glyph row because
8716 they don't fit.
c02dcedf
EZ
8717 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
8718 column is beyond frame width: don't subtract 1 "pixel" when
8719 computing width of the stretch.
3e62b7e0
EZ
8720 (reseat_at_next_visible_line_start): Undo the change made on
8721 2011-09-17 that saved paragraph information and restored it after
8722 the call to `reseat'. (Bug#9545)
56cd55c8 8723
5ed99d36 87242011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
8725
8726 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
8727 and turn window cursor on if cleared (Bug#9415).
8728
5ed99d36 87292011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
8730
8731 * search.c (boyer_moore): Take unibyte characters from pattern
8732 literally. (Bug#9458)
8733
9bade7b2
EZ
87342011-09-18 Eli Zaretskii <eliz@gnu.org>
8735
8736 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
8737
e5e9d610
PE
87382011-09-18 Paul Eggert <eggert@cs.ucla.edu>
8739
87e4427a
PE
8740 Fix minor problem found by static checking.
8741 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
8742 initialized, to pacify gcc -Wuninitialized.
8743
e5e9d610
PE
8744 * fileio.c: Report proper errno when syscall falls.
8745 (Finsert_file_contents): Save and restore errno,
8746 so that report_file_error outputs the correct diagnostic.
8747 (Fwrite_region) [CLASH_DETECTION]: Likewise.
8748
a1674f0b
EZ
87492011-09-18 Eli Zaretskii <eliz@gnu.org>
8750
8751 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
8752
fbfb6dd4
EZ
87532011-09-17 Eli Zaretskii <eliz@gnu.org>
8754
8755 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
8756 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
8757
bb187662
EZ
87582011-09-17 Eli Zaretskii <eliz@gnu.org>
8759
1137e8b8 8760 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 8761 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
8762
8763 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
8764 (bidi_find_paragraph_start): Search back for paragraph beginning
8765 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
8766 (bidi_move_to_visually_next): Only trigger paragraph-related
8767 computations when the last character is a newline or at EOB, not
8768 just any NEUTRAL_B. (Bug#9470)
8769
bb187662
EZ
8770 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
8771 truncated lines if point is covered by a display string. (Bug#9524)
8772
2e621251
PE
87732011-09-16 Paul Eggert <eggert@cs.ucla.edu>
8774
8775 * xselect.c: Relax test for outgoing X longs (Bug#9498).
8776 (cons_to_x_long): New function.
8777 (lisp_data_to_selection_data): Use it. Correct the test for
8778 short-versus-long data; it was negated. Break out of vector
8779 loop, for efficiency, when a long datum is discovered.
8780
91a15bc6
SM
87812011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
8782
8783 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
8784
b41c3a35
EZ
87852011-09-16 Eli Zaretskii <eliz@gnu.org>
8786
8787 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
8788 GCC PR/17406) by declaring this function with external scope.
8789
7812ba2d
PE
87902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8791
8792 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
8793 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
8794
cf7edc2a
AS
87952011-09-15 Andreas Schwab <schwab@linux-m68k.org>
8796
8797 * editfns.c (Fformat): Correctly handle text properties on "%%".
8798
bd01620e
EZ
87992011-09-15 Eli Zaretskii <eliz@gnu.org>
8800
8801 * xterm.c (x_draw_composite_glyph_string_foreground):
8802 * w32term.c (x_draw_composite_glyph_string_foreground):
8803 * term.c (encode_terminal_code):
8804 * composite.c (composition_update_it, get_composition_id):
8805 * xdisp.c (get_next_display_element)
8806 (fill_composite_glyph_string): Add comments about special meaning
8807 of TAB characters in a composition.
8808
a02719a3
PE
88092011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8810
8811 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8812 This occurs when processing a multibyte format.
8813 Problem reported by Wolfgang Jenker.
a02719a3 8814
72589a3c
JB
88152011-09-15 Johan Bockgård <bojohan@gnu.org>
8816
8817 * xdisp.c (try_cursor_movement): Only check for exact match if
8818 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8819
1c14176c
PE
88202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8821
8822 Remove unused external symbols.
8823 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8824 * xdisp.c (calc_pixel_width_or_height): Now static.
8825 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8826 * indent.c (check_display_width):
8827 * w32term.c: Fix comment to match code.
8828 * xterm.c, xterm.h (x_catching_errors): Remove.
8829
d2eea5b5
PE
88302011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8831
8832 * xselect.c: Use signed conversions more consistently (Bug#9498).
8833 (selection_data_to_lisp_data): Assume incoming selection data are
8834 signed integers, not unsigned. This is to be consistent with
8835 outgoing selection data, which was modified to use signed integers
8836 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8837 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8838 expects long, not unsigned long.
8839
46888499
EZ
88402011-09-14 Eli Zaretskii <eliz@gnu.org>
8841
8842 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8843 computation of loop end. Reported by Johan Bockgård
8844 <bojohan@gnu.org>.
8845
ef8ef9fb
CY
88462011-09-13 Chong Yidong <cyd@stupidchicken.com>
8847
8848 * frame.c (Fother_visible_frames_p): Function deleted.
8849
fa819fed
EZ
88502011-09-12 Eli Zaretskii <eliz@gnu.org>
8851
8852 * indent.c (compute_motion): Process display vector front to back
8853 rather than the other way around. (Bug#2496)
8854
2ba8e008
SM
88552011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8856
8857 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8858
20f53c69
CY
88592011-09-11 Chong Yidong <cyd@stupidchicken.com>
8860
8861 * minibuf.c (Fread_from_minibuffer): Doc fix.
8862
d562d7a4
EZ
88632011-09-11 Eli Zaretskii <eliz@gnu.org>
8864
8865 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8866 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8867
1c4d7f3d
LMI
88682011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8869
8870 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8871 value for non-existent files.
8872
b885bf36
EZ
88732011-09-11 Eli Zaretskii <eliz@gnu.org>
8874
8875 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8876 set its "size" to -1. This will set the modtime_size field of
8877 the corresponding buffer to -1, which is what
8878 verify-visited-file-modtime expects for files that do not exist.
8879 (Bug#9139)
8880
6612f0bf
PE
88812011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8882
8883 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8884 here ...
8885 * lisp.h: ... from here. push_key_description is no longer
8886 defined in keyboard.c, so its declaration should not be in
8887 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8888 logically belongs with push_key_description.
8889
dfb3f755
PE
88902011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8891
8892 * buffer.h: Include <sys/types.h> instead of <time.h>.
8893 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8894 Problem reported by Herbert J. Skuhra.
8895
3134906c
LMI
88962011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8897
8898 * xml.c (parse_region): Make the parsing work for
8899 non-comment-starting XML files again (bug#9144).
8900
8d903f4e
AS
89012011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8902
8903 * image.c (gif_load): Fix calculation of bottom and right corner.
8904 (Bug#9468)
8905
80ad64f4
EZ
89062011-09-10 Eli Zaretskii <eliz@gnu.org>
8907
8908 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8909 redisplay in small windows.
8910
208a048d
EZ
89112011-09-09 Eli Zaretskii <eliz@gnu.org>
8912
8913 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8914
9b1c252e
MR
89152011-09-08 Martin Rudalics <rudalics@gmx.at>
8916
8917 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8918 Operate on live windows only.
8919
2949f33b
JB
89202011-09-08 Juanma Barranquero <lekktu@gmail.com>
8921
8922 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8923
e08dcafd
EZ
89242011-09-07 Eli Zaretskii <eliz@gnu.org>
8925
8926 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8927 only under bidi iteration.
8928
115b96bd
JD
89292011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8930
8931 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8932
c8199d0f
PE
89332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8934
8935 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8936 Without this fix, the command to link temacs failed due to an
8937 undefined symbol __builtin_isnan. This is because
8938 /usr/include/iso/math_c99.h #defines isnan(x) to
8939 __builtin_isnan(x), but the bundled gcc, which identifies itself
8940 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8941 a __builtin_isnan.
8942 * floatfns.c (isnan): #undef, and then #define to a clone of
8943 what's in data.c.
8944 (Fisnan): Always define, since it's always available now.
8945 (syms_of_floatfns): Always define isnan at the Lisp level.
8946
e39b275c 89472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8948
8949 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8950
b2db44d9 89512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8952
f4af5137 8953 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8954 The previous code assumed that file offsets (off_t values) fit in
8955 EMACS_INT variables, which is not true on typical 32-bit hosts.
8956 The code messed up by falsely reporting buffer overflow in cases
8957 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8958 when "big" contains more than 2**29 bytes, even though this
8959 inserts just one byte and does not overflow the buffer.
8960 (Finsert_file_contents): Store file offsets as off_t
8961 values, not as EMACS_INT values. Check for overflow when
8962 converting between EMACS_INT and off_t. When checking for
8963 buffer overflow or for overlap, take the offsets into account.
8964 Don't use EMACS_INT for small values where int suffices.
8965 When checking for overlap, fix a typo: ZV was used where
8966 ZV_BYTE was intended.
8967 (Fwrite_region): Don't assume off_t fits into 'long'.
8968 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8969
ecfc0a49
MA
89702011-09-05 Michael Albinus <michael.albinus@gmx.de>
8971
8972 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8973
6511acf2 89742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8975
0999621a 8976 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8977
8978 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8979 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8980 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8981 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8982 (modify_event_symbol): Do not assume that the length of
8983 name_alist_or_stem is safe to alloca and fits in int.
8984 (Fexecute_extended_command): Likewise for function name and binding.
8985 (Frecursion_depth): Wrap around reliably on integer overflow.
8986 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8987 since some callers pass EMACS_INT values.
8988 (Fsingle_key_description): Don't crash if symbol name contains more
8989 than MAX_ALLOCA bytes.
8990 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8991 (get_minibuffer): Arg is now EMACS_INT, not int.
8992 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8993 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8994 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8995
2be7d702
PE
8996 * dbusbind.c (signature_cat): New function.
8997 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8998 Do not overrun buffer; instead, report string overflow.
8999
9d1df220
PE
9000 * dispnew.c (add_window_display_history): Don't overrun buffer.
9001 Truncate instead; this is OK since it's just a log.
9002
33ef5c64
PE
9003 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
9004 even if the time zone offset is outlandishly large.
9005 Don't mishandle offset == INT_MIN.
9006
66c6fdd5
PE
9007 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
9008 when creating daemon; the previous buffer-overflow check was incorrect.
9009
d749b01b
PE
9010 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
9011 which has the guts of the old verror function.
9012
b5cd1905
PE
9013 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
9014 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
9015
6e1a67fb
PE
9016 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
9017 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 9018 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 9019 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
9020 length of string rather than counting it via multiple sprintfs;
9021 that's simpler and more reliable.
c21721cc
PE
9022 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
9023 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
9024 sprintf, in case result does not fit in int.
9025
c57b67fc
PE
9026 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
9027 (fontset_from_font): Print it.
9028
8a401434
PE
9029 * frame.c (tty_frame_count): Now printmax_t, not int.
9030 (make_terminal_frame, set_term_frame_name): Print it.
9031 (x_report_frame_params): In X, window IDs are unsigned long,
9032 not signed long, so print them as unsigned.
9033 (validate_x_resource_name): Check for implausibly long names,
9034 and don't assume name length fits in 'int'.
9035 (x_get_resource_string): Don't blindly alloca invocation name;
9036 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
9037 not fit in int.
9038
6e1a67fb
PE
9039 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
9040 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
9041 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
9042
0df02bf3
PE
9043 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
9044 Use esprintf, not sprintf, in case result does not fit in int.
9045
48e30793
PE
9046 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9047 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
9048 it as a large positive number.
9049 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
9050 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
9051
a66ff6d8
PE
9052 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
9053 in case result does not fit in int.
9054
aca216ff
PE
9055 * print.c (float_to_string): Detect width overflow more reliably.
9056 (print_object): Make sprintf buffer a bit bigger, to avoid potential
9057 buffer overrun. Don't assume list length fits in 'int'. Treat
9058 print length of 0 as 0, not as infinity; to be consistent with other
9059 uses of print length in this function. Don't overflow print length
9060 index. Don't assume hash table size fits in 'long', or that
9061 vectorlike size fits in 'unsigned long'.
9062
31c286f7
PE
9063 * process.c (make_process): Use printmax_t, not int, to format
9064 process-name gensyms.
9065
55e5faa1
PE
9066 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
9067
80f2e268
PE
9068 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
9069 to avoid potential buffer overrun.
9070
670741ab
PE
9071 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
9072 if X resource line is longer than 512 bytes.
9073
b7163a50
PE
9074 * xfns.c (x_window): Make sprintf buffer a bit bigger
9075 to avoid potential buffer overrun.
9076
ae58ff1f
PE
9077 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
9078
c43c8a6a
PE
9079 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
9080
3f8236f4
PE
90812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
9082
53e9fe90 9083 Integer overflow fixes for scrolling, etc.
6511acf2
PE
9084 Without these, Emacs silently mishandles large integers sometimes.
9085 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
9086 it were "C-u 1 M-x recenter" on a typical 64-bit host.
9087
6511acf2
PE
9088 * xdisp.c (try_window_id): Check Emacs fixnum range before
9089 converting to 'int'.
806add1d 9090
6511acf2 9091 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
9092 Check that an Emacs fixnum is in range before assigning it to 'int'.
9093 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
9094 values converted from Emacs fixnums.
9095 (Frecenter): Don't wrap around a line count if it is out of 'int'
9096 range; instead, treat it as an extreme value.
9097 (Fset_window_configuration, compare_window_configurations):
9098 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
9099
6511acf2
PE
9100 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
9101 that can exceed INT_MAX. Check that EMACS_INT value is in range
9102 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
9103 (match_limit): Don't assume that a fixnum can fit in 'int'.
9104
6511acf2 9105 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
9106 exceed INT_MAX.
9107
6511acf2 9108 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
9109 (Fvertical_motion): Don't wrap around LINES values that don't fit
9110 in 'int'. Instead, treat them as extreme values. This is good
9111 enough for windows, which can't have more than INT_MAX lines anyway.
9112
fcb901a7
LMI
91132011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9114
0f2f6b6d
LMI
9115 * Require libxml/parser.h to avoid compilation warning.
9116
fcb901a7
LMI
9117 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
9118
9119 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
9120 since this reportedly can destroy thread storage.
9121
6e20a0d4
CY
91222011-08-30 Chong Yidong <cyd@stupidchicken.com>
9123
9124 * syntax.c (find_defun_start): Update all cache variables if
9125 exiting early (Bug#9401).
9126
148ae00e
EZ
91272011-08-30 Eli Zaretskii <eliz@gnu.org>
9128
f6cfbd8f
EZ
9129 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
9130
148ae00e
EZ
9131 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
9132 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
9133 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
9134
9135 * term.c (tty_append_glyph): New function.
9136 (produce_stretch_glyph): Static function and its prototype deleted.
9137
a66cfb1c
SM
9138 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
9139 Add prototypes.
148ae00e 9140
c4a07a4c
PE
91412011-08-29 Paul Eggert <eggert@cs.ucla.edu>
9142
9143 * image.c (parse_image_spec): Check for nonnegative, not for positive,
9144 when checking :margin (Bug#9390).
9145 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 9146 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
9147 so that the name doesn't mislead. All uses changed.
9148
6bc8cd65
JB
91492011-08-28 Johan Bockgård <bojohan@gnu.org>
9150
9151 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
9152 set_tty_hooks.
9153
dca4927e
EZ
91542011-08-27 Eli Zaretskii <eliz@gnu.org>
9155
9156 * xdisp.c (move_it_to): Don't bail out early when reaching
9157 position beyond to_charpos, if we are scanning backwards.
9158 (move_it_vertically_backward): When DY == 0, make sure we get to
9159 the first character in the line after the newline.
9160
f2cad773
PE
91612011-08-27 Paul Eggert <eggert@cs.ucla.edu>
9162
9163 * ccl.c: Improve and simplify overflow checking (Bug#9196).
9164 (ccl_driver): Do not generate an out-of-range pointer.
9165 (Fccl_execute_on_string): Remove unnecessary check for
9166 integer overflow, noted by Stefan Monnier in
9167 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
9168 Remove a FIXME that didn't need fixing.
9169 Simplify the newly-introduced buffer reallocation code.
9170
0cae2cdb
JB
91712011-08-27 Juanma Barranquero <lekktu@gmail.com>
9172
9173 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
9174
5fc295a4 91752011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 9176
70c60eb2 9177 Integer and memory overflow issues (Bug#9196).
726e0ab1 9178
d31850da
PE
9179 * doc.c (get_doc_string): Rework so that
9180 get_doc_string_buffer_size is the actual buffer size, rather than
9181 being 1 less than the actual buffer size; this makes xpalloc more
9182 convenient.
9183
a69fbedb
PE
9184 * image.c (x_allocate_bitmap_record, cache_image):
9185 * xselect.c (Fx_register_dnd_atom):
9186 Simplify previous changes by using xpalloc.
9187
fe5c5d37
PE
9188 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
9189 since either will do and ptrdiff_t is convenient with xpalloc.
9190
0065d054
PE
9191 * charset.c (charset_table_size)
9192 (struct charset_sort_data.priority): Now ptrdiff_t.
9193 (charset_compare): Don't overflow if priorities differ greatly.
9194 (Fsort_charsets): Don't assume list length fits in int.
9195 Check for size-calculation overflow when allocating sort data.
9196 (syms_of_charset): Allocate an initial charset table that is
9197 just under 64 KiB, to avoid problems with glibc malloc and mmap.
9198
9199 * cmds.c (internal_self_insert): Check for size-calculation overflow.
9200
9201 * composite.h (struct composition.glyph_len): Now int, not unsigned.
9202 The actual value is always <= INT_MAX, and leaving it unsigned made
9203 overflow checking harder.
9204
9205 * dispextern.h (struct glyph_matrix.rows_allocated)
9206 (struct face_cache.size): Now ptrdiff_t, for convenience in use
9207 with xpalloc. The values are still always <= INT_MAX.
9208
9209 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
9210
9211 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
9212 (SAFE_NALLOCA): New macro.
9213
9214 * region-cache.c (struct boundary.pos, find_cache_boundary)
9215 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
9216 (set_cache_region, invalidate_region_cache)
9217 (revalidate_region_cache, know_region_cache, region_cache_forward)
9218 (region_cache_backward, pp_cache):
9219 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
9220 so that ptrdiff_t * can be passed to xpalloc.
9221 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
9222 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
9223 (pp_cache): Don't assume cache_len fits in int.
9224 * region-cache.h: Adjust extern decls to match.
9225
9226 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
9227 EMACS_INT, since either will do, for xpalloc.
9228
9229 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
9230 (xnmalloc, xnrealloc, xpalloc): New functions.
9231
726e0ab1
PE
9232 * bidi.c (bidi_shelve_header_size): New constant.
9233 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
9234 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
9235
51f30bc5 9236 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
9237 * buffer.c (overlays_at, overlays_in, record_overlay_string)
9238 (overlay_strings):
9239 Don't update size of array until after memory allocation succeeds,
9240 because xmalloc/xrealloc may not return.
0065d054
PE
9241 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
9242 now that we have proper integer overflow checking.
9243 (record_overlay_string, overlay_strings): Catch overflows when
9244 calculating size of overlay_str_buf.
726e0ab1 9245
0065d054
PE
9246 * callproc.c (Fcall_process): Check for size overflow when
9247 calculating size of args2.
9248 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
9249 Normally we prefer signed values, but sticking with ptrdiff_t would
9250 require adding more-complicated checks.
726e0ab1
PE
9251
9252 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
9253 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
9254 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 9255 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
9256
9257 * character.c (Fstring): Check for size-calculation overflow.
9258
9259 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
9260 unnecessary integer overflow. Check for size overflow.
9261 (encode_coding_object): Don't update size until xmalloc succeeds.
9262
9263 * composite.c (get_composition_id): Check for overflow in glyph
9264 length calculations.
9265
9266 Integer and memory overflow fixes for display code.
9267 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
9268 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
9269 (scrolling_window): Check for overflow in size calculations.
9270 (line_draw_cost, realloc_glyph_pool, add_row_entry):
9271 Don't assume glyph table len fits in int.
9272 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
9273 (row_table_size): Now ptrdiff_t, not int.
9274 (scrolling_window): Avoid overflow in size calculations.
9275 Don't update size until allocation succeeds.
9276 * fns.c (concat): Check for overflow in size calculations.
9277 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
9278 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9279 (NEXT_ALMOST_PRIME_LIMIT): New constant.
9280
9281 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
9282 (get_doc_string): Check for size calculation overflow.
9283 Don't update size until allocation succeeds.
9284 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
9285 EMACS_INT, where ptrdiff_t will do.
9286 (Fsubstitute_command_keys): Check for string overflow.
9287
9288 * editfns.c (set_time_zone_rule): Don't assume environment length
9289 fits in int.
9290 (message_length): Now ptrdiff_t, not int.
9291 (Fmessage_box): Don't update size until allocation succeeds.
9292 Don't assume message length fits in int.
9293 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
9294
0065d054
PE
9295 * emacs.c (main): Do not reallocate argv, since there is a null at
9296 the end that can be overwritten, and this way there's no need to
9297 worry about size-calculation overflow.
9298 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
9299
9300 * eval.c (init_eval_once, grow_specpdl): Don't update size until
9301 alloc succeeds.
9302 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
9303
9304 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
9305 (x_set_scroll_bar_width, x_figure_window_size):
9306 Check for integer overflow.
9307 (x_set_alpha): Do not assume XINT fits in int.
9308
9309 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
9310 This is for the members text_lines, text_cols, total_lines, total_cols,
9311 where the system imposes an 'int' limit.
9312
9313 * fringe.c (Fdefine_fringe_bitmap):
9314 Don't update size until alloc works.
9315
9316 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
9317 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
9318
9319 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
9320 Check for size-calculation overflow.
9321 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
9322 do, as we prefer signed integers.
9323 (id_to_widget.max_size, id_to_widget.used)
9324 (xg_store_widget_in_map, xg_remove_widget_from_map)
9325 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
9326 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
9327 Use and return ptrdiff_t, not int.
9328 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
9329 * gtkutil.h: Change prototypes to match the above.
9330
9331 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
9332 are duplicate now that they've been promoted to lisp.h.
9333 (x_allocate_bitmap_record, x_alloc_image_color)
9334 (make_image_cache, cache_image, xpm_load):
9335 Don't update size until alloc is done.
9336 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
9337 (x_detect_edges):
3256efce 9338 Check for size calculation overflow.
726e0ab1
PE
9339 (ct_colors_allocated_max): New constant.
9340 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
9341 overflow.
3256efce 9342
726e0ab1
PE
9343 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
9344 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
9345 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
9346 Use ptrdiff_t, not int, to count maps.
9347 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
9348 calculations. Don't update size until allocation succeeds.
9349 Redo calculations to avoid overflow.
726e0ab1
PE
9350 * keyboard.h: Change prototypes to match the above.
9351
9352 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
9353 to count maps.
9354 (current_minor_maps): Check for size calculation overflow.
9355 * keymap.h: Change prototypes to match the above.
9356
9357 * lread.c (read1, init_obarray): Don't update size until alloc done.
9358
9359 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
9360 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
9361
726e0ab1
PE
9362 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
9363 Now ptrdiff_t, not int.
9364 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
9365 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
9366
9367 * process.c (Fnetwork_interface_list): Check for overflow
9368 in size calculation.
9369
9370 * region-cache.c (move_cache_gap): Check for size calculation overflow.
9371
9372 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
9373 overflow. Don't bother calling xmalloc when xrealloc will do.
9374
9375 * search.c (Freplace_match): Check for size calculation overflow.
9376 (Fset_match_data): Don't assume list lengths fit in 'int'.
9377
9378 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
9379 for command line length. Do not attempt to address one before the
9380 beginning of an array, as that's not portable.
9381
9382 * term.c (max_frame_lines): Remove; unused.
9383 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
9384 not int.
9385 (encode_terminal_code, calculate_costs): Check for size
9386 calculation overflow.
9387 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
9388 table lengths and related sizes. Don't update size until alloc
9389 done. Redo calculations to avoid overflow.
9390 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
9391
9392 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
9393 subtracting pointers.
9394 (gobble_line): Check for overflow more carefully. Don't update size
9395 until alloc done.
9396
9397 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
9398 Don't update size until alloc done.
9399 Redo size calculations to avoid overflow.
9400 Check for size calculation overflow.
0065d054 9401 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
9402
9403 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
9404 Use ptrdiff_t, not int, for sizes.
9405 (store_mode_line_noprop_char): Don't update size until alloc done.
9406
0065d054
PE
9407 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
9408 Use ptrdiff_t, not int, for sizes.
9409 (Finternal_make_lisp_face, cache_face):
9410 Check for size calculation overflow.
9411 (cache_face): Treat size calculation overflows as if they were
9412 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
9413
9414 * xfns.c (x_encode_text, x_set_name_internal)
9415 (Fx_change_window_property): Use ptrdiff_t, not int, to count
9416 sizes, since they can exceed INT_MAX in size. Check for size
9417 calculation overflow.
9418
0065d054
PE
9419 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
9420 (xg_select): Check for size calculation overflow.
726e0ab1
PE
9421 Don't update size until alloc done.
9422
0065d054 9423 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 9424 as sprintf is limited to int lengths.
1d526e2f 9425
252c5ee1
PE
9426 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
9427 (X_LONG_MIN): New macros.
864d7ce7
PE
9428 Use them to make the following changes clearer.
9429 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
9430 This change doesn't affect the value now, but it may help remind
9431 future maintainers not to raise the value too much later.
9432 (SELECTION_QUANTUM): Remove, replacing with ...
9433 (selection_quantum): ... new function, which avoids overflow.
9434 All uses changed.
9435 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
9436 assumption that selection length fits in 'int'.
9437 (x_reply_selection_request, x_handle_selection_request)
9438 (x_get_window_property, receive_incremental_selection)
9439 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
9440 (lisp_data_to_selection_data, clean_local_selection_data):
9441 Use ptrdiff_t, not int, to record length of selection.
9442 (x_reply_selection_request, x_get_window_property)
9443 (receive_incremental_selection, x_property_data_to_lisp):
9444 Redo calculations to avoid overflow.
9445 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 9446 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
9447 something.
9448 (x_get_window_property, receive_incremental_selection)
9449 (lisp_data_to_selection_data, x_property_data_to_lisp):
9450 Check for size-calculation overflow.
9451 (x_get_window_property, receive_incremental_selection)
9452 (lisp_data_to_selection_data, Fx_register_dnd_atom):
9453 Don't store size until memory allocation succeeds.
9454 (x_get_window_property): Plug memory leak on memory exhaustion.
9455 Don't double-block input; malloc is safe here. Don't assume 2**34
9456 - 4 fits in unsigned long. Add an xassert to check
9457 XGetWindowProperty overflow. Be more careful about overflow
9458 calculations, and distinguish size from memory overflow better.
9459 (receive_incremental_selection): When tracing, don't assume
9460 unsigned int is less than INT_MAX.
9461 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
9462 harmful) conversions of unsigned short to int.
9463 (lisp_data_to_selection_data): Don't assume that integers
9464 in the range -65535 through -1 fit in an X unsigned short.
9465 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
9466 result parameters unless successful. Rely on cons_to_unsigned
9467 to report problems with elements; the old code wasn't right anyway.
9468 (x_check_property_data): Check for int overflow; we cannot use
9469 a wider type due to X limits.
9470 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
9471
726e0ab1 9472 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 9473
0065d054
PE
9474 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
9475 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
9476 (x_color_cells): Don't store size until memory allocation succeeds.
9477 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 9478 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
9479 (x_term_init): Don't assume length fits in int (sprintf is limited
9480 to int size).
bc18e09d 9481
ebfa62c0
PE
9482 Use ptrdiff_t for composition IDs.
9483 * character.c (lisp_string_width):
9484 * composite.c (composition_table_size, n_compositions)
9485 (get_composition_id, composition_gstring_from_id):
9486 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
9487 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
9488 * window.c (Frecenter):
9489 Use ptrdiff_t, not int, for composition IDs.
9490 * composite.c (get_composition_id): Check for integer overflow.
9491 * composite.h: Adjust prototypes to match the above changes.
9492
d3411f89
PE
9493 Use ptrdiff_t for hash table indexes.
9494 * category.c (hash_get_category_set):
9495 * ccl.c (ccl_driver):
9496 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
9497 * coding.c (coding_system_charset_list, detect_coding_system):
9498 * coding.h (struct coding_system.id):
9499 * composite.c (get_composition_id, gstring_lookup_cache):
9500 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
9501 * image.c (xpm_get_color_table_h):
9502 * lisp.h (hash_lookup, hash_put):
9503 * minibuf.c (Ftest_completion):
9504 Use ptrdiff_t for hash table indexes, not int (which is too
9505 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
9506 32-bit --with-wide-int hosts).
9507
e097a6fa
PE
9508 * charset.c (Fdefine_charset_internal): Check for integer overflow.
9509 Add a FIXME comment about memory leaks.
9510 (syms_of_charset): Don't assume xmalloc returns.
9511
5637687f
PE
9512 Don't assume that stated character widths fit in int.
9513 * character.c (Fchar_width, c_string_width, lisp_string_width):
9514 * character.h (CHAR_WIDTH):
9515 * indent.c (MULTIBYTE_BYTES_WIDTH):
9516 Use sanitize_char_width to avoid undefined and/or bad behavior
9517 with outlandish widths.
a66cfb1c 9518 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
9519 now that we have two such functions. All uses changed.
9520 (sanitize_char_width): New inline function.
9521
a2271ba2
PE
9522 Don't assume that tab-width fits in int.
9523 * character.h (sanitize_width): New inline function.
9524 (SANE_TAB_WIDTH): New macro.
9525 (ASCII_CHAR_WIDTH): Use it.
9526 * indent.c (sane_tab_width): Remove. All uses replaced by
9527 SANE_TAB_WIDTH (current_buffer).
9528 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
9529
18c52557
PE
9530 * fileio.c: Integer overflow issues with file modes.
9531 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
9532
caeeedc1
PE
9533 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
9534 Remove unreachable code.
9535 (read_hex, load_charset_map_from_file): Check for integer overflow.
9536
6df6ae42 9537 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
9538 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
9539 (x_send_scroll_bar_event): Likewise. Check that the size does not
9540 exceed limits imposed by XClientMessageEvent, as well as the usual
9541 ptrdiff_t and size_t limits.
9542
b13995db
PE
9543 * keyboard.c: Overflow, signedness and related fixes.
9544 (make_lispy_movement): Use same integer type in forward decl
9545 that is used in the definition.
9546 (read_key_sequence, keyremap_step):
9547 Change bufsize argument back to int, undoing my 2011-03-30 change.
9548 We prefer signed types, and int is wide enough here.
9549 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
9550 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
9551 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
9552 length, not size_t. Use ptrdiff_t for index, not int.
9553 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
9554 possibility of integer overflow.
9555
13464394
PE
9556 Overflow, signedness and related fixes for images.
9557
9558 * dispextern.h (struct it.stack[0].u.image.image_id)
9559 (struct_it.image_id, struct image.id, struct image_cache.size)
9560 (struct image_cache.used, struct image_cache.ref_count):
9561 * gtkutil.c (update_frame_tool_bar):
9562 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
9563 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
9564 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
9565 * nsmenu.m (update_frame_tool_bar):
9566 * xdisp.c (calc_pixel_width_or_height):
9567 * xfns.c (image_cache_refcount):
9568 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
9569 on typical 64-bit hosts.
9570
9571 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
9572 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
9573 Omit unnecessary casts to int.
9574 (parse_image_spec): Check that integers fall into 'int' range
9575 when the callers expect that.
9576 (image_ascent): Redo ascent calculation to avoid int overflow.
9577 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
9578 (lookup_image): Remove unnecessary tests.
9579 (xbm_image_p): Locals are now of int, not EMACS_INT,
9580 since parse_image_check makes sure they fit into int.
9581 (png_load, gif_load, svg_load_image):
9582 Prefer int to unsigned where either will do.
9583 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
9584 old tiff_error_handler and tiff_warning_handler.
9585 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
9586 stack buffer overflows. It uses only the features of vsnprintf
9587 that are common to both POSIX and native Microsoft.
9588 (tiff_error_handler, tiff_warning_handler): Use it.
9589 (tiff_load, gif_load, imagemagick_load_image):
9590 Don't assume :index value fits in 'int'.
9591 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
9592 (imagemagick_load_image): Check that crop parameters fit into
9593 the integer types that MagickCropImage accepts. Don't assume
9594 Vimagemagick_render_type has a nonnegative value. Don't assume
9595 size_t fits in 'long'.
9596 (gs_load): Use printmax_t to print the widest integers possible.
9597 Check for integer overflow when computing image height and width.
9598
c11821d4
EZ
95992011-08-26 Eli Zaretskii <eliz@gnu.org>
9600
9601 * xdisp.c (redisplay_window): Don't force window start if point
9602 will be invisible in the resulting window. (Bug#9324)
9603
0c95fcf7
EZ
96042011-08-25 Eli Zaretskii <eliz@gnu.org>
9605
9606 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
9607 the display spec is of the form `(space ...)'.
9608 (handle_display_spec): Return the value returned by
9609 handle_single_display_spec, not just 1 or zero.
9610 (handle_single_display_spec): If the display spec is of the form
9611 `(space ...)', and specifies display in the text area, return 2
9612 rather than 1.
fee65a97 9613 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
9614 accurately, and prefer exact match for point under bidi.
9615 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
9616
9617 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
9618 into disp_prop; all users changed.
9619
9620 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
9621 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
9622 for the text covered by the display property.
9623
e4ed06f1
CY
96242011-08-25 Chong Yidong <cyd@stupidchicken.com>
9625
9626 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
9627 Change return value to nil.
9628 (Frecord_buffer): Delete unused function.
9629
f67cdd7f
EZ
96302011-08-24 Eli Zaretskii <eliz@gnu.org>
9631
5980d4c6
EZ
9632 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
9633 buffers, return left-to-right.
8610fe8b
EZ
9634 (set_cursor_from_row): Consider candidate row a win if its glyph
9635 represents a newline and point is on that newline. Fixes cursor
9636 positioning on the newline at EOL of R2L text within L2R
9637 paragraph, and vice versa.
9638 (try_cursor_movement): Check continued rows, in addition to
9639 continuation rows. Fixes unwarranted scroll when point enters a
9640 continued line of R2L text within an L2R paragraph, or vice versa.
9641 (cursor_row_p): Consider the case of point being equal to
9642 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
9643 from the end of a short line to the beginning of a continued line
9644 of R2L text within L2R paragraph.
9645 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
9646 composed characters.
5980d4c6 9647
f67cdd7f
EZ
9648 * bidi.c (bidi_check_type): Use xassert.
9649 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
9650 members.
9651
bca633fb
EZ
96522011-08-23 Eli Zaretskii <eliz@gnu.org>
9653
9654 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
9655 a character.
9656
4a5885a7
CY
96572011-08-23 Chong Yidong <cyd@stupidchicken.com>
9658
9659 * nsfont.m (ns_otf_to_script): Fix typo.
9660
0902a04e
KH
96612011-08-22 Kenichi Handa <handa@m17n.org>
9662
9663 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
9664 extra slot even if the purpose is char-code-property-table.
9665
1a2e6670
EZ
96662011-08-23 Eli Zaretskii <eliz@gnu.org>
9667
8ddde651
EZ
9668 * xdisp.c (redisplay_window): When computing centering_position,
9669 account for the height of the header line. (Bug#8874)
9670
425cc014
EZ
9671 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
9672 instead of CHAR_TO_BYTE. Fixes a crash when a completion
9673 candidate is selected by the mouse, and that candidate has a
9674 composed character under the mouse.
9675
1a2e6670
EZ
9676 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
9677 coordinates reported by pos-visible-in-window-p for a composed
9678 character in column zero.
9679
8b76d6f8
SM
96802011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
9681
9682 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
9683
dac347dd
EZ
96842011-08-22 Eli Zaretskii <eliz@gnu.org>
9685
9686 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
9687 consider it a hit if to_charpos is anywhere in the range of the
9688 composed buffer positions.
9689
e013fb34
CY
96902011-08-22 Chong Yidong <cyd@stupidchicken.com>
9691
9692 * image.c (gif_load): Don't assume that each subimage has the same
9693 dimensions as the base image. Handle disposal method that is
9694 "undefined" by the gif spec (Bug#9335).
9695
bd1ba3e8
CY
96962011-08-20 Chong Yidong <cyd@stupidchicken.com>
9697
9698 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 9699 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 9700
54a1215b
EZ
97012011-08-19 Eli Zaretskii <eliz@gnu.org>
9702
823564e5
EZ
9703 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
9704 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
9705 from an Org mode buffer to a Speedbar frame.
9706
54a1215b
EZ
9707 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
9708 a composition, take its buffer position from IT->cmp_it.charpos.
9709 Fixes cursor positioning at the beginning of a line that begins
9710 with a composed character.
9711
9778ebcc
EZ
97122011-08-18 Eli Zaretskii <eliz@gnu.org>
9713
0be6ee06
EZ
9714 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
9715 character bidirectional type, use STRONG_L instead. Fixes crashes
9716 in a buffer produced by `describe-categories'.
9717
9778ebcc
EZ
9718 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
9719 members before the level stack, so they would be saved and
9720 restored when copying iterator state. Fixes incorrect reordering
9721 around TABs covered by display properties.
9722
156bffbe
AS
97232011-08-18 Andreas Schwab <schwab@linux-m68k.org>
9724
6b02f655 9725 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 9726
72ad093b
CY
97272011-08-17 Chong Yidong <cyd@stupidchicken.com>
9728
9729 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
9730 (internal_condition_case_2, internal_condition_case_n):
9731 Remove unnecessary aborts (Bug#9081).
72ad093b 9732
35774242
EZ
97332011-08-17 Eli Zaretskii <eliz@gnu.org>
9734
9735 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
9736 has no `load' handler, try opening the file locally. (Bug#9311)
9737
db76dd85
KB
97382011-08-16 Ken Brown <kbrown@cornell.edu>
9739
9740 * gmalloc.c: Expand comment.
9741
b215eee5
EZ
97422011-08-16 Eli Zaretskii <eliz@gnu.org>
9743
9744 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
9745 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
9746
a4579d33
KB
97472011-08-16 Ken Brown <kbrown@cornell.edu>
9748
9749 Fix memory allocation problems in Cygwin build (Bug#9273).
9750
9751 * unexcw.c ( __malloc_initialized): Declare external variable.
9752 (fixup_executable): Force the dumped emacs to reinitialize malloc.
9753
8b76d6f8
SM
9754 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
9755 New variables.
a4579d33
KB
9756 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
9757 dumped emacs.
9758 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
9759 in the static heap.
9760 [CYGWIN] (special_realloc): New function.
9761 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
9762 requests to realloc storage in the static heap.
9763
3ebec551
PE
97642011-08-15 Paul Eggert <eggert@cs.ucla.edu>
9765
9766 * bidi.c (bidi_initialize): Remove unused local.
9767
9fd8be00
EZ
97682011-08-15 Eli Zaretskii <eliz@gnu.org>
9769
6b02f655
SM
9770 * bidimirror.h:
9771 * biditype.h: Remove file.
9772 * makefile.w32-in ($(BLD)/bidi.$(O)):
9773 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
9774
9775 * dispextern.h: Fix a typo in the comment to bidi_type_t.
9776
9777 * chartab.c: Improve commentary for the uniprop_table API.
9778
32413314
EZ
9779 * bidi.c (bidi_paragraph_init): Support zero value of
9780 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
9781 (bidi_initialize): Use uniprop_table instead of including
9782 biditype.h and bidimirror.h.
32413314 9783
9fd8be00
EZ
9784 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
9785 coordinates of the iterator when restoring from ppos_it.
9786 (Bug#9296)
9787
5cf2b69b
KH
97882011-08-14 Kenichi Handa <handa@m17n.org>
9789
9790 * process.c (create_process): Call setup_process_coding_systems
72ad093b 9791 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 9792
daf17d00
EZ
97932011-08-14 Eli Zaretskii <eliz@gnu.org>
9794
9795 * xdisp.c (move_it_in_display_line_to): Don't invoke
9796 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
9797 ppos_it. Fixes vertical cursor motion when line beginning is
9798 covered by an image. (Bug#9296)
9799
08e3161a
JD
98002011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9801
9802 * nsterm.h (ns_run_ascript): Declare.
9803 (NSAPP_DATA2_RUNASSCRIPT): Define.
9804
9805 * nsfns.m (as_script, as_result, as_status): New static variables.
9806 (ns_run_ascript): New function.
5e617bc2 9807 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9808 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9809 the event loop. Get status from as_status (Bug#7276).
9810
9811 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9812 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9813 the event loop (Bug#7276).
9814
a3720aa2
AS
98152011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9816
9817 * gnutls.c (QCgnutls_bootprop_priority)
9818 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9819 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9820 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9821 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9822 (QCgnutls_bootprop_verify_hostname_error)
9823 (QCgnutls_bootprop_callbacks_verify): Rename from
9824 Qgnutls_bootprop_..., all uses changed.
9825
9826 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9827 uses changed.
9828
0a0d27fb
PE
98292011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9830
19d5c50c
PE
9831 * xfaces.c (Qframe_set_background_mode): Now static.
9832 * dispextern.h (Qframe_set_background_mode): Remove decl.
9833
0a0d27fb
PE
9834 * process.c (Fnetwork_interface_info): Declare local only if needed.
9835
377538cb
JD
98362011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9837
9838 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9839 (Fnetwork_interface_list): Allocate in increments of bytes instead
9840 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9841 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9842 sockaddr.
9843 (struct ifflag_def): notrailers is smart on OSX.
9844 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9845 Get hardware address with getifaddrs if available.
9846
08fff70c
EZ
98472011-08-12 Eli Zaretskii <eliz@gnu.org>
9848
9849 * xdisp.c (iterate_out_of_display_property): xassert that
9850 IT->position is set to within IT->object's boundaries. Break from
9851 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9852 when IT->position is set up wrongly due to some bug.
9853 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9854 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9855 entry. Force push_it to save on the stack the current
9856 buffer/string position, to be restored by pop_it. Fix flags in
9857 the iterator structure wrt the object coming from a display
9858 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9859 properties. (Bug#9284)
9860
7be1c708 98612011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9862
7be1c708
CY
9863 * fontset.c (fontset_get_font_group): Add proper type checks.
9864 (Bug#9172)
aac0c6e3 9865
7be1c708 98662011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9867
7be1c708
CY
9868 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9869 and LC_VERSION_MIN_MACOSX.
9870 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9871 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9872
97bb72a6
EZ
98732011-08-08 Eli Zaretskii <eliz@gnu.org>
9874
9875 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9876 no-display-properties-and-no-overlays under bidi display.
9877 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9878 properties and overlays.
97bb72a6 9879
d5617611
CY
98802011-08-08 Chong Yidong <cyd@stupidchicken.com>
9881
37e11a63
CY
9882 * editfns.c (Fset_time_zone_rule): Document relationship with the
9883 setenv function.
9884
d5617611
CY
9885 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9886 the font entity extracted from the cache (Bug#8109).
9887
58872834
CY
98882011-08-07 Chong Yidong <cyd@stupidchicken.com>
9889
9890 * composite.c (autocmp_chars): Don't reset point. That is done by
9891 restore_point_unwind (Bug#5984).
9892
75bfc667
JL
98932011-08-07 Juri Linkov <juri@jurta.org>
9894
9895 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9896 to show the arg `TIME' instead of `TIMEVAL'.
9897
d1410150
EZ
98982011-08-06 Eli Zaretskii <eliz@gnu.org>
9899
9900 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9901 display property strides EOL and includes a newline, as in
9902 longlines-mode. (Bug#9254)
75b771e4
EZ
9903 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9904 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9905
9906 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9907 is non-zero, even if the data buffer is NULL. Fixes a crash in
9908 vertical-motion with longlines-mode. (Bug#9254)
9909
35928349
EZ
99102011-08-05 Eli Zaretskii <eliz@gnu.org>
9911
ec7cc85b
EZ
9912 * bidi.c <bidi_cache_total_alloc>: Now static.
9913 (bidi_initialize): Initialize bidi_cache_total_alloc.
9914
8b76d6f8 9915 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9916 cache. (Bug#9221)
9917
9918 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9919 amount allocated this far in `bidi_cache_total_alloc'.
9920 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9921 non-zero, only free the data buffer without restoring the cache
9922 contents. All callers changed.
9923
9924 * dispextern.h (bidi_unshelve_cache): Update prototype.
9925
9926 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9927 (move_it_in_display_line, move_it_to)
9928 (move_it_vertically_backward, move_it_by_lines): Replace the call
9929 to xfree to an equivalent call to bidi_unshelve_cache.
9930 (move_it_in_display_line_to): Fix logic of returning
412b6358 9931 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9932
e2e2423b
EZ
99332011-08-05 Eli Zaretskii <eliz@gnu.org>
9934
9935 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9936 came from a string character with a `cursor' property. (Bug#9229)
9937
ae9e757a
JD
99382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9939
9940 * Makefile.in (LIB_PTHREAD): New variable.
9941 (LIBES): Add LIB_PTHREAD (Bug#9216).
9942
9943 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9944 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9945
213bd7f2
AS
99462011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9947
6b02f655 9948 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9949
99aaf75f
JD
99502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9951
9952 * xterm.c (x_find_topmost_parent): New function.
9953 (x_set_frame_alpha): Find topmost parent window with
9954 x_find_topmost_parent and set the property there also (bug#9181).
9955 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9956
c74e9d86
PE
99572011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9958
9959 * callproc.c (Fcall_process): Avoid vfork clobbering
9960 the local vars buffer, coding_systems, current_dir.
9961
640c8776
SM
99622011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9963
9964 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9965
f26d0e4c
PE
99662011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9967
8a10d76c
PE
9968 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9969 so that it is not optimized away.
9970
f26d0e4c
PE
9971 * xdisp.c (compute_display_string_pos): Remove unused local.
9972
55439c61
EZ
99732011-08-02 Eli Zaretskii <eliz@gnu.org>
9974
9975 Fix slow cursor motion and scrolling in large buffers with
9976 selective display, like Org Mode buffers. (Bug#9218)
9977
9978 * dispextern.h (struct bidi_it): New member disp_prop_p.
9979
9980 * xdisp.c: Remove one-slot cache of display string positions.
9981 (compute_display_string_pos): Accept an additional argument
5e617bc2 9982 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9983 for a display string or property. If found, set DISP_PROP_P
9984 non-zero.
9985
9986 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9987 DISP_PROP_P, and pass it to compute_display_string_pos.
9988 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9989 non-zero. All callers of bidi_fetch_char changed.
9990
fb33fa43
SM
99912011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9992
9993 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9994
b099e063
DM
99952010-12-03 Don March <don@ohspite.net>
9996
9997 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9998 last character M-[char] is translated to ESC [char] (bug#7541).
9999
5cc7f7af
KH
100002011-08-02 Kenichi Handa <handa@m17n.org>
10001
d0fffa3f 10002 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
10003
10004 * chartab.c (uniprop_table): Make it non-static.
10005
525d5e6e
EZ
100062011-08-01 Eli Zaretskii <eliz@gnu.org>
10007
10008 * xdisp.c (forward_to_next_line_start): Accept additional argument
10009 BIDI_IT_PREV, and store into it the state of the bidi iterator had
10010 on the newline.
10011 (reseat_at_next_visible_line_start): Use the bidi iterator state
10012 returned by forward_to_next_line_start to restore the state of
10013 it->bidi_it after backing up to previous newline. (Bug#9212)
10014
31011111
AS
100152011-07-30 Andreas Schwab <schwab@linux-m68k.org>
10016
10017 * regex.c (re_comp): Protoize.
10018 (re_exec): Fix return type.
10019 (regexec): Fix type of `ret'. (Bug#9203)
10020
476371c4
PE
100212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10022
e5d76069
PE
10023 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
10024 This is needed if max-image-size is a floating-point number.
10025
9a79b20c
AS
100262011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10027
10028 * print.c (print_object): Print empty symbol as ##.
10029
10030 * lread.c (read1): Read ## as empty symbol.
10031
d8c2fa78
AA
100322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
10033
10034 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
10035 setting frame foreground color (Bug#9175).
10036 (x_set_background_color): Likewise.
10037
ffe57a7a
AA
10038 * nsmenu.m (-setText): Size tooltip dimensions precisely to
10039 contents (Bug#9176).
10040 (EmacsTooltip -init): Remove bezels and add shadows to
10041 tooltip windows.
10042
bf3492a5
AA
10043 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
10044 or scroll bar (Bug#8470).
10045
d55e9c53
AA
10046 * nsfont.m (nsfont_open): Remove assignment to voffset and
10047 unnecessary vars hshink, expand, hd, full_height, min_height.
10048 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
10049
10050 * nsterm.h (nsfont_info): Remove voffset field.
10051
d8c2fa78 100522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
10053
10054 Implement strike-through and overline on NextStep (Bug#8863).
10055
10056 * nsfont.m (nsfont_open): Use underline position provided by font,
10057 instead of hard-coded value of 2.
10058 (nsfont_draw): Call ns_draw_text_decoration instead.
10059
10060 * nsterm.h: Add declaration for ns_draw_text_decoration.
10061
10062 * nsterm.m (ns_draw_text_decoration): New function for drawing
10063 underline, overline, and strike-through.
10064 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
10065 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 10066 accommodate underlining, etc.
4843aac3 10067
4cc60b9b
EZ
100682011-07-28 Eli Zaretskii <eliz@gnu.org>
10069
bc7ece87
EZ
10070 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
10071 default.
4cc60b9b 10072
476371c4
PE
100732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10074
66606eea
PE
10075 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
10076 Without this fix, if a signal arrives just after memory fills up,
10077 'malloc' might be invoked reentrantly.
10078
476371c4
PE
10079 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
10080 In other words, assume that every image size is allowed, on non-X
10081 hosts. This assumption is probably wrong, but it lets Emacs compile.
10082
f3fcc40d
AS
100832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
10084
10085 * regex.c (re_iswctype): Convert return values to boolean.
10086
350c992f
EZ
100872011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
10088
10089 * xdisp.c (compute_display_string_pos): Don't use cached display
10090 string position if the buffer had its restriction changed.
10091 (Bug#9184)
10092
5266b4bb
PE
100932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
10094
10095 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10096
2573a837 100972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 10098
41f55ccd 10099 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 10100
39e378da
PE
10101 * bidi.c: Integer size and overflow fixes.
10102 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
10103 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
10104 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10105 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
10106 (bidi_find_other_level_edge):
10107 Use ptrdiff_t instead of EMACS_INT where either will do.
10108 This works better on 32-bit hosts configured --with-wide-int.
10109 (bidi_cache_ensure_space): Check for size-calculation overflow.
10110 Use % rather than repeated addition, for better worst-case speed.
10111 Don't set bidi_cache_size until after xrealloc returns, because it
10112 might not return.
10113 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
10114 (bidi_cache_ensure_space): Also check that the bidi cache size
10115 does not exceed that of the largest Lisp string or buffer. See Eli
10116 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 10117
5e927815
PE
10118 * alloc.c (__malloc_size_t): Remove.
10119 All uses replaced by size_t. See Andreas Schwab's note
10120 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
10121
ca4aa935
PE
10122 * image.c: Improve checking for integer overflow.
10123 (check_image_size): Assume that f is nonnull, since
10124 it is always nonnull in practice. This is one less thing to
10125 worry about when checking for integer overflow later.
10126 (x_check_image_size): New function, which checks for integer
10127 overflow issues inside X.
10128 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
10129 This removes the need for a memory_full check.
10130 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
10131 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
10132 (xbm_read_bitmap_data): Change locals back to 'int', since
10133 their values must fit in 'int'.
10134 (xpm_load_image, png_load, tiff_load):
10135 Invoke x_create_x_image_and_pixmap earlier,
10136 to avoid much needless work if the image is too large.
10137 (tiff_load): Treat overly large images as if
10138 x_create_x_image_and_pixmap failed, not as malloc failures.
10139 (gs_load): Use x_check_image_size.
10140
5f8f9cc2
PE
10141 * gtkutil.c: Omit integer casts.
10142 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
10143 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
10144
5adf60bc
PE
10145 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
10146
c8907a93
PE
10147 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
10148 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
10149 would wrongly return t on a 64-bit host.
10150
e3c25c68
PE
10151 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
10152 The plain *_OVERFLOW macros run afoul of GCC bug 49705
10153 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
10154 and therefore cause GCC to emit a bogus diagnostic in some cases.
10155
3f791afe
PE
10156 * image.c: Integer signedness and overflow and related fixes.
10157 This is not an exhaustive set of fixes, but it's time to
10158 record what I've got.
10159 (lookup_pixel_color, check_image_size): Remove redundant decls.
10160 (check_image_size): Don't assume that arbitrary EMACS_INT values
10161 fit in 'int', or that arbitrary 'double' values fit in 'int'.
10162 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
10163 (tiff_load, imagemagick_load_image):
10164 Check for overflow in size calculations.
10165 (x_create_x_image_and_pixmap): Remove unnecessary test for
10166 xmalloc returning NULL; that can't happen.
10167 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
10168 (xpm_color_bucket): Use better integer hashing function.
10169 (xpm_cache_color): Don't possibly over-allocate memory.
10170 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
10171 (gif_memory_source):
10172 Use ptrdiff_t, not int or size_t, to record sizes.
10173 (png_load): Don't assume values greater than 2**31 fit in 'int'.
10174 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
10175 either works, as we prefer signed integers.
10176 (tiff_read_from_memory, tiff_write_from_memory):
10177 Return tsize_t, not size_t, since that's what the TIFF API wants.
10178 (tiff_read_from_memory): Don't fail simply because the read would
10179 go past EOF; instead, return a short read.
10180 (tiff_load): Omit no-longer-needed casts.
10181 (Fimagemagick_types): Don't assume size fits into 'int'.
10182
3cc5a532
PE
10183 Improve hashing quality when configured --with-wide-int.
10184 * fns.c (hash_string): New function, taken from sxhash_string.
10185 Do not discard information about ASCII character case; this
10186 discarding is no longer needed.
10187 (sxhash-string): Use it. Change sig to match it. Caller changed.
10188 * lisp.h: Declare it.
10189 * lread.c (hash_string): Remove, since we now use fns.c's version.
10190 The fns.c version returns a wider integer if --with-wide-int is
10191 specified, so this should help the quality of the hashing a bit.
10192
b312a492
PE
10193 * emacs.c: Integer overflow minor fix.
10194 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
10195 Define only if GNU_LINUX.
10196 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
10197
dfd153ae
PE
10198 * dispnew.c: Integer signedness and overflow fixes.
10199 Remove unnecessary forward decls, that were a maintenance hassle.
10200 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
10201 All uses changed.
10202 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
10203 (scrolling_window): Use ptrdiff_t, not int, for byte count.
10204 (prepare_desired_row, line_draw_cost):
10205 Use int, not unsigned, where either works.
10206 (save_current_matrix, restore_current_matrix):
10207 Use ptrdiff_t, not size_t, where either works.
10208 (init_display): Check for overflow more accurately, and without
10209 relying on undefined behavior.
10210
a81d11a3
PE
10211 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
10212 Remove, replacing with the new symbols in lisp.h. All uses changed.
10213 * fileio.c (make_temp_name):
10214 * filelock.c (lock_file_1, lock_file):
10215 * xdisp.c (message_dolog):
10216 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10217 Use pMd etc. instead.
10218 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
10219 replacing the pWIDE etc. symbols removed from editfns.c.
10220
3300e6fd
PE
10221 * keyboard.h (num_input_events): Now uintmax_t.
10222 This is (very slightly) less likely to mess up due to wraparound.
10223 All uses changed.
10224
fd05c7e9
PE
10225 * buffer.c: Integer signedness fixes.
10226 (alloc_buffer_text, enlarge_buffer_text):
10227 Use ptrdiff_t rather than size_t when either will do, as we prefer
10228 signed integers.
10229
903fe15d
PE
10230 * alloc.c: Integer signedness and overflow fixes.
10231 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
10232 (__malloc_size_t): Default to size_t, not to int.
10233 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
10234 (Fgarbage_collect, mark_object_loop_halt, mark_object):
10235 Prefer ptrdiff_t to size_t when either would do, as we prefer
10236 signed integers.
10237 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
10238 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
10239 Now const. Initialize with values that are in range even if char
10240 is signed.
10241 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
10242 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
10243 These functions do the right thing with sizes > 2**32.
10244 (check_depth): Now ptrdiff_t, not int.
10245 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
10246 Adjust to new way of storing sizes. Check for size overflow bugs
10247 in rest of code.
10248 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
10249 slightly wrong anyway, as it missed one instance of
10250 XMALLOC_OVERRUN_CHECK_OVERHEAD.
10251 (refill_memory_reserve): Omit needless cast to size_t.
10252 (mark_object_loop_halt): Mark as externally visible.
10253
ac82cc6a
PE
10254 * xselect.c: Integer signedness and overflow fixes.
10255 (Fx_register_dnd_atom, x_handle_dnd_message):
10256 Use ptrdiff_t, not size_t, since we prefer signed.
10257 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
10258 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
10259 x_dnd_atoms_size and x_dnd_atoms_length.
10260
c2d1e36d
PE
10261 * doprnt.c: Prefer signed to unsigned when either works.
10262 * eval.c (verror):
10263 * doprnt.c (doprnt):
10264 * lisp.h (doprnt):
10265 * xdisp.c (vmessage):
10266 Use ptrdiff_t, not size_t, when using or implementing doprnt,
10267 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
10268 prefer signed arithmetic to avoid comparison confusion.
10269 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
10270 but is a bit tricky.
10271
0e926e56
PE
10272 Assume freestanding C89 headers, string.h, stdlib.h.
10273 * data.c, doprnt.c, floatfns.c, print.c:
10274 Include float.h unconditionally.
10275 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
10276 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
10277 * regex.c: Likewise for stddef.h, string.h.
10278 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
10279 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
10280 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
10281 (STDC_HEADERS): Remove obsolete defines.
10282 * sysdep.c: Include limits.h unconditionally.
10283
9cfdb3ec
PE
10284 Assume support for memcmp, memcpy, memmove, memset.
10285 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
10286 * regex.c (memcmp, memcpy):
10287 Remove; we assume C89 now.
10288
10289 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
10290 (__malloc_safe_bcopy): Remove; no longer needed.
10291
cf950e6b 10292 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
10293 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
10294 well either way, and we prefer signed to unsigned.
10295
dbf38e02
LMI
102962011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
10297
10298 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
10299 closes the connection while we're reading (bug#9182).
10300
d6f0886c 103012011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 10302
d6f0886c
JD
10303 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
10304 are specified (Bug#9168).
24e0f6b1 10305
2eb1f9e6
PE
103062011-07-25 Paul Eggert <eggert@cs.ucla.edu>
10307
10308 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
10309 Found by GCC static checking and --with-wide-int on a 32-bit host.
10310
22381272 103112011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
10312
10313 * xdisp.c (compute_display_string_pos): Fix logic of caching
10314 previous display string position. Initialize cached_prev_pos to
10315 -1. Fixes slow-down at the beginning of a buffer.
10316
f25e39b4
EZ
103172011-07-24 Eli Zaretskii <eliz@gnu.org>
10318
10319 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
10320 for attrs[LFACE_FONTSET_INDEX].
10321
04c4b52e
PE
103222011-07-23 Paul Eggert <eggert@cs.ucla.edu>
10323
10324 * xml.c (parse_region): Remove unused local
10325 that was recently introduced.
10326
c1734fbd
EZ
103272011-07-23 Eli Zaretskii <eliz@gnu.org>
10328
be18c5a5
EZ
10329 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
10330 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
10331
c1734fbd
EZ
10332 * xdisp.c (move_it_in_display_line_to): Record the best matching
10333 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
10334 exit if none of the characters scanned was an exact match.
10335 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
10336 when exact match is impossible due to invisible text, and the
10337 lines are truncated.
10338
a258d627
JD
103392011-07-23 Jan Djärv <jan.h.d@swipnet.se>
10340
10341 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
10342 for OSX >= 10.7.
10343
b6d5a689
EZ
103442011-07-22 Eli Zaretskii <eliz@gnu.org>
10345
0f74f785
EZ
10346 Fix a significant slow-down of cursor motion with C-n, C-p,
10347 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
10348 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 10349 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
10350 (next_element_from_buffer): Call compute_stop_pos_backwards to
10351 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
10352 base_level_stop.
10353 (reseat): Don't look for prev_stop, as that could mean a very long
10354 run.
10355 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
10356 <cached_disp_overlay_modiff>: Cache for last found display string
10357 position.
551918c1 10358 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
10359 about the same buffer in the same area of character positions, and
10360 the buffer wasn't changed since the time the display string
10361 position was cached.
551918c1 10362
b2d0c91a
EZ
103632011-07-22 Eli Zaretskii <eliz@gnu.org>
10364
10365 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
10366 is an integer, which is important for empty lines. (Bug#9149)
10367
043604ee
CY
103682011-07-22 Chong Yidong <cyd@stupidchicken.com>
10369
10370 * frame.c (Fmodify_frame_parameters): In tty case, update the
10371 default face if necessary (Bug#4238).
10372
da4adb04
CY
103732011-07-21 Chong Yidong <cyd@stupidchicken.com>
10374
10375 * editfns.c (Fstring_to_char): No need to explain what a character
10376 is in the docstring (Bug#6576).
10377
9abd0532
LMI
103782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10379
10380 * xml.c (parse_region): Make sure we always return a tree.
10381
36881d16
HK
103822011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
10383
10384 * xml.c (parse_region): If a document contains only comments,
10385 return that, too.
10386
1e98674d
LMI
103872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
10388
10389 * xml.c (make_dom): Return comments, too.
10390
590bd467
PE
103912011-07-19 Paul Eggert <eggert@cs.ucla.edu>
10392
10393 Port to OpenBSD.
10394 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
10395 and the surrounding thread.
10396 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
10397 rather than fgets, and retry after EINTR. Otherwise, 'emacs
10398 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
10399 timer goes off.
10400 * s/openbsd.h (BROKEN_SIGIO): Define.
10401 * unexelf.c (unexec) [__OpenBSD__]:
10402 Don't update the .mdebug section of the Alpha COFF symbol table.
10403
f41628b2
LMI
104042011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10405
10406 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
10407 (bug#8460).
10408
b59b67c5
PE
104092011-07-18 Paul Eggert <eggert@cs.ucla.edu>
10410
15e3a074
PE
10411 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
10412 This fixes some race conditions on the permissions of any newly
10413 created file.
10414
41bed37d
PE
10415 * alloc.c (valid_pointer_p): Use pipe, not open.
10416 This fixes some permissions issues when debugging.
10417
b59b67c5
PE
10418 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
10419 If fchown fails to set both uid and gid, try to set just gid,
10420 as that is sometimes allowed. Adjust the file's mode to eliminate
10421 setuid or setgid bits that are inappropriate if fchown fails.
10422
925a6be7
SM
104232011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
10424
10425 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
10426 to compare Lisp_Objects.
10427 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
10428 global_gnutls_log_level, don't mistake it for a Lisp_Object.
10429 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
10430
52968808
AS
104312011-07-17 Andreas Schwab <schwab@linux-m68k.org>
10432
0a6a104b
AS
10433 * lread.c (read_integer): Unread even EOF character.
10434 (read1): Likewise. Properly record start position of symbol.
10435
52968808
AS
10436 * lread.c (read1): Read `#:' as empty uninterned symbol if no
10437 symbol character follows.
10438
9e381cdd
PE
104392011-07-17 Paul Eggert <eggert@cs.ucla.edu>
10440
10441 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
10442 This works around a problem with the previous change to Fcopy_file.
10443 Recent glibc declares fchown with __attribute__((warn_unused_result)),
10444 and without this change, GCC might complain about discarding
10445 fchown's return value.
10446
b5641435
JB
104472011-07-16 Juanma Barranquero <lekktu@gmail.com>
10448
10449 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
10450
a8031457
PE
104512011-07-16 Paul Eggert <eggert@cs.ucla.edu>
10452
10453 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
10454
dd889327
LMI
104552011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
10456
750c33f7
LMI
10457 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
10458 it's used from the C level.
10459
dd889327
LMI
10460 * process.c: Use the same condition for POLL_FOR_INPUT in both
10461 keyboard.c and process.c (bug#1858).
10462
87e86684
LM
104632011-07-09 Lawrence Mitchell <wence@gmx.li>
10464
10465 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
10466 (Fgnutls_boot): Use it.
10467
64348f40
AS
104682011-07-15 Andreas Schwab <schwab@linux-m68k.org>
10469
10470 * doc.c (Fsubstitute_command_keys): Revert last change.
10471
1d698799
LMI
104722011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
10473
f863868c
LMI
10474 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
10475 quotes the next character, and doesn't affect other longer
10476 sequences (bug#8935).
10477
1d698799
LMI
10478 * lread.c (syms_of_lread): Clarify that is isn't only
10479 `eval-buffer' and `eval-defun' that's affected by
10480 `lexical-binding' (bug#8460).
10481
aa4b6df6
EZ
104822011-07-15 Eli Zaretskii <eliz@gnu.org>
10483
10484 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 10485 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 10486
5d856da6
PE
104872011-07-14 Paul Eggert <eggert@cs.ucla.edu>
10488
ad6042bb
PE
10489 Fix minor problems found by static checking.
10490 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
10491 (elsz): Now a signed constant, not a size_t var. We prefer signed
10492 types to unsigned, to avoid integer comparison confusion. Without
10493 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
10494 "cannot optimize loop, the loop counter may overflow", a symptom
10495 of the confusion.
f00bbb22 10496 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
10497 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
10498
6468f31c
LMI
104992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10500
49080b10
LMI
10501 * search.c (Fre_search_backward): Mention `case-fold-search' in
10502 all the re_search_* functions (bug#8138).
10503
6468f31c
LMI
10504 * keyboard.c (Fopen_dribble_file): Document when the file is
10505 closed (bug#8056).
10506
c965adc5
EZ
105072011-07-14 Eli Zaretskii <eliz@gnu.org>
10508
df9733bf
EZ
10509 * bidi.c (bidi_dump_cached_states): Fix format of displaying
10510 bidi_cache_idx.
10511
0bb23927
EZ
10512 Support bidi reordering of display and overlay strings.
10513 * xdisp.c (compute_display_string_pos)
10514 (compute_display_string_end): Accept additional argument STRING.
10515 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
10516 (reseat_to_string): Initialize bidi_it->string.s and
10517 bidi_it->string.schars.
10518 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
10519 NULL (avoids a crash in bidi_paragraph_init).
10520 Initialize itb.string.lstring.
0bb23927
EZ
10521 (init_iterator): Call bidi_init_it only of a valid
10522 buffer position was specified. Initialize paragraph_embedding to
10523 L2R.
10524 (reseat_to_string): Initialize the bidi iterator.
10525 (display_string): If we need to ignore text properties of
10526 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
10527 original value of -1 will not work with bidi.)
10528 (compute_display_string_pos): First arg is now struct
10529 `text_pos *'; all callers changed. Support display properties on
10530 Lisp strings.
10531 (compute_display_string_end): Support display properties on Lisp
10532 strings.
10533 (init_iterator, reseat_1, reseat_to_string): Initialize the
10534 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
10535 when iterating on a string not from display properties).
640c8776
SM
10536 (compute_display_string_pos, compute_display_string_end):
10537 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
10538 arrow keys.
10539 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
10540 base_level_stop; instead, set base_level_stop to BEGV.
10541 Fixes crashes in vertical-motion.
0bb23927
EZ
10542 (next_element_from_buffer): Improve commentary for when
10543 the iterator is before prev_stop.
10544 (init_iterator): Initialize bidi_p from the default value of
10545 bidi-display-reordering, not from buffer-local value. Use the
10546 buffer-local value only if initializing for buffer iteration.
10547 (handle_invisible_prop): Support invisible properties on strings
10548 that are being bidi-reordered.
10549 (set_iterator_to_next): Support bidi reordering of C strings and
10550 Lisp strings.
10551 (next_element_from_string): Support bidi reordering of Lisp
10552 strings.
10553 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
10554 (display_string): Support display of R2L glyph rows.
10555 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
10556 (init_iterator): Don't initialize it->bidi_p for strings
10557 here.
10558 (reseat_to_string): Initialize it->bidi_p for strings here.
10559 (next_element_from_string, next_element_from_c_string)
10560 (next_element_from_buffer): Add xassert's for correspondence
10561 between IT's object being iterated and it->bidi_it.string
10562 structure.
10563 (face_before_or_after_it_pos): Support bidi iteration.
10564 (next_element_from_c_string): Handle the case of the first string
10565 character that is not the first one in the visual order.
10566 (get_visually_first_element): New function, refactored from common
10567 parts of next_element_from_buffer, next_element_from_string, and
10568 next_element_from_c_string.
10569 (tool_bar_lines_needed, redisplay_tool_bar)
10570 (display_menu_bar): Force left-to-right direction. Add a FIXME
10571 comment for making that be controlled by a user option.
10572 (push_it, pop_it): Save and restore the state of the
10573 bidi iterator. Save and restore the bidi_p flag.
10574 (pop_it): Iterate out of display property for string iteration as
10575 well.
10576 (iterate_out_of_display_property): Support iteration over strings.
10577 (handle_single_display_spec): Set up it->bidi_it for iteration
10578 over a display string, and call bidi_init_it.
10579 (handle_single_display_spec, next_overlay_string)
10580 (get_overlay_strings_1, push_display_prop): Set up the bidi
10581 iterator for displaying display or overlay strings.
10582 (forward_to_next_line_start): Don't use the shortcut if
10583 bidi-iterating.
10584 (back_to_previous_visible_line_start): If handle_display_prop
10585 pushed the iterator stack, restore the internal state of the bidi
10586 iterator by calling bidi_pop_it same number of times.
10587 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
10588 and we are bidi-iterating, don't decrement the iterator position;
10589 instead, set the first_elt flag in the bidi iterator, to produce
10590 the same effect.
10591 (reseat_1): Remove redundant setting of string_from_display_prop_p.
10592 (push_display_prop): xassert that we are iterating a buffer.
10593 (push_it, pop_it): Save and restore paragraph_embedding member.
10594 (handle_single_display_spec, next_overlay_string)
10595 (get_overlay_strings_1, reseat_1, reseat_to_string)
10596 (push_display_prop): Set up the `unibyte' member of bidi_it.string
10597 correctly. Don't assume unibyte strings are not bidi-reordered.
10598 (compute_display_string_pos)
10599 (compute_display_string_end): Fix handling the case of C string.
10600 (push_it, pop_it): Save and restore from_disp_prop_p.
10601 (handle_single_display_spec, push_display_prop): Set the
10602 from_disp_prop_p flag.
10603 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
10604 (pop_it): Call iterate_out_of_display_property only if we are
10605 popping after iteration over a string that came from a display
10606 property. Fix a typo in popping stretch info. Add an assertion
10607 for verifying that the iterator position is in sync with the bidi
10608 iterator.
10609 (handle_single_display_spec, get_overlay_strings_1)
10610 (push_display_prop): Fix initialization of paragraph direction for
10611 string when that of the parent object is not yet determined.
10612 (reseat_1): Call bidi_init_it to resync the bidi
10613 iterator with IT's position. (Bug#7616)
10614 (find_row_edges): If ROW->start.pos gives position
10615 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
10616 (handle_stop, back_to_previous_visible_line_start, reseat_1):
10617 Reset the from_disp_prop_p flag.
10618 (SAVE_IT, RESTORE_IT): New macros.
10619 (pos_visible_p, face_before_or_after_it_pos)
10620 (back_to_previous_visible_line_start)
10621 (move_it_in_display_line_to, move_it_in_display_line)
10622 (move_it_to, move_it_vertically_backward, move_it_by_lines)
10623 (try_scrolling, redisplay_window, display_line): Use them when
10624 saving a temporary copy of the iterator and restoring it back.
10625 (back_to_previous_visible_line_start, reseat_1)
10626 (init_iterator): Empty the bidi cache "stack".
10627 (move_it_in_display_line_to): If iterator ended up at
10628 EOL, but we never saw any buffer positions smaller than
10629 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
10630 motion in bidi-reordered lines.
10631 (move_it_in_display_line_to): Record prev_method and prev_pos
10632 immediately before the call to set_iterator_to_next. Fixes cursor
10633 motion in bidi-reordered lines with stretch glyphs and strings
10634 displayed in margins. (Bug#8133) (Bug#8867)
10635 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
10636 TO_CHARPOS.
640c8776
SM
10637 (pos_visible_p): Support positions in bidi-reordered lines.
10638 Save and restore bidi cache.
0bb23927
EZ
10639
10640 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
10641 (bidi_paragraph_info): Delete unused struct.
10642 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
10643 (bidi_cache_start): New variable.
10644 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
10645 to zero.
10646 (bidi_cache_fetch_state, bidi_cache_search)
10647 (bidi_cache_find_level_change, bidi_cache_iterator_state)
10648 (bidi_cache_find, bidi_peek_at_next_level)
10649 (bidi_level_of_next_char, bidi_find_other_level_edge)
10650 (bidi_move_to_visually_next): Compare cache index with
10651 bidi_cache_start rather than with zero.
10652 (bidi_fetch_char): Accept new argument STRING; all callers
10653 changed. Support iteration over a string. Support strings with
10654 display properties. Support unibyte strings. Fix the type of
10655 `len' according to what STRING_CHAR_AND_LENGTH expects.
10656 (bidi_paragraph_init, bidi_resolve_explicit_1)
10657 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
10658 (bidi_level_of_next_char, bidi_move_to_visually_next):
10659 Support iteration over a string.
0bb23927
EZ
10660 (bidi_set_sor_type, bidi_resolve_explicit_1)
10661 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
10662 can now be zero (for strings); special values 0 and -1 were
10663 changed to -1 and -2, respectively.
10664 (bidi_char_at_pos): New function.
10665 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
10666 Call it instead of FETCH_MULTIBYTE_CHAR.
10667 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
10668 initialized to valid values.
10669 (bidi_init_it): Don't initialize charpos and bytepos with invalid
10670 values.
10671 (bidi_level_of_next_char): Allow the sentinel "position" to pass
10672 the test for valid cached positions. Fix the logic for looking up
10673 the sentinel state in the cache. GCPRO the Lisp string we are
10674 iterating.
10675 (bidi_push_it, bidi_pop_it): New functions.
10676 (bidi_initialize): Initialize the bidi cache start stack pointer.
10677 (bidi_cache_ensure_space): New function, refactored from part of
10678 bidi_cache_iterator_state. Don't assume the required size is just
10679 one BIDI_CACHE_CHUNK away.
10680 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
10681 (bidi_count_bytes, bidi_char_at_pos): New functions.
10682 (bidi_cache_search): Don't assume bidi_cache_last_idx is
10683 always valid if bidi_cache_idx is valid.
10684 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
10685 is valid if it's going to be used.
10686 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
10687 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
10688 (bidi_cache_find_level_change, bidi_cache_ensure_space)
10689 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
10690 (bidi_find_other_level_edge, bidi_cache_start_stack):
10691 All variables related to cache indices are now EMACS_INT.
c965adc5 10692
0bb23927
EZ
10693 * dispextern.h (struct bidi_string_data): New structure.
10694 (struct bidi_it): New member `string'. Make flag members be 1-bit
10695 fields, and put them last in the struct.
640c8776
SM
10696 (compute_display_string_pos, compute_display_string_end):
10697 Update prototypes.
0bb23927
EZ
10698 (bidi_push_it, bidi_pop_it): Add prototypes.
10699 (struct iterator_stack_entry): New members bidi_p,
10700 paragraph_embedding, and from_disp_prop_p.
10701 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
10702 (bidi_shelve_cache, bidi_unshelve_cache):
10703 Declare prototypes.
0bb23927
EZ
10704
10705 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
10706 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
10707 and vector-like objects.
10708
10709 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
10710 cache around display iteration.
10711
10712 * window.c (Fwindow_end, window_scroll_pixel_based)
10713 (displayed_window_lines, Frecenter): Save and restore the bidi
10714 cache around display iteration.
10715
3bbd2265
LMI
107162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
10717
10718 * editfns.c (Fdelete_region): Clarify the use of the named
10719 parameters (bug#6788).
10720
adc47434
MR
107212011-07-14 Martin Rudalics <rudalics@gmx.at>
10722
10723 * indent.c (Fvertical_motion): Set and restore w->pointm when
10724 saving and restoring the window's buffer (Bug#9006).
10725
837c31f8
LMI
107262011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
10727
10728 * editfns.c (Fstring_to_char): Clarify just what is returned
10729 (bug#6576). Text by Eli Zaretskii.
10730
ac389d0c
JB
107312011-07-13 Juanma Barranquero <lekktu@gmail.com>
10732
10733 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
10734
0be0ce47
EZ
107352011-07-13 Eli Zaretskii <eliz@gnu.org>
10736
10737 * buffer.c (mmap_find): Fix a typo.
10738
cd18e7e3
JB
107392011-07-13 Johan Bockgård <bojohan@gnu.org>
10740
10741 Fix execution of x selection hooks.
10742 * xselect.c (Qx_lost_selection_functions)
10743 (Qx_sent_selection_functions): New vars.
10744 (syms_of_xselect): DEFSYM them.
10745 (x_handle_selection_request): Pass Qx_sent_selection_functions
10746 rather than Vx_sent_selection_functions to Frun_hook_with_args.
10747 (x_handle_selection_clear,x_clear_frame_selections):
10748 Pass Qx_lost_selection_functions rather than
10749 Vx_lost_selection_functions to Frun_hook_with_args.
10750
47ea7f44
PE
107512011-07-13 Paul Eggert <eggert@cs.ucla.edu>
10752
ac389d0c 10753 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
10754 The old code sometimes used this field without initializing it.
10755
47ea7f44
PE
10756 * alloc.c (gc_sweep): Don't read past end of array.
10757 In theory, the old code could also have corrupted Emacs internals,
10758 though it'd be very unlikely.
10759
bc985c87
AS
107602011-07-12 Andreas Schwab <schwab@linux-m68k.org>
10761
10762 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 10763 argument. (Bug#4026)
bc985c87 10764
0cf34688
LMI
107652011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
10766
b3dadd76
LMI
10767 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
10768 key" (bug#4257).
10769
0cf34688
LMI
10770 * window.c (Fset_window_start): Doc fix (bug#4199).
10771 (Fset_window_hscroll): Ditto.
10772
270768cd
PE
107732011-07-12 Paul Eggert <eggert@cs.ucla.edu>
10774
077e3dda 10775 Fix minor new problems caught by GCC 4.6.1.
270768cd 10776 * term.c (init_tty): Remove unused local.
490011a6 10777 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 10778 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 10779 not used otherwise.
270768cd 10780
b1f58454
CY
107812011-07-12 Chong Yidong <cyd@stupidchicken.com>
10782
10783 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
10784
22b9578d
LMI
107852011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10786
6e70ab07
LMI
10787 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
10788 are the mini-buffer and the echo area (bug#3320).
10789
22b9578d
LMI
10790 * term.c (init_tty): Remove support for supdup, c10 and perq
10791 terminals, which are no longer supported (bug#1482).
10792
8974cc9f
JB
107932011-07-10 Johan Bockgård <bojohan@gnu.org>
10794
10795 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
10796
a560d974
JD
107972011-07-10 Jan Djärv <jan.h.d@swipnet.se>
10798
10799 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10800 for non-popups (Bug#3642).
10801
1dae0f0a
AS
108022011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10803
268c2c36 10804 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10805 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10806 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10807 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10808 * data.c (fmod): Likewise.
10809 * dispnew.c (swap_glyphs_in_rows): Likewise.
10810 * emacs.c (memory_warning_signal): Likewise.
10811 * floatfns.c (float_error): Likewise.
10812 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10813 (otf_open, font_otf_capability, generate_otf_features)
10814 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10815 Likewise.
10816 * image.c (pbm_read_file): Likewise.
10817 * indent.c (string_display_width): Likewise.
10818 * intervals.c (check_for_interval, search_for_interval)
10819 (inc_interval_count, count_intervals, root_interval)
10820 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10821 * lread.c (defalias): Likewise.
268c2c36 10822 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10823 * regex.c (set_image_of_range_1, set_image_of_range)
10824 (regex_grow_registers): Likewise.
10825 * sysdep.c (strerror): Likewise.
10826 * termcap.c (valid_filename_p, tprint, main): Likewise.
10827 * tparam.c (main): Likewise.
10828 * unexhp9k800.c (run_time_remap, save_data_space)
10829 (update_file_ptrs, read_header, write_header, calculate_checksum)
10830 (copy_file, copy_rest, display_header): Likewise.
10831 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10832 Likewise.
10833 * xdisp.c (check_it): Likewise.
10834 * xfaces.c (register_color, unregister_color, unregister_colors):
10835 Likewise.
10836 * xfns.c (print_fontset_result): Likewise.
10837 * xrdb.c (member, fatal, main): Likewise.
10838
99033785
PE
108392011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10840
10841 Fix minor problems found by static checking (Bug#9031).
10842 * chartab.c (char_table_set_range, map_sub_char_table):
10843 Remove unused locals.
10844 (uniprop_table): Now static.
10845 * composite.c (_work_char): Remove unused static var.
10846
9cb2ac56
JB
108472011-07-09 Juanma Barranquero <lekktu@gmail.com>
10848
10849 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10850
f25661f0
JD
108512011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10852
10853 * gtkutil.c (qttip_cb): Remove code without function.
10854
8278c4fe
EZ
108552011-07-09 Eli Zaretskii <eliz@gnu.org>
10856
10857 * w32.c (pthread_sigmask): New stub.
10858
1692ae2d 108592011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10860
8a6ebd58 10861 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10862 sigprocmask is portable only for single-threaded applications, and
10863 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10864 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10865 (LIBES): Use it.
10866 * callproc.c (Fcall_process):
10867 * process.c (create_process):
10868 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10869 Use pthread_sigmask, not sigprocmask.
123403e4 10870
1b854618
JD
108712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10872
10873 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10874 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10875 wrong (Bug#8591).
10876
3fe4b549
JD
108772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10878
0ce7e563
JD
10879 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10880 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10881 (xg_hide_tooltip): Fix comment.
10882
3fe4b549
JD
10883 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10884 in registerServicesMenuSendTypes.
10885 (validRequestorForSendType): Don't check ns_return_types.
10886
10887 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10888 ns_return_type.
10889
5df75e47
JR
108902011-07-08 Jason Rumney <jasonr@gnu.org>
10891
22610910
JR
10892 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10893 SH_SHOW for hidden windows (Bug#5482).
10894
5df75e47
JR
10895 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10896 frame struct members of non-existent frames (Bug#6284).
10897
699c10bd
JD
108982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10899
4393663b
JD
10900 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10901 variable firstTime not needed on OSX >= 10.6.
10902 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10903 >= 10.5. Use setKnobProportion, setDoubleValue.
10904
10905 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10906 (MAC_OS_X_VERSION_10_5): Define if not defined.
10907 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10908 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10909 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10910
10911 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10912 cString and lossyCString on OSX >= 10.4.
4393663b 10913
58179cce 10914 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10915 sizeToFit on OSX >= 10.2.
10916
10917 * nsimage.m (allocInitFromFile): Don't use deprecated method
10918 bestRepresentationForDevice on OSX >= 10.6.
10919
10920 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10921 to avoid warning.
10922
10923 * emacs.c: Declare unexec_init_emacs_zone.
10924
a63e0781
JD
10925 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10926
699c10bd
JD
10927 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10928
10929 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10930 on svcsMenu (Bug#8842).
10931
10932 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10933 ns_return_types.
10934 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10935
10936 * nsterm.m (QUTF8_STRING): Declare.
10937 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10938 (validRequestorForSendType): Return type is (id).
10939 Change indexOfObjectIdenticalTo to indexOfObject.
10940 Check if we have local selection before returning self (Bug#8842).
10941 (writeSelectionToPasteboard): Put local selection into paste board
10942 if we have a local selection (Bug#8842).
10943 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10944
10945 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10946 (ns_get_local_selection): Declare.
10947
54e10184
LMI
109482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10949
9888ff71
LMI
10950 * keymap.c (describe_map_tree): Don't insert a double newline at
10951 the end of the buffer (bug#1169) and return whether we inserted
10952 something.
10953
54e10184
LMI
10954 * callint.c (Fcall_interactively): Change "reading args" to
10955 "providing args" to try to clarify what it does (bug#1010).
10956
15fa4783
KH
109572011-07-07 Kenichi Handa <handa@m17n.org>
10958
10959 * composite.c (composition_compute_stop_pos): Ignore a static
10960 composition starting before CHARPOS (Bug#8915).
10961
10962 * xdisp.c (handle_composition_prop): Likewise.
10963
a8815b00
EZ
109642011-07-07 Eli Zaretskii <eliz@gnu.org>
10965
10966 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10967 (Bug#9015)
10968
ef7b981d 109692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10970
10971 * character.h (unicode_category_t): New enum type.
10972
10973 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10974 (Qchar_code_property_table): New variable.
10975 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10976 (UNIPROP_COMPRESSED_FORM_P): New macros.
10977 (char_table_ascii): Uncompress the compressed values.
10978 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10979 Uncompress the compressed values.
ac389d0c 10980 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10981 (char_table_ref_and_range): Uncompress the compressed values.
10982 (sub_char_table_set): New arg is_uniprop. Callers changed.
10983 Uncompress the compressed values.
10984 (sub_char_table_set_range): Args changed. Callers changed.
10985 (char_table_set_range): Adjuted for the above change.
10986 (map_sub_char_table): Delete args default_val and parent. Add arg
10987 top. Give decoded values to a Lisp function.
640c8776 10988 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10989 values to a Lisp function. Gcpro more variables.
10990 (uniprop_table_uncompress)
10991 (uniprop_decode_value_run_length): New functions.
10992 (uniprop_decoder, uniprop_decoder_count): New variables.
10993 (uniprop_get_decoder, uniprop_encode_value_character)
10994 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10995 New functions.
10996 (uniprop_encoder, uniprop_encoder_count): New variables.
10997 (uniprop_get_encoder, uniprop_table)
10998 (Funicode_property_table_internal, Fget_unicode_property_internal)
10999 (Fput_unicode_property_internal): New functions.
11000 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
11001 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 11002 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
11003 char-code-property-alist.
11004
640c8776 11005 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
11006 Vunicode_category_table.
11007
640c8776 11008 * font.c (font_range): Adjust for the change of
c805dec0
KH
11009 Vunicode_category_table.
11010
76b397fb
DN
110112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
11012
11013 * m/iris4d.h: Remove file, move contents ...
11014 * s/irix6-5.h: ... here.
11015
22b4128e
PE
110162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
11017
11018 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
11019 * alloc.c (mark_buffer):
11020 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
11021 (clone_per_buffer_values): Don't assume that
22b4128e
PE
11022 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
11023 This isn't true in general, and it's particularly not true
11024 if Emacs is configured with --with-wide-int.
11025 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
11026 New macros, used in the buffer.c change.
11027
869795d6
JD
110282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
11029
11030 * xsettings.c: Use both GConf and GSettings if both are available.
11031 (store_config_changed_event): Add comment.
11032 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
11033 (store_tool_bar_style_changed): New functions.
5e617bc2 11034 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
11035 (struct xsettings): Move font inside HAVE_XFT.
11036 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 11037 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 11038 Move inside HAVE_XFT.
640c8776 11039 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
11040 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
11041 also.
11042 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 11043 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 11044 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
11045 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
11046 (parse_settings): Move check for font inside HAVE_XFT.
11047 (read_settings, apply_xft_settings): Add comment.
11048 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
11049 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
11050 call store_font_name_changed.
11051 (xft_settings_event): Add comment.
11052 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
11053 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
11054 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
11055 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
11056 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
11057 (xsettings_get_system_font, xsettings_get_system_normal_font):
11058 Add comment.
869795d6 11059
d8ed26bd
PE
110602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
11061
11062 Random fixes. E.g., (random) never returned negative values.
11063 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
11064 subseconds part to the entropy, as that's a bit more random.
11065 Prefer signed to unsigned, since the signedness doesn't matter and
11066 in general we prefer signed. When given a limit, use a
11067 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
11068 latter isn't right if USE_2_TAGS_FOR_INTS.
11069 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
11070 not 0..VALMASK. Don't discard "excess" bits that random () returns.
11071
cabf1cac
SM
110722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
11073
11074 * textprop.c (text_property_stickiness):
11075 Obey Vtext_property_default_nonsticky.
11076 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
11077 * w32fns.c (syms_of_w32fns):
11078 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
11079
6e9b2be9
PE
110802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11081
11082 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
11083 This is more efficient than Ffile_directory_p and avoids a minor race.
11084
90186c68
LMI
110852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
11086
7c301272
LMI
11087 * buffer.c (Foverlay_put): Say what the return value is
11088 (bug#7835).
11089
c4f2d8d4
LMI
11090 * fileio.c (barf_or_query_if_file_exists): Check first if the file
11091 is a directory before asking whether to use the file name
11092 (bug#7564).
ad637907
LMI
11093 (barf_or_query_if_file_exists): Make the "File is a directory"
11094 error be more correct.
c4f2d8d4 11095
90186c68
LMI
11096 * fns.c (Frequire): Remove the mention of the .gz files, since
11097 that's installation-specific, but keep the mention of
11098 `get-load-suffixes'.
11099
da64016e
PE
111002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
11101
11102 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
11103 Report string overflow if the output is too long.
11104
7d47b580
JB
111052011-07-04 Juanma Barranquero <lekktu@gmail.com>
11106
a555cb87
JB
11107 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
11108 (syms_of_gnutls): Remove duplicate DEFSYM for
11109 Qgnutls_bootprop_verify_hostname_error, an error for
11110 Qgnutls_bootprop_verify_error (which is no longer used).
11111
7d47b580
JB
11112 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
11113 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
11114 Also (re)move comments that are misplaced or no longer relevant.
11115
1e49bfab
LMI
111162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11117
11118 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
11119
1485f4c0
CY
111202011-07-03 Chong Yidong <cyd@stupidchicken.com>
11121
11122 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
11123 and background color parameters if they have been changed.
11124
a9ab721e
LMI
111252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
11126
11127 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
11128
cf7cff57
PE
111292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
11130
2e13213d
PE
11131 * xsettings.c (SYSTEM_FONT): Define only when used.
11132 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
11133
cf7cff57
PE
11134 * keymap.c (access_keymap_1): Now static.
11135
7a8e04f7
CY
111362011-07-02 Chong Yidong <cyd@stupidchicken.com>
11137
11138 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
11139 leave any prefix arg for the up event (Bug#1586).
11140
61352f62
LMI
111412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11142
69bb1ef7
LMI
11143 * lread.c (syms_of_lread): Mention single symbols defined by
11144 `defvar' or `defconst' (bug#7154).
11145
61352f62 11146 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 11147 (Frequire): Mention get-load-suffixes.
61352f62 11148
28545e04
MR
111492011-07-02 Martin Rudalics <rudalics@gmx.at>
11150
11151 * window.h (window): Remove clone_number slot.
11152 * window.c (Fwindow_clone_number, Fset_window_clone_number):
11153 Remove.
11154 (make_parent_window, make_window, saved_window)
11155 (Fset_window_configuration, save_window_save): Don't deal with
11156 clone numbers.
11157 * buffer.c (Qclone_number): Remove declaration.
11158 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11159
3349e122
SM
111602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
11161
11162 Add multiple inheritance to keymaps.
11163 * keymap.c (Fmake_composed_keymap): New function.
11164 (Fset_keymap_parent): Simplify.
11165 (fix_submap_inheritance): Remove.
11166 (access_keymap_1): New function extracted from access_keymap to handle
11167 embedded parents and handle lists of maps.
11168 (access_keymap): Use it.
11169 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
11170 (Fcopy_keymap): Handle embedded parents.
11171 (Fcommand_remapping, define_as_prefix): Simplify.
11172 (Fkey_binding): Simplify.
11173 (syms_of_keymap): Move minibuffer-local-completion-map,
11174 minibuffer-local-filename-completion-map,
11175 minibuffer-local-must-match-map, and
11176 minibuffer-local-filename-must-match-map to Elisp.
11177 (syms_of_keymap): Defsubr make-composed-keymap.
11178 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
11179 (parse_menu_item): Trivial simplification.
11180
3279eb87
GM
111812011-07-01 Glenn Morris <rgm@gnu.org>
11182
11183 * Makefile.in (SETTINGS_LIBS): Fix typo.
11184
39cb9e56 111852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
11186
11187 * coding.c (Fencode_coding_string): Record the last coding system
11188 used, as the function doc string says (bug#8738).
11189
0949d2b6
JD
111902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
11191
11192 * xsettings.c (store_monospaced_changed): Take new font as arg and
11193 check for change against current_mono_font.
11194 (EMACS_TYPE_SETTINGS): Remove this and related defines.
11195 (emacs_settings_constructor, emacs_settings_get_property)
11196 (emacs_settings_set_property, emacs_settings_class_init)
11197 (emacs_settings_init, gsettings_obj): Remove.
11198 (something_changedCB): New function for HAVE_GSETTINGS.
11199 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
11200 with value as argument.
11201 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
11202 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 11203 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
11204 "changed".
11205
11206 * xgselect.c: Add defined (HAVE_GSETTINGS).
11207 (xgselect_initialize): Ditto.
11208
11209 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
11210 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
11211 xg_select.
11212
bbc6b304
PE
112132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
11214
11215 * eval.c (struct backtrace): Simplify and port the data structure.
11216 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
11217 signed bit field, as this assumption is not portable and it makes
11218 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
11219 "char debug_on_exit : 1" as this is not portable either; instead,
11220 use the portable "unsigned int debug_on_exit : 1". Remove unused
11221 member evalargs. Remove obsolete comments about cc bombing out.
11222
9851bfc5
JD
112232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
11224
51bb811f 11225 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
11226 Let HAVE_GSETTINGS override HAVE_GCONF.
11227 (store_monospaced_changed): New function.
11228 (EMACS_SETTINGS): A new type derived from GObject to handle
11229 GSettings notifications.
11230 (emacs_settings_constructor, emacs_settings_get_property)
11231 (emacs_settings_set_property, emacs_settings_class_init):
11232 New functions.
11233 (gsettings_client, gsettings_obj): New variables.
11234 (GSETTINGS_SCHEMA): New define.
11235 (something_changedCB): Call store_monospaced_changed.
11236 (init_gsettings): New function.
11237 (xsettings_initialize): Call init_gsettings.
11238 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
11239 to NULL.
11240
640c8776 11241 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
11242 GCONF_CFLAGS/LIBS.
11243
5386012d
MR
112442011-06-29 Martin Rudalics <rudalics@gmx.at>
11245
11246 * window.c (resize_root_window, grow_mini_window)
11247 (shrink_mini_window): Rename Qresize_root_window to
11248 Qwindow_resize_root_window and Qresize_root_window_vertically to
11249 Qwindow_resize_root_window_vertically.
11250
f13e0b08
PE
112512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
11252
11253 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
11254
94515237
JB
112552011-06-27 Juanma Barranquero <lekktu@gmail.com>
11256
11257 * makefile.w32-in: Redesign dependencies so they reflect more
11258 clearly which files are directly included by each source file,
11259 and not through other includes.
11260
e43b6e43
MR
112612011-06-27 Martin Rudalics <rudalics@gmx.at>
11262
11263 * buffer.c (Qclone_number): Declare static and DEFSYM it.
11264 (sort_overlays, overlay_strings): When an overlay's clone number
11265 matches the window's clone number process the overlay even if
11266 the overlay's window property doesn't match the current window.
11267
d68443dc
MR
11268 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
11269 (Fwindow_hchild): Rename to Fwindow_left_child.
11270 (Fwindow_next): Rename to Fwindow_next_sibling.
11271 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
11272 (resize_window_check): Rename to window_resize_check.
11273 (resize_window_apply): Rename to window_resize_apply.
11274 (Fresize_window_apply): Rename to Fwindow_resize_apply.
11275 (Fdelete_other_windows_internal, resize_frame_windows)
11276 (Fsplit_window_internal, Fdelete_window_internal)
11277 (grow_mini_window, shrink_mini_window)
11278 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 11279
c7e73be5
JD
112802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
11281
11282 * emacsgtkfixed.h: State that this is only used with Gtk+3.
11283 (emacs_fixed_set_min_size): Remove.
11284 (emacs_fixed_new): Take frame as argument.
11285
11286 * emacsgtkfixed.c: State that this is only used with Gtk+3.
11287 (_EmacsFixedPrivate): Remove minwidth/height.
11288 Add struct frame *f.
11289 (emacs_fixed_init): Initialize priv->f.
11290 (get_parent_class, emacs_fixed_set_min_size): Remove.
11291 (emacs_fixed_new): Set priv->f to argument.
11292 (emacs_fixed_get_preferred_width)
11293 (emacs_fixed_get_preferred_height): Use min_width/height from
11294 frames size_hint to set minimum and natural (Bug#8919).
11295 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
11296 and use min_width/height from frames size_hint to set
11297 min_width/height (Bug#8919).
11298
11299 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
11300 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
11301 Fix indentation.
c7e73be5 11302
cf99dcf8
EZ
113032011-06-26 Eli Zaretskii <eliz@gnu.org>
11304
11305 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
11306 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
11307 called at ZV.
11308
029529ac
CY
113092011-06-26 Chong Yidong <cyd@stupidchicken.com>
11310
11311 * process.c (wait_reading_process_output): Bypass select if
11312 waiting for a cell while ignoring keyboard input, and input is
11313 pending. Suggested by Jan Djärv (Bug#8869).
11314
7a7ef429
PE
113152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
11316
11317 Use gnulib's dup2 module instead of rolling our own.
11318 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
11319
11fdef7d 113202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
11321
11322 * dispnew.c (scrolling_window): Before scrolling, turn off a
11323 mouse-highlight in the window being scrolled.
11324
cd3520a4
JB
113252011-06-24 Juanma Barranquero <lekktu@gmail.com>
11326
11327 Move DEFSYM to lisp.h and use everywhere.
11328
11329 * character.h (DEFSYM): Move declaration...
11330 * lisp.h (DEFSYM): ...here.
11331
11332 * gnutls.c:
11333 * minibuf.c:
11334 * w32menu.c:
11335 * w32proc.c:
11336 * w32select.c: Don't include character.h.
11337
11338 * alloc.c (syms_of_alloc):
11339 * buffer.c (syms_of_buffer):
11340 * bytecode.c (syms_of_bytecode):
11341 * callint.c (syms_of_callint):
11342 * casefiddle.c (syms_of_casefiddle):
11343 * casetab.c (init_casetab_once):
11344 * category.c (init_category_once, syms_of_category):
11345 * ccl.c (syms_of_ccl):
11346 * cmds.c (syms_of_cmds):
11347 * composite.c (syms_of_composite):
11348 * dbusbind.c (syms_of_dbusbind):
11349 * dired.c (syms_of_dired):
11350 * dispnew.c (syms_of_display):
11351 * doc.c (syms_of_doc):
11352 * editfns.c (syms_of_editfns):
11353 * emacs.c (syms_of_emacs):
11354 * eval.c (syms_of_eval):
11355 * fileio.c (syms_of_fileio):
11356 * fns.c (syms_of_fns):
11357 * frame.c (syms_of_frame):
11358 * fringe.c (syms_of_fringe):
11359 * insdel.c (syms_of_insdel):
11360 * keymap.c (syms_of_keymap):
11361 * lread.c (init_obarray, syms_of_lread):
11362 * macros.c (syms_of_macros):
11363 * msdos.c (syms_of_msdos):
11364 * print.c (syms_of_print):
11365 * process.c (syms_of_process):
11366 * search.c (syms_of_search):
11367 * sound.c (syms_of_sound):
11368 * syntax.c (init_syntax_once, syms_of_syntax):
11369 * terminal.c (syms_of_terminal):
11370 * textprop.c (syms_of_textprop):
11371 * undo.c (syms_of_undo):
11372 * w32.c (globals_of_w32):
11373 * window.c (syms_of_window):
11374 * xdisp.c (syms_of_xdisp):
11375 * xfaces.c (syms_of_xfaces):
11376 * xfns.c (syms_of_xfns):
11377 * xmenu.c (syms_of_xmenu):
11378 * xsettings.c (syms_of_xsettings):
11379 * xterm.c (syms_of_xterm): Use DEFSYM.
11380
4228cf16
TZ
113812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
11382
cd3520a4 11383 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 11384
7fcccf1e
PE
113852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
11386
7efb4e0e
PE
11387 Integer and buffer overflow fixes (Bug#8873).
11388
ff5844ad
PE
11389 * print.c (printchar, strout): Check for string overflow.
11390 (PRINTPREPARE, printchar, strout):
11391 Don't set size unless allocation succeeds.
11392
90532f02
PE
11393 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
11394 for sizes. Check for string overflow more accurately.
11395 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
11396
6d84508d
PE
11397 * macros.c: Integer and buffer overflow fixes.
11398 * keyboard.h (struct keyboard.kbd_macro_bufsize):
11399 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
11400 Use ptrdiff_t, not int, for sizes.
11401 Don't increment bufsize until after realloc succeeds.
11402 Check for size-calculation overflow.
11403 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
11404
437b2cb4
PE
11405 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
11406
8b9ac8b4
PE
11407 * lread.c: Integer overflow fixes.
11408 (read_integer): Radix is now EMACS_INT, not int,
11409 to improve quality of diagnostics for out-of-range radices.
11410 Calculate buffer size correctly for out-of-range radices.
11411 (read1): Check for integer overflow in radices, and in
11412 read-circle numbers.
82cb60d3
PE
11413 (read_escape): Avoid int overflow.
11414 (Fload, openp, read_buffer_size, read1)
11415 (substitute_object_recurse, read_vector, read_list, map_obarray):
11416 Use ptrdiff_t, not int, for sizes.
11417 (read1): Use EMACS_INT, not int, for sizes.
20270765 11418 Check for size overflow.
8b9ac8b4 11419
7fcccf1e
PE
11420 * image.c (cache_image): Check for size arithmetic overflow.
11421
bfbbd7e7
PE
11422 * lread.c: Integer overflow issues.
11423 (saved_doc_string_size, saved_doc_string_length)
11424 (prev_saved_doc_string_size, prev_saved_doc_string_length):
11425 Now ptrdiff_t, not int.
11426 (read1): Don't assume doc string length fits in int. Check for
11427 out-of-range doc string lengths.
11428 (read_list): Don't assume file position fits in int.
39019e54 11429 (read_escape): Check for hex character overflow.
bfbbd7e7 11430
4e323265
LL
114312011-06-22 Leo Liu <sdl.web@gmail.com>
11432
11433 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
11434 Move to minibuffer.el.
11435
85fece3e
PE
114362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11437
20b84ce9 11438 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
11439 The following patches are for when GLYPH_DEBUG && !XASSERT.
11440 * dispextern.h (trace_redisplay_p, dump_glyph_string):
11441 * dispnew.c (flush_stdout):
11442 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
11443 Mark as externally visible.
11444 * dispnew.c (check_window_matrix_pointers): Now static.
11445 * dispnew.c (window_to_frame_vpos):
11446 * xfns.c (unwind_create_frame):
11447 * xterm.c (x_check_font): Remove unused local.
11448 * scroll.c (CHECK_BOUNDS):
11449 * xfaces.c (cache_fache): Rename local to avoid shadowing.
11450 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
11451 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
11452 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
11453 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
11454 Now static.
11455 (debug_method_add): Use va_list and vsprintf rather than relying
11456 on undefined behavior with wrong number of arguments.
11457 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
11458 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
11459 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
11460 since we're not interested in debugging glyphs with old libraries.
11461 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
11462 GCC 4.6.0's static checking.
11463
0766b489
PE
114642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
11465
31fd4b32
PE
11466 Integer overflow and signedness fixes (Bug#8873).
11467 A few related buffer overrun fixes, too.
11468
b79e8648
PE
11469 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
11470
0766b489
PE
11471 * dispextern.h (struct face.stipple):
11472 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
11473 (x_bitmap_mask, x_allocate_bitmap_record)
11474 (x_create_bitmap_from_data, x_create_bitmap_from_file)
11475 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
11476 (x_create_bitmap_from_xpm_data):
11477 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
11478 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
11479 (.bitmaps_last):
11480 * xfaces.c (load_pixmap):
11481 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
11482 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
11483 (.bitmaps_last, struct x_output.icon_bitmap):
11484 Use ptrdiff_t, not int, for bitmap indexes.
11485 (x_allocate_bitmap_record): Check for size overflow.
11486 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
11487
b081724f
PE
11488 Use ptrdiff_t, not int, for overlay counts.
11489 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
11490 * editfns.c (overlays_around, get_pos_property):
11491 * textprop.c (get_char_property_and_overlay):
11492 * xdisp.c (next_overlay_change, note_mouse_highlight):
11493 * xfaces.c (face_at_buffer_position):
21514da7
PE
11494 * buffer.c (OVERLAY_COUNT_MAX): New macro.
11495 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
11496 (Fnext_overlay_change, Fprevious_overlay_change)
11497 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 11498 Use ptrdiff_t, not int, for sizes.
21514da7 11499 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 11500
3de73e5e
PE
11501 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
11502
2606c57b
PE
11503 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
11504 (x_session_initialize): Do not assume string length fits in int.
11505
aaafe47a
PE
11506 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
11507 This is unlikely, but can occur if DPI is outlandish.
11508
2674ddc8 11509 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
11510 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
11511
28154962
PE
11512 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
11513 * xrdb.c (magic_file_p, search_magic_path):
11514 Omit last arg SUFFIX; it was always 0. All callers changed.
11515 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
11516
7de51af5
PE
11517 * xfont.c (xfont_match): Avoid need for strlen.
11518
25ed6cc3
PE
11519 * xfns.c: Don't assume strlen fits in int.
11520 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
11521
4eab31dd
PE
11522 * xdisp.c (message_log_check_duplicate): Return intmax_t,
11523 not unsigned long, as we prefer signed integers. All callers changed.
11524 Detect integer overflow in repeat count.
11525 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 11526 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 11527
171e2a58
PE
11528 * termcap.c: Don't assume sizes fit in int and never overflow.
11529 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
11530 (gobble_line): Check for size-calculation overflow.
11531
ad39faca 11532 * minibuf.c (Fread_buffer):
6e5bb2dc 11533 * lread.c (intern, intern_c_string):
74ca2eb3
PE
11534 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
11535 Don't assume string length fits in int.
11536
52c61c22 11537 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
11538 * gtkutil.c (style_changed_cb): Avoid need for strlen.
11539
b5b8c9e5
PE
11540 * font.c: Don't assume string length fits in int.
11541 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
11542 Use ptrdiff_t, not int.
ccd6111c
PE
11543 (font_intern_prop): Don't assume string length fits in int.
11544 Don't assume integer property fits in fixnum.
11545 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 11546
882f0d81 11547 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 11548 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
11549 Reformulate so as not to need the command string.
11550 Invoke gzip -cd rather than gunzip, as it's more portable.
11551 (lock_info_type, lock_file_1, lock_file):
11552 Don't assume pid_t and time_t fit in unsigned long.
11553 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
11554 (current_lock_owner): Prefer signed type for sizes.
11555 Use memcpy, not strncpy, where memcpy is what is really wanted.
11556 Don't assume (via atoi) that time_t and pid_t fit in int.
11557 Check for time_t and/or pid_t out of range, e.g., via a network share.
11558 Don't alloca where an auto var works fine.
11559
93f4cf88
PE
11560 * fileio.c: Fix some integer overflow issues.
11561 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
11562 Don't assume string length fits in int.
11563 (directory_file_name): Don't assume string length fits in long.
11564 (make_temp_name): Don't assume pid fits in int, or that its print
11565 length is less than 20.
11566
f3e92b69
PE
11567 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
11568
1bfdaf10
PE
11569 * coding.c (make_subsidiaries): Don't assume string length fits in int.
11570
35016e9a
PE
11571 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
11572
3d1e65a1
PE
11573 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
11574 We prefer signed integers, even for size calculations.
11575
0b963a93
PE
11576 * emacs.c: Don't assume string length fits in 'int'.
11577 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
11578 (main): Don't invoke strlen when not needed.
11579
573f4b54
PE
11580 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
11581 (XD_DEBUG_MESSAGE): Don't waste a byte.
11582
989f33ba
PE
11583 * callproc.c (getenv_internal_1, getenv_internal)
11584 (Fgetenv_internal):
965d34eb
PE
11585 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
11586
e4d29b33
PE
11587 * lread.c (invalid_syntax): Omit length argument.
11588 All uses changed. This doesn't fix a bug, but it simplifies the
11589 code away from its former Hollerith-constant appearance, and it's
11590 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 11591 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 11592
eb49b136
PE
11593 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
11594 This didn't break anything, but it didn't help either.
11595 It's confusing to put a bogus integer in a place where the actual
11596 value does not matter.
9f62aeb1 11597 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 11598 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 11599
15375a22
PE
11600 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
11601 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
11602 implementation.
b61cc01c
PE
11603 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
11604 We prefer signed types, and the value cannot exceed the EMACS_INT
11605 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
11606 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
11607 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
11608 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 11609
53b2623d
PE
11610 * indent.c (sane_tab_width): New function.
11611 (current_column, scan_for_column, Findent_to, position_indentation)
11612 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 11613 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11614
51cab52b 11615 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 11616
f2ed8a70
PE
11617 * lisp.h (lint_assume): New macro.
11618 * composite.c (composition_gstring_put_cache):
11619 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
11620
abe80cc6
PE
11621 * editfns.c, insdel.c:
11622 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 11623
b02c740e
PE
11624 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
11625
ebc96716
PE
11626 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
11627
b4e50fa0 11628 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 11629 Use much-faster test for byte-length change.
311d5d7c 11630 Don't assume string byte-length fits in 'int'.
a4cf38e4 11631 Check that character arg fits in 'int'.
85461888 11632 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 11633
c0c1ee9f
PE
11634 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
11635
a498d7f4
PE
11636 * fns.c (concat): Catch string overflow earlier.
11637 Do not rely on integer wraparound.
11638
51cab52b
PE
11639 * dispextern.h (struct it.overlay_strings_charpos)
11640 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
11641 * xdisp.c (forward_to_next_line_start)
11642 (back_to_previous_visible_line_start)
11643 (reseat_at_next_visible_line_start, next_element_from_buffer):
11644 Don't arbitrarily truncate the value of 'selective' to int.
11645
76031fad
PE
11646 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
11647
5eb55db9
PE
11648 * composite.c: Don't truncate sizes to 'int'.
11649 (composition_gstring_p, composition_reseat_it)
11650 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
11651 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
11652 not EMACS_UINT, for indexes.
5eb55db9 11653
0703a717
PE
11654 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
11655
d6202519
PE
11656 * buffer.c: Include <verify.h>.
11657 (struct sortvec.priority, struct sortstr.priority):
8961a454 11658 Now EMACS_INT, not int.
c20998a7 11659 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
11660 (struct sortstr.size, record_overlay_string)
11661 (struct sortstrlist.size, struct sortlist.used):
11662 Don't truncate size to int.
11663 (record_overlay_string): Check for size-calculation overflow.
d6202519 11664 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 11665
d5a19415
JM
116662011-06-22 Jim Meyering <meyering@redhat.com>
11667
029529ac 11668 Don't leak an XBM-image-sized buffer
d5a19415
JM
11669 * image.c (xbm_load): Free the image buffer after using it.
11670
a9041e6c
PE
116712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
11672
11673 Port to Sun C.
11674 * composite.c (find_automatic_composition): Omit needless 'return 0;'
11675 that Sun C diagnosed.
11676 * fns.c (secure_hash): Fix pointer signedness issue.
11677 * intervals.c (static_offset_intervals): New function.
11678 (offset_intervals): Use it.
11679
7f3f739f
LL
116802011-06-21 Leo Liu <sdl.web@gmail.com>
11681
11682 * deps.mk (fns.o):
11683 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
11684 sha512.h.
11685
11686 * fns.c (secure_hash): Rename from crypto_hash_function and change
11687 the first arg to accept symbols.
5b66d427 11688 (Fsecure_hash): New primitive.
7f3f739f
LL
11689 (syms_of_fns): New symbols.
11690
76147d94
DD
116912011-06-20 Deniz Dogan <deniz@dogan.se>
11692
11693 * process.c (Fset_process_buffer): Clarify return value in
11694 docstring.
11695
7d7d0045
CY
116962011-06-18 Chong Yidong <cyd@stupidchicken.com>
11697
11698 * dispnew.c (add_window_display_history): Use BVAR.
11699
11700 * xdisp.c (debug_method_add): Use BVAR.
11701 (check_window_end, dump_glyph_matrix, dump_glyph)
11702 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
11703
11704 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
11705 Likewise.
11706
11707 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
11708 check till after the cache is created in init_frame_faces.
11709
ff2bc410
SM
117102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
11711
11712 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
11713
28177add
PE
117142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
11715
dd3482fe
PE
11716 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
11717 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11718 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11719
393d71f3 11720 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
11721 * fileio.c (Finsert_file_contents):
11722 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
11723 Remove the old (too-loose) buffer overflow checks.
11724 They weren't needed, since make_gap checks for buffer overflow.
11725 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
11726 The old code merely checked for Emacs fixnum overflow, and relied
11727 on undefined (wraparound) behavior. The new code avoids undefined
11728 behavior, and also checks for ptrdiff_t and/or size_t overflow.
11729
2e6813b0 11730 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
11731 Tune. Don't use wider integers than needed. Don't use alloca.
11732 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 11733
599a9e4f
PE
11734 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
11735
99561444
PE
11736 * insdel.c, lisp.h (buffer_overflow): New function.
11737 (insert_from_buffer_1, replace_range, replace_range_2):
11738 * insdel.c (make_gap_larger):
11739 * editfns.c (Finsert_char):
11740 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
11741
28177add
PE
11742 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
11743
e69dafad
PE
117442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
11745
4baa020d 11746 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 11747
b1c46f02
PE
11748 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
11749 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
11750
e69dafad
PE
11751 * fileio.c: Don't assume EMACS_INT fits in off_t.
11752 (emacs_lseek): New static function.
11753 (Finsert_file_contents, Fwrite_region): Use it.
11754 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
11755
566684ea
PE
11756 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
11757
e6966cd6
PE
11758 * fns.c: Don't overflow int when computing a list length.
11759 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
11760 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
11761 truncation on 64-bit hosts. Check for QUIT every
11762 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
11763 faster and is responsive enough.
11764 (Flength): Report an error instead of overflowing an integer.
11765 (Fsafe_length): Return a float if the value is not representable
11766 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 11767 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 11768 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 11769
dd0b0efb
PE
11770 * alloc.c: Check that resized vectors' lengths fit in fixnums.
11771 (header_size, word_size): New constants.
11772 (allocate_vectorlike): Don't check size overflow here.
11773 (allocate_vector): Check it here instead, since this is the only
11774 caller of allocate_vectorlike that could cause overflow.
11775 Check that the new vector's length is representable as a fixnum.
11776
86fe5cfe
PE
11777 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
11778 The previous code was bogus. For example, next_almost_prime (32)
11779 returned 39, which is undesirable as it is a multiple of 3; and
11780 next_almost_prime (24) returned 25, which is a multiple of 5 so
11781 why was the code bothering to check for multiples of 7?
11782
80e88859
PE
11783 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
11784
4a2f0ad6
PE
11785 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
11786
f66c7cf8
PE
11787 Variadic C functions now count arguments with ptrdiff_t.
11788 This partly undoes my 2011-03-30 change, which replaced int with size_t.
11789 Back then I didn't know that the Emacs coding style prefers signed int.
11790 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
11791 were being counted with int, which may truncate counts on 64-bit
11792 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
11793 * lisp.h (struct Lisp_Subr.function.aMANY)
11794 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
11795 Arg counts are now ptrdiff_t, not size_t.
11796 All variadic functions and their callers changed accordingly.
11797 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
11798 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
11799 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11800 * callint.c (Fcall_interactively): Check arg count for overflow,
11801 to avoid potential buffer overrun. Use signed char, not 'int',
11802 for 'varies' array, so that we needn't bother to check its size
11803 calculation for overflow.
11804 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11805 * eval.c (apply_lambda):
11806 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11807 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11808 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11809
a1759b76
PE
11810 * callint.c (Fcall_interactively): Don't use index var as event count.
11811
d96be9fc
PE
11812 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11813 * mem-limits.h (SIZE): Remove; no longer used.
11814
a690a978 11815 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11816
578c21e6
PE
11817 Remove unnecessary casts.
11818 * xterm.c (x_term_init):
11819 * xfns.c (x_set_border_pixel):
11820 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11821 These aren't needed now that we assume ANSI C.
11822
96f53c6c
PE
11823 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11824 It's more likely to cause problems (due to unsigned overflow)
11825 than to cure them.
11826
83c77d31
PE
11827 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11828
ee2079f1
PE
11829 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11830
6da65536
PE
11831 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11832
7147c4a4
PE
11833 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11834
193e32d9
PE
11835 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11836
e5533da6
PE
11837 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11838
9910e595
PE
11839 GLYPH_CODE_FACE returns EMACS_INT, not int.
11840 * dispextern.h (merge_faces):
11841 * xfaces.c (merge_faces):
01103c44
PE
11842 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11843 Don't assume EMACS_INT fits in int.
9910e595 11844
2638320e
PE
11845 * character.h (CHAR_VALID_P): Remove unused parameter.
11846 * fontset.c, lisp.h, xdisp.c: All uses changed.
11847
045eb8d9
PE
11848 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11849
c1f134b5
PE
11850 * fns.c (concat): Minor tuning based on overflow analysis.
11851 This doesn't fix any bugs. Use int to hold character, instead
11852 of constantly refetching from Emacs object. Use XFASTINT, not
11853 XINT, for value known to be a character. Don't bother comparing
11854 a single byte to 0400, as it's always less.
11855
395fcb93 11856 * floatfns.c (Fexpt):
327eeec8
PE
11857 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11858
abbd3d23
PE
11859 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11860 for characters.
11861
684a03ef
PE
11862 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11863
0fed43f3
PE
11864 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11865 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11866 incorrectly succeed when S was a string, because 4294967386 was
11867 truncated before it was used.
11868
8fd02eb7
PE
11869 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11870 Otherwise, an out-of-range integer could cause undefined behavior
11871 on a 64-bit host.
11872
f8c86b69
PE
11873 * composite.c: Use int, not EMACS_INT, for characters.
11874 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11875 EMACS_INT, for values that are known to be in character range.
11876 This doesn't fix any bugs but is the usual style inside Emacs and
11877 may generate better code on 32-bit machines.
11878
34206dd2
PE
11879 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11880 This is for reasons similar to the recent CHAR_STRING fix.
11881 * charset.c (Fencode_char): Check that character arg is actually
11882 a character. Pass an int to ENCODE_CHAR.
11883 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11884 wider than 'int', as a compile-time check to prevent future regressions
11885 in this area.
11886
c5958d4c 11887 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11888
11889 Make sure a 64-bit char is never passed to CHAR_STRING.
11890 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11891 by silently ignoring the top 32 bits, allowing some values
11892 that were far too large to be valid characters.
11893 * character.h: Include <verify.h>.
11894 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11895 arguments are no wider than unsigned, as a compile-time check
11896 to prevent future regressions in this area.
11897 * data.c (Faset):
01103c44 11898 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11899 (Fsubst_char_in_region):
11900 * fns.c (concat):
11901 * xdisp.c (decode_mode_spec_coding):
11902 Adjust to CHAR_STRING's new requirement.
11903 * editfns.c (Finsert_char, Fsubst_char_in_region):
11904 * fns.c (concat): Check that character args are actually
11905 characters. Without this test, these functions did the wrong
11906 thing with wildly out-of-range values on 64-bit hosts.
11907
d37ca623
PE
11908 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11909 These casts should not be needed on 32-bit hosts, either.
11910 * keyboard.c (read_char):
11911 * lread.c (Fload): Remove casts to unsigned.
11912
ea204efb
PE
11913 * lisp.h (UNSIGNED_CMP): New macro.
11914 This fixes comparison bugs on 64-bit hosts.
11915 (ASCII_CHAR_P): Use it.
11916 * casefiddle.c (casify_object):
01103c44 11917 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11918 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11919 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11920 * dispextern.h (FACE_FROM_ID):
11921 * keyboard.c (read_char): Use UNSIGNED_CMP.
11922
41cb286c
PE
11923 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11924 not to EMACS_INT, to avoid GCC warning.
11925
4a1b9832
PE
11926 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11927
55daad71
PE
11928 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11929 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11930 isn't needed on 32-bit machines.
8f95c75c 11931
01103c44
PE
11932 * buffer.c (Fgenerate_new_buffer_name):
11933 Use EMACS_INT for count, not int.
0ceccced 11934 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11935
11936 * data.c (Qcompiled_function): Now static.
11937
c6f072e7
PE
11938 * window.c (window_body_lines): Now static.
11939
20ce5912
PE
11940 * image.c (gif_load): Rename local to avoid shadowing.
11941
9c4c5f81
PE
11942 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11943 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11944 * alloc.c (make_save_value): Integer argument is now of type
11945 ptrdiff_t, not int.
11946 (mark_object): Use ptrdiff_t, not int.
11947 * lisp.h (pD): New macro.
11948 * print.c (print_object): Use it.
11949
c0c5c8ae
PE
11950 * alloc.c: Use EMACS_INT, not int, to count objects.
11951 (total_conses, total_markers, total_symbols, total_vector_size)
11952 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11953 (total_free_floats, total_floats, total_free_intervals)
11954 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11955 Now EMACS_INT, not int. All uses changed.
11956 (Fgarbage_collect): Compute overall total using a double, so that
11957 integer overflow is less likely to be a problem. Check for overflow
11958 when converting back to an integer.
5a25e253
PE
11959 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11960 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11961 These were 'int' variables that could overflow on 64-bit hosts;
11962 they were never used, so remove them instead of repairing them.
211a0b2a 11963 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11964 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11965 Previously, this ceilinged at INT_MAX, but that doesn't work on
11966 64-bit machines.
e46bb31a 11967 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11968
c78baabf 11969 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11970 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11971 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11972 when a (possibly-narrower) signed value would do just as well.
11973 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11974
c9d624c6
PE
11975 * alloc.c: Catch some string size overflows that we were missing.
11976 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11977 for convenience in STRING_BYTES_MAX.
11978 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11979 The definition here is exact; the one in lisp.h was approximate.
11980 (allocate_string_data): Check for string overflow. This catches
11981 some instances we weren't catching before. Also, it catches
11982 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11983 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11984 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11985
c9d624c6
PE
11986 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11987 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11988 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11989
353032ce
PE
11990 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11991
2bccce07
PE
11992 * alloc.c (Fmake_string): Check for out-of-range init.
11993
0ac30604
SM
119942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11995
11996 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11997
c195f2de
JD
119982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11999
12000 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
12001 xg_get_default_scrollbar_width.
12002
12003 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
12004 (int_gtk_range_get_value): Move to the scroll bar part of the file.
12005 (style_changed_cb): Call update_theme_scrollbar_width and call
12006 x_set_scroll_bar_default_width and xg_frame_set_char_size for
12007 all frames (Bug#8505).
12008 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
12009 Call gtk_window_set_resizable if HAVE_GTK3.
12010 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
12011 and height if HAVE_GTK3 (Bug#8505).
12012 (scroll_bar_width_for_theme): New variable.
12013 (update_theme_scrollbar_width): New function.
12014 (xg_get_default_scrollbar_width): Move code to
12015 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
12016 (xg_initialize): Call update_theme_scrollbar_width.
12017
12018 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
12019
12020 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
12021
e10ac9f1
MR
120222011-06-12 Martin Rudalics <rudalics@gmx.at>
12023
12024 * frame.c (make_frame): Call other_buffer_safely instead of
12025 other_buffer.
12026
12027 * window.c (temp_output_buffer_show): Call display_buffer with
12028 second argument Vtemp_buffer_show_specifiers and reset latter
12029 immediately after the call.
12030 (Vtemp_buffer_show_specifiers): New variable.
12031 (auto_window_vscroll_p, next_screen_context_lines)
12032 (Vscroll_preserve_screen_position): Remove leading asterisks from
12033 doc-strings.
12034
2d3c217e 120352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 12036
7b7f97e8 12037 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
12038 * buffer.c (Qclone_number): Remove for now, as it's unused.
12039 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
12040 (record_buffer): Remove unused local.
12041 * frame.c (other_visible_frames, frame_buffer_list): Now static.
12042 (set_frame_buffer_list): Remove; unused.
12043 * frame.h (other_visible_frames): Remove decl.
12044 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
12045 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
12046 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
12047 if HAVE_GPM.
12048 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
12049 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
12050 Define only if HAVE_GPM.
12051 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
12052 (update_hints_inhibit): Remove; never set. All uses removed.
12053 * widgetprv.h (emacsFrameClassRec): Remove decl.
12054 * window.c (delete_deletable_window): Now returns void, since it
12055 wasn't returning anything.
12056 (compare_window_configurations): Remove unused locals.
12057 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
12058 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
12059 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
12060 the same widths as pointers. This follows up on the 2011-05-06 patch.
12061 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
12062 * xterm.h: Likewise.
12063 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
12064
1384b89e
JB
120652011-06-12 Juanma Barranquero <lekktu@gmail.com>
12066
12067 * makefile.w32-in: Update dependencies.
12068 (LISP_H): Add lib/intprops.h.
12069
1100a63c
CY
120702011-06-11 Chong Yidong <cyd@stupidchicken.com>
12071
12072 * image.c (gif_load): Add animation frame delay to the metadata.
12073 (syms_of_image): Use DEFSYM. New symbol `delay'.
12074
6198ccd0
MR
120752011-06-11 Martin Rudalics <rudalics@gmx.at>
12076
12077 * window.c (delete_deletable_window): Re-add.
12078 (Fset_window_configuration): Rewrite to handle dead buffers and
12079 consequently deletable windows.
12080 (window_tree, Fwindow_tree): Remove. Supply functionality in
12081 window.el.
12082 (compare_window_configurations): Simplify code.
12083
b6e3633c
AS
120842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
12085
1ab0dee5
AS
12086 * image.c (imagemagick_load_image): Fix type mismatch.
12087 (Fimagemagick_types): Likewise.
12088
b6e3633c
AS
12089 * window.h (replace_buffer_in_windows): Declare.
12090
9397e56f
MR
120912011-06-11 Martin Rudalics <rudalics@gmx.at>
12092
12093 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
12094 Qclone_number. Remove external declaration of Qdelete_window.
12095 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
12096 code.
640c8776
SM
12097 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
12098 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
12099 (Fother_buffer): Rewrite doc-string. Major rewrite for new
12100 buffer list implementation.
12101 (other_buffer_safely): New function.
12102 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
12103 calls to replace_buffer_in_windows and
12104 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
12105 if allowed.
12106 (record_buffer): Inhibit quitting and rewrite using quittable
12107 functions. Run Qbuffer_list_update_hook if allowed.
12108 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
12109 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
12110 Move switch-to-buffer to window.el.
9397e56f
MR
12111 (bury-buffer): Move to window.el.
12112 (Vbuffer_list_update_hook): New variable.
12113
12114 * lisp.h (other_buffer_safely): Add prototype in buffer.c
12115 section.
12116
12117 * window.h (resize_frame_windows): Move up in code.
12118 (Fwindow_frame): Remove EXFUN.
12119 (replace_buffer_in_all_windows): Remove prototype.
12120 (replace_buffer_in_windows_safely): Add prototype.
12121
12122 * window.c: Declare Qdelete_window static again. Move down
12123 declaration of select_count.
12124 (Fnext_window, Fprevious_window): Rewrite doc-strings.
12125 (Fother_window): Move to window.el.
12126 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
12127 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
12128 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
12129 window.el.
12130 (replace_buffer_in_windows): Implement by calling
12131 Qreplace_buffer_in_windows.
12132 (replace_buffer_in_all_windows): Remove with some functionality
12133 moved into replace_buffer_in_windows_safely.
12134 (replace_buffer_in_windows_safely): New function.
12135 (select_window_norecord, select_frame_norecord): Move in front
12136 of run_window_configuration_change_hook. Remove now obsolete
12137 declarations.
640c8776
SM
12138 (Fset_window_buffer): Rewrite doc-string.
12139 Call Qrecord_window_buffer.
9397e56f
MR
12140 (keys_of_window): Move binding for other-window to window.el.
12141
b50691aa
CY
121422011-06-11 Chong Yidong <cyd@stupidchicken.com>
12143
12144 * dispextern.h (struct image): Replace data member, whose int_val
12145 and ptr_val fields were not used by anything, with a single
12146 lisp_val object.
12147
12148 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
12149 (gif_clear_image, gif_load, imagemagick_load_image)
12150 (gs_clear_image, gs_load): Callers changed.
12151
3f754b86
PE
121522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12153
cca69397
PE
12154 * buffer.h: Include <time.h>, for time_t.
12155 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
12156
109e28d0
PE
12157 Fix minor problems found by static checking.
12158
60737f02
PE
12159 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
12160
4b66faf3
PE
12161 Make identifiers static if they are not used in other modules.
12162 * data.c (Qcompiled_function, Qframe, Qvector):
12163 * image.c (QimageMagick, Qsvg):
12164 * minibuf.c (Qmetadata):
12165 * window.c (resize_window_check, resize_root_window): Now static.
12166 * window.h (resize_window_check, resize_root_window): Remove decls.
12167
109e28d0
PE
12168 * window.c (window_deletion_count, delete_deletable_window):
12169 Remove; unused.
46a4ce9e
PE
12170 (window_body_lines): Now static.
12171 (Fdelete_other_windows_internal): Mark vars as initialized.
12172 Make sure 'resize_failed' is initialized.
12173 (run_window_configuration_change_hook): Rename local to avoid shadowing.
12174 (resize_window_apply): Remove unused local.
12175 * window.h (delete_deletable_window): Remove decl.
12176
109e28d0 12177 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
12178 (imagemagick_load_image): Fix pointer signedness problem by changing
12179 last arg from unsigned char * to char *. All uses changed.
12180 Also, fix a local for similar reasons.
12181 Remove unused locals. Remove locals to avoid shadowing.
12182 (fn_rsvg_handle_free): Remove; unused.
12183 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 12184 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 12185
3f754b86
PE
12186 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
12187
2547adb1
CY
121882011-06-10 Chong Yidong <cyd@stupidchicken.com>
12189
12190 * image.c (gif_load): Fix omitted cast error introduced by
12191 2011-06-06 change.
12192
2c8e37d4
MR
121932011-06-10 Martin Rudalics <rudalics@gmx.at>
12194
12195 * window.h (resize_proportionally, orig_total_lines)
12196 (orig_top_line): Remove from window structure.
12197 (set_window_height, set_window_width, change_window_heights)
12198 (Fdelete_window): Remove prototypes.
12199 (resize_frame_windows): Remove duplicate declaration.
12200
440a42e3
EZ
122012011-06-10 Eli Zaretskii <eliz@gnu.org>
12202
12203 * window.h (resize_frame_windows, resize_window_check)
12204 (delete_deletable_window, resize_root_window)
12205 (resize_frame_windows): Declare prototypes.
12206
12207 * window.c (resize_window_apply): Make definition be "static" to
12208 match the prototype.
12209
562dd5e9
MR
122102011-06-10 Martin Rudalics <rudalics@gmx.at>
12211
12212 * window.c: Remove declarations of Qwindow_size_fixed,
12213 window_min_size_1, window_min_size_2, window_min_size,
12214 size_window, window_fixed_size_p, enlarge_window, delete_window.
12215 Remove static from declaration of Qdelete_window, it's
12216 temporarily needed by Fbury_buffer.
12217 (replace_window): Don't assign orig_top_line and
12218 orig_total_lines.
12219 (Fdelete_window, delete_window): Remove. Window deletion is
12220 handled by window.el.
640c8776
SM
12221 (window_loop): Remove DELETE_OTHER_WINDOWS case.
12222 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
12223 (Fdelete_other_windows): Remove. Deleting other windows is
12224 handled by window.el.
12225 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
12226 handled in window.el.
12227 (window_min_size_2, window_min_size_1, window_min_size): Remove.
12228 Window minimum sizes are handled in window.el.
12229 (shrink_windows, size_window, set_window_height)
12230 (set_window_width, change_window_heights, window_height)
12231 (window_width, CURBEG, CURSIZE, enlarge_window)
12232 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
12233 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
12234 handled in window.el.
12235 (make_dummy_parent): Rename to make_parent_window and give it a
12236 second argument horflag.
12237 (make_window): Don't set resize_proportionally any more.
12238 (Fsplit_window): Remove. Windows are split in window.el.
12239 (save_restore_action, save_restore_orig_size)
12240 (shrink_window_lowest_first, save_restore_orig_size): Remove.
12241 Resize mini windows in window.el.
12242 (grow_mini_window, shrink_mini_window): Implement by calling
12243 Qresize_root_window_vertically, resize_window_check and
12244 resize_window_apply.
640c8776
SM
12245 (saved_window, Fset_window_configuration, save_window_save):
12246 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
12247 resize_proportionally.
12248 (window_min_height, window_min_width): Move to window.el.
12249 (keys_of_window): Move bindings for delete-other-windows,
12250 split-window, delete-window and enlarge-window to window.el.
12251
12252 * buffer.c: Temporarily extern Qdelete_window.
12253 (Fbury_buffer): Temporarily call Qdelete_window instead of
12254 Fdelete_window (Fbury_buffer will move to window.el soon).
12255
12256 * frame.c (set_menu_bar_lines_1): Remove code handling
12257 orig_top_line and orig_total_lines.
12258
12259 * dispnew.c (adjust_frame_glyphs_initially): Don't use
12260 set_window_height but set heights directly.
12261 (change_frame_size_1): Use resize_frame_windows.
12262
12263 * xdisp.c (init_xdisp): Don't use set_window_height but set
12264 heights directly.
12265
640c8776
SM
12266 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
12267 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
12268 run_window_configuration_change_hook.
12269
12270 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
12271 instead of change_window_heights and run
12272 run_window_configuration_change_hook.
12273
1a13852e
MR
122742011-06-09 Martin Rudalics <rudalics@gmx.at>
12275
12276 * window.c (replace_window): Rename second argument REPLACEMENT to
12277 NEW. New third argument SETFLAG. Rewrite.
12278 (delete_window, make_dummy_parent): Call replace_window with
12279 third argument 1.
12280 (window_list_1): Move down in code.
12281 (run_window_configuration_change_hook): Move set_buffer part
12282 before select_frame_norecord part in order to unwind correctly.
12283 Rename count1 to count.
12284 (recombine_windows, delete_deletable_window, resize_root_window)
12285 (Fdelete_other_windows_internal)
12286 (Frun_window_configuration_change_hook, make_parent_window)
12287 (resize_window_check, resize_window_apply, Fresize_window_apply)
12288 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
12289 (Fdelete_window_internal, Fresize_mini_window_internal):
12290 New functions.
1a13852e
MR
12291 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
12292
f3d1777e
MR
122932011-06-08 Martin Rudalics <rudalics@gmx.at>
12294
496e208e
MR
12295 * window.h (window): Add some new members to window structure -
12296 normal_lines, normal_cols, new_total, new_normal, clone_number,
12297 splits, nest, prev_buffers, next_buffers.
12298 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 12299 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 12300
f3d1777e
MR
12301 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
12302 Remove.
496e208e
MR
12303 (make_dummy_parent): Set new members of windows structure.
12304 (make_window): Move down in code. Handle new members of window
12305 structure.
12306 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
12307 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
12308 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
12309 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
12310 (Fset_window_next_buffers, Fset_window_clone_number):
12311 New functions.
496e208e
MR
12312 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
12313 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
12314 Doc-string fixes.
12315 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
12316 Argument WINDOW can be now internal window too.
12317 (Fwindow_use_time): Move up in code.
12318 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
12319 Rewrite doc-string.
12320 (Fset_window_configuration, saved_window)
12321 (Fcurrent_window_configuration, save_window_save): Handle new
12322 members of window structure.
b9e809c2
MR
12323 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
12324 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
12325 (syms_of_window): New Lisp objects Qrecord_window_buffer,
12326 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
12327 Qget_mru_window, Qresize_root_window,
12328 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
12329 Qauto_buffer_name; staticpro them.
f3d1777e 12330
abde8f8c
MR
123312011-06-07 Martin Rudalics <rudalics@gmx.at>
12332
12333 * window.c (Fwindow_total_size, Fwindow_left_column)
12334 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
12335 (Fwindow_list_1): New functions.
12336 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
12337 (Fwindow_width, Fscroll_left, Fscroll_right):
12338 Use window_body_cols instead of window_box_text_cols.
12339 (delete_window, Fset_window_configuration):
12340 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
12341 (delete_all_subwindows): Take a window as argument and not a
12342 structure. Rewrite.
190b47e6
MR
12343 (window_loop): Remove handling of GET_LRU_WINDOW and
12344 GET_LARGEST_WINDOW.
12345 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
12346
12347 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
12348 window_box_text_cols. delete_all_subwindows now takes a
12349 Lisp_Object as argument.
abde8f8c 12350
640c8776
SM
12351 * indent.c (compute_motion, Fcompute_motion):
12352 Use window_body_cols instead of window_box_text_cols.
abde8f8c 12353
fa8a67e6
MR
12354 * frame.c (delete_frame): Call delete_all_subwindows with root
12355 window as argument.
12356
a54e3482
DC
123572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
12358
12359 * fns.c (Fputhash): Document return value.
12360
60002bf5
CY
123612011-06-06 Chong Yidong <cyd@stupidchicken.com>
12362
12363 * image.c (gif_load): Implement gif89a spec "no disposal" method.
12364
0c671da6 123652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 12366
b862a52a 12367 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 12368
be44ca6c
PE
12369 Check for overflow when converting integer to cons and back.
12370 * charset.c (Fdefine_charset_internal, Fdecode_char):
12371 Use cons_to_unsigned to catch overflow.
12372 (Fencode_char): Use INTEGER_TO_CONS.
12373 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
12374 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
12375 * data.c (long_to_cons, cons_to_long): Remove.
12376 (cons_to_unsigned, cons_to_signed): New functions.
12377 These signal an error for invalid or out-of-range values.
12378 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
12379 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
12380 * font.c (Ffont_variation_glyphs):
12381 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
12382 * lisp.h: Include <intprops.h>.
12383 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
12384 (cons_to_signed, cons_to_unsigned): New decls.
12385 (long_to_cons, cons_to_long): Remove decls.
12386 * undo.c (record_first_change): Use INTEGER_TO_CONS.
12387 (Fprimitive_undo): Use CONS_TO_INTEGER.
12388 * xfns.c (Fx_window_property): Likewise.
12389 * xselect.c: Include <limits.h>.
12390 (x_own_selection, selection_data_to_lisp_data):
12391 Use INTEGER_TO_CONS.
12392 (x_handle_selection_request, x_handle_selection_clear)
12393 (x_get_foreign_selection, Fx_disown_selection_internal)
12394 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
12395 (lisp_data_to_selection_data): Use cons_to_unsigned.
12396 (x_fill_property_data): Use cons_to_signed.
12397 Report values out of range.
12398
d1f3d2af
PE
12399 Check for buffer and string overflow more precisely.
12400 * buffer.h (BUF_BYTES_MAX): New macro.
12401 * lisp.h (STRING_BYTES_MAX): New macro.
12402 * alloc.c (Fmake_string):
12403 * character.c (string_escape_byte8):
12404 * coding.c (coding_alloc_by_realloc):
12405 * doprnt.c (doprnt):
12406 * editfns.c (Fformat):
12407 * eval.c (verror):
12408 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
12409 since they may not be the same number.
12410 * editfns.c (Finsert_char):
12411 * fileio.c (Finsert_file_contents):
12412 Likewise for BUF_BYTES_MAX.
12413
dd52fcea
PE
12414 * image.c: Use ptrdiff_t, not int, for sizes.
12415 (slurp_file): Switch from int to ptrdiff_t.
12416 All uses changed.
12417 (slurp_file): Check that file size fits in both size_t (for
12418 malloc) and ptrdiff_t (for sanity and safety).
12419
7f9bbdbb
PE
12420 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
12421 if b->modtime has its maximal value.
12422
dfe18f82
PE
12423 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
12424
84acfcf0
PE
12425 Don't assume time_t can fit into int.
12426 * buffer.h (struct buffer.modtime): Now time_t, not int.
12427 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
12428 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
12429
ccd9a01a
PE
12430 Minor fixes for signed vs unsigned integers.
12431 * character.h (MAYBE_UNIFY_CHAR):
12432 * charset.c (maybe_unify_char):
12433 * keyboard.c (read_char, reorder_modifiers):
12434 XINT -> XFASTINT, since the integer must be nonnegative.
12435 * ftfont.c (ftfont_spec_pattern):
12436 * keymap.c (access_keymap, silly_event_symbol_error):
12437 XUINT -> XFASTINT, since the integer must be nonnegative.
12438 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
12439 since it makes no difference and we prefer signed.
12440 * keyboard.c (record_char): Use XUINT when all the neighbors do.
12441 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
12442 nonnegative.
12443
d6d100dd
SM
124442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
12445
12446 * window.h (Fwindow_frame): Declare.
12447
2b6148e4
PE
124482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12449
12450 * alloc.c: Simplify handling of large-request failures (Bug#8800).
12451 (SPARE_MEMORY): Always define.
12452 (LARGE_REQUEST): Remove.
12453 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
12454
f230ecc9
MR
124552011-06-06 Martin Rudalics <rudalics@gmx.at>
12456
727e958e
MR
12457 * lisp.h: Move EXFUNS for Fframe_root_window,
12458 Fframe_first_window and Fset_frame_selected_window to window.h.
12459
12460 * window.h: Move EXFUNS for Fframe_root_window,
12461 Fframe_first_window and Fset_frame_selected_window here from
12462 lisp.h.
12463
12464 * frame.c (Fwindow_frame, Fframe_first_window)
12465 (Fframe_root_window, Fframe_selected_window)
12466 (Fset_frame_selected_window): Move to window.c.
12467 (Factive_minibuffer_window): Move to minibuf.c.
12468 (Fother_visible_frames_p): New function.
12469
12470 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
12471
f230ecc9
MR
12472 * window.c (decode_window, decode_any_window): Move up in code.
12473 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
12474 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
12475 (Fwindow_buffer): Move up and rewrite doc-string.
12476 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
12477 (Fwindow_prev): New functions.
727e958e
MR
12478 (Fwindow_frame): Move here from frame.c. Accept any window as
12479 argument.
12480 (Fframe_root_window, Fframe_first_window)
12481 (Fframe_selected_window): Move here from frame.c. Accept frame
12482 or arbitrary window as argument. Update doc-strings.
12483 (Fminibuffer_window): Move up in code.
12484 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
12485 (Fset_frame_selected_window): Move here from frame.c.
12486 Marginal rewrite.
727e958e
MR
12487 (Fselected_window, select_window, Fselect_window): Move up in
12488 code. Minor doc-string fixes.
f230ecc9 12489
4d09bcf6
PE
124902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
12491
12492 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
12493 Do not assume that spare memory exists; that assumption is valid
12494 only if SYSTEM_MALLOC.
12495 (LARGE_REQUEST): New macro, so that the issue of large requests
12496 is separated from the issue of spare memory.
12497
810928a2
AS
124982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
12499
172418ad
AS
12500 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
12501 format. (Bug#8806)
12502
43f862f7
AS
12503 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
12504
810928a2
AS
12505 * xfns.c (x_set_scroll_bar_default_width): Move declarations
12506 before statements.
12507
a059fe24
JD
125082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
12509
12510 * gtkutil.c (xg_get_default_scrollbar_width): New function.
12511
12512 * gtkutil.h: Declare xg_get_default_scrollbar_width.
12513
12514 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
12515 min width by calling x_set_scroll_bar_default_width (Bug#8505).
12516
989bf368
JB
125172011-06-05 Juanma Barranquero <lekktu@gmail.com>
12518
12519 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
12520
4b80f674
CY
125212011-06-04 Chong Yidong <cyd@stupidchicken.com>
12522
12523 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
12524 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
12525 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
12526 New error handlers.
4b80f674
CY
12527 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
12528 Obey Vx_select_enable_clipboard_manager. Catch errors in
12529 x_clipboard_manager_save (Bug#8779).
12530 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 12531 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 12532
99a33b77 125332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
12534
12535 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
12536
99a33b77 125372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
12538
12539 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
12540 in the current matrix if keep_current_p is non-zero.
12541
8264569d
EZ
125422011-06-04 Eli Zaretskii <eliz@gnu.org>
12543
12544 * bidi.c (bidi_level_of_next_char): Fix last change.
12545
57f97249
EZ
125462011-06-03 Eli Zaretskii <eliz@gnu.org>
12547
fec2107c 12548 Support bidi reordering of text covered by display properties.
57f97249 12549
fec2107c
EZ
12550 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
12551 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
12552 (bidi_cache_search, bidi_cache_iterator_state)
12553 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
12554 (bidi_level_of_next_char, bidi_move_to_visually_next):
12555 Support character positions inside a run of characters covered by a
fec2107c
EZ
12556 display string.
12557 (bidi_paragraph_init, bidi_resolve_explicit_1)
12558 (bidi_level_of_next_char): Call bidi_fetch_char and
12559 bidi_fetch_char_advance instead of FETCH_CHAR and
12560 FETCH_CHAR_ADVANCE.
12561 (bidi_init_it): Initialize new members.
12562 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
12563 definitions.
12564 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
12565 instead of using explicit *_CHAR codes.
d6d100dd
SM
12566 (bidi_resolve_explicit, bidi_resolve_weak):
12567 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
12568 bidirectional text is supported only in multibyte buffers.
12569 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
12570 it to initialize the frame_window_p member of struct bidi_it.
12571 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
12572 (bidi_resolve_explicit, bidi_resolve_weak)
12573 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
12574 bidi_it->nchars is non-positive.
12575 (bidi_level_of_next_char): Don't try to lookup the cache for the
12576 next/previous character if nothing is cached there yet, or if we
12577 were just reseat()'ed to a new position.
c40e2fb2 12578
0e14fe90
EZ
12579 * xdisp.c (set_cursor_from_row): Set start and stop points
12580 according to the row's direction when priming the loop that looks
12581 for the glyph on which to display cursor.
12582 (single_display_spec_intangible_p): Function deleted.
12583 (display_prop_intangible_p): Reimplement to call
12584 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
12585 Accept 3 additional arguments needed by handle_display_spec.
12586 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
12587 values: lists, `(when COND...)' forms, etc.
12588 (single_display_spec_string_p): Support property values that are
12589 lists with the argument STRING its top-level element.
12590 (display_prop_string_p): Fix the condition for processing a
12591 property that is a list to be consistent with handle_display_spec.
fec2107c 12592 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
12593 last portion of handle_display_prop.
12594 (compute_display_string_pos): Accept additional argument
12595 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
12596 value of a `display' property is a "replacing spec".
12597 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
12598 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
12599 the display property, but just return a value indicating whether
12600 the display property will replace the characters it covers.
12601 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
12602 frame_window_p members of struct bidi_it.
d6d100dd
SM
12603 (compute_display_string_pos, compute_display_string_end):
12604 New functions.
fec2107c
EZ
12605 (push_it): Accept second argument POSITION, where pop_it should
12606 jump to continue iteration.
12607 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 12608
fec2107c
EZ
12609 * keyboard.c (adjust_point_for_property): Adjust the call to
12610 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
12611
12612 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
12613 (bidi_init_it): Update prototypes.
12614 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
12615 (compute_display_string_pos, compute_display_string_end):
12616 Declare prototypes.
fec2107c
EZ
12617 (struct bidi_it): New members nchars and disp_pos. ch_len is now
12618 EMACS_INT.
fc6f18ce 12619
40087514 126202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 12621
57f53182
PE
12622 Malloc failure behavior now depends on size of allocation.
12623 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
12624 * lisp.h: Change signatures accordingly.
12625 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
12626 All callers changed. (Bug#8762)
12627
12628 * gnutls.c: Use Emacs's memory allocators.
12629 Without this change, the gnutls library would invoke malloc etc.
12630 directly, which causes problems on non-SYNC_INPUT hosts, and which
12631 runs afoul of improving memory_full behavior. (Bug#8761)
12632 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
12633 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
12634 xfree instead of the default malloc, realloc, free.
12635 (Fgnutls_boot): No need to check for memory allocation failure,
12636 since xmalloc does that for us.
12637
ac32cd99 12638 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
12639 * category.c (hash_get_category_set):
12640 * ccl.c (ccl_driver):
12641 * charset.c (Fdefine_charset_internal):
12642 * charset.h (struct charset.hash_index):
12643 * composite.c (get_composition_id, gstring_lookup_cache)
12644 (composition_gstring_put_cache):
12645 * composite.h (struct composition.hash_index):
12646 * dispextern.h (struct image.hash):
12647 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
12648 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
12649 (hashfn_equal, hashfn_user_defined, make_hash_table)
12650 (maybe_resize_hash_table, hash_lookup, hash_put)
12651 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
12652 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
12653 (Fsxhash, Fgethash, Fputhash, Fmaphash):
12654 * image.c (make_image, search_image_cache, lookup_image)
12655 (xpm_put_color_table_h):
12656 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 12657 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 12658 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 12659 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
12660 * alloc.c (allocate_vectorlike):
12661 Check for overflow in vector size calculations.
12662 * ccl.c (ccl_driver):
12663 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
12664 * fns.c, image.c: Remove unnecessary static decls that would otherwise
12665 need to be updated by these changes.
40087514
PE
12666 * fns.c (make_hash_table, maybe_resize_hash_table):
12667 Check for integer overflow with large hash tables.
0de4bb68
PE
12668 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
12669 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
12670 (SXHASH_REDUCE): New macro.
12671 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
12672 Use it instead of discarding useful hash info with large hash values.
12673 (sxhash_float): New function.
12674 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
12675 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
12676 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
12677 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
12678 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
12679 Adjust signatures to match updated version of code.
12680 (consing_since_gc): Now EMACS_INT, since a single hash table can
12681 use more than INT_MAX bytes.
12682
698d32e2
DN
126832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
12684
12685 Make it possible to build with GCC-4.6+ -O2 -flto.
12686
12687 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
12688
fd6fa53f
SM
126892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
12690
12691 * minibuf.c (get_minibuffer, read_minibuf_unwind):
12692 Call minibuffer-inactive-mode.
12693
864db017
JB
126942011-05-31 Juanma Barranquero <lekktu@gmail.com>
12695
12696 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
12697 Update dependencies.
12698
2ad0baf4
DN
126992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12700
12701 * data.c (init_data): Remove code for UTS, this system is not
12702 supported anymore.
12703
4fcc2638
DN
127042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12705
12706 Don't force ./temacs to start in terminal mode.
12707
12708 * frame.c (make_initial_frame): Initialize faces in all cases, not
12709 only when CANNOT_DUMP is defined.
12710 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
12711
c56e0fd5
DN
127122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12713
12714 * dispnew.c (add_window_display_history): Use const for the string
12715 pointer. Remove declaration, not needed.
12716
333d54da 127172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 12718
55d4c1b2 12719 Use 'inline', not 'INLINE'.
333d54da 12720 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
12721 * alloc.c, fontset.c (INLINE): Remove.
12722 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
12723 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
12724 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
12725 * gmalloc.c (register_heapinfo): Use inline unconditionally.
12726 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
12727
738db178
DN
127282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
12729
12730 Make it possible to run ./temacs.
12731
12732 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
12733 syms_of_callproc does the same thing. Remove test for
12734 "initialized", do it in the caller.
12735 * emacs.c (main): Avoid calling set_initial_environment when dumping.
12736
620c53a6
SM
127372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
12738
12739 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
12740 (read_minibuf): Use get_minibuffer.
12741 (syms_of_minibuf): Use DEFSYM.
12742 (Qmetadata): New var.
12743 * data.c (Qbuffer): Don't make it static.
12744 (syms_of_data): Use DEFSYM.
12745
e003a292
PE
127462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
12747
12748 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
12749 (CCL_CODE_MIN): New macro.
12750
ed008a6d
PE
127512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
12752
3687c2ef
PE
12753 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
12754
ed008a6d
PE
12755 * eval.c (Qdebug): Now static.
12756 * lisp.h (Qdebug): Remove decl. This reverts a part of the
12757 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
12758 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
12759
d66c4c7c
CY
127602011-05-29 Chong Yidong <cyd@stupidchicken.com>
12761
12762 * image.c: Various fixes to ImageMagick code comments.
12763 (Fimagemagick_types): Doc fix.
12764
5fbc2025
PE
127652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
12766
0196f88a
PE
12767 Minor fixes prompted by GCC 4.6.0 warnings.
12768
12769 * xselect.c (converted_selections, conversion_fail_tag): Now static.
12770
5fbc2025
PE
12771 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
12772 (x_clipboard_manager_save_all): Move extern decl to ...
12773 * xterm.h: ... here, so that it can be checked for consistency.
12774
1dd3c2d9
CY
127752011-05-29 Chong Yidong <cyd@stupidchicken.com>
12776
12777 * xselect.c (x_clipboard_manager_save_frame)
12778 (x_clipboard_manager_save_all): New functions.
12779 (Fx_clipboard_manager_save): Lisp function deleted.
12780
12781 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
12782 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
12783
12784 * xterm.h: Update prototype.
12785
5ba6571d
WX
127862011-05-28 William Xu <william.xwl@gmail.com>
12787
12788 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
12789 exiting (Bug#8239).
12790
3eaff834
JM
127912011-05-28 Jim Meyering <meyering@redhat.com>
12792
e1900994 12793 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
12794 * fns.c (to_uchar): Define.
12795 (crypto_hash_function): Use it to convert some newly-signed
12796 variables to unsigned, to avoid sign-extension bugs. For example,
12797 without this change, (md5 "truc") would evaluate to
12798 45723a2aff78ff4fff7fff1114760e62 rather than the expected
12799 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12800 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12801
0f6990a7
PE
128022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12803
12804 Integer overflow fixes.
c8a9ca5a 12805
08686060
PE
12806 * dbusbind.c: Serial number integer overflow fixes.
12807 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12808 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12809 to hold a serial number that is too large for a fixnum.
12810 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12811 Check for serial numbers out of range. Decode any serial number
59568bf0 12812 that was so large that it became a float. (Bug#8722)
08686060 12813
2d1fc3c7
PE
12814 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12815 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12816 Use XFASTINT rather than XUINT when numbers are nonnegative.
12817 (xd_append_arg, Fdbus_method_return_internal):
12818 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12819 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12820 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12821 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12822 (Bug#8722)
2d1fc3c7 12823
c8a9ca5a
PE
12824 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12825
519e1d69
PE
12826 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12827
6df6ae42 12828 ccl: Add integer overflow checks.
30569699
PE
12829 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12830 (IN_INT_RANGE): New macros.
12831 (ccl_driver): Use them to check for integer overflow when
12832 decoding a CCL program. Many of the new checks are whether XINT (x)
12833 fits in int; it doesn't always, on 64-bit hosts. The new version
12834 doesn't catch all possible integer overflows, but it's an
847044ea 12835 improvement. (Bug#8719)
30569699 12836
c11285dc
PE
12837 * alloc.c (make_event_array): Use XINT, not XUINT.
12838 There's no need for unsigned here.
12839
fdccd48e
PE
12840 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12841 This follows up to the 2011-05-06 change that substituted uintptr_t
12842 for EMACS_INT. This case wasn't caught back then.
12843
37910ab2
PE
12844 Rework Fformat to avoid integer overflow issues.
12845 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12846 now (part of C89). Include <verify.h>.
12847 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12848 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12849 (Fformat): Avoid the prepass trying to compute sizes; it was only
12850 approximate and thus did not catch overflow reliably. Instead, walk
12851 through the format just once, formatting and computing sizes as we go,
12852 checking for integer overflow at every step, and allocating a larger
12853 buffer as needed. Keep track separately whether the format is
12854 multibyte. Keep only the most-recently calculated precision, rather
12855 than them all. Record whether each argument has been converted to
12856 string. Use EMACS_INT, not int, for byte and char and arg counts.
12857 Support field widths and precisions larger than INT_MAX. Avoid
12858 sprintf's undefined behavior with conversion specifications such as %#d
12859 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12860 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12861 formatting out-of-range floating point numbers with int
9173deec 12862 formats. (Bug#8668)
37910ab2 12863
2e6578fb
PE
12864 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12865
0ae6bdee
PE
12866 * data.c: Avoid integer truncation in expressions involving floats.
12867 * data.c: Include <intprops.h>.
12868 (arith_driver): When there's an integer overflow in an expression
12869 involving floating point, convert the integers to floating point
12870 so that the resulting value does not suffer from catastrophic
12871 integer truncation. For example, on a 64-bit host (* 4
12872 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12873 Do not rely on undefined behavior after integer overflow.
12874
de883a70
PE
12875 merge count_size_as_multibyte, parse_str_to_multibyte
12876 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12877 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12878 Check for integer overflow.
12879 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12880 since it's now a duplicate of the other. This is more of
12881 a character than a buffer op, so better that it's in character.c.
12882 * fns.c, print.c: Adjust to above changes.
12883
2ff916cb
PE
128842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12885
12886 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12887
f1b54466
PE
128882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12889
fb1ac845
PE
12890 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12891 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12892 (x_clipboard_manager_save): Now static.
12893 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12894
f1b54466
PE
12895 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12896 (crypto_hash_function): Now static.
12897 Fix pointer signedness problems. Avoid unnecessary initializations.
12898
a9f737ee
CY
128992011-05-27 Chong Yidong <cyd@stupidchicken.com>
12900
12901 * termhooks.h (Vselection_alist): Make it terminal-local.
12902
12903 * terminal.c (create_terminal): Initialize it.
12904
12905 * xselect.c: Support for clipboard managers.
12906 (Vselection_alist): Move to termhooks.h as terminal-local var.
12907 (LOCAL_SELECTION): New macro.
12908 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12909 (symbol_to_x_atom): Remove gratuitous arg.
12910 (x_handle_selection_request, lisp_data_to_selection_data)
12911 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12912 (x_own_selection, x_get_local_selection, x_convert_selection):
12913 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12914 (some_frame_on_display): Delete unused function.
12915 (Fx_own_selection_internal, Fx_get_selection_internal)
12916 (Fx_disown_selection_internal, Fx_selection_owner_p)
12917 (Fx_selection_exists_p): New optional frame arg.
12918 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12919 (x_handle_selection_clear): Don't treat other terminals with the
12920 same keyboard specially. Use the terminal-local Vselection_alist.
12921 (x_clear_frame_selections): Use Frun_hook_with_args.
12922
12923 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12924
12925 * xterm.h: Add support for those atoms.
12926
e067f0c1
CY
129272011-05-26 Chong Yidong <cyd@stupidchicken.com>
12928
12929 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12930 (converted_selections, conversion_fail_tag): New global variables.
12931 (x_selection_request_lisp_error): Free the above.
12932 (x_get_local_selection): Remove unnecessary code.
12933 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12934 of converted selections stored in converted_selections.
12935 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12936 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12937 (x_convert_selection): New function.
12938 (x_handle_selection_event): Simplify.
12939 (x_get_foreign_selection): Don't ignore incoming requests while
12940 waiting for an answer; this will fail when we implement
12941 SAVE_TARGETS, and seems unnecessary anyway.
12942 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12943 (Vx_sent_selection_functions): Doc fix.
12944
0f4aebc0
LL
129452011-05-26 Leo Liu <sdl.web@gmail.com>
12946
12947 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12948
e61124cd
YM
129492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12950
12951 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12952
12953 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12954 for fringe update if it has periodic bitmap.
ac389d0c 12955 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12956 and fringe_bitmap_periodic_p.
12957
12958 * fringe.c (get_fringe_bitmap_data): New function.
12959 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12960 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12961 row. Mark glyph row for fringe update if periodicity changed.
12962
12963 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12964 for fringe update unless it has periodic bitmap.
12965
f16d9837
KH
129662011-05-25 Kenichi Handa <handa@m17n.org>
12967
12968 * xdisp.c (get_next_display_element): Set correct it->face_id for
12969 a static composition.
12970
e1b90ef6
LL
129712011-05-24 Leo Liu <sdl.web@gmail.com>
12972
12973 * deps.mk (fns.o):
12974 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12975
12976 * fns.c (crypto_hash_function, Fsha1): New function.
12977 (Fmd5): Use crypto_hash_function.
12978 (syms_of_fns): Add Ssha1.
12979
7400048f
PE
129802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12981
12982 * gnutls.c: Remove unused macros.
12983 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12984 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12985 Remove macros that are defined and never used.
12986 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12987
abb71cf4
CY
129882011-05-22 Chong Yidong <cyd@stupidchicken.com>
12989
12990 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12991 (Fx_get_selection_internal): Minor cleanup.
12992 (Fx_own_selection_internal): Rename arguments for consistency with
12993 select.el.
12994
6307db39
PE
129952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12996
12997 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12998
f3d4e0a4
CY
129992011-05-22 Chong Yidong <cyd@stupidchicken.com>
13000
13001 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
13002
4d8ade89
YM
130032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13004
13005 * dispnew.c (scrolling_window): Don't exclude the case that the
13006 last enabled row in the desired matrix touches the bottom boundary.
13007
32078c8d
GM
130082011-05-21 Glenn Morris <rgm@gnu.org>
13009
13010 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
13011 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
13012 and add some more files.
32078c8d 13013
7285dc67
EZ
130142011-05-20 Eli Zaretskii <eliz@gnu.org>
13015
13016 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
13017 report_file_error introduced by the change from 2011-05-07.
13018
89d1bd22
PE
130192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13020
13021 * systime.h (Time): Define only if emacs is defined.
13022 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
13023 where the include path doesn't have X11/X.h by default. See
13024 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
13025
cd394be1 130262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
13027
13028 * composite.c (find_automatic_composition): Fix previous change.
13029
b9704ad9
GM
130302011-05-20 Glenn Morris <rgm@gnu.org>
13031
13032 * lisp.mk: New file, split from Makefile.in.
13033 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
13034 (shortlisp): Remove.
13035 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
13036
4a720484
GM
130372011-05-19 Glenn Morris <rgm@gnu.org>
13038
13039 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
13040 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
13041 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
13042 (lisp): Set the order to that of loadup.el.
13043 (shortlisp): Make it a copy of $lisp.
13044 (SOME_MACHINE_LISP): Remove.
13045 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
13046 Use just $shortlisp, not $SOME_MACHINE_LISP too.
13047
a28d4396
KH
130482011-05-18 Kenichi Handa <handa@m17n.org>
13049
13050 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
13051 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
13052 (find_automatic_composition): Mostly rewrite for efficiency.
13053
a2b1fa8e
JB
130542011-05-18 Juanma Barranquero <lekktu@gmail.com>
13055
13056 * makefile.w32-in: Update dependencies.
13057
8e1f5610
CS
130582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
13059
13060 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 13061 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 13062
7025ee00 130632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 13064
cdfa6eab
PE
13065 Fix some integer overflow issues, such as string length overflow.
13066
06d6db33
PE
13067 * insdel.c (count_size_as_multibyte): Check for string overflow.
13068
2b4560a8
PE
13069 * character.c (lisp_string_width): Check for string overflow.
13070 Use EMACS_INT, not int, for string indexes and lengths; in
13071 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
13072 the resulting string length overflows an EMACS_INT; instead,
13073 report a string overflow if no precision given. When checking for
13074 precision exhaustion, use a check that cannot possibly have
13075 integer overflow. (Bug#8675)
13076 * character.h (lisp_string_width): Adjust to new signature.
13077
cb93f9be
PE
13078 * alloc.c (string_overflow): New function.
13079 (Fmake_string): Use it. This doesn't change behavior, but saves
13080 a few bytes and will simplify future changes.
13081 * character.c (string_escape_byte8): Likewise.
13082 * lisp.h (string_overflow): New decl.
13083
1a1f3366
PE
13084 Fixups, following up to the user-interface timestamp change.
13085 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
13086 for UI timestamps, instead of unsigned long.
9fbd6841
PE
13087 * msdos.c (mouse_get_pos): Likewise.
13088 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
13089 * w32gui.h (Time): Define by including "systime.h" rather than by
13090 declaring it ourselves. (Bug#8664)
13091
d4e3e4d3
PE
13092 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
13093 * image.c (clear_image_cache): Likewise.
13094
f6a24d19
PE
13095 * term.c (term_mouse_position): Don't assume time_t wraparound.
13096
08dc5ae6
PE
13097 Be more systematic about user-interface timestamps.
13098 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
13099 and sometimes 'EMACS_UINT', to represent these timestamps.
13100 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
13101 This makes the code easier to follow, and makes it easier to catch
13102 integer overflow bugs such as Bug#8664.
13103 * frame.c (Fmouse_position, Fmouse_pixel_position):
13104 Use Time, not unsigned long, for user-interface timestamps.
13105 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
13106 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
13107 * keyboard.h (last_event_timestamp): Likewise.
13108 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
13109 * menu.h (xmenu_show): Likewise.
13110 * term.c (term_mouse_position): Likewise.
13111 * termhooks.h (struct input_event.timestamp): Likewise.
13112 (struct terminal.mouse_position_hook): Likewise.
13113 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
13114 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
13115 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
13116 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
13117 what it was before.
13118 * menu.h, termhooks.h: Include "systime.h", for Time.
13119
8e55734a
PE
13120 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
13121 Don't assume that the difference between two unsigned long values
13122 can fit into an integer. At this point, we know button_down_time
13123 <= event->timestamp, so the difference must be nonnegative, so
13124 there's no need to cast the result if double-click-time is
13125 nonnegative, as it should be; check that it's nonnegative, just in
13126 case. This bug is triggered when events are more than 2**31 ms
86db42d2 13127 apart (about 25 days). (Bug#8664)
8e55734a 13128
841f1b75 13129 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13130 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 13131
3e26f69c
PE
13132 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
13133 that always fit in int. Use a sentinel instead of a counter, to
13134 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
13135 * frame.h (struct frame): Use int for menu_bar_items_used
13136 instead of EMACS_INT, since it always fits in int.
3e26f69c 13137
5cc152c0
PE
13138 * menu.c (grow_menu_items): Check for int overflow.
13139
d89eb65e
PE
13140 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
13141
5235bd3e
PE
13142 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
13143 Before, the code was not consistent. These values cannot exceed
13144 2**31 - 1 so there's no need to make them unsigned.
13145 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
13146 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
13147 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
13148 as modifiers.
13149 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
13150
bc827e23
PE
13151 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13152 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
13153 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
13154 presumably because the widths might not match.
13155
78eb494e
PE
13156 * window.c (size_window): Avoid needless test at loop start.
13157
04f2d78b
CB
131582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
13159
13160 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
13161
d2fc7e3d 131622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
13163
13164 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
13165
d2fc7e3d 131662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
13167
13168 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
13169 `width' to `bar_area_x' and `bar_area_width', respectively.
13170 (x_scroll_run): Take account of fringe background extension.
13171
04f2d78b
CB
13172 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
13173 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
13174 `bar_area_width', respectively.
13175 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
13176 background extension.
13177
79b70037
GM
131782011-05-10 Jim Meyering <meyering@redhat.com>
13179
13180 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
13181
2f142cc5
JB
131822011-05-10 Juanma Barranquero <lekktu@gmail.com>
13183
13184 * image.c (Finit_image_library): Return t for built-in image types,
13185 like pbm and xbm. (Bug#8640)
13186
57679c86
AS
131872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
13188
13189 * w32menu.c (set_frame_menubar): Fix submenu allocation.
13190
888c9e86
EZ
131912011-05-07 Eli Zaretskii <eliz@gnu.org>
13192
b0512a1d
EZ
13193 * w32console.c (Fset_screen_color): Doc fix.
13194 (Fget_screen_color): New function.
13195 (syms_of_ntterm): Defsubr it.
13196
7285dc67
EZ
13197 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
13198 unlink the temporary file if Fcall_process didn't create it in the
13199 first place.
13200 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
13201 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
13202 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
13203 cue to call_process_cleanup not to close that handle.
13204
4d3fcc8e
BK
132052011-05-07 Ben Key <bkey76@gmail.com>
13206
13207 * makefile.w32-in: The bootstrap-temacs rule now makes use of
13208 one of two shell specific rules, either bootstrap-temacs-CMD or
13209 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
13210 to the previous implementation of the bootstrap-temacs rule.
13211 The bootstrap-temacs-CMD rule is similar to the previous
13212 implementation of the bootstrap-temacs rule except that it
13213 makes use of the ESC_CFLAGS variable instead of the CFLAGS
13214 variable.
13215
13216 These changes, along with some changes to nt/configure.bat,
13217 nt/gmake.defs, and nt/nmake.defs, are required to extend my
13218 earlier fix to add support for --cflags and --ldflags options
13219 that include quotes so that it works whether make uses cmd or
13220 sh as the shell.
13221
b4289b64
MA
132222011-05-06 Michael Albinus <michael.albinus@gmx.de>
13223
13224 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
13225 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
13226 is a constant.
13227 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
13228 a string. Handle both cases.
13229 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
13230 (Fdbus_register_method): Use Qinvalid_function.
13231
af4c0e28
JB
132322011-05-06 Juanma Barranquero <lekktu@gmail.com>
13233
13234 * makefile.w32-in: Update dependencies.
13235 (LISP_H): Add inttypes.h and stdin.h.
13236 (PROCESS_H): Add unistd.h.
13237
c51453d9
EZ
132382011-05-06 Eli Zaretskii <eliz@gnu.org>
13239
13240 * lread.c: Include limits.h (fixes the MS-Windows build broken by
13241 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
13242
8ff0ac3c 132432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 13244
4c4b566b
PE
13245 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
13246
aab2b9b5
PE
13247 * term.c (vfatal): Remove stray call to va_end.
13248 It's not needed and the C Standard doesn't allow it here anyway.
13249
c378da0b
PE
13250 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
13251 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
13252
288b08c7
PE
13253 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
13254 bytes.
13255
e3601888
PE
13256 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
13257
db6c0e74
PE
13258 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
13259
dd5963ea
PE
13260 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
13261
88c9450f
PE
13262 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
13263
2f9442b8
PE
13264 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
13265
c032b5f8
PE
13266 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
13267 * charset.c (Fdefine_charset_internal): Don't initialize
13268 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 13269 32-bit int (Bug#8600).
a108c10b
PE
13270
13271 * lread.c (read_integer): Be more consistent with string-to-number.
13272 Use string_to_number to do the actual conversion; this avoids
13273 rounding errors and fixes some other screwups. Without this fix,
13274 for example, #x1fffffffffffffff was misread as -2305843009213693952.
13275 (digit_to_number): Move earlier, for benefit of read_integer.
13276 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 13277 not a digit in any supported base. (Bug#8602)
a108c10b 13278
ad5f9eea
PE
13279 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
13280
aec1708a
PE
13281 * dispnew.c (scrolling_window): Return 1 if we scrolled,
13282 to match comment at start of function. This also removes a
13283 GCC warning about overflow in a 32+64-bit port.
13284
47be4ab5
PE
13285 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
13286
371cac43
PE
13287 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
13288 Reported by Stefan Monnier in
13289 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
13290 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13291 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 13292
d01a7826
PE
13293 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
13294 (EMACS_UINTPTR): Likewise, with uintptr_t.
13295
7fd47d5c
PE
13296 * lisp.h: Prefer 64-bit EMACS_INT if available.
13297 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
13298 on 32-bit hosts that have 64-bit int, so that they can access
13299 large files.
122b0c86
PE
13300 However, temporarily disable this change unless the temporary
13301 symbol WIDE_EMACS_INT is defined.
7fd47d5c 13302
8727937b
PE
13303 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
13304
8ac068ac
PE
13305 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
13306 This removes an assumption that EMACS_INT and long are the same
13307 width as pointers. The assumption is true for Emacs porting targets
13308 now, but we want to make other targets possible.
13309 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
13310 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
13311 In the rest of the code, change types of integers that hold casted
13312 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
13313 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
13314 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
13315 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
13316 No need to cast type when ORing.
13317 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
13318 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
13319 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
13320 assume EMACS_INT is the same width as char *.
13321 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
13322 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
13323 Remove no-longer-needed casts.
13324 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
13325 (xg_tool_bar_help_callback, xg_make_tool_item):
13326 Use EMACS_INTPTR to hold an integer
13327 that will be cast to void *; this can avoid a GCC warning
13328 if EMACS_INT is not the same width as void *.
13329 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
13330 * xdisp.c (display_echo_area_1, resize_mini_window_1):
13331 (current_message_1, set_message_1):
13332 Use a local to convert to proper width without a cast.
13333 * xmenu.c (dialog_selection_callback): Likewise.
13334
ede49d71
PE
13335 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
13336 Also, don't assume VALBITS / RAND_BITS is less than 5,
13337 and don't rely on undefined behavior when shifting a 1 left into
13338 the sign bit.
13339 * lisp.h (get_random): Change signature to match.
13340
2f30ecd0
PE
13341 * lread.c (hash_string): Use size_t, not int, for hash computation.
13342 Normally we prefer signed values; but hashing is special, because
13343 it's better to use unsigned division on hash table sizes so that
13344 the remainder is nonnegative. Also, size_t is the natural width
13345 for hashing into memory. The previous code used 'int', which doesn't
13346 retain enough info to hash well into very large tables.
13347 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
13348
2a866e7b
PE
13349 * dbusbind.c: Don't possibly lose pointer info when converting.
13350 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
13351 Use XPNTR rather than XHASH, so that the high-order bits of
13352 the pointer aren't lost when converting through void *.
13353
51639eac
PE
13354 * eval.c (Fautoload): Don't double-shift a pointer.
13355
92394119
PE
13356 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
13357
dbdb9a7c
JB
133582011-05-06 Juanma Barranquero <lekktu@gmail.com>
13359
13360 * gnutls.c (DEF_GNUTLS_FN):
13361 * image.c (DEF_IMGLIB_FN): Make function pointers static.
13362
db7a0b4f
AS
133632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
13364
13365 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
13366 marker. (Bug#8610)
13367
cd394be1 133682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
13369
13370 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
13371 New version that can reserve upto 2GB of heap space.
13372
f7ff1b0f 133732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
13374
13375 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
13376
639c109b
TZ
133772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
13378
13379 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
13380 `gnutls_certificate_set_x509_key_file'.
13381
d2127135
JB
133822011-05-05 Juanma Barranquero <lekktu@gmail.com>
13383
13384 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
13385 Update dependencies.
13386
e968f4f3
JB
133872011-05-04 Juanma Barranquero <lekktu@gmail.com>
13388
13389 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
13390 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
13391 Remove unused parameter `fildes'.
13392 * process.c (read_process_output, send_process): Don't pass it.
13393
84d358f0
JB
133942011-05-04 Juanma Barranquero <lekktu@gmail.com>
13395
13396 Fix previous change: the library cache is defined in w32.c.
13397 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
13398 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
13399
0898ca10
JB
134002011-05-04 Juanma Barranquero <lekktu@gmail.com>
13401
13402 Implement dynamic loading of GnuTLS on Windows.
13403
13404 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
13405 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
13406 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13407 Declare.
13408
13409 * gnutls.c (Qgnutls_dll): Define.
13410 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
13411 (gnutls_*): Declare function pointers.
13412 (init_gnutls_functions): New function to initialize function pointers.
13413 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
13414 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
13415 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
13416 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
13417 (emacs_gnutls_write, emacs_gnutls_read)
13418 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
13419 (Fgnutls_available_p): New function.
13420 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
13421 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
13422 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
13423
13424 * image.c: Include w32.h.
13425 (Vimage_type_cache): Delete.
13426 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
13427 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
13428 (w32_delayed_load): Move to w32.c.
13429
13430 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
13431
13432 * w32.c (QCloaded_from, Vlibrary_cache): Define.
13433 (w32_delayed_load): Move from image.c. When loading a library, record
13434 its filename in the :loaded-from property of the library id.
13435 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
13436 Initialize and staticpro them.
13437 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
13438
13439 * process.c: Include lisp.h before w32.h, not after.
13440 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
13441 instead of gnutls_record_check_pending.
13442
13443 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
13444
ff4de4aa
TZ
134452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
13446
13447 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
13448 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
13449 as passed in.
13450
abe95abb
JD
134512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
13452
13453 * xterm.c (x_set_frame_alpha): Do not set property on anything
13454 else than FRAME_X_OUTER_WINDOW (Bug#8608).
13455
e16e55d4
JB
134562011-05-02 Juanma Barranquero <lekktu@gmail.com>
13457
13458 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
13459
bafcf6a5
JB
134602011-05-02 Juanma Barranquero <lekktu@gmail.com>
13461
13462 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
13463 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
13464 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
13465 (gnutls_global_initialized, Qgnutls_bootprop_priority)
13466 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
13467 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
13468 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
13469 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
13470 (Qgnutls_bootprop_callbacks_verify): Make static.
13471
e7a6747f
AS
134722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
13473
19ed11ba
AS
13474 * callproc.c: Indentation fixup.
13475
e7a6747f 13476 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
13477 (wait_for_termination, interruptible_wait_for_termination):
13478 Move after wait_for_termination_1.
e7a6747f 13479
1ef14cb4
LMI
134802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
13481
13482 * sysdep.c (interruptible_wait_for_termination): New function
13483 which is like wait_for_termination, but allows keyboard
13484 interruptions.
13485
13486 * callproc.c (Fcall_process): Add (:file "file") as an option for
13487 the STDOUT buffer.
13488 (Fcall_process_region): Ditto.
13489
330d880c
EZ
134902011-04-30 Eli Zaretskii <eliz@gnu.org>
13491
8db90b73
EZ
13492 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
13493 rather than `XVECTOR (FOO)->size'.
13494
330d880c
EZ
13495 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
13496 inttypes.h, as a gnulib replacement is used if it not available in
13497 system headers.
13498
15cbd324
EZ
134992011-04-21 Eli Zaretskii <eliz@gnu.org>
13500
13501 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
13502 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
13503 of MOST_POSITIVE_FIXNUM. (Bug#8528)
13504
13505 * coding.c (coding_alloc_by_realloc): Error out if destination
13506 will grow beyond MOST_POSITIVE_FIXNUM.
13507 (decode_coding_emacs_mule): Abort if there isn't enough place in
13508 charbuf for the composition carryover bytes. Reserve an extra
13509 space for up to 2 characters produced in a loop.
13510 (decode_coding_iso_2022): Abort if there isn't enough place in
13511 charbuf for the composition carryover bytes.
13512
135132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 13514
ae940cca
EZ
13515 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
13516 aborting when %lld or %lll format is passed.
13517 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
13518 %llo or %llx format is passed. (Bug#8545)
13519
03ab8921
EZ
13520 * window.c (window_scroll_line_based): Use a marker instead of
13521 simple variables to record original value of point. (Bug#7952)
13522
afda1437
EZ
13523 * doprnt.c (doprnt): Fix the case where a multibyte sequence
13524 produced by %s or %c overflows available buffer space. (Bug#8545)
13525
f76dee0c
PE
135262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
13527
13528 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 13529 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 13530
fdc5744d
JB
135312011-04-28 Juanma Barranquero <lekktu@gmail.com>
13532
13533 * w32.c (init_environment): Warn about defaulting HOME to C:\.
13534
638f053a
JB
135352011-04-28 Juanma Barranquero <lekktu@gmail.com>
13536
13537 * keyboard.c (Qdelayed_warnings_hook): Define.
13538 (command_loop_1): Run `delayed-warnings-hook'
13539 if Vdelayed_warnings_list is non-nil.
13540 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
13541 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
13542
d178f871
EZ
135432011-04-28 Eli Zaretskii <eliz@gnu.org>
13544
13545 * doprnt.c (doprnt): Don't return value smaller than the buffer
13546 size if the message was truncated. (Bug#8545).
13547
b124fd93
JB
135482011-04-28 Juanma Barranquero <lekktu@gmail.com>
13549
13550 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
13551 (Fx_window_property): #if-0 the whole functions, not just the bodies.
13552
e810457d
PE
135532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13554
13555 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
13556
ea51cceb
JB
135572011-04-27 Juanma Barranquero <lekktu@gmail.com>
13558
13559 * makefile.w32-in: Update dependencies.
13560
94dcfacf
EZ
135612011-04-27 Eli Zaretskii <eliz@gnu.org>
13562
13563 Improve `doprnt' and its usage. (Bug#8545)
13564 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
13565 `format_end'. Remove support for %l as a conversion specifier.
13566 Don't use xrealloc. Improve diagnostics when the %l size modifier
13567 is used. Update the commentary.
13568
13569 * eval.c (verror): Simplify calculation of size_t.
13570
13571 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
13572 messages.
13573
f61f41d7
PE
135742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
13575
13576 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
13577 change.
13578
96fb4434
PE
135792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
13580
13581 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
13582 This makes this file independent of the recent pseudovector change.
13583
671875da 135842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 13585
69e9b5a3
PE
13586 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
13587
b5f869a7 13588 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 13589 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 13590 Remove unused local.
c8926152 13591 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 13592
841a1577 13593 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
13594 GCC 4.6.0 optimizes based on type-based alias analysis.
13595 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
13596 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
13597 != &v->size, and therefore "v->size = 1; b->size = 2; return
13598 v->size;" must therefore return 1. This assumption is incorrect
13599 for Emacs, since it type-puns struct Lisp_Vector * with many other
13600 types. To fix this problem, this patch adds a new type struct
f904488f 13601 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
13602 and pseudovectors, and helps optimizing compilers not get fooled
13603 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
13604 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
13605 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
13606 the size member.
eab3844f
PE
13607 (XSETPVECTYPE): Rewrite in terms of new macro.
13608 (XSETPVECTYPESIZE): New macro, specifying both type and size.
13609 This is a bit clearer, and further avoids the possibility of
13610 undesirable aliasing.
13611 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 13612 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
13613 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
13614 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
13615 (ASIZE): Now uses header.size rather than size.
13616 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
13617 to avoid the hassle of writing XVECTOR (foo)->header.size.
13618 (struct vectorlike_header): New type.
eab3844f
PE
13619 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
13620 object, to help avoid aliasing.
13621 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
13622 (SUBRP): Likewise, since Lisp_Subr is a special case.
13623 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
13624 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
13625 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 13626 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
13627 changed to be "header.size" and "header.next".
13628 * buffer.h (struct buffer): Likewise.
13629 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
13630 * frame.h (struct frame): Likewise.
13631 * process.h (struct Lisp_Process): Likewise.
13632 * termhooks.h (struct terminal): Likewise.
13633 * window.c (struct save_window_data, struct saved_window): Likewise.
13634 * window.h (struct window): Likewise.
13635 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
13636 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
13637 * buffer.c (init_buffer_once): Likewise.
13638 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
13639 special case.
13640 * process.c (Fformat_network_address): Use local var for size,
13641 for brevity.
13642
0df1eac5
PE
13643 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
13644
847ab9d1 13645 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
13646 * data.c (atof): Remove decl; no longer used or needed.
13647 (digit_to_number): Move to lread.c.
13648 (Fstring_to_number): Use new string_to_number function, to be
13649 consistent with how the Lisp reader treats infinities and NaNs.
13650 Do not assume that floating-point numbers represent EMACS_INT
13651 without losing information; this is not true on most 64-bit hosts.
13652 Avoid double-rounding errors, by insisting on integers when
13653 parsing non-base-10 numbers, as the documentation specifies.
13654 * lisp.h (string_to_number): New decl, replacing ...
13655 (isfloat_string): Remove.
bc0a5c13 13656 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 13657 (read1): Do not accept +. and -. as integers; this
452f4150
PE
13658 appears to have been a coding error. Similarly, do not accept
13659 strings like +-1e0 as floating point numbers. Do not report
13660 overflow for integer overflows unless the base is not 10 which
13661 means we have no simple and reliable way to continue.
13662 Break out the floating-point parsing into a new
13663 function string_to_number, so that Fstring_to_number parses
13664 floating point numbers consistently with the Lisp reader.
04f2d78b 13665 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
13666 (E_CHAR, EXP_INT): Remove, replacing with ...
13667 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
13668 (string_to_number): New function, replacing isfloat_string.
13669 This function checks for valid syntax and produces the resulting
13670 Lisp float number too. Rework it so that string-to-number
bc0a5c13 13671 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
13672 so that overflow for non-base-10 numbers is reported only when
13673 there's no portable and simple way to convert to floating point.
452f4150 13674
67769ffc
PE
13675 * textprop.c (set_text_properties_1): Rewrite for clarity,
13676 and to avoid GCC warning about integer overflow.
13677
c20db43f
PE
13678 * intervals.h (struct interval): Use EMACS_INT for members
13679 where EMACS_UINT might cause problems. See
13680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
13681 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
13682 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
13683 All uses changed.
37aa2f85
PE
13684 (offset_intervals): Tell GCC not to worry about length overflow
13685 when negating a negative length.
c20db43f 13686
2538aa2f
PE
13687 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
13688 (overrun_check_free): Likewise.
13689
f2d3008d
PE
13690 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
13691 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
13692 word size.
13693
ec8df744
PE
13694 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13695 (gnutls_make_error): Rename local to avoid shadowing.
13696 (gnutls_emacs_global_deinit): ifdef out; not used.
13697 (Fgnutls_boot): Use const for pointer to readonly storage.
13698 Comment out unused local. Fix pointer signedness problems.
13699
640ee02d
PE
13700 * lread.c (openp): Don't stuff size_t into an 'int'.
13701 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
13702 about possible signed overflow.
13703
6048fb2a
PE
13704 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
13705 (GDK_KEY_g): Don't define if already defined.
13706 (xg_prepare_tooltip): Avoid pointer signedness problem.
13707 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
13708
fa3c87e1
PE
13709 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
13710 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
13711
2172544b
PE
13712 * xfns.c (Fx_window_property): Simplify a bit,
13713 to make a bit faster and to avoid GCC 4.6.0 warning.
13714 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
13715
9b821a21
PE
13716 * fns.c (internal_equal): Don't assume size_t fits in int.
13717
3c616cfa
PE
13718 * alloc.c (compact_small_strings): Tighten assertion a little.
13719
c2982e87
PE
13720 Replace pEd with more-general pI, and fix some printf arg casts.
13721 * lisp.h (pI): New macro, generalizing old pEd macro to other
13722 conversion specifiers. For example, use "...%"pI"d..." rather
13723 than "...%"pEd"...".
13724 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 13725 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
13726 * alloc.c (check_pure_size): Don't overflow by converting size to int.
13727 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
13728 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
13729 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
13730 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
13731 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
13732 64-bit hosts.
13733 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
13734 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
13735 * print.c (safe_debug_print, print_object): Likewise.
13736 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
13737 to int.
6f04d126
PE
13738 Use pI instead of if-then-else-abort. Use %p to avoid casts,
13739 avoiding the 0 flag, which is not portable.
c2982e87
PE
13740 * process.c (Fmake_network_process): Use pI to avoid cast.
13741 * region-cache.c (pp_cache): Likewise.
13742 * xdisp.c (decode_mode_spec): Likewise.
13743 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
13744 behavior on 64-bit hosts with printf arg.
6f04d126 13745 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
13746 (x_stop_queuing_selection_requests): Likewise.
13747 (x_get_window_property): Don't truncate byte count to an 'int'
13748 when tracing.
0b432f21 13749
5e073ec7
PE
13750 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
13751 here, since it parses constructs like leading '-' and spaces,
13752 which are not wanted; and it overflows with large numbers.
13753 Instead, simply match F[0-9]+, which is what is wanted anyway.
13754
36372bf9
PE
13755 * alloc.c: Remove unportable assumptions about struct layout.
13756 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
13757 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
13758 (allocate_vectorlike, make_pure_vector): Use the new macros,
13759 plus offsetof, to remove unportable assumptions about struct layout.
13760 These assumptions hold on all porting targets that I know of, but
13761 they are not guaranteed, they're easy to remove, and removing them
13762 makes further changes easier.
13763
0b432f21
PE
13764 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
13765 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
13766 (string_overrun_cookie): Now const. Use initializers that
13767 don't formally overflow signed char, to avoid warnings.
000098c1
PE
13768 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
13769 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
13770 (allocate_buffer): Don't assume sizeof (struct buffer) is a
13771 multiple of sizeof (EMACS_INT); it need not be, if
13772 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 13773 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 13774
895009e1
JB
137752011-04-26 Juanma Barranquero <lekktu@gmail.com>
13776
13777 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
13778
6a7a1b0b
TZ
137792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
13780
13781 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 13782 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
13783 Reported by Paul Eggert <eggert@cs.ucla.edu>.
13784
841a1577 137852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
13786
13787 * lisp.h (Qdebug): List symbol.
895009e1 13788 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
13789 * keyboard.c (debug-on-event): New variable.
13790 (handle_user_signal): Break into debugger when debug-on-event
13791 matches the current signal symbol.
13792
f2d3ba6f
DN
137932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
13794
13795 * alloc.c (check_sblock, check_string_bytes)
13796 (check_string_free_list): Convert to standard C.
13797
42ce4c63
TZ
137982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
13799
13800 * w32.c (emacs_gnutls_push): Fix typo.
13801
825cd63c
EZ
138022011-04-25 Eli Zaretskii <eliz@gnu.org>
13803
fb11d64d
EZ
13804 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13805 "cast to pointer from integer of different size".
13806
825cd63c
EZ
13807 Improve doprnt and its use in verror. (Bug#8545)
13808 * doprnt.c (doprnt): Document the set of format control sequences
13809 supported by the function. Use SAFE_ALLOCA instead of always
13810 using `alloca'.
13811
13812 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13813 is one byte too soon. Don't use xrealloc; instead xfree and
13814 xmalloc anew.
13815
e061a11b
TZ
138162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13817
13818 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13819 callbacks stage.
13820
13821 * gnutls.c: Renamed global_initialized to
13822 gnutls_global_initialized. Added internals for the
13823 :verify-hostname-error, :verify-error, and :verify-flags
13824 parameters of `gnutls-boot' and documented those parameters in the
13825 docstring. Start callback support.
9173deec
JB
13826 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13827 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13828 on error. Return error code.
e061a11b
TZ
13829 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13830 (emacs_gnutls_read): Likewise.
13831 (Fgnutls_boot): Return handshake error code.
13832 (emacs_gnutls_handle_error): New function.
13833 (wsaerror_to_errno): Likewise.
13834
13835 * w32.h (emacs_gnutls_pull): Add prototype.
13836 (emacs_gnutls_push): Likewise.
13837
13838 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13839 (emacs_gnutls_push): Likewise.
13840
138412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13842
13843 * process.c (wait_reading_process_output): Check if GnuTLS
13844 buffered some data internally if no FDs are set for TLS
13845 connections.
13846
13847 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13848 (LIBS): Link to USER_LIBS.
13849 ($(BLD)/gnutls.$(0)): New target.
13850
fa6996bc
EZ
138512011-04-24 Eli Zaretskii <eliz@gnu.org>
13852
eb35682e
EZ
13853 * xdisp.c (handle_single_display_spec): Rename the
13854 display_replaced_before_p argument into display_replaced_p, to
13855 make it consistent with the commentary. Fix typos in the
13856 commentary.
13857
e2ad650c
EZ
13858 * textprop.c (syms_of_textprop): Remove dead code.
13859 (copy_text_properties): Delete obsolete commentary about an
13860 interface that was deleted long ago. Fix typos in the description
13861 of arguments.
13862
1b2de274
EZ
13863 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13864 to changes in oldXMenu/XMenu.h from 2011-04-16.
13865 <menu_help_message, prev_menu_help_message>: Constify.
13866 (IT_menu_make_room): menu->help_text is now `const char **';
13867 adjust.
13868
13869 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13870 to changes in oldXMenu/XMenu.h from 2011-04-16.
13871 (struct XMenu): Declare `help_text' `const char **'.
13872
13873 * xfaces.c <Qunspecified>: Make extern again.
13874
13875 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13876 required by POSIX.
1b2de274 13877
762b15be
EZ
13878 * doc.c (get_doc_string): Improve the format passed to `error'.
13879
13880 * doprnt.c (doprnt): Improve commentary.
13881
13882 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13883
13884 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13885 them with etags.
13886
f1052e5d
EZ
13887 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13888 changes in globals.h immediately force recompilation.
762b15be
EZ
13889 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13890 $(CURDIR)/s/ms-w32.h.
13891 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13892
fa6996bc
EZ
13893 * character.c (Fchar_direction): Function deleted.
13894 (syms_of_character): Don't defsubr it.
13895 <char-direction-table>: Deleted.
13896
e6c3da20
EZ
138972011-04-23 Eli Zaretskii <eliz@gnu.org>
13898
13899 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13900 * doprnt.c: Include limits.h.
13901 (SIZE_MAX): New macro.
04f2d78b
CB
13902 (doprnt): Return a size_t value. 2nd arg is now size_t.
13903 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13904 Improve overflow protection. Support `l' modifier for integer
13905 conversions. Support %l conversion. Don't assume an EMACS_INT
13906 argument for integer conversions and for %c.
13907
13908 * lisp.h (doprnt): Restore prototype.
13909
13910 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13911 $(SRC)/character.h.
13912
13913 * Makefile.in (base_obj): Add back doprnt.o.
13914
13915 * deps.mk (doprnt.o): Add back prerequisites.
13916 (callint.o): Depend on character.h.
13917
13918 * eval.c (internal_lisp_condition_case): Include the handler
13919 representation in the error message.
13920 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13921 when breaking from the loop.
13922
13923 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13924
13925 * callint.c (Fcall_interactively): When displaying error message
13926 about invalid control letter, pass the character's codepoint, not
13927 a pointer to its multibyte form. Improve display of the character
13928 in octal and display also its hex code.
13929
13930 * character.c (char_string): Use %x to display the (unsigned)
13931 codepoint of an invalid character, to avoid displaying a bogus
13932 negative value.
13933
13934 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13935 `error', not SYMBOL_NAME itself.
13936
13937 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13938 character arguments to `error'.
13939
13940 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13941 to `error' in error message about FINAL_CHAR argument. Make sure
13942 FINAL_CHAR is a character, and use %c when it is passed as
13943 argument to `error'.
13944
4ffd0d6b 139452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13946
13947 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13948
13949 * w32.c: Include <time.h>.
13950 (sys_localtime): New function.
13951
4ffd0d6b 139522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13953
13954 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13955
4ffd0d6b 13956 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13957
4ffd0d6b 139582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13959
4ffd0d6b
GM
13960 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13961 zombies (Bug#8467).
aac0c6e3 13962
04c56954
EZ
139632011-04-19 Eli Zaretskii <eliz@gnu.org>
13964
13965 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13966 gl_state.e_property when gl_state.object is Qt.
13967
13968 * insdel.c (make_gap_larger): Remove limitation of buffer size
13969 to <= INT_MAX.
13970
16a43933
CY
139712011-04-18 Chong Yidong <cyd@stupidchicken.com>
13972
13973 * xdisp.c (lookup_glyphless_char_display)
13974 (produce_glyphless_glyph): Handle cons cell entry in
13975 glyphless-char-display.
13976 (Vglyphless_char_display): Document it.
13977
13978 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13979 glyphless-char-display.
13980
4581706e
CY
139812011-04-17 Chong Yidong <cyd@stupidchicken.com>
13982
13983 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13984
13985 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13986
13987 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13988 definition for no-X builds.
13989
4887c6e2 139902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13991
fd35b6f9
PE
13992 Static checks with GCC 4.6.0 and non-default toolkits.
13993
5c1ccb01
PE
13994 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13995
006c5daa
PE
13996 * process.c (keyboard_bit_set): Define only if SIGIO.
13997 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13998 (send_process): Repair possible setjmp clobbering.
13999
efc736d3
PE
14000 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
14001
4e2fe2e6
PE
14002 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
14003
f97334a2
PE
14004 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
14005
4e75f29d
PE
14006 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
14007 Define only if needed.
14008
90efadd1
PE
14009 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
14010 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 14011 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 14012
3c647824
PE
14013 * dispextern.h (struct redisplay_interface): Rename param
14014 to avoid shadowing.
e264f262 14015 * termhooks.h (struct terminal): Likewise.
761383f4 14016 * xterm.c (xembed_send_message): Likewise.
3c647824 14017
b58c5c4a
PE
14018 * insdel.c (make_gap_smaller): Define only if
14019 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
14020
cad59032
PE
14021 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
14022 it.
14023
c339dc2e
PE
14024 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
14025 so that we aren't warned about unused symbols.
14026
91a3e27b
PE
14027 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
14028
399c71d3 14029 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 14030
8ffc96f5
PE
14031 * xfns.c (x_real_positions): Mark locals as initialized.
14032
eef9bc79
PE
14033 * xmenu.c (xmenu_show): Don't use uninitialized vars.
14034
098db9dd
PE
14035 * xterm.c: Fix problems found by static analysis with other toolkits.
14036 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
14037 (x_dispatch_event): Declare static if USE_GTK, and
14038 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 14039 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 14040 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
14041 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
14042 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 14043
eb18f6cc
PE
14044 * xmenu.c (menu_help_callback): Pointer type fixes.
14045 Use const pointers when pointing at readonly data. Avoid pointer
14046 signedness clashes.
14047 (FALSE): Remove unused macro.
14048 (update_frame_menubar): Remove unused decl.
14049
1fe72bf8
PE
14050 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
14051
60d9e1db
PE
14052 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
14053 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
14054 (single_menu_item): Rename local to avoid shadowing.
14055
39261c26
PE
14056 * keyboard.c (make_lispy_event): Remove unused local var.
14057
018c5e19
PE
14058 * frame.c, frame.h (x_get_resource_string): Bring this back, but
14059 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
14060
63d2b86e
PE
14061 * bitmaps: Change bitmaps from unsigned char back to the X11
14062 compatible char. Avoid the old compiler warnings about
14063 out-of-range initializers by using, for example, '\xab' rather
14064 than 0xab.
14065
aefd87e1
PE
14066 * xgselect.c (xgselect_initialize): Check vs interface
14067 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14068
bf501fb9
PE
14069 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
14070
e9829fdf
PE
14071 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
14072 to read-only memory.
14073
1086c095
PE
14074 * fns.c (vector): Remove; this old hack is no longer needed.
14075
2baccd04 14076 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 14077 Remove unused var.
dde42981 14078 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 14079
72391843 14080 * xrdb.c (x_load_resources): Omit unused local.
3565b346 14081
436c16df 14082 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 14083 (x_window): Rename locals to avoid shadowing.
dc5ddd85 14084 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14085
92bb796d 14086 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 14087 (x_term_init): Remove local to avoid shadowing.
92bb796d 14088
764430a3 14089 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
14090
14091 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
14092 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
14093
d1dfb56c
EZ
140942011-04-16 Eli Zaretskii <eliz@gnu.org>
14095
c4354cb4
EZ
14096 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
14097
d1dfb56c
EZ
14098 Fix regex.c, syntax.c and friends for buffers > 2GB.
14099 * syntax.h (struct gl_state_s): Declare character position members
14100 EMACS_INT.
14101
14102 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
14103
04f2d78b
CB
14104 * textprop.c (verify_interval_modification, interval_of):
14105 Declare arguments EMACS_INT.
d1dfb56c
EZ
14106
14107 * intervals.c (adjust_intervals_for_insertion): Declare arguments
14108 EMACS_INT.
14109
14110 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
14111
14112 * indent.c (Fvertical_motion): Local variable it_start is now
14113 EMACS_INT.
14114
14115 * regex.c (re_match, re_match_2, re_match_2_internal)
14116 (bcmp_translate, regcomp, regexec, print_double_string)
14117 (group_in_compile_stack, re_search, re_search_2, regex_compile)
14118 (re_compile_pattern, re_exec): Declare arguments and local
14119 variables `size_t' and `ssize_t' and return values `regoff_t', as
14120 appropriate.
14121 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
14122 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
14123 <compile_stack_type>: `size' and `avail' are now `size_t'.
14124
14125 * regex.h <regoff_t>: Use ssize_t, not int.
14126 (re_search, re_search_2, re_match, re_match_2): Arguments that
14127 specify buffer/string position and length are now ssize_t and
14128 size_t. Return type is regoff_t.
14129
613052cd
BK
141302011-04-16 Ben Key <bkey76@gmail.com>
14131
14132 * nsfont.m: Fixed bugs in ns_get_family and
14133 ns_descriptor_to_entity that were caused by using free to
14134 deallocate memory blocks that were allocated by xmalloc (via
14135 xstrdup). This caused Emacs to crash when compiled with
14136 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
14137 --enable-checking=xmallocoverrun). xfree is now used to
14138 deallocate these memory blocks.
14139
4170f62f 141402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 14141
71b41406
PE
14142 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
14143
9587a89d
PE
14144 emacs_write: Accept and return EMACS_INT for sizes.
14145 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
14146 et seq.
14147 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
14148 Accept and return EMACS_INT.
14149 (emacs_gnutls_write): Return the number of bytes written on
14150 partial writes.
14151 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
14152 (emacs_read, emacs_write): Remove check for negative size, as the
14153 Emacs source code has been audited now.
9587a89d
PE
14154 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
14155 (emacs_read, emacs_write): Use it.
273a5f82
PE
14156 * process.c (send_process): Adjust to the new signatures of
14157 emacs_write and emacs_gnutls_write. Do not attempt to store
14158 a byte offset into an 'int'; it might overflow.
9587a89d 14159 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 14160
3e047f51
PE
14161 * sound.c: Don't assume sizes fit in 'int'.
14162 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 14163 Return EMACS_INT, not int.
3e047f51 14164 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
14165 Accept EMACS_INT, not int.
14166 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
14167 record read return values.
14168
cc39a9db
BK
141692011-04-15 Ben Key <bkey76@gmail.com>
14170
c9d0ec6d
JB
14171 * keyboard.c (Qundefined): Don't declare static since it is used
14172 in nsfns.m.
14173 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
14174 static since they are used in nsfont.m.
cc39a9db 14175
6c60eb9f
SM
141762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
14177
14178 * process.c (Qprocessp): Don't declare static.
14179 * lisp.h (Qprocessp): Declare again.
14180
7990b61a
JB
141812011-04-15 Juanma Barranquero <lekktu@gmail.com>
14182
14183 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
14184
5d4cb038
PE
141852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
14186
8bd7b830 14187 Improve C-level modularity by making more things 'static'.
cd64ea1d 14188
e3b27b31
PE
14189 Don't publish debugger-only interfaces to other modules.
14190 * lisp.h (safe_debug_print, debug_output_compilation_hack):
14191 (verify_bytepos, count_markers): Move decls to the only modules
14192 that need them.
14193 * region-cache.h (pp_cache): Likewise.
14194 * window.h (check_all_windows): Likewise.
14195 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
14196
5d4cb038
PE
14197 * sysdep.c (croak): Now static, if
14198 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
14199 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14200
14201 * alloc.c (refill_memory_reserve): Now static if
14202 !defined REL_ALLOC || defined SYSTEM_MALLOC.
14203 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 14204
e87b6180
PE
14205 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
14206 Define only if USE_LUCID.
14207
ac64929e
PE
14208 * xrdb.c (x_customization_string, x_rm_string): Now static.
14209
6f37259d
PE
14210 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
14211 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
14212
1683e3ab
PE
14213 * xdisp.c (draw_row_with_mouse_face): Now static.
14214 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
14215
de9c2632
PE
14216 * window.h (check_all_windows): Mark externally visible.
14217
2b96acb7
PE
14218 * window.c (window_deletion_count): Now static.
14219
14220 * undo.c: Make symbols static if they're not exported.
14221 (last_undo_buffer, last_boundary_position, pending_boundary):
14222 Now static.
14223
50436f33
PE
14224 * textprop.c (interval_insert_behind_hooks): Now static.
14225 (interval_insert_in_front_hooks): Likewise.
14226
64520e5c
PE
14227 * term.c: Make symbols static if they're not exported.
14228 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
14229 (max_frame_lines, tty_set_terminal_modes):
14230 (tty_reset_terminal_modes, tty_turn_off_highlight):
14231 (get_tty_terminal): Now static.
14232 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
14233 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 14234 HAVE_WINDOW_SYSTEM.
64520e5c
PE
14235 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
14236 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
14237
1fa53021
PE
14238 * sysdep.c: Make symbols static if they're not exported.
14239 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
14240 Now static.
14241 (sigprocmask_set, full_mask): Remove; unused.
14242 (wait_debugging): Mark as visible.
14243 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
14244 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
14245
d4b43b22
PE
14246 * syntax.c (syntax_temp): Define only if !__GNUC__.
14247
b7c513d0
PE
14248 * sound.c (current_sound_device, current_sound): Now static.
14249
989b29ad
PE
14250 * search.c (searchbufs, searchbuf_head): Now static.
14251
13a55a78
PE
14252 * scroll.c (scroll_cost): Remove; unused.
14253 * dispextern.h (scroll_cost): Remove decl.
14254
de68a1fc
PE
14255 * region-cache.h (pp_cache): Mark as externally visible.
14256
40ccffa6
PE
14257 * process.c: Make symbols static if they're not exported.
14258 (process_tick, update_tick, create_process, chan_process):
14259 (Vprocess_alist, proc_buffered_char, datagram_access):
14260 (fd_callback_data, send_process_frame, process_sent_to): Now static.
14261 (deactivate_process): Mark defn as static, as well as decl.
14262 * lisp.h (create_process): Remove decl.
14263 * process.h (chan_process, Vprocess_alist): Remove decls.
14264
ad64fc97
PE
14265 * print.c: Make symbols static if they're not exported.
14266 (print_depth, new_backquote_output, being_printed, print_buffer):
14267 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
14268 (print_interval, print_number_index, initial_stderr_stream):
14269 Now static.
14270 * lisp.h (Fprinc): Remove decl.
14271 (debug_output_compilation_hack): Mark as externally visible.
14272
adddb265
PE
14273 * sysdep.c (croak): Move decl from here to syssignal.h.
14274 * syssignal.h (croak): Put it here, so the API can be checked when
14275 'croak' is called from dissociate_if_controlling_tty.
14276
1717ede2
PE
14277 * minibuf.c: Make symbols static if they're not exported.
14278 (minibuf_save_list, choose_minibuf_frame): Now static.
14279 * lisp.h (choose_minibuf_frame): Remove decl.
14280
fa5fb2bc
PE
14281 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
14282
1e3890d1
PE
14283 * lread.c: Make symbols static if they're not exported.
14284 (read_objects, initial_obarray, oblookup_last_bucket_number):
14285 Now static.
14286 (make_symbol): Remove; unused.
14287 * lisp.h (initial_obarray, make_symbol): Remove decls.
14288
8a1414fa
PE
14289 * keyboard.c: Make symbols static if they're not exported.
14290 (single_kboard, recent_keys_index, total_keys, recent_keys):
14291 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
14292 (this_single_command_key_start, echoing, last_auto_save):
14293 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
14294 (command_loop, echo_now, keyboard_init_hook, help_char_p):
14295 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
14296 (Vlispy_mouse_stem, double_click_count):
14297 Now static.
14298 (force_auto_save_soon): Define only if SIGDANGER.
14299 (ignore_mouse_drag_p): Now static if
14300 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
14301 (print_help): Remove; unused.
14302 (stop_character, last_timer_event): Mark as externally visible.
14303 * keyboard.h (ignore_mouse_drag_p): Declare only if
14304 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
14305 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
14306 * lisp.h (echoing): Remove decl.
14307 (force_auto_save_soon): Declare only if SIGDANGER.
14308 * xdisp.c (redisplay_window): Simplify code, to make it more
14309 obvious that ignore_mouse_drag_p is not accessed if !defined
14310 USE_GTK && !defined HAVE_NS.
14311
93ea6e8f
PE
14312 * intervals.c: Make symbols static if they're not exported.
14313 (merge_properties_sticky, merge_interval_right, delete_interval):
14314 Now static.
14315 * intervals.h (merge_interval_right, delete_interval): Remove decls.
14316
77382fcc
PE
14317 * insdel.c: Make symbols static if they're not exported.
14318 However, leave prepare_to_modify_buffer alone. It's never
14319 called from outside this function, but that appears to be a bug.
14320 (combine_after_change_list, combine_after_change_buffer):
4889fc82 14321 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
14322 (adjust_after_replace_noundo): Remove; unused.
14323 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 14324 (signal_before_change): Remove decls.
77382fcc 14325
9306c32e
PE
14326 * indent.c (val_compute_motion, val_vmotion): Now static.
14327
cd44d2eb
PE
14328 * image.c: Make symbols static if they're not exported.
14329 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
14330 if USE_GTK.
14331 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
14332 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
14333
ad9a7a06
PE
14334 * fringe.c (standard_bitmaps): Now static.
14335 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
14336
81626931
PE
14337 * frame.c: Make symbols static if they're not exported.
14338 (x_report_frame_params, make_terminal_frame): Now static.
14339 (get_frame_param): Now static, unless HAVE_NS.
14340 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
14341 (x_get_resource_string): Remove; not used.
14342 * frame.h (make_terminal_frame, x_report_frame_params):
14343 (x_get_resource_string); Remove decls.
14344 (x_fullscreen_adjust): Declare only if WINDOWSNT.
14345 * lisp.h (get_frame_param): Declare only if HAVE_NS.
14346
239f9db9
PE
14347 * font.c, fontset.c: Make symbols static if they're not exported.
14348 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
14349 (FACE_SUITABLE_FOR_CHAR_P): Use it.
14350 * font.c (font_close_object): Now static.
14351 * font.h (font_close_object): Remove.
14352 * fontset.c (FONTSET_OBJLIST): Remove.
14353 (free_realized_fontset) #if-0 the body, which does nothing.
14354 (face_suitable_for_char_p): #if-0, as it's never called.
14355 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
14356 * xfaces.c (face_at_string_position):
14357 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
14358 since 0 is always ASCII.
14359
dfcf3579
PE
14360 * fns.c (weak_hash_tables): Now static.
14361
5045092b
PE
14362 * fileio.c: Make symbols static if they're not exported.
14363 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
14364 (Vwrite_region_annotation_buffers): Now static.
14365
57a96f5c
PE
14366 * eval.c: Make symbols static if they're not exported.
14367 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
14368 * lisp.h (backtrace_list): Remove decl.
14369
35f08c38
PE
14370 * emacs.c: Make symbols static if they're not exported.
14371 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
14372 (fatal_error_code, fatal_error_signal_hook, standard_args):
14373 Now static.
14374 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
14375 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
14376 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
14377 * lisp.h (fatal_error_signal_hook): Remove decl.
14378 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
14379
f44bd759
PE
14380 * editfns.c: Move a (normally-unused) function to its only use.
14381 * editfns.c, lisp.h (get_operating_system_release): Remove.
14382 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
14383 worth the hassle of breaking this out.
14384
b532497d
PE
14385 * xterm.c: Make symbols static if they're not exported.
14386 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
14387 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
14388 (x_destroy_window, x_delete_display):
14389 Now static.
14390 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
14391 (x_mouse_leave): Remove; unused.
14392 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
14393 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
14394 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
14395 Remove decls.
14396 (x_mouse_leave): Declare only if WINDOWSNT.
14397 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
14398 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
14399 USE_X_TOOLKIT.
14400
1675728f
PE
14401 * ftxfont.c: Make symbols static if they're not exported.
14402 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
14403 HAVE_FREETYPE.
14404 * font.h (ftxfont_driver): Likewise.
14405
e4cebfca
PE
14406 * xfns.c: Make symbols static if they're not exported.
14407 (x_last_font_name, x_display_info_for_name):
14408 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
14409 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
14410 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
14411 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
14412 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
14413 (last_show_tip_args): Now static.
14414 (xic_defaut_fontset, xic_create_fontsetname): Define only if
14415 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
14416 (x_screen_planes): Remove; unused.
14417 * dispextern.h (x_screen_planes): Remove decl.
14418
5bf46f05
PE
14419 * dispnew.c: Make symbols static if they're not exported.
14420 * dispextern.h (redraw_garbaged_frames, scrolling):
14421 (increment_row_positions): Remove.
14422 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
14423 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
14424 Now static.
14425 (redraw_garbaged_frames): Remove; unused.
14426
435f4c28
PE
14427 * xfaces.c: Make symbols static if they're not exported.
14428 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
14429 Remove decls.
14430 * xterm.h (defined_color): Remove decls.
14431 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
14432 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
14433 (menu_face_changed_default, defined_color, free_realized_face):
14434 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
14435 (ascii_face_of_lisp_face): Remove; unused.
14436
8524aef3
PE
14437 * xdisp.c: Make symbols static if they're not exported.
14438 * dispextern.h (scratch_glyph_row, window_box_edges):
14439 (glyph_to_pixel_coords, set_cursor_from_row):
14440 (get_next_display_element, set_iterator_to_next):
14441 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
14442 (show_mouse_face): Remove decls
14443 * frame.h (message_buf_print): Likewise.
14444 * lisp.h (pop_message, set_message, check_point_in_composition):
14445 Likewise.
14446 * xterm.h (set_vertical_scroll_bar): Likewise.
14447 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
14448 (message_buf_print, scratch_glyph_row, displayed_buffer):
14449 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
14450 (get_next_display_element, show_mouse_face, window_box_edges):
14451 (frame_to_window_pixel_xy, check_point_in_composition):
14452 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
14453 (glyph_to_pixel_coords): Remove; unused.
14454
16390cd2
PE
14455 * dired.c (file_name_completion): Now static.
14456
14457 * dbusbind.c (xd_in_read_queued_messages): Now static.
14458
a25f4dfa
PE
14459 * lisp.h (circular_list_error, FOREACH): Remove; unused.
14460 * data.c (circular_list_error): Remove.
14461
14a9c8df
PE
14462 * commands.h (last_point_position, last_point_position_buffer):
14463 (last_point_position_window): Remove decls.
14464 * keyboard.c: Make these variables static.
14465
04f2d78b
CB
14466 * coding.h (coding, code_convert_region, encode_coding_gap):
14467 Remove decls.
74ab6df5
PE
14468 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
14469 (iso_code_class, detect_coding, code_convert_region): Now static.
14470 (encode_coding_gap): Remove; unused.
14471
38dfbee1
PE
14472 * chartab.c (chartab_chars, chartab_bits): Now static.
14473
a2cb4e63
PE
14474 * charset.h (charset_iso_8859_1): Remove decl.
14475 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
14476 Now static.
14477
127198fd
PE
14478 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
14479 * ccl.c (Vccl_program_table): Now static.
14480 (check_ccl_update): Remove; unused.
14481
d85b608f
PE
14482 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
14483 * category.h: ... from here.
14484 * category.c (check_category_table, set_category_set): Now static.
14485
31cd66f3
PE
14486 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
14487 * lisp.h: Remove these decls.
14488
c358e587
PE
14489 * buffer.c (buffer_count): Remove unused var.
14490
e78aecca
PE
14491 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
14492 so that it's not optimized away.
14493 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
14494 * dispextern.h (bidi_dump_cached_states): Remove, since it's
14495 exported only to the debugger.
14496
e192d7d3 14497 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 14498 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 14499
92470028
PE
14500 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
14501 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
14502 was inaccessible from Lisp.
14503 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
14504 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
14505
244ed907
PE
14506 alloc.c: Import and export fewer symbols, and remove unused items.
14507 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
14508 is defined.
14509 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
14510 it's not optimized away by whole-program optimization.
14511 (message_enable_multibyte, free_misc): Remove.
14512 (catchlist, handlerlist, mark_backtrace):
14513 Declare only if BYTE_MARK_STACK.
14514 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
14515 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
14516 (message_enable_multibyte): Remove decl.
14517 (free_misc, interval_free_list, float_block, float_block_index):
14518 (n_float_blocks, float_free_list, cons_block, cons_block_index):
14519 (cons_free_list, last_marked_index):
14520 Now static.
14521 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
14522 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
14523 (mark_backtrace): Define only if BYTE_MARK_STACK.
14524 * xdisp.c (message_enable_multibyte): Now static.
14525
61c2b50e 14526 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
14527 This makes it easier for human readers (and static analyzers)
14528 to see whether these variables are used from other modules.
14529 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
14530 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
14531 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
14532 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
14533 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
14534 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
14535 * xmenu.c, xselect.c:
14536 Declare Q* vars static if they are not used in other modules.
14537 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
14538 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
14539 Remove decls of unexported vars.
14540 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
14541
95c82688
PE
14542 * lisp.h (DEFINE_FUNC): Make sname 'static'.
14543
16a97296
PE
14544 Make Emacs functions such as Fatom 'static' by default.
14545 This makes it easier for human readers (and static analyzers)
14546 to see whether these functions can be called from other modules.
14547 DEFUN now defines a static function. To make the function external
14548 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
14549 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
14550 (Finit_image_library):
16a97296
PE
14551 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
14552 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
14553 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
14554 Remove decls, since these functions are now static.
14555 (Funintern, Fget_internal_run_time): New decls, since these functions
14556 were already external.
95c82688 14557
16a97296
PE
14558 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
14559 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
14560 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
14561 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
14562 * keyboard.c, keymap.c, lread.c:
14563 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
14564 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
14565 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
14566 Mark functions with DEFUE instead of DEFUN,
14567 if they are used in other modules.
14568 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
14569 decls for now-static functions.
14570 * buffer.h (Fdelete_overlay): Remove decl.
14571 * callproc.c (Fgetenv_internal): Mark as internal.
14572 * composite.c (Fremove_list_of_text_properties): Remove decl.
14573 (Fcomposition_get_gstring): New forward static decl.
14574 * composite.h (Fcomposite_get_gstring): Remove decl.
14575 * dired.c (Ffile_attributes): New forward static decl.
14576 * doc.c (Fdocumntation_property): New forward static decl.
14577 * eval.c (Ffetch_bytecode): New forward static decl.
14578 (Funintern): Remove extern decl; now in .h file where it belongs.
14579 * fileio.c (Fmake_symbolic_link): New forward static decl.
14580 * image.c (Finit_image_library): New forward static decl.
14581 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
14582 * intervals.h (Fprevious_property_change):
14583 (Fremove_list_of_text_properties): Remove decls.
14584 * keyboard.c (Fthis_command_keys): Remove decl.
14585 (Fcommand_execute): New forward static decl.
14586 * keymap.c (Flookup_key): New forward static decl.
14587 (Fcopy_keymap): Now static.
14588 * keymap.h (Flookup_key): Remove decl.
14589 * process.c (Fget_process): New forward static decl.
14590 (Fprocess_datagram_address): Mark as internal.
14591 * syntax.c (Fsyntax_table_p): New forward static decl.
14592 (skip_chars): Remove duplicate decl.
14593 * textprop.c (Fprevious_property_change): New forward static decl.
14594 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
14595 Now internal.
14596 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
14597 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
14598
785bbd42
PE
14599 * editfns.c (Fformat): Remove unreachable code.
14600
8b913b57
AS
146012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
14602
14603 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
14604 change. (Bug#8496)
14605
a6744a35
EZ
146062011-04-13 Eli Zaretskii <eliz@gnu.org>
14607
14608 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
14609 when at ZV. (Bug#8487)
14610
e7974947
AS
146112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
14612
baad03f0
AS
14613 * charset.c (Fclear_charset_maps): Use xfree instead of free.
14614 (Bug#8437)
14615 * keyboard.c (parse_tool_bar_item): Likewise.
14616 * sound.c (sound_cleanup, alsa_close): Likewise.
14617 * termcap.c (tgetent): Likewise.
14618 * xfns.c (x_default_font_parameter): Likewise.
14619 * xsettings.c (read_and_apply_settings): Likewise.
14620
e7974947
AS
14621 * alloc.c (overrun_check_malloc, overrun_check_realloc)
14622 (overrun_check_free): Protoize.
14623
28272684
PE
146242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
14625
14626 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
14627 since callers should never pass a negative size.
14628 Change the signature to match that of plain 'read' and 'write'; see
14629 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
14630 * lisp.h: Update prototypes of emacs_write and emacs_read.
14631
11997c76
EZ
146322011-04-11 Eli Zaretskii <eliz@gnu.org>
14633
14634 * xdisp.c (redisplay_window): Don't try to determine the character
14635 position of the scroll margin if the window start point w->startp
e896f03c 14636 is outside the buffer's accessible region. (Bug#8468)
11997c76 14637
8a2cbd72
EZ
146382011-04-10 Eli Zaretskii <eliz@gnu.org>
14639
14640 Fix write-region and its subroutines for buffers > 2GB.
14641 * fileio.c (a_write, e_write): Modify declaration of arguments and
14642 local variables to support buffers larger than 2GB.
14643 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
14644
14645 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
14646 argument, local variables, and return value.
14647
14648 * lisp.h: Update prototypes of emacs_write and emacs_read.
14649
14650 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
14651
4073e537 146522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 14653
1ebfdcb6
PE
14654 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
14655
b2ded58d
PE
14656 Fix more problems found by GCC 4.6.0's static checks.
14657
7d66342c
PE
14658 * xdisp.c (vmessage): Use a better test for character truncation.
14659
bbf47d44
PE
14660 * charset.c (load_charset_map): <, not <=, for optimization,
14661 and to avoid potential problems with integer overflow.
9248994d 14662 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 14663 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 14664 * editfns.c (Fformat): Likewise.
1e69125e 14665 * syntax.c (skip_chars): Likewise.
3befa583 14666
e3019616
PE
14667 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
14668 This also lets GCC 4.6.0 generate slightly better loop code.
14669
becfa255
PE
14670 * callint.c (Fcall_interactively): <, not <=, for optimization.
14671 (Fcall_interactively): Count the number of arguments produced,
14672 not the number of arguments given. This is simpler and lets GCC
14673 4.6.0 generate slightly better code.
14674
dae0cd48
PE
14675 * ftfont.c: Distingish more carefully between FcChar8 and char.
14676 The previous code passed unsigned char * to a functions like
14677 strlen and xstrcasecmp that expect char *, which does not
14678 conform to the C standard.
14679 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
14680 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
14681 char * when the C standard requires it.
14682
76032d70
PE
14683 * keyboard.c (read_char): Remove unused var.
14684
eb3f1cc8
PE
14685 * eval.c: Port to Windows vsnprintf (Bug#8435).
14686 Include <limits.h>.
14687 (SIZE_MAX): Define if the headers do not.
14688 (verror): Do not give up if vsnprintf returns a negative count.
14689 Instead, grow the buffer. This ports to Windows vsnprintf, which
14690 does not conform to C99. Problem reported by Eli Zaretskii.
14691 Also, simplify the allocation scheme, by avoiding the need for
14692 calling realloc, and removing the ALLOCATED variable.
14693
70476b54
PE
14694 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
14695
12020a9e
PE
14696 Remove invocations of doprnt, as Emacs now uses vsnprintf.
14697 But keep the doprint source code for now, as we might revamp it
14698 and use it again (Bug#8435).
ea6c7ae6
PE
14699 * lisp.h (doprnt): Remove.
14700 * Makefile.in (base_obj): Remove doprnt.o.
14701 * deps.mk (doprnt.o): Remove.
14702
5fdb398c
PE
14703 error: Print 32- and 64-bit integers portably (Bug#8435).
14704 Without this change, on typical 64-bit hosts error ("...%d...", N)
14705 was used to print both 32- and 64-bit integers N, which relied on
14706 undefined behavior.
61bdb816 14707 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
14708 * lisp.h (error, verror): Mark as printf-like functions.
14709 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
14710 Report overflow in size calculations when allocating printf buffer.
14711 Do not truncate output string at its first null byte.
14712 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
14713 Truncate the output at a character boundary, since vsnprintf does not
14714 do that.
14715 * charset.c (check_iso_charset_parameter): Convert internal
14716 character to string before calling 'error', since %c now has the
14717 printf meaning.
14718 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
14719 overflow when computing char to be passed to 'error'. Do not
14720 pass Lisp_Object to 'error'; pass the integer instead.
14721 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
14722 formatted with plain %d.
14723
b189fa66
PE
14724 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
14725
bff87ef0
PE
14726 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
14727
7e2cac20
PE
14728 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
14729
ce4d90b5
PE
14730 * xterm.c (x_catch_errors): Remove duplicate declaration.
14731
266c9547
PE
14732 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14733
79c49ad2
PE
14734 * xdisp.c, lisp.h (message_nolog): Remove; unused.
14735
368f4090
JM
147362011-04-10 Jim Meyering <meyering@redhat.com>
14737
14738 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
14739 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
14740 return ssize_t not "int", and use size_t as the buffer length.
14741 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
14742 * gnutls.h: Update declarations.
14743 * process.c (read_process_output): Use ssize_t, to match.
14744 (send_process): Likewise.
14745
a32d4040
CY
147462011-04-09 Chong Yidong <cyd@stupidchicken.com>
14747
14748 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
14749
8546720e 147502011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 14751
04f2d78b
CB
14752 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
14753 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 14754
8546720e
GM
14755 * xterm.c (handle_one_xevent):
14756 * xmenu.c (create_and_show_popup_menu):
14757 * xselect.c (x_decline_selection_request)
14758 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 14759
0a2f5c1a 147602011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
14761
14762 Fix some uses of `int' instead of EMACS_INT.
14763 * search.c (string_match_1, fast_string_match)
14764 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
14765 (scan_buffer, find_next_newline_no_quit)
14766 (find_before_next_newline, search_command, Freplace_match)
14767 (Fmatch_data): Make some `int' variables be EMACS_INT.
14768
14769 * xdisp.c (display_count_lines): 3rd argument and return value now
14770 EMACS_INT. All callers changed.
14771 (pint2hrstr): Last argument is now EMACS_INT.
14772
14773 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
14774 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
14775 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
14776 (decode_coding_utf_16, decode_coding_emacs_mule)
14777 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
14778 (decode_coding_ccl, decode_coding_charset)
14779 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
14780 (decode_coding_iso_2022, decode_coding_emacs_mule)
14781 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
14782 <char_offset, last_offset>: Declare EMACS_INT.
14783 (encode_coding_utf_8, encode_coding_utf_16)
14784 (encode_coding_emacs_mule, encode_invocation_designation)
14785 (encode_designation_at_bol, encode_coding_iso_2022)
14786 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
14787 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
14788 Declare EMACS_INT.
14789 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
14790 (encode_invocation_designation): Last argument P_NCHARS is now
14791 EMACS_INT.
14792 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
14793 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
14794
14795 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
14796 All users changed.
14797
14798 * ccl.c (Fccl_execute_on_string): Declare some variables
14799 EMACS_INT.
14800
8546720e 148012011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14802
14803 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14804
4e19a977
CS
148052011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14806
14807 * process.c (Fformat_network_address): Doc fix.
14808
87302331
R
148092011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14810
ee7683eb 14811 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14812
cbb59342
CY
148132011-04-08 Chong Yidong <cyd@stupidchicken.com>
14814
14815 * keyboard.c (read_char): Call Lisp function help-form-show,
14816 instead of using internal_with_output_to_temp_buffer.
14817 (Qhelp_form_show): New var.
e0d38eeb 14818 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14819
14820 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14821
14822 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14823
e67a13ab
CY
148242011-04-06 Chong Yidong <cyd@stupidchicken.com>
14825
04f2d78b
CB
14826 * process.c (Flist_processes): Remove to Lisp.
14827 (list_processes_1): Delete.
e67a13ab 14828
973f782d
EZ
148292011-04-06 Eli Zaretskii <eliz@gnu.org>
14830
7c106b1e
EZ
14831 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14832
973f782d
EZ
14833 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14834
41cf7d1a 148352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14836
ca23cc88
PE
14837 Fix more problems found by GCC 4.6.0's static checks.
14838
f390e2d5
PE
14839 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14840
42eea0d0
PE
14841 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14842
b69769da 14843 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14844
f9541e84
PE
14845 * xdisp.c (vmessage): Mark as a printf-like function.
14846
13841b55
PE
14847 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14848
c136c10f
PE
14849 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14850
5e2d4a30
PE
14851 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14852 printf-like functions.
14853 (tiff_load): Add casts to remove these marks before passing them
14854 to system-supplied API.
14855
583f48b9
PE
14856 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14857
b25d760e
PE
14858 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14859 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14860 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14861 directly, rather than having caller test rule sign. This avoids
14862 some unnecessary tests.
14863 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14864 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14865 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14866
bc7b6697 14867 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14868 (xfont_open): Avoid unnecessary tests.
bc7b6697 14869
27ccc379
PE
14870 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14871
dcd5c89a
PE
14872 * composite.h, composite.c (composition_gstring_put_cache):
14873 Use EMACS_INT, not int, for length.
14874
b13a45c6
PE
14875 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14876 breaking out part of COMPOSITION_DECODE_RULE.
14877 (COMPOSITION_DECODE_RULE): Use it.
14878 * composite.c (get_composition_id): Remove unused local vars,
14879 by using the new macro.
14880
1e792e4d
PE
14881 * textprop.c (set_text_properties_1): Change while to do-while,
14882 since the condition is always true at first.
14883
dc6c6455 14884 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14885 (interval_deletion_adjustment): Return unsigned value.
14886 All uses changed.
dc6c6455 14887
aba7731a
PE
14888 * process.c (list_processes_1, create_pty, read_process_output):
14889 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14890 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14891 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14892 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14893 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14894
fdfc4bf3
PE
14895 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14896
fca8fe46 14897 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14898 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14899
06a0259a 14900 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14901 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14902 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14903
e7b9e80f
PE
14904 * print.c (print_error_message): Avoid int overflow.
14905
56201685
PE
14906 * font.c (font_list_entities): Redo for clarity,
14907 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14908
78834453 14909 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14910 (font_score): Avoid potential overflow in diff calculation.
78834453 14911
0bc0b309 14912 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14913 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14914
e610eaca
PE
14915 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14916
b895abce
PE
14917 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14918 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14919 can always succeed if overflow has undefined behavior.
14920
1f1d9321 14921 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14922 (wordify): Omit three unnecessary tests.
1f1d9321 14923
c59478bc
PE
14924 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14925 All callers changed. This avoids the need for an unused var.
14926
79b73827
PE
14927 * casefiddle.c (casify_region): Remove var that is set but not used.
14928
a4db5dfe
PE
14929 * dired.c (file_name_completion): Remove var that is set but not used.
14930
43aae36e
PE
14931 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14932
2a47c44d 14933 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14934 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14935
a37c69bf
PE
14936 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14937 Check for integer overflow on size calculations.
14938
328ab8e7
PE
14939 * buffer.c (Fprevious_overlay_change): Remove var that is set
14940 but not used.
14941
e5a2a5cb
PE
14942 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14943 Remove vars that are set but not used.
8d84a6eb 14944 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14945 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14946
a60e5f68
PE
14947 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14948
f661cb61 14949 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14950 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14951
f0397f5a
PE
14952 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14953 that are set but not used.
14954
8664db06 14955 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14956 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14957
6abdaa4a
PE
14958 * xselect.c (x_get_local_selection, x_handle_property_notify):
14959 Remove vars that are set but not used.
14960
0ce7538d 14961 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14962 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14963
9ae848fc
PE
14964 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14965 Remove var that is set but not used.
0b918413
PE
14966 (scroll_bar_windows_size): Now size_t, not int.
14967 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14968 Check for overflow.
9ae848fc 14969
a5a62657
PE
14970 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14971 (map_tty_color) [!defined MSDOS]: Likewise.
14972
5c5cdd39
PE
14973 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14974
66ebf983
PE
14975 * coding.c: Remove vars that are set but not used.
14976 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14977 All callers changed.
14978 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14979 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14980 (decode_coding_charset): Remove vars that are set but not used.
14981
1be4d761
PE
14982 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14983 that is set but not used.
14984
47553fa8
PE
14985 * print.c (print_object): Remove var that is set but not used.
14986
1f7196bf 14987 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14988 The gnulib version avoids calling malloc in the usual case,
14989 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14990 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14991 * filelock.c (current_lock_owner): Likewise.
14992 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14993 * sysdep.c: Include allocator.h, careadlinkat.h.
14994 (emacs_no_realloc_allocator): New static constant.
14995 (emacs_readlink): New function.
fdb61804
PE
14996 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14997 ../lib/careadlinkat.h.
d1fdcab7 14998
f84c17c7
SM
149992011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
15000
15001 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
15002 first non-nil return value).
15003
ef3862ad
JD
150042011-04-03 Jan Djärv <jan.h.d@swipnet.se>
15005
15006 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
15007 if not defined (Bug#8403).
15008
376a7006
JB
150092011-04-02 Juanma Barranquero <lekktu@gmail.com>
15010
15011 * xdisp.c (display_count_lines): Remove parameter `start',
15012 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15013 (get_char_face_and_encoding): Remove parameter `multibyte_p',
15014 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15015 (fill_stretch_glyph_string): Remove parameters `row' and `area',
15016 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
15017 and thereabouts. All callers changed.
15018 (get_per_char_metric): Remove parameter `f', unused since
15019 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
15020
6ca3801d
JM
150212011-04-02 Jim Meyering <meyering@redhat.com>
15022
15023 do not dereference NULL upon failed strdup
15024 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
15025 (ns_get_family): Likewise.
15026
d8e2b5ba
JB
150272011-04-02 Juanma Barranquero <lekktu@gmail.com>
15028
15029 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
15030
8c74fcbd
JD
150312011-04-02 Jan Djärv <jan.h.d@swipnet.se>
15032
15033 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
15034 later (Bug#8403).
15035
7200d79c
SM
150362011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
15037
03408648 15038 Add lexical binding.
7200d79c 15039
03408648
SM
15040 * window.c (Ftemp_output_buffer_show): New fun.
15041 (Fsave_window_excursion):
15042 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
15043
15044 * lread.c (lisp_file_lexically_bound_p): New function.
15045 (Fload): Bind Qlexical_binding.
15046 (readevalloop): Remove `evalfun' arg.
15047 Bind Qinternal_interpreter_environment.
15048 (Feval_buffer): Bind Qlexical_binding.
15049 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
15050 Mark as dynamic.
15051 (syms_of_lread): Declare `lexical-binding'.
15052
15053 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
15054
15055 * keyboard.c (eval_dyn): New fun.
15056 (menu_item_eval_property): Use it.
ca105506
SM
15057
15058 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 15059
03408648
SM
15060 * fns.c (concat, mapcar1): Accept byte-code-functions.
15061
15062 * eval.c (Fsetq): Handle lexical vars.
15063 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
15064 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
15065 (FletX, Flet): Obey lexical binding.
15066 (Fcommandp): Handle closures.
15067 (Feval): New `lexical' arg.
15068 (eval_sub): New function extracted from Feval. Use it almost
15069 everywhere where Feval was used. Look up vars in lexical env.
15070 Handle closures.
15071 (Ffunctionp): Move from subr.el.
15072 (Ffuncall): Handle closures.
15073 (apply_lambda): Remove `eval_flags'.
15074 (funcall_lambda): Handle closures and new byte-code-functions.
15075 (Fspecial_variable_p): New function.
15076 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
15077 but without exporting it to Lisp.
23aba0ea 15078
23aba0ea 15079 * doc.c (Fdocumentation, store_function_docstring):
03408648 15080 * data.c (Finteractive_form): Handle closures.
23aba0ea 15081
03408648
SM
15082 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
15083 interactive spec.
ba83908c 15084
04f2d78b
CB
15085 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
15086 New byte-codes.
03408648
SM
15087 (exec_byte_code): New function extracted from Fbyte_code to handle new
15088 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 15089
03408648 15090 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 15091
03408648 15092 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 15093
e2abce01
JB
150942011-03-31 Juanma Barranquero <lekktu@gmail.com>
15095
15096 * xdisp.c (redisplay_internal): Fix prototype.
15097
63696a73 150982011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 15099
63696a73 15100 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
15101 (try_scrolling): Use it when setting scroll_limit.
15102 Limit scrolling to 100 screen lines.
63696a73
EZ
15103 (redisplay_window): Even when falling back on "recentering",
15104 position point in the window according to scroll-conservatively,
15105 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
15106
15107 (try_scrolling): When point is above the window, allow searching
15108 as far as scroll_max, or one screenful, to compute vertical
15109 distance from PT to the scroll margin position. This prevents
15110 try_scrolling from unnecessarily failing when
15111 scroll-conservatively is set to a value slightly larger than the
15112 window height. Clean up the case of PT below the margin at bottom
15113 of window: scroll_max can no longer be INT_MAX. When aggressive
15114 scrolling is in use, don't let point enter the opposite scroll
15115 margin as result of the scroll.
15116 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
15117 threshold of 100 lines for never-recentering scrolling.
15118
e4cc2dfc
JB
151192011-03-31 Juanma Barranquero <lekktu@gmail.com>
15120
15121 * dispextern.h (move_it_by_lines):
15122 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
15123 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
15124 (message_log_check_duplicate): Remove parameters `prev_bol' and
15125 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
15126 (redisplay_internal): Remove parameter `preserve_echo_area',
15127 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
15128
15129 * indent.c (Fvertical_motion):
15130 * window.c (window_scroll_pixel_based, Frecenter):
15131 Don't pass `need_y_p' to `move_it_by_lines'.
15132
1c470562
SM
151332011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
15134
44f230aa
SM
15135 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
15136 steal a few bits to be more compact.
15137 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
15138 Remove unneeded casts.
15139
1c470562
SM
15140 * bytecode.c (Fbyte_code): CAR and CDR can GC.
15141
888adce9
ZK
151422011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
15143
15144 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
15145 binding" message (bug#7967).
15146
f838ed7b
PE
151472011-03-30 Paul Eggert <eggert@cs.ucla.edu>
15148
77861b95
PE
15149 Fix more problems found by GCC 4.6.0's static checks.
15150
de6dbc14
PE
15151 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
15152 Remove unused local var.
15153
f838ed7b
PE
15154 * editfns.c (Fmessage_box): Remove unused local var.
15155
792c7b2b
PE
15156 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
15157 (note_mode_line_or_margin_highlight, note_mouse_highlight):
15158 Omit unused local vars.
c499e557 15159 * window.c (shrink_windows): Omit unused local var.
b01a1c29 15160 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
15161 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
15162 Omit unused local var.
15163
ba0165e1
PE
15164 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
15165 Don't assume string length fits in int.
32ad8845 15166 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 15167 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 15168
3c59b4c9
PE
15169 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
15170 instead of alloca (Bug#8344).
15171
a3eed478 15172 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 15173 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 15174
eb4d412d
PE
15175 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
15176
1658b401
PE
15177 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
15178 concerns.
15179
15180 * term.c (produce_glyphless_glyph): Remove unnecessary test.
15181
15182 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 15183
9a2c6e05
PE
15184 * keyboard.c (syms_of_keyboard): Use the same style as later
15185 in this function when indexing through an array. This also
15186 works around GCC bug 48267.
15187
03d0a109
PE
15188 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
15189
44f730c8
PE
15190 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
15191
fe75f926
PE
15192 * chartab.c (sub_char_table_ref_and_range): Redo for slight
15193 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
15194
ffa8c828
PE
15195 * keyboard.c, keyboard.h (num_input_events): Now size_t.
15196 This avoids undefined behavior on integer overflow, and is a bit
15197 more convenient anyway since it is compared to a size_t variable.
15198
c5101a77
PE
15199 Variadic C functions now count arguments with size_t, not int.
15200 This avoids an unnecessary limitation on 64-bit machines, which
15201 caused (substring ...) to crash on large vectors (Bug#8344).
15202 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
15203 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 15204 All variadic functions and their callers changed accordingly.
c5101a77
PE
15205 (struct gcpro.nvars): Now size_t, not int. All uses changed.
15206 * data.c (arith_driver, float_arith_driver): Likewise.
15207 * editfns.c (general_insert_function): Likewise.
15208 * eval.c (struct backtrace.nargs, interactive_p)
15209 (internal_condition_case_n, run_hook_with_args, apply_lambda)
15210 (funcall_lambda, mark_backtrace): Likewise.
15211 * fns.c (concat): Likewise.
15212 * frame.c (x_set_frame_parameters): Likewise.
15213 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
15214 0 if not found, not -1. All callers changed.
15215
dd3f25f7
PE
15216 * alloc.c (garbage_collect): Don't assume stack size fits in int.
15217 (stack_copy_size): Now size_t, not int.
15218 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
15219
461c2ab9
JB
152202011-03-28 Juanma Barranquero <lekktu@gmail.com>
15221
15222 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
15223 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15224 All callers changed.
15225
15226 * lisp.h (multibyte_char_to_unibyte):
15227 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
15228 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
15229 * character.h (CHAR_TO_BYTE8):
15230 * cmds.c (internal_self_insert):
15231 * editfns.c (general_insert_function):
15232 * keymap.c (push_key_description):
15233 * search.c (Freplace_match):
15234 * xdisp.c (message_dolog, set_message_1): All callers changed.
15235
f6d62986
SM
152362011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
15237
15238 * keyboard.c (safe_run_hook_funcall): New function.
15239 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
15240 don't set the hook to nil, but remove the offending function instead.
15241 (Qcommand_hook_internal): Remove, unused.
15242 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
15243 Vcommand_hook_internal.
15244
15245 * eval.c (enum run_hooks_condition): Remove.
15246 (funcall_nil, funcall_not): New functions.
15247 (run_hook_with_args): Call each function through a `funcall' argument.
15248 Remove `cond' argument, now redundant.
15249 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
15250 (Frun_hook_with_args_until_failure): Adjust accordingly.
15251 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
15252
1db5b1ad
JB
152532011-03-28 Juanma Barranquero <lekktu@gmail.com>
15254
15255 * dispextern.h (string_buffer_position): Remove declaration.
15256
15257 * print.c (strout): Remove parameter `multibyte', unused since
15258 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
15259
15260 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
15261 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
15262 All callers changed.
15263
15264 * w32.c (_wsa_errlist): Use braces for struct initializers.
15265
15266 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
15267 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
15268 All callers changed.
15269 (string_buffer_position): Likewise. Also, make static (it's never
15270 used outside xdisp.c).
15271 (cursor_row_p): Remove parameter `w', unused since
15272 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
15273 (decode_mode_spec): Remove parameter `precision', introduced during
15274 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
15275 All callers changed.
15276
5ffb62aa
JD
152772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15278
15279 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
15280
461c2ab9 152812011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
15282
15283 * nsterm.m (ns_menu_bar_is_hidden): New variable.
15284 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
15285 (ns_update_auto_hide_menu_bar): New functions.
15286 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
15287 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
15288 ns_constrain_all_frames.
15289 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
15290 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
15291
5c380ffb
JD
152922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
15293
15294 * nsmenu.m (runDialogAt): Remove argument to timer_check.
15295
9af30bdf
GM
152962011-03-27 Glenn Morris <rgm@gnu.org>
15297
15298 * syssignal.h: Replace RETSIGTYPE with void.
15299 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
15300 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
15301 Replace SIGTYPE with void everywhere.
15302 * s/usg5-4-common.h (SIGTYPE): Remove definition.
15303 * s/template.h (SIGTYPE): Remove commented out definition.
15304
e2abce01
JB
153052011-03-26 Eli Zaretskii <eliz@gnu.org>
15306
15307 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
15308 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
15309
f868cd8a
JB
153102011-03-26 Juanma Barranquero <lekktu@gmail.com>
15311
59eb0929
JB
15312 * w32.c (read_unc_volume): Use parameter `henum', instead of
15313 global variable `wget_enum_handle'.
15314
15315 * keymap.c (describe_vector): Remove parameters `indices' and
15316 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
15317 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
15318
f868cd8a
JB
15319 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
15320
15321 * keyboard.c (timer_check): Remove parameter `do_it_now',
15322 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
15323 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
15324 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
15325
15326 * keyboard.c (read_char):
15327 * w32menu.c (w32_menu_display_help):
15328 * xmenu.c (show_help_event, menu_help_callback):
15329 Adjust calls to `show_help_echo'.
15330
15331 * gtkutil.c (xg_maybe_add_timer):
15332 * keyboard.c (readable_events):
15333 * process.c (wait_reading_process_output):
15334 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
15335
15336 * insdel.c (adjust_markers_gap_motion):
15337 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
15338 (gap_left, gap_right): Don't call it.
15339
2ecf6fdb
CY
153402011-03-25 Chong Yidong <cyd@stupidchicken.com>
15341
15342 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
15343 incurred during fontification.
15344
6b1f9ba4
JB
153452011-03-25 Juanma Barranquero <lekktu@gmail.com>
15346
15347 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
15348 (DEFVAR_PER_BUFFER): Don't pass it.
15349
15350 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
15351 (scrolling_window): Don't pass it.
15352
0f4a96b5
JB
153532011-03-25 Juanma Barranquero <lekktu@gmail.com>
15354
15355 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
15356
15357 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
15358 and `suffix'.
15359 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
15360 of variables specific to SELinux and computation of `encoded_absname'.
15361
15362 * image.c (XPutPixel): Remove unused variable `height'.
15363
15364 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
15365
15366 * unexw32.c (get_section_info): Remove unused variable `section'.
15367
15368 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
15369 (system_process_attributes): Remove unused variable `sess'.
15370 (sys_read): Remove unused variable `err'.
15371
15372 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
15373 (w32_wnd_proc): Remove unused variable `isdead'.
15374 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
15375 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
15376 (x_create_tip_frame): Remove unused variable `tem'.
15377
15378 * w32inevt.c (w32_console_read_socket):
15379 Remove unused variable `no_events'.
15380
15381 * w32term.c (x_draw_composite_glyph_string_foreground):
15382 Remove unused variable `width'.
15383
1149507c
JB
153842011-03-24 Juanma Barranquero <lekktu@gmail.com>
15385
15386 * w32term.c (x_set_glyph_string_clipping):
15387 Don't pass uninitialized region to CombineRgn.
15388
9c88f339
JB
153892011-03-23 Juanma Barranquero <lekktu@gmail.com>
15390
15391 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
15392 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
15393 (Fx_close_connection): Remove unused variable `i'.
15394
15395 * w32font.c (w32font_draw): Return number of glyphs.
15396 (w32font_open_internal): Remove unused variable `i'.
15397 (w32font_driver): Add missing initializer.
15398
15399 * w32menu.c (utf8to16): Remove unused variable `utf16'.
15400 (fill_in_menu): Remove unused variable `items_added'.
15401
15402 * w32term.c (last_mouse_press_frame): Remove static global variable.
15403 (w32_clip_to_row): Remove unused variable `f'.
15404 (x_delete_terminal): Remove unused variable `i'.
15405
15406 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
15407 (NOTHING): Remove unused static global variable.
15408 (uniscribe_check_otf): Remove unused variable `table'.
15409 (uniscribe_font_driver): Add missing initializers.
15410
dee091a3
JD
154112011-03-23 Julien Danjou <julien@danjou.info>
15412
15413 * term.c (Fsuspend_tty, Fresume_tty):
15414 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
15415 * window.c (temp_output_buffer_show):
15416 * insdel.c (signal_before_change):
15417 * frame.c (Fhandle_switch_frame):
15418 * fileio.c (Fdo_auto_save):
15419 * emacs.c (Fkill_emacs):
15420 * editfns.c (save_excursion_restore):
15421 * cmds.c (internal_self_insert):
15422 * callint.c (Fcall_interactively):
15423 * buffer.c (Fkill_all_local_variables):
15424 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
15425 Use Frun_hooks.
0f4a96b5 15426 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 15427 unconditionally since it does the check itself.
dee091a3 15428
2c520ab5 154292011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 15430
c9c49752
PE
15431 Fix more problems found by GCC 4.5.2's static checks.
15432
8abc3f12
PE
15433 * coding.c (encode_coding_raw_text): Avoid unnecessary test
15434 the first time through the loop, since we know p0 < p1 then.
15435 This also avoids a gcc -Wstrict-overflow warning.
15436
a2d26660
PE
15437 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
15438 leading to a memory leak, possible in functions like
15439 load_charset_map_from_file that can allocate an unbounded number
b12ef411 15440 of objects (Bug#8318).
a2d26660 15441
916c72e9
PE
15442 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
15443 that could (at least in theory) be that large.
15444
19ab8a18
PE
15445 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
15446 This is less likely to overflow, and avoids undefined behavior if
15447 overflow does occur. All callers changed. Use strtoul to scan
15448 for the unsigned long integer.
b7cbbd6f
PE
15449 (pint2hrstr): Simplify and tune code slightly.
15450 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 15451
f0641eff
PE
15452 * scroll.c (do_scrolling): Work around GCC bug 48228.
15453 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
15454
7f650bb9
PE
15455 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
15456 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
15457 (validate_x_resource_name): Simplify count usage.
15458 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 15459
37dd57d1
PE
15460 * fileio.c (Fcopy_file): Report error if fchown or fchmod
15461 fail (Bug#8306).
81e56e61 15462
699979fc 15463 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 15464
401bf9b4
PE
15465 * process.c (Fmake_network_process): Use socklen_t, not int,
15466 where POSIX says socklen_t is required in portable programs.
15467 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 15468 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
15469 (Fmake_network_process, server_accept_connection):
15470 (wait_reading_process_output, read_process_output):
15471 Likewise.
15472
b93aacde
PE
15473 * process.c: Rename or move locals to avoid shadowing.
15474 (list_processes_1, Fmake_network_process):
15475 (read_process_output_error_handler, exec_sentinel_error_handler):
15476 Rename or move locals.
4dc343ee 15477 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 15478 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 15479 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 15480 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 15481 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 15482
af8a867c 15483 Make tparam.h and terminfo.c consistent.
44f230aa
SM
15484 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
15485 Include tparam.h instead, since it declares them.
af8a867c
PE
15486 * cm.h (PC): Remove extern decl; tparam.h now does this.
15487 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
15488 * terminfo.c: Include tparam.h, to check interfaces.
15489 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
15490 (tparam): Adjust signature to match interface in tparam.h;
15491 this removes some undefined behavior. Check that outstring and len
15492 are zero, which they always are with Emacs.
15493 * tparam.h (PC, BC, UP): New extern decls.
15494
0248044d 15495 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 15496 (xftfont_open): Rename locals to avoid shadowing.
0248044d 15497
8ff096c1 15498 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
15499 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
15500 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 15501 (ftfont_list): Remove unused local.
49eaafba
PE
15502 (get_adstyle_property, ftfont_pattern_entity):
15503 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
15504 Rename locals to avoid shadowing.
8ff096c1 15505
e2be39f6
PE
15506 * xfont.c (xfont_list_family): Mark var as initialized.
15507
c9735e30
PE
15508 * xml.c (make_dom): Now static.
15509
8f5201ae
PE
15510 * composite.c (composition_compute_stop_pos): Rename local to
15511 avoid shadowing.
b246f932
PE
15512 (composition_reseat_it): Remove unused locals.
15513 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 15514 (composition_update_it): Mark var as initialized.
11b61122
PE
15515 (find_automatic_composition): Mark vars as initialized,
15516 with a FIXME (Bug#8290).
8f5201ae 15517
760fbc2c
PE
15518 character.h: Rename locals to avoid shadowing.
15519 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
15520 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
15521 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
15522 (BUF_DEC_POS): Be more systematic about renaming local temporaries
15523 to avoid shadowing.
15524
ff08eb85
PE
15525 * textprop.c (property_change_between_p): Remove; unused.
15526
fc7bf025
PE
15527 * intervals.c (interval_start_pos): Now static.
15528
235d7abc
PE
15529 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
15530
44f230aa
SM
15531 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
15532 Rename locals to avoid shadowing.
3e7d6594 15533
50060332
PE
15534 * sound.c (wav_play, au_play, Fplay_sound_internal):
15535 Fix pointer signedness.
d01f234b 15536 (alsa_choose_format): Remove unused local var.
c83b8872
PE
15537 (wav_play): Initialize a variable to 0, to prevent undefined
15538 behavior (Bug#8278).
50060332 15539
c4fc4e30
PE
15540 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
15541
918436ed
PE
15542 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
15543
c939f91b
PE
15544 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
15545 clobbering (Bug#8298).
b9c7f648
PE
15546 * sysdep.c (sys_subshell): Likewise.
15547 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 15548
6bd8c144
PE
15549 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
15550 This should get cleaned up, so that child_setup has the
15551 same signature on all platforms.
15552
7710357c 15553 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 15554 (relocate_fd): Rename locals to avoid shadowing.
7710357c 15555
c59da222
CY
155562011-03-22 Chong Yidong <cyd@stupidchicken.com>
15557
15558 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
15559 not to be necessary, and produces flickering.
15560
66b87493
GM
155612011-03-20 Glenn Morris <rgm@gnu.org>
15562
15563 * config.in: Remove file.
15564
45b6f6d5
JB
155652011-03-20 Juanma Barranquero <lekktu@gmail.com>
15566
15567 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
15568 are now in src/globals.h.
15569 (syms_of_minibuf): Remove spurious & from previous change.
15570
cd394be1 155712011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
15572
15573 * minibuf.c (completing-read-function): New variable.
15574 (completing-read-default): Rename from completing-read.
15575 (completing-read): Call completing-read-function.
15576
b14e3e21
CY
155772011-03-19 Juanma Barranquero <lekktu@gmail.com>
15578
15579 * xfaces.c (Fx_load_color_file):
15580 Read color file from absolute filename (bug#8250).
15581
f2b726e6
JB
155822011-03-19 Juanma Barranquero <lekktu@gmail.com>
15583
15584 * makefile.w32-in: Update dependencies.
15585
09f6ff02
EZ
155862011-03-17 Eli Zaretskii <eliz@gnu.org>
15587
15588 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
15589
29a6015a
PE
155902011-03-17 Paul Eggert <eggert@cs.ucla.edu>
15591
a3a6c54e
PE
15592 Fix more problems found by GCC 4.5.2's static checks.
15593
b766f867
PE
15594 * process.c (make_serial_process_unwind, send_process_trap):
15595 (sigchld_handler): Now static.
15596
be02381c
PE
15597 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
15598 That way, the code declares only the vars that it needs.
15599 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
15600 * s/cygwin.h (PTY_ITERATION): Likewise.
15601 * s/darwin.h (PTY_ITERATION): Likewise.
15602 * s/gnu-linux.h (PTY_ITERATION): Likewise.
15603
57048744
PE
15604 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
15605 * process.c (allocate_pty): Don't declare stb unless it's needed.
15606
7914961c 15607 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
15608 (CONSTANTLIM): Remove; unused.
15609 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
15610 Define only if needed.
7914961c 15611
b3967b18
PE
15612 * unexelf.c (unexec): Name an expression,
15613 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
15614 Use a different way to cause a compilation error if anyone uses
15615 n rather than nn, a way that does not involve shadowing.
73366a00 15616 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 15617
29a6015a
PE
15618 * deps.mk (unexalpha.o): Remove; unused.
15619
43cfc33e 15620 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 15621 * unexec.h: New file.
ce701a33
PE
15622 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
15623 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
15624 Depend on unexec.h.
15625 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
15626 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
15627 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 15628 Change as necessary to match prototype in unexec.h.
ce701a33 15629
01f44d5a
PE
15630 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
15631 shadowing.
4f63c6bb 15632 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 15633
a6670b0b
PE
15634 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
15635 Rename locals to avoid shadowing.
15636
cef2010d 15637 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 15638 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 15639
d4d7173a
PE
15640 * print.c (Fredirect_debugging_output): Fix pointer signedess.
15641
f08b802a
PE
15642 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
15643 warning when compiling print.c.
15644
3ddb0639
PE
15645 * font.c (font_unparse_fcname): Abort in an "impossible" situation
15646 instead of using an uninitialized var.
5ad03b97 15647 (font_sort_entities): Mark var as initialized.
3ddb0639 15648
170a2692
PE
15649 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
15650
e663c700
PE
15651 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
15652 pointers to constants.
89bc529a 15653 (font_parse_fcname): Remove unused vars.
7b81e2d0 15654 (font_delete_unmatched): Now static.
ea838e10 15655 (font_get_spec): Remove; unused.
13a547c6
PE
15656 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
15657 (font_update_drivers, Ffont_get_glyphs, font_add_log):
15658 Rename or move locals to avoid shadowing.
e663c700 15659
2a80c887 15660 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 15661 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 15662
1384fa33 15663 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 15664 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 15665
8b2c52e9
PE
15666 * alloc.c (mark_backtrace): Move decl from here ...
15667 * lisp.h: ... to here, so that it can be checked.
15668
475545b5 15669 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 15670 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
15671 (lisp_indirect_variable): Name an expression,
15672 to avoid gcc -Wbad-function-cast warning.
1faed8ae 15673 (Fdefvar): Rename locals to avoid shadowing.
475545b5 15674
b1349114 15675 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 15676 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 15677 Use const pointer when appropriate.
b1349114 15678
a2928364
PE
15679 * lisp.h (get_system_name, get_operating_system_release):
15680 Move decls here, to check interfaces.
15681 * process.c (get_operating_system_release): Move decl to lisp.h.
15682 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
15683 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
15684 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
15685 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
15686 (Fformat_time_string, Fencode_time, Finsert_char):
15687 (Ftranslate_region_internal, Fformat):
15688 Rename or remove local vars to avoid shadowing.
9710023e 15689 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 15690
a415e694
PE
15691 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
15692 avoid shadowing.
15693
8ef4622d
PE
15694 * lisp.h (eassert): Check that the argument compiles, even if
15695 ENABLE_CHECKING is not defined.
15696
946f9a5b
PE
15697 * data.c (Findirect_variable): Name an expression, to avoid
15698 gcc -Wbad-function-cast warning.
112396d6 15699 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 15700 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
15701 (Fmake_variable_buffer_local, Fmake_local_variable):
15702 Mark variables as initialized.
52746918 15703 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 15704
e5aab7e7 15705 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
15706 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
15707 Rename locals to avoid shadowing.
dff45157
PE
15708 (mark_stack): Move local variables into the #ifdef region where
15709 they're used.
7bc26fdb
PE
15710 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
15711 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
15712 needed otherwise.
15713 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
15714 (GC_STRING_CHARS): Remove; not used.
d40d4be1 15715 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 15716
e5aab7e7
PE
15717 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
15718 avoids undefined behavior in theory.
15719
4da60324
PE
15720 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
15721
88043301
PE
15722 Use functions, not macros, for up- and down-casing (Bug#8254).
15723 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15724 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
15725 to use the following functions instead of these macros.
15726 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
15727 EMACS_INT, since callers assume the returned value fits in int.
15728 (upcase1): Likewise, for UPCASE_TABLE.
15729 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 15730 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 15731 the race-condition problem in the old DOWNCASE.
88043301 15732
19ed5445
PE
15733 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
15734 Rename locals to avoid shadowing.
15735 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
15736 (regex_compile, re_search_2, re_match_2_internal):
15737 Remove unused local vars.
952db0d7
PE
15738 (FREE_VAR): Rewrite so as not to use empty "else",
15739 which gcc can warn about.
da053e48 15740 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
15741 (RETALLOC_IF): Define only if needed.
15742 (WORDCHAR_P): Likewise. This one is never needed, but is used
15743 only in a comment talking about a compiler bug, so put inside
15744 the #if 0 of that comment.
15745 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
15746 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
15747 Remove; unused.
19ed5445 15748
1f3561e4 15749 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
15750 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
15751 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 15752
ded6f8f7
PE
15753 * search.c (simple_search): Remove unused var.
15754
dbd37a95
PE
15755 * dired.c (compile_pattern): Move decl from here ...
15756 * lisp.h: ... to here, so that it can be checked.
15757 (struct re_registers): New forward decl.
15758
7e47afad
PE
15759 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
15760
85f24f61
PE
15761 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
15762 All uses changed.
15763 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
15764 Rename locals to avoid shadowing.
5671df8f 15765 (Fvertical_motion): Mark locals as initialized.
85f24f61 15766
181aa2be 15767 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 15768 (casify_region): Mark local as initialized.
181aa2be 15769
930d429c
PE
15770 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
15771
7082eac6
PE
15772 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
15773 New macros, so that the caller can use some names other than
15774 gcpro1, gcpro2, etc.
15775 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
15776 of the new macros.
15777 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
15778 argument, for consistency with GCPRO2_VAR, etc: it is now the
15779 prefix of the variable, not the variable itself. All uses
15780 changed.
38b2c076
PE
15781 * dired.c (directory_files_internal, file_name_completion):
15782 Rename locals to avoid shadowing.
15783
15206ed9
PE
15784 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
15785 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
15786 dired.c's scmp function, had undefined behavior.
15787 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
15788 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
15789 * buffer.h: ... to here, because these macros use current_buffer,
15790 and the new implementation with inline functions needs to have
15791 current_buffer in scope now, rather than later when the macros
15792 are used.
15793 (downcase, upcase1): New static inline functions.
15794 (DOWNCASE, UPCASE1): Reimplement using these functions.
15795 This avoids undefined behavior in expressions like
15796 DOWNCASE (x) == DOWNCASE (y), which previously suffered
15797 from race conditions in accessing the global variables
15798 case_temp1 and case_temp2.
15799 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15800 * lisp.h (case_temp1, case_temp2): Remove their decls.
15801 * character.h (ASCII_CHAR_P): Move from here ...
15802 * lisp.h: ... to here, so that the inline functions mentioned
15803 above can use them.
15804
4a6bea26
PE
15805 * dired.c (directory_files_internal_unwind): Now static.
15806
f14b7e14
PE
15807 * fileio.c (file_name_as_directory, directory_file_name):
15808 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15809 Now static.
2893f146
PE
15810 (file_name_as_directory): Use const pointers when appropriate.
15811 (Fexpand_file_name): Likewise. In particular, newdir might
15812 point at constant storage, so make it a const pointer.
fd4ead52 15813 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15814 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15815 signedness issues.
f839df0c
PE
15816 (Fset_file_times, Finsert_file_contents, auto_save_error):
15817 Rename locals to avoid shadowing.
f14b7e14 15818
5716756e 15819 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15820 (Ftry_completion, Fall_completions): Rename or remove locals
15821 to avoid shadowing.
5716756e 15822
b4c3046a
PE
15823 * marker.c (bytepos_to_charpos): Remove; unused.
15824
b45db522
PE
15825 * lisp.h (verify_bytepos, count_markers): New decls,
15826 so that gcc does not warn that these functions aren't declared.
15827
85876d07
PE
15828 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15829 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15830 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15831 (copy_text): Remove unused local var.
85876d07 15832
03d78a21 15833 * filelock.c (within_one_second): Now static.
b3dd38ab 15834 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15835
5df8f01b
PE
15836 * buffer.c (fix_overlays_before): Mark locals as initialized.
15837 (fix_start_end_in_overlays): Likewise. This function should be
15838 simplified by using pointers-to-pointers, but that's a different
15839 matter.
b1d876f1 15840 (switch_to_buffer_1): Now static.
8f54f30a
PE
15841 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15842 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15843
a70072c9 15844 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15845 Fix pointer signedness issue.
edced198
PE
15846 (sys_subshell): Mark local as volatile if checking for lint,
15847 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15848 (MAXPATHLEN): Define only if needed.
a70072c9 15849
a0977c44
PE
15850 * process.c (serial_open, serial_configure): Move decls from here ...
15851 * systty.h: ... to here, so that they can be checked.
15852
a884fdcc
PE
15853 * fns.c (get_random, seed_random): Move extern decls from here ...
15854 * lisp.h: ... to here, so that they can be checked.
15855
604efe86 15856 * sysdep.c (reset_io): Now static.
b8950c94 15857 (wait_for_termination_signal): Remove; unused.
604efe86 15858
38fc62d9
PE
15859 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15860 (copy_keymap_item, append_key, push_text_char_description):
15861 Now static.
1004a21a 15862 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15863 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15864 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15865 (describe_map_tree):
15866 Rename locals to avoid shadowing.
38fc62d9 15867
2f2650da
PE
15868 * keyboard.c: Declare functions static if they are not used elsewhere.
15869 (echo_char, echo_dash, cmd_error, top_level_2):
15870 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15871 (read_char, kbd_buffer_get_event, make_lispy_position):
15872 (make_lispy_event, make_lispy_movement, apply_modifiers):
15873 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15874 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15875 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15876 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15877 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15878
a053e86c 15879 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15880 (mark_kboards): Move decl here ...
15881 * alloc.c (mark_kboards): ... from here.
a053e86c 15882
4752793e
PE
15883 * lisp.h (force_auto_save_soon): New decl.
15884
74f10ca7 15885 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15886 (DEFINE_DUMMY_FUNCTION): New macro.
15887 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15888 Use it.
c03cd23f
PE
15889 (main): Add casts to avoid warnings
15890 if GCC considers string literals to be constants.
74f10ca7 15891
022e70d4
PE
15892 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15893
59d6fe83
PE
15894 * dbusbind.c: Pointer signedness fixes.
15895 (xd_signature, xd_append_arg, xd_initialize):
15896 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15897 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15898 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15899 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15900
78320123
PE
15901 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15902 if GCC considers string literals to be constants.
49cebcca 15903 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15904
35ac2a97
SM
159052011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15906
fb103ca9
SM
15907 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15908 (print_preprocess, print_object): New macro to fix last change.
15909
35ac2a97
SM
15910 * print.c (print_preprocess): Don't forget font objects.
15911
62973b41
JB
159122011-03-16 Juanma Barranquero <lekktu@gmail.com>
15913
15914 * emacs.c (USAGE3): Doc fixes.
15915
0e48bb22
AS
159162011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15917
15918 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15919 structure.
15920
7684e57b
JB
159212011-03-14 Juanma Barranquero <lekktu@gmail.com>
15922
15923 * lisp.h (VWindow_system, Qfile_name_history):
15924 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15925 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15926 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15927
15928 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15929 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15930
15931 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15932 * w32console.c (detect_input_pending, read_input_pending)
15933 (encode_terminal_code):
15934 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15935 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15936 (w32_system_caret_y, Qfile_name_history):
15937 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15938 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15939 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15940 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15941 * w32proc.c (Qlocal, report_file_error):
15942 * w32term.c (Vwindow_system, updating_frame):
15943 * w32uniscribe.c (initialized, uniscribe_font_driver):
15944 Remove unneeded extern declarations.
15945
2aa46d6c
CY
159462011-03-14 Chong Yidong <cyd@stupidchicken.com>
15947
c96bbc66 15948 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15949
cffc6f3b
CY
159502011-03-13 Chong Yidong <cyd@stupidchicken.com>
15951
15952 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15953 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15954 These macros can no longer be used for assignment.
15955
44f230aa
SM
15956 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15957 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15958 (record_buffer_markers, fetch_buffer_markers): New functions for
15959 recording and fetching special buffer markers.
15960 (set_buffer_internal_1, set_buffer_temp): Use them.
15961
15962 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15963
15964 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15965
15966 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15967 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15968
15969 * xdisp.c (hscroll_window_tree):
15970 (reconsider_clip_changes): Use PT instead of BUF_PT.
15971
d251f04b
EZ
159722011-03-13 Eli Zaretskii <eliz@gnu.org>
15973
15974 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15975 $(EMACS_ROOT)/lib/intprops.h.
15976
f0c77cd1
PE
159772011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15978
3eca4629
PE
15979 Fix more problems found by GCC 4.5.2's static checks.
15980
7c86ee98
PE
15981 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15982 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15983 (xg_free_frame_widgets): Make it clear that a local variable is
15984 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15985 (gdk_window_get_screen): Make it clear that this macro is needed
15986 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15987 (int_gtk_range_get_value): New function, which avoids a diagnostic
15988 from gcc -Wbad-function-cast.
15989 (xg_set_toolkit_scroll_bar_thumb): Use it.
15990 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15991 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15992 (get_utf8_string, xg_get_file_with_chooser):
15993 Rename locals to avoid shadowing.
15994 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15995
41729b81
PE
15996 * xgselect.c (xg_select): Remove unused var.
15997
f0c77cd1
PE
15998 * image.c (four_corners_best): Mark locals as initialized.
15999 (gif_load): Initialize transparent_p to zero (Bug#8238).
16000 Mark another local as initialized.
ec6cf4c6 16001 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 16002
ce0ad53d 16003 * image.c (clear_image_cache): Now static.
d5d5a617 16004 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 16005 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
16006 (x_edge_detection): Remove unnecessary cast that
16007 gcc -Wbad-function-cast diagnoses.
2037898d 16008 (gif_load): Fix pointer signedness.
6ae141d6
PE
16009 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
16010 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 16011
33383987 160122011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 16013
d32df629
PE
16014 Improve quality of tests for time stamp overflow.
16015 For example, without this patch (encode-time 0 0 0 1 1
16016 1152921504606846976) returns the obviously-bogus value (-948597
16017 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
16018 reports time overflow. See
16019 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
16020 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
16021 * editfns.c: Include limits.h and intprops.h.
16022 (TIME_T_MIN, TIME_T_MAX): New macros.
16023 (time_overflow): Move earlier, to before first use.
16024 (hi_time, lo_time): New functions, for an accurate test for
16025 out-of-range times.
16026 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
16027 (Fget_internal_run_time): Don't assume time_t fits in int.
16028 (make_time): Use list2 instead of Fcons twice.
16029 (Fdecode_time): More accurate test for out-of-range times.
16030 (check_tm_member): New function.
16031 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
16032 (lisp_time_argument): Don't rely on undefined left-shift and
16033 right-shift behavior when checking for time stamp overflow.
8be6f318 16034
fe31d94c
PE
16035 * editfns.c (time_overflow): New function, refactoring common code.
16036 (Fformat_time_string, Fdecode_time, Fencode_time):
16037 (Fcurrent_time_string): Use it.
16038
8be6f318
PE
16039 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
16040 * dired.c (make_time): Move to ...
16041 * editfns.c (make_time): ... here.
16042 * systime.h: Note the move.
16043
09d9db2c 160442011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 16045
126bc0dc
YM
16046 * fringe.c (update_window_fringes): Remove unused variables.
16047
c47cbdfd
YM
16048 * unexmacosx.c (copy_data_segment): Also copy __got section.
16049 (Bug#8223)
16050
7ac80be9
EZ
160512011-03-12 Eli Zaretskii <eliz@gnu.org>
16052
c96bbc66 16053 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
16054 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
16055 Constify `char *' arguments and their references according to
16056 prototypes in tparam.h.
16057
ecb0f94d 16058 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 16059
7ac80be9
EZ
16060 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
16061 Adapt all references accordingly.
16062
16063 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
16064
ef1fd07e
TT
160652011-03-11 Tom Tromey <tromey@redhat.com>
16066
16067 * buffer.c (syms_of_buffer): Remove obsolete comment.
16068
7ef4b50c
EZ
160692011-03-11 Eli Zaretskii <eliz@gnu.org>
16070
16071 * termhooks.h (encode_terminal_code): Declare prototype.
16072
16073 * msdos.c (encode_terminal_code): Don't declare prototype.
16074
16075 * term.c (encode_terminal_code): Now external again, used by
16076 w32console.c and msdos.c.
16077
44f230aa
SM
16078 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
16079 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 16080
4b1ec863 160812011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 16082
1714f52b 16083 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 16084
4b1ec863
PE
16085 * fringe.c (update_window_fringes): Mark locals as initialized
16086 (Bug#8227).
16087 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 16088
524c7aa6
PE
16089 * alloc.c (mark_fringe_data): Move decl from here ...
16090 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
16091 to check its interface.
16092 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
16093
a5c0af81 16094 * fontset.c (free_realized_fontset): Now static.
7519b8cd 16095 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 16096 (fontset_font): Mark local as initialized.
a9a06e0b 16097 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 16098
b4716021
PE
16099 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
16100
811e9bac 16101 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 16102 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
16103 (x_own_selection, Fx_disown_selection_internal): Rename locals
16104 to avoid shadowing.
16105 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 16106
7e3ab302
PE
16107 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
16108 so that the caller can use some name other than gcpro1.
16109 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
16110 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16111 (Fx_backspace_delete_keys_p):
16112 Use them to avoid shadowing, and rename vars to avoid shadowing.
16113 (x_decode_color, x_set_name, x_window): Now static.
6b437900 16114 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 16115 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
16116 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
16117 Remove unused locals.
7e3ab302
PE
16118 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
16119 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
16120 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
16121 macros.
f78faa98 16122
e2b13473
PE
16123 * xterm.h (x_mouse_leave): New decl.
16124
77f23912
PE
16125 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
16126 Remove unused functions.
cdf4ba58
PE
16127 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
16128 (x_calc_absolute_position): Now static.
7411c686 16129 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 16130 Don't declare local "event" unless it's used.
ed7bf3a5
PE
16131 (x_iconify_frame, x_free_frame_resources): Don't declare locals
16132 unless they are used.
38d0b34a
PE
16133 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
16134 (x_fatal_error_signal): Remove; not used.
a6067996
PE
16135 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
16136 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
16137 (x_error_catcher, x_connection_closed, x_error_handler):
16138 (x_error_quitter, xembed_send_message, x_iconify_frame):
16139 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 16140 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 16141 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 16142
44f230aa
SM
16143 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
16144 Rename or move locals to avoid shadowing.
6b463e58 16145 (tty_defined_color, merge_face_heights): Now static.
5967d051 16146 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
16147 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
16148 does not deduce is never used uninitialized.
73719eba
PE
16149 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
16150 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 16151
426994c3 16152 * terminal.c (store_terminal_param): Now static.
5489860b 16153
032f1620 16154 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 16155 (set_frame_menubar): Remove unused local.
d4323972 16156 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
16157 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
16158 since they might point to immutable storage.
281585b0
PE
16159 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
16160 since it's unused otherwise.
032f1620 16161
367c19e5 16162 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 16163 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
16164 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
16165 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 16166 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
16167 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
16168 does not deduce are never used uninitialized.
70739cbe 16169
07b48fa9
PE
16170 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
16171
8868a238 16172 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
16173 * window.c (window_loop, size_window):
16174 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 16175
7e5cf297 16176 * window.c (display_buffer): Now static.
d6550a9f
PE
16177 (size_window): Mark variables that gcc -Wuninitialized
16178 does not deduce are never used uninitialized.
a586633d
PE
16179 * window.h (check_all_windows): New decl, to forestall
16180 gcc -Wmissing-prototypes diagnostic.
5b555da1 16181 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 16182
f6095868
PE
16183 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
16184 shadowing.
16185 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
16186 Include <limits.h>.
16187 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
16188 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
16189 (load_charset_map): Mark variables that gcc -Wuninitialized
16190 does not deduce are never used uninitialized.
53df7c11 16191 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 16192
f38b440c
PE
16193 * coding.c (coding_set_source, coding_set_destination):
16194 Use "else { /* comment */ }" rather than "else /* comment */;"
16195 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
16196 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
16197 a block, when the outer 'i' will do.
16198 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
16199 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
16200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
16201 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
16202 (Fdecode_sjis_char, Fdefine_coding_system_internal):
16203 Rename locals to avoid shadowing.
16204 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
16205 * coding.c (emacs_mule_char, encode_invocation_designation):
16206 Now static, since they're not used elsewhere.
413bb2db 16207 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 16208 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
16209 (decode_coding_emacs_mule): Mark variables that gcc
16210 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
16211 (detect_coding_iso_2022): Initialize a local variable that might
16212 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 16213 this initialization is needed. (Bug#8211)
5f58e762
PE
16214 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
16215 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
16216 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
16217 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
16218 Remove unused macros.
f38b440c 16219
232b38b9 16220 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 16221 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 16222 * character.c (string_count_byte8): Likewise.
232b38b9 16223
fb90da1b
PE
16224 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
16225 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
16226
fb93dbc2
PE
16227 * chartab.c (copy_sub_char_table): Now static, since it's not used
16228 elsewhere.
5c156ace
PE
16229 (sub_char_table_ref_and_range, char_table_ref_and_range):
16230 Rename locals to avoid shadowing.
bbcd0949 16231 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 16232
7d3b3862 16233 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 16234 (BIDI_BOB): Remove unused macro.
7d3b3862 16235
6be7d3da
PE
16236 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
16237 deduce are never used uninitialized.
c2ed9c8b 16238 * term.c (encode_terminal_code): Likewise.
6be7d3da 16239
75f8807f 16240 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 16241
50938595
PE
16242 * tparam.h: New file.
16243 * term.c, tparam.h: Include it.
16244 * deps.mk (term.o, tparam.o): Depend on tparam.h.
16245 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
16246 Move these decls to tparam.h, and make them agree with what
16247 is actually in tparam.c. The previous trick of using incompatible
16248 decls in different modules does not conform to the C standard.
16249 All callers of tparam changed to use tparam's actual API.
16250 * tparam.c (tparam1, tparam, tgoto):
16251 Use const pointers where appropriate.
16252
fbceeba2
PE
16253 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
16254 * cm.h (struct cm): Likewise.
16255 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
16256 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
16257 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
16258 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
16259 (turn_on_face, init_tty): Likewise.
16260 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 16261
7f3f1250
PE
16262 * term.c (term_mouse_position): Rename local to avoid shadowing.
16263
e6ca6543
PE
16264 * alloc.c (mark_ttys): Move decl from here ...
16265 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
16266
c40f8d15
AS
162672011-03-11 Andreas Schwab <schwab@linux-m68k.org>
16268
16269 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
16270
cfe0661d
JB
162712011-03-09 Juanma Barranquero <lekktu@gmail.com>
16272
16273 * search.c (compile_pattern_1): Remove argument regp, unused since
16274 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
16275 (compile_pattern): Don't pass it.
16276
0afb4571
J
162772011-03-08 Jan Djärv <jan.h.d@swipnet.se>
16278
16279 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
16280 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
16281 for ! HAVE_GTK3.
16282 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
16283
16284 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
16285
16286 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
16287 gdk_window_get_screen, gdk_window_get_geometry,
16288 gdk_x11_window_lookup_for_display and GDK_KEY_g.
16289 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
16290 (xg_get_pixbuf_from_pixmap): New function.
16291 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
16292 to Pixmap, take frame as parameter, remove GdkColormap parameter.
16293 Call xg_get_pixbuf_from_pixmap instead of
16294 gdk_pixbuf_get_from_drawable.
16295 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
16296 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
16297 (xg_check_special_colors): Use GtkStyleContext and its functions
16298 for HAVE_GTK3.
16299 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
16300 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
16301 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
16302 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
16303 Call gtk_widget_get_preferred_size.
0afb4571
J
16304 (xg_frame_resized): gdk_window_get_geometry only takes 5
16305 parameters.
44f230aa
SM
16306 (xg_win_to_widget, xg_event_is_for_menubar):
16307 Call gdk_x11_window_lookup_for_display.
0afb4571
J
16308 (xg_set_widget_bg): New function.
16309 (delete_cb): New function.
895009e1 16310 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 16311 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
16312 (xg_set_background_color): Call xg_set_widget_bg.
16313 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
16314 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
16315 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
16316 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
16317 if ! HAVE_GTK3.
16318 (update_frame_tool_bar): Call gtk_widget_hide.
16319 (xg_initialize): Use GDK_KEY_g.
16320
16321 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
16322 if ! HAVE_GTK3
16323 (x_session_initialize): Call gdk_x11_set_sm_client_id.
16324
16325 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
16326 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
16327 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
16328
1c2cc4ef
JB
163292011-03-08 Juanma Barranquero <lekktu@gmail.com>
16330
16331 * w32xfns.c (select_palette): Check success of RealizePalette against
16332 GDI_ERROR, not zero.
16333
33383987 16334See ChangeLog.11 for earlier changes.
aac0c6e3
MR
16335
16336;; Local Variables:
16337;; coding: utf-8
aac0c6e3
MR
16338;; End:
16339
2f097256 16340 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
16341
16342 This file is part of GNU Emacs.
16343
16344 GNU Emacs is free software: you can redistribute it and/or modify
16345 it under the terms of the GNU General Public License as published by
16346 the Free Software Foundation, either version 3 of the License, or
16347 (at your option) any later version.
16348
16349 GNU Emacs is distributed in the hope that it will be useful,
16350 but WITHOUT ANY WARRANTY; without even the implied warranty of
16351 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16352 GNU General Public License for more details.
16353
16354 You should have received a copy of the GNU General Public License
16355 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.