Small leim/Makefile.in simplification
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a18ecafa
TZ
12012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2
3 * process.c (make_process):
4 * process.h: Add integer `gnutls_handshakes_tried' member to
5 process struct.
6
7 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit. Add
8 convenience `GNUTLS_LOG2i' macro.
9
10 * gnutls.c (gnutls_log_function2i): Convenience log function.
11 (emacs_gnutls_read): Use new log functions,
12 `gnutls_handshakes_tried' process member, and
13 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
14 attempts per process (connection).
15
b4d3bc10
CY
162012-04-09 Chong Yidong <cyd@gnu.org>
17
18 * eval.c (Fuser_variable_p, user_variable_p_eh)
19 (lisp_indirect_variable): Functions deleted.
20 (Fdefvar): Caller changed.
21
22 * callint.c (Finteractive, Fcall_interactively):
23 * minibuf.c (Fread_variable): Callers changed.
24
70f4d973
EZ
252012-04-09 Eli Zaretskii <eliz@gnu.org>
26
27 * xdisp.c (set_cursor_from_row): If the display string appears in
28 the buffer at position that is closer to point than the position
29 after the display string, display the cursor on the first glyph of
30 the display string. Fixes cursor display when a 'display' text
31 property immediately follows invisible text. (Bug#11094)
32
cb3c2e3e
PE
332012-04-09 Paul Eggert <eggert@cs.ucla.edu>
34
35 composite.c: use 'double' consistently
36 * composite.c (get_composition_id): Use 'double' consistently
37 instead of converting 'float' to 'double' and vice versa; this is
38 easier to understand and avoids a GCC warning.
39
fd06db5d
GM
402012-04-09 Glenn Morris <rgm@gnu.org>
41
50fe702a
GM
42 * Makefile.in: Generate leim-list with bootstrap-emacs, in
43 preparation for dumping it with emacs. (Bug#4789)
44 (leimdir): New variable.
45 ($(leimdir)/leim-list.el): New rule.
46 (emacs$(EXEEXT)): Depend on leim-list.el.
47
fd06db5d
GM
48 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
49 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
50 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
51
55c131ee
AS
522012-04-08 Andreas Schwab <schwab@linux-m68k.org>
53
54 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
55 proper alignment.
56
9209588f
JB
572012-04-07 Juanma Barranquero <lekktu@gmail.com>
58
59 * xml.c (init_libxml2_functions) [WINDOWSNT]:
60 Remove unused local variable.
61
e3fb2efb
PE
622012-04-07 Paul Eggert <eggert@cs.ucla.edu>
63
64 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
65 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
66 (mark_memory): Mark Lisp_Objects only if pointers might hide in
67 objects, as mark_maybe_pointer will catch them otherwise.
68 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
69 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
70
b5385551
PE
712012-04-07 Paul Eggert <eggert@cs.ucla.edu>
72
73 Fix typo that broke non-Windows builds.
74 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
75
9078ead6
EZ
762012-04-07 Eli Zaretskii <eliz@gnu.org>
77
78 Support building on MS-Windows with libxml2.
79
80 * makefile.w32-in (OBJ2): Add xml.$(O).
81 (GLOBAL_SOURCES): Add xml.c.
82 ($(BLD)/xml.$(O)): New dependency list.
83
84 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
85 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
86 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
87 [!WINDOWSNT]: New macros.
88 (init_libxml2_functions, libxml2_loaded_p): New functions.
89 (parse_region): Call fn_xmlCheckVersion instead of using the macro
90 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
91 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
92 Calls xmlCleanupParser only if libxml2 was loaded (or statically
93 linked in).
94 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
95 init_libxml2_functions before calling libxml2 functions.
96 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
97
98 * emacs.c: Don't include libxml/parser.h.
99 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
100 xmlCleanupParser directly.
101
102 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
103
3811fdf3
EZ
1042012-04-07 Eli Zaretskii <eliz@gnu.org>
105
106 * indent.c (Fvertical_motion): If there is a display string at
107 point, use it.vpos to compute how many lines to backtrack after
108 move_it_to point. (Bug#11133)
109
2f8e16b2
EZ
1102012-04-06 Eli Zaretskii <eliz@gnu.org>
111
112 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
113 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
114 about subtle differences between FETCH_CHAR* and STRING_CHAR*
115 macros related to unification of CJK characters. For the details,
116 see the discussion following the message here:
117 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
118
3d439cd1
CY
1192012-04-04 Chong Yidong <cyd@gnu.org>
120
121 * keyboard.c (Vdelayed_warnings_list): Doc fix.
122
8bc53d00
EZ
1232012-04-01 Eli Zaretskii <eliz@gnu.org>
124
125 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
126 instead of alloca. (Bug#11138)
127
3b0512a3
AS
1282012-04-01 Andreas Schwab <schwab@linux-m68k.org>
129
130 * w32menu.c (is_simple_dialog): Properly check lisp types.
131 (Bug#11141)
132
8427ddd2
EZ
1332012-03-31 Eli Zaretskii <eliz@gnu.org>
134
979022ef
EZ
135 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
136 position we get to after a call to move_it_to fails the
137 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
138 only if we wind up in a string from display property. (Bug#11063)
139
a6b1c7cc
EZ
140 * window.c (Fdelete_other_windows_internal): Invalidate the row
141 and column information about mouse highlight, so that redisplay
142 restores it after reallocating the glyph matrices. (Bug#7464)
143
8427ddd2
EZ
144 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
145 string comes from a `display' text property, use the buffer
146 position of that property as if we actually saw that position in
147 the row's glyphs.
697ba24b
EZ
148 (move_it_by_lines): Remove the assertion that
149 "it->current_x == 0 && it->hpos == 0" which can be legitimately
150 violated when there's a before-string at the beginning of a line.
151 (Bug#11063)
8427ddd2 152
65a0a738
EZ
1532012-03-30 Eli Zaretskii <eliz@gnu.org>
154
155 * xdisp.c (append_space_for_newline): If the default face was
156 remapped, use the remapped face for the appended newline.
157 (extend_face_to_end_of_line): Use the remapped default face for
158 extending the face to the end of the line.
159 (display_line): Call extend_face_to_end_of_line when the default
160 face was remapped. (Bug#11068)
161
581355cc
EZ
1622012-03-29 Eli Zaretskii <eliz@gnu.org>
163
164 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
165
e8fc049f
SM
1662012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
167
168 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
169
4fb9a543
GM
1702012-03-27 Glenn Morris <rgm@gnu.org>
171
172 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
173 Doc fixes.
174
679910f1
KH
1752012-03-26 Kenichi Handa <handa@m17n.org>
176
177 * dispextern.h (struct glyph): Fix previous change. Change the
178 bit length of glyphless.ch to 25 (Bug#11082).
179
90d49b7f
CY
1802012-03-26 Chong Yidong <cyd@gnu.org>
181
182 * keyboard.c (Vselection_inhibit_update_commands): New variable.
183 (command_loop_1): Use it; inhibit selection update for
184 handle-select-window too (Bug#8996).
185
f514f6f0
FP
1862012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
187
e8fc049f 188 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 189
bf43fa51
KH
1902012-03-25 Kenichi Handa <handa@m17n.org>
191
192 * dispextern.h (struct glyph): Change the bit length of
193 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
194
8a0c01dd
EZ
1952012-03-24 Eli Zaretskii <eliz@gnu.org>
196
197 * s/ms-w32.h (tzname): Include time.h before redirecting to
198 _tzname. Fixes the MSVC build. (Bug#9960)
199
7d1c3a76
AS
2002012-03-24 Andreas Schwab <schwab@linux-m68k.org>
201
8ed79523
AS
202 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
203 characters.
204
7d1c3a76
AS
205 * xterm.c (XTread_socket): Only modify handling_signal if
206 !SYNC_INPUT. (Bug#11080)
207
e99a9b8b
EZ
2082012-03-23 Eli Zaretskii <eliz@gnu.org>
209
210 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
211 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
212 when fetching a multibyte character consumes more bytes than
213 CHAR_BYTES returns, due to unification of CJK characters in
214 string_char. (Bug#11073)
215
5063c0e1
TN
2162012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
217
218 * process.c (wait_reading_process_output): Handle pty disconnect
219 by refraining from sending oneself a SIGCHLD (bug#10933).
220
9f851fbd
CY
2212012-03-22 Chong Yidong <cyd@gnu.org>
222
223 * dispextern.h (struct it): New member string_from_prefix_prop_p.
224
5063c0e1 225 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
226 Mark string as coming from a prefix property.
227 (handle_face_prop): Use default face for prefix strings (Bug#4281).
228 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
229
fb5b8aca
CY
2302012-03-21 Chong Yidong <cyd@gnu.org>
231
232 * xfaces.c (Vface_remapping_alist): Doc fix.
233
62356a1b
EZ
2342012-03-20 Eli Zaretskii <eliz@gnu.org>
235
236 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
237 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
238 Doc fixes.
62356a1b 239
025de85b
CY
2402012-03-20 Chong Yidong <cyd@gnu.org>
241
242 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
243 to reflect default non-nil value of redisplay-dont-pause.
244
4827f94e
KH
2452012-03-19 Kenichi Handa <handa@m17n.org>
246
247 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
248 it fit in a valid range (Bug#11003).
249
e50a24a2
EZ
2502012-03-18 Eli Zaretskii <eliz@gnu.org>
251
252 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
253 that is not from display property, accept the row as a "cursor
254 row" if one of the string's character has a non-nil `cursor'
255 property. Fixes cursor positioning when there are newlines in
256 overlay strings, e.g. in icomplete.el. (Bug#11035)
257
9af5ed87
PE
2582012-03-12 Paul Eggert <eggert@cs.ucla.edu>
259
260 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
261
d1f55f16
CY
2622012-03-12 Chong Yidong <cyd@gnu.org>
263
264 * eval.c (inhibit_lisp_code): Rename from
265 inhibit_window_configuration_change_hook; move from window.c.
266
267 * xfns.c (unwind_create_frame_1, Fx_create_frame):
268 * window.c (run_window_configuration_change_hook)
269 (syms_of_window): Callers changed.
270
66c5eebd
CY
2712012-03-11 Chong Yidong <cyd@gnu.org>
272
413df973
CY
273 * keymap.c (Fkey_description): Doc fix (Bug#9700).
274
66c5eebd
CY
275 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
276
1de11f56
CY
2772012-03-10 Chong Yidong <cyd@gnu.org>
278
279 * frame.c (other_visible_frames): Don't assume the selected frame
280 is visible (Bug#10955).
281
cae07000
SM
2822012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
283
284 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
285
89c94350
JD
2862012-03-08 Jan Djärv <jan.h.d@swipnet.se>
287
288 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
289 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
290 zero (Bug#10954).
291
999dd333
GM
2922012-03-03 Glenn Morris <rgm@gnu.org>
293
01a6dcc8 294 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 295
de0100f2
EZ
2962012-03-02 Eli Zaretskii <eliz@gnu.org>
297
298 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
299 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
300 (redisplay_window, next_element_from_string): Fix typos in
301 comments.
3e441275
EZ
302 (redisplay_window): Pass to move_it_vertically the margin in
303 pixels, not in screen lines.
de0100f2 304
96a72ee9
GM
3052012-03-02 Glenn Morris <rgm@gnu.org>
306
307 * buffer.c (buffer-list-update-hook): Doc fix.
308
312508d7
EZ
3092012-02-29 Eli Zaretskii <eliz@gnu.org>
310
311 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
312 push_it before setting up the iterator for the first overlay
313 string, even if we have an empty string loaded.
314 (next_overlay_string): If there's an empty string on the iterator
315 stack, pop the stack. (Bug#10903)
316
27f3c637
PE
3172012-02-25 Paul Eggert <eggert@cs.ucla.edu>
318
319 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
320 Suggested by Stefan Monnier in
321 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
322 * alloc.c (widen_to_Lisp_Object): New static function.
323 (mark_memory): Also mark Lisp_Objects by fetching pointer words
324 and widening them to Lisp_Objects. This would work even if
325 USE_LSB_TAG is defined and wide integers are used, which might
326 happen in a future version of Emacs.
327
3c9dfce6
CY
3282012-02-25 Chong Yidong <cyd@gnu.org>
329
fa74b241
CY
330 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
331 Doc fix.
332
3c9dfce6
CY
333 * xselect.c (Fx_selection_exists_p): Doc fix.
334 (x_clipboard_manager_save_all): Print an informative message
335 before saving to clipboard manager.
336
9486df08
CY
3372012-02-24 Chong Yidong <cyd@gnu.org>
338
339 * keyboard.c (process_special_events): Handle all X selection
340 requests in kbd_buffer, not just the next one (Bug#8869).
341
f01d3321
CY
3422012-02-23 Chong Yidong <cyd@gnu.org>
343
344 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
345 call when setting menu-bar-lines and tool-bar-lines parameters.
346 (unwind_create_frame_1): New helper function.
347
348 * window.c (inhibit_window_configuration_change_hook): New var.
349 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 350 (syms_of_window): Initialize it.
f01d3321 351
86b847b6
CY
3522012-02-22 Chong Yidong <cyd@gnu.org>
353
354 * xterm.c (x_draw_image_relief): Add missing type check for
355 Vtool_bar_button_margin (Bug#10743).
356
a59225b1
CY
3572012-02-21 Chong Yidong <cyd@gnu.org>
358
359 * fileio.c (Vfile_name_handler_alist): Doc fix.
360
361 * buffer.c (Fget_file_buffer): Protect against invalid file
362 handler return value.
363
310f5bd4
PE
3642012-02-20 Paul Eggert <eggert@cs.ucla.edu>
365
cb3a28cc
PE
366 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
367 when computing $valmask.
368
310f5bd4
PE
369 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
370 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
371 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
372 It's useless in that case, and it can cause problems on hosts
373 that allocate halves of EMACS_INT values separately.
374 Reported by Dan Horák. Diagnosed by Andreas Schwab in
375 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
376 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
377 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
378 it avoids undefined behavior on hosts where shifting right by more
379 than the word width has undefined behavior.
380
2375c96a
CY
3812012-02-19 Chong Yidong <cyd@gnu.org>
382
383 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
384 (Funhandled_file_name_directory, Ffile_name_as_directory)
385 (Fdirectory_file_name, Fexpand_file_name)
386 (Fsubstitute_in_file_name): Protect against invalid file handler
387 return values (Bug#10845).
388
3eb49e71
EZ
3892012-02-18 Eli Zaretskii <eliz@gnu.org>
390
391 * .gdbinit (pitx): Fix incorrect references to fields of the
392 iterator stack.
393
7b926f3f
CY
3942012-02-17 Chong Yidong <cyd@gnu.org>
395
396 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
397
11273115
PE
3982012-02-15 Paul Eggert <eggert@cs.ucla.edu>
399
400 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
401 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
402
c3a70e2b
CY
4032012-02-15 Chong Yidong <cyd@gnu.org>
404
405 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
406 marked as special. Also, starting docstrings with * is obsolete.
407
0ca43699
AS
4082012-02-13 Andreas Schwab <schwab@linux-m68k.org>
409
410 * gnutls.c (emacs_gnutls_write): Fix last change.
411
2e8f3c56
LI
4122012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
413
414 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
415 send_process.
416
af70074f
SM
4172012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
418
419 * keymap.c (Fsingle_key_description): Handle char ranges.
420
95986d52
CY
4212012-02-12 Chong Yidong <cyd@gnu.org>
422
afd83bd1
CY
423 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
424 as that creates a dangerous corner case.
425
95986d52
CY
426 * window.c (Fdelete_window_internal): Invalidate the mouse
427 highlight (Bug#9904).
428
bd7da63e
GM
4292012-02-12 Glenn Morris <rgm@gnu.org>
430
431 * xselect.c (Fx_own_selection_internal)
432 (Fx_get_selection_internal, Fx_disown_selection_internal)
433 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
434 * nsselect.m (Fx_own_selection_internal)
435 (Fx_disown_selection_internal, Fx_selection_exists_p)
436 (Fx_selection_owner_p, Fx_get_selection_internal):
437 Sync docs and argument specs with the xselect.c versions.
438
77abcbc2
LI
4392012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
440
441 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
442
90b671e2
EZ
4432012-02-11 Eli Zaretskii <eliz@gnu.org>
444
1c0ca0b7
EZ
445 * w32select.c (Fx_selection_exists_p): Sync doc string and
446 argument list with xselect.c. (Bug#10783)
447
448 * w16select.c (Fx_selection_exists_p): Sync doc string and
449 argument list with xselect.c. (Bug#10783)
90b671e2 450
49241268
GM
4512012-02-10 Glenn Morris <rgm@gnu.org>
452
453 * fns.c (Fsecure_hash): Doc fix.
454
f998bbe7 4552012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
456
457 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
458
0992bd9c
CY
4592012-02-07 Chong Yidong <cyd@gnu.org>
460
461 * buffer.c (Fbuffer_local_variables)
462 (buffer_lisp_local_variables): Handle unbound vars correctly;
463 don't let Qunbound leak into Lisp.
464
af008560
GM
4652012-02-07 Glenn Morris <rgm@gnu.org>
466
dd605cc4
GM
467 * image.c (Fimagemagick_types): Doc fix.
468
af008560
GM
469 * image.c (imagemagick-render-type): Change it from a lisp object
470 to an integer. Move the doc here from the lisp manual.
471 Treat all values not equal to 0 the same.
472
1449fa1d
CY
4732012-02-06 Chong Yidong <cyd@gnu.org>
474
475 * doc.c (store_function_docstring): Avoid applying docstring of
476 alias to base function (Bug#2603).
477
3723ec07
AS
4782012-02-04 Andreas Schwab <schwab@linux-m68k.org>
479
480 * .gdbinit (pp1, pv1): Remove redundant defines.
481 (pr): Use pp.
482
79c1cc1e
CY
4832012-02-04 Chong Yidong <cyd@gnu.org>
484
485 * nsterm.m: Declare a global (Bug#10694).
486
d7f29f8e
EZ
4872012-02-04 Eli Zaretskii <eliz@gnu.org>
488
cae07000
SM
489 * w32.c (get_emacs_configuration_options):
490 Include --enable-checking, if specified, in the return value.
d7f29f8e 491
3b95a6f9
MR
4922012-02-04 Martin Rudalics <rudalics@gmx.at>
493
494 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
495 after rounding frame sizes. (Bug#9723)
496
d6fa96a6
EZ
4972012-02-04 Eli Zaretskii <eliz@gnu.org>
498
499 * keyboard.c (adjust_point_for_property): Don't position point
500 before BEGV. (Bug#10696)
501
df0b2940
PE
5022012-02-03 Paul Eggert <eggert@cs.ucla.edu>
503
504 Handle overflow when computing char display width (Bug#9496).
505 * character.c (char_width): Return EMACS_INT, not int.
506 (char_width, c_string_width): Check for overflow when
507 computing the width; this is possible now that individual
508 characters can have unbounded width. Problem introduced
509 by merge from Emacs 23 on 2012-01-19.
510
6bee44d6
MA
5112012-02-02 Michael Albinus <michael.albinus@gmx.de>
512
513 * dbusbind.c (Fdbus_register_method): Mention the return value
514 :ignore in the docstring.
515
44f92739
GM
5162012-02-02 Glenn Morris <rgm@gnu.org>
517
1b9f60cc
GM
518 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
519
44f92739
GM
520 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
521 Unconditionally set to t. (Bug#10673)
522 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
523 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
524 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
525
c5d3843c
KH
5262012-02-02 Kenichi Handa <handa@m17n.org>
527
528 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
529 0, do not call append_composite_glyph.
530
159462d4 5312012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
532
533 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
534 NULL (Bug#6988).
535 (x_produce_glyphs): If the component of a composition is a null
536 string, set it->pixel_width to 1 to avoid zero-width glyph.
537
78cef877
EZ
5382012-02-01 Eli Zaretskii <eliz@gnu.org>
539
540 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
541 first 2 arguments are identical. This makes inserting large
542 output from a subprocess an order of magnitude faster on
543 MS-Windows, where all sbrk'ed memory is always contiguous.
544
97897668
GM
5452012-01-31 Glenn Morris <rgm@gnu.org>
546
547 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 548 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
549 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
550
31fd3586
GM
5512012-01-29 Glenn Morris <rgm@gnu.org>
552
553 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
554
0e24a8b2
CY
5552012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
556
557 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
558
cc0adcb0
CY
5592012-01-28 Chong Yidong <cyd@gnu.org>
560
561 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
562
acc28cb9
CY
5632012-01-26 Chong Yidong <cyd@gnu.org>
564
9c69cfb7
CY
565 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
566
acc28cb9
CY
567 * search.c (Fsearch_forward, Fsearch_backward): Document negative
568 repeat counts (Bug#10507).
569
48da7392
GM
5702012-01-26 Glenn Morris <rgm@gnu.org>
571
572 * lread.c (syms_of_lread): Doc fix.
573
14af5f7f
CY
5742012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
575
576 * coding.c (encode_designation_at_bol): Change return value to
577 EMACS_INT.
578
0b21c100
CY
5792012-01-25 Chong Yidong <cyd@gnu.org>
580
581 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
582
3c2907f7
CY
5832012-01-21 Chong Yidong <cyd@gnu.org>
584
585 * floatfns.c (Fcopysign): Make the second argument non-optional,
586 since nil is not allowed anyway.
587
959ad23f
AS
5882012-01-21 Andreas Schwab <schwab@linux-m68k.org>
589
590 * process.c (read_process_output): Use p instead of XPROCESS (proc).
591 (send_process): Likewise.
592
34a02f46
MR
5932012-01-19 Martin Rudalics <rudalics@gmx.at>
594
595 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
596 (Vwindow_persistent_parameters): Do not use Qstate.
597 Rewrite doc-strings.
34a02f46 598
1259009a 5992012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
600
601 * character.c (char_width): New function.
70d4fdf6
GM
602 (Fchar_width, c_string_width, lisp_string_width):
603 Use char_width (Bug#9496).
25ed9e61 604
6a6ee00d
MR
6052012-01-16 Martin Rudalics <rudalics@gmx.at>
606
607 * window.c (Vwindow_persistent_parameters): New variable.
608 (Fset_window_configuration, save_window_save): Handle persistent
609 window parameters.
610
c85efaf7
EZ
6112012-01-14 Eli Zaretskii <eliz@gnu.org>
612
613 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
614 thrashing the stack of the thread. (Bug#9087)
615
5944709e
PE
6162012-01-12 Paul Eggert <eggert@cs.ucla.edu>
617
618 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
619
e71f5d99
EZ
6202012-01-11 Eli Zaretskii <eliz@gnu.org>
621
622 * xdisp.c (rows_from_pos_range): Handle the case where the
623 highlight ends on a newline. (Bug#10464)
624 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
625 he end column for display of highlight that ends on a newline
626 before a R2L line.
627
ce316182
GM
6282012-01-11 Glenn Morris <rgm@gnu.org>
629
630 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
631 from load-path also when installation-directory is nil. (Bug#10208)
632
5b43da69
GM
6332012-01-10 Glenn Morris <rgm@gnu.org>
634
74cc8ff9
GM
635 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
636
7d8d6e4e
GM
637 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
638 Update template values to be closer to their typical values these days.
5b43da69 639
a0db8d43
EZ
6402012-01-09 Eli Zaretskii <eliz@gnu.org>
641
642 * xdisp.c (rows_from_pos_range): Accept additional argument
643 DISP_STRING, and accept any glyph in a row whose object is that
644 string as eligible for mouse highlight. Fixes mouse highlight of
645 display strings from overlays. (Bug#10464)
646
9a0115ab 6472012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 648
b9110d6a 649 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
650 * fileio.c (auto_saving_dir_umask): New static var.
651 (Fmake_directory_internal): Use it.
652 (do_auto_save_make_dir): Set it, instead of invoking chmod after
653 creating the directory. The old code temporarily assigns
654 too-generous permissions to the directory.
655 (do_auto_save_eh): Clear it.
b9110d6a 656 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
657 that the var is always cleared.
658
6c1bd3f3
EZ
6592012-01-07 Eli Zaretskii <eliz@gnu.org>
660
661 * search.c (scan_buffer): Pass character positions to
662 know_region_cache, not byte positions. (Bug#6540)
663
069d2b50
L
6642012-01-07 LynX <_LynX@bk.ru> (tiny change)
665
666 * w32.c (sys_rename): Report EXDEV when rename of a directory
667 fails because the target is on another logical disk. (Bug#10284)
668
75bf0d33
DB
6692012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
670
671 * xterm.c (x_embed_request_focus): New function.
672
673 * xterm.h: Add prototype.
674
675 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
676
1c6e5a32
GM
6772012-01-05 Glenn Morris <rgm@gnu.org>
678
679 * emacs.c (emacs_copyright): Update short copyright year to 2012.
680
651e947e
EZ
6812012-01-01 Eli Zaretskii <eliz@gnu.org>
682
683 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
684 Load gnutls_transport_set_lowat only if GnuTLS version is below
685 2.11.1.
686 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
687 GnuTLS versions below 2.11.1.
688
3778cdd8
AL
6892011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
690
691 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
692 to the doc string advising against its use for altering the way
693 windows are scrolled.
694
0e5317f7
KH
6952011-12-28 Kenichi Handa <handa@m17n.org>
696
697 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
698 coding-system ASCII compatible only when it does not produce BOM
699 on encoding (Bug#10383).
700
93d5ca1f
JD
7012011-12-26 Jan Djärv <jan.h.d@swipnet.se>
702
703 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
704 can scroll.
705 (create_and_show_popup_menu): Always use menu_position_func for
706 Gtk3 (Bug#10361).
707
ca22b785
AS
7082011-12-24 Andreas Schwab <schwab@linux-m68k.org>
709
710 * callint.c (Fcall_interactively): Don't truncate prompt string.
711
d048e1e6
EZ
7122011-12-23 Eli Zaretskii <eliz@gnu.org>
713
714 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
715 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 716 resumed from there (after widening). (Bug#10360)
d048e1e6 717
5ccaba1f
JD
7182011-12-22 Jan Djärv <jan.h.d@swipnet.se>
719
720 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
721
204ee57f
JD
7222011-12-21 Jan Djärv <jan.h.d@swipnet.se>
723
b81d40f0
JB
724 * nsterm.m (x_free_frame_resources):
725 Release f->output_data.ns->miniimage.
204ee57f
JD
726 (ns_index_color): Fix indentation. Do not retain
727 color_table->colors[i].
728
729 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
730 before returning.
731
732 * nsfns.m (x_set_background_color): Assign return value from
733 ns_index_color to face-background instead of NSColor*.
734 (ns_implicitly_set_icon_type): Fix indentation.
735 Change assignment in for loop to comparison.
736
737 * emacs.c (ns_pool): New variable.
738 (main): Assign ns_pool.
739 (Fkill_emacs): Call ns_release_autorelease_pool.
740
741 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
742 autorelease fdesc, release fdAttrs and tdict.
743 (ns_get_covering_families): Release charset.
744 (ns_findfonts): Release NSFontDescriptor created with new.
745 (ns_uni_to_glyphs): Fix indentation.
746 (setString): Release attrStr before assigning new value.
747
c803b2b7
JD
7482011-12-18 Jan Djärv <jan.h.d@swipnet.se>
749
678f4426
JD
750 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
751 and NS_IMPL_COCOA.
752 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
753 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
754
cd394be1 7552011-12-18 David Reitter <reitter@cmu.edu>
678f4426 756
5fecd5fc
JD
757 * nsterm.m (ns_term_init): Subscribe for notifications
758 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
759 to method trackingNotification in EmacsMenu.
760
761 * nsmenu.m (trackingMenu): New variable.
3771cb17 762 (trackingNotification): New method (from Aquamacs).
5fecd5fc 763 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 764 from Aquamacs (Bug#7030).
678f4426
JD
765
7662011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 767
c803b2b7
JD
768 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
769 (symbol_to_nsstring): Fix indentation.
770 (ns_symbol_to_pb): New function.
cae07000
SM
771 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
772 (Fns_rotate_cut_buffers_internal): Remove.
773 (Fns_store_selection_internal): Rename from
c803b2b7
JD
774 Fns_store_cut_buffer_internal.
775 (ns_get_foreign_selection, Fx_own_selection_internal)
776 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
777 (Fns_get_selection_internal, Fns_store_selection_internal):
778 Use ns_symbol_to_pb and check if return value is nil.
779 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
780 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
781 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
782 renamed to Sns_store_selection_internal.
783 (ns_handle_selection_request): Move code to Fx_own_selection_internal
784 and remove this function.
785 (ns_handle_selection_clear): Remove, never used.
786 (Fx_own_selection_internal): Move code from ns_handle_selection_request
787 here.
788
e1b01a3a
KB
7892011-12-17 Ken Brown <kbrown@cornell.edu>
790
791 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
792 GID is unknown (Bug#10257).
793
2adb6e85
PE
7942011-12-17 Paul Eggert <eggert@cs.ucla.edu>
795
796 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
797 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
798 which caused a build failure on GNU/Linux IA-64. This problem was
799 introduced by my 2011-10-07 patch.
800
d1d7b339
JL
8012011-12-15 Juri Linkov <juri@jurta.org>
802
803 * image.c (imagemagick_error): New function. (Bug#10112)
804 (imagemagick_load_image): Comment out `MagickSetResolution' call.
805 Use `imagemagick_error' where ImageMagick functions return
806 `MagickFalse'.
807 (Fimagemagick_types): Add `Fnreverse' to return the list in the
808 proper order.
809
100d5755
KH
8102011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
811
812 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
813 fill background (Bug#8992).
814
454592a6
MR
8152011-12-13 Martin Rudalics <rudalics@gmx.at>
816
817 * window.c (Vwindow_combination_resize)
818 (Vwindow_combination_limit): Use t instead of non-nil in
819 doc-strings.
61d4b438
MR
820 (Vrecenter_redisplay): Add first sentence of doc-string on
821 separate line.
53524d93 822 (Frecenter): Fix doc-string typo.
454592a6 823
3633e3aa
KH
8242011-12-11 Kenichi Handa <handa@m17n.org>
825
826 * coding.c (Funencodable_char_position): Pay attention to the
827 buffer text relocation (Bug#9389).
828
7b9d523a
JD
8292011-12-10 Jan Djärv <jan.h.d@swipnet.se>
830
831 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
832 gtk_init (Bug#10100).
833
b73189c6
EZ
8342011-12-10 Eli Zaretskii <eliz@gnu.org>
835
836 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
837 IT->string is nil. (Bug#10263)
838
f7dfe5d6
JD
8392011-12-10 Jan Djärv <jan.h.d@swipnet.se>
840
83faebb4
JD
841 * nsterm.h (x_free_frame_resources): Declare.
842
f7dfe5d6
JD
843 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
844 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
845
846 * nsterm.h (ns_get_defaults_value): Declare.
847
848 * nsterm.m (ns_default): Call ns_get_defaults_value.
849
7cd4e72c
EZ
8502011-12-09 Eli Zaretskii <eliz@gnu.org>
851
852 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
853 (Bug#10170)
854
b34d7317
YM
8552011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
856
857 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
858 that where the value of an _OBJC_* symbol points to is in the .bss
859 section (Bug#10240).
860
76470ad1
KH
8612011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
862
863 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 864 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 865
745fff94
KH
8662011-12-08 Kenichi Handa <handa@m17n.org>
867
868 * ftfont.c (get_adstyle_property): Fix previous change
869 (Bug#10233).
870
6e44397c
JB
8712011-12-07 Juanma Barranquero <lekktu@gmail.com>
872
873 * w32.c (init_environment): If no_site_lisp, remove site-lisp
874 dirs from the default value of EMACSLOADPATH (bug#10208).
875
7efa6272
GM
8762011-12-07 Glenn Morris <rgm@gnu.org>
877
878 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
879 installation and source directories as well. (Bug#10208)
880
f6fc4d87
CY
8812011-12-06 Chong Yidong <cyd@gnu.org>
882
883 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
884
2bf26180
GM
8852011-12-06 Glenn Morris <rgm@gnu.org>
886
887 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
888 as an error, not just -1. (Bug#10217)
889
3a6ad4f0
CY
8902011-12-05 Chong Yidong <cyd@gnu.org>
891
892 * keyboard.c (process_special_events): New function.
893 (swallow_events, Finput_pending_p): Use it (Bug#10195).
894
75a3b399
PE
8952011-12-05 Paul Eggert <eggert@cs.ucla.edu>
896
897 * coding.c (encode_designation_at_bol): Don't use uninitialized
898 local variable (Bug#9318).
899
c3c9e25e
KH
9002011-12-05 Kenichi Handa <handa@m17n.org>
901
902 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
903 return Qnil (Bug#8046, Bug#10193).
904
5eb05ea3
KH
9052011-12-05 Kenichi Handa <handa@m17n.org>
906
907 * coding.c (encode_designation_at_bol): New args charbuf_end and
908 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
909 (coding_set_source): Return how many bytes coding->source was
910 relocated.
911 (coding_set_destination): Return how many bytes
912 coding->destination was relocated.
913 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 914 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
915
9162011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
917
918 * coding.c (CODING_CHAR_CHARSET_P): New macro.
919 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
920 macro (Bug#9318).
921
9222011-12-05 Andreas Schwab <schwab@linux-m68k.org>
923
924 The following changes are to fix Bug#9318.
925
a79703f5 926 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
927 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
928 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 929 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 930
7dbda6df
JB
9312011-12-05 Juanma Barranquero <lekktu@gmail.com>
932
933 * lisp.h (process_quit_flag): Fix external declaration.
934
6d5eb5b0
SM
9352011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 Don't macro-inline non-performance-critical code.
938 * eval.c (process_quit_flag): New function.
939 * lisp.h (QUIT): Use it.
940
a0c3fad0
JD
9412011-12-04 Jan Djärv <jan.h.d@swipnet.se>
942
943 * nsfns.m (get_geometry_from_preferences): New function.
944 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
945
6c07aac2
AS
9462011-12-04 Andreas Schwab <schwab@linux-m68k.org>
947
948 * emacs.c (Qkill_emacs): Define.
949 (syms_of_emacs): Initialize it.
950 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
951 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
952 (quit_throw_to_read_char): Add parameter `from_signal'.
953 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
954 * lisp.h (QUIT): Call Fkill_emacs if requested.
955
c052ead4
JD
9562011-12-03 Jan Djärv <jan.h.d@swipnet.se>
957
958 * widget.c (update_wm_hints): Return if wmshell is null.
959 (widget_update_wm_size_hints): New function.
960
961 * widget.h (widget_update_wm_size_hints): Declare.
962
963 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
964 widget_update_wm_size_hints (Bug#10104).
965
9e49252b
EZ
9662011-12-03 Eli Zaretskii <eliz@gnu.org>
967
968 * xdisp.c (handle_invisible_prop): If the invisible text ends just
969 before a newline, prepare the bidi iterator for consuming the
970 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 971 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 972
02b16839
JL
9732011-12-02 Juri Linkov <juri@jurta.org>
974
975 * search.c (Fword_search_regexp): New Lisp function created from
976 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
977 (Fword_search_backward, Fword_search_forward)
978 (Fword_search_backward_lax, Fword_search_forward_lax):
979 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
980 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
981
0068070e
SM
9822011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
983
984 * fileio.c (Finsert_file_contents): Move after-change-function call
985 to before the "handled:" label, since all "goto handled" appear in
986 cases where the *-change-functions have already been properly called
987 (bug#10117).
988
3360a3fc
AS
9892011-12-01 Andreas Schwab <schwab@linux-m68k.org>
990
991 * keyboard.c (interrupt_signal): Don't call kill-emacs when
992 waiting for input. (Bug#10169)
993
73d6c093
EZ
9942011-11-30 Eli Zaretskii <eliz@gnu.org>
995
996 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
997 verifies glyph row's hash code--we have just reallocated the
998 glyphs, so their contents can be complete garbage. (Bug#10164)
999
febe6bea
JB
10002011-11-30 Juanma Barranquero <lekktu@gmail.com>
1001
1002 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1003
801a4313
EZ
10042011-11-30 Eli Zaretskii <eliz@gnu.org>
1005
1006 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1007 attributes are tested _before_ calling verify_row_hash, to protect
1008 against GCC re-ordering of the tests. (Bug#10164)
1009
2b56b87e
JD
10102011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1011
1012 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1013
1014 * xterm.c (handle_one_xevent): Only set async_visible and friends
1015 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1016 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1017 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1018
dbf31225
PE
10192011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1022 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1023 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1024 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1025 All uses changed to use GCPRO1 etc.
1026 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1027 Revert to old implementation (i.e., before 2011-03-11).
1028
1305621b
YM
10292011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1030
1031 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1032 of scroll runs so as to avoid assigning disabled bogus rows and
1033 unnecessary graphics copy operations.
1034
8c9afb46
EZ
10352011-11-27 Eli Zaretskii <eliz@gnu.org>
1036
1037 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1038 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1039 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1040 (malloc, free, realloc, calloc): Redirect to e_* only when
1041 compiling Emacs.
1042
1043 * lisp.h (GCTYPEBITS): Move before first use.
1044 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1045 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1046 this macro definition.
1047
1048 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1049 _MSC_VER.
1050
54e9e3bf
JD
10512011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1052
6d5eb5b0
SM
1053 * gtkutil.c (xg_create_frame_widgets):
1054 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1055 present with Gtk+ 2.0.
1056
83aca1cb
PE
10572011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 * fileio.c (Finsert_file_contents): Undo previous change; see
1060 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1061
5b76caa4
PE
10622011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 Rename locals to avoid shadowing.
1065 * fileio.c (Finsert_file_contents):
1066 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1067 * process.c (wait_reading_process_output):
1068 Rename inner 'proc' to 'p' to avoid shadowing.
1069 Indent for consistency with usual Emacs style.
1070
8c535114
EZ
10712011-11-25 Eli Zaretskii <eliz@gnu.org>
1072
1073 * xdisp.c (redisplay_window): If cursor row is not fully visible
1074 after recentering, and scroll-conservatively is set to a large
1075 number, scroll window by a few more lines to make the cursor fully
1076 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1077 (start_display): Don't move to the next line if the display should
1078 start at a newline that is part of a display vector or an overlay
1079 string. (Bug#10119)
8c535114 1080
fa4fdb5c
JL
10812011-11-24 Juri Linkov <juri@jurta.org>
1082
1083 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1084 after the `MagickPingImage' call. (Bug#10112)
1085
90ec88df
CY
10862011-11-23 Chong Yidong <cyd@gnu.org>
1087
1088 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1089
56e2e794
MR
10902011-11-23 Martin Rudalics <rudalics@gmx.at>
1091
1092 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1093 making another buffer current. (Bug#10114)
1094
b6e64c41
GM
10952011-11-23 Glenn Morris <rgm@gnu.org>
1096
1097 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1098
6b21de18
CY
10992011-11-23 Chong Yidong <cyd@gnu.org>
1100
1101 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1102 using it (Bug#5984).
1103
b12cd789
EZ
11042011-11-22 Eli Zaretskii <eliz@gnu.org>
1105
1106 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1107 and header-lines, as they don't have one computed for them.
1108 (Bug#10098)
1109
1110 * .gdbinit (prow): Make displayed values more self-explaining.
1111 Add row's hash code.
1112
261b6fd4
LMI
11132011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1114
1115 * process.c (wait_reading_process_output): Fix asynchrounous
1116 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1117 (wait_reading_process_output): Add comment and URL.
261b6fd4 1118
e7cfd277
JD
11192011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1120
1121 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1122
a9b9b7f5
CY
11232011-11-21 Chong Yidong <cyd@gnu.org>
1124
1125 * window.c (Fnext_window, Fprevious_window): Doc fix.
1126
b0d15b4f
SM
11272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1128
1129 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1130
fe7a3057
JB
11312011-11-20 Juanma Barranquero <lekktu@gmail.com>
1132
1133 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1134
d2999b1a
MR
11352011-11-20 Martin Rudalics <rudalics@gmx.at>
1136
1137 * window.c (Fset_window_combination_limit): Rename argument
1138 STATUS to LIMIT.
1139 (Vwindow_combination_limit): Remove "status" from doc-string.
1140
d5ff9cd0
AS
11412011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1142
1143 * m/ibms390.h: Remove.
1144 * m/ibms390x.h: Don't include "ibms390.h".
1145
a5bb9bd3
SM
11462011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1147
1148 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1149 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1150
cd1181db
JB
11512011-11-20 Juanma Barranquero <lekktu@gmail.com>
1152
1153 * casetab.c (Fset_case_table):
1154 * charset.c (Fcharset_after): Fix typos.
1155
615a3b8d 11562011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1157
17e845af
PE
1158 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1159 Otherwise, valgrind does not work on some platforms.
1160 Problem reported by Andreas Schwab in
6a0bf43d
PE
1161 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1162 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1163 is set, removing the need for VIRT_ADDRESS_VARIES.
1164 (PURE_P): Use a more-efficient implementation that needs just one
1165 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1166 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1167 to 4 (xorl, subq, cmpq, setbe).
1168 * alloc.c (pure): Always extern now, since that's the
1169 VIRT_ADDR_VARIES behavior.
1170 (PURE_POINTER_P): Use a single comparison, not two, for
1171 consistency with the new puresize.h.
1172 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1173 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1174 Remove VIRT_ADDR_VARIES no longer needed.
1175
f8fe6f96
EZ
11762011-11-19 Eli Zaretskii <eliz@gnu.org>
1177
1178 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1179 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1180 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1181 behave as if the cursor position were at the window margin.
1182
1183 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1184 and the cursor position is out of bounds, behave as if the cursor
1185 position were at the window margin. (Bug#10075)
1186
df05a53c
CY
11872011-11-18 Chong Yidong <cyd@gnu.org>
1188
1189 * window.c (Fwindow_combination_limit): Make first argument
1190 non-optional, since it is meaningless for live windows like the
1191 selected window.
1192
2071918e
DA
11932011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1194
1195 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1196
b50a28de
SM
11972011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1198
1199 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1200 (graft_intervals_into_buffer): Simplify.
1201
015137db
EZ
12022011-11-18 Eli Zaretskii <eliz@gnu.org>
1203
1204 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1205 hash values of the two rows.
1206 (copy_row_except_pointers): Preserve the used[] arrays and the
1207 hash values of the two rows. (Bug#10035)
68c95424 1208 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1209
1210 * xdisp.c (row_hash): New function, body extracted from
1211 compute_line_metrics.
1212 (compute_line_metrics): Call row_hash, instead of computing the
1213 hash code inline.
1214
1215 * dispnew.c (verify_row_hash): Call row_hash for computing the
1216 hash code of a row, instead of duplicating code from xdisp.c.
1217
1218 * dispextern.h (row_hash): Add prototype.
1219
a2addb04
TH
12202011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1221
1222 * frame.c (delete_frame): Don't delete the terminal when the last
1223 X frame is closed if emacs is built with GTK toolkit.
1224
df85d315
JB
12252011-11-17 Juanma Barranquero <lekktu@gmail.com>
1226
1227 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1228
a0c2d0ae
MR
12292011-11-17 Martin Rudalics <rudalics@gmx.at>
1230
1231 * window.c (Vwindow_splits): Rename to
1232 Vwindow_combination_resize. Suggested by Juri Linkov.
1233 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1234 of Vwindow_splits.
1235
58179cce
JB
12362011-11-16 Juanma Barranquero <lekktu@gmail.com>
1237
7877f373
JB
1238 * nsfns.m (Fns_font_name):
1239 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1240
b6f67890
MR
12412011-11-16 Martin Rudalics <rudalics@gmx.at>
1242
1243 * window.h (window): Rename slot "nest" to "combination_limit".
1244 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1245 (Fset_window_nest): Rename to Fset_window_combination_limit.
1246 (Vwindow_nest): Rename to Vwindow_combination_limit.
1247 (recombine_windows, make_parent_window, make_window)
1248 (Fsplit_window_internal, saved_window)
1249 (Fset_window_configuration, save_window_save): Rename all
1250 occurrences of window_nest to window_combination_limit.
1251
c7015153
JB
12522011-11-15 Juanma Barranquero <lekktu@gmail.com>
1253
1254 * image.c (imagemagick_load_image): Fix typo.
1255
322ad6ec
EZ
12562011-11-14 Eli Zaretskii <eliz@gnu.org>
1257
1258 * xdisp.c (display_line): Move the call to
1259 highlight_trailing_whitespace before the call to
1260 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1261 faces of all the glyphs to compute ROW's hash value.
1262 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1263
f067b8ec
JB
12642011-11-14 Juanma Barranquero <lekktu@gmail.com>
1265
1266 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1267 just return (bug#10044).
1268
1e5b2111
EZ
12692011-11-12 Eli Zaretskii <eliz@gnu.org>
1270
7ef3cbd5
EZ
1271 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1272 with user-defined heap size. Bump the default size of the temacs
1273 heap to 27MB, to avoid memory warning when running temacs.
1274 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1275
1e5b2111
EZ
1276 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1277 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1278 (verify_row_hash) [XASSERTS]: New function.
1279 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1280 that the hash value of glyph rows is correct.
1e5b2111 1281
89d61221
MR
12822011-11-12 Martin Rudalics <rudalics@gmx.at>
1283
1284 * window.h (window): Remove splits slot.
1285 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1286 (Fdelete_other_windows_internal, make_parent_window)
1287 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1288 (Fset_window_configuration, save_window_save): Don't deal with
1289 split status of windows.
1290 (saved_window): Remove splits slot.
1291 (Vwindow_splits): Rewrite doc-string.
1292
97f18cc8
JD
12932011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1294
1295 * xfns.c (unwind_create_frame):
1296 * nsfns.m (unwind_create_frame):
1297 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1298 Vframe_list (Bug#9999).
1299
22a648b4
DA
13002011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1301
0b381c7e 1302 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1303
659afede
KH
13042011-11-11 Kenichi Handa <handa@m17n.org>
1305
1306 * callproc.c (Fcall_process): Set the member dst_multibyte of
1307 process_coding.
1308
9ac0394b
KH
13092011-11-11 Johan Bockgård <bojohan@gnu.org>
1310
1311 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1312 avoid a crash (bug#9496).
1313
2fbdc249
CY
13142011-11-09 Chong Yidong <cyd@gnu.org>
1315
1316 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1317 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1318
ac6b1f81
PE
13192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1322
09db192c
PE
13232011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Avoid some portability problems by eschewing 'extern inline' functions.
1326 The trivial performance wins aren't worth the portability hassles; see
1327 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1328 et seq.
1329 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1330 (window_box_width, window_box_left, window_box_left_offset)
1331 (window_box_right, window_box_right_offset): Undo previous change,
1332 by removing the "extern"s.
1333 * intervals.c (adjust_intervals_for_insertion)
1334 (adjust_intervals_for_deletion): Undo previous change,
1335 making these static again.
1336 (offset_intervals, temp_set_point_both, temp_set_point)
1337 (copy_intervals_to_string): No longer inline.
1338 * xdisp.c (window_text_bottom_y, window_box_width)
1339 (window_box_height, window_box_left_offset)
1340 (window_box_right_offset, window_box_left, window_box_right)
1341 (window_box): No longer inline.
1342
105216ed
CY
13432011-11-08 Chong Yidong <cyd@gnu.org>
1344
1345 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1346 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1347 Signal an error if not a live window.
105216ed
CY
1348 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1349 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1350
ae9e237f
JB
13512011-11-07 Juanma Barranquero <lekktu@gmail.com>
1352
1353 * lisp.h (syms_of_abbrev): Remove declaration.
1354 Reported by CHENG Gao <chenggao@royau.me>.
1355
c7aa8333
EZ
13562011-11-07 Eli Zaretskii <eliz@gnu.org>
1357
1358 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1359 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1360 of temacs in GUI mode.
1361
be7f5545
MR
13622011-11-07 Martin Rudalics <rudalics@gmx.at>
1363
1364 * window.h: Declare delete_all_child_windows instead of
1365 delete_all_subwindows.
1366 * window.c (Fwindow_nest, Fset_window_nest)
1367 (Fset_window_new_total, Fset_window_new_normal)
1368 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1369 (delete_all_subwindows): Rename to delete_all_child_windows.
1370 (Fdelete_other_windows_internal, Fset_window_configuration):
1371 Call delete_all_child_windows instead of delete_all_subwindows.
1372 * frame.c (delete_frame): Call delete_all_child_windows instead
1373 of delete_all_subwindows.
1374
ca78dc43
PE
13752011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1376
1377 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1378 This is also needed for porting to any host where GC_MARK_STACK is
1379 not GC_MAKE_GCPROS_NOOPS.
1380 (which_symbols): Use it.
1381
a0241d01
KH
13822011-11-07 Kenichi Handa <handa@m17n.org>
1383
1384 * coding.c (coding_set_destination): Check coding->src_pos only
1385 when coding->src_object is a buffer (bug#9910).
1386
1387 * process.c (send_process): Set the member src_multibyte of coding
1388 to 0 (bug#9911) when sending a unibyte text.
1389
1390 * callproc.c (Fcall_process): Set the member src_multibyte of
1391 process_coding to 0 (bug#9912).
1392
a64bfdfa 13932011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1394
1395 * xmenu.c (cleanup_widget_value_tree): New function.
1396 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1397 calling free_menubar_widget_value_tree directly (Bug#9830).
1398
cb41b32a
PE
13992011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 Fix some portability problems with 'inline'.
1402 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1403 (window_box_width, window_box_left, window_box_left_offset)
1404 (window_box_right, window_box_right_offset): Declare extern.
1405 Otherwise, these inline functions do not conform to C99 and
1406 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1407 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1408 * intervals.c (adjust_intervals_for_insertion)
1409 (adjust_intervals_for_deletion): Now extern, because otherwise the
1410 extern inline functions 'offset_intervals' couldn't refer to it.
1411 (static_offset_intervals): Remove.
1412 (offset_intervals): Rewrite using the old contents of
1413 static_offset_intervals. The old version didn't conform to C99
1414 because an extern inline function contained a reference to an
1415 identifier with static linkage.
1416
b7041366
AS
14172011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1418
1419 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1420 GC.
1421
88a37c4d
EZ
14222011-11-06 Eli Zaretskii <eliz@gnu.org>
1423
1424 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1425 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1426 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1427 return Qleft_to_right.
1428
49745b39
CY
14292011-11-06 Chong Yidong <cyd@gnu.org>
1430
1431 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1432 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1433 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1434 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1435 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1436 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1437 (Fwindow_vscroll): Doc fix.
1438 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1439 argument, since it makes no sense to pass a live window and for
1440 consistency with window-child.
1441
1f05cd82
CS
14422011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1443
1444 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1445 support MSVC.
1446
22610910
JR
14472011-11-05 Jason Rumney <jasonr@gnu.org>
1448
1449 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1450 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1451 fonts (Bug#6029).
1452 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1453 bitwise arithmetic preventing use of unicode-sip and non-truetype
1454 opentype fonts.
1455
a06776b2
EZ
14562011-11-05 Eli Zaretskii <eliz@gnu.org>
1457
3ad924ba
EZ
1458 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1459 "emacs"-only part.
1460
a06776b2
EZ
1461 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1462 initialization code to keep similarity to xfns.c after changes
1463 from 2011-11-05.
1464
c9e7db78
JD
14652011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1466
a97f8f3f
JD
1467 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1468 (unwind_create_frame): New function (Bug#9943).
1469 (Fx_create_frame): Restructure code to be more similar to the one in
1470 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1471 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1472 Move terminal->reference_count++ just before making the frame official
1473 (Bug#9943).
1474
1475 * nsterm.m (x_free_frame_resources): New function.
1476 (x_destroy_window): Move code to x_free_frame_resources.
1477
c9e7db78 1478 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1479 (Fx_create_frame, x_create_tip_frame):
1480 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1481 official. Move initialization of image_cache_refcount and
1482 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1483
a6fc3b5c
EZ
14842011-11-05 Eli Zaretskii <eliz@gnu.org>
1485
1486 Support MSVC build with newer versions of Visual Studio.
1487 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1488 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1489 nt/gmake.defs.
1490
1491 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1492 which are not supported by MSVC.
1493 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1494 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1495 bitfields.
1496 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1497 types in bitfields.
1498 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1499
1500 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1501
58179cce 15022011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1503
1504 Support MSVC build with newer versions of Visual Studio.
1505 * w32.c: Don't include w32api.h for MSVC.
1506 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1507
1508 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1509 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1510 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1511 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1512 e_* cousins.
1513 (alloca) [_MSC_VER]: Define to _alloca.
1514
1515 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1516
1517 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1518
a58c13ed
EZ
15192011-11-04 Eli Zaretskii <eliz@gnu.org>
1520
1521 * xdisp.c (note_mouse_highlight): If either of
1522 previous/next-single-property-change returns nil, treat that as
1523 the beginning or the end of the buffer. (Bug#9955)
1524
fe0b6370
JD
15252011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1526
a58c13ed 1527 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1528 label is not null (Bug#9951).
1529 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1530 may be NULL.
1531
89bd5ee1
EZ
15322011-11-04 Eli Zaretskii <eliz@gnu.org>
1533
1534 * window.c (Fwindow_body_size): Mention in the doc string that the
1535 return value is in frame's canonical units. (Bug#9949)
1536
84c3edb9
EZ
15372011-11-03 Eli Zaretskii <eliz@gnu.org>
1538
4e2fb5c7
EZ
1539 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1540
84c3edb9 1541 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1542 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1543 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1544
bc17a887
EZ
15452011-11-01 Eli Zaretskii <eliz@gnu.org>
1546
1547 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1548 Don't stop backward scan on the continuation glyph, even though
1549 its CHARPOS is positive.
6d5eb5b0
SM
1550 (mouse_face_from_buffer_pos, note_mouse_highlight):
1551 Rename cover_string to disp_string.
bc17a887 1552
4ee88440
MR
15532011-11-01 Martin Rudalics <rudalics@gmx.at>
1554
1555 * window.c (temp_output_buffer_show): Don't use
1556 Vtemp_buffer_show_specifiers.
1557 (Vtemp_buffer_show_specifiers): Remove unused variable.
1558
c2ff3c02
EZ
15592011-10-30 Eli Zaretskii <eliz@gnu.org>
1560
1561 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1562 past the beginning of the current glyph matrix.
1563
58179cce 15642011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1565
1566 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1567 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1568 HAVE_GTK3 (Bug#9869).
b77a6a7f 1569
3b574623
JD
1570 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1571 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1572
b77a6a7f
JD
1573 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1574
1575 * xterm.c: Declare x_handle_net_wm_state to return int.
1576 (handle_one_xevent): Check if we are iconified but don't have
1577 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1578 (get_current_wm_state): Return non-zero if not hidden,
1579 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1580 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1581 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1582 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1583
196e41e4
PE
15842011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1587 so that this new function doesn't get optimized away by a
1588 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1589
021f2e1a
AS
15902011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1591
1592 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1593
8b058d44
EZ
15942011-10-29 Eli Zaretskii <eliz@gnu.org>
1595
1596 Fix the `xbytecode' command.
1597 * .gdbinit (xprintbytestr): New command.
b50a28de 1598 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1599 (xbytecode): Print the byte-code string as well.
1600
4452fb80
EZ
16012011-10-29 Kim Storm <storm@cua.dk>
1602
8b058d44
EZ
1603 * alloc.c (which_symbols): New function.
1604
21b72067
AS
16052011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1606
1607 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1608 line. (Bug#9903)
1609
83ed7b5c
GM
16102011-10-29 Glenn Morris <rgm@gnu.org>
1611
1612 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1613 Not clear what it was for, and it causes various bugs. (Bug#9839)
1614
5a7a728b
EZ
16152011-10-28 Eli Zaretskii <eliz@gnu.org>
1616
1617 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1618 possible random value that matches one of those tested as
1619 condition to clear the mouse face.
1620
d3d0842f
CY
16212011-10-28 Chong Yidong <cyd@gnu.org>
1622
1623 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1624
31b39d13
DN
16252011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1626
1627 * window.c (make_window): Initialize phys_cursor_on_p.
1628
9aba6043
SM
16292011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1630
1631 * lisp.h (struct Lisp_Symbol): Update comments.
1632
c20992f4
JB
16332011-10-28 Juanma Barranquero <lekktu@gmail.com>
1634
1635 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1636
db4f02f2
EZ
16372011-10-28 Eli Zaretskii <eliz@gnu.org>
1638
1639 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1640 <oslsachem@gmail.com> for helping to debug this.
1641
1642 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1643 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1644 (g_b_init_get_glyph_outline_w): New static variables.
1645 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1646 (GetGlyphOutlineW_Proc): New typedefs.
1647 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1648 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1649 New functions.
1650 (w32font_open_internal, compute_metrics):
1651 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1652 instead of calling the "wide" APIs directly.
1653
1654 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1655
1656 * w32.h (syms_of_w32font): Add prototype.
1657
87e68db4
JB
16582011-10-27 Juanma Barranquero <lekktu@gmail.com>
1659
1660 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1661 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1662 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1663 (Fmove_to_window_line): Doc fix.
1664
435c1d67
CY
16652011-10-27 Chong Yidong <cyd@gnu.org>
1666
1667 * process.c (make_process): Set gnutls_state to NULL.
1668
1669 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1670 non-NULL, regardless of GNUTLS_INITSTAGE.
1671 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1672 an error. Set process slots as soon as we allocate them.
1673
1674 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1675
9c6c6f49
CY
16762011-10-27 Chong Yidong <cyd@gnu.org>
1677
9aba6043
SM
1678 * gnutls.c (emacs_gnutls_deinit): New function.
1679 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1680 (Fgnutls_deinit, Fgnutls_boot): Use it.
1681
1682 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1683 (deactivate_process): Call emacs_gnutls_deinit.
1684
657d08d3
JB
16852011-10-27 Juanma Barranquero <lekktu@gmail.com>
1686
1687 * image.c (x_create_x_image_and_pixmap):
1688 * w32.c (sys_rename, w32_delayed_load):
1689 * w32font.c (fill_in_logfont):
1690 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1691
5430d399
JB
16922011-10-26 Juanma Barranquero <lekktu@gmail.com>
1693
1694 * w32fns.c (w32_default_color_map): New function,
1695 extracted from Fw32_default_color_map.
a7ef684b 1696 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1697
fe0055fa
PE
16982011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1699
1700 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1701
e6346438
SM
17022011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1703
1704 * keyboard.c (test_undefined): New function (bug#9751).
1705 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1706
e112cc37
ET
17072011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1708
1709 * sysdep.c (init_sys_modes): Fix the check for the controlling
1710 terminal (Bug#6649).
1711
7b5d6677
EZ
17122011-10-20 Eli Zaretskii <eliz@gnu.org>
1713
1714 * dispextern.h (struct bidi_it): New member next_en_type.
1715
1716 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1717 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1718 current character, check also for next_en_type being WEAK_EN.
1719 (bidi_resolve_weak): Don't enter the expensive loop if the current
1720 position is before next_en_pos. Record the bidi type of the first
1721 non-ET, non-BN character we find, in addition to its position.
1722 (bidi_level_of_next_char): Invalidate next_en_type when
1723 next_en_pos is over-stepped.
1724
7da0b018
PE
17252011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1726
1727 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1728 * editfns.c: Rewrite current-time-zone so that it invokes
1729 the equivalent of (format-time-string "%Z") to get the time zone name.
1730 This fixes a bug when the time zone name contains characters that
1731 need converting from the system time locale to Emacs internal format.
1732 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1733 that patch fixed format-time-string to do the conversion, but
1734 I forgot to fix current-time-zone.
1735 (format_time_string): New function, containing most of
1736 what Fformat_time_string used to contain.
1737 (Fformat_time_string): Rewrite in terms of format_time_string.
1738 This doesn't change this function's behavior.
1739 (current-time-zone): Rewrite to use format_time_string.
1740 This fixes the bug reported by Michael Schierl in
1741 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1742 Jason Rumney's 2007-06-07 change worked around this bug, but
1743 didn't fix it.
1744 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1745
8547b010
EZ
17462011-10-19 Eli Zaretskii <eliz@gnu.org>
1747
1748 * xdisp.c (start_display): If the character at POS is displayed
1749 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1750 (try_window_reusing_current_matrix): If a line ends in a display
1751 vector or the next line starts in a display vector, continue
1752 redrawing the window even though the character position of
1753 start_row was reached.
8547b010
EZ
1754 (Bug#9771, part 2)
1755
4e948d15
CY
17562011-10-18 Chong Yidong <cyd@gnu.org>
1757
1758 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1759 with nobreak-char-display too.
1760
4787455f
EZ
17612011-10-18 Eli Zaretskii <eliz@gnu.org>
1762
1763 Fix part 3 of bug#9771.
1764 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1765 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1766 non-neutral characters if the current character is a paragraph
1767 separator (a.k.a. Newline). This avoids running the same
1768 expensive loop twice, once when we consume the preceding newline
1769 and the other time when the line actually needs to be displayed.
1770 Avoid the loop when we see neutrals on the base embedding level
1771 following a character whose directionality is the same as the
1772 paragraph's. This avoids running the expensive loop when a line
1773 ends in a long sequence of neutrals, like control characters.
1774 Add assertion against STRONG_AL type. Slightly rearrange code
1775 that determines the type of a neutral given the first non-neutral
1776 that follows it.
1777 (bidi_level_of_next_char): Set next_en_pos to zero when
1778 invalidating its info.
1779
2c91f553
EZ
17802011-10-17 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (push_display_prop): Determine whether to record string
1783 or buffer position by IT->string, not by IT->method. Allow
1784 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1785 (move_it_vertically_backward): Don't look for character position
1786 immediately after the newline when in a continuation line.
1787 (Bug#9771, part 1)
2c91f553 1788
c7b08b0d
MR
17892011-10-15 Martin Rudalics <rudalics@gmx.at>
1790
1791 * window.c (coordinates_in_window): Rewrite and delabelize
1792 vertical border check. (Bug#5357) (Bug#9618)
1793
6b02f655
SM
17942011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1795
1796 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1797 errors in XSetWindowBorder (bug#9310).
1798
81d40c92
DA
17992011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1800
1801 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1802 avoid crash when xmalloc overrun checking is enabled.
1803
d4172c3b
EZ
18042011-10-13 Eli Zaretskii <eliz@gnu.org>
1805
1806 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1807 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1808 cursor motion with <left> and <right> arrow keys.
1809
1810 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1811 some callers set that themselves.
1812
b00eea75
EZ
18132011-10-12 Eli Zaretskii <eliz@gnu.org>
1814
1815 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1816 display string and the previous row comes from the same string and
1817 is empty. (Bug#9739) (Bug#9738)
1818
8fe012c4
SM
18192011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1820
1821 * doc.c (get_doc_string): Encode file name (bug#9735).
1822
0074aef2
EZ
18232011-10-12 Eli Zaretskii <eliz@gnu.org>
1824
79beb178
EZ
1825 * bidi.c (bidi_level_of_next_char):
1826 * xdisp.c (get_visually_first_element): Remove old incorrect
1827 comments regarding the Unicode Line Separator character.
1828
0074aef2
EZ
1829 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1830
6e4b3fbe
DA
18312011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1832
1833 * alloc.c (Fgc_status): Do not access beyond zombies array
1834 boundary if nzombies > MAX_ZOMBIES.
1835 * alloc.c (dump_zombies): Add missing format specifier.
1836
0324f3af
PE
18372011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1838
b5525cac
PE
1839 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1840 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1841
0324f3af
PE
1842 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1843 Some packages use them to denote characters with modifiers.
1844
e9b5f888
AS
18452011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1846
1847 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1848 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1849 matching a pp-number. Rename parameter var to var1.
1850
127827c0
SM
18512011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1852
1853 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1854
c8fd3bd0
GM
18552011-10-08 Glenn Morris <rgm@gnu.org>
1856
1857 * callint.c (Fcall_interactively): Give a more explicit error for the
1858 'c' case with a non-character input. (Bug#8479)
1859
352ec8ff
EZ
18602011-10-08 Eli Zaretskii <eliz@gnu.org>
1861
03669ccb
EZ
1862 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1863 lines.
7061c986
EZ
1864 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1865 lines that are hscrolled on the left.
03669ccb 1866
352ec8ff
EZ
1867 * dispnew.c (buffer_posn_from_coords): Account for a possible
1868 presence of header-line. (Bug#4426)
1869
a66cfb1c
SM
18702011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1871
6b02f655
SM
1872 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1873 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1874
7c5ee88e
PE
18752011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1878 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1879 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1880 this makes Emacs dump core during garbage collection on rare
1881 occasions. sizeof is obviously inferior to offsetof here, so
1882 stick with offsetof.
1883 (GC_POINTER_ALIGNMENT): New macro.
1884 (mark_memory): Omit 3rd (offset) arg; caller changed.
1885 Don't assume EMACS_INT alignment is the same as pointer alignment.
1886
df1bbe5b
SM
18872011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1888
1889 * keyboard.c (read_key_sequence_remapped): New var.
1890 (read_key_sequence): Compute remapping in the right buffer.
1891 (command_loop_1): Use read_key_sequence's remapping directly.
1892
51553db6
SM
18932011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1894
32c1fffd
SM
1895 * dired.c (file_name_completion): Don't expand file name.
1896 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1897 before checking file name handler.
1898
51553db6
SM
1899 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1900 they've been requested explicitly (bug#9591).
1901
b6bd1599 19022011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1903
1904 * keymap.c (Fsingle_key_description): Use make_specified_string
1905 instead of build_string to build string from push_key_description.
1906 (Bug#5193)
1907
f701dc2a
PE
19082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1909
4222c55d
PE
1910 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1911 This fixes a Y2038 bug on 64-bit hosts.
1912 * buffer.c (reset_buffer):
1913 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1914 (Fclear_buffer_auto_save_failure):
1915 Use 0, not -1, to represent an unset failure time, since time_t
1916 might not be signed.
1917
f701dc2a
PE
1918 Remove dependency on glibc malloc internals.
1919 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1920 Move back here from lisp.h, but with their new implementations.
1921 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1922 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1923 * charset.c (charset_table_init): New static var.
1924 (syms_of_charset): Use it instead of xmalloc. This removes a
1925 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1926 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1927 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1928 Move back to alloc.c.
1929 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1930 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1931
9ceebf39
JD
19322011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1933
1934 * nsterm.m (windowDidResize): Call x_set_window_size only when
1935 ns_in_resize is true. Otherwise set pixelwidth/height and
1936 call change_frame_size (Bug#9628).
1937
cb993c58
PE
19382011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1939
3930c88b
PE
1940 Port --enable-checking=all to Fedora 14 x86-64.
1941 * charset.c (syms_of_charset): Also account for glibc malloc's
1942 internal overhead when calculating the initial malloc maximum.
1943
cb993c58
PE
1944 Port --enable-checking=all to Fedora 14 x86.
1945 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1946 Move to lisp.h.
1947 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1948 (overrun_check_realloc, overrun_check_free):
1949 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1950 That way, xmalloc returns a properly-aligned pointer even if
1951 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1952 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1953 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1954 into account when calculating the initial malloc maximum.
1955 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1956 Move here from alloc.c, so that charset.c can use it too.
1957 Properly align; the old code wasn't right for common 32-bit hosts
1958 when configured with --enable-checking=all.
1959 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1960 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1961
31bed486
EZ
19622011-09-29 Eli Zaretskii <eliz@gnu.org>
1963
04c70788 1964 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1965 use EDOM.
1966
fbcaa2f3
EZ
19672011-09-28 Eli Zaretskii <eliz@gnu.org>
1968
1969 * xdisp.c (compute_display_string_end): If there's no display
1970 string at CHARPOS, return -1.
1971
1972 * bidi.c (bidi_fetch_char): When compute_display_string_end
1973 returns a negative value, treat the character as a normal
1974 character not covered by a display string. (Bug#9624)
1975
a239d4e9
JB
19762011-09-28 Juanma Barranquero <lekktu@gmail.com>
1977
1978 * lread.c (Fread_from_string): Fix typo in docstring.
1979
88652fd5
EZ
19802011-09-27 Eli Zaretskii <eliz@gnu.org>
1981
1982 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1983 newline, reseat the iterator instead of bidi-iterating there one
1984 character at a time. (Bug#9610)
32c1fffd
SM
1985 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1986 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1987
ed497dd4
AS
19882011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1989
1990 * lread.c (readevalloop): Use correct code for NBSP.
1991 (read1): Likewise. (Bug#9608)
1992
b2bf61aa
MA
19932011-09-25 Michael Albinus <michael.albinus@gmx.de>
1994
1995 * dbusbind.c (Fdbus_register_signal): When service is not
1996 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1997
32bbb17c
GM
19982011-09-25 Glenn Morris <rgm@gnu.org>
1999
2000 * buffer.c (truncate-lines): Doc fix.
2001
94e0933e
CY
20022011-09-24 Chong Yidong <cyd@stupidchicken.com>
2003
2004 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2005 (Fset_window_next_buffers): Doc fix.
2006
cddde921
GM
20072011-09-24 Glenn Morris <rgm@gnu.org>
2008
2009 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2010
1260aef1
PE
20112011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2012
25b4bfa0
PE
2013 Fix minor problems found by static checking.
2014 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2015 * indent.c (Fvertical_motion): Fix == vs = typo.
2016
e3cbd34b
EZ
20172011-09-24 Eli Zaretskii <eliz@gnu.org>
2018
a66cfb1c
SM
2019 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2020 Default value is now t. Doc fix.
6bf7006f 2021
e3cbd34b 2022 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2023 logic when moving up, not only when moving down. Fix the
e3cbd34b 2024 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2025 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2026
2027 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2028 CHARPOS is covered by a display string which includes newlines.
2029 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2030 is covered by a display string with embedded newlines.
2031
a3de0cbd
MA
20322011-09-24 Michael Albinus <michael.albinus@gmx.de>
2033
2034 * dbusbind.c (Fdbus_register_signal): Add match rule to
2035 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2036 (Fdbus_register_method, Vdbus_registered_objects_table):
2037 Fix docstring.
a3de0cbd 2038
b260039d
JM
20392011-09-24 Jim Meyering <meyering@redhat.com>
2040
32c1fffd 2041 do not ignore write error for any output size
b260039d
JM
2042 The previous change was incomplete.
2043 While it makes emacs --batch detect the vast majority of stdout
2044 write failures, errors were still ignored whenever the output size is
2045 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2046 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2047 && echo FAIL: ignored write error
2048 FAIL: ignored write error
2049 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2050 && echo FAIL: ignored write error
2051 FAIL: ignored write error
2052 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2053
8eca8a7c
AS
20542011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2055
2056 * emacs.c (Fkill_emacs): In noninteractive mode exit
2057 non-successfully if a write error occurred on stdout. (Bug#9574)
2058
3341db62
EZ
20592011-09-21 Eli Zaretskii <eliz@gnu.org>
2060
2061 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2062 the xassert test.
2063
2064 * dispextern.h (struct it): Update the comment documenting what
2065 can it->OBJECT be.
2066
8c203dbf
EZ
20672011-09-20 Eli Zaretskii <eliz@gnu.org>
2068
2069 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2070 a display string, extend search for cursor position to end of row.
2071 (find_row_edges): If the row ends in a newline from a display
2072 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2073 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2074 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2075 non-empty line. Fixes confusing cursor motion with arrow keys at
2076 the beginning of a line that starts with whitespace.
8c203dbf 2077
a4824228
LMI
20782011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2079
2080 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2081 (bug#9493).
2082
33ed493b
CY
20832011-09-18 Chong Yidong <cyd@stupidchicken.com>
2084
2085 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2086 boolean (Bug#9154).
2087
56cd55c8
EZ
20882011-09-18 Eli Zaretskii <eliz@gnu.org>
2089
2090 * xdisp.c (display_line): Record maximum and minimum buffer
2091 positions even if no glyphs were produced (e.g., by a zero-width
2092 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2093 buffer positions that will be removed from the glyph row because
2094 they don't fit.
c02dcedf
EZ
2095 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2096 column is beyond frame width: don't subtract 1 "pixel" when
2097 computing width of the stretch.
3e62b7e0
EZ
2098 (reseat_at_next_visible_line_start): Undo the change made on
2099 2011-09-17 that saved paragraph information and restored it after
2100 the call to `reseat'. (Bug#9545)
56cd55c8 2101
5ed99d36 21022011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2103
2104 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2105 and turn window cursor on if cleared (Bug#9415).
2106
5ed99d36 21072011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2108
2109 * search.c (boyer_moore): Take unibyte characters from pattern
2110 literally. (Bug#9458)
2111
9bade7b2
EZ
21122011-09-18 Eli Zaretskii <eliz@gnu.org>
2113
2114 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2115
e5e9d610
PE
21162011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2117
87e4427a
PE
2118 Fix minor problem found by static checking.
2119 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2120 initialized, to pacify gcc -Wuninitialized.
2121
e5e9d610
PE
2122 * fileio.c: Report proper errno when syscall falls.
2123 (Finsert_file_contents): Save and restore errno,
2124 so that report_file_error outputs the correct diagnostic.
2125 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2126
a1674f0b
EZ
21272011-09-18 Eli Zaretskii <eliz@gnu.org>
2128
2129 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2130
fbfb6dd4
EZ
21312011-09-17 Eli Zaretskii <eliz@gnu.org>
2132
2133 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2134 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2135
bb187662
EZ
21362011-09-17 Eli Zaretskii <eliz@gnu.org>
2137
1137e8b8 2138 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2139 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2140
2141 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2142 (bidi_find_paragraph_start): Search back for paragraph beginning
2143 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2144 (bidi_move_to_visually_next): Only trigger paragraph-related
2145 computations when the last character is a newline or at EOB, not
2146 just any NEUTRAL_B. (Bug#9470)
2147
bb187662
EZ
2148 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2149 truncated lines if point is covered by a display string. (Bug#9524)
2150
2e621251
PE
21512011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2152
2153 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2154 (cons_to_x_long): New function.
2155 (lisp_data_to_selection_data): Use it. Correct the test for
2156 short-versus-long data; it was negated. Break out of vector
2157 loop, for efficiency, when a long datum is discovered.
2158
91a15bc6
SM
21592011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2160
2161 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2162
b41c3a35
EZ
21632011-09-16 Eli Zaretskii <eliz@gnu.org>
2164
2165 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2166 GCC PR/17406) by declaring this function with external scope.
2167
7812ba2d
PE
21682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2169
2170 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2171 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2172
cf7edc2a
AS
21732011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2174
2175 * editfns.c (Fformat): Correctly handle text properties on "%%".
2176
bd01620e
EZ
21772011-09-15 Eli Zaretskii <eliz@gnu.org>
2178
2179 * xterm.c (x_draw_composite_glyph_string_foreground):
2180 * w32term.c (x_draw_composite_glyph_string_foreground):
2181 * term.c (encode_terminal_code):
2182 * composite.c (composition_update_it, get_composition_id):
2183 * xdisp.c (get_next_display_element)
2184 (fill_composite_glyph_string): Add comments about special meaning
2185 of TAB characters in a composition.
2186
a02719a3
PE
21872011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2190 This occurs when processing a multibyte format.
2191 Problem reported by Wolfgang Jenker.
a02719a3 2192
72589a3c
JB
21932011-09-15 Johan Bockgård <bojohan@gnu.org>
2194
2195 * xdisp.c (try_cursor_movement): Only check for exact match if
2196 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2197
1c14176c
PE
21982011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 Remove unused external symbols.
2201 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2202 * xdisp.c (calc_pixel_width_or_height): Now static.
2203 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2204 * indent.c (check_display_width):
2205 * w32term.c: Fix comment to match code.
2206 * xterm.c, xterm.h (x_catching_errors): Remove.
2207
d2eea5b5
PE
22082011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 * xselect.c: Use signed conversions more consistently (Bug#9498).
2211 (selection_data_to_lisp_data): Assume incoming selection data are
2212 signed integers, not unsigned. This is to be consistent with
2213 outgoing selection data, which was modified to use signed integers
2214 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2215 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2216 expects long, not unsigned long.
2217
46888499
EZ
22182011-09-14 Eli Zaretskii <eliz@gnu.org>
2219
2220 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2221 computation of loop end. Reported by Johan Bockgård
2222 <bojohan@gnu.org>.
2223
ef8ef9fb
CY
22242011-09-13 Chong Yidong <cyd@stupidchicken.com>
2225
2226 * frame.c (Fother_visible_frames_p): Function deleted.
2227
fa819fed
EZ
22282011-09-12 Eli Zaretskii <eliz@gnu.org>
2229
2230 * indent.c (compute_motion): Process display vector front to back
2231 rather than the other way around. (Bug#2496)
2232
2ba8e008
SM
22332011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2234
2235 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2236
20f53c69
CY
22372011-09-11 Chong Yidong <cyd@stupidchicken.com>
2238
2239 * minibuf.c (Fread_from_minibuffer): Doc fix.
2240
d562d7a4
EZ
22412011-09-11 Eli Zaretskii <eliz@gnu.org>
2242
2243 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2244 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2245
1c4d7f3d
LMI
22462011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2247
2248 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2249 value for non-existent files.
2250
b885bf36
EZ
22512011-09-11 Eli Zaretskii <eliz@gnu.org>
2252
2253 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2254 set its "size" to -1. This will set the modtime_size field of
2255 the corresponding buffer to -1, which is what
2256 verify-visited-file-modtime expects for files that do not exist.
2257 (Bug#9139)
2258
6612f0bf
PE
22592011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2260
2261 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2262 here ...
2263 * lisp.h: ... from here. push_key_description is no longer
2264 defined in keyboard.c, so its declaration should not be in
2265 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2266 logically belongs with push_key_description.
2267
dfb3f755
PE
22682011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2269
2270 * buffer.h: Include <sys/types.h> instead of <time.h>.
2271 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2272 Problem reported by Herbert J. Skuhra.
2273
3134906c
LMI
22742011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2275
2276 * xml.c (parse_region): Make the parsing work for
2277 non-comment-starting XML files again (bug#9144).
2278
8d903f4e
AS
22792011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2280
2281 * image.c (gif_load): Fix calculation of bottom and right corner.
2282 (Bug#9468)
2283
80ad64f4
EZ
22842011-09-10 Eli Zaretskii <eliz@gnu.org>
2285
2286 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2287 redisplay in small windows.
2288
208a048d
EZ
22892011-09-09 Eli Zaretskii <eliz@gnu.org>
2290
2291 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2292
9b1c252e
MR
22932011-09-08 Martin Rudalics <rudalics@gmx.at>
2294
2295 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2296 Operate on live windows only.
2297
2949f33b
JB
22982011-09-08 Juanma Barranquero <lekktu@gmail.com>
2299
2300 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2301
e08dcafd
EZ
23022011-09-07 Eli Zaretskii <eliz@gnu.org>
2303
2304 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2305 only under bidi iteration.
2306
115b96bd
JD
23072011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2308
2309 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2310
c8199d0f
PE
23112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2314 Without this fix, the command to link temacs failed due to an
2315 undefined symbol __builtin_isnan. This is because
2316 /usr/include/iso/math_c99.h #defines isnan(x) to
2317 __builtin_isnan(x), but the bundled gcc, which identifies itself
2318 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2319 a __builtin_isnan.
2320 * floatfns.c (isnan): #undef, and then #define to a clone of
2321 what's in data.c.
2322 (Fisnan): Always define, since it's always available now.
2323 (syms_of_floatfns): Always define isnan at the Lisp level.
2324
e39b275c 23252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2326
2327 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2328
b2db44d9 23292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2330
f4af5137 2331 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2332 The previous code assumed that file offsets (off_t values) fit in
2333 EMACS_INT variables, which is not true on typical 32-bit hosts.
2334 The code messed up by falsely reporting buffer overflow in cases
2335 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2336 when "big" contains more than 2**29 bytes, even though this
2337 inserts just one byte and does not overflow the buffer.
2338 (Finsert_file_contents): Store file offsets as off_t
2339 values, not as EMACS_INT values. Check for overflow when
2340 converting between EMACS_INT and off_t. When checking for
2341 buffer overflow or for overlap, take the offsets into account.
2342 Don't use EMACS_INT for small values where int suffices.
2343 When checking for overlap, fix a typo: ZV was used where
2344 ZV_BYTE was intended.
2345 (Fwrite_region): Don't assume off_t fits into 'long'.
2346 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2347
ecfc0a49
MA
23482011-09-05 Michael Albinus <michael.albinus@gmx.de>
2349
2350 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2351
6511acf2 23522011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2353
0999621a 2354 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2355
2356 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2357 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2358 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2359 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2360 (modify_event_symbol): Do not assume that the length of
2361 name_alist_or_stem is safe to alloca and fits in int.
2362 (Fexecute_extended_command): Likewise for function name and binding.
2363 (Frecursion_depth): Wrap around reliably on integer overflow.
2364 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2365 since some callers pass EMACS_INT values.
2366 (Fsingle_key_description): Don't crash if symbol name contains more
2367 than MAX_ALLOCA bytes.
2368 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2369 (get_minibuffer): Arg is now EMACS_INT, not int.
2370 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2371 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2372 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2373
2be7d702
PE
2374 * dbusbind.c (signature_cat): New function.
2375 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2376 Do not overrun buffer; instead, report string overflow.
2377
9d1df220
PE
2378 * dispnew.c (add_window_display_history): Don't overrun buffer.
2379 Truncate instead; this is OK since it's just a log.
2380
33ef5c64
PE
2381 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2382 even if the time zone offset is outlandishly large.
2383 Don't mishandle offset == INT_MIN.
2384
66c6fdd5
PE
2385 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2386 when creating daemon; the previous buffer-overflow check was incorrect.
2387
d749b01b
PE
2388 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2389 which has the guts of the old verror function.
2390
b5cd1905
PE
2391 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2392 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2393
6e1a67fb
PE
2394 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2395 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2396 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2397 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2398 length of string rather than counting it via multiple sprintfs;
2399 that's simpler and more reliable.
c21721cc
PE
2400 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2401 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2402 sprintf, in case result does not fit in int.
2403
c57b67fc
PE
2404 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2405 (fontset_from_font): Print it.
2406
8a401434
PE
2407 * frame.c (tty_frame_count): Now printmax_t, not int.
2408 (make_terminal_frame, set_term_frame_name): Print it.
2409 (x_report_frame_params): In X, window IDs are unsigned long,
2410 not signed long, so print them as unsigned.
2411 (validate_x_resource_name): Check for implausibly long names,
2412 and don't assume name length fits in 'int'.
2413 (x_get_resource_string): Don't blindly alloca invocation name;
2414 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2415 not fit in int.
2416
6e1a67fb
PE
2417 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2418 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2419 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2420
0df02bf3
PE
2421 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2422 Use esprintf, not sprintf, in case result does not fit in int.
2423
48e30793
PE
2424 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2425 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2426 it as a large positive number.
2427 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2428 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2429
a66ff6d8
PE
2430 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2431 in case result does not fit in int.
2432
aca216ff
PE
2433 * print.c (float_to_string): Detect width overflow more reliably.
2434 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2435 buffer overrun. Don't assume list length fits in 'int'. Treat
2436 print length of 0 as 0, not as infinity; to be consistent with other
2437 uses of print length in this function. Don't overflow print length
2438 index. Don't assume hash table size fits in 'long', or that
2439 vectorlike size fits in 'unsigned long'.
2440
31c286f7
PE
2441 * process.c (make_process): Use printmax_t, not int, to format
2442 process-name gensyms.
2443
55e5faa1
PE
2444 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2445
80f2e268
PE
2446 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2447 to avoid potential buffer overrun.
2448
670741ab
PE
2449 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2450 if X resource line is longer than 512 bytes.
2451
b7163a50
PE
2452 * xfns.c (x_window): Make sprintf buffer a bit bigger
2453 to avoid potential buffer overrun.
2454
ae58ff1f
PE
2455 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2456
c43c8a6a
PE
2457 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2458
3f8236f4
PE
24592011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2460
53e9fe90 2461 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2462 Without these, Emacs silently mishandles large integers sometimes.
2463 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2464 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2465
6511acf2
PE
2466 * xdisp.c (try_window_id): Check Emacs fixnum range before
2467 converting to 'int'.
806add1d 2468
6511acf2 2469 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2470 Check that an Emacs fixnum is in range before assigning it to 'int'.
2471 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2472 values converted from Emacs fixnums.
2473 (Frecenter): Don't wrap around a line count if it is out of 'int'
2474 range; instead, treat it as an extreme value.
2475 (Fset_window_configuration, compare_window_configurations):
2476 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2477
6511acf2
PE
2478 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2479 that can exceed INT_MAX. Check that EMACS_INT value is in range
2480 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2481 (match_limit): Don't assume that a fixnum can fit in 'int'.
2482
6511acf2 2483 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2484 exceed INT_MAX.
2485
6511acf2 2486 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2487 (Fvertical_motion): Don't wrap around LINES values that don't fit
2488 in 'int'. Instead, treat them as extreme values. This is good
2489 enough for windows, which can't have more than INT_MAX lines anyway.
2490
fcb901a7
LMI
24912011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2492
0f2f6b6d
LMI
2493 * Require libxml/parser.h to avoid compilation warning.
2494
fcb901a7
LMI
2495 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2496
2497 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2498 since this reportedly can destroy thread storage.
2499
6e20a0d4
CY
25002011-08-30 Chong Yidong <cyd@stupidchicken.com>
2501
2502 * syntax.c (find_defun_start): Update all cache variables if
2503 exiting early (Bug#9401).
2504
148ae00e
EZ
25052011-08-30 Eli Zaretskii <eliz@gnu.org>
2506
f6cfbd8f
EZ
2507 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2508
148ae00e
EZ
2509 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2510 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2511 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2512
2513 * term.c (tty_append_glyph): New function.
2514 (produce_stretch_glyph): Static function and its prototype deleted.
2515
a66cfb1c
SM
2516 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2517 Add prototypes.
148ae00e 2518
c4a07a4c
PE
25192011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2520
2521 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2522 when checking :margin (Bug#9390).
2523 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2524 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2525 so that the name doesn't mislead. All uses changed.
2526
6bc8cd65
JB
25272011-08-28 Johan Bockgård <bojohan@gnu.org>
2528
2529 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2530 set_tty_hooks.
2531
dca4927e
EZ
25322011-08-27 Eli Zaretskii <eliz@gnu.org>
2533
2534 * xdisp.c (move_it_to): Don't bail out early when reaching
2535 position beyond to_charpos, if we are scanning backwards.
2536 (move_it_vertically_backward): When DY == 0, make sure we get to
2537 the first character in the line after the newline.
2538
f2cad773
PE
25392011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2540
2541 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2542 (ccl_driver): Do not generate an out-of-range pointer.
2543 (Fccl_execute_on_string): Remove unnecessary check for
2544 integer overflow, noted by Stefan Monnier in
2545 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2546 Remove a FIXME that didn't need fixing.
2547 Simplify the newly-introduced buffer reallocation code.
2548
0cae2cdb
JB
25492011-08-27 Juanma Barranquero <lekktu@gmail.com>
2550
2551 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2552
5fc295a4 25532011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2554
70c60eb2 2555 Integer and memory overflow issues (Bug#9196).
726e0ab1 2556
d31850da
PE
2557 * doc.c (get_doc_string): Rework so that
2558 get_doc_string_buffer_size is the actual buffer size, rather than
2559 being 1 less than the actual buffer size; this makes xpalloc more
2560 convenient.
2561
a69fbedb
PE
2562 * image.c (x_allocate_bitmap_record, cache_image):
2563 * xselect.c (Fx_register_dnd_atom):
2564 Simplify previous changes by using xpalloc.
2565
fe5c5d37
PE
2566 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2567 since either will do and ptrdiff_t is convenient with xpalloc.
2568
0065d054
PE
2569 * charset.c (charset_table_size)
2570 (struct charset_sort_data.priority): Now ptrdiff_t.
2571 (charset_compare): Don't overflow if priorities differ greatly.
2572 (Fsort_charsets): Don't assume list length fits in int.
2573 Check for size-calculation overflow when allocating sort data.
2574 (syms_of_charset): Allocate an initial charset table that is
2575 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2576
2577 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2578
2579 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2580 The actual value is always <= INT_MAX, and leaving it unsigned made
2581 overflow checking harder.
2582
2583 * dispextern.h (struct glyph_matrix.rows_allocated)
2584 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2585 with xpalloc. The values are still always <= INT_MAX.
2586
2587 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2588
2589 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2590 (SAFE_NALLOCA): New macro.
2591
2592 * region-cache.c (struct boundary.pos, find_cache_boundary)
2593 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2594 (set_cache_region, invalidate_region_cache)
2595 (revalidate_region_cache, know_region_cache, region_cache_forward)
2596 (region_cache_backward, pp_cache):
2597 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2598 so that ptrdiff_t * can be passed to xpalloc.
2599 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2600 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2601 (pp_cache): Don't assume cache_len fits in int.
2602 * region-cache.h: Adjust extern decls to match.
2603
2604 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2605 EMACS_INT, since either will do, for xpalloc.
2606
2607 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2608 (xnmalloc, xnrealloc, xpalloc): New functions.
2609
726e0ab1
PE
2610 * bidi.c (bidi_shelve_header_size): New constant.
2611 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2612 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2613
51f30bc5 2614 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2615 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2616 (overlay_strings):
2617 Don't update size of array until after memory allocation succeeds,
2618 because xmalloc/xrealloc may not return.
0065d054
PE
2619 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2620 now that we have proper integer overflow checking.
2621 (record_overlay_string, overlay_strings): Catch overflows when
2622 calculating size of overlay_str_buf.
726e0ab1 2623
0065d054
PE
2624 * callproc.c (Fcall_process): Check for size overflow when
2625 calculating size of args2.
2626 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2627 Normally we prefer signed values, but sticking with ptrdiff_t would
2628 require adding more-complicated checks.
726e0ab1
PE
2629
2630 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2631 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2632 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2633 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2634
2635 * character.c (Fstring): Check for size-calculation overflow.
2636
2637 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2638 unnecessary integer overflow. Check for size overflow.
2639 (encode_coding_object): Don't update size until xmalloc succeeds.
2640
2641 * composite.c (get_composition_id): Check for overflow in glyph
2642 length calculations.
2643
2644 Integer and memory overflow fixes for display code.
2645 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2646 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2647 (scrolling_window): Check for overflow in size calculations.
2648 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2649 Don't assume glyph table len fits in int.
2650 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2651 (row_table_size): Now ptrdiff_t, not int.
2652 (scrolling_window): Avoid overflow in size calculations.
2653 Don't update size until allocation succeeds.
2654 * fns.c (concat): Check for overflow in size calculations.
2655 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2656 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2657 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2658
2659 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2660 (get_doc_string): Check for size calculation overflow.
2661 Don't update size until allocation succeeds.
2662 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2663 EMACS_INT, where ptrdiff_t will do.
2664 (Fsubstitute_command_keys): Check for string overflow.
2665
2666 * editfns.c (set_time_zone_rule): Don't assume environment length
2667 fits in int.
2668 (message_length): Now ptrdiff_t, not int.
2669 (Fmessage_box): Don't update size until allocation succeeds.
2670 Don't assume message length fits in int.
2671 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2672
0065d054
PE
2673 * emacs.c (main): Do not reallocate argv, since there is a null at
2674 the end that can be overwritten, and this way there's no need to
2675 worry about size-calculation overflow.
2676 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2677
2678 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2679 alloc succeeds.
2680 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2681
2682 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2683 (x_set_scroll_bar_width, x_figure_window_size):
2684 Check for integer overflow.
2685 (x_set_alpha): Do not assume XINT fits in int.
2686
2687 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2688 This is for the members text_lines, text_cols, total_lines, total_cols,
2689 where the system imposes an 'int' limit.
2690
2691 * fringe.c (Fdefine_fringe_bitmap):
2692 Don't update size until alloc works.
2693
2694 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2695 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2696
2697 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2698 Check for size-calculation overflow.
2699 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2700 do, as we prefer signed integers.
2701 (id_to_widget.max_size, id_to_widget.used)
2702 (xg_store_widget_in_map, xg_remove_widget_from_map)
2703 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2704 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2705 Use and return ptrdiff_t, not int.
2706 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2707 * gtkutil.h: Change prototypes to match the above.
2708
2709 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2710 are duplicate now that they've been promoted to lisp.h.
2711 (x_allocate_bitmap_record, x_alloc_image_color)
2712 (make_image_cache, cache_image, xpm_load):
2713 Don't update size until alloc is done.
2714 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2715 (x_detect_edges):
3256efce 2716 Check for size calculation overflow.
726e0ab1
PE
2717 (ct_colors_allocated_max): New constant.
2718 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2719 overflow.
3256efce 2720
726e0ab1
PE
2721 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2722 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2723 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2724 Use ptrdiff_t, not int, to count maps.
2725 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2726 calculations. Don't update size until allocation succeeds.
2727 Redo calculations to avoid overflow.
726e0ab1
PE
2728 * keyboard.h: Change prototypes to match the above.
2729
2730 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2731 to count maps.
2732 (current_minor_maps): Check for size calculation overflow.
2733 * keymap.h: Change prototypes to match the above.
2734
2735 * lread.c (read1, init_obarray): Don't update size until alloc done.
2736
2737 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2738 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2739
726e0ab1
PE
2740 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2741 Now ptrdiff_t, not int.
2742 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2743 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2744
2745 * process.c (Fnetwork_interface_list): Check for overflow
2746 in size calculation.
2747
2748 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2749
2750 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2751 overflow. Don't bother calling xmalloc when xrealloc will do.
2752
2753 * search.c (Freplace_match): Check for size calculation overflow.
2754 (Fset_match_data): Don't assume list lengths fit in 'int'.
2755
2756 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2757 for command line length. Do not attempt to address one before the
2758 beginning of an array, as that's not portable.
2759
2760 * term.c (max_frame_lines): Remove; unused.
2761 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2762 not int.
2763 (encode_terminal_code, calculate_costs): Check for size
2764 calculation overflow.
2765 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2766 table lengths and related sizes. Don't update size until alloc
2767 done. Redo calculations to avoid overflow.
2768 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2769
2770 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2771 subtracting pointers.
2772 (gobble_line): Check for overflow more carefully. Don't update size
2773 until alloc done.
2774
2775 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2776 Don't update size until alloc done.
2777 Redo size calculations to avoid overflow.
2778 Check for size calculation overflow.
0065d054 2779 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2780
2781 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2782 Use ptrdiff_t, not int, for sizes.
2783 (store_mode_line_noprop_char): Don't update size until alloc done.
2784
0065d054
PE
2785 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2786 Use ptrdiff_t, not int, for sizes.
2787 (Finternal_make_lisp_face, cache_face):
2788 Check for size calculation overflow.
2789 (cache_face): Treat size calculation overflows as if they were
2790 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2791
2792 * xfns.c (x_encode_text, x_set_name_internal)
2793 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2794 sizes, since they can exceed INT_MAX in size. Check for size
2795 calculation overflow.
2796
0065d054
PE
2797 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2798 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2799 Don't update size until alloc done.
2800
0065d054 2801 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2802 as sprintf is limited to int lengths.
1d526e2f 2803
252c5ee1
PE
2804 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2805 (X_LONG_MIN): New macros.
864d7ce7
PE
2806 Use them to make the following changes clearer.
2807 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2808 This change doesn't affect the value now, but it may help remind
2809 future maintainers not to raise the value too much later.
2810 (SELECTION_QUANTUM): Remove, replacing with ...
2811 (selection_quantum): ... new function, which avoids overflow.
2812 All uses changed.
2813 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2814 assumption that selection length fits in 'int'.
2815 (x_reply_selection_request, x_handle_selection_request)
2816 (x_get_window_property, receive_incremental_selection)
2817 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2818 (lisp_data_to_selection_data, clean_local_selection_data):
2819 Use ptrdiff_t, not int, to record length of selection.
2820 (x_reply_selection_request, x_get_window_property)
2821 (receive_incremental_selection, x_property_data_to_lisp):
2822 Redo calculations to avoid overflow.
2823 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2824 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2825 something.
2826 (x_get_window_property, receive_incremental_selection)
2827 (lisp_data_to_selection_data, x_property_data_to_lisp):
2828 Check for size-calculation overflow.
2829 (x_get_window_property, receive_incremental_selection)
2830 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2831 Don't store size until memory allocation succeeds.
2832 (x_get_window_property): Plug memory leak on memory exhaustion.
2833 Don't double-block input; malloc is safe here. Don't assume 2**34
2834 - 4 fits in unsigned long. Add an xassert to check
2835 XGetWindowProperty overflow. Be more careful about overflow
2836 calculations, and distinguish size from memory overflow better.
2837 (receive_incremental_selection): When tracing, don't assume
2838 unsigned int is less than INT_MAX.
2839 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2840 harmful) conversions of unsigned short to int.
2841 (lisp_data_to_selection_data): Don't assume that integers
2842 in the range -65535 through -1 fit in an X unsigned short.
2843 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2844 result parameters unless successful. Rely on cons_to_unsigned
2845 to report problems with elements; the old code wasn't right anyway.
2846 (x_check_property_data): Check for int overflow; we cannot use
2847 a wider type due to X limits.
2848 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2849
726e0ab1 2850 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2851
0065d054
PE
2852 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2853 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2854 (x_color_cells): Don't store size until memory allocation succeeds.
2855 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2856 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2857 (x_term_init): Don't assume length fits in int (sprintf is limited
2858 to int size).
bc18e09d 2859
ebfa62c0
PE
2860 Use ptrdiff_t for composition IDs.
2861 * character.c (lisp_string_width):
2862 * composite.c (composition_table_size, n_compositions)
2863 (get_composition_id, composition_gstring_from_id):
2864 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2865 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2866 * window.c (Frecenter):
2867 Use ptrdiff_t, not int, for composition IDs.
2868 * composite.c (get_composition_id): Check for integer overflow.
2869 * composite.h: Adjust prototypes to match the above changes.
2870
d3411f89
PE
2871 Use ptrdiff_t for hash table indexes.
2872 * category.c (hash_get_category_set):
2873 * ccl.c (ccl_driver):
2874 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2875 * coding.c (coding_system_charset_list, detect_coding_system):
2876 * coding.h (struct coding_system.id):
2877 * composite.c (get_composition_id, gstring_lookup_cache):
2878 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2879 * image.c (xpm_get_color_table_h):
2880 * lisp.h (hash_lookup, hash_put):
2881 * minibuf.c (Ftest_completion):
2882 Use ptrdiff_t for hash table indexes, not int (which is too
2883 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2884 32-bit --with-wide-int hosts).
2885
e097a6fa
PE
2886 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2887 Add a FIXME comment about memory leaks.
2888 (syms_of_charset): Don't assume xmalloc returns.
2889
5637687f
PE
2890 Don't assume that stated character widths fit in int.
2891 * character.c (Fchar_width, c_string_width, lisp_string_width):
2892 * character.h (CHAR_WIDTH):
2893 * indent.c (MULTIBYTE_BYTES_WIDTH):
2894 Use sanitize_char_width to avoid undefined and/or bad behavior
2895 with outlandish widths.
a66cfb1c 2896 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2897 now that we have two such functions. All uses changed.
2898 (sanitize_char_width): New inline function.
2899
a2271ba2
PE
2900 Don't assume that tab-width fits in int.
2901 * character.h (sanitize_width): New inline function.
2902 (SANE_TAB_WIDTH): New macro.
2903 (ASCII_CHAR_WIDTH): Use it.
2904 * indent.c (sane_tab_width): Remove. All uses replaced by
2905 SANE_TAB_WIDTH (current_buffer).
2906 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2907
18c52557
PE
2908 * fileio.c: Integer overflow issues with file modes.
2909 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2910
caeeedc1
PE
2911 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2912 Remove unreachable code.
2913 (read_hex, load_charset_map_from_file): Check for integer overflow.
2914
6df6ae42 2915 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2916 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2917 (x_send_scroll_bar_event): Likewise. Check that the size does not
2918 exceed limits imposed by XClientMessageEvent, as well as the usual
2919 ptrdiff_t and size_t limits.
2920
b13995db
PE
2921 * keyboard.c: Overflow, signedness and related fixes.
2922 (make_lispy_movement): Use same integer type in forward decl
2923 that is used in the definition.
2924 (read_key_sequence, keyremap_step):
2925 Change bufsize argument back to int, undoing my 2011-03-30 change.
2926 We prefer signed types, and int is wide enough here.
2927 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2928 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2929 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2930 length, not size_t. Use ptrdiff_t for index, not int.
2931 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2932 possibility of integer overflow.
2933
13464394
PE
2934 Overflow, signedness and related fixes for images.
2935
2936 * dispextern.h (struct it.stack[0].u.image.image_id)
2937 (struct_it.image_id, struct image.id, struct image_cache.size)
2938 (struct image_cache.used, struct image_cache.ref_count):
2939 * gtkutil.c (update_frame_tool_bar):
2940 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2941 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2942 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2943 * nsmenu.m (update_frame_tool_bar):
2944 * xdisp.c (calc_pixel_width_or_height):
2945 * xfns.c (image_cache_refcount):
2946 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2947 on typical 64-bit hosts.
2948
2949 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2950 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2951 Omit unnecessary casts to int.
2952 (parse_image_spec): Check that integers fall into 'int' range
2953 when the callers expect that.
2954 (image_ascent): Redo ascent calculation to avoid int overflow.
2955 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2956 (lookup_image): Remove unnecessary tests.
2957 (xbm_image_p): Locals are now of int, not EMACS_INT,
2958 since parse_image_check makes sure they fit into int.
2959 (png_load, gif_load, svg_load_image):
2960 Prefer int to unsigned where either will do.
2961 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2962 old tiff_error_handler and tiff_warning_handler.
2963 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2964 stack buffer overflows. It uses only the features of vsnprintf
2965 that are common to both POSIX and native Microsoft.
2966 (tiff_error_handler, tiff_warning_handler): Use it.
2967 (tiff_load, gif_load, imagemagick_load_image):
2968 Don't assume :index value fits in 'int'.
2969 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2970 (imagemagick_load_image): Check that crop parameters fit into
2971 the integer types that MagickCropImage accepts. Don't assume
2972 Vimagemagick_render_type has a nonnegative value. Don't assume
2973 size_t fits in 'long'.
2974 (gs_load): Use printmax_t to print the widest integers possible.
2975 Check for integer overflow when computing image height and width.
2976
c11821d4
EZ
29772011-08-26 Eli Zaretskii <eliz@gnu.org>
2978
2979 * xdisp.c (redisplay_window): Don't force window start if point
2980 will be invisible in the resulting window. (Bug#9324)
2981
0c95fcf7
EZ
29822011-08-25 Eli Zaretskii <eliz@gnu.org>
2983
2984 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2985 the display spec is of the form `(space ...)'.
2986 (handle_display_spec): Return the value returned by
2987 handle_single_display_spec, not just 1 or zero.
2988 (handle_single_display_spec): If the display spec is of the form
2989 `(space ...)', and specifies display in the text area, return 2
2990 rather than 1.
fee65a97 2991 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2992 accurately, and prefer exact match for point under bidi.
2993 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2994
2995 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2996 into disp_prop; all users changed.
2997
2998 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2999 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3000 for the text covered by the display property.
3001
e4ed06f1
CY
30022011-08-25 Chong Yidong <cyd@stupidchicken.com>
3003
3004 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3005 Change return value to nil.
3006 (Frecord_buffer): Delete unused function.
3007
f67cdd7f
EZ
30082011-08-24 Eli Zaretskii <eliz@gnu.org>
3009
5980d4c6
EZ
3010 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3011 buffers, return left-to-right.
8610fe8b
EZ
3012 (set_cursor_from_row): Consider candidate row a win if its glyph
3013 represents a newline and point is on that newline. Fixes cursor
3014 positioning on the newline at EOL of R2L text within L2R
3015 paragraph, and vice versa.
3016 (try_cursor_movement): Check continued rows, in addition to
3017 continuation rows. Fixes unwarranted scroll when point enters a
3018 continued line of R2L text within an L2R paragraph, or vice versa.
3019 (cursor_row_p): Consider the case of point being equal to
3020 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3021 from the end of a short line to the beginning of a continued line
3022 of R2L text within L2R paragraph.
3023 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3024 composed characters.
5980d4c6 3025
f67cdd7f
EZ
3026 * bidi.c (bidi_check_type): Use xassert.
3027 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3028 members.
3029
bca633fb
EZ
30302011-08-23 Eli Zaretskii <eliz@gnu.org>
3031
3032 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3033 a character.
3034
4a5885a7
CY
30352011-08-23 Chong Yidong <cyd@stupidchicken.com>
3036
3037 * nsfont.m (ns_otf_to_script): Fix typo.
3038
0902a04e
KH
30392011-08-22 Kenichi Handa <handa@m17n.org>
3040
3041 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3042 extra slot even if the purpose is char-code-property-table.
3043
1a2e6670
EZ
30442011-08-23 Eli Zaretskii <eliz@gnu.org>
3045
8ddde651
EZ
3046 * xdisp.c (redisplay_window): When computing centering_position,
3047 account for the height of the header line. (Bug#8874)
3048
425cc014
EZ
3049 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3050 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3051 candidate is selected by the mouse, and that candidate has a
3052 composed character under the mouse.
3053
1a2e6670
EZ
3054 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3055 coordinates reported by pos-visible-in-window-p for a composed
3056 character in column zero.
3057
8b76d6f8
SM
30582011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3059
3060 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3061
dac347dd
EZ
30622011-08-22 Eli Zaretskii <eliz@gnu.org>
3063
3064 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3065 consider it a hit if to_charpos is anywhere in the range of the
3066 composed buffer positions.
3067
e013fb34
CY
30682011-08-22 Chong Yidong <cyd@stupidchicken.com>
3069
3070 * image.c (gif_load): Don't assume that each subimage has the same
3071 dimensions as the base image. Handle disposal method that is
3072 "undefined" by the gif spec (Bug#9335).
3073
bd1ba3e8
CY
30742011-08-20 Chong Yidong <cyd@stupidchicken.com>
3075
3076 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3077 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3078
54a1215b
EZ
30792011-08-19 Eli Zaretskii <eliz@gnu.org>
3080
823564e5
EZ
3081 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3082 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3083 from an Org mode buffer to a Speedbar frame.
3084
54a1215b
EZ
3085 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3086 a composition, take its buffer position from IT->cmp_it.charpos.
3087 Fixes cursor positioning at the beginning of a line that begins
3088 with a composed character.
3089
9778ebcc
EZ
30902011-08-18 Eli Zaretskii <eliz@gnu.org>
3091
0be6ee06
EZ
3092 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3093 character bidirectional type, use STRONG_L instead. Fixes crashes
3094 in a buffer produced by `describe-categories'.
3095
9778ebcc
EZ
3096 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3097 members before the level stack, so they would be saved and
3098 restored when copying iterator state. Fixes incorrect reordering
3099 around TABs covered by display properties.
3100
156bffbe
AS
31012011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3102
6b02f655 3103 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3104
72ad093b
CY
31052011-08-17 Chong Yidong <cyd@stupidchicken.com>
3106
3107 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3108 (internal_condition_case_2, internal_condition_case_n):
3109 Remove unnecessary aborts (Bug#9081).
72ad093b 3110
35774242
EZ
31112011-08-17 Eli Zaretskii <eliz@gnu.org>
3112
3113 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3114 has no `load' handler, try opening the file locally. (Bug#9311)
3115
db76dd85
KB
31162011-08-16 Ken Brown <kbrown@cornell.edu>
3117
3118 * gmalloc.c: Expand comment.
3119
b215eee5
EZ
31202011-08-16 Eli Zaretskii <eliz@gnu.org>
3121
3122 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3123 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3124
a4579d33
KB
31252011-08-16 Ken Brown <kbrown@cornell.edu>
3126
3127 Fix memory allocation problems in Cygwin build (Bug#9273).
3128
3129 * unexcw.c ( __malloc_initialized): Declare external variable.
3130 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3131
8b76d6f8
SM
3132 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3133 New variables.
a4579d33
KB
3134 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3135 dumped emacs.
3136 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3137 in the static heap.
3138 [CYGWIN] (special_realloc): New function.
3139 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3140 requests to realloc storage in the static heap.
3141
3ebec551
PE
31422011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3143
3144 * bidi.c (bidi_initialize): Remove unused local.
3145
9fd8be00
EZ
31462011-08-15 Eli Zaretskii <eliz@gnu.org>
3147
6b02f655
SM
3148 * bidimirror.h:
3149 * biditype.h: Remove file.
3150 * makefile.w32-in ($(BLD)/bidi.$(O)):
3151 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3152
3153 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3154
3155 * chartab.c: Improve commentary for the uniprop_table API.
3156
32413314
EZ
3157 * bidi.c (bidi_paragraph_init): Support zero value of
3158 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3159 (bidi_initialize): Use uniprop_table instead of including
3160 biditype.h and bidimirror.h.
32413314 3161
9fd8be00
EZ
3162 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3163 coordinates of the iterator when restoring from ppos_it.
3164 (Bug#9296)
3165
5cf2b69b
KH
31662011-08-14 Kenichi Handa <handa@m17n.org>
3167
3168 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3169 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3170
daf17d00
EZ
31712011-08-14 Eli Zaretskii <eliz@gnu.org>
3172
3173 * xdisp.c (move_it_in_display_line_to): Don't invoke
3174 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3175 ppos_it. Fixes vertical cursor motion when line beginning is
3176 covered by an image. (Bug#9296)
3177
08e3161a
JD
31782011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3179
3180 * nsterm.h (ns_run_ascript): Declare.
3181 (NSAPP_DATA2_RUNASSCRIPT): Define.
3182
3183 * nsfns.m (as_script, as_result, as_status): New static variables.
3184 (ns_run_ascript): New function.
5e617bc2 3185 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3186 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3187 the event loop. Get status from as_status (Bug#7276).
3188
3189 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3190 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3191 the event loop (Bug#7276).
3192
a3720aa2
AS
31932011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3194
3195 * gnutls.c (QCgnutls_bootprop_priority)
3196 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3197 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3198 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3199 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3200 (QCgnutls_bootprop_verify_hostname_error)
3201 (QCgnutls_bootprop_callbacks_verify): Rename from
3202 Qgnutls_bootprop_..., all uses changed.
3203
3204 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3205 uses changed.
3206
0a0d27fb
PE
32072011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3208
19d5c50c
PE
3209 * xfaces.c (Qframe_set_background_mode): Now static.
3210 * dispextern.h (Qframe_set_background_mode): Remove decl.
3211
0a0d27fb
PE
3212 * process.c (Fnetwork_interface_info): Declare local only if needed.
3213
377538cb
JD
32142011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3215
3216 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3217 (Fnetwork_interface_list): Allocate in increments of bytes instead
3218 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3219 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3220 sockaddr.
3221 (struct ifflag_def): notrailers is smart on OSX.
3222 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3223 Get hardware address with getifaddrs if available.
3224
08fff70c
EZ
32252011-08-12 Eli Zaretskii <eliz@gnu.org>
3226
3227 * xdisp.c (iterate_out_of_display_property): xassert that
3228 IT->position is set to within IT->object's boundaries. Break from
3229 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3230 when IT->position is set up wrongly due to some bug.
3231 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3232 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3233 entry. Force push_it to save on the stack the current
3234 buffer/string position, to be restored by pop_it. Fix flags in
3235 the iterator structure wrt the object coming from a display
3236 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3237 properties. (Bug#9284)
3238
7be1c708 32392011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3240
7be1c708
CY
3241 * fontset.c (fontset_get_font_group): Add proper type checks.
3242 (Bug#9172)
aac0c6e3 3243
7be1c708 32442011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3245
7be1c708
CY
3246 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3247 and LC_VERSION_MIN_MACOSX.
3248 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3249 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3250
97bb72a6
EZ
32512011-08-08 Eli Zaretskii <eliz@gnu.org>
3252
3253 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3254 no-display-properties-and-no-overlays under bidi display.
3255 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3256 properties and overlays.
97bb72a6 3257
d5617611
CY
32582011-08-08 Chong Yidong <cyd@stupidchicken.com>
3259
37e11a63
CY
3260 * editfns.c (Fset_time_zone_rule): Document relationship with the
3261 setenv function.
3262
d5617611
CY
3263 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3264 the font entity extracted from the cache (Bug#8109).
3265
58872834
CY
32662011-08-07 Chong Yidong <cyd@stupidchicken.com>
3267
3268 * composite.c (autocmp_chars): Don't reset point. That is done by
3269 restore_point_unwind (Bug#5984).
3270
75bfc667
JL
32712011-08-07 Juri Linkov <juri@jurta.org>
3272
3273 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3274 to show the arg `TIME' instead of `TIMEVAL'.
3275
d1410150
EZ
32762011-08-06 Eli Zaretskii <eliz@gnu.org>
3277
3278 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3279 display property strides EOL and includes a newline, as in
3280 longlines-mode. (Bug#9254)
75b771e4
EZ
3281 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3282 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3283
3284 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3285 is non-zero, even if the data buffer is NULL. Fixes a crash in
3286 vertical-motion with longlines-mode. (Bug#9254)
3287
35928349
EZ
32882011-08-05 Eli Zaretskii <eliz@gnu.org>
3289
ec7cc85b
EZ
3290 * bidi.c <bidi_cache_total_alloc>: Now static.
3291 (bidi_initialize): Initialize bidi_cache_total_alloc.
3292
8b76d6f8 3293 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3294 cache. (Bug#9221)
3295
3296 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3297 amount allocated this far in `bidi_cache_total_alloc'.
3298 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3299 non-zero, only free the data buffer without restoring the cache
3300 contents. All callers changed.
3301
3302 * dispextern.h (bidi_unshelve_cache): Update prototype.
3303
3304 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3305 (move_it_in_display_line, move_it_to)
3306 (move_it_vertically_backward, move_it_by_lines): Replace the call
3307 to xfree to an equivalent call to bidi_unshelve_cache.
3308 (move_it_in_display_line_to): Fix logic of returning
412b6358 3309 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3310
e2e2423b
EZ
33112011-08-05 Eli Zaretskii <eliz@gnu.org>
3312
3313 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3314 came from a string character with a `cursor' property. (Bug#9229)
3315
ae9e757a
JD
33162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3317
3318 * Makefile.in (LIB_PTHREAD): New variable.
3319 (LIBES): Add LIB_PTHREAD (Bug#9216).
3320
3321 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3322 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3323
213bd7f2
AS
33242011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3325
6b02f655 3326 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3327
99aaf75f
JD
33282011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3329
3330 * xterm.c (x_find_topmost_parent): New function.
3331 (x_set_frame_alpha): Find topmost parent window with
3332 x_find_topmost_parent and set the property there also (bug#9181).
3333 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3334
c74e9d86
PE
33352011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3336
3337 * callproc.c (Fcall_process): Avoid vfork clobbering
3338 the local vars buffer, coding_systems, current_dir.
3339
640c8776
SM
33402011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3341
3342 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3343
f26d0e4c
PE
33442011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3345
8a10d76c
PE
3346 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3347 so that it is not optimized away.
3348
f26d0e4c
PE
3349 * xdisp.c (compute_display_string_pos): Remove unused local.
3350
55439c61
EZ
33512011-08-02 Eli Zaretskii <eliz@gnu.org>
3352
3353 Fix slow cursor motion and scrolling in large buffers with
3354 selective display, like Org Mode buffers. (Bug#9218)
3355
3356 * dispextern.h (struct bidi_it): New member disp_prop_p.
3357
3358 * xdisp.c: Remove one-slot cache of display string positions.
3359 (compute_display_string_pos): Accept an additional argument
5e617bc2 3360 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3361 for a display string or property. If found, set DISP_PROP_P
3362 non-zero.
3363
3364 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3365 DISP_PROP_P, and pass it to compute_display_string_pos.
3366 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3367 non-zero. All callers of bidi_fetch_char changed.
3368
fb33fa43
SM
33692011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3370
3371 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3372
b099e063
DM
33732010-12-03 Don March <don@ohspite.net>
3374
3375 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3376 last character M-[char] is translated to ESC [char] (bug#7541).
3377
5cc7f7af
KH
33782011-08-02 Kenichi Handa <handa@m17n.org>
3379
d0fffa3f 3380 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3381
3382 * chartab.c (uniprop_table): Make it non-static.
3383
525d5e6e
EZ
33842011-08-01 Eli Zaretskii <eliz@gnu.org>
3385
3386 * xdisp.c (forward_to_next_line_start): Accept additional argument
3387 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3388 on the newline.
3389 (reseat_at_next_visible_line_start): Use the bidi iterator state
3390 returned by forward_to_next_line_start to restore the state of
3391 it->bidi_it after backing up to previous newline. (Bug#9212)
3392
31011111
AS
33932011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3394
3395 * regex.c (re_comp): Protoize.
3396 (re_exec): Fix return type.
3397 (regexec): Fix type of `ret'. (Bug#9203)
3398
476371c4
PE
33992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3400
e5d76069
PE
3401 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3402 This is needed if max-image-size is a floating-point number.
3403
9a79b20c
AS
34042011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3405
3406 * print.c (print_object): Print empty symbol as ##.
3407
3408 * lread.c (read1): Read ## as empty symbol.
3409
d8c2fa78
AA
34102011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3411
3412 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3413 setting frame foreground color (Bug#9175).
3414 (x_set_background_color): Likewise.
3415
ffe57a7a
AA
3416 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3417 contents (Bug#9176).
3418 (EmacsTooltip -init): Remove bezels and add shadows to
3419 tooltip windows.
3420
bf3492a5
AA
3421 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3422 or scroll bar (Bug#8470).
3423
d55e9c53
AA
3424 * nsfont.m (nsfont_open): Remove assignment to voffset and
3425 unnecessary vars hshink, expand, hd, full_height, min_height.
3426 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3427
3428 * nsterm.h (nsfont_info): Remove voffset field.
3429
d8c2fa78 34302011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3431
3432 Implement strike-through and overline on NextStep (Bug#8863).
3433
3434 * nsfont.m (nsfont_open): Use underline position provided by font,
3435 instead of hard-coded value of 2.
3436 (nsfont_draw): Call ns_draw_text_decoration instead.
3437
3438 * nsterm.h: Add declaration for ns_draw_text_decoration.
3439
3440 * nsterm.m (ns_draw_text_decoration): New function for drawing
3441 underline, overline, and strike-through.
3442 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3443 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3444 accommodate underlining, etc.
4843aac3 3445
4cc60b9b
EZ
34462011-07-28 Eli Zaretskii <eliz@gnu.org>
3447
bc7ece87
EZ
3448 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3449 default.
4cc60b9b 3450
476371c4
PE
34512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3452
66606eea
PE
3453 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3454 Without this fix, if a signal arrives just after memory fills up,
3455 'malloc' might be invoked reentrantly.
3456
476371c4
PE
3457 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3458 In other words, assume that every image size is allowed, on non-X
3459 hosts. This assumption is probably wrong, but it lets Emacs compile.
3460
f3fcc40d
AS
34612011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3462
3463 * regex.c (re_iswctype): Convert return values to boolean.
3464
350c992f
EZ
34652011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3466
3467 * xdisp.c (compute_display_string_pos): Don't use cached display
3468 string position if the buffer had its restriction changed.
3469 (Bug#9184)
3470
5266b4bb
PE
34712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3472
3473 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3474
2573a837 34752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3476
41f55ccd 3477 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3478
39e378da
PE
3479 * bidi.c: Integer size and overflow fixes.
3480 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3481 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3482 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3483 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3484 (bidi_find_other_level_edge):
3485 Use ptrdiff_t instead of EMACS_INT where either will do.
3486 This works better on 32-bit hosts configured --with-wide-int.
3487 (bidi_cache_ensure_space): Check for size-calculation overflow.
3488 Use % rather than repeated addition, for better worst-case speed.
3489 Don't set bidi_cache_size until after xrealloc returns, because it
3490 might not return.
3491 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3492 (bidi_cache_ensure_space): Also check that the bidi cache size
3493 does not exceed that of the largest Lisp string or buffer. See Eli
3494 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3495
5e927815
PE
3496 * alloc.c (__malloc_size_t): Remove.
3497 All uses replaced by size_t. See Andreas Schwab's note
3498 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3499
ca4aa935
PE
3500 * image.c: Improve checking for integer overflow.
3501 (check_image_size): Assume that f is nonnull, since
3502 it is always nonnull in practice. This is one less thing to
3503 worry about when checking for integer overflow later.
3504 (x_check_image_size): New function, which checks for integer
3505 overflow issues inside X.
3506 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3507 This removes the need for a memory_full check.
3508 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3509 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3510 (xbm_read_bitmap_data): Change locals back to 'int', since
3511 their values must fit in 'int'.
3512 (xpm_load_image, png_load, tiff_load):
3513 Invoke x_create_x_image_and_pixmap earlier,
3514 to avoid much needless work if the image is too large.
3515 (tiff_load): Treat overly large images as if
3516 x_create_x_image_and_pixmap failed, not as malloc failures.
3517 (gs_load): Use x_check_image_size.
3518
5f8f9cc2
PE
3519 * gtkutil.c: Omit integer casts.
3520 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3521 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3522
5adf60bc
PE
3523 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3524
c8907a93
PE
3525 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3526 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3527 would wrongly return t on a 64-bit host.
3528
e3c25c68
PE
3529 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3530 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3531 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3532 and therefore cause GCC to emit a bogus diagnostic in some cases.
3533
3f791afe
PE
3534 * image.c: Integer signedness and overflow and related fixes.
3535 This is not an exhaustive set of fixes, but it's time to
3536 record what I've got.
3537 (lookup_pixel_color, check_image_size): Remove redundant decls.
3538 (check_image_size): Don't assume that arbitrary EMACS_INT values
3539 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3540 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3541 (tiff_load, imagemagick_load_image):
3542 Check for overflow in size calculations.
3543 (x_create_x_image_and_pixmap): Remove unnecessary test for
3544 xmalloc returning NULL; that can't happen.
3545 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3546 (xpm_color_bucket): Use better integer hashing function.
3547 (xpm_cache_color): Don't possibly over-allocate memory.
3548 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3549 (gif_memory_source):
3550 Use ptrdiff_t, not int or size_t, to record sizes.
3551 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3552 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3553 either works, as we prefer signed integers.
3554 (tiff_read_from_memory, tiff_write_from_memory):
3555 Return tsize_t, not size_t, since that's what the TIFF API wants.
3556 (tiff_read_from_memory): Don't fail simply because the read would
3557 go past EOF; instead, return a short read.
3558 (tiff_load): Omit no-longer-needed casts.
3559 (Fimagemagick_types): Don't assume size fits into 'int'.
3560
3cc5a532
PE
3561 Improve hashing quality when configured --with-wide-int.
3562 * fns.c (hash_string): New function, taken from sxhash_string.
3563 Do not discard information about ASCII character case; this
3564 discarding is no longer needed.
3565 (sxhash-string): Use it. Change sig to match it. Caller changed.
3566 * lisp.h: Declare it.
3567 * lread.c (hash_string): Remove, since we now use fns.c's version.
3568 The fns.c version returns a wider integer if --with-wide-int is
3569 specified, so this should help the quality of the hashing a bit.
3570
b312a492
PE
3571 * emacs.c: Integer overflow minor fix.
3572 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3573 Define only if GNU_LINUX.
3574 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3575
dfd153ae
PE
3576 * dispnew.c: Integer signedness and overflow fixes.
3577 Remove unnecessary forward decls, that were a maintenance hassle.
3578 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3579 All uses changed.
3580 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3581 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3582 (prepare_desired_row, line_draw_cost):
3583 Use int, not unsigned, where either works.
3584 (save_current_matrix, restore_current_matrix):
3585 Use ptrdiff_t, not size_t, where either works.
3586 (init_display): Check for overflow more accurately, and without
3587 relying on undefined behavior.
3588
a81d11a3
PE
3589 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3590 Remove, replacing with the new symbols in lisp.h. All uses changed.
3591 * fileio.c (make_temp_name):
3592 * filelock.c (lock_file_1, lock_file):
3593 * xdisp.c (message_dolog):
3594 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3595 Use pMd etc. instead.
3596 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3597 replacing the pWIDE etc. symbols removed from editfns.c.
3598
3300e6fd
PE
3599 * keyboard.h (num_input_events): Now uintmax_t.
3600 This is (very slightly) less likely to mess up due to wraparound.
3601 All uses changed.
3602
fd05c7e9
PE
3603 * buffer.c: Integer signedness fixes.
3604 (alloc_buffer_text, enlarge_buffer_text):
3605 Use ptrdiff_t rather than size_t when either will do, as we prefer
3606 signed integers.
3607
903fe15d
PE
3608 * alloc.c: Integer signedness and overflow fixes.
3609 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3610 (__malloc_size_t): Default to size_t, not to int.
3611 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3612 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3613 Prefer ptrdiff_t to size_t when either would do, as we prefer
3614 signed integers.
3615 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3616 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3617 Now const. Initialize with values that are in range even if char
3618 is signed.
3619 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3620 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3621 These functions do the right thing with sizes > 2**32.
3622 (check_depth): Now ptrdiff_t, not int.
3623 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3624 Adjust to new way of storing sizes. Check for size overflow bugs
3625 in rest of code.
3626 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3627 slightly wrong anyway, as it missed one instance of
3628 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3629 (refill_memory_reserve): Omit needless cast to size_t.
3630 (mark_object_loop_halt): Mark as externally visible.
3631
ac82cc6a
PE
3632 * xselect.c: Integer signedness and overflow fixes.
3633 (Fx_register_dnd_atom, x_handle_dnd_message):
3634 Use ptrdiff_t, not size_t, since we prefer signed.
3635 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3636 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3637 x_dnd_atoms_size and x_dnd_atoms_length.
3638
c2d1e36d
PE
3639 * doprnt.c: Prefer signed to unsigned when either works.
3640 * eval.c (verror):
3641 * doprnt.c (doprnt):
3642 * lisp.h (doprnt):
3643 * xdisp.c (vmessage):
3644 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3645 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3646 prefer signed arithmetic to avoid comparison confusion.
3647 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3648 but is a bit tricky.
3649
0e926e56
PE
3650 Assume freestanding C89 headers, string.h, stdlib.h.
3651 * data.c, doprnt.c, floatfns.c, print.c:
3652 Include float.h unconditionally.
3653 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3654 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3655 * regex.c: Likewise for stddef.h, string.h.
3656 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3657 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3658 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3659 (STDC_HEADERS): Remove obsolete defines.
3660 * sysdep.c: Include limits.h unconditionally.
3661
9cfdb3ec
PE
3662 Assume support for memcmp, memcpy, memmove, memset.
3663 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3664 * regex.c (memcmp, memcpy):
3665 Remove; we assume C89 now.
3666
3667 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3668 (__malloc_safe_bcopy): Remove; no longer needed.
3669
cf950e6b 3670 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3671 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3672 well either way, and we prefer signed to unsigned.
3673
dbf38e02
LMI
36742011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3675
3676 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3677 closes the connection while we're reading (bug#9182).
3678
d6f0886c 36792011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3680
d6f0886c
JD
3681 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3682 are specified (Bug#9168).
24e0f6b1 3683
2eb1f9e6
PE
36842011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3685
3686 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3687 Found by GCC static checking and --with-wide-int on a 32-bit host.
3688
22381272 36892011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3690
3691 * xdisp.c (compute_display_string_pos): Fix logic of caching
3692 previous display string position. Initialize cached_prev_pos to
3693 -1. Fixes slow-down at the beginning of a buffer.
3694
f25e39b4
EZ
36952011-07-24 Eli Zaretskii <eliz@gnu.org>
3696
3697 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3698 for attrs[LFACE_FONTSET_INDEX].
3699
04c4b52e
PE
37002011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 * xml.c (parse_region): Remove unused local
3703 that was recently introduced.
3704
c1734fbd
EZ
37052011-07-23 Eli Zaretskii <eliz@gnu.org>
3706
be18c5a5
EZ
3707 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3708 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3709
c1734fbd
EZ
3710 * xdisp.c (move_it_in_display_line_to): Record the best matching
3711 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3712 exit if none of the characters scanned was an exact match.
3713 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3714 when exact match is impossible due to invisible text, and the
3715 lines are truncated.
3716
a258d627
JD
37172011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3718
3719 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3720 for OSX >= 10.7.
3721
b6d5a689
EZ
37222011-07-22 Eli Zaretskii <eliz@gnu.org>
3723
0f74f785
EZ
3724 Fix a significant slow-down of cursor motion with C-n, C-p,
3725 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3726 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3727 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3728 (next_element_from_buffer): Call compute_stop_pos_backwards to
3729 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3730 base_level_stop.
3731 (reseat): Don't look for prev_stop, as that could mean a very long
3732 run.
3733 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3734 <cached_disp_overlay_modiff>: Cache for last found display string
3735 position.
551918c1 3736 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3737 about the same buffer in the same area of character positions, and
3738 the buffer wasn't changed since the time the display string
3739 position was cached.
551918c1 3740
b2d0c91a
EZ
37412011-07-22 Eli Zaretskii <eliz@gnu.org>
3742
3743 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3744 is an integer, which is important for empty lines. (Bug#9149)
3745
043604ee
CY
37462011-07-22 Chong Yidong <cyd@stupidchicken.com>
3747
3748 * frame.c (Fmodify_frame_parameters): In tty case, update the
3749 default face if necessary (Bug#4238).
3750
da4adb04
CY
37512011-07-21 Chong Yidong <cyd@stupidchicken.com>
3752
3753 * editfns.c (Fstring_to_char): No need to explain what a character
3754 is in the docstring (Bug#6576).
3755
9abd0532
LMI
37562011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3757
3758 * xml.c (parse_region): Make sure we always return a tree.
3759
36881d16
HK
37602011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3761
3762 * xml.c (parse_region): If a document contains only comments,
3763 return that, too.
3764
1e98674d
LMI
37652011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3766
3767 * xml.c (make_dom): Return comments, too.
3768
590bd467
PE
37692011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3770
3771 Port to OpenBSD.
3772 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3773 and the surrounding thread.
3774 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3775 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3776 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3777 timer goes off.
3778 * s/openbsd.h (BROKEN_SIGIO): Define.
3779 * unexelf.c (unexec) [__OpenBSD__]:
3780 Don't update the .mdebug section of the Alpha COFF symbol table.
3781
f41628b2
LMI
37822011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3783
3784 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3785 (bug#8460).
3786
b59b67c5
PE
37872011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3788
15e3a074
PE
3789 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3790 This fixes some race conditions on the permissions of any newly
3791 created file.
3792
41bed37d
PE
3793 * alloc.c (valid_pointer_p): Use pipe, not open.
3794 This fixes some permissions issues when debugging.
3795
b59b67c5
PE
3796 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3797 If fchown fails to set both uid and gid, try to set just gid,
3798 as that is sometimes allowed. Adjust the file's mode to eliminate
3799 setuid or setgid bits that are inappropriate if fchown fails.
3800
925a6be7
SM
38012011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3802
3803 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3804 to compare Lisp_Objects.
3805 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3806 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3807 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3808
52968808
AS
38092011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3810
0a6a104b
AS
3811 * lread.c (read_integer): Unread even EOF character.
3812 (read1): Likewise. Properly record start position of symbol.
3813
52968808
AS
3814 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3815 symbol character follows.
3816
9e381cdd
PE
38172011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3818
3819 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3820 This works around a problem with the previous change to Fcopy_file.
3821 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3822 and without this change, GCC might complain about discarding
3823 fchown's return value.
3824
b5641435
JB
38252011-07-16 Juanma Barranquero <lekktu@gmail.com>
3826
3827 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3828
a8031457
PE
38292011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3830
3831 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3832
dd889327
LMI
38332011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3834
750c33f7
LMI
3835 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3836 it's used from the C level.
3837
dd889327
LMI
3838 * process.c: Use the same condition for POLL_FOR_INPUT in both
3839 keyboard.c and process.c (bug#1858).
3840
87e86684
LM
38412011-07-09 Lawrence Mitchell <wence@gmx.li>
3842
3843 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3844 (Fgnutls_boot): Use it.
3845
64348f40
AS
38462011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3847
3848 * doc.c (Fsubstitute_command_keys): Revert last change.
3849
1d698799
LMI
38502011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3851
f863868c
LMI
3852 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3853 quotes the next character, and doesn't affect other longer
3854 sequences (bug#8935).
3855
1d698799
LMI
3856 * lread.c (syms_of_lread): Clarify that is isn't only
3857 `eval-buffer' and `eval-defun' that's affected by
3858 `lexical-binding' (bug#8460).
3859
aa4b6df6
EZ
38602011-07-15 Eli Zaretskii <eliz@gnu.org>
3861
3862 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3863 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3864
5d856da6
PE
38652011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3866
ad6042bb
PE
3867 Fix minor problems found by static checking.
3868 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3869 (elsz): Now a signed constant, not a size_t var. We prefer signed
3870 types to unsigned, to avoid integer comparison confusion. Without
3871 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3872 "cannot optimize loop, the loop counter may overflow", a symptom
3873 of the confusion.
f00bbb22 3874 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3875 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3876
6468f31c
LMI
38772011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3878
49080b10
LMI
3879 * search.c (Fre_search_backward): Mention `case-fold-search' in
3880 all the re_search_* functions (bug#8138).
3881
6468f31c
LMI
3882 * keyboard.c (Fopen_dribble_file): Document when the file is
3883 closed (bug#8056).
3884
c965adc5
EZ
38852011-07-14 Eli Zaretskii <eliz@gnu.org>
3886
df9733bf
EZ
3887 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3888 bidi_cache_idx.
3889
0bb23927
EZ
3890 Support bidi reordering of display and overlay strings.
3891 * xdisp.c (compute_display_string_pos)
3892 (compute_display_string_end): Accept additional argument STRING.
3893 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3894 (reseat_to_string): Initialize bidi_it->string.s and
3895 bidi_it->string.schars.
3896 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3897 NULL (avoids a crash in bidi_paragraph_init).
3898 Initialize itb.string.lstring.
0bb23927
EZ
3899 (init_iterator): Call bidi_init_it only of a valid
3900 buffer position was specified. Initialize paragraph_embedding to
3901 L2R.
3902 (reseat_to_string): Initialize the bidi iterator.
3903 (display_string): If we need to ignore text properties of
3904 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3905 original value of -1 will not work with bidi.)
3906 (compute_display_string_pos): First arg is now struct
3907 `text_pos *'; all callers changed. Support display properties on
3908 Lisp strings.
3909 (compute_display_string_end): Support display properties on Lisp
3910 strings.
3911 (init_iterator, reseat_1, reseat_to_string): Initialize the
3912 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3913 when iterating on a string not from display properties).
640c8776
SM
3914 (compute_display_string_pos, compute_display_string_end):
3915 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3916 arrow keys.
3917 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3918 base_level_stop; instead, set base_level_stop to BEGV.
3919 Fixes crashes in vertical-motion.
0bb23927
EZ
3920 (next_element_from_buffer): Improve commentary for when
3921 the iterator is before prev_stop.
3922 (init_iterator): Initialize bidi_p from the default value of
3923 bidi-display-reordering, not from buffer-local value. Use the
3924 buffer-local value only if initializing for buffer iteration.
3925 (handle_invisible_prop): Support invisible properties on strings
3926 that are being bidi-reordered.
3927 (set_iterator_to_next): Support bidi reordering of C strings and
3928 Lisp strings.
3929 (next_element_from_string): Support bidi reordering of Lisp
3930 strings.
3931 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3932 (display_string): Support display of R2L glyph rows.
3933 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3934 (init_iterator): Don't initialize it->bidi_p for strings
3935 here.
3936 (reseat_to_string): Initialize it->bidi_p for strings here.
3937 (next_element_from_string, next_element_from_c_string)
3938 (next_element_from_buffer): Add xassert's for correspondence
3939 between IT's object being iterated and it->bidi_it.string
3940 structure.
3941 (face_before_or_after_it_pos): Support bidi iteration.
3942 (next_element_from_c_string): Handle the case of the first string
3943 character that is not the first one in the visual order.
3944 (get_visually_first_element): New function, refactored from common
3945 parts of next_element_from_buffer, next_element_from_string, and
3946 next_element_from_c_string.
3947 (tool_bar_lines_needed, redisplay_tool_bar)
3948 (display_menu_bar): Force left-to-right direction. Add a FIXME
3949 comment for making that be controlled by a user option.
3950 (push_it, pop_it): Save and restore the state of the
3951 bidi iterator. Save and restore the bidi_p flag.
3952 (pop_it): Iterate out of display property for string iteration as
3953 well.
3954 (iterate_out_of_display_property): Support iteration over strings.
3955 (handle_single_display_spec): Set up it->bidi_it for iteration
3956 over a display string, and call bidi_init_it.
3957 (handle_single_display_spec, next_overlay_string)
3958 (get_overlay_strings_1, push_display_prop): Set up the bidi
3959 iterator for displaying display or overlay strings.
3960 (forward_to_next_line_start): Don't use the shortcut if
3961 bidi-iterating.
3962 (back_to_previous_visible_line_start): If handle_display_prop
3963 pushed the iterator stack, restore the internal state of the bidi
3964 iterator by calling bidi_pop_it same number of times.
3965 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3966 and we are bidi-iterating, don't decrement the iterator position;
3967 instead, set the first_elt flag in the bidi iterator, to produce
3968 the same effect.
3969 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3970 (push_display_prop): xassert that we are iterating a buffer.
3971 (push_it, pop_it): Save and restore paragraph_embedding member.
3972 (handle_single_display_spec, next_overlay_string)
3973 (get_overlay_strings_1, reseat_1, reseat_to_string)
3974 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3975 correctly. Don't assume unibyte strings are not bidi-reordered.
3976 (compute_display_string_pos)
3977 (compute_display_string_end): Fix handling the case of C string.
3978 (push_it, pop_it): Save and restore from_disp_prop_p.
3979 (handle_single_display_spec, push_display_prop): Set the
3980 from_disp_prop_p flag.
3981 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3982 (pop_it): Call iterate_out_of_display_property only if we are
3983 popping after iteration over a string that came from a display
3984 property. Fix a typo in popping stretch info. Add an assertion
3985 for verifying that the iterator position is in sync with the bidi
3986 iterator.
3987 (handle_single_display_spec, get_overlay_strings_1)
3988 (push_display_prop): Fix initialization of paragraph direction for
3989 string when that of the parent object is not yet determined.
3990 (reseat_1): Call bidi_init_it to resync the bidi
3991 iterator with IT's position. (Bug#7616)
3992 (find_row_edges): If ROW->start.pos gives position
3993 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3994 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3995 Reset the from_disp_prop_p flag.
3996 (SAVE_IT, RESTORE_IT): New macros.
3997 (pos_visible_p, face_before_or_after_it_pos)
3998 (back_to_previous_visible_line_start)
3999 (move_it_in_display_line_to, move_it_in_display_line)
4000 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4001 (try_scrolling, redisplay_window, display_line): Use them when
4002 saving a temporary copy of the iterator and restoring it back.
4003 (back_to_previous_visible_line_start, reseat_1)
4004 (init_iterator): Empty the bidi cache "stack".
4005 (move_it_in_display_line_to): If iterator ended up at
4006 EOL, but we never saw any buffer positions smaller than
4007 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4008 motion in bidi-reordered lines.
4009 (move_it_in_display_line_to): Record prev_method and prev_pos
4010 immediately before the call to set_iterator_to_next. Fixes cursor
4011 motion in bidi-reordered lines with stretch glyphs and strings
4012 displayed in margins. (Bug#8133) (Bug#8867)
4013 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4014 TO_CHARPOS.
640c8776
SM
4015 (pos_visible_p): Support positions in bidi-reordered lines.
4016 Save and restore bidi cache.
0bb23927
EZ
4017
4018 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4019 (bidi_paragraph_info): Delete unused struct.
4020 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4021 (bidi_cache_start): New variable.
4022 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4023 to zero.
4024 (bidi_cache_fetch_state, bidi_cache_search)
4025 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4026 (bidi_cache_find, bidi_peek_at_next_level)
4027 (bidi_level_of_next_char, bidi_find_other_level_edge)
4028 (bidi_move_to_visually_next): Compare cache index with
4029 bidi_cache_start rather than with zero.
4030 (bidi_fetch_char): Accept new argument STRING; all callers
4031 changed. Support iteration over a string. Support strings with
4032 display properties. Support unibyte strings. Fix the type of
4033 `len' according to what STRING_CHAR_AND_LENGTH expects.
4034 (bidi_paragraph_init, bidi_resolve_explicit_1)
4035 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4036 (bidi_level_of_next_char, bidi_move_to_visually_next):
4037 Support iteration over a string.
0bb23927
EZ
4038 (bidi_set_sor_type, bidi_resolve_explicit_1)
4039 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4040 can now be zero (for strings); special values 0 and -1 were
4041 changed to -1 and -2, respectively.
4042 (bidi_char_at_pos): New function.
4043 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4044 Call it instead of FETCH_MULTIBYTE_CHAR.
4045 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4046 initialized to valid values.
4047 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4048 values.
4049 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4050 the test for valid cached positions. Fix the logic for looking up
4051 the sentinel state in the cache. GCPRO the Lisp string we are
4052 iterating.
4053 (bidi_push_it, bidi_pop_it): New functions.
4054 (bidi_initialize): Initialize the bidi cache start stack pointer.
4055 (bidi_cache_ensure_space): New function, refactored from part of
4056 bidi_cache_iterator_state. Don't assume the required size is just
4057 one BIDI_CACHE_CHUNK away.
4058 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4059 (bidi_count_bytes, bidi_char_at_pos): New functions.
4060 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4061 always valid if bidi_cache_idx is valid.
4062 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4063 is valid if it's going to be used.
4064 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4065 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4066 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4067 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4068 (bidi_find_other_level_edge, bidi_cache_start_stack):
4069 All variables related to cache indices are now EMACS_INT.
c965adc5 4070
0bb23927
EZ
4071 * dispextern.h (struct bidi_string_data): New structure.
4072 (struct bidi_it): New member `string'. Make flag members be 1-bit
4073 fields, and put them last in the struct.
640c8776
SM
4074 (compute_display_string_pos, compute_display_string_end):
4075 Update prototypes.
0bb23927
EZ
4076 (bidi_push_it, bidi_pop_it): Add prototypes.
4077 (struct iterator_stack_entry): New members bidi_p,
4078 paragraph_embedding, and from_disp_prop_p.
4079 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4080 (bidi_shelve_cache, bidi_unshelve_cache):
4081 Declare prototypes.
0bb23927
EZ
4082
4083 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4084 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4085 and vector-like objects.
4086
4087 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4088 cache around display iteration.
4089
4090 * window.c (Fwindow_end, window_scroll_pixel_based)
4091 (displayed_window_lines, Frecenter): Save and restore the bidi
4092 cache around display iteration.
4093
3bbd2265
LMI
40942011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4095
4096 * editfns.c (Fdelete_region): Clarify the use of the named
4097 parameters (bug#6788).
4098
adc47434
MR
40992011-07-14 Martin Rudalics <rudalics@gmx.at>
4100
4101 * indent.c (Fvertical_motion): Set and restore w->pointm when
4102 saving and restoring the window's buffer (Bug#9006).
4103
837c31f8
LMI
41042011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4105
4106 * editfns.c (Fstring_to_char): Clarify just what is returned
4107 (bug#6576). Text by Eli Zaretskii.
4108
ac389d0c
JB
41092011-07-13 Juanma Barranquero <lekktu@gmail.com>
4110
4111 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4112
0be0ce47
EZ
41132011-07-13 Eli Zaretskii <eliz@gnu.org>
4114
4115 * buffer.c (mmap_find): Fix a typo.
4116
cd18e7e3
JB
41172011-07-13 Johan Bockgård <bojohan@gnu.org>
4118
4119 Fix execution of x selection hooks.
4120 * xselect.c (Qx_lost_selection_functions)
4121 (Qx_sent_selection_functions): New vars.
4122 (syms_of_xselect): DEFSYM them.
4123 (x_handle_selection_request): Pass Qx_sent_selection_functions
4124 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4125 (x_handle_selection_clear,x_clear_frame_selections):
4126 Pass Qx_lost_selection_functions rather than
4127 Vx_lost_selection_functions to Frun_hook_with_args.
4128
47ea7f44
PE
41292011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4130
ac389d0c 4131 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4132 The old code sometimes used this field without initializing it.
4133
47ea7f44
PE
4134 * alloc.c (gc_sweep): Don't read past end of array.
4135 In theory, the old code could also have corrupted Emacs internals,
4136 though it'd be very unlikely.
4137
bc985c87
AS
41382011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4139
4140 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4141 argument. (Bug#4026)
bc985c87 4142
0cf34688
LMI
41432011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4144
b3dadd76
LMI
4145 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4146 key" (bug#4257).
4147
0cf34688
LMI
4148 * window.c (Fset_window_start): Doc fix (bug#4199).
4149 (Fset_window_hscroll): Ditto.
4150
270768cd
PE
41512011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4152
077e3dda 4153 Fix minor new problems caught by GCC 4.6.1.
270768cd 4154 * term.c (init_tty): Remove unused local.
490011a6 4155 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4156 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4157 not used otherwise.
270768cd 4158
b1f58454
CY
41592011-07-12 Chong Yidong <cyd@stupidchicken.com>
4160
4161 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4162
22b9578d
LMI
41632011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4164
6e70ab07
LMI
4165 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4166 are the mini-buffer and the echo area (bug#3320).
4167
22b9578d
LMI
4168 * term.c (init_tty): Remove support for supdup, c10 and perq
4169 terminals, which are no longer supported (bug#1482).
4170
8974cc9f
JB
41712011-07-10 Johan Bockgård <bojohan@gnu.org>
4172
4173 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4174
a560d974
JD
41752011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4176
4177 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4178 for non-popups (Bug#3642).
4179
1dae0f0a
AS
41802011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4181
268c2c36 4182 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4183 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4184 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4185 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4186 * data.c (fmod): Likewise.
4187 * dispnew.c (swap_glyphs_in_rows): Likewise.
4188 * emacs.c (memory_warning_signal): Likewise.
4189 * floatfns.c (float_error): Likewise.
4190 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4191 (otf_open, font_otf_capability, generate_otf_features)
4192 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4193 Likewise.
4194 * image.c (pbm_read_file): Likewise.
4195 * indent.c (string_display_width): Likewise.
4196 * intervals.c (check_for_interval, search_for_interval)
4197 (inc_interval_count, count_intervals, root_interval)
4198 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4199 * lread.c (defalias): Likewise.
268c2c36 4200 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4201 * regex.c (set_image_of_range_1, set_image_of_range)
4202 (regex_grow_registers): Likewise.
4203 * sysdep.c (strerror): Likewise.
4204 * termcap.c (valid_filename_p, tprint, main): Likewise.
4205 * tparam.c (main): Likewise.
4206 * unexhp9k800.c (run_time_remap, save_data_space)
4207 (update_file_ptrs, read_header, write_header, calculate_checksum)
4208 (copy_file, copy_rest, display_header): Likewise.
4209 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4210 Likewise.
4211 * xdisp.c (check_it): Likewise.
4212 * xfaces.c (register_color, unregister_color, unregister_colors):
4213 Likewise.
4214 * xfns.c (print_fontset_result): Likewise.
4215 * xrdb.c (member, fatal, main): Likewise.
4216
99033785
PE
42172011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4218
4219 Fix minor problems found by static checking (Bug#9031).
4220 * chartab.c (char_table_set_range, map_sub_char_table):
4221 Remove unused locals.
4222 (uniprop_table): Now static.
4223 * composite.c (_work_char): Remove unused static var.
4224
9cb2ac56
JB
42252011-07-09 Juanma Barranquero <lekktu@gmail.com>
4226
4227 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4228
f25661f0
JD
42292011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4230
4231 * gtkutil.c (qttip_cb): Remove code without function.
4232
8278c4fe
EZ
42332011-07-09 Eli Zaretskii <eliz@gnu.org>
4234
4235 * w32.c (pthread_sigmask): New stub.
4236
1692ae2d 42372011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4238
8a6ebd58 4239 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4240 sigprocmask is portable only for single-threaded applications, and
4241 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4242 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4243 (LIBES): Use it.
4244 * callproc.c (Fcall_process):
4245 * process.c (create_process):
4246 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4247 Use pthread_sigmask, not sigprocmask.
123403e4 4248
1b854618
JD
42492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4250
4251 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4252 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4253 wrong (Bug#8591).
4254
3fe4b549
JD
42552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4256
0ce7e563
JD
4257 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4258 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4259 (xg_hide_tooltip): Fix comment.
4260
3fe4b549
JD
4261 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4262 in registerServicesMenuSendTypes.
4263 (validRequestorForSendType): Don't check ns_return_types.
4264
4265 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4266 ns_return_type.
4267
5df75e47
JR
42682011-07-08 Jason Rumney <jasonr@gnu.org>
4269
22610910
JR
4270 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4271 SH_SHOW for hidden windows (Bug#5482).
4272
5df75e47
JR
4273 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4274 frame struct members of non-existent frames (Bug#6284).
4275
699c10bd
JD
42762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4277
4393663b
JD
4278 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4279 variable firstTime not needed on OSX >= 10.6.
4280 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4281 >= 10.5. Use setKnobProportion, setDoubleValue.
4282
4283 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4284 (MAC_OS_X_VERSION_10_5): Define if not defined.
4285 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4286 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4287 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4288
4289 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4290 cString and lossyCString on OSX >= 10.4
4291
58179cce 4292 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4293 sizeToFit on OSX >= 10.2.
4294
4295 * nsimage.m (allocInitFromFile): Don't use deprecated method
4296 bestRepresentationForDevice on OSX >= 10.6.
4297
4298 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4299 to avoid warning.
4300
4301 * emacs.c: Declare unexec_init_emacs_zone.
4302
a63e0781
JD
4303 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4304
699c10bd
JD
4305 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4306
4307 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4308 on svcsMenu (Bug#8842).
4309
4310 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4311 ns_return_types.
4312 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4313
4314 * nsterm.m (QUTF8_STRING): Declare.
4315 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4316 (validRequestorForSendType): Return type is (id).
4317 Change indexOfObjectIdenticalTo to indexOfObject.
4318 Check if we have local selection before returning self (Bug#8842).
4319 (writeSelectionToPasteboard): Put local selection into paste board
4320 if we have a local selection (Bug#8842).
4321 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4322
4323 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4324 (ns_get_local_selection): Declare.
4325
54e10184
LMI
43262011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4327
9888ff71
LMI
4328 * keymap.c (describe_map_tree): Don't insert a double newline at
4329 the end of the buffer (bug#1169) and return whether we inserted
4330 something.
4331
54e10184
LMI
4332 * callint.c (Fcall_interactively): Change "reading args" to
4333 "providing args" to try to clarify what it does (bug#1010).
4334
15fa4783
KH
43352011-07-07 Kenichi Handa <handa@m17n.org>
4336
4337 * composite.c (composition_compute_stop_pos): Ignore a static
4338 composition starting before CHARPOS (Bug#8915).
4339
4340 * xdisp.c (handle_composition_prop): Likewise.
4341
a8815b00
EZ
43422011-07-07 Eli Zaretskii <eliz@gnu.org>
4343
4344 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4345 (Bug#9015)
4346
ef7b981d 43472011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4348
4349 * character.h (unicode_category_t): New enum type.
4350
4351 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4352 (Qchar_code_property_table): New variable.
4353 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4354 (UNIPROP_COMPRESSED_FORM_P): New macros.
4355 (char_table_ascii): Uncompress the compressed values.
4356 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4357 Uncompress the compressed values.
ac389d0c 4358 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4359 (char_table_ref_and_range): Uncompress the compressed values.
4360 (sub_char_table_set): New arg is_uniprop. Callers changed.
4361 Uncompress the compressed values.
4362 (sub_char_table_set_range): Args changed. Callers changed.
4363 (char_table_set_range): Adjuted for the above change.
4364 (map_sub_char_table): Delete args default_val and parent. Add arg
4365 top. Give decoded values to a Lisp function.
640c8776 4366 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4367 values to a Lisp function. Gcpro more variables.
4368 (uniprop_table_uncompress)
4369 (uniprop_decode_value_run_length): New functions.
4370 (uniprop_decoder, uniprop_decoder_count): New variables.
4371 (uniprop_get_decoder, uniprop_encode_value_character)
4372 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4373 New functions.
4374 (uniprop_encoder, uniprop_encoder_count): New variables.
4375 (uniprop_get_encoder, uniprop_table)
4376 (Funicode_property_table_internal, Fget_unicode_property_internal)
4377 (Fput_unicode_property_internal): New functions.
4378 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4379 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4380 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4381 char-code-property-alist.
4382
640c8776 4383 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4384 Vunicode_category_table.
4385
640c8776 4386 * font.c (font_range): Adjust for the change of
c805dec0
KH
4387 Vunicode_category_table.
4388
76b397fb
DN
43892011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4390
4391 * m/iris4d.h: Remove file, move contents ...
4392 * s/irix6-5.h: ... here.
4393
22b4128e
PE
43942011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4395
4396 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4397 * alloc.c (mark_buffer):
4398 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4399 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4400 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4401 This isn't true in general, and it's particularly not true
4402 if Emacs is configured with --with-wide-int.
4403 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4404 New macros, used in the buffer.c change.
4405
869795d6
JD
44062011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4407
4408 * xsettings.c: Use both GConf and GSettings if both are available.
4409 (store_config_changed_event): Add comment.
4410 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4411 (store_tool_bar_style_changed): New functions.
5e617bc2 4412 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4413 (struct xsettings): Move font inside HAVE_XFT.
4414 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4415 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4416 Move inside HAVE_XFT.
640c8776 4417 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4418 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4419 also.
4420 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4421 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4422 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4423 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4424 (parse_settings): Move check for font inside HAVE_XFT.
4425 (read_settings, apply_xft_settings): Add comment.
4426 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4427 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4428 call store_font_name_changed.
4429 (xft_settings_event): Add comment.
4430 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4431 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4432 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4433 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4434 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4435 (xsettings_get_system_font, xsettings_get_system_normal_font):
4436 Add comment.
869795d6 4437
d8ed26bd
PE
44382011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4439
4440 Random fixes. E.g., (random) never returned negative values.
4441 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4442 subseconds part to the entropy, as that's a bit more random.
4443 Prefer signed to unsigned, since the signedness doesn't matter and
4444 in general we prefer signed. When given a limit, use a
4445 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4446 latter isn't right if USE_2_TAGS_FOR_INTS.
4447 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4448 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4449
cabf1cac
SM
44502011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4451
4452 * textprop.c (text_property_stickiness):
4453 Obey Vtext_property_default_nonsticky.
4454 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4455 * w32fns.c (syms_of_w32fns):
4456 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4457
6e9b2be9
PE
44582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4459
4460 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4461 This is more efficient than Ffile_directory_p and avoids a minor race.
4462
90186c68
LMI
44632011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4464
7c301272
LMI
4465 * buffer.c (Foverlay_put): Say what the return value is
4466 (bug#7835).
4467
c4f2d8d4
LMI
4468 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4469 is a directory before asking whether to use the file name
4470 (bug#7564).
ad637907
LMI
4471 (barf_or_query_if_file_exists): Make the "File is a directory"
4472 error be more correct.
c4f2d8d4 4473
90186c68
LMI
4474 * fns.c (Frequire): Remove the mention of the .gz files, since
4475 that's installation-specific, but keep the mention of
4476 `get-load-suffixes'.
4477
da64016e
PE
44782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4479
4480 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4481 Report string overflow if the output is too long.
4482
7d47b580
JB
44832011-07-04 Juanma Barranquero <lekktu@gmail.com>
4484
a555cb87
JB
4485 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4486 (syms_of_gnutls): Remove duplicate DEFSYM for
4487 Qgnutls_bootprop_verify_hostname_error, an error for
4488 Qgnutls_bootprop_verify_error (which is no longer used).
4489
7d47b580
JB
4490 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4491 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4492 Also (re)move comments that are misplaced or no longer relevant.
4493
1e49bfab
LMI
44942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4495
4496 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4497
1485f4c0
CY
44982011-07-03 Chong Yidong <cyd@stupidchicken.com>
4499
4500 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4501 and background color parameters if they have been changed.
4502
a9ab721e
LMI
45032011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4504
4505 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4506
cf7cff57
PE
45072011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4508
2e13213d
PE
4509 * xsettings.c (SYSTEM_FONT): Define only when used.
4510 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4511
cf7cff57
PE
4512 * keymap.c (access_keymap_1): Now static.
4513
7a8e04f7
CY
45142011-07-02 Chong Yidong <cyd@stupidchicken.com>
4515
4516 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4517 leave any prefix arg for the up event (Bug#1586).
4518
61352f62
LMI
45192011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4520
69bb1ef7
LMI
4521 * lread.c (syms_of_lread): Mention single symbols defined by
4522 `defvar' or `defconst' (bug#7154).
4523
61352f62 4524 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4525 (Frequire): Mention get-load-suffixes.
61352f62 4526
28545e04
MR
45272011-07-02 Martin Rudalics <rudalics@gmx.at>
4528
4529 * window.h (window): Remove clone_number slot.
4530 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4531 Remove.
4532 (make_parent_window, make_window, saved_window)
4533 (Fset_window_configuration, save_window_save): Don't deal with
4534 clone numbers.
4535 * buffer.c (Qclone_number): Remove declaration.
4536 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4537
3349e122
SM
45382011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4539
4540 Add multiple inheritance to keymaps.
4541 * keymap.c (Fmake_composed_keymap): New function.
4542 (Fset_keymap_parent): Simplify.
4543 (fix_submap_inheritance): Remove.
4544 (access_keymap_1): New function extracted from access_keymap to handle
4545 embedded parents and handle lists of maps.
4546 (access_keymap): Use it.
4547 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4548 (Fcopy_keymap): Handle embedded parents.
4549 (Fcommand_remapping, define_as_prefix): Simplify.
4550 (Fkey_binding): Simplify.
4551 (syms_of_keymap): Move minibuffer-local-completion-map,
4552 minibuffer-local-filename-completion-map,
4553 minibuffer-local-must-match-map, and
4554 minibuffer-local-filename-must-match-map to Elisp.
4555 (syms_of_keymap): Defsubr make-composed-keymap.
4556 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4557 (parse_menu_item): Trivial simplification.
4558
3279eb87
GM
45592011-07-01 Glenn Morris <rgm@gnu.org>
4560
4561 * Makefile.in (SETTINGS_LIBS): Fix typo.
4562
4550efdf
KI
45632011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4564
4565 * coding.c (Fencode_coding_string): Record the last coding system
4566 used, as the function doc string says (bug#8738).
4567
0949d2b6
JD
45682011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4569
4570 * xsettings.c (store_monospaced_changed): Take new font as arg and
4571 check for change against current_mono_font.
4572 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4573 (emacs_settings_constructor, emacs_settings_get_property)
4574 (emacs_settings_set_property, emacs_settings_class_init)
4575 (emacs_settings_init, gsettings_obj): Remove.
4576 (something_changedCB): New function for HAVE_GSETTINGS.
4577 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4578 with value as argument.
4579 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4580 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4581 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4582 "changed".
4583
4584 * xgselect.c: Add defined (HAVE_GSETTINGS).
4585 (xgselect_initialize): Ditto.
4586
4587 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4588 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4589 xg_select.
4590
bbc6b304
PE
45912011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4592
4593 * eval.c (struct backtrace): Simplify and port the data structure.
4594 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4595 signed bit field, as this assumption is not portable and it makes
4596 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4597 "char debug_on_exit : 1" as this is not portable either; instead,
4598 use the portable "unsigned int debug_on_exit : 1". Remove unused
4599 member evalargs. Remove obsolete comments about cc bombing out.
4600
9851bfc5
JD
46012011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4602
51bb811f 4603 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4604 Let HAVE_GSETTINGS override HAVE_GCONF.
4605 (store_monospaced_changed): New function.
4606 (EMACS_SETTINGS): A new type derived from GObject to handle
4607 GSettings notifications.
4608 (emacs_settings_constructor, emacs_settings_get_property)
4609 (emacs_settings_set_property, emacs_settings_class_init):
4610 New functions.
4611 (gsettings_client, gsettings_obj): New variables.
4612 (GSETTINGS_SCHEMA): New define.
4613 (something_changedCB): Call store_monospaced_changed.
4614 (init_gsettings): New function.
4615 (xsettings_initialize): Call init_gsettings.
4616 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4617 to NULL.
4618
640c8776 4619 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4620 GCONF_CFLAGS/LIBS.
4621
5386012d
MR
46222011-06-29 Martin Rudalics <rudalics@gmx.at>
4623
4624 * window.c (resize_root_window, grow_mini_window)
4625 (shrink_mini_window): Rename Qresize_root_window to
4626 Qwindow_resize_root_window and Qresize_root_window_vertically to
4627 Qwindow_resize_root_window_vertically.
4628
f13e0b08
PE
46292011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4630
4631 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4632
94515237
JB
46332011-06-27 Juanma Barranquero <lekktu@gmail.com>
4634
4635 * makefile.w32-in: Redesign dependencies so they reflect more
4636 clearly which files are directly included by each source file,
4637 and not through other includes.
4638
e43b6e43
MR
46392011-06-27 Martin Rudalics <rudalics@gmx.at>
4640
4641 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4642 (sort_overlays, overlay_strings): When an overlay's clone number
4643 matches the window's clone number process the overlay even if
4644 the overlay's window property doesn't match the current window.
4645
d68443dc
MR
4646 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4647 (Fwindow_hchild): Rename to Fwindow_left_child.
4648 (Fwindow_next): Rename to Fwindow_next_sibling.
4649 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4650 (resize_window_check): Rename to window_resize_check.
4651 (resize_window_apply): Rename to window_resize_apply.
4652 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4653 (Fdelete_other_windows_internal, resize_frame_windows)
4654 (Fsplit_window_internal, Fdelete_window_internal)
4655 (grow_mini_window, shrink_mini_window)
4656 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4657
c7e73be5
JD
46582011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4659
4660 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4661 (emacs_fixed_set_min_size): Remove.
4662 (emacs_fixed_new): Take frame as argument.
4663
4664 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4665 (_EmacsFixedPrivate): Remove minwidth/height.
4666 Add struct frame *f.
4667 (emacs_fixed_init): Initialize priv->f.
4668 (get_parent_class, emacs_fixed_set_min_size): Remove.
4669 (emacs_fixed_new): Set priv->f to argument.
4670 (emacs_fixed_get_preferred_width)
4671 (emacs_fixed_get_preferred_height): Use min_width/height from
4672 frames size_hint to set minimum and natural (Bug#8919).
4673 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4674 and use min_width/height from frames size_hint to set
4675 min_width/height (Bug#8919).
4676
4677 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4678 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4679 Fix indentation.
c7e73be5 4680
cf99dcf8
EZ
46812011-06-26 Eli Zaretskii <eliz@gnu.org>
4682
4683 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4684 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4685 called at ZV.
4686
029529ac
CY
46872011-06-26 Chong Yidong <cyd@stupidchicken.com>
4688
4689 * process.c (wait_reading_process_output): Bypass select if
4690 waiting for a cell while ignoring keyboard input, and input is
4691 pending. Suggested by Jan Djärv (Bug#8869).
4692
7a7ef429
PE
46932011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4694
4695 Use gnulib's dup2 module instead of rolling our own.
4696 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4697
11fdef7d 46982011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4699
4700 * dispnew.c (scrolling_window): Before scrolling, turn off a
4701 mouse-highlight in the window being scrolled.
4702
cd3520a4
JB
47032011-06-24 Juanma Barranquero <lekktu@gmail.com>
4704
4705 Move DEFSYM to lisp.h and use everywhere.
4706
4707 * character.h (DEFSYM): Move declaration...
4708 * lisp.h (DEFSYM): ...here.
4709
4710 * gnutls.c:
4711 * minibuf.c:
4712 * w32menu.c:
4713 * w32proc.c:
4714 * w32select.c: Don't include character.h.
4715
4716 * alloc.c (syms_of_alloc):
4717 * buffer.c (syms_of_buffer):
4718 * bytecode.c (syms_of_bytecode):
4719 * callint.c (syms_of_callint):
4720 * casefiddle.c (syms_of_casefiddle):
4721 * casetab.c (init_casetab_once):
4722 * category.c (init_category_once, syms_of_category):
4723 * ccl.c (syms_of_ccl):
4724 * cmds.c (syms_of_cmds):
4725 * composite.c (syms_of_composite):
4726 * dbusbind.c (syms_of_dbusbind):
4727 * dired.c (syms_of_dired):
4728 * dispnew.c (syms_of_display):
4729 * doc.c (syms_of_doc):
4730 * editfns.c (syms_of_editfns):
4731 * emacs.c (syms_of_emacs):
4732 * eval.c (syms_of_eval):
4733 * fileio.c (syms_of_fileio):
4734 * fns.c (syms_of_fns):
4735 * frame.c (syms_of_frame):
4736 * fringe.c (syms_of_fringe):
4737 * insdel.c (syms_of_insdel):
4738 * keymap.c (syms_of_keymap):
4739 * lread.c (init_obarray, syms_of_lread):
4740 * macros.c (syms_of_macros):
4741 * msdos.c (syms_of_msdos):
4742 * print.c (syms_of_print):
4743 * process.c (syms_of_process):
4744 * search.c (syms_of_search):
4745 * sound.c (syms_of_sound):
4746 * syntax.c (init_syntax_once, syms_of_syntax):
4747 * terminal.c (syms_of_terminal):
4748 * textprop.c (syms_of_textprop):
4749 * undo.c (syms_of_undo):
4750 * w32.c (globals_of_w32):
4751 * window.c (syms_of_window):
4752 * xdisp.c (syms_of_xdisp):
4753 * xfaces.c (syms_of_xfaces):
4754 * xfns.c (syms_of_xfns):
4755 * xmenu.c (syms_of_xmenu):
4756 * xsettings.c (syms_of_xsettings):
4757 * xterm.c (syms_of_xterm): Use DEFSYM.
4758
4228cf16
TZ
47592011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4760
cd3520a4 4761 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4762
7fcccf1e
PE
47632011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4764
7efb4e0e
PE
4765 Integer and buffer overflow fixes (Bug#8873).
4766
ff5844ad
PE
4767 * print.c (printchar, strout): Check for string overflow.
4768 (PRINTPREPARE, printchar, strout):
4769 Don't set size unless allocation succeeds.
4770
90532f02
PE
4771 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4772 for sizes. Check for string overflow more accurately.
4773 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4774
6d84508d
PE
4775 * macros.c: Integer and buffer overflow fixes.
4776 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4777 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4778 Use ptrdiff_t, not int, for sizes.
4779 Don't increment bufsize until after realloc succeeds.
4780 Check for size-calculation overflow.
4781 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4782
437b2cb4
PE
4783 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4784
8b9ac8b4
PE
4785 * lread.c: Integer overflow fixes.
4786 (read_integer): Radix is now EMACS_INT, not int,
4787 to improve quality of diagnostics for out-of-range radices.
4788 Calculate buffer size correctly for out-of-range radices.
4789 (read1): Check for integer overflow in radices, and in
4790 read-circle numbers.
82cb60d3
PE
4791 (read_escape): Avoid int overflow.
4792 (Fload, openp, read_buffer_size, read1)
4793 (substitute_object_recurse, read_vector, read_list, map_obarray):
4794 Use ptrdiff_t, not int, for sizes.
4795 (read1): Use EMACS_INT, not int, for sizes.
20270765 4796 Check for size overflow.
8b9ac8b4 4797
7fcccf1e
PE
4798 * image.c (cache_image): Check for size arithmetic overflow.
4799
bfbbd7e7
PE
4800 * lread.c: Integer overflow issues.
4801 (saved_doc_string_size, saved_doc_string_length)
4802 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4803 Now ptrdiff_t, not int.
4804 (read1): Don't assume doc string length fits in int. Check for
4805 out-of-range doc string lengths.
4806 (read_list): Don't assume file position fits in int.
39019e54 4807 (read_escape): Check for hex character overflow.
bfbbd7e7 4808
4e323265
LL
48092011-06-22 Leo Liu <sdl.web@gmail.com>
4810
4811 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4812 Move to minibuffer.el.
4813
85fece3e
PE
48142011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4815
20b84ce9 4816 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4817 The following patches are for when GLYPH_DEBUG && !XASSERT.
4818 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4819 * dispnew.c (flush_stdout):
4820 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4821 Mark as externally visible.
4822 * dispnew.c (check_window_matrix_pointers): Now static.
4823 * dispnew.c (window_to_frame_vpos):
4824 * xfns.c (unwind_create_frame):
4825 * xterm.c (x_check_font): Remove unused local.
4826 * scroll.c (CHECK_BOUNDS):
4827 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4828 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4829 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4830 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4831 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4832 Now static.
4833 (debug_method_add): Use va_list and vsprintf rather than relying
4834 on undefined behavior with wrong number of arguments.
4835 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4836 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4837 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4838 since we're not interested in debugging glyphs with old libraries.
4839 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4840 GCC 4.6.0's static checking.
4841
0766b489
PE
48422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4843
31fd4b32
PE
4844 Integer overflow and signedness fixes (Bug#8873).
4845 A few related buffer overrun fixes, too.
4846
b79e8648
PE
4847 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4848
0766b489
PE
4849 * dispextern.h (struct face.stipple):
4850 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4851 (x_bitmap_mask, x_allocate_bitmap_record)
4852 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4853 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4854 (x_create_bitmap_from_xpm_data):
4855 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4856 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4857 (.bitmaps_last):
4858 * xfaces.c (load_pixmap):
4859 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4860 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4861 (.bitmaps_last, struct x_output.icon_bitmap):
4862 Use ptrdiff_t, not int, for bitmap indexes.
4863 (x_allocate_bitmap_record): Check for size overflow.
4864 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4865
b081724f
PE
4866 Use ptrdiff_t, not int, for overlay counts.
4867 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4868 * editfns.c (overlays_around, get_pos_property):
4869 * textprop.c (get_char_property_and_overlay):
4870 * xdisp.c (next_overlay_change, note_mouse_highlight):
4871 * xfaces.c (face_at_buffer_position):
21514da7
PE
4872 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4873 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4874 (Fnext_overlay_change, Fprevious_overlay_change)
4875 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4876 Use ptrdiff_t, not int, for sizes.
21514da7 4877 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4878
3de73e5e
PE
4879 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4880
2606c57b
PE
4881 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4882 (x_session_initialize): Do not assume string length fits in int.
4883
aaafe47a
PE
4884 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4885 This is unlikely, but can occur if DPI is outlandish.
4886
2674ddc8 4887 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4888 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4889
28154962
PE
4890 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4891 * xrdb.c (magic_file_p, search_magic_path):
4892 Omit last arg SUFFIX; it was always 0. All callers changed.
4893 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4894
7de51af5
PE
4895 * xfont.c (xfont_match): Avoid need for strlen.
4896
25ed6cc3
PE
4897 * xfns.c: Don't assume strlen fits in int.
4898 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4899
4eab31dd
PE
4900 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4901 not unsigned long, as we prefer signed integers. All callers changed.
4902 Detect integer overflow in repeat count.
4903 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4904 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4905
171e2a58
PE
4906 * termcap.c: Don't assume sizes fit in int and never overflow.
4907 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4908 (gobble_line): Check for size-calculation overflow.
4909
ad39faca 4910 * minibuf.c (Fread_buffer):
6e5bb2dc 4911 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4912 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4913 Don't assume string length fits in int.
4914
52c61c22 4915 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4916 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4917
b5b8c9e5
PE
4918 * font.c: Don't assume string length fits in int.
4919 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4920 Use ptrdiff_t, not int.
ccd6111c
PE
4921 (font_intern_prop): Don't assume string length fits in int.
4922 Don't assume integer property fits in fixnum.
4923 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4924
882f0d81 4925 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4926 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4927 Reformulate so as not to need the command string.
4928 Invoke gzip -cd rather than gunzip, as it's more portable.
4929 (lock_info_type, lock_file_1, lock_file):
4930 Don't assume pid_t and time_t fit in unsigned long.
4931 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4932 (current_lock_owner): Prefer signed type for sizes.
4933 Use memcpy, not strncpy, where memcpy is what is really wanted.
4934 Don't assume (via atoi) that time_t and pid_t fit in int.
4935 Check for time_t and/or pid_t out of range, e.g., via a network share.
4936 Don't alloca where an auto var works fine.
4937
93f4cf88
PE
4938 * fileio.c: Fix some integer overflow issues.
4939 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4940 Don't assume string length fits in int.
4941 (directory_file_name): Don't assume string length fits in long.
4942 (make_temp_name): Don't assume pid fits in int, or that its print
4943 length is less than 20.
4944
f3e92b69
PE
4945 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4946
1bfdaf10
PE
4947 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4948
35016e9a
PE
4949 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4950
3d1e65a1
PE
4951 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4952 We prefer signed integers, even for size calculations.
4953
0b963a93
PE
4954 * emacs.c: Don't assume string length fits in 'int'.
4955 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4956 (main): Don't invoke strlen when not needed.
4957
573f4b54
PE
4958 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4959 (XD_DEBUG_MESSAGE): Don't waste a byte.
4960
989f33ba
PE
4961 * callproc.c (getenv_internal_1, getenv_internal)
4962 (Fgetenv_internal):
965d34eb
PE
4963 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4964
e4d29b33
PE
4965 * lread.c (invalid_syntax): Omit length argument.
4966 All uses changed. This doesn't fix a bug, but it simplifies the
4967 code away from its former Hollerith-constant appearance, and it's
4968 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4969 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4970
eb49b136
PE
4971 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4972 This didn't break anything, but it didn't help either.
4973 It's confusing to put a bogus integer in a place where the actual
4974 value does not matter.
9f62aeb1 4975 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4976 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4977
15375a22
PE
4978 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4979 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4980 implementation.
b61cc01c
PE
4981 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4982 We prefer signed types, and the value cannot exceed the EMACS_INT
4983 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4984 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4985 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4986 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4987
53b2623d
PE
4988 * indent.c (sane_tab_width): New function.
4989 (current_column, scan_for_column, Findent_to, position_indentation)
4990 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4991 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4992
51cab52b 4993 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4994
f2ed8a70
PE
4995 * lisp.h (lint_assume): New macro.
4996 * composite.c (composition_gstring_put_cache):
4997 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4998
abe80cc6
PE
4999 * editfns.c, insdel.c:
5000 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5001
b02c740e
PE
5002 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5003
ebc96716
PE
5004 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5005
b4e50fa0 5006 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5007 Use much-faster test for byte-length change.
311d5d7c 5008 Don't assume string byte-length fits in 'int'.
a4cf38e4 5009 Check that character arg fits in 'int'.
85461888 5010 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5011
c0c1ee9f
PE
5012 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5013
a498d7f4
PE
5014 * fns.c (concat): Catch string overflow earlier.
5015 Do not rely on integer wraparound.
5016
51cab52b
PE
5017 * dispextern.h (struct it.overlay_strings_charpos)
5018 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5019 * xdisp.c (forward_to_next_line_start)
5020 (back_to_previous_visible_line_start)
5021 (reseat_at_next_visible_line_start, next_element_from_buffer):
5022 Don't arbitrarily truncate the value of 'selective' to int.
5023
76031fad
PE
5024 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5025
5eb55db9
PE
5026 * composite.c: Don't truncate sizes to 'int'.
5027 (composition_gstring_p, composition_reseat_it)
5028 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5029 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5030 not EMACS_UINT, for indexes.
5eb55db9 5031
0703a717
PE
5032 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5033
d6202519
PE
5034 * buffer.c: Include <verify.h>.
5035 (struct sortvec.priority, struct sortstr.priority):
8961a454 5036 Now EMACS_INT, not int.
c20998a7 5037 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5038 (struct sortstr.size, record_overlay_string)
5039 (struct sortstrlist.size, struct sortlist.used):
5040 Don't truncate size to int.
5041 (record_overlay_string): Check for size-calculation overflow.
d6202519 5042 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5043
d5a19415
JM
50442011-06-22 Jim Meyering <meyering@redhat.com>
5045
029529ac 5046 Don't leak an XBM-image-sized buffer
d5a19415
JM
5047 * image.c (xbm_load): Free the image buffer after using it.
5048
a9041e6c
PE
50492011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5050
5051 Port to Sun C.
5052 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5053 that Sun C diagnosed.
5054 * fns.c (secure_hash): Fix pointer signedness issue.
5055 * intervals.c (static_offset_intervals): New function.
5056 (offset_intervals): Use it.
5057
7f3f739f
LL
50582011-06-21 Leo Liu <sdl.web@gmail.com>
5059
5060 * deps.mk (fns.o):
5061 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5062 sha512.h.
5063
5064 * fns.c (secure_hash): Rename from crypto_hash_function and change
5065 the first arg to accept symbols.
5b66d427 5066 (Fsecure_hash): New primitive.
7f3f739f
LL
5067 (syms_of_fns): New symbols.
5068
76147d94
DD
50692011-06-20 Deniz Dogan <deniz@dogan.se>
5070
5071 * process.c (Fset_process_buffer): Clarify return value in
5072 docstring.
5073
7d7d0045
CY
50742011-06-18 Chong Yidong <cyd@stupidchicken.com>
5075
5076 * dispnew.c (add_window_display_history): Use BVAR.
5077
5078 * xdisp.c (debug_method_add): Use BVAR.
5079 (check_window_end, dump_glyph_matrix, dump_glyph)
5080 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5081
5082 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5083 Likewise.
5084
5085 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5086 check till after the cache is created in init_frame_faces.
5087
ff2bc410
SM
50882011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5089
5090 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5091
28177add
PE
50922011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5093
dd3482fe
PE
5094 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5095 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5096 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5097
393d71f3 5098 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5099 * fileio.c (Finsert_file_contents):
5100 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5101 Remove the old (too-loose) buffer overflow checks.
5102 They weren't needed, since make_gap checks for buffer overflow.
5103 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5104 The old code merely checked for Emacs fixnum overflow, and relied
5105 on undefined (wraparound) behavior. The new code avoids undefined
5106 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5107
2e6813b0 5108 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5109 Tune. Don't use wider integers than needed. Don't use alloca.
5110 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5111
599a9e4f
PE
5112 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5113
99561444
PE
5114 * insdel.c, lisp.h (buffer_overflow): New function.
5115 (insert_from_buffer_1, replace_range, replace_range_2):
5116 * insdel.c (make_gap_larger):
5117 * editfns.c (Finsert_char):
5118 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5119
28177add
PE
5120 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5121
e69dafad
PE
51222011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5123
4baa020d 5124 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5125
b1c46f02
PE
5126 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5127 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5128
e69dafad
PE
5129 * fileio.c: Don't assume EMACS_INT fits in off_t.
5130 (emacs_lseek): New static function.
5131 (Finsert_file_contents, Fwrite_region): Use it.
5132 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5133
566684ea
PE
5134 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5135
e6966cd6
PE
5136 * fns.c: Don't overflow int when computing a list length.
5137 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5138 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5139 truncation on 64-bit hosts. Check for QUIT every
5140 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5141 faster and is responsive enough.
5142 (Flength): Report an error instead of overflowing an integer.
5143 (Fsafe_length): Return a float if the value is not representable
5144 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5145 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5146 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5147
dd0b0efb
PE
5148 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5149 (header_size, word_size): New constants.
5150 (allocate_vectorlike): Don't check size overflow here.
5151 (allocate_vector): Check it here instead, since this is the only
5152 caller of allocate_vectorlike that could cause overflow.
5153 Check that the new vector's length is representable as a fixnum.
5154
86fe5cfe
PE
5155 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5156 The previous code was bogus. For example, next_almost_prime (32)
5157 returned 39, which is undesirable as it is a multiple of 3; and
5158 next_almost_prime (24) returned 25, which is a multiple of 5 so
5159 why was the code bothering to check for multiples of 7?
5160
80e88859
PE
5161 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5162
4a2f0ad6
PE
5163 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5164
f66c7cf8
PE
5165 Variadic C functions now count arguments with ptrdiff_t.
5166 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5167 Back then I didn't know that the Emacs coding style prefers signed int.
5168 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5169 were being counted with int, which may truncate counts on 64-bit
5170 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5171 * lisp.h (struct Lisp_Subr.function.aMANY)
5172 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5173 Arg counts are now ptrdiff_t, not size_t.
5174 All variadic functions and their callers changed accordingly.
5175 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5176 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5177 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5178 * callint.c (Fcall_interactively): Check arg count for overflow,
5179 to avoid potential buffer overrun. Use signed char, not 'int',
5180 for 'varies' array, so that we needn't bother to check its size
5181 calculation for overflow.
5182 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5183 * eval.c (apply_lambda):
5184 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5185 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5186 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5187
a1759b76
PE
5188 * callint.c (Fcall_interactively): Don't use index var as event count.
5189
d96be9fc
PE
5190 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5191 * mem-limits.h (SIZE): Remove; no longer used.
5192
a690a978 5193 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5194
578c21e6
PE
5195 Remove unnecessary casts.
5196 * xterm.c (x_term_init):
5197 * xfns.c (x_set_border_pixel):
5198 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5199 These aren't needed now that we assume ANSI C.
5200
96f53c6c
PE
5201 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5202 It's more likely to cause problems (due to unsigned overflow)
5203 than to cure them.
5204
83c77d31
PE
5205 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5206
ee2079f1
PE
5207 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5208
6da65536
PE
5209 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5210
7147c4a4
PE
5211 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5212
193e32d9
PE
5213 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5214
e5533da6
PE
5215 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5216
9910e595
PE
5217 GLYPH_CODE_FACE returns EMACS_INT, not int.
5218 * dispextern.h (merge_faces):
5219 * xfaces.c (merge_faces):
01103c44
PE
5220 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5221 Don't assume EMACS_INT fits in int.
9910e595 5222
2638320e
PE
5223 * character.h (CHAR_VALID_P): Remove unused parameter.
5224 * fontset.c, lisp.h, xdisp.c: All uses changed.
5225
045eb8d9
PE
5226 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5227
c1f134b5
PE
5228 * fns.c (concat): Minor tuning based on overflow analysis.
5229 This doesn't fix any bugs. Use int to hold character, instead
5230 of constantly refetching from Emacs object. Use XFASTINT, not
5231 XINT, for value known to be a character. Don't bother comparing
5232 a single byte to 0400, as it's always less.
5233
395fcb93 5234 * floatfns.c (Fexpt):
327eeec8
PE
5235 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5236
abbd3d23
PE
5237 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5238 for characters.
5239
684a03ef
PE
5240 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5241
0fed43f3
PE
5242 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5243 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5244 incorrectly succeed when S was a string, because 4294967386 was
5245 truncated before it was used.
5246
8fd02eb7
PE
5247 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5248 Otherwise, an out-of-range integer could cause undefined behavior
5249 on a 64-bit host.
5250
f8c86b69
PE
5251 * composite.c: Use int, not EMACS_INT, for characters.
5252 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5253 EMACS_INT, for values that are known to be in character range.
5254 This doesn't fix any bugs but is the usual style inside Emacs and
5255 may generate better code on 32-bit machines.
5256
34206dd2
PE
5257 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5258 This is for reasons similar to the recent CHAR_STRING fix.
5259 * charset.c (Fencode_char): Check that character arg is actually
5260 a character. Pass an int to ENCODE_CHAR.
5261 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5262 wider than 'int', as a compile-time check to prevent future regressions
5263 in this area.
5264
c5958d4c 5265 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5266
5267 Make sure a 64-bit char is never passed to CHAR_STRING.
5268 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5269 by silently ignoring the top 32 bits, allowing some values
5270 that were far too large to be valid characters.
5271 * character.h: Include <verify.h>.
5272 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5273 arguments are no wider than unsigned, as a compile-time check
5274 to prevent future regressions in this area.
5275 * data.c (Faset):
01103c44 5276 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5277 (Fsubst_char_in_region):
5278 * fns.c (concat):
5279 * xdisp.c (decode_mode_spec_coding):
5280 Adjust to CHAR_STRING's new requirement.
5281 * editfns.c (Finsert_char, Fsubst_char_in_region):
5282 * fns.c (concat): Check that character args are actually
5283 characters. Without this test, these functions did the wrong
5284 thing with wildly out-of-range values on 64-bit hosts.
5285
d37ca623
PE
5286 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5287 These casts should not be needed on 32-bit hosts, either.
5288 * keyboard.c (read_char):
5289 * lread.c (Fload): Remove casts to unsigned.
5290
ea204efb
PE
5291 * lisp.h (UNSIGNED_CMP): New macro.
5292 This fixes comparison bugs on 64-bit hosts.
5293 (ASCII_CHAR_P): Use it.
5294 * casefiddle.c (casify_object):
01103c44 5295 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5296 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5297 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5298 * dispextern.h (FACE_FROM_ID):
5299 * keyboard.c (read_char): Use UNSIGNED_CMP.
5300
41cb286c
PE
5301 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5302 not to EMACS_INT, to avoid GCC warning.
5303
4a1b9832
PE
5304 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5305
55daad71
PE
5306 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5307 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5308 isn't needed on 32-bit machines.
8f95c75c 5309
01103c44
PE
5310 * buffer.c (Fgenerate_new_buffer_name):
5311 Use EMACS_INT for count, not int.
0ceccced 5312 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5313
5314 * data.c (Qcompiled_function): Now static.
5315
c6f072e7
PE
5316 * window.c (window_body_lines): Now static.
5317
20ce5912
PE
5318 * image.c (gif_load): Rename local to avoid shadowing.
5319
9c4c5f81
PE
5320 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5321 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5322 * alloc.c (make_save_value): Integer argument is now of type
5323 ptrdiff_t, not int.
5324 (mark_object): Use ptrdiff_t, not int.
5325 * lisp.h (pD): New macro.
5326 * print.c (print_object): Use it.
5327
c0c5c8ae
PE
5328 * alloc.c: Use EMACS_INT, not int, to count objects.
5329 (total_conses, total_markers, total_symbols, total_vector_size)
5330 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5331 (total_free_floats, total_floats, total_free_intervals)
5332 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5333 Now EMACS_INT, not int. All uses changed.
5334 (Fgarbage_collect): Compute overall total using a double, so that
5335 integer overflow is less likely to be a problem. Check for overflow
5336 when converting back to an integer.
5a25e253
PE
5337 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5338 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5339 These were 'int' variables that could overflow on 64-bit hosts;
5340 they were never used, so remove them instead of repairing them.
211a0b2a 5341 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5342 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5343 Previously, this ceilinged at INT_MAX, but that doesn't work on
5344 64-bit machines.
e46bb31a 5345 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5346
c78baabf 5347 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5348 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5349 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5350 when a (possibly-narrower) signed value would do just as well.
5351 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5352
c9d624c6
PE
5353 * alloc.c: Catch some string size overflows that we were missing.
5354 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5355 for convenience in STRING_BYTES_MAX.
5356 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5357 The definition here is exact; the one in lisp.h was approximate.
5358 (allocate_string_data): Check for string overflow. This catches
5359 some instances we weren't catching before. Also, it catches
5360 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5361 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5362 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5363
c9d624c6
PE
5364 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5365 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5366 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5367
353032ce
PE
5368 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5369
2bccce07
PE
5370 * alloc.c (Fmake_string): Check for out-of-range init.
5371
0ac30604
SM
53722011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5373
5374 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5375
c195f2de
JD
53762011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5377
5378 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5379 xg_get_default_scrollbar_width.
5380
5381 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5382 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5383 (style_changed_cb): Call update_theme_scrollbar_width and call
5384 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5385 all frames (Bug#8505).
5386 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5387 Call gtk_window_set_resizable if HAVE_GTK3.
5388 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5389 and height if HAVE_GTK3 (Bug#8505).
5390 (scroll_bar_width_for_theme): New variable.
5391 (update_theme_scrollbar_width): New function.
5392 (xg_get_default_scrollbar_width): Move code to
5393 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5394 (xg_initialize): Call update_theme_scrollbar_width.
5395
5396 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5397
5398 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5399
e10ac9f1
MR
54002011-06-12 Martin Rudalics <rudalics@gmx.at>
5401
5402 * frame.c (make_frame): Call other_buffer_safely instead of
5403 other_buffer.
5404
5405 * window.c (temp_output_buffer_show): Call display_buffer with
5406 second argument Vtemp_buffer_show_specifiers and reset latter
5407 immediately after the call.
5408 (Vtemp_buffer_show_specifiers): New variable.
5409 (auto_window_vscroll_p, next_screen_context_lines)
5410 (Vscroll_preserve_screen_position): Remove leading asterisks from
5411 doc-strings.
5412
2d3c217e 54132011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5414
7b7f97e8 5415 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5416 * buffer.c (Qclone_number): Remove for now, as it's unused.
5417 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5418 (record_buffer): Remove unused local.
5419 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5420 (set_frame_buffer_list): Remove; unused.
5421 * frame.h (other_visible_frames): Remove decl.
5422 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5423 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5424 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5425 if HAVE_GPM.
5426 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5427 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5428 Define only if HAVE_GPM.
5429 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5430 (update_hints_inhibit): Remove; never set. All uses removed.
5431 * widgetprv.h (emacsFrameClassRec): Remove decl.
5432 * window.c (delete_deletable_window): Now returns void, since it
5433 wasn't returning anything.
5434 (compare_window_configurations): Remove unused locals.
5435 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5436 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5437 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5438 the same widths as pointers. This follows up on the 2011-05-06 patch.
5439 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5440 * xterm.h: Likewise.
5441 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5442
1384b89e
JB
54432011-06-12 Juanma Barranquero <lekktu@gmail.com>
5444
5445 * makefile.w32-in: Update dependencies.
5446 (LISP_H): Add lib/intprops.h.
5447
1100a63c
CY
54482011-06-11 Chong Yidong <cyd@stupidchicken.com>
5449
5450 * image.c (gif_load): Add animation frame delay to the metadata.
5451 (syms_of_image): Use DEFSYM. New symbol `delay'.
5452
6198ccd0
MR
54532011-06-11 Martin Rudalics <rudalics@gmx.at>
5454
5455 * window.c (delete_deletable_window): Re-add.
5456 (Fset_window_configuration): Rewrite to handle dead buffers and
5457 consequently deletable windows.
5458 (window_tree, Fwindow_tree): Remove. Supply functionality in
5459 window.el.
5460 (compare_window_configurations): Simplify code.
5461
b6e3633c
AS
54622011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5463
1ab0dee5
AS
5464 * image.c (imagemagick_load_image): Fix type mismatch.
5465 (Fimagemagick_types): Likewise.
5466
b6e3633c
AS
5467 * window.h (replace_buffer_in_windows): Declare.
5468
9397e56f
MR
54692011-06-11 Martin Rudalics <rudalics@gmx.at>
5470
5471 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5472 Qclone_number. Remove external declaration of Qdelete_window.
5473 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5474 code.
640c8776
SM
5475 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5476 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5477 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5478 buffer list implementation.
5479 (other_buffer_safely): New function.
5480 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5481 calls to replace_buffer_in_windows and
5482 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5483 if allowed.
5484 (record_buffer): Inhibit quitting and rewrite using quittable
5485 functions. Run Qbuffer_list_update_hook if allowed.
5486 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5487 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5488 Move switch-to-buffer to window.el.
9397e56f
MR
5489 (bury-buffer): Move to window.el.
5490 (Vbuffer_list_update_hook): New variable.
5491
5492 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5493 section.
5494
5495 * window.h (resize_frame_windows): Move up in code.
5496 (Fwindow_frame): Remove EXFUN.
5497 (replace_buffer_in_all_windows): Remove prototype.
5498 (replace_buffer_in_windows_safely): Add prototype.
5499
5500 * window.c: Declare Qdelete_window static again. Move down
5501 declaration of select_count.
5502 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5503 (Fother_window): Move to window.el.
5504 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5505 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5506 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5507 window.el.
5508 (replace_buffer_in_windows): Implement by calling
5509 Qreplace_buffer_in_windows.
5510 (replace_buffer_in_all_windows): Remove with some functionality
5511 moved into replace_buffer_in_windows_safely.
5512 (replace_buffer_in_windows_safely): New function.
5513 (select_window_norecord, select_frame_norecord): Move in front
5514 of run_window_configuration_change_hook. Remove now obsolete
5515 declarations.
640c8776
SM
5516 (Fset_window_buffer): Rewrite doc-string.
5517 Call Qrecord_window_buffer.
9397e56f
MR
5518 (keys_of_window): Move binding for other-window to window.el.
5519
b50691aa
CY
55202011-06-11 Chong Yidong <cyd@stupidchicken.com>
5521
5522 * dispextern.h (struct image): Replace data member, whose int_val
5523 and ptr_val fields were not used by anything, with a single
5524 lisp_val object.
5525
5526 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5527 (gif_clear_image, gif_load, imagemagick_load_image)
5528 (gs_clear_image, gs_load): Callers changed.
5529
3f754b86
PE
55302011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5531
cca69397
PE
5532 * buffer.h: Include <time.h>, for time_t.
5533 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5534
109e28d0
PE
5535 Fix minor problems found by static checking.
5536
60737f02
PE
5537 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5538
4b66faf3
PE
5539 Make identifiers static if they are not used in other modules.
5540 * data.c (Qcompiled_function, Qframe, Qvector):
5541 * image.c (QimageMagick, Qsvg):
5542 * minibuf.c (Qmetadata):
5543 * window.c (resize_window_check, resize_root_window): Now static.
5544 * window.h (resize_window_check, resize_root_window): Remove decls.
5545
109e28d0
PE
5546 * window.c (window_deletion_count, delete_deletable_window):
5547 Remove; unused.
46a4ce9e
PE
5548 (window_body_lines): Now static.
5549 (Fdelete_other_windows_internal): Mark vars as initialized.
5550 Make sure 'resize_failed' is initialized.
5551 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5552 (resize_window_apply): Remove unused local.
5553 * window.h (delete_deletable_window): Remove decl.
5554
109e28d0 5555 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5556 (imagemagick_load_image): Fix pointer signedness problem by changing
5557 last arg from unsigned char * to char *. All uses changed.
5558 Also, fix a local for similar reasons.
5559 Remove unused locals. Remove locals to avoid shadowing.
5560 (fn_rsvg_handle_free): Remove; unused.
5561 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5562 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5563
3f754b86
PE
5564 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5565
2547adb1
CY
55662011-06-10 Chong Yidong <cyd@stupidchicken.com>
5567
5568 * image.c (gif_load): Fix omitted cast error introduced by
5569 2011-06-06 change.
5570
2c8e37d4
MR
55712011-06-10 Martin Rudalics <rudalics@gmx.at>
5572
5573 * window.h (resize_proportionally, orig_total_lines)
5574 (orig_top_line): Remove from window structure.
5575 (set_window_height, set_window_width, change_window_heights)
5576 (Fdelete_window): Remove prototypes.
5577 (resize_frame_windows): Remove duplicate declaration.
5578
440a42e3
EZ
55792011-06-10 Eli Zaretskii <eliz@gnu.org>
5580
5581 * window.h (resize_frame_windows, resize_window_check)
5582 (delete_deletable_window, resize_root_window)
5583 (resize_frame_windows): Declare prototypes.
5584
5585 * window.c (resize_window_apply): Make definition be "static" to
5586 match the prototype.
5587
562dd5e9
MR
55882011-06-10 Martin Rudalics <rudalics@gmx.at>
5589
5590 * window.c: Remove declarations of Qwindow_size_fixed,
5591 window_min_size_1, window_min_size_2, window_min_size,
5592 size_window, window_fixed_size_p, enlarge_window, delete_window.
5593 Remove static from declaration of Qdelete_window, it's
5594 temporarily needed by Fbury_buffer.
5595 (replace_window): Don't assign orig_top_line and
5596 orig_total_lines.
5597 (Fdelete_window, delete_window): Remove. Window deletion is
5598 handled by window.el.
640c8776
SM
5599 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5600 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5601 (Fdelete_other_windows): Remove. Deleting other windows is
5602 handled by window.el.
5603 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5604 handled in window.el.
5605 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5606 Window minimum sizes are handled in window.el.
5607 (shrink_windows, size_window, set_window_height)
5608 (set_window_width, change_window_heights, window_height)
5609 (window_width, CURBEG, CURSIZE, enlarge_window)
5610 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5611 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5612 handled in window.el.
5613 (make_dummy_parent): Rename to make_parent_window and give it a
5614 second argument horflag.
5615 (make_window): Don't set resize_proportionally any more.
5616 (Fsplit_window): Remove. Windows are split in window.el.
5617 (save_restore_action, save_restore_orig_size)
5618 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5619 Resize mini windows in window.el.
5620 (grow_mini_window, shrink_mini_window): Implement by calling
5621 Qresize_root_window_vertically, resize_window_check and
5622 resize_window_apply.
640c8776
SM
5623 (saved_window, Fset_window_configuration, save_window_save):
5624 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5625 resize_proportionally.
5626 (window_min_height, window_min_width): Move to window.el.
5627 (keys_of_window): Move bindings for delete-other-windows,
5628 split-window, delete-window and enlarge-window to window.el.
5629
5630 * buffer.c: Temporarily extern Qdelete_window.
5631 (Fbury_buffer): Temporarily call Qdelete_window instead of
5632 Fdelete_window (Fbury_buffer will move to window.el soon).
5633
5634 * frame.c (set_menu_bar_lines_1): Remove code handling
5635 orig_top_line and orig_total_lines.
5636
5637 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5638 set_window_height but set heights directly.
5639 (change_frame_size_1): Use resize_frame_windows.
5640
5641 * xdisp.c (init_xdisp): Don't use set_window_height but set
5642 heights directly.
5643
640c8776
SM
5644 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5645 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5646 run_window_configuration_change_hook.
5647
5648 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5649 instead of change_window_heights and run
5650 run_window_configuration_change_hook.
5651
1a13852e
MR
56522011-06-09 Martin Rudalics <rudalics@gmx.at>
5653
5654 * window.c (replace_window): Rename second argument REPLACEMENT to
5655 NEW. New third argument SETFLAG. Rewrite.
5656 (delete_window, make_dummy_parent): Call replace_window with
5657 third argument 1.
5658 (window_list_1): Move down in code.
5659 (run_window_configuration_change_hook): Move set_buffer part
5660 before select_frame_norecord part in order to unwind correctly.
5661 Rename count1 to count.
5662 (recombine_windows, delete_deletable_window, resize_root_window)
5663 (Fdelete_other_windows_internal)
5664 (Frun_window_configuration_change_hook, make_parent_window)
5665 (resize_window_check, resize_window_apply, Fresize_window_apply)
5666 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5667 (Fdelete_window_internal, Fresize_mini_window_internal):
5668 New functions.
1a13852e
MR
5669 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5670
f3d1777e
MR
56712011-06-08 Martin Rudalics <rudalics@gmx.at>
5672
496e208e
MR
5673 * window.h (window): Add some new members to window structure -
5674 normal_lines, normal_cols, new_total, new_normal, clone_number,
5675 splits, nest, prev_buffers, next_buffers.
5676 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5677 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5678
f3d1777e
MR
5679 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5680 Remove.
496e208e
MR
5681 (make_dummy_parent): Set new members of windows structure.
5682 (make_window): Move down in code. Handle new members of window
5683 structure.
5684 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5685 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5686 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5687 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5688 (Fset_window_next_buffers, Fset_window_clone_number):
5689 New functions.
496e208e
MR
5690 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5691 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5692 Doc-string fixes.
5693 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5694 Argument WINDOW can be now internal window too.
5695 (Fwindow_use_time): Move up in code.
5696 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5697 Rewrite doc-string.
5698 (Fset_window_configuration, saved_window)
5699 (Fcurrent_window_configuration, save_window_save): Handle new
5700 members of window structure.
b9e809c2
MR
5701 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5702 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5703 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5704 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5705 Qget_mru_window, Qresize_root_window,
5706 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5707 Qauto_buffer_name; staticpro them.
f3d1777e 5708
abde8f8c
MR
57092011-06-07 Martin Rudalics <rudalics@gmx.at>
5710
5711 * window.c (Fwindow_total_size, Fwindow_left_column)
5712 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5713 (Fwindow_list_1): New functions.
5714 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5715 (Fwindow_width, Fscroll_left, Fscroll_right):
5716 Use window_body_cols instead of window_box_text_cols.
5717 (delete_window, Fset_window_configuration):
5718 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5719 (delete_all_subwindows): Take a window as argument and not a
5720 structure. Rewrite.
190b47e6
MR
5721 (window_loop): Remove handling of GET_LRU_WINDOW and
5722 GET_LARGEST_WINDOW.
5723 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5724
5725 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5726 window_box_text_cols. delete_all_subwindows now takes a
5727 Lisp_Object as argument.
abde8f8c 5728
640c8776
SM
5729 * indent.c (compute_motion, Fcompute_motion):
5730 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5731
fa8a67e6
MR
5732 * frame.c (delete_frame): Call delete_all_subwindows with root
5733 window as argument.
5734
a54e3482
DC
57352011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5736
5737 * fns.c (Fputhash): Document return value.
5738
60002bf5
CY
57392011-06-06 Chong Yidong <cyd@stupidchicken.com>
5740
5741 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5742
0c671da6 57432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5744
b862a52a 5745 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5746
be44ca6c
PE
5747 Check for overflow when converting integer to cons and back.
5748 * charset.c (Fdefine_charset_internal, Fdecode_char):
5749 Use cons_to_unsigned to catch overflow.
5750 (Fencode_char): Use INTEGER_TO_CONS.
5751 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5752 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5753 * data.c (long_to_cons, cons_to_long): Remove.
5754 (cons_to_unsigned, cons_to_signed): New functions.
5755 These signal an error for invalid or out-of-range values.
5756 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5757 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5758 * font.c (Ffont_variation_glyphs):
5759 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5760 * lisp.h: Include <intprops.h>.
5761 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5762 (cons_to_signed, cons_to_unsigned): New decls.
5763 (long_to_cons, cons_to_long): Remove decls.
5764 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5765 (Fprimitive_undo): Use CONS_TO_INTEGER.
5766 * xfns.c (Fx_window_property): Likewise.
5767 * xselect.c: Include <limits.h>.
5768 (x_own_selection, selection_data_to_lisp_data):
5769 Use INTEGER_TO_CONS.
5770 (x_handle_selection_request, x_handle_selection_clear)
5771 (x_get_foreign_selection, Fx_disown_selection_internal)
5772 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5773 (lisp_data_to_selection_data): Use cons_to_unsigned.
5774 (x_fill_property_data): Use cons_to_signed.
5775 Report values out of range.
5776
d1f3d2af
PE
5777 Check for buffer and string overflow more precisely.
5778 * buffer.h (BUF_BYTES_MAX): New macro.
5779 * lisp.h (STRING_BYTES_MAX): New macro.
5780 * alloc.c (Fmake_string):
5781 * character.c (string_escape_byte8):
5782 * coding.c (coding_alloc_by_realloc):
5783 * doprnt.c (doprnt):
5784 * editfns.c (Fformat):
5785 * eval.c (verror):
5786 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5787 since they may not be the same number.
5788 * editfns.c (Finsert_char):
5789 * fileio.c (Finsert_file_contents):
5790 Likewise for BUF_BYTES_MAX.
5791
dd52fcea
PE
5792 * image.c: Use ptrdiff_t, not int, for sizes.
5793 (slurp_file): Switch from int to ptrdiff_t.
5794 All uses changed.
5795 (slurp_file): Check that file size fits in both size_t (for
5796 malloc) and ptrdiff_t (for sanity and safety).
5797
7f9bbdbb
PE
5798 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5799 if b->modtime has its maximal value.
5800
dfe18f82
PE
5801 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5802
84acfcf0
PE
5803 Don't assume time_t can fit into int.
5804 * buffer.h (struct buffer.modtime): Now time_t, not int.
5805 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5806 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5807
ccd9a01a
PE
5808 Minor fixes for signed vs unsigned integers.
5809 * character.h (MAYBE_UNIFY_CHAR):
5810 * charset.c (maybe_unify_char):
5811 * keyboard.c (read_char, reorder_modifiers):
5812 XINT -> XFASTINT, since the integer must be nonnegative.
5813 * ftfont.c (ftfont_spec_pattern):
5814 * keymap.c (access_keymap, silly_event_symbol_error):
5815 XUINT -> XFASTINT, since the integer must be nonnegative.
5816 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5817 since it makes no difference and we prefer signed.
5818 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5819 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5820 nonnegative.
5821
d6d100dd
SM
58222011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5823
5824 * window.h (Fwindow_frame): Declare.
5825
2b6148e4
PE
58262011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5827
5828 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5829 (SPARE_MEMORY): Always define.
5830 (LARGE_REQUEST): Remove.
5831 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5832
f230ecc9
MR
58332011-06-06 Martin Rudalics <rudalics@gmx.at>
5834
727e958e
MR
5835 * lisp.h: Move EXFUNS for Fframe_root_window,
5836 Fframe_first_window and Fset_frame_selected_window to window.h.
5837
5838 * window.h: Move EXFUNS for Fframe_root_window,
5839 Fframe_first_window and Fset_frame_selected_window here from
5840 lisp.h.
5841
5842 * frame.c (Fwindow_frame, Fframe_first_window)
5843 (Fframe_root_window, Fframe_selected_window)
5844 (Fset_frame_selected_window): Move to window.c.
5845 (Factive_minibuffer_window): Move to minibuf.c.
5846 (Fother_visible_frames_p): New function.
5847
5848 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5849
f230ecc9
MR
5850 * window.c (decode_window, decode_any_window): Move up in code.
5851 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5852 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5853 (Fwindow_buffer): Move up and rewrite doc-string.
5854 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5855 (Fwindow_prev): New functions.
727e958e
MR
5856 (Fwindow_frame): Move here from frame.c. Accept any window as
5857 argument.
5858 (Fframe_root_window, Fframe_first_window)
5859 (Fframe_selected_window): Move here from frame.c. Accept frame
5860 or arbitrary window as argument. Update doc-strings.
5861 (Fminibuffer_window): Move up in code.
5862 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5863 (Fset_frame_selected_window): Move here from frame.c.
5864 Marginal rewrite.
727e958e
MR
5865 (Fselected_window, select_window, Fselect_window): Move up in
5866 code. Minor doc-string fixes.
f230ecc9 5867
4d09bcf6
PE
58682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5869
5870 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5871 Do not assume that spare memory exists; that assumption is valid
5872 only if SYSTEM_MALLOC.
5873 (LARGE_REQUEST): New macro, so that the issue of large requests
5874 is separated from the issue of spare memory.
5875
810928a2
AS
58762011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5877
172418ad
AS
5878 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5879 format. (Bug#8806)
5880
43f862f7
AS
5881 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5882
810928a2
AS
5883 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5884 before statements.
5885
a059fe24
JD
58862011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5887
5888 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5889
5890 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5891
5892 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5893 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5894
989bf368
JB
58952011-06-05 Juanma Barranquero <lekktu@gmail.com>
5896
5897 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5898
4b80f674
CY
58992011-06-04 Chong Yidong <cyd@stupidchicken.com>
5900
5901 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5902 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5903 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5904 New error handlers.
4b80f674
CY
5905 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5906 Obey Vx_select_enable_clipboard_manager. Catch errors in
5907 x_clipboard_manager_save (Bug#8779).
5908 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5909 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5910
99a33b77 59112011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5912
5913 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5914
99a33b77 59152011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5916
5917 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5918 in the current matrix if keep_current_p is non-zero.
5919
8264569d
EZ
59202011-06-04 Eli Zaretskii <eliz@gnu.org>
5921
5922 * bidi.c (bidi_level_of_next_char): Fix last change.
5923
57f97249
EZ
59242011-06-03 Eli Zaretskii <eliz@gnu.org>
5925
fec2107c 5926 Support bidi reordering of text covered by display properties.
57f97249 5927
fec2107c
EZ
5928 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5929 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5930 (bidi_cache_search, bidi_cache_iterator_state)
5931 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5932 (bidi_level_of_next_char, bidi_move_to_visually_next):
5933 Support character positions inside a run of characters covered by a
fec2107c
EZ
5934 display string.
5935 (bidi_paragraph_init, bidi_resolve_explicit_1)
5936 (bidi_level_of_next_char): Call bidi_fetch_char and
5937 bidi_fetch_char_advance instead of FETCH_CHAR and
5938 FETCH_CHAR_ADVANCE.
5939 (bidi_init_it): Initialize new members.
5940 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5941 definitions.
5942 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5943 instead of using explicit *_CHAR codes.
d6d100dd
SM
5944 (bidi_resolve_explicit, bidi_resolve_weak):
5945 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5946 bidirectional text is supported only in multibyte buffers.
5947 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5948 it to initialize the frame_window_p member of struct bidi_it.
5949 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5950 (bidi_resolve_explicit, bidi_resolve_weak)
5951 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5952 bidi_it->nchars is non-positive.
5953 (bidi_level_of_next_char): Don't try to lookup the cache for the
5954 next/previous character if nothing is cached there yet, or if we
5955 were just reseat()'ed to a new position.
c40e2fb2 5956
0e14fe90
EZ
5957 * xdisp.c (set_cursor_from_row): Set start and stop points
5958 according to the row's direction when priming the loop that looks
5959 for the glyph on which to display cursor.
5960 (single_display_spec_intangible_p): Function deleted.
5961 (display_prop_intangible_p): Reimplement to call
5962 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5963 Accept 3 additional arguments needed by handle_display_spec.
5964 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5965 values: lists, `(when COND...)' forms, etc.
5966 (single_display_spec_string_p): Support property values that are
5967 lists with the argument STRING its top-level element.
5968 (display_prop_string_p): Fix the condition for processing a
5969 property that is a list to be consistent with handle_display_spec.
fec2107c 5970 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5971 last portion of handle_display_prop.
5972 (compute_display_string_pos): Accept additional argument
5973 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5974 value of a `display' property is a "replacing spec".
5975 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5976 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5977 the display property, but just return a value indicating whether
5978 the display property will replace the characters it covers.
5979 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5980 frame_window_p members of struct bidi_it.
d6d100dd
SM
5981 (compute_display_string_pos, compute_display_string_end):
5982 New functions.
fec2107c
EZ
5983 (push_it): Accept second argument POSITION, where pop_it should
5984 jump to continue iteration.
5985 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5986
fec2107c
EZ
5987 * keyboard.c (adjust_point_for_property): Adjust the call to
5988 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5989
5990 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5991 (bidi_init_it): Update prototypes.
5992 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5993 (compute_display_string_pos, compute_display_string_end):
5994 Declare prototypes.
fec2107c
EZ
5995 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5996 EMACS_INT.
fc6f18ce 5997
40087514 59982011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5999
57f53182
PE
6000 Malloc failure behavior now depends on size of allocation.
6001 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6002 * lisp.h: Change signatures accordingly.
6003 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6004 All callers changed. (Bug#8762)
6005
6006 * gnutls.c: Use Emacs's memory allocators.
6007 Without this change, the gnutls library would invoke malloc etc.
6008 directly, which causes problems on non-SYNC_INPUT hosts, and which
6009 runs afoul of improving memory_full behavior. (Bug#8761)
6010 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6011 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6012 xfree instead of the default malloc, realloc, free.
6013 (Fgnutls_boot): No need to check for memory allocation failure,
6014 since xmalloc does that for us.
6015
ac32cd99 6016 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6017 * category.c (hash_get_category_set):
6018 * ccl.c (ccl_driver):
6019 * charset.c (Fdefine_charset_internal):
6020 * charset.h (struct charset.hash_index):
6021 * composite.c (get_composition_id, gstring_lookup_cache)
6022 (composition_gstring_put_cache):
6023 * composite.h (struct composition.hash_index):
6024 * dispextern.h (struct image.hash):
6025 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6026 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6027 (hashfn_equal, hashfn_user_defined, make_hash_table)
6028 (maybe_resize_hash_table, hash_lookup, hash_put)
6029 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6030 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6031 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6032 * image.c (make_image, search_image_cache, lookup_image)
6033 (xpm_put_color_table_h):
6034 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6035 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6036 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6037 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6038 * alloc.c (allocate_vectorlike):
6039 Check for overflow in vector size calculations.
6040 * ccl.c (ccl_driver):
6041 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6042 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6043 need to be updated by these changes.
40087514
PE
6044 * fns.c (make_hash_table, maybe_resize_hash_table):
6045 Check for integer overflow with large hash tables.
0de4bb68
PE
6046 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6047 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6048 (SXHASH_REDUCE): New macro.
6049 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6050 Use it instead of discarding useful hash info with large hash values.
6051 (sxhash_float): New function.
6052 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6053 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6054 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6055 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6056 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6057 Adjust signatures to match updated version of code.
6058 (consing_since_gc): Now EMACS_INT, since a single hash table can
6059 use more than INT_MAX bytes.
6060
698d32e2
DN
60612011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6062
6063 Make it possible to build with GCC-4.6+ -O2 -flto.
6064
6065 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6066
fd6fa53f
SM
60672011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6068
6069 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6070 Call minibuffer-inactive-mode.
6071
864db017
JB
60722011-05-31 Juanma Barranquero <lekktu@gmail.com>
6073
6074 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6075 Update dependencies.
6076
2ad0baf4
DN
60772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6078
6079 * data.c (init_data): Remove code for UTS, this system is not
6080 supported anymore.
6081
4fcc2638
DN
60822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6083
6084 Don't force ./temacs to start in terminal mode.
6085
6086 * frame.c (make_initial_frame): Initialize faces in all cases, not
6087 only when CANNOT_DUMP is defined.
6088 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6089
c56e0fd5
DN
60902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6091
6092 * dispnew.c (add_window_display_history): Use const for the string
6093 pointer. Remove declaration, not needed.
6094
333d54da 60952011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6096
55d4c1b2 6097 Use 'inline', not 'INLINE'.
333d54da 6098 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6099 * alloc.c, fontset.c (INLINE): Remove.
6100 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6101 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6102 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6103 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6104 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6105
738db178
DN
61062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6107
6108 Make it possible to run ./temacs.
6109
6110 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6111 syms_of_callproc does the same thing. Remove test for
6112 "initialized", do it in the caller.
6113 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6114
620c53a6
SM
61152011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6116
6117 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6118 (read_minibuf): Use get_minibuffer.
6119 (syms_of_minibuf): Use DEFSYM.
6120 (Qmetadata): New var.
6121 * data.c (Qbuffer): Don't make it static.
6122 (syms_of_data): Use DEFSYM.
6123
e003a292
PE
61242011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6125
6126 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6127 (CCL_CODE_MIN): New macro.
6128
ed008a6d
PE
61292011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6130
3687c2ef
PE
6131 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6132
ed008a6d
PE
6133 * eval.c (Qdebug): Now static.
6134 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6135 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6136 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6137
d66c4c7c
CY
61382011-05-29 Chong Yidong <cyd@stupidchicken.com>
6139
6140 * image.c: Various fixes to ImageMagick code comments.
6141 (Fimagemagick_types): Doc fix.
6142
5fbc2025
PE
61432011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6144
0196f88a
PE
6145 Minor fixes prompted by GCC 4.6.0 warnings.
6146
6147 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6148
5fbc2025
PE
6149 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6150 (x_clipboard_manager_save_all): Move extern decl to ...
6151 * xterm.h: ... here, so that it can be checked for consistency.
6152
1dd3c2d9
CY
61532011-05-29 Chong Yidong <cyd@stupidchicken.com>
6154
6155 * xselect.c (x_clipboard_manager_save_frame)
6156 (x_clipboard_manager_save_all): New functions.
6157 (Fx_clipboard_manager_save): Lisp function deleted.
6158
6159 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6160 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6161
6162 * xterm.h: Update prototype.
6163
5ba6571d
WX
61642011-05-28 William Xu <william.xwl@gmail.com>
6165
6166 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6167 exiting (Bug#8239).
6168
3eaff834
JM
61692011-05-28 Jim Meyering <meyering@redhat.com>
6170
e1900994 6171 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6172 * fns.c (to_uchar): Define.
6173 (crypto_hash_function): Use it to convert some newly-signed
6174 variables to unsigned, to avoid sign-extension bugs. For example,
6175 without this change, (md5 "truc") would evaluate to
6176 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6177 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6178 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6179
0f6990a7
PE
61802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6181
6182 Integer overflow fixes.
c8a9ca5a 6183
08686060
PE
6184 * dbusbind.c: Serial number integer overflow fixes.
6185 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6186 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6187 to hold a serial number that is too large for a fixnum.
6188 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6189 Check for serial numbers out of range. Decode any serial number
59568bf0 6190 that was so large that it became a float. (Bug#8722)
08686060 6191
2d1fc3c7
PE
6192 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6193 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6194 Use XFASTINT rather than XUINT when numbers are nonnegative.
6195 (xd_append_arg, Fdbus_method_return_internal):
6196 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6197 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6198 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6199 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6200 (Bug#8722)
2d1fc3c7 6201
c8a9ca5a
PE
6202 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6203
519e1d69
PE
6204 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6205
6df6ae42 6206 ccl: Add integer overflow checks.
30569699
PE
6207 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6208 (IN_INT_RANGE): New macros.
6209 (ccl_driver): Use them to check for integer overflow when
6210 decoding a CCL program. Many of the new checks are whether XINT (x)
6211 fits in int; it doesn't always, on 64-bit hosts. The new version
6212 doesn't catch all possible integer overflows, but it's an
847044ea 6213 improvement. (Bug#8719)
30569699 6214
c11285dc
PE
6215 * alloc.c (make_event_array): Use XINT, not XUINT.
6216 There's no need for unsigned here.
6217
fdccd48e
PE
6218 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6219 This follows up to the 2011-05-06 change that substituted uintptr_t
6220 for EMACS_INT. This case wasn't caught back then.
6221
37910ab2
PE
6222 Rework Fformat to avoid integer overflow issues.
6223 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6224 now (part of C89). Include <verify.h>.
6225 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6226 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6227 (Fformat): Avoid the prepass trying to compute sizes; it was only
6228 approximate and thus did not catch overflow reliably. Instead, walk
6229 through the format just once, formatting and computing sizes as we go,
6230 checking for integer overflow at every step, and allocating a larger
6231 buffer as needed. Keep track separately whether the format is
6232 multibyte. Keep only the most-recently calculated precision, rather
6233 than them all. Record whether each argument has been converted to
6234 string. Use EMACS_INT, not int, for byte and char and arg counts.
6235 Support field widths and precisions larger than INT_MAX. Avoid
6236 sprintf's undefined behavior with conversion specifications such as %#d
6237 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6238 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6239 formatting out-of-range floating point numbers with int
9173deec 6240 formats. (Bug#8668)
37910ab2 6241
2e6578fb
PE
6242 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6243
0ae6bdee
PE
6244 * data.c: Avoid integer truncation in expressions involving floats.
6245 * data.c: Include <intprops.h>.
6246 (arith_driver): When there's an integer overflow in an expression
6247 involving floating point, convert the integers to floating point
6248 so that the resulting value does not suffer from catastrophic
6249 integer truncation. For example, on a 64-bit host (* 4
6250 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6251 Do not rely on undefined behavior after integer overflow.
6252
de883a70
PE
6253 merge count_size_as_multibyte, parse_str_to_multibyte
6254 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6255 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6256 Check for integer overflow.
6257 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6258 since it's now a duplicate of the other. This is more of
6259 a character than a buffer op, so better that it's in character.c.
6260 * fns.c, print.c: Adjust to above changes.
6261
2ff916cb
PE
62622011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6263
6264 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6265
f1b54466
PE
62662011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6267
fb1ac845
PE
6268 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6269 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6270 (x_clipboard_manager_save): Now static.
6271 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6272
f1b54466
PE
6273 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6274 (crypto_hash_function): Now static.
6275 Fix pointer signedness problems. Avoid unnecessary initializations.
6276
a9f737ee
CY
62772011-05-27 Chong Yidong <cyd@stupidchicken.com>
6278
6279 * termhooks.h (Vselection_alist): Make it terminal-local.
6280
6281 * terminal.c (create_terminal): Initialize it.
6282
6283 * xselect.c: Support for clipboard managers.
6284 (Vselection_alist): Move to termhooks.h as terminal-local var.
6285 (LOCAL_SELECTION): New macro.
6286 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6287 (symbol_to_x_atom): Remove gratuitous arg.
6288 (x_handle_selection_request, lisp_data_to_selection_data)
6289 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6290 (x_own_selection, x_get_local_selection, x_convert_selection):
6291 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6292 (some_frame_on_display): Delete unused function.
6293 (Fx_own_selection_internal, Fx_get_selection_internal)
6294 (Fx_disown_selection_internal, Fx_selection_owner_p)
6295 (Fx_selection_exists_p): New optional frame arg.
6296 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6297 (x_handle_selection_clear): Don't treat other terminals with the
6298 same keyboard specially. Use the terminal-local Vselection_alist.
6299 (x_clear_frame_selections): Use Frun_hook_with_args.
6300
6301 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6302
6303 * xterm.h: Add support for those atoms.
6304
e067f0c1
CY
63052011-05-26 Chong Yidong <cyd@stupidchicken.com>
6306
6307 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6308 (converted_selections, conversion_fail_tag): New global variables.
6309 (x_selection_request_lisp_error): Free the above.
6310 (x_get_local_selection): Remove unnecessary code.
6311 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6312 of converted selections stored in converted_selections.
6313 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6314 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6315 (x_convert_selection): New function.
6316 (x_handle_selection_event): Simplify.
6317 (x_get_foreign_selection): Don't ignore incoming requests while
6318 waiting for an answer; this will fail when we implement
6319 SAVE_TARGETS, and seems unnecessary anyway.
6320 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6321 (Vx_sent_selection_functions): Doc fix.
6322
0f4aebc0
LL
63232011-05-26 Leo Liu <sdl.web@gmail.com>
6324
6325 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6326
e61124cd
YM
63272011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6328
6329 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6330
6331 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6332 for fringe update if it has periodic bitmap.
ac389d0c 6333 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6334 and fringe_bitmap_periodic_p.
6335
6336 * fringe.c (get_fringe_bitmap_data): New function.
6337 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6338 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6339 row. Mark glyph row for fringe update if periodicity changed.
6340
6341 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6342 for fringe update unless it has periodic bitmap.
6343
f16d9837
KH
63442011-05-25 Kenichi Handa <handa@m17n.org>
6345
6346 * xdisp.c (get_next_display_element): Set correct it->face_id for
6347 a static composition.
6348
e1b90ef6
LL
63492011-05-24 Leo Liu <sdl.web@gmail.com>
6350
6351 * deps.mk (fns.o):
6352 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6353
6354 * fns.c (crypto_hash_function, Fsha1): New function.
6355 (Fmd5): Use crypto_hash_function.
6356 (syms_of_fns): Add Ssha1.
6357
7400048f
PE
63582011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6359
6360 * gnutls.c: Remove unused macros.
6361 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6362 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6363 Remove macros that are defined and never used.
6364 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6365
abb71cf4
CY
63662011-05-22 Chong Yidong <cyd@stupidchicken.com>
6367
6368 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6369 (Fx_get_selection_internal): Minor cleanup.
6370 (Fx_own_selection_internal): Rename arguments for consistency with
6371 select.el.
6372
6307db39
PE
63732011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6374
6375 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6376
f3d4e0a4
CY
63772011-05-22 Chong Yidong <cyd@stupidchicken.com>
6378
6379 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6380
4d8ade89
YM
63812011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6382
6383 * dispnew.c (scrolling_window): Don't exclude the case that the
6384 last enabled row in the desired matrix touches the bottom boundary.
6385
32078c8d
GM
63862011-05-21 Glenn Morris <rgm@gnu.org>
6387
6388 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6389 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6390 and add some more files.
32078c8d 6391
7285dc67
EZ
63922011-05-20 Eli Zaretskii <eliz@gnu.org>
6393
6394 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6395 report_file_error introduced by the change from 2011-05-07.
6396
89d1bd22
PE
63972011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6398
6399 * systime.h (Time): Define only if emacs is defined.
6400 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6401 where the include path doesn't have X11/X.h by default. See
6402 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6403
cd394be1 64042011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6405
6406 * composite.c (find_automatic_composition): Fix previous change.
6407
b9704ad9
GM
64082011-05-20 Glenn Morris <rgm@gnu.org>
6409
6410 * lisp.mk: New file, split from Makefile.in.
6411 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6412 (shortlisp): Remove.
6413 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6414
4a720484
GM
64152011-05-19 Glenn Morris <rgm@gnu.org>
6416
6417 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6418 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6419 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6420 (lisp): Set the order to that of loadup.el.
6421 (shortlisp): Make it a copy of $lisp.
6422 (SOME_MACHINE_LISP): Remove.
6423 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6424 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6425
a28d4396
KH
64262011-05-18 Kenichi Handa <handa@m17n.org>
6427
6428 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6429 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6430 (find_automatic_composition): Mostly rewrite for efficiency.
6431
a2b1fa8e
JB
64322011-05-18 Juanma Barranquero <lekktu@gmail.com>
6433
6434 * makefile.w32-in: Update dependencies.
6435
8e1f5610
CS
64362011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6437
6438 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6439 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6440
7025ee00 64412011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6442
cdfa6eab
PE
6443 Fix some integer overflow issues, such as string length overflow.
6444
06d6db33
PE
6445 * insdel.c (count_size_as_multibyte): Check for string overflow.
6446
2b4560a8
PE
6447 * character.c (lisp_string_width): Check for string overflow.
6448 Use EMACS_INT, not int, for string indexes and lengths; in
6449 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6450 the resulting string length overflows an EMACS_INT; instead,
6451 report a string overflow if no precision given. When checking for
6452 precision exhaustion, use a check that cannot possibly have
6453 integer overflow. (Bug#8675)
6454 * character.h (lisp_string_width): Adjust to new signature.
6455
cb93f9be
PE
6456 * alloc.c (string_overflow): New function.
6457 (Fmake_string): Use it. This doesn't change behavior, but saves
6458 a few bytes and will simplify future changes.
6459 * character.c (string_escape_byte8): Likewise.
6460 * lisp.h (string_overflow): New decl.
6461
1a1f3366
PE
6462 Fixups, following up to the user-interface timestamp change.
6463 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6464 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6465 * msdos.c (mouse_get_pos): Likewise.
6466 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6467 * w32gui.h (Time): Define by including "systime.h" rather than by
6468 declaring it ourselves. (Bug#8664)
6469
d4e3e4d3
PE
6470 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6471 * image.c (clear_image_cache): Likewise.
6472
f6a24d19
PE
6473 * term.c (term_mouse_position): Don't assume time_t wraparound.
6474
08dc5ae6
PE
6475 Be more systematic about user-interface timestamps.
6476 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6477 and sometimes 'EMACS_UINT', to represent these timestamps.
6478 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6479 This makes the code easier to follow, and makes it easier to catch
6480 integer overflow bugs such as Bug#8664.
6481 * frame.c (Fmouse_position, Fmouse_pixel_position):
6482 Use Time, not unsigned long, for user-interface timestamps.
6483 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6484 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6485 * keyboard.h (last_event_timestamp): Likewise.
6486 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6487 * menu.h (xmenu_show): Likewise.
6488 * term.c (term_mouse_position): Likewise.
6489 * termhooks.h (struct input_event.timestamp): Likewise.
6490 (struct terminal.mouse_position_hook): Likewise.
6491 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6492 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6493 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6494 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6495 what it was before.
6496 * menu.h, termhooks.h: Include "systime.h", for Time.
6497
8e55734a
PE
6498 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6499 Don't assume that the difference between two unsigned long values
6500 can fit into an integer. At this point, we know button_down_time
6501 <= event->timestamp, so the difference must be nonnegative, so
6502 there's no need to cast the result if double-click-time is
6503 nonnegative, as it should be; check that it's nonnegative, just in
6504 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6505 apart (about 25 days). (Bug#8664)
8e55734a 6506
841f1b75 6507 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6508 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6509
3e26f69c
PE
6510 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6511 that always fit in int. Use a sentinel instead of a counter, to
6512 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6513 * frame.h (struct frame): Use int for menu_bar_items_used
6514 instead of EMACS_INT, since it always fits in int.
3e26f69c 6515
5cc152c0
PE
6516 * menu.c (grow_menu_items): Check for int overflow.
6517
d89eb65e
PE
6518 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6519
5235bd3e
PE
6520 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6521 Before, the code was not consistent. These values cannot exceed
6522 2**31 - 1 so there's no need to make them unsigned.
6523 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6524 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6525 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6526 as modifiers.
6527 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6528
bc827e23
PE
6529 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6530 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6531 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6532 presumably because the widths might not match.
6533
78eb494e
PE
6534 * window.c (size_window): Avoid needless test at loop start.
6535
04f2d78b
CB
65362011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6537
6538 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6539
d2fc7e3d 65402011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6541
6542 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6543
d2fc7e3d 65442011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6545
6546 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6547 `width' to `bar_area_x' and `bar_area_width', respectively.
6548 (x_scroll_run): Take account of fringe background extension.
6549
04f2d78b
CB
6550 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6551 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6552 `bar_area_width', respectively.
6553 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6554 background extension.
6555
79b70037
GM
65562011-05-10 Jim Meyering <meyering@redhat.com>
6557
6558 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6559
2f142cc5
JB
65602011-05-10 Juanma Barranquero <lekktu@gmail.com>
6561
6562 * image.c (Finit_image_library): Return t for built-in image types,
6563 like pbm and xbm. (Bug#8640)
6564
57679c86
AS
65652011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6566
6567 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6568
888c9e86
EZ
65692011-05-07 Eli Zaretskii <eliz@gnu.org>
6570
b0512a1d
EZ
6571 * w32console.c (Fset_screen_color): Doc fix.
6572 (Fget_screen_color): New function.
6573 (syms_of_ntterm): Defsubr it.
6574
7285dc67
EZ
6575 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6576 unlink the temporary file if Fcall_process didn't create it in the
6577 first place.
6578 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6579 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6580 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6581 cue to call_process_cleanup not to close that handle.
6582
4d3fcc8e
BK
65832011-05-07 Ben Key <bkey76@gmail.com>
6584
6585 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6586 one of two shell specific rules, either bootstrap-temacs-CMD or
6587 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6588 to the previous implementation of the bootstrap-temacs rule.
6589 The bootstrap-temacs-CMD rule is similar to the previous
6590 implementation of the bootstrap-temacs rule except that it
6591 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6592 variable.
6593
6594 These changes, along with some changes to nt/configure.bat,
6595 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6596 earlier fix to add support for --cflags and --ldflags options
6597 that include quotes so that it works whether make uses cmd or
6598 sh as the shell.
6599
b4289b64
MA
66002011-05-06 Michael Albinus <michael.albinus@gmx.de>
6601
6602 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6603 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6604 is a constant.
6605 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6606 a string. Handle both cases.
6607 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6608 (Fdbus_register_method): Use Qinvalid_function.
6609
af4c0e28
JB
66102011-05-06 Juanma Barranquero <lekktu@gmail.com>
6611
6612 * makefile.w32-in: Update dependencies.
6613 (LISP_H): Add inttypes.h and stdin.h.
6614 (PROCESS_H): Add unistd.h.
6615
c51453d9
EZ
66162011-05-06 Eli Zaretskii <eliz@gnu.org>
6617
6618 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6619 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6620
8ff0ac3c 66212011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6622
4c4b566b
PE
6623 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6624
aab2b9b5
PE
6625 * term.c (vfatal): Remove stray call to va_end.
6626 It's not needed and the C Standard doesn't allow it here anyway.
6627
c378da0b
PE
6628 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6629 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6630
288b08c7
PE
6631 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6632 bytes.
6633
e3601888
PE
6634 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6635
db6c0e74
PE
6636 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6637
dd5963ea
PE
6638 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6639
88c9450f
PE
6640 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6641
2f9442b8
PE
6642 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6643
c032b5f8
PE
6644 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6645 * charset.c (Fdefine_charset_internal): Don't initialize
6646 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6647 32-bit int (Bug#8600).
a108c10b
PE
6648
6649 * lread.c (read_integer): Be more consistent with string-to-number.
6650 Use string_to_number to do the actual conversion; this avoids
6651 rounding errors and fixes some other screwups. Without this fix,
6652 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6653 (digit_to_number): Move earlier, for benefit of read_integer.
6654 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6655 not a digit in any supported base. (Bug#8602)
a108c10b 6656
ad5f9eea
PE
6657 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6658
aec1708a
PE
6659 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6660 to match comment at start of function. This also removes a
6661 GCC warning about overflow in a 32+64-bit port.
6662
47be4ab5
PE
6663 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6664
371cac43
PE
6665 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6666 Reported by Stefan Monnier in
6667 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6668 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6669 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6670
d01a7826
PE
6671 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6672 (EMACS_UINTPTR): Likewise, with uintptr_t.
6673
7fd47d5c
PE
6674 * lisp.h: Prefer 64-bit EMACS_INT if available.
6675 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6676 on 32-bit hosts that have 64-bit int, so that they can access
6677 large files.
122b0c86
PE
6678 However, temporarily disable this change unless the temporary
6679 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6680
8727937b
PE
6681 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6682
8ac068ac
PE
6683 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6684 This removes an assumption that EMACS_INT and long are the same
6685 width as pointers. The assumption is true for Emacs porting targets
6686 now, but we want to make other targets possible.
6687 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6688 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6689 In the rest of the code, change types of integers that hold casted
6690 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6691 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6692 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6693 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6694 No need to cast type when ORing.
6695 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6696 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6697 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6698 assume EMACS_INT is the same width as char *.
6699 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6700 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6701 Remove no-longer-needed casts.
6702 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6703 (xg_tool_bar_help_callback, xg_make_tool_item):
6704 Use EMACS_INTPTR to hold an integer
6705 that will be cast to void *; this can avoid a GCC warning
6706 if EMACS_INT is not the same width as void *.
6707 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6708 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6709 (current_message_1, set_message_1):
6710 Use a local to convert to proper width without a cast.
6711 * xmenu.c (dialog_selection_callback): Likewise.
6712
ede49d71
PE
6713 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6714 Also, don't assume VALBITS / RAND_BITS is less than 5,
6715 and don't rely on undefined behavior when shifting a 1 left into
6716 the sign bit.
6717 * lisp.h (get_random): Change signature to match.
6718
2f30ecd0
PE
6719 * lread.c (hash_string): Use size_t, not int, for hash computation.
6720 Normally we prefer signed values; but hashing is special, because
6721 it's better to use unsigned division on hash table sizes so that
6722 the remainder is nonnegative. Also, size_t is the natural width
6723 for hashing into memory. The previous code used 'int', which doesn't
6724 retain enough info to hash well into very large tables.
6725 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6726
2a866e7b
PE
6727 * dbusbind.c: Don't possibly lose pointer info when converting.
6728 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6729 Use XPNTR rather than XHASH, so that the high-order bits of
6730 the pointer aren't lost when converting through void *.
6731
51639eac
PE
6732 * eval.c (Fautoload): Don't double-shift a pointer.
6733
92394119
PE
6734 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6735
dbdb9a7c
JB
67362011-05-06 Juanma Barranquero <lekktu@gmail.com>
6737
6738 * gnutls.c (DEF_GNUTLS_FN):
6739 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6740
db7a0b4f
AS
67412011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6742
6743 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6744 marker. (Bug#8610)
6745
cd394be1 67462011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6747
6748 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6749 New version that can reserve upto 2GB of heap space.
6750
f7ff1b0f 67512011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6752
6753 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6754
639c109b
TZ
67552011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6756
6757 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6758 `gnutls_certificate_set_x509_key_file'.
6759
d2127135
JB
67602011-05-05 Juanma Barranquero <lekktu@gmail.com>
6761
6762 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6763 Update dependencies.
6764
e968f4f3
JB
67652011-05-04 Juanma Barranquero <lekktu@gmail.com>
6766
6767 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6768 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6769 Remove unused parameter `fildes'.
6770 * process.c (read_process_output, send_process): Don't pass it.
6771
84d358f0
JB
67722011-05-04 Juanma Barranquero <lekktu@gmail.com>
6773
6774 Fix previous change: the library cache is defined in w32.c.
6775 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6776 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6777
0898ca10
JB
67782011-05-04 Juanma Barranquero <lekktu@gmail.com>
6779
6780 Implement dynamic loading of GnuTLS on Windows.
6781
6782 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6783 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6784 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6785 Declare.
6786
6787 * gnutls.c (Qgnutls_dll): Define.
6788 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6789 (gnutls_*): Declare function pointers.
6790 (init_gnutls_functions): New function to initialize function pointers.
6791 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6792 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6793 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6794 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6795 (emacs_gnutls_write, emacs_gnutls_read)
6796 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6797 (Fgnutls_available_p): New function.
6798 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6799 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6800 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6801
6802 * image.c: Include w32.h.
6803 (Vimage_type_cache): Delete.
6804 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6805 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6806 (w32_delayed_load): Move to w32.c.
6807
6808 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6809
6810 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6811 (w32_delayed_load): Move from image.c. When loading a library, record
6812 its filename in the :loaded-from property of the library id.
6813 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6814 Initialize and staticpro them.
6815 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6816
6817 * process.c: Include lisp.h before w32.h, not after.
6818 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6819 instead of gnutls_record_check_pending.
6820
6821 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6822
ff4de4aa
TZ
68232011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6824
6825 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6826 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6827 as passed in.
6828
abe95abb
JD
68292011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6830
6831 * xterm.c (x_set_frame_alpha): Do not set property on anything
6832 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6833
e16e55d4
JB
68342011-05-02 Juanma Barranquero <lekktu@gmail.com>
6835
6836 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6837
bafcf6a5
JB
68382011-05-02 Juanma Barranquero <lekktu@gmail.com>
6839
6840 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6841 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6842 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6843 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6844 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6845 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6846 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6847 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6848 (Qgnutls_bootprop_callbacks_verify): Make static.
6849
e7a6747f
AS
68502011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6851
19ed11ba
AS
6852 * callproc.c: Indentation fixup.
6853
e7a6747f 6854 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6855 (wait_for_termination, interruptible_wait_for_termination):
6856 Move after wait_for_termination_1.
e7a6747f 6857
1ef14cb4
LMI
68582011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6859
6860 * sysdep.c (interruptible_wait_for_termination): New function
6861 which is like wait_for_termination, but allows keyboard
6862 interruptions.
6863
6864 * callproc.c (Fcall_process): Add (:file "file") as an option for
6865 the STDOUT buffer.
6866 (Fcall_process_region): Ditto.
6867
330d880c
EZ
68682011-04-30 Eli Zaretskii <eliz@gnu.org>
6869
8db90b73
EZ
6870 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6871 rather than `XVECTOR (FOO)->size'.
6872
330d880c
EZ
6873 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6874 inttypes.h, as a gnulib replacement is used if it not available in
6875 system headers.
6876
15cbd324
EZ
68772011-04-21 Eli Zaretskii <eliz@gnu.org>
6878
6879 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6880 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6881 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6882
6883 * coding.c (coding_alloc_by_realloc): Error out if destination
6884 will grow beyond MOST_POSITIVE_FIXNUM.
6885 (decode_coding_emacs_mule): Abort if there isn't enough place in
6886 charbuf for the composition carryover bytes. Reserve an extra
6887 space for up to 2 characters produced in a loop.
6888 (decode_coding_iso_2022): Abort if there isn't enough place in
6889 charbuf for the composition carryover bytes.
6890
68912011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6892
ae940cca
EZ
6893 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6894 aborting when %lld or %lll format is passed.
6895 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6896 %llo or %llx format is passed. (Bug#8545)
6897
03ab8921
EZ
6898 * window.c (window_scroll_line_based): Use a marker instead of
6899 simple variables to record original value of point. (Bug#7952)
6900
afda1437
EZ
6901 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6902 produced by %s or %c overflows available buffer space. (Bug#8545)
6903
f76dee0c
PE
69042011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6905
6906 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6907 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6908
fdc5744d
JB
69092011-04-28 Juanma Barranquero <lekktu@gmail.com>
6910
6911 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6912
638f053a
JB
69132011-04-28 Juanma Barranquero <lekktu@gmail.com>
6914
6915 * keyboard.c (Qdelayed_warnings_hook): Define.
6916 (command_loop_1): Run `delayed-warnings-hook'
6917 if Vdelayed_warnings_list is non-nil.
6918 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6919 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6920
d178f871
EZ
69212011-04-28 Eli Zaretskii <eliz@gnu.org>
6922
6923 * doprnt.c (doprnt): Don't return value smaller than the buffer
6924 size if the message was truncated. (Bug#8545).
6925
b124fd93
JB
69262011-04-28 Juanma Barranquero <lekktu@gmail.com>
6927
6928 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6929 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6930
e810457d
PE
69312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6932
6933 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6934
ea51cceb
JB
69352011-04-27 Juanma Barranquero <lekktu@gmail.com>
6936
6937 * makefile.w32-in: Update dependencies.
6938
94dcfacf
EZ
69392011-04-27 Eli Zaretskii <eliz@gnu.org>
6940
6941 Improve `doprnt' and its usage. (Bug#8545)
6942 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6943 `format_end'. Remove support for %l as a conversion specifier.
6944 Don't use xrealloc. Improve diagnostics when the %l size modifier
6945 is used. Update the commentary.
6946
6947 * eval.c (verror): Simplify calculation of size_t.
6948
6949 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6950 messages.
6951
f61f41d7
PE
69522011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6953
6954 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6955 change.
6956
96fb4434
PE
69572011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6958
6959 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6960 This makes this file independent of the recent pseudovector change.
6961
671875da 69622011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6963
69e9b5a3
PE
6964 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6965
b5f869a7 6966 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6967 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6968 Remove unused local.
c8926152 6969 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6970
841a1577 6971 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6972 GCC 4.6.0 optimizes based on type-based alias analysis.
6973 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6974 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6975 != &v->size, and therefore "v->size = 1; b->size = 2; return
6976 v->size;" must therefore return 1. This assumption is incorrect
6977 for Emacs, since it type-puns struct Lisp_Vector * with many other
6978 types. To fix this problem, this patch adds a new type struct
f904488f 6979 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6980 and pseudovectors, and helps optimizing compilers not get fooled
6981 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6982 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6983 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6984 the size member.
eab3844f
PE
6985 (XSETPVECTYPE): Rewrite in terms of new macro.
6986 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6987 This is a bit clearer, and further avoids the possibility of
6988 undesirable aliasing.
6989 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6990 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6991 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6992 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6993 (ASIZE): Now uses header.size rather than size.
6994 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6995 to avoid the hassle of writing XVECTOR (foo)->header.size.
6996 (struct vectorlike_header): New type.
eab3844f
PE
6997 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6998 object, to help avoid aliasing.
6999 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7000 (SUBRP): Likewise, since Lisp_Subr is a special case.
7001 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7002 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7003 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7004 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7005 changed to be "header.size" and "header.next".
7006 * buffer.h (struct buffer): Likewise.
7007 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7008 * frame.h (struct frame): Likewise.
7009 * process.h (struct Lisp_Process): Likewise.
7010 * termhooks.h (struct terminal): Likewise.
7011 * window.c (struct save_window_data, struct saved_window): Likewise.
7012 * window.h (struct window): Likewise.
7013 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7014 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7015 * buffer.c (init_buffer_once): Likewise.
7016 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7017 special case.
7018 * process.c (Fformat_network_address): Use local var for size,
7019 for brevity.
7020
0df1eac5
PE
7021 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7022
847ab9d1 7023 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7024 * data.c (atof): Remove decl; no longer used or needed.
7025 (digit_to_number): Move to lread.c.
7026 (Fstring_to_number): Use new string_to_number function, to be
7027 consistent with how the Lisp reader treats infinities and NaNs.
7028 Do not assume that floating-point numbers represent EMACS_INT
7029 without losing information; this is not true on most 64-bit hosts.
7030 Avoid double-rounding errors, by insisting on integers when
7031 parsing non-base-10 numbers, as the documentation specifies.
7032 * lisp.h (string_to_number): New decl, replacing ...
7033 (isfloat_string): Remove.
bc0a5c13 7034 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7035 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7036 appears to have been a coding error. Similarly, do not accept
7037 strings like +-1e0 as floating point numbers. Do not report
7038 overflow for integer overflows unless the base is not 10 which
7039 means we have no simple and reliable way to continue.
7040 Break out the floating-point parsing into a new
7041 function string_to_number, so that Fstring_to_number parses
7042 floating point numbers consistently with the Lisp reader.
04f2d78b 7043 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7044 (E_CHAR, EXP_INT): Remove, replacing with ...
7045 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7046 (string_to_number): New function, replacing isfloat_string.
7047 This function checks for valid syntax and produces the resulting
7048 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7049 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7050 so that overflow for non-base-10 numbers is reported only when
7051 there's no portable and simple way to convert to floating point.
452f4150 7052
67769ffc
PE
7053 * textprop.c (set_text_properties_1): Rewrite for clarity,
7054 and to avoid GCC warning about integer overflow.
7055
c20db43f
PE
7056 * intervals.h (struct interval): Use EMACS_INT for members
7057 where EMACS_UINT might cause problems. See
7058 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7059 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7060 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7061 All uses changed.
37aa2f85
PE
7062 (offset_intervals): Tell GCC not to worry about length overflow
7063 when negating a negative length.
c20db43f 7064
2538aa2f
PE
7065 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7066 (overrun_check_free): Likewise.
7067
f2d3008d
PE
7068 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7069 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7070 word size.
7071
ec8df744
PE
7072 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7073 (gnutls_make_error): Rename local to avoid shadowing.
7074 (gnutls_emacs_global_deinit): ifdef out; not used.
7075 (Fgnutls_boot): Use const for pointer to readonly storage.
7076 Comment out unused local. Fix pointer signedness problems.
7077
640ee02d
PE
7078 * lread.c (openp): Don't stuff size_t into an 'int'.
7079 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7080 about possible signed overflow.
7081
6048fb2a
PE
7082 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7083 (GDK_KEY_g): Don't define if already defined.
7084 (xg_prepare_tooltip): Avoid pointer signedness problem.
7085 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7086
fa3c87e1
PE
7087 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7088 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7089
2172544b
PE
7090 * xfns.c (Fx_window_property): Simplify a bit,
7091 to make a bit faster and to avoid GCC 4.6.0 warning.
7092 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7093
9b821a21
PE
7094 * fns.c (internal_equal): Don't assume size_t fits in int.
7095
3c616cfa
PE
7096 * alloc.c (compact_small_strings): Tighten assertion a little.
7097
c2982e87
PE
7098 Replace pEd with more-general pI, and fix some printf arg casts.
7099 * lisp.h (pI): New macro, generalizing old pEd macro to other
7100 conversion specifiers. For example, use "...%"pI"d..." rather
7101 than "...%"pEd"...".
7102 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7103 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7104 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7105 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7106 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7107 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7108 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7109 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7110 64-bit hosts.
7111 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7112 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7113 * print.c (safe_debug_print, print_object): Likewise.
7114 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7115 to int.
6f04d126
PE
7116 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7117 avoiding the 0 flag, which is not portable.
c2982e87
PE
7118 * process.c (Fmake_network_process): Use pI to avoid cast.
7119 * region-cache.c (pp_cache): Likewise.
7120 * xdisp.c (decode_mode_spec): Likewise.
7121 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7122 behavior on 64-bit hosts with printf arg.
6f04d126 7123 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7124 (x_stop_queuing_selection_requests): Likewise.
7125 (x_get_window_property): Don't truncate byte count to an 'int'
7126 when tracing.
0b432f21 7127
5e073ec7
PE
7128 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7129 here, since it parses constructs like leading '-' and spaces,
7130 which are not wanted; and it overflows with large numbers.
7131 Instead, simply match F[0-9]+, which is what is wanted anyway.
7132
36372bf9
PE
7133 * alloc.c: Remove unportable assumptions about struct layout.
7134 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7135 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7136 (allocate_vectorlike, make_pure_vector): Use the new macros,
7137 plus offsetof, to remove unportable assumptions about struct layout.
7138 These assumptions hold on all porting targets that I know of, but
7139 they are not guaranteed, they're easy to remove, and removing them
7140 makes further changes easier.
7141
0b432f21
PE
7142 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7143 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7144 (string_overrun_cookie): Now const. Use initializers that
7145 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7146 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7147 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7148 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7149 multiple of sizeof (EMACS_INT); it need not be, if
7150 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7151 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7152
895009e1
JB
71532011-04-26 Juanma Barranquero <lekktu@gmail.com>
7154
7155 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7156
6a7a1b0b
TZ
71572011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7158
7159 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7160 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7161 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7162
841a1577 71632011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7164
7165 * lisp.h (Qdebug): List symbol.
895009e1 7166 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7167 * keyboard.c (debug-on-event): New variable.
7168 (handle_user_signal): Break into debugger when debug-on-event
7169 matches the current signal symbol.
7170
f2d3ba6f
DN
71712011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7172
7173 * alloc.c (check_sblock, check_string_bytes)
7174 (check_string_free_list): Convert to standard C.
7175
42ce4c63
TZ
71762011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7177
7178 * w32.c (emacs_gnutls_push): Fix typo.
7179
825cd63c
EZ
71802011-04-25 Eli Zaretskii <eliz@gnu.org>
7181
fb11d64d
EZ
7182 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7183 "cast to pointer from integer of different size".
7184
825cd63c
EZ
7185 Improve doprnt and its use in verror. (Bug#8545)
7186 * doprnt.c (doprnt): Document the set of format control sequences
7187 supported by the function. Use SAFE_ALLOCA instead of always
7188 using `alloca'.
7189
7190 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7191 is one byte too soon. Don't use xrealloc; instead xfree and
7192 xmalloc anew.
7193
e061a11b
TZ
71942011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7195
7196 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7197 callbacks stage.
7198
7199 * gnutls.c: Renamed global_initialized to
7200 gnutls_global_initialized. Added internals for the
7201 :verify-hostname-error, :verify-error, and :verify-flags
7202 parameters of `gnutls-boot' and documented those parameters in the
7203 docstring. Start callback support.
9173deec
JB
7204 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7205 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7206 on error. Return error code.
e061a11b
TZ
7207 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7208 (emacs_gnutls_read): Likewise.
7209 (Fgnutls_boot): Return handshake error code.
7210 (emacs_gnutls_handle_error): New function.
7211 (wsaerror_to_errno): Likewise.
7212
7213 * w32.h (emacs_gnutls_pull): Add prototype.
7214 (emacs_gnutls_push): Likewise.
7215
7216 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7217 (emacs_gnutls_push): Likewise.
7218
72192011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7220
7221 * process.c (wait_reading_process_output): Check if GnuTLS
7222 buffered some data internally if no FDs are set for TLS
7223 connections.
7224
7225 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7226 (LIBS): Link to USER_LIBS.
7227 ($(BLD)/gnutls.$(0)): New target.
7228
fa6996bc
EZ
72292011-04-24 Eli Zaretskii <eliz@gnu.org>
7230
eb35682e
EZ
7231 * xdisp.c (handle_single_display_spec): Rename the
7232 display_replaced_before_p argument into display_replaced_p, to
7233 make it consistent with the commentary. Fix typos in the
7234 commentary.
7235
e2ad650c
EZ
7236 * textprop.c (syms_of_textprop): Remove dead code.
7237 (copy_text_properties): Delete obsolete commentary about an
7238 interface that was deleted long ago. Fix typos in the description
7239 of arguments.
7240
1b2de274
EZ
7241 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7242 to changes in oldXMenu/XMenu.h from 2011-04-16.
7243 <menu_help_message, prev_menu_help_message>: Constify.
7244 (IT_menu_make_room): menu->help_text is now `const char **';
7245 adjust.
7246
7247 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7248 to changes in oldXMenu/XMenu.h from 2011-04-16.
7249 (struct XMenu): Declare `help_text' `const char **'.
7250
7251 * xfaces.c <Qunspecified>: Make extern again.
7252
7253 * syntax.c: Include sys/types.h before including regex.h, as
7254 required by Posix.
7255
762b15be
EZ
7256 * doc.c (get_doc_string): Improve the format passed to `error'.
7257
7258 * doprnt.c (doprnt): Improve commentary.
7259
7260 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7261
7262 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7263 them with etags.
7264
f1052e5d
EZ
7265 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7266 changes in globals.h immediately force recompilation.
762b15be
EZ
7267 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7268 $(CURDIR)/s/ms-w32.h.
7269 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7270
fa6996bc
EZ
7271 * character.c (Fchar_direction): Function deleted.
7272 (syms_of_character): Don't defsubr it.
7273 <char-direction-table>: Deleted.
7274
e6c3da20
EZ
72752011-04-23 Eli Zaretskii <eliz@gnu.org>
7276
7277 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7278 * doprnt.c: Include limits.h.
7279 (SIZE_MAX): New macro.
04f2d78b
CB
7280 (doprnt): Return a size_t value. 2nd arg is now size_t.
7281 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7282 Improve overflow protection. Support `l' modifier for integer
7283 conversions. Support %l conversion. Don't assume an EMACS_INT
7284 argument for integer conversions and for %c.
7285
7286 * lisp.h (doprnt): Restore prototype.
7287
7288 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7289 $(SRC)/character.h.
7290
7291 * Makefile.in (base_obj): Add back doprnt.o.
7292
7293 * deps.mk (doprnt.o): Add back prerequisites.
7294 (callint.o): Depend on character.h.
7295
7296 * eval.c (internal_lisp_condition_case): Include the handler
7297 representation in the error message.
7298 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7299 when breaking from the loop.
7300
7301 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7302
7303 * callint.c (Fcall_interactively): When displaying error message
7304 about invalid control letter, pass the character's codepoint, not
7305 a pointer to its multibyte form. Improve display of the character
7306 in octal and display also its hex code.
7307
7308 * character.c (char_string): Use %x to display the (unsigned)
7309 codepoint of an invalid character, to avoid displaying a bogus
7310 negative value.
7311
7312 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7313 `error', not SYMBOL_NAME itself.
7314
7315 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7316 character arguments to `error'.
7317
7318 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7319 to `error' in error message about FINAL_CHAR argument. Make sure
7320 FINAL_CHAR is a character, and use %c when it is passed as
7321 argument to `error'.
7322
4ffd0d6b 73232011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7324
7325 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7326
7327 * w32.c: Include <time.h>.
7328 (sys_localtime): New function.
7329
4ffd0d6b 73302011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7331
7332 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7333
4ffd0d6b 7334 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7335
4ffd0d6b 73362011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7337
4ffd0d6b
GM
7338 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7339 zombies (Bug#8467).
aac0c6e3 7340
04c56954
EZ
73412011-04-19 Eli Zaretskii <eliz@gnu.org>
7342
7343 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7344 gl_state.e_property when gl_state.object is Qt.
7345
7346 * insdel.c (make_gap_larger): Remove limitation of buffer size
7347 to <= INT_MAX.
7348
16a43933
CY
73492011-04-18 Chong Yidong <cyd@stupidchicken.com>
7350
7351 * xdisp.c (lookup_glyphless_char_display)
7352 (produce_glyphless_glyph): Handle cons cell entry in
7353 glyphless-char-display.
7354 (Vglyphless_char_display): Document it.
7355
7356 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7357 glyphless-char-display.
7358
4581706e
CY
73592011-04-17 Chong Yidong <cyd@stupidchicken.com>
7360
7361 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7362
7363 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7364
7365 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7366 definition for no-X builds.
7367
4887c6e2 73682011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7369
fd35b6f9
PE
7370 Static checks with GCC 4.6.0 and non-default toolkits.
7371
5c1ccb01
PE
7372 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7373
006c5daa
PE
7374 * process.c (keyboard_bit_set): Define only if SIGIO.
7375 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7376 (send_process): Repair possible setjmp clobbering.
7377
efc736d3
PE
7378 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7379
4e2fe2e6
PE
7380 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7381
f97334a2
PE
7382 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7383
4e75f29d
PE
7384 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7385 Define only if needed.
7386
90efadd1
PE
7387 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7388 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7389 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7390
3c647824
PE
7391 * dispextern.h (struct redisplay_interface): Rename param
7392 to avoid shadowing.
e264f262 7393 * termhooks.h (struct terminal): Likewise.
761383f4 7394 * xterm.c (xembed_send_message): Likewise.
3c647824 7395
b58c5c4a
PE
7396 * insdel.c (make_gap_smaller): Define only if
7397 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7398
cad59032
PE
7399 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7400 it.
7401
c339dc2e
PE
7402 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7403 so that we aren't warned about unused symbols.
7404
91a3e27b
PE
7405 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7406
399c71d3 7407 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7408
8ffc96f5
PE
7409 * xfns.c (x_real_positions): Mark locals as initialized.
7410
eef9bc79
PE
7411 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7412
098db9dd
PE
7413 * xterm.c: Fix problems found by static analysis with other toolkits.
7414 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7415 (x_dispatch_event): Declare static if USE_GTK, and
7416 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7417 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7418 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7419 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7420 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7421
eb18f6cc
PE
7422 * xmenu.c (menu_help_callback): Pointer type fixes.
7423 Use const pointers when pointing at readonly data. Avoid pointer
7424 signedness clashes.
7425 (FALSE): Remove unused macro.
7426 (update_frame_menubar): Remove unused decl.
7427
1fe72bf8
PE
7428 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7429
60d9e1db
PE
7430 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7431 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7432 (single_menu_item): Rename local to avoid shadowing.
7433
39261c26
PE
7434 * keyboard.c (make_lispy_event): Remove unused local var.
7435
018c5e19
PE
7436 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7437 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7438
63d2b86e
PE
7439 * bitmaps: Change bitmaps from unsigned char back to the X11
7440 compatible char. Avoid the old compiler warnings about
7441 out-of-range initializers by using, for example, '\xab' rather
7442 than 0xab.
7443
aefd87e1
PE
7444 * xgselect.c (xgselect_initialize): Check vs interface
7445 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7446
bf501fb9
PE
7447 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7448
e9829fdf
PE
7449 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7450 to read-only memory.
7451
1086c095
PE
7452 * fns.c (vector): Remove; this old hack is no longer needed.
7453
2baccd04 7454 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7455 Remove unused var.
dde42981 7456 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7457
72391843 7458 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7459
436c16df 7460 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7461 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7462 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7463
92bb796d 7464 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7465 (x_term_init): Remove local to avoid shadowing.
92bb796d 7466
764430a3 7467 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7468
7469 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7470 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7471
d1dfb56c
EZ
74722011-04-16 Eli Zaretskii <eliz@gnu.org>
7473
c4354cb4
EZ
7474 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7475
d1dfb56c
EZ
7476 Fix regex.c, syntax.c and friends for buffers > 2GB.
7477 * syntax.h (struct gl_state_s): Declare character position members
7478 EMACS_INT.
7479
7480 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7481
04f2d78b
CB
7482 * textprop.c (verify_interval_modification, interval_of):
7483 Declare arguments EMACS_INT.
d1dfb56c
EZ
7484
7485 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7486 EMACS_INT.
7487
7488 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7489
7490 * indent.c (Fvertical_motion): Local variable it_start is now
7491 EMACS_INT.
7492
7493 * regex.c (re_match, re_match_2, re_match_2_internal)
7494 (bcmp_translate, regcomp, regexec, print_double_string)
7495 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7496 (re_compile_pattern, re_exec): Declare arguments and local
7497 variables `size_t' and `ssize_t' and return values `regoff_t', as
7498 appropriate.
7499 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7500 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7501 <compile_stack_type>: `size' and `avail' are now `size_t'.
7502
7503 * regex.h <regoff_t>: Use ssize_t, not int.
7504 (re_search, re_search_2, re_match, re_match_2): Arguments that
7505 specify buffer/string position and length are now ssize_t and
7506 size_t. Return type is regoff_t.
7507
613052cd
BK
75082011-04-16 Ben Key <bkey76@gmail.com>
7509
7510 * nsfont.m: Fixed bugs in ns_get_family and
7511 ns_descriptor_to_entity that were caused by using free to
7512 deallocate memory blocks that were allocated by xmalloc (via
7513 xstrdup). This caused Emacs to crash when compiled with
7514 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7515 --enable-checking=xmallocoverrun). xfree is now used to
7516 deallocate these memory blocks.
7517
4170f62f 75182011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7519
71b41406
PE
7520 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7521
9587a89d
PE
7522 emacs_write: Accept and return EMACS_INT for sizes.
7523 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7524 et seq.
7525 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7526 Accept and return EMACS_INT.
7527 (emacs_gnutls_write): Return the number of bytes written on
7528 partial writes.
7529 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7530 (emacs_read, emacs_write): Remove check for negative size, as the
7531 Emacs source code has been audited now.
9587a89d
PE
7532 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7533 (emacs_read, emacs_write): Use it.
273a5f82
PE
7534 * process.c (send_process): Adjust to the new signatures of
7535 emacs_write and emacs_gnutls_write. Do not attempt to store
7536 a byte offset into an 'int'; it might overflow.
9587a89d 7537 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7538
3e047f51
PE
7539 * sound.c: Don't assume sizes fit in 'int'.
7540 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7541 Return EMACS_INT, not int.
3e047f51 7542 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7543 Accept EMACS_INT, not int.
7544 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7545 record read return values.
7546
cc39a9db
BK
75472011-04-15 Ben Key <bkey76@gmail.com>
7548
c9d0ec6d
JB
7549 * keyboard.c (Qundefined): Don't declare static since it is used
7550 in nsfns.m.
7551 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7552 static since they are used in nsfont.m.
cc39a9db 7553
6c60eb9f
SM
75542011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7555
7556 * process.c (Qprocessp): Don't declare static.
7557 * lisp.h (Qprocessp): Declare again.
7558
7990b61a
JB
75592011-04-15 Juanma Barranquero <lekktu@gmail.com>
7560
7561 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7562
5d4cb038
PE
75632011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7564
8bd7b830 7565 Improve C-level modularity by making more things 'static'.
cd64ea1d 7566
e3b27b31
PE
7567 Don't publish debugger-only interfaces to other modules.
7568 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7569 (verify_bytepos, count_markers): Move decls to the only modules
7570 that need them.
7571 * region-cache.h (pp_cache): Likewise.
7572 * window.h (check_all_windows): Likewise.
7573 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7574
5d4cb038
PE
7575 * sysdep.c (croak): Now static, if
7576 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7577 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7578
7579 * alloc.c (refill_memory_reserve): Now static if
7580 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7581 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7582
e87b6180
PE
7583 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7584 Define only if USE_LUCID.
7585
ac64929e
PE
7586 * xrdb.c (x_customization_string, x_rm_string): Now static.
7587
6f37259d
PE
7588 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7589 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7590
1683e3ab
PE
7591 * xdisp.c (draw_row_with_mouse_face): Now static.
7592 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7593
de9c2632
PE
7594 * window.h (check_all_windows): Mark externally visible.
7595
2b96acb7
PE
7596 * window.c (window_deletion_count): Now static.
7597
7598 * undo.c: Make symbols static if they're not exported.
7599 (last_undo_buffer, last_boundary_position, pending_boundary):
7600 Now static.
7601
50436f33
PE
7602 * textprop.c (interval_insert_behind_hooks): Now static.
7603 (interval_insert_in_front_hooks): Likewise.
7604
64520e5c
PE
7605 * term.c: Make symbols static if they're not exported.
7606 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7607 (max_frame_lines, tty_set_terminal_modes):
7608 (tty_reset_terminal_modes, tty_turn_off_highlight):
7609 (get_tty_terminal): Now static.
7610 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7611 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7612 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7613 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7614 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7615
1fa53021
PE
7616 * sysdep.c: Make symbols static if they're not exported.
7617 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7618 Now static.
7619 (sigprocmask_set, full_mask): Remove; unused.
7620 (wait_debugging): Mark as visible.
7621 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7622 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7623
d4b43b22
PE
7624 * syntax.c (syntax_temp): Define only if !__GNUC__.
7625
b7c513d0
PE
7626 * sound.c (current_sound_device, current_sound): Now static.
7627
989b29ad
PE
7628 * search.c (searchbufs, searchbuf_head): Now static.
7629
13a55a78
PE
7630 * scroll.c (scroll_cost): Remove; unused.
7631 * dispextern.h (scroll_cost): Remove decl.
7632
de68a1fc
PE
7633 * region-cache.h (pp_cache): Mark as externally visible.
7634
40ccffa6
PE
7635 * process.c: Make symbols static if they're not exported.
7636 (process_tick, update_tick, create_process, chan_process):
7637 (Vprocess_alist, proc_buffered_char, datagram_access):
7638 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7639 (deactivate_process): Mark defn as static, as well as decl.
7640 * lisp.h (create_process): Remove decl.
7641 * process.h (chan_process, Vprocess_alist): Remove decls.
7642
ad64fc97
PE
7643 * print.c: Make symbols static if they're not exported.
7644 (print_depth, new_backquote_output, being_printed, print_buffer):
7645 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7646 (print_interval, print_number_index, initial_stderr_stream):
7647 Now static.
7648 * lisp.h (Fprinc): Remove decl.
7649 (debug_output_compilation_hack): Mark as externally visible.
7650
adddb265
PE
7651 * sysdep.c (croak): Move decl from here to syssignal.h.
7652 * syssignal.h (croak): Put it here, so the API can be checked when
7653 'croak' is called from dissociate_if_controlling_tty.
7654
1717ede2
PE
7655 * minibuf.c: Make symbols static if they're not exported.
7656 (minibuf_save_list, choose_minibuf_frame): Now static.
7657 * lisp.h (choose_minibuf_frame): Remove decl.
7658
fa5fb2bc
PE
7659 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7660
1e3890d1
PE
7661 * lread.c: Make symbols static if they're not exported.
7662 (read_objects, initial_obarray, oblookup_last_bucket_number):
7663 Now static.
7664 (make_symbol): Remove; unused.
7665 * lisp.h (initial_obarray, make_symbol): Remove decls.
7666
8a1414fa
PE
7667 * keyboard.c: Make symbols static if they're not exported.
7668 (single_kboard, recent_keys_index, total_keys, recent_keys):
7669 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7670 (this_single_command_key_start, echoing, last_auto_save):
7671 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7672 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7673 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7674 (Vlispy_mouse_stem, double_click_count):
7675 Now static.
7676 (force_auto_save_soon): Define only if SIGDANGER.
7677 (ignore_mouse_drag_p): Now static if
7678 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7679 (print_help): Remove; unused.
7680 (stop_character, last_timer_event): Mark as externally visible.
7681 * keyboard.h (ignore_mouse_drag_p): Declare only if
7682 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7683 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7684 * lisp.h (echoing): Remove decl.
7685 (force_auto_save_soon): Declare only if SIGDANGER.
7686 * xdisp.c (redisplay_window): Simplify code, to make it more
7687 obvious that ignore_mouse_drag_p is not accessed if !defined
7688 USE_GTK && !defined HAVE_NS.
7689
93ea6e8f
PE
7690 * intervals.c: Make symbols static if they're not exported.
7691 (merge_properties_sticky, merge_interval_right, delete_interval):
7692 Now static.
7693 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7694
77382fcc
PE
7695 * insdel.c: Make symbols static if they're not exported.
7696 However, leave prepare_to_modify_buffer alone. It's never
7697 called from outside this function, but that appears to be a bug.
7698 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7699 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7700 (adjust_after_replace_noundo): Remove; unused.
7701 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7702 (signal_before_change): Remove decls.
77382fcc 7703
9306c32e
PE
7704 * indent.c (val_compute_motion, val_vmotion): Now static.
7705
cd44d2eb
PE
7706 * image.c: Make symbols static if they're not exported.
7707 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7708 if USE_GTK.
7709 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7710 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7711
ad9a7a06
PE
7712 * fringe.c (standard_bitmaps): Now static.
7713 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7714
81626931
PE
7715 * frame.c: Make symbols static if they're not exported.
7716 (x_report_frame_params, make_terminal_frame): Now static.
7717 (get_frame_param): Now static, unless HAVE_NS.
7718 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7719 (x_get_resource_string): Remove; not used.
7720 * frame.h (make_terminal_frame, x_report_frame_params):
7721 (x_get_resource_string); Remove decls.
7722 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7723 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7724
239f9db9
PE
7725 * font.c, fontset.c: Make symbols static if they're not exported.
7726 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7727 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7728 * font.c (font_close_object): Now static.
7729 * font.h (font_close_object): Remove.
7730 * fontset.c (FONTSET_OBJLIST): Remove.
7731 (free_realized_fontset) #if-0 the body, which does nothing.
7732 (face_suitable_for_char_p): #if-0, as it's never called.
7733 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7734 * xfaces.c (face_at_string_position):
7735 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7736 since 0 is always ASCII.
7737
dfcf3579
PE
7738 * fns.c (weak_hash_tables): Now static.
7739
5045092b
PE
7740 * fileio.c: Make symbols static if they're not exported.
7741 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7742 (Vwrite_region_annotation_buffers): Now static.
7743
57a96f5c
PE
7744 * eval.c: Make symbols static if they're not exported.
7745 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7746 * lisp.h (backtrace_list): Remove decl.
7747
35f08c38
PE
7748 * emacs.c: Make symbols static if they're not exported.
7749 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7750 (fatal_error_code, fatal_error_signal_hook, standard_args):
7751 Now static.
7752 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7753 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7754 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7755 * lisp.h (fatal_error_signal_hook): Remove decl.
7756 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7757
f44bd759
PE
7758 * editfns.c: Move a (normally-unused) function to its only use.
7759 * editfns.c, lisp.h (get_operating_system_release): Remove.
7760 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7761 worth the hassle of breaking this out.
7762
b532497d
PE
7763 * xterm.c: Make symbols static if they're not exported.
7764 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7765 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7766 (x_destroy_window, x_delete_display):
7767 Now static.
7768 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7769 (x_mouse_leave): Remove; unused.
7770 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7771 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7772 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7773 Remove decls.
7774 (x_mouse_leave): Declare only if WINDOWSNT.
7775 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7776 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7777 USE_X_TOOLKIT.
7778
1675728f
PE
7779 * ftxfont.c: Make symbols static if they're not exported.
7780 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7781 HAVE_FREETYPE.
7782 * font.h (ftxfont_driver): Likewise.
7783
e4cebfca
PE
7784 * xfns.c: Make symbols static if they're not exported.
7785 (x_last_font_name, x_display_info_for_name):
7786 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7787 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7788 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7789 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7790 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7791 (last_show_tip_args): Now static.
7792 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7793 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7794 (x_screen_planes): Remove; unused.
7795 * dispextern.h (x_screen_planes): Remove decl.
7796
5bf46f05
PE
7797 * dispnew.c: Make symbols static if they're not exported.
7798 * dispextern.h (redraw_garbaged_frames, scrolling):
7799 (increment_row_positions): Remove.
7800 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7801 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7802 Now static.
7803 (redraw_garbaged_frames): Remove; unused.
7804
435f4c28
PE
7805 * xfaces.c: Make symbols static if they're not exported.
7806 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7807 Remove decls.
7808 * xterm.h (defined_color): Remove decls.
7809 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7810 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7811 (menu_face_changed_default, defined_color, free_realized_face):
7812 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7813 (ascii_face_of_lisp_face): Remove; unused.
7814
8524aef3
PE
7815 * xdisp.c: Make symbols static if they're not exported.
7816 * dispextern.h (scratch_glyph_row, window_box_edges):
7817 (glyph_to_pixel_coords, set_cursor_from_row):
7818 (get_next_display_element, set_iterator_to_next):
7819 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7820 (show_mouse_face): Remove decls
7821 * frame.h (message_buf_print): Likewise.
7822 * lisp.h (pop_message, set_message, check_point_in_composition):
7823 Likewise.
7824 * xterm.h (set_vertical_scroll_bar): Likewise.
7825 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7826 (message_buf_print, scratch_glyph_row, displayed_buffer):
7827 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7828 (get_next_display_element, show_mouse_face, window_box_edges):
7829 (frame_to_window_pixel_xy, check_point_in_composition):
7830 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7831 (glyph_to_pixel_coords): Remove; unused.
7832
16390cd2
PE
7833 * dired.c (file_name_completion): Now static.
7834
7835 * dbusbind.c (xd_in_read_queued_messages): Now static.
7836
a25f4dfa
PE
7837 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7838 * data.c (circular_list_error): Remove.
7839
14a9c8df
PE
7840 * commands.h (last_point_position, last_point_position_buffer):
7841 (last_point_position_window): Remove decls.
7842 * keyboard.c: Make these variables static.
7843
04f2d78b
CB
7844 * coding.h (coding, code_convert_region, encode_coding_gap):
7845 Remove decls.
74ab6df5
PE
7846 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7847 (iso_code_class, detect_coding, code_convert_region): Now static.
7848 (encode_coding_gap): Remove; unused.
7849
38dfbee1
PE
7850 * chartab.c (chartab_chars, chartab_bits): Now static.
7851
a2cb4e63
PE
7852 * charset.h (charset_iso_8859_1): Remove decl.
7853 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7854 Now static.
7855
127198fd
PE
7856 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7857 * ccl.c (Vccl_program_table): Now static.
7858 (check_ccl_update): Remove; unused.
7859
d85b608f
PE
7860 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7861 * category.h: ... from here.
7862 * category.c (check_category_table, set_category_set): Now static.
7863
31cd66f3
PE
7864 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7865 * lisp.h: Remove these decls.
7866
c358e587
PE
7867 * buffer.c (buffer_count): Remove unused var.
7868
e78aecca
PE
7869 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7870 so that it's not optimized away.
7871 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7872 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7873 exported only to the debugger.
7874
e192d7d3 7875 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7876 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7877
92470028
PE
7878 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7879 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7880 was inaccessible from Lisp.
7881 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7882 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7883
244ed907
PE
7884 alloc.c: Import and export fewer symbols, and remove unused items.
7885 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7886 is defined.
7887 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7888 it's not optimized away by whole-program optimization.
7889 (message_enable_multibyte, free_misc): Remove.
7890 (catchlist, handlerlist, mark_backtrace):
7891 Declare only if BYTE_MARK_STACK.
7892 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7893 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7894 (message_enable_multibyte): Remove decl.
7895 (free_misc, interval_free_list, float_block, float_block_index):
7896 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7897 (cons_free_list, last_marked_index):
7898 Now static.
7899 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7900 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7901 (mark_backtrace): Define only if BYTE_MARK_STACK.
7902 * xdisp.c (message_enable_multibyte): Now static.
7903
61c2b50e 7904 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7905 This makes it easier for human readers (and static analyzers)
7906 to see whether these variables are used from other modules.
7907 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7908 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7909 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7910 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7911 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7912 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7913 * xmenu.c, xselect.c:
7914 Declare Q* vars static if they are not used in other modules.
7915 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7916 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7917 Remove decls of unexported vars.
7918 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7919
95c82688
PE
7920 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7921
16a97296
PE
7922 Make Emacs functions such as Fatom 'static' by default.
7923 This makes it easier for human readers (and static analyzers)
7924 to see whether these functions can be called from other modules.
7925 DEFUN now defines a static function. To make the function external
7926 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7927 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7928 (Finit_image_library):
16a97296
PE
7929 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7930 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7931 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7932 Remove decls, since these functions are now static.
7933 (Funintern, Fget_internal_run_time): New decls, since these functions
7934 were already external.
95c82688 7935
16a97296
PE
7936 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7937 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7938 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7939 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7940 * keyboard.c, keymap.c, lread.c:
7941 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7942 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7943 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7944 Mark functions with DEFUE instead of DEFUN,
7945 if they are used in other modules.
7946 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7947 decls for now-static functions.
7948 * buffer.h (Fdelete_overlay): Remove decl.
7949 * callproc.c (Fgetenv_internal): Mark as internal.
7950 * composite.c (Fremove_list_of_text_properties): Remove decl.
7951 (Fcomposition_get_gstring): New forward static decl.
7952 * composite.h (Fcomposite_get_gstring): Remove decl.
7953 * dired.c (Ffile_attributes): New forward static decl.
7954 * doc.c (Fdocumntation_property): New forward static decl.
7955 * eval.c (Ffetch_bytecode): New forward static decl.
7956 (Funintern): Remove extern decl; now in .h file where it belongs.
7957 * fileio.c (Fmake_symbolic_link): New forward static decl.
7958 * image.c (Finit_image_library): New forward static decl.
7959 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7960 * intervals.h (Fprevious_property_change):
7961 (Fremove_list_of_text_properties): Remove decls.
7962 * keyboard.c (Fthis_command_keys): Remove decl.
7963 (Fcommand_execute): New forward static decl.
7964 * keymap.c (Flookup_key): New forward static decl.
7965 (Fcopy_keymap): Now static.
7966 * keymap.h (Flookup_key): Remove decl.
7967 * process.c (Fget_process): New forward static decl.
7968 (Fprocess_datagram_address): Mark as internal.
7969 * syntax.c (Fsyntax_table_p): New forward static decl.
7970 (skip_chars): Remove duplicate decl.
7971 * textprop.c (Fprevious_property_change): New forward static decl.
7972 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7973 Now internal.
7974 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7975 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7976
785bbd42
PE
7977 * editfns.c (Fformat): Remove unreachable code.
7978
8b913b57
AS
79792011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7980
7981 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7982 change. (Bug#8496)
7983
a6744a35
EZ
79842011-04-13 Eli Zaretskii <eliz@gnu.org>
7985
7986 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7987 when at ZV. (Bug#8487)
7988
e7974947
AS
79892011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7990
baad03f0
AS
7991 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7992 (Bug#8437)
7993 * keyboard.c (parse_tool_bar_item): Likewise.
7994 * sound.c (sound_cleanup, alsa_close): Likewise.
7995 * termcap.c (tgetent): Likewise.
7996 * xfns.c (x_default_font_parameter): Likewise.
7997 * xsettings.c (read_and_apply_settings): Likewise.
7998
e7974947
AS
7999 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8000 (overrun_check_free): Protoize.
8001
28272684
PE
80022011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8003
8004 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8005 since callers should never pass a negative size.
8006 Change the signature to match that of plain 'read' and 'write'; see
8007 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8008 * lisp.h: Update prototypes of emacs_write and emacs_read.
8009
11997c76
EZ
80102011-04-11 Eli Zaretskii <eliz@gnu.org>
8011
8012 * xdisp.c (redisplay_window): Don't try to determine the character
8013 position of the scroll margin if the window start point w->startp
e896f03c 8014 is outside the buffer's accessible region. (Bug#8468)
11997c76 8015
8a2cbd72
EZ
80162011-04-10 Eli Zaretskii <eliz@gnu.org>
8017
8018 Fix write-region and its subroutines for buffers > 2GB.
8019 * fileio.c (a_write, e_write): Modify declaration of arguments and
8020 local variables to support buffers larger than 2GB.
8021 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8022
8023 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8024 argument, local variables, and return value.
8025
8026 * lisp.h: Update prototypes of emacs_write and emacs_read.
8027
8028 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8029
4073e537 80302011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8031
1ebfdcb6
PE
8032 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8033
b2ded58d
PE
8034 Fix more problems found by GCC 4.6.0's static checks.
8035
7d66342c
PE
8036 * xdisp.c (vmessage): Use a better test for character truncation.
8037
bbf47d44
PE
8038 * charset.c (load_charset_map): <, not <=, for optimization,
8039 and to avoid potential problems with integer overflow.
9248994d 8040 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8041 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8042 * editfns.c (Fformat): Likewise.
1e69125e 8043 * syntax.c (skip_chars): Likewise.
3befa583 8044
e3019616
PE
8045 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8046 This also lets GCC 4.6.0 generate slightly better loop code.
8047
becfa255
PE
8048 * callint.c (Fcall_interactively): <, not <=, for optimization.
8049 (Fcall_interactively): Count the number of arguments produced,
8050 not the number of arguments given. This is simpler and lets GCC
8051 4.6.0 generate slightly better code.
8052
dae0cd48
PE
8053 * ftfont.c: Distingish more carefully between FcChar8 and char.
8054 The previous code passed unsigned char * to a functions like
8055 strlen and xstrcasecmp that expect char *, which does not
8056 conform to the C standard.
8057 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8058 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8059 char * when the C standard requires it.
8060
76032d70
PE
8061 * keyboard.c (read_char): Remove unused var.
8062
eb3f1cc8
PE
8063 * eval.c: Port to Windows vsnprintf (Bug#8435).
8064 Include <limits.h>.
8065 (SIZE_MAX): Define if the headers do not.
8066 (verror): Do not give up if vsnprintf returns a negative count.
8067 Instead, grow the buffer. This ports to Windows vsnprintf, which
8068 does not conform to C99. Problem reported by Eli Zaretskii.
8069 Also, simplify the allocation scheme, by avoiding the need for
8070 calling realloc, and removing the ALLOCATED variable.
8071
70476b54
PE
8072 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8073
12020a9e
PE
8074 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8075 But keep the doprint source code for now, as we might revamp it
8076 and use it again (Bug#8435).
ea6c7ae6
PE
8077 * lisp.h (doprnt): Remove.
8078 * Makefile.in (base_obj): Remove doprnt.o.
8079 * deps.mk (doprnt.o): Remove.
8080
5fdb398c
PE
8081 error: Print 32- and 64-bit integers portably (Bug#8435).
8082 Without this change, on typical 64-bit hosts error ("...%d...", N)
8083 was used to print both 32- and 64-bit integers N, which relied on
8084 undefined behavior.
61bdb816 8085 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8086 * lisp.h (error, verror): Mark as printf-like functions.
8087 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8088 Report overflow in size calculations when allocating printf buffer.
8089 Do not truncate output string at its first null byte.
8090 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8091 Truncate the output at a character boundary, since vsnprintf does not
8092 do that.
8093 * charset.c (check_iso_charset_parameter): Convert internal
8094 character to string before calling 'error', since %c now has the
8095 printf meaning.
8096 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8097 overflow when computing char to be passed to 'error'. Do not
8098 pass Lisp_Object to 'error'; pass the integer instead.
8099 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8100 formatted with plain %d.
8101
b189fa66
PE
8102 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8103
bff87ef0
PE
8104 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8105
7e2cac20
PE
8106 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8107
ce4d90b5
PE
8108 * xterm.c (x_catch_errors): Remove duplicate declaration.
8109
266c9547
PE
8110 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8111
79c49ad2
PE
8112 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8113
368f4090
JM
81142011-04-10 Jim Meyering <meyering@redhat.com>
8115
8116 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8117 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8118 return ssize_t not "int", and use size_t as the buffer length.
8119 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8120 * gnutls.h: Update declarations.
8121 * process.c (read_process_output): Use ssize_t, to match.
8122 (send_process): Likewise.
8123
a32d4040
CY
81242011-04-09 Chong Yidong <cyd@stupidchicken.com>
8125
8126 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8127
8546720e 81282011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8129
04f2d78b
CB
8130 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8131 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8132
8546720e
GM
8133 * xterm.c (handle_one_xevent):
8134 * xmenu.c (create_and_show_popup_menu):
8135 * xselect.c (x_decline_selection_request)
8136 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8137
0a2f5c1a 81382011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8139
8140 Fix some uses of `int' instead of EMACS_INT.
8141 * search.c (string_match_1, fast_string_match)
8142 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8143 (scan_buffer, find_next_newline_no_quit)
8144 (find_before_next_newline, search_command, Freplace_match)
8145 (Fmatch_data): Make some `int' variables be EMACS_INT.
8146
8147 * xdisp.c (display_count_lines): 3rd argument and return value now
8148 EMACS_INT. All callers changed.
8149 (pint2hrstr): Last argument is now EMACS_INT.
8150
8151 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8152 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8153 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8154 (decode_coding_utf_16, decode_coding_emacs_mule)
8155 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8156 (decode_coding_ccl, decode_coding_charset)
8157 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8158 (decode_coding_iso_2022, decode_coding_emacs_mule)
8159 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8160 <char_offset, last_offset>: Declare EMACS_INT.
8161 (encode_coding_utf_8, encode_coding_utf_16)
8162 (encode_coding_emacs_mule, encode_invocation_designation)
8163 (encode_designation_at_bol, encode_coding_iso_2022)
8164 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8165 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8166 Declare EMACS_INT.
8167 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8168 (encode_invocation_designation): Last argument P_NCHARS is now
8169 EMACS_INT.
8170 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8171 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8172
8173 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8174 All users changed.
8175
8176 * ccl.c (Fccl_execute_on_string): Declare some variables
8177 EMACS_INT.
8178
8546720e 81792011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8180
8181 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8182
4e19a977
CS
81832011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8184
8185 * process.c (Fformat_network_address): Doc fix.
8186
87302331
R
81872011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8188
ee7683eb 8189 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8190
cbb59342
CY
81912011-04-08 Chong Yidong <cyd@stupidchicken.com>
8192
8193 * keyboard.c (read_char): Call Lisp function help-form-show,
8194 instead of using internal_with_output_to_temp_buffer.
8195 (Qhelp_form_show): New var.
e0d38eeb 8196 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8197
8198 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8199
8200 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8201
e67a13ab
CY
82022011-04-06 Chong Yidong <cyd@stupidchicken.com>
8203
04f2d78b
CB
8204 * process.c (Flist_processes): Remove to Lisp.
8205 (list_processes_1): Delete.
e67a13ab 8206
973f782d
EZ
82072011-04-06 Eli Zaretskii <eliz@gnu.org>
8208
7c106b1e
EZ
8209 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8210
973f782d
EZ
8211 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8212
41cf7d1a 82132011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8214
ca23cc88
PE
8215 Fix more problems found by GCC 4.6.0's static checks.
8216
f390e2d5
PE
8217 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8218
42eea0d0
PE
8219 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8220
b69769da 8221 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8222
f9541e84
PE
8223 * xdisp.c (vmessage): Mark as a printf-like function.
8224
13841b55
PE
8225 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8226
c136c10f
PE
8227 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8228
5e2d4a30
PE
8229 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8230 printf-like functions.
8231 (tiff_load): Add casts to remove these marks before passing them
8232 to system-supplied API.
8233
583f48b9
PE
8234 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8235
b25d760e
PE
8236 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8237 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8238 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8239 directly, rather than having caller test rule sign. This avoids
8240 some unnecessary tests.
8241 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8242 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8243 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8244
bc7b6697 8245 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8246 (xfont_open): Avoid unnecessary tests.
bc7b6697 8247
27ccc379
PE
8248 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8249
dcd5c89a
PE
8250 * composite.h, composite.c (composition_gstring_put_cache):
8251 Use EMACS_INT, not int, for length.
8252
b13a45c6
PE
8253 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8254 breaking out part of COMPOSITION_DECODE_RULE.
8255 (COMPOSITION_DECODE_RULE): Use it.
8256 * composite.c (get_composition_id): Remove unused local vars,
8257 by using the new macro.
8258
1e792e4d
PE
8259 * textprop.c (set_text_properties_1): Change while to do-while,
8260 since the condition is always true at first.
8261
dc6c6455 8262 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8263 (interval_deletion_adjustment): Return unsigned value.
8264 All uses changed.
dc6c6455 8265
aba7731a
PE
8266 * process.c (list_processes_1, create_pty, read_process_output):
8267 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8268 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8269 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8270 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8271 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8272
fdfc4bf3
PE
8273 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8274
fca8fe46 8275 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8276 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8277
06a0259a 8278 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8279 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8280 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8281
e7b9e80f
PE
8282 * print.c (print_error_message): Avoid int overflow.
8283
56201685
PE
8284 * font.c (font_list_entities): Redo for clarity,
8285 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8286
78834453 8287 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8288 (font_score): Avoid potential overflow in diff calculation.
78834453 8289
0bc0b309 8290 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8291 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8292
e610eaca
PE
8293 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8294
b895abce
PE
8295 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8296 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8297 can always succeed if overflow has undefined behavior.
8298
1f1d9321 8299 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8300 (wordify): Omit three unnecessary tests.
1f1d9321 8301
c59478bc
PE
8302 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8303 All callers changed. This avoids the need for an unused var.
8304
79b73827
PE
8305 * casefiddle.c (casify_region): Remove var that is set but not used.
8306
a4db5dfe
PE
8307 * dired.c (file_name_completion): Remove var that is set but not used.
8308
43aae36e
PE
8309 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8310
2a47c44d 8311 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8312 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8313
a37c69bf
PE
8314 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8315 Check for integer overflow on size calculations.
8316
328ab8e7
PE
8317 * buffer.c (Fprevious_overlay_change): Remove var that is set
8318 but not used.
8319
e5a2a5cb
PE
8320 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8321 Remove vars that are set but not used.
8d84a6eb 8322 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8323 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8324
a60e5f68
PE
8325 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8326
f661cb61 8327 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8328 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8329
f0397f5a
PE
8330 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8331 that are set but not used.
8332
8664db06 8333 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8334 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8335
6abdaa4a
PE
8336 * xselect.c (x_get_local_selection, x_handle_property_notify):
8337 Remove vars that are set but not used.
8338
0ce7538d 8339 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8340 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8341
9ae848fc
PE
8342 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8343 Remove var that is set but not used.
0b918413
PE
8344 (scroll_bar_windows_size): Now size_t, not int.
8345 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8346 Check for overflow.
9ae848fc 8347
a5a62657
PE
8348 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8349 (map_tty_color) [!defined MSDOS]: Likewise.
8350
5c5cdd39
PE
8351 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8352
66ebf983
PE
8353 * coding.c: Remove vars that are set but not used.
8354 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8355 All callers changed.
8356 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8357 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8358 (decode_coding_charset): Remove vars that are set but not used.
8359
1be4d761
PE
8360 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8361 that is set but not used.
8362
47553fa8
PE
8363 * print.c (print_object): Remove var that is set but not used.
8364
1f7196bf 8365 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8366 The gnulib version avoids calling malloc in the usual case,
8367 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8368 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8369 * filelock.c (current_lock_owner): Likewise.
8370 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8371 * sysdep.c: Include allocator.h, careadlinkat.h.
8372 (emacs_no_realloc_allocator): New static constant.
8373 (emacs_readlink): New function.
fdb61804
PE
8374 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8375 ../lib/careadlinkat.h.
d1fdcab7 8376
f84c17c7
SM
83772011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8378
8379 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8380 first non-nil return value).
8381
ef3862ad
JD
83822011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8383
8384 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8385 if not defined (Bug#8403).
8386
376a7006
JB
83872011-04-02 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * xdisp.c (display_count_lines): Remove parameter `start',
8390 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8391 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8392 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8393 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8394 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8395 and thereabouts. All callers changed.
8396 (get_per_char_metric): Remove parameter `f', unused since
8397 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8398
6ca3801d
JM
83992011-04-02 Jim Meyering <meyering@redhat.com>
8400
8401 do not dereference NULL upon failed strdup
8402 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8403 (ns_get_family): Likewise.
8404
d8e2b5ba
JB
84052011-04-02 Juanma Barranquero <lekktu@gmail.com>
8406
8407 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8408
8c74fcbd
JD
84092011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8410
8411 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8412 later (Bug#8403).
8413
7200d79c
SM
84142011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8415
03408648 8416 Add lexical binding.
7200d79c 8417
03408648
SM
8418 * window.c (Ftemp_output_buffer_show): New fun.
8419 (Fsave_window_excursion):
8420 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8421
8422 * lread.c (lisp_file_lexically_bound_p): New function.
8423 (Fload): Bind Qlexical_binding.
8424 (readevalloop): Remove `evalfun' arg.
8425 Bind Qinternal_interpreter_environment.
8426 (Feval_buffer): Bind Qlexical_binding.
8427 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8428 Mark as dynamic.
8429 (syms_of_lread): Declare `lexical-binding'.
8430
8431 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8432
8433 * keyboard.c (eval_dyn): New fun.
8434 (menu_item_eval_property): Use it.
ca105506
SM
8435
8436 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8437
03408648
SM
8438 * fns.c (concat, mapcar1): Accept byte-code-functions.
8439
8440 * eval.c (Fsetq): Handle lexical vars.
8441 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8442 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8443 (FletX, Flet): Obey lexical binding.
8444 (Fcommandp): Handle closures.
8445 (Feval): New `lexical' arg.
8446 (eval_sub): New function extracted from Feval. Use it almost
8447 everywhere where Feval was used. Look up vars in lexical env.
8448 Handle closures.
8449 (Ffunctionp): Move from subr.el.
8450 (Ffuncall): Handle closures.
8451 (apply_lambda): Remove `eval_flags'.
8452 (funcall_lambda): Handle closures and new byte-code-functions.
8453 (Fspecial_variable_p): New function.
8454 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8455 but without exporting it to Lisp.
23aba0ea 8456
23aba0ea 8457 * doc.c (Fdocumentation, store_function_docstring):
03408648 8458 * data.c (Finteractive_form): Handle closures.
23aba0ea 8459
03408648
SM
8460 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8461 interactive spec.
ba83908c 8462
04f2d78b
CB
8463 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8464 New byte-codes.
03408648
SM
8465 (exec_byte_code): New function extracted from Fbyte_code to handle new
8466 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8467
03408648 8468 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8469
03408648 8470 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8471
e2abce01
JB
84722011-03-31 Juanma Barranquero <lekktu@gmail.com>
8473
8474 * xdisp.c (redisplay_internal): Fix prototype.
8475
63696a73 84762011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8477
63696a73 8478 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8479 (try_scrolling): Use it when setting scroll_limit.
8480 Limit scrolling to 100 screen lines.
63696a73
EZ
8481 (redisplay_window): Even when falling back on "recentering",
8482 position point in the window according to scroll-conservatively,
8483 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8484
8485 (try_scrolling): When point is above the window, allow searching
8486 as far as scroll_max, or one screenful, to compute vertical
8487 distance from PT to the scroll margin position. This prevents
8488 try_scrolling from unnecessarily failing when
8489 scroll-conservatively is set to a value slightly larger than the
8490 window height. Clean up the case of PT below the margin at bottom
8491 of window: scroll_max can no longer be INT_MAX. When aggressive
8492 scrolling is in use, don't let point enter the opposite scroll
8493 margin as result of the scroll.
8494 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8495 threshold of 100 lines for never-recentering scrolling.
8496
e4cc2dfc
JB
84972011-03-31 Juanma Barranquero <lekktu@gmail.com>
8498
8499 * dispextern.h (move_it_by_lines):
8500 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8501 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8502 (message_log_check_duplicate): Remove parameters `prev_bol' and
8503 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8504 (redisplay_internal): Remove parameter `preserve_echo_area',
8505 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8506
8507 * indent.c (Fvertical_motion):
8508 * window.c (window_scroll_pixel_based, Frecenter):
8509 Don't pass `need_y_p' to `move_it_by_lines'.
8510
1c470562
SM
85112011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8512
44f230aa
SM
8513 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8514 steal a few bits to be more compact.
8515 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8516 Remove unneeded casts.
8517
1c470562
SM
8518 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8519
888adce9
ZK
85202011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8521
8522 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8523 binding" message (bug#7967).
8524
f838ed7b
PE
85252011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8526
77861b95
PE
8527 Fix more problems found by GCC 4.6.0's static checks.
8528
de6dbc14
PE
8529 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8530 Remove unused local var.
8531
f838ed7b
PE
8532 * editfns.c (Fmessage_box): Remove unused local var.
8533
792c7b2b
PE
8534 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8535 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8536 Omit unused local vars.
c499e557 8537 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8538 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8539 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8540 Omit unused local var.
8541
ba0165e1
PE
8542 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8543 Don't assume string length fits in int.
32ad8845 8544 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8545 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8546
3c59b4c9
PE
8547 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8548 instead of alloca (Bug#8344).
8549
a3eed478 8550 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8551 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8552
eb4d412d
PE
8553 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8554
1658b401
PE
8555 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8556 concerns.
8557
8558 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8559
8560 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8561
9a2c6e05
PE
8562 * keyboard.c (syms_of_keyboard): Use the same style as later
8563 in this function when indexing through an array. This also
8564 works around GCC bug 48267.
8565
03d0a109
PE
8566 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8567
44f730c8
PE
8568 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8569
fe75f926
PE
8570 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8571 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8572
ffa8c828
PE
8573 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8574 This avoids undefined behavior on integer overflow, and is a bit
8575 more convenient anyway since it is compared to a size_t variable.
8576
c5101a77
PE
8577 Variadic C functions now count arguments with size_t, not int.
8578 This avoids an unnecessary limitation on 64-bit machines, which
8579 caused (substring ...) to crash on large vectors (Bug#8344).
8580 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8581 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8582 All variadic functions and their callers changed accordingly.
c5101a77
PE
8583 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8584 * data.c (arith_driver, float_arith_driver): Likewise.
8585 * editfns.c (general_insert_function): Likewise.
8586 * eval.c (struct backtrace.nargs, interactive_p)
8587 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8588 (funcall_lambda, mark_backtrace): Likewise.
8589 * fns.c (concat): Likewise.
8590 * frame.c (x_set_frame_parameters): Likewise.
8591 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8592 0 if not found, not -1. All callers changed.
8593
dd3f25f7
PE
8594 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8595 (stack_copy_size): Now size_t, not int.
8596 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8597
461c2ab9
JB
85982011-03-28 Juanma Barranquero <lekktu@gmail.com>
8599
8600 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8601 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8602 All callers changed.
8603
8604 * lisp.h (multibyte_char_to_unibyte):
8605 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8606 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8607 * character.h (CHAR_TO_BYTE8):
8608 * cmds.c (internal_self_insert):
8609 * editfns.c (general_insert_function):
8610 * keymap.c (push_key_description):
8611 * search.c (Freplace_match):
8612 * xdisp.c (message_dolog, set_message_1): All callers changed.
8613
f6d62986
SM
86142011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8615
8616 * keyboard.c (safe_run_hook_funcall): New function.
8617 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8618 don't set the hook to nil, but remove the offending function instead.
8619 (Qcommand_hook_internal): Remove, unused.
8620 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8621 Vcommand_hook_internal.
8622
8623 * eval.c (enum run_hooks_condition): Remove.
8624 (funcall_nil, funcall_not): New functions.
8625 (run_hook_with_args): Call each function through a `funcall' argument.
8626 Remove `cond' argument, now redundant.
8627 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8628 (Frun_hook_with_args_until_failure): Adjust accordingly.
8629 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8630
1db5b1ad
JB
86312011-03-28 Juanma Barranquero <lekktu@gmail.com>
8632
8633 * dispextern.h (string_buffer_position): Remove declaration.
8634
8635 * print.c (strout): Remove parameter `multibyte', unused since
8636 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8637
8638 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8639 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8640 All callers changed.
8641
8642 * w32.c (_wsa_errlist): Use braces for struct initializers.
8643
8644 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8645 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8646 All callers changed.
8647 (string_buffer_position): Likewise. Also, make static (it's never
8648 used outside xdisp.c).
8649 (cursor_row_p): Remove parameter `w', unused since
8650 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8651 (decode_mode_spec): Remove parameter `precision', introduced during
8652 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8653 All callers changed.
8654
5ffb62aa
JD
86552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8656
8657 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8658
461c2ab9 86592011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8660
8661 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8662 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8663 (ns_update_auto_hide_menu_bar): New functions.
8664 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8665 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8666 ns_constrain_all_frames.
8667 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8668 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8669
5c380ffb
JD
86702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8671
8672 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8673
9af30bdf
GM
86742011-03-27 Glenn Morris <rgm@gnu.org>
8675
8676 * syssignal.h: Replace RETSIGTYPE with void.
8677 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8678 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8679 Replace SIGTYPE with void everywhere.
8680 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8681 * s/template.h (SIGTYPE): Remove commented out definition.
8682
e2abce01
JB
86832011-03-26 Eli Zaretskii <eliz@gnu.org>
8684
8685 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8686 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8687
f868cd8a
JB
86882011-03-26 Juanma Barranquero <lekktu@gmail.com>
8689
59eb0929
JB
8690 * w32.c (read_unc_volume): Use parameter `henum', instead of
8691 global variable `wget_enum_handle'.
8692
8693 * keymap.c (describe_vector): Remove parameters `indices' and
8694 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8695 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8696
f868cd8a
JB
8697 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8698
8699 * keyboard.c (timer_check): Remove parameter `do_it_now',
8700 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8701 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8702 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8703
8704 * keyboard.c (read_char):
8705 * w32menu.c (w32_menu_display_help):
8706 * xmenu.c (show_help_event, menu_help_callback):
8707 Adjust calls to `show_help_echo'.
8708
8709 * gtkutil.c (xg_maybe_add_timer):
8710 * keyboard.c (readable_events):
8711 * process.c (wait_reading_process_output):
8712 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8713
8714 * insdel.c (adjust_markers_gap_motion):
8715 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8716 (gap_left, gap_right): Don't call it.
8717
2ecf6fdb
CY
87182011-03-25 Chong Yidong <cyd@stupidchicken.com>
8719
8720 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8721 incurred during fontification.
8722
6b1f9ba4
JB
87232011-03-25 Juanma Barranquero <lekktu@gmail.com>
8724
8725 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8726 (DEFVAR_PER_BUFFER): Don't pass it.
8727
8728 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8729 (scrolling_window): Don't pass it.
8730
0f4a96b5
JB
87312011-03-25 Juanma Barranquero <lekktu@gmail.com>
8732
8733 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8734
8735 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8736 and `suffix'.
8737 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8738 of variables specific to SELinux and computation of `encoded_absname'.
8739
8740 * image.c (XPutPixel): Remove unused variable `height'.
8741
8742 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8743
8744 * unexw32.c (get_section_info): Remove unused variable `section'.
8745
8746 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8747 (system_process_attributes): Remove unused variable `sess'.
8748 (sys_read): Remove unused variable `err'.
8749
8750 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8751 (w32_wnd_proc): Remove unused variable `isdead'.
8752 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8753 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8754 (x_create_tip_frame): Remove unused variable `tem'.
8755
8756 * w32inevt.c (w32_console_read_socket):
8757 Remove unused variable `no_events'.
8758
8759 * w32term.c (x_draw_composite_glyph_string_foreground):
8760 Remove unused variable `width'.
8761
1149507c
JB
87622011-03-24 Juanma Barranquero <lekktu@gmail.com>
8763
8764 * w32term.c (x_set_glyph_string_clipping):
8765 Don't pass uninitialized region to CombineRgn.
8766
9c88f339
JB
87672011-03-23 Juanma Barranquero <lekktu@gmail.com>
8768
8769 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8770 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8771 (Fx_close_connection): Remove unused variable `i'.
8772
8773 * w32font.c (w32font_draw): Return number of glyphs.
8774 (w32font_open_internal): Remove unused variable `i'.
8775 (w32font_driver): Add missing initializer.
8776
8777 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8778 (fill_in_menu): Remove unused variable `items_added'.
8779
8780 * w32term.c (last_mouse_press_frame): Remove static global variable.
8781 (w32_clip_to_row): Remove unused variable `f'.
8782 (x_delete_terminal): Remove unused variable `i'.
8783
8784 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8785 (NOTHING): Remove unused static global variable.
8786 (uniscribe_check_otf): Remove unused variable `table'.
8787 (uniscribe_font_driver): Add missing initializers.
8788
dee091a3
JD
87892011-03-23 Julien Danjou <julien@danjou.info>
8790
8791 * term.c (Fsuspend_tty, Fresume_tty):
8792 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8793 * window.c (temp_output_buffer_show):
8794 * insdel.c (signal_before_change):
8795 * frame.c (Fhandle_switch_frame):
8796 * fileio.c (Fdo_auto_save):
8797 * emacs.c (Fkill_emacs):
8798 * editfns.c (save_excursion_restore):
8799 * cmds.c (internal_self_insert):
8800 * callint.c (Fcall_interactively):
8801 * buffer.c (Fkill_all_local_variables):
8802 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8803 Use Frun_hooks.
0f4a96b5 8804 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8805 unconditionally since it does the check itself.
dee091a3 8806
2c520ab5 88072011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8808
c9c49752
PE
8809 Fix more problems found by GCC 4.5.2's static checks.
8810
8abc3f12
PE
8811 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8812 the first time through the loop, since we know p0 < p1 then.
8813 This also avoids a gcc -Wstrict-overflow warning.
8814
a2d26660
PE
8815 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8816 leading to a memory leak, possible in functions like
8817 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8818 of objects (Bug#8318).
a2d26660 8819
916c72e9
PE
8820 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8821 that could (at least in theory) be that large.
8822
19ab8a18
PE
8823 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8824 This is less likely to overflow, and avoids undefined behavior if
8825 overflow does occur. All callers changed. Use strtoul to scan
8826 for the unsigned long integer.
b7cbbd6f
PE
8827 (pint2hrstr): Simplify and tune code slightly.
8828 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8829
f0641eff
PE
8830 * scroll.c (do_scrolling): Work around GCC bug 48228.
8831 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8832
7f650bb9
PE
8833 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8834 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8835 (validate_x_resource_name): Simplify count usage.
8836 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8837
37dd57d1
PE
8838 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8839 fail (Bug#8306).
81e56e61 8840
699979fc 8841 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8842
401bf9b4
PE
8843 * process.c (Fmake_network_process): Use socklen_t, not int,
8844 where POSIX says socklen_t is required in portable programs.
8845 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8846 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8847 (Fmake_network_process, server_accept_connection):
8848 (wait_reading_process_output, read_process_output):
8849 Likewise.
8850
b93aacde
PE
8851 * process.c: Rename or move locals to avoid shadowing.
8852 (list_processes_1, Fmake_network_process):
8853 (read_process_output_error_handler, exec_sentinel_error_handler):
8854 Rename or move locals.
4dc343ee 8855 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8856 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8857 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8858 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8859 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8860
af8a867c 8861 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8862 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8863 Include tparam.h instead, since it declares them.
af8a867c
PE
8864 * cm.h (PC): Remove extern decl; tparam.h now does this.
8865 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8866 * terminfo.c: Include tparam.h, to check interfaces.
8867 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8868 (tparam): Adjust signature to match interface in tparam.h;
8869 this removes some undefined behavior. Check that outstring and len
8870 are zero, which they always are with Emacs.
8871 * tparam.h (PC, BC, UP): New extern decls.
8872
0248044d 8873 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8874 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8875
8ff096c1 8876 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8877 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8878 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8879 (ftfont_list): Remove unused local.
49eaafba
PE
8880 (get_adstyle_property, ftfont_pattern_entity):
8881 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8882 Rename locals to avoid shadowing.
8ff096c1 8883
e2be39f6
PE
8884 * xfont.c (xfont_list_family): Mark var as initialized.
8885
c9735e30
PE
8886 * xml.c (make_dom): Now static.
8887
8f5201ae
PE
8888 * composite.c (composition_compute_stop_pos): Rename local to
8889 avoid shadowing.
b246f932
PE
8890 (composition_reseat_it): Remove unused locals.
8891 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8892 (composition_update_it): Mark var as initialized.
11b61122
PE
8893 (find_automatic_composition): Mark vars as initialized,
8894 with a FIXME (Bug#8290).
8f5201ae 8895
760fbc2c
PE
8896 character.h: Rename locals to avoid shadowing.
8897 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8898 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8899 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8900 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8901 to avoid shadowing.
8902
ff08eb85
PE
8903 * textprop.c (property_change_between_p): Remove; unused.
8904
fc7bf025
PE
8905 * intervals.c (interval_start_pos): Now static.
8906
235d7abc
PE
8907 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8908
44f230aa
SM
8909 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8910 Rename locals to avoid shadowing.
3e7d6594 8911
50060332
PE
8912 * sound.c (wav_play, au_play, Fplay_sound_internal):
8913 Fix pointer signedness.
d01f234b 8914 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8915 (wav_play): Initialize a variable to 0, to prevent undefined
8916 behavior (Bug#8278).
50060332 8917
c4fc4e30
PE
8918 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8919
918436ed
PE
8920 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8921
c939f91b
PE
8922 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8923 clobbering (Bug#8298).
b9c7f648
PE
8924 * sysdep.c (sys_subshell): Likewise.
8925 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8926
6bd8c144
PE
8927 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8928 This should get cleaned up, so that child_setup has the
8929 same signature on all platforms.
8930
7710357c 8931 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8932 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8933
c59da222
CY
89342011-03-22 Chong Yidong <cyd@stupidchicken.com>
8935
8936 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8937 not to be necessary, and produces flickering.
8938
66b87493
GM
89392011-03-20 Glenn Morris <rgm@gnu.org>
8940
8941 * config.in: Remove file.
8942
45b6f6d5
JB
89432011-03-20 Juanma Barranquero <lekktu@gmail.com>
8944
8945 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8946 are now in src/globals.h.
8947 (syms_of_minibuf): Remove spurious & from previous change.
8948
cd394be1 89492011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8950
8951 * minibuf.c (completing-read-function): New variable.
8952 (completing-read-default): Rename from completing-read.
8953 (completing-read): Call completing-read-function.
8954
b14e3e21
CY
89552011-03-19 Juanma Barranquero <lekktu@gmail.com>
8956
8957 * xfaces.c (Fx_load_color_file):
8958 Read color file from absolute filename (bug#8250).
8959
f2b726e6
JB
89602011-03-19 Juanma Barranquero <lekktu@gmail.com>
8961
8962 * makefile.w32-in: Update dependencies.
8963
09f6ff02
EZ
89642011-03-17 Eli Zaretskii <eliz@gnu.org>
8965
8966 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8967
29a6015a
PE
89682011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8969
a3a6c54e
PE
8970 Fix more problems found by GCC 4.5.2's static checks.
8971
b766f867
PE
8972 * process.c (make_serial_process_unwind, send_process_trap):
8973 (sigchld_handler): Now static.
8974
be02381c
PE
8975 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8976 That way, the code declares only the vars that it needs.
8977 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8978 * s/cygwin.h (PTY_ITERATION): Likewise.
8979 * s/darwin.h (PTY_ITERATION): Likewise.
8980 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8981
57048744
PE
8982 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8983 * process.c (allocate_pty): Don't declare stb unless it's needed.
8984
7914961c 8985 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8986 (CONSTANTLIM): Remove; unused.
8987 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8988 Define only if needed.
7914961c 8989
b3967b18
PE
8990 * unexelf.c (unexec): Name an expression,
8991 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8992 Use a different way to cause a compilation error if anyone uses
8993 n rather than nn, a way that does not involve shadowing.
73366a00 8994 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8995
29a6015a
PE
8996 * deps.mk (unexalpha.o): Remove; unused.
8997
43cfc33e 8998 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8999 * unexec.h: New file.
ce701a33
PE
9000 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9001 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9002 Depend on unexec.h.
9003 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9004 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9005 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9006 Change as necessary to match prototype in unexec.h.
ce701a33 9007
01f44d5a
PE
9008 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9009 shadowing.
4f63c6bb 9010 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9011
a6670b0b
PE
9012 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9013 Rename locals to avoid shadowing.
9014
cef2010d 9015 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9016 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9017
d4d7173a
PE
9018 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9019
f08b802a
PE
9020 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9021 warning when compiling print.c.
9022
3ddb0639
PE
9023 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9024 instead of using an uninitialized var.
5ad03b97 9025 (font_sort_entities): Mark var as initialized.
3ddb0639 9026
170a2692
PE
9027 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9028
e663c700
PE
9029 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9030 pointers to constants.
89bc529a 9031 (font_parse_fcname): Remove unused vars.
7b81e2d0 9032 (font_delete_unmatched): Now static.
ea838e10 9033 (font_get_spec): Remove; unused.
13a547c6
PE
9034 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9035 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9036 Rename or move locals to avoid shadowing.
e663c700 9037
2a80c887 9038 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9039 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9040
1384fa33 9041 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9042 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9043
8b2c52e9
PE
9044 * alloc.c (mark_backtrace): Move decl from here ...
9045 * lisp.h: ... to here, so that it can be checked.
9046
475545b5 9047 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9048 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9049 (lisp_indirect_variable): Name an expression,
9050 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9051 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9052
b1349114 9053 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9054 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9055 Use const pointer when appropriate.
b1349114 9056
a2928364
PE
9057 * lisp.h (get_system_name, get_operating_system_release):
9058 Move decls here, to check interfaces.
9059 * process.c (get_operating_system_release): Move decl to lisp.h.
9060 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9061 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9062 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9063 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9064 (Fformat_time_string, Fencode_time, Finsert_char):
9065 (Ftranslate_region_internal, Fformat):
9066 Rename or remove local vars to avoid shadowing.
9710023e 9067 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9068
a415e694
PE
9069 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9070 avoid shadowing.
9071
8ef4622d
PE
9072 * lisp.h (eassert): Check that the argument compiles, even if
9073 ENABLE_CHECKING is not defined.
9074
946f9a5b
PE
9075 * data.c (Findirect_variable): Name an expression, to avoid
9076 gcc -Wbad-function-cast warning.
112396d6 9077 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9078 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9079 (Fmake_variable_buffer_local, Fmake_local_variable):
9080 Mark variables as initialized.
52746918 9081 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9082
e5aab7e7 9083 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9084 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9085 Rename locals to avoid shadowing.
dff45157
PE
9086 (mark_stack): Move local variables into the #ifdef region where
9087 they're used.
7bc26fdb
PE
9088 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9089 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9090 needed otherwise.
9091 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9092 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9093 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9094
e5aab7e7
PE
9095 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9096 avoids undefined behavior in theory.
9097
4da60324
PE
9098 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9099
88043301
PE
9100 Use functions, not macros, for up- and down-casing (Bug#8254).
9101 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9102 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9103 to use the following functions instead of these macros.
9104 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9105 EMACS_INT, since callers assume the returned value fits in int.
9106 (upcase1): Likewise, for UPCASE_TABLE.
9107 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9108 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9109 the race-condition problem in the old DOWNCASE.
88043301 9110
19ed5445
PE
9111 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9112 Rename locals to avoid shadowing.
9113 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9114 (regex_compile, re_search_2, re_match_2_internal):
9115 Remove unused local vars.
952db0d7
PE
9116 (FREE_VAR): Rewrite so as not to use empty "else",
9117 which gcc can warn about.
da053e48 9118 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9119 (RETALLOC_IF): Define only if needed.
9120 (WORDCHAR_P): Likewise. This one is never needed, but is used
9121 only in a comment talking about a compiler bug, so put inside
9122 the #if 0 of that comment.
9123 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9124 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9125 Remove; unused.
19ed5445 9126
1f3561e4 9127 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9128 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9129 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9130
ded6f8f7
PE
9131 * search.c (simple_search): Remove unused var.
9132
dbd37a95
PE
9133 * dired.c (compile_pattern): Move decl from here ...
9134 * lisp.h: ... to here, so that it can be checked.
9135 (struct re_registers): New forward decl.
9136
7e47afad
PE
9137 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9138
85f24f61
PE
9139 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9140 All uses changed.
9141 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9142 Rename locals to avoid shadowing.
5671df8f 9143 (Fvertical_motion): Mark locals as initialized.
85f24f61 9144
181aa2be 9145 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9146 (casify_region): Mark local as initialized.
181aa2be 9147
930d429c
PE
9148 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9149
7082eac6
PE
9150 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9151 New macros, so that the caller can use some names other than
9152 gcpro1, gcpro2, etc.
9153 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9154 of the new macros.
9155 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9156 argument, for consistency with GCPRO2_VAR, etc: it is now the
9157 prefix of the variable, not the variable itself. All uses
9158 changed.
38b2c076
PE
9159 * dired.c (directory_files_internal, file_name_completion):
9160 Rename locals to avoid shadowing.
9161
15206ed9
PE
9162 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9163 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9164 dired.c's scmp function, had undefined behavior.
9165 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9166 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9167 * buffer.h: ... to here, because these macros use current_buffer,
9168 and the new implementation with inline functions needs to have
9169 current_buffer in scope now, rather than later when the macros
9170 are used.
9171 (downcase, upcase1): New static inline functions.
9172 (DOWNCASE, UPCASE1): Reimplement using these functions.
9173 This avoids undefined behavior in expressions like
9174 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9175 from race conditions in accessing the global variables
9176 case_temp1 and case_temp2.
9177 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9178 * lisp.h (case_temp1, case_temp2): Remove their decls.
9179 * character.h (ASCII_CHAR_P): Move from here ...
9180 * lisp.h: ... to here, so that the inline functions mentioned
9181 above can use them.
9182
4a6bea26
PE
9183 * dired.c (directory_files_internal_unwind): Now static.
9184
f14b7e14
PE
9185 * fileio.c (file_name_as_directory, directory_file_name):
9186 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9187 Now static.
2893f146
PE
9188 (file_name_as_directory): Use const pointers when appropriate.
9189 (Fexpand_file_name): Likewise. In particular, newdir might
9190 point at constant storage, so make it a const pointer.
fd4ead52 9191 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9192 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9193 signedness issues.
f839df0c
PE
9194 (Fset_file_times, Finsert_file_contents, auto_save_error):
9195 Rename locals to avoid shadowing.
f14b7e14 9196
5716756e 9197 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9198 (Ftry_completion, Fall_completions): Rename or remove locals
9199 to avoid shadowing.
5716756e 9200
b4c3046a
PE
9201 * marker.c (bytepos_to_charpos): Remove; unused.
9202
b45db522
PE
9203 * lisp.h (verify_bytepos, count_markers): New decls,
9204 so that gcc does not warn that these functions aren't declared.
9205
85876d07
PE
9206 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9207 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9208 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9209 (copy_text): Remove unused local var.
85876d07 9210
03d78a21 9211 * filelock.c (within_one_second): Now static.
b3dd38ab 9212 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9213
5df8f01b
PE
9214 * buffer.c (fix_overlays_before): Mark locals as initialized.
9215 (fix_start_end_in_overlays): Likewise. This function should be
9216 simplified by using pointers-to-pointers, but that's a different
9217 matter.
b1d876f1 9218 (switch_to_buffer_1): Now static.
8f54f30a
PE
9219 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9220 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9221
a70072c9 9222 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9223 Fix pointer signedness issue.
edced198
PE
9224 (sys_subshell): Mark local as volatile if checking for lint,
9225 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9226 (MAXPATHLEN): Define only if needed.
a70072c9 9227
a0977c44
PE
9228 * process.c (serial_open, serial_configure): Move decls from here ...
9229 * systty.h: ... to here, so that they can be checked.
9230
a884fdcc
PE
9231 * fns.c (get_random, seed_random): Move extern decls from here ...
9232 * lisp.h: ... to here, so that they can be checked.
9233
604efe86 9234 * sysdep.c (reset_io): Now static.
b8950c94 9235 (wait_for_termination_signal): Remove; unused.
604efe86 9236
38fc62d9
PE
9237 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9238 (copy_keymap_item, append_key, push_text_char_description):
9239 Now static.
1004a21a 9240 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9241 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9242 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9243 (describe_map_tree):
9244 Rename locals to avoid shadowing.
38fc62d9 9245
2f2650da
PE
9246 * keyboard.c: Declare functions static if they are not used elsewhere.
9247 (echo_char, echo_dash, cmd_error, top_level_2):
9248 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9249 (read_char, kbd_buffer_get_event, make_lispy_position):
9250 (make_lispy_event, make_lispy_movement, apply_modifiers):
9251 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9252 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9253 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9254 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9255 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9256
a053e86c 9257 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9258 (mark_kboards): Move decl here ...
9259 * alloc.c (mark_kboards): ... from here.
a053e86c 9260
4752793e
PE
9261 * lisp.h (force_auto_save_soon): New decl.
9262
74f10ca7 9263 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9264 (DEFINE_DUMMY_FUNCTION): New macro.
9265 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9266 Use it.
c03cd23f
PE
9267 (main): Add casts to avoid warnings
9268 if GCC considers string literals to be constants.
74f10ca7 9269
022e70d4
PE
9270 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9271
59d6fe83
PE
9272 * dbusbind.c: Pointer signedness fixes.
9273 (xd_signature, xd_append_arg, xd_initialize):
9274 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9275 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9276 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9277 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9278
78320123
PE
9279 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9280 if GCC considers string literals to be constants.
49cebcca 9281 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9282
35ac2a97
SM
92832011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9284
fb103ca9
SM
9285 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9286 (print_preprocess, print_object): New macro to fix last change.
9287
35ac2a97
SM
9288 * print.c (print_preprocess): Don't forget font objects.
9289
62973b41
JB
92902011-03-16 Juanma Barranquero <lekktu@gmail.com>
9291
9292 * emacs.c (USAGE3): Doc fixes.
9293
0e48bb22
AS
92942011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9295
9296 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9297 structure.
9298
7684e57b
JB
92992011-03-14 Juanma Barranquero <lekktu@gmail.com>
9300
9301 * lisp.h (VWindow_system, Qfile_name_history):
9302 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9303 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9304 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9305
9306 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9307 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9308
9309 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9310 * w32console.c (detect_input_pending, read_input_pending)
9311 (encode_terminal_code):
9312 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9313 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9314 (w32_system_caret_y, Qfile_name_history):
9315 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9316 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9317 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9318 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9319 * w32proc.c (Qlocal, report_file_error):
9320 * w32term.c (Vwindow_system, updating_frame):
9321 * w32uniscribe.c (initialized, uniscribe_font_driver):
9322 Remove unneeded extern declarations.
9323
2aa46d6c
CY
93242011-03-14 Chong Yidong <cyd@stupidchicken.com>
9325
c96bbc66 9326 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9327
cffc6f3b
CY
93282011-03-13 Chong Yidong <cyd@stupidchicken.com>
9329
9330 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9331 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9332 These macros can no longer be used for assignment.
9333
44f230aa
SM
9334 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9335 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9336 (record_buffer_markers, fetch_buffer_markers): New functions for
9337 recording and fetching special buffer markers.
9338 (set_buffer_internal_1, set_buffer_temp): Use them.
9339
9340 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9341
9342 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9343
9344 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9345 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9346
9347 * xdisp.c (hscroll_window_tree):
9348 (reconsider_clip_changes): Use PT instead of BUF_PT.
9349
d251f04b
EZ
93502011-03-13 Eli Zaretskii <eliz@gnu.org>
9351
9352 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9353 $(EMACS_ROOT)/lib/intprops.h.
9354
f0c77cd1
PE
93552011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9356
3eca4629
PE
9357 Fix more problems found by GCC 4.5.2's static checks.
9358
7c86ee98
PE
9359 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9360 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9361 (xg_free_frame_widgets): Make it clear that a local variable is
9362 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9363 (gdk_window_get_screen): Make it clear that this macro is needed
9364 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9365 (int_gtk_range_get_value): New function, which avoids a diagnostic
9366 from gcc -Wbad-function-cast.
9367 (xg_set_toolkit_scroll_bar_thumb): Use it.
9368 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9369 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9370 (get_utf8_string, xg_get_file_with_chooser):
9371 Rename locals to avoid shadowing.
9372 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9373
41729b81
PE
9374 * xgselect.c (xg_select): Remove unused var.
9375
f0c77cd1
PE
9376 * image.c (four_corners_best): Mark locals as initialized.
9377 (gif_load): Initialize transparent_p to zero (Bug#8238).
9378 Mark another local as initialized.
ec6cf4c6 9379 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9380
ce0ad53d 9381 * image.c (clear_image_cache): Now static.
d5d5a617 9382 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9383 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9384 (x_edge_detection): Remove unnecessary cast that
9385 gcc -Wbad-function-cast diagnoses.
2037898d 9386 (gif_load): Fix pointer signedness.
6ae141d6
PE
9387 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9388 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9389
33383987 93902011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9391
d32df629
PE
9392 Improve quality of tests for time stamp overflow.
9393 For example, without this patch (encode-time 0 0 0 1 1
9394 1152921504606846976) returns the obviously-bogus value (-948597
9395 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9396 reports time overflow. See
9397 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9398 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9399 * editfns.c: Include limits.h and intprops.h.
9400 (TIME_T_MIN, TIME_T_MAX): New macros.
9401 (time_overflow): Move earlier, to before first use.
9402 (hi_time, lo_time): New functions, for an accurate test for
9403 out-of-range times.
9404 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9405 (Fget_internal_run_time): Don't assume time_t fits in int.
9406 (make_time): Use list2 instead of Fcons twice.
9407 (Fdecode_time): More accurate test for out-of-range times.
9408 (check_tm_member): New function.
9409 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9410 (lisp_time_argument): Don't rely on undefined left-shift and
9411 right-shift behavior when checking for time stamp overflow.
8be6f318 9412
fe31d94c
PE
9413 * editfns.c (time_overflow): New function, refactoring common code.
9414 (Fformat_time_string, Fdecode_time, Fencode_time):
9415 (Fcurrent_time_string): Use it.
9416
8be6f318
PE
9417 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9418 * dired.c (make_time): Move to ...
9419 * editfns.c (make_time): ... here.
9420 * systime.h: Note the move.
9421
09d9db2c 94222011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9423
126bc0dc
YM
9424 * fringe.c (update_window_fringes): Remove unused variables.
9425
c47cbdfd
YM
9426 * unexmacosx.c (copy_data_segment): Also copy __got section.
9427 (Bug#8223)
9428
7ac80be9
EZ
94292011-03-12 Eli Zaretskii <eliz@gnu.org>
9430
c96bbc66 9431 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9432 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9433 Constify `char *' arguments and their references according to
9434 prototypes in tparam.h.
9435
ecb0f94d 9436 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9437
7ac80be9
EZ
9438 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9439 Adapt all references accordingly.
9440
9441 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9442
ef1fd07e
TT
94432011-03-11 Tom Tromey <tromey@redhat.com>
9444
9445 * buffer.c (syms_of_buffer): Remove obsolete comment.
9446
7ef4b50c
EZ
94472011-03-11 Eli Zaretskii <eliz@gnu.org>
9448
9449 * termhooks.h (encode_terminal_code): Declare prototype.
9450
9451 * msdos.c (encode_terminal_code): Don't declare prototype.
9452
9453 * term.c (encode_terminal_code): Now external again, used by
9454 w32console.c and msdos.c.
9455
44f230aa
SM
9456 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9457 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9458
4b1ec863 94592011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9460
1714f52b 9461 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9462
4b1ec863
PE
9463 * fringe.c (update_window_fringes): Mark locals as initialized
9464 (Bug#8227).
9465 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9466
524c7aa6
PE
9467 * alloc.c (mark_fringe_data): Move decl from here ...
9468 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9469 to check its interface.
9470 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9471
a5c0af81 9472 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9473 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9474 (fontset_font): Mark local as initialized.
a9a06e0b 9475 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9476
b4716021
PE
9477 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9478
811e9bac 9479 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9480 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9481 (x_own_selection, Fx_disown_selection_internal): Rename locals
9482 to avoid shadowing.
9483 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9484
7e3ab302
PE
9485 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9486 so that the caller can use some name other than gcpro1.
9487 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9488 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9489 (Fx_backspace_delete_keys_p):
9490 Use them to avoid shadowing, and rename vars to avoid shadowing.
9491 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9492 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9493 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9494 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9495 Remove unused locals.
7e3ab302
PE
9496 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9497 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9498 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9499 macros.
f78faa98 9500
e2b13473
PE
9501 * xterm.h (x_mouse_leave): New decl.
9502
77f23912
PE
9503 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9504 Remove unused functions.
cdf4ba58
PE
9505 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9506 (x_calc_absolute_position): Now static.
7411c686 9507 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9508 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9509 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9510 unless they are used.
38d0b34a
PE
9511 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9512 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9513 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9514 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9515 (x_error_catcher, x_connection_closed, x_error_handler):
9516 (x_error_quitter, xembed_send_message, x_iconify_frame):
9517 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9518 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9519 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9520
44f230aa
SM
9521 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9522 Rename or move locals to avoid shadowing.
6b463e58 9523 (tty_defined_color, merge_face_heights): Now static.
5967d051 9524 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9525 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9526 does not deduce is never used uninitialized.
73719eba
PE
9527 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9528 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9529
426994c3 9530 * terminal.c (store_terminal_param): Now static.
5489860b 9531
032f1620 9532 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9533 (set_frame_menubar): Remove unused local.
d4323972 9534 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9535 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9536 since they might point to immutable storage.
281585b0
PE
9537 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9538 since it's unused otherwise.
032f1620 9539
367c19e5 9540 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9541 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9542 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9543 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9544 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9545 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9546 does not deduce are never used uninitialized.
70739cbe 9547
07b48fa9
PE
9548 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9549
8868a238 9550 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9551 * window.c (window_loop, size_window):
9552 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9553
7e5cf297 9554 * window.c (display_buffer): Now static.
d6550a9f
PE
9555 (size_window): Mark variables that gcc -Wuninitialized
9556 does not deduce are never used uninitialized.
a586633d
PE
9557 * window.h (check_all_windows): New decl, to forestall
9558 gcc -Wmissing-prototypes diagnostic.
5b555da1 9559 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9560
f6095868
PE
9561 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9562 shadowing.
9563 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9564 Include <limits.h>.
9565 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9566 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9567 (load_charset_map): Mark variables that gcc -Wuninitialized
9568 does not deduce are never used uninitialized.
53df7c11 9569 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9570
f38b440c
PE
9571 * coding.c (coding_set_source, coding_set_destination):
9572 Use "else { /* comment */ }" rather than "else /* comment */;"
9573 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9574 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9575 a block, when the outer 'i' will do.
9576 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9577 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9578 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9579 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9580 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9581 Rename locals to avoid shadowing.
9582 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9583 * coding.c (emacs_mule_char, encode_invocation_designation):
9584 Now static, since they're not used elsewhere.
413bb2db 9585 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9586 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9587 (decode_coding_emacs_mule): Mark variables that gcc
9588 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9589 (detect_coding_iso_2022): Initialize a local variable that might
9590 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9591 this initialization is needed. (Bug#8211)
5f58e762
PE
9592 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9593 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9594 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9595 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9596 Remove unused macros.
f38b440c 9597
232b38b9 9598 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9599 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9600 * character.c (string_count_byte8): Likewise.
232b38b9 9601
fb90da1b
PE
9602 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9603 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9604
fb93dbc2
PE
9605 * chartab.c (copy_sub_char_table): Now static, since it's not used
9606 elsewhere.
5c156ace
PE
9607 (sub_char_table_ref_and_range, char_table_ref_and_range):
9608 Rename locals to avoid shadowing.
bbcd0949 9609 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9610
7d3b3862 9611 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9612 (BIDI_BOB): Remove unused macro.
7d3b3862 9613
6be7d3da
PE
9614 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9615 deduce are never used uninitialized.
c2ed9c8b 9616 * term.c (encode_terminal_code): Likewise.
6be7d3da 9617
75f8807f 9618 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9619
50938595
PE
9620 * tparam.h: New file.
9621 * term.c, tparam.h: Include it.
9622 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9623 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9624 Move these decls to tparam.h, and make them agree with what
9625 is actually in tparam.c. The previous trick of using incompatible
9626 decls in different modules does not conform to the C standard.
9627 All callers of tparam changed to use tparam's actual API.
9628 * tparam.c (tparam1, tparam, tgoto):
9629 Use const pointers where appropriate.
9630
fbceeba2
PE
9631 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9632 * cm.h (struct cm): Likewise.
9633 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9634 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9635 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9636 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9637 (turn_on_face, init_tty): Likewise.
9638 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9639
7f3f1250
PE
9640 * term.c (term_mouse_position): Rename local to avoid shadowing.
9641
e6ca6543
PE
9642 * alloc.c (mark_ttys): Move decl from here ...
9643 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9644
c40f8d15
AS
96452011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9646
9647 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9648
cfe0661d
JB
96492011-03-09 Juanma Barranquero <lekktu@gmail.com>
9650
9651 * search.c (compile_pattern_1): Remove argument regp, unused since
9652 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9653 (compile_pattern): Don't pass it.
9654
0afb4571
J
96552011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9656
9657 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9658 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9659 for ! HAVE_GTK3.
9660 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9661
9662 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9663
9664 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9665 gdk_window_get_screen, gdk_window_get_geometry,
9666 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9667 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9668 (xg_get_pixbuf_from_pixmap): New function.
9669 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9670 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9671 Call xg_get_pixbuf_from_pixmap instead of
9672 gdk_pixbuf_get_from_drawable.
9673 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9674 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9675 (xg_check_special_colors): Use GtkStyleContext and its functions
9676 for HAVE_GTK3.
9677 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9678 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9679 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9680 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9681 Call gtk_widget_get_preferred_size.
0afb4571
J
9682 (xg_frame_resized): gdk_window_get_geometry only takes 5
9683 parameters.
44f230aa
SM
9684 (xg_win_to_widget, xg_event_is_for_menubar):
9685 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9686 (xg_set_widget_bg): New function.
9687 (delete_cb): New function.
895009e1 9688 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9689 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9690 (xg_set_background_color): Call xg_set_widget_bg.
9691 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9692 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9693 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9694 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9695 if ! HAVE_GTK3.
9696 (update_frame_tool_bar): Call gtk_widget_hide.
9697 (xg_initialize): Use GDK_KEY_g.
9698
9699 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9700 if ! HAVE_GTK3
9701 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9702
9703 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9704 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9705 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9706
1c2cc4ef
JB
97072011-03-08 Juanma Barranquero <lekktu@gmail.com>
9708
9709 * w32xfns.c (select_palette): Check success of RealizePalette against
9710 GDI_ERROR, not zero.
9711
33383987 9712See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9713
9714;; Local Variables:
9715;; coding: utf-8
aac0c6e3
MR
9716;; End:
9717
acaf905b 9718 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9719
9720 This file is part of GNU Emacs.
9721
9722 GNU Emacs is free software: you can redistribute it and/or modify
9723 it under the terms of the GNU General Public License as published by
9724 the Free Software Foundation, either version 3 of the License, or
9725 (at your option) any later version.
9726
9727 GNU Emacs is distributed in the hope that it will be useful,
9728 but WITHOUT ANY WARRANTY; without even the implied warranty of
9729 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9730 GNU General Public License for more details.
9731
9732 You should have received a copy of the GNU General Public License
9733 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.