* minibuf.c: Make symbols static if they're not exported.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
93ea6e8f
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
1717ede2
PE
3 * minibuf.c: Make symbols static if they're not exported.
4 (minibuf_save_list, choose_minibuf_frame): Now static.
5 * lisp.h (choose_minibuf_frame): Remove decl.
6
fa5fb2bc
PE
7 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8
1e3890d1
PE
9 * lread.c: Make symbols static if they're not exported.
10 (read_objects, initial_obarray, oblookup_last_bucket_number):
11 Now static.
12 (make_symbol): Remove; unused.
13 * lisp.h (initial_obarray, make_symbol): Remove decls.
14
8a1414fa
PE
15 * keyboard.c: Make symbols static if they're not exported.
16 (single_kboard, recent_keys_index, total_keys, recent_keys):
17 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
18 (this_single_command_key_start, echoing, last_auto_save):
19 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
20 (command_loop, echo_now, keyboard_init_hook, help_char_p):
21 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
22 (Vlispy_mouse_stem, double_click_count):
23 Now static.
24 (force_auto_save_soon): Define only if SIGDANGER.
25 (ignore_mouse_drag_p): Now static if
26 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
27 (print_help): Remove; unused.
28 (stop_character, last_timer_event): Mark as externally visible.
29 * keyboard.h (ignore_mouse_drag_p): Declare only if
30 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
31 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
32 * lisp.h (echoing): Remove decl.
33 (force_auto_save_soon): Declare only if SIGDANGER.
34 * xdisp.c (redisplay_window): Simplify code, to make it more
35 obvious that ignore_mouse_drag_p is not accessed if !defined
36 USE_GTK && !defined HAVE_NS.
37
93ea6e8f
PE
38 * intervals.c: Make symbols static if they're not exported.
39 (merge_properties_sticky, merge_interval_right, delete_interval):
40 Now static.
41 * intervals.h (merge_interval_right, delete_interval): Remove decls.
42
b532497d
PE
432011-04-13 Paul Eggert <eggert@cs.ucla.edu>
44
77382fcc
PE
45 * insdel.c: Make symbols static if they're not exported.
46 However, leave prepare_to_modify_buffer alone. It's never
47 called from outside this function, but that appears to be a bug.
48 (combine_after_change_list, combine_after_change_buffer):
4889fc82 49 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
50 (adjust_after_replace_noundo): Remove; unused.
51 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 52 (signal_before_change): Remove decls.
77382fcc 53
9306c32e
PE
54 * indent.c (val_compute_motion, val_vmotion): Now static.
55
cd44d2eb
PE
56 * image.c: Make symbols static if they're not exported.
57 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
58 if USE_GTK.
59 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
60 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
61
ad9a7a06
PE
62 * fringe.c (standard_bitmaps): Now static.
63 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
64
81626931
PE
65 * frame.c: Make symbols static if they're not exported.
66 (x_report_frame_params, make_terminal_frame): Now static.
67 (get_frame_param): Now static, unless HAVE_NS.
68 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
69 (x_get_resource_string): Remove; not used.
70 * frame.h (make_terminal_frame, x_report_frame_params):
71 (x_get_resource_string); Remove decls.
72 (x_fullscreen_adjust): Declare only if WINDOWSNT.
73 * lisp.h (get_frame_param): Declare only if HAVE_NS.
74
239f9db9
PE
75 * font.c, fontset.c: Make symbols static if they're not exported.
76 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
77 (FACE_SUITABLE_FOR_CHAR_P): Use it.
78 * font.c (font_close_object): Now static.
79 * font.h (font_close_object): Remove.
80 * fontset.c (FONTSET_OBJLIST): Remove.
81 (free_realized_fontset) #if-0 the body, which does nothing.
82 (face_suitable_for_char_p): #if-0, as it's never called.
83 * fontset.h (face_suitable_for_char_p): Remove decl.
84 * xfaces.c (face_at_string_position): Use
85 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
86 since 0 is always ASCII.
87
dfcf3579
PE
88 * fns.c (weak_hash_tables): Now static.
89
5045092b
PE
90 * fileio.c: Make symbols static if they're not exported.
91 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
92 (Vwrite_region_annotation_buffers): Now static.
93
57a96f5c
PE
94 * eval.c: Make symbols static if they're not exported.
95 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
96 * lisp.h (backtrace_list): Remove decl.
97
35f08c38
PE
98 * emacs.c: Make symbols static if they're not exported.
99 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
100 (fatal_error_code, fatal_error_signal_hook, standard_args):
101 Now static.
102 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
103 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
104 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
105 * lisp.h (fatal_error_signal_hook): Remove decl.
106 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
107
f44bd759
PE
108 * editfns.c: Move a (normally-unused) function to its only use.
109 * editfns.c, lisp.h (get_operating_system_release): Remove.
110 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
111 worth the hassle of breaking this out.
112
b532497d
PE
113 * xterm.c: Make symbols static if they're not exported.
114 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
115 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
116 (x_destroy_window, x_delete_display):
117 Now static.
118 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
119 (x_mouse_leave): Remove; unused.
120 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
121 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
122 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
123 Remove decls.
124 (x_mouse_leave): Declare only if WINDOWSNT.
125 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
126 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
127 USE_X_TOOLKIT.
128
a25f4dfa
PE
1292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
130
1675728f
PE
131 * ftxfont.c: Make symbols static if they're not exported.
132 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
133 HAVE_FREETYPE.
134 * font.h (ftxfont_driver): Likewise.
135
e4cebfca
PE
136 * xfns.c: Make symbols static if they're not exported.
137 (x_last_font_name, x_display_info_for_name):
138 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
139 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
140 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
141 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
142 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
143 (last_show_tip_args): Now static.
144 (xic_defaut_fontset, xic_create_fontsetname): Define only if
145 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
146 (x_screen_planes): Remove; unused.
147 * dispextern.h (x_screen_planes): Remove decl.
148
5bf46f05
PE
149 * dispnew.c: Make symbols static if they're not exported.
150 * dispextern.h (redraw_garbaged_frames, scrolling):
151 (increment_row_positions): Remove.
152 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
153 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
154 Now static.
155 (redraw_garbaged_frames): Remove; unused.
156
435f4c28
PE
157 * xfaces.c: Make symbols static if they're not exported.
158 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
159 Remove decls.
160 * xterm.h (defined_color): Remove decls.
161 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
162 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
163 (menu_face_changed_default, defined_color, free_realized_face):
164 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
165 (ascii_face_of_lisp_face): Remove; unused.
166
8524aef3
PE
167 * xdisp.c: Make symbols static if they're not exported.
168 * dispextern.h (scratch_glyph_row, window_box_edges):
169 (glyph_to_pixel_coords, set_cursor_from_row):
170 (get_next_display_element, set_iterator_to_next):
171 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
172 (show_mouse_face): Remove decls
173 * frame.h (message_buf_print): Likewise.
174 * lisp.h (pop_message, set_message, check_point_in_composition):
175 Likewise.
176 * xterm.h (set_vertical_scroll_bar): Likewise.
177 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
178 (message_buf_print, scratch_glyph_row, displayed_buffer):
179 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
180 (get_next_display_element, show_mouse_face, window_box_edges):
181 (frame_to_window_pixel_xy, check_point_in_composition):
182 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
183 (glyph_to_pixel_coords): Remove; unused.
184
16390cd2
PE
185 * dired.c (file_name_completion): Now static.
186
187 * dbusbind.c (xd_in_read_queued_messages): Now static.
188
a25f4dfa
PE
189 * lisp.h (circular_list_error, FOREACH): Remove; unused.
190 * data.c (circular_list_error): Remove.
191
16a97296
PE
1922011-04-11 Paul Eggert <eggert@cs.ucla.edu>
193
14a9c8df
PE
194 * commands.h (last_point_position, last_point_position_buffer):
195 (last_point_position_window): Remove decls.
196 * keyboard.c: Make these variables static.
197
74ab6df5
PE
198 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
199 decls.
200 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
201 (iso_code_class, detect_coding, code_convert_region): Now static.
202 (encode_coding_gap): Remove; unused.
203
38dfbee1
PE
204 * chartab.c (chartab_chars, chartab_bits): Now static.
205
a2cb4e63
PE
206 * charset.h (charset_iso_8859_1): Remove decl.
207 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
208 Now static.
209
127198fd
PE
210 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
211 * ccl.c (Vccl_program_table): Now static.
212 (check_ccl_update): Remove; unused.
213
d85b608f
PE
214 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
215 * category.h: ... from here.
216 * category.c (check_category_table, set_category_set): Now static.
217
31cd66f3
PE
218 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
219 * lisp.h: Remove these decls.
220
c358e587
PE
221 * buffer.c (buffer_count): Remove unused var.
222
e78aecca
PE
223 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
224 so that it's not optimized away.
225 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
226 * dispextern.h (bidi_dump_cached_states): Remove, since it's
227 exported only to the debugger.
228
e192d7d3
PE
229 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
230 * atimer.h (run_all_atimers): Removed; not exported.
231
92470028
PE
232 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
233 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
234 was inaccessible from Lisp.
235 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
236 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
237
244ed907
PE
238 alloc.c: Import and export fewer symbols, and remove unused items.
239 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
240 is defined.
241 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
242 it's not optimized away by whole-program optimization.
243 (message_enable_multibyte, free_misc): Remove.
244 (catchlist, handlerlist, mark_backtrace):
245 Declare only if BYTE_MARK_STACK.
246 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
247 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
248 (message_enable_multibyte): Remove decl.
249 (free_misc, interval_free_list, float_block, float_block_index):
250 (n_float_blocks, float_free_list, cons_block, cons_block_index):
251 (cons_free_list, last_marked_index):
252 Now static.
253 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
254 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
255 (mark_backtrace): Define only if BYTE_MARK_STACK.
256 * xdisp.c (message_enable_multibyte): Now static.
257
955cbe7b
PE
258 Declare Lisp_Object Q* variables to be 'static' if not exproted.
259 This makes it easier for human readers (and static analyzers)
260 to see whether these variables are used from other modules.
261 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
262 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
263 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
264 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
265 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
266 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
267 * xmenu.c, xselect.c:
268 Declare Q* vars static if they are not used in other modules.
269 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
270 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
271 Remove decls of unexported vars.
272 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
273
95c82688
PE
274 * lisp.h (DEFINE_FUNC): Make sname 'static'.
275
16a97296
PE
276 Make Emacs functions such as Fatom 'static' by default.
277 This makes it easier for human readers (and static analyzers)
278 to see whether these functions can be called from other modules.
279 DEFUN now defines a static function. To make the function external
280 so that it can be used in other C modules, use the new macro DEFUE.
281 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
282 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
283 static function definition. Use DEFUE if you want an extern one.
284 (DEFUE, INFUN): New macros.
285 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
286 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
287 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
288 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
289 Remove decls, since these functions are now static.
290 (Funintern, Fget_internal_run_time): New decls, since these functions
291 were already external.
95c82688 292
16a97296
PE
293 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
294 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
295 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
296 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
297 * keyboard.c, keymap.c, lread.c:
298 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
299 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
300 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
301 Mark functions with DEFUE instead of DEFUN,
302 if they are used in other modules.
303 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
304 decls for now-static functions.
305 * buffer.h (Fdelete_overlay): Remove decl.
306 * callproc.c (Fgetenv_internal): Mark as internal.
307 * composite.c (Fremove_list_of_text_properties): Remove decl.
308 (Fcomposition_get_gstring): New forward static decl.
309 * composite.h (Fcomposite_get_gstring): Remove decl.
310 * dired.c (Ffile_attributes): New forward static decl.
311 * doc.c (Fdocumntation_property): New forward static decl.
312 * eval.c (Ffetch_bytecode): New forward static decl.
313 (Funintern): Remove extern decl; now in .h file where it belongs.
314 * fileio.c (Fmake_symbolic_link): New forward static decl.
315 * image.c (Finit_image_library): New forward static decl.
316 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
317 * intervals.h (Fprevious_property_change):
318 (Fremove_list_of_text_properties): Remove decls.
319 * keyboard.c (Fthis_command_keys): Remove decl.
320 (Fcommand_execute): New forward static decl.
321 * keymap.c (Flookup_key): New forward static decl.
322 (Fcopy_keymap): Now static.
323 * keymap.h (Flookup_key): Remove decl.
324 * process.c (Fget_process): New forward static decl.
325 (Fprocess_datagram_address): Mark as internal.
326 * syntax.c (Fsyntax_table_p): New forward static decl.
327 (skip_chars): Remove duplicate decl.
328 * textprop.c (Fprevious_property_change): New forward static decl.
329 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
330 Now internal.
331 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
332 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
333
785bbd42
PE
3342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
335
336 * editfns.c (Fformat): Remove unreachable code.
337
4073e537 3382011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 339
b2ded58d
PE
340 Fix more problems found by GCC 4.6.0's static checks.
341
7d66342c
PE
342 * xdisp.c (vmessage): Use a better test for character truncation.
343
bbf47d44
PE
344 * charset.c (load_charset_map): <, not <=, for optimization,
345 and to avoid potential problems with integer overflow.
9248994d 346 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 347 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 348 * editfns.c (Fformat): Likewise.
1e69125e 349 * syntax.c (skip_chars): Likewise.
3befa583 350
e3019616
PE
351 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
352 This also lets GCC 4.6.0 generate slightly better loop code.
353
becfa255
PE
354 * callint.c (Fcall_interactively): <, not <=, for optimization.
355 (Fcall_interactively): Count the number of arguments produced,
356 not the number of arguments given. This is simpler and lets GCC
357 4.6.0 generate slightly better code.
358
dae0cd48
PE
359 * ftfont.c: Distingish more carefully between FcChar8 and char.
360 The previous code passed unsigned char * to a functions like
361 strlen and xstrcasecmp that expect char *, which does not
362 conform to the C standard.
363 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
364 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
365 char * when the C standard requires it.
366
76032d70
PE
367 * keyboard.c (read_char): Remove unused var.
368
eb3f1cc8
PE
369 * eval.c: Port to Windows vsnprintf (Bug#8435).
370 Include <limits.h>.
371 (SIZE_MAX): Define if the headers do not.
372 (verror): Do not give up if vsnprintf returns a negative count.
373 Instead, grow the buffer. This ports to Windows vsnprintf, which
374 does not conform to C99. Problem reported by Eli Zaretskii.
375 Also, simplify the allocation scheme, by avoiding the need for
376 calling realloc, and removing the ALLOCATED variable.
377
70476b54
PE
378 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
379
12020a9e
PE
380 Remove invocations of doprnt, as Emacs now uses vsnprintf.
381 But keep the doprint source code for now, as we might revamp it
382 and use it again (Bug#8435).
ea6c7ae6
PE
383 * lisp.h (doprnt): Remove.
384 * Makefile.in (base_obj): Remove doprnt.o.
385 * deps.mk (doprnt.o): Remove.
386
5fdb398c
PE
387 error: Print 32- and 64-bit integers portably (Bug#8435).
388 Without this change, on typical 64-bit hosts error ("...%d...", N)
389 was used to print both 32- and 64-bit integers N, which relied on
390 undefined behavior.
391 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
392 New macro.
393 * lisp.h (error, verror): Mark as printf-like functions.
394 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
395 Report overflow in size calculations when allocating printf buffer.
396 Do not truncate output string at its first null byte.
397 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
398 Truncate the output at a character boundary, since vsnprintf does not
399 do that.
400 * charset.c (check_iso_charset_parameter): Convert internal
401 character to string before calling 'error', since %c now has the
402 printf meaning.
403 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
404 overflow when computing char to be passed to 'error'. Do not
405 pass Lisp_Object to 'error'; pass the integer instead.
406 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
407 formatted with plain %d.
408
b189fa66
PE
409 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
410
bff87ef0
PE
411 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
412
7e2cac20
PE
413 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
414
ce4d90b5
PE
415 * xterm.c (x_catch_errors): Remove duplicate declaration.
416
266c9547
PE
417 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
418
79c49ad2
PE
419 * xdisp.c, lisp.h (message_nolog): Remove; unused.
420
368f4090
JM
4212011-04-10 Jim Meyering <meyering@redhat.com>
422
423 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
424 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
425 return ssize_t not "int", and use size_t as the buffer length.
426 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
427 * gnutls.h: Update declarations.
428 * process.c (read_process_output): Use ssize_t, to match.
429 (send_process): Likewise.
430
a32d4040
CY
4312011-04-09 Chong Yidong <cyd@stupidchicken.com>
432
433 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
434
8546720e 4352011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 436
8546720e
GM
437 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
438 unsigned char, to match FcChar8 type definition.
aac0c6e3 439
8546720e
GM
440 * xterm.c (handle_one_xevent):
441 * xmenu.c (create_and_show_popup_menu):
442 * xselect.c (x_decline_selection_request)
443 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 444
a53e2e89
EZ
4452011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
446
447 Fix some uses of `int' instead of EMACS_INT.
448 * search.c (string_match_1, fast_string_match)
449 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
450 (scan_buffer, find_next_newline_no_quit)
451 (find_before_next_newline, search_command, Freplace_match)
452 (Fmatch_data): Make some `int' variables be EMACS_INT.
453
454 * xdisp.c (display_count_lines): 3rd argument and return value now
455 EMACS_INT. All callers changed.
456 (pint2hrstr): Last argument is now EMACS_INT.
457
458 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
459 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
460 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
461 (decode_coding_utf_16, decode_coding_emacs_mule)
462 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
463 (decode_coding_ccl, decode_coding_charset)
464 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
465 (decode_coding_iso_2022, decode_coding_emacs_mule)
466 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
467 <char_offset, last_offset>: Declare EMACS_INT.
468 (encode_coding_utf_8, encode_coding_utf_16)
469 (encode_coding_emacs_mule, encode_invocation_designation)
470 (encode_designation_at_bol, encode_coding_iso_2022)
471 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
472 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
473 Declare EMACS_INT.
474 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
475 (encode_invocation_designation): Last argument P_NCHARS is now
476 EMACS_INT.
477 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
478 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
479
480 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
481 All users changed.
482
483 * ccl.c (Fccl_execute_on_string): Declare some variables
484 EMACS_INT.
485
8546720e 4862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
487
488 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
489
4e19a977
CS
4902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
491
492 * process.c (Fformat_network_address): Doc fix.
493
87302331
R
4942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
495
496 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
497
cbb59342
CY
4982011-04-08 Chong Yidong <cyd@stupidchicken.com>
499
500 * keyboard.c (read_char): Call Lisp function help-form-show,
501 instead of using internal_with_output_to_temp_buffer.
502 (Qhelp_form_show): New var.
e0d38eeb 503 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
504
505 * print.c (internal_with_output_to_temp_buffer): Function deleted.
506
507 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
508
e67a13ab
CY
5092011-04-06 Chong Yidong <cyd@stupidchicken.com>
510
511 * process.c (Flist_processes): Removed to Lisp.
512 (list_processes_1): Deleted.
513
973f782d
EZ
5142011-04-06 Eli Zaretskii <eliz@gnu.org>
515
7c106b1e
EZ
516 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
517
973f782d
EZ
518 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
519
41cf7d1a 5202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 521
ca23cc88
PE
522 Fix more problems found by GCC 4.6.0's static checks.
523
f390e2d5
PE
524 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
525
42eea0d0
PE
526 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
527
b69769da 528 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 529
f9541e84
PE
530 * xdisp.c (vmessage): Mark as a printf-like function.
531
13841b55
PE
532 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
533
c136c10f
PE
534 * sound.c (sound_warning): Don't crash if arg contains a printf format.
535
5e2d4a30
PE
536 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
537 printf-like functions.
538 (tiff_load): Add casts to remove these marks before passing them
539 to system-supplied API.
540
583f48b9
PE
541 * eval.c (Fsignal): Remove excess argument to 'fatal'.
542
b25d760e
PE
543 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
544 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
545 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
546 directly, rather than having caller test rule sign. This avoids
547 some unnecessary tests.
548 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
549 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
550 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 551
bc7b6697 552 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 553 (xfont_open): Avoid unnecessary tests.
bc7b6697 554
27ccc379
PE
555 * composite.c (composition_gstring_put_cache): Use unsigned integer.
556
dcd5c89a
PE
557 * composite.h, composite.c (composition_gstring_put_cache):
558 Use EMACS_INT, not int, for length.
559
b13a45c6
PE
560 * composite.h (COMPOSITION_DECODE_REFS): New macro,
561 breaking out part of COMPOSITION_DECODE_RULE.
562 (COMPOSITION_DECODE_RULE): Use it.
563 * composite.c (get_composition_id): Remove unused local vars,
564 by using the new macro.
565
1e792e4d
PE
566 * textprop.c (set_text_properties_1): Change while to do-while,
567 since the condition is always true at first.
568
dc6c6455 569 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
570 (interval_deletion_adjustment): Return unsigned value.
571 All uses changed.
dc6c6455 572
aba7731a
PE
573 * process.c (list_processes_1, create_pty, read_process_output):
574 (exec_sentinel): Remove vars that were set but not used.
afd4052b 575 (create_pty): Remove unnecessary "volatile"s.
bc57d757 576 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 577 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 578 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 579
fdfc4bf3
PE
580 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
581
fca8fe46 582 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 583 (update_syntax_table): Use unsigned instead of int.
fca8fe46 584
06a0259a 585 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 586 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 587 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 588
e7b9e80f
PE
589 * print.c (print_error_message): Avoid int overflow.
590
56201685
PE
591 * font.c (font_list_entities): Redo for clarity,
592 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
593
78834453 594 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 595 (font_score): Avoid potential overflow in diff calculation.
78834453 596
0bc0b309 597 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 598 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 599
e610eaca
PE
600 * eval.c (funcall_lambda): Rename local to avoid shadowing.
601
b895abce
PE
602 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
603 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
604 can always succeed if overflow has undefined behavior.
605
1f1d9321 606 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 607 (wordify): Omit three unnecessary tests.
1f1d9321 608
c59478bc
PE
609 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
610 All callers changed. This avoids the need for an unused var.
611
79b73827
PE
612 * casefiddle.c (casify_region): Remove var that is set but not used.
613
a4db5dfe
PE
614 * dired.c (file_name_completion): Remove var that is set but not used.
615
43aae36e
PE
616 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
617
2a47c44d 618 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 619 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 620
a37c69bf
PE
621 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
622 Check for integer overflow on size calculations.
623
328ab8e7
PE
624 * buffer.c (Fprevious_overlay_change): Remove var that is set
625 but not used.
626
e5a2a5cb
PE
627 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
628 Remove vars that are set but not used.
8d84a6eb 629 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 630 (timer_check_2): Mark vars as initialized.
e5a2a5cb 631
a60e5f68
PE
632 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
633
f661cb61 634 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 635 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 636
f0397f5a
PE
637 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
638 that are set but not used.
639
8664db06 640 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 641 if XCreateBitmapFromData fails (Bug#8410).
8664db06 642
6abdaa4a
PE
643 * xselect.c (x_get_local_selection, x_handle_property_notify):
644 Remove vars that are set but not used.
645
0ce7538d 646 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 647 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 648
9ae848fc
PE
649 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
650 Remove var that is set but not used.
0b918413
PE
651 (scroll_bar_windows_size): Now size_t, not int.
652 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
653 Check for overflow.
9ae848fc 654
a5a62657
PE
655 * xfaces.c (realize_named_face): Remove vars that are set but not used.
656 (map_tty_color) [!defined MSDOS]: Likewise.
657
5c5cdd39
PE
658 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
659
66ebf983
PE
660 * coding.c: Remove vars that are set but not used.
661 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
662 All callers changed.
663 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
664 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
665 (decode_coding_charset): Remove vars that are set but not used.
666
1be4d761
PE
667 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
668 that is set but not used.
669
47553fa8
PE
670 * print.c (print_object): Remove var that is set but not used.
671
1f7196bf 672 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
673 The gnulib version avoids calling malloc in the usual case,
674 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
675 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
676 * filelock.c (current_lock_owner): Likewise.
677 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
678 * sysdep.c: Include allocator.h, careadlinkat.h.
679 (emacs_no_realloc_allocator): New static constant.
680 (emacs_readlink): New function.
fdb61804
PE
681 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
682 ../lib/careadlinkat.h.
d1fdcab7 683
f84c17c7
SM
6842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
685
686 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
687 first non-nil return value).
688
ef3862ad
JD
6892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
690
691 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
692 if not defined (Bug#8403).
693
376a7006
JB
6942011-04-02 Juanma Barranquero <lekktu@gmail.com>
695
696 * xdisp.c (display_count_lines): Remove parameter `start',
697 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
698 (get_char_face_and_encoding): Remove parameter `multibyte_p',
699 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
700 (fill_stretch_glyph_string): Remove parameters `row' and `area',
701 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
702 and thereabouts. All callers changed.
703 (get_per_char_metric): Remove parameter `f', unused since
704 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
705
6ca3801d
JM
7062011-04-02 Jim Meyering <meyering@redhat.com>
707
708 do not dereference NULL upon failed strdup
709 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
710 (ns_get_family): Likewise.
711
d8e2b5ba
JB
7122011-04-02 Juanma Barranquero <lekktu@gmail.com>
713
714 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
715
8c74fcbd
JD
7162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
717
718 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
719 later (Bug#8403).
720
7200d79c
SM
7212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
722
03408648 723 Add lexical binding.
7200d79c 724
03408648
SM
725 * window.c (Ftemp_output_buffer_show): New fun.
726 (Fsave_window_excursion):
727 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
728
729 * lread.c (lisp_file_lexically_bound_p): New function.
730 (Fload): Bind Qlexical_binding.
731 (readevalloop): Remove `evalfun' arg.
732 Bind Qinternal_interpreter_environment.
733 (Feval_buffer): Bind Qlexical_binding.
734 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
735 Mark as dynamic.
736 (syms_of_lread): Declare `lexical-binding'.
737
738 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
739
740 * keyboard.c (eval_dyn): New fun.
741 (menu_item_eval_property): Use it.
ca105506
SM
742
743 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 744
03408648
SM
745 * fns.c (concat, mapcar1): Accept byte-code-functions.
746
747 * eval.c (Fsetq): Handle lexical vars.
748 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
749 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
750 (FletX, Flet): Obey lexical binding.
751 (Fcommandp): Handle closures.
752 (Feval): New `lexical' arg.
753 (eval_sub): New function extracted from Feval. Use it almost
754 everywhere where Feval was used. Look up vars in lexical env.
755 Handle closures.
756 (Ffunctionp): Move from subr.el.
757 (Ffuncall): Handle closures.
758 (apply_lambda): Remove `eval_flags'.
759 (funcall_lambda): Handle closures and new byte-code-functions.
760 (Fspecial_variable_p): New function.
761 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
762 but without exporting it to Lisp.
23aba0ea 763
23aba0ea 764 * doc.c (Fdocumentation, store_function_docstring):
03408648 765 * data.c (Finteractive_form): Handle closures.
23aba0ea 766
03408648
SM
767 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
768 interactive spec.
ba83908c 769
03408648
SM
770 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
771 byte-codes.
772 (exec_byte_code): New function extracted from Fbyte_code to handle new
773 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 774
03408648 775 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 776
03408648 777 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 778
e2abce01
JB
7792011-03-31 Juanma Barranquero <lekktu@gmail.com>
780
781 * xdisp.c (redisplay_internal): Fix prototype.
782
63696a73 7832011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 784
63696a73
EZ
785 * xdisp.c (SCROLL_LIMIT): New macro.
786 (try_scrolling): Use it when setting scroll_limit. Limit
787 scrolling to 100 screen lines.
788 (redisplay_window): Even when falling back on "recentering",
789 position point in the window according to scroll-conservatively,
790 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
791
792 (try_scrolling): When point is above the window, allow searching
793 as far as scroll_max, or one screenful, to compute vertical
794 distance from PT to the scroll margin position. This prevents
795 try_scrolling from unnecessarily failing when
796 scroll-conservatively is set to a value slightly larger than the
797 window height. Clean up the case of PT below the margin at bottom
798 of window: scroll_max can no longer be INT_MAX. When aggressive
799 scrolling is in use, don't let point enter the opposite scroll
800 margin as result of the scroll.
801 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
802 threshold of 100 lines for never-recentering scrolling.
803
e4cc2dfc
JB
8042011-03-31 Juanma Barranquero <lekktu@gmail.com>
805
806 * dispextern.h (move_it_by_lines):
807 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
808 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
809 (message_log_check_duplicate): Remove parameters `prev_bol' and
810 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
811 (redisplay_internal): Remove parameter `preserve_echo_area',
812 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
813
814 * indent.c (Fvertical_motion):
815 * window.c (window_scroll_pixel_based, Frecenter):
816 Don't pass `need_y_p' to `move_it_by_lines'.
817
1c470562
SM
8182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
819
44f230aa
SM
820 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
821 steal a few bits to be more compact.
822 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
823 Remove unneeded casts.
824
1c470562
SM
825 * bytecode.c (Fbyte_code): CAR and CDR can GC.
826
888adce9
ZK
8272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
828
829 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
830 binding" message (bug#7967).
831
f838ed7b
PE
8322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
833
77861b95
PE
834 Fix more problems found by GCC 4.6.0's static checks.
835
de6dbc14
PE
836 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
837 Remove unused local var.
838
f838ed7b
PE
839 * editfns.c (Fmessage_box): Remove unused local var.
840
792c7b2b
PE
841 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
842 (note_mode_line_or_margin_highlight, note_mouse_highlight):
843 Omit unused local vars.
c499e557 844 * window.c (shrink_windows): Omit unused local var.
b01a1c29 845 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
846 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
847 Omit unused local var.
848
ba0165e1
PE
849 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
850 Don't assume string length fits in int.
32ad8845 851 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 852 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 853
3c59b4c9
PE
854 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
855 instead of alloca (Bug#8344).
856
a3eed478 857 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 858 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 859
eb4d412d
PE
860 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
861
1658b401
PE
862 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
863 concerns.
864
865 * term.c (produce_glyphless_glyph): Remove unnecessary test.
866
867 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 868
9a2c6e05
PE
869 * keyboard.c (syms_of_keyboard): Use the same style as later
870 in this function when indexing through an array. This also
871 works around GCC bug 48267.
872
03d0a109
PE
873 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
874
44f730c8
PE
875 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
876
fe75f926
PE
877 * chartab.c (sub_char_table_ref_and_range): Redo for slight
878 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
879
ffa8c828
PE
880 * keyboard.c, keyboard.h (num_input_events): Now size_t.
881 This avoids undefined behavior on integer overflow, and is a bit
882 more convenient anyway since it is compared to a size_t variable.
883
c5101a77
PE
884 Variadic C functions now count arguments with size_t, not int.
885 This avoids an unnecessary limitation on 64-bit machines, which
886 caused (substring ...) to crash on large vectors (Bug#8344).
887 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
888 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 889 All variadic functions and their callers changed accordingly.
c5101a77
PE
890 (struct gcpro.nvars): Now size_t, not int. All uses changed.
891 * data.c (arith_driver, float_arith_driver): Likewise.
892 * editfns.c (general_insert_function): Likewise.
893 * eval.c (struct backtrace.nargs, interactive_p)
894 (internal_condition_case_n, run_hook_with_args, apply_lambda)
895 (funcall_lambda, mark_backtrace): Likewise.
896 * fns.c (concat): Likewise.
897 * frame.c (x_set_frame_parameters): Likewise.
898 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
899 0 if not found, not -1. All callers changed.
900
dd3f25f7
PE
901 * alloc.c (garbage_collect): Don't assume stack size fits in int.
902 (stack_copy_size): Now size_t, not int.
903 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
904
461c2ab9
JB
9052011-03-28 Juanma Barranquero <lekktu@gmail.com>
906
907 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
908 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
909 All callers changed.
910
911 * lisp.h (multibyte_char_to_unibyte):
912 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
913 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
914 * character.h (CHAR_TO_BYTE8):
915 * cmds.c (internal_self_insert):
916 * editfns.c (general_insert_function):
917 * keymap.c (push_key_description):
918 * search.c (Freplace_match):
919 * xdisp.c (message_dolog, set_message_1): All callers changed.
920
f6d62986
SM
9212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
922
923 * keyboard.c (safe_run_hook_funcall): New function.
924 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
925 don't set the hook to nil, but remove the offending function instead.
926 (Qcommand_hook_internal): Remove, unused.
927 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
928 Vcommand_hook_internal.
929
930 * eval.c (enum run_hooks_condition): Remove.
931 (funcall_nil, funcall_not): New functions.
932 (run_hook_with_args): Call each function through a `funcall' argument.
933 Remove `cond' argument, now redundant.
934 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
935 (Frun_hook_with_args_until_failure): Adjust accordingly.
936 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
937
1db5b1ad
JB
9382011-03-28 Juanma Barranquero <lekktu@gmail.com>
939
940 * dispextern.h (string_buffer_position): Remove declaration.
941
942 * print.c (strout): Remove parameter `multibyte', unused since
943 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
944
945 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
946 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
947 All callers changed.
948
949 * w32.c (_wsa_errlist): Use braces for struct initializers.
950
951 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
952 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
953 All callers changed.
954 (string_buffer_position): Likewise. Also, make static (it's never
955 used outside xdisp.c).
956 (cursor_row_p): Remove parameter `w', unused since
957 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
958 (decode_mode_spec): Remove parameter `precision', introduced during
959 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
960 All callers changed.
961
5ffb62aa
JD
9622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
963
964 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
965
461c2ab9 9662011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
967
968 * nsterm.m (ns_menu_bar_is_hidden): New variable.
969 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
970 (ns_update_auto_hide_menu_bar): New functions.
971 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
972 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
973 ns_constrain_all_frames.
974 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
975 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
976
5c380ffb
JD
9772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
978
979 * nsmenu.m (runDialogAt): Remove argument to timer_check.
980
9af30bdf
GM
9812011-03-27 Glenn Morris <rgm@gnu.org>
982
983 * syssignal.h: Replace RETSIGTYPE with void.
984 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
985 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
986 Replace SIGTYPE with void everywhere.
987 * s/usg5-4-common.h (SIGTYPE): Remove definition.
988 * s/template.h (SIGTYPE): Remove commented out definition.
989
e2abce01
JB
9902011-03-26 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
993 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
994
f868cd8a
JB
9952011-03-26 Juanma Barranquero <lekktu@gmail.com>
996
59eb0929
JB
997 * w32.c (read_unc_volume): Use parameter `henum', instead of
998 global variable `wget_enum_handle'.
999
1000 * keymap.c (describe_vector): Remove parameters `indices' and
1001 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1002 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1003
f868cd8a
JB
1004 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1005
1006 * keyboard.c (timer_check): Remove parameter `do_it_now',
1007 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1008 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1009 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1010
1011 * keyboard.c (read_char):
1012 * w32menu.c (w32_menu_display_help):
1013 * xmenu.c (show_help_event, menu_help_callback):
1014 Adjust calls to `show_help_echo'.
1015
1016 * gtkutil.c (xg_maybe_add_timer):
1017 * keyboard.c (readable_events):
1018 * process.c (wait_reading_process_output):
1019 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1020
1021 * insdel.c (adjust_markers_gap_motion):
1022 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1023 (gap_left, gap_right): Don't call it.
1024
2ecf6fdb
CY
10252011-03-25 Chong Yidong <cyd@stupidchicken.com>
1026
1027 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1028 incurred during fontification.
1029
6b1f9ba4
JB
10302011-03-25 Juanma Barranquero <lekktu@gmail.com>
1031
1032 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1033 (DEFVAR_PER_BUFFER): Don't pass it.
1034
1035 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1036 (scrolling_window): Don't pass it.
1037
0f4a96b5
JB
10382011-03-25 Juanma Barranquero <lekktu@gmail.com>
1039
1040 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1041
1042 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1043 and `suffix'.
1044 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1045 of variables specific to SELinux and computation of `encoded_absname'.
1046
1047 * image.c (XPutPixel): Remove unused variable `height'.
1048
1049 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1050
1051 * unexw32.c (get_section_info): Remove unused variable `section'.
1052
1053 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1054 (system_process_attributes): Remove unused variable `sess'.
1055 (sys_read): Remove unused variable `err'.
1056
1057 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1058 (w32_wnd_proc): Remove unused variable `isdead'.
1059 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1060 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1061 (x_create_tip_frame): Remove unused variable `tem'.
1062
1063 * w32inevt.c (w32_console_read_socket):
1064 Remove unused variable `no_events'.
1065
1066 * w32term.c (x_draw_composite_glyph_string_foreground):
1067 Remove unused variable `width'.
1068
1149507c
JB
10692011-03-24 Juanma Barranquero <lekktu@gmail.com>
1070
1071 * w32term.c (x_set_glyph_string_clipping):
1072 Don't pass uninitialized region to CombineRgn.
1073
9c88f339
JB
10742011-03-23 Juanma Barranquero <lekktu@gmail.com>
1075
1076 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1077 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1078 (Fx_close_connection): Remove unused variable `i'.
1079
1080 * w32font.c (w32font_draw): Return number of glyphs.
1081 (w32font_open_internal): Remove unused variable `i'.
1082 (w32font_driver): Add missing initializer.
1083
1084 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1085 (fill_in_menu): Remove unused variable `items_added'.
1086
1087 * w32term.c (last_mouse_press_frame): Remove static global variable.
1088 (w32_clip_to_row): Remove unused variable `f'.
1089 (x_delete_terminal): Remove unused variable `i'.
1090
1091 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1092 (NOTHING): Remove unused static global variable.
1093 (uniscribe_check_otf): Remove unused variable `table'.
1094 (uniscribe_font_driver): Add missing initializers.
1095
dee091a3
JD
10962011-03-23 Julien Danjou <julien@danjou.info>
1097
1098 * term.c (Fsuspend_tty, Fresume_tty):
1099 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1100 * window.c (temp_output_buffer_show):
1101 * insdel.c (signal_before_change):
1102 * frame.c (Fhandle_switch_frame):
1103 * fileio.c (Fdo_auto_save):
1104 * emacs.c (Fkill_emacs):
1105 * editfns.c (save_excursion_restore):
1106 * cmds.c (internal_self_insert):
1107 * callint.c (Fcall_interactively):
1108 * buffer.c (Fkill_all_local_variables):
1109 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1110 Use Frun_hooks.
0f4a96b5 1111 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1112 unconditionnaly since it does the check itself.
1113
2c520ab5 11142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1115
c9c49752
PE
1116 Fix more problems found by GCC 4.5.2's static checks.
1117
8abc3f12
PE
1118 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1119 the first time through the loop, since we know p0 < p1 then.
1120 This also avoids a gcc -Wstrict-overflow warning.
1121
a2d26660
PE
1122 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1123 leading to a memory leak, possible in functions like
1124 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1125 of objects (Bug#8318).
a2d26660 1126
916c72e9
PE
1127 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1128 that could (at least in theory) be that large.
1129
19ab8a18
PE
1130 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1131 This is less likely to overflow, and avoids undefined behavior if
1132 overflow does occur. All callers changed. Use strtoul to scan
1133 for the unsigned long integer.
b7cbbd6f
PE
1134 (pint2hrstr): Simplify and tune code slightly.
1135 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1136
f0641eff
PE
1137 * scroll.c (do_scrolling): Work around GCC bug 48228.
1138 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1139
7f650bb9
PE
1140 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1141 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1142 (validate_x_resource_name): Simplify count usage.
1143 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1144
37dd57d1
PE
1145 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1146 fail (Bug#8306).
81e56e61 1147
699979fc 1148 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1149
401bf9b4
PE
1150 * process.c (Fmake_network_process): Use socklen_t, not int,
1151 where POSIX says socklen_t is required in portable programs.
1152 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1153 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1154 (Fmake_network_process, server_accept_connection):
1155 (wait_reading_process_output, read_process_output):
1156 Likewise.
1157
b93aacde
PE
1158 * process.c: Rename or move locals to avoid shadowing.
1159 (list_processes_1, Fmake_network_process):
1160 (read_process_output_error_handler, exec_sentinel_error_handler):
1161 Rename or move locals.
4dc343ee 1162 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1163 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1164 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1165 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1166 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1167
af8a867c 1168 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1169 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1170 Include tparam.h instead, since it declares them.
af8a867c
PE
1171 * cm.h (PC): Remove extern decl; tparam.h now does this.
1172 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1173 * terminfo.c: Include tparam.h, to check interfaces.
1174 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1175 (tparam): Adjust signature to match interface in tparam.h;
1176 this removes some undefined behavior. Check that outstring and len
1177 are zero, which they always are with Emacs.
1178 * tparam.h (PC, BC, UP): New extern decls.
1179
0248044d 1180 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1181 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1182
8ff096c1 1183 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1184 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1185 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1186 (ftfont_list): Remove unused local.
49eaafba
PE
1187 (get_adstyle_property, ftfont_pattern_entity):
1188 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1189 Rename locals to avoid shadowing.
8ff096c1 1190
e2be39f6
PE
1191 * xfont.c (xfont_list_family): Mark var as initialized.
1192
c9735e30
PE
1193 * xml.c (make_dom): Now static.
1194
8f5201ae
PE
1195 * composite.c (composition_compute_stop_pos): Rename local to
1196 avoid shadowing.
b246f932
PE
1197 (composition_reseat_it): Remove unused locals.
1198 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1199 (composition_update_it): Mark var as initialized.
11b61122
PE
1200 (find_automatic_composition): Mark vars as initialized,
1201 with a FIXME (Bug#8290).
8f5201ae 1202
760fbc2c
PE
1203 character.h: Rename locals to avoid shadowing.
1204 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1205 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1206 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1207 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1208 to avoid shadowing.
1209
ff08eb85
PE
1210 * textprop.c (property_change_between_p): Remove; unused.
1211
fc7bf025
PE
1212 * intervals.c (interval_start_pos): Now static.
1213
235d7abc
PE
1214 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1215
44f230aa
SM
1216 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1217 Rename locals to avoid shadowing.
3e7d6594 1218
50060332
PE
1219 * sound.c (wav_play, au_play, Fplay_sound_internal):
1220 Fix pointer signedness.
d01f234b 1221 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1222 (wav_play): Initialize a variable to 0, to prevent undefined
1223 behavior (Bug#8278).
50060332 1224
c4fc4e30
PE
1225 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1226
918436ed
PE
1227 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1228
c939f91b
PE
1229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1230 clobbering (Bug#8298).
b9c7f648
PE
1231 * sysdep.c (sys_subshell): Likewise.
1232 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1233
6bd8c144
PE
1234 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1235 This should get cleaned up, so that child_setup has the
1236 same signature on all platforms.
1237
7710357c 1238 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1239 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1240
c59da222
CY
12412011-03-22 Chong Yidong <cyd@stupidchicken.com>
1242
1243 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1244 not to be necessary, and produces flickering.
1245
66b87493
GM
12462011-03-20 Glenn Morris <rgm@gnu.org>
1247
1248 * config.in: Remove file.
1249
45b6f6d5
JB
12502011-03-20 Juanma Barranquero <lekktu@gmail.com>
1251
1252 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1253 are now in src/globals.h.
1254 (syms_of_minibuf): Remove spurious & from previous change.
1255
3ec03f7e
LL
12562011-03-20 Leo <sdl.web@gmail.com>
1257
1258 * minibuf.c (completing-read-function): New variable.
1259 (completing-read-default): Rename from completing-read.
1260 (completing-read): Call completing-read-function.
1261
b14e3e21
CY
12622011-03-19 Juanma Barranquero <lekktu@gmail.com>
1263
1264 * xfaces.c (Fx_load_color_file):
1265 Read color file from absolute filename (bug#8250).
1266
f2b726e6
JB
12672011-03-19 Juanma Barranquero <lekktu@gmail.com>
1268
1269 * makefile.w32-in: Update dependencies.
1270
09f6ff02
EZ
12712011-03-17 Eli Zaretskii <eliz@gnu.org>
1272
1273 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1274
29a6015a
PE
12752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1276
a3a6c54e
PE
1277 Fix more problems found by GCC 4.5.2's static checks.
1278
b766f867
PE
1279 * process.c (make_serial_process_unwind, send_process_trap):
1280 (sigchld_handler): Now static.
1281
be02381c
PE
1282 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1283 That way, the code declares only the vars that it needs.
1284 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1285 * s/cygwin.h (PTY_ITERATION): Likewise.
1286 * s/darwin.h (PTY_ITERATION): Likewise.
1287 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1288
57048744
PE
1289 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1290 * process.c (allocate_pty): Don't declare stb unless it's needed.
1291
7914961c 1292 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1293 (CONSTANTLIM): Remove; unused.
1294 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1295 Define only if needed.
7914961c 1296
b3967b18
PE
1297 * unexelf.c (unexec): Name an expression,
1298 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1299 Use a different way to cause a compilation error if anyone uses
1300 n rather than nn, a way that does not involve shadowing.
73366a00 1301 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1302
29a6015a
PE
1303 * deps.mk (unexalpha.o): Remove; unused.
1304
43cfc33e 1305 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1306 * unexec.h: New file.
ce701a33
PE
1307 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1308 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1309 Depend on unexec.h.
1310 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1311 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1312 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1313 Change as necessary to match prototype in unexec.h.
ce701a33 1314
01f44d5a
PE
1315 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1316 shadowing.
4f63c6bb 1317 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1318
a6670b0b
PE
1319 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1320 Rename locals to avoid shadowing.
1321
cef2010d 1322 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1323 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1324
d4d7173a
PE
1325 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1326
f08b802a
PE
1327 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1328 warning when compiling print.c.
1329
3ddb0639
PE
1330 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1331 instead of using an uninitialized var.
5ad03b97 1332 (font_sort_entities): Mark var as initialized.
3ddb0639 1333
170a2692
PE
1334 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1335
e663c700
PE
1336 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1337 pointers to constants.
89bc529a 1338 (font_parse_fcname): Remove unused vars.
7b81e2d0 1339 (font_delete_unmatched): Now static.
ea838e10 1340 (font_get_spec): Remove; unused.
13a547c6
PE
1341 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1342 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1343 Rename or move locals to avoid shadowing.
e663c700 1344
2a80c887 1345 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1346 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1347
1384fa33 1348 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1349 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1350
8b2c52e9
PE
1351 * alloc.c (mark_backtrace): Move decl from here ...
1352 * lisp.h: ... to here, so that it can be checked.
1353
475545b5 1354 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1355 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1356 (lisp_indirect_variable): Name an expression,
1357 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1358 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1359
b1349114 1360 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1361 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1362 Use const pointer when appropriate.
b1349114 1363
a2928364
PE
1364 * lisp.h (get_system_name, get_operating_system_release):
1365 Move decls here, to check interfaces.
1366 * process.c (get_operating_system_release): Move decl to lisp.h.
1367 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1368 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1369 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1370 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1371 (Fformat_time_string, Fencode_time, Finsert_char):
1372 (Ftranslate_region_internal, Fformat):
1373 Rename or remove local vars to avoid shadowing.
9710023e 1374 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1375
a415e694
PE
1376 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1377 avoid shadowing.
1378
8ef4622d
PE
1379 * lisp.h (eassert): Check that the argument compiles, even if
1380 ENABLE_CHECKING is not defined.
1381
946f9a5b
PE
1382 * data.c (Findirect_variable): Name an expression, to avoid
1383 gcc -Wbad-function-cast warning.
112396d6 1384 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1385 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1386 (Fmake_variable_buffer_local, Fmake_local_variable):
1387 Mark variables as initialized.
52746918 1388 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1389
e5aab7e7 1390 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1391 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1392 Rename locals to avoid shadowing.
dff45157
PE
1393 (mark_stack): Move local variables into the #ifdef region where
1394 they're used.
7bc26fdb
PE
1395 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1396 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1397 needed otherwise.
1398 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1399 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1400 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1401
e5aab7e7
PE
1402 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1403 avoids undefined behavior in theory.
1404
4da60324
PE
1405 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1406
88043301
PE
1407 Use functions, not macros, for up- and down-casing (Bug#8254).
1408 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1409 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1410 to use the following functions instead of these macros.
1411 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1412 EMACS_INT, since callers assume the returned value fits in int.
1413 (upcase1): Likewise, for UPCASE_TABLE.
1414 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1415 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1416 the race-condition problem in the old DOWNCASE.
88043301 1417
19ed5445
PE
1418 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1419 Rename locals to avoid shadowing.
1420 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1421 (regex_compile, re_search_2, re_match_2_internal):
1422 Remove unused local vars.
952db0d7
PE
1423 (FREE_VAR): Rewrite so as not to use empty "else",
1424 which gcc can warn about.
da053e48 1425 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1426 (RETALLOC_IF): Define only if needed.
1427 (WORDCHAR_P): Likewise. This one is never needed, but is used
1428 only in a comment talking about a compiler bug, so put inside
1429 the #if 0 of that comment.
1430 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1431 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1432 Remove; unused.
19ed5445 1433
1f3561e4 1434 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1435 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1436 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1437
ded6f8f7
PE
1438 * search.c (simple_search): Remove unused var.
1439
dbd37a95
PE
1440 * dired.c (compile_pattern): Move decl from here ...
1441 * lisp.h: ... to here, so that it can be checked.
1442 (struct re_registers): New forward decl.
1443
7e47afad
PE
1444 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1445
85f24f61
PE
1446 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1447 All uses changed.
1448 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1449 Rename locals to avoid shadowing.
5671df8f 1450 (Fvertical_motion): Mark locals as initialized.
85f24f61 1451
181aa2be 1452 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1453 (casify_region): Mark local as initialized.
181aa2be 1454
930d429c
PE
1455 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1456
7082eac6
PE
1457 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1458 New macros, so that the caller can use some names other than
1459 gcpro1, gcpro2, etc.
1460 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1461 of the new macros.
1462 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1463 argument, for consistency with GCPRO2_VAR, etc: it is now the
1464 prefix of the variable, not the variable itself. All uses
1465 changed.
38b2c076
PE
1466 * dired.c (directory_files_internal, file_name_completion):
1467 Rename locals to avoid shadowing.
1468
15206ed9
PE
1469 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1470 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1471 dired.c's scmp function, had undefined behavior.
1472 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1473 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1474 * buffer.h: ... to here, because these macros use current_buffer,
1475 and the new implementation with inline functions needs to have
1476 current_buffer in scope now, rather than later when the macros
1477 are used.
1478 (downcase, upcase1): New static inline functions.
1479 (DOWNCASE, UPCASE1): Reimplement using these functions.
1480 This avoids undefined behavior in expressions like
1481 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1482 from race conditions in accessing the global variables
1483 case_temp1 and case_temp2.
1484 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1485 * lisp.h (case_temp1, case_temp2): Remove their decls.
1486 * character.h (ASCII_CHAR_P): Move from here ...
1487 * lisp.h: ... to here, so that the inline functions mentioned
1488 above can use them.
1489
4a6bea26
PE
1490 * dired.c (directory_files_internal_unwind): Now static.
1491
f14b7e14
PE
1492 * fileio.c (file_name_as_directory, directory_file_name):
1493 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1494 Now static.
2893f146
PE
1495 (file_name_as_directory): Use const pointers when appropriate.
1496 (Fexpand_file_name): Likewise. In particular, newdir might
1497 point at constant storage, so make it a const pointer.
fd4ead52 1498 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1499 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1500 signedness issues.
f839df0c
PE
1501 (Fset_file_times, Finsert_file_contents, auto_save_error):
1502 Rename locals to avoid shadowing.
f14b7e14 1503
5716756e 1504 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1505 (Ftry_completion, Fall_completions): Rename or remove locals
1506 to avoid shadowing.
5716756e 1507
b4c3046a
PE
1508 * marker.c (bytepos_to_charpos): Remove; unused.
1509
b45db522
PE
1510 * lisp.h (verify_bytepos, count_markers): New decls,
1511 so that gcc does not warn that these functions aren't declared.
1512
85876d07
PE
1513 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1514 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1515 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1516 (copy_text): Remove unused local var.
85876d07 1517
03d78a21 1518 * filelock.c (within_one_second): Now static.
b3dd38ab 1519 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1520
5df8f01b
PE
1521 * buffer.c (fix_overlays_before): Mark locals as initialized.
1522 (fix_start_end_in_overlays): Likewise. This function should be
1523 simplified by using pointers-to-pointers, but that's a different
1524 matter.
b1d876f1 1525 (switch_to_buffer_1): Now static.
8f54f30a
PE
1526 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1527 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1528
a70072c9 1529 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1530 Fix pointer signedness issue.
edced198
PE
1531 (sys_subshell): Mark local as volatile if checking for lint,
1532 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1533 (MAXPATHLEN): Define only if needed.
a70072c9 1534
a0977c44
PE
1535 * process.c (serial_open, serial_configure): Move decls from here ...
1536 * systty.h: ... to here, so that they can be checked.
1537
a884fdcc
PE
1538 * fns.c (get_random, seed_random): Move extern decls from here ...
1539 * lisp.h: ... to here, so that they can be checked.
1540
604efe86 1541 * sysdep.c (reset_io): Now static.
b8950c94 1542 (wait_for_termination_signal): Remove; unused.
604efe86 1543
38fc62d9
PE
1544 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1545 (copy_keymap_item, append_key, push_text_char_description):
1546 Now static.
1004a21a 1547 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1548 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1549 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1550 (describe_map_tree):
1551 Rename locals to avoid shadowing.
38fc62d9 1552
2f2650da
PE
1553 * keyboard.c: Declare functions static if they are not used elsewhere.
1554 (echo_char, echo_dash, cmd_error, top_level_2):
1555 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1556 (read_char, kbd_buffer_get_event, make_lispy_position):
1557 (make_lispy_event, make_lispy_movement, apply_modifiers):
1558 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1559 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1560 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1561 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1562 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1563
a053e86c 1564 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1565 (mark_kboards): Move decl here ...
1566 * alloc.c (mark_kboards): ... from here.
a053e86c 1567
4752793e
PE
1568 * lisp.h (force_auto_save_soon): New decl.
1569
74f10ca7 1570 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1571 (DEFINE_DUMMY_FUNCTION): New macro.
1572 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1573 Use it.
c03cd23f
PE
1574 (main): Add casts to avoid warnings
1575 if GCC considers string literals to be constants.
74f10ca7 1576
022e70d4
PE
1577 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1578
59d6fe83
PE
1579 * dbusbind.c: Pointer signedness fixes.
1580 (xd_signature, xd_append_arg, xd_initialize):
1581 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1582 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1583 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1584 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1585
78320123
PE
1586 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1587 if GCC considers string literals to be constants.
49cebcca 1588 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1589
35ac2a97
SM
15902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1591
fb103ca9
SM
1592 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1593 (print_preprocess, print_object): New macro to fix last change.
1594
35ac2a97
SM
1595 * print.c (print_preprocess): Don't forget font objects.
1596
62973b41
JB
15972011-03-16 Juanma Barranquero <lekktu@gmail.com>
1598
1599 * emacs.c (USAGE3): Doc fixes.
1600
0e48bb22
AS
16012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1602
1603 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1604 structure.
1605
7684e57b
JB
16062011-03-14 Juanma Barranquero <lekktu@gmail.com>
1607
1608 * lisp.h (VWindow_system, Qfile_name_history):
1609 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1610 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1611 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1612
1613 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1614 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1615
1616 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1617 * w32console.c (detect_input_pending, read_input_pending)
1618 (encode_terminal_code):
1619 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1620 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1621 (w32_system_caret_y, Qfile_name_history):
1622 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1623 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1624 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1625 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1626 * w32proc.c (Qlocal, report_file_error):
1627 * w32term.c (Vwindow_system, updating_frame):
1628 * w32uniscribe.c (initialized, uniscribe_font_driver):
1629 Remove unneeded extern declarations.
1630
2aa46d6c
CY
16312011-03-14 Chong Yidong <cyd@stupidchicken.com>
1632
c96bbc66 1633 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1634
cffc6f3b
CY
16352011-03-13 Chong Yidong <cyd@stupidchicken.com>
1636
1637 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1638 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1639 These macros can no longer be used for assignment.
1640
44f230aa
SM
1641 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1642 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1643 (record_buffer_markers, fetch_buffer_markers): New functions for
1644 recording and fetching special buffer markers.
1645 (set_buffer_internal_1, set_buffer_temp): Use them.
1646
1647 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1648
1649 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1650
1651 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1652 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1653
1654 * xdisp.c (hscroll_window_tree):
1655 (reconsider_clip_changes): Use PT instead of BUF_PT.
1656
d251f04b
EZ
16572011-03-13 Eli Zaretskii <eliz@gnu.org>
1658
1659 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1660 $(EMACS_ROOT)/lib/intprops.h.
1661
f0c77cd1
PE
16622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1663
3eca4629
PE
1664 Fix more problems found by GCC 4.5.2's static checks.
1665
7c86ee98
PE
1666 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1667 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1668 (xg_free_frame_widgets): Make it clear that a local variable is
1669 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1670 (gdk_window_get_screen): Make it clear that this macro is needed
1671 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1672 (int_gtk_range_get_value): New function, which avoids a diagnostic
1673 from gcc -Wbad-function-cast.
1674 (xg_set_toolkit_scroll_bar_thumb): Use it.
1675 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1676 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1677 (get_utf8_string, xg_get_file_with_chooser):
1678 Rename locals to avoid shadowing.
1679 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1680
41729b81
PE
1681 * xgselect.c (xg_select): Remove unused var.
1682
f0c77cd1
PE
1683 * image.c (four_corners_best): Mark locals as initialized.
1684 (gif_load): Initialize transparent_p to zero (Bug#8238).
1685 Mark another local as initialized.
ec6cf4c6 1686 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1687
ce0ad53d 1688 * image.c (clear_image_cache): Now static.
d5d5a617 1689 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1690 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1691 (x_edge_detection): Remove unnecessary cast that
1692 gcc -Wbad-function-cast diagnoses.
2037898d 1693 (gif_load): Fix pointer signedness.
6ae141d6
PE
1694 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1695 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1696
33383987 16972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1698
d32df629
PE
1699 Improve quality of tests for time stamp overflow.
1700 For example, without this patch (encode-time 0 0 0 1 1
1701 1152921504606846976) returns the obviously-bogus value (-948597
1702 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1703 reports time overflow. See
1704 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1705 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1706 * editfns.c: Include limits.h and intprops.h.
1707 (TIME_T_MIN, TIME_T_MAX): New macros.
1708 (time_overflow): Move earlier, to before first use.
1709 (hi_time, lo_time): New functions, for an accurate test for
1710 out-of-range times.
1711 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1712 (Fget_internal_run_time): Don't assume time_t fits in int.
1713 (make_time): Use list2 instead of Fcons twice.
1714 (Fdecode_time): More accurate test for out-of-range times.
1715 (check_tm_member): New function.
1716 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1717 (lisp_time_argument): Don't rely on undefined left-shift and
1718 right-shift behavior when checking for time stamp overflow.
8be6f318 1719
fe31d94c
PE
1720 * editfns.c (time_overflow): New function, refactoring common code.
1721 (Fformat_time_string, Fdecode_time, Fencode_time):
1722 (Fcurrent_time_string): Use it.
1723
8be6f318
PE
1724 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1725 * dired.c (make_time): Move to ...
1726 * editfns.c (make_time): ... here.
1727 * systime.h: Note the move.
1728
09d9db2c 17292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1730
126bc0dc
YM
1731 * fringe.c (update_window_fringes): Remove unused variables.
1732
c47cbdfd
YM
1733 * unexmacosx.c (copy_data_segment): Also copy __got section.
1734 (Bug#8223)
1735
7ac80be9
EZ
17362011-03-12 Eli Zaretskii <eliz@gnu.org>
1737
c96bbc66 1738 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1739 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1740 Constify `char *' arguments and their references according to
1741 prototypes in tparam.h.
1742
ecb0f94d 1743 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1744
7ac80be9
EZ
1745 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1746 Adapt all references accordingly.
1747
1748 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1749
ef1fd07e
TT
17502011-03-11 Tom Tromey <tromey@redhat.com>
1751
1752 * buffer.c (syms_of_buffer): Remove obsolete comment.
1753
7ef4b50c
EZ
17542011-03-11 Eli Zaretskii <eliz@gnu.org>
1755
1756 * termhooks.h (encode_terminal_code): Declare prototype.
1757
1758 * msdos.c (encode_terminal_code): Don't declare prototype.
1759
1760 * term.c (encode_terminal_code): Now external again, used by
1761 w32console.c and msdos.c.
1762
44f230aa
SM
1763 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1764 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1765
4b1ec863 17662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1767
1714f52b 1768 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1769
4b1ec863
PE
1770 * fringe.c (update_window_fringes): Mark locals as initialized
1771 (Bug#8227).
1772 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1773
524c7aa6
PE
1774 * alloc.c (mark_fringe_data): Move decl from here ...
1775 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1776 to check its interface.
1777 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1778
a5c0af81 1779 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1780 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1781 (fontset_font): Mark local as initialized.
a9a06e0b 1782 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1783
b4716021
PE
1784 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1785
811e9bac 1786 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1787 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1788 (x_own_selection, Fx_disown_selection_internal): Rename locals
1789 to avoid shadowing.
1790 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1791
7e3ab302
PE
1792 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1793 so that the caller can use some name other than gcpro1.
1794 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1795 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1796 (Fx_backspace_delete_keys_p):
1797 Use them to avoid shadowing, and rename vars to avoid shadowing.
1798 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1799 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1800 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1801 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1802 Remove unused locals.
7e3ab302
PE
1803 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1804 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1805 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1806 macros.
f78faa98 1807
e2b13473
PE
1808 * xterm.h (x_mouse_leave): New decl.
1809
77f23912
PE
1810 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1811 Remove unused functions.
cdf4ba58
PE
1812 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1813 (x_calc_absolute_position): Now static.
7411c686 1814 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1815 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1816 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1817 unless they are used.
38d0b34a
PE
1818 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1819 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1820 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1821 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1822 (x_error_catcher, x_connection_closed, x_error_handler):
1823 (x_error_quitter, xembed_send_message, x_iconify_frame):
1824 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1825 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1826 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1827
44f230aa
SM
1828 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1829 Rename or move locals to avoid shadowing.
6b463e58 1830 (tty_defined_color, merge_face_heights): Now static.
5967d051 1831 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1832 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1833 does not deduce is never used uninitialized.
73719eba
PE
1834 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1835 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1836
426994c3 1837 * terminal.c (store_terminal_param): Now static.
5489860b 1838
032f1620 1839 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1840 (set_frame_menubar): Remove unused local.
d4323972 1841 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1842 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1843 since they might point to immutable storage.
281585b0
PE
1844 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1845 since it's unused otherwise.
032f1620 1846
367c19e5 1847 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1848 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1849 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1850 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1851 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1852 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1853 does not deduce are never used uninitialized.
70739cbe 1854
07b48fa9
PE
1855 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1856
8868a238 1857 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1858 * window.c (window_loop, size_window):
1859 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1860
7e5cf297 1861 * window.c (display_buffer): Now static.
d6550a9f
PE
1862 (size_window): Mark variables that gcc -Wuninitialized
1863 does not deduce are never used uninitialized.
a586633d
PE
1864 * window.h (check_all_windows): New decl, to forestall
1865 gcc -Wmissing-prototypes diagnostic.
5b555da1 1866 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1867
f6095868
PE
1868 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1869 shadowing.
1870 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1871 Include <limits.h>.
1872 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1873 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1874 (load_charset_map): Mark variables that gcc -Wuninitialized
1875 does not deduce are never used uninitialized.
53df7c11 1876 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1877
f38b440c
PE
1878 * coding.c (coding_set_source, coding_set_destination):
1879 Use "else { /* comment */ }" rather than "else /* comment */;"
1880 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1881 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1882 a block, when the outer 'i' will do.
1883 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1884 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1885 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1886 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1887 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1888 Rename locals to avoid shadowing.
1889 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1890 * coding.c (emacs_mule_char, encode_invocation_designation):
1891 Now static, since they're not used elsewhere.
413bb2db 1892 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1893 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1894 (decode_coding_emacs_mule): Mark variables that gcc
1895 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1896 (detect_coding_iso_2022): Initialize a local variable that might
1897 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1898 this initialization is needed. (Bug#8211)
5f58e762
PE
1899 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1900 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1901 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1902 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1903 Remove unused macros.
f38b440c 1904
232b38b9 1905 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1906 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1907 * character.c (string_count_byte8): Likewise.
232b38b9 1908
fb90da1b
PE
1909 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1910 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1911
fb93dbc2
PE
1912 * chartab.c (copy_sub_char_table): Now static, since it's not used
1913 elsewhere.
5c156ace
PE
1914 (sub_char_table_ref_and_range, char_table_ref_and_range):
1915 Rename locals to avoid shadowing.
bbcd0949 1916 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1917
7d3b3862 1918 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1919 (BIDI_BOB): Remove unused macro.
7d3b3862 1920
6be7d3da
PE
1921 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1922 deduce are never used uninitialized.
c2ed9c8b 1923 * term.c (encode_terminal_code): Likewise.
6be7d3da 1924
75f8807f 1925 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1926
50938595
PE
1927 * tparam.h: New file.
1928 * term.c, tparam.h: Include it.
1929 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1930 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1931 Move these decls to tparam.h, and make them agree with what
1932 is actually in tparam.c. The previous trick of using incompatible
1933 decls in different modules does not conform to the C standard.
1934 All callers of tparam changed to use tparam's actual API.
1935 * tparam.c (tparam1, tparam, tgoto):
1936 Use const pointers where appropriate.
1937
fbceeba2
PE
1938 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1939 * cm.h (struct cm): Likewise.
1940 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1941 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1942 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1943 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1944 (turn_on_face, init_tty): Likewise.
1945 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1946
7f3f1250
PE
1947 * term.c (term_mouse_position): Rename local to avoid shadowing.
1948
e6ca6543
PE
1949 * alloc.c (mark_ttys): Move decl from here ...
1950 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1951
c40f8d15
AS
19522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1953
1954 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1955
cfe0661d
JB
19562011-03-09 Juanma Barranquero <lekktu@gmail.com>
1957
1958 * search.c (compile_pattern_1): Remove argument regp, unused since
1959 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1960 (compile_pattern): Don't pass it.
1961
0afb4571
J
19622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1963
1964 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1965 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1966 for ! HAVE_GTK3.
1967 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1968
1969 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1970
1971 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1972 gdk_window_get_screen, gdk_window_get_geometry,
1973 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1974 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1975 (xg_get_pixbuf_from_pixmap): New function.
1976 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1977 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1978 Call xg_get_pixbuf_from_pixmap instead of
1979 gdk_pixbuf_get_from_drawable.
1980 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1981 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1982 (xg_check_special_colors): Use GtkStyleContext and its functions
1983 for HAVE_GTK3.
1984 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1985 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1986 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1987 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1988 Call gtk_widget_get_preferred_size.
0afb4571
J
1989 (xg_frame_resized): gdk_window_get_geometry only takes 5
1990 parameters.
44f230aa
SM
1991 (xg_win_to_widget, xg_event_is_for_menubar):
1992 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1993 (xg_set_widget_bg): New function.
1994 (delete_cb): New function.
1995 (xg_create_frame_widgets): connect delete-event to delete_cb.
1996 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1997 (xg_set_background_color): Call xg_set_widget_bg.
1998 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1999 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2000 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2001 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2002 if ! HAVE_GTK3.
2003 (update_frame_tool_bar): Call gtk_widget_hide.
2004 (xg_initialize): Use GDK_KEY_g.
2005
2006 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2007 if ! HAVE_GTK3
2008 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2009
2010 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2011 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2012 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2013
1c2cc4ef
JB
20142011-03-08 Juanma Barranquero <lekktu@gmail.com>
2015
2016 * w32xfns.c (select_palette): Check success of RealizePalette against
2017 GDI_ERROR, not zero.
2018
33383987 2019See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2020
2021;; Local Variables:
2022;; coding: utf-8
aac0c6e3
MR
2023;; End:
2024
33383987 2025 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2026
2027 This file is part of GNU Emacs.
2028
2029 GNU Emacs is free software: you can redistribute it and/or modify
2030 it under the terms of the GNU General Public License as published by
2031 the Free Software Foundation, either version 3 of the License, or
2032 (at your option) any later version.
2033
2034 GNU Emacs is distributed in the hope that it will be useful,
2035 but WITHOUT ANY WARRANTY; without even the implied warranty of
2036 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2037 GNU General Public License for more details.
2038
2039 You should have received a copy of the GNU General Public License
2040 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.