Spelling fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c3a70e2b
CY
12012-02-15 Chong Yidong <cyd@gnu.org>
2
3 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4 marked as special. Also, starting docstrings with * is obsolete.
5
0ca43699
AS
62012-02-13 Andreas Schwab <schwab@linux-m68k.org>
7
8 * gnutls.c (emacs_gnutls_write): Fix last change.
9
2e8f3c56
LI
102012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
11
12 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
13 send_process.
14
af70074f
SM
152012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
16
17 * keymap.c (Fsingle_key_description): Handle char ranges.
18
95986d52
CY
192012-02-12 Chong Yidong <cyd@gnu.org>
20
afd83bd1
CY
21 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
22 as that creates a dangerous corner case.
23
95986d52
CY
24 * window.c (Fdelete_window_internal): Invalidate the mouse
25 highlight (Bug#9904).
26
bd7da63e
GM
272012-02-12 Glenn Morris <rgm@gnu.org>
28
29 * xselect.c (Fx_own_selection_internal)
30 (Fx_get_selection_internal, Fx_disown_selection_internal)
31 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
32 * nsselect.m (Fx_own_selection_internal)
33 (Fx_disown_selection_internal, Fx_selection_exists_p)
34 (Fx_selection_owner_p, Fx_get_selection_internal):
35 Sync docs and argument specs with the xselect.c versions.
36
77abcbc2
LI
372012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
38
39 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
40
90b671e2
EZ
412012-02-11 Eli Zaretskii <eliz@gnu.org>
42
1c0ca0b7
EZ
43 * w32select.c (Fx_selection_exists_p): Sync doc string and
44 argument list with xselect.c. (Bug#10783)
45
46 * w16select.c (Fx_selection_exists_p): Sync doc string and
47 argument list with xselect.c. (Bug#10783)
90b671e2 48
49241268
GM
492012-02-10 Glenn Morris <rgm@gnu.org>
50
51 * fns.c (Fsecure_hash): Doc fix.
52
f998bbe7 532012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
54
55 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
56
0992bd9c
CY
572012-02-07 Chong Yidong <cyd@gnu.org>
58
59 * buffer.c (Fbuffer_local_variables)
60 (buffer_lisp_local_variables): Handle unbound vars correctly;
61 don't let Qunbound leak into Lisp.
62
af008560
GM
632012-02-07 Glenn Morris <rgm@gnu.org>
64
dd605cc4
GM
65 * image.c (Fimagemagick_types): Doc fix.
66
af008560
GM
67 * image.c (imagemagick-render-type): Change it from a lisp object
68 to an integer. Move the doc here from the lisp manual.
69 Treat all values not equal to 0 the same.
70
1449fa1d
CY
712012-02-06 Chong Yidong <cyd@gnu.org>
72
73 * doc.c (store_function_docstring): Avoid applying docstring of
74 alias to base function (Bug#2603).
75
3723ec07
AS
762012-02-04 Andreas Schwab <schwab@linux-m68k.org>
77
78 * .gdbinit (pp1, pv1): Remove redundant defines.
79 (pr): Use pp.
80
79c1cc1e
CY
812012-02-04 Chong Yidong <cyd@gnu.org>
82
83 * nsterm.m: Declare a global (Bug#10694).
84
d7f29f8e
EZ
852012-02-04 Eli Zaretskii <eliz@gnu.org>
86
87 * w32.c (get_emacs_configuration_options): Include
88 --enable-checking, if specified, in the return value.
89
3b95a6f9
MR
902012-02-04 Martin Rudalics <rudalics@gmx.at>
91
92 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
93 after rounding frame sizes. (Bug#9723)
94
d6fa96a6
EZ
952012-02-04 Eli Zaretskii <eliz@gnu.org>
96
97 * keyboard.c (adjust_point_for_property): Don't position point
98 before BEGV. (Bug#10696)
99
df0b2940
PE
1002012-02-03 Paul Eggert <eggert@cs.ucla.edu>
101
102 Handle overflow when computing char display width (Bug#9496).
103 * character.c (char_width): Return EMACS_INT, not int.
104 (char_width, c_string_width): Check for overflow when
105 computing the width; this is possible now that individual
106 characters can have unbounded width. Problem introduced
107 by merge from Emacs 23 on 2012-01-19.
108
6bee44d6
MA
1092012-02-02 Michael Albinus <michael.albinus@gmx.de>
110
111 * dbusbind.c (Fdbus_register_method): Mention the return value
112 :ignore in the docstring.
113
44f92739
GM
1142012-02-02 Glenn Morris <rgm@gnu.org>
115
1b9f60cc
GM
116 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
117
44f92739
GM
118 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
119 Unconditionally set to t. (Bug#10673)
120 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
121 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
122 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
123
c5d3843c
KH
1242012-02-02 Kenichi Handa <handa@m17n.org>
125
126 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
127 0, do not call append_composite_glyph.
128
159462d4 1292012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
130
131 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
132 NULL (Bug#6988).
133 (x_produce_glyphs): If the component of a composition is a null
134 string, set it->pixel_width to 1 to avoid zero-width glyph.
135
78cef877
EZ
1362012-02-01 Eli Zaretskii <eliz@gnu.org>
137
138 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
139 first 2 arguments are identical. This makes inserting large
140 output from a subprocess an order of magnitude faster on
141 MS-Windows, where all sbrk'ed memory is always contiguous.
142
97897668
GM
1432012-01-31 Glenn Morris <rgm@gnu.org>
144
145 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 146 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
147 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
148
31fd3586
GM
1492012-01-29 Glenn Morris <rgm@gnu.org>
150
151 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
152
0e24a8b2
CY
1532012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
154
155 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
156
cc0adcb0
CY
1572012-01-28 Chong Yidong <cyd@gnu.org>
158
159 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
160
acc28cb9
CY
1612012-01-26 Chong Yidong <cyd@gnu.org>
162
9c69cfb7
CY
163 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
164
acc28cb9
CY
165 * search.c (Fsearch_forward, Fsearch_backward): Document negative
166 repeat counts (Bug#10507).
167
48da7392
GM
1682012-01-26 Glenn Morris <rgm@gnu.org>
169
170 * lread.c (syms_of_lread): Doc fix.
171
14af5f7f
CY
1722012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
173
174 * coding.c (encode_designation_at_bol): Change return value to
175 EMACS_INT.
176
0b21c100
CY
1772012-01-25 Chong Yidong <cyd@gnu.org>
178
179 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
180
3c2907f7
CY
1812012-01-21 Chong Yidong <cyd@gnu.org>
182
183 * floatfns.c (Fcopysign): Make the second argument non-optional,
184 since nil is not allowed anyway.
185
959ad23f
AS
1862012-01-21 Andreas Schwab <schwab@linux-m68k.org>
187
188 * process.c (read_process_output): Use p instead of XPROCESS (proc).
189 (send_process): Likewise.
190
34a02f46
MR
1912012-01-19 Martin Rudalics <rudalics@gmx.at>
192
193 * window.c (save_window_save, Fcurrent_window_configuration)
194 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
195 doc-strings.
196
1259009a 1972012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
198
199 * character.c (char_width): New function.
70d4fdf6
GM
200 (Fchar_width, c_string_width, lisp_string_width):
201 Use char_width (Bug#9496).
25ed9e61 202
6a6ee00d
MR
2032012-01-16 Martin Rudalics <rudalics@gmx.at>
204
205 * window.c (Vwindow_persistent_parameters): New variable.
206 (Fset_window_configuration, save_window_save): Handle persistent
207 window parameters.
208
c85efaf7
EZ
2092012-01-14 Eli Zaretskii <eliz@gnu.org>
210
211 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
212 thrashing the stack of the thread. (Bug#9087)
213
5944709e
PE
2142012-01-12 Paul Eggert <eggert@cs.ucla.edu>
215
216 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
217
e71f5d99
EZ
2182012-01-11 Eli Zaretskii <eliz@gnu.org>
219
220 * xdisp.c (rows_from_pos_range): Handle the case where the
221 highlight ends on a newline. (Bug#10464)
222 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
223 he end column for display of highlight that ends on a newline
224 before a R2L line.
225
ce316182
GM
2262012-01-11 Glenn Morris <rgm@gnu.org>
227
228 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
229 from load-path also when installation-directory is nil. (Bug#10208)
230
5b43da69
GM
2312012-01-10 Glenn Morris <rgm@gnu.org>
232
74cc8ff9
GM
233 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
234
7d8d6e4e
GM
235 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
236 Update template values to be closer to their typical values these days.
5b43da69 237
a0db8d43
EZ
2382012-01-09 Eli Zaretskii <eliz@gnu.org>
239
240 * xdisp.c (rows_from_pos_range): Accept additional argument
241 DISP_STRING, and accept any glyph in a row whose object is that
242 string as eligible for mouse highlight. Fixes mouse highlight of
243 display strings from overlays. (Bug#10464)
244
9a0115ab 2452012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 246
b9110d6a 247 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
248 * fileio.c (auto_saving_dir_umask): New static var.
249 (Fmake_directory_internal): Use it.
250 (do_auto_save_make_dir): Set it, instead of invoking chmod after
251 creating the directory. The old code temporarily assigns
252 too-generous permissions to the directory.
253 (do_auto_save_eh): Clear it.
b9110d6a 254 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
255 that the var is always cleared.
256
6c1bd3f3
EZ
2572012-01-07 Eli Zaretskii <eliz@gnu.org>
258
259 * search.c (scan_buffer): Pass character positions to
260 know_region_cache, not byte positions. (Bug#6540)
261
069d2b50
L
2622012-01-07 LynX <_LynX@bk.ru> (tiny change)
263
264 * w32.c (sys_rename): Report EXDEV when rename of a directory
265 fails because the target is on another logical disk. (Bug#10284)
266
75bf0d33
DB
2672012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
268
269 * xterm.c (x_embed_request_focus): New function.
270
271 * xterm.h: Add prototype.
272
273 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
274
1c6e5a32
GM
2752012-01-05 Glenn Morris <rgm@gnu.org>
276
277 * emacs.c (emacs_copyright): Update short copyright year to 2012.
278
651e947e
EZ
2792012-01-01 Eli Zaretskii <eliz@gnu.org>
280
281 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
282 Load gnutls_transport_set_lowat only if GnuTLS version is below
283 2.11.1.
284 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
285 GnuTLS versions below 2.11.1.
286
3778cdd8
AL
2872011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
288
289 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
290 to the doc string advising against its use for altering the way
291 windows are scrolled.
292
0e5317f7
KH
2932011-12-28 Kenichi Handa <handa@m17n.org>
294
295 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
296 coding-system ASCII compatible only when it does not produce BOM
297 on encoding (Bug#10383).
298
93d5ca1f
JD
2992011-12-26 Jan Djärv <jan.h.d@swipnet.se>
300
301 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
302 can scroll.
303 (create_and_show_popup_menu): Always use menu_position_func for
304 Gtk3 (Bug#10361).
305
ca22b785
AS
3062011-12-24 Andreas Schwab <schwab@linux-m68k.org>
307
308 * callint.c (Fcall_interactively): Don't truncate prompt string.
309
d048e1e6
EZ
3102011-12-23 Eli Zaretskii <eliz@gnu.org>
311
312 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
313 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 314 resumed from there (after widening). (Bug#10360)
d048e1e6 315
5ccaba1f
JD
3162011-12-22 Jan Djärv <jan.h.d@swipnet.se>
317
318 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
319
204ee57f
JD
3202011-12-21 Jan Djärv <jan.h.d@swipnet.se>
321
b81d40f0
JB
322 * nsterm.m (x_free_frame_resources):
323 Release f->output_data.ns->miniimage.
204ee57f
JD
324 (ns_index_color): Fix indentation. Do not retain
325 color_table->colors[i].
326
327 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
328 before returning.
329
330 * nsfns.m (x_set_background_color): Assign return value from
331 ns_index_color to face-background instead of NSColor*.
332 (ns_implicitly_set_icon_type): Fix indentation.
333 Change assignment in for loop to comparison.
334
335 * emacs.c (ns_pool): New variable.
336 (main): Assign ns_pool.
337 (Fkill_emacs): Call ns_release_autorelease_pool.
338
339 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
340 autorelease fdesc, release fdAttrs and tdict.
341 (ns_get_covering_families): Release charset.
342 (ns_findfonts): Release NSFontDescriptor created with new.
343 (ns_uni_to_glyphs): Fix indentation.
344 (setString): Release attrStr before assigning new value.
345
c803b2b7
JD
3462011-12-18 Jan Djärv <jan.h.d@swipnet.se>
347
678f4426
JD
348 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
349 and NS_IMPL_COCOA.
350 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
351 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
352
cd394be1 3532011-12-18 David Reitter <reitter@cmu.edu>
678f4426 354
5fecd5fc
JD
355 * nsterm.m (ns_term_init): Subscribe for notifications
356 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
357 to method trackingNotification in EmacsMenu.
358
359 * nsmenu.m (trackingMenu): New variable.
3771cb17 360 (trackingNotification): New method (from Aquamacs).
5fecd5fc 361 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 362 from Aquamacs (Bug#7030).
678f4426
JD
363
3642011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 365
c803b2b7
JD
366 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
367 (symbol_to_nsstring): Fix indentation.
368 (ns_symbol_to_pb): New function.
369 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
370 (Fns_rotate_cut_buffers_internal): Removed.
371 (Fns_store_selection_internal): Renamed from
372 Fns_store_cut_buffer_internal.
373 (ns_get_foreign_selection, Fx_own_selection_internal)
374 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
375 (Fns_get_selection_internal, Fns_store_selection_internal):
376 Use ns_symbol_to_pb and check if return value is nil.
377 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
378 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
379 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
380 renamed to Sns_store_selection_internal.
381 (ns_handle_selection_request): Move code to Fx_own_selection_internal
382 and remove this function.
383 (ns_handle_selection_clear): Remove, never used.
384 (Fx_own_selection_internal): Move code from ns_handle_selection_request
385 here.
386
e1b01a3a
KB
3872011-12-17 Ken Brown <kbrown@cornell.edu>
388
389 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
390 GID is unknown (Bug#10257).
391
2adb6e85
PE
3922011-12-17 Paul Eggert <eggert@cs.ucla.edu>
393
394 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
395 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
396 which caused a build failure on GNU/Linux IA-64. This problem was
397 introduced by my 2011-10-07 patch.
398
d1d7b339
JL
3992011-12-15 Juri Linkov <juri@jurta.org>
400
401 * image.c (imagemagick_error): New function. (Bug#10112)
402 (imagemagick_load_image): Comment out `MagickSetResolution' call.
403 Use `imagemagick_error' where ImageMagick functions return
404 `MagickFalse'.
405 (Fimagemagick_types): Add `Fnreverse' to return the list in the
406 proper order.
407
100d5755
KH
4082011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
409
410 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
411 fill background (Bug#8992).
412
454592a6
MR
4132011-12-13 Martin Rudalics <rudalics@gmx.at>
414
415 * window.c (Vwindow_combination_resize)
416 (Vwindow_combination_limit): Use t instead of non-nil in
417 doc-strings.
61d4b438
MR
418 (Vrecenter_redisplay): Add first sentence of doc-string on
419 separate line.
53524d93 420 (Frecenter): Fix doc-string typo.
454592a6 421
3633e3aa
KH
4222011-12-11 Kenichi Handa <handa@m17n.org>
423
424 * coding.c (Funencodable_char_position): Pay attention to the
425 buffer text relocation (Bug#9389).
426
7b9d523a
JD
4272011-12-10 Jan Djärv <jan.h.d@swipnet.se>
428
429 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
430 gtk_init (Bug#10100).
431
b73189c6
EZ
4322011-12-10 Eli Zaretskii <eliz@gnu.org>
433
434 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
435 IT->string is nil. (Bug#10263)
436
f7dfe5d6
JD
4372011-12-10 Jan Djärv <jan.h.d@swipnet.se>
438
83faebb4
JD
439 * nsterm.h (x_free_frame_resources): Declare.
440
f7dfe5d6
JD
441 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
442 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
443
444 * nsterm.h (ns_get_defaults_value): Declare.
445
446 * nsterm.m (ns_default): Call ns_get_defaults_value.
447
7cd4e72c
EZ
4482011-12-09 Eli Zaretskii <eliz@gnu.org>
449
450 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
451 (Bug#10170)
452
b34d7317
YM
4532011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
454
455 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
456 that where the value of an _OBJC_* symbol points to is in the .bss
457 section (Bug#10240).
458
76470ad1
KH
4592011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
460
461 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 462 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 463
745fff94
KH
4642011-12-08 Kenichi Handa <handa@m17n.org>
465
466 * ftfont.c (get_adstyle_property): Fix previous change
467 (Bug#10233).
468
6e44397c
JB
4692011-12-07 Juanma Barranquero <lekktu@gmail.com>
470
471 * w32.c (init_environment): If no_site_lisp, remove site-lisp
472 dirs from the default value of EMACSLOADPATH (bug#10208).
473
7efa6272
GM
4742011-12-07 Glenn Morris <rgm@gnu.org>
475
476 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
477 installation and source directories as well. (Bug#10208)
478
f6fc4d87
CY
4792011-12-06 Chong Yidong <cyd@gnu.org>
480
481 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
482
2bf26180
GM
4832011-12-06 Glenn Morris <rgm@gnu.org>
484
485 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
486 as an error, not just -1. (Bug#10217)
487
3a6ad4f0
CY
4882011-12-05 Chong Yidong <cyd@gnu.org>
489
490 * keyboard.c (process_special_events): New function.
491 (swallow_events, Finput_pending_p): Use it (Bug#10195).
492
75a3b399
PE
4932011-12-05 Paul Eggert <eggert@cs.ucla.edu>
494
495 * coding.c (encode_designation_at_bol): Don't use uninitialized
496 local variable (Bug#9318).
497
c3c9e25e
KH
4982011-12-05 Kenichi Handa <handa@m17n.org>
499
500 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
501 return Qnil (Bug#8046, Bug#10193).
502
5eb05ea3
KH
5032011-12-05 Kenichi Handa <handa@m17n.org>
504
505 * coding.c (encode_designation_at_bol): New args charbuf_end and
506 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
507 (coding_set_source): Return how many bytes coding->source was
508 relocated.
509 (coding_set_destination): Return how many bytes
510 coding->destination was relocated.
511 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
512 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
513
5142011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
515
516 * coding.c (CODING_CHAR_CHARSET_P): New macro.
517 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
518 macro (Bug#9318).
519
5202011-12-05 Andreas Schwab <schwab@linux-m68k.org>
521
522 The following changes are to fix Bug#9318.
523
a79703f5 524 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
525 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
526 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 527 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 528
7dbda6df
JB
5292011-12-05 Juanma Barranquero <lekktu@gmail.com>
530
531 * lisp.h (process_quit_flag): Fix external declaration.
532
6d5eb5b0
SM
5332011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
534
535 Don't macro-inline non-performance-critical code.
536 * eval.c (process_quit_flag): New function.
537 * lisp.h (QUIT): Use it.
538
a0c3fad0
JD
5392011-12-04 Jan Djärv <jan.h.d@swipnet.se>
540
541 * nsfns.m (get_geometry_from_preferences): New function.
542 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
543
6c07aac2
AS
5442011-12-04 Andreas Schwab <schwab@linux-m68k.org>
545
546 * emacs.c (Qkill_emacs): Define.
547 (syms_of_emacs): Initialize it.
548 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
549 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
550 (quit_throw_to_read_char): Add parameter `from_signal'.
551 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
552 * lisp.h (QUIT): Call Fkill_emacs if requested.
553
c052ead4
JD
5542011-12-03 Jan Djärv <jan.h.d@swipnet.se>
555
556 * widget.c (update_wm_hints): Return if wmshell is null.
557 (widget_update_wm_size_hints): New function.
558
559 * widget.h (widget_update_wm_size_hints): Declare.
560
561 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
562 widget_update_wm_size_hints (Bug#10104).
563
9e49252b
EZ
5642011-12-03 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (handle_invisible_prop): If the invisible text ends just
567 before a newline, prepare the bidi iterator for consuming the
568 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 569 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 570
02b16839
JL
5712011-12-02 Juri Linkov <juri@jurta.org>
572
573 * search.c (Fword_search_regexp): New Lisp function created from
574 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
575 (Fword_search_backward, Fword_search_forward)
576 (Fword_search_backward_lax, Fword_search_forward_lax):
577 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
578 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
579
0068070e
SM
5802011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
581
582 * fileio.c (Finsert_file_contents): Move after-change-function call
583 to before the "handled:" label, since all "goto handled" appear in
584 cases where the *-change-functions have already been properly called
585 (bug#10117).
586
3360a3fc
AS
5872011-12-01 Andreas Schwab <schwab@linux-m68k.org>
588
589 * keyboard.c (interrupt_signal): Don't call kill-emacs when
590 waiting for input. (Bug#10169)
591
73d6c093
EZ
5922011-11-30 Eli Zaretskii <eliz@gnu.org>
593
594 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
595 verifies glyph row's hash code--we have just reallocated the
596 glyphs, so their contents can be complete garbage. (Bug#10164)
597
febe6bea
JB
5982011-11-30 Juanma Barranquero <lekktu@gmail.com>
599
600 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
601
801a4313
EZ
6022011-11-30 Eli Zaretskii <eliz@gnu.org>
603
604 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
605 attributes are tested _before_ calling verify_row_hash, to protect
606 against GCC re-ordering of the tests. (Bug#10164)
607
2b56b87e
JD
6082011-11-29 Jan Djärv <jan.h.d@swipnet.se>
609
610 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
611
612 * xterm.c (handle_one_xevent): Only set async_visible and friends
613 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 614 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
615 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
616
dbf31225
PE
6172011-11-28 Paul Eggert <eggert@cs.ucla.edu>
618
619 Remove GCPRO-related macros that exist only to avoid shadowing locals.
620 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
621 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
622 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
623 All uses changed to use GCPRO1 etc.
624 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
625 Revert to old implementation (i.e., before 2011-03-11).
626
1305621b
YM
6272011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
628
629 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
630 of scroll runs so as to avoid assigning disabled bogus rows and
631 unnecessary graphics copy operations.
632
8c9afb46
EZ
6332011-11-27 Eli Zaretskii <eliz@gnu.org>
634
635 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
636 (snprintf) [_MSC_VER]: Redirect to _snprintf.
637 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
638 (malloc, free, realloc, calloc): Redirect to e_* only when
639 compiling Emacs.
640
641 * lisp.h (GCTYPEBITS): Move before first use.
642 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
643 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
644 this macro definition.
645
646 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
647 _MSC_VER.
648
54e9e3bf
JD
6492011-11-27 Jan Djärv <jan.h.d@swipnet.se>
650
6d5eb5b0
SM
651 * gtkutil.c (xg_create_frame_widgets):
652 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
653 present with Gtk+ 2.0.
654
83aca1cb
PE
6552011-11-26 Paul Eggert <eggert@cs.ucla.edu>
656
657 * fileio.c (Finsert_file_contents): Undo previous change; see
658 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
659
5b76caa4
PE
6602011-11-26 Paul Eggert <eggert@cs.ucla.edu>
661
662 Rename locals to avoid shadowing.
663 * fileio.c (Finsert_file_contents):
664 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
665 * process.c (wait_reading_process_output):
666 Rename inner 'proc' to 'p' to avoid shadowing.
667 Indent for consistency with usual Emacs style.
668
8c535114
EZ
6692011-11-25 Eli Zaretskii <eliz@gnu.org>
670
671 * xdisp.c (redisplay_window): If cursor row is not fully visible
672 after recentering, and scroll-conservatively is set to a large
673 number, scroll window by a few more lines to make the cursor fully
674 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
675 (start_display): Don't move to the next line if the display should
676 start at a newline that is part of a display vector or an overlay
677 string. (Bug#10119)
8c535114 678
fa4fdb5c
JL
6792011-11-24 Juri Linkov <juri@jurta.org>
680
681 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
682 after the `MagickPingImage' call. (Bug#10112)
683
90ec88df
CY
6842011-11-23 Chong Yidong <cyd@gnu.org>
685
686 * window.c (Fcoordinates_in_window_p): Accept only live windows.
687
56e2e794
MR
6882011-11-23 Martin Rudalics <rudalics@gmx.at>
689
690 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
691 making another buffer current. (Bug#10114)
692
b6e64c41
GM
6932011-11-23 Glenn Morris <rgm@gnu.org>
694
695 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
696
6b21de18
CY
6972011-11-23 Chong Yidong <cyd@gnu.org>
698
699 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
700 using it (Bug#5984).
701
b12cd789
EZ
7022011-11-22 Eli Zaretskii <eliz@gnu.org>
703
704 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
705 and header-lines, as they don't have one computed for them.
706 (Bug#10098)
707
708 * .gdbinit (prow): Make displayed values more self-explaining.
709 Add row's hash code.
710
261b6fd4
LMI
7112011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
712
713 * process.c (wait_reading_process_output): Fix asynchrounous
714 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 715 (wait_reading_process_output): Add comment and URL.
261b6fd4 716
e7cfd277
JD
7172011-11-21 Jan Djärv <jan.h.d@swipnet.se>
718
719 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
720
a9b9b7f5
CY
7212011-11-21 Chong Yidong <cyd@gnu.org>
722
723 * window.c (Fnext_window, Fprevious_window): Doc fix.
724
b0d15b4f
SM
7252011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
726
727 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
728
fe7a3057
JB
7292011-11-20 Juanma Barranquero <lekktu@gmail.com>
730
731 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
732
d2999b1a
MR
7332011-11-20 Martin Rudalics <rudalics@gmx.at>
734
735 * window.c (Fset_window_combination_limit): Rename argument
736 STATUS to LIMIT.
737 (Vwindow_combination_limit): Remove "status" from doc-string.
738
d5ff9cd0
AS
7392011-11-20 Andreas Schwab <schwab@linux-m68k.org>
740
741 * m/ibms390.h: Remove.
742 * m/ibms390x.h: Don't include "ibms390.h".
743
a5bb9bd3
SM
7442011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
745
746 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
747 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
748
cd1181db
JB
7492011-11-20 Juanma Barranquero <lekktu@gmail.com>
750
751 * casetab.c (Fset_case_table):
752 * charset.c (Fcharset_after): Fix typos.
753
615a3b8d 7542011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 755
17e845af
PE
756 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
757 Otherwise, valgrind does not work on some platforms.
758 Problem reported by Andreas Schwab in
6a0bf43d
PE
759 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
760 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
761 is set, removing the need for VIRT_ADDRESS_VARIES.
762 (PURE_P): Use a more-efficient implementation that needs just one
763 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
764 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
765 to 4 (xorl, subq, cmpq, setbe).
766 * alloc.c (pure): Always extern now, since that's the
767 VIRT_ADDR_VARIES behavior.
768 (PURE_POINTER_P): Use a single comparison, not two, for
769 consistency with the new puresize.h.
770 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
771 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
772 Remove VIRT_ADDR_VARIES no longer needed.
773
f8fe6f96
EZ
7742011-11-19 Eli Zaretskii <eliz@gnu.org>
775
776 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
777 (erase_phys_cursor, update_window_cursor, show_mouse_face)
778 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
779 behave as if the cursor position were at the window margin.
780
781 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
782 and the cursor position is out of bounds, behave as if the cursor
783 position were at the window margin. (Bug#10075)
784
df05a53c
CY
7852011-11-18 Chong Yidong <cyd@gnu.org>
786
787 * window.c (Fwindow_combination_limit): Make first argument
788 non-optional, since it is meaningless for live windows like the
789 selected window.
790
2071918e
DA
7912011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
792
793 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
794
b50a28de
SM
7952011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * intervals.c: Fix grafting over the whole buffer (bug#10071).
798 (graft_intervals_into_buffer): Simplify.
799
015137db
EZ
8002011-11-18 Eli Zaretskii <eliz@gnu.org>
801
802 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
803 hash values of the two rows.
804 (copy_row_except_pointers): Preserve the used[] arrays and the
805 hash values of the two rows. (Bug#10035)
68c95424 806 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
807
808 * xdisp.c (row_hash): New function, body extracted from
809 compute_line_metrics.
810 (compute_line_metrics): Call row_hash, instead of computing the
811 hash code inline.
812
813 * dispnew.c (verify_row_hash): Call row_hash for computing the
814 hash code of a row, instead of duplicating code from xdisp.c.
815
816 * dispextern.h (row_hash): Add prototype.
817
a2addb04
TH
8182011-11-18 Tassilo Horn <tassilo@member.fsf.org>
819
820 * frame.c (delete_frame): Don't delete the terminal when the last
821 X frame is closed if emacs is built with GTK toolkit.
822
df85d315
JB
8232011-11-17 Juanma Barranquero <lekktu@gmail.com>
824
825 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
826
a0c2d0ae
MR
8272011-11-17 Martin Rudalics <rudalics@gmx.at>
828
829 * window.c (Vwindow_splits): Rename to
830 Vwindow_combination_resize. Suggested by Juri Linkov.
831 (Fsplit_window_internal): Use Vwindow_combination_resize instead
832 of Vwindow_splits.
833
58179cce
JB
8342011-11-16 Juanma Barranquero <lekktu@gmail.com>
835
7877f373
JB
836 * nsfns.m (Fns_font_name):
837 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 838
b6f67890
MR
8392011-11-16 Martin Rudalics <rudalics@gmx.at>
840
841 * window.h (window): Rename slot "nest" to "combination_limit".
842 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
843 (Fset_window_nest): Rename to Fset_window_combination_limit.
844 (Vwindow_nest): Rename to Vwindow_combination_limit.
845 (recombine_windows, make_parent_window, make_window)
846 (Fsplit_window_internal, saved_window)
847 (Fset_window_configuration, save_window_save): Rename all
848 occurrences of window_nest to window_combination_limit.
849
c7015153
JB
8502011-11-15 Juanma Barranquero <lekktu@gmail.com>
851
852 * image.c (imagemagick_load_image): Fix typo.
853
322ad6ec
EZ
8542011-11-14 Eli Zaretskii <eliz@gnu.org>
855
856 * xdisp.c (display_line): Move the call to
857 highlight_trailing_whitespace before the call to
858 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
859 faces of all the glyphs to compute ROW's hash value.
860 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 861
f067b8ec
JB
8622011-11-14 Juanma Barranquero <lekktu@gmail.com>
863
864 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
865 just return (bug#10044).
866
1e5b2111
EZ
8672011-11-12 Eli Zaretskii <eliz@gnu.org>
868
7ef3cbd5
EZ
869 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
870 with user-defined heap size. Bump the default size of the temacs
871 heap to 27MB, to avoid memory warning when running temacs.
872 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
873
1e5b2111
EZ
874 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
875 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
876 (verify_row_hash) [XASSERTS]: New function.
877 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
878 that the hash value of glyph rows is correct.
1e5b2111 879
89d61221
MR
8802011-11-12 Martin Rudalics <rudalics@gmx.at>
881
882 * window.h (window): Remove splits slot.
883 * window.c (Fwindow_splits, Fset_window_splits): Remove.
884 (Fdelete_other_windows_internal, make_parent_window)
885 (make_window, Fsplit_window_internal, Fdelete_window_internal)
886 (Fset_window_configuration, save_window_save): Don't deal with
887 split status of windows.
888 (saved_window): Remove splits slot.
889 (Vwindow_splits): Rewrite doc-string.
890
97f18cc8
JD
8912011-11-11 Jan Djärv <jan.h.d@swipnet.se>
892
893 * xfns.c (unwind_create_frame):
894 * nsfns.m (unwind_create_frame):
895 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
896 Vframe_list (Bug#9999).
897
22a648b4
DA
8982011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
899
0b381c7e 900 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 901
659afede
KH
9022011-11-11 Kenichi Handa <handa@m17n.org>
903
904 * callproc.c (Fcall_process): Set the member dst_multibyte of
905 process_coding.
906
9ac0394b
KH
9072011-11-11 Johan Bockgård <bojohan@gnu.org>
908
909 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
910 avoid a crash (bug#9496).
911
2fbdc249
CY
9122011-11-09 Chong Yidong <cyd@gnu.org>
913
914 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
915 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
916
ac6b1f81
PE
9172011-11-08 Paul Eggert <eggert@cs.ucla.edu>
918
919 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
920
09db192c
PE
9212011-11-08 Paul Eggert <eggert@cs.ucla.edu>
922
923 Avoid some portability problems by eschewing 'extern inline' functions.
924 The trivial performance wins aren't worth the portability hassles; see
925 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
926 et seq.
927 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
928 (window_box_width, window_box_left, window_box_left_offset)
929 (window_box_right, window_box_right_offset): Undo previous change,
930 by removing the "extern"s.
931 * intervals.c (adjust_intervals_for_insertion)
932 (adjust_intervals_for_deletion): Undo previous change,
933 making these static again.
934 (offset_intervals, temp_set_point_both, temp_set_point)
935 (copy_intervals_to_string): No longer inline.
936 * xdisp.c (window_text_bottom_y, window_box_width)
937 (window_box_height, window_box_left_offset)
938 (window_box_right_offset, window_box_left, window_box_right)
939 (window_box): No longer inline.
940
105216ed
CY
9412011-11-08 Chong Yidong <cyd@gnu.org>
942
943 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
944 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
945 Signal an error if not a live window.
105216ed
CY
946 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
947 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
948
ae9e237f
JB
9492011-11-07 Juanma Barranquero <lekktu@gmail.com>
950
951 * lisp.h (syms_of_abbrev): Remove declaration.
952 Reported by CHENG Gao <chenggao@royau.me>.
953
c7aa8333
EZ
9542011-11-07 Eli Zaretskii <eliz@gnu.org>
955
956 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
957 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
958 of temacs in GUI mode.
959
be7f5545
MR
9602011-11-07 Martin Rudalics <rudalics@gmx.at>
961
962 * window.h: Declare delete_all_child_windows instead of
963 delete_all_subwindows.
964 * window.c (Fwindow_nest, Fset_window_nest)
965 (Fset_window_new_total, Fset_window_new_normal)
966 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
967 (delete_all_subwindows): Rename to delete_all_child_windows.
968 (Fdelete_other_windows_internal, Fset_window_configuration):
969 Call delete_all_child_windows instead of delete_all_subwindows.
970 * frame.c (delete_frame): Call delete_all_child_windows instead
971 of delete_all_subwindows.
972
ca78dc43
PE
9732011-11-07 Paul Eggert <eggert@cs.ucla.edu>
974
975 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
976 This is also needed for porting to any host where GC_MARK_STACK is
977 not GC_MAKE_GCPROS_NOOPS.
978 (which_symbols): Use it.
979
a0241d01
KH
9802011-11-07 Kenichi Handa <handa@m17n.org>
981
982 * coding.c (coding_set_destination): Check coding->src_pos only
983 when coding->src_object is a buffer (bug#9910).
984
985 * process.c (send_process): Set the member src_multibyte of coding
986 to 0 (bug#9911) when sending a unibyte text.
987
988 * callproc.c (Fcall_process): Set the member src_multibyte of
989 process_coding to 0 (bug#9912).
990
a64bfdfa 9912011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
992
993 * xmenu.c (cleanup_widget_value_tree): New function.
994 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
995 calling free_menubar_widget_value_tree directly (Bug#9830).
996
cb41b32a
PE
9972011-11-06 Paul Eggert <eggert@cs.ucla.edu>
998
999 Fix some portability problems with 'inline'.
1000 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1001 (window_box_width, window_box_left, window_box_left_offset)
1002 (window_box_right, window_box_right_offset): Declare extern.
1003 Otherwise, these inline functions do not conform to C99 and
1004 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1005 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1006 * intervals.c (adjust_intervals_for_insertion)
1007 (adjust_intervals_for_deletion): Now extern, because otherwise the
1008 extern inline functions 'offset_intervals' couldn't refer to it.
1009 (static_offset_intervals): Remove.
1010 (offset_intervals): Rewrite using the old contents of
1011 static_offset_intervals. The old version didn't conform to C99
1012 because an extern inline function contained a reference to an
1013 identifier with static linkage.
1014
b7041366
AS
10152011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1016
1017 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1018 GC.
1019
88a37c4d
EZ
10202011-11-06 Eli Zaretskii <eliz@gnu.org>
1021
1022 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1023 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1024 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1025 return Qleft_to_right.
1026
49745b39
CY
10272011-11-06 Chong Yidong <cyd@gnu.org>
1028
1029 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1030 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1031 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1032 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1033 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1034 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1035 (Fwindow_vscroll): Doc fix.
1036 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1037 argument, since it makes no sense to pass a live window and for
1038 consistency with window-child.
1039
1f05cd82
CS
10402011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1041
1042 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1043 support MSVC.
1044
22610910
JR
10452011-11-05 Jason Rumney <jasonr@gnu.org>
1046
1047 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1048 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1049 fonts (Bug#6029).
1050 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1051 bitwise arithmetic preventing use of unicode-sip and non-truetype
1052 opentype fonts.
1053
a06776b2
EZ
10542011-11-05 Eli Zaretskii <eliz@gnu.org>
1055
3ad924ba
EZ
1056 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1057 "emacs"-only part.
1058
a06776b2
EZ
1059 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1060 initialization code to keep similarity to xfns.c after changes
1061 from 2011-11-05.
1062
c9e7db78
JD
10632011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1064
a97f8f3f
JD
1065 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1066 (unwind_create_frame): New function (Bug#9943).
1067 (Fx_create_frame): Restructure code to be more similar to the one in
1068 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1069 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1070 Move terminal->reference_count++ just before making the frame official
1071 (Bug#9943).
1072
1073 * nsterm.m (x_free_frame_resources): New function.
1074 (x_destroy_window): Move code to x_free_frame_resources.
1075
c9e7db78 1076 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1077 (Fx_create_frame, x_create_tip_frame):
1078 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1079 official. Move initialization of image_cache_refcount and
1080 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1081
a6fc3b5c
EZ
10822011-11-05 Eli Zaretskii <eliz@gnu.org>
1083
1084 Support MSVC build with newer versions of Visual Studio.
1085 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1086 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1087 nt/gmake.defs.
1088
1089 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1090 which are not supported by MSVC.
1091 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1092 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1093 bitfields.
1094 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1095 types in bitfields.
1096 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1097
1098 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1099
58179cce 11002011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1101
1102 Support MSVC build with newer versions of Visual Studio.
1103 * w32.c: Don't include w32api.h for MSVC.
1104 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1105
1106 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1107 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1108 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1109 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1110 e_* cousins.
1111 (alloca) [_MSC_VER]: Define to _alloca.
1112
1113 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1114
1115 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1116
a58c13ed
EZ
11172011-11-04 Eli Zaretskii <eliz@gnu.org>
1118
1119 * xdisp.c (note_mouse_highlight): If either of
1120 previous/next-single-property-change returns nil, treat that as
1121 the beginning or the end of the buffer. (Bug#9955)
1122
fe0b6370
JD
11232011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1124
a58c13ed 1125 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1126 label is not null (Bug#9951).
1127 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1128 may be NULL.
1129
89bd5ee1
EZ
11302011-11-04 Eli Zaretskii <eliz@gnu.org>
1131
1132 * window.c (Fwindow_body_size): Mention in the doc string that the
1133 return value is in frame's canonical units. (Bug#9949)
1134
84c3edb9
EZ
11352011-11-03 Eli Zaretskii <eliz@gnu.org>
1136
4e2fb5c7
EZ
1137 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1138
84c3edb9 1139 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1140 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1141 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1142
bc17a887
EZ
11432011-11-01 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1146 Don't stop backward scan on the continuation glyph, even though
1147 its CHARPOS is positive.
6d5eb5b0
SM
1148 (mouse_face_from_buffer_pos, note_mouse_highlight):
1149 Rename cover_string to disp_string.
bc17a887 1150
4ee88440
MR
11512011-11-01 Martin Rudalics <rudalics@gmx.at>
1152
1153 * window.c (temp_output_buffer_show): Don't use
1154 Vtemp_buffer_show_specifiers.
1155 (Vtemp_buffer_show_specifiers): Remove unused variable.
1156
c2ff3c02
EZ
11572011-10-30 Eli Zaretskii <eliz@gnu.org>
1158
1159 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1160 past the beginning of the current glyph matrix.
1161
58179cce 11622011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1163
1164 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1165 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1166 HAVE_GTK3 (Bug#9869).
b77a6a7f 1167
3b574623
JD
1168 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1169 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1170
b77a6a7f
JD
1171 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1172
1173 * xterm.c: Declare x_handle_net_wm_state to return int.
1174 (handle_one_xevent): Check if we are iconified but don't have
1175 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1176 (get_current_wm_state): Return non-zero if not hidden,
1177 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1178 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1179 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1180 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1181
196e41e4
PE
11822011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1183
1184 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1185 so that this new function doesn't get optimized away by a
1186 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1187
021f2e1a
AS
11882011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1189
1190 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1191
8b058d44
EZ
11922011-10-29 Eli Zaretskii <eliz@gnu.org>
1193
1194 Fix the `xbytecode' command.
1195 * .gdbinit (xprintbytestr): New command.
b50a28de 1196 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1197 (xbytecode): Print the byte-code string as well.
1198
4452fb80
EZ
11992011-10-29 Kim Storm <storm@cua.dk>
1200
8b058d44
EZ
1201 * alloc.c (which_symbols): New function.
1202
21b72067
AS
12032011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1204
1205 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1206 line. (Bug#9903)
1207
83ed7b5c
GM
12082011-10-29 Glenn Morris <rgm@gnu.org>
1209
1210 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1211 Not clear what it was for, and it causes various bugs. (Bug#9839)
1212
5a7a728b
EZ
12132011-10-28 Eli Zaretskii <eliz@gnu.org>
1214
1215 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1216 possible random value that matches one of those tested as
1217 condition to clear the mouse face.
1218
d3d0842f
CY
12192011-10-28 Chong Yidong <cyd@gnu.org>
1220
1221 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1222
31b39d13
DN
12232011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1224
1225 * window.c (make_window): Initialize phys_cursor_on_p.
1226
9aba6043
SM
12272011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1228
1229 * lisp.h (struct Lisp_Symbol): Update comments.
1230
c20992f4
JB
12312011-10-28 Juanma Barranquero <lekktu@gmail.com>
1232
1233 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1234
db4f02f2
EZ
12352011-10-28 Eli Zaretskii <eliz@gnu.org>
1236
1237 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1238 <oslsachem@gmail.com> for helping to debug this.
1239
1240 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1241 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1242 (g_b_init_get_glyph_outline_w): New static variables.
1243 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1244 (GetGlyphOutlineW_Proc): New typedefs.
1245 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1246 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1247 New functions.
1248 (w32font_open_internal, compute_metrics):
1249 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1250 instead of calling the "wide" APIs directly.
1251
1252 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1253
1254 * w32.h (syms_of_w32font): Add prototype.
1255
87e68db4
JB
12562011-10-27 Juanma Barranquero <lekktu@gmail.com>
1257
1258 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1259 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1260 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1261 (Fmove_to_window_line): Doc fix.
1262
435c1d67
CY
12632011-10-27 Chong Yidong <cyd@gnu.org>
1264
1265 * process.c (make_process): Set gnutls_state to NULL.
1266
1267 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1268 non-NULL, regardless of GNUTLS_INITSTAGE.
1269 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1270 an error. Set process slots as soon as we allocate them.
1271
1272 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1273
9c6c6f49
CY
12742011-10-27 Chong Yidong <cyd@gnu.org>
1275
9aba6043
SM
1276 * gnutls.c (emacs_gnutls_deinit): New function.
1277 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1278 (Fgnutls_deinit, Fgnutls_boot): Use it.
1279
1280 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1281 (deactivate_process): Call emacs_gnutls_deinit.
1282
657d08d3
JB
12832011-10-27 Juanma Barranquero <lekktu@gmail.com>
1284
1285 * image.c (x_create_x_image_and_pixmap):
1286 * w32.c (sys_rename, w32_delayed_load):
1287 * w32font.c (fill_in_logfont):
1288 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1289
5430d399
JB
12902011-10-26 Juanma Barranquero <lekktu@gmail.com>
1291
1292 * w32fns.c (w32_default_color_map): New function,
1293 extracted from Fw32_default_color_map.
a7ef684b 1294 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1295
fe0055fa
PE
12962011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1299
e6346438
SM
13002011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1301
1302 * keyboard.c (test_undefined): New function (bug#9751).
1303 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1304
e112cc37
ET
13052011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1306
1307 * sysdep.c (init_sys_modes): Fix the check for the controlling
1308 terminal (Bug#6649).
1309
7b5d6677
EZ
13102011-10-20 Eli Zaretskii <eliz@gnu.org>
1311
1312 * dispextern.h (struct bidi_it): New member next_en_type.
1313
1314 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1315 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1316 current character, check also for next_en_type being WEAK_EN.
1317 (bidi_resolve_weak): Don't enter the expensive loop if the current
1318 position is before next_en_pos. Record the bidi type of the first
1319 non-ET, non-BN character we find, in addition to its position.
1320 (bidi_level_of_next_char): Invalidate next_en_type when
1321 next_en_pos is over-stepped.
1322
7da0b018
PE
13232011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1326 * editfns.c: Rewrite current-time-zone so that it invokes
1327 the equivalent of (format-time-string "%Z") to get the time zone name.
1328 This fixes a bug when the time zone name contains characters that
1329 need converting from the system time locale to Emacs internal format.
1330 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1331 that patch fixed format-time-string to do the conversion, but
1332 I forgot to fix current-time-zone.
1333 (format_time_string): New function, containing most of
1334 what Fformat_time_string used to contain.
1335 (Fformat_time_string): Rewrite in terms of format_time_string.
1336 This doesn't change this function's behavior.
1337 (current-time-zone): Rewrite to use format_time_string.
1338 This fixes the bug reported by Michael Schierl in
1339 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1340 Jason Rumney's 2007-06-07 change worked around this bug, but
1341 didn't fix it.
1342 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1343
8547b010
EZ
13442011-10-19 Eli Zaretskii <eliz@gnu.org>
1345
1346 * xdisp.c (start_display): If the character at POS is displayed
1347 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1348 (try_window_reusing_current_matrix): If a line ends in a display
1349 vector or the next line starts in a display vector, continue
1350 redrawing the window even though the character position of
1351 start_row was reached.
8547b010
EZ
1352 (Bug#9771, part 2)
1353
4e948d15
CY
13542011-10-18 Chong Yidong <cyd@gnu.org>
1355
1356 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1357 with nobreak-char-display too.
1358
4787455f
EZ
13592011-10-18 Eli Zaretskii <eliz@gnu.org>
1360
1361 Fix part 3 of bug#9771.
1362 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1363 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1364 non-neutral characters if the current character is a paragraph
1365 separator (a.k.a. Newline). This avoids running the same
1366 expensive loop twice, once when we consume the preceding newline
1367 and the other time when the line actually needs to be displayed.
1368 Avoid the loop when we see neutrals on the base embedding level
1369 following a character whose directionality is the same as the
1370 paragraph's. This avoids running the expensive loop when a line
1371 ends in a long sequence of neutrals, like control characters.
1372 Add assertion against STRONG_AL type. Slightly rearrange code
1373 that determines the type of a neutral given the first non-neutral
1374 that follows it.
1375 (bidi_level_of_next_char): Set next_en_pos to zero when
1376 invalidating its info.
1377
2c91f553
EZ
13782011-10-17 Eli Zaretskii <eliz@gnu.org>
1379
1380 * xdisp.c (push_display_prop): Determine whether to record string
1381 or buffer position by IT->string, not by IT->method. Allow
1382 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1383 (move_it_vertically_backward): Don't look for character position
1384 immediately after the newline when in a continuation line.
1385 (Bug#9771, part 1)
2c91f553 1386
c7b08b0d
MR
13872011-10-15 Martin Rudalics <rudalics@gmx.at>
1388
1389 * window.c (coordinates_in_window): Rewrite and delabelize
1390 vertical border check. (Bug#5357) (Bug#9618)
1391
6b02f655
SM
13922011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1393
1394 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1395 errors in XSetWindowBorder (bug#9310).
1396
81d40c92
DA
13972011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1398
1399 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1400 avoid crash when xmalloc overrun checking is enabled.
1401
d4172c3b
EZ
14022011-10-13 Eli Zaretskii <eliz@gnu.org>
1403
1404 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1405 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1406 cursor motion with <left> and <right> arrow keys.
1407
1408 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1409 some callers set that themselves.
1410
b00eea75
EZ
14112011-10-12 Eli Zaretskii <eliz@gnu.org>
1412
1413 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1414 display string and the previous row comes from the same string and
1415 is empty. (Bug#9739) (Bug#9738)
1416
8fe012c4
SM
14172011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * doc.c (get_doc_string): Encode file name (bug#9735).
1420
0074aef2
EZ
14212011-10-12 Eli Zaretskii <eliz@gnu.org>
1422
79beb178
EZ
1423 * bidi.c (bidi_level_of_next_char):
1424 * xdisp.c (get_visually_first_element): Remove old incorrect
1425 comments regarding the Unicode Line Separator character.
1426
0074aef2
EZ
1427 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1428
6e4b3fbe
DA
14292011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1430
1431 * alloc.c (Fgc_status): Do not access beyond zombies array
1432 boundary if nzombies > MAX_ZOMBIES.
1433 * alloc.c (dump_zombies): Add missing format specifier.
1434
0324f3af
PE
14352011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1436
b5525cac
PE
1437 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1438 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1439
0324f3af
PE
1440 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1441 Some packages use them to denote characters with modifiers.
1442
e9b5f888
AS
14432011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1444
1445 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1446 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1447 matching a pp-number. Rename parameter var to var1.
1448
127827c0
SM
14492011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1450
1451 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1452
c8fd3bd0
GM
14532011-10-08 Glenn Morris <rgm@gnu.org>
1454
1455 * callint.c (Fcall_interactively): Give a more explicit error for the
1456 'c' case with a non-character input. (Bug#8479)
1457
352ec8ff
EZ
14582011-10-08 Eli Zaretskii <eliz@gnu.org>
1459
03669ccb
EZ
1460 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1461 lines.
7061c986
EZ
1462 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1463 lines that are hscrolled on the left.
03669ccb 1464
352ec8ff
EZ
1465 * dispnew.c (buffer_posn_from_coords): Account for a possible
1466 presence of header-line. (Bug#4426)
1467
a66cfb1c
SM
14682011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1469
6b02f655
SM
1470 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1471 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1472
7c5ee88e
PE
14732011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1474
1475 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1476 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1477 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1478 this makes Emacs dump core during garbage collection on rare
1479 occasions. sizeof is obviously inferior to offsetof here, so
1480 stick with offsetof.
1481 (GC_POINTER_ALIGNMENT): New macro.
1482 (mark_memory): Omit 3rd (offset) arg; caller changed.
1483 Don't assume EMACS_INT alignment is the same as pointer alignment.
1484
df1bbe5b
SM
14852011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1486
1487 * keyboard.c (read_key_sequence_remapped): New var.
1488 (read_key_sequence): Compute remapping in the right buffer.
1489 (command_loop_1): Use read_key_sequence's remapping directly.
1490
51553db6
SM
14912011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1492
32c1fffd
SM
1493 * dired.c (file_name_completion): Don't expand file name.
1494 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1495 before checking file name handler.
1496
51553db6
SM
1497 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1498 they've been requested explicitly (bug#9591).
1499
b6bd1599 15002011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1501
1502 * keymap.c (Fsingle_key_description): Use make_specified_string
1503 instead of build_string to build string from push_key_description.
1504 (Bug#5193)
1505
f701dc2a
PE
15062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1507
4222c55d
PE
1508 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1509 This fixes a Y2038 bug on 64-bit hosts.
1510 * buffer.c (reset_buffer):
1511 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1512 (Fclear_buffer_auto_save_failure):
1513 Use 0, not -1, to represent an unset failure time, since time_t
1514 might not be signed.
1515
f701dc2a
PE
1516 Remove dependency on glibc malloc internals.
1517 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1518 Move back here from lisp.h, but with their new implementations.
1519 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1520 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1521 * charset.c (charset_table_init): New static var.
1522 (syms_of_charset): Use it instead of xmalloc. This removes a
1523 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1524 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1525 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1526 Move back to alloc.c.
1527 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1528 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1529
9ceebf39
JD
15302011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1531
1532 * nsterm.m (windowDidResize): Call x_set_window_size only when
1533 ns_in_resize is true. Otherwise set pixelwidth/height and
1534 call change_frame_size (Bug#9628).
1535
cb993c58
PE
15362011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1537
3930c88b
PE
1538 Port --enable-checking=all to Fedora 14 x86-64.
1539 * charset.c (syms_of_charset): Also account for glibc malloc's
1540 internal overhead when calculating the initial malloc maximum.
1541
cb993c58
PE
1542 Port --enable-checking=all to Fedora 14 x86.
1543 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1544 Move to lisp.h.
1545 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1546 (overrun_check_realloc, overrun_check_free):
1547 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1548 That way, xmalloc returns a properly-aligned pointer even if
1549 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1550 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1551 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1552 into account when calculating the initial malloc maximum.
1553 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1554 Move here from alloc.c, so that charset.c can use it too.
1555 Properly align; the old code wasn't right for common 32-bit hosts
1556 when configured with --enable-checking=all.
1557 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1558 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1559
31bed486
EZ
15602011-09-29 Eli Zaretskii <eliz@gnu.org>
1561
04c70788 1562 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1563 use EDOM.
1564
fbcaa2f3
EZ
15652011-09-28 Eli Zaretskii <eliz@gnu.org>
1566
1567 * xdisp.c (compute_display_string_end): If there's no display
1568 string at CHARPOS, return -1.
1569
1570 * bidi.c (bidi_fetch_char): When compute_display_string_end
1571 returns a negative value, treat the character as a normal
1572 character not covered by a display string. (Bug#9624)
1573
a239d4e9
JB
15742011-09-28 Juanma Barranquero <lekktu@gmail.com>
1575
1576 * lread.c (Fread_from_string): Fix typo in docstring.
1577
88652fd5
EZ
15782011-09-27 Eli Zaretskii <eliz@gnu.org>
1579
1580 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1581 newline, reseat the iterator instead of bidi-iterating there one
1582 character at a time. (Bug#9610)
32c1fffd
SM
1583 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1584 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1585
ed497dd4
AS
15862011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1587
1588 * lread.c (readevalloop): Use correct code for NBSP.
1589 (read1): Likewise. (Bug#9608)
1590
b2bf61aa
MA
15912011-09-25 Michael Albinus <michael.albinus@gmx.de>
1592
1593 * dbusbind.c (Fdbus_register_signal): When service is not
1594 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1595
32bbb17c
GM
15962011-09-25 Glenn Morris <rgm@gnu.org>
1597
1598 * buffer.c (truncate-lines): Doc fix.
1599
94e0933e
CY
16002011-09-24 Chong Yidong <cyd@stupidchicken.com>
1601
1602 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1603 (Fset_window_next_buffers): Doc fix.
1604
cddde921
GM
16052011-09-24 Glenn Morris <rgm@gnu.org>
1606
1607 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1608
1260aef1
PE
16092011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1610
25b4bfa0
PE
1611 Fix minor problems found by static checking.
1612 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1613 * indent.c (Fvertical_motion): Fix == vs = typo.
1614
e3cbd34b
EZ
16152011-09-24 Eli Zaretskii <eliz@gnu.org>
1616
a66cfb1c
SM
1617 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1618 Default value is now t. Doc fix.
6bf7006f 1619
e3cbd34b 1620 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1621 logic when moving up, not only when moving down. Fix the
e3cbd34b 1622 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1623 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1624
1625 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1626 CHARPOS is covered by a display string which includes newlines.
1627 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1628 is covered by a display string with embedded newlines.
1629
a3de0cbd
MA
16302011-09-24 Michael Albinus <michael.albinus@gmx.de>
1631
1632 * dbusbind.c (Fdbus_register_signal): Add match rule to
1633 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1634 (Fdbus_register_method, Vdbus_registered_objects_table):
1635 Fix docstring.
a3de0cbd 1636
b260039d
JM
16372011-09-24 Jim Meyering <meyering@redhat.com>
1638
32c1fffd 1639 do not ignore write error for any output size
b260039d
JM
1640 The previous change was incomplete.
1641 While it makes emacs --batch detect the vast majority of stdout
1642 write failures, errors were still ignored whenever the output size is
1643 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1644 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1645 && echo FAIL: ignored write error
1646 FAIL: ignored write error
1647 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1648 && echo FAIL: ignored write error
1649 FAIL: ignored write error
1650 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1651
8eca8a7c
AS
16522011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1653
1654 * emacs.c (Fkill_emacs): In noninteractive mode exit
1655 non-successfully if a write error occurred on stdout. (Bug#9574)
1656
3341db62
EZ
16572011-09-21 Eli Zaretskii <eliz@gnu.org>
1658
1659 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1660 the xassert test.
1661
1662 * dispextern.h (struct it): Update the comment documenting what
1663 can it->OBJECT be.
1664
8c203dbf
EZ
16652011-09-20 Eli Zaretskii <eliz@gnu.org>
1666
1667 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1668 a display string, extend search for cursor position to end of row.
1669 (find_row_edges): If the row ends in a newline from a display
1670 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1671 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1672 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1673 non-empty line. Fixes confusing cursor motion with arrow keys at
1674 the beginning of a line that starts with whitespace.
8c203dbf 1675
a4824228
LMI
16762011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1677
1678 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1679 (bug#9493).
1680
33ed493b
CY
16812011-09-18 Chong Yidong <cyd@stupidchicken.com>
1682
1683 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1684 boolean (Bug#9154).
1685
56cd55c8
EZ
16862011-09-18 Eli Zaretskii <eliz@gnu.org>
1687
1688 * xdisp.c (display_line): Record maximum and minimum buffer
1689 positions even if no glyphs were produced (e.g., by a zero-width
1690 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1691 buffer positions that will be removed from the glyph row because
1692 they don't fit.
c02dcedf
EZ
1693 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1694 column is beyond frame width: don't subtract 1 "pixel" when
1695 computing width of the stretch.
3e62b7e0
EZ
1696 (reseat_at_next_visible_line_start): Undo the change made on
1697 2011-09-17 that saved paragraph information and restored it after
1698 the call to `reseat'. (Bug#9545)
56cd55c8 1699
5ed99d36 17002011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1701
1702 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1703 and turn window cursor on if cleared (Bug#9415).
1704
5ed99d36 17052011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1706
1707 * search.c (boyer_moore): Take unibyte characters from pattern
1708 literally. (Bug#9458)
1709
9bade7b2
EZ
17102011-09-18 Eli Zaretskii <eliz@gnu.org>
1711
1712 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1713
e5e9d610
PE
17142011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1715
87e4427a
PE
1716 Fix minor problem found by static checking.
1717 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1718 initialized, to pacify gcc -Wuninitialized.
1719
e5e9d610
PE
1720 * fileio.c: Report proper errno when syscall falls.
1721 (Finsert_file_contents): Save and restore errno,
1722 so that report_file_error outputs the correct diagnostic.
1723 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1724
a1674f0b
EZ
17252011-09-18 Eli Zaretskii <eliz@gnu.org>
1726
1727 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1728
fbfb6dd4
EZ
17292011-09-17 Eli Zaretskii <eliz@gnu.org>
1730
1731 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1732 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1733
bb187662
EZ
17342011-09-17 Eli Zaretskii <eliz@gnu.org>
1735
1137e8b8 1736 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1737 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1738
1739 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1740 (bidi_find_paragraph_start): Search back for paragraph beginning
1741 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1742 (bidi_move_to_visually_next): Only trigger paragraph-related
1743 computations when the last character is a newline or at EOB, not
1744 just any NEUTRAL_B. (Bug#9470)
1745
bb187662
EZ
1746 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1747 truncated lines if point is covered by a display string. (Bug#9524)
1748
2e621251
PE
17492011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1750
1751 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1752 (cons_to_x_long): New function.
1753 (lisp_data_to_selection_data): Use it. Correct the test for
1754 short-versus-long data; it was negated. Break out of vector
1755 loop, for efficiency, when a long datum is discovered.
1756
91a15bc6
SM
17572011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1758
1759 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1760
b41c3a35
EZ
17612011-09-16 Eli Zaretskii <eliz@gnu.org>
1762
1763 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1764 GCC PR/17406) by declaring this function with external scope.
1765
7812ba2d
PE
17662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1769 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1770
cf7edc2a
AS
17712011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1772
1773 * editfns.c (Fformat): Correctly handle text properties on "%%".
1774
bd01620e
EZ
17752011-09-15 Eli Zaretskii <eliz@gnu.org>
1776
1777 * xterm.c (x_draw_composite_glyph_string_foreground):
1778 * w32term.c (x_draw_composite_glyph_string_foreground):
1779 * term.c (encode_terminal_code):
1780 * composite.c (composition_update_it, get_composition_id):
1781 * xdisp.c (get_next_display_element)
1782 (fill_composite_glyph_string): Add comments about special meaning
1783 of TAB characters in a composition.
1784
a02719a3
PE
17852011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1786
1787 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1788 This occurs when processing a multibyte format.
1789 Problem reported by Wolfgang Jenker.
a02719a3 1790
72589a3c
JB
17912011-09-15 Johan Bockgård <bojohan@gnu.org>
1792
1793 * xdisp.c (try_cursor_movement): Only check for exact match if
1794 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1795
1c14176c
PE
17962011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 Remove unused external symbols.
1799 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1800 * xdisp.c (calc_pixel_width_or_height): Now static.
1801 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1802 * indent.c (check_display_width):
1803 * w32term.c: Fix comment to match code.
1804 * xterm.c, xterm.h (x_catching_errors): Remove.
1805
d2eea5b5
PE
18062011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1807
1808 * xselect.c: Use signed conversions more consistently (Bug#9498).
1809 (selection_data_to_lisp_data): Assume incoming selection data are
1810 signed integers, not unsigned. This is to be consistent with
1811 outgoing selection data, which was modified to use signed integers
1812 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1813 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1814 expects long, not unsigned long.
1815
46888499
EZ
18162011-09-14 Eli Zaretskii <eliz@gnu.org>
1817
1818 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1819 computation of loop end. Reported by Johan Bockgård
1820 <bojohan@gnu.org>.
1821
ef8ef9fb
CY
18222011-09-13 Chong Yidong <cyd@stupidchicken.com>
1823
1824 * frame.c (Fother_visible_frames_p): Function deleted.
1825
fa819fed
EZ
18262011-09-12 Eli Zaretskii <eliz@gnu.org>
1827
1828 * indent.c (compute_motion): Process display vector front to back
1829 rather than the other way around. (Bug#2496)
1830
2ba8e008
SM
18312011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1832
1833 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1834
20f53c69
CY
18352011-09-11 Chong Yidong <cyd@stupidchicken.com>
1836
1837 * minibuf.c (Fread_from_minibuffer): Doc fix.
1838
d562d7a4
EZ
18392011-09-11 Eli Zaretskii <eliz@gnu.org>
1840
1841 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1842 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1843
1c4d7f3d
LMI
18442011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1845
1846 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1847 value for non-existent files.
1848
b885bf36
EZ
18492011-09-11 Eli Zaretskii <eliz@gnu.org>
1850
1851 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1852 set its "size" to -1. This will set the modtime_size field of
1853 the corresponding buffer to -1, which is what
1854 verify-visited-file-modtime expects for files that do not exist.
1855 (Bug#9139)
1856
6612f0bf
PE
18572011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1860 here ...
1861 * lisp.h: ... from here. push_key_description is no longer
1862 defined in keyboard.c, so its declaration should not be in
1863 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1864 logically belongs with push_key_description.
1865
dfb3f755
PE
18662011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1867
1868 * buffer.h: Include <sys/types.h> instead of <time.h>.
1869 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1870 Problem reported by Herbert J. Skuhra.
1871
3134906c
LMI
18722011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1873
1874 * xml.c (parse_region): Make the parsing work for
1875 non-comment-starting XML files again (bug#9144).
1876
8d903f4e
AS
18772011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1878
1879 * image.c (gif_load): Fix calculation of bottom and right corner.
1880 (Bug#9468)
1881
80ad64f4
EZ
18822011-09-10 Eli Zaretskii <eliz@gnu.org>
1883
1884 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1885 redisplay in small windows.
1886
208a048d
EZ
18872011-09-09 Eli Zaretskii <eliz@gnu.org>
1888
1889 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1890
9b1c252e
MR
18912011-09-08 Martin Rudalics <rudalics@gmx.at>
1892
1893 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1894 Operate on live windows only.
1895
2949f33b
JB
18962011-09-08 Juanma Barranquero <lekktu@gmail.com>
1897
1898 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1899
e08dcafd
EZ
19002011-09-07 Eli Zaretskii <eliz@gnu.org>
1901
1902 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1903 only under bidi iteration.
1904
115b96bd
JD
19052011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1906
1907 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1908
c8199d0f
PE
19092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1910
1911 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1912 Without this fix, the command to link temacs failed due to an
1913 undefined symbol __builtin_isnan. This is because
1914 /usr/include/iso/math_c99.h #defines isnan(x) to
1915 __builtin_isnan(x), but the bundled gcc, which identifies itself
1916 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1917 a __builtin_isnan.
1918 * floatfns.c (isnan): #undef, and then #define to a clone of
1919 what's in data.c.
1920 (Fisnan): Always define, since it's always available now.
1921 (syms_of_floatfns): Always define isnan at the Lisp level.
1922
e39b275c 19232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1924
1925 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1926
b2db44d9 19272011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1928
f4af5137 1929 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1930 The previous code assumed that file offsets (off_t values) fit in
1931 EMACS_INT variables, which is not true on typical 32-bit hosts.
1932 The code messed up by falsely reporting buffer overflow in cases
1933 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1934 when "big" contains more than 2**29 bytes, even though this
1935 inserts just one byte and does not overflow the buffer.
1936 (Finsert_file_contents): Store file offsets as off_t
1937 values, not as EMACS_INT values. Check for overflow when
1938 converting between EMACS_INT and off_t. When checking for
1939 buffer overflow or for overlap, take the offsets into account.
1940 Don't use EMACS_INT for small values where int suffices.
1941 When checking for overlap, fix a typo: ZV was used where
1942 ZV_BYTE was intended.
1943 (Fwrite_region): Don't assume off_t fits into 'long'.
1944 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1945
ecfc0a49
MA
19462011-09-05 Michael Albinus <michael.albinus@gmx.de>
1947
1948 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1949
6511acf2 19502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1951
0999621a 1952 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1953
1954 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1955 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1956 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1957 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1958 (modify_event_symbol): Do not assume that the length of
1959 name_alist_or_stem is safe to alloca and fits in int.
1960 (Fexecute_extended_command): Likewise for function name and binding.
1961 (Frecursion_depth): Wrap around reliably on integer overflow.
1962 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1963 since some callers pass EMACS_INT values.
1964 (Fsingle_key_description): Don't crash if symbol name contains more
1965 than MAX_ALLOCA bytes.
1966 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1967 (get_minibuffer): Arg is now EMACS_INT, not int.
1968 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1969 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1970 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1971
2be7d702
PE
1972 * dbusbind.c (signature_cat): New function.
1973 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1974 Do not overrun buffer; instead, report string overflow.
1975
9d1df220
PE
1976 * dispnew.c (add_window_display_history): Don't overrun buffer.
1977 Truncate instead; this is OK since it's just a log.
1978
33ef5c64
PE
1979 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1980 even if the time zone offset is outlandishly large.
1981 Don't mishandle offset == INT_MIN.
1982
66c6fdd5
PE
1983 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1984 when creating daemon; the previous buffer-overflow check was incorrect.
1985
d749b01b
PE
1986 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1987 which has the guts of the old verror function.
1988
b5cd1905
PE
1989 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1990 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1991
6e1a67fb
PE
1992 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1993 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1994 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1995 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1996 length of string rather than counting it via multiple sprintfs;
1997 that's simpler and more reliable.
c21721cc
PE
1998 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1999 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2000 sprintf, in case result does not fit in int.
2001
c57b67fc
PE
2002 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2003 (fontset_from_font): Print it.
2004
8a401434
PE
2005 * frame.c (tty_frame_count): Now printmax_t, not int.
2006 (make_terminal_frame, set_term_frame_name): Print it.
2007 (x_report_frame_params): In X, window IDs are unsigned long,
2008 not signed long, so print them as unsigned.
2009 (validate_x_resource_name): Check for implausibly long names,
2010 and don't assume name length fits in 'int'.
2011 (x_get_resource_string): Don't blindly alloca invocation name;
2012 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2013 not fit in int.
2014
6e1a67fb
PE
2015 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2016 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2017 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2018
0df02bf3
PE
2019 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2020 Use esprintf, not sprintf, in case result does not fit in int.
2021
48e30793
PE
2022 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2023 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2024 it as a large positive number.
2025 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2026 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2027
a66ff6d8
PE
2028 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2029 in case result does not fit in int.
2030
aca216ff
PE
2031 * print.c (float_to_string): Detect width overflow more reliably.
2032 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2033 buffer overrun. Don't assume list length fits in 'int'. Treat
2034 print length of 0 as 0, not as infinity; to be consistent with other
2035 uses of print length in this function. Don't overflow print length
2036 index. Don't assume hash table size fits in 'long', or that
2037 vectorlike size fits in 'unsigned long'.
2038
31c286f7
PE
2039 * process.c (make_process): Use printmax_t, not int, to format
2040 process-name gensyms.
2041
55e5faa1
PE
2042 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2043
80f2e268
PE
2044 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2045 to avoid potential buffer overrun.
2046
670741ab
PE
2047 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2048 if X resource line is longer than 512 bytes.
2049
b7163a50
PE
2050 * xfns.c (x_window): Make sprintf buffer a bit bigger
2051 to avoid potential buffer overrun.
2052
ae58ff1f
PE
2053 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2054
c43c8a6a
PE
2055 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2056
3f8236f4
PE
20572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2058
53e9fe90 2059 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2060 Without these, Emacs silently mishandles large integers sometimes.
2061 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2062 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2063
6511acf2
PE
2064 * xdisp.c (try_window_id): Check Emacs fixnum range before
2065 converting to 'int'.
806add1d 2066
6511acf2 2067 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2068 Check that an Emacs fixnum is in range before assigning it to 'int'.
2069 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2070 values converted from Emacs fixnums.
2071 (Frecenter): Don't wrap around a line count if it is out of 'int'
2072 range; instead, treat it as an extreme value.
2073 (Fset_window_configuration, compare_window_configurations):
2074 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2075
6511acf2
PE
2076 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2077 that can exceed INT_MAX. Check that EMACS_INT value is in range
2078 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2079 (match_limit): Don't assume that a fixnum can fit in 'int'.
2080
6511acf2 2081 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2082 exceed INT_MAX.
2083
6511acf2 2084 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2085 (Fvertical_motion): Don't wrap around LINES values that don't fit
2086 in 'int'. Instead, treat them as extreme values. This is good
2087 enough for windows, which can't have more than INT_MAX lines anyway.
2088
fcb901a7
LMI
20892011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2090
0f2f6b6d
LMI
2091 * Require libxml/parser.h to avoid compilation warning.
2092
fcb901a7
LMI
2093 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2094
2095 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2096 since this reportedly can destroy thread storage.
2097
6e20a0d4
CY
20982011-08-30 Chong Yidong <cyd@stupidchicken.com>
2099
2100 * syntax.c (find_defun_start): Update all cache variables if
2101 exiting early (Bug#9401).
2102
148ae00e
EZ
21032011-08-30 Eli Zaretskii <eliz@gnu.org>
2104
f6cfbd8f
EZ
2105 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2106
148ae00e
EZ
2107 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2108 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2109 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2110
2111 * term.c (tty_append_glyph): New function.
2112 (produce_stretch_glyph): Static function and its prototype deleted.
2113
a66cfb1c
SM
2114 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2115 Add prototypes.
148ae00e 2116
c4a07a4c
PE
21172011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2120 when checking :margin (Bug#9390).
2121 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2122 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2123 so that the name doesn't mislead. All uses changed.
2124
6bc8cd65
JB
21252011-08-28 Johan Bockgård <bojohan@gnu.org>
2126
2127 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2128 set_tty_hooks.
2129
dca4927e
EZ
21302011-08-27 Eli Zaretskii <eliz@gnu.org>
2131
2132 * xdisp.c (move_it_to): Don't bail out early when reaching
2133 position beyond to_charpos, if we are scanning backwards.
2134 (move_it_vertically_backward): When DY == 0, make sure we get to
2135 the first character in the line after the newline.
2136
f2cad773
PE
21372011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2138
2139 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2140 (ccl_driver): Do not generate an out-of-range pointer.
2141 (Fccl_execute_on_string): Remove unnecessary check for
2142 integer overflow, noted by Stefan Monnier in
2143 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2144 Remove a FIXME that didn't need fixing.
2145 Simplify the newly-introduced buffer reallocation code.
2146
0cae2cdb
JB
21472011-08-27 Juanma Barranquero <lekktu@gmail.com>
2148
2149 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2150
5fc295a4 21512011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2152
70c60eb2 2153 Integer and memory overflow issues (Bug#9196).
726e0ab1 2154
d31850da
PE
2155 * doc.c (get_doc_string): Rework so that
2156 get_doc_string_buffer_size is the actual buffer size, rather than
2157 being 1 less than the actual buffer size; this makes xpalloc more
2158 convenient.
2159
a69fbedb
PE
2160 * image.c (x_allocate_bitmap_record, cache_image):
2161 * xselect.c (Fx_register_dnd_atom):
2162 Simplify previous changes by using xpalloc.
2163
fe5c5d37
PE
2164 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2165 since either will do and ptrdiff_t is convenient with xpalloc.
2166
0065d054
PE
2167 * charset.c (charset_table_size)
2168 (struct charset_sort_data.priority): Now ptrdiff_t.
2169 (charset_compare): Don't overflow if priorities differ greatly.
2170 (Fsort_charsets): Don't assume list length fits in int.
2171 Check for size-calculation overflow when allocating sort data.
2172 (syms_of_charset): Allocate an initial charset table that is
2173 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2174
2175 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2176
2177 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2178 The actual value is always <= INT_MAX, and leaving it unsigned made
2179 overflow checking harder.
2180
2181 * dispextern.h (struct glyph_matrix.rows_allocated)
2182 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2183 with xpalloc. The values are still always <= INT_MAX.
2184
2185 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2186
2187 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2188 (SAFE_NALLOCA): New macro.
2189
2190 * region-cache.c (struct boundary.pos, find_cache_boundary)
2191 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2192 (set_cache_region, invalidate_region_cache)
2193 (revalidate_region_cache, know_region_cache, region_cache_forward)
2194 (region_cache_backward, pp_cache):
2195 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2196 so that ptrdiff_t * can be passed to xpalloc.
2197 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2198 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2199 (pp_cache): Don't assume cache_len fits in int.
2200 * region-cache.h: Adjust extern decls to match.
2201
2202 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2203 EMACS_INT, since either will do, for xpalloc.
2204
2205 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2206 (xnmalloc, xnrealloc, xpalloc): New functions.
2207
726e0ab1
PE
2208 * bidi.c (bidi_shelve_header_size): New constant.
2209 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2210 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2211
51f30bc5 2212 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2213 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2214 (overlay_strings):
2215 Don't update size of array until after memory allocation succeeds,
2216 because xmalloc/xrealloc may not return.
0065d054
PE
2217 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2218 now that we have proper integer overflow checking.
2219 (record_overlay_string, overlay_strings): Catch overflows when
2220 calculating size of overlay_str_buf.
726e0ab1 2221
0065d054
PE
2222 * callproc.c (Fcall_process): Check for size overflow when
2223 calculating size of args2.
2224 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2225 Normally we prefer signed values, but sticking with ptrdiff_t would
2226 require adding more-complicated checks.
726e0ab1
PE
2227
2228 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2229 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2230 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2231 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2232
2233 * character.c (Fstring): Check for size-calculation overflow.
2234
2235 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2236 unnecessary integer overflow. Check for size overflow.
2237 (encode_coding_object): Don't update size until xmalloc succeeds.
2238
2239 * composite.c (get_composition_id): Check for overflow in glyph
2240 length calculations.
2241
2242 Integer and memory overflow fixes for display code.
2243 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2244 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2245 (scrolling_window): Check for overflow in size calculations.
2246 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2247 Don't assume glyph table len fits in int.
2248 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2249 (row_table_size): Now ptrdiff_t, not int.
2250 (scrolling_window): Avoid overflow in size calculations.
2251 Don't update size until allocation succeeds.
2252 * fns.c (concat): Check for overflow in size calculations.
2253 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2254 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2255 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2256
2257 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2258 (get_doc_string): Check for size calculation overflow.
2259 Don't update size until allocation succeeds.
2260 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2261 EMACS_INT, where ptrdiff_t will do.
2262 (Fsubstitute_command_keys): Check for string overflow.
2263
2264 * editfns.c (set_time_zone_rule): Don't assume environment length
2265 fits in int.
2266 (message_length): Now ptrdiff_t, not int.
2267 (Fmessage_box): Don't update size until allocation succeeds.
2268 Don't assume message length fits in int.
2269 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2270
0065d054
PE
2271 * emacs.c (main): Do not reallocate argv, since there is a null at
2272 the end that can be overwritten, and this way there's no need to
2273 worry about size-calculation overflow.
2274 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2275
2276 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2277 alloc succeeds.
2278 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2279
2280 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2281 (x_set_scroll_bar_width, x_figure_window_size):
2282 Check for integer overflow.
2283 (x_set_alpha): Do not assume XINT fits in int.
2284
2285 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2286 This is for the members text_lines, text_cols, total_lines, total_cols,
2287 where the system imposes an 'int' limit.
2288
2289 * fringe.c (Fdefine_fringe_bitmap):
2290 Don't update size until alloc works.
2291
2292 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2293 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2294
2295 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2296 Check for size-calculation overflow.
2297 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2298 do, as we prefer signed integers.
2299 (id_to_widget.max_size, id_to_widget.used)
2300 (xg_store_widget_in_map, xg_remove_widget_from_map)
2301 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2302 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2303 Use and return ptrdiff_t, not int.
2304 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2305 * gtkutil.h: Change prototypes to match the above.
2306
2307 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2308 are duplicate now that they've been promoted to lisp.h.
2309 (x_allocate_bitmap_record, x_alloc_image_color)
2310 (make_image_cache, cache_image, xpm_load):
2311 Don't update size until alloc is done.
2312 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2313 (x_detect_edges):
3256efce 2314 Check for size calculation overflow.
726e0ab1
PE
2315 (ct_colors_allocated_max): New constant.
2316 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2317 overflow.
3256efce 2318
726e0ab1
PE
2319 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2320 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2321 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2322 Use ptrdiff_t, not int, to count maps.
2323 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2324 calculations. Don't update size until allocation succeeds.
2325 Redo calculations to avoid overflow.
726e0ab1
PE
2326 * keyboard.h: Change prototypes to match the above.
2327
2328 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2329 to count maps.
2330 (current_minor_maps): Check for size calculation overflow.
2331 * keymap.h: Change prototypes to match the above.
2332
2333 * lread.c (read1, init_obarray): Don't update size until alloc done.
2334
2335 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2336 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2337
726e0ab1
PE
2338 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2339 Now ptrdiff_t, not int.
2340 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2341 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2342
2343 * process.c (Fnetwork_interface_list): Check for overflow
2344 in size calculation.
2345
2346 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2347
2348 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2349 overflow. Don't bother calling xmalloc when xrealloc will do.
2350
2351 * search.c (Freplace_match): Check for size calculation overflow.
2352 (Fset_match_data): Don't assume list lengths fit in 'int'.
2353
2354 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2355 for command line length. Do not attempt to address one before the
2356 beginning of an array, as that's not portable.
2357
2358 * term.c (max_frame_lines): Remove; unused.
2359 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2360 not int.
2361 (encode_terminal_code, calculate_costs): Check for size
2362 calculation overflow.
2363 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2364 table lengths and related sizes. Don't update size until alloc
2365 done. Redo calculations to avoid overflow.
2366 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2367
2368 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2369 subtracting pointers.
2370 (gobble_line): Check for overflow more carefully. Don't update size
2371 until alloc done.
2372
2373 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2374 Don't update size until alloc done.
2375 Redo size calculations to avoid overflow.
2376 Check for size calculation overflow.
0065d054 2377 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2378
2379 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2380 Use ptrdiff_t, not int, for sizes.
2381 (store_mode_line_noprop_char): Don't update size until alloc done.
2382
0065d054
PE
2383 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2384 Use ptrdiff_t, not int, for sizes.
2385 (Finternal_make_lisp_face, cache_face):
2386 Check for size calculation overflow.
2387 (cache_face): Treat size calculation overflows as if they were
2388 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2389
2390 * xfns.c (x_encode_text, x_set_name_internal)
2391 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2392 sizes, since they can exceed INT_MAX in size. Check for size
2393 calculation overflow.
2394
0065d054
PE
2395 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2396 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2397 Don't update size until alloc done.
2398
0065d054 2399 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2400 as sprintf is limited to int lengths.
1d526e2f 2401
252c5ee1
PE
2402 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2403 (X_LONG_MIN): New macros.
864d7ce7
PE
2404 Use them to make the following changes clearer.
2405 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2406 This change doesn't affect the value now, but it may help remind
2407 future maintainers not to raise the value too much later.
2408 (SELECTION_QUANTUM): Remove, replacing with ...
2409 (selection_quantum): ... new function, which avoids overflow.
2410 All uses changed.
2411 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2412 assumption that selection length fits in 'int'.
2413 (x_reply_selection_request, x_handle_selection_request)
2414 (x_get_window_property, receive_incremental_selection)
2415 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2416 (lisp_data_to_selection_data, clean_local_selection_data):
2417 Use ptrdiff_t, not int, to record length of selection.
2418 (x_reply_selection_request, x_get_window_property)
2419 (receive_incremental_selection, x_property_data_to_lisp):
2420 Redo calculations to avoid overflow.
2421 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2422 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2423 something.
2424 (x_get_window_property, receive_incremental_selection)
2425 (lisp_data_to_selection_data, x_property_data_to_lisp):
2426 Check for size-calculation overflow.
2427 (x_get_window_property, receive_incremental_selection)
2428 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2429 Don't store size until memory allocation succeeds.
2430 (x_get_window_property): Plug memory leak on memory exhaustion.
2431 Don't double-block input; malloc is safe here. Don't assume 2**34
2432 - 4 fits in unsigned long. Add an xassert to check
2433 XGetWindowProperty overflow. Be more careful about overflow
2434 calculations, and distinguish size from memory overflow better.
2435 (receive_incremental_selection): When tracing, don't assume
2436 unsigned int is less than INT_MAX.
2437 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2438 harmful) conversions of unsigned short to int.
2439 (lisp_data_to_selection_data): Don't assume that integers
2440 in the range -65535 through -1 fit in an X unsigned short.
2441 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2442 result parameters unless successful. Rely on cons_to_unsigned
2443 to report problems with elements; the old code wasn't right anyway.
2444 (x_check_property_data): Check for int overflow; we cannot use
2445 a wider type due to X limits.
2446 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2447
726e0ab1 2448 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2449
0065d054
PE
2450 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2451 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2452 (x_color_cells): Don't store size until memory allocation succeeds.
2453 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2454 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2455 (x_term_init): Don't assume length fits in int (sprintf is limited
2456 to int size).
bc18e09d 2457
ebfa62c0
PE
2458 Use ptrdiff_t for composition IDs.
2459 * character.c (lisp_string_width):
2460 * composite.c (composition_table_size, n_compositions)
2461 (get_composition_id, composition_gstring_from_id):
2462 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2463 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2464 * window.c (Frecenter):
2465 Use ptrdiff_t, not int, for composition IDs.
2466 * composite.c (get_composition_id): Check for integer overflow.
2467 * composite.h: Adjust prototypes to match the above changes.
2468
d3411f89
PE
2469 Use ptrdiff_t for hash table indexes.
2470 * category.c (hash_get_category_set):
2471 * ccl.c (ccl_driver):
2472 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2473 * coding.c (coding_system_charset_list, detect_coding_system):
2474 * coding.h (struct coding_system.id):
2475 * composite.c (get_composition_id, gstring_lookup_cache):
2476 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2477 * image.c (xpm_get_color_table_h):
2478 * lisp.h (hash_lookup, hash_put):
2479 * minibuf.c (Ftest_completion):
2480 Use ptrdiff_t for hash table indexes, not int (which is too
2481 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2482 32-bit --with-wide-int hosts).
2483
e097a6fa
PE
2484 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2485 Add a FIXME comment about memory leaks.
2486 (syms_of_charset): Don't assume xmalloc returns.
2487
5637687f
PE
2488 Don't assume that stated character widths fit in int.
2489 * character.c (Fchar_width, c_string_width, lisp_string_width):
2490 * character.h (CHAR_WIDTH):
2491 * indent.c (MULTIBYTE_BYTES_WIDTH):
2492 Use sanitize_char_width to avoid undefined and/or bad behavior
2493 with outlandish widths.
a66cfb1c 2494 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2495 now that we have two such functions. All uses changed.
2496 (sanitize_char_width): New inline function.
2497
a2271ba2
PE
2498 Don't assume that tab-width fits in int.
2499 * character.h (sanitize_width): New inline function.
2500 (SANE_TAB_WIDTH): New macro.
2501 (ASCII_CHAR_WIDTH): Use it.
2502 * indent.c (sane_tab_width): Remove. All uses replaced by
2503 SANE_TAB_WIDTH (current_buffer).
2504 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2505
18c52557
PE
2506 * fileio.c: Integer overflow issues with file modes.
2507 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2508
caeeedc1
PE
2509 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2510 Remove unreachable code.
2511 (read_hex, load_charset_map_from_file): Check for integer overflow.
2512
6df6ae42 2513 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2514 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2515 (x_send_scroll_bar_event): Likewise. Check that the size does not
2516 exceed limits imposed by XClientMessageEvent, as well as the usual
2517 ptrdiff_t and size_t limits.
2518
b13995db
PE
2519 * keyboard.c: Overflow, signedness and related fixes.
2520 (make_lispy_movement): Use same integer type in forward decl
2521 that is used in the definition.
2522 (read_key_sequence, keyremap_step):
2523 Change bufsize argument back to int, undoing my 2011-03-30 change.
2524 We prefer signed types, and int is wide enough here.
2525 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2526 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2527 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2528 length, not size_t. Use ptrdiff_t for index, not int.
2529 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2530 possibility of integer overflow.
2531
13464394
PE
2532 Overflow, signedness and related fixes for images.
2533
2534 * dispextern.h (struct it.stack[0].u.image.image_id)
2535 (struct_it.image_id, struct image.id, struct image_cache.size)
2536 (struct image_cache.used, struct image_cache.ref_count):
2537 * gtkutil.c (update_frame_tool_bar):
2538 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2539 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2540 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2541 * nsmenu.m (update_frame_tool_bar):
2542 * xdisp.c (calc_pixel_width_or_height):
2543 * xfns.c (image_cache_refcount):
2544 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2545 on typical 64-bit hosts.
2546
2547 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2548 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2549 Omit unnecessary casts to int.
2550 (parse_image_spec): Check that integers fall into 'int' range
2551 when the callers expect that.
2552 (image_ascent): Redo ascent calculation to avoid int overflow.
2553 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2554 (lookup_image): Remove unnecessary tests.
2555 (xbm_image_p): Locals are now of int, not EMACS_INT,
2556 since parse_image_check makes sure they fit into int.
2557 (png_load, gif_load, svg_load_image):
2558 Prefer int to unsigned where either will do.
2559 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2560 old tiff_error_handler and tiff_warning_handler.
2561 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2562 stack buffer overflows. It uses only the features of vsnprintf
2563 that are common to both POSIX and native Microsoft.
2564 (tiff_error_handler, tiff_warning_handler): Use it.
2565 (tiff_load, gif_load, imagemagick_load_image):
2566 Don't assume :index value fits in 'int'.
2567 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2568 (imagemagick_load_image): Check that crop parameters fit into
2569 the integer types that MagickCropImage accepts. Don't assume
2570 Vimagemagick_render_type has a nonnegative value. Don't assume
2571 size_t fits in 'long'.
2572 (gs_load): Use printmax_t to print the widest integers possible.
2573 Check for integer overflow when computing image height and width.
2574
c11821d4
EZ
25752011-08-26 Eli Zaretskii <eliz@gnu.org>
2576
2577 * xdisp.c (redisplay_window): Don't force window start if point
2578 will be invisible in the resulting window. (Bug#9324)
2579
0c95fcf7
EZ
25802011-08-25 Eli Zaretskii <eliz@gnu.org>
2581
2582 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2583 the display spec is of the form `(space ...)'.
2584 (handle_display_spec): Return the value returned by
2585 handle_single_display_spec, not just 1 or zero.
2586 (handle_single_display_spec): If the display spec is of the form
2587 `(space ...)', and specifies display in the text area, return 2
2588 rather than 1.
fee65a97 2589 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2590 accurately, and prefer exact match for point under bidi.
2591 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2592
2593 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2594 into disp_prop; all users changed.
2595
2596 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2597 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2598 for the text covered by the display property.
2599
e4ed06f1
CY
26002011-08-25 Chong Yidong <cyd@stupidchicken.com>
2601
2602 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2603 Change return value to nil.
2604 (Frecord_buffer): Delete unused function.
2605
f67cdd7f
EZ
26062011-08-24 Eli Zaretskii <eliz@gnu.org>
2607
5980d4c6
EZ
2608 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2609 buffers, return left-to-right.
8610fe8b
EZ
2610 (set_cursor_from_row): Consider candidate row a win if its glyph
2611 represents a newline and point is on that newline. Fixes cursor
2612 positioning on the newline at EOL of R2L text within L2R
2613 paragraph, and vice versa.
2614 (try_cursor_movement): Check continued rows, in addition to
2615 continuation rows. Fixes unwarranted scroll when point enters a
2616 continued line of R2L text within an L2R paragraph, or vice versa.
2617 (cursor_row_p): Consider the case of point being equal to
2618 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2619 from the end of a short line to the beginning of a continued line
2620 of R2L text within L2R paragraph.
2621 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2622 composed characters.
5980d4c6 2623
f67cdd7f
EZ
2624 * bidi.c (bidi_check_type): Use xassert.
2625 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2626 members.
2627
bca633fb
EZ
26282011-08-23 Eli Zaretskii <eliz@gnu.org>
2629
2630 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2631 a character.
2632
4a5885a7
CY
26332011-08-23 Chong Yidong <cyd@stupidchicken.com>
2634
2635 * nsfont.m (ns_otf_to_script): Fix typo.
2636
0902a04e
KH
26372011-08-22 Kenichi Handa <handa@m17n.org>
2638
2639 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2640 extra slot even if the purpose is char-code-property-table.
2641
1a2e6670
EZ
26422011-08-23 Eli Zaretskii <eliz@gnu.org>
2643
8ddde651
EZ
2644 * xdisp.c (redisplay_window): When computing centering_position,
2645 account for the height of the header line. (Bug#8874)
2646
425cc014
EZ
2647 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2648 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2649 candidate is selected by the mouse, and that candidate has a
2650 composed character under the mouse.
2651
1a2e6670
EZ
2652 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2653 coordinates reported by pos-visible-in-window-p for a composed
2654 character in column zero.
2655
8b76d6f8
SM
26562011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2657
2658 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2659
dac347dd
EZ
26602011-08-22 Eli Zaretskii <eliz@gnu.org>
2661
2662 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2663 consider it a hit if to_charpos is anywhere in the range of the
2664 composed buffer positions.
2665
e013fb34
CY
26662011-08-22 Chong Yidong <cyd@stupidchicken.com>
2667
2668 * image.c (gif_load): Don't assume that each subimage has the same
2669 dimensions as the base image. Handle disposal method that is
2670 "undefined" by the gif spec (Bug#9335).
2671
bd1ba3e8
CY
26722011-08-20 Chong Yidong <cyd@stupidchicken.com>
2673
2674 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2675 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2676
54a1215b
EZ
26772011-08-19 Eli Zaretskii <eliz@gnu.org>
2678
823564e5
EZ
2679 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2680 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2681 from an Org mode buffer to a Speedbar frame.
2682
54a1215b
EZ
2683 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2684 a composition, take its buffer position from IT->cmp_it.charpos.
2685 Fixes cursor positioning at the beginning of a line that begins
2686 with a composed character.
2687
9778ebcc
EZ
26882011-08-18 Eli Zaretskii <eliz@gnu.org>
2689
0be6ee06
EZ
2690 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2691 character bidirectional type, use STRONG_L instead. Fixes crashes
2692 in a buffer produced by `describe-categories'.
2693
9778ebcc
EZ
2694 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2695 members before the level stack, so they would be saved and
2696 restored when copying iterator state. Fixes incorrect reordering
2697 around TABs covered by display properties.
2698
156bffbe
AS
26992011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2700
6b02f655 2701 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2702
72ad093b
CY
27032011-08-17 Chong Yidong <cyd@stupidchicken.com>
2704
2705 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2706 (internal_condition_case_2, internal_condition_case_n):
2707 Remove unnecessary aborts (Bug#9081).
72ad093b 2708
35774242
EZ
27092011-08-17 Eli Zaretskii <eliz@gnu.org>
2710
2711 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2712 has no `load' handler, try opening the file locally. (Bug#9311)
2713
db76dd85
KB
27142011-08-16 Ken Brown <kbrown@cornell.edu>
2715
2716 * gmalloc.c: Expand comment.
2717
b215eee5
EZ
27182011-08-16 Eli Zaretskii <eliz@gnu.org>
2719
2720 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2721 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2722
a4579d33
KB
27232011-08-16 Ken Brown <kbrown@cornell.edu>
2724
2725 Fix memory allocation problems in Cygwin build (Bug#9273).
2726
2727 * unexcw.c ( __malloc_initialized): Declare external variable.
2728 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2729
8b76d6f8
SM
2730 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2731 New variables.
a4579d33
KB
2732 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2733 dumped emacs.
2734 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2735 in the static heap.
2736 [CYGWIN] (special_realloc): New function.
2737 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2738 requests to realloc storage in the static heap.
2739
3ebec551
PE
27402011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2741
2742 * bidi.c (bidi_initialize): Remove unused local.
2743
9fd8be00
EZ
27442011-08-15 Eli Zaretskii <eliz@gnu.org>
2745
6b02f655
SM
2746 * bidimirror.h:
2747 * biditype.h: Remove file.
2748 * makefile.w32-in ($(BLD)/bidi.$(O)):
2749 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2750
2751 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2752
2753 * chartab.c: Improve commentary for the uniprop_table API.
2754
32413314
EZ
2755 * bidi.c (bidi_paragraph_init): Support zero value of
2756 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2757 (bidi_initialize): Use uniprop_table instead of including
2758 biditype.h and bidimirror.h.
32413314 2759
9fd8be00
EZ
2760 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2761 coordinates of the iterator when restoring from ppos_it.
2762 (Bug#9296)
2763
5cf2b69b
KH
27642011-08-14 Kenichi Handa <handa@m17n.org>
2765
2766 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2767 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2768
daf17d00
EZ
27692011-08-14 Eli Zaretskii <eliz@gnu.org>
2770
2771 * xdisp.c (move_it_in_display_line_to): Don't invoke
2772 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2773 ppos_it. Fixes vertical cursor motion when line beginning is
2774 covered by an image. (Bug#9296)
2775
08e3161a
JD
27762011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2777
2778 * nsterm.h (ns_run_ascript): Declare.
2779 (NSAPP_DATA2_RUNASSCRIPT): Define.
2780
2781 * nsfns.m (as_script, as_result, as_status): New static variables.
2782 (ns_run_ascript): New function.
5e617bc2 2783 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2784 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2785 the event loop. Get status from as_status (Bug#7276).
2786
2787 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2788 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2789 the event loop (Bug#7276).
2790
a3720aa2
AS
27912011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2792
2793 * gnutls.c (QCgnutls_bootprop_priority)
2794 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2795 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2796 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2797 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2798 (QCgnutls_bootprop_verify_hostname_error)
2799 (QCgnutls_bootprop_callbacks_verify): Rename from
2800 Qgnutls_bootprop_..., all uses changed.
2801
2802 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2803 uses changed.
2804
0a0d27fb
PE
28052011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2806
19d5c50c
PE
2807 * xfaces.c (Qframe_set_background_mode): Now static.
2808 * dispextern.h (Qframe_set_background_mode): Remove decl.
2809
0a0d27fb
PE
2810 * process.c (Fnetwork_interface_info): Declare local only if needed.
2811
377538cb
JD
28122011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2813
2814 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2815 (Fnetwork_interface_list): Allocate in increments of bytes instead
2816 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2817 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2818 sockaddr.
2819 (struct ifflag_def): notrailers is smart on OSX.
2820 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2821 Get hardware address with getifaddrs if available.
2822
08fff70c
EZ
28232011-08-12 Eli Zaretskii <eliz@gnu.org>
2824
2825 * xdisp.c (iterate_out_of_display_property): xassert that
2826 IT->position is set to within IT->object's boundaries. Break from
2827 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2828 when IT->position is set up wrongly due to some bug.
2829 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2830 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2831 entry. Force push_it to save on the stack the current
2832 buffer/string position, to be restored by pop_it. Fix flags in
2833 the iterator structure wrt the object coming from a display
2834 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2835 properties. (Bug#9284)
2836
7be1c708 28372011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2838
7be1c708
CY
2839 * fontset.c (fontset_get_font_group): Add proper type checks.
2840 (Bug#9172)
aac0c6e3 2841
7be1c708 28422011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2843
7be1c708
CY
2844 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2845 and LC_VERSION_MIN_MACOSX.
2846 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2847 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2848
97bb72a6
EZ
28492011-08-08 Eli Zaretskii <eliz@gnu.org>
2850
2851 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2852 no-display-properties-and-no-overlays under bidi display.
2853 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2854 properties and overlays.
97bb72a6 2855
d5617611
CY
28562011-08-08 Chong Yidong <cyd@stupidchicken.com>
2857
37e11a63
CY
2858 * editfns.c (Fset_time_zone_rule): Document relationship with the
2859 setenv function.
2860
d5617611
CY
2861 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2862 the font entity extracted from the cache (Bug#8109).
2863
58872834
CY
28642011-08-07 Chong Yidong <cyd@stupidchicken.com>
2865
2866 * composite.c (autocmp_chars): Don't reset point. That is done by
2867 restore_point_unwind (Bug#5984).
2868
75bfc667
JL
28692011-08-07 Juri Linkov <juri@jurta.org>
2870
2871 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2872 to show the arg `TIME' instead of `TIMEVAL'.
2873
d1410150
EZ
28742011-08-06 Eli Zaretskii <eliz@gnu.org>
2875
2876 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2877 display property strides EOL and includes a newline, as in
2878 longlines-mode. (Bug#9254)
75b771e4
EZ
2879 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2880 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2881
2882 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2883 is non-zero, even if the data buffer is NULL. Fixes a crash in
2884 vertical-motion with longlines-mode. (Bug#9254)
2885
35928349
EZ
28862011-08-05 Eli Zaretskii <eliz@gnu.org>
2887
ec7cc85b
EZ
2888 * bidi.c <bidi_cache_total_alloc>: Now static.
2889 (bidi_initialize): Initialize bidi_cache_total_alloc.
2890
8b76d6f8 2891 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2892 cache. (Bug#9221)
2893
2894 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2895 amount allocated this far in `bidi_cache_total_alloc'.
2896 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2897 non-zero, only free the data buffer without restoring the cache
2898 contents. All callers changed.
2899
2900 * dispextern.h (bidi_unshelve_cache): Update prototype.
2901
2902 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2903 (move_it_in_display_line, move_it_to)
2904 (move_it_vertically_backward, move_it_by_lines): Replace the call
2905 to xfree to an equivalent call to bidi_unshelve_cache.
2906 (move_it_in_display_line_to): Fix logic of returning
412b6358 2907 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2908
e2e2423b
EZ
29092011-08-05 Eli Zaretskii <eliz@gnu.org>
2910
2911 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2912 came from a string character with a `cursor' property. (Bug#9229)
2913
ae9e757a
JD
29142011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2915
2916 * Makefile.in (LIB_PTHREAD): New variable.
2917 (LIBES): Add LIB_PTHREAD (Bug#9216).
2918
2919 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2920 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2921
213bd7f2
AS
29222011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2923
6b02f655 2924 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2925
99aaf75f
JD
29262011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2927
2928 * xterm.c (x_find_topmost_parent): New function.
2929 (x_set_frame_alpha): Find topmost parent window with
2930 x_find_topmost_parent and set the property there also (bug#9181).
2931 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2932
c74e9d86
PE
29332011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2934
2935 * callproc.c (Fcall_process): Avoid vfork clobbering
2936 the local vars buffer, coding_systems, current_dir.
2937
640c8776
SM
29382011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2939
2940 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2941
f26d0e4c
PE
29422011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2943
8a10d76c
PE
2944 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2945 so that it is not optimized away.
2946
f26d0e4c
PE
2947 * xdisp.c (compute_display_string_pos): Remove unused local.
2948
55439c61
EZ
29492011-08-02 Eli Zaretskii <eliz@gnu.org>
2950
2951 Fix slow cursor motion and scrolling in large buffers with
2952 selective display, like Org Mode buffers. (Bug#9218)
2953
2954 * dispextern.h (struct bidi_it): New member disp_prop_p.
2955
2956 * xdisp.c: Remove one-slot cache of display string positions.
2957 (compute_display_string_pos): Accept an additional argument
5e617bc2 2958 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2959 for a display string or property. If found, set DISP_PROP_P
2960 non-zero.
2961
2962 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2963 DISP_PROP_P, and pass it to compute_display_string_pos.
2964 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2965 non-zero. All callers of bidi_fetch_char changed.
2966
fb33fa43
SM
29672011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2968
2969 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2970
b099e063
DM
29712010-12-03 Don March <don@ohspite.net>
2972
2973 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2974 last character M-[char] is translated to ESC [char] (bug#7541).
2975
5cc7f7af
KH
29762011-08-02 Kenichi Handa <handa@m17n.org>
2977
d0fffa3f 2978 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2979
2980 * chartab.c (uniprop_table): Make it non-static.
2981
525d5e6e
EZ
29822011-08-01 Eli Zaretskii <eliz@gnu.org>
2983
2984 * xdisp.c (forward_to_next_line_start): Accept additional argument
2985 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2986 on the newline.
2987 (reseat_at_next_visible_line_start): Use the bidi iterator state
2988 returned by forward_to_next_line_start to restore the state of
2989 it->bidi_it after backing up to previous newline. (Bug#9212)
2990
31011111
AS
29912011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2992
2993 * regex.c (re_comp): Protoize.
2994 (re_exec): Fix return type.
2995 (regexec): Fix type of `ret'. (Bug#9203)
2996
476371c4
PE
29972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2998
e5d76069
PE
2999 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3000 This is needed if max-image-size is a floating-point number.
3001
9a79b20c
AS
30022011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3003
3004 * print.c (print_object): Print empty symbol as ##.
3005
3006 * lread.c (read1): Read ## as empty symbol.
3007
d8c2fa78
AA
30082011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3009
3010 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3011 setting frame foreground color (Bug#9175).
3012 (x_set_background_color): Likewise.
3013
ffe57a7a
AA
3014 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3015 contents (Bug#9176).
3016 (EmacsTooltip -init): Remove bezels and add shadows to
3017 tooltip windows.
3018
bf3492a5
AA
3019 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3020 or scroll bar (Bug#8470).
3021
d55e9c53
AA
3022 * nsfont.m (nsfont_open): Remove assignment to voffset and
3023 unnecessary vars hshink, expand, hd, full_height, min_height.
3024 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3025
3026 * nsterm.h (nsfont_info): Remove voffset field.
3027
d8c2fa78 30282011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3029
3030 Implement strike-through and overline on NextStep (Bug#8863).
3031
3032 * nsfont.m (nsfont_open): Use underline position provided by font,
3033 instead of hard-coded value of 2.
3034 (nsfont_draw): Call ns_draw_text_decoration instead.
3035
3036 * nsterm.h: Add declaration for ns_draw_text_decoration.
3037
3038 * nsterm.m (ns_draw_text_decoration): New function for drawing
3039 underline, overline, and strike-through.
3040 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3041 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3042 accommodate underlining, etc.
4843aac3 3043
4cc60b9b
EZ
30442011-07-28 Eli Zaretskii <eliz@gnu.org>
3045
bc7ece87
EZ
3046 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3047 default.
4cc60b9b 3048
476371c4
PE
30492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3050
66606eea
PE
3051 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3052 Without this fix, if a signal arrives just after memory fills up,
3053 'malloc' might be invoked reentrantly.
3054
476371c4
PE
3055 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3056 In other words, assume that every image size is allowed, on non-X
3057 hosts. This assumption is probably wrong, but it lets Emacs compile.
3058
f3fcc40d
AS
30592011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3060
3061 * regex.c (re_iswctype): Convert return values to boolean.
3062
350c992f
EZ
30632011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3064
3065 * xdisp.c (compute_display_string_pos): Don't use cached display
3066 string position if the buffer had its restriction changed.
3067 (Bug#9184)
3068
5266b4bb
PE
30692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3070
3071 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3072
2573a837 30732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3074
41f55ccd 3075 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3076
39e378da
PE
3077 * bidi.c: Integer size and overflow fixes.
3078 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3079 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3080 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3081 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3082 (bidi_find_other_level_edge):
3083 Use ptrdiff_t instead of EMACS_INT where either will do.
3084 This works better on 32-bit hosts configured --with-wide-int.
3085 (bidi_cache_ensure_space): Check for size-calculation overflow.
3086 Use % rather than repeated addition, for better worst-case speed.
3087 Don't set bidi_cache_size until after xrealloc returns, because it
3088 might not return.
3089 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3090 (bidi_cache_ensure_space): Also check that the bidi cache size
3091 does not exceed that of the largest Lisp string or buffer. See Eli
3092 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3093
5e927815
PE
3094 * alloc.c (__malloc_size_t): Remove.
3095 All uses replaced by size_t. See Andreas Schwab's note
3096 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3097
ca4aa935
PE
3098 * image.c: Improve checking for integer overflow.
3099 (check_image_size): Assume that f is nonnull, since
3100 it is always nonnull in practice. This is one less thing to
3101 worry about when checking for integer overflow later.
3102 (x_check_image_size): New function, which checks for integer
3103 overflow issues inside X.
3104 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3105 This removes the need for a memory_full check.
3106 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3107 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3108 (xbm_read_bitmap_data): Change locals back to 'int', since
3109 their values must fit in 'int'.
3110 (xpm_load_image, png_load, tiff_load):
3111 Invoke x_create_x_image_and_pixmap earlier,
3112 to avoid much needless work if the image is too large.
3113 (tiff_load): Treat overly large images as if
3114 x_create_x_image_and_pixmap failed, not as malloc failures.
3115 (gs_load): Use x_check_image_size.
3116
5f8f9cc2
PE
3117 * gtkutil.c: Omit integer casts.
3118 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3119 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3120
5adf60bc
PE
3121 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3122
c8907a93
PE
3123 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3124 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3125 would wrongly return t on a 64-bit host.
3126
e3c25c68
PE
3127 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3128 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3129 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3130 and therefore cause GCC to emit a bogus diagnostic in some cases.
3131
3f791afe
PE
3132 * image.c: Integer signedness and overflow and related fixes.
3133 This is not an exhaustive set of fixes, but it's time to
3134 record what I've got.
3135 (lookup_pixel_color, check_image_size): Remove redundant decls.
3136 (check_image_size): Don't assume that arbitrary EMACS_INT values
3137 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3138 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3139 (tiff_load, imagemagick_load_image):
3140 Check for overflow in size calculations.
3141 (x_create_x_image_and_pixmap): Remove unnecessary test for
3142 xmalloc returning NULL; that can't happen.
3143 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3144 (xpm_color_bucket): Use better integer hashing function.
3145 (xpm_cache_color): Don't possibly over-allocate memory.
3146 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3147 (gif_memory_source):
3148 Use ptrdiff_t, not int or size_t, to record sizes.
3149 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3150 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3151 either works, as we prefer signed integers.
3152 (tiff_read_from_memory, tiff_write_from_memory):
3153 Return tsize_t, not size_t, since that's what the TIFF API wants.
3154 (tiff_read_from_memory): Don't fail simply because the read would
3155 go past EOF; instead, return a short read.
3156 (tiff_load): Omit no-longer-needed casts.
3157 (Fimagemagick_types): Don't assume size fits into 'int'.
3158
3cc5a532
PE
3159 Improve hashing quality when configured --with-wide-int.
3160 * fns.c (hash_string): New function, taken from sxhash_string.
3161 Do not discard information about ASCII character case; this
3162 discarding is no longer needed.
3163 (sxhash-string): Use it. Change sig to match it. Caller changed.
3164 * lisp.h: Declare it.
3165 * lread.c (hash_string): Remove, since we now use fns.c's version.
3166 The fns.c version returns a wider integer if --with-wide-int is
3167 specified, so this should help the quality of the hashing a bit.
3168
b312a492
PE
3169 * emacs.c: Integer overflow minor fix.
3170 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3171 Define only if GNU_LINUX.
3172 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3173
dfd153ae
PE
3174 * dispnew.c: Integer signedness and overflow fixes.
3175 Remove unnecessary forward decls, that were a maintenance hassle.
3176 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3177 All uses changed.
3178 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3179 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3180 (prepare_desired_row, line_draw_cost):
3181 Use int, not unsigned, where either works.
3182 (save_current_matrix, restore_current_matrix):
3183 Use ptrdiff_t, not size_t, where either works.
3184 (init_display): Check for overflow more accurately, and without
3185 relying on undefined behavior.
3186
a81d11a3
PE
3187 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3188 Remove, replacing with the new symbols in lisp.h. All uses changed.
3189 * fileio.c (make_temp_name):
3190 * filelock.c (lock_file_1, lock_file):
3191 * xdisp.c (message_dolog):
3192 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3193 Use pMd etc. instead.
3194 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3195 replacing the pWIDE etc. symbols removed from editfns.c.
3196
3300e6fd
PE
3197 * keyboard.h (num_input_events): Now uintmax_t.
3198 This is (very slightly) less likely to mess up due to wraparound.
3199 All uses changed.
3200
fd05c7e9
PE
3201 * buffer.c: Integer signedness fixes.
3202 (alloc_buffer_text, enlarge_buffer_text):
3203 Use ptrdiff_t rather than size_t when either will do, as we prefer
3204 signed integers.
3205
903fe15d
PE
3206 * alloc.c: Integer signedness and overflow fixes.
3207 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3208 (__malloc_size_t): Default to size_t, not to int.
3209 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3210 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3211 Prefer ptrdiff_t to size_t when either would do, as we prefer
3212 signed integers.
3213 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3214 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3215 Now const. Initialize with values that are in range even if char
3216 is signed.
3217 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3218 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3219 These functions do the right thing with sizes > 2**32.
3220 (check_depth): Now ptrdiff_t, not int.
3221 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3222 Adjust to new way of storing sizes. Check for size overflow bugs
3223 in rest of code.
3224 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3225 slightly wrong anyway, as it missed one instance of
3226 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3227 (refill_memory_reserve): Omit needless cast to size_t.
3228 (mark_object_loop_halt): Mark as externally visible.
3229
ac82cc6a
PE
3230 * xselect.c: Integer signedness and overflow fixes.
3231 (Fx_register_dnd_atom, x_handle_dnd_message):
3232 Use ptrdiff_t, not size_t, since we prefer signed.
3233 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3234 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3235 x_dnd_atoms_size and x_dnd_atoms_length.
3236
c2d1e36d
PE
3237 * doprnt.c: Prefer signed to unsigned when either works.
3238 * eval.c (verror):
3239 * doprnt.c (doprnt):
3240 * lisp.h (doprnt):
3241 * xdisp.c (vmessage):
3242 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3243 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3244 prefer signed arithmetic to avoid comparison confusion.
3245 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3246 but is a bit tricky.
3247
0e926e56
PE
3248 Assume freestanding C89 headers, string.h, stdlib.h.
3249 * data.c, doprnt.c, floatfns.c, print.c:
3250 Include float.h unconditionally.
3251 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3252 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3253 * regex.c: Likewise for stddef.h, string.h.
3254 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3255 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3256 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3257 (STDC_HEADERS): Remove obsolete defines.
3258 * sysdep.c: Include limits.h unconditionally.
3259
9cfdb3ec
PE
3260 Assume support for memcmp, memcpy, memmove, memset.
3261 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3262 * regex.c (memcmp, memcpy):
3263 Remove; we assume C89 now.
3264
3265 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3266 (__malloc_safe_bcopy): Remove; no longer needed.
3267
cf950e6b 3268 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3269 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3270 well either way, and we prefer signed to unsigned.
3271
dbf38e02
LMI
32722011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3273
3274 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3275 closes the connection while we're reading (bug#9182).
3276
d6f0886c 32772011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3278
d6f0886c
JD
3279 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3280 are specified (Bug#9168).
24e0f6b1 3281
2eb1f9e6
PE
32822011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3283
3284 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3285 Found by GCC static checking and --with-wide-int on a 32-bit host.
3286
22381272 32872011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3288
3289 * xdisp.c (compute_display_string_pos): Fix logic of caching
3290 previous display string position. Initialize cached_prev_pos to
3291 -1. Fixes slow-down at the beginning of a buffer.
3292
f25e39b4
EZ
32932011-07-24 Eli Zaretskii <eliz@gnu.org>
3294
3295 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3296 for attrs[LFACE_FONTSET_INDEX].
3297
04c4b52e
PE
32982011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3299
3300 * xml.c (parse_region): Remove unused local
3301 that was recently introduced.
3302
c1734fbd
EZ
33032011-07-23 Eli Zaretskii <eliz@gnu.org>
3304
be18c5a5
EZ
3305 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3306 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3307
c1734fbd
EZ
3308 * xdisp.c (move_it_in_display_line_to): Record the best matching
3309 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3310 exit if none of the characters scanned was an exact match.
3311 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3312 when exact match is impossible due to invisible text, and the
3313 lines are truncated.
3314
a258d627
JD
33152011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3316
3317 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3318 for OSX >= 10.7.
3319
b6d5a689
EZ
33202011-07-22 Eli Zaretskii <eliz@gnu.org>
3321
0f74f785
EZ
3322 Fix a significant slow-down of cursor motion with C-n, C-p,
3323 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3324 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3325 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3326 (next_element_from_buffer): Call compute_stop_pos_backwards to
3327 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3328 base_level_stop.
3329 (reseat): Don't look for prev_stop, as that could mean a very long
3330 run.
3331 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3332 <cached_disp_overlay_modiff>: Cache for last found display string
3333 position.
551918c1 3334 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3335 about the same buffer in the same area of character positions, and
3336 the buffer wasn't changed since the time the display string
3337 position was cached.
551918c1 3338
b2d0c91a
EZ
33392011-07-22 Eli Zaretskii <eliz@gnu.org>
3340
3341 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3342 is an integer, which is important for empty lines. (Bug#9149)
3343
043604ee
CY
33442011-07-22 Chong Yidong <cyd@stupidchicken.com>
3345
3346 * frame.c (Fmodify_frame_parameters): In tty case, update the
3347 default face if necessary (Bug#4238).
3348
da4adb04
CY
33492011-07-21 Chong Yidong <cyd@stupidchicken.com>
3350
3351 * editfns.c (Fstring_to_char): No need to explain what a character
3352 is in the docstring (Bug#6576).
3353
9abd0532
LMI
33542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3355
3356 * xml.c (parse_region): Make sure we always return a tree.
3357
36881d16
HK
33582011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3359
3360 * xml.c (parse_region): If a document contains only comments,
3361 return that, too.
3362
1e98674d
LMI
33632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3364
3365 * xml.c (make_dom): Return comments, too.
3366
590bd467
PE
33672011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3368
3369 Port to OpenBSD.
3370 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3371 and the surrounding thread.
3372 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3373 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3374 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3375 timer goes off.
3376 * s/openbsd.h (BROKEN_SIGIO): Define.
3377 * unexelf.c (unexec) [__OpenBSD__]:
3378 Don't update the .mdebug section of the Alpha COFF symbol table.
3379
f41628b2
LMI
33802011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3381
3382 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3383 (bug#8460).
3384
b59b67c5
PE
33852011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3386
15e3a074
PE
3387 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3388 This fixes some race conditions on the permissions of any newly
3389 created file.
3390
41bed37d
PE
3391 * alloc.c (valid_pointer_p): Use pipe, not open.
3392 This fixes some permissions issues when debugging.
3393
b59b67c5
PE
3394 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3395 If fchown fails to set both uid and gid, try to set just gid,
3396 as that is sometimes allowed. Adjust the file's mode to eliminate
3397 setuid or setgid bits that are inappropriate if fchown fails.
3398
925a6be7
SM
33992011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3400
3401 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3402 to compare Lisp_Objects.
3403 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3404 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3405 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3406
52968808
AS
34072011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3408
0a6a104b
AS
3409 * lread.c (read_integer): Unread even EOF character.
3410 (read1): Likewise. Properly record start position of symbol.
3411
52968808
AS
3412 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3413 symbol character follows.
3414
9e381cdd
PE
34152011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3416
3417 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3418 This works around a problem with the previous change to Fcopy_file.
3419 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3420 and without this change, GCC might complain about discarding
3421 fchown's return value.
3422
b5641435
JB
34232011-07-16 Juanma Barranquero <lekktu@gmail.com>
3424
3425 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3426
a8031457
PE
34272011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3428
3429 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3430
dd889327
LMI
34312011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3432
750c33f7
LMI
3433 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3434 it's used from the C level.
3435
dd889327
LMI
3436 * process.c: Use the same condition for POLL_FOR_INPUT in both
3437 keyboard.c and process.c (bug#1858).
3438
87e86684
LM
34392011-07-09 Lawrence Mitchell <wence@gmx.li>
3440
3441 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3442 (Fgnutls_boot): Use it.
3443
64348f40
AS
34442011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3445
3446 * doc.c (Fsubstitute_command_keys): Revert last change.
3447
1d698799
LMI
34482011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3449
f863868c
LMI
3450 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3451 quotes the next character, and doesn't affect other longer
3452 sequences (bug#8935).
3453
1d698799
LMI
3454 * lread.c (syms_of_lread): Clarify that is isn't only
3455 `eval-buffer' and `eval-defun' that's affected by
3456 `lexical-binding' (bug#8460).
3457
aa4b6df6
EZ
34582011-07-15 Eli Zaretskii <eliz@gnu.org>
3459
3460 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3461 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3462
5d856da6
PE
34632011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3464
ad6042bb
PE
3465 Fix minor problems found by static checking.
3466 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3467 (elsz): Now a signed constant, not a size_t var. We prefer signed
3468 types to unsigned, to avoid integer comparison confusion. Without
3469 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3470 "cannot optimize loop, the loop counter may overflow", a symptom
3471 of the confusion.
f00bbb22 3472 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3473 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3474
6468f31c
LMI
34752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3476
49080b10
LMI
3477 * search.c (Fre_search_backward): Mention `case-fold-search' in
3478 all the re_search_* functions (bug#8138).
3479
6468f31c
LMI
3480 * keyboard.c (Fopen_dribble_file): Document when the file is
3481 closed (bug#8056).
3482
c965adc5
EZ
34832011-07-14 Eli Zaretskii <eliz@gnu.org>
3484
df9733bf
EZ
3485 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3486 bidi_cache_idx.
3487
0bb23927
EZ
3488 Support bidi reordering of display and overlay strings.
3489 * xdisp.c (compute_display_string_pos)
3490 (compute_display_string_end): Accept additional argument STRING.
3491 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3492 (reseat_to_string): Initialize bidi_it->string.s and
3493 bidi_it->string.schars.
3494 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3495 NULL (avoids a crash in bidi_paragraph_init).
3496 Initialize itb.string.lstring.
0bb23927
EZ
3497 (init_iterator): Call bidi_init_it only of a valid
3498 buffer position was specified. Initialize paragraph_embedding to
3499 L2R.
3500 (reseat_to_string): Initialize the bidi iterator.
3501 (display_string): If we need to ignore text properties of
3502 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3503 original value of -1 will not work with bidi.)
3504 (compute_display_string_pos): First arg is now struct
3505 `text_pos *'; all callers changed. Support display properties on
3506 Lisp strings.
3507 (compute_display_string_end): Support display properties on Lisp
3508 strings.
3509 (init_iterator, reseat_1, reseat_to_string): Initialize the
3510 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3511 when iterating on a string not from display properties).
640c8776
SM
3512 (compute_display_string_pos, compute_display_string_end):
3513 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3514 arrow keys.
3515 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3516 base_level_stop; instead, set base_level_stop to BEGV.
3517 Fixes crashes in vertical-motion.
0bb23927
EZ
3518 (next_element_from_buffer): Improve commentary for when
3519 the iterator is before prev_stop.
3520 (init_iterator): Initialize bidi_p from the default value of
3521 bidi-display-reordering, not from buffer-local value. Use the
3522 buffer-local value only if initializing for buffer iteration.
3523 (handle_invisible_prop): Support invisible properties on strings
3524 that are being bidi-reordered.
3525 (set_iterator_to_next): Support bidi reordering of C strings and
3526 Lisp strings.
3527 (next_element_from_string): Support bidi reordering of Lisp
3528 strings.
3529 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3530 (display_string): Support display of R2L glyph rows.
3531 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3532 (init_iterator): Don't initialize it->bidi_p for strings
3533 here.
3534 (reseat_to_string): Initialize it->bidi_p for strings here.
3535 (next_element_from_string, next_element_from_c_string)
3536 (next_element_from_buffer): Add xassert's for correspondence
3537 between IT's object being iterated and it->bidi_it.string
3538 structure.
3539 (face_before_or_after_it_pos): Support bidi iteration.
3540 (next_element_from_c_string): Handle the case of the first string
3541 character that is not the first one in the visual order.
3542 (get_visually_first_element): New function, refactored from common
3543 parts of next_element_from_buffer, next_element_from_string, and
3544 next_element_from_c_string.
3545 (tool_bar_lines_needed, redisplay_tool_bar)
3546 (display_menu_bar): Force left-to-right direction. Add a FIXME
3547 comment for making that be controlled by a user option.
3548 (push_it, pop_it): Save and restore the state of the
3549 bidi iterator. Save and restore the bidi_p flag.
3550 (pop_it): Iterate out of display property for string iteration as
3551 well.
3552 (iterate_out_of_display_property): Support iteration over strings.
3553 (handle_single_display_spec): Set up it->bidi_it for iteration
3554 over a display string, and call bidi_init_it.
3555 (handle_single_display_spec, next_overlay_string)
3556 (get_overlay_strings_1, push_display_prop): Set up the bidi
3557 iterator for displaying display or overlay strings.
3558 (forward_to_next_line_start): Don't use the shortcut if
3559 bidi-iterating.
3560 (back_to_previous_visible_line_start): If handle_display_prop
3561 pushed the iterator stack, restore the internal state of the bidi
3562 iterator by calling bidi_pop_it same number of times.
3563 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3564 and we are bidi-iterating, don't decrement the iterator position;
3565 instead, set the first_elt flag in the bidi iterator, to produce
3566 the same effect.
3567 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3568 (push_display_prop): xassert that we are iterating a buffer.
3569 (push_it, pop_it): Save and restore paragraph_embedding member.
3570 (handle_single_display_spec, next_overlay_string)
3571 (get_overlay_strings_1, reseat_1, reseat_to_string)
3572 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3573 correctly. Don't assume unibyte strings are not bidi-reordered.
3574 (compute_display_string_pos)
3575 (compute_display_string_end): Fix handling the case of C string.
3576 (push_it, pop_it): Save and restore from_disp_prop_p.
3577 (handle_single_display_spec, push_display_prop): Set the
3578 from_disp_prop_p flag.
3579 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3580 (pop_it): Call iterate_out_of_display_property only if we are
3581 popping after iteration over a string that came from a display
3582 property. Fix a typo in popping stretch info. Add an assertion
3583 for verifying that the iterator position is in sync with the bidi
3584 iterator.
3585 (handle_single_display_spec, get_overlay_strings_1)
3586 (push_display_prop): Fix initialization of paragraph direction for
3587 string when that of the parent object is not yet determined.
3588 (reseat_1): Call bidi_init_it to resync the bidi
3589 iterator with IT's position. (Bug#7616)
3590 (find_row_edges): If ROW->start.pos gives position
3591 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3592 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3593 Reset the from_disp_prop_p flag.
3594 (SAVE_IT, RESTORE_IT): New macros.
3595 (pos_visible_p, face_before_or_after_it_pos)
3596 (back_to_previous_visible_line_start)
3597 (move_it_in_display_line_to, move_it_in_display_line)
3598 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3599 (try_scrolling, redisplay_window, display_line): Use them when
3600 saving a temporary copy of the iterator and restoring it back.
3601 (back_to_previous_visible_line_start, reseat_1)
3602 (init_iterator): Empty the bidi cache "stack".
3603 (move_it_in_display_line_to): If iterator ended up at
3604 EOL, but we never saw any buffer positions smaller than
3605 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3606 motion in bidi-reordered lines.
3607 (move_it_in_display_line_to): Record prev_method and prev_pos
3608 immediately before the call to set_iterator_to_next. Fixes cursor
3609 motion in bidi-reordered lines with stretch glyphs and strings
3610 displayed in margins. (Bug#8133) (Bug#8867)
3611 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3612 TO_CHARPOS.
640c8776
SM
3613 (pos_visible_p): Support positions in bidi-reordered lines.
3614 Save and restore bidi cache.
0bb23927
EZ
3615
3616 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3617 (bidi_paragraph_info): Delete unused struct.
3618 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3619 (bidi_cache_start): New variable.
3620 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3621 to zero.
3622 (bidi_cache_fetch_state, bidi_cache_search)
3623 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3624 (bidi_cache_find, bidi_peek_at_next_level)
3625 (bidi_level_of_next_char, bidi_find_other_level_edge)
3626 (bidi_move_to_visually_next): Compare cache index with
3627 bidi_cache_start rather than with zero.
3628 (bidi_fetch_char): Accept new argument STRING; all callers
3629 changed. Support iteration over a string. Support strings with
3630 display properties. Support unibyte strings. Fix the type of
3631 `len' according to what STRING_CHAR_AND_LENGTH expects.
3632 (bidi_paragraph_init, bidi_resolve_explicit_1)
3633 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3634 (bidi_level_of_next_char, bidi_move_to_visually_next):
3635 Support iteration over a string.
0bb23927
EZ
3636 (bidi_set_sor_type, bidi_resolve_explicit_1)
3637 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3638 can now be zero (for strings); special values 0 and -1 were
3639 changed to -1 and -2, respectively.
3640 (bidi_char_at_pos): New function.
3641 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3642 Call it instead of FETCH_MULTIBYTE_CHAR.
3643 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3644 initialized to valid values.
3645 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3646 values.
3647 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3648 the test for valid cached positions. Fix the logic for looking up
3649 the sentinel state in the cache. GCPRO the Lisp string we are
3650 iterating.
3651 (bidi_push_it, bidi_pop_it): New functions.
3652 (bidi_initialize): Initialize the bidi cache start stack pointer.
3653 (bidi_cache_ensure_space): New function, refactored from part of
3654 bidi_cache_iterator_state. Don't assume the required size is just
3655 one BIDI_CACHE_CHUNK away.
3656 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3657 (bidi_count_bytes, bidi_char_at_pos): New functions.
3658 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3659 always valid if bidi_cache_idx is valid.
3660 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3661 is valid if it's going to be used.
3662 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3663 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3664 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3665 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3666 (bidi_find_other_level_edge, bidi_cache_start_stack):
3667 All variables related to cache indices are now EMACS_INT.
c965adc5 3668
0bb23927
EZ
3669 * dispextern.h (struct bidi_string_data): New structure.
3670 (struct bidi_it): New member `string'. Make flag members be 1-bit
3671 fields, and put them last in the struct.
640c8776
SM
3672 (compute_display_string_pos, compute_display_string_end):
3673 Update prototypes.
0bb23927
EZ
3674 (bidi_push_it, bidi_pop_it): Add prototypes.
3675 (struct iterator_stack_entry): New members bidi_p,
3676 paragraph_embedding, and from_disp_prop_p.
3677 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3678 (bidi_shelve_cache, bidi_unshelve_cache):
3679 Declare prototypes.
0bb23927
EZ
3680
3681 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3682 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3683 and vector-like objects.
3684
3685 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3686 cache around display iteration.
3687
3688 * window.c (Fwindow_end, window_scroll_pixel_based)
3689 (displayed_window_lines, Frecenter): Save and restore the bidi
3690 cache around display iteration.
3691
3bbd2265
LMI
36922011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3693
3694 * editfns.c (Fdelete_region): Clarify the use of the named
3695 parameters (bug#6788).
3696
adc47434
MR
36972011-07-14 Martin Rudalics <rudalics@gmx.at>
3698
3699 * indent.c (Fvertical_motion): Set and restore w->pointm when
3700 saving and restoring the window's buffer (Bug#9006).
3701
837c31f8
LMI
37022011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3703
3704 * editfns.c (Fstring_to_char): Clarify just what is returned
3705 (bug#6576). Text by Eli Zaretskii.
3706
ac389d0c
JB
37072011-07-13 Juanma Barranquero <lekktu@gmail.com>
3708
3709 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3710
0be0ce47
EZ
37112011-07-13 Eli Zaretskii <eliz@gnu.org>
3712
3713 * buffer.c (mmap_find): Fix a typo.
3714
cd18e7e3
JB
37152011-07-13 Johan Bockgård <bojohan@gnu.org>
3716
3717 Fix execution of x selection hooks.
3718 * xselect.c (Qx_lost_selection_functions)
3719 (Qx_sent_selection_functions): New vars.
3720 (syms_of_xselect): DEFSYM them.
3721 (x_handle_selection_request): Pass Qx_sent_selection_functions
3722 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3723 (x_handle_selection_clear,x_clear_frame_selections):
3724 Pass Qx_lost_selection_functions rather than
3725 Vx_lost_selection_functions to Frun_hook_with_args.
3726
47ea7f44
PE
37272011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3728
ac389d0c 3729 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3730 The old code sometimes used this field without initializing it.
3731
47ea7f44
PE
3732 * alloc.c (gc_sweep): Don't read past end of array.
3733 In theory, the old code could also have corrupted Emacs internals,
3734 though it'd be very unlikely.
3735
bc985c87
AS
37362011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3737
3738 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3739 argument. (Bug#4026)
bc985c87 3740
0cf34688
LMI
37412011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3742
b3dadd76
LMI
3743 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3744 key" (bug#4257).
3745
0cf34688
LMI
3746 * window.c (Fset_window_start): Doc fix (bug#4199).
3747 (Fset_window_hscroll): Ditto.
3748
270768cd
PE
37492011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3750
077e3dda 3751 Fix minor new problems caught by GCC 4.6.1.
270768cd 3752 * term.c (init_tty): Remove unused local.
490011a6 3753 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3754 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3755 not used otherwise.
270768cd 3756
b1f58454
CY
37572011-07-12 Chong Yidong <cyd@stupidchicken.com>
3758
3759 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3760
22b9578d
LMI
37612011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3762
6e70ab07
LMI
3763 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3764 are the mini-buffer and the echo area (bug#3320).
3765
22b9578d
LMI
3766 * term.c (init_tty): Remove support for supdup, c10 and perq
3767 terminals, which are no longer supported (bug#1482).
3768
8974cc9f
JB
37692011-07-10 Johan Bockgård <bojohan@gnu.org>
3770
3771 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3772
a560d974
JD
37732011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3774
3775 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3776 for non-popups (Bug#3642).
3777
1dae0f0a
AS
37782011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3779
268c2c36 3780 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3781 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3782 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3783 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3784 * data.c (fmod): Likewise.
3785 * dispnew.c (swap_glyphs_in_rows): Likewise.
3786 * emacs.c (memory_warning_signal): Likewise.
3787 * floatfns.c (float_error): Likewise.
3788 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3789 (otf_open, font_otf_capability, generate_otf_features)
3790 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3791 Likewise.
3792 * image.c (pbm_read_file): Likewise.
3793 * indent.c (string_display_width): Likewise.
3794 * intervals.c (check_for_interval, search_for_interval)
3795 (inc_interval_count, count_intervals, root_interval)
3796 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3797 * lread.c (defalias): Likewise.
268c2c36 3798 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3799 * regex.c (set_image_of_range_1, set_image_of_range)
3800 (regex_grow_registers): Likewise.
3801 * sysdep.c (strerror): Likewise.
3802 * termcap.c (valid_filename_p, tprint, main): Likewise.
3803 * tparam.c (main): Likewise.
3804 * unexhp9k800.c (run_time_remap, save_data_space)
3805 (update_file_ptrs, read_header, write_header, calculate_checksum)
3806 (copy_file, copy_rest, display_header): Likewise.
3807 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3808 Likewise.
3809 * xdisp.c (check_it): Likewise.
3810 * xfaces.c (register_color, unregister_color, unregister_colors):
3811 Likewise.
3812 * xfns.c (print_fontset_result): Likewise.
3813 * xrdb.c (member, fatal, main): Likewise.
3814
99033785
PE
38152011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3816
3817 Fix minor problems found by static checking (Bug#9031).
3818 * chartab.c (char_table_set_range, map_sub_char_table):
3819 Remove unused locals.
3820 (uniprop_table): Now static.
3821 * composite.c (_work_char): Remove unused static var.
3822
9cb2ac56
JB
38232011-07-09 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3826
f25661f0
JD
38272011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3828
3829 * gtkutil.c (qttip_cb): Remove code without function.
3830
8278c4fe
EZ
38312011-07-09 Eli Zaretskii <eliz@gnu.org>
3832
3833 * w32.c (pthread_sigmask): New stub.
3834
1692ae2d 38352011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3836
8a6ebd58 3837 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3838 sigprocmask is portable only for single-threaded applications, and
3839 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3840 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3841 (LIBES): Use it.
3842 * callproc.c (Fcall_process):
3843 * process.c (create_process):
3844 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3845 Use pthread_sigmask, not sigprocmask.
123403e4 3846
1b854618
JD
38472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3848
3849 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3850 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3851 wrong (Bug#8591).
3852
3fe4b549
JD
38532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3854
0ce7e563
JD
3855 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3856 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3857 (xg_hide_tooltip): Fix comment.
3858
3fe4b549
JD
3859 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3860 in registerServicesMenuSendTypes.
3861 (validRequestorForSendType): Don't check ns_return_types.
3862
3863 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3864 ns_return_type.
3865
5df75e47
JR
38662011-07-08 Jason Rumney <jasonr@gnu.org>
3867
22610910
JR
3868 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3869 SH_SHOW for hidden windows (Bug#5482).
3870
5df75e47
JR
3871 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3872 frame struct members of non-existent frames (Bug#6284).
3873
699c10bd
JD
38742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3875
4393663b
JD
3876 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3877 variable firstTime not needed on OSX >= 10.6.
3878 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3879 >= 10.5. Use setKnobProportion, setDoubleValue.
3880
3881 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3882 (MAC_OS_X_VERSION_10_5): Define if not defined.
3883 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3884 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3885 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3886
3887 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3888 cString and lossyCString on OSX >= 10.4
3889
58179cce 3890 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3891 sizeToFit on OSX >= 10.2.
3892
3893 * nsimage.m (allocInitFromFile): Don't use deprecated method
3894 bestRepresentationForDevice on OSX >= 10.6.
3895
3896 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3897 to avoid warning.
3898
3899 * emacs.c: Declare unexec_init_emacs_zone.
3900
a63e0781
JD
3901 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3902
699c10bd
JD
3903 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3904
3905 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3906 on svcsMenu (Bug#8842).
3907
3908 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3909 ns_return_types.
3910 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3911
3912 * nsterm.m (QUTF8_STRING): Declare.
3913 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3914 (validRequestorForSendType): Return type is (id).
3915 Change indexOfObjectIdenticalTo to indexOfObject.
3916 Check if we have local selection before returning self (Bug#8842).
3917 (writeSelectionToPasteboard): Put local selection into paste board
3918 if we have a local selection (Bug#8842).
3919 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3920
3921 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3922 (ns_get_local_selection): Declare.
3923
54e10184
LMI
39242011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3925
9888ff71
LMI
3926 * keymap.c (describe_map_tree): Don't insert a double newline at
3927 the end of the buffer (bug#1169) and return whether we inserted
3928 something.
3929
54e10184
LMI
3930 * callint.c (Fcall_interactively): Change "reading args" to
3931 "providing args" to try to clarify what it does (bug#1010).
3932
15fa4783
KH
39332011-07-07 Kenichi Handa <handa@m17n.org>
3934
3935 * composite.c (composition_compute_stop_pos): Ignore a static
3936 composition starting before CHARPOS (Bug#8915).
3937
3938 * xdisp.c (handle_composition_prop): Likewise.
3939
a8815b00
EZ
39402011-07-07 Eli Zaretskii <eliz@gnu.org>
3941
3942 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3943 (Bug#9015)
3944
ef7b981d 39452011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3946
3947 * character.h (unicode_category_t): New enum type.
3948
3949 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3950 (Qchar_code_property_table): New variable.
3951 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3952 (UNIPROP_COMPRESSED_FORM_P): New macros.
3953 (char_table_ascii): Uncompress the compressed values.
3954 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3955 Uncompress the compressed values.
ac389d0c 3956 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3957 (char_table_ref_and_range): Uncompress the compressed values.
3958 (sub_char_table_set): New arg is_uniprop. Callers changed.
3959 Uncompress the compressed values.
3960 (sub_char_table_set_range): Args changed. Callers changed.
3961 (char_table_set_range): Adjuted for the above change.
3962 (map_sub_char_table): Delete args default_val and parent. Add arg
3963 top. Give decoded values to a Lisp function.
640c8776 3964 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3965 values to a Lisp function. Gcpro more variables.
3966 (uniprop_table_uncompress)
3967 (uniprop_decode_value_run_length): New functions.
3968 (uniprop_decoder, uniprop_decoder_count): New variables.
3969 (uniprop_get_decoder, uniprop_encode_value_character)
3970 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3971 New functions.
3972 (uniprop_encoder, uniprop_encoder_count): New variables.
3973 (uniprop_get_encoder, uniprop_table)
3974 (Funicode_property_table_internal, Fget_unicode_property_internal)
3975 (Fput_unicode_property_internal): New functions.
3976 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3977 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3978 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3979 char-code-property-alist.
3980
640c8776 3981 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3982 Vunicode_category_table.
3983
640c8776 3984 * font.c (font_range): Adjust for the change of
c805dec0
KH
3985 Vunicode_category_table.
3986
76b397fb
DN
39872011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3988
3989 * m/iris4d.h: Remove file, move contents ...
3990 * s/irix6-5.h: ... here.
3991
22b4128e
PE
39922011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3993
3994 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3995 * alloc.c (mark_buffer):
3996 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3997 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3998 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3999 This isn't true in general, and it's particularly not true
4000 if Emacs is configured with --with-wide-int.
4001 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4002 New macros, used in the buffer.c change.
4003
869795d6
JD
40042011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4005
4006 * xsettings.c: Use both GConf and GSettings if both are available.
4007 (store_config_changed_event): Add comment.
4008 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4009 (store_tool_bar_style_changed): New functions.
5e617bc2 4010 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4011 (struct xsettings): Move font inside HAVE_XFT.
4012 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4013 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4014 Move inside HAVE_XFT.
640c8776 4015 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4016 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4017 also.
4018 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4019 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4020 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4021 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4022 (parse_settings): Move check for font inside HAVE_XFT.
4023 (read_settings, apply_xft_settings): Add comment.
4024 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4025 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4026 call store_font_name_changed.
4027 (xft_settings_event): Add comment.
4028 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4029 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4030 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4031 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4032 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4033 (xsettings_get_system_font, xsettings_get_system_normal_font):
4034 Add comment.
869795d6 4035
d8ed26bd
PE
40362011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4037
4038 Random fixes. E.g., (random) never returned negative values.
4039 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4040 subseconds part to the entropy, as that's a bit more random.
4041 Prefer signed to unsigned, since the signedness doesn't matter and
4042 in general we prefer signed. When given a limit, use a
4043 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4044 latter isn't right if USE_2_TAGS_FOR_INTS.
4045 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4046 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4047
cabf1cac
SM
40482011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4049
4050 * textprop.c (text_property_stickiness):
4051 Obey Vtext_property_default_nonsticky.
4052 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4053 * w32fns.c (syms_of_w32fns):
4054 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4055
6e9b2be9
PE
40562011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4059 This is more efficient than Ffile_directory_p and avoids a minor race.
4060
90186c68
LMI
40612011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4062
7c301272
LMI
4063 * buffer.c (Foverlay_put): Say what the return value is
4064 (bug#7835).
4065
c4f2d8d4
LMI
4066 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4067 is a directory before asking whether to use the file name
4068 (bug#7564).
ad637907
LMI
4069 (barf_or_query_if_file_exists): Make the "File is a directory"
4070 error be more correct.
c4f2d8d4 4071
90186c68
LMI
4072 * fns.c (Frequire): Remove the mention of the .gz files, since
4073 that's installation-specific, but keep the mention of
4074 `get-load-suffixes'.
4075
da64016e
PE
40762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4079 Report string overflow if the output is too long.
4080
7d47b580
JB
40812011-07-04 Juanma Barranquero <lekktu@gmail.com>
4082
a555cb87
JB
4083 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4084 (syms_of_gnutls): Remove duplicate DEFSYM for
4085 Qgnutls_bootprop_verify_hostname_error, an error for
4086 Qgnutls_bootprop_verify_error (which is no longer used).
4087
7d47b580
JB
4088 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4089 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4090 Also (re)move comments that are misplaced or no longer relevant.
4091
1e49bfab
LMI
40922011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4093
4094 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4095
1485f4c0
CY
40962011-07-03 Chong Yidong <cyd@stupidchicken.com>
4097
4098 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4099 and background color parameters if they have been changed.
4100
a9ab721e
LMI
41012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4102
4103 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4104
cf7cff57
PE
41052011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4106
2e13213d
PE
4107 * xsettings.c (SYSTEM_FONT): Define only when used.
4108 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4109
cf7cff57
PE
4110 * keymap.c (access_keymap_1): Now static.
4111
7a8e04f7
CY
41122011-07-02 Chong Yidong <cyd@stupidchicken.com>
4113
4114 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4115 leave any prefix arg for the up event (Bug#1586).
4116
61352f62
LMI
41172011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4118
69bb1ef7
LMI
4119 * lread.c (syms_of_lread): Mention single symbols defined by
4120 `defvar' or `defconst' (bug#7154).
4121
61352f62 4122 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4123 (Frequire): Mention get-load-suffixes.
61352f62 4124
28545e04
MR
41252011-07-02 Martin Rudalics <rudalics@gmx.at>
4126
4127 * window.h (window): Remove clone_number slot.
4128 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4129 Remove.
4130 (make_parent_window, make_window, saved_window)
4131 (Fset_window_configuration, save_window_save): Don't deal with
4132 clone numbers.
4133 * buffer.c (Qclone_number): Remove declaration.
4134 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4135
3349e122
SM
41362011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4137
4138 Add multiple inheritance to keymaps.
4139 * keymap.c (Fmake_composed_keymap): New function.
4140 (Fset_keymap_parent): Simplify.
4141 (fix_submap_inheritance): Remove.
4142 (access_keymap_1): New function extracted from access_keymap to handle
4143 embedded parents and handle lists of maps.
4144 (access_keymap): Use it.
4145 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4146 (Fcopy_keymap): Handle embedded parents.
4147 (Fcommand_remapping, define_as_prefix): Simplify.
4148 (Fkey_binding): Simplify.
4149 (syms_of_keymap): Move minibuffer-local-completion-map,
4150 minibuffer-local-filename-completion-map,
4151 minibuffer-local-must-match-map, and
4152 minibuffer-local-filename-must-match-map to Elisp.
4153 (syms_of_keymap): Defsubr make-composed-keymap.
4154 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4155 (parse_menu_item): Trivial simplification.
4156
3279eb87
GM
41572011-07-01 Glenn Morris <rgm@gnu.org>
4158
4159 * Makefile.in (SETTINGS_LIBS): Fix typo.
4160
4550efdf
KI
41612011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4162
4163 * coding.c (Fencode_coding_string): Record the last coding system
4164 used, as the function doc string says (bug#8738).
4165
0949d2b6
JD
41662011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4167
4168 * xsettings.c (store_monospaced_changed): Take new font as arg and
4169 check for change against current_mono_font.
4170 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4171 (emacs_settings_constructor, emacs_settings_get_property)
4172 (emacs_settings_set_property, emacs_settings_class_init)
4173 (emacs_settings_init, gsettings_obj): Remove.
4174 (something_changedCB): New function for HAVE_GSETTINGS.
4175 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4176 with value as argument.
4177 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4178 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4179 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4180 "changed".
4181
4182 * xgselect.c: Add defined (HAVE_GSETTINGS).
4183 (xgselect_initialize): Ditto.
4184
4185 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4186 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4187 xg_select.
4188
bbc6b304
PE
41892011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4190
4191 * eval.c (struct backtrace): Simplify and port the data structure.
4192 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4193 signed bit field, as this assumption is not portable and it makes
4194 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4195 "char debug_on_exit : 1" as this is not portable either; instead,
4196 use the portable "unsigned int debug_on_exit : 1". Remove unused
4197 member evalargs. Remove obsolete comments about cc bombing out.
4198
9851bfc5
JD
41992011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4200
51bb811f 4201 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4202 Let HAVE_GSETTINGS override HAVE_GCONF.
4203 (store_monospaced_changed): New function.
4204 (EMACS_SETTINGS): A new type derived from GObject to handle
4205 GSettings notifications.
4206 (emacs_settings_constructor, emacs_settings_get_property)
4207 (emacs_settings_set_property, emacs_settings_class_init):
4208 New functions.
4209 (gsettings_client, gsettings_obj): New variables.
4210 (GSETTINGS_SCHEMA): New define.
4211 (something_changedCB): Call store_monospaced_changed.
4212 (init_gsettings): New function.
4213 (xsettings_initialize): Call init_gsettings.
4214 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4215 to NULL.
4216
640c8776 4217 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4218 GCONF_CFLAGS/LIBS.
4219
5386012d
MR
42202011-06-29 Martin Rudalics <rudalics@gmx.at>
4221
4222 * window.c (resize_root_window, grow_mini_window)
4223 (shrink_mini_window): Rename Qresize_root_window to
4224 Qwindow_resize_root_window and Qresize_root_window_vertically to
4225 Qwindow_resize_root_window_vertically.
4226
f13e0b08
PE
42272011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4228
4229 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4230
94515237
JB
42312011-06-27 Juanma Barranquero <lekktu@gmail.com>
4232
4233 * makefile.w32-in: Redesign dependencies so they reflect more
4234 clearly which files are directly included by each source file,
4235 and not through other includes.
4236
e43b6e43
MR
42372011-06-27 Martin Rudalics <rudalics@gmx.at>
4238
4239 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4240 (sort_overlays, overlay_strings): When an overlay's clone number
4241 matches the window's clone number process the overlay even if
4242 the overlay's window property doesn't match the current window.
4243
d68443dc
MR
4244 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4245 (Fwindow_hchild): Rename to Fwindow_left_child.
4246 (Fwindow_next): Rename to Fwindow_next_sibling.
4247 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4248 (resize_window_check): Rename to window_resize_check.
4249 (resize_window_apply): Rename to window_resize_apply.
4250 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4251 (Fdelete_other_windows_internal, resize_frame_windows)
4252 (Fsplit_window_internal, Fdelete_window_internal)
4253 (grow_mini_window, shrink_mini_window)
4254 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4255
c7e73be5
JD
42562011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4257
4258 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4259 (emacs_fixed_set_min_size): Remove.
4260 (emacs_fixed_new): Take frame as argument.
4261
4262 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4263 (_EmacsFixedPrivate): Remove minwidth/height.
4264 Add struct frame *f.
4265 (emacs_fixed_init): Initialize priv->f.
4266 (get_parent_class, emacs_fixed_set_min_size): Remove.
4267 (emacs_fixed_new): Set priv->f to argument.
4268 (emacs_fixed_get_preferred_width)
4269 (emacs_fixed_get_preferred_height): Use min_width/height from
4270 frames size_hint to set minimum and natural (Bug#8919).
4271 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4272 and use min_width/height from frames size_hint to set
4273 min_width/height (Bug#8919).
4274
4275 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4276 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4277 Fix indentation.
c7e73be5 4278
cf99dcf8
EZ
42792011-06-26 Eli Zaretskii <eliz@gnu.org>
4280
4281 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4282 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4283 called at ZV.
4284
029529ac
CY
42852011-06-26 Chong Yidong <cyd@stupidchicken.com>
4286
4287 * process.c (wait_reading_process_output): Bypass select if
4288 waiting for a cell while ignoring keyboard input, and input is
4289 pending. Suggested by Jan Djärv (Bug#8869).
4290
7a7ef429
PE
42912011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4292
4293 Use gnulib's dup2 module instead of rolling our own.
4294 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4295
11fdef7d 42962011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4297
4298 * dispnew.c (scrolling_window): Before scrolling, turn off a
4299 mouse-highlight in the window being scrolled.
4300
cd3520a4
JB
43012011-06-24 Juanma Barranquero <lekktu@gmail.com>
4302
4303 Move DEFSYM to lisp.h and use everywhere.
4304
4305 * character.h (DEFSYM): Move declaration...
4306 * lisp.h (DEFSYM): ...here.
4307
4308 * gnutls.c:
4309 * minibuf.c:
4310 * w32menu.c:
4311 * w32proc.c:
4312 * w32select.c: Don't include character.h.
4313
4314 * alloc.c (syms_of_alloc):
4315 * buffer.c (syms_of_buffer):
4316 * bytecode.c (syms_of_bytecode):
4317 * callint.c (syms_of_callint):
4318 * casefiddle.c (syms_of_casefiddle):
4319 * casetab.c (init_casetab_once):
4320 * category.c (init_category_once, syms_of_category):
4321 * ccl.c (syms_of_ccl):
4322 * cmds.c (syms_of_cmds):
4323 * composite.c (syms_of_composite):
4324 * dbusbind.c (syms_of_dbusbind):
4325 * dired.c (syms_of_dired):
4326 * dispnew.c (syms_of_display):
4327 * doc.c (syms_of_doc):
4328 * editfns.c (syms_of_editfns):
4329 * emacs.c (syms_of_emacs):
4330 * eval.c (syms_of_eval):
4331 * fileio.c (syms_of_fileio):
4332 * fns.c (syms_of_fns):
4333 * frame.c (syms_of_frame):
4334 * fringe.c (syms_of_fringe):
4335 * insdel.c (syms_of_insdel):
4336 * keymap.c (syms_of_keymap):
4337 * lread.c (init_obarray, syms_of_lread):
4338 * macros.c (syms_of_macros):
4339 * msdos.c (syms_of_msdos):
4340 * print.c (syms_of_print):
4341 * process.c (syms_of_process):
4342 * search.c (syms_of_search):
4343 * sound.c (syms_of_sound):
4344 * syntax.c (init_syntax_once, syms_of_syntax):
4345 * terminal.c (syms_of_terminal):
4346 * textprop.c (syms_of_textprop):
4347 * undo.c (syms_of_undo):
4348 * w32.c (globals_of_w32):
4349 * window.c (syms_of_window):
4350 * xdisp.c (syms_of_xdisp):
4351 * xfaces.c (syms_of_xfaces):
4352 * xfns.c (syms_of_xfns):
4353 * xmenu.c (syms_of_xmenu):
4354 * xsettings.c (syms_of_xsettings):
4355 * xterm.c (syms_of_xterm): Use DEFSYM.
4356
4228cf16
TZ
43572011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4358
cd3520a4 4359 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4360
7fcccf1e
PE
43612011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4362
7efb4e0e
PE
4363 Integer and buffer overflow fixes (Bug#8873).
4364
ff5844ad
PE
4365 * print.c (printchar, strout): Check for string overflow.
4366 (PRINTPREPARE, printchar, strout):
4367 Don't set size unless allocation succeeds.
4368
90532f02
PE
4369 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4370 for sizes. Check for string overflow more accurately.
4371 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4372
6d84508d
PE
4373 * macros.c: Integer and buffer overflow fixes.
4374 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4375 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4376 Use ptrdiff_t, not int, for sizes.
4377 Don't increment bufsize until after realloc succeeds.
4378 Check for size-calculation overflow.
4379 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4380
437b2cb4
PE
4381 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4382
8b9ac8b4
PE
4383 * lread.c: Integer overflow fixes.
4384 (read_integer): Radix is now EMACS_INT, not int,
4385 to improve quality of diagnostics for out-of-range radices.
4386 Calculate buffer size correctly for out-of-range radices.
4387 (read1): Check for integer overflow in radices, and in
4388 read-circle numbers.
82cb60d3
PE
4389 (read_escape): Avoid int overflow.
4390 (Fload, openp, read_buffer_size, read1)
4391 (substitute_object_recurse, read_vector, read_list, map_obarray):
4392 Use ptrdiff_t, not int, for sizes.
4393 (read1): Use EMACS_INT, not int, for sizes.
20270765 4394 Check for size overflow.
8b9ac8b4 4395
7fcccf1e
PE
4396 * image.c (cache_image): Check for size arithmetic overflow.
4397
bfbbd7e7
PE
4398 * lread.c: Integer overflow issues.
4399 (saved_doc_string_size, saved_doc_string_length)
4400 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4401 Now ptrdiff_t, not int.
4402 (read1): Don't assume doc string length fits in int. Check for
4403 out-of-range doc string lengths.
4404 (read_list): Don't assume file position fits in int.
39019e54 4405 (read_escape): Check for hex character overflow.
bfbbd7e7 4406
4e323265
LL
44072011-06-22 Leo Liu <sdl.web@gmail.com>
4408
4409 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4410 Move to minibuffer.el.
4411
85fece3e
PE
44122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4413
20b84ce9 4414 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4415 The following patches are for when GLYPH_DEBUG && !XASSERT.
4416 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4417 * dispnew.c (flush_stdout):
4418 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4419 Mark as externally visible.
4420 * dispnew.c (check_window_matrix_pointers): Now static.
4421 * dispnew.c (window_to_frame_vpos):
4422 * xfns.c (unwind_create_frame):
4423 * xterm.c (x_check_font): Remove unused local.
4424 * scroll.c (CHECK_BOUNDS):
4425 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4426 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4427 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4428 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4429 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4430 Now static.
4431 (debug_method_add): Use va_list and vsprintf rather than relying
4432 on undefined behavior with wrong number of arguments.
4433 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4434 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4435 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4436 since we're not interested in debugging glyphs with old libraries.
4437 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4438 GCC 4.6.0's static checking.
4439
0766b489
PE
44402011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4441
31fd4b32
PE
4442 Integer overflow and signedness fixes (Bug#8873).
4443 A few related buffer overrun fixes, too.
4444
b79e8648
PE
4445 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4446
0766b489
PE
4447 * dispextern.h (struct face.stipple):
4448 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4449 (x_bitmap_mask, x_allocate_bitmap_record)
4450 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4451 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4452 (x_create_bitmap_from_xpm_data):
4453 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4454 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4455 (.bitmaps_last):
4456 * xfaces.c (load_pixmap):
4457 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4458 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4459 (.bitmaps_last, struct x_output.icon_bitmap):
4460 Use ptrdiff_t, not int, for bitmap indexes.
4461 (x_allocate_bitmap_record): Check for size overflow.
4462 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4463
b081724f
PE
4464 Use ptrdiff_t, not int, for overlay counts.
4465 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4466 * editfns.c (overlays_around, get_pos_property):
4467 * textprop.c (get_char_property_and_overlay):
4468 * xdisp.c (next_overlay_change, note_mouse_highlight):
4469 * xfaces.c (face_at_buffer_position):
21514da7
PE
4470 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4471 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4472 (Fnext_overlay_change, Fprevious_overlay_change)
4473 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4474 Use ptrdiff_t, not int, for sizes.
21514da7 4475 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4476
3de73e5e
PE
4477 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4478
2606c57b
PE
4479 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4480 (x_session_initialize): Do not assume string length fits in int.
4481
aaafe47a
PE
4482 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4483 This is unlikely, but can occur if DPI is outlandish.
4484
2674ddc8 4485 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4486 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4487
28154962
PE
4488 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4489 * xrdb.c (magic_file_p, search_magic_path):
4490 Omit last arg SUFFIX; it was always 0. All callers changed.
4491 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4492
7de51af5
PE
4493 * xfont.c (xfont_match): Avoid need for strlen.
4494
25ed6cc3
PE
4495 * xfns.c: Don't assume strlen fits in int.
4496 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4497
4eab31dd
PE
4498 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4499 not unsigned long, as we prefer signed integers. All callers changed.
4500 Detect integer overflow in repeat count.
4501 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4502 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4503
171e2a58
PE
4504 * termcap.c: Don't assume sizes fit in int and never overflow.
4505 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4506 (gobble_line): Check for size-calculation overflow.
4507
ad39faca 4508 * minibuf.c (Fread_buffer):
6e5bb2dc 4509 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4510 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4511 Don't assume string length fits in int.
4512
52c61c22 4513 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4514 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4515
b5b8c9e5
PE
4516 * font.c: Don't assume string length fits in int.
4517 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4518 Use ptrdiff_t, not int.
ccd6111c
PE
4519 (font_intern_prop): Don't assume string length fits in int.
4520 Don't assume integer property fits in fixnum.
4521 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4522
882f0d81 4523 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4524 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4525 Reformulate so as not to need the command string.
4526 Invoke gzip -cd rather than gunzip, as it's more portable.
4527 (lock_info_type, lock_file_1, lock_file):
4528 Don't assume pid_t and time_t fit in unsigned long.
4529 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4530 (current_lock_owner): Prefer signed type for sizes.
4531 Use memcpy, not strncpy, where memcpy is what is really wanted.
4532 Don't assume (via atoi) that time_t and pid_t fit in int.
4533 Check for time_t and/or pid_t out of range, e.g., via a network share.
4534 Don't alloca where an auto var works fine.
4535
93f4cf88
PE
4536 * fileio.c: Fix some integer overflow issues.
4537 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4538 Don't assume string length fits in int.
4539 (directory_file_name): Don't assume string length fits in long.
4540 (make_temp_name): Don't assume pid fits in int, or that its print
4541 length is less than 20.
4542
f3e92b69
PE
4543 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4544
1bfdaf10
PE
4545 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4546
35016e9a
PE
4547 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4548
3d1e65a1
PE
4549 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4550 We prefer signed integers, even for size calculations.
4551
0b963a93
PE
4552 * emacs.c: Don't assume string length fits in 'int'.
4553 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4554 (main): Don't invoke strlen when not needed.
4555
573f4b54
PE
4556 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4557 (XD_DEBUG_MESSAGE): Don't waste a byte.
4558
989f33ba
PE
4559 * callproc.c (getenv_internal_1, getenv_internal)
4560 (Fgetenv_internal):
965d34eb
PE
4561 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4562
e4d29b33
PE
4563 * lread.c (invalid_syntax): Omit length argument.
4564 All uses changed. This doesn't fix a bug, but it simplifies the
4565 code away from its former Hollerith-constant appearance, and it's
4566 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4567 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4568
eb49b136
PE
4569 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4570 This didn't break anything, but it didn't help either.
4571 It's confusing to put a bogus integer in a place where the actual
4572 value does not matter.
9f62aeb1 4573 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4574 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4575
15375a22
PE
4576 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4577 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4578 implementation.
b61cc01c
PE
4579 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4580 We prefer signed types, and the value cannot exceed the EMACS_INT
4581 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4582 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4583 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4584 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4585
53b2623d
PE
4586 * indent.c (sane_tab_width): New function.
4587 (current_column, scan_for_column, Findent_to, position_indentation)
4588 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4589 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4590
51cab52b 4591 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4592
f2ed8a70
PE
4593 * lisp.h (lint_assume): New macro.
4594 * composite.c (composition_gstring_put_cache):
4595 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4596
abe80cc6
PE
4597 * editfns.c, insdel.c:
4598 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4599
b02c740e
PE
4600 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4601
ebc96716
PE
4602 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4603
b4e50fa0 4604 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4605 Use much-faster test for byte-length change.
311d5d7c 4606 Don't assume string byte-length fits in 'int'.
a4cf38e4 4607 Check that character arg fits in 'int'.
85461888 4608 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4609
c0c1ee9f
PE
4610 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4611
a498d7f4
PE
4612 * fns.c (concat): Catch string overflow earlier.
4613 Do not rely on integer wraparound.
4614
51cab52b
PE
4615 * dispextern.h (struct it.overlay_strings_charpos)
4616 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4617 * xdisp.c (forward_to_next_line_start)
4618 (back_to_previous_visible_line_start)
4619 (reseat_at_next_visible_line_start, next_element_from_buffer):
4620 Don't arbitrarily truncate the value of 'selective' to int.
4621
76031fad
PE
4622 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4623
5eb55db9
PE
4624 * composite.c: Don't truncate sizes to 'int'.
4625 (composition_gstring_p, composition_reseat_it)
4626 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4627 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4628 not EMACS_UINT, for indexes.
5eb55db9 4629
0703a717
PE
4630 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4631
d6202519
PE
4632 * buffer.c: Include <verify.h>.
4633 (struct sortvec.priority, struct sortstr.priority):
8961a454 4634 Now EMACS_INT, not int.
c20998a7 4635 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4636 (struct sortstr.size, record_overlay_string)
4637 (struct sortstrlist.size, struct sortlist.used):
4638 Don't truncate size to int.
4639 (record_overlay_string): Check for size-calculation overflow.
d6202519 4640 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4641
d5a19415
JM
46422011-06-22 Jim Meyering <meyering@redhat.com>
4643
029529ac 4644 Don't leak an XBM-image-sized buffer
d5a19415
JM
4645 * image.c (xbm_load): Free the image buffer after using it.
4646
a9041e6c
PE
46472011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4648
4649 Port to Sun C.
4650 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4651 that Sun C diagnosed.
4652 * fns.c (secure_hash): Fix pointer signedness issue.
4653 * intervals.c (static_offset_intervals): New function.
4654 (offset_intervals): Use it.
4655
7f3f739f
LL
46562011-06-21 Leo Liu <sdl.web@gmail.com>
4657
4658 * deps.mk (fns.o):
4659 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4660 sha512.h.
4661
4662 * fns.c (secure_hash): Rename from crypto_hash_function and change
4663 the first arg to accept symbols.
5b66d427 4664 (Fsecure_hash): New primitive.
7f3f739f
LL
4665 (syms_of_fns): New symbols.
4666
76147d94
DD
46672011-06-20 Deniz Dogan <deniz@dogan.se>
4668
4669 * process.c (Fset_process_buffer): Clarify return value in
4670 docstring.
4671
7d7d0045
CY
46722011-06-18 Chong Yidong <cyd@stupidchicken.com>
4673
4674 * dispnew.c (add_window_display_history): Use BVAR.
4675
4676 * xdisp.c (debug_method_add): Use BVAR.
4677 (check_window_end, dump_glyph_matrix, dump_glyph)
4678 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4679
4680 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4681 Likewise.
4682
4683 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4684 check till after the cache is created in init_frame_faces.
4685
ff2bc410
SM
46862011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4687
4688 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4689
28177add
PE
46902011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4691
dd3482fe
PE
4692 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4693 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4694 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4695
393d71f3 4696 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4697 * fileio.c (Finsert_file_contents):
4698 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4699 Remove the old (too-loose) buffer overflow checks.
4700 They weren't needed, since make_gap checks for buffer overflow.
4701 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4702 The old code merely checked for Emacs fixnum overflow, and relied
4703 on undefined (wraparound) behavior. The new code avoids undefined
4704 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4705
2e6813b0 4706 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4707 Tune. Don't use wider integers than needed. Don't use alloca.
4708 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4709
599a9e4f
PE
4710 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4711
99561444
PE
4712 * insdel.c, lisp.h (buffer_overflow): New function.
4713 (insert_from_buffer_1, replace_range, replace_range_2):
4714 * insdel.c (make_gap_larger):
4715 * editfns.c (Finsert_char):
4716 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4717
28177add
PE
4718 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4719
e69dafad
PE
47202011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4721
4baa020d 4722 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4723
b1c46f02
PE
4724 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4725 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4726
e69dafad
PE
4727 * fileio.c: Don't assume EMACS_INT fits in off_t.
4728 (emacs_lseek): New static function.
4729 (Finsert_file_contents, Fwrite_region): Use it.
4730 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4731
566684ea
PE
4732 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4733
e6966cd6
PE
4734 * fns.c: Don't overflow int when computing a list length.
4735 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4736 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4737 truncation on 64-bit hosts. Check for QUIT every
4738 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4739 faster and is responsive enough.
4740 (Flength): Report an error instead of overflowing an integer.
4741 (Fsafe_length): Return a float if the value is not representable
4742 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4743 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4744 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4745
dd0b0efb
PE
4746 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4747 (header_size, word_size): New constants.
4748 (allocate_vectorlike): Don't check size overflow here.
4749 (allocate_vector): Check it here instead, since this is the only
4750 caller of allocate_vectorlike that could cause overflow.
4751 Check that the new vector's length is representable as a fixnum.
4752
86fe5cfe
PE
4753 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4754 The previous code was bogus. For example, next_almost_prime (32)
4755 returned 39, which is undesirable as it is a multiple of 3; and
4756 next_almost_prime (24) returned 25, which is a multiple of 5 so
4757 why was the code bothering to check for multiples of 7?
4758
80e88859
PE
4759 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4760
4a2f0ad6
PE
4761 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4762
f66c7cf8
PE
4763 Variadic C functions now count arguments with ptrdiff_t.
4764 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4765 Back then I didn't know that the Emacs coding style prefers signed int.
4766 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4767 were being counted with int, which may truncate counts on 64-bit
4768 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4769 * lisp.h (struct Lisp_Subr.function.aMANY)
4770 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4771 Arg counts are now ptrdiff_t, not size_t.
4772 All variadic functions and their callers changed accordingly.
4773 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4774 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4775 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4776 * callint.c (Fcall_interactively): Check arg count for overflow,
4777 to avoid potential buffer overrun. Use signed char, not 'int',
4778 for 'varies' array, so that we needn't bother to check its size
4779 calculation for overflow.
4780 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4781 * eval.c (apply_lambda):
4782 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4783 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4784 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4785
a1759b76
PE
4786 * callint.c (Fcall_interactively): Don't use index var as event count.
4787
d96be9fc
PE
4788 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4789 * mem-limits.h (SIZE): Remove; no longer used.
4790
a690a978 4791 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4792
578c21e6
PE
4793 Remove unnecessary casts.
4794 * xterm.c (x_term_init):
4795 * xfns.c (x_set_border_pixel):
4796 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4797 These aren't needed now that we assume ANSI C.
4798
96f53c6c
PE
4799 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4800 It's more likely to cause problems (due to unsigned overflow)
4801 than to cure them.
4802
83c77d31
PE
4803 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4804
ee2079f1
PE
4805 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4806
6da65536
PE
4807 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4808
7147c4a4
PE
4809 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4810
193e32d9
PE
4811 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4812
e5533da6
PE
4813 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4814
9910e595
PE
4815 GLYPH_CODE_FACE returns EMACS_INT, not int.
4816 * dispextern.h (merge_faces):
4817 * xfaces.c (merge_faces):
01103c44
PE
4818 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4819 Don't assume EMACS_INT fits in int.
9910e595 4820
2638320e
PE
4821 * character.h (CHAR_VALID_P): Remove unused parameter.
4822 * fontset.c, lisp.h, xdisp.c: All uses changed.
4823
045eb8d9
PE
4824 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4825
c1f134b5
PE
4826 * fns.c (concat): Minor tuning based on overflow analysis.
4827 This doesn't fix any bugs. Use int to hold character, instead
4828 of constantly refetching from Emacs object. Use XFASTINT, not
4829 XINT, for value known to be a character. Don't bother comparing
4830 a single byte to 0400, as it's always less.
4831
395fcb93 4832 * floatfns.c (Fexpt):
327eeec8
PE
4833 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4834
abbd3d23
PE
4835 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4836 for characters.
4837
684a03ef
PE
4838 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4839
0fed43f3
PE
4840 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4841 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4842 incorrectly succeed when S was a string, because 4294967386 was
4843 truncated before it was used.
4844
8fd02eb7
PE
4845 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4846 Otherwise, an out-of-range integer could cause undefined behavior
4847 on a 64-bit host.
4848
f8c86b69
PE
4849 * composite.c: Use int, not EMACS_INT, for characters.
4850 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4851 EMACS_INT, for values that are known to be in character range.
4852 This doesn't fix any bugs but is the usual style inside Emacs and
4853 may generate better code on 32-bit machines.
4854
34206dd2
PE
4855 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4856 This is for reasons similar to the recent CHAR_STRING fix.
4857 * charset.c (Fencode_char): Check that character arg is actually
4858 a character. Pass an int to ENCODE_CHAR.
4859 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4860 wider than 'int', as a compile-time check to prevent future regressions
4861 in this area.
4862
c5958d4c 4863 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4864
4865 Make sure a 64-bit char is never passed to CHAR_STRING.
4866 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4867 by silently ignoring the top 32 bits, allowing some values
4868 that were far too large to be valid characters.
4869 * character.h: Include <verify.h>.
4870 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4871 arguments are no wider than unsigned, as a compile-time check
4872 to prevent future regressions in this area.
4873 * data.c (Faset):
01103c44 4874 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4875 (Fsubst_char_in_region):
4876 * fns.c (concat):
4877 * xdisp.c (decode_mode_spec_coding):
4878 Adjust to CHAR_STRING's new requirement.
4879 * editfns.c (Finsert_char, Fsubst_char_in_region):
4880 * fns.c (concat): Check that character args are actually
4881 characters. Without this test, these functions did the wrong
4882 thing with wildly out-of-range values on 64-bit hosts.
4883
d37ca623
PE
4884 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4885 These casts should not be needed on 32-bit hosts, either.
4886 * keyboard.c (read_char):
4887 * lread.c (Fload): Remove casts to unsigned.
4888
ea204efb
PE
4889 * lisp.h (UNSIGNED_CMP): New macro.
4890 This fixes comparison bugs on 64-bit hosts.
4891 (ASCII_CHAR_P): Use it.
4892 * casefiddle.c (casify_object):
01103c44 4893 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4894 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4895 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4896 * dispextern.h (FACE_FROM_ID):
4897 * keyboard.c (read_char): Use UNSIGNED_CMP.
4898
41cb286c
PE
4899 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4900 not to EMACS_INT, to avoid GCC warning.
4901
4a1b9832
PE
4902 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4903
55daad71
PE
4904 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4905 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4906 isn't needed on 32-bit machines.
8f95c75c 4907
01103c44
PE
4908 * buffer.c (Fgenerate_new_buffer_name):
4909 Use EMACS_INT for count, not int.
0ceccced 4910 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4911
4912 * data.c (Qcompiled_function): Now static.
4913
c6f072e7
PE
4914 * window.c (window_body_lines): Now static.
4915
20ce5912
PE
4916 * image.c (gif_load): Rename local to avoid shadowing.
4917
9c4c5f81
PE
4918 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4919 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4920 * alloc.c (make_save_value): Integer argument is now of type
4921 ptrdiff_t, not int.
4922 (mark_object): Use ptrdiff_t, not int.
4923 * lisp.h (pD): New macro.
4924 * print.c (print_object): Use it.
4925
c0c5c8ae
PE
4926 * alloc.c: Use EMACS_INT, not int, to count objects.
4927 (total_conses, total_markers, total_symbols, total_vector_size)
4928 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4929 (total_free_floats, total_floats, total_free_intervals)
4930 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4931 Now EMACS_INT, not int. All uses changed.
4932 (Fgarbage_collect): Compute overall total using a double, so that
4933 integer overflow is less likely to be a problem. Check for overflow
4934 when converting back to an integer.
5a25e253
PE
4935 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4936 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4937 These were 'int' variables that could overflow on 64-bit hosts;
4938 they were never used, so remove them instead of repairing them.
211a0b2a 4939 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4940 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4941 Previously, this ceilinged at INT_MAX, but that doesn't work on
4942 64-bit machines.
e46bb31a 4943 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4944
c78baabf 4945 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4946 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4947 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4948 when a (possibly-narrower) signed value would do just as well.
4949 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4950
c9d624c6
PE
4951 * alloc.c: Catch some string size overflows that we were missing.
4952 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4953 for convenience in STRING_BYTES_MAX.
4954 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4955 The definition here is exact; the one in lisp.h was approximate.
4956 (allocate_string_data): Check for string overflow. This catches
4957 some instances we weren't catching before. Also, it catches
4958 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4959 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4960 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4961
c9d624c6
PE
4962 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4963 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4964 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4965
353032ce
PE
4966 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4967
2bccce07
PE
4968 * alloc.c (Fmake_string): Check for out-of-range init.
4969
0ac30604
SM
49702011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4971
4972 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4973
c195f2de
JD
49742011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4975
4976 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4977 xg_get_default_scrollbar_width.
4978
4979 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4980 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4981 (style_changed_cb): Call update_theme_scrollbar_width and call
4982 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4983 all frames (Bug#8505).
4984 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4985 Call gtk_window_set_resizable if HAVE_GTK3.
4986 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4987 and height if HAVE_GTK3 (Bug#8505).
4988 (scroll_bar_width_for_theme): New variable.
4989 (update_theme_scrollbar_width): New function.
4990 (xg_get_default_scrollbar_width): Move code to
4991 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4992 (xg_initialize): Call update_theme_scrollbar_width.
4993
4994 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4995
4996 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4997
e10ac9f1
MR
49982011-06-12 Martin Rudalics <rudalics@gmx.at>
4999
5000 * frame.c (make_frame): Call other_buffer_safely instead of
5001 other_buffer.
5002
5003 * window.c (temp_output_buffer_show): Call display_buffer with
5004 second argument Vtemp_buffer_show_specifiers and reset latter
5005 immediately after the call.
5006 (Vtemp_buffer_show_specifiers): New variable.
5007 (auto_window_vscroll_p, next_screen_context_lines)
5008 (Vscroll_preserve_screen_position): Remove leading asterisks from
5009 doc-strings.
5010
2d3c217e 50112011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5012
7b7f97e8 5013 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5014 * buffer.c (Qclone_number): Remove for now, as it's unused.
5015 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5016 (record_buffer): Remove unused local.
5017 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5018 (set_frame_buffer_list): Remove; unused.
5019 * frame.h (other_visible_frames): Remove decl.
5020 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5021 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5022 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5023 if HAVE_GPM.
5024 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5025 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5026 Define only if HAVE_GPM.
5027 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5028 (update_hints_inhibit): Remove; never set. All uses removed.
5029 * widgetprv.h (emacsFrameClassRec): Remove decl.
5030 * window.c (delete_deletable_window): Now returns void, since it
5031 wasn't returning anything.
5032 (compare_window_configurations): Remove unused locals.
5033 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5034 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5035 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5036 the same widths as pointers. This follows up on the 2011-05-06 patch.
5037 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5038 * xterm.h: Likewise.
5039 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5040
1384b89e
JB
50412011-06-12 Juanma Barranquero <lekktu@gmail.com>
5042
5043 * makefile.w32-in: Update dependencies.
5044 (LISP_H): Add lib/intprops.h.
5045
1100a63c
CY
50462011-06-11 Chong Yidong <cyd@stupidchicken.com>
5047
5048 * image.c (gif_load): Add animation frame delay to the metadata.
5049 (syms_of_image): Use DEFSYM. New symbol `delay'.
5050
6198ccd0
MR
50512011-06-11 Martin Rudalics <rudalics@gmx.at>
5052
5053 * window.c (delete_deletable_window): Re-add.
5054 (Fset_window_configuration): Rewrite to handle dead buffers and
5055 consequently deletable windows.
5056 (window_tree, Fwindow_tree): Remove. Supply functionality in
5057 window.el.
5058 (compare_window_configurations): Simplify code.
5059
b6e3633c
AS
50602011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5061
1ab0dee5
AS
5062 * image.c (imagemagick_load_image): Fix type mismatch.
5063 (Fimagemagick_types): Likewise.
5064
b6e3633c
AS
5065 * window.h (replace_buffer_in_windows): Declare.
5066
9397e56f
MR
50672011-06-11 Martin Rudalics <rudalics@gmx.at>
5068
5069 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5070 Qclone_number. Remove external declaration of Qdelete_window.
5071 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5072 code.
640c8776
SM
5073 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5074 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5075 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5076 buffer list implementation.
5077 (other_buffer_safely): New function.
5078 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5079 calls to replace_buffer_in_windows and
5080 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5081 if allowed.
5082 (record_buffer): Inhibit quitting and rewrite using quittable
5083 functions. Run Qbuffer_list_update_hook if allowed.
5084 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5085 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5086 Move switch-to-buffer to window.el.
9397e56f
MR
5087 (bury-buffer): Move to window.el.
5088 (Vbuffer_list_update_hook): New variable.
5089
5090 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5091 section.
5092
5093 * window.h (resize_frame_windows): Move up in code.
5094 (Fwindow_frame): Remove EXFUN.
5095 (replace_buffer_in_all_windows): Remove prototype.
5096 (replace_buffer_in_windows_safely): Add prototype.
5097
5098 * window.c: Declare Qdelete_window static again. Move down
5099 declaration of select_count.
5100 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5101 (Fother_window): Move to window.el.
5102 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5103 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5104 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5105 window.el.
5106 (replace_buffer_in_windows): Implement by calling
5107 Qreplace_buffer_in_windows.
5108 (replace_buffer_in_all_windows): Remove with some functionality
5109 moved into replace_buffer_in_windows_safely.
5110 (replace_buffer_in_windows_safely): New function.
5111 (select_window_norecord, select_frame_norecord): Move in front
5112 of run_window_configuration_change_hook. Remove now obsolete
5113 declarations.
640c8776
SM
5114 (Fset_window_buffer): Rewrite doc-string.
5115 Call Qrecord_window_buffer.
9397e56f
MR
5116 (keys_of_window): Move binding for other-window to window.el.
5117
b50691aa
CY
51182011-06-11 Chong Yidong <cyd@stupidchicken.com>
5119
5120 * dispextern.h (struct image): Replace data member, whose int_val
5121 and ptr_val fields were not used by anything, with a single
5122 lisp_val object.
5123
5124 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5125 (gif_clear_image, gif_load, imagemagick_load_image)
5126 (gs_clear_image, gs_load): Callers changed.
5127
3f754b86
PE
51282011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5129
cca69397
PE
5130 * buffer.h: Include <time.h>, for time_t.
5131 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5132
109e28d0
PE
5133 Fix minor problems found by static checking.
5134
60737f02
PE
5135 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5136
4b66faf3
PE
5137 Make identifiers static if they are not used in other modules.
5138 * data.c (Qcompiled_function, Qframe, Qvector):
5139 * image.c (QimageMagick, Qsvg):
5140 * minibuf.c (Qmetadata):
5141 * window.c (resize_window_check, resize_root_window): Now static.
5142 * window.h (resize_window_check, resize_root_window): Remove decls.
5143
109e28d0
PE
5144 * window.c (window_deletion_count, delete_deletable_window):
5145 Remove; unused.
46a4ce9e
PE
5146 (window_body_lines): Now static.
5147 (Fdelete_other_windows_internal): Mark vars as initialized.
5148 Make sure 'resize_failed' is initialized.
5149 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5150 (resize_window_apply): Remove unused local.
5151 * window.h (delete_deletable_window): Remove decl.
5152
109e28d0 5153 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5154 (imagemagick_load_image): Fix pointer signedness problem by changing
5155 last arg from unsigned char * to char *. All uses changed.
5156 Also, fix a local for similar reasons.
5157 Remove unused locals. Remove locals to avoid shadowing.
5158 (fn_rsvg_handle_free): Remove; unused.
5159 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5160 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5161
3f754b86
PE
5162 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5163
2547adb1
CY
51642011-06-10 Chong Yidong <cyd@stupidchicken.com>
5165
5166 * image.c (gif_load): Fix omitted cast error introduced by
5167 2011-06-06 change.
5168
2c8e37d4
MR
51692011-06-10 Martin Rudalics <rudalics@gmx.at>
5170
5171 * window.h (resize_proportionally, orig_total_lines)
5172 (orig_top_line): Remove from window structure.
5173 (set_window_height, set_window_width, change_window_heights)
5174 (Fdelete_window): Remove prototypes.
5175 (resize_frame_windows): Remove duplicate declaration.
5176
440a42e3
EZ
51772011-06-10 Eli Zaretskii <eliz@gnu.org>
5178
5179 * window.h (resize_frame_windows, resize_window_check)
5180 (delete_deletable_window, resize_root_window)
5181 (resize_frame_windows): Declare prototypes.
5182
5183 * window.c (resize_window_apply): Make definition be "static" to
5184 match the prototype.
5185
562dd5e9
MR
51862011-06-10 Martin Rudalics <rudalics@gmx.at>
5187
5188 * window.c: Remove declarations of Qwindow_size_fixed,
5189 window_min_size_1, window_min_size_2, window_min_size,
5190 size_window, window_fixed_size_p, enlarge_window, delete_window.
5191 Remove static from declaration of Qdelete_window, it's
5192 temporarily needed by Fbury_buffer.
5193 (replace_window): Don't assign orig_top_line and
5194 orig_total_lines.
5195 (Fdelete_window, delete_window): Remove. Window deletion is
5196 handled by window.el.
640c8776
SM
5197 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5198 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5199 (Fdelete_other_windows): Remove. Deleting other windows is
5200 handled by window.el.
5201 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5202 handled in window.el.
5203 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5204 Window minimum sizes are handled in window.el.
5205 (shrink_windows, size_window, set_window_height)
5206 (set_window_width, change_window_heights, window_height)
5207 (window_width, CURBEG, CURSIZE, enlarge_window)
5208 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5209 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5210 handled in window.el.
5211 (make_dummy_parent): Rename to make_parent_window and give it a
5212 second argument horflag.
5213 (make_window): Don't set resize_proportionally any more.
5214 (Fsplit_window): Remove. Windows are split in window.el.
5215 (save_restore_action, save_restore_orig_size)
5216 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5217 Resize mini windows in window.el.
5218 (grow_mini_window, shrink_mini_window): Implement by calling
5219 Qresize_root_window_vertically, resize_window_check and
5220 resize_window_apply.
640c8776
SM
5221 (saved_window, Fset_window_configuration, save_window_save):
5222 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5223 resize_proportionally.
5224 (window_min_height, window_min_width): Move to window.el.
5225 (keys_of_window): Move bindings for delete-other-windows,
5226 split-window, delete-window and enlarge-window to window.el.
5227
5228 * buffer.c: Temporarily extern Qdelete_window.
5229 (Fbury_buffer): Temporarily call Qdelete_window instead of
5230 Fdelete_window (Fbury_buffer will move to window.el soon).
5231
5232 * frame.c (set_menu_bar_lines_1): Remove code handling
5233 orig_top_line and orig_total_lines.
5234
5235 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5236 set_window_height but set heights directly.
5237 (change_frame_size_1): Use resize_frame_windows.
5238
5239 * xdisp.c (init_xdisp): Don't use set_window_height but set
5240 heights directly.
5241
640c8776
SM
5242 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5243 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5244 run_window_configuration_change_hook.
5245
5246 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5247 instead of change_window_heights and run
5248 run_window_configuration_change_hook.
5249
1a13852e
MR
52502011-06-09 Martin Rudalics <rudalics@gmx.at>
5251
5252 * window.c (replace_window): Rename second argument REPLACEMENT to
5253 NEW. New third argument SETFLAG. Rewrite.
5254 (delete_window, make_dummy_parent): Call replace_window with
5255 third argument 1.
5256 (window_list_1): Move down in code.
5257 (run_window_configuration_change_hook): Move set_buffer part
5258 before select_frame_norecord part in order to unwind correctly.
5259 Rename count1 to count.
5260 (recombine_windows, delete_deletable_window, resize_root_window)
5261 (Fdelete_other_windows_internal)
5262 (Frun_window_configuration_change_hook, make_parent_window)
5263 (resize_window_check, resize_window_apply, Fresize_window_apply)
5264 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5265 (Fdelete_window_internal, Fresize_mini_window_internal):
5266 New functions.
1a13852e
MR
5267 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5268
f3d1777e
MR
52692011-06-08 Martin Rudalics <rudalics@gmx.at>
5270
496e208e
MR
5271 * window.h (window): Add some new members to window structure -
5272 normal_lines, normal_cols, new_total, new_normal, clone_number,
5273 splits, nest, prev_buffers, next_buffers.
5274 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5275 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5276
f3d1777e
MR
5277 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5278 Remove.
496e208e
MR
5279 (make_dummy_parent): Set new members of windows structure.
5280 (make_window): Move down in code. Handle new members of window
5281 structure.
5282 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5283 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5284 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5285 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5286 (Fset_window_next_buffers, Fset_window_clone_number):
5287 New functions.
496e208e
MR
5288 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5289 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5290 Doc-string fixes.
5291 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5292 Argument WINDOW can be now internal window too.
5293 (Fwindow_use_time): Move up in code.
5294 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5295 Rewrite doc-string.
5296 (Fset_window_configuration, saved_window)
5297 (Fcurrent_window_configuration, save_window_save): Handle new
5298 members of window structure.
b9e809c2
MR
5299 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5300 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5301 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5302 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5303 Qget_mru_window, Qresize_root_window,
5304 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5305 Qauto_buffer_name; staticpro them.
f3d1777e 5306
abde8f8c
MR
53072011-06-07 Martin Rudalics <rudalics@gmx.at>
5308
5309 * window.c (Fwindow_total_size, Fwindow_left_column)
5310 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5311 (Fwindow_list_1): New functions.
5312 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5313 (Fwindow_width, Fscroll_left, Fscroll_right):
5314 Use window_body_cols instead of window_box_text_cols.
5315 (delete_window, Fset_window_configuration):
5316 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5317 (delete_all_subwindows): Take a window as argument and not a
5318 structure. Rewrite.
190b47e6
MR
5319 (window_loop): Remove handling of GET_LRU_WINDOW and
5320 GET_LARGEST_WINDOW.
5321 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5322
5323 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5324 window_box_text_cols. delete_all_subwindows now takes a
5325 Lisp_Object as argument.
abde8f8c 5326
640c8776
SM
5327 * indent.c (compute_motion, Fcompute_motion):
5328 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5329
fa8a67e6
MR
5330 * frame.c (delete_frame): Call delete_all_subwindows with root
5331 window as argument.
5332
a54e3482
DC
53332011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5334
5335 * fns.c (Fputhash): Document return value.
5336
60002bf5
CY
53372011-06-06 Chong Yidong <cyd@stupidchicken.com>
5338
5339 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5340
0c671da6 53412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5342
b862a52a 5343 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5344
be44ca6c
PE
5345 Check for overflow when converting integer to cons and back.
5346 * charset.c (Fdefine_charset_internal, Fdecode_char):
5347 Use cons_to_unsigned to catch overflow.
5348 (Fencode_char): Use INTEGER_TO_CONS.
5349 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5350 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5351 * data.c (long_to_cons, cons_to_long): Remove.
5352 (cons_to_unsigned, cons_to_signed): New functions.
5353 These signal an error for invalid or out-of-range values.
5354 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5355 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5356 * font.c (Ffont_variation_glyphs):
5357 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5358 * lisp.h: Include <intprops.h>.
5359 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5360 (cons_to_signed, cons_to_unsigned): New decls.
5361 (long_to_cons, cons_to_long): Remove decls.
5362 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5363 (Fprimitive_undo): Use CONS_TO_INTEGER.
5364 * xfns.c (Fx_window_property): Likewise.
5365 * xselect.c: Include <limits.h>.
5366 (x_own_selection, selection_data_to_lisp_data):
5367 Use INTEGER_TO_CONS.
5368 (x_handle_selection_request, x_handle_selection_clear)
5369 (x_get_foreign_selection, Fx_disown_selection_internal)
5370 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5371 (lisp_data_to_selection_data): Use cons_to_unsigned.
5372 (x_fill_property_data): Use cons_to_signed.
5373 Report values out of range.
5374
d1f3d2af
PE
5375 Check for buffer and string overflow more precisely.
5376 * buffer.h (BUF_BYTES_MAX): New macro.
5377 * lisp.h (STRING_BYTES_MAX): New macro.
5378 * alloc.c (Fmake_string):
5379 * character.c (string_escape_byte8):
5380 * coding.c (coding_alloc_by_realloc):
5381 * doprnt.c (doprnt):
5382 * editfns.c (Fformat):
5383 * eval.c (verror):
5384 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5385 since they may not be the same number.
5386 * editfns.c (Finsert_char):
5387 * fileio.c (Finsert_file_contents):
5388 Likewise for BUF_BYTES_MAX.
5389
dd52fcea
PE
5390 * image.c: Use ptrdiff_t, not int, for sizes.
5391 (slurp_file): Switch from int to ptrdiff_t.
5392 All uses changed.
5393 (slurp_file): Check that file size fits in both size_t (for
5394 malloc) and ptrdiff_t (for sanity and safety).
5395
7f9bbdbb
PE
5396 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5397 if b->modtime has its maximal value.
5398
dfe18f82
PE
5399 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5400
84acfcf0
PE
5401 Don't assume time_t can fit into int.
5402 * buffer.h (struct buffer.modtime): Now time_t, not int.
5403 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5404 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5405
ccd9a01a
PE
5406 Minor fixes for signed vs unsigned integers.
5407 * character.h (MAYBE_UNIFY_CHAR):
5408 * charset.c (maybe_unify_char):
5409 * keyboard.c (read_char, reorder_modifiers):
5410 XINT -> XFASTINT, since the integer must be nonnegative.
5411 * ftfont.c (ftfont_spec_pattern):
5412 * keymap.c (access_keymap, silly_event_symbol_error):
5413 XUINT -> XFASTINT, since the integer must be nonnegative.
5414 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5415 since it makes no difference and we prefer signed.
5416 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5417 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5418 nonnegative.
5419
d6d100dd
SM
54202011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5421
5422 * window.h (Fwindow_frame): Declare.
5423
2b6148e4
PE
54242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5425
5426 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5427 (SPARE_MEMORY): Always define.
5428 (LARGE_REQUEST): Remove.
5429 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5430
f230ecc9
MR
54312011-06-06 Martin Rudalics <rudalics@gmx.at>
5432
727e958e
MR
5433 * lisp.h: Move EXFUNS for Fframe_root_window,
5434 Fframe_first_window and Fset_frame_selected_window to window.h.
5435
5436 * window.h: Move EXFUNS for Fframe_root_window,
5437 Fframe_first_window and Fset_frame_selected_window here from
5438 lisp.h.
5439
5440 * frame.c (Fwindow_frame, Fframe_first_window)
5441 (Fframe_root_window, Fframe_selected_window)
5442 (Fset_frame_selected_window): Move to window.c.
5443 (Factive_minibuffer_window): Move to minibuf.c.
5444 (Fother_visible_frames_p): New function.
5445
5446 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5447
f230ecc9
MR
5448 * window.c (decode_window, decode_any_window): Move up in code.
5449 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5450 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5451 (Fwindow_buffer): Move up and rewrite doc-string.
5452 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5453 (Fwindow_prev): New functions.
727e958e
MR
5454 (Fwindow_frame): Move here from frame.c. Accept any window as
5455 argument.
5456 (Fframe_root_window, Fframe_first_window)
5457 (Fframe_selected_window): Move here from frame.c. Accept frame
5458 or arbitrary window as argument. Update doc-strings.
5459 (Fminibuffer_window): Move up in code.
5460 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5461 (Fset_frame_selected_window): Move here from frame.c.
5462 Marginal rewrite.
727e958e
MR
5463 (Fselected_window, select_window, Fselect_window): Move up in
5464 code. Minor doc-string fixes.
f230ecc9 5465
4d09bcf6
PE
54662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5467
5468 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5469 Do not assume that spare memory exists; that assumption is valid
5470 only if SYSTEM_MALLOC.
5471 (LARGE_REQUEST): New macro, so that the issue of large requests
5472 is separated from the issue of spare memory.
5473
810928a2
AS
54742011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5475
172418ad
AS
5476 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5477 format. (Bug#8806)
5478
43f862f7
AS
5479 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5480
810928a2
AS
5481 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5482 before statements.
5483
a059fe24
JD
54842011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5485
5486 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5487
5488 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5489
5490 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5491 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5492
989bf368
JB
54932011-06-05 Juanma Barranquero <lekktu@gmail.com>
5494
5495 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5496
4b80f674
CY
54972011-06-04 Chong Yidong <cyd@stupidchicken.com>
5498
5499 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5500 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5501 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5502 New error handlers.
4b80f674
CY
5503 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5504 Obey Vx_select_enable_clipboard_manager. Catch errors in
5505 x_clipboard_manager_save (Bug#8779).
5506 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5507 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5508
99a33b77 55092011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5510
5511 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5512
99a33b77 55132011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5514
5515 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5516 in the current matrix if keep_current_p is non-zero.
5517
8264569d
EZ
55182011-06-04 Eli Zaretskii <eliz@gnu.org>
5519
5520 * bidi.c (bidi_level_of_next_char): Fix last change.
5521
57f97249
EZ
55222011-06-03 Eli Zaretskii <eliz@gnu.org>
5523
fec2107c 5524 Support bidi reordering of text covered by display properties.
57f97249 5525
fec2107c
EZ
5526 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5527 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5528 (bidi_cache_search, bidi_cache_iterator_state)
5529 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5530 (bidi_level_of_next_char, bidi_move_to_visually_next):
5531 Support character positions inside a run of characters covered by a
fec2107c
EZ
5532 display string.
5533 (bidi_paragraph_init, bidi_resolve_explicit_1)
5534 (bidi_level_of_next_char): Call bidi_fetch_char and
5535 bidi_fetch_char_advance instead of FETCH_CHAR and
5536 FETCH_CHAR_ADVANCE.
5537 (bidi_init_it): Initialize new members.
5538 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5539 definitions.
5540 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5541 instead of using explicit *_CHAR codes.
d6d100dd
SM
5542 (bidi_resolve_explicit, bidi_resolve_weak):
5543 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5544 bidirectional text is supported only in multibyte buffers.
5545 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5546 it to initialize the frame_window_p member of struct bidi_it.
5547 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5548 (bidi_resolve_explicit, bidi_resolve_weak)
5549 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5550 bidi_it->nchars is non-positive.
5551 (bidi_level_of_next_char): Don't try to lookup the cache for the
5552 next/previous character if nothing is cached there yet, or if we
5553 were just reseat()'ed to a new position.
c40e2fb2 5554
0e14fe90
EZ
5555 * xdisp.c (set_cursor_from_row): Set start and stop points
5556 according to the row's direction when priming the loop that looks
5557 for the glyph on which to display cursor.
5558 (single_display_spec_intangible_p): Function deleted.
5559 (display_prop_intangible_p): Reimplement to call
5560 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5561 Accept 3 additional arguments needed by handle_display_spec.
5562 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5563 values: lists, `(when COND...)' forms, etc.
5564 (single_display_spec_string_p): Support property values that are
5565 lists with the argument STRING its top-level element.
5566 (display_prop_string_p): Fix the condition for processing a
5567 property that is a list to be consistent with handle_display_spec.
fec2107c 5568 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5569 last portion of handle_display_prop.
5570 (compute_display_string_pos): Accept additional argument
5571 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5572 value of a `display' property is a "replacing spec".
5573 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5574 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5575 the display property, but just return a value indicating whether
5576 the display property will replace the characters it covers.
5577 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5578 frame_window_p members of struct bidi_it.
d6d100dd
SM
5579 (compute_display_string_pos, compute_display_string_end):
5580 New functions.
fec2107c
EZ
5581 (push_it): Accept second argument POSITION, where pop_it should
5582 jump to continue iteration.
5583 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5584
fec2107c
EZ
5585 * keyboard.c (adjust_point_for_property): Adjust the call to
5586 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5587
5588 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5589 (bidi_init_it): Update prototypes.
5590 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5591 (compute_display_string_pos, compute_display_string_end):
5592 Declare prototypes.
fec2107c
EZ
5593 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5594 EMACS_INT.
fc6f18ce 5595
40087514 55962011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5597
57f53182
PE
5598 Malloc failure behavior now depends on size of allocation.
5599 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5600 * lisp.h: Change signatures accordingly.
5601 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5602 All callers changed. (Bug#8762)
5603
5604 * gnutls.c: Use Emacs's memory allocators.
5605 Without this change, the gnutls library would invoke malloc etc.
5606 directly, which causes problems on non-SYNC_INPUT hosts, and which
5607 runs afoul of improving memory_full behavior. (Bug#8761)
5608 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5609 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5610 xfree instead of the default malloc, realloc, free.
5611 (Fgnutls_boot): No need to check for memory allocation failure,
5612 since xmalloc does that for us.
5613
ac32cd99 5614 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5615 * category.c (hash_get_category_set):
5616 * ccl.c (ccl_driver):
5617 * charset.c (Fdefine_charset_internal):
5618 * charset.h (struct charset.hash_index):
5619 * composite.c (get_composition_id, gstring_lookup_cache)
5620 (composition_gstring_put_cache):
5621 * composite.h (struct composition.hash_index):
5622 * dispextern.h (struct image.hash):
5623 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5624 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5625 (hashfn_equal, hashfn_user_defined, make_hash_table)
5626 (maybe_resize_hash_table, hash_lookup, hash_put)
5627 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5628 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5629 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5630 * image.c (make_image, search_image_cache, lookup_image)
5631 (xpm_put_color_table_h):
5632 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5633 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5634 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5635 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5636 * alloc.c (allocate_vectorlike):
5637 Check for overflow in vector size calculations.
5638 * ccl.c (ccl_driver):
5639 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5640 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5641 need to be updated by these changes.
40087514
PE
5642 * fns.c (make_hash_table, maybe_resize_hash_table):
5643 Check for integer overflow with large hash tables.
0de4bb68
PE
5644 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5645 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5646 (SXHASH_REDUCE): New macro.
5647 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5648 Use it instead of discarding useful hash info with large hash values.
5649 (sxhash_float): New function.
5650 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5651 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5652 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5653 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5654 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5655 Adjust signatures to match updated version of code.
5656 (consing_since_gc): Now EMACS_INT, since a single hash table can
5657 use more than INT_MAX bytes.
5658
698d32e2
DN
56592011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5660
5661 Make it possible to build with GCC-4.6+ -O2 -flto.
5662
5663 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5664
fd6fa53f
SM
56652011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5666
5667 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5668 Call minibuffer-inactive-mode.
5669
864db017
JB
56702011-05-31 Juanma Barranquero <lekktu@gmail.com>
5671
5672 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5673 Update dependencies.
5674
2ad0baf4
DN
56752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5676
5677 * data.c (init_data): Remove code for UTS, this system is not
5678 supported anymore.
5679
4fcc2638
DN
56802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5681
5682 Don't force ./temacs to start in terminal mode.
5683
5684 * frame.c (make_initial_frame): Initialize faces in all cases, not
5685 only when CANNOT_DUMP is defined.
5686 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5687
c56e0fd5
DN
56882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5689
5690 * dispnew.c (add_window_display_history): Use const for the string
5691 pointer. Remove declaration, not needed.
5692
333d54da 56932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5694
55d4c1b2 5695 Use 'inline', not 'INLINE'.
333d54da 5696 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5697 * alloc.c, fontset.c (INLINE): Remove.
5698 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5699 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5700 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5701 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5702 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5703
738db178
DN
57042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5705
5706 Make it possible to run ./temacs.
5707
5708 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5709 syms_of_callproc does the same thing. Remove test for
5710 "initialized", do it in the caller.
5711 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5712
620c53a6
SM
57132011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5714
5715 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5716 (read_minibuf): Use get_minibuffer.
5717 (syms_of_minibuf): Use DEFSYM.
5718 (Qmetadata): New var.
5719 * data.c (Qbuffer): Don't make it static.
5720 (syms_of_data): Use DEFSYM.
5721
e003a292
PE
57222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5725 (CCL_CODE_MIN): New macro.
5726
ed008a6d
PE
57272011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5728
3687c2ef
PE
5729 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5730
ed008a6d
PE
5731 * eval.c (Qdebug): Now static.
5732 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5733 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5734 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5735
d66c4c7c
CY
57362011-05-29 Chong Yidong <cyd@stupidchicken.com>
5737
5738 * image.c: Various fixes to ImageMagick code comments.
5739 (Fimagemagick_types): Doc fix.
5740
5fbc2025
PE
57412011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5742
0196f88a
PE
5743 Minor fixes prompted by GCC 4.6.0 warnings.
5744
5745 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5746
5fbc2025
PE
5747 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5748 (x_clipboard_manager_save_all): Move extern decl to ...
5749 * xterm.h: ... here, so that it can be checked for consistency.
5750
1dd3c2d9
CY
57512011-05-29 Chong Yidong <cyd@stupidchicken.com>
5752
5753 * xselect.c (x_clipboard_manager_save_frame)
5754 (x_clipboard_manager_save_all): New functions.
5755 (Fx_clipboard_manager_save): Lisp function deleted.
5756
5757 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5758 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5759
5760 * xterm.h: Update prototype.
5761
5ba6571d
WX
57622011-05-28 William Xu <william.xwl@gmail.com>
5763
5764 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5765 exiting (Bug#8239).
5766
3eaff834
JM
57672011-05-28 Jim Meyering <meyering@redhat.com>
5768
e1900994 5769 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5770 * fns.c (to_uchar): Define.
5771 (crypto_hash_function): Use it to convert some newly-signed
5772 variables to unsigned, to avoid sign-extension bugs. For example,
5773 without this change, (md5 "truc") would evaluate to
5774 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5775 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5776 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5777
0f6990a7
PE
57782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5779
5780 Integer overflow fixes.
c8a9ca5a 5781
08686060
PE
5782 * dbusbind.c: Serial number integer overflow fixes.
5783 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5784 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5785 to hold a serial number that is too large for a fixnum.
5786 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5787 Check for serial numbers out of range. Decode any serial number
59568bf0 5788 that was so large that it became a float. (Bug#8722)
08686060 5789
2d1fc3c7
PE
5790 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5791 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5792 Use XFASTINT rather than XUINT when numbers are nonnegative.
5793 (xd_append_arg, Fdbus_method_return_internal):
5794 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5795 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5796 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5797 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5798 (Bug#8722)
2d1fc3c7 5799
c8a9ca5a
PE
5800 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5801
519e1d69
PE
5802 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5803
6df6ae42 5804 ccl: Add integer overflow checks.
30569699
PE
5805 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5806 (IN_INT_RANGE): New macros.
5807 (ccl_driver): Use them to check for integer overflow when
5808 decoding a CCL program. Many of the new checks are whether XINT (x)
5809 fits in int; it doesn't always, on 64-bit hosts. The new version
5810 doesn't catch all possible integer overflows, but it's an
847044ea 5811 improvement. (Bug#8719)
30569699 5812
c11285dc
PE
5813 * alloc.c (make_event_array): Use XINT, not XUINT.
5814 There's no need for unsigned here.
5815
fdccd48e
PE
5816 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5817 This follows up to the 2011-05-06 change that substituted uintptr_t
5818 for EMACS_INT. This case wasn't caught back then.
5819
37910ab2
PE
5820 Rework Fformat to avoid integer overflow issues.
5821 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5822 now (part of C89). Include <verify.h>.
5823 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5824 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5825 (Fformat): Avoid the prepass trying to compute sizes; it was only
5826 approximate and thus did not catch overflow reliably. Instead, walk
5827 through the format just once, formatting and computing sizes as we go,
5828 checking for integer overflow at every step, and allocating a larger
5829 buffer as needed. Keep track separately whether the format is
5830 multibyte. Keep only the most-recently calculated precision, rather
5831 than them all. Record whether each argument has been converted to
5832 string. Use EMACS_INT, not int, for byte and char and arg counts.
5833 Support field widths and precisions larger than INT_MAX. Avoid
5834 sprintf's undefined behavior with conversion specifications such as %#d
5835 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5836 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5837 formatting out-of-range floating point numbers with int
9173deec 5838 formats. (Bug#8668)
37910ab2 5839
2e6578fb
PE
5840 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5841
0ae6bdee
PE
5842 * data.c: Avoid integer truncation in expressions involving floats.
5843 * data.c: Include <intprops.h>.
5844 (arith_driver): When there's an integer overflow in an expression
5845 involving floating point, convert the integers to floating point
5846 so that the resulting value does not suffer from catastrophic
5847 integer truncation. For example, on a 64-bit host (* 4
5848 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5849 Do not rely on undefined behavior after integer overflow.
5850
de883a70
PE
5851 merge count_size_as_multibyte, parse_str_to_multibyte
5852 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5853 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5854 Check for integer overflow.
5855 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5856 since it's now a duplicate of the other. This is more of
5857 a character than a buffer op, so better that it's in character.c.
5858 * fns.c, print.c: Adjust to above changes.
5859
2ff916cb
PE
58602011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5861
5862 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5863
f1b54466
PE
58642011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5865
fb1ac845
PE
5866 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5867 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5868 (x_clipboard_manager_save): Now static.
5869 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5870
f1b54466
PE
5871 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5872 (crypto_hash_function): Now static.
5873 Fix pointer signedness problems. Avoid unnecessary initializations.
5874
a9f737ee
CY
58752011-05-27 Chong Yidong <cyd@stupidchicken.com>
5876
5877 * termhooks.h (Vselection_alist): Make it terminal-local.
5878
5879 * terminal.c (create_terminal): Initialize it.
5880
5881 * xselect.c: Support for clipboard managers.
5882 (Vselection_alist): Move to termhooks.h as terminal-local var.
5883 (LOCAL_SELECTION): New macro.
5884 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5885 (symbol_to_x_atom): Remove gratuitous arg.
5886 (x_handle_selection_request, lisp_data_to_selection_data)
5887 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5888 (x_own_selection, x_get_local_selection, x_convert_selection):
5889 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5890 (some_frame_on_display): Delete unused function.
5891 (Fx_own_selection_internal, Fx_get_selection_internal)
5892 (Fx_disown_selection_internal, Fx_selection_owner_p)
5893 (Fx_selection_exists_p): New optional frame arg.
5894 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5895 (x_handle_selection_clear): Don't treat other terminals with the
5896 same keyboard specially. Use the terminal-local Vselection_alist.
5897 (x_clear_frame_selections): Use Frun_hook_with_args.
5898
5899 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5900
5901 * xterm.h: Add support for those atoms.
5902
e067f0c1
CY
59032011-05-26 Chong Yidong <cyd@stupidchicken.com>
5904
5905 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5906 (converted_selections, conversion_fail_tag): New global variables.
5907 (x_selection_request_lisp_error): Free the above.
5908 (x_get_local_selection): Remove unnecessary code.
5909 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5910 of converted selections stored in converted_selections.
5911 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5912 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5913 (x_convert_selection): New function.
5914 (x_handle_selection_event): Simplify.
5915 (x_get_foreign_selection): Don't ignore incoming requests while
5916 waiting for an answer; this will fail when we implement
5917 SAVE_TARGETS, and seems unnecessary anyway.
5918 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5919 (Vx_sent_selection_functions): Doc fix.
5920
0f4aebc0
LL
59212011-05-26 Leo Liu <sdl.web@gmail.com>
5922
5923 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5924
e61124cd
YM
59252011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5926
5927 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5928
5929 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5930 for fringe update if it has periodic bitmap.
ac389d0c 5931 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5932 and fringe_bitmap_periodic_p.
5933
5934 * fringe.c (get_fringe_bitmap_data): New function.
5935 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5936 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5937 row. Mark glyph row for fringe update if periodicity changed.
5938
5939 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5940 for fringe update unless it has periodic bitmap.
5941
f16d9837
KH
59422011-05-25 Kenichi Handa <handa@m17n.org>
5943
5944 * xdisp.c (get_next_display_element): Set correct it->face_id for
5945 a static composition.
5946
e1b90ef6
LL
59472011-05-24 Leo Liu <sdl.web@gmail.com>
5948
5949 * deps.mk (fns.o):
5950 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5951
5952 * fns.c (crypto_hash_function, Fsha1): New function.
5953 (Fmd5): Use crypto_hash_function.
5954 (syms_of_fns): Add Ssha1.
5955
7400048f
PE
59562011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5957
5958 * gnutls.c: Remove unused macros.
5959 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5960 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5961 Remove macros that are defined and never used.
5962 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5963
abb71cf4
CY
59642011-05-22 Chong Yidong <cyd@stupidchicken.com>
5965
5966 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5967 (Fx_get_selection_internal): Minor cleanup.
5968 (Fx_own_selection_internal): Rename arguments for consistency with
5969 select.el.
5970
6307db39
PE
59712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5972
5973 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5974
f3d4e0a4
CY
59752011-05-22 Chong Yidong <cyd@stupidchicken.com>
5976
5977 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5978
4d8ade89
YM
59792011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5980
5981 * dispnew.c (scrolling_window): Don't exclude the case that the
5982 last enabled row in the desired matrix touches the bottom boundary.
5983
32078c8d
GM
59842011-05-21 Glenn Morris <rgm@gnu.org>
5985
5986 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5987 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5988 and add some more files.
32078c8d 5989
7285dc67
EZ
59902011-05-20 Eli Zaretskii <eliz@gnu.org>
5991
5992 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5993 report_file_error introduced by the change from 2011-05-07.
5994
89d1bd22
PE
59952011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5996
5997 * systime.h (Time): Define only if emacs is defined.
5998 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5999 where the include path doesn't have X11/X.h by default. See
6000 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6001
cd394be1 60022011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6003
6004 * composite.c (find_automatic_composition): Fix previous change.
6005
b9704ad9
GM
60062011-05-20 Glenn Morris <rgm@gnu.org>
6007
6008 * lisp.mk: New file, split from Makefile.in.
6009 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6010 (shortlisp): Remove.
6011 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6012
4a720484
GM
60132011-05-19 Glenn Morris <rgm@gnu.org>
6014
6015 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6016 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6017 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6018 (lisp): Set the order to that of loadup.el.
6019 (shortlisp): Make it a copy of $lisp.
6020 (SOME_MACHINE_LISP): Remove.
6021 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6022 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6023
a28d4396
KH
60242011-05-18 Kenichi Handa <handa@m17n.org>
6025
6026 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6027 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6028 (find_automatic_composition): Mostly rewrite for efficiency.
6029
a2b1fa8e
JB
60302011-05-18 Juanma Barranquero <lekktu@gmail.com>
6031
6032 * makefile.w32-in: Update dependencies.
6033
8e1f5610
CS
60342011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6035
6036 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6037 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6038
7025ee00 60392011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6040
cdfa6eab
PE
6041 Fix some integer overflow issues, such as string length overflow.
6042
06d6db33
PE
6043 * insdel.c (count_size_as_multibyte): Check for string overflow.
6044
2b4560a8
PE
6045 * character.c (lisp_string_width): Check for string overflow.
6046 Use EMACS_INT, not int, for string indexes and lengths; in
6047 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6048 the resulting string length overflows an EMACS_INT; instead,
6049 report a string overflow if no precision given. When checking for
6050 precision exhaustion, use a check that cannot possibly have
6051 integer overflow. (Bug#8675)
6052 * character.h (lisp_string_width): Adjust to new signature.
6053
cb93f9be
PE
6054 * alloc.c (string_overflow): New function.
6055 (Fmake_string): Use it. This doesn't change behavior, but saves
6056 a few bytes and will simplify future changes.
6057 * character.c (string_escape_byte8): Likewise.
6058 * lisp.h (string_overflow): New decl.
6059
1a1f3366
PE
6060 Fixups, following up to the user-interface timestamp change.
6061 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6062 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6063 * msdos.c (mouse_get_pos): Likewise.
6064 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6065 * w32gui.h (Time): Define by including "systime.h" rather than by
6066 declaring it ourselves. (Bug#8664)
6067
d4e3e4d3
PE
6068 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6069 * image.c (clear_image_cache): Likewise.
6070
f6a24d19
PE
6071 * term.c (term_mouse_position): Don't assume time_t wraparound.
6072
08dc5ae6
PE
6073 Be more systematic about user-interface timestamps.
6074 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6075 and sometimes 'EMACS_UINT', to represent these timestamps.
6076 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6077 This makes the code easier to follow, and makes it easier to catch
6078 integer overflow bugs such as Bug#8664.
6079 * frame.c (Fmouse_position, Fmouse_pixel_position):
6080 Use Time, not unsigned long, for user-interface timestamps.
6081 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6082 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6083 * keyboard.h (last_event_timestamp): Likewise.
6084 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6085 * menu.h (xmenu_show): Likewise.
6086 * term.c (term_mouse_position): Likewise.
6087 * termhooks.h (struct input_event.timestamp): Likewise.
6088 (struct terminal.mouse_position_hook): Likewise.
6089 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6090 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6091 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6092 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6093 what it was before.
6094 * menu.h, termhooks.h: Include "systime.h", for Time.
6095
8e55734a
PE
6096 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6097 Don't assume that the difference between two unsigned long values
6098 can fit into an integer. At this point, we know button_down_time
6099 <= event->timestamp, so the difference must be nonnegative, so
6100 there's no need to cast the result if double-click-time is
6101 nonnegative, as it should be; check that it's nonnegative, just in
6102 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6103 apart (about 25 days). (Bug#8664)
8e55734a 6104
841f1b75 6105 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6106 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6107
3e26f69c
PE
6108 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6109 that always fit in int. Use a sentinel instead of a counter, to
6110 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6111 * frame.h (struct frame): Use int for menu_bar_items_used
6112 instead of EMACS_INT, since it always fits in int.
3e26f69c 6113
5cc152c0
PE
6114 * menu.c (grow_menu_items): Check for int overflow.
6115
d89eb65e
PE
6116 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6117
5235bd3e
PE
6118 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6119 Before, the code was not consistent. These values cannot exceed
6120 2**31 - 1 so there's no need to make them unsigned.
6121 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6122 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6123 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6124 as modifiers.
6125 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6126
bc827e23
PE
6127 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6128 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6129 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6130 presumably because the widths might not match.
6131
78eb494e
PE
6132 * window.c (size_window): Avoid needless test at loop start.
6133
04f2d78b
CB
61342011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6135
6136 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6137
d2fc7e3d 61382011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6139
6140 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6141
d2fc7e3d 61422011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6143
6144 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6145 `width' to `bar_area_x' and `bar_area_width', respectively.
6146 (x_scroll_run): Take account of fringe background extension.
6147
04f2d78b
CB
6148 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6149 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6150 `bar_area_width', respectively.
6151 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6152 background extension.
6153
79b70037
GM
61542011-05-10 Jim Meyering <meyering@redhat.com>
6155
6156 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6157
2f142cc5
JB
61582011-05-10 Juanma Barranquero <lekktu@gmail.com>
6159
6160 * image.c (Finit_image_library): Return t for built-in image types,
6161 like pbm and xbm. (Bug#8640)
6162
57679c86
AS
61632011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6164
6165 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6166
888c9e86
EZ
61672011-05-07 Eli Zaretskii <eliz@gnu.org>
6168
b0512a1d
EZ
6169 * w32console.c (Fset_screen_color): Doc fix.
6170 (Fget_screen_color): New function.
6171 (syms_of_ntterm): Defsubr it.
6172
7285dc67
EZ
6173 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6174 unlink the temporary file if Fcall_process didn't create it in the
6175 first place.
6176 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6177 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6178 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6179 cue to call_process_cleanup not to close that handle.
6180
4d3fcc8e
BK
61812011-05-07 Ben Key <bkey76@gmail.com>
6182
6183 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6184 one of two shell specific rules, either bootstrap-temacs-CMD or
6185 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6186 to the previous implementation of the bootstrap-temacs rule.
6187 The bootstrap-temacs-CMD rule is similar to the previous
6188 implementation of the bootstrap-temacs rule except that it
6189 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6190 variable.
6191
6192 These changes, along with some changes to nt/configure.bat,
6193 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6194 earlier fix to add support for --cflags and --ldflags options
6195 that include quotes so that it works whether make uses cmd or
6196 sh as the shell.
6197
b4289b64
MA
61982011-05-06 Michael Albinus <michael.albinus@gmx.de>
6199
6200 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6201 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6202 is a constant.
6203 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6204 a string. Handle both cases.
6205 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6206 (Fdbus_register_method): Use Qinvalid_function.
6207
af4c0e28
JB
62082011-05-06 Juanma Barranquero <lekktu@gmail.com>
6209
6210 * makefile.w32-in: Update dependencies.
6211 (LISP_H): Add inttypes.h and stdin.h.
6212 (PROCESS_H): Add unistd.h.
6213
c51453d9
EZ
62142011-05-06 Eli Zaretskii <eliz@gnu.org>
6215
6216 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6217 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6218
8ff0ac3c 62192011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6220
4c4b566b
PE
6221 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6222
aab2b9b5
PE
6223 * term.c (vfatal): Remove stray call to va_end.
6224 It's not needed and the C Standard doesn't allow it here anyway.
6225
c378da0b
PE
6226 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6227 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6228
288b08c7
PE
6229 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6230 bytes.
6231
e3601888
PE
6232 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6233
db6c0e74
PE
6234 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6235
dd5963ea
PE
6236 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6237
88c9450f
PE
6238 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6239
2f9442b8
PE
6240 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6241
c032b5f8
PE
6242 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6243 * charset.c (Fdefine_charset_internal): Don't initialize
6244 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6245 32-bit int (Bug#8600).
a108c10b
PE
6246
6247 * lread.c (read_integer): Be more consistent with string-to-number.
6248 Use string_to_number to do the actual conversion; this avoids
6249 rounding errors and fixes some other screwups. Without this fix,
6250 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6251 (digit_to_number): Move earlier, for benefit of read_integer.
6252 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6253 not a digit in any supported base. (Bug#8602)
a108c10b 6254
ad5f9eea
PE
6255 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6256
aec1708a
PE
6257 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6258 to match comment at start of function. This also removes a
6259 GCC warning about overflow in a 32+64-bit port.
6260
47be4ab5
PE
6261 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6262
371cac43
PE
6263 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6264 Reported by Stefan Monnier in
6265 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6266 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6267 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6268
d01a7826
PE
6269 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6270 (EMACS_UINTPTR): Likewise, with uintptr_t.
6271
7fd47d5c
PE
6272 * lisp.h: Prefer 64-bit EMACS_INT if available.
6273 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6274 on 32-bit hosts that have 64-bit int, so that they can access
6275 large files.
122b0c86
PE
6276 However, temporarily disable this change unless the temporary
6277 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6278
8727937b
PE
6279 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6280
8ac068ac
PE
6281 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6282 This removes an assumption that EMACS_INT and long are the same
6283 width as pointers. The assumption is true for Emacs porting targets
6284 now, but we want to make other targets possible.
6285 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6286 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6287 In the rest of the code, change types of integers that hold casted
6288 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6289 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6290 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6291 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6292 No need to cast type when ORing.
6293 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6294 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6295 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6296 assume EMACS_INT is the same width as char *.
6297 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6298 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6299 Remove no-longer-needed casts.
6300 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6301 (xg_tool_bar_help_callback, xg_make_tool_item):
6302 Use EMACS_INTPTR to hold an integer
6303 that will be cast to void *; this can avoid a GCC warning
6304 if EMACS_INT is not the same width as void *.
6305 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6306 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6307 (current_message_1, set_message_1):
6308 Use a local to convert to proper width without a cast.
6309 * xmenu.c (dialog_selection_callback): Likewise.
6310
ede49d71
PE
6311 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6312 Also, don't assume VALBITS / RAND_BITS is less than 5,
6313 and don't rely on undefined behavior when shifting a 1 left into
6314 the sign bit.
6315 * lisp.h (get_random): Change signature to match.
6316
2f30ecd0
PE
6317 * lread.c (hash_string): Use size_t, not int, for hash computation.
6318 Normally we prefer signed values; but hashing is special, because
6319 it's better to use unsigned division on hash table sizes so that
6320 the remainder is nonnegative. Also, size_t is the natural width
6321 for hashing into memory. The previous code used 'int', which doesn't
6322 retain enough info to hash well into very large tables.
6323 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6324
2a866e7b
PE
6325 * dbusbind.c: Don't possibly lose pointer info when converting.
6326 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6327 Use XPNTR rather than XHASH, so that the high-order bits of
6328 the pointer aren't lost when converting through void *.
6329
51639eac
PE
6330 * eval.c (Fautoload): Don't double-shift a pointer.
6331
92394119
PE
6332 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6333
dbdb9a7c
JB
63342011-05-06 Juanma Barranquero <lekktu@gmail.com>
6335
6336 * gnutls.c (DEF_GNUTLS_FN):
6337 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6338
db7a0b4f
AS
63392011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6340
6341 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6342 marker. (Bug#8610)
6343
cd394be1 63442011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6345
6346 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6347 New version that can reserve upto 2GB of heap space.
6348
f7ff1b0f 63492011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6350
6351 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6352
639c109b
TZ
63532011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6354
6355 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6356 `gnutls_certificate_set_x509_key_file'.
6357
d2127135
JB
63582011-05-05 Juanma Barranquero <lekktu@gmail.com>
6359
6360 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6361 Update dependencies.
6362
e968f4f3
JB
63632011-05-04 Juanma Barranquero <lekktu@gmail.com>
6364
6365 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6366 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6367 Remove unused parameter `fildes'.
6368 * process.c (read_process_output, send_process): Don't pass it.
6369
84d358f0
JB
63702011-05-04 Juanma Barranquero <lekktu@gmail.com>
6371
6372 Fix previous change: the library cache is defined in w32.c.
6373 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6374 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6375
0898ca10
JB
63762011-05-04 Juanma Barranquero <lekktu@gmail.com>
6377
6378 Implement dynamic loading of GnuTLS on Windows.
6379
6380 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6381 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6382 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6383 Declare.
6384
6385 * gnutls.c (Qgnutls_dll): Define.
6386 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6387 (gnutls_*): Declare function pointers.
6388 (init_gnutls_functions): New function to initialize function pointers.
6389 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6390 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6391 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6392 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6393 (emacs_gnutls_write, emacs_gnutls_read)
6394 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6395 (Fgnutls_available_p): New function.
6396 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6397 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6398 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6399
6400 * image.c: Include w32.h.
6401 (Vimage_type_cache): Delete.
6402 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6403 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6404 (w32_delayed_load): Move to w32.c.
6405
6406 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6407
6408 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6409 (w32_delayed_load): Move from image.c. When loading a library, record
6410 its filename in the :loaded-from property of the library id.
6411 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6412 Initialize and staticpro them.
6413 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6414
6415 * process.c: Include lisp.h before w32.h, not after.
6416 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6417 instead of gnutls_record_check_pending.
6418
6419 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6420
ff4de4aa
TZ
64212011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6422
6423 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6424 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6425 as passed in.
6426
abe95abb
JD
64272011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6428
6429 * xterm.c (x_set_frame_alpha): Do not set property on anything
6430 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6431
e16e55d4
JB
64322011-05-02 Juanma Barranquero <lekktu@gmail.com>
6433
6434 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6435
bafcf6a5
JB
64362011-05-02 Juanma Barranquero <lekktu@gmail.com>
6437
6438 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6439 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6440 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6441 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6442 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6443 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6444 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6445 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6446 (Qgnutls_bootprop_callbacks_verify): Make static.
6447
e7a6747f
AS
64482011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6449
19ed11ba
AS
6450 * callproc.c: Indentation fixup.
6451
e7a6747f 6452 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6453 (wait_for_termination, interruptible_wait_for_termination):
6454 Move after wait_for_termination_1.
e7a6747f 6455
1ef14cb4
LMI
64562011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6457
6458 * sysdep.c (interruptible_wait_for_termination): New function
6459 which is like wait_for_termination, but allows keyboard
6460 interruptions.
6461
6462 * callproc.c (Fcall_process): Add (:file "file") as an option for
6463 the STDOUT buffer.
6464 (Fcall_process_region): Ditto.
6465
330d880c
EZ
64662011-04-30 Eli Zaretskii <eliz@gnu.org>
6467
8db90b73
EZ
6468 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6469 rather than `XVECTOR (FOO)->size'.
6470
330d880c
EZ
6471 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6472 inttypes.h, as a gnulib replacement is used if it not available in
6473 system headers.
6474
15cbd324
EZ
64752011-04-21 Eli Zaretskii <eliz@gnu.org>
6476
6477 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6478 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6479 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6480
6481 * coding.c (coding_alloc_by_realloc): Error out if destination
6482 will grow beyond MOST_POSITIVE_FIXNUM.
6483 (decode_coding_emacs_mule): Abort if there isn't enough place in
6484 charbuf for the composition carryover bytes. Reserve an extra
6485 space for up to 2 characters produced in a loop.
6486 (decode_coding_iso_2022): Abort if there isn't enough place in
6487 charbuf for the composition carryover bytes.
6488
64892011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6490
ae940cca
EZ
6491 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6492 aborting when %lld or %lll format is passed.
6493 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6494 %llo or %llx format is passed. (Bug#8545)
6495
03ab8921
EZ
6496 * window.c (window_scroll_line_based): Use a marker instead of
6497 simple variables to record original value of point. (Bug#7952)
6498
afda1437
EZ
6499 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6500 produced by %s or %c overflows available buffer space. (Bug#8545)
6501
f76dee0c
PE
65022011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6503
6504 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6505 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6506
fdc5744d
JB
65072011-04-28 Juanma Barranquero <lekktu@gmail.com>
6508
6509 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6510
638f053a
JB
65112011-04-28 Juanma Barranquero <lekktu@gmail.com>
6512
6513 * keyboard.c (Qdelayed_warnings_hook): Define.
6514 (command_loop_1): Run `delayed-warnings-hook'
6515 if Vdelayed_warnings_list is non-nil.
6516 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6517 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6518
d178f871
EZ
65192011-04-28 Eli Zaretskii <eliz@gnu.org>
6520
6521 * doprnt.c (doprnt): Don't return value smaller than the buffer
6522 size if the message was truncated. (Bug#8545).
6523
b124fd93
JB
65242011-04-28 Juanma Barranquero <lekktu@gmail.com>
6525
6526 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6527 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6528
e810457d
PE
65292011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6530
6531 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6532
ea51cceb
JB
65332011-04-27 Juanma Barranquero <lekktu@gmail.com>
6534
6535 * makefile.w32-in: Update dependencies.
6536
94dcfacf
EZ
65372011-04-27 Eli Zaretskii <eliz@gnu.org>
6538
6539 Improve `doprnt' and its usage. (Bug#8545)
6540 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6541 `format_end'. Remove support for %l as a conversion specifier.
6542 Don't use xrealloc. Improve diagnostics when the %l size modifier
6543 is used. Update the commentary.
6544
6545 * eval.c (verror): Simplify calculation of size_t.
6546
6547 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6548 messages.
6549
f61f41d7
PE
65502011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6551
6552 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6553 change.
6554
96fb4434
PE
65552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6556
6557 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6558 This makes this file independent of the recent pseudovector change.
6559
671875da 65602011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6561
69e9b5a3
PE
6562 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6563
b5f869a7 6564 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6565 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6566 Remove unused local.
c8926152 6567 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6568
841a1577 6569 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6570 GCC 4.6.0 optimizes based on type-based alias analysis.
6571 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6572 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6573 != &v->size, and therefore "v->size = 1; b->size = 2; return
6574 v->size;" must therefore return 1. This assumption is incorrect
6575 for Emacs, since it type-puns struct Lisp_Vector * with many other
6576 types. To fix this problem, this patch adds a new type struct
f904488f 6577 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6578 and pseudovectors, and helps optimizing compilers not get fooled
6579 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6580 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6581 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6582 the size member.
eab3844f
PE
6583 (XSETPVECTYPE): Rewrite in terms of new macro.
6584 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6585 This is a bit clearer, and further avoids the possibility of
6586 undesirable aliasing.
6587 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6588 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6589 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6590 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6591 (ASIZE): Now uses header.size rather than size.
6592 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6593 to avoid the hassle of writing XVECTOR (foo)->header.size.
6594 (struct vectorlike_header): New type.
eab3844f
PE
6595 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6596 object, to help avoid aliasing.
6597 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6598 (SUBRP): Likewise, since Lisp_Subr is a special case.
6599 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6600 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6601 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6602 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6603 changed to be "header.size" and "header.next".
6604 * buffer.h (struct buffer): Likewise.
6605 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6606 * frame.h (struct frame): Likewise.
6607 * process.h (struct Lisp_Process): Likewise.
6608 * termhooks.h (struct terminal): Likewise.
6609 * window.c (struct save_window_data, struct saved_window): Likewise.
6610 * window.h (struct window): Likewise.
6611 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6612 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6613 * buffer.c (init_buffer_once): Likewise.
6614 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6615 special case.
6616 * process.c (Fformat_network_address): Use local var for size,
6617 for brevity.
6618
0df1eac5
PE
6619 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6620
847ab9d1 6621 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6622 * data.c (atof): Remove decl; no longer used or needed.
6623 (digit_to_number): Move to lread.c.
6624 (Fstring_to_number): Use new string_to_number function, to be
6625 consistent with how the Lisp reader treats infinities and NaNs.
6626 Do not assume that floating-point numbers represent EMACS_INT
6627 without losing information; this is not true on most 64-bit hosts.
6628 Avoid double-rounding errors, by insisting on integers when
6629 parsing non-base-10 numbers, as the documentation specifies.
6630 * lisp.h (string_to_number): New decl, replacing ...
6631 (isfloat_string): Remove.
bc0a5c13 6632 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6633 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6634 appears to have been a coding error. Similarly, do not accept
6635 strings like +-1e0 as floating point numbers. Do not report
6636 overflow for integer overflows unless the base is not 10 which
6637 means we have no simple and reliable way to continue.
6638 Break out the floating-point parsing into a new
6639 function string_to_number, so that Fstring_to_number parses
6640 floating point numbers consistently with the Lisp reader.
04f2d78b 6641 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6642 (E_CHAR, EXP_INT): Remove, replacing with ...
6643 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6644 (string_to_number): New function, replacing isfloat_string.
6645 This function checks for valid syntax and produces the resulting
6646 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6647 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6648 so that overflow for non-base-10 numbers is reported only when
6649 there's no portable and simple way to convert to floating point.
452f4150 6650
67769ffc
PE
6651 * textprop.c (set_text_properties_1): Rewrite for clarity,
6652 and to avoid GCC warning about integer overflow.
6653
c20db43f
PE
6654 * intervals.h (struct interval): Use EMACS_INT for members
6655 where EMACS_UINT might cause problems. See
6656 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6657 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6658 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6659 All uses changed.
37aa2f85
PE
6660 (offset_intervals): Tell GCC not to worry about length overflow
6661 when negating a negative length.
c20db43f 6662
2538aa2f
PE
6663 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6664 (overrun_check_free): Likewise.
6665
f2d3008d
PE
6666 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6667 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6668 word size.
6669
ec8df744
PE
6670 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6671 (gnutls_make_error): Rename local to avoid shadowing.
6672 (gnutls_emacs_global_deinit): ifdef out; not used.
6673 (Fgnutls_boot): Use const for pointer to readonly storage.
6674 Comment out unused local. Fix pointer signedness problems.
6675
640ee02d
PE
6676 * lread.c (openp): Don't stuff size_t into an 'int'.
6677 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6678 about possible signed overflow.
6679
6048fb2a
PE
6680 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6681 (GDK_KEY_g): Don't define if already defined.
6682 (xg_prepare_tooltip): Avoid pointer signedness problem.
6683 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6684
fa3c87e1
PE
6685 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6686 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6687
2172544b
PE
6688 * xfns.c (Fx_window_property): Simplify a bit,
6689 to make a bit faster and to avoid GCC 4.6.0 warning.
6690 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6691
9b821a21
PE
6692 * fns.c (internal_equal): Don't assume size_t fits in int.
6693
3c616cfa
PE
6694 * alloc.c (compact_small_strings): Tighten assertion a little.
6695
c2982e87
PE
6696 Replace pEd with more-general pI, and fix some printf arg casts.
6697 * lisp.h (pI): New macro, generalizing old pEd macro to other
6698 conversion specifiers. For example, use "...%"pI"d..." rather
6699 than "...%"pEd"...".
6700 (pEd): Remove. All uses replaced with similar uses of pI.
6701 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6702 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6703 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6704 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6705 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6706 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6707 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6708 64-bit hosts.
6709 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6710 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6711 * print.c (safe_debug_print, print_object): Likewise.
6712 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6713 to int.
6f04d126
PE
6714 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6715 avoiding the 0 flag, which is not portable.
c2982e87
PE
6716 * process.c (Fmake_network_process): Use pI to avoid cast.
6717 * region-cache.c (pp_cache): Likewise.
6718 * xdisp.c (decode_mode_spec): Likewise.
6719 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6720 behavior on 64-bit hosts with printf arg.
6f04d126 6721 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6722 (x_stop_queuing_selection_requests): Likewise.
6723 (x_get_window_property): Don't truncate byte count to an 'int'
6724 when tracing.
0b432f21 6725
5e073ec7
PE
6726 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6727 here, since it parses constructs like leading '-' and spaces,
6728 which are not wanted; and it overflows with large numbers.
6729 Instead, simply match F[0-9]+, which is what is wanted anyway.
6730
36372bf9
PE
6731 * alloc.c: Remove unportable assumptions about struct layout.
6732 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6733 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6734 (allocate_vectorlike, make_pure_vector): Use the new macros,
6735 plus offsetof, to remove unportable assumptions about struct layout.
6736 These assumptions hold on all porting targets that I know of, but
6737 they are not guaranteed, they're easy to remove, and removing them
6738 makes further changes easier.
6739
0b432f21
PE
6740 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6741 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6742 (string_overrun_cookie): Now const. Use initializers that
6743 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6744 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6745 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6746 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6747 multiple of sizeof (EMACS_INT); it need not be, if
6748 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6749 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6750
895009e1
JB
67512011-04-26 Juanma Barranquero <lekktu@gmail.com>
6752
6753 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6754
6a7a1b0b
TZ
67552011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6756
6757 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6758 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6759 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6760
841a1577 67612011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6762
6763 * lisp.h (Qdebug): List symbol.
895009e1 6764 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6765 * keyboard.c (debug-on-event): New variable.
6766 (handle_user_signal): Break into debugger when debug-on-event
6767 matches the current signal symbol.
6768
f2d3ba6f
DN
67692011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6770
6771 * alloc.c (check_sblock, check_string_bytes)
6772 (check_string_free_list): Convert to standard C.
6773
42ce4c63
TZ
67742011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6775
6776 * w32.c (emacs_gnutls_push): Fix typo.
6777
825cd63c
EZ
67782011-04-25 Eli Zaretskii <eliz@gnu.org>
6779
fb11d64d
EZ
6780 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6781 "cast to pointer from integer of different size".
6782
825cd63c
EZ
6783 Improve doprnt and its use in verror. (Bug#8545)
6784 * doprnt.c (doprnt): Document the set of format control sequences
6785 supported by the function. Use SAFE_ALLOCA instead of always
6786 using `alloca'.
6787
6788 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6789 is one byte too soon. Don't use xrealloc; instead xfree and
6790 xmalloc anew.
6791
e061a11b
TZ
67922011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6793
6794 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6795 callbacks stage.
6796
6797 * gnutls.c: Renamed global_initialized to
6798 gnutls_global_initialized. Added internals for the
6799 :verify-hostname-error, :verify-error, and :verify-flags
6800 parameters of `gnutls-boot' and documented those parameters in the
6801 docstring. Start callback support.
9173deec
JB
6802 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6803 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6804 on error. Return error code.
e061a11b
TZ
6805 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6806 (emacs_gnutls_read): Likewise.
6807 (Fgnutls_boot): Return handshake error code.
6808 (emacs_gnutls_handle_error): New function.
6809 (wsaerror_to_errno): Likewise.
6810
6811 * w32.h (emacs_gnutls_pull): Add prototype.
6812 (emacs_gnutls_push): Likewise.
6813
6814 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6815 (emacs_gnutls_push): Likewise.
6816
68172011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6818
6819 * process.c (wait_reading_process_output): Check if GnuTLS
6820 buffered some data internally if no FDs are set for TLS
6821 connections.
6822
6823 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6824 (LIBS): Link to USER_LIBS.
6825 ($(BLD)/gnutls.$(0)): New target.
6826
fa6996bc
EZ
68272011-04-24 Eli Zaretskii <eliz@gnu.org>
6828
eb35682e
EZ
6829 * xdisp.c (handle_single_display_spec): Rename the
6830 display_replaced_before_p argument into display_replaced_p, to
6831 make it consistent with the commentary. Fix typos in the
6832 commentary.
6833
e2ad650c
EZ
6834 * textprop.c (syms_of_textprop): Remove dead code.
6835 (copy_text_properties): Delete obsolete commentary about an
6836 interface that was deleted long ago. Fix typos in the description
6837 of arguments.
6838
1b2de274
EZ
6839 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6840 to changes in oldXMenu/XMenu.h from 2011-04-16.
6841 <menu_help_message, prev_menu_help_message>: Constify.
6842 (IT_menu_make_room): menu->help_text is now `const char **';
6843 adjust.
6844
6845 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6846 to changes in oldXMenu/XMenu.h from 2011-04-16.
6847 (struct XMenu): Declare `help_text' `const char **'.
6848
6849 * xfaces.c <Qunspecified>: Make extern again.
6850
6851 * syntax.c: Include sys/types.h before including regex.h, as
6852 required by Posix.
6853
762b15be
EZ
6854 * doc.c (get_doc_string): Improve the format passed to `error'.
6855
6856 * doprnt.c (doprnt): Improve commentary.
6857
6858 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6859
6860 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6861 them with etags.
6862
f1052e5d
EZ
6863 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6864 changes in globals.h immediately force recompilation.
762b15be
EZ
6865 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6866 $(CURDIR)/s/ms-w32.h.
6867 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6868
fa6996bc
EZ
6869 * character.c (Fchar_direction): Function deleted.
6870 (syms_of_character): Don't defsubr it.
6871 <char-direction-table>: Deleted.
6872
e6c3da20
EZ
68732011-04-23 Eli Zaretskii <eliz@gnu.org>
6874
6875 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6876 * doprnt.c: Include limits.h.
6877 (SIZE_MAX): New macro.
04f2d78b
CB
6878 (doprnt): Return a size_t value. 2nd arg is now size_t.
6879 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6880 Improve overflow protection. Support `l' modifier for integer
6881 conversions. Support %l conversion. Don't assume an EMACS_INT
6882 argument for integer conversions and for %c.
6883
6884 * lisp.h (doprnt): Restore prototype.
6885
6886 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6887 $(SRC)/character.h.
6888
6889 * Makefile.in (base_obj): Add back doprnt.o.
6890
6891 * deps.mk (doprnt.o): Add back prerequisites.
6892 (callint.o): Depend on character.h.
6893
6894 * eval.c (internal_lisp_condition_case): Include the handler
6895 representation in the error message.
6896 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6897 when breaking from the loop.
6898
6899 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6900
6901 * callint.c (Fcall_interactively): When displaying error message
6902 about invalid control letter, pass the character's codepoint, not
6903 a pointer to its multibyte form. Improve display of the character
6904 in octal and display also its hex code.
6905
6906 * character.c (char_string): Use %x to display the (unsigned)
6907 codepoint of an invalid character, to avoid displaying a bogus
6908 negative value.
6909
6910 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6911 `error', not SYMBOL_NAME itself.
6912
6913 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6914 character arguments to `error'.
6915
6916 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6917 to `error' in error message about FINAL_CHAR argument. Make sure
6918 FINAL_CHAR is a character, and use %c when it is passed as
6919 argument to `error'.
6920
4ffd0d6b 69212011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6922
6923 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6924
6925 * w32.c: Include <time.h>.
6926 (sys_localtime): New function.
6927
4ffd0d6b 69282011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6929
6930 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6931
4ffd0d6b 6932 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6933
4ffd0d6b 69342011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6935
4ffd0d6b
GM
6936 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6937 zombies (Bug#8467).
aac0c6e3 6938
04c56954
EZ
69392011-04-19 Eli Zaretskii <eliz@gnu.org>
6940
6941 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6942 gl_state.e_property when gl_state.object is Qt.
6943
6944 * insdel.c (make_gap_larger): Remove limitation of buffer size
6945 to <= INT_MAX.
6946
16a43933
CY
69472011-04-18 Chong Yidong <cyd@stupidchicken.com>
6948
6949 * xdisp.c (lookup_glyphless_char_display)
6950 (produce_glyphless_glyph): Handle cons cell entry in
6951 glyphless-char-display.
6952 (Vglyphless_char_display): Document it.
6953
6954 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6955 glyphless-char-display.
6956
4581706e
CY
69572011-04-17 Chong Yidong <cyd@stupidchicken.com>
6958
6959 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6960
6961 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6962
6963 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6964 definition for no-X builds.
6965
4887c6e2 69662011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6967
fd35b6f9
PE
6968 Static checks with GCC 4.6.0 and non-default toolkits.
6969
5c1ccb01
PE
6970 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6971
006c5daa
PE
6972 * process.c (keyboard_bit_set): Define only if SIGIO.
6973 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6974 (send_process): Repair possible setjmp clobbering.
6975
efc736d3
PE
6976 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6977
4e2fe2e6
PE
6978 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6979
f97334a2
PE
6980 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6981
4e75f29d
PE
6982 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6983 Define only if needed.
6984
90efadd1
PE
6985 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6986 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6987 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6988
3c647824
PE
6989 * dispextern.h (struct redisplay_interface): Rename param
6990 to avoid shadowing.
e264f262 6991 * termhooks.h (struct terminal): Likewise.
761383f4 6992 * xterm.c (xembed_send_message): Likewise.
3c647824 6993
b58c5c4a
PE
6994 * insdel.c (make_gap_smaller): Define only if
6995 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6996
cad59032
PE
6997 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6998 it.
6999
c339dc2e
PE
7000 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7001 so that we aren't warned about unused symbols.
7002
91a3e27b
PE
7003 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7004
399c71d3 7005 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7006
8ffc96f5
PE
7007 * xfns.c (x_real_positions): Mark locals as initialized.
7008
eef9bc79
PE
7009 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7010
098db9dd
PE
7011 * xterm.c: Fix problems found by static analysis with other toolkits.
7012 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7013 (x_dispatch_event): Declare static if USE_GTK, and
7014 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7015 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7016 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7017 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7018 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7019
eb18f6cc
PE
7020 * xmenu.c (menu_help_callback): Pointer type fixes.
7021 Use const pointers when pointing at readonly data. Avoid pointer
7022 signedness clashes.
7023 (FALSE): Remove unused macro.
7024 (update_frame_menubar): Remove unused decl.
7025
1fe72bf8
PE
7026 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7027
60d9e1db
PE
7028 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7029 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7030 (single_menu_item): Rename local to avoid shadowing.
7031
39261c26
PE
7032 * keyboard.c (make_lispy_event): Remove unused local var.
7033
018c5e19
PE
7034 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7035 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7036
63d2b86e
PE
7037 * bitmaps: Change bitmaps from unsigned char back to the X11
7038 compatible char. Avoid the old compiler warnings about
7039 out-of-range initializers by using, for example, '\xab' rather
7040 than 0xab.
7041
aefd87e1
PE
7042 * xgselect.c (xgselect_initialize): Check vs interface
7043 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7044
bf501fb9
PE
7045 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7046
e9829fdf
PE
7047 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7048 to read-only memory.
7049
1086c095
PE
7050 * fns.c (vector): Remove; this old hack is no longer needed.
7051
2baccd04 7052 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7053 Remove unused var.
dde42981 7054 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7055
72391843 7056 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7057
436c16df 7058 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7059 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7060 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7061
92bb796d 7062 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7063 (x_term_init): Remove local to avoid shadowing.
92bb796d 7064
764430a3 7065 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7066
7067 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7068 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7069
d1dfb56c
EZ
70702011-04-16 Eli Zaretskii <eliz@gnu.org>
7071
c4354cb4
EZ
7072 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7073
d1dfb56c
EZ
7074 Fix regex.c, syntax.c and friends for buffers > 2GB.
7075 * syntax.h (struct gl_state_s): Declare character position members
7076 EMACS_INT.
7077
7078 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7079
04f2d78b
CB
7080 * textprop.c (verify_interval_modification, interval_of):
7081 Declare arguments EMACS_INT.
d1dfb56c
EZ
7082
7083 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7084 EMACS_INT.
7085
7086 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7087
7088 * indent.c (Fvertical_motion): Local variable it_start is now
7089 EMACS_INT.
7090
7091 * regex.c (re_match, re_match_2, re_match_2_internal)
7092 (bcmp_translate, regcomp, regexec, print_double_string)
7093 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7094 (re_compile_pattern, re_exec): Declare arguments and local
7095 variables `size_t' and `ssize_t' and return values `regoff_t', as
7096 appropriate.
7097 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7098 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7099 <compile_stack_type>: `size' and `avail' are now `size_t'.
7100
7101 * regex.h <regoff_t>: Use ssize_t, not int.
7102 (re_search, re_search_2, re_match, re_match_2): Arguments that
7103 specify buffer/string position and length are now ssize_t and
7104 size_t. Return type is regoff_t.
7105
613052cd
BK
71062011-04-16 Ben Key <bkey76@gmail.com>
7107
7108 * nsfont.m: Fixed bugs in ns_get_family and
7109 ns_descriptor_to_entity that were caused by using free to
7110 deallocate memory blocks that were allocated by xmalloc (via
7111 xstrdup). This caused Emacs to crash when compiled with
7112 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7113 --enable-checking=xmallocoverrun). xfree is now used to
7114 deallocate these memory blocks.
7115
4170f62f 71162011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7117
71b41406
PE
7118 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7119
9587a89d
PE
7120 emacs_write: Accept and return EMACS_INT for sizes.
7121 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7122 et seq.
7123 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7124 Accept and return EMACS_INT.
7125 (emacs_gnutls_write): Return the number of bytes written on
7126 partial writes.
7127 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7128 (emacs_read, emacs_write): Remove check for negative size, as the
7129 Emacs source code has been audited now.
9587a89d
PE
7130 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7131 (emacs_read, emacs_write): Use it.
273a5f82
PE
7132 * process.c (send_process): Adjust to the new signatures of
7133 emacs_write and emacs_gnutls_write. Do not attempt to store
7134 a byte offset into an 'int'; it might overflow.
9587a89d 7135 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7136
3e047f51
PE
7137 * sound.c: Don't assume sizes fit in 'int'.
7138 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7139 Return EMACS_INT, not int.
3e047f51 7140 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7141 Accept EMACS_INT, not int.
7142 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7143 record read return values.
7144
cc39a9db
BK
71452011-04-15 Ben Key <bkey76@gmail.com>
7146
c9d0ec6d
JB
7147 * keyboard.c (Qundefined): Don't declare static since it is used
7148 in nsfns.m.
7149 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7150 static since they are used in nsfont.m.
cc39a9db 7151
6c60eb9f
SM
71522011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7153
7154 * process.c (Qprocessp): Don't declare static.
7155 * lisp.h (Qprocessp): Declare again.
7156
7990b61a
JB
71572011-04-15 Juanma Barranquero <lekktu@gmail.com>
7158
7159 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7160
5d4cb038
PE
71612011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7162
8bd7b830 7163 Improve C-level modularity by making more things 'static'.
cd64ea1d 7164
e3b27b31
PE
7165 Don't publish debugger-only interfaces to other modules.
7166 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7167 (verify_bytepos, count_markers): Move decls to the only modules
7168 that need them.
7169 * region-cache.h (pp_cache): Likewise.
7170 * window.h (check_all_windows): Likewise.
7171 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7172
5d4cb038
PE
7173 * sysdep.c (croak): Now static, if
7174 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7175 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7176
7177 * alloc.c (refill_memory_reserve): Now static if
7178 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7179 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7180
e87b6180
PE
7181 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7182 Define only if USE_LUCID.
7183
ac64929e
PE
7184 * xrdb.c (x_customization_string, x_rm_string): Now static.
7185
6f37259d
PE
7186 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7187 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7188
1683e3ab
PE
7189 * xdisp.c (draw_row_with_mouse_face): Now static.
7190 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7191
de9c2632
PE
7192 * window.h (check_all_windows): Mark externally visible.
7193
2b96acb7
PE
7194 * window.c (window_deletion_count): Now static.
7195
7196 * undo.c: Make symbols static if they're not exported.
7197 (last_undo_buffer, last_boundary_position, pending_boundary):
7198 Now static.
7199
50436f33
PE
7200 * textprop.c (interval_insert_behind_hooks): Now static.
7201 (interval_insert_in_front_hooks): Likewise.
7202
64520e5c
PE
7203 * term.c: Make symbols static if they're not exported.
7204 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7205 (max_frame_lines, tty_set_terminal_modes):
7206 (tty_reset_terminal_modes, tty_turn_off_highlight):
7207 (get_tty_terminal): Now static.
7208 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7209 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7210 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7211 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7212 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7213
1fa53021
PE
7214 * sysdep.c: Make symbols static if they're not exported.
7215 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7216 Now static.
7217 (sigprocmask_set, full_mask): Remove; unused.
7218 (wait_debugging): Mark as visible.
7219 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7220 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7221
d4b43b22
PE
7222 * syntax.c (syntax_temp): Define only if !__GNUC__.
7223
b7c513d0
PE
7224 * sound.c (current_sound_device, current_sound): Now static.
7225
989b29ad
PE
7226 * search.c (searchbufs, searchbuf_head): Now static.
7227
13a55a78
PE
7228 * scroll.c (scroll_cost): Remove; unused.
7229 * dispextern.h (scroll_cost): Remove decl.
7230
de68a1fc
PE
7231 * region-cache.h (pp_cache): Mark as externally visible.
7232
40ccffa6
PE
7233 * process.c: Make symbols static if they're not exported.
7234 (process_tick, update_tick, create_process, chan_process):
7235 (Vprocess_alist, proc_buffered_char, datagram_access):
7236 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7237 (deactivate_process): Mark defn as static, as well as decl.
7238 * lisp.h (create_process): Remove decl.
7239 * process.h (chan_process, Vprocess_alist): Remove decls.
7240
ad64fc97
PE
7241 * print.c: Make symbols static if they're not exported.
7242 (print_depth, new_backquote_output, being_printed, print_buffer):
7243 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7244 (print_interval, print_number_index, initial_stderr_stream):
7245 Now static.
7246 * lisp.h (Fprinc): Remove decl.
7247 (debug_output_compilation_hack): Mark as externally visible.
7248
adddb265
PE
7249 * sysdep.c (croak): Move decl from here to syssignal.h.
7250 * syssignal.h (croak): Put it here, so the API can be checked when
7251 'croak' is called from dissociate_if_controlling_tty.
7252
1717ede2
PE
7253 * minibuf.c: Make symbols static if they're not exported.
7254 (minibuf_save_list, choose_minibuf_frame): Now static.
7255 * lisp.h (choose_minibuf_frame): Remove decl.
7256
fa5fb2bc
PE
7257 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7258
1e3890d1
PE
7259 * lread.c: Make symbols static if they're not exported.
7260 (read_objects, initial_obarray, oblookup_last_bucket_number):
7261 Now static.
7262 (make_symbol): Remove; unused.
7263 * lisp.h (initial_obarray, make_symbol): Remove decls.
7264
8a1414fa
PE
7265 * keyboard.c: Make symbols static if they're not exported.
7266 (single_kboard, recent_keys_index, total_keys, recent_keys):
7267 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7268 (this_single_command_key_start, echoing, last_auto_save):
7269 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7270 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7271 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7272 (Vlispy_mouse_stem, double_click_count):
7273 Now static.
7274 (force_auto_save_soon): Define only if SIGDANGER.
7275 (ignore_mouse_drag_p): Now static if
7276 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7277 (print_help): Remove; unused.
7278 (stop_character, last_timer_event): Mark as externally visible.
7279 * keyboard.h (ignore_mouse_drag_p): Declare only if
7280 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7281 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7282 * lisp.h (echoing): Remove decl.
7283 (force_auto_save_soon): Declare only if SIGDANGER.
7284 * xdisp.c (redisplay_window): Simplify code, to make it more
7285 obvious that ignore_mouse_drag_p is not accessed if !defined
7286 USE_GTK && !defined HAVE_NS.
7287
93ea6e8f
PE
7288 * intervals.c: Make symbols static if they're not exported.
7289 (merge_properties_sticky, merge_interval_right, delete_interval):
7290 Now static.
7291 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7292
77382fcc
PE
7293 * insdel.c: Make symbols static if they're not exported.
7294 However, leave prepare_to_modify_buffer alone. It's never
7295 called from outside this function, but that appears to be a bug.
7296 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7297 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7298 (adjust_after_replace_noundo): Remove; unused.
7299 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7300 (signal_before_change): Remove decls.
77382fcc 7301
9306c32e
PE
7302 * indent.c (val_compute_motion, val_vmotion): Now static.
7303
cd44d2eb
PE
7304 * image.c: Make symbols static if they're not exported.
7305 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7306 if USE_GTK.
7307 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7308 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7309
ad9a7a06
PE
7310 * fringe.c (standard_bitmaps): Now static.
7311 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7312
81626931
PE
7313 * frame.c: Make symbols static if they're not exported.
7314 (x_report_frame_params, make_terminal_frame): Now static.
7315 (get_frame_param): Now static, unless HAVE_NS.
7316 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7317 (x_get_resource_string): Remove; not used.
7318 * frame.h (make_terminal_frame, x_report_frame_params):
7319 (x_get_resource_string); Remove decls.
7320 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7321 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7322
239f9db9
PE
7323 * font.c, fontset.c: Make symbols static if they're not exported.
7324 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7325 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7326 * font.c (font_close_object): Now static.
7327 * font.h (font_close_object): Remove.
7328 * fontset.c (FONTSET_OBJLIST): Remove.
7329 (free_realized_fontset) #if-0 the body, which does nothing.
7330 (face_suitable_for_char_p): #if-0, as it's never called.
7331 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7332 * xfaces.c (face_at_string_position):
7333 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7334 since 0 is always ASCII.
7335
dfcf3579
PE
7336 * fns.c (weak_hash_tables): Now static.
7337
5045092b
PE
7338 * fileio.c: Make symbols static if they're not exported.
7339 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7340 (Vwrite_region_annotation_buffers): Now static.
7341
57a96f5c
PE
7342 * eval.c: Make symbols static if they're not exported.
7343 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7344 * lisp.h (backtrace_list): Remove decl.
7345
35f08c38
PE
7346 * emacs.c: Make symbols static if they're not exported.
7347 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7348 (fatal_error_code, fatal_error_signal_hook, standard_args):
7349 Now static.
7350 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7351 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7352 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7353 * lisp.h (fatal_error_signal_hook): Remove decl.
7354 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7355
f44bd759
PE
7356 * editfns.c: Move a (normally-unused) function to its only use.
7357 * editfns.c, lisp.h (get_operating_system_release): Remove.
7358 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7359 worth the hassle of breaking this out.
7360
b532497d
PE
7361 * xterm.c: Make symbols static if they're not exported.
7362 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7363 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7364 (x_destroy_window, x_delete_display):
7365 Now static.
7366 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7367 (x_mouse_leave): Remove; unused.
7368 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7369 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7370 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7371 Remove decls.
7372 (x_mouse_leave): Declare only if WINDOWSNT.
7373 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7374 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7375 USE_X_TOOLKIT.
7376
1675728f
PE
7377 * ftxfont.c: Make symbols static if they're not exported.
7378 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7379 HAVE_FREETYPE.
7380 * font.h (ftxfont_driver): Likewise.
7381
e4cebfca
PE
7382 * xfns.c: Make symbols static if they're not exported.
7383 (x_last_font_name, x_display_info_for_name):
7384 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7385 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7386 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7387 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7388 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7389 (last_show_tip_args): Now static.
7390 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7391 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7392 (x_screen_planes): Remove; unused.
7393 * dispextern.h (x_screen_planes): Remove decl.
7394
5bf46f05
PE
7395 * dispnew.c: Make symbols static if they're not exported.
7396 * dispextern.h (redraw_garbaged_frames, scrolling):
7397 (increment_row_positions): Remove.
7398 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7399 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7400 Now static.
7401 (redraw_garbaged_frames): Remove; unused.
7402
435f4c28
PE
7403 * xfaces.c: Make symbols static if they're not exported.
7404 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7405 Remove decls.
7406 * xterm.h (defined_color): Remove decls.
7407 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7408 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7409 (menu_face_changed_default, defined_color, free_realized_face):
7410 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7411 (ascii_face_of_lisp_face): Remove; unused.
7412
8524aef3
PE
7413 * xdisp.c: Make symbols static if they're not exported.
7414 * dispextern.h (scratch_glyph_row, window_box_edges):
7415 (glyph_to_pixel_coords, set_cursor_from_row):
7416 (get_next_display_element, set_iterator_to_next):
7417 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7418 (show_mouse_face): Remove decls
7419 * frame.h (message_buf_print): Likewise.
7420 * lisp.h (pop_message, set_message, check_point_in_composition):
7421 Likewise.
7422 * xterm.h (set_vertical_scroll_bar): Likewise.
7423 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7424 (message_buf_print, scratch_glyph_row, displayed_buffer):
7425 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7426 (get_next_display_element, show_mouse_face, window_box_edges):
7427 (frame_to_window_pixel_xy, check_point_in_composition):
7428 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7429 (glyph_to_pixel_coords): Remove; unused.
7430
16390cd2
PE
7431 * dired.c (file_name_completion): Now static.
7432
7433 * dbusbind.c (xd_in_read_queued_messages): Now static.
7434
a25f4dfa
PE
7435 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7436 * data.c (circular_list_error): Remove.
7437
14a9c8df
PE
7438 * commands.h (last_point_position, last_point_position_buffer):
7439 (last_point_position_window): Remove decls.
7440 * keyboard.c: Make these variables static.
7441
04f2d78b
CB
7442 * coding.h (coding, code_convert_region, encode_coding_gap):
7443 Remove decls.
74ab6df5
PE
7444 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7445 (iso_code_class, detect_coding, code_convert_region): Now static.
7446 (encode_coding_gap): Remove; unused.
7447
38dfbee1
PE
7448 * chartab.c (chartab_chars, chartab_bits): Now static.
7449
a2cb4e63
PE
7450 * charset.h (charset_iso_8859_1): Remove decl.
7451 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7452 Now static.
7453
127198fd
PE
7454 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7455 * ccl.c (Vccl_program_table): Now static.
7456 (check_ccl_update): Remove; unused.
7457
d85b608f
PE
7458 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7459 * category.h: ... from here.
7460 * category.c (check_category_table, set_category_set): Now static.
7461
31cd66f3
PE
7462 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7463 * lisp.h: Remove these decls.
7464
c358e587
PE
7465 * buffer.c (buffer_count): Remove unused var.
7466
e78aecca
PE
7467 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7468 so that it's not optimized away.
7469 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7470 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7471 exported only to the debugger.
7472
e192d7d3 7473 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7474 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7475
92470028
PE
7476 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7477 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7478 was inaccessible from Lisp.
7479 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7480 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7481
244ed907
PE
7482 alloc.c: Import and export fewer symbols, and remove unused items.
7483 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7484 is defined.
7485 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7486 it's not optimized away by whole-program optimization.
7487 (message_enable_multibyte, free_misc): Remove.
7488 (catchlist, handlerlist, mark_backtrace):
7489 Declare only if BYTE_MARK_STACK.
7490 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7491 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7492 (message_enable_multibyte): Remove decl.
7493 (free_misc, interval_free_list, float_block, float_block_index):
7494 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7495 (cons_free_list, last_marked_index):
7496 Now static.
7497 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7498 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7499 (mark_backtrace): Define only if BYTE_MARK_STACK.
7500 * xdisp.c (message_enable_multibyte): Now static.
7501
61c2b50e 7502 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7503 This makes it easier for human readers (and static analyzers)
7504 to see whether these variables are used from other modules.
7505 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7506 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7507 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7508 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7509 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7510 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7511 * xmenu.c, xselect.c:
7512 Declare Q* vars static if they are not used in other modules.
7513 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7514 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7515 Remove decls of unexported vars.
7516 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7517
95c82688
PE
7518 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7519
16a97296
PE
7520 Make Emacs functions such as Fatom 'static' by default.
7521 This makes it easier for human readers (and static analyzers)
7522 to see whether these functions can be called from other modules.
7523 DEFUN now defines a static function. To make the function external
7524 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7525 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7526 (Finit_image_library):
16a97296
PE
7527 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7528 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7529 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7530 Remove decls, since these functions are now static.
7531 (Funintern, Fget_internal_run_time): New decls, since these functions
7532 were already external.
95c82688 7533
16a97296
PE
7534 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7535 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7536 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7537 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7538 * keyboard.c, keymap.c, lread.c:
7539 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7540 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7541 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7542 Mark functions with DEFUE instead of DEFUN,
7543 if they are used in other modules.
7544 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7545 decls for now-static functions.
7546 * buffer.h (Fdelete_overlay): Remove decl.
7547 * callproc.c (Fgetenv_internal): Mark as internal.
7548 * composite.c (Fremove_list_of_text_properties): Remove decl.
7549 (Fcomposition_get_gstring): New forward static decl.
7550 * composite.h (Fcomposite_get_gstring): Remove decl.
7551 * dired.c (Ffile_attributes): New forward static decl.
7552 * doc.c (Fdocumntation_property): New forward static decl.
7553 * eval.c (Ffetch_bytecode): New forward static decl.
7554 (Funintern): Remove extern decl; now in .h file where it belongs.
7555 * fileio.c (Fmake_symbolic_link): New forward static decl.
7556 * image.c (Finit_image_library): New forward static decl.
7557 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7558 * intervals.h (Fprevious_property_change):
7559 (Fremove_list_of_text_properties): Remove decls.
7560 * keyboard.c (Fthis_command_keys): Remove decl.
7561 (Fcommand_execute): New forward static decl.
7562 * keymap.c (Flookup_key): New forward static decl.
7563 (Fcopy_keymap): Now static.
7564 * keymap.h (Flookup_key): Remove decl.
7565 * process.c (Fget_process): New forward static decl.
7566 (Fprocess_datagram_address): Mark as internal.
7567 * syntax.c (Fsyntax_table_p): New forward static decl.
7568 (skip_chars): Remove duplicate decl.
7569 * textprop.c (Fprevious_property_change): New forward static decl.
7570 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7571 Now internal.
7572 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7573 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7574
785bbd42
PE
7575 * editfns.c (Fformat): Remove unreachable code.
7576
8b913b57
AS
75772011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7578
7579 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7580 change. (Bug#8496)
7581
a6744a35
EZ
75822011-04-13 Eli Zaretskii <eliz@gnu.org>
7583
7584 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7585 when at ZV. (Bug#8487)
7586
e7974947
AS
75872011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7588
baad03f0
AS
7589 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7590 (Bug#8437)
7591 * keyboard.c (parse_tool_bar_item): Likewise.
7592 * sound.c (sound_cleanup, alsa_close): Likewise.
7593 * termcap.c (tgetent): Likewise.
7594 * xfns.c (x_default_font_parameter): Likewise.
7595 * xsettings.c (read_and_apply_settings): Likewise.
7596
e7974947
AS
7597 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7598 (overrun_check_free): Protoize.
7599
28272684
PE
76002011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7601
7602 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7603 since callers should never pass a negative size.
7604 Change the signature to match that of plain 'read' and 'write'; see
7605 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7606 * lisp.h: Update prototypes of emacs_write and emacs_read.
7607
11997c76
EZ
76082011-04-11 Eli Zaretskii <eliz@gnu.org>
7609
7610 * xdisp.c (redisplay_window): Don't try to determine the character
7611 position of the scroll margin if the window start point w->startp
e896f03c 7612 is outside the buffer's accessible region. (Bug#8468)
11997c76 7613
8a2cbd72
EZ
76142011-04-10 Eli Zaretskii <eliz@gnu.org>
7615
7616 Fix write-region and its subroutines for buffers > 2GB.
7617 * fileio.c (a_write, e_write): Modify declaration of arguments and
7618 local variables to support buffers larger than 2GB.
7619 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7620
7621 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7622 argument, local variables, and return value.
7623
7624 * lisp.h: Update prototypes of emacs_write and emacs_read.
7625
7626 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7627
4073e537 76282011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7629
1ebfdcb6
PE
7630 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7631
b2ded58d
PE
7632 Fix more problems found by GCC 4.6.0's static checks.
7633
7d66342c
PE
7634 * xdisp.c (vmessage): Use a better test for character truncation.
7635
bbf47d44
PE
7636 * charset.c (load_charset_map): <, not <=, for optimization,
7637 and to avoid potential problems with integer overflow.
9248994d 7638 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7639 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7640 * editfns.c (Fformat): Likewise.
1e69125e 7641 * syntax.c (skip_chars): Likewise.
3befa583 7642
e3019616
PE
7643 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7644 This also lets GCC 4.6.0 generate slightly better loop code.
7645
becfa255
PE
7646 * callint.c (Fcall_interactively): <, not <=, for optimization.
7647 (Fcall_interactively): Count the number of arguments produced,
7648 not the number of arguments given. This is simpler and lets GCC
7649 4.6.0 generate slightly better code.
7650
dae0cd48
PE
7651 * ftfont.c: Distingish more carefully between FcChar8 and char.
7652 The previous code passed unsigned char * to a functions like
7653 strlen and xstrcasecmp that expect char *, which does not
7654 conform to the C standard.
7655 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7656 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7657 char * when the C standard requires it.
7658
76032d70
PE
7659 * keyboard.c (read_char): Remove unused var.
7660
eb3f1cc8
PE
7661 * eval.c: Port to Windows vsnprintf (Bug#8435).
7662 Include <limits.h>.
7663 (SIZE_MAX): Define if the headers do not.
7664 (verror): Do not give up if vsnprintf returns a negative count.
7665 Instead, grow the buffer. This ports to Windows vsnprintf, which
7666 does not conform to C99. Problem reported by Eli Zaretskii.
7667 Also, simplify the allocation scheme, by avoiding the need for
7668 calling realloc, and removing the ALLOCATED variable.
7669
70476b54
PE
7670 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7671
12020a9e
PE
7672 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7673 But keep the doprint source code for now, as we might revamp it
7674 and use it again (Bug#8435).
ea6c7ae6
PE
7675 * lisp.h (doprnt): Remove.
7676 * Makefile.in (base_obj): Remove doprnt.o.
7677 * deps.mk (doprnt.o): Remove.
7678
5fdb398c
PE
7679 error: Print 32- and 64-bit integers portably (Bug#8435).
7680 Without this change, on typical 64-bit hosts error ("...%d...", N)
7681 was used to print both 32- and 64-bit integers N, which relied on
7682 undefined behavior.
7683 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7684 New macro.
7685 * lisp.h (error, verror): Mark as printf-like functions.
7686 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7687 Report overflow in size calculations when allocating printf buffer.
7688 Do not truncate output string at its first null byte.
7689 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7690 Truncate the output at a character boundary, since vsnprintf does not
7691 do that.
7692 * charset.c (check_iso_charset_parameter): Convert internal
7693 character to string before calling 'error', since %c now has the
7694 printf meaning.
7695 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7696 overflow when computing char to be passed to 'error'. Do not
7697 pass Lisp_Object to 'error'; pass the integer instead.
7698 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7699 formatted with plain %d.
7700
b189fa66
PE
7701 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7702
bff87ef0
PE
7703 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7704
7e2cac20
PE
7705 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7706
ce4d90b5
PE
7707 * xterm.c (x_catch_errors): Remove duplicate declaration.
7708
266c9547
PE
7709 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7710
79c49ad2
PE
7711 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7712
368f4090
JM
77132011-04-10 Jim Meyering <meyering@redhat.com>
7714
7715 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7716 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7717 return ssize_t not "int", and use size_t as the buffer length.
7718 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7719 * gnutls.h: Update declarations.
7720 * process.c (read_process_output): Use ssize_t, to match.
7721 (send_process): Likewise.
7722
a32d4040
CY
77232011-04-09 Chong Yidong <cyd@stupidchicken.com>
7724
7725 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7726
8546720e 77272011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7728
04f2d78b
CB
7729 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7730 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7731
8546720e
GM
7732 * xterm.c (handle_one_xevent):
7733 * xmenu.c (create_and_show_popup_menu):
7734 * xselect.c (x_decline_selection_request)
7735 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7736
0a2f5c1a 77372011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7738
7739 Fix some uses of `int' instead of EMACS_INT.
7740 * search.c (string_match_1, fast_string_match)
7741 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7742 (scan_buffer, find_next_newline_no_quit)
7743 (find_before_next_newline, search_command, Freplace_match)
7744 (Fmatch_data): Make some `int' variables be EMACS_INT.
7745
7746 * xdisp.c (display_count_lines): 3rd argument and return value now
7747 EMACS_INT. All callers changed.
7748 (pint2hrstr): Last argument is now EMACS_INT.
7749
7750 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7751 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7752 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7753 (decode_coding_utf_16, decode_coding_emacs_mule)
7754 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7755 (decode_coding_ccl, decode_coding_charset)
7756 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7757 (decode_coding_iso_2022, decode_coding_emacs_mule)
7758 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7759 <char_offset, last_offset>: Declare EMACS_INT.
7760 (encode_coding_utf_8, encode_coding_utf_16)
7761 (encode_coding_emacs_mule, encode_invocation_designation)
7762 (encode_designation_at_bol, encode_coding_iso_2022)
7763 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7764 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7765 Declare EMACS_INT.
7766 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7767 (encode_invocation_designation): Last argument P_NCHARS is now
7768 EMACS_INT.
7769 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7770 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7771
7772 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7773 All users changed.
7774
7775 * ccl.c (Fccl_execute_on_string): Declare some variables
7776 EMACS_INT.
7777
8546720e 77782011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7779
7780 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7781
4e19a977
CS
77822011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7783
7784 * process.c (Fformat_network_address): Doc fix.
7785
87302331
R
77862011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7787
ee7683eb 7788 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7789
cbb59342
CY
77902011-04-08 Chong Yidong <cyd@stupidchicken.com>
7791
7792 * keyboard.c (read_char): Call Lisp function help-form-show,
7793 instead of using internal_with_output_to_temp_buffer.
7794 (Qhelp_form_show): New var.
e0d38eeb 7795 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7796
7797 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7798
7799 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7800
e67a13ab
CY
78012011-04-06 Chong Yidong <cyd@stupidchicken.com>
7802
04f2d78b
CB
7803 * process.c (Flist_processes): Remove to Lisp.
7804 (list_processes_1): Delete.
e67a13ab 7805
973f782d
EZ
78062011-04-06 Eli Zaretskii <eliz@gnu.org>
7807
7c106b1e
EZ
7808 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7809
973f782d
EZ
7810 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7811
41cf7d1a 78122011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7813
ca23cc88
PE
7814 Fix more problems found by GCC 4.6.0's static checks.
7815
f390e2d5
PE
7816 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7817
42eea0d0
PE
7818 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7819
b69769da 7820 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7821
f9541e84
PE
7822 * xdisp.c (vmessage): Mark as a printf-like function.
7823
13841b55
PE
7824 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7825
c136c10f
PE
7826 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7827
5e2d4a30
PE
7828 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7829 printf-like functions.
7830 (tiff_load): Add casts to remove these marks before passing them
7831 to system-supplied API.
7832
583f48b9
PE
7833 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7834
b25d760e
PE
7835 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7836 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7837 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7838 directly, rather than having caller test rule sign. This avoids
7839 some unnecessary tests.
7840 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7841 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7842 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7843
bc7b6697 7844 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7845 (xfont_open): Avoid unnecessary tests.
bc7b6697 7846
27ccc379
PE
7847 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7848
dcd5c89a
PE
7849 * composite.h, composite.c (composition_gstring_put_cache):
7850 Use EMACS_INT, not int, for length.
7851
b13a45c6
PE
7852 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7853 breaking out part of COMPOSITION_DECODE_RULE.
7854 (COMPOSITION_DECODE_RULE): Use it.
7855 * composite.c (get_composition_id): Remove unused local vars,
7856 by using the new macro.
7857
1e792e4d
PE
7858 * textprop.c (set_text_properties_1): Change while to do-while,
7859 since the condition is always true at first.
7860
dc6c6455 7861 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7862 (interval_deletion_adjustment): Return unsigned value.
7863 All uses changed.
dc6c6455 7864
aba7731a
PE
7865 * process.c (list_processes_1, create_pty, read_process_output):
7866 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7867 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7868 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7869 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7870 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7871
fdfc4bf3
PE
7872 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7873
fca8fe46 7874 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7875 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7876
06a0259a 7877 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7878 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7879 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7880
e7b9e80f
PE
7881 * print.c (print_error_message): Avoid int overflow.
7882
56201685
PE
7883 * font.c (font_list_entities): Redo for clarity,
7884 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7885
78834453 7886 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7887 (font_score): Avoid potential overflow in diff calculation.
78834453 7888
0bc0b309 7889 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7890 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7891
e610eaca
PE
7892 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7893
b895abce
PE
7894 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7895 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7896 can always succeed if overflow has undefined behavior.
7897
1f1d9321 7898 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7899 (wordify): Omit three unnecessary tests.
1f1d9321 7900
c59478bc
PE
7901 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7902 All callers changed. This avoids the need for an unused var.
7903
79b73827
PE
7904 * casefiddle.c (casify_region): Remove var that is set but not used.
7905
a4db5dfe
PE
7906 * dired.c (file_name_completion): Remove var that is set but not used.
7907
43aae36e
PE
7908 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7909
2a47c44d 7910 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7911 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7912
a37c69bf
PE
7913 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7914 Check for integer overflow on size calculations.
7915
328ab8e7
PE
7916 * buffer.c (Fprevious_overlay_change): Remove var that is set
7917 but not used.
7918
e5a2a5cb
PE
7919 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7920 Remove vars that are set but not used.
8d84a6eb 7921 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7922 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7923
a60e5f68
PE
7924 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7925
f661cb61 7926 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7927 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7928
f0397f5a
PE
7929 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7930 that are set but not used.
7931
8664db06 7932 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7933 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7934
6abdaa4a
PE
7935 * xselect.c (x_get_local_selection, x_handle_property_notify):
7936 Remove vars that are set but not used.
7937
0ce7538d 7938 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7939 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7940
9ae848fc
PE
7941 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7942 Remove var that is set but not used.
0b918413
PE
7943 (scroll_bar_windows_size): Now size_t, not int.
7944 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7945 Check for overflow.
9ae848fc 7946
a5a62657
PE
7947 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7948 (map_tty_color) [!defined MSDOS]: Likewise.
7949
5c5cdd39
PE
7950 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7951
66ebf983
PE
7952 * coding.c: Remove vars that are set but not used.
7953 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7954 All callers changed.
7955 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7956 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7957 (decode_coding_charset): Remove vars that are set but not used.
7958
1be4d761
PE
7959 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7960 that is set but not used.
7961
47553fa8
PE
7962 * print.c (print_object): Remove var that is set but not used.
7963
1f7196bf 7964 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7965 The gnulib version avoids calling malloc in the usual case,
7966 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7967 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7968 * filelock.c (current_lock_owner): Likewise.
7969 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7970 * sysdep.c: Include allocator.h, careadlinkat.h.
7971 (emacs_no_realloc_allocator): New static constant.
7972 (emacs_readlink): New function.
fdb61804
PE
7973 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7974 ../lib/careadlinkat.h.
d1fdcab7 7975
f84c17c7
SM
79762011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7977
7978 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7979 first non-nil return value).
7980
ef3862ad
JD
79812011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7982
7983 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7984 if not defined (Bug#8403).
7985
376a7006
JB
79862011-04-02 Juanma Barranquero <lekktu@gmail.com>
7987
7988 * xdisp.c (display_count_lines): Remove parameter `start',
7989 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7990 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7991 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7992 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7993 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7994 and thereabouts. All callers changed.
7995 (get_per_char_metric): Remove parameter `f', unused since
7996 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7997
6ca3801d
JM
79982011-04-02 Jim Meyering <meyering@redhat.com>
7999
8000 do not dereference NULL upon failed strdup
8001 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8002 (ns_get_family): Likewise.
8003
d8e2b5ba
JB
80042011-04-02 Juanma Barranquero <lekktu@gmail.com>
8005
8006 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8007
8c74fcbd
JD
80082011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8009
8010 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8011 later (Bug#8403).
8012
7200d79c
SM
80132011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8014
03408648 8015 Add lexical binding.
7200d79c 8016
03408648
SM
8017 * window.c (Ftemp_output_buffer_show): New fun.
8018 (Fsave_window_excursion):
8019 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8020
8021 * lread.c (lisp_file_lexically_bound_p): New function.
8022 (Fload): Bind Qlexical_binding.
8023 (readevalloop): Remove `evalfun' arg.
8024 Bind Qinternal_interpreter_environment.
8025 (Feval_buffer): Bind Qlexical_binding.
8026 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8027 Mark as dynamic.
8028 (syms_of_lread): Declare `lexical-binding'.
8029
8030 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8031
8032 * keyboard.c (eval_dyn): New fun.
8033 (menu_item_eval_property): Use it.
ca105506
SM
8034
8035 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8036
03408648
SM
8037 * fns.c (concat, mapcar1): Accept byte-code-functions.
8038
8039 * eval.c (Fsetq): Handle lexical vars.
8040 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8041 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8042 (FletX, Flet): Obey lexical binding.
8043 (Fcommandp): Handle closures.
8044 (Feval): New `lexical' arg.
8045 (eval_sub): New function extracted from Feval. Use it almost
8046 everywhere where Feval was used. Look up vars in lexical env.
8047 Handle closures.
8048 (Ffunctionp): Move from subr.el.
8049 (Ffuncall): Handle closures.
8050 (apply_lambda): Remove `eval_flags'.
8051 (funcall_lambda): Handle closures and new byte-code-functions.
8052 (Fspecial_variable_p): New function.
8053 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8054 but without exporting it to Lisp.
23aba0ea 8055
23aba0ea 8056 * doc.c (Fdocumentation, store_function_docstring):
03408648 8057 * data.c (Finteractive_form): Handle closures.
23aba0ea 8058
03408648
SM
8059 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8060 interactive spec.
ba83908c 8061
04f2d78b
CB
8062 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8063 New byte-codes.
03408648
SM
8064 (exec_byte_code): New function extracted from Fbyte_code to handle new
8065 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8066
03408648 8067 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8068
03408648 8069 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8070
e2abce01
JB
80712011-03-31 Juanma Barranquero <lekktu@gmail.com>
8072
8073 * xdisp.c (redisplay_internal): Fix prototype.
8074
63696a73 80752011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8076
63696a73 8077 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8078 (try_scrolling): Use it when setting scroll_limit.
8079 Limit scrolling to 100 screen lines.
63696a73
EZ
8080 (redisplay_window): Even when falling back on "recentering",
8081 position point in the window according to scroll-conservatively,
8082 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8083
8084 (try_scrolling): When point is above the window, allow searching
8085 as far as scroll_max, or one screenful, to compute vertical
8086 distance from PT to the scroll margin position. This prevents
8087 try_scrolling from unnecessarily failing when
8088 scroll-conservatively is set to a value slightly larger than the
8089 window height. Clean up the case of PT below the margin at bottom
8090 of window: scroll_max can no longer be INT_MAX. When aggressive
8091 scrolling is in use, don't let point enter the opposite scroll
8092 margin as result of the scroll.
8093 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8094 threshold of 100 lines for never-recentering scrolling.
8095
e4cc2dfc
JB
80962011-03-31 Juanma Barranquero <lekktu@gmail.com>
8097
8098 * dispextern.h (move_it_by_lines):
8099 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8100 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8101 (message_log_check_duplicate): Remove parameters `prev_bol' and
8102 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8103 (redisplay_internal): Remove parameter `preserve_echo_area',
8104 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8105
8106 * indent.c (Fvertical_motion):
8107 * window.c (window_scroll_pixel_based, Frecenter):
8108 Don't pass `need_y_p' to `move_it_by_lines'.
8109
1c470562
SM
81102011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8111
44f230aa
SM
8112 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8113 steal a few bits to be more compact.
8114 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8115 Remove unneeded casts.
8116
1c470562
SM
8117 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8118
888adce9
ZK
81192011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8120
8121 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8122 binding" message (bug#7967).
8123
f838ed7b
PE
81242011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8125
77861b95
PE
8126 Fix more problems found by GCC 4.6.0's static checks.
8127
de6dbc14
PE
8128 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8129 Remove unused local var.
8130
f838ed7b
PE
8131 * editfns.c (Fmessage_box): Remove unused local var.
8132
792c7b2b
PE
8133 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8134 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8135 Omit unused local vars.
c499e557 8136 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8137 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8138 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8139 Omit unused local var.
8140
ba0165e1
PE
8141 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8142 Don't assume string length fits in int.
32ad8845 8143 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8144 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8145
3c59b4c9
PE
8146 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8147 instead of alloca (Bug#8344).
8148
a3eed478 8149 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8150 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8151
eb4d412d
PE
8152 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8153
1658b401
PE
8154 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8155 concerns.
8156
8157 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8158
8159 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8160
9a2c6e05
PE
8161 * keyboard.c (syms_of_keyboard): Use the same style as later
8162 in this function when indexing through an array. This also
8163 works around GCC bug 48267.
8164
03d0a109
PE
8165 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8166
44f730c8
PE
8167 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8168
fe75f926
PE
8169 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8170 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8171
ffa8c828
PE
8172 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8173 This avoids undefined behavior on integer overflow, and is a bit
8174 more convenient anyway since it is compared to a size_t variable.
8175
c5101a77
PE
8176 Variadic C functions now count arguments with size_t, not int.
8177 This avoids an unnecessary limitation on 64-bit machines, which
8178 caused (substring ...) to crash on large vectors (Bug#8344).
8179 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8180 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8181 All variadic functions and their callers changed accordingly.
c5101a77
PE
8182 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8183 * data.c (arith_driver, float_arith_driver): Likewise.
8184 * editfns.c (general_insert_function): Likewise.
8185 * eval.c (struct backtrace.nargs, interactive_p)
8186 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8187 (funcall_lambda, mark_backtrace): Likewise.
8188 * fns.c (concat): Likewise.
8189 * frame.c (x_set_frame_parameters): Likewise.
8190 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8191 0 if not found, not -1. All callers changed.
8192
dd3f25f7
PE
8193 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8194 (stack_copy_size): Now size_t, not int.
8195 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8196
461c2ab9
JB
81972011-03-28 Juanma Barranquero <lekktu@gmail.com>
8198
8199 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8200 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8201 All callers changed.
8202
8203 * lisp.h (multibyte_char_to_unibyte):
8204 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8205 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8206 * character.h (CHAR_TO_BYTE8):
8207 * cmds.c (internal_self_insert):
8208 * editfns.c (general_insert_function):
8209 * keymap.c (push_key_description):
8210 * search.c (Freplace_match):
8211 * xdisp.c (message_dolog, set_message_1): All callers changed.
8212
f6d62986
SM
82132011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8214
8215 * keyboard.c (safe_run_hook_funcall): New function.
8216 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8217 don't set the hook to nil, but remove the offending function instead.
8218 (Qcommand_hook_internal): Remove, unused.
8219 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8220 Vcommand_hook_internal.
8221
8222 * eval.c (enum run_hooks_condition): Remove.
8223 (funcall_nil, funcall_not): New functions.
8224 (run_hook_with_args): Call each function through a `funcall' argument.
8225 Remove `cond' argument, now redundant.
8226 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8227 (Frun_hook_with_args_until_failure): Adjust accordingly.
8228 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8229
1db5b1ad
JB
82302011-03-28 Juanma Barranquero <lekktu@gmail.com>
8231
8232 * dispextern.h (string_buffer_position): Remove declaration.
8233
8234 * print.c (strout): Remove parameter `multibyte', unused since
8235 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8236
8237 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8238 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8239 All callers changed.
8240
8241 * w32.c (_wsa_errlist): Use braces for struct initializers.
8242
8243 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8244 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8245 All callers changed.
8246 (string_buffer_position): Likewise. Also, make static (it's never
8247 used outside xdisp.c).
8248 (cursor_row_p): Remove parameter `w', unused since
8249 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8250 (decode_mode_spec): Remove parameter `precision', introduced during
8251 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8252 All callers changed.
8253
5ffb62aa
JD
82542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8255
8256 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8257
461c2ab9 82582011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8259
8260 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8261 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8262 (ns_update_auto_hide_menu_bar): New functions.
8263 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8264 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8265 ns_constrain_all_frames.
8266 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8267 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8268
5c380ffb
JD
82692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8270
8271 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8272
9af30bdf
GM
82732011-03-27 Glenn Morris <rgm@gnu.org>
8274
8275 * syssignal.h: Replace RETSIGTYPE with void.
8276 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8277 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8278 Replace SIGTYPE with void everywhere.
8279 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8280 * s/template.h (SIGTYPE): Remove commented out definition.
8281
e2abce01
JB
82822011-03-26 Eli Zaretskii <eliz@gnu.org>
8283
8284 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8285 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8286
f868cd8a
JB
82872011-03-26 Juanma Barranquero <lekktu@gmail.com>
8288
59eb0929
JB
8289 * w32.c (read_unc_volume): Use parameter `henum', instead of
8290 global variable `wget_enum_handle'.
8291
8292 * keymap.c (describe_vector): Remove parameters `indices' and
8293 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8294 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8295
f868cd8a
JB
8296 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8297
8298 * keyboard.c (timer_check): Remove parameter `do_it_now',
8299 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8300 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8301 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8302
8303 * keyboard.c (read_char):
8304 * w32menu.c (w32_menu_display_help):
8305 * xmenu.c (show_help_event, menu_help_callback):
8306 Adjust calls to `show_help_echo'.
8307
8308 * gtkutil.c (xg_maybe_add_timer):
8309 * keyboard.c (readable_events):
8310 * process.c (wait_reading_process_output):
8311 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8312
8313 * insdel.c (adjust_markers_gap_motion):
8314 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8315 (gap_left, gap_right): Don't call it.
8316
2ecf6fdb
CY
83172011-03-25 Chong Yidong <cyd@stupidchicken.com>
8318
8319 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8320 incurred during fontification.
8321
6b1f9ba4
JB
83222011-03-25 Juanma Barranquero <lekktu@gmail.com>
8323
8324 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8325 (DEFVAR_PER_BUFFER): Don't pass it.
8326
8327 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8328 (scrolling_window): Don't pass it.
8329
0f4a96b5
JB
83302011-03-25 Juanma Barranquero <lekktu@gmail.com>
8331
8332 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8333
8334 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8335 and `suffix'.
8336 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8337 of variables specific to SELinux and computation of `encoded_absname'.
8338
8339 * image.c (XPutPixel): Remove unused variable `height'.
8340
8341 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8342
8343 * unexw32.c (get_section_info): Remove unused variable `section'.
8344
8345 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8346 (system_process_attributes): Remove unused variable `sess'.
8347 (sys_read): Remove unused variable `err'.
8348
8349 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8350 (w32_wnd_proc): Remove unused variable `isdead'.
8351 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8352 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8353 (x_create_tip_frame): Remove unused variable `tem'.
8354
8355 * w32inevt.c (w32_console_read_socket):
8356 Remove unused variable `no_events'.
8357
8358 * w32term.c (x_draw_composite_glyph_string_foreground):
8359 Remove unused variable `width'.
8360
1149507c
JB
83612011-03-24 Juanma Barranquero <lekktu@gmail.com>
8362
8363 * w32term.c (x_set_glyph_string_clipping):
8364 Don't pass uninitialized region to CombineRgn.
8365
9c88f339
JB
83662011-03-23 Juanma Barranquero <lekktu@gmail.com>
8367
8368 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8369 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8370 (Fx_close_connection): Remove unused variable `i'.
8371
8372 * w32font.c (w32font_draw): Return number of glyphs.
8373 (w32font_open_internal): Remove unused variable `i'.
8374 (w32font_driver): Add missing initializer.
8375
8376 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8377 (fill_in_menu): Remove unused variable `items_added'.
8378
8379 * w32term.c (last_mouse_press_frame): Remove static global variable.
8380 (w32_clip_to_row): Remove unused variable `f'.
8381 (x_delete_terminal): Remove unused variable `i'.
8382
8383 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8384 (NOTHING): Remove unused static global variable.
8385 (uniscribe_check_otf): Remove unused variable `table'.
8386 (uniscribe_font_driver): Add missing initializers.
8387
dee091a3
JD
83882011-03-23 Julien Danjou <julien@danjou.info>
8389
8390 * term.c (Fsuspend_tty, Fresume_tty):
8391 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8392 * window.c (temp_output_buffer_show):
8393 * insdel.c (signal_before_change):
8394 * frame.c (Fhandle_switch_frame):
8395 * fileio.c (Fdo_auto_save):
8396 * emacs.c (Fkill_emacs):
8397 * editfns.c (save_excursion_restore):
8398 * cmds.c (internal_self_insert):
8399 * callint.c (Fcall_interactively):
8400 * buffer.c (Fkill_all_local_variables):
8401 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8402 Use Frun_hooks.
0f4a96b5 8403 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8404 unconditionally since it does the check itself.
dee091a3 8405
2c520ab5 84062011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8407
c9c49752
PE
8408 Fix more problems found by GCC 4.5.2's static checks.
8409
8abc3f12
PE
8410 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8411 the first time through the loop, since we know p0 < p1 then.
8412 This also avoids a gcc -Wstrict-overflow warning.
8413
a2d26660
PE
8414 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8415 leading to a memory leak, possible in functions like
8416 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8417 of objects (Bug#8318).
a2d26660 8418
916c72e9
PE
8419 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8420 that could (at least in theory) be that large.
8421
19ab8a18
PE
8422 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8423 This is less likely to overflow, and avoids undefined behavior if
8424 overflow does occur. All callers changed. Use strtoul to scan
8425 for the unsigned long integer.
b7cbbd6f
PE
8426 (pint2hrstr): Simplify and tune code slightly.
8427 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8428
f0641eff
PE
8429 * scroll.c (do_scrolling): Work around GCC bug 48228.
8430 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8431
7f650bb9
PE
8432 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8433 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8434 (validate_x_resource_name): Simplify count usage.
8435 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8436
37dd57d1
PE
8437 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8438 fail (Bug#8306).
81e56e61 8439
699979fc 8440 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8441
401bf9b4
PE
8442 * process.c (Fmake_network_process): Use socklen_t, not int,
8443 where POSIX says socklen_t is required in portable programs.
8444 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8445 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8446 (Fmake_network_process, server_accept_connection):
8447 (wait_reading_process_output, read_process_output):
8448 Likewise.
8449
b93aacde
PE
8450 * process.c: Rename or move locals to avoid shadowing.
8451 (list_processes_1, Fmake_network_process):
8452 (read_process_output_error_handler, exec_sentinel_error_handler):
8453 Rename or move locals.
4dc343ee 8454 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8455 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8456 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8457 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8458 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8459
af8a867c 8460 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8461 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8462 Include tparam.h instead, since it declares them.
af8a867c
PE
8463 * cm.h (PC): Remove extern decl; tparam.h now does this.
8464 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8465 * terminfo.c: Include tparam.h, to check interfaces.
8466 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8467 (tparam): Adjust signature to match interface in tparam.h;
8468 this removes some undefined behavior. Check that outstring and len
8469 are zero, which they always are with Emacs.
8470 * tparam.h (PC, BC, UP): New extern decls.
8471
0248044d 8472 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8473 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8474
8ff096c1 8475 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8476 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8477 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8478 (ftfont_list): Remove unused local.
49eaafba
PE
8479 (get_adstyle_property, ftfont_pattern_entity):
8480 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8481 Rename locals to avoid shadowing.
8ff096c1 8482
e2be39f6
PE
8483 * xfont.c (xfont_list_family): Mark var as initialized.
8484
c9735e30
PE
8485 * xml.c (make_dom): Now static.
8486
8f5201ae
PE
8487 * composite.c (composition_compute_stop_pos): Rename local to
8488 avoid shadowing.
b246f932
PE
8489 (composition_reseat_it): Remove unused locals.
8490 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8491 (composition_update_it): Mark var as initialized.
11b61122
PE
8492 (find_automatic_composition): Mark vars as initialized,
8493 with a FIXME (Bug#8290).
8f5201ae 8494
760fbc2c
PE
8495 character.h: Rename locals to avoid shadowing.
8496 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8497 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8498 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8499 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8500 to avoid shadowing.
8501
ff08eb85
PE
8502 * textprop.c (property_change_between_p): Remove; unused.
8503
fc7bf025
PE
8504 * intervals.c (interval_start_pos): Now static.
8505
235d7abc
PE
8506 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8507
44f230aa
SM
8508 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8509 Rename locals to avoid shadowing.
3e7d6594 8510
50060332
PE
8511 * sound.c (wav_play, au_play, Fplay_sound_internal):
8512 Fix pointer signedness.
d01f234b 8513 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8514 (wav_play): Initialize a variable to 0, to prevent undefined
8515 behavior (Bug#8278).
50060332 8516
c4fc4e30
PE
8517 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8518
918436ed
PE
8519 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8520
c939f91b
PE
8521 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8522 clobbering (Bug#8298).
b9c7f648
PE
8523 * sysdep.c (sys_subshell): Likewise.
8524 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8525
6bd8c144
PE
8526 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8527 This should get cleaned up, so that child_setup has the
8528 same signature on all platforms.
8529
7710357c 8530 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8531 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8532
c59da222
CY
85332011-03-22 Chong Yidong <cyd@stupidchicken.com>
8534
8535 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8536 not to be necessary, and produces flickering.
8537
66b87493
GM
85382011-03-20 Glenn Morris <rgm@gnu.org>
8539
8540 * config.in: Remove file.
8541
45b6f6d5
JB
85422011-03-20 Juanma Barranquero <lekktu@gmail.com>
8543
8544 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8545 are now in src/globals.h.
8546 (syms_of_minibuf): Remove spurious & from previous change.
8547
cd394be1 85482011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8549
8550 * minibuf.c (completing-read-function): New variable.
8551 (completing-read-default): Rename from completing-read.
8552 (completing-read): Call completing-read-function.
8553
b14e3e21
CY
85542011-03-19 Juanma Barranquero <lekktu@gmail.com>
8555
8556 * xfaces.c (Fx_load_color_file):
8557 Read color file from absolute filename (bug#8250).
8558
f2b726e6
JB
85592011-03-19 Juanma Barranquero <lekktu@gmail.com>
8560
8561 * makefile.w32-in: Update dependencies.
8562
09f6ff02
EZ
85632011-03-17 Eli Zaretskii <eliz@gnu.org>
8564
8565 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8566
29a6015a
PE
85672011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8568
a3a6c54e
PE
8569 Fix more problems found by GCC 4.5.2's static checks.
8570
b766f867
PE
8571 * process.c (make_serial_process_unwind, send_process_trap):
8572 (sigchld_handler): Now static.
8573
be02381c
PE
8574 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8575 That way, the code declares only the vars that it needs.
8576 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8577 * s/cygwin.h (PTY_ITERATION): Likewise.
8578 * s/darwin.h (PTY_ITERATION): Likewise.
8579 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8580
57048744
PE
8581 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8582 * process.c (allocate_pty): Don't declare stb unless it's needed.
8583
7914961c 8584 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8585 (CONSTANTLIM): Remove; unused.
8586 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8587 Define only if needed.
7914961c 8588
b3967b18
PE
8589 * unexelf.c (unexec): Name an expression,
8590 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8591 Use a different way to cause a compilation error if anyone uses
8592 n rather than nn, a way that does not involve shadowing.
73366a00 8593 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8594
29a6015a
PE
8595 * deps.mk (unexalpha.o): Remove; unused.
8596
43cfc33e 8597 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8598 * unexec.h: New file.
ce701a33
PE
8599 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8600 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8601 Depend on unexec.h.
8602 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8603 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8604 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8605 Change as necessary to match prototype in unexec.h.
ce701a33 8606
01f44d5a
PE
8607 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8608 shadowing.
4f63c6bb 8609 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8610
a6670b0b
PE
8611 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8612 Rename locals to avoid shadowing.
8613
cef2010d 8614 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8615 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8616
d4d7173a
PE
8617 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8618
f08b802a
PE
8619 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8620 warning when compiling print.c.
8621
3ddb0639
PE
8622 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8623 instead of using an uninitialized var.
5ad03b97 8624 (font_sort_entities): Mark var as initialized.
3ddb0639 8625
170a2692
PE
8626 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8627
e663c700
PE
8628 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8629 pointers to constants.
89bc529a 8630 (font_parse_fcname): Remove unused vars.
7b81e2d0 8631 (font_delete_unmatched): Now static.
ea838e10 8632 (font_get_spec): Remove; unused.
13a547c6
PE
8633 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8634 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8635 Rename or move locals to avoid shadowing.
e663c700 8636
2a80c887 8637 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8638 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8639
1384fa33 8640 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8641 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8642
8b2c52e9
PE
8643 * alloc.c (mark_backtrace): Move decl from here ...
8644 * lisp.h: ... to here, so that it can be checked.
8645
475545b5 8646 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8647 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8648 (lisp_indirect_variable): Name an expression,
8649 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8650 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8651
b1349114 8652 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8653 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8654 Use const pointer when appropriate.
b1349114 8655
a2928364
PE
8656 * lisp.h (get_system_name, get_operating_system_release):
8657 Move decls here, to check interfaces.
8658 * process.c (get_operating_system_release): Move decl to lisp.h.
8659 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8660 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8661 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8662 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8663 (Fformat_time_string, Fencode_time, Finsert_char):
8664 (Ftranslate_region_internal, Fformat):
8665 Rename or remove local vars to avoid shadowing.
9710023e 8666 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8667
a415e694
PE
8668 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8669 avoid shadowing.
8670
8ef4622d
PE
8671 * lisp.h (eassert): Check that the argument compiles, even if
8672 ENABLE_CHECKING is not defined.
8673
946f9a5b
PE
8674 * data.c (Findirect_variable): Name an expression, to avoid
8675 gcc -Wbad-function-cast warning.
112396d6 8676 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8677 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8678 (Fmake_variable_buffer_local, Fmake_local_variable):
8679 Mark variables as initialized.
52746918 8680 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8681
e5aab7e7 8682 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8683 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8684 Rename locals to avoid shadowing.
dff45157
PE
8685 (mark_stack): Move local variables into the #ifdef region where
8686 they're used.
7bc26fdb
PE
8687 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8688 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8689 needed otherwise.
8690 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8691 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8692 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8693
e5aab7e7
PE
8694 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8695 avoids undefined behavior in theory.
8696
4da60324
PE
8697 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8698
88043301
PE
8699 Use functions, not macros, for up- and down-casing (Bug#8254).
8700 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8701 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8702 to use the following functions instead of these macros.
8703 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8704 EMACS_INT, since callers assume the returned value fits in int.
8705 (upcase1): Likewise, for UPCASE_TABLE.
8706 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8707 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8708 the race-condition problem in the old DOWNCASE.
88043301 8709
19ed5445
PE
8710 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8711 Rename locals to avoid shadowing.
8712 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8713 (regex_compile, re_search_2, re_match_2_internal):
8714 Remove unused local vars.
952db0d7
PE
8715 (FREE_VAR): Rewrite so as not to use empty "else",
8716 which gcc can warn about.
da053e48 8717 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8718 (RETALLOC_IF): Define only if needed.
8719 (WORDCHAR_P): Likewise. This one is never needed, but is used
8720 only in a comment talking about a compiler bug, so put inside
8721 the #if 0 of that comment.
8722 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8723 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8724 Remove; unused.
19ed5445 8725
1f3561e4 8726 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8727 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8728 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8729
ded6f8f7
PE
8730 * search.c (simple_search): Remove unused var.
8731
dbd37a95
PE
8732 * dired.c (compile_pattern): Move decl from here ...
8733 * lisp.h: ... to here, so that it can be checked.
8734 (struct re_registers): New forward decl.
8735
7e47afad
PE
8736 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8737
85f24f61
PE
8738 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8739 All uses changed.
8740 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8741 Rename locals to avoid shadowing.
5671df8f 8742 (Fvertical_motion): Mark locals as initialized.
85f24f61 8743
181aa2be 8744 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8745 (casify_region): Mark local as initialized.
181aa2be 8746
930d429c
PE
8747 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8748
7082eac6
PE
8749 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8750 New macros, so that the caller can use some names other than
8751 gcpro1, gcpro2, etc.
8752 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8753 of the new macros.
8754 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8755 argument, for consistency with GCPRO2_VAR, etc: it is now the
8756 prefix of the variable, not the variable itself. All uses
8757 changed.
38b2c076
PE
8758 * dired.c (directory_files_internal, file_name_completion):
8759 Rename locals to avoid shadowing.
8760
15206ed9
PE
8761 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8762 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8763 dired.c's scmp function, had undefined behavior.
8764 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8765 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8766 * buffer.h: ... to here, because these macros use current_buffer,
8767 and the new implementation with inline functions needs to have
8768 current_buffer in scope now, rather than later when the macros
8769 are used.
8770 (downcase, upcase1): New static inline functions.
8771 (DOWNCASE, UPCASE1): Reimplement using these functions.
8772 This avoids undefined behavior in expressions like
8773 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8774 from race conditions in accessing the global variables
8775 case_temp1 and case_temp2.
8776 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8777 * lisp.h (case_temp1, case_temp2): Remove their decls.
8778 * character.h (ASCII_CHAR_P): Move from here ...
8779 * lisp.h: ... to here, so that the inline functions mentioned
8780 above can use them.
8781
4a6bea26
PE
8782 * dired.c (directory_files_internal_unwind): Now static.
8783
f14b7e14
PE
8784 * fileio.c (file_name_as_directory, directory_file_name):
8785 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8786 Now static.
2893f146
PE
8787 (file_name_as_directory): Use const pointers when appropriate.
8788 (Fexpand_file_name): Likewise. In particular, newdir might
8789 point at constant storage, so make it a const pointer.
fd4ead52 8790 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8791 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8792 signedness issues.
f839df0c
PE
8793 (Fset_file_times, Finsert_file_contents, auto_save_error):
8794 Rename locals to avoid shadowing.
f14b7e14 8795
5716756e 8796 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8797 (Ftry_completion, Fall_completions): Rename or remove locals
8798 to avoid shadowing.
5716756e 8799
b4c3046a
PE
8800 * marker.c (bytepos_to_charpos): Remove; unused.
8801
b45db522
PE
8802 * lisp.h (verify_bytepos, count_markers): New decls,
8803 so that gcc does not warn that these functions aren't declared.
8804
85876d07
PE
8805 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8806 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8807 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8808 (copy_text): Remove unused local var.
85876d07 8809
03d78a21 8810 * filelock.c (within_one_second): Now static.
b3dd38ab 8811 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8812
5df8f01b
PE
8813 * buffer.c (fix_overlays_before): Mark locals as initialized.
8814 (fix_start_end_in_overlays): Likewise. This function should be
8815 simplified by using pointers-to-pointers, but that's a different
8816 matter.
b1d876f1 8817 (switch_to_buffer_1): Now static.
8f54f30a
PE
8818 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8819 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8820
a70072c9 8821 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8822 Fix pointer signedness issue.
edced198
PE
8823 (sys_subshell): Mark local as volatile if checking for lint,
8824 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8825 (MAXPATHLEN): Define only if needed.
a70072c9 8826
a0977c44
PE
8827 * process.c (serial_open, serial_configure): Move decls from here ...
8828 * systty.h: ... to here, so that they can be checked.
8829
a884fdcc
PE
8830 * fns.c (get_random, seed_random): Move extern decls from here ...
8831 * lisp.h: ... to here, so that they can be checked.
8832
604efe86 8833 * sysdep.c (reset_io): Now static.
b8950c94 8834 (wait_for_termination_signal): Remove; unused.
604efe86 8835
38fc62d9
PE
8836 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8837 (copy_keymap_item, append_key, push_text_char_description):
8838 Now static.
1004a21a 8839 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8840 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8841 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8842 (describe_map_tree):
8843 Rename locals to avoid shadowing.
38fc62d9 8844
2f2650da
PE
8845 * keyboard.c: Declare functions static if they are not used elsewhere.
8846 (echo_char, echo_dash, cmd_error, top_level_2):
8847 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8848 (read_char, kbd_buffer_get_event, make_lispy_position):
8849 (make_lispy_event, make_lispy_movement, apply_modifiers):
8850 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8851 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8852 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8853 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8854 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8855
a053e86c 8856 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8857 (mark_kboards): Move decl here ...
8858 * alloc.c (mark_kboards): ... from here.
a053e86c 8859
4752793e
PE
8860 * lisp.h (force_auto_save_soon): New decl.
8861
74f10ca7 8862 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8863 (DEFINE_DUMMY_FUNCTION): New macro.
8864 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8865 Use it.
c03cd23f
PE
8866 (main): Add casts to avoid warnings
8867 if GCC considers string literals to be constants.
74f10ca7 8868
022e70d4
PE
8869 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8870
59d6fe83
PE
8871 * dbusbind.c: Pointer signedness fixes.
8872 (xd_signature, xd_append_arg, xd_initialize):
8873 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8874 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8875 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8876 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8877
78320123
PE
8878 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8879 if GCC considers string literals to be constants.
49cebcca 8880 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8881
35ac2a97
SM
88822011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8883
fb103ca9
SM
8884 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8885 (print_preprocess, print_object): New macro to fix last change.
8886
35ac2a97
SM
8887 * print.c (print_preprocess): Don't forget font objects.
8888
62973b41
JB
88892011-03-16 Juanma Barranquero <lekktu@gmail.com>
8890
8891 * emacs.c (USAGE3): Doc fixes.
8892
0e48bb22
AS
88932011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8894
8895 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8896 structure.
8897
7684e57b
JB
88982011-03-14 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * lisp.h (VWindow_system, Qfile_name_history):
8901 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8902 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8903 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8904
8905 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8906 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8907
8908 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8909 * w32console.c (detect_input_pending, read_input_pending)
8910 (encode_terminal_code):
8911 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8912 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8913 (w32_system_caret_y, Qfile_name_history):
8914 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8915 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8916 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8917 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8918 * w32proc.c (Qlocal, report_file_error):
8919 * w32term.c (Vwindow_system, updating_frame):
8920 * w32uniscribe.c (initialized, uniscribe_font_driver):
8921 Remove unneeded extern declarations.
8922
2aa46d6c
CY
89232011-03-14 Chong Yidong <cyd@stupidchicken.com>
8924
c96bbc66 8925 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8926
cffc6f3b
CY
89272011-03-13 Chong Yidong <cyd@stupidchicken.com>
8928
8929 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8930 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8931 These macros can no longer be used for assignment.
8932
44f230aa
SM
8933 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8934 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8935 (record_buffer_markers, fetch_buffer_markers): New functions for
8936 recording and fetching special buffer markers.
8937 (set_buffer_internal_1, set_buffer_temp): Use them.
8938
8939 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8940
8941 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8942
8943 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8944 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8945
8946 * xdisp.c (hscroll_window_tree):
8947 (reconsider_clip_changes): Use PT instead of BUF_PT.
8948
d251f04b
EZ
89492011-03-13 Eli Zaretskii <eliz@gnu.org>
8950
8951 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8952 $(EMACS_ROOT)/lib/intprops.h.
8953
f0c77cd1
PE
89542011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8955
3eca4629
PE
8956 Fix more problems found by GCC 4.5.2's static checks.
8957
7c86ee98
PE
8958 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8959 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8960 (xg_free_frame_widgets): Make it clear that a local variable is
8961 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8962 (gdk_window_get_screen): Make it clear that this macro is needed
8963 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8964 (int_gtk_range_get_value): New function, which avoids a diagnostic
8965 from gcc -Wbad-function-cast.
8966 (xg_set_toolkit_scroll_bar_thumb): Use it.
8967 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8968 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8969 (get_utf8_string, xg_get_file_with_chooser):
8970 Rename locals to avoid shadowing.
8971 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8972
41729b81
PE
8973 * xgselect.c (xg_select): Remove unused var.
8974
f0c77cd1
PE
8975 * image.c (four_corners_best): Mark locals as initialized.
8976 (gif_load): Initialize transparent_p to zero (Bug#8238).
8977 Mark another local as initialized.
ec6cf4c6 8978 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8979
ce0ad53d 8980 * image.c (clear_image_cache): Now static.
d5d5a617 8981 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8982 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8983 (x_edge_detection): Remove unnecessary cast that
8984 gcc -Wbad-function-cast diagnoses.
2037898d 8985 (gif_load): Fix pointer signedness.
6ae141d6
PE
8986 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8987 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8988
33383987 89892011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8990
d32df629
PE
8991 Improve quality of tests for time stamp overflow.
8992 For example, without this patch (encode-time 0 0 0 1 1
8993 1152921504606846976) returns the obviously-bogus value (-948597
8994 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8995 reports time overflow. See
8996 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8997 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8998 * editfns.c: Include limits.h and intprops.h.
8999 (TIME_T_MIN, TIME_T_MAX): New macros.
9000 (time_overflow): Move earlier, to before first use.
9001 (hi_time, lo_time): New functions, for an accurate test for
9002 out-of-range times.
9003 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9004 (Fget_internal_run_time): Don't assume time_t fits in int.
9005 (make_time): Use list2 instead of Fcons twice.
9006 (Fdecode_time): More accurate test for out-of-range times.
9007 (check_tm_member): New function.
9008 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9009 (lisp_time_argument): Don't rely on undefined left-shift and
9010 right-shift behavior when checking for time stamp overflow.
8be6f318 9011
fe31d94c
PE
9012 * editfns.c (time_overflow): New function, refactoring common code.
9013 (Fformat_time_string, Fdecode_time, Fencode_time):
9014 (Fcurrent_time_string): Use it.
9015
8be6f318
PE
9016 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9017 * dired.c (make_time): Move to ...
9018 * editfns.c (make_time): ... here.
9019 * systime.h: Note the move.
9020
09d9db2c 90212011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9022
126bc0dc
YM
9023 * fringe.c (update_window_fringes): Remove unused variables.
9024
c47cbdfd
YM
9025 * unexmacosx.c (copy_data_segment): Also copy __got section.
9026 (Bug#8223)
9027
7ac80be9
EZ
90282011-03-12 Eli Zaretskii <eliz@gnu.org>
9029
c96bbc66 9030 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9031 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9032 Constify `char *' arguments and their references according to
9033 prototypes in tparam.h.
9034
ecb0f94d 9035 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9036
7ac80be9
EZ
9037 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9038 Adapt all references accordingly.
9039
9040 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9041
ef1fd07e
TT
90422011-03-11 Tom Tromey <tromey@redhat.com>
9043
9044 * buffer.c (syms_of_buffer): Remove obsolete comment.
9045
7ef4b50c
EZ
90462011-03-11 Eli Zaretskii <eliz@gnu.org>
9047
9048 * termhooks.h (encode_terminal_code): Declare prototype.
9049
9050 * msdos.c (encode_terminal_code): Don't declare prototype.
9051
9052 * term.c (encode_terminal_code): Now external again, used by
9053 w32console.c and msdos.c.
9054
44f230aa
SM
9055 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9056 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9057
4b1ec863 90582011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9059
1714f52b 9060 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9061
4b1ec863
PE
9062 * fringe.c (update_window_fringes): Mark locals as initialized
9063 (Bug#8227).
9064 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9065
524c7aa6
PE
9066 * alloc.c (mark_fringe_data): Move decl from here ...
9067 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9068 to check its interface.
9069 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9070
a5c0af81 9071 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9072 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9073 (fontset_font): Mark local as initialized.
a9a06e0b 9074 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9075
b4716021
PE
9076 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9077
811e9bac 9078 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9079 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9080 (x_own_selection, Fx_disown_selection_internal): Rename locals
9081 to avoid shadowing.
9082 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9083
7e3ab302
PE
9084 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9085 so that the caller can use some name other than gcpro1.
9086 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9087 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9088 (Fx_backspace_delete_keys_p):
9089 Use them to avoid shadowing, and rename vars to avoid shadowing.
9090 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9091 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9092 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9093 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9094 Remove unused locals.
7e3ab302
PE
9095 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9096 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9097 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9098 macros.
f78faa98 9099
e2b13473
PE
9100 * xterm.h (x_mouse_leave): New decl.
9101
77f23912
PE
9102 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9103 Remove unused functions.
cdf4ba58
PE
9104 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9105 (x_calc_absolute_position): Now static.
7411c686 9106 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9107 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9108 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9109 unless they are used.
38d0b34a
PE
9110 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9111 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9112 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9113 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9114 (x_error_catcher, x_connection_closed, x_error_handler):
9115 (x_error_quitter, xembed_send_message, x_iconify_frame):
9116 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9117 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9118 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9119
44f230aa
SM
9120 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9121 Rename or move locals to avoid shadowing.
6b463e58 9122 (tty_defined_color, merge_face_heights): Now static.
5967d051 9123 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9124 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9125 does not deduce is never used uninitialized.
73719eba
PE
9126 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9127 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9128
426994c3 9129 * terminal.c (store_terminal_param): Now static.
5489860b 9130
032f1620 9131 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9132 (set_frame_menubar): Remove unused local.
d4323972 9133 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9134 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9135 since they might point to immutable storage.
281585b0
PE
9136 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9137 since it's unused otherwise.
032f1620 9138
367c19e5 9139 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9140 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9141 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9142 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9143 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9144 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9145 does not deduce are never used uninitialized.
70739cbe 9146
07b48fa9
PE
9147 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9148
8868a238 9149 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9150 * window.c (window_loop, size_window):
9151 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9152
7e5cf297 9153 * window.c (display_buffer): Now static.
d6550a9f
PE
9154 (size_window): Mark variables that gcc -Wuninitialized
9155 does not deduce are never used uninitialized.
a586633d
PE
9156 * window.h (check_all_windows): New decl, to forestall
9157 gcc -Wmissing-prototypes diagnostic.
5b555da1 9158 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9159
f6095868
PE
9160 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9161 shadowing.
9162 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9163 Include <limits.h>.
9164 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9165 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9166 (load_charset_map): Mark variables that gcc -Wuninitialized
9167 does not deduce are never used uninitialized.
53df7c11 9168 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9169
f38b440c
PE
9170 * coding.c (coding_set_source, coding_set_destination):
9171 Use "else { /* comment */ }" rather than "else /* comment */;"
9172 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9173 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9174 a block, when the outer 'i' will do.
9175 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9176 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9177 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9178 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9179 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9180 Rename locals to avoid shadowing.
9181 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9182 * coding.c (emacs_mule_char, encode_invocation_designation):
9183 Now static, since they're not used elsewhere.
413bb2db 9184 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9185 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9186 (decode_coding_emacs_mule): Mark variables that gcc
9187 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9188 (detect_coding_iso_2022): Initialize a local variable that might
9189 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9190 this initialization is needed. (Bug#8211)
5f58e762
PE
9191 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9192 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9193 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9194 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9195 Remove unused macros.
f38b440c 9196
232b38b9 9197 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9198 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9199 * character.c (string_count_byte8): Likewise.
232b38b9 9200
fb90da1b
PE
9201 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9202 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9203
fb93dbc2
PE
9204 * chartab.c (copy_sub_char_table): Now static, since it's not used
9205 elsewhere.
5c156ace
PE
9206 (sub_char_table_ref_and_range, char_table_ref_and_range):
9207 Rename locals to avoid shadowing.
bbcd0949 9208 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9209
7d3b3862 9210 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9211 (BIDI_BOB): Remove unused macro.
7d3b3862 9212
6be7d3da
PE
9213 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9214 deduce are never used uninitialized.
c2ed9c8b 9215 * term.c (encode_terminal_code): Likewise.
6be7d3da 9216
75f8807f 9217 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9218
50938595
PE
9219 * tparam.h: New file.
9220 * term.c, tparam.h: Include it.
9221 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9222 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9223 Move these decls to tparam.h, and make them agree with what
9224 is actually in tparam.c. The previous trick of using incompatible
9225 decls in different modules does not conform to the C standard.
9226 All callers of tparam changed to use tparam's actual API.
9227 * tparam.c (tparam1, tparam, tgoto):
9228 Use const pointers where appropriate.
9229
fbceeba2
PE
9230 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9231 * cm.h (struct cm): Likewise.
9232 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9233 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9234 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9235 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9236 (turn_on_face, init_tty): Likewise.
9237 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9238
7f3f1250
PE
9239 * term.c (term_mouse_position): Rename local to avoid shadowing.
9240
e6ca6543
PE
9241 * alloc.c (mark_ttys): Move decl from here ...
9242 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9243
c40f8d15
AS
92442011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9245
9246 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9247
cfe0661d
JB
92482011-03-09 Juanma Barranquero <lekktu@gmail.com>
9249
9250 * search.c (compile_pattern_1): Remove argument regp, unused since
9251 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9252 (compile_pattern): Don't pass it.
9253
0afb4571
J
92542011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9255
9256 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9257 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9258 for ! HAVE_GTK3.
9259 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9260
9261 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9262
9263 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9264 gdk_window_get_screen, gdk_window_get_geometry,
9265 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9266 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9267 (xg_get_pixbuf_from_pixmap): New function.
9268 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9269 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9270 Call xg_get_pixbuf_from_pixmap instead of
9271 gdk_pixbuf_get_from_drawable.
9272 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9273 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9274 (xg_check_special_colors): Use GtkStyleContext and its functions
9275 for HAVE_GTK3.
9276 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9277 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9278 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9279 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9280 Call gtk_widget_get_preferred_size.
0afb4571
J
9281 (xg_frame_resized): gdk_window_get_geometry only takes 5
9282 parameters.
44f230aa
SM
9283 (xg_win_to_widget, xg_event_is_for_menubar):
9284 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9285 (xg_set_widget_bg): New function.
9286 (delete_cb): New function.
895009e1 9287 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9288 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9289 (xg_set_background_color): Call xg_set_widget_bg.
9290 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9291 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9292 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9293 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9294 if ! HAVE_GTK3.
9295 (update_frame_tool_bar): Call gtk_widget_hide.
9296 (xg_initialize): Use GDK_KEY_g.
9297
9298 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9299 if ! HAVE_GTK3
9300 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9301
9302 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9303 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9304 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9305
1c2cc4ef
JB
93062011-03-08 Juanma Barranquero <lekktu@gmail.com>
9307
9308 * w32xfns.c (select_palette): Check success of RealizePalette against
9309 GDI_ERROR, not zero.
9310
33383987 9311See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9312
9313;; Local Variables:
9314;; coding: utf-8
aac0c6e3
MR
9315;; End:
9316
acaf905b 9317 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9318
9319 This file is part of GNU Emacs.
9320
9321 GNU Emacs is free software: you can redistribute it and/or modify
9322 it under the terms of the GNU General Public License as published by
9323 the Free Software Foundation, either version 3 of the License, or
9324 (at your option) any later version.
9325
9326 GNU Emacs is distributed in the hope that it will be useful,
9327 but WITHOUT ANY WARRANTY; without even the implied warranty of
9328 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9329 GNU General Public License for more details.
9330
9331 You should have received a copy of the GNU General Public License
9332 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.