Warning comments about subtleties of fetching characters from buffers/strings.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2f8e16b2
EZ
12012-04-06 Eli Zaretskii <eliz@gnu.org>
2
3 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5 about subtle differences between FETCH_CHAR* and STRING_CHAR*
6 macros related to unification of CJK characters. For the details,
7 see the discussion following the message here:
8 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
9
3d439cd1
CY
102012-04-04 Chong Yidong <cyd@gnu.org>
11
12 * keyboard.c (Vdelayed_warnings_list): Doc fix.
13
8bc53d00
EZ
142012-04-01 Eli Zaretskii <eliz@gnu.org>
15
16 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
17 instead of alloca. (Bug#11138)
18
3b0512a3
AS
192012-04-01 Andreas Schwab <schwab@linux-m68k.org>
20
21 * w32menu.c (is_simple_dialog): Properly check lisp types.
22 (Bug#11141)
23
8427ddd2
EZ
242012-03-31 Eli Zaretskii <eliz@gnu.org>
25
979022ef
EZ
26 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
27 position we get to after a call to move_it_to fails the
28 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
29 only if we wind up in a string from display property. (Bug#11063)
30
a6b1c7cc
EZ
31 * window.c (Fdelete_other_windows_internal): Invalidate the row
32 and column information about mouse highlight, so that redisplay
33 restores it after reallocating the glyph matrices. (Bug#7464)
34
8427ddd2
EZ
35 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
36 string comes from a `display' text property, use the buffer
37 position of that property as if we actually saw that position in
38 the row's glyphs.
697ba24b
EZ
39 (move_it_by_lines): Remove the assertion that
40 "it->current_x == 0 && it->hpos == 0" which can be legitimately
41 violated when there's a before-string at the beginning of a line.
42 (Bug#11063)
8427ddd2 43
65a0a738
EZ
442012-03-30 Eli Zaretskii <eliz@gnu.org>
45
46 * xdisp.c (append_space_for_newline): If the default face was
47 remapped, use the remapped face for the appended newline.
48 (extend_face_to_end_of_line): Use the remapped default face for
49 extending the face to the end of the line.
50 (display_line): Call extend_face_to_end_of_line when the default
51 face was remapped. (Bug#11068)
52
581355cc
EZ
532012-03-29 Eli Zaretskii <eliz@gnu.org>
54
55 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
56
e8fc049f
SM
572012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
58
59 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
60
4fb9a543
GM
612012-03-27 Glenn Morris <rgm@gnu.org>
62
63 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
64 Doc fixes.
65
679910f1
KH
662012-03-26 Kenichi Handa <handa@m17n.org>
67
68 * dispextern.h (struct glyph): Fix previous change. Change the
69 bit length of glyphless.ch to 25 (Bug#11082).
70
90d49b7f
CY
712012-03-26 Chong Yidong <cyd@gnu.org>
72
73 * keyboard.c (Vselection_inhibit_update_commands): New variable.
74 (command_loop_1): Use it; inhibit selection update for
75 handle-select-window too (Bug#8996).
76
f514f6f0
FP
772012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
78
e8fc049f 79 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 80
bf43fa51
KH
812012-03-25 Kenichi Handa <handa@m17n.org>
82
83 * dispextern.h (struct glyph): Change the bit length of
84 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
85
8a0c01dd
EZ
862012-03-24 Eli Zaretskii <eliz@gnu.org>
87
88 * s/ms-w32.h (tzname): Include time.h before redirecting to
89 _tzname. Fixes the MSVC build. (Bug#9960)
90
7d1c3a76
AS
912012-03-24 Andreas Schwab <schwab@linux-m68k.org>
92
8ed79523
AS
93 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
94 characters.
95
7d1c3a76
AS
96 * xterm.c (XTread_socket): Only modify handling_signal if
97 !SYNC_INPUT. (Bug#11080)
98
e99a9b8b
EZ
992012-03-23 Eli Zaretskii <eliz@gnu.org>
100
101 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
102 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
103 when fetching a multibyte character consumes more bytes than
104 CHAR_BYTES returns, due to unification of CJK characters in
105 string_char. (Bug#11073)
106
5063c0e1
TN
1072012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
108
109 * process.c (wait_reading_process_output): Handle pty disconnect
110 by refraining from sending oneself a SIGCHLD (bug#10933).
111
9f851fbd
CY
1122012-03-22 Chong Yidong <cyd@gnu.org>
113
114 * dispextern.h (struct it): New member string_from_prefix_prop_p.
115
5063c0e1 116 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
117 Mark string as coming from a prefix property.
118 (handle_face_prop): Use default face for prefix strings (Bug#4281).
119 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
120
fb5b8aca
CY
1212012-03-21 Chong Yidong <cyd@gnu.org>
122
123 * xfaces.c (Vface_remapping_alist): Doc fix.
124
62356a1b
EZ
1252012-03-20 Eli Zaretskii <eliz@gnu.org>
126
127 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
128 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
129 Doc fixes.
62356a1b 130
025de85b
CY
1312012-03-20 Chong Yidong <cyd@gnu.org>
132
133 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
134 to reflect default non-nil value of redisplay-dont-pause.
135
4827f94e
KH
1362012-03-19 Kenichi Handa <handa@m17n.org>
137
138 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
139 it fit in a valid range (Bug#11003).
140
e50a24a2
EZ
1412012-03-18 Eli Zaretskii <eliz@gnu.org>
142
143 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
144 that is not from display property, accept the row as a "cursor
145 row" if one of the string's character has a non-nil `cursor'
146 property. Fixes cursor positioning when there are newlines in
147 overlay strings, e.g. in icomplete.el. (Bug#11035)
148
9af5ed87
PE
1492012-03-12 Paul Eggert <eggert@cs.ucla.edu>
150
151 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
152
d1f55f16
CY
1532012-03-12 Chong Yidong <cyd@gnu.org>
154
155 * eval.c (inhibit_lisp_code): Rename from
156 inhibit_window_configuration_change_hook; move from window.c.
157
158 * xfns.c (unwind_create_frame_1, Fx_create_frame):
159 * window.c (run_window_configuration_change_hook)
160 (syms_of_window): Callers changed.
161
66c5eebd
CY
1622012-03-11 Chong Yidong <cyd@gnu.org>
163
413df973
CY
164 * keymap.c (Fkey_description): Doc fix (Bug#9700).
165
66c5eebd
CY
166 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
167
1de11f56
CY
1682012-03-10 Chong Yidong <cyd@gnu.org>
169
170 * frame.c (other_visible_frames): Don't assume the selected frame
171 is visible (Bug#10955).
172
cae07000
SM
1732012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
174
175 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
176
89c94350
JD
1772012-03-08 Jan Djärv <jan.h.d@swipnet.se>
178
179 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
180 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
181 zero (Bug#10954).
182
999dd333
GM
1832012-03-03 Glenn Morris <rgm@gnu.org>
184
01a6dcc8 185 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 186
de0100f2
EZ
1872012-03-02 Eli Zaretskii <eliz@gnu.org>
188
189 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
190 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
191 (redisplay_window, next_element_from_string): Fix typos in
192 comments.
3e441275
EZ
193 (redisplay_window): Pass to move_it_vertically the margin in
194 pixels, not in screen lines.
de0100f2 195
96a72ee9
GM
1962012-03-02 Glenn Morris <rgm@gnu.org>
197
198 * buffer.c (buffer-list-update-hook): Doc fix.
199
312508d7
EZ
2002012-02-29 Eli Zaretskii <eliz@gnu.org>
201
202 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
203 push_it before setting up the iterator for the first overlay
204 string, even if we have an empty string loaded.
205 (next_overlay_string): If there's an empty string on the iterator
206 stack, pop the stack. (Bug#10903)
207
27f3c637
PE
2082012-02-25 Paul Eggert <eggert@cs.ucla.edu>
209
210 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
211 Suggested by Stefan Monnier in
212 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
213 * alloc.c (widen_to_Lisp_Object): New static function.
214 (mark_memory): Also mark Lisp_Objects by fetching pointer words
215 and widening them to Lisp_Objects. This would work even if
216 USE_LSB_TAG is defined and wide integers are used, which might
217 happen in a future version of Emacs.
218
3c9dfce6
CY
2192012-02-25 Chong Yidong <cyd@gnu.org>
220
fa74b241
CY
221 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
222 Doc fix.
223
3c9dfce6
CY
224 * xselect.c (Fx_selection_exists_p): Doc fix.
225 (x_clipboard_manager_save_all): Print an informative message
226 before saving to clipboard manager.
227
9486df08
CY
2282012-02-24 Chong Yidong <cyd@gnu.org>
229
230 * keyboard.c (process_special_events): Handle all X selection
231 requests in kbd_buffer, not just the next one (Bug#8869).
232
f01d3321
CY
2332012-02-23 Chong Yidong <cyd@gnu.org>
234
235 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
236 call when setting menu-bar-lines and tool-bar-lines parameters.
237 (unwind_create_frame_1): New helper function.
238
239 * window.c (inhibit_window_configuration_change_hook): New var.
240 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 241 (syms_of_window): Initialize it.
f01d3321 242
86b847b6
CY
2432012-02-22 Chong Yidong <cyd@gnu.org>
244
245 * xterm.c (x_draw_image_relief): Add missing type check for
246 Vtool_bar_button_margin (Bug#10743).
247
a59225b1
CY
2482012-02-21 Chong Yidong <cyd@gnu.org>
249
250 * fileio.c (Vfile_name_handler_alist): Doc fix.
251
252 * buffer.c (Fget_file_buffer): Protect against invalid file
253 handler return value.
254
310f5bd4
PE
2552012-02-20 Paul Eggert <eggert@cs.ucla.edu>
256
cb3a28cc
PE
257 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
258 when computing $valmask.
259
310f5bd4
PE
260 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
261 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
262 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
263 It's useless in that case, and it can cause problems on hosts
264 that allocate halves of EMACS_INT values separately.
265 Reported by Dan Horák. Diagnosed by Andreas Schwab in
266 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
267 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
268 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
269 it avoids undefined behavior on hosts where shifting right by more
270 than the word width has undefined behavior.
271
2375c96a
CY
2722012-02-19 Chong Yidong <cyd@gnu.org>
273
274 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
275 (Funhandled_file_name_directory, Ffile_name_as_directory)
276 (Fdirectory_file_name, Fexpand_file_name)
277 (Fsubstitute_in_file_name): Protect against invalid file handler
278 return values (Bug#10845).
279
3eb49e71
EZ
2802012-02-18 Eli Zaretskii <eliz@gnu.org>
281
282 * .gdbinit (pitx): Fix incorrect references to fields of the
283 iterator stack.
284
7b926f3f
CY
2852012-02-17 Chong Yidong <cyd@gnu.org>
286
287 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
288
11273115
PE
2892012-02-15 Paul Eggert <eggert@cs.ucla.edu>
290
291 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
292 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
293
c3a70e2b
CY
2942012-02-15 Chong Yidong <cyd@gnu.org>
295
296 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
297 marked as special. Also, starting docstrings with * is obsolete.
298
0ca43699
AS
2992012-02-13 Andreas Schwab <schwab@linux-m68k.org>
300
301 * gnutls.c (emacs_gnutls_write): Fix last change.
302
2e8f3c56
LI
3032012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
304
305 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
306 send_process.
307
af70074f
SM
3082012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
309
310 * keymap.c (Fsingle_key_description): Handle char ranges.
311
95986d52
CY
3122012-02-12 Chong Yidong <cyd@gnu.org>
313
afd83bd1
CY
314 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
315 as that creates a dangerous corner case.
316
95986d52
CY
317 * window.c (Fdelete_window_internal): Invalidate the mouse
318 highlight (Bug#9904).
319
bd7da63e
GM
3202012-02-12 Glenn Morris <rgm@gnu.org>
321
322 * xselect.c (Fx_own_selection_internal)
323 (Fx_get_selection_internal, Fx_disown_selection_internal)
324 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
325 * nsselect.m (Fx_own_selection_internal)
326 (Fx_disown_selection_internal, Fx_selection_exists_p)
327 (Fx_selection_owner_p, Fx_get_selection_internal):
328 Sync docs and argument specs with the xselect.c versions.
329
77abcbc2
LI
3302012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
331
332 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
333
90b671e2
EZ
3342012-02-11 Eli Zaretskii <eliz@gnu.org>
335
1c0ca0b7
EZ
336 * w32select.c (Fx_selection_exists_p): Sync doc string and
337 argument list with xselect.c. (Bug#10783)
338
339 * w16select.c (Fx_selection_exists_p): Sync doc string and
340 argument list with xselect.c. (Bug#10783)
90b671e2 341
49241268
GM
3422012-02-10 Glenn Morris <rgm@gnu.org>
343
344 * fns.c (Fsecure_hash): Doc fix.
345
f998bbe7 3462012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
347
348 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
349
0992bd9c
CY
3502012-02-07 Chong Yidong <cyd@gnu.org>
351
352 * buffer.c (Fbuffer_local_variables)
353 (buffer_lisp_local_variables): Handle unbound vars correctly;
354 don't let Qunbound leak into Lisp.
355
af008560
GM
3562012-02-07 Glenn Morris <rgm@gnu.org>
357
dd605cc4
GM
358 * image.c (Fimagemagick_types): Doc fix.
359
af008560
GM
360 * image.c (imagemagick-render-type): Change it from a lisp object
361 to an integer. Move the doc here from the lisp manual.
362 Treat all values not equal to 0 the same.
363
1449fa1d
CY
3642012-02-06 Chong Yidong <cyd@gnu.org>
365
366 * doc.c (store_function_docstring): Avoid applying docstring of
367 alias to base function (Bug#2603).
368
3723ec07
AS
3692012-02-04 Andreas Schwab <schwab@linux-m68k.org>
370
371 * .gdbinit (pp1, pv1): Remove redundant defines.
372 (pr): Use pp.
373
79c1cc1e
CY
3742012-02-04 Chong Yidong <cyd@gnu.org>
375
376 * nsterm.m: Declare a global (Bug#10694).
377
d7f29f8e
EZ
3782012-02-04 Eli Zaretskii <eliz@gnu.org>
379
cae07000
SM
380 * w32.c (get_emacs_configuration_options):
381 Include --enable-checking, if specified, in the return value.
d7f29f8e 382
3b95a6f9
MR
3832012-02-04 Martin Rudalics <rudalics@gmx.at>
384
385 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
386 after rounding frame sizes. (Bug#9723)
387
d6fa96a6
EZ
3882012-02-04 Eli Zaretskii <eliz@gnu.org>
389
390 * keyboard.c (adjust_point_for_property): Don't position point
391 before BEGV. (Bug#10696)
392
df0b2940
PE
3932012-02-03 Paul Eggert <eggert@cs.ucla.edu>
394
395 Handle overflow when computing char display width (Bug#9496).
396 * character.c (char_width): Return EMACS_INT, not int.
397 (char_width, c_string_width): Check for overflow when
398 computing the width; this is possible now that individual
399 characters can have unbounded width. Problem introduced
400 by merge from Emacs 23 on 2012-01-19.
401
6bee44d6
MA
4022012-02-02 Michael Albinus <michael.albinus@gmx.de>
403
404 * dbusbind.c (Fdbus_register_method): Mention the return value
405 :ignore in the docstring.
406
44f92739
GM
4072012-02-02 Glenn Morris <rgm@gnu.org>
408
1b9f60cc
GM
409 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
410
44f92739
GM
411 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
412 Unconditionally set to t. (Bug#10673)
413 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
414 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
415 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
416
c5d3843c
KH
4172012-02-02 Kenichi Handa <handa@m17n.org>
418
419 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
420 0, do not call append_composite_glyph.
421
159462d4 4222012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
423
424 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
425 NULL (Bug#6988).
426 (x_produce_glyphs): If the component of a composition is a null
427 string, set it->pixel_width to 1 to avoid zero-width glyph.
428
78cef877
EZ
4292012-02-01 Eli Zaretskii <eliz@gnu.org>
430
431 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
432 first 2 arguments are identical. This makes inserting large
433 output from a subprocess an order of magnitude faster on
434 MS-Windows, where all sbrk'ed memory is always contiguous.
435
97897668
GM
4362012-01-31 Glenn Morris <rgm@gnu.org>
437
438 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 439 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
440 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
441
31fd3586
GM
4422012-01-29 Glenn Morris <rgm@gnu.org>
443
444 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
445
0e24a8b2
CY
4462012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
447
448 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
449
cc0adcb0
CY
4502012-01-28 Chong Yidong <cyd@gnu.org>
451
452 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
453
acc28cb9
CY
4542012-01-26 Chong Yidong <cyd@gnu.org>
455
9c69cfb7
CY
456 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
457
acc28cb9
CY
458 * search.c (Fsearch_forward, Fsearch_backward): Document negative
459 repeat counts (Bug#10507).
460
48da7392
GM
4612012-01-26 Glenn Morris <rgm@gnu.org>
462
463 * lread.c (syms_of_lread): Doc fix.
464
14af5f7f
CY
4652012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
466
467 * coding.c (encode_designation_at_bol): Change return value to
468 EMACS_INT.
469
0b21c100
CY
4702012-01-25 Chong Yidong <cyd@gnu.org>
471
472 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
473
3c2907f7
CY
4742012-01-21 Chong Yidong <cyd@gnu.org>
475
476 * floatfns.c (Fcopysign): Make the second argument non-optional,
477 since nil is not allowed anyway.
478
959ad23f
AS
4792012-01-21 Andreas Schwab <schwab@linux-m68k.org>
480
481 * process.c (read_process_output): Use p instead of XPROCESS (proc).
482 (send_process): Likewise.
483
34a02f46
MR
4842012-01-19 Martin Rudalics <rudalics@gmx.at>
485
486 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
487 (Vwindow_persistent_parameters): Do not use Qstate.
488 Rewrite doc-strings.
34a02f46 489
1259009a 4902012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
491
492 * character.c (char_width): New function.
70d4fdf6
GM
493 (Fchar_width, c_string_width, lisp_string_width):
494 Use char_width (Bug#9496).
25ed9e61 495
6a6ee00d
MR
4962012-01-16 Martin Rudalics <rudalics@gmx.at>
497
498 * window.c (Vwindow_persistent_parameters): New variable.
499 (Fset_window_configuration, save_window_save): Handle persistent
500 window parameters.
501
c85efaf7
EZ
5022012-01-14 Eli Zaretskii <eliz@gnu.org>
503
504 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
505 thrashing the stack of the thread. (Bug#9087)
506
5944709e
PE
5072012-01-12 Paul Eggert <eggert@cs.ucla.edu>
508
509 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
510
e71f5d99
EZ
5112012-01-11 Eli Zaretskii <eliz@gnu.org>
512
513 * xdisp.c (rows_from_pos_range): Handle the case where the
514 highlight ends on a newline. (Bug#10464)
515 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
516 he end column for display of highlight that ends on a newline
517 before a R2L line.
518
ce316182
GM
5192012-01-11 Glenn Morris <rgm@gnu.org>
520
521 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
522 from load-path also when installation-directory is nil. (Bug#10208)
523
5b43da69
GM
5242012-01-10 Glenn Morris <rgm@gnu.org>
525
74cc8ff9
GM
526 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
527
7d8d6e4e
GM
528 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
529 Update template values to be closer to their typical values these days.
5b43da69 530
a0db8d43
EZ
5312012-01-09 Eli Zaretskii <eliz@gnu.org>
532
533 * xdisp.c (rows_from_pos_range): Accept additional argument
534 DISP_STRING, and accept any glyph in a row whose object is that
535 string as eligible for mouse highlight. Fixes mouse highlight of
536 display strings from overlays. (Bug#10464)
537
9a0115ab 5382012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 539
b9110d6a 540 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
541 * fileio.c (auto_saving_dir_umask): New static var.
542 (Fmake_directory_internal): Use it.
543 (do_auto_save_make_dir): Set it, instead of invoking chmod after
544 creating the directory. The old code temporarily assigns
545 too-generous permissions to the directory.
546 (do_auto_save_eh): Clear it.
b9110d6a 547 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
548 that the var is always cleared.
549
6c1bd3f3
EZ
5502012-01-07 Eli Zaretskii <eliz@gnu.org>
551
552 * search.c (scan_buffer): Pass character positions to
553 know_region_cache, not byte positions. (Bug#6540)
554
069d2b50
L
5552012-01-07 LynX <_LynX@bk.ru> (tiny change)
556
557 * w32.c (sys_rename): Report EXDEV when rename of a directory
558 fails because the target is on another logical disk. (Bug#10284)
559
75bf0d33
DB
5602012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
561
562 * xterm.c (x_embed_request_focus): New function.
563
564 * xterm.h: Add prototype.
565
566 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
567
1c6e5a32
GM
5682012-01-05 Glenn Morris <rgm@gnu.org>
569
570 * emacs.c (emacs_copyright): Update short copyright year to 2012.
571
651e947e
EZ
5722012-01-01 Eli Zaretskii <eliz@gnu.org>
573
574 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
575 Load gnutls_transport_set_lowat only if GnuTLS version is below
576 2.11.1.
577 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
578 GnuTLS versions below 2.11.1.
579
3778cdd8
AL
5802011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
581
582 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
583 to the doc string advising against its use for altering the way
584 windows are scrolled.
585
0e5317f7
KH
5862011-12-28 Kenichi Handa <handa@m17n.org>
587
588 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
589 coding-system ASCII compatible only when it does not produce BOM
590 on encoding (Bug#10383).
591
93d5ca1f
JD
5922011-12-26 Jan Djärv <jan.h.d@swipnet.se>
593
594 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
595 can scroll.
596 (create_and_show_popup_menu): Always use menu_position_func for
597 Gtk3 (Bug#10361).
598
ca22b785
AS
5992011-12-24 Andreas Schwab <schwab@linux-m68k.org>
600
601 * callint.c (Fcall_interactively): Don't truncate prompt string.
602
d048e1e6
EZ
6032011-12-23 Eli Zaretskii <eliz@gnu.org>
604
605 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
606 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 607 resumed from there (after widening). (Bug#10360)
d048e1e6 608
5ccaba1f
JD
6092011-12-22 Jan Djärv <jan.h.d@swipnet.se>
610
611 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
612
204ee57f
JD
6132011-12-21 Jan Djärv <jan.h.d@swipnet.se>
614
b81d40f0
JB
615 * nsterm.m (x_free_frame_resources):
616 Release f->output_data.ns->miniimage.
204ee57f
JD
617 (ns_index_color): Fix indentation. Do not retain
618 color_table->colors[i].
619
620 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
621 before returning.
622
623 * nsfns.m (x_set_background_color): Assign return value from
624 ns_index_color to face-background instead of NSColor*.
625 (ns_implicitly_set_icon_type): Fix indentation.
626 Change assignment in for loop to comparison.
627
628 * emacs.c (ns_pool): New variable.
629 (main): Assign ns_pool.
630 (Fkill_emacs): Call ns_release_autorelease_pool.
631
632 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
633 autorelease fdesc, release fdAttrs and tdict.
634 (ns_get_covering_families): Release charset.
635 (ns_findfonts): Release NSFontDescriptor created with new.
636 (ns_uni_to_glyphs): Fix indentation.
637 (setString): Release attrStr before assigning new value.
638
c803b2b7
JD
6392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
640
678f4426
JD
641 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
642 and NS_IMPL_COCOA.
643 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
644 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
645
cd394be1 6462011-12-18 David Reitter <reitter@cmu.edu>
678f4426 647
5fecd5fc
JD
648 * nsterm.m (ns_term_init): Subscribe for notifications
649 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
650 to method trackingNotification in EmacsMenu.
651
652 * nsmenu.m (trackingMenu): New variable.
3771cb17 653 (trackingNotification): New method (from Aquamacs).
5fecd5fc 654 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 655 from Aquamacs (Bug#7030).
678f4426
JD
656
6572011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 658
c803b2b7
JD
659 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
660 (symbol_to_nsstring): Fix indentation.
661 (ns_symbol_to_pb): New function.
cae07000
SM
662 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
663 (Fns_rotate_cut_buffers_internal): Remove.
664 (Fns_store_selection_internal): Rename from
c803b2b7
JD
665 Fns_store_cut_buffer_internal.
666 (ns_get_foreign_selection, Fx_own_selection_internal)
667 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
668 (Fns_get_selection_internal, Fns_store_selection_internal):
669 Use ns_symbol_to_pb and check if return value is nil.
670 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
671 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
672 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
673 renamed to Sns_store_selection_internal.
674 (ns_handle_selection_request): Move code to Fx_own_selection_internal
675 and remove this function.
676 (ns_handle_selection_clear): Remove, never used.
677 (Fx_own_selection_internal): Move code from ns_handle_selection_request
678 here.
679
e1b01a3a
KB
6802011-12-17 Ken Brown <kbrown@cornell.edu>
681
682 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
683 GID is unknown (Bug#10257).
684
2adb6e85
PE
6852011-12-17 Paul Eggert <eggert@cs.ucla.edu>
686
687 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
688 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
689 which caused a build failure on GNU/Linux IA-64. This problem was
690 introduced by my 2011-10-07 patch.
691
d1d7b339
JL
6922011-12-15 Juri Linkov <juri@jurta.org>
693
694 * image.c (imagemagick_error): New function. (Bug#10112)
695 (imagemagick_load_image): Comment out `MagickSetResolution' call.
696 Use `imagemagick_error' where ImageMagick functions return
697 `MagickFalse'.
698 (Fimagemagick_types): Add `Fnreverse' to return the list in the
699 proper order.
700
100d5755
KH
7012011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
702
703 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
704 fill background (Bug#8992).
705
454592a6
MR
7062011-12-13 Martin Rudalics <rudalics@gmx.at>
707
708 * window.c (Vwindow_combination_resize)
709 (Vwindow_combination_limit): Use t instead of non-nil in
710 doc-strings.
61d4b438
MR
711 (Vrecenter_redisplay): Add first sentence of doc-string on
712 separate line.
53524d93 713 (Frecenter): Fix doc-string typo.
454592a6 714
3633e3aa
KH
7152011-12-11 Kenichi Handa <handa@m17n.org>
716
717 * coding.c (Funencodable_char_position): Pay attention to the
718 buffer text relocation (Bug#9389).
719
7b9d523a
JD
7202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
721
722 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
723 gtk_init (Bug#10100).
724
b73189c6
EZ
7252011-12-10 Eli Zaretskii <eliz@gnu.org>
726
727 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
728 IT->string is nil. (Bug#10263)
729
f7dfe5d6
JD
7302011-12-10 Jan Djärv <jan.h.d@swipnet.se>
731
83faebb4
JD
732 * nsterm.h (x_free_frame_resources): Declare.
733
f7dfe5d6
JD
734 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
735 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
736
737 * nsterm.h (ns_get_defaults_value): Declare.
738
739 * nsterm.m (ns_default): Call ns_get_defaults_value.
740
7cd4e72c
EZ
7412011-12-09 Eli Zaretskii <eliz@gnu.org>
742
743 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
744 (Bug#10170)
745
b34d7317
YM
7462011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
747
748 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
749 that where the value of an _OBJC_* symbol points to is in the .bss
750 section (Bug#10240).
751
76470ad1
KH
7522011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
753
754 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 755 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 756
745fff94
KH
7572011-12-08 Kenichi Handa <handa@m17n.org>
758
759 * ftfont.c (get_adstyle_property): Fix previous change
760 (Bug#10233).
761
6e44397c
JB
7622011-12-07 Juanma Barranquero <lekktu@gmail.com>
763
764 * w32.c (init_environment): If no_site_lisp, remove site-lisp
765 dirs from the default value of EMACSLOADPATH (bug#10208).
766
7efa6272
GM
7672011-12-07 Glenn Morris <rgm@gnu.org>
768
769 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
770 installation and source directories as well. (Bug#10208)
771
f6fc4d87
CY
7722011-12-06 Chong Yidong <cyd@gnu.org>
773
774 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
775
2bf26180
GM
7762011-12-06 Glenn Morris <rgm@gnu.org>
777
778 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
779 as an error, not just -1. (Bug#10217)
780
3a6ad4f0
CY
7812011-12-05 Chong Yidong <cyd@gnu.org>
782
783 * keyboard.c (process_special_events): New function.
784 (swallow_events, Finput_pending_p): Use it (Bug#10195).
785
75a3b399
PE
7862011-12-05 Paul Eggert <eggert@cs.ucla.edu>
787
788 * coding.c (encode_designation_at_bol): Don't use uninitialized
789 local variable (Bug#9318).
790
c3c9e25e
KH
7912011-12-05 Kenichi Handa <handa@m17n.org>
792
793 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
794 return Qnil (Bug#8046, Bug#10193).
795
5eb05ea3
KH
7962011-12-05 Kenichi Handa <handa@m17n.org>
797
798 * coding.c (encode_designation_at_bol): New args charbuf_end and
799 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
800 (coding_set_source): Return how many bytes coding->source was
801 relocated.
802 (coding_set_destination): Return how many bytes
803 coding->destination was relocated.
804 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 805 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
806
8072011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
808
809 * coding.c (CODING_CHAR_CHARSET_P): New macro.
810 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
811 macro (Bug#9318).
812
8132011-12-05 Andreas Schwab <schwab@linux-m68k.org>
814
815 The following changes are to fix Bug#9318.
816
a79703f5 817 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
818 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
819 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 820 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 821
7dbda6df
JB
8222011-12-05 Juanma Barranquero <lekktu@gmail.com>
823
824 * lisp.h (process_quit_flag): Fix external declaration.
825
6d5eb5b0
SM
8262011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
827
828 Don't macro-inline non-performance-critical code.
829 * eval.c (process_quit_flag): New function.
830 * lisp.h (QUIT): Use it.
831
a0c3fad0
JD
8322011-12-04 Jan Djärv <jan.h.d@swipnet.se>
833
834 * nsfns.m (get_geometry_from_preferences): New function.
835 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
836
6c07aac2
AS
8372011-12-04 Andreas Schwab <schwab@linux-m68k.org>
838
839 * emacs.c (Qkill_emacs): Define.
840 (syms_of_emacs): Initialize it.
841 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
842 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
843 (quit_throw_to_read_char): Add parameter `from_signal'.
844 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
845 * lisp.h (QUIT): Call Fkill_emacs if requested.
846
c052ead4
JD
8472011-12-03 Jan Djärv <jan.h.d@swipnet.se>
848
849 * widget.c (update_wm_hints): Return if wmshell is null.
850 (widget_update_wm_size_hints): New function.
851
852 * widget.h (widget_update_wm_size_hints): Declare.
853
854 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
855 widget_update_wm_size_hints (Bug#10104).
856
9e49252b
EZ
8572011-12-03 Eli Zaretskii <eliz@gnu.org>
858
859 * xdisp.c (handle_invisible_prop): If the invisible text ends just
860 before a newline, prepare the bidi iterator for consuming the
861 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 862 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 863
02b16839
JL
8642011-12-02 Juri Linkov <juri@jurta.org>
865
866 * search.c (Fword_search_regexp): New Lisp function created from
867 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
868 (Fword_search_backward, Fword_search_forward)
869 (Fword_search_backward_lax, Fword_search_forward_lax):
870 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
871 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
872
0068070e
SM
8732011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
874
875 * fileio.c (Finsert_file_contents): Move after-change-function call
876 to before the "handled:" label, since all "goto handled" appear in
877 cases where the *-change-functions have already been properly called
878 (bug#10117).
879
3360a3fc
AS
8802011-12-01 Andreas Schwab <schwab@linux-m68k.org>
881
882 * keyboard.c (interrupt_signal): Don't call kill-emacs when
883 waiting for input. (Bug#10169)
884
73d6c093
EZ
8852011-11-30 Eli Zaretskii <eliz@gnu.org>
886
887 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
888 verifies glyph row's hash code--we have just reallocated the
889 glyphs, so their contents can be complete garbage. (Bug#10164)
890
febe6bea
JB
8912011-11-30 Juanma Barranquero <lekktu@gmail.com>
892
893 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
894
801a4313
EZ
8952011-11-30 Eli Zaretskii <eliz@gnu.org>
896
897 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
898 attributes are tested _before_ calling verify_row_hash, to protect
899 against GCC re-ordering of the tests. (Bug#10164)
900
2b56b87e
JD
9012011-11-29 Jan Djärv <jan.h.d@swipnet.se>
902
903 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
904
905 * xterm.c (handle_one_xevent): Only set async_visible and friends
906 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 907 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
908 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
909
dbf31225
PE
9102011-11-28 Paul Eggert <eggert@cs.ucla.edu>
911
912 Remove GCPRO-related macros that exist only to avoid shadowing locals.
913 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
914 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
915 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
916 All uses changed to use GCPRO1 etc.
917 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
918 Revert to old implementation (i.e., before 2011-03-11).
919
1305621b
YM
9202011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
921
922 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
923 of scroll runs so as to avoid assigning disabled bogus rows and
924 unnecessary graphics copy operations.
925
8c9afb46
EZ
9262011-11-27 Eli Zaretskii <eliz@gnu.org>
927
928 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
929 (snprintf) [_MSC_VER]: Redirect to _snprintf.
930 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
931 (malloc, free, realloc, calloc): Redirect to e_* only when
932 compiling Emacs.
933
934 * lisp.h (GCTYPEBITS): Move before first use.
935 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
936 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
937 this macro definition.
938
939 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
940 _MSC_VER.
941
54e9e3bf
JD
9422011-11-27 Jan Djärv <jan.h.d@swipnet.se>
943
6d5eb5b0
SM
944 * gtkutil.c (xg_create_frame_widgets):
945 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
946 present with Gtk+ 2.0.
947
83aca1cb
PE
9482011-11-26 Paul Eggert <eggert@cs.ucla.edu>
949
950 * fileio.c (Finsert_file_contents): Undo previous change; see
951 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
952
5b76caa4
PE
9532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
954
955 Rename locals to avoid shadowing.
956 * fileio.c (Finsert_file_contents):
957 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
958 * process.c (wait_reading_process_output):
959 Rename inner 'proc' to 'p' to avoid shadowing.
960 Indent for consistency with usual Emacs style.
961
8c535114
EZ
9622011-11-25 Eli Zaretskii <eliz@gnu.org>
963
964 * xdisp.c (redisplay_window): If cursor row is not fully visible
965 after recentering, and scroll-conservatively is set to a large
966 number, scroll window by a few more lines to make the cursor fully
967 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
968 (start_display): Don't move to the next line if the display should
969 start at a newline that is part of a display vector or an overlay
970 string. (Bug#10119)
8c535114 971
fa4fdb5c
JL
9722011-11-24 Juri Linkov <juri@jurta.org>
973
974 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
975 after the `MagickPingImage' call. (Bug#10112)
976
90ec88df
CY
9772011-11-23 Chong Yidong <cyd@gnu.org>
978
979 * window.c (Fcoordinates_in_window_p): Accept only live windows.
980
56e2e794
MR
9812011-11-23 Martin Rudalics <rudalics@gmx.at>
982
983 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
984 making another buffer current. (Bug#10114)
985
b6e64c41
GM
9862011-11-23 Glenn Morris <rgm@gnu.org>
987
988 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
989
6b21de18
CY
9902011-11-23 Chong Yidong <cyd@gnu.org>
991
992 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
993 using it (Bug#5984).
994
b12cd789
EZ
9952011-11-22 Eli Zaretskii <eliz@gnu.org>
996
997 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
998 and header-lines, as they don't have one computed for them.
999 (Bug#10098)
1000
1001 * .gdbinit (prow): Make displayed values more self-explaining.
1002 Add row's hash code.
1003
261b6fd4
LMI
10042011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1005
1006 * process.c (wait_reading_process_output): Fix asynchrounous
1007 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1008 (wait_reading_process_output): Add comment and URL.
261b6fd4 1009
e7cfd277
JD
10102011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1011
1012 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1013
a9b9b7f5
CY
10142011-11-21 Chong Yidong <cyd@gnu.org>
1015
1016 * window.c (Fnext_window, Fprevious_window): Doc fix.
1017
b0d15b4f
SM
10182011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1019
1020 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1021
fe7a3057
JB
10222011-11-20 Juanma Barranquero <lekktu@gmail.com>
1023
1024 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1025
d2999b1a
MR
10262011-11-20 Martin Rudalics <rudalics@gmx.at>
1027
1028 * window.c (Fset_window_combination_limit): Rename argument
1029 STATUS to LIMIT.
1030 (Vwindow_combination_limit): Remove "status" from doc-string.
1031
d5ff9cd0
AS
10322011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1033
1034 * m/ibms390.h: Remove.
1035 * m/ibms390x.h: Don't include "ibms390.h".
1036
a5bb9bd3
SM
10372011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1038
1039 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1040 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1041
cd1181db
JB
10422011-11-20 Juanma Barranquero <lekktu@gmail.com>
1043
1044 * casetab.c (Fset_case_table):
1045 * charset.c (Fcharset_after): Fix typos.
1046
615a3b8d 10472011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1048
17e845af
PE
1049 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1050 Otherwise, valgrind does not work on some platforms.
1051 Problem reported by Andreas Schwab in
6a0bf43d
PE
1052 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1053 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1054 is set, removing the need for VIRT_ADDRESS_VARIES.
1055 (PURE_P): Use a more-efficient implementation that needs just one
1056 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1057 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1058 to 4 (xorl, subq, cmpq, setbe).
1059 * alloc.c (pure): Always extern now, since that's the
1060 VIRT_ADDR_VARIES behavior.
1061 (PURE_POINTER_P): Use a single comparison, not two, for
1062 consistency with the new puresize.h.
1063 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1064 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1065 Remove VIRT_ADDR_VARIES no longer needed.
1066
f8fe6f96
EZ
10672011-11-19 Eli Zaretskii <eliz@gnu.org>
1068
1069 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1070 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1071 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1072 behave as if the cursor position were at the window margin.
1073
1074 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1075 and the cursor position is out of bounds, behave as if the cursor
1076 position were at the window margin. (Bug#10075)
1077
df05a53c
CY
10782011-11-18 Chong Yidong <cyd@gnu.org>
1079
1080 * window.c (Fwindow_combination_limit): Make first argument
1081 non-optional, since it is meaningless for live windows like the
1082 selected window.
1083
2071918e
DA
10842011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1085
1086 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1087
b50a28de
SM
10882011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1089
1090 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1091 (graft_intervals_into_buffer): Simplify.
1092
015137db
EZ
10932011-11-18 Eli Zaretskii <eliz@gnu.org>
1094
1095 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1096 hash values of the two rows.
1097 (copy_row_except_pointers): Preserve the used[] arrays and the
1098 hash values of the two rows. (Bug#10035)
68c95424 1099 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1100
1101 * xdisp.c (row_hash): New function, body extracted from
1102 compute_line_metrics.
1103 (compute_line_metrics): Call row_hash, instead of computing the
1104 hash code inline.
1105
1106 * dispnew.c (verify_row_hash): Call row_hash for computing the
1107 hash code of a row, instead of duplicating code from xdisp.c.
1108
1109 * dispextern.h (row_hash): Add prototype.
1110
a2addb04
TH
11112011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1112
1113 * frame.c (delete_frame): Don't delete the terminal when the last
1114 X frame is closed if emacs is built with GTK toolkit.
1115
df85d315
JB
11162011-11-17 Juanma Barranquero <lekktu@gmail.com>
1117
1118 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1119
a0c2d0ae
MR
11202011-11-17 Martin Rudalics <rudalics@gmx.at>
1121
1122 * window.c (Vwindow_splits): Rename to
1123 Vwindow_combination_resize. Suggested by Juri Linkov.
1124 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1125 of Vwindow_splits.
1126
58179cce
JB
11272011-11-16 Juanma Barranquero <lekktu@gmail.com>
1128
7877f373
JB
1129 * nsfns.m (Fns_font_name):
1130 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1131
b6f67890
MR
11322011-11-16 Martin Rudalics <rudalics@gmx.at>
1133
1134 * window.h (window): Rename slot "nest" to "combination_limit".
1135 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1136 (Fset_window_nest): Rename to Fset_window_combination_limit.
1137 (Vwindow_nest): Rename to Vwindow_combination_limit.
1138 (recombine_windows, make_parent_window, make_window)
1139 (Fsplit_window_internal, saved_window)
1140 (Fset_window_configuration, save_window_save): Rename all
1141 occurrences of window_nest to window_combination_limit.
1142
c7015153
JB
11432011-11-15 Juanma Barranquero <lekktu@gmail.com>
1144
1145 * image.c (imagemagick_load_image): Fix typo.
1146
322ad6ec
EZ
11472011-11-14 Eli Zaretskii <eliz@gnu.org>
1148
1149 * xdisp.c (display_line): Move the call to
1150 highlight_trailing_whitespace before the call to
1151 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1152 faces of all the glyphs to compute ROW's hash value.
1153 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1154
f067b8ec
JB
11552011-11-14 Juanma Barranquero <lekktu@gmail.com>
1156
1157 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1158 just return (bug#10044).
1159
1e5b2111
EZ
11602011-11-12 Eli Zaretskii <eliz@gnu.org>
1161
7ef3cbd5
EZ
1162 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1163 with user-defined heap size. Bump the default size of the temacs
1164 heap to 27MB, to avoid memory warning when running temacs.
1165 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1166
1e5b2111
EZ
1167 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1168 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1169 (verify_row_hash) [XASSERTS]: New function.
1170 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1171 that the hash value of glyph rows is correct.
1e5b2111 1172
89d61221
MR
11732011-11-12 Martin Rudalics <rudalics@gmx.at>
1174
1175 * window.h (window): Remove splits slot.
1176 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1177 (Fdelete_other_windows_internal, make_parent_window)
1178 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1179 (Fset_window_configuration, save_window_save): Don't deal with
1180 split status of windows.
1181 (saved_window): Remove splits slot.
1182 (Vwindow_splits): Rewrite doc-string.
1183
97f18cc8
JD
11842011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1185
1186 * xfns.c (unwind_create_frame):
1187 * nsfns.m (unwind_create_frame):
1188 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1189 Vframe_list (Bug#9999).
1190
22a648b4
DA
11912011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1192
0b381c7e 1193 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1194
659afede
KH
11952011-11-11 Kenichi Handa <handa@m17n.org>
1196
1197 * callproc.c (Fcall_process): Set the member dst_multibyte of
1198 process_coding.
1199
9ac0394b
KH
12002011-11-11 Johan Bockgård <bojohan@gnu.org>
1201
1202 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1203 avoid a crash (bug#9496).
1204
2fbdc249
CY
12052011-11-09 Chong Yidong <cyd@gnu.org>
1206
1207 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1208 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1209
ac6b1f81
PE
12102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1213
09db192c
PE
12142011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 Avoid some portability problems by eschewing 'extern inline' functions.
1217 The trivial performance wins aren't worth the portability hassles; see
1218 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1219 et seq.
1220 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1221 (window_box_width, window_box_left, window_box_left_offset)
1222 (window_box_right, window_box_right_offset): Undo previous change,
1223 by removing the "extern"s.
1224 * intervals.c (adjust_intervals_for_insertion)
1225 (adjust_intervals_for_deletion): Undo previous change,
1226 making these static again.
1227 (offset_intervals, temp_set_point_both, temp_set_point)
1228 (copy_intervals_to_string): No longer inline.
1229 * xdisp.c (window_text_bottom_y, window_box_width)
1230 (window_box_height, window_box_left_offset)
1231 (window_box_right_offset, window_box_left, window_box_right)
1232 (window_box): No longer inline.
1233
105216ed
CY
12342011-11-08 Chong Yidong <cyd@gnu.org>
1235
1236 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1237 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1238 Signal an error if not a live window.
105216ed
CY
1239 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1240 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1241
ae9e237f
JB
12422011-11-07 Juanma Barranquero <lekktu@gmail.com>
1243
1244 * lisp.h (syms_of_abbrev): Remove declaration.
1245 Reported by CHENG Gao <chenggao@royau.me>.
1246
c7aa8333
EZ
12472011-11-07 Eli Zaretskii <eliz@gnu.org>
1248
1249 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1250 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1251 of temacs in GUI mode.
1252
be7f5545
MR
12532011-11-07 Martin Rudalics <rudalics@gmx.at>
1254
1255 * window.h: Declare delete_all_child_windows instead of
1256 delete_all_subwindows.
1257 * window.c (Fwindow_nest, Fset_window_nest)
1258 (Fset_window_new_total, Fset_window_new_normal)
1259 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1260 (delete_all_subwindows): Rename to delete_all_child_windows.
1261 (Fdelete_other_windows_internal, Fset_window_configuration):
1262 Call delete_all_child_windows instead of delete_all_subwindows.
1263 * frame.c (delete_frame): Call delete_all_child_windows instead
1264 of delete_all_subwindows.
1265
ca78dc43
PE
12662011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1267
1268 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1269 This is also needed for porting to any host where GC_MARK_STACK is
1270 not GC_MAKE_GCPROS_NOOPS.
1271 (which_symbols): Use it.
1272
a0241d01
KH
12732011-11-07 Kenichi Handa <handa@m17n.org>
1274
1275 * coding.c (coding_set_destination): Check coding->src_pos only
1276 when coding->src_object is a buffer (bug#9910).
1277
1278 * process.c (send_process): Set the member src_multibyte of coding
1279 to 0 (bug#9911) when sending a unibyte text.
1280
1281 * callproc.c (Fcall_process): Set the member src_multibyte of
1282 process_coding to 0 (bug#9912).
1283
a64bfdfa 12842011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1285
1286 * xmenu.c (cleanup_widget_value_tree): New function.
1287 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1288 calling free_menubar_widget_value_tree directly (Bug#9830).
1289
cb41b32a
PE
12902011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 Fix some portability problems with 'inline'.
1293 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1294 (window_box_width, window_box_left, window_box_left_offset)
1295 (window_box_right, window_box_right_offset): Declare extern.
1296 Otherwise, these inline functions do not conform to C99 and
1297 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1298 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1299 * intervals.c (adjust_intervals_for_insertion)
1300 (adjust_intervals_for_deletion): Now extern, because otherwise the
1301 extern inline functions 'offset_intervals' couldn't refer to it.
1302 (static_offset_intervals): Remove.
1303 (offset_intervals): Rewrite using the old contents of
1304 static_offset_intervals. The old version didn't conform to C99
1305 because an extern inline function contained a reference to an
1306 identifier with static linkage.
1307
b7041366
AS
13082011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1309
1310 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1311 GC.
1312
88a37c4d
EZ
13132011-11-06 Eli Zaretskii <eliz@gnu.org>
1314
1315 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1316 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1317 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1318 return Qleft_to_right.
1319
49745b39
CY
13202011-11-06 Chong Yidong <cyd@gnu.org>
1321
1322 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1323 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1324 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1325 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1326 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1327 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1328 (Fwindow_vscroll): Doc fix.
1329 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1330 argument, since it makes no sense to pass a live window and for
1331 consistency with window-child.
1332
1f05cd82
CS
13332011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1334
1335 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1336 support MSVC.
1337
22610910
JR
13382011-11-05 Jason Rumney <jasonr@gnu.org>
1339
1340 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1341 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1342 fonts (Bug#6029).
1343 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1344 bitwise arithmetic preventing use of unicode-sip and non-truetype
1345 opentype fonts.
1346
a06776b2
EZ
13472011-11-05 Eli Zaretskii <eliz@gnu.org>
1348
3ad924ba
EZ
1349 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1350 "emacs"-only part.
1351
a06776b2
EZ
1352 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1353 initialization code to keep similarity to xfns.c after changes
1354 from 2011-11-05.
1355
c9e7db78
JD
13562011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1357
a97f8f3f
JD
1358 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1359 (unwind_create_frame): New function (Bug#9943).
1360 (Fx_create_frame): Restructure code to be more similar to the one in
1361 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1362 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1363 Move terminal->reference_count++ just before making the frame official
1364 (Bug#9943).
1365
1366 * nsterm.m (x_free_frame_resources): New function.
1367 (x_destroy_window): Move code to x_free_frame_resources.
1368
c9e7db78 1369 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1370 (Fx_create_frame, x_create_tip_frame):
1371 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1372 official. Move initialization of image_cache_refcount and
1373 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1374
a6fc3b5c
EZ
13752011-11-05 Eli Zaretskii <eliz@gnu.org>
1376
1377 Support MSVC build with newer versions of Visual Studio.
1378 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1379 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1380 nt/gmake.defs.
1381
1382 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1383 which are not supported by MSVC.
1384 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1385 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1386 bitfields.
1387 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1388 types in bitfields.
1389 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1390
1391 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1392
58179cce 13932011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1394
1395 Support MSVC build with newer versions of Visual Studio.
1396 * w32.c: Don't include w32api.h for MSVC.
1397 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1398
1399 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1400 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1401 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1402 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1403 e_* cousins.
1404 (alloca) [_MSC_VER]: Define to _alloca.
1405
1406 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1407
1408 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1409
a58c13ed
EZ
14102011-11-04 Eli Zaretskii <eliz@gnu.org>
1411
1412 * xdisp.c (note_mouse_highlight): If either of
1413 previous/next-single-property-change returns nil, treat that as
1414 the beginning or the end of the buffer. (Bug#9955)
1415
fe0b6370
JD
14162011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1417
a58c13ed 1418 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1419 label is not null (Bug#9951).
1420 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1421 may be NULL.
1422
89bd5ee1
EZ
14232011-11-04 Eli Zaretskii <eliz@gnu.org>
1424
1425 * window.c (Fwindow_body_size): Mention in the doc string that the
1426 return value is in frame's canonical units. (Bug#9949)
1427
84c3edb9
EZ
14282011-11-03 Eli Zaretskii <eliz@gnu.org>
1429
4e2fb5c7
EZ
1430 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1431
84c3edb9 1432 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1433 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1434 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1435
bc17a887
EZ
14362011-11-01 Eli Zaretskii <eliz@gnu.org>
1437
1438 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1439 Don't stop backward scan on the continuation glyph, even though
1440 its CHARPOS is positive.
6d5eb5b0
SM
1441 (mouse_face_from_buffer_pos, note_mouse_highlight):
1442 Rename cover_string to disp_string.
bc17a887 1443
4ee88440
MR
14442011-11-01 Martin Rudalics <rudalics@gmx.at>
1445
1446 * window.c (temp_output_buffer_show): Don't use
1447 Vtemp_buffer_show_specifiers.
1448 (Vtemp_buffer_show_specifiers): Remove unused variable.
1449
c2ff3c02
EZ
14502011-10-30 Eli Zaretskii <eliz@gnu.org>
1451
1452 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1453 past the beginning of the current glyph matrix.
1454
58179cce 14552011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1456
1457 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1458 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1459 HAVE_GTK3 (Bug#9869).
b77a6a7f 1460
3b574623
JD
1461 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1462 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1463
b77a6a7f
JD
1464 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1465
1466 * xterm.c: Declare x_handle_net_wm_state to return int.
1467 (handle_one_xevent): Check if we are iconified but don't have
1468 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1469 (get_current_wm_state): Return non-zero if not hidden,
1470 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1471 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1472 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1473 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1474
196e41e4
PE
14752011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1478 so that this new function doesn't get optimized away by a
1479 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1480
021f2e1a
AS
14812011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1482
1483 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1484
8b058d44
EZ
14852011-10-29 Eli Zaretskii <eliz@gnu.org>
1486
1487 Fix the `xbytecode' command.
1488 * .gdbinit (xprintbytestr): New command.
b50a28de 1489 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1490 (xbytecode): Print the byte-code string as well.
1491
4452fb80
EZ
14922011-10-29 Kim Storm <storm@cua.dk>
1493
8b058d44
EZ
1494 * alloc.c (which_symbols): New function.
1495
21b72067
AS
14962011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1497
1498 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1499 line. (Bug#9903)
1500
83ed7b5c
GM
15012011-10-29 Glenn Morris <rgm@gnu.org>
1502
1503 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1504 Not clear what it was for, and it causes various bugs. (Bug#9839)
1505
5a7a728b
EZ
15062011-10-28 Eli Zaretskii <eliz@gnu.org>
1507
1508 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1509 possible random value that matches one of those tested as
1510 condition to clear the mouse face.
1511
d3d0842f
CY
15122011-10-28 Chong Yidong <cyd@gnu.org>
1513
1514 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1515
31b39d13
DN
15162011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1517
1518 * window.c (make_window): Initialize phys_cursor_on_p.
1519
9aba6043
SM
15202011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1521
1522 * lisp.h (struct Lisp_Symbol): Update comments.
1523
c20992f4
JB
15242011-10-28 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1527
db4f02f2
EZ
15282011-10-28 Eli Zaretskii <eliz@gnu.org>
1529
1530 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1531 <oslsachem@gmail.com> for helping to debug this.
1532
1533 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1534 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1535 (g_b_init_get_glyph_outline_w): New static variables.
1536 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1537 (GetGlyphOutlineW_Proc): New typedefs.
1538 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1539 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1540 New functions.
1541 (w32font_open_internal, compute_metrics):
1542 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1543 instead of calling the "wide" APIs directly.
1544
1545 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1546
1547 * w32.h (syms_of_w32font): Add prototype.
1548
87e68db4
JB
15492011-10-27 Juanma Barranquero <lekktu@gmail.com>
1550
1551 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1552 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1553 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1554 (Fmove_to_window_line): Doc fix.
1555
435c1d67
CY
15562011-10-27 Chong Yidong <cyd@gnu.org>
1557
1558 * process.c (make_process): Set gnutls_state to NULL.
1559
1560 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1561 non-NULL, regardless of GNUTLS_INITSTAGE.
1562 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1563 an error. Set process slots as soon as we allocate them.
1564
1565 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1566
9c6c6f49
CY
15672011-10-27 Chong Yidong <cyd@gnu.org>
1568
9aba6043
SM
1569 * gnutls.c (emacs_gnutls_deinit): New function.
1570 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1571 (Fgnutls_deinit, Fgnutls_boot): Use it.
1572
1573 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1574 (deactivate_process): Call emacs_gnutls_deinit.
1575
657d08d3
JB
15762011-10-27 Juanma Barranquero <lekktu@gmail.com>
1577
1578 * image.c (x_create_x_image_and_pixmap):
1579 * w32.c (sys_rename, w32_delayed_load):
1580 * w32font.c (fill_in_logfont):
1581 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1582
5430d399
JB
15832011-10-26 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * w32fns.c (w32_default_color_map): New function,
1586 extracted from Fw32_default_color_map.
a7ef684b 1587 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1588
fe0055fa
PE
15892011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1590
1591 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1592
e6346438
SM
15932011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1594
1595 * keyboard.c (test_undefined): New function (bug#9751).
1596 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1597
e112cc37
ET
15982011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1599
1600 * sysdep.c (init_sys_modes): Fix the check for the controlling
1601 terminal (Bug#6649).
1602
7b5d6677
EZ
16032011-10-20 Eli Zaretskii <eliz@gnu.org>
1604
1605 * dispextern.h (struct bidi_it): New member next_en_type.
1606
1607 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1608 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1609 current character, check also for next_en_type being WEAK_EN.
1610 (bidi_resolve_weak): Don't enter the expensive loop if the current
1611 position is before next_en_pos. Record the bidi type of the first
1612 non-ET, non-BN character we find, in addition to its position.
1613 (bidi_level_of_next_char): Invalidate next_en_type when
1614 next_en_pos is over-stepped.
1615
7da0b018
PE
16162011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1617
1618 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1619 * editfns.c: Rewrite current-time-zone so that it invokes
1620 the equivalent of (format-time-string "%Z") to get the time zone name.
1621 This fixes a bug when the time zone name contains characters that
1622 need converting from the system time locale to Emacs internal format.
1623 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1624 that patch fixed format-time-string to do the conversion, but
1625 I forgot to fix current-time-zone.
1626 (format_time_string): New function, containing most of
1627 what Fformat_time_string used to contain.
1628 (Fformat_time_string): Rewrite in terms of format_time_string.
1629 This doesn't change this function's behavior.
1630 (current-time-zone): Rewrite to use format_time_string.
1631 This fixes the bug reported by Michael Schierl in
1632 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1633 Jason Rumney's 2007-06-07 change worked around this bug, but
1634 didn't fix it.
1635 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1636
8547b010
EZ
16372011-10-19 Eli Zaretskii <eliz@gnu.org>
1638
1639 * xdisp.c (start_display): If the character at POS is displayed
1640 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1641 (try_window_reusing_current_matrix): If a line ends in a display
1642 vector or the next line starts in a display vector, continue
1643 redrawing the window even though the character position of
1644 start_row was reached.
8547b010
EZ
1645 (Bug#9771, part 2)
1646
4e948d15
CY
16472011-10-18 Chong Yidong <cyd@gnu.org>
1648
1649 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1650 with nobreak-char-display too.
1651
4787455f
EZ
16522011-10-18 Eli Zaretskii <eliz@gnu.org>
1653
1654 Fix part 3 of bug#9771.
1655 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1656 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1657 non-neutral characters if the current character is a paragraph
1658 separator (a.k.a. Newline). This avoids running the same
1659 expensive loop twice, once when we consume the preceding newline
1660 and the other time when the line actually needs to be displayed.
1661 Avoid the loop when we see neutrals on the base embedding level
1662 following a character whose directionality is the same as the
1663 paragraph's. This avoids running the expensive loop when a line
1664 ends in a long sequence of neutrals, like control characters.
1665 Add assertion against STRONG_AL type. Slightly rearrange code
1666 that determines the type of a neutral given the first non-neutral
1667 that follows it.
1668 (bidi_level_of_next_char): Set next_en_pos to zero when
1669 invalidating its info.
1670
2c91f553
EZ
16712011-10-17 Eli Zaretskii <eliz@gnu.org>
1672
1673 * xdisp.c (push_display_prop): Determine whether to record string
1674 or buffer position by IT->string, not by IT->method. Allow
1675 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1676 (move_it_vertically_backward): Don't look for character position
1677 immediately after the newline when in a continuation line.
1678 (Bug#9771, part 1)
2c91f553 1679
c7b08b0d
MR
16802011-10-15 Martin Rudalics <rudalics@gmx.at>
1681
1682 * window.c (coordinates_in_window): Rewrite and delabelize
1683 vertical border check. (Bug#5357) (Bug#9618)
1684
6b02f655
SM
16852011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1686
1687 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1688 errors in XSetWindowBorder (bug#9310).
1689
81d40c92
DA
16902011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1691
1692 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1693 avoid crash when xmalloc overrun checking is enabled.
1694
d4172c3b
EZ
16952011-10-13 Eli Zaretskii <eliz@gnu.org>
1696
1697 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1698 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1699 cursor motion with <left> and <right> arrow keys.
1700
1701 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1702 some callers set that themselves.
1703
b00eea75
EZ
17042011-10-12 Eli Zaretskii <eliz@gnu.org>
1705
1706 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1707 display string and the previous row comes from the same string and
1708 is empty. (Bug#9739) (Bug#9738)
1709
8fe012c4
SM
17102011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1711
1712 * doc.c (get_doc_string): Encode file name (bug#9735).
1713
0074aef2
EZ
17142011-10-12 Eli Zaretskii <eliz@gnu.org>
1715
79beb178
EZ
1716 * bidi.c (bidi_level_of_next_char):
1717 * xdisp.c (get_visually_first_element): Remove old incorrect
1718 comments regarding the Unicode Line Separator character.
1719
0074aef2
EZ
1720 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1721
6e4b3fbe
DA
17222011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1723
1724 * alloc.c (Fgc_status): Do not access beyond zombies array
1725 boundary if nzombies > MAX_ZOMBIES.
1726 * alloc.c (dump_zombies): Add missing format specifier.
1727
0324f3af
PE
17282011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1729
b5525cac
PE
1730 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1731 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1732
0324f3af
PE
1733 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1734 Some packages use them to denote characters with modifiers.
1735
e9b5f888
AS
17362011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1737
1738 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1739 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1740 matching a pp-number. Rename parameter var to var1.
1741
127827c0
SM
17422011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1743
1744 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1745
c8fd3bd0
GM
17462011-10-08 Glenn Morris <rgm@gnu.org>
1747
1748 * callint.c (Fcall_interactively): Give a more explicit error for the
1749 'c' case with a non-character input. (Bug#8479)
1750
352ec8ff
EZ
17512011-10-08 Eli Zaretskii <eliz@gnu.org>
1752
03669ccb
EZ
1753 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1754 lines.
7061c986
EZ
1755 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1756 lines that are hscrolled on the left.
03669ccb 1757
352ec8ff
EZ
1758 * dispnew.c (buffer_posn_from_coords): Account for a possible
1759 presence of header-line. (Bug#4426)
1760
a66cfb1c
SM
17612011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1762
6b02f655
SM
1763 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1764 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1765
7c5ee88e
PE
17662011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1769 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1770 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1771 this makes Emacs dump core during garbage collection on rare
1772 occasions. sizeof is obviously inferior to offsetof here, so
1773 stick with offsetof.
1774 (GC_POINTER_ALIGNMENT): New macro.
1775 (mark_memory): Omit 3rd (offset) arg; caller changed.
1776 Don't assume EMACS_INT alignment is the same as pointer alignment.
1777
df1bbe5b
SM
17782011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1779
1780 * keyboard.c (read_key_sequence_remapped): New var.
1781 (read_key_sequence): Compute remapping in the right buffer.
1782 (command_loop_1): Use read_key_sequence's remapping directly.
1783
51553db6
SM
17842011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1785
32c1fffd
SM
1786 * dired.c (file_name_completion): Don't expand file name.
1787 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1788 before checking file name handler.
1789
51553db6
SM
1790 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1791 they've been requested explicitly (bug#9591).
1792
b6bd1599 17932011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1794
1795 * keymap.c (Fsingle_key_description): Use make_specified_string
1796 instead of build_string to build string from push_key_description.
1797 (Bug#5193)
1798
f701dc2a
PE
17992011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1800
4222c55d
PE
1801 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1802 This fixes a Y2038 bug on 64-bit hosts.
1803 * buffer.c (reset_buffer):
1804 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1805 (Fclear_buffer_auto_save_failure):
1806 Use 0, not -1, to represent an unset failure time, since time_t
1807 might not be signed.
1808
f701dc2a
PE
1809 Remove dependency on glibc malloc internals.
1810 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1811 Move back here from lisp.h, but with their new implementations.
1812 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1813 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1814 * charset.c (charset_table_init): New static var.
1815 (syms_of_charset): Use it instead of xmalloc. This removes a
1816 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1817 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1818 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1819 Move back to alloc.c.
1820 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1821 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1822
9ceebf39
JD
18232011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1824
1825 * nsterm.m (windowDidResize): Call x_set_window_size only when
1826 ns_in_resize is true. Otherwise set pixelwidth/height and
1827 call change_frame_size (Bug#9628).
1828
cb993c58
PE
18292011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1830
3930c88b
PE
1831 Port --enable-checking=all to Fedora 14 x86-64.
1832 * charset.c (syms_of_charset): Also account for glibc malloc's
1833 internal overhead when calculating the initial malloc maximum.
1834
cb993c58
PE
1835 Port --enable-checking=all to Fedora 14 x86.
1836 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1837 Move to lisp.h.
1838 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1839 (overrun_check_realloc, overrun_check_free):
1840 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1841 That way, xmalloc returns a properly-aligned pointer even if
1842 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1843 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1844 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1845 into account when calculating the initial malloc maximum.
1846 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1847 Move here from alloc.c, so that charset.c can use it too.
1848 Properly align; the old code wasn't right for common 32-bit hosts
1849 when configured with --enable-checking=all.
1850 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1851 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1852
31bed486
EZ
18532011-09-29 Eli Zaretskii <eliz@gnu.org>
1854
04c70788 1855 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1856 use EDOM.
1857
fbcaa2f3
EZ
18582011-09-28 Eli Zaretskii <eliz@gnu.org>
1859
1860 * xdisp.c (compute_display_string_end): If there's no display
1861 string at CHARPOS, return -1.
1862
1863 * bidi.c (bidi_fetch_char): When compute_display_string_end
1864 returns a negative value, treat the character as a normal
1865 character not covered by a display string. (Bug#9624)
1866
a239d4e9
JB
18672011-09-28 Juanma Barranquero <lekktu@gmail.com>
1868
1869 * lread.c (Fread_from_string): Fix typo in docstring.
1870
88652fd5
EZ
18712011-09-27 Eli Zaretskii <eliz@gnu.org>
1872
1873 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1874 newline, reseat the iterator instead of bidi-iterating there one
1875 character at a time. (Bug#9610)
32c1fffd
SM
1876 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1877 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1878
ed497dd4
AS
18792011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1880
1881 * lread.c (readevalloop): Use correct code for NBSP.
1882 (read1): Likewise. (Bug#9608)
1883
b2bf61aa
MA
18842011-09-25 Michael Albinus <michael.albinus@gmx.de>
1885
1886 * dbusbind.c (Fdbus_register_signal): When service is not
1887 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1888
32bbb17c
GM
18892011-09-25 Glenn Morris <rgm@gnu.org>
1890
1891 * buffer.c (truncate-lines): Doc fix.
1892
94e0933e
CY
18932011-09-24 Chong Yidong <cyd@stupidchicken.com>
1894
1895 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1896 (Fset_window_next_buffers): Doc fix.
1897
cddde921
GM
18982011-09-24 Glenn Morris <rgm@gnu.org>
1899
1900 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1901
1260aef1
PE
19022011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1903
25b4bfa0
PE
1904 Fix minor problems found by static checking.
1905 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1906 * indent.c (Fvertical_motion): Fix == vs = typo.
1907
e3cbd34b
EZ
19082011-09-24 Eli Zaretskii <eliz@gnu.org>
1909
a66cfb1c
SM
1910 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1911 Default value is now t. Doc fix.
6bf7006f 1912
e3cbd34b 1913 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1914 logic when moving up, not only when moving down. Fix the
e3cbd34b 1915 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1916 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1917
1918 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1919 CHARPOS is covered by a display string which includes newlines.
1920 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1921 is covered by a display string with embedded newlines.
1922
a3de0cbd
MA
19232011-09-24 Michael Albinus <michael.albinus@gmx.de>
1924
1925 * dbusbind.c (Fdbus_register_signal): Add match rule to
1926 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1927 (Fdbus_register_method, Vdbus_registered_objects_table):
1928 Fix docstring.
a3de0cbd 1929
b260039d
JM
19302011-09-24 Jim Meyering <meyering@redhat.com>
1931
32c1fffd 1932 do not ignore write error for any output size
b260039d
JM
1933 The previous change was incomplete.
1934 While it makes emacs --batch detect the vast majority of stdout
1935 write failures, errors were still ignored whenever the output size is
1936 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1937 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1938 && echo FAIL: ignored write error
1939 FAIL: ignored write error
1940 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1941 && echo FAIL: ignored write error
1942 FAIL: ignored write error
1943 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1944
8eca8a7c
AS
19452011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1946
1947 * emacs.c (Fkill_emacs): In noninteractive mode exit
1948 non-successfully if a write error occurred on stdout. (Bug#9574)
1949
3341db62
EZ
19502011-09-21 Eli Zaretskii <eliz@gnu.org>
1951
1952 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1953 the xassert test.
1954
1955 * dispextern.h (struct it): Update the comment documenting what
1956 can it->OBJECT be.
1957
8c203dbf
EZ
19582011-09-20 Eli Zaretskii <eliz@gnu.org>
1959
1960 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1961 a display string, extend search for cursor position to end of row.
1962 (find_row_edges): If the row ends in a newline from a display
1963 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1964 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1965 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1966 non-empty line. Fixes confusing cursor motion with arrow keys at
1967 the beginning of a line that starts with whitespace.
8c203dbf 1968
a4824228
LMI
19692011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1970
1971 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1972 (bug#9493).
1973
33ed493b
CY
19742011-09-18 Chong Yidong <cyd@stupidchicken.com>
1975
1976 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1977 boolean (Bug#9154).
1978
56cd55c8
EZ
19792011-09-18 Eli Zaretskii <eliz@gnu.org>
1980
1981 * xdisp.c (display_line): Record maximum and minimum buffer
1982 positions even if no glyphs were produced (e.g., by a zero-width
1983 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1984 buffer positions that will be removed from the glyph row because
1985 they don't fit.
c02dcedf
EZ
1986 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1987 column is beyond frame width: don't subtract 1 "pixel" when
1988 computing width of the stretch.
3e62b7e0
EZ
1989 (reseat_at_next_visible_line_start): Undo the change made on
1990 2011-09-17 that saved paragraph information and restored it after
1991 the call to `reseat'. (Bug#9545)
56cd55c8 1992
5ed99d36 19932011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1994
1995 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1996 and turn window cursor on if cleared (Bug#9415).
1997
5ed99d36 19982011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1999
2000 * search.c (boyer_moore): Take unibyte characters from pattern
2001 literally. (Bug#9458)
2002
9bade7b2
EZ
20032011-09-18 Eli Zaretskii <eliz@gnu.org>
2004
2005 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2006
e5e9d610
PE
20072011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2008
87e4427a
PE
2009 Fix minor problem found by static checking.
2010 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2011 initialized, to pacify gcc -Wuninitialized.
2012
e5e9d610
PE
2013 * fileio.c: Report proper errno when syscall falls.
2014 (Finsert_file_contents): Save and restore errno,
2015 so that report_file_error outputs the correct diagnostic.
2016 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2017
a1674f0b
EZ
20182011-09-18 Eli Zaretskii <eliz@gnu.org>
2019
2020 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2021
fbfb6dd4
EZ
20222011-09-17 Eli Zaretskii <eliz@gnu.org>
2023
2024 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2025 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2026
bb187662
EZ
20272011-09-17 Eli Zaretskii <eliz@gnu.org>
2028
1137e8b8 2029 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2030 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2031
2032 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2033 (bidi_find_paragraph_start): Search back for paragraph beginning
2034 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2035 (bidi_move_to_visually_next): Only trigger paragraph-related
2036 computations when the last character is a newline or at EOB, not
2037 just any NEUTRAL_B. (Bug#9470)
2038
bb187662
EZ
2039 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2040 truncated lines if point is covered by a display string. (Bug#9524)
2041
2e621251
PE
20422011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2043
2044 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2045 (cons_to_x_long): New function.
2046 (lisp_data_to_selection_data): Use it. Correct the test for
2047 short-versus-long data; it was negated. Break out of vector
2048 loop, for efficiency, when a long datum is discovered.
2049
91a15bc6
SM
20502011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2051
2052 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2053
b41c3a35
EZ
20542011-09-16 Eli Zaretskii <eliz@gnu.org>
2055
2056 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2057 GCC PR/17406) by declaring this function with external scope.
2058
7812ba2d
PE
20592011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2060
2061 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2062 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2063
cf7edc2a
AS
20642011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2065
2066 * editfns.c (Fformat): Correctly handle text properties on "%%".
2067
bd01620e
EZ
20682011-09-15 Eli Zaretskii <eliz@gnu.org>
2069
2070 * xterm.c (x_draw_composite_glyph_string_foreground):
2071 * w32term.c (x_draw_composite_glyph_string_foreground):
2072 * term.c (encode_terminal_code):
2073 * composite.c (composition_update_it, get_composition_id):
2074 * xdisp.c (get_next_display_element)
2075 (fill_composite_glyph_string): Add comments about special meaning
2076 of TAB characters in a composition.
2077
a02719a3
PE
20782011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2079
2080 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2081 This occurs when processing a multibyte format.
2082 Problem reported by Wolfgang Jenker.
a02719a3 2083
72589a3c
JB
20842011-09-15 Johan Bockgård <bojohan@gnu.org>
2085
2086 * xdisp.c (try_cursor_movement): Only check for exact match if
2087 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2088
1c14176c
PE
20892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2090
2091 Remove unused external symbols.
2092 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2093 * xdisp.c (calc_pixel_width_or_height): Now static.
2094 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2095 * indent.c (check_display_width):
2096 * w32term.c: Fix comment to match code.
2097 * xterm.c, xterm.h (x_catching_errors): Remove.
2098
d2eea5b5
PE
20992011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2100
2101 * xselect.c: Use signed conversions more consistently (Bug#9498).
2102 (selection_data_to_lisp_data): Assume incoming selection data are
2103 signed integers, not unsigned. This is to be consistent with
2104 outgoing selection data, which was modified to use signed integers
2105 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2106 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2107 expects long, not unsigned long.
2108
46888499
EZ
21092011-09-14 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2112 computation of loop end. Reported by Johan Bockgård
2113 <bojohan@gnu.org>.
2114
ef8ef9fb
CY
21152011-09-13 Chong Yidong <cyd@stupidchicken.com>
2116
2117 * frame.c (Fother_visible_frames_p): Function deleted.
2118
fa819fed
EZ
21192011-09-12 Eli Zaretskii <eliz@gnu.org>
2120
2121 * indent.c (compute_motion): Process display vector front to back
2122 rather than the other way around. (Bug#2496)
2123
2ba8e008
SM
21242011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2125
2126 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2127
20f53c69
CY
21282011-09-11 Chong Yidong <cyd@stupidchicken.com>
2129
2130 * minibuf.c (Fread_from_minibuffer): Doc fix.
2131
d562d7a4
EZ
21322011-09-11 Eli Zaretskii <eliz@gnu.org>
2133
2134 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2135 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2136
1c4d7f3d
LMI
21372011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2138
2139 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2140 value for non-existent files.
2141
b885bf36
EZ
21422011-09-11 Eli Zaretskii <eliz@gnu.org>
2143
2144 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2145 set its "size" to -1. This will set the modtime_size field of
2146 the corresponding buffer to -1, which is what
2147 verify-visited-file-modtime expects for files that do not exist.
2148 (Bug#9139)
2149
6612f0bf
PE
21502011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2151
2152 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2153 here ...
2154 * lisp.h: ... from here. push_key_description is no longer
2155 defined in keyboard.c, so its declaration should not be in
2156 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2157 logically belongs with push_key_description.
2158
dfb3f755
PE
21592011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 * buffer.h: Include <sys/types.h> instead of <time.h>.
2162 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2163 Problem reported by Herbert J. Skuhra.
2164
3134906c
LMI
21652011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2166
2167 * xml.c (parse_region): Make the parsing work for
2168 non-comment-starting XML files again (bug#9144).
2169
8d903f4e
AS
21702011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2171
2172 * image.c (gif_load): Fix calculation of bottom and right corner.
2173 (Bug#9468)
2174
80ad64f4
EZ
21752011-09-10 Eli Zaretskii <eliz@gnu.org>
2176
2177 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2178 redisplay in small windows.
2179
208a048d
EZ
21802011-09-09 Eli Zaretskii <eliz@gnu.org>
2181
2182 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2183
9b1c252e
MR
21842011-09-08 Martin Rudalics <rudalics@gmx.at>
2185
2186 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2187 Operate on live windows only.
2188
2949f33b
JB
21892011-09-08 Juanma Barranquero <lekktu@gmail.com>
2190
2191 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2192
e08dcafd
EZ
21932011-09-07 Eli Zaretskii <eliz@gnu.org>
2194
2195 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2196 only under bidi iteration.
2197
115b96bd
JD
21982011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2199
2200 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2201
c8199d0f
PE
22022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2203
2204 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2205 Without this fix, the command to link temacs failed due to an
2206 undefined symbol __builtin_isnan. This is because
2207 /usr/include/iso/math_c99.h #defines isnan(x) to
2208 __builtin_isnan(x), but the bundled gcc, which identifies itself
2209 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2210 a __builtin_isnan.
2211 * floatfns.c (isnan): #undef, and then #define to a clone of
2212 what's in data.c.
2213 (Fisnan): Always define, since it's always available now.
2214 (syms_of_floatfns): Always define isnan at the Lisp level.
2215
e39b275c 22162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2217
2218 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2219
b2db44d9 22202011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2221
f4af5137 2222 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2223 The previous code assumed that file offsets (off_t values) fit in
2224 EMACS_INT variables, which is not true on typical 32-bit hosts.
2225 The code messed up by falsely reporting buffer overflow in cases
2226 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2227 when "big" contains more than 2**29 bytes, even though this
2228 inserts just one byte and does not overflow the buffer.
2229 (Finsert_file_contents): Store file offsets as off_t
2230 values, not as EMACS_INT values. Check for overflow when
2231 converting between EMACS_INT and off_t. When checking for
2232 buffer overflow or for overlap, take the offsets into account.
2233 Don't use EMACS_INT for small values where int suffices.
2234 When checking for overlap, fix a typo: ZV was used where
2235 ZV_BYTE was intended.
2236 (Fwrite_region): Don't assume off_t fits into 'long'.
2237 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2238
ecfc0a49
MA
22392011-09-05 Michael Albinus <michael.albinus@gmx.de>
2240
2241 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2242
6511acf2 22432011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2244
0999621a 2245 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2246
2247 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2248 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2249 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2250 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2251 (modify_event_symbol): Do not assume that the length of
2252 name_alist_or_stem is safe to alloca and fits in int.
2253 (Fexecute_extended_command): Likewise for function name and binding.
2254 (Frecursion_depth): Wrap around reliably on integer overflow.
2255 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2256 since some callers pass EMACS_INT values.
2257 (Fsingle_key_description): Don't crash if symbol name contains more
2258 than MAX_ALLOCA bytes.
2259 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2260 (get_minibuffer): Arg is now EMACS_INT, not int.
2261 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2262 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2263 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2264
2be7d702
PE
2265 * dbusbind.c (signature_cat): New function.
2266 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2267 Do not overrun buffer; instead, report string overflow.
2268
9d1df220
PE
2269 * dispnew.c (add_window_display_history): Don't overrun buffer.
2270 Truncate instead; this is OK since it's just a log.
2271
33ef5c64
PE
2272 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2273 even if the time zone offset is outlandishly large.
2274 Don't mishandle offset == INT_MIN.
2275
66c6fdd5
PE
2276 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2277 when creating daemon; the previous buffer-overflow check was incorrect.
2278
d749b01b
PE
2279 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2280 which has the guts of the old verror function.
2281
b5cd1905
PE
2282 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2283 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2284
6e1a67fb
PE
2285 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2286 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2287 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2288 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2289 length of string rather than counting it via multiple sprintfs;
2290 that's simpler and more reliable.
c21721cc
PE
2291 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2292 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2293 sprintf, in case result does not fit in int.
2294
c57b67fc
PE
2295 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2296 (fontset_from_font): Print it.
2297
8a401434
PE
2298 * frame.c (tty_frame_count): Now printmax_t, not int.
2299 (make_terminal_frame, set_term_frame_name): Print it.
2300 (x_report_frame_params): In X, window IDs are unsigned long,
2301 not signed long, so print them as unsigned.
2302 (validate_x_resource_name): Check for implausibly long names,
2303 and don't assume name length fits in 'int'.
2304 (x_get_resource_string): Don't blindly alloca invocation name;
2305 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2306 not fit in int.
2307
6e1a67fb
PE
2308 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2309 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2310 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2311
0df02bf3
PE
2312 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2313 Use esprintf, not sprintf, in case result does not fit in int.
2314
48e30793
PE
2315 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2316 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2317 it as a large positive number.
2318 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2319 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2320
a66ff6d8
PE
2321 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2322 in case result does not fit in int.
2323
aca216ff
PE
2324 * print.c (float_to_string): Detect width overflow more reliably.
2325 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2326 buffer overrun. Don't assume list length fits in 'int'. Treat
2327 print length of 0 as 0, not as infinity; to be consistent with other
2328 uses of print length in this function. Don't overflow print length
2329 index. Don't assume hash table size fits in 'long', or that
2330 vectorlike size fits in 'unsigned long'.
2331
31c286f7
PE
2332 * process.c (make_process): Use printmax_t, not int, to format
2333 process-name gensyms.
2334
55e5faa1
PE
2335 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2336
80f2e268
PE
2337 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2338 to avoid potential buffer overrun.
2339
670741ab
PE
2340 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2341 if X resource line is longer than 512 bytes.
2342
b7163a50
PE
2343 * xfns.c (x_window): Make sprintf buffer a bit bigger
2344 to avoid potential buffer overrun.
2345
ae58ff1f
PE
2346 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2347
c43c8a6a
PE
2348 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2349
3f8236f4
PE
23502011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2351
53e9fe90 2352 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2353 Without these, Emacs silently mishandles large integers sometimes.
2354 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2355 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2356
6511acf2
PE
2357 * xdisp.c (try_window_id): Check Emacs fixnum range before
2358 converting to 'int'.
806add1d 2359
6511acf2 2360 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2361 Check that an Emacs fixnum is in range before assigning it to 'int'.
2362 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2363 values converted from Emacs fixnums.
2364 (Frecenter): Don't wrap around a line count if it is out of 'int'
2365 range; instead, treat it as an extreme value.
2366 (Fset_window_configuration, compare_window_configurations):
2367 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2368
6511acf2
PE
2369 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2370 that can exceed INT_MAX. Check that EMACS_INT value is in range
2371 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2372 (match_limit): Don't assume that a fixnum can fit in 'int'.
2373
6511acf2 2374 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2375 exceed INT_MAX.
2376
6511acf2 2377 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2378 (Fvertical_motion): Don't wrap around LINES values that don't fit
2379 in 'int'. Instead, treat them as extreme values. This is good
2380 enough for windows, which can't have more than INT_MAX lines anyway.
2381
fcb901a7
LMI
23822011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2383
0f2f6b6d
LMI
2384 * Require libxml/parser.h to avoid compilation warning.
2385
fcb901a7
LMI
2386 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2387
2388 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2389 since this reportedly can destroy thread storage.
2390
6e20a0d4
CY
23912011-08-30 Chong Yidong <cyd@stupidchicken.com>
2392
2393 * syntax.c (find_defun_start): Update all cache variables if
2394 exiting early (Bug#9401).
2395
148ae00e
EZ
23962011-08-30 Eli Zaretskii <eliz@gnu.org>
2397
f6cfbd8f
EZ
2398 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2399
148ae00e
EZ
2400 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2401 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2402 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2403
2404 * term.c (tty_append_glyph): New function.
2405 (produce_stretch_glyph): Static function and its prototype deleted.
2406
a66cfb1c
SM
2407 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2408 Add prototypes.
148ae00e 2409
c4a07a4c
PE
24102011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2413 when checking :margin (Bug#9390).
2414 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2415 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2416 so that the name doesn't mislead. All uses changed.
2417
6bc8cd65
JB
24182011-08-28 Johan Bockgård <bojohan@gnu.org>
2419
2420 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2421 set_tty_hooks.
2422
dca4927e
EZ
24232011-08-27 Eli Zaretskii <eliz@gnu.org>
2424
2425 * xdisp.c (move_it_to): Don't bail out early when reaching
2426 position beyond to_charpos, if we are scanning backwards.
2427 (move_it_vertically_backward): When DY == 0, make sure we get to
2428 the first character in the line after the newline.
2429
f2cad773
PE
24302011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2431
2432 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2433 (ccl_driver): Do not generate an out-of-range pointer.
2434 (Fccl_execute_on_string): Remove unnecessary check for
2435 integer overflow, noted by Stefan Monnier in
2436 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2437 Remove a FIXME that didn't need fixing.
2438 Simplify the newly-introduced buffer reallocation code.
2439
0cae2cdb
JB
24402011-08-27 Juanma Barranquero <lekktu@gmail.com>
2441
2442 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2443
5fc295a4 24442011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2445
70c60eb2 2446 Integer and memory overflow issues (Bug#9196).
726e0ab1 2447
d31850da
PE
2448 * doc.c (get_doc_string): Rework so that
2449 get_doc_string_buffer_size is the actual buffer size, rather than
2450 being 1 less than the actual buffer size; this makes xpalloc more
2451 convenient.
2452
a69fbedb
PE
2453 * image.c (x_allocate_bitmap_record, cache_image):
2454 * xselect.c (Fx_register_dnd_atom):
2455 Simplify previous changes by using xpalloc.
2456
fe5c5d37
PE
2457 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2458 since either will do and ptrdiff_t is convenient with xpalloc.
2459
0065d054
PE
2460 * charset.c (charset_table_size)
2461 (struct charset_sort_data.priority): Now ptrdiff_t.
2462 (charset_compare): Don't overflow if priorities differ greatly.
2463 (Fsort_charsets): Don't assume list length fits in int.
2464 Check for size-calculation overflow when allocating sort data.
2465 (syms_of_charset): Allocate an initial charset table that is
2466 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2467
2468 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2469
2470 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2471 The actual value is always <= INT_MAX, and leaving it unsigned made
2472 overflow checking harder.
2473
2474 * dispextern.h (struct glyph_matrix.rows_allocated)
2475 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2476 with xpalloc. The values are still always <= INT_MAX.
2477
2478 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2479
2480 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2481 (SAFE_NALLOCA): New macro.
2482
2483 * region-cache.c (struct boundary.pos, find_cache_boundary)
2484 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2485 (set_cache_region, invalidate_region_cache)
2486 (revalidate_region_cache, know_region_cache, region_cache_forward)
2487 (region_cache_backward, pp_cache):
2488 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2489 so that ptrdiff_t * can be passed to xpalloc.
2490 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2491 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2492 (pp_cache): Don't assume cache_len fits in int.
2493 * region-cache.h: Adjust extern decls to match.
2494
2495 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2496 EMACS_INT, since either will do, for xpalloc.
2497
2498 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2499 (xnmalloc, xnrealloc, xpalloc): New functions.
2500
726e0ab1
PE
2501 * bidi.c (bidi_shelve_header_size): New constant.
2502 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2503 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2504
51f30bc5 2505 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2506 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2507 (overlay_strings):
2508 Don't update size of array until after memory allocation succeeds,
2509 because xmalloc/xrealloc may not return.
0065d054
PE
2510 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2511 now that we have proper integer overflow checking.
2512 (record_overlay_string, overlay_strings): Catch overflows when
2513 calculating size of overlay_str_buf.
726e0ab1 2514
0065d054
PE
2515 * callproc.c (Fcall_process): Check for size overflow when
2516 calculating size of args2.
2517 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2518 Normally we prefer signed values, but sticking with ptrdiff_t would
2519 require adding more-complicated checks.
726e0ab1
PE
2520
2521 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2522 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2523 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2524 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2525
2526 * character.c (Fstring): Check for size-calculation overflow.
2527
2528 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2529 unnecessary integer overflow. Check for size overflow.
2530 (encode_coding_object): Don't update size until xmalloc succeeds.
2531
2532 * composite.c (get_composition_id): Check for overflow in glyph
2533 length calculations.
2534
2535 Integer and memory overflow fixes for display code.
2536 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2537 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2538 (scrolling_window): Check for overflow in size calculations.
2539 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2540 Don't assume glyph table len fits in int.
2541 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2542 (row_table_size): Now ptrdiff_t, not int.
2543 (scrolling_window): Avoid overflow in size calculations.
2544 Don't update size until allocation succeeds.
2545 * fns.c (concat): Check for overflow in size calculations.
2546 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2547 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2548 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2549
2550 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2551 (get_doc_string): Check for size calculation overflow.
2552 Don't update size until allocation succeeds.
2553 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2554 EMACS_INT, where ptrdiff_t will do.
2555 (Fsubstitute_command_keys): Check for string overflow.
2556
2557 * editfns.c (set_time_zone_rule): Don't assume environment length
2558 fits in int.
2559 (message_length): Now ptrdiff_t, not int.
2560 (Fmessage_box): Don't update size until allocation succeeds.
2561 Don't assume message length fits in int.
2562 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2563
0065d054
PE
2564 * emacs.c (main): Do not reallocate argv, since there is a null at
2565 the end that can be overwritten, and this way there's no need to
2566 worry about size-calculation overflow.
2567 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2568
2569 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2570 alloc succeeds.
2571 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2572
2573 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2574 (x_set_scroll_bar_width, x_figure_window_size):
2575 Check for integer overflow.
2576 (x_set_alpha): Do not assume XINT fits in int.
2577
2578 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2579 This is for the members text_lines, text_cols, total_lines, total_cols,
2580 where the system imposes an 'int' limit.
2581
2582 * fringe.c (Fdefine_fringe_bitmap):
2583 Don't update size until alloc works.
2584
2585 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2586 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2587
2588 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2589 Check for size-calculation overflow.
2590 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2591 do, as we prefer signed integers.
2592 (id_to_widget.max_size, id_to_widget.used)
2593 (xg_store_widget_in_map, xg_remove_widget_from_map)
2594 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2595 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2596 Use and return ptrdiff_t, not int.
2597 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2598 * gtkutil.h: Change prototypes to match the above.
2599
2600 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2601 are duplicate now that they've been promoted to lisp.h.
2602 (x_allocate_bitmap_record, x_alloc_image_color)
2603 (make_image_cache, cache_image, xpm_load):
2604 Don't update size until alloc is done.
2605 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2606 (x_detect_edges):
3256efce 2607 Check for size calculation overflow.
726e0ab1
PE
2608 (ct_colors_allocated_max): New constant.
2609 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2610 overflow.
3256efce 2611
726e0ab1
PE
2612 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2613 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2614 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2615 Use ptrdiff_t, not int, to count maps.
2616 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2617 calculations. Don't update size until allocation succeeds.
2618 Redo calculations to avoid overflow.
726e0ab1
PE
2619 * keyboard.h: Change prototypes to match the above.
2620
2621 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2622 to count maps.
2623 (current_minor_maps): Check for size calculation overflow.
2624 * keymap.h: Change prototypes to match the above.
2625
2626 * lread.c (read1, init_obarray): Don't update size until alloc done.
2627
2628 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2629 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2630
726e0ab1
PE
2631 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2632 Now ptrdiff_t, not int.
2633 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2634 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2635
2636 * process.c (Fnetwork_interface_list): Check for overflow
2637 in size calculation.
2638
2639 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2640
2641 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2642 overflow. Don't bother calling xmalloc when xrealloc will do.
2643
2644 * search.c (Freplace_match): Check for size calculation overflow.
2645 (Fset_match_data): Don't assume list lengths fit in 'int'.
2646
2647 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2648 for command line length. Do not attempt to address one before the
2649 beginning of an array, as that's not portable.
2650
2651 * term.c (max_frame_lines): Remove; unused.
2652 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2653 not int.
2654 (encode_terminal_code, calculate_costs): Check for size
2655 calculation overflow.
2656 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2657 table lengths and related sizes. Don't update size until alloc
2658 done. Redo calculations to avoid overflow.
2659 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2660
2661 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2662 subtracting pointers.
2663 (gobble_line): Check for overflow more carefully. Don't update size
2664 until alloc done.
2665
2666 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2667 Don't update size until alloc done.
2668 Redo size calculations to avoid overflow.
2669 Check for size calculation overflow.
0065d054 2670 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2671
2672 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2673 Use ptrdiff_t, not int, for sizes.
2674 (store_mode_line_noprop_char): Don't update size until alloc done.
2675
0065d054
PE
2676 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2677 Use ptrdiff_t, not int, for sizes.
2678 (Finternal_make_lisp_face, cache_face):
2679 Check for size calculation overflow.
2680 (cache_face): Treat size calculation overflows as if they were
2681 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2682
2683 * xfns.c (x_encode_text, x_set_name_internal)
2684 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2685 sizes, since they can exceed INT_MAX in size. Check for size
2686 calculation overflow.
2687
0065d054
PE
2688 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2689 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2690 Don't update size until alloc done.
2691
0065d054 2692 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2693 as sprintf is limited to int lengths.
1d526e2f 2694
252c5ee1
PE
2695 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2696 (X_LONG_MIN): New macros.
864d7ce7
PE
2697 Use them to make the following changes clearer.
2698 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2699 This change doesn't affect the value now, but it may help remind
2700 future maintainers not to raise the value too much later.
2701 (SELECTION_QUANTUM): Remove, replacing with ...
2702 (selection_quantum): ... new function, which avoids overflow.
2703 All uses changed.
2704 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2705 assumption that selection length fits in 'int'.
2706 (x_reply_selection_request, x_handle_selection_request)
2707 (x_get_window_property, receive_incremental_selection)
2708 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2709 (lisp_data_to_selection_data, clean_local_selection_data):
2710 Use ptrdiff_t, not int, to record length of selection.
2711 (x_reply_selection_request, x_get_window_property)
2712 (receive_incremental_selection, x_property_data_to_lisp):
2713 Redo calculations to avoid overflow.
2714 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2715 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2716 something.
2717 (x_get_window_property, receive_incremental_selection)
2718 (lisp_data_to_selection_data, x_property_data_to_lisp):
2719 Check for size-calculation overflow.
2720 (x_get_window_property, receive_incremental_selection)
2721 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2722 Don't store size until memory allocation succeeds.
2723 (x_get_window_property): Plug memory leak on memory exhaustion.
2724 Don't double-block input; malloc is safe here. Don't assume 2**34
2725 - 4 fits in unsigned long. Add an xassert to check
2726 XGetWindowProperty overflow. Be more careful about overflow
2727 calculations, and distinguish size from memory overflow better.
2728 (receive_incremental_selection): When tracing, don't assume
2729 unsigned int is less than INT_MAX.
2730 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2731 harmful) conversions of unsigned short to int.
2732 (lisp_data_to_selection_data): Don't assume that integers
2733 in the range -65535 through -1 fit in an X unsigned short.
2734 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2735 result parameters unless successful. Rely on cons_to_unsigned
2736 to report problems with elements; the old code wasn't right anyway.
2737 (x_check_property_data): Check for int overflow; we cannot use
2738 a wider type due to X limits.
2739 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2740
726e0ab1 2741 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2742
0065d054
PE
2743 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2744 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2745 (x_color_cells): Don't store size until memory allocation succeeds.
2746 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2747 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2748 (x_term_init): Don't assume length fits in int (sprintf is limited
2749 to int size).
bc18e09d 2750
ebfa62c0
PE
2751 Use ptrdiff_t for composition IDs.
2752 * character.c (lisp_string_width):
2753 * composite.c (composition_table_size, n_compositions)
2754 (get_composition_id, composition_gstring_from_id):
2755 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2756 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2757 * window.c (Frecenter):
2758 Use ptrdiff_t, not int, for composition IDs.
2759 * composite.c (get_composition_id): Check for integer overflow.
2760 * composite.h: Adjust prototypes to match the above changes.
2761
d3411f89
PE
2762 Use ptrdiff_t for hash table indexes.
2763 * category.c (hash_get_category_set):
2764 * ccl.c (ccl_driver):
2765 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2766 * coding.c (coding_system_charset_list, detect_coding_system):
2767 * coding.h (struct coding_system.id):
2768 * composite.c (get_composition_id, gstring_lookup_cache):
2769 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2770 * image.c (xpm_get_color_table_h):
2771 * lisp.h (hash_lookup, hash_put):
2772 * minibuf.c (Ftest_completion):
2773 Use ptrdiff_t for hash table indexes, not int (which is too
2774 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2775 32-bit --with-wide-int hosts).
2776
e097a6fa
PE
2777 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2778 Add a FIXME comment about memory leaks.
2779 (syms_of_charset): Don't assume xmalloc returns.
2780
5637687f
PE
2781 Don't assume that stated character widths fit in int.
2782 * character.c (Fchar_width, c_string_width, lisp_string_width):
2783 * character.h (CHAR_WIDTH):
2784 * indent.c (MULTIBYTE_BYTES_WIDTH):
2785 Use sanitize_char_width to avoid undefined and/or bad behavior
2786 with outlandish widths.
a66cfb1c 2787 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2788 now that we have two such functions. All uses changed.
2789 (sanitize_char_width): New inline function.
2790
a2271ba2
PE
2791 Don't assume that tab-width fits in int.
2792 * character.h (sanitize_width): New inline function.
2793 (SANE_TAB_WIDTH): New macro.
2794 (ASCII_CHAR_WIDTH): Use it.
2795 * indent.c (sane_tab_width): Remove. All uses replaced by
2796 SANE_TAB_WIDTH (current_buffer).
2797 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2798
18c52557
PE
2799 * fileio.c: Integer overflow issues with file modes.
2800 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2801
caeeedc1
PE
2802 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2803 Remove unreachable code.
2804 (read_hex, load_charset_map_from_file): Check for integer overflow.
2805
6df6ae42 2806 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2807 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2808 (x_send_scroll_bar_event): Likewise. Check that the size does not
2809 exceed limits imposed by XClientMessageEvent, as well as the usual
2810 ptrdiff_t and size_t limits.
2811
b13995db
PE
2812 * keyboard.c: Overflow, signedness and related fixes.
2813 (make_lispy_movement): Use same integer type in forward decl
2814 that is used in the definition.
2815 (read_key_sequence, keyremap_step):
2816 Change bufsize argument back to int, undoing my 2011-03-30 change.
2817 We prefer signed types, and int is wide enough here.
2818 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2819 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2820 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2821 length, not size_t. Use ptrdiff_t for index, not int.
2822 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2823 possibility of integer overflow.
2824
13464394
PE
2825 Overflow, signedness and related fixes for images.
2826
2827 * dispextern.h (struct it.stack[0].u.image.image_id)
2828 (struct_it.image_id, struct image.id, struct image_cache.size)
2829 (struct image_cache.used, struct image_cache.ref_count):
2830 * gtkutil.c (update_frame_tool_bar):
2831 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2832 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2833 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2834 * nsmenu.m (update_frame_tool_bar):
2835 * xdisp.c (calc_pixel_width_or_height):
2836 * xfns.c (image_cache_refcount):
2837 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2838 on typical 64-bit hosts.
2839
2840 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2841 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2842 Omit unnecessary casts to int.
2843 (parse_image_spec): Check that integers fall into 'int' range
2844 when the callers expect that.
2845 (image_ascent): Redo ascent calculation to avoid int overflow.
2846 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2847 (lookup_image): Remove unnecessary tests.
2848 (xbm_image_p): Locals are now of int, not EMACS_INT,
2849 since parse_image_check makes sure they fit into int.
2850 (png_load, gif_load, svg_load_image):
2851 Prefer int to unsigned where either will do.
2852 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2853 old tiff_error_handler and tiff_warning_handler.
2854 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2855 stack buffer overflows. It uses only the features of vsnprintf
2856 that are common to both POSIX and native Microsoft.
2857 (tiff_error_handler, tiff_warning_handler): Use it.
2858 (tiff_load, gif_load, imagemagick_load_image):
2859 Don't assume :index value fits in 'int'.
2860 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2861 (imagemagick_load_image): Check that crop parameters fit into
2862 the integer types that MagickCropImage accepts. Don't assume
2863 Vimagemagick_render_type has a nonnegative value. Don't assume
2864 size_t fits in 'long'.
2865 (gs_load): Use printmax_t to print the widest integers possible.
2866 Check for integer overflow when computing image height and width.
2867
c11821d4
EZ
28682011-08-26 Eli Zaretskii <eliz@gnu.org>
2869
2870 * xdisp.c (redisplay_window): Don't force window start if point
2871 will be invisible in the resulting window. (Bug#9324)
2872
0c95fcf7
EZ
28732011-08-25 Eli Zaretskii <eliz@gnu.org>
2874
2875 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2876 the display spec is of the form `(space ...)'.
2877 (handle_display_spec): Return the value returned by
2878 handle_single_display_spec, not just 1 or zero.
2879 (handle_single_display_spec): If the display spec is of the form
2880 `(space ...)', and specifies display in the text area, return 2
2881 rather than 1.
fee65a97 2882 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2883 accurately, and prefer exact match for point under bidi.
2884 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2885
2886 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2887 into disp_prop; all users changed.
2888
2889 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2890 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2891 for the text covered by the display property.
2892
e4ed06f1
CY
28932011-08-25 Chong Yidong <cyd@stupidchicken.com>
2894
2895 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2896 Change return value to nil.
2897 (Frecord_buffer): Delete unused function.
2898
f67cdd7f
EZ
28992011-08-24 Eli Zaretskii <eliz@gnu.org>
2900
5980d4c6
EZ
2901 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2902 buffers, return left-to-right.
8610fe8b
EZ
2903 (set_cursor_from_row): Consider candidate row a win if its glyph
2904 represents a newline and point is on that newline. Fixes cursor
2905 positioning on the newline at EOL of R2L text within L2R
2906 paragraph, and vice versa.
2907 (try_cursor_movement): Check continued rows, in addition to
2908 continuation rows. Fixes unwarranted scroll when point enters a
2909 continued line of R2L text within an L2R paragraph, or vice versa.
2910 (cursor_row_p): Consider the case of point being equal to
2911 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2912 from the end of a short line to the beginning of a continued line
2913 of R2L text within L2R paragraph.
2914 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2915 composed characters.
5980d4c6 2916
f67cdd7f
EZ
2917 * bidi.c (bidi_check_type): Use xassert.
2918 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2919 members.
2920
bca633fb
EZ
29212011-08-23 Eli Zaretskii <eliz@gnu.org>
2922
2923 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2924 a character.
2925
4a5885a7
CY
29262011-08-23 Chong Yidong <cyd@stupidchicken.com>
2927
2928 * nsfont.m (ns_otf_to_script): Fix typo.
2929
0902a04e
KH
29302011-08-22 Kenichi Handa <handa@m17n.org>
2931
2932 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2933 extra slot even if the purpose is char-code-property-table.
2934
1a2e6670
EZ
29352011-08-23 Eli Zaretskii <eliz@gnu.org>
2936
8ddde651
EZ
2937 * xdisp.c (redisplay_window): When computing centering_position,
2938 account for the height of the header line. (Bug#8874)
2939
425cc014
EZ
2940 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2941 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2942 candidate is selected by the mouse, and that candidate has a
2943 composed character under the mouse.
2944
1a2e6670
EZ
2945 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2946 coordinates reported by pos-visible-in-window-p for a composed
2947 character in column zero.
2948
8b76d6f8
SM
29492011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2950
2951 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2952
dac347dd
EZ
29532011-08-22 Eli Zaretskii <eliz@gnu.org>
2954
2955 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2956 consider it a hit if to_charpos is anywhere in the range of the
2957 composed buffer positions.
2958
e013fb34
CY
29592011-08-22 Chong Yidong <cyd@stupidchicken.com>
2960
2961 * image.c (gif_load): Don't assume that each subimage has the same
2962 dimensions as the base image. Handle disposal method that is
2963 "undefined" by the gif spec (Bug#9335).
2964
bd1ba3e8
CY
29652011-08-20 Chong Yidong <cyd@stupidchicken.com>
2966
2967 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2968 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2969
54a1215b
EZ
29702011-08-19 Eli Zaretskii <eliz@gnu.org>
2971
823564e5
EZ
2972 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2973 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2974 from an Org mode buffer to a Speedbar frame.
2975
54a1215b
EZ
2976 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2977 a composition, take its buffer position from IT->cmp_it.charpos.
2978 Fixes cursor positioning at the beginning of a line that begins
2979 with a composed character.
2980
9778ebcc
EZ
29812011-08-18 Eli Zaretskii <eliz@gnu.org>
2982
0be6ee06
EZ
2983 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2984 character bidirectional type, use STRONG_L instead. Fixes crashes
2985 in a buffer produced by `describe-categories'.
2986
9778ebcc
EZ
2987 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2988 members before the level stack, so they would be saved and
2989 restored when copying iterator state. Fixes incorrect reordering
2990 around TABs covered by display properties.
2991
156bffbe
AS
29922011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2993
6b02f655 2994 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2995
72ad093b
CY
29962011-08-17 Chong Yidong <cyd@stupidchicken.com>
2997
2998 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2999 (internal_condition_case_2, internal_condition_case_n):
3000 Remove unnecessary aborts (Bug#9081).
72ad093b 3001
35774242
EZ
30022011-08-17 Eli Zaretskii <eliz@gnu.org>
3003
3004 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3005 has no `load' handler, try opening the file locally. (Bug#9311)
3006
db76dd85
KB
30072011-08-16 Ken Brown <kbrown@cornell.edu>
3008
3009 * gmalloc.c: Expand comment.
3010
b215eee5
EZ
30112011-08-16 Eli Zaretskii <eliz@gnu.org>
3012
3013 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3014 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3015
a4579d33
KB
30162011-08-16 Ken Brown <kbrown@cornell.edu>
3017
3018 Fix memory allocation problems in Cygwin build (Bug#9273).
3019
3020 * unexcw.c ( __malloc_initialized): Declare external variable.
3021 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3022
8b76d6f8
SM
3023 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3024 New variables.
a4579d33
KB
3025 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3026 dumped emacs.
3027 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3028 in the static heap.
3029 [CYGWIN] (special_realloc): New function.
3030 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3031 requests to realloc storage in the static heap.
3032
3ebec551
PE
30332011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3034
3035 * bidi.c (bidi_initialize): Remove unused local.
3036
9fd8be00
EZ
30372011-08-15 Eli Zaretskii <eliz@gnu.org>
3038
6b02f655
SM
3039 * bidimirror.h:
3040 * biditype.h: Remove file.
3041 * makefile.w32-in ($(BLD)/bidi.$(O)):
3042 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3043
3044 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3045
3046 * chartab.c: Improve commentary for the uniprop_table API.
3047
32413314
EZ
3048 * bidi.c (bidi_paragraph_init): Support zero value of
3049 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3050 (bidi_initialize): Use uniprop_table instead of including
3051 biditype.h and bidimirror.h.
32413314 3052
9fd8be00
EZ
3053 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3054 coordinates of the iterator when restoring from ppos_it.
3055 (Bug#9296)
3056
5cf2b69b
KH
30572011-08-14 Kenichi Handa <handa@m17n.org>
3058
3059 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3060 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3061
daf17d00
EZ
30622011-08-14 Eli Zaretskii <eliz@gnu.org>
3063
3064 * xdisp.c (move_it_in_display_line_to): Don't invoke
3065 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3066 ppos_it. Fixes vertical cursor motion when line beginning is
3067 covered by an image. (Bug#9296)
3068
08e3161a
JD
30692011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3070
3071 * nsterm.h (ns_run_ascript): Declare.
3072 (NSAPP_DATA2_RUNASSCRIPT): Define.
3073
3074 * nsfns.m (as_script, as_result, as_status): New static variables.
3075 (ns_run_ascript): New function.
5e617bc2 3076 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3077 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3078 the event loop. Get status from as_status (Bug#7276).
3079
3080 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3081 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3082 the event loop (Bug#7276).
3083
a3720aa2
AS
30842011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3085
3086 * gnutls.c (QCgnutls_bootprop_priority)
3087 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3088 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3089 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3090 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3091 (QCgnutls_bootprop_verify_hostname_error)
3092 (QCgnutls_bootprop_callbacks_verify): Rename from
3093 Qgnutls_bootprop_..., all uses changed.
3094
3095 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3096 uses changed.
3097
0a0d27fb
PE
30982011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3099
19d5c50c
PE
3100 * xfaces.c (Qframe_set_background_mode): Now static.
3101 * dispextern.h (Qframe_set_background_mode): Remove decl.
3102
0a0d27fb
PE
3103 * process.c (Fnetwork_interface_info): Declare local only if needed.
3104
377538cb
JD
31052011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3106
3107 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3108 (Fnetwork_interface_list): Allocate in increments of bytes instead
3109 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3110 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3111 sockaddr.
3112 (struct ifflag_def): notrailers is smart on OSX.
3113 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3114 Get hardware address with getifaddrs if available.
3115
08fff70c
EZ
31162011-08-12 Eli Zaretskii <eliz@gnu.org>
3117
3118 * xdisp.c (iterate_out_of_display_property): xassert that
3119 IT->position is set to within IT->object's boundaries. Break from
3120 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3121 when IT->position is set up wrongly due to some bug.
3122 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3123 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3124 entry. Force push_it to save on the stack the current
3125 buffer/string position, to be restored by pop_it. Fix flags in
3126 the iterator structure wrt the object coming from a display
3127 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3128 properties. (Bug#9284)
3129
7be1c708 31302011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3131
7be1c708
CY
3132 * fontset.c (fontset_get_font_group): Add proper type checks.
3133 (Bug#9172)
aac0c6e3 3134
7be1c708 31352011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3136
7be1c708
CY
3137 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3138 and LC_VERSION_MIN_MACOSX.
3139 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3140 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3141
97bb72a6
EZ
31422011-08-08 Eli Zaretskii <eliz@gnu.org>
3143
3144 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3145 no-display-properties-and-no-overlays under bidi display.
3146 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3147 properties and overlays.
97bb72a6 3148
d5617611
CY
31492011-08-08 Chong Yidong <cyd@stupidchicken.com>
3150
37e11a63
CY
3151 * editfns.c (Fset_time_zone_rule): Document relationship with the
3152 setenv function.
3153
d5617611
CY
3154 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3155 the font entity extracted from the cache (Bug#8109).
3156
58872834
CY
31572011-08-07 Chong Yidong <cyd@stupidchicken.com>
3158
3159 * composite.c (autocmp_chars): Don't reset point. That is done by
3160 restore_point_unwind (Bug#5984).
3161
75bfc667
JL
31622011-08-07 Juri Linkov <juri@jurta.org>
3163
3164 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3165 to show the arg `TIME' instead of `TIMEVAL'.
3166
d1410150
EZ
31672011-08-06 Eli Zaretskii <eliz@gnu.org>
3168
3169 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3170 display property strides EOL and includes a newline, as in
3171 longlines-mode. (Bug#9254)
75b771e4
EZ
3172 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3173 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3174
3175 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3176 is non-zero, even if the data buffer is NULL. Fixes a crash in
3177 vertical-motion with longlines-mode. (Bug#9254)
3178
35928349
EZ
31792011-08-05 Eli Zaretskii <eliz@gnu.org>
3180
ec7cc85b
EZ
3181 * bidi.c <bidi_cache_total_alloc>: Now static.
3182 (bidi_initialize): Initialize bidi_cache_total_alloc.
3183
8b76d6f8 3184 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3185 cache. (Bug#9221)
3186
3187 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3188 amount allocated this far in `bidi_cache_total_alloc'.
3189 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3190 non-zero, only free the data buffer without restoring the cache
3191 contents. All callers changed.
3192
3193 * dispextern.h (bidi_unshelve_cache): Update prototype.
3194
3195 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3196 (move_it_in_display_line, move_it_to)
3197 (move_it_vertically_backward, move_it_by_lines): Replace the call
3198 to xfree to an equivalent call to bidi_unshelve_cache.
3199 (move_it_in_display_line_to): Fix logic of returning
412b6358 3200 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3201
e2e2423b
EZ
32022011-08-05 Eli Zaretskii <eliz@gnu.org>
3203
3204 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3205 came from a string character with a `cursor' property. (Bug#9229)
3206
ae9e757a
JD
32072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3208
3209 * Makefile.in (LIB_PTHREAD): New variable.
3210 (LIBES): Add LIB_PTHREAD (Bug#9216).
3211
3212 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3213 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3214
213bd7f2
AS
32152011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3216
6b02f655 3217 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3218
99aaf75f
JD
32192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3220
3221 * xterm.c (x_find_topmost_parent): New function.
3222 (x_set_frame_alpha): Find topmost parent window with
3223 x_find_topmost_parent and set the property there also (bug#9181).
3224 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3225
c74e9d86
PE
32262011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3227
3228 * callproc.c (Fcall_process): Avoid vfork clobbering
3229 the local vars buffer, coding_systems, current_dir.
3230
640c8776
SM
32312011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3232
3233 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3234
f26d0e4c
PE
32352011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3236
8a10d76c
PE
3237 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3238 so that it is not optimized away.
3239
f26d0e4c
PE
3240 * xdisp.c (compute_display_string_pos): Remove unused local.
3241
55439c61
EZ
32422011-08-02 Eli Zaretskii <eliz@gnu.org>
3243
3244 Fix slow cursor motion and scrolling in large buffers with
3245 selective display, like Org Mode buffers. (Bug#9218)
3246
3247 * dispextern.h (struct bidi_it): New member disp_prop_p.
3248
3249 * xdisp.c: Remove one-slot cache of display string positions.
3250 (compute_display_string_pos): Accept an additional argument
5e617bc2 3251 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3252 for a display string or property. If found, set DISP_PROP_P
3253 non-zero.
3254
3255 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3256 DISP_PROP_P, and pass it to compute_display_string_pos.
3257 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3258 non-zero. All callers of bidi_fetch_char changed.
3259
fb33fa43
SM
32602011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3261
3262 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3263
b099e063
DM
32642010-12-03 Don March <don@ohspite.net>
3265
3266 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3267 last character M-[char] is translated to ESC [char] (bug#7541).
3268
5cc7f7af
KH
32692011-08-02 Kenichi Handa <handa@m17n.org>
3270
d0fffa3f 3271 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3272
3273 * chartab.c (uniprop_table): Make it non-static.
3274
525d5e6e
EZ
32752011-08-01 Eli Zaretskii <eliz@gnu.org>
3276
3277 * xdisp.c (forward_to_next_line_start): Accept additional argument
3278 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3279 on the newline.
3280 (reseat_at_next_visible_line_start): Use the bidi iterator state
3281 returned by forward_to_next_line_start to restore the state of
3282 it->bidi_it after backing up to previous newline. (Bug#9212)
3283
31011111
AS
32842011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3285
3286 * regex.c (re_comp): Protoize.
3287 (re_exec): Fix return type.
3288 (regexec): Fix type of `ret'. (Bug#9203)
3289
476371c4
PE
32902011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3291
e5d76069
PE
3292 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3293 This is needed if max-image-size is a floating-point number.
3294
9a79b20c
AS
32952011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3296
3297 * print.c (print_object): Print empty symbol as ##.
3298
3299 * lread.c (read1): Read ## as empty symbol.
3300
d8c2fa78
AA
33012011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3302
3303 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3304 setting frame foreground color (Bug#9175).
3305 (x_set_background_color): Likewise.
3306
ffe57a7a
AA
3307 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3308 contents (Bug#9176).
3309 (EmacsTooltip -init): Remove bezels and add shadows to
3310 tooltip windows.
3311
bf3492a5
AA
3312 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3313 or scroll bar (Bug#8470).
3314
d55e9c53
AA
3315 * nsfont.m (nsfont_open): Remove assignment to voffset and
3316 unnecessary vars hshink, expand, hd, full_height, min_height.
3317 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3318
3319 * nsterm.h (nsfont_info): Remove voffset field.
3320
d8c2fa78 33212011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3322
3323 Implement strike-through and overline on NextStep (Bug#8863).
3324
3325 * nsfont.m (nsfont_open): Use underline position provided by font,
3326 instead of hard-coded value of 2.
3327 (nsfont_draw): Call ns_draw_text_decoration instead.
3328
3329 * nsterm.h: Add declaration for ns_draw_text_decoration.
3330
3331 * nsterm.m (ns_draw_text_decoration): New function for drawing
3332 underline, overline, and strike-through.
3333 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3334 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3335 accommodate underlining, etc.
4843aac3 3336
4cc60b9b
EZ
33372011-07-28 Eli Zaretskii <eliz@gnu.org>
3338
bc7ece87
EZ
3339 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3340 default.
4cc60b9b 3341
476371c4
PE
33422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3343
66606eea
PE
3344 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3345 Without this fix, if a signal arrives just after memory fills up,
3346 'malloc' might be invoked reentrantly.
3347
476371c4
PE
3348 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3349 In other words, assume that every image size is allowed, on non-X
3350 hosts. This assumption is probably wrong, but it lets Emacs compile.
3351
f3fcc40d
AS
33522011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3353
3354 * regex.c (re_iswctype): Convert return values to boolean.
3355
350c992f
EZ
33562011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3357
3358 * xdisp.c (compute_display_string_pos): Don't use cached display
3359 string position if the buffer had its restriction changed.
3360 (Bug#9184)
3361
5266b4bb
PE
33622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3363
3364 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3365
2573a837 33662011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3367
41f55ccd 3368 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3369
39e378da
PE
3370 * bidi.c: Integer size and overflow fixes.
3371 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3372 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3373 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3374 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3375 (bidi_find_other_level_edge):
3376 Use ptrdiff_t instead of EMACS_INT where either will do.
3377 This works better on 32-bit hosts configured --with-wide-int.
3378 (bidi_cache_ensure_space): Check for size-calculation overflow.
3379 Use % rather than repeated addition, for better worst-case speed.
3380 Don't set bidi_cache_size until after xrealloc returns, because it
3381 might not return.
3382 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3383 (bidi_cache_ensure_space): Also check that the bidi cache size
3384 does not exceed that of the largest Lisp string or buffer. See Eli
3385 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3386
5e927815
PE
3387 * alloc.c (__malloc_size_t): Remove.
3388 All uses replaced by size_t. See Andreas Schwab's note
3389 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3390
ca4aa935
PE
3391 * image.c: Improve checking for integer overflow.
3392 (check_image_size): Assume that f is nonnull, since
3393 it is always nonnull in practice. This is one less thing to
3394 worry about when checking for integer overflow later.
3395 (x_check_image_size): New function, which checks for integer
3396 overflow issues inside X.
3397 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3398 This removes the need for a memory_full check.
3399 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3400 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3401 (xbm_read_bitmap_data): Change locals back to 'int', since
3402 their values must fit in 'int'.
3403 (xpm_load_image, png_load, tiff_load):
3404 Invoke x_create_x_image_and_pixmap earlier,
3405 to avoid much needless work if the image is too large.
3406 (tiff_load): Treat overly large images as if
3407 x_create_x_image_and_pixmap failed, not as malloc failures.
3408 (gs_load): Use x_check_image_size.
3409
5f8f9cc2
PE
3410 * gtkutil.c: Omit integer casts.
3411 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3412 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3413
5adf60bc
PE
3414 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3415
c8907a93
PE
3416 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3417 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3418 would wrongly return t on a 64-bit host.
3419
e3c25c68
PE
3420 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3421 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3422 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3423 and therefore cause GCC to emit a bogus diagnostic in some cases.
3424
3f791afe
PE
3425 * image.c: Integer signedness and overflow and related fixes.
3426 This is not an exhaustive set of fixes, but it's time to
3427 record what I've got.
3428 (lookup_pixel_color, check_image_size): Remove redundant decls.
3429 (check_image_size): Don't assume that arbitrary EMACS_INT values
3430 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3431 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3432 (tiff_load, imagemagick_load_image):
3433 Check for overflow in size calculations.
3434 (x_create_x_image_and_pixmap): Remove unnecessary test for
3435 xmalloc returning NULL; that can't happen.
3436 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3437 (xpm_color_bucket): Use better integer hashing function.
3438 (xpm_cache_color): Don't possibly over-allocate memory.
3439 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3440 (gif_memory_source):
3441 Use ptrdiff_t, not int or size_t, to record sizes.
3442 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3443 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3444 either works, as we prefer signed integers.
3445 (tiff_read_from_memory, tiff_write_from_memory):
3446 Return tsize_t, not size_t, since that's what the TIFF API wants.
3447 (tiff_read_from_memory): Don't fail simply because the read would
3448 go past EOF; instead, return a short read.
3449 (tiff_load): Omit no-longer-needed casts.
3450 (Fimagemagick_types): Don't assume size fits into 'int'.
3451
3cc5a532
PE
3452 Improve hashing quality when configured --with-wide-int.
3453 * fns.c (hash_string): New function, taken from sxhash_string.
3454 Do not discard information about ASCII character case; this
3455 discarding is no longer needed.
3456 (sxhash-string): Use it. Change sig to match it. Caller changed.
3457 * lisp.h: Declare it.
3458 * lread.c (hash_string): Remove, since we now use fns.c's version.
3459 The fns.c version returns a wider integer if --with-wide-int is
3460 specified, so this should help the quality of the hashing a bit.
3461
b312a492
PE
3462 * emacs.c: Integer overflow minor fix.
3463 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3464 Define only if GNU_LINUX.
3465 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3466
dfd153ae
PE
3467 * dispnew.c: Integer signedness and overflow fixes.
3468 Remove unnecessary forward decls, that were a maintenance hassle.
3469 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3470 All uses changed.
3471 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3472 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3473 (prepare_desired_row, line_draw_cost):
3474 Use int, not unsigned, where either works.
3475 (save_current_matrix, restore_current_matrix):
3476 Use ptrdiff_t, not size_t, where either works.
3477 (init_display): Check for overflow more accurately, and without
3478 relying on undefined behavior.
3479
a81d11a3
PE
3480 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3481 Remove, replacing with the new symbols in lisp.h. All uses changed.
3482 * fileio.c (make_temp_name):
3483 * filelock.c (lock_file_1, lock_file):
3484 * xdisp.c (message_dolog):
3485 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3486 Use pMd etc. instead.
3487 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3488 replacing the pWIDE etc. symbols removed from editfns.c.
3489
3300e6fd
PE
3490 * keyboard.h (num_input_events): Now uintmax_t.
3491 This is (very slightly) less likely to mess up due to wraparound.
3492 All uses changed.
3493
fd05c7e9
PE
3494 * buffer.c: Integer signedness fixes.
3495 (alloc_buffer_text, enlarge_buffer_text):
3496 Use ptrdiff_t rather than size_t when either will do, as we prefer
3497 signed integers.
3498
903fe15d
PE
3499 * alloc.c: Integer signedness and overflow fixes.
3500 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3501 (__malloc_size_t): Default to size_t, not to int.
3502 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3503 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3504 Prefer ptrdiff_t to size_t when either would do, as we prefer
3505 signed integers.
3506 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3507 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3508 Now const. Initialize with values that are in range even if char
3509 is signed.
3510 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3511 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3512 These functions do the right thing with sizes > 2**32.
3513 (check_depth): Now ptrdiff_t, not int.
3514 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3515 Adjust to new way of storing sizes. Check for size overflow bugs
3516 in rest of code.
3517 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3518 slightly wrong anyway, as it missed one instance of
3519 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3520 (refill_memory_reserve): Omit needless cast to size_t.
3521 (mark_object_loop_halt): Mark as externally visible.
3522
ac82cc6a
PE
3523 * xselect.c: Integer signedness and overflow fixes.
3524 (Fx_register_dnd_atom, x_handle_dnd_message):
3525 Use ptrdiff_t, not size_t, since we prefer signed.
3526 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3527 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3528 x_dnd_atoms_size and x_dnd_atoms_length.
3529
c2d1e36d
PE
3530 * doprnt.c: Prefer signed to unsigned when either works.
3531 * eval.c (verror):
3532 * doprnt.c (doprnt):
3533 * lisp.h (doprnt):
3534 * xdisp.c (vmessage):
3535 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3536 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3537 prefer signed arithmetic to avoid comparison confusion.
3538 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3539 but is a bit tricky.
3540
0e926e56
PE
3541 Assume freestanding C89 headers, string.h, stdlib.h.
3542 * data.c, doprnt.c, floatfns.c, print.c:
3543 Include float.h unconditionally.
3544 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3545 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3546 * regex.c: Likewise for stddef.h, string.h.
3547 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3548 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3549 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3550 (STDC_HEADERS): Remove obsolete defines.
3551 * sysdep.c: Include limits.h unconditionally.
3552
9cfdb3ec
PE
3553 Assume support for memcmp, memcpy, memmove, memset.
3554 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3555 * regex.c (memcmp, memcpy):
3556 Remove; we assume C89 now.
3557
3558 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3559 (__malloc_safe_bcopy): Remove; no longer needed.
3560
cf950e6b 3561 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3562 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3563 well either way, and we prefer signed to unsigned.
3564
dbf38e02
LMI
35652011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3566
3567 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3568 closes the connection while we're reading (bug#9182).
3569
d6f0886c 35702011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3571
d6f0886c
JD
3572 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3573 are specified (Bug#9168).
24e0f6b1 3574
2eb1f9e6
PE
35752011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3576
3577 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3578 Found by GCC static checking and --with-wide-int on a 32-bit host.
3579
22381272 35802011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3581
3582 * xdisp.c (compute_display_string_pos): Fix logic of caching
3583 previous display string position. Initialize cached_prev_pos to
3584 -1. Fixes slow-down at the beginning of a buffer.
3585
f25e39b4
EZ
35862011-07-24 Eli Zaretskii <eliz@gnu.org>
3587
3588 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3589 for attrs[LFACE_FONTSET_INDEX].
3590
04c4b52e
PE
35912011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3592
3593 * xml.c (parse_region): Remove unused local
3594 that was recently introduced.
3595
c1734fbd
EZ
35962011-07-23 Eli Zaretskii <eliz@gnu.org>
3597
be18c5a5
EZ
3598 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3599 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3600
c1734fbd
EZ
3601 * xdisp.c (move_it_in_display_line_to): Record the best matching
3602 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3603 exit if none of the characters scanned was an exact match.
3604 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3605 when exact match is impossible due to invisible text, and the
3606 lines are truncated.
3607
a258d627
JD
36082011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3609
3610 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3611 for OSX >= 10.7.
3612
b6d5a689
EZ
36132011-07-22 Eli Zaretskii <eliz@gnu.org>
3614
0f74f785
EZ
3615 Fix a significant slow-down of cursor motion with C-n, C-p,
3616 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3617 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3618 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3619 (next_element_from_buffer): Call compute_stop_pos_backwards to
3620 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3621 base_level_stop.
3622 (reseat): Don't look for prev_stop, as that could mean a very long
3623 run.
3624 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3625 <cached_disp_overlay_modiff>: Cache for last found display string
3626 position.
551918c1 3627 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3628 about the same buffer in the same area of character positions, and
3629 the buffer wasn't changed since the time the display string
3630 position was cached.
551918c1 3631
b2d0c91a
EZ
36322011-07-22 Eli Zaretskii <eliz@gnu.org>
3633
3634 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3635 is an integer, which is important for empty lines. (Bug#9149)
3636
043604ee
CY
36372011-07-22 Chong Yidong <cyd@stupidchicken.com>
3638
3639 * frame.c (Fmodify_frame_parameters): In tty case, update the
3640 default face if necessary (Bug#4238).
3641
da4adb04
CY
36422011-07-21 Chong Yidong <cyd@stupidchicken.com>
3643
3644 * editfns.c (Fstring_to_char): No need to explain what a character
3645 is in the docstring (Bug#6576).
3646
9abd0532
LMI
36472011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3648
3649 * xml.c (parse_region): Make sure we always return a tree.
3650
36881d16
HK
36512011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3652
3653 * xml.c (parse_region): If a document contains only comments,
3654 return that, too.
3655
1e98674d
LMI
36562011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3657
3658 * xml.c (make_dom): Return comments, too.
3659
590bd467
PE
36602011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3661
3662 Port to OpenBSD.
3663 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3664 and the surrounding thread.
3665 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3666 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3667 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3668 timer goes off.
3669 * s/openbsd.h (BROKEN_SIGIO): Define.
3670 * unexelf.c (unexec) [__OpenBSD__]:
3671 Don't update the .mdebug section of the Alpha COFF symbol table.
3672
f41628b2
LMI
36732011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3674
3675 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3676 (bug#8460).
3677
b59b67c5
PE
36782011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3679
15e3a074
PE
3680 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3681 This fixes some race conditions on the permissions of any newly
3682 created file.
3683
41bed37d
PE
3684 * alloc.c (valid_pointer_p): Use pipe, not open.
3685 This fixes some permissions issues when debugging.
3686
b59b67c5
PE
3687 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3688 If fchown fails to set both uid and gid, try to set just gid,
3689 as that is sometimes allowed. Adjust the file's mode to eliminate
3690 setuid or setgid bits that are inappropriate if fchown fails.
3691
925a6be7
SM
36922011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3693
3694 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3695 to compare Lisp_Objects.
3696 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3697 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3698 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3699
52968808
AS
37002011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3701
0a6a104b
AS
3702 * lread.c (read_integer): Unread even EOF character.
3703 (read1): Likewise. Properly record start position of symbol.
3704
52968808
AS
3705 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3706 symbol character follows.
3707
9e381cdd
PE
37082011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3709
3710 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3711 This works around a problem with the previous change to Fcopy_file.
3712 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3713 and without this change, GCC might complain about discarding
3714 fchown's return value.
3715
b5641435
JB
37162011-07-16 Juanma Barranquero <lekktu@gmail.com>
3717
3718 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3719
a8031457
PE
37202011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3721
3722 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3723
dd889327
LMI
37242011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3725
750c33f7
LMI
3726 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3727 it's used from the C level.
3728
dd889327
LMI
3729 * process.c: Use the same condition for POLL_FOR_INPUT in both
3730 keyboard.c and process.c (bug#1858).
3731
87e86684
LM
37322011-07-09 Lawrence Mitchell <wence@gmx.li>
3733
3734 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3735 (Fgnutls_boot): Use it.
3736
64348f40
AS
37372011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3738
3739 * doc.c (Fsubstitute_command_keys): Revert last change.
3740
1d698799
LMI
37412011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3742
f863868c
LMI
3743 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3744 quotes the next character, and doesn't affect other longer
3745 sequences (bug#8935).
3746
1d698799
LMI
3747 * lread.c (syms_of_lread): Clarify that is isn't only
3748 `eval-buffer' and `eval-defun' that's affected by
3749 `lexical-binding' (bug#8460).
3750
aa4b6df6
EZ
37512011-07-15 Eli Zaretskii <eliz@gnu.org>
3752
3753 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3754 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3755
5d856da6
PE
37562011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3757
ad6042bb
PE
3758 Fix minor problems found by static checking.
3759 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3760 (elsz): Now a signed constant, not a size_t var. We prefer signed
3761 types to unsigned, to avoid integer comparison confusion. Without
3762 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3763 "cannot optimize loop, the loop counter may overflow", a symptom
3764 of the confusion.
f00bbb22 3765 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3766 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3767
6468f31c
LMI
37682011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3769
49080b10
LMI
3770 * search.c (Fre_search_backward): Mention `case-fold-search' in
3771 all the re_search_* functions (bug#8138).
3772
6468f31c
LMI
3773 * keyboard.c (Fopen_dribble_file): Document when the file is
3774 closed (bug#8056).
3775
c965adc5
EZ
37762011-07-14 Eli Zaretskii <eliz@gnu.org>
3777
df9733bf
EZ
3778 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3779 bidi_cache_idx.
3780
0bb23927
EZ
3781 Support bidi reordering of display and overlay strings.
3782 * xdisp.c (compute_display_string_pos)
3783 (compute_display_string_end): Accept additional argument STRING.
3784 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3785 (reseat_to_string): Initialize bidi_it->string.s and
3786 bidi_it->string.schars.
3787 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3788 NULL (avoids a crash in bidi_paragraph_init).
3789 Initialize itb.string.lstring.
0bb23927
EZ
3790 (init_iterator): Call bidi_init_it only of a valid
3791 buffer position was specified. Initialize paragraph_embedding to
3792 L2R.
3793 (reseat_to_string): Initialize the bidi iterator.
3794 (display_string): If we need to ignore text properties of
3795 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3796 original value of -1 will not work with bidi.)
3797 (compute_display_string_pos): First arg is now struct
3798 `text_pos *'; all callers changed. Support display properties on
3799 Lisp strings.
3800 (compute_display_string_end): Support display properties on Lisp
3801 strings.
3802 (init_iterator, reseat_1, reseat_to_string): Initialize the
3803 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3804 when iterating on a string not from display properties).
640c8776
SM
3805 (compute_display_string_pos, compute_display_string_end):
3806 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3807 arrow keys.
3808 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3809 base_level_stop; instead, set base_level_stop to BEGV.
3810 Fixes crashes in vertical-motion.
0bb23927
EZ
3811 (next_element_from_buffer): Improve commentary for when
3812 the iterator is before prev_stop.
3813 (init_iterator): Initialize bidi_p from the default value of
3814 bidi-display-reordering, not from buffer-local value. Use the
3815 buffer-local value only if initializing for buffer iteration.
3816 (handle_invisible_prop): Support invisible properties on strings
3817 that are being bidi-reordered.
3818 (set_iterator_to_next): Support bidi reordering of C strings and
3819 Lisp strings.
3820 (next_element_from_string): Support bidi reordering of Lisp
3821 strings.
3822 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3823 (display_string): Support display of R2L glyph rows.
3824 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3825 (init_iterator): Don't initialize it->bidi_p for strings
3826 here.
3827 (reseat_to_string): Initialize it->bidi_p for strings here.
3828 (next_element_from_string, next_element_from_c_string)
3829 (next_element_from_buffer): Add xassert's for correspondence
3830 between IT's object being iterated and it->bidi_it.string
3831 structure.
3832 (face_before_or_after_it_pos): Support bidi iteration.
3833 (next_element_from_c_string): Handle the case of the first string
3834 character that is not the first one in the visual order.
3835 (get_visually_first_element): New function, refactored from common
3836 parts of next_element_from_buffer, next_element_from_string, and
3837 next_element_from_c_string.
3838 (tool_bar_lines_needed, redisplay_tool_bar)
3839 (display_menu_bar): Force left-to-right direction. Add a FIXME
3840 comment for making that be controlled by a user option.
3841 (push_it, pop_it): Save and restore the state of the
3842 bidi iterator. Save and restore the bidi_p flag.
3843 (pop_it): Iterate out of display property for string iteration as
3844 well.
3845 (iterate_out_of_display_property): Support iteration over strings.
3846 (handle_single_display_spec): Set up it->bidi_it for iteration
3847 over a display string, and call bidi_init_it.
3848 (handle_single_display_spec, next_overlay_string)
3849 (get_overlay_strings_1, push_display_prop): Set up the bidi
3850 iterator for displaying display or overlay strings.
3851 (forward_to_next_line_start): Don't use the shortcut if
3852 bidi-iterating.
3853 (back_to_previous_visible_line_start): If handle_display_prop
3854 pushed the iterator stack, restore the internal state of the bidi
3855 iterator by calling bidi_pop_it same number of times.
3856 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3857 and we are bidi-iterating, don't decrement the iterator position;
3858 instead, set the first_elt flag in the bidi iterator, to produce
3859 the same effect.
3860 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3861 (push_display_prop): xassert that we are iterating a buffer.
3862 (push_it, pop_it): Save and restore paragraph_embedding member.
3863 (handle_single_display_spec, next_overlay_string)
3864 (get_overlay_strings_1, reseat_1, reseat_to_string)
3865 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3866 correctly. Don't assume unibyte strings are not bidi-reordered.
3867 (compute_display_string_pos)
3868 (compute_display_string_end): Fix handling the case of C string.
3869 (push_it, pop_it): Save and restore from_disp_prop_p.
3870 (handle_single_display_spec, push_display_prop): Set the
3871 from_disp_prop_p flag.
3872 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3873 (pop_it): Call iterate_out_of_display_property only if we are
3874 popping after iteration over a string that came from a display
3875 property. Fix a typo in popping stretch info. Add an assertion
3876 for verifying that the iterator position is in sync with the bidi
3877 iterator.
3878 (handle_single_display_spec, get_overlay_strings_1)
3879 (push_display_prop): Fix initialization of paragraph direction for
3880 string when that of the parent object is not yet determined.
3881 (reseat_1): Call bidi_init_it to resync the bidi
3882 iterator with IT's position. (Bug#7616)
3883 (find_row_edges): If ROW->start.pos gives position
3884 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3885 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3886 Reset the from_disp_prop_p flag.
3887 (SAVE_IT, RESTORE_IT): New macros.
3888 (pos_visible_p, face_before_or_after_it_pos)
3889 (back_to_previous_visible_line_start)
3890 (move_it_in_display_line_to, move_it_in_display_line)
3891 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3892 (try_scrolling, redisplay_window, display_line): Use them when
3893 saving a temporary copy of the iterator and restoring it back.
3894 (back_to_previous_visible_line_start, reseat_1)
3895 (init_iterator): Empty the bidi cache "stack".
3896 (move_it_in_display_line_to): If iterator ended up at
3897 EOL, but we never saw any buffer positions smaller than
3898 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3899 motion in bidi-reordered lines.
3900 (move_it_in_display_line_to): Record prev_method and prev_pos
3901 immediately before the call to set_iterator_to_next. Fixes cursor
3902 motion in bidi-reordered lines with stretch glyphs and strings
3903 displayed in margins. (Bug#8133) (Bug#8867)
3904 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3905 TO_CHARPOS.
640c8776
SM
3906 (pos_visible_p): Support positions in bidi-reordered lines.
3907 Save and restore bidi cache.
0bb23927
EZ
3908
3909 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3910 (bidi_paragraph_info): Delete unused struct.
3911 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3912 (bidi_cache_start): New variable.
3913 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3914 to zero.
3915 (bidi_cache_fetch_state, bidi_cache_search)
3916 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3917 (bidi_cache_find, bidi_peek_at_next_level)
3918 (bidi_level_of_next_char, bidi_find_other_level_edge)
3919 (bidi_move_to_visually_next): Compare cache index with
3920 bidi_cache_start rather than with zero.
3921 (bidi_fetch_char): Accept new argument STRING; all callers
3922 changed. Support iteration over a string. Support strings with
3923 display properties. Support unibyte strings. Fix the type of
3924 `len' according to what STRING_CHAR_AND_LENGTH expects.
3925 (bidi_paragraph_init, bidi_resolve_explicit_1)
3926 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3927 (bidi_level_of_next_char, bidi_move_to_visually_next):
3928 Support iteration over a string.
0bb23927
EZ
3929 (bidi_set_sor_type, bidi_resolve_explicit_1)
3930 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3931 can now be zero (for strings); special values 0 and -1 were
3932 changed to -1 and -2, respectively.
3933 (bidi_char_at_pos): New function.
3934 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3935 Call it instead of FETCH_MULTIBYTE_CHAR.
3936 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3937 initialized to valid values.
3938 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3939 values.
3940 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3941 the test for valid cached positions. Fix the logic for looking up
3942 the sentinel state in the cache. GCPRO the Lisp string we are
3943 iterating.
3944 (bidi_push_it, bidi_pop_it): New functions.
3945 (bidi_initialize): Initialize the bidi cache start stack pointer.
3946 (bidi_cache_ensure_space): New function, refactored from part of
3947 bidi_cache_iterator_state. Don't assume the required size is just
3948 one BIDI_CACHE_CHUNK away.
3949 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3950 (bidi_count_bytes, bidi_char_at_pos): New functions.
3951 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3952 always valid if bidi_cache_idx is valid.
3953 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3954 is valid if it's going to be used.
3955 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3956 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3957 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3958 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3959 (bidi_find_other_level_edge, bidi_cache_start_stack):
3960 All variables related to cache indices are now EMACS_INT.
c965adc5 3961
0bb23927
EZ
3962 * dispextern.h (struct bidi_string_data): New structure.
3963 (struct bidi_it): New member `string'. Make flag members be 1-bit
3964 fields, and put them last in the struct.
640c8776
SM
3965 (compute_display_string_pos, compute_display_string_end):
3966 Update prototypes.
0bb23927
EZ
3967 (bidi_push_it, bidi_pop_it): Add prototypes.
3968 (struct iterator_stack_entry): New members bidi_p,
3969 paragraph_embedding, and from_disp_prop_p.
3970 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3971 (bidi_shelve_cache, bidi_unshelve_cache):
3972 Declare prototypes.
0bb23927
EZ
3973
3974 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3975 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3976 and vector-like objects.
3977
3978 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3979 cache around display iteration.
3980
3981 * window.c (Fwindow_end, window_scroll_pixel_based)
3982 (displayed_window_lines, Frecenter): Save and restore the bidi
3983 cache around display iteration.
3984
3bbd2265
LMI
39852011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3986
3987 * editfns.c (Fdelete_region): Clarify the use of the named
3988 parameters (bug#6788).
3989
adc47434
MR
39902011-07-14 Martin Rudalics <rudalics@gmx.at>
3991
3992 * indent.c (Fvertical_motion): Set and restore w->pointm when
3993 saving and restoring the window's buffer (Bug#9006).
3994
837c31f8
LMI
39952011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3996
3997 * editfns.c (Fstring_to_char): Clarify just what is returned
3998 (bug#6576). Text by Eli Zaretskii.
3999
ac389d0c
JB
40002011-07-13 Juanma Barranquero <lekktu@gmail.com>
4001
4002 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4003
0be0ce47
EZ
40042011-07-13 Eli Zaretskii <eliz@gnu.org>
4005
4006 * buffer.c (mmap_find): Fix a typo.
4007
cd18e7e3
JB
40082011-07-13 Johan Bockgård <bojohan@gnu.org>
4009
4010 Fix execution of x selection hooks.
4011 * xselect.c (Qx_lost_selection_functions)
4012 (Qx_sent_selection_functions): New vars.
4013 (syms_of_xselect): DEFSYM them.
4014 (x_handle_selection_request): Pass Qx_sent_selection_functions
4015 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4016 (x_handle_selection_clear,x_clear_frame_selections):
4017 Pass Qx_lost_selection_functions rather than
4018 Vx_lost_selection_functions to Frun_hook_with_args.
4019
47ea7f44
PE
40202011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4021
ac389d0c 4022 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4023 The old code sometimes used this field without initializing it.
4024
47ea7f44
PE
4025 * alloc.c (gc_sweep): Don't read past end of array.
4026 In theory, the old code could also have corrupted Emacs internals,
4027 though it'd be very unlikely.
4028
bc985c87
AS
40292011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4030
4031 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4032 argument. (Bug#4026)
bc985c87 4033
0cf34688
LMI
40342011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4035
b3dadd76
LMI
4036 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4037 key" (bug#4257).
4038
0cf34688
LMI
4039 * window.c (Fset_window_start): Doc fix (bug#4199).
4040 (Fset_window_hscroll): Ditto.
4041
270768cd
PE
40422011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4043
077e3dda 4044 Fix minor new problems caught by GCC 4.6.1.
270768cd 4045 * term.c (init_tty): Remove unused local.
490011a6 4046 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4047 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4048 not used otherwise.
270768cd 4049
b1f58454
CY
40502011-07-12 Chong Yidong <cyd@stupidchicken.com>
4051
4052 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4053
22b9578d
LMI
40542011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4055
6e70ab07
LMI
4056 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4057 are the mini-buffer and the echo area (bug#3320).
4058
22b9578d
LMI
4059 * term.c (init_tty): Remove support for supdup, c10 and perq
4060 terminals, which are no longer supported (bug#1482).
4061
8974cc9f
JB
40622011-07-10 Johan Bockgård <bojohan@gnu.org>
4063
4064 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4065
a560d974
JD
40662011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4067
4068 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4069 for non-popups (Bug#3642).
4070
1dae0f0a
AS
40712011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4072
268c2c36 4073 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4074 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4075 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4076 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4077 * data.c (fmod): Likewise.
4078 * dispnew.c (swap_glyphs_in_rows): Likewise.
4079 * emacs.c (memory_warning_signal): Likewise.
4080 * floatfns.c (float_error): Likewise.
4081 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4082 (otf_open, font_otf_capability, generate_otf_features)
4083 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4084 Likewise.
4085 * image.c (pbm_read_file): Likewise.
4086 * indent.c (string_display_width): Likewise.
4087 * intervals.c (check_for_interval, search_for_interval)
4088 (inc_interval_count, count_intervals, root_interval)
4089 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4090 * lread.c (defalias): Likewise.
268c2c36 4091 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4092 * regex.c (set_image_of_range_1, set_image_of_range)
4093 (regex_grow_registers): Likewise.
4094 * sysdep.c (strerror): Likewise.
4095 * termcap.c (valid_filename_p, tprint, main): Likewise.
4096 * tparam.c (main): Likewise.
4097 * unexhp9k800.c (run_time_remap, save_data_space)
4098 (update_file_ptrs, read_header, write_header, calculate_checksum)
4099 (copy_file, copy_rest, display_header): Likewise.
4100 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4101 Likewise.
4102 * xdisp.c (check_it): Likewise.
4103 * xfaces.c (register_color, unregister_color, unregister_colors):
4104 Likewise.
4105 * xfns.c (print_fontset_result): Likewise.
4106 * xrdb.c (member, fatal, main): Likewise.
4107
99033785
PE
41082011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4109
4110 Fix minor problems found by static checking (Bug#9031).
4111 * chartab.c (char_table_set_range, map_sub_char_table):
4112 Remove unused locals.
4113 (uniprop_table): Now static.
4114 * composite.c (_work_char): Remove unused static var.
4115
9cb2ac56
JB
41162011-07-09 Juanma Barranquero <lekktu@gmail.com>
4117
4118 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4119
f25661f0
JD
41202011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4121
4122 * gtkutil.c (qttip_cb): Remove code without function.
4123
8278c4fe
EZ
41242011-07-09 Eli Zaretskii <eliz@gnu.org>
4125
4126 * w32.c (pthread_sigmask): New stub.
4127
1692ae2d 41282011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4129
8a6ebd58 4130 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4131 sigprocmask is portable only for single-threaded applications, and
4132 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4133 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4134 (LIBES): Use it.
4135 * callproc.c (Fcall_process):
4136 * process.c (create_process):
4137 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4138 Use pthread_sigmask, not sigprocmask.
123403e4 4139
1b854618
JD
41402011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4141
4142 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4143 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4144 wrong (Bug#8591).
4145
3fe4b549
JD
41462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4147
0ce7e563
JD
4148 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4149 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4150 (xg_hide_tooltip): Fix comment.
4151
3fe4b549
JD
4152 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4153 in registerServicesMenuSendTypes.
4154 (validRequestorForSendType): Don't check ns_return_types.
4155
4156 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4157 ns_return_type.
4158
5df75e47
JR
41592011-07-08 Jason Rumney <jasonr@gnu.org>
4160
22610910
JR
4161 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4162 SH_SHOW for hidden windows (Bug#5482).
4163
5df75e47
JR
4164 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4165 frame struct members of non-existent frames (Bug#6284).
4166
699c10bd
JD
41672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4168
4393663b
JD
4169 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4170 variable firstTime not needed on OSX >= 10.6.
4171 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4172 >= 10.5. Use setKnobProportion, setDoubleValue.
4173
4174 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4175 (MAC_OS_X_VERSION_10_5): Define if not defined.
4176 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4177 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4178 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4179
4180 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4181 cString and lossyCString on OSX >= 10.4
4182
58179cce 4183 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4184 sizeToFit on OSX >= 10.2.
4185
4186 * nsimage.m (allocInitFromFile): Don't use deprecated method
4187 bestRepresentationForDevice on OSX >= 10.6.
4188
4189 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4190 to avoid warning.
4191
4192 * emacs.c: Declare unexec_init_emacs_zone.
4193
a63e0781
JD
4194 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4195
699c10bd
JD
4196 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4197
4198 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4199 on svcsMenu (Bug#8842).
4200
4201 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4202 ns_return_types.
4203 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4204
4205 * nsterm.m (QUTF8_STRING): Declare.
4206 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4207 (validRequestorForSendType): Return type is (id).
4208 Change indexOfObjectIdenticalTo to indexOfObject.
4209 Check if we have local selection before returning self (Bug#8842).
4210 (writeSelectionToPasteboard): Put local selection into paste board
4211 if we have a local selection (Bug#8842).
4212 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4213
4214 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4215 (ns_get_local_selection): Declare.
4216
54e10184
LMI
42172011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4218
9888ff71
LMI
4219 * keymap.c (describe_map_tree): Don't insert a double newline at
4220 the end of the buffer (bug#1169) and return whether we inserted
4221 something.
4222
54e10184
LMI
4223 * callint.c (Fcall_interactively): Change "reading args" to
4224 "providing args" to try to clarify what it does (bug#1010).
4225
15fa4783
KH
42262011-07-07 Kenichi Handa <handa@m17n.org>
4227
4228 * composite.c (composition_compute_stop_pos): Ignore a static
4229 composition starting before CHARPOS (Bug#8915).
4230
4231 * xdisp.c (handle_composition_prop): Likewise.
4232
a8815b00
EZ
42332011-07-07 Eli Zaretskii <eliz@gnu.org>
4234
4235 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4236 (Bug#9015)
4237
ef7b981d 42382011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4239
4240 * character.h (unicode_category_t): New enum type.
4241
4242 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4243 (Qchar_code_property_table): New variable.
4244 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4245 (UNIPROP_COMPRESSED_FORM_P): New macros.
4246 (char_table_ascii): Uncompress the compressed values.
4247 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4248 Uncompress the compressed values.
ac389d0c 4249 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4250 (char_table_ref_and_range): Uncompress the compressed values.
4251 (sub_char_table_set): New arg is_uniprop. Callers changed.
4252 Uncompress the compressed values.
4253 (sub_char_table_set_range): Args changed. Callers changed.
4254 (char_table_set_range): Adjuted for the above change.
4255 (map_sub_char_table): Delete args default_val and parent. Add arg
4256 top. Give decoded values to a Lisp function.
640c8776 4257 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4258 values to a Lisp function. Gcpro more variables.
4259 (uniprop_table_uncompress)
4260 (uniprop_decode_value_run_length): New functions.
4261 (uniprop_decoder, uniprop_decoder_count): New variables.
4262 (uniprop_get_decoder, uniprop_encode_value_character)
4263 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4264 New functions.
4265 (uniprop_encoder, uniprop_encoder_count): New variables.
4266 (uniprop_get_encoder, uniprop_table)
4267 (Funicode_property_table_internal, Fget_unicode_property_internal)
4268 (Fput_unicode_property_internal): New functions.
4269 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4270 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4271 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4272 char-code-property-alist.
4273
640c8776 4274 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4275 Vunicode_category_table.
4276
640c8776 4277 * font.c (font_range): Adjust for the change of
c805dec0
KH
4278 Vunicode_category_table.
4279
76b397fb
DN
42802011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4281
4282 * m/iris4d.h: Remove file, move contents ...
4283 * s/irix6-5.h: ... here.
4284
22b4128e
PE
42852011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4286
4287 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4288 * alloc.c (mark_buffer):
4289 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4290 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4291 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4292 This isn't true in general, and it's particularly not true
4293 if Emacs is configured with --with-wide-int.
4294 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4295 New macros, used in the buffer.c change.
4296
869795d6
JD
42972011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4298
4299 * xsettings.c: Use both GConf and GSettings if both are available.
4300 (store_config_changed_event): Add comment.
4301 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4302 (store_tool_bar_style_changed): New functions.
5e617bc2 4303 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4304 (struct xsettings): Move font inside HAVE_XFT.
4305 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4306 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4307 Move inside HAVE_XFT.
640c8776 4308 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4309 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4310 also.
4311 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4312 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4313 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4314 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4315 (parse_settings): Move check for font inside HAVE_XFT.
4316 (read_settings, apply_xft_settings): Add comment.
4317 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4318 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4319 call store_font_name_changed.
4320 (xft_settings_event): Add comment.
4321 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4322 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4323 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4324 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4325 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4326 (xsettings_get_system_font, xsettings_get_system_normal_font):
4327 Add comment.
869795d6 4328
d8ed26bd
PE
43292011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4330
4331 Random fixes. E.g., (random) never returned negative values.
4332 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4333 subseconds part to the entropy, as that's a bit more random.
4334 Prefer signed to unsigned, since the signedness doesn't matter and
4335 in general we prefer signed. When given a limit, use a
4336 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4337 latter isn't right if USE_2_TAGS_FOR_INTS.
4338 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4339 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4340
cabf1cac
SM
43412011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4342
4343 * textprop.c (text_property_stickiness):
4344 Obey Vtext_property_default_nonsticky.
4345 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4346 * w32fns.c (syms_of_w32fns):
4347 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4348
6e9b2be9
PE
43492011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4350
4351 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4352 This is more efficient than Ffile_directory_p and avoids a minor race.
4353
90186c68
LMI
43542011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4355
7c301272
LMI
4356 * buffer.c (Foverlay_put): Say what the return value is
4357 (bug#7835).
4358
c4f2d8d4
LMI
4359 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4360 is a directory before asking whether to use the file name
4361 (bug#7564).
ad637907
LMI
4362 (barf_or_query_if_file_exists): Make the "File is a directory"
4363 error be more correct.
c4f2d8d4 4364
90186c68
LMI
4365 * fns.c (Frequire): Remove the mention of the .gz files, since
4366 that's installation-specific, but keep the mention of
4367 `get-load-suffixes'.
4368
da64016e
PE
43692011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4372 Report string overflow if the output is too long.
4373
7d47b580
JB
43742011-07-04 Juanma Barranquero <lekktu@gmail.com>
4375
a555cb87
JB
4376 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4377 (syms_of_gnutls): Remove duplicate DEFSYM for
4378 Qgnutls_bootprop_verify_hostname_error, an error for
4379 Qgnutls_bootprop_verify_error (which is no longer used).
4380
7d47b580
JB
4381 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4382 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4383 Also (re)move comments that are misplaced or no longer relevant.
4384
1e49bfab
LMI
43852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4386
4387 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4388
1485f4c0
CY
43892011-07-03 Chong Yidong <cyd@stupidchicken.com>
4390
4391 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4392 and background color parameters if they have been changed.
4393
a9ab721e
LMI
43942011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4395
4396 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4397
cf7cff57
PE
43982011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4399
2e13213d
PE
4400 * xsettings.c (SYSTEM_FONT): Define only when used.
4401 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4402
cf7cff57
PE
4403 * keymap.c (access_keymap_1): Now static.
4404
7a8e04f7
CY
44052011-07-02 Chong Yidong <cyd@stupidchicken.com>
4406
4407 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4408 leave any prefix arg for the up event (Bug#1586).
4409
61352f62
LMI
44102011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4411
69bb1ef7
LMI
4412 * lread.c (syms_of_lread): Mention single symbols defined by
4413 `defvar' or `defconst' (bug#7154).
4414
61352f62 4415 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4416 (Frequire): Mention get-load-suffixes.
61352f62 4417
28545e04
MR
44182011-07-02 Martin Rudalics <rudalics@gmx.at>
4419
4420 * window.h (window): Remove clone_number slot.
4421 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4422 Remove.
4423 (make_parent_window, make_window, saved_window)
4424 (Fset_window_configuration, save_window_save): Don't deal with
4425 clone numbers.
4426 * buffer.c (Qclone_number): Remove declaration.
4427 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4428
3349e122
SM
44292011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4430
4431 Add multiple inheritance to keymaps.
4432 * keymap.c (Fmake_composed_keymap): New function.
4433 (Fset_keymap_parent): Simplify.
4434 (fix_submap_inheritance): Remove.
4435 (access_keymap_1): New function extracted from access_keymap to handle
4436 embedded parents and handle lists of maps.
4437 (access_keymap): Use it.
4438 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4439 (Fcopy_keymap): Handle embedded parents.
4440 (Fcommand_remapping, define_as_prefix): Simplify.
4441 (Fkey_binding): Simplify.
4442 (syms_of_keymap): Move minibuffer-local-completion-map,
4443 minibuffer-local-filename-completion-map,
4444 minibuffer-local-must-match-map, and
4445 minibuffer-local-filename-must-match-map to Elisp.
4446 (syms_of_keymap): Defsubr make-composed-keymap.
4447 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4448 (parse_menu_item): Trivial simplification.
4449
3279eb87
GM
44502011-07-01 Glenn Morris <rgm@gnu.org>
4451
4452 * Makefile.in (SETTINGS_LIBS): Fix typo.
4453
4550efdf
KI
44542011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4455
4456 * coding.c (Fencode_coding_string): Record the last coding system
4457 used, as the function doc string says (bug#8738).
4458
0949d2b6
JD
44592011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4460
4461 * xsettings.c (store_monospaced_changed): Take new font as arg and
4462 check for change against current_mono_font.
4463 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4464 (emacs_settings_constructor, emacs_settings_get_property)
4465 (emacs_settings_set_property, emacs_settings_class_init)
4466 (emacs_settings_init, gsettings_obj): Remove.
4467 (something_changedCB): New function for HAVE_GSETTINGS.
4468 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4469 with value as argument.
4470 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4471 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4472 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4473 "changed".
4474
4475 * xgselect.c: Add defined (HAVE_GSETTINGS).
4476 (xgselect_initialize): Ditto.
4477
4478 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4479 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4480 xg_select.
4481
bbc6b304
PE
44822011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 * eval.c (struct backtrace): Simplify and port the data structure.
4485 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4486 signed bit field, as this assumption is not portable and it makes
4487 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4488 "char debug_on_exit : 1" as this is not portable either; instead,
4489 use the portable "unsigned int debug_on_exit : 1". Remove unused
4490 member evalargs. Remove obsolete comments about cc bombing out.
4491
9851bfc5
JD
44922011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4493
51bb811f 4494 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4495 Let HAVE_GSETTINGS override HAVE_GCONF.
4496 (store_monospaced_changed): New function.
4497 (EMACS_SETTINGS): A new type derived from GObject to handle
4498 GSettings notifications.
4499 (emacs_settings_constructor, emacs_settings_get_property)
4500 (emacs_settings_set_property, emacs_settings_class_init):
4501 New functions.
4502 (gsettings_client, gsettings_obj): New variables.
4503 (GSETTINGS_SCHEMA): New define.
4504 (something_changedCB): Call store_monospaced_changed.
4505 (init_gsettings): New function.
4506 (xsettings_initialize): Call init_gsettings.
4507 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4508 to NULL.
4509
640c8776 4510 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4511 GCONF_CFLAGS/LIBS.
4512
5386012d
MR
45132011-06-29 Martin Rudalics <rudalics@gmx.at>
4514
4515 * window.c (resize_root_window, grow_mini_window)
4516 (shrink_mini_window): Rename Qresize_root_window to
4517 Qwindow_resize_root_window and Qresize_root_window_vertically to
4518 Qwindow_resize_root_window_vertically.
4519
f13e0b08
PE
45202011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4521
4522 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4523
94515237
JB
45242011-06-27 Juanma Barranquero <lekktu@gmail.com>
4525
4526 * makefile.w32-in: Redesign dependencies so they reflect more
4527 clearly which files are directly included by each source file,
4528 and not through other includes.
4529
e43b6e43
MR
45302011-06-27 Martin Rudalics <rudalics@gmx.at>
4531
4532 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4533 (sort_overlays, overlay_strings): When an overlay's clone number
4534 matches the window's clone number process the overlay even if
4535 the overlay's window property doesn't match the current window.
4536
d68443dc
MR
4537 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4538 (Fwindow_hchild): Rename to Fwindow_left_child.
4539 (Fwindow_next): Rename to Fwindow_next_sibling.
4540 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4541 (resize_window_check): Rename to window_resize_check.
4542 (resize_window_apply): Rename to window_resize_apply.
4543 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4544 (Fdelete_other_windows_internal, resize_frame_windows)
4545 (Fsplit_window_internal, Fdelete_window_internal)
4546 (grow_mini_window, shrink_mini_window)
4547 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4548
c7e73be5
JD
45492011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4550
4551 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4552 (emacs_fixed_set_min_size): Remove.
4553 (emacs_fixed_new): Take frame as argument.
4554
4555 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4556 (_EmacsFixedPrivate): Remove minwidth/height.
4557 Add struct frame *f.
4558 (emacs_fixed_init): Initialize priv->f.
4559 (get_parent_class, emacs_fixed_set_min_size): Remove.
4560 (emacs_fixed_new): Set priv->f to argument.
4561 (emacs_fixed_get_preferred_width)
4562 (emacs_fixed_get_preferred_height): Use min_width/height from
4563 frames size_hint to set minimum and natural (Bug#8919).
4564 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4565 and use min_width/height from frames size_hint to set
4566 min_width/height (Bug#8919).
4567
4568 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4569 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4570 Fix indentation.
c7e73be5 4571
cf99dcf8
EZ
45722011-06-26 Eli Zaretskii <eliz@gnu.org>
4573
4574 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4575 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4576 called at ZV.
4577
029529ac
CY
45782011-06-26 Chong Yidong <cyd@stupidchicken.com>
4579
4580 * process.c (wait_reading_process_output): Bypass select if
4581 waiting for a cell while ignoring keyboard input, and input is
4582 pending. Suggested by Jan Djärv (Bug#8869).
4583
7a7ef429
PE
45842011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4585
4586 Use gnulib's dup2 module instead of rolling our own.
4587 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4588
11fdef7d 45892011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4590
4591 * dispnew.c (scrolling_window): Before scrolling, turn off a
4592 mouse-highlight in the window being scrolled.
4593
cd3520a4
JB
45942011-06-24 Juanma Barranquero <lekktu@gmail.com>
4595
4596 Move DEFSYM to lisp.h and use everywhere.
4597
4598 * character.h (DEFSYM): Move declaration...
4599 * lisp.h (DEFSYM): ...here.
4600
4601 * gnutls.c:
4602 * minibuf.c:
4603 * w32menu.c:
4604 * w32proc.c:
4605 * w32select.c: Don't include character.h.
4606
4607 * alloc.c (syms_of_alloc):
4608 * buffer.c (syms_of_buffer):
4609 * bytecode.c (syms_of_bytecode):
4610 * callint.c (syms_of_callint):
4611 * casefiddle.c (syms_of_casefiddle):
4612 * casetab.c (init_casetab_once):
4613 * category.c (init_category_once, syms_of_category):
4614 * ccl.c (syms_of_ccl):
4615 * cmds.c (syms_of_cmds):
4616 * composite.c (syms_of_composite):
4617 * dbusbind.c (syms_of_dbusbind):
4618 * dired.c (syms_of_dired):
4619 * dispnew.c (syms_of_display):
4620 * doc.c (syms_of_doc):
4621 * editfns.c (syms_of_editfns):
4622 * emacs.c (syms_of_emacs):
4623 * eval.c (syms_of_eval):
4624 * fileio.c (syms_of_fileio):
4625 * fns.c (syms_of_fns):
4626 * frame.c (syms_of_frame):
4627 * fringe.c (syms_of_fringe):
4628 * insdel.c (syms_of_insdel):
4629 * keymap.c (syms_of_keymap):
4630 * lread.c (init_obarray, syms_of_lread):
4631 * macros.c (syms_of_macros):
4632 * msdos.c (syms_of_msdos):
4633 * print.c (syms_of_print):
4634 * process.c (syms_of_process):
4635 * search.c (syms_of_search):
4636 * sound.c (syms_of_sound):
4637 * syntax.c (init_syntax_once, syms_of_syntax):
4638 * terminal.c (syms_of_terminal):
4639 * textprop.c (syms_of_textprop):
4640 * undo.c (syms_of_undo):
4641 * w32.c (globals_of_w32):
4642 * window.c (syms_of_window):
4643 * xdisp.c (syms_of_xdisp):
4644 * xfaces.c (syms_of_xfaces):
4645 * xfns.c (syms_of_xfns):
4646 * xmenu.c (syms_of_xmenu):
4647 * xsettings.c (syms_of_xsettings):
4648 * xterm.c (syms_of_xterm): Use DEFSYM.
4649
4228cf16
TZ
46502011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4651
cd3520a4 4652 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4653
7fcccf1e
PE
46542011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4655
7efb4e0e
PE
4656 Integer and buffer overflow fixes (Bug#8873).
4657
ff5844ad
PE
4658 * print.c (printchar, strout): Check for string overflow.
4659 (PRINTPREPARE, printchar, strout):
4660 Don't set size unless allocation succeeds.
4661
90532f02
PE
4662 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4663 for sizes. Check for string overflow more accurately.
4664 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4665
6d84508d
PE
4666 * macros.c: Integer and buffer overflow fixes.
4667 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4668 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4669 Use ptrdiff_t, not int, for sizes.
4670 Don't increment bufsize until after realloc succeeds.
4671 Check for size-calculation overflow.
4672 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4673
437b2cb4
PE
4674 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4675
8b9ac8b4
PE
4676 * lread.c: Integer overflow fixes.
4677 (read_integer): Radix is now EMACS_INT, not int,
4678 to improve quality of diagnostics for out-of-range radices.
4679 Calculate buffer size correctly for out-of-range radices.
4680 (read1): Check for integer overflow in radices, and in
4681 read-circle numbers.
82cb60d3
PE
4682 (read_escape): Avoid int overflow.
4683 (Fload, openp, read_buffer_size, read1)
4684 (substitute_object_recurse, read_vector, read_list, map_obarray):
4685 Use ptrdiff_t, not int, for sizes.
4686 (read1): Use EMACS_INT, not int, for sizes.
20270765 4687 Check for size overflow.
8b9ac8b4 4688
7fcccf1e
PE
4689 * image.c (cache_image): Check for size arithmetic overflow.
4690
bfbbd7e7
PE
4691 * lread.c: Integer overflow issues.
4692 (saved_doc_string_size, saved_doc_string_length)
4693 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4694 Now ptrdiff_t, not int.
4695 (read1): Don't assume doc string length fits in int. Check for
4696 out-of-range doc string lengths.
4697 (read_list): Don't assume file position fits in int.
39019e54 4698 (read_escape): Check for hex character overflow.
bfbbd7e7 4699
4e323265
LL
47002011-06-22 Leo Liu <sdl.web@gmail.com>
4701
4702 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4703 Move to minibuffer.el.
4704
85fece3e
PE
47052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4706
20b84ce9 4707 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4708 The following patches are for when GLYPH_DEBUG && !XASSERT.
4709 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4710 * dispnew.c (flush_stdout):
4711 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4712 Mark as externally visible.
4713 * dispnew.c (check_window_matrix_pointers): Now static.
4714 * dispnew.c (window_to_frame_vpos):
4715 * xfns.c (unwind_create_frame):
4716 * xterm.c (x_check_font): Remove unused local.
4717 * scroll.c (CHECK_BOUNDS):
4718 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4719 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4720 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4721 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4722 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4723 Now static.
4724 (debug_method_add): Use va_list and vsprintf rather than relying
4725 on undefined behavior with wrong number of arguments.
4726 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4727 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4728 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4729 since we're not interested in debugging glyphs with old libraries.
4730 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4731 GCC 4.6.0's static checking.
4732
0766b489
PE
47332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4734
31fd4b32
PE
4735 Integer overflow and signedness fixes (Bug#8873).
4736 A few related buffer overrun fixes, too.
4737
b79e8648
PE
4738 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4739
0766b489
PE
4740 * dispextern.h (struct face.stipple):
4741 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4742 (x_bitmap_mask, x_allocate_bitmap_record)
4743 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4744 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4745 (x_create_bitmap_from_xpm_data):
4746 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4747 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4748 (.bitmaps_last):
4749 * xfaces.c (load_pixmap):
4750 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4751 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4752 (.bitmaps_last, struct x_output.icon_bitmap):
4753 Use ptrdiff_t, not int, for bitmap indexes.
4754 (x_allocate_bitmap_record): Check for size overflow.
4755 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4756
b081724f
PE
4757 Use ptrdiff_t, not int, for overlay counts.
4758 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4759 * editfns.c (overlays_around, get_pos_property):
4760 * textprop.c (get_char_property_and_overlay):
4761 * xdisp.c (next_overlay_change, note_mouse_highlight):
4762 * xfaces.c (face_at_buffer_position):
21514da7
PE
4763 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4764 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4765 (Fnext_overlay_change, Fprevious_overlay_change)
4766 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4767 Use ptrdiff_t, not int, for sizes.
21514da7 4768 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4769
3de73e5e
PE
4770 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4771
2606c57b
PE
4772 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4773 (x_session_initialize): Do not assume string length fits in int.
4774
aaafe47a
PE
4775 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4776 This is unlikely, but can occur if DPI is outlandish.
4777
2674ddc8 4778 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4779 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4780
28154962
PE
4781 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4782 * xrdb.c (magic_file_p, search_magic_path):
4783 Omit last arg SUFFIX; it was always 0. All callers changed.
4784 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4785
7de51af5
PE
4786 * xfont.c (xfont_match): Avoid need for strlen.
4787
25ed6cc3
PE
4788 * xfns.c: Don't assume strlen fits in int.
4789 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4790
4eab31dd
PE
4791 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4792 not unsigned long, as we prefer signed integers. All callers changed.
4793 Detect integer overflow in repeat count.
4794 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4795 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4796
171e2a58
PE
4797 * termcap.c: Don't assume sizes fit in int and never overflow.
4798 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4799 (gobble_line): Check for size-calculation overflow.
4800
ad39faca 4801 * minibuf.c (Fread_buffer):
6e5bb2dc 4802 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4803 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4804 Don't assume string length fits in int.
4805
52c61c22 4806 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4807 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4808
b5b8c9e5
PE
4809 * font.c: Don't assume string length fits in int.
4810 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4811 Use ptrdiff_t, not int.
ccd6111c
PE
4812 (font_intern_prop): Don't assume string length fits in int.
4813 Don't assume integer property fits in fixnum.
4814 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4815
882f0d81 4816 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4817 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4818 Reformulate so as not to need the command string.
4819 Invoke gzip -cd rather than gunzip, as it's more portable.
4820 (lock_info_type, lock_file_1, lock_file):
4821 Don't assume pid_t and time_t fit in unsigned long.
4822 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4823 (current_lock_owner): Prefer signed type for sizes.
4824 Use memcpy, not strncpy, where memcpy is what is really wanted.
4825 Don't assume (via atoi) that time_t and pid_t fit in int.
4826 Check for time_t and/or pid_t out of range, e.g., via a network share.
4827 Don't alloca where an auto var works fine.
4828
93f4cf88
PE
4829 * fileio.c: Fix some integer overflow issues.
4830 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4831 Don't assume string length fits in int.
4832 (directory_file_name): Don't assume string length fits in long.
4833 (make_temp_name): Don't assume pid fits in int, or that its print
4834 length is less than 20.
4835
f3e92b69
PE
4836 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4837
1bfdaf10
PE
4838 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4839
35016e9a
PE
4840 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4841
3d1e65a1
PE
4842 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4843 We prefer signed integers, even for size calculations.
4844
0b963a93
PE
4845 * emacs.c: Don't assume string length fits in 'int'.
4846 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4847 (main): Don't invoke strlen when not needed.
4848
573f4b54
PE
4849 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4850 (XD_DEBUG_MESSAGE): Don't waste a byte.
4851
989f33ba
PE
4852 * callproc.c (getenv_internal_1, getenv_internal)
4853 (Fgetenv_internal):
965d34eb
PE
4854 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4855
e4d29b33
PE
4856 * lread.c (invalid_syntax): Omit length argument.
4857 All uses changed. This doesn't fix a bug, but it simplifies the
4858 code away from its former Hollerith-constant appearance, and it's
4859 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4860 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4861
eb49b136
PE
4862 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4863 This didn't break anything, but it didn't help either.
4864 It's confusing to put a bogus integer in a place where the actual
4865 value does not matter.
9f62aeb1 4866 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4867 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4868
15375a22
PE
4869 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4870 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4871 implementation.
b61cc01c
PE
4872 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4873 We prefer signed types, and the value cannot exceed the EMACS_INT
4874 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4875 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4876 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4877 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4878
53b2623d
PE
4879 * indent.c (sane_tab_width): New function.
4880 (current_column, scan_for_column, Findent_to, position_indentation)
4881 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4882 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4883
51cab52b 4884 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4885
f2ed8a70
PE
4886 * lisp.h (lint_assume): New macro.
4887 * composite.c (composition_gstring_put_cache):
4888 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4889
abe80cc6
PE
4890 * editfns.c, insdel.c:
4891 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4892
b02c740e
PE
4893 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4894
ebc96716
PE
4895 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4896
b4e50fa0 4897 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4898 Use much-faster test for byte-length change.
311d5d7c 4899 Don't assume string byte-length fits in 'int'.
a4cf38e4 4900 Check that character arg fits in 'int'.
85461888 4901 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4902
c0c1ee9f
PE
4903 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4904
a498d7f4
PE
4905 * fns.c (concat): Catch string overflow earlier.
4906 Do not rely on integer wraparound.
4907
51cab52b
PE
4908 * dispextern.h (struct it.overlay_strings_charpos)
4909 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4910 * xdisp.c (forward_to_next_line_start)
4911 (back_to_previous_visible_line_start)
4912 (reseat_at_next_visible_line_start, next_element_from_buffer):
4913 Don't arbitrarily truncate the value of 'selective' to int.
4914
76031fad
PE
4915 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4916
5eb55db9
PE
4917 * composite.c: Don't truncate sizes to 'int'.
4918 (composition_gstring_p, composition_reseat_it)
4919 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4920 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4921 not EMACS_UINT, for indexes.
5eb55db9 4922
0703a717
PE
4923 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4924
d6202519
PE
4925 * buffer.c: Include <verify.h>.
4926 (struct sortvec.priority, struct sortstr.priority):
8961a454 4927 Now EMACS_INT, not int.
c20998a7 4928 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4929 (struct sortstr.size, record_overlay_string)
4930 (struct sortstrlist.size, struct sortlist.used):
4931 Don't truncate size to int.
4932 (record_overlay_string): Check for size-calculation overflow.
d6202519 4933 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4934
d5a19415
JM
49352011-06-22 Jim Meyering <meyering@redhat.com>
4936
029529ac 4937 Don't leak an XBM-image-sized buffer
d5a19415
JM
4938 * image.c (xbm_load): Free the image buffer after using it.
4939
a9041e6c
PE
49402011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4941
4942 Port to Sun C.
4943 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4944 that Sun C diagnosed.
4945 * fns.c (secure_hash): Fix pointer signedness issue.
4946 * intervals.c (static_offset_intervals): New function.
4947 (offset_intervals): Use it.
4948
7f3f739f
LL
49492011-06-21 Leo Liu <sdl.web@gmail.com>
4950
4951 * deps.mk (fns.o):
4952 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4953 sha512.h.
4954
4955 * fns.c (secure_hash): Rename from crypto_hash_function and change
4956 the first arg to accept symbols.
5b66d427 4957 (Fsecure_hash): New primitive.
7f3f739f
LL
4958 (syms_of_fns): New symbols.
4959
76147d94
DD
49602011-06-20 Deniz Dogan <deniz@dogan.se>
4961
4962 * process.c (Fset_process_buffer): Clarify return value in
4963 docstring.
4964
7d7d0045
CY
49652011-06-18 Chong Yidong <cyd@stupidchicken.com>
4966
4967 * dispnew.c (add_window_display_history): Use BVAR.
4968
4969 * xdisp.c (debug_method_add): Use BVAR.
4970 (check_window_end, dump_glyph_matrix, dump_glyph)
4971 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4972
4973 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4974 Likewise.
4975
4976 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4977 check till after the cache is created in init_frame_faces.
4978
ff2bc410
SM
49792011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4980
4981 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4982
28177add
PE
49832011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4984
dd3482fe
PE
4985 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4986 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4987 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4988
393d71f3 4989 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4990 * fileio.c (Finsert_file_contents):
4991 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4992 Remove the old (too-loose) buffer overflow checks.
4993 They weren't needed, since make_gap checks for buffer overflow.
4994 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4995 The old code merely checked for Emacs fixnum overflow, and relied
4996 on undefined (wraparound) behavior. The new code avoids undefined
4997 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4998
2e6813b0 4999 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5000 Tune. Don't use wider integers than needed. Don't use alloca.
5001 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5002
599a9e4f
PE
5003 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5004
99561444
PE
5005 * insdel.c, lisp.h (buffer_overflow): New function.
5006 (insert_from_buffer_1, replace_range, replace_range_2):
5007 * insdel.c (make_gap_larger):
5008 * editfns.c (Finsert_char):
5009 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5010
28177add
PE
5011 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5012
e69dafad
PE
50132011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5014
4baa020d 5015 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5016
b1c46f02
PE
5017 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5018 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5019
e69dafad
PE
5020 * fileio.c: Don't assume EMACS_INT fits in off_t.
5021 (emacs_lseek): New static function.
5022 (Finsert_file_contents, Fwrite_region): Use it.
5023 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5024
566684ea
PE
5025 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5026
e6966cd6
PE
5027 * fns.c: Don't overflow int when computing a list length.
5028 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5029 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5030 truncation on 64-bit hosts. Check for QUIT every
5031 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5032 faster and is responsive enough.
5033 (Flength): Report an error instead of overflowing an integer.
5034 (Fsafe_length): Return a float if the value is not representable
5035 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5036 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5037 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5038
dd0b0efb
PE
5039 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5040 (header_size, word_size): New constants.
5041 (allocate_vectorlike): Don't check size overflow here.
5042 (allocate_vector): Check it here instead, since this is the only
5043 caller of allocate_vectorlike that could cause overflow.
5044 Check that the new vector's length is representable as a fixnum.
5045
86fe5cfe
PE
5046 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5047 The previous code was bogus. For example, next_almost_prime (32)
5048 returned 39, which is undesirable as it is a multiple of 3; and
5049 next_almost_prime (24) returned 25, which is a multiple of 5 so
5050 why was the code bothering to check for multiples of 7?
5051
80e88859
PE
5052 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5053
4a2f0ad6
PE
5054 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5055
f66c7cf8
PE
5056 Variadic C functions now count arguments with ptrdiff_t.
5057 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5058 Back then I didn't know that the Emacs coding style prefers signed int.
5059 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5060 were being counted with int, which may truncate counts on 64-bit
5061 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5062 * lisp.h (struct Lisp_Subr.function.aMANY)
5063 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5064 Arg counts are now ptrdiff_t, not size_t.
5065 All variadic functions and their callers changed accordingly.
5066 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5067 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5068 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5069 * callint.c (Fcall_interactively): Check arg count for overflow,
5070 to avoid potential buffer overrun. Use signed char, not 'int',
5071 for 'varies' array, so that we needn't bother to check its size
5072 calculation for overflow.
5073 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5074 * eval.c (apply_lambda):
5075 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5076 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5077 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5078
a1759b76
PE
5079 * callint.c (Fcall_interactively): Don't use index var as event count.
5080
d96be9fc
PE
5081 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5082 * mem-limits.h (SIZE): Remove; no longer used.
5083
a690a978 5084 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5085
578c21e6
PE
5086 Remove unnecessary casts.
5087 * xterm.c (x_term_init):
5088 * xfns.c (x_set_border_pixel):
5089 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5090 These aren't needed now that we assume ANSI C.
5091
96f53c6c
PE
5092 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5093 It's more likely to cause problems (due to unsigned overflow)
5094 than to cure them.
5095
83c77d31
PE
5096 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5097
ee2079f1
PE
5098 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5099
6da65536
PE
5100 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5101
7147c4a4
PE
5102 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5103
193e32d9
PE
5104 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5105
e5533da6
PE
5106 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5107
9910e595
PE
5108 GLYPH_CODE_FACE returns EMACS_INT, not int.
5109 * dispextern.h (merge_faces):
5110 * xfaces.c (merge_faces):
01103c44
PE
5111 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5112 Don't assume EMACS_INT fits in int.
9910e595 5113
2638320e
PE
5114 * character.h (CHAR_VALID_P): Remove unused parameter.
5115 * fontset.c, lisp.h, xdisp.c: All uses changed.
5116
045eb8d9
PE
5117 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5118
c1f134b5
PE
5119 * fns.c (concat): Minor tuning based on overflow analysis.
5120 This doesn't fix any bugs. Use int to hold character, instead
5121 of constantly refetching from Emacs object. Use XFASTINT, not
5122 XINT, for value known to be a character. Don't bother comparing
5123 a single byte to 0400, as it's always less.
5124
395fcb93 5125 * floatfns.c (Fexpt):
327eeec8
PE
5126 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5127
abbd3d23
PE
5128 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5129 for characters.
5130
684a03ef
PE
5131 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5132
0fed43f3
PE
5133 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5134 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5135 incorrectly succeed when S was a string, because 4294967386 was
5136 truncated before it was used.
5137
8fd02eb7
PE
5138 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5139 Otherwise, an out-of-range integer could cause undefined behavior
5140 on a 64-bit host.
5141
f8c86b69
PE
5142 * composite.c: Use int, not EMACS_INT, for characters.
5143 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5144 EMACS_INT, for values that are known to be in character range.
5145 This doesn't fix any bugs but is the usual style inside Emacs and
5146 may generate better code on 32-bit machines.
5147
34206dd2
PE
5148 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5149 This is for reasons similar to the recent CHAR_STRING fix.
5150 * charset.c (Fencode_char): Check that character arg is actually
5151 a character. Pass an int to ENCODE_CHAR.
5152 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5153 wider than 'int', as a compile-time check to prevent future regressions
5154 in this area.
5155
c5958d4c 5156 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5157
5158 Make sure a 64-bit char is never passed to CHAR_STRING.
5159 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5160 by silently ignoring the top 32 bits, allowing some values
5161 that were far too large to be valid characters.
5162 * character.h: Include <verify.h>.
5163 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5164 arguments are no wider than unsigned, as a compile-time check
5165 to prevent future regressions in this area.
5166 * data.c (Faset):
01103c44 5167 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5168 (Fsubst_char_in_region):
5169 * fns.c (concat):
5170 * xdisp.c (decode_mode_spec_coding):
5171 Adjust to CHAR_STRING's new requirement.
5172 * editfns.c (Finsert_char, Fsubst_char_in_region):
5173 * fns.c (concat): Check that character args are actually
5174 characters. Without this test, these functions did the wrong
5175 thing with wildly out-of-range values on 64-bit hosts.
5176
d37ca623
PE
5177 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5178 These casts should not be needed on 32-bit hosts, either.
5179 * keyboard.c (read_char):
5180 * lread.c (Fload): Remove casts to unsigned.
5181
ea204efb
PE
5182 * lisp.h (UNSIGNED_CMP): New macro.
5183 This fixes comparison bugs on 64-bit hosts.
5184 (ASCII_CHAR_P): Use it.
5185 * casefiddle.c (casify_object):
01103c44 5186 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5187 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5188 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5189 * dispextern.h (FACE_FROM_ID):
5190 * keyboard.c (read_char): Use UNSIGNED_CMP.
5191
41cb286c
PE
5192 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5193 not to EMACS_INT, to avoid GCC warning.
5194
4a1b9832
PE
5195 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5196
55daad71
PE
5197 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5198 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5199 isn't needed on 32-bit machines.
8f95c75c 5200
01103c44
PE
5201 * buffer.c (Fgenerate_new_buffer_name):
5202 Use EMACS_INT for count, not int.
0ceccced 5203 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5204
5205 * data.c (Qcompiled_function): Now static.
5206
c6f072e7
PE
5207 * window.c (window_body_lines): Now static.
5208
20ce5912
PE
5209 * image.c (gif_load): Rename local to avoid shadowing.
5210
9c4c5f81
PE
5211 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5212 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5213 * alloc.c (make_save_value): Integer argument is now of type
5214 ptrdiff_t, not int.
5215 (mark_object): Use ptrdiff_t, not int.
5216 * lisp.h (pD): New macro.
5217 * print.c (print_object): Use it.
5218
c0c5c8ae
PE
5219 * alloc.c: Use EMACS_INT, not int, to count objects.
5220 (total_conses, total_markers, total_symbols, total_vector_size)
5221 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5222 (total_free_floats, total_floats, total_free_intervals)
5223 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5224 Now EMACS_INT, not int. All uses changed.
5225 (Fgarbage_collect): Compute overall total using a double, so that
5226 integer overflow is less likely to be a problem. Check for overflow
5227 when converting back to an integer.
5a25e253
PE
5228 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5229 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5230 These were 'int' variables that could overflow on 64-bit hosts;
5231 they were never used, so remove them instead of repairing them.
211a0b2a 5232 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5233 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5234 Previously, this ceilinged at INT_MAX, but that doesn't work on
5235 64-bit machines.
e46bb31a 5236 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5237
c78baabf 5238 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5239 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5240 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5241 when a (possibly-narrower) signed value would do just as well.
5242 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5243
c9d624c6
PE
5244 * alloc.c: Catch some string size overflows that we were missing.
5245 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5246 for convenience in STRING_BYTES_MAX.
5247 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5248 The definition here is exact; the one in lisp.h was approximate.
5249 (allocate_string_data): Check for string overflow. This catches
5250 some instances we weren't catching before. Also, it catches
5251 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5252 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5253 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5254
c9d624c6
PE
5255 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5256 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5257 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5258
353032ce
PE
5259 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5260
2bccce07
PE
5261 * alloc.c (Fmake_string): Check for out-of-range init.
5262
0ac30604
SM
52632011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5264
5265 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5266
c195f2de
JD
52672011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5268
5269 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5270 xg_get_default_scrollbar_width.
5271
5272 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5273 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5274 (style_changed_cb): Call update_theme_scrollbar_width and call
5275 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5276 all frames (Bug#8505).
5277 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5278 Call gtk_window_set_resizable if HAVE_GTK3.
5279 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5280 and height if HAVE_GTK3 (Bug#8505).
5281 (scroll_bar_width_for_theme): New variable.
5282 (update_theme_scrollbar_width): New function.
5283 (xg_get_default_scrollbar_width): Move code to
5284 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5285 (xg_initialize): Call update_theme_scrollbar_width.
5286
5287 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5288
5289 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5290
e10ac9f1
MR
52912011-06-12 Martin Rudalics <rudalics@gmx.at>
5292
5293 * frame.c (make_frame): Call other_buffer_safely instead of
5294 other_buffer.
5295
5296 * window.c (temp_output_buffer_show): Call display_buffer with
5297 second argument Vtemp_buffer_show_specifiers and reset latter
5298 immediately after the call.
5299 (Vtemp_buffer_show_specifiers): New variable.
5300 (auto_window_vscroll_p, next_screen_context_lines)
5301 (Vscroll_preserve_screen_position): Remove leading asterisks from
5302 doc-strings.
5303
2d3c217e 53042011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5305
7b7f97e8 5306 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5307 * buffer.c (Qclone_number): Remove for now, as it's unused.
5308 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5309 (record_buffer): Remove unused local.
5310 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5311 (set_frame_buffer_list): Remove; unused.
5312 * frame.h (other_visible_frames): Remove decl.
5313 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5314 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5315 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5316 if HAVE_GPM.
5317 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5318 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5319 Define only if HAVE_GPM.
5320 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5321 (update_hints_inhibit): Remove; never set. All uses removed.
5322 * widgetprv.h (emacsFrameClassRec): Remove decl.
5323 * window.c (delete_deletable_window): Now returns void, since it
5324 wasn't returning anything.
5325 (compare_window_configurations): Remove unused locals.
5326 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5327 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5328 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5329 the same widths as pointers. This follows up on the 2011-05-06 patch.
5330 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5331 * xterm.h: Likewise.
5332 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5333
1384b89e
JB
53342011-06-12 Juanma Barranquero <lekktu@gmail.com>
5335
5336 * makefile.w32-in: Update dependencies.
5337 (LISP_H): Add lib/intprops.h.
5338
1100a63c
CY
53392011-06-11 Chong Yidong <cyd@stupidchicken.com>
5340
5341 * image.c (gif_load): Add animation frame delay to the metadata.
5342 (syms_of_image): Use DEFSYM. New symbol `delay'.
5343
6198ccd0
MR
53442011-06-11 Martin Rudalics <rudalics@gmx.at>
5345
5346 * window.c (delete_deletable_window): Re-add.
5347 (Fset_window_configuration): Rewrite to handle dead buffers and
5348 consequently deletable windows.
5349 (window_tree, Fwindow_tree): Remove. Supply functionality in
5350 window.el.
5351 (compare_window_configurations): Simplify code.
5352
b6e3633c
AS
53532011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5354
1ab0dee5
AS
5355 * image.c (imagemagick_load_image): Fix type mismatch.
5356 (Fimagemagick_types): Likewise.
5357
b6e3633c
AS
5358 * window.h (replace_buffer_in_windows): Declare.
5359
9397e56f
MR
53602011-06-11 Martin Rudalics <rudalics@gmx.at>
5361
5362 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5363 Qclone_number. Remove external declaration of Qdelete_window.
5364 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5365 code.
640c8776
SM
5366 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5367 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5368 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5369 buffer list implementation.
5370 (other_buffer_safely): New function.
5371 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5372 calls to replace_buffer_in_windows and
5373 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5374 if allowed.
5375 (record_buffer): Inhibit quitting and rewrite using quittable
5376 functions. Run Qbuffer_list_update_hook if allowed.
5377 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5378 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5379 Move switch-to-buffer to window.el.
9397e56f
MR
5380 (bury-buffer): Move to window.el.
5381 (Vbuffer_list_update_hook): New variable.
5382
5383 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5384 section.
5385
5386 * window.h (resize_frame_windows): Move up in code.
5387 (Fwindow_frame): Remove EXFUN.
5388 (replace_buffer_in_all_windows): Remove prototype.
5389 (replace_buffer_in_windows_safely): Add prototype.
5390
5391 * window.c: Declare Qdelete_window static again. Move down
5392 declaration of select_count.
5393 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5394 (Fother_window): Move to window.el.
5395 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5396 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5397 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5398 window.el.
5399 (replace_buffer_in_windows): Implement by calling
5400 Qreplace_buffer_in_windows.
5401 (replace_buffer_in_all_windows): Remove with some functionality
5402 moved into replace_buffer_in_windows_safely.
5403 (replace_buffer_in_windows_safely): New function.
5404 (select_window_norecord, select_frame_norecord): Move in front
5405 of run_window_configuration_change_hook. Remove now obsolete
5406 declarations.
640c8776
SM
5407 (Fset_window_buffer): Rewrite doc-string.
5408 Call Qrecord_window_buffer.
9397e56f
MR
5409 (keys_of_window): Move binding for other-window to window.el.
5410
b50691aa
CY
54112011-06-11 Chong Yidong <cyd@stupidchicken.com>
5412
5413 * dispextern.h (struct image): Replace data member, whose int_val
5414 and ptr_val fields were not used by anything, with a single
5415 lisp_val object.
5416
5417 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5418 (gif_clear_image, gif_load, imagemagick_load_image)
5419 (gs_clear_image, gs_load): Callers changed.
5420
3f754b86
PE
54212011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5422
cca69397
PE
5423 * buffer.h: Include <time.h>, for time_t.
5424 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5425
109e28d0
PE
5426 Fix minor problems found by static checking.
5427
60737f02
PE
5428 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5429
4b66faf3
PE
5430 Make identifiers static if they are not used in other modules.
5431 * data.c (Qcompiled_function, Qframe, Qvector):
5432 * image.c (QimageMagick, Qsvg):
5433 * minibuf.c (Qmetadata):
5434 * window.c (resize_window_check, resize_root_window): Now static.
5435 * window.h (resize_window_check, resize_root_window): Remove decls.
5436
109e28d0
PE
5437 * window.c (window_deletion_count, delete_deletable_window):
5438 Remove; unused.
46a4ce9e
PE
5439 (window_body_lines): Now static.
5440 (Fdelete_other_windows_internal): Mark vars as initialized.
5441 Make sure 'resize_failed' is initialized.
5442 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5443 (resize_window_apply): Remove unused local.
5444 * window.h (delete_deletable_window): Remove decl.
5445
109e28d0 5446 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5447 (imagemagick_load_image): Fix pointer signedness problem by changing
5448 last arg from unsigned char * to char *. All uses changed.
5449 Also, fix a local for similar reasons.
5450 Remove unused locals. Remove locals to avoid shadowing.
5451 (fn_rsvg_handle_free): Remove; unused.
5452 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5453 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5454
3f754b86
PE
5455 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5456
2547adb1
CY
54572011-06-10 Chong Yidong <cyd@stupidchicken.com>
5458
5459 * image.c (gif_load): Fix omitted cast error introduced by
5460 2011-06-06 change.
5461
2c8e37d4
MR
54622011-06-10 Martin Rudalics <rudalics@gmx.at>
5463
5464 * window.h (resize_proportionally, orig_total_lines)
5465 (orig_top_line): Remove from window structure.
5466 (set_window_height, set_window_width, change_window_heights)
5467 (Fdelete_window): Remove prototypes.
5468 (resize_frame_windows): Remove duplicate declaration.
5469
440a42e3
EZ
54702011-06-10 Eli Zaretskii <eliz@gnu.org>
5471
5472 * window.h (resize_frame_windows, resize_window_check)
5473 (delete_deletable_window, resize_root_window)
5474 (resize_frame_windows): Declare prototypes.
5475
5476 * window.c (resize_window_apply): Make definition be "static" to
5477 match the prototype.
5478
562dd5e9
MR
54792011-06-10 Martin Rudalics <rudalics@gmx.at>
5480
5481 * window.c: Remove declarations of Qwindow_size_fixed,
5482 window_min_size_1, window_min_size_2, window_min_size,
5483 size_window, window_fixed_size_p, enlarge_window, delete_window.
5484 Remove static from declaration of Qdelete_window, it's
5485 temporarily needed by Fbury_buffer.
5486 (replace_window): Don't assign orig_top_line and
5487 orig_total_lines.
5488 (Fdelete_window, delete_window): Remove. Window deletion is
5489 handled by window.el.
640c8776
SM
5490 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5491 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5492 (Fdelete_other_windows): Remove. Deleting other windows is
5493 handled by window.el.
5494 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5495 handled in window.el.
5496 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5497 Window minimum sizes are handled in window.el.
5498 (shrink_windows, size_window, set_window_height)
5499 (set_window_width, change_window_heights, window_height)
5500 (window_width, CURBEG, CURSIZE, enlarge_window)
5501 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5502 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5503 handled in window.el.
5504 (make_dummy_parent): Rename to make_parent_window and give it a
5505 second argument horflag.
5506 (make_window): Don't set resize_proportionally any more.
5507 (Fsplit_window): Remove. Windows are split in window.el.
5508 (save_restore_action, save_restore_orig_size)
5509 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5510 Resize mini windows in window.el.
5511 (grow_mini_window, shrink_mini_window): Implement by calling
5512 Qresize_root_window_vertically, resize_window_check and
5513 resize_window_apply.
640c8776
SM
5514 (saved_window, Fset_window_configuration, save_window_save):
5515 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5516 resize_proportionally.
5517 (window_min_height, window_min_width): Move to window.el.
5518 (keys_of_window): Move bindings for delete-other-windows,
5519 split-window, delete-window and enlarge-window to window.el.
5520
5521 * buffer.c: Temporarily extern Qdelete_window.
5522 (Fbury_buffer): Temporarily call Qdelete_window instead of
5523 Fdelete_window (Fbury_buffer will move to window.el soon).
5524
5525 * frame.c (set_menu_bar_lines_1): Remove code handling
5526 orig_top_line and orig_total_lines.
5527
5528 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5529 set_window_height but set heights directly.
5530 (change_frame_size_1): Use resize_frame_windows.
5531
5532 * xdisp.c (init_xdisp): Don't use set_window_height but set
5533 heights directly.
5534
640c8776
SM
5535 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5536 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5537 run_window_configuration_change_hook.
5538
5539 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5540 instead of change_window_heights and run
5541 run_window_configuration_change_hook.
5542
1a13852e
MR
55432011-06-09 Martin Rudalics <rudalics@gmx.at>
5544
5545 * window.c (replace_window): Rename second argument REPLACEMENT to
5546 NEW. New third argument SETFLAG. Rewrite.
5547 (delete_window, make_dummy_parent): Call replace_window with
5548 third argument 1.
5549 (window_list_1): Move down in code.
5550 (run_window_configuration_change_hook): Move set_buffer part
5551 before select_frame_norecord part in order to unwind correctly.
5552 Rename count1 to count.
5553 (recombine_windows, delete_deletable_window, resize_root_window)
5554 (Fdelete_other_windows_internal)
5555 (Frun_window_configuration_change_hook, make_parent_window)
5556 (resize_window_check, resize_window_apply, Fresize_window_apply)
5557 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5558 (Fdelete_window_internal, Fresize_mini_window_internal):
5559 New functions.
1a13852e
MR
5560 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5561
f3d1777e
MR
55622011-06-08 Martin Rudalics <rudalics@gmx.at>
5563
496e208e
MR
5564 * window.h (window): Add some new members to window structure -
5565 normal_lines, normal_cols, new_total, new_normal, clone_number,
5566 splits, nest, prev_buffers, next_buffers.
5567 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5568 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5569
f3d1777e
MR
5570 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5571 Remove.
496e208e
MR
5572 (make_dummy_parent): Set new members of windows structure.
5573 (make_window): Move down in code. Handle new members of window
5574 structure.
5575 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5576 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5577 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5578 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5579 (Fset_window_next_buffers, Fset_window_clone_number):
5580 New functions.
496e208e
MR
5581 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5582 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5583 Doc-string fixes.
5584 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5585 Argument WINDOW can be now internal window too.
5586 (Fwindow_use_time): Move up in code.
5587 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5588 Rewrite doc-string.
5589 (Fset_window_configuration, saved_window)
5590 (Fcurrent_window_configuration, save_window_save): Handle new
5591 members of window structure.
b9e809c2
MR
5592 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5593 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5594 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5595 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5596 Qget_mru_window, Qresize_root_window,
5597 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5598 Qauto_buffer_name; staticpro them.
f3d1777e 5599
abde8f8c
MR
56002011-06-07 Martin Rudalics <rudalics@gmx.at>
5601
5602 * window.c (Fwindow_total_size, Fwindow_left_column)
5603 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5604 (Fwindow_list_1): New functions.
5605 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5606 (Fwindow_width, Fscroll_left, Fscroll_right):
5607 Use window_body_cols instead of window_box_text_cols.
5608 (delete_window, Fset_window_configuration):
5609 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5610 (delete_all_subwindows): Take a window as argument and not a
5611 structure. Rewrite.
190b47e6
MR
5612 (window_loop): Remove handling of GET_LRU_WINDOW and
5613 GET_LARGEST_WINDOW.
5614 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5615
5616 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5617 window_box_text_cols. delete_all_subwindows now takes a
5618 Lisp_Object as argument.
abde8f8c 5619
640c8776
SM
5620 * indent.c (compute_motion, Fcompute_motion):
5621 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5622
fa8a67e6
MR
5623 * frame.c (delete_frame): Call delete_all_subwindows with root
5624 window as argument.
5625
a54e3482
DC
56262011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5627
5628 * fns.c (Fputhash): Document return value.
5629
60002bf5
CY
56302011-06-06 Chong Yidong <cyd@stupidchicken.com>
5631
5632 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5633
0c671da6 56342011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5635
b862a52a 5636 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5637
be44ca6c
PE
5638 Check for overflow when converting integer to cons and back.
5639 * charset.c (Fdefine_charset_internal, Fdecode_char):
5640 Use cons_to_unsigned to catch overflow.
5641 (Fencode_char): Use INTEGER_TO_CONS.
5642 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5643 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5644 * data.c (long_to_cons, cons_to_long): Remove.
5645 (cons_to_unsigned, cons_to_signed): New functions.
5646 These signal an error for invalid or out-of-range values.
5647 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5648 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5649 * font.c (Ffont_variation_glyphs):
5650 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5651 * lisp.h: Include <intprops.h>.
5652 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5653 (cons_to_signed, cons_to_unsigned): New decls.
5654 (long_to_cons, cons_to_long): Remove decls.
5655 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5656 (Fprimitive_undo): Use CONS_TO_INTEGER.
5657 * xfns.c (Fx_window_property): Likewise.
5658 * xselect.c: Include <limits.h>.
5659 (x_own_selection, selection_data_to_lisp_data):
5660 Use INTEGER_TO_CONS.
5661 (x_handle_selection_request, x_handle_selection_clear)
5662 (x_get_foreign_selection, Fx_disown_selection_internal)
5663 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5664 (lisp_data_to_selection_data): Use cons_to_unsigned.
5665 (x_fill_property_data): Use cons_to_signed.
5666 Report values out of range.
5667
d1f3d2af
PE
5668 Check for buffer and string overflow more precisely.
5669 * buffer.h (BUF_BYTES_MAX): New macro.
5670 * lisp.h (STRING_BYTES_MAX): New macro.
5671 * alloc.c (Fmake_string):
5672 * character.c (string_escape_byte8):
5673 * coding.c (coding_alloc_by_realloc):
5674 * doprnt.c (doprnt):
5675 * editfns.c (Fformat):
5676 * eval.c (verror):
5677 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5678 since they may not be the same number.
5679 * editfns.c (Finsert_char):
5680 * fileio.c (Finsert_file_contents):
5681 Likewise for BUF_BYTES_MAX.
5682
dd52fcea
PE
5683 * image.c: Use ptrdiff_t, not int, for sizes.
5684 (slurp_file): Switch from int to ptrdiff_t.
5685 All uses changed.
5686 (slurp_file): Check that file size fits in both size_t (for
5687 malloc) and ptrdiff_t (for sanity and safety).
5688
7f9bbdbb
PE
5689 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5690 if b->modtime has its maximal value.
5691
dfe18f82
PE
5692 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5693
84acfcf0
PE
5694 Don't assume time_t can fit into int.
5695 * buffer.h (struct buffer.modtime): Now time_t, not int.
5696 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5697 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5698
ccd9a01a
PE
5699 Minor fixes for signed vs unsigned integers.
5700 * character.h (MAYBE_UNIFY_CHAR):
5701 * charset.c (maybe_unify_char):
5702 * keyboard.c (read_char, reorder_modifiers):
5703 XINT -> XFASTINT, since the integer must be nonnegative.
5704 * ftfont.c (ftfont_spec_pattern):
5705 * keymap.c (access_keymap, silly_event_symbol_error):
5706 XUINT -> XFASTINT, since the integer must be nonnegative.
5707 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5708 since it makes no difference and we prefer signed.
5709 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5710 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5711 nonnegative.
5712
d6d100dd
SM
57132011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5714
5715 * window.h (Fwindow_frame): Declare.
5716
2b6148e4
PE
57172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5718
5719 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5720 (SPARE_MEMORY): Always define.
5721 (LARGE_REQUEST): Remove.
5722 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5723
f230ecc9
MR
57242011-06-06 Martin Rudalics <rudalics@gmx.at>
5725
727e958e
MR
5726 * lisp.h: Move EXFUNS for Fframe_root_window,
5727 Fframe_first_window and Fset_frame_selected_window to window.h.
5728
5729 * window.h: Move EXFUNS for Fframe_root_window,
5730 Fframe_first_window and Fset_frame_selected_window here from
5731 lisp.h.
5732
5733 * frame.c (Fwindow_frame, Fframe_first_window)
5734 (Fframe_root_window, Fframe_selected_window)
5735 (Fset_frame_selected_window): Move to window.c.
5736 (Factive_minibuffer_window): Move to minibuf.c.
5737 (Fother_visible_frames_p): New function.
5738
5739 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5740
f230ecc9
MR
5741 * window.c (decode_window, decode_any_window): Move up in code.
5742 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5743 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5744 (Fwindow_buffer): Move up and rewrite doc-string.
5745 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5746 (Fwindow_prev): New functions.
727e958e
MR
5747 (Fwindow_frame): Move here from frame.c. Accept any window as
5748 argument.
5749 (Fframe_root_window, Fframe_first_window)
5750 (Fframe_selected_window): Move here from frame.c. Accept frame
5751 or arbitrary window as argument. Update doc-strings.
5752 (Fminibuffer_window): Move up in code.
5753 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5754 (Fset_frame_selected_window): Move here from frame.c.
5755 Marginal rewrite.
727e958e
MR
5756 (Fselected_window, select_window, Fselect_window): Move up in
5757 code. Minor doc-string fixes.
f230ecc9 5758
4d09bcf6
PE
57592011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5760
5761 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5762 Do not assume that spare memory exists; that assumption is valid
5763 only if SYSTEM_MALLOC.
5764 (LARGE_REQUEST): New macro, so that the issue of large requests
5765 is separated from the issue of spare memory.
5766
810928a2
AS
57672011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5768
172418ad
AS
5769 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5770 format. (Bug#8806)
5771
43f862f7
AS
5772 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5773
810928a2
AS
5774 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5775 before statements.
5776
a059fe24
JD
57772011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5778
5779 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5780
5781 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5782
5783 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5784 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5785
989bf368
JB
57862011-06-05 Juanma Barranquero <lekktu@gmail.com>
5787
5788 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5789
4b80f674
CY
57902011-06-04 Chong Yidong <cyd@stupidchicken.com>
5791
5792 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5793 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5794 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5795 New error handlers.
4b80f674
CY
5796 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5797 Obey Vx_select_enable_clipboard_manager. Catch errors in
5798 x_clipboard_manager_save (Bug#8779).
5799 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5800 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5801
99a33b77 58022011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5803
5804 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5805
99a33b77 58062011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5807
5808 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5809 in the current matrix if keep_current_p is non-zero.
5810
8264569d
EZ
58112011-06-04 Eli Zaretskii <eliz@gnu.org>
5812
5813 * bidi.c (bidi_level_of_next_char): Fix last change.
5814
57f97249
EZ
58152011-06-03 Eli Zaretskii <eliz@gnu.org>
5816
fec2107c 5817 Support bidi reordering of text covered by display properties.
57f97249 5818
fec2107c
EZ
5819 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5820 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5821 (bidi_cache_search, bidi_cache_iterator_state)
5822 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5823 (bidi_level_of_next_char, bidi_move_to_visually_next):
5824 Support character positions inside a run of characters covered by a
fec2107c
EZ
5825 display string.
5826 (bidi_paragraph_init, bidi_resolve_explicit_1)
5827 (bidi_level_of_next_char): Call bidi_fetch_char and
5828 bidi_fetch_char_advance instead of FETCH_CHAR and
5829 FETCH_CHAR_ADVANCE.
5830 (bidi_init_it): Initialize new members.
5831 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5832 definitions.
5833 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5834 instead of using explicit *_CHAR codes.
d6d100dd
SM
5835 (bidi_resolve_explicit, bidi_resolve_weak):
5836 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5837 bidirectional text is supported only in multibyte buffers.
5838 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5839 it to initialize the frame_window_p member of struct bidi_it.
5840 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5841 (bidi_resolve_explicit, bidi_resolve_weak)
5842 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5843 bidi_it->nchars is non-positive.
5844 (bidi_level_of_next_char): Don't try to lookup the cache for the
5845 next/previous character if nothing is cached there yet, or if we
5846 were just reseat()'ed to a new position.
c40e2fb2 5847
0e14fe90
EZ
5848 * xdisp.c (set_cursor_from_row): Set start and stop points
5849 according to the row's direction when priming the loop that looks
5850 for the glyph on which to display cursor.
5851 (single_display_spec_intangible_p): Function deleted.
5852 (display_prop_intangible_p): Reimplement to call
5853 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5854 Accept 3 additional arguments needed by handle_display_spec.
5855 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5856 values: lists, `(when COND...)' forms, etc.
5857 (single_display_spec_string_p): Support property values that are
5858 lists with the argument STRING its top-level element.
5859 (display_prop_string_p): Fix the condition for processing a
5860 property that is a list to be consistent with handle_display_spec.
fec2107c 5861 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5862 last portion of handle_display_prop.
5863 (compute_display_string_pos): Accept additional argument
5864 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5865 value of a `display' property is a "replacing spec".
5866 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5867 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5868 the display property, but just return a value indicating whether
5869 the display property will replace the characters it covers.
5870 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5871 frame_window_p members of struct bidi_it.
d6d100dd
SM
5872 (compute_display_string_pos, compute_display_string_end):
5873 New functions.
fec2107c
EZ
5874 (push_it): Accept second argument POSITION, where pop_it should
5875 jump to continue iteration.
5876 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5877
fec2107c
EZ
5878 * keyboard.c (adjust_point_for_property): Adjust the call to
5879 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5880
5881 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5882 (bidi_init_it): Update prototypes.
5883 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5884 (compute_display_string_pos, compute_display_string_end):
5885 Declare prototypes.
fec2107c
EZ
5886 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5887 EMACS_INT.
fc6f18ce 5888
40087514 58892011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5890
57f53182
PE
5891 Malloc failure behavior now depends on size of allocation.
5892 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5893 * lisp.h: Change signatures accordingly.
5894 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5895 All callers changed. (Bug#8762)
5896
5897 * gnutls.c: Use Emacs's memory allocators.
5898 Without this change, the gnutls library would invoke malloc etc.
5899 directly, which causes problems on non-SYNC_INPUT hosts, and which
5900 runs afoul of improving memory_full behavior. (Bug#8761)
5901 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5902 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5903 xfree instead of the default malloc, realloc, free.
5904 (Fgnutls_boot): No need to check for memory allocation failure,
5905 since xmalloc does that for us.
5906
ac32cd99 5907 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5908 * category.c (hash_get_category_set):
5909 * ccl.c (ccl_driver):
5910 * charset.c (Fdefine_charset_internal):
5911 * charset.h (struct charset.hash_index):
5912 * composite.c (get_composition_id, gstring_lookup_cache)
5913 (composition_gstring_put_cache):
5914 * composite.h (struct composition.hash_index):
5915 * dispextern.h (struct image.hash):
5916 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5917 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5918 (hashfn_equal, hashfn_user_defined, make_hash_table)
5919 (maybe_resize_hash_table, hash_lookup, hash_put)
5920 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5921 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5922 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5923 * image.c (make_image, search_image_cache, lookup_image)
5924 (xpm_put_color_table_h):
5925 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5926 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5927 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5928 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5929 * alloc.c (allocate_vectorlike):
5930 Check for overflow in vector size calculations.
5931 * ccl.c (ccl_driver):
5932 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5933 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5934 need to be updated by these changes.
40087514
PE
5935 * fns.c (make_hash_table, maybe_resize_hash_table):
5936 Check for integer overflow with large hash tables.
0de4bb68
PE
5937 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5938 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5939 (SXHASH_REDUCE): New macro.
5940 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5941 Use it instead of discarding useful hash info with large hash values.
5942 (sxhash_float): New function.
5943 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5944 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5945 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5946 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5947 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5948 Adjust signatures to match updated version of code.
5949 (consing_since_gc): Now EMACS_INT, since a single hash table can
5950 use more than INT_MAX bytes.
5951
698d32e2
DN
59522011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5953
5954 Make it possible to build with GCC-4.6+ -O2 -flto.
5955
5956 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5957
fd6fa53f
SM
59582011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5959
5960 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5961 Call minibuffer-inactive-mode.
5962
864db017
JB
59632011-05-31 Juanma Barranquero <lekktu@gmail.com>
5964
5965 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5966 Update dependencies.
5967
2ad0baf4
DN
59682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5969
5970 * data.c (init_data): Remove code for UTS, this system is not
5971 supported anymore.
5972
4fcc2638
DN
59732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5974
5975 Don't force ./temacs to start in terminal mode.
5976
5977 * frame.c (make_initial_frame): Initialize faces in all cases, not
5978 only when CANNOT_DUMP is defined.
5979 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5980
c56e0fd5
DN
59812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5982
5983 * dispnew.c (add_window_display_history): Use const for the string
5984 pointer. Remove declaration, not needed.
5985
333d54da 59862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5987
55d4c1b2 5988 Use 'inline', not 'INLINE'.
333d54da 5989 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5990 * alloc.c, fontset.c (INLINE): Remove.
5991 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5992 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5993 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5994 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5995 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5996
738db178
DN
59972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5998
5999 Make it possible to run ./temacs.
6000
6001 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6002 syms_of_callproc does the same thing. Remove test for
6003 "initialized", do it in the caller.
6004 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6005
620c53a6
SM
60062011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6007
6008 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6009 (read_minibuf): Use get_minibuffer.
6010 (syms_of_minibuf): Use DEFSYM.
6011 (Qmetadata): New var.
6012 * data.c (Qbuffer): Don't make it static.
6013 (syms_of_data): Use DEFSYM.
6014
e003a292
PE
60152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6016
6017 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6018 (CCL_CODE_MIN): New macro.
6019
ed008a6d
PE
60202011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6021
3687c2ef
PE
6022 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6023
ed008a6d
PE
6024 * eval.c (Qdebug): Now static.
6025 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6026 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6027 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6028
d66c4c7c
CY
60292011-05-29 Chong Yidong <cyd@stupidchicken.com>
6030
6031 * image.c: Various fixes to ImageMagick code comments.
6032 (Fimagemagick_types): Doc fix.
6033
5fbc2025
PE
60342011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6035
0196f88a
PE
6036 Minor fixes prompted by GCC 4.6.0 warnings.
6037
6038 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6039
5fbc2025
PE
6040 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6041 (x_clipboard_manager_save_all): Move extern decl to ...
6042 * xterm.h: ... here, so that it can be checked for consistency.
6043
1dd3c2d9
CY
60442011-05-29 Chong Yidong <cyd@stupidchicken.com>
6045
6046 * xselect.c (x_clipboard_manager_save_frame)
6047 (x_clipboard_manager_save_all): New functions.
6048 (Fx_clipboard_manager_save): Lisp function deleted.
6049
6050 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6051 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6052
6053 * xterm.h: Update prototype.
6054
5ba6571d
WX
60552011-05-28 William Xu <william.xwl@gmail.com>
6056
6057 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6058 exiting (Bug#8239).
6059
3eaff834
JM
60602011-05-28 Jim Meyering <meyering@redhat.com>
6061
e1900994 6062 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6063 * fns.c (to_uchar): Define.
6064 (crypto_hash_function): Use it to convert some newly-signed
6065 variables to unsigned, to avoid sign-extension bugs. For example,
6066 without this change, (md5 "truc") would evaluate to
6067 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6068 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6069 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6070
0f6990a7
PE
60712011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6072
6073 Integer overflow fixes.
c8a9ca5a 6074
08686060
PE
6075 * dbusbind.c: Serial number integer overflow fixes.
6076 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6077 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6078 to hold a serial number that is too large for a fixnum.
6079 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6080 Check for serial numbers out of range. Decode any serial number
59568bf0 6081 that was so large that it became a float. (Bug#8722)
08686060 6082
2d1fc3c7
PE
6083 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6084 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6085 Use XFASTINT rather than XUINT when numbers are nonnegative.
6086 (xd_append_arg, Fdbus_method_return_internal):
6087 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6088 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6089 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6090 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6091 (Bug#8722)
2d1fc3c7 6092
c8a9ca5a
PE
6093 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6094
519e1d69
PE
6095 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6096
6df6ae42 6097 ccl: Add integer overflow checks.
30569699
PE
6098 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6099 (IN_INT_RANGE): New macros.
6100 (ccl_driver): Use them to check for integer overflow when
6101 decoding a CCL program. Many of the new checks are whether XINT (x)
6102 fits in int; it doesn't always, on 64-bit hosts. The new version
6103 doesn't catch all possible integer overflows, but it's an
847044ea 6104 improvement. (Bug#8719)
30569699 6105
c11285dc
PE
6106 * alloc.c (make_event_array): Use XINT, not XUINT.
6107 There's no need for unsigned here.
6108
fdccd48e
PE
6109 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6110 This follows up to the 2011-05-06 change that substituted uintptr_t
6111 for EMACS_INT. This case wasn't caught back then.
6112
37910ab2
PE
6113 Rework Fformat to avoid integer overflow issues.
6114 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6115 now (part of C89). Include <verify.h>.
6116 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6117 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6118 (Fformat): Avoid the prepass trying to compute sizes; it was only
6119 approximate and thus did not catch overflow reliably. Instead, walk
6120 through the format just once, formatting and computing sizes as we go,
6121 checking for integer overflow at every step, and allocating a larger
6122 buffer as needed. Keep track separately whether the format is
6123 multibyte. Keep only the most-recently calculated precision, rather
6124 than them all. Record whether each argument has been converted to
6125 string. Use EMACS_INT, not int, for byte and char and arg counts.
6126 Support field widths and precisions larger than INT_MAX. Avoid
6127 sprintf's undefined behavior with conversion specifications such as %#d
6128 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6129 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6130 formatting out-of-range floating point numbers with int
9173deec 6131 formats. (Bug#8668)
37910ab2 6132
2e6578fb
PE
6133 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6134
0ae6bdee
PE
6135 * data.c: Avoid integer truncation in expressions involving floats.
6136 * data.c: Include <intprops.h>.
6137 (arith_driver): When there's an integer overflow in an expression
6138 involving floating point, convert the integers to floating point
6139 so that the resulting value does not suffer from catastrophic
6140 integer truncation. For example, on a 64-bit host (* 4
6141 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6142 Do not rely on undefined behavior after integer overflow.
6143
de883a70
PE
6144 merge count_size_as_multibyte, parse_str_to_multibyte
6145 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6146 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6147 Check for integer overflow.
6148 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6149 since it's now a duplicate of the other. This is more of
6150 a character than a buffer op, so better that it's in character.c.
6151 * fns.c, print.c: Adjust to above changes.
6152
2ff916cb
PE
61532011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6154
6155 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6156
f1b54466
PE
61572011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6158
fb1ac845
PE
6159 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6160 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6161 (x_clipboard_manager_save): Now static.
6162 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6163
f1b54466
PE
6164 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6165 (crypto_hash_function): Now static.
6166 Fix pointer signedness problems. Avoid unnecessary initializations.
6167
a9f737ee
CY
61682011-05-27 Chong Yidong <cyd@stupidchicken.com>
6169
6170 * termhooks.h (Vselection_alist): Make it terminal-local.
6171
6172 * terminal.c (create_terminal): Initialize it.
6173
6174 * xselect.c: Support for clipboard managers.
6175 (Vselection_alist): Move to termhooks.h as terminal-local var.
6176 (LOCAL_SELECTION): New macro.
6177 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6178 (symbol_to_x_atom): Remove gratuitous arg.
6179 (x_handle_selection_request, lisp_data_to_selection_data)
6180 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6181 (x_own_selection, x_get_local_selection, x_convert_selection):
6182 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6183 (some_frame_on_display): Delete unused function.
6184 (Fx_own_selection_internal, Fx_get_selection_internal)
6185 (Fx_disown_selection_internal, Fx_selection_owner_p)
6186 (Fx_selection_exists_p): New optional frame arg.
6187 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6188 (x_handle_selection_clear): Don't treat other terminals with the
6189 same keyboard specially. Use the terminal-local Vselection_alist.
6190 (x_clear_frame_selections): Use Frun_hook_with_args.
6191
6192 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6193
6194 * xterm.h: Add support for those atoms.
6195
e067f0c1
CY
61962011-05-26 Chong Yidong <cyd@stupidchicken.com>
6197
6198 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6199 (converted_selections, conversion_fail_tag): New global variables.
6200 (x_selection_request_lisp_error): Free the above.
6201 (x_get_local_selection): Remove unnecessary code.
6202 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6203 of converted selections stored in converted_selections.
6204 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6205 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6206 (x_convert_selection): New function.
6207 (x_handle_selection_event): Simplify.
6208 (x_get_foreign_selection): Don't ignore incoming requests while
6209 waiting for an answer; this will fail when we implement
6210 SAVE_TARGETS, and seems unnecessary anyway.
6211 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6212 (Vx_sent_selection_functions): Doc fix.
6213
0f4aebc0
LL
62142011-05-26 Leo Liu <sdl.web@gmail.com>
6215
6216 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6217
e61124cd
YM
62182011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6219
6220 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6221
6222 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6223 for fringe update if it has periodic bitmap.
ac389d0c 6224 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6225 and fringe_bitmap_periodic_p.
6226
6227 * fringe.c (get_fringe_bitmap_data): New function.
6228 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6229 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6230 row. Mark glyph row for fringe update if periodicity changed.
6231
6232 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6233 for fringe update unless it has periodic bitmap.
6234
f16d9837
KH
62352011-05-25 Kenichi Handa <handa@m17n.org>
6236
6237 * xdisp.c (get_next_display_element): Set correct it->face_id for
6238 a static composition.
6239
e1b90ef6
LL
62402011-05-24 Leo Liu <sdl.web@gmail.com>
6241
6242 * deps.mk (fns.o):
6243 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6244
6245 * fns.c (crypto_hash_function, Fsha1): New function.
6246 (Fmd5): Use crypto_hash_function.
6247 (syms_of_fns): Add Ssha1.
6248
7400048f
PE
62492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6250
6251 * gnutls.c: Remove unused macros.
6252 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6253 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6254 Remove macros that are defined and never used.
6255 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6256
abb71cf4
CY
62572011-05-22 Chong Yidong <cyd@stupidchicken.com>
6258
6259 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6260 (Fx_get_selection_internal): Minor cleanup.
6261 (Fx_own_selection_internal): Rename arguments for consistency with
6262 select.el.
6263
6307db39
PE
62642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6265
6266 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6267
f3d4e0a4
CY
62682011-05-22 Chong Yidong <cyd@stupidchicken.com>
6269
6270 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6271
4d8ade89
YM
62722011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6273
6274 * dispnew.c (scrolling_window): Don't exclude the case that the
6275 last enabled row in the desired matrix touches the bottom boundary.
6276
32078c8d
GM
62772011-05-21 Glenn Morris <rgm@gnu.org>
6278
6279 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6280 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6281 and add some more files.
32078c8d 6282
7285dc67
EZ
62832011-05-20 Eli Zaretskii <eliz@gnu.org>
6284
6285 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6286 report_file_error introduced by the change from 2011-05-07.
6287
89d1bd22
PE
62882011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6289
6290 * systime.h (Time): Define only if emacs is defined.
6291 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6292 where the include path doesn't have X11/X.h by default. See
6293 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6294
cd394be1 62952011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6296
6297 * composite.c (find_automatic_composition): Fix previous change.
6298
b9704ad9
GM
62992011-05-20 Glenn Morris <rgm@gnu.org>
6300
6301 * lisp.mk: New file, split from Makefile.in.
6302 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6303 (shortlisp): Remove.
6304 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6305
4a720484
GM
63062011-05-19 Glenn Morris <rgm@gnu.org>
6307
6308 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6309 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6310 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6311 (lisp): Set the order to that of loadup.el.
6312 (shortlisp): Make it a copy of $lisp.
6313 (SOME_MACHINE_LISP): Remove.
6314 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6315 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6316
a28d4396
KH
63172011-05-18 Kenichi Handa <handa@m17n.org>
6318
6319 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6320 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6321 (find_automatic_composition): Mostly rewrite for efficiency.
6322
a2b1fa8e
JB
63232011-05-18 Juanma Barranquero <lekktu@gmail.com>
6324
6325 * makefile.w32-in: Update dependencies.
6326
8e1f5610
CS
63272011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6328
6329 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6330 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6331
7025ee00 63322011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6333
cdfa6eab
PE
6334 Fix some integer overflow issues, such as string length overflow.
6335
06d6db33
PE
6336 * insdel.c (count_size_as_multibyte): Check for string overflow.
6337
2b4560a8
PE
6338 * character.c (lisp_string_width): Check for string overflow.
6339 Use EMACS_INT, not int, for string indexes and lengths; in
6340 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6341 the resulting string length overflows an EMACS_INT; instead,
6342 report a string overflow if no precision given. When checking for
6343 precision exhaustion, use a check that cannot possibly have
6344 integer overflow. (Bug#8675)
6345 * character.h (lisp_string_width): Adjust to new signature.
6346
cb93f9be
PE
6347 * alloc.c (string_overflow): New function.
6348 (Fmake_string): Use it. This doesn't change behavior, but saves
6349 a few bytes and will simplify future changes.
6350 * character.c (string_escape_byte8): Likewise.
6351 * lisp.h (string_overflow): New decl.
6352
1a1f3366
PE
6353 Fixups, following up to the user-interface timestamp change.
6354 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6355 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6356 * msdos.c (mouse_get_pos): Likewise.
6357 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6358 * w32gui.h (Time): Define by including "systime.h" rather than by
6359 declaring it ourselves. (Bug#8664)
6360
d4e3e4d3
PE
6361 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6362 * image.c (clear_image_cache): Likewise.
6363
f6a24d19
PE
6364 * term.c (term_mouse_position): Don't assume time_t wraparound.
6365
08dc5ae6
PE
6366 Be more systematic about user-interface timestamps.
6367 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6368 and sometimes 'EMACS_UINT', to represent these timestamps.
6369 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6370 This makes the code easier to follow, and makes it easier to catch
6371 integer overflow bugs such as Bug#8664.
6372 * frame.c (Fmouse_position, Fmouse_pixel_position):
6373 Use Time, not unsigned long, for user-interface timestamps.
6374 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6375 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6376 * keyboard.h (last_event_timestamp): Likewise.
6377 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6378 * menu.h (xmenu_show): Likewise.
6379 * term.c (term_mouse_position): Likewise.
6380 * termhooks.h (struct input_event.timestamp): Likewise.
6381 (struct terminal.mouse_position_hook): Likewise.
6382 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6383 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6384 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6385 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6386 what it was before.
6387 * menu.h, termhooks.h: Include "systime.h", for Time.
6388
8e55734a
PE
6389 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6390 Don't assume that the difference between two unsigned long values
6391 can fit into an integer. At this point, we know button_down_time
6392 <= event->timestamp, so the difference must be nonnegative, so
6393 there's no need to cast the result if double-click-time is
6394 nonnegative, as it should be; check that it's nonnegative, just in
6395 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6396 apart (about 25 days). (Bug#8664)
8e55734a 6397
841f1b75 6398 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6399 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6400
3e26f69c
PE
6401 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6402 that always fit in int. Use a sentinel instead of a counter, to
6403 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6404 * frame.h (struct frame): Use int for menu_bar_items_used
6405 instead of EMACS_INT, since it always fits in int.
3e26f69c 6406
5cc152c0
PE
6407 * menu.c (grow_menu_items): Check for int overflow.
6408
d89eb65e
PE
6409 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6410
5235bd3e
PE
6411 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6412 Before, the code was not consistent. These values cannot exceed
6413 2**31 - 1 so there's no need to make them unsigned.
6414 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6415 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6416 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6417 as modifiers.
6418 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6419
bc827e23
PE
6420 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6421 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6422 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6423 presumably because the widths might not match.
6424
78eb494e
PE
6425 * window.c (size_window): Avoid needless test at loop start.
6426
04f2d78b
CB
64272011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6428
6429 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6430
d2fc7e3d 64312011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6432
6433 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6434
d2fc7e3d 64352011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6436
6437 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6438 `width' to `bar_area_x' and `bar_area_width', respectively.
6439 (x_scroll_run): Take account of fringe background extension.
6440
04f2d78b
CB
6441 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6442 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6443 `bar_area_width', respectively.
6444 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6445 background extension.
6446
79b70037
GM
64472011-05-10 Jim Meyering <meyering@redhat.com>
6448
6449 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6450
2f142cc5
JB
64512011-05-10 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * image.c (Finit_image_library): Return t for built-in image types,
6454 like pbm and xbm. (Bug#8640)
6455
57679c86
AS
64562011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6457
6458 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6459
888c9e86
EZ
64602011-05-07 Eli Zaretskii <eliz@gnu.org>
6461
b0512a1d
EZ
6462 * w32console.c (Fset_screen_color): Doc fix.
6463 (Fget_screen_color): New function.
6464 (syms_of_ntterm): Defsubr it.
6465
7285dc67
EZ
6466 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6467 unlink the temporary file if Fcall_process didn't create it in the
6468 first place.
6469 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6470 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6471 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6472 cue to call_process_cleanup not to close that handle.
6473
4d3fcc8e
BK
64742011-05-07 Ben Key <bkey76@gmail.com>
6475
6476 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6477 one of two shell specific rules, either bootstrap-temacs-CMD or
6478 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6479 to the previous implementation of the bootstrap-temacs rule.
6480 The bootstrap-temacs-CMD rule is similar to the previous
6481 implementation of the bootstrap-temacs rule except that it
6482 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6483 variable.
6484
6485 These changes, along with some changes to nt/configure.bat,
6486 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6487 earlier fix to add support for --cflags and --ldflags options
6488 that include quotes so that it works whether make uses cmd or
6489 sh as the shell.
6490
b4289b64
MA
64912011-05-06 Michael Albinus <michael.albinus@gmx.de>
6492
6493 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6494 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6495 is a constant.
6496 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6497 a string. Handle both cases.
6498 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6499 (Fdbus_register_method): Use Qinvalid_function.
6500
af4c0e28
JB
65012011-05-06 Juanma Barranquero <lekktu@gmail.com>
6502
6503 * makefile.w32-in: Update dependencies.
6504 (LISP_H): Add inttypes.h and stdin.h.
6505 (PROCESS_H): Add unistd.h.
6506
c51453d9
EZ
65072011-05-06 Eli Zaretskii <eliz@gnu.org>
6508
6509 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6510 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6511
8ff0ac3c 65122011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6513
4c4b566b
PE
6514 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6515
aab2b9b5
PE
6516 * term.c (vfatal): Remove stray call to va_end.
6517 It's not needed and the C Standard doesn't allow it here anyway.
6518
c378da0b
PE
6519 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6520 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6521
288b08c7
PE
6522 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6523 bytes.
6524
e3601888
PE
6525 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6526
db6c0e74
PE
6527 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6528
dd5963ea
PE
6529 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6530
88c9450f
PE
6531 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6532
2f9442b8
PE
6533 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6534
c032b5f8
PE
6535 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6536 * charset.c (Fdefine_charset_internal): Don't initialize
6537 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6538 32-bit int (Bug#8600).
a108c10b
PE
6539
6540 * lread.c (read_integer): Be more consistent with string-to-number.
6541 Use string_to_number to do the actual conversion; this avoids
6542 rounding errors and fixes some other screwups. Without this fix,
6543 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6544 (digit_to_number): Move earlier, for benefit of read_integer.
6545 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6546 not a digit in any supported base. (Bug#8602)
a108c10b 6547
ad5f9eea
PE
6548 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6549
aec1708a
PE
6550 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6551 to match comment at start of function. This also removes a
6552 GCC warning about overflow in a 32+64-bit port.
6553
47be4ab5
PE
6554 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6555
371cac43
PE
6556 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6557 Reported by Stefan Monnier in
6558 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6559 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6560 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6561
d01a7826
PE
6562 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6563 (EMACS_UINTPTR): Likewise, with uintptr_t.
6564
7fd47d5c
PE
6565 * lisp.h: Prefer 64-bit EMACS_INT if available.
6566 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6567 on 32-bit hosts that have 64-bit int, so that they can access
6568 large files.
122b0c86
PE
6569 However, temporarily disable this change unless the temporary
6570 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6571
8727937b
PE
6572 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6573
8ac068ac
PE
6574 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6575 This removes an assumption that EMACS_INT and long are the same
6576 width as pointers. The assumption is true for Emacs porting targets
6577 now, but we want to make other targets possible.
6578 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6579 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6580 In the rest of the code, change types of integers that hold casted
6581 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6582 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6583 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6584 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6585 No need to cast type when ORing.
6586 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6587 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6588 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6589 assume EMACS_INT is the same width as char *.
6590 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6591 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6592 Remove no-longer-needed casts.
6593 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6594 (xg_tool_bar_help_callback, xg_make_tool_item):
6595 Use EMACS_INTPTR to hold an integer
6596 that will be cast to void *; this can avoid a GCC warning
6597 if EMACS_INT is not the same width as void *.
6598 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6599 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6600 (current_message_1, set_message_1):
6601 Use a local to convert to proper width without a cast.
6602 * xmenu.c (dialog_selection_callback): Likewise.
6603
ede49d71
PE
6604 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6605 Also, don't assume VALBITS / RAND_BITS is less than 5,
6606 and don't rely on undefined behavior when shifting a 1 left into
6607 the sign bit.
6608 * lisp.h (get_random): Change signature to match.
6609
2f30ecd0
PE
6610 * lread.c (hash_string): Use size_t, not int, for hash computation.
6611 Normally we prefer signed values; but hashing is special, because
6612 it's better to use unsigned division on hash table sizes so that
6613 the remainder is nonnegative. Also, size_t is the natural width
6614 for hashing into memory. The previous code used 'int', which doesn't
6615 retain enough info to hash well into very large tables.
6616 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6617
2a866e7b
PE
6618 * dbusbind.c: Don't possibly lose pointer info when converting.
6619 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6620 Use XPNTR rather than XHASH, so that the high-order bits of
6621 the pointer aren't lost when converting through void *.
6622
51639eac
PE
6623 * eval.c (Fautoload): Don't double-shift a pointer.
6624
92394119
PE
6625 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6626
dbdb9a7c
JB
66272011-05-06 Juanma Barranquero <lekktu@gmail.com>
6628
6629 * gnutls.c (DEF_GNUTLS_FN):
6630 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6631
db7a0b4f
AS
66322011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6633
6634 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6635 marker. (Bug#8610)
6636
cd394be1 66372011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6638
6639 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6640 New version that can reserve upto 2GB of heap space.
6641
f7ff1b0f 66422011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6643
6644 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6645
639c109b
TZ
66462011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6647
6648 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6649 `gnutls_certificate_set_x509_key_file'.
6650
d2127135
JB
66512011-05-05 Juanma Barranquero <lekktu@gmail.com>
6652
6653 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6654 Update dependencies.
6655
e968f4f3
JB
66562011-05-04 Juanma Barranquero <lekktu@gmail.com>
6657
6658 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6659 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6660 Remove unused parameter `fildes'.
6661 * process.c (read_process_output, send_process): Don't pass it.
6662
84d358f0
JB
66632011-05-04 Juanma Barranquero <lekktu@gmail.com>
6664
6665 Fix previous change: the library cache is defined in w32.c.
6666 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6667 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6668
0898ca10
JB
66692011-05-04 Juanma Barranquero <lekktu@gmail.com>
6670
6671 Implement dynamic loading of GnuTLS on Windows.
6672
6673 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6674 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6675 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6676 Declare.
6677
6678 * gnutls.c (Qgnutls_dll): Define.
6679 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6680 (gnutls_*): Declare function pointers.
6681 (init_gnutls_functions): New function to initialize function pointers.
6682 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6683 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6684 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6685 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6686 (emacs_gnutls_write, emacs_gnutls_read)
6687 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6688 (Fgnutls_available_p): New function.
6689 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6690 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6691 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6692
6693 * image.c: Include w32.h.
6694 (Vimage_type_cache): Delete.
6695 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6696 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6697 (w32_delayed_load): Move to w32.c.
6698
6699 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6700
6701 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6702 (w32_delayed_load): Move from image.c. When loading a library, record
6703 its filename in the :loaded-from property of the library id.
6704 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6705 Initialize and staticpro them.
6706 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6707
6708 * process.c: Include lisp.h before w32.h, not after.
6709 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6710 instead of gnutls_record_check_pending.
6711
6712 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6713
ff4de4aa
TZ
67142011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6715
6716 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6717 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6718 as passed in.
6719
abe95abb
JD
67202011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6721
6722 * xterm.c (x_set_frame_alpha): Do not set property on anything
6723 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6724
e16e55d4
JB
67252011-05-02 Juanma Barranquero <lekktu@gmail.com>
6726
6727 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6728
bafcf6a5
JB
67292011-05-02 Juanma Barranquero <lekktu@gmail.com>
6730
6731 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6732 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6733 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6734 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6735 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6736 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6737 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6738 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6739 (Qgnutls_bootprop_callbacks_verify): Make static.
6740
e7a6747f
AS
67412011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6742
19ed11ba
AS
6743 * callproc.c: Indentation fixup.
6744
e7a6747f 6745 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6746 (wait_for_termination, interruptible_wait_for_termination):
6747 Move after wait_for_termination_1.
e7a6747f 6748
1ef14cb4
LMI
67492011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6750
6751 * sysdep.c (interruptible_wait_for_termination): New function
6752 which is like wait_for_termination, but allows keyboard
6753 interruptions.
6754
6755 * callproc.c (Fcall_process): Add (:file "file") as an option for
6756 the STDOUT buffer.
6757 (Fcall_process_region): Ditto.
6758
330d880c
EZ
67592011-04-30 Eli Zaretskii <eliz@gnu.org>
6760
8db90b73
EZ
6761 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6762 rather than `XVECTOR (FOO)->size'.
6763
330d880c
EZ
6764 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6765 inttypes.h, as a gnulib replacement is used if it not available in
6766 system headers.
6767
15cbd324
EZ
67682011-04-21 Eli Zaretskii <eliz@gnu.org>
6769
6770 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6771 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6772 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6773
6774 * coding.c (coding_alloc_by_realloc): Error out if destination
6775 will grow beyond MOST_POSITIVE_FIXNUM.
6776 (decode_coding_emacs_mule): Abort if there isn't enough place in
6777 charbuf for the composition carryover bytes. Reserve an extra
6778 space for up to 2 characters produced in a loop.
6779 (decode_coding_iso_2022): Abort if there isn't enough place in
6780 charbuf for the composition carryover bytes.
6781
67822011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6783
ae940cca
EZ
6784 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6785 aborting when %lld or %lll format is passed.
6786 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6787 %llo or %llx format is passed. (Bug#8545)
6788
03ab8921
EZ
6789 * window.c (window_scroll_line_based): Use a marker instead of
6790 simple variables to record original value of point. (Bug#7952)
6791
afda1437
EZ
6792 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6793 produced by %s or %c overflows available buffer space. (Bug#8545)
6794
f76dee0c
PE
67952011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6796
6797 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6798 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6799
fdc5744d
JB
68002011-04-28 Juanma Barranquero <lekktu@gmail.com>
6801
6802 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6803
638f053a
JB
68042011-04-28 Juanma Barranquero <lekktu@gmail.com>
6805
6806 * keyboard.c (Qdelayed_warnings_hook): Define.
6807 (command_loop_1): Run `delayed-warnings-hook'
6808 if Vdelayed_warnings_list is non-nil.
6809 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6810 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6811
d178f871
EZ
68122011-04-28 Eli Zaretskii <eliz@gnu.org>
6813
6814 * doprnt.c (doprnt): Don't return value smaller than the buffer
6815 size if the message was truncated. (Bug#8545).
6816
b124fd93
JB
68172011-04-28 Juanma Barranquero <lekktu@gmail.com>
6818
6819 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6820 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6821
e810457d
PE
68222011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6823
6824 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6825
ea51cceb
JB
68262011-04-27 Juanma Barranquero <lekktu@gmail.com>
6827
6828 * makefile.w32-in: Update dependencies.
6829
94dcfacf
EZ
68302011-04-27 Eli Zaretskii <eliz@gnu.org>
6831
6832 Improve `doprnt' and its usage. (Bug#8545)
6833 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6834 `format_end'. Remove support for %l as a conversion specifier.
6835 Don't use xrealloc. Improve diagnostics when the %l size modifier
6836 is used. Update the commentary.
6837
6838 * eval.c (verror): Simplify calculation of size_t.
6839
6840 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6841 messages.
6842
f61f41d7
PE
68432011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6844
6845 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6846 change.
6847
96fb4434
PE
68482011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6849
6850 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6851 This makes this file independent of the recent pseudovector change.
6852
671875da 68532011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6854
69e9b5a3
PE
6855 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6856
b5f869a7 6857 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6858 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6859 Remove unused local.
c8926152 6860 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6861
841a1577 6862 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6863 GCC 4.6.0 optimizes based on type-based alias analysis.
6864 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6865 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6866 != &v->size, and therefore "v->size = 1; b->size = 2; return
6867 v->size;" must therefore return 1. This assumption is incorrect
6868 for Emacs, since it type-puns struct Lisp_Vector * with many other
6869 types. To fix this problem, this patch adds a new type struct
f904488f 6870 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6871 and pseudovectors, and helps optimizing compilers not get fooled
6872 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6873 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6874 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6875 the size member.
eab3844f
PE
6876 (XSETPVECTYPE): Rewrite in terms of new macro.
6877 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6878 This is a bit clearer, and further avoids the possibility of
6879 undesirable aliasing.
6880 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6881 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6882 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6883 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6884 (ASIZE): Now uses header.size rather than size.
6885 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6886 to avoid the hassle of writing XVECTOR (foo)->header.size.
6887 (struct vectorlike_header): New type.
eab3844f
PE
6888 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6889 object, to help avoid aliasing.
6890 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6891 (SUBRP): Likewise, since Lisp_Subr is a special case.
6892 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6893 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6894 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6895 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6896 changed to be "header.size" and "header.next".
6897 * buffer.h (struct buffer): Likewise.
6898 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6899 * frame.h (struct frame): Likewise.
6900 * process.h (struct Lisp_Process): Likewise.
6901 * termhooks.h (struct terminal): Likewise.
6902 * window.c (struct save_window_data, struct saved_window): Likewise.
6903 * window.h (struct window): Likewise.
6904 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6905 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6906 * buffer.c (init_buffer_once): Likewise.
6907 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6908 special case.
6909 * process.c (Fformat_network_address): Use local var for size,
6910 for brevity.
6911
0df1eac5
PE
6912 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6913
847ab9d1 6914 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6915 * data.c (atof): Remove decl; no longer used or needed.
6916 (digit_to_number): Move to lread.c.
6917 (Fstring_to_number): Use new string_to_number function, to be
6918 consistent with how the Lisp reader treats infinities and NaNs.
6919 Do not assume that floating-point numbers represent EMACS_INT
6920 without losing information; this is not true on most 64-bit hosts.
6921 Avoid double-rounding errors, by insisting on integers when
6922 parsing non-base-10 numbers, as the documentation specifies.
6923 * lisp.h (string_to_number): New decl, replacing ...
6924 (isfloat_string): Remove.
bc0a5c13 6925 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6926 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6927 appears to have been a coding error. Similarly, do not accept
6928 strings like +-1e0 as floating point numbers. Do not report
6929 overflow for integer overflows unless the base is not 10 which
6930 means we have no simple and reliable way to continue.
6931 Break out the floating-point parsing into a new
6932 function string_to_number, so that Fstring_to_number parses
6933 floating point numbers consistently with the Lisp reader.
04f2d78b 6934 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6935 (E_CHAR, EXP_INT): Remove, replacing with ...
6936 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6937 (string_to_number): New function, replacing isfloat_string.
6938 This function checks for valid syntax and produces the resulting
6939 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6940 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6941 so that overflow for non-base-10 numbers is reported only when
6942 there's no portable and simple way to convert to floating point.
452f4150 6943
67769ffc
PE
6944 * textprop.c (set_text_properties_1): Rewrite for clarity,
6945 and to avoid GCC warning about integer overflow.
6946
c20db43f
PE
6947 * intervals.h (struct interval): Use EMACS_INT for members
6948 where EMACS_UINT might cause problems. See
6949 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6950 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6951 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6952 All uses changed.
37aa2f85
PE
6953 (offset_intervals): Tell GCC not to worry about length overflow
6954 when negating a negative length.
c20db43f 6955
2538aa2f
PE
6956 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6957 (overrun_check_free): Likewise.
6958
f2d3008d
PE
6959 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6960 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6961 word size.
6962
ec8df744
PE
6963 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6964 (gnutls_make_error): Rename local to avoid shadowing.
6965 (gnutls_emacs_global_deinit): ifdef out; not used.
6966 (Fgnutls_boot): Use const for pointer to readonly storage.
6967 Comment out unused local. Fix pointer signedness problems.
6968
640ee02d
PE
6969 * lread.c (openp): Don't stuff size_t into an 'int'.
6970 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6971 about possible signed overflow.
6972
6048fb2a
PE
6973 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6974 (GDK_KEY_g): Don't define if already defined.
6975 (xg_prepare_tooltip): Avoid pointer signedness problem.
6976 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6977
fa3c87e1
PE
6978 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6979 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6980
2172544b
PE
6981 * xfns.c (Fx_window_property): Simplify a bit,
6982 to make a bit faster and to avoid GCC 4.6.0 warning.
6983 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6984
9b821a21
PE
6985 * fns.c (internal_equal): Don't assume size_t fits in int.
6986
3c616cfa
PE
6987 * alloc.c (compact_small_strings): Tighten assertion a little.
6988
c2982e87
PE
6989 Replace pEd with more-general pI, and fix some printf arg casts.
6990 * lisp.h (pI): New macro, generalizing old pEd macro to other
6991 conversion specifiers. For example, use "...%"pI"d..." rather
6992 than "...%"pEd"...".
6993 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6994 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6995 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6996 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6997 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6998 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6999 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7000 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7001 64-bit hosts.
7002 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7003 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7004 * print.c (safe_debug_print, print_object): Likewise.
7005 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7006 to int.
6f04d126
PE
7007 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7008 avoiding the 0 flag, which is not portable.
c2982e87
PE
7009 * process.c (Fmake_network_process): Use pI to avoid cast.
7010 * region-cache.c (pp_cache): Likewise.
7011 * xdisp.c (decode_mode_spec): Likewise.
7012 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7013 behavior on 64-bit hosts with printf arg.
6f04d126 7014 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7015 (x_stop_queuing_selection_requests): Likewise.
7016 (x_get_window_property): Don't truncate byte count to an 'int'
7017 when tracing.
0b432f21 7018
5e073ec7
PE
7019 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7020 here, since it parses constructs like leading '-' and spaces,
7021 which are not wanted; and it overflows with large numbers.
7022 Instead, simply match F[0-9]+, which is what is wanted anyway.
7023
36372bf9
PE
7024 * alloc.c: Remove unportable assumptions about struct layout.
7025 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7026 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7027 (allocate_vectorlike, make_pure_vector): Use the new macros,
7028 plus offsetof, to remove unportable assumptions about struct layout.
7029 These assumptions hold on all porting targets that I know of, but
7030 they are not guaranteed, they're easy to remove, and removing them
7031 makes further changes easier.
7032
0b432f21
PE
7033 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7034 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7035 (string_overrun_cookie): Now const. Use initializers that
7036 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7037 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7038 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7039 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7040 multiple of sizeof (EMACS_INT); it need not be, if
7041 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7042 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7043
895009e1
JB
70442011-04-26 Juanma Barranquero <lekktu@gmail.com>
7045
7046 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7047
6a7a1b0b
TZ
70482011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7049
7050 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7051 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7052 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7053
841a1577 70542011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7055
7056 * lisp.h (Qdebug): List symbol.
895009e1 7057 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7058 * keyboard.c (debug-on-event): New variable.
7059 (handle_user_signal): Break into debugger when debug-on-event
7060 matches the current signal symbol.
7061
f2d3ba6f
DN
70622011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7063
7064 * alloc.c (check_sblock, check_string_bytes)
7065 (check_string_free_list): Convert to standard C.
7066
42ce4c63
TZ
70672011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7068
7069 * w32.c (emacs_gnutls_push): Fix typo.
7070
825cd63c
EZ
70712011-04-25 Eli Zaretskii <eliz@gnu.org>
7072
fb11d64d
EZ
7073 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7074 "cast to pointer from integer of different size".
7075
825cd63c
EZ
7076 Improve doprnt and its use in verror. (Bug#8545)
7077 * doprnt.c (doprnt): Document the set of format control sequences
7078 supported by the function. Use SAFE_ALLOCA instead of always
7079 using `alloca'.
7080
7081 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7082 is one byte too soon. Don't use xrealloc; instead xfree and
7083 xmalloc anew.
7084
e061a11b
TZ
70852011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7086
7087 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7088 callbacks stage.
7089
7090 * gnutls.c: Renamed global_initialized to
7091 gnutls_global_initialized. Added internals for the
7092 :verify-hostname-error, :verify-error, and :verify-flags
7093 parameters of `gnutls-boot' and documented those parameters in the
7094 docstring. Start callback support.
9173deec
JB
7095 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7096 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7097 on error. Return error code.
e061a11b
TZ
7098 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7099 (emacs_gnutls_read): Likewise.
7100 (Fgnutls_boot): Return handshake error code.
7101 (emacs_gnutls_handle_error): New function.
7102 (wsaerror_to_errno): Likewise.
7103
7104 * w32.h (emacs_gnutls_pull): Add prototype.
7105 (emacs_gnutls_push): Likewise.
7106
7107 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7108 (emacs_gnutls_push): Likewise.
7109
71102011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7111
7112 * process.c (wait_reading_process_output): Check if GnuTLS
7113 buffered some data internally if no FDs are set for TLS
7114 connections.
7115
7116 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7117 (LIBS): Link to USER_LIBS.
7118 ($(BLD)/gnutls.$(0)): New target.
7119
fa6996bc
EZ
71202011-04-24 Eli Zaretskii <eliz@gnu.org>
7121
eb35682e
EZ
7122 * xdisp.c (handle_single_display_spec): Rename the
7123 display_replaced_before_p argument into display_replaced_p, to
7124 make it consistent with the commentary. Fix typos in the
7125 commentary.
7126
e2ad650c
EZ
7127 * textprop.c (syms_of_textprop): Remove dead code.
7128 (copy_text_properties): Delete obsolete commentary about an
7129 interface that was deleted long ago. Fix typos in the description
7130 of arguments.
7131
1b2de274
EZ
7132 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7133 to changes in oldXMenu/XMenu.h from 2011-04-16.
7134 <menu_help_message, prev_menu_help_message>: Constify.
7135 (IT_menu_make_room): menu->help_text is now `const char **';
7136 adjust.
7137
7138 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7139 to changes in oldXMenu/XMenu.h from 2011-04-16.
7140 (struct XMenu): Declare `help_text' `const char **'.
7141
7142 * xfaces.c <Qunspecified>: Make extern again.
7143
7144 * syntax.c: Include sys/types.h before including regex.h, as
7145 required by Posix.
7146
762b15be
EZ
7147 * doc.c (get_doc_string): Improve the format passed to `error'.
7148
7149 * doprnt.c (doprnt): Improve commentary.
7150
7151 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7152
7153 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7154 them with etags.
7155
f1052e5d
EZ
7156 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7157 changes in globals.h immediately force recompilation.
762b15be
EZ
7158 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7159 $(CURDIR)/s/ms-w32.h.
7160 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7161
fa6996bc
EZ
7162 * character.c (Fchar_direction): Function deleted.
7163 (syms_of_character): Don't defsubr it.
7164 <char-direction-table>: Deleted.
7165
e6c3da20
EZ
71662011-04-23 Eli Zaretskii <eliz@gnu.org>
7167
7168 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7169 * doprnt.c: Include limits.h.
7170 (SIZE_MAX): New macro.
04f2d78b
CB
7171 (doprnt): Return a size_t value. 2nd arg is now size_t.
7172 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7173 Improve overflow protection. Support `l' modifier for integer
7174 conversions. Support %l conversion. Don't assume an EMACS_INT
7175 argument for integer conversions and for %c.
7176
7177 * lisp.h (doprnt): Restore prototype.
7178
7179 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7180 $(SRC)/character.h.
7181
7182 * Makefile.in (base_obj): Add back doprnt.o.
7183
7184 * deps.mk (doprnt.o): Add back prerequisites.
7185 (callint.o): Depend on character.h.
7186
7187 * eval.c (internal_lisp_condition_case): Include the handler
7188 representation in the error message.
7189 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7190 when breaking from the loop.
7191
7192 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7193
7194 * callint.c (Fcall_interactively): When displaying error message
7195 about invalid control letter, pass the character's codepoint, not
7196 a pointer to its multibyte form. Improve display of the character
7197 in octal and display also its hex code.
7198
7199 * character.c (char_string): Use %x to display the (unsigned)
7200 codepoint of an invalid character, to avoid displaying a bogus
7201 negative value.
7202
7203 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7204 `error', not SYMBOL_NAME itself.
7205
7206 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7207 character arguments to `error'.
7208
7209 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7210 to `error' in error message about FINAL_CHAR argument. Make sure
7211 FINAL_CHAR is a character, and use %c when it is passed as
7212 argument to `error'.
7213
4ffd0d6b 72142011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7215
7216 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7217
7218 * w32.c: Include <time.h>.
7219 (sys_localtime): New function.
7220
4ffd0d6b 72212011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7222
7223 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7224
4ffd0d6b 7225 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7226
4ffd0d6b 72272011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7228
4ffd0d6b
GM
7229 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7230 zombies (Bug#8467).
aac0c6e3 7231
04c56954
EZ
72322011-04-19 Eli Zaretskii <eliz@gnu.org>
7233
7234 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7235 gl_state.e_property when gl_state.object is Qt.
7236
7237 * insdel.c (make_gap_larger): Remove limitation of buffer size
7238 to <= INT_MAX.
7239
16a43933
CY
72402011-04-18 Chong Yidong <cyd@stupidchicken.com>
7241
7242 * xdisp.c (lookup_glyphless_char_display)
7243 (produce_glyphless_glyph): Handle cons cell entry in
7244 glyphless-char-display.
7245 (Vglyphless_char_display): Document it.
7246
7247 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7248 glyphless-char-display.
7249
4581706e
CY
72502011-04-17 Chong Yidong <cyd@stupidchicken.com>
7251
7252 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7253
7254 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7255
7256 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7257 definition for no-X builds.
7258
4887c6e2 72592011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7260
fd35b6f9
PE
7261 Static checks with GCC 4.6.0 and non-default toolkits.
7262
5c1ccb01
PE
7263 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7264
006c5daa
PE
7265 * process.c (keyboard_bit_set): Define only if SIGIO.
7266 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7267 (send_process): Repair possible setjmp clobbering.
7268
efc736d3
PE
7269 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7270
4e2fe2e6
PE
7271 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7272
f97334a2
PE
7273 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7274
4e75f29d
PE
7275 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7276 Define only if needed.
7277
90efadd1
PE
7278 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7279 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7280 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7281
3c647824
PE
7282 * dispextern.h (struct redisplay_interface): Rename param
7283 to avoid shadowing.
e264f262 7284 * termhooks.h (struct terminal): Likewise.
761383f4 7285 * xterm.c (xembed_send_message): Likewise.
3c647824 7286
b58c5c4a
PE
7287 * insdel.c (make_gap_smaller): Define only if
7288 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7289
cad59032
PE
7290 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7291 it.
7292
c339dc2e
PE
7293 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7294 so that we aren't warned about unused symbols.
7295
91a3e27b
PE
7296 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7297
399c71d3 7298 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7299
8ffc96f5
PE
7300 * xfns.c (x_real_positions): Mark locals as initialized.
7301
eef9bc79
PE
7302 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7303
098db9dd
PE
7304 * xterm.c: Fix problems found by static analysis with other toolkits.
7305 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7306 (x_dispatch_event): Declare static if USE_GTK, and
7307 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7308 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7309 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7310 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7311 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7312
eb18f6cc
PE
7313 * xmenu.c (menu_help_callback): Pointer type fixes.
7314 Use const pointers when pointing at readonly data. Avoid pointer
7315 signedness clashes.
7316 (FALSE): Remove unused macro.
7317 (update_frame_menubar): Remove unused decl.
7318
1fe72bf8
PE
7319 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7320
60d9e1db
PE
7321 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7322 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7323 (single_menu_item): Rename local to avoid shadowing.
7324
39261c26
PE
7325 * keyboard.c (make_lispy_event): Remove unused local var.
7326
018c5e19
PE
7327 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7328 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7329
63d2b86e
PE
7330 * bitmaps: Change bitmaps from unsigned char back to the X11
7331 compatible char. Avoid the old compiler warnings about
7332 out-of-range initializers by using, for example, '\xab' rather
7333 than 0xab.
7334
aefd87e1
PE
7335 * xgselect.c (xgselect_initialize): Check vs interface
7336 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7337
bf501fb9
PE
7338 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7339
e9829fdf
PE
7340 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7341 to read-only memory.
7342
1086c095
PE
7343 * fns.c (vector): Remove; this old hack is no longer needed.
7344
2baccd04 7345 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7346 Remove unused var.
dde42981 7347 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7348
72391843 7349 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7350
436c16df 7351 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7352 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7353 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7354
92bb796d 7355 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7356 (x_term_init): Remove local to avoid shadowing.
92bb796d 7357
764430a3 7358 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7359
7360 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7361 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7362
d1dfb56c
EZ
73632011-04-16 Eli Zaretskii <eliz@gnu.org>
7364
c4354cb4
EZ
7365 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7366
d1dfb56c
EZ
7367 Fix regex.c, syntax.c and friends for buffers > 2GB.
7368 * syntax.h (struct gl_state_s): Declare character position members
7369 EMACS_INT.
7370
7371 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7372
04f2d78b
CB
7373 * textprop.c (verify_interval_modification, interval_of):
7374 Declare arguments EMACS_INT.
d1dfb56c
EZ
7375
7376 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7377 EMACS_INT.
7378
7379 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7380
7381 * indent.c (Fvertical_motion): Local variable it_start is now
7382 EMACS_INT.
7383
7384 * regex.c (re_match, re_match_2, re_match_2_internal)
7385 (bcmp_translate, regcomp, regexec, print_double_string)
7386 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7387 (re_compile_pattern, re_exec): Declare arguments and local
7388 variables `size_t' and `ssize_t' and return values `regoff_t', as
7389 appropriate.
7390 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7391 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7392 <compile_stack_type>: `size' and `avail' are now `size_t'.
7393
7394 * regex.h <regoff_t>: Use ssize_t, not int.
7395 (re_search, re_search_2, re_match, re_match_2): Arguments that
7396 specify buffer/string position and length are now ssize_t and
7397 size_t. Return type is regoff_t.
7398
613052cd
BK
73992011-04-16 Ben Key <bkey76@gmail.com>
7400
7401 * nsfont.m: Fixed bugs in ns_get_family and
7402 ns_descriptor_to_entity that were caused by using free to
7403 deallocate memory blocks that were allocated by xmalloc (via
7404 xstrdup). This caused Emacs to crash when compiled with
7405 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7406 --enable-checking=xmallocoverrun). xfree is now used to
7407 deallocate these memory blocks.
7408
4170f62f 74092011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7410
71b41406
PE
7411 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7412
9587a89d
PE
7413 emacs_write: Accept and return EMACS_INT for sizes.
7414 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7415 et seq.
7416 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7417 Accept and return EMACS_INT.
7418 (emacs_gnutls_write): Return the number of bytes written on
7419 partial writes.
7420 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7421 (emacs_read, emacs_write): Remove check for negative size, as the
7422 Emacs source code has been audited now.
9587a89d
PE
7423 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7424 (emacs_read, emacs_write): Use it.
273a5f82
PE
7425 * process.c (send_process): Adjust to the new signatures of
7426 emacs_write and emacs_gnutls_write. Do not attempt to store
7427 a byte offset into an 'int'; it might overflow.
9587a89d 7428 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7429
3e047f51
PE
7430 * sound.c: Don't assume sizes fit in 'int'.
7431 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7432 Return EMACS_INT, not int.
3e047f51 7433 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7434 Accept EMACS_INT, not int.
7435 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7436 record read return values.
7437
cc39a9db
BK
74382011-04-15 Ben Key <bkey76@gmail.com>
7439
c9d0ec6d
JB
7440 * keyboard.c (Qundefined): Don't declare static since it is used
7441 in nsfns.m.
7442 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7443 static since they are used in nsfont.m.
cc39a9db 7444
6c60eb9f
SM
74452011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7446
7447 * process.c (Qprocessp): Don't declare static.
7448 * lisp.h (Qprocessp): Declare again.
7449
7990b61a
JB
74502011-04-15 Juanma Barranquero <lekktu@gmail.com>
7451
7452 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7453
5d4cb038
PE
74542011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7455
8bd7b830 7456 Improve C-level modularity by making more things 'static'.
cd64ea1d 7457
e3b27b31
PE
7458 Don't publish debugger-only interfaces to other modules.
7459 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7460 (verify_bytepos, count_markers): Move decls to the only modules
7461 that need them.
7462 * region-cache.h (pp_cache): Likewise.
7463 * window.h (check_all_windows): Likewise.
7464 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7465
5d4cb038
PE
7466 * sysdep.c (croak): Now static, if
7467 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7468 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7469
7470 * alloc.c (refill_memory_reserve): Now static if
7471 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7472 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7473
e87b6180
PE
7474 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7475 Define only if USE_LUCID.
7476
ac64929e
PE
7477 * xrdb.c (x_customization_string, x_rm_string): Now static.
7478
6f37259d
PE
7479 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7480 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7481
1683e3ab
PE
7482 * xdisp.c (draw_row_with_mouse_face): Now static.
7483 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7484
de9c2632
PE
7485 * window.h (check_all_windows): Mark externally visible.
7486
2b96acb7
PE
7487 * window.c (window_deletion_count): Now static.
7488
7489 * undo.c: Make symbols static if they're not exported.
7490 (last_undo_buffer, last_boundary_position, pending_boundary):
7491 Now static.
7492
50436f33
PE
7493 * textprop.c (interval_insert_behind_hooks): Now static.
7494 (interval_insert_in_front_hooks): Likewise.
7495
64520e5c
PE
7496 * term.c: Make symbols static if they're not exported.
7497 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7498 (max_frame_lines, tty_set_terminal_modes):
7499 (tty_reset_terminal_modes, tty_turn_off_highlight):
7500 (get_tty_terminal): Now static.
7501 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7502 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7503 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7504 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7505 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7506
1fa53021
PE
7507 * sysdep.c: Make symbols static if they're not exported.
7508 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7509 Now static.
7510 (sigprocmask_set, full_mask): Remove; unused.
7511 (wait_debugging): Mark as visible.
7512 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7513 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7514
d4b43b22
PE
7515 * syntax.c (syntax_temp): Define only if !__GNUC__.
7516
b7c513d0
PE
7517 * sound.c (current_sound_device, current_sound): Now static.
7518
989b29ad
PE
7519 * search.c (searchbufs, searchbuf_head): Now static.
7520
13a55a78
PE
7521 * scroll.c (scroll_cost): Remove; unused.
7522 * dispextern.h (scroll_cost): Remove decl.
7523
de68a1fc
PE
7524 * region-cache.h (pp_cache): Mark as externally visible.
7525
40ccffa6
PE
7526 * process.c: Make symbols static if they're not exported.
7527 (process_tick, update_tick, create_process, chan_process):
7528 (Vprocess_alist, proc_buffered_char, datagram_access):
7529 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7530 (deactivate_process): Mark defn as static, as well as decl.
7531 * lisp.h (create_process): Remove decl.
7532 * process.h (chan_process, Vprocess_alist): Remove decls.
7533
ad64fc97
PE
7534 * print.c: Make symbols static if they're not exported.
7535 (print_depth, new_backquote_output, being_printed, print_buffer):
7536 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7537 (print_interval, print_number_index, initial_stderr_stream):
7538 Now static.
7539 * lisp.h (Fprinc): Remove decl.
7540 (debug_output_compilation_hack): Mark as externally visible.
7541
adddb265
PE
7542 * sysdep.c (croak): Move decl from here to syssignal.h.
7543 * syssignal.h (croak): Put it here, so the API can be checked when
7544 'croak' is called from dissociate_if_controlling_tty.
7545
1717ede2
PE
7546 * minibuf.c: Make symbols static if they're not exported.
7547 (minibuf_save_list, choose_minibuf_frame): Now static.
7548 * lisp.h (choose_minibuf_frame): Remove decl.
7549
fa5fb2bc
PE
7550 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7551
1e3890d1
PE
7552 * lread.c: Make symbols static if they're not exported.
7553 (read_objects, initial_obarray, oblookup_last_bucket_number):
7554 Now static.
7555 (make_symbol): Remove; unused.
7556 * lisp.h (initial_obarray, make_symbol): Remove decls.
7557
8a1414fa
PE
7558 * keyboard.c: Make symbols static if they're not exported.
7559 (single_kboard, recent_keys_index, total_keys, recent_keys):
7560 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7561 (this_single_command_key_start, echoing, last_auto_save):
7562 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7563 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7564 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7565 (Vlispy_mouse_stem, double_click_count):
7566 Now static.
7567 (force_auto_save_soon): Define only if SIGDANGER.
7568 (ignore_mouse_drag_p): Now static if
7569 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7570 (print_help): Remove; unused.
7571 (stop_character, last_timer_event): Mark as externally visible.
7572 * keyboard.h (ignore_mouse_drag_p): Declare only if
7573 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7574 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7575 * lisp.h (echoing): Remove decl.
7576 (force_auto_save_soon): Declare only if SIGDANGER.
7577 * xdisp.c (redisplay_window): Simplify code, to make it more
7578 obvious that ignore_mouse_drag_p is not accessed if !defined
7579 USE_GTK && !defined HAVE_NS.
7580
93ea6e8f
PE
7581 * intervals.c: Make symbols static if they're not exported.
7582 (merge_properties_sticky, merge_interval_right, delete_interval):
7583 Now static.
7584 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7585
77382fcc
PE
7586 * insdel.c: Make symbols static if they're not exported.
7587 However, leave prepare_to_modify_buffer alone. It's never
7588 called from outside this function, but that appears to be a bug.
7589 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7590 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7591 (adjust_after_replace_noundo): Remove; unused.
7592 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7593 (signal_before_change): Remove decls.
77382fcc 7594
9306c32e
PE
7595 * indent.c (val_compute_motion, val_vmotion): Now static.
7596
cd44d2eb
PE
7597 * image.c: Make symbols static if they're not exported.
7598 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7599 if USE_GTK.
7600 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7601 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7602
ad9a7a06
PE
7603 * fringe.c (standard_bitmaps): Now static.
7604 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7605
81626931
PE
7606 * frame.c: Make symbols static if they're not exported.
7607 (x_report_frame_params, make_terminal_frame): Now static.
7608 (get_frame_param): Now static, unless HAVE_NS.
7609 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7610 (x_get_resource_string): Remove; not used.
7611 * frame.h (make_terminal_frame, x_report_frame_params):
7612 (x_get_resource_string); Remove decls.
7613 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7614 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7615
239f9db9
PE
7616 * font.c, fontset.c: Make symbols static if they're not exported.
7617 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7618 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7619 * font.c (font_close_object): Now static.
7620 * font.h (font_close_object): Remove.
7621 * fontset.c (FONTSET_OBJLIST): Remove.
7622 (free_realized_fontset) #if-0 the body, which does nothing.
7623 (face_suitable_for_char_p): #if-0, as it's never called.
7624 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7625 * xfaces.c (face_at_string_position):
7626 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7627 since 0 is always ASCII.
7628
dfcf3579
PE
7629 * fns.c (weak_hash_tables): Now static.
7630
5045092b
PE
7631 * fileio.c: Make symbols static if they're not exported.
7632 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7633 (Vwrite_region_annotation_buffers): Now static.
7634
57a96f5c
PE
7635 * eval.c: Make symbols static if they're not exported.
7636 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7637 * lisp.h (backtrace_list): Remove decl.
7638
35f08c38
PE
7639 * emacs.c: Make symbols static if they're not exported.
7640 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7641 (fatal_error_code, fatal_error_signal_hook, standard_args):
7642 Now static.
7643 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7644 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7645 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7646 * lisp.h (fatal_error_signal_hook): Remove decl.
7647 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7648
f44bd759
PE
7649 * editfns.c: Move a (normally-unused) function to its only use.
7650 * editfns.c, lisp.h (get_operating_system_release): Remove.
7651 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7652 worth the hassle of breaking this out.
7653
b532497d
PE
7654 * xterm.c: Make symbols static if they're not exported.
7655 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7656 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7657 (x_destroy_window, x_delete_display):
7658 Now static.
7659 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7660 (x_mouse_leave): Remove; unused.
7661 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7662 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7663 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7664 Remove decls.
7665 (x_mouse_leave): Declare only if WINDOWSNT.
7666 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7667 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7668 USE_X_TOOLKIT.
7669
1675728f
PE
7670 * ftxfont.c: Make symbols static if they're not exported.
7671 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7672 HAVE_FREETYPE.
7673 * font.h (ftxfont_driver): Likewise.
7674
e4cebfca
PE
7675 * xfns.c: Make symbols static if they're not exported.
7676 (x_last_font_name, x_display_info_for_name):
7677 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7678 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7679 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7680 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7681 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7682 (last_show_tip_args): Now static.
7683 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7684 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7685 (x_screen_planes): Remove; unused.
7686 * dispextern.h (x_screen_planes): Remove decl.
7687
5bf46f05
PE
7688 * dispnew.c: Make symbols static if they're not exported.
7689 * dispextern.h (redraw_garbaged_frames, scrolling):
7690 (increment_row_positions): Remove.
7691 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7692 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7693 Now static.
7694 (redraw_garbaged_frames): Remove; unused.
7695
435f4c28
PE
7696 * xfaces.c: Make symbols static if they're not exported.
7697 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7698 Remove decls.
7699 * xterm.h (defined_color): Remove decls.
7700 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7701 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7702 (menu_face_changed_default, defined_color, free_realized_face):
7703 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7704 (ascii_face_of_lisp_face): Remove; unused.
7705
8524aef3
PE
7706 * xdisp.c: Make symbols static if they're not exported.
7707 * dispextern.h (scratch_glyph_row, window_box_edges):
7708 (glyph_to_pixel_coords, set_cursor_from_row):
7709 (get_next_display_element, set_iterator_to_next):
7710 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7711 (show_mouse_face): Remove decls
7712 * frame.h (message_buf_print): Likewise.
7713 * lisp.h (pop_message, set_message, check_point_in_composition):
7714 Likewise.
7715 * xterm.h (set_vertical_scroll_bar): Likewise.
7716 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7717 (message_buf_print, scratch_glyph_row, displayed_buffer):
7718 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7719 (get_next_display_element, show_mouse_face, window_box_edges):
7720 (frame_to_window_pixel_xy, check_point_in_composition):
7721 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7722 (glyph_to_pixel_coords): Remove; unused.
7723
16390cd2
PE
7724 * dired.c (file_name_completion): Now static.
7725
7726 * dbusbind.c (xd_in_read_queued_messages): Now static.
7727
a25f4dfa
PE
7728 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7729 * data.c (circular_list_error): Remove.
7730
14a9c8df
PE
7731 * commands.h (last_point_position, last_point_position_buffer):
7732 (last_point_position_window): Remove decls.
7733 * keyboard.c: Make these variables static.
7734
04f2d78b
CB
7735 * coding.h (coding, code_convert_region, encode_coding_gap):
7736 Remove decls.
74ab6df5
PE
7737 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7738 (iso_code_class, detect_coding, code_convert_region): Now static.
7739 (encode_coding_gap): Remove; unused.
7740
38dfbee1
PE
7741 * chartab.c (chartab_chars, chartab_bits): Now static.
7742
a2cb4e63
PE
7743 * charset.h (charset_iso_8859_1): Remove decl.
7744 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7745 Now static.
7746
127198fd
PE
7747 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7748 * ccl.c (Vccl_program_table): Now static.
7749 (check_ccl_update): Remove; unused.
7750
d85b608f
PE
7751 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7752 * category.h: ... from here.
7753 * category.c (check_category_table, set_category_set): Now static.
7754
31cd66f3
PE
7755 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7756 * lisp.h: Remove these decls.
7757
c358e587
PE
7758 * buffer.c (buffer_count): Remove unused var.
7759
e78aecca
PE
7760 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7761 so that it's not optimized away.
7762 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7763 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7764 exported only to the debugger.
7765
e192d7d3 7766 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7767 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7768
92470028
PE
7769 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7770 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7771 was inaccessible from Lisp.
7772 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7773 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7774
244ed907
PE
7775 alloc.c: Import and export fewer symbols, and remove unused items.
7776 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7777 is defined.
7778 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7779 it's not optimized away by whole-program optimization.
7780 (message_enable_multibyte, free_misc): Remove.
7781 (catchlist, handlerlist, mark_backtrace):
7782 Declare only if BYTE_MARK_STACK.
7783 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7784 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7785 (message_enable_multibyte): Remove decl.
7786 (free_misc, interval_free_list, float_block, float_block_index):
7787 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7788 (cons_free_list, last_marked_index):
7789 Now static.
7790 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7791 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7792 (mark_backtrace): Define only if BYTE_MARK_STACK.
7793 * xdisp.c (message_enable_multibyte): Now static.
7794
61c2b50e 7795 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7796 This makes it easier for human readers (and static analyzers)
7797 to see whether these variables are used from other modules.
7798 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7799 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7800 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7801 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7802 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7803 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7804 * xmenu.c, xselect.c:
7805 Declare Q* vars static if they are not used in other modules.
7806 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7807 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7808 Remove decls of unexported vars.
7809 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7810
95c82688
PE
7811 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7812
16a97296
PE
7813 Make Emacs functions such as Fatom 'static' by default.
7814 This makes it easier for human readers (and static analyzers)
7815 to see whether these functions can be called from other modules.
7816 DEFUN now defines a static function. To make the function external
7817 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7818 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7819 (Finit_image_library):
16a97296
PE
7820 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7821 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7822 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7823 Remove decls, since these functions are now static.
7824 (Funintern, Fget_internal_run_time): New decls, since these functions
7825 were already external.
95c82688 7826
16a97296
PE
7827 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7828 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7829 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7830 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7831 * keyboard.c, keymap.c, lread.c:
7832 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7833 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7834 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7835 Mark functions with DEFUE instead of DEFUN,
7836 if they are used in other modules.
7837 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7838 decls for now-static functions.
7839 * buffer.h (Fdelete_overlay): Remove decl.
7840 * callproc.c (Fgetenv_internal): Mark as internal.
7841 * composite.c (Fremove_list_of_text_properties): Remove decl.
7842 (Fcomposition_get_gstring): New forward static decl.
7843 * composite.h (Fcomposite_get_gstring): Remove decl.
7844 * dired.c (Ffile_attributes): New forward static decl.
7845 * doc.c (Fdocumntation_property): New forward static decl.
7846 * eval.c (Ffetch_bytecode): New forward static decl.
7847 (Funintern): Remove extern decl; now in .h file where it belongs.
7848 * fileio.c (Fmake_symbolic_link): New forward static decl.
7849 * image.c (Finit_image_library): New forward static decl.
7850 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7851 * intervals.h (Fprevious_property_change):
7852 (Fremove_list_of_text_properties): Remove decls.
7853 * keyboard.c (Fthis_command_keys): Remove decl.
7854 (Fcommand_execute): New forward static decl.
7855 * keymap.c (Flookup_key): New forward static decl.
7856 (Fcopy_keymap): Now static.
7857 * keymap.h (Flookup_key): Remove decl.
7858 * process.c (Fget_process): New forward static decl.
7859 (Fprocess_datagram_address): Mark as internal.
7860 * syntax.c (Fsyntax_table_p): New forward static decl.
7861 (skip_chars): Remove duplicate decl.
7862 * textprop.c (Fprevious_property_change): New forward static decl.
7863 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7864 Now internal.
7865 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7866 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7867
785bbd42
PE
7868 * editfns.c (Fformat): Remove unreachable code.
7869
8b913b57
AS
78702011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7871
7872 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7873 change. (Bug#8496)
7874
a6744a35
EZ
78752011-04-13 Eli Zaretskii <eliz@gnu.org>
7876
7877 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7878 when at ZV. (Bug#8487)
7879
e7974947
AS
78802011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7881
baad03f0
AS
7882 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7883 (Bug#8437)
7884 * keyboard.c (parse_tool_bar_item): Likewise.
7885 * sound.c (sound_cleanup, alsa_close): Likewise.
7886 * termcap.c (tgetent): Likewise.
7887 * xfns.c (x_default_font_parameter): Likewise.
7888 * xsettings.c (read_and_apply_settings): Likewise.
7889
e7974947
AS
7890 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7891 (overrun_check_free): Protoize.
7892
28272684
PE
78932011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7894
7895 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7896 since callers should never pass a negative size.
7897 Change the signature to match that of plain 'read' and 'write'; see
7898 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7899 * lisp.h: Update prototypes of emacs_write and emacs_read.
7900
11997c76
EZ
79012011-04-11 Eli Zaretskii <eliz@gnu.org>
7902
7903 * xdisp.c (redisplay_window): Don't try to determine the character
7904 position of the scroll margin if the window start point w->startp
e896f03c 7905 is outside the buffer's accessible region. (Bug#8468)
11997c76 7906
8a2cbd72
EZ
79072011-04-10 Eli Zaretskii <eliz@gnu.org>
7908
7909 Fix write-region and its subroutines for buffers > 2GB.
7910 * fileio.c (a_write, e_write): Modify declaration of arguments and
7911 local variables to support buffers larger than 2GB.
7912 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7913
7914 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7915 argument, local variables, and return value.
7916
7917 * lisp.h: Update prototypes of emacs_write and emacs_read.
7918
7919 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7920
4073e537 79212011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7922
1ebfdcb6
PE
7923 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7924
b2ded58d
PE
7925 Fix more problems found by GCC 4.6.0's static checks.
7926
7d66342c
PE
7927 * xdisp.c (vmessage): Use a better test for character truncation.
7928
bbf47d44
PE
7929 * charset.c (load_charset_map): <, not <=, for optimization,
7930 and to avoid potential problems with integer overflow.
9248994d 7931 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7932 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7933 * editfns.c (Fformat): Likewise.
1e69125e 7934 * syntax.c (skip_chars): Likewise.
3befa583 7935
e3019616
PE
7936 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7937 This also lets GCC 4.6.0 generate slightly better loop code.
7938
becfa255
PE
7939 * callint.c (Fcall_interactively): <, not <=, for optimization.
7940 (Fcall_interactively): Count the number of arguments produced,
7941 not the number of arguments given. This is simpler and lets GCC
7942 4.6.0 generate slightly better code.
7943
dae0cd48
PE
7944 * ftfont.c: Distingish more carefully between FcChar8 and char.
7945 The previous code passed unsigned char * to a functions like
7946 strlen and xstrcasecmp that expect char *, which does not
7947 conform to the C standard.
7948 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7949 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7950 char * when the C standard requires it.
7951
76032d70
PE
7952 * keyboard.c (read_char): Remove unused var.
7953
eb3f1cc8
PE
7954 * eval.c: Port to Windows vsnprintf (Bug#8435).
7955 Include <limits.h>.
7956 (SIZE_MAX): Define if the headers do not.
7957 (verror): Do not give up if vsnprintf returns a negative count.
7958 Instead, grow the buffer. This ports to Windows vsnprintf, which
7959 does not conform to C99. Problem reported by Eli Zaretskii.
7960 Also, simplify the allocation scheme, by avoiding the need for
7961 calling realloc, and removing the ALLOCATED variable.
7962
70476b54
PE
7963 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7964
12020a9e
PE
7965 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7966 But keep the doprint source code for now, as we might revamp it
7967 and use it again (Bug#8435).
ea6c7ae6
PE
7968 * lisp.h (doprnt): Remove.
7969 * Makefile.in (base_obj): Remove doprnt.o.
7970 * deps.mk (doprnt.o): Remove.
7971
5fdb398c
PE
7972 error: Print 32- and 64-bit integers portably (Bug#8435).
7973 Without this change, on typical 64-bit hosts error ("...%d...", N)
7974 was used to print both 32- and 64-bit integers N, which relied on
7975 undefined behavior.
61bdb816 7976 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7977 * lisp.h (error, verror): Mark as printf-like functions.
7978 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7979 Report overflow in size calculations when allocating printf buffer.
7980 Do not truncate output string at its first null byte.
7981 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7982 Truncate the output at a character boundary, since vsnprintf does not
7983 do that.
7984 * charset.c (check_iso_charset_parameter): Convert internal
7985 character to string before calling 'error', since %c now has the
7986 printf meaning.
7987 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7988 overflow when computing char to be passed to 'error'. Do not
7989 pass Lisp_Object to 'error'; pass the integer instead.
7990 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7991 formatted with plain %d.
7992
b189fa66
PE
7993 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7994
bff87ef0
PE
7995 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7996
7e2cac20
PE
7997 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7998
ce4d90b5
PE
7999 * xterm.c (x_catch_errors): Remove duplicate declaration.
8000
266c9547
PE
8001 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8002
79c49ad2
PE
8003 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8004
368f4090
JM
80052011-04-10 Jim Meyering <meyering@redhat.com>
8006
8007 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8008 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8009 return ssize_t not "int", and use size_t as the buffer length.
8010 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8011 * gnutls.h: Update declarations.
8012 * process.c (read_process_output): Use ssize_t, to match.
8013 (send_process): Likewise.
8014
a32d4040
CY
80152011-04-09 Chong Yidong <cyd@stupidchicken.com>
8016
8017 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8018
8546720e 80192011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8020
04f2d78b
CB
8021 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8022 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8023
8546720e
GM
8024 * xterm.c (handle_one_xevent):
8025 * xmenu.c (create_and_show_popup_menu):
8026 * xselect.c (x_decline_selection_request)
8027 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8028
0a2f5c1a 80292011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8030
8031 Fix some uses of `int' instead of EMACS_INT.
8032 * search.c (string_match_1, fast_string_match)
8033 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8034 (scan_buffer, find_next_newline_no_quit)
8035 (find_before_next_newline, search_command, Freplace_match)
8036 (Fmatch_data): Make some `int' variables be EMACS_INT.
8037
8038 * xdisp.c (display_count_lines): 3rd argument and return value now
8039 EMACS_INT. All callers changed.
8040 (pint2hrstr): Last argument is now EMACS_INT.
8041
8042 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8043 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8044 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8045 (decode_coding_utf_16, decode_coding_emacs_mule)
8046 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8047 (decode_coding_ccl, decode_coding_charset)
8048 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8049 (decode_coding_iso_2022, decode_coding_emacs_mule)
8050 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8051 <char_offset, last_offset>: Declare EMACS_INT.
8052 (encode_coding_utf_8, encode_coding_utf_16)
8053 (encode_coding_emacs_mule, encode_invocation_designation)
8054 (encode_designation_at_bol, encode_coding_iso_2022)
8055 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8056 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8057 Declare EMACS_INT.
8058 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8059 (encode_invocation_designation): Last argument P_NCHARS is now
8060 EMACS_INT.
8061 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8062 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8063
8064 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8065 All users changed.
8066
8067 * ccl.c (Fccl_execute_on_string): Declare some variables
8068 EMACS_INT.
8069
8546720e 80702011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8071
8072 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8073
4e19a977
CS
80742011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8075
8076 * process.c (Fformat_network_address): Doc fix.
8077
87302331
R
80782011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8079
ee7683eb 8080 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8081
cbb59342
CY
80822011-04-08 Chong Yidong <cyd@stupidchicken.com>
8083
8084 * keyboard.c (read_char): Call Lisp function help-form-show,
8085 instead of using internal_with_output_to_temp_buffer.
8086 (Qhelp_form_show): New var.
e0d38eeb 8087 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8088
8089 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8090
8091 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8092
e67a13ab
CY
80932011-04-06 Chong Yidong <cyd@stupidchicken.com>
8094
04f2d78b
CB
8095 * process.c (Flist_processes): Remove to Lisp.
8096 (list_processes_1): Delete.
e67a13ab 8097
973f782d
EZ
80982011-04-06 Eli Zaretskii <eliz@gnu.org>
8099
7c106b1e
EZ
8100 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8101
973f782d
EZ
8102 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8103
41cf7d1a 81042011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8105
ca23cc88
PE
8106 Fix more problems found by GCC 4.6.0's static checks.
8107
f390e2d5
PE
8108 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8109
42eea0d0
PE
8110 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8111
b69769da 8112 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8113
f9541e84
PE
8114 * xdisp.c (vmessage): Mark as a printf-like function.
8115
13841b55
PE
8116 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8117
c136c10f
PE
8118 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8119
5e2d4a30
PE
8120 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8121 printf-like functions.
8122 (tiff_load): Add casts to remove these marks before passing them
8123 to system-supplied API.
8124
583f48b9
PE
8125 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8126
b25d760e
PE
8127 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8128 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8129 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8130 directly, rather than having caller test rule sign. This avoids
8131 some unnecessary tests.
8132 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8133 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8134 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8135
bc7b6697 8136 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8137 (xfont_open): Avoid unnecessary tests.
bc7b6697 8138
27ccc379
PE
8139 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8140
dcd5c89a
PE
8141 * composite.h, composite.c (composition_gstring_put_cache):
8142 Use EMACS_INT, not int, for length.
8143
b13a45c6
PE
8144 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8145 breaking out part of COMPOSITION_DECODE_RULE.
8146 (COMPOSITION_DECODE_RULE): Use it.
8147 * composite.c (get_composition_id): Remove unused local vars,
8148 by using the new macro.
8149
1e792e4d
PE
8150 * textprop.c (set_text_properties_1): Change while to do-while,
8151 since the condition is always true at first.
8152
dc6c6455 8153 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8154 (interval_deletion_adjustment): Return unsigned value.
8155 All uses changed.
dc6c6455 8156
aba7731a
PE
8157 * process.c (list_processes_1, create_pty, read_process_output):
8158 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8159 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8160 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8161 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8162 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8163
fdfc4bf3
PE
8164 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8165
fca8fe46 8166 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8167 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8168
06a0259a 8169 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8170 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8171 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8172
e7b9e80f
PE
8173 * print.c (print_error_message): Avoid int overflow.
8174
56201685
PE
8175 * font.c (font_list_entities): Redo for clarity,
8176 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8177
78834453 8178 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8179 (font_score): Avoid potential overflow in diff calculation.
78834453 8180
0bc0b309 8181 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8182 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8183
e610eaca
PE
8184 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8185
b895abce
PE
8186 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8187 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8188 can always succeed if overflow has undefined behavior.
8189
1f1d9321 8190 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8191 (wordify): Omit three unnecessary tests.
1f1d9321 8192
c59478bc
PE
8193 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8194 All callers changed. This avoids the need for an unused var.
8195
79b73827
PE
8196 * casefiddle.c (casify_region): Remove var that is set but not used.
8197
a4db5dfe
PE
8198 * dired.c (file_name_completion): Remove var that is set but not used.
8199
43aae36e
PE
8200 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8201
2a47c44d 8202 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8203 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8204
a37c69bf
PE
8205 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8206 Check for integer overflow on size calculations.
8207
328ab8e7
PE
8208 * buffer.c (Fprevious_overlay_change): Remove var that is set
8209 but not used.
8210
e5a2a5cb
PE
8211 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8212 Remove vars that are set but not used.
8d84a6eb 8213 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8214 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8215
a60e5f68
PE
8216 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8217
f661cb61 8218 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8219 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8220
f0397f5a
PE
8221 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8222 that are set but not used.
8223
8664db06 8224 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8225 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8226
6abdaa4a
PE
8227 * xselect.c (x_get_local_selection, x_handle_property_notify):
8228 Remove vars that are set but not used.
8229
0ce7538d 8230 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8231 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8232
9ae848fc
PE
8233 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8234 Remove var that is set but not used.
0b918413
PE
8235 (scroll_bar_windows_size): Now size_t, not int.
8236 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8237 Check for overflow.
9ae848fc 8238
a5a62657
PE
8239 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8240 (map_tty_color) [!defined MSDOS]: Likewise.
8241
5c5cdd39
PE
8242 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8243
66ebf983
PE
8244 * coding.c: Remove vars that are set but not used.
8245 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8246 All callers changed.
8247 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8248 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8249 (decode_coding_charset): Remove vars that are set but not used.
8250
1be4d761
PE
8251 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8252 that is set but not used.
8253
47553fa8
PE
8254 * print.c (print_object): Remove var that is set but not used.
8255
1f7196bf 8256 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8257 The gnulib version avoids calling malloc in the usual case,
8258 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8259 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8260 * filelock.c (current_lock_owner): Likewise.
8261 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8262 * sysdep.c: Include allocator.h, careadlinkat.h.
8263 (emacs_no_realloc_allocator): New static constant.
8264 (emacs_readlink): New function.
fdb61804
PE
8265 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8266 ../lib/careadlinkat.h.
d1fdcab7 8267
f84c17c7
SM
82682011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8269
8270 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8271 first non-nil return value).
8272
ef3862ad
JD
82732011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8274
8275 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8276 if not defined (Bug#8403).
8277
376a7006
JB
82782011-04-02 Juanma Barranquero <lekktu@gmail.com>
8279
8280 * xdisp.c (display_count_lines): Remove parameter `start',
8281 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8282 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8283 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8284 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8285 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8286 and thereabouts. All callers changed.
8287 (get_per_char_metric): Remove parameter `f', unused since
8288 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8289
6ca3801d
JM
82902011-04-02 Jim Meyering <meyering@redhat.com>
8291
8292 do not dereference NULL upon failed strdup
8293 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8294 (ns_get_family): Likewise.
8295
d8e2b5ba
JB
82962011-04-02 Juanma Barranquero <lekktu@gmail.com>
8297
8298 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8299
8c74fcbd
JD
83002011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8301
8302 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8303 later (Bug#8403).
8304
7200d79c
SM
83052011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8306
03408648 8307 Add lexical binding.
7200d79c 8308
03408648
SM
8309 * window.c (Ftemp_output_buffer_show): New fun.
8310 (Fsave_window_excursion):
8311 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8312
8313 * lread.c (lisp_file_lexically_bound_p): New function.
8314 (Fload): Bind Qlexical_binding.
8315 (readevalloop): Remove `evalfun' arg.
8316 Bind Qinternal_interpreter_environment.
8317 (Feval_buffer): Bind Qlexical_binding.
8318 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8319 Mark as dynamic.
8320 (syms_of_lread): Declare `lexical-binding'.
8321
8322 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8323
8324 * keyboard.c (eval_dyn): New fun.
8325 (menu_item_eval_property): Use it.
ca105506
SM
8326
8327 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8328
03408648
SM
8329 * fns.c (concat, mapcar1): Accept byte-code-functions.
8330
8331 * eval.c (Fsetq): Handle lexical vars.
8332 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8333 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8334 (FletX, Flet): Obey lexical binding.
8335 (Fcommandp): Handle closures.
8336 (Feval): New `lexical' arg.
8337 (eval_sub): New function extracted from Feval. Use it almost
8338 everywhere where Feval was used. Look up vars in lexical env.
8339 Handle closures.
8340 (Ffunctionp): Move from subr.el.
8341 (Ffuncall): Handle closures.
8342 (apply_lambda): Remove `eval_flags'.
8343 (funcall_lambda): Handle closures and new byte-code-functions.
8344 (Fspecial_variable_p): New function.
8345 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8346 but without exporting it to Lisp.
23aba0ea 8347
23aba0ea 8348 * doc.c (Fdocumentation, store_function_docstring):
03408648 8349 * data.c (Finteractive_form): Handle closures.
23aba0ea 8350
03408648
SM
8351 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8352 interactive spec.
ba83908c 8353
04f2d78b
CB
8354 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8355 New byte-codes.
03408648
SM
8356 (exec_byte_code): New function extracted from Fbyte_code to handle new
8357 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8358
03408648 8359 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8360
03408648 8361 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8362
e2abce01
JB
83632011-03-31 Juanma Barranquero <lekktu@gmail.com>
8364
8365 * xdisp.c (redisplay_internal): Fix prototype.
8366
63696a73 83672011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8368
63696a73 8369 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8370 (try_scrolling): Use it when setting scroll_limit.
8371 Limit scrolling to 100 screen lines.
63696a73
EZ
8372 (redisplay_window): Even when falling back on "recentering",
8373 position point in the window according to scroll-conservatively,
8374 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8375
8376 (try_scrolling): When point is above the window, allow searching
8377 as far as scroll_max, or one screenful, to compute vertical
8378 distance from PT to the scroll margin position. This prevents
8379 try_scrolling from unnecessarily failing when
8380 scroll-conservatively is set to a value slightly larger than the
8381 window height. Clean up the case of PT below the margin at bottom
8382 of window: scroll_max can no longer be INT_MAX. When aggressive
8383 scrolling is in use, don't let point enter the opposite scroll
8384 margin as result of the scroll.
8385 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8386 threshold of 100 lines for never-recentering scrolling.
8387
e4cc2dfc
JB
83882011-03-31 Juanma Barranquero <lekktu@gmail.com>
8389
8390 * dispextern.h (move_it_by_lines):
8391 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8392 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8393 (message_log_check_duplicate): Remove parameters `prev_bol' and
8394 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8395 (redisplay_internal): Remove parameter `preserve_echo_area',
8396 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8397
8398 * indent.c (Fvertical_motion):
8399 * window.c (window_scroll_pixel_based, Frecenter):
8400 Don't pass `need_y_p' to `move_it_by_lines'.
8401
1c470562
SM
84022011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8403
44f230aa
SM
8404 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8405 steal a few bits to be more compact.
8406 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8407 Remove unneeded casts.
8408
1c470562
SM
8409 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8410
888adce9
ZK
84112011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8412
8413 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8414 binding" message (bug#7967).
8415
f838ed7b
PE
84162011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8417
77861b95
PE
8418 Fix more problems found by GCC 4.6.0's static checks.
8419
de6dbc14
PE
8420 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8421 Remove unused local var.
8422
f838ed7b
PE
8423 * editfns.c (Fmessage_box): Remove unused local var.
8424
792c7b2b
PE
8425 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8426 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8427 Omit unused local vars.
c499e557 8428 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8429 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8430 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8431 Omit unused local var.
8432
ba0165e1
PE
8433 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8434 Don't assume string length fits in int.
32ad8845 8435 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8436 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8437
3c59b4c9
PE
8438 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8439 instead of alloca (Bug#8344).
8440
a3eed478 8441 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8442 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8443
eb4d412d
PE
8444 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8445
1658b401
PE
8446 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8447 concerns.
8448
8449 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8450
8451 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8452
9a2c6e05
PE
8453 * keyboard.c (syms_of_keyboard): Use the same style as later
8454 in this function when indexing through an array. This also
8455 works around GCC bug 48267.
8456
03d0a109
PE
8457 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8458
44f730c8
PE
8459 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8460
fe75f926
PE
8461 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8462 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8463
ffa8c828
PE
8464 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8465 This avoids undefined behavior on integer overflow, and is a bit
8466 more convenient anyway since it is compared to a size_t variable.
8467
c5101a77
PE
8468 Variadic C functions now count arguments with size_t, not int.
8469 This avoids an unnecessary limitation on 64-bit machines, which
8470 caused (substring ...) to crash on large vectors (Bug#8344).
8471 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8472 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8473 All variadic functions and their callers changed accordingly.
c5101a77
PE
8474 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8475 * data.c (arith_driver, float_arith_driver): Likewise.
8476 * editfns.c (general_insert_function): Likewise.
8477 * eval.c (struct backtrace.nargs, interactive_p)
8478 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8479 (funcall_lambda, mark_backtrace): Likewise.
8480 * fns.c (concat): Likewise.
8481 * frame.c (x_set_frame_parameters): Likewise.
8482 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8483 0 if not found, not -1. All callers changed.
8484
dd3f25f7
PE
8485 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8486 (stack_copy_size): Now size_t, not int.
8487 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8488
461c2ab9
JB
84892011-03-28 Juanma Barranquero <lekktu@gmail.com>
8490
8491 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8492 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8493 All callers changed.
8494
8495 * lisp.h (multibyte_char_to_unibyte):
8496 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8497 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8498 * character.h (CHAR_TO_BYTE8):
8499 * cmds.c (internal_self_insert):
8500 * editfns.c (general_insert_function):
8501 * keymap.c (push_key_description):
8502 * search.c (Freplace_match):
8503 * xdisp.c (message_dolog, set_message_1): All callers changed.
8504
f6d62986
SM
85052011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8506
8507 * keyboard.c (safe_run_hook_funcall): New function.
8508 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8509 don't set the hook to nil, but remove the offending function instead.
8510 (Qcommand_hook_internal): Remove, unused.
8511 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8512 Vcommand_hook_internal.
8513
8514 * eval.c (enum run_hooks_condition): Remove.
8515 (funcall_nil, funcall_not): New functions.
8516 (run_hook_with_args): Call each function through a `funcall' argument.
8517 Remove `cond' argument, now redundant.
8518 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8519 (Frun_hook_with_args_until_failure): Adjust accordingly.
8520 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8521
1db5b1ad
JB
85222011-03-28 Juanma Barranquero <lekktu@gmail.com>
8523
8524 * dispextern.h (string_buffer_position): Remove declaration.
8525
8526 * print.c (strout): Remove parameter `multibyte', unused since
8527 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8528
8529 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8530 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8531 All callers changed.
8532
8533 * w32.c (_wsa_errlist): Use braces for struct initializers.
8534
8535 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8536 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8537 All callers changed.
8538 (string_buffer_position): Likewise. Also, make static (it's never
8539 used outside xdisp.c).
8540 (cursor_row_p): Remove parameter `w', unused since
8541 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8542 (decode_mode_spec): Remove parameter `precision', introduced during
8543 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8544 All callers changed.
8545
5ffb62aa
JD
85462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8547
8548 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8549
461c2ab9 85502011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8551
8552 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8553 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8554 (ns_update_auto_hide_menu_bar): New functions.
8555 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8556 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8557 ns_constrain_all_frames.
8558 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8559 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8560
5c380ffb
JD
85612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8562
8563 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8564
9af30bdf
GM
85652011-03-27 Glenn Morris <rgm@gnu.org>
8566
8567 * syssignal.h: Replace RETSIGTYPE with void.
8568 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8569 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8570 Replace SIGTYPE with void everywhere.
8571 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8572 * s/template.h (SIGTYPE): Remove commented out definition.
8573
e2abce01
JB
85742011-03-26 Eli Zaretskii <eliz@gnu.org>
8575
8576 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8577 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8578
f868cd8a
JB
85792011-03-26 Juanma Barranquero <lekktu@gmail.com>
8580
59eb0929
JB
8581 * w32.c (read_unc_volume): Use parameter `henum', instead of
8582 global variable `wget_enum_handle'.
8583
8584 * keymap.c (describe_vector): Remove parameters `indices' and
8585 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8586 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8587
f868cd8a
JB
8588 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8589
8590 * keyboard.c (timer_check): Remove parameter `do_it_now',
8591 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8592 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8593 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8594
8595 * keyboard.c (read_char):
8596 * w32menu.c (w32_menu_display_help):
8597 * xmenu.c (show_help_event, menu_help_callback):
8598 Adjust calls to `show_help_echo'.
8599
8600 * gtkutil.c (xg_maybe_add_timer):
8601 * keyboard.c (readable_events):
8602 * process.c (wait_reading_process_output):
8603 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8604
8605 * insdel.c (adjust_markers_gap_motion):
8606 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8607 (gap_left, gap_right): Don't call it.
8608
2ecf6fdb
CY
86092011-03-25 Chong Yidong <cyd@stupidchicken.com>
8610
8611 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8612 incurred during fontification.
8613
6b1f9ba4
JB
86142011-03-25 Juanma Barranquero <lekktu@gmail.com>
8615
8616 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8617 (DEFVAR_PER_BUFFER): Don't pass it.
8618
8619 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8620 (scrolling_window): Don't pass it.
8621
0f4a96b5
JB
86222011-03-25 Juanma Barranquero <lekktu@gmail.com>
8623
8624 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8625
8626 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8627 and `suffix'.
8628 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8629 of variables specific to SELinux and computation of `encoded_absname'.
8630
8631 * image.c (XPutPixel): Remove unused variable `height'.
8632
8633 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8634
8635 * unexw32.c (get_section_info): Remove unused variable `section'.
8636
8637 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8638 (system_process_attributes): Remove unused variable `sess'.
8639 (sys_read): Remove unused variable `err'.
8640
8641 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8642 (w32_wnd_proc): Remove unused variable `isdead'.
8643 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8644 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8645 (x_create_tip_frame): Remove unused variable `tem'.
8646
8647 * w32inevt.c (w32_console_read_socket):
8648 Remove unused variable `no_events'.
8649
8650 * w32term.c (x_draw_composite_glyph_string_foreground):
8651 Remove unused variable `width'.
8652
1149507c
JB
86532011-03-24 Juanma Barranquero <lekktu@gmail.com>
8654
8655 * w32term.c (x_set_glyph_string_clipping):
8656 Don't pass uninitialized region to CombineRgn.
8657
9c88f339
JB
86582011-03-23 Juanma Barranquero <lekktu@gmail.com>
8659
8660 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8661 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8662 (Fx_close_connection): Remove unused variable `i'.
8663
8664 * w32font.c (w32font_draw): Return number of glyphs.
8665 (w32font_open_internal): Remove unused variable `i'.
8666 (w32font_driver): Add missing initializer.
8667
8668 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8669 (fill_in_menu): Remove unused variable `items_added'.
8670
8671 * w32term.c (last_mouse_press_frame): Remove static global variable.
8672 (w32_clip_to_row): Remove unused variable `f'.
8673 (x_delete_terminal): Remove unused variable `i'.
8674
8675 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8676 (NOTHING): Remove unused static global variable.
8677 (uniscribe_check_otf): Remove unused variable `table'.
8678 (uniscribe_font_driver): Add missing initializers.
8679
dee091a3
JD
86802011-03-23 Julien Danjou <julien@danjou.info>
8681
8682 * term.c (Fsuspend_tty, Fresume_tty):
8683 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8684 * window.c (temp_output_buffer_show):
8685 * insdel.c (signal_before_change):
8686 * frame.c (Fhandle_switch_frame):
8687 * fileio.c (Fdo_auto_save):
8688 * emacs.c (Fkill_emacs):
8689 * editfns.c (save_excursion_restore):
8690 * cmds.c (internal_self_insert):
8691 * callint.c (Fcall_interactively):
8692 * buffer.c (Fkill_all_local_variables):
8693 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8694 Use Frun_hooks.
0f4a96b5 8695 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8696 unconditionally since it does the check itself.
dee091a3 8697
2c520ab5 86982011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8699
c9c49752
PE
8700 Fix more problems found by GCC 4.5.2's static checks.
8701
8abc3f12
PE
8702 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8703 the first time through the loop, since we know p0 < p1 then.
8704 This also avoids a gcc -Wstrict-overflow warning.
8705
a2d26660
PE
8706 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8707 leading to a memory leak, possible in functions like
8708 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8709 of objects (Bug#8318).
a2d26660 8710
916c72e9
PE
8711 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8712 that could (at least in theory) be that large.
8713
19ab8a18
PE
8714 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8715 This is less likely to overflow, and avoids undefined behavior if
8716 overflow does occur. All callers changed. Use strtoul to scan
8717 for the unsigned long integer.
b7cbbd6f
PE
8718 (pint2hrstr): Simplify and tune code slightly.
8719 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8720
f0641eff
PE
8721 * scroll.c (do_scrolling): Work around GCC bug 48228.
8722 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8723
7f650bb9
PE
8724 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8725 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8726 (validate_x_resource_name): Simplify count usage.
8727 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8728
37dd57d1
PE
8729 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8730 fail (Bug#8306).
81e56e61 8731
699979fc 8732 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8733
401bf9b4
PE
8734 * process.c (Fmake_network_process): Use socklen_t, not int,
8735 where POSIX says socklen_t is required in portable programs.
8736 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8737 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8738 (Fmake_network_process, server_accept_connection):
8739 (wait_reading_process_output, read_process_output):
8740 Likewise.
8741
b93aacde
PE
8742 * process.c: Rename or move locals to avoid shadowing.
8743 (list_processes_1, Fmake_network_process):
8744 (read_process_output_error_handler, exec_sentinel_error_handler):
8745 Rename or move locals.
4dc343ee 8746 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8747 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8748 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8749 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8750 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8751
af8a867c 8752 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8753 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8754 Include tparam.h instead, since it declares them.
af8a867c
PE
8755 * cm.h (PC): Remove extern decl; tparam.h now does this.
8756 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8757 * terminfo.c: Include tparam.h, to check interfaces.
8758 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8759 (tparam): Adjust signature to match interface in tparam.h;
8760 this removes some undefined behavior. Check that outstring and len
8761 are zero, which they always are with Emacs.
8762 * tparam.h (PC, BC, UP): New extern decls.
8763
0248044d 8764 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8765 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8766
8ff096c1 8767 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8768 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8769 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8770 (ftfont_list): Remove unused local.
49eaafba
PE
8771 (get_adstyle_property, ftfont_pattern_entity):
8772 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8773 Rename locals to avoid shadowing.
8ff096c1 8774
e2be39f6
PE
8775 * xfont.c (xfont_list_family): Mark var as initialized.
8776
c9735e30
PE
8777 * xml.c (make_dom): Now static.
8778
8f5201ae
PE
8779 * composite.c (composition_compute_stop_pos): Rename local to
8780 avoid shadowing.
b246f932
PE
8781 (composition_reseat_it): Remove unused locals.
8782 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8783 (composition_update_it): Mark var as initialized.
11b61122
PE
8784 (find_automatic_composition): Mark vars as initialized,
8785 with a FIXME (Bug#8290).
8f5201ae 8786
760fbc2c
PE
8787 character.h: Rename locals to avoid shadowing.
8788 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8789 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8790 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8791 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8792 to avoid shadowing.
8793
ff08eb85
PE
8794 * textprop.c (property_change_between_p): Remove; unused.
8795
fc7bf025
PE
8796 * intervals.c (interval_start_pos): Now static.
8797
235d7abc
PE
8798 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8799
44f230aa
SM
8800 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8801 Rename locals to avoid shadowing.
3e7d6594 8802
50060332
PE
8803 * sound.c (wav_play, au_play, Fplay_sound_internal):
8804 Fix pointer signedness.
d01f234b 8805 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8806 (wav_play): Initialize a variable to 0, to prevent undefined
8807 behavior (Bug#8278).
50060332 8808
c4fc4e30
PE
8809 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8810
918436ed
PE
8811 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8812
c939f91b
PE
8813 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8814 clobbering (Bug#8298).
b9c7f648
PE
8815 * sysdep.c (sys_subshell): Likewise.
8816 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8817
6bd8c144
PE
8818 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8819 This should get cleaned up, so that child_setup has the
8820 same signature on all platforms.
8821
7710357c 8822 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8823 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8824
c59da222
CY
88252011-03-22 Chong Yidong <cyd@stupidchicken.com>
8826
8827 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8828 not to be necessary, and produces flickering.
8829
66b87493
GM
88302011-03-20 Glenn Morris <rgm@gnu.org>
8831
8832 * config.in: Remove file.
8833
45b6f6d5
JB
88342011-03-20 Juanma Barranquero <lekktu@gmail.com>
8835
8836 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8837 are now in src/globals.h.
8838 (syms_of_minibuf): Remove spurious & from previous change.
8839
cd394be1 88402011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8841
8842 * minibuf.c (completing-read-function): New variable.
8843 (completing-read-default): Rename from completing-read.
8844 (completing-read): Call completing-read-function.
8845
b14e3e21
CY
88462011-03-19 Juanma Barranquero <lekktu@gmail.com>
8847
8848 * xfaces.c (Fx_load_color_file):
8849 Read color file from absolute filename (bug#8250).
8850
f2b726e6
JB
88512011-03-19 Juanma Barranquero <lekktu@gmail.com>
8852
8853 * makefile.w32-in: Update dependencies.
8854
09f6ff02
EZ
88552011-03-17 Eli Zaretskii <eliz@gnu.org>
8856
8857 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8858
29a6015a
PE
88592011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8860
a3a6c54e
PE
8861 Fix more problems found by GCC 4.5.2's static checks.
8862
b766f867
PE
8863 * process.c (make_serial_process_unwind, send_process_trap):
8864 (sigchld_handler): Now static.
8865
be02381c
PE
8866 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8867 That way, the code declares only the vars that it needs.
8868 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8869 * s/cygwin.h (PTY_ITERATION): Likewise.
8870 * s/darwin.h (PTY_ITERATION): Likewise.
8871 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8872
57048744
PE
8873 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8874 * process.c (allocate_pty): Don't declare stb unless it's needed.
8875
7914961c 8876 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8877 (CONSTANTLIM): Remove; unused.
8878 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8879 Define only if needed.
7914961c 8880
b3967b18
PE
8881 * unexelf.c (unexec): Name an expression,
8882 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8883 Use a different way to cause a compilation error if anyone uses
8884 n rather than nn, a way that does not involve shadowing.
73366a00 8885 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8886
29a6015a
PE
8887 * deps.mk (unexalpha.o): Remove; unused.
8888
43cfc33e 8889 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8890 * unexec.h: New file.
ce701a33
PE
8891 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8892 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8893 Depend on unexec.h.
8894 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8895 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8896 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8897 Change as necessary to match prototype in unexec.h.
ce701a33 8898
01f44d5a
PE
8899 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8900 shadowing.
4f63c6bb 8901 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8902
a6670b0b
PE
8903 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8904 Rename locals to avoid shadowing.
8905
cef2010d 8906 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8907 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8908
d4d7173a
PE
8909 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8910
f08b802a
PE
8911 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8912 warning when compiling print.c.
8913
3ddb0639
PE
8914 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8915 instead of using an uninitialized var.
5ad03b97 8916 (font_sort_entities): Mark var as initialized.
3ddb0639 8917
170a2692
PE
8918 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8919
e663c700
PE
8920 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8921 pointers to constants.
89bc529a 8922 (font_parse_fcname): Remove unused vars.
7b81e2d0 8923 (font_delete_unmatched): Now static.
ea838e10 8924 (font_get_spec): Remove; unused.
13a547c6
PE
8925 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8926 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8927 Rename or move locals to avoid shadowing.
e663c700 8928
2a80c887 8929 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8930 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8931
1384fa33 8932 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8933 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8934
8b2c52e9
PE
8935 * alloc.c (mark_backtrace): Move decl from here ...
8936 * lisp.h: ... to here, so that it can be checked.
8937
475545b5 8938 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8939 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8940 (lisp_indirect_variable): Name an expression,
8941 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8942 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8943
b1349114 8944 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8945 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8946 Use const pointer when appropriate.
b1349114 8947
a2928364
PE
8948 * lisp.h (get_system_name, get_operating_system_release):
8949 Move decls here, to check interfaces.
8950 * process.c (get_operating_system_release): Move decl to lisp.h.
8951 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8952 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8953 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8954 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8955 (Fformat_time_string, Fencode_time, Finsert_char):
8956 (Ftranslate_region_internal, Fformat):
8957 Rename or remove local vars to avoid shadowing.
9710023e 8958 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8959
a415e694
PE
8960 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8961 avoid shadowing.
8962
8ef4622d
PE
8963 * lisp.h (eassert): Check that the argument compiles, even if
8964 ENABLE_CHECKING is not defined.
8965
946f9a5b
PE
8966 * data.c (Findirect_variable): Name an expression, to avoid
8967 gcc -Wbad-function-cast warning.
112396d6 8968 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8969 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8970 (Fmake_variable_buffer_local, Fmake_local_variable):
8971 Mark variables as initialized.
52746918 8972 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8973
e5aab7e7 8974 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8975 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8976 Rename locals to avoid shadowing.
dff45157
PE
8977 (mark_stack): Move local variables into the #ifdef region where
8978 they're used.
7bc26fdb
PE
8979 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8980 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8981 needed otherwise.
8982 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8983 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8984 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8985
e5aab7e7
PE
8986 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8987 avoids undefined behavior in theory.
8988
4da60324
PE
8989 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8990
88043301
PE
8991 Use functions, not macros, for up- and down-casing (Bug#8254).
8992 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8993 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8994 to use the following functions instead of these macros.
8995 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8996 EMACS_INT, since callers assume the returned value fits in int.
8997 (upcase1): Likewise, for UPCASE_TABLE.
8998 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8999 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9000 the race-condition problem in the old DOWNCASE.
88043301 9001
19ed5445
PE
9002 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9003 Rename locals to avoid shadowing.
9004 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9005 (regex_compile, re_search_2, re_match_2_internal):
9006 Remove unused local vars.
952db0d7
PE
9007 (FREE_VAR): Rewrite so as not to use empty "else",
9008 which gcc can warn about.
da053e48 9009 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9010 (RETALLOC_IF): Define only if needed.
9011 (WORDCHAR_P): Likewise. This one is never needed, but is used
9012 only in a comment talking about a compiler bug, so put inside
9013 the #if 0 of that comment.
9014 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9015 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9016 Remove; unused.
19ed5445 9017
1f3561e4 9018 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9019 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9020 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9021
ded6f8f7
PE
9022 * search.c (simple_search): Remove unused var.
9023
dbd37a95
PE
9024 * dired.c (compile_pattern): Move decl from here ...
9025 * lisp.h: ... to here, so that it can be checked.
9026 (struct re_registers): New forward decl.
9027
7e47afad
PE
9028 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9029
85f24f61
PE
9030 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9031 All uses changed.
9032 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9033 Rename locals to avoid shadowing.
5671df8f 9034 (Fvertical_motion): Mark locals as initialized.
85f24f61 9035
181aa2be 9036 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9037 (casify_region): Mark local as initialized.
181aa2be 9038
930d429c
PE
9039 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9040
7082eac6
PE
9041 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9042 New macros, so that the caller can use some names other than
9043 gcpro1, gcpro2, etc.
9044 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9045 of the new macros.
9046 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9047 argument, for consistency with GCPRO2_VAR, etc: it is now the
9048 prefix of the variable, not the variable itself. All uses
9049 changed.
38b2c076
PE
9050 * dired.c (directory_files_internal, file_name_completion):
9051 Rename locals to avoid shadowing.
9052
15206ed9
PE
9053 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9054 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9055 dired.c's scmp function, had undefined behavior.
9056 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9057 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9058 * buffer.h: ... to here, because these macros use current_buffer,
9059 and the new implementation with inline functions needs to have
9060 current_buffer in scope now, rather than later when the macros
9061 are used.
9062 (downcase, upcase1): New static inline functions.
9063 (DOWNCASE, UPCASE1): Reimplement using these functions.
9064 This avoids undefined behavior in expressions like
9065 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9066 from race conditions in accessing the global variables
9067 case_temp1 and case_temp2.
9068 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9069 * lisp.h (case_temp1, case_temp2): Remove their decls.
9070 * character.h (ASCII_CHAR_P): Move from here ...
9071 * lisp.h: ... to here, so that the inline functions mentioned
9072 above can use them.
9073
4a6bea26
PE
9074 * dired.c (directory_files_internal_unwind): Now static.
9075
f14b7e14
PE
9076 * fileio.c (file_name_as_directory, directory_file_name):
9077 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9078 Now static.
2893f146
PE
9079 (file_name_as_directory): Use const pointers when appropriate.
9080 (Fexpand_file_name): Likewise. In particular, newdir might
9081 point at constant storage, so make it a const pointer.
fd4ead52 9082 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9083 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9084 signedness issues.
f839df0c
PE
9085 (Fset_file_times, Finsert_file_contents, auto_save_error):
9086 Rename locals to avoid shadowing.
f14b7e14 9087
5716756e 9088 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9089 (Ftry_completion, Fall_completions): Rename or remove locals
9090 to avoid shadowing.
5716756e 9091
b4c3046a
PE
9092 * marker.c (bytepos_to_charpos): Remove; unused.
9093
b45db522
PE
9094 * lisp.h (verify_bytepos, count_markers): New decls,
9095 so that gcc does not warn that these functions aren't declared.
9096
85876d07
PE
9097 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9098 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9099 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9100 (copy_text): Remove unused local var.
85876d07 9101
03d78a21 9102 * filelock.c (within_one_second): Now static.
b3dd38ab 9103 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9104
5df8f01b
PE
9105 * buffer.c (fix_overlays_before): Mark locals as initialized.
9106 (fix_start_end_in_overlays): Likewise. This function should be
9107 simplified by using pointers-to-pointers, but that's a different
9108 matter.
b1d876f1 9109 (switch_to_buffer_1): Now static.
8f54f30a
PE
9110 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9111 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9112
a70072c9 9113 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9114 Fix pointer signedness issue.
edced198
PE
9115 (sys_subshell): Mark local as volatile if checking for lint,
9116 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9117 (MAXPATHLEN): Define only if needed.
a70072c9 9118
a0977c44
PE
9119 * process.c (serial_open, serial_configure): Move decls from here ...
9120 * systty.h: ... to here, so that they can be checked.
9121
a884fdcc
PE
9122 * fns.c (get_random, seed_random): Move extern decls from here ...
9123 * lisp.h: ... to here, so that they can be checked.
9124
604efe86 9125 * sysdep.c (reset_io): Now static.
b8950c94 9126 (wait_for_termination_signal): Remove; unused.
604efe86 9127
38fc62d9
PE
9128 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9129 (copy_keymap_item, append_key, push_text_char_description):
9130 Now static.
1004a21a 9131 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9132 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9133 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9134 (describe_map_tree):
9135 Rename locals to avoid shadowing.
38fc62d9 9136
2f2650da
PE
9137 * keyboard.c: Declare functions static if they are not used elsewhere.
9138 (echo_char, echo_dash, cmd_error, top_level_2):
9139 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9140 (read_char, kbd_buffer_get_event, make_lispy_position):
9141 (make_lispy_event, make_lispy_movement, apply_modifiers):
9142 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9143 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9144 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9145 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9146 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9147
a053e86c 9148 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9149 (mark_kboards): Move decl here ...
9150 * alloc.c (mark_kboards): ... from here.
a053e86c 9151
4752793e
PE
9152 * lisp.h (force_auto_save_soon): New decl.
9153
74f10ca7 9154 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9155 (DEFINE_DUMMY_FUNCTION): New macro.
9156 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9157 Use it.
c03cd23f
PE
9158 (main): Add casts to avoid warnings
9159 if GCC considers string literals to be constants.
74f10ca7 9160
022e70d4
PE
9161 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9162
59d6fe83
PE
9163 * dbusbind.c: Pointer signedness fixes.
9164 (xd_signature, xd_append_arg, xd_initialize):
9165 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9166 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9167 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9168 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9169
78320123
PE
9170 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9171 if GCC considers string literals to be constants.
49cebcca 9172 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9173
35ac2a97
SM
91742011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9175
fb103ca9
SM
9176 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9177 (print_preprocess, print_object): New macro to fix last change.
9178
35ac2a97
SM
9179 * print.c (print_preprocess): Don't forget font objects.
9180
62973b41
JB
91812011-03-16 Juanma Barranquero <lekktu@gmail.com>
9182
9183 * emacs.c (USAGE3): Doc fixes.
9184
0e48bb22
AS
91852011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9186
9187 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9188 structure.
9189
7684e57b
JB
91902011-03-14 Juanma Barranquero <lekktu@gmail.com>
9191
9192 * lisp.h (VWindow_system, Qfile_name_history):
9193 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9194 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9195 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9196
9197 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9198 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9199
9200 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9201 * w32console.c (detect_input_pending, read_input_pending)
9202 (encode_terminal_code):
9203 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9204 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9205 (w32_system_caret_y, Qfile_name_history):
9206 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9207 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9208 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9209 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9210 * w32proc.c (Qlocal, report_file_error):
9211 * w32term.c (Vwindow_system, updating_frame):
9212 * w32uniscribe.c (initialized, uniscribe_font_driver):
9213 Remove unneeded extern declarations.
9214
2aa46d6c
CY
92152011-03-14 Chong Yidong <cyd@stupidchicken.com>
9216
c96bbc66 9217 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9218
cffc6f3b
CY
92192011-03-13 Chong Yidong <cyd@stupidchicken.com>
9220
9221 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9222 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9223 These macros can no longer be used for assignment.
9224
44f230aa
SM
9225 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9226 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9227 (record_buffer_markers, fetch_buffer_markers): New functions for
9228 recording and fetching special buffer markers.
9229 (set_buffer_internal_1, set_buffer_temp): Use them.
9230
9231 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9232
9233 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9234
9235 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9236 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9237
9238 * xdisp.c (hscroll_window_tree):
9239 (reconsider_clip_changes): Use PT instead of BUF_PT.
9240
d251f04b
EZ
92412011-03-13 Eli Zaretskii <eliz@gnu.org>
9242
9243 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9244 $(EMACS_ROOT)/lib/intprops.h.
9245
f0c77cd1
PE
92462011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9247
3eca4629
PE
9248 Fix more problems found by GCC 4.5.2's static checks.
9249
7c86ee98
PE
9250 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9251 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9252 (xg_free_frame_widgets): Make it clear that a local variable is
9253 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9254 (gdk_window_get_screen): Make it clear that this macro is needed
9255 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9256 (int_gtk_range_get_value): New function, which avoids a diagnostic
9257 from gcc -Wbad-function-cast.
9258 (xg_set_toolkit_scroll_bar_thumb): Use it.
9259 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9260 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9261 (get_utf8_string, xg_get_file_with_chooser):
9262 Rename locals to avoid shadowing.
9263 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9264
41729b81
PE
9265 * xgselect.c (xg_select): Remove unused var.
9266
f0c77cd1
PE
9267 * image.c (four_corners_best): Mark locals as initialized.
9268 (gif_load): Initialize transparent_p to zero (Bug#8238).
9269 Mark another local as initialized.
ec6cf4c6 9270 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9271
ce0ad53d 9272 * image.c (clear_image_cache): Now static.
d5d5a617 9273 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9274 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9275 (x_edge_detection): Remove unnecessary cast that
9276 gcc -Wbad-function-cast diagnoses.
2037898d 9277 (gif_load): Fix pointer signedness.
6ae141d6
PE
9278 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9279 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9280
33383987 92812011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9282
d32df629
PE
9283 Improve quality of tests for time stamp overflow.
9284 For example, without this patch (encode-time 0 0 0 1 1
9285 1152921504606846976) returns the obviously-bogus value (-948597
9286 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9287 reports time overflow. See
9288 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9289 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9290 * editfns.c: Include limits.h and intprops.h.
9291 (TIME_T_MIN, TIME_T_MAX): New macros.
9292 (time_overflow): Move earlier, to before first use.
9293 (hi_time, lo_time): New functions, for an accurate test for
9294 out-of-range times.
9295 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9296 (Fget_internal_run_time): Don't assume time_t fits in int.
9297 (make_time): Use list2 instead of Fcons twice.
9298 (Fdecode_time): More accurate test for out-of-range times.
9299 (check_tm_member): New function.
9300 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9301 (lisp_time_argument): Don't rely on undefined left-shift and
9302 right-shift behavior when checking for time stamp overflow.
8be6f318 9303
fe31d94c
PE
9304 * editfns.c (time_overflow): New function, refactoring common code.
9305 (Fformat_time_string, Fdecode_time, Fencode_time):
9306 (Fcurrent_time_string): Use it.
9307
8be6f318
PE
9308 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9309 * dired.c (make_time): Move to ...
9310 * editfns.c (make_time): ... here.
9311 * systime.h: Note the move.
9312
09d9db2c 93132011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9314
126bc0dc
YM
9315 * fringe.c (update_window_fringes): Remove unused variables.
9316
c47cbdfd
YM
9317 * unexmacosx.c (copy_data_segment): Also copy __got section.
9318 (Bug#8223)
9319
7ac80be9
EZ
93202011-03-12 Eli Zaretskii <eliz@gnu.org>
9321
c96bbc66 9322 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9323 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9324 Constify `char *' arguments and their references according to
9325 prototypes in tparam.h.
9326
ecb0f94d 9327 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9328
7ac80be9
EZ
9329 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9330 Adapt all references accordingly.
9331
9332 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9333
ef1fd07e
TT
93342011-03-11 Tom Tromey <tromey@redhat.com>
9335
9336 * buffer.c (syms_of_buffer): Remove obsolete comment.
9337
7ef4b50c
EZ
93382011-03-11 Eli Zaretskii <eliz@gnu.org>
9339
9340 * termhooks.h (encode_terminal_code): Declare prototype.
9341
9342 * msdos.c (encode_terminal_code): Don't declare prototype.
9343
9344 * term.c (encode_terminal_code): Now external again, used by
9345 w32console.c and msdos.c.
9346
44f230aa
SM
9347 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9348 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9349
4b1ec863 93502011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9351
1714f52b 9352 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9353
4b1ec863
PE
9354 * fringe.c (update_window_fringes): Mark locals as initialized
9355 (Bug#8227).
9356 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9357
524c7aa6
PE
9358 * alloc.c (mark_fringe_data): Move decl from here ...
9359 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9360 to check its interface.
9361 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9362
a5c0af81 9363 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9364 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9365 (fontset_font): Mark local as initialized.
a9a06e0b 9366 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9367
b4716021
PE
9368 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9369
811e9bac 9370 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9371 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9372 (x_own_selection, Fx_disown_selection_internal): Rename locals
9373 to avoid shadowing.
9374 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9375
7e3ab302
PE
9376 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9377 so that the caller can use some name other than gcpro1.
9378 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9379 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9380 (Fx_backspace_delete_keys_p):
9381 Use them to avoid shadowing, and rename vars to avoid shadowing.
9382 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9383 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9384 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9385 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9386 Remove unused locals.
7e3ab302
PE
9387 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9388 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9389 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9390 macros.
f78faa98 9391
e2b13473
PE
9392 * xterm.h (x_mouse_leave): New decl.
9393
77f23912
PE
9394 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9395 Remove unused functions.
cdf4ba58
PE
9396 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9397 (x_calc_absolute_position): Now static.
7411c686 9398 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9399 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9400 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9401 unless they are used.
38d0b34a
PE
9402 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9403 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9404 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9405 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9406 (x_error_catcher, x_connection_closed, x_error_handler):
9407 (x_error_quitter, xembed_send_message, x_iconify_frame):
9408 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9409 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9410 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9411
44f230aa
SM
9412 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9413 Rename or move locals to avoid shadowing.
6b463e58 9414 (tty_defined_color, merge_face_heights): Now static.
5967d051 9415 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9416 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9417 does not deduce is never used uninitialized.
73719eba
PE
9418 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9419 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9420
426994c3 9421 * terminal.c (store_terminal_param): Now static.
5489860b 9422
032f1620 9423 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9424 (set_frame_menubar): Remove unused local.
d4323972 9425 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9426 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9427 since they might point to immutable storage.
281585b0
PE
9428 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9429 since it's unused otherwise.
032f1620 9430
367c19e5 9431 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9432 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9433 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9434 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9435 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9436 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9437 does not deduce are never used uninitialized.
70739cbe 9438
07b48fa9
PE
9439 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9440
8868a238 9441 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9442 * window.c (window_loop, size_window):
9443 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9444
7e5cf297 9445 * window.c (display_buffer): Now static.
d6550a9f
PE
9446 (size_window): Mark variables that gcc -Wuninitialized
9447 does not deduce are never used uninitialized.
a586633d
PE
9448 * window.h (check_all_windows): New decl, to forestall
9449 gcc -Wmissing-prototypes diagnostic.
5b555da1 9450 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9451
f6095868
PE
9452 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9453 shadowing.
9454 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9455 Include <limits.h>.
9456 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9457 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9458 (load_charset_map): Mark variables that gcc -Wuninitialized
9459 does not deduce are never used uninitialized.
53df7c11 9460 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9461
f38b440c
PE
9462 * coding.c (coding_set_source, coding_set_destination):
9463 Use "else { /* comment */ }" rather than "else /* comment */;"
9464 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9465 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9466 a block, when the outer 'i' will do.
9467 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9468 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9469 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9470 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9471 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9472 Rename locals to avoid shadowing.
9473 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9474 * coding.c (emacs_mule_char, encode_invocation_designation):
9475 Now static, since they're not used elsewhere.
413bb2db 9476 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9477 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9478 (decode_coding_emacs_mule): Mark variables that gcc
9479 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9480 (detect_coding_iso_2022): Initialize a local variable that might
9481 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9482 this initialization is needed. (Bug#8211)
5f58e762
PE
9483 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9484 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9485 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9486 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9487 Remove unused macros.
f38b440c 9488
232b38b9 9489 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9490 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9491 * character.c (string_count_byte8): Likewise.
232b38b9 9492
fb90da1b
PE
9493 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9494 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9495
fb93dbc2
PE
9496 * chartab.c (copy_sub_char_table): Now static, since it's not used
9497 elsewhere.
5c156ace
PE
9498 (sub_char_table_ref_and_range, char_table_ref_and_range):
9499 Rename locals to avoid shadowing.
bbcd0949 9500 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9501
7d3b3862 9502 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9503 (BIDI_BOB): Remove unused macro.
7d3b3862 9504
6be7d3da
PE
9505 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9506 deduce are never used uninitialized.
c2ed9c8b 9507 * term.c (encode_terminal_code): Likewise.
6be7d3da 9508
75f8807f 9509 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9510
50938595
PE
9511 * tparam.h: New file.
9512 * term.c, tparam.h: Include it.
9513 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9514 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9515 Move these decls to tparam.h, and make them agree with what
9516 is actually in tparam.c. The previous trick of using incompatible
9517 decls in different modules does not conform to the C standard.
9518 All callers of tparam changed to use tparam's actual API.
9519 * tparam.c (tparam1, tparam, tgoto):
9520 Use const pointers where appropriate.
9521
fbceeba2
PE
9522 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9523 * cm.h (struct cm): Likewise.
9524 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9525 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9526 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9527 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9528 (turn_on_face, init_tty): Likewise.
9529 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9530
7f3f1250
PE
9531 * term.c (term_mouse_position): Rename local to avoid shadowing.
9532
e6ca6543
PE
9533 * alloc.c (mark_ttys): Move decl from here ...
9534 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9535
c40f8d15
AS
95362011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9537
9538 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9539
cfe0661d
JB
95402011-03-09 Juanma Barranquero <lekktu@gmail.com>
9541
9542 * search.c (compile_pattern_1): Remove argument regp, unused since
9543 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9544 (compile_pattern): Don't pass it.
9545
0afb4571
J
95462011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9547
9548 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9549 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9550 for ! HAVE_GTK3.
9551 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9552
9553 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9554
9555 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9556 gdk_window_get_screen, gdk_window_get_geometry,
9557 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9558 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9559 (xg_get_pixbuf_from_pixmap): New function.
9560 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9561 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9562 Call xg_get_pixbuf_from_pixmap instead of
9563 gdk_pixbuf_get_from_drawable.
9564 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9565 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9566 (xg_check_special_colors): Use GtkStyleContext and its functions
9567 for HAVE_GTK3.
9568 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9569 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9570 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9571 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9572 Call gtk_widget_get_preferred_size.
0afb4571
J
9573 (xg_frame_resized): gdk_window_get_geometry only takes 5
9574 parameters.
44f230aa
SM
9575 (xg_win_to_widget, xg_event_is_for_menubar):
9576 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9577 (xg_set_widget_bg): New function.
9578 (delete_cb): New function.
895009e1 9579 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9580 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9581 (xg_set_background_color): Call xg_set_widget_bg.
9582 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9583 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9584 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9585 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9586 if ! HAVE_GTK3.
9587 (update_frame_tool_bar): Call gtk_widget_hide.
9588 (xg_initialize): Use GDK_KEY_g.
9589
9590 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9591 if ! HAVE_GTK3
9592 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9593
9594 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9595 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9596 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9597
1c2cc4ef
JB
95982011-03-08 Juanma Barranquero <lekktu@gmail.com>
9599
9600 * w32xfns.c (select_palette): Check success of RealizePalette against
9601 GDI_ERROR, not zero.
9602
33383987 9603See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9604
9605;; Local Variables:
9606;; coding: utf-8
aac0c6e3
MR
9607;; End:
9608
acaf905b 9609 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9610
9611 This file is part of GNU Emacs.
9612
9613 GNU Emacs is free software: you can redistribute it and/or modify
9614 it under the terms of the GNU General Public License as published by
9615 the Free Software Foundation, either version 3 of the License, or
9616 (at your option) any later version.
9617
9618 GNU Emacs is distributed in the hope that it will be useful,
9619 but WITHOUT ANY WARRANTY; without even the implied warranty of
9620 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9621 GNU General Public License for more details.
9622
9623 You should have received a copy of the GNU General Public License
9624 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.