Add doc-strings to some cl float parameters.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9c6c6f49
CY
12011-10-27 Chong Yidong <cyd@gnu.org>
2
3 * gnutls.c (emacs_gnutls_deinit): New function. Deallocate
4 credentials structures as well as calling gnutls_deinit.
5 (Fgnutls_deinit, Fgnutls_boot): Use it.
6
7 * process.c (make_process): Initialize GnuTLS credentials to NULL.
8 (deactivate_process): Call emacs_gnutls_deinit.
9
657d08d3
JB
102011-10-27 Juanma Barranquero <lekktu@gmail.com>
11
12 * image.c (x_create_x_image_and_pixmap):
13 * w32.c (sys_rename, w32_delayed_load):
14 * w32font.c (fill_in_logfont):
15 * w32reg.c (x_get_string_resource): Silence compiler warnings.
16
5430d399
JB
172011-10-26 Juanma Barranquero <lekktu@gmail.com>
18
19 * w32fns.c (w32_default_color_map): New function,
20 extracted from Fw32_default_color_map.
a7ef684b 21 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 22
fe0055fa
PE
232011-10-25 Paul Eggert <eggert@cs.ucla.edu>
24
25 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
26
e6346438
SM
272011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
28
29 * keyboard.c (test_undefined): New function (bug#9751).
30 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
31
e112cc37
ET
322011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
33
34 * sysdep.c (init_sys_modes): Fix the check for the controlling
35 terminal (Bug#6649).
36
7b5d6677
EZ
372011-10-20 Eli Zaretskii <eliz@gnu.org>
38
39 * dispextern.h (struct bidi_it): New member next_en_type.
40
41 * bidi.c (bidi_line_init): Initialize the next_en_type member.
42 (bidi_resolve_explicit_1): When next_en_pos is valid for the
43 current character, check also for next_en_type being WEAK_EN.
44 (bidi_resolve_weak): Don't enter the expensive loop if the current
45 position is before next_en_pos. Record the bidi type of the first
46 non-ET, non-BN character we find, in addition to its position.
47 (bidi_level_of_next_char): Invalidate next_en_type when
48 next_en_pos is over-stepped.
49
7da0b018
PE
502011-10-20 Paul Eggert <eggert@cs.ucla.edu>
51
52 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
53 * editfns.c: Rewrite current-time-zone so that it invokes
54 the equivalent of (format-time-string "%Z") to get the time zone name.
55 This fixes a bug when the time zone name contains characters that
56 need converting from the system time locale to Emacs internal format.
57 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
58 that patch fixed format-time-string to do the conversion, but
59 I forgot to fix current-time-zone.
60 (format_time_string): New function, containing most of
61 what Fformat_time_string used to contain.
62 (Fformat_time_string): Rewrite in terms of format_time_string.
63 This doesn't change this function's behavior.
64 (current-time-zone): Rewrite to use format_time_string.
65 This fixes the bug reported by Michael Schierl in
66 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
67 Jason Rumney's 2007-06-07 change worked around this bug, but
68 didn't fix it.
69 * systime.h (tzname, timezone): Remove no-longer-used declarations.
70
8547b010
EZ
712011-10-19 Eli Zaretskii <eliz@gnu.org>
72
73 * xdisp.c (start_display): If the character at POS is displayed
74 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
75 (try_window_reusing_current_matrix): If a line ends in a display
76 vector or the next line starts in a display vector, continue
77 redrawing the window even though the character position of
78 start_row was reached.
8547b010
EZ
79 (Bug#9771, part 2)
80
4e948d15
CY
812011-10-18 Chong Yidong <cyd@gnu.org>
82
83 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
84 with nobreak-char-display too.
85
4787455f
EZ
862011-10-18 Eli Zaretskii <eliz@gnu.org>
87
88 Fix part 3 of bug#9771.
89 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
90 (bidi_resolve_neutral): Don't enter the expensive loop looking for
91 non-neutral characters if the current character is a paragraph
92 separator (a.k.a. Newline). This avoids running the same
93 expensive loop twice, once when we consume the preceding newline
94 and the other time when the line actually needs to be displayed.
95 Avoid the loop when we see neutrals on the base embedding level
96 following a character whose directionality is the same as the
97 paragraph's. This avoids running the expensive loop when a line
98 ends in a long sequence of neutrals, like control characters.
99 Add assertion against STRONG_AL type. Slightly rearrange code
100 that determines the type of a neutral given the first non-neutral
101 that follows it.
102 (bidi_level_of_next_char): Set next_en_pos to zero when
103 invalidating its info.
104
2c91f553
EZ
1052011-10-17 Eli Zaretskii <eliz@gnu.org>
106
107 * xdisp.c (push_display_prop): Determine whether to record string
108 or buffer position by IT->string, not by IT->method. Allow
109 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
110 (move_it_vertically_backward): Don't look for character position
111 immediately after the newline when in a continuation line.
112 (Bug#9771, part 1)
2c91f553 113
c7b08b0d
MR
1142011-10-15 Martin Rudalics <rudalics@gmx.at>
115
116 * window.c (coordinates_in_window): Rewrite and delabelize
117 vertical border check. (Bug#5357) (Bug#9618)
118
6b02f655
SM
1192011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
120
121 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
122 errors in XSetWindowBorder (bug#9310).
123
81d40c92
DA
1242011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
125
126 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
127 avoid crash when xmalloc overrun checking is enabled.
128
d4172c3b
EZ
1292011-10-13 Eli Zaretskii <eliz@gnu.org>
130
131 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
132 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
133 cursor motion with <left> and <right> arrow keys.
134
135 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
136 some callers set that themselves.
137
b00eea75
EZ
1382011-10-12 Eli Zaretskii <eliz@gnu.org>
139
140 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
141 display string and the previous row comes from the same string and
142 is empty. (Bug#9739) (Bug#9738)
143
8fe012c4
SM
1442011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
145
146 * doc.c (get_doc_string): Encode file name (bug#9735).
147
0074aef2
EZ
1482011-10-12 Eli Zaretskii <eliz@gnu.org>
149
79beb178
EZ
150 * bidi.c (bidi_level_of_next_char):
151 * xdisp.c (get_visually_first_element): Remove old incorrect
152 comments regarding the Unicode Line Separator character.
153
0074aef2
EZ
154 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
155
6e4b3fbe
DA
1562011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
157
158 * alloc.c (Fgc_status): Do not access beyond zombies array
159 boundary if nzombies > MAX_ZOMBIES.
160 * alloc.c (dump_zombies): Add missing format specifier.
161
0324f3af
PE
1622011-10-12 Paul Eggert <eggert@cs.ucla.edu>
163
b5525cac
PE
164 * xdisp.c (set_cursor_from_row): Simplify conditionals,
165 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
166
0324f3af
PE
167 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
168 Some packages use them to denote characters with modifiers.
169
e9b5f888
AS
1702011-10-11 Andreas Schwab <schwab@linux-m68k.org>
171
172 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
173 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
174 matching a pp-number. Rename parameter var to var1.
175
127827c0
SM
1762011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
177
178 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
179
c8fd3bd0
GM
1802011-10-08 Glenn Morris <rgm@gnu.org>
181
182 * callint.c (Fcall_interactively): Give a more explicit error for the
183 'c' case with a non-character input. (Bug#8479)
184
352ec8ff
EZ
1852011-10-08 Eli Zaretskii <eliz@gnu.org>
186
03669ccb
EZ
187 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
188 lines.
7061c986
EZ
189 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
190 lines that are hscrolled on the left.
03669ccb 191
352ec8ff
EZ
192 * dispnew.c (buffer_posn_from_coords): Account for a possible
193 presence of header-line. (Bug#4426)
194
a66cfb1c
SM
1952011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
196
6b02f655
SM
197 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
198 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 199
7c5ee88e
PE
2002011-10-07 Paul Eggert <eggert@cs.ucla.edu>
201
202 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
203 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
204 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
205 this makes Emacs dump core during garbage collection on rare
206 occasions. sizeof is obviously inferior to offsetof here, so
207 stick with offsetof.
208 (GC_POINTER_ALIGNMENT): New macro.
209 (mark_memory): Omit 3rd (offset) arg; caller changed.
210 Don't assume EMACS_INT alignment is the same as pointer alignment.
211
df1bbe5b
SM
2122011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
213
214 * keyboard.c (read_key_sequence_remapped): New var.
215 (read_key_sequence): Compute remapping in the right buffer.
216 (command_loop_1): Use read_key_sequence's remapping directly.
217
51553db6
SM
2182011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
219
32c1fffd
SM
220 * dired.c (file_name_completion): Don't expand file name.
221 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
222 before checking file name handler.
223
51553db6
SM
224 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
225 they've been requested explicitly (bug#9591).
226
b6bd1599 2272011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
228
229 * keymap.c (Fsingle_key_description): Use make_specified_string
230 instead of build_string to build string from push_key_description.
231 (Bug#5193)
232
f701dc2a
PE
2332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
234
4222c55d
PE
235 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
236 This fixes a Y2038 bug on 64-bit hosts.
237 * buffer.c (reset_buffer):
238 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
239 (Fclear_buffer_auto_save_failure):
240 Use 0, not -1, to represent an unset failure time, since time_t
241 might not be signed.
242
f701dc2a
PE
243 Remove dependency on glibc malloc internals.
244 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
245 Move back here from lisp.h, but with their new implementations.
246 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
247 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
248 * charset.c (charset_table_init): New static var.
249 (syms_of_charset): Use it instead of xmalloc. This removes a
250 dependency on glibc malloc internals. See Eli Zaretskii's comment in
251 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
252 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
253 Move back to alloc.c.
254 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
255 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
256
9ceebf39
JD
2572011-09-30 Jan Djärv <jan.h.d@swipnet.se>
258
259 * nsterm.m (windowDidResize): Call x_set_window_size only when
260 ns_in_resize is true. Otherwise set pixelwidth/height and
261 call change_frame_size (Bug#9628).
262
cb993c58
PE
2632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
264
3930c88b
PE
265 Port --enable-checking=all to Fedora 14 x86-64.
266 * charset.c (syms_of_charset): Also account for glibc malloc's
267 internal overhead when calculating the initial malloc maximum.
268
cb993c58
PE
269 Port --enable-checking=all to Fedora 14 x86.
270 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
271 Move to lisp.h.
272 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
273 (overrun_check_realloc, overrun_check_free):
274 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
275 That way, xmalloc returns a properly-aligned pointer even if
276 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
277 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
278 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
279 into account when calculating the initial malloc maximum.
280 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
281 Move here from alloc.c, so that charset.c can use it too.
282 Properly align; the old code wasn't right for common 32-bit hosts
283 when configured with --enable-checking=all.
284 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
285 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
286
31bed486
EZ
2872011-09-29 Eli Zaretskii <eliz@gnu.org>
288
04c70788 289 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
290 use EDOM.
291
fbcaa2f3
EZ
2922011-09-28 Eli Zaretskii <eliz@gnu.org>
293
294 * xdisp.c (compute_display_string_end): If there's no display
295 string at CHARPOS, return -1.
296
297 * bidi.c (bidi_fetch_char): When compute_display_string_end
298 returns a negative value, treat the character as a normal
299 character not covered by a display string. (Bug#9624)
300
a239d4e9
JB
3012011-09-28 Juanma Barranquero <lekktu@gmail.com>
302
303 * lread.c (Fread_from_string): Fix typo in docstring.
304
88652fd5
EZ
3052011-09-27 Eli Zaretskii <eliz@gnu.org>
306
307 * xdisp.c (handle_invisible_prop): If invisible text ends on a
308 newline, reseat the iterator instead of bidi-iterating there one
309 character at a time. (Bug#9610)
32c1fffd
SM
310 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
311 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 312
ed497dd4
AS
3132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
314
315 * lread.c (readevalloop): Use correct code for NBSP.
316 (read1): Likewise. (Bug#9608)
317
b2bf61aa
MA
3182011-09-25 Michael Albinus <michael.albinus@gmx.de>
319
320 * dbusbind.c (Fdbus_register_signal): When service is not
321 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
322
32bbb17c
GM
3232011-09-25 Glenn Morris <rgm@gnu.org>
324
325 * buffer.c (truncate-lines): Doc fix.
326
94e0933e
CY
3272011-09-24 Chong Yidong <cyd@stupidchicken.com>
328
329 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
330 (Fset_window_next_buffers): Doc fix.
331
cddde921
GM
3322011-09-24 Glenn Morris <rgm@gnu.org>
333
334 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
335
1260aef1
PE
3362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
337
25b4bfa0
PE
338 Fix minor problems found by static checking.
339 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
340 * indent.c (Fvertical_motion): Fix == vs = typo.
341
e3cbd34b
EZ
3422011-09-24 Eli Zaretskii <eliz@gnu.org>
343
a66cfb1c
SM
344 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
345 Default value is now t. Doc fix.
6bf7006f 346
e3cbd34b 347 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 348 logic when moving up, not only when moving down. Fix the
e3cbd34b 349 confusing name and values of the it_overshoot_expected variable;
32c1fffd 350 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
351
352 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
353 CHARPOS is covered by a display string which includes newlines.
354 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
355 is covered by a display string with embedded newlines.
356
a3de0cbd
MA
3572011-09-24 Michael Albinus <michael.albinus@gmx.de>
358
359 * dbusbind.c (Fdbus_register_signal): Add match rule to
360 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
361 (Fdbus_register_method, Vdbus_registered_objects_table):
362 Fix docstring.
a3de0cbd 363
b260039d
JM
3642011-09-24 Jim Meyering <meyering@redhat.com>
365
32c1fffd 366 do not ignore write error for any output size
b260039d
JM
367 The previous change was incomplete.
368 While it makes emacs --batch detect the vast majority of stdout
369 write failures, errors were still ignored whenever the output size is
370 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
371 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
372 && echo FAIL: ignored write error
373 FAIL: ignored write error
374 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
375 && echo FAIL: ignored write error
376 FAIL: ignored write error
377 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
378
8eca8a7c
AS
3792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
380
381 * emacs.c (Fkill_emacs): In noninteractive mode exit
382 non-successfully if a write error occurred on stdout. (Bug#9574)
383
3341db62
EZ
3842011-09-21 Eli Zaretskii <eliz@gnu.org>
385
386 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
387 the xassert test.
388
389 * dispextern.h (struct it): Update the comment documenting what
390 can it->OBJECT be.
391
8c203dbf
EZ
3922011-09-20 Eli Zaretskii <eliz@gnu.org>
393
394 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
395 a display string, extend search for cursor position to end of row.
396 (find_row_edges): If the row ends in a newline from a display
397 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
398 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
399 (Fcurrent_bidi_paragraph_direction): Fix search for previous
400 non-empty line. Fixes confusing cursor motion with arrow keys at
401 the beginning of a line that starts with whitespace.
8c203dbf 402
a4824228
LMI
4032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
404
405 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
406 (bug#9493).
407
33ed493b
CY
4082011-09-18 Chong Yidong <cyd@stupidchicken.com>
409
410 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
411 boolean (Bug#9154).
412
56cd55c8
EZ
4132011-09-18 Eli Zaretskii <eliz@gnu.org>
414
415 * xdisp.c (display_line): Record maximum and minimum buffer
416 positions even if no glyphs were produced (e.g., by a zero-width
417 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
418 buffer positions that will be removed from the glyph row because
419 they don't fit.
c02dcedf
EZ
420 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
421 column is beyond frame width: don't subtract 1 "pixel" when
422 computing width of the stretch.
3e62b7e0
EZ
423 (reseat_at_next_visible_line_start): Undo the change made on
424 2011-09-17 that saved paragraph information and restored it after
425 the call to `reseat'. (Bug#9545)
56cd55c8 426
5ed99d36 4272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
428
429 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
430 and turn window cursor on if cleared (Bug#9415).
431
5ed99d36 4322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
433
434 * search.c (boyer_moore): Take unibyte characters from pattern
435 literally. (Bug#9458)
436
9bade7b2
EZ
4372011-09-18 Eli Zaretskii <eliz@gnu.org>
438
439 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
440
e5e9d610
PE
4412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
442
87e4427a
PE
443 Fix minor problem found by static checking.
444 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
445 initialized, to pacify gcc -Wuninitialized.
446
e5e9d610
PE
447 * fileio.c: Report proper errno when syscall falls.
448 (Finsert_file_contents): Save and restore errno,
449 so that report_file_error outputs the correct diagnostic.
450 (Fwrite_region) [CLASH_DETECTION]: Likewise.
451
a1674f0b
EZ
4522011-09-18 Eli Zaretskii <eliz@gnu.org>
453
454 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
455
fbfb6dd4
EZ
4562011-09-17 Eli Zaretskii <eliz@gnu.org>
457
458 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
459 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
460
bb187662
EZ
4612011-09-17 Eli Zaretskii <eliz@gnu.org>
462
1137e8b8 463 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 464 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
465
466 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
467 (bidi_find_paragraph_start): Search back for paragraph beginning
468 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
469 (bidi_move_to_visually_next): Only trigger paragraph-related
470 computations when the last character is a newline or at EOB, not
471 just any NEUTRAL_B. (Bug#9470)
472
bb187662
EZ
473 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
474 truncated lines if point is covered by a display string. (Bug#9524)
475
2e621251
PE
4762011-09-16 Paul Eggert <eggert@cs.ucla.edu>
477
478 * xselect.c: Relax test for outgoing X longs (Bug#9498).
479 (cons_to_x_long): New function.
480 (lisp_data_to_selection_data): Use it. Correct the test for
481 short-versus-long data; it was negated. Break out of vector
482 loop, for efficiency, when a long datum is discovered.
483
91a15bc6
SM
4842011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
485
486 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
487
b41c3a35
EZ
4882011-09-16 Eli Zaretskii <eliz@gnu.org>
489
490 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
491 GCC PR/17406) by declaring this function with external scope.
492
7812ba2d
PE
4932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
494
495 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
496 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
497
cf7edc2a
AS
4982011-09-15 Andreas Schwab <schwab@linux-m68k.org>
499
500 * editfns.c (Fformat): Correctly handle text properties on "%%".
501
bd01620e
EZ
5022011-09-15 Eli Zaretskii <eliz@gnu.org>
503
504 * xterm.c (x_draw_composite_glyph_string_foreground):
505 * w32term.c (x_draw_composite_glyph_string_foreground):
506 * term.c (encode_terminal_code):
507 * composite.c (composition_update_it, get_composition_id):
508 * xdisp.c (get_next_display_element)
509 (fill_composite_glyph_string): Add comments about special meaning
510 of TAB characters in a composition.
511
a02719a3
PE
5122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
513
514 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
515 This occurs when processing a multibyte format.
516 Problem reported by Wolfgang Jenker.
a02719a3 517
72589a3c
JB
5182011-09-15 Johan Bockgård <bojohan@gnu.org>
519
520 * xdisp.c (try_cursor_movement): Only check for exact match if
521 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
522
1c14176c
PE
5232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
524
525 Remove unused external symbols.
526 * dispextern.h (calc_pixel_width_or_height): Remove decl.
527 * xdisp.c (calc_pixel_width_or_height): Now static.
528 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
529 * indent.c (check_display_width):
530 * w32term.c: Fix comment to match code.
531 * xterm.c, xterm.h (x_catching_errors): Remove.
532
d2eea5b5
PE
5332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
534
535 * xselect.c: Use signed conversions more consistently (Bug#9498).
536 (selection_data_to_lisp_data): Assume incoming selection data are
537 signed integers, not unsigned. This is to be consistent with
538 outgoing selection data, which was modified to use signed integers
539 in as part of the fix to Bug#9196 in response to Jan D.'s comment
540 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
541 expects long, not unsigned long.
542
46888499
EZ
5432011-09-14 Eli Zaretskii <eliz@gnu.org>
544
545 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
546 computation of loop end. Reported by Johan Bockgård
547 <bojohan@gnu.org>.
548
ef8ef9fb
CY
5492011-09-13 Chong Yidong <cyd@stupidchicken.com>
550
551 * frame.c (Fother_visible_frames_p): Function deleted.
552
fa819fed
EZ
5532011-09-12 Eli Zaretskii <eliz@gnu.org>
554
555 * indent.c (compute_motion): Process display vector front to back
556 rather than the other way around. (Bug#2496)
557
2ba8e008
SM
5582011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
559
560 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
561
20f53c69
CY
5622011-09-11 Chong Yidong <cyd@stupidchicken.com>
563
564 * minibuf.c (Fread_from_minibuffer): Doc fix.
565
d562d7a4
EZ
5662011-09-11 Eli Zaretskii <eliz@gnu.org>
567
568 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
569 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
570
1c4d7f3d
LMI
5712011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
572
573 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
574 value for non-existent files.
575
b885bf36
EZ
5762011-09-11 Eli Zaretskii <eliz@gnu.org>
577
578 * fileio.c (Finsert_file_contents): If the file cannot be opened,
579 set its "size" to -1. This will set the modtime_size field of
580 the corresponding buffer to -1, which is what
581 verify-visited-file-modtime expects for files that do not exist.
582 (Bug#9139)
583
6612f0bf
PE
5842011-09-11 Paul Eggert <eggert@cs.ucla.edu>
585
586 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
587 here ...
588 * lisp.h: ... from here. push_key_description is no longer
589 defined in keyboard.c, so its declaration should not be in
590 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
591 logically belongs with push_key_description.
592
dfb3f755
PE
5932011-09-10 Paul Eggert <eggert@cs.ucla.edu>
594
595 * buffer.h: Include <sys/types.h> instead of <time.h>.
596 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
597 Problem reported by Herbert J. Skuhra.
598
3134906c
LMI
5992011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
600
601 * xml.c (parse_region): Make the parsing work for
602 non-comment-starting XML files again (bug#9144).
603
8d903f4e
AS
6042011-09-10 Andreas Schwab <schwab@linux-m68k.org>
605
606 * image.c (gif_load): Fix calculation of bottom and right corner.
607 (Bug#9468)
608
80ad64f4
EZ
6092011-09-10 Eli Zaretskii <eliz@gnu.org>
610
611 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
612 redisplay in small windows.
613
208a048d
EZ
6142011-09-09 Eli Zaretskii <eliz@gnu.org>
615
616 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
617
9b1c252e
MR
6182011-09-08 Martin Rudalics <rudalics@gmx.at>
619
620 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
621 Operate on live windows only.
622
2949f33b
JB
6232011-09-08 Juanma Barranquero <lekktu@gmail.com>
624
625 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
626
e08dcafd
EZ
6272011-09-07 Eli Zaretskii <eliz@gnu.org>
628
629 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
630 only under bidi iteration.
631
115b96bd
JD
6322011-09-07 Jan Djärv <jan.h.d@swipnet.se>
633
634 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
635
c8199d0f
PE
6362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
637
638 isnan: Fix porting problem to Solaris 10 with bundled gcc.
639 Without this fix, the command to link temacs failed due to an
640 undefined symbol __builtin_isnan. This is because
641 /usr/include/iso/math_c99.h #defines isnan(x) to
642 __builtin_isnan(x), but the bundled gcc, which identifies itself
643 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
644 a __builtin_isnan.
645 * floatfns.c (isnan): #undef, and then #define to a clone of
646 what's in data.c.
647 (Fisnan): Always define, since it's always available now.
648 (syms_of_floatfns): Always define isnan at the Lisp level.
649
e39b275c 6502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
651
652 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
653
b2db44d9 6542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 655
f4af5137 656 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
657 The previous code assumed that file offsets (off_t values) fit in
658 EMACS_INT variables, which is not true on typical 32-bit hosts.
659 The code messed up by falsely reporting buffer overflow in cases
660 such as (insert-file-contents "big" nil 1 2) into an empty buffer
661 when "big" contains more than 2**29 bytes, even though this
662 inserts just one byte and does not overflow the buffer.
663 (Finsert_file_contents): Store file offsets as off_t
664 values, not as EMACS_INT values. Check for overflow when
665 converting between EMACS_INT and off_t. When checking for
666 buffer overflow or for overlap, take the offsets into account.
667 Don't use EMACS_INT for small values where int suffices.
668 When checking for overlap, fix a typo: ZV was used where
669 ZV_BYTE was intended.
670 (Fwrite_region): Don't assume off_t fits into 'long'.
671 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
672
ecfc0a49
MA
6732011-09-05 Michael Albinus <michael.albinus@gmx.de>
674
675 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
676
6511acf2 6772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 678
0999621a 679 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
680
681 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 682 (esprintf, exprintf, evxprintf): New functions.
62f19c19 683 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 684 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
685 (modify_event_symbol): Do not assume that the length of
686 name_alist_or_stem is safe to alloca and fits in int.
687 (Fexecute_extended_command): Likewise for function name and binding.
688 (Frecursion_depth): Wrap around reliably on integer overflow.
689 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
690 since some callers pass EMACS_INT values.
691 (Fsingle_key_description): Don't crash if symbol name contains more
692 than MAX_ALLOCA bytes.
693 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
694 (get_minibuffer): Arg is now EMACS_INT, not int.
695 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 696 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
697 * window.h (command_loop_level, minibuf_level): Reflect API changes.
698
2be7d702
PE
699 * dbusbind.c (signature_cat): New function.
700 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
701 Do not overrun buffer; instead, report string overflow.
702
9d1df220
PE
703 * dispnew.c (add_window_display_history): Don't overrun buffer.
704 Truncate instead; this is OK since it's just a log.
705
33ef5c64
PE
706 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
707 even if the time zone offset is outlandishly large.
708 Don't mishandle offset == INT_MIN.
709
66c6fdd5
PE
710 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
711 when creating daemon; the previous buffer-overflow check was incorrect.
712
d749b01b
PE
713 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
714 which has the guts of the old verror function.
715
b5cd1905
PE
716 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
717 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
718
6e1a67fb
PE
719 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
720 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 721 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 722 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
723 length of string rather than counting it via multiple sprintfs;
724 that's simpler and more reliable.
c21721cc
PE
725 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
726 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
727 sprintf, in case result does not fit in int.
728
c57b67fc
PE
729 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
730 (fontset_from_font): Print it.
731
8a401434
PE
732 * frame.c (tty_frame_count): Now printmax_t, not int.
733 (make_terminal_frame, set_term_frame_name): Print it.
734 (x_report_frame_params): In X, window IDs are unsigned long,
735 not signed long, so print them as unsigned.
736 (validate_x_resource_name): Check for implausibly long names,
737 and don't assume name length fits in 'int'.
738 (x_get_resource_string): Don't blindly alloca invocation name;
739 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
740 not fit in int.
741
6e1a67fb
PE
742 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
743 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
744 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
745
0df02bf3
PE
746 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
747 Use esprintf, not sprintf, in case result does not fit in int.
748
48e30793
PE
749 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
750 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
751 it as a large positive number.
752 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
753 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
754
a66ff6d8
PE
755 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
756 in case result does not fit in int.
757
aca216ff
PE
758 * print.c (float_to_string): Detect width overflow more reliably.
759 (print_object): Make sprintf buffer a bit bigger, to avoid potential
760 buffer overrun. Don't assume list length fits in 'int'. Treat
761 print length of 0 as 0, not as infinity; to be consistent with other
762 uses of print length in this function. Don't overflow print length
763 index. Don't assume hash table size fits in 'long', or that
764 vectorlike size fits in 'unsigned long'.
765
31c286f7
PE
766 * process.c (make_process): Use printmax_t, not int, to format
767 process-name gensyms.
768
55e5faa1
PE
769 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
770
80f2e268
PE
771 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
772 to avoid potential buffer overrun.
773
670741ab
PE
774 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
775 if X resource line is longer than 512 bytes.
776
b7163a50
PE
777 * xfns.c (x_window): Make sprintf buffer a bit bigger
778 to avoid potential buffer overrun.
779
ae58ff1f
PE
780 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
781
c43c8a6a
PE
782 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
783
3f8236f4
PE
7842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
785
53e9fe90 786 Integer overflow fixes for scrolling, etc.
6511acf2
PE
787 Without these, Emacs silently mishandles large integers sometimes.
788 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
789 it were "C-u 1 M-x recenter" on a typical 64-bit host.
790
6511acf2
PE
791 * xdisp.c (try_window_id): Check Emacs fixnum range before
792 converting to 'int'.
806add1d 793
6511acf2 794 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
795 Check that an Emacs fixnum is in range before assigning it to 'int'.
796 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
797 values converted from Emacs fixnums.
798 (Frecenter): Don't wrap around a line count if it is out of 'int'
799 range; instead, treat it as an extreme value.
800 (Fset_window_configuration, compare_window_configurations):
801 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
802
6511acf2
PE
803 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
804 that can exceed INT_MAX. Check that EMACS_INT value is in range
805 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
806 (match_limit): Don't assume that a fixnum can fit in 'int'.
807
6511acf2 808 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
809 exceed INT_MAX.
810
6511acf2 811 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
812 (Fvertical_motion): Don't wrap around LINES values that don't fit
813 in 'int'. Instead, treat them as extreme values. This is good
814 enough for windows, which can't have more than INT_MAX lines anyway.
815
fcb901a7
LMI
8162011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
817
0f2f6b6d
LMI
818 * Require libxml/parser.h to avoid compilation warning.
819
fcb901a7
LMI
820 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
821
822 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
823 since this reportedly can destroy thread storage.
824
6e20a0d4
CY
8252011-08-30 Chong Yidong <cyd@stupidchicken.com>
826
827 * syntax.c (find_defun_start): Update all cache variables if
828 exiting early (Bug#9401).
829
148ae00e
EZ
8302011-08-30 Eli Zaretskii <eliz@gnu.org>
831
f6cfbd8f
EZ
832 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
833
148ae00e
EZ
834 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
835 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
836 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
837
838 * term.c (tty_append_glyph): New function.
839 (produce_stretch_glyph): Static function and its prototype deleted.
840
a66cfb1c
SM
841 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
842 Add prototypes.
148ae00e 843
c4a07a4c
PE
8442011-08-29 Paul Eggert <eggert@cs.ucla.edu>
845
846 * image.c (parse_image_spec): Check for nonnegative, not for positive,
847 when checking :margin (Bug#9390).
848 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 849 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
850 so that the name doesn't mislead. All uses changed.
851
6bc8cd65
JB
8522011-08-28 Johan Bockgård <bojohan@gnu.org>
853
854 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
855 set_tty_hooks.
856
dca4927e
EZ
8572011-08-27 Eli Zaretskii <eliz@gnu.org>
858
859 * xdisp.c (move_it_to): Don't bail out early when reaching
860 position beyond to_charpos, if we are scanning backwards.
861 (move_it_vertically_backward): When DY == 0, make sure we get to
862 the first character in the line after the newline.
863
f2cad773
PE
8642011-08-27 Paul Eggert <eggert@cs.ucla.edu>
865
866 * ccl.c: Improve and simplify overflow checking (Bug#9196).
867 (ccl_driver): Do not generate an out-of-range pointer.
868 (Fccl_execute_on_string): Remove unnecessary check for
869 integer overflow, noted by Stefan Monnier in
870 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
871 Remove a FIXME that didn't need fixing.
872 Simplify the newly-introduced buffer reallocation code.
873
0cae2cdb
JB
8742011-08-27 Juanma Barranquero <lekktu@gmail.com>
875
876 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
877
5fc295a4 8782011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 879
70c60eb2 880 Integer and memory overflow issues (Bug#9196).
726e0ab1 881
d31850da
PE
882 * doc.c (get_doc_string): Rework so that
883 get_doc_string_buffer_size is the actual buffer size, rather than
884 being 1 less than the actual buffer size; this makes xpalloc more
885 convenient.
886
a69fbedb
PE
887 * image.c (x_allocate_bitmap_record, cache_image):
888 * xselect.c (Fx_register_dnd_atom):
889 Simplify previous changes by using xpalloc.
890
fe5c5d37
PE
891 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
892 since either will do and ptrdiff_t is convenient with xpalloc.
893
0065d054
PE
894 * charset.c (charset_table_size)
895 (struct charset_sort_data.priority): Now ptrdiff_t.
896 (charset_compare): Don't overflow if priorities differ greatly.
897 (Fsort_charsets): Don't assume list length fits in int.
898 Check for size-calculation overflow when allocating sort data.
899 (syms_of_charset): Allocate an initial charset table that is
900 just under 64 KiB, to avoid problems with glibc malloc and mmap.
901
902 * cmds.c (internal_self_insert): Check for size-calculation overflow.
903
904 * composite.h (struct composition.glyph_len): Now int, not unsigned.
905 The actual value is always <= INT_MAX, and leaving it unsigned made
906 overflow checking harder.
907
908 * dispextern.h (struct glyph_matrix.rows_allocated)
909 (struct face_cache.size): Now ptrdiff_t, for convenience in use
910 with xpalloc. The values are still always <= INT_MAX.
911
912 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
913
914 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
915 (SAFE_NALLOCA): New macro.
916
917 * region-cache.c (struct boundary.pos, find_cache_boundary)
918 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
919 (set_cache_region, invalidate_region_cache)
920 (revalidate_region_cache, know_region_cache, region_cache_forward)
921 (region_cache_backward, pp_cache):
922 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
923 so that ptrdiff_t * can be passed to xpalloc.
924 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
925 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
926 (pp_cache): Don't assume cache_len fits in int.
927 * region-cache.h: Adjust extern decls to match.
928
929 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
930 EMACS_INT, since either will do, for xpalloc.
931
932 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
933 (xnmalloc, xnrealloc, xpalloc): New functions.
934
726e0ab1
PE
935 * bidi.c (bidi_shelve_header_size): New constant.
936 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
937 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
938
51f30bc5 939 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
940 * buffer.c (overlays_at, overlays_in, record_overlay_string)
941 (overlay_strings):
942 Don't update size of array until after memory allocation succeeds,
943 because xmalloc/xrealloc may not return.
0065d054
PE
944 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
945 now that we have proper integer overflow checking.
946 (record_overlay_string, overlay_strings): Catch overflows when
947 calculating size of overlay_str_buf.
726e0ab1 948
0065d054
PE
949 * callproc.c (Fcall_process): Check for size overflow when
950 calculating size of args2.
951 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
952 Normally we prefer signed values, but sticking with ptrdiff_t would
953 require adding more-complicated checks.
726e0ab1
PE
954
955 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
956 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
957 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 958 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
959
960 * character.c (Fstring): Check for size-calculation overflow.
961
962 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
963 unnecessary integer overflow. Check for size overflow.
964 (encode_coding_object): Don't update size until xmalloc succeeds.
965
966 * composite.c (get_composition_id): Check for overflow in glyph
967 length calculations.
968
969 Integer and memory overflow fixes for display code.
970 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
971 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
972 (scrolling_window): Check for overflow in size calculations.
973 (line_draw_cost, realloc_glyph_pool, add_row_entry):
974 Don't assume glyph table len fits in int.
975 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
976 (row_table_size): Now ptrdiff_t, not int.
977 (scrolling_window): Avoid overflow in size calculations.
978 Don't update size until allocation succeeds.
979 * fns.c (concat): Check for overflow in size calculations.
980 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
981 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
982 (NEXT_ALMOST_PRIME_LIMIT): New constant.
983
984 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
985 (get_doc_string): Check for size calculation overflow.
986 Don't update size until allocation succeeds.
987 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
988 EMACS_INT, where ptrdiff_t will do.
989 (Fsubstitute_command_keys): Check for string overflow.
990
991 * editfns.c (set_time_zone_rule): Don't assume environment length
992 fits in int.
993 (message_length): Now ptrdiff_t, not int.
994 (Fmessage_box): Don't update size until allocation succeeds.
995 Don't assume message length fits in int.
996 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
997
0065d054
PE
998 * emacs.c (main): Do not reallocate argv, since there is a null at
999 the end that can be overwritten, and this way there's no need to
1000 worry about size-calculation overflow.
1001 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1002
1003 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1004 alloc succeeds.
1005 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1006
1007 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1008 (x_set_scroll_bar_width, x_figure_window_size):
1009 Check for integer overflow.
1010 (x_set_alpha): Do not assume XINT fits in int.
1011
1012 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1013 This is for the members text_lines, text_cols, total_lines, total_cols,
1014 where the system imposes an 'int' limit.
1015
1016 * fringe.c (Fdefine_fringe_bitmap):
1017 Don't update size until alloc works.
1018
1019 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1020 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1021
1022 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1023 Check for size-calculation overflow.
1024 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1025 do, as we prefer signed integers.
1026 (id_to_widget.max_size, id_to_widget.used)
1027 (xg_store_widget_in_map, xg_remove_widget_from_map)
1028 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1029 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1030 Use and return ptrdiff_t, not int.
1031 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1032 * gtkutil.h: Change prototypes to match the above.
1033
1034 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1035 are duplicate now that they've been promoted to lisp.h.
1036 (x_allocate_bitmap_record, x_alloc_image_color)
1037 (make_image_cache, cache_image, xpm_load):
1038 Don't update size until alloc is done.
1039 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1040 (x_detect_edges):
3256efce 1041 Check for size calculation overflow.
726e0ab1
PE
1042 (ct_colors_allocated_max): New constant.
1043 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1044 overflow.
3256efce 1045
726e0ab1
PE
1046 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1047 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1048 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1049 Use ptrdiff_t, not int, to count maps.
1050 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1051 calculations. Don't update size until allocation succeeds.
1052 Redo calculations to avoid overflow.
726e0ab1
PE
1053 * keyboard.h: Change prototypes to match the above.
1054
1055 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1056 to count maps.
1057 (current_minor_maps): Check for size calculation overflow.
1058 * keymap.h: Change prototypes to match the above.
1059
1060 * lread.c (read1, init_obarray): Don't update size until alloc done.
1061
1062 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1063 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1064
726e0ab1
PE
1065 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1066 Now ptrdiff_t, not int.
1067 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1068 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1069
1070 * process.c (Fnetwork_interface_list): Check for overflow
1071 in size calculation.
1072
1073 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1074
1075 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1076 overflow. Don't bother calling xmalloc when xrealloc will do.
1077
1078 * search.c (Freplace_match): Check for size calculation overflow.
1079 (Fset_match_data): Don't assume list lengths fit in 'int'.
1080
1081 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1082 for command line length. Do not attempt to address one before the
1083 beginning of an array, as that's not portable.
1084
1085 * term.c (max_frame_lines): Remove; unused.
1086 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1087 not int.
1088 (encode_terminal_code, calculate_costs): Check for size
1089 calculation overflow.
1090 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1091 table lengths and related sizes. Don't update size until alloc
1092 done. Redo calculations to avoid overflow.
1093 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1094
1095 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1096 subtracting pointers.
1097 (gobble_line): Check for overflow more carefully. Don't update size
1098 until alloc done.
1099
1100 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1101 Don't update size until alloc done.
1102 Redo size calculations to avoid overflow.
1103 Check for size calculation overflow.
0065d054 1104 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1105
1106 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1107 Use ptrdiff_t, not int, for sizes.
1108 (store_mode_line_noprop_char): Don't update size until alloc done.
1109
0065d054
PE
1110 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1111 Use ptrdiff_t, not int, for sizes.
1112 (Finternal_make_lisp_face, cache_face):
1113 Check for size calculation overflow.
1114 (cache_face): Treat size calculation overflows as if they were
1115 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1116
1117 * xfns.c (x_encode_text, x_set_name_internal)
1118 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1119 sizes, since they can exceed INT_MAX in size. Check for size
1120 calculation overflow.
1121
0065d054
PE
1122 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1123 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1124 Don't update size until alloc done.
1125
0065d054 1126 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1127 as sprintf is limited to int lengths.
1d526e2f 1128
252c5ee1
PE
1129 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1130 (X_LONG_MIN): New macros.
864d7ce7
PE
1131 Use them to make the following changes clearer.
1132 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1133 This change doesn't affect the value now, but it may help remind
1134 future maintainers not to raise the value too much later.
1135 (SELECTION_QUANTUM): Remove, replacing with ...
1136 (selection_quantum): ... new function, which avoids overflow.
1137 All uses changed.
1138 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1139 assumption that selection length fits in 'int'.
1140 (x_reply_selection_request, x_handle_selection_request)
1141 (x_get_window_property, receive_incremental_selection)
1142 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1143 (lisp_data_to_selection_data, clean_local_selection_data):
1144 Use ptrdiff_t, not int, to record length of selection.
1145 (x_reply_selection_request, x_get_window_property)
1146 (receive_incremental_selection, x_property_data_to_lisp):
1147 Redo calculations to avoid overflow.
1148 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1149 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1150 something.
1151 (x_get_window_property, receive_incremental_selection)
1152 (lisp_data_to_selection_data, x_property_data_to_lisp):
1153 Check for size-calculation overflow.
1154 (x_get_window_property, receive_incremental_selection)
1155 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1156 Don't store size until memory allocation succeeds.
1157 (x_get_window_property): Plug memory leak on memory exhaustion.
1158 Don't double-block input; malloc is safe here. Don't assume 2**34
1159 - 4 fits in unsigned long. Add an xassert to check
1160 XGetWindowProperty overflow. Be more careful about overflow
1161 calculations, and distinguish size from memory overflow better.
1162 (receive_incremental_selection): When tracing, don't assume
1163 unsigned int is less than INT_MAX.
1164 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1165 harmful) conversions of unsigned short to int.
1166 (lisp_data_to_selection_data): Don't assume that integers
1167 in the range -65535 through -1 fit in an X unsigned short.
1168 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1169 result parameters unless successful. Rely on cons_to_unsigned
1170 to report problems with elements; the old code wasn't right anyway.
1171 (x_check_property_data): Check for int overflow; we cannot use
1172 a wider type due to X limits.
1173 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1174
726e0ab1 1175 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1176
0065d054
PE
1177 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1178 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1179 (x_color_cells): Don't store size until memory allocation succeeds.
1180 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1181 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1182 (x_term_init): Don't assume length fits in int (sprintf is limited
1183 to int size).
bc18e09d 1184
ebfa62c0
PE
1185 Use ptrdiff_t for composition IDs.
1186 * character.c (lisp_string_width):
1187 * composite.c (composition_table_size, n_compositions)
1188 (get_composition_id, composition_gstring_from_id):
1189 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1190 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1191 * window.c (Frecenter):
1192 Use ptrdiff_t, not int, for composition IDs.
1193 * composite.c (get_composition_id): Check for integer overflow.
1194 * composite.h: Adjust prototypes to match the above changes.
1195
d3411f89
PE
1196 Use ptrdiff_t for hash table indexes.
1197 * category.c (hash_get_category_set):
1198 * ccl.c (ccl_driver):
1199 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1200 * coding.c (coding_system_charset_list, detect_coding_system):
1201 * coding.h (struct coding_system.id):
1202 * composite.c (get_composition_id, gstring_lookup_cache):
1203 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1204 * image.c (xpm_get_color_table_h):
1205 * lisp.h (hash_lookup, hash_put):
1206 * minibuf.c (Ftest_completion):
1207 Use ptrdiff_t for hash table indexes, not int (which is too
1208 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1209 32-bit --with-wide-int hosts).
1210
e097a6fa
PE
1211 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1212 Add a FIXME comment about memory leaks.
1213 (syms_of_charset): Don't assume xmalloc returns.
1214
5637687f
PE
1215 Don't assume that stated character widths fit in int.
1216 * character.c (Fchar_width, c_string_width, lisp_string_width):
1217 * character.h (CHAR_WIDTH):
1218 * indent.c (MULTIBYTE_BYTES_WIDTH):
1219 Use sanitize_char_width to avoid undefined and/or bad behavior
1220 with outlandish widths.
a66cfb1c 1221 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1222 now that we have two such functions. All uses changed.
1223 (sanitize_char_width): New inline function.
1224
a2271ba2
PE
1225 Don't assume that tab-width fits in int.
1226 * character.h (sanitize_width): New inline function.
1227 (SANE_TAB_WIDTH): New macro.
1228 (ASCII_CHAR_WIDTH): Use it.
1229 * indent.c (sane_tab_width): Remove. All uses replaced by
1230 SANE_TAB_WIDTH (current_buffer).
1231 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1232
18c52557
PE
1233 * fileio.c: Integer overflow issues with file modes.
1234 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1235
caeeedc1
PE
1236 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1237 Remove unreachable code.
1238 (read_hex, load_charset_map_from_file): Check for integer overflow.
1239
50849c52
PE
1240 * xterm.c: don't go over XClientMessageEvent limit
1241 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1242 (x_send_scroll_bar_event): Likewise. Check that the size does not
1243 exceed limits imposed by XClientMessageEvent, as well as the usual
1244 ptrdiff_t and size_t limits.
1245
b13995db
PE
1246 * keyboard.c: Overflow, signedness and related fixes.
1247 (make_lispy_movement): Use same integer type in forward decl
1248 that is used in the definition.
1249 (read_key_sequence, keyremap_step):
1250 Change bufsize argument back to int, undoing my 2011-03-30 change.
1251 We prefer signed types, and int is wide enough here.
1252 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1253 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1254 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1255 length, not size_t. Use ptrdiff_t for index, not int.
1256 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1257 possibility of integer overflow.
1258
13464394
PE
1259 Overflow, signedness and related fixes for images.
1260
1261 * dispextern.h (struct it.stack[0].u.image.image_id)
1262 (struct_it.image_id, struct image.id, struct image_cache.size)
1263 (struct image_cache.used, struct image_cache.ref_count):
1264 * gtkutil.c (update_frame_tool_bar):
1265 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1266 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1267 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1268 * nsmenu.m (update_frame_tool_bar):
1269 * xdisp.c (calc_pixel_width_or_height):
1270 * xfns.c (image_cache_refcount):
1271 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1272 on typical 64-bit hosts.
1273
1274 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1275 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1276 Omit unnecessary casts to int.
1277 (parse_image_spec): Check that integers fall into 'int' range
1278 when the callers expect that.
1279 (image_ascent): Redo ascent calculation to avoid int overflow.
1280 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1281 (lookup_image): Remove unnecessary tests.
1282 (xbm_image_p): Locals are now of int, not EMACS_INT,
1283 since parse_image_check makes sure they fit into int.
1284 (png_load, gif_load, svg_load_image):
1285 Prefer int to unsigned where either will do.
1286 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1287 old tiff_error_handler and tiff_warning_handler.
1288 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1289 stack buffer overflows. It uses only the features of vsnprintf
1290 that are common to both POSIX and native Microsoft.
1291 (tiff_error_handler, tiff_warning_handler): Use it.
1292 (tiff_load, gif_load, imagemagick_load_image):
1293 Don't assume :index value fits in 'int'.
1294 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1295 (imagemagick_load_image): Check that crop parameters fit into
1296 the integer types that MagickCropImage accepts. Don't assume
1297 Vimagemagick_render_type has a nonnegative value. Don't assume
1298 size_t fits in 'long'.
1299 (gs_load): Use printmax_t to print the widest integers possible.
1300 Check for integer overflow when computing image height and width.
1301
c11821d4
EZ
13022011-08-26 Eli Zaretskii <eliz@gnu.org>
1303
1304 * xdisp.c (redisplay_window): Don't force window start if point
1305 will be invisible in the resulting window. (Bug#9324)
1306
0c95fcf7
EZ
13072011-08-25 Eli Zaretskii <eliz@gnu.org>
1308
1309 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1310 the display spec is of the form `(space ...)'.
1311 (handle_display_spec): Return the value returned by
1312 handle_single_display_spec, not just 1 or zero.
1313 (handle_single_display_spec): If the display spec is of the form
1314 `(space ...)', and specifies display in the text area, return 2
1315 rather than 1.
fee65a97 1316 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1317 accurately, and prefer exact match for point under bidi.
1318 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1319
1320 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1321 into disp_prop; all users changed.
1322
1323 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1324 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1325 for the text covered by the display property.
1326
e4ed06f1
CY
13272011-08-25 Chong Yidong <cyd@stupidchicken.com>
1328
1329 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1330 Change return value to nil.
1331 (Frecord_buffer): Delete unused function.
1332
f67cdd7f
EZ
13332011-08-24 Eli Zaretskii <eliz@gnu.org>
1334
5980d4c6
EZ
1335 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1336 buffers, return left-to-right.
8610fe8b
EZ
1337 (set_cursor_from_row): Consider candidate row a win if its glyph
1338 represents a newline and point is on that newline. Fixes cursor
1339 positioning on the newline at EOL of R2L text within L2R
1340 paragraph, and vice versa.
1341 (try_cursor_movement): Check continued rows, in addition to
1342 continuation rows. Fixes unwarranted scroll when point enters a
1343 continued line of R2L text within an L2R paragraph, or vice versa.
1344 (cursor_row_p): Consider the case of point being equal to
1345 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1346 from the end of a short line to the beginning of a continued line
1347 of R2L text within L2R paragraph.
1348 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1349 composed characters.
5980d4c6 1350
f67cdd7f
EZ
1351 * bidi.c (bidi_check_type): Use xassert.
1352 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1353 members.
1354
bca633fb
EZ
13552011-08-23 Eli Zaretskii <eliz@gnu.org>
1356
1357 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1358 a character.
1359
4a5885a7
CY
13602011-08-23 Chong Yidong <cyd@stupidchicken.com>
1361
1362 * nsfont.m (ns_otf_to_script): Fix typo.
1363
0902a04e
KH
13642011-08-22 Kenichi Handa <handa@m17n.org>
1365
1366 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1367 extra slot even if the purpose is char-code-property-table.
1368
1a2e6670
EZ
13692011-08-23 Eli Zaretskii <eliz@gnu.org>
1370
8ddde651
EZ
1371 * xdisp.c (redisplay_window): When computing centering_position,
1372 account for the height of the header line. (Bug#8874)
1373
425cc014
EZ
1374 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1375 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1376 candidate is selected by the mouse, and that candidate has a
1377 composed character under the mouse.
1378
1a2e6670
EZ
1379 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1380 coordinates reported by pos-visible-in-window-p for a composed
1381 character in column zero.
1382
8b76d6f8
SM
13832011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1384
1385 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1386
dac347dd
EZ
13872011-08-22 Eli Zaretskii <eliz@gnu.org>
1388
1389 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1390 consider it a hit if to_charpos is anywhere in the range of the
1391 composed buffer positions.
1392
e013fb34
CY
13932011-08-22 Chong Yidong <cyd@stupidchicken.com>
1394
1395 * image.c (gif_load): Don't assume that each subimage has the same
1396 dimensions as the base image. Handle disposal method that is
1397 "undefined" by the gif spec (Bug#9335).
1398
bd1ba3e8
CY
13992011-08-20 Chong Yidong <cyd@stupidchicken.com>
1400
1401 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1402 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1403
54a1215b
EZ
14042011-08-19 Eli Zaretskii <eliz@gnu.org>
1405
823564e5
EZ
1406 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1407 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1408 from an Org mode buffer to a Speedbar frame.
1409
54a1215b
EZ
1410 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1411 a composition, take its buffer position from IT->cmp_it.charpos.
1412 Fixes cursor positioning at the beginning of a line that begins
1413 with a composed character.
1414
9778ebcc
EZ
14152011-08-18 Eli Zaretskii <eliz@gnu.org>
1416
0be6ee06
EZ
1417 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1418 character bidirectional type, use STRONG_L instead. Fixes crashes
1419 in a buffer produced by `describe-categories'.
1420
9778ebcc
EZ
1421 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1422 members before the level stack, so they would be saved and
1423 restored when copying iterator state. Fixes incorrect reordering
1424 around TABs covered by display properties.
1425
156bffbe
AS
14262011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1427
6b02f655 1428 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1429
72ad093b
CY
14302011-08-17 Chong Yidong <cyd@stupidchicken.com>
1431
1432 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1433 (internal_condition_case_2, internal_condition_case_n):
1434 Remove unnecessary aborts (Bug#9081).
72ad093b 1435
35774242
EZ
14362011-08-17 Eli Zaretskii <eliz@gnu.org>
1437
1438 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1439 has no `load' handler, try opening the file locally. (Bug#9311)
1440
db76dd85
KB
14412011-08-16 Ken Brown <kbrown@cornell.edu>
1442
1443 * gmalloc.c: Expand comment.
1444
b215eee5
EZ
14452011-08-16 Eli Zaretskii <eliz@gnu.org>
1446
1447 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1448 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1449
a4579d33
KB
14502011-08-16 Ken Brown <kbrown@cornell.edu>
1451
1452 Fix memory allocation problems in Cygwin build (Bug#9273).
1453
1454 * unexcw.c ( __malloc_initialized): Declare external variable.
1455 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1456
8b76d6f8
SM
1457 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1458 New variables.
a4579d33
KB
1459 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1460 dumped emacs.
1461 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1462 in the static heap.
1463 [CYGWIN] (special_realloc): New function.
1464 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1465 requests to realloc storage in the static heap.
1466
3ebec551
PE
14672011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1468
1469 * bidi.c (bidi_initialize): Remove unused local.
1470
9fd8be00
EZ
14712011-08-15 Eli Zaretskii <eliz@gnu.org>
1472
6b02f655
SM
1473 * bidimirror.h:
1474 * biditype.h: Remove file.
1475 * makefile.w32-in ($(BLD)/bidi.$(O)):
1476 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1477
1478 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1479
1480 * chartab.c: Improve commentary for the uniprop_table API.
1481
32413314
EZ
1482 * bidi.c (bidi_paragraph_init): Support zero value of
1483 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1484 (bidi_initialize): Use uniprop_table instead of including
1485 biditype.h and bidimirror.h.
32413314 1486
9fd8be00
EZ
1487 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1488 coordinates of the iterator when restoring from ppos_it.
1489 (Bug#9296)
1490
5cf2b69b
KH
14912011-08-14 Kenichi Handa <handa@m17n.org>
1492
1493 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1494 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1495
daf17d00
EZ
14962011-08-14 Eli Zaretskii <eliz@gnu.org>
1497
1498 * xdisp.c (move_it_in_display_line_to): Don't invoke
1499 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1500 ppos_it. Fixes vertical cursor motion when line beginning is
1501 covered by an image. (Bug#9296)
1502
08e3161a
JD
15032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1504
1505 * nsterm.h (ns_run_ascript): Declare.
1506 (NSAPP_DATA2_RUNASSCRIPT): Define.
1507
1508 * nsfns.m (as_script, as_result, as_status): New static variables.
1509 (ns_run_ascript): New function.
5e617bc2 1510 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1511 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1512 the event loop. Get status from as_status (Bug#7276).
1513
1514 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1515 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1516 the event loop (Bug#7276).
1517
a3720aa2
AS
15182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1519
1520 * gnutls.c (QCgnutls_bootprop_priority)
1521 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1522 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1523 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1524 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1525 (QCgnutls_bootprop_verify_hostname_error)
1526 (QCgnutls_bootprop_callbacks_verify): Rename from
1527 Qgnutls_bootprop_..., all uses changed.
1528
1529 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1530 uses changed.
1531
0a0d27fb
PE
15322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1533
19d5c50c
PE
1534 * xfaces.c (Qframe_set_background_mode): Now static.
1535 * dispextern.h (Qframe_set_background_mode): Remove decl.
1536
0a0d27fb
PE
1537 * process.c (Fnetwork_interface_info): Declare local only if needed.
1538
377538cb
JD
15392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1540
1541 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1542 (Fnetwork_interface_list): Allocate in increments of bytes instead
1543 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1544 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1545 sockaddr.
1546 (struct ifflag_def): notrailers is smart on OSX.
1547 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1548 Get hardware address with getifaddrs if available.
1549
08fff70c
EZ
15502011-08-12 Eli Zaretskii <eliz@gnu.org>
1551
1552 * xdisp.c (iterate_out_of_display_property): xassert that
1553 IT->position is set to within IT->object's boundaries. Break from
1554 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1555 when IT->position is set up wrongly due to some bug.
1556 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1557 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1558 entry. Force push_it to save on the stack the current
1559 buffer/string position, to be restored by pop_it. Fix flags in
1560 the iterator structure wrt the object coming from a display
1561 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1562 properties. (Bug#9284)
1563
7be1c708 15642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1565
7be1c708
CY
1566 * fontset.c (fontset_get_font_group): Add proper type checks.
1567 (Bug#9172)
aac0c6e3 1568
7be1c708 15692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1570
7be1c708
CY
1571 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1572 and LC_VERSION_MIN_MACOSX.
1573 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1574 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1575
97bb72a6
EZ
15762011-08-08 Eli Zaretskii <eliz@gnu.org>
1577
1578 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1579 no-display-properties-and-no-overlays under bidi display.
1580 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1581 properties and overlays.
97bb72a6 1582
d5617611
CY
15832011-08-08 Chong Yidong <cyd@stupidchicken.com>
1584
37e11a63
CY
1585 * editfns.c (Fset_time_zone_rule): Document relationship with the
1586 setenv function.
1587
d5617611
CY
1588 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1589 the font entity extracted from the cache (Bug#8109).
1590
58872834
CY
15912011-08-07 Chong Yidong <cyd@stupidchicken.com>
1592
1593 * composite.c (autocmp_chars): Don't reset point. That is done by
1594 restore_point_unwind (Bug#5984).
1595
75bfc667
JL
15962011-08-07 Juri Linkov <juri@jurta.org>
1597
1598 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1599 to show the arg `TIME' instead of `TIMEVAL'.
1600
d1410150
EZ
16012011-08-06 Eli Zaretskii <eliz@gnu.org>
1602
1603 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1604 display property strides EOL and includes a newline, as in
1605 longlines-mode. (Bug#9254)
75b771e4
EZ
1606 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1607 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1608
1609 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1610 is non-zero, even if the data buffer is NULL. Fixes a crash in
1611 vertical-motion with longlines-mode. (Bug#9254)
1612
35928349
EZ
16132011-08-05 Eli Zaretskii <eliz@gnu.org>
1614
ec7cc85b
EZ
1615 * bidi.c <bidi_cache_total_alloc>: Now static.
1616 (bidi_initialize): Initialize bidi_cache_total_alloc.
1617
8b76d6f8 1618 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1619 cache. (Bug#9221)
1620
1621 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1622 amount allocated this far in `bidi_cache_total_alloc'.
1623 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1624 non-zero, only free the data buffer without restoring the cache
1625 contents. All callers changed.
1626
1627 * dispextern.h (bidi_unshelve_cache): Update prototype.
1628
1629 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1630 (move_it_in_display_line, move_it_to)
1631 (move_it_vertically_backward, move_it_by_lines): Replace the call
1632 to xfree to an equivalent call to bidi_unshelve_cache.
1633 (move_it_in_display_line_to): Fix logic of returning
412b6358 1634 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1635
e2e2423b
EZ
16362011-08-05 Eli Zaretskii <eliz@gnu.org>
1637
1638 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1639 came from a string character with a `cursor' property. (Bug#9229)
1640
ae9e757a
JD
16412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1642
1643 * Makefile.in (LIB_PTHREAD): New variable.
1644 (LIBES): Add LIB_PTHREAD (Bug#9216).
1645
1646 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1647 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1648
213bd7f2
AS
16492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1650
6b02f655 1651 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1652
99aaf75f
JD
16532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1654
1655 * xterm.c (x_find_topmost_parent): New function.
1656 (x_set_frame_alpha): Find topmost parent window with
1657 x_find_topmost_parent and set the property there also (bug#9181).
1658 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1659
c74e9d86
PE
16602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1661
1662 * callproc.c (Fcall_process): Avoid vfork clobbering
1663 the local vars buffer, coding_systems, current_dir.
1664
640c8776
SM
16652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1666
1667 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1668
f26d0e4c
PE
16692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1670
8a10d76c
PE
1671 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1672 so that it is not optimized away.
1673
f26d0e4c
PE
1674 * xdisp.c (compute_display_string_pos): Remove unused local.
1675
55439c61
EZ
16762011-08-02 Eli Zaretskii <eliz@gnu.org>
1677
1678 Fix slow cursor motion and scrolling in large buffers with
1679 selective display, like Org Mode buffers. (Bug#9218)
1680
1681 * dispextern.h (struct bidi_it): New member disp_prop_p.
1682
1683 * xdisp.c: Remove one-slot cache of display string positions.
1684 (compute_display_string_pos): Accept an additional argument
5e617bc2 1685 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1686 for a display string or property. If found, set DISP_PROP_P
1687 non-zero.
1688
1689 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1690 DISP_PROP_P, and pass it to compute_display_string_pos.
1691 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1692 non-zero. All callers of bidi_fetch_char changed.
1693
fb33fa43
SM
16942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1695
1696 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1697
b099e063
DM
16982010-12-03 Don March <don@ohspite.net>
1699
1700 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1701 last character M-[char] is translated to ESC [char] (bug#7541).
1702
5cc7f7af
KH
17032011-08-02 Kenichi Handa <handa@m17n.org>
1704
d0fffa3f 1705 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1706
1707 * chartab.c (uniprop_table): Make it non-static.
1708
525d5e6e
EZ
17092011-08-01 Eli Zaretskii <eliz@gnu.org>
1710
1711 * xdisp.c (forward_to_next_line_start): Accept additional argument
1712 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1713 on the newline.
1714 (reseat_at_next_visible_line_start): Use the bidi iterator state
1715 returned by forward_to_next_line_start to restore the state of
1716 it->bidi_it after backing up to previous newline. (Bug#9212)
1717
31011111
AS
17182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1719
1720 * regex.c (re_comp): Protoize.
1721 (re_exec): Fix return type.
1722 (regexec): Fix type of `ret'. (Bug#9203)
1723
476371c4
PE
17242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1725
e5d76069
PE
1726 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1727 This is needed if max-image-size is a floating-point number.
1728
9a79b20c
AS
17292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1730
1731 * print.c (print_object): Print empty symbol as ##.
1732
1733 * lread.c (read1): Read ## as empty symbol.
1734
d8c2fa78
AA
17352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1736
1737 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1738 setting frame foreground color (Bug#9175).
1739 (x_set_background_color): Likewise.
1740
ffe57a7a
AA
1741 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1742 contents (Bug#9176).
1743 (EmacsTooltip -init): Remove bezels and add shadows to
1744 tooltip windows.
1745
bf3492a5
AA
1746 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1747 or scroll bar (Bug#8470).
1748
d55e9c53
AA
1749 * nsfont.m (nsfont_open): Remove assignment to voffset and
1750 unnecessary vars hshink, expand, hd, full_height, min_height.
1751 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1752
1753 * nsterm.h (nsfont_info): Remove voffset field.
1754
d8c2fa78 17552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1756
1757 Implement strike-through and overline on NextStep (Bug#8863).
1758
1759 * nsfont.m (nsfont_open): Use underline position provided by font,
1760 instead of hard-coded value of 2.
1761 (nsfont_draw): Call ns_draw_text_decoration instead.
1762
1763 * nsterm.h: Add declaration for ns_draw_text_decoration.
1764
1765 * nsterm.m (ns_draw_text_decoration): New function for drawing
1766 underline, overline, and strike-through.
1767 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1768 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1769 accommodate underlining, etc.
4843aac3 1770
4cc60b9b
EZ
17712011-07-28 Eli Zaretskii <eliz@gnu.org>
1772
bc7ece87
EZ
1773 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1774 default.
4cc60b9b 1775
476371c4
PE
17762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1777
66606eea
PE
1778 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1779 Without this fix, if a signal arrives just after memory fills up,
1780 'malloc' might be invoked reentrantly.
1781
476371c4
PE
1782 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1783 In other words, assume that every image size is allowed, on non-X
1784 hosts. This assumption is probably wrong, but it lets Emacs compile.
1785
f3fcc40d
AS
17862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1787
1788 * regex.c (re_iswctype): Convert return values to boolean.
1789
350c992f
EZ
17902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1791
1792 * xdisp.c (compute_display_string_pos): Don't use cached display
1793 string position if the buffer had its restriction changed.
1794 (Bug#9184)
1795
5266b4bb
PE
17962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1799
2573a837 18002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1801
41f55ccd 1802 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1803
39e378da
PE
1804 * bidi.c: Integer size and overflow fixes.
1805 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1806 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1807 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1808 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1809 (bidi_find_other_level_edge):
1810 Use ptrdiff_t instead of EMACS_INT where either will do.
1811 This works better on 32-bit hosts configured --with-wide-int.
1812 (bidi_cache_ensure_space): Check for size-calculation overflow.
1813 Use % rather than repeated addition, for better worst-case speed.
1814 Don't set bidi_cache_size until after xrealloc returns, because it
1815 might not return.
1816 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1817 (bidi_cache_ensure_space): Also check that the bidi cache size
1818 does not exceed that of the largest Lisp string or buffer. See Eli
1819 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1820
5e927815
PE
1821 * alloc.c (__malloc_size_t): Remove.
1822 All uses replaced by size_t. See Andreas Schwab's note
1823 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1824
ca4aa935
PE
1825 * image.c: Improve checking for integer overflow.
1826 (check_image_size): Assume that f is nonnull, since
1827 it is always nonnull in practice. This is one less thing to
1828 worry about when checking for integer overflow later.
1829 (x_check_image_size): New function, which checks for integer
1830 overflow issues inside X.
1831 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1832 This removes the need for a memory_full check.
1833 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1834 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1835 (xbm_read_bitmap_data): Change locals back to 'int', since
1836 their values must fit in 'int'.
1837 (xpm_load_image, png_load, tiff_load):
1838 Invoke x_create_x_image_and_pixmap earlier,
1839 to avoid much needless work if the image is too large.
1840 (tiff_load): Treat overly large images as if
1841 x_create_x_image_and_pixmap failed, not as malloc failures.
1842 (gs_load): Use x_check_image_size.
1843
5f8f9cc2
PE
1844 * gtkutil.c: Omit integer casts.
1845 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1846 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1847
5adf60bc
PE
1848 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1849
c8907a93
PE
1850 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1851 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1852 would wrongly return t on a 64-bit host.
1853
e3c25c68
PE
1854 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1855 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1856 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1857 and therefore cause GCC to emit a bogus diagnostic in some cases.
1858
3f791afe
PE
1859 * image.c: Integer signedness and overflow and related fixes.
1860 This is not an exhaustive set of fixes, but it's time to
1861 record what I've got.
1862 (lookup_pixel_color, check_image_size): Remove redundant decls.
1863 (check_image_size): Don't assume that arbitrary EMACS_INT values
1864 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1865 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1866 (tiff_load, imagemagick_load_image):
1867 Check for overflow in size calculations.
1868 (x_create_x_image_and_pixmap): Remove unnecessary test for
1869 xmalloc returning NULL; that can't happen.
1870 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1871 (xpm_color_bucket): Use better integer hashing function.
1872 (xpm_cache_color): Don't possibly over-allocate memory.
1873 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1874 (gif_memory_source):
1875 Use ptrdiff_t, not int or size_t, to record sizes.
1876 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1877 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1878 either works, as we prefer signed integers.
1879 (tiff_read_from_memory, tiff_write_from_memory):
1880 Return tsize_t, not size_t, since that's what the TIFF API wants.
1881 (tiff_read_from_memory): Don't fail simply because the read would
1882 go past EOF; instead, return a short read.
1883 (tiff_load): Omit no-longer-needed casts.
1884 (Fimagemagick_types): Don't assume size fits into 'int'.
1885
3cc5a532
PE
1886 Improve hashing quality when configured --with-wide-int.
1887 * fns.c (hash_string): New function, taken from sxhash_string.
1888 Do not discard information about ASCII character case; this
1889 discarding is no longer needed.
1890 (sxhash-string): Use it. Change sig to match it. Caller changed.
1891 * lisp.h: Declare it.
1892 * lread.c (hash_string): Remove, since we now use fns.c's version.
1893 The fns.c version returns a wider integer if --with-wide-int is
1894 specified, so this should help the quality of the hashing a bit.
1895
b312a492
PE
1896 * emacs.c: Integer overflow minor fix.
1897 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1898 Define only if GNU_LINUX.
1899 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1900
dfd153ae
PE
1901 * dispnew.c: Integer signedness and overflow fixes.
1902 Remove unnecessary forward decls, that were a maintenance hassle.
1903 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1904 All uses changed.
1905 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1906 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1907 (prepare_desired_row, line_draw_cost):
1908 Use int, not unsigned, where either works.
1909 (save_current_matrix, restore_current_matrix):
1910 Use ptrdiff_t, not size_t, where either works.
1911 (init_display): Check for overflow more accurately, and without
1912 relying on undefined behavior.
1913
a81d11a3
PE
1914 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1915 Remove, replacing with the new symbols in lisp.h. All uses changed.
1916 * fileio.c (make_temp_name):
1917 * filelock.c (lock_file_1, lock_file):
1918 * xdisp.c (message_dolog):
1919 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1920 Use pMd etc. instead.
1921 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1922 replacing the pWIDE etc. symbols removed from editfns.c.
1923
3300e6fd
PE
1924 * keyboard.h (num_input_events): Now uintmax_t.
1925 This is (very slightly) less likely to mess up due to wraparound.
1926 All uses changed.
1927
fd05c7e9
PE
1928 * buffer.c: Integer signedness fixes.
1929 (alloc_buffer_text, enlarge_buffer_text):
1930 Use ptrdiff_t rather than size_t when either will do, as we prefer
1931 signed integers.
1932
903fe15d
PE
1933 * alloc.c: Integer signedness and overflow fixes.
1934 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1935 (__malloc_size_t): Default to size_t, not to int.
1936 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1937 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1938 Prefer ptrdiff_t to size_t when either would do, as we prefer
1939 signed integers.
1940 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1941 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1942 Now const. Initialize with values that are in range even if char
1943 is signed.
1944 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1945 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1946 These functions do the right thing with sizes > 2**32.
1947 (check_depth): Now ptrdiff_t, not int.
1948 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1949 Adjust to new way of storing sizes. Check for size overflow bugs
1950 in rest of code.
1951 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1952 slightly wrong anyway, as it missed one instance of
1953 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1954 (refill_memory_reserve): Omit needless cast to size_t.
1955 (mark_object_loop_halt): Mark as externally visible.
1956
ac82cc6a
PE
1957 * xselect.c: Integer signedness and overflow fixes.
1958 (Fx_register_dnd_atom, x_handle_dnd_message):
1959 Use ptrdiff_t, not size_t, since we prefer signed.
1960 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1961 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1962 x_dnd_atoms_size and x_dnd_atoms_length.
1963
c2d1e36d
PE
1964 * doprnt.c: Prefer signed to unsigned when either works.
1965 * eval.c (verror):
1966 * doprnt.c (doprnt):
1967 * lisp.h (doprnt):
1968 * xdisp.c (vmessage):
1969 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1970 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1971 prefer signed arithmetic to avoid comparison confusion.
1972 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1973 but is a bit tricky.
1974
0e926e56
PE
1975 Assume freestanding C89 headers, string.h, stdlib.h.
1976 * data.c, doprnt.c, floatfns.c, print.c:
1977 Include float.h unconditionally.
1978 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1979 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1980 * regex.c: Likewise for stddef.h, string.h.
1981 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1982 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1983 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1984 (STDC_HEADERS): Remove obsolete defines.
1985 * sysdep.c: Include limits.h unconditionally.
1986
9cfdb3ec
PE
1987 Assume support for memcmp, memcpy, memmove, memset.
1988 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1989 * regex.c (memcmp, memcpy):
1990 Remove; we assume C89 now.
1991
1992 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1993 (__malloc_safe_bcopy): Remove; no longer needed.
1994
cf950e6b 1995 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1996 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1997 well either way, and we prefer signed to unsigned.
1998
dbf38e02
LMI
19992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2000
2001 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2002 closes the connection while we're reading (bug#9182).
2003
d6f0886c 20042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2005
d6f0886c
JD
2006 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2007 are specified (Bug#9168).
24e0f6b1 2008
2eb1f9e6
PE
20092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2010
2011 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2012 Found by GCC static checking and --with-wide-int on a 32-bit host.
2013
22381272 20142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2015
2016 * xdisp.c (compute_display_string_pos): Fix logic of caching
2017 previous display string position. Initialize cached_prev_pos to
2018 -1. Fixes slow-down at the beginning of a buffer.
2019
f25e39b4
EZ
20202011-07-24 Eli Zaretskii <eliz@gnu.org>
2021
2022 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2023 for attrs[LFACE_FONTSET_INDEX].
2024
04c4b52e
PE
20252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 * xml.c (parse_region): Remove unused local
2028 that was recently introduced.
2029
c1734fbd
EZ
20302011-07-23 Eli Zaretskii <eliz@gnu.org>
2031
be18c5a5
EZ
2032 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2033 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2034
c1734fbd
EZ
2035 * xdisp.c (move_it_in_display_line_to): Record the best matching
2036 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2037 exit if none of the characters scanned was an exact match.
2038 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2039 when exact match is impossible due to invisible text, and the
2040 lines are truncated.
2041
a258d627
JD
20422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2043
2044 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2045 for OSX >= 10.7.
2046
b6d5a689
EZ
20472011-07-22 Eli Zaretskii <eliz@gnu.org>
2048
0f74f785
EZ
2049 Fix a significant slow-down of cursor motion with C-n, C-p,
2050 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2051 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2052 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2053 (next_element_from_buffer): Call compute_stop_pos_backwards to
2054 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2055 base_level_stop.
2056 (reseat): Don't look for prev_stop, as that could mean a very long
2057 run.
2058 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2059 <cached_disp_overlay_modiff>: Cache for last found display string
2060 position.
551918c1 2061 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2062 about the same buffer in the same area of character positions, and
2063 the buffer wasn't changed since the time the display string
2064 position was cached.
551918c1 2065
b2d0c91a
EZ
20662011-07-22 Eli Zaretskii <eliz@gnu.org>
2067
2068 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2069 is an integer, which is important for empty lines. (Bug#9149)
2070
043604ee
CY
20712011-07-22 Chong Yidong <cyd@stupidchicken.com>
2072
2073 * frame.c (Fmodify_frame_parameters): In tty case, update the
2074 default face if necessary (Bug#4238).
2075
da4adb04
CY
20762011-07-21 Chong Yidong <cyd@stupidchicken.com>
2077
2078 * editfns.c (Fstring_to_char): No need to explain what a character
2079 is in the docstring (Bug#6576).
2080
9abd0532
LMI
20812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2082
2083 * xml.c (parse_region): Make sure we always return a tree.
2084
36881d16
HK
20852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2086
2087 * xml.c (parse_region): If a document contains only comments,
2088 return that, too.
2089
1e98674d
LMI
20902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2091
2092 * xml.c (make_dom): Return comments, too.
2093
590bd467
PE
20942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 Port to OpenBSD.
2097 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2098 and the surrounding thread.
2099 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2100 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2101 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2102 timer goes off.
2103 * s/openbsd.h (BROKEN_SIGIO): Define.
2104 * unexelf.c (unexec) [__OpenBSD__]:
2105 Don't update the .mdebug section of the Alpha COFF symbol table.
2106
f41628b2
LMI
21072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2108
2109 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2110 (bug#8460).
2111
b59b67c5
PE
21122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2113
15e3a074
PE
2114 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2115 This fixes some race conditions on the permissions of any newly
2116 created file.
2117
41bed37d
PE
2118 * alloc.c (valid_pointer_p): Use pipe, not open.
2119 This fixes some permissions issues when debugging.
2120
b59b67c5
PE
2121 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2122 If fchown fails to set both uid and gid, try to set just gid,
2123 as that is sometimes allowed. Adjust the file's mode to eliminate
2124 setuid or setgid bits that are inappropriate if fchown fails.
2125
925a6be7
SM
21262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2127
2128 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2129 to compare Lisp_Objects.
2130 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2131 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2132 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2133
52968808
AS
21342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2135
0a6a104b
AS
2136 * lread.c (read_integer): Unread even EOF character.
2137 (read1): Likewise. Properly record start position of symbol.
2138
52968808
AS
2139 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2140 symbol character follows.
2141
9e381cdd
PE
21422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2145 This works around a problem with the previous change to Fcopy_file.
2146 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2147 and without this change, GCC might complain about discarding
2148 fchown's return value.
2149
b5641435
JB
21502011-07-16 Juanma Barranquero <lekktu@gmail.com>
2151
2152 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2153
a8031457
PE
21542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2157
dd889327
LMI
21582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2159
750c33f7
LMI
2160 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2161 it's used from the C level.
2162
dd889327
LMI
2163 * process.c: Use the same condition for POLL_FOR_INPUT in both
2164 keyboard.c and process.c (bug#1858).
2165
87e86684
LM
21662011-07-09 Lawrence Mitchell <wence@gmx.li>
2167
2168 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2169 (Fgnutls_boot): Use it.
2170
64348f40
AS
21712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2172
2173 * doc.c (Fsubstitute_command_keys): Revert last change.
2174
1d698799
LMI
21752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2176
f863868c
LMI
2177 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2178 quotes the next character, and doesn't affect other longer
2179 sequences (bug#8935).
2180
1d698799
LMI
2181 * lread.c (syms_of_lread): Clarify that is isn't only
2182 `eval-buffer' and `eval-defun' that's affected by
2183 `lexical-binding' (bug#8460).
2184
aa4b6df6
EZ
21852011-07-15 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2188 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2189
5d856da6
PE
21902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2191
ad6042bb
PE
2192 Fix minor problems found by static checking.
2193 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2194 (elsz): Now a signed constant, not a size_t var. We prefer signed
2195 types to unsigned, to avoid integer comparison confusion. Without
2196 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2197 "cannot optimize loop, the loop counter may overflow", a symptom
2198 of the confusion.
f00bbb22 2199 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2200 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2201
6468f31c
LMI
22022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2203
49080b10
LMI
2204 * search.c (Fre_search_backward): Mention `case-fold-search' in
2205 all the re_search_* functions (bug#8138).
2206
6468f31c
LMI
2207 * keyboard.c (Fopen_dribble_file): Document when the file is
2208 closed (bug#8056).
2209
c965adc5
EZ
22102011-07-14 Eli Zaretskii <eliz@gnu.org>
2211
df9733bf
EZ
2212 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2213 bidi_cache_idx.
2214
0bb23927
EZ
2215 Support bidi reordering of display and overlay strings.
2216 * xdisp.c (compute_display_string_pos)
2217 (compute_display_string_end): Accept additional argument STRING.
2218 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2219 (reseat_to_string): Initialize bidi_it->string.s and
2220 bidi_it->string.schars.
2221 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2222 NULL (avoids a crash in bidi_paragraph_init).
2223 Initialize itb.string.lstring.
0bb23927
EZ
2224 (init_iterator): Call bidi_init_it only of a valid
2225 buffer position was specified. Initialize paragraph_embedding to
2226 L2R.
2227 (reseat_to_string): Initialize the bidi iterator.
2228 (display_string): If we need to ignore text properties of
2229 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2230 original value of -1 will not work with bidi.)
2231 (compute_display_string_pos): First arg is now struct
2232 `text_pos *'; all callers changed. Support display properties on
2233 Lisp strings.
2234 (compute_display_string_end): Support display properties on Lisp
2235 strings.
2236 (init_iterator, reseat_1, reseat_to_string): Initialize the
2237 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2238 when iterating on a string not from display properties).
640c8776
SM
2239 (compute_display_string_pos, compute_display_string_end):
2240 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2241 arrow keys.
2242 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2243 base_level_stop; instead, set base_level_stop to BEGV.
2244 Fixes crashes in vertical-motion.
0bb23927
EZ
2245 (next_element_from_buffer): Improve commentary for when
2246 the iterator is before prev_stop.
2247 (init_iterator): Initialize bidi_p from the default value of
2248 bidi-display-reordering, not from buffer-local value. Use the
2249 buffer-local value only if initializing for buffer iteration.
2250 (handle_invisible_prop): Support invisible properties on strings
2251 that are being bidi-reordered.
2252 (set_iterator_to_next): Support bidi reordering of C strings and
2253 Lisp strings.
2254 (next_element_from_string): Support bidi reordering of Lisp
2255 strings.
2256 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2257 (display_string): Support display of R2L glyph rows.
2258 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2259 (init_iterator): Don't initialize it->bidi_p for strings
2260 here.
2261 (reseat_to_string): Initialize it->bidi_p for strings here.
2262 (next_element_from_string, next_element_from_c_string)
2263 (next_element_from_buffer): Add xassert's for correspondence
2264 between IT's object being iterated and it->bidi_it.string
2265 structure.
2266 (face_before_or_after_it_pos): Support bidi iteration.
2267 (next_element_from_c_string): Handle the case of the first string
2268 character that is not the first one in the visual order.
2269 (get_visually_first_element): New function, refactored from common
2270 parts of next_element_from_buffer, next_element_from_string, and
2271 next_element_from_c_string.
2272 (tool_bar_lines_needed, redisplay_tool_bar)
2273 (display_menu_bar): Force left-to-right direction. Add a FIXME
2274 comment for making that be controlled by a user option.
2275 (push_it, pop_it): Save and restore the state of the
2276 bidi iterator. Save and restore the bidi_p flag.
2277 (pop_it): Iterate out of display property for string iteration as
2278 well.
2279 (iterate_out_of_display_property): Support iteration over strings.
2280 (handle_single_display_spec): Set up it->bidi_it for iteration
2281 over a display string, and call bidi_init_it.
2282 (handle_single_display_spec, next_overlay_string)
2283 (get_overlay_strings_1, push_display_prop): Set up the bidi
2284 iterator for displaying display or overlay strings.
2285 (forward_to_next_line_start): Don't use the shortcut if
2286 bidi-iterating.
2287 (back_to_previous_visible_line_start): If handle_display_prop
2288 pushed the iterator stack, restore the internal state of the bidi
2289 iterator by calling bidi_pop_it same number of times.
2290 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2291 and we are bidi-iterating, don't decrement the iterator position;
2292 instead, set the first_elt flag in the bidi iterator, to produce
2293 the same effect.
2294 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2295 (push_display_prop): xassert that we are iterating a buffer.
2296 (push_it, pop_it): Save and restore paragraph_embedding member.
2297 (handle_single_display_spec, next_overlay_string)
2298 (get_overlay_strings_1, reseat_1, reseat_to_string)
2299 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2300 correctly. Don't assume unibyte strings are not bidi-reordered.
2301 (compute_display_string_pos)
2302 (compute_display_string_end): Fix handling the case of C string.
2303 (push_it, pop_it): Save and restore from_disp_prop_p.
2304 (handle_single_display_spec, push_display_prop): Set the
2305 from_disp_prop_p flag.
2306 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2307 (pop_it): Call iterate_out_of_display_property only if we are
2308 popping after iteration over a string that came from a display
2309 property. Fix a typo in popping stretch info. Add an assertion
2310 for verifying that the iterator position is in sync with the bidi
2311 iterator.
2312 (handle_single_display_spec, get_overlay_strings_1)
2313 (push_display_prop): Fix initialization of paragraph direction for
2314 string when that of the parent object is not yet determined.
2315 (reseat_1): Call bidi_init_it to resync the bidi
2316 iterator with IT's position. (Bug#7616)
2317 (find_row_edges): If ROW->start.pos gives position
2318 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2319 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2320 Reset the from_disp_prop_p flag.
2321 (SAVE_IT, RESTORE_IT): New macros.
2322 (pos_visible_p, face_before_or_after_it_pos)
2323 (back_to_previous_visible_line_start)
2324 (move_it_in_display_line_to, move_it_in_display_line)
2325 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2326 (try_scrolling, redisplay_window, display_line): Use them when
2327 saving a temporary copy of the iterator and restoring it back.
2328 (back_to_previous_visible_line_start, reseat_1)
2329 (init_iterator): Empty the bidi cache "stack".
2330 (move_it_in_display_line_to): If iterator ended up at
2331 EOL, but we never saw any buffer positions smaller than
2332 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2333 motion in bidi-reordered lines.
2334 (move_it_in_display_line_to): Record prev_method and prev_pos
2335 immediately before the call to set_iterator_to_next. Fixes cursor
2336 motion in bidi-reordered lines with stretch glyphs and strings
2337 displayed in margins. (Bug#8133) (Bug#8867)
2338 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2339 TO_CHARPOS.
640c8776
SM
2340 (pos_visible_p): Support positions in bidi-reordered lines.
2341 Save and restore bidi cache.
0bb23927
EZ
2342
2343 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2344 (bidi_paragraph_info): Delete unused struct.
2345 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2346 (bidi_cache_start): New variable.
2347 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2348 to zero.
2349 (bidi_cache_fetch_state, bidi_cache_search)
2350 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2351 (bidi_cache_find, bidi_peek_at_next_level)
2352 (bidi_level_of_next_char, bidi_find_other_level_edge)
2353 (bidi_move_to_visually_next): Compare cache index with
2354 bidi_cache_start rather than with zero.
2355 (bidi_fetch_char): Accept new argument STRING; all callers
2356 changed. Support iteration over a string. Support strings with
2357 display properties. Support unibyte strings. Fix the type of
2358 `len' according to what STRING_CHAR_AND_LENGTH expects.
2359 (bidi_paragraph_init, bidi_resolve_explicit_1)
2360 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2361 (bidi_level_of_next_char, bidi_move_to_visually_next):
2362 Support iteration over a string.
0bb23927
EZ
2363 (bidi_set_sor_type, bidi_resolve_explicit_1)
2364 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2365 can now be zero (for strings); special values 0 and -1 were
2366 changed to -1 and -2, respectively.
2367 (bidi_char_at_pos): New function.
2368 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2369 Call it instead of FETCH_MULTIBYTE_CHAR.
2370 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2371 initialized to valid values.
2372 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2373 values.
2374 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2375 the test for valid cached positions. Fix the logic for looking up
2376 the sentinel state in the cache. GCPRO the Lisp string we are
2377 iterating.
2378 (bidi_push_it, bidi_pop_it): New functions.
2379 (bidi_initialize): Initialize the bidi cache start stack pointer.
2380 (bidi_cache_ensure_space): New function, refactored from part of
2381 bidi_cache_iterator_state. Don't assume the required size is just
2382 one BIDI_CACHE_CHUNK away.
2383 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2384 (bidi_count_bytes, bidi_char_at_pos): New functions.
2385 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2386 always valid if bidi_cache_idx is valid.
2387 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2388 is valid if it's going to be used.
2389 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2390 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2391 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2392 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2393 (bidi_find_other_level_edge, bidi_cache_start_stack):
2394 All variables related to cache indices are now EMACS_INT.
c965adc5 2395
0bb23927
EZ
2396 * dispextern.h (struct bidi_string_data): New structure.
2397 (struct bidi_it): New member `string'. Make flag members be 1-bit
2398 fields, and put them last in the struct.
640c8776
SM
2399 (compute_display_string_pos, compute_display_string_end):
2400 Update prototypes.
0bb23927
EZ
2401 (bidi_push_it, bidi_pop_it): Add prototypes.
2402 (struct iterator_stack_entry): New members bidi_p,
2403 paragraph_embedding, and from_disp_prop_p.
2404 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2405 (bidi_shelve_cache, bidi_unshelve_cache):
2406 Declare prototypes.
0bb23927
EZ
2407
2408 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2409 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2410 and vector-like objects.
2411
2412 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2413 cache around display iteration.
2414
2415 * window.c (Fwindow_end, window_scroll_pixel_based)
2416 (displayed_window_lines, Frecenter): Save and restore the bidi
2417 cache around display iteration.
2418
3bbd2265
LMI
24192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2420
2421 * editfns.c (Fdelete_region): Clarify the use of the named
2422 parameters (bug#6788).
2423
adc47434
MR
24242011-07-14 Martin Rudalics <rudalics@gmx.at>
2425
2426 * indent.c (Fvertical_motion): Set and restore w->pointm when
2427 saving and restoring the window's buffer (Bug#9006).
2428
837c31f8
LMI
24292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2430
2431 * editfns.c (Fstring_to_char): Clarify just what is returned
2432 (bug#6576). Text by Eli Zaretskii.
2433
ac389d0c
JB
24342011-07-13 Juanma Barranquero <lekktu@gmail.com>
2435
2436 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2437
0be0ce47
EZ
24382011-07-13 Eli Zaretskii <eliz@gnu.org>
2439
2440 * buffer.c (mmap_find): Fix a typo.
2441
cd18e7e3
JB
24422011-07-13 Johan Bockgård <bojohan@gnu.org>
2443
2444 Fix execution of x selection hooks.
2445 * xselect.c (Qx_lost_selection_functions)
2446 (Qx_sent_selection_functions): New vars.
2447 (syms_of_xselect): DEFSYM them.
2448 (x_handle_selection_request): Pass Qx_sent_selection_functions
2449 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2450 (x_handle_selection_clear,x_clear_frame_selections):
2451 Pass Qx_lost_selection_functions rather than
2452 Vx_lost_selection_functions to Frun_hook_with_args.
2453
47ea7f44
PE
24542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2455
ac389d0c 2456 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2457 The old code sometimes used this field without initializing it.
2458
47ea7f44
PE
2459 * alloc.c (gc_sweep): Don't read past end of array.
2460 In theory, the old code could also have corrupted Emacs internals,
2461 though it'd be very unlikely.
2462
bc985c87
AS
24632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2464
2465 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2466 argument. (Bug#4026)
bc985c87 2467
0cf34688
LMI
24682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2469
b3dadd76
LMI
2470 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2471 key" (bug#4257).
2472
0cf34688
LMI
2473 * window.c (Fset_window_start): Doc fix (bug#4199).
2474 (Fset_window_hscroll): Ditto.
2475
270768cd
PE
24762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2477
077e3dda 2478 Fix minor new problems caught by GCC 4.6.1.
270768cd 2479 * term.c (init_tty): Remove unused local.
490011a6 2480 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2481 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2482 not used otherwise.
270768cd 2483
b1f58454
CY
24842011-07-12 Chong Yidong <cyd@stupidchicken.com>
2485
2486 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2487
22b9578d
LMI
24882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2489
6e70ab07
LMI
2490 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2491 are the mini-buffer and the echo area (bug#3320).
2492
22b9578d
LMI
2493 * term.c (init_tty): Remove support for supdup, c10 and perq
2494 terminals, which are no longer supported (bug#1482).
2495
8974cc9f
JB
24962011-07-10 Johan Bockgård <bojohan@gnu.org>
2497
2498 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2499
a560d974
JD
25002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2501
2502 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2503 for non-popups (Bug#3642).
2504
1dae0f0a
AS
25052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2506
268c2c36 2507 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2508 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2509 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2510 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2511 * data.c (fmod): Likewise.
2512 * dispnew.c (swap_glyphs_in_rows): Likewise.
2513 * emacs.c (memory_warning_signal): Likewise.
2514 * floatfns.c (float_error): Likewise.
2515 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2516 (otf_open, font_otf_capability, generate_otf_features)
2517 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2518 Likewise.
2519 * image.c (pbm_read_file): Likewise.
2520 * indent.c (string_display_width): Likewise.
2521 * intervals.c (check_for_interval, search_for_interval)
2522 (inc_interval_count, count_intervals, root_interval)
2523 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2524 * lread.c (defalias): Likewise.
268c2c36 2525 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2526 * regex.c (set_image_of_range_1, set_image_of_range)
2527 (regex_grow_registers): Likewise.
2528 * sysdep.c (strerror): Likewise.
2529 * termcap.c (valid_filename_p, tprint, main): Likewise.
2530 * tparam.c (main): Likewise.
2531 * unexhp9k800.c (run_time_remap, save_data_space)
2532 (update_file_ptrs, read_header, write_header, calculate_checksum)
2533 (copy_file, copy_rest, display_header): Likewise.
2534 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2535 Likewise.
2536 * xdisp.c (check_it): Likewise.
2537 * xfaces.c (register_color, unregister_color, unregister_colors):
2538 Likewise.
2539 * xfns.c (print_fontset_result): Likewise.
2540 * xrdb.c (member, fatal, main): Likewise.
2541
99033785
PE
25422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2543
2544 Fix minor problems found by static checking (Bug#9031).
2545 * chartab.c (char_table_set_range, map_sub_char_table):
2546 Remove unused locals.
2547 (uniprop_table): Now static.
2548 * composite.c (_work_char): Remove unused static var.
2549
9cb2ac56
JB
25502011-07-09 Juanma Barranquero <lekktu@gmail.com>
2551
2552 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2553
f25661f0
JD
25542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2555
2556 * gtkutil.c (qttip_cb): Remove code without function.
2557
8278c4fe
EZ
25582011-07-09 Eli Zaretskii <eliz@gnu.org>
2559
2560 * w32.c (pthread_sigmask): New stub.
2561
1692ae2d 25622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2563
8a6ebd58 2564 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2565 sigprocmask is portable only for single-threaded applications, and
2566 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2567 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2568 (LIBES): Use it.
2569 * callproc.c (Fcall_process):
2570 * process.c (create_process):
2571 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2572 Use pthread_sigmask, not sigprocmask.
123403e4 2573
1b854618
JD
25742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2575
2576 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2577 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2578 wrong (Bug#8591).
2579
3fe4b549
JD
25802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2581
0ce7e563
JD
2582 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2583 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2584 (xg_hide_tooltip): Fix comment.
2585
3fe4b549
JD
2586 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2587 in registerServicesMenuSendTypes.
2588 (validRequestorForSendType): Don't check ns_return_types.
2589
2590 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2591 ns_return_type.
2592
5df75e47
JR
25932011-07-08 Jason Rumney <jasonr@gnu.org>
2594
2595 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2596 frame struct members of non-existent frames (Bug#6284).
2597
699c10bd
JD
25982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2599
4393663b
JD
2600 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2601 variable firstTime not needed on OSX >= 10.6.
2602 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2603 >= 10.5. Use setKnobProportion, setDoubleValue.
2604
2605 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2606 (MAC_OS_X_VERSION_10_5): Define if not defined.
2607 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2608 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2609 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2610
2611 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2612 cString and lossyCString on OSX >= 10.4
2613
2614 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2615 sizeToFit on OSX >= 10.2.
2616
2617 * nsimage.m (allocInitFromFile): Don't use deprecated method
2618 bestRepresentationForDevice on OSX >= 10.6.
2619
2620 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2621 to avoid warning.
2622
2623 * emacs.c: Declare unexec_init_emacs_zone.
2624
a63e0781
JD
2625 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2626
699c10bd
JD
2627 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2628
2629 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2630 on svcsMenu (Bug#8842).
2631
2632 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2633 ns_return_types.
2634 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2635
2636 * nsterm.m (QUTF8_STRING): Declare.
2637 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2638 (validRequestorForSendType): Return type is (id).
2639 Change indexOfObjectIdenticalTo to indexOfObject.
2640 Check if we have local selection before returning self (Bug#8842).
2641 (writeSelectionToPasteboard): Put local selection into paste board
2642 if we have a local selection (Bug#8842).
2643 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2644
2645 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2646 (ns_get_local_selection): Declare.
2647
54e10184
LMI
26482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2649
9888ff71
LMI
2650 * keymap.c (describe_map_tree): Don't insert a double newline at
2651 the end of the buffer (bug#1169) and return whether we inserted
2652 something.
2653
54e10184
LMI
2654 * callint.c (Fcall_interactively): Change "reading args" to
2655 "providing args" to try to clarify what it does (bug#1010).
2656
15fa4783
KH
26572011-07-07 Kenichi Handa <handa@m17n.org>
2658
2659 * composite.c (composition_compute_stop_pos): Ignore a static
2660 composition starting before CHARPOS (Bug#8915).
2661
2662 * xdisp.c (handle_composition_prop): Likewise.
2663
a8815b00
EZ
26642011-07-07 Eli Zaretskii <eliz@gnu.org>
2665
2666 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2667 (Bug#9015)
2668
ef7b981d 26692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2670
2671 * character.h (unicode_category_t): New enum type.
2672
2673 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2674 (Qchar_code_property_table): New variable.
2675 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2676 (UNIPROP_COMPRESSED_FORM_P): New macros.
2677 (char_table_ascii): Uncompress the compressed values.
2678 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2679 Uncompress the compressed values.
ac389d0c 2680 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2681 (char_table_ref_and_range): Uncompress the compressed values.
2682 (sub_char_table_set): New arg is_uniprop. Callers changed.
2683 Uncompress the compressed values.
2684 (sub_char_table_set_range): Args changed. Callers changed.
2685 (char_table_set_range): Adjuted for the above change.
2686 (map_sub_char_table): Delete args default_val and parent. Add arg
2687 top. Give decoded values to a Lisp function.
640c8776 2688 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2689 values to a Lisp function. Gcpro more variables.
2690 (uniprop_table_uncompress)
2691 (uniprop_decode_value_run_length): New functions.
2692 (uniprop_decoder, uniprop_decoder_count): New variables.
2693 (uniprop_get_decoder, uniprop_encode_value_character)
2694 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2695 New functions.
2696 (uniprop_encoder, uniprop_encoder_count): New variables.
2697 (uniprop_get_encoder, uniprop_table)
2698 (Funicode_property_table_internal, Fget_unicode_property_internal)
2699 (Fput_unicode_property_internal): New functions.
2700 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2701 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2702 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2703 char-code-property-alist.
2704
640c8776 2705 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2706 Vunicode_category_table.
2707
640c8776 2708 * font.c (font_range): Adjust for the change of
c805dec0
KH
2709 Vunicode_category_table.
2710
76b397fb
DN
27112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2712
2713 * m/iris4d.h: Remove file, move contents ...
2714 * s/irix6-5.h: ... here.
2715
22b4128e
PE
27162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2717
2718 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2719 * alloc.c (mark_buffer):
2720 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2721 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2722 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2723 This isn't true in general, and it's particularly not true
2724 if Emacs is configured with --with-wide-int.
2725 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2726 New macros, used in the buffer.c change.
2727
869795d6
JD
27282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2729
2730 * xsettings.c: Use both GConf and GSettings if both are available.
2731 (store_config_changed_event): Add comment.
2732 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2733 (store_tool_bar_style_changed): New functions.
5e617bc2 2734 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2735 (struct xsettings): Move font inside HAVE_XFT.
2736 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2737 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2738 Move inside HAVE_XFT.
640c8776 2739 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2740 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2741 also.
2742 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2743 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2744 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2745 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2746 (parse_settings): Move check for font inside HAVE_XFT.
2747 (read_settings, apply_xft_settings): Add comment.
2748 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2749 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2750 call store_font_name_changed.
2751 (xft_settings_event): Add comment.
2752 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2753 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2754 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2755 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2756 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2757 (xsettings_get_system_font, xsettings_get_system_normal_font):
2758 Add comment.
869795d6 2759
d8ed26bd
PE
27602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2761
2762 Random fixes. E.g., (random) never returned negative values.
2763 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2764 subseconds part to the entropy, as that's a bit more random.
2765 Prefer signed to unsigned, since the signedness doesn't matter and
2766 in general we prefer signed. When given a limit, use a
2767 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2768 latter isn't right if USE_2_TAGS_FOR_INTS.
2769 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2770 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2771
cabf1cac
SM
27722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2773
2774 * textprop.c (text_property_stickiness):
2775 Obey Vtext_property_default_nonsticky.
2776 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2777 * w32fns.c (syms_of_w32fns):
2778 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2779
6e9b2be9
PE
27802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2781
2782 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2783 This is more efficient than Ffile_directory_p and avoids a minor race.
2784
90186c68
LMI
27852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2786
7c301272
LMI
2787 * buffer.c (Foverlay_put): Say what the return value is
2788 (bug#7835).
2789
c4f2d8d4
LMI
2790 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2791 is a directory before asking whether to use the file name
2792 (bug#7564).
ad637907
LMI
2793 (barf_or_query_if_file_exists): Make the "File is a directory"
2794 error be more correct.
c4f2d8d4 2795
90186c68
LMI
2796 * fns.c (Frequire): Remove the mention of the .gz files, since
2797 that's installation-specific, but keep the mention of
2798 `get-load-suffixes'.
2799
da64016e
PE
28002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2801
2802 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2803 Report string overflow if the output is too long.
2804
7d47b580
JB
28052011-07-04 Juanma Barranquero <lekktu@gmail.com>
2806
a555cb87
JB
2807 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2808 (syms_of_gnutls): Remove duplicate DEFSYM for
2809 Qgnutls_bootprop_verify_hostname_error, an error for
2810 Qgnutls_bootprop_verify_error (which is no longer used).
2811
7d47b580
JB
2812 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2813 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2814 Also (re)move comments that are misplaced or no longer relevant.
2815
1e49bfab
LMI
28162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2817
2818 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2819
1485f4c0
CY
28202011-07-03 Chong Yidong <cyd@stupidchicken.com>
2821
2822 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2823 and background color parameters if they have been changed.
2824
a9ab721e
LMI
28252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2826
2827 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2828
cf7cff57
PE
28292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2830
2e13213d
PE
2831 * xsettings.c (SYSTEM_FONT): Define only when used.
2832 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2833
cf7cff57
PE
2834 * keymap.c (access_keymap_1): Now static.
2835
7a8e04f7
CY
28362011-07-02 Chong Yidong <cyd@stupidchicken.com>
2837
2838 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2839 leave any prefix arg for the up event (Bug#1586).
2840
61352f62
LMI
28412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2842
69bb1ef7
LMI
2843 * lread.c (syms_of_lread): Mention single symbols defined by
2844 `defvar' or `defconst' (bug#7154).
2845
61352f62 2846 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2847 (Frequire): Mention get-load-suffixes.
61352f62 2848
28545e04
MR
28492011-07-02 Martin Rudalics <rudalics@gmx.at>
2850
2851 * window.h (window): Remove clone_number slot.
2852 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2853 Remove.
2854 (make_parent_window, make_window, saved_window)
2855 (Fset_window_configuration, save_window_save): Don't deal with
2856 clone numbers.
2857 * buffer.c (Qclone_number): Remove declaration.
2858 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2859
3349e122
SM
28602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2861
2862 Add multiple inheritance to keymaps.
2863 * keymap.c (Fmake_composed_keymap): New function.
2864 (Fset_keymap_parent): Simplify.
2865 (fix_submap_inheritance): Remove.
2866 (access_keymap_1): New function extracted from access_keymap to handle
2867 embedded parents and handle lists of maps.
2868 (access_keymap): Use it.
2869 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2870 (Fcopy_keymap): Handle embedded parents.
2871 (Fcommand_remapping, define_as_prefix): Simplify.
2872 (Fkey_binding): Simplify.
2873 (syms_of_keymap): Move minibuffer-local-completion-map,
2874 minibuffer-local-filename-completion-map,
2875 minibuffer-local-must-match-map, and
2876 minibuffer-local-filename-must-match-map to Elisp.
2877 (syms_of_keymap): Defsubr make-composed-keymap.
2878 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2879 (parse_menu_item): Trivial simplification.
2880
3279eb87
GM
28812011-07-01 Glenn Morris <rgm@gnu.org>
2882
2883 * Makefile.in (SETTINGS_LIBS): Fix typo.
2884
4550efdf
KI
28852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2886
2887 * coding.c (Fencode_coding_string): Record the last coding system
2888 used, as the function doc string says (bug#8738).
2889
0949d2b6
JD
28902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2891
2892 * xsettings.c (store_monospaced_changed): Take new font as arg and
2893 check for change against current_mono_font.
2894 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2895 (emacs_settings_constructor, emacs_settings_get_property)
2896 (emacs_settings_set_property, emacs_settings_class_init)
2897 (emacs_settings_init, gsettings_obj): Remove.
2898 (something_changedCB): New function for HAVE_GSETTINGS.
2899 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2900 with value as argument.
2901 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2902 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2903 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2904 "changed".
2905
2906 * xgselect.c: Add defined (HAVE_GSETTINGS).
2907 (xgselect_initialize): Ditto.
2908
2909 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2910 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2911 xg_select.
2912
bbc6b304
PE
29132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2914
2915 * eval.c (struct backtrace): Simplify and port the data structure.
2916 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2917 signed bit field, as this assumption is not portable and it makes
2918 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2919 "char debug_on_exit : 1" as this is not portable either; instead,
2920 use the portable "unsigned int debug_on_exit : 1". Remove unused
2921 member evalargs. Remove obsolete comments about cc bombing out.
2922
9851bfc5
JD
29232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2924
51bb811f 2925 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2926 Let HAVE_GSETTINGS override HAVE_GCONF.
2927 (store_monospaced_changed): New function.
2928 (EMACS_SETTINGS): A new type derived from GObject to handle
2929 GSettings notifications.
2930 (emacs_settings_constructor, emacs_settings_get_property)
2931 (emacs_settings_set_property, emacs_settings_class_init):
2932 New functions.
2933 (gsettings_client, gsettings_obj): New variables.
2934 (GSETTINGS_SCHEMA): New define.
2935 (something_changedCB): Call store_monospaced_changed.
2936 (init_gsettings): New function.
2937 (xsettings_initialize): Call init_gsettings.
2938 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2939 to NULL.
2940
640c8776 2941 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2942 GCONF_CFLAGS/LIBS.
2943
5386012d
MR
29442011-06-29 Martin Rudalics <rudalics@gmx.at>
2945
2946 * window.c (resize_root_window, grow_mini_window)
2947 (shrink_mini_window): Rename Qresize_root_window to
2948 Qwindow_resize_root_window and Qresize_root_window_vertically to
2949 Qwindow_resize_root_window_vertically.
2950
f13e0b08
PE
29512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2952
2953 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2954
94515237
JB
29552011-06-27 Juanma Barranquero <lekktu@gmail.com>
2956
2957 * makefile.w32-in: Redesign dependencies so they reflect more
2958 clearly which files are directly included by each source file,
2959 and not through other includes.
2960
e43b6e43
MR
29612011-06-27 Martin Rudalics <rudalics@gmx.at>
2962
2963 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2964 (sort_overlays, overlay_strings): When an overlay's clone number
2965 matches the window's clone number process the overlay even if
2966 the overlay's window property doesn't match the current window.
2967
d68443dc
MR
2968 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2969 (Fwindow_hchild): Rename to Fwindow_left_child.
2970 (Fwindow_next): Rename to Fwindow_next_sibling.
2971 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2972 (resize_window_check): Rename to window_resize_check.
2973 (resize_window_apply): Rename to window_resize_apply.
2974 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2975 (Fdelete_other_windows_internal, resize_frame_windows)
2976 (Fsplit_window_internal, Fdelete_window_internal)
2977 (grow_mini_window, shrink_mini_window)
2978 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2979
c7e73be5
JD
29802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2981
2982 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2983 (emacs_fixed_set_min_size): Remove.
2984 (emacs_fixed_new): Take frame as argument.
2985
2986 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2987 (_EmacsFixedPrivate): Remove minwidth/height.
2988 Add struct frame *f.
2989 (emacs_fixed_init): Initialize priv->f.
2990 (get_parent_class, emacs_fixed_set_min_size): Remove.
2991 (emacs_fixed_new): Set priv->f to argument.
2992 (emacs_fixed_get_preferred_width)
2993 (emacs_fixed_get_preferred_height): Use min_width/height from
2994 frames size_hint to set minimum and natural (Bug#8919).
2995 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2996 and use min_width/height from frames size_hint to set
2997 min_width/height (Bug#8919).
2998
2999 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3000 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3001 Fix indentation.
c7e73be5 3002
cf99dcf8
EZ
30032011-06-26 Eli Zaretskii <eliz@gnu.org>
3004
3005 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3006 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3007 called at ZV.
3008
029529ac
CY
30092011-06-26 Chong Yidong <cyd@stupidchicken.com>
3010
3011 * process.c (wait_reading_process_output): Bypass select if
3012 waiting for a cell while ignoring keyboard input, and input is
3013 pending. Suggested by Jan Djärv (Bug#8869).
3014
7a7ef429
PE
30152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3016
3017 Use gnulib's dup2 module instead of rolling our own.
3018 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3019
11fdef7d 30202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3021
3022 * dispnew.c (scrolling_window): Before scrolling, turn off a
3023 mouse-highlight in the window being scrolled.
3024
cd3520a4
JB
30252011-06-24 Juanma Barranquero <lekktu@gmail.com>
3026
3027 Move DEFSYM to lisp.h and use everywhere.
3028
3029 * character.h (DEFSYM): Move declaration...
3030 * lisp.h (DEFSYM): ...here.
3031
3032 * gnutls.c:
3033 * minibuf.c:
3034 * w32menu.c:
3035 * w32proc.c:
3036 * w32select.c: Don't include character.h.
3037
3038 * alloc.c (syms_of_alloc):
3039 * buffer.c (syms_of_buffer):
3040 * bytecode.c (syms_of_bytecode):
3041 * callint.c (syms_of_callint):
3042 * casefiddle.c (syms_of_casefiddle):
3043 * casetab.c (init_casetab_once):
3044 * category.c (init_category_once, syms_of_category):
3045 * ccl.c (syms_of_ccl):
3046 * cmds.c (syms_of_cmds):
3047 * composite.c (syms_of_composite):
3048 * dbusbind.c (syms_of_dbusbind):
3049 * dired.c (syms_of_dired):
3050 * dispnew.c (syms_of_display):
3051 * doc.c (syms_of_doc):
3052 * editfns.c (syms_of_editfns):
3053 * emacs.c (syms_of_emacs):
3054 * eval.c (syms_of_eval):
3055 * fileio.c (syms_of_fileio):
3056 * fns.c (syms_of_fns):
3057 * frame.c (syms_of_frame):
3058 * fringe.c (syms_of_fringe):
3059 * insdel.c (syms_of_insdel):
3060 * keymap.c (syms_of_keymap):
3061 * lread.c (init_obarray, syms_of_lread):
3062 * macros.c (syms_of_macros):
3063 * msdos.c (syms_of_msdos):
3064 * print.c (syms_of_print):
3065 * process.c (syms_of_process):
3066 * search.c (syms_of_search):
3067 * sound.c (syms_of_sound):
3068 * syntax.c (init_syntax_once, syms_of_syntax):
3069 * terminal.c (syms_of_terminal):
3070 * textprop.c (syms_of_textprop):
3071 * undo.c (syms_of_undo):
3072 * w32.c (globals_of_w32):
3073 * window.c (syms_of_window):
3074 * xdisp.c (syms_of_xdisp):
3075 * xfaces.c (syms_of_xfaces):
3076 * xfns.c (syms_of_xfns):
3077 * xmenu.c (syms_of_xmenu):
3078 * xsettings.c (syms_of_xsettings):
3079 * xterm.c (syms_of_xterm): Use DEFSYM.
3080
4228cf16
TZ
30812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3082
cd3520a4 3083 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3084
7fcccf1e
PE
30852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3086
7efb4e0e
PE
3087 Integer and buffer overflow fixes (Bug#8873).
3088
ff5844ad
PE
3089 * print.c (printchar, strout): Check for string overflow.
3090 (PRINTPREPARE, printchar, strout):
3091 Don't set size unless allocation succeeds.
3092
90532f02
PE
3093 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3094 for sizes. Check for string overflow more accurately.
3095 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3096
6d84508d
PE
3097 * macros.c: Integer and buffer overflow fixes.
3098 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3099 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3100 Use ptrdiff_t, not int, for sizes.
3101 Don't increment bufsize until after realloc succeeds.
3102 Check for size-calculation overflow.
3103 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3104
437b2cb4
PE
3105 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3106
8b9ac8b4
PE
3107 * lread.c: Integer overflow fixes.
3108 (read_integer): Radix is now EMACS_INT, not int,
3109 to improve quality of diagnostics for out-of-range radices.
3110 Calculate buffer size correctly for out-of-range radices.
3111 (read1): Check for integer overflow in radices, and in
3112 read-circle numbers.
82cb60d3
PE
3113 (read_escape): Avoid int overflow.
3114 (Fload, openp, read_buffer_size, read1)
3115 (substitute_object_recurse, read_vector, read_list, map_obarray):
3116 Use ptrdiff_t, not int, for sizes.
3117 (read1): Use EMACS_INT, not int, for sizes.
20270765 3118 Check for size overflow.
8b9ac8b4 3119
7fcccf1e
PE
3120 * image.c (cache_image): Check for size arithmetic overflow.
3121
bfbbd7e7
PE
3122 * lread.c: Integer overflow issues.
3123 (saved_doc_string_size, saved_doc_string_length)
3124 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3125 Now ptrdiff_t, not int.
3126 (read1): Don't assume doc string length fits in int. Check for
3127 out-of-range doc string lengths.
3128 (read_list): Don't assume file position fits in int.
39019e54 3129 (read_escape): Check for hex character overflow.
bfbbd7e7 3130
4e323265
LL
31312011-06-22 Leo Liu <sdl.web@gmail.com>
3132
3133 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3134 Move to minibuffer.el.
3135
85fece3e
PE
31362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3137
20b84ce9 3138 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3139 The following patches are for when GLYPH_DEBUG && !XASSERT.
3140 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3141 * dispnew.c (flush_stdout):
3142 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3143 Mark as externally visible.
3144 * dispnew.c (check_window_matrix_pointers): Now static.
3145 * dispnew.c (window_to_frame_vpos):
3146 * xfns.c (unwind_create_frame):
3147 * xterm.c (x_check_font): Remove unused local.
3148 * scroll.c (CHECK_BOUNDS):
3149 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3150 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3151 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3152 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3153 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3154 Now static.
3155 (debug_method_add): Use va_list and vsprintf rather than relying
3156 on undefined behavior with wrong number of arguments.
3157 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3158 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3159 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3160 since we're not interested in debugging glyphs with old libraries.
3161 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3162 GCC 4.6.0's static checking.
3163
0766b489
PE
31642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3165
31fd4b32
PE
3166 Integer overflow and signedness fixes (Bug#8873).
3167 A few related buffer overrun fixes, too.
3168
b79e8648
PE
3169 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3170
0766b489
PE
3171 * dispextern.h (struct face.stipple):
3172 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3173 (x_bitmap_mask, x_allocate_bitmap_record)
3174 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3175 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3176 (x_create_bitmap_from_xpm_data):
3177 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3178 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3179 (.bitmaps_last):
3180 * xfaces.c (load_pixmap):
3181 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3182 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3183 (.bitmaps_last, struct x_output.icon_bitmap):
3184 Use ptrdiff_t, not int, for bitmap indexes.
3185 (x_allocate_bitmap_record): Check for size overflow.
3186 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3187
b081724f
PE
3188 Use ptrdiff_t, not int, for overlay counts.
3189 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3190 * editfns.c (overlays_around, get_pos_property):
3191 * textprop.c (get_char_property_and_overlay):
3192 * xdisp.c (next_overlay_change, note_mouse_highlight):
3193 * xfaces.c (face_at_buffer_position):
21514da7
PE
3194 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3195 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3196 (Fnext_overlay_change, Fprevious_overlay_change)
3197 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3198 Use ptrdiff_t, not int, for sizes.
21514da7 3199 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3200
3de73e5e
PE
3201 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3202
2606c57b
PE
3203 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3204 (x_session_initialize): Do not assume string length fits in int.
3205
aaafe47a
PE
3206 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3207 This is unlikely, but can occur if DPI is outlandish.
3208
2674ddc8 3209 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3210 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3211
28154962
PE
3212 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3213 * xrdb.c (magic_file_p, search_magic_path):
3214 Omit last arg SUFFIX; it was always 0. All callers changed.
3215 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3216
7de51af5
PE
3217 * xfont.c (xfont_match): Avoid need for strlen.
3218
25ed6cc3
PE
3219 * xfns.c: Don't assume strlen fits in int.
3220 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3221
4eab31dd
PE
3222 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3223 not unsigned long, as we prefer signed integers. All callers changed.
3224 Detect integer overflow in repeat count.
3225 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3226 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3227
171e2a58
PE
3228 * termcap.c: Don't assume sizes fit in int and never overflow.
3229 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3230 (gobble_line): Check for size-calculation overflow.
3231
ad39faca 3232 * minibuf.c (Fread_buffer):
6e5bb2dc 3233 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3234 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3235 Don't assume string length fits in int.
3236
52c61c22 3237 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3238 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3239
b5b8c9e5
PE
3240 * font.c: Don't assume string length fits in int.
3241 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3242 Use ptrdiff_t, not int.
ccd6111c
PE
3243 (font_intern_prop): Don't assume string length fits in int.
3244 Don't assume integer property fits in fixnum.
3245 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3246
882f0d81 3247 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3248 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3249 Reformulate so as not to need the command string.
3250 Invoke gzip -cd rather than gunzip, as it's more portable.
3251 (lock_info_type, lock_file_1, lock_file):
3252 Don't assume pid_t and time_t fit in unsigned long.
3253 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3254 (current_lock_owner): Prefer signed type for sizes.
3255 Use memcpy, not strncpy, where memcpy is what is really wanted.
3256 Don't assume (via atoi) that time_t and pid_t fit in int.
3257 Check for time_t and/or pid_t out of range, e.g., via a network share.
3258 Don't alloca where an auto var works fine.
3259
93f4cf88
PE
3260 * fileio.c: Fix some integer overflow issues.
3261 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3262 Don't assume string length fits in int.
3263 (directory_file_name): Don't assume string length fits in long.
3264 (make_temp_name): Don't assume pid fits in int, or that its print
3265 length is less than 20.
3266
f3e92b69
PE
3267 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3268
1bfdaf10
PE
3269 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3270
35016e9a
PE
3271 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3272
3d1e65a1
PE
3273 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3274 We prefer signed integers, even for size calculations.
3275
0b963a93
PE
3276 * emacs.c: Don't assume string length fits in 'int'.
3277 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3278 (main): Don't invoke strlen when not needed.
3279
573f4b54
PE
3280 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3281 (XD_DEBUG_MESSAGE): Don't waste a byte.
3282
989f33ba
PE
3283 * callproc.c (getenv_internal_1, getenv_internal)
3284 (Fgetenv_internal):
965d34eb
PE
3285 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3286
e4d29b33
PE
3287 * lread.c (invalid_syntax): Omit length argument.
3288 All uses changed. This doesn't fix a bug, but it simplifies the
3289 code away from its former Hollerith-constant appearance, and it's
3290 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3291 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3292
eb49b136
PE
3293 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3294 This didn't break anything, but it didn't help either.
3295 It's confusing to put a bogus integer in a place where the actual
3296 value does not matter.
9f62aeb1 3297 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3298 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3299
15375a22
PE
3300 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3301 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3302 implementation.
b61cc01c
PE
3303 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3304 We prefer signed types, and the value cannot exceed the EMACS_INT
3305 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3306 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3307 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3308 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3309
53b2623d
PE
3310 * indent.c (sane_tab_width): New function.
3311 (current_column, scan_for_column, Findent_to, position_indentation)
3312 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3313 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3314
51cab52b 3315 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3316
f2ed8a70
PE
3317 * lisp.h (lint_assume): New macro.
3318 * composite.c (composition_gstring_put_cache):
3319 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3320
abe80cc6
PE
3321 * editfns.c, insdel.c:
3322 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3323
b02c740e
PE
3324 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3325
ebc96716
PE
3326 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3327
b4e50fa0 3328 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3329 Use much-faster test for byte-length change.
311d5d7c 3330 Don't assume string byte-length fits in 'int'.
a4cf38e4 3331 Check that character arg fits in 'int'.
85461888 3332 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3333
c0c1ee9f
PE
3334 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3335
a498d7f4
PE
3336 * fns.c (concat): Catch string overflow earlier.
3337 Do not rely on integer wraparound.
3338
51cab52b
PE
3339 * dispextern.h (struct it.overlay_strings_charpos)
3340 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3341 * xdisp.c (forward_to_next_line_start)
3342 (back_to_previous_visible_line_start)
3343 (reseat_at_next_visible_line_start, next_element_from_buffer):
3344 Don't arbitrarily truncate the value of 'selective' to int.
3345
76031fad
PE
3346 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3347
5eb55db9
PE
3348 * composite.c: Don't truncate sizes to 'int'.
3349 (composition_gstring_p, composition_reseat_it)
3350 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3351 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3352 not EMACS_UINT, for indexes.
5eb55db9 3353
0703a717
PE
3354 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3355
d6202519
PE
3356 * buffer.c: Include <verify.h>.
3357 (struct sortvec.priority, struct sortstr.priority):
8961a454 3358 Now EMACS_INT, not int.
c20998a7 3359 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3360 (struct sortstr.size, record_overlay_string)
3361 (struct sortstrlist.size, struct sortlist.used):
3362 Don't truncate size to int.
3363 (record_overlay_string): Check for size-calculation overflow.
d6202519 3364 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3365
d5a19415
JM
33662011-06-22 Jim Meyering <meyering@redhat.com>
3367
029529ac 3368 Don't leak an XBM-image-sized buffer
d5a19415
JM
3369 * image.c (xbm_load): Free the image buffer after using it.
3370
a9041e6c
PE
33712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 Port to Sun C.
3374 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3375 that Sun C diagnosed.
3376 * fns.c (secure_hash): Fix pointer signedness issue.
3377 * intervals.c (static_offset_intervals): New function.
3378 (offset_intervals): Use it.
3379
7f3f739f
LL
33802011-06-21 Leo Liu <sdl.web@gmail.com>
3381
3382 * deps.mk (fns.o):
3383 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3384 sha512.h.
3385
3386 * fns.c (secure_hash): Rename from crypto_hash_function and change
3387 the first arg to accept symbols.
5b66d427 3388 (Fsecure_hash): New primitive.
7f3f739f
LL
3389 (syms_of_fns): New symbols.
3390
76147d94
DD
33912011-06-20 Deniz Dogan <deniz@dogan.se>
3392
3393 * process.c (Fset_process_buffer): Clarify return value in
3394 docstring.
3395
7d7d0045
CY
33962011-06-18 Chong Yidong <cyd@stupidchicken.com>
3397
3398 * dispnew.c (add_window_display_history): Use BVAR.
3399
3400 * xdisp.c (debug_method_add): Use BVAR.
3401 (check_window_end, dump_glyph_matrix, dump_glyph)
3402 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3403
3404 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3405 Likewise.
3406
3407 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3408 check till after the cache is created in init_frame_faces.
3409
ff2bc410
SM
34102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3411
3412 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3413
28177add
PE
34142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3415
dd3482fe
PE
3416 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3417 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3418 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3419
393d71f3 3420 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3421 * fileio.c (Finsert_file_contents):
3422 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3423 Remove the old (too-loose) buffer overflow checks.
3424 They weren't needed, since make_gap checks for buffer overflow.
3425 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3426 The old code merely checked for Emacs fixnum overflow, and relied
3427 on undefined (wraparound) behavior. The new code avoids undefined
3428 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3429
2e6813b0 3430 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3431 Tune. Don't use wider integers than needed. Don't use alloca.
3432 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3433
599a9e4f
PE
3434 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3435
99561444
PE
3436 * insdel.c, lisp.h (buffer_overflow): New function.
3437 (insert_from_buffer_1, replace_range, replace_range_2):
3438 * insdel.c (make_gap_larger):
3439 * editfns.c (Finsert_char):
3440 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3441
28177add
PE
3442 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3443
e69dafad
PE
34442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3445
a7af7fde 3446 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3447
b1c46f02
PE
3448 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3449 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3450
e69dafad
PE
3451 * fileio.c: Don't assume EMACS_INT fits in off_t.
3452 (emacs_lseek): New static function.
3453 (Finsert_file_contents, Fwrite_region): Use it.
3454 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3455
566684ea
PE
3456 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3457
e6966cd6
PE
3458 * fns.c: Don't overflow int when computing a list length.
3459 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3460 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3461 truncation on 64-bit hosts. Check for QUIT every
3462 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3463 faster and is responsive enough.
3464 (Flength): Report an error instead of overflowing an integer.
3465 (Fsafe_length): Return a float if the value is not representable
3466 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3467 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3468 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3469
dd0b0efb
PE
3470 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3471 (header_size, word_size): New constants.
3472 (allocate_vectorlike): Don't check size overflow here.
3473 (allocate_vector): Check it here instead, since this is the only
3474 caller of allocate_vectorlike that could cause overflow.
3475 Check that the new vector's length is representable as a fixnum.
3476
86fe5cfe
PE
3477 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3478 The previous code was bogus. For example, next_almost_prime (32)
3479 returned 39, which is undesirable as it is a multiple of 3; and
3480 next_almost_prime (24) returned 25, which is a multiple of 5 so
3481 why was the code bothering to check for multiples of 7?
3482
80e88859
PE
3483 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3484
4a2f0ad6
PE
3485 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3486
f66c7cf8
PE
3487 Variadic C functions now count arguments with ptrdiff_t.
3488 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3489 Back then I didn't know that the Emacs coding style prefers signed int.
3490 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3491 were being counted with int, which may truncate counts on 64-bit
3492 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3493 * lisp.h (struct Lisp_Subr.function.aMANY)
3494 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3495 Arg counts are now ptrdiff_t, not size_t.
3496 All variadic functions and their callers changed accordingly.
3497 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3498 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3499 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3500 * callint.c (Fcall_interactively): Check arg count for overflow,
3501 to avoid potential buffer overrun. Use signed char, not 'int',
3502 for 'varies' array, so that we needn't bother to check its size
3503 calculation for overflow.
3504 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3505 * eval.c (apply_lambda):
3506 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3507 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3508 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3509
a1759b76
PE
3510 * callint.c (Fcall_interactively): Don't use index var as event count.
3511
d96be9fc
PE
3512 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3513 * mem-limits.h (SIZE): Remove; no longer used.
3514
a690a978 3515 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3516
578c21e6
PE
3517 Remove unnecessary casts.
3518 * xterm.c (x_term_init):
3519 * xfns.c (x_set_border_pixel):
3520 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3521 These aren't needed now that we assume ANSI C.
3522
96f53c6c
PE
3523 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3524 It's more likely to cause problems (due to unsigned overflow)
3525 than to cure them.
3526
83c77d31
PE
3527 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3528
ee2079f1
PE
3529 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3530
6da65536
PE
3531 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3532
7147c4a4
PE
3533 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3534
193e32d9
PE
3535 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3536
e5533da6
PE
3537 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3538
9910e595
PE
3539 GLYPH_CODE_FACE returns EMACS_INT, not int.
3540 * dispextern.h (merge_faces):
3541 * xfaces.c (merge_faces):
01103c44
PE
3542 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3543 Don't assume EMACS_INT fits in int.
9910e595 3544
2638320e
PE
3545 * character.h (CHAR_VALID_P): Remove unused parameter.
3546 * fontset.c, lisp.h, xdisp.c: All uses changed.
3547
045eb8d9
PE
3548 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3549
c1f134b5
PE
3550 * fns.c (concat): Minor tuning based on overflow analysis.
3551 This doesn't fix any bugs. Use int to hold character, instead
3552 of constantly refetching from Emacs object. Use XFASTINT, not
3553 XINT, for value known to be a character. Don't bother comparing
3554 a single byte to 0400, as it's always less.
3555
395fcb93 3556 * floatfns.c (Fexpt):
327eeec8
PE
3557 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3558
abbd3d23
PE
3559 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3560 for characters.
3561
684a03ef
PE
3562 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3563
0fed43f3
PE
3564 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3565 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3566 incorrectly succeed when S was a string, because 4294967386 was
3567 truncated before it was used.
3568
8fd02eb7
PE
3569 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3570 Otherwise, an out-of-range integer could cause undefined behavior
3571 on a 64-bit host.
3572
f8c86b69
PE
3573 * composite.c: Use int, not EMACS_INT, for characters.
3574 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3575 EMACS_INT, for values that are known to be in character range.
3576 This doesn't fix any bugs but is the usual style inside Emacs and
3577 may generate better code on 32-bit machines.
3578
34206dd2
PE
3579 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3580 This is for reasons similar to the recent CHAR_STRING fix.
3581 * charset.c (Fencode_char): Check that character arg is actually
3582 a character. Pass an int to ENCODE_CHAR.
3583 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3584 wider than 'int', as a compile-time check to prevent future regressions
3585 in this area.
3586
c5958d4c 3587 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3588
3589 Make sure a 64-bit char is never passed to CHAR_STRING.
3590 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3591 by silently ignoring the top 32 bits, allowing some values
3592 that were far too large to be valid characters.
3593 * character.h: Include <verify.h>.
3594 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3595 arguments are no wider than unsigned, as a compile-time check
3596 to prevent future regressions in this area.
3597 * data.c (Faset):
01103c44 3598 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3599 (Fsubst_char_in_region):
3600 * fns.c (concat):
3601 * xdisp.c (decode_mode_spec_coding):
3602 Adjust to CHAR_STRING's new requirement.
3603 * editfns.c (Finsert_char, Fsubst_char_in_region):
3604 * fns.c (concat): Check that character args are actually
3605 characters. Without this test, these functions did the wrong
3606 thing with wildly out-of-range values on 64-bit hosts.
3607
d37ca623
PE
3608 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3609 These casts should not be needed on 32-bit hosts, either.
3610 * keyboard.c (read_char):
3611 * lread.c (Fload): Remove casts to unsigned.
3612
ea204efb
PE
3613 * lisp.h (UNSIGNED_CMP): New macro.
3614 This fixes comparison bugs on 64-bit hosts.
3615 (ASCII_CHAR_P): Use it.
3616 * casefiddle.c (casify_object):
01103c44 3617 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3618 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3619 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3620 * dispextern.h (FACE_FROM_ID):
3621 * keyboard.c (read_char): Use UNSIGNED_CMP.
3622
41cb286c
PE
3623 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3624 not to EMACS_INT, to avoid GCC warning.
3625
4a1b9832
PE
3626 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3627
55daad71
PE
3628 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3629 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3630 isn't needed on 32-bit machines.
8f95c75c 3631
01103c44
PE
3632 * buffer.c (Fgenerate_new_buffer_name):
3633 Use EMACS_INT for count, not int.
0ceccced 3634 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3635
3636 * data.c (Qcompiled_function): Now static.
3637
c6f072e7
PE
3638 * window.c (window_body_lines): Now static.
3639
20ce5912
PE
3640 * image.c (gif_load): Rename local to avoid shadowing.
3641
9c4c5f81
PE
3642 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3643 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3644 * alloc.c (make_save_value): Integer argument is now of type
3645 ptrdiff_t, not int.
3646 (mark_object): Use ptrdiff_t, not int.
3647 * lisp.h (pD): New macro.
3648 * print.c (print_object): Use it.
3649
c0c5c8ae
PE
3650 * alloc.c: Use EMACS_INT, not int, to count objects.
3651 (total_conses, total_markers, total_symbols, total_vector_size)
3652 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3653 (total_free_floats, total_floats, total_free_intervals)
3654 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3655 Now EMACS_INT, not int. All uses changed.
3656 (Fgarbage_collect): Compute overall total using a double, so that
3657 integer overflow is less likely to be a problem. Check for overflow
3658 when converting back to an integer.
5a25e253
PE
3659 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3660 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3661 These were 'int' variables that could overflow on 64-bit hosts;
3662 they were never used, so remove them instead of repairing them.
211a0b2a 3663 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3664 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3665 Previously, this ceilinged at INT_MAX, but that doesn't work on
3666 64-bit machines.
e46bb31a 3667 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3668
c78baabf 3669 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3670 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3671 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3672 when a (possibly-narrower) signed value would do just as well.
3673 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3674
c9d624c6
PE
3675 * alloc.c: Catch some string size overflows that we were missing.
3676 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3677 for convenience in STRING_BYTES_MAX.
3678 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3679 The definition here is exact; the one in lisp.h was approximate.
3680 (allocate_string_data): Check for string overflow. This catches
3681 some instances we weren't catching before. Also, it catches
3682 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3683 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3684 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3685
c9d624c6
PE
3686 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3687 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3688 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3689
353032ce
PE
3690 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3691
2bccce07
PE
3692 * alloc.c (Fmake_string): Check for out-of-range init.
3693
0ac30604
SM
36942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3695
3696 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3697
c195f2de
JD
36982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3699
3700 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3701 xg_get_default_scrollbar_width.
3702
3703 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3704 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3705 (style_changed_cb): Call update_theme_scrollbar_width and call
3706 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3707 all frames (Bug#8505).
3708 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3709 Call gtk_window_set_resizable if HAVE_GTK3.
3710 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3711 and height if HAVE_GTK3 (Bug#8505).
3712 (scroll_bar_width_for_theme): New variable.
3713 (update_theme_scrollbar_width): New function.
3714 (xg_get_default_scrollbar_width): Move code to
3715 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3716 (xg_initialize): Call update_theme_scrollbar_width.
3717
3718 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3719
3720 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3721
e10ac9f1
MR
37222011-06-12 Martin Rudalics <rudalics@gmx.at>
3723
3724 * frame.c (make_frame): Call other_buffer_safely instead of
3725 other_buffer.
3726
3727 * window.c (temp_output_buffer_show): Call display_buffer with
3728 second argument Vtemp_buffer_show_specifiers and reset latter
3729 immediately after the call.
3730 (Vtemp_buffer_show_specifiers): New variable.
3731 (auto_window_vscroll_p, next_screen_context_lines)
3732 (Vscroll_preserve_screen_position): Remove leading asterisks from
3733 doc-strings.
3734
2d3c217e 37352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3736
7b7f97e8 3737 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3738 * buffer.c (Qclone_number): Remove for now, as it's unused.
3739 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3740 (record_buffer): Remove unused local.
3741 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3742 (set_frame_buffer_list): Remove; unused.
3743 * frame.h (other_visible_frames): Remove decl.
3744 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3745 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3746 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3747 if HAVE_GPM.
3748 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3749 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3750 Define only if HAVE_GPM.
3751 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3752 (update_hints_inhibit): Remove; never set. All uses removed.
3753 * widgetprv.h (emacsFrameClassRec): Remove decl.
3754 * window.c (delete_deletable_window): Now returns void, since it
3755 wasn't returning anything.
3756 (compare_window_configurations): Remove unused locals.
3757 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3758 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3759 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3760 the same widths as pointers. This follows up on the 2011-05-06 patch.
3761 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3762 * xterm.h: Likewise.
3763 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3764
1384b89e
JB
37652011-06-12 Juanma Barranquero <lekktu@gmail.com>
3766
3767 * makefile.w32-in: Update dependencies.
3768 (LISP_H): Add lib/intprops.h.
3769
1100a63c
CY
37702011-06-11 Chong Yidong <cyd@stupidchicken.com>
3771
3772 * image.c (gif_load): Add animation frame delay to the metadata.
3773 (syms_of_image): Use DEFSYM. New symbol `delay'.
3774
6198ccd0
MR
37752011-06-11 Martin Rudalics <rudalics@gmx.at>
3776
3777 * window.c (delete_deletable_window): Re-add.
3778 (Fset_window_configuration): Rewrite to handle dead buffers and
3779 consequently deletable windows.
3780 (window_tree, Fwindow_tree): Remove. Supply functionality in
3781 window.el.
3782 (compare_window_configurations): Simplify code.
3783
b6e3633c
AS
37842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3785
1ab0dee5
AS
3786 * image.c (imagemagick_load_image): Fix type mismatch.
3787 (Fimagemagick_types): Likewise.
3788
b6e3633c
AS
3789 * window.h (replace_buffer_in_windows): Declare.
3790
9397e56f
MR
37912011-06-11 Martin Rudalics <rudalics@gmx.at>
3792
3793 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3794 Qclone_number. Remove external declaration of Qdelete_window.
3795 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3796 code.
640c8776
SM
3797 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3798 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3799 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3800 buffer list implementation.
3801 (other_buffer_safely): New function.
3802 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3803 calls to replace_buffer_in_windows and
3804 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3805 if allowed.
3806 (record_buffer): Inhibit quitting and rewrite using quittable
3807 functions. Run Qbuffer_list_update_hook if allowed.
3808 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3809 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3810 Move switch-to-buffer to window.el.
9397e56f
MR
3811 (bury-buffer): Move to window.el.
3812 (Vbuffer_list_update_hook): New variable.
3813
3814 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3815 section.
3816
3817 * window.h (resize_frame_windows): Move up in code.
3818 (Fwindow_frame): Remove EXFUN.
3819 (replace_buffer_in_all_windows): Remove prototype.
3820 (replace_buffer_in_windows_safely): Add prototype.
3821
3822 * window.c: Declare Qdelete_window static again. Move down
3823 declaration of select_count.
3824 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3825 (Fother_window): Move to window.el.
3826 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3827 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3828 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3829 window.el.
3830 (replace_buffer_in_windows): Implement by calling
3831 Qreplace_buffer_in_windows.
3832 (replace_buffer_in_all_windows): Remove with some functionality
3833 moved into replace_buffer_in_windows_safely.
3834 (replace_buffer_in_windows_safely): New function.
3835 (select_window_norecord, select_frame_norecord): Move in front
3836 of run_window_configuration_change_hook. Remove now obsolete
3837 declarations.
640c8776
SM
3838 (Fset_window_buffer): Rewrite doc-string.
3839 Call Qrecord_window_buffer.
9397e56f
MR
3840 (keys_of_window): Move binding for other-window to window.el.
3841
b50691aa
CY
38422011-06-11 Chong Yidong <cyd@stupidchicken.com>
3843
3844 * dispextern.h (struct image): Replace data member, whose int_val
3845 and ptr_val fields were not used by anything, with a single
3846 lisp_val object.
3847
3848 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3849 (gif_clear_image, gif_load, imagemagick_load_image)
3850 (gs_clear_image, gs_load): Callers changed.
3851
3f754b86
PE
38522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3853
cca69397
PE
3854 * buffer.h: Include <time.h>, for time_t.
3855 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3856
109e28d0
PE
3857 Fix minor problems found by static checking.
3858
60737f02
PE
3859 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3860
4b66faf3
PE
3861 Make identifiers static if they are not used in other modules.
3862 * data.c (Qcompiled_function, Qframe, Qvector):
3863 * image.c (QimageMagick, Qsvg):
3864 * minibuf.c (Qmetadata):
3865 * window.c (resize_window_check, resize_root_window): Now static.
3866 * window.h (resize_window_check, resize_root_window): Remove decls.
3867
109e28d0
PE
3868 * window.c (window_deletion_count, delete_deletable_window):
3869 Remove; unused.
46a4ce9e
PE
3870 (window_body_lines): Now static.
3871 (Fdelete_other_windows_internal): Mark vars as initialized.
3872 Make sure 'resize_failed' is initialized.
3873 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3874 (resize_window_apply): Remove unused local.
3875 * window.h (delete_deletable_window): Remove decl.
3876
109e28d0 3877 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3878 (imagemagick_load_image): Fix pointer signedness problem by changing
3879 last arg from unsigned char * to char *. All uses changed.
3880 Also, fix a local for similar reasons.
3881 Remove unused locals. Remove locals to avoid shadowing.
3882 (fn_rsvg_handle_free): Remove; unused.
3883 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3884 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3885
3f754b86
PE
3886 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3887
2547adb1
CY
38882011-06-10 Chong Yidong <cyd@stupidchicken.com>
3889
3890 * image.c (gif_load): Fix omitted cast error introduced by
3891 2011-06-06 change.
3892
2c8e37d4
MR
38932011-06-10 Martin Rudalics <rudalics@gmx.at>
3894
3895 * window.h (resize_proportionally, orig_total_lines)
3896 (orig_top_line): Remove from window structure.
3897 (set_window_height, set_window_width, change_window_heights)
3898 (Fdelete_window): Remove prototypes.
3899 (resize_frame_windows): Remove duplicate declaration.
3900
440a42e3
EZ
39012011-06-10 Eli Zaretskii <eliz@gnu.org>
3902
3903 * window.h (resize_frame_windows, resize_window_check)
3904 (delete_deletable_window, resize_root_window)
3905 (resize_frame_windows): Declare prototypes.
3906
3907 * window.c (resize_window_apply): Make definition be "static" to
3908 match the prototype.
3909
562dd5e9
MR
39102011-06-10 Martin Rudalics <rudalics@gmx.at>
3911
3912 * window.c: Remove declarations of Qwindow_size_fixed,
3913 window_min_size_1, window_min_size_2, window_min_size,
3914 size_window, window_fixed_size_p, enlarge_window, delete_window.
3915 Remove static from declaration of Qdelete_window, it's
3916 temporarily needed by Fbury_buffer.
3917 (replace_window): Don't assign orig_top_line and
3918 orig_total_lines.
3919 (Fdelete_window, delete_window): Remove. Window deletion is
3920 handled by window.el.
640c8776
SM
3921 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3922 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3923 (Fdelete_other_windows): Remove. Deleting other windows is
3924 handled by window.el.
3925 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3926 handled in window.el.
3927 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3928 Window minimum sizes are handled in window.el.
3929 (shrink_windows, size_window, set_window_height)
3930 (set_window_width, change_window_heights, window_height)
3931 (window_width, CURBEG, CURSIZE, enlarge_window)
3932 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3933 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3934 handled in window.el.
3935 (make_dummy_parent): Rename to make_parent_window and give it a
3936 second argument horflag.
3937 (make_window): Don't set resize_proportionally any more.
3938 (Fsplit_window): Remove. Windows are split in window.el.
3939 (save_restore_action, save_restore_orig_size)
3940 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3941 Resize mini windows in window.el.
3942 (grow_mini_window, shrink_mini_window): Implement by calling
3943 Qresize_root_window_vertically, resize_window_check and
3944 resize_window_apply.
640c8776
SM
3945 (saved_window, Fset_window_configuration, save_window_save):
3946 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3947 resize_proportionally.
3948 (window_min_height, window_min_width): Move to window.el.
3949 (keys_of_window): Move bindings for delete-other-windows,
3950 split-window, delete-window and enlarge-window to window.el.
3951
3952 * buffer.c: Temporarily extern Qdelete_window.
3953 (Fbury_buffer): Temporarily call Qdelete_window instead of
3954 Fdelete_window (Fbury_buffer will move to window.el soon).
3955
3956 * frame.c (set_menu_bar_lines_1): Remove code handling
3957 orig_top_line and orig_total_lines.
3958
3959 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3960 set_window_height but set heights directly.
3961 (change_frame_size_1): Use resize_frame_windows.
3962
3963 * xdisp.c (init_xdisp): Don't use set_window_height but set
3964 heights directly.
3965
640c8776
SM
3966 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3967 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3968 run_window_configuration_change_hook.
3969
3970 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3971 instead of change_window_heights and run
3972 run_window_configuration_change_hook.
3973
1a13852e
MR
39742011-06-09 Martin Rudalics <rudalics@gmx.at>
3975
3976 * window.c (replace_window): Rename second argument REPLACEMENT to
3977 NEW. New third argument SETFLAG. Rewrite.
3978 (delete_window, make_dummy_parent): Call replace_window with
3979 third argument 1.
3980 (window_list_1): Move down in code.
3981 (run_window_configuration_change_hook): Move set_buffer part
3982 before select_frame_norecord part in order to unwind correctly.
3983 Rename count1 to count.
3984 (recombine_windows, delete_deletable_window, resize_root_window)
3985 (Fdelete_other_windows_internal)
3986 (Frun_window_configuration_change_hook, make_parent_window)
3987 (resize_window_check, resize_window_apply, Fresize_window_apply)
3988 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3989 (Fdelete_window_internal, Fresize_mini_window_internal):
3990 New functions.
1a13852e
MR
3991 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3992
f3d1777e
MR
39932011-06-08 Martin Rudalics <rudalics@gmx.at>
3994
496e208e
MR
3995 * window.h (window): Add some new members to window structure -
3996 normal_lines, normal_cols, new_total, new_normal, clone_number,
3997 splits, nest, prev_buffers, next_buffers.
3998 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3999 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4000
f3d1777e
MR
4001 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4002 Remove.
496e208e
MR
4003 (make_dummy_parent): Set new members of windows structure.
4004 (make_window): Move down in code. Handle new members of window
4005 structure.
4006 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4007 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4008 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4009 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4010 (Fset_window_next_buffers, Fset_window_clone_number):
4011 New functions.
496e208e
MR
4012 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4013 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4014 Doc-string fixes.
4015 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4016 Argument WINDOW can be now internal window too.
4017 (Fwindow_use_time): Move up in code.
4018 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4019 Rewrite doc-string.
4020 (Fset_window_configuration, saved_window)
4021 (Fcurrent_window_configuration, save_window_save): Handle new
4022 members of window structure.
b9e809c2
MR
4023 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4024 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4025 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4026 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4027 Qget_mru_window, Qresize_root_window,
4028 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4029 Qauto_buffer_name; staticpro them.
f3d1777e 4030
abde8f8c
MR
40312011-06-07 Martin Rudalics <rudalics@gmx.at>
4032
4033 * window.c (Fwindow_total_size, Fwindow_left_column)
4034 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4035 (Fwindow_list_1): New functions.
4036 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4037 (Fwindow_width, Fscroll_left, Fscroll_right):
4038 Use window_body_cols instead of window_box_text_cols.
4039 (delete_window, Fset_window_configuration):
4040 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4041 (delete_all_subwindows): Take a window as argument and not a
4042 structure. Rewrite.
190b47e6
MR
4043 (window_loop): Remove handling of GET_LRU_WINDOW and
4044 GET_LARGEST_WINDOW.
4045 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4046
4047 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4048 window_box_text_cols. delete_all_subwindows now takes a
4049 Lisp_Object as argument.
abde8f8c 4050
640c8776
SM
4051 * indent.c (compute_motion, Fcompute_motion):
4052 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4053
fa8a67e6
MR
4054 * frame.c (delete_frame): Call delete_all_subwindows with root
4055 window as argument.
4056
a54e3482
DC
40572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4058
4059 * fns.c (Fputhash): Document return value.
4060
60002bf5
CY
40612011-06-06 Chong Yidong <cyd@stupidchicken.com>
4062
4063 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4064
0c671da6 40652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4066
b862a52a 4067 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4068
be44ca6c
PE
4069 Check for overflow when converting integer to cons and back.
4070 * charset.c (Fdefine_charset_internal, Fdecode_char):
4071 Use cons_to_unsigned to catch overflow.
4072 (Fencode_char): Use INTEGER_TO_CONS.
4073 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4074 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4075 * data.c (long_to_cons, cons_to_long): Remove.
4076 (cons_to_unsigned, cons_to_signed): New functions.
4077 These signal an error for invalid or out-of-range values.
4078 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4079 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4080 * font.c (Ffont_variation_glyphs):
4081 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4082 * lisp.h: Include <intprops.h>.
4083 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4084 (cons_to_signed, cons_to_unsigned): New decls.
4085 (long_to_cons, cons_to_long): Remove decls.
4086 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4087 (Fprimitive_undo): Use CONS_TO_INTEGER.
4088 * xfns.c (Fx_window_property): Likewise.
4089 * xselect.c: Include <limits.h>.
4090 (x_own_selection, selection_data_to_lisp_data):
4091 Use INTEGER_TO_CONS.
4092 (x_handle_selection_request, x_handle_selection_clear)
4093 (x_get_foreign_selection, Fx_disown_selection_internal)
4094 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4095 (lisp_data_to_selection_data): Use cons_to_unsigned.
4096 (x_fill_property_data): Use cons_to_signed.
4097 Report values out of range.
4098
d1f3d2af
PE
4099 Check for buffer and string overflow more precisely.
4100 * buffer.h (BUF_BYTES_MAX): New macro.
4101 * lisp.h (STRING_BYTES_MAX): New macro.
4102 * alloc.c (Fmake_string):
4103 * character.c (string_escape_byte8):
4104 * coding.c (coding_alloc_by_realloc):
4105 * doprnt.c (doprnt):
4106 * editfns.c (Fformat):
4107 * eval.c (verror):
4108 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4109 since they may not be the same number.
4110 * editfns.c (Finsert_char):
4111 * fileio.c (Finsert_file_contents):
4112 Likewise for BUF_BYTES_MAX.
4113
dd52fcea
PE
4114 * image.c: Use ptrdiff_t, not int, for sizes.
4115 (slurp_file): Switch from int to ptrdiff_t.
4116 All uses changed.
4117 (slurp_file): Check that file size fits in both size_t (for
4118 malloc) and ptrdiff_t (for sanity and safety).
4119
7f9bbdbb
PE
4120 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4121 if b->modtime has its maximal value.
4122
dfe18f82
PE
4123 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4124
84acfcf0
PE
4125 Don't assume time_t can fit into int.
4126 * buffer.h (struct buffer.modtime): Now time_t, not int.
4127 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4128 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4129
ccd9a01a
PE
4130 Minor fixes for signed vs unsigned integers.
4131 * character.h (MAYBE_UNIFY_CHAR):
4132 * charset.c (maybe_unify_char):
4133 * keyboard.c (read_char, reorder_modifiers):
4134 XINT -> XFASTINT, since the integer must be nonnegative.
4135 * ftfont.c (ftfont_spec_pattern):
4136 * keymap.c (access_keymap, silly_event_symbol_error):
4137 XUINT -> XFASTINT, since the integer must be nonnegative.
4138 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4139 since it makes no difference and we prefer signed.
4140 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4141 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4142 nonnegative.
4143
d6d100dd
SM
41442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4145
4146 * window.h (Fwindow_frame): Declare.
4147
2b6148e4
PE
41482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4149
4150 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4151 (SPARE_MEMORY): Always define.
4152 (LARGE_REQUEST): Remove.
4153 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4154
f230ecc9
MR
41552011-06-06 Martin Rudalics <rudalics@gmx.at>
4156
727e958e
MR
4157 * lisp.h: Move EXFUNS for Fframe_root_window,
4158 Fframe_first_window and Fset_frame_selected_window to window.h.
4159
4160 * window.h: Move EXFUNS for Fframe_root_window,
4161 Fframe_first_window and Fset_frame_selected_window here from
4162 lisp.h.
4163
4164 * frame.c (Fwindow_frame, Fframe_first_window)
4165 (Fframe_root_window, Fframe_selected_window)
4166 (Fset_frame_selected_window): Move to window.c.
4167 (Factive_minibuffer_window): Move to minibuf.c.
4168 (Fother_visible_frames_p): New function.
4169
4170 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4171
f230ecc9
MR
4172 * window.c (decode_window, decode_any_window): Move up in code.
4173 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4174 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4175 (Fwindow_buffer): Move up and rewrite doc-string.
4176 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4177 (Fwindow_prev): New functions.
727e958e
MR
4178 (Fwindow_frame): Move here from frame.c. Accept any window as
4179 argument.
4180 (Fframe_root_window, Fframe_first_window)
4181 (Fframe_selected_window): Move here from frame.c. Accept frame
4182 or arbitrary window as argument. Update doc-strings.
4183 (Fminibuffer_window): Move up in code.
4184 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4185 (Fset_frame_selected_window): Move here from frame.c.
4186 Marginal rewrite.
727e958e
MR
4187 (Fselected_window, select_window, Fselect_window): Move up in
4188 code. Minor doc-string fixes.
f230ecc9 4189
4d09bcf6
PE
41902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4191
4192 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4193 Do not assume that spare memory exists; that assumption is valid
4194 only if SYSTEM_MALLOC.
4195 (LARGE_REQUEST): New macro, so that the issue of large requests
4196 is separated from the issue of spare memory.
4197
810928a2
AS
41982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4199
172418ad
AS
4200 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4201 format. (Bug#8806)
4202
43f862f7
AS
4203 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4204
810928a2
AS
4205 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4206 before statements.
4207
a059fe24
JD
42082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4209
4210 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4211
4212 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4213
4214 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4215 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4216
989bf368
JB
42172011-06-05 Juanma Barranquero <lekktu@gmail.com>
4218
4219 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4220
4b80f674
CY
42212011-06-04 Chong Yidong <cyd@stupidchicken.com>
4222
4223 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4224 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4225 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4226 New error handlers.
4b80f674
CY
4227 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4228 Obey Vx_select_enable_clipboard_manager. Catch errors in
4229 x_clipboard_manager_save (Bug#8779).
4230 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4231 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4232
99a33b77 42332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4234
4235 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4236
99a33b77 42372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4238
4239 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4240 in the current matrix if keep_current_p is non-zero.
4241
8264569d
EZ
42422011-06-04 Eli Zaretskii <eliz@gnu.org>
4243
4244 * bidi.c (bidi_level_of_next_char): Fix last change.
4245
57f97249
EZ
42462011-06-03 Eli Zaretskii <eliz@gnu.org>
4247
fec2107c 4248 Support bidi reordering of text covered by display properties.
57f97249 4249
fec2107c
EZ
4250 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4251 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4252 (bidi_cache_search, bidi_cache_iterator_state)
4253 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4254 (bidi_level_of_next_char, bidi_move_to_visually_next):
4255 Support character positions inside a run of characters covered by a
fec2107c
EZ
4256 display string.
4257 (bidi_paragraph_init, bidi_resolve_explicit_1)
4258 (bidi_level_of_next_char): Call bidi_fetch_char and
4259 bidi_fetch_char_advance instead of FETCH_CHAR and
4260 FETCH_CHAR_ADVANCE.
4261 (bidi_init_it): Initialize new members.
4262 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4263 definitions.
4264 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4265 instead of using explicit *_CHAR codes.
d6d100dd
SM
4266 (bidi_resolve_explicit, bidi_resolve_weak):
4267 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4268 bidirectional text is supported only in multibyte buffers.
4269 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4270 it to initialize the frame_window_p member of struct bidi_it.
4271 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4272 (bidi_resolve_explicit, bidi_resolve_weak)
4273 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4274 bidi_it->nchars is non-positive.
4275 (bidi_level_of_next_char): Don't try to lookup the cache for the
4276 next/previous character if nothing is cached there yet, or if we
4277 were just reseat()'ed to a new position.
c40e2fb2 4278
0e14fe90
EZ
4279 * xdisp.c (set_cursor_from_row): Set start and stop points
4280 according to the row's direction when priming the loop that looks
4281 for the glyph on which to display cursor.
4282 (single_display_spec_intangible_p): Function deleted.
4283 (display_prop_intangible_p): Reimplement to call
4284 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4285 Accept 3 additional arguments needed by handle_display_spec.
4286 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4287 values: lists, `(when COND...)' forms, etc.
4288 (single_display_spec_string_p): Support property values that are
4289 lists with the argument STRING its top-level element.
4290 (display_prop_string_p): Fix the condition for processing a
4291 property that is a list to be consistent with handle_display_spec.
fec2107c 4292 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4293 last portion of handle_display_prop.
4294 (compute_display_string_pos): Accept additional argument
4295 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4296 value of a `display' property is a "replacing spec".
4297 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4298 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4299 the display property, but just return a value indicating whether
4300 the display property will replace the characters it covers.
4301 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4302 frame_window_p members of struct bidi_it.
d6d100dd
SM
4303 (compute_display_string_pos, compute_display_string_end):
4304 New functions.
fec2107c
EZ
4305 (push_it): Accept second argument POSITION, where pop_it should
4306 jump to continue iteration.
4307 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4308
fec2107c
EZ
4309 * keyboard.c (adjust_point_for_property): Adjust the call to
4310 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4311
4312 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4313 (bidi_init_it): Update prototypes.
4314 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4315 (compute_display_string_pos, compute_display_string_end):
4316 Declare prototypes.
fec2107c
EZ
4317 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4318 EMACS_INT.
fc6f18ce 4319
40087514 43202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4321
57f53182
PE
4322 Malloc failure behavior now depends on size of allocation.
4323 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4324 * lisp.h: Change signatures accordingly.
4325 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4326 All callers changed. (Bug#8762)
4327
4328 * gnutls.c: Use Emacs's memory allocators.
4329 Without this change, the gnutls library would invoke malloc etc.
4330 directly, which causes problems on non-SYNC_INPUT hosts, and which
4331 runs afoul of improving memory_full behavior. (Bug#8761)
4332 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4333 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4334 xfree instead of the default malloc, realloc, free.
4335 (Fgnutls_boot): No need to check for memory allocation failure,
4336 since xmalloc does that for us.
4337
ac32cd99 4338 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4339 * category.c (hash_get_category_set):
4340 * ccl.c (ccl_driver):
4341 * charset.c (Fdefine_charset_internal):
4342 * charset.h (struct charset.hash_index):
4343 * composite.c (get_composition_id, gstring_lookup_cache)
4344 (composition_gstring_put_cache):
4345 * composite.h (struct composition.hash_index):
4346 * dispextern.h (struct image.hash):
4347 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4348 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4349 (hashfn_equal, hashfn_user_defined, make_hash_table)
4350 (maybe_resize_hash_table, hash_lookup, hash_put)
4351 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4352 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4353 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4354 * image.c (make_image, search_image_cache, lookup_image)
4355 (xpm_put_color_table_h):
4356 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4357 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4358 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4359 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4360 * alloc.c (allocate_vectorlike):
4361 Check for overflow in vector size calculations.
4362 * ccl.c (ccl_driver):
4363 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4364 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4365 need to be updated by these changes.
40087514
PE
4366 * fns.c (make_hash_table, maybe_resize_hash_table):
4367 Check for integer overflow with large hash tables.
0de4bb68
PE
4368 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4369 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4370 (SXHASH_REDUCE): New macro.
4371 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4372 Use it instead of discarding useful hash info with large hash values.
4373 (sxhash_float): New function.
4374 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4375 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4376 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4377 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4378 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4379 Adjust signatures to match updated version of code.
4380 (consing_since_gc): Now EMACS_INT, since a single hash table can
4381 use more than INT_MAX bytes.
4382
698d32e2
DN
43832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4384
4385 Make it possible to build with GCC-4.6+ -O2 -flto.
4386
4387 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4388
fd6fa53f
SM
43892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4390
4391 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4392 Call minibuffer-inactive-mode.
4393
864db017
JB
43942011-05-31 Juanma Barranquero <lekktu@gmail.com>
4395
4396 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4397 Update dependencies.
4398
2ad0baf4
DN
43992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4400
4401 * data.c (init_data): Remove code for UTS, this system is not
4402 supported anymore.
4403
4fcc2638
DN
44042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4405
4406 Don't force ./temacs to start in terminal mode.
4407
4408 * frame.c (make_initial_frame): Initialize faces in all cases, not
4409 only when CANNOT_DUMP is defined.
4410 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4411
c56e0fd5
DN
44122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4413
4414 * dispnew.c (add_window_display_history): Use const for the string
4415 pointer. Remove declaration, not needed.
4416
333d54da 44172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4418
55d4c1b2 4419 Use 'inline', not 'INLINE'.
333d54da 4420 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4421 * alloc.c, fontset.c (INLINE): Remove.
4422 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4423 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4424 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4425 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4426 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4427
738db178
DN
44282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4429
4430 Make it possible to run ./temacs.
4431
4432 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4433 syms_of_callproc does the same thing. Remove test for
4434 "initialized", do it in the caller.
4435 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4436
620c53a6
SM
44372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4438
4439 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4440 (read_minibuf): Use get_minibuffer.
4441 (syms_of_minibuf): Use DEFSYM.
4442 (Qmetadata): New var.
4443 * data.c (Qbuffer): Don't make it static.
4444 (syms_of_data): Use DEFSYM.
4445
e003a292
PE
44462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4447
4448 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4449 (CCL_CODE_MIN): New macro.
4450
ed008a6d
PE
44512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4452
3687c2ef
PE
4453 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4454
ed008a6d
PE
4455 * eval.c (Qdebug): Now static.
4456 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4457 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4458 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4459
d66c4c7c
CY
44602011-05-29 Chong Yidong <cyd@stupidchicken.com>
4461
4462 * image.c: Various fixes to ImageMagick code comments.
4463 (Fimagemagick_types): Doc fix.
4464
5fbc2025
PE
44652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4466
0196f88a
PE
4467 Minor fixes prompted by GCC 4.6.0 warnings.
4468
4469 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4470
5fbc2025
PE
4471 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4472 (x_clipboard_manager_save_all): Move extern decl to ...
4473 * xterm.h: ... here, so that it can be checked for consistency.
4474
1dd3c2d9
CY
44752011-05-29 Chong Yidong <cyd@stupidchicken.com>
4476
4477 * xselect.c (x_clipboard_manager_save_frame)
4478 (x_clipboard_manager_save_all): New functions.
4479 (Fx_clipboard_manager_save): Lisp function deleted.
4480
4481 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4482 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4483
4484 * xterm.h: Update prototype.
4485
5ba6571d
WX
44862011-05-28 William Xu <william.xwl@gmail.com>
4487
4488 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4489 exiting (Bug#8239).
4490
3eaff834
JM
44912011-05-28 Jim Meyering <meyering@redhat.com>
4492
e1900994 4493 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4494 * fns.c (to_uchar): Define.
4495 (crypto_hash_function): Use it to convert some newly-signed
4496 variables to unsigned, to avoid sign-extension bugs. For example,
4497 without this change, (md5 "truc") would evaluate to
4498 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4499 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4500 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4501
0f6990a7
PE
45022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4503
4504 Integer overflow fixes.
c8a9ca5a 4505
08686060
PE
4506 * dbusbind.c: Serial number integer overflow fixes.
4507 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4508 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4509 to hold a serial number that is too large for a fixnum.
4510 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4511 Check for serial numbers out of range. Decode any serial number
59568bf0 4512 that was so large that it became a float. (Bug#8722)
08686060 4513
2d1fc3c7
PE
4514 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4515 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4516 Use XFASTINT rather than XUINT when numbers are nonnegative.
4517 (xd_append_arg, Fdbus_method_return_internal):
4518 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4519 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4520 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4521 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4522 (Bug#8722)
2d1fc3c7 4523
c8a9ca5a
PE
4524 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4525
519e1d69
PE
4526 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4527
30569699
PE
4528 ccl: add integer overflow checks
4529 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4530 (IN_INT_RANGE): New macros.
4531 (ccl_driver): Use them to check for integer overflow when
4532 decoding a CCL program. Many of the new checks are whether XINT (x)
4533 fits in int; it doesn't always, on 64-bit hosts. The new version
4534 doesn't catch all possible integer overflows, but it's an
847044ea 4535 improvement. (Bug#8719)
30569699 4536
c11285dc
PE
4537 * alloc.c (make_event_array): Use XINT, not XUINT.
4538 There's no need for unsigned here.
4539
fdccd48e
PE
4540 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4541 This follows up to the 2011-05-06 change that substituted uintptr_t
4542 for EMACS_INT. This case wasn't caught back then.
4543
37910ab2
PE
4544 Rework Fformat to avoid integer overflow issues.
4545 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4546 now (part of C89). Include <verify.h>.
4547 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4548 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4549 (Fformat): Avoid the prepass trying to compute sizes; it was only
4550 approximate and thus did not catch overflow reliably. Instead, walk
4551 through the format just once, formatting and computing sizes as we go,
4552 checking for integer overflow at every step, and allocating a larger
4553 buffer as needed. Keep track separately whether the format is
4554 multibyte. Keep only the most-recently calculated precision, rather
4555 than them all. Record whether each argument has been converted to
4556 string. Use EMACS_INT, not int, for byte and char and arg counts.
4557 Support field widths and precisions larger than INT_MAX. Avoid
4558 sprintf's undefined behavior with conversion specifications such as %#d
4559 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4560 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4561 formatting out-of-range floating point numbers with int
9173deec 4562 formats. (Bug#8668)
37910ab2 4563
2e6578fb
PE
4564 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4565
0ae6bdee
PE
4566 * data.c: Avoid integer truncation in expressions involving floats.
4567 * data.c: Include <intprops.h>.
4568 (arith_driver): When there's an integer overflow in an expression
4569 involving floating point, convert the integers to floating point
4570 so that the resulting value does not suffer from catastrophic
4571 integer truncation. For example, on a 64-bit host (* 4
4572 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4573 Do not rely on undefined behavior after integer overflow.
4574
de883a70
PE
4575 merge count_size_as_multibyte, parse_str_to_multibyte
4576 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4577 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4578 Check for integer overflow.
4579 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4580 since it's now a duplicate of the other. This is more of
4581 a character than a buffer op, so better that it's in character.c.
4582 * fns.c, print.c: Adjust to above changes.
4583
2ff916cb
PE
45842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4585
4586 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4587
f1b54466
PE
45882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4589
fb1ac845
PE
4590 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4591 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4592 (x_clipboard_manager_save): Now static.
4593 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4594
f1b54466
PE
4595 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4596 (crypto_hash_function): Now static.
4597 Fix pointer signedness problems. Avoid unnecessary initializations.
4598
a9f737ee
CY
45992011-05-27 Chong Yidong <cyd@stupidchicken.com>
4600
4601 * termhooks.h (Vselection_alist): Make it terminal-local.
4602
4603 * terminal.c (create_terminal): Initialize it.
4604
4605 * xselect.c: Support for clipboard managers.
4606 (Vselection_alist): Move to termhooks.h as terminal-local var.
4607 (LOCAL_SELECTION): New macro.
4608 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4609 (symbol_to_x_atom): Remove gratuitous arg.
4610 (x_handle_selection_request, lisp_data_to_selection_data)
4611 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4612 (x_own_selection, x_get_local_selection, x_convert_selection):
4613 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4614 (some_frame_on_display): Delete unused function.
4615 (Fx_own_selection_internal, Fx_get_selection_internal)
4616 (Fx_disown_selection_internal, Fx_selection_owner_p)
4617 (Fx_selection_exists_p): New optional frame arg.
4618 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4619 (x_handle_selection_clear): Don't treat other terminals with the
4620 same keyboard specially. Use the terminal-local Vselection_alist.
4621 (x_clear_frame_selections): Use Frun_hook_with_args.
4622
4623 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4624
4625 * xterm.h: Add support for those atoms.
4626
e067f0c1
CY
46272011-05-26 Chong Yidong <cyd@stupidchicken.com>
4628
4629 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4630 (converted_selections, conversion_fail_tag): New global variables.
4631 (x_selection_request_lisp_error): Free the above.
4632 (x_get_local_selection): Remove unnecessary code.
4633 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4634 of converted selections stored in converted_selections.
4635 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4636 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4637 (x_convert_selection): New function.
4638 (x_handle_selection_event): Simplify.
4639 (x_get_foreign_selection): Don't ignore incoming requests while
4640 waiting for an answer; this will fail when we implement
4641 SAVE_TARGETS, and seems unnecessary anyway.
4642 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4643 (Vx_sent_selection_functions): Doc fix.
4644
0f4aebc0
LL
46452011-05-26 Leo Liu <sdl.web@gmail.com>
4646
4647 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4648
e61124cd
YM
46492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4650
4651 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4652
4653 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4654 for fringe update if it has periodic bitmap.
ac389d0c 4655 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4656 and fringe_bitmap_periodic_p.
4657
4658 * fringe.c (get_fringe_bitmap_data): New function.
4659 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4660 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4661 row. Mark glyph row for fringe update if periodicity changed.
4662
4663 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4664 for fringe update unless it has periodic bitmap.
4665
f16d9837
KH
46662011-05-25 Kenichi Handa <handa@m17n.org>
4667
4668 * xdisp.c (get_next_display_element): Set correct it->face_id for
4669 a static composition.
4670
e1b90ef6
LL
46712011-05-24 Leo Liu <sdl.web@gmail.com>
4672
4673 * deps.mk (fns.o):
4674 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4675
4676 * fns.c (crypto_hash_function, Fsha1): New function.
4677 (Fmd5): Use crypto_hash_function.
4678 (syms_of_fns): Add Ssha1.
4679
7400048f
PE
46802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4681
4682 * gnutls.c: Remove unused macros.
4683 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4684 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4685 Remove macros that are defined and never used.
4686 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4687
abb71cf4
CY
46882011-05-22 Chong Yidong <cyd@stupidchicken.com>
4689
4690 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4691 (Fx_get_selection_internal): Minor cleanup.
4692 (Fx_own_selection_internal): Rename arguments for consistency with
4693 select.el.
4694
6307db39
PE
46952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4696
4697 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4698
f3d4e0a4
CY
46992011-05-22 Chong Yidong <cyd@stupidchicken.com>
4700
4701 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4702
4d8ade89
YM
47032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4704
4705 * dispnew.c (scrolling_window): Don't exclude the case that the
4706 last enabled row in the desired matrix touches the bottom boundary.
4707
32078c8d
GM
47082011-05-21 Glenn Morris <rgm@gnu.org>
4709
4710 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4711 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4712 and add some more files.
32078c8d 4713
7285dc67
EZ
47142011-05-20 Eli Zaretskii <eliz@gnu.org>
4715
4716 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4717 report_file_error introduced by the change from 2011-05-07.
4718
89d1bd22
PE
47192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4720
4721 * systime.h (Time): Define only if emacs is defined.
4722 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4723 where the include path doesn't have X11/X.h by default. See
4724 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4725
e23640bb 47262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4727
4728 * composite.c (find_automatic_composition): Fix previous change.
4729
b9704ad9
GM
47302011-05-20 Glenn Morris <rgm@gnu.org>
4731
4732 * lisp.mk: New file, split from Makefile.in.
4733 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4734 (shortlisp): Remove.
4735 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4736
4a720484
GM
47372011-05-19 Glenn Morris <rgm@gnu.org>
4738
4739 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4740 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4741 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4742 (lisp): Set the order to that of loadup.el.
4743 (shortlisp): Make it a copy of $lisp.
4744 (SOME_MACHINE_LISP): Remove.
4745 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4746 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4747
a28d4396
KH
47482011-05-18 Kenichi Handa <handa@m17n.org>
4749
4750 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4751 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4752 (find_automatic_composition): Mostly rewrite for efficiency.
4753
a2b1fa8e
JB
47542011-05-18 Juanma Barranquero <lekktu@gmail.com>
4755
4756 * makefile.w32-in: Update dependencies.
4757
8e1f5610
CS
47582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4759
4760 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4761 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4762
7025ee00 47632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4764
cdfa6eab
PE
4765 Fix some integer overflow issues, such as string length overflow.
4766
06d6db33
PE
4767 * insdel.c (count_size_as_multibyte): Check for string overflow.
4768
2b4560a8
PE
4769 * character.c (lisp_string_width): Check for string overflow.
4770 Use EMACS_INT, not int, for string indexes and lengths; in
4771 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4772 the resulting string length overflows an EMACS_INT; instead,
4773 report a string overflow if no precision given. When checking for
4774 precision exhaustion, use a check that cannot possibly have
4775 integer overflow. (Bug#8675)
4776 * character.h (lisp_string_width): Adjust to new signature.
4777
cb93f9be
PE
4778 * alloc.c (string_overflow): New function.
4779 (Fmake_string): Use it. This doesn't change behavior, but saves
4780 a few bytes and will simplify future changes.
4781 * character.c (string_escape_byte8): Likewise.
4782 * lisp.h (string_overflow): New decl.
4783
1a1f3366
PE
4784 Fixups, following up to the user-interface timestamp change.
4785 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4786 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4787 * msdos.c (mouse_get_pos): Likewise.
4788 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4789 * w32gui.h (Time): Define by including "systime.h" rather than by
4790 declaring it ourselves. (Bug#8664)
4791
d4e3e4d3
PE
4792 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4793 * image.c (clear_image_cache): Likewise.
4794
f6a24d19
PE
4795 * term.c (term_mouse_position): Don't assume time_t wraparound.
4796
08dc5ae6
PE
4797 Be more systematic about user-interface timestamps.
4798 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4799 and sometimes 'EMACS_UINT', to represent these timestamps.
4800 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4801 This makes the code easier to follow, and makes it easier to catch
4802 integer overflow bugs such as Bug#8664.
4803 * frame.c (Fmouse_position, Fmouse_pixel_position):
4804 Use Time, not unsigned long, for user-interface timestamps.
4805 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4806 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4807 * keyboard.h (last_event_timestamp): Likewise.
4808 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4809 * menu.h (xmenu_show): Likewise.
4810 * term.c (term_mouse_position): Likewise.
4811 * termhooks.h (struct input_event.timestamp): Likewise.
4812 (struct terminal.mouse_position_hook): Likewise.
4813 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4814 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4815 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4816 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4817 what it was before.
4818 * menu.h, termhooks.h: Include "systime.h", for Time.
4819
8e55734a
PE
4820 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4821 Don't assume that the difference between two unsigned long values
4822 can fit into an integer. At this point, we know button_down_time
4823 <= event->timestamp, so the difference must be nonnegative, so
4824 there's no need to cast the result if double-click-time is
4825 nonnegative, as it should be; check that it's nonnegative, just in
4826 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4827 apart (about 25 days). (Bug#8664)
8e55734a 4828
841f1b75 4829 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4830 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4831
3e26f69c
PE
4832 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4833 that always fit in int. Use a sentinel instead of a counter, to
4834 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4835 * frame.h (struct frame): Use int for menu_bar_items_used
4836 instead of EMACS_INT, since it always fits in int.
3e26f69c 4837
5cc152c0
PE
4838 * menu.c (grow_menu_items): Check for int overflow.
4839
d89eb65e
PE
4840 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4841
5235bd3e
PE
4842 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4843 Before, the code was not consistent. These values cannot exceed
4844 2**31 - 1 so there's no need to make them unsigned.
4845 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4846 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4847 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4848 as modifiers.
4849 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4850
bc827e23
PE
4851 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4852 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4853 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4854 presumably because the widths might not match.
4855
78eb494e
PE
4856 * window.c (size_window): Avoid needless test at loop start.
4857
04f2d78b
CB
48582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4859
4860 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4861
d2fc7e3d 48622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4863
4864 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4865
d2fc7e3d 48662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4867
4868 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4869 `width' to `bar_area_x' and `bar_area_width', respectively.
4870 (x_scroll_run): Take account of fringe background extension.
4871
04f2d78b
CB
4872 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4873 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4874 `bar_area_width', respectively.
4875 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4876 background extension.
4877
79b70037
GM
48782011-05-10 Jim Meyering <meyering@redhat.com>
4879
4880 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4881
2f142cc5
JB
48822011-05-10 Juanma Barranquero <lekktu@gmail.com>
4883
4884 * image.c (Finit_image_library): Return t for built-in image types,
4885 like pbm and xbm. (Bug#8640)
4886
57679c86
AS
48872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4888
4889 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4890
888c9e86
EZ
48912011-05-07 Eli Zaretskii <eliz@gnu.org>
4892
b0512a1d
EZ
4893 * w32console.c (Fset_screen_color): Doc fix.
4894 (Fget_screen_color): New function.
4895 (syms_of_ntterm): Defsubr it.
4896
7285dc67
EZ
4897 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4898 unlink the temporary file if Fcall_process didn't create it in the
4899 first place.
4900 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4901 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4902 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4903 cue to call_process_cleanup not to close that handle.
4904
4d3fcc8e
BK
49052011-05-07 Ben Key <bkey76@gmail.com>
4906
4907 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4908 one of two shell specific rules, either bootstrap-temacs-CMD or
4909 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4910 to the previous implementation of the bootstrap-temacs rule.
4911 The bootstrap-temacs-CMD rule is similar to the previous
4912 implementation of the bootstrap-temacs rule except that it
4913 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4914 variable.
4915
4916 These changes, along with some changes to nt/configure.bat,
4917 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4918 earlier fix to add support for --cflags and --ldflags options
4919 that include quotes so that it works whether make uses cmd or
4920 sh as the shell.
4921
b4289b64
MA
49222011-05-06 Michael Albinus <michael.albinus@gmx.de>
4923
4924 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4925 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4926 is a constant.
4927 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4928 a string. Handle both cases.
4929 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4930 (Fdbus_register_method): Use Qinvalid_function.
4931
af4c0e28
JB
49322011-05-06 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * makefile.w32-in: Update dependencies.
4935 (LISP_H): Add inttypes.h and stdin.h.
4936 (PROCESS_H): Add unistd.h.
4937
c51453d9
EZ
49382011-05-06 Eli Zaretskii <eliz@gnu.org>
4939
4940 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4941 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4942
8ff0ac3c 49432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4944
4c4b566b
PE
4945 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4946
aab2b9b5
PE
4947 * term.c (vfatal): Remove stray call to va_end.
4948 It's not needed and the C Standard doesn't allow it here anyway.
4949
c378da0b
PE
4950 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4951 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4952
288b08c7
PE
4953 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4954 bytes.
4955
e3601888
PE
4956 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4957
db6c0e74
PE
4958 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4959
dd5963ea
PE
4960 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4961
88c9450f
PE
4962 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4963
2f9442b8
PE
4964 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4965
c032b5f8
PE
4966 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4967 * charset.c (Fdefine_charset_internal): Don't initialize
4968 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4969 32-bit int (Bug#8600).
a108c10b
PE
4970
4971 * lread.c (read_integer): Be more consistent with string-to-number.
4972 Use string_to_number to do the actual conversion; this avoids
4973 rounding errors and fixes some other screwups. Without this fix,
4974 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4975 (digit_to_number): Move earlier, for benefit of read_integer.
4976 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4977 not a digit in any supported base. (Bug#8602)
a108c10b 4978
ad5f9eea
PE
4979 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4980
aec1708a
PE
4981 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4982 to match comment at start of function. This also removes a
4983 GCC warning about overflow in a 32+64-bit port.
4984
47be4ab5
PE
4985 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4986
371cac43
PE
4987 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4988 Reported by Stefan Monnier in
4989 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4990 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4991 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4992
d01a7826
PE
4993 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4994 (EMACS_UINTPTR): Likewise, with uintptr_t.
4995
7fd47d5c
PE
4996 * lisp.h: Prefer 64-bit EMACS_INT if available.
4997 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4998 on 32-bit hosts that have 64-bit int, so that they can access
4999 large files.
122b0c86
PE
5000 However, temporarily disable this change unless the temporary
5001 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5002
8727937b
PE
5003 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5004
8ac068ac
PE
5005 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5006 This removes an assumption that EMACS_INT and long are the same
5007 width as pointers. The assumption is true for Emacs porting targets
5008 now, but we want to make other targets possible.
5009 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5010 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5011 In the rest of the code, change types of integers that hold casted
5012 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5013 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5014 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5015 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5016 No need to cast type when ORing.
5017 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5018 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5019 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5020 assume EMACS_INT is the same width as char *.
5021 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5022 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5023 Remove no-longer-needed casts.
5024 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5025 (xg_tool_bar_help_callback, xg_make_tool_item):
5026 Use EMACS_INTPTR to hold an integer
5027 that will be cast to void *; this can avoid a GCC warning
5028 if EMACS_INT is not the same width as void *.
5029 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5030 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5031 (current_message_1, set_message_1):
5032 Use a local to convert to proper width without a cast.
5033 * xmenu.c (dialog_selection_callback): Likewise.
5034
ede49d71
PE
5035 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5036 Also, don't assume VALBITS / RAND_BITS is less than 5,
5037 and don't rely on undefined behavior when shifting a 1 left into
5038 the sign bit.
5039 * lisp.h (get_random): Change signature to match.
5040
2f30ecd0
PE
5041 * lread.c (hash_string): Use size_t, not int, for hash computation.
5042 Normally we prefer signed values; but hashing is special, because
5043 it's better to use unsigned division on hash table sizes so that
5044 the remainder is nonnegative. Also, size_t is the natural width
5045 for hashing into memory. The previous code used 'int', which doesn't
5046 retain enough info to hash well into very large tables.
5047 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5048
2a866e7b
PE
5049 * dbusbind.c: Don't possibly lose pointer info when converting.
5050 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5051 Use XPNTR rather than XHASH, so that the high-order bits of
5052 the pointer aren't lost when converting through void *.
5053
51639eac
PE
5054 * eval.c (Fautoload): Don't double-shift a pointer.
5055
92394119
PE
5056 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5057
dbdb9a7c
JB
50582011-05-06 Juanma Barranquero <lekktu@gmail.com>
5059
5060 * gnutls.c (DEF_GNUTLS_FN):
5061 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5062
db7a0b4f
AS
50632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5064
5065 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5066 marker. (Bug#8610)
5067
f7ff1b0f 50682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5069
5070 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5071 New version that can reserve upto 2GB of heap space.
5072
f7ff1b0f 50732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5074
5075 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5076
639c109b
TZ
50772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5078
5079 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5080 `gnutls_certificate_set_x509_key_file'.
5081
d2127135
JB
50822011-05-05 Juanma Barranquero <lekktu@gmail.com>
5083
5084 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5085 Update dependencies.
5086
e968f4f3
JB
50872011-05-04 Juanma Barranquero <lekktu@gmail.com>
5088
5089 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5090 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5091 Remove unused parameter `fildes'.
5092 * process.c (read_process_output, send_process): Don't pass it.
5093
84d358f0
JB
50942011-05-04 Juanma Barranquero <lekktu@gmail.com>
5095
5096 Fix previous change: the library cache is defined in w32.c.
5097 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5098 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5099
0898ca10
JB
51002011-05-04 Juanma Barranquero <lekktu@gmail.com>
5101
5102 Implement dynamic loading of GnuTLS on Windows.
5103
5104 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5105 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5106 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5107 Declare.
5108
5109 * gnutls.c (Qgnutls_dll): Define.
5110 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5111 (gnutls_*): Declare function pointers.
5112 (init_gnutls_functions): New function to initialize function pointers.
5113 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5114 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5115 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5116 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5117 (emacs_gnutls_write, emacs_gnutls_read)
5118 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5119 (Fgnutls_available_p): New function.
5120 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5121 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5122 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5123
5124 * image.c: Include w32.h.
5125 (Vimage_type_cache): Delete.
5126 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5127 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5128 (w32_delayed_load): Move to w32.c.
5129
5130 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5131
5132 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5133 (w32_delayed_load): Move from image.c. When loading a library, record
5134 its filename in the :loaded-from property of the library id.
5135 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5136 Initialize and staticpro them.
5137 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5138
5139 * process.c: Include lisp.h before w32.h, not after.
5140 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5141 instead of gnutls_record_check_pending.
5142
5143 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5144
ff4de4aa
TZ
51452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5146
5147 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5148 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5149 as passed in.
5150
abe95abb
JD
51512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5152
5153 * xterm.c (x_set_frame_alpha): Do not set property on anything
5154 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5155
e16e55d4
JB
51562011-05-02 Juanma Barranquero <lekktu@gmail.com>
5157
5158 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5159
bafcf6a5
JB
51602011-05-02 Juanma Barranquero <lekktu@gmail.com>
5161
5162 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5163 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5164 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5165 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5166 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5167 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5168 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5169 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5170 (Qgnutls_bootprop_callbacks_verify): Make static.
5171
e7a6747f
AS
51722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5173
19ed11ba
AS
5174 * callproc.c: Indentation fixup.
5175
e7a6747f 5176 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5177 (wait_for_termination, interruptible_wait_for_termination):
5178 Move after wait_for_termination_1.
e7a6747f 5179
1ef14cb4
LMI
51802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5181
5182 * sysdep.c (interruptible_wait_for_termination): New function
5183 which is like wait_for_termination, but allows keyboard
5184 interruptions.
5185
5186 * callproc.c (Fcall_process): Add (:file "file") as an option for
5187 the STDOUT buffer.
5188 (Fcall_process_region): Ditto.
5189
330d880c
EZ
51902011-04-30 Eli Zaretskii <eliz@gnu.org>
5191
8db90b73
EZ
5192 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5193 rather than `XVECTOR (FOO)->size'.
5194
330d880c
EZ
5195 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5196 inttypes.h, as a gnulib replacement is used if it not available in
5197 system headers.
5198
15cbd324
EZ
51992011-04-21 Eli Zaretskii <eliz@gnu.org>
5200
5201 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5202 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5203 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5204
5205 * coding.c (coding_alloc_by_realloc): Error out if destination
5206 will grow beyond MOST_POSITIVE_FIXNUM.
5207 (decode_coding_emacs_mule): Abort if there isn't enough place in
5208 charbuf for the composition carryover bytes. Reserve an extra
5209 space for up to 2 characters produced in a loop.
5210 (decode_coding_iso_2022): Abort if there isn't enough place in
5211 charbuf for the composition carryover bytes.
5212
52132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5214
ae940cca
EZ
5215 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5216 aborting when %lld or %lll format is passed.
5217 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5218 %llo or %llx format is passed. (Bug#8545)
5219
03ab8921
EZ
5220 * window.c (window_scroll_line_based): Use a marker instead of
5221 simple variables to record original value of point. (Bug#7952)
5222
afda1437
EZ
5223 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5224 produced by %s or %c overflows available buffer space. (Bug#8545)
5225
f76dee0c
PE
52262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5227
5228 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5229 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5230
fdc5744d
JB
52312011-04-28 Juanma Barranquero <lekktu@gmail.com>
5232
5233 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5234
638f053a
JB
52352011-04-28 Juanma Barranquero <lekktu@gmail.com>
5236
5237 * keyboard.c (Qdelayed_warnings_hook): Define.
5238 (command_loop_1): Run `delayed-warnings-hook'
5239 if Vdelayed_warnings_list is non-nil.
5240 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5241 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5242
d178f871
EZ
52432011-04-28 Eli Zaretskii <eliz@gnu.org>
5244
5245 * doprnt.c (doprnt): Don't return value smaller than the buffer
5246 size if the message was truncated. (Bug#8545).
5247
b124fd93
JB
52482011-04-28 Juanma Barranquero <lekktu@gmail.com>
5249
5250 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5251 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5252
e810457d
PE
52532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5254
5255 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5256
ea51cceb
JB
52572011-04-27 Juanma Barranquero <lekktu@gmail.com>
5258
5259 * makefile.w32-in: Update dependencies.
5260
94dcfacf
EZ
52612011-04-27 Eli Zaretskii <eliz@gnu.org>
5262
5263 Improve `doprnt' and its usage. (Bug#8545)
5264 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5265 `format_end'. Remove support for %l as a conversion specifier.
5266 Don't use xrealloc. Improve diagnostics when the %l size modifier
5267 is used. Update the commentary.
5268
5269 * eval.c (verror): Simplify calculation of size_t.
5270
5271 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5272 messages.
5273
f61f41d7
PE
52742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5275
5276 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5277 change.
5278
96fb4434
PE
52792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5280
5281 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5282 This makes this file independent of the recent pseudovector change.
5283
671875da 52842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5285
69e9b5a3
PE
5286 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5287
b5f869a7 5288 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5289 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5290 Remove unused local.
c8926152 5291 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5292
841a1577 5293 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5294 GCC 4.6.0 optimizes based on type-based alias analysis.
5295 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5296 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5297 != &v->size, and therefore "v->size = 1; b->size = 2; return
5298 v->size;" must therefore return 1. This assumption is incorrect
5299 for Emacs, since it type-puns struct Lisp_Vector * with many other
5300 types. To fix this problem, this patch adds a new type struct
f904488f 5301 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5302 and pseudovectors, and helps optimizing compilers not get fooled
5303 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5304 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5305 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5306 the size member.
eab3844f
PE
5307 (XSETPVECTYPE): Rewrite in terms of new macro.
5308 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5309 This is a bit clearer, and further avoids the possibility of
5310 undesirable aliasing.
5311 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5312 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5313 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5314 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5315 (ASIZE): Now uses header.size rather than size.
5316 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5317 to avoid the hassle of writing XVECTOR (foo)->header.size.
5318 (struct vectorlike_header): New type.
eab3844f
PE
5319 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5320 object, to help avoid aliasing.
5321 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5322 (SUBRP): Likewise, since Lisp_Subr is a special case.
5323 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5324 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5325 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5326 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5327 changed to be "header.size" and "header.next".
5328 * buffer.h (struct buffer): Likewise.
5329 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5330 * frame.h (struct frame): Likewise.
5331 * process.h (struct Lisp_Process): Likewise.
5332 * termhooks.h (struct terminal): Likewise.
5333 * window.c (struct save_window_data, struct saved_window): Likewise.
5334 * window.h (struct window): Likewise.
5335 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5336 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5337 * buffer.c (init_buffer_once): Likewise.
5338 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5339 special case.
5340 * process.c (Fformat_network_address): Use local var for size,
5341 for brevity.
5342
0df1eac5
PE
5343 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5344
847ab9d1 5345 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5346 * data.c (atof): Remove decl; no longer used or needed.
5347 (digit_to_number): Move to lread.c.
5348 (Fstring_to_number): Use new string_to_number function, to be
5349 consistent with how the Lisp reader treats infinities and NaNs.
5350 Do not assume that floating-point numbers represent EMACS_INT
5351 without losing information; this is not true on most 64-bit hosts.
5352 Avoid double-rounding errors, by insisting on integers when
5353 parsing non-base-10 numbers, as the documentation specifies.
5354 * lisp.h (string_to_number): New decl, replacing ...
5355 (isfloat_string): Remove.
bc0a5c13 5356 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5357 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5358 appears to have been a coding error. Similarly, do not accept
5359 strings like +-1e0 as floating point numbers. Do not report
5360 overflow for integer overflows unless the base is not 10 which
5361 means we have no simple and reliable way to continue.
5362 Break out the floating-point parsing into a new
5363 function string_to_number, so that Fstring_to_number parses
5364 floating point numbers consistently with the Lisp reader.
04f2d78b 5365 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5366 (E_CHAR, EXP_INT): Remove, replacing with ...
5367 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5368 (string_to_number): New function, replacing isfloat_string.
5369 This function checks for valid syntax and produces the resulting
5370 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5371 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5372 so that overflow for non-base-10 numbers is reported only when
5373 there's no portable and simple way to convert to floating point.
452f4150 5374
67769ffc
PE
5375 * textprop.c (set_text_properties_1): Rewrite for clarity,
5376 and to avoid GCC warning about integer overflow.
5377
c20db43f
PE
5378 * intervals.h (struct interval): Use EMACS_INT for members
5379 where EMACS_UINT might cause problems. See
5380 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5381 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5382 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5383 All uses changed.
37aa2f85
PE
5384 (offset_intervals): Tell GCC not to worry about length overflow
5385 when negating a negative length.
c20db43f 5386
2538aa2f
PE
5387 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5388 (overrun_check_free): Likewise.
5389
f2d3008d
PE
5390 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5391 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5392 word size.
5393
ec8df744
PE
5394 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5395 (gnutls_make_error): Rename local to avoid shadowing.
5396 (gnutls_emacs_global_deinit): ifdef out; not used.
5397 (Fgnutls_boot): Use const for pointer to readonly storage.
5398 Comment out unused local. Fix pointer signedness problems.
5399
640ee02d
PE
5400 * lread.c (openp): Don't stuff size_t into an 'int'.
5401 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5402 about possible signed overflow.
5403
6048fb2a
PE
5404 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5405 (GDK_KEY_g): Don't define if already defined.
5406 (xg_prepare_tooltip): Avoid pointer signedness problem.
5407 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5408
fa3c87e1
PE
5409 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5410 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5411
2172544b
PE
5412 * xfns.c (Fx_window_property): Simplify a bit,
5413 to make a bit faster and to avoid GCC 4.6.0 warning.
5414 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5415
9b821a21
PE
5416 * fns.c (internal_equal): Don't assume size_t fits in int.
5417
3c616cfa
PE
5418 * alloc.c (compact_small_strings): Tighten assertion a little.
5419
c2982e87
PE
5420 Replace pEd with more-general pI, and fix some printf arg casts.
5421 * lisp.h (pI): New macro, generalizing old pEd macro to other
5422 conversion specifiers. For example, use "...%"pI"d..." rather
5423 than "...%"pEd"...".
5424 (pEd): Remove. All uses replaced with similar uses of pI.
5425 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5426 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5427 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5428 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5429 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5430 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5431 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5432 64-bit hosts.
5433 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5434 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5435 * print.c (safe_debug_print, print_object): Likewise.
5436 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5437 to int.
6f04d126
PE
5438 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5439 avoiding the 0 flag, which is not portable.
c2982e87
PE
5440 * process.c (Fmake_network_process): Use pI to avoid cast.
5441 * region-cache.c (pp_cache): Likewise.
5442 * xdisp.c (decode_mode_spec): Likewise.
5443 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5444 behavior on 64-bit hosts with printf arg.
6f04d126 5445 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5446 (x_stop_queuing_selection_requests): Likewise.
5447 (x_get_window_property): Don't truncate byte count to an 'int'
5448 when tracing.
0b432f21 5449
5e073ec7
PE
5450 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5451 here, since it parses constructs like leading '-' and spaces,
5452 which are not wanted; and it overflows with large numbers.
5453 Instead, simply match F[0-9]+, which is what is wanted anyway.
5454
36372bf9
PE
5455 * alloc.c: Remove unportable assumptions about struct layout.
5456 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5457 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5458 (allocate_vectorlike, make_pure_vector): Use the new macros,
5459 plus offsetof, to remove unportable assumptions about struct layout.
5460 These assumptions hold on all porting targets that I know of, but
5461 they are not guaranteed, they're easy to remove, and removing them
5462 makes further changes easier.
5463
0b432f21
PE
5464 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5465 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5466 (string_overrun_cookie): Now const. Use initializers that
5467 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5468 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5469 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5470 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5471 multiple of sizeof (EMACS_INT); it need not be, if
5472 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5473 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5474
895009e1
JB
54752011-04-26 Juanma Barranquero <lekktu@gmail.com>
5476
5477 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5478
6a7a1b0b
TZ
54792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5480
5481 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5482 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5483 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5484
841a1577 54852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5486
5487 * lisp.h (Qdebug): List symbol.
895009e1 5488 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5489 * keyboard.c (debug-on-event): New variable.
5490 (handle_user_signal): Break into debugger when debug-on-event
5491 matches the current signal symbol.
5492
f2d3ba6f
DN
54932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5494
5495 * alloc.c (check_sblock, check_string_bytes)
5496 (check_string_free_list): Convert to standard C.
5497
42ce4c63
TZ
54982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5499
5500 * w32.c (emacs_gnutls_push): Fix typo.
5501
825cd63c
EZ
55022011-04-25 Eli Zaretskii <eliz@gnu.org>
5503
fb11d64d
EZ
5504 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5505 "cast to pointer from integer of different size".
5506
825cd63c
EZ
5507 Improve doprnt and its use in verror. (Bug#8545)
5508 * doprnt.c (doprnt): Document the set of format control sequences
5509 supported by the function. Use SAFE_ALLOCA instead of always
5510 using `alloca'.
5511
5512 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5513 is one byte too soon. Don't use xrealloc; instead xfree and
5514 xmalloc anew.
5515
e061a11b
TZ
55162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5517
5518 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5519 callbacks stage.
5520
5521 * gnutls.c: Renamed global_initialized to
5522 gnutls_global_initialized. Added internals for the
5523 :verify-hostname-error, :verify-error, and :verify-flags
5524 parameters of `gnutls-boot' and documented those parameters in the
5525 docstring. Start callback support.
9173deec
JB
5526 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5527 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5528 on error. Return error code.
e061a11b
TZ
5529 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5530 (emacs_gnutls_read): Likewise.
5531 (Fgnutls_boot): Return handshake error code.
5532 (emacs_gnutls_handle_error): New function.
5533 (wsaerror_to_errno): Likewise.
5534
5535 * w32.h (emacs_gnutls_pull): Add prototype.
5536 (emacs_gnutls_push): Likewise.
5537
5538 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5539 (emacs_gnutls_push): Likewise.
5540
55412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5542
5543 * process.c (wait_reading_process_output): Check if GnuTLS
5544 buffered some data internally if no FDs are set for TLS
5545 connections.
5546
5547 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5548 (LIBS): Link to USER_LIBS.
5549 ($(BLD)/gnutls.$(0)): New target.
5550
fa6996bc
EZ
55512011-04-24 Eli Zaretskii <eliz@gnu.org>
5552
eb35682e
EZ
5553 * xdisp.c (handle_single_display_spec): Rename the
5554 display_replaced_before_p argument into display_replaced_p, to
5555 make it consistent with the commentary. Fix typos in the
5556 commentary.
5557
e2ad650c
EZ
5558 * textprop.c (syms_of_textprop): Remove dead code.
5559 (copy_text_properties): Delete obsolete commentary about an
5560 interface that was deleted long ago. Fix typos in the description
5561 of arguments.
5562
1b2de274
EZ
5563 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5564 to changes in oldXMenu/XMenu.h from 2011-04-16.
5565 <menu_help_message, prev_menu_help_message>: Constify.
5566 (IT_menu_make_room): menu->help_text is now `const char **';
5567 adjust.
5568
5569 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5570 to changes in oldXMenu/XMenu.h from 2011-04-16.
5571 (struct XMenu): Declare `help_text' `const char **'.
5572
5573 * xfaces.c <Qunspecified>: Make extern again.
5574
5575 * syntax.c: Include sys/types.h before including regex.h, as
5576 required by Posix.
5577
762b15be
EZ
5578 * doc.c (get_doc_string): Improve the format passed to `error'.
5579
5580 * doprnt.c (doprnt): Improve commentary.
5581
5582 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5583
5584 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5585 them with etags.
5586
f1052e5d
EZ
5587 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5588 changes in globals.h immediately force recompilation.
762b15be
EZ
5589 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5590 $(CURDIR)/s/ms-w32.h.
5591 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5592
fa6996bc
EZ
5593 * character.c (Fchar_direction): Function deleted.
5594 (syms_of_character): Don't defsubr it.
5595 <char-direction-table>: Deleted.
5596
e6c3da20
EZ
55972011-04-23 Eli Zaretskii <eliz@gnu.org>
5598
5599 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5600 * doprnt.c: Include limits.h.
5601 (SIZE_MAX): New macro.
04f2d78b
CB
5602 (doprnt): Return a size_t value. 2nd arg is now size_t.
5603 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5604 Improve overflow protection. Support `l' modifier for integer
5605 conversions. Support %l conversion. Don't assume an EMACS_INT
5606 argument for integer conversions and for %c.
5607
5608 * lisp.h (doprnt): Restore prototype.
5609
5610 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5611 $(SRC)/character.h.
5612
5613 * Makefile.in (base_obj): Add back doprnt.o.
5614
5615 * deps.mk (doprnt.o): Add back prerequisites.
5616 (callint.o): Depend on character.h.
5617
5618 * eval.c (internal_lisp_condition_case): Include the handler
5619 representation in the error message.
5620 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5621 when breaking from the loop.
5622
5623 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5624
5625 * callint.c (Fcall_interactively): When displaying error message
5626 about invalid control letter, pass the character's codepoint, not
5627 a pointer to its multibyte form. Improve display of the character
5628 in octal and display also its hex code.
5629
5630 * character.c (char_string): Use %x to display the (unsigned)
5631 codepoint of an invalid character, to avoid displaying a bogus
5632 negative value.
5633
5634 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5635 `error', not SYMBOL_NAME itself.
5636
5637 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5638 character arguments to `error'.
5639
5640 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5641 to `error' in error message about FINAL_CHAR argument. Make sure
5642 FINAL_CHAR is a character, and use %c when it is passed as
5643 argument to `error'.
5644
4ffd0d6b 56452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5646
5647 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5648
5649 * w32.c: Include <time.h>.
5650 (sys_localtime): New function.
5651
4ffd0d6b 56522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5653
5654 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5655
4ffd0d6b 5656 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5657
4ffd0d6b 56582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5659
4ffd0d6b
GM
5660 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5661 zombies (Bug#8467).
aac0c6e3 5662
04c56954
EZ
56632011-04-19 Eli Zaretskii <eliz@gnu.org>
5664
5665 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5666 gl_state.e_property when gl_state.object is Qt.
5667
5668 * insdel.c (make_gap_larger): Remove limitation of buffer size
5669 to <= INT_MAX.
5670
16a43933
CY
56712011-04-18 Chong Yidong <cyd@stupidchicken.com>
5672
5673 * xdisp.c (lookup_glyphless_char_display)
5674 (produce_glyphless_glyph): Handle cons cell entry in
5675 glyphless-char-display.
5676 (Vglyphless_char_display): Document it.
5677
5678 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5679 glyphless-char-display.
5680
4581706e
CY
56812011-04-17 Chong Yidong <cyd@stupidchicken.com>
5682
5683 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5684
5685 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5686
5687 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5688 definition for no-X builds.
5689
4887c6e2 56902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5691
fd35b6f9
PE
5692 Static checks with GCC 4.6.0 and non-default toolkits.
5693
5c1ccb01
PE
5694 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5695
006c5daa
PE
5696 * process.c (keyboard_bit_set): Define only if SIGIO.
5697 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5698 (send_process): Repair possible setjmp clobbering.
5699
efc736d3
PE
5700 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5701
4e2fe2e6
PE
5702 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5703
f97334a2
PE
5704 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5705
4e75f29d
PE
5706 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5707 Define only if needed.
5708
90efadd1
PE
5709 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5710 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5711 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5712
3c647824
PE
5713 * dispextern.h (struct redisplay_interface): Rename param
5714 to avoid shadowing.
e264f262 5715 * termhooks.h (struct terminal): Likewise.
761383f4 5716 * xterm.c (xembed_send_message): Likewise.
3c647824 5717
b58c5c4a
PE
5718 * insdel.c (make_gap_smaller): Define only if
5719 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5720
cad59032
PE
5721 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5722 it.
5723
c339dc2e
PE
5724 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5725 so that we aren't warned about unused symbols.
5726
91a3e27b
PE
5727 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5728
399c71d3 5729 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5730
8ffc96f5
PE
5731 * xfns.c (x_real_positions): Mark locals as initialized.
5732
eef9bc79
PE
5733 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5734
098db9dd
PE
5735 * xterm.c: Fix problems found by static analysis with other toolkits.
5736 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5737 (x_dispatch_event): Declare static if USE_GTK, and
5738 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5739 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5740 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5741 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5742 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5743
eb18f6cc
PE
5744 * xmenu.c (menu_help_callback): Pointer type fixes.
5745 Use const pointers when pointing at readonly data. Avoid pointer
5746 signedness clashes.
5747 (FALSE): Remove unused macro.
5748 (update_frame_menubar): Remove unused decl.
5749
1fe72bf8
PE
5750 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5751
60d9e1db
PE
5752 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5753 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5754 (single_menu_item): Rename local to avoid shadowing.
5755
39261c26
PE
5756 * keyboard.c (make_lispy_event): Remove unused local var.
5757
018c5e19
PE
5758 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5759 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5760
63d2b86e
PE
5761 * bitmaps: Change bitmaps from unsigned char back to the X11
5762 compatible char. Avoid the old compiler warnings about
5763 out-of-range initializers by using, for example, '\xab' rather
5764 than 0xab.
5765
aefd87e1
PE
5766 * xgselect.c (xgselect_initialize): Check vs interface
5767 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5768
bf501fb9
PE
5769 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5770
e9829fdf
PE
5771 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5772 to read-only memory.
5773
1086c095
PE
5774 * fns.c (vector): Remove; this old hack is no longer needed.
5775
2baccd04 5776 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5777 Remove unused var.
dde42981 5778 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5779
72391843 5780 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5781
436c16df 5782 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5783 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5784 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5785
92bb796d 5786 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5787 (x_term_init): Remove local to avoid shadowing.
92bb796d 5788
764430a3 5789 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5790
5791 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5792 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5793
d1dfb56c
EZ
57942011-04-16 Eli Zaretskii <eliz@gnu.org>
5795
c4354cb4
EZ
5796 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5797
d1dfb56c
EZ
5798 Fix regex.c, syntax.c and friends for buffers > 2GB.
5799 * syntax.h (struct gl_state_s): Declare character position members
5800 EMACS_INT.
5801
5802 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5803
04f2d78b
CB
5804 * textprop.c (verify_interval_modification, interval_of):
5805 Declare arguments EMACS_INT.
d1dfb56c
EZ
5806
5807 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5808 EMACS_INT.
5809
5810 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5811
5812 * indent.c (Fvertical_motion): Local variable it_start is now
5813 EMACS_INT.
5814
5815 * regex.c (re_match, re_match_2, re_match_2_internal)
5816 (bcmp_translate, regcomp, regexec, print_double_string)
5817 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5818 (re_compile_pattern, re_exec): Declare arguments and local
5819 variables `size_t' and `ssize_t' and return values `regoff_t', as
5820 appropriate.
5821 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5822 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5823 <compile_stack_type>: `size' and `avail' are now `size_t'.
5824
5825 * regex.h <regoff_t>: Use ssize_t, not int.
5826 (re_search, re_search_2, re_match, re_match_2): Arguments that
5827 specify buffer/string position and length are now ssize_t and
5828 size_t. Return type is regoff_t.
5829
613052cd
BK
58302011-04-16 Ben Key <bkey76@gmail.com>
5831
5832 * nsfont.m: Fixed bugs in ns_get_family and
5833 ns_descriptor_to_entity that were caused by using free to
5834 deallocate memory blocks that were allocated by xmalloc (via
5835 xstrdup). This caused Emacs to crash when compiled with
5836 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5837 --enable-checking=xmallocoverrun). xfree is now used to
5838 deallocate these memory blocks.
5839
4170f62f 58402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5841
71b41406
PE
5842 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5843
9587a89d
PE
5844 emacs_write: Accept and return EMACS_INT for sizes.
5845 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5846 et seq.
5847 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5848 Accept and return EMACS_INT.
5849 (emacs_gnutls_write): Return the number of bytes written on
5850 partial writes.
5851 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5852 (emacs_read, emacs_write): Remove check for negative size, as the
5853 Emacs source code has been audited now.
9587a89d
PE
5854 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5855 (emacs_read, emacs_write): Use it.
273a5f82
PE
5856 * process.c (send_process): Adjust to the new signatures of
5857 emacs_write and emacs_gnutls_write. Do not attempt to store
5858 a byte offset into an 'int'; it might overflow.
9587a89d 5859 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5860
3e047f51
PE
5861 * sound.c: Don't assume sizes fit in 'int'.
5862 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5863 Return EMACS_INT, not int.
3e047f51 5864 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5865 Accept EMACS_INT, not int.
5866 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5867 record read return values.
5868
cc39a9db
BK
58692011-04-15 Ben Key <bkey76@gmail.com>
5870
c9d0ec6d
JB
5871 * keyboard.c (Qundefined): Don't declare static since it is used
5872 in nsfns.m.
5873 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5874 static since they are used in nsfont.m.
cc39a9db 5875
6c60eb9f
SM
58762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5877
5878 * process.c (Qprocessp): Don't declare static.
5879 * lisp.h (Qprocessp): Declare again.
5880
7990b61a
JB
58812011-04-15 Juanma Barranquero <lekktu@gmail.com>
5882
5883 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5884
5d4cb038
PE
58852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5886
8bd7b830 5887 Improve C-level modularity by making more things 'static'.
cd64ea1d 5888
e3b27b31
PE
5889 Don't publish debugger-only interfaces to other modules.
5890 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5891 (verify_bytepos, count_markers): Move decls to the only modules
5892 that need them.
5893 * region-cache.h (pp_cache): Likewise.
5894 * window.h (check_all_windows): Likewise.
5895 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5896
5d4cb038
PE
5897 * sysdep.c (croak): Now static, if
5898 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5899 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5900
5901 * alloc.c (refill_memory_reserve): Now static if
5902 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5903 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5904
e87b6180
PE
5905 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5906 Define only if USE_LUCID.
5907
ac64929e
PE
5908 * xrdb.c (x_customization_string, x_rm_string): Now static.
5909
6f37259d
PE
5910 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5911 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5912
1683e3ab
PE
5913 * xdisp.c (draw_row_with_mouse_face): Now static.
5914 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5915
de9c2632
PE
5916 * window.h (check_all_windows): Mark externally visible.
5917
2b96acb7
PE
5918 * window.c (window_deletion_count): Now static.
5919
5920 * undo.c: Make symbols static if they're not exported.
5921 (last_undo_buffer, last_boundary_position, pending_boundary):
5922 Now static.
5923
50436f33
PE
5924 * textprop.c (interval_insert_behind_hooks): Now static.
5925 (interval_insert_in_front_hooks): Likewise.
5926
64520e5c
PE
5927 * term.c: Make symbols static if they're not exported.
5928 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5929 (max_frame_lines, tty_set_terminal_modes):
5930 (tty_reset_terminal_modes, tty_turn_off_highlight):
5931 (get_tty_terminal): Now static.
5932 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5933 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5934 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5935 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5936 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5937
1fa53021
PE
5938 * sysdep.c: Make symbols static if they're not exported.
5939 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5940 Now static.
5941 (sigprocmask_set, full_mask): Remove; unused.
5942 (wait_debugging): Mark as visible.
5943 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5944 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5945
d4b43b22
PE
5946 * syntax.c (syntax_temp): Define only if !__GNUC__.
5947
b7c513d0
PE
5948 * sound.c (current_sound_device, current_sound): Now static.
5949
989b29ad
PE
5950 * search.c (searchbufs, searchbuf_head): Now static.
5951
13a55a78
PE
5952 * scroll.c (scroll_cost): Remove; unused.
5953 * dispextern.h (scroll_cost): Remove decl.
5954
de68a1fc
PE
5955 * region-cache.h (pp_cache): Mark as externally visible.
5956
40ccffa6
PE
5957 * process.c: Make symbols static if they're not exported.
5958 (process_tick, update_tick, create_process, chan_process):
5959 (Vprocess_alist, proc_buffered_char, datagram_access):
5960 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5961 (deactivate_process): Mark defn as static, as well as decl.
5962 * lisp.h (create_process): Remove decl.
5963 * process.h (chan_process, Vprocess_alist): Remove decls.
5964
ad64fc97
PE
5965 * print.c: Make symbols static if they're not exported.
5966 (print_depth, new_backquote_output, being_printed, print_buffer):
5967 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5968 (print_interval, print_number_index, initial_stderr_stream):
5969 Now static.
5970 * lisp.h (Fprinc): Remove decl.
5971 (debug_output_compilation_hack): Mark as externally visible.
5972
adddb265
PE
5973 * sysdep.c (croak): Move decl from here to syssignal.h.
5974 * syssignal.h (croak): Put it here, so the API can be checked when
5975 'croak' is called from dissociate_if_controlling_tty.
5976
1717ede2
PE
5977 * minibuf.c: Make symbols static if they're not exported.
5978 (minibuf_save_list, choose_minibuf_frame): Now static.
5979 * lisp.h (choose_minibuf_frame): Remove decl.
5980
fa5fb2bc
PE
5981 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5982
1e3890d1
PE
5983 * lread.c: Make symbols static if they're not exported.
5984 (read_objects, initial_obarray, oblookup_last_bucket_number):
5985 Now static.
5986 (make_symbol): Remove; unused.
5987 * lisp.h (initial_obarray, make_symbol): Remove decls.
5988
8a1414fa
PE
5989 * keyboard.c: Make symbols static if they're not exported.
5990 (single_kboard, recent_keys_index, total_keys, recent_keys):
5991 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5992 (this_single_command_key_start, echoing, last_auto_save):
5993 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5994 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5995 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5996 (Vlispy_mouse_stem, double_click_count):
5997 Now static.
5998 (force_auto_save_soon): Define only if SIGDANGER.
5999 (ignore_mouse_drag_p): Now static if
6000 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6001 (print_help): Remove; unused.
6002 (stop_character, last_timer_event): Mark as externally visible.
6003 * keyboard.h (ignore_mouse_drag_p): Declare only if
6004 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6005 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6006 * lisp.h (echoing): Remove decl.
6007 (force_auto_save_soon): Declare only if SIGDANGER.
6008 * xdisp.c (redisplay_window): Simplify code, to make it more
6009 obvious that ignore_mouse_drag_p is not accessed if !defined
6010 USE_GTK && !defined HAVE_NS.
6011
93ea6e8f
PE
6012 * intervals.c: Make symbols static if they're not exported.
6013 (merge_properties_sticky, merge_interval_right, delete_interval):
6014 Now static.
6015 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6016
77382fcc
PE
6017 * insdel.c: Make symbols static if they're not exported.
6018 However, leave prepare_to_modify_buffer alone. It's never
6019 called from outside this function, but that appears to be a bug.
6020 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6021 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6022 (adjust_after_replace_noundo): Remove; unused.
6023 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6024 (signal_before_change): Remove decls.
77382fcc 6025
9306c32e
PE
6026 * indent.c (val_compute_motion, val_vmotion): Now static.
6027
cd44d2eb
PE
6028 * image.c: Make symbols static if they're not exported.
6029 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6030 if USE_GTK.
6031 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6032 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6033
ad9a7a06
PE
6034 * fringe.c (standard_bitmaps): Now static.
6035 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6036
81626931
PE
6037 * frame.c: Make symbols static if they're not exported.
6038 (x_report_frame_params, make_terminal_frame): Now static.
6039 (get_frame_param): Now static, unless HAVE_NS.
6040 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6041 (x_get_resource_string): Remove; not used.
6042 * frame.h (make_terminal_frame, x_report_frame_params):
6043 (x_get_resource_string); Remove decls.
6044 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6045 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6046
239f9db9
PE
6047 * font.c, fontset.c: Make symbols static if they're not exported.
6048 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6049 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6050 * font.c (font_close_object): Now static.
6051 * font.h (font_close_object): Remove.
6052 * fontset.c (FONTSET_OBJLIST): Remove.
6053 (free_realized_fontset) #if-0 the body, which does nothing.
6054 (face_suitable_for_char_p): #if-0, as it's never called.
6055 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6056 * xfaces.c (face_at_string_position):
6057 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6058 since 0 is always ASCII.
6059
dfcf3579
PE
6060 * fns.c (weak_hash_tables): Now static.
6061
5045092b
PE
6062 * fileio.c: Make symbols static if they're not exported.
6063 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6064 (Vwrite_region_annotation_buffers): Now static.
6065
57a96f5c
PE
6066 * eval.c: Make symbols static if they're not exported.
6067 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6068 * lisp.h (backtrace_list): Remove decl.
6069
35f08c38
PE
6070 * emacs.c: Make symbols static if they're not exported.
6071 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6072 (fatal_error_code, fatal_error_signal_hook, standard_args):
6073 Now static.
6074 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6075 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6076 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6077 * lisp.h (fatal_error_signal_hook): Remove decl.
6078 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6079
f44bd759
PE
6080 * editfns.c: Move a (normally-unused) function to its only use.
6081 * editfns.c, lisp.h (get_operating_system_release): Remove.
6082 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6083 worth the hassle of breaking this out.
6084
b532497d
PE
6085 * xterm.c: Make symbols static if they're not exported.
6086 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6087 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6088 (x_destroy_window, x_delete_display):
6089 Now static.
6090 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6091 (x_mouse_leave): Remove; unused.
6092 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6093 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6094 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6095 Remove decls.
6096 (x_mouse_leave): Declare only if WINDOWSNT.
6097 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6098 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6099 USE_X_TOOLKIT.
6100
1675728f
PE
6101 * ftxfont.c: Make symbols static if they're not exported.
6102 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6103 HAVE_FREETYPE.
6104 * font.h (ftxfont_driver): Likewise.
6105
e4cebfca
PE
6106 * xfns.c: Make symbols static if they're not exported.
6107 (x_last_font_name, x_display_info_for_name):
6108 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6109 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6110 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6111 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6112 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6113 (last_show_tip_args): Now static.
6114 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6115 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6116 (x_screen_planes): Remove; unused.
6117 * dispextern.h (x_screen_planes): Remove decl.
6118
5bf46f05
PE
6119 * dispnew.c: Make symbols static if they're not exported.
6120 * dispextern.h (redraw_garbaged_frames, scrolling):
6121 (increment_row_positions): Remove.
6122 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6123 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6124 Now static.
6125 (redraw_garbaged_frames): Remove; unused.
6126
435f4c28
PE
6127 * xfaces.c: Make symbols static if they're not exported.
6128 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6129 Remove decls.
6130 * xterm.h (defined_color): Remove decls.
6131 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6132 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6133 (menu_face_changed_default, defined_color, free_realized_face):
6134 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6135 (ascii_face_of_lisp_face): Remove; unused.
6136
8524aef3
PE
6137 * xdisp.c: Make symbols static if they're not exported.
6138 * dispextern.h (scratch_glyph_row, window_box_edges):
6139 (glyph_to_pixel_coords, set_cursor_from_row):
6140 (get_next_display_element, set_iterator_to_next):
6141 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6142 (show_mouse_face): Remove decls
6143 * frame.h (message_buf_print): Likewise.
6144 * lisp.h (pop_message, set_message, check_point_in_composition):
6145 Likewise.
6146 * xterm.h (set_vertical_scroll_bar): Likewise.
6147 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6148 (message_buf_print, scratch_glyph_row, displayed_buffer):
6149 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6150 (get_next_display_element, show_mouse_face, window_box_edges):
6151 (frame_to_window_pixel_xy, check_point_in_composition):
6152 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6153 (glyph_to_pixel_coords): Remove; unused.
6154
16390cd2
PE
6155 * dired.c (file_name_completion): Now static.
6156
6157 * dbusbind.c (xd_in_read_queued_messages): Now static.
6158
a25f4dfa
PE
6159 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6160 * data.c (circular_list_error): Remove.
6161
14a9c8df
PE
6162 * commands.h (last_point_position, last_point_position_buffer):
6163 (last_point_position_window): Remove decls.
6164 * keyboard.c: Make these variables static.
6165
04f2d78b
CB
6166 * coding.h (coding, code_convert_region, encode_coding_gap):
6167 Remove decls.
74ab6df5
PE
6168 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6169 (iso_code_class, detect_coding, code_convert_region): Now static.
6170 (encode_coding_gap): Remove; unused.
6171
38dfbee1
PE
6172 * chartab.c (chartab_chars, chartab_bits): Now static.
6173
a2cb4e63
PE
6174 * charset.h (charset_iso_8859_1): Remove decl.
6175 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6176 Now static.
6177
127198fd
PE
6178 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6179 * ccl.c (Vccl_program_table): Now static.
6180 (check_ccl_update): Remove; unused.
6181
d85b608f
PE
6182 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6183 * category.h: ... from here.
6184 * category.c (check_category_table, set_category_set): Now static.
6185
31cd66f3
PE
6186 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6187 * lisp.h: Remove these decls.
6188
c358e587
PE
6189 * buffer.c (buffer_count): Remove unused var.
6190
e78aecca
PE
6191 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6192 so that it's not optimized away.
6193 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6194 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6195 exported only to the debugger.
6196
e192d7d3 6197 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6198 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6199
92470028
PE
6200 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6201 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6202 was inaccessible from Lisp.
6203 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6204 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6205
244ed907
PE
6206 alloc.c: Import and export fewer symbols, and remove unused items.
6207 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6208 is defined.
6209 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6210 it's not optimized away by whole-program optimization.
6211 (message_enable_multibyte, free_misc): Remove.
6212 (catchlist, handlerlist, mark_backtrace):
6213 Declare only if BYTE_MARK_STACK.
6214 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6215 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6216 (message_enable_multibyte): Remove decl.
6217 (free_misc, interval_free_list, float_block, float_block_index):
6218 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6219 (cons_free_list, last_marked_index):
6220 Now static.
6221 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6222 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6223 (mark_backtrace): Define only if BYTE_MARK_STACK.
6224 * xdisp.c (message_enable_multibyte): Now static.
6225
61c2b50e 6226 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6227 This makes it easier for human readers (and static analyzers)
6228 to see whether these variables are used from other modules.
6229 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6230 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6231 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6232 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6233 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6234 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6235 * xmenu.c, xselect.c:
6236 Declare Q* vars static if they are not used in other modules.
6237 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6238 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6239 Remove decls of unexported vars.
6240 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6241
95c82688
PE
6242 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6243
16a97296
PE
6244 Make Emacs functions such as Fatom 'static' by default.
6245 This makes it easier for human readers (and static analyzers)
6246 to see whether these functions can be called from other modules.
6247 DEFUN now defines a static function. To make the function external
6248 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6249 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6250 (Finit_image_library):
16a97296
PE
6251 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6252 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6253 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6254 Remove decls, since these functions are now static.
6255 (Funintern, Fget_internal_run_time): New decls, since these functions
6256 were already external.
95c82688 6257
16a97296
PE
6258 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6259 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6260 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6261 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6262 * keyboard.c, keymap.c, lread.c:
6263 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6264 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6265 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6266 Mark functions with DEFUE instead of DEFUN,
6267 if they are used in other modules.
6268 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6269 decls for now-static functions.
6270 * buffer.h (Fdelete_overlay): Remove decl.
6271 * callproc.c (Fgetenv_internal): Mark as internal.
6272 * composite.c (Fremove_list_of_text_properties): Remove decl.
6273 (Fcomposition_get_gstring): New forward static decl.
6274 * composite.h (Fcomposite_get_gstring): Remove decl.
6275 * dired.c (Ffile_attributes): New forward static decl.
6276 * doc.c (Fdocumntation_property): New forward static decl.
6277 * eval.c (Ffetch_bytecode): New forward static decl.
6278 (Funintern): Remove extern decl; now in .h file where it belongs.
6279 * fileio.c (Fmake_symbolic_link): New forward static decl.
6280 * image.c (Finit_image_library): New forward static decl.
6281 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6282 * intervals.h (Fprevious_property_change):
6283 (Fremove_list_of_text_properties): Remove decls.
6284 * keyboard.c (Fthis_command_keys): Remove decl.
6285 (Fcommand_execute): New forward static decl.
6286 * keymap.c (Flookup_key): New forward static decl.
6287 (Fcopy_keymap): Now static.
6288 * keymap.h (Flookup_key): Remove decl.
6289 * process.c (Fget_process): New forward static decl.
6290 (Fprocess_datagram_address): Mark as internal.
6291 * syntax.c (Fsyntax_table_p): New forward static decl.
6292 (skip_chars): Remove duplicate decl.
6293 * textprop.c (Fprevious_property_change): New forward static decl.
6294 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6295 Now internal.
6296 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6297 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6298
785bbd42
PE
6299 * editfns.c (Fformat): Remove unreachable code.
6300
8b913b57
AS
63012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6302
6303 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6304 change. (Bug#8496)
6305
a6744a35
EZ
63062011-04-13 Eli Zaretskii <eliz@gnu.org>
6307
6308 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6309 when at ZV. (Bug#8487)
6310
e7974947
AS
63112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6312
baad03f0
AS
6313 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6314 (Bug#8437)
6315 * keyboard.c (parse_tool_bar_item): Likewise.
6316 * sound.c (sound_cleanup, alsa_close): Likewise.
6317 * termcap.c (tgetent): Likewise.
6318 * xfns.c (x_default_font_parameter): Likewise.
6319 * xsettings.c (read_and_apply_settings): Likewise.
6320
e7974947
AS
6321 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6322 (overrun_check_free): Protoize.
6323
28272684
PE
63242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6325
6326 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6327 since callers should never pass a negative size.
6328 Change the signature to match that of plain 'read' and 'write'; see
6329 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6330 * lisp.h: Update prototypes of emacs_write and emacs_read.
6331
11997c76
EZ
63322011-04-11 Eli Zaretskii <eliz@gnu.org>
6333
6334 * xdisp.c (redisplay_window): Don't try to determine the character
6335 position of the scroll margin if the window start point w->startp
e896f03c 6336 is outside the buffer's accessible region. (Bug#8468)
11997c76 6337
8a2cbd72
EZ
63382011-04-10 Eli Zaretskii <eliz@gnu.org>
6339
6340 Fix write-region and its subroutines for buffers > 2GB.
6341 * fileio.c (a_write, e_write): Modify declaration of arguments and
6342 local variables to support buffers larger than 2GB.
6343 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6344
6345 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6346 argument, local variables, and return value.
6347
6348 * lisp.h: Update prototypes of emacs_write and emacs_read.
6349
6350 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6351
4073e537 63522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6353
1ebfdcb6
PE
6354 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6355
b2ded58d
PE
6356 Fix more problems found by GCC 4.6.0's static checks.
6357
7d66342c
PE
6358 * xdisp.c (vmessage): Use a better test for character truncation.
6359
bbf47d44
PE
6360 * charset.c (load_charset_map): <, not <=, for optimization,
6361 and to avoid potential problems with integer overflow.
9248994d 6362 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6363 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6364 * editfns.c (Fformat): Likewise.
1e69125e 6365 * syntax.c (skip_chars): Likewise.
3befa583 6366
e3019616
PE
6367 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6368 This also lets GCC 4.6.0 generate slightly better loop code.
6369
becfa255
PE
6370 * callint.c (Fcall_interactively): <, not <=, for optimization.
6371 (Fcall_interactively): Count the number of arguments produced,
6372 not the number of arguments given. This is simpler and lets GCC
6373 4.6.0 generate slightly better code.
6374
dae0cd48
PE
6375 * ftfont.c: Distingish more carefully between FcChar8 and char.
6376 The previous code passed unsigned char * to a functions like
6377 strlen and xstrcasecmp that expect char *, which does not
6378 conform to the C standard.
6379 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6380 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6381 char * when the C standard requires it.
6382
76032d70
PE
6383 * keyboard.c (read_char): Remove unused var.
6384
eb3f1cc8
PE
6385 * eval.c: Port to Windows vsnprintf (Bug#8435).
6386 Include <limits.h>.
6387 (SIZE_MAX): Define if the headers do not.
6388 (verror): Do not give up if vsnprintf returns a negative count.
6389 Instead, grow the buffer. This ports to Windows vsnprintf, which
6390 does not conform to C99. Problem reported by Eli Zaretskii.
6391 Also, simplify the allocation scheme, by avoiding the need for
6392 calling realloc, and removing the ALLOCATED variable.
6393
70476b54
PE
6394 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6395
12020a9e
PE
6396 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6397 But keep the doprint source code for now, as we might revamp it
6398 and use it again (Bug#8435).
ea6c7ae6
PE
6399 * lisp.h (doprnt): Remove.
6400 * Makefile.in (base_obj): Remove doprnt.o.
6401 * deps.mk (doprnt.o): Remove.
6402
5fdb398c
PE
6403 error: Print 32- and 64-bit integers portably (Bug#8435).
6404 Without this change, on typical 64-bit hosts error ("...%d...", N)
6405 was used to print both 32- and 64-bit integers N, which relied on
6406 undefined behavior.
6407 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6408 New macro.
6409 * lisp.h (error, verror): Mark as printf-like functions.
6410 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6411 Report overflow in size calculations when allocating printf buffer.
6412 Do not truncate output string at its first null byte.
6413 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6414 Truncate the output at a character boundary, since vsnprintf does not
6415 do that.
6416 * charset.c (check_iso_charset_parameter): Convert internal
6417 character to string before calling 'error', since %c now has the
6418 printf meaning.
6419 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6420 overflow when computing char to be passed to 'error'. Do not
6421 pass Lisp_Object to 'error'; pass the integer instead.
6422 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6423 formatted with plain %d.
6424
b189fa66
PE
6425 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6426
bff87ef0
PE
6427 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6428
7e2cac20
PE
6429 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6430
ce4d90b5
PE
6431 * xterm.c (x_catch_errors): Remove duplicate declaration.
6432
266c9547
PE
6433 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6434
79c49ad2
PE
6435 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6436
368f4090
JM
64372011-04-10 Jim Meyering <meyering@redhat.com>
6438
6439 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6440 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6441 return ssize_t not "int", and use size_t as the buffer length.
6442 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6443 * gnutls.h: Update declarations.
6444 * process.c (read_process_output): Use ssize_t, to match.
6445 (send_process): Likewise.
6446
a32d4040
CY
64472011-04-09 Chong Yidong <cyd@stupidchicken.com>
6448
6449 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6450
8546720e 64512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6452
04f2d78b
CB
6453 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6454 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6455
8546720e
GM
6456 * xterm.c (handle_one_xevent):
6457 * xmenu.c (create_and_show_popup_menu):
6458 * xselect.c (x_decline_selection_request)
6459 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6460
0a2f5c1a 64612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6462
6463 Fix some uses of `int' instead of EMACS_INT.
6464 * search.c (string_match_1, fast_string_match)
6465 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6466 (scan_buffer, find_next_newline_no_quit)
6467 (find_before_next_newline, search_command, Freplace_match)
6468 (Fmatch_data): Make some `int' variables be EMACS_INT.
6469
6470 * xdisp.c (display_count_lines): 3rd argument and return value now
6471 EMACS_INT. All callers changed.
6472 (pint2hrstr): Last argument is now EMACS_INT.
6473
6474 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6475 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6476 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6477 (decode_coding_utf_16, decode_coding_emacs_mule)
6478 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6479 (decode_coding_ccl, decode_coding_charset)
6480 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6481 (decode_coding_iso_2022, decode_coding_emacs_mule)
6482 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6483 <char_offset, last_offset>: Declare EMACS_INT.
6484 (encode_coding_utf_8, encode_coding_utf_16)
6485 (encode_coding_emacs_mule, encode_invocation_designation)
6486 (encode_designation_at_bol, encode_coding_iso_2022)
6487 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6488 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6489 Declare EMACS_INT.
6490 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6491 (encode_invocation_designation): Last argument P_NCHARS is now
6492 EMACS_INT.
6493 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6494 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6495
6496 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6497 All users changed.
6498
6499 * ccl.c (Fccl_execute_on_string): Declare some variables
6500 EMACS_INT.
6501
8546720e 65022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6503
6504 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6505
4e19a977
CS
65062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6507
6508 * process.c (Fformat_network_address): Doc fix.
6509
87302331
R
65102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6511
6512 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6513
cbb59342
CY
65142011-04-08 Chong Yidong <cyd@stupidchicken.com>
6515
6516 * keyboard.c (read_char): Call Lisp function help-form-show,
6517 instead of using internal_with_output_to_temp_buffer.
6518 (Qhelp_form_show): New var.
e0d38eeb 6519 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6520
6521 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6522
6523 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6524
e67a13ab
CY
65252011-04-06 Chong Yidong <cyd@stupidchicken.com>
6526
04f2d78b
CB
6527 * process.c (Flist_processes): Remove to Lisp.
6528 (list_processes_1): Delete.
e67a13ab 6529
973f782d
EZ
65302011-04-06 Eli Zaretskii <eliz@gnu.org>
6531
7c106b1e
EZ
6532 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6533
973f782d
EZ
6534 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6535
41cf7d1a 65362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6537
ca23cc88
PE
6538 Fix more problems found by GCC 4.6.0's static checks.
6539
f390e2d5
PE
6540 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6541
42eea0d0
PE
6542 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6543
b69769da 6544 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6545
f9541e84
PE
6546 * xdisp.c (vmessage): Mark as a printf-like function.
6547
13841b55
PE
6548 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6549
c136c10f
PE
6550 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6551
5e2d4a30
PE
6552 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6553 printf-like functions.
6554 (tiff_load): Add casts to remove these marks before passing them
6555 to system-supplied API.
6556
583f48b9
PE
6557 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6558
b25d760e
PE
6559 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6560 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6561 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6562 directly, rather than having caller test rule sign. This avoids
6563 some unnecessary tests.
6564 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6565 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6566 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6567
bc7b6697 6568 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6569 (xfont_open): Avoid unnecessary tests.
bc7b6697 6570
27ccc379
PE
6571 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6572
dcd5c89a
PE
6573 * composite.h, composite.c (composition_gstring_put_cache):
6574 Use EMACS_INT, not int, for length.
6575
b13a45c6
PE
6576 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6577 breaking out part of COMPOSITION_DECODE_RULE.
6578 (COMPOSITION_DECODE_RULE): Use it.
6579 * composite.c (get_composition_id): Remove unused local vars,
6580 by using the new macro.
6581
1e792e4d
PE
6582 * textprop.c (set_text_properties_1): Change while to do-while,
6583 since the condition is always true at first.
6584
dc6c6455 6585 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6586 (interval_deletion_adjustment): Return unsigned value.
6587 All uses changed.
dc6c6455 6588
aba7731a
PE
6589 * process.c (list_processes_1, create_pty, read_process_output):
6590 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6591 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6592 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6593 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6594 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6595
fdfc4bf3
PE
6596 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6597
fca8fe46 6598 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6599 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6600
06a0259a 6601 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6602 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6603 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6604
e7b9e80f
PE
6605 * print.c (print_error_message): Avoid int overflow.
6606
56201685
PE
6607 * font.c (font_list_entities): Redo for clarity,
6608 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6609
78834453 6610 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6611 (font_score): Avoid potential overflow in diff calculation.
78834453 6612
0bc0b309 6613 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6614 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6615
e610eaca
PE
6616 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6617
b895abce
PE
6618 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6619 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6620 can always succeed if overflow has undefined behavior.
6621
1f1d9321 6622 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6623 (wordify): Omit three unnecessary tests.
1f1d9321 6624
c59478bc
PE
6625 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6626 All callers changed. This avoids the need for an unused var.
6627
79b73827
PE
6628 * casefiddle.c (casify_region): Remove var that is set but not used.
6629
a4db5dfe
PE
6630 * dired.c (file_name_completion): Remove var that is set but not used.
6631
43aae36e
PE
6632 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6633
2a47c44d 6634 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6635 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6636
a37c69bf
PE
6637 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6638 Check for integer overflow on size calculations.
6639
328ab8e7
PE
6640 * buffer.c (Fprevious_overlay_change): Remove var that is set
6641 but not used.
6642
e5a2a5cb
PE
6643 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6644 Remove vars that are set but not used.
8d84a6eb 6645 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6646 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6647
a60e5f68
PE
6648 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6649
f661cb61 6650 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6651 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6652
f0397f5a
PE
6653 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6654 that are set but not used.
6655
8664db06 6656 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6657 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6658
6abdaa4a
PE
6659 * xselect.c (x_get_local_selection, x_handle_property_notify):
6660 Remove vars that are set but not used.
6661
0ce7538d 6662 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6663 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6664
9ae848fc
PE
6665 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6666 Remove var that is set but not used.
0b918413
PE
6667 (scroll_bar_windows_size): Now size_t, not int.
6668 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6669 Check for overflow.
9ae848fc 6670
a5a62657
PE
6671 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6672 (map_tty_color) [!defined MSDOS]: Likewise.
6673
5c5cdd39
PE
6674 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6675
66ebf983
PE
6676 * coding.c: Remove vars that are set but not used.
6677 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6678 All callers changed.
6679 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6680 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6681 (decode_coding_charset): Remove vars that are set but not used.
6682
1be4d761
PE
6683 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6684 that is set but not used.
6685
47553fa8
PE
6686 * print.c (print_object): Remove var that is set but not used.
6687
1f7196bf 6688 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6689 The gnulib version avoids calling malloc in the usual case,
6690 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6691 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6692 * filelock.c (current_lock_owner): Likewise.
6693 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6694 * sysdep.c: Include allocator.h, careadlinkat.h.
6695 (emacs_no_realloc_allocator): New static constant.
6696 (emacs_readlink): New function.
fdb61804
PE
6697 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6698 ../lib/careadlinkat.h.
d1fdcab7 6699
f84c17c7
SM
67002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6701
6702 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6703 first non-nil return value).
6704
ef3862ad
JD
67052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6706
6707 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6708 if not defined (Bug#8403).
6709
376a7006
JB
67102011-04-02 Juanma Barranquero <lekktu@gmail.com>
6711
6712 * xdisp.c (display_count_lines): Remove parameter `start',
6713 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6714 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6715 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6716 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6717 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6718 and thereabouts. All callers changed.
6719 (get_per_char_metric): Remove parameter `f', unused since
6720 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6721
6ca3801d
JM
67222011-04-02 Jim Meyering <meyering@redhat.com>
6723
6724 do not dereference NULL upon failed strdup
6725 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6726 (ns_get_family): Likewise.
6727
d8e2b5ba
JB
67282011-04-02 Juanma Barranquero <lekktu@gmail.com>
6729
6730 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6731
8c74fcbd
JD
67322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6733
6734 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6735 later (Bug#8403).
6736
7200d79c
SM
67372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6738
03408648 6739 Add lexical binding.
7200d79c 6740
03408648
SM
6741 * window.c (Ftemp_output_buffer_show): New fun.
6742 (Fsave_window_excursion):
6743 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6744
6745 * lread.c (lisp_file_lexically_bound_p): New function.
6746 (Fload): Bind Qlexical_binding.
6747 (readevalloop): Remove `evalfun' arg.
6748 Bind Qinternal_interpreter_environment.
6749 (Feval_buffer): Bind Qlexical_binding.
6750 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6751 Mark as dynamic.
6752 (syms_of_lread): Declare `lexical-binding'.
6753
6754 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6755
6756 * keyboard.c (eval_dyn): New fun.
6757 (menu_item_eval_property): Use it.
ca105506
SM
6758
6759 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6760
03408648
SM
6761 * fns.c (concat, mapcar1): Accept byte-code-functions.
6762
6763 * eval.c (Fsetq): Handle lexical vars.
6764 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6765 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6766 (FletX, Flet): Obey lexical binding.
6767 (Fcommandp): Handle closures.
6768 (Feval): New `lexical' arg.
6769 (eval_sub): New function extracted from Feval. Use it almost
6770 everywhere where Feval was used. Look up vars in lexical env.
6771 Handle closures.
6772 (Ffunctionp): Move from subr.el.
6773 (Ffuncall): Handle closures.
6774 (apply_lambda): Remove `eval_flags'.
6775 (funcall_lambda): Handle closures and new byte-code-functions.
6776 (Fspecial_variable_p): New function.
6777 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6778 but without exporting it to Lisp.
23aba0ea 6779
23aba0ea 6780 * doc.c (Fdocumentation, store_function_docstring):
03408648 6781 * data.c (Finteractive_form): Handle closures.
23aba0ea 6782
03408648
SM
6783 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6784 interactive spec.
ba83908c 6785
04f2d78b
CB
6786 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6787 New byte-codes.
03408648
SM
6788 (exec_byte_code): New function extracted from Fbyte_code to handle new
6789 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6790
03408648 6791 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6792
03408648 6793 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6794
e2abce01
JB
67952011-03-31 Juanma Barranquero <lekktu@gmail.com>
6796
6797 * xdisp.c (redisplay_internal): Fix prototype.
6798
63696a73 67992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6800
63696a73 6801 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6802 (try_scrolling): Use it when setting scroll_limit.
6803 Limit scrolling to 100 screen lines.
63696a73
EZ
6804 (redisplay_window): Even when falling back on "recentering",
6805 position point in the window according to scroll-conservatively,
6806 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6807
6808 (try_scrolling): When point is above the window, allow searching
6809 as far as scroll_max, or one screenful, to compute vertical
6810 distance from PT to the scroll margin position. This prevents
6811 try_scrolling from unnecessarily failing when
6812 scroll-conservatively is set to a value slightly larger than the
6813 window height. Clean up the case of PT below the margin at bottom
6814 of window: scroll_max can no longer be INT_MAX. When aggressive
6815 scrolling is in use, don't let point enter the opposite scroll
6816 margin as result of the scroll.
6817 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6818 threshold of 100 lines for never-recentering scrolling.
6819
e4cc2dfc
JB
68202011-03-31 Juanma Barranquero <lekktu@gmail.com>
6821
6822 * dispextern.h (move_it_by_lines):
6823 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6824 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6825 (message_log_check_duplicate): Remove parameters `prev_bol' and
6826 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6827 (redisplay_internal): Remove parameter `preserve_echo_area',
6828 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6829
6830 * indent.c (Fvertical_motion):
6831 * window.c (window_scroll_pixel_based, Frecenter):
6832 Don't pass `need_y_p' to `move_it_by_lines'.
6833
1c470562
SM
68342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6835
44f230aa
SM
6836 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6837 steal a few bits to be more compact.
6838 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6839 Remove unneeded casts.
6840
1c470562
SM
6841 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6842
888adce9
ZK
68432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6844
6845 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6846 binding" message (bug#7967).
6847
f838ed7b
PE
68482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6849
77861b95
PE
6850 Fix more problems found by GCC 4.6.0's static checks.
6851
de6dbc14
PE
6852 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6853 Remove unused local var.
6854
f838ed7b
PE
6855 * editfns.c (Fmessage_box): Remove unused local var.
6856
792c7b2b
PE
6857 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6858 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6859 Omit unused local vars.
c499e557 6860 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6861 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6862 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6863 Omit unused local var.
6864
ba0165e1
PE
6865 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6866 Don't assume string length fits in int.
32ad8845 6867 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6868 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6869
3c59b4c9
PE
6870 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6871 instead of alloca (Bug#8344).
6872
a3eed478 6873 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6874 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6875
eb4d412d
PE
6876 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6877
1658b401
PE
6878 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6879 concerns.
6880
6881 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6882
6883 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6884
9a2c6e05
PE
6885 * keyboard.c (syms_of_keyboard): Use the same style as later
6886 in this function when indexing through an array. This also
6887 works around GCC bug 48267.
6888
03d0a109
PE
6889 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6890
44f730c8
PE
6891 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6892
fe75f926
PE
6893 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6894 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6895
ffa8c828
PE
6896 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6897 This avoids undefined behavior on integer overflow, and is a bit
6898 more convenient anyway since it is compared to a size_t variable.
6899
c5101a77
PE
6900 Variadic C functions now count arguments with size_t, not int.
6901 This avoids an unnecessary limitation on 64-bit machines, which
6902 caused (substring ...) to crash on large vectors (Bug#8344).
6903 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6904 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6905 All variadic functions and their callers changed accordingly.
c5101a77
PE
6906 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6907 * data.c (arith_driver, float_arith_driver): Likewise.
6908 * editfns.c (general_insert_function): Likewise.
6909 * eval.c (struct backtrace.nargs, interactive_p)
6910 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6911 (funcall_lambda, mark_backtrace): Likewise.
6912 * fns.c (concat): Likewise.
6913 * frame.c (x_set_frame_parameters): Likewise.
6914 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6915 0 if not found, not -1. All callers changed.
6916
dd3f25f7
PE
6917 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6918 (stack_copy_size): Now size_t, not int.
6919 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6920
461c2ab9
JB
69212011-03-28 Juanma Barranquero <lekktu@gmail.com>
6922
6923 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6924 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6925 All callers changed.
6926
6927 * lisp.h (multibyte_char_to_unibyte):
6928 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6929 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6930 * character.h (CHAR_TO_BYTE8):
6931 * cmds.c (internal_self_insert):
6932 * editfns.c (general_insert_function):
6933 * keymap.c (push_key_description):
6934 * search.c (Freplace_match):
6935 * xdisp.c (message_dolog, set_message_1): All callers changed.
6936
f6d62986
SM
69372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6938
6939 * keyboard.c (safe_run_hook_funcall): New function.
6940 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6941 don't set the hook to nil, but remove the offending function instead.
6942 (Qcommand_hook_internal): Remove, unused.
6943 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6944 Vcommand_hook_internal.
6945
6946 * eval.c (enum run_hooks_condition): Remove.
6947 (funcall_nil, funcall_not): New functions.
6948 (run_hook_with_args): Call each function through a `funcall' argument.
6949 Remove `cond' argument, now redundant.
6950 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6951 (Frun_hook_with_args_until_failure): Adjust accordingly.
6952 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6953
1db5b1ad
JB
69542011-03-28 Juanma Barranquero <lekktu@gmail.com>
6955
6956 * dispextern.h (string_buffer_position): Remove declaration.
6957
6958 * print.c (strout): Remove parameter `multibyte', unused since
6959 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6960
6961 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6962 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6963 All callers changed.
6964
6965 * w32.c (_wsa_errlist): Use braces for struct initializers.
6966
6967 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6968 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6969 All callers changed.
6970 (string_buffer_position): Likewise. Also, make static (it's never
6971 used outside xdisp.c).
6972 (cursor_row_p): Remove parameter `w', unused since
6973 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6974 (decode_mode_spec): Remove parameter `precision', introduced during
6975 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6976 All callers changed.
6977
5ffb62aa
JD
69782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6979
6980 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6981
461c2ab9 69822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6983
6984 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6985 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6986 (ns_update_auto_hide_menu_bar): New functions.
6987 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6988 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6989 ns_constrain_all_frames.
6990 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6991 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6992
5c380ffb
JD
69932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6994
6995 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6996
9af30bdf
GM
69972011-03-27 Glenn Morris <rgm@gnu.org>
6998
6999 * syssignal.h: Replace RETSIGTYPE with void.
7000 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7001 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7002 Replace SIGTYPE with void everywhere.
7003 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7004 * s/template.h (SIGTYPE): Remove commented out definition.
7005
e2abce01
JB
70062011-03-26 Eli Zaretskii <eliz@gnu.org>
7007
7008 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7009 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7010
f868cd8a
JB
70112011-03-26 Juanma Barranquero <lekktu@gmail.com>
7012
59eb0929
JB
7013 * w32.c (read_unc_volume): Use parameter `henum', instead of
7014 global variable `wget_enum_handle'.
7015
7016 * keymap.c (describe_vector): Remove parameters `indices' and
7017 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7018 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7019
f868cd8a
JB
7020 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7021
7022 * keyboard.c (timer_check): Remove parameter `do_it_now',
7023 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7024 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7025 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7026
7027 * keyboard.c (read_char):
7028 * w32menu.c (w32_menu_display_help):
7029 * xmenu.c (show_help_event, menu_help_callback):
7030 Adjust calls to `show_help_echo'.
7031
7032 * gtkutil.c (xg_maybe_add_timer):
7033 * keyboard.c (readable_events):
7034 * process.c (wait_reading_process_output):
7035 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7036
7037 * insdel.c (adjust_markers_gap_motion):
7038 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7039 (gap_left, gap_right): Don't call it.
7040
2ecf6fdb
CY
70412011-03-25 Chong Yidong <cyd@stupidchicken.com>
7042
7043 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7044 incurred during fontification.
7045
6b1f9ba4
JB
70462011-03-25 Juanma Barranquero <lekktu@gmail.com>
7047
7048 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7049 (DEFVAR_PER_BUFFER): Don't pass it.
7050
7051 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7052 (scrolling_window): Don't pass it.
7053
0f4a96b5
JB
70542011-03-25 Juanma Barranquero <lekktu@gmail.com>
7055
7056 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7057
7058 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7059 and `suffix'.
7060 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7061 of variables specific to SELinux and computation of `encoded_absname'.
7062
7063 * image.c (XPutPixel): Remove unused variable `height'.
7064
7065 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7066
7067 * unexw32.c (get_section_info): Remove unused variable `section'.
7068
7069 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7070 (system_process_attributes): Remove unused variable `sess'.
7071 (sys_read): Remove unused variable `err'.
7072
7073 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7074 (w32_wnd_proc): Remove unused variable `isdead'.
7075 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7076 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7077 (x_create_tip_frame): Remove unused variable `tem'.
7078
7079 * w32inevt.c (w32_console_read_socket):
7080 Remove unused variable `no_events'.
7081
7082 * w32term.c (x_draw_composite_glyph_string_foreground):
7083 Remove unused variable `width'.
7084
1149507c
JB
70852011-03-24 Juanma Barranquero <lekktu@gmail.com>
7086
7087 * w32term.c (x_set_glyph_string_clipping):
7088 Don't pass uninitialized region to CombineRgn.
7089
9c88f339
JB
70902011-03-23 Juanma Barranquero <lekktu@gmail.com>
7091
7092 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7093 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7094 (Fx_close_connection): Remove unused variable `i'.
7095
7096 * w32font.c (w32font_draw): Return number of glyphs.
7097 (w32font_open_internal): Remove unused variable `i'.
7098 (w32font_driver): Add missing initializer.
7099
7100 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7101 (fill_in_menu): Remove unused variable `items_added'.
7102
7103 * w32term.c (last_mouse_press_frame): Remove static global variable.
7104 (w32_clip_to_row): Remove unused variable `f'.
7105 (x_delete_terminal): Remove unused variable `i'.
7106
7107 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7108 (NOTHING): Remove unused static global variable.
7109 (uniscribe_check_otf): Remove unused variable `table'.
7110 (uniscribe_font_driver): Add missing initializers.
7111
dee091a3
JD
71122011-03-23 Julien Danjou <julien@danjou.info>
7113
7114 * term.c (Fsuspend_tty, Fresume_tty):
7115 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7116 * window.c (temp_output_buffer_show):
7117 * insdel.c (signal_before_change):
7118 * frame.c (Fhandle_switch_frame):
7119 * fileio.c (Fdo_auto_save):
7120 * emacs.c (Fkill_emacs):
7121 * editfns.c (save_excursion_restore):
7122 * cmds.c (internal_self_insert):
7123 * callint.c (Fcall_interactively):
7124 * buffer.c (Fkill_all_local_variables):
7125 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7126 Use Frun_hooks.
0f4a96b5 7127 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7128 unconditionnaly since it does the check itself.
7129
2c520ab5 71302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7131
c9c49752
PE
7132 Fix more problems found by GCC 4.5.2's static checks.
7133
8abc3f12
PE
7134 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7135 the first time through the loop, since we know p0 < p1 then.
7136 This also avoids a gcc -Wstrict-overflow warning.
7137
a2d26660
PE
7138 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7139 leading to a memory leak, possible in functions like
7140 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7141 of objects (Bug#8318).
a2d26660 7142
916c72e9
PE
7143 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7144 that could (at least in theory) be that large.
7145
19ab8a18
PE
7146 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7147 This is less likely to overflow, and avoids undefined behavior if
7148 overflow does occur. All callers changed. Use strtoul to scan
7149 for the unsigned long integer.
b7cbbd6f
PE
7150 (pint2hrstr): Simplify and tune code slightly.
7151 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7152
f0641eff
PE
7153 * scroll.c (do_scrolling): Work around GCC bug 48228.
7154 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7155
7f650bb9
PE
7156 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7157 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7158 (validate_x_resource_name): Simplify count usage.
7159 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7160
37dd57d1
PE
7161 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7162 fail (Bug#8306).
81e56e61 7163
699979fc 7164 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7165
401bf9b4
PE
7166 * process.c (Fmake_network_process): Use socklen_t, not int,
7167 where POSIX says socklen_t is required in portable programs.
7168 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7169 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7170 (Fmake_network_process, server_accept_connection):
7171 (wait_reading_process_output, read_process_output):
7172 Likewise.
7173
b93aacde
PE
7174 * process.c: Rename or move locals to avoid shadowing.
7175 (list_processes_1, Fmake_network_process):
7176 (read_process_output_error_handler, exec_sentinel_error_handler):
7177 Rename or move locals.
4dc343ee 7178 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7179 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7180 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7181 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7182 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7183
af8a867c 7184 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7185 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7186 Include tparam.h instead, since it declares them.
af8a867c
PE
7187 * cm.h (PC): Remove extern decl; tparam.h now does this.
7188 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7189 * terminfo.c: Include tparam.h, to check interfaces.
7190 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7191 (tparam): Adjust signature to match interface in tparam.h;
7192 this removes some undefined behavior. Check that outstring and len
7193 are zero, which they always are with Emacs.
7194 * tparam.h (PC, BC, UP): New extern decls.
7195
0248044d 7196 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7197 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7198
8ff096c1 7199 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7200 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7201 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7202 (ftfont_list): Remove unused local.
49eaafba
PE
7203 (get_adstyle_property, ftfont_pattern_entity):
7204 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7205 Rename locals to avoid shadowing.
8ff096c1 7206
e2be39f6
PE
7207 * xfont.c (xfont_list_family): Mark var as initialized.
7208
c9735e30
PE
7209 * xml.c (make_dom): Now static.
7210
8f5201ae
PE
7211 * composite.c (composition_compute_stop_pos): Rename local to
7212 avoid shadowing.
b246f932
PE
7213 (composition_reseat_it): Remove unused locals.
7214 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7215 (composition_update_it): Mark var as initialized.
11b61122
PE
7216 (find_automatic_composition): Mark vars as initialized,
7217 with a FIXME (Bug#8290).
8f5201ae 7218
760fbc2c
PE
7219 character.h: Rename locals to avoid shadowing.
7220 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7221 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7222 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7223 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7224 to avoid shadowing.
7225
ff08eb85
PE
7226 * textprop.c (property_change_between_p): Remove; unused.
7227
fc7bf025
PE
7228 * intervals.c (interval_start_pos): Now static.
7229
235d7abc
PE
7230 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7231
44f230aa
SM
7232 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7233 Rename locals to avoid shadowing.
3e7d6594 7234
50060332
PE
7235 * sound.c (wav_play, au_play, Fplay_sound_internal):
7236 Fix pointer signedness.
d01f234b 7237 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7238 (wav_play): Initialize a variable to 0, to prevent undefined
7239 behavior (Bug#8278).
50060332 7240
c4fc4e30
PE
7241 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7242
918436ed
PE
7243 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7244
c939f91b
PE
7245 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7246 clobbering (Bug#8298).
b9c7f648
PE
7247 * sysdep.c (sys_subshell): Likewise.
7248 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7249
6bd8c144
PE
7250 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7251 This should get cleaned up, so that child_setup has the
7252 same signature on all platforms.
7253
7710357c 7254 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7255 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7256
c59da222
CY
72572011-03-22 Chong Yidong <cyd@stupidchicken.com>
7258
7259 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7260 not to be necessary, and produces flickering.
7261
66b87493
GM
72622011-03-20 Glenn Morris <rgm@gnu.org>
7263
7264 * config.in: Remove file.
7265
45b6f6d5
JB
72662011-03-20 Juanma Barranquero <lekktu@gmail.com>
7267
7268 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7269 are now in src/globals.h.
7270 (syms_of_minibuf): Remove spurious & from previous change.
7271
3ec03f7e
LL
72722011-03-20 Leo <sdl.web@gmail.com>
7273
7274 * minibuf.c (completing-read-function): New variable.
7275 (completing-read-default): Rename from completing-read.
7276 (completing-read): Call completing-read-function.
7277
b14e3e21
CY
72782011-03-19 Juanma Barranquero <lekktu@gmail.com>
7279
7280 * xfaces.c (Fx_load_color_file):
7281 Read color file from absolute filename (bug#8250).
7282
f2b726e6
JB
72832011-03-19 Juanma Barranquero <lekktu@gmail.com>
7284
7285 * makefile.w32-in: Update dependencies.
7286
09f6ff02
EZ
72872011-03-17 Eli Zaretskii <eliz@gnu.org>
7288
7289 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7290
29a6015a
PE
72912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7292
a3a6c54e
PE
7293 Fix more problems found by GCC 4.5.2's static checks.
7294
b766f867
PE
7295 * process.c (make_serial_process_unwind, send_process_trap):
7296 (sigchld_handler): Now static.
7297
be02381c
PE
7298 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7299 That way, the code declares only the vars that it needs.
7300 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7301 * s/cygwin.h (PTY_ITERATION): Likewise.
7302 * s/darwin.h (PTY_ITERATION): Likewise.
7303 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7304
57048744
PE
7305 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7306 * process.c (allocate_pty): Don't declare stb unless it's needed.
7307
7914961c 7308 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7309 (CONSTANTLIM): Remove; unused.
7310 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7311 Define only if needed.
7914961c 7312
b3967b18
PE
7313 * unexelf.c (unexec): Name an expression,
7314 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7315 Use a different way to cause a compilation error if anyone uses
7316 n rather than nn, a way that does not involve shadowing.
73366a00 7317 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7318
29a6015a
PE
7319 * deps.mk (unexalpha.o): Remove; unused.
7320
43cfc33e 7321 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7322 * unexec.h: New file.
ce701a33
PE
7323 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7324 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7325 Depend on unexec.h.
7326 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7327 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7328 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7329 Change as necessary to match prototype in unexec.h.
ce701a33 7330
01f44d5a
PE
7331 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7332 shadowing.
4f63c6bb 7333 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7334
a6670b0b
PE
7335 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7336 Rename locals to avoid shadowing.
7337
cef2010d 7338 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7339 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7340
d4d7173a
PE
7341 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7342
f08b802a
PE
7343 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7344 warning when compiling print.c.
7345
3ddb0639
PE
7346 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7347 instead of using an uninitialized var.
5ad03b97 7348 (font_sort_entities): Mark var as initialized.
3ddb0639 7349
170a2692
PE
7350 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7351
e663c700
PE
7352 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7353 pointers to constants.
89bc529a 7354 (font_parse_fcname): Remove unused vars.
7b81e2d0 7355 (font_delete_unmatched): Now static.
ea838e10 7356 (font_get_spec): Remove; unused.
13a547c6
PE
7357 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7358 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7359 Rename or move locals to avoid shadowing.
e663c700 7360
2a80c887 7361 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7362 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7363
1384fa33 7364 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7365 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7366
8b2c52e9
PE
7367 * alloc.c (mark_backtrace): Move decl from here ...
7368 * lisp.h: ... to here, so that it can be checked.
7369
475545b5 7370 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7371 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7372 (lisp_indirect_variable): Name an expression,
7373 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7374 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7375
b1349114 7376 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7377 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7378 Use const pointer when appropriate.
b1349114 7379
a2928364
PE
7380 * lisp.h (get_system_name, get_operating_system_release):
7381 Move decls here, to check interfaces.
7382 * process.c (get_operating_system_release): Move decl to lisp.h.
7383 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7384 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7385 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7386 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7387 (Fformat_time_string, Fencode_time, Finsert_char):
7388 (Ftranslate_region_internal, Fformat):
7389 Rename or remove local vars to avoid shadowing.
9710023e 7390 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7391
a415e694
PE
7392 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7393 avoid shadowing.
7394
8ef4622d
PE
7395 * lisp.h (eassert): Check that the argument compiles, even if
7396 ENABLE_CHECKING is not defined.
7397
946f9a5b
PE
7398 * data.c (Findirect_variable): Name an expression, to avoid
7399 gcc -Wbad-function-cast warning.
112396d6 7400 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7401 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7402 (Fmake_variable_buffer_local, Fmake_local_variable):
7403 Mark variables as initialized.
52746918 7404 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7405
e5aab7e7 7406 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7407 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7408 Rename locals to avoid shadowing.
dff45157
PE
7409 (mark_stack): Move local variables into the #ifdef region where
7410 they're used.
7bc26fdb
PE
7411 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7412 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7413 needed otherwise.
7414 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7415 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7416 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7417
e5aab7e7
PE
7418 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7419 avoids undefined behavior in theory.
7420
4da60324
PE
7421 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7422
88043301
PE
7423 Use functions, not macros, for up- and down-casing (Bug#8254).
7424 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7425 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7426 to use the following functions instead of these macros.
7427 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7428 EMACS_INT, since callers assume the returned value fits in int.
7429 (upcase1): Likewise, for UPCASE_TABLE.
7430 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7431 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7432 the race-condition problem in the old DOWNCASE.
88043301 7433
19ed5445
PE
7434 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7435 Rename locals to avoid shadowing.
7436 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7437 (regex_compile, re_search_2, re_match_2_internal):
7438 Remove unused local vars.
952db0d7
PE
7439 (FREE_VAR): Rewrite so as not to use empty "else",
7440 which gcc can warn about.
da053e48 7441 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7442 (RETALLOC_IF): Define only if needed.
7443 (WORDCHAR_P): Likewise. This one is never needed, but is used
7444 only in a comment talking about a compiler bug, so put inside
7445 the #if 0 of that comment.
7446 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7447 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7448 Remove; unused.
19ed5445 7449
1f3561e4 7450 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7451 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7452 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7453
ded6f8f7
PE
7454 * search.c (simple_search): Remove unused var.
7455
dbd37a95
PE
7456 * dired.c (compile_pattern): Move decl from here ...
7457 * lisp.h: ... to here, so that it can be checked.
7458 (struct re_registers): New forward decl.
7459
7e47afad
PE
7460 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7461
85f24f61
PE
7462 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7463 All uses changed.
7464 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7465 Rename locals to avoid shadowing.
5671df8f 7466 (Fvertical_motion): Mark locals as initialized.
85f24f61 7467
181aa2be 7468 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7469 (casify_region): Mark local as initialized.
181aa2be 7470
930d429c
PE
7471 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7472
7082eac6
PE
7473 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7474 New macros, so that the caller can use some names other than
7475 gcpro1, gcpro2, etc.
7476 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7477 of the new macros.
7478 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7479 argument, for consistency with GCPRO2_VAR, etc: it is now the
7480 prefix of the variable, not the variable itself. All uses
7481 changed.
38b2c076
PE
7482 * dired.c (directory_files_internal, file_name_completion):
7483 Rename locals to avoid shadowing.
7484
15206ed9
PE
7485 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7486 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7487 dired.c's scmp function, had undefined behavior.
7488 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7489 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7490 * buffer.h: ... to here, because these macros use current_buffer,
7491 and the new implementation with inline functions needs to have
7492 current_buffer in scope now, rather than later when the macros
7493 are used.
7494 (downcase, upcase1): New static inline functions.
7495 (DOWNCASE, UPCASE1): Reimplement using these functions.
7496 This avoids undefined behavior in expressions like
7497 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7498 from race conditions in accessing the global variables
7499 case_temp1 and case_temp2.
7500 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7501 * lisp.h (case_temp1, case_temp2): Remove their decls.
7502 * character.h (ASCII_CHAR_P): Move from here ...
7503 * lisp.h: ... to here, so that the inline functions mentioned
7504 above can use them.
7505
4a6bea26
PE
7506 * dired.c (directory_files_internal_unwind): Now static.
7507
f14b7e14
PE
7508 * fileio.c (file_name_as_directory, directory_file_name):
7509 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7510 Now static.
2893f146
PE
7511 (file_name_as_directory): Use const pointers when appropriate.
7512 (Fexpand_file_name): Likewise. In particular, newdir might
7513 point at constant storage, so make it a const pointer.
fd4ead52 7514 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7515 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7516 signedness issues.
f839df0c
PE
7517 (Fset_file_times, Finsert_file_contents, auto_save_error):
7518 Rename locals to avoid shadowing.
f14b7e14 7519
5716756e 7520 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7521 (Ftry_completion, Fall_completions): Rename or remove locals
7522 to avoid shadowing.
5716756e 7523
b4c3046a
PE
7524 * marker.c (bytepos_to_charpos): Remove; unused.
7525
b45db522
PE
7526 * lisp.h (verify_bytepos, count_markers): New decls,
7527 so that gcc does not warn that these functions aren't declared.
7528
85876d07
PE
7529 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7530 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7531 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7532 (copy_text): Remove unused local var.
85876d07 7533
03d78a21 7534 * filelock.c (within_one_second): Now static.
b3dd38ab 7535 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7536
5df8f01b
PE
7537 * buffer.c (fix_overlays_before): Mark locals as initialized.
7538 (fix_start_end_in_overlays): Likewise. This function should be
7539 simplified by using pointers-to-pointers, but that's a different
7540 matter.
b1d876f1 7541 (switch_to_buffer_1): Now static.
8f54f30a
PE
7542 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7543 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7544
a70072c9 7545 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7546 Fix pointer signedness issue.
edced198
PE
7547 (sys_subshell): Mark local as volatile if checking for lint,
7548 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7549 (MAXPATHLEN): Define only if needed.
a70072c9 7550
a0977c44
PE
7551 * process.c (serial_open, serial_configure): Move decls from here ...
7552 * systty.h: ... to here, so that they can be checked.
7553
a884fdcc
PE
7554 * fns.c (get_random, seed_random): Move extern decls from here ...
7555 * lisp.h: ... to here, so that they can be checked.
7556
604efe86 7557 * sysdep.c (reset_io): Now static.
b8950c94 7558 (wait_for_termination_signal): Remove; unused.
604efe86 7559
38fc62d9
PE
7560 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7561 (copy_keymap_item, append_key, push_text_char_description):
7562 Now static.
1004a21a 7563 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7564 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7565 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7566 (describe_map_tree):
7567 Rename locals to avoid shadowing.
38fc62d9 7568
2f2650da
PE
7569 * keyboard.c: Declare functions static if they are not used elsewhere.
7570 (echo_char, echo_dash, cmd_error, top_level_2):
7571 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7572 (read_char, kbd_buffer_get_event, make_lispy_position):
7573 (make_lispy_event, make_lispy_movement, apply_modifiers):
7574 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7575 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7576 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7577 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7578 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7579
a053e86c 7580 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7581 (mark_kboards): Move decl here ...
7582 * alloc.c (mark_kboards): ... from here.
a053e86c 7583
4752793e
PE
7584 * lisp.h (force_auto_save_soon): New decl.
7585
74f10ca7 7586 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7587 (DEFINE_DUMMY_FUNCTION): New macro.
7588 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7589 Use it.
c03cd23f
PE
7590 (main): Add casts to avoid warnings
7591 if GCC considers string literals to be constants.
74f10ca7 7592
022e70d4
PE
7593 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7594
59d6fe83
PE
7595 * dbusbind.c: Pointer signedness fixes.
7596 (xd_signature, xd_append_arg, xd_initialize):
7597 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7598 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7599 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7600 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7601
78320123
PE
7602 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7603 if GCC considers string literals to be constants.
49cebcca 7604 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7605
35ac2a97
SM
76062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7607
fb103ca9
SM
7608 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7609 (print_preprocess, print_object): New macro to fix last change.
7610
35ac2a97
SM
7611 * print.c (print_preprocess): Don't forget font objects.
7612
62973b41
JB
76132011-03-16 Juanma Barranquero <lekktu@gmail.com>
7614
7615 * emacs.c (USAGE3): Doc fixes.
7616
0e48bb22
AS
76172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7618
7619 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7620 structure.
7621
7684e57b
JB
76222011-03-14 Juanma Barranquero <lekktu@gmail.com>
7623
7624 * lisp.h (VWindow_system, Qfile_name_history):
7625 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7626 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7627 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7628
7629 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7630 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7631
7632 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7633 * w32console.c (detect_input_pending, read_input_pending)
7634 (encode_terminal_code):
7635 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7636 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7637 (w32_system_caret_y, Qfile_name_history):
7638 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7639 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7640 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7641 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7642 * w32proc.c (Qlocal, report_file_error):
7643 * w32term.c (Vwindow_system, updating_frame):
7644 * w32uniscribe.c (initialized, uniscribe_font_driver):
7645 Remove unneeded extern declarations.
7646
2aa46d6c
CY
76472011-03-14 Chong Yidong <cyd@stupidchicken.com>
7648
c96bbc66 7649 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7650
cffc6f3b
CY
76512011-03-13 Chong Yidong <cyd@stupidchicken.com>
7652
7653 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7654 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7655 These macros can no longer be used for assignment.
7656
44f230aa
SM
7657 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7658 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7659 (record_buffer_markers, fetch_buffer_markers): New functions for
7660 recording and fetching special buffer markers.
7661 (set_buffer_internal_1, set_buffer_temp): Use them.
7662
7663 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7664
7665 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7666
7667 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7668 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7669
7670 * xdisp.c (hscroll_window_tree):
7671 (reconsider_clip_changes): Use PT instead of BUF_PT.
7672
d251f04b
EZ
76732011-03-13 Eli Zaretskii <eliz@gnu.org>
7674
7675 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7676 $(EMACS_ROOT)/lib/intprops.h.
7677
f0c77cd1
PE
76782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7679
3eca4629
PE
7680 Fix more problems found by GCC 4.5.2's static checks.
7681
7c86ee98
PE
7682 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7683 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7684 (xg_free_frame_widgets): Make it clear that a local variable is
7685 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7686 (gdk_window_get_screen): Make it clear that this macro is needed
7687 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7688 (int_gtk_range_get_value): New function, which avoids a diagnostic
7689 from gcc -Wbad-function-cast.
7690 (xg_set_toolkit_scroll_bar_thumb): Use it.
7691 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7692 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7693 (get_utf8_string, xg_get_file_with_chooser):
7694 Rename locals to avoid shadowing.
7695 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7696
41729b81
PE
7697 * xgselect.c (xg_select): Remove unused var.
7698
f0c77cd1
PE
7699 * image.c (four_corners_best): Mark locals as initialized.
7700 (gif_load): Initialize transparent_p to zero (Bug#8238).
7701 Mark another local as initialized.
ec6cf4c6 7702 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7703
ce0ad53d 7704 * image.c (clear_image_cache): Now static.
d5d5a617 7705 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7706 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7707 (x_edge_detection): Remove unnecessary cast that
7708 gcc -Wbad-function-cast diagnoses.
2037898d 7709 (gif_load): Fix pointer signedness.
6ae141d6
PE
7710 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7711 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7712
33383987 77132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7714
d32df629
PE
7715 Improve quality of tests for time stamp overflow.
7716 For example, without this patch (encode-time 0 0 0 1 1
7717 1152921504606846976) returns the obviously-bogus value (-948597
7718 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7719 reports time overflow. See
7720 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7721 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7722 * editfns.c: Include limits.h and intprops.h.
7723 (TIME_T_MIN, TIME_T_MAX): New macros.
7724 (time_overflow): Move earlier, to before first use.
7725 (hi_time, lo_time): New functions, for an accurate test for
7726 out-of-range times.
7727 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7728 (Fget_internal_run_time): Don't assume time_t fits in int.
7729 (make_time): Use list2 instead of Fcons twice.
7730 (Fdecode_time): More accurate test for out-of-range times.
7731 (check_tm_member): New function.
7732 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7733 (lisp_time_argument): Don't rely on undefined left-shift and
7734 right-shift behavior when checking for time stamp overflow.
8be6f318 7735
fe31d94c
PE
7736 * editfns.c (time_overflow): New function, refactoring common code.
7737 (Fformat_time_string, Fdecode_time, Fencode_time):
7738 (Fcurrent_time_string): Use it.
7739
8be6f318
PE
7740 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7741 * dired.c (make_time): Move to ...
7742 * editfns.c (make_time): ... here.
7743 * systime.h: Note the move.
7744
09d9db2c 77452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7746
126bc0dc
YM
7747 * fringe.c (update_window_fringes): Remove unused variables.
7748
c47cbdfd
YM
7749 * unexmacosx.c (copy_data_segment): Also copy __got section.
7750 (Bug#8223)
7751
7ac80be9
EZ
77522011-03-12 Eli Zaretskii <eliz@gnu.org>
7753
c96bbc66 7754 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7755 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7756 Constify `char *' arguments and their references according to
7757 prototypes in tparam.h.
7758
ecb0f94d 7759 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7760
7ac80be9
EZ
7761 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7762 Adapt all references accordingly.
7763
7764 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7765
ef1fd07e
TT
77662011-03-11 Tom Tromey <tromey@redhat.com>
7767
7768 * buffer.c (syms_of_buffer): Remove obsolete comment.
7769
7ef4b50c
EZ
77702011-03-11 Eli Zaretskii <eliz@gnu.org>
7771
7772 * termhooks.h (encode_terminal_code): Declare prototype.
7773
7774 * msdos.c (encode_terminal_code): Don't declare prototype.
7775
7776 * term.c (encode_terminal_code): Now external again, used by
7777 w32console.c and msdos.c.
7778
44f230aa
SM
7779 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7780 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7781
4b1ec863 77822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7783
1714f52b 7784 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7785
4b1ec863
PE
7786 * fringe.c (update_window_fringes): Mark locals as initialized
7787 (Bug#8227).
7788 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7789
524c7aa6
PE
7790 * alloc.c (mark_fringe_data): Move decl from here ...
7791 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7792 to check its interface.
7793 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7794
a5c0af81 7795 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7796 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7797 (fontset_font): Mark local as initialized.
a9a06e0b 7798 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7799
b4716021
PE
7800 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7801
811e9bac 7802 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7803 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7804 (x_own_selection, Fx_disown_selection_internal): Rename locals
7805 to avoid shadowing.
7806 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7807
7e3ab302
PE
7808 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7809 so that the caller can use some name other than gcpro1.
7810 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7811 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7812 (Fx_backspace_delete_keys_p):
7813 Use them to avoid shadowing, and rename vars to avoid shadowing.
7814 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7815 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7816 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7817 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7818 Remove unused locals.
7e3ab302
PE
7819 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7820 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7821 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7822 macros.
f78faa98 7823
e2b13473
PE
7824 * xterm.h (x_mouse_leave): New decl.
7825
77f23912
PE
7826 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7827 Remove unused functions.
cdf4ba58
PE
7828 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7829 (x_calc_absolute_position): Now static.
7411c686 7830 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7831 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7832 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7833 unless they are used.
38d0b34a
PE
7834 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7835 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7836 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7837 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7838 (x_error_catcher, x_connection_closed, x_error_handler):
7839 (x_error_quitter, xembed_send_message, x_iconify_frame):
7840 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7841 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7842 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7843
44f230aa
SM
7844 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7845 Rename or move locals to avoid shadowing.
6b463e58 7846 (tty_defined_color, merge_face_heights): Now static.
5967d051 7847 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7848 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7849 does not deduce is never used uninitialized.
73719eba
PE
7850 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7851 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7852
426994c3 7853 * terminal.c (store_terminal_param): Now static.
5489860b 7854
032f1620 7855 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7856 (set_frame_menubar): Remove unused local.
d4323972 7857 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7858 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7859 since they might point to immutable storage.
281585b0
PE
7860 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7861 since it's unused otherwise.
032f1620 7862
367c19e5 7863 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7864 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7865 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7866 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7867 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7868 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7869 does not deduce are never used uninitialized.
70739cbe 7870
07b48fa9
PE
7871 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7872
8868a238 7873 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7874 * window.c (window_loop, size_window):
7875 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7876
7e5cf297 7877 * window.c (display_buffer): Now static.
d6550a9f
PE
7878 (size_window): Mark variables that gcc -Wuninitialized
7879 does not deduce are never used uninitialized.
a586633d
PE
7880 * window.h (check_all_windows): New decl, to forestall
7881 gcc -Wmissing-prototypes diagnostic.
5b555da1 7882 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7883
f6095868
PE
7884 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7885 shadowing.
7886 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7887 Include <limits.h>.
7888 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7889 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7890 (load_charset_map): Mark variables that gcc -Wuninitialized
7891 does not deduce are never used uninitialized.
53df7c11 7892 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7893
f38b440c
PE
7894 * coding.c (coding_set_source, coding_set_destination):
7895 Use "else { /* comment */ }" rather than "else /* comment */;"
7896 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7897 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7898 a block, when the outer 'i' will do.
7899 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7900 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7901 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7902 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7903 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7904 Rename locals to avoid shadowing.
7905 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7906 * coding.c (emacs_mule_char, encode_invocation_designation):
7907 Now static, since they're not used elsewhere.
413bb2db 7908 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7909 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7910 (decode_coding_emacs_mule): Mark variables that gcc
7911 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7912 (detect_coding_iso_2022): Initialize a local variable that might
7913 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7914 this initialization is needed. (Bug#8211)
5f58e762
PE
7915 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7916 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7917 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7918 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7919 Remove unused macros.
f38b440c 7920
232b38b9 7921 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7922 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7923 * character.c (string_count_byte8): Likewise.
232b38b9 7924
fb90da1b
PE
7925 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7926 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7927
fb93dbc2
PE
7928 * chartab.c (copy_sub_char_table): Now static, since it's not used
7929 elsewhere.
5c156ace
PE
7930 (sub_char_table_ref_and_range, char_table_ref_and_range):
7931 Rename locals to avoid shadowing.
bbcd0949 7932 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7933
7d3b3862 7934 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7935 (BIDI_BOB): Remove unused macro.
7d3b3862 7936
6be7d3da
PE
7937 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7938 deduce are never used uninitialized.
c2ed9c8b 7939 * term.c (encode_terminal_code): Likewise.
6be7d3da 7940
75f8807f 7941 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7942
50938595
PE
7943 * tparam.h: New file.
7944 * term.c, tparam.h: Include it.
7945 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7946 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7947 Move these decls to tparam.h, and make them agree with what
7948 is actually in tparam.c. The previous trick of using incompatible
7949 decls in different modules does not conform to the C standard.
7950 All callers of tparam changed to use tparam's actual API.
7951 * tparam.c (tparam1, tparam, tgoto):
7952 Use const pointers where appropriate.
7953
fbceeba2
PE
7954 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7955 * cm.h (struct cm): Likewise.
7956 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7957 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7958 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7959 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7960 (turn_on_face, init_tty): Likewise.
7961 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7962
7f3f1250
PE
7963 * term.c (term_mouse_position): Rename local to avoid shadowing.
7964
e6ca6543
PE
7965 * alloc.c (mark_ttys): Move decl from here ...
7966 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7967
c40f8d15
AS
79682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7969
7970 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7971
cfe0661d
JB
79722011-03-09 Juanma Barranquero <lekktu@gmail.com>
7973
7974 * search.c (compile_pattern_1): Remove argument regp, unused since
7975 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7976 (compile_pattern): Don't pass it.
7977
0afb4571
J
79782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7979
7980 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7981 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7982 for ! HAVE_GTK3.
7983 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7984
7985 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7986
7987 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7988 gdk_window_get_screen, gdk_window_get_geometry,
7989 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7990 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7991 (xg_get_pixbuf_from_pixmap): New function.
7992 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7993 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7994 Call xg_get_pixbuf_from_pixmap instead of
7995 gdk_pixbuf_get_from_drawable.
7996 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7997 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7998 (xg_check_special_colors): Use GtkStyleContext and its functions
7999 for HAVE_GTK3.
8000 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8001 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8002 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8003 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8004 Call gtk_widget_get_preferred_size.
0afb4571
J
8005 (xg_frame_resized): gdk_window_get_geometry only takes 5
8006 parameters.
44f230aa
SM
8007 (xg_win_to_widget, xg_event_is_for_menubar):
8008 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8009 (xg_set_widget_bg): New function.
8010 (delete_cb): New function.
895009e1 8011 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8012 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8013 (xg_set_background_color): Call xg_set_widget_bg.
8014 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8015 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8016 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8017 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8018 if ! HAVE_GTK3.
8019 (update_frame_tool_bar): Call gtk_widget_hide.
8020 (xg_initialize): Use GDK_KEY_g.
8021
8022 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8023 if ! HAVE_GTK3
8024 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8025
8026 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8027 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8028 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8029
1c2cc4ef
JB
80302011-03-08 Juanma Barranquero <lekktu@gmail.com>
8031
8032 * w32xfns.c (select_palette): Check success of RealizePalette against
8033 GDI_ERROR, not zero.
8034
33383987 8035See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8036
8037;; Local Variables:
8038;; coding: utf-8
aac0c6e3
MR
8039;; End:
8040
33383987 8041 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8042
8043 This file is part of GNU Emacs.
8044
8045 GNU Emacs is free software: you can redistribute it and/or modify
8046 it under the terms of the GNU General Public License as published by
8047 the Free Software Foundation, either version 3 of the License, or
8048 (at your option) any later version.
8049
8050 GNU Emacs is distributed in the hope that it will be useful,
8051 but WITHOUT ANY WARRANTY; without even the implied warranty of
8052 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8053 GNU General Public License for more details.
8054
8055 You should have received a copy of the GNU General Public License
8056 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.