* chartab.c (Fchar_table_range): Use CHARACTERP to check range.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
8fd02eb7
PE
3 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4 Otherwise, an out-of-range integer could cause undefined behavior
5 on a 64-bit host.
6
f8c86b69
PE
7 * composite.c: Use int, not EMACS_INT, for characters.
8 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9 EMACS_INT, for values that are known to be in character range.
10 This doesn't fix any bugs but is the usual style inside Emacs and
11 may generate better code on 32-bit machines.
12
34206dd2
PE
13 Make sure a 64-bit char is never passed to ENCODE_CHAR.
14 This is for reasons similar to the recent CHAR_STRING fix.
15 * charset.c (Fencode_char): Check that character arg is actually
16 a character. Pass an int to ENCODE_CHAR.
17 * charset.h (ENCODE_CHAR): Verify that the character argument is no
18 wider than 'int', as a compile-time check to prevent future regressions
19 in this area.
20
c5958d4c 21 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
22
23 Make sure a 64-bit char is never passed to CHAR_STRING.
24 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
25 by silently ignoring the top 32 bits, allowing some values
26 that were far too large to be valid characters.
27 * character.h: Include <verify.h>.
28 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
29 arguments are no wider than unsigned, as a compile-time check
30 to prevent future regressions in this area.
31 * data.c (Faset):
32 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
33 (Fsubst_char_in_region):
34 * fns.c (concat):
35 * xdisp.c (decode_mode_spec_coding):
36 Adjust to CHAR_STRING's new requirement.
37 * editfns.c (Finsert_char, Fsubst_char_in_region):
38 * fns.c (concat): Check that character args are actually
39 characters. Without this test, these functions did the wrong
40 thing with wildly out-of-range values on 64-bit hosts.
41
ea204efb
PE
422011-06-12 Paul Eggert <eggert@cs.ucla.edu>
43
d37ca623
PE
44 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
45 These casts should not be needed on 32-bit hosts, either.
46 * keyboard.c (read_char):
47 * lread.c (Fload): Remove casts to unsigned.
48
ea204efb
PE
49 * lisp.h (UNSIGNED_CMP): New macro.
50 This fixes comparison bugs on 64-bit hosts.
51 (ASCII_CHAR_P): Use it.
52 * casefiddle.c (casify_object):
53 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
54 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
55 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
56 * dispextern.h (FACE_FROM_ID):
57 * keyboard.c (read_char): Use UNSIGNED_CMP.
58
fc83f7d3 592011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 60
41cb286c
PE
61 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
62 not to EMACS_INT, to avoid GCC warning.
63
4a1b9832
PE
64 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
65
55daad71
PE
66 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
67 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
68 isn't needed on 32-bit machines.
8f95c75c 69
666398f3 70 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 71 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
72
73 * data.c (Qcompiled_function): Now static.
74
c6f072e7
PE
75 * window.c (window_body_lines): Now static.
76
20ce5912
PE
77 * image.c (gif_load): Rename local to avoid shadowing.
78
9c4c5f81
PE
79 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
80 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
81 * alloc.c (make_save_value): Integer argument is now of type
82 ptrdiff_t, not int.
83 (mark_object): Use ptrdiff_t, not int.
84 * lisp.h (pD): New macro.
85 * print.c (print_object): Use it.
86
c0c5c8ae
PE
87 * alloc.c: Use EMACS_INT, not int, to count objects.
88 (total_conses, total_markers, total_symbols, total_vector_size)
89 (total_free_conses, total_free_markers, total_free_symbols)
90 (total_free_floats, total_floats, total_free_intervals, total_intervals)
91 (total_strings, total_free_strings):
92 Now EMACS_INT, not int. All uses changed.
93 (Fgarbage_collect): Compute overall total using a double, so that
94 integer overflow is less likely to be a problem. Check for overflow
95 when converting back to an integer.
5a25e253
PE
96 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
97 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
98 These were 'int' variables that could overflow on 64-bit hosts;
99 they were never used, so remove them instead of repairing them.
211a0b2a 100 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
101 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
102 Previously, this ceilinged at INT_MAX, but that doesn't work on
103 64-bit machines.
e46bb31a 104 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 105
c78baabf 106 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 107 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
108 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
109 when a (possibly-narrower) signed value would do just as well.
110 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 111
c9d624c6
PE
112 * alloc.c: Catch some string size overflows that we were missing.
113 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
114 for convenience in STRING_BYTES_MAX.
115 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
116 The definition here is exact; the one in lisp.h was approximate.
117 (allocate_string_data): Check for string overflow. This catches
118 some instances we weren't catching before. Also, it catches
119 size_t overflow on (unusual) hosts where SIZE_MAX <= min
120 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
121 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 122
c9d624c6
PE
123 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
124 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
125 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
126
353032ce
PE
127 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
128
2bccce07
PE
129 * alloc.c (Fmake_string): Check for out-of-range init.
130
b50691aa
CY
1312011-06-11 Chong Yidong <cyd@stupidchicken.com>
132
133 * dispextern.h (struct image): Replace data member, whose int_val
134 and ptr_val fields were not used by anything, with a single
135 lisp_val object.
136
137 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
138 (gif_clear_image, gif_load, imagemagick_load_image)
139 (gs_clear_image, gs_load): Callers changed.
140
3f754b86
PE
1412011-06-10 Paul Eggert <eggert@cs.ucla.edu>
142
cca69397
PE
143 * buffer.h: Include <time.h>, for time_t.
144 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
145
109e28d0
PE
146 Fix minor problems found by static checking.
147
60737f02
PE
148 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
149
4b66faf3
PE
150 Make identifiers static if they are not used in other modules.
151 * data.c (Qcompiled_function, Qframe, Qvector):
152 * image.c (QimageMagick, Qsvg):
153 * minibuf.c (Qmetadata):
154 * window.c (resize_window_check, resize_root_window): Now static.
155 * window.h (resize_window_check, resize_root_window): Remove decls.
156
109e28d0
PE
157 * window.c (window_deletion_count, delete_deletable_window):
158 Remove; unused.
46a4ce9e
PE
159 (window_body_lines): Now static.
160 (Fdelete_other_windows_internal): Mark vars as initialized.
161 Make sure 'resize_failed' is initialized.
162 (run_window_configuration_change_hook): Rename local to avoid shadowing.
163 (resize_window_apply): Remove unused local.
164 * window.h (delete_deletable_window): Remove decl.
165
109e28d0 166 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
167 (imagemagick_load_image): Fix pointer signedness problem by changing
168 last arg from unsigned char * to char *. All uses changed.
169 Also, fix a local for similar reasons.
170 Remove unused locals. Remove locals to avoid shadowing.
171 (fn_rsvg_handle_free): Remove; unused.
172 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 173 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 174
3f754b86
PE
175 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
176
2547adb1
CY
1772011-06-10 Chong Yidong <cyd@stupidchicken.com>
178
179 * image.c (gif_load): Fix omitted cast error introduced by
180 2011-06-06 change.
181
2c8e37d4
MR
1822011-06-10 Martin Rudalics <rudalics@gmx.at>
183
184 * window.h (resize_proportionally, orig_total_lines)
185 (orig_top_line): Remove from window structure.
186 (set_window_height, set_window_width, change_window_heights)
187 (Fdelete_window): Remove prototypes.
188 (resize_frame_windows): Remove duplicate declaration.
189
440a42e3
EZ
1902011-06-10 Eli Zaretskii <eliz@gnu.org>
191
192 * window.h (resize_frame_windows, resize_window_check)
193 (delete_deletable_window, resize_root_window)
194 (resize_frame_windows): Declare prototypes.
195
196 * window.c (resize_window_apply): Make definition be "static" to
197 match the prototype.
198
562dd5e9
MR
1992011-06-10 Martin Rudalics <rudalics@gmx.at>
200
201 * window.c: Remove declarations of Qwindow_size_fixed,
202 window_min_size_1, window_min_size_2, window_min_size,
203 size_window, window_fixed_size_p, enlarge_window, delete_window.
204 Remove static from declaration of Qdelete_window, it's
205 temporarily needed by Fbury_buffer.
206 (replace_window): Don't assign orig_top_line and
207 orig_total_lines.
208 (Fdelete_window, delete_window): Remove. Window deletion is
209 handled by window.el.
210 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
211 Fdelete_window calls with calls to Qdelete_window.
212 (Fdelete_other_windows): Remove. Deleting other windows is
213 handled by window.el.
214 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
215 handled in window.el.
216 (window_min_size_2, window_min_size_1, window_min_size): Remove.
217 Window minimum sizes are handled in window.el.
218 (shrink_windows, size_window, set_window_height)
219 (set_window_width, change_window_heights, window_height)
220 (window_width, CURBEG, CURSIZE, enlarge_window)
221 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
222 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
223 handled in window.el.
224 (make_dummy_parent): Rename to make_parent_window and give it a
225 second argument horflag.
226 (make_window): Don't set resize_proportionally any more.
227 (Fsplit_window): Remove. Windows are split in window.el.
228 (save_restore_action, save_restore_orig_size)
229 (shrink_window_lowest_first, save_restore_orig_size): Remove.
230 Resize mini windows in window.el.
231 (grow_mini_window, shrink_mini_window): Implement by calling
232 Qresize_root_window_vertically, resize_window_check and
233 resize_window_apply.
234 (saved_window, Fset_window_configuration, save_window_save): Do
235 not handle orig_top_line, orig_total_lines, and
236 resize_proportionally.
237 (window_min_height, window_min_width): Move to window.el.
238 (keys_of_window): Move bindings for delete-other-windows,
239 split-window, delete-window and enlarge-window to window.el.
240
241 * buffer.c: Temporarily extern Qdelete_window.
242 (Fbury_buffer): Temporarily call Qdelete_window instead of
243 Fdelete_window (Fbury_buffer will move to window.el soon).
244
245 * frame.c (set_menu_bar_lines_1): Remove code handling
246 orig_top_line and orig_total_lines.
247
248 * dispnew.c (adjust_frame_glyphs_initially): Don't use
249 set_window_height but set heights directly.
250 (change_frame_size_1): Use resize_frame_windows.
251
252 * xdisp.c (init_xdisp): Don't use set_window_height but set
253 heights directly.
254
255 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
256 resize_frame_windows instead of change_window_heights and run
257 run_window_configuration_change_hook.
258
259 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
260 instead of change_window_heights and run
261 run_window_configuration_change_hook.
262
1a13852e
MR
2632011-06-09 Martin Rudalics <rudalics@gmx.at>
264
265 * window.c (replace_window): Rename second argument REPLACEMENT to
266 NEW. New third argument SETFLAG. Rewrite.
267 (delete_window, make_dummy_parent): Call replace_window with
268 third argument 1.
269 (window_list_1): Move down in code.
270 (run_window_configuration_change_hook): Move set_buffer part
271 before select_frame_norecord part in order to unwind correctly.
272 Rename count1 to count.
273 (recombine_windows, delete_deletable_window, resize_root_window)
274 (Fdelete_other_windows_internal)
275 (Frun_window_configuration_change_hook, make_parent_window)
276 (resize_window_check, resize_window_apply, Fresize_window_apply)
277 (resize_frame_windows, Fsplit_window_internal)
278 (Fdelete_window_internal, Fresize_mini_window_internal): New
279 functions.
280 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
281
f3d1777e
MR
2822011-06-08 Martin Rudalics <rudalics@gmx.at>
283
496e208e
MR
284 * window.h (window): Add some new members to window structure -
285 normal_lines, normal_cols, new_total, new_normal, clone_number,
286 splits, nest, prev_buffers, next_buffers.
287 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 288 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 289
f3d1777e
MR
290 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
291 Remove.
496e208e
MR
292 (make_dummy_parent): Set new members of windows structure.
293 (make_window): Move down in code. Handle new members of window
294 structure.
295 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
296 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
297 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
298 (Fset_window_prev_buffers, Fwindow_next_buffers)
299 (Fset_window_next_buffers, Fset_window_clone_number): New
300 functions.
301 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
302 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
303 Doc-string fixes.
304 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
305 Argument WINDOW can be now internal window too.
306 (Fwindow_use_time): Move up in code.
307 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
308 Rewrite doc-string.
309 (Fset_window_configuration, saved_window)
310 (Fcurrent_window_configuration, save_window_save): Handle new
311 members of window structure.
b9e809c2
MR
312 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
313 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
314 (syms_of_window): New Lisp objects Qrecord_window_buffer,
315 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
316 Qget_mru_window, Qresize_root_window,
317 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
318 Qauto_buffer_name; staticpro them.
f3d1777e 319
abde8f8c
MR
3202011-06-07 Martin Rudalics <rudalics@gmx.at>
321
322 * window.c (Fwindow_total_size, Fwindow_left_column)
323 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
324 (Fwindow_list_1): New functions.
325 (window_box_text_cols): Replace with window_body_cols.
326 (Fwindow_width, Fscroll_left, Fscroll_right): Use
327 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
328 (delete_window, Fset_window_configuration): Call
329 delete_all_subwindows with window as argument.
330 (delete_all_subwindows): Take a window as argument and not a
331 structure. Rewrite.
190b47e6
MR
332 (window_loop): Remove handling of GET_LRU_WINDOW and
333 GET_LARGEST_WINDOW.
334 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
335
336 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
337 window_box_text_cols. delete_all_subwindows now takes a
338 Lisp_Object as argument.
abde8f8c
MR
339
340 * indent.c (compute_motion, Fcompute_motion): Use
341 window_body_cols instead of window_box_text_cols.
342
fa8a67e6
MR
343 * frame.c (delete_frame): Call delete_all_subwindows with root
344 window as argument.
345
a54e3482
DC
3462011-06-07 Daniel Colascione <dan.colascione@gmail.com>
347
348 * fns.c (Fputhash): Document return value.
349
60002bf5
CY
3502011-06-06 Chong Yidong <cyd@stupidchicken.com>
351
352 * image.c (gif_load): Implement gif89a spec "no disposal" method.
353
0c671da6 3542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 355
b862a52a 356 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 357
be44ca6c
PE
358 Check for overflow when converting integer to cons and back.
359 * charset.c (Fdefine_charset_internal, Fdecode_char):
360 Use cons_to_unsigned to catch overflow.
361 (Fencode_char): Use INTEGER_TO_CONS.
362 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
363 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
364 * data.c (long_to_cons, cons_to_long): Remove.
365 (cons_to_unsigned, cons_to_signed): New functions.
366 These signal an error for invalid or out-of-range values.
367 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
368 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
369 * font.c (Ffont_variation_glyphs):
370 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
371 * lisp.h: Include <intprops.h>.
372 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
373 (cons_to_signed, cons_to_unsigned): New decls.
374 (long_to_cons, cons_to_long): Remove decls.
375 * undo.c (record_first_change): Use INTEGER_TO_CONS.
376 (Fprimitive_undo): Use CONS_TO_INTEGER.
377 * xfns.c (Fx_window_property): Likewise.
378 * xselect.c: Include <limits.h>.
379 (x_own_selection, selection_data_to_lisp_data):
380 Use INTEGER_TO_CONS.
381 (x_handle_selection_request, x_handle_selection_clear)
382 (x_get_foreign_selection, Fx_disown_selection_internal)
383 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
384 (lisp_data_to_selection_data): Use cons_to_unsigned.
385 (x_fill_property_data): Use cons_to_signed.
386 Report values out of range.
387
d1f3d2af
PE
388 Check for buffer and string overflow more precisely.
389 * buffer.h (BUF_BYTES_MAX): New macro.
390 * lisp.h (STRING_BYTES_MAX): New macro.
391 * alloc.c (Fmake_string):
392 * character.c (string_escape_byte8):
393 * coding.c (coding_alloc_by_realloc):
394 * doprnt.c (doprnt):
395 * editfns.c (Fformat):
396 * eval.c (verror):
397 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
398 since they may not be the same number.
399 * editfns.c (Finsert_char):
400 * fileio.c (Finsert_file_contents):
401 Likewise for BUF_BYTES_MAX.
402
dd52fcea
PE
403 * image.c: Use ptrdiff_t, not int, for sizes.
404 (slurp_file): Switch from int to ptrdiff_t.
405 All uses changed.
406 (slurp_file): Check that file size fits in both size_t (for
407 malloc) and ptrdiff_t (for sanity and safety).
408
7f9bbdbb
PE
409 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
410 if b->modtime has its maximal value.
411
dfe18f82
PE
412 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
413
84acfcf0
PE
414 Don't assume time_t can fit into int.
415 * buffer.h (struct buffer.modtime): Now time_t, not int.
416 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
417 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
418
ccd9a01a
PE
419 Minor fixes for signed vs unsigned integers.
420 * character.h (MAYBE_UNIFY_CHAR):
421 * charset.c (maybe_unify_char):
422 * keyboard.c (read_char, reorder_modifiers):
423 XINT -> XFASTINT, since the integer must be nonnegative.
424 * ftfont.c (ftfont_spec_pattern):
425 * keymap.c (access_keymap, silly_event_symbol_error):
426 XUINT -> XFASTINT, since the integer must be nonnegative.
427 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
428 since it makes no difference and we prefer signed.
429 * keyboard.c (record_char): Use XUINT when all the neighbors do.
430 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
431 nonnegative.
432
d6d100dd
SM
4332011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
434
435 * window.h (Fwindow_frame): Declare.
436
2b6148e4
PE
4372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
438
439 * alloc.c: Simplify handling of large-request failures (Bug#8800).
440 (SPARE_MEMORY): Always define.
441 (LARGE_REQUEST): Remove.
442 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
443
f230ecc9
MR
4442011-06-06 Martin Rudalics <rudalics@gmx.at>
445
727e958e
MR
446 * lisp.h: Move EXFUNS for Fframe_root_window,
447 Fframe_first_window and Fset_frame_selected_window to window.h.
448
449 * window.h: Move EXFUNS for Fframe_root_window,
450 Fframe_first_window and Fset_frame_selected_window here from
451 lisp.h.
452
453 * frame.c (Fwindow_frame, Fframe_first_window)
454 (Fframe_root_window, Fframe_selected_window)
455 (Fset_frame_selected_window): Move to window.c.
456 (Factive_minibuffer_window): Move to minibuf.c.
457 (Fother_visible_frames_p): New function.
458
459 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
460
f230ecc9
MR
461 * window.c (decode_window, decode_any_window): Move up in code.
462 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
463 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
464 (Fwindow_buffer): Move up and rewrite doc-string.
465 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
466 (Fwindow_prev): New functions.
727e958e
MR
467 (Fwindow_frame): Move here from frame.c. Accept any window as
468 argument.
469 (Fframe_root_window, Fframe_first_window)
470 (Fframe_selected_window): Move here from frame.c. Accept frame
471 or arbitrary window as argument. Update doc-strings.
472 (Fminibuffer_window): Move up in code.
473 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
474 (Fset_frame_selected_window): Move here from frame.c.
475 Marginal rewrite.
727e958e
MR
476 (Fselected_window, select_window, Fselect_window): Move up in
477 code. Minor doc-string fixes.
f230ecc9 478
4d09bcf6
PE
4792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
480
481 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
482 Do not assume that spare memory exists; that assumption is valid
483 only if SYSTEM_MALLOC.
484 (LARGE_REQUEST): New macro, so that the issue of large requests
485 is separated from the issue of spare memory.
486
810928a2
AS
4872011-06-05 Andreas Schwab <schwab@linux-m68k.org>
488
172418ad
AS
489 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
490 format. (Bug#8806)
491
43f862f7
AS
492 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
493
810928a2
AS
494 * xfns.c (x_set_scroll_bar_default_width): Move declarations
495 before statements.
496
a059fe24
JD
4972011-06-05 Jan Djärv <jan.h.d@swipnet.se>
498
499 * gtkutil.c (xg_get_default_scrollbar_width): New function.
500
501 * gtkutil.h: Declare xg_get_default_scrollbar_width.
502
503 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
504 min width by calling x_set_scroll_bar_default_width (Bug#8505).
505
989bf368
JB
5062011-06-05 Juanma Barranquero <lekktu@gmail.com>
507
508 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
509
4b80f674
CY
5102011-06-04 Chong Yidong <cyd@stupidchicken.com>
511
512 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
513 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
514 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
515 New error handlers.
4b80f674
CY
516 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
517 Obey Vx_select_enable_clipboard_manager. Catch errors in
518 x_clipboard_manager_save (Bug#8779).
519 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 520 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 521
99a33b77 5222011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
523
524 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
525
99a33b77 5262011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
527
528 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
529 in the current matrix if keep_current_p is non-zero.
530
8264569d
EZ
5312011-06-04 Eli Zaretskii <eliz@gnu.org>
532
533 * bidi.c (bidi_level_of_next_char): Fix last change.
534
57f97249
EZ
5352011-06-03 Eli Zaretskii <eliz@gnu.org>
536
fec2107c 537 Support bidi reordering of text covered by display properties.
57f97249 538
fec2107c
EZ
539 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
540 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
541 (bidi_cache_search, bidi_cache_iterator_state)
542 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
543 (bidi_level_of_next_char, bidi_move_to_visually_next):
544 Support character positions inside a run of characters covered by a
fec2107c
EZ
545 display string.
546 (bidi_paragraph_init, bidi_resolve_explicit_1)
547 (bidi_level_of_next_char): Call bidi_fetch_char and
548 bidi_fetch_char_advance instead of FETCH_CHAR and
549 FETCH_CHAR_ADVANCE.
550 (bidi_init_it): Initialize new members.
551 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
552 definitions.
553 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
554 instead of using explicit *_CHAR codes.
d6d100dd
SM
555 (bidi_resolve_explicit, bidi_resolve_weak):
556 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
557 bidirectional text is supported only in multibyte buffers.
558 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
559 it to initialize the frame_window_p member of struct bidi_it.
560 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
561 (bidi_resolve_explicit, bidi_resolve_weak)
562 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
563 bidi_it->nchars is non-positive.
564 (bidi_level_of_next_char): Don't try to lookup the cache for the
565 next/previous character if nothing is cached there yet, or if we
566 were just reseat()'ed to a new position.
c40e2fb2 567
0e14fe90
EZ
568 * xdisp.c (set_cursor_from_row): Set start and stop points
569 according to the row's direction when priming the loop that looks
570 for the glyph on which to display cursor.
571 (single_display_spec_intangible_p): Function deleted.
572 (display_prop_intangible_p): Reimplement to call
573 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
574 Accept 3 additional arguments needed by handle_display_spec.
575 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
576 values: lists, `(when COND...)' forms, etc.
577 (single_display_spec_string_p): Support property values that are
578 lists with the argument STRING its top-level element.
579 (display_prop_string_p): Fix the condition for processing a
580 property that is a list to be consistent with handle_display_spec.
fec2107c 581 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
582 last portion of handle_display_prop.
583 (compute_display_string_pos): Accept additional argument
584 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
585 value of a `display' property is a "replacing spec".
586 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
587 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
588 the display property, but just return a value indicating whether
589 the display property will replace the characters it covers.
590 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
591 frame_window_p members of struct bidi_it.
d6d100dd
SM
592 (compute_display_string_pos, compute_display_string_end):
593 New functions.
fec2107c
EZ
594 (push_it): Accept second argument POSITION, where pop_it should
595 jump to continue iteration.
596 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 597
fec2107c
EZ
598 * keyboard.c (adjust_point_for_property): Adjust the call to
599 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
600
601 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
602 (bidi_init_it): Update prototypes.
603 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
604 (compute_display_string_pos, compute_display_string_end):
605 Declare prototypes.
fec2107c
EZ
606 (struct bidi_it): New members nchars and disp_pos. ch_len is now
607 EMACS_INT.
fc6f18ce 608
40087514 6092011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 610
57f53182
PE
611 Malloc failure behavior now depends on size of allocation.
612 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
613 * lisp.h: Change signatures accordingly.
614 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
615 All callers changed. (Bug#8762)
616
617 * gnutls.c: Use Emacs's memory allocators.
618 Without this change, the gnutls library would invoke malloc etc.
619 directly, which causes problems on non-SYNC_INPUT hosts, and which
620 runs afoul of improving memory_full behavior. (Bug#8761)
621 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
622 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
623 xfree instead of the default malloc, realloc, free.
624 (Fgnutls_boot): No need to check for memory allocation failure,
625 since xmalloc does that for us.
626
ac32cd99 627 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
628 * category.c (hash_get_category_set):
629 * ccl.c (ccl_driver):
630 * charset.c (Fdefine_charset_internal):
631 * charset.h (struct charset.hash_index):
632 * composite.c (get_composition_id, gstring_lookup_cache)
633 (composition_gstring_put_cache):
634 * composite.h (struct composition.hash_index):
635 * dispextern.h (struct image.hash):
636 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
637 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
638 (hashfn_equal, hashfn_user_defined, make_hash_table)
639 (maybe_resize_hash_table, hash_lookup, hash_put)
640 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
641 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
642 (Fsxhash, Fgethash, Fputhash, Fmaphash):
643 * image.c (make_image, search_image_cache, lookup_image)
644 (xpm_put_color_table_h):
645 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 646 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
647 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
648 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
649 * alloc.c (allocate_vectorlike):
650 Check for overflow in vector size calculations.
651 * ccl.c (ccl_driver):
652 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
653 * fns.c, image.c: Remove unnecessary static decls that would otherwise
654 need to be updated by these changes.
40087514
PE
655 * fns.c (make_hash_table, maybe_resize_hash_table):
656 Check for integer overflow with large hash tables.
0de4bb68
PE
657 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
658 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
659 (SXHASH_REDUCE): New macro.
660 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
661 Use it instead of discarding useful hash info with large hash values.
662 (sxhash_float): New function.
663 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
664 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
665 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
666 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
667 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
668 Adjust signatures to match updated version of code.
669 (consing_since_gc): Now EMACS_INT, since a single hash table can
670 use more than INT_MAX bytes.
671
698d32e2
DN
6722011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
673
674 Make it possible to build with GCC-4.6+ -O2 -flto.
675
676 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
677
fd6fa53f
SM
6782011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
679
680 * minibuf.c (get_minibuffer, read_minibuf_unwind):
681 Call minibuffer-inactive-mode.
682
864db017
JB
6832011-05-31 Juanma Barranquero <lekktu@gmail.com>
684
685 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
686 Update dependencies.
687
2ad0baf4
DN
6882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
689
690 * data.c (init_data): Remove code for UTS, this system is not
691 supported anymore.
692
4fcc2638
DN
6932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
694
695 Don't force ./temacs to start in terminal mode.
696
697 * frame.c (make_initial_frame): Initialize faces in all cases, not
698 only when CANNOT_DUMP is defined.
699 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
700
c56e0fd5
DN
7012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
702
703 * dispnew.c (add_window_display_history): Use const for the string
704 pointer. Remove declaration, not needed.
705
333d54da 7062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 707
55d4c1b2 708 Use 'inline', not 'INLINE'.
333d54da 709 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
710 * alloc.c, fontset.c (INLINE): Remove.
711 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
712 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
713 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
714 * gmalloc.c (register_heapinfo): Use inline unconditionally.
715 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
716
738db178
DN
7172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
718
719 Make it possible to run ./temacs.
720
721 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
722 syms_of_callproc does the same thing. Remove test for
723 "initialized", do it in the caller.
724 * emacs.c (main): Avoid calling set_initial_environment when dumping.
725
620c53a6
SM
7262011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
727
728 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
729 (read_minibuf): Use get_minibuffer.
730 (syms_of_minibuf): Use DEFSYM.
731 (Qmetadata): New var.
732 * data.c (Qbuffer): Don't make it static.
733 (syms_of_data): Use DEFSYM.
734
e003a292
PE
7352011-05-31 Paul Eggert <eggert@cs.ucla.edu>
736
737 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
738 (CCL_CODE_MIN): New macro.
739
ed008a6d
PE
7402011-05-30 Paul Eggert <eggert@cs.ucla.edu>
741
3687c2ef
PE
742 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
743
ed008a6d
PE
744 * eval.c (Qdebug): Now static.
745 * lisp.h (Qdebug): Remove decl. This reverts a part of the
746 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
747 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
748
d66c4c7c
CY
7492011-05-29 Chong Yidong <cyd@stupidchicken.com>
750
751 * image.c: Various fixes to ImageMagick code comments.
752 (Fimagemagick_types): Doc fix.
753
5fbc2025
PE
7542011-05-29 Paul Eggert <eggert@cs.ucla.edu>
755
0196f88a
PE
756 Minor fixes prompted by GCC 4.6.0 warnings.
757
758 * xselect.c (converted_selections, conversion_fail_tag): Now static.
759
5fbc2025
PE
760 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
761 (x_clipboard_manager_save_all): Move extern decl to ...
762 * xterm.h: ... here, so that it can be checked for consistency.
763
1dd3c2d9
CY
7642011-05-29 Chong Yidong <cyd@stupidchicken.com>
765
766 * xselect.c (x_clipboard_manager_save_frame)
767 (x_clipboard_manager_save_all): New functions.
768 (Fx_clipboard_manager_save): Lisp function deleted.
769
770 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
771 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
772
773 * xterm.h: Update prototype.
774
5ba6571d
WX
7752011-05-28 William Xu <william.xwl@gmail.com>
776
777 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
778 exiting (Bug#8239).
779
3eaff834
JM
7802011-05-28 Jim Meyering <meyering@redhat.com>
781
e1900994 782 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
783 * fns.c (to_uchar): Define.
784 (crypto_hash_function): Use it to convert some newly-signed
785 variables to unsigned, to avoid sign-extension bugs. For example,
786 without this change, (md5 "truc") would evaluate to
787 45723a2aff78ff4fff7fff1114760e62 rather than the expected
788 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 789 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 790
0f6990a7
PE
7912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
792
793 Integer overflow fixes.
c8a9ca5a 794
08686060
PE
795 * dbusbind.c: Serial number integer overflow fixes.
796 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
797 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
798 to hold a serial number that is too large for a fixnum.
799 (Fdbus_method_return_internal, Fdbus_method_error_internal):
800 Check for serial numbers out of range. Decode any serial number
59568bf0 801 that was so large that it became a float. (Bug#8722)
08686060 802
2d1fc3c7
PE
803 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
804 (Fdbus_call_method, Fdbus_call_method_asynchronously):
805 Use XFASTINT rather than XUINT when numbers are nonnegative.
806 (xd_append_arg, Fdbus_method_return_internal):
807 (Fdbus_method_error_internal): Likewise. Also, for unsigned
808 arguments, check that Lisp number is nonnegative, rather than
59568bf0 809 silently wrapping negative numbers around. (Bug#8722)
30217ff0 810 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 811 (Bug#8722)
2d1fc3c7 812
c8a9ca5a
PE
813 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
814
519e1d69
PE
815 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
816
30569699
PE
817 ccl: add integer overflow checks
818 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
819 (IN_INT_RANGE): New macros.
820 (ccl_driver): Use them to check for integer overflow when
821 decoding a CCL program. Many of the new checks are whether XINT (x)
822 fits in int; it doesn't always, on 64-bit hosts. The new version
823 doesn't catch all possible integer overflows, but it's an
847044ea 824 improvement. (Bug#8719)
30569699 825
c11285dc
PE
826 * alloc.c (make_event_array): Use XINT, not XUINT.
827 There's no need for unsigned here.
828
fdccd48e
PE
829 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
830 This follows up to the 2011-05-06 change that substituted uintptr_t
831 for EMACS_INT. This case wasn't caught back then.
832
37910ab2
PE
833 Rework Fformat to avoid integer overflow issues.
834 * editfns.c: Include <float.h> unconditionally, as it's everywhere
835 now (part of C89). Include <verify.h>.
836 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
837 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
838 (Fformat): Avoid the prepass trying to compute sizes; it was only
839 approximate and thus did not catch overflow reliably. Instead, walk
840 through the format just once, formatting and computing sizes as we go,
841 checking for integer overflow at every step, and allocating a larger
842 buffer as needed. Keep track separately whether the format is
843 multibyte. Keep only the most-recently calculated precision, rather
844 than them all. Record whether each argument has been converted to
845 string. Use EMACS_INT, not int, for byte and char and arg counts.
846 Support field widths and precisions larger than INT_MAX. Avoid
847 sprintf's undefined behavior with conversion specifications such as %#d
848 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
849 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
850 formatting out-of-range floating point numbers with int
851 formats. (Bug#8668)
852
2e6578fb
PE
853 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
854
0ae6bdee
PE
855 * data.c: Avoid integer truncation in expressions involving floats.
856 * data.c: Include <intprops.h>.
857 (arith_driver): When there's an integer overflow in an expression
858 involving floating point, convert the integers to floating point
859 so that the resulting value does not suffer from catastrophic
860 integer truncation. For example, on a 64-bit host (* 4
861 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
862 Do not rely on undefined behavior after integer overflow.
863
de883a70
PE
864 merge count_size_as_multibyte, parse_str_to_multibyte
865 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 866 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
867 Check for integer overflow.
868 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
869 since it's now a duplicate of the other. This is more of
870 a character than a buffer op, so better that it's in character.c.
871 * fns.c, print.c: Adjust to above changes.
872
2ff916cb
PE
8732011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
874
875 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
876
f1b54466
PE
8772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
878
fb1ac845
PE
879 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
880 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
881 (x_clipboard_manager_save): Now static.
882 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
883
f1b54466
PE
884 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
885 (crypto_hash_function): Now static.
886 Fix pointer signedness problems. Avoid unnecessary initializations.
887
a9f737ee
CY
8882011-05-27 Chong Yidong <cyd@stupidchicken.com>
889
890 * termhooks.h (Vselection_alist): Make it terminal-local.
891
892 * terminal.c (create_terminal): Initialize it.
893
894 * xselect.c: Support for clipboard managers.
895 (Vselection_alist): Move to termhooks.h as terminal-local var.
896 (LOCAL_SELECTION): New macro.
897 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
898 (symbol_to_x_atom): Remove gratuitous arg.
899 (x_handle_selection_request, lisp_data_to_selection_data)
900 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
901 (x_own_selection, x_get_local_selection, x_convert_selection):
902 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
903 (some_frame_on_display): Delete unused function.
904 (Fx_own_selection_internal, Fx_get_selection_internal)
905 (Fx_disown_selection_internal, Fx_selection_owner_p)
906 (Fx_selection_exists_p): New optional frame arg.
907 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
908 (x_handle_selection_clear): Don't treat other terminals with the
909 same keyboard specially. Use the terminal-local Vselection_alist.
910 (x_clear_frame_selections): Use Frun_hook_with_args.
911
912 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
913
914 * xterm.h: Add support for those atoms.
915
e067f0c1
CY
9162011-05-26 Chong Yidong <cyd@stupidchicken.com>
917
918 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
919 (converted_selections, conversion_fail_tag): New global variables.
920 (x_selection_request_lisp_error): Free the above.
921 (x_get_local_selection): Remove unnecessary code.
922 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
923 of converted selections stored in converted_selections.
924 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
925 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
926 (x_convert_selection): New function.
927 (x_handle_selection_event): Simplify.
928 (x_get_foreign_selection): Don't ignore incoming requests while
929 waiting for an answer; this will fail when we implement
930 SAVE_TARGETS, and seems unnecessary anyway.
931 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
932 (Vx_sent_selection_functions): Doc fix.
933
0f4aebc0
LL
9342011-05-26 Leo Liu <sdl.web@gmail.com>
935
936 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
937
e61124cd
YM
9382011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
939
940 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
941
942 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
943 for fringe update if it has periodic bitmap.
944 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
945 and fringe_bitmap_periodic_p.
946
947 * fringe.c (get_fringe_bitmap_data): New function.
948 (draw_fringe_bitmap_1, update_window_fringes): Use it.
949 (update_window_fringes): Record periodicity of fringe bitmap in glyph
950 row. Mark glyph row for fringe update if periodicity changed.
951
952 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
953 for fringe update unless it has periodic bitmap.
954
f16d9837
KH
9552011-05-25 Kenichi Handa <handa@m17n.org>
956
957 * xdisp.c (get_next_display_element): Set correct it->face_id for
958 a static composition.
959
e1b90ef6
LL
9602011-05-24 Leo Liu <sdl.web@gmail.com>
961
962 * deps.mk (fns.o):
963 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
964
965 * fns.c (crypto_hash_function, Fsha1): New function.
966 (Fmd5): Use crypto_hash_function.
967 (syms_of_fns): Add Ssha1.
968
7400048f
PE
9692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
970
971 * gnutls.c: Remove unused macros.
972 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
973 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
974 Remove macros that are defined and never used.
975 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
976
abb71cf4
CY
9772011-05-22 Chong Yidong <cyd@stupidchicken.com>
978
979 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
980 (Fx_get_selection_internal): Minor cleanup.
981 (Fx_own_selection_internal): Rename arguments for consistency with
982 select.el.
983
6307db39
PE
9842011-05-22 Paul Eggert <eggert@cs.ucla.edu>
985
986 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
987
f3d4e0a4
CY
9882011-05-22 Chong Yidong <cyd@stupidchicken.com>
989
990 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
991
4d8ade89
YM
9922011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
993
994 * dispnew.c (scrolling_window): Don't exclude the case that the
995 last enabled row in the desired matrix touches the bottom boundary.
996
32078c8d
GM
9972011-05-21 Glenn Morris <rgm@gnu.org>
998
999 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1000 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1001 and add some more files.
32078c8d 1002
7285dc67
EZ
10032011-05-20 Eli Zaretskii <eliz@gnu.org>
1004
1005 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1006 report_file_error introduced by the change from 2011-05-07.
1007
89d1bd22
PE
10082011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 * systime.h (Time): Define only if emacs is defined.
1011 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1012 where the include path doesn't have X11/X.h by default. See
1013 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1014
e23640bb 10152011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1016
1017 * composite.c (find_automatic_composition): Fix previous change.
1018
b9704ad9
GM
10192011-05-20 Glenn Morris <rgm@gnu.org>
1020
1021 * lisp.mk: New file, split from Makefile.in.
1022 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1023 (shortlisp): Remove.
1024 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1025
4a720484
GM
10262011-05-19 Glenn Morris <rgm@gnu.org>
1027
1028 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1029 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1030 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1031 (lisp): Set the order to that of loadup.el.
1032 (shortlisp): Make it a copy of $lisp.
1033 (SOME_MACHINE_LISP): Remove.
1034 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1035 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1036
a28d4396
KH
10372011-05-18 Kenichi Handa <handa@m17n.org>
1038
1039 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1040 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1041 (find_automatic_composition): Mostly rewrite for efficiency.
1042
a2b1fa8e
JB
10432011-05-18 Juanma Barranquero <lekktu@gmail.com>
1044
1045 * makefile.w32-in: Update dependencies.
1046
8e1f5610
CS
10472011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1048
1049 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1050 revision 104625).
1051
7025ee00 10522011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1053
cdfa6eab
PE
1054 Fix some integer overflow issues, such as string length overflow.
1055
06d6db33
PE
1056 * insdel.c (count_size_as_multibyte): Check for string overflow.
1057
2b4560a8
PE
1058 * character.c (lisp_string_width): Check for string overflow.
1059 Use EMACS_INT, not int, for string indexes and lengths; in
1060 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1061 the resulting string length overflows an EMACS_INT; instead,
1062 report a string overflow if no precision given. When checking for
1063 precision exhaustion, use a check that cannot possibly have
1064 integer overflow. (Bug#8675)
1065 * character.h (lisp_string_width): Adjust to new signature.
1066
cb93f9be
PE
1067 * alloc.c (string_overflow): New function.
1068 (Fmake_string): Use it. This doesn't change behavior, but saves
1069 a few bytes and will simplify future changes.
1070 * character.c (string_escape_byte8): Likewise.
1071 * lisp.h (string_overflow): New decl.
1072
1a1f3366
PE
1073 Fixups, following up to the user-interface timestamp change.
1074 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1075 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1076 * msdos.c (mouse_get_pos): Likewise.
1077 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1078 * w32gui.h (Time): Define by including "systime.h" rather than by
1079 declaring it ourselves. (Bug#8664)
1080
d4e3e4d3
PE
1081 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1082 * image.c (clear_image_cache): Likewise.
1083
f6a24d19
PE
1084 * term.c (term_mouse_position): Don't assume time_t wraparound.
1085
08dc5ae6
PE
1086 Be more systematic about user-interface timestamps.
1087 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1088 and sometimes 'EMACS_UINT', to represent these timestamps.
1089 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1090 This makes the code easier to follow, and makes it easier to catch
1091 integer overflow bugs such as Bug#8664.
1092 * frame.c (Fmouse_position, Fmouse_pixel_position):
1093 Use Time, not unsigned long, for user-interface timestamps.
1094 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1095 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1096 * keyboard.h (last_event_timestamp): Likewise.
1097 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1098 * menu.h (xmenu_show): Likewise.
1099 * term.c (term_mouse_position): Likewise.
1100 * termhooks.h (struct input_event.timestamp): Likewise.
1101 (struct terminal.mouse_position_hook): Likewise.
1102 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1103 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1104 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1105 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1106 what it was before.
1107 * menu.h, termhooks.h: Include "systime.h", for Time.
1108
8e55734a
PE
1109 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1110 Don't assume that the difference between two unsigned long values
1111 can fit into an integer. At this point, we know button_down_time
1112 <= event->timestamp, so the difference must be nonnegative, so
1113 there's no need to cast the result if double-click-time is
1114 nonnegative, as it should be; check that it's nonnegative, just in
1115 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1116 apart (about 25 days). (Bug#8664)
8e55734a 1117
841f1b75 1118 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1119 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1120
3e26f69c
PE
1121 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1122 that always fit in int. Use a sentinel instead of a counter, to
1123 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1124 * frame.h (struct frame): Use int for menu_bar_items_used
1125 instead of EMACS_INT, since it always fits in int.
3e26f69c 1126
5cc152c0
PE
1127 * menu.c (grow_menu_items): Check for int overflow.
1128
d89eb65e
PE
1129 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1130
5235bd3e
PE
1131 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1132 Before, the code was not consistent. These values cannot exceed
1133 2**31 - 1 so there's no need to make them unsigned.
1134 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1135 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1136 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1137 as modifiers.
1138 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1139
bc827e23
PE
1140 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1141 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1142 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1143 presumably because the widths might not match.
1144
78eb494e
PE
1145 * window.c (size_window): Avoid needless test at loop start.
1146
04f2d78b
CB
11472011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1148
1149 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1150
d2fc7e3d 11512011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1152
1153 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1154
d2fc7e3d 11552011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1156
1157 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1158 `width' to `bar_area_x' and `bar_area_width', respectively.
1159 (x_scroll_run): Take account of fringe background extension.
1160
04f2d78b
CB
1161 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1162 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1163 `bar_area_width', respectively.
1164 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1165 background extension.
1166
79b70037
GM
11672011-05-10 Jim Meyering <meyering@redhat.com>
1168
1169 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1170
2f142cc5
JB
11712011-05-10 Juanma Barranquero <lekktu@gmail.com>
1172
1173 * image.c (Finit_image_library): Return t for built-in image types,
1174 like pbm and xbm. (Bug#8640)
1175
57679c86
AS
11762011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1177
1178 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1179
888c9e86
EZ
11802011-05-07 Eli Zaretskii <eliz@gnu.org>
1181
b0512a1d
EZ
1182 * w32console.c (Fset_screen_color): Doc fix.
1183 (Fget_screen_color): New function.
1184 (syms_of_ntterm): Defsubr it.
1185
7285dc67
EZ
1186 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1187 unlink the temporary file if Fcall_process didn't create it in the
1188 first place.
1189 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1190 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1191 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1192 cue to call_process_cleanup not to close that handle.
1193
4d3fcc8e
BK
11942011-05-07 Ben Key <bkey76@gmail.com>
1195
1196 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1197 one of two shell specific rules, either bootstrap-temacs-CMD or
1198 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1199 to the previous implementation of the bootstrap-temacs rule.
1200 The bootstrap-temacs-CMD rule is similar to the previous
1201 implementation of the bootstrap-temacs rule except that it
1202 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1203 variable.
1204
1205 These changes, along with some changes to nt/configure.bat,
1206 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1207 earlier fix to add support for --cflags and --ldflags options
1208 that include quotes so that it works whether make uses cmd or
1209 sh as the shell.
1210
b4289b64
MA
12112011-05-06 Michael Albinus <michael.albinus@gmx.de>
1212
1213 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1214 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1215 is a constant.
1216 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1217 a string. Handle both cases.
1218 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1219 (Fdbus_register_method): Use Qinvalid_function.
1220
af4c0e28
JB
12212011-05-06 Juanma Barranquero <lekktu@gmail.com>
1222
1223 * makefile.w32-in: Update dependencies.
1224 (LISP_H): Add inttypes.h and stdin.h.
1225 (PROCESS_H): Add unistd.h.
1226
c51453d9
EZ
12272011-05-06 Eli Zaretskii <eliz@gnu.org>
1228
1229 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1230 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1231
8ff0ac3c 12322011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1233
4c4b566b
PE
1234 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1235
aab2b9b5
PE
1236 * term.c (vfatal): Remove stray call to va_end.
1237 It's not needed and the C Standard doesn't allow it here anyway.
1238
c378da0b
PE
1239 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1240 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1241
288b08c7
PE
1242 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1243 bytes.
1244
e3601888
PE
1245 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1246
db6c0e74
PE
1247 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1248
dd5963ea
PE
1249 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1250
88c9450f
PE
1251 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1252
2f9442b8
PE
1253 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1254
c032b5f8
PE
1255 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1256 * charset.c (Fdefine_charset_internal): Don't initialize
1257 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1258 32-bit int (Bug#8600).
a108c10b
PE
1259
1260 * lread.c (read_integer): Be more consistent with string-to-number.
1261 Use string_to_number to do the actual conversion; this avoids
1262 rounding errors and fixes some other screwups. Without this fix,
1263 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1264 (digit_to_number): Move earlier, for benefit of read_integer.
1265 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1266 not a digit in any supported base. (Bug#8602)
a108c10b 1267
ad5f9eea
PE
1268 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1269
aec1708a
PE
1270 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1271 to match comment at start of function. This also removes a
1272 GCC warning about overflow in a 32+64-bit port.
1273
47be4ab5
PE
1274 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1275
371cac43
PE
1276 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1277 Reported by Stefan Monnier in
1278 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1279 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1280 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1281
d01a7826
PE
1282 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1283 (EMACS_UINTPTR): Likewise, with uintptr_t.
1284
7fd47d5c
PE
1285 * lisp.h: Prefer 64-bit EMACS_INT if available.
1286 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1287 on 32-bit hosts that have 64-bit int, so that they can access
1288 large files.
122b0c86
PE
1289 However, temporarily disable this change unless the temporary
1290 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1291
8727937b
PE
1292 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1293
8ac068ac
PE
1294 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1295 This removes an assumption that EMACS_INT and long are the same
1296 width as pointers. The assumption is true for Emacs porting targets
1297 now, but we want to make other targets possible.
1298 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1299 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1300 In the rest of the code, change types of integers that hold casted
1301 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1302 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1303 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1304 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1305 No need to cast type when ORing.
1306 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1307 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1308 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1309 assume EMACS_INT is the same width as char *.
1310 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1311 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1312 Remove no-longer-needed casts.
1313 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1314 (xg_tool_bar_help_callback, xg_make_tool_item):
1315 Use EMACS_INTPTR to hold an integer
1316 that will be cast to void *; this can avoid a GCC warning
1317 if EMACS_INT is not the same width as void *.
1318 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1319 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1320 (current_message_1, set_message_1):
1321 Use a local to convert to proper width without a cast.
1322 * xmenu.c (dialog_selection_callback): Likewise.
1323
ede49d71
PE
1324 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1325 Also, don't assume VALBITS / RAND_BITS is less than 5,
1326 and don't rely on undefined behavior when shifting a 1 left into
1327 the sign bit.
1328 * lisp.h (get_random): Change signature to match.
1329
2f30ecd0
PE
1330 * lread.c (hash_string): Use size_t, not int, for hash computation.
1331 Normally we prefer signed values; but hashing is special, because
1332 it's better to use unsigned division on hash table sizes so that
1333 the remainder is nonnegative. Also, size_t is the natural width
1334 for hashing into memory. The previous code used 'int', which doesn't
1335 retain enough info to hash well into very large tables.
1336 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1337
2a866e7b
PE
1338 * dbusbind.c: Don't possibly lose pointer info when converting.
1339 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1340 Use XPNTR rather than XHASH, so that the high-order bits of
1341 the pointer aren't lost when converting through void *.
1342
51639eac
PE
1343 * eval.c (Fautoload): Don't double-shift a pointer.
1344
92394119
PE
1345 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1346
dbdb9a7c
JB
13472011-05-06 Juanma Barranquero <lekktu@gmail.com>
1348
1349 * gnutls.c (DEF_GNUTLS_FN):
1350 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1351
db7a0b4f
AS
13522011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1353
1354 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1355 marker. (Bug#8610)
1356
f7ff1b0f 13572011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1358
1359 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1360 New version that can reserve upto 2GB of heap space.
1361
f7ff1b0f 13622011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1363
1364 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1365
639c109b
TZ
13662011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1367
1368 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1369 `gnutls_certificate_set_x509_key_file'.
1370
d2127135
JB
13712011-05-05 Juanma Barranquero <lekktu@gmail.com>
1372
1373 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1374 Update dependencies.
1375
e968f4f3
JB
13762011-05-04 Juanma Barranquero <lekktu@gmail.com>
1377
1378 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1379 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1380 Remove unused parameter `fildes'.
1381 * process.c (read_process_output, send_process): Don't pass it.
1382
84d358f0
JB
13832011-05-04 Juanma Barranquero <lekktu@gmail.com>
1384
1385 Fix previous change: the library cache is defined in w32.c.
1386 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1387 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1388
0898ca10
JB
13892011-05-04 Juanma Barranquero <lekktu@gmail.com>
1390
1391 Implement dynamic loading of GnuTLS on Windows.
1392
1393 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1394 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1395 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1396 Declare.
1397
1398 * gnutls.c (Qgnutls_dll): Define.
1399 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1400 (gnutls_*): Declare function pointers.
1401 (init_gnutls_functions): New function to initialize function pointers.
1402 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1403 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1404 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1405 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1406 (emacs_gnutls_write, emacs_gnutls_read)
1407 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1408 (Fgnutls_available_p): New function.
1409 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1410 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1411 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1412
1413 * image.c: Include w32.h.
1414 (Vimage_type_cache): Delete.
1415 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1416 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1417 (w32_delayed_load): Move to w32.c.
1418
1419 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1420
1421 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1422 (w32_delayed_load): Move from image.c. When loading a library, record
1423 its filename in the :loaded-from property of the library id.
1424 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1425 Initialize and staticpro them.
1426 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1427
1428 * process.c: Include lisp.h before w32.h, not after.
1429 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1430 instead of gnutls_record_check_pending.
1431
1432 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1433
ff4de4aa
TZ
14342011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1435
1436 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1437 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1438 as passed in.
1439
abe95abb
JD
14402011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1441
1442 * xterm.c (x_set_frame_alpha): Do not set property on anything
1443 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1444
e16e55d4
JB
14452011-05-02 Juanma Barranquero <lekktu@gmail.com>
1446
1447 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1448
bafcf6a5
JB
14492011-05-02 Juanma Barranquero <lekktu@gmail.com>
1450
1451 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1452 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1453 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1454 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1455 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1456 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1457 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1458 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1459 (Qgnutls_bootprop_callbacks_verify): Make static.
1460
e7a6747f
AS
14612011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1462
19ed11ba
AS
1463 * callproc.c: Indentation fixup.
1464
e7a6747f 1465 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1466 (wait_for_termination, interruptible_wait_for_termination):
1467 Move after wait_for_termination_1.
e7a6747f 1468
1ef14cb4
LMI
14692011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1470
1471 * sysdep.c (interruptible_wait_for_termination): New function
1472 which is like wait_for_termination, but allows keyboard
1473 interruptions.
1474
1475 * callproc.c (Fcall_process): Add (:file "file") as an option for
1476 the STDOUT buffer.
1477 (Fcall_process_region): Ditto.
1478
330d880c
EZ
14792011-04-30 Eli Zaretskii <eliz@gnu.org>
1480
8db90b73
EZ
1481 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1482 rather than `XVECTOR (FOO)->size'.
1483
330d880c
EZ
1484 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1485 inttypes.h, as a gnulib replacement is used if it not available in
1486 system headers.
1487
15cbd324
EZ
14882011-04-21 Eli Zaretskii <eliz@gnu.org>
1489
1490 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1491 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1492 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1493
1494 * coding.c (coding_alloc_by_realloc): Error out if destination
1495 will grow beyond MOST_POSITIVE_FIXNUM.
1496 (decode_coding_emacs_mule): Abort if there isn't enough place in
1497 charbuf for the composition carryover bytes. Reserve an extra
1498 space for up to 2 characters produced in a loop.
1499 (decode_coding_iso_2022): Abort if there isn't enough place in
1500 charbuf for the composition carryover bytes.
1501
15022011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1503
ae940cca
EZ
1504 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1505 aborting when %lld or %lll format is passed.
1506 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1507 %llo or %llx format is passed. (Bug#8545)
1508
03ab8921
EZ
1509 * window.c (window_scroll_line_based): Use a marker instead of
1510 simple variables to record original value of point. (Bug#7952)
1511
afda1437
EZ
1512 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1513 produced by %s or %c overflows available buffer space. (Bug#8545)
1514
f76dee0c
PE
15152011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1518 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1519
fdc5744d
JB
15202011-04-28 Juanma Barranquero <lekktu@gmail.com>
1521
1522 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1523
638f053a
JB
15242011-04-28 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * keyboard.c (Qdelayed_warnings_hook): Define.
1527 (command_loop_1): Run `delayed-warnings-hook'
1528 if Vdelayed_warnings_list is non-nil.
1529 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1530 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1531
d178f871
EZ
15322011-04-28 Eli Zaretskii <eliz@gnu.org>
1533
1534 * doprnt.c (doprnt): Don't return value smaller than the buffer
1535 size if the message was truncated. (Bug#8545).
1536
b124fd93
JB
15372011-04-28 Juanma Barranquero <lekktu@gmail.com>
1538
1539 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1540 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1541
e810457d
PE
15422011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1543
1544 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1545
ea51cceb
JB
15462011-04-27 Juanma Barranquero <lekktu@gmail.com>
1547
1548 * makefile.w32-in: Update dependencies.
1549
94dcfacf
EZ
15502011-04-27 Eli Zaretskii <eliz@gnu.org>
1551
1552 Improve `doprnt' and its usage. (Bug#8545)
1553 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1554 `format_end'. Remove support for %l as a conversion specifier.
1555 Don't use xrealloc. Improve diagnostics when the %l size modifier
1556 is used. Update the commentary.
1557
1558 * eval.c (verror): Simplify calculation of size_t.
1559
1560 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1561 messages.
1562
f61f41d7
PE
15632011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1564
1565 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1566 change.
1567
96fb4434
PE
15682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1569
1570 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1571 This makes this file independent of the recent pseudovector change.
1572
671875da 15732011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1574
69e9b5a3
PE
1575 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1576
b5f869a7 1577 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1578 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1579 Remove unused local.
c8926152 1580 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1581
841a1577 1582 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1583 GCC 4.6.0 optimizes based on type-based alias analysis.
1584 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1585 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1586 != &v->size, and therefore "v->size = 1; b->size = 2; return
1587 v->size;" must therefore return 1. This assumption is incorrect
1588 for Emacs, since it type-puns struct Lisp_Vector * with many other
1589 types. To fix this problem, this patch adds a new type struct
f904488f 1590 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1591 and pseudovectors, and helps optimizing compilers not get fooled
1592 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1593 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1594 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1595 the size member.
eab3844f
PE
1596 (XSETPVECTYPE): Rewrite in terms of new macro.
1597 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1598 This is a bit clearer, and further avoids the possibility of
1599 undesirable aliasing.
1600 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1601 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1602 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1603 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1604 (ASIZE): Now uses header.size rather than size.
1605 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1606 to avoid the hassle of writing XVECTOR (foo)->header.size.
1607 (struct vectorlike_header): New type.
eab3844f
PE
1608 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1609 object, to help avoid aliasing.
1610 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1611 (SUBRP): Likewise, since Lisp_Subr is a special case.
1612 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1613 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1614 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1615 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1616 changed to be "header.size" and "header.next".
1617 * buffer.h (struct buffer): Likewise.
1618 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1619 * frame.h (struct frame): Likewise.
1620 * process.h (struct Lisp_Process): Likewise.
1621 * termhooks.h (struct terminal): Likewise.
1622 * window.c (struct save_window_data, struct saved_window): Likewise.
1623 * window.h (struct window): Likewise.
1624 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1625 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1626 * buffer.c (init_buffer_once): Likewise.
1627 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1628 special case.
1629 * process.c (Fformat_network_address): Use local var for size,
1630 for brevity.
1631
0df1eac5
PE
1632 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1633
847ab9d1 1634 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1635 * data.c (atof): Remove decl; no longer used or needed.
1636 (digit_to_number): Move to lread.c.
1637 (Fstring_to_number): Use new string_to_number function, to be
1638 consistent with how the Lisp reader treats infinities and NaNs.
1639 Do not assume that floating-point numbers represent EMACS_INT
1640 without losing information; this is not true on most 64-bit hosts.
1641 Avoid double-rounding errors, by insisting on integers when
1642 parsing non-base-10 numbers, as the documentation specifies.
1643 * lisp.h (string_to_number): New decl, replacing ...
1644 (isfloat_string): Remove.
bc0a5c13 1645 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1646 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1647 appears to have been a coding error. Similarly, do not accept
1648 strings like +-1e0 as floating point numbers. Do not report
1649 overflow for integer overflows unless the base is not 10 which
1650 means we have no simple and reliable way to continue.
1651 Break out the floating-point parsing into a new
1652 function string_to_number, so that Fstring_to_number parses
1653 floating point numbers consistently with the Lisp reader.
04f2d78b 1654 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1655 (E_CHAR, EXP_INT): Remove, replacing with ...
1656 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1657 (string_to_number): New function, replacing isfloat_string.
1658 This function checks for valid syntax and produces the resulting
1659 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1660 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1661 so that overflow for non-base-10 numbers is reported only when
1662 there's no portable and simple way to convert to floating point.
452f4150 1663
67769ffc
PE
1664 * textprop.c (set_text_properties_1): Rewrite for clarity,
1665 and to avoid GCC warning about integer overflow.
1666
c20db43f
PE
1667 * intervals.h (struct interval): Use EMACS_INT for members
1668 where EMACS_UINT might cause problems. See
1669 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1670 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1671 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1672 All uses changed.
37aa2f85
PE
1673 (offset_intervals): Tell GCC not to worry about length overflow
1674 when negating a negative length.
c20db43f 1675
2538aa2f
PE
1676 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1677 (overrun_check_free): Likewise.
1678
f2d3008d
PE
1679 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1680 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1681 word size.
1682
ec8df744
PE
1683 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1684 (gnutls_make_error): Rename local to avoid shadowing.
1685 (gnutls_emacs_global_deinit): ifdef out; not used.
1686 (Fgnutls_boot): Use const for pointer to readonly storage.
1687 Comment out unused local. Fix pointer signedness problems.
1688
640ee02d
PE
1689 * lread.c (openp): Don't stuff size_t into an 'int'.
1690 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1691 about possible signed overflow.
1692
6048fb2a
PE
1693 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1694 (GDK_KEY_g): Don't define if already defined.
1695 (xg_prepare_tooltip): Avoid pointer signedness problem.
1696 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1697
fa3c87e1
PE
1698 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1699 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1700
2172544b
PE
1701 * xfns.c (Fx_window_property): Simplify a bit,
1702 to make a bit faster and to avoid GCC 4.6.0 warning.
1703 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1704
9b821a21
PE
1705 * fns.c (internal_equal): Don't assume size_t fits in int.
1706
3c616cfa
PE
1707 * alloc.c (compact_small_strings): Tighten assertion a little.
1708
c2982e87
PE
1709 Replace pEd with more-general pI, and fix some printf arg casts.
1710 * lisp.h (pI): New macro, generalizing old pEd macro to other
1711 conversion specifiers. For example, use "...%"pI"d..." rather
1712 than "...%"pEd"...".
1713 (pEd): Remove. All uses replaced with similar uses of pI.
1714 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1715 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1716 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1717 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1718 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1719 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1720 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1721 64-bit hosts.
1722 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1723 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1724 * print.c (safe_debug_print, print_object): Likewise.
1725 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1726 to int.
6f04d126
PE
1727 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1728 avoiding the 0 flag, which is not portable.
c2982e87
PE
1729 * process.c (Fmake_network_process): Use pI to avoid cast.
1730 * region-cache.c (pp_cache): Likewise.
1731 * xdisp.c (decode_mode_spec): Likewise.
1732 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1733 behavior on 64-bit hosts with printf arg.
6f04d126 1734 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1735 (x_stop_queuing_selection_requests): Likewise.
1736 (x_get_window_property): Don't truncate byte count to an 'int'
1737 when tracing.
0b432f21 1738
5e073ec7
PE
1739 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1740 here, since it parses constructs like leading '-' and spaces,
1741 which are not wanted; and it overflows with large numbers.
1742 Instead, simply match F[0-9]+, which is what is wanted anyway.
1743
36372bf9
PE
1744 * alloc.c: Remove unportable assumptions about struct layout.
1745 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1746 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1747 (allocate_vectorlike, make_pure_vector): Use the new macros,
1748 plus offsetof, to remove unportable assumptions about struct layout.
1749 These assumptions hold on all porting targets that I know of, but
1750 they are not guaranteed, they're easy to remove, and removing them
1751 makes further changes easier.
1752
0b432f21
PE
1753 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1754 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1755 (string_overrun_cookie): Now const. Use initializers that
1756 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1757 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1758 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1759 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1760 multiple of sizeof (EMACS_INT); it need not be, if
1761 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1762 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1763
895009e1
JB
17642011-04-26 Juanma Barranquero <lekktu@gmail.com>
1765
1766 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1767
6a7a1b0b
TZ
17682011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1769
1770 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1771 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1772 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1773
841a1577 17742011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1775
1776 * lisp.h (Qdebug): List symbol.
895009e1 1777 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1778 * keyboard.c (debug-on-event): New variable.
1779 (handle_user_signal): Break into debugger when debug-on-event
1780 matches the current signal symbol.
1781
f2d3ba6f
DN
17822011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1783
1784 * alloc.c (check_sblock, check_string_bytes)
1785 (check_string_free_list): Convert to standard C.
1786
42ce4c63
TZ
17872011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1788
1789 * w32.c (emacs_gnutls_push): Fix typo.
1790
825cd63c
EZ
17912011-04-25 Eli Zaretskii <eliz@gnu.org>
1792
fb11d64d
EZ
1793 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1794 "cast to pointer from integer of different size".
1795
825cd63c
EZ
1796 Improve doprnt and its use in verror. (Bug#8545)
1797 * doprnt.c (doprnt): Document the set of format control sequences
1798 supported by the function. Use SAFE_ALLOCA instead of always
1799 using `alloca'.
1800
1801 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1802 is one byte too soon. Don't use xrealloc; instead xfree and
1803 xmalloc anew.
1804
e061a11b
TZ
18052011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1806
1807 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1808 callbacks stage.
1809
1810 * gnutls.c: Renamed global_initialized to
1811 gnutls_global_initialized. Added internals for the
1812 :verify-hostname-error, :verify-error, and :verify-flags
1813 parameters of `gnutls-boot' and documented those parameters in the
1814 docstring. Start callback support.
1815 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1816 unless a fatal error occured. Call gnutls_alert_send_appropriate
1817 on error. Return error code.
1818 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1819 (emacs_gnutls_read): Likewise.
1820 (Fgnutls_boot): Return handshake error code.
1821 (emacs_gnutls_handle_error): New function.
1822 (wsaerror_to_errno): Likewise.
1823
1824 * w32.h (emacs_gnutls_pull): Add prototype.
1825 (emacs_gnutls_push): Likewise.
1826
1827 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1828 (emacs_gnutls_push): Likewise.
1829
18302011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1831
1832 * process.c (wait_reading_process_output): Check if GnuTLS
1833 buffered some data internally if no FDs are set for TLS
1834 connections.
1835
1836 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1837 (LIBS): Link to USER_LIBS.
1838 ($(BLD)/gnutls.$(0)): New target.
1839
fa6996bc
EZ
18402011-04-24 Eli Zaretskii <eliz@gnu.org>
1841
eb35682e
EZ
1842 * xdisp.c (handle_single_display_spec): Rename the
1843 display_replaced_before_p argument into display_replaced_p, to
1844 make it consistent with the commentary. Fix typos in the
1845 commentary.
1846
e2ad650c
EZ
1847 * textprop.c (syms_of_textprop): Remove dead code.
1848 (copy_text_properties): Delete obsolete commentary about an
1849 interface that was deleted long ago. Fix typos in the description
1850 of arguments.
1851
1b2de274
EZ
1852 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1853 to changes in oldXMenu/XMenu.h from 2011-04-16.
1854 <menu_help_message, prev_menu_help_message>: Constify.
1855 (IT_menu_make_room): menu->help_text is now `const char **';
1856 adjust.
1857
1858 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1859 to changes in oldXMenu/XMenu.h from 2011-04-16.
1860 (struct XMenu): Declare `help_text' `const char **'.
1861
1862 * xfaces.c <Qunspecified>: Make extern again.
1863
1864 * syntax.c: Include sys/types.h before including regex.h, as
1865 required by Posix.
1866
762b15be
EZ
1867 * doc.c (get_doc_string): Improve the format passed to `error'.
1868
1869 * doprnt.c (doprnt): Improve commentary.
1870
1871 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1872
1873 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1874 them with etags.
1875
f1052e5d
EZ
1876 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1877 changes in globals.h immediately force recompilation.
762b15be
EZ
1878 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1879 $(CURDIR)/s/ms-w32.h.
1880 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1881
fa6996bc
EZ
1882 * character.c (Fchar_direction): Function deleted.
1883 (syms_of_character): Don't defsubr it.
1884 <char-direction-table>: Deleted.
1885
e6c3da20
EZ
18862011-04-23 Eli Zaretskii <eliz@gnu.org>
1887
1888 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1889 * doprnt.c: Include limits.h.
1890 (SIZE_MAX): New macro.
04f2d78b
CB
1891 (doprnt): Return a size_t value. 2nd arg is now size_t.
1892 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1893 Improve overflow protection. Support `l' modifier for integer
1894 conversions. Support %l conversion. Don't assume an EMACS_INT
1895 argument for integer conversions and for %c.
1896
1897 * lisp.h (doprnt): Restore prototype.
1898
1899 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1900 $(SRC)/character.h.
1901
1902 * Makefile.in (base_obj): Add back doprnt.o.
1903
1904 * deps.mk (doprnt.o): Add back prerequisites.
1905 (callint.o): Depend on character.h.
1906
1907 * eval.c (internal_lisp_condition_case): Include the handler
1908 representation in the error message.
1909 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1910 when breaking from the loop.
1911
1912 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1913
1914 * callint.c (Fcall_interactively): When displaying error message
1915 about invalid control letter, pass the character's codepoint, not
1916 a pointer to its multibyte form. Improve display of the character
1917 in octal and display also its hex code.
1918
1919 * character.c (char_string): Use %x to display the (unsigned)
1920 codepoint of an invalid character, to avoid displaying a bogus
1921 negative value.
1922
1923 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1924 `error', not SYMBOL_NAME itself.
1925
1926 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1927 character arguments to `error'.
1928
1929 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1930 to `error' in error message about FINAL_CHAR argument. Make sure
1931 FINAL_CHAR is a character, and use %c when it is passed as
1932 argument to `error'.
1933
4ffd0d6b 19342011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1935
1936 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1937
1938 * w32.c: Include <time.h>.
1939 (sys_localtime): New function.
1940
4ffd0d6b 19412011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1942
1943 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1944
4ffd0d6b 1945 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1946
4ffd0d6b 19472011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1948
4ffd0d6b
GM
1949 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1950 zombies (Bug#8467).
aac0c6e3 1951
04c56954
EZ
19522011-04-19 Eli Zaretskii <eliz@gnu.org>
1953
1954 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1955 gl_state.e_property when gl_state.object is Qt.
1956
1957 * insdel.c (make_gap_larger): Remove limitation of buffer size
1958 to <= INT_MAX.
1959
16a43933
CY
19602011-04-18 Chong Yidong <cyd@stupidchicken.com>
1961
1962 * xdisp.c (lookup_glyphless_char_display)
1963 (produce_glyphless_glyph): Handle cons cell entry in
1964 glyphless-char-display.
1965 (Vglyphless_char_display): Document it.
1966
1967 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1968 glyphless-char-display.
1969
4581706e
CY
19702011-04-17 Chong Yidong <cyd@stupidchicken.com>
1971
1972 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1973
1974 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1975
1976 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1977 definition for no-X builds.
1978
4887c6e2 19792011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1980
fd35b6f9
PE
1981 Static checks with GCC 4.6.0 and non-default toolkits.
1982
5c1ccb01
PE
1983 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1984
006c5daa
PE
1985 * process.c (keyboard_bit_set): Define only if SIGIO.
1986 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1987 (send_process): Repair possible setjmp clobbering.
1988
efc736d3
PE
1989 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1990
4e2fe2e6
PE
1991 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1992
f97334a2
PE
1993 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1994
4e75f29d
PE
1995 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1996 Define only if needed.
1997
90efadd1
PE
1998 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1999 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2000 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2001
3c647824
PE
2002 * dispextern.h (struct redisplay_interface): Rename param
2003 to avoid shadowing.
e264f262 2004 * termhooks.h (struct terminal): Likewise.
761383f4 2005 * xterm.c (xembed_send_message): Likewise.
3c647824 2006
b58c5c4a
PE
2007 * insdel.c (make_gap_smaller): Define only if
2008 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2009
cad59032
PE
2010 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2011 it.
2012
c339dc2e
PE
2013 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2014 so that we aren't warned about unused symbols.
2015
91a3e27b
PE
2016 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2017
399c71d3 2018 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2019
8ffc96f5
PE
2020 * xfns.c (x_real_positions): Mark locals as initialized.
2021
eef9bc79
PE
2022 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2023
098db9dd
PE
2024 * xterm.c: Fix problems found by static analysis with other toolkits.
2025 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2026 (x_dispatch_event): Declare static if USE_GTK, and
2027 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2028 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2029 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2030 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2031 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2032
eb18f6cc
PE
2033 * xmenu.c (menu_help_callback): Pointer type fixes.
2034 Use const pointers when pointing at readonly data. Avoid pointer
2035 signedness clashes.
2036 (FALSE): Remove unused macro.
2037 (update_frame_menubar): Remove unused decl.
2038
1fe72bf8
PE
2039 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2040
60d9e1db
PE
2041 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2042 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2043 (single_menu_item): Rename local to avoid shadowing.
2044
39261c26
PE
2045 * keyboard.c (make_lispy_event): Remove unused local var.
2046
018c5e19
PE
2047 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2048 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2049
63d2b86e
PE
2050 * bitmaps: Change bitmaps from unsigned char back to the X11
2051 compatible char. Avoid the old compiler warnings about
2052 out-of-range initializers by using, for example, '\xab' rather
2053 than 0xab.
2054
aefd87e1
PE
2055 * xgselect.c (xgselect_initialize): Check vs interface
2056 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2057
bf501fb9
PE
2058 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2059
e9829fdf
PE
2060 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2061 to read-only memory.
2062
1086c095
PE
2063 * fns.c (vector): Remove; this old hack is no longer needed.
2064
2baccd04 2065 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2066 Remove unused var.
dde42981 2067 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2068
72391843 2069 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2070
436c16df 2071 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2072 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2073 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2074
92bb796d 2075 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2076 (x_term_init): Remove local to avoid shadowing.
92bb796d 2077
764430a3 2078 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2079
2080 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2081 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2082
d1dfb56c
EZ
20832011-04-16 Eli Zaretskii <eliz@gnu.org>
2084
c4354cb4
EZ
2085 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2086
d1dfb56c
EZ
2087 Fix regex.c, syntax.c and friends for buffers > 2GB.
2088 * syntax.h (struct gl_state_s): Declare character position members
2089 EMACS_INT.
2090
2091 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2092
04f2d78b
CB
2093 * textprop.c (verify_interval_modification, interval_of):
2094 Declare arguments EMACS_INT.
d1dfb56c
EZ
2095
2096 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2097 EMACS_INT.
2098
2099 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2100
2101 * indent.c (Fvertical_motion): Local variable it_start is now
2102 EMACS_INT.
2103
2104 * regex.c (re_match, re_match_2, re_match_2_internal)
2105 (bcmp_translate, regcomp, regexec, print_double_string)
2106 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2107 (re_compile_pattern, re_exec): Declare arguments and local
2108 variables `size_t' and `ssize_t' and return values `regoff_t', as
2109 appropriate.
2110 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2111 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2112 <compile_stack_type>: `size' and `avail' are now `size_t'.
2113
2114 * regex.h <regoff_t>: Use ssize_t, not int.
2115 (re_search, re_search_2, re_match, re_match_2): Arguments that
2116 specify buffer/string position and length are now ssize_t and
2117 size_t. Return type is regoff_t.
2118
613052cd
BK
21192011-04-16 Ben Key <bkey76@gmail.com>
2120
2121 * nsfont.m: Fixed bugs in ns_get_family and
2122 ns_descriptor_to_entity that were caused by using free to
2123 deallocate memory blocks that were allocated by xmalloc (via
2124 xstrdup). This caused Emacs to crash when compiled with
2125 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2126 --enable-checking=xmallocoverrun). xfree is now used to
2127 deallocate these memory blocks.
2128
4170f62f 21292011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2130
71b41406
PE
2131 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2132
9587a89d
PE
2133 emacs_write: Accept and return EMACS_INT for sizes.
2134 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2135 et seq.
2136 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2137 Accept and return EMACS_INT.
2138 (emacs_gnutls_write): Return the number of bytes written on
2139 partial writes.
2140 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2141 (emacs_read, emacs_write): Remove check for negative size, as the
2142 Emacs source code has been audited now.
9587a89d
PE
2143 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2144 (emacs_read, emacs_write): Use it.
273a5f82
PE
2145 * process.c (send_process): Adjust to the new signatures of
2146 emacs_write and emacs_gnutls_write. Do not attempt to store
2147 a byte offset into an 'int'; it might overflow.
9587a89d 2148 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2149
3e047f51
PE
2150 * sound.c: Don't assume sizes fit in 'int'.
2151 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2152 Return EMACS_INT, not int.
3e047f51 2153 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2154 Accept EMACS_INT, not int.
2155 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2156 record read return values.
2157
cc39a9db
BK
21582011-04-15 Ben Key <bkey76@gmail.com>
2159
c9d0ec6d
JB
2160 * keyboard.c (Qundefined): Don't declare static since it is used
2161 in nsfns.m.
2162 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2163 static since they are used in nsfont.m.
cc39a9db 2164
6c60eb9f
SM
21652011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2166
2167 * process.c (Qprocessp): Don't declare static.
2168 * lisp.h (Qprocessp): Declare again.
2169
7990b61a
JB
21702011-04-15 Juanma Barranquero <lekktu@gmail.com>
2171
2172 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2173
5d4cb038
PE
21742011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2175
8bd7b830 2176 Improve C-level modularity by making more things 'static'.
cd64ea1d 2177
e3b27b31
PE
2178 Don't publish debugger-only interfaces to other modules.
2179 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2180 (verify_bytepos, count_markers): Move decls to the only modules
2181 that need them.
2182 * region-cache.h (pp_cache): Likewise.
2183 * window.h (check_all_windows): Likewise.
2184 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2185
5d4cb038
PE
2186 * sysdep.c (croak): Now static, if
2187 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2188 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2189
2190 * alloc.c (refill_memory_reserve): Now static if
2191 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2192 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2193
e87b6180
PE
2194 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2195 Define only if USE_LUCID.
2196
ac64929e
PE
2197 * xrdb.c (x_customization_string, x_rm_string): Now static.
2198
6f37259d
PE
2199 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2200 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2201
1683e3ab
PE
2202 * xdisp.c (draw_row_with_mouse_face): Now static.
2203 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2204
de9c2632
PE
2205 * window.h (check_all_windows): Mark externally visible.
2206
2b96acb7
PE
2207 * window.c (window_deletion_count): Now static.
2208
2209 * undo.c: Make symbols static if they're not exported.
2210 (last_undo_buffer, last_boundary_position, pending_boundary):
2211 Now static.
2212
50436f33
PE
2213 * textprop.c (interval_insert_behind_hooks): Now static.
2214 (interval_insert_in_front_hooks): Likewise.
2215
64520e5c
PE
2216 * term.c: Make symbols static if they're not exported.
2217 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2218 (max_frame_lines, tty_set_terminal_modes):
2219 (tty_reset_terminal_modes, tty_turn_off_highlight):
2220 (get_tty_terminal): Now static.
2221 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2222 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2223 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2224 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2225 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2226
1fa53021
PE
2227 * sysdep.c: Make symbols static if they're not exported.
2228 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2229 Now static.
2230 (sigprocmask_set, full_mask): Remove; unused.
2231 (wait_debugging): Mark as visible.
2232 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2233 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2234
d4b43b22
PE
2235 * syntax.c (syntax_temp): Define only if !__GNUC__.
2236
b7c513d0
PE
2237 * sound.c (current_sound_device, current_sound): Now static.
2238
989b29ad
PE
2239 * search.c (searchbufs, searchbuf_head): Now static.
2240
13a55a78
PE
2241 * scroll.c (scroll_cost): Remove; unused.
2242 * dispextern.h (scroll_cost): Remove decl.
2243
de68a1fc
PE
2244 * region-cache.h (pp_cache): Mark as externally visible.
2245
40ccffa6
PE
2246 * process.c: Make symbols static if they're not exported.
2247 (process_tick, update_tick, create_process, chan_process):
2248 (Vprocess_alist, proc_buffered_char, datagram_access):
2249 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2250 (deactivate_process): Mark defn as static, as well as decl.
2251 * lisp.h (create_process): Remove decl.
2252 * process.h (chan_process, Vprocess_alist): Remove decls.
2253
ad64fc97
PE
2254 * print.c: Make symbols static if they're not exported.
2255 (print_depth, new_backquote_output, being_printed, print_buffer):
2256 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2257 (print_interval, print_number_index, initial_stderr_stream):
2258 Now static.
2259 * lisp.h (Fprinc): Remove decl.
2260 (debug_output_compilation_hack): Mark as externally visible.
2261
adddb265
PE
2262 * sysdep.c (croak): Move decl from here to syssignal.h.
2263 * syssignal.h (croak): Put it here, so the API can be checked when
2264 'croak' is called from dissociate_if_controlling_tty.
2265
1717ede2
PE
2266 * minibuf.c: Make symbols static if they're not exported.
2267 (minibuf_save_list, choose_minibuf_frame): Now static.
2268 * lisp.h (choose_minibuf_frame): Remove decl.
2269
fa5fb2bc
PE
2270 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2271
1e3890d1
PE
2272 * lread.c: Make symbols static if they're not exported.
2273 (read_objects, initial_obarray, oblookup_last_bucket_number):
2274 Now static.
2275 (make_symbol): Remove; unused.
2276 * lisp.h (initial_obarray, make_symbol): Remove decls.
2277
8a1414fa
PE
2278 * keyboard.c: Make symbols static if they're not exported.
2279 (single_kboard, recent_keys_index, total_keys, recent_keys):
2280 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2281 (this_single_command_key_start, echoing, last_auto_save):
2282 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2283 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2284 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2285 (Vlispy_mouse_stem, double_click_count):
2286 Now static.
2287 (force_auto_save_soon): Define only if SIGDANGER.
2288 (ignore_mouse_drag_p): Now static if
2289 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2290 (print_help): Remove; unused.
2291 (stop_character, last_timer_event): Mark as externally visible.
2292 * keyboard.h (ignore_mouse_drag_p): Declare only if
2293 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2294 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2295 * lisp.h (echoing): Remove decl.
2296 (force_auto_save_soon): Declare only if SIGDANGER.
2297 * xdisp.c (redisplay_window): Simplify code, to make it more
2298 obvious that ignore_mouse_drag_p is not accessed if !defined
2299 USE_GTK && !defined HAVE_NS.
2300
93ea6e8f
PE
2301 * intervals.c: Make symbols static if they're not exported.
2302 (merge_properties_sticky, merge_interval_right, delete_interval):
2303 Now static.
2304 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2305
77382fcc
PE
2306 * insdel.c: Make symbols static if they're not exported.
2307 However, leave prepare_to_modify_buffer alone. It's never
2308 called from outside this function, but that appears to be a bug.
2309 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2310 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2311 (adjust_after_replace_noundo): Remove; unused.
2312 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2313 (signal_before_change): Remove decls.
77382fcc 2314
9306c32e
PE
2315 * indent.c (val_compute_motion, val_vmotion): Now static.
2316
cd44d2eb
PE
2317 * image.c: Make symbols static if they're not exported.
2318 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2319 if USE_GTK.
2320 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2321 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2322
ad9a7a06
PE
2323 * fringe.c (standard_bitmaps): Now static.
2324 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2325
81626931
PE
2326 * frame.c: Make symbols static if they're not exported.
2327 (x_report_frame_params, make_terminal_frame): Now static.
2328 (get_frame_param): Now static, unless HAVE_NS.
2329 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2330 (x_get_resource_string): Remove; not used.
2331 * frame.h (make_terminal_frame, x_report_frame_params):
2332 (x_get_resource_string); Remove decls.
2333 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2334 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2335
239f9db9
PE
2336 * font.c, fontset.c: Make symbols static if they're not exported.
2337 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2338 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2339 * font.c (font_close_object): Now static.
2340 * font.h (font_close_object): Remove.
2341 * fontset.c (FONTSET_OBJLIST): Remove.
2342 (free_realized_fontset) #if-0 the body, which does nothing.
2343 (face_suitable_for_char_p): #if-0, as it's never called.
2344 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2345 * xfaces.c (face_at_string_position):
2346 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2347 since 0 is always ASCII.
2348
dfcf3579
PE
2349 * fns.c (weak_hash_tables): Now static.
2350
5045092b
PE
2351 * fileio.c: Make symbols static if they're not exported.
2352 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2353 (Vwrite_region_annotation_buffers): Now static.
2354
57a96f5c
PE
2355 * eval.c: Make symbols static if they're not exported.
2356 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2357 * lisp.h (backtrace_list): Remove decl.
2358
35f08c38
PE
2359 * emacs.c: Make symbols static if they're not exported.
2360 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2361 (fatal_error_code, fatal_error_signal_hook, standard_args):
2362 Now static.
2363 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2364 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2365 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2366 * lisp.h (fatal_error_signal_hook): Remove decl.
2367 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2368
f44bd759
PE
2369 * editfns.c: Move a (normally-unused) function to its only use.
2370 * editfns.c, lisp.h (get_operating_system_release): Remove.
2371 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2372 worth the hassle of breaking this out.
2373
b532497d
PE
2374 * xterm.c: Make symbols static if they're not exported.
2375 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2376 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2377 (x_destroy_window, x_delete_display):
2378 Now static.
2379 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2380 (x_mouse_leave): Remove; unused.
2381 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2382 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2383 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2384 Remove decls.
2385 (x_mouse_leave): Declare only if WINDOWSNT.
2386 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2387 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2388 USE_X_TOOLKIT.
2389
1675728f
PE
2390 * ftxfont.c: Make symbols static if they're not exported.
2391 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2392 HAVE_FREETYPE.
2393 * font.h (ftxfont_driver): Likewise.
2394
e4cebfca
PE
2395 * xfns.c: Make symbols static if they're not exported.
2396 (x_last_font_name, x_display_info_for_name):
2397 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2398 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2399 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2400 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2401 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2402 (last_show_tip_args): Now static.
2403 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2404 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2405 (x_screen_planes): Remove; unused.
2406 * dispextern.h (x_screen_planes): Remove decl.
2407
5bf46f05
PE
2408 * dispnew.c: Make symbols static if they're not exported.
2409 * dispextern.h (redraw_garbaged_frames, scrolling):
2410 (increment_row_positions): Remove.
2411 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2412 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2413 Now static.
2414 (redraw_garbaged_frames): Remove; unused.
2415
435f4c28
PE
2416 * xfaces.c: Make symbols static if they're not exported.
2417 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2418 Remove decls.
2419 * xterm.h (defined_color): Remove decls.
2420 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2421 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2422 (menu_face_changed_default, defined_color, free_realized_face):
2423 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2424 (ascii_face_of_lisp_face): Remove; unused.
2425
8524aef3
PE
2426 * xdisp.c: Make symbols static if they're not exported.
2427 * dispextern.h (scratch_glyph_row, window_box_edges):
2428 (glyph_to_pixel_coords, set_cursor_from_row):
2429 (get_next_display_element, set_iterator_to_next):
2430 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2431 (show_mouse_face): Remove decls
2432 * frame.h (message_buf_print): Likewise.
2433 * lisp.h (pop_message, set_message, check_point_in_composition):
2434 Likewise.
2435 * xterm.h (set_vertical_scroll_bar): Likewise.
2436 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2437 (message_buf_print, scratch_glyph_row, displayed_buffer):
2438 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2439 (get_next_display_element, show_mouse_face, window_box_edges):
2440 (frame_to_window_pixel_xy, check_point_in_composition):
2441 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2442 (glyph_to_pixel_coords): Remove; unused.
2443
16390cd2
PE
2444 * dired.c (file_name_completion): Now static.
2445
2446 * dbusbind.c (xd_in_read_queued_messages): Now static.
2447
a25f4dfa
PE
2448 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2449 * data.c (circular_list_error): Remove.
2450
14a9c8df
PE
2451 * commands.h (last_point_position, last_point_position_buffer):
2452 (last_point_position_window): Remove decls.
2453 * keyboard.c: Make these variables static.
2454
04f2d78b
CB
2455 * coding.h (coding, code_convert_region, encode_coding_gap):
2456 Remove decls.
74ab6df5
PE
2457 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2458 (iso_code_class, detect_coding, code_convert_region): Now static.
2459 (encode_coding_gap): Remove; unused.
2460
38dfbee1
PE
2461 * chartab.c (chartab_chars, chartab_bits): Now static.
2462
a2cb4e63
PE
2463 * charset.h (charset_iso_8859_1): Remove decl.
2464 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2465 Now static.
2466
127198fd
PE
2467 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2468 * ccl.c (Vccl_program_table): Now static.
2469 (check_ccl_update): Remove; unused.
2470
d85b608f
PE
2471 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2472 * category.h: ... from here.
2473 * category.c (check_category_table, set_category_set): Now static.
2474
31cd66f3
PE
2475 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2476 * lisp.h: Remove these decls.
2477
c358e587
PE
2478 * buffer.c (buffer_count): Remove unused var.
2479
e78aecca
PE
2480 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2481 so that it's not optimized away.
2482 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2483 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2484 exported only to the debugger.
2485
e192d7d3 2486 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2487 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2488
92470028
PE
2489 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2490 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2491 was inaccessible from Lisp.
2492 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2493 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2494
244ed907
PE
2495 alloc.c: Import and export fewer symbols, and remove unused items.
2496 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2497 is defined.
2498 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2499 it's not optimized away by whole-program optimization.
2500 (message_enable_multibyte, free_misc): Remove.
2501 (catchlist, handlerlist, mark_backtrace):
2502 Declare only if BYTE_MARK_STACK.
2503 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2504 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2505 (message_enable_multibyte): Remove decl.
2506 (free_misc, interval_free_list, float_block, float_block_index):
2507 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2508 (cons_free_list, last_marked_index):
2509 Now static.
2510 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2511 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2512 (mark_backtrace): Define only if BYTE_MARK_STACK.
2513 * xdisp.c (message_enable_multibyte): Now static.
2514
61c2b50e 2515 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2516 This makes it easier for human readers (and static analyzers)
2517 to see whether these variables are used from other modules.
2518 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2519 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2520 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2521 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2522 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2523 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2524 * xmenu.c, xselect.c:
2525 Declare Q* vars static if they are not used in other modules.
2526 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2527 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2528 Remove decls of unexported vars.
2529 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2530
95c82688
PE
2531 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2532
16a97296
PE
2533 Make Emacs functions such as Fatom 'static' by default.
2534 This makes it easier for human readers (and static analyzers)
2535 to see whether these functions can be called from other modules.
2536 DEFUN now defines a static function. To make the function external
2537 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2538 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2539 (Finit_image_library):
16a97296
PE
2540 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2541 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2542 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2543 Remove decls, since these functions are now static.
2544 (Funintern, Fget_internal_run_time): New decls, since these functions
2545 were already external.
95c82688 2546
16a97296
PE
2547 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2548 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2549 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2550 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2551 * keyboard.c, keymap.c, lread.c:
2552 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2553 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2554 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2555 Mark functions with DEFUE instead of DEFUN,
2556 if they are used in other modules.
2557 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2558 decls for now-static functions.
2559 * buffer.h (Fdelete_overlay): Remove decl.
2560 * callproc.c (Fgetenv_internal): Mark as internal.
2561 * composite.c (Fremove_list_of_text_properties): Remove decl.
2562 (Fcomposition_get_gstring): New forward static decl.
2563 * composite.h (Fcomposite_get_gstring): Remove decl.
2564 * dired.c (Ffile_attributes): New forward static decl.
2565 * doc.c (Fdocumntation_property): New forward static decl.
2566 * eval.c (Ffetch_bytecode): New forward static decl.
2567 (Funintern): Remove extern decl; now in .h file where it belongs.
2568 * fileio.c (Fmake_symbolic_link): New forward static decl.
2569 * image.c (Finit_image_library): New forward static decl.
2570 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2571 * intervals.h (Fprevious_property_change):
2572 (Fremove_list_of_text_properties): Remove decls.
2573 * keyboard.c (Fthis_command_keys): Remove decl.
2574 (Fcommand_execute): New forward static decl.
2575 * keymap.c (Flookup_key): New forward static decl.
2576 (Fcopy_keymap): Now static.
2577 * keymap.h (Flookup_key): Remove decl.
2578 * process.c (Fget_process): New forward static decl.
2579 (Fprocess_datagram_address): Mark as internal.
2580 * syntax.c (Fsyntax_table_p): New forward static decl.
2581 (skip_chars): Remove duplicate decl.
2582 * textprop.c (Fprevious_property_change): New forward static decl.
2583 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2584 Now internal.
2585 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2586 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2587
785bbd42
PE
2588 * editfns.c (Fformat): Remove unreachable code.
2589
8b913b57
AS
25902011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2591
2592 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2593 change. (Bug#8496)
2594
a6744a35
EZ
25952011-04-13 Eli Zaretskii <eliz@gnu.org>
2596
2597 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2598 when at ZV. (Bug#8487)
2599
e7974947
AS
26002011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2601
baad03f0
AS
2602 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2603 (Bug#8437)
2604 * keyboard.c (parse_tool_bar_item): Likewise.
2605 * sound.c (sound_cleanup, alsa_close): Likewise.
2606 * termcap.c (tgetent): Likewise.
2607 * xfns.c (x_default_font_parameter): Likewise.
2608 * xsettings.c (read_and_apply_settings): Likewise.
2609
e7974947
AS
2610 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2611 (overrun_check_free): Protoize.
2612
28272684
PE
26132011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2614
2615 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2616 since callers should never pass a negative size.
2617 Change the signature to match that of plain 'read' and 'write'; see
2618 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2619 * lisp.h: Update prototypes of emacs_write and emacs_read.
2620
11997c76
EZ
26212011-04-11 Eli Zaretskii <eliz@gnu.org>
2622
2623 * xdisp.c (redisplay_window): Don't try to determine the character
2624 position of the scroll margin if the window start point w->startp
e896f03c 2625 is outside the buffer's accessible region. (Bug#8468)
11997c76 2626
8a2cbd72
EZ
26272011-04-10 Eli Zaretskii <eliz@gnu.org>
2628
2629 Fix write-region and its subroutines for buffers > 2GB.
2630 * fileio.c (a_write, e_write): Modify declaration of arguments and
2631 local variables to support buffers larger than 2GB.
2632 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2633
2634 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2635 argument, local variables, and return value.
2636
2637 * lisp.h: Update prototypes of emacs_write and emacs_read.
2638
2639 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2640
4073e537 26412011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2642
1ebfdcb6
PE
2643 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2644
b2ded58d
PE
2645 Fix more problems found by GCC 4.6.0's static checks.
2646
7d66342c
PE
2647 * xdisp.c (vmessage): Use a better test for character truncation.
2648
bbf47d44
PE
2649 * charset.c (load_charset_map): <, not <=, for optimization,
2650 and to avoid potential problems with integer overflow.
9248994d 2651 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2652 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2653 * editfns.c (Fformat): Likewise.
1e69125e 2654 * syntax.c (skip_chars): Likewise.
3befa583 2655
e3019616
PE
2656 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2657 This also lets GCC 4.6.0 generate slightly better loop code.
2658
becfa255
PE
2659 * callint.c (Fcall_interactively): <, not <=, for optimization.
2660 (Fcall_interactively): Count the number of arguments produced,
2661 not the number of arguments given. This is simpler and lets GCC
2662 4.6.0 generate slightly better code.
2663
dae0cd48
PE
2664 * ftfont.c: Distingish more carefully between FcChar8 and char.
2665 The previous code passed unsigned char * to a functions like
2666 strlen and xstrcasecmp that expect char *, which does not
2667 conform to the C standard.
2668 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2669 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2670 char * when the C standard requires it.
2671
76032d70
PE
2672 * keyboard.c (read_char): Remove unused var.
2673
eb3f1cc8
PE
2674 * eval.c: Port to Windows vsnprintf (Bug#8435).
2675 Include <limits.h>.
2676 (SIZE_MAX): Define if the headers do not.
2677 (verror): Do not give up if vsnprintf returns a negative count.
2678 Instead, grow the buffer. This ports to Windows vsnprintf, which
2679 does not conform to C99. Problem reported by Eli Zaretskii.
2680 Also, simplify the allocation scheme, by avoiding the need for
2681 calling realloc, and removing the ALLOCATED variable.
2682
70476b54
PE
2683 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2684
12020a9e
PE
2685 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2686 But keep the doprint source code for now, as we might revamp it
2687 and use it again (Bug#8435).
ea6c7ae6
PE
2688 * lisp.h (doprnt): Remove.
2689 * Makefile.in (base_obj): Remove doprnt.o.
2690 * deps.mk (doprnt.o): Remove.
2691
5fdb398c
PE
2692 error: Print 32- and 64-bit integers portably (Bug#8435).
2693 Without this change, on typical 64-bit hosts error ("...%d...", N)
2694 was used to print both 32- and 64-bit integers N, which relied on
2695 undefined behavior.
2696 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2697 New macro.
2698 * lisp.h (error, verror): Mark as printf-like functions.
2699 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2700 Report overflow in size calculations when allocating printf buffer.
2701 Do not truncate output string at its first null byte.
2702 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2703 Truncate the output at a character boundary, since vsnprintf does not
2704 do that.
2705 * charset.c (check_iso_charset_parameter): Convert internal
2706 character to string before calling 'error', since %c now has the
2707 printf meaning.
2708 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2709 overflow when computing char to be passed to 'error'. Do not
2710 pass Lisp_Object to 'error'; pass the integer instead.
2711 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2712 formatted with plain %d.
2713
b189fa66
PE
2714 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2715
bff87ef0
PE
2716 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2717
7e2cac20
PE
2718 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2719
ce4d90b5
PE
2720 * xterm.c (x_catch_errors): Remove duplicate declaration.
2721
266c9547
PE
2722 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2723
79c49ad2
PE
2724 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2725
368f4090
JM
27262011-04-10 Jim Meyering <meyering@redhat.com>
2727
2728 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2729 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2730 return ssize_t not "int", and use size_t as the buffer length.
2731 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2732 * gnutls.h: Update declarations.
2733 * process.c (read_process_output): Use ssize_t, to match.
2734 (send_process): Likewise.
2735
a32d4040
CY
27362011-04-09 Chong Yidong <cyd@stupidchicken.com>
2737
2738 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2739
8546720e 27402011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2741
04f2d78b
CB
2742 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2743 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2744
8546720e
GM
2745 * xterm.c (handle_one_xevent):
2746 * xmenu.c (create_and_show_popup_menu):
2747 * xselect.c (x_decline_selection_request)
2748 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2749
0a2f5c1a 27502011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2751
2752 Fix some uses of `int' instead of EMACS_INT.
2753 * search.c (string_match_1, fast_string_match)
2754 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2755 (scan_buffer, find_next_newline_no_quit)
2756 (find_before_next_newline, search_command, Freplace_match)
2757 (Fmatch_data): Make some `int' variables be EMACS_INT.
2758
2759 * xdisp.c (display_count_lines): 3rd argument and return value now
2760 EMACS_INT. All callers changed.
2761 (pint2hrstr): Last argument is now EMACS_INT.
2762
2763 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2764 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2765 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2766 (decode_coding_utf_16, decode_coding_emacs_mule)
2767 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2768 (decode_coding_ccl, decode_coding_charset)
2769 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2770 (decode_coding_iso_2022, decode_coding_emacs_mule)
2771 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2772 <char_offset, last_offset>: Declare EMACS_INT.
2773 (encode_coding_utf_8, encode_coding_utf_16)
2774 (encode_coding_emacs_mule, encode_invocation_designation)
2775 (encode_designation_at_bol, encode_coding_iso_2022)
2776 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2777 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2778 Declare EMACS_INT.
2779 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2780 (encode_invocation_designation): Last argument P_NCHARS is now
2781 EMACS_INT.
2782 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2783 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2784
2785 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2786 All users changed.
2787
2788 * ccl.c (Fccl_execute_on_string): Declare some variables
2789 EMACS_INT.
2790
8546720e 27912011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2792
2793 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2794
4e19a977
CS
27952011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2796
2797 * process.c (Fformat_network_address): Doc fix.
2798
87302331
R
27992011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2800
2801 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2802
cbb59342
CY
28032011-04-08 Chong Yidong <cyd@stupidchicken.com>
2804
2805 * keyboard.c (read_char): Call Lisp function help-form-show,
2806 instead of using internal_with_output_to_temp_buffer.
2807 (Qhelp_form_show): New var.
e0d38eeb 2808 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2809
2810 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2811
2812 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2813
e67a13ab
CY
28142011-04-06 Chong Yidong <cyd@stupidchicken.com>
2815
04f2d78b
CB
2816 * process.c (Flist_processes): Remove to Lisp.
2817 (list_processes_1): Delete.
e67a13ab 2818
973f782d
EZ
28192011-04-06 Eli Zaretskii <eliz@gnu.org>
2820
7c106b1e
EZ
2821 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2822
973f782d
EZ
2823 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2824
41cf7d1a 28252011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2826
ca23cc88
PE
2827 Fix more problems found by GCC 4.6.0's static checks.
2828
f390e2d5
PE
2829 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2830
42eea0d0
PE
2831 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2832
b69769da 2833 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2834
f9541e84
PE
2835 * xdisp.c (vmessage): Mark as a printf-like function.
2836
13841b55
PE
2837 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2838
c136c10f
PE
2839 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2840
5e2d4a30
PE
2841 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2842 printf-like functions.
2843 (tiff_load): Add casts to remove these marks before passing them
2844 to system-supplied API.
2845
583f48b9
PE
2846 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2847
b25d760e
PE
2848 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2849 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2850 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2851 directly, rather than having caller test rule sign. This avoids
2852 some unnecessary tests.
2853 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2854 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2855 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2856
bc7b6697 2857 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2858 (xfont_open): Avoid unnecessary tests.
bc7b6697 2859
27ccc379
PE
2860 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2861
dcd5c89a
PE
2862 * composite.h, composite.c (composition_gstring_put_cache):
2863 Use EMACS_INT, not int, for length.
2864
b13a45c6
PE
2865 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2866 breaking out part of COMPOSITION_DECODE_RULE.
2867 (COMPOSITION_DECODE_RULE): Use it.
2868 * composite.c (get_composition_id): Remove unused local vars,
2869 by using the new macro.
2870
1e792e4d
PE
2871 * textprop.c (set_text_properties_1): Change while to do-while,
2872 since the condition is always true at first.
2873
dc6c6455 2874 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2875 (interval_deletion_adjustment): Return unsigned value.
2876 All uses changed.
dc6c6455 2877
aba7731a
PE
2878 * process.c (list_processes_1, create_pty, read_process_output):
2879 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2880 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2881 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2882 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2883 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2884
fdfc4bf3
PE
2885 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2886
fca8fe46 2887 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2888 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2889
06a0259a 2890 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2891 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2892 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2893
e7b9e80f
PE
2894 * print.c (print_error_message): Avoid int overflow.
2895
56201685
PE
2896 * font.c (font_list_entities): Redo for clarity,
2897 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2898
78834453 2899 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2900 (font_score): Avoid potential overflow in diff calculation.
78834453 2901
0bc0b309 2902 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2903 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2904
e610eaca
PE
2905 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2906
b895abce
PE
2907 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2908 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2909 can always succeed if overflow has undefined behavior.
2910
1f1d9321 2911 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2912 (wordify): Omit three unnecessary tests.
1f1d9321 2913
c59478bc
PE
2914 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2915 All callers changed. This avoids the need for an unused var.
2916
79b73827
PE
2917 * casefiddle.c (casify_region): Remove var that is set but not used.
2918
a4db5dfe
PE
2919 * dired.c (file_name_completion): Remove var that is set but not used.
2920
43aae36e
PE
2921 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2922
2a47c44d 2923 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2924 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2925
a37c69bf
PE
2926 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2927 Check for integer overflow on size calculations.
2928
328ab8e7
PE
2929 * buffer.c (Fprevious_overlay_change): Remove var that is set
2930 but not used.
2931
e5a2a5cb
PE
2932 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2933 Remove vars that are set but not used.
8d84a6eb 2934 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2935 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2936
a60e5f68
PE
2937 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2938
f661cb61 2939 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2940 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2941
f0397f5a
PE
2942 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2943 that are set but not used.
2944
8664db06 2945 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2946 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2947
6abdaa4a
PE
2948 * xselect.c (x_get_local_selection, x_handle_property_notify):
2949 Remove vars that are set but not used.
2950
0ce7538d 2951 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2952 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2953
9ae848fc
PE
2954 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2955 Remove var that is set but not used.
0b918413
PE
2956 (scroll_bar_windows_size): Now size_t, not int.
2957 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2958 Check for overflow.
9ae848fc 2959
a5a62657
PE
2960 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2961 (map_tty_color) [!defined MSDOS]: Likewise.
2962
5c5cdd39
PE
2963 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2964
66ebf983
PE
2965 * coding.c: Remove vars that are set but not used.
2966 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2967 All callers changed.
2968 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2969 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2970 (decode_coding_charset): Remove vars that are set but not used.
2971
1be4d761
PE
2972 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2973 that is set but not used.
2974
47553fa8
PE
2975 * print.c (print_object): Remove var that is set but not used.
2976
1f7196bf 2977 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2978 The gnulib version avoids calling malloc in the usual case,
2979 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2980 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2981 * filelock.c (current_lock_owner): Likewise.
2982 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2983 * sysdep.c: Include allocator.h, careadlinkat.h.
2984 (emacs_no_realloc_allocator): New static constant.
2985 (emacs_readlink): New function.
fdb61804
PE
2986 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2987 ../lib/careadlinkat.h.
d1fdcab7 2988
f84c17c7
SM
29892011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2990
2991 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2992 first non-nil return value).
2993
ef3862ad
JD
29942011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2995
2996 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2997 if not defined (Bug#8403).
2998
376a7006
JB
29992011-04-02 Juanma Barranquero <lekktu@gmail.com>
3000
3001 * xdisp.c (display_count_lines): Remove parameter `start',
3002 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3003 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3004 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3005 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3006 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3007 and thereabouts. All callers changed.
3008 (get_per_char_metric): Remove parameter `f', unused since
3009 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3010
6ca3801d
JM
30112011-04-02 Jim Meyering <meyering@redhat.com>
3012
3013 do not dereference NULL upon failed strdup
3014 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3015 (ns_get_family): Likewise.
3016
d8e2b5ba
JB
30172011-04-02 Juanma Barranquero <lekktu@gmail.com>
3018
3019 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3020
8c74fcbd
JD
30212011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3022
3023 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3024 later (Bug#8403).
3025
7200d79c
SM
30262011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3027
03408648 3028 Add lexical binding.
7200d79c 3029
03408648
SM
3030 * window.c (Ftemp_output_buffer_show): New fun.
3031 (Fsave_window_excursion):
3032 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3033
3034 * lread.c (lisp_file_lexically_bound_p): New function.
3035 (Fload): Bind Qlexical_binding.
3036 (readevalloop): Remove `evalfun' arg.
3037 Bind Qinternal_interpreter_environment.
3038 (Feval_buffer): Bind Qlexical_binding.
3039 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3040 Mark as dynamic.
3041 (syms_of_lread): Declare `lexical-binding'.
3042
3043 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3044
3045 * keyboard.c (eval_dyn): New fun.
3046 (menu_item_eval_property): Use it.
ca105506
SM
3047
3048 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3049
03408648
SM
3050 * fns.c (concat, mapcar1): Accept byte-code-functions.
3051
3052 * eval.c (Fsetq): Handle lexical vars.
3053 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3054 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3055 (FletX, Flet): Obey lexical binding.
3056 (Fcommandp): Handle closures.
3057 (Feval): New `lexical' arg.
3058 (eval_sub): New function extracted from Feval. Use it almost
3059 everywhere where Feval was used. Look up vars in lexical env.
3060 Handle closures.
3061 (Ffunctionp): Move from subr.el.
3062 (Ffuncall): Handle closures.
3063 (apply_lambda): Remove `eval_flags'.
3064 (funcall_lambda): Handle closures and new byte-code-functions.
3065 (Fspecial_variable_p): New function.
3066 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3067 but without exporting it to Lisp.
23aba0ea 3068
23aba0ea 3069 * doc.c (Fdocumentation, store_function_docstring):
03408648 3070 * data.c (Finteractive_form): Handle closures.
23aba0ea 3071
03408648
SM
3072 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3073 interactive spec.
ba83908c 3074
04f2d78b
CB
3075 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3076 New byte-codes.
03408648
SM
3077 (exec_byte_code): New function extracted from Fbyte_code to handle new
3078 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3079
03408648 3080 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3081
03408648 3082 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3083
e2abce01
JB
30842011-03-31 Juanma Barranquero <lekktu@gmail.com>
3085
3086 * xdisp.c (redisplay_internal): Fix prototype.
3087
63696a73 30882011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3089
63696a73 3090 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3091 (try_scrolling): Use it when setting scroll_limit.
3092 Limit scrolling to 100 screen lines.
63696a73
EZ
3093 (redisplay_window): Even when falling back on "recentering",
3094 position point in the window according to scroll-conservatively,
3095 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3096
3097 (try_scrolling): When point is above the window, allow searching
3098 as far as scroll_max, or one screenful, to compute vertical
3099 distance from PT to the scroll margin position. This prevents
3100 try_scrolling from unnecessarily failing when
3101 scroll-conservatively is set to a value slightly larger than the
3102 window height. Clean up the case of PT below the margin at bottom
3103 of window: scroll_max can no longer be INT_MAX. When aggressive
3104 scrolling is in use, don't let point enter the opposite scroll
3105 margin as result of the scroll.
3106 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3107 threshold of 100 lines for never-recentering scrolling.
3108
e4cc2dfc
JB
31092011-03-31 Juanma Barranquero <lekktu@gmail.com>
3110
3111 * dispextern.h (move_it_by_lines):
3112 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3113 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3114 (message_log_check_duplicate): Remove parameters `prev_bol' and
3115 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3116 (redisplay_internal): Remove parameter `preserve_echo_area',
3117 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3118
3119 * indent.c (Fvertical_motion):
3120 * window.c (window_scroll_pixel_based, Frecenter):
3121 Don't pass `need_y_p' to `move_it_by_lines'.
3122
1c470562
SM
31232011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3124
44f230aa
SM
3125 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3126 steal a few bits to be more compact.
3127 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3128 Remove unneeded casts.
3129
1c470562
SM
3130 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3131
888adce9
ZK
31322011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3133
3134 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3135 binding" message (bug#7967).
3136
f838ed7b
PE
31372011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3138
77861b95
PE
3139 Fix more problems found by GCC 4.6.0's static checks.
3140
de6dbc14
PE
3141 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3142 Remove unused local var.
3143
f838ed7b
PE
3144 * editfns.c (Fmessage_box): Remove unused local var.
3145
792c7b2b
PE
3146 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3147 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3148 Omit unused local vars.
c499e557 3149 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3150 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3151 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3152 Omit unused local var.
3153
ba0165e1
PE
3154 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3155 Don't assume string length fits in int.
32ad8845 3156 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3157 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3158
3c59b4c9
PE
3159 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3160 instead of alloca (Bug#8344).
3161
a3eed478 3162 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3163 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3164
eb4d412d
PE
3165 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3166
1658b401
PE
3167 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3168 concerns.
3169
3170 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3171
3172 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3173
9a2c6e05
PE
3174 * keyboard.c (syms_of_keyboard): Use the same style as later
3175 in this function when indexing through an array. This also
3176 works around GCC bug 48267.
3177
03d0a109
PE
3178 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3179
44f730c8
PE
3180 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3181
fe75f926
PE
3182 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3183 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3184
ffa8c828
PE
3185 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3186 This avoids undefined behavior on integer overflow, and is a bit
3187 more convenient anyway since it is compared to a size_t variable.
3188
c5101a77
PE
3189 Variadic C functions now count arguments with size_t, not int.
3190 This avoids an unnecessary limitation on 64-bit machines, which
3191 caused (substring ...) to crash on large vectors (Bug#8344).
3192 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3193 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3194 All variadic functions and their callers changed accordingly.
c5101a77
PE
3195 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3196 * data.c (arith_driver, float_arith_driver): Likewise.
3197 * editfns.c (general_insert_function): Likewise.
3198 * eval.c (struct backtrace.nargs, interactive_p)
3199 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3200 (funcall_lambda, mark_backtrace): Likewise.
3201 * fns.c (concat): Likewise.
3202 * frame.c (x_set_frame_parameters): Likewise.
3203 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3204 0 if not found, not -1. All callers changed.
3205
dd3f25f7
PE
3206 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3207 (stack_copy_size): Now size_t, not int.
3208 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3209
461c2ab9
JB
32102011-03-28 Juanma Barranquero <lekktu@gmail.com>
3211
3212 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3213 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3214 All callers changed.
3215
3216 * lisp.h (multibyte_char_to_unibyte):
3217 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3218 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3219 * character.h (CHAR_TO_BYTE8):
3220 * cmds.c (internal_self_insert):
3221 * editfns.c (general_insert_function):
3222 * keymap.c (push_key_description):
3223 * search.c (Freplace_match):
3224 * xdisp.c (message_dolog, set_message_1): All callers changed.
3225
f6d62986
SM
32262011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3227
3228 * keyboard.c (safe_run_hook_funcall): New function.
3229 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3230 don't set the hook to nil, but remove the offending function instead.
3231 (Qcommand_hook_internal): Remove, unused.
3232 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3233 Vcommand_hook_internal.
3234
3235 * eval.c (enum run_hooks_condition): Remove.
3236 (funcall_nil, funcall_not): New functions.
3237 (run_hook_with_args): Call each function through a `funcall' argument.
3238 Remove `cond' argument, now redundant.
3239 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3240 (Frun_hook_with_args_until_failure): Adjust accordingly.
3241 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3242
1db5b1ad
JB
32432011-03-28 Juanma Barranquero <lekktu@gmail.com>
3244
3245 * dispextern.h (string_buffer_position): Remove declaration.
3246
3247 * print.c (strout): Remove parameter `multibyte', unused since
3248 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3249
3250 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3251 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3252 All callers changed.
3253
3254 * w32.c (_wsa_errlist): Use braces for struct initializers.
3255
3256 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3257 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3258 All callers changed.
3259 (string_buffer_position): Likewise. Also, make static (it's never
3260 used outside xdisp.c).
3261 (cursor_row_p): Remove parameter `w', unused since
3262 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3263 (decode_mode_spec): Remove parameter `precision', introduced during
3264 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3265 All callers changed.
3266
5ffb62aa
JD
32672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3268
3269 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3270
461c2ab9 32712011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3272
3273 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3274 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3275 (ns_update_auto_hide_menu_bar): New functions.
3276 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3277 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3278 ns_constrain_all_frames.
3279 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3280 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3281
5c380ffb
JD
32822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3283
3284 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3285
9af30bdf
GM
32862011-03-27 Glenn Morris <rgm@gnu.org>
3287
3288 * syssignal.h: Replace RETSIGTYPE with void.
3289 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3290 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3291 Replace SIGTYPE with void everywhere.
3292 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3293 * s/template.h (SIGTYPE): Remove commented out definition.
3294
e2abce01
JB
32952011-03-26 Eli Zaretskii <eliz@gnu.org>
3296
3297 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3298 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3299
f868cd8a
JB
33002011-03-26 Juanma Barranquero <lekktu@gmail.com>
3301
59eb0929
JB
3302 * w32.c (read_unc_volume): Use parameter `henum', instead of
3303 global variable `wget_enum_handle'.
3304
3305 * keymap.c (describe_vector): Remove parameters `indices' and
3306 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3307 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3308
f868cd8a
JB
3309 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3310
3311 * keyboard.c (timer_check): Remove parameter `do_it_now',
3312 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3313 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3314 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3315
3316 * keyboard.c (read_char):
3317 * w32menu.c (w32_menu_display_help):
3318 * xmenu.c (show_help_event, menu_help_callback):
3319 Adjust calls to `show_help_echo'.
3320
3321 * gtkutil.c (xg_maybe_add_timer):
3322 * keyboard.c (readable_events):
3323 * process.c (wait_reading_process_output):
3324 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3325
3326 * insdel.c (adjust_markers_gap_motion):
3327 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3328 (gap_left, gap_right): Don't call it.
3329
2ecf6fdb
CY
33302011-03-25 Chong Yidong <cyd@stupidchicken.com>
3331
3332 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3333 incurred during fontification.
3334
6b1f9ba4
JB
33352011-03-25 Juanma Barranquero <lekktu@gmail.com>
3336
3337 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3338 (DEFVAR_PER_BUFFER): Don't pass it.
3339
3340 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3341 (scrolling_window): Don't pass it.
3342
0f4a96b5
JB
33432011-03-25 Juanma Barranquero <lekktu@gmail.com>
3344
3345 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3346
3347 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3348 and `suffix'.
3349 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3350 of variables specific to SELinux and computation of `encoded_absname'.
3351
3352 * image.c (XPutPixel): Remove unused variable `height'.
3353
3354 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3355
3356 * unexw32.c (get_section_info): Remove unused variable `section'.
3357
3358 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3359 (system_process_attributes): Remove unused variable `sess'.
3360 (sys_read): Remove unused variable `err'.
3361
3362 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3363 (w32_wnd_proc): Remove unused variable `isdead'.
3364 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3365 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3366 (x_create_tip_frame): Remove unused variable `tem'.
3367
3368 * w32inevt.c (w32_console_read_socket):
3369 Remove unused variable `no_events'.
3370
3371 * w32term.c (x_draw_composite_glyph_string_foreground):
3372 Remove unused variable `width'.
3373
1149507c
JB
33742011-03-24 Juanma Barranquero <lekktu@gmail.com>
3375
3376 * w32term.c (x_set_glyph_string_clipping):
3377 Don't pass uninitialized region to CombineRgn.
3378
9c88f339
JB
33792011-03-23 Juanma Barranquero <lekktu@gmail.com>
3380
3381 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3382 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3383 (Fx_close_connection): Remove unused variable `i'.
3384
3385 * w32font.c (w32font_draw): Return number of glyphs.
3386 (w32font_open_internal): Remove unused variable `i'.
3387 (w32font_driver): Add missing initializer.
3388
3389 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3390 (fill_in_menu): Remove unused variable `items_added'.
3391
3392 * w32term.c (last_mouse_press_frame): Remove static global variable.
3393 (w32_clip_to_row): Remove unused variable `f'.
3394 (x_delete_terminal): Remove unused variable `i'.
3395
3396 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3397 (NOTHING): Remove unused static global variable.
3398 (uniscribe_check_otf): Remove unused variable `table'.
3399 (uniscribe_font_driver): Add missing initializers.
3400
dee091a3
JD
34012011-03-23 Julien Danjou <julien@danjou.info>
3402
3403 * term.c (Fsuspend_tty, Fresume_tty):
3404 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3405 * window.c (temp_output_buffer_show):
3406 * insdel.c (signal_before_change):
3407 * frame.c (Fhandle_switch_frame):
3408 * fileio.c (Fdo_auto_save):
3409 * emacs.c (Fkill_emacs):
3410 * editfns.c (save_excursion_restore):
3411 * cmds.c (internal_self_insert):
3412 * callint.c (Fcall_interactively):
3413 * buffer.c (Fkill_all_local_variables):
3414 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3415 Use Frun_hooks.
0f4a96b5 3416 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3417 unconditionnaly since it does the check itself.
3418
2c520ab5 34192011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3420
c9c49752
PE
3421 Fix more problems found by GCC 4.5.2's static checks.
3422
8abc3f12
PE
3423 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3424 the first time through the loop, since we know p0 < p1 then.
3425 This also avoids a gcc -Wstrict-overflow warning.
3426
a2d26660
PE
3427 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3428 leading to a memory leak, possible in functions like
3429 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3430 of objects (Bug#8318).
a2d26660 3431
916c72e9
PE
3432 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3433 that could (at least in theory) be that large.
3434
19ab8a18
PE
3435 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3436 This is less likely to overflow, and avoids undefined behavior if
3437 overflow does occur. All callers changed. Use strtoul to scan
3438 for the unsigned long integer.
b7cbbd6f
PE
3439 (pint2hrstr): Simplify and tune code slightly.
3440 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3441
f0641eff
PE
3442 * scroll.c (do_scrolling): Work around GCC bug 48228.
3443 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3444
7f650bb9
PE
3445 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3446 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3447 (validate_x_resource_name): Simplify count usage.
3448 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3449
37dd57d1
PE
3450 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3451 fail (Bug#8306).
81e56e61 3452
699979fc 3453 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3454
401bf9b4
PE
3455 * process.c (Fmake_network_process): Use socklen_t, not int,
3456 where POSIX says socklen_t is required in portable programs.
3457 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3458 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3459 (Fmake_network_process, server_accept_connection):
3460 (wait_reading_process_output, read_process_output):
3461 Likewise.
3462
b93aacde
PE
3463 * process.c: Rename or move locals to avoid shadowing.
3464 (list_processes_1, Fmake_network_process):
3465 (read_process_output_error_handler, exec_sentinel_error_handler):
3466 Rename or move locals.
4dc343ee 3467 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3468 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3469 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3470 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3471 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3472
af8a867c 3473 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3474 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3475 Include tparam.h instead, since it declares them.
af8a867c
PE
3476 * cm.h (PC): Remove extern decl; tparam.h now does this.
3477 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3478 * terminfo.c: Include tparam.h, to check interfaces.
3479 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3480 (tparam): Adjust signature to match interface in tparam.h;
3481 this removes some undefined behavior. Check that outstring and len
3482 are zero, which they always are with Emacs.
3483 * tparam.h (PC, BC, UP): New extern decls.
3484
0248044d 3485 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3486 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3487
8ff096c1 3488 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3489 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3490 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3491 (ftfont_list): Remove unused local.
49eaafba
PE
3492 (get_adstyle_property, ftfont_pattern_entity):
3493 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3494 Rename locals to avoid shadowing.
8ff096c1 3495
e2be39f6
PE
3496 * xfont.c (xfont_list_family): Mark var as initialized.
3497
c9735e30
PE
3498 * xml.c (make_dom): Now static.
3499
8f5201ae
PE
3500 * composite.c (composition_compute_stop_pos): Rename local to
3501 avoid shadowing.
b246f932
PE
3502 (composition_reseat_it): Remove unused locals.
3503 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3504 (composition_update_it): Mark var as initialized.
11b61122
PE
3505 (find_automatic_composition): Mark vars as initialized,
3506 with a FIXME (Bug#8290).
8f5201ae 3507
760fbc2c
PE
3508 character.h: Rename locals to avoid shadowing.
3509 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3510 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3511 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3512 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3513 to avoid shadowing.
3514
ff08eb85
PE
3515 * textprop.c (property_change_between_p): Remove; unused.
3516
fc7bf025
PE
3517 * intervals.c (interval_start_pos): Now static.
3518
235d7abc
PE
3519 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3520
44f230aa
SM
3521 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3522 Rename locals to avoid shadowing.
3e7d6594 3523
50060332
PE
3524 * sound.c (wav_play, au_play, Fplay_sound_internal):
3525 Fix pointer signedness.
d01f234b 3526 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3527 (wav_play): Initialize a variable to 0, to prevent undefined
3528 behavior (Bug#8278).
50060332 3529
c4fc4e30
PE
3530 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3531
918436ed
PE
3532 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3533
c939f91b
PE
3534 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3535 clobbering (Bug#8298).
b9c7f648
PE
3536 * sysdep.c (sys_subshell): Likewise.
3537 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3538
6bd8c144
PE
3539 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3540 This should get cleaned up, so that child_setup has the
3541 same signature on all platforms.
3542
7710357c 3543 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3544 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3545
c59da222
CY
35462011-03-22 Chong Yidong <cyd@stupidchicken.com>
3547
3548 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3549 not to be necessary, and produces flickering.
3550
66b87493
GM
35512011-03-20 Glenn Morris <rgm@gnu.org>
3552
3553 * config.in: Remove file.
3554
45b6f6d5
JB
35552011-03-20 Juanma Barranquero <lekktu@gmail.com>
3556
3557 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3558 are now in src/globals.h.
3559 (syms_of_minibuf): Remove spurious & from previous change.
3560
3ec03f7e
LL
35612011-03-20 Leo <sdl.web@gmail.com>
3562
3563 * minibuf.c (completing-read-function): New variable.
3564 (completing-read-default): Rename from completing-read.
3565 (completing-read): Call completing-read-function.
3566
b14e3e21
CY
35672011-03-19 Juanma Barranquero <lekktu@gmail.com>
3568
3569 * xfaces.c (Fx_load_color_file):
3570 Read color file from absolute filename (bug#8250).
3571
f2b726e6
JB
35722011-03-19 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * makefile.w32-in: Update dependencies.
3575
09f6ff02
EZ
35762011-03-17 Eli Zaretskii <eliz@gnu.org>
3577
3578 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3579
29a6015a
PE
35802011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3581
a3a6c54e
PE
3582 Fix more problems found by GCC 4.5.2's static checks.
3583
b766f867
PE
3584 * process.c (make_serial_process_unwind, send_process_trap):
3585 (sigchld_handler): Now static.
3586
be02381c
PE
3587 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3588 That way, the code declares only the vars that it needs.
3589 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3590 * s/cygwin.h (PTY_ITERATION): Likewise.
3591 * s/darwin.h (PTY_ITERATION): Likewise.
3592 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3593
57048744
PE
3594 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3595 * process.c (allocate_pty): Don't declare stb unless it's needed.
3596
7914961c 3597 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3598 (CONSTANTLIM): Remove; unused.
3599 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3600 Define only if needed.
7914961c 3601
b3967b18
PE
3602 * unexelf.c (unexec): Name an expression,
3603 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3604 Use a different way to cause a compilation error if anyone uses
3605 n rather than nn, a way that does not involve shadowing.
73366a00 3606 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3607
29a6015a
PE
3608 * deps.mk (unexalpha.o): Remove; unused.
3609
43cfc33e 3610 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3611 * unexec.h: New file.
ce701a33
PE
3612 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3613 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3614 Depend on unexec.h.
3615 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3616 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3617 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3618 Change as necessary to match prototype in unexec.h.
ce701a33 3619
01f44d5a
PE
3620 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3621 shadowing.
4f63c6bb 3622 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3623
a6670b0b
PE
3624 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3625 Rename locals to avoid shadowing.
3626
cef2010d 3627 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3628 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3629
d4d7173a
PE
3630 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3631
f08b802a
PE
3632 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3633 warning when compiling print.c.
3634
3ddb0639
PE
3635 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3636 instead of using an uninitialized var.
5ad03b97 3637 (font_sort_entities): Mark var as initialized.
3ddb0639 3638
170a2692
PE
3639 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3640
e663c700
PE
3641 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3642 pointers to constants.
89bc529a 3643 (font_parse_fcname): Remove unused vars.
7b81e2d0 3644 (font_delete_unmatched): Now static.
ea838e10 3645 (font_get_spec): Remove; unused.
13a547c6
PE
3646 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3647 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3648 Rename or move locals to avoid shadowing.
e663c700 3649
2a80c887 3650 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3651 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3652
1384fa33 3653 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3654 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3655
8b2c52e9
PE
3656 * alloc.c (mark_backtrace): Move decl from here ...
3657 * lisp.h: ... to here, so that it can be checked.
3658
475545b5 3659 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3660 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3661 (lisp_indirect_variable): Name an expression,
3662 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3663 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3664
b1349114 3665 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3666 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3667 Use const pointer when appropriate.
b1349114 3668
a2928364
PE
3669 * lisp.h (get_system_name, get_operating_system_release):
3670 Move decls here, to check interfaces.
3671 * process.c (get_operating_system_release): Move decl to lisp.h.
3672 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3673 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3674 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3675 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3676 (Fformat_time_string, Fencode_time, Finsert_char):
3677 (Ftranslate_region_internal, Fformat):
3678 Rename or remove local vars to avoid shadowing.
9710023e 3679 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3680
a415e694
PE
3681 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3682 avoid shadowing.
3683
8ef4622d
PE
3684 * lisp.h (eassert): Check that the argument compiles, even if
3685 ENABLE_CHECKING is not defined.
3686
946f9a5b
PE
3687 * data.c (Findirect_variable): Name an expression, to avoid
3688 gcc -Wbad-function-cast warning.
112396d6 3689 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3690 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3691 (Fmake_variable_buffer_local, Fmake_local_variable):
3692 Mark variables as initialized.
52746918 3693 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3694
e5aab7e7 3695 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3696 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3697 Rename locals to avoid shadowing.
dff45157
PE
3698 (mark_stack): Move local variables into the #ifdef region where
3699 they're used.
7bc26fdb
PE
3700 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3701 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3702 needed otherwise.
3703 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3704 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3705 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3706
e5aab7e7
PE
3707 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3708 avoids undefined behavior in theory.
3709
4da60324
PE
3710 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3711
88043301
PE
3712 Use functions, not macros, for up- and down-casing (Bug#8254).
3713 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3714 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3715 to use the following functions instead of these macros.
3716 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3717 EMACS_INT, since callers assume the returned value fits in int.
3718 (upcase1): Likewise, for UPCASE_TABLE.
3719 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3720 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3721 the race-condition problem in the old DOWNCASE.
88043301 3722
19ed5445
PE
3723 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3724 Rename locals to avoid shadowing.
3725 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3726 (regex_compile, re_search_2, re_match_2_internal):
3727 Remove unused local vars.
952db0d7
PE
3728 (FREE_VAR): Rewrite so as not to use empty "else",
3729 which gcc can warn about.
da053e48 3730 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3731 (RETALLOC_IF): Define only if needed.
3732 (WORDCHAR_P): Likewise. This one is never needed, but is used
3733 only in a comment talking about a compiler bug, so put inside
3734 the #if 0 of that comment.
3735 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3736 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3737 Remove; unused.
19ed5445 3738
1f3561e4 3739 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3740 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3741 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3742
ded6f8f7
PE
3743 * search.c (simple_search): Remove unused var.
3744
dbd37a95
PE
3745 * dired.c (compile_pattern): Move decl from here ...
3746 * lisp.h: ... to here, so that it can be checked.
3747 (struct re_registers): New forward decl.
3748
7e47afad
PE
3749 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3750
85f24f61
PE
3751 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3752 All uses changed.
3753 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3754 Rename locals to avoid shadowing.
5671df8f 3755 (Fvertical_motion): Mark locals as initialized.
85f24f61 3756
181aa2be 3757 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3758 (casify_region): Mark local as initialized.
181aa2be 3759
930d429c
PE
3760 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3761
7082eac6
PE
3762 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3763 New macros, so that the caller can use some names other than
3764 gcpro1, gcpro2, etc.
3765 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3766 of the new macros.
3767 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3768 argument, for consistency with GCPRO2_VAR, etc: it is now the
3769 prefix of the variable, not the variable itself. All uses
3770 changed.
38b2c076
PE
3771 * dired.c (directory_files_internal, file_name_completion):
3772 Rename locals to avoid shadowing.
3773
15206ed9
PE
3774 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3775 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3776 dired.c's scmp function, had undefined behavior.
3777 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3778 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3779 * buffer.h: ... to here, because these macros use current_buffer,
3780 and the new implementation with inline functions needs to have
3781 current_buffer in scope now, rather than later when the macros
3782 are used.
3783 (downcase, upcase1): New static inline functions.
3784 (DOWNCASE, UPCASE1): Reimplement using these functions.
3785 This avoids undefined behavior in expressions like
3786 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3787 from race conditions in accessing the global variables
3788 case_temp1 and case_temp2.
3789 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3790 * lisp.h (case_temp1, case_temp2): Remove their decls.
3791 * character.h (ASCII_CHAR_P): Move from here ...
3792 * lisp.h: ... to here, so that the inline functions mentioned
3793 above can use them.
3794
4a6bea26
PE
3795 * dired.c (directory_files_internal_unwind): Now static.
3796
f14b7e14
PE
3797 * fileio.c (file_name_as_directory, directory_file_name):
3798 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3799 Now static.
2893f146
PE
3800 (file_name_as_directory): Use const pointers when appropriate.
3801 (Fexpand_file_name): Likewise. In particular, newdir might
3802 point at constant storage, so make it a const pointer.
fd4ead52 3803 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3804 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3805 signedness issues.
f839df0c
PE
3806 (Fset_file_times, Finsert_file_contents, auto_save_error):
3807 Rename locals to avoid shadowing.
f14b7e14 3808
5716756e 3809 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3810 (Ftry_completion, Fall_completions): Rename or remove locals
3811 to avoid shadowing.
5716756e 3812
b4c3046a
PE
3813 * marker.c (bytepos_to_charpos): Remove; unused.
3814
b45db522
PE
3815 * lisp.h (verify_bytepos, count_markers): New decls,
3816 so that gcc does not warn that these functions aren't declared.
3817
85876d07
PE
3818 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3819 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3820 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3821 (copy_text): Remove unused local var.
85876d07 3822
03d78a21 3823 * filelock.c (within_one_second): Now static.
b3dd38ab 3824 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3825
5df8f01b
PE
3826 * buffer.c (fix_overlays_before): Mark locals as initialized.
3827 (fix_start_end_in_overlays): Likewise. This function should be
3828 simplified by using pointers-to-pointers, but that's a different
3829 matter.
b1d876f1 3830 (switch_to_buffer_1): Now static.
8f54f30a
PE
3831 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3832 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3833
a70072c9 3834 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3835 Fix pointer signedness issue.
edced198
PE
3836 (sys_subshell): Mark local as volatile if checking for lint,
3837 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3838 (MAXPATHLEN): Define only if needed.
a70072c9 3839
a0977c44
PE
3840 * process.c (serial_open, serial_configure): Move decls from here ...
3841 * systty.h: ... to here, so that they can be checked.
3842
a884fdcc
PE
3843 * fns.c (get_random, seed_random): Move extern decls from here ...
3844 * lisp.h: ... to here, so that they can be checked.
3845
604efe86 3846 * sysdep.c (reset_io): Now static.
b8950c94 3847 (wait_for_termination_signal): Remove; unused.
604efe86 3848
38fc62d9
PE
3849 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3850 (copy_keymap_item, append_key, push_text_char_description):
3851 Now static.
1004a21a 3852 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3853 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3854 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3855 (describe_map_tree):
3856 Rename locals to avoid shadowing.
38fc62d9 3857
2f2650da
PE
3858 * keyboard.c: Declare functions static if they are not used elsewhere.
3859 (echo_char, echo_dash, cmd_error, top_level_2):
3860 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3861 (read_char, kbd_buffer_get_event, make_lispy_position):
3862 (make_lispy_event, make_lispy_movement, apply_modifiers):
3863 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3864 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3865 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3866 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3867 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3868
a053e86c 3869 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3870 (mark_kboards): Move decl here ...
3871 * alloc.c (mark_kboards): ... from here.
a053e86c 3872
4752793e
PE
3873 * lisp.h (force_auto_save_soon): New decl.
3874
74f10ca7 3875 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3876 (DEFINE_DUMMY_FUNCTION): New macro.
3877 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3878 Use it.
c03cd23f
PE
3879 (main): Add casts to avoid warnings
3880 if GCC considers string literals to be constants.
74f10ca7 3881
022e70d4
PE
3882 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3883
59d6fe83
PE
3884 * dbusbind.c: Pointer signedness fixes.
3885 (xd_signature, xd_append_arg, xd_initialize):
3886 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3887 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3888 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3889 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3890
78320123
PE
3891 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3892 if GCC considers string literals to be constants.
49cebcca 3893 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3894
35ac2a97
SM
38952011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3896
fb103ca9
SM
3897 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3898 (print_preprocess, print_object): New macro to fix last change.
3899
35ac2a97
SM
3900 * print.c (print_preprocess): Don't forget font objects.
3901
62973b41
JB
39022011-03-16 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * emacs.c (USAGE3): Doc fixes.
3905
0e48bb22
AS
39062011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3907
3908 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3909 structure.
3910
7684e57b
JB
39112011-03-14 Juanma Barranquero <lekktu@gmail.com>
3912
3913 * lisp.h (VWindow_system, Qfile_name_history):
3914 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3915 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3916 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3917
3918 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3919 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3920
3921 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3922 * w32console.c (detect_input_pending, read_input_pending)
3923 (encode_terminal_code):
3924 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3925 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3926 (w32_system_caret_y, Qfile_name_history):
3927 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3928 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3929 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3930 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3931 * w32proc.c (Qlocal, report_file_error):
3932 * w32term.c (Vwindow_system, updating_frame):
3933 * w32uniscribe.c (initialized, uniscribe_font_driver):
3934 Remove unneeded extern declarations.
3935
2aa46d6c
CY
39362011-03-14 Chong Yidong <cyd@stupidchicken.com>
3937
c96bbc66 3938 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3939
cffc6f3b
CY
39402011-03-13 Chong Yidong <cyd@stupidchicken.com>
3941
3942 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3943 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3944 These macros can no longer be used for assignment.
3945
44f230aa
SM
3946 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3947 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3948 (record_buffer_markers, fetch_buffer_markers): New functions for
3949 recording and fetching special buffer markers.
3950 (set_buffer_internal_1, set_buffer_temp): Use them.
3951
3952 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3953
3954 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3955
3956 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3957 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3958
3959 * xdisp.c (hscroll_window_tree):
3960 (reconsider_clip_changes): Use PT instead of BUF_PT.
3961
d251f04b
EZ
39622011-03-13 Eli Zaretskii <eliz@gnu.org>
3963
3964 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3965 $(EMACS_ROOT)/lib/intprops.h.
3966
f0c77cd1
PE
39672011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3968
3eca4629
PE
3969 Fix more problems found by GCC 4.5.2's static checks.
3970
7c86ee98
PE
3971 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3972 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3973 (xg_free_frame_widgets): Make it clear that a local variable is
3974 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3975 (gdk_window_get_screen): Make it clear that this macro is needed
3976 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3977 (int_gtk_range_get_value): New function, which avoids a diagnostic
3978 from gcc -Wbad-function-cast.
3979 (xg_set_toolkit_scroll_bar_thumb): Use it.
3980 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3981 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3982 (get_utf8_string, xg_get_file_with_chooser):
3983 Rename locals to avoid shadowing.
3984 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3985
41729b81
PE
3986 * xgselect.c (xg_select): Remove unused var.
3987
f0c77cd1
PE
3988 * image.c (four_corners_best): Mark locals as initialized.
3989 (gif_load): Initialize transparent_p to zero (Bug#8238).
3990 Mark another local as initialized.
ec6cf4c6 3991 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3992
ce0ad53d 3993 * image.c (clear_image_cache): Now static.
d5d5a617 3994 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3995 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3996 (x_edge_detection): Remove unnecessary cast that
3997 gcc -Wbad-function-cast diagnoses.
2037898d 3998 (gif_load): Fix pointer signedness.
6ae141d6
PE
3999 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4000 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4001
33383987 40022011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4003
d32df629
PE
4004 Improve quality of tests for time stamp overflow.
4005 For example, without this patch (encode-time 0 0 0 1 1
4006 1152921504606846976) returns the obviously-bogus value (-948597
4007 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4008 reports time overflow. See
4009 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4010 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4011 * editfns.c: Include limits.h and intprops.h.
4012 (TIME_T_MIN, TIME_T_MAX): New macros.
4013 (time_overflow): Move earlier, to before first use.
4014 (hi_time, lo_time): New functions, for an accurate test for
4015 out-of-range times.
4016 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4017 (Fget_internal_run_time): Don't assume time_t fits in int.
4018 (make_time): Use list2 instead of Fcons twice.
4019 (Fdecode_time): More accurate test for out-of-range times.
4020 (check_tm_member): New function.
4021 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4022 (lisp_time_argument): Don't rely on undefined left-shift and
4023 right-shift behavior when checking for time stamp overflow.
8be6f318 4024
fe31d94c
PE
4025 * editfns.c (time_overflow): New function, refactoring common code.
4026 (Fformat_time_string, Fdecode_time, Fencode_time):
4027 (Fcurrent_time_string): Use it.
4028
8be6f318
PE
4029 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4030 * dired.c (make_time): Move to ...
4031 * editfns.c (make_time): ... here.
4032 * systime.h: Note the move.
4033
09d9db2c 40342011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4035
126bc0dc
YM
4036 * fringe.c (update_window_fringes): Remove unused variables.
4037
c47cbdfd
YM
4038 * unexmacosx.c (copy_data_segment): Also copy __got section.
4039 (Bug#8223)
4040
7ac80be9
EZ
40412011-03-12 Eli Zaretskii <eliz@gnu.org>
4042
c96bbc66 4043 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4044 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4045 Constify `char *' arguments and their references according to
4046 prototypes in tparam.h.
4047
ecb0f94d 4048 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4049
7ac80be9
EZ
4050 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4051 Adapt all references accordingly.
4052
4053 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4054
ef1fd07e
TT
40552011-03-11 Tom Tromey <tromey@redhat.com>
4056
4057 * buffer.c (syms_of_buffer): Remove obsolete comment.
4058
7ef4b50c
EZ
40592011-03-11 Eli Zaretskii <eliz@gnu.org>
4060
4061 * termhooks.h (encode_terminal_code): Declare prototype.
4062
4063 * msdos.c (encode_terminal_code): Don't declare prototype.
4064
4065 * term.c (encode_terminal_code): Now external again, used by
4066 w32console.c and msdos.c.
4067
44f230aa
SM
4068 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4069 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4070
4b1ec863 40712011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4072
1714f52b 4073 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4074
4b1ec863
PE
4075 * fringe.c (update_window_fringes): Mark locals as initialized
4076 (Bug#8227).
4077 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4078
524c7aa6
PE
4079 * alloc.c (mark_fringe_data): Move decl from here ...
4080 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4081 to check its interface.
4082 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4083
a5c0af81 4084 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4085 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4086 (fontset_font): Mark local as initialized.
a9a06e0b 4087 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4088
b4716021
PE
4089 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4090
811e9bac 4091 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4092 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4093 (x_own_selection, Fx_disown_selection_internal): Rename locals
4094 to avoid shadowing.
4095 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4096
7e3ab302
PE
4097 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4098 so that the caller can use some name other than gcpro1.
4099 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4100 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4101 (Fx_backspace_delete_keys_p):
4102 Use them to avoid shadowing, and rename vars to avoid shadowing.
4103 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4104 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4105 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4106 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4107 Remove unused locals.
7e3ab302
PE
4108 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4109 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4110 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4111 macros.
f78faa98 4112
e2b13473
PE
4113 * xterm.h (x_mouse_leave): New decl.
4114
77f23912
PE
4115 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4116 Remove unused functions.
cdf4ba58
PE
4117 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4118 (x_calc_absolute_position): Now static.
7411c686 4119 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4120 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4121 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4122 unless they are used.
38d0b34a
PE
4123 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4124 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4125 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4126 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4127 (x_error_catcher, x_connection_closed, x_error_handler):
4128 (x_error_quitter, xembed_send_message, x_iconify_frame):
4129 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4130 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4131 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4132
44f230aa
SM
4133 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4134 Rename or move locals to avoid shadowing.
6b463e58 4135 (tty_defined_color, merge_face_heights): Now static.
5967d051 4136 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4137 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4138 does not deduce is never used uninitialized.
73719eba
PE
4139 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4140 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4141
426994c3 4142 * terminal.c (store_terminal_param): Now static.
5489860b 4143
032f1620 4144 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4145 (set_frame_menubar): Remove unused local.
d4323972 4146 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4147 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4148 since they might point to immutable storage.
281585b0
PE
4149 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4150 since it's unused otherwise.
032f1620 4151
367c19e5 4152 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4153 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4154 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4155 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4156 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4157 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4158 does not deduce are never used uninitialized.
70739cbe 4159
07b48fa9
PE
4160 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4161
8868a238 4162 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4163 * window.c (window_loop, size_window):
4164 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4165
7e5cf297 4166 * window.c (display_buffer): Now static.
d6550a9f
PE
4167 (size_window): Mark variables that gcc -Wuninitialized
4168 does not deduce are never used uninitialized.
a586633d
PE
4169 * window.h (check_all_windows): New decl, to forestall
4170 gcc -Wmissing-prototypes diagnostic.
5b555da1 4171 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4172
f6095868
PE
4173 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4174 shadowing.
4175 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4176 Include <limits.h>.
4177 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4178 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4179 (load_charset_map): Mark variables that gcc -Wuninitialized
4180 does not deduce are never used uninitialized.
53df7c11 4181 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4182
f38b440c
PE
4183 * coding.c (coding_set_source, coding_set_destination):
4184 Use "else { /* comment */ }" rather than "else /* comment */;"
4185 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4186 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4187 a block, when the outer 'i' will do.
4188 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4189 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4190 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4191 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4192 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4193 Rename locals to avoid shadowing.
4194 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4195 * coding.c (emacs_mule_char, encode_invocation_designation):
4196 Now static, since they're not used elsewhere.
413bb2db 4197 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4198 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4199 (decode_coding_emacs_mule): Mark variables that gcc
4200 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4201 (detect_coding_iso_2022): Initialize a local variable that might
4202 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4203 this initialization is needed. (Bug#8211)
5f58e762
PE
4204 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4205 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4206 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4207 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4208 Remove unused macros.
f38b440c 4209
232b38b9 4210 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4211 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4212 * character.c (string_count_byte8): Likewise.
232b38b9 4213
fb90da1b
PE
4214 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4215 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4216
fb93dbc2
PE
4217 * chartab.c (copy_sub_char_table): Now static, since it's not used
4218 elsewhere.
5c156ace
PE
4219 (sub_char_table_ref_and_range, char_table_ref_and_range):
4220 Rename locals to avoid shadowing.
bbcd0949 4221 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4222
7d3b3862 4223 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4224 (BIDI_BOB): Remove unused macro.
7d3b3862 4225
6be7d3da
PE
4226 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4227 deduce are never used uninitialized.
c2ed9c8b 4228 * term.c (encode_terminal_code): Likewise.
6be7d3da 4229
75f8807f 4230 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4231
50938595
PE
4232 * tparam.h: New file.
4233 * term.c, tparam.h: Include it.
4234 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4235 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4236 Move these decls to tparam.h, and make them agree with what
4237 is actually in tparam.c. The previous trick of using incompatible
4238 decls in different modules does not conform to the C standard.
4239 All callers of tparam changed to use tparam's actual API.
4240 * tparam.c (tparam1, tparam, tgoto):
4241 Use const pointers where appropriate.
4242
fbceeba2
PE
4243 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4244 * cm.h (struct cm): Likewise.
4245 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4246 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4247 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4248 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4249 (turn_on_face, init_tty): Likewise.
4250 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4251
7f3f1250
PE
4252 * term.c (term_mouse_position): Rename local to avoid shadowing.
4253
e6ca6543
PE
4254 * alloc.c (mark_ttys): Move decl from here ...
4255 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4256
c40f8d15
AS
42572011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4258
4259 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4260
cfe0661d
JB
42612011-03-09 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * search.c (compile_pattern_1): Remove argument regp, unused since
4264 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4265 (compile_pattern): Don't pass it.
4266
0afb4571
J
42672011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4268
4269 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4270 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4271 for ! HAVE_GTK3.
4272 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4273
4274 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4275
4276 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4277 gdk_window_get_screen, gdk_window_get_geometry,
4278 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4279 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4280 (xg_get_pixbuf_from_pixmap): New function.
4281 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4282 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4283 Call xg_get_pixbuf_from_pixmap instead of
4284 gdk_pixbuf_get_from_drawable.
4285 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4286 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4287 (xg_check_special_colors): Use GtkStyleContext and its functions
4288 for HAVE_GTK3.
4289 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4290 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4291 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4292 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4293 Call gtk_widget_get_preferred_size.
0afb4571
J
4294 (xg_frame_resized): gdk_window_get_geometry only takes 5
4295 parameters.
44f230aa
SM
4296 (xg_win_to_widget, xg_event_is_for_menubar):
4297 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4298 (xg_set_widget_bg): New function.
4299 (delete_cb): New function.
895009e1 4300 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4301 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4302 (xg_set_background_color): Call xg_set_widget_bg.
4303 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4304 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4305 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4306 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4307 if ! HAVE_GTK3.
4308 (update_frame_tool_bar): Call gtk_widget_hide.
4309 (xg_initialize): Use GDK_KEY_g.
4310
4311 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4312 if ! HAVE_GTK3
4313 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4314
4315 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4316 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4317 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4318
1c2cc4ef
JB
43192011-03-08 Juanma Barranquero <lekktu@gmail.com>
4320
4321 * w32xfns.c (select_palette): Check success of RealizePalette against
4322 GDI_ERROR, not zero.
4323
33383987 4324See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4325
4326;; Local Variables:
4327;; coding: utf-8
aac0c6e3
MR
4328;; End:
4329
33383987 4330 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4331
4332 This file is part of GNU Emacs.
4333
4334 GNU Emacs is free software: you can redistribute it and/or modify
4335 it under the terms of the GNU General Public License as published by
4336 the Free Software Foundation, either version 3 of the License, or
4337 (at your option) any later version.
4338
4339 GNU Emacs is distributed in the hope that it will be useful,
4340 but WITHOUT ANY WARRANTY; without even the implied warranty of
4341 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4342 GNU General Public License for more details.
4343
4344 You should have received a copy of the GNU General Public License
4345 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.