gnus-msg.el (gnus-msg-mail): Ensure that gnus-newsgroup-name is a string so that...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
23415acf
EZ
12012-05-21 Eli Zaretskii <eliz@gnu.org>
2
3 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4 Update value to 24.
5
44e27368
EZ
62012-05-19 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
9 state after an additional call to move_it_in_display_line_to, keep
10 the values of it->max_ascent and it->max_descent found for the
11 entire line.
12 (pos_visible_p): Revert the comparison against bottom_y to what it
13 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
14 (Bug#11464)
15
ccbf309c
EZ
162012-05-15 Eli Zaretskii <eliz@gnu.org>
17
18 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
19
ac268e67
EZ
202012-05-13 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
23 already have overlays loaded.
24 (handle_single_display_spec): Before returning without displaying
25 fringe bitmap, synchronize the bidi iterator with the main display
26 iterator, by calling iterate_out_of_display_property.
27 (iterate_out_of_display_property): Detect buffer iteration by
28 testing that it->string is a Lisp string.
29 (get_next_display_element): When the current object is exhausted,
30 and there's something on it->stack, call set_iterator_to_next to
31 proceed with what's on the stack, instead of returning zero.
32 (set_iterator_to_next): If called at the end of a Lisp string,
33 proceed to consider_string_end without incrementing string
34 position. Don't increment display vector index past the end of
35 the display vector. (Bug#11417)
c8fb9dc6
EZ
36 (pos_visible_p): Don't report a position visible when move_it_to
37 stopped at the last line of window, which happens to be scanned
38 backwards by the bidi iteration. (Bug#11464)
ac268e67 39
82f9b393
EZ
402012-05-11 Eli Zaretskii <eliz@gnu.org>
41
42 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
43 and right-margin display specs even if the spec is invalid or we
44 are on a TTY, and thus unable to display on the fringes. That's
45 because the text with the property will not be displayed anyway,
46 so we need to signal to the caller that this is a "replacing"
47 display spec. This fixes display when the spec is invalid or we
48 are on a TTY.
49
297834cd
PE
502012-05-09 Paul Eggert <eggert@cs.ucla.edu>
51
52 * unexaix.c (make_hdr): Fix typo in prototype.
53 This bug broke the build on AIX. Problem reported by Gilles Pion.
54
0d887c7d
EZ
552012-05-05 Eli Zaretskii <eliz@gnu.org>
56
57 * w32proc.c (new_child): Force Windows to reserve only 64KB of
58 stack for each reader_thread, instead of defaulting to 8MB
59 determined by the linker. This avoids failures in creating
60 subprocesses on Windows 7, see the discussion in this thread:
61 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
62
bf98199c
JM
632012-05-02 Jim Meyering <meyering@redhat.com>
64
65 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
66
2fa85638
EZ
672012-04-29 Eli Zaretskii <eliz@gnu.org>
68
69 * xdisp.c (pos_visible_p): If already at a newline from the
70 display string before the 'while' loop, don't walk back the glyphs
71 from it3.glyph_row. Solves assertion violation when the display
72 string begins with a newline (egg.el). (Bug#11367)
73
9be2fd9b
CY
742012-04-24 Chong Yidong <cyd@gnu.org>
75
76 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
77
f0ee99a0
EZ
782012-04-23 Eli Zaretskii <eliz@gnu.org>
79
80 * xdisp.c (pos_visible_p): If the window start position is beyond
81 ZV, start the display from buffer beginning. Prevents assertion
82 violation in init_iterator when the minibuffer window is scrolled
83 via the scroll bar.
84
85 * window.c (window_scroll_pixel_based): Likewise.
86
9ec7751f
CY
872012-04-23 Chong Yidong <cyd@gnu.org>
88
89 * keymap.c (where_is_internal): Doc fix (Bug#10872).
90
24c51a09
GM
912012-04-20 Glenn Morris <rgm@gnu.org>
92
93 * fileio.c (Fcopy_file, Fset_file_selinux_context):
94 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
95
73055685
EZ
962012-04-20 Eli Zaretskii <eliz@gnu.org>
97
98 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
99 overrun array limits of glyph row's used[] array. (Bug#11288)
100
f30d612a
CY
1012012-04-20 Chong Yidong <cyd@gnu.org>
102
103 * process.c (wait_reading_process_output): If EIO occurs on a pty,
104 set the status to "failed" and ensure that sentinel is run.
105
016a35df
GM
1062012-04-18 Glenn Morris <rgm@gnu.org>
107
108 * process.c (Fset_process_inherit_coding_system_flag)
109 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 110 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 111
20a68157
EZ
1122012-04-17 Eli Zaretskii <eliz@gnu.org>
113
114 * xdisp.c (string_buffer_position_lim): Limit starting position to
115 BEGV.
116 (set_cursor_from_row): If called for a mode-line or header-line
117 row, return zero immediately.
118 (try_cursor_movement): If inside continuation line, don't back up
119 farther than the first row after the header line, if any. Don't
120 consider the header-line row as "partially visible", even if
121 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
122
ad3a2b41
AO
1232012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
124
125 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
126
e63c261b
CY
1272012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
128
129 * process.c (make_process):
130 * process.h: Add integer `gnutls_handshakes_tried' member to
131 process struct.
132
ad3a2b41
AO
133 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
134 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
135
136 * gnutls.c (gnutls_log_function2i): Convenience log function.
137 (emacs_gnutls_read): Use new log functions,
138 `gnutls_handshakes_tried' process member, and
139 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
140 attempts per process (connection).
141
e53357c4
EZ
1422012-04-09 Eli Zaretskii <eliz@gnu.org>
143
144 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
145 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
146
aff67c82
JD
1472012-04-09 Jan Djärv <jan.h.d@swipnet.se>
148
149 * nsterm.m (constrainFrameRect): Always constrain when there is only
150 one screen (Bug#10962).
151
2f8e16b2
EZ
1522012-04-06 Eli Zaretskii <eliz@gnu.org>
153
154 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
155 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
156 about subtle differences between FETCH_CHAR* and STRING_CHAR*
157 macros related to unification of CJK characters. For the details,
158 see the discussion following the message here:
159 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
160
3d439cd1
CY
1612012-04-04 Chong Yidong <cyd@gnu.org>
162
163 * keyboard.c (Vdelayed_warnings_list): Doc fix.
164
8bc53d00
EZ
1652012-04-01 Eli Zaretskii <eliz@gnu.org>
166
167 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
168 instead of alloca. (Bug#11138)
169
3b0512a3
AS
1702012-04-01 Andreas Schwab <schwab@linux-m68k.org>
171
172 * w32menu.c (is_simple_dialog): Properly check lisp types.
173 (Bug#11141)
174
8427ddd2
EZ
1752012-03-31 Eli Zaretskii <eliz@gnu.org>
176
979022ef
EZ
177 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
178 position we get to after a call to move_it_to fails the
179 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
180 only if we wind up in a string from display property. (Bug#11063)
181
a6b1c7cc
EZ
182 * window.c (Fdelete_other_windows_internal): Invalidate the row
183 and column information about mouse highlight, so that redisplay
184 restores it after reallocating the glyph matrices. (Bug#7464)
185
8427ddd2
EZ
186 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
187 string comes from a `display' text property, use the buffer
188 position of that property as if we actually saw that position in
189 the row's glyphs.
697ba24b
EZ
190 (move_it_by_lines): Remove the assertion that
191 "it->current_x == 0 && it->hpos == 0" which can be legitimately
192 violated when there's a before-string at the beginning of a line.
193 (Bug#11063)
8427ddd2 194
65a0a738
EZ
1952012-03-30 Eli Zaretskii <eliz@gnu.org>
196
197 * xdisp.c (append_space_for_newline): If the default face was
198 remapped, use the remapped face for the appended newline.
199 (extend_face_to_end_of_line): Use the remapped default face for
200 extending the face to the end of the line.
201 (display_line): Call extend_face_to_end_of_line when the default
202 face was remapped. (Bug#11068)
203
581355cc
EZ
2042012-03-29 Eli Zaretskii <eliz@gnu.org>
205
206 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
207
e8fc049f
SM
2082012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
209
210 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
211
4fb9a543
GM
2122012-03-27 Glenn Morris <rgm@gnu.org>
213
214 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
215 Doc fixes.
216
679910f1
KH
2172012-03-26 Kenichi Handa <handa@m17n.org>
218
219 * dispextern.h (struct glyph): Fix previous change. Change the
220 bit length of glyphless.ch to 25 (Bug#11082).
221
90d49b7f
CY
2222012-03-26 Chong Yidong <cyd@gnu.org>
223
224 * keyboard.c (Vselection_inhibit_update_commands): New variable.
225 (command_loop_1): Use it; inhibit selection update for
226 handle-select-window too (Bug#8996).
227
f514f6f0
FP
2282012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
229
e8fc049f 230 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 231
bf43fa51
KH
2322012-03-25 Kenichi Handa <handa@m17n.org>
233
234 * dispextern.h (struct glyph): Change the bit length of
235 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
236
8a0c01dd
EZ
2372012-03-24 Eli Zaretskii <eliz@gnu.org>
238
239 * s/ms-w32.h (tzname): Include time.h before redirecting to
240 _tzname. Fixes the MSVC build. (Bug#9960)
241
7d1c3a76
AS
2422012-03-24 Andreas Schwab <schwab@linux-m68k.org>
243
8ed79523
AS
244 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
245 characters.
246
7d1c3a76
AS
247 * xterm.c (XTread_socket): Only modify handling_signal if
248 !SYNC_INPUT. (Bug#11080)
249
e99a9b8b
EZ
2502012-03-23 Eli Zaretskii <eliz@gnu.org>
251
252 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
253 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
254 when fetching a multibyte character consumes more bytes than
255 CHAR_BYTES returns, due to unification of CJK characters in
256 string_char. (Bug#11073)
257
5063c0e1
TN
2582012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
259
260 * process.c (wait_reading_process_output): Handle pty disconnect
261 by refraining from sending oneself a SIGCHLD (bug#10933).
262
9f851fbd
CY
2632012-03-22 Chong Yidong <cyd@gnu.org>
264
265 * dispextern.h (struct it): New member string_from_prefix_prop_p.
266
5063c0e1 267 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
268 Mark string as coming from a prefix property.
269 (handle_face_prop): Use default face for prefix strings (Bug#4281).
270 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
271
fb5b8aca
CY
2722012-03-21 Chong Yidong <cyd@gnu.org>
273
274 * xfaces.c (Vface_remapping_alist): Doc fix.
275
62356a1b
EZ
2762012-03-20 Eli Zaretskii <eliz@gnu.org>
277
278 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
279 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
280 Doc fixes.
62356a1b 281
025de85b
CY
2822012-03-20 Chong Yidong <cyd@gnu.org>
283
284 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
285 to reflect default non-nil value of redisplay-dont-pause.
286
4827f94e
KH
2872012-03-19 Kenichi Handa <handa@m17n.org>
288
289 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
290 it fit in a valid range (Bug#11003).
291
e50a24a2
EZ
2922012-03-18 Eli Zaretskii <eliz@gnu.org>
293
294 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
295 that is not from display property, accept the row as a "cursor
296 row" if one of the string's character has a non-nil `cursor'
297 property. Fixes cursor positioning when there are newlines in
298 overlay strings, e.g. in icomplete.el. (Bug#11035)
299
9af5ed87
PE
3002012-03-12 Paul Eggert <eggert@cs.ucla.edu>
301
302 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
303
d1f55f16
CY
3042012-03-12 Chong Yidong <cyd@gnu.org>
305
306 * eval.c (inhibit_lisp_code): Rename from
307 inhibit_window_configuration_change_hook; move from window.c.
308
309 * xfns.c (unwind_create_frame_1, Fx_create_frame):
310 * window.c (run_window_configuration_change_hook)
311 (syms_of_window): Callers changed.
312
66c5eebd
CY
3132012-03-11 Chong Yidong <cyd@gnu.org>
314
413df973
CY
315 * keymap.c (Fkey_description): Doc fix (Bug#9700).
316
66c5eebd
CY
317 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
318
1de11f56
CY
3192012-03-10 Chong Yidong <cyd@gnu.org>
320
321 * frame.c (other_visible_frames): Don't assume the selected frame
322 is visible (Bug#10955).
323
cae07000
SM
3242012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
327
89c94350
JD
3282012-03-08 Jan Djärv <jan.h.d@swipnet.se>
329
330 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
331 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
332 zero (Bug#10954).
333
999dd333
GM
3342012-03-03 Glenn Morris <rgm@gnu.org>
335
01a6dcc8 336 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 337
de0100f2
EZ
3382012-03-02 Eli Zaretskii <eliz@gnu.org>
339
340 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
341 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
342 (redisplay_window, next_element_from_string): Fix typos in
343 comments.
3e441275
EZ
344 (redisplay_window): Pass to move_it_vertically the margin in
345 pixels, not in screen lines.
de0100f2 346
96a72ee9
GM
3472012-03-02 Glenn Morris <rgm@gnu.org>
348
349 * buffer.c (buffer-list-update-hook): Doc fix.
350
312508d7
EZ
3512012-02-29 Eli Zaretskii <eliz@gnu.org>
352
353 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
354 push_it before setting up the iterator for the first overlay
355 string, even if we have an empty string loaded.
356 (next_overlay_string): If there's an empty string on the iterator
357 stack, pop the stack. (Bug#10903)
358
27f3c637
PE
3592012-02-25 Paul Eggert <eggert@cs.ucla.edu>
360
361 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
362 Suggested by Stefan Monnier in
363 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
364 * alloc.c (widen_to_Lisp_Object): New static function.
365 (mark_memory): Also mark Lisp_Objects by fetching pointer words
366 and widening them to Lisp_Objects. This would work even if
367 USE_LSB_TAG is defined and wide integers are used, which might
368 happen in a future version of Emacs.
369
3c9dfce6
CY
3702012-02-25 Chong Yidong <cyd@gnu.org>
371
fa74b241
CY
372 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
373 Doc fix.
374
3c9dfce6
CY
375 * xselect.c (Fx_selection_exists_p): Doc fix.
376 (x_clipboard_manager_save_all): Print an informative message
377 before saving to clipboard manager.
378
9486df08
CY
3792012-02-24 Chong Yidong <cyd@gnu.org>
380
381 * keyboard.c (process_special_events): Handle all X selection
382 requests in kbd_buffer, not just the next one (Bug#8869).
383
f01d3321
CY
3842012-02-23 Chong Yidong <cyd@gnu.org>
385
386 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
387 call when setting menu-bar-lines and tool-bar-lines parameters.
388 (unwind_create_frame_1): New helper function.
389
390 * window.c (inhibit_window_configuration_change_hook): New var.
391 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 392 (syms_of_window): Initialize it.
f01d3321 393
86b847b6
CY
3942012-02-22 Chong Yidong <cyd@gnu.org>
395
396 * xterm.c (x_draw_image_relief): Add missing type check for
397 Vtool_bar_button_margin (Bug#10743).
398
a59225b1
CY
3992012-02-21 Chong Yidong <cyd@gnu.org>
400
401 * fileio.c (Vfile_name_handler_alist): Doc fix.
402
403 * buffer.c (Fget_file_buffer): Protect against invalid file
404 handler return value.
405
310f5bd4
PE
4062012-02-20 Paul Eggert <eggert@cs.ucla.edu>
407
cb3a28cc
PE
408 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
409 when computing $valmask.
410
310f5bd4
PE
411 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
412 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
413 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
414 It's useless in that case, and it can cause problems on hosts
415 that allocate halves of EMACS_INT values separately.
416 Reported by Dan Horák. Diagnosed by Andreas Schwab in
417 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
418 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
419 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
420 it avoids undefined behavior on hosts where shifting right by more
421 than the word width has undefined behavior.
422
2375c96a
CY
4232012-02-19 Chong Yidong <cyd@gnu.org>
424
425 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
426 (Funhandled_file_name_directory, Ffile_name_as_directory)
427 (Fdirectory_file_name, Fexpand_file_name)
428 (Fsubstitute_in_file_name): Protect against invalid file handler
429 return values (Bug#10845).
430
3eb49e71
EZ
4312012-02-18 Eli Zaretskii <eliz@gnu.org>
432
433 * .gdbinit (pitx): Fix incorrect references to fields of the
434 iterator stack.
435
7b926f3f
CY
4362012-02-17 Chong Yidong <cyd@gnu.org>
437
438 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
439
11273115
PE
4402012-02-15 Paul Eggert <eggert@cs.ucla.edu>
441
442 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
443 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
444
c3a70e2b
CY
4452012-02-15 Chong Yidong <cyd@gnu.org>
446
447 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
448 marked as special. Also, starting docstrings with * is obsolete.
449
0ca43699
AS
4502012-02-13 Andreas Schwab <schwab@linux-m68k.org>
451
452 * gnutls.c (emacs_gnutls_write): Fix last change.
453
2e8f3c56
LI
4542012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
455
456 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
457 send_process.
458
af70074f
SM
4592012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
460
461 * keymap.c (Fsingle_key_description): Handle char ranges.
462
95986d52
CY
4632012-02-12 Chong Yidong <cyd@gnu.org>
464
afd83bd1
CY
465 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
466 as that creates a dangerous corner case.
467
95986d52
CY
468 * window.c (Fdelete_window_internal): Invalidate the mouse
469 highlight (Bug#9904).
470
bd7da63e
GM
4712012-02-12 Glenn Morris <rgm@gnu.org>
472
473 * xselect.c (Fx_own_selection_internal)
474 (Fx_get_selection_internal, Fx_disown_selection_internal)
475 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
476 * nsselect.m (Fx_own_selection_internal)
477 (Fx_disown_selection_internal, Fx_selection_exists_p)
478 (Fx_selection_owner_p, Fx_get_selection_internal):
479 Sync docs and argument specs with the xselect.c versions.
480
77abcbc2
LI
4812012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
482
483 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
484
90b671e2
EZ
4852012-02-11 Eli Zaretskii <eliz@gnu.org>
486
1c0ca0b7
EZ
487 * w32select.c (Fx_selection_exists_p): Sync doc string and
488 argument list with xselect.c. (Bug#10783)
489
490 * w16select.c (Fx_selection_exists_p): Sync doc string and
491 argument list with xselect.c. (Bug#10783)
90b671e2 492
49241268
GM
4932012-02-10 Glenn Morris <rgm@gnu.org>
494
495 * fns.c (Fsecure_hash): Doc fix.
496
f998bbe7 4972012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
498
499 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
500
0992bd9c
CY
5012012-02-07 Chong Yidong <cyd@gnu.org>
502
503 * buffer.c (Fbuffer_local_variables)
504 (buffer_lisp_local_variables): Handle unbound vars correctly;
505 don't let Qunbound leak into Lisp.
506
af008560
GM
5072012-02-07 Glenn Morris <rgm@gnu.org>
508
dd605cc4
GM
509 * image.c (Fimagemagick_types): Doc fix.
510
af008560
GM
511 * image.c (imagemagick-render-type): Change it from a lisp object
512 to an integer. Move the doc here from the lisp manual.
513 Treat all values not equal to 0 the same.
514
1449fa1d
CY
5152012-02-06 Chong Yidong <cyd@gnu.org>
516
517 * doc.c (store_function_docstring): Avoid applying docstring of
518 alias to base function (Bug#2603).
519
3723ec07
AS
5202012-02-04 Andreas Schwab <schwab@linux-m68k.org>
521
522 * .gdbinit (pp1, pv1): Remove redundant defines.
523 (pr): Use pp.
524
79c1cc1e
CY
5252012-02-04 Chong Yidong <cyd@gnu.org>
526
527 * nsterm.m: Declare a global (Bug#10694).
528
d7f29f8e
EZ
5292012-02-04 Eli Zaretskii <eliz@gnu.org>
530
cae07000
SM
531 * w32.c (get_emacs_configuration_options):
532 Include --enable-checking, if specified, in the return value.
d7f29f8e 533
3b95a6f9
MR
5342012-02-04 Martin Rudalics <rudalics@gmx.at>
535
536 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
537 after rounding frame sizes. (Bug#9723)
538
d6fa96a6
EZ
5392012-02-04 Eli Zaretskii <eliz@gnu.org>
540
541 * keyboard.c (adjust_point_for_property): Don't position point
542 before BEGV. (Bug#10696)
543
df0b2940
PE
5442012-02-03 Paul Eggert <eggert@cs.ucla.edu>
545
546 Handle overflow when computing char display width (Bug#9496).
547 * character.c (char_width): Return EMACS_INT, not int.
548 (char_width, c_string_width): Check for overflow when
549 computing the width; this is possible now that individual
550 characters can have unbounded width. Problem introduced
551 by merge from Emacs 23 on 2012-01-19.
552
6bee44d6
MA
5532012-02-02 Michael Albinus <michael.albinus@gmx.de>
554
555 * dbusbind.c (Fdbus_register_method): Mention the return value
556 :ignore in the docstring.
557
44f92739
GM
5582012-02-02 Glenn Morris <rgm@gnu.org>
559
1b9f60cc
GM
560 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
561
44f92739
GM
562 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
563 Unconditionally set to t. (Bug#10673)
564 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
565 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
566 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
567
c5d3843c
KH
5682012-02-02 Kenichi Handa <handa@m17n.org>
569
570 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
571 0, do not call append_composite_glyph.
572
159462d4 5732012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
574
575 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
576 NULL (Bug#6988).
577 (x_produce_glyphs): If the component of a composition is a null
578 string, set it->pixel_width to 1 to avoid zero-width glyph.
579
78cef877
EZ
5802012-02-01 Eli Zaretskii <eliz@gnu.org>
581
582 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
583 first 2 arguments are identical. This makes inserting large
584 output from a subprocess an order of magnitude faster on
585 MS-Windows, where all sbrk'ed memory is always contiguous.
586
97897668
GM
5872012-01-31 Glenn Morris <rgm@gnu.org>
588
589 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 590 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
591 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
592
31fd3586
GM
5932012-01-29 Glenn Morris <rgm@gnu.org>
594
595 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
596
0e24a8b2
CY
5972012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
598
599 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
600
cc0adcb0
CY
6012012-01-28 Chong Yidong <cyd@gnu.org>
602
603 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
604
acc28cb9
CY
6052012-01-26 Chong Yidong <cyd@gnu.org>
606
9c69cfb7
CY
607 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
608
acc28cb9
CY
609 * search.c (Fsearch_forward, Fsearch_backward): Document negative
610 repeat counts (Bug#10507).
611
48da7392
GM
6122012-01-26 Glenn Morris <rgm@gnu.org>
613
614 * lread.c (syms_of_lread): Doc fix.
615
14af5f7f
CY
6162012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
617
618 * coding.c (encode_designation_at_bol): Change return value to
619 EMACS_INT.
620
0b21c100
CY
6212012-01-25 Chong Yidong <cyd@gnu.org>
622
623 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
624
3c2907f7
CY
6252012-01-21 Chong Yidong <cyd@gnu.org>
626
627 * floatfns.c (Fcopysign): Make the second argument non-optional,
628 since nil is not allowed anyway.
629
959ad23f
AS
6302012-01-21 Andreas Schwab <schwab@linux-m68k.org>
631
632 * process.c (read_process_output): Use p instead of XPROCESS (proc).
633 (send_process): Likewise.
634
34a02f46
MR
6352012-01-19 Martin Rudalics <rudalics@gmx.at>
636
637 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
638 (Vwindow_persistent_parameters): Do not use Qstate.
639 Rewrite doc-strings.
34a02f46 640
1259009a 6412012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
642
643 * character.c (char_width): New function.
70d4fdf6
GM
644 (Fchar_width, c_string_width, lisp_string_width):
645 Use char_width (Bug#9496).
25ed9e61 646
6a6ee00d
MR
6472012-01-16 Martin Rudalics <rudalics@gmx.at>
648
649 * window.c (Vwindow_persistent_parameters): New variable.
650 (Fset_window_configuration, save_window_save): Handle persistent
651 window parameters.
652
c85efaf7
EZ
6532012-01-14 Eli Zaretskii <eliz@gnu.org>
654
655 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
656 thrashing the stack of the thread. (Bug#9087)
657
5944709e
PE
6582012-01-12 Paul Eggert <eggert@cs.ucla.edu>
659
660 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
661
e71f5d99
EZ
6622012-01-11 Eli Zaretskii <eliz@gnu.org>
663
664 * xdisp.c (rows_from_pos_range): Handle the case where the
665 highlight ends on a newline. (Bug#10464)
666 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
667 he end column for display of highlight that ends on a newline
668 before a R2L line.
669
ce316182
GM
6702012-01-11 Glenn Morris <rgm@gnu.org>
671
672 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
673 from load-path also when installation-directory is nil. (Bug#10208)
674
5b43da69
GM
6752012-01-10 Glenn Morris <rgm@gnu.org>
676
74cc8ff9
GM
677 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
678
7d8d6e4e
GM
679 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
680 Update template values to be closer to their typical values these days.
5b43da69 681
a0db8d43
EZ
6822012-01-09 Eli Zaretskii <eliz@gnu.org>
683
684 * xdisp.c (rows_from_pos_range): Accept additional argument
685 DISP_STRING, and accept any glyph in a row whose object is that
686 string as eligible for mouse highlight. Fixes mouse highlight of
687 display strings from overlays. (Bug#10464)
688
9a0115ab 6892012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 690
b9110d6a 691 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
692 * fileio.c (auto_saving_dir_umask): New static var.
693 (Fmake_directory_internal): Use it.
694 (do_auto_save_make_dir): Set it, instead of invoking chmod after
695 creating the directory. The old code temporarily assigns
696 too-generous permissions to the directory.
697 (do_auto_save_eh): Clear it.
b9110d6a 698 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
699 that the var is always cleared.
700
6c1bd3f3
EZ
7012012-01-07 Eli Zaretskii <eliz@gnu.org>
702
703 * search.c (scan_buffer): Pass character positions to
704 know_region_cache, not byte positions. (Bug#6540)
705
069d2b50
L
7062012-01-07 LynX <_LynX@bk.ru> (tiny change)
707
708 * w32.c (sys_rename): Report EXDEV when rename of a directory
709 fails because the target is on another logical disk. (Bug#10284)
710
75bf0d33
DB
7112012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
712
713 * xterm.c (x_embed_request_focus): New function.
714
715 * xterm.h: Add prototype.
716
717 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
718
1c6e5a32
GM
7192012-01-05 Glenn Morris <rgm@gnu.org>
720
721 * emacs.c (emacs_copyright): Update short copyright year to 2012.
722
651e947e
EZ
7232012-01-01 Eli Zaretskii <eliz@gnu.org>
724
725 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
726 Load gnutls_transport_set_lowat only if GnuTLS version is below
727 2.11.1.
728 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
729 GnuTLS versions below 2.11.1.
730
3778cdd8
AL
7312011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
732
733 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
734 to the doc string advising against its use for altering the way
735 windows are scrolled.
736
0e5317f7
KH
7372011-12-28 Kenichi Handa <handa@m17n.org>
738
739 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
740 coding-system ASCII compatible only when it does not produce BOM
741 on encoding (Bug#10383).
742
93d5ca1f
JD
7432011-12-26 Jan Djärv <jan.h.d@swipnet.se>
744
745 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
746 can scroll.
747 (create_and_show_popup_menu): Always use menu_position_func for
748 Gtk3 (Bug#10361).
749
ca22b785
AS
7502011-12-24 Andreas Schwab <schwab@linux-m68k.org>
751
752 * callint.c (Fcall_interactively): Don't truncate prompt string.
753
d048e1e6
EZ
7542011-12-23 Eli Zaretskii <eliz@gnu.org>
755
756 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
757 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 758 resumed from there (after widening). (Bug#10360)
d048e1e6 759
5ccaba1f
JD
7602011-12-22 Jan Djärv <jan.h.d@swipnet.se>
761
762 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
763
204ee57f
JD
7642011-12-21 Jan Djärv <jan.h.d@swipnet.se>
765
b81d40f0
JB
766 * nsterm.m (x_free_frame_resources):
767 Release f->output_data.ns->miniimage.
204ee57f
JD
768 (ns_index_color): Fix indentation. Do not retain
769 color_table->colors[i].
770
771 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
772 before returning.
773
774 * nsfns.m (x_set_background_color): Assign return value from
775 ns_index_color to face-background instead of NSColor*.
776 (ns_implicitly_set_icon_type): Fix indentation.
777 Change assignment in for loop to comparison.
778
779 * emacs.c (ns_pool): New variable.
780 (main): Assign ns_pool.
781 (Fkill_emacs): Call ns_release_autorelease_pool.
782
783 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
784 autorelease fdesc, release fdAttrs and tdict.
785 (ns_get_covering_families): Release charset.
786 (ns_findfonts): Release NSFontDescriptor created with new.
787 (ns_uni_to_glyphs): Fix indentation.
788 (setString): Release attrStr before assigning new value.
789
c803b2b7
JD
7902011-12-18 Jan Djärv <jan.h.d@swipnet.se>
791
678f4426
JD
792 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
793 and NS_IMPL_COCOA.
794 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
795 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
796
cd394be1 7972011-12-18 David Reitter <reitter@cmu.edu>
678f4426 798
5fecd5fc
JD
799 * nsterm.m (ns_term_init): Subscribe for notifications
800 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
801 to method trackingNotification in EmacsMenu.
802
803 * nsmenu.m (trackingMenu): New variable.
3771cb17 804 (trackingNotification): New method (from Aquamacs).
5fecd5fc 805 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 806 from Aquamacs (Bug#7030).
678f4426
JD
807
8082011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 809
c803b2b7
JD
810 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
811 (symbol_to_nsstring): Fix indentation.
812 (ns_symbol_to_pb): New function.
cae07000
SM
813 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
814 (Fns_rotate_cut_buffers_internal): Remove.
815 (Fns_store_selection_internal): Rename from
c803b2b7
JD
816 Fns_store_cut_buffer_internal.
817 (ns_get_foreign_selection, Fx_own_selection_internal)
818 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
819 (Fns_get_selection_internal, Fns_store_selection_internal):
820 Use ns_symbol_to_pb and check if return value is nil.
821 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
822 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
823 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
824 renamed to Sns_store_selection_internal.
825 (ns_handle_selection_request): Move code to Fx_own_selection_internal
826 and remove this function.
827 (ns_handle_selection_clear): Remove, never used.
828 (Fx_own_selection_internal): Move code from ns_handle_selection_request
829 here.
830
e1b01a3a
KB
8312011-12-17 Ken Brown <kbrown@cornell.edu>
832
833 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
834 GID is unknown (Bug#10257).
835
2adb6e85
PE
8362011-12-17 Paul Eggert <eggert@cs.ucla.edu>
837
838 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
839 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
840 which caused a build failure on GNU/Linux IA-64. This problem was
841 introduced by my 2011-10-07 patch.
842
d1d7b339
JL
8432011-12-15 Juri Linkov <juri@jurta.org>
844
845 * image.c (imagemagick_error): New function. (Bug#10112)
846 (imagemagick_load_image): Comment out `MagickSetResolution' call.
847 Use `imagemagick_error' where ImageMagick functions return
848 `MagickFalse'.
849 (Fimagemagick_types): Add `Fnreverse' to return the list in the
850 proper order.
851
100d5755
KH
8522011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
853
854 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
855 fill background (Bug#8992).
856
454592a6
MR
8572011-12-13 Martin Rudalics <rudalics@gmx.at>
858
859 * window.c (Vwindow_combination_resize)
860 (Vwindow_combination_limit): Use t instead of non-nil in
861 doc-strings.
61d4b438
MR
862 (Vrecenter_redisplay): Add first sentence of doc-string on
863 separate line.
53524d93 864 (Frecenter): Fix doc-string typo.
454592a6 865
3633e3aa
KH
8662011-12-11 Kenichi Handa <handa@m17n.org>
867
868 * coding.c (Funencodable_char_position): Pay attention to the
869 buffer text relocation (Bug#9389).
870
7b9d523a
JD
8712011-12-10 Jan Djärv <jan.h.d@swipnet.se>
872
873 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
874 gtk_init (Bug#10100).
875
b73189c6
EZ
8762011-12-10 Eli Zaretskii <eliz@gnu.org>
877
878 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
879 IT->string is nil. (Bug#10263)
880
f7dfe5d6
JD
8812011-12-10 Jan Djärv <jan.h.d@swipnet.se>
882
83faebb4
JD
883 * nsterm.h (x_free_frame_resources): Declare.
884
f7dfe5d6
JD
885 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
886 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
887
888 * nsterm.h (ns_get_defaults_value): Declare.
889
890 * nsterm.m (ns_default): Call ns_get_defaults_value.
891
7cd4e72c
EZ
8922011-12-09 Eli Zaretskii <eliz@gnu.org>
893
894 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
895 (Bug#10170)
896
b34d7317
YM
8972011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
898
899 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
900 that where the value of an _OBJC_* symbol points to is in the .bss
901 section (Bug#10240).
902
76470ad1
KH
9032011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
904
905 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 906 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 907
745fff94
KH
9082011-12-08 Kenichi Handa <handa@m17n.org>
909
910 * ftfont.c (get_adstyle_property): Fix previous change
911 (Bug#10233).
912
6e44397c
JB
9132011-12-07 Juanma Barranquero <lekktu@gmail.com>
914
915 * w32.c (init_environment): If no_site_lisp, remove site-lisp
916 dirs from the default value of EMACSLOADPATH (bug#10208).
917
7efa6272
GM
9182011-12-07 Glenn Morris <rgm@gnu.org>
919
920 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
921 installation and source directories as well. (Bug#10208)
922
f6fc4d87
CY
9232011-12-06 Chong Yidong <cyd@gnu.org>
924
925 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
926
2bf26180
GM
9272011-12-06 Glenn Morris <rgm@gnu.org>
928
929 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
930 as an error, not just -1. (Bug#10217)
931
3a6ad4f0
CY
9322011-12-05 Chong Yidong <cyd@gnu.org>
933
934 * keyboard.c (process_special_events): New function.
935 (swallow_events, Finput_pending_p): Use it (Bug#10195).
936
75a3b399
PE
9372011-12-05 Paul Eggert <eggert@cs.ucla.edu>
938
939 * coding.c (encode_designation_at_bol): Don't use uninitialized
940 local variable (Bug#9318).
941
c3c9e25e
KH
9422011-12-05 Kenichi Handa <handa@m17n.org>
943
944 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
945 return Qnil (Bug#8046, Bug#10193).
946
5eb05ea3
KH
9472011-12-05 Kenichi Handa <handa@m17n.org>
948
949 * coding.c (encode_designation_at_bol): New args charbuf_end and
950 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
951 (coding_set_source): Return how many bytes coding->source was
952 relocated.
953 (coding_set_destination): Return how many bytes
954 coding->destination was relocated.
955 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 956 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
957
9582011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
959
960 * coding.c (CODING_CHAR_CHARSET_P): New macro.
961 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
962 macro (Bug#9318).
963
9642011-12-05 Andreas Schwab <schwab@linux-m68k.org>
965
966 The following changes are to fix Bug#9318.
967
a79703f5 968 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
969 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
970 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 971 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 972
7dbda6df
JB
9732011-12-05 Juanma Barranquero <lekktu@gmail.com>
974
975 * lisp.h (process_quit_flag): Fix external declaration.
976
6d5eb5b0
SM
9772011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
978
979 Don't macro-inline non-performance-critical code.
980 * eval.c (process_quit_flag): New function.
981 * lisp.h (QUIT): Use it.
982
a0c3fad0
JD
9832011-12-04 Jan Djärv <jan.h.d@swipnet.se>
984
985 * nsfns.m (get_geometry_from_preferences): New function.
986 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
987
6c07aac2
AS
9882011-12-04 Andreas Schwab <schwab@linux-m68k.org>
989
990 * emacs.c (Qkill_emacs): Define.
991 (syms_of_emacs): Initialize it.
992 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
993 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
994 (quit_throw_to_read_char): Add parameter `from_signal'.
995 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
996 * lisp.h (QUIT): Call Fkill_emacs if requested.
997
c052ead4
JD
9982011-12-03 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * widget.c (update_wm_hints): Return if wmshell is null.
1001 (widget_update_wm_size_hints): New function.
1002
1003 * widget.h (widget_update_wm_size_hints): Declare.
1004
1005 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1006 widget_update_wm_size_hints (Bug#10104).
1007
9e49252b
EZ
10082011-12-03 Eli Zaretskii <eliz@gnu.org>
1009
1010 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1011 before a newline, prepare the bidi iterator for consuming the
1012 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1013 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1014
02b16839
JL
10152011-12-02 Juri Linkov <juri@jurta.org>
1016
1017 * search.c (Fword_search_regexp): New Lisp function created from
1018 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1019 (Fword_search_backward, Fword_search_forward)
1020 (Fword_search_backward_lax, Fword_search_forward_lax):
1021 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1022 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1023
0068070e
SM
10242011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1025
1026 * fileio.c (Finsert_file_contents): Move after-change-function call
1027 to before the "handled:" label, since all "goto handled" appear in
1028 cases where the *-change-functions have already been properly called
1029 (bug#10117).
1030
3360a3fc
AS
10312011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1032
1033 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1034 waiting for input. (Bug#10169)
1035
73d6c093
EZ
10362011-11-30 Eli Zaretskii <eliz@gnu.org>
1037
1038 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1039 verifies glyph row's hash code--we have just reallocated the
1040 glyphs, so their contents can be complete garbage. (Bug#10164)
1041
febe6bea
JB
10422011-11-30 Juanma Barranquero <lekktu@gmail.com>
1043
1044 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1045
801a4313
EZ
10462011-11-30 Eli Zaretskii <eliz@gnu.org>
1047
1048 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1049 attributes are tested _before_ calling verify_row_hash, to protect
1050 against GCC re-ordering of the tests. (Bug#10164)
1051
2b56b87e
JD
10522011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1053
1054 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1055
1056 * xterm.c (handle_one_xevent): Only set async_visible and friends
1057 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1058 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1059 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1060
dbf31225
PE
10612011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1062
1063 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1064 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1065 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1066 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1067 All uses changed to use GCPRO1 etc.
1068 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1069 Revert to old implementation (i.e., before 2011-03-11).
1070
1305621b
YM
10712011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1072
1073 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1074 of scroll runs so as to avoid assigning disabled bogus rows and
1075 unnecessary graphics copy operations.
1076
8c9afb46
EZ
10772011-11-27 Eli Zaretskii <eliz@gnu.org>
1078
1079 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1080 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1081 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1082 (malloc, free, realloc, calloc): Redirect to e_* only when
1083 compiling Emacs.
1084
1085 * lisp.h (GCTYPEBITS): Move before first use.
1086 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1087 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1088 this macro definition.
1089
1090 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1091 _MSC_VER.
1092
54e9e3bf
JD
10932011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1094
6d5eb5b0
SM
1095 * gtkutil.c (xg_create_frame_widgets):
1096 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1097 present with Gtk+ 2.0.
1098
83aca1cb
PE
10992011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1100
1101 * fileio.c (Finsert_file_contents): Undo previous change; see
1102 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1103
5b76caa4
PE
11042011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1105
1106 Rename locals to avoid shadowing.
1107 * fileio.c (Finsert_file_contents):
1108 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1109 * process.c (wait_reading_process_output):
1110 Rename inner 'proc' to 'p' to avoid shadowing.
1111 Indent for consistency with usual Emacs style.
1112
8c535114
EZ
11132011-11-25 Eli Zaretskii <eliz@gnu.org>
1114
1115 * xdisp.c (redisplay_window): If cursor row is not fully visible
1116 after recentering, and scroll-conservatively is set to a large
1117 number, scroll window by a few more lines to make the cursor fully
1118 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1119 (start_display): Don't move to the next line if the display should
1120 start at a newline that is part of a display vector or an overlay
1121 string. (Bug#10119)
8c535114 1122
fa4fdb5c
JL
11232011-11-24 Juri Linkov <juri@jurta.org>
1124
1125 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1126 after the `MagickPingImage' call. (Bug#10112)
1127
90ec88df
CY
11282011-11-23 Chong Yidong <cyd@gnu.org>
1129
1130 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1131
56e2e794
MR
11322011-11-23 Martin Rudalics <rudalics@gmx.at>
1133
1134 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1135 making another buffer current. (Bug#10114)
1136
b6e64c41
GM
11372011-11-23 Glenn Morris <rgm@gnu.org>
1138
1139 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1140
6b21de18
CY
11412011-11-23 Chong Yidong <cyd@gnu.org>
1142
1143 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1144 using it (Bug#5984).
1145
b12cd789
EZ
11462011-11-22 Eli Zaretskii <eliz@gnu.org>
1147
1148 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1149 and header-lines, as they don't have one computed for them.
1150 (Bug#10098)
1151
1152 * .gdbinit (prow): Make displayed values more self-explaining.
1153 Add row's hash code.
1154
261b6fd4
LMI
11552011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1156
1157 * process.c (wait_reading_process_output): Fix asynchrounous
1158 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1159 (wait_reading_process_output): Add comment and URL.
261b6fd4 1160
e7cfd277
JD
11612011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1162
1163 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1164
a9b9b7f5
CY
11652011-11-21 Chong Yidong <cyd@gnu.org>
1166
1167 * window.c (Fnext_window, Fprevious_window): Doc fix.
1168
b0d15b4f
SM
11692011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1170
1171 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1172
fe7a3057
JB
11732011-11-20 Juanma Barranquero <lekktu@gmail.com>
1174
1175 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1176
d2999b1a
MR
11772011-11-20 Martin Rudalics <rudalics@gmx.at>
1178
1179 * window.c (Fset_window_combination_limit): Rename argument
1180 STATUS to LIMIT.
1181 (Vwindow_combination_limit): Remove "status" from doc-string.
1182
d5ff9cd0
AS
11832011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1184
1185 * m/ibms390.h: Remove.
1186 * m/ibms390x.h: Don't include "ibms390.h".
1187
a5bb9bd3
SM
11882011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1189
1190 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1191 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1192
cd1181db
JB
11932011-11-20 Juanma Barranquero <lekktu@gmail.com>
1194
1195 * casetab.c (Fset_case_table):
1196 * charset.c (Fcharset_after): Fix typos.
1197
615a3b8d 11982011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1199
17e845af
PE
1200 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1201 Otherwise, valgrind does not work on some platforms.
1202 Problem reported by Andreas Schwab in
6a0bf43d
PE
1203 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1204 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1205 is set, removing the need for VIRT_ADDRESS_VARIES.
1206 (PURE_P): Use a more-efficient implementation that needs just one
1207 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1208 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1209 to 4 (xorl, subq, cmpq, setbe).
1210 * alloc.c (pure): Always extern now, since that's the
1211 VIRT_ADDR_VARIES behavior.
1212 (PURE_POINTER_P): Use a single comparison, not two, for
1213 consistency with the new puresize.h.
1214 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1215 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1216 Remove VIRT_ADDR_VARIES no longer needed.
1217
f8fe6f96
EZ
12182011-11-19 Eli Zaretskii <eliz@gnu.org>
1219
1220 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1221 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1222 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1223 behave as if the cursor position were at the window margin.
1224
1225 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1226 and the cursor position is out of bounds, behave as if the cursor
1227 position were at the window margin. (Bug#10075)
1228
df05a53c
CY
12292011-11-18 Chong Yidong <cyd@gnu.org>
1230
1231 * window.c (Fwindow_combination_limit): Make first argument
1232 non-optional, since it is meaningless for live windows like the
1233 selected window.
1234
2071918e
DA
12352011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1236
1237 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1238
b50a28de
SM
12392011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1240
1241 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1242 (graft_intervals_into_buffer): Simplify.
1243
015137db
EZ
12442011-11-18 Eli Zaretskii <eliz@gnu.org>
1245
1246 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1247 hash values of the two rows.
1248 (copy_row_except_pointers): Preserve the used[] arrays and the
1249 hash values of the two rows. (Bug#10035)
68c95424 1250 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1251
1252 * xdisp.c (row_hash): New function, body extracted from
1253 compute_line_metrics.
1254 (compute_line_metrics): Call row_hash, instead of computing the
1255 hash code inline.
1256
1257 * dispnew.c (verify_row_hash): Call row_hash for computing the
1258 hash code of a row, instead of duplicating code from xdisp.c.
1259
1260 * dispextern.h (row_hash): Add prototype.
1261
a2addb04
TH
12622011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1263
1264 * frame.c (delete_frame): Don't delete the terminal when the last
1265 X frame is closed if emacs is built with GTK toolkit.
1266
df85d315
JB
12672011-11-17 Juanma Barranquero <lekktu@gmail.com>
1268
1269 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1270
a0c2d0ae
MR
12712011-11-17 Martin Rudalics <rudalics@gmx.at>
1272
1273 * window.c (Vwindow_splits): Rename to
1274 Vwindow_combination_resize. Suggested by Juri Linkov.
1275 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1276 of Vwindow_splits.
1277
58179cce
JB
12782011-11-16 Juanma Barranquero <lekktu@gmail.com>
1279
7877f373
JB
1280 * nsfns.m (Fns_font_name):
1281 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1282
b6f67890
MR
12832011-11-16 Martin Rudalics <rudalics@gmx.at>
1284
1285 * window.h (window): Rename slot "nest" to "combination_limit".
1286 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1287 (Fset_window_nest): Rename to Fset_window_combination_limit.
1288 (Vwindow_nest): Rename to Vwindow_combination_limit.
1289 (recombine_windows, make_parent_window, make_window)
1290 (Fsplit_window_internal, saved_window)
1291 (Fset_window_configuration, save_window_save): Rename all
1292 occurrences of window_nest to window_combination_limit.
1293
c7015153
JB
12942011-11-15 Juanma Barranquero <lekktu@gmail.com>
1295
1296 * image.c (imagemagick_load_image): Fix typo.
1297
322ad6ec
EZ
12982011-11-14 Eli Zaretskii <eliz@gnu.org>
1299
1300 * xdisp.c (display_line): Move the call to
1301 highlight_trailing_whitespace before the call to
1302 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1303 faces of all the glyphs to compute ROW's hash value.
1304 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1305
f067b8ec
JB
13062011-11-14 Juanma Barranquero <lekktu@gmail.com>
1307
1308 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1309 just return (bug#10044).
1310
1e5b2111
EZ
13112011-11-12 Eli Zaretskii <eliz@gnu.org>
1312
7ef3cbd5
EZ
1313 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1314 with user-defined heap size. Bump the default size of the temacs
1315 heap to 27MB, to avoid memory warning when running temacs.
1316 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1317
1e5b2111
EZ
1318 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1319 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1320 (verify_row_hash) [XASSERTS]: New function.
1321 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1322 that the hash value of glyph rows is correct.
1e5b2111 1323
89d61221
MR
13242011-11-12 Martin Rudalics <rudalics@gmx.at>
1325
1326 * window.h (window): Remove splits slot.
1327 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1328 (Fdelete_other_windows_internal, make_parent_window)
1329 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1330 (Fset_window_configuration, save_window_save): Don't deal with
1331 split status of windows.
1332 (saved_window): Remove splits slot.
1333 (Vwindow_splits): Rewrite doc-string.
1334
97f18cc8
JD
13352011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1336
1337 * xfns.c (unwind_create_frame):
1338 * nsfns.m (unwind_create_frame):
1339 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1340 Vframe_list (Bug#9999).
1341
22a648b4
DA
13422011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1343
0b381c7e 1344 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1345
659afede
KH
13462011-11-11 Kenichi Handa <handa@m17n.org>
1347
1348 * callproc.c (Fcall_process): Set the member dst_multibyte of
1349 process_coding.
1350
9ac0394b
KH
13512011-11-11 Johan Bockgård <bojohan@gnu.org>
1352
1353 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1354 avoid a crash (bug#9496).
1355
2fbdc249
CY
13562011-11-09 Chong Yidong <cyd@gnu.org>
1357
1358 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1359 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1360
ac6b1f81
PE
13612011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1364
09db192c
PE
13652011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 Avoid some portability problems by eschewing 'extern inline' functions.
1368 The trivial performance wins aren't worth the portability hassles; see
1369 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1370 et seq.
1371 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1372 (window_box_width, window_box_left, window_box_left_offset)
1373 (window_box_right, window_box_right_offset): Undo previous change,
1374 by removing the "extern"s.
1375 * intervals.c (adjust_intervals_for_insertion)
1376 (adjust_intervals_for_deletion): Undo previous change,
1377 making these static again.
1378 (offset_intervals, temp_set_point_both, temp_set_point)
1379 (copy_intervals_to_string): No longer inline.
1380 * xdisp.c (window_text_bottom_y, window_box_width)
1381 (window_box_height, window_box_left_offset)
1382 (window_box_right_offset, window_box_left, window_box_right)
1383 (window_box): No longer inline.
1384
105216ed
CY
13852011-11-08 Chong Yidong <cyd@gnu.org>
1386
1387 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1388 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1389 Signal an error if not a live window.
105216ed
CY
1390 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1391 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1392
ae9e237f
JB
13932011-11-07 Juanma Barranquero <lekktu@gmail.com>
1394
1395 * lisp.h (syms_of_abbrev): Remove declaration.
1396 Reported by CHENG Gao <chenggao@royau.me>.
1397
c7aa8333
EZ
13982011-11-07 Eli Zaretskii <eliz@gnu.org>
1399
1400 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1401 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1402 of temacs in GUI mode.
1403
be7f5545
MR
14042011-11-07 Martin Rudalics <rudalics@gmx.at>
1405
1406 * window.h: Declare delete_all_child_windows instead of
1407 delete_all_subwindows.
1408 * window.c (Fwindow_nest, Fset_window_nest)
1409 (Fset_window_new_total, Fset_window_new_normal)
1410 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1411 (delete_all_subwindows): Rename to delete_all_child_windows.
1412 (Fdelete_other_windows_internal, Fset_window_configuration):
1413 Call delete_all_child_windows instead of delete_all_subwindows.
1414 * frame.c (delete_frame): Call delete_all_child_windows instead
1415 of delete_all_subwindows.
1416
ca78dc43
PE
14172011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1420 This is also needed for porting to any host where GC_MARK_STACK is
1421 not GC_MAKE_GCPROS_NOOPS.
1422 (which_symbols): Use it.
1423
a0241d01
KH
14242011-11-07 Kenichi Handa <handa@m17n.org>
1425
1426 * coding.c (coding_set_destination): Check coding->src_pos only
1427 when coding->src_object is a buffer (bug#9910).
1428
1429 * process.c (send_process): Set the member src_multibyte of coding
1430 to 0 (bug#9911) when sending a unibyte text.
1431
1432 * callproc.c (Fcall_process): Set the member src_multibyte of
1433 process_coding to 0 (bug#9912).
1434
a64bfdfa 14352011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1436
1437 * xmenu.c (cleanup_widget_value_tree): New function.
1438 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1439 calling free_menubar_widget_value_tree directly (Bug#9830).
1440
cb41b32a
PE
14412011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1442
1443 Fix some portability problems with 'inline'.
1444 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1445 (window_box_width, window_box_left, window_box_left_offset)
1446 (window_box_right, window_box_right_offset): Declare extern.
1447 Otherwise, these inline functions do not conform to C99 and
1448 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1449 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1450 * intervals.c (adjust_intervals_for_insertion)
1451 (adjust_intervals_for_deletion): Now extern, because otherwise the
1452 extern inline functions 'offset_intervals' couldn't refer to it.
1453 (static_offset_intervals): Remove.
1454 (offset_intervals): Rewrite using the old contents of
1455 static_offset_intervals. The old version didn't conform to C99
1456 because an extern inline function contained a reference to an
1457 identifier with static linkage.
1458
b7041366
AS
14592011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1460
1461 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1462 GC.
1463
88a37c4d
EZ
14642011-11-06 Eli Zaretskii <eliz@gnu.org>
1465
1466 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1467 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1468 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1469 return Qleft_to_right.
1470
49745b39
CY
14712011-11-06 Chong Yidong <cyd@gnu.org>
1472
1473 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1474 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1475 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1476 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1477 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1478 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1479 (Fwindow_vscroll): Doc fix.
1480 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1481 argument, since it makes no sense to pass a live window and for
1482 consistency with window-child.
1483
1f05cd82
CS
14842011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1485
1486 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1487 support MSVC.
1488
22610910
JR
14892011-11-05 Jason Rumney <jasonr@gnu.org>
1490
1491 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1492 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1493 fonts (Bug#6029).
1494 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1495 bitwise arithmetic preventing use of unicode-sip and non-truetype
1496 opentype fonts.
1497
a06776b2
EZ
14982011-11-05 Eli Zaretskii <eliz@gnu.org>
1499
3ad924ba
EZ
1500 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1501 "emacs"-only part.
1502
a06776b2
EZ
1503 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1504 initialization code to keep similarity to xfns.c after changes
1505 from 2011-11-05.
1506
c9e7db78
JD
15072011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1508
a97f8f3f
JD
1509 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1510 (unwind_create_frame): New function (Bug#9943).
1511 (Fx_create_frame): Restructure code to be more similar to the one in
1512 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1513 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1514 Move terminal->reference_count++ just before making the frame official
1515 (Bug#9943).
1516
1517 * nsterm.m (x_free_frame_resources): New function.
1518 (x_destroy_window): Move code to x_free_frame_resources.
1519
c9e7db78 1520 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1521 (Fx_create_frame, x_create_tip_frame):
1522 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1523 official. Move initialization of image_cache_refcount and
1524 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1525
a6fc3b5c
EZ
15262011-11-05 Eli Zaretskii <eliz@gnu.org>
1527
1528 Support MSVC build with newer versions of Visual Studio.
1529 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1530 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1531 nt/gmake.defs.
1532
1533 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1534 which are not supported by MSVC.
1535 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1536 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1537 bitfields.
1538 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1539 types in bitfields.
1540 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1541
1542 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1543
58179cce 15442011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1545
1546 Support MSVC build with newer versions of Visual Studio.
1547 * w32.c: Don't include w32api.h for MSVC.
1548 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1549
1550 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1551 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1552 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1553 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1554 e_* cousins.
1555 (alloca) [_MSC_VER]: Define to _alloca.
1556
1557 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1558
1559 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1560
a58c13ed
EZ
15612011-11-04 Eli Zaretskii <eliz@gnu.org>
1562
1563 * xdisp.c (note_mouse_highlight): If either of
1564 previous/next-single-property-change returns nil, treat that as
1565 the beginning or the end of the buffer. (Bug#9955)
1566
fe0b6370
JD
15672011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1568
a58c13ed 1569 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1570 label is not null (Bug#9951).
1571 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1572 may be NULL.
1573
89bd5ee1
EZ
15742011-11-04 Eli Zaretskii <eliz@gnu.org>
1575
1576 * window.c (Fwindow_body_size): Mention in the doc string that the
1577 return value is in frame's canonical units. (Bug#9949)
1578
84c3edb9
EZ
15792011-11-03 Eli Zaretskii <eliz@gnu.org>
1580
4e2fb5c7
EZ
1581 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1582
84c3edb9 1583 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1584 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1585 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1586
bc17a887
EZ
15872011-11-01 Eli Zaretskii <eliz@gnu.org>
1588
1589 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1590 Don't stop backward scan on the continuation glyph, even though
1591 its CHARPOS is positive.
6d5eb5b0
SM
1592 (mouse_face_from_buffer_pos, note_mouse_highlight):
1593 Rename cover_string to disp_string.
bc17a887 1594
4ee88440
MR
15952011-11-01 Martin Rudalics <rudalics@gmx.at>
1596
1597 * window.c (temp_output_buffer_show): Don't use
1598 Vtemp_buffer_show_specifiers.
1599 (Vtemp_buffer_show_specifiers): Remove unused variable.
1600
c2ff3c02
EZ
16012011-10-30 Eli Zaretskii <eliz@gnu.org>
1602
1603 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1604 past the beginning of the current glyph matrix.
1605
58179cce 16062011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1607
1608 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1609 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1610 HAVE_GTK3 (Bug#9869).
b77a6a7f 1611
3b574623
JD
1612 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1613 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1614
b77a6a7f
JD
1615 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1616
1617 * xterm.c: Declare x_handle_net_wm_state to return int.
1618 (handle_one_xevent): Check if we are iconified but don't have
1619 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1620 (get_current_wm_state): Return non-zero if not hidden,
1621 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1622 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1623 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1624 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1625
196e41e4
PE
16262011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1629 so that this new function doesn't get optimized away by a
1630 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1631
021f2e1a
AS
16322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1633
1634 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1635
8b058d44
EZ
16362011-10-29 Eli Zaretskii <eliz@gnu.org>
1637
1638 Fix the `xbytecode' command.
1639 * .gdbinit (xprintbytestr): New command.
b50a28de 1640 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1641 (xbytecode): Print the byte-code string as well.
1642
4452fb80
EZ
16432011-10-29 Kim Storm <storm@cua.dk>
1644
8b058d44
EZ
1645 * alloc.c (which_symbols): New function.
1646
21b72067
AS
16472011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1648
1649 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1650 line. (Bug#9903)
1651
83ed7b5c
GM
16522011-10-29 Glenn Morris <rgm@gnu.org>
1653
1654 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1655 Not clear what it was for, and it causes various bugs. (Bug#9839)
1656
5a7a728b
EZ
16572011-10-28 Eli Zaretskii <eliz@gnu.org>
1658
1659 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1660 possible random value that matches one of those tested as
1661 condition to clear the mouse face.
1662
d3d0842f
CY
16632011-10-28 Chong Yidong <cyd@gnu.org>
1664
1665 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1666
31b39d13
DN
16672011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1668
1669 * window.c (make_window): Initialize phys_cursor_on_p.
1670
9aba6043
SM
16712011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1672
1673 * lisp.h (struct Lisp_Symbol): Update comments.
1674
c20992f4
JB
16752011-10-28 Juanma Barranquero <lekktu@gmail.com>
1676
1677 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1678
db4f02f2
EZ
16792011-10-28 Eli Zaretskii <eliz@gnu.org>
1680
1681 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1682 <oslsachem@gmail.com> for helping to debug this.
1683
1684 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1685 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1686 (g_b_init_get_glyph_outline_w): New static variables.
1687 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1688 (GetGlyphOutlineW_Proc): New typedefs.
1689 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1690 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1691 New functions.
1692 (w32font_open_internal, compute_metrics):
1693 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1694 instead of calling the "wide" APIs directly.
1695
1696 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1697
1698 * w32.h (syms_of_w32font): Add prototype.
1699
87e68db4
JB
17002011-10-27 Juanma Barranquero <lekktu@gmail.com>
1701
1702 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1703 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1704 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1705 (Fmove_to_window_line): Doc fix.
1706
435c1d67
CY
17072011-10-27 Chong Yidong <cyd@gnu.org>
1708
1709 * process.c (make_process): Set gnutls_state to NULL.
1710
1711 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1712 non-NULL, regardless of GNUTLS_INITSTAGE.
1713 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1714 an error. Set process slots as soon as we allocate them.
1715
1716 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1717
9c6c6f49
CY
17182011-10-27 Chong Yidong <cyd@gnu.org>
1719
9aba6043
SM
1720 * gnutls.c (emacs_gnutls_deinit): New function.
1721 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1722 (Fgnutls_deinit, Fgnutls_boot): Use it.
1723
1724 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1725 (deactivate_process): Call emacs_gnutls_deinit.
1726
657d08d3
JB
17272011-10-27 Juanma Barranquero <lekktu@gmail.com>
1728
1729 * image.c (x_create_x_image_and_pixmap):
1730 * w32.c (sys_rename, w32_delayed_load):
1731 * w32font.c (fill_in_logfont):
1732 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1733
5430d399
JB
17342011-10-26 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * w32fns.c (w32_default_color_map): New function,
1737 extracted from Fw32_default_color_map.
a7ef684b 1738 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1739
fe0055fa
PE
17402011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1741
1742 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1743
e6346438
SM
17442011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1745
1746 * keyboard.c (test_undefined): New function (bug#9751).
1747 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1748
e112cc37
ET
17492011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1750
1751 * sysdep.c (init_sys_modes): Fix the check for the controlling
1752 terminal (Bug#6649).
1753
7b5d6677
EZ
17542011-10-20 Eli Zaretskii <eliz@gnu.org>
1755
1756 * dispextern.h (struct bidi_it): New member next_en_type.
1757
1758 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1759 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1760 current character, check also for next_en_type being WEAK_EN.
1761 (bidi_resolve_weak): Don't enter the expensive loop if the current
1762 position is before next_en_pos. Record the bidi type of the first
1763 non-ET, non-BN character we find, in addition to its position.
1764 (bidi_level_of_next_char): Invalidate next_en_type when
1765 next_en_pos is over-stepped.
1766
7da0b018
PE
17672011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1768
1769 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1770 * editfns.c: Rewrite current-time-zone so that it invokes
1771 the equivalent of (format-time-string "%Z") to get the time zone name.
1772 This fixes a bug when the time zone name contains characters that
1773 need converting from the system time locale to Emacs internal format.
1774 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1775 that patch fixed format-time-string to do the conversion, but
1776 I forgot to fix current-time-zone.
1777 (format_time_string): New function, containing most of
1778 what Fformat_time_string used to contain.
1779 (Fformat_time_string): Rewrite in terms of format_time_string.
1780 This doesn't change this function's behavior.
1781 (current-time-zone): Rewrite to use format_time_string.
1782 This fixes the bug reported by Michael Schierl in
1783 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1784 Jason Rumney's 2007-06-07 change worked around this bug, but
1785 didn't fix it.
1786 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1787
8547b010
EZ
17882011-10-19 Eli Zaretskii <eliz@gnu.org>
1789
1790 * xdisp.c (start_display): If the character at POS is displayed
1791 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1792 (try_window_reusing_current_matrix): If a line ends in a display
1793 vector or the next line starts in a display vector, continue
1794 redrawing the window even though the character position of
1795 start_row was reached.
8547b010
EZ
1796 (Bug#9771, part 2)
1797
4e948d15
CY
17982011-10-18 Chong Yidong <cyd@gnu.org>
1799
1800 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1801 with nobreak-char-display too.
1802
4787455f
EZ
18032011-10-18 Eli Zaretskii <eliz@gnu.org>
1804
1805 Fix part 3 of bug#9771.
1806 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1807 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1808 non-neutral characters if the current character is a paragraph
1809 separator (a.k.a. Newline). This avoids running the same
1810 expensive loop twice, once when we consume the preceding newline
1811 and the other time when the line actually needs to be displayed.
1812 Avoid the loop when we see neutrals on the base embedding level
1813 following a character whose directionality is the same as the
1814 paragraph's. This avoids running the expensive loop when a line
1815 ends in a long sequence of neutrals, like control characters.
1816 Add assertion against STRONG_AL type. Slightly rearrange code
1817 that determines the type of a neutral given the first non-neutral
1818 that follows it.
1819 (bidi_level_of_next_char): Set next_en_pos to zero when
1820 invalidating its info.
1821
2c91f553
EZ
18222011-10-17 Eli Zaretskii <eliz@gnu.org>
1823
1824 * xdisp.c (push_display_prop): Determine whether to record string
1825 or buffer position by IT->string, not by IT->method. Allow
1826 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1827 (move_it_vertically_backward): Don't look for character position
1828 immediately after the newline when in a continuation line.
1829 (Bug#9771, part 1)
2c91f553 1830
c7b08b0d
MR
18312011-10-15 Martin Rudalics <rudalics@gmx.at>
1832
1833 * window.c (coordinates_in_window): Rewrite and delabelize
1834 vertical border check. (Bug#5357) (Bug#9618)
1835
6b02f655
SM
18362011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1837
1838 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1839 errors in XSetWindowBorder (bug#9310).
1840
81d40c92
DA
18412011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1842
1843 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1844 avoid crash when xmalloc overrun checking is enabled.
1845
d4172c3b
EZ
18462011-10-13 Eli Zaretskii <eliz@gnu.org>
1847
1848 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1849 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1850 cursor motion with <left> and <right> arrow keys.
1851
1852 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1853 some callers set that themselves.
1854
b00eea75
EZ
18552011-10-12 Eli Zaretskii <eliz@gnu.org>
1856
1857 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1858 display string and the previous row comes from the same string and
1859 is empty. (Bug#9739) (Bug#9738)
1860
8fe012c4
SM
18612011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1862
1863 * doc.c (get_doc_string): Encode file name (bug#9735).
1864
0074aef2
EZ
18652011-10-12 Eli Zaretskii <eliz@gnu.org>
1866
79beb178
EZ
1867 * bidi.c (bidi_level_of_next_char):
1868 * xdisp.c (get_visually_first_element): Remove old incorrect
1869 comments regarding the Unicode Line Separator character.
1870
0074aef2
EZ
1871 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1872
6e4b3fbe
DA
18732011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1874
1875 * alloc.c (Fgc_status): Do not access beyond zombies array
1876 boundary if nzombies > MAX_ZOMBIES.
1877 * alloc.c (dump_zombies): Add missing format specifier.
1878
0324f3af
PE
18792011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1880
b5525cac
PE
1881 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1882 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1883
0324f3af
PE
1884 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1885 Some packages use them to denote characters with modifiers.
1886
e9b5f888
AS
18872011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1888
1889 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1890 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1891 matching a pp-number. Rename parameter var to var1.
1892
127827c0
SM
18932011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1894
1895 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1896
c8fd3bd0
GM
18972011-10-08 Glenn Morris <rgm@gnu.org>
1898
1899 * callint.c (Fcall_interactively): Give a more explicit error for the
1900 'c' case with a non-character input. (Bug#8479)
1901
352ec8ff
EZ
19022011-10-08 Eli Zaretskii <eliz@gnu.org>
1903
03669ccb
EZ
1904 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1905 lines.
7061c986
EZ
1906 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1907 lines that are hscrolled on the left.
03669ccb 1908
352ec8ff
EZ
1909 * dispnew.c (buffer_posn_from_coords): Account for a possible
1910 presence of header-line. (Bug#4426)
1911
a66cfb1c
SM
19122011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1913
6b02f655
SM
1914 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1915 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1916
7c5ee88e
PE
19172011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1920 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1921 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1922 this makes Emacs dump core during garbage collection on rare
1923 occasions. sizeof is obviously inferior to offsetof here, so
1924 stick with offsetof.
1925 (GC_POINTER_ALIGNMENT): New macro.
1926 (mark_memory): Omit 3rd (offset) arg; caller changed.
1927 Don't assume EMACS_INT alignment is the same as pointer alignment.
1928
df1bbe5b
SM
19292011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1930
1931 * keyboard.c (read_key_sequence_remapped): New var.
1932 (read_key_sequence): Compute remapping in the right buffer.
1933 (command_loop_1): Use read_key_sequence's remapping directly.
1934
51553db6
SM
19352011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1936
32c1fffd
SM
1937 * dired.c (file_name_completion): Don't expand file name.
1938 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1939 before checking file name handler.
1940
51553db6
SM
1941 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1942 they've been requested explicitly (bug#9591).
1943
b6bd1599 19442011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1945
1946 * keymap.c (Fsingle_key_description): Use make_specified_string
1947 instead of build_string to build string from push_key_description.
1948 (Bug#5193)
1949
f701dc2a
PE
19502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1951
4222c55d
PE
1952 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1953 This fixes a Y2038 bug on 64-bit hosts.
1954 * buffer.c (reset_buffer):
1955 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1956 (Fclear_buffer_auto_save_failure):
1957 Use 0, not -1, to represent an unset failure time, since time_t
1958 might not be signed.
1959
f701dc2a
PE
1960 Remove dependency on glibc malloc internals.
1961 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1962 Move back here from lisp.h, but with their new implementations.
1963 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1964 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1965 * charset.c (charset_table_init): New static var.
1966 (syms_of_charset): Use it instead of xmalloc. This removes a
1967 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1968 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1969 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1970 Move back to alloc.c.
1971 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1972 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1973
9ceebf39
JD
19742011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1975
1976 * nsterm.m (windowDidResize): Call x_set_window_size only when
1977 ns_in_resize is true. Otherwise set pixelwidth/height and
1978 call change_frame_size (Bug#9628).
1979
cb993c58
PE
19802011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1981
3930c88b
PE
1982 Port --enable-checking=all to Fedora 14 x86-64.
1983 * charset.c (syms_of_charset): Also account for glibc malloc's
1984 internal overhead when calculating the initial malloc maximum.
1985
cb993c58
PE
1986 Port --enable-checking=all to Fedora 14 x86.
1987 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1988 Move to lisp.h.
1989 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1990 (overrun_check_realloc, overrun_check_free):
1991 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1992 That way, xmalloc returns a properly-aligned pointer even if
1993 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1994 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1995 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1996 into account when calculating the initial malloc maximum.
1997 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1998 Move here from alloc.c, so that charset.c can use it too.
1999 Properly align; the old code wasn't right for common 32-bit hosts
2000 when configured with --enable-checking=all.
2001 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2002 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2003
31bed486
EZ
20042011-09-29 Eli Zaretskii <eliz@gnu.org>
2005
04c70788 2006 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2007 use EDOM.
2008
fbcaa2f3
EZ
20092011-09-28 Eli Zaretskii <eliz@gnu.org>
2010
2011 * xdisp.c (compute_display_string_end): If there's no display
2012 string at CHARPOS, return -1.
2013
2014 * bidi.c (bidi_fetch_char): When compute_display_string_end
2015 returns a negative value, treat the character as a normal
2016 character not covered by a display string. (Bug#9624)
2017
a239d4e9
JB
20182011-09-28 Juanma Barranquero <lekktu@gmail.com>
2019
2020 * lread.c (Fread_from_string): Fix typo in docstring.
2021
88652fd5
EZ
20222011-09-27 Eli Zaretskii <eliz@gnu.org>
2023
2024 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2025 newline, reseat the iterator instead of bidi-iterating there one
2026 character at a time. (Bug#9610)
32c1fffd
SM
2027 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2028 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2029
ed497dd4
AS
20302011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2031
2032 * lread.c (readevalloop): Use correct code for NBSP.
2033 (read1): Likewise. (Bug#9608)
2034
b2bf61aa
MA
20352011-09-25 Michael Albinus <michael.albinus@gmx.de>
2036
2037 * dbusbind.c (Fdbus_register_signal): When service is not
2038 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2039
32bbb17c
GM
20402011-09-25 Glenn Morris <rgm@gnu.org>
2041
2042 * buffer.c (truncate-lines): Doc fix.
2043
94e0933e
CY
20442011-09-24 Chong Yidong <cyd@stupidchicken.com>
2045
2046 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2047 (Fset_window_next_buffers): Doc fix.
2048
cddde921
GM
20492011-09-24 Glenn Morris <rgm@gnu.org>
2050
2051 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2052
1260aef1
PE
20532011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2054
25b4bfa0
PE
2055 Fix minor problems found by static checking.
2056 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2057 * indent.c (Fvertical_motion): Fix == vs = typo.
2058
e3cbd34b
EZ
20592011-09-24 Eli Zaretskii <eliz@gnu.org>
2060
a66cfb1c
SM
2061 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2062 Default value is now t. Doc fix.
6bf7006f 2063
e3cbd34b 2064 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2065 logic when moving up, not only when moving down. Fix the
e3cbd34b 2066 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2067 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2068
2069 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2070 CHARPOS is covered by a display string which includes newlines.
2071 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2072 is covered by a display string with embedded newlines.
2073
a3de0cbd
MA
20742011-09-24 Michael Albinus <michael.albinus@gmx.de>
2075
2076 * dbusbind.c (Fdbus_register_signal): Add match rule to
2077 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2078 (Fdbus_register_method, Vdbus_registered_objects_table):
2079 Fix docstring.
a3de0cbd 2080
b260039d
JM
20812011-09-24 Jim Meyering <meyering@redhat.com>
2082
32c1fffd 2083 do not ignore write error for any output size
b260039d
JM
2084 The previous change was incomplete.
2085 While it makes emacs --batch detect the vast majority of stdout
2086 write failures, errors were still ignored whenever the output size is
2087 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2088 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2089 && echo FAIL: ignored write error
2090 FAIL: ignored write error
2091 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2092 && echo FAIL: ignored write error
2093 FAIL: ignored write error
2094 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2095
8eca8a7c
AS
20962011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2097
2098 * emacs.c (Fkill_emacs): In noninteractive mode exit
2099 non-successfully if a write error occurred on stdout. (Bug#9574)
2100
3341db62
EZ
21012011-09-21 Eli Zaretskii <eliz@gnu.org>
2102
2103 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2104 the xassert test.
2105
2106 * dispextern.h (struct it): Update the comment documenting what
2107 can it->OBJECT be.
2108
8c203dbf
EZ
21092011-09-20 Eli Zaretskii <eliz@gnu.org>
2110
2111 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2112 a display string, extend search for cursor position to end of row.
2113 (find_row_edges): If the row ends in a newline from a display
2114 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2115 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2116 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2117 non-empty line. Fixes confusing cursor motion with arrow keys at
2118 the beginning of a line that starts with whitespace.
8c203dbf 2119
a4824228
LMI
21202011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2121
2122 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2123 (bug#9493).
2124
33ed493b
CY
21252011-09-18 Chong Yidong <cyd@stupidchicken.com>
2126
2127 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2128 boolean (Bug#9154).
2129
56cd55c8
EZ
21302011-09-18 Eli Zaretskii <eliz@gnu.org>
2131
2132 * xdisp.c (display_line): Record maximum and minimum buffer
2133 positions even if no glyphs were produced (e.g., by a zero-width
2134 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2135 buffer positions that will be removed from the glyph row because
2136 they don't fit.
c02dcedf
EZ
2137 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2138 column is beyond frame width: don't subtract 1 "pixel" when
2139 computing width of the stretch.
3e62b7e0
EZ
2140 (reseat_at_next_visible_line_start): Undo the change made on
2141 2011-09-17 that saved paragraph information and restored it after
2142 the call to `reseat'. (Bug#9545)
56cd55c8 2143
5ed99d36 21442011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2145
2146 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2147 and turn window cursor on if cleared (Bug#9415).
2148
5ed99d36 21492011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2150
2151 * search.c (boyer_moore): Take unibyte characters from pattern
2152 literally. (Bug#9458)
2153
9bade7b2
EZ
21542011-09-18 Eli Zaretskii <eliz@gnu.org>
2155
2156 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2157
e5e9d610
PE
21582011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2159
87e4427a
PE
2160 Fix minor problem found by static checking.
2161 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2162 initialized, to pacify gcc -Wuninitialized.
2163
e5e9d610
PE
2164 * fileio.c: Report proper errno when syscall falls.
2165 (Finsert_file_contents): Save and restore errno,
2166 so that report_file_error outputs the correct diagnostic.
2167 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2168
a1674f0b
EZ
21692011-09-18 Eli Zaretskii <eliz@gnu.org>
2170
2171 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2172
fbfb6dd4
EZ
21732011-09-17 Eli Zaretskii <eliz@gnu.org>
2174
2175 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2176 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2177
bb187662
EZ
21782011-09-17 Eli Zaretskii <eliz@gnu.org>
2179
1137e8b8 2180 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2181 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2182
2183 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2184 (bidi_find_paragraph_start): Search back for paragraph beginning
2185 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2186 (bidi_move_to_visually_next): Only trigger paragraph-related
2187 computations when the last character is a newline or at EOB, not
2188 just any NEUTRAL_B. (Bug#9470)
2189
bb187662
EZ
2190 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2191 truncated lines if point is covered by a display string. (Bug#9524)
2192
2e621251
PE
21932011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2196 (cons_to_x_long): New function.
2197 (lisp_data_to_selection_data): Use it. Correct the test for
2198 short-versus-long data; it was negated. Break out of vector
2199 loop, for efficiency, when a long datum is discovered.
2200
91a15bc6
SM
22012011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2202
2203 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2204
b41c3a35
EZ
22052011-09-16 Eli Zaretskii <eliz@gnu.org>
2206
2207 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2208 GCC PR/17406) by declaring this function with external scope.
2209
7812ba2d
PE
22102011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2211
2212 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2213 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2214
cf7edc2a
AS
22152011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2216
2217 * editfns.c (Fformat): Correctly handle text properties on "%%".
2218
bd01620e
EZ
22192011-09-15 Eli Zaretskii <eliz@gnu.org>
2220
2221 * xterm.c (x_draw_composite_glyph_string_foreground):
2222 * w32term.c (x_draw_composite_glyph_string_foreground):
2223 * term.c (encode_terminal_code):
2224 * composite.c (composition_update_it, get_composition_id):
2225 * xdisp.c (get_next_display_element)
2226 (fill_composite_glyph_string): Add comments about special meaning
2227 of TAB characters in a composition.
2228
a02719a3
PE
22292011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2232 This occurs when processing a multibyte format.
2233 Problem reported by Wolfgang Jenker.
a02719a3 2234
72589a3c
JB
22352011-09-15 Johan Bockgård <bojohan@gnu.org>
2236
2237 * xdisp.c (try_cursor_movement): Only check for exact match if
2238 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2239
1c14176c
PE
22402011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2241
2242 Remove unused external symbols.
2243 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2244 * xdisp.c (calc_pixel_width_or_height): Now static.
2245 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2246 * indent.c (check_display_width):
2247 * w32term.c: Fix comment to match code.
2248 * xterm.c, xterm.h (x_catching_errors): Remove.
2249
d2eea5b5
PE
22502011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2251
2252 * xselect.c: Use signed conversions more consistently (Bug#9498).
2253 (selection_data_to_lisp_data): Assume incoming selection data are
2254 signed integers, not unsigned. This is to be consistent with
2255 outgoing selection data, which was modified to use signed integers
2256 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2257 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2258 expects long, not unsigned long.
2259
46888499
EZ
22602011-09-14 Eli Zaretskii <eliz@gnu.org>
2261
2262 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2263 computation of loop end. Reported by Johan Bockgård
2264 <bojohan@gnu.org>.
2265
ef8ef9fb
CY
22662011-09-13 Chong Yidong <cyd@stupidchicken.com>
2267
2268 * frame.c (Fother_visible_frames_p): Function deleted.
2269
fa819fed
EZ
22702011-09-12 Eli Zaretskii <eliz@gnu.org>
2271
2272 * indent.c (compute_motion): Process display vector front to back
2273 rather than the other way around. (Bug#2496)
2274
2ba8e008
SM
22752011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2276
2277 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2278
20f53c69
CY
22792011-09-11 Chong Yidong <cyd@stupidchicken.com>
2280
2281 * minibuf.c (Fread_from_minibuffer): Doc fix.
2282
d562d7a4
EZ
22832011-09-11 Eli Zaretskii <eliz@gnu.org>
2284
2285 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2286 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2287
1c4d7f3d
LMI
22882011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2289
2290 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2291 value for non-existent files.
2292
b885bf36
EZ
22932011-09-11 Eli Zaretskii <eliz@gnu.org>
2294
2295 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2296 set its "size" to -1. This will set the modtime_size field of
2297 the corresponding buffer to -1, which is what
2298 verify-visited-file-modtime expects for files that do not exist.
2299 (Bug#9139)
2300
6612f0bf
PE
23012011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2304 here ...
2305 * lisp.h: ... from here. push_key_description is no longer
2306 defined in keyboard.c, so its declaration should not be in
2307 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2308 logically belongs with push_key_description.
2309
dfb3f755
PE
23102011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * buffer.h: Include <sys/types.h> instead of <time.h>.
2313 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2314 Problem reported by Herbert J. Skuhra.
2315
3134906c
LMI
23162011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2317
2318 * xml.c (parse_region): Make the parsing work for
2319 non-comment-starting XML files again (bug#9144).
2320
8d903f4e
AS
23212011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2322
2323 * image.c (gif_load): Fix calculation of bottom and right corner.
2324 (Bug#9468)
2325
80ad64f4
EZ
23262011-09-10 Eli Zaretskii <eliz@gnu.org>
2327
2328 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2329 redisplay in small windows.
2330
208a048d
EZ
23312011-09-09 Eli Zaretskii <eliz@gnu.org>
2332
2333 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2334
9b1c252e
MR
23352011-09-08 Martin Rudalics <rudalics@gmx.at>
2336
2337 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2338 Operate on live windows only.
2339
2949f33b
JB
23402011-09-08 Juanma Barranquero <lekktu@gmail.com>
2341
2342 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2343
e08dcafd
EZ
23442011-09-07 Eli Zaretskii <eliz@gnu.org>
2345
2346 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2347 only under bidi iteration.
2348
115b96bd
JD
23492011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2350
2351 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2352
c8199d0f
PE
23532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2354
2355 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2356 Without this fix, the command to link temacs failed due to an
2357 undefined symbol __builtin_isnan. This is because
2358 /usr/include/iso/math_c99.h #defines isnan(x) to
2359 __builtin_isnan(x), but the bundled gcc, which identifies itself
2360 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2361 a __builtin_isnan.
2362 * floatfns.c (isnan): #undef, and then #define to a clone of
2363 what's in data.c.
2364 (Fisnan): Always define, since it's always available now.
2365 (syms_of_floatfns): Always define isnan at the Lisp level.
2366
e39b275c 23672011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2368
2369 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2370
b2db44d9 23712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2372
f4af5137 2373 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2374 The previous code assumed that file offsets (off_t values) fit in
2375 EMACS_INT variables, which is not true on typical 32-bit hosts.
2376 The code messed up by falsely reporting buffer overflow in cases
2377 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2378 when "big" contains more than 2**29 bytes, even though this
2379 inserts just one byte and does not overflow the buffer.
2380 (Finsert_file_contents): Store file offsets as off_t
2381 values, not as EMACS_INT values. Check for overflow when
2382 converting between EMACS_INT and off_t. When checking for
2383 buffer overflow or for overlap, take the offsets into account.
2384 Don't use EMACS_INT for small values where int suffices.
2385 When checking for overlap, fix a typo: ZV was used where
2386 ZV_BYTE was intended.
2387 (Fwrite_region): Don't assume off_t fits into 'long'.
2388 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2389
ecfc0a49
MA
23902011-09-05 Michael Albinus <michael.albinus@gmx.de>
2391
2392 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2393
6511acf2 23942011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2395
0999621a 2396 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2397
2398 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2399 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2400 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2401 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2402 (modify_event_symbol): Do not assume that the length of
2403 name_alist_or_stem is safe to alloca and fits in int.
2404 (Fexecute_extended_command): Likewise for function name and binding.
2405 (Frecursion_depth): Wrap around reliably on integer overflow.
2406 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2407 since some callers pass EMACS_INT values.
2408 (Fsingle_key_description): Don't crash if symbol name contains more
2409 than MAX_ALLOCA bytes.
2410 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2411 (get_minibuffer): Arg is now EMACS_INT, not int.
2412 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2413 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2414 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2415
2be7d702
PE
2416 * dbusbind.c (signature_cat): New function.
2417 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2418 Do not overrun buffer; instead, report string overflow.
2419
9d1df220
PE
2420 * dispnew.c (add_window_display_history): Don't overrun buffer.
2421 Truncate instead; this is OK since it's just a log.
2422
33ef5c64
PE
2423 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2424 even if the time zone offset is outlandishly large.
2425 Don't mishandle offset == INT_MIN.
2426
66c6fdd5
PE
2427 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2428 when creating daemon; the previous buffer-overflow check was incorrect.
2429
d749b01b
PE
2430 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2431 which has the guts of the old verror function.
2432
b5cd1905
PE
2433 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2434 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2435
6e1a67fb
PE
2436 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2437 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2438 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2439 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2440 length of string rather than counting it via multiple sprintfs;
2441 that's simpler and more reliable.
c21721cc
PE
2442 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2443 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2444 sprintf, in case result does not fit in int.
2445
c57b67fc
PE
2446 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2447 (fontset_from_font): Print it.
2448
8a401434
PE
2449 * frame.c (tty_frame_count): Now printmax_t, not int.
2450 (make_terminal_frame, set_term_frame_name): Print it.
2451 (x_report_frame_params): In X, window IDs are unsigned long,
2452 not signed long, so print them as unsigned.
2453 (validate_x_resource_name): Check for implausibly long names,
2454 and don't assume name length fits in 'int'.
2455 (x_get_resource_string): Don't blindly alloca invocation name;
2456 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2457 not fit in int.
2458
6e1a67fb
PE
2459 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2460 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2461 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2462
0df02bf3
PE
2463 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2464 Use esprintf, not sprintf, in case result does not fit in int.
2465
48e30793
PE
2466 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2467 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2468 it as a large positive number.
2469 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2470 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2471
a66ff6d8
PE
2472 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2473 in case result does not fit in int.
2474
aca216ff
PE
2475 * print.c (float_to_string): Detect width overflow more reliably.
2476 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2477 buffer overrun. Don't assume list length fits in 'int'. Treat
2478 print length of 0 as 0, not as infinity; to be consistent with other
2479 uses of print length in this function. Don't overflow print length
2480 index. Don't assume hash table size fits in 'long', or that
2481 vectorlike size fits in 'unsigned long'.
2482
31c286f7
PE
2483 * process.c (make_process): Use printmax_t, not int, to format
2484 process-name gensyms.
2485
55e5faa1
PE
2486 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2487
80f2e268
PE
2488 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2489 to avoid potential buffer overrun.
2490
670741ab
PE
2491 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2492 if X resource line is longer than 512 bytes.
2493
b7163a50
PE
2494 * xfns.c (x_window): Make sprintf buffer a bit bigger
2495 to avoid potential buffer overrun.
2496
ae58ff1f
PE
2497 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2498
c43c8a6a
PE
2499 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2500
3f8236f4
PE
25012011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2502
53e9fe90 2503 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2504 Without these, Emacs silently mishandles large integers sometimes.
2505 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2506 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2507
6511acf2
PE
2508 * xdisp.c (try_window_id): Check Emacs fixnum range before
2509 converting to 'int'.
806add1d 2510
6511acf2 2511 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2512 Check that an Emacs fixnum is in range before assigning it to 'int'.
2513 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2514 values converted from Emacs fixnums.
2515 (Frecenter): Don't wrap around a line count if it is out of 'int'
2516 range; instead, treat it as an extreme value.
2517 (Fset_window_configuration, compare_window_configurations):
2518 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2519
6511acf2
PE
2520 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2521 that can exceed INT_MAX. Check that EMACS_INT value is in range
2522 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2523 (match_limit): Don't assume that a fixnum can fit in 'int'.
2524
6511acf2 2525 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2526 exceed INT_MAX.
2527
6511acf2 2528 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2529 (Fvertical_motion): Don't wrap around LINES values that don't fit
2530 in 'int'. Instead, treat them as extreme values. This is good
2531 enough for windows, which can't have more than INT_MAX lines anyway.
2532
fcb901a7
LMI
25332011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2534
0f2f6b6d
LMI
2535 * Require libxml/parser.h to avoid compilation warning.
2536
fcb901a7
LMI
2537 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2538
2539 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2540 since this reportedly can destroy thread storage.
2541
6e20a0d4
CY
25422011-08-30 Chong Yidong <cyd@stupidchicken.com>
2543
2544 * syntax.c (find_defun_start): Update all cache variables if
2545 exiting early (Bug#9401).
2546
148ae00e
EZ
25472011-08-30 Eli Zaretskii <eliz@gnu.org>
2548
f6cfbd8f
EZ
2549 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2550
148ae00e
EZ
2551 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2552 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2553 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2554
2555 * term.c (tty_append_glyph): New function.
2556 (produce_stretch_glyph): Static function and its prototype deleted.
2557
a66cfb1c
SM
2558 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2559 Add prototypes.
148ae00e 2560
c4a07a4c
PE
25612011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2562
2563 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2564 when checking :margin (Bug#9390).
2565 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2566 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2567 so that the name doesn't mislead. All uses changed.
2568
6bc8cd65
JB
25692011-08-28 Johan Bockgård <bojohan@gnu.org>
2570
2571 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2572 set_tty_hooks.
2573
dca4927e
EZ
25742011-08-27 Eli Zaretskii <eliz@gnu.org>
2575
2576 * xdisp.c (move_it_to): Don't bail out early when reaching
2577 position beyond to_charpos, if we are scanning backwards.
2578 (move_it_vertically_backward): When DY == 0, make sure we get to
2579 the first character in the line after the newline.
2580
f2cad773
PE
25812011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2582
2583 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2584 (ccl_driver): Do not generate an out-of-range pointer.
2585 (Fccl_execute_on_string): Remove unnecessary check for
2586 integer overflow, noted by Stefan Monnier in
2587 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2588 Remove a FIXME that didn't need fixing.
2589 Simplify the newly-introduced buffer reallocation code.
2590
0cae2cdb
JB
25912011-08-27 Juanma Barranquero <lekktu@gmail.com>
2592
2593 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2594
5fc295a4 25952011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2596
70c60eb2 2597 Integer and memory overflow issues (Bug#9196).
726e0ab1 2598
d31850da
PE
2599 * doc.c (get_doc_string): Rework so that
2600 get_doc_string_buffer_size is the actual buffer size, rather than
2601 being 1 less than the actual buffer size; this makes xpalloc more
2602 convenient.
2603
a69fbedb
PE
2604 * image.c (x_allocate_bitmap_record, cache_image):
2605 * xselect.c (Fx_register_dnd_atom):
2606 Simplify previous changes by using xpalloc.
2607
fe5c5d37
PE
2608 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2609 since either will do and ptrdiff_t is convenient with xpalloc.
2610
0065d054
PE
2611 * charset.c (charset_table_size)
2612 (struct charset_sort_data.priority): Now ptrdiff_t.
2613 (charset_compare): Don't overflow if priorities differ greatly.
2614 (Fsort_charsets): Don't assume list length fits in int.
2615 Check for size-calculation overflow when allocating sort data.
2616 (syms_of_charset): Allocate an initial charset table that is
2617 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2618
2619 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2620
2621 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2622 The actual value is always <= INT_MAX, and leaving it unsigned made
2623 overflow checking harder.
2624
2625 * dispextern.h (struct glyph_matrix.rows_allocated)
2626 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2627 with xpalloc. The values are still always <= INT_MAX.
2628
2629 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2630
2631 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2632 (SAFE_NALLOCA): New macro.
2633
2634 * region-cache.c (struct boundary.pos, find_cache_boundary)
2635 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2636 (set_cache_region, invalidate_region_cache)
2637 (revalidate_region_cache, know_region_cache, region_cache_forward)
2638 (region_cache_backward, pp_cache):
2639 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2640 so that ptrdiff_t * can be passed to xpalloc.
2641 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2642 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2643 (pp_cache): Don't assume cache_len fits in int.
2644 * region-cache.h: Adjust extern decls to match.
2645
2646 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2647 EMACS_INT, since either will do, for xpalloc.
2648
2649 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2650 (xnmalloc, xnrealloc, xpalloc): New functions.
2651
726e0ab1
PE
2652 * bidi.c (bidi_shelve_header_size): New constant.
2653 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2654 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2655
51f30bc5 2656 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2657 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2658 (overlay_strings):
2659 Don't update size of array until after memory allocation succeeds,
2660 because xmalloc/xrealloc may not return.
0065d054
PE
2661 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2662 now that we have proper integer overflow checking.
2663 (record_overlay_string, overlay_strings): Catch overflows when
2664 calculating size of overlay_str_buf.
726e0ab1 2665
0065d054
PE
2666 * callproc.c (Fcall_process): Check for size overflow when
2667 calculating size of args2.
2668 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2669 Normally we prefer signed values, but sticking with ptrdiff_t would
2670 require adding more-complicated checks.
726e0ab1
PE
2671
2672 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2673 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2674 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2675 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2676
2677 * character.c (Fstring): Check for size-calculation overflow.
2678
2679 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2680 unnecessary integer overflow. Check for size overflow.
2681 (encode_coding_object): Don't update size until xmalloc succeeds.
2682
2683 * composite.c (get_composition_id): Check for overflow in glyph
2684 length calculations.
2685
2686 Integer and memory overflow fixes for display code.
2687 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2688 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2689 (scrolling_window): Check for overflow in size calculations.
2690 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2691 Don't assume glyph table len fits in int.
2692 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2693 (row_table_size): Now ptrdiff_t, not int.
2694 (scrolling_window): Avoid overflow in size calculations.
2695 Don't update size until allocation succeeds.
2696 * fns.c (concat): Check for overflow in size calculations.
2697 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2698 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2699 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2700
2701 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2702 (get_doc_string): Check for size calculation overflow.
2703 Don't update size until allocation succeeds.
2704 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2705 EMACS_INT, where ptrdiff_t will do.
2706 (Fsubstitute_command_keys): Check for string overflow.
2707
2708 * editfns.c (set_time_zone_rule): Don't assume environment length
2709 fits in int.
2710 (message_length): Now ptrdiff_t, not int.
2711 (Fmessage_box): Don't update size until allocation succeeds.
2712 Don't assume message length fits in int.
2713 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2714
0065d054
PE
2715 * emacs.c (main): Do not reallocate argv, since there is a null at
2716 the end that can be overwritten, and this way there's no need to
2717 worry about size-calculation overflow.
2718 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2719
2720 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2721 alloc succeeds.
2722 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2723
2724 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2725 (x_set_scroll_bar_width, x_figure_window_size):
2726 Check for integer overflow.
2727 (x_set_alpha): Do not assume XINT fits in int.
2728
2729 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2730 This is for the members text_lines, text_cols, total_lines, total_cols,
2731 where the system imposes an 'int' limit.
2732
2733 * fringe.c (Fdefine_fringe_bitmap):
2734 Don't update size until alloc works.
2735
2736 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2737 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2738
2739 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2740 Check for size-calculation overflow.
2741 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2742 do, as we prefer signed integers.
2743 (id_to_widget.max_size, id_to_widget.used)
2744 (xg_store_widget_in_map, xg_remove_widget_from_map)
2745 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2746 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2747 Use and return ptrdiff_t, not int.
2748 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2749 * gtkutil.h: Change prototypes to match the above.
2750
2751 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2752 are duplicate now that they've been promoted to lisp.h.
2753 (x_allocate_bitmap_record, x_alloc_image_color)
2754 (make_image_cache, cache_image, xpm_load):
2755 Don't update size until alloc is done.
2756 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2757 (x_detect_edges):
3256efce 2758 Check for size calculation overflow.
726e0ab1
PE
2759 (ct_colors_allocated_max): New constant.
2760 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2761 overflow.
3256efce 2762
726e0ab1
PE
2763 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2764 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2765 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2766 Use ptrdiff_t, not int, to count maps.
2767 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2768 calculations. Don't update size until allocation succeeds.
2769 Redo calculations to avoid overflow.
726e0ab1
PE
2770 * keyboard.h: Change prototypes to match the above.
2771
2772 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2773 to count maps.
2774 (current_minor_maps): Check for size calculation overflow.
2775 * keymap.h: Change prototypes to match the above.
2776
2777 * lread.c (read1, init_obarray): Don't update size until alloc done.
2778
2779 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2780 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2781
726e0ab1
PE
2782 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2783 Now ptrdiff_t, not int.
2784 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2785 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2786
2787 * process.c (Fnetwork_interface_list): Check for overflow
2788 in size calculation.
2789
2790 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2791
2792 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2793 overflow. Don't bother calling xmalloc when xrealloc will do.
2794
2795 * search.c (Freplace_match): Check for size calculation overflow.
2796 (Fset_match_data): Don't assume list lengths fit in 'int'.
2797
2798 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2799 for command line length. Do not attempt to address one before the
2800 beginning of an array, as that's not portable.
2801
2802 * term.c (max_frame_lines): Remove; unused.
2803 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2804 not int.
2805 (encode_terminal_code, calculate_costs): Check for size
2806 calculation overflow.
2807 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2808 table lengths and related sizes. Don't update size until alloc
2809 done. Redo calculations to avoid overflow.
2810 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2811
2812 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2813 subtracting pointers.
2814 (gobble_line): Check for overflow more carefully. Don't update size
2815 until alloc done.
2816
2817 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2818 Don't update size until alloc done.
2819 Redo size calculations to avoid overflow.
2820 Check for size calculation overflow.
0065d054 2821 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2822
2823 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2824 Use ptrdiff_t, not int, for sizes.
2825 (store_mode_line_noprop_char): Don't update size until alloc done.
2826
0065d054
PE
2827 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2828 Use ptrdiff_t, not int, for sizes.
2829 (Finternal_make_lisp_face, cache_face):
2830 Check for size calculation overflow.
2831 (cache_face): Treat size calculation overflows as if they were
2832 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2833
2834 * xfns.c (x_encode_text, x_set_name_internal)
2835 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2836 sizes, since they can exceed INT_MAX in size. Check for size
2837 calculation overflow.
2838
0065d054
PE
2839 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2840 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2841 Don't update size until alloc done.
2842
0065d054 2843 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2844 as sprintf is limited to int lengths.
1d526e2f 2845
252c5ee1
PE
2846 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2847 (X_LONG_MIN): New macros.
864d7ce7
PE
2848 Use them to make the following changes clearer.
2849 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2850 This change doesn't affect the value now, but it may help remind
2851 future maintainers not to raise the value too much later.
2852 (SELECTION_QUANTUM): Remove, replacing with ...
2853 (selection_quantum): ... new function, which avoids overflow.
2854 All uses changed.
2855 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2856 assumption that selection length fits in 'int'.
2857 (x_reply_selection_request, x_handle_selection_request)
2858 (x_get_window_property, receive_incremental_selection)
2859 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2860 (lisp_data_to_selection_data, clean_local_selection_data):
2861 Use ptrdiff_t, not int, to record length of selection.
2862 (x_reply_selection_request, x_get_window_property)
2863 (receive_incremental_selection, x_property_data_to_lisp):
2864 Redo calculations to avoid overflow.
2865 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2866 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2867 something.
2868 (x_get_window_property, receive_incremental_selection)
2869 (lisp_data_to_selection_data, x_property_data_to_lisp):
2870 Check for size-calculation overflow.
2871 (x_get_window_property, receive_incremental_selection)
2872 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2873 Don't store size until memory allocation succeeds.
2874 (x_get_window_property): Plug memory leak on memory exhaustion.
2875 Don't double-block input; malloc is safe here. Don't assume 2**34
2876 - 4 fits in unsigned long. Add an xassert to check
2877 XGetWindowProperty overflow. Be more careful about overflow
2878 calculations, and distinguish size from memory overflow better.
2879 (receive_incremental_selection): When tracing, don't assume
2880 unsigned int is less than INT_MAX.
2881 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2882 harmful) conversions of unsigned short to int.
2883 (lisp_data_to_selection_data): Don't assume that integers
2884 in the range -65535 through -1 fit in an X unsigned short.
2885 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2886 result parameters unless successful. Rely on cons_to_unsigned
2887 to report problems with elements; the old code wasn't right anyway.
2888 (x_check_property_data): Check for int overflow; we cannot use
2889 a wider type due to X limits.
2890 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2891
726e0ab1 2892 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2893
0065d054
PE
2894 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2895 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2896 (x_color_cells): Don't store size until memory allocation succeeds.
2897 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2898 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2899 (x_term_init): Don't assume length fits in int (sprintf is limited
2900 to int size).
bc18e09d 2901
ebfa62c0
PE
2902 Use ptrdiff_t for composition IDs.
2903 * character.c (lisp_string_width):
2904 * composite.c (composition_table_size, n_compositions)
2905 (get_composition_id, composition_gstring_from_id):
2906 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2907 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2908 * window.c (Frecenter):
2909 Use ptrdiff_t, not int, for composition IDs.
2910 * composite.c (get_composition_id): Check for integer overflow.
2911 * composite.h: Adjust prototypes to match the above changes.
2912
d3411f89
PE
2913 Use ptrdiff_t for hash table indexes.
2914 * category.c (hash_get_category_set):
2915 * ccl.c (ccl_driver):
2916 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2917 * coding.c (coding_system_charset_list, detect_coding_system):
2918 * coding.h (struct coding_system.id):
2919 * composite.c (get_composition_id, gstring_lookup_cache):
2920 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2921 * image.c (xpm_get_color_table_h):
2922 * lisp.h (hash_lookup, hash_put):
2923 * minibuf.c (Ftest_completion):
2924 Use ptrdiff_t for hash table indexes, not int (which is too
2925 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2926 32-bit --with-wide-int hosts).
2927
e097a6fa
PE
2928 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2929 Add a FIXME comment about memory leaks.
2930 (syms_of_charset): Don't assume xmalloc returns.
2931
5637687f
PE
2932 Don't assume that stated character widths fit in int.
2933 * character.c (Fchar_width, c_string_width, lisp_string_width):
2934 * character.h (CHAR_WIDTH):
2935 * indent.c (MULTIBYTE_BYTES_WIDTH):
2936 Use sanitize_char_width to avoid undefined and/or bad behavior
2937 with outlandish widths.
a66cfb1c 2938 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2939 now that we have two such functions. All uses changed.
2940 (sanitize_char_width): New inline function.
2941
a2271ba2
PE
2942 Don't assume that tab-width fits in int.
2943 * character.h (sanitize_width): New inline function.
2944 (SANE_TAB_WIDTH): New macro.
2945 (ASCII_CHAR_WIDTH): Use it.
2946 * indent.c (sane_tab_width): Remove. All uses replaced by
2947 SANE_TAB_WIDTH (current_buffer).
2948 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2949
18c52557
PE
2950 * fileio.c: Integer overflow issues with file modes.
2951 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2952
caeeedc1
PE
2953 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2954 Remove unreachable code.
2955 (read_hex, load_charset_map_from_file): Check for integer overflow.
2956
6df6ae42 2957 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2958 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2959 (x_send_scroll_bar_event): Likewise. Check that the size does not
2960 exceed limits imposed by XClientMessageEvent, as well as the usual
2961 ptrdiff_t and size_t limits.
2962
b13995db
PE
2963 * keyboard.c: Overflow, signedness and related fixes.
2964 (make_lispy_movement): Use same integer type in forward decl
2965 that is used in the definition.
2966 (read_key_sequence, keyremap_step):
2967 Change bufsize argument back to int, undoing my 2011-03-30 change.
2968 We prefer signed types, and int is wide enough here.
2969 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2970 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2971 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2972 length, not size_t. Use ptrdiff_t for index, not int.
2973 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2974 possibility of integer overflow.
2975
13464394
PE
2976 Overflow, signedness and related fixes for images.
2977
2978 * dispextern.h (struct it.stack[0].u.image.image_id)
2979 (struct_it.image_id, struct image.id, struct image_cache.size)
2980 (struct image_cache.used, struct image_cache.ref_count):
2981 * gtkutil.c (update_frame_tool_bar):
2982 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2983 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2984 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2985 * nsmenu.m (update_frame_tool_bar):
2986 * xdisp.c (calc_pixel_width_or_height):
2987 * xfns.c (image_cache_refcount):
2988 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2989 on typical 64-bit hosts.
2990
2991 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2992 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2993 Omit unnecessary casts to int.
2994 (parse_image_spec): Check that integers fall into 'int' range
2995 when the callers expect that.
2996 (image_ascent): Redo ascent calculation to avoid int overflow.
2997 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2998 (lookup_image): Remove unnecessary tests.
2999 (xbm_image_p): Locals are now of int, not EMACS_INT,
3000 since parse_image_check makes sure they fit into int.
3001 (png_load, gif_load, svg_load_image):
3002 Prefer int to unsigned where either will do.
3003 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3004 old tiff_error_handler and tiff_warning_handler.
3005 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3006 stack buffer overflows. It uses only the features of vsnprintf
3007 that are common to both POSIX and native Microsoft.
3008 (tiff_error_handler, tiff_warning_handler): Use it.
3009 (tiff_load, gif_load, imagemagick_load_image):
3010 Don't assume :index value fits in 'int'.
3011 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3012 (imagemagick_load_image): Check that crop parameters fit into
3013 the integer types that MagickCropImage accepts. Don't assume
3014 Vimagemagick_render_type has a nonnegative value. Don't assume
3015 size_t fits in 'long'.
3016 (gs_load): Use printmax_t to print the widest integers possible.
3017 Check for integer overflow when computing image height and width.
3018
c11821d4
EZ
30192011-08-26 Eli Zaretskii <eliz@gnu.org>
3020
3021 * xdisp.c (redisplay_window): Don't force window start if point
3022 will be invisible in the resulting window. (Bug#9324)
3023
0c95fcf7
EZ
30242011-08-25 Eli Zaretskii <eliz@gnu.org>
3025
3026 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3027 the display spec is of the form `(space ...)'.
3028 (handle_display_spec): Return the value returned by
3029 handle_single_display_spec, not just 1 or zero.
3030 (handle_single_display_spec): If the display spec is of the form
3031 `(space ...)', and specifies display in the text area, return 2
3032 rather than 1.
fee65a97 3033 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3034 accurately, and prefer exact match for point under bidi.
3035 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3036
3037 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3038 into disp_prop; all users changed.
3039
3040 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3041 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3042 for the text covered by the display property.
3043
e4ed06f1
CY
30442011-08-25 Chong Yidong <cyd@stupidchicken.com>
3045
3046 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3047 Change return value to nil.
3048 (Frecord_buffer): Delete unused function.
3049
f67cdd7f
EZ
30502011-08-24 Eli Zaretskii <eliz@gnu.org>
3051
5980d4c6
EZ
3052 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3053 buffers, return left-to-right.
8610fe8b
EZ
3054 (set_cursor_from_row): Consider candidate row a win if its glyph
3055 represents a newline and point is on that newline. Fixes cursor
3056 positioning on the newline at EOL of R2L text within L2R
3057 paragraph, and vice versa.
3058 (try_cursor_movement): Check continued rows, in addition to
3059 continuation rows. Fixes unwarranted scroll when point enters a
3060 continued line of R2L text within an L2R paragraph, or vice versa.
3061 (cursor_row_p): Consider the case of point being equal to
3062 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3063 from the end of a short line to the beginning of a continued line
3064 of R2L text within L2R paragraph.
3065 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3066 composed characters.
5980d4c6 3067
f67cdd7f
EZ
3068 * bidi.c (bidi_check_type): Use xassert.
3069 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3070 members.
3071
bca633fb
EZ
30722011-08-23 Eli Zaretskii <eliz@gnu.org>
3073
3074 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3075 a character.
3076
4a5885a7
CY
30772011-08-23 Chong Yidong <cyd@stupidchicken.com>
3078
3079 * nsfont.m (ns_otf_to_script): Fix typo.
3080
0902a04e
KH
30812011-08-22 Kenichi Handa <handa@m17n.org>
3082
3083 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3084 extra slot even if the purpose is char-code-property-table.
3085
1a2e6670
EZ
30862011-08-23 Eli Zaretskii <eliz@gnu.org>
3087
8ddde651
EZ
3088 * xdisp.c (redisplay_window): When computing centering_position,
3089 account for the height of the header line. (Bug#8874)
3090
425cc014
EZ
3091 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3092 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3093 candidate is selected by the mouse, and that candidate has a
3094 composed character under the mouse.
3095
1a2e6670
EZ
3096 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3097 coordinates reported by pos-visible-in-window-p for a composed
3098 character in column zero.
3099
8b76d6f8
SM
31002011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3101
3102 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3103
dac347dd
EZ
31042011-08-22 Eli Zaretskii <eliz@gnu.org>
3105
3106 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3107 consider it a hit if to_charpos is anywhere in the range of the
3108 composed buffer positions.
3109
e013fb34
CY
31102011-08-22 Chong Yidong <cyd@stupidchicken.com>
3111
3112 * image.c (gif_load): Don't assume that each subimage has the same
3113 dimensions as the base image. Handle disposal method that is
3114 "undefined" by the gif spec (Bug#9335).
3115
bd1ba3e8
CY
31162011-08-20 Chong Yidong <cyd@stupidchicken.com>
3117
3118 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3119 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3120
54a1215b
EZ
31212011-08-19 Eli Zaretskii <eliz@gnu.org>
3122
823564e5
EZ
3123 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3124 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3125 from an Org mode buffer to a Speedbar frame.
3126
54a1215b
EZ
3127 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3128 a composition, take its buffer position from IT->cmp_it.charpos.
3129 Fixes cursor positioning at the beginning of a line that begins
3130 with a composed character.
3131
9778ebcc
EZ
31322011-08-18 Eli Zaretskii <eliz@gnu.org>
3133
0be6ee06
EZ
3134 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3135 character bidirectional type, use STRONG_L instead. Fixes crashes
3136 in a buffer produced by `describe-categories'.
3137
9778ebcc
EZ
3138 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3139 members before the level stack, so they would be saved and
3140 restored when copying iterator state. Fixes incorrect reordering
3141 around TABs covered by display properties.
3142
156bffbe
AS
31432011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3144
6b02f655 3145 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3146
72ad093b
CY
31472011-08-17 Chong Yidong <cyd@stupidchicken.com>
3148
3149 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3150 (internal_condition_case_2, internal_condition_case_n):
3151 Remove unnecessary aborts (Bug#9081).
72ad093b 3152
35774242
EZ
31532011-08-17 Eli Zaretskii <eliz@gnu.org>
3154
3155 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3156 has no `load' handler, try opening the file locally. (Bug#9311)
3157
db76dd85
KB
31582011-08-16 Ken Brown <kbrown@cornell.edu>
3159
3160 * gmalloc.c: Expand comment.
3161
b215eee5
EZ
31622011-08-16 Eli Zaretskii <eliz@gnu.org>
3163
3164 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3165 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3166
a4579d33
KB
31672011-08-16 Ken Brown <kbrown@cornell.edu>
3168
3169 Fix memory allocation problems in Cygwin build (Bug#9273).
3170
3171 * unexcw.c ( __malloc_initialized): Declare external variable.
3172 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3173
8b76d6f8
SM
3174 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3175 New variables.
a4579d33
KB
3176 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3177 dumped emacs.
3178 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3179 in the static heap.
3180 [CYGWIN] (special_realloc): New function.
3181 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3182 requests to realloc storage in the static heap.
3183
3ebec551
PE
31842011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3185
3186 * bidi.c (bidi_initialize): Remove unused local.
3187
9fd8be00
EZ
31882011-08-15 Eli Zaretskii <eliz@gnu.org>
3189
6b02f655
SM
3190 * bidimirror.h:
3191 * biditype.h: Remove file.
3192 * makefile.w32-in ($(BLD)/bidi.$(O)):
3193 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3194
3195 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3196
3197 * chartab.c: Improve commentary for the uniprop_table API.
3198
32413314
EZ
3199 * bidi.c (bidi_paragraph_init): Support zero value of
3200 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3201 (bidi_initialize): Use uniprop_table instead of including
3202 biditype.h and bidimirror.h.
32413314 3203
9fd8be00
EZ
3204 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3205 coordinates of the iterator when restoring from ppos_it.
3206 (Bug#9296)
3207
5cf2b69b
KH
32082011-08-14 Kenichi Handa <handa@m17n.org>
3209
3210 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3211 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3212
daf17d00
EZ
32132011-08-14 Eli Zaretskii <eliz@gnu.org>
3214
3215 * xdisp.c (move_it_in_display_line_to): Don't invoke
3216 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3217 ppos_it. Fixes vertical cursor motion when line beginning is
3218 covered by an image. (Bug#9296)
3219
08e3161a
JD
32202011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3221
3222 * nsterm.h (ns_run_ascript): Declare.
3223 (NSAPP_DATA2_RUNASSCRIPT): Define.
3224
3225 * nsfns.m (as_script, as_result, as_status): New static variables.
3226 (ns_run_ascript): New function.
5e617bc2 3227 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3228 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3229 the event loop. Get status from as_status (Bug#7276).
3230
3231 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3232 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3233 the event loop (Bug#7276).
3234
a3720aa2
AS
32352011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3236
3237 * gnutls.c (QCgnutls_bootprop_priority)
3238 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3239 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3240 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3241 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3242 (QCgnutls_bootprop_verify_hostname_error)
3243 (QCgnutls_bootprop_callbacks_verify): Rename from
3244 Qgnutls_bootprop_..., all uses changed.
3245
3246 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3247 uses changed.
3248
0a0d27fb
PE
32492011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3250
19d5c50c
PE
3251 * xfaces.c (Qframe_set_background_mode): Now static.
3252 * dispextern.h (Qframe_set_background_mode): Remove decl.
3253
0a0d27fb
PE
3254 * process.c (Fnetwork_interface_info): Declare local only if needed.
3255
377538cb
JD
32562011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3257
3258 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3259 (Fnetwork_interface_list): Allocate in increments of bytes instead
3260 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3261 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3262 sockaddr.
3263 (struct ifflag_def): notrailers is smart on OSX.
3264 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3265 Get hardware address with getifaddrs if available.
3266
08fff70c
EZ
32672011-08-12 Eli Zaretskii <eliz@gnu.org>
3268
3269 * xdisp.c (iterate_out_of_display_property): xassert that
3270 IT->position is set to within IT->object's boundaries. Break from
3271 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3272 when IT->position is set up wrongly due to some bug.
3273 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3274 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3275 entry. Force push_it to save on the stack the current
3276 buffer/string position, to be restored by pop_it. Fix flags in
3277 the iterator structure wrt the object coming from a display
3278 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3279 properties. (Bug#9284)
3280
7be1c708 32812011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3282
7be1c708
CY
3283 * fontset.c (fontset_get_font_group): Add proper type checks.
3284 (Bug#9172)
aac0c6e3 3285
7be1c708 32862011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3287
7be1c708
CY
3288 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3289 and LC_VERSION_MIN_MACOSX.
3290 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3291 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3292
97bb72a6
EZ
32932011-08-08 Eli Zaretskii <eliz@gnu.org>
3294
3295 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3296 no-display-properties-and-no-overlays under bidi display.
3297 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3298 properties and overlays.
97bb72a6 3299
d5617611
CY
33002011-08-08 Chong Yidong <cyd@stupidchicken.com>
3301
37e11a63
CY
3302 * editfns.c (Fset_time_zone_rule): Document relationship with the
3303 setenv function.
3304
d5617611
CY
3305 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3306 the font entity extracted from the cache (Bug#8109).
3307
58872834
CY
33082011-08-07 Chong Yidong <cyd@stupidchicken.com>
3309
3310 * composite.c (autocmp_chars): Don't reset point. That is done by
3311 restore_point_unwind (Bug#5984).
3312
75bfc667
JL
33132011-08-07 Juri Linkov <juri@jurta.org>
3314
3315 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3316 to show the arg `TIME' instead of `TIMEVAL'.
3317
d1410150
EZ
33182011-08-06 Eli Zaretskii <eliz@gnu.org>
3319
3320 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3321 display property strides EOL and includes a newline, as in
3322 longlines-mode. (Bug#9254)
75b771e4
EZ
3323 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3324 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3325
3326 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3327 is non-zero, even if the data buffer is NULL. Fixes a crash in
3328 vertical-motion with longlines-mode. (Bug#9254)
3329
35928349
EZ
33302011-08-05 Eli Zaretskii <eliz@gnu.org>
3331
ec7cc85b
EZ
3332 * bidi.c <bidi_cache_total_alloc>: Now static.
3333 (bidi_initialize): Initialize bidi_cache_total_alloc.
3334
8b76d6f8 3335 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3336 cache. (Bug#9221)
3337
3338 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3339 amount allocated this far in `bidi_cache_total_alloc'.
3340 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3341 non-zero, only free the data buffer without restoring the cache
3342 contents. All callers changed.
3343
3344 * dispextern.h (bidi_unshelve_cache): Update prototype.
3345
3346 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3347 (move_it_in_display_line, move_it_to)
3348 (move_it_vertically_backward, move_it_by_lines): Replace the call
3349 to xfree to an equivalent call to bidi_unshelve_cache.
3350 (move_it_in_display_line_to): Fix logic of returning
412b6358 3351 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3352
e2e2423b
EZ
33532011-08-05 Eli Zaretskii <eliz@gnu.org>
3354
3355 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3356 came from a string character with a `cursor' property. (Bug#9229)
3357
ae9e757a
JD
33582011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3359
3360 * Makefile.in (LIB_PTHREAD): New variable.
3361 (LIBES): Add LIB_PTHREAD (Bug#9216).
3362
3363 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3364 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3365
213bd7f2
AS
33662011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3367
6b02f655 3368 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3369
99aaf75f
JD
33702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3371
3372 * xterm.c (x_find_topmost_parent): New function.
3373 (x_set_frame_alpha): Find topmost parent window with
3374 x_find_topmost_parent and set the property there also (bug#9181).
3375 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3376
c74e9d86
PE
33772011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 * callproc.c (Fcall_process): Avoid vfork clobbering
3380 the local vars buffer, coding_systems, current_dir.
3381
640c8776
SM
33822011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3383
3384 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3385
f26d0e4c
PE
33862011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3387
8a10d76c
PE
3388 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3389 so that it is not optimized away.
3390
f26d0e4c
PE
3391 * xdisp.c (compute_display_string_pos): Remove unused local.
3392
55439c61
EZ
33932011-08-02 Eli Zaretskii <eliz@gnu.org>
3394
3395 Fix slow cursor motion and scrolling in large buffers with
3396 selective display, like Org Mode buffers. (Bug#9218)
3397
3398 * dispextern.h (struct bidi_it): New member disp_prop_p.
3399
3400 * xdisp.c: Remove one-slot cache of display string positions.
3401 (compute_display_string_pos): Accept an additional argument
5e617bc2 3402 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3403 for a display string or property. If found, set DISP_PROP_P
3404 non-zero.
3405
3406 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3407 DISP_PROP_P, and pass it to compute_display_string_pos.
3408 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3409 non-zero. All callers of bidi_fetch_char changed.
3410
fb33fa43
SM
34112011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3412
3413 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3414
b099e063
DM
34152010-12-03 Don March <don@ohspite.net>
3416
3417 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3418 last character M-[char] is translated to ESC [char] (bug#7541).
3419
5cc7f7af
KH
34202011-08-02 Kenichi Handa <handa@m17n.org>
3421
d0fffa3f 3422 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3423
3424 * chartab.c (uniprop_table): Make it non-static.
3425
525d5e6e
EZ
34262011-08-01 Eli Zaretskii <eliz@gnu.org>
3427
3428 * xdisp.c (forward_to_next_line_start): Accept additional argument
3429 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3430 on the newline.
3431 (reseat_at_next_visible_line_start): Use the bidi iterator state
3432 returned by forward_to_next_line_start to restore the state of
3433 it->bidi_it after backing up to previous newline. (Bug#9212)
3434
31011111
AS
34352011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3436
3437 * regex.c (re_comp): Protoize.
3438 (re_exec): Fix return type.
3439 (regexec): Fix type of `ret'. (Bug#9203)
3440
476371c4
PE
34412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3442
e5d76069
PE
3443 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3444 This is needed if max-image-size is a floating-point number.
3445
9a79b20c
AS
34462011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3447
3448 * print.c (print_object): Print empty symbol as ##.
3449
3450 * lread.c (read1): Read ## as empty symbol.
3451
d8c2fa78
AA
34522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3453
3454 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3455 setting frame foreground color (Bug#9175).
3456 (x_set_background_color): Likewise.
3457
ffe57a7a
AA
3458 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3459 contents (Bug#9176).
3460 (EmacsTooltip -init): Remove bezels and add shadows to
3461 tooltip windows.
3462
bf3492a5
AA
3463 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3464 or scroll bar (Bug#8470).
3465
d55e9c53
AA
3466 * nsfont.m (nsfont_open): Remove assignment to voffset and
3467 unnecessary vars hshink, expand, hd, full_height, min_height.
3468 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3469
3470 * nsterm.h (nsfont_info): Remove voffset field.
3471
d8c2fa78 34722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3473
3474 Implement strike-through and overline on NextStep (Bug#8863).
3475
3476 * nsfont.m (nsfont_open): Use underline position provided by font,
3477 instead of hard-coded value of 2.
3478 (nsfont_draw): Call ns_draw_text_decoration instead.
3479
3480 * nsterm.h: Add declaration for ns_draw_text_decoration.
3481
3482 * nsterm.m (ns_draw_text_decoration): New function for drawing
3483 underline, overline, and strike-through.
3484 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3485 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3486 accommodate underlining, etc.
4843aac3 3487
4cc60b9b
EZ
34882011-07-28 Eli Zaretskii <eliz@gnu.org>
3489
bc7ece87
EZ
3490 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3491 default.
4cc60b9b 3492
476371c4
PE
34932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3494
66606eea
PE
3495 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3496 Without this fix, if a signal arrives just after memory fills up,
3497 'malloc' might be invoked reentrantly.
3498
476371c4
PE
3499 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3500 In other words, assume that every image size is allowed, on non-X
3501 hosts. This assumption is probably wrong, but it lets Emacs compile.
3502
f3fcc40d
AS
35032011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3504
3505 * regex.c (re_iswctype): Convert return values to boolean.
3506
350c992f
EZ
35072011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3508
3509 * xdisp.c (compute_display_string_pos): Don't use cached display
3510 string position if the buffer had its restriction changed.
3511 (Bug#9184)
3512
5266b4bb
PE
35132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3516
2573a837 35172011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3518
41f55ccd 3519 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3520
39e378da
PE
3521 * bidi.c: Integer size and overflow fixes.
3522 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3523 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3524 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3525 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3526 (bidi_find_other_level_edge):
3527 Use ptrdiff_t instead of EMACS_INT where either will do.
3528 This works better on 32-bit hosts configured --with-wide-int.
3529 (bidi_cache_ensure_space): Check for size-calculation overflow.
3530 Use % rather than repeated addition, for better worst-case speed.
3531 Don't set bidi_cache_size until after xrealloc returns, because it
3532 might not return.
3533 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3534 (bidi_cache_ensure_space): Also check that the bidi cache size
3535 does not exceed that of the largest Lisp string or buffer. See Eli
3536 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3537
5e927815
PE
3538 * alloc.c (__malloc_size_t): Remove.
3539 All uses replaced by size_t. See Andreas Schwab's note
3540 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3541
ca4aa935
PE
3542 * image.c: Improve checking for integer overflow.
3543 (check_image_size): Assume that f is nonnull, since
3544 it is always nonnull in practice. This is one less thing to
3545 worry about when checking for integer overflow later.
3546 (x_check_image_size): New function, which checks for integer
3547 overflow issues inside X.
3548 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3549 This removes the need for a memory_full check.
3550 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3551 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3552 (xbm_read_bitmap_data): Change locals back to 'int', since
3553 their values must fit in 'int'.
3554 (xpm_load_image, png_load, tiff_load):
3555 Invoke x_create_x_image_and_pixmap earlier,
3556 to avoid much needless work if the image is too large.
3557 (tiff_load): Treat overly large images as if
3558 x_create_x_image_and_pixmap failed, not as malloc failures.
3559 (gs_load): Use x_check_image_size.
3560
5f8f9cc2
PE
3561 * gtkutil.c: Omit integer casts.
3562 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3563 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3564
5adf60bc
PE
3565 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3566
c8907a93
PE
3567 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3568 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3569 would wrongly return t on a 64-bit host.
3570
e3c25c68
PE
3571 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3572 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3573 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3574 and therefore cause GCC to emit a bogus diagnostic in some cases.
3575
3f791afe
PE
3576 * image.c: Integer signedness and overflow and related fixes.
3577 This is not an exhaustive set of fixes, but it's time to
3578 record what I've got.
3579 (lookup_pixel_color, check_image_size): Remove redundant decls.
3580 (check_image_size): Don't assume that arbitrary EMACS_INT values
3581 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3582 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3583 (tiff_load, imagemagick_load_image):
3584 Check for overflow in size calculations.
3585 (x_create_x_image_and_pixmap): Remove unnecessary test for
3586 xmalloc returning NULL; that can't happen.
3587 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3588 (xpm_color_bucket): Use better integer hashing function.
3589 (xpm_cache_color): Don't possibly over-allocate memory.
3590 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3591 (gif_memory_source):
3592 Use ptrdiff_t, not int or size_t, to record sizes.
3593 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3594 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3595 either works, as we prefer signed integers.
3596 (tiff_read_from_memory, tiff_write_from_memory):
3597 Return tsize_t, not size_t, since that's what the TIFF API wants.
3598 (tiff_read_from_memory): Don't fail simply because the read would
3599 go past EOF; instead, return a short read.
3600 (tiff_load): Omit no-longer-needed casts.
3601 (Fimagemagick_types): Don't assume size fits into 'int'.
3602
3cc5a532
PE
3603 Improve hashing quality when configured --with-wide-int.
3604 * fns.c (hash_string): New function, taken from sxhash_string.
3605 Do not discard information about ASCII character case; this
3606 discarding is no longer needed.
3607 (sxhash-string): Use it. Change sig to match it. Caller changed.
3608 * lisp.h: Declare it.
3609 * lread.c (hash_string): Remove, since we now use fns.c's version.
3610 The fns.c version returns a wider integer if --with-wide-int is
3611 specified, so this should help the quality of the hashing a bit.
3612
b312a492
PE
3613 * emacs.c: Integer overflow minor fix.
3614 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3615 Define only if GNU_LINUX.
3616 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3617
dfd153ae
PE
3618 * dispnew.c: Integer signedness and overflow fixes.
3619 Remove unnecessary forward decls, that were a maintenance hassle.
3620 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3621 All uses changed.
3622 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3623 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3624 (prepare_desired_row, line_draw_cost):
3625 Use int, not unsigned, where either works.
3626 (save_current_matrix, restore_current_matrix):
3627 Use ptrdiff_t, not size_t, where either works.
3628 (init_display): Check for overflow more accurately, and without
3629 relying on undefined behavior.
3630
a81d11a3
PE
3631 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3632 Remove, replacing with the new symbols in lisp.h. All uses changed.
3633 * fileio.c (make_temp_name):
3634 * filelock.c (lock_file_1, lock_file):
3635 * xdisp.c (message_dolog):
3636 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3637 Use pMd etc. instead.
3638 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3639 replacing the pWIDE etc. symbols removed from editfns.c.
3640
3300e6fd
PE
3641 * keyboard.h (num_input_events): Now uintmax_t.
3642 This is (very slightly) less likely to mess up due to wraparound.
3643 All uses changed.
3644
fd05c7e9
PE
3645 * buffer.c: Integer signedness fixes.
3646 (alloc_buffer_text, enlarge_buffer_text):
3647 Use ptrdiff_t rather than size_t when either will do, as we prefer
3648 signed integers.
3649
903fe15d
PE
3650 * alloc.c: Integer signedness and overflow fixes.
3651 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3652 (__malloc_size_t): Default to size_t, not to int.
3653 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3654 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3655 Prefer ptrdiff_t to size_t when either would do, as we prefer
3656 signed integers.
3657 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3658 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3659 Now const. Initialize with values that are in range even if char
3660 is signed.
3661 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3662 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3663 These functions do the right thing with sizes > 2**32.
3664 (check_depth): Now ptrdiff_t, not int.
3665 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3666 Adjust to new way of storing sizes. Check for size overflow bugs
3667 in rest of code.
3668 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3669 slightly wrong anyway, as it missed one instance of
3670 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3671 (refill_memory_reserve): Omit needless cast to size_t.
3672 (mark_object_loop_halt): Mark as externally visible.
3673
ac82cc6a
PE
3674 * xselect.c: Integer signedness and overflow fixes.
3675 (Fx_register_dnd_atom, x_handle_dnd_message):
3676 Use ptrdiff_t, not size_t, since we prefer signed.
3677 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3678 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3679 x_dnd_atoms_size and x_dnd_atoms_length.
3680
c2d1e36d
PE
3681 * doprnt.c: Prefer signed to unsigned when either works.
3682 * eval.c (verror):
3683 * doprnt.c (doprnt):
3684 * lisp.h (doprnt):
3685 * xdisp.c (vmessage):
3686 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3687 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3688 prefer signed arithmetic to avoid comparison confusion.
3689 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3690 but is a bit tricky.
3691
0e926e56
PE
3692 Assume freestanding C89 headers, string.h, stdlib.h.
3693 * data.c, doprnt.c, floatfns.c, print.c:
3694 Include float.h unconditionally.
3695 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3696 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3697 * regex.c: Likewise for stddef.h, string.h.
3698 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3699 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3700 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3701 (STDC_HEADERS): Remove obsolete defines.
3702 * sysdep.c: Include limits.h unconditionally.
3703
9cfdb3ec
PE
3704 Assume support for memcmp, memcpy, memmove, memset.
3705 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3706 * regex.c (memcmp, memcpy):
3707 Remove; we assume C89 now.
3708
3709 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3710 (__malloc_safe_bcopy): Remove; no longer needed.
3711
cf950e6b 3712 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3713 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3714 well either way, and we prefer signed to unsigned.
3715
dbf38e02
LMI
37162011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3717
3718 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3719 closes the connection while we're reading (bug#9182).
3720
d6f0886c 37212011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3722
d6f0886c
JD
3723 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3724 are specified (Bug#9168).
24e0f6b1 3725
2eb1f9e6
PE
37262011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3727
3728 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3729 Found by GCC static checking and --with-wide-int on a 32-bit host.
3730
22381272 37312011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3732
3733 * xdisp.c (compute_display_string_pos): Fix logic of caching
3734 previous display string position. Initialize cached_prev_pos to
3735 -1. Fixes slow-down at the beginning of a buffer.
3736
f25e39b4
EZ
37372011-07-24 Eli Zaretskii <eliz@gnu.org>
3738
3739 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3740 for attrs[LFACE_FONTSET_INDEX].
3741
04c4b52e
PE
37422011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3743
3744 * xml.c (parse_region): Remove unused local
3745 that was recently introduced.
3746
c1734fbd
EZ
37472011-07-23 Eli Zaretskii <eliz@gnu.org>
3748
be18c5a5
EZ
3749 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3750 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3751
c1734fbd
EZ
3752 * xdisp.c (move_it_in_display_line_to): Record the best matching
3753 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3754 exit if none of the characters scanned was an exact match.
3755 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3756 when exact match is impossible due to invisible text, and the
3757 lines are truncated.
3758
a258d627
JD
37592011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3760
3761 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3762 for OSX >= 10.7.
3763
b6d5a689
EZ
37642011-07-22 Eli Zaretskii <eliz@gnu.org>
3765
0f74f785
EZ
3766 Fix a significant slow-down of cursor motion with C-n, C-p,
3767 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3768 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3769 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3770 (next_element_from_buffer): Call compute_stop_pos_backwards to
3771 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3772 base_level_stop.
3773 (reseat): Don't look for prev_stop, as that could mean a very long
3774 run.
3775 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3776 <cached_disp_overlay_modiff>: Cache for last found display string
3777 position.
551918c1 3778 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3779 about the same buffer in the same area of character positions, and
3780 the buffer wasn't changed since the time the display string
3781 position was cached.
551918c1 3782
b2d0c91a
EZ
37832011-07-22 Eli Zaretskii <eliz@gnu.org>
3784
3785 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3786 is an integer, which is important for empty lines. (Bug#9149)
3787
043604ee
CY
37882011-07-22 Chong Yidong <cyd@stupidchicken.com>
3789
3790 * frame.c (Fmodify_frame_parameters): In tty case, update the
3791 default face if necessary (Bug#4238).
3792
da4adb04
CY
37932011-07-21 Chong Yidong <cyd@stupidchicken.com>
3794
3795 * editfns.c (Fstring_to_char): No need to explain what a character
3796 is in the docstring (Bug#6576).
3797
9abd0532
LMI
37982011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3799
3800 * xml.c (parse_region): Make sure we always return a tree.
3801
36881d16
HK
38022011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3803
3804 * xml.c (parse_region): If a document contains only comments,
3805 return that, too.
3806
1e98674d
LMI
38072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3808
3809 * xml.c (make_dom): Return comments, too.
3810
590bd467
PE
38112011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3812
3813 Port to OpenBSD.
3814 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3815 and the surrounding thread.
3816 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3817 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3818 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3819 timer goes off.
3820 * s/openbsd.h (BROKEN_SIGIO): Define.
3821 * unexelf.c (unexec) [__OpenBSD__]:
3822 Don't update the .mdebug section of the Alpha COFF symbol table.
3823
f41628b2
LMI
38242011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3825
3826 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3827 (bug#8460).
3828
b59b67c5
PE
38292011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3830
15e3a074
PE
3831 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3832 This fixes some race conditions on the permissions of any newly
3833 created file.
3834
41bed37d
PE
3835 * alloc.c (valid_pointer_p): Use pipe, not open.
3836 This fixes some permissions issues when debugging.
3837
b59b67c5
PE
3838 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3839 If fchown fails to set both uid and gid, try to set just gid,
3840 as that is sometimes allowed. Adjust the file's mode to eliminate
3841 setuid or setgid bits that are inappropriate if fchown fails.
3842
925a6be7
SM
38432011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3844
3845 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3846 to compare Lisp_Objects.
3847 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3848 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3849 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3850
52968808
AS
38512011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3852
0a6a104b
AS
3853 * lread.c (read_integer): Unread even EOF character.
3854 (read1): Likewise. Properly record start position of symbol.
3855
52968808
AS
3856 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3857 symbol character follows.
3858
9e381cdd
PE
38592011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3860
3861 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3862 This works around a problem with the previous change to Fcopy_file.
3863 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3864 and without this change, GCC might complain about discarding
3865 fchown's return value.
3866
b5641435
JB
38672011-07-16 Juanma Barranquero <lekktu@gmail.com>
3868
3869 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3870
a8031457
PE
38712011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3874
dd889327
LMI
38752011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3876
750c33f7
LMI
3877 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3878 it's used from the C level.
3879
dd889327
LMI
3880 * process.c: Use the same condition for POLL_FOR_INPUT in both
3881 keyboard.c and process.c (bug#1858).
3882
87e86684
LM
38832011-07-09 Lawrence Mitchell <wence@gmx.li>
3884
3885 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3886 (Fgnutls_boot): Use it.
3887
64348f40
AS
38882011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3889
3890 * doc.c (Fsubstitute_command_keys): Revert last change.
3891
1d698799
LMI
38922011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3893
f863868c
LMI
3894 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3895 quotes the next character, and doesn't affect other longer
3896 sequences (bug#8935).
3897
1d698799
LMI
3898 * lread.c (syms_of_lread): Clarify that is isn't only
3899 `eval-buffer' and `eval-defun' that's affected by
3900 `lexical-binding' (bug#8460).
3901
aa4b6df6
EZ
39022011-07-15 Eli Zaretskii <eliz@gnu.org>
3903
3904 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3905 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3906
5d856da6
PE
39072011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3908
ad6042bb
PE
3909 Fix minor problems found by static checking.
3910 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3911 (elsz): Now a signed constant, not a size_t var. We prefer signed
3912 types to unsigned, to avoid integer comparison confusion. Without
3913 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3914 "cannot optimize loop, the loop counter may overflow", a symptom
3915 of the confusion.
f00bbb22 3916 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3917 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3918
6468f31c
LMI
39192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3920
49080b10
LMI
3921 * search.c (Fre_search_backward): Mention `case-fold-search' in
3922 all the re_search_* functions (bug#8138).
3923
6468f31c
LMI
3924 * keyboard.c (Fopen_dribble_file): Document when the file is
3925 closed (bug#8056).
3926
c965adc5
EZ
39272011-07-14 Eli Zaretskii <eliz@gnu.org>
3928
df9733bf
EZ
3929 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3930 bidi_cache_idx.
3931
0bb23927
EZ
3932 Support bidi reordering of display and overlay strings.
3933 * xdisp.c (compute_display_string_pos)
3934 (compute_display_string_end): Accept additional argument STRING.
3935 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3936 (reseat_to_string): Initialize bidi_it->string.s and
3937 bidi_it->string.schars.
3938 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3939 NULL (avoids a crash in bidi_paragraph_init).
3940 Initialize itb.string.lstring.
0bb23927
EZ
3941 (init_iterator): Call bidi_init_it only of a valid
3942 buffer position was specified. Initialize paragraph_embedding to
3943 L2R.
3944 (reseat_to_string): Initialize the bidi iterator.
3945 (display_string): If we need to ignore text properties of
3946 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3947 original value of -1 will not work with bidi.)
3948 (compute_display_string_pos): First arg is now struct
3949 `text_pos *'; all callers changed. Support display properties on
3950 Lisp strings.
3951 (compute_display_string_end): Support display properties on Lisp
3952 strings.
3953 (init_iterator, reseat_1, reseat_to_string): Initialize the
3954 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3955 when iterating on a string not from display properties).
640c8776
SM
3956 (compute_display_string_pos, compute_display_string_end):
3957 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3958 arrow keys.
3959 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3960 base_level_stop; instead, set base_level_stop to BEGV.
3961 Fixes crashes in vertical-motion.
0bb23927
EZ
3962 (next_element_from_buffer): Improve commentary for when
3963 the iterator is before prev_stop.
3964 (init_iterator): Initialize bidi_p from the default value of
3965 bidi-display-reordering, not from buffer-local value. Use the
3966 buffer-local value only if initializing for buffer iteration.
3967 (handle_invisible_prop): Support invisible properties on strings
3968 that are being bidi-reordered.
3969 (set_iterator_to_next): Support bidi reordering of C strings and
3970 Lisp strings.
3971 (next_element_from_string): Support bidi reordering of Lisp
3972 strings.
3973 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3974 (display_string): Support display of R2L glyph rows.
3975 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3976 (init_iterator): Don't initialize it->bidi_p for strings
3977 here.
3978 (reseat_to_string): Initialize it->bidi_p for strings here.
3979 (next_element_from_string, next_element_from_c_string)
3980 (next_element_from_buffer): Add xassert's for correspondence
3981 between IT's object being iterated and it->bidi_it.string
3982 structure.
3983 (face_before_or_after_it_pos): Support bidi iteration.
3984 (next_element_from_c_string): Handle the case of the first string
3985 character that is not the first one in the visual order.
3986 (get_visually_first_element): New function, refactored from common
3987 parts of next_element_from_buffer, next_element_from_string, and
3988 next_element_from_c_string.
3989 (tool_bar_lines_needed, redisplay_tool_bar)
3990 (display_menu_bar): Force left-to-right direction. Add a FIXME
3991 comment for making that be controlled by a user option.
3992 (push_it, pop_it): Save and restore the state of the
3993 bidi iterator. Save and restore the bidi_p flag.
3994 (pop_it): Iterate out of display property for string iteration as
3995 well.
3996 (iterate_out_of_display_property): Support iteration over strings.
3997 (handle_single_display_spec): Set up it->bidi_it for iteration
3998 over a display string, and call bidi_init_it.
3999 (handle_single_display_spec, next_overlay_string)
4000 (get_overlay_strings_1, push_display_prop): Set up the bidi
4001 iterator for displaying display or overlay strings.
4002 (forward_to_next_line_start): Don't use the shortcut if
4003 bidi-iterating.
4004 (back_to_previous_visible_line_start): If handle_display_prop
4005 pushed the iterator stack, restore the internal state of the bidi
4006 iterator by calling bidi_pop_it same number of times.
4007 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4008 and we are bidi-iterating, don't decrement the iterator position;
4009 instead, set the first_elt flag in the bidi iterator, to produce
4010 the same effect.
4011 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4012 (push_display_prop): xassert that we are iterating a buffer.
4013 (push_it, pop_it): Save and restore paragraph_embedding member.
4014 (handle_single_display_spec, next_overlay_string)
4015 (get_overlay_strings_1, reseat_1, reseat_to_string)
4016 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4017 correctly. Don't assume unibyte strings are not bidi-reordered.
4018 (compute_display_string_pos)
4019 (compute_display_string_end): Fix handling the case of C string.
4020 (push_it, pop_it): Save and restore from_disp_prop_p.
4021 (handle_single_display_spec, push_display_prop): Set the
4022 from_disp_prop_p flag.
4023 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4024 (pop_it): Call iterate_out_of_display_property only if we are
4025 popping after iteration over a string that came from a display
4026 property. Fix a typo in popping stretch info. Add an assertion
4027 for verifying that the iterator position is in sync with the bidi
4028 iterator.
4029 (handle_single_display_spec, get_overlay_strings_1)
4030 (push_display_prop): Fix initialization of paragraph direction for
4031 string when that of the parent object is not yet determined.
4032 (reseat_1): Call bidi_init_it to resync the bidi
4033 iterator with IT's position. (Bug#7616)
4034 (find_row_edges): If ROW->start.pos gives position
4035 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4036 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4037 Reset the from_disp_prop_p flag.
4038 (SAVE_IT, RESTORE_IT): New macros.
4039 (pos_visible_p, face_before_or_after_it_pos)
4040 (back_to_previous_visible_line_start)
4041 (move_it_in_display_line_to, move_it_in_display_line)
4042 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4043 (try_scrolling, redisplay_window, display_line): Use them when
4044 saving a temporary copy of the iterator and restoring it back.
4045 (back_to_previous_visible_line_start, reseat_1)
4046 (init_iterator): Empty the bidi cache "stack".
4047 (move_it_in_display_line_to): If iterator ended up at
4048 EOL, but we never saw any buffer positions smaller than
4049 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4050 motion in bidi-reordered lines.
4051 (move_it_in_display_line_to): Record prev_method and prev_pos
4052 immediately before the call to set_iterator_to_next. Fixes cursor
4053 motion in bidi-reordered lines with stretch glyphs and strings
4054 displayed in margins. (Bug#8133) (Bug#8867)
4055 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4056 TO_CHARPOS.
640c8776
SM
4057 (pos_visible_p): Support positions in bidi-reordered lines.
4058 Save and restore bidi cache.
0bb23927
EZ
4059
4060 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4061 (bidi_paragraph_info): Delete unused struct.
4062 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4063 (bidi_cache_start): New variable.
4064 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4065 to zero.
4066 (bidi_cache_fetch_state, bidi_cache_search)
4067 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4068 (bidi_cache_find, bidi_peek_at_next_level)
4069 (bidi_level_of_next_char, bidi_find_other_level_edge)
4070 (bidi_move_to_visually_next): Compare cache index with
4071 bidi_cache_start rather than with zero.
4072 (bidi_fetch_char): Accept new argument STRING; all callers
4073 changed. Support iteration over a string. Support strings with
4074 display properties. Support unibyte strings. Fix the type of
4075 `len' according to what STRING_CHAR_AND_LENGTH expects.
4076 (bidi_paragraph_init, bidi_resolve_explicit_1)
4077 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4078 (bidi_level_of_next_char, bidi_move_to_visually_next):
4079 Support iteration over a string.
0bb23927
EZ
4080 (bidi_set_sor_type, bidi_resolve_explicit_1)
4081 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4082 can now be zero (for strings); special values 0 and -1 were
4083 changed to -1 and -2, respectively.
4084 (bidi_char_at_pos): New function.
4085 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4086 Call it instead of FETCH_MULTIBYTE_CHAR.
4087 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4088 initialized to valid values.
4089 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4090 values.
4091 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4092 the test for valid cached positions. Fix the logic for looking up
4093 the sentinel state in the cache. GCPRO the Lisp string we are
4094 iterating.
4095 (bidi_push_it, bidi_pop_it): New functions.
4096 (bidi_initialize): Initialize the bidi cache start stack pointer.
4097 (bidi_cache_ensure_space): New function, refactored from part of
4098 bidi_cache_iterator_state. Don't assume the required size is just
4099 one BIDI_CACHE_CHUNK away.
4100 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4101 (bidi_count_bytes, bidi_char_at_pos): New functions.
4102 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4103 always valid if bidi_cache_idx is valid.
4104 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4105 is valid if it's going to be used.
4106 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4107 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4108 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4109 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4110 (bidi_find_other_level_edge, bidi_cache_start_stack):
4111 All variables related to cache indices are now EMACS_INT.
c965adc5 4112
0bb23927
EZ
4113 * dispextern.h (struct bidi_string_data): New structure.
4114 (struct bidi_it): New member `string'. Make flag members be 1-bit
4115 fields, and put them last in the struct.
640c8776
SM
4116 (compute_display_string_pos, compute_display_string_end):
4117 Update prototypes.
0bb23927
EZ
4118 (bidi_push_it, bidi_pop_it): Add prototypes.
4119 (struct iterator_stack_entry): New members bidi_p,
4120 paragraph_embedding, and from_disp_prop_p.
4121 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4122 (bidi_shelve_cache, bidi_unshelve_cache):
4123 Declare prototypes.
0bb23927
EZ
4124
4125 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4126 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4127 and vector-like objects.
4128
4129 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4130 cache around display iteration.
4131
4132 * window.c (Fwindow_end, window_scroll_pixel_based)
4133 (displayed_window_lines, Frecenter): Save and restore the bidi
4134 cache around display iteration.
4135
3bbd2265
LMI
41362011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4137
4138 * editfns.c (Fdelete_region): Clarify the use of the named
4139 parameters (bug#6788).
4140
adc47434
MR
41412011-07-14 Martin Rudalics <rudalics@gmx.at>
4142
4143 * indent.c (Fvertical_motion): Set and restore w->pointm when
4144 saving and restoring the window's buffer (Bug#9006).
4145
837c31f8
LMI
41462011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4147
4148 * editfns.c (Fstring_to_char): Clarify just what is returned
4149 (bug#6576). Text by Eli Zaretskii.
4150
ac389d0c
JB
41512011-07-13 Juanma Barranquero <lekktu@gmail.com>
4152
4153 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4154
0be0ce47
EZ
41552011-07-13 Eli Zaretskii <eliz@gnu.org>
4156
4157 * buffer.c (mmap_find): Fix a typo.
4158
cd18e7e3
JB
41592011-07-13 Johan Bockgård <bojohan@gnu.org>
4160
4161 Fix execution of x selection hooks.
4162 * xselect.c (Qx_lost_selection_functions)
4163 (Qx_sent_selection_functions): New vars.
4164 (syms_of_xselect): DEFSYM them.
4165 (x_handle_selection_request): Pass Qx_sent_selection_functions
4166 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4167 (x_handle_selection_clear,x_clear_frame_selections):
4168 Pass Qx_lost_selection_functions rather than
4169 Vx_lost_selection_functions to Frun_hook_with_args.
4170
47ea7f44
PE
41712011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4172
ac389d0c 4173 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4174 The old code sometimes used this field without initializing it.
4175
47ea7f44
PE
4176 * alloc.c (gc_sweep): Don't read past end of array.
4177 In theory, the old code could also have corrupted Emacs internals,
4178 though it'd be very unlikely.
4179
bc985c87
AS
41802011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4181
4182 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4183 argument. (Bug#4026)
bc985c87 4184
0cf34688
LMI
41852011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4186
b3dadd76
LMI
4187 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4188 key" (bug#4257).
4189
0cf34688
LMI
4190 * window.c (Fset_window_start): Doc fix (bug#4199).
4191 (Fset_window_hscroll): Ditto.
4192
270768cd
PE
41932011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4194
077e3dda 4195 Fix minor new problems caught by GCC 4.6.1.
270768cd 4196 * term.c (init_tty): Remove unused local.
490011a6 4197 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4198 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4199 not used otherwise.
270768cd 4200
b1f58454
CY
42012011-07-12 Chong Yidong <cyd@stupidchicken.com>
4202
4203 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4204
22b9578d
LMI
42052011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4206
6e70ab07
LMI
4207 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4208 are the mini-buffer and the echo area (bug#3320).
4209
22b9578d
LMI
4210 * term.c (init_tty): Remove support for supdup, c10 and perq
4211 terminals, which are no longer supported (bug#1482).
4212
8974cc9f
JB
42132011-07-10 Johan Bockgård <bojohan@gnu.org>
4214
4215 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4216
a560d974
JD
42172011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4218
4219 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4220 for non-popups (Bug#3642).
4221
1dae0f0a
AS
42222011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4223
268c2c36 4224 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4225 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4226 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4227 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4228 * data.c (fmod): Likewise.
4229 * dispnew.c (swap_glyphs_in_rows): Likewise.
4230 * emacs.c (memory_warning_signal): Likewise.
4231 * floatfns.c (float_error): Likewise.
4232 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4233 (otf_open, font_otf_capability, generate_otf_features)
4234 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4235 Likewise.
4236 * image.c (pbm_read_file): Likewise.
4237 * indent.c (string_display_width): Likewise.
4238 * intervals.c (check_for_interval, search_for_interval)
4239 (inc_interval_count, count_intervals, root_interval)
4240 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4241 * lread.c (defalias): Likewise.
268c2c36 4242 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4243 * regex.c (set_image_of_range_1, set_image_of_range)
4244 (regex_grow_registers): Likewise.
4245 * sysdep.c (strerror): Likewise.
4246 * termcap.c (valid_filename_p, tprint, main): Likewise.
4247 * tparam.c (main): Likewise.
4248 * unexhp9k800.c (run_time_remap, save_data_space)
4249 (update_file_ptrs, read_header, write_header, calculate_checksum)
4250 (copy_file, copy_rest, display_header): Likewise.
4251 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4252 Likewise.
4253 * xdisp.c (check_it): Likewise.
4254 * xfaces.c (register_color, unregister_color, unregister_colors):
4255 Likewise.
4256 * xfns.c (print_fontset_result): Likewise.
4257 * xrdb.c (member, fatal, main): Likewise.
4258
99033785
PE
42592011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4260
4261 Fix minor problems found by static checking (Bug#9031).
4262 * chartab.c (char_table_set_range, map_sub_char_table):
4263 Remove unused locals.
4264 (uniprop_table): Now static.
4265 * composite.c (_work_char): Remove unused static var.
4266
9cb2ac56
JB
42672011-07-09 Juanma Barranquero <lekktu@gmail.com>
4268
4269 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4270
f25661f0
JD
42712011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4272
4273 * gtkutil.c (qttip_cb): Remove code without function.
4274
8278c4fe
EZ
42752011-07-09 Eli Zaretskii <eliz@gnu.org>
4276
4277 * w32.c (pthread_sigmask): New stub.
4278
1692ae2d 42792011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4280
8a6ebd58 4281 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4282 sigprocmask is portable only for single-threaded applications, and
4283 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4284 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4285 (LIBES): Use it.
4286 * callproc.c (Fcall_process):
4287 * process.c (create_process):
4288 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4289 Use pthread_sigmask, not sigprocmask.
123403e4 4290
1b854618
JD
42912011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4292
4293 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4294 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4295 wrong (Bug#8591).
4296
3fe4b549
JD
42972011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4298
0ce7e563
JD
4299 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4300 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4301 (xg_hide_tooltip): Fix comment.
4302
3fe4b549
JD
4303 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4304 in registerServicesMenuSendTypes.
4305 (validRequestorForSendType): Don't check ns_return_types.
4306
4307 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4308 ns_return_type.
4309
5df75e47
JR
43102011-07-08 Jason Rumney <jasonr@gnu.org>
4311
22610910
JR
4312 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4313 SH_SHOW for hidden windows (Bug#5482).
4314
5df75e47
JR
4315 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4316 frame struct members of non-existent frames (Bug#6284).
4317
699c10bd
JD
43182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4319
4393663b
JD
4320 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4321 variable firstTime not needed on OSX >= 10.6.
4322 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4323 >= 10.5. Use setKnobProportion, setDoubleValue.
4324
4325 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4326 (MAC_OS_X_VERSION_10_5): Define if not defined.
4327 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4328 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4329 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4330
4331 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4332 cString and lossyCString on OSX >= 10.4
4333
58179cce 4334 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4335 sizeToFit on OSX >= 10.2.
4336
4337 * nsimage.m (allocInitFromFile): Don't use deprecated method
4338 bestRepresentationForDevice on OSX >= 10.6.
4339
4340 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4341 to avoid warning.
4342
4343 * emacs.c: Declare unexec_init_emacs_zone.
4344
a63e0781
JD
4345 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4346
699c10bd
JD
4347 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4348
4349 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4350 on svcsMenu (Bug#8842).
4351
4352 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4353 ns_return_types.
4354 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4355
4356 * nsterm.m (QUTF8_STRING): Declare.
4357 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4358 (validRequestorForSendType): Return type is (id).
4359 Change indexOfObjectIdenticalTo to indexOfObject.
4360 Check if we have local selection before returning self (Bug#8842).
4361 (writeSelectionToPasteboard): Put local selection into paste board
4362 if we have a local selection (Bug#8842).
4363 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4364
4365 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4366 (ns_get_local_selection): Declare.
4367
54e10184
LMI
43682011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4369
9888ff71
LMI
4370 * keymap.c (describe_map_tree): Don't insert a double newline at
4371 the end of the buffer (bug#1169) and return whether we inserted
4372 something.
4373
54e10184
LMI
4374 * callint.c (Fcall_interactively): Change "reading args" to
4375 "providing args" to try to clarify what it does (bug#1010).
4376
15fa4783
KH
43772011-07-07 Kenichi Handa <handa@m17n.org>
4378
4379 * composite.c (composition_compute_stop_pos): Ignore a static
4380 composition starting before CHARPOS (Bug#8915).
4381
4382 * xdisp.c (handle_composition_prop): Likewise.
4383
a8815b00
EZ
43842011-07-07 Eli Zaretskii <eliz@gnu.org>
4385
4386 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4387 (Bug#9015)
4388
ef7b981d 43892011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4390
4391 * character.h (unicode_category_t): New enum type.
4392
4393 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4394 (Qchar_code_property_table): New variable.
4395 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4396 (UNIPROP_COMPRESSED_FORM_P): New macros.
4397 (char_table_ascii): Uncompress the compressed values.
4398 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4399 Uncompress the compressed values.
ac389d0c 4400 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4401 (char_table_ref_and_range): Uncompress the compressed values.
4402 (sub_char_table_set): New arg is_uniprop. Callers changed.
4403 Uncompress the compressed values.
4404 (sub_char_table_set_range): Args changed. Callers changed.
4405 (char_table_set_range): Adjuted for the above change.
4406 (map_sub_char_table): Delete args default_val and parent. Add arg
4407 top. Give decoded values to a Lisp function.
640c8776 4408 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4409 values to a Lisp function. Gcpro more variables.
4410 (uniprop_table_uncompress)
4411 (uniprop_decode_value_run_length): New functions.
4412 (uniprop_decoder, uniprop_decoder_count): New variables.
4413 (uniprop_get_decoder, uniprop_encode_value_character)
4414 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4415 New functions.
4416 (uniprop_encoder, uniprop_encoder_count): New variables.
4417 (uniprop_get_encoder, uniprop_table)
4418 (Funicode_property_table_internal, Fget_unicode_property_internal)
4419 (Fput_unicode_property_internal): New functions.
4420 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4421 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4422 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4423 char-code-property-alist.
4424
640c8776 4425 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4426 Vunicode_category_table.
4427
640c8776 4428 * font.c (font_range): Adjust for the change of
c805dec0
KH
4429 Vunicode_category_table.
4430
76b397fb
DN
44312011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4432
4433 * m/iris4d.h: Remove file, move contents ...
4434 * s/irix6-5.h: ... here.
4435
22b4128e
PE
44362011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4437
4438 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4439 * alloc.c (mark_buffer):
4440 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4441 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4442 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4443 This isn't true in general, and it's particularly not true
4444 if Emacs is configured with --with-wide-int.
4445 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4446 New macros, used in the buffer.c change.
4447
869795d6
JD
44482011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4449
4450 * xsettings.c: Use both GConf and GSettings if both are available.
4451 (store_config_changed_event): Add comment.
4452 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4453 (store_tool_bar_style_changed): New functions.
5e617bc2 4454 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4455 (struct xsettings): Move font inside HAVE_XFT.
4456 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4457 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4458 Move inside HAVE_XFT.
640c8776 4459 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4460 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4461 also.
4462 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4463 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4464 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4465 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4466 (parse_settings): Move check for font inside HAVE_XFT.
4467 (read_settings, apply_xft_settings): Add comment.
4468 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4469 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4470 call store_font_name_changed.
4471 (xft_settings_event): Add comment.
4472 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4473 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4474 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4475 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4476 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4477 (xsettings_get_system_font, xsettings_get_system_normal_font):
4478 Add comment.
869795d6 4479
d8ed26bd
PE
44802011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4481
4482 Random fixes. E.g., (random) never returned negative values.
4483 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4484 subseconds part to the entropy, as that's a bit more random.
4485 Prefer signed to unsigned, since the signedness doesn't matter and
4486 in general we prefer signed. When given a limit, use a
4487 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4488 latter isn't right if USE_2_TAGS_FOR_INTS.
4489 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4490 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4491
cabf1cac
SM
44922011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4493
4494 * textprop.c (text_property_stickiness):
4495 Obey Vtext_property_default_nonsticky.
4496 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4497 * w32fns.c (syms_of_w32fns):
4498 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4499
6e9b2be9
PE
45002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4501
4502 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4503 This is more efficient than Ffile_directory_p and avoids a minor race.
4504
90186c68
LMI
45052011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4506
7c301272
LMI
4507 * buffer.c (Foverlay_put): Say what the return value is
4508 (bug#7835).
4509
c4f2d8d4
LMI
4510 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4511 is a directory before asking whether to use the file name
4512 (bug#7564).
ad637907
LMI
4513 (barf_or_query_if_file_exists): Make the "File is a directory"
4514 error be more correct.
c4f2d8d4 4515
90186c68
LMI
4516 * fns.c (Frequire): Remove the mention of the .gz files, since
4517 that's installation-specific, but keep the mention of
4518 `get-load-suffixes'.
4519
da64016e
PE
45202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4521
4522 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4523 Report string overflow if the output is too long.
4524
7d47b580
JB
45252011-07-04 Juanma Barranquero <lekktu@gmail.com>
4526
a555cb87
JB
4527 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4528 (syms_of_gnutls): Remove duplicate DEFSYM for
4529 Qgnutls_bootprop_verify_hostname_error, an error for
4530 Qgnutls_bootprop_verify_error (which is no longer used).
4531
7d47b580
JB
4532 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4533 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4534 Also (re)move comments that are misplaced or no longer relevant.
4535
1e49bfab
LMI
45362011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4537
4538 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4539
1485f4c0
CY
45402011-07-03 Chong Yidong <cyd@stupidchicken.com>
4541
4542 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4543 and background color parameters if they have been changed.
4544
a9ab721e
LMI
45452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4546
4547 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4548
cf7cff57
PE
45492011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4550
2e13213d
PE
4551 * xsettings.c (SYSTEM_FONT): Define only when used.
4552 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4553
cf7cff57
PE
4554 * keymap.c (access_keymap_1): Now static.
4555
7a8e04f7
CY
45562011-07-02 Chong Yidong <cyd@stupidchicken.com>
4557
4558 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4559 leave any prefix arg for the up event (Bug#1586).
4560
61352f62
LMI
45612011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4562
69bb1ef7
LMI
4563 * lread.c (syms_of_lread): Mention single symbols defined by
4564 `defvar' or `defconst' (bug#7154).
4565
61352f62 4566 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4567 (Frequire): Mention get-load-suffixes.
61352f62 4568
28545e04
MR
45692011-07-02 Martin Rudalics <rudalics@gmx.at>
4570
4571 * window.h (window): Remove clone_number slot.
4572 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4573 Remove.
4574 (make_parent_window, make_window, saved_window)
4575 (Fset_window_configuration, save_window_save): Don't deal with
4576 clone numbers.
4577 * buffer.c (Qclone_number): Remove declaration.
4578 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4579
3349e122
SM
45802011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4581
4582 Add multiple inheritance to keymaps.
4583 * keymap.c (Fmake_composed_keymap): New function.
4584 (Fset_keymap_parent): Simplify.
4585 (fix_submap_inheritance): Remove.
4586 (access_keymap_1): New function extracted from access_keymap to handle
4587 embedded parents and handle lists of maps.
4588 (access_keymap): Use it.
4589 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4590 (Fcopy_keymap): Handle embedded parents.
4591 (Fcommand_remapping, define_as_prefix): Simplify.
4592 (Fkey_binding): Simplify.
4593 (syms_of_keymap): Move minibuffer-local-completion-map,
4594 minibuffer-local-filename-completion-map,
4595 minibuffer-local-must-match-map, and
4596 minibuffer-local-filename-must-match-map to Elisp.
4597 (syms_of_keymap): Defsubr make-composed-keymap.
4598 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4599 (parse_menu_item): Trivial simplification.
4600
3279eb87
GM
46012011-07-01 Glenn Morris <rgm@gnu.org>
4602
4603 * Makefile.in (SETTINGS_LIBS): Fix typo.
4604
4550efdf
KI
46052011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4606
4607 * coding.c (Fencode_coding_string): Record the last coding system
4608 used, as the function doc string says (bug#8738).
4609
0949d2b6
JD
46102011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4611
4612 * xsettings.c (store_monospaced_changed): Take new font as arg and
4613 check for change against current_mono_font.
4614 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4615 (emacs_settings_constructor, emacs_settings_get_property)
4616 (emacs_settings_set_property, emacs_settings_class_init)
4617 (emacs_settings_init, gsettings_obj): Remove.
4618 (something_changedCB): New function for HAVE_GSETTINGS.
4619 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4620 with value as argument.
4621 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4622 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4623 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4624 "changed".
4625
4626 * xgselect.c: Add defined (HAVE_GSETTINGS).
4627 (xgselect_initialize): Ditto.
4628
4629 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4630 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4631 xg_select.
4632
bbc6b304
PE
46332011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4634
4635 * eval.c (struct backtrace): Simplify and port the data structure.
4636 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4637 signed bit field, as this assumption is not portable and it makes
4638 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4639 "char debug_on_exit : 1" as this is not portable either; instead,
4640 use the portable "unsigned int debug_on_exit : 1". Remove unused
4641 member evalargs. Remove obsolete comments about cc bombing out.
4642
9851bfc5
JD
46432011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4644
51bb811f 4645 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4646 Let HAVE_GSETTINGS override HAVE_GCONF.
4647 (store_monospaced_changed): New function.
4648 (EMACS_SETTINGS): A new type derived from GObject to handle
4649 GSettings notifications.
4650 (emacs_settings_constructor, emacs_settings_get_property)
4651 (emacs_settings_set_property, emacs_settings_class_init):
4652 New functions.
4653 (gsettings_client, gsettings_obj): New variables.
4654 (GSETTINGS_SCHEMA): New define.
4655 (something_changedCB): Call store_monospaced_changed.
4656 (init_gsettings): New function.
4657 (xsettings_initialize): Call init_gsettings.
4658 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4659 to NULL.
4660
640c8776 4661 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4662 GCONF_CFLAGS/LIBS.
4663
5386012d
MR
46642011-06-29 Martin Rudalics <rudalics@gmx.at>
4665
4666 * window.c (resize_root_window, grow_mini_window)
4667 (shrink_mini_window): Rename Qresize_root_window to
4668 Qwindow_resize_root_window and Qresize_root_window_vertically to
4669 Qwindow_resize_root_window_vertically.
4670
f13e0b08
PE
46712011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4672
4673 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4674
94515237
JB
46752011-06-27 Juanma Barranquero <lekktu@gmail.com>
4676
4677 * makefile.w32-in: Redesign dependencies so they reflect more
4678 clearly which files are directly included by each source file,
4679 and not through other includes.
4680
e43b6e43
MR
46812011-06-27 Martin Rudalics <rudalics@gmx.at>
4682
4683 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4684 (sort_overlays, overlay_strings): When an overlay's clone number
4685 matches the window's clone number process the overlay even if
4686 the overlay's window property doesn't match the current window.
4687
d68443dc
MR
4688 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4689 (Fwindow_hchild): Rename to Fwindow_left_child.
4690 (Fwindow_next): Rename to Fwindow_next_sibling.
4691 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4692 (resize_window_check): Rename to window_resize_check.
4693 (resize_window_apply): Rename to window_resize_apply.
4694 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4695 (Fdelete_other_windows_internal, resize_frame_windows)
4696 (Fsplit_window_internal, Fdelete_window_internal)
4697 (grow_mini_window, shrink_mini_window)
4698 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4699
c7e73be5
JD
47002011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4701
4702 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4703 (emacs_fixed_set_min_size): Remove.
4704 (emacs_fixed_new): Take frame as argument.
4705
4706 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4707 (_EmacsFixedPrivate): Remove minwidth/height.
4708 Add struct frame *f.
4709 (emacs_fixed_init): Initialize priv->f.
4710 (get_parent_class, emacs_fixed_set_min_size): Remove.
4711 (emacs_fixed_new): Set priv->f to argument.
4712 (emacs_fixed_get_preferred_width)
4713 (emacs_fixed_get_preferred_height): Use min_width/height from
4714 frames size_hint to set minimum and natural (Bug#8919).
4715 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4716 and use min_width/height from frames size_hint to set
4717 min_width/height (Bug#8919).
4718
4719 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4720 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4721 Fix indentation.
c7e73be5 4722
cf99dcf8
EZ
47232011-06-26 Eli Zaretskii <eliz@gnu.org>
4724
4725 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4726 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4727 called at ZV.
4728
029529ac
CY
47292011-06-26 Chong Yidong <cyd@stupidchicken.com>
4730
4731 * process.c (wait_reading_process_output): Bypass select if
4732 waiting for a cell while ignoring keyboard input, and input is
4733 pending. Suggested by Jan Djärv (Bug#8869).
4734
7a7ef429
PE
47352011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4736
4737 Use gnulib's dup2 module instead of rolling our own.
4738 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4739
11fdef7d 47402011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4741
4742 * dispnew.c (scrolling_window): Before scrolling, turn off a
4743 mouse-highlight in the window being scrolled.
4744
cd3520a4
JB
47452011-06-24 Juanma Barranquero <lekktu@gmail.com>
4746
4747 Move DEFSYM to lisp.h and use everywhere.
4748
4749 * character.h (DEFSYM): Move declaration...
4750 * lisp.h (DEFSYM): ...here.
4751
4752 * gnutls.c:
4753 * minibuf.c:
4754 * w32menu.c:
4755 * w32proc.c:
4756 * w32select.c: Don't include character.h.
4757
4758 * alloc.c (syms_of_alloc):
4759 * buffer.c (syms_of_buffer):
4760 * bytecode.c (syms_of_bytecode):
4761 * callint.c (syms_of_callint):
4762 * casefiddle.c (syms_of_casefiddle):
4763 * casetab.c (init_casetab_once):
4764 * category.c (init_category_once, syms_of_category):
4765 * ccl.c (syms_of_ccl):
4766 * cmds.c (syms_of_cmds):
4767 * composite.c (syms_of_composite):
4768 * dbusbind.c (syms_of_dbusbind):
4769 * dired.c (syms_of_dired):
4770 * dispnew.c (syms_of_display):
4771 * doc.c (syms_of_doc):
4772 * editfns.c (syms_of_editfns):
4773 * emacs.c (syms_of_emacs):
4774 * eval.c (syms_of_eval):
4775 * fileio.c (syms_of_fileio):
4776 * fns.c (syms_of_fns):
4777 * frame.c (syms_of_frame):
4778 * fringe.c (syms_of_fringe):
4779 * insdel.c (syms_of_insdel):
4780 * keymap.c (syms_of_keymap):
4781 * lread.c (init_obarray, syms_of_lread):
4782 * macros.c (syms_of_macros):
4783 * msdos.c (syms_of_msdos):
4784 * print.c (syms_of_print):
4785 * process.c (syms_of_process):
4786 * search.c (syms_of_search):
4787 * sound.c (syms_of_sound):
4788 * syntax.c (init_syntax_once, syms_of_syntax):
4789 * terminal.c (syms_of_terminal):
4790 * textprop.c (syms_of_textprop):
4791 * undo.c (syms_of_undo):
4792 * w32.c (globals_of_w32):
4793 * window.c (syms_of_window):
4794 * xdisp.c (syms_of_xdisp):
4795 * xfaces.c (syms_of_xfaces):
4796 * xfns.c (syms_of_xfns):
4797 * xmenu.c (syms_of_xmenu):
4798 * xsettings.c (syms_of_xsettings):
4799 * xterm.c (syms_of_xterm): Use DEFSYM.
4800
4228cf16
TZ
48012011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4802
cd3520a4 4803 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4804
7fcccf1e
PE
48052011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4806
7efb4e0e
PE
4807 Integer and buffer overflow fixes (Bug#8873).
4808
ff5844ad
PE
4809 * print.c (printchar, strout): Check for string overflow.
4810 (PRINTPREPARE, printchar, strout):
4811 Don't set size unless allocation succeeds.
4812
90532f02
PE
4813 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4814 for sizes. Check for string overflow more accurately.
4815 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4816
6d84508d
PE
4817 * macros.c: Integer and buffer overflow fixes.
4818 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4819 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4820 Use ptrdiff_t, not int, for sizes.
4821 Don't increment bufsize until after realloc succeeds.
4822 Check for size-calculation overflow.
4823 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4824
437b2cb4
PE
4825 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4826
8b9ac8b4
PE
4827 * lread.c: Integer overflow fixes.
4828 (read_integer): Radix is now EMACS_INT, not int,
4829 to improve quality of diagnostics for out-of-range radices.
4830 Calculate buffer size correctly for out-of-range radices.
4831 (read1): Check for integer overflow in radices, and in
4832 read-circle numbers.
82cb60d3
PE
4833 (read_escape): Avoid int overflow.
4834 (Fload, openp, read_buffer_size, read1)
4835 (substitute_object_recurse, read_vector, read_list, map_obarray):
4836 Use ptrdiff_t, not int, for sizes.
4837 (read1): Use EMACS_INT, not int, for sizes.
20270765 4838 Check for size overflow.
8b9ac8b4 4839
7fcccf1e
PE
4840 * image.c (cache_image): Check for size arithmetic overflow.
4841
bfbbd7e7
PE
4842 * lread.c: Integer overflow issues.
4843 (saved_doc_string_size, saved_doc_string_length)
4844 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4845 Now ptrdiff_t, not int.
4846 (read1): Don't assume doc string length fits in int. Check for
4847 out-of-range doc string lengths.
4848 (read_list): Don't assume file position fits in int.
39019e54 4849 (read_escape): Check for hex character overflow.
bfbbd7e7 4850
4e323265
LL
48512011-06-22 Leo Liu <sdl.web@gmail.com>
4852
4853 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4854 Move to minibuffer.el.
4855
85fece3e
PE
48562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4857
20b84ce9 4858 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4859 The following patches are for when GLYPH_DEBUG && !XASSERT.
4860 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4861 * dispnew.c (flush_stdout):
4862 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4863 Mark as externally visible.
4864 * dispnew.c (check_window_matrix_pointers): Now static.
4865 * dispnew.c (window_to_frame_vpos):
4866 * xfns.c (unwind_create_frame):
4867 * xterm.c (x_check_font): Remove unused local.
4868 * scroll.c (CHECK_BOUNDS):
4869 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4870 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4871 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4872 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4873 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4874 Now static.
4875 (debug_method_add): Use va_list and vsprintf rather than relying
4876 on undefined behavior with wrong number of arguments.
4877 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4878 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4879 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4880 since we're not interested in debugging glyphs with old libraries.
4881 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4882 GCC 4.6.0's static checking.
4883
0766b489
PE
48842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4885
31fd4b32
PE
4886 Integer overflow and signedness fixes (Bug#8873).
4887 A few related buffer overrun fixes, too.
4888
b79e8648
PE
4889 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4890
0766b489
PE
4891 * dispextern.h (struct face.stipple):
4892 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4893 (x_bitmap_mask, x_allocate_bitmap_record)
4894 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4895 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4896 (x_create_bitmap_from_xpm_data):
4897 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4898 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4899 (.bitmaps_last):
4900 * xfaces.c (load_pixmap):
4901 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4902 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4903 (.bitmaps_last, struct x_output.icon_bitmap):
4904 Use ptrdiff_t, not int, for bitmap indexes.
4905 (x_allocate_bitmap_record): Check for size overflow.
4906 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4907
b081724f
PE
4908 Use ptrdiff_t, not int, for overlay counts.
4909 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4910 * editfns.c (overlays_around, get_pos_property):
4911 * textprop.c (get_char_property_and_overlay):
4912 * xdisp.c (next_overlay_change, note_mouse_highlight):
4913 * xfaces.c (face_at_buffer_position):
21514da7
PE
4914 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4915 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4916 (Fnext_overlay_change, Fprevious_overlay_change)
4917 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4918 Use ptrdiff_t, not int, for sizes.
21514da7 4919 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4920
3de73e5e
PE
4921 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4922
2606c57b
PE
4923 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4924 (x_session_initialize): Do not assume string length fits in int.
4925
aaafe47a
PE
4926 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4927 This is unlikely, but can occur if DPI is outlandish.
4928
2674ddc8 4929 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4930 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4931
28154962
PE
4932 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4933 * xrdb.c (magic_file_p, search_magic_path):
4934 Omit last arg SUFFIX; it was always 0. All callers changed.
4935 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4936
7de51af5
PE
4937 * xfont.c (xfont_match): Avoid need for strlen.
4938
25ed6cc3
PE
4939 * xfns.c: Don't assume strlen fits in int.
4940 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4941
4eab31dd
PE
4942 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4943 not unsigned long, as we prefer signed integers. All callers changed.
4944 Detect integer overflow in repeat count.
4945 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4946 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4947
171e2a58
PE
4948 * termcap.c: Don't assume sizes fit in int and never overflow.
4949 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4950 (gobble_line): Check for size-calculation overflow.
4951
ad39faca 4952 * minibuf.c (Fread_buffer):
6e5bb2dc 4953 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4954 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4955 Don't assume string length fits in int.
4956
52c61c22 4957 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4958 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4959
b5b8c9e5
PE
4960 * font.c: Don't assume string length fits in int.
4961 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4962 Use ptrdiff_t, not int.
ccd6111c
PE
4963 (font_intern_prop): Don't assume string length fits in int.
4964 Don't assume integer property fits in fixnum.
4965 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4966
882f0d81 4967 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4968 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4969 Reformulate so as not to need the command string.
4970 Invoke gzip -cd rather than gunzip, as it's more portable.
4971 (lock_info_type, lock_file_1, lock_file):
4972 Don't assume pid_t and time_t fit in unsigned long.
4973 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4974 (current_lock_owner): Prefer signed type for sizes.
4975 Use memcpy, not strncpy, where memcpy is what is really wanted.
4976 Don't assume (via atoi) that time_t and pid_t fit in int.
4977 Check for time_t and/or pid_t out of range, e.g., via a network share.
4978 Don't alloca where an auto var works fine.
4979
93f4cf88
PE
4980 * fileio.c: Fix some integer overflow issues.
4981 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4982 Don't assume string length fits in int.
4983 (directory_file_name): Don't assume string length fits in long.
4984 (make_temp_name): Don't assume pid fits in int, or that its print
4985 length is less than 20.
4986
f3e92b69
PE
4987 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4988
1bfdaf10
PE
4989 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4990
35016e9a
PE
4991 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4992
3d1e65a1
PE
4993 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4994 We prefer signed integers, even for size calculations.
4995
0b963a93
PE
4996 * emacs.c: Don't assume string length fits in 'int'.
4997 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4998 (main): Don't invoke strlen when not needed.
4999
573f4b54
PE
5000 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5001 (XD_DEBUG_MESSAGE): Don't waste a byte.
5002
989f33ba
PE
5003 * callproc.c (getenv_internal_1, getenv_internal)
5004 (Fgetenv_internal):
965d34eb
PE
5005 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5006
e4d29b33
PE
5007 * lread.c (invalid_syntax): Omit length argument.
5008 All uses changed. This doesn't fix a bug, but it simplifies the
5009 code away from its former Hollerith-constant appearance, and it's
5010 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5011 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5012
eb49b136
PE
5013 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5014 This didn't break anything, but it didn't help either.
5015 It's confusing to put a bogus integer in a place where the actual
5016 value does not matter.
9f62aeb1 5017 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5018 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5019
15375a22
PE
5020 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5021 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5022 implementation.
b61cc01c
PE
5023 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5024 We prefer signed types, and the value cannot exceed the EMACS_INT
5025 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5026 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5027 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5028 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5029
53b2623d
PE
5030 * indent.c (sane_tab_width): New function.
5031 (current_column, scan_for_column, Findent_to, position_indentation)
5032 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5033 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5034
51cab52b 5035 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5036
f2ed8a70
PE
5037 * lisp.h (lint_assume): New macro.
5038 * composite.c (composition_gstring_put_cache):
5039 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5040
abe80cc6
PE
5041 * editfns.c, insdel.c:
5042 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5043
b02c740e
PE
5044 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5045
ebc96716
PE
5046 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5047
b4e50fa0 5048 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5049 Use much-faster test for byte-length change.
311d5d7c 5050 Don't assume string byte-length fits in 'int'.
a4cf38e4 5051 Check that character arg fits in 'int'.
85461888 5052 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5053
c0c1ee9f
PE
5054 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5055
a498d7f4
PE
5056 * fns.c (concat): Catch string overflow earlier.
5057 Do not rely on integer wraparound.
5058
51cab52b
PE
5059 * dispextern.h (struct it.overlay_strings_charpos)
5060 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5061 * xdisp.c (forward_to_next_line_start)
5062 (back_to_previous_visible_line_start)
5063 (reseat_at_next_visible_line_start, next_element_from_buffer):
5064 Don't arbitrarily truncate the value of 'selective' to int.
5065
76031fad
PE
5066 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5067
5eb55db9
PE
5068 * composite.c: Don't truncate sizes to 'int'.
5069 (composition_gstring_p, composition_reseat_it)
5070 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5071 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5072 not EMACS_UINT, for indexes.
5eb55db9 5073
0703a717
PE
5074 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5075
d6202519
PE
5076 * buffer.c: Include <verify.h>.
5077 (struct sortvec.priority, struct sortstr.priority):
8961a454 5078 Now EMACS_INT, not int.
c20998a7 5079 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5080 (struct sortstr.size, record_overlay_string)
5081 (struct sortstrlist.size, struct sortlist.used):
5082 Don't truncate size to int.
5083 (record_overlay_string): Check for size-calculation overflow.
d6202519 5084 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5085
d5a19415
JM
50862011-06-22 Jim Meyering <meyering@redhat.com>
5087
029529ac 5088 Don't leak an XBM-image-sized buffer
d5a19415
JM
5089 * image.c (xbm_load): Free the image buffer after using it.
5090
a9041e6c
PE
50912011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5092
5093 Port to Sun C.
5094 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5095 that Sun C diagnosed.
5096 * fns.c (secure_hash): Fix pointer signedness issue.
5097 * intervals.c (static_offset_intervals): New function.
5098 (offset_intervals): Use it.
5099
7f3f739f
LL
51002011-06-21 Leo Liu <sdl.web@gmail.com>
5101
5102 * deps.mk (fns.o):
5103 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5104 sha512.h.
5105
5106 * fns.c (secure_hash): Rename from crypto_hash_function and change
5107 the first arg to accept symbols.
5b66d427 5108 (Fsecure_hash): New primitive.
7f3f739f
LL
5109 (syms_of_fns): New symbols.
5110
76147d94
DD
51112011-06-20 Deniz Dogan <deniz@dogan.se>
5112
5113 * process.c (Fset_process_buffer): Clarify return value in
5114 docstring.
5115
7d7d0045
CY
51162011-06-18 Chong Yidong <cyd@stupidchicken.com>
5117
5118 * dispnew.c (add_window_display_history): Use BVAR.
5119
5120 * xdisp.c (debug_method_add): Use BVAR.
5121 (check_window_end, dump_glyph_matrix, dump_glyph)
5122 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5123
5124 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5125 Likewise.
5126
5127 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5128 check till after the cache is created in init_frame_faces.
5129
ff2bc410
SM
51302011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5131
5132 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5133
28177add
PE
51342011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5135
dd3482fe
PE
5136 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5137 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5138 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5139
393d71f3 5140 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5141 * fileio.c (Finsert_file_contents):
5142 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5143 Remove the old (too-loose) buffer overflow checks.
5144 They weren't needed, since make_gap checks for buffer overflow.
5145 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5146 The old code merely checked for Emacs fixnum overflow, and relied
5147 on undefined (wraparound) behavior. The new code avoids undefined
5148 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5149
2e6813b0 5150 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5151 Tune. Don't use wider integers than needed. Don't use alloca.
5152 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5153
599a9e4f
PE
5154 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5155
99561444
PE
5156 * insdel.c, lisp.h (buffer_overflow): New function.
5157 (insert_from_buffer_1, replace_range, replace_range_2):
5158 * insdel.c (make_gap_larger):
5159 * editfns.c (Finsert_char):
5160 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5161
28177add
PE
5162 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5163
e69dafad
PE
51642011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5165
4baa020d 5166 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5167
b1c46f02
PE
5168 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5169 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5170
e69dafad
PE
5171 * fileio.c: Don't assume EMACS_INT fits in off_t.
5172 (emacs_lseek): New static function.
5173 (Finsert_file_contents, Fwrite_region): Use it.
5174 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5175
566684ea
PE
5176 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5177
e6966cd6
PE
5178 * fns.c: Don't overflow int when computing a list length.
5179 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5180 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5181 truncation on 64-bit hosts. Check for QUIT every
5182 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5183 faster and is responsive enough.
5184 (Flength): Report an error instead of overflowing an integer.
5185 (Fsafe_length): Return a float if the value is not representable
5186 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5187 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5188 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5189
dd0b0efb
PE
5190 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5191 (header_size, word_size): New constants.
5192 (allocate_vectorlike): Don't check size overflow here.
5193 (allocate_vector): Check it here instead, since this is the only
5194 caller of allocate_vectorlike that could cause overflow.
5195 Check that the new vector's length is representable as a fixnum.
5196
86fe5cfe
PE
5197 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5198 The previous code was bogus. For example, next_almost_prime (32)
5199 returned 39, which is undesirable as it is a multiple of 3; and
5200 next_almost_prime (24) returned 25, which is a multiple of 5 so
5201 why was the code bothering to check for multiples of 7?
5202
80e88859
PE
5203 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5204
4a2f0ad6
PE
5205 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5206
f66c7cf8
PE
5207 Variadic C functions now count arguments with ptrdiff_t.
5208 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5209 Back then I didn't know that the Emacs coding style prefers signed int.
5210 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5211 were being counted with int, which may truncate counts on 64-bit
5212 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5213 * lisp.h (struct Lisp_Subr.function.aMANY)
5214 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5215 Arg counts are now ptrdiff_t, not size_t.
5216 All variadic functions and their callers changed accordingly.
5217 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5218 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5219 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5220 * callint.c (Fcall_interactively): Check arg count for overflow,
5221 to avoid potential buffer overrun. Use signed char, not 'int',
5222 for 'varies' array, so that we needn't bother to check its size
5223 calculation for overflow.
5224 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5225 * eval.c (apply_lambda):
5226 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5227 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5228 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5229
a1759b76
PE
5230 * callint.c (Fcall_interactively): Don't use index var as event count.
5231
d96be9fc
PE
5232 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5233 * mem-limits.h (SIZE): Remove; no longer used.
5234
a690a978 5235 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5236
578c21e6
PE
5237 Remove unnecessary casts.
5238 * xterm.c (x_term_init):
5239 * xfns.c (x_set_border_pixel):
5240 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5241 These aren't needed now that we assume ANSI C.
5242
96f53c6c
PE
5243 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5244 It's more likely to cause problems (due to unsigned overflow)
5245 than to cure them.
5246
83c77d31
PE
5247 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5248
ee2079f1
PE
5249 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5250
6da65536
PE
5251 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5252
7147c4a4
PE
5253 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5254
193e32d9
PE
5255 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5256
e5533da6
PE
5257 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5258
9910e595
PE
5259 GLYPH_CODE_FACE returns EMACS_INT, not int.
5260 * dispextern.h (merge_faces):
5261 * xfaces.c (merge_faces):
01103c44
PE
5262 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5263 Don't assume EMACS_INT fits in int.
9910e595 5264
2638320e
PE
5265 * character.h (CHAR_VALID_P): Remove unused parameter.
5266 * fontset.c, lisp.h, xdisp.c: All uses changed.
5267
045eb8d9
PE
5268 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5269
c1f134b5
PE
5270 * fns.c (concat): Minor tuning based on overflow analysis.
5271 This doesn't fix any bugs. Use int to hold character, instead
5272 of constantly refetching from Emacs object. Use XFASTINT, not
5273 XINT, for value known to be a character. Don't bother comparing
5274 a single byte to 0400, as it's always less.
5275
395fcb93 5276 * floatfns.c (Fexpt):
327eeec8
PE
5277 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5278
abbd3d23
PE
5279 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5280 for characters.
5281
684a03ef
PE
5282 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5283
0fed43f3
PE
5284 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5285 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5286 incorrectly succeed when S was a string, because 4294967386 was
5287 truncated before it was used.
5288
8fd02eb7
PE
5289 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5290 Otherwise, an out-of-range integer could cause undefined behavior
5291 on a 64-bit host.
5292
f8c86b69
PE
5293 * composite.c: Use int, not EMACS_INT, for characters.
5294 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5295 EMACS_INT, for values that are known to be in character range.
5296 This doesn't fix any bugs but is the usual style inside Emacs and
5297 may generate better code on 32-bit machines.
5298
34206dd2
PE
5299 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5300 This is for reasons similar to the recent CHAR_STRING fix.
5301 * charset.c (Fencode_char): Check that character arg is actually
5302 a character. Pass an int to ENCODE_CHAR.
5303 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5304 wider than 'int', as a compile-time check to prevent future regressions
5305 in this area.
5306
c5958d4c 5307 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5308
5309 Make sure a 64-bit char is never passed to CHAR_STRING.
5310 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5311 by silently ignoring the top 32 bits, allowing some values
5312 that were far too large to be valid characters.
5313 * character.h: Include <verify.h>.
5314 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5315 arguments are no wider than unsigned, as a compile-time check
5316 to prevent future regressions in this area.
5317 * data.c (Faset):
01103c44 5318 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5319 (Fsubst_char_in_region):
5320 * fns.c (concat):
5321 * xdisp.c (decode_mode_spec_coding):
5322 Adjust to CHAR_STRING's new requirement.
5323 * editfns.c (Finsert_char, Fsubst_char_in_region):
5324 * fns.c (concat): Check that character args are actually
5325 characters. Without this test, these functions did the wrong
5326 thing with wildly out-of-range values on 64-bit hosts.
5327
d37ca623
PE
5328 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5329 These casts should not be needed on 32-bit hosts, either.
5330 * keyboard.c (read_char):
5331 * lread.c (Fload): Remove casts to unsigned.
5332
ea204efb
PE
5333 * lisp.h (UNSIGNED_CMP): New macro.
5334 This fixes comparison bugs on 64-bit hosts.
5335 (ASCII_CHAR_P): Use it.
5336 * casefiddle.c (casify_object):
01103c44 5337 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5338 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5339 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5340 * dispextern.h (FACE_FROM_ID):
5341 * keyboard.c (read_char): Use UNSIGNED_CMP.
5342
41cb286c
PE
5343 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5344 not to EMACS_INT, to avoid GCC warning.
5345
4a1b9832
PE
5346 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5347
55daad71
PE
5348 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5349 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5350 isn't needed on 32-bit machines.
8f95c75c 5351
01103c44
PE
5352 * buffer.c (Fgenerate_new_buffer_name):
5353 Use EMACS_INT for count, not int.
0ceccced 5354 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5355
5356 * data.c (Qcompiled_function): Now static.
5357
c6f072e7
PE
5358 * window.c (window_body_lines): Now static.
5359
20ce5912
PE
5360 * image.c (gif_load): Rename local to avoid shadowing.
5361
9c4c5f81
PE
5362 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5363 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5364 * alloc.c (make_save_value): Integer argument is now of type
5365 ptrdiff_t, not int.
5366 (mark_object): Use ptrdiff_t, not int.
5367 * lisp.h (pD): New macro.
5368 * print.c (print_object): Use it.
5369
c0c5c8ae
PE
5370 * alloc.c: Use EMACS_INT, not int, to count objects.
5371 (total_conses, total_markers, total_symbols, total_vector_size)
5372 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5373 (total_free_floats, total_floats, total_free_intervals)
5374 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5375 Now EMACS_INT, not int. All uses changed.
5376 (Fgarbage_collect): Compute overall total using a double, so that
5377 integer overflow is less likely to be a problem. Check for overflow
5378 when converting back to an integer.
5a25e253
PE
5379 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5380 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5381 These were 'int' variables that could overflow on 64-bit hosts;
5382 they were never used, so remove them instead of repairing them.
211a0b2a 5383 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5384 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5385 Previously, this ceilinged at INT_MAX, but that doesn't work on
5386 64-bit machines.
e46bb31a 5387 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5388
c78baabf 5389 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5390 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5391 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5392 when a (possibly-narrower) signed value would do just as well.
5393 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5394
c9d624c6
PE
5395 * alloc.c: Catch some string size overflows that we were missing.
5396 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5397 for convenience in STRING_BYTES_MAX.
5398 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5399 The definition here is exact; the one in lisp.h was approximate.
5400 (allocate_string_data): Check for string overflow. This catches
5401 some instances we weren't catching before. Also, it catches
5402 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5403 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5404 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5405
c9d624c6
PE
5406 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5407 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5408 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5409
353032ce
PE
5410 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5411
2bccce07
PE
5412 * alloc.c (Fmake_string): Check for out-of-range init.
5413
0ac30604
SM
54142011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5415
5416 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5417
c195f2de
JD
54182011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5419
5420 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5421 xg_get_default_scrollbar_width.
5422
5423 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5424 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5425 (style_changed_cb): Call update_theme_scrollbar_width and call
5426 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5427 all frames (Bug#8505).
5428 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5429 Call gtk_window_set_resizable if HAVE_GTK3.
5430 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5431 and height if HAVE_GTK3 (Bug#8505).
5432 (scroll_bar_width_for_theme): New variable.
5433 (update_theme_scrollbar_width): New function.
5434 (xg_get_default_scrollbar_width): Move code to
5435 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5436 (xg_initialize): Call update_theme_scrollbar_width.
5437
5438 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5439
5440 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5441
e10ac9f1
MR
54422011-06-12 Martin Rudalics <rudalics@gmx.at>
5443
5444 * frame.c (make_frame): Call other_buffer_safely instead of
5445 other_buffer.
5446
5447 * window.c (temp_output_buffer_show): Call display_buffer with
5448 second argument Vtemp_buffer_show_specifiers and reset latter
5449 immediately after the call.
5450 (Vtemp_buffer_show_specifiers): New variable.
5451 (auto_window_vscroll_p, next_screen_context_lines)
5452 (Vscroll_preserve_screen_position): Remove leading asterisks from
5453 doc-strings.
5454
2d3c217e 54552011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5456
7b7f97e8 5457 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5458 * buffer.c (Qclone_number): Remove for now, as it's unused.
5459 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5460 (record_buffer): Remove unused local.
5461 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5462 (set_frame_buffer_list): Remove; unused.
5463 * frame.h (other_visible_frames): Remove decl.
5464 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5465 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5466 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5467 if HAVE_GPM.
5468 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5469 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5470 Define only if HAVE_GPM.
5471 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5472 (update_hints_inhibit): Remove; never set. All uses removed.
5473 * widgetprv.h (emacsFrameClassRec): Remove decl.
5474 * window.c (delete_deletable_window): Now returns void, since it
5475 wasn't returning anything.
5476 (compare_window_configurations): Remove unused locals.
5477 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5478 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5479 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5480 the same widths as pointers. This follows up on the 2011-05-06 patch.
5481 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5482 * xterm.h: Likewise.
5483 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5484
1384b89e
JB
54852011-06-12 Juanma Barranquero <lekktu@gmail.com>
5486
5487 * makefile.w32-in: Update dependencies.
5488 (LISP_H): Add lib/intprops.h.
5489
1100a63c
CY
54902011-06-11 Chong Yidong <cyd@stupidchicken.com>
5491
5492 * image.c (gif_load): Add animation frame delay to the metadata.
5493 (syms_of_image): Use DEFSYM. New symbol `delay'.
5494
6198ccd0
MR
54952011-06-11 Martin Rudalics <rudalics@gmx.at>
5496
5497 * window.c (delete_deletable_window): Re-add.
5498 (Fset_window_configuration): Rewrite to handle dead buffers and
5499 consequently deletable windows.
5500 (window_tree, Fwindow_tree): Remove. Supply functionality in
5501 window.el.
5502 (compare_window_configurations): Simplify code.
5503
b6e3633c
AS
55042011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5505
1ab0dee5
AS
5506 * image.c (imagemagick_load_image): Fix type mismatch.
5507 (Fimagemagick_types): Likewise.
5508
b6e3633c
AS
5509 * window.h (replace_buffer_in_windows): Declare.
5510
9397e56f
MR
55112011-06-11 Martin Rudalics <rudalics@gmx.at>
5512
5513 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5514 Qclone_number. Remove external declaration of Qdelete_window.
5515 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5516 code.
640c8776
SM
5517 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5518 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5519 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5520 buffer list implementation.
5521 (other_buffer_safely): New function.
5522 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5523 calls to replace_buffer_in_windows and
5524 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5525 if allowed.
5526 (record_buffer): Inhibit quitting and rewrite using quittable
5527 functions. Run Qbuffer_list_update_hook if allowed.
5528 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5529 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5530 Move switch-to-buffer to window.el.
9397e56f
MR
5531 (bury-buffer): Move to window.el.
5532 (Vbuffer_list_update_hook): New variable.
5533
5534 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5535 section.
5536
5537 * window.h (resize_frame_windows): Move up in code.
5538 (Fwindow_frame): Remove EXFUN.
5539 (replace_buffer_in_all_windows): Remove prototype.
5540 (replace_buffer_in_windows_safely): Add prototype.
5541
5542 * window.c: Declare Qdelete_window static again. Move down
5543 declaration of select_count.
5544 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5545 (Fother_window): Move to window.el.
5546 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5547 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5548 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5549 window.el.
5550 (replace_buffer_in_windows): Implement by calling
5551 Qreplace_buffer_in_windows.
5552 (replace_buffer_in_all_windows): Remove with some functionality
5553 moved into replace_buffer_in_windows_safely.
5554 (replace_buffer_in_windows_safely): New function.
5555 (select_window_norecord, select_frame_norecord): Move in front
5556 of run_window_configuration_change_hook. Remove now obsolete
5557 declarations.
640c8776
SM
5558 (Fset_window_buffer): Rewrite doc-string.
5559 Call Qrecord_window_buffer.
9397e56f
MR
5560 (keys_of_window): Move binding for other-window to window.el.
5561
b50691aa
CY
55622011-06-11 Chong Yidong <cyd@stupidchicken.com>
5563
5564 * dispextern.h (struct image): Replace data member, whose int_val
5565 and ptr_val fields were not used by anything, with a single
5566 lisp_val object.
5567
5568 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5569 (gif_clear_image, gif_load, imagemagick_load_image)
5570 (gs_clear_image, gs_load): Callers changed.
5571
3f754b86
PE
55722011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5573
cca69397
PE
5574 * buffer.h: Include <time.h>, for time_t.
5575 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5576
109e28d0
PE
5577 Fix minor problems found by static checking.
5578
60737f02
PE
5579 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5580
4b66faf3
PE
5581 Make identifiers static if they are not used in other modules.
5582 * data.c (Qcompiled_function, Qframe, Qvector):
5583 * image.c (QimageMagick, Qsvg):
5584 * minibuf.c (Qmetadata):
5585 * window.c (resize_window_check, resize_root_window): Now static.
5586 * window.h (resize_window_check, resize_root_window): Remove decls.
5587
109e28d0
PE
5588 * window.c (window_deletion_count, delete_deletable_window):
5589 Remove; unused.
46a4ce9e
PE
5590 (window_body_lines): Now static.
5591 (Fdelete_other_windows_internal): Mark vars as initialized.
5592 Make sure 'resize_failed' is initialized.
5593 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5594 (resize_window_apply): Remove unused local.
5595 * window.h (delete_deletable_window): Remove decl.
5596
109e28d0 5597 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5598 (imagemagick_load_image): Fix pointer signedness problem by changing
5599 last arg from unsigned char * to char *. All uses changed.
5600 Also, fix a local for similar reasons.
5601 Remove unused locals. Remove locals to avoid shadowing.
5602 (fn_rsvg_handle_free): Remove; unused.
5603 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5604 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5605
3f754b86
PE
5606 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5607
2547adb1
CY
56082011-06-10 Chong Yidong <cyd@stupidchicken.com>
5609
5610 * image.c (gif_load): Fix omitted cast error introduced by
5611 2011-06-06 change.
5612
2c8e37d4
MR
56132011-06-10 Martin Rudalics <rudalics@gmx.at>
5614
5615 * window.h (resize_proportionally, orig_total_lines)
5616 (orig_top_line): Remove from window structure.
5617 (set_window_height, set_window_width, change_window_heights)
5618 (Fdelete_window): Remove prototypes.
5619 (resize_frame_windows): Remove duplicate declaration.
5620
440a42e3
EZ
56212011-06-10 Eli Zaretskii <eliz@gnu.org>
5622
5623 * window.h (resize_frame_windows, resize_window_check)
5624 (delete_deletable_window, resize_root_window)
5625 (resize_frame_windows): Declare prototypes.
5626
5627 * window.c (resize_window_apply): Make definition be "static" to
5628 match the prototype.
5629
562dd5e9
MR
56302011-06-10 Martin Rudalics <rudalics@gmx.at>
5631
5632 * window.c: Remove declarations of Qwindow_size_fixed,
5633 window_min_size_1, window_min_size_2, window_min_size,
5634 size_window, window_fixed_size_p, enlarge_window, delete_window.
5635 Remove static from declaration of Qdelete_window, it's
5636 temporarily needed by Fbury_buffer.
5637 (replace_window): Don't assign orig_top_line and
5638 orig_total_lines.
5639 (Fdelete_window, delete_window): Remove. Window deletion is
5640 handled by window.el.
640c8776
SM
5641 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5642 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5643 (Fdelete_other_windows): Remove. Deleting other windows is
5644 handled by window.el.
5645 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5646 handled in window.el.
5647 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5648 Window minimum sizes are handled in window.el.
5649 (shrink_windows, size_window, set_window_height)
5650 (set_window_width, change_window_heights, window_height)
5651 (window_width, CURBEG, CURSIZE, enlarge_window)
5652 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5653 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5654 handled in window.el.
5655 (make_dummy_parent): Rename to make_parent_window and give it a
5656 second argument horflag.
5657 (make_window): Don't set resize_proportionally any more.
5658 (Fsplit_window): Remove. Windows are split in window.el.
5659 (save_restore_action, save_restore_orig_size)
5660 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5661 Resize mini windows in window.el.
5662 (grow_mini_window, shrink_mini_window): Implement by calling
5663 Qresize_root_window_vertically, resize_window_check and
5664 resize_window_apply.
640c8776
SM
5665 (saved_window, Fset_window_configuration, save_window_save):
5666 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5667 resize_proportionally.
5668 (window_min_height, window_min_width): Move to window.el.
5669 (keys_of_window): Move bindings for delete-other-windows,
5670 split-window, delete-window and enlarge-window to window.el.
5671
5672 * buffer.c: Temporarily extern Qdelete_window.
5673 (Fbury_buffer): Temporarily call Qdelete_window instead of
5674 Fdelete_window (Fbury_buffer will move to window.el soon).
5675
5676 * frame.c (set_menu_bar_lines_1): Remove code handling
5677 orig_top_line and orig_total_lines.
5678
5679 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5680 set_window_height but set heights directly.
5681 (change_frame_size_1): Use resize_frame_windows.
5682
5683 * xdisp.c (init_xdisp): Don't use set_window_height but set
5684 heights directly.
5685
640c8776
SM
5686 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5687 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5688 run_window_configuration_change_hook.
5689
5690 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5691 instead of change_window_heights and run
5692 run_window_configuration_change_hook.
5693
1a13852e
MR
56942011-06-09 Martin Rudalics <rudalics@gmx.at>
5695
5696 * window.c (replace_window): Rename second argument REPLACEMENT to
5697 NEW. New third argument SETFLAG. Rewrite.
5698 (delete_window, make_dummy_parent): Call replace_window with
5699 third argument 1.
5700 (window_list_1): Move down in code.
5701 (run_window_configuration_change_hook): Move set_buffer part
5702 before select_frame_norecord part in order to unwind correctly.
5703 Rename count1 to count.
5704 (recombine_windows, delete_deletable_window, resize_root_window)
5705 (Fdelete_other_windows_internal)
5706 (Frun_window_configuration_change_hook, make_parent_window)
5707 (resize_window_check, resize_window_apply, Fresize_window_apply)
5708 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5709 (Fdelete_window_internal, Fresize_mini_window_internal):
5710 New functions.
1a13852e
MR
5711 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5712
f3d1777e
MR
57132011-06-08 Martin Rudalics <rudalics@gmx.at>
5714
496e208e
MR
5715 * window.h (window): Add some new members to window structure -
5716 normal_lines, normal_cols, new_total, new_normal, clone_number,
5717 splits, nest, prev_buffers, next_buffers.
5718 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5719 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5720
f3d1777e
MR
5721 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5722 Remove.
496e208e
MR
5723 (make_dummy_parent): Set new members of windows structure.
5724 (make_window): Move down in code. Handle new members of window
5725 structure.
5726 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5727 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5728 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5729 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5730 (Fset_window_next_buffers, Fset_window_clone_number):
5731 New functions.
496e208e
MR
5732 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5733 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5734 Doc-string fixes.
5735 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5736 Argument WINDOW can be now internal window too.
5737 (Fwindow_use_time): Move up in code.
5738 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5739 Rewrite doc-string.
5740 (Fset_window_configuration, saved_window)
5741 (Fcurrent_window_configuration, save_window_save): Handle new
5742 members of window structure.
b9e809c2
MR
5743 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5744 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5745 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5746 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5747 Qget_mru_window, Qresize_root_window,
5748 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5749 Qauto_buffer_name; staticpro them.
f3d1777e 5750
abde8f8c
MR
57512011-06-07 Martin Rudalics <rudalics@gmx.at>
5752
5753 * window.c (Fwindow_total_size, Fwindow_left_column)
5754 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5755 (Fwindow_list_1): New functions.
5756 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5757 (Fwindow_width, Fscroll_left, Fscroll_right):
5758 Use window_body_cols instead of window_box_text_cols.
5759 (delete_window, Fset_window_configuration):
5760 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5761 (delete_all_subwindows): Take a window as argument and not a
5762 structure. Rewrite.
190b47e6
MR
5763 (window_loop): Remove handling of GET_LRU_WINDOW and
5764 GET_LARGEST_WINDOW.
5765 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5766
5767 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5768 window_box_text_cols. delete_all_subwindows now takes a
5769 Lisp_Object as argument.
abde8f8c 5770
640c8776
SM
5771 * indent.c (compute_motion, Fcompute_motion):
5772 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5773
fa8a67e6
MR
5774 * frame.c (delete_frame): Call delete_all_subwindows with root
5775 window as argument.
5776
a54e3482
DC
57772011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5778
5779 * fns.c (Fputhash): Document return value.
5780
60002bf5
CY
57812011-06-06 Chong Yidong <cyd@stupidchicken.com>
5782
5783 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5784
0c671da6 57852011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5786
b862a52a 5787 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5788
be44ca6c
PE
5789 Check for overflow when converting integer to cons and back.
5790 * charset.c (Fdefine_charset_internal, Fdecode_char):
5791 Use cons_to_unsigned to catch overflow.
5792 (Fencode_char): Use INTEGER_TO_CONS.
5793 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5794 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5795 * data.c (long_to_cons, cons_to_long): Remove.
5796 (cons_to_unsigned, cons_to_signed): New functions.
5797 These signal an error for invalid or out-of-range values.
5798 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5799 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5800 * font.c (Ffont_variation_glyphs):
5801 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5802 * lisp.h: Include <intprops.h>.
5803 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5804 (cons_to_signed, cons_to_unsigned): New decls.
5805 (long_to_cons, cons_to_long): Remove decls.
5806 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5807 (Fprimitive_undo): Use CONS_TO_INTEGER.
5808 * xfns.c (Fx_window_property): Likewise.
5809 * xselect.c: Include <limits.h>.
5810 (x_own_selection, selection_data_to_lisp_data):
5811 Use INTEGER_TO_CONS.
5812 (x_handle_selection_request, x_handle_selection_clear)
5813 (x_get_foreign_selection, Fx_disown_selection_internal)
5814 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5815 (lisp_data_to_selection_data): Use cons_to_unsigned.
5816 (x_fill_property_data): Use cons_to_signed.
5817 Report values out of range.
5818
d1f3d2af
PE
5819 Check for buffer and string overflow more precisely.
5820 * buffer.h (BUF_BYTES_MAX): New macro.
5821 * lisp.h (STRING_BYTES_MAX): New macro.
5822 * alloc.c (Fmake_string):
5823 * character.c (string_escape_byte8):
5824 * coding.c (coding_alloc_by_realloc):
5825 * doprnt.c (doprnt):
5826 * editfns.c (Fformat):
5827 * eval.c (verror):
5828 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5829 since they may not be the same number.
5830 * editfns.c (Finsert_char):
5831 * fileio.c (Finsert_file_contents):
5832 Likewise for BUF_BYTES_MAX.
5833
dd52fcea
PE
5834 * image.c: Use ptrdiff_t, not int, for sizes.
5835 (slurp_file): Switch from int to ptrdiff_t.
5836 All uses changed.
5837 (slurp_file): Check that file size fits in both size_t (for
5838 malloc) and ptrdiff_t (for sanity and safety).
5839
7f9bbdbb
PE
5840 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5841 if b->modtime has its maximal value.
5842
dfe18f82
PE
5843 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5844
84acfcf0
PE
5845 Don't assume time_t can fit into int.
5846 * buffer.h (struct buffer.modtime): Now time_t, not int.
5847 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5848 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5849
ccd9a01a
PE
5850 Minor fixes for signed vs unsigned integers.
5851 * character.h (MAYBE_UNIFY_CHAR):
5852 * charset.c (maybe_unify_char):
5853 * keyboard.c (read_char, reorder_modifiers):
5854 XINT -> XFASTINT, since the integer must be nonnegative.
5855 * ftfont.c (ftfont_spec_pattern):
5856 * keymap.c (access_keymap, silly_event_symbol_error):
5857 XUINT -> XFASTINT, since the integer must be nonnegative.
5858 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5859 since it makes no difference and we prefer signed.
5860 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5861 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5862 nonnegative.
5863
d6d100dd
SM
58642011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5865
5866 * window.h (Fwindow_frame): Declare.
5867
2b6148e4
PE
58682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5869
5870 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5871 (SPARE_MEMORY): Always define.
5872 (LARGE_REQUEST): Remove.
5873 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5874
f230ecc9
MR
58752011-06-06 Martin Rudalics <rudalics@gmx.at>
5876
727e958e
MR
5877 * lisp.h: Move EXFUNS for Fframe_root_window,
5878 Fframe_first_window and Fset_frame_selected_window to window.h.
5879
5880 * window.h: Move EXFUNS for Fframe_root_window,
5881 Fframe_first_window and Fset_frame_selected_window here from
5882 lisp.h.
5883
5884 * frame.c (Fwindow_frame, Fframe_first_window)
5885 (Fframe_root_window, Fframe_selected_window)
5886 (Fset_frame_selected_window): Move to window.c.
5887 (Factive_minibuffer_window): Move to minibuf.c.
5888 (Fother_visible_frames_p): New function.
5889
5890 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5891
f230ecc9
MR
5892 * window.c (decode_window, decode_any_window): Move up in code.
5893 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5894 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5895 (Fwindow_buffer): Move up and rewrite doc-string.
5896 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5897 (Fwindow_prev): New functions.
727e958e
MR
5898 (Fwindow_frame): Move here from frame.c. Accept any window as
5899 argument.
5900 (Fframe_root_window, Fframe_first_window)
5901 (Fframe_selected_window): Move here from frame.c. Accept frame
5902 or arbitrary window as argument. Update doc-strings.
5903 (Fminibuffer_window): Move up in code.
5904 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5905 (Fset_frame_selected_window): Move here from frame.c.
5906 Marginal rewrite.
727e958e
MR
5907 (Fselected_window, select_window, Fselect_window): Move up in
5908 code. Minor doc-string fixes.
f230ecc9 5909
4d09bcf6
PE
59102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5911
5912 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5913 Do not assume that spare memory exists; that assumption is valid
5914 only if SYSTEM_MALLOC.
5915 (LARGE_REQUEST): New macro, so that the issue of large requests
5916 is separated from the issue of spare memory.
5917
810928a2
AS
59182011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5919
172418ad
AS
5920 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5921 format. (Bug#8806)
5922
43f862f7
AS
5923 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5924
810928a2
AS
5925 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5926 before statements.
5927
a059fe24
JD
59282011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5929
5930 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5931
5932 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5933
5934 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5935 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5936
989bf368
JB
59372011-06-05 Juanma Barranquero <lekktu@gmail.com>
5938
5939 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5940
4b80f674
CY
59412011-06-04 Chong Yidong <cyd@stupidchicken.com>
5942
5943 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5944 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5945 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5946 New error handlers.
4b80f674
CY
5947 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5948 Obey Vx_select_enable_clipboard_manager. Catch errors in
5949 x_clipboard_manager_save (Bug#8779).
5950 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5951 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5952
99a33b77 59532011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5954
5955 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5956
99a33b77 59572011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5958
5959 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5960 in the current matrix if keep_current_p is non-zero.
5961
8264569d
EZ
59622011-06-04 Eli Zaretskii <eliz@gnu.org>
5963
5964 * bidi.c (bidi_level_of_next_char): Fix last change.
5965
57f97249
EZ
59662011-06-03 Eli Zaretskii <eliz@gnu.org>
5967
fec2107c 5968 Support bidi reordering of text covered by display properties.
57f97249 5969
fec2107c
EZ
5970 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5971 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5972 (bidi_cache_search, bidi_cache_iterator_state)
5973 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5974 (bidi_level_of_next_char, bidi_move_to_visually_next):
5975 Support character positions inside a run of characters covered by a
fec2107c
EZ
5976 display string.
5977 (bidi_paragraph_init, bidi_resolve_explicit_1)
5978 (bidi_level_of_next_char): Call bidi_fetch_char and
5979 bidi_fetch_char_advance instead of FETCH_CHAR and
5980 FETCH_CHAR_ADVANCE.
5981 (bidi_init_it): Initialize new members.
5982 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5983 definitions.
5984 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5985 instead of using explicit *_CHAR codes.
d6d100dd
SM
5986 (bidi_resolve_explicit, bidi_resolve_weak):
5987 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5988 bidirectional text is supported only in multibyte buffers.
5989 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5990 it to initialize the frame_window_p member of struct bidi_it.
5991 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5992 (bidi_resolve_explicit, bidi_resolve_weak)
5993 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5994 bidi_it->nchars is non-positive.
5995 (bidi_level_of_next_char): Don't try to lookup the cache for the
5996 next/previous character if nothing is cached there yet, or if we
5997 were just reseat()'ed to a new position.
c40e2fb2 5998
0e14fe90
EZ
5999 * xdisp.c (set_cursor_from_row): Set start and stop points
6000 according to the row's direction when priming the loop that looks
6001 for the glyph on which to display cursor.
6002 (single_display_spec_intangible_p): Function deleted.
6003 (display_prop_intangible_p): Reimplement to call
6004 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6005 Accept 3 additional arguments needed by handle_display_spec.
6006 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6007 values: lists, `(when COND...)' forms, etc.
6008 (single_display_spec_string_p): Support property values that are
6009 lists with the argument STRING its top-level element.
6010 (display_prop_string_p): Fix the condition for processing a
6011 property that is a list to be consistent with handle_display_spec.
fec2107c 6012 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6013 last portion of handle_display_prop.
6014 (compute_display_string_pos): Accept additional argument
6015 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6016 value of a `display' property is a "replacing spec".
6017 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6018 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6019 the display property, but just return a value indicating whether
6020 the display property will replace the characters it covers.
6021 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6022 frame_window_p members of struct bidi_it.
d6d100dd
SM
6023 (compute_display_string_pos, compute_display_string_end):
6024 New functions.
fec2107c
EZ
6025 (push_it): Accept second argument POSITION, where pop_it should
6026 jump to continue iteration.
6027 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6028
fec2107c
EZ
6029 * keyboard.c (adjust_point_for_property): Adjust the call to
6030 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6031
6032 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6033 (bidi_init_it): Update prototypes.
6034 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6035 (compute_display_string_pos, compute_display_string_end):
6036 Declare prototypes.
fec2107c
EZ
6037 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6038 EMACS_INT.
fc6f18ce 6039
40087514 60402011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6041
57f53182
PE
6042 Malloc failure behavior now depends on size of allocation.
6043 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6044 * lisp.h: Change signatures accordingly.
6045 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6046 All callers changed. (Bug#8762)
6047
6048 * gnutls.c: Use Emacs's memory allocators.
6049 Without this change, the gnutls library would invoke malloc etc.
6050 directly, which causes problems on non-SYNC_INPUT hosts, and which
6051 runs afoul of improving memory_full behavior. (Bug#8761)
6052 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6053 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6054 xfree instead of the default malloc, realloc, free.
6055 (Fgnutls_boot): No need to check for memory allocation failure,
6056 since xmalloc does that for us.
6057
ac32cd99 6058 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6059 * category.c (hash_get_category_set):
6060 * ccl.c (ccl_driver):
6061 * charset.c (Fdefine_charset_internal):
6062 * charset.h (struct charset.hash_index):
6063 * composite.c (get_composition_id, gstring_lookup_cache)
6064 (composition_gstring_put_cache):
6065 * composite.h (struct composition.hash_index):
6066 * dispextern.h (struct image.hash):
6067 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6068 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6069 (hashfn_equal, hashfn_user_defined, make_hash_table)
6070 (maybe_resize_hash_table, hash_lookup, hash_put)
6071 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6072 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6073 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6074 * image.c (make_image, search_image_cache, lookup_image)
6075 (xpm_put_color_table_h):
6076 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6077 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6078 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6079 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6080 * alloc.c (allocate_vectorlike):
6081 Check for overflow in vector size calculations.
6082 * ccl.c (ccl_driver):
6083 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6084 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6085 need to be updated by these changes.
40087514
PE
6086 * fns.c (make_hash_table, maybe_resize_hash_table):
6087 Check for integer overflow with large hash tables.
0de4bb68
PE
6088 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6089 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6090 (SXHASH_REDUCE): New macro.
6091 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6092 Use it instead of discarding useful hash info with large hash values.
6093 (sxhash_float): New function.
6094 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6095 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6096 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6097 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6098 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6099 Adjust signatures to match updated version of code.
6100 (consing_since_gc): Now EMACS_INT, since a single hash table can
6101 use more than INT_MAX bytes.
6102
698d32e2
DN
61032011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6104
6105 Make it possible to build with GCC-4.6+ -O2 -flto.
6106
6107 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6108
fd6fa53f
SM
61092011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6110
6111 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6112 Call minibuffer-inactive-mode.
6113
864db017
JB
61142011-05-31 Juanma Barranquero <lekktu@gmail.com>
6115
6116 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6117 Update dependencies.
6118
2ad0baf4
DN
61192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6120
6121 * data.c (init_data): Remove code for UTS, this system is not
6122 supported anymore.
6123
4fcc2638
DN
61242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6125
6126 Don't force ./temacs to start in terminal mode.
6127
6128 * frame.c (make_initial_frame): Initialize faces in all cases, not
6129 only when CANNOT_DUMP is defined.
6130 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6131
c56e0fd5
DN
61322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6133
6134 * dispnew.c (add_window_display_history): Use const for the string
6135 pointer. Remove declaration, not needed.
6136
333d54da 61372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6138
55d4c1b2 6139 Use 'inline', not 'INLINE'.
333d54da 6140 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6141 * alloc.c, fontset.c (INLINE): Remove.
6142 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6143 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6144 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6145 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6146 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6147
738db178
DN
61482011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6149
6150 Make it possible to run ./temacs.
6151
6152 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6153 syms_of_callproc does the same thing. Remove test for
6154 "initialized", do it in the caller.
6155 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6156
620c53a6
SM
61572011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6158
6159 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6160 (read_minibuf): Use get_minibuffer.
6161 (syms_of_minibuf): Use DEFSYM.
6162 (Qmetadata): New var.
6163 * data.c (Qbuffer): Don't make it static.
6164 (syms_of_data): Use DEFSYM.
6165
e003a292
PE
61662011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6167
6168 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6169 (CCL_CODE_MIN): New macro.
6170
ed008a6d
PE
61712011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6172
3687c2ef
PE
6173 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6174
ed008a6d
PE
6175 * eval.c (Qdebug): Now static.
6176 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6177 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6178 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6179
d66c4c7c
CY
61802011-05-29 Chong Yidong <cyd@stupidchicken.com>
6181
6182 * image.c: Various fixes to ImageMagick code comments.
6183 (Fimagemagick_types): Doc fix.
6184
5fbc2025
PE
61852011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6186
0196f88a
PE
6187 Minor fixes prompted by GCC 4.6.0 warnings.
6188
6189 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6190
5fbc2025
PE
6191 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6192 (x_clipboard_manager_save_all): Move extern decl to ...
6193 * xterm.h: ... here, so that it can be checked for consistency.
6194
1dd3c2d9
CY
61952011-05-29 Chong Yidong <cyd@stupidchicken.com>
6196
6197 * xselect.c (x_clipboard_manager_save_frame)
6198 (x_clipboard_manager_save_all): New functions.
6199 (Fx_clipboard_manager_save): Lisp function deleted.
6200
6201 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6202 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6203
6204 * xterm.h: Update prototype.
6205
5ba6571d
WX
62062011-05-28 William Xu <william.xwl@gmail.com>
6207
6208 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6209 exiting (Bug#8239).
6210
3eaff834
JM
62112011-05-28 Jim Meyering <meyering@redhat.com>
6212
e1900994 6213 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6214 * fns.c (to_uchar): Define.
6215 (crypto_hash_function): Use it to convert some newly-signed
6216 variables to unsigned, to avoid sign-extension bugs. For example,
6217 without this change, (md5 "truc") would evaluate to
6218 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6219 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6220 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6221
0f6990a7
PE
62222011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6223
6224 Integer overflow fixes.
c8a9ca5a 6225
08686060
PE
6226 * dbusbind.c: Serial number integer overflow fixes.
6227 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6228 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6229 to hold a serial number that is too large for a fixnum.
6230 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6231 Check for serial numbers out of range. Decode any serial number
59568bf0 6232 that was so large that it became a float. (Bug#8722)
08686060 6233
2d1fc3c7
PE
6234 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6235 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6236 Use XFASTINT rather than XUINT when numbers are nonnegative.
6237 (xd_append_arg, Fdbus_method_return_internal):
6238 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6239 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6240 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6241 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6242 (Bug#8722)
2d1fc3c7 6243
c8a9ca5a
PE
6244 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6245
519e1d69
PE
6246 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6247
6df6ae42 6248 ccl: Add integer overflow checks.
30569699
PE
6249 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6250 (IN_INT_RANGE): New macros.
6251 (ccl_driver): Use them to check for integer overflow when
6252 decoding a CCL program. Many of the new checks are whether XINT (x)
6253 fits in int; it doesn't always, on 64-bit hosts. The new version
6254 doesn't catch all possible integer overflows, but it's an
847044ea 6255 improvement. (Bug#8719)
30569699 6256
c11285dc
PE
6257 * alloc.c (make_event_array): Use XINT, not XUINT.
6258 There's no need for unsigned here.
6259
fdccd48e
PE
6260 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6261 This follows up to the 2011-05-06 change that substituted uintptr_t
6262 for EMACS_INT. This case wasn't caught back then.
6263
37910ab2
PE
6264 Rework Fformat to avoid integer overflow issues.
6265 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6266 now (part of C89). Include <verify.h>.
6267 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6268 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6269 (Fformat): Avoid the prepass trying to compute sizes; it was only
6270 approximate and thus did not catch overflow reliably. Instead, walk
6271 through the format just once, formatting and computing sizes as we go,
6272 checking for integer overflow at every step, and allocating a larger
6273 buffer as needed. Keep track separately whether the format is
6274 multibyte. Keep only the most-recently calculated precision, rather
6275 than them all. Record whether each argument has been converted to
6276 string. Use EMACS_INT, not int, for byte and char and arg counts.
6277 Support field widths and precisions larger than INT_MAX. Avoid
6278 sprintf's undefined behavior with conversion specifications such as %#d
6279 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6280 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6281 formatting out-of-range floating point numbers with int
9173deec 6282 formats. (Bug#8668)
37910ab2 6283
2e6578fb
PE
6284 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6285
0ae6bdee
PE
6286 * data.c: Avoid integer truncation in expressions involving floats.
6287 * data.c: Include <intprops.h>.
6288 (arith_driver): When there's an integer overflow in an expression
6289 involving floating point, convert the integers to floating point
6290 so that the resulting value does not suffer from catastrophic
6291 integer truncation. For example, on a 64-bit host (* 4
6292 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6293 Do not rely on undefined behavior after integer overflow.
6294
de883a70
PE
6295 merge count_size_as_multibyte, parse_str_to_multibyte
6296 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6297 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6298 Check for integer overflow.
6299 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6300 since it's now a duplicate of the other. This is more of
6301 a character than a buffer op, so better that it's in character.c.
6302 * fns.c, print.c: Adjust to above changes.
6303
2ff916cb
PE
63042011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6305
6306 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6307
f1b54466
PE
63082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6309
fb1ac845
PE
6310 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6311 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6312 (x_clipboard_manager_save): Now static.
6313 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6314
f1b54466
PE
6315 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6316 (crypto_hash_function): Now static.
6317 Fix pointer signedness problems. Avoid unnecessary initializations.
6318
a9f737ee
CY
63192011-05-27 Chong Yidong <cyd@stupidchicken.com>
6320
6321 * termhooks.h (Vselection_alist): Make it terminal-local.
6322
6323 * terminal.c (create_terminal): Initialize it.
6324
6325 * xselect.c: Support for clipboard managers.
6326 (Vselection_alist): Move to termhooks.h as terminal-local var.
6327 (LOCAL_SELECTION): New macro.
6328 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6329 (symbol_to_x_atom): Remove gratuitous arg.
6330 (x_handle_selection_request, lisp_data_to_selection_data)
6331 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6332 (x_own_selection, x_get_local_selection, x_convert_selection):
6333 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6334 (some_frame_on_display): Delete unused function.
6335 (Fx_own_selection_internal, Fx_get_selection_internal)
6336 (Fx_disown_selection_internal, Fx_selection_owner_p)
6337 (Fx_selection_exists_p): New optional frame arg.
6338 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6339 (x_handle_selection_clear): Don't treat other terminals with the
6340 same keyboard specially. Use the terminal-local Vselection_alist.
6341 (x_clear_frame_selections): Use Frun_hook_with_args.
6342
6343 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6344
6345 * xterm.h: Add support for those atoms.
6346
e067f0c1
CY
63472011-05-26 Chong Yidong <cyd@stupidchicken.com>
6348
6349 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6350 (converted_selections, conversion_fail_tag): New global variables.
6351 (x_selection_request_lisp_error): Free the above.
6352 (x_get_local_selection): Remove unnecessary code.
6353 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6354 of converted selections stored in converted_selections.
6355 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6356 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6357 (x_convert_selection): New function.
6358 (x_handle_selection_event): Simplify.
6359 (x_get_foreign_selection): Don't ignore incoming requests while
6360 waiting for an answer; this will fail when we implement
6361 SAVE_TARGETS, and seems unnecessary anyway.
6362 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6363 (Vx_sent_selection_functions): Doc fix.
6364
0f4aebc0
LL
63652011-05-26 Leo Liu <sdl.web@gmail.com>
6366
6367 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6368
e61124cd
YM
63692011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6370
6371 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6372
6373 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6374 for fringe update if it has periodic bitmap.
ac389d0c 6375 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6376 and fringe_bitmap_periodic_p.
6377
6378 * fringe.c (get_fringe_bitmap_data): New function.
6379 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6380 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6381 row. Mark glyph row for fringe update if periodicity changed.
6382
6383 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6384 for fringe update unless it has periodic bitmap.
6385
f16d9837
KH
63862011-05-25 Kenichi Handa <handa@m17n.org>
6387
6388 * xdisp.c (get_next_display_element): Set correct it->face_id for
6389 a static composition.
6390
e1b90ef6
LL
63912011-05-24 Leo Liu <sdl.web@gmail.com>
6392
6393 * deps.mk (fns.o):
6394 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6395
6396 * fns.c (crypto_hash_function, Fsha1): New function.
6397 (Fmd5): Use crypto_hash_function.
6398 (syms_of_fns): Add Ssha1.
6399
7400048f
PE
64002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6401
6402 * gnutls.c: Remove unused macros.
6403 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6404 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6405 Remove macros that are defined and never used.
6406 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6407
abb71cf4
CY
64082011-05-22 Chong Yidong <cyd@stupidchicken.com>
6409
6410 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6411 (Fx_get_selection_internal): Minor cleanup.
6412 (Fx_own_selection_internal): Rename arguments for consistency with
6413 select.el.
6414
6307db39
PE
64152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6416
6417 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6418
f3d4e0a4
CY
64192011-05-22 Chong Yidong <cyd@stupidchicken.com>
6420
6421 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6422
4d8ade89
YM
64232011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6424
6425 * dispnew.c (scrolling_window): Don't exclude the case that the
6426 last enabled row in the desired matrix touches the bottom boundary.
6427
32078c8d
GM
64282011-05-21 Glenn Morris <rgm@gnu.org>
6429
6430 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6431 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6432 and add some more files.
32078c8d 6433
7285dc67
EZ
64342011-05-20 Eli Zaretskii <eliz@gnu.org>
6435
6436 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6437 report_file_error introduced by the change from 2011-05-07.
6438
89d1bd22
PE
64392011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6440
6441 * systime.h (Time): Define only if emacs is defined.
6442 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6443 where the include path doesn't have X11/X.h by default. See
6444 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6445
cd394be1 64462011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6447
6448 * composite.c (find_automatic_composition): Fix previous change.
6449
b9704ad9
GM
64502011-05-20 Glenn Morris <rgm@gnu.org>
6451
6452 * lisp.mk: New file, split from Makefile.in.
6453 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6454 (shortlisp): Remove.
6455 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6456
4a720484
GM
64572011-05-19 Glenn Morris <rgm@gnu.org>
6458
6459 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6460 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6461 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6462 (lisp): Set the order to that of loadup.el.
6463 (shortlisp): Make it a copy of $lisp.
6464 (SOME_MACHINE_LISP): Remove.
6465 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6466 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6467
a28d4396
KH
64682011-05-18 Kenichi Handa <handa@m17n.org>
6469
6470 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6471 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6472 (find_automatic_composition): Mostly rewrite for efficiency.
6473
a2b1fa8e
JB
64742011-05-18 Juanma Barranquero <lekktu@gmail.com>
6475
6476 * makefile.w32-in: Update dependencies.
6477
8e1f5610
CS
64782011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6479
6480 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6481 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6482
7025ee00 64832011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6484
cdfa6eab
PE
6485 Fix some integer overflow issues, such as string length overflow.
6486
06d6db33
PE
6487 * insdel.c (count_size_as_multibyte): Check for string overflow.
6488
2b4560a8
PE
6489 * character.c (lisp_string_width): Check for string overflow.
6490 Use EMACS_INT, not int, for string indexes and lengths; in
6491 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6492 the resulting string length overflows an EMACS_INT; instead,
6493 report a string overflow if no precision given. When checking for
6494 precision exhaustion, use a check that cannot possibly have
6495 integer overflow. (Bug#8675)
6496 * character.h (lisp_string_width): Adjust to new signature.
6497
cb93f9be
PE
6498 * alloc.c (string_overflow): New function.
6499 (Fmake_string): Use it. This doesn't change behavior, but saves
6500 a few bytes and will simplify future changes.
6501 * character.c (string_escape_byte8): Likewise.
6502 * lisp.h (string_overflow): New decl.
6503
1a1f3366
PE
6504 Fixups, following up to the user-interface timestamp change.
6505 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6506 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6507 * msdos.c (mouse_get_pos): Likewise.
6508 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6509 * w32gui.h (Time): Define by including "systime.h" rather than by
6510 declaring it ourselves. (Bug#8664)
6511
d4e3e4d3
PE
6512 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6513 * image.c (clear_image_cache): Likewise.
6514
f6a24d19
PE
6515 * term.c (term_mouse_position): Don't assume time_t wraparound.
6516
08dc5ae6
PE
6517 Be more systematic about user-interface timestamps.
6518 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6519 and sometimes 'EMACS_UINT', to represent these timestamps.
6520 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6521 This makes the code easier to follow, and makes it easier to catch
6522 integer overflow bugs such as Bug#8664.
6523 * frame.c (Fmouse_position, Fmouse_pixel_position):
6524 Use Time, not unsigned long, for user-interface timestamps.
6525 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6526 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6527 * keyboard.h (last_event_timestamp): Likewise.
6528 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6529 * menu.h (xmenu_show): Likewise.
6530 * term.c (term_mouse_position): Likewise.
6531 * termhooks.h (struct input_event.timestamp): Likewise.
6532 (struct terminal.mouse_position_hook): Likewise.
6533 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6534 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6535 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6536 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6537 what it was before.
6538 * menu.h, termhooks.h: Include "systime.h", for Time.
6539
8e55734a
PE
6540 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6541 Don't assume that the difference between two unsigned long values
6542 can fit into an integer. At this point, we know button_down_time
6543 <= event->timestamp, so the difference must be nonnegative, so
6544 there's no need to cast the result if double-click-time is
6545 nonnegative, as it should be; check that it's nonnegative, just in
6546 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6547 apart (about 25 days). (Bug#8664)
8e55734a 6548
841f1b75 6549 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6550 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6551
3e26f69c
PE
6552 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6553 that always fit in int. Use a sentinel instead of a counter, to
6554 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6555 * frame.h (struct frame): Use int for menu_bar_items_used
6556 instead of EMACS_INT, since it always fits in int.
3e26f69c 6557
5cc152c0
PE
6558 * menu.c (grow_menu_items): Check for int overflow.
6559
d89eb65e
PE
6560 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6561
5235bd3e
PE
6562 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6563 Before, the code was not consistent. These values cannot exceed
6564 2**31 - 1 so there's no need to make them unsigned.
6565 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6566 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6567 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6568 as modifiers.
6569 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6570
bc827e23
PE
6571 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6572 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6573 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6574 presumably because the widths might not match.
6575
78eb494e
PE
6576 * window.c (size_window): Avoid needless test at loop start.
6577
04f2d78b
CB
65782011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6579
6580 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6581
d2fc7e3d 65822011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6583
6584 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6585
d2fc7e3d 65862011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6587
6588 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6589 `width' to `bar_area_x' and `bar_area_width', respectively.
6590 (x_scroll_run): Take account of fringe background extension.
6591
04f2d78b
CB
6592 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6593 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6594 `bar_area_width', respectively.
6595 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6596 background extension.
6597
79b70037
GM
65982011-05-10 Jim Meyering <meyering@redhat.com>
6599
6600 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6601
2f142cc5
JB
66022011-05-10 Juanma Barranquero <lekktu@gmail.com>
6603
6604 * image.c (Finit_image_library): Return t for built-in image types,
6605 like pbm and xbm. (Bug#8640)
6606
57679c86
AS
66072011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6608
6609 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6610
888c9e86
EZ
66112011-05-07 Eli Zaretskii <eliz@gnu.org>
6612
b0512a1d
EZ
6613 * w32console.c (Fset_screen_color): Doc fix.
6614 (Fget_screen_color): New function.
6615 (syms_of_ntterm): Defsubr it.
6616
7285dc67
EZ
6617 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6618 unlink the temporary file if Fcall_process didn't create it in the
6619 first place.
6620 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6621 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6622 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6623 cue to call_process_cleanup not to close that handle.
6624
4d3fcc8e
BK
66252011-05-07 Ben Key <bkey76@gmail.com>
6626
6627 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6628 one of two shell specific rules, either bootstrap-temacs-CMD or
6629 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6630 to the previous implementation of the bootstrap-temacs rule.
6631 The bootstrap-temacs-CMD rule is similar to the previous
6632 implementation of the bootstrap-temacs rule except that it
6633 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6634 variable.
6635
6636 These changes, along with some changes to nt/configure.bat,
6637 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6638 earlier fix to add support for --cflags and --ldflags options
6639 that include quotes so that it works whether make uses cmd or
6640 sh as the shell.
6641
b4289b64
MA
66422011-05-06 Michael Albinus <michael.albinus@gmx.de>
6643
6644 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6645 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6646 is a constant.
6647 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6648 a string. Handle both cases.
6649 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6650 (Fdbus_register_method): Use Qinvalid_function.
6651
af4c0e28
JB
66522011-05-06 Juanma Barranquero <lekktu@gmail.com>
6653
6654 * makefile.w32-in: Update dependencies.
6655 (LISP_H): Add inttypes.h and stdin.h.
6656 (PROCESS_H): Add unistd.h.
6657
c51453d9
EZ
66582011-05-06 Eli Zaretskii <eliz@gnu.org>
6659
6660 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6661 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6662
8ff0ac3c 66632011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6664
4c4b566b
PE
6665 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6666
aab2b9b5
PE
6667 * term.c (vfatal): Remove stray call to va_end.
6668 It's not needed and the C Standard doesn't allow it here anyway.
6669
c378da0b
PE
6670 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6671 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6672
288b08c7
PE
6673 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6674 bytes.
6675
e3601888
PE
6676 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6677
db6c0e74
PE
6678 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6679
dd5963ea
PE
6680 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6681
88c9450f
PE
6682 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6683
2f9442b8
PE
6684 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6685
c032b5f8
PE
6686 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6687 * charset.c (Fdefine_charset_internal): Don't initialize
6688 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6689 32-bit int (Bug#8600).
a108c10b
PE
6690
6691 * lread.c (read_integer): Be more consistent with string-to-number.
6692 Use string_to_number to do the actual conversion; this avoids
6693 rounding errors and fixes some other screwups. Without this fix,
6694 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6695 (digit_to_number): Move earlier, for benefit of read_integer.
6696 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6697 not a digit in any supported base. (Bug#8602)
a108c10b 6698
ad5f9eea
PE
6699 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6700
aec1708a
PE
6701 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6702 to match comment at start of function. This also removes a
6703 GCC warning about overflow in a 32+64-bit port.
6704
47be4ab5
PE
6705 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6706
371cac43
PE
6707 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6708 Reported by Stefan Monnier in
6709 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6710 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6711 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6712
d01a7826
PE
6713 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6714 (EMACS_UINTPTR): Likewise, with uintptr_t.
6715
7fd47d5c
PE
6716 * lisp.h: Prefer 64-bit EMACS_INT if available.
6717 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6718 on 32-bit hosts that have 64-bit int, so that they can access
6719 large files.
122b0c86
PE
6720 However, temporarily disable this change unless the temporary
6721 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6722
8727937b
PE
6723 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6724
8ac068ac
PE
6725 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6726 This removes an assumption that EMACS_INT and long are the same
6727 width as pointers. The assumption is true for Emacs porting targets
6728 now, but we want to make other targets possible.
6729 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6730 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6731 In the rest of the code, change types of integers that hold casted
6732 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6733 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6734 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6735 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6736 No need to cast type when ORing.
6737 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6738 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6739 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6740 assume EMACS_INT is the same width as char *.
6741 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6742 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6743 Remove no-longer-needed casts.
6744 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6745 (xg_tool_bar_help_callback, xg_make_tool_item):
6746 Use EMACS_INTPTR to hold an integer
6747 that will be cast to void *; this can avoid a GCC warning
6748 if EMACS_INT is not the same width as void *.
6749 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6750 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6751 (current_message_1, set_message_1):
6752 Use a local to convert to proper width without a cast.
6753 * xmenu.c (dialog_selection_callback): Likewise.
6754
ede49d71
PE
6755 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6756 Also, don't assume VALBITS / RAND_BITS is less than 5,
6757 and don't rely on undefined behavior when shifting a 1 left into
6758 the sign bit.
6759 * lisp.h (get_random): Change signature to match.
6760
2f30ecd0
PE
6761 * lread.c (hash_string): Use size_t, not int, for hash computation.
6762 Normally we prefer signed values; but hashing is special, because
6763 it's better to use unsigned division on hash table sizes so that
6764 the remainder is nonnegative. Also, size_t is the natural width
6765 for hashing into memory. The previous code used 'int', which doesn't
6766 retain enough info to hash well into very large tables.
6767 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6768
2a866e7b
PE
6769 * dbusbind.c: Don't possibly lose pointer info when converting.
6770 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6771 Use XPNTR rather than XHASH, so that the high-order bits of
6772 the pointer aren't lost when converting through void *.
6773
51639eac
PE
6774 * eval.c (Fautoload): Don't double-shift a pointer.
6775
92394119
PE
6776 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6777
dbdb9a7c
JB
67782011-05-06 Juanma Barranquero <lekktu@gmail.com>
6779
6780 * gnutls.c (DEF_GNUTLS_FN):
6781 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6782
db7a0b4f
AS
67832011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6784
6785 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6786 marker. (Bug#8610)
6787
cd394be1 67882011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6789
6790 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6791 New version that can reserve upto 2GB of heap space.
6792
f7ff1b0f 67932011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6794
6795 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6796
639c109b
TZ
67972011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6798
6799 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6800 `gnutls_certificate_set_x509_key_file'.
6801
d2127135
JB
68022011-05-05 Juanma Barranquero <lekktu@gmail.com>
6803
6804 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6805 Update dependencies.
6806
e968f4f3
JB
68072011-05-04 Juanma Barranquero <lekktu@gmail.com>
6808
6809 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6810 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6811 Remove unused parameter `fildes'.
6812 * process.c (read_process_output, send_process): Don't pass it.
6813
84d358f0
JB
68142011-05-04 Juanma Barranquero <lekktu@gmail.com>
6815
6816 Fix previous change: the library cache is defined in w32.c.
6817 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6818 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6819
0898ca10
JB
68202011-05-04 Juanma Barranquero <lekktu@gmail.com>
6821
6822 Implement dynamic loading of GnuTLS on Windows.
6823
6824 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6825 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6826 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6827 Declare.
6828
6829 * gnutls.c (Qgnutls_dll): Define.
6830 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6831 (gnutls_*): Declare function pointers.
6832 (init_gnutls_functions): New function to initialize function pointers.
6833 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6834 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6835 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6836 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6837 (emacs_gnutls_write, emacs_gnutls_read)
6838 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6839 (Fgnutls_available_p): New function.
6840 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6841 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6842 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6843
6844 * image.c: Include w32.h.
6845 (Vimage_type_cache): Delete.
6846 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6847 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6848 (w32_delayed_load): Move to w32.c.
6849
6850 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6851
6852 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6853 (w32_delayed_load): Move from image.c. When loading a library, record
6854 its filename in the :loaded-from property of the library id.
6855 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6856 Initialize and staticpro them.
6857 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6858
6859 * process.c: Include lisp.h before w32.h, not after.
6860 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6861 instead of gnutls_record_check_pending.
6862
6863 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6864
ff4de4aa
TZ
68652011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6866
6867 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6868 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6869 as passed in.
6870
abe95abb
JD
68712011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6872
6873 * xterm.c (x_set_frame_alpha): Do not set property on anything
6874 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6875
e16e55d4
JB
68762011-05-02 Juanma Barranquero <lekktu@gmail.com>
6877
6878 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6879
bafcf6a5
JB
68802011-05-02 Juanma Barranquero <lekktu@gmail.com>
6881
6882 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6883 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6884 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6885 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6886 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6887 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6888 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6889 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6890 (Qgnutls_bootprop_callbacks_verify): Make static.
6891
e7a6747f
AS
68922011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6893
19ed11ba
AS
6894 * callproc.c: Indentation fixup.
6895
e7a6747f 6896 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6897 (wait_for_termination, interruptible_wait_for_termination):
6898 Move after wait_for_termination_1.
e7a6747f 6899
1ef14cb4
LMI
69002011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6901
6902 * sysdep.c (interruptible_wait_for_termination): New function
6903 which is like wait_for_termination, but allows keyboard
6904 interruptions.
6905
6906 * callproc.c (Fcall_process): Add (:file "file") as an option for
6907 the STDOUT buffer.
6908 (Fcall_process_region): Ditto.
6909
330d880c
EZ
69102011-04-30 Eli Zaretskii <eliz@gnu.org>
6911
8db90b73
EZ
6912 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6913 rather than `XVECTOR (FOO)->size'.
6914
330d880c
EZ
6915 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6916 inttypes.h, as a gnulib replacement is used if it not available in
6917 system headers.
6918
15cbd324
EZ
69192011-04-21 Eli Zaretskii <eliz@gnu.org>
6920
6921 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6922 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6923 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6924
6925 * coding.c (coding_alloc_by_realloc): Error out if destination
6926 will grow beyond MOST_POSITIVE_FIXNUM.
6927 (decode_coding_emacs_mule): Abort if there isn't enough place in
6928 charbuf for the composition carryover bytes. Reserve an extra
6929 space for up to 2 characters produced in a loop.
6930 (decode_coding_iso_2022): Abort if there isn't enough place in
6931 charbuf for the composition carryover bytes.
6932
69332011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6934
ae940cca
EZ
6935 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6936 aborting when %lld or %lll format is passed.
6937 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6938 %llo or %llx format is passed. (Bug#8545)
6939
03ab8921
EZ
6940 * window.c (window_scroll_line_based): Use a marker instead of
6941 simple variables to record original value of point. (Bug#7952)
6942
afda1437
EZ
6943 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6944 produced by %s or %c overflows available buffer space. (Bug#8545)
6945
f76dee0c
PE
69462011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6947
6948 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6949 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6950
fdc5744d
JB
69512011-04-28 Juanma Barranquero <lekktu@gmail.com>
6952
6953 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6954
638f053a
JB
69552011-04-28 Juanma Barranquero <lekktu@gmail.com>
6956
6957 * keyboard.c (Qdelayed_warnings_hook): Define.
6958 (command_loop_1): Run `delayed-warnings-hook'
6959 if Vdelayed_warnings_list is non-nil.
6960 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6961 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6962
d178f871
EZ
69632011-04-28 Eli Zaretskii <eliz@gnu.org>
6964
6965 * doprnt.c (doprnt): Don't return value smaller than the buffer
6966 size if the message was truncated. (Bug#8545).
6967
b124fd93
JB
69682011-04-28 Juanma Barranquero <lekktu@gmail.com>
6969
6970 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6971 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6972
e810457d
PE
69732011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6974
6975 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6976
ea51cceb
JB
69772011-04-27 Juanma Barranquero <lekktu@gmail.com>
6978
6979 * makefile.w32-in: Update dependencies.
6980
94dcfacf
EZ
69812011-04-27 Eli Zaretskii <eliz@gnu.org>
6982
6983 Improve `doprnt' and its usage. (Bug#8545)
6984 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6985 `format_end'. Remove support for %l as a conversion specifier.
6986 Don't use xrealloc. Improve diagnostics when the %l size modifier
6987 is used. Update the commentary.
6988
6989 * eval.c (verror): Simplify calculation of size_t.
6990
6991 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6992 messages.
6993
f61f41d7
PE
69942011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6995
6996 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6997 change.
6998
96fb4434
PE
69992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7000
7001 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7002 This makes this file independent of the recent pseudovector change.
7003
671875da 70042011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7005
69e9b5a3
PE
7006 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7007
b5f869a7 7008 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7009 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7010 Remove unused local.
c8926152 7011 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7012
841a1577 7013 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7014 GCC 4.6.0 optimizes based on type-based alias analysis.
7015 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7016 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7017 != &v->size, and therefore "v->size = 1; b->size = 2; return
7018 v->size;" must therefore return 1. This assumption is incorrect
7019 for Emacs, since it type-puns struct Lisp_Vector * with many other
7020 types. To fix this problem, this patch adds a new type struct
f904488f 7021 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7022 and pseudovectors, and helps optimizing compilers not get fooled
7023 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7024 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7025 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7026 the size member.
eab3844f
PE
7027 (XSETPVECTYPE): Rewrite in terms of new macro.
7028 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7029 This is a bit clearer, and further avoids the possibility of
7030 undesirable aliasing.
7031 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7032 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7033 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7034 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7035 (ASIZE): Now uses header.size rather than size.
7036 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7037 to avoid the hassle of writing XVECTOR (foo)->header.size.
7038 (struct vectorlike_header): New type.
eab3844f
PE
7039 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7040 object, to help avoid aliasing.
7041 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7042 (SUBRP): Likewise, since Lisp_Subr is a special case.
7043 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7044 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7045 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7046 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7047 changed to be "header.size" and "header.next".
7048 * buffer.h (struct buffer): Likewise.
7049 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7050 * frame.h (struct frame): Likewise.
7051 * process.h (struct Lisp_Process): Likewise.
7052 * termhooks.h (struct terminal): Likewise.
7053 * window.c (struct save_window_data, struct saved_window): Likewise.
7054 * window.h (struct window): Likewise.
7055 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7056 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7057 * buffer.c (init_buffer_once): Likewise.
7058 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7059 special case.
7060 * process.c (Fformat_network_address): Use local var for size,
7061 for brevity.
7062
0df1eac5
PE
7063 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7064
847ab9d1 7065 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7066 * data.c (atof): Remove decl; no longer used or needed.
7067 (digit_to_number): Move to lread.c.
7068 (Fstring_to_number): Use new string_to_number function, to be
7069 consistent with how the Lisp reader treats infinities and NaNs.
7070 Do not assume that floating-point numbers represent EMACS_INT
7071 without losing information; this is not true on most 64-bit hosts.
7072 Avoid double-rounding errors, by insisting on integers when
7073 parsing non-base-10 numbers, as the documentation specifies.
7074 * lisp.h (string_to_number): New decl, replacing ...
7075 (isfloat_string): Remove.
bc0a5c13 7076 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7077 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7078 appears to have been a coding error. Similarly, do not accept
7079 strings like +-1e0 as floating point numbers. Do not report
7080 overflow for integer overflows unless the base is not 10 which
7081 means we have no simple and reliable way to continue.
7082 Break out the floating-point parsing into a new
7083 function string_to_number, so that Fstring_to_number parses
7084 floating point numbers consistently with the Lisp reader.
04f2d78b 7085 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7086 (E_CHAR, EXP_INT): Remove, replacing with ...
7087 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7088 (string_to_number): New function, replacing isfloat_string.
7089 This function checks for valid syntax and produces the resulting
7090 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7091 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7092 so that overflow for non-base-10 numbers is reported only when
7093 there's no portable and simple way to convert to floating point.
452f4150 7094
67769ffc
PE
7095 * textprop.c (set_text_properties_1): Rewrite for clarity,
7096 and to avoid GCC warning about integer overflow.
7097
c20db43f
PE
7098 * intervals.h (struct interval): Use EMACS_INT for members
7099 where EMACS_UINT might cause problems. See
7100 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7101 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7102 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7103 All uses changed.
37aa2f85
PE
7104 (offset_intervals): Tell GCC not to worry about length overflow
7105 when negating a negative length.
c20db43f 7106
2538aa2f
PE
7107 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7108 (overrun_check_free): Likewise.
7109
f2d3008d
PE
7110 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7111 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7112 word size.
7113
ec8df744
PE
7114 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7115 (gnutls_make_error): Rename local to avoid shadowing.
7116 (gnutls_emacs_global_deinit): ifdef out; not used.
7117 (Fgnutls_boot): Use const for pointer to readonly storage.
7118 Comment out unused local. Fix pointer signedness problems.
7119
640ee02d
PE
7120 * lread.c (openp): Don't stuff size_t into an 'int'.
7121 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7122 about possible signed overflow.
7123
6048fb2a
PE
7124 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7125 (GDK_KEY_g): Don't define if already defined.
7126 (xg_prepare_tooltip): Avoid pointer signedness problem.
7127 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7128
fa3c87e1
PE
7129 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7130 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7131
2172544b
PE
7132 * xfns.c (Fx_window_property): Simplify a bit,
7133 to make a bit faster and to avoid GCC 4.6.0 warning.
7134 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7135
9b821a21
PE
7136 * fns.c (internal_equal): Don't assume size_t fits in int.
7137
3c616cfa
PE
7138 * alloc.c (compact_small_strings): Tighten assertion a little.
7139
c2982e87
PE
7140 Replace pEd with more-general pI, and fix some printf arg casts.
7141 * lisp.h (pI): New macro, generalizing old pEd macro to other
7142 conversion specifiers. For example, use "...%"pI"d..." rather
7143 than "...%"pEd"...".
7144 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7145 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7146 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7147 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7148 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7149 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7150 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7151 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7152 64-bit hosts.
7153 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7154 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7155 * print.c (safe_debug_print, print_object): Likewise.
7156 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7157 to int.
6f04d126
PE
7158 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7159 avoiding the 0 flag, which is not portable.
c2982e87
PE
7160 * process.c (Fmake_network_process): Use pI to avoid cast.
7161 * region-cache.c (pp_cache): Likewise.
7162 * xdisp.c (decode_mode_spec): Likewise.
7163 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7164 behavior on 64-bit hosts with printf arg.
6f04d126 7165 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7166 (x_stop_queuing_selection_requests): Likewise.
7167 (x_get_window_property): Don't truncate byte count to an 'int'
7168 when tracing.
0b432f21 7169
5e073ec7
PE
7170 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7171 here, since it parses constructs like leading '-' and spaces,
7172 which are not wanted; and it overflows with large numbers.
7173 Instead, simply match F[0-9]+, which is what is wanted anyway.
7174
36372bf9
PE
7175 * alloc.c: Remove unportable assumptions about struct layout.
7176 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7177 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7178 (allocate_vectorlike, make_pure_vector): Use the new macros,
7179 plus offsetof, to remove unportable assumptions about struct layout.
7180 These assumptions hold on all porting targets that I know of, but
7181 they are not guaranteed, they're easy to remove, and removing them
7182 makes further changes easier.
7183
0b432f21
PE
7184 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7185 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7186 (string_overrun_cookie): Now const. Use initializers that
7187 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7188 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7189 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7190 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7191 multiple of sizeof (EMACS_INT); it need not be, if
7192 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7193 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7194
895009e1
JB
71952011-04-26 Juanma Barranquero <lekktu@gmail.com>
7196
7197 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7198
6a7a1b0b
TZ
71992011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7200
7201 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7202 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7203 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7204
841a1577 72052011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7206
7207 * lisp.h (Qdebug): List symbol.
895009e1 7208 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7209 * keyboard.c (debug-on-event): New variable.
7210 (handle_user_signal): Break into debugger when debug-on-event
7211 matches the current signal symbol.
7212
f2d3ba6f
DN
72132011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7214
7215 * alloc.c (check_sblock, check_string_bytes)
7216 (check_string_free_list): Convert to standard C.
7217
42ce4c63
TZ
72182011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7219
7220 * w32.c (emacs_gnutls_push): Fix typo.
7221
825cd63c
EZ
72222011-04-25 Eli Zaretskii <eliz@gnu.org>
7223
fb11d64d
EZ
7224 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7225 "cast to pointer from integer of different size".
7226
825cd63c
EZ
7227 Improve doprnt and its use in verror. (Bug#8545)
7228 * doprnt.c (doprnt): Document the set of format control sequences
7229 supported by the function. Use SAFE_ALLOCA instead of always
7230 using `alloca'.
7231
7232 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7233 is one byte too soon. Don't use xrealloc; instead xfree and
7234 xmalloc anew.
7235
e061a11b
TZ
72362011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7237
7238 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7239 callbacks stage.
7240
7241 * gnutls.c: Renamed global_initialized to
7242 gnutls_global_initialized. Added internals for the
7243 :verify-hostname-error, :verify-error, and :verify-flags
7244 parameters of `gnutls-boot' and documented those parameters in the
7245 docstring. Start callback support.
9173deec
JB
7246 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7247 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7248 on error. Return error code.
e061a11b
TZ
7249 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7250 (emacs_gnutls_read): Likewise.
7251 (Fgnutls_boot): Return handshake error code.
7252 (emacs_gnutls_handle_error): New function.
7253 (wsaerror_to_errno): Likewise.
7254
7255 * w32.h (emacs_gnutls_pull): Add prototype.
7256 (emacs_gnutls_push): Likewise.
7257
7258 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7259 (emacs_gnutls_push): Likewise.
7260
72612011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7262
7263 * process.c (wait_reading_process_output): Check if GnuTLS
7264 buffered some data internally if no FDs are set for TLS
7265 connections.
7266
7267 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7268 (LIBS): Link to USER_LIBS.
7269 ($(BLD)/gnutls.$(0)): New target.
7270
fa6996bc
EZ
72712011-04-24 Eli Zaretskii <eliz@gnu.org>
7272
eb35682e
EZ
7273 * xdisp.c (handle_single_display_spec): Rename the
7274 display_replaced_before_p argument into display_replaced_p, to
7275 make it consistent with the commentary. Fix typos in the
7276 commentary.
7277
e2ad650c
EZ
7278 * textprop.c (syms_of_textprop): Remove dead code.
7279 (copy_text_properties): Delete obsolete commentary about an
7280 interface that was deleted long ago. Fix typos in the description
7281 of arguments.
7282
1b2de274
EZ
7283 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7284 to changes in oldXMenu/XMenu.h from 2011-04-16.
7285 <menu_help_message, prev_menu_help_message>: Constify.
7286 (IT_menu_make_room): menu->help_text is now `const char **';
7287 adjust.
7288
7289 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7290 to changes in oldXMenu/XMenu.h from 2011-04-16.
7291 (struct XMenu): Declare `help_text' `const char **'.
7292
7293 * xfaces.c <Qunspecified>: Make extern again.
7294
7295 * syntax.c: Include sys/types.h before including regex.h, as
7296 required by Posix.
7297
762b15be
EZ
7298 * doc.c (get_doc_string): Improve the format passed to `error'.
7299
7300 * doprnt.c (doprnt): Improve commentary.
7301
7302 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7303
7304 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7305 them with etags.
7306
f1052e5d
EZ
7307 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7308 changes in globals.h immediately force recompilation.
762b15be
EZ
7309 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7310 $(CURDIR)/s/ms-w32.h.
7311 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7312
fa6996bc
EZ
7313 * character.c (Fchar_direction): Function deleted.
7314 (syms_of_character): Don't defsubr it.
7315 <char-direction-table>: Deleted.
7316
e6c3da20
EZ
73172011-04-23 Eli Zaretskii <eliz@gnu.org>
7318
7319 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7320 * doprnt.c: Include limits.h.
7321 (SIZE_MAX): New macro.
04f2d78b
CB
7322 (doprnt): Return a size_t value. 2nd arg is now size_t.
7323 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7324 Improve overflow protection. Support `l' modifier for integer
7325 conversions. Support %l conversion. Don't assume an EMACS_INT
7326 argument for integer conversions and for %c.
7327
7328 * lisp.h (doprnt): Restore prototype.
7329
7330 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7331 $(SRC)/character.h.
7332
7333 * Makefile.in (base_obj): Add back doprnt.o.
7334
7335 * deps.mk (doprnt.o): Add back prerequisites.
7336 (callint.o): Depend on character.h.
7337
7338 * eval.c (internal_lisp_condition_case): Include the handler
7339 representation in the error message.
7340 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7341 when breaking from the loop.
7342
7343 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7344
7345 * callint.c (Fcall_interactively): When displaying error message
7346 about invalid control letter, pass the character's codepoint, not
7347 a pointer to its multibyte form. Improve display of the character
7348 in octal and display also its hex code.
7349
7350 * character.c (char_string): Use %x to display the (unsigned)
7351 codepoint of an invalid character, to avoid displaying a bogus
7352 negative value.
7353
7354 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7355 `error', not SYMBOL_NAME itself.
7356
7357 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7358 character arguments to `error'.
7359
7360 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7361 to `error' in error message about FINAL_CHAR argument. Make sure
7362 FINAL_CHAR is a character, and use %c when it is passed as
7363 argument to `error'.
7364
4ffd0d6b 73652011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7366
7367 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7368
7369 * w32.c: Include <time.h>.
7370 (sys_localtime): New function.
7371
4ffd0d6b 73722011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7373
7374 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7375
4ffd0d6b 7376 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7377
4ffd0d6b 73782011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7379
4ffd0d6b
GM
7380 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7381 zombies (Bug#8467).
aac0c6e3 7382
04c56954
EZ
73832011-04-19 Eli Zaretskii <eliz@gnu.org>
7384
7385 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7386 gl_state.e_property when gl_state.object is Qt.
7387
7388 * insdel.c (make_gap_larger): Remove limitation of buffer size
7389 to <= INT_MAX.
7390
16a43933
CY
73912011-04-18 Chong Yidong <cyd@stupidchicken.com>
7392
7393 * xdisp.c (lookup_glyphless_char_display)
7394 (produce_glyphless_glyph): Handle cons cell entry in
7395 glyphless-char-display.
7396 (Vglyphless_char_display): Document it.
7397
7398 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7399 glyphless-char-display.
7400
4581706e
CY
74012011-04-17 Chong Yidong <cyd@stupidchicken.com>
7402
7403 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7404
7405 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7406
7407 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7408 definition for no-X builds.
7409
4887c6e2 74102011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7411
fd35b6f9
PE
7412 Static checks with GCC 4.6.0 and non-default toolkits.
7413
5c1ccb01
PE
7414 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7415
006c5daa
PE
7416 * process.c (keyboard_bit_set): Define only if SIGIO.
7417 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7418 (send_process): Repair possible setjmp clobbering.
7419
efc736d3
PE
7420 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7421
4e2fe2e6
PE
7422 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7423
f97334a2
PE
7424 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7425
4e75f29d
PE
7426 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7427 Define only if needed.
7428
90efadd1
PE
7429 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7430 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7431 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7432
3c647824
PE
7433 * dispextern.h (struct redisplay_interface): Rename param
7434 to avoid shadowing.
e264f262 7435 * termhooks.h (struct terminal): Likewise.
761383f4 7436 * xterm.c (xembed_send_message): Likewise.
3c647824 7437
b58c5c4a
PE
7438 * insdel.c (make_gap_smaller): Define only if
7439 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7440
cad59032
PE
7441 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7442 it.
7443
c339dc2e
PE
7444 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7445 so that we aren't warned about unused symbols.
7446
91a3e27b
PE
7447 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7448
399c71d3 7449 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7450
8ffc96f5
PE
7451 * xfns.c (x_real_positions): Mark locals as initialized.
7452
eef9bc79
PE
7453 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7454
098db9dd
PE
7455 * xterm.c: Fix problems found by static analysis with other toolkits.
7456 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7457 (x_dispatch_event): Declare static if USE_GTK, and
7458 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7459 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7460 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7461 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7462 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7463
eb18f6cc
PE
7464 * xmenu.c (menu_help_callback): Pointer type fixes.
7465 Use const pointers when pointing at readonly data. Avoid pointer
7466 signedness clashes.
7467 (FALSE): Remove unused macro.
7468 (update_frame_menubar): Remove unused decl.
7469
1fe72bf8
PE
7470 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7471
60d9e1db
PE
7472 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7473 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7474 (single_menu_item): Rename local to avoid shadowing.
7475
39261c26
PE
7476 * keyboard.c (make_lispy_event): Remove unused local var.
7477
018c5e19
PE
7478 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7479 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7480
63d2b86e
PE
7481 * bitmaps: Change bitmaps from unsigned char back to the X11
7482 compatible char. Avoid the old compiler warnings about
7483 out-of-range initializers by using, for example, '\xab' rather
7484 than 0xab.
7485
aefd87e1
PE
7486 * xgselect.c (xgselect_initialize): Check vs interface
7487 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7488
bf501fb9
PE
7489 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7490
e9829fdf
PE
7491 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7492 to read-only memory.
7493
1086c095
PE
7494 * fns.c (vector): Remove; this old hack is no longer needed.
7495
2baccd04 7496 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7497 Remove unused var.
dde42981 7498 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7499
72391843 7500 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7501
436c16df 7502 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7503 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7504 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7505
92bb796d 7506 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7507 (x_term_init): Remove local to avoid shadowing.
92bb796d 7508
764430a3 7509 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7510
7511 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7512 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7513
d1dfb56c
EZ
75142011-04-16 Eli Zaretskii <eliz@gnu.org>
7515
c4354cb4
EZ
7516 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7517
d1dfb56c
EZ
7518 Fix regex.c, syntax.c and friends for buffers > 2GB.
7519 * syntax.h (struct gl_state_s): Declare character position members
7520 EMACS_INT.
7521
7522 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7523
04f2d78b
CB
7524 * textprop.c (verify_interval_modification, interval_of):
7525 Declare arguments EMACS_INT.
d1dfb56c
EZ
7526
7527 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7528 EMACS_INT.
7529
7530 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7531
7532 * indent.c (Fvertical_motion): Local variable it_start is now
7533 EMACS_INT.
7534
7535 * regex.c (re_match, re_match_2, re_match_2_internal)
7536 (bcmp_translate, regcomp, regexec, print_double_string)
7537 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7538 (re_compile_pattern, re_exec): Declare arguments and local
7539 variables `size_t' and `ssize_t' and return values `regoff_t', as
7540 appropriate.
7541 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7542 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7543 <compile_stack_type>: `size' and `avail' are now `size_t'.
7544
7545 * regex.h <regoff_t>: Use ssize_t, not int.
7546 (re_search, re_search_2, re_match, re_match_2): Arguments that
7547 specify buffer/string position and length are now ssize_t and
7548 size_t. Return type is regoff_t.
7549
613052cd
BK
75502011-04-16 Ben Key <bkey76@gmail.com>
7551
7552 * nsfont.m: Fixed bugs in ns_get_family and
7553 ns_descriptor_to_entity that were caused by using free to
7554 deallocate memory blocks that were allocated by xmalloc (via
7555 xstrdup). This caused Emacs to crash when compiled with
7556 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7557 --enable-checking=xmallocoverrun). xfree is now used to
7558 deallocate these memory blocks.
7559
4170f62f 75602011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7561
71b41406
PE
7562 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7563
9587a89d
PE
7564 emacs_write: Accept and return EMACS_INT for sizes.
7565 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7566 et seq.
7567 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7568 Accept and return EMACS_INT.
7569 (emacs_gnutls_write): Return the number of bytes written on
7570 partial writes.
7571 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7572 (emacs_read, emacs_write): Remove check for negative size, as the
7573 Emacs source code has been audited now.
9587a89d
PE
7574 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7575 (emacs_read, emacs_write): Use it.
273a5f82
PE
7576 * process.c (send_process): Adjust to the new signatures of
7577 emacs_write and emacs_gnutls_write. Do not attempt to store
7578 a byte offset into an 'int'; it might overflow.
9587a89d 7579 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7580
3e047f51
PE
7581 * sound.c: Don't assume sizes fit in 'int'.
7582 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7583 Return EMACS_INT, not int.
3e047f51 7584 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7585 Accept EMACS_INT, not int.
7586 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7587 record read return values.
7588
cc39a9db
BK
75892011-04-15 Ben Key <bkey76@gmail.com>
7590
c9d0ec6d
JB
7591 * keyboard.c (Qundefined): Don't declare static since it is used
7592 in nsfns.m.
7593 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7594 static since they are used in nsfont.m.
cc39a9db 7595
6c60eb9f
SM
75962011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7597
7598 * process.c (Qprocessp): Don't declare static.
7599 * lisp.h (Qprocessp): Declare again.
7600
7990b61a
JB
76012011-04-15 Juanma Barranquero <lekktu@gmail.com>
7602
7603 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7604
5d4cb038
PE
76052011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7606
8bd7b830 7607 Improve C-level modularity by making more things 'static'.
cd64ea1d 7608
e3b27b31
PE
7609 Don't publish debugger-only interfaces to other modules.
7610 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7611 (verify_bytepos, count_markers): Move decls to the only modules
7612 that need them.
7613 * region-cache.h (pp_cache): Likewise.
7614 * window.h (check_all_windows): Likewise.
7615 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7616
5d4cb038
PE
7617 * sysdep.c (croak): Now static, if
7618 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7619 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7620
7621 * alloc.c (refill_memory_reserve): Now static if
7622 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7623 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7624
e87b6180
PE
7625 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7626 Define only if USE_LUCID.
7627
ac64929e
PE
7628 * xrdb.c (x_customization_string, x_rm_string): Now static.
7629
6f37259d
PE
7630 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7631 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7632
1683e3ab
PE
7633 * xdisp.c (draw_row_with_mouse_face): Now static.
7634 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7635
de9c2632
PE
7636 * window.h (check_all_windows): Mark externally visible.
7637
2b96acb7
PE
7638 * window.c (window_deletion_count): Now static.
7639
7640 * undo.c: Make symbols static if they're not exported.
7641 (last_undo_buffer, last_boundary_position, pending_boundary):
7642 Now static.
7643
50436f33
PE
7644 * textprop.c (interval_insert_behind_hooks): Now static.
7645 (interval_insert_in_front_hooks): Likewise.
7646
64520e5c
PE
7647 * term.c: Make symbols static if they're not exported.
7648 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7649 (max_frame_lines, tty_set_terminal_modes):
7650 (tty_reset_terminal_modes, tty_turn_off_highlight):
7651 (get_tty_terminal): Now static.
7652 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7653 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7654 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7655 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7656 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7657
1fa53021
PE
7658 * sysdep.c: Make symbols static if they're not exported.
7659 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7660 Now static.
7661 (sigprocmask_set, full_mask): Remove; unused.
7662 (wait_debugging): Mark as visible.
7663 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7664 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7665
d4b43b22
PE
7666 * syntax.c (syntax_temp): Define only if !__GNUC__.
7667
b7c513d0
PE
7668 * sound.c (current_sound_device, current_sound): Now static.
7669
989b29ad
PE
7670 * search.c (searchbufs, searchbuf_head): Now static.
7671
13a55a78
PE
7672 * scroll.c (scroll_cost): Remove; unused.
7673 * dispextern.h (scroll_cost): Remove decl.
7674
de68a1fc
PE
7675 * region-cache.h (pp_cache): Mark as externally visible.
7676
40ccffa6
PE
7677 * process.c: Make symbols static if they're not exported.
7678 (process_tick, update_tick, create_process, chan_process):
7679 (Vprocess_alist, proc_buffered_char, datagram_access):
7680 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7681 (deactivate_process): Mark defn as static, as well as decl.
7682 * lisp.h (create_process): Remove decl.
7683 * process.h (chan_process, Vprocess_alist): Remove decls.
7684
ad64fc97
PE
7685 * print.c: Make symbols static if they're not exported.
7686 (print_depth, new_backquote_output, being_printed, print_buffer):
7687 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7688 (print_interval, print_number_index, initial_stderr_stream):
7689 Now static.
7690 * lisp.h (Fprinc): Remove decl.
7691 (debug_output_compilation_hack): Mark as externally visible.
7692
adddb265
PE
7693 * sysdep.c (croak): Move decl from here to syssignal.h.
7694 * syssignal.h (croak): Put it here, so the API can be checked when
7695 'croak' is called from dissociate_if_controlling_tty.
7696
1717ede2
PE
7697 * minibuf.c: Make symbols static if they're not exported.
7698 (minibuf_save_list, choose_minibuf_frame): Now static.
7699 * lisp.h (choose_minibuf_frame): Remove decl.
7700
fa5fb2bc
PE
7701 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7702
1e3890d1
PE
7703 * lread.c: Make symbols static if they're not exported.
7704 (read_objects, initial_obarray, oblookup_last_bucket_number):
7705 Now static.
7706 (make_symbol): Remove; unused.
7707 * lisp.h (initial_obarray, make_symbol): Remove decls.
7708
8a1414fa
PE
7709 * keyboard.c: Make symbols static if they're not exported.
7710 (single_kboard, recent_keys_index, total_keys, recent_keys):
7711 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7712 (this_single_command_key_start, echoing, last_auto_save):
7713 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7714 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7715 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7716 (Vlispy_mouse_stem, double_click_count):
7717 Now static.
7718 (force_auto_save_soon): Define only if SIGDANGER.
7719 (ignore_mouse_drag_p): Now static if
7720 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7721 (print_help): Remove; unused.
7722 (stop_character, last_timer_event): Mark as externally visible.
7723 * keyboard.h (ignore_mouse_drag_p): Declare only if
7724 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7725 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7726 * lisp.h (echoing): Remove decl.
7727 (force_auto_save_soon): Declare only if SIGDANGER.
7728 * xdisp.c (redisplay_window): Simplify code, to make it more
7729 obvious that ignore_mouse_drag_p is not accessed if !defined
7730 USE_GTK && !defined HAVE_NS.
7731
93ea6e8f
PE
7732 * intervals.c: Make symbols static if they're not exported.
7733 (merge_properties_sticky, merge_interval_right, delete_interval):
7734 Now static.
7735 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7736
77382fcc
PE
7737 * insdel.c: Make symbols static if they're not exported.
7738 However, leave prepare_to_modify_buffer alone. It's never
7739 called from outside this function, but that appears to be a bug.
7740 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7741 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7742 (adjust_after_replace_noundo): Remove; unused.
7743 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7744 (signal_before_change): Remove decls.
77382fcc 7745
9306c32e
PE
7746 * indent.c (val_compute_motion, val_vmotion): Now static.
7747
cd44d2eb
PE
7748 * image.c: Make symbols static if they're not exported.
7749 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7750 if USE_GTK.
7751 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7752 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7753
ad9a7a06
PE
7754 * fringe.c (standard_bitmaps): Now static.
7755 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7756
81626931
PE
7757 * frame.c: Make symbols static if they're not exported.
7758 (x_report_frame_params, make_terminal_frame): Now static.
7759 (get_frame_param): Now static, unless HAVE_NS.
7760 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7761 (x_get_resource_string): Remove; not used.
7762 * frame.h (make_terminal_frame, x_report_frame_params):
7763 (x_get_resource_string); Remove decls.
7764 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7765 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7766
239f9db9
PE
7767 * font.c, fontset.c: Make symbols static if they're not exported.
7768 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7769 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7770 * font.c (font_close_object): Now static.
7771 * font.h (font_close_object): Remove.
7772 * fontset.c (FONTSET_OBJLIST): Remove.
7773 (free_realized_fontset) #if-0 the body, which does nothing.
7774 (face_suitable_for_char_p): #if-0, as it's never called.
7775 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7776 * xfaces.c (face_at_string_position):
7777 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7778 since 0 is always ASCII.
7779
dfcf3579
PE
7780 * fns.c (weak_hash_tables): Now static.
7781
5045092b
PE
7782 * fileio.c: Make symbols static if they're not exported.
7783 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7784 (Vwrite_region_annotation_buffers): Now static.
7785
57a96f5c
PE
7786 * eval.c: Make symbols static if they're not exported.
7787 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7788 * lisp.h (backtrace_list): Remove decl.
7789
35f08c38
PE
7790 * emacs.c: Make symbols static if they're not exported.
7791 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7792 (fatal_error_code, fatal_error_signal_hook, standard_args):
7793 Now static.
7794 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7795 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7796 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7797 * lisp.h (fatal_error_signal_hook): Remove decl.
7798 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7799
f44bd759
PE
7800 * editfns.c: Move a (normally-unused) function to its only use.
7801 * editfns.c, lisp.h (get_operating_system_release): Remove.
7802 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7803 worth the hassle of breaking this out.
7804
b532497d
PE
7805 * xterm.c: Make symbols static if they're not exported.
7806 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7807 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7808 (x_destroy_window, x_delete_display):
7809 Now static.
7810 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7811 (x_mouse_leave): Remove; unused.
7812 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7813 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7814 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7815 Remove decls.
7816 (x_mouse_leave): Declare only if WINDOWSNT.
7817 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7818 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7819 USE_X_TOOLKIT.
7820
1675728f
PE
7821 * ftxfont.c: Make symbols static if they're not exported.
7822 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7823 HAVE_FREETYPE.
7824 * font.h (ftxfont_driver): Likewise.
7825
e4cebfca
PE
7826 * xfns.c: Make symbols static if they're not exported.
7827 (x_last_font_name, x_display_info_for_name):
7828 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7829 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7830 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7831 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7832 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7833 (last_show_tip_args): Now static.
7834 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7835 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7836 (x_screen_planes): Remove; unused.
7837 * dispextern.h (x_screen_planes): Remove decl.
7838
5bf46f05
PE
7839 * dispnew.c: Make symbols static if they're not exported.
7840 * dispextern.h (redraw_garbaged_frames, scrolling):
7841 (increment_row_positions): Remove.
7842 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7843 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7844 Now static.
7845 (redraw_garbaged_frames): Remove; unused.
7846
435f4c28
PE
7847 * xfaces.c: Make symbols static if they're not exported.
7848 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7849 Remove decls.
7850 * xterm.h (defined_color): Remove decls.
7851 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7852 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7853 (menu_face_changed_default, defined_color, free_realized_face):
7854 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7855 (ascii_face_of_lisp_face): Remove; unused.
7856
8524aef3
PE
7857 * xdisp.c: Make symbols static if they're not exported.
7858 * dispextern.h (scratch_glyph_row, window_box_edges):
7859 (glyph_to_pixel_coords, set_cursor_from_row):
7860 (get_next_display_element, set_iterator_to_next):
7861 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7862 (show_mouse_face): Remove decls
7863 * frame.h (message_buf_print): Likewise.
7864 * lisp.h (pop_message, set_message, check_point_in_composition):
7865 Likewise.
7866 * xterm.h (set_vertical_scroll_bar): Likewise.
7867 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7868 (message_buf_print, scratch_glyph_row, displayed_buffer):
7869 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7870 (get_next_display_element, show_mouse_face, window_box_edges):
7871 (frame_to_window_pixel_xy, check_point_in_composition):
7872 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7873 (glyph_to_pixel_coords): Remove; unused.
7874
16390cd2
PE
7875 * dired.c (file_name_completion): Now static.
7876
7877 * dbusbind.c (xd_in_read_queued_messages): Now static.
7878
a25f4dfa
PE
7879 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7880 * data.c (circular_list_error): Remove.
7881
14a9c8df
PE
7882 * commands.h (last_point_position, last_point_position_buffer):
7883 (last_point_position_window): Remove decls.
7884 * keyboard.c: Make these variables static.
7885
04f2d78b
CB
7886 * coding.h (coding, code_convert_region, encode_coding_gap):
7887 Remove decls.
74ab6df5
PE
7888 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7889 (iso_code_class, detect_coding, code_convert_region): Now static.
7890 (encode_coding_gap): Remove; unused.
7891
38dfbee1
PE
7892 * chartab.c (chartab_chars, chartab_bits): Now static.
7893
a2cb4e63
PE
7894 * charset.h (charset_iso_8859_1): Remove decl.
7895 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7896 Now static.
7897
127198fd
PE
7898 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7899 * ccl.c (Vccl_program_table): Now static.
7900 (check_ccl_update): Remove; unused.
7901
d85b608f
PE
7902 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7903 * category.h: ... from here.
7904 * category.c (check_category_table, set_category_set): Now static.
7905
31cd66f3
PE
7906 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7907 * lisp.h: Remove these decls.
7908
c358e587
PE
7909 * buffer.c (buffer_count): Remove unused var.
7910
e78aecca
PE
7911 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7912 so that it's not optimized away.
7913 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7914 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7915 exported only to the debugger.
7916
e192d7d3 7917 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7918 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7919
92470028
PE
7920 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7921 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7922 was inaccessible from Lisp.
7923 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7924 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7925
244ed907
PE
7926 alloc.c: Import and export fewer symbols, and remove unused items.
7927 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7928 is defined.
7929 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7930 it's not optimized away by whole-program optimization.
7931 (message_enable_multibyte, free_misc): Remove.
7932 (catchlist, handlerlist, mark_backtrace):
7933 Declare only if BYTE_MARK_STACK.
7934 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7935 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7936 (message_enable_multibyte): Remove decl.
7937 (free_misc, interval_free_list, float_block, float_block_index):
7938 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7939 (cons_free_list, last_marked_index):
7940 Now static.
7941 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7942 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7943 (mark_backtrace): Define only if BYTE_MARK_STACK.
7944 * xdisp.c (message_enable_multibyte): Now static.
7945
61c2b50e 7946 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7947 This makes it easier for human readers (and static analyzers)
7948 to see whether these variables are used from other modules.
7949 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7950 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7951 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7952 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7953 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7954 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7955 * xmenu.c, xselect.c:
7956 Declare Q* vars static if they are not used in other modules.
7957 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7958 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7959 Remove decls of unexported vars.
7960 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7961
95c82688
PE
7962 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7963
16a97296
PE
7964 Make Emacs functions such as Fatom 'static' by default.
7965 This makes it easier for human readers (and static analyzers)
7966 to see whether these functions can be called from other modules.
7967 DEFUN now defines a static function. To make the function external
7968 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7969 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7970 (Finit_image_library):
16a97296
PE
7971 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7972 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7973 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7974 Remove decls, since these functions are now static.
7975 (Funintern, Fget_internal_run_time): New decls, since these functions
7976 were already external.
95c82688 7977
16a97296
PE
7978 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7979 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7980 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7981 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7982 * keyboard.c, keymap.c, lread.c:
7983 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7984 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7985 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7986 Mark functions with DEFUE instead of DEFUN,
7987 if they are used in other modules.
7988 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7989 decls for now-static functions.
7990 * buffer.h (Fdelete_overlay): Remove decl.
7991 * callproc.c (Fgetenv_internal): Mark as internal.
7992 * composite.c (Fremove_list_of_text_properties): Remove decl.
7993 (Fcomposition_get_gstring): New forward static decl.
7994 * composite.h (Fcomposite_get_gstring): Remove decl.
7995 * dired.c (Ffile_attributes): New forward static decl.
7996 * doc.c (Fdocumntation_property): New forward static decl.
7997 * eval.c (Ffetch_bytecode): New forward static decl.
7998 (Funintern): Remove extern decl; now in .h file where it belongs.
7999 * fileio.c (Fmake_symbolic_link): New forward static decl.
8000 * image.c (Finit_image_library): New forward static decl.
8001 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8002 * intervals.h (Fprevious_property_change):
8003 (Fremove_list_of_text_properties): Remove decls.
8004 * keyboard.c (Fthis_command_keys): Remove decl.
8005 (Fcommand_execute): New forward static decl.
8006 * keymap.c (Flookup_key): New forward static decl.
8007 (Fcopy_keymap): Now static.
8008 * keymap.h (Flookup_key): Remove decl.
8009 * process.c (Fget_process): New forward static decl.
8010 (Fprocess_datagram_address): Mark as internal.
8011 * syntax.c (Fsyntax_table_p): New forward static decl.
8012 (skip_chars): Remove duplicate decl.
8013 * textprop.c (Fprevious_property_change): New forward static decl.
8014 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8015 Now internal.
8016 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8017 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8018
785bbd42
PE
8019 * editfns.c (Fformat): Remove unreachable code.
8020
8b913b57
AS
80212011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8022
8023 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8024 change. (Bug#8496)
8025
a6744a35
EZ
80262011-04-13 Eli Zaretskii <eliz@gnu.org>
8027
8028 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8029 when at ZV. (Bug#8487)
8030
e7974947
AS
80312011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8032
baad03f0
AS
8033 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8034 (Bug#8437)
8035 * keyboard.c (parse_tool_bar_item): Likewise.
8036 * sound.c (sound_cleanup, alsa_close): Likewise.
8037 * termcap.c (tgetent): Likewise.
8038 * xfns.c (x_default_font_parameter): Likewise.
8039 * xsettings.c (read_and_apply_settings): Likewise.
8040
e7974947
AS
8041 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8042 (overrun_check_free): Protoize.
8043
28272684
PE
80442011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8045
8046 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8047 since callers should never pass a negative size.
8048 Change the signature to match that of plain 'read' and 'write'; see
8049 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8050 * lisp.h: Update prototypes of emacs_write and emacs_read.
8051
11997c76
EZ
80522011-04-11 Eli Zaretskii <eliz@gnu.org>
8053
8054 * xdisp.c (redisplay_window): Don't try to determine the character
8055 position of the scroll margin if the window start point w->startp
e896f03c 8056 is outside the buffer's accessible region. (Bug#8468)
11997c76 8057
8a2cbd72
EZ
80582011-04-10 Eli Zaretskii <eliz@gnu.org>
8059
8060 Fix write-region and its subroutines for buffers > 2GB.
8061 * fileio.c (a_write, e_write): Modify declaration of arguments and
8062 local variables to support buffers larger than 2GB.
8063 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8064
8065 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8066 argument, local variables, and return value.
8067
8068 * lisp.h: Update prototypes of emacs_write and emacs_read.
8069
8070 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8071
4073e537 80722011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8073
1ebfdcb6
PE
8074 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8075
b2ded58d
PE
8076 Fix more problems found by GCC 4.6.0's static checks.
8077
7d66342c
PE
8078 * xdisp.c (vmessage): Use a better test for character truncation.
8079
bbf47d44
PE
8080 * charset.c (load_charset_map): <, not <=, for optimization,
8081 and to avoid potential problems with integer overflow.
9248994d 8082 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8083 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8084 * editfns.c (Fformat): Likewise.
1e69125e 8085 * syntax.c (skip_chars): Likewise.
3befa583 8086
e3019616
PE
8087 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8088 This also lets GCC 4.6.0 generate slightly better loop code.
8089
becfa255
PE
8090 * callint.c (Fcall_interactively): <, not <=, for optimization.
8091 (Fcall_interactively): Count the number of arguments produced,
8092 not the number of arguments given. This is simpler and lets GCC
8093 4.6.0 generate slightly better code.
8094
dae0cd48
PE
8095 * ftfont.c: Distingish more carefully between FcChar8 and char.
8096 The previous code passed unsigned char * to a functions like
8097 strlen and xstrcasecmp that expect char *, which does not
8098 conform to the C standard.
8099 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8100 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8101 char * when the C standard requires it.
8102
76032d70
PE
8103 * keyboard.c (read_char): Remove unused var.
8104
eb3f1cc8
PE
8105 * eval.c: Port to Windows vsnprintf (Bug#8435).
8106 Include <limits.h>.
8107 (SIZE_MAX): Define if the headers do not.
8108 (verror): Do not give up if vsnprintf returns a negative count.
8109 Instead, grow the buffer. This ports to Windows vsnprintf, which
8110 does not conform to C99. Problem reported by Eli Zaretskii.
8111 Also, simplify the allocation scheme, by avoiding the need for
8112 calling realloc, and removing the ALLOCATED variable.
8113
70476b54
PE
8114 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8115
12020a9e
PE
8116 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8117 But keep the doprint source code for now, as we might revamp it
8118 and use it again (Bug#8435).
ea6c7ae6
PE
8119 * lisp.h (doprnt): Remove.
8120 * Makefile.in (base_obj): Remove doprnt.o.
8121 * deps.mk (doprnt.o): Remove.
8122
5fdb398c
PE
8123 error: Print 32- and 64-bit integers portably (Bug#8435).
8124 Without this change, on typical 64-bit hosts error ("...%d...", N)
8125 was used to print both 32- and 64-bit integers N, which relied on
8126 undefined behavior.
61bdb816 8127 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8128 * lisp.h (error, verror): Mark as printf-like functions.
8129 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8130 Report overflow in size calculations when allocating printf buffer.
8131 Do not truncate output string at its first null byte.
8132 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8133 Truncate the output at a character boundary, since vsnprintf does not
8134 do that.
8135 * charset.c (check_iso_charset_parameter): Convert internal
8136 character to string before calling 'error', since %c now has the
8137 printf meaning.
8138 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8139 overflow when computing char to be passed to 'error'. Do not
8140 pass Lisp_Object to 'error'; pass the integer instead.
8141 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8142 formatted with plain %d.
8143
b189fa66
PE
8144 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8145
bff87ef0
PE
8146 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8147
7e2cac20
PE
8148 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8149
ce4d90b5
PE
8150 * xterm.c (x_catch_errors): Remove duplicate declaration.
8151
266c9547
PE
8152 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8153
79c49ad2
PE
8154 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8155
368f4090
JM
81562011-04-10 Jim Meyering <meyering@redhat.com>
8157
8158 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8159 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8160 return ssize_t not "int", and use size_t as the buffer length.
8161 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8162 * gnutls.h: Update declarations.
8163 * process.c (read_process_output): Use ssize_t, to match.
8164 (send_process): Likewise.
8165
a32d4040
CY
81662011-04-09 Chong Yidong <cyd@stupidchicken.com>
8167
8168 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8169
8546720e 81702011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8171
04f2d78b
CB
8172 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8173 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8174
8546720e
GM
8175 * xterm.c (handle_one_xevent):
8176 * xmenu.c (create_and_show_popup_menu):
8177 * xselect.c (x_decline_selection_request)
8178 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8179
0a2f5c1a 81802011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8181
8182 Fix some uses of `int' instead of EMACS_INT.
8183 * search.c (string_match_1, fast_string_match)
8184 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8185 (scan_buffer, find_next_newline_no_quit)
8186 (find_before_next_newline, search_command, Freplace_match)
8187 (Fmatch_data): Make some `int' variables be EMACS_INT.
8188
8189 * xdisp.c (display_count_lines): 3rd argument and return value now
8190 EMACS_INT. All callers changed.
8191 (pint2hrstr): Last argument is now EMACS_INT.
8192
8193 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8194 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8195 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8196 (decode_coding_utf_16, decode_coding_emacs_mule)
8197 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8198 (decode_coding_ccl, decode_coding_charset)
8199 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8200 (decode_coding_iso_2022, decode_coding_emacs_mule)
8201 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8202 <char_offset, last_offset>: Declare EMACS_INT.
8203 (encode_coding_utf_8, encode_coding_utf_16)
8204 (encode_coding_emacs_mule, encode_invocation_designation)
8205 (encode_designation_at_bol, encode_coding_iso_2022)
8206 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8207 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8208 Declare EMACS_INT.
8209 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8210 (encode_invocation_designation): Last argument P_NCHARS is now
8211 EMACS_INT.
8212 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8213 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8214
8215 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8216 All users changed.
8217
8218 * ccl.c (Fccl_execute_on_string): Declare some variables
8219 EMACS_INT.
8220
8546720e 82212011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8222
8223 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8224
4e19a977
CS
82252011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8226
8227 * process.c (Fformat_network_address): Doc fix.
8228
87302331
R
82292011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8230
ee7683eb 8231 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8232
cbb59342
CY
82332011-04-08 Chong Yidong <cyd@stupidchicken.com>
8234
8235 * keyboard.c (read_char): Call Lisp function help-form-show,
8236 instead of using internal_with_output_to_temp_buffer.
8237 (Qhelp_form_show): New var.
e0d38eeb 8238 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8239
8240 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8241
8242 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8243
e67a13ab
CY
82442011-04-06 Chong Yidong <cyd@stupidchicken.com>
8245
04f2d78b
CB
8246 * process.c (Flist_processes): Remove to Lisp.
8247 (list_processes_1): Delete.
e67a13ab 8248
973f782d
EZ
82492011-04-06 Eli Zaretskii <eliz@gnu.org>
8250
7c106b1e
EZ
8251 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8252
973f782d
EZ
8253 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8254
41cf7d1a 82552011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8256
ca23cc88
PE
8257 Fix more problems found by GCC 4.6.0's static checks.
8258
f390e2d5
PE
8259 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8260
42eea0d0
PE
8261 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8262
b69769da 8263 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8264
f9541e84
PE
8265 * xdisp.c (vmessage): Mark as a printf-like function.
8266
13841b55
PE
8267 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8268
c136c10f
PE
8269 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8270
5e2d4a30
PE
8271 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8272 printf-like functions.
8273 (tiff_load): Add casts to remove these marks before passing them
8274 to system-supplied API.
8275
583f48b9
PE
8276 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8277
b25d760e
PE
8278 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8279 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8280 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8281 directly, rather than having caller test rule sign. This avoids
8282 some unnecessary tests.
8283 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8284 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8285 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8286
bc7b6697 8287 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8288 (xfont_open): Avoid unnecessary tests.
bc7b6697 8289
27ccc379
PE
8290 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8291
dcd5c89a
PE
8292 * composite.h, composite.c (composition_gstring_put_cache):
8293 Use EMACS_INT, not int, for length.
8294
b13a45c6
PE
8295 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8296 breaking out part of COMPOSITION_DECODE_RULE.
8297 (COMPOSITION_DECODE_RULE): Use it.
8298 * composite.c (get_composition_id): Remove unused local vars,
8299 by using the new macro.
8300
1e792e4d
PE
8301 * textprop.c (set_text_properties_1): Change while to do-while,
8302 since the condition is always true at first.
8303
dc6c6455 8304 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8305 (interval_deletion_adjustment): Return unsigned value.
8306 All uses changed.
dc6c6455 8307
aba7731a
PE
8308 * process.c (list_processes_1, create_pty, read_process_output):
8309 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8310 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8311 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8312 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8313 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8314
fdfc4bf3
PE
8315 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8316
fca8fe46 8317 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8318 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8319
06a0259a 8320 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8321 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8322 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8323
e7b9e80f
PE
8324 * print.c (print_error_message): Avoid int overflow.
8325
56201685
PE
8326 * font.c (font_list_entities): Redo for clarity,
8327 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8328
78834453 8329 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8330 (font_score): Avoid potential overflow in diff calculation.
78834453 8331
0bc0b309 8332 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8333 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8334
e610eaca
PE
8335 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8336
b895abce
PE
8337 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8338 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8339 can always succeed if overflow has undefined behavior.
8340
1f1d9321 8341 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8342 (wordify): Omit three unnecessary tests.
1f1d9321 8343
c59478bc
PE
8344 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8345 All callers changed. This avoids the need for an unused var.
8346
79b73827
PE
8347 * casefiddle.c (casify_region): Remove var that is set but not used.
8348
a4db5dfe
PE
8349 * dired.c (file_name_completion): Remove var that is set but not used.
8350
43aae36e
PE
8351 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8352
2a47c44d 8353 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8354 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8355
a37c69bf
PE
8356 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8357 Check for integer overflow on size calculations.
8358
328ab8e7
PE
8359 * buffer.c (Fprevious_overlay_change): Remove var that is set
8360 but not used.
8361
e5a2a5cb
PE
8362 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8363 Remove vars that are set but not used.
8d84a6eb 8364 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8365 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8366
a60e5f68
PE
8367 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8368
f661cb61 8369 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8370 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8371
f0397f5a
PE
8372 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8373 that are set but not used.
8374
8664db06 8375 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8376 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8377
6abdaa4a
PE
8378 * xselect.c (x_get_local_selection, x_handle_property_notify):
8379 Remove vars that are set but not used.
8380
0ce7538d 8381 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8382 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8383
9ae848fc
PE
8384 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8385 Remove var that is set but not used.
0b918413
PE
8386 (scroll_bar_windows_size): Now size_t, not int.
8387 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8388 Check for overflow.
9ae848fc 8389
a5a62657
PE
8390 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8391 (map_tty_color) [!defined MSDOS]: Likewise.
8392
5c5cdd39
PE
8393 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8394
66ebf983
PE
8395 * coding.c: Remove vars that are set but not used.
8396 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8397 All callers changed.
8398 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8399 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8400 (decode_coding_charset): Remove vars that are set but not used.
8401
1be4d761
PE
8402 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8403 that is set but not used.
8404
47553fa8
PE
8405 * print.c (print_object): Remove var that is set but not used.
8406
1f7196bf 8407 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8408 The gnulib version avoids calling malloc in the usual case,
8409 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8410 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8411 * filelock.c (current_lock_owner): Likewise.
8412 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8413 * sysdep.c: Include allocator.h, careadlinkat.h.
8414 (emacs_no_realloc_allocator): New static constant.
8415 (emacs_readlink): New function.
fdb61804
PE
8416 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8417 ../lib/careadlinkat.h.
d1fdcab7 8418
f84c17c7
SM
84192011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8420
8421 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8422 first non-nil return value).
8423
ef3862ad
JD
84242011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8425
8426 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8427 if not defined (Bug#8403).
8428
376a7006
JB
84292011-04-02 Juanma Barranquero <lekktu@gmail.com>
8430
8431 * xdisp.c (display_count_lines): Remove parameter `start',
8432 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8433 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8434 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8435 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8436 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8437 and thereabouts. All callers changed.
8438 (get_per_char_metric): Remove parameter `f', unused since
8439 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8440
6ca3801d
JM
84412011-04-02 Jim Meyering <meyering@redhat.com>
8442
8443 do not dereference NULL upon failed strdup
8444 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8445 (ns_get_family): Likewise.
8446
d8e2b5ba
JB
84472011-04-02 Juanma Barranquero <lekktu@gmail.com>
8448
8449 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8450
8c74fcbd
JD
84512011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8452
8453 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8454 later (Bug#8403).
8455
7200d79c
SM
84562011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8457
03408648 8458 Add lexical binding.
7200d79c 8459
03408648
SM
8460 * window.c (Ftemp_output_buffer_show): New fun.
8461 (Fsave_window_excursion):
8462 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8463
8464 * lread.c (lisp_file_lexically_bound_p): New function.
8465 (Fload): Bind Qlexical_binding.
8466 (readevalloop): Remove `evalfun' arg.
8467 Bind Qinternal_interpreter_environment.
8468 (Feval_buffer): Bind Qlexical_binding.
8469 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8470 Mark as dynamic.
8471 (syms_of_lread): Declare `lexical-binding'.
8472
8473 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8474
8475 * keyboard.c (eval_dyn): New fun.
8476 (menu_item_eval_property): Use it.
ca105506
SM
8477
8478 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8479
03408648
SM
8480 * fns.c (concat, mapcar1): Accept byte-code-functions.
8481
8482 * eval.c (Fsetq): Handle lexical vars.
8483 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8484 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8485 (FletX, Flet): Obey lexical binding.
8486 (Fcommandp): Handle closures.
8487 (Feval): New `lexical' arg.
8488 (eval_sub): New function extracted from Feval. Use it almost
8489 everywhere where Feval was used. Look up vars in lexical env.
8490 Handle closures.
8491 (Ffunctionp): Move from subr.el.
8492 (Ffuncall): Handle closures.
8493 (apply_lambda): Remove `eval_flags'.
8494 (funcall_lambda): Handle closures and new byte-code-functions.
8495 (Fspecial_variable_p): New function.
8496 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8497 but without exporting it to Lisp.
23aba0ea 8498
23aba0ea 8499 * doc.c (Fdocumentation, store_function_docstring):
03408648 8500 * data.c (Finteractive_form): Handle closures.
23aba0ea 8501
03408648
SM
8502 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8503 interactive spec.
ba83908c 8504
04f2d78b
CB
8505 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8506 New byte-codes.
03408648
SM
8507 (exec_byte_code): New function extracted from Fbyte_code to handle new
8508 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8509
03408648 8510 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8511
03408648 8512 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8513
e2abce01
JB
85142011-03-31 Juanma Barranquero <lekktu@gmail.com>
8515
8516 * xdisp.c (redisplay_internal): Fix prototype.
8517
63696a73 85182011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8519
63696a73 8520 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8521 (try_scrolling): Use it when setting scroll_limit.
8522 Limit scrolling to 100 screen lines.
63696a73
EZ
8523 (redisplay_window): Even when falling back on "recentering",
8524 position point in the window according to scroll-conservatively,
8525 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8526
8527 (try_scrolling): When point is above the window, allow searching
8528 as far as scroll_max, or one screenful, to compute vertical
8529 distance from PT to the scroll margin position. This prevents
8530 try_scrolling from unnecessarily failing when
8531 scroll-conservatively is set to a value slightly larger than the
8532 window height. Clean up the case of PT below the margin at bottom
8533 of window: scroll_max can no longer be INT_MAX. When aggressive
8534 scrolling is in use, don't let point enter the opposite scroll
8535 margin as result of the scroll.
8536 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8537 threshold of 100 lines for never-recentering scrolling.
8538
e4cc2dfc
JB
85392011-03-31 Juanma Barranquero <lekktu@gmail.com>
8540
8541 * dispextern.h (move_it_by_lines):
8542 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8543 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8544 (message_log_check_duplicate): Remove parameters `prev_bol' and
8545 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8546 (redisplay_internal): Remove parameter `preserve_echo_area',
8547 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8548
8549 * indent.c (Fvertical_motion):
8550 * window.c (window_scroll_pixel_based, Frecenter):
8551 Don't pass `need_y_p' to `move_it_by_lines'.
8552
1c470562
SM
85532011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8554
44f230aa
SM
8555 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8556 steal a few bits to be more compact.
8557 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8558 Remove unneeded casts.
8559
1c470562
SM
8560 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8561
888adce9
ZK
85622011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8563
8564 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8565 binding" message (bug#7967).
8566
f838ed7b
PE
85672011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8568
77861b95
PE
8569 Fix more problems found by GCC 4.6.0's static checks.
8570
de6dbc14
PE
8571 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8572 Remove unused local var.
8573
f838ed7b
PE
8574 * editfns.c (Fmessage_box): Remove unused local var.
8575
792c7b2b
PE
8576 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8577 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8578 Omit unused local vars.
c499e557 8579 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8580 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8581 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8582 Omit unused local var.
8583
ba0165e1
PE
8584 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8585 Don't assume string length fits in int.
32ad8845 8586 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8587 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8588
3c59b4c9
PE
8589 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8590 instead of alloca (Bug#8344).
8591
a3eed478 8592 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8593 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8594
eb4d412d
PE
8595 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8596
1658b401
PE
8597 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8598 concerns.
8599
8600 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8601
8602 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8603
9a2c6e05
PE
8604 * keyboard.c (syms_of_keyboard): Use the same style as later
8605 in this function when indexing through an array. This also
8606 works around GCC bug 48267.
8607
03d0a109
PE
8608 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8609
44f730c8
PE
8610 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8611
fe75f926
PE
8612 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8613 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8614
ffa8c828
PE
8615 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8616 This avoids undefined behavior on integer overflow, and is a bit
8617 more convenient anyway since it is compared to a size_t variable.
8618
c5101a77
PE
8619 Variadic C functions now count arguments with size_t, not int.
8620 This avoids an unnecessary limitation on 64-bit machines, which
8621 caused (substring ...) to crash on large vectors (Bug#8344).
8622 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8623 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8624 All variadic functions and their callers changed accordingly.
c5101a77
PE
8625 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8626 * data.c (arith_driver, float_arith_driver): Likewise.
8627 * editfns.c (general_insert_function): Likewise.
8628 * eval.c (struct backtrace.nargs, interactive_p)
8629 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8630 (funcall_lambda, mark_backtrace): Likewise.
8631 * fns.c (concat): Likewise.
8632 * frame.c (x_set_frame_parameters): Likewise.
8633 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8634 0 if not found, not -1. All callers changed.
8635
dd3f25f7
PE
8636 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8637 (stack_copy_size): Now size_t, not int.
8638 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8639
461c2ab9
JB
86402011-03-28 Juanma Barranquero <lekktu@gmail.com>
8641
8642 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8643 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8644 All callers changed.
8645
8646 * lisp.h (multibyte_char_to_unibyte):
8647 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8648 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8649 * character.h (CHAR_TO_BYTE8):
8650 * cmds.c (internal_self_insert):
8651 * editfns.c (general_insert_function):
8652 * keymap.c (push_key_description):
8653 * search.c (Freplace_match):
8654 * xdisp.c (message_dolog, set_message_1): All callers changed.
8655
f6d62986
SM
86562011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8657
8658 * keyboard.c (safe_run_hook_funcall): New function.
8659 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8660 don't set the hook to nil, but remove the offending function instead.
8661 (Qcommand_hook_internal): Remove, unused.
8662 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8663 Vcommand_hook_internal.
8664
8665 * eval.c (enum run_hooks_condition): Remove.
8666 (funcall_nil, funcall_not): New functions.
8667 (run_hook_with_args): Call each function through a `funcall' argument.
8668 Remove `cond' argument, now redundant.
8669 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8670 (Frun_hook_with_args_until_failure): Adjust accordingly.
8671 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8672
1db5b1ad
JB
86732011-03-28 Juanma Barranquero <lekktu@gmail.com>
8674
8675 * dispextern.h (string_buffer_position): Remove declaration.
8676
8677 * print.c (strout): Remove parameter `multibyte', unused since
8678 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8679
8680 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8681 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8682 All callers changed.
8683
8684 * w32.c (_wsa_errlist): Use braces for struct initializers.
8685
8686 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8687 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8688 All callers changed.
8689 (string_buffer_position): Likewise. Also, make static (it's never
8690 used outside xdisp.c).
8691 (cursor_row_p): Remove parameter `w', unused since
8692 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8693 (decode_mode_spec): Remove parameter `precision', introduced during
8694 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8695 All callers changed.
8696
5ffb62aa
JD
86972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8698
8699 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8700
461c2ab9 87012011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8702
8703 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8704 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8705 (ns_update_auto_hide_menu_bar): New functions.
8706 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8707 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8708 ns_constrain_all_frames.
8709 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8710 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8711
5c380ffb
JD
87122011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8713
8714 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8715
9af30bdf
GM
87162011-03-27 Glenn Morris <rgm@gnu.org>
8717
8718 * syssignal.h: Replace RETSIGTYPE with void.
8719 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8720 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8721 Replace SIGTYPE with void everywhere.
8722 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8723 * s/template.h (SIGTYPE): Remove commented out definition.
8724
e2abce01
JB
87252011-03-26 Eli Zaretskii <eliz@gnu.org>
8726
8727 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8728 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8729
f868cd8a
JB
87302011-03-26 Juanma Barranquero <lekktu@gmail.com>
8731
59eb0929
JB
8732 * w32.c (read_unc_volume): Use parameter `henum', instead of
8733 global variable `wget_enum_handle'.
8734
8735 * keymap.c (describe_vector): Remove parameters `indices' and
8736 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8737 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8738
f868cd8a
JB
8739 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8740
8741 * keyboard.c (timer_check): Remove parameter `do_it_now',
8742 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8743 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8744 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8745
8746 * keyboard.c (read_char):
8747 * w32menu.c (w32_menu_display_help):
8748 * xmenu.c (show_help_event, menu_help_callback):
8749 Adjust calls to `show_help_echo'.
8750
8751 * gtkutil.c (xg_maybe_add_timer):
8752 * keyboard.c (readable_events):
8753 * process.c (wait_reading_process_output):
8754 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8755
8756 * insdel.c (adjust_markers_gap_motion):
8757 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8758 (gap_left, gap_right): Don't call it.
8759
2ecf6fdb
CY
87602011-03-25 Chong Yidong <cyd@stupidchicken.com>
8761
8762 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8763 incurred during fontification.
8764
6b1f9ba4
JB
87652011-03-25 Juanma Barranquero <lekktu@gmail.com>
8766
8767 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8768 (DEFVAR_PER_BUFFER): Don't pass it.
8769
8770 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8771 (scrolling_window): Don't pass it.
8772
0f4a96b5
JB
87732011-03-25 Juanma Barranquero <lekktu@gmail.com>
8774
8775 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8776
8777 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8778 and `suffix'.
8779 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8780 of variables specific to SELinux and computation of `encoded_absname'.
8781
8782 * image.c (XPutPixel): Remove unused variable `height'.
8783
8784 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8785
8786 * unexw32.c (get_section_info): Remove unused variable `section'.
8787
8788 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8789 (system_process_attributes): Remove unused variable `sess'.
8790 (sys_read): Remove unused variable `err'.
8791
8792 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8793 (w32_wnd_proc): Remove unused variable `isdead'.
8794 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8795 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8796 (x_create_tip_frame): Remove unused variable `tem'.
8797
8798 * w32inevt.c (w32_console_read_socket):
8799 Remove unused variable `no_events'.
8800
8801 * w32term.c (x_draw_composite_glyph_string_foreground):
8802 Remove unused variable `width'.
8803
1149507c
JB
88042011-03-24 Juanma Barranquero <lekktu@gmail.com>
8805
8806 * w32term.c (x_set_glyph_string_clipping):
8807 Don't pass uninitialized region to CombineRgn.
8808
9c88f339
JB
88092011-03-23 Juanma Barranquero <lekktu@gmail.com>
8810
8811 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8812 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8813 (Fx_close_connection): Remove unused variable `i'.
8814
8815 * w32font.c (w32font_draw): Return number of glyphs.
8816 (w32font_open_internal): Remove unused variable `i'.
8817 (w32font_driver): Add missing initializer.
8818
8819 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8820 (fill_in_menu): Remove unused variable `items_added'.
8821
8822 * w32term.c (last_mouse_press_frame): Remove static global variable.
8823 (w32_clip_to_row): Remove unused variable `f'.
8824 (x_delete_terminal): Remove unused variable `i'.
8825
8826 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8827 (NOTHING): Remove unused static global variable.
8828 (uniscribe_check_otf): Remove unused variable `table'.
8829 (uniscribe_font_driver): Add missing initializers.
8830
dee091a3
JD
88312011-03-23 Julien Danjou <julien@danjou.info>
8832
8833 * term.c (Fsuspend_tty, Fresume_tty):
8834 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8835 * window.c (temp_output_buffer_show):
8836 * insdel.c (signal_before_change):
8837 * frame.c (Fhandle_switch_frame):
8838 * fileio.c (Fdo_auto_save):
8839 * emacs.c (Fkill_emacs):
8840 * editfns.c (save_excursion_restore):
8841 * cmds.c (internal_self_insert):
8842 * callint.c (Fcall_interactively):
8843 * buffer.c (Fkill_all_local_variables):
8844 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8845 Use Frun_hooks.
0f4a96b5 8846 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8847 unconditionally since it does the check itself.
dee091a3 8848
2c520ab5 88492011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8850
c9c49752
PE
8851 Fix more problems found by GCC 4.5.2's static checks.
8852
8abc3f12
PE
8853 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8854 the first time through the loop, since we know p0 < p1 then.
8855 This also avoids a gcc -Wstrict-overflow warning.
8856
a2d26660
PE
8857 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8858 leading to a memory leak, possible in functions like
8859 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8860 of objects (Bug#8318).
a2d26660 8861
916c72e9
PE
8862 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8863 that could (at least in theory) be that large.
8864
19ab8a18
PE
8865 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8866 This is less likely to overflow, and avoids undefined behavior if
8867 overflow does occur. All callers changed. Use strtoul to scan
8868 for the unsigned long integer.
b7cbbd6f
PE
8869 (pint2hrstr): Simplify and tune code slightly.
8870 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8871
f0641eff
PE
8872 * scroll.c (do_scrolling): Work around GCC bug 48228.
8873 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8874
7f650bb9
PE
8875 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8876 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8877 (validate_x_resource_name): Simplify count usage.
8878 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8879
37dd57d1
PE
8880 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8881 fail (Bug#8306).
81e56e61 8882
699979fc 8883 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8884
401bf9b4
PE
8885 * process.c (Fmake_network_process): Use socklen_t, not int,
8886 where POSIX says socklen_t is required in portable programs.
8887 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8888 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8889 (Fmake_network_process, server_accept_connection):
8890 (wait_reading_process_output, read_process_output):
8891 Likewise.
8892
b93aacde
PE
8893 * process.c: Rename or move locals to avoid shadowing.
8894 (list_processes_1, Fmake_network_process):
8895 (read_process_output_error_handler, exec_sentinel_error_handler):
8896 Rename or move locals.
4dc343ee 8897 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8898 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8899 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8900 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8901 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8902
af8a867c 8903 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8904 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8905 Include tparam.h instead, since it declares them.
af8a867c
PE
8906 * cm.h (PC): Remove extern decl; tparam.h now does this.
8907 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8908 * terminfo.c: Include tparam.h, to check interfaces.
8909 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8910 (tparam): Adjust signature to match interface in tparam.h;
8911 this removes some undefined behavior. Check that outstring and len
8912 are zero, which they always are with Emacs.
8913 * tparam.h (PC, BC, UP): New extern decls.
8914
0248044d 8915 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8916 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8917
8ff096c1 8918 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8919 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8920 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8921 (ftfont_list): Remove unused local.
49eaafba
PE
8922 (get_adstyle_property, ftfont_pattern_entity):
8923 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8924 Rename locals to avoid shadowing.
8ff096c1 8925
e2be39f6
PE
8926 * xfont.c (xfont_list_family): Mark var as initialized.
8927
c9735e30
PE
8928 * xml.c (make_dom): Now static.
8929
8f5201ae
PE
8930 * composite.c (composition_compute_stop_pos): Rename local to
8931 avoid shadowing.
b246f932
PE
8932 (composition_reseat_it): Remove unused locals.
8933 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8934 (composition_update_it): Mark var as initialized.
11b61122
PE
8935 (find_automatic_composition): Mark vars as initialized,
8936 with a FIXME (Bug#8290).
8f5201ae 8937
760fbc2c
PE
8938 character.h: Rename locals to avoid shadowing.
8939 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8940 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8941 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8942 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8943 to avoid shadowing.
8944
ff08eb85
PE
8945 * textprop.c (property_change_between_p): Remove; unused.
8946
fc7bf025
PE
8947 * intervals.c (interval_start_pos): Now static.
8948
235d7abc
PE
8949 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8950
44f230aa
SM
8951 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8952 Rename locals to avoid shadowing.
3e7d6594 8953
50060332
PE
8954 * sound.c (wav_play, au_play, Fplay_sound_internal):
8955 Fix pointer signedness.
d01f234b 8956 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8957 (wav_play): Initialize a variable to 0, to prevent undefined
8958 behavior (Bug#8278).
50060332 8959
c4fc4e30
PE
8960 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8961
918436ed
PE
8962 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8963
c939f91b
PE
8964 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8965 clobbering (Bug#8298).
b9c7f648
PE
8966 * sysdep.c (sys_subshell): Likewise.
8967 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8968
6bd8c144
PE
8969 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8970 This should get cleaned up, so that child_setup has the
8971 same signature on all platforms.
8972
7710357c 8973 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8974 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8975
c59da222
CY
89762011-03-22 Chong Yidong <cyd@stupidchicken.com>
8977
8978 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8979 not to be necessary, and produces flickering.
8980
66b87493
GM
89812011-03-20 Glenn Morris <rgm@gnu.org>
8982
8983 * config.in: Remove file.
8984
45b6f6d5
JB
89852011-03-20 Juanma Barranquero <lekktu@gmail.com>
8986
8987 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8988 are now in src/globals.h.
8989 (syms_of_minibuf): Remove spurious & from previous change.
8990
cd394be1 89912011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8992
8993 * minibuf.c (completing-read-function): New variable.
8994 (completing-read-default): Rename from completing-read.
8995 (completing-read): Call completing-read-function.
8996
b14e3e21
CY
89972011-03-19 Juanma Barranquero <lekktu@gmail.com>
8998
8999 * xfaces.c (Fx_load_color_file):
9000 Read color file from absolute filename (bug#8250).
9001
f2b726e6
JB
90022011-03-19 Juanma Barranquero <lekktu@gmail.com>
9003
9004 * makefile.w32-in: Update dependencies.
9005
09f6ff02
EZ
90062011-03-17 Eli Zaretskii <eliz@gnu.org>
9007
9008 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9009
29a6015a
PE
90102011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9011
a3a6c54e
PE
9012 Fix more problems found by GCC 4.5.2's static checks.
9013
b766f867
PE
9014 * process.c (make_serial_process_unwind, send_process_trap):
9015 (sigchld_handler): Now static.
9016
be02381c
PE
9017 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9018 That way, the code declares only the vars that it needs.
9019 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9020 * s/cygwin.h (PTY_ITERATION): Likewise.
9021 * s/darwin.h (PTY_ITERATION): Likewise.
9022 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9023
57048744
PE
9024 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9025 * process.c (allocate_pty): Don't declare stb unless it's needed.
9026
7914961c 9027 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9028 (CONSTANTLIM): Remove; unused.
9029 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9030 Define only if needed.
7914961c 9031
b3967b18
PE
9032 * unexelf.c (unexec): Name an expression,
9033 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9034 Use a different way to cause a compilation error if anyone uses
9035 n rather than nn, a way that does not involve shadowing.
73366a00 9036 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9037
29a6015a
PE
9038 * deps.mk (unexalpha.o): Remove; unused.
9039
43cfc33e 9040 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9041 * unexec.h: New file.
ce701a33
PE
9042 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9043 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9044 Depend on unexec.h.
9045 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9046 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9047 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9048 Change as necessary to match prototype in unexec.h.
ce701a33 9049
01f44d5a
PE
9050 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9051 shadowing.
4f63c6bb 9052 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9053
a6670b0b
PE
9054 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9055 Rename locals to avoid shadowing.
9056
cef2010d 9057 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9058 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9059
d4d7173a
PE
9060 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9061
f08b802a
PE
9062 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9063 warning when compiling print.c.
9064
3ddb0639
PE
9065 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9066 instead of using an uninitialized var.
5ad03b97 9067 (font_sort_entities): Mark var as initialized.
3ddb0639 9068
170a2692
PE
9069 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9070
e663c700
PE
9071 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9072 pointers to constants.
89bc529a 9073 (font_parse_fcname): Remove unused vars.
7b81e2d0 9074 (font_delete_unmatched): Now static.
ea838e10 9075 (font_get_spec): Remove; unused.
13a547c6
PE
9076 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9077 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9078 Rename or move locals to avoid shadowing.
e663c700 9079
2a80c887 9080 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9081 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9082
1384fa33 9083 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9084 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9085
8b2c52e9
PE
9086 * alloc.c (mark_backtrace): Move decl from here ...
9087 * lisp.h: ... to here, so that it can be checked.
9088
475545b5 9089 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9090 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9091 (lisp_indirect_variable): Name an expression,
9092 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9093 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9094
b1349114 9095 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9096 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9097 Use const pointer when appropriate.
b1349114 9098
a2928364
PE
9099 * lisp.h (get_system_name, get_operating_system_release):
9100 Move decls here, to check interfaces.
9101 * process.c (get_operating_system_release): Move decl to lisp.h.
9102 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9103 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9104 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9105 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9106 (Fformat_time_string, Fencode_time, Finsert_char):
9107 (Ftranslate_region_internal, Fformat):
9108 Rename or remove local vars to avoid shadowing.
9710023e 9109 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9110
a415e694
PE
9111 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9112 avoid shadowing.
9113
8ef4622d
PE
9114 * lisp.h (eassert): Check that the argument compiles, even if
9115 ENABLE_CHECKING is not defined.
9116
946f9a5b
PE
9117 * data.c (Findirect_variable): Name an expression, to avoid
9118 gcc -Wbad-function-cast warning.
112396d6 9119 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9120 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9121 (Fmake_variable_buffer_local, Fmake_local_variable):
9122 Mark variables as initialized.
52746918 9123 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9124
e5aab7e7 9125 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9126 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9127 Rename locals to avoid shadowing.
dff45157
PE
9128 (mark_stack): Move local variables into the #ifdef region where
9129 they're used.
7bc26fdb
PE
9130 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9131 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9132 needed otherwise.
9133 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9134 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9135 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9136
e5aab7e7
PE
9137 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9138 avoids undefined behavior in theory.
9139
4da60324
PE
9140 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9141
88043301
PE
9142 Use functions, not macros, for up- and down-casing (Bug#8254).
9143 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9144 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9145 to use the following functions instead of these macros.
9146 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9147 EMACS_INT, since callers assume the returned value fits in int.
9148 (upcase1): Likewise, for UPCASE_TABLE.
9149 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9150 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9151 the race-condition problem in the old DOWNCASE.
88043301 9152
19ed5445
PE
9153 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9154 Rename locals to avoid shadowing.
9155 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9156 (regex_compile, re_search_2, re_match_2_internal):
9157 Remove unused local vars.
952db0d7
PE
9158 (FREE_VAR): Rewrite so as not to use empty "else",
9159 which gcc can warn about.
da053e48 9160 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9161 (RETALLOC_IF): Define only if needed.
9162 (WORDCHAR_P): Likewise. This one is never needed, but is used
9163 only in a comment talking about a compiler bug, so put inside
9164 the #if 0 of that comment.
9165 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9166 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9167 Remove; unused.
19ed5445 9168
1f3561e4 9169 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9170 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9171 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9172
ded6f8f7
PE
9173 * search.c (simple_search): Remove unused var.
9174
dbd37a95
PE
9175 * dired.c (compile_pattern): Move decl from here ...
9176 * lisp.h: ... to here, so that it can be checked.
9177 (struct re_registers): New forward decl.
9178
7e47afad
PE
9179 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9180
85f24f61
PE
9181 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9182 All uses changed.
9183 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9184 Rename locals to avoid shadowing.
5671df8f 9185 (Fvertical_motion): Mark locals as initialized.
85f24f61 9186
181aa2be 9187 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9188 (casify_region): Mark local as initialized.
181aa2be 9189
930d429c
PE
9190 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9191
7082eac6
PE
9192 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9193 New macros, so that the caller can use some names other than
9194 gcpro1, gcpro2, etc.
9195 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9196 of the new macros.
9197 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9198 argument, for consistency with GCPRO2_VAR, etc: it is now the
9199 prefix of the variable, not the variable itself. All uses
9200 changed.
38b2c076
PE
9201 * dired.c (directory_files_internal, file_name_completion):
9202 Rename locals to avoid shadowing.
9203
15206ed9
PE
9204 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9205 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9206 dired.c's scmp function, had undefined behavior.
9207 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9208 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9209 * buffer.h: ... to here, because these macros use current_buffer,
9210 and the new implementation with inline functions needs to have
9211 current_buffer in scope now, rather than later when the macros
9212 are used.
9213 (downcase, upcase1): New static inline functions.
9214 (DOWNCASE, UPCASE1): Reimplement using these functions.
9215 This avoids undefined behavior in expressions like
9216 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9217 from race conditions in accessing the global variables
9218 case_temp1 and case_temp2.
9219 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9220 * lisp.h (case_temp1, case_temp2): Remove their decls.
9221 * character.h (ASCII_CHAR_P): Move from here ...
9222 * lisp.h: ... to here, so that the inline functions mentioned
9223 above can use them.
9224
4a6bea26
PE
9225 * dired.c (directory_files_internal_unwind): Now static.
9226
f14b7e14
PE
9227 * fileio.c (file_name_as_directory, directory_file_name):
9228 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9229 Now static.
2893f146
PE
9230 (file_name_as_directory): Use const pointers when appropriate.
9231 (Fexpand_file_name): Likewise. In particular, newdir might
9232 point at constant storage, so make it a const pointer.
fd4ead52 9233 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9234 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9235 signedness issues.
f839df0c
PE
9236 (Fset_file_times, Finsert_file_contents, auto_save_error):
9237 Rename locals to avoid shadowing.
f14b7e14 9238
5716756e 9239 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9240 (Ftry_completion, Fall_completions): Rename or remove locals
9241 to avoid shadowing.
5716756e 9242
b4c3046a
PE
9243 * marker.c (bytepos_to_charpos): Remove; unused.
9244
b45db522
PE
9245 * lisp.h (verify_bytepos, count_markers): New decls,
9246 so that gcc does not warn that these functions aren't declared.
9247
85876d07
PE
9248 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9249 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9250 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9251 (copy_text): Remove unused local var.
85876d07 9252
03d78a21 9253 * filelock.c (within_one_second): Now static.
b3dd38ab 9254 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9255
5df8f01b
PE
9256 * buffer.c (fix_overlays_before): Mark locals as initialized.
9257 (fix_start_end_in_overlays): Likewise. This function should be
9258 simplified by using pointers-to-pointers, but that's a different
9259 matter.
b1d876f1 9260 (switch_to_buffer_1): Now static.
8f54f30a
PE
9261 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9262 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9263
a70072c9 9264 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9265 Fix pointer signedness issue.
edced198
PE
9266 (sys_subshell): Mark local as volatile if checking for lint,
9267 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9268 (MAXPATHLEN): Define only if needed.
a70072c9 9269
a0977c44
PE
9270 * process.c (serial_open, serial_configure): Move decls from here ...
9271 * systty.h: ... to here, so that they can be checked.
9272
a884fdcc
PE
9273 * fns.c (get_random, seed_random): Move extern decls from here ...
9274 * lisp.h: ... to here, so that they can be checked.
9275
604efe86 9276 * sysdep.c (reset_io): Now static.
b8950c94 9277 (wait_for_termination_signal): Remove; unused.
604efe86 9278
38fc62d9
PE
9279 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9280 (copy_keymap_item, append_key, push_text_char_description):
9281 Now static.
1004a21a 9282 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9283 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9284 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9285 (describe_map_tree):
9286 Rename locals to avoid shadowing.
38fc62d9 9287
2f2650da
PE
9288 * keyboard.c: Declare functions static if they are not used elsewhere.
9289 (echo_char, echo_dash, cmd_error, top_level_2):
9290 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9291 (read_char, kbd_buffer_get_event, make_lispy_position):
9292 (make_lispy_event, make_lispy_movement, apply_modifiers):
9293 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9294 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9295 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9296 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9297 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9298
a053e86c 9299 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9300 (mark_kboards): Move decl here ...
9301 * alloc.c (mark_kboards): ... from here.
a053e86c 9302
4752793e
PE
9303 * lisp.h (force_auto_save_soon): New decl.
9304
74f10ca7 9305 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9306 (DEFINE_DUMMY_FUNCTION): New macro.
9307 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9308 Use it.
c03cd23f
PE
9309 (main): Add casts to avoid warnings
9310 if GCC considers string literals to be constants.
74f10ca7 9311
022e70d4
PE
9312 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9313
59d6fe83
PE
9314 * dbusbind.c: Pointer signedness fixes.
9315 (xd_signature, xd_append_arg, xd_initialize):
9316 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9317 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9318 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9319 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9320
78320123
PE
9321 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9322 if GCC considers string literals to be constants.
49cebcca 9323 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9324
35ac2a97
SM
93252011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9326
fb103ca9
SM
9327 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9328 (print_preprocess, print_object): New macro to fix last change.
9329
35ac2a97
SM
9330 * print.c (print_preprocess): Don't forget font objects.
9331
62973b41
JB
93322011-03-16 Juanma Barranquero <lekktu@gmail.com>
9333
9334 * emacs.c (USAGE3): Doc fixes.
9335
0e48bb22
AS
93362011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9337
9338 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9339 structure.
9340
7684e57b
JB
93412011-03-14 Juanma Barranquero <lekktu@gmail.com>
9342
9343 * lisp.h (VWindow_system, Qfile_name_history):
9344 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9345 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9346 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9347
9348 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9349 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9350
9351 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9352 * w32console.c (detect_input_pending, read_input_pending)
9353 (encode_terminal_code):
9354 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9355 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9356 (w32_system_caret_y, Qfile_name_history):
9357 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9358 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9359 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9360 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9361 * w32proc.c (Qlocal, report_file_error):
9362 * w32term.c (Vwindow_system, updating_frame):
9363 * w32uniscribe.c (initialized, uniscribe_font_driver):
9364 Remove unneeded extern declarations.
9365
2aa46d6c
CY
93662011-03-14 Chong Yidong <cyd@stupidchicken.com>
9367
c96bbc66 9368 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9369
cffc6f3b
CY
93702011-03-13 Chong Yidong <cyd@stupidchicken.com>
9371
9372 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9373 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9374 These macros can no longer be used for assignment.
9375
44f230aa
SM
9376 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9377 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9378 (record_buffer_markers, fetch_buffer_markers): New functions for
9379 recording and fetching special buffer markers.
9380 (set_buffer_internal_1, set_buffer_temp): Use them.
9381
9382 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9383
9384 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9385
9386 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9387 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9388
9389 * xdisp.c (hscroll_window_tree):
9390 (reconsider_clip_changes): Use PT instead of BUF_PT.
9391
d251f04b
EZ
93922011-03-13 Eli Zaretskii <eliz@gnu.org>
9393
9394 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9395 $(EMACS_ROOT)/lib/intprops.h.
9396
f0c77cd1
PE
93972011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9398
3eca4629
PE
9399 Fix more problems found by GCC 4.5.2's static checks.
9400
7c86ee98
PE
9401 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9402 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9403 (xg_free_frame_widgets): Make it clear that a local variable is
9404 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9405 (gdk_window_get_screen): Make it clear that this macro is needed
9406 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9407 (int_gtk_range_get_value): New function, which avoids a diagnostic
9408 from gcc -Wbad-function-cast.
9409 (xg_set_toolkit_scroll_bar_thumb): Use it.
9410 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9411 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9412 (get_utf8_string, xg_get_file_with_chooser):
9413 Rename locals to avoid shadowing.
9414 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9415
41729b81
PE
9416 * xgselect.c (xg_select): Remove unused var.
9417
f0c77cd1
PE
9418 * image.c (four_corners_best): Mark locals as initialized.
9419 (gif_load): Initialize transparent_p to zero (Bug#8238).
9420 Mark another local as initialized.
ec6cf4c6 9421 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9422
ce0ad53d 9423 * image.c (clear_image_cache): Now static.
d5d5a617 9424 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9425 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9426 (x_edge_detection): Remove unnecessary cast that
9427 gcc -Wbad-function-cast diagnoses.
2037898d 9428 (gif_load): Fix pointer signedness.
6ae141d6
PE
9429 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9430 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9431
33383987 94322011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9433
d32df629
PE
9434 Improve quality of tests for time stamp overflow.
9435 For example, without this patch (encode-time 0 0 0 1 1
9436 1152921504606846976) returns the obviously-bogus value (-948597
9437 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9438 reports time overflow. See
9439 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9440 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9441 * editfns.c: Include limits.h and intprops.h.
9442 (TIME_T_MIN, TIME_T_MAX): New macros.
9443 (time_overflow): Move earlier, to before first use.
9444 (hi_time, lo_time): New functions, for an accurate test for
9445 out-of-range times.
9446 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9447 (Fget_internal_run_time): Don't assume time_t fits in int.
9448 (make_time): Use list2 instead of Fcons twice.
9449 (Fdecode_time): More accurate test for out-of-range times.
9450 (check_tm_member): New function.
9451 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9452 (lisp_time_argument): Don't rely on undefined left-shift and
9453 right-shift behavior when checking for time stamp overflow.
8be6f318 9454
fe31d94c
PE
9455 * editfns.c (time_overflow): New function, refactoring common code.
9456 (Fformat_time_string, Fdecode_time, Fencode_time):
9457 (Fcurrent_time_string): Use it.
9458
8be6f318
PE
9459 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9460 * dired.c (make_time): Move to ...
9461 * editfns.c (make_time): ... here.
9462 * systime.h: Note the move.
9463
09d9db2c 94642011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9465
126bc0dc
YM
9466 * fringe.c (update_window_fringes): Remove unused variables.
9467
c47cbdfd
YM
9468 * unexmacosx.c (copy_data_segment): Also copy __got section.
9469 (Bug#8223)
9470
7ac80be9
EZ
94712011-03-12 Eli Zaretskii <eliz@gnu.org>
9472
c96bbc66 9473 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9474 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9475 Constify `char *' arguments and their references according to
9476 prototypes in tparam.h.
9477
ecb0f94d 9478 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9479
7ac80be9
EZ
9480 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9481 Adapt all references accordingly.
9482
9483 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9484
ef1fd07e
TT
94852011-03-11 Tom Tromey <tromey@redhat.com>
9486
9487 * buffer.c (syms_of_buffer): Remove obsolete comment.
9488
7ef4b50c
EZ
94892011-03-11 Eli Zaretskii <eliz@gnu.org>
9490
9491 * termhooks.h (encode_terminal_code): Declare prototype.
9492
9493 * msdos.c (encode_terminal_code): Don't declare prototype.
9494
9495 * term.c (encode_terminal_code): Now external again, used by
9496 w32console.c and msdos.c.
9497
44f230aa
SM
9498 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9499 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9500
4b1ec863 95012011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9502
1714f52b 9503 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9504
4b1ec863
PE
9505 * fringe.c (update_window_fringes): Mark locals as initialized
9506 (Bug#8227).
9507 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9508
524c7aa6
PE
9509 * alloc.c (mark_fringe_data): Move decl from here ...
9510 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9511 to check its interface.
9512 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9513
a5c0af81 9514 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9515 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9516 (fontset_font): Mark local as initialized.
a9a06e0b 9517 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9518
b4716021
PE
9519 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9520
811e9bac 9521 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9522 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9523 (x_own_selection, Fx_disown_selection_internal): Rename locals
9524 to avoid shadowing.
9525 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9526
7e3ab302
PE
9527 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9528 so that the caller can use some name other than gcpro1.
9529 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9530 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9531 (Fx_backspace_delete_keys_p):
9532 Use them to avoid shadowing, and rename vars to avoid shadowing.
9533 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9534 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9535 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9536 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9537 Remove unused locals.
7e3ab302
PE
9538 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9539 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9540 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9541 macros.
f78faa98 9542
e2b13473
PE
9543 * xterm.h (x_mouse_leave): New decl.
9544
77f23912
PE
9545 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9546 Remove unused functions.
cdf4ba58
PE
9547 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9548 (x_calc_absolute_position): Now static.
7411c686 9549 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9550 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9551 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9552 unless they are used.
38d0b34a
PE
9553 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9554 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9555 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9556 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9557 (x_error_catcher, x_connection_closed, x_error_handler):
9558 (x_error_quitter, xembed_send_message, x_iconify_frame):
9559 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9560 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9561 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9562
44f230aa
SM
9563 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9564 Rename or move locals to avoid shadowing.
6b463e58 9565 (tty_defined_color, merge_face_heights): Now static.
5967d051 9566 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9567 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9568 does not deduce is never used uninitialized.
73719eba
PE
9569 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9570 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9571
426994c3 9572 * terminal.c (store_terminal_param): Now static.
5489860b 9573
032f1620 9574 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9575 (set_frame_menubar): Remove unused local.
d4323972 9576 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9577 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9578 since they might point to immutable storage.
281585b0
PE
9579 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9580 since it's unused otherwise.
032f1620 9581
367c19e5 9582 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9583 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9584 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9585 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9586 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9587 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9588 does not deduce are never used uninitialized.
70739cbe 9589
07b48fa9
PE
9590 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9591
8868a238 9592 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9593 * window.c (window_loop, size_window):
9594 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9595
7e5cf297 9596 * window.c (display_buffer): Now static.
d6550a9f
PE
9597 (size_window): Mark variables that gcc -Wuninitialized
9598 does not deduce are never used uninitialized.
a586633d
PE
9599 * window.h (check_all_windows): New decl, to forestall
9600 gcc -Wmissing-prototypes diagnostic.
5b555da1 9601 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9602
f6095868
PE
9603 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9604 shadowing.
9605 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9606 Include <limits.h>.
9607 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9608 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9609 (load_charset_map): Mark variables that gcc -Wuninitialized
9610 does not deduce are never used uninitialized.
53df7c11 9611 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9612
f38b440c
PE
9613 * coding.c (coding_set_source, coding_set_destination):
9614 Use "else { /* comment */ }" rather than "else /* comment */;"
9615 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9616 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9617 a block, when the outer 'i' will do.
9618 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9619 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9620 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9621 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9622 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9623 Rename locals to avoid shadowing.
9624 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9625 * coding.c (emacs_mule_char, encode_invocation_designation):
9626 Now static, since they're not used elsewhere.
413bb2db 9627 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9628 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9629 (decode_coding_emacs_mule): Mark variables that gcc
9630 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9631 (detect_coding_iso_2022): Initialize a local variable that might
9632 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9633 this initialization is needed. (Bug#8211)
5f58e762
PE
9634 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9635 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9636 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9637 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9638 Remove unused macros.
f38b440c 9639
232b38b9 9640 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9641 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9642 * character.c (string_count_byte8): Likewise.
232b38b9 9643
fb90da1b
PE
9644 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9645 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9646
fb93dbc2
PE
9647 * chartab.c (copy_sub_char_table): Now static, since it's not used
9648 elsewhere.
5c156ace
PE
9649 (sub_char_table_ref_and_range, char_table_ref_and_range):
9650 Rename locals to avoid shadowing.
bbcd0949 9651 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9652
7d3b3862 9653 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9654 (BIDI_BOB): Remove unused macro.
7d3b3862 9655
6be7d3da
PE
9656 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9657 deduce are never used uninitialized.
c2ed9c8b 9658 * term.c (encode_terminal_code): Likewise.
6be7d3da 9659
75f8807f 9660 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9661
50938595
PE
9662 * tparam.h: New file.
9663 * term.c, tparam.h: Include it.
9664 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9665 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9666 Move these decls to tparam.h, and make them agree with what
9667 is actually in tparam.c. The previous trick of using incompatible
9668 decls in different modules does not conform to the C standard.
9669 All callers of tparam changed to use tparam's actual API.
9670 * tparam.c (tparam1, tparam, tgoto):
9671 Use const pointers where appropriate.
9672
fbceeba2
PE
9673 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9674 * cm.h (struct cm): Likewise.
9675 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9676 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9677 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9678 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9679 (turn_on_face, init_tty): Likewise.
9680 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9681
7f3f1250
PE
9682 * term.c (term_mouse_position): Rename local to avoid shadowing.
9683
e6ca6543
PE
9684 * alloc.c (mark_ttys): Move decl from here ...
9685 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9686
c40f8d15
AS
96872011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9688
9689 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9690
cfe0661d
JB
96912011-03-09 Juanma Barranquero <lekktu@gmail.com>
9692
9693 * search.c (compile_pattern_1): Remove argument regp, unused since
9694 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9695 (compile_pattern): Don't pass it.
9696
0afb4571
J
96972011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9698
9699 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9700 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9701 for ! HAVE_GTK3.
9702 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9703
9704 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9705
9706 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9707 gdk_window_get_screen, gdk_window_get_geometry,
9708 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9709 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9710 (xg_get_pixbuf_from_pixmap): New function.
9711 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9712 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9713 Call xg_get_pixbuf_from_pixmap instead of
9714 gdk_pixbuf_get_from_drawable.
9715 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9716 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9717 (xg_check_special_colors): Use GtkStyleContext and its functions
9718 for HAVE_GTK3.
9719 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9720 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9721 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9722 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9723 Call gtk_widget_get_preferred_size.
0afb4571
J
9724 (xg_frame_resized): gdk_window_get_geometry only takes 5
9725 parameters.
44f230aa
SM
9726 (xg_win_to_widget, xg_event_is_for_menubar):
9727 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9728 (xg_set_widget_bg): New function.
9729 (delete_cb): New function.
895009e1 9730 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9731 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9732 (xg_set_background_color): Call xg_set_widget_bg.
9733 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9734 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9735 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9736 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9737 if ! HAVE_GTK3.
9738 (update_frame_tool_bar): Call gtk_widget_hide.
9739 (xg_initialize): Use GDK_KEY_g.
9740
9741 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9742 if ! HAVE_GTK3
9743 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9744
9745 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9746 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9747 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9748
1c2cc4ef
JB
97492011-03-08 Juanma Barranquero <lekktu@gmail.com>
9750
9751 * w32xfns.c (select_palette): Check success of RealizePalette against
9752 GDI_ERROR, not zero.
9753
33383987 9754See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9755
9756;; Local Variables:
9757;; coding: utf-8
aac0c6e3
MR
9758;; End:
9759
acaf905b 9760 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9761
9762 This file is part of GNU Emacs.
9763
9764 GNU Emacs is free software: you can redistribute it and/or modify
9765 it under the terms of the GNU General Public License as published by
9766 the Free Software Foundation, either version 3 of the License, or
9767 (at your option) any later version.
9768
9769 GNU Emacs is distributed in the hope that it will be useful,
9770 but WITHOUT ANY WARRANTY; without even the implied warranty of
9771 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9772 GNU General Public License for more details.
9773
9774 You should have received a copy of the GNU General Public License
9775 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.