Auto-generate EXFUN using make-docfile
[bpt/emacs.git] / src / ChangeLog
CommitLineData
404dbd37
TT
12012-07-03 Tom Tromey <tromey@redhat.com>
2
3 * window.c (Fset_window_margins, Fset_window_fringes)
4 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5 * textprop.c (Fprevious_property_change): No longer static.
6 * syntax.c (Fsyntax_table_p): No longer static.
7 * process.c (Fget_process, Fprocess_datagram_address): No longer
8 static.
9 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
10 * keyboard.c (Fcommand_execute): No longer static.
11 Remove EXFUN.
12 * insdel.c (Fcombine_after_change_execute): No longer static.
13 * image.c (Finit_image_library): No longer static.
14 * fileio.c (Fmake_symbolic_link): No longer static.
15 * eval.c (Ffetch_bytecode): No longer static.
16 * editfns.c (Fuser_full_name): No longer static.
17 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
18 longer static.
19 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
20 static.
21 * dired.c (Ffile_attributes): No longer static.
22 * composite.c (Fcomposition_get_gstring): No longer static.
23 * callproc.c (Fgetenv_internal): No longer static.
24
25 * ccl.h: Remove EXFUNs.
26 * buffer.h: Remove EXFUNs.
27 * dispextern.h: Remove EXFUNs.
28 * intervals.h: Remove EXFUNs.
29 * fontset.h: Remove EXFUN.
30 * font.h: Remove EXFUNs.
31 * dosfns.c (system_process_attributes): Remove EXFUN.
32 * keymap.h: Remove EXFUNs.
33 * lisp.h: Remove EXFUNs.
34 * w32term.h: Remove EXFUNs.
35 * window.h: Remove EXFUNs.
36 * xsettings.h: Remove EXFUN.
37 * xterm.h: Remove EXFUN.
38
8e4fd1e1
GM
392012-07-03 Glenn Morris <rgm@gnu.org>
40
41 * lisp.h (Frandom): Make it visible to C.
42 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
43 buffer for invisible buffers. (Bug#1229)
44
ca95b3eb
DA
452012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
46
47 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
48 values which aren't power of 2.
49 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
50 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
51 accordingly.
52
7555c33f
SM
532012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
54
55 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
56
57 * alloc.c (mark_object): Revert part of last patch to use `switch'.
58
d12e8f5a
DA
592012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
60
61 * alloc.c (allocate_vector_block): Remove redundant
62 calls to mallopt if DOUG_LEA_MALLOC is defined.
63 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
64 avoid calls to mallopt if zero_vector is returned.
65
296094c3
DA
662012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
67
68 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
69 is enabled, avoid dereferencing NULL current_sblock if
70 running undumped.
71
36429c89
DA
722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
73
74 Cleanup basic buffer management.
75 * buffer.h (struct buffer): Change layout to use generic vector
76 marking code. Fix some comments. Change type of 'clip_changed'
77 to bitfield. Remove unused #ifndef old.
78 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
79 (GET_OVERLAYS_AT): Fix indentation.
80 (for_each_per_buffer_object_at): New macro.
81 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
82 (Fbuffer_local_variables): Use it.
83 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
84 * alloc.c (allocate_buffer): Adjust to match new layout of
85 struct buffer. Fix comment.
86 (mark_overlay): New function.
87 (mark_buffer): Use it. Use mark_vectorlike to mark normal
88 Lisp area of struct buffer.
89 (mark_object): Use it. Adjust marking of misc objects
90 and related comments.
91
3b3e4cac
PE
922012-07-02 Paul Eggert <eggert@cs.ucla.edu>
93
94 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
95 wrapper that is not needed because the wrapped code is a no-op (zero
96 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
97 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
98
cf5c0175
DA
992012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
100
101 * alloc.c (mark_buffer): Simplify. Remove prototype.
102 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 103 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
104 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
105 redundant calls to mark_vectorlike for bool vectors.
106
ca26824c
GM
1072012-06-30 Glenn Morris <rgm@gnu.org>
108
2e4c5312
GM
109 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
110
ca26824c
GM
111 * epaths.in (PATH_SITELOADSEARCH): New.
112 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
113 This is rather than relying on --enable-locallisppath elements
114 having "site-lisp" in their names. (Bug#10208#25, 11658)
115
0d23c240
EZ
1162012-06-30 Eli Zaretskii <eliz@gnu.org>
117
c9240d7a
EZ
118 * w32proc.c (sys_select): Accept and ignore one more argument.
119
120 * w32.c (emacs_gnutls_pull): Call select with one more argument.
121
0d23c240 122 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 123 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
124
125 * sysdep.c: Don't include dos.h and dosfns.h.
126
127 * process.c (sys_select):
128 * msdos.c (sys_select): Accept one more argument and ignore it.
129
130 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
131 adapt data types and code to that.
132
133 * dosfns.c:
134 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
135 which clashes with the gnulib function of the same name.
136
af5a5a98
AS
1372012-06-30 Andreas Schwab <schwab@linux-m68k.org>
138
c5e4379c
AS
139 * font.c (font_style_to_value, font_style_symbolic)
140 (font_prop_validate_style): Add type checks for values in
141 font_style_table.
142
af5a5a98
AS
143 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
144 argument.
145 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
146 uses.
147
8d38f461
EZ
1482012-06-29 Eli Zaretskii <eliz@gnu.org>
149
2e5a6631
EZ
150 * xdisp.c (try_window_id): Undo last change.
151
8d38f461
EZ
152 * w32.c (getwd): Adjust commentary about startup_dir.
153 (init_environment): Always call sys_access, even in non-MSVC
154 builds. Don't chdir to the directory of the Emacs executable.
155 This undoes code from 1997 which was justified by the need to
156 "avoid conflicts when removing and renaming directories". But its
157 downside was that every relative file name was being interpreted
158 relative to the directory of the Emacs executable, which can never
159 be TRT. In particular, it broke sys_access when called with
160 relative file names.
161 (sys_access): Map GetLastError to errno.
162
2af3565e
DA
1632012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
164
165 * window.h (struct window): Change type of 'fringes_outside_margins'
166 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 167 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
168 Adjust comment.
169 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
170 to ptrdiff_t.
171
c8d3a25c 1722012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 173
c8d3a25c
GM
174 * gnutls.c (emacs_gnutls_handshake):
175 Add QUIT to make the loop interruptible.
57570cd3 176
c8d3a25c 1772012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 178
c8d3a25c
GM
179 * charset.c (init_charset): Make lack of etc/charsets fatal.
180
3e984ee8
DA
1812012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
182
183 * editfns.c (region_limit): Fix type mismatch.
184
ef884f23
DA
1852012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
186
187 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
188 undefined. Convert from xassert to eassert.
189 * nsmenu.m: Convert from xassert to eassert.
190 * nsterm.m: Likewise.
191
7d7e0027
SM
1922012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
193
194 * editfns.c (region_limit): Clip to narrowing (bug#11770).
195
aa754e6a
PE
1962012-06-28 Paul Eggert <eggert@cs.ucla.edu>
197
198 Avoid integer overflow on scroll-left and scroll-right.
199 * window.c (HSCROLL_MAX): New macro.
200 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
201 overflow when requested scroll falls outside ptrdiff_t range.
202
80b00b08
DA
2032012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
204
205 * window.h (struct window): Change type of 'hscroll',
206 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
207 'last_modified' and 'last_overlay_modified' to EMACS_INT.
208 Adjust users accordingly.
209 * xdisp.c (try_cursor_movement): Replace type check with eassert.
210 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
211 from EMACS_INT to ptrdiff_t.
212 (make_window): Omit redundant initialization.
213
62b2bcf6
JB
2142012-06-28 Juanma Barranquero <lekktu@gmail.com>
215
216 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
217
45942c7d
DA
2182012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
219
220 * window.h (struct window): Change type of 'use_time' and
221 'sequence_number' from Lisp_Object to int.
222 * frame.c (make_frame): Adjust users accordingly.
223 * print.c (print_object): Likewise.
224 * window.c (select_window, Fwindow_use_time, make_parent_window)
225 (make_window): Likewise.
226
e509cfa6
DA
2272012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
230 enabled with --enable-checking=[all,glyphs] configure option.
231 Fix GLYPH_DEBUG usage assuming that it may be undefined,
232 adjust comments accordingly.
233 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
234 undefined, adjust comments accordingly.
235 * image.c: Likewise.
236 * scroll.c: Likewise.
237 * w32fns.c: Likewise.
238 * w32term.c: Likewise.
239 * xdisp.c: Likewise.
240 * xfaces.c: Likewise.
241 * xfns.c: Likewise.
242 * xterm.c: Likewise.
243
a54e2c05
DA
2442012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Generalize run-time debugging checks.
247 * dispextern.h (XASSERTS): Remove.
248 * fontset.c (xassert): Remove.
249 Convert from xassert to eassert.
250 * alloc.c: Convert from xassert to eassert.
251 * bidi.c: Likewise.
252 * dispnew.c: Likewise.
253 * fns.c: Likewise.
254 * fringe.c: Likewise.
255 * ftfont.c: Likewise.
256 * gtkutil.c: Likewise.
257 * image.c: Likewise.
258 * keyboard.c: Likewise.
259 * menu.c: Likewise.
260 * process.c: Likewise.
261 * scroll.c: Likewise.
262 * sound.c: Likewise.
263 * term.c: Likewise.
264 * w32console.c: Likewise.
265 * w32fns.c: Likewise.
266 * w32term.c: Likewise.
267 * window.c: Likewise.
268 * xdisp.c: Likewise.
269 * xfaces.c: Likewise.
270 * xfns.c: Likewise.
271 * xselect.c: Likewise.
272 * xterm.c: Likewise.
273
1ec4b7b2
SM
2742012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
275
276 * fns.c (maybe_resize_hash_table): Output message when growing the
277 purify-hashtable.
278
2014308a
DA
2792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
280
281 * alloc.c (allocate_string_data): Remove dead code.
282 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
283 avoid GCC warning about unused macro.
284
246155eb
DA
2852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
286
287 * alloc.c (allocate_string): Omit intervals initialization.
288 * alloc.c (make_uninit_multibyte_string): Initialize intervals
289 as in make_pure_string and make_pure_c_string.
290
43184b7b
DA
2912012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
292
293 * alloc.c (allocate_string): Fix last change.
294
3fe6dd74
DA
2952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
296
297 * alloc.c (allocate_string): Remove two redundant calls
298 to memset, add explicit initialization where appropriate.
299
1ba6038a
GM
3002012-06-27 Glenn Morris <rgm@gnu.org>
301
302 * lisp.mk (lisp): Remove paths.elc.
303
c89926a5
CY
3042012-06-27 Chong Yidong <cyd@gnu.org>
305
306 * doc.c (Fsubstitute_command_keys): Fix punctuation.
307
ed6b3510
JW
3082012-06-26 John Wiegley <johnw@newartisans.com>
309
1ec4b7b2 310 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
311 on Mac OS X Lion: __mod_init_func and __mod_term_func.
312
ed6b3510
JW
313 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
314 when building with Clang.
315
8edd4a2b
SM
3162012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
317
318 * eval.c (Fapply): Allow calling it with a single argument.
319
f6f62d1b
EZ
3202012-06-26 Eli Zaretskii <eliz@gnu.org>
321
322 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
323 _stricmp and _strnicmp.
324 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
325
62efea5e
DA
3262012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
327
328 * alloc.c (allocate_window): Zero out non-Lisp part of newly
329 allocated window.
330 (allocate_process): Likewise for new process.
8edd4a2b 331 (allocate_terminal): Change to use offsetof.
62efea5e
DA
332 (allocate_frame): Likewise.
333 * frame.c (make_frame): Omit redundant initialization.
334 * window.c (make_parent_window): Use memset.
335 (make_window): Omit redundant initialization.
336 * process.c (make_process): Omit redundant initialization.
337 * terminal.c (create_terminal): Likewise.
338
42997f4d
DA
3392012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
340
341 * term.c (delete_tty): Remove redundant call to memset.
342
1130ecfc
DA
3432012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
344
345 * alloc.c: Remove build_string.
346 * lisp.h: Define build_string as static inline. This provides
347 a better opportunity to optimize away calls to strlen when the
348 function is called with compile-time constant argument.
349 * image.c (imagemagick_error): Convert to build_string.
350 * w32proc.c (sys_spawnve): Likewise.
351 * xterm.c (x_term_init): Likewise.
352
cf38a720
PE
3532012-06-26 Paul Eggert <eggert@cs.ucla.edu>
354
99027bdd
PE
355 Use sprintf return value instead of invoking strlen on result.
356 In the old days this wasn't portable, since some sprintf
357 implementations returned char *. But they died out years ago and
358 Emacs already assumes sprintf returns int.
359 Similarly for float_to_string.
360 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
361 * ccl.c (ccl_driver):
362 * character.c (string_escape_byte8):
363 * data.c (Fnumber_to_string):
364 * doprnt.c (doprnt):
365 * print.c (print_object):
366 * xdisp.c (message_dolog):
367 * xfns.c (syms_of_xfns):
368 Use sprintf or float_to_string result to avoid need to call strlen.
369 * data.c (Fnumber_to_string):
370 Use make_unibyte_string, since the string must be ASCII.
371 * lisp.h, print.c (float_to_string): Now returns int length.
372 * term.c (produce_glyphless_glyph):
373 Use sprintf result rather than recomputing it.
374
cf38a720
PE
375 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
376 * Makefile.in (ALL_CFLAGS):
377 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
378 * gmalloc.c, regex.c: Include <config.h> unconditionally.
379
3511c784
DA
3802012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
381
0a08eb21 382 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
383 strcasecmp if available.
384 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
385
fb7da12e
AS
3862012-06-25 Andreas Schwab <schwab@linux-m68k.org>
387
388 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
389 Avoid comma operator.
390 * menu.c (push_submenu_start, push_submenu_end)
391 (push_left_right_boundary, push_menu_pane): Likewise.
392 * msdos.c (dos_rawgetc): Likewise.
393
afa2ffd8
DA
3942012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
395
396 * xfns.c (xic_create_fontsetname): Remove redundant calls
397 to memset.
398
b3b4476b
PE
3992012-06-25 Paul Eggert <eggert@cs.ucla.edu>
400
4495ff38
PE
401 * gtkutil.c (get_utf8_string): Remove redundant assignment.
402 sprintf already null-terminates its output.
403
b3b4476b
PE
404 * xfns.c (x_window): Remove redundant cast.
405
b00876c9
DA
4062012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
407
408 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
409 `const char *' to `char *' to avoid compiler warning.
410
d188e26b
PE
4112012-06-24 Paul Eggert <eggert@cs.ucla.edu>
412
885d1d74
PE
413 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
414 instead of truncating it to 63 (admittedly a generous limit).
415
d188e26b
PE
416 * process.c: Fix spelling and caps in comments.
417
e2f560b1
DN
4182012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
419
e86db54b 420 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
421 * sysdep.c (setpgrp): Remove definition, not used in this file.
422
7583a3a1
JB
4232012-06-24 Juanma Barranquero <lekktu@gmail.com>
424
425 * makefile.w32-in: Update dependencies.
426
696056c2
EZ
4272012-06-24 Eli Zaretskii <eliz@gnu.org>
428
429 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
430 (SYSTIME_H): Add nt/inc/sys/time.h.
431
432 * systime.h [WINDOWSNT]: Include sys/time.h.
433
434 * s/ms-w32.h (struct timespec): Definition moved from
435 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
436
845ca893
PE
4372012-06-24 Paul Eggert <eggert@cs.ucla.edu>
438
439 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
440 * buffer.h (buffer_slot_type_mismatch):
441 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
442 * eval.c (unwind_to_catch):
443 * image.c (my_png_error, my_error_exit):
444 * keyboard.c (quit_throw_to_read_char, user_error)
445 (Fexit_recursive_edit, Fabort_recursive_edit):
446 * lisp.h (die, args_out_of_range, args_out_of_range_3)
447 (wrong_type_argument, buffer_overflow, __executable_start)
448 (memory_full, buffer_memory_full, string_overflow, Fthrow)
449 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
450 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
451 (fatal):
452 (child_setup) [!DOS_NT]:
453 * lread.c (end_of_file_error, invalid_syntax):
454 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
455 * puresize.h (pure_write_error):
456 * search.c (matcher_overflow):
457 * sound.c (sound_perror, alsa_sound_perror):
458 * sysdep.c, syssignal.h (croak):
459 * term.c (maybe_fatal, vfatal):
460 * textprop.c (text_read_only):
461 * undo.c (user_error):
462 * unexmacosx.c (unexec_error):
463 * xterm.c (x_ins_del_lines, x_delete_glyphs):
464 Use _Noreturn rather than NO_RETURN.
465 No need for separate decl merely because of _Noreturn.
466 * sound.c (sound_warning, parse_sound):
467 Remove unnecessary forward decls.
468
f1dd8073
PE
4692012-06-24 Paul Eggert <eggert@cs.ucla.edu>
470
471 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
472 * lisp.h (WAIT_READING_MAX): New macro.
473 * dispnew.c (Fsleep_for, sit_for):
474 * keyboard.c (kbd_buffer_get_event):
475 * process.c (Faccept_process_output):
476 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
477 This improves on the previous patch, which introduced a bug
478 when time_t is unsigned and as wide as intmax_t.
479 See <http://bugs.gnu.org/9000#51>.
480
b82c1755
EZ
4812012-06-23 Eli Zaretskii <eliz@gnu.org>
482
483 * dispnew.c (sit_for, Fsleep_for):
484 * keyboard.c (kbd_buffer_get_event):
485 * process.c (Faccept_process_output): Avoid compiler warnings when
486 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
487
ca300656
JB
4882012-06-23 Juanma Barranquero <lekktu@gmail.com>
489
049ec95b
JB
490 * makefile.w32-in: Update dependencies.
491
ca300656
JB
492 * w32.c (ltime): Add return type and declare static.
493 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
494
db7b8d06
PE
4952012-06-23 Paul Eggert <eggert@cs.ucla.edu>
496
497 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
498 Privately reported by Herbert J. Skuhra.
499 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
500 All uses changed.
501 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
502 not make_lisp_timeval, when the argument is of type EMACS_TIME.
503
0bd8297f
EZ
5042012-06-23 Eli Zaretskii <eliz@gnu.org>
505
96512555
EZ
506 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
507 last argument of make_unibyte_string.
508
0bd8297f
EZ
509 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
510 language ID in the event parameters.
511
512 * w32term.c (w32_read_socket): Put the new keyboard codepage into
513 event.code, not the obscure "character set ID".
514
63def6b6
CY
5152012-06-23 Chong Yidong <cyd@gnu.org>
516
517 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
518
e8a02204
EZ
5192012-06-23 Eli Zaretskii <eliz@gnu.org>
520
388cdec0
EZ
521 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
522 * w32.c (fdutimens): New function.
523
524 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
525
526 * s/ms-w32.h (pselect): Redirect to sys_select.
527
528 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
529
e8a02204
EZ
530 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
531 in the logic of incrementing and decrementing the value of
532 use_relocatable_buffers.
533
d054f3fb
PE
5342012-06-23 Paul Eggert <eggert@cs.ucla.edu>
535
536 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
537 Privately reported by Herbert J. Skuhra.
538 [__FreeBSD__]: Remove "*/" typo after "#include".
539 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
540 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
541 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
542 Don't assume EMACS_TIME and struct timeval are the same type.
543
d35af63c
PE
5442012-06-22 Paul Eggert <eggert@cs.ucla.edu>
545
546 Support higher-resolution time stamps (Bug#9000).
547 The time stamps are only nanosecond-resolution at the C level,
548 since that's the best that any real-world system supports now.
549 But they are picosecond-resolution at the Lisp level, as that's
550 easy, and leaves room for future OS improvements.
551
552 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
553 (LIBES): Use it.
554
555 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
556 Don't get current time unless it's needed.
557
558 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
559 now provides it if it's absent.
560 (start_atimer): Port to higher-res time stamps.
561 Check for time stamp overflow. Don't get current time more
562 often than is needed.
563
564 * buffer.h (struct buffer): Buffer modtime now has high resolution.
565 Include systime.h, not time.h.
566 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
567
568 * dired.c: Include stat-time.h.
569 (Ffile-attributes): File times now have higher resolution.
570
571 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
572 (struct image): Timestamp now has higher resolution.
573
574 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
575 has at least microseconds now. All uses removed.
576 (update_frame, update_single_window, update_window, update_frame_1)
577 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
578
579 * editfns.c (time_overflow): Now extern.
580 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
581 (float-time, Fformat_time_string, Fcurrent_time_string)
582 (Fcurrent_time_zone): Accept and generate higher-resolution
583 time stamps.
584 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
585 (decode_time_components, lisp_seconds_argument): New functions.
586 (make_time): Now static.
587 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
588 Report an error if the time is invalid, rather than having the caller
589 do that.
590
591 * fileio.c: Include <stat-time.h>
592 (Fcopy_file): Copy higher-resolution time stamps.
593 Prefer to set the time stamp via a file descriptor if that works.
594 (Fset_file_times, Finsert_file_contents, Fwrite_region)
595 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
596 (Fvisited_file_modtime, Fset_visited_file_modtime):
597 Support higher-resolution time stamps.
598
599 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
600
601 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
602
603 * image.c (prepare_image_for_display, clear_image_cache)
604 (lookup_image): Port to higer-resolution time stamps.
605
606 * keyboard.c (start_polling, bind_polling_period):
607 Check for time stamp overflow.
608 (read_char, kbd_buffer_get_event, timer_start_idle)
609 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
610 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
611 Port to higher-resolution time stamps. Do not assume time_t is signed.
612 (decode_timer): New function. Timers are now vectors of length 9,
613 not 8, to accommodate the picosecond component.
614 (timer_check_2): Use it.
615
616 * nsterm.m (select_timeout, timeval_subtract): Remove.
617 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
618 as they're a bit more accurate and handle overflow better.
619 (ns_select): Change prototype to be compatible with pselect.
620 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
621 * nsterm.h (ns_select): Adjust prototype.
622
623 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
624 us-resolution time stamps.
625 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
626
627 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
628
629 * lisp.h (time_overflow): New decl.
630 (wait_reading_process_output): First arg is now intmax_t, not int,
631 to accommodate larger waits.
632
633 * process.h (struct Lisp_Process.read_output_delay):
634 Now counts nanoseconds, not microseconds.
635 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
636 EMACS_HAS_USECS.
637 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
638 (wait_reading_process_output):
639 Port to ns-resolution time stamps.
640 (Faccept_process_output, wait_reading_process_output):
641 Check for time stamp overflow. Do not assume time_t is signed.
642 (select_wrapper): Remove; we now use pselect.
643 (Fprocess_attributes): Now generates ns-resolution time stamps.
644
645 * sysdep.c: Include utimens.h. Don't include utime.h
646 or worry about struct utimbuf; gnulib does that for us now.
647 (gettimeofday): Remove; gnulib provides a substitute.
648 (make_timeval): New function.
649 (set_file_times): Now sets ns-resolution time stamps.
650 New arg FD; all uses changed.
651 (time_from_jiffies, ltime_from_jiffies, get_up_time)
652 (system_process_attributes):
653 Now returns ns-resolution time stamp. All uses changed.
654 Check for time stamp overflow.
655
656 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
657 provides a substitute now.
658
659 * systime.h: Include timespec.h rather than sys/time.h and time.h,
660 since it guarantees struct timespec.
661 (EMACS_TIME): Now struct timespec, so that we can support
662 ns-resolution time stamps.
663 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
664 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
665 (EMACS_USECS): Remove.
666 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
667 so multiply the arg by 1000 before storing it.
668 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
669 New macros.
670 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
671 Port to ns-resolution time stamps.
672 (EMACS_TIME_NEG_P): Remove; replaced by....
673 (EMACS_TIME_SIGN): New macro.
674 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
675 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
676 (set_file_times, make_time, lisp_time_argument): Adjust signature.
677 (make_timeval, make_lisp_time, decode_time_components): New decls.
678 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
679 that it mishandled time_t overflow. You can't compare by subtracting!
680 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
681 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
682
683 * term.c: Include <sys/time.h>.
684 (timeval_to_Time): New function, for proper overflow wraparound.
685 (term_mouse_position, term_mouse_click): Use it.
686
687 * undo.c (record_first_change): Support higher-resolution time stamps
688 in the undo buffer.
689 (Fprimitive_undo): Use them when restoring time stamps.
690
691 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
692 (w32_get_internal_run_time):
693 Port to higher-resolution Emacs time stamps.
694 (ltime): Now accepts single 64-bit integer, as that's more convenient
695 for callers.
696
697 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
698
699 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
700 for compatibility with pselect. Support ns-resolution time stamps.
701
702 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
703
704 * xselect.c (wait_for_property_change, x_get_foreign_selection):
705 Check for time stamp overflow, and support ns-resolution time stamps.
706
707 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
708 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
709 (timeval_subtract): Remove; no longer needed.
710 (XTflash, XTring_bell, x_wait_for_event):
711 Port to ns-resolution time stamps. Don't assume time_t is signed.
712
b6a92dfe
CY
7132012-06-22 Chong Yidong <cyd@gnu.org>
714
715 * xdisp.c (x_consider_frame_title): Revert last change.
716
d251c37c
EZ
7172012-06-22 Eli Zaretskii <eliz@gnu.org>
718
719 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
720 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
721 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
722 staticidx goes up to 1597 out of 1600 = 0x640.)
723
f10deafb
PE
7242012-06-20 Paul Eggert <eggert@cs.ucla.edu>
725
726 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
727 Otherwise, the umask might be mistakenly 0 while handling input signals.
728
ec6de1e2
SM
7292012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
730
731 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
732
28be1ada
DA
7332012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
734
735 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
736 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
737 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
738 access to `contents' member of Lisp_Vector objects with AREF and ASET
739 where appropriate.
740
c6bf3022
CY
7412012-06-19 Chong Yidong <cyd@gnu.org>
742
743 * frame.c (delete_frame): When selecting a frame on a different
744 text terminal, do not alter the terminal's top-frame.
745
746 * xdisp.c (format_mode_line_unwind_data): Record the target
747 frame's selected window and its terminal's top-frame.
748 (unwind_format_mode_line): Restore them.
749 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
750 Callers changed.
751 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
752 since tty frames can be explicitly named.
753 (prepare_menu_bars): Likewise.
754
755 * term.c (Ftty_top_frame): New function.
756
defd4196
PE
7572012-06-18 Paul Eggert <eggert@cs.ucla.edu>
758
759 Port byte-code-meter to modern targets.
760 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
761 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 762 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
763 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
764 (METER_1, METER_2): Simplify.
765
1053a871
SM
7662012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
767
768 * data.c (Fdefalias): Return `symbol' (bug#11686).
769
b7e8d081
MR
7702012-06-18 Martin Rudalics <rudalics@gmx.at>
771
772 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
773 gets killed during executing of this function (Bug#11665).
774 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
775 (Vkill_buffer_query_functions): In doc-string say that functions
776 run by this hook should not change the current buffer.
777
7ea2b339
PE
7782012-06-18 Paul Eggert <eggert@cs.ucla.edu>
779
780 Fix recently-introduced process.c problems found by static checking.
781 * process.c (write_queue_push, write_queue_pop, send_process):
782 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
783 (write_queue_pop): Fix pointer signedness problem.
784 (send_process): Remove unused local.
785
96a313a1
CY
7862012-06-17 Chong Yidong <cyd@gnu.org>
787
788 * xdisp.c (redisplay_internal): No need to redisplay terminal
789 frames that are not on top.
790
20ca2e94
TN
7912012-06-17 Troels Nielsen <bn.troels@gmail.com>
792
793 * process.c (make_process): Initialize write_queue.
794 (write_queue_push, write_queue_pop): New functions.
795 (send_process): Use them to maintain correct ordering of process
796 writes (Bug#10815).
797
9a900ca9
PE
7982012-06-17 Paul Eggert <eggert@cs.ucla.edu>
799
310fbfa8
PE
800 * lisp.h (eassert): Assume C89 or later.
801 This removes the need for CHECK.
802 (CHECK): Remove. Its comments about always evaluating its
803 argument were confusing, as 'eassert' typically does not evaluate
804 its argument.
805
27bb1ca4
PE
806 * coding.c (produce_chars): Use ptrdiff_t, not int.
807
9a900ca9
PE
808 * xterm.c (x_draw_underwave): Check for integer overflow.
809 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
810
41b7f8bc 8112012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
812
813 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
814 referenced (Bug#11583).
815
9b0e3eba
AA
8162012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
817
818 Implement wave-style variant of underlining.
819 * dispextern.h (face_underline_type): New enum.
820 (face): Add field for underline type.
821 * nsterm.m (ns_draw_underwave): New function.
822 (ns_draw_text_decoration): Use it.
823 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
824 New functions.
825 (x_draw_glyph_string): Use them.
826 * xfaces.c (Qline, Qwave): New Lisp objects.
827 (check_lface_attrs, merge_face_ref)
1053a871
SM
828 (Finternal_set_lisp_face_attribute, realize_x_face):
829 Handle wave-style underline face attributes.
9b0e3eba
AA
830 * xterm.c (x_draw_underwave): New function.
831 (x_draw_glyph_string): Use it.
832
0fb52f11
JB
8332012-06-16 Juanma Barranquero <lekktu@gmail.com>
834
835 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
836 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
837 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
838 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
839 ($(BLD)/w32select.$(O)): Update dependencies.
840
e5560ff7
AS
8412012-06-16 Andreas Schwab <schwab@linux-m68k.org>
842
843 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
844 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
845 * character.c (_fetch_multibyte_char_p): Remove.
846 * alloc.c: Include "character.h" before "buffer.h".
847 * bidi.c: Likewise.
848 * buffer.c: Likewise.
849 * bytecode.c: Likewise.
850 * callint.c: Likewise.
851 * callproc.c: Likewise.
852 * casefiddle.c: Likewise.
853 * casetab.c: Likewise.
854 * category.c: Likewise.
855 * cmds.c: Likewise.
856 * coding.c: Likewise.
857 * composite.c: Likewise.
858 * dired.c: Likewise.
859 * dispnew.c: Likewise.
860 * doc.c: Likewise.
861 * dosfns.c: Likewise.
862 * editfns.c: Likewise.
863 * emacs.c: Likewise.
864 * fileio.c: Likewise.
865 * filelock.c: Likewise.
866 * font.c: Likewise.
867 * fontset.c: Likewise.
868 * fringe.c: Likewise.
869 * indent.c: Likewise.
870 * insdel.c: Likewise.
871 * intervals.c: Likewise.
872 * keyboard.c: Likewise.
873 * keymap.c: Likewise.
874 * lread.c: Likewise.
875 * macros.c: Likewise.
876 * marker.c: Likewise.
877 * minibuf.c: Likewise.
878 * nsfns.m: Likewise.
879 * nsmenu.m: Likewise.
880 * print.c: Likewise.
881 * process.c: Likewise.
882 * regex.c: Likewise.
883 * region-cache.c: Likewise.
884 * search.c: Likewise.
885 * syntax.c: Likewise.
886 * term.c: Likewise.
887 * textprop.c: Likewise.
888 * undo.c: Likewise.
889 * unexsol.c: Likewise.
890 * w16select.c: Likewise.
891 * w32fns.c: Likewise.
892 * w32menu.c: Likewise.
893 * window.c: Likewise.
894 * xdisp.c: Likewise.
895 * xfns.c: Likewise.
896 * xmenu.c: Likewise.
897 * xml.c: Likewise.
898 * xselect.c: Likewise.
899
2f07e6af
EZ
9002012-06-16 Eli Zaretskii <eliz@gnu.org>
901
1053a871
SM
902 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
903 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 904 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
905 row.
906 (handle_face_prop): Use chunk-relative overlay string index when
907 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
908 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
909 the rightmost. (Bug#11720)
2f07e6af 910
29b83cec
AS
9112012-06-16 Andreas Schwab <schwab@linux-m68k.org>
912
913 * category.h (CHAR_HAS_CATEGORY): Define as inline.
914 (CATEGORY_MEMBER): Enforce 1/0 value.
915 * category.c (_temp_category_set): Remove.
916
4c5501e9
EZ
9172012-06-16 Eli Zaretskii <eliz@gnu.org>
918
919 * window.c (Fdelete_other_windows_internal)
920 (Fdelete_window_internal): Don't access frame's mouse highlight
921 info of the initial frame. (Bug#11677)
922
2b570124
PE
9232012-06-14 Paul Eggert <eggert@cs.ucla.edu>
924
e93864f9
PE
925 * .gdbinit (xgetint): Fix recently-introduced paren typo.
926 Assume USE_2_TAGS_FOR_INTS.
927 (xreload): Adjust $tagmask width to match recent lisp.h change.
928
2b570124
PE
929 Simplify lisp.h in minor ways that should not affect code.
930 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
931 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
932 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
933 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
934 (INTTYPEBITS): New macro, for clarity.
935 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
936 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
937 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
938 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
939 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
940
81755f69
JB
9412012-06-13 Juanma Barranquero <lekktu@gmail.com>
942
943 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
944
16192a57
GM
9452012-06-13 Glenn Morris <rgm@gnu.org>
946
947 * s/bsd-common.h (BSD4_3):
948 * s/usg5-4-common.h (USG5_4): No longer define; unused.
949
646b5f55
AS
9502012-06-13 Andreas Schwab <schwab@linux-m68k.org>
951
952 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
953 instead of union.
954 (XLI, XIL): Define.
1053a871
SM
955 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
956 Use them.
957 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 958 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 959 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
960 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
961 * frame.c (delete_frame): Remove outdated comment.
962 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
963 USE_LISP_UNION_TYPE.
964 (Fw32_unregister_hot_key): Likewise.
965 (Fw32_toggle_lock_key): Likewise.
966 * w32menu.c (add_menu_item): Likewise.
967 (w32_menu_display_help): Use XIL instead of checking
968 USE_LISP_UNION_TYPE.
969 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
970 (init_heap): Likewise.
971 * w32term.c (w32_read_socket): Update comment.
972
1d3823c9
GM
9732012-06-13 Glenn Morris <rgm@gnu.org>
974
c62ff706
GM
975 * s/usg5-4-common.h, src/s/unixware.h:
976 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
977
1d3823c9
GM
978 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
979
bfe3e0a2
PE
9802012-06-13 Paul Eggert <eggert@cs.ucla.edu>
981
982 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
983 * alloc.c (make_number) [!defined make_number]:
984 Remove, as lisp.h always defines this now.
985 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
986 (roundup_size): Verify that it is a power of 2.
987 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
988 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
989 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
990 -DUSE_LSB_TAG=0, to override the automatically-selected default.
991 USE_LSB_TAG now is always defined to be either 0 or 1.
992 All uses changed.
993 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
994 code works fine either way, and efficiency is not a concern here,
995 as the union type is for debugging, not for production.
996 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
997 Use an inline function on all platforms when using the union type,
998 since this is simpler and 'static inline' can be used portably
999 within Emacs now.
1000 (LISP_INITIALLY_ZERO): New macro.
1001 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1002 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1003
45fa9c0f
GM
10042012-06-12 Glenn Morris <rgm@gnu.org>
1005
b4492cba
GM
1006 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1007
1008 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1009
45fa9c0f
GM
1010 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1011 Move BROKEN_SIGIO to configure.
1012
1013 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1014 Move NO_TERMIO to configure.
1015
0e25d334
CY
10162012-06-12 Chong Yidong <cyd@gnu.org>
1017
1018 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1019 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1020 MagickExportImagePixels is undefined.
1021
43682bb6
PE
10222012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * image.c (imagemagick_load_image): Remove unused label.
1025
a9be7d2b
GM
10262012-06-11 Glenn Morris <rgm@gnu.org>
1027
1028 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1029 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1030 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1031 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1032
3017f87f
SM
10332012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1034
1035 * alloc.c (make_byte_code): New function.
1036 (Fmake_byte_code): Use it. Don't purify here.
1037 * lread.c (read1): Use it as well to avoid extra allocation.
1038
1b9b4cf4
CY
10392012-06-11 Chong Yidong <cyd@gnu.org>
1040
1041 * image.c (imagemagick_load_image): Implement transparency.
1042
95988fcf
AS
10432012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1044
1045 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1046 account for preceding backslashes. (Bug#11663)
1047
cd4eb164
CY
10482012-06-09 Chong Yidong <cyd@gnu.org>
1049
1050 * term.c: Support italics in capable terminals (Bug#9652).
1051 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1052 (turn_on_face): Output using TS_enter_italic_mode if available.
1053 Don't handle unused blinking and alt-charset cases.
1054 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1055 and tty_alt_charset_p cases.
1056 (tty_capable_p, init_tty): Support italics.
1057
1058 * termchar.h (struct tty_display_info): Add field for italics.
1059 Remove unused blink field.
1060
1061 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1062 Handle slant.
1063
1064 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1065 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1066 tty_alt_charset_p. Add tty_italic_p.
1067
ff88beb8
MA
10682012-06-09 Michael Albinus <michael.albinus@gmx.de>
1069
1070 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1071 dbus_type_is_basic if available.
1072 (xd_extract_signed, xd_extract_unsigned): Rename from
1073 extract_signed and extract_unsigned, respectively. Adapt callers.
1074
44286096
CY
10752012-06-09 Chong Yidong <cyd@gnu.org>
1076
1682701f
CY
1077 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1078
44286096
CY
1079 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1080 case (Bug#9752).
1081
d86feb17
PE
10822012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1083
1084 * xdisp.c (vmessage): Treat frame message as multibyte.
1085 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1086 would generate the diagnostic "Making \302\247 buffer-local while
1087 let-bound!".
1088
d5c20fe8
EZ
10892012-06-08 Eli Zaretskii <eliz@gnu.org>
1090
1091 * dispnew.c (showing_window_margins_p): Undo last change, which
1092 was done due to an inadvertent commit.
1093 (adjust_frame_glyphs_for_frame_redisplay): Do call
1094 showing_window_margins_p.
1095
513749ee
SM
10962012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1097
1098 * eval.c (Fmake_var_non_special): New primitive.
1099 (syms_of_eval): Defsubr it.
1100 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1101
d4a8f5c1
JB
11022012-06-08 Juanma Barranquero <lekktu@gmail.com>
1103
1104 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1105 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1106
8bbbc977
EZ
11072012-06-08 Eli Zaretskii <eliz@gnu.org>
1108
1109 * alloc.c (allocate_vectorlike): Fix last change.
1110
f3372c87
DA
11112012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1112
1113 Block-based vector allocation of small vectors.
1114 * lisp.h (struct vectorlike_header): New field `nbytes',
1115 adjust comment accordingly.
1116 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1117 to denote vector blocks. Adjust users (live_vector_p,
1118 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1119 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1120 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1121 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1122 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1123 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1124 (roundup_size): New constant.
1125 (struct vector_block): New data type.
1126 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1127 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1128 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1129 (sweep_vectors): New functions.
1130 (allocate_vectorlike): Return `zero_vector' as the only vector of
1131 0 items. Allocate new vector from block if vector size is less than
1132 or equal to VBLOCK_BYTES_MAX.
1133 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1134 (init_alloc_once): Add call to init_vectors.
1135
4f18a4ed
SM
11362012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1137
1138 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1139
86f158bc
PE
11402012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1141
1142 * doprnt.c (doprnt): Truncate multibyte char correctly.
1143 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1144 would mishandle a string argument "Xc" if X was a multibyte
1145 character of length 2: it would truncate after X's first byte
1146 rather than including all of X.
1147
c5cfcbe0
CY
11482012-06-06 Chong Yidong <cyd@gnu.org>
1149
1150 * buffer.c (word_wrap): Doc fix.
1151
c05cf390
PE
11522012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1153
1154 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1155
0c3461de
GM
11562012-06-03 Glenn Morris <rgm@gnu.org>
1157
1158 * xdisp.c (tool-bar-style): Doc fix.
1159
c71232db
UM
11602012-06-03 Ulrich Müller <ulm@gentoo.org>
1161
1162 * Makefile.in (PAXCTL): Define.
1163 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1164 binary via PaX flags if the paxctl utility is available.
1165 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1166 Restore PaX flags to their default. (Bug#11398)
1167
383f7350
CY
11682012-06-03 Chong Yidong <cyd@gnu.org>
1169
1170 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1171 buffer (Bug#11226).
1172
5f2c76c6
CY
11732012-06-03 Chong Yidong <cyd@gnu.org>
1174
1175 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1176 (note_mode_line_or_margin_highlight): If there is no help echo,
1177 use mode-line-default-help-echo. Handle the case where the mouse
1178 position is past the end of the mode line string.
1179
1180 * buffer.c (buffer_local_value_1): New function, split from
1181 Fbuffer_local_value; can return Qunbound.
1182 (Fbuffer_local_value): Use it.
1183 (Vmode_line_format): Docstring tweaks.
1184
773d47f6
PE
11852012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 * sysdep.c (system_process_attributes): Improve comment.
1188
f2d6a3df
SM
11892012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1190
1191 * keyboard.c: Export real-this-command to Elisp.
1192 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1193 and DEFVAR it. Update all users.
1194
63810350
PE
11952012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1196
7bd5c1f4
PE
1197 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1198
63810350
PE
1199 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1200 Convert pctcpu and pctmem to Lisp float properly.
1201 Let the compiler fold better, as 100.0/0x8000 is exact.
1202
a2821611
AS
12032012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1204
1205 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1206 cons_block.
1207
5fceba1d
PE
12082012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1209
1210 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1211
c98ff5dd
DA
12122012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 For a 'struct window', replace some Lisp_Object fields to
1215 bitfields where appropriate, remove unused fields.
1216 * window.h (struct window): Remove unused 'last_mark_x' and
1217 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1218 change it's type from Lisp_Object to bitfield.
1219 Change type of 'force_start', 'optional_new_start',
1220 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1221 fields from Lisp_Object to bitfield. Adjust users accordingly.
1222
ca34e0be
PE
12232012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 Pacify gcc -Wdouble-precision when using Xaw.
1226 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1227 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1228 Use 'float' consistently, rather than 'float' in most places
1229 and 'double' in a couple of places.
1230
efc00ab1 12312012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1232
1233 * xdisp.c (handle_stop): Detect whether we have overlay strings
1234 loaded by testing it->current.overlay_string_index to be
1235 non-negative, instead of checking whether n_overlay_strings is
1236 positive. (Bug#11587)
1237
efc00ab1 12382012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1239
1240 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1241
1242 * doc.c (Fsubstitute_command_keys): Doc fix.
1243
efc00ab1 12442012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1245
1246 * search.c (search_buffer): Remove calls to
1247 r_alloc_inhibit_buffer_relocation, as it is now called by
1248 maybe_unify_char, which was the cause of relocation of buffer text
1249 in bug#11519.
1250
efc00ab1 12512012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1252
1253 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1254 for the duration of call to load_charset, to avoid problems with
1255 callers of maybe_unify_char that access buffer text through C
1256 pointers.
1257
1258 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1259 decrement the inhibition flag, instead of just setting or
1260 resetting it.
1261
ba93a187
PE
12622012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Remove obsolete '#define static' cruft.
1265 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1266 This #undef was "temporary" in 2000; it is no longer needed
1267 now that '#define static' has gone away.
1268 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1269 (gray_bitmap_bits): Remove; no longer needed.
1270 All uses replaced with definiens.
1271 * xterm.c: Include "bitmaps/gray.xbm".
1272
9e4bf381
PE
12732012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 Clean up __executable_start, monstartup when --enable-profiling.
1276 The following changes affect the code only when profiling.
1277 * dispnew.c (__executable_start): Rename from safe_bcopy.
1278 Define only on platforms that need it.
1279 * emacs.c: Include <sys/gmon.h> when profiling.
1280 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1281 (__executable_start): Remove decl, since lisp.h does it now.
1282 (safe_bcopy): Remove decl; no longer has that name.
1283 (main): Coalesce #if into single bit of code, for simplicity.
1284 Cast pointers to uintptr_t, since standard libraries want integers
1285 and not pointers.
1286 * lisp.h (__executable_start): New decl.
1287
32d72c2f
GM
12882012-05-31 Glenn Morris <rgm@gnu.org>
1289
1290 * image.c (Fimagemagick_types): Doc fix.
1291
baac5bc7
JM
12922012-05-30 Jim Meyering <meyering@redhat.com>
1293
1294 * callproc.c (Fcall_process_region): Include directory component
1295 in mkstemp error message (Bug#11586).
1296
72cb32cf
PE
12972012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1298
1299 * alloc.c, lisp.h (make_pure_vector): Now static.
1300
61b108cc
SM
13012012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1302
1303 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1304 Move to byte-run.el.
1305 (Fautoload): Do the hash-doc more carefully.
1306 * data.c (Fdefalias): Purify definition, except for keymaps.
1307 (Qdefun): Move from eval.c.
1308 * lisp.h (Qdefun): Remove.
1309 * lread.c (read1): Tiny simplification.
1310
471fe23d
TN
13112012-05-29 Troels Nielsen <bn.troels@gmail.com>
1312
934f3f58 1313 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1314 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1315 Bug#9642, but explicitly check that the buffer the overlay would
1316 be moved to is live and rearrange lines to make sure that errors
1317 will not put the overlay in an inconsistent state.
1318 (Fdelete_overlay): Cosmetics.
1319
85d0efd1
EZ
13202012-05-28 Eli Zaretskii <eliz@gnu.org>
1321
1322 * w32term.c (my_bring_window_to_top): New function.
1323 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1324 could be different from the original one.
1325 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1326 (Bug#11513)
1327
1328 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1329 by calling BringWindowToTop.
1330
1331 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1332 (WM_EMACS_END): Increase by one.
1333
da92a98c
PE
13342012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1335
1336 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1337 This avoids undefined behavior that might cause the eassert
1338 to not catch an out-of-range value.
1339
74d1f848
JB
13402012-05-28 Juanma Barranquero <lekktu@gmail.com>
1341
1342 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1343 Update dependencies.
1344
9e1a06fc
EZ
13452012-05-27 Eli Zaretskii <eliz@gnu.org>
1346
1347 * bidi.c (bidi_mirror_char): Fix last change.
1348
f3dd7312
AS
13492012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1350
1351 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1352 when referring to sectname field in printf format.
1353
81899c91
PE
13542012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1355
57b81a9f
PE
1356 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1357 Only r_alloc_inhibit_buffer_relocation needed to be added;
1358 the others were already declared.
1359
81899c91
PE
1360 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1361 before checking whether it's out of range. Put the check inside
1362 eassert. See
1363 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1364
33017faf 13652012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1366
1367 * callproc.c (Fcall_process): Restore a line that was accidentally
1368 commented out in the 2011-02-13 change (bug#11547).
1369
33017faf 13702012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1371
1372 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1373 defined on ralloc.c.
1374
1375 * buffer.c [REL_ALLOC]: Remove prototypes of
1376 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1377 they are now on lisp.h.
1378
1379 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1380
1381 * search.c (search_buffer): Use it to inhibit relocation of buffer
1382 text while re_search_2 is doing its job, because re_search_2 is
1383 passed C pointers to buffer text. (Bug#11519)
1384
23415acf
EZ
1385 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1386 Update value to 24.
1387
44e27368
EZ
1388 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1389 state after an additional call to move_it_in_display_line_to, keep
1390 the values of it->max_ascent and it->max_descent found for the
1391 entire line.
1392 (pos_visible_p): Revert the comparison against bottom_y to what it
1393 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1394 (Bug#11464)
1395
c1892f11
PE
13962012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1397
1398 Fix coding-related core dumps with gcc -ftrapv.
1399 The code was computing A - B, where A and B are pointers, and B is
1400 random garbage. This can lead to core dumps on platforms that
1401 have special pointer registers, and it also leads to core dumps on
1402 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1403 A - B only when B is initialized properly.
1404 * coding.c (coding_set_source, coding_set_destination): Return void.
1405 (coding_change_source, coding_change_destinations): New functions,
1406 with the old behaviors of coding_set_source and coding_set_destination.
1407 All callers that need an offset changed to use these new functions.
1408
eb7afdad
GM
14092012-05-26 Glenn Morris <rgm@gnu.org>
1410
1411 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1412
f12fdf02
EZ
14132012-05-26 Eli Zaretskii <eliz@gnu.org>
1414
53a63be6 1415 Extend mouse support on W32 text-mode console.
61b108cc
SM
1416 * xdisp.c (draw_row_with_mouse_face):
1417 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1418
eb3f6f01 1419 * w32console.c: Include window.h.
61b108cc
SM
1420 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1421 New functions.
eb3f6f01
EZ
1422 (initialize_w32_display): Initialize mouse-highlight data.
1423
53a63be6
EZ
1424 * w32inevt.c: Include termchar.h and window.h.
1425 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1426 moves, call note_mouse_highlight. If help_echo changed, call
1427 gen_help_event to produce help-echo message in the echo area.
1428 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1429 highlight info.
1430
4cfd81f6
PE
14312012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 * lread.c (read1): Simplify slightly to avoid an overflow warning
1434 with GCC 4.7.0 on x86-64.
1435
4446092a
EZ
14362012-05-26 Eli Zaretskii <eliz@gnu.org>
1437
1438 * bidi.c (bidi_mirror_char): Revert last change: an int is
1439 definitely wide enough here.
1440
42b2a986 14412012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1442
42b2a986 1443 Fix integer width and related bugs (Bug#9874).
eb106a49 1444 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1445 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1446 (string_bytes, check_sblock, allocate_string_data):
1447 (compact_small_strings, Fmake_bool_vector, make_string)
1448 (make_unibyte_string, make_multibyte_string)
1449 (make_string_from_bytes, make_specified_string)
1450 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1451 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1452 (mark_vectorlike):
1453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1454 (allocate_pseudovector):
1455 Use int, not EMACS_INT, where int is wide enough.
1456 (inhibit_garbage_collection, Fgarbage_collect):
1457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1458 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1459 int might not be wide enough.
1460 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1461 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1462 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1463 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1464 (bidi_level_of_next_char, bidi_move_to_visually_next):
1465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1466 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1467 (Fkill_buffer, Fset_buffer_major_mode)
1468 (advance_to_char_boundary, Fbuffer_swap_text)
1469 (Fset_buffer_multibyte, overlays_at, overlays_in)
1470 (overlay_touches_p, struct sortvec, record_overlay_string)
1471 (overlay_strings, recenter_overlay_lists)
1472 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1473 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1474 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1475 (Foverlay_recenter, last_overlay_modification_hooks_used)
1476 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1478 (validate_region): Omit unnecessary test for b <= e,
1479 since that's guaranteed by the previous test.
d311d28c
PE
1480 (adjust_overlays_for_delete): Avoid pos + length overflow.
1481 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1482 (report_overlay_modification):
1483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1484 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1485 Omit pointer cast, which isn't needed anyway, and doesn't work
1486 after the EMACS_INT -> ptrdiff_t change.
02481186 1487 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1488 * buffer.h: Adjust decls to match defn changes elsewhere.
1489 (struct buffer_text, struct buffer):
1490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1491 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1492 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1493 not int, to avoid needless 32-bit limit on 64-bit hosts.
1494 (exec_byte_code): Use tighter memory-full test, one that checks
1495 for alloca overflow. Don't compute the address of the object just
1496 before an array, as that's not portable. Use EMACS_INT, not
1497 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1498 * callint.c (Fcall_interactively):
1499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1500 * callproc.c (call_process_kill, Fcall_process):
1501 Don't assume pid_t fits into an Emacs fixnum.
1502 (call_process_cleanup, Fcall_process, child_setup):
1503 Don't assume pid_t fits into int.
1504 (call_process_cleanup, Fcall_process, delete_temp_file)
1505 (Fcall_process_region):
1506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1507 (Fcall_process): Simplify handling of volatile integers.
1508 Use int, not EMACS_INT, where int will do.
1509 * casefiddle.c (casify_object, casify_region, operate_on_word)
1510 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1512 (casify_object): Avoid integer overflow when overallocating buffer.
1513 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1514 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1515 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1516 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1517 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1518 integers are now checked earlier. All uses replaced with XINT.
1519 (ccl_driver):
1520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1521 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1522 (ccl_driver, Fregister_code_conversion_map):
1523 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1524 (resolve_symbol_ccl_program): Check that vector header is in range.
1525 Always copy the vector, so that we can check its contents reliably
1526 now rather than having to recheck each instruction as it's being
1527 executed. Check that vector words fit in 'int'.
1528 (ccl_get_compiled_code, Fregister_ccl_program)
1529 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1530 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1531 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1532 contents are in range.
1533 (Fccl_execute_on_string): Check that status is in range.
1534 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1535 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1536 Accept and return EMACS_INT, not int, because callers can pass values
1537 out of 'int' range.
1538 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1539 (multibyte_chars_in_text, parse_str_as_multibyte)
1540 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1541 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1542 (string_escape_byte8, Fget_byte):
1543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1544 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1545 avoid mishandling large integers.
1546 * character.h: Adjust decls to match defn changes elsewhere.
1547 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1548 (Ffind_charset_region):
1549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1550 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1551 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1552 Don't assume fixnum fits in int.
d311d28c
PE
1553 (load_charset_map_from_vector, Fmap_charset_chars):
1554 Remove now-unnecessary CHECK_NATNUMs.
1555 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1556 Don't rely on undefined behavior with signed left shift overflow.
1557 Don't assume unsigned int fits into fixnum, or that fixnum fits
1558 into unsigned int. Don't require max_code to be a valid fixnum;
1559 that's not true for gb10830 4-byte on a 32-bit host. Allow
1560 invalid_code to be a cons, for the same reason. Require code_offset
1561 to be a character. Avoid int overflow if max_char is close
1562 to INT_MAX.
1563 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1564 this is intended anyway and avoids some undefined behavior.
1565 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1566 INDEX_TO_CODE_POINT, as that's what it expects.
1567 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1568 * charset.h (DECODE_CHAR): Return int, not unsigned;
1569 this is what was intended anyway, and it avoids undefined behavior.
1570 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1571 integer-overflow issues.
1572 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1573 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1574 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1575 * chartab.c (Fmake_char_table, Fset_char_table_range)
1576 (uniprop_get_decoder, uniprop_get_encoder):
1577 Don't assume fixnum fits in int.
1578 * cmds.c (move_point): New function, that does the gist of
1579 Fforward_char and Fbackward_char, but does so while checking
1580 for integer overflow more accurately.
c96e5d6a 1581 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1582 (Fforward_line, Fend_of_line, internal_self_insert)
1583 (internal_self_insert):
1584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1585 Fix a FIXME, by checking for integer overflow when calculating
1586 target_clm and actual_clm.
1587 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1588 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1589 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1590 (coding_alloc_by_making_gap, alloc_destination)
1591 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1592 (encode_coding_utf_16, detect_coding_emacs_mule)
1593 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1594 (detect_coding_iso_2022, decode_coding_iso_2022)
1595 (encode_invocation_designation, encode_designation_at_bol)
1596 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1597 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1598 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1599 (encode_coding_ccl, encode_coding_raw_text)
1600 (detect_coding_charset, decode_coding_charset)
1601 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1602 (produce_composition, produce_charset, produce_annotation)
1603 (decode_coding, handle_composition_annotation)
1604 (handle_charset_annotation, consume_chars, decode_coding_gap)
1605 (decode_coding_object, encode_coding_object, detect_coding_system)
1606 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1607 (code_convert_region, code_convert_string)
8f50130c
PE
1608 (Fdefine_coding_system_internal)
1609 (coding_set_source, coding_set_destination):
d311d28c
PE
1610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1611 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1612 (Fdefine_coding_system_internal):
1613 Don't assume fixnums fit in int.
1614 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1615 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1616 (Funencodable_char_position, Fcheck_coding_systems_region)
1617 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1619 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1620 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1621 Don't access memory outside of the args array.
d311d28c 1622 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1623 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1624 result of ENCODE_CHAR.
d311d28c
PE
1625 * coding.h: Adjust decls to match defn changes elsewhere.
1626 (struct coding_system):
1627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1628 * composite.c (get_composition_id, find_composition)
1629 (run_composition_function, update_compositions)
1630 (compose_text, composition_gstring_put_cache)
1631 (composition_gstring_p, composition_gstring_width)
1632 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1633 (composition_compute_stop_pos, composition_reseat_it)
1634 (composition_update_it, struct position_record)
1635 (find_automatic_composition, composition_adjust_point)
1636 (Fcomposition_get_gstring, Ffind_composition_internal):
1637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1638 (update_compositions):
1639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1640 * composite.h: Adjust decls to match defn changes elsewhere.
1641 (struct composition):
1642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1643 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1644 Do not attempt to compute the address of the object just before a
1645 buffer; this is not portable.
1646 (Faref, Faset):
1647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1648 (Faset): Use int, not EMACS_INT, where int is wide enough.
1649 (Fstring_to_number): Don't assume fixnums fit in int.
1650 (Frem): Don't assume arg is nonnegative.
1651 * dbusbind.c (xd_append_arg): Check for integers out of range.
1652 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1653 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1654 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1655 (xd_get_connection_references): Return ptrdiff_t, not int.
1656 All uses changed.
1657 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1658 (xd_read_message_1):
1659 Use int, not unsigned, where the dbus API uses int.
1660 (Fdbus_message_internal): Don't overflow mtype.
1661 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1662 * dired.c (directory_files_internal, file_name_completion, scmp)
1663 (file_name_completion_stat):
1664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1665 (file_name_completion): Don't overflow matchcount.
1666 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1667 * dispextern.h: Adjust decls to match defn changes elsewhere.
1668 (struct text_pos, struct glyph, struct bidi_saved_info)
1669 (struct bidi_string_data, struct bidi_it, struct composition_it)
1670 (struct it):
1671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1672 (struct display_pos, struct composition_it, struct it):
1673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1674 * dispnew.c (increment_matrix_positions)
1675 (increment_row_positions, mode_line_string)
1676 (marginal_area_string):
1677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1678 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1680 (duration_to_sec_usec): New function, to check for overflow better.
1681 (Fsleep_for, sit_for): Use it.
1682 * doc.c (get_doc_string, store_function_docstring):
1683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1684 (get_doc_string, Fsnarf_documentation):
1685 Use int, not EMACS_INT, where int is wide enough.
1686 (get_doc_string):
1687 Use SAFE_ALLOCA, not alloca.
1688 Check for overflow when converting EMACS_INT to off_t.
1689 * doprnt.c (doprnt):
1690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1691 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1692 Don't assume uid_t fits into fixnum.
1693 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1694 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1695 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1696 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1697 (general_insert_function)
1698 (Finsert_char, make_buffer_string, make_buffer_string_both)
1699 (update_buffer_properties, Fbuffer_substring)
1700 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1701 (Fsubst_char_in_region, check_translation)
1702 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1703 (transpose_markers, Ftranspose_regions):
1704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1705 (clip_to_bounds): Move to lisp.h as an inline function).
1706 (Fconstrain_to_field): Don't assume integers are nonnegative.
1707 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1708 (Fsubst_char_in_region, Fsave_restriction):
1709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1710 (Femacs_pid): Don't assume pid_t fits into fixnum.
1711 (lo_time): Use int, not EMACS_INT, when int suffices.
1712 (lisp_time_argument): Check for usec out of range.
1713 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1714 (Fuser_login_name, Fuser_full_name): Signal an error
1715 if a uid argument is out of range, rather than relying on
1716 undefined behavior.
c8d5c857
PE
1717 (Fformat_time_string): Remove now-unnecessary check.
1718 lisp_time_argument checks for out-of-range usec now.
243e0530 1719 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1720 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1721 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1722 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1723 (init_cmdargs, Fdump_emacs):
1724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1725 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1726 the bottom (typically) 32 bits of the fixnum.
1727 * eval.c (specpdl_size, call_debugger):
1728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1729 (when_entered_debugger, Fbacktrace_debug):
1730 Don't assume fixnum can fit in int.
1731 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1732 the object just before a buffer; this is not portable.
1733 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1734 (grow_specpdl, unbind_to):
1735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1736 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1737 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1738 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1739 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1740 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1742 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1743 (a_write, e_write):
1744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1745 (Fcopy_file, non_regular_nbytes, read_non_regular)
1746 (Finsert_file_contents):
1747 Use int, not EMACS_INT, where int is wide enough.
1748 (READ_BUF_SIZE): Verify that it fits in int.
1749 (Finsert_file_contents): Check that counts are in proper range,
1750 rather than assuming fixnums fit into ptrdiff_t etc.
1751 Don't assume fixnums fit into int.
125b3835 1752 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1753 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1754 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1755 (string_char_to_byte, string_byte_to_char)
1756 (string_make_multibyte, string_to_multibyte)
1757 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1758 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1759 (substring_both, Fdelete, internal_equal, Ffillarray)
1760 (Fclear_string, mapcar1)
1761 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1762 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1763 (larger_vector, make_hash_table, maybe_resize_hash_table)
1764 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1765 (Fmaphash, secure_hash):
1766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1767 (concat): Check for string index and length overflow.
1768 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1769 (Frequire):
1770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1771 (larger_vector): New API (vec, incr_min, size_max) replaces old
1772 one (vec, new_size, init). This catches size overflow.
1773 INIT was removed because it was always Qnil.
1774 All callers changed.
1775 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1776 the upper bound on a hash table index size.
1777 (make_hash_table, maybe_resize_hash_table): Use it.
1778 (secure_hash): Computer start_byte and end_byte only after
1779 they're known to be in ptrdiff_t range.
1780 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1781 (Ffont_get_glyphs, Ffont_at):
1782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1783 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1784 (Flist_fonts, Fopen_font):
1785 Don't assume fixnum can fit in int.
1786 (check_gstring): Don't assume index can fit in int.
1787 (font_match_p): Check that fixnum is a character, not a nonnegative
1788 fixnum, since the later code needs to stuff it into an int.
1789 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1790 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1791 conversion overflow issues.
1792 (Fopen_font): Check for integer out of range.
1793 (Ffont_get_glyphs): Don't assume index can fit in int.
1794 * font.h: Adjust decls to match defn changes elsewhere.
1795 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1796 integer overflow.
1797 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1798 printmax_t, where ptrdiff_t is wide enough.
1799 (Finternal_char_font):
1800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1801 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1802 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1803 (Fset_frame_position, x_set_frame_parameters)
1804 (x_set_line_spacing, x_set_border_width)
1805 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1806 Check that fixnums are in proper range for system types.
1807 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1809 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1810 Use SAFE_ALLOCA_LISP, not alloca.
1811 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1812 intptr_t is wide enough.
1813 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1814 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1815 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1816 Check for fixnum out of range.
1817 * ftfont.c (ftfont_list): Don't assume index fits in int.
1818 Check that fixnums are in proper range for system types.
1819 (ftfont_shape_by_flt):
1820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1821 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1823 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1824 Check that fixnums are in proper range for system types.
1825 * gnutls.h: Adjust decls to match defn changes elsewhere.
1826 * gtkutil.c (xg_dialog_run):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 (update_frame_tool_bar):
1829 Check that fixnums are in proper range for system types.
1830 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1831 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1832 * indent.c (last_known_column, last_known_column_point):
1833 (current_column_bol_cache):
1834 (skip_invisible, current_column, check_display_width):
1835 (check_display_width, scan_for_column, current_column_1)
1836 (Findent_to, Fcurrent_indentation, position_indentation)
1837 (indented_beyond_p, Fmove_to_column, compute_motion):
1838 (Fcompute_motion, Fvertical_motion):
1839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1840 (last_known_column_modified): Use EMACS_INT, not int.
1841 (check_display_width):
1842 (Fcompute_motion):
1843 Check that fixnums and floats are in proper range for system types.
1844 (compute_motion): Don't assume index or fixnum fits in int.
1845 (compute_motion, Fcompute_motion):
1846 Use int, not EMACS_INT, when it is wide enough.
1847 (vmotion): Omit local var start_hpos that is always 0; that way
1848 we don't need to worry about overflow in expressions involving it.
1849 * indent.h: Adjust decls to match defn changes elsewhere.
1850 (struct position):
1851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1852 Use int, not EMACS_INT, where int is wide enough.
1853 Remove unused members ovstring_chars_done and tab_offset;
1854 all uses removed.
1855 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1856 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1857 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1858 (make_gap, copy_text, insert, insert_and_inherit)
1859 (insert_before_markers, insert_before_markers_and_inherit)
1860 (insert_1, count_combining_before, count_combining_after)
1861 (insert_1_both, insert_from_string)
1862 (insert_from_string_before_markers, insert_from_string_1)
1863 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1864 (adjust_after_replace, adjust_after_insert, replace_range)
1865 (replace_range_2, del_range, del_range_1, del_range_byte)
1866 (del_range_both, del_range_2, modify_region)
1867 (prepare_to_modify_buffer, signal_before_change)
1868 (signal_after_change, Fcombine_after_change_execute):
1869 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1870 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1871 (balance_an_interval, split_interval_right, split_interval_left)
1872 (find_interval, next_interval, update_interval)
1873 (adjust_intervals_for_insertion, delete_node, delete_interval)
1874 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1875 (static_offset_intervals, offset_intervals)
1876 (merge_interval_right, merge_interval_left, make_new_interval)
1877 (graft_intervals_into_buffer, temp_set_point_both)
1878 (temp_set_point, set_point, adjust_for_invis_intang)
1879 (set_point_both, move_if_not_intangible, get_property_and_range)
1880 (get_local_map, copy_intervals, copy_intervals_to_string)
1881 (compare_string_intervals, set_intervals_multibyte_1):
1882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1883 * intervals.h: Adjust decls to match defn changes elsewhere.
1884 (struct interval):
1885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1886 * keyboard.c (this_command_key_count, this_single_command_key_start)
1887 (before_command_key_count, before_command_echo_length, echo_now)
1888 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1889 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1890 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1891 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1893 (last_non_minibuf_size, last_point_position, echo_truncate)
1894 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1895 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1896 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1897 (stuff_buffered_input):
1898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1899 (last_auto_save, command_loop_1, read_char):
1900 Use EMACS_INT, not int, to avoid integer overflow.
1901 (record_char): Avoid overflow in total_keys computation.
1902 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1903 * keyboard.h: Adjust decls to match defn changes elsewhere.
1904 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1905 (Fkey_description, Fdescribe_vector, Flookup_key):
1906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1907 (click_position): New function, to check that positions are in range.
1908 (Fcurrent_active_maps):
1909 (describe_command):
1910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1911 (Faccessible_keymaps, Fkey_description):
1912 (preferred_sequence_p):
1913 Don't assume fixnum can fit into int.
1914 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1915 Check for integer overflow in size calculations.
1916 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1917 avoid mishandling large integers.
1918 * lisp.h: Adjust decls to match defn changes elsewhere.
1919 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1920 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1921 (struct Lisp_Marker):
1922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1923 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1924 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1925 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1926 All callers changed.
1927 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1928 Assume the arg has valid form, since it always does.
1929 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1930 unsigned integer system type.
1931 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1932 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1934 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1935 (duration_to_sec_usec): New decl.
1936 * lread.c (read_from_string_index, read_from_string_index_byte)
1937 (read_from_string_limit, readchar, unreadchar, openp)
1938 (read_internal_start, read1, oblookup):
1939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1940 (Fload, readevalloop, Feval_buffer, Feval_region):
1941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1942 (openp): Check for out-of-range argument to 'access'.
1943 (read1): Use int, not EMACS_INT, where int is wide enough.
1944 Don't assume fixnum fits into int.
6efdadfd 1945 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1946 (read_filtered_event): Use duration_to_sec_usec
1947 to do proper overflow checking on durations.
d311d28c
PE
1948 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1949 in size calculation.
1950 (Fexecute_kbd_macro):
1951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1952 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1953 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1954 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1955 (set_marker_both, set_marker_restricted_both, marker_position)
1956 (marker_byte_position, Fbuffer_has_markers_at):
1957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1958 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1959 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1960 It now merely ensures that the menu is large enough, without
1961 necessarily growing it, as this avoids some integer overflow issues.
1962 All callers changed.
1963 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1965 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1966 Use SAFE_ALLOCA_LISP, not alloca.
1967 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1968 to EMACS_INT. Check that fixnums are in proper range for system types.
1969 * minibuf.c (minibuf_prompt_width, string_to_object)
1970 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1971 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1973 (get_minibuffer, read_minibuf_unwind):
1974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1975 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1976 this simplifies overflow checking. All callers changed.
1977 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1978 (Ftest_completion):
1979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1980 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1981 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1982 Check that fixnums are in proper range for system types.
1983 (Fx_create_frame, Fx_show_tip):
1984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1985 * nsfont.m (ns_findfonts, nsfont_list_family):
1986 Don't assume fixnum fits in long.
1987 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1988 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1989 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1990 wide enough.
17fdb222 1991 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1993 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1994 (PRINTDECLARE, PRINTPREPARE):
1995 (strout, print_string):
1996 (print, print_preprocess, print_check_string_charset_prop)
1997 (print_object):
1998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1999 (PRINTDECLARE):
2000 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2001 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2002 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2003 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2004 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2005 (print_error_message): Use SAFE_ALLOCA, not alloca.
2006 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2007 (print_depth, new_backquote_output, print_number_index):
2008 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2009 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2010 (Fset_process_window_size, Fformat_network_address)
2011 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2012 (sigchld_handler):
d311d28c 2013 Check that fixnums are in proper range for system types.
d44287d4 2014 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2015 Check for process-ids out of pid_t range rather than relying on
2016 undefined behavior.
e4d81efc 2017 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2018 (Fformat_network_address, read_process_output, send_process)
2019 (Fprocess_send_region, status_notify):
2020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2021 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2022 (wait_reading_process_output, read_process_output, exec_sentinel):
2023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2024 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2025 (Faccept_process_output): Use duration_to_sec_usec to do proper
2026 overflow checking on durations.
dde14581
PE
2027 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2028 Don't assume pid_t fits in int.
02481186
PE
2029 * process.h (struct Lisp_Process): Members tick and update_tick
2030 are now of type EMACS_INT, not int.
b62b53e8
PE
2031 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2032 configured --with-wide-int.
d311d28c
PE
2033 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2034 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2035 * search.c (looking_at_1, string_match_1):
2036 (fast_string_match, fast_c_string_match_ignore_case)
2037 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2038 (scan_newline, find_before_next_newline, search_command)
2039 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2040 (set_search_regs, wordify):
2041 (Freplace_match):
2042 (Fmatch_data):
2043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2044 (string_match_1, search_buffer, set_search_regs):
2045 (Fmatch_data):
2046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2047 (wordify): Check for overflow in size calculation.
2048 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2049 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2050 Check that fixnums are in proper range for system types.
2051 * sound.c (struct sound_device)
2052 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2054 (Fplay_sound_internal):
2055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2056 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2057 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2058 (Fparse_partial_sexp):
2059 Don't assume fixnums can fit in int.
2060 (struct lisp_parse_state, find_start_pos, find_start_value)
2061 (find_start_value_byte, find_start_begv)
2062 (update_syntax_table, char_quoted, dec_bytepos)
2063 (find_defun_start, prev_char_comend_first, back_comment):
2064 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2065 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2067 (Finternal_describe_syntax_value): Check that match_lisp is a
2068 character, not an integer, since the code stuffs it into int.
2069 (scan_words, scan_sexps_forward):
2070 Check that fixnums are in proper range for system types.
2071 (Fforward_word):
2072 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2073 (scan_sexps_forward):
2074 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2075 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2076 * syntax.h: Adjust decls to match defn changes elsewhere.
2077 (struct gl_state_s):
2078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2079 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2080 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2081 * sysdep.c (wait_for_termination_1, wait_for_termination)
2082 (interruptible_wait_for_termination, mkdir):
2083 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2084 (emacs_read, emacs_write):
2085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2086 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2087 and double all fit in int.
d311d28c
PE
2088 * term.c (set_tty_color_mode):
2089 Check that fixnums are in proper range for system types.
2090 * termhooks.h (struct input_event):
2091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2092 * textprop.c (validate_interval_range, interval_of)
2093 (Fadd_text_properties, set_text_properties_1)
2094 (Fremove_text_properties, Fremove_list_of_text_properties)
2095 (Ftext_property_any, Ftext_property_not_all)
2096 (copy_text_properties, text_property_list, extend_property_ranges)
2097 (verify_interval_modification):
2098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2099 (Fnext_single_char_property_change)
2100 (Fprevious_single_char_property_change):
2101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2102 (copy_text_properties):
2103 Check for integer overflow in index calculation.
d311d28c
PE
2104 * undo.c (last_boundary_position, record_point, record_insert)
2105 (record_delete, record_marker_adjustment, record_change)
2106 (record_property_change):
2107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2108 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2110 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2111 (Fx_hide_tip, Fx_file_dialog):
2112 * w32menu.c (set_frame_menubar):
2113 Use ptrdiff_t, not int, for consistency with rest of code.
2114 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2115 (select_window, Fdelete_other_windows_internal)
2116 (window_scroll_pixel_based, window_scroll_line_based)
2117 (Frecenter, Fset_window_configuration):
2118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2119 (Fset_window_hscroll, run_window_configuration_change_hook)
2120 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2121 (Fscroll_other_window, Frecenter):
d311d28c
PE
2122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2123 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2124 Don't assume fixnum fits in int.
2125 (Fset_window_scroll_bars):
2126 Check that fixnums are in proper range for system types.
2127 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2128 (string_pos, c_string_pos, number_of_chars, init_iterator)
2129 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2130 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2131 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2132 (face_before_or_after_it_pos, handle_invisible_prop)
2133 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2134 (display_prop_intangible_p, string_buffer_position_lim)
2135 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2136 (get_overlay_strings_1, get_overlay_strings)
2137 (iterate_out_of_display_property, forward_to_next_line_start)
2138 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2139 (get_next_display_element, set_iterator_to_next)
2140 (get_visually_first_element, compute_stop_pos_backwards)
2141 (handle_stop_backwards, next_element_from_buffer)
2142 (move_it_in_display_line_to, move_it_in_display_line)
2143 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2144 (add_to_log, message_dolog, message_log_check_duplicate)
2145 (message2, message2_nolog, message3, message3_nolog
2146 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2147 (current_message_1, truncate_echo_area, truncate_message_1)
2148 (set_message, set_message_1, store_mode_line_noprop)
2149 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2150 (text_outside_line_unchanged_p, check_point_in_composition)
2151 (reconsider_clip_changes)
2152 (redisplay_internal, set_cursor_from_row, try_scrolling)
2153 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2154 (redisplay_window, find_last_unchanged_at_beg_row)
2155 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2156 (trailing_whitespace_p, find_row_edges, display_line)
2157 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2158 (display_mode_element, store_mode_line_string)
2159 (pint2str, pint2hrstr, decode_mode_spec)
2160 (display_count_lines, display_string, draw_glyphs)
2161 (x_produce_glyphs, x_insert_glyphs)
2162 (rows_from_pos_range, mouse_face_from_buffer_pos)
2163 (fast_find_string_pos, mouse_face_from_string_pos)
2164 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2166 (safe_call, init_from_display_pos, handle_fontified_prop)
2167 (handle_single_display_spec, load_overlay_strings)
2168 (with_echo_area_buffer, setup_echo_area_for_printing)
2169 (display_echo_area, echo_area_display)
2170 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2171 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2172 (redisplay_window, dump_glyph_row, display_mode_line)
2173 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2174 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2176 (handle_single_display_spec, build_desired_tool_bar_string)
2177 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2178 (get_specified_cursor_type):
2179 Check that fixnums are in proper range for system types.
2180 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2181 (Flookup_image_map):
2182 Don't assume fixnums fit in int.
2183 (compare_overlay_entries):
2184 Avoid mishandling comparisons due to subtraction overflow.
2185 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2186 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2187 (handle_tool_bar_click):
2188 Use int, not unsigned, since we prefer signed and the signedness
2189 doesn't matter here.
2190 (get_next_display_element, next_element_from_display_vector):
2191 Use int, not EMACS_INT, when int is wide enough.
2192 (start_hourglass): Use duration_to_sec_usec to do proper
2193 overflow checking on durations.
2194 * xfaces.c (Fbitmap_spec_p):
2195 Check that fixnums are in proper range for system types.
2196 (compare_fonts_by_sort_order):
2197 Avoid mishandling comparisons due to subtraction overflow.
2198 (Fx_family_fonts, realize_basic_faces):
2199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2200 (Fx_family_fonts):
2201 Don't assume fixnum fits in int.
2202 Use SAFE_ALLOCA_LISP, not alloca.
2203 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2204 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2205 (face_at_buffer_position, face_for_overlay_string)
2206 (face_at_string_position):
2207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2208 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2209 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2210 (Fx_show_tip):
2211 Check that fixnums are in proper range for system types.
2212 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2213 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2215 (Fx_change_window_property): Don't assume fixnums fit in int.
2216 * xfont.c (xfont_chars_supported):
2217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2218 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2219 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2221 * xml.c (parse_region):
2222 * xrdb.c (magic_file_p):
2223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2224 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2225 (x_get_local_selection, x_reply_selection_request)
2226 (x_handle_selection_request, wait_for_property_change):
2227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2228 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2229 short is wide enough.
2230 (x_send_client_event): Don't assume fixnum fits in int.
2231 * xterm.c (x_x_to_emacs_modifiers):
2232 Don't assume EMACS_INT overflows nicely into int.
2233 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2234 may come from Lisp.
2235 (handle_one_xevent): NATNUMP can eval its arg twice.
2236 (x_connection_closed):
2237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2238 * xterm.h: Adjust decls to match defn changes elsewhere.
2239 (struct scroll_bar): Use struct vectorlike_header
2240 rather than rolling our own approximation.
2241 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2242
c6574eb5
GM
22432012-05-25 Glenn Morris <rgm@gnu.org>
2244
2245 * lisp.mk (lisp): Update for more files being compiled now.
2246
e8d32c7e
SM
22472012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2248
48def666
SM
2249 * lread.c: Remove `read_pure' which makes no difference.
2250 (read_pure): Remove var.
2251 (unreadpure): Remove function.
2252 (readevalloop): Don't call read_list with -1 flag.
2253 (read1, read_vector): Don't test read_pure any more.
2254 (read_list): Simplify.
2255
e8d32c7e
SM
2256 * fileio.c, character.h: Minor style tweaks.
2257
4b2addb7
DA
22582012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2259
2260 * window.h (clip_changed): Remove useless declaration.
2261
584461b2
JB
22622012-05-22 Juanma Barranquero <lekktu@gmail.com>
2263
2264 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2265 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2266
34374650
PE
22672012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 Remove src/m/*.
2270 This directory predates autoconf and is no longer needed nowadays.
2271 Move its few remaining bits of functionality to where they're needed.
2272 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2273 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2274 * m/template.h: Remove.
2275 * Makefile.in (M_FILE): Remove. All uses removed.
2276 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2277 * lisp.h (USE_LSB_TAG):
2278 * mem-limits.h (EXCEEDS_LISP_PTR):
2279 Use VAL_MAX, not VALBITS, in #if.
2280 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2281 (EMACS_UINT): Define unconditionally now.
2282 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2283 (BITS_PER_EMACS_INT): New constants, replacing
2284 what used to be in config.h, but not useful in #if.
2285 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2286 define them any more.
2287 (VAL_MAX): New macro.
2288 (VALMASK): Use it.
2289 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2290 BITS_PER_EMACS_INT, in #if.
2291 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2292 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2293 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2294 * s/ms-w32.h (DATA_START):
2295 Move here from removed file m/intel386.h.
2296 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2297 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2298
261cb4bb
PE
22992012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2300
2301 Assume C89 or later.
2302 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2303 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2304 (xrealloc):
2305 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2306 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2307 * textprop.c, tparam.c (NULL): Remove.
2308 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2309 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2310 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2311 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2312 * xterm.c (input_signal_count): Assume volatile works.
2313
ff23cd9f
KB
23142012-05-21 Ken Brown <kbrown@cornell.edu>
2315
2316 * xgselect.c (xg_select): Fix first argument in call to 'select'
2317 (bug#11508).
2318
1b170bc6
KB
23192012-05-20 Ken Brown <kbrown@cornell.edu>
2320
2321 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2322 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2323
b2f4d39f
KB
23242012-05-19 Ken Brown <kbrown@cornell.edu>
2325
2326 * xfns.c (x_in_use): Remove `static' qualifier.
2327 * xterm.h (x_in_use): Declare.
2328 * xgselect.c: Include xterm.h.
2329 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2330 and `display_arg' (bug#9754).
2331
003fdae2
PE
23322012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2333
9232a6d9
PE
2334 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2335
003fdae2
PE
2336 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2337 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2338
784b56e2
EZ
23392012-05-18 Eli Zaretskii <eliz@gnu.org>
2340
2341 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2342
2343 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2344 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2345
2346 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2347 reference to image_cache->refcount.
2348 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2349
a0a79cde
JL
23502012-05-17 Juri Linkov <juri@jurta.org>
2351
2352 * search.c (Fword_search_regexp, Fword_search_backward)
2353 (Fword_search_forward, Fword_search_backward_lax)
2354 (Fword_search_forward_lax): Move functions to isearch.el
2355 (bug#10145, bug#11381).
2356
b0572523
PE
23572012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2360
9660f5fc
SM
23612012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2362
2363 * lread.c (init_obarray): Declare Qt and Qnil as special.
2364
4374de83
GM
23652012-05-14 Glenn Morris <rgm@gnu.org>
2366
2367 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2368 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2369
dc44c39a
PE
23702012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2371
078c97cb
PE
2372 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2373
dc44c39a
PE
2374 * unexaix.c: Port to more-recent AIX compilers.
2375 (report_error, report_error_1, make_hdr, copy_sym)
2376 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2377 Make arguments const char *, not char *, to avoid violations of C
2378 standard and to fix some AIX warnings reported by Gilles Pion.
2379
e18afed7 23802012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2381
2382 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2383 already have overlays loaded.
2384 (handle_single_display_spec): Before returning without displaying
2385 fringe bitmap, synchronize the bidi iterator with the main display
2386 iterator, by calling iterate_out_of_display_property.
2387 (iterate_out_of_display_property): Detect buffer iteration by
2388 testing that it->string is a Lisp string.
2389 (get_next_display_element): When the current object is exhausted,
2390 and there's something on it->stack, call set_iterator_to_next to
2391 proceed with what's on the stack, instead of returning zero.
2392 (set_iterator_to_next): If called at the end of a Lisp string,
2393 proceed to consider_string_end without incrementing string
2394 position. Don't increment display vector index past the end of
2395 the display vector. (Bug#11417)
c8fb9dc6
EZ
2396 (pos_visible_p): Don't report a position visible when move_it_to
2397 stopped at the last line of window, which happens to be scanned
2398 backwards by the bidi iteration. (Bug#11464)
ac268e67 2399
e18afed7 24002012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2401
2402 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2403 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2404 are on a TTY, and thus unable to display on the fringes.
2405 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2406 so we need to signal to the caller that this is a "replacing"
2407 display spec. This fixes display when the spec is invalid or we
2408 are on a TTY.
2409
e18afed7 24102012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2411
2412 * unexaix.c (make_hdr): Fix typo in prototype.
2413 This bug broke the build on AIX. Problem reported by Gilles Pion.
2414
9d0a235a
MA
24152012-05-14 Michael Albinus <michael.albinus@gmx.de>
2416
2417 * keyboard.c (kbd_buffer_get_event): Read special events also in
2418 batch mode. (Bug#11415)
2419
9e6b06ed
GM
24202012-05-12 Glenn Morris <rgm@gnu.org>
2421
2422 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2423
c1a1d7a3
EZ
24242012-05-12 Eli Zaretskii <eliz@gnu.org>
2425
2426 * lisp.mk (lisp): Add newcomment.elc.
2427
3fe7cdc8
GM
24282012-05-12 Glenn Morris <rgm@gnu.org>
2429
2430 * Makefile.in (MKDIR_P): New, set by configure.
2431 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2432
53f7d2c0
PE
24332012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2434
2435 Remove unused function hourglass_started.
2436 * dispextern.h (hourglass_started):
2437 * w32fns.c (hourglass_started):
2438 * xdisp.c (hourglass_started): Remove.
2439
75aafb17
JB
24402012-05-10 Juanma Barranquero <lekktu@gmail.com>
2441
2442 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2443 Update dependencies.
2444
12959e8e
PE
24452012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2446
97107e2e
PE
2447 * xgselect.c (xg_select): Put maxfds+1 into a var.
2448 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2449
12959e8e
PE
2450 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2451
836d29b3
DA
24522012-05-10 Dave Abrahams <dave@boostpro.com>
2453
2454 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2455 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2456
5cb67954
MA
24572012-05-09 Michael Albinus <michael.albinus@gmx.de>
2458
2459 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2460 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2461 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2462 Initialize xd_registered_buses.
2463
3478ec45
PE
24642012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2465
b263a6b0
PE
2466 Untag more efficiently if USE_LSB_TAG.
2467 This is based on a proposal by YAMAMOTO Mitsuharu in
2468 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2469 For an admittedly artificial (nth 8000 longlist) benchmark on
2470 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2471 Emacs's overall text size by 1%.
2472 * lisp.h (XUNTAG): New macro.
2473 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2474 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2475 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2476 * eval.c (Fautoload):
2477 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2478 * frame.h (XFRAME): Use XUNTAG.
2479
3478ec45
PE
2480 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2481 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2482 Remove unportable assumptions about print widths of types like
2483 dbus_uint32_t.
2484 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2485 intptr_t when converting between pointer and integer, to avoid GCC
2486 warnings about wrong width.
2487
666b903b 24882012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2489
2490 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2491 stack for each reader_thread, instead of defaulting to 8MB
2492 determined by the linker. This avoids failures in creating
2493 subprocesses on Windows 7, see the discussion in this thread:
2494 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2495
b120cc17
JC
24962012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2497
2498 Fix up display of the *Minibuf-0* buffer in the mini window.
2499 * keyboard.c (read_char): Don't clear the echo area if there's no
2500 message to clear.
2501 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2502 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2503
9a4b36f8
MA
25042012-05-07 Michael Albinus <michael.albinus@gmx.de>
2505
2506 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2507 batch mode.
2508
e5f9458f
CY
25092012-05-06 Chong Yidong <cyd@gnu.org>
2510
2511 * lisp.mk (lisp): Update.
2512
eceeb5fc 25132012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2514
2515 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2516
71873e2b
SM
25172012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2518
2519 * data.c (PUT_ERROR): New macro.
2520 (syms_of_data): Use it. Add new error type `user-error'.
2521 * undo.c (user_error): New function.
2522 (Fprimitive_undo): Use it.
2523 * print.c (print_error_message): Adjust print style for `user-error'.
2524 * keyboard.c (user_error): New function.
2525 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2526
ab0fa4e4
PE
25272012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 Do not limit current-time-string to years 1000..9999.
2530 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2531 (Fcurrent_time_string): Support any year that is supported by the
2532 underlying localtime representation. Don't use asctime, as it
2533 has undefined behavior for years outside the range -999..9999.
2534
7ed806a7
PE
25352012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2536
2537 Fix race conditions involving setenv, gmtime, localtime, asctime.
2538 Without this fix, interrupts could mess up code that uses these
2539 nonreentrant functions, since setting TZ invalidates existing
2540 tm_zone or tzname values, and since most of these functions return
2541 pointers to static storage.
2542 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2543 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2544 Grow the critical sections to include not just invoking
2545 localtime/gmtime, but also accessing these functions' results
2546 including their tm_zone values if any, and any related TZ setting.
2547 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2548 so that the struct tm is saved in the critical section.
2549 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2550 motivated by the fact that memory allocation needs to be outside
2551 the critical section.
2552
0c16dfed
DA
25532012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2554
2555 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2556 with RESET_INTERVAL.
2557
2558 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2559 Remove duplicated buffer name initialization.
2560
3f83ace8
JM
25612012-05-02 Jim Meyering <jim@meyering.net>
2562
2563 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2564
c7b8541e
JM
2565 * xfns.c (x_window): Use xstrdup (Bug#11375).
2566
90207a15 25672012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2568
2569 * xdisp.c (pos_visible_p): If already at a newline from the
2570 display string before the 'while' loop, don't walk back the glyphs
2571 from it3.glyph_row. Solves assertion violation when the display
2572 string begins with a newline (egg.el). (Bug#11367)
2573
b593d6a9
AH
25742012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2575
2576 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2577 Move to simple.el.
2578
4737362e
GM
25792012-05-01 Glenn Morris <rgm@gnu.org>
2580
99cf43f9
GM
2581 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2582 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2583 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2584 All were removed before 23.1.
2585
9311dcff
GM
2586 * dispnew.c: Remove HAVE_LIBNCURSES test;
2587 it is always true on relevant platforms.
2588
4d5c6349
GM
2589 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2590 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2591
4737362e
GM
2592 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2593
74dd3a6b
AS
25942012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2595
2596 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2597 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2598 Remove.
2599
13c379ee
PE
26002012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2601
2602 Do not avoid creating empty evaporating overlays (Bug#9642).
2603 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2604 That is, do not delete an evaporating overlay if it becomes
2605 empty after its bounds are adjusted to fit within its buffer.
2606 This fix caused other problems, and I'm reverting it until we get
2607 to the bottom of them.
2608
a8e7d6d7 26092012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2610
2611 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2612
a8e7d6d7 26132012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2614
2615 * xdisp.c (pos_visible_p): If the window start position is beyond
2616 ZV, start the display from buffer beginning. Prevents assertion
2617 violation in init_iterator when the minibuffer window is scrolled
2618 via the scroll bar.
2619
2620 * window.c (window_scroll_pixel_based): Likewise.
2621
a8e7d6d7 26222012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2623
2624 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2625
a8e7d6d7 26262012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2627
2628 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2629 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2630
a8e7d6d7 26312012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2632
b593d6a9
AH
2633 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2634 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2635
1c6900d9
EZ
26362012-04-26 Eli Zaretskii <eliz@gnu.org>
2637
4c3fa1d9
EZ
2638 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2639 display element, check also the underlying string or buffer
2640 character. (Bug#11341)
2641
1c6900d9
EZ
2642 * w32menu.c: Include w32heap.h.
2643 (add_menu_item): If the call to AppendMenuW (via
2644 unicode_append_menu) fails, disable Unicode menus only if we are
2645 running on Windows 9X/Me.
2646
42bf8205
AS
26472012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2648
2649 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2650 (xgetint): Add missing shift for LSB tags.
2651
b1bac16e
MR
26522012-04-24 Martin Rudalics <rudalics@gmx.at>
2653
2654 * keyboard.c (read_char): Don't wipe echo area for select window
2655 events: These might get delayed via `mouse-autoselect-window'
2656 (Bug#11304).
2657
d69621cc
JB
26582012-04-24 Juanma Barranquero <lekktu@gmail.com>
2659
2660 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2661 manipulation of :loaded-from data.
2662
02fd101b
JB
26632012-04-23 Juanma Barranquero <lekktu@gmail.com>
2664
2665 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2666 now a cons (bug#11311).
2667
888bec30
PE
26682012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2669
89a438bd
PE
2670 Do not create empty overlays with the evaporate property (Bug#9642).
2671 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2672 if it becomes empty after its bounds are adjusted to fit within
2673 its buffer. Without this fix, in a nonempty buffer (let ((o
2674 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2675 yields an empty overlay that has the evaporate property, which is
2676 not supposed to happen.
2677
1068fe4d
PE
2678 Fix minor GTK3 problems found by static checking.
2679 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2680 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2681 (struct _EmacsFixedClass, emacs_fixed_get_type):
2682 Move decls here from emacsgtkfixed.h, since they needn't be public.
2683 (emacs_fixed_get_type): Now static.
2684 (emacs_fixed_class_init): Omit unused local.
2685 (emacs_fixed_child_type): Remove; unused.
2686 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2687 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2688 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2689 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2690 (EMACS_FIXED_GET_CLASS): Remove; unused.
2691 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2692
888bec30
PE
2693 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2694 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2695
de85e130
PE
26962012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2697
d0baac98 2698 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2699 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2700 (__malloc_size_t, __malloc_ptrdiff_t):
2701 Remove. All uses removed, replaced by the definiens if needed,
2702 since we can assume C89 or better now.
2703 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2704 (protect_malloc_state, align, get_contiguous_space)
2705 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2706 (malloc_atfork_handler_child, malloc_enable_thread)
2707 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2708 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2709 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2710 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2711 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2712 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2713 Define using prototypes, not old style.
2714 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2715 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2716 (align): Don't assume that signed integer overflow wraps around.
2717 Omit unused local var.
2718 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2719 (_free_internal_nolock, memalign, mallochook, reallochook):
2720 Omit no-longer-needed casts.
2721 (valloc): Use getpagesize, not __getpagesize.
2722 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2723 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2724
de85e130
PE
2725 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2726
dcbf5805
MA
27272012-04-22 Michael Albinus <michael.albinus@gmx.de>
2728
2729 Move functions from C to Lisp. Make non-blocking method calls
2730 the default. Implement further D-Bus standard interfaces.
2731
2732 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2733 (QCdbus_request_name_allow_replacement)
2734 (QCdbus_request_name_replace_existing)
2735 (QCdbus_request_name_do_not_queue)
2736 (QCdbus_request_name_reply_primary_owner)
2737 (QCdbus_request_name_reply_in_queue)
2738 (QCdbus_request_name_reply_exists)
2739 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2740 (QCdbus_registered_serial, QCdbus_registered_method)
2741 (QCdbus_registered_signal): New Lisp objects.
2742 (XD_DEBUG_MESSAGE): Use sizeof.
2743 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2744 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2745 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2746 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2747 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2748 (xd_signature, xd_append_arg): Allow float for integer types.
2749 (xd_get_connection_references): New function.
b593d6a9
AH
2750 (xd_get_connection_address): Rename from xd_initialize.
2751 Return cached address.
dcbf5805
MA
2752 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2753 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2754 level.
2755 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2756 Return number of refcounts.
dcbf5805
MA
2757 (Fdbus_get_unique_name): Make stronger parameter check.
2758 (Fdbus_message_internal): New defun.
2759 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2760 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2761 (Fdbus_send_signal, Fdbus_register_service)
2762 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2763 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2764 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2765 (Vdbus_compiled_version, Vdbus_runtime_version)
2766 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2767 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2768 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2769 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2770 Adapt docstring.
dcbf5805 2771
52828e02
PE
27722012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2773
da05bc4c
PE
2774 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2775 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2776 Do not assume ptrdiff_t is the same width as 'int'.
2777
52828e02
PE
2778 * alloc.c: Handle unusual debugging option combinations.
2779 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2780 since the two debugging options are incompatible.
2781 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2782 is defined.
2783 (mem_init, mem_insert, mem_insert_fixup):
2784 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2785 (NEED_MEM_INSERT): Remove; no longer needed.
2786
f01769f9
LL
27872012-04-22 Leo Liu <sdl.web@gmail.com>
2788
2789 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2790
5790543d
PE
27912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 * sysdep.c [__FreeBSD__]: Minor cleanups.
2794 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2795 Use Emacs indenting style more consistently. Avoid some casts.
2796 Use 'double' consistently rather than mixing 'float' and 'double'.
2797
b91b7e4d
EW
27982012-04-21 Eduard Wiebe <usenet@pusto.de>
2799
b593d6a9
AH
2800 * sysdep.c (list_system_processes, system_process_attributes):
2801 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2802
6114eb15
AS
28032012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2804
2805 * lisp.mk (lisp): Update.
2806
2f38dff7
PE
28072012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2808
2809 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2810 It is never used otherwise.
2811
4ae29f89
SM
28122012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2813
2814 * print.c (print_preprocess): Only check print_depth if print-circle
2815 is nil.
2816 (print_object): Check for cycles even when print-circle is nil and
2817 print-gensym is t, but only check print_depth if print-circle is nil.
2818
f30d612a
CY
28192012-04-20 Chong Yidong <cyd@gnu.org>
2820
2821 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2822 set the status to "failed" and ensure that sentinel is run.
2823
c07a4c0b 28242012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2825
2826 * process.c (Fset_process_inherit_coding_system_flag)
2827 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2828 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2829
c07a4c0b 28302012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2831
2832 * xdisp.c (string_buffer_position_lim): Limit starting position to
2833 BEGV.
2834 (set_cursor_from_row): If called for a mode-line or header-line
2835 row, return zero immediately.
2836 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2837 farther than the first row after the header line, if any.
2838 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2839 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2840
c07a4c0b 28412012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2842
4ae29f89
SM
2843 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2844 (bug#11238).
ad3a2b41 2845
c07a4c0b 28462012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 28472012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2848
2849 configure: new option --enable-gcc-warnings (Bug#11207)
2850 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2851 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2852 (ALL_CFLAGS): Use new macros rather than old.
2853 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2854 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2855 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2856 -Wunused-result, -Wunused-variable. This should go away once
2857 the Emacs and Gnulib regex code is merged.
2858 (xmalloc, xrealloc): Now static.
2859
aba027e8
PE
28602012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2861
2862 * dired.c (Fsystem_groups): Remove unused local.
2863
e5a36063
GM
28642012-04-17 Glenn Morris <rgm@gnu.org>
2865
2866 * dired.c (Fsystem_users): Doc fix.
2867
316411f0
DA
28682012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2869
2870 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2871 (syms_of_dired): Add them.
2872
9426aba4
PE
28732012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2874
b62a57be
PE
2875 Fix minor alloc.c problems found by static checking.
2876 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2877 New extern decls, to avoid calling undeclared functions.
2878 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2879 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2880 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2881 (NEED_MEM_INSERT): New macro.
2882 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2883 Remove one incorrect comment and fix another.
b62a57be 2884
3539f31f
PE
2885 Fix minor ralloc.c problems found by static checking.
2886 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2887 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2888 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2889 (r_alloc_sbrk): Now static.
2890
a041960a
PE
2891 Improve ralloc.c interface checking.
2892 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2893 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2894 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2895 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2896 [REL_ALLOC]: ... to here, to check interface.
2897 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2898 Remove decls. This fixes an "It stinks!".
2899
9426aba4
PE
2900 * alloc.c (which_symbols): Fix alignment issue / type clash.
2901
d55c12ed
AS
29022012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2903
2904 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2905 (struct Lisp_Misc_Any): Likewise.
2906 (struct Lisp_Free): Likewise.
2907 * alloc.c (union aligned_Lisp_Symbol): Define.
2908 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2909 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2910 (union aligned_Lisp_Misc): Define.
2911 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2912 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2913 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2914
b948ce8b
PE
29152012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2918 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2919 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2920 * s/netbsd.h, s/sol2-6.h:
2921 Remove definition of GC_MARK_STACK, since the default now works.
2922 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2923 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2924 no longer the default.
2925 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2926
35dc09a1 29272012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2928
35dc09a1
GM
2929 * lread.c (lisp_file_lexically_bound_p):
2930 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2931
35dc09a1
GM
29322012-04-14 Eli Zaretskii <eliz@gnu.org>
2933
2934 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2935 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2936
29372012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2938
2939 * nsterm.m (constrainFrameRect): Always constrain when there is only
2940 one screen (Bug#10962).
2941
bcd86815
KB
29422012-04-13 Ken Brown <kbrown@cornell.edu>
2943
2944 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2945
c25df26e
RT
29462012-04-13 Reuben Thomas <rrt@sc3d.org>
2947
2948 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2949
0fc59f1e
DC
29502012-04-11 Daniel Colascione <dancol@dancol.org>
2951
2952 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2953 against is gone. It's better to use vfork now so that when Cygwin
2954 gains a new, working vfork, we use it automatically (bug#10398).
2955
de8c03dc
SM
29562012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2957
2958 * window.c (save_window_save): Obey window-point-insertion-type.
2959
2f097256
GM
29602012-04-11 Glenn Morris <rgm@gnu.org>
2961
2962 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2963
453b951e
SM
29642012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2965
2966 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2967
75f1671a 29682012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2969
2970 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2971 (force_quit_count): New var.
2972 (handle_interrupt): Use it.
2973
2a8ce227
JB
29742012-04-10 Juanma Barranquero <lekktu@gmail.com>
2975
2976 * w32.c (w32_delayed_load): Record the full path of the library
2977 being loaded (bug#10424).
2978
935396c0
GM
29792012-04-09 Glenn Morris <rgm@gnu.org>
2980
05920a43
GM
2981 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2982 not just in the obarray, before snarfing them. (Bug#11036)
2983
935396c0
GM
2984 * Makefile.in ($(leimdir)/leim-list.el):
2985 Pass EMACS rather than BUILT_EMACS.
2986
a18ecafa
TZ
29872012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2988
2989 * process.c (make_process):
2990 * process.h: Add integer `gnutls_handshakes_tried' member to
2991 process struct.
2992
6bbef4e5
JC
2993 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2994 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2995
2996 * gnutls.c (gnutls_log_function2i): Convenience log function.
2997 (emacs_gnutls_read): Use new log functions,
2998 `gnutls_handshakes_tried' process member, and
2999 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3000 attempts per process (connection).
3001
b4d3bc10
CY
30022012-04-09 Chong Yidong <cyd@gnu.org>
3003
3004 * eval.c (Fuser_variable_p, user_variable_p_eh)
3005 (lisp_indirect_variable): Functions deleted.
3006 (Fdefvar): Caller changed.
3007
3008 * callint.c (Finteractive, Fcall_interactively):
3009 * minibuf.c (Fread_variable): Callers changed.
3010
70f4d973
EZ
30112012-04-09 Eli Zaretskii <eliz@gnu.org>
3012
3013 * xdisp.c (set_cursor_from_row): If the display string appears in
3014 the buffer at position that is closer to point than the position
3015 after the display string, display the cursor on the first glyph of
3016 the display string. Fixes cursor display when a 'display' text
3017 property immediately follows invisible text. (Bug#11094)
3018
cb3c2e3e
PE
30192012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3020
3021 composite.c: use 'double' consistently
3022 * composite.c (get_composition_id): Use 'double' consistently
3023 instead of converting 'float' to 'double' and vice versa; this is
3024 easier to understand and avoids a GCC warning.
3025
fd06db5d
GM
30262012-04-09 Glenn Morris <rgm@gnu.org>
3027
50fe702a
GM
3028 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3029 preparation for dumping it with emacs. (Bug#4789)
3030 (leimdir): New variable.
3031 ($(leimdir)/leim-list.el): New rule.
3032 (emacs$(EXEEXT)): Depend on leim-list.el.
3033
fd06db5d
GM
3034 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3035 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3036 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3037
55c131ee
AS
30382012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3039
3040 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3041 proper alignment.
3042
9209588f
JB
30432012-04-07 Juanma Barranquero <lekktu@gmail.com>
3044
3045 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3046 Remove unused local variable.
3047
e3fb2efb
PE
30482012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3049
3050 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3051 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3052 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3053 objects, as mark_maybe_pointer will catch them otherwise.
3054 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3055 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3056
b5385551
PE
30572012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 Fix typo that broke non-Windows builds.
3060 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3061
9078ead6
EZ
30622012-04-07 Eli Zaretskii <eliz@gnu.org>
3063
3064 Support building on MS-Windows with libxml2.
3065
3066 * makefile.w32-in (OBJ2): Add xml.$(O).
3067 (GLOBAL_SOURCES): Add xml.c.
3068 ($(BLD)/xml.$(O)): New dependency list.
3069
3070 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3071 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3072 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3073 [!WINDOWSNT]: New macros.
3074 (init_libxml2_functions, libxml2_loaded_p): New functions.
3075 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3076 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3077 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3078 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3079 linked in).
6bbef4e5
JC
3080 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3081 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3082 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3083
3084 * emacs.c: Don't include libxml/parser.h.
3085 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3086 xmlCleanupParser directly.
3087
3088 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3089
3811fdf3
EZ
30902012-04-07 Eli Zaretskii <eliz@gnu.org>
3091
3092 * indent.c (Fvertical_motion): If there is a display string at
3093 point, use it.vpos to compute how many lines to backtrack after
3094 move_it_to point. (Bug#11133)
3095
2f8e16b2
EZ
30962012-04-06 Eli Zaretskii <eliz@gnu.org>
3097
3098 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3099 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3100 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3101 macros related to unification of CJK characters. For the details,
3102 see the discussion following the message here:
3103 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3104
3d439cd1
CY
31052012-04-04 Chong Yidong <cyd@gnu.org>
3106
3107 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3108
8bc53d00
EZ
31092012-04-01 Eli Zaretskii <eliz@gnu.org>
3110
3111 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3112 instead of alloca. (Bug#11138)
3113
3b0512a3
AS
31142012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3115
3116 * w32menu.c (is_simple_dialog): Properly check lisp types.
3117 (Bug#11141)
3118
8427ddd2
EZ
31192012-03-31 Eli Zaretskii <eliz@gnu.org>
3120
979022ef
EZ
3121 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3122 position we get to after a call to move_it_to fails the
3123 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3124 only if we wind up in a string from display property. (Bug#11063)
3125
a6b1c7cc
EZ
3126 * window.c (Fdelete_other_windows_internal): Invalidate the row
3127 and column information about mouse highlight, so that redisplay
3128 restores it after reallocating the glyph matrices. (Bug#7464)
3129
8427ddd2
EZ
3130 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3131 string comes from a `display' text property, use the buffer
3132 position of that property as if we actually saw that position in
3133 the row's glyphs.
697ba24b
EZ
3134 (move_it_by_lines): Remove the assertion that
3135 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3136 violated when there's a before-string at the beginning of a line.
3137 (Bug#11063)
8427ddd2 3138
65a0a738
EZ
31392012-03-30 Eli Zaretskii <eliz@gnu.org>
3140
3141 * xdisp.c (append_space_for_newline): If the default face was
3142 remapped, use the remapped face for the appended newline.
3143 (extend_face_to_end_of_line): Use the remapped default face for
3144 extending the face to the end of the line.
3145 (display_line): Call extend_face_to_end_of_line when the default
3146 face was remapped. (Bug#11068)
3147
581355cc
EZ
31482012-03-29 Eli Zaretskii <eliz@gnu.org>
3149
3150 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3151
e8fc049f
SM
31522012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3153
3154 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3155
4fb9a543
GM
31562012-03-27 Glenn Morris <rgm@gnu.org>
3157
3158 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3159 Doc fixes.
3160
679910f1
KH
31612012-03-26 Kenichi Handa <handa@m17n.org>
3162
3163 * dispextern.h (struct glyph): Fix previous change. Change the
3164 bit length of glyphless.ch to 25 (Bug#11082).
3165
90d49b7f
CY
31662012-03-26 Chong Yidong <cyd@gnu.org>
3167
3168 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3169 (command_loop_1): Use it; inhibit selection update for
3170 handle-select-window too (Bug#8996).
3171
f514f6f0
FP
31722012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3173
e8fc049f 3174 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3175
bf43fa51
KH
31762012-03-25 Kenichi Handa <handa@m17n.org>
3177
3178 * dispextern.h (struct glyph): Change the bit length of
3179 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3180
8a0c01dd
EZ
31812012-03-24 Eli Zaretskii <eliz@gnu.org>
3182
3183 * s/ms-w32.h (tzname): Include time.h before redirecting to
3184 _tzname. Fixes the MSVC build. (Bug#9960)
3185
7d1c3a76
AS
31862012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3187
8ed79523
AS
3188 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3189 characters.
3190
7d1c3a76
AS
3191 * xterm.c (XTread_socket): Only modify handling_signal if
3192 !SYNC_INPUT. (Bug#11080)
3193
e99a9b8b
EZ
31942012-03-23 Eli Zaretskii <eliz@gnu.org>
3195
3196 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3197 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3198 when fetching a multibyte character consumes more bytes than
3199 CHAR_BYTES returns, due to unification of CJK characters in
3200 string_char. (Bug#11073)
3201
5063c0e1
TN
32022012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3203
3204 * process.c (wait_reading_process_output): Handle pty disconnect
3205 by refraining from sending oneself a SIGCHLD (bug#10933).
3206
9f851fbd
CY
32072012-03-22 Chong Yidong <cyd@gnu.org>
3208
3209 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3210
5063c0e1 3211 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3212 Mark string as coming from a prefix property.
3213 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3214 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3215
fb5b8aca
CY
32162012-03-21 Chong Yidong <cyd@gnu.org>
3217
3218 * xfaces.c (Vface_remapping_alist): Doc fix.
3219
62356a1b
EZ
32202012-03-20 Eli Zaretskii <eliz@gnu.org>
3221
3222 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3223 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3224 Doc fixes.
62356a1b 3225
025de85b
CY
32262012-03-20 Chong Yidong <cyd@gnu.org>
3227
3228 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3229 to reflect default non-nil value of redisplay-dont-pause.
3230
4827f94e
KH
32312012-03-19 Kenichi Handa <handa@m17n.org>
3232
3233 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3234 it fit in a valid range (Bug#11003).
3235
e50a24a2
EZ
32362012-03-18 Eli Zaretskii <eliz@gnu.org>
3237
3238 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3239 that is not from display property, accept the row as a "cursor
3240 row" if one of the string's character has a non-nil `cursor'
3241 property. Fixes cursor positioning when there are newlines in
3242 overlay strings, e.g. in icomplete.el. (Bug#11035)
3243
9af5ed87
PE
32442012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3245
3246 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3247
d1f55f16
CY
32482012-03-12 Chong Yidong <cyd@gnu.org>
3249
3250 * eval.c (inhibit_lisp_code): Rename from
3251 inhibit_window_configuration_change_hook; move from window.c.
3252
3253 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3254 * window.c (run_window_configuration_change_hook)
3255 (syms_of_window): Callers changed.
3256
66c5eebd
CY
32572012-03-11 Chong Yidong <cyd@gnu.org>
3258
413df973
CY
3259 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3260
66c5eebd
CY
3261 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3262
1de11f56
CY
32632012-03-10 Chong Yidong <cyd@gnu.org>
3264
3265 * frame.c (other_visible_frames): Don't assume the selected frame
3266 is visible (Bug#10955).
3267
cae07000
SM
32682012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3269
3270 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3271
89c94350
JD
32722012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3273
3274 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3275 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3276 zero (Bug#10954).
3277
999dd333
GM
32782012-03-03 Glenn Morris <rgm@gnu.org>
3279
01a6dcc8 3280 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3281
de0100f2
EZ
32822012-03-02 Eli Zaretskii <eliz@gnu.org>
3283
3284 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3285 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3286 (redisplay_window, next_element_from_string): Fix typos in
3287 comments.
3e441275
EZ
3288 (redisplay_window): Pass to move_it_vertically the margin in
3289 pixels, not in screen lines.
de0100f2 3290
96a72ee9
GM
32912012-03-02 Glenn Morris <rgm@gnu.org>
3292
3293 * buffer.c (buffer-list-update-hook): Doc fix.
3294
312508d7
EZ
32952012-02-29 Eli Zaretskii <eliz@gnu.org>
3296
3297 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3298 push_it before setting up the iterator for the first overlay
3299 string, even if we have an empty string loaded.
3300 (next_overlay_string): If there's an empty string on the iterator
3301 stack, pop the stack. (Bug#10903)
3302
27f3c637
PE
33032012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3304
3305 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3306 Suggested by Stefan Monnier in
3307 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3308 * alloc.c (widen_to_Lisp_Object): New static function.
3309 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3310 and widening them to Lisp_Objects. This would work even if
3311 USE_LSB_TAG is defined and wide integers are used, which might
3312 happen in a future version of Emacs.
3313
3c9dfce6
CY
33142012-02-25 Chong Yidong <cyd@gnu.org>
3315
fa74b241
CY
3316 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3317 Doc fix.
3318
3c9dfce6
CY
3319 * xselect.c (Fx_selection_exists_p): Doc fix.
3320 (x_clipboard_manager_save_all): Print an informative message
3321 before saving to clipboard manager.
3322
9486df08
CY
33232012-02-24 Chong Yidong <cyd@gnu.org>
3324
3325 * keyboard.c (process_special_events): Handle all X selection
3326 requests in kbd_buffer, not just the next one (Bug#8869).
3327
f01d3321
CY
33282012-02-23 Chong Yidong <cyd@gnu.org>
3329
3330 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3331 call when setting menu-bar-lines and tool-bar-lines parameters.
3332 (unwind_create_frame_1): New helper function.
3333
3334 * window.c (inhibit_window_configuration_change_hook): New var.
3335 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3336 (syms_of_window): Initialize it.
f01d3321 3337
86b847b6
CY
33382012-02-22 Chong Yidong <cyd@gnu.org>
3339
3340 * xterm.c (x_draw_image_relief): Add missing type check for
3341 Vtool_bar_button_margin (Bug#10743).
3342
a59225b1
CY
33432012-02-21 Chong Yidong <cyd@gnu.org>
3344
3345 * fileio.c (Vfile_name_handler_alist): Doc fix.
3346
3347 * buffer.c (Fget_file_buffer): Protect against invalid file
3348 handler return value.
3349
310f5bd4
PE
33502012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3351
cb3a28cc
PE
3352 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3353 when computing $valmask.
3354
310f5bd4
PE
3355 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3356 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3357 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3358 It's useless in that case, and it can cause problems on hosts
3359 that allocate halves of EMACS_INT values separately.
3360 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3361 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3362 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3363 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3364 it avoids undefined behavior on hosts where shifting right by more
3365 than the word width has undefined behavior.
3366
2375c96a
CY
33672012-02-19 Chong Yidong <cyd@gnu.org>
3368
3369 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3370 (Funhandled_file_name_directory, Ffile_name_as_directory)
3371 (Fdirectory_file_name, Fexpand_file_name)
3372 (Fsubstitute_in_file_name): Protect against invalid file handler
3373 return values (Bug#10845).
3374
3eb49e71
EZ
33752012-02-18 Eli Zaretskii <eliz@gnu.org>
3376
3377 * .gdbinit (pitx): Fix incorrect references to fields of the
3378 iterator stack.
3379
7b926f3f
CY
33802012-02-17 Chong Yidong <cyd@gnu.org>
3381
3382 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3383
11273115
PE
33842012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3385
3386 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3387 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3388
c3a70e2b
CY
33892012-02-15 Chong Yidong <cyd@gnu.org>
3390
3391 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3392 marked as special. Also, starting docstrings with * is obsolete.
3393
0ca43699
AS
33942012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3395
3396 * gnutls.c (emacs_gnutls_write): Fix last change.
3397
2e8f3c56
LI
33982012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3399
3400 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3401 send_process.
3402
af70074f
SM
34032012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3404
3405 * keymap.c (Fsingle_key_description): Handle char ranges.
3406
95986d52
CY
34072012-02-12 Chong Yidong <cyd@gnu.org>
3408
afd83bd1
CY
3409 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3410 as that creates a dangerous corner case.
3411
95986d52
CY
3412 * window.c (Fdelete_window_internal): Invalidate the mouse
3413 highlight (Bug#9904).
3414
bd7da63e
GM
34152012-02-12 Glenn Morris <rgm@gnu.org>
3416
3417 * xselect.c (Fx_own_selection_internal)
3418 (Fx_get_selection_internal, Fx_disown_selection_internal)
3419 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3420 * nsselect.m (Fx_own_selection_internal)
3421 (Fx_disown_selection_internal, Fx_selection_exists_p)
3422 (Fx_selection_owner_p, Fx_get_selection_internal):
3423 Sync docs and argument specs with the xselect.c versions.
3424
77abcbc2
LI
34252012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3426
3427 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3428
90b671e2
EZ
34292012-02-11 Eli Zaretskii <eliz@gnu.org>
3430
1c0ca0b7
EZ
3431 * w32select.c (Fx_selection_exists_p): Sync doc string and
3432 argument list with xselect.c. (Bug#10783)
3433
3434 * w16select.c (Fx_selection_exists_p): Sync doc string and
3435 argument list with xselect.c. (Bug#10783)
90b671e2 3436
49241268
GM
34372012-02-10 Glenn Morris <rgm@gnu.org>
3438
3439 * fns.c (Fsecure_hash): Doc fix.
3440
f998bbe7 34412012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3442
3443 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3444
0992bd9c
CY
34452012-02-07 Chong Yidong <cyd@gnu.org>
3446
3447 * buffer.c (Fbuffer_local_variables)
3448 (buffer_lisp_local_variables): Handle unbound vars correctly;
3449 don't let Qunbound leak into Lisp.
3450
af008560
GM
34512012-02-07 Glenn Morris <rgm@gnu.org>
3452
dd605cc4
GM
3453 * image.c (Fimagemagick_types): Doc fix.
3454
af008560
GM
3455 * image.c (imagemagick-render-type): Change it from a lisp object
3456 to an integer. Move the doc here from the lisp manual.
3457 Treat all values not equal to 0 the same.
3458
1449fa1d
CY
34592012-02-06 Chong Yidong <cyd@gnu.org>
3460
3461 * doc.c (store_function_docstring): Avoid applying docstring of
3462 alias to base function (Bug#2603).
3463
3723ec07
AS
34642012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3465
3466 * .gdbinit (pp1, pv1): Remove redundant defines.
3467 (pr): Use pp.
3468
79c1cc1e
CY
34692012-02-04 Chong Yidong <cyd@gnu.org>
3470
3471 * nsterm.m: Declare a global (Bug#10694).
3472
d7f29f8e
EZ
34732012-02-04 Eli Zaretskii <eliz@gnu.org>
3474
cae07000
SM
3475 * w32.c (get_emacs_configuration_options):
3476 Include --enable-checking, if specified, in the return value.
d7f29f8e 3477
3b95a6f9
MR
34782012-02-04 Martin Rudalics <rudalics@gmx.at>
3479
3480 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3481 after rounding frame sizes. (Bug#9723)
3482
d6fa96a6
EZ
34832012-02-04 Eli Zaretskii <eliz@gnu.org>
3484
3485 * keyboard.c (adjust_point_for_property): Don't position point
3486 before BEGV. (Bug#10696)
3487
df0b2940
PE
34882012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3489
3490 Handle overflow when computing char display width (Bug#9496).
3491 * character.c (char_width): Return EMACS_INT, not int.
3492 (char_width, c_string_width): Check for overflow when
3493 computing the width; this is possible now that individual
3494 characters can have unbounded width. Problem introduced
3495 by merge from Emacs 23 on 2012-01-19.
3496
6bee44d6
MA
34972012-02-02 Michael Albinus <michael.albinus@gmx.de>
3498
3499 * dbusbind.c (Fdbus_register_method): Mention the return value
3500 :ignore in the docstring.
3501
44f92739
GM
35022012-02-02 Glenn Morris <rgm@gnu.org>
3503
1b9f60cc
GM
3504 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3505
44f92739
GM
3506 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3507 Unconditionally set to t. (Bug#10673)
3508 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3509 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3510 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3511
c5d3843c
KH
35122012-02-02 Kenichi Handa <handa@m17n.org>
3513
3514 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3515 0, do not call append_composite_glyph.
3516
159462d4 35172012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3518
3519 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3520 NULL (Bug#6988).
3521 (x_produce_glyphs): If the component of a composition is a null
3522 string, set it->pixel_width to 1 to avoid zero-width glyph.
3523
78cef877
EZ
35242012-02-01 Eli Zaretskii <eliz@gnu.org>
3525
3526 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3527 first 2 arguments are identical. This makes inserting large
3528 output from a subprocess an order of magnitude faster on
3529 MS-Windows, where all sbrk'ed memory is always contiguous.
3530
97897668
GM
35312012-01-31 Glenn Morris <rgm@gnu.org>
3532
3533 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3534 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3535 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3536
31fd3586
GM
35372012-01-29 Glenn Morris <rgm@gnu.org>
3538
3539 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3540
0e24a8b2
CY
35412012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3542
3543 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3544
cc0adcb0
CY
35452012-01-28 Chong Yidong <cyd@gnu.org>
3546
3547 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3548
acc28cb9
CY
35492012-01-26 Chong Yidong <cyd@gnu.org>
3550
9c69cfb7
CY
3551 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3552
acc28cb9
CY
3553 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3554 repeat counts (Bug#10507).
3555
48da7392
GM
35562012-01-26 Glenn Morris <rgm@gnu.org>
3557
3558 * lread.c (syms_of_lread): Doc fix.
3559
14af5f7f
CY
35602012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3561
3562 * coding.c (encode_designation_at_bol): Change return value to
3563 EMACS_INT.
3564
0b21c100
CY
35652012-01-25 Chong Yidong <cyd@gnu.org>
3566
3567 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3568
3c2907f7
CY
35692012-01-21 Chong Yidong <cyd@gnu.org>
3570
3571 * floatfns.c (Fcopysign): Make the second argument non-optional,
3572 since nil is not allowed anyway.
3573
959ad23f
AS
35742012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3575
3576 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3577 (send_process): Likewise.
3578
34a02f46
MR
35792012-01-19 Martin Rudalics <rudalics@gmx.at>
3580
3581 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3582 (Vwindow_persistent_parameters): Do not use Qstate.
3583 Rewrite doc-strings.
34a02f46 3584
1259009a 35852012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3586
3587 * character.c (char_width): New function.
70d4fdf6
GM
3588 (Fchar_width, c_string_width, lisp_string_width):
3589 Use char_width (Bug#9496).
25ed9e61 3590
6a6ee00d
MR
35912012-01-16 Martin Rudalics <rudalics@gmx.at>
3592
3593 * window.c (Vwindow_persistent_parameters): New variable.
3594 (Fset_window_configuration, save_window_save): Handle persistent
3595 window parameters.
3596
c85efaf7
EZ
35972012-01-14 Eli Zaretskii <eliz@gnu.org>
3598
3599 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3600 thrashing the stack of the thread. (Bug#9087)
3601
5944709e
PE
36022012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3605
e71f5d99
EZ
36062012-01-11 Eli Zaretskii <eliz@gnu.org>
3607
3608 * xdisp.c (rows_from_pos_range): Handle the case where the
3609 highlight ends on a newline. (Bug#10464)
3610 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3611 he end column for display of highlight that ends on a newline
3612 before a R2L line.
3613
ce316182
GM
36142012-01-11 Glenn Morris <rgm@gnu.org>
3615
3616 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3617 from load-path also when installation-directory is nil. (Bug#10208)
3618
5b43da69
GM
36192012-01-10 Glenn Morris <rgm@gnu.org>
3620
74cc8ff9
GM
3621 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3622
7d8d6e4e
GM
3623 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3624 Update template values to be closer to their typical values these days.
5b43da69 3625
a0db8d43
EZ
36262012-01-09 Eli Zaretskii <eliz@gnu.org>
3627
3628 * xdisp.c (rows_from_pos_range): Accept additional argument
3629 DISP_STRING, and accept any glyph in a row whose object is that
3630 string as eligible for mouse highlight. Fixes mouse highlight of
3631 display strings from overlays. (Bug#10464)
3632
9a0115ab 36332012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3634
b9110d6a 3635 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3636 * fileio.c (auto_saving_dir_umask): New static var.
3637 (Fmake_directory_internal): Use it.
3638 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3639 creating the directory. The old code temporarily assigns
3640 too-generous permissions to the directory.
3641 (do_auto_save_eh): Clear it.
b9110d6a 3642 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3643 that the var is always cleared.
3644
6c1bd3f3
EZ
36452012-01-07 Eli Zaretskii <eliz@gnu.org>
3646
3647 * search.c (scan_buffer): Pass character positions to
3648 know_region_cache, not byte positions. (Bug#6540)
3649
069d2b50
L
36502012-01-07 LynX <_LynX@bk.ru> (tiny change)
3651
3652 * w32.c (sys_rename): Report EXDEV when rename of a directory
3653 fails because the target is on another logical disk. (Bug#10284)
3654
75bf0d33
DB
36552012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3656
3657 * xterm.c (x_embed_request_focus): New function.
3658
3659 * xterm.h: Add prototype.
3660
3661 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3662
1c6e5a32
GM
36632012-01-05 Glenn Morris <rgm@gnu.org>
3664
3665 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3666
651e947e
EZ
36672012-01-01 Eli Zaretskii <eliz@gnu.org>
3668
3669 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3670 Load gnutls_transport_set_lowat only if GnuTLS version is below
3671 2.11.1.
3672 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3673 GnuTLS versions below 2.11.1.
3674
3778cdd8
AL
36752011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3676
3677 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3678 to the doc string advising against its use for altering the way
3679 windows are scrolled.
3680
0e5317f7
KH
36812011-12-28 Kenichi Handa <handa@m17n.org>
3682
3683 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3684 coding-system ASCII compatible only when it does not produce BOM
3685 on encoding (Bug#10383).
3686
93d5ca1f
JD
36872011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3688
3689 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3690 can scroll.
3691 (create_and_show_popup_menu): Always use menu_position_func for
3692 Gtk3 (Bug#10361).
3693
ca22b785
AS
36942011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3695
3696 * callint.c (Fcall_interactively): Don't truncate prompt string.
3697
d048e1e6
EZ
36982011-12-23 Eli Zaretskii <eliz@gnu.org>
3699
3700 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3701 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3702 resumed from there (after widening). (Bug#10360)
d048e1e6 3703
5ccaba1f
JD
37042011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3705
3706 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3707
204ee57f
JD
37082011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3709
b81d40f0
JB
3710 * nsterm.m (x_free_frame_resources):
3711 Release f->output_data.ns->miniimage.
204ee57f
JD
3712 (ns_index_color): Fix indentation. Do not retain
3713 color_table->colors[i].
3714
3715 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3716 before returning.
3717
3718 * nsfns.m (x_set_background_color): Assign return value from
3719 ns_index_color to face-background instead of NSColor*.
3720 (ns_implicitly_set_icon_type): Fix indentation.
3721 Change assignment in for loop to comparison.
3722
3723 * emacs.c (ns_pool): New variable.
3724 (main): Assign ns_pool.
3725 (Fkill_emacs): Call ns_release_autorelease_pool.
3726
3727 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3728 autorelease fdesc, release fdAttrs and tdict.
3729 (ns_get_covering_families): Release charset.
3730 (ns_findfonts): Release NSFontDescriptor created with new.
3731 (ns_uni_to_glyphs): Fix indentation.
3732 (setString): Release attrStr before assigning new value.
3733
c803b2b7
JD
37342011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3735
678f4426
JD
3736 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3737 and NS_IMPL_COCOA.
3738 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3739 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3740
cd394be1 37412011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3742
5fecd5fc
JD
3743 * nsterm.m (ns_term_init): Subscribe for notifications
3744 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3745 to method trackingNotification in EmacsMenu.
3746
3747 * nsmenu.m (trackingMenu): New variable.
3771cb17 3748 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3749 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3750 from Aquamacs (Bug#7030).
678f4426
JD
3751
37522011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3753
c803b2b7
JD
3754 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3755 (symbol_to_nsstring): Fix indentation.
3756 (ns_symbol_to_pb): New function.
cae07000
SM
3757 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3758 (Fns_rotate_cut_buffers_internal): Remove.
3759 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3760 Fns_store_cut_buffer_internal.
3761 (ns_get_foreign_selection, Fx_own_selection_internal)
3762 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3763 (Fns_get_selection_internal, Fns_store_selection_internal):
3764 Use ns_symbol_to_pb and check if return value is nil.
3765 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3766 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3767 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3768 renamed to Sns_store_selection_internal.
3769 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3770 and remove this function.
3771 (ns_handle_selection_clear): Remove, never used.
3772 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3773 here.
3774
e1b01a3a
KB
37752011-12-17 Ken Brown <kbrown@cornell.edu>
3776
3777 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3778 GID is unknown (Bug#10257).
3779
2adb6e85
PE
37802011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3781
3782 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3783 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3784 which caused a build failure on GNU/Linux IA-64. This problem was
3785 introduced by my 2011-10-07 patch.
3786
d1d7b339
JL
37872011-12-15 Juri Linkov <juri@jurta.org>
3788
3789 * image.c (imagemagick_error): New function. (Bug#10112)
3790 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3791 Use `imagemagick_error' where ImageMagick functions return
3792 `MagickFalse'.
3793 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3794 proper order.
3795
100d5755
KH
37962011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3797
3798 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3799 fill background (Bug#8992).
3800
454592a6
MR
38012011-12-13 Martin Rudalics <rudalics@gmx.at>
3802
3803 * window.c (Vwindow_combination_resize)
3804 (Vwindow_combination_limit): Use t instead of non-nil in
3805 doc-strings.
61d4b438
MR
3806 (Vrecenter_redisplay): Add first sentence of doc-string on
3807 separate line.
53524d93 3808 (Frecenter): Fix doc-string typo.
454592a6 3809
3633e3aa
KH
38102011-12-11 Kenichi Handa <handa@m17n.org>
3811
3812 * coding.c (Funencodable_char_position): Pay attention to the
3813 buffer text relocation (Bug#9389).
3814
7b9d523a 38152011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3816
7b9d523a
JD
3817 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3818 gtk_init (Bug#10100).
3819
b73189c6
EZ
38202011-12-10 Eli Zaretskii <eliz@gnu.org>
3821
3822 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3823 IT->string is nil. (Bug#10263)
3824
f7dfe5d6
JD
38252011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3826
83faebb4
JD
3827 * nsterm.h (x_free_frame_resources): Declare.
3828
f7dfe5d6
JD
3829 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3830 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3831
3832 * nsterm.h (ns_get_defaults_value): Declare.
3833
3834 * nsterm.m (ns_default): Call ns_get_defaults_value.
3835
7cd4e72c
EZ
38362011-12-09 Eli Zaretskii <eliz@gnu.org>
3837
3838 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3839 (Bug#10170)
3840
b34d7317
YM
38412011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3842
3843 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3844 that where the value of an _OBJC_* symbol points to is in the .bss
3845 section (Bug#10240).
3846
76470ad1
KH
38472011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3848
3849 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3850 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3851
745fff94
KH
38522011-12-08 Kenichi Handa <handa@m17n.org>
3853
3854 * ftfont.c (get_adstyle_property): Fix previous change
3855 (Bug#10233).
3856
6e44397c
JB
38572011-12-07 Juanma Barranquero <lekktu@gmail.com>
3858
3859 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3860 dirs from the default value of EMACSLOADPATH (bug#10208).
3861
7efa6272
GM
38622011-12-07 Glenn Morris <rgm@gnu.org>
3863
3864 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3865 installation and source directories as well. (Bug#10208)
3866
f6fc4d87
CY
38672011-12-06 Chong Yidong <cyd@gnu.org>
3868
3869 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3870
2bf26180
GM
38712011-12-06 Glenn Morris <rgm@gnu.org>
3872
3873 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3874 as an error, not just -1. (Bug#10217)
3875
3a6ad4f0
CY
38762011-12-05 Chong Yidong <cyd@gnu.org>
3877
3878 * keyboard.c (process_special_events): New function.
3879 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3880
75a3b399
PE
38812011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 * coding.c (encode_designation_at_bol): Don't use uninitialized
3884 local variable (Bug#9318).
3885
c3c9e25e
KH
38862011-12-05 Kenichi Handa <handa@m17n.org>
3887
3888 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3889 return Qnil (Bug#8046, Bug#10193).
3890
5eb05ea3
KH
38912011-12-05 Kenichi Handa <handa@m17n.org>
3892
3893 * coding.c (encode_designation_at_bol): New args charbuf_end and
3894 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3895 (coding_set_source): Return how many bytes coding->source was
3896 relocated.
3897 (coding_set_destination): Return how many bytes
3898 coding->destination was relocated.
3899 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3900 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3901
39022011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3903
3904 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3905 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3906 macro (Bug#9318).
3907
39082011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3909
3910 The following changes are to fix Bug#9318.
3911
a79703f5 3912 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3913 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3914 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3915 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3916
7dbda6df
JB
39172011-12-05 Juanma Barranquero <lekktu@gmail.com>
3918
3919 * lisp.h (process_quit_flag): Fix external declaration.
3920
6d5eb5b0
SM
39212011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3922
3923 Don't macro-inline non-performance-critical code.
3924 * eval.c (process_quit_flag): New function.
3925 * lisp.h (QUIT): Use it.
3926
a0c3fad0
JD
39272011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3928
3929 * nsfns.m (get_geometry_from_preferences): New function.
3930 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3931
6c07aac2
AS
39322011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3933
3934 * emacs.c (Qkill_emacs): Define.
3935 (syms_of_emacs): Initialize it.
3936 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3937 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3938 (quit_throw_to_read_char): Add parameter `from_signal'.
3939 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3940 * lisp.h (QUIT): Call Fkill_emacs if requested.
3941
c052ead4
JD
39422011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3943
3944 * widget.c (update_wm_hints): Return if wmshell is null.
3945 (widget_update_wm_size_hints): New function.
3946
3947 * widget.h (widget_update_wm_size_hints): Declare.
3948
3949 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3950 widget_update_wm_size_hints (Bug#10104).
3951
9e49252b
EZ
39522011-12-03 Eli Zaretskii <eliz@gnu.org>
3953
3954 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3955 before a newline, prepare the bidi iterator for consuming the
3956 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3957 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3958
02b16839
JL
39592011-12-02 Juri Linkov <juri@jurta.org>
3960
3961 * search.c (Fword_search_regexp): New Lisp function created from
3962 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3963 (Fword_search_backward, Fword_search_forward)
3964 (Fword_search_backward_lax, Fword_search_forward_lax):
3965 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3966 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3967
0068070e
SM
39682011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3969
3970 * fileio.c (Finsert_file_contents): Move after-change-function call
3971 to before the "handled:" label, since all "goto handled" appear in
3972 cases where the *-change-functions have already been properly called
3973 (bug#10117).
3974
3360a3fc
AS
39752011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3976
3977 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3978 waiting for input. (Bug#10169)
3979
73d6c093
EZ
39802011-11-30 Eli Zaretskii <eliz@gnu.org>
3981
3982 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3983 verifies glyph row's hash code--we have just reallocated the
3984 glyphs, so their contents can be complete garbage. (Bug#10164)
3985
febe6bea
JB
39862011-11-30 Juanma Barranquero <lekktu@gmail.com>
3987
3988 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3989
801a4313
EZ
39902011-11-30 Eli Zaretskii <eliz@gnu.org>
3991
3992 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3993 attributes are tested _before_ calling verify_row_hash, to protect
3994 against GCC re-ordering of the tests. (Bug#10164)
3995
2b56b87e
JD
39962011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3997
3998 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3999
4000 * xterm.c (handle_one_xevent): Only set async_visible and friends
4001 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4002 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4003 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4004
dbf31225
PE
40052011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4006
4007 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4008 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4009 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4010 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4011 All uses changed to use GCPRO1 etc.
4012 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4013 Revert to old implementation (i.e., before 2011-03-11).
4014
1305621b
YM
40152011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4016
4017 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4018 of scroll runs so as to avoid assigning disabled bogus rows and
4019 unnecessary graphics copy operations.
4020
8c9afb46
EZ
40212011-11-27 Eli Zaretskii <eliz@gnu.org>
4022
4023 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4024 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4025 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4026 (malloc, free, realloc, calloc): Redirect to e_* only when
4027 compiling Emacs.
4028
4029 * lisp.h (GCTYPEBITS): Move before first use.
4030 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4031 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4032 this macro definition.
4033
4034 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4035 _MSC_VER.
4036
54e9e3bf
JD
40372011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4038
6d5eb5b0
SM
4039 * gtkutil.c (xg_create_frame_widgets):
4040 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4041 present with Gtk+ 2.0.
4042
83aca1cb
PE
40432011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4044
4045 * fileio.c (Finsert_file_contents): Undo previous change; see
4046 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4047
5b76caa4
PE
40482011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4049
4050 Rename locals to avoid shadowing.
4051 * fileio.c (Finsert_file_contents):
4052 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4053 * process.c (wait_reading_process_output):
4054 Rename inner 'proc' to 'p' to avoid shadowing.
4055 Indent for consistency with usual Emacs style.
4056
8c535114
EZ
40572011-11-25 Eli Zaretskii <eliz@gnu.org>
4058
4059 * xdisp.c (redisplay_window): If cursor row is not fully visible
4060 after recentering, and scroll-conservatively is set to a large
4061 number, scroll window by a few more lines to make the cursor fully
4062 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4063 (start_display): Don't move to the next line if the display should
4064 start at a newline that is part of a display vector or an overlay
4065 string. (Bug#10119)
8c535114 4066
fa4fdb5c
JL
40672011-11-24 Juri Linkov <juri@jurta.org>
4068
4069 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4070 after the `MagickPingImage' call. (Bug#10112)
4071
90ec88df
CY
40722011-11-23 Chong Yidong <cyd@gnu.org>
4073
4074 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4075
56e2e794
MR
40762011-11-23 Martin Rudalics <rudalics@gmx.at>
4077
4078 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4079 making another buffer current. (Bug#10114)
4080
b6e64c41
GM
40812011-11-23 Glenn Morris <rgm@gnu.org>
4082
4083 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4084
6b21de18
CY
40852011-11-23 Chong Yidong <cyd@gnu.org>
4086
4087 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4088 using it (Bug#5984).
4089
b12cd789
EZ
40902011-11-22 Eli Zaretskii <eliz@gnu.org>
4091
4092 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4093 and header-lines, as they don't have one computed for them.
4094 (Bug#10098)
4095
4096 * .gdbinit (prow): Make displayed values more self-explaining.
4097 Add row's hash code.
4098
261b6fd4
LMI
40992011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4100
4101 * process.c (wait_reading_process_output): Fix asynchrounous
4102 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4103 (wait_reading_process_output): Add comment and URL.
261b6fd4 4104
e7cfd277
JD
41052011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4106
4107 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4108
a9b9b7f5
CY
41092011-11-21 Chong Yidong <cyd@gnu.org>
4110
4111 * window.c (Fnext_window, Fprevious_window): Doc fix.
4112
b0d15b4f
SM
41132011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4114
4115 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4116
fe7a3057
JB
41172011-11-20 Juanma Barranquero <lekktu@gmail.com>
4118
4119 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4120
d2999b1a
MR
41212011-11-20 Martin Rudalics <rudalics@gmx.at>
4122
4123 * window.c (Fset_window_combination_limit): Rename argument
4124 STATUS to LIMIT.
4125 (Vwindow_combination_limit): Remove "status" from doc-string.
4126
d5ff9cd0
AS
41272011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4128
4129 * m/ibms390.h: Remove.
4130 * m/ibms390x.h: Don't include "ibms390.h".
4131
a5bb9bd3
SM
41322011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4133
4134 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4135 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4136
cd1181db
JB
41372011-11-20 Juanma Barranquero <lekktu@gmail.com>
4138
4139 * casetab.c (Fset_case_table):
4140 * charset.c (Fcharset_after): Fix typos.
4141
615a3b8d 41422011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4143
17e845af
PE
4144 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4145 Otherwise, valgrind does not work on some platforms.
4146 Problem reported by Andreas Schwab in
6a0bf43d
PE
4147 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4148 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4149 is set, removing the need for VIRT_ADDRESS_VARIES.
4150 (PURE_P): Use a more-efficient implementation that needs just one
4151 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4152 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4153 to 4 (xorl, subq, cmpq, setbe).
4154 * alloc.c (pure): Always extern now, since that's the
4155 VIRT_ADDR_VARIES behavior.
4156 (PURE_POINTER_P): Use a single comparison, not two, for
4157 consistency with the new puresize.h.
4158 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4159 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4160 Remove VIRT_ADDR_VARIES no longer needed.
4161
f8fe6f96
EZ
41622011-11-19 Eli Zaretskii <eliz@gnu.org>
4163
4164 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4165 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4166 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4167 behave as if the cursor position were at the window margin.
4168
4169 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4170 and the cursor position is out of bounds, behave as if the cursor
4171 position were at the window margin. (Bug#10075)
4172
df05a53c
CY
41732011-11-18 Chong Yidong <cyd@gnu.org>
4174
4175 * window.c (Fwindow_combination_limit): Make first argument
4176 non-optional, since it is meaningless for live windows like the
4177 selected window.
61ccba97 4178
2071918e
DA
41792011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4180
4181 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4182
b50a28de
SM
41832011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4184
4185 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4186 (graft_intervals_into_buffer): Simplify.
4187
015137db
EZ
41882011-11-18 Eli Zaretskii <eliz@gnu.org>
4189
4190 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4191 hash values of the two rows.
4192 (copy_row_except_pointers): Preserve the used[] arrays and the
4193 hash values of the two rows. (Bug#10035)
68c95424 4194 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4195
4196 * xdisp.c (row_hash): New function, body extracted from
4197 compute_line_metrics.
4198 (compute_line_metrics): Call row_hash, instead of computing the
4199 hash code inline.
4200
4201 * dispnew.c (verify_row_hash): Call row_hash for computing the
4202 hash code of a row, instead of duplicating code from xdisp.c.
4203
4204 * dispextern.h (row_hash): Add prototype.
4205
a2addb04
TH
42062011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4207
4208 * frame.c (delete_frame): Don't delete the terminal when the last
4209 X frame is closed if emacs is built with GTK toolkit.
4210
df85d315
JB
42112011-11-17 Juanma Barranquero <lekktu@gmail.com>
4212
4213 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4214
a0c2d0ae
MR
42152011-11-17 Martin Rudalics <rudalics@gmx.at>
4216
4217 * window.c (Vwindow_splits): Rename to
4218 Vwindow_combination_resize. Suggested by Juri Linkov.
4219 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4220 of Vwindow_splits.
4221
58179cce
JB
42222011-11-16 Juanma Barranquero <lekktu@gmail.com>
4223
7877f373
JB
4224 * nsfns.m (Fns_font_name):
4225 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4226
b6f67890
MR
42272011-11-16 Martin Rudalics <rudalics@gmx.at>
4228
4229 * window.h (window): Rename slot "nest" to "combination_limit".
4230 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4231 (Fset_window_nest): Rename to Fset_window_combination_limit.
4232 (Vwindow_nest): Rename to Vwindow_combination_limit.
4233 (recombine_windows, make_parent_window, make_window)
4234 (Fsplit_window_internal, saved_window)
4235 (Fset_window_configuration, save_window_save): Rename all
4236 occurrences of window_nest to window_combination_limit.
4237
c7015153
JB
42382011-11-15 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * image.c (imagemagick_load_image): Fix typo.
4241
322ad6ec
EZ
42422011-11-14 Eli Zaretskii <eliz@gnu.org>
4243
4244 * xdisp.c (display_line): Move the call to
4245 highlight_trailing_whitespace before the call to
4246 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4247 faces of all the glyphs to compute ROW's hash value.
4248 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4249
f067b8ec
JB
42502011-11-14 Juanma Barranquero <lekktu@gmail.com>
4251
4252 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4253 just return (bug#10044).
4254
1e5b2111
EZ
42552011-11-12 Eli Zaretskii <eliz@gnu.org>
4256
7ef3cbd5
EZ
4257 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4258 with user-defined heap size. Bump the default size of the temacs
4259 heap to 27MB, to avoid memory warning when running temacs.
4260 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4261
1e5b2111
EZ
4262 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4263 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4264 (verify_row_hash) [XASSERTS]: New function.
4265 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4266 that the hash value of glyph rows is correct.
1e5b2111 4267
89d61221
MR
42682011-11-12 Martin Rudalics <rudalics@gmx.at>
4269
4270 * window.h (window): Remove splits slot.
4271 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4272 (Fdelete_other_windows_internal, make_parent_window)
4273 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4274 (Fset_window_configuration, save_window_save): Don't deal with
4275 split status of windows.
4276 (saved_window): Remove splits slot.
4277 (Vwindow_splits): Rewrite doc-string.
4278
97f18cc8
JD
42792011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4280
4281 * xfns.c (unwind_create_frame):
4282 * nsfns.m (unwind_create_frame):
4283 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4284 Vframe_list (Bug#9999).
4285
22a648b4
DA
42862011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4287
0b381c7e 4288 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4289
659afede
KH
42902011-11-11 Kenichi Handa <handa@m17n.org>
4291
4292 * callproc.c (Fcall_process): Set the member dst_multibyte of
4293 process_coding.
4294
9ac0394b
KH
42952011-11-11 Johan Bockgård <bojohan@gnu.org>
4296
4297 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4298 avoid a crash (bug#9496).
4299
2fbdc249
CY
43002011-11-09 Chong Yidong <cyd@gnu.org>
4301
4302 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4303 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4304
ac6b1f81
PE
43052011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4308
09db192c
PE
43092011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4310
4311 Avoid some portability problems by eschewing 'extern inline' functions.
4312 The trivial performance wins aren't worth the portability hassles; see
4313 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4314 et seq.
4315 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4316 (window_box_width, window_box_left, window_box_left_offset)
4317 (window_box_right, window_box_right_offset): Undo previous change,
4318 by removing the "extern"s.
4319 * intervals.c (adjust_intervals_for_insertion)
4320 (adjust_intervals_for_deletion): Undo previous change,
4321 making these static again.
4322 (offset_intervals, temp_set_point_both, temp_set_point)
4323 (copy_intervals_to_string): No longer inline.
4324 * xdisp.c (window_text_bottom_y, window_box_width)
4325 (window_box_height, window_box_left_offset)
4326 (window_box_right_offset, window_box_left, window_box_right)
4327 (window_box): No longer inline.
4328
105216ed
CY
43292011-11-08 Chong Yidong <cyd@gnu.org>
4330
4331 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4332 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4333 Signal an error if not a live window.
105216ed
CY
4334 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4335 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4336
ae9e237f
JB
43372011-11-07 Juanma Barranquero <lekktu@gmail.com>
4338
4339 * lisp.h (syms_of_abbrev): Remove declaration.
4340 Reported by CHENG Gao <chenggao@royau.me>.
4341
c7aa8333
EZ
43422011-11-07 Eli Zaretskii <eliz@gnu.org>
4343
4344 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4345 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4346 of temacs in GUI mode.
4347
be7f5545
MR
43482011-11-07 Martin Rudalics <rudalics@gmx.at>
4349
4350 * window.h: Declare delete_all_child_windows instead of
4351 delete_all_subwindows.
4352 * window.c (Fwindow_nest, Fset_window_nest)
4353 (Fset_window_new_total, Fset_window_new_normal)
4354 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4355 (delete_all_subwindows): Rename to delete_all_child_windows.
4356 (Fdelete_other_windows_internal, Fset_window_configuration):
4357 Call delete_all_child_windows instead of delete_all_subwindows.
4358 * frame.c (delete_frame): Call delete_all_child_windows instead
4359 of delete_all_subwindows.
4360
ca78dc43
PE
43612011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4362
4363 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4364 This is also needed for porting to any host where GC_MARK_STACK is
4365 not GC_MAKE_GCPROS_NOOPS.
4366 (which_symbols): Use it.
4367
a0241d01
KH
43682011-11-07 Kenichi Handa <handa@m17n.org>
4369
4370 * coding.c (coding_set_destination): Check coding->src_pos only
4371 when coding->src_object is a buffer (bug#9910).
4372
4373 * process.c (send_process): Set the member src_multibyte of coding
4374 to 0 (bug#9911) when sending a unibyte text.
4375
4376 * callproc.c (Fcall_process): Set the member src_multibyte of
4377 process_coding to 0 (bug#9912).
4378
a64bfdfa 43792011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4380
4381 * xmenu.c (cleanup_widget_value_tree): New function.
4382 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4383 calling free_menubar_widget_value_tree directly (Bug#9830).
4384
cb41b32a
PE
43852011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4386
4387 Fix some portability problems with 'inline'.
4388 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4389 (window_box_width, window_box_left, window_box_left_offset)
4390 (window_box_right, window_box_right_offset): Declare extern.
4391 Otherwise, these inline functions do not conform to C99 and
4392 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4393 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4394 * intervals.c (adjust_intervals_for_insertion)
4395 (adjust_intervals_for_deletion): Now extern, because otherwise the
4396 extern inline functions 'offset_intervals' couldn't refer to it.
4397 (static_offset_intervals): Remove.
4398 (offset_intervals): Rewrite using the old contents of
4399 static_offset_intervals. The old version didn't conform to C99
4400 because an extern inline function contained a reference to an
4401 identifier with static linkage.
4402
b7041366
AS
44032011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4404
4405 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4406 GC.
4407
88a37c4d
EZ
44082011-11-06 Eli Zaretskii <eliz@gnu.org>
4409
4410 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4411 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4412 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4413 return Qleft_to_right.
4414
49745b39
CY
44152011-11-06 Chong Yidong <cyd@gnu.org>
4416
4417 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4418 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4419 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4420 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4421 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4422 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4423 (Fwindow_vscroll): Doc fix.
4424 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4425 argument, since it makes no sense to pass a live window and for
4426 consistency with window-child.
4427
1f05cd82
CS
44282011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4429
4430 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4431 support MSVC.
4432
22610910
JR
44332011-11-05 Jason Rumney <jasonr@gnu.org>
4434
4435 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4436 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4437 fonts (Bug#6029).
4438 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4439 bitwise arithmetic preventing use of unicode-sip and non-truetype
4440 opentype fonts.
4441
a06776b2
EZ
44422011-11-05 Eli Zaretskii <eliz@gnu.org>
4443
3ad924ba
EZ
4444 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4445 "emacs"-only part.
4446
a06776b2
EZ
4447 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4448 initialization code to keep similarity to xfns.c after changes
4449 from 2011-11-05.
4450
c9e7db78
JD
44512011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4452
a97f8f3f
JD
4453 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4454 (unwind_create_frame): New function (Bug#9943).
4455 (Fx_create_frame): Restructure code to be more similar to the one in
4456 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4457 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4458 Move terminal->reference_count++ just before making the frame official
4459 (Bug#9943).
4460
4461 * nsterm.m (x_free_frame_resources): New function.
4462 (x_destroy_window): Move code to x_free_frame_resources.
4463
c9e7db78 4464 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4465 (Fx_create_frame, x_create_tip_frame):
4466 Move terminal->reference_count++ just before making the frame
75f1671a 4467 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4468 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4469
a6fc3b5c
EZ
44702011-11-05 Eli Zaretskii <eliz@gnu.org>
4471
4472 Support MSVC build with newer versions of Visual Studio.
4473 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4474 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4475 nt/gmake.defs.
4476
4477 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4478 which are not supported by MSVC.
4479 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4480 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4481 bitfields.
4482 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4483 types in bitfields.
4484 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4485
4486 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4487
58179cce 44882011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4489
4490 Support MSVC build with newer versions of Visual Studio.
4491 * w32.c: Don't include w32api.h for MSVC.
4492 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4493
4494 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4495 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4496 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4497 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4498 e_* cousins.
4499 (alloca) [_MSC_VER]: Define to _alloca.
4500
4501 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4502
4503 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4504
a58c13ed
EZ
45052011-11-04 Eli Zaretskii <eliz@gnu.org>
4506
4507 * xdisp.c (note_mouse_highlight): If either of
4508 previous/next-single-property-change returns nil, treat that as
4509 the beginning or the end of the buffer. (Bug#9955)
4510
fe0b6370
JD
45112011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4512
a58c13ed 4513 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4514 label is not null (Bug#9951).
4515 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4516 may be NULL.
4517
89bd5ee1
EZ
45182011-11-04 Eli Zaretskii <eliz@gnu.org>
4519
4520 * window.c (Fwindow_body_size): Mention in the doc string that the
4521 return value is in frame's canonical units. (Bug#9949)
4522
84c3edb9
EZ
45232011-11-03 Eli Zaretskii <eliz@gnu.org>
4524
4e2fb5c7
EZ
4525 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4526
84c3edb9 4527 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4528 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4529 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4530
bc17a887
EZ
45312011-11-01 Eli Zaretskii <eliz@gnu.org>
4532
4533 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4534 Don't stop backward scan on the continuation glyph, even though
4535 its CHARPOS is positive.
6d5eb5b0
SM
4536 (mouse_face_from_buffer_pos, note_mouse_highlight):
4537 Rename cover_string to disp_string.
bc17a887 4538
4ee88440
MR
45392011-11-01 Martin Rudalics <rudalics@gmx.at>
4540
4541 * window.c (temp_output_buffer_show): Don't use
4542 Vtemp_buffer_show_specifiers.
4543 (Vtemp_buffer_show_specifiers): Remove unused variable.
4544
c2ff3c02
EZ
45452011-10-30 Eli Zaretskii <eliz@gnu.org>
4546
4547 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4548 past the beginning of the current glyph matrix.
4549
58179cce 45502011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4551
4552 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4553 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4554 HAVE_GTK3 (Bug#9869).
b77a6a7f 4555
3b574623
JD
4556 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4557 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4558
b77a6a7f
JD
4559 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4560
4561 * xterm.c: Declare x_handle_net_wm_state to return int.
4562 (handle_one_xevent): Check if we are iconified but don't have
4563 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4564 (get_current_wm_state): Return non-zero if not hidden,
4565 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4566 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4567 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4568 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4569
196e41e4
PE
45702011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4571
4572 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4573 so that this new function doesn't get optimized away by a
4574 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4575
021f2e1a
AS
45762011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4577
4578 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4579
8b058d44
EZ
45802011-10-29 Eli Zaretskii <eliz@gnu.org>
4581
4582 Fix the `xbytecode' command.
4583 * .gdbinit (xprintbytestr): New command.
b50a28de 4584 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4585 (xbytecode): Print the byte-code string as well.
4586
4452fb80
EZ
45872011-10-29 Kim Storm <storm@cua.dk>
4588
8b058d44
EZ
4589 * alloc.c (which_symbols): New function.
4590
21b72067
AS
45912011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4592
4593 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4594 line. (Bug#9903)
4595
83ed7b5c
GM
45962011-10-29 Glenn Morris <rgm@gnu.org>
4597
4598 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4599 Not clear what it was for, and it causes various bugs. (Bug#9839)
4600
5a7a728b
EZ
46012011-10-28 Eli Zaretskii <eliz@gnu.org>
4602
4603 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4604 possible random value that matches one of those tested as
4605 condition to clear the mouse face.
4606
d3d0842f
CY
46072011-10-28 Chong Yidong <cyd@gnu.org>
4608
4609 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4610
31b39d13
DN
46112011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4612
4613 * window.c (make_window): Initialize phys_cursor_on_p.
4614
9aba6043
SM
46152011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4616
4617 * lisp.h (struct Lisp_Symbol): Update comments.
4618
c20992f4
JB
46192011-10-28 Juanma Barranquero <lekktu@gmail.com>
4620
4621 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4622
db4f02f2
EZ
46232011-10-28 Eli Zaretskii <eliz@gnu.org>
4624
4625 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4626 <oslsachem@gmail.com> for helping to debug this.
4627
4628 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4629 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4630 (g_b_init_get_glyph_outline_w): New static variables.
4631 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4632 (GetGlyphOutlineW_Proc): New typedefs.
4633 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4634 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4635 New functions.
4636 (w32font_open_internal, compute_metrics):
4637 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4638 instead of calling the "wide" APIs directly.
4639
4640 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4641
4642 * w32.h (syms_of_w32font): Add prototype.
4643
87e68db4
JB
46442011-10-27 Juanma Barranquero <lekktu@gmail.com>
4645
4646 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4647 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4648 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4649 (Fmove_to_window_line): Doc fix.
4650
435c1d67
CY
46512011-10-27 Chong Yidong <cyd@gnu.org>
4652
4653 * process.c (make_process): Set gnutls_state to NULL.
4654
4655 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4656 non-NULL, regardless of GNUTLS_INITSTAGE.
4657 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4658 an error. Set process slots as soon as we allocate them.
4659
4660 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4661
9c6c6f49
CY
46622011-10-27 Chong Yidong <cyd@gnu.org>
4663
9aba6043
SM
4664 * gnutls.c (emacs_gnutls_deinit): New function.
4665 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4666 (Fgnutls_deinit, Fgnutls_boot): Use it.
4667
4668 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4669 (deactivate_process): Call emacs_gnutls_deinit.
4670
657d08d3
JB
46712011-10-27 Juanma Barranquero <lekktu@gmail.com>
4672
4673 * image.c (x_create_x_image_and_pixmap):
4674 * w32.c (sys_rename, w32_delayed_load):
4675 * w32font.c (fill_in_logfont):
4676 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4677
5430d399
JB
46782011-10-26 Juanma Barranquero <lekktu@gmail.com>
4679
4680 * w32fns.c (w32_default_color_map): New function,
4681 extracted from Fw32_default_color_map.
a7ef684b 4682 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4683
fe0055fa
PE
46842011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4685
4686 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4687
e6346438
SM
46882011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4689
4690 * keyboard.c (test_undefined): New function (bug#9751).
4691 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4692
e112cc37
ET
46932011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4694
4695 * sysdep.c (init_sys_modes): Fix the check for the controlling
4696 terminal (Bug#6649).
4697
7b5d6677
EZ
46982011-10-20 Eli Zaretskii <eliz@gnu.org>
4699
4700 * dispextern.h (struct bidi_it): New member next_en_type.
4701
4702 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4703 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4704 current character, check also for next_en_type being WEAK_EN.
4705 (bidi_resolve_weak): Don't enter the expensive loop if the current
4706 position is before next_en_pos. Record the bidi type of the first
4707 non-ET, non-BN character we find, in addition to its position.
4708 (bidi_level_of_next_char): Invalidate next_en_type when
4709 next_en_pos is over-stepped.
4710
7da0b018
PE
47112011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4712
4713 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4714 * editfns.c: Rewrite current-time-zone so that it invokes
4715 the equivalent of (format-time-string "%Z") to get the time zone name.
4716 This fixes a bug when the time zone name contains characters that
4717 need converting from the system time locale to Emacs internal format.
4718 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4719 that patch fixed format-time-string to do the conversion, but
4720 I forgot to fix current-time-zone.
4721 (format_time_string): New function, containing most of
4722 what Fformat_time_string used to contain.
4723 (Fformat_time_string): Rewrite in terms of format_time_string.
4724 This doesn't change this function's behavior.
4725 (current-time-zone): Rewrite to use format_time_string.
4726 This fixes the bug reported by Michael Schierl in
4727 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4728 Jason Rumney's 2007-06-07 change worked around this bug, but
4729 didn't fix it.
4730 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4731
8547b010
EZ
47322011-10-19 Eli Zaretskii <eliz@gnu.org>
4733
4734 * xdisp.c (start_display): If the character at POS is displayed
4735 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4736 (try_window_reusing_current_matrix): If a line ends in a display
4737 vector or the next line starts in a display vector, continue
4738 redrawing the window even though the character position of
4739 start_row was reached.
8547b010
EZ
4740 (Bug#9771, part 2)
4741
4e948d15
CY
47422011-10-18 Chong Yidong <cyd@gnu.org>
4743
4744 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4745 with nobreak-char-display too.
4746
4787455f
EZ
47472011-10-18 Eli Zaretskii <eliz@gnu.org>
4748
4749 Fix part 3 of bug#9771.
4750 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4751 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4752 non-neutral characters if the current character is a paragraph
4753 separator (a.k.a. Newline). This avoids running the same
4754 expensive loop twice, once when we consume the preceding newline
4755 and the other time when the line actually needs to be displayed.
4756 Avoid the loop when we see neutrals on the base embedding level
4757 following a character whose directionality is the same as the
4758 paragraph's. This avoids running the expensive loop when a line
4759 ends in a long sequence of neutrals, like control characters.
4760 Add assertion against STRONG_AL type. Slightly rearrange code
4761 that determines the type of a neutral given the first non-neutral
4762 that follows it.
4763 (bidi_level_of_next_char): Set next_en_pos to zero when
4764 invalidating its info.
4765
2c91f553
EZ
47662011-10-17 Eli Zaretskii <eliz@gnu.org>
4767
4768 * xdisp.c (push_display_prop): Determine whether to record string
4769 or buffer position by IT->string, not by IT->method. Allow
4770 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4771 (move_it_vertically_backward): Don't look for character position
4772 immediately after the newline when in a continuation line.
4773 (Bug#9771, part 1)
2c91f553 4774
c7b08b0d
MR
47752011-10-15 Martin Rudalics <rudalics@gmx.at>
4776
4777 * window.c (coordinates_in_window): Rewrite and delabelize
4778 vertical border check. (Bug#5357) (Bug#9618)
4779
6b02f655
SM
47802011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4781
4782 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4783 errors in XSetWindowBorder (bug#9310).
4784
81d40c92
DA
47852011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4786
4787 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4788 avoid crash when xmalloc overrun checking is enabled.
4789
d4172c3b
EZ
47902011-10-13 Eli Zaretskii <eliz@gnu.org>
4791
4792 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4793 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4794 cursor motion with <left> and <right> arrow keys.
4795
4796 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4797 some callers set that themselves.
4798
b00eea75
EZ
47992011-10-12 Eli Zaretskii <eliz@gnu.org>
4800
4801 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4802 display string and the previous row comes from the same string and
4803 is empty. (Bug#9739) (Bug#9738)
4804
8fe012c4
SM
48052011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4806
4807 * doc.c (get_doc_string): Encode file name (bug#9735).
4808
0074aef2
EZ
48092011-10-12 Eli Zaretskii <eliz@gnu.org>
4810
79beb178
EZ
4811 * bidi.c (bidi_level_of_next_char):
4812 * xdisp.c (get_visually_first_element): Remove old incorrect
4813 comments regarding the Unicode Line Separator character.
4814
0074aef2
EZ
4815 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4816
6e4b3fbe
DA
48172011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4818
4819 * alloc.c (Fgc_status): Do not access beyond zombies array
4820 boundary if nzombies > MAX_ZOMBIES.
4821 * alloc.c (dump_zombies): Add missing format specifier.
4822
0324f3af
PE
48232011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4824
b5525cac
PE
4825 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4826 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4827
0324f3af
PE
4828 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4829 Some packages use them to denote characters with modifiers.
4830
e9b5f888
AS
48312011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4832
4833 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4834 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4835 matching a pp-number. Rename parameter var to var1.
4836
127827c0
SM
48372011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4838
4839 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4840
c8fd3bd0
GM
48412011-10-08 Glenn Morris <rgm@gnu.org>
4842
4843 * callint.c (Fcall_interactively): Give a more explicit error for the
4844 'c' case with a non-character input. (Bug#8479)
4845
352ec8ff
EZ
48462011-10-08 Eli Zaretskii <eliz@gnu.org>
4847
03669ccb
EZ
4848 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4849 lines.
7061c986
EZ
4850 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4851 lines that are hscrolled on the left.
03669ccb 4852
352ec8ff
EZ
4853 * dispnew.c (buffer_posn_from_coords): Account for a possible
4854 presence of header-line. (Bug#4426)
4855
a66cfb1c
SM
48562011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4857
6b02f655
SM
4858 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4859 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4860
7c5ee88e
PE
48612011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4862
4863 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4864 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4865 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4866 this makes Emacs dump core during garbage collection on rare
4867 occasions. sizeof is obviously inferior to offsetof here, so
4868 stick with offsetof.
4869 (GC_POINTER_ALIGNMENT): New macro.
4870 (mark_memory): Omit 3rd (offset) arg; caller changed.
4871 Don't assume EMACS_INT alignment is the same as pointer alignment.
4872
df1bbe5b
SM
48732011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4874
4875 * keyboard.c (read_key_sequence_remapped): New var.
4876 (read_key_sequence): Compute remapping in the right buffer.
4877 (command_loop_1): Use read_key_sequence's remapping directly.
4878
51553db6
SM
48792011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4880
32c1fffd
SM
4881 * dired.c (file_name_completion): Don't expand file name.
4882 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4883 before checking file name handler.
4884
51553db6
SM
4885 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4886 they've been requested explicitly (bug#9591).
4887
b6bd1599 48882011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4889
4890 * keymap.c (Fsingle_key_description): Use make_specified_string
4891 instead of build_string to build string from push_key_description.
4892 (Bug#5193)
4893
f701dc2a
PE
48942011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4895
4222c55d
PE
4896 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4897 This fixes a Y2038 bug on 64-bit hosts.
4898 * buffer.c (reset_buffer):
4899 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4900 (Fclear_buffer_auto_save_failure):
4901 Use 0, not -1, to represent an unset failure time, since time_t
4902 might not be signed.
4903
f701dc2a
PE
4904 Remove dependency on glibc malloc internals.
4905 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4906 Move back here from lisp.h, but with their new implementations.
4907 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4908 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4909 * charset.c (charset_table_init): New static var.
4910 (syms_of_charset): Use it instead of xmalloc. This removes a
4911 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4912 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4913 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4914 Move back to alloc.c.
4915 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4916 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4917
9ceebf39
JD
49182011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4919
4920 * nsterm.m (windowDidResize): Call x_set_window_size only when
4921 ns_in_resize is true. Otherwise set pixelwidth/height and
4922 call change_frame_size (Bug#9628).
4923
cb993c58
PE
49242011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4925
3930c88b
PE
4926 Port --enable-checking=all to Fedora 14 x86-64.
4927 * charset.c (syms_of_charset): Also account for glibc malloc's
4928 internal overhead when calculating the initial malloc maximum.
4929
cb993c58
PE
4930 Port --enable-checking=all to Fedora 14 x86.
4931 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4932 Move to lisp.h.
4933 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4934 (overrun_check_realloc, overrun_check_free):
4935 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4936 That way, xmalloc returns a properly-aligned pointer even if
4937 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4938 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4939 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4940 into account when calculating the initial malloc maximum.
4941 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4942 Move here from alloc.c, so that charset.c can use it too.
4943 Properly align; the old code wasn't right for common 32-bit hosts
4944 when configured with --enable-checking=all.
4945 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4946 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4947
31bed486
EZ
49482011-09-29 Eli Zaretskii <eliz@gnu.org>
4949
04c70788 4950 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4951 use EDOM.
4952
fbcaa2f3
EZ
49532011-09-28 Eli Zaretskii <eliz@gnu.org>
4954
4955 * xdisp.c (compute_display_string_end): If there's no display
4956 string at CHARPOS, return -1.
4957
4958 * bidi.c (bidi_fetch_char): When compute_display_string_end
4959 returns a negative value, treat the character as a normal
4960 character not covered by a display string. (Bug#9624)
4961
a239d4e9
JB
49622011-09-28 Juanma Barranquero <lekktu@gmail.com>
4963
4964 * lread.c (Fread_from_string): Fix typo in docstring.
4965
88652fd5
EZ
49662011-09-27 Eli Zaretskii <eliz@gnu.org>
4967
4968 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4969 newline, reseat the iterator instead of bidi-iterating there one
4970 character at a time. (Bug#9610)
32c1fffd
SM
4971 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4972 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4973
ed497dd4
AS
49742011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4975
4976 * lread.c (readevalloop): Use correct code for NBSP.
4977 (read1): Likewise. (Bug#9608)
4978
b2bf61aa
MA
49792011-09-25 Michael Albinus <michael.albinus@gmx.de>
4980
4981 * dbusbind.c (Fdbus_register_signal): When service is not
4982 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4983
32bbb17c
GM
49842011-09-25 Glenn Morris <rgm@gnu.org>
4985
4986 * buffer.c (truncate-lines): Doc fix.
4987
94e0933e
CY
49882011-09-24 Chong Yidong <cyd@stupidchicken.com>
4989
4990 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4991 (Fset_window_next_buffers): Doc fix.
4992
cddde921
GM
49932011-09-24 Glenn Morris <rgm@gnu.org>
4994
4995 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4996
1260aef1
PE
49972011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4998
25b4bfa0
PE
4999 Fix minor problems found by static checking.
5000 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5001 * indent.c (Fvertical_motion): Fix == vs = typo.
5002
e3cbd34b
EZ
50032011-09-24 Eli Zaretskii <eliz@gnu.org>
5004
a66cfb1c
SM
5005 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5006 Default value is now t. Doc fix.
6bf7006f 5007
e3cbd34b 5008 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5009 logic when moving up, not only when moving down. Fix the
e3cbd34b 5010 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5011 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5012
5013 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5014 CHARPOS is covered by a display string which includes newlines.
5015 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5016 is covered by a display string with embedded newlines.
5017
a3de0cbd
MA
50182011-09-24 Michael Albinus <michael.albinus@gmx.de>
5019
5020 * dbusbind.c (Fdbus_register_signal): Add match rule to
5021 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5022 (Fdbus_register_method, Vdbus_registered_objects_table):
5023 Fix docstring.
a3de0cbd 5024
b260039d
JM
50252011-09-24 Jim Meyering <meyering@redhat.com>
5026
32c1fffd 5027 do not ignore write error for any output size
b260039d
JM
5028 The previous change was incomplete.
5029 While it makes emacs --batch detect the vast majority of stdout
5030 write failures, errors were still ignored whenever the output size is
5031 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5032 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5033 && echo FAIL: ignored write error
5034 FAIL: ignored write error
5035 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5036 && echo FAIL: ignored write error
5037 FAIL: ignored write error
5038 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5039
8eca8a7c
AS
50402011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5041
5042 * emacs.c (Fkill_emacs): In noninteractive mode exit
5043 non-successfully if a write error occurred on stdout. (Bug#9574)
5044
3341db62
EZ
50452011-09-21 Eli Zaretskii <eliz@gnu.org>
5046
5047 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5048 the xassert test.
5049
5050 * dispextern.h (struct it): Update the comment documenting what
5051 can it->OBJECT be.
5052
8c203dbf
EZ
50532011-09-20 Eli Zaretskii <eliz@gnu.org>
5054
5055 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5056 a display string, extend search for cursor position to end of row.
5057 (find_row_edges): If the row ends in a newline from a display
5058 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5059 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5060 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5061 non-empty line. Fixes confusing cursor motion with arrow keys at
5062 the beginning of a line that starts with whitespace.
8c203dbf 5063
a4824228
LMI
50642011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5065
5066 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5067 (bug#9493).
5068
33ed493b
CY
50692011-09-18 Chong Yidong <cyd@stupidchicken.com>
5070
5071 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5072 boolean (Bug#9154).
5073
56cd55c8
EZ
50742011-09-18 Eli Zaretskii <eliz@gnu.org>
5075
5076 * xdisp.c (display_line): Record maximum and minimum buffer
5077 positions even if no glyphs were produced (e.g., by a zero-width
5078 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5079 buffer positions that will be removed from the glyph row because
5080 they don't fit.
c02dcedf
EZ
5081 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5082 column is beyond frame width: don't subtract 1 "pixel" when
5083 computing width of the stretch.
3e62b7e0
EZ
5084 (reseat_at_next_visible_line_start): Undo the change made on
5085 2011-09-17 that saved paragraph information and restored it after
5086 the call to `reseat'. (Bug#9545)
56cd55c8 5087
5ed99d36 50882011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5089
5090 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5091 and turn window cursor on if cleared (Bug#9415).
5092
5ed99d36 50932011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5094
5095 * search.c (boyer_moore): Take unibyte characters from pattern
5096 literally. (Bug#9458)
5097
9bade7b2
EZ
50982011-09-18 Eli Zaretskii <eliz@gnu.org>
5099
5100 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5101
e5e9d610
PE
51022011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5103
87e4427a
PE
5104 Fix minor problem found by static checking.
5105 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5106 initialized, to pacify gcc -Wuninitialized.
5107
e5e9d610
PE
5108 * fileio.c: Report proper errno when syscall falls.
5109 (Finsert_file_contents): Save and restore errno,
5110 so that report_file_error outputs the correct diagnostic.
5111 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5112
a1674f0b
EZ
51132011-09-18 Eli Zaretskii <eliz@gnu.org>
5114
5115 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5116
fbfb6dd4
EZ
51172011-09-17 Eli Zaretskii <eliz@gnu.org>
5118
5119 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5120 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5121
bb187662
EZ
51222011-09-17 Eli Zaretskii <eliz@gnu.org>
5123
1137e8b8 5124 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5125 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5126
5127 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5128 (bidi_find_paragraph_start): Search back for paragraph beginning
5129 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5130 (bidi_move_to_visually_next): Only trigger paragraph-related
5131 computations when the last character is a newline or at EOB, not
5132 just any NEUTRAL_B. (Bug#9470)
5133
bb187662
EZ
5134 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5135 truncated lines if point is covered by a display string. (Bug#9524)
5136
2e621251
PE
51372011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5138
5139 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5140 (cons_to_x_long): New function.
5141 (lisp_data_to_selection_data): Use it. Correct the test for
5142 short-versus-long data; it was negated. Break out of vector
5143 loop, for efficiency, when a long datum is discovered.
5144
91a15bc6
SM
51452011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5146
5147 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5148
b41c3a35
EZ
51492011-09-16 Eli Zaretskii <eliz@gnu.org>
5150
5151 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5152 GCC PR/17406) by declaring this function with external scope.
5153
7812ba2d
PE
51542011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5155
5156 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5157 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5158
cf7edc2a
AS
51592011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5160
5161 * editfns.c (Fformat): Correctly handle text properties on "%%".
5162
bd01620e
EZ
51632011-09-15 Eli Zaretskii <eliz@gnu.org>
5164
5165 * xterm.c (x_draw_composite_glyph_string_foreground):
5166 * w32term.c (x_draw_composite_glyph_string_foreground):
5167 * term.c (encode_terminal_code):
5168 * composite.c (composition_update_it, get_composition_id):
5169 * xdisp.c (get_next_display_element)
5170 (fill_composite_glyph_string): Add comments about special meaning
5171 of TAB characters in a composition.
5172
a02719a3
PE
51732011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5174
5175 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5176 This occurs when processing a multibyte format.
5177 Problem reported by Wolfgang Jenker.
a02719a3 5178
72589a3c
JB
51792011-09-15 Johan Bockgård <bojohan@gnu.org>
5180
5181 * xdisp.c (try_cursor_movement): Only check for exact match if
5182 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5183
1c14176c
PE
51842011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5185
5186 Remove unused external symbols.
5187 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5188 * xdisp.c (calc_pixel_width_or_height): Now static.
5189 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5190 * indent.c (check_display_width):
5191 * w32term.c: Fix comment to match code.
5192 * xterm.c, xterm.h (x_catching_errors): Remove.
5193
d2eea5b5
PE
51942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5195
5196 * xselect.c: Use signed conversions more consistently (Bug#9498).
5197 (selection_data_to_lisp_data): Assume incoming selection data are
5198 signed integers, not unsigned. This is to be consistent with
5199 outgoing selection data, which was modified to use signed integers
5200 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5201 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5202 expects long, not unsigned long.
5203
46888499
EZ
52042011-09-14 Eli Zaretskii <eliz@gnu.org>
5205
5206 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5207 computation of loop end. Reported by Johan Bockgård
5208 <bojohan@gnu.org>.
5209
ef8ef9fb
CY
52102011-09-13 Chong Yidong <cyd@stupidchicken.com>
5211
5212 * frame.c (Fother_visible_frames_p): Function deleted.
5213
fa819fed
EZ
52142011-09-12 Eli Zaretskii <eliz@gnu.org>
5215
5216 * indent.c (compute_motion): Process display vector front to back
5217 rather than the other way around. (Bug#2496)
5218
2ba8e008
SM
52192011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5220
5221 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5222
20f53c69
CY
52232011-09-11 Chong Yidong <cyd@stupidchicken.com>
5224
5225 * minibuf.c (Fread_from_minibuffer): Doc fix.
5226
d562d7a4
EZ
52272011-09-11 Eli Zaretskii <eliz@gnu.org>
5228
5229 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5230 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5231
1c4d7f3d
LMI
52322011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5233
5234 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5235 value for non-existent files.
5236
b885bf36
EZ
52372011-09-11 Eli Zaretskii <eliz@gnu.org>
5238
5239 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5240 set its "size" to -1. This will set the modtime_size field of
5241 the corresponding buffer to -1, which is what
5242 verify-visited-file-modtime expects for files that do not exist.
5243 (Bug#9139)
5244
6612f0bf
PE
52452011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5248 here ...
5249 * lisp.h: ... from here. push_key_description is no longer
5250 defined in keyboard.c, so its declaration should not be in
5251 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5252 logically belongs with push_key_description.
5253
dfb3f755
PE
52542011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5255
5256 * buffer.h: Include <sys/types.h> instead of <time.h>.
5257 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5258 Problem reported by Herbert J. Skuhra.
5259
3134906c
LMI
52602011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5261
5262 * xml.c (parse_region): Make the parsing work for
5263 non-comment-starting XML files again (bug#9144).
5264
8d903f4e
AS
52652011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5266
5267 * image.c (gif_load): Fix calculation of bottom and right corner.
5268 (Bug#9468)
5269
80ad64f4
EZ
52702011-09-10 Eli Zaretskii <eliz@gnu.org>
5271
5272 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5273 redisplay in small windows.
5274
208a048d
EZ
52752011-09-09 Eli Zaretskii <eliz@gnu.org>
5276
5277 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5278
9b1c252e
MR
52792011-09-08 Martin Rudalics <rudalics@gmx.at>
5280
5281 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5282 Operate on live windows only.
5283
2949f33b
JB
52842011-09-08 Juanma Barranquero <lekktu@gmail.com>
5285
5286 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5287
e08dcafd
EZ
52882011-09-07 Eli Zaretskii <eliz@gnu.org>
5289
5290 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5291 only under bidi iteration.
5292
115b96bd
JD
52932011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5294
5295 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5296
c8199d0f
PE
52972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5298
5299 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5300 Without this fix, the command to link temacs failed due to an
5301 undefined symbol __builtin_isnan. This is because
5302 /usr/include/iso/math_c99.h #defines isnan(x) to
5303 __builtin_isnan(x), but the bundled gcc, which identifies itself
5304 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5305 a __builtin_isnan.
5306 * floatfns.c (isnan): #undef, and then #define to a clone of
5307 what's in data.c.
5308 (Fisnan): Always define, since it's always available now.
5309 (syms_of_floatfns): Always define isnan at the Lisp level.
5310
e39b275c 53112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5312
5313 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5314
b2db44d9 53152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5316
f4af5137 5317 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5318 The previous code assumed that file offsets (off_t values) fit in
5319 EMACS_INT variables, which is not true on typical 32-bit hosts.
5320 The code messed up by falsely reporting buffer overflow in cases
5321 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5322 when "big" contains more than 2**29 bytes, even though this
5323 inserts just one byte and does not overflow the buffer.
5324 (Finsert_file_contents): Store file offsets as off_t
5325 values, not as EMACS_INT values. Check for overflow when
5326 converting between EMACS_INT and off_t. When checking for
5327 buffer overflow or for overlap, take the offsets into account.
5328 Don't use EMACS_INT for small values where int suffices.
5329 When checking for overlap, fix a typo: ZV was used where
5330 ZV_BYTE was intended.
5331 (Fwrite_region): Don't assume off_t fits into 'long'.
5332 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5333
ecfc0a49
MA
53342011-09-05 Michael Albinus <michael.albinus@gmx.de>
5335
5336 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5337
6511acf2 53382011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5339
0999621a 5340 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5341
5342 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5343 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5344 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5345 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5346 (modify_event_symbol): Do not assume that the length of
5347 name_alist_or_stem is safe to alloca and fits in int.
5348 (Fexecute_extended_command): Likewise for function name and binding.
5349 (Frecursion_depth): Wrap around reliably on integer overflow.
5350 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5351 since some callers pass EMACS_INT values.
5352 (Fsingle_key_description): Don't crash if symbol name contains more
5353 than MAX_ALLOCA bytes.
5354 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5355 (get_minibuffer): Arg is now EMACS_INT, not int.
5356 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5357 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5358 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5359
2be7d702
PE
5360 * dbusbind.c (signature_cat): New function.
5361 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5362 Do not overrun buffer; instead, report string overflow.
5363
9d1df220
PE
5364 * dispnew.c (add_window_display_history): Don't overrun buffer.
5365 Truncate instead; this is OK since it's just a log.
5366
33ef5c64
PE
5367 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5368 even if the time zone offset is outlandishly large.
5369 Don't mishandle offset == INT_MIN.
5370
66c6fdd5
PE
5371 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5372 when creating daemon; the previous buffer-overflow check was incorrect.
5373
d749b01b
PE
5374 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5375 which has the guts of the old verror function.
5376
b5cd1905
PE
5377 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5378 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5379
6e1a67fb
PE
5380 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5381 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5382 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5383 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5384 length of string rather than counting it via multiple sprintfs;
5385 that's simpler and more reliable.
c21721cc
PE
5386 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5387 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5388 sprintf, in case result does not fit in int.
5389
c57b67fc
PE
5390 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5391 (fontset_from_font): Print it.
5392
8a401434
PE
5393 * frame.c (tty_frame_count): Now printmax_t, not int.
5394 (make_terminal_frame, set_term_frame_name): Print it.
5395 (x_report_frame_params): In X, window IDs are unsigned long,
5396 not signed long, so print them as unsigned.
5397 (validate_x_resource_name): Check for implausibly long names,
5398 and don't assume name length fits in 'int'.
5399 (x_get_resource_string): Don't blindly alloca invocation name;
5400 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5401 not fit in int.
5402
6e1a67fb
PE
5403 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5404 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5405 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5406
0df02bf3
PE
5407 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5408 Use esprintf, not sprintf, in case result does not fit in int.
5409
48e30793
PE
5410 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5411 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5412 it as a large positive number.
5413 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5414 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5415
a66ff6d8
PE
5416 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5417 in case result does not fit in int.
5418
aca216ff
PE
5419 * print.c (float_to_string): Detect width overflow more reliably.
5420 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5421 buffer overrun. Don't assume list length fits in 'int'. Treat
5422 print length of 0 as 0, not as infinity; to be consistent with other
5423 uses of print length in this function. Don't overflow print length
5424 index. Don't assume hash table size fits in 'long', or that
5425 vectorlike size fits in 'unsigned long'.
5426
31c286f7
PE
5427 * process.c (make_process): Use printmax_t, not int, to format
5428 process-name gensyms.
5429
55e5faa1
PE
5430 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5431
80f2e268
PE
5432 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5433 to avoid potential buffer overrun.
5434
670741ab
PE
5435 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5436 if X resource line is longer than 512 bytes.
5437
b7163a50
PE
5438 * xfns.c (x_window): Make sprintf buffer a bit bigger
5439 to avoid potential buffer overrun.
5440
ae58ff1f
PE
5441 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5442
c43c8a6a
PE
5443 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5444
3f8236f4
PE
54452011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5446
53e9fe90 5447 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5448 Without these, Emacs silently mishandles large integers sometimes.
5449 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5450 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5451
6511acf2
PE
5452 * xdisp.c (try_window_id): Check Emacs fixnum range before
5453 converting to 'int'.
806add1d 5454
6511acf2 5455 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5456 Check that an Emacs fixnum is in range before assigning it to 'int'.
5457 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5458 values converted from Emacs fixnums.
5459 (Frecenter): Don't wrap around a line count if it is out of 'int'
5460 range; instead, treat it as an extreme value.
5461 (Fset_window_configuration, compare_window_configurations):
5462 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5463
6511acf2
PE
5464 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5465 that can exceed INT_MAX. Check that EMACS_INT value is in range
5466 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5467 (match_limit): Don't assume that a fixnum can fit in 'int'.
5468
6511acf2 5469 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5470 exceed INT_MAX.
5471
6511acf2 5472 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5473 (Fvertical_motion): Don't wrap around LINES values that don't fit
5474 in 'int'. Instead, treat them as extreme values. This is good
5475 enough for windows, which can't have more than INT_MAX lines anyway.
5476
fcb901a7
LMI
54772011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5478
0f2f6b6d
LMI
5479 * Require libxml/parser.h to avoid compilation warning.
5480
fcb901a7
LMI
5481 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5482
5483 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5484 since this reportedly can destroy thread storage.
5485
6e20a0d4
CY
54862011-08-30 Chong Yidong <cyd@stupidchicken.com>
5487
5488 * syntax.c (find_defun_start): Update all cache variables if
5489 exiting early (Bug#9401).
5490
148ae00e
EZ
54912011-08-30 Eli Zaretskii <eliz@gnu.org>
5492
f6cfbd8f
EZ
5493 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5494
148ae00e
EZ
5495 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5496 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5497 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5498
5499 * term.c (tty_append_glyph): New function.
5500 (produce_stretch_glyph): Static function and its prototype deleted.
5501
a66cfb1c
SM
5502 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5503 Add prototypes.
148ae00e 5504
c4a07a4c
PE
55052011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5506
5507 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5508 when checking :margin (Bug#9390).
5509 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5510 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5511 so that the name doesn't mislead. All uses changed.
5512
6bc8cd65
JB
55132011-08-28 Johan Bockgård <bojohan@gnu.org>
5514
5515 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5516 set_tty_hooks.
5517
dca4927e
EZ
55182011-08-27 Eli Zaretskii <eliz@gnu.org>
5519
5520 * xdisp.c (move_it_to): Don't bail out early when reaching
5521 position beyond to_charpos, if we are scanning backwards.
5522 (move_it_vertically_backward): When DY == 0, make sure we get to
5523 the first character in the line after the newline.
5524
f2cad773
PE
55252011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5526
5527 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5528 (ccl_driver): Do not generate an out-of-range pointer.
5529 (Fccl_execute_on_string): Remove unnecessary check for
5530 integer overflow, noted by Stefan Monnier in
5531 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5532 Remove a FIXME that didn't need fixing.
5533 Simplify the newly-introduced buffer reallocation code.
5534
0cae2cdb
JB
55352011-08-27 Juanma Barranquero <lekktu@gmail.com>
5536
5537 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5538
5fc295a4 55392011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5540
70c60eb2 5541 Integer and memory overflow issues (Bug#9196).
726e0ab1 5542
d31850da
PE
5543 * doc.c (get_doc_string): Rework so that
5544 get_doc_string_buffer_size is the actual buffer size, rather than
5545 being 1 less than the actual buffer size; this makes xpalloc more
5546 convenient.
5547
a69fbedb
PE
5548 * image.c (x_allocate_bitmap_record, cache_image):
5549 * xselect.c (Fx_register_dnd_atom):
5550 Simplify previous changes by using xpalloc.
5551
fe5c5d37
PE
5552 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5553 since either will do and ptrdiff_t is convenient with xpalloc.
5554
0065d054
PE
5555 * charset.c (charset_table_size)
5556 (struct charset_sort_data.priority): Now ptrdiff_t.
5557 (charset_compare): Don't overflow if priorities differ greatly.
5558 (Fsort_charsets): Don't assume list length fits in int.
5559 Check for size-calculation overflow when allocating sort data.
5560 (syms_of_charset): Allocate an initial charset table that is
5561 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5562
5563 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5564
5565 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5566 The actual value is always <= INT_MAX, and leaving it unsigned made
5567 overflow checking harder.
5568
5569 * dispextern.h (struct glyph_matrix.rows_allocated)
5570 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5571 with xpalloc. The values are still always <= INT_MAX.
5572
5573 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5574
5575 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5576 (SAFE_NALLOCA): New macro.
5577
5578 * region-cache.c (struct boundary.pos, find_cache_boundary)
5579 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5580 (set_cache_region, invalidate_region_cache)
5581 (revalidate_region_cache, know_region_cache, region_cache_forward)
5582 (region_cache_backward, pp_cache):
5583 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5584 so that ptrdiff_t * can be passed to xpalloc.
5585 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5586 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5587 (pp_cache): Don't assume cache_len fits in int.
5588 * region-cache.h: Adjust extern decls to match.
5589
5590 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5591 EMACS_INT, since either will do, for xpalloc.
5592
5593 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5594 (xnmalloc, xnrealloc, xpalloc): New functions.
5595
726e0ab1
PE
5596 * bidi.c (bidi_shelve_header_size): New constant.
5597 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5598 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5599
51f30bc5 5600 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5601 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5602 (overlay_strings):
5603 Don't update size of array until after memory allocation succeeds,
5604 because xmalloc/xrealloc may not return.
0065d054
PE
5605 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5606 now that we have proper integer overflow checking.
5607 (record_overlay_string, overlay_strings): Catch overflows when
5608 calculating size of overlay_str_buf.
726e0ab1 5609
0065d054
PE
5610 * callproc.c (Fcall_process): Check for size overflow when
5611 calculating size of args2.
5612 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5613 Normally we prefer signed values, but sticking with ptrdiff_t would
5614 require adding more-complicated checks.
726e0ab1
PE
5615
5616 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5617 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5618 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5619 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5620
5621 * character.c (Fstring): Check for size-calculation overflow.
5622
5623 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5624 unnecessary integer overflow. Check for size overflow.
5625 (encode_coding_object): Don't update size until xmalloc succeeds.
5626
5627 * composite.c (get_composition_id): Check for overflow in glyph
5628 length calculations.
5629
5630 Integer and memory overflow fixes for display code.
5631 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5632 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5633 (scrolling_window): Check for overflow in size calculations.
5634 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5635 Don't assume glyph table len fits in int.
5636 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5637 (row_table_size): Now ptrdiff_t, not int.
5638 (scrolling_window): Avoid overflow in size calculations.
5639 Don't update size until allocation succeeds.
5640 * fns.c (concat): Check for overflow in size calculations.
5641 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5642 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5643 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5644
5645 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5646 (get_doc_string): Check for size calculation overflow.
5647 Don't update size until allocation succeeds.
5648 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5649 EMACS_INT, where ptrdiff_t will do.
5650 (Fsubstitute_command_keys): Check for string overflow.
5651
5652 * editfns.c (set_time_zone_rule): Don't assume environment length
5653 fits in int.
5654 (message_length): Now ptrdiff_t, not int.
5655 (Fmessage_box): Don't update size until allocation succeeds.
5656 Don't assume message length fits in int.
5657 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5658
0065d054
PE
5659 * emacs.c (main): Do not reallocate argv, since there is a null at
5660 the end that can be overwritten, and this way there's no need to
5661 worry about size-calculation overflow.
5662 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5663
5664 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5665 alloc succeeds.
5666 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5667
5668 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5669 (x_set_scroll_bar_width, x_figure_window_size):
5670 Check for integer overflow.
5671 (x_set_alpha): Do not assume XINT fits in int.
5672
5673 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5674 This is for the members text_lines, text_cols, total_lines, total_cols,
5675 where the system imposes an 'int' limit.
5676
5677 * fringe.c (Fdefine_fringe_bitmap):
5678 Don't update size until alloc works.
5679
5680 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5681 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5682
5683 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5684 Check for size-calculation overflow.
5685 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5686 do, as we prefer signed integers.
5687 (id_to_widget.max_size, id_to_widget.used)
5688 (xg_store_widget_in_map, xg_remove_widget_from_map)
5689 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5690 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5691 Use and return ptrdiff_t, not int.
5692 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5693 * gtkutil.h: Change prototypes to match the above.
5694
5695 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5696 are duplicate now that they've been promoted to lisp.h.
5697 (x_allocate_bitmap_record, x_alloc_image_color)
5698 (make_image_cache, cache_image, xpm_load):
5699 Don't update size until alloc is done.
5700 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5701 (x_detect_edges):
3256efce 5702 Check for size calculation overflow.
726e0ab1
PE
5703 (ct_colors_allocated_max): New constant.
5704 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5705 overflow.
3256efce 5706
726e0ab1
PE
5707 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5708 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5709 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5710 Use ptrdiff_t, not int, to count maps.
5711 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5712 calculations. Don't update size until allocation succeeds.
5713 Redo calculations to avoid overflow.
726e0ab1
PE
5714 * keyboard.h: Change prototypes to match the above.
5715
5716 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5717 to count maps.
5718 (current_minor_maps): Check for size calculation overflow.
5719 * keymap.h: Change prototypes to match the above.
5720
5721 * lread.c (read1, init_obarray): Don't update size until alloc done.
5722
5723 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5724 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5725
726e0ab1
PE
5726 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5727 Now ptrdiff_t, not int.
5728 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5729 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5730
5731 * process.c (Fnetwork_interface_list): Check for overflow
5732 in size calculation.
5733
5734 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5735
5736 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5737 overflow. Don't bother calling xmalloc when xrealloc will do.
5738
5739 * search.c (Freplace_match): Check for size calculation overflow.
5740 (Fset_match_data): Don't assume list lengths fit in 'int'.
5741
5742 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5743 for command line length. Do not attempt to address one before the
5744 beginning of an array, as that's not portable.
5745
5746 * term.c (max_frame_lines): Remove; unused.
5747 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5748 not int.
5749 (encode_terminal_code, calculate_costs): Check for size
5750 calculation overflow.
5751 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5752 table lengths and related sizes. Don't update size until alloc
5753 done. Redo calculations to avoid overflow.
5754 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5755
5756 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5757 subtracting pointers.
5758 (gobble_line): Check for overflow more carefully. Don't update size
5759 until alloc done.
5760
5761 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5762 Don't update size until alloc done.
5763 Redo size calculations to avoid overflow.
5764 Check for size calculation overflow.
0065d054 5765 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5766
5767 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5768 Use ptrdiff_t, not int, for sizes.
5769 (store_mode_line_noprop_char): Don't update size until alloc done.
5770
0065d054
PE
5771 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5772 Use ptrdiff_t, not int, for sizes.
5773 (Finternal_make_lisp_face, cache_face):
5774 Check for size calculation overflow.
5775 (cache_face): Treat size calculation overflows as if they were
5776 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5777
5778 * xfns.c (x_encode_text, x_set_name_internal)
5779 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5780 sizes, since they can exceed INT_MAX in size. Check for size
5781 calculation overflow.
5782
0065d054
PE
5783 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5784 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5785 Don't update size until alloc done.
5786
0065d054 5787 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5788 as sprintf is limited to int lengths.
1d526e2f 5789
252c5ee1
PE
5790 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5791 (X_LONG_MIN): New macros.
864d7ce7
PE
5792 Use them to make the following changes clearer.
5793 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5794 This change doesn't affect the value now, but it may help remind
5795 future maintainers not to raise the value too much later.
5796 (SELECTION_QUANTUM): Remove, replacing with ...
5797 (selection_quantum): ... new function, which avoids overflow.
5798 All uses changed.
5799 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5800 assumption that selection length fits in 'int'.
5801 (x_reply_selection_request, x_handle_selection_request)
5802 (x_get_window_property, receive_incremental_selection)
5803 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5804 (lisp_data_to_selection_data, clean_local_selection_data):
5805 Use ptrdiff_t, not int, to record length of selection.
5806 (x_reply_selection_request, x_get_window_property)
5807 (receive_incremental_selection, x_property_data_to_lisp):
5808 Redo calculations to avoid overflow.
5809 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5810 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5811 something.
5812 (x_get_window_property, receive_incremental_selection)
5813 (lisp_data_to_selection_data, x_property_data_to_lisp):
5814 Check for size-calculation overflow.
5815 (x_get_window_property, receive_incremental_selection)
5816 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5817 Don't store size until memory allocation succeeds.
5818 (x_get_window_property): Plug memory leak on memory exhaustion.
5819 Don't double-block input; malloc is safe here. Don't assume 2**34
5820 - 4 fits in unsigned long. Add an xassert to check
5821 XGetWindowProperty overflow. Be more careful about overflow
5822 calculations, and distinguish size from memory overflow better.
5823 (receive_incremental_selection): When tracing, don't assume
5824 unsigned int is less than INT_MAX.
5825 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5826 harmful) conversions of unsigned short to int.
5827 (lisp_data_to_selection_data): Don't assume that integers
5828 in the range -65535 through -1 fit in an X unsigned short.
5829 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5830 result parameters unless successful. Rely on cons_to_unsigned
5831 to report problems with elements; the old code wasn't right anyway.
5832 (x_check_property_data): Check for int overflow; we cannot use
5833 a wider type due to X limits.
5834 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5835
726e0ab1 5836 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5837
0065d054
PE
5838 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5839 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5840 (x_color_cells): Don't store size until memory allocation succeeds.
5841 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5842 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5843 (x_term_init): Don't assume length fits in int (sprintf is limited
5844 to int size).
bc18e09d 5845
ebfa62c0
PE
5846 Use ptrdiff_t for composition IDs.
5847 * character.c (lisp_string_width):
5848 * composite.c (composition_table_size, n_compositions)
5849 (get_composition_id, composition_gstring_from_id):
5850 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5851 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5852 * window.c (Frecenter):
5853 Use ptrdiff_t, not int, for composition IDs.
5854 * composite.c (get_composition_id): Check for integer overflow.
5855 * composite.h: Adjust prototypes to match the above changes.
5856
d3411f89
PE
5857 Use ptrdiff_t for hash table indexes.
5858 * category.c (hash_get_category_set):
5859 * ccl.c (ccl_driver):
5860 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5861 * coding.c (coding_system_charset_list, detect_coding_system):
5862 * coding.h (struct coding_system.id):
5863 * composite.c (get_composition_id, gstring_lookup_cache):
5864 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5865 * image.c (xpm_get_color_table_h):
5866 * lisp.h (hash_lookup, hash_put):
5867 * minibuf.c (Ftest_completion):
5868 Use ptrdiff_t for hash table indexes, not int (which is too
5869 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5870 32-bit --with-wide-int hosts).
5871
e097a6fa
PE
5872 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5873 Add a FIXME comment about memory leaks.
5874 (syms_of_charset): Don't assume xmalloc returns.
5875
5637687f
PE
5876 Don't assume that stated character widths fit in int.
5877 * character.c (Fchar_width, c_string_width, lisp_string_width):
5878 * character.h (CHAR_WIDTH):
5879 * indent.c (MULTIBYTE_BYTES_WIDTH):
5880 Use sanitize_char_width to avoid undefined and/or bad behavior
5881 with outlandish widths.
a66cfb1c 5882 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5883 now that we have two such functions. All uses changed.
5884 (sanitize_char_width): New inline function.
5885
a2271ba2
PE
5886 Don't assume that tab-width fits in int.
5887 * character.h (sanitize_width): New inline function.
5888 (SANE_TAB_WIDTH): New macro.
5889 (ASCII_CHAR_WIDTH): Use it.
5890 * indent.c (sane_tab_width): Remove. All uses replaced by
5891 SANE_TAB_WIDTH (current_buffer).
5892 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5893
18c52557
PE
5894 * fileio.c: Integer overflow issues with file modes.
5895 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5896
caeeedc1
PE
5897 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5898 Remove unreachable code.
5899 (read_hex, load_charset_map_from_file): Check for integer overflow.
5900
6df6ae42 5901 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5902 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5903 (x_send_scroll_bar_event): Likewise. Check that the size does not
5904 exceed limits imposed by XClientMessageEvent, as well as the usual
5905 ptrdiff_t and size_t limits.
5906
b13995db
PE
5907 * keyboard.c: Overflow, signedness and related fixes.
5908 (make_lispy_movement): Use same integer type in forward decl
5909 that is used in the definition.
5910 (read_key_sequence, keyremap_step):
5911 Change bufsize argument back to int, undoing my 2011-03-30 change.
5912 We prefer signed types, and int is wide enough here.
5913 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5914 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5915 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5916 length, not size_t. Use ptrdiff_t for index, not int.
5917 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5918 possibility of integer overflow.
5919
13464394
PE
5920 Overflow, signedness and related fixes for images.
5921
5922 * dispextern.h (struct it.stack[0].u.image.image_id)
5923 (struct_it.image_id, struct image.id, struct image_cache.size)
5924 (struct image_cache.used, struct image_cache.ref_count):
5925 * gtkutil.c (update_frame_tool_bar):
5926 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5927 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5928 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5929 * nsmenu.m (update_frame_tool_bar):
5930 * xdisp.c (calc_pixel_width_or_height):
5931 * xfns.c (image_cache_refcount):
5932 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5933 on typical 64-bit hosts.
5934
5935 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5936 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5937 Omit unnecessary casts to int.
5938 (parse_image_spec): Check that integers fall into 'int' range
5939 when the callers expect that.
5940 (image_ascent): Redo ascent calculation to avoid int overflow.
5941 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5942 (lookup_image): Remove unnecessary tests.
5943 (xbm_image_p): Locals are now of int, not EMACS_INT,
5944 since parse_image_check makes sure they fit into int.
5945 (png_load, gif_load, svg_load_image):
5946 Prefer int to unsigned where either will do.
5947 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5948 old tiff_error_handler and tiff_warning_handler.
5949 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5950 stack buffer overflows. It uses only the features of vsnprintf
5951 that are common to both POSIX and native Microsoft.
5952 (tiff_error_handler, tiff_warning_handler): Use it.
5953 (tiff_load, gif_load, imagemagick_load_image):
5954 Don't assume :index value fits in 'int'.
5955 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5956 (imagemagick_load_image): Check that crop parameters fit into
5957 the integer types that MagickCropImage accepts. Don't assume
5958 Vimagemagick_render_type has a nonnegative value. Don't assume
5959 size_t fits in 'long'.
5960 (gs_load): Use printmax_t to print the widest integers possible.
5961 Check for integer overflow when computing image height and width.
5962
c11821d4
EZ
59632011-08-26 Eli Zaretskii <eliz@gnu.org>
5964
5965 * xdisp.c (redisplay_window): Don't force window start if point
5966 will be invisible in the resulting window. (Bug#9324)
5967
0c95fcf7
EZ
59682011-08-25 Eli Zaretskii <eliz@gnu.org>
5969
5970 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5971 the display spec is of the form `(space ...)'.
5972 (handle_display_spec): Return the value returned by
5973 handle_single_display_spec, not just 1 or zero.
5974 (handle_single_display_spec): If the display spec is of the form
5975 `(space ...)', and specifies display in the text area, return 2
5976 rather than 1.
fee65a97 5977 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5978 accurately, and prefer exact match for point under bidi.
5979 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5980
5981 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5982 into disp_prop; all users changed.
5983
5984 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5985 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5986 for the text covered by the display property.
5987
e4ed06f1
CY
59882011-08-25 Chong Yidong <cyd@stupidchicken.com>
5989
5990 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5991 Change return value to nil.
5992 (Frecord_buffer): Delete unused function.
5993
f67cdd7f
EZ
59942011-08-24 Eli Zaretskii <eliz@gnu.org>
5995
5980d4c6
EZ
5996 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5997 buffers, return left-to-right.
8610fe8b
EZ
5998 (set_cursor_from_row): Consider candidate row a win if its glyph
5999 represents a newline and point is on that newline. Fixes cursor
6000 positioning on the newline at EOL of R2L text within L2R
6001 paragraph, and vice versa.
6002 (try_cursor_movement): Check continued rows, in addition to
6003 continuation rows. Fixes unwarranted scroll when point enters a
6004 continued line of R2L text within an L2R paragraph, or vice versa.
6005 (cursor_row_p): Consider the case of point being equal to
6006 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6007 from the end of a short line to the beginning of a continued line
6008 of R2L text within L2R paragraph.
6009 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6010 composed characters.
5980d4c6 6011
f67cdd7f
EZ
6012 * bidi.c (bidi_check_type): Use xassert.
6013 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6014 members.
6015
bca633fb
EZ
60162011-08-23 Eli Zaretskii <eliz@gnu.org>
6017
6018 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6019 a character.
6020
4a5885a7
CY
60212011-08-23 Chong Yidong <cyd@stupidchicken.com>
6022
6023 * nsfont.m (ns_otf_to_script): Fix typo.
6024
0902a04e
KH
60252011-08-22 Kenichi Handa <handa@m17n.org>
6026
6027 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6028 extra slot even if the purpose is char-code-property-table.
6029
1a2e6670
EZ
60302011-08-23 Eli Zaretskii <eliz@gnu.org>
6031
8ddde651
EZ
6032 * xdisp.c (redisplay_window): When computing centering_position,
6033 account for the height of the header line. (Bug#8874)
6034
425cc014
EZ
6035 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6036 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6037 candidate is selected by the mouse, and that candidate has a
6038 composed character under the mouse.
6039
1a2e6670
EZ
6040 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6041 coordinates reported by pos-visible-in-window-p for a composed
6042 character in column zero.
6043
8b76d6f8
SM
60442011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6045
6046 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6047
dac347dd
EZ
60482011-08-22 Eli Zaretskii <eliz@gnu.org>
6049
6050 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6051 consider it a hit if to_charpos is anywhere in the range of the
6052 composed buffer positions.
6053
e013fb34
CY
60542011-08-22 Chong Yidong <cyd@stupidchicken.com>
6055
6056 * image.c (gif_load): Don't assume that each subimage has the same
6057 dimensions as the base image. Handle disposal method that is
6058 "undefined" by the gif spec (Bug#9335).
6059
bd1ba3e8
CY
60602011-08-20 Chong Yidong <cyd@stupidchicken.com>
6061
6062 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6063 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6064
54a1215b
EZ
60652011-08-19 Eli Zaretskii <eliz@gnu.org>
6066
823564e5
EZ
6067 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6068 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6069 from an Org mode buffer to a Speedbar frame.
6070
54a1215b
EZ
6071 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6072 a composition, take its buffer position from IT->cmp_it.charpos.
6073 Fixes cursor positioning at the beginning of a line that begins
6074 with a composed character.
6075
9778ebcc
EZ
60762011-08-18 Eli Zaretskii <eliz@gnu.org>
6077
0be6ee06
EZ
6078 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6079 character bidirectional type, use STRONG_L instead. Fixes crashes
6080 in a buffer produced by `describe-categories'.
6081
9778ebcc
EZ
6082 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6083 members before the level stack, so they would be saved and
6084 restored when copying iterator state. Fixes incorrect reordering
6085 around TABs covered by display properties.
6086
156bffbe
AS
60872011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6088
6b02f655 6089 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6090
72ad093b
CY
60912011-08-17 Chong Yidong <cyd@stupidchicken.com>
6092
6093 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6094 (internal_condition_case_2, internal_condition_case_n):
6095 Remove unnecessary aborts (Bug#9081).
72ad093b 6096
35774242
EZ
60972011-08-17 Eli Zaretskii <eliz@gnu.org>
6098
6099 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6100 has no `load' handler, try opening the file locally. (Bug#9311)
6101
db76dd85
KB
61022011-08-16 Ken Brown <kbrown@cornell.edu>
6103
6104 * gmalloc.c: Expand comment.
6105
b215eee5
EZ
61062011-08-16 Eli Zaretskii <eliz@gnu.org>
6107
6108 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6109 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6110
a4579d33
KB
61112011-08-16 Ken Brown <kbrown@cornell.edu>
6112
6113 Fix memory allocation problems in Cygwin build (Bug#9273).
6114
6115 * unexcw.c ( __malloc_initialized): Declare external variable.
6116 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6117
8b76d6f8
SM
6118 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6119 New variables.
a4579d33
KB
6120 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6121 dumped emacs.
6122 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6123 in the static heap.
6124 [CYGWIN] (special_realloc): New function.
6125 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6126 requests to realloc storage in the static heap.
6127
3ebec551
PE
61282011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6129
6130 * bidi.c (bidi_initialize): Remove unused local.
6131
9fd8be00
EZ
61322011-08-15 Eli Zaretskii <eliz@gnu.org>
6133
6b02f655
SM
6134 * bidimirror.h:
6135 * biditype.h: Remove file.
6136 * makefile.w32-in ($(BLD)/bidi.$(O)):
6137 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6138
6139 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6140
6141 * chartab.c: Improve commentary for the uniprop_table API.
6142
32413314
EZ
6143 * bidi.c (bidi_paragraph_init): Support zero value of
6144 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6145 (bidi_initialize): Use uniprop_table instead of including
6146 biditype.h and bidimirror.h.
32413314 6147
9fd8be00
EZ
6148 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6149 coordinates of the iterator when restoring from ppos_it.
6150 (Bug#9296)
6151
5cf2b69b
KH
61522011-08-14 Kenichi Handa <handa@m17n.org>
6153
6154 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6155 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6156
daf17d00
EZ
61572011-08-14 Eli Zaretskii <eliz@gnu.org>
6158
6159 * xdisp.c (move_it_in_display_line_to): Don't invoke
6160 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6161 ppos_it. Fixes vertical cursor motion when line beginning is
6162 covered by an image. (Bug#9296)
6163
08e3161a
JD
61642011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6165
6166 * nsterm.h (ns_run_ascript): Declare.
6167 (NSAPP_DATA2_RUNASSCRIPT): Define.
6168
6169 * nsfns.m (as_script, as_result, as_status): New static variables.
6170 (ns_run_ascript): New function.
5e617bc2 6171 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6172 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6173 the event loop. Get status from as_status (Bug#7276).
6174
6175 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6176 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6177 the event loop (Bug#7276).
6178
a3720aa2
AS
61792011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6180
6181 * gnutls.c (QCgnutls_bootprop_priority)
6182 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6183 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6184 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6185 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6186 (QCgnutls_bootprop_verify_hostname_error)
6187 (QCgnutls_bootprop_callbacks_verify): Rename from
6188 Qgnutls_bootprop_..., all uses changed.
6189
6190 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6191 uses changed.
6192
0a0d27fb
PE
61932011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6194
19d5c50c
PE
6195 * xfaces.c (Qframe_set_background_mode): Now static.
6196 * dispextern.h (Qframe_set_background_mode): Remove decl.
6197
0a0d27fb
PE
6198 * process.c (Fnetwork_interface_info): Declare local only if needed.
6199
377538cb
JD
62002011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6201
6202 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6203 (Fnetwork_interface_list): Allocate in increments of bytes instead
6204 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6205 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6206 sockaddr.
6207 (struct ifflag_def): notrailers is smart on OSX.
6208 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6209 Get hardware address with getifaddrs if available.
6210
08fff70c
EZ
62112011-08-12 Eli Zaretskii <eliz@gnu.org>
6212
6213 * xdisp.c (iterate_out_of_display_property): xassert that
6214 IT->position is set to within IT->object's boundaries. Break from
6215 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6216 when IT->position is set up wrongly due to some bug.
6217 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6218 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6219 entry. Force push_it to save on the stack the current
6220 buffer/string position, to be restored by pop_it. Fix flags in
6221 the iterator structure wrt the object coming from a display
6222 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6223 properties. (Bug#9284)
6224
7be1c708 62252011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6226
7be1c708
CY
6227 * fontset.c (fontset_get_font_group): Add proper type checks.
6228 (Bug#9172)
aac0c6e3 6229
7be1c708 62302011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6231
7be1c708
CY
6232 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6233 and LC_VERSION_MIN_MACOSX.
6234 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6235 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6236
97bb72a6
EZ
62372011-08-08 Eli Zaretskii <eliz@gnu.org>
6238
6239 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6240 no-display-properties-and-no-overlays under bidi display.
6241 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6242 properties and overlays.
97bb72a6 6243
d5617611
CY
62442011-08-08 Chong Yidong <cyd@stupidchicken.com>
6245
37e11a63
CY
6246 * editfns.c (Fset_time_zone_rule): Document relationship with the
6247 setenv function.
6248
d5617611
CY
6249 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6250 the font entity extracted from the cache (Bug#8109).
6251
58872834
CY
62522011-08-07 Chong Yidong <cyd@stupidchicken.com>
6253
6254 * composite.c (autocmp_chars): Don't reset point. That is done by
6255 restore_point_unwind (Bug#5984).
6256
75bfc667
JL
62572011-08-07 Juri Linkov <juri@jurta.org>
6258
6259 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6260 to show the arg `TIME' instead of `TIMEVAL'.
6261
d1410150
EZ
62622011-08-06 Eli Zaretskii <eliz@gnu.org>
6263
6264 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6265 display property strides EOL and includes a newline, as in
6266 longlines-mode. (Bug#9254)
75b771e4
EZ
6267 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6268 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6269
6270 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6271 is non-zero, even if the data buffer is NULL. Fixes a crash in
6272 vertical-motion with longlines-mode. (Bug#9254)
6273
35928349
EZ
62742011-08-05 Eli Zaretskii <eliz@gnu.org>
6275
ec7cc85b
EZ
6276 * bidi.c <bidi_cache_total_alloc>: Now static.
6277 (bidi_initialize): Initialize bidi_cache_total_alloc.
6278
8b76d6f8 6279 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6280 cache. (Bug#9221)
6281
6282 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6283 amount allocated this far in `bidi_cache_total_alloc'.
6284 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6285 non-zero, only free the data buffer without restoring the cache
6286 contents. All callers changed.
6287
6288 * dispextern.h (bidi_unshelve_cache): Update prototype.
6289
6290 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6291 (move_it_in_display_line, move_it_to)
6292 (move_it_vertically_backward, move_it_by_lines): Replace the call
6293 to xfree to an equivalent call to bidi_unshelve_cache.
6294 (move_it_in_display_line_to): Fix logic of returning
412b6358 6295 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6296
e2e2423b
EZ
62972011-08-05 Eli Zaretskii <eliz@gnu.org>
6298
6299 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6300 came from a string character with a `cursor' property. (Bug#9229)
6301
ae9e757a
JD
63022011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6303
6304 * Makefile.in (LIB_PTHREAD): New variable.
6305 (LIBES): Add LIB_PTHREAD (Bug#9216).
6306
6307 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6308 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6309
213bd7f2
AS
63102011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6311
6b02f655 6312 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6313
99aaf75f
JD
63142011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6315
6316 * xterm.c (x_find_topmost_parent): New function.
6317 (x_set_frame_alpha): Find topmost parent window with
6318 x_find_topmost_parent and set the property there also (bug#9181).
6319 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6320
c74e9d86
PE
63212011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6322
6323 * callproc.c (Fcall_process): Avoid vfork clobbering
6324 the local vars buffer, coding_systems, current_dir.
6325
640c8776
SM
63262011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6327
6328 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6329
f26d0e4c
PE
63302011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6331
8a10d76c
PE
6332 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6333 so that it is not optimized away.
6334
f26d0e4c
PE
6335 * xdisp.c (compute_display_string_pos): Remove unused local.
6336
55439c61
EZ
63372011-08-02 Eli Zaretskii <eliz@gnu.org>
6338
6339 Fix slow cursor motion and scrolling in large buffers with
6340 selective display, like Org Mode buffers. (Bug#9218)
6341
6342 * dispextern.h (struct bidi_it): New member disp_prop_p.
6343
6344 * xdisp.c: Remove one-slot cache of display string positions.
6345 (compute_display_string_pos): Accept an additional argument
5e617bc2 6346 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6347 for a display string or property. If found, set DISP_PROP_P
6348 non-zero.
6349
6350 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6351 DISP_PROP_P, and pass it to compute_display_string_pos.
6352 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6353 non-zero. All callers of bidi_fetch_char changed.
6354
fb33fa43
SM
63552011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6356
6357 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6358
b099e063
DM
63592010-12-03 Don March <don@ohspite.net>
6360
6361 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6362 last character M-[char] is translated to ESC [char] (bug#7541).
6363
5cc7f7af
KH
63642011-08-02 Kenichi Handa <handa@m17n.org>
6365
d0fffa3f 6366 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6367
6368 * chartab.c (uniprop_table): Make it non-static.
6369
525d5e6e
EZ
63702011-08-01 Eli Zaretskii <eliz@gnu.org>
6371
6372 * xdisp.c (forward_to_next_line_start): Accept additional argument
6373 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6374 on the newline.
6375 (reseat_at_next_visible_line_start): Use the bidi iterator state
6376 returned by forward_to_next_line_start to restore the state of
6377 it->bidi_it after backing up to previous newline. (Bug#9212)
6378
31011111
AS
63792011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6380
6381 * regex.c (re_comp): Protoize.
6382 (re_exec): Fix return type.
6383 (regexec): Fix type of `ret'. (Bug#9203)
6384
476371c4
PE
63852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6386
e5d76069
PE
6387 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6388 This is needed if max-image-size is a floating-point number.
6389
9a79b20c
AS
63902011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6391
6392 * print.c (print_object): Print empty symbol as ##.
6393
6394 * lread.c (read1): Read ## as empty symbol.
6395
d8c2fa78
AA
63962011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6397
6398 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6399 setting frame foreground color (Bug#9175).
6400 (x_set_background_color): Likewise.
6401
ffe57a7a
AA
6402 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6403 contents (Bug#9176).
6404 (EmacsTooltip -init): Remove bezels and add shadows to
6405 tooltip windows.
6406
bf3492a5
AA
6407 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6408 or scroll bar (Bug#8470).
6409
d55e9c53
AA
6410 * nsfont.m (nsfont_open): Remove assignment to voffset and
6411 unnecessary vars hshink, expand, hd, full_height, min_height.
6412 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6413
6414 * nsterm.h (nsfont_info): Remove voffset field.
6415
d8c2fa78 64162011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6417
6418 Implement strike-through and overline on NextStep (Bug#8863).
6419
6420 * nsfont.m (nsfont_open): Use underline position provided by font,
6421 instead of hard-coded value of 2.
6422 (nsfont_draw): Call ns_draw_text_decoration instead.
6423
6424 * nsterm.h: Add declaration for ns_draw_text_decoration.
6425
6426 * nsterm.m (ns_draw_text_decoration): New function for drawing
6427 underline, overline, and strike-through.
6428 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6429 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6430 accommodate underlining, etc.
4843aac3 6431
4cc60b9b
EZ
64322011-07-28 Eli Zaretskii <eliz@gnu.org>
6433
bc7ece87
EZ
6434 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6435 default.
4cc60b9b 6436
476371c4
PE
64372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6438
66606eea
PE
6439 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6440 Without this fix, if a signal arrives just after memory fills up,
6441 'malloc' might be invoked reentrantly.
6442
476371c4
PE
6443 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6444 In other words, assume that every image size is allowed, on non-X
6445 hosts. This assumption is probably wrong, but it lets Emacs compile.
6446
f3fcc40d
AS
64472011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6448
6449 * regex.c (re_iswctype): Convert return values to boolean.
6450
350c992f
EZ
64512011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6452
6453 * xdisp.c (compute_display_string_pos): Don't use cached display
6454 string position if the buffer had its restriction changed.
6455 (Bug#9184)
6456
5266b4bb
PE
64572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6458
6459 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6460
2573a837 64612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6462
41f55ccd 6463 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6464
39e378da
PE
6465 * bidi.c: Integer size and overflow fixes.
6466 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6467 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6468 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6469 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6470 (bidi_find_other_level_edge):
6471 Use ptrdiff_t instead of EMACS_INT where either will do.
6472 This works better on 32-bit hosts configured --with-wide-int.
6473 (bidi_cache_ensure_space): Check for size-calculation overflow.
6474 Use % rather than repeated addition, for better worst-case speed.
6475 Don't set bidi_cache_size until after xrealloc returns, because it
6476 might not return.
6477 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6478 (bidi_cache_ensure_space): Also check that the bidi cache size
6479 does not exceed that of the largest Lisp string or buffer. See Eli
6480 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6481
5e927815
PE
6482 * alloc.c (__malloc_size_t): Remove.
6483 All uses replaced by size_t. See Andreas Schwab's note
6484 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6485
ca4aa935
PE
6486 * image.c: Improve checking for integer overflow.
6487 (check_image_size): Assume that f is nonnull, since
6488 it is always nonnull in practice. This is one less thing to
6489 worry about when checking for integer overflow later.
6490 (x_check_image_size): New function, which checks for integer
6491 overflow issues inside X.
6492 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6493 This removes the need for a memory_full check.
6494 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6495 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6496 (xbm_read_bitmap_data): Change locals back to 'int', since
6497 their values must fit in 'int'.
6498 (xpm_load_image, png_load, tiff_load):
6499 Invoke x_create_x_image_and_pixmap earlier,
6500 to avoid much needless work if the image is too large.
6501 (tiff_load): Treat overly large images as if
6502 x_create_x_image_and_pixmap failed, not as malloc failures.
6503 (gs_load): Use x_check_image_size.
6504
5f8f9cc2
PE
6505 * gtkutil.c: Omit integer casts.
6506 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6507 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6508
5adf60bc
PE
6509 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6510
c8907a93
PE
6511 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6512 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6513 would wrongly return t on a 64-bit host.
6514
e3c25c68
PE
6515 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6516 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6517 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6518 and therefore cause GCC to emit a bogus diagnostic in some cases.
6519
3f791afe
PE
6520 * image.c: Integer signedness and overflow and related fixes.
6521 This is not an exhaustive set of fixes, but it's time to
6522 record what I've got.
6523 (lookup_pixel_color, check_image_size): Remove redundant decls.
6524 (check_image_size): Don't assume that arbitrary EMACS_INT values
6525 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6526 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6527 (tiff_load, imagemagick_load_image):
6528 Check for overflow in size calculations.
6529 (x_create_x_image_and_pixmap): Remove unnecessary test for
6530 xmalloc returning NULL; that can't happen.
6531 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6532 (xpm_color_bucket): Use better integer hashing function.
6533 (xpm_cache_color): Don't possibly over-allocate memory.
6534 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6535 (gif_memory_source):
6536 Use ptrdiff_t, not int or size_t, to record sizes.
6537 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6538 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6539 either works, as we prefer signed integers.
6540 (tiff_read_from_memory, tiff_write_from_memory):
6541 Return tsize_t, not size_t, since that's what the TIFF API wants.
6542 (tiff_read_from_memory): Don't fail simply because the read would
6543 go past EOF; instead, return a short read.
6544 (tiff_load): Omit no-longer-needed casts.
6545 (Fimagemagick_types): Don't assume size fits into 'int'.
6546
3cc5a532
PE
6547 Improve hashing quality when configured --with-wide-int.
6548 * fns.c (hash_string): New function, taken from sxhash_string.
6549 Do not discard information about ASCII character case; this
6550 discarding is no longer needed.
6551 (sxhash-string): Use it. Change sig to match it. Caller changed.
6552 * lisp.h: Declare it.
6553 * lread.c (hash_string): Remove, since we now use fns.c's version.
6554 The fns.c version returns a wider integer if --with-wide-int is
6555 specified, so this should help the quality of the hashing a bit.
6556
b312a492
PE
6557 * emacs.c: Integer overflow minor fix.
6558 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6559 Define only if GNU_LINUX.
6560 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6561
dfd153ae
PE
6562 * dispnew.c: Integer signedness and overflow fixes.
6563 Remove unnecessary forward decls, that were a maintenance hassle.
6564 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6565 All uses changed.
6566 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6567 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6568 (prepare_desired_row, line_draw_cost):
6569 Use int, not unsigned, where either works.
6570 (save_current_matrix, restore_current_matrix):
6571 Use ptrdiff_t, not size_t, where either works.
6572 (init_display): Check for overflow more accurately, and without
6573 relying on undefined behavior.
6574
a81d11a3
PE
6575 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6576 Remove, replacing with the new symbols in lisp.h. All uses changed.
6577 * fileio.c (make_temp_name):
6578 * filelock.c (lock_file_1, lock_file):
6579 * xdisp.c (message_dolog):
6580 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6581 Use pMd etc. instead.
6582 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6583 replacing the pWIDE etc. symbols removed from editfns.c.
6584
3300e6fd
PE
6585 * keyboard.h (num_input_events): Now uintmax_t.
6586 This is (very slightly) less likely to mess up due to wraparound.
6587 All uses changed.
6588
fd05c7e9
PE
6589 * buffer.c: Integer signedness fixes.
6590 (alloc_buffer_text, enlarge_buffer_text):
6591 Use ptrdiff_t rather than size_t when either will do, as we prefer
6592 signed integers.
6593
903fe15d
PE
6594 * alloc.c: Integer signedness and overflow fixes.
6595 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6596 (__malloc_size_t): Default to size_t, not to int.
6597 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6598 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6599 Prefer ptrdiff_t to size_t when either would do, as we prefer
6600 signed integers.
6601 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6602 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6603 Now const. Initialize with values that are in range even if char
6604 is signed.
6605 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6606 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6607 These functions do the right thing with sizes > 2**32.
6608 (check_depth): Now ptrdiff_t, not int.
6609 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6610 Adjust to new way of storing sizes. Check for size overflow bugs
6611 in rest of code.
6612 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6613 slightly wrong anyway, as it missed one instance of
6614 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6615 (refill_memory_reserve): Omit needless cast to size_t.
6616 (mark_object_loop_halt): Mark as externally visible.
6617
ac82cc6a
PE
6618 * xselect.c: Integer signedness and overflow fixes.
6619 (Fx_register_dnd_atom, x_handle_dnd_message):
6620 Use ptrdiff_t, not size_t, since we prefer signed.
6621 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6622 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6623 x_dnd_atoms_size and x_dnd_atoms_length.
6624
c2d1e36d
PE
6625 * doprnt.c: Prefer signed to unsigned when either works.
6626 * eval.c (verror):
6627 * doprnt.c (doprnt):
6628 * lisp.h (doprnt):
6629 * xdisp.c (vmessage):
6630 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6631 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6632 prefer signed arithmetic to avoid comparison confusion.
6633 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6634 but is a bit tricky.
6635
0e926e56
PE
6636 Assume freestanding C89 headers, string.h, stdlib.h.
6637 * data.c, doprnt.c, floatfns.c, print.c:
6638 Include float.h unconditionally.
6639 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6640 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6641 * regex.c: Likewise for stddef.h, string.h.
6642 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6643 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6644 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6645 (STDC_HEADERS): Remove obsolete defines.
6646 * sysdep.c: Include limits.h unconditionally.
6647
9cfdb3ec
PE
6648 Assume support for memcmp, memcpy, memmove, memset.
6649 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6650 * regex.c (memcmp, memcpy):
6651 Remove; we assume C89 now.
6652
6653 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6654 (__malloc_safe_bcopy): Remove; no longer needed.
6655
cf950e6b 6656 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6657 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6658 well either way, and we prefer signed to unsigned.
6659
dbf38e02
LMI
66602011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6661
6662 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6663 closes the connection while we're reading (bug#9182).
6664
d6f0886c 66652011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6666
d6f0886c
JD
6667 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6668 are specified (Bug#9168).
24e0f6b1 6669
2eb1f9e6
PE
66702011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6671
6672 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6673 Found by GCC static checking and --with-wide-int on a 32-bit host.
6674
22381272 66752011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6676
6677 * xdisp.c (compute_display_string_pos): Fix logic of caching
6678 previous display string position. Initialize cached_prev_pos to
6679 -1. Fixes slow-down at the beginning of a buffer.
6680
f25e39b4
EZ
66812011-07-24 Eli Zaretskii <eliz@gnu.org>
6682
6683 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6684 for attrs[LFACE_FONTSET_INDEX].
6685
04c4b52e
PE
66862011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6687
6688 * xml.c (parse_region): Remove unused local
6689 that was recently introduced.
6690
c1734fbd
EZ
66912011-07-23 Eli Zaretskii <eliz@gnu.org>
6692
be18c5a5
EZ
6693 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6694 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6695
c1734fbd
EZ
6696 * xdisp.c (move_it_in_display_line_to): Record the best matching
6697 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6698 exit if none of the characters scanned was an exact match.
6699 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6700 when exact match is impossible due to invisible text, and the
6701 lines are truncated.
6702
a258d627
JD
67032011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6704
6705 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6706 for OSX >= 10.7.
6707
b6d5a689
EZ
67082011-07-22 Eli Zaretskii <eliz@gnu.org>
6709
0f74f785
EZ
6710 Fix a significant slow-down of cursor motion with C-n, C-p,
6711 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6712 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6713 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6714 (next_element_from_buffer): Call compute_stop_pos_backwards to
6715 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6716 base_level_stop.
6717 (reseat): Don't look for prev_stop, as that could mean a very long
6718 run.
6719 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6720 <cached_disp_overlay_modiff>: Cache for last found display string
6721 position.
551918c1 6722 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6723 about the same buffer in the same area of character positions, and
6724 the buffer wasn't changed since the time the display string
6725 position was cached.
551918c1 6726
b2d0c91a
EZ
67272011-07-22 Eli Zaretskii <eliz@gnu.org>
6728
6729 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6730 is an integer, which is important for empty lines. (Bug#9149)
6731
043604ee
CY
67322011-07-22 Chong Yidong <cyd@stupidchicken.com>
6733
6734 * frame.c (Fmodify_frame_parameters): In tty case, update the
6735 default face if necessary (Bug#4238).
6736
da4adb04
CY
67372011-07-21 Chong Yidong <cyd@stupidchicken.com>
6738
6739 * editfns.c (Fstring_to_char): No need to explain what a character
6740 is in the docstring (Bug#6576).
6741
9abd0532
LMI
67422011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6743
6744 * xml.c (parse_region): Make sure we always return a tree.
6745
36881d16
HK
67462011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6747
6748 * xml.c (parse_region): If a document contains only comments,
6749 return that, too.
6750
1e98674d
LMI
67512011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6752
6753 * xml.c (make_dom): Return comments, too.
6754
590bd467
PE
67552011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6756
6757 Port to OpenBSD.
6758 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6759 and the surrounding thread.
6760 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6761 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6762 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6763 timer goes off.
6764 * s/openbsd.h (BROKEN_SIGIO): Define.
6765 * unexelf.c (unexec) [__OpenBSD__]:
6766 Don't update the .mdebug section of the Alpha COFF symbol table.
6767
f41628b2
LMI
67682011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6769
6770 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6771 (bug#8460).
6772
b59b67c5
PE
67732011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6774
15e3a074
PE
6775 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6776 This fixes some race conditions on the permissions of any newly
6777 created file.
6778
41bed37d
PE
6779 * alloc.c (valid_pointer_p): Use pipe, not open.
6780 This fixes some permissions issues when debugging.
6781
b59b67c5
PE
6782 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6783 If fchown fails to set both uid and gid, try to set just gid,
6784 as that is sometimes allowed. Adjust the file's mode to eliminate
6785 setuid or setgid bits that are inappropriate if fchown fails.
6786
925a6be7
SM
67872011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6788
6789 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6790 to compare Lisp_Objects.
6791 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6792 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6793 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6794
52968808
AS
67952011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6796
0a6a104b
AS
6797 * lread.c (read_integer): Unread even EOF character.
6798 (read1): Likewise. Properly record start position of symbol.
6799
52968808
AS
6800 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6801 symbol character follows.
6802
9e381cdd
PE
68032011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6804
6805 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6806 This works around a problem with the previous change to Fcopy_file.
6807 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6808 and without this change, GCC might complain about discarding
6809 fchown's return value.
6810
b5641435
JB
68112011-07-16 Juanma Barranquero <lekktu@gmail.com>
6812
6813 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6814
a8031457
PE
68152011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6816
6817 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6818
dd889327
LMI
68192011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6820
750c33f7
LMI
6821 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6822 it's used from the C level.
6823
dd889327
LMI
6824 * process.c: Use the same condition for POLL_FOR_INPUT in both
6825 keyboard.c and process.c (bug#1858).
6826
87e86684
LM
68272011-07-09 Lawrence Mitchell <wence@gmx.li>
6828
6829 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6830 (Fgnutls_boot): Use it.
6831
64348f40
AS
68322011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6833
6834 * doc.c (Fsubstitute_command_keys): Revert last change.
6835
1d698799
LMI
68362011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6837
f863868c
LMI
6838 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6839 quotes the next character, and doesn't affect other longer
6840 sequences (bug#8935).
6841
1d698799
LMI
6842 * lread.c (syms_of_lread): Clarify that is isn't only
6843 `eval-buffer' and `eval-defun' that's affected by
6844 `lexical-binding' (bug#8460).
6845
aa4b6df6
EZ
68462011-07-15 Eli Zaretskii <eliz@gnu.org>
6847
6848 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6849 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6850
5d856da6
PE
68512011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6852
ad6042bb
PE
6853 Fix minor problems found by static checking.
6854 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6855 (elsz): Now a signed constant, not a size_t var. We prefer signed
6856 types to unsigned, to avoid integer comparison confusion. Without
6857 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6858 "cannot optimize loop, the loop counter may overflow", a symptom
6859 of the confusion.
f00bbb22 6860 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6861 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6862
6468f31c
LMI
68632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6864
49080b10
LMI
6865 * search.c (Fre_search_backward): Mention `case-fold-search' in
6866 all the re_search_* functions (bug#8138).
6867
6468f31c
LMI
6868 * keyboard.c (Fopen_dribble_file): Document when the file is
6869 closed (bug#8056).
6870
c965adc5
EZ
68712011-07-14 Eli Zaretskii <eliz@gnu.org>
6872
df9733bf
EZ
6873 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6874 bidi_cache_idx.
6875
0bb23927
EZ
6876 Support bidi reordering of display and overlay strings.
6877 * xdisp.c (compute_display_string_pos)
6878 (compute_display_string_end): Accept additional argument STRING.
6879 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6880 (reseat_to_string): Initialize bidi_it->string.s and
6881 bidi_it->string.schars.
6882 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6883 NULL (avoids a crash in bidi_paragraph_init).
6884 Initialize itb.string.lstring.
0bb23927
EZ
6885 (init_iterator): Call bidi_init_it only of a valid
6886 buffer position was specified. Initialize paragraph_embedding to
6887 L2R.
6888 (reseat_to_string): Initialize the bidi iterator.
6889 (display_string): If we need to ignore text properties of
6890 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6891 original value of -1 will not work with bidi.)
6892 (compute_display_string_pos): First arg is now struct
6893 `text_pos *'; all callers changed. Support display properties on
6894 Lisp strings.
6895 (compute_display_string_end): Support display properties on Lisp
6896 strings.
6897 (init_iterator, reseat_1, reseat_to_string): Initialize the
6898 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6899 when iterating on a string not from display properties).
640c8776
SM
6900 (compute_display_string_pos, compute_display_string_end):
6901 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6902 arrow keys.
6903 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6904 base_level_stop; instead, set base_level_stop to BEGV.
6905 Fixes crashes in vertical-motion.
0bb23927
EZ
6906 (next_element_from_buffer): Improve commentary for when
6907 the iterator is before prev_stop.
6908 (init_iterator): Initialize bidi_p from the default value of
6909 bidi-display-reordering, not from buffer-local value. Use the
6910 buffer-local value only if initializing for buffer iteration.
6911 (handle_invisible_prop): Support invisible properties on strings
6912 that are being bidi-reordered.
6913 (set_iterator_to_next): Support bidi reordering of C strings and
6914 Lisp strings.
6915 (next_element_from_string): Support bidi reordering of Lisp
6916 strings.
6917 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6918 (display_string): Support display of R2L glyph rows.
6919 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6920 (init_iterator): Don't initialize it->bidi_p for strings
6921 here.
6922 (reseat_to_string): Initialize it->bidi_p for strings here.
6923 (next_element_from_string, next_element_from_c_string)
6924 (next_element_from_buffer): Add xassert's for correspondence
6925 between IT's object being iterated and it->bidi_it.string
6926 structure.
6927 (face_before_or_after_it_pos): Support bidi iteration.
6928 (next_element_from_c_string): Handle the case of the first string
6929 character that is not the first one in the visual order.
6930 (get_visually_first_element): New function, refactored from common
6931 parts of next_element_from_buffer, next_element_from_string, and
6932 next_element_from_c_string.
6933 (tool_bar_lines_needed, redisplay_tool_bar)
6934 (display_menu_bar): Force left-to-right direction. Add a FIXME
6935 comment for making that be controlled by a user option.
6936 (push_it, pop_it): Save and restore the state of the
6937 bidi iterator. Save and restore the bidi_p flag.
6938 (pop_it): Iterate out of display property for string iteration as
6939 well.
6940 (iterate_out_of_display_property): Support iteration over strings.
6941 (handle_single_display_spec): Set up it->bidi_it for iteration
6942 over a display string, and call bidi_init_it.
6943 (handle_single_display_spec, next_overlay_string)
6944 (get_overlay_strings_1, push_display_prop): Set up the bidi
6945 iterator for displaying display or overlay strings.
6946 (forward_to_next_line_start): Don't use the shortcut if
6947 bidi-iterating.
6948 (back_to_previous_visible_line_start): If handle_display_prop
6949 pushed the iterator stack, restore the internal state of the bidi
6950 iterator by calling bidi_pop_it same number of times.
6951 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6952 and we are bidi-iterating, don't decrement the iterator position;
6953 instead, set the first_elt flag in the bidi iterator, to produce
6954 the same effect.
6955 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6956 (push_display_prop): xassert that we are iterating a buffer.
6957 (push_it, pop_it): Save and restore paragraph_embedding member.
6958 (handle_single_display_spec, next_overlay_string)
6959 (get_overlay_strings_1, reseat_1, reseat_to_string)
6960 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6961 correctly. Don't assume unibyte strings are not bidi-reordered.
6962 (compute_display_string_pos)
6963 (compute_display_string_end): Fix handling the case of C string.
6964 (push_it, pop_it): Save and restore from_disp_prop_p.
6965 (handle_single_display_spec, push_display_prop): Set the
6966 from_disp_prop_p flag.
6967 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6968 (pop_it): Call iterate_out_of_display_property only if we are
6969 popping after iteration over a string that came from a display
6970 property. Fix a typo in popping stretch info. Add an assertion
6971 for verifying that the iterator position is in sync with the bidi
6972 iterator.
6973 (handle_single_display_spec, get_overlay_strings_1)
6974 (push_display_prop): Fix initialization of paragraph direction for
6975 string when that of the parent object is not yet determined.
6976 (reseat_1): Call bidi_init_it to resync the bidi
6977 iterator with IT's position. (Bug#7616)
6978 (find_row_edges): If ROW->start.pos gives position
6979 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6980 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6981 Reset the from_disp_prop_p flag.
6982 (SAVE_IT, RESTORE_IT): New macros.
6983 (pos_visible_p, face_before_or_after_it_pos)
6984 (back_to_previous_visible_line_start)
6985 (move_it_in_display_line_to, move_it_in_display_line)
6986 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6987 (try_scrolling, redisplay_window, display_line): Use them when
6988 saving a temporary copy of the iterator and restoring it back.
6989 (back_to_previous_visible_line_start, reseat_1)
6990 (init_iterator): Empty the bidi cache "stack".
6991 (move_it_in_display_line_to): If iterator ended up at
6992 EOL, but we never saw any buffer positions smaller than
6993 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6994 motion in bidi-reordered lines.
6995 (move_it_in_display_line_to): Record prev_method and prev_pos
6996 immediately before the call to set_iterator_to_next. Fixes cursor
6997 motion in bidi-reordered lines with stretch glyphs and strings
6998 displayed in margins. (Bug#8133) (Bug#8867)
6999 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7000 TO_CHARPOS.
640c8776
SM
7001 (pos_visible_p): Support positions in bidi-reordered lines.
7002 Save and restore bidi cache.
0bb23927
EZ
7003
7004 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7005 (bidi_paragraph_info): Delete unused struct.
7006 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7007 (bidi_cache_start): New variable.
7008 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7009 to zero.
7010 (bidi_cache_fetch_state, bidi_cache_search)
7011 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7012 (bidi_cache_find, bidi_peek_at_next_level)
7013 (bidi_level_of_next_char, bidi_find_other_level_edge)
7014 (bidi_move_to_visually_next): Compare cache index with
7015 bidi_cache_start rather than with zero.
7016 (bidi_fetch_char): Accept new argument STRING; all callers
7017 changed. Support iteration over a string. Support strings with
7018 display properties. Support unibyte strings. Fix the type of
7019 `len' according to what STRING_CHAR_AND_LENGTH expects.
7020 (bidi_paragraph_init, bidi_resolve_explicit_1)
7021 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7022 (bidi_level_of_next_char, bidi_move_to_visually_next):
7023 Support iteration over a string.
0bb23927
EZ
7024 (bidi_set_sor_type, bidi_resolve_explicit_1)
7025 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7026 can now be zero (for strings); special values 0 and -1 were
7027 changed to -1 and -2, respectively.
7028 (bidi_char_at_pos): New function.
7029 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7030 Call it instead of FETCH_MULTIBYTE_CHAR.
7031 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7032 initialized to valid values.
7033 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7034 values.
7035 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7036 the test for valid cached positions. Fix the logic for looking up
7037 the sentinel state in the cache. GCPRO the Lisp string we are
7038 iterating.
7039 (bidi_push_it, bidi_pop_it): New functions.
7040 (bidi_initialize): Initialize the bidi cache start stack pointer.
7041 (bidi_cache_ensure_space): New function, refactored from part of
7042 bidi_cache_iterator_state. Don't assume the required size is just
7043 one BIDI_CACHE_CHUNK away.
7044 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7045 (bidi_count_bytes, bidi_char_at_pos): New functions.
7046 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7047 always valid if bidi_cache_idx is valid.
7048 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7049 is valid if it's going to be used.
7050 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7051 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7052 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7053 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7054 (bidi_find_other_level_edge, bidi_cache_start_stack):
7055 All variables related to cache indices are now EMACS_INT.
c965adc5 7056
0bb23927
EZ
7057 * dispextern.h (struct bidi_string_data): New structure.
7058 (struct bidi_it): New member `string'. Make flag members be 1-bit
7059 fields, and put them last in the struct.
640c8776
SM
7060 (compute_display_string_pos, compute_display_string_end):
7061 Update prototypes.
0bb23927
EZ
7062 (bidi_push_it, bidi_pop_it): Add prototypes.
7063 (struct iterator_stack_entry): New members bidi_p,
7064 paragraph_embedding, and from_disp_prop_p.
7065 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7066 (bidi_shelve_cache, bidi_unshelve_cache):
7067 Declare prototypes.
0bb23927
EZ
7068
7069 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7070 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7071 and vector-like objects.
7072
7073 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7074 cache around display iteration.
7075
7076 * window.c (Fwindow_end, window_scroll_pixel_based)
7077 (displayed_window_lines, Frecenter): Save and restore the bidi
7078 cache around display iteration.
7079
3bbd2265
LMI
70802011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7081
7082 * editfns.c (Fdelete_region): Clarify the use of the named
7083 parameters (bug#6788).
7084
adc47434
MR
70852011-07-14 Martin Rudalics <rudalics@gmx.at>
7086
7087 * indent.c (Fvertical_motion): Set and restore w->pointm when
7088 saving and restoring the window's buffer (Bug#9006).
7089
837c31f8
LMI
70902011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7091
7092 * editfns.c (Fstring_to_char): Clarify just what is returned
7093 (bug#6576). Text by Eli Zaretskii.
7094
ac389d0c
JB
70952011-07-13 Juanma Barranquero <lekktu@gmail.com>
7096
7097 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7098
0be0ce47
EZ
70992011-07-13 Eli Zaretskii <eliz@gnu.org>
7100
7101 * buffer.c (mmap_find): Fix a typo.
7102
cd18e7e3
JB
71032011-07-13 Johan Bockgård <bojohan@gnu.org>
7104
7105 Fix execution of x selection hooks.
7106 * xselect.c (Qx_lost_selection_functions)
7107 (Qx_sent_selection_functions): New vars.
7108 (syms_of_xselect): DEFSYM them.
7109 (x_handle_selection_request): Pass Qx_sent_selection_functions
7110 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7111 (x_handle_selection_clear,x_clear_frame_selections):
7112 Pass Qx_lost_selection_functions rather than
7113 Vx_lost_selection_functions to Frun_hook_with_args.
7114
47ea7f44
PE
71152011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7116
ac389d0c 7117 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7118 The old code sometimes used this field without initializing it.
7119
47ea7f44
PE
7120 * alloc.c (gc_sweep): Don't read past end of array.
7121 In theory, the old code could also have corrupted Emacs internals,
7122 though it'd be very unlikely.
7123
bc985c87
AS
71242011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7125
7126 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7127 argument. (Bug#4026)
bc985c87 7128
0cf34688
LMI
71292011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7130
b3dadd76
LMI
7131 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7132 key" (bug#4257).
7133
0cf34688
LMI
7134 * window.c (Fset_window_start): Doc fix (bug#4199).
7135 (Fset_window_hscroll): Ditto.
7136
270768cd
PE
71372011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7138
077e3dda 7139 Fix minor new problems caught by GCC 4.6.1.
270768cd 7140 * term.c (init_tty): Remove unused local.
490011a6 7141 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7142 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7143 not used otherwise.
270768cd 7144
b1f58454
CY
71452011-07-12 Chong Yidong <cyd@stupidchicken.com>
7146
7147 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7148
22b9578d
LMI
71492011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7150
6e70ab07
LMI
7151 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7152 are the mini-buffer and the echo area (bug#3320).
7153
22b9578d
LMI
7154 * term.c (init_tty): Remove support for supdup, c10 and perq
7155 terminals, which are no longer supported (bug#1482).
7156
8974cc9f
JB
71572011-07-10 Johan Bockgård <bojohan@gnu.org>
7158
7159 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7160
a560d974
JD
71612011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7162
7163 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7164 for non-popups (Bug#3642).
7165
1dae0f0a
AS
71662011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7167
268c2c36 7168 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7169 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7170 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7171 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7172 * data.c (fmod): Likewise.
7173 * dispnew.c (swap_glyphs_in_rows): Likewise.
7174 * emacs.c (memory_warning_signal): Likewise.
7175 * floatfns.c (float_error): Likewise.
7176 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7177 (otf_open, font_otf_capability, generate_otf_features)
7178 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7179 Likewise.
7180 * image.c (pbm_read_file): Likewise.
7181 * indent.c (string_display_width): Likewise.
7182 * intervals.c (check_for_interval, search_for_interval)
7183 (inc_interval_count, count_intervals, root_interval)
7184 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7185 * lread.c (defalias): Likewise.
268c2c36 7186 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7187 * regex.c (set_image_of_range_1, set_image_of_range)
7188 (regex_grow_registers): Likewise.
7189 * sysdep.c (strerror): Likewise.
7190 * termcap.c (valid_filename_p, tprint, main): Likewise.
7191 * tparam.c (main): Likewise.
7192 * unexhp9k800.c (run_time_remap, save_data_space)
7193 (update_file_ptrs, read_header, write_header, calculate_checksum)
7194 (copy_file, copy_rest, display_header): Likewise.
7195 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7196 Likewise.
7197 * xdisp.c (check_it): Likewise.
7198 * xfaces.c (register_color, unregister_color, unregister_colors):
7199 Likewise.
7200 * xfns.c (print_fontset_result): Likewise.
7201 * xrdb.c (member, fatal, main): Likewise.
7202
99033785
PE
72032011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7204
7205 Fix minor problems found by static checking (Bug#9031).
7206 * chartab.c (char_table_set_range, map_sub_char_table):
7207 Remove unused locals.
7208 (uniprop_table): Now static.
7209 * composite.c (_work_char): Remove unused static var.
7210
9cb2ac56
JB
72112011-07-09 Juanma Barranquero <lekktu@gmail.com>
7212
7213 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7214
f25661f0
JD
72152011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7216
7217 * gtkutil.c (qttip_cb): Remove code without function.
7218
8278c4fe
EZ
72192011-07-09 Eli Zaretskii <eliz@gnu.org>
7220
7221 * w32.c (pthread_sigmask): New stub.
7222
1692ae2d 72232011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7224
8a6ebd58 7225 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7226 sigprocmask is portable only for single-threaded applications, and
7227 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7228 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7229 (LIBES): Use it.
7230 * callproc.c (Fcall_process):
7231 * process.c (create_process):
7232 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7233 Use pthread_sigmask, not sigprocmask.
123403e4 7234
1b854618
JD
72352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7236
7237 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7238 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7239 wrong (Bug#8591).
7240
3fe4b549
JD
72412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7242
0ce7e563
JD
7243 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7244 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7245 (xg_hide_tooltip): Fix comment.
7246
3fe4b549
JD
7247 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7248 in registerServicesMenuSendTypes.
7249 (validRequestorForSendType): Don't check ns_return_types.
7250
7251 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7252 ns_return_type.
7253
5df75e47
JR
72542011-07-08 Jason Rumney <jasonr@gnu.org>
7255
22610910
JR
7256 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7257 SH_SHOW for hidden windows (Bug#5482).
7258
5df75e47
JR
7259 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7260 frame struct members of non-existent frames (Bug#6284).
7261
699c10bd
JD
72622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7263
4393663b
JD
7264 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7265 variable firstTime not needed on OSX >= 10.6.
7266 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7267 >= 10.5. Use setKnobProportion, setDoubleValue.
7268
7269 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7270 (MAC_OS_X_VERSION_10_5): Define if not defined.
7271 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7272 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7273 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7274
7275 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7276 cString and lossyCString on OSX >= 10.4
7277
58179cce 7278 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7279 sizeToFit on OSX >= 10.2.
7280
7281 * nsimage.m (allocInitFromFile): Don't use deprecated method
7282 bestRepresentationForDevice on OSX >= 10.6.
7283
7284 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7285 to avoid warning.
7286
7287 * emacs.c: Declare unexec_init_emacs_zone.
7288
a63e0781
JD
7289 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7290
699c10bd
JD
7291 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7292
7293 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7294 on svcsMenu (Bug#8842).
7295
7296 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7297 ns_return_types.
7298 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7299
7300 * nsterm.m (QUTF8_STRING): Declare.
7301 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7302 (validRequestorForSendType): Return type is (id).
7303 Change indexOfObjectIdenticalTo to indexOfObject.
7304 Check if we have local selection before returning self (Bug#8842).
7305 (writeSelectionToPasteboard): Put local selection into paste board
7306 if we have a local selection (Bug#8842).
7307 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7308
7309 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7310 (ns_get_local_selection): Declare.
7311
54e10184
LMI
73122011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7313
9888ff71
LMI
7314 * keymap.c (describe_map_tree): Don't insert a double newline at
7315 the end of the buffer (bug#1169) and return whether we inserted
7316 something.
7317
54e10184
LMI
7318 * callint.c (Fcall_interactively): Change "reading args" to
7319 "providing args" to try to clarify what it does (bug#1010).
7320
15fa4783
KH
73212011-07-07 Kenichi Handa <handa@m17n.org>
7322
7323 * composite.c (composition_compute_stop_pos): Ignore a static
7324 composition starting before CHARPOS (Bug#8915).
7325
7326 * xdisp.c (handle_composition_prop): Likewise.
7327
a8815b00
EZ
73282011-07-07 Eli Zaretskii <eliz@gnu.org>
7329
7330 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7331 (Bug#9015)
7332
ef7b981d 73332011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7334
7335 * character.h (unicode_category_t): New enum type.
7336
7337 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7338 (Qchar_code_property_table): New variable.
7339 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7340 (UNIPROP_COMPRESSED_FORM_P): New macros.
7341 (char_table_ascii): Uncompress the compressed values.
7342 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7343 Uncompress the compressed values.
ac389d0c 7344 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7345 (char_table_ref_and_range): Uncompress the compressed values.
7346 (sub_char_table_set): New arg is_uniprop. Callers changed.
7347 Uncompress the compressed values.
7348 (sub_char_table_set_range): Args changed. Callers changed.
7349 (char_table_set_range): Adjuted for the above change.
7350 (map_sub_char_table): Delete args default_val and parent. Add arg
7351 top. Give decoded values to a Lisp function.
640c8776 7352 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7353 values to a Lisp function. Gcpro more variables.
7354 (uniprop_table_uncompress)
7355 (uniprop_decode_value_run_length): New functions.
7356 (uniprop_decoder, uniprop_decoder_count): New variables.
7357 (uniprop_get_decoder, uniprop_encode_value_character)
7358 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7359 New functions.
7360 (uniprop_encoder, uniprop_encoder_count): New variables.
7361 (uniprop_get_encoder, uniprop_table)
7362 (Funicode_property_table_internal, Fget_unicode_property_internal)
7363 (Fput_unicode_property_internal): New functions.
7364 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7365 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7366 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7367 char-code-property-alist.
7368
640c8776 7369 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7370 Vunicode_category_table.
7371
640c8776 7372 * font.c (font_range): Adjust for the change of
c805dec0
KH
7373 Vunicode_category_table.
7374
76b397fb
DN
73752011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7376
7377 * m/iris4d.h: Remove file, move contents ...
7378 * s/irix6-5.h: ... here.
7379
22b4128e
PE
73802011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7381
7382 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7383 * alloc.c (mark_buffer):
7384 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7385 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7386 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7387 This isn't true in general, and it's particularly not true
7388 if Emacs is configured with --with-wide-int.
7389 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7390 New macros, used in the buffer.c change.
7391
869795d6
JD
73922011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7393
7394 * xsettings.c: Use both GConf and GSettings if both are available.
7395 (store_config_changed_event): Add comment.
7396 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7397 (store_tool_bar_style_changed): New functions.
5e617bc2 7398 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7399 (struct xsettings): Move font inside HAVE_XFT.
7400 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7401 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7402 Move inside HAVE_XFT.
640c8776 7403 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7404 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7405 also.
7406 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7407 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7408 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7409 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7410 (parse_settings): Move check for font inside HAVE_XFT.
7411 (read_settings, apply_xft_settings): Add comment.
7412 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7413 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7414 call store_font_name_changed.
7415 (xft_settings_event): Add comment.
7416 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7417 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7418 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7419 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7420 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7421 (xsettings_get_system_font, xsettings_get_system_normal_font):
7422 Add comment.
869795d6 7423
d8ed26bd
PE
74242011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7425
7426 Random fixes. E.g., (random) never returned negative values.
7427 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7428 subseconds part to the entropy, as that's a bit more random.
7429 Prefer signed to unsigned, since the signedness doesn't matter and
7430 in general we prefer signed. When given a limit, use a
7431 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7432 latter isn't right if USE_2_TAGS_FOR_INTS.
7433 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7434 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7435
cabf1cac
SM
74362011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7437
7438 * textprop.c (text_property_stickiness):
7439 Obey Vtext_property_default_nonsticky.
7440 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7441 * w32fns.c (syms_of_w32fns):
7442 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7443
6e9b2be9
PE
74442011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7445
7446 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7447 This is more efficient than Ffile_directory_p and avoids a minor race.
7448
90186c68
LMI
74492011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7450
7c301272
LMI
7451 * buffer.c (Foverlay_put): Say what the return value is
7452 (bug#7835).
7453
c4f2d8d4
LMI
7454 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7455 is a directory before asking whether to use the file name
7456 (bug#7564).
ad637907
LMI
7457 (barf_or_query_if_file_exists): Make the "File is a directory"
7458 error be more correct.
c4f2d8d4 7459
90186c68
LMI
7460 * fns.c (Frequire): Remove the mention of the .gz files, since
7461 that's installation-specific, but keep the mention of
7462 `get-load-suffixes'.
7463
da64016e
PE
74642011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7465
7466 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7467 Report string overflow if the output is too long.
7468
7d47b580
JB
74692011-07-04 Juanma Barranquero <lekktu@gmail.com>
7470
a555cb87
JB
7471 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7472 (syms_of_gnutls): Remove duplicate DEFSYM for
7473 Qgnutls_bootprop_verify_hostname_error, an error for
7474 Qgnutls_bootprop_verify_error (which is no longer used).
7475
7d47b580
JB
7476 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7477 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7478 Also (re)move comments that are misplaced or no longer relevant.
7479
1e49bfab
LMI
74802011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7481
7482 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7483
1485f4c0
CY
74842011-07-03 Chong Yidong <cyd@stupidchicken.com>
7485
7486 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7487 and background color parameters if they have been changed.
7488
a9ab721e
LMI
74892011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7490
7491 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7492
cf7cff57
PE
74932011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7494
2e13213d
PE
7495 * xsettings.c (SYSTEM_FONT): Define only when used.
7496 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7497
cf7cff57
PE
7498 * keymap.c (access_keymap_1): Now static.
7499
7a8e04f7
CY
75002011-07-02 Chong Yidong <cyd@stupidchicken.com>
7501
7502 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7503 leave any prefix arg for the up event (Bug#1586).
7504
61352f62
LMI
75052011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7506
69bb1ef7
LMI
7507 * lread.c (syms_of_lread): Mention single symbols defined by
7508 `defvar' or `defconst' (bug#7154).
7509
61352f62 7510 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7511 (Frequire): Mention get-load-suffixes.
61352f62 7512
28545e04
MR
75132011-07-02 Martin Rudalics <rudalics@gmx.at>
7514
7515 * window.h (window): Remove clone_number slot.
7516 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7517 Remove.
7518 (make_parent_window, make_window, saved_window)
7519 (Fset_window_configuration, save_window_save): Don't deal with
7520 clone numbers.
7521 * buffer.c (Qclone_number): Remove declaration.
7522 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7523
3349e122
SM
75242011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7525
7526 Add multiple inheritance to keymaps.
7527 * keymap.c (Fmake_composed_keymap): New function.
7528 (Fset_keymap_parent): Simplify.
7529 (fix_submap_inheritance): Remove.
7530 (access_keymap_1): New function extracted from access_keymap to handle
7531 embedded parents and handle lists of maps.
7532 (access_keymap): Use it.
7533 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7534 (Fcopy_keymap): Handle embedded parents.
7535 (Fcommand_remapping, define_as_prefix): Simplify.
7536 (Fkey_binding): Simplify.
7537 (syms_of_keymap): Move minibuffer-local-completion-map,
7538 minibuffer-local-filename-completion-map,
7539 minibuffer-local-must-match-map, and
7540 minibuffer-local-filename-must-match-map to Elisp.
7541 (syms_of_keymap): Defsubr make-composed-keymap.
7542 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7543 (parse_menu_item): Trivial simplification.
7544
3279eb87
GM
75452011-07-01 Glenn Morris <rgm@gnu.org>
7546
7547 * Makefile.in (SETTINGS_LIBS): Fix typo.
7548
4550efdf
KI
75492011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7550
7551 * coding.c (Fencode_coding_string): Record the last coding system
7552 used, as the function doc string says (bug#8738).
7553
0949d2b6
JD
75542011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7555
7556 * xsettings.c (store_monospaced_changed): Take new font as arg and
7557 check for change against current_mono_font.
7558 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7559 (emacs_settings_constructor, emacs_settings_get_property)
7560 (emacs_settings_set_property, emacs_settings_class_init)
7561 (emacs_settings_init, gsettings_obj): Remove.
7562 (something_changedCB): New function for HAVE_GSETTINGS.
7563 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7564 with value as argument.
7565 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7566 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7567 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7568 "changed".
7569
7570 * xgselect.c: Add defined (HAVE_GSETTINGS).
7571 (xgselect_initialize): Ditto.
7572
7573 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7574 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7575 xg_select.
7576
bbc6b304
PE
75772011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7578
7579 * eval.c (struct backtrace): Simplify and port the data structure.
7580 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7581 signed bit field, as this assumption is not portable and it makes
7582 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7583 "char debug_on_exit : 1" as this is not portable either; instead,
7584 use the portable "unsigned int debug_on_exit : 1". Remove unused
7585 member evalargs. Remove obsolete comments about cc bombing out.
7586
9851bfc5
JD
75872011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7588
51bb811f 7589 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7590 Let HAVE_GSETTINGS override HAVE_GCONF.
7591 (store_monospaced_changed): New function.
7592 (EMACS_SETTINGS): A new type derived from GObject to handle
7593 GSettings notifications.
7594 (emacs_settings_constructor, emacs_settings_get_property)
7595 (emacs_settings_set_property, emacs_settings_class_init):
7596 New functions.
7597 (gsettings_client, gsettings_obj): New variables.
7598 (GSETTINGS_SCHEMA): New define.
7599 (something_changedCB): Call store_monospaced_changed.
7600 (init_gsettings): New function.
7601 (xsettings_initialize): Call init_gsettings.
7602 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7603 to NULL.
7604
640c8776 7605 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7606 GCONF_CFLAGS/LIBS.
7607
5386012d
MR
76082011-06-29 Martin Rudalics <rudalics@gmx.at>
7609
7610 * window.c (resize_root_window, grow_mini_window)
7611 (shrink_mini_window): Rename Qresize_root_window to
7612 Qwindow_resize_root_window and Qresize_root_window_vertically to
7613 Qwindow_resize_root_window_vertically.
7614
f13e0b08
PE
76152011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7616
7617 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7618
94515237
JB
76192011-06-27 Juanma Barranquero <lekktu@gmail.com>
7620
7621 * makefile.w32-in: Redesign dependencies so they reflect more
7622 clearly which files are directly included by each source file,
7623 and not through other includes.
7624
e43b6e43
MR
76252011-06-27 Martin Rudalics <rudalics@gmx.at>
7626
7627 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7628 (sort_overlays, overlay_strings): When an overlay's clone number
7629 matches the window's clone number process the overlay even if
7630 the overlay's window property doesn't match the current window.
7631
d68443dc
MR
7632 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7633 (Fwindow_hchild): Rename to Fwindow_left_child.
7634 (Fwindow_next): Rename to Fwindow_next_sibling.
7635 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7636 (resize_window_check): Rename to window_resize_check.
7637 (resize_window_apply): Rename to window_resize_apply.
7638 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7639 (Fdelete_other_windows_internal, resize_frame_windows)
7640 (Fsplit_window_internal, Fdelete_window_internal)
7641 (grow_mini_window, shrink_mini_window)
7642 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7643
c7e73be5
JD
76442011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7645
7646 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7647 (emacs_fixed_set_min_size): Remove.
7648 (emacs_fixed_new): Take frame as argument.
7649
7650 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7651 (_EmacsFixedPrivate): Remove minwidth/height.
7652 Add struct frame *f.
7653 (emacs_fixed_init): Initialize priv->f.
7654 (get_parent_class, emacs_fixed_set_min_size): Remove.
7655 (emacs_fixed_new): Set priv->f to argument.
7656 (emacs_fixed_get_preferred_width)
7657 (emacs_fixed_get_preferred_height): Use min_width/height from
7658 frames size_hint to set minimum and natural (Bug#8919).
7659 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7660 and use min_width/height from frames size_hint to set
7661 min_width/height (Bug#8919).
7662
7663 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7664 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7665 Fix indentation.
c7e73be5 7666
cf99dcf8
EZ
76672011-06-26 Eli Zaretskii <eliz@gnu.org>
7668
7669 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7670 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7671 called at ZV.
7672
029529ac
CY
76732011-06-26 Chong Yidong <cyd@stupidchicken.com>
7674
7675 * process.c (wait_reading_process_output): Bypass select if
7676 waiting for a cell while ignoring keyboard input, and input is
7677 pending. Suggested by Jan Djärv (Bug#8869).
7678
7a7ef429
PE
76792011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7680
7681 Use gnulib's dup2 module instead of rolling our own.
7682 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7683
11fdef7d 76842011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7685
7686 * dispnew.c (scrolling_window): Before scrolling, turn off a
7687 mouse-highlight in the window being scrolled.
7688
cd3520a4
JB
76892011-06-24 Juanma Barranquero <lekktu@gmail.com>
7690
7691 Move DEFSYM to lisp.h and use everywhere.
7692
7693 * character.h (DEFSYM): Move declaration...
7694 * lisp.h (DEFSYM): ...here.
7695
7696 * gnutls.c:
7697 * minibuf.c:
7698 * w32menu.c:
7699 * w32proc.c:
7700 * w32select.c: Don't include character.h.
7701
7702 * alloc.c (syms_of_alloc):
7703 * buffer.c (syms_of_buffer):
7704 * bytecode.c (syms_of_bytecode):
7705 * callint.c (syms_of_callint):
7706 * casefiddle.c (syms_of_casefiddle):
7707 * casetab.c (init_casetab_once):
7708 * category.c (init_category_once, syms_of_category):
7709 * ccl.c (syms_of_ccl):
7710 * cmds.c (syms_of_cmds):
7711 * composite.c (syms_of_composite):
7712 * dbusbind.c (syms_of_dbusbind):
7713 * dired.c (syms_of_dired):
7714 * dispnew.c (syms_of_display):
7715 * doc.c (syms_of_doc):
7716 * editfns.c (syms_of_editfns):
7717 * emacs.c (syms_of_emacs):
7718 * eval.c (syms_of_eval):
7719 * fileio.c (syms_of_fileio):
7720 * fns.c (syms_of_fns):
7721 * frame.c (syms_of_frame):
7722 * fringe.c (syms_of_fringe):
7723 * insdel.c (syms_of_insdel):
7724 * keymap.c (syms_of_keymap):
7725 * lread.c (init_obarray, syms_of_lread):
7726 * macros.c (syms_of_macros):
7727 * msdos.c (syms_of_msdos):
7728 * print.c (syms_of_print):
7729 * process.c (syms_of_process):
7730 * search.c (syms_of_search):
7731 * sound.c (syms_of_sound):
7732 * syntax.c (init_syntax_once, syms_of_syntax):
7733 * terminal.c (syms_of_terminal):
7734 * textprop.c (syms_of_textprop):
7735 * undo.c (syms_of_undo):
7736 * w32.c (globals_of_w32):
7737 * window.c (syms_of_window):
7738 * xdisp.c (syms_of_xdisp):
7739 * xfaces.c (syms_of_xfaces):
7740 * xfns.c (syms_of_xfns):
7741 * xmenu.c (syms_of_xmenu):
7742 * xsettings.c (syms_of_xsettings):
7743 * xterm.c (syms_of_xterm): Use DEFSYM.
7744
4228cf16
TZ
77452011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7746
cd3520a4 7747 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7748
7fcccf1e
PE
77492011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7750
7efb4e0e
PE
7751 Integer and buffer overflow fixes (Bug#8873).
7752
ff5844ad
PE
7753 * print.c (printchar, strout): Check for string overflow.
7754 (PRINTPREPARE, printchar, strout):
7755 Don't set size unless allocation succeeds.
7756
90532f02
PE
7757 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7758 for sizes. Check for string overflow more accurately.
7759 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7760
6d84508d
PE
7761 * macros.c: Integer and buffer overflow fixes.
7762 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7763 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7764 Use ptrdiff_t, not int, for sizes.
7765 Don't increment bufsize until after realloc succeeds.
7766 Check for size-calculation overflow.
7767 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7768
437b2cb4
PE
7769 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7770
8b9ac8b4
PE
7771 * lread.c: Integer overflow fixes.
7772 (read_integer): Radix is now EMACS_INT, not int,
7773 to improve quality of diagnostics for out-of-range radices.
7774 Calculate buffer size correctly for out-of-range radices.
7775 (read1): Check for integer overflow in radices, and in
7776 read-circle numbers.
82cb60d3
PE
7777 (read_escape): Avoid int overflow.
7778 (Fload, openp, read_buffer_size, read1)
7779 (substitute_object_recurse, read_vector, read_list, map_obarray):
7780 Use ptrdiff_t, not int, for sizes.
7781 (read1): Use EMACS_INT, not int, for sizes.
20270765 7782 Check for size overflow.
8b9ac8b4 7783
7fcccf1e
PE
7784 * image.c (cache_image): Check for size arithmetic overflow.
7785
bfbbd7e7
PE
7786 * lread.c: Integer overflow issues.
7787 (saved_doc_string_size, saved_doc_string_length)
7788 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7789 Now ptrdiff_t, not int.
7790 (read1): Don't assume doc string length fits in int. Check for
7791 out-of-range doc string lengths.
7792 (read_list): Don't assume file position fits in int.
39019e54 7793 (read_escape): Check for hex character overflow.
bfbbd7e7 7794
4e323265
LL
77952011-06-22 Leo Liu <sdl.web@gmail.com>
7796
7797 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7798 Move to minibuffer.el.
7799
85fece3e
PE
78002011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7801
20b84ce9 7802 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7803 The following patches are for when GLYPH_DEBUG && !XASSERT.
7804 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7805 * dispnew.c (flush_stdout):
7806 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7807 Mark as externally visible.
7808 * dispnew.c (check_window_matrix_pointers): Now static.
7809 * dispnew.c (window_to_frame_vpos):
7810 * xfns.c (unwind_create_frame):
7811 * xterm.c (x_check_font): Remove unused local.
7812 * scroll.c (CHECK_BOUNDS):
7813 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7814 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7815 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7816 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7817 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7818 Now static.
7819 (debug_method_add): Use va_list and vsprintf rather than relying
7820 on undefined behavior with wrong number of arguments.
7821 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7822 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7823 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7824 since we're not interested in debugging glyphs with old libraries.
7825 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7826 GCC 4.6.0's static checking.
7827
0766b489
PE
78282011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7829
31fd4b32
PE
7830 Integer overflow and signedness fixes (Bug#8873).
7831 A few related buffer overrun fixes, too.
7832
b79e8648
PE
7833 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7834
0766b489
PE
7835 * dispextern.h (struct face.stipple):
7836 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7837 (x_bitmap_mask, x_allocate_bitmap_record)
7838 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7839 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7840 (x_create_bitmap_from_xpm_data):
7841 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7842 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7843 (.bitmaps_last):
7844 * xfaces.c (load_pixmap):
7845 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7846 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7847 (.bitmaps_last, struct x_output.icon_bitmap):
7848 Use ptrdiff_t, not int, for bitmap indexes.
7849 (x_allocate_bitmap_record): Check for size overflow.
7850 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7851
b081724f
PE
7852 Use ptrdiff_t, not int, for overlay counts.
7853 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7854 * editfns.c (overlays_around, get_pos_property):
7855 * textprop.c (get_char_property_and_overlay):
7856 * xdisp.c (next_overlay_change, note_mouse_highlight):
7857 * xfaces.c (face_at_buffer_position):
21514da7
PE
7858 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7859 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7860 (Fnext_overlay_change, Fprevious_overlay_change)
7861 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7862 Use ptrdiff_t, not int, for sizes.
21514da7 7863 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7864
3de73e5e
PE
7865 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7866
2606c57b
PE
7867 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7868 (x_session_initialize): Do not assume string length fits in int.
7869
aaafe47a
PE
7870 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7871 This is unlikely, but can occur if DPI is outlandish.
7872
2674ddc8 7873 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7874 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7875
28154962
PE
7876 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7877 * xrdb.c (magic_file_p, search_magic_path):
7878 Omit last arg SUFFIX; it was always 0. All callers changed.
7879 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7880
7de51af5
PE
7881 * xfont.c (xfont_match): Avoid need for strlen.
7882
25ed6cc3
PE
7883 * xfns.c: Don't assume strlen fits in int.
7884 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7885
4eab31dd
PE
7886 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7887 not unsigned long, as we prefer signed integers. All callers changed.
7888 Detect integer overflow in repeat count.
7889 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7890 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7891
171e2a58
PE
7892 * termcap.c: Don't assume sizes fit in int and never overflow.
7893 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7894 (gobble_line): Check for size-calculation overflow.
7895
ad39faca 7896 * minibuf.c (Fread_buffer):
6e5bb2dc 7897 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7898 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7899 Don't assume string length fits in int.
7900
52c61c22 7901 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7902 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7903
b5b8c9e5
PE
7904 * font.c: Don't assume string length fits in int.
7905 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7906 Use ptrdiff_t, not int.
ccd6111c
PE
7907 (font_intern_prop): Don't assume string length fits in int.
7908 Don't assume integer property fits in fixnum.
7909 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7910
882f0d81 7911 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7912 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7913 Reformulate so as not to need the command string.
7914 Invoke gzip -cd rather than gunzip, as it's more portable.
7915 (lock_info_type, lock_file_1, lock_file):
7916 Don't assume pid_t and time_t fit in unsigned long.
7917 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7918 (current_lock_owner): Prefer signed type for sizes.
7919 Use memcpy, not strncpy, where memcpy is what is really wanted.
7920 Don't assume (via atoi) that time_t and pid_t fit in int.
7921 Check for time_t and/or pid_t out of range, e.g., via a network share.
7922 Don't alloca where an auto var works fine.
7923
93f4cf88
PE
7924 * fileio.c: Fix some integer overflow issues.
7925 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7926 Don't assume string length fits in int.
7927 (directory_file_name): Don't assume string length fits in long.
7928 (make_temp_name): Don't assume pid fits in int, or that its print
7929 length is less than 20.
7930
f3e92b69
PE
7931 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7932
1bfdaf10
PE
7933 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7934
35016e9a
PE
7935 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7936
3d1e65a1
PE
7937 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7938 We prefer signed integers, even for size calculations.
7939
0b963a93
PE
7940 * emacs.c: Don't assume string length fits in 'int'.
7941 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7942 (main): Don't invoke strlen when not needed.
7943
573f4b54
PE
7944 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7945 (XD_DEBUG_MESSAGE): Don't waste a byte.
7946
989f33ba
PE
7947 * callproc.c (getenv_internal_1, getenv_internal)
7948 (Fgetenv_internal):
965d34eb
PE
7949 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7950
e4d29b33
PE
7951 * lread.c (invalid_syntax): Omit length argument.
7952 All uses changed. This doesn't fix a bug, but it simplifies the
7953 code away from its former Hollerith-constant appearance, and it's
7954 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7955 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7956
eb49b136
PE
7957 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7958 This didn't break anything, but it didn't help either.
7959 It's confusing to put a bogus integer in a place where the actual
7960 value does not matter.
9f62aeb1 7961 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7962 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7963
15375a22
PE
7964 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7965 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7966 implementation.
b61cc01c
PE
7967 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7968 We prefer signed types, and the value cannot exceed the EMACS_INT
7969 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7970 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7971 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7972 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7973
53b2623d
PE
7974 * indent.c (sane_tab_width): New function.
7975 (current_column, scan_for_column, Findent_to, position_indentation)
7976 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7977 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7978
51cab52b 7979 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7980
f2ed8a70
PE
7981 * lisp.h (lint_assume): New macro.
7982 * composite.c (composition_gstring_put_cache):
7983 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7984
abe80cc6
PE
7985 * editfns.c, insdel.c:
7986 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7987
b02c740e
PE
7988 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7989
ebc96716
PE
7990 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7991
b4e50fa0 7992 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7993 Use much-faster test for byte-length change.
311d5d7c 7994 Don't assume string byte-length fits in 'int'.
a4cf38e4 7995 Check that character arg fits in 'int'.
85461888 7996 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7997
c0c1ee9f
PE
7998 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7999
a498d7f4
PE
8000 * fns.c (concat): Catch string overflow earlier.
8001 Do not rely on integer wraparound.
8002
51cab52b
PE
8003 * dispextern.h (struct it.overlay_strings_charpos)
8004 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8005 * xdisp.c (forward_to_next_line_start)
8006 (back_to_previous_visible_line_start)
8007 (reseat_at_next_visible_line_start, next_element_from_buffer):
8008 Don't arbitrarily truncate the value of 'selective' to int.
8009
76031fad
PE
8010 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8011
5eb55db9
PE
8012 * composite.c: Don't truncate sizes to 'int'.
8013 (composition_gstring_p, composition_reseat_it)
8014 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8015 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8016 not EMACS_UINT, for indexes.
5eb55db9 8017
0703a717
PE
8018 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8019
d6202519
PE
8020 * buffer.c: Include <verify.h>.
8021 (struct sortvec.priority, struct sortstr.priority):
8961a454 8022 Now EMACS_INT, not int.
c20998a7 8023 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8024 (struct sortstr.size, record_overlay_string)
8025 (struct sortstrlist.size, struct sortlist.used):
8026 Don't truncate size to int.
8027 (record_overlay_string): Check for size-calculation overflow.
d6202519 8028 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8029
d5a19415
JM
80302011-06-22 Jim Meyering <meyering@redhat.com>
8031
029529ac 8032 Don't leak an XBM-image-sized buffer
d5a19415
JM
8033 * image.c (xbm_load): Free the image buffer after using it.
8034
a9041e6c
PE
80352011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8036
8037 Port to Sun C.
8038 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8039 that Sun C diagnosed.
8040 * fns.c (secure_hash): Fix pointer signedness issue.
8041 * intervals.c (static_offset_intervals): New function.
8042 (offset_intervals): Use it.
8043
7f3f739f
LL
80442011-06-21 Leo Liu <sdl.web@gmail.com>
8045
8046 * deps.mk (fns.o):
8047 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8048 sha512.h.
8049
8050 * fns.c (secure_hash): Rename from crypto_hash_function and change
8051 the first arg to accept symbols.
5b66d427 8052 (Fsecure_hash): New primitive.
7f3f739f
LL
8053 (syms_of_fns): New symbols.
8054
76147d94
DD
80552011-06-20 Deniz Dogan <deniz@dogan.se>
8056
8057 * process.c (Fset_process_buffer): Clarify return value in
8058 docstring.
8059
7d7d0045
CY
80602011-06-18 Chong Yidong <cyd@stupidchicken.com>
8061
8062 * dispnew.c (add_window_display_history): Use BVAR.
8063
8064 * xdisp.c (debug_method_add): Use BVAR.
8065 (check_window_end, dump_glyph_matrix, dump_glyph)
8066 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8067
8068 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8069 Likewise.
8070
8071 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8072 check till after the cache is created in init_frame_faces.
8073
ff2bc410
SM
80742011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8075
8076 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8077
28177add
PE
80782011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8079
dd3482fe
PE
8080 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8081 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8082 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8083
393d71f3 8084 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8085 * fileio.c (Finsert_file_contents):
8086 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8087 Remove the old (too-loose) buffer overflow checks.
8088 They weren't needed, since make_gap checks for buffer overflow.
8089 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8090 The old code merely checked for Emacs fixnum overflow, and relied
8091 on undefined (wraparound) behavior. The new code avoids undefined
8092 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8093
2e6813b0 8094 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8095 Tune. Don't use wider integers than needed. Don't use alloca.
8096 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8097
599a9e4f
PE
8098 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8099
99561444
PE
8100 * insdel.c, lisp.h (buffer_overflow): New function.
8101 (insert_from_buffer_1, replace_range, replace_range_2):
8102 * insdel.c (make_gap_larger):
8103 * editfns.c (Finsert_char):
8104 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8105
28177add
PE
8106 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8107
e69dafad
PE
81082011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8109
4baa020d 8110 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8111
b1c46f02
PE
8112 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8113 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8114
e69dafad
PE
8115 * fileio.c: Don't assume EMACS_INT fits in off_t.
8116 (emacs_lseek): New static function.
8117 (Finsert_file_contents, Fwrite_region): Use it.
8118 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8119
566684ea
PE
8120 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8121
e6966cd6
PE
8122 * fns.c: Don't overflow int when computing a list length.
8123 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8124 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8125 truncation on 64-bit hosts. Check for QUIT every
8126 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8127 faster and is responsive enough.
8128 (Flength): Report an error instead of overflowing an integer.
8129 (Fsafe_length): Return a float if the value is not representable
8130 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8131 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8132 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8133
dd0b0efb
PE
8134 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8135 (header_size, word_size): New constants.
8136 (allocate_vectorlike): Don't check size overflow here.
8137 (allocate_vector): Check it here instead, since this is the only
8138 caller of allocate_vectorlike that could cause overflow.
8139 Check that the new vector's length is representable as a fixnum.
8140
86fe5cfe
PE
8141 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8142 The previous code was bogus. For example, next_almost_prime (32)
8143 returned 39, which is undesirable as it is a multiple of 3; and
8144 next_almost_prime (24) returned 25, which is a multiple of 5 so
8145 why was the code bothering to check for multiples of 7?
8146
80e88859
PE
8147 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8148
4a2f0ad6
PE
8149 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8150
f66c7cf8
PE
8151 Variadic C functions now count arguments with ptrdiff_t.
8152 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8153 Back then I didn't know that the Emacs coding style prefers signed int.
8154 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8155 were being counted with int, which may truncate counts on 64-bit
8156 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8157 * lisp.h (struct Lisp_Subr.function.aMANY)
8158 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8159 Arg counts are now ptrdiff_t, not size_t.
8160 All variadic functions and their callers changed accordingly.
8161 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8162 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8163 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8164 * callint.c (Fcall_interactively): Check arg count for overflow,
8165 to avoid potential buffer overrun. Use signed char, not 'int',
8166 for 'varies' array, so that we needn't bother to check its size
8167 calculation for overflow.
8168 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8169 * eval.c (apply_lambda):
8170 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8171 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8172 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8173
a1759b76
PE
8174 * callint.c (Fcall_interactively): Don't use index var as event count.
8175
d96be9fc
PE
8176 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8177 * mem-limits.h (SIZE): Remove; no longer used.
8178
a690a978 8179 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8180
578c21e6
PE
8181 Remove unnecessary casts.
8182 * xterm.c (x_term_init):
8183 * xfns.c (x_set_border_pixel):
8184 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8185 These aren't needed now that we assume ANSI C.
8186
96f53c6c
PE
8187 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8188 It's more likely to cause problems (due to unsigned overflow)
8189 than to cure them.
8190
83c77d31
PE
8191 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8192
ee2079f1
PE
8193 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8194
6da65536
PE
8195 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8196
7147c4a4
PE
8197 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8198
193e32d9
PE
8199 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8200
e5533da6
PE
8201 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8202
9910e595
PE
8203 GLYPH_CODE_FACE returns EMACS_INT, not int.
8204 * dispextern.h (merge_faces):
8205 * xfaces.c (merge_faces):
01103c44
PE
8206 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8207 Don't assume EMACS_INT fits in int.
9910e595 8208
2638320e
PE
8209 * character.h (CHAR_VALID_P): Remove unused parameter.
8210 * fontset.c, lisp.h, xdisp.c: All uses changed.
8211
045eb8d9
PE
8212 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8213
c1f134b5
PE
8214 * fns.c (concat): Minor tuning based on overflow analysis.
8215 This doesn't fix any bugs. Use int to hold character, instead
8216 of constantly refetching from Emacs object. Use XFASTINT, not
8217 XINT, for value known to be a character. Don't bother comparing
8218 a single byte to 0400, as it's always less.
8219
395fcb93 8220 * floatfns.c (Fexpt):
327eeec8
PE
8221 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8222
abbd3d23
PE
8223 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8224 for characters.
8225
684a03ef
PE
8226 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8227
0fed43f3
PE
8228 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8229 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8230 incorrectly succeed when S was a string, because 4294967386 was
8231 truncated before it was used.
8232
8fd02eb7
PE
8233 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8234 Otherwise, an out-of-range integer could cause undefined behavior
8235 on a 64-bit host.
8236
f8c86b69
PE
8237 * composite.c: Use int, not EMACS_INT, for characters.
8238 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8239 EMACS_INT, for values that are known to be in character range.
8240 This doesn't fix any bugs but is the usual style inside Emacs and
8241 may generate better code on 32-bit machines.
8242
34206dd2
PE
8243 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8244 This is for reasons similar to the recent CHAR_STRING fix.
8245 * charset.c (Fencode_char): Check that character arg is actually
8246 a character. Pass an int to ENCODE_CHAR.
8247 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8248 wider than 'int', as a compile-time check to prevent future regressions
8249 in this area.
8250
c5958d4c 8251 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8252
8253 Make sure a 64-bit char is never passed to CHAR_STRING.
8254 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8255 by silently ignoring the top 32 bits, allowing some values
8256 that were far too large to be valid characters.
8257 * character.h: Include <verify.h>.
8258 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8259 arguments are no wider than unsigned, as a compile-time check
8260 to prevent future regressions in this area.
8261 * data.c (Faset):
01103c44 8262 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8263 (Fsubst_char_in_region):
8264 * fns.c (concat):
8265 * xdisp.c (decode_mode_spec_coding):
8266 Adjust to CHAR_STRING's new requirement.
8267 * editfns.c (Finsert_char, Fsubst_char_in_region):
8268 * fns.c (concat): Check that character args are actually
8269 characters. Without this test, these functions did the wrong
8270 thing with wildly out-of-range values on 64-bit hosts.
8271
d37ca623
PE
8272 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8273 These casts should not be needed on 32-bit hosts, either.
8274 * keyboard.c (read_char):
8275 * lread.c (Fload): Remove casts to unsigned.
8276
ea204efb
PE
8277 * lisp.h (UNSIGNED_CMP): New macro.
8278 This fixes comparison bugs on 64-bit hosts.
8279 (ASCII_CHAR_P): Use it.
8280 * casefiddle.c (casify_object):
01103c44 8281 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8282 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8283 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8284 * dispextern.h (FACE_FROM_ID):
8285 * keyboard.c (read_char): Use UNSIGNED_CMP.
8286
41cb286c
PE
8287 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8288 not to EMACS_INT, to avoid GCC warning.
8289
4a1b9832
PE
8290 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8291
55daad71
PE
8292 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8293 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8294 isn't needed on 32-bit machines.
8f95c75c 8295
01103c44
PE
8296 * buffer.c (Fgenerate_new_buffer_name):
8297 Use EMACS_INT for count, not int.
0ceccced 8298 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8299
8300 * data.c (Qcompiled_function): Now static.
8301
c6f072e7
PE
8302 * window.c (window_body_lines): Now static.
8303
20ce5912
PE
8304 * image.c (gif_load): Rename local to avoid shadowing.
8305
9c4c5f81
PE
8306 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8307 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8308 * alloc.c (make_save_value): Integer argument is now of type
8309 ptrdiff_t, not int.
8310 (mark_object): Use ptrdiff_t, not int.
8311 * lisp.h (pD): New macro.
8312 * print.c (print_object): Use it.
8313
c0c5c8ae
PE
8314 * alloc.c: Use EMACS_INT, not int, to count objects.
8315 (total_conses, total_markers, total_symbols, total_vector_size)
8316 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8317 (total_free_floats, total_floats, total_free_intervals)
8318 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8319 Now EMACS_INT, not int. All uses changed.
8320 (Fgarbage_collect): Compute overall total using a double, so that
8321 integer overflow is less likely to be a problem. Check for overflow
8322 when converting back to an integer.
5a25e253
PE
8323 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8324 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8325 These were 'int' variables that could overflow on 64-bit hosts;
8326 they were never used, so remove them instead of repairing them.
211a0b2a 8327 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8328 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8329 Previously, this ceilinged at INT_MAX, but that doesn't work on
8330 64-bit machines.
e46bb31a 8331 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8332
c78baabf 8333 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8334 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8335 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8336 when a (possibly-narrower) signed value would do just as well.
8337 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8338
c9d624c6
PE
8339 * alloc.c: Catch some string size overflows that we were missing.
8340 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8341 for convenience in STRING_BYTES_MAX.
8342 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8343 The definition here is exact; the one in lisp.h was approximate.
8344 (allocate_string_data): Check for string overflow. This catches
8345 some instances we weren't catching before. Also, it catches
8346 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8347 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8348 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8349
c9d624c6
PE
8350 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8351 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8352 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8353
353032ce
PE
8354 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8355
2bccce07
PE
8356 * alloc.c (Fmake_string): Check for out-of-range init.
8357
0ac30604
SM
83582011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8359
8360 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8361
c195f2de
JD
83622011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8363
8364 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8365 xg_get_default_scrollbar_width.
8366
8367 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8368 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8369 (style_changed_cb): Call update_theme_scrollbar_width and call
8370 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8371 all frames (Bug#8505).
8372 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8373 Call gtk_window_set_resizable if HAVE_GTK3.
8374 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8375 and height if HAVE_GTK3 (Bug#8505).
8376 (scroll_bar_width_for_theme): New variable.
8377 (update_theme_scrollbar_width): New function.
8378 (xg_get_default_scrollbar_width): Move code to
8379 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8380 (xg_initialize): Call update_theme_scrollbar_width.
8381
8382 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8383
8384 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8385
e10ac9f1
MR
83862011-06-12 Martin Rudalics <rudalics@gmx.at>
8387
8388 * frame.c (make_frame): Call other_buffer_safely instead of
8389 other_buffer.
8390
8391 * window.c (temp_output_buffer_show): Call display_buffer with
8392 second argument Vtemp_buffer_show_specifiers and reset latter
8393 immediately after the call.
8394 (Vtemp_buffer_show_specifiers): New variable.
8395 (auto_window_vscroll_p, next_screen_context_lines)
8396 (Vscroll_preserve_screen_position): Remove leading asterisks from
8397 doc-strings.
8398
2d3c217e 83992011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8400
7b7f97e8 8401 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8402 * buffer.c (Qclone_number): Remove for now, as it's unused.
8403 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8404 (record_buffer): Remove unused local.
8405 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8406 (set_frame_buffer_list): Remove; unused.
8407 * frame.h (other_visible_frames): Remove decl.
8408 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8409 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8410 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8411 if HAVE_GPM.
8412 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8413 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8414 Define only if HAVE_GPM.
8415 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8416 (update_hints_inhibit): Remove; never set. All uses removed.
8417 * widgetprv.h (emacsFrameClassRec): Remove decl.
8418 * window.c (delete_deletable_window): Now returns void, since it
8419 wasn't returning anything.
8420 (compare_window_configurations): Remove unused locals.
8421 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8422 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8423 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8424 the same widths as pointers. This follows up on the 2011-05-06 patch.
8425 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8426 * xterm.h: Likewise.
8427 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8428
1384b89e
JB
84292011-06-12 Juanma Barranquero <lekktu@gmail.com>
8430
8431 * makefile.w32-in: Update dependencies.
8432 (LISP_H): Add lib/intprops.h.
8433
1100a63c
CY
84342011-06-11 Chong Yidong <cyd@stupidchicken.com>
8435
8436 * image.c (gif_load): Add animation frame delay to the metadata.
8437 (syms_of_image): Use DEFSYM. New symbol `delay'.
8438
6198ccd0
MR
84392011-06-11 Martin Rudalics <rudalics@gmx.at>
8440
8441 * window.c (delete_deletable_window): Re-add.
8442 (Fset_window_configuration): Rewrite to handle dead buffers and
8443 consequently deletable windows.
8444 (window_tree, Fwindow_tree): Remove. Supply functionality in
8445 window.el.
8446 (compare_window_configurations): Simplify code.
8447
b6e3633c
AS
84482011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8449
1ab0dee5
AS
8450 * image.c (imagemagick_load_image): Fix type mismatch.
8451 (Fimagemagick_types): Likewise.
8452
b6e3633c
AS
8453 * window.h (replace_buffer_in_windows): Declare.
8454
9397e56f
MR
84552011-06-11 Martin Rudalics <rudalics@gmx.at>
8456
8457 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8458 Qclone_number. Remove external declaration of Qdelete_window.
8459 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8460 code.
640c8776
SM
8461 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8462 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8463 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8464 buffer list implementation.
8465 (other_buffer_safely): New function.
8466 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8467 calls to replace_buffer_in_windows and
8468 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8469 if allowed.
8470 (record_buffer): Inhibit quitting and rewrite using quittable
8471 functions. Run Qbuffer_list_update_hook if allowed.
8472 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8473 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8474 Move switch-to-buffer to window.el.
9397e56f
MR
8475 (bury-buffer): Move to window.el.
8476 (Vbuffer_list_update_hook): New variable.
8477
8478 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8479 section.
8480
8481 * window.h (resize_frame_windows): Move up in code.
8482 (Fwindow_frame): Remove EXFUN.
8483 (replace_buffer_in_all_windows): Remove prototype.
8484 (replace_buffer_in_windows_safely): Add prototype.
8485
8486 * window.c: Declare Qdelete_window static again. Move down
8487 declaration of select_count.
8488 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8489 (Fother_window): Move to window.el.
8490 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8491 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8492 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8493 window.el.
8494 (replace_buffer_in_windows): Implement by calling
8495 Qreplace_buffer_in_windows.
8496 (replace_buffer_in_all_windows): Remove with some functionality
8497 moved into replace_buffer_in_windows_safely.
8498 (replace_buffer_in_windows_safely): New function.
8499 (select_window_norecord, select_frame_norecord): Move in front
8500 of run_window_configuration_change_hook. Remove now obsolete
8501 declarations.
640c8776
SM
8502 (Fset_window_buffer): Rewrite doc-string.
8503 Call Qrecord_window_buffer.
9397e56f
MR
8504 (keys_of_window): Move binding for other-window to window.el.
8505
b50691aa
CY
85062011-06-11 Chong Yidong <cyd@stupidchicken.com>
8507
8508 * dispextern.h (struct image): Replace data member, whose int_val
8509 and ptr_val fields were not used by anything, with a single
8510 lisp_val object.
8511
8512 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8513 (gif_clear_image, gif_load, imagemagick_load_image)
8514 (gs_clear_image, gs_load): Callers changed.
8515
3f754b86
PE
85162011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8517
cca69397
PE
8518 * buffer.h: Include <time.h>, for time_t.
8519 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8520
109e28d0
PE
8521 Fix minor problems found by static checking.
8522
60737f02
PE
8523 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8524
4b66faf3
PE
8525 Make identifiers static if they are not used in other modules.
8526 * data.c (Qcompiled_function, Qframe, Qvector):
8527 * image.c (QimageMagick, Qsvg):
8528 * minibuf.c (Qmetadata):
8529 * window.c (resize_window_check, resize_root_window): Now static.
8530 * window.h (resize_window_check, resize_root_window): Remove decls.
8531
109e28d0
PE
8532 * window.c (window_deletion_count, delete_deletable_window):
8533 Remove; unused.
46a4ce9e
PE
8534 (window_body_lines): Now static.
8535 (Fdelete_other_windows_internal): Mark vars as initialized.
8536 Make sure 'resize_failed' is initialized.
8537 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8538 (resize_window_apply): Remove unused local.
8539 * window.h (delete_deletable_window): Remove decl.
8540
109e28d0 8541 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8542 (imagemagick_load_image): Fix pointer signedness problem by changing
8543 last arg from unsigned char * to char *. All uses changed.
8544 Also, fix a local for similar reasons.
8545 Remove unused locals. Remove locals to avoid shadowing.
8546 (fn_rsvg_handle_free): Remove; unused.
8547 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8548 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8549
3f754b86
PE
8550 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8551
2547adb1
CY
85522011-06-10 Chong Yidong <cyd@stupidchicken.com>
8553
8554 * image.c (gif_load): Fix omitted cast error introduced by
8555 2011-06-06 change.
8556
2c8e37d4
MR
85572011-06-10 Martin Rudalics <rudalics@gmx.at>
8558
8559 * window.h (resize_proportionally, orig_total_lines)
8560 (orig_top_line): Remove from window structure.
8561 (set_window_height, set_window_width, change_window_heights)
8562 (Fdelete_window): Remove prototypes.
8563 (resize_frame_windows): Remove duplicate declaration.
8564
440a42e3
EZ
85652011-06-10 Eli Zaretskii <eliz@gnu.org>
8566
8567 * window.h (resize_frame_windows, resize_window_check)
8568 (delete_deletable_window, resize_root_window)
8569 (resize_frame_windows): Declare prototypes.
8570
8571 * window.c (resize_window_apply): Make definition be "static" to
8572 match the prototype.
8573
562dd5e9
MR
85742011-06-10 Martin Rudalics <rudalics@gmx.at>
8575
8576 * window.c: Remove declarations of Qwindow_size_fixed,
8577 window_min_size_1, window_min_size_2, window_min_size,
8578 size_window, window_fixed_size_p, enlarge_window, delete_window.
8579 Remove static from declaration of Qdelete_window, it's
8580 temporarily needed by Fbury_buffer.
8581 (replace_window): Don't assign orig_top_line and
8582 orig_total_lines.
8583 (Fdelete_window, delete_window): Remove. Window deletion is
8584 handled by window.el.
640c8776
SM
8585 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8586 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8587 (Fdelete_other_windows): Remove. Deleting other windows is
8588 handled by window.el.
8589 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8590 handled in window.el.
8591 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8592 Window minimum sizes are handled in window.el.
8593 (shrink_windows, size_window, set_window_height)
8594 (set_window_width, change_window_heights, window_height)
8595 (window_width, CURBEG, CURSIZE, enlarge_window)
8596 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8597 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8598 handled in window.el.
8599 (make_dummy_parent): Rename to make_parent_window and give it a
8600 second argument horflag.
8601 (make_window): Don't set resize_proportionally any more.
8602 (Fsplit_window): Remove. Windows are split in window.el.
8603 (save_restore_action, save_restore_orig_size)
8604 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8605 Resize mini windows in window.el.
8606 (grow_mini_window, shrink_mini_window): Implement by calling
8607 Qresize_root_window_vertically, resize_window_check and
8608 resize_window_apply.
640c8776
SM
8609 (saved_window, Fset_window_configuration, save_window_save):
8610 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8611 resize_proportionally.
8612 (window_min_height, window_min_width): Move to window.el.
8613 (keys_of_window): Move bindings for delete-other-windows,
8614 split-window, delete-window and enlarge-window to window.el.
8615
8616 * buffer.c: Temporarily extern Qdelete_window.
8617 (Fbury_buffer): Temporarily call Qdelete_window instead of
8618 Fdelete_window (Fbury_buffer will move to window.el soon).
8619
8620 * frame.c (set_menu_bar_lines_1): Remove code handling
8621 orig_top_line and orig_total_lines.
8622
8623 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8624 set_window_height but set heights directly.
8625 (change_frame_size_1): Use resize_frame_windows.
8626
8627 * xdisp.c (init_xdisp): Don't use set_window_height but set
8628 heights directly.
8629
640c8776
SM
8630 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8631 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8632 run_window_configuration_change_hook.
8633
8634 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8635 instead of change_window_heights and run
8636 run_window_configuration_change_hook.
8637
1a13852e
MR
86382011-06-09 Martin Rudalics <rudalics@gmx.at>
8639
8640 * window.c (replace_window): Rename second argument REPLACEMENT to
8641 NEW. New third argument SETFLAG. Rewrite.
8642 (delete_window, make_dummy_parent): Call replace_window with
8643 third argument 1.
8644 (window_list_1): Move down in code.
8645 (run_window_configuration_change_hook): Move set_buffer part
8646 before select_frame_norecord part in order to unwind correctly.
8647 Rename count1 to count.
8648 (recombine_windows, delete_deletable_window, resize_root_window)
8649 (Fdelete_other_windows_internal)
8650 (Frun_window_configuration_change_hook, make_parent_window)
8651 (resize_window_check, resize_window_apply, Fresize_window_apply)
8652 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8653 (Fdelete_window_internal, Fresize_mini_window_internal):
8654 New functions.
1a13852e
MR
8655 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8656
f3d1777e
MR
86572011-06-08 Martin Rudalics <rudalics@gmx.at>
8658
496e208e
MR
8659 * window.h (window): Add some new members to window structure -
8660 normal_lines, normal_cols, new_total, new_normal, clone_number,
8661 splits, nest, prev_buffers, next_buffers.
8662 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8663 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8664
f3d1777e
MR
8665 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8666 Remove.
496e208e
MR
8667 (make_dummy_parent): Set new members of windows structure.
8668 (make_window): Move down in code. Handle new members of window
8669 structure.
8670 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8671 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8672 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8673 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8674 (Fset_window_next_buffers, Fset_window_clone_number):
8675 New functions.
496e208e
MR
8676 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8677 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8678 Doc-string fixes.
8679 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8680 Argument WINDOW can be now internal window too.
8681 (Fwindow_use_time): Move up in code.
8682 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8683 Rewrite doc-string.
8684 (Fset_window_configuration, saved_window)
8685 (Fcurrent_window_configuration, save_window_save): Handle new
8686 members of window structure.
b9e809c2
MR
8687 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8688 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8689 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8690 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8691 Qget_mru_window, Qresize_root_window,
8692 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8693 Qauto_buffer_name; staticpro them.
f3d1777e 8694
abde8f8c
MR
86952011-06-07 Martin Rudalics <rudalics@gmx.at>
8696
8697 * window.c (Fwindow_total_size, Fwindow_left_column)
8698 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8699 (Fwindow_list_1): New functions.
8700 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8701 (Fwindow_width, Fscroll_left, Fscroll_right):
8702 Use window_body_cols instead of window_box_text_cols.
8703 (delete_window, Fset_window_configuration):
8704 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8705 (delete_all_subwindows): Take a window as argument and not a
8706 structure. Rewrite.
190b47e6
MR
8707 (window_loop): Remove handling of GET_LRU_WINDOW and
8708 GET_LARGEST_WINDOW.
8709 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8710
8711 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8712 window_box_text_cols. delete_all_subwindows now takes a
8713 Lisp_Object as argument.
abde8f8c 8714
640c8776
SM
8715 * indent.c (compute_motion, Fcompute_motion):
8716 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8717
fa8a67e6
MR
8718 * frame.c (delete_frame): Call delete_all_subwindows with root
8719 window as argument.
8720
a54e3482
DC
87212011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8722
8723 * fns.c (Fputhash): Document return value.
8724
60002bf5
CY
87252011-06-06 Chong Yidong <cyd@stupidchicken.com>
8726
8727 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8728
0c671da6 87292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8730
b862a52a 8731 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8732
be44ca6c
PE
8733 Check for overflow when converting integer to cons and back.
8734 * charset.c (Fdefine_charset_internal, Fdecode_char):
8735 Use cons_to_unsigned to catch overflow.
8736 (Fencode_char): Use INTEGER_TO_CONS.
8737 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8738 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8739 * data.c (long_to_cons, cons_to_long): Remove.
8740 (cons_to_unsigned, cons_to_signed): New functions.
8741 These signal an error for invalid or out-of-range values.
8742 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8743 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8744 * font.c (Ffont_variation_glyphs):
8745 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8746 * lisp.h: Include <intprops.h>.
8747 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8748 (cons_to_signed, cons_to_unsigned): New decls.
8749 (long_to_cons, cons_to_long): Remove decls.
8750 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8751 (Fprimitive_undo): Use CONS_TO_INTEGER.
8752 * xfns.c (Fx_window_property): Likewise.
8753 * xselect.c: Include <limits.h>.
8754 (x_own_selection, selection_data_to_lisp_data):
8755 Use INTEGER_TO_CONS.
8756 (x_handle_selection_request, x_handle_selection_clear)
8757 (x_get_foreign_selection, Fx_disown_selection_internal)
8758 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8759 (lisp_data_to_selection_data): Use cons_to_unsigned.
8760 (x_fill_property_data): Use cons_to_signed.
8761 Report values out of range.
8762
d1f3d2af
PE
8763 Check for buffer and string overflow more precisely.
8764 * buffer.h (BUF_BYTES_MAX): New macro.
8765 * lisp.h (STRING_BYTES_MAX): New macro.
8766 * alloc.c (Fmake_string):
8767 * character.c (string_escape_byte8):
8768 * coding.c (coding_alloc_by_realloc):
8769 * doprnt.c (doprnt):
8770 * editfns.c (Fformat):
8771 * eval.c (verror):
8772 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8773 since they may not be the same number.
8774 * editfns.c (Finsert_char):
8775 * fileio.c (Finsert_file_contents):
8776 Likewise for BUF_BYTES_MAX.
8777
dd52fcea
PE
8778 * image.c: Use ptrdiff_t, not int, for sizes.
8779 (slurp_file): Switch from int to ptrdiff_t.
8780 All uses changed.
8781 (slurp_file): Check that file size fits in both size_t (for
8782 malloc) and ptrdiff_t (for sanity and safety).
8783
7f9bbdbb
PE
8784 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8785 if b->modtime has its maximal value.
8786
dfe18f82
PE
8787 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8788
84acfcf0
PE
8789 Don't assume time_t can fit into int.
8790 * buffer.h (struct buffer.modtime): Now time_t, not int.
8791 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8792 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8793
ccd9a01a
PE
8794 Minor fixes for signed vs unsigned integers.
8795 * character.h (MAYBE_UNIFY_CHAR):
8796 * charset.c (maybe_unify_char):
8797 * keyboard.c (read_char, reorder_modifiers):
8798 XINT -> XFASTINT, since the integer must be nonnegative.
8799 * ftfont.c (ftfont_spec_pattern):
8800 * keymap.c (access_keymap, silly_event_symbol_error):
8801 XUINT -> XFASTINT, since the integer must be nonnegative.
8802 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8803 since it makes no difference and we prefer signed.
8804 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8805 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8806 nonnegative.
8807
d6d100dd
SM
88082011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8809
8810 * window.h (Fwindow_frame): Declare.
8811
2b6148e4
PE
88122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8813
8814 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8815 (SPARE_MEMORY): Always define.
8816 (LARGE_REQUEST): Remove.
8817 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8818
f230ecc9
MR
88192011-06-06 Martin Rudalics <rudalics@gmx.at>
8820
727e958e
MR
8821 * lisp.h: Move EXFUNS for Fframe_root_window,
8822 Fframe_first_window and Fset_frame_selected_window to window.h.
8823
8824 * window.h: Move EXFUNS for Fframe_root_window,
8825 Fframe_first_window and Fset_frame_selected_window here from
8826 lisp.h.
8827
8828 * frame.c (Fwindow_frame, Fframe_first_window)
8829 (Fframe_root_window, Fframe_selected_window)
8830 (Fset_frame_selected_window): Move to window.c.
8831 (Factive_minibuffer_window): Move to minibuf.c.
8832 (Fother_visible_frames_p): New function.
8833
8834 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8835
f230ecc9
MR
8836 * window.c (decode_window, decode_any_window): Move up in code.
8837 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8838 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8839 (Fwindow_buffer): Move up and rewrite doc-string.
8840 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8841 (Fwindow_prev): New functions.
727e958e
MR
8842 (Fwindow_frame): Move here from frame.c. Accept any window as
8843 argument.
8844 (Fframe_root_window, Fframe_first_window)
8845 (Fframe_selected_window): Move here from frame.c. Accept frame
8846 or arbitrary window as argument. Update doc-strings.
8847 (Fminibuffer_window): Move up in code.
8848 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8849 (Fset_frame_selected_window): Move here from frame.c.
8850 Marginal rewrite.
727e958e
MR
8851 (Fselected_window, select_window, Fselect_window): Move up in
8852 code. Minor doc-string fixes.
f230ecc9 8853
4d09bcf6
PE
88542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8855
8856 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8857 Do not assume that spare memory exists; that assumption is valid
8858 only if SYSTEM_MALLOC.
8859 (LARGE_REQUEST): New macro, so that the issue of large requests
8860 is separated from the issue of spare memory.
8861
810928a2
AS
88622011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8863
172418ad
AS
8864 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8865 format. (Bug#8806)
8866
43f862f7
AS
8867 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8868
810928a2
AS
8869 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8870 before statements.
8871
a059fe24
JD
88722011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8873
8874 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8875
8876 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8877
8878 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8879 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8880
989bf368
JB
88812011-06-05 Juanma Barranquero <lekktu@gmail.com>
8882
8883 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8884
4b80f674
CY
88852011-06-04 Chong Yidong <cyd@stupidchicken.com>
8886
8887 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8888 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8889 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8890 New error handlers.
4b80f674
CY
8891 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8892 Obey Vx_select_enable_clipboard_manager. Catch errors in
8893 x_clipboard_manager_save (Bug#8779).
8894 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8895 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8896
99a33b77 88972011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8898
8899 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8900
99a33b77 89012011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8902
8903 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8904 in the current matrix if keep_current_p is non-zero.
8905
8264569d
EZ
89062011-06-04 Eli Zaretskii <eliz@gnu.org>
8907
8908 * bidi.c (bidi_level_of_next_char): Fix last change.
8909
57f97249
EZ
89102011-06-03 Eli Zaretskii <eliz@gnu.org>
8911
fec2107c 8912 Support bidi reordering of text covered by display properties.
57f97249 8913
fec2107c
EZ
8914 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8915 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8916 (bidi_cache_search, bidi_cache_iterator_state)
8917 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8918 (bidi_level_of_next_char, bidi_move_to_visually_next):
8919 Support character positions inside a run of characters covered by a
fec2107c
EZ
8920 display string.
8921 (bidi_paragraph_init, bidi_resolve_explicit_1)
8922 (bidi_level_of_next_char): Call bidi_fetch_char and
8923 bidi_fetch_char_advance instead of FETCH_CHAR and
8924 FETCH_CHAR_ADVANCE.
8925 (bidi_init_it): Initialize new members.
8926 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8927 definitions.
8928 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8929 instead of using explicit *_CHAR codes.
d6d100dd
SM
8930 (bidi_resolve_explicit, bidi_resolve_weak):
8931 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8932 bidirectional text is supported only in multibyte buffers.
8933 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8934 it to initialize the frame_window_p member of struct bidi_it.
8935 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8936 (bidi_resolve_explicit, bidi_resolve_weak)
8937 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8938 bidi_it->nchars is non-positive.
8939 (bidi_level_of_next_char): Don't try to lookup the cache for the
8940 next/previous character if nothing is cached there yet, or if we
8941 were just reseat()'ed to a new position.
c40e2fb2 8942
0e14fe90
EZ
8943 * xdisp.c (set_cursor_from_row): Set start and stop points
8944 according to the row's direction when priming the loop that looks
8945 for the glyph on which to display cursor.
8946 (single_display_spec_intangible_p): Function deleted.
8947 (display_prop_intangible_p): Reimplement to call
8948 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8949 Accept 3 additional arguments needed by handle_display_spec.
8950 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8951 values: lists, `(when COND...)' forms, etc.
8952 (single_display_spec_string_p): Support property values that are
8953 lists with the argument STRING its top-level element.
8954 (display_prop_string_p): Fix the condition for processing a
8955 property that is a list to be consistent with handle_display_spec.
fec2107c 8956 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8957 last portion of handle_display_prop.
8958 (compute_display_string_pos): Accept additional argument
8959 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8960 value of a `display' property is a "replacing spec".
8961 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8962 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8963 the display property, but just return a value indicating whether
8964 the display property will replace the characters it covers.
8965 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8966 frame_window_p members of struct bidi_it.
d6d100dd
SM
8967 (compute_display_string_pos, compute_display_string_end):
8968 New functions.
fec2107c
EZ
8969 (push_it): Accept second argument POSITION, where pop_it should
8970 jump to continue iteration.
8971 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8972
fec2107c
EZ
8973 * keyboard.c (adjust_point_for_property): Adjust the call to
8974 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8975
8976 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8977 (bidi_init_it): Update prototypes.
8978 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8979 (compute_display_string_pos, compute_display_string_end):
8980 Declare prototypes.
fec2107c
EZ
8981 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8982 EMACS_INT.
fc6f18ce 8983
40087514 89842011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8985
57f53182
PE
8986 Malloc failure behavior now depends on size of allocation.
8987 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8988 * lisp.h: Change signatures accordingly.
8989 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8990 All callers changed. (Bug#8762)
8991
8992 * gnutls.c: Use Emacs's memory allocators.
8993 Without this change, the gnutls library would invoke malloc etc.
8994 directly, which causes problems on non-SYNC_INPUT hosts, and which
8995 runs afoul of improving memory_full behavior. (Bug#8761)
8996 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8997 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8998 xfree instead of the default malloc, realloc, free.
8999 (Fgnutls_boot): No need to check for memory allocation failure,
9000 since xmalloc does that for us.
9001
ac32cd99 9002 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9003 * category.c (hash_get_category_set):
9004 * ccl.c (ccl_driver):
9005 * charset.c (Fdefine_charset_internal):
9006 * charset.h (struct charset.hash_index):
9007 * composite.c (get_composition_id, gstring_lookup_cache)
9008 (composition_gstring_put_cache):
9009 * composite.h (struct composition.hash_index):
9010 * dispextern.h (struct image.hash):
9011 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9012 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9013 (hashfn_equal, hashfn_user_defined, make_hash_table)
9014 (maybe_resize_hash_table, hash_lookup, hash_put)
9015 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9016 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9017 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9018 * image.c (make_image, search_image_cache, lookup_image)
9019 (xpm_put_color_table_h):
9020 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9021 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9022 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9023 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9024 * alloc.c (allocate_vectorlike):
9025 Check for overflow in vector size calculations.
9026 * ccl.c (ccl_driver):
9027 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9028 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9029 need to be updated by these changes.
40087514
PE
9030 * fns.c (make_hash_table, maybe_resize_hash_table):
9031 Check for integer overflow with large hash tables.
0de4bb68
PE
9032 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9033 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9034 (SXHASH_REDUCE): New macro.
9035 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9036 Use it instead of discarding useful hash info with large hash values.
9037 (sxhash_float): New function.
9038 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9039 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9040 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9041 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9042 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9043 Adjust signatures to match updated version of code.
9044 (consing_since_gc): Now EMACS_INT, since a single hash table can
9045 use more than INT_MAX bytes.
9046
698d32e2
DN
90472011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9048
9049 Make it possible to build with GCC-4.6+ -O2 -flto.
9050
9051 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9052
fd6fa53f
SM
90532011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9054
9055 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9056 Call minibuffer-inactive-mode.
9057
864db017
JB
90582011-05-31 Juanma Barranquero <lekktu@gmail.com>
9059
9060 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9061 Update dependencies.
9062
2ad0baf4
DN
90632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9064
9065 * data.c (init_data): Remove code for UTS, this system is not
9066 supported anymore.
9067
4fcc2638
DN
90682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9069
9070 Don't force ./temacs to start in terminal mode.
9071
9072 * frame.c (make_initial_frame): Initialize faces in all cases, not
9073 only when CANNOT_DUMP is defined.
9074 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9075
c56e0fd5
DN
90762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9077
9078 * dispnew.c (add_window_display_history): Use const for the string
9079 pointer. Remove declaration, not needed.
9080
333d54da 90812011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9082
55d4c1b2 9083 Use 'inline', not 'INLINE'.
333d54da 9084 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9085 * alloc.c, fontset.c (INLINE): Remove.
9086 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9087 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9088 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9089 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9090 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9091
738db178
DN
90922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9093
9094 Make it possible to run ./temacs.
9095
9096 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9097 syms_of_callproc does the same thing. Remove test for
9098 "initialized", do it in the caller.
9099 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9100
620c53a6
SM
91012011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9102
9103 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9104 (read_minibuf): Use get_minibuffer.
9105 (syms_of_minibuf): Use DEFSYM.
9106 (Qmetadata): New var.
9107 * data.c (Qbuffer): Don't make it static.
9108 (syms_of_data): Use DEFSYM.
9109
e003a292
PE
91102011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9111
9112 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9113 (CCL_CODE_MIN): New macro.
9114
ed008a6d
PE
91152011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9116
3687c2ef
PE
9117 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9118
ed008a6d
PE
9119 * eval.c (Qdebug): Now static.
9120 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9121 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9122 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9123
d66c4c7c
CY
91242011-05-29 Chong Yidong <cyd@stupidchicken.com>
9125
9126 * image.c: Various fixes to ImageMagick code comments.
9127 (Fimagemagick_types): Doc fix.
9128
5fbc2025
PE
91292011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9130
0196f88a
PE
9131 Minor fixes prompted by GCC 4.6.0 warnings.
9132
9133 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9134
5fbc2025
PE
9135 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9136 (x_clipboard_manager_save_all): Move extern decl to ...
9137 * xterm.h: ... here, so that it can be checked for consistency.
9138
1dd3c2d9
CY
91392011-05-29 Chong Yidong <cyd@stupidchicken.com>
9140
9141 * xselect.c (x_clipboard_manager_save_frame)
9142 (x_clipboard_manager_save_all): New functions.
9143 (Fx_clipboard_manager_save): Lisp function deleted.
9144
9145 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9146 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9147
9148 * xterm.h: Update prototype.
9149
5ba6571d
WX
91502011-05-28 William Xu <william.xwl@gmail.com>
9151
9152 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9153 exiting (Bug#8239).
9154
3eaff834
JM
91552011-05-28 Jim Meyering <meyering@redhat.com>
9156
e1900994 9157 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9158 * fns.c (to_uchar): Define.
9159 (crypto_hash_function): Use it to convert some newly-signed
9160 variables to unsigned, to avoid sign-extension bugs. For example,
9161 without this change, (md5 "truc") would evaluate to
9162 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9163 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9164 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9165
0f6990a7
PE
91662011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9167
9168 Integer overflow fixes.
c8a9ca5a 9169
08686060
PE
9170 * dbusbind.c: Serial number integer overflow fixes.
9171 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9172 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9173 to hold a serial number that is too large for a fixnum.
9174 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9175 Check for serial numbers out of range. Decode any serial number
59568bf0 9176 that was so large that it became a float. (Bug#8722)
08686060 9177
2d1fc3c7
PE
9178 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9179 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9180 Use XFASTINT rather than XUINT when numbers are nonnegative.
9181 (xd_append_arg, Fdbus_method_return_internal):
9182 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9183 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9184 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9185 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9186 (Bug#8722)
2d1fc3c7 9187
c8a9ca5a
PE
9188 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9189
519e1d69
PE
9190 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9191
6df6ae42 9192 ccl: Add integer overflow checks.
30569699
PE
9193 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9194 (IN_INT_RANGE): New macros.
9195 (ccl_driver): Use them to check for integer overflow when
9196 decoding a CCL program. Many of the new checks are whether XINT (x)
9197 fits in int; it doesn't always, on 64-bit hosts. The new version
9198 doesn't catch all possible integer overflows, but it's an
847044ea 9199 improvement. (Bug#8719)
30569699 9200
c11285dc
PE
9201 * alloc.c (make_event_array): Use XINT, not XUINT.
9202 There's no need for unsigned here.
9203
fdccd48e
PE
9204 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9205 This follows up to the 2011-05-06 change that substituted uintptr_t
9206 for EMACS_INT. This case wasn't caught back then.
9207
37910ab2
PE
9208 Rework Fformat to avoid integer overflow issues.
9209 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9210 now (part of C89). Include <verify.h>.
9211 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9212 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9213 (Fformat): Avoid the prepass trying to compute sizes; it was only
9214 approximate and thus did not catch overflow reliably. Instead, walk
9215 through the format just once, formatting and computing sizes as we go,
9216 checking for integer overflow at every step, and allocating a larger
9217 buffer as needed. Keep track separately whether the format is
9218 multibyte. Keep only the most-recently calculated precision, rather
9219 than them all. Record whether each argument has been converted to
9220 string. Use EMACS_INT, not int, for byte and char and arg counts.
9221 Support field widths and precisions larger than INT_MAX. Avoid
9222 sprintf's undefined behavior with conversion specifications such as %#d
9223 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9224 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9225 formatting out-of-range floating point numbers with int
9173deec 9226 formats. (Bug#8668)
37910ab2 9227
2e6578fb
PE
9228 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9229
0ae6bdee
PE
9230 * data.c: Avoid integer truncation in expressions involving floats.
9231 * data.c: Include <intprops.h>.
9232 (arith_driver): When there's an integer overflow in an expression
9233 involving floating point, convert the integers to floating point
9234 so that the resulting value does not suffer from catastrophic
9235 integer truncation. For example, on a 64-bit host (* 4
9236 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9237 Do not rely on undefined behavior after integer overflow.
9238
de883a70
PE
9239 merge count_size_as_multibyte, parse_str_to_multibyte
9240 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9241 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9242 Check for integer overflow.
9243 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9244 since it's now a duplicate of the other. This is more of
9245 a character than a buffer op, so better that it's in character.c.
9246 * fns.c, print.c: Adjust to above changes.
9247
2ff916cb
PE
92482011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9249
9250 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9251
f1b54466
PE
92522011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9253
fb1ac845
PE
9254 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9255 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9256 (x_clipboard_manager_save): Now static.
9257 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9258
f1b54466
PE
9259 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9260 (crypto_hash_function): Now static.
9261 Fix pointer signedness problems. Avoid unnecessary initializations.
9262
a9f737ee
CY
92632011-05-27 Chong Yidong <cyd@stupidchicken.com>
9264
9265 * termhooks.h (Vselection_alist): Make it terminal-local.
9266
9267 * terminal.c (create_terminal): Initialize it.
9268
9269 * xselect.c: Support for clipboard managers.
9270 (Vselection_alist): Move to termhooks.h as terminal-local var.
9271 (LOCAL_SELECTION): New macro.
9272 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9273 (symbol_to_x_atom): Remove gratuitous arg.
9274 (x_handle_selection_request, lisp_data_to_selection_data)
9275 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9276 (x_own_selection, x_get_local_selection, x_convert_selection):
9277 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9278 (some_frame_on_display): Delete unused function.
9279 (Fx_own_selection_internal, Fx_get_selection_internal)
9280 (Fx_disown_selection_internal, Fx_selection_owner_p)
9281 (Fx_selection_exists_p): New optional frame arg.
9282 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9283 (x_handle_selection_clear): Don't treat other terminals with the
9284 same keyboard specially. Use the terminal-local Vselection_alist.
9285 (x_clear_frame_selections): Use Frun_hook_with_args.
9286
9287 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9288
9289 * xterm.h: Add support for those atoms.
9290
e067f0c1
CY
92912011-05-26 Chong Yidong <cyd@stupidchicken.com>
9292
9293 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9294 (converted_selections, conversion_fail_tag): New global variables.
9295 (x_selection_request_lisp_error): Free the above.
9296 (x_get_local_selection): Remove unnecessary code.
9297 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9298 of converted selections stored in converted_selections.
9299 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9300 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9301 (x_convert_selection): New function.
9302 (x_handle_selection_event): Simplify.
9303 (x_get_foreign_selection): Don't ignore incoming requests while
9304 waiting for an answer; this will fail when we implement
9305 SAVE_TARGETS, and seems unnecessary anyway.
9306 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9307 (Vx_sent_selection_functions): Doc fix.
9308
0f4aebc0
LL
93092011-05-26 Leo Liu <sdl.web@gmail.com>
9310
9311 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9312
e61124cd
YM
93132011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9314
9315 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9316
9317 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9318 for fringe update if it has periodic bitmap.
ac389d0c 9319 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9320 and fringe_bitmap_periodic_p.
9321
9322 * fringe.c (get_fringe_bitmap_data): New function.
9323 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9324 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9325 row. Mark glyph row for fringe update if periodicity changed.
9326
9327 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9328 for fringe update unless it has periodic bitmap.
9329
f16d9837
KH
93302011-05-25 Kenichi Handa <handa@m17n.org>
9331
9332 * xdisp.c (get_next_display_element): Set correct it->face_id for
9333 a static composition.
9334
e1b90ef6
LL
93352011-05-24 Leo Liu <sdl.web@gmail.com>
9336
9337 * deps.mk (fns.o):
9338 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9339
9340 * fns.c (crypto_hash_function, Fsha1): New function.
9341 (Fmd5): Use crypto_hash_function.
9342 (syms_of_fns): Add Ssha1.
9343
7400048f
PE
93442011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9345
9346 * gnutls.c: Remove unused macros.
9347 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9348 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9349 Remove macros that are defined and never used.
9350 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9351
abb71cf4
CY
93522011-05-22 Chong Yidong <cyd@stupidchicken.com>
9353
9354 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9355 (Fx_get_selection_internal): Minor cleanup.
9356 (Fx_own_selection_internal): Rename arguments for consistency with
9357 select.el.
9358
6307db39
PE
93592011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9360
9361 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9362
f3d4e0a4
CY
93632011-05-22 Chong Yidong <cyd@stupidchicken.com>
9364
9365 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9366
4d8ade89
YM
93672011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9368
9369 * dispnew.c (scrolling_window): Don't exclude the case that the
9370 last enabled row in the desired matrix touches the bottom boundary.
9371
32078c8d
GM
93722011-05-21 Glenn Morris <rgm@gnu.org>
9373
9374 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9375 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9376 and add some more files.
32078c8d 9377
7285dc67
EZ
93782011-05-20 Eli Zaretskii <eliz@gnu.org>
9379
9380 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9381 report_file_error introduced by the change from 2011-05-07.
9382
89d1bd22
PE
93832011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9384
9385 * systime.h (Time): Define only if emacs is defined.
9386 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9387 where the include path doesn't have X11/X.h by default. See
9388 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9389
cd394be1 93902011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9391
9392 * composite.c (find_automatic_composition): Fix previous change.
9393
b9704ad9
GM
93942011-05-20 Glenn Morris <rgm@gnu.org>
9395
9396 * lisp.mk: New file, split from Makefile.in.
9397 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9398 (shortlisp): Remove.
9399 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9400
4a720484
GM
94012011-05-19 Glenn Morris <rgm@gnu.org>
9402
9403 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9404 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9405 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9406 (lisp): Set the order to that of loadup.el.
9407 (shortlisp): Make it a copy of $lisp.
9408 (SOME_MACHINE_LISP): Remove.
9409 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9410 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9411
a28d4396
KH
94122011-05-18 Kenichi Handa <handa@m17n.org>
9413
9414 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9415 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9416 (find_automatic_composition): Mostly rewrite for efficiency.
9417
a2b1fa8e
JB
94182011-05-18 Juanma Barranquero <lekktu@gmail.com>
9419
9420 * makefile.w32-in: Update dependencies.
9421
8e1f5610
CS
94222011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9423
9424 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9425 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9426
7025ee00 94272011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9428
cdfa6eab
PE
9429 Fix some integer overflow issues, such as string length overflow.
9430
06d6db33
PE
9431 * insdel.c (count_size_as_multibyte): Check for string overflow.
9432
2b4560a8
PE
9433 * character.c (lisp_string_width): Check for string overflow.
9434 Use EMACS_INT, not int, for string indexes and lengths; in
9435 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9436 the resulting string length overflows an EMACS_INT; instead,
9437 report a string overflow if no precision given. When checking for
9438 precision exhaustion, use a check that cannot possibly have
9439 integer overflow. (Bug#8675)
9440 * character.h (lisp_string_width): Adjust to new signature.
9441
cb93f9be
PE
9442 * alloc.c (string_overflow): New function.
9443 (Fmake_string): Use it. This doesn't change behavior, but saves
9444 a few bytes and will simplify future changes.
9445 * character.c (string_escape_byte8): Likewise.
9446 * lisp.h (string_overflow): New decl.
9447
1a1f3366
PE
9448 Fixups, following up to the user-interface timestamp change.
9449 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9450 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9451 * msdos.c (mouse_get_pos): Likewise.
9452 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9453 * w32gui.h (Time): Define by including "systime.h" rather than by
9454 declaring it ourselves. (Bug#8664)
9455
d4e3e4d3
PE
9456 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9457 * image.c (clear_image_cache): Likewise.
9458
f6a24d19
PE
9459 * term.c (term_mouse_position): Don't assume time_t wraparound.
9460
08dc5ae6
PE
9461 Be more systematic about user-interface timestamps.
9462 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9463 and sometimes 'EMACS_UINT', to represent these timestamps.
9464 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9465 This makes the code easier to follow, and makes it easier to catch
9466 integer overflow bugs such as Bug#8664.
9467 * frame.c (Fmouse_position, Fmouse_pixel_position):
9468 Use Time, not unsigned long, for user-interface timestamps.
9469 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9470 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9471 * keyboard.h (last_event_timestamp): Likewise.
9472 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9473 * menu.h (xmenu_show): Likewise.
9474 * term.c (term_mouse_position): Likewise.
9475 * termhooks.h (struct input_event.timestamp): Likewise.
9476 (struct terminal.mouse_position_hook): Likewise.
9477 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9478 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9479 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9480 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9481 what it was before.
9482 * menu.h, termhooks.h: Include "systime.h", for Time.
9483
8e55734a
PE
9484 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9485 Don't assume that the difference between two unsigned long values
9486 can fit into an integer. At this point, we know button_down_time
9487 <= event->timestamp, so the difference must be nonnegative, so
9488 there's no need to cast the result if double-click-time is
9489 nonnegative, as it should be; check that it's nonnegative, just in
9490 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9491 apart (about 25 days). (Bug#8664)
8e55734a 9492
841f1b75 9493 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9494 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9495
3e26f69c
PE
9496 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9497 that always fit in int. Use a sentinel instead of a counter, to
9498 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9499 * frame.h (struct frame): Use int for menu_bar_items_used
9500 instead of EMACS_INT, since it always fits in int.
3e26f69c 9501
5cc152c0
PE
9502 * menu.c (grow_menu_items): Check for int overflow.
9503
d89eb65e
PE
9504 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9505
5235bd3e
PE
9506 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9507 Before, the code was not consistent. These values cannot exceed
9508 2**31 - 1 so there's no need to make them unsigned.
9509 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9510 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9511 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9512 as modifiers.
9513 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9514
bc827e23
PE
9515 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9516 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9517 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9518 presumably because the widths might not match.
9519
78eb494e
PE
9520 * window.c (size_window): Avoid needless test at loop start.
9521
04f2d78b
CB
95222011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9523
9524 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9525
d2fc7e3d 95262011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9527
9528 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9529
d2fc7e3d 95302011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9531
9532 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9533 `width' to `bar_area_x' and `bar_area_width', respectively.
9534 (x_scroll_run): Take account of fringe background extension.
9535
04f2d78b
CB
9536 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9537 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9538 `bar_area_width', respectively.
9539 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9540 background extension.
9541
79b70037
GM
95422011-05-10 Jim Meyering <meyering@redhat.com>
9543
9544 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9545
2f142cc5
JB
95462011-05-10 Juanma Barranquero <lekktu@gmail.com>
9547
9548 * image.c (Finit_image_library): Return t for built-in image types,
9549 like pbm and xbm. (Bug#8640)
9550
57679c86
AS
95512011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9552
9553 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9554
888c9e86
EZ
95552011-05-07 Eli Zaretskii <eliz@gnu.org>
9556
b0512a1d
EZ
9557 * w32console.c (Fset_screen_color): Doc fix.
9558 (Fget_screen_color): New function.
9559 (syms_of_ntterm): Defsubr it.
9560
7285dc67
EZ
9561 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9562 unlink the temporary file if Fcall_process didn't create it in the
9563 first place.
9564 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9565 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9566 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9567 cue to call_process_cleanup not to close that handle.
9568
4d3fcc8e
BK
95692011-05-07 Ben Key <bkey76@gmail.com>
9570
9571 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9572 one of two shell specific rules, either bootstrap-temacs-CMD or
9573 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9574 to the previous implementation of the bootstrap-temacs rule.
9575 The bootstrap-temacs-CMD rule is similar to the previous
9576 implementation of the bootstrap-temacs rule except that it
9577 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9578 variable.
9579
9580 These changes, along with some changes to nt/configure.bat,
9581 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9582 earlier fix to add support for --cflags and --ldflags options
9583 that include quotes so that it works whether make uses cmd or
9584 sh as the shell.
9585
b4289b64
MA
95862011-05-06 Michael Albinus <michael.albinus@gmx.de>
9587
9588 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9589 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9590 is a constant.
9591 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9592 a string. Handle both cases.
9593 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9594 (Fdbus_register_method): Use Qinvalid_function.
9595
af4c0e28
JB
95962011-05-06 Juanma Barranquero <lekktu@gmail.com>
9597
9598 * makefile.w32-in: Update dependencies.
9599 (LISP_H): Add inttypes.h and stdin.h.
9600 (PROCESS_H): Add unistd.h.
9601
c51453d9
EZ
96022011-05-06 Eli Zaretskii <eliz@gnu.org>
9603
9604 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9605 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9606
8ff0ac3c 96072011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9608
4c4b566b
PE
9609 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9610
aab2b9b5
PE
9611 * term.c (vfatal): Remove stray call to va_end.
9612 It's not needed and the C Standard doesn't allow it here anyway.
9613
c378da0b
PE
9614 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9615 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9616
288b08c7
PE
9617 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9618 bytes.
9619
e3601888
PE
9620 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9621
db6c0e74
PE
9622 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9623
dd5963ea
PE
9624 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9625
88c9450f
PE
9626 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9627
2f9442b8
PE
9628 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9629
c032b5f8
PE
9630 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9631 * charset.c (Fdefine_charset_internal): Don't initialize
9632 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9633 32-bit int (Bug#8600).
a108c10b
PE
9634
9635 * lread.c (read_integer): Be more consistent with string-to-number.
9636 Use string_to_number to do the actual conversion; this avoids
9637 rounding errors and fixes some other screwups. Without this fix,
9638 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9639 (digit_to_number): Move earlier, for benefit of read_integer.
9640 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9641 not a digit in any supported base. (Bug#8602)
a108c10b 9642
ad5f9eea
PE
9643 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9644
aec1708a
PE
9645 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9646 to match comment at start of function. This also removes a
9647 GCC warning about overflow in a 32+64-bit port.
9648
47be4ab5
PE
9649 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9650
371cac43
PE
9651 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9652 Reported by Stefan Monnier in
9653 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9654 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9655 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9656
d01a7826
PE
9657 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9658 (EMACS_UINTPTR): Likewise, with uintptr_t.
9659
7fd47d5c
PE
9660 * lisp.h: Prefer 64-bit EMACS_INT if available.
9661 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9662 on 32-bit hosts that have 64-bit int, so that they can access
9663 large files.
122b0c86
PE
9664 However, temporarily disable this change unless the temporary
9665 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9666
8727937b
PE
9667 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9668
8ac068ac
PE
9669 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9670 This removes an assumption that EMACS_INT and long are the same
9671 width as pointers. The assumption is true for Emacs porting targets
9672 now, but we want to make other targets possible.
9673 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9674 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9675 In the rest of the code, change types of integers that hold casted
9676 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9677 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9678 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9679 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9680 No need to cast type when ORing.
9681 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9682 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9683 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9684 assume EMACS_INT is the same width as char *.
9685 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9686 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9687 Remove no-longer-needed casts.
9688 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9689 (xg_tool_bar_help_callback, xg_make_tool_item):
9690 Use EMACS_INTPTR to hold an integer
9691 that will be cast to void *; this can avoid a GCC warning
9692 if EMACS_INT is not the same width as void *.
9693 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9694 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9695 (current_message_1, set_message_1):
9696 Use a local to convert to proper width without a cast.
9697 * xmenu.c (dialog_selection_callback): Likewise.
9698
ede49d71
PE
9699 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9700 Also, don't assume VALBITS / RAND_BITS is less than 5,
9701 and don't rely on undefined behavior when shifting a 1 left into
9702 the sign bit.
9703 * lisp.h (get_random): Change signature to match.
9704
2f30ecd0
PE
9705 * lread.c (hash_string): Use size_t, not int, for hash computation.
9706 Normally we prefer signed values; but hashing is special, because
9707 it's better to use unsigned division on hash table sizes so that
9708 the remainder is nonnegative. Also, size_t is the natural width
9709 for hashing into memory. The previous code used 'int', which doesn't
9710 retain enough info to hash well into very large tables.
9711 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9712
2a866e7b
PE
9713 * dbusbind.c: Don't possibly lose pointer info when converting.
9714 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9715 Use XPNTR rather than XHASH, so that the high-order bits of
9716 the pointer aren't lost when converting through void *.
9717
51639eac
PE
9718 * eval.c (Fautoload): Don't double-shift a pointer.
9719
92394119
PE
9720 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9721
dbdb9a7c
JB
97222011-05-06 Juanma Barranquero <lekktu@gmail.com>
9723
9724 * gnutls.c (DEF_GNUTLS_FN):
9725 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9726
db7a0b4f
AS
97272011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9728
9729 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9730 marker. (Bug#8610)
9731
cd394be1 97322011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9733
9734 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9735 New version that can reserve upto 2GB of heap space.
9736
f7ff1b0f 97372011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9738
9739 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9740
639c109b
TZ
97412011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9742
9743 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9744 `gnutls_certificate_set_x509_key_file'.
9745
d2127135
JB
97462011-05-05 Juanma Barranquero <lekktu@gmail.com>
9747
9748 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9749 Update dependencies.
9750
e968f4f3
JB
97512011-05-04 Juanma Barranquero <lekktu@gmail.com>
9752
9753 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9754 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9755 Remove unused parameter `fildes'.
9756 * process.c (read_process_output, send_process): Don't pass it.
9757
84d358f0
JB
97582011-05-04 Juanma Barranquero <lekktu@gmail.com>
9759
9760 Fix previous change: the library cache is defined in w32.c.
9761 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9762 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9763
0898ca10
JB
97642011-05-04 Juanma Barranquero <lekktu@gmail.com>
9765
9766 Implement dynamic loading of GnuTLS on Windows.
9767
9768 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9769 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9770 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9771 Declare.
9772
9773 * gnutls.c (Qgnutls_dll): Define.
9774 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9775 (gnutls_*): Declare function pointers.
9776 (init_gnutls_functions): New function to initialize function pointers.
9777 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9778 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9779 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9780 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9781 (emacs_gnutls_write, emacs_gnutls_read)
9782 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9783 (Fgnutls_available_p): New function.
9784 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9785 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9786 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9787
9788 * image.c: Include w32.h.
9789 (Vimage_type_cache): Delete.
9790 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9791 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9792 (w32_delayed_load): Move to w32.c.
9793
9794 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9795
9796 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9797 (w32_delayed_load): Move from image.c. When loading a library, record
9798 its filename in the :loaded-from property of the library id.
9799 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9800 Initialize and staticpro them.
9801 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9802
9803 * process.c: Include lisp.h before w32.h, not after.
9804 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9805 instead of gnutls_record_check_pending.
9806
9807 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9808
ff4de4aa
TZ
98092011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9810
9811 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9812 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9813 as passed in.
9814
abe95abb
JD
98152011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9816
9817 * xterm.c (x_set_frame_alpha): Do not set property on anything
9818 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9819
e16e55d4
JB
98202011-05-02 Juanma Barranquero <lekktu@gmail.com>
9821
9822 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9823
bafcf6a5
JB
98242011-05-02 Juanma Barranquero <lekktu@gmail.com>
9825
9826 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9827 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9828 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9829 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9830 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9831 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9832 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9833 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9834 (Qgnutls_bootprop_callbacks_verify): Make static.
9835
e7a6747f
AS
98362011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9837
19ed11ba
AS
9838 * callproc.c: Indentation fixup.
9839
e7a6747f 9840 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9841 (wait_for_termination, interruptible_wait_for_termination):
9842 Move after wait_for_termination_1.
e7a6747f 9843
1ef14cb4
LMI
98442011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9845
9846 * sysdep.c (interruptible_wait_for_termination): New function
9847 which is like wait_for_termination, but allows keyboard
9848 interruptions.
9849
9850 * callproc.c (Fcall_process): Add (:file "file") as an option for
9851 the STDOUT buffer.
9852 (Fcall_process_region): Ditto.
9853
330d880c
EZ
98542011-04-30 Eli Zaretskii <eliz@gnu.org>
9855
8db90b73
EZ
9856 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9857 rather than `XVECTOR (FOO)->size'.
9858
330d880c
EZ
9859 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9860 inttypes.h, as a gnulib replacement is used if it not available in
9861 system headers.
9862
15cbd324
EZ
98632011-04-21 Eli Zaretskii <eliz@gnu.org>
9864
9865 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9866 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9867 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9868
9869 * coding.c (coding_alloc_by_realloc): Error out if destination
9870 will grow beyond MOST_POSITIVE_FIXNUM.
9871 (decode_coding_emacs_mule): Abort if there isn't enough place in
9872 charbuf for the composition carryover bytes. Reserve an extra
9873 space for up to 2 characters produced in a loop.
9874 (decode_coding_iso_2022): Abort if there isn't enough place in
9875 charbuf for the composition carryover bytes.
9876
98772011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9878
ae940cca
EZ
9879 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9880 aborting when %lld or %lll format is passed.
9881 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9882 %llo or %llx format is passed. (Bug#8545)
9883
03ab8921
EZ
9884 * window.c (window_scroll_line_based): Use a marker instead of
9885 simple variables to record original value of point. (Bug#7952)
9886
afda1437
EZ
9887 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9888 produced by %s or %c overflows available buffer space. (Bug#8545)
9889
f76dee0c
PE
98902011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9891
9892 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9893 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9894
fdc5744d
JB
98952011-04-28 Juanma Barranquero <lekktu@gmail.com>
9896
9897 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9898
638f053a
JB
98992011-04-28 Juanma Barranquero <lekktu@gmail.com>
9900
9901 * keyboard.c (Qdelayed_warnings_hook): Define.
9902 (command_loop_1): Run `delayed-warnings-hook'
9903 if Vdelayed_warnings_list is non-nil.
9904 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9905 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9906
d178f871
EZ
99072011-04-28 Eli Zaretskii <eliz@gnu.org>
9908
9909 * doprnt.c (doprnt): Don't return value smaller than the buffer
9910 size if the message was truncated. (Bug#8545).
9911
b124fd93
JB
99122011-04-28 Juanma Barranquero <lekktu@gmail.com>
9913
9914 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9915 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9916
e810457d
PE
99172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9918
9919 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9920
ea51cceb
JB
99212011-04-27 Juanma Barranquero <lekktu@gmail.com>
9922
9923 * makefile.w32-in: Update dependencies.
9924
94dcfacf
EZ
99252011-04-27 Eli Zaretskii <eliz@gnu.org>
9926
9927 Improve `doprnt' and its usage. (Bug#8545)
9928 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9929 `format_end'. Remove support for %l as a conversion specifier.
9930 Don't use xrealloc. Improve diagnostics when the %l size modifier
9931 is used. Update the commentary.
9932
9933 * eval.c (verror): Simplify calculation of size_t.
9934
9935 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9936 messages.
9937
f61f41d7
PE
99382011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9939
9940 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9941 change.
9942
96fb4434
PE
99432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9944
9945 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9946 This makes this file independent of the recent pseudovector change.
9947
671875da 99482011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9949
69e9b5a3
PE
9950 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9951
b5f869a7 9952 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9953 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9954 Remove unused local.
c8926152 9955 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9956
841a1577 9957 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9958 GCC 4.6.0 optimizes based on type-based alias analysis.
9959 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9960 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9961 != &v->size, and therefore "v->size = 1; b->size = 2; return
9962 v->size;" must therefore return 1. This assumption is incorrect
9963 for Emacs, since it type-puns struct Lisp_Vector * with many other
9964 types. To fix this problem, this patch adds a new type struct
f904488f 9965 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9966 and pseudovectors, and helps optimizing compilers not get fooled
9967 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9968 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9969 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9970 the size member.
eab3844f
PE
9971 (XSETPVECTYPE): Rewrite in terms of new macro.
9972 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9973 This is a bit clearer, and further avoids the possibility of
9974 undesirable aliasing.
9975 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9976 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9977 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9978 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9979 (ASIZE): Now uses header.size rather than size.
9980 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9981 to avoid the hassle of writing XVECTOR (foo)->header.size.
9982 (struct vectorlike_header): New type.
eab3844f
PE
9983 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9984 object, to help avoid aliasing.
9985 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9986 (SUBRP): Likewise, since Lisp_Subr is a special case.
9987 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9988 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9989 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9990 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9991 changed to be "header.size" and "header.next".
9992 * buffer.h (struct buffer): Likewise.
9993 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9994 * frame.h (struct frame): Likewise.
9995 * process.h (struct Lisp_Process): Likewise.
9996 * termhooks.h (struct terminal): Likewise.
9997 * window.c (struct save_window_data, struct saved_window): Likewise.
9998 * window.h (struct window): Likewise.
9999 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10000 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10001 * buffer.c (init_buffer_once): Likewise.
10002 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10003 special case.
10004 * process.c (Fformat_network_address): Use local var for size,
10005 for brevity.
10006
0df1eac5
PE
10007 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10008
847ab9d1 10009 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10010 * data.c (atof): Remove decl; no longer used or needed.
10011 (digit_to_number): Move to lread.c.
10012 (Fstring_to_number): Use new string_to_number function, to be
10013 consistent with how the Lisp reader treats infinities and NaNs.
10014 Do not assume that floating-point numbers represent EMACS_INT
10015 without losing information; this is not true on most 64-bit hosts.
10016 Avoid double-rounding errors, by insisting on integers when
10017 parsing non-base-10 numbers, as the documentation specifies.
10018 * lisp.h (string_to_number): New decl, replacing ...
10019 (isfloat_string): Remove.
bc0a5c13 10020 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10021 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10022 appears to have been a coding error. Similarly, do not accept
10023 strings like +-1e0 as floating point numbers. Do not report
10024 overflow for integer overflows unless the base is not 10 which
10025 means we have no simple and reliable way to continue.
10026 Break out the floating-point parsing into a new
10027 function string_to_number, so that Fstring_to_number parses
10028 floating point numbers consistently with the Lisp reader.
04f2d78b 10029 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10030 (E_CHAR, EXP_INT): Remove, replacing with ...
10031 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10032 (string_to_number): New function, replacing isfloat_string.
10033 This function checks for valid syntax and produces the resulting
10034 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10035 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10036 so that overflow for non-base-10 numbers is reported only when
10037 there's no portable and simple way to convert to floating point.
452f4150 10038
67769ffc
PE
10039 * textprop.c (set_text_properties_1): Rewrite for clarity,
10040 and to avoid GCC warning about integer overflow.
10041
c20db43f
PE
10042 * intervals.h (struct interval): Use EMACS_INT for members
10043 where EMACS_UINT might cause problems. See
10044 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10045 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10046 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10047 All uses changed.
37aa2f85
PE
10048 (offset_intervals): Tell GCC not to worry about length overflow
10049 when negating a negative length.
c20db43f 10050
2538aa2f
PE
10051 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10052 (overrun_check_free): Likewise.
10053
f2d3008d
PE
10054 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10055 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10056 word size.
10057
ec8df744
PE
10058 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10059 (gnutls_make_error): Rename local to avoid shadowing.
10060 (gnutls_emacs_global_deinit): ifdef out; not used.
10061 (Fgnutls_boot): Use const for pointer to readonly storage.
10062 Comment out unused local. Fix pointer signedness problems.
10063
640ee02d
PE
10064 * lread.c (openp): Don't stuff size_t into an 'int'.
10065 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10066 about possible signed overflow.
10067
6048fb2a
PE
10068 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10069 (GDK_KEY_g): Don't define if already defined.
10070 (xg_prepare_tooltip): Avoid pointer signedness problem.
10071 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10072
fa3c87e1
PE
10073 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10074 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10075
2172544b
PE
10076 * xfns.c (Fx_window_property): Simplify a bit,
10077 to make a bit faster and to avoid GCC 4.6.0 warning.
10078 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10079
9b821a21
PE
10080 * fns.c (internal_equal): Don't assume size_t fits in int.
10081
3c616cfa
PE
10082 * alloc.c (compact_small_strings): Tighten assertion a little.
10083
c2982e87
PE
10084 Replace pEd with more-general pI, and fix some printf arg casts.
10085 * lisp.h (pI): New macro, generalizing old pEd macro to other
10086 conversion specifiers. For example, use "...%"pI"d..." rather
10087 than "...%"pEd"...".
10088 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10089 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10090 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10091 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10092 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10093 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10094 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10095 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10096 64-bit hosts.
10097 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10098 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10099 * print.c (safe_debug_print, print_object): Likewise.
10100 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10101 to int.
6f04d126
PE
10102 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10103 avoiding the 0 flag, which is not portable.
c2982e87
PE
10104 * process.c (Fmake_network_process): Use pI to avoid cast.
10105 * region-cache.c (pp_cache): Likewise.
10106 * xdisp.c (decode_mode_spec): Likewise.
10107 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10108 behavior on 64-bit hosts with printf arg.
6f04d126 10109 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10110 (x_stop_queuing_selection_requests): Likewise.
10111 (x_get_window_property): Don't truncate byte count to an 'int'
10112 when tracing.
0b432f21 10113
5e073ec7
PE
10114 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10115 here, since it parses constructs like leading '-' and spaces,
10116 which are not wanted; and it overflows with large numbers.
10117 Instead, simply match F[0-9]+, which is what is wanted anyway.
10118
36372bf9
PE
10119 * alloc.c: Remove unportable assumptions about struct layout.
10120 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10121 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10122 (allocate_vectorlike, make_pure_vector): Use the new macros,
10123 plus offsetof, to remove unportable assumptions about struct layout.
10124 These assumptions hold on all porting targets that I know of, but
10125 they are not guaranteed, they're easy to remove, and removing them
10126 makes further changes easier.
10127
0b432f21
PE
10128 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10129 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10130 (string_overrun_cookie): Now const. Use initializers that
10131 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10132 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10133 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10134 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10135 multiple of sizeof (EMACS_INT); it need not be, if
10136 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10137 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10138
895009e1
JB
101392011-04-26 Juanma Barranquero <lekktu@gmail.com>
10140
10141 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10142
6a7a1b0b
TZ
101432011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10144
10145 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10146 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10147 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10148
841a1577 101492011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10150
10151 * lisp.h (Qdebug): List symbol.
895009e1 10152 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10153 * keyboard.c (debug-on-event): New variable.
10154 (handle_user_signal): Break into debugger when debug-on-event
10155 matches the current signal symbol.
10156
f2d3ba6f
DN
101572011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10158
10159 * alloc.c (check_sblock, check_string_bytes)
10160 (check_string_free_list): Convert to standard C.
10161
42ce4c63
TZ
101622011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10163
10164 * w32.c (emacs_gnutls_push): Fix typo.
10165
825cd63c
EZ
101662011-04-25 Eli Zaretskii <eliz@gnu.org>
10167
fb11d64d
EZ
10168 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10169 "cast to pointer from integer of different size".
10170
825cd63c
EZ
10171 Improve doprnt and its use in verror. (Bug#8545)
10172 * doprnt.c (doprnt): Document the set of format control sequences
10173 supported by the function. Use SAFE_ALLOCA instead of always
10174 using `alloca'.
10175
10176 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10177 is one byte too soon. Don't use xrealloc; instead xfree and
10178 xmalloc anew.
10179
e061a11b
TZ
101802011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10181
10182 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10183 callbacks stage.
10184
10185 * gnutls.c: Renamed global_initialized to
10186 gnutls_global_initialized. Added internals for the
10187 :verify-hostname-error, :verify-error, and :verify-flags
10188 parameters of `gnutls-boot' and documented those parameters in the
10189 docstring. Start callback support.
9173deec
JB
10190 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10191 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10192 on error. Return error code.
e061a11b
TZ
10193 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10194 (emacs_gnutls_read): Likewise.
10195 (Fgnutls_boot): Return handshake error code.
10196 (emacs_gnutls_handle_error): New function.
10197 (wsaerror_to_errno): Likewise.
10198
10199 * w32.h (emacs_gnutls_pull): Add prototype.
10200 (emacs_gnutls_push): Likewise.
10201
10202 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10203 (emacs_gnutls_push): Likewise.
10204
102052011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10206
10207 * process.c (wait_reading_process_output): Check if GnuTLS
10208 buffered some data internally if no FDs are set for TLS
10209 connections.
10210
10211 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10212 (LIBS): Link to USER_LIBS.
10213 ($(BLD)/gnutls.$(0)): New target.
10214
fa6996bc
EZ
102152011-04-24 Eli Zaretskii <eliz@gnu.org>
10216
eb35682e
EZ
10217 * xdisp.c (handle_single_display_spec): Rename the
10218 display_replaced_before_p argument into display_replaced_p, to
10219 make it consistent with the commentary. Fix typos in the
10220 commentary.
10221
e2ad650c
EZ
10222 * textprop.c (syms_of_textprop): Remove dead code.
10223 (copy_text_properties): Delete obsolete commentary about an
10224 interface that was deleted long ago. Fix typos in the description
10225 of arguments.
10226
1b2de274
EZ
10227 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10228 to changes in oldXMenu/XMenu.h from 2011-04-16.
10229 <menu_help_message, prev_menu_help_message>: Constify.
10230 (IT_menu_make_room): menu->help_text is now `const char **';
10231 adjust.
10232
10233 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10234 to changes in oldXMenu/XMenu.h from 2011-04-16.
10235 (struct XMenu): Declare `help_text' `const char **'.
10236
10237 * xfaces.c <Qunspecified>: Make extern again.
10238
10239 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10240 required by POSIX.
1b2de274 10241
762b15be
EZ
10242 * doc.c (get_doc_string): Improve the format passed to `error'.
10243
10244 * doprnt.c (doprnt): Improve commentary.
10245
10246 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10247
10248 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10249 them with etags.
10250
f1052e5d
EZ
10251 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10252 changes in globals.h immediately force recompilation.
762b15be
EZ
10253 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10254 $(CURDIR)/s/ms-w32.h.
10255 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10256
fa6996bc
EZ
10257 * character.c (Fchar_direction): Function deleted.
10258 (syms_of_character): Don't defsubr it.
10259 <char-direction-table>: Deleted.
10260
e6c3da20
EZ
102612011-04-23 Eli Zaretskii <eliz@gnu.org>
10262
10263 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10264 * doprnt.c: Include limits.h.
10265 (SIZE_MAX): New macro.
04f2d78b
CB
10266 (doprnt): Return a size_t value. 2nd arg is now size_t.
10267 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10268 Improve overflow protection. Support `l' modifier for integer
10269 conversions. Support %l conversion. Don't assume an EMACS_INT
10270 argument for integer conversions and for %c.
10271
10272 * lisp.h (doprnt): Restore prototype.
10273
10274 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10275 $(SRC)/character.h.
10276
10277 * Makefile.in (base_obj): Add back doprnt.o.
10278
10279 * deps.mk (doprnt.o): Add back prerequisites.
10280 (callint.o): Depend on character.h.
10281
10282 * eval.c (internal_lisp_condition_case): Include the handler
10283 representation in the error message.
10284 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10285 when breaking from the loop.
10286
10287 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10288
10289 * callint.c (Fcall_interactively): When displaying error message
10290 about invalid control letter, pass the character's codepoint, not
10291 a pointer to its multibyte form. Improve display of the character
10292 in octal and display also its hex code.
10293
10294 * character.c (char_string): Use %x to display the (unsigned)
10295 codepoint of an invalid character, to avoid displaying a bogus
10296 negative value.
10297
10298 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10299 `error', not SYMBOL_NAME itself.
10300
10301 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10302 character arguments to `error'.
10303
10304 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10305 to `error' in error message about FINAL_CHAR argument. Make sure
10306 FINAL_CHAR is a character, and use %c when it is passed as
10307 argument to `error'.
10308
4ffd0d6b 103092011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10310
10311 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10312
10313 * w32.c: Include <time.h>.
10314 (sys_localtime): New function.
10315
4ffd0d6b 103162011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10317
10318 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10319
4ffd0d6b 10320 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10321
4ffd0d6b 103222011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10323
4ffd0d6b
GM
10324 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10325 zombies (Bug#8467).
aac0c6e3 10326
04c56954
EZ
103272011-04-19 Eli Zaretskii <eliz@gnu.org>
10328
10329 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10330 gl_state.e_property when gl_state.object is Qt.
10331
10332 * insdel.c (make_gap_larger): Remove limitation of buffer size
10333 to <= INT_MAX.
10334
16a43933
CY
103352011-04-18 Chong Yidong <cyd@stupidchicken.com>
10336
10337 * xdisp.c (lookup_glyphless_char_display)
10338 (produce_glyphless_glyph): Handle cons cell entry in
10339 glyphless-char-display.
10340 (Vglyphless_char_display): Document it.
10341
10342 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10343 glyphless-char-display.
10344
4581706e
CY
103452011-04-17 Chong Yidong <cyd@stupidchicken.com>
10346
10347 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10348
10349 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10350
10351 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10352 definition for no-X builds.
10353
4887c6e2 103542011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10355
fd35b6f9
PE
10356 Static checks with GCC 4.6.0 and non-default toolkits.
10357
5c1ccb01
PE
10358 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10359
006c5daa
PE
10360 * process.c (keyboard_bit_set): Define only if SIGIO.
10361 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10362 (send_process): Repair possible setjmp clobbering.
10363
efc736d3
PE
10364 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10365
4e2fe2e6
PE
10366 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10367
f97334a2
PE
10368 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10369
4e75f29d
PE
10370 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10371 Define only if needed.
10372
90efadd1
PE
10373 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10374 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10375 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10376
3c647824
PE
10377 * dispextern.h (struct redisplay_interface): Rename param
10378 to avoid shadowing.
e264f262 10379 * termhooks.h (struct terminal): Likewise.
761383f4 10380 * xterm.c (xembed_send_message): Likewise.
3c647824 10381
b58c5c4a
PE
10382 * insdel.c (make_gap_smaller): Define only if
10383 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10384
cad59032
PE
10385 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10386 it.
10387
c339dc2e
PE
10388 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10389 so that we aren't warned about unused symbols.
10390
91a3e27b
PE
10391 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10392
399c71d3 10393 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10394
8ffc96f5
PE
10395 * xfns.c (x_real_positions): Mark locals as initialized.
10396
eef9bc79
PE
10397 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10398
098db9dd
PE
10399 * xterm.c: Fix problems found by static analysis with other toolkits.
10400 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10401 (x_dispatch_event): Declare static if USE_GTK, and
10402 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10403 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10404 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10405 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10406 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10407
eb18f6cc
PE
10408 * xmenu.c (menu_help_callback): Pointer type fixes.
10409 Use const pointers when pointing at readonly data. Avoid pointer
10410 signedness clashes.
10411 (FALSE): Remove unused macro.
10412 (update_frame_menubar): Remove unused decl.
10413
1fe72bf8
PE
10414 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10415
60d9e1db
PE
10416 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10417 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10418 (single_menu_item): Rename local to avoid shadowing.
10419
39261c26
PE
10420 * keyboard.c (make_lispy_event): Remove unused local var.
10421
018c5e19
PE
10422 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10423 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10424
63d2b86e
PE
10425 * bitmaps: Change bitmaps from unsigned char back to the X11
10426 compatible char. Avoid the old compiler warnings about
10427 out-of-range initializers by using, for example, '\xab' rather
10428 than 0xab.
10429
aefd87e1
PE
10430 * xgselect.c (xgselect_initialize): Check vs interface
10431 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10432
bf501fb9
PE
10433 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10434
e9829fdf
PE
10435 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10436 to read-only memory.
10437
1086c095
PE
10438 * fns.c (vector): Remove; this old hack is no longer needed.
10439
2baccd04 10440 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10441 Remove unused var.
dde42981 10442 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10443
72391843 10444 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10445
436c16df 10446 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10447 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10448 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10449
92bb796d 10450 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10451 (x_term_init): Remove local to avoid shadowing.
92bb796d 10452
764430a3 10453 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10454
10455 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10456 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10457
d1dfb56c
EZ
104582011-04-16 Eli Zaretskii <eliz@gnu.org>
10459
c4354cb4
EZ
10460 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10461
d1dfb56c
EZ
10462 Fix regex.c, syntax.c and friends for buffers > 2GB.
10463 * syntax.h (struct gl_state_s): Declare character position members
10464 EMACS_INT.
10465
10466 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10467
04f2d78b
CB
10468 * textprop.c (verify_interval_modification, interval_of):
10469 Declare arguments EMACS_INT.
d1dfb56c
EZ
10470
10471 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10472 EMACS_INT.
10473
10474 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10475
10476 * indent.c (Fvertical_motion): Local variable it_start is now
10477 EMACS_INT.
10478
10479 * regex.c (re_match, re_match_2, re_match_2_internal)
10480 (bcmp_translate, regcomp, regexec, print_double_string)
10481 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10482 (re_compile_pattern, re_exec): Declare arguments and local
10483 variables `size_t' and `ssize_t' and return values `regoff_t', as
10484 appropriate.
10485 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10486 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10487 <compile_stack_type>: `size' and `avail' are now `size_t'.
10488
10489 * regex.h <regoff_t>: Use ssize_t, not int.
10490 (re_search, re_search_2, re_match, re_match_2): Arguments that
10491 specify buffer/string position and length are now ssize_t and
10492 size_t. Return type is regoff_t.
10493
613052cd
BK
104942011-04-16 Ben Key <bkey76@gmail.com>
10495
10496 * nsfont.m: Fixed bugs in ns_get_family and
10497 ns_descriptor_to_entity that were caused by using free to
10498 deallocate memory blocks that were allocated by xmalloc (via
10499 xstrdup). This caused Emacs to crash when compiled with
10500 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10501 --enable-checking=xmallocoverrun). xfree is now used to
10502 deallocate these memory blocks.
10503
4170f62f 105042011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10505
71b41406
PE
10506 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10507
9587a89d
PE
10508 emacs_write: Accept and return EMACS_INT for sizes.
10509 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10510 et seq.
10511 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10512 Accept and return EMACS_INT.
10513 (emacs_gnutls_write): Return the number of bytes written on
10514 partial writes.
10515 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10516 (emacs_read, emacs_write): Remove check for negative size, as the
10517 Emacs source code has been audited now.
9587a89d
PE
10518 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10519 (emacs_read, emacs_write): Use it.
273a5f82
PE
10520 * process.c (send_process): Adjust to the new signatures of
10521 emacs_write and emacs_gnutls_write. Do not attempt to store
10522 a byte offset into an 'int'; it might overflow.
9587a89d 10523 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10524
3e047f51
PE
10525 * sound.c: Don't assume sizes fit in 'int'.
10526 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10527 Return EMACS_INT, not int.
3e047f51 10528 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10529 Accept EMACS_INT, not int.
10530 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10531 record read return values.
10532
cc39a9db
BK
105332011-04-15 Ben Key <bkey76@gmail.com>
10534
c9d0ec6d
JB
10535 * keyboard.c (Qundefined): Don't declare static since it is used
10536 in nsfns.m.
10537 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10538 static since they are used in nsfont.m.
cc39a9db 10539
6c60eb9f
SM
105402011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10541
10542 * process.c (Qprocessp): Don't declare static.
10543 * lisp.h (Qprocessp): Declare again.
10544
7990b61a
JB
105452011-04-15 Juanma Barranquero <lekktu@gmail.com>
10546
10547 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10548
5d4cb038
PE
105492011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10550
8bd7b830 10551 Improve C-level modularity by making more things 'static'.
cd64ea1d 10552
e3b27b31
PE
10553 Don't publish debugger-only interfaces to other modules.
10554 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10555 (verify_bytepos, count_markers): Move decls to the only modules
10556 that need them.
10557 * region-cache.h (pp_cache): Likewise.
10558 * window.h (check_all_windows): Likewise.
10559 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10560
5d4cb038
PE
10561 * sysdep.c (croak): Now static, if
10562 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10563 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10564
10565 * alloc.c (refill_memory_reserve): Now static if
10566 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10567 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10568
e87b6180
PE
10569 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10570 Define only if USE_LUCID.
10571
ac64929e
PE
10572 * xrdb.c (x_customization_string, x_rm_string): Now static.
10573
6f37259d
PE
10574 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10575 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10576
1683e3ab
PE
10577 * xdisp.c (draw_row_with_mouse_face): Now static.
10578 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10579
de9c2632
PE
10580 * window.h (check_all_windows): Mark externally visible.
10581
2b96acb7
PE
10582 * window.c (window_deletion_count): Now static.
10583
10584 * undo.c: Make symbols static if they're not exported.
10585 (last_undo_buffer, last_boundary_position, pending_boundary):
10586 Now static.
10587
50436f33
PE
10588 * textprop.c (interval_insert_behind_hooks): Now static.
10589 (interval_insert_in_front_hooks): Likewise.
10590
64520e5c
PE
10591 * term.c: Make symbols static if they're not exported.
10592 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10593 (max_frame_lines, tty_set_terminal_modes):
10594 (tty_reset_terminal_modes, tty_turn_off_highlight):
10595 (get_tty_terminal): Now static.
10596 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10597 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10598 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10599 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10600 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10601
1fa53021
PE
10602 * sysdep.c: Make symbols static if they're not exported.
10603 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10604 Now static.
10605 (sigprocmask_set, full_mask): Remove; unused.
10606 (wait_debugging): Mark as visible.
10607 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10608 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10609
d4b43b22
PE
10610 * syntax.c (syntax_temp): Define only if !__GNUC__.
10611
b7c513d0
PE
10612 * sound.c (current_sound_device, current_sound): Now static.
10613
989b29ad
PE
10614 * search.c (searchbufs, searchbuf_head): Now static.
10615
13a55a78
PE
10616 * scroll.c (scroll_cost): Remove; unused.
10617 * dispextern.h (scroll_cost): Remove decl.
10618
de68a1fc
PE
10619 * region-cache.h (pp_cache): Mark as externally visible.
10620
40ccffa6
PE
10621 * process.c: Make symbols static if they're not exported.
10622 (process_tick, update_tick, create_process, chan_process):
10623 (Vprocess_alist, proc_buffered_char, datagram_access):
10624 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10625 (deactivate_process): Mark defn as static, as well as decl.
10626 * lisp.h (create_process): Remove decl.
10627 * process.h (chan_process, Vprocess_alist): Remove decls.
10628
ad64fc97
PE
10629 * print.c: Make symbols static if they're not exported.
10630 (print_depth, new_backquote_output, being_printed, print_buffer):
10631 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10632 (print_interval, print_number_index, initial_stderr_stream):
10633 Now static.
10634 * lisp.h (Fprinc): Remove decl.
10635 (debug_output_compilation_hack): Mark as externally visible.
10636
adddb265
PE
10637 * sysdep.c (croak): Move decl from here to syssignal.h.
10638 * syssignal.h (croak): Put it here, so the API can be checked when
10639 'croak' is called from dissociate_if_controlling_tty.
10640
1717ede2
PE
10641 * minibuf.c: Make symbols static if they're not exported.
10642 (minibuf_save_list, choose_minibuf_frame): Now static.
10643 * lisp.h (choose_minibuf_frame): Remove decl.
10644
fa5fb2bc
PE
10645 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10646
1e3890d1
PE
10647 * lread.c: Make symbols static if they're not exported.
10648 (read_objects, initial_obarray, oblookup_last_bucket_number):
10649 Now static.
10650 (make_symbol): Remove; unused.
10651 * lisp.h (initial_obarray, make_symbol): Remove decls.
10652
8a1414fa
PE
10653 * keyboard.c: Make symbols static if they're not exported.
10654 (single_kboard, recent_keys_index, total_keys, recent_keys):
10655 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10656 (this_single_command_key_start, echoing, last_auto_save):
10657 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10658 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10659 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10660 (Vlispy_mouse_stem, double_click_count):
10661 Now static.
10662 (force_auto_save_soon): Define only if SIGDANGER.
10663 (ignore_mouse_drag_p): Now static if
10664 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10665 (print_help): Remove; unused.
10666 (stop_character, last_timer_event): Mark as externally visible.
10667 * keyboard.h (ignore_mouse_drag_p): Declare only if
10668 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10669 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10670 * lisp.h (echoing): Remove decl.
10671 (force_auto_save_soon): Declare only if SIGDANGER.
10672 * xdisp.c (redisplay_window): Simplify code, to make it more
10673 obvious that ignore_mouse_drag_p is not accessed if !defined
10674 USE_GTK && !defined HAVE_NS.
10675
93ea6e8f
PE
10676 * intervals.c: Make symbols static if they're not exported.
10677 (merge_properties_sticky, merge_interval_right, delete_interval):
10678 Now static.
10679 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10680
77382fcc
PE
10681 * insdel.c: Make symbols static if they're not exported.
10682 However, leave prepare_to_modify_buffer alone. It's never
10683 called from outside this function, but that appears to be a bug.
10684 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10685 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10686 (adjust_after_replace_noundo): Remove; unused.
10687 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10688 (signal_before_change): Remove decls.
77382fcc 10689
9306c32e
PE
10690 * indent.c (val_compute_motion, val_vmotion): Now static.
10691
cd44d2eb
PE
10692 * image.c: Make symbols static if they're not exported.
10693 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10694 if USE_GTK.
10695 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10696 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10697
ad9a7a06
PE
10698 * fringe.c (standard_bitmaps): Now static.
10699 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10700
81626931
PE
10701 * frame.c: Make symbols static if they're not exported.
10702 (x_report_frame_params, make_terminal_frame): Now static.
10703 (get_frame_param): Now static, unless HAVE_NS.
10704 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10705 (x_get_resource_string): Remove; not used.
10706 * frame.h (make_terminal_frame, x_report_frame_params):
10707 (x_get_resource_string); Remove decls.
10708 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10709 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10710
239f9db9
PE
10711 * font.c, fontset.c: Make symbols static if they're not exported.
10712 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10713 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10714 * font.c (font_close_object): Now static.
10715 * font.h (font_close_object): Remove.
10716 * fontset.c (FONTSET_OBJLIST): Remove.
10717 (free_realized_fontset) #if-0 the body, which does nothing.
10718 (face_suitable_for_char_p): #if-0, as it's never called.
10719 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10720 * xfaces.c (face_at_string_position):
10721 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10722 since 0 is always ASCII.
10723
dfcf3579
PE
10724 * fns.c (weak_hash_tables): Now static.
10725
5045092b
PE
10726 * fileio.c: Make symbols static if they're not exported.
10727 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10728 (Vwrite_region_annotation_buffers): Now static.
10729
57a96f5c
PE
10730 * eval.c: Make symbols static if they're not exported.
10731 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10732 * lisp.h (backtrace_list): Remove decl.
10733
35f08c38
PE
10734 * emacs.c: Make symbols static if they're not exported.
10735 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10736 (fatal_error_code, fatal_error_signal_hook, standard_args):
10737 Now static.
10738 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10739 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10740 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10741 * lisp.h (fatal_error_signal_hook): Remove decl.
10742 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10743
f44bd759
PE
10744 * editfns.c: Move a (normally-unused) function to its only use.
10745 * editfns.c, lisp.h (get_operating_system_release): Remove.
10746 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10747 worth the hassle of breaking this out.
10748
b532497d
PE
10749 * xterm.c: Make symbols static if they're not exported.
10750 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10751 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10752 (x_destroy_window, x_delete_display):
10753 Now static.
10754 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10755 (x_mouse_leave): Remove; unused.
10756 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10757 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10758 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10759 Remove decls.
10760 (x_mouse_leave): Declare only if WINDOWSNT.
10761 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10762 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10763 USE_X_TOOLKIT.
10764
1675728f
PE
10765 * ftxfont.c: Make symbols static if they're not exported.
10766 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10767 HAVE_FREETYPE.
10768 * font.h (ftxfont_driver): Likewise.
10769
e4cebfca
PE
10770 * xfns.c: Make symbols static if they're not exported.
10771 (x_last_font_name, x_display_info_for_name):
10772 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10773 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10774 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10775 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10776 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10777 (last_show_tip_args): Now static.
10778 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10779 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10780 (x_screen_planes): Remove; unused.
10781 * dispextern.h (x_screen_planes): Remove decl.
10782
5bf46f05
PE
10783 * dispnew.c: Make symbols static if they're not exported.
10784 * dispextern.h (redraw_garbaged_frames, scrolling):
10785 (increment_row_positions): Remove.
10786 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10787 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10788 Now static.
10789 (redraw_garbaged_frames): Remove; unused.
10790
435f4c28
PE
10791 * xfaces.c: Make symbols static if they're not exported.
10792 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10793 Remove decls.
10794 * xterm.h (defined_color): Remove decls.
10795 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10796 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10797 (menu_face_changed_default, defined_color, free_realized_face):
10798 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10799 (ascii_face_of_lisp_face): Remove; unused.
10800
8524aef3
PE
10801 * xdisp.c: Make symbols static if they're not exported.
10802 * dispextern.h (scratch_glyph_row, window_box_edges):
10803 (glyph_to_pixel_coords, set_cursor_from_row):
10804 (get_next_display_element, set_iterator_to_next):
10805 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10806 (show_mouse_face): Remove decls
10807 * frame.h (message_buf_print): Likewise.
10808 * lisp.h (pop_message, set_message, check_point_in_composition):
10809 Likewise.
10810 * xterm.h (set_vertical_scroll_bar): Likewise.
10811 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10812 (message_buf_print, scratch_glyph_row, displayed_buffer):
10813 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10814 (get_next_display_element, show_mouse_face, window_box_edges):
10815 (frame_to_window_pixel_xy, check_point_in_composition):
10816 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10817 (glyph_to_pixel_coords): Remove; unused.
10818
16390cd2
PE
10819 * dired.c (file_name_completion): Now static.
10820
10821 * dbusbind.c (xd_in_read_queued_messages): Now static.
10822
a25f4dfa
PE
10823 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10824 * data.c (circular_list_error): Remove.
10825
14a9c8df
PE
10826 * commands.h (last_point_position, last_point_position_buffer):
10827 (last_point_position_window): Remove decls.
10828 * keyboard.c: Make these variables static.
10829
04f2d78b
CB
10830 * coding.h (coding, code_convert_region, encode_coding_gap):
10831 Remove decls.
74ab6df5
PE
10832 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10833 (iso_code_class, detect_coding, code_convert_region): Now static.
10834 (encode_coding_gap): Remove; unused.
10835
38dfbee1
PE
10836 * chartab.c (chartab_chars, chartab_bits): Now static.
10837
a2cb4e63
PE
10838 * charset.h (charset_iso_8859_1): Remove decl.
10839 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10840 Now static.
10841
127198fd
PE
10842 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10843 * ccl.c (Vccl_program_table): Now static.
10844 (check_ccl_update): Remove; unused.
10845
d85b608f
PE
10846 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10847 * category.h: ... from here.
10848 * category.c (check_category_table, set_category_set): Now static.
10849
31cd66f3
PE
10850 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10851 * lisp.h: Remove these decls.
10852
c358e587
PE
10853 * buffer.c (buffer_count): Remove unused var.
10854
e78aecca
PE
10855 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10856 so that it's not optimized away.
10857 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10858 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10859 exported only to the debugger.
10860
e192d7d3 10861 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10862 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10863
92470028
PE
10864 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10865 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10866 was inaccessible from Lisp.
10867 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10868 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10869
244ed907
PE
10870 alloc.c: Import and export fewer symbols, and remove unused items.
10871 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10872 is defined.
10873 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10874 it's not optimized away by whole-program optimization.
10875 (message_enable_multibyte, free_misc): Remove.
10876 (catchlist, handlerlist, mark_backtrace):
10877 Declare only if BYTE_MARK_STACK.
10878 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10879 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10880 (message_enable_multibyte): Remove decl.
10881 (free_misc, interval_free_list, float_block, float_block_index):
10882 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10883 (cons_free_list, last_marked_index):
10884 Now static.
10885 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10886 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10887 (mark_backtrace): Define only if BYTE_MARK_STACK.
10888 * xdisp.c (message_enable_multibyte): Now static.
10889
61c2b50e 10890 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10891 This makes it easier for human readers (and static analyzers)
10892 to see whether these variables are used from other modules.
10893 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10894 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10895 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10896 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10897 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10898 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10899 * xmenu.c, xselect.c:
10900 Declare Q* vars static if they are not used in other modules.
10901 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10902 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10903 Remove decls of unexported vars.
10904 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10905
95c82688
PE
10906 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10907
16a97296
PE
10908 Make Emacs functions such as Fatom 'static' by default.
10909 This makes it easier for human readers (and static analyzers)
10910 to see whether these functions can be called from other modules.
10911 DEFUN now defines a static function. To make the function external
10912 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10913 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10914 (Finit_image_library):
16a97296
PE
10915 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10916 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10917 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10918 Remove decls, since these functions are now static.
10919 (Funintern, Fget_internal_run_time): New decls, since these functions
10920 were already external.
95c82688 10921
16a97296
PE
10922 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10923 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10924 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10925 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10926 * keyboard.c, keymap.c, lread.c:
10927 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10928 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10929 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10930 Mark functions with DEFUE instead of DEFUN,
10931 if they are used in other modules.
10932 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10933 decls for now-static functions.
10934 * buffer.h (Fdelete_overlay): Remove decl.
10935 * callproc.c (Fgetenv_internal): Mark as internal.
10936 * composite.c (Fremove_list_of_text_properties): Remove decl.
10937 (Fcomposition_get_gstring): New forward static decl.
10938 * composite.h (Fcomposite_get_gstring): Remove decl.
10939 * dired.c (Ffile_attributes): New forward static decl.
10940 * doc.c (Fdocumntation_property): New forward static decl.
10941 * eval.c (Ffetch_bytecode): New forward static decl.
10942 (Funintern): Remove extern decl; now in .h file where it belongs.
10943 * fileio.c (Fmake_symbolic_link): New forward static decl.
10944 * image.c (Finit_image_library): New forward static decl.
10945 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10946 * intervals.h (Fprevious_property_change):
10947 (Fremove_list_of_text_properties): Remove decls.
10948 * keyboard.c (Fthis_command_keys): Remove decl.
10949 (Fcommand_execute): New forward static decl.
10950 * keymap.c (Flookup_key): New forward static decl.
10951 (Fcopy_keymap): Now static.
10952 * keymap.h (Flookup_key): Remove decl.
10953 * process.c (Fget_process): New forward static decl.
10954 (Fprocess_datagram_address): Mark as internal.
10955 * syntax.c (Fsyntax_table_p): New forward static decl.
10956 (skip_chars): Remove duplicate decl.
10957 * textprop.c (Fprevious_property_change): New forward static decl.
10958 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10959 Now internal.
10960 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10961 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10962
785bbd42
PE
10963 * editfns.c (Fformat): Remove unreachable code.
10964
8b913b57
AS
109652011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10966
10967 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10968 change. (Bug#8496)
10969
a6744a35
EZ
109702011-04-13 Eli Zaretskii <eliz@gnu.org>
10971
10972 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10973 when at ZV. (Bug#8487)
10974
e7974947
AS
109752011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10976
baad03f0
AS
10977 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10978 (Bug#8437)
10979 * keyboard.c (parse_tool_bar_item): Likewise.
10980 * sound.c (sound_cleanup, alsa_close): Likewise.
10981 * termcap.c (tgetent): Likewise.
10982 * xfns.c (x_default_font_parameter): Likewise.
10983 * xsettings.c (read_and_apply_settings): Likewise.
10984
e7974947
AS
10985 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10986 (overrun_check_free): Protoize.
10987
28272684
PE
109882011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10989
10990 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10991 since callers should never pass a negative size.
10992 Change the signature to match that of plain 'read' and 'write'; see
10993 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10994 * lisp.h: Update prototypes of emacs_write and emacs_read.
10995
11997c76
EZ
109962011-04-11 Eli Zaretskii <eliz@gnu.org>
10997
10998 * xdisp.c (redisplay_window): Don't try to determine the character
10999 position of the scroll margin if the window start point w->startp
e896f03c 11000 is outside the buffer's accessible region. (Bug#8468)
11997c76 11001
8a2cbd72
EZ
110022011-04-10 Eli Zaretskii <eliz@gnu.org>
11003
11004 Fix write-region and its subroutines for buffers > 2GB.
11005 * fileio.c (a_write, e_write): Modify declaration of arguments and
11006 local variables to support buffers larger than 2GB.
11007 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11008
11009 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11010 argument, local variables, and return value.
11011
11012 * lisp.h: Update prototypes of emacs_write and emacs_read.
11013
11014 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11015
4073e537 110162011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11017
1ebfdcb6
PE
11018 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11019
b2ded58d
PE
11020 Fix more problems found by GCC 4.6.0's static checks.
11021
7d66342c
PE
11022 * xdisp.c (vmessage): Use a better test for character truncation.
11023
bbf47d44
PE
11024 * charset.c (load_charset_map): <, not <=, for optimization,
11025 and to avoid potential problems with integer overflow.
9248994d 11026 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11027 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11028 * editfns.c (Fformat): Likewise.
1e69125e 11029 * syntax.c (skip_chars): Likewise.
3befa583 11030
e3019616
PE
11031 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11032 This also lets GCC 4.6.0 generate slightly better loop code.
11033
becfa255
PE
11034 * callint.c (Fcall_interactively): <, not <=, for optimization.
11035 (Fcall_interactively): Count the number of arguments produced,
11036 not the number of arguments given. This is simpler and lets GCC
11037 4.6.0 generate slightly better code.
11038
dae0cd48
PE
11039 * ftfont.c: Distingish more carefully between FcChar8 and char.
11040 The previous code passed unsigned char * to a functions like
11041 strlen and xstrcasecmp that expect char *, which does not
11042 conform to the C standard.
11043 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11044 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11045 char * when the C standard requires it.
11046
76032d70
PE
11047 * keyboard.c (read_char): Remove unused var.
11048
eb3f1cc8
PE
11049 * eval.c: Port to Windows vsnprintf (Bug#8435).
11050 Include <limits.h>.
11051 (SIZE_MAX): Define if the headers do not.
11052 (verror): Do not give up if vsnprintf returns a negative count.
11053 Instead, grow the buffer. This ports to Windows vsnprintf, which
11054 does not conform to C99. Problem reported by Eli Zaretskii.
11055 Also, simplify the allocation scheme, by avoiding the need for
11056 calling realloc, and removing the ALLOCATED variable.
11057
70476b54
PE
11058 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11059
12020a9e
PE
11060 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11061 But keep the doprint source code for now, as we might revamp it
11062 and use it again (Bug#8435).
ea6c7ae6
PE
11063 * lisp.h (doprnt): Remove.
11064 * Makefile.in (base_obj): Remove doprnt.o.
11065 * deps.mk (doprnt.o): Remove.
11066
5fdb398c
PE
11067 error: Print 32- and 64-bit integers portably (Bug#8435).
11068 Without this change, on typical 64-bit hosts error ("...%d...", N)
11069 was used to print both 32- and 64-bit integers N, which relied on
11070 undefined behavior.
61bdb816 11071 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11072 * lisp.h (error, verror): Mark as printf-like functions.
11073 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11074 Report overflow in size calculations when allocating printf buffer.
11075 Do not truncate output string at its first null byte.
11076 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11077 Truncate the output at a character boundary, since vsnprintf does not
11078 do that.
11079 * charset.c (check_iso_charset_parameter): Convert internal
11080 character to string before calling 'error', since %c now has the
11081 printf meaning.
11082 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11083 overflow when computing char to be passed to 'error'. Do not
11084 pass Lisp_Object to 'error'; pass the integer instead.
11085 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11086 formatted with plain %d.
11087
b189fa66
PE
11088 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11089
bff87ef0
PE
11090 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11091
7e2cac20
PE
11092 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11093
ce4d90b5
PE
11094 * xterm.c (x_catch_errors): Remove duplicate declaration.
11095
266c9547
PE
11096 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11097
79c49ad2
PE
11098 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11099
368f4090
JM
111002011-04-10 Jim Meyering <meyering@redhat.com>
11101
11102 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11103 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11104 return ssize_t not "int", and use size_t as the buffer length.
11105 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11106 * gnutls.h: Update declarations.
11107 * process.c (read_process_output): Use ssize_t, to match.
11108 (send_process): Likewise.
11109
a32d4040
CY
111102011-04-09 Chong Yidong <cyd@stupidchicken.com>
11111
11112 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11113
8546720e 111142011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11115
04f2d78b
CB
11116 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11117 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11118
8546720e
GM
11119 * xterm.c (handle_one_xevent):
11120 * xmenu.c (create_and_show_popup_menu):
11121 * xselect.c (x_decline_selection_request)
11122 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11123
0a2f5c1a 111242011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11125
11126 Fix some uses of `int' instead of EMACS_INT.
11127 * search.c (string_match_1, fast_string_match)
11128 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11129 (scan_buffer, find_next_newline_no_quit)
11130 (find_before_next_newline, search_command, Freplace_match)
11131 (Fmatch_data): Make some `int' variables be EMACS_INT.
11132
11133 * xdisp.c (display_count_lines): 3rd argument and return value now
11134 EMACS_INT. All callers changed.
11135 (pint2hrstr): Last argument is now EMACS_INT.
11136
11137 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11138 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11139 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11140 (decode_coding_utf_16, decode_coding_emacs_mule)
11141 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11142 (decode_coding_ccl, decode_coding_charset)
11143 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11144 (decode_coding_iso_2022, decode_coding_emacs_mule)
11145 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11146 <char_offset, last_offset>: Declare EMACS_INT.
11147 (encode_coding_utf_8, encode_coding_utf_16)
11148 (encode_coding_emacs_mule, encode_invocation_designation)
11149 (encode_designation_at_bol, encode_coding_iso_2022)
11150 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11151 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11152 Declare EMACS_INT.
11153 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11154 (encode_invocation_designation): Last argument P_NCHARS is now
11155 EMACS_INT.
11156 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11157 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11158
11159 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11160 All users changed.
11161
11162 * ccl.c (Fccl_execute_on_string): Declare some variables
11163 EMACS_INT.
11164
8546720e 111652011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11166
11167 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11168
4e19a977
CS
111692011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11170
11171 * process.c (Fformat_network_address): Doc fix.
11172
87302331
R
111732011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11174
ee7683eb 11175 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11176
cbb59342
CY
111772011-04-08 Chong Yidong <cyd@stupidchicken.com>
11178
11179 * keyboard.c (read_char): Call Lisp function help-form-show,
11180 instead of using internal_with_output_to_temp_buffer.
11181 (Qhelp_form_show): New var.
e0d38eeb 11182 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11183
11184 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11185
11186 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11187
e67a13ab
CY
111882011-04-06 Chong Yidong <cyd@stupidchicken.com>
11189
04f2d78b
CB
11190 * process.c (Flist_processes): Remove to Lisp.
11191 (list_processes_1): Delete.
e67a13ab 11192
973f782d
EZ
111932011-04-06 Eli Zaretskii <eliz@gnu.org>
11194
7c106b1e
EZ
11195 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11196
973f782d
EZ
11197 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11198
41cf7d1a 111992011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11200
ca23cc88
PE
11201 Fix more problems found by GCC 4.6.0's static checks.
11202
f390e2d5
PE
11203 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11204
42eea0d0
PE
11205 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11206
b69769da 11207 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11208
f9541e84
PE
11209 * xdisp.c (vmessage): Mark as a printf-like function.
11210
13841b55
PE
11211 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11212
c136c10f
PE
11213 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11214
5e2d4a30
PE
11215 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11216 printf-like functions.
11217 (tiff_load): Add casts to remove these marks before passing them
11218 to system-supplied API.
11219
583f48b9
PE
11220 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11221
b25d760e
PE
11222 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11223 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11224 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11225 directly, rather than having caller test rule sign. This avoids
11226 some unnecessary tests.
11227 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11228 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11229 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11230
bc7b6697 11231 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11232 (xfont_open): Avoid unnecessary tests.
bc7b6697 11233
27ccc379
PE
11234 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11235
dcd5c89a
PE
11236 * composite.h, composite.c (composition_gstring_put_cache):
11237 Use EMACS_INT, not int, for length.
11238
b13a45c6
PE
11239 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11240 breaking out part of COMPOSITION_DECODE_RULE.
11241 (COMPOSITION_DECODE_RULE): Use it.
11242 * composite.c (get_composition_id): Remove unused local vars,
11243 by using the new macro.
11244
1e792e4d
PE
11245 * textprop.c (set_text_properties_1): Change while to do-while,
11246 since the condition is always true at first.
11247
dc6c6455 11248 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11249 (interval_deletion_adjustment): Return unsigned value.
11250 All uses changed.
dc6c6455 11251
aba7731a
PE
11252 * process.c (list_processes_1, create_pty, read_process_output):
11253 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11254 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11255 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11256 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11257 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11258
fdfc4bf3
PE
11259 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11260
fca8fe46 11261 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11262 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11263
06a0259a 11264 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11265 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11266 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11267
e7b9e80f
PE
11268 * print.c (print_error_message): Avoid int overflow.
11269
56201685
PE
11270 * font.c (font_list_entities): Redo for clarity,
11271 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11272
78834453 11273 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11274 (font_score): Avoid potential overflow in diff calculation.
78834453 11275
0bc0b309 11276 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11277 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11278
e610eaca
PE
11279 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11280
b895abce
PE
11281 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11282 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11283 can always succeed if overflow has undefined behavior.
11284
1f1d9321 11285 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11286 (wordify): Omit three unnecessary tests.
1f1d9321 11287
c59478bc
PE
11288 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11289 All callers changed. This avoids the need for an unused var.
11290
79b73827
PE
11291 * casefiddle.c (casify_region): Remove var that is set but not used.
11292
a4db5dfe
PE
11293 * dired.c (file_name_completion): Remove var that is set but not used.
11294
43aae36e
PE
11295 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11296
2a47c44d 11297 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11298 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11299
a37c69bf
PE
11300 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11301 Check for integer overflow on size calculations.
11302
328ab8e7
PE
11303 * buffer.c (Fprevious_overlay_change): Remove var that is set
11304 but not used.
11305
e5a2a5cb
PE
11306 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11307 Remove vars that are set but not used.
8d84a6eb 11308 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11309 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11310
a60e5f68
PE
11311 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11312
f661cb61 11313 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11314 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11315
f0397f5a
PE
11316 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11317 that are set but not used.
11318
8664db06 11319 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11320 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11321
6abdaa4a
PE
11322 * xselect.c (x_get_local_selection, x_handle_property_notify):
11323 Remove vars that are set but not used.
11324
0ce7538d 11325 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11326 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11327
9ae848fc
PE
11328 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11329 Remove var that is set but not used.
0b918413
PE
11330 (scroll_bar_windows_size): Now size_t, not int.
11331 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11332 Check for overflow.
9ae848fc 11333
a5a62657
PE
11334 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11335 (map_tty_color) [!defined MSDOS]: Likewise.
11336
5c5cdd39
PE
11337 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11338
66ebf983
PE
11339 * coding.c: Remove vars that are set but not used.
11340 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11341 All callers changed.
11342 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11343 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11344 (decode_coding_charset): Remove vars that are set but not used.
11345
1be4d761
PE
11346 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11347 that is set but not used.
11348
47553fa8
PE
11349 * print.c (print_object): Remove var that is set but not used.
11350
1f7196bf 11351 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11352 The gnulib version avoids calling malloc in the usual case,
11353 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11354 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11355 * filelock.c (current_lock_owner): Likewise.
11356 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11357 * sysdep.c: Include allocator.h, careadlinkat.h.
11358 (emacs_no_realloc_allocator): New static constant.
11359 (emacs_readlink): New function.
fdb61804
PE
11360 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11361 ../lib/careadlinkat.h.
d1fdcab7 11362
f84c17c7
SM
113632011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11364
11365 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11366 first non-nil return value).
11367
ef3862ad
JD
113682011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11369
11370 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11371 if not defined (Bug#8403).
11372
376a7006
JB
113732011-04-02 Juanma Barranquero <lekktu@gmail.com>
11374
11375 * xdisp.c (display_count_lines): Remove parameter `start',
11376 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11377 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11378 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11379 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11380 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11381 and thereabouts. All callers changed.
11382 (get_per_char_metric): Remove parameter `f', unused since
11383 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11384
6ca3801d
JM
113852011-04-02 Jim Meyering <meyering@redhat.com>
11386
11387 do not dereference NULL upon failed strdup
11388 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11389 (ns_get_family): Likewise.
11390
d8e2b5ba
JB
113912011-04-02 Juanma Barranquero <lekktu@gmail.com>
11392
11393 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11394
8c74fcbd
JD
113952011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11396
11397 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11398 later (Bug#8403).
11399
7200d79c
SM
114002011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11401
03408648 11402 Add lexical binding.
7200d79c 11403
03408648
SM
11404 * window.c (Ftemp_output_buffer_show): New fun.
11405 (Fsave_window_excursion):
11406 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11407
11408 * lread.c (lisp_file_lexically_bound_p): New function.
11409 (Fload): Bind Qlexical_binding.
11410 (readevalloop): Remove `evalfun' arg.
11411 Bind Qinternal_interpreter_environment.
11412 (Feval_buffer): Bind Qlexical_binding.
11413 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11414 Mark as dynamic.
11415 (syms_of_lread): Declare `lexical-binding'.
11416
11417 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11418
11419 * keyboard.c (eval_dyn): New fun.
11420 (menu_item_eval_property): Use it.
ca105506
SM
11421
11422 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11423
03408648
SM
11424 * fns.c (concat, mapcar1): Accept byte-code-functions.
11425
11426 * eval.c (Fsetq): Handle lexical vars.
11427 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11428 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11429 (FletX, Flet): Obey lexical binding.
11430 (Fcommandp): Handle closures.
11431 (Feval): New `lexical' arg.
11432 (eval_sub): New function extracted from Feval. Use it almost
11433 everywhere where Feval was used. Look up vars in lexical env.
11434 Handle closures.
11435 (Ffunctionp): Move from subr.el.
11436 (Ffuncall): Handle closures.
11437 (apply_lambda): Remove `eval_flags'.
11438 (funcall_lambda): Handle closures and new byte-code-functions.
11439 (Fspecial_variable_p): New function.
11440 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11441 but without exporting it to Lisp.
23aba0ea 11442
23aba0ea 11443 * doc.c (Fdocumentation, store_function_docstring):
03408648 11444 * data.c (Finteractive_form): Handle closures.
23aba0ea 11445
03408648
SM
11446 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11447 interactive spec.
ba83908c 11448
04f2d78b
CB
11449 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11450 New byte-codes.
03408648
SM
11451 (exec_byte_code): New function extracted from Fbyte_code to handle new
11452 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11453
03408648 11454 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11455
03408648 11456 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11457
e2abce01
JB
114582011-03-31 Juanma Barranquero <lekktu@gmail.com>
11459
11460 * xdisp.c (redisplay_internal): Fix prototype.
11461
63696a73 114622011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11463
63696a73 11464 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11465 (try_scrolling): Use it when setting scroll_limit.
11466 Limit scrolling to 100 screen lines.
63696a73
EZ
11467 (redisplay_window): Even when falling back on "recentering",
11468 position point in the window according to scroll-conservatively,
11469 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11470
11471 (try_scrolling): When point is above the window, allow searching
11472 as far as scroll_max, or one screenful, to compute vertical
11473 distance from PT to the scroll margin position. This prevents
11474 try_scrolling from unnecessarily failing when
11475 scroll-conservatively is set to a value slightly larger than the
11476 window height. Clean up the case of PT below the margin at bottom
11477 of window: scroll_max can no longer be INT_MAX. When aggressive
11478 scrolling is in use, don't let point enter the opposite scroll
11479 margin as result of the scroll.
11480 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11481 threshold of 100 lines for never-recentering scrolling.
11482
e4cc2dfc
JB
114832011-03-31 Juanma Barranquero <lekktu@gmail.com>
11484
11485 * dispextern.h (move_it_by_lines):
11486 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11487 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11488 (message_log_check_duplicate): Remove parameters `prev_bol' and
11489 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11490 (redisplay_internal): Remove parameter `preserve_echo_area',
11491 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11492
11493 * indent.c (Fvertical_motion):
11494 * window.c (window_scroll_pixel_based, Frecenter):
11495 Don't pass `need_y_p' to `move_it_by_lines'.
11496
1c470562
SM
114972011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11498
44f230aa
SM
11499 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11500 steal a few bits to be more compact.
11501 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11502 Remove unneeded casts.
11503
1c470562
SM
11504 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11505
888adce9
ZK
115062011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11507
11508 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11509 binding" message (bug#7967).
11510
f838ed7b
PE
115112011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11512
77861b95
PE
11513 Fix more problems found by GCC 4.6.0's static checks.
11514
de6dbc14
PE
11515 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11516 Remove unused local var.
11517
f838ed7b
PE
11518 * editfns.c (Fmessage_box): Remove unused local var.
11519
792c7b2b
PE
11520 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11521 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11522 Omit unused local vars.
c499e557 11523 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11524 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11525 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11526 Omit unused local var.
11527
ba0165e1
PE
11528 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11529 Don't assume string length fits in int.
32ad8845 11530 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11531 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11532
3c59b4c9
PE
11533 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11534 instead of alloca (Bug#8344).
11535
a3eed478 11536 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11537 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11538
eb4d412d
PE
11539 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11540
1658b401
PE
11541 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11542 concerns.
11543
11544 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11545
11546 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11547
9a2c6e05
PE
11548 * keyboard.c (syms_of_keyboard): Use the same style as later
11549 in this function when indexing through an array. This also
11550 works around GCC bug 48267.
11551
03d0a109
PE
11552 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11553
44f730c8
PE
11554 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11555
fe75f926
PE
11556 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11557 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11558
ffa8c828
PE
11559 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11560 This avoids undefined behavior on integer overflow, and is a bit
11561 more convenient anyway since it is compared to a size_t variable.
11562
c5101a77
PE
11563 Variadic C functions now count arguments with size_t, not int.
11564 This avoids an unnecessary limitation on 64-bit machines, which
11565 caused (substring ...) to crash on large vectors (Bug#8344).
11566 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11567 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11568 All variadic functions and their callers changed accordingly.
c5101a77
PE
11569 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11570 * data.c (arith_driver, float_arith_driver): Likewise.
11571 * editfns.c (general_insert_function): Likewise.
11572 * eval.c (struct backtrace.nargs, interactive_p)
11573 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11574 (funcall_lambda, mark_backtrace): Likewise.
11575 * fns.c (concat): Likewise.
11576 * frame.c (x_set_frame_parameters): Likewise.
11577 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11578 0 if not found, not -1. All callers changed.
11579
dd3f25f7
PE
11580 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11581 (stack_copy_size): Now size_t, not int.
11582 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11583
461c2ab9
JB
115842011-03-28 Juanma Barranquero <lekktu@gmail.com>
11585
11586 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11587 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11588 All callers changed.
11589
11590 * lisp.h (multibyte_char_to_unibyte):
11591 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11592 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11593 * character.h (CHAR_TO_BYTE8):
11594 * cmds.c (internal_self_insert):
11595 * editfns.c (general_insert_function):
11596 * keymap.c (push_key_description):
11597 * search.c (Freplace_match):
11598 * xdisp.c (message_dolog, set_message_1): All callers changed.
11599
f6d62986
SM
116002011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11601
11602 * keyboard.c (safe_run_hook_funcall): New function.
11603 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11604 don't set the hook to nil, but remove the offending function instead.
11605 (Qcommand_hook_internal): Remove, unused.
11606 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11607 Vcommand_hook_internal.
11608
11609 * eval.c (enum run_hooks_condition): Remove.
11610 (funcall_nil, funcall_not): New functions.
11611 (run_hook_with_args): Call each function through a `funcall' argument.
11612 Remove `cond' argument, now redundant.
11613 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11614 (Frun_hook_with_args_until_failure): Adjust accordingly.
11615 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11616
1db5b1ad
JB
116172011-03-28 Juanma Barranquero <lekktu@gmail.com>
11618
11619 * dispextern.h (string_buffer_position): Remove declaration.
11620
11621 * print.c (strout): Remove parameter `multibyte', unused since
11622 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11623
11624 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11625 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11626 All callers changed.
11627
11628 * w32.c (_wsa_errlist): Use braces for struct initializers.
11629
11630 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11631 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11632 All callers changed.
11633 (string_buffer_position): Likewise. Also, make static (it's never
11634 used outside xdisp.c).
11635 (cursor_row_p): Remove parameter `w', unused since
11636 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11637 (decode_mode_spec): Remove parameter `precision', introduced during
11638 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11639 All callers changed.
11640
5ffb62aa
JD
116412011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11642
11643 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11644
461c2ab9 116452011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11646
11647 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11648 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11649 (ns_update_auto_hide_menu_bar): New functions.
11650 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11651 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11652 ns_constrain_all_frames.
11653 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11654 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11655
5c380ffb
JD
116562011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11657
11658 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11659
9af30bdf
GM
116602011-03-27 Glenn Morris <rgm@gnu.org>
11661
11662 * syssignal.h: Replace RETSIGTYPE with void.
11663 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11664 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11665 Replace SIGTYPE with void everywhere.
11666 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11667 * s/template.h (SIGTYPE): Remove commented out definition.
11668
e2abce01
JB
116692011-03-26 Eli Zaretskii <eliz@gnu.org>
11670
11671 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11672 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11673
f868cd8a
JB
116742011-03-26 Juanma Barranquero <lekktu@gmail.com>
11675
59eb0929
JB
11676 * w32.c (read_unc_volume): Use parameter `henum', instead of
11677 global variable `wget_enum_handle'.
11678
11679 * keymap.c (describe_vector): Remove parameters `indices' and
11680 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11681 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11682
f868cd8a
JB
11683 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11684
11685 * keyboard.c (timer_check): Remove parameter `do_it_now',
11686 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11687 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11688 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11689
11690 * keyboard.c (read_char):
11691 * w32menu.c (w32_menu_display_help):
11692 * xmenu.c (show_help_event, menu_help_callback):
11693 Adjust calls to `show_help_echo'.
11694
11695 * gtkutil.c (xg_maybe_add_timer):
11696 * keyboard.c (readable_events):
11697 * process.c (wait_reading_process_output):
11698 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11699
11700 * insdel.c (adjust_markers_gap_motion):
11701 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11702 (gap_left, gap_right): Don't call it.
11703
2ecf6fdb
CY
117042011-03-25 Chong Yidong <cyd@stupidchicken.com>
11705
11706 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11707 incurred during fontification.
11708
6b1f9ba4
JB
117092011-03-25 Juanma Barranquero <lekktu@gmail.com>
11710
11711 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11712 (DEFVAR_PER_BUFFER): Don't pass it.
11713
11714 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11715 (scrolling_window): Don't pass it.
11716
0f4a96b5
JB
117172011-03-25 Juanma Barranquero <lekktu@gmail.com>
11718
11719 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11720
11721 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11722 and `suffix'.
11723 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11724 of variables specific to SELinux and computation of `encoded_absname'.
11725
11726 * image.c (XPutPixel): Remove unused variable `height'.
11727
11728 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11729
11730 * unexw32.c (get_section_info): Remove unused variable `section'.
11731
11732 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11733 (system_process_attributes): Remove unused variable `sess'.
11734 (sys_read): Remove unused variable `err'.
11735
11736 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11737 (w32_wnd_proc): Remove unused variable `isdead'.
11738 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11739 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11740 (x_create_tip_frame): Remove unused variable `tem'.
11741
11742 * w32inevt.c (w32_console_read_socket):
11743 Remove unused variable `no_events'.
11744
11745 * w32term.c (x_draw_composite_glyph_string_foreground):
11746 Remove unused variable `width'.
11747
1149507c
JB
117482011-03-24 Juanma Barranquero <lekktu@gmail.com>
11749
11750 * w32term.c (x_set_glyph_string_clipping):
11751 Don't pass uninitialized region to CombineRgn.
11752
9c88f339
JB
117532011-03-23 Juanma Barranquero <lekktu@gmail.com>
11754
11755 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11756 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11757 (Fx_close_connection): Remove unused variable `i'.
11758
11759 * w32font.c (w32font_draw): Return number of glyphs.
11760 (w32font_open_internal): Remove unused variable `i'.
11761 (w32font_driver): Add missing initializer.
11762
11763 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11764 (fill_in_menu): Remove unused variable `items_added'.
11765
11766 * w32term.c (last_mouse_press_frame): Remove static global variable.
11767 (w32_clip_to_row): Remove unused variable `f'.
11768 (x_delete_terminal): Remove unused variable `i'.
11769
11770 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11771 (NOTHING): Remove unused static global variable.
11772 (uniscribe_check_otf): Remove unused variable `table'.
11773 (uniscribe_font_driver): Add missing initializers.
11774
dee091a3
JD
117752011-03-23 Julien Danjou <julien@danjou.info>
11776
11777 * term.c (Fsuspend_tty, Fresume_tty):
11778 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11779 * window.c (temp_output_buffer_show):
11780 * insdel.c (signal_before_change):
11781 * frame.c (Fhandle_switch_frame):
11782 * fileio.c (Fdo_auto_save):
11783 * emacs.c (Fkill_emacs):
11784 * editfns.c (save_excursion_restore):
11785 * cmds.c (internal_self_insert):
11786 * callint.c (Fcall_interactively):
11787 * buffer.c (Fkill_all_local_variables):
11788 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11789 Use Frun_hooks.
0f4a96b5 11790 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11791 unconditionally since it does the check itself.
dee091a3 11792
2c520ab5 117932011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11794
c9c49752
PE
11795 Fix more problems found by GCC 4.5.2's static checks.
11796
8abc3f12
PE
11797 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11798 the first time through the loop, since we know p0 < p1 then.
11799 This also avoids a gcc -Wstrict-overflow warning.
11800
a2d26660
PE
11801 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11802 leading to a memory leak, possible in functions like
11803 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11804 of objects (Bug#8318).
a2d26660 11805
916c72e9
PE
11806 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11807 that could (at least in theory) be that large.
11808
19ab8a18
PE
11809 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11810 This is less likely to overflow, and avoids undefined behavior if
11811 overflow does occur. All callers changed. Use strtoul to scan
11812 for the unsigned long integer.
b7cbbd6f
PE
11813 (pint2hrstr): Simplify and tune code slightly.
11814 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11815
f0641eff
PE
11816 * scroll.c (do_scrolling): Work around GCC bug 48228.
11817 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11818
7f650bb9
PE
11819 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11820 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11821 (validate_x_resource_name): Simplify count usage.
11822 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11823
37dd57d1
PE
11824 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11825 fail (Bug#8306).
81e56e61 11826
699979fc 11827 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11828
401bf9b4
PE
11829 * process.c (Fmake_network_process): Use socklen_t, not int,
11830 where POSIX says socklen_t is required in portable programs.
11831 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11832 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11833 (Fmake_network_process, server_accept_connection):
11834 (wait_reading_process_output, read_process_output):
11835 Likewise.
11836
b93aacde
PE
11837 * process.c: Rename or move locals to avoid shadowing.
11838 (list_processes_1, Fmake_network_process):
11839 (read_process_output_error_handler, exec_sentinel_error_handler):
11840 Rename or move locals.
4dc343ee 11841 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11842 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11843 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11844 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11845 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11846
af8a867c 11847 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11848 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11849 Include tparam.h instead, since it declares them.
af8a867c
PE
11850 * cm.h (PC): Remove extern decl; tparam.h now does this.
11851 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11852 * terminfo.c: Include tparam.h, to check interfaces.
11853 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11854 (tparam): Adjust signature to match interface in tparam.h;
11855 this removes some undefined behavior. Check that outstring and len
11856 are zero, which they always are with Emacs.
11857 * tparam.h (PC, BC, UP): New extern decls.
11858
0248044d 11859 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11860 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11861
8ff096c1 11862 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11863 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11864 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11865 (ftfont_list): Remove unused local.
49eaafba
PE
11866 (get_adstyle_property, ftfont_pattern_entity):
11867 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11868 Rename locals to avoid shadowing.
8ff096c1 11869
e2be39f6
PE
11870 * xfont.c (xfont_list_family): Mark var as initialized.
11871
c9735e30
PE
11872 * xml.c (make_dom): Now static.
11873
8f5201ae
PE
11874 * composite.c (composition_compute_stop_pos): Rename local to
11875 avoid shadowing.
b246f932
PE
11876 (composition_reseat_it): Remove unused locals.
11877 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11878 (composition_update_it): Mark var as initialized.
11b61122
PE
11879 (find_automatic_composition): Mark vars as initialized,
11880 with a FIXME (Bug#8290).
8f5201ae 11881
760fbc2c
PE
11882 character.h: Rename locals to avoid shadowing.
11883 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11884 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11885 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11886 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11887 to avoid shadowing.
11888
ff08eb85
PE
11889 * textprop.c (property_change_between_p): Remove; unused.
11890
fc7bf025
PE
11891 * intervals.c (interval_start_pos): Now static.
11892
235d7abc
PE
11893 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11894
44f230aa
SM
11895 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11896 Rename locals to avoid shadowing.
3e7d6594 11897
50060332
PE
11898 * sound.c (wav_play, au_play, Fplay_sound_internal):
11899 Fix pointer signedness.
d01f234b 11900 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11901 (wav_play): Initialize a variable to 0, to prevent undefined
11902 behavior (Bug#8278).
50060332 11903
c4fc4e30
PE
11904 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11905
918436ed
PE
11906 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11907
c939f91b
PE
11908 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11909 clobbering (Bug#8298).
b9c7f648
PE
11910 * sysdep.c (sys_subshell): Likewise.
11911 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11912
6bd8c144
PE
11913 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11914 This should get cleaned up, so that child_setup has the
11915 same signature on all platforms.
11916
7710357c 11917 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11918 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11919
c59da222
CY
119202011-03-22 Chong Yidong <cyd@stupidchicken.com>
11921
11922 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11923 not to be necessary, and produces flickering.
11924
66b87493
GM
119252011-03-20 Glenn Morris <rgm@gnu.org>
11926
11927 * config.in: Remove file.
11928
45b6f6d5
JB
119292011-03-20 Juanma Barranquero <lekktu@gmail.com>
11930
11931 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11932 are now in src/globals.h.
11933 (syms_of_minibuf): Remove spurious & from previous change.
11934
cd394be1 119352011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11936
11937 * minibuf.c (completing-read-function): New variable.
11938 (completing-read-default): Rename from completing-read.
11939 (completing-read): Call completing-read-function.
11940
b14e3e21
CY
119412011-03-19 Juanma Barranquero <lekktu@gmail.com>
11942
11943 * xfaces.c (Fx_load_color_file):
11944 Read color file from absolute filename (bug#8250).
11945
f2b726e6
JB
119462011-03-19 Juanma Barranquero <lekktu@gmail.com>
11947
11948 * makefile.w32-in: Update dependencies.
11949
09f6ff02
EZ
119502011-03-17 Eli Zaretskii <eliz@gnu.org>
11951
11952 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11953
29a6015a
PE
119542011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11955
a3a6c54e
PE
11956 Fix more problems found by GCC 4.5.2's static checks.
11957
b766f867
PE
11958 * process.c (make_serial_process_unwind, send_process_trap):
11959 (sigchld_handler): Now static.
11960
be02381c
PE
11961 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11962 That way, the code declares only the vars that it needs.
11963 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11964 * s/cygwin.h (PTY_ITERATION): Likewise.
11965 * s/darwin.h (PTY_ITERATION): Likewise.
11966 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11967
57048744
PE
11968 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11969 * process.c (allocate_pty): Don't declare stb unless it's needed.
11970
7914961c 11971 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11972 (CONSTANTLIM): Remove; unused.
11973 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11974 Define only if needed.
7914961c 11975
b3967b18
PE
11976 * unexelf.c (unexec): Name an expression,
11977 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11978 Use a different way to cause a compilation error if anyone uses
11979 n rather than nn, a way that does not involve shadowing.
73366a00 11980 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11981
29a6015a
PE
11982 * deps.mk (unexalpha.o): Remove; unused.
11983
43cfc33e 11984 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11985 * unexec.h: New file.
ce701a33
PE
11986 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11987 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11988 Depend on unexec.h.
11989 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11990 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11991 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11992 Change as necessary to match prototype in unexec.h.
ce701a33 11993
01f44d5a
PE
11994 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11995 shadowing.
4f63c6bb 11996 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11997
a6670b0b
PE
11998 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11999 Rename locals to avoid shadowing.
12000
cef2010d 12001 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12002 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12003
d4d7173a
PE
12004 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12005
f08b802a
PE
12006 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12007 warning when compiling print.c.
12008
3ddb0639
PE
12009 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12010 instead of using an uninitialized var.
5ad03b97 12011 (font_sort_entities): Mark var as initialized.
3ddb0639 12012
170a2692
PE
12013 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12014
e663c700
PE
12015 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12016 pointers to constants.
89bc529a 12017 (font_parse_fcname): Remove unused vars.
7b81e2d0 12018 (font_delete_unmatched): Now static.
ea838e10 12019 (font_get_spec): Remove; unused.
13a547c6
PE
12020 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12021 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12022 Rename or move locals to avoid shadowing.
e663c700 12023
2a80c887 12024 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12025 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12026
1384fa33 12027 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12028 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12029
8b2c52e9
PE
12030 * alloc.c (mark_backtrace): Move decl from here ...
12031 * lisp.h: ... to here, so that it can be checked.
12032
475545b5 12033 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12034 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12035 (lisp_indirect_variable): Name an expression,
12036 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12037 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12038
b1349114 12039 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12040 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12041 Use const pointer when appropriate.
b1349114 12042
a2928364
PE
12043 * lisp.h (get_system_name, get_operating_system_release):
12044 Move decls here, to check interfaces.
12045 * process.c (get_operating_system_release): Move decl to lisp.h.
12046 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12047 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12048 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12049 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12050 (Fformat_time_string, Fencode_time, Finsert_char):
12051 (Ftranslate_region_internal, Fformat):
12052 Rename or remove local vars to avoid shadowing.
9710023e 12053 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12054
a415e694
PE
12055 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12056 avoid shadowing.
12057
8ef4622d
PE
12058 * lisp.h (eassert): Check that the argument compiles, even if
12059 ENABLE_CHECKING is not defined.
12060
946f9a5b
PE
12061 * data.c (Findirect_variable): Name an expression, to avoid
12062 gcc -Wbad-function-cast warning.
112396d6 12063 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12064 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12065 (Fmake_variable_buffer_local, Fmake_local_variable):
12066 Mark variables as initialized.
52746918 12067 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12068
e5aab7e7 12069 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12070 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12071 Rename locals to avoid shadowing.
dff45157
PE
12072 (mark_stack): Move local variables into the #ifdef region where
12073 they're used.
7bc26fdb
PE
12074 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12075 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12076 needed otherwise.
12077 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12078 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12079 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12080
e5aab7e7
PE
12081 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12082 avoids undefined behavior in theory.
12083
4da60324
PE
12084 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12085
88043301
PE
12086 Use functions, not macros, for up- and down-casing (Bug#8254).
12087 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12088 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12089 to use the following functions instead of these macros.
12090 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12091 EMACS_INT, since callers assume the returned value fits in int.
12092 (upcase1): Likewise, for UPCASE_TABLE.
12093 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12094 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12095 the race-condition problem in the old DOWNCASE.
88043301 12096
19ed5445
PE
12097 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12098 Rename locals to avoid shadowing.
12099 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12100 (regex_compile, re_search_2, re_match_2_internal):
12101 Remove unused local vars.
952db0d7
PE
12102 (FREE_VAR): Rewrite so as not to use empty "else",
12103 which gcc can warn about.
da053e48 12104 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12105 (RETALLOC_IF): Define only if needed.
12106 (WORDCHAR_P): Likewise. This one is never needed, but is used
12107 only in a comment talking about a compiler bug, so put inside
12108 the #if 0 of that comment.
12109 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12110 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12111 Remove; unused.
19ed5445 12112
1f3561e4 12113 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12114 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12115 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12116
ded6f8f7
PE
12117 * search.c (simple_search): Remove unused var.
12118
dbd37a95
PE
12119 * dired.c (compile_pattern): Move decl from here ...
12120 * lisp.h: ... to here, so that it can be checked.
12121 (struct re_registers): New forward decl.
12122
7e47afad
PE
12123 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12124
85f24f61
PE
12125 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12126 All uses changed.
12127 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12128 Rename locals to avoid shadowing.
5671df8f 12129 (Fvertical_motion): Mark locals as initialized.
85f24f61 12130
181aa2be 12131 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12132 (casify_region): Mark local as initialized.
181aa2be 12133
930d429c
PE
12134 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12135
7082eac6
PE
12136 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12137 New macros, so that the caller can use some names other than
12138 gcpro1, gcpro2, etc.
12139 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12140 of the new macros.
12141 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12142 argument, for consistency with GCPRO2_VAR, etc: it is now the
12143 prefix of the variable, not the variable itself. All uses
12144 changed.
38b2c076
PE
12145 * dired.c (directory_files_internal, file_name_completion):
12146 Rename locals to avoid shadowing.
12147
15206ed9
PE
12148 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12149 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12150 dired.c's scmp function, had undefined behavior.
12151 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12152 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12153 * buffer.h: ... to here, because these macros use current_buffer,
12154 and the new implementation with inline functions needs to have
12155 current_buffer in scope now, rather than later when the macros
12156 are used.
12157 (downcase, upcase1): New static inline functions.
12158 (DOWNCASE, UPCASE1): Reimplement using these functions.
12159 This avoids undefined behavior in expressions like
12160 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12161 from race conditions in accessing the global variables
12162 case_temp1 and case_temp2.
12163 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12164 * lisp.h (case_temp1, case_temp2): Remove their decls.
12165 * character.h (ASCII_CHAR_P): Move from here ...
12166 * lisp.h: ... to here, so that the inline functions mentioned
12167 above can use them.
12168
4a6bea26
PE
12169 * dired.c (directory_files_internal_unwind): Now static.
12170
f14b7e14
PE
12171 * fileio.c (file_name_as_directory, directory_file_name):
12172 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12173 Now static.
2893f146
PE
12174 (file_name_as_directory): Use const pointers when appropriate.
12175 (Fexpand_file_name): Likewise. In particular, newdir might
12176 point at constant storage, so make it a const pointer.
fd4ead52 12177 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12178 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12179 signedness issues.
f839df0c
PE
12180 (Fset_file_times, Finsert_file_contents, auto_save_error):
12181 Rename locals to avoid shadowing.
f14b7e14 12182
5716756e 12183 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12184 (Ftry_completion, Fall_completions): Rename or remove locals
12185 to avoid shadowing.
5716756e 12186
b4c3046a
PE
12187 * marker.c (bytepos_to_charpos): Remove; unused.
12188
b45db522
PE
12189 * lisp.h (verify_bytepos, count_markers): New decls,
12190 so that gcc does not warn that these functions aren't declared.
12191
85876d07
PE
12192 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12193 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12194 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12195 (copy_text): Remove unused local var.
85876d07 12196
03d78a21 12197 * filelock.c (within_one_second): Now static.
b3dd38ab 12198 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12199
5df8f01b
PE
12200 * buffer.c (fix_overlays_before): Mark locals as initialized.
12201 (fix_start_end_in_overlays): Likewise. This function should be
12202 simplified by using pointers-to-pointers, but that's a different
12203 matter.
b1d876f1 12204 (switch_to_buffer_1): Now static.
8f54f30a
PE
12205 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12206 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12207
a70072c9 12208 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12209 Fix pointer signedness issue.
edced198
PE
12210 (sys_subshell): Mark local as volatile if checking for lint,
12211 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12212 (MAXPATHLEN): Define only if needed.
a70072c9 12213
a0977c44
PE
12214 * process.c (serial_open, serial_configure): Move decls from here ...
12215 * systty.h: ... to here, so that they can be checked.
12216
a884fdcc
PE
12217 * fns.c (get_random, seed_random): Move extern decls from here ...
12218 * lisp.h: ... to here, so that they can be checked.
12219
604efe86 12220 * sysdep.c (reset_io): Now static.
b8950c94 12221 (wait_for_termination_signal): Remove; unused.
604efe86 12222
38fc62d9
PE
12223 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12224 (copy_keymap_item, append_key, push_text_char_description):
12225 Now static.
1004a21a 12226 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12227 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12228 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12229 (describe_map_tree):
12230 Rename locals to avoid shadowing.
38fc62d9 12231
2f2650da
PE
12232 * keyboard.c: Declare functions static if they are not used elsewhere.
12233 (echo_char, echo_dash, cmd_error, top_level_2):
12234 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12235 (read_char, kbd_buffer_get_event, make_lispy_position):
12236 (make_lispy_event, make_lispy_movement, apply_modifiers):
12237 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12238 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12239 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12240 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12241 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12242
a053e86c 12243 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12244 (mark_kboards): Move decl here ...
12245 * alloc.c (mark_kboards): ... from here.
a053e86c 12246
4752793e
PE
12247 * lisp.h (force_auto_save_soon): New decl.
12248
74f10ca7 12249 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12250 (DEFINE_DUMMY_FUNCTION): New macro.
12251 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12252 Use it.
c03cd23f
PE
12253 (main): Add casts to avoid warnings
12254 if GCC considers string literals to be constants.
74f10ca7 12255
022e70d4
PE
12256 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12257
59d6fe83
PE
12258 * dbusbind.c: Pointer signedness fixes.
12259 (xd_signature, xd_append_arg, xd_initialize):
12260 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12261 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12262 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12263 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12264
78320123
PE
12265 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12266 if GCC considers string literals to be constants.
49cebcca 12267 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12268
35ac2a97
SM
122692011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12270
fb103ca9
SM
12271 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12272 (print_preprocess, print_object): New macro to fix last change.
12273
35ac2a97
SM
12274 * print.c (print_preprocess): Don't forget font objects.
12275
62973b41
JB
122762011-03-16 Juanma Barranquero <lekktu@gmail.com>
12277
12278 * emacs.c (USAGE3): Doc fixes.
12279
0e48bb22
AS
122802011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12281
12282 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12283 structure.
12284
7684e57b
JB
122852011-03-14 Juanma Barranquero <lekktu@gmail.com>
12286
12287 * lisp.h (VWindow_system, Qfile_name_history):
12288 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12289 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12290 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12291
12292 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12293 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12294
12295 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12296 * w32console.c (detect_input_pending, read_input_pending)
12297 (encode_terminal_code):
12298 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12299 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12300 (w32_system_caret_y, Qfile_name_history):
12301 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12302 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12303 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12304 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12305 * w32proc.c (Qlocal, report_file_error):
12306 * w32term.c (Vwindow_system, updating_frame):
12307 * w32uniscribe.c (initialized, uniscribe_font_driver):
12308 Remove unneeded extern declarations.
12309
2aa46d6c
CY
123102011-03-14 Chong Yidong <cyd@stupidchicken.com>
12311
c96bbc66 12312 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12313
cffc6f3b
CY
123142011-03-13 Chong Yidong <cyd@stupidchicken.com>
12315
12316 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12317 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12318 These macros can no longer be used for assignment.
12319
44f230aa
SM
12320 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12321 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12322 (record_buffer_markers, fetch_buffer_markers): New functions for
12323 recording and fetching special buffer markers.
12324 (set_buffer_internal_1, set_buffer_temp): Use them.
12325
12326 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12327
12328 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12329
12330 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12331 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12332
12333 * xdisp.c (hscroll_window_tree):
12334 (reconsider_clip_changes): Use PT instead of BUF_PT.
12335
d251f04b
EZ
123362011-03-13 Eli Zaretskii <eliz@gnu.org>
12337
12338 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12339 $(EMACS_ROOT)/lib/intprops.h.
12340
f0c77cd1
PE
123412011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12342
3eca4629
PE
12343 Fix more problems found by GCC 4.5.2's static checks.
12344
7c86ee98
PE
12345 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12346 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12347 (xg_free_frame_widgets): Make it clear that a local variable is
12348 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12349 (gdk_window_get_screen): Make it clear that this macro is needed
12350 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12351 (int_gtk_range_get_value): New function, which avoids a diagnostic
12352 from gcc -Wbad-function-cast.
12353 (xg_set_toolkit_scroll_bar_thumb): Use it.
12354 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12355 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12356 (get_utf8_string, xg_get_file_with_chooser):
12357 Rename locals to avoid shadowing.
12358 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12359
41729b81
PE
12360 * xgselect.c (xg_select): Remove unused var.
12361
f0c77cd1
PE
12362 * image.c (four_corners_best): Mark locals as initialized.
12363 (gif_load): Initialize transparent_p to zero (Bug#8238).
12364 Mark another local as initialized.
ec6cf4c6 12365 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12366
ce0ad53d 12367 * image.c (clear_image_cache): Now static.
d5d5a617 12368 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12369 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12370 (x_edge_detection): Remove unnecessary cast that
12371 gcc -Wbad-function-cast diagnoses.
2037898d 12372 (gif_load): Fix pointer signedness.
6ae141d6
PE
12373 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12374 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12375
33383987 123762011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12377
d32df629
PE
12378 Improve quality of tests for time stamp overflow.
12379 For example, without this patch (encode-time 0 0 0 1 1
12380 1152921504606846976) returns the obviously-bogus value (-948597
12381 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12382 reports time overflow. See
12383 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12384 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12385 * editfns.c: Include limits.h and intprops.h.
12386 (TIME_T_MIN, TIME_T_MAX): New macros.
12387 (time_overflow): Move earlier, to before first use.
12388 (hi_time, lo_time): New functions, for an accurate test for
12389 out-of-range times.
12390 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12391 (Fget_internal_run_time): Don't assume time_t fits in int.
12392 (make_time): Use list2 instead of Fcons twice.
12393 (Fdecode_time): More accurate test for out-of-range times.
12394 (check_tm_member): New function.
12395 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12396 (lisp_time_argument): Don't rely on undefined left-shift and
12397 right-shift behavior when checking for time stamp overflow.
8be6f318 12398
fe31d94c
PE
12399 * editfns.c (time_overflow): New function, refactoring common code.
12400 (Fformat_time_string, Fdecode_time, Fencode_time):
12401 (Fcurrent_time_string): Use it.
12402
8be6f318
PE
12403 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12404 * dired.c (make_time): Move to ...
12405 * editfns.c (make_time): ... here.
12406 * systime.h: Note the move.
12407
09d9db2c 124082011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12409
126bc0dc
YM
12410 * fringe.c (update_window_fringes): Remove unused variables.
12411
c47cbdfd
YM
12412 * unexmacosx.c (copy_data_segment): Also copy __got section.
12413 (Bug#8223)
12414
7ac80be9
EZ
124152011-03-12 Eli Zaretskii <eliz@gnu.org>
12416
c96bbc66 12417 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12418 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12419 Constify `char *' arguments and their references according to
12420 prototypes in tparam.h.
12421
ecb0f94d 12422 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12423
7ac80be9
EZ
12424 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12425 Adapt all references accordingly.
12426
12427 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12428
ef1fd07e
TT
124292011-03-11 Tom Tromey <tromey@redhat.com>
12430
12431 * buffer.c (syms_of_buffer): Remove obsolete comment.
12432
7ef4b50c
EZ
124332011-03-11 Eli Zaretskii <eliz@gnu.org>
12434
12435 * termhooks.h (encode_terminal_code): Declare prototype.
12436
12437 * msdos.c (encode_terminal_code): Don't declare prototype.
12438
12439 * term.c (encode_terminal_code): Now external again, used by
12440 w32console.c and msdos.c.
12441
44f230aa
SM
12442 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12443 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12444
4b1ec863 124452011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12446
1714f52b 12447 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12448
4b1ec863
PE
12449 * fringe.c (update_window_fringes): Mark locals as initialized
12450 (Bug#8227).
12451 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12452
524c7aa6
PE
12453 * alloc.c (mark_fringe_data): Move decl from here ...
12454 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12455 to check its interface.
12456 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12457
a5c0af81 12458 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12459 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12460 (fontset_font): Mark local as initialized.
a9a06e0b 12461 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12462
b4716021
PE
12463 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12464
811e9bac 12465 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12466 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12467 (x_own_selection, Fx_disown_selection_internal): Rename locals
12468 to avoid shadowing.
12469 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12470
7e3ab302
PE
12471 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12472 so that the caller can use some name other than gcpro1.
12473 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12474 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12475 (Fx_backspace_delete_keys_p):
12476 Use them to avoid shadowing, and rename vars to avoid shadowing.
12477 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12478 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12479 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12480 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12481 Remove unused locals.
7e3ab302
PE
12482 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12483 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12484 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12485 macros.
f78faa98 12486
e2b13473
PE
12487 * xterm.h (x_mouse_leave): New decl.
12488
77f23912
PE
12489 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12490 Remove unused functions.
cdf4ba58
PE
12491 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12492 (x_calc_absolute_position): Now static.
7411c686 12493 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12494 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12495 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12496 unless they are used.
38d0b34a
PE
12497 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12498 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12499 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12500 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12501 (x_error_catcher, x_connection_closed, x_error_handler):
12502 (x_error_quitter, xembed_send_message, x_iconify_frame):
12503 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12504 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12505 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12506
44f230aa
SM
12507 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12508 Rename or move locals to avoid shadowing.
6b463e58 12509 (tty_defined_color, merge_face_heights): Now static.
5967d051 12510 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12511 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12512 does not deduce is never used uninitialized.
73719eba
PE
12513 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12514 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12515
426994c3 12516 * terminal.c (store_terminal_param): Now static.
5489860b 12517
032f1620 12518 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12519 (set_frame_menubar): Remove unused local.
d4323972 12520 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12521 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12522 since they might point to immutable storage.
281585b0
PE
12523 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12524 since it's unused otherwise.
032f1620 12525
367c19e5 12526 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12527 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12528 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12529 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12530 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12531 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12532 does not deduce are never used uninitialized.
70739cbe 12533
07b48fa9
PE
12534 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12535
8868a238 12536 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12537 * window.c (window_loop, size_window):
12538 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12539
7e5cf297 12540 * window.c (display_buffer): Now static.
d6550a9f
PE
12541 (size_window): Mark variables that gcc -Wuninitialized
12542 does not deduce are never used uninitialized.
a586633d
PE
12543 * window.h (check_all_windows): New decl, to forestall
12544 gcc -Wmissing-prototypes diagnostic.
5b555da1 12545 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12546
f6095868
PE
12547 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12548 shadowing.
12549 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12550 Include <limits.h>.
12551 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12552 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12553 (load_charset_map): Mark variables that gcc -Wuninitialized
12554 does not deduce are never used uninitialized.
53df7c11 12555 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12556
f38b440c
PE
12557 * coding.c (coding_set_source, coding_set_destination):
12558 Use "else { /* comment */ }" rather than "else /* comment */;"
12559 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12560 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12561 a block, when the outer 'i' will do.
12562 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12563 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12564 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12565 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12566 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12567 Rename locals to avoid shadowing.
12568 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12569 * coding.c (emacs_mule_char, encode_invocation_designation):
12570 Now static, since they're not used elsewhere.
413bb2db 12571 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12572 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12573 (decode_coding_emacs_mule): Mark variables that gcc
12574 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12575 (detect_coding_iso_2022): Initialize a local variable that might
12576 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12577 this initialization is needed. (Bug#8211)
5f58e762
PE
12578 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12579 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12580 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12581 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12582 Remove unused macros.
f38b440c 12583
232b38b9 12584 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12585 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12586 * character.c (string_count_byte8): Likewise.
232b38b9 12587
fb90da1b
PE
12588 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12589 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12590
fb93dbc2
PE
12591 * chartab.c (copy_sub_char_table): Now static, since it's not used
12592 elsewhere.
5c156ace
PE
12593 (sub_char_table_ref_and_range, char_table_ref_and_range):
12594 Rename locals to avoid shadowing.
bbcd0949 12595 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12596
7d3b3862 12597 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12598 (BIDI_BOB): Remove unused macro.
7d3b3862 12599
6be7d3da
PE
12600 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12601 deduce are never used uninitialized.
c2ed9c8b 12602 * term.c (encode_terminal_code): Likewise.
6be7d3da 12603
75f8807f 12604 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12605
50938595
PE
12606 * tparam.h: New file.
12607 * term.c, tparam.h: Include it.
12608 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12609 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12610 Move these decls to tparam.h, and make them agree with what
12611 is actually in tparam.c. The previous trick of using incompatible
12612 decls in different modules does not conform to the C standard.
12613 All callers of tparam changed to use tparam's actual API.
12614 * tparam.c (tparam1, tparam, tgoto):
12615 Use const pointers where appropriate.
12616
fbceeba2
PE
12617 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12618 * cm.h (struct cm): Likewise.
12619 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12620 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12621 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12622 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12623 (turn_on_face, init_tty): Likewise.
12624 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12625
7f3f1250
PE
12626 * term.c (term_mouse_position): Rename local to avoid shadowing.
12627
e6ca6543
PE
12628 * alloc.c (mark_ttys): Move decl from here ...
12629 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12630
c40f8d15
AS
126312011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12632
12633 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12634
cfe0661d
JB
126352011-03-09 Juanma Barranquero <lekktu@gmail.com>
12636
12637 * search.c (compile_pattern_1): Remove argument regp, unused since
12638 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12639 (compile_pattern): Don't pass it.
12640
0afb4571
J
126412011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12642
12643 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12644 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12645 for ! HAVE_GTK3.
12646 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12647
12648 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12649
12650 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12651 gdk_window_get_screen, gdk_window_get_geometry,
12652 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12653 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12654 (xg_get_pixbuf_from_pixmap): New function.
12655 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12656 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12657 Call xg_get_pixbuf_from_pixmap instead of
12658 gdk_pixbuf_get_from_drawable.
12659 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12660 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12661 (xg_check_special_colors): Use GtkStyleContext and its functions
12662 for HAVE_GTK3.
12663 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12664 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12665 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12666 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12667 Call gtk_widget_get_preferred_size.
0afb4571
J
12668 (xg_frame_resized): gdk_window_get_geometry only takes 5
12669 parameters.
44f230aa
SM
12670 (xg_win_to_widget, xg_event_is_for_menubar):
12671 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12672 (xg_set_widget_bg): New function.
12673 (delete_cb): New function.
895009e1 12674 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12675 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12676 (xg_set_background_color): Call xg_set_widget_bg.
12677 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12678 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12679 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12680 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12681 if ! HAVE_GTK3.
12682 (update_frame_tool_bar): Call gtk_widget_hide.
12683 (xg_initialize): Use GDK_KEY_g.
12684
12685 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12686 if ! HAVE_GTK3
12687 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12688
12689 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12690 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12691 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12692
1c2cc4ef
JB
126932011-03-08 Juanma Barranquero <lekktu@gmail.com>
12694
12695 * w32xfns.c (select_palette): Check success of RealizePalette against
12696 GDI_ERROR, not zero.
12697
33383987 12698See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12699
12700;; Local Variables:
12701;; coding: utf-8
aac0c6e3
MR
12702;; End:
12703
2f097256 12704 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12705
12706 This file is part of GNU Emacs.
12707
12708 GNU Emacs is free software: you can redistribute it and/or modify
12709 it under the terms of the GNU General Public License as published by
12710 the Free Software Foundation, either version 3 of the License, or
12711 (at your option) any later version.
12712
12713 GNU Emacs is distributed in the hope that it will be useful,
12714 but WITHOUT ANY WARRANTY; without even the implied warranty of
12715 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12716 GNU General Public License for more details.
12717
12718 You should have received a copy of the GNU General Public License
12719 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.