* window.el (split-window-sensibly): Make WINDOW argument
[bpt/emacs.git] / src / ChangeLog
CommitLineData
169925ec
DA
12012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Fix sweep_vectors to handle large bool vectors correctly.
4 * alloc.c (sweep_vectors): Account total_vector_bytes for
5 bool vectors larger than VBLOCK_BYTES_MAX.
6
5fbfb018
CY
72012-07-18 Chong Yidong <cyd@gnu.org>
8
9 * frame.c (x_set_frame_parameters): Revert bogus change introduced
10 in 2012-05-25 commit by Paul Eggert (Bug#11738).
11
3ab6e069
DA
122012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
13
14 Return more descriptive data from Fgarbage_collect.
15 Suggested by Stefan Monnier in
16 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
17 * alloc.c (bounded_number): New function.
18 (total_buffers, total_vectors): New variable.
19 (total_string_size): Rename to total_string_bytes, adjust users.
20 (total_vector_size): Rename to total_vector_bytes, adjust users.
21 (sweep_vectors): Account total_vectors and total_vector_bytes.
22 (Fgarbage_collect): New return value. Adjust documentation.
23 (gc_sweep): Account total_buffers.
24 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
25 (VECTOR_SIZE): Remove.
26 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
27 (Qinterval, Qmisc): New symbols.
28 (syms_of_data): Initialize them.
29 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
30 (Qcons, Qbuffer): New declarations.
31
6d02fe5b
PE
322012-07-17 Paul Eggert <eggert@cs.ucla.edu>
33
34 * alloc.c (Fmemory_free): Account for memory-free's own storage.
35 Round up, not down. Improve doc.
36
b7ffe040
DA
372012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
38
39 Restore old code in allocate_string_data to avoid Faset breakage.
40 Reported by Julien Danjou <julien@danjou.info> in
41 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
42 * alloc.c (allocate_string_data): Restore old code with minor
43 adjustments, fix comment to explain this subtle issue.
44
4dc7c8d5
SM
452012-07-17 Eli Zaretskii <eliz@gnu.org>
46
47 Remove FILE_SYSTEM_CASE.
48 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
49
50 * fileio.c (FILE_SYSTEM_CASE): Don't define.
51 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
52 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
53 call-process-region passes it through expand-file-name.
54
55 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
56
572012-07-17 Andreas Schwab <schwab@linux-m68k.org>
58
59 Fix crash when creating indirect buffer (Bug#11917)
60 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
61 Don't handle unbound variables specially if non-zero.
62 (Fbuffer_local_variables): Pass zero.
63 (clone_per_buffer_values): Pass non-zero.
64
652012-07-17 Andreas Schwab <schwab@linux-m68k.org>
66
67 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
68 to make the loop interruptible.
69
702012-07-17 Andreas Schwab <schwab@linux-m68k.org>
71
72 * gnutls.c (emacs_gnutls_handshake): Only retry if
73 GNUTLS_E_INTERRUPTED.
74
752012-07-17 Eli Zaretskii <eliz@gnu.org>
cce7fefc
DA
762012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
77
78 Cleanup and convert miscellaneous checks to eassert.
79 * alloc.c (mark_interval): Fix comment, partially rephrase
80 old comment from intervals.h (see below).
81 * intervals.c (find_interval, adjust_intervals_for_insertion)
82 (delete_interval, adjust_intervals_for_deletion)
83 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
84 Convert to eassert.
85 (adjust_intervals_for_insertion, make_new_interval):
86 Remove obsolete and unused code.
87 * intervals.h (struct interval): Remove obsolete comment.
88 * textprotp.c (erase_properties): Remove unused code.
89 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
90 (Fremove_list_of_text_properties): Convert to eassert.
91
9ea10cc3
CY
922012-07-17 Chong Yidong <cyd@gnu.org>
93
94 * editfns.c (Finsert_char): Doc fix.
95
3900d5de
DA
962012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
97
98 Fix previous change to make Fmemory_free always accurate.
99 * alloc.c (make_interval): Update total_free_intervals.
100 (make_float): Likewise for total_free_floats.
101 (free_cons, Fcons): Likewise for total_free_conses.
102 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
103 Likewise for total_free_vector_bytes.
104 (Fmake_symbol): Likewise for total_free_symbols.
105 (bytes_free): Remove.
106
7098646f
DA
1072012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
108
109 Simple free memory accounting feature.
110 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
111 (sweep_vectors): Accumulate size of free vectors.
112 (Fgarbage_collect): Setup bytes_free.
113 (Fmemory_free): New function.
114 (syms_of_alloc): Register it.
115
22657b40
DA
1162012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
117
118 Cleanup overlays checking.
119 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
120 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
121 eassert and OVERLAYP.
122 (sort_overlays): Change to use OVERLAYP.
123
ddfc8813
RK
1242012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
125
126 * editfns.c (Finsert_char): Make it interactive, and make the
127 second arg optional. Copy interactive spec and docstring from
128 ucs-insert.
129
7c26cf3c
PE
1302012-07-17 Paul Eggert <eggert@cs.ucla.edu>
131
132 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
133 Unlike the other wrapped functions, fabs has an unspecified
134 effect on errno.
135
5d127af9
JD
1362012-07-16 Jan Djärv <jan.h.d@swipnet.se>
137
138 * nsterm.m (keyDown): Interpret flags without left/right bits
139 as the left key (Bug#11670).
140
6a0dd1d7
DA
1412012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
142
143 Remove empty and useless init functions.
144 * lisp.h (init_character_once, init_fns, init_image)
145 (init_filelock, init_sound): Remove prototype.
146 * character.c (init_character_once): Remove.
147 * filelock.c (init_filelock): Likewise.
148 * fns.c (init_fns): Likewise.
149 * image.c (init_image): Likewise.
150 * sound.c (init_sound): Likewise.
151 * emacs.c (main): Adjust accordingly.
152
7a6136fd
DA
1532012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
154
155 * gtkutil.h: Tiny cleanups.
156 (use_old_gtk_file_dialog): Remove useless declaration.
157 (xg_uses_old_file_dialog): Add suggested const attribute.
158
ce811ad9
EZ
1592012-07-15 Eli Zaretskii <eliz@gnu.org>
160
161 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
162 (bidi_paragraph_init): Use it to limit search forward for a strong
163 directional character in abnormally large paragraphs full of
164 neutral or weak characters. (Bug#11943)
165
c9adfeaa
SF
1662012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
167
168 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
169 the toolbar (Bug#9451).
170 (xg_make_tool_item): Give the widget event box a transparent
171 background.
172
fff62aa9
DA
1732012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
174
175 Cleanup basic allocation variables and functions.
176 * alloc.c (ignore_warnings, init_intervals, init_float)
177 (init_cons, init_symbol, init_marker): Remove.
178 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
179 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
180 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
181 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
182 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
183 (staticidx, init_alloc_once, init_strings, free_ablock):
184 Remove redundant initialization.
185 * fns.c (init_weak_hash_tables): Remove.
186 * lisp.h (init_weak_hash_tables): Remove prototype.
187
9730daca
DA
1882012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Use zero_vector where appropriate.
191 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
192 accordingly.
193 * lisp.h (zero_vector): New declaration.
194 * font.c (null_vector): Remove.
195 (syms_of_font): Remove initialization and staticpro.
196 (font_list_entities, font_find_for_lface): Change to use zero_vector.
197 * keymap.c (Faccessible_keymaps): Likewise.
198
2e2d2a13
LL
1992012-07-15 Leo Liu <sdl.web@gmail.com>
200
201 * fringe.c: Fix typo in comments.
202
cd276f6e
LL
2032012-07-14 Leo Liu <sdl.web@gmail.com>
204
205 * fringe.c: Add a new bitmap exclamation-mark.
206
5a1131d9
EZ
2072012-07-14 Eli Zaretskii <eliz@gnu.org>
208
209 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
210
211 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
212 (HAVE_MENUS): Don't define, defined by editing config.in with
213 msdos/sed2v2.inp.
214 (GMALLOC_INHIBIT_VALLOC): Don't define.
215 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
216
22e983b7
JB
2172012-07-14 Juanma Barranquero <lekktu@gmail.com>
218
219 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
220
5b3f250f
GM
2212012-07-14 Glenn Morris <rgm@gnu.org>
222
223 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
224 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
225 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
226
33d63ff4
GM
2272012-07-13 Glenn Morris <rgm@gnu.org>
228
5b633342
GM
229 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
230
33d63ff4
GM
231 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
232 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
233
b55b9f85
JD
2342012-07-13 Jan Djärv <jan.h.d@swipnet.se>
235
0dc8cf50
JD
236 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
237 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
238 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
239 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
240 where appropriate.
241 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
242 as boolean expression.
243 (x_set_window_size): Remove unused variable toolbar.
244 (ns_get_color_default, ns_mod_to_lisp): Remove.
245 (ns_mouse_position): Remove unused variables xchar and ychar.
246 (ns_compute_glyph_string_overhangs): Remove unused variable face.
247 (ns_set_vertical_scroll_bar): Remove unused variable count.
248 (ns_delete_terminal): Remove unused variable i.
249 (ns_term_init): Remove unused variables r, g and b.
250 (mouseDown): Remove unused variable window.
251 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
252 (initFrameFromEmacs): Remove unused variable vbextra.
253 (mouseEntered): Remove unused variables p and dpyinfo.
254 (mouseExited): Remove unused variables p and r.
255 (ns_define_frame_cursor, ns_clear_frame_area)
256 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
257 (menuDown): Assign [sender tag] to variable and cast the variable.
258
259 * nsterm.h (menuDown): Add id as type to argument sender.
260 (ns_display_info_for_name): Add Lisp_Object argument.
261 (ns_term_init): Add Lisp_Object argument.
262 (ns_map_event_to_object): Add void argument.
263 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
264 prototype with arguments and only declare if __OBJC__.
265 (nxatoms_of_nsselect): Add void argument.
266 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
267 (ns_alloc_autorelease_pool): Add void argument.
268 (ns_release_autorelease_pool): Add void* argument.
269 (ns_get_defaults_value): Add const char* argument.
270
271 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
272 (initFromContents): Use SSDATA where appropriate.
273 (ns_update_menubar): Add braces to ambigous if-else.
274 (initWithTitle): Put () around assignment in if statement.
275 (ns_menu_show): Remove unused variables window and keymap.
276 (update_frame_tool_bar): Remove unused variable selected_p.
277 (initWithContentRect): Remove unused variable this_cmd_name.
278
279 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
280 appropriate.
281 (setXBMColor): Remove unused variable len.
282 (setPixmapData): Put () around assignment in loop statement.
283
284 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
285 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
286 where appropriate.
287 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
288 around assignment in loop statement.
289 (nsfont_open): Remove unused variable i.
290 (nsfont_open): Remove unused variable len.
291 (nsfont_draw): Remove unused variable cs.
292
293 * nsfns.m (x_set_icon_name, ns_set_name_internal)
294 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
295 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
296 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
297 (Fns_font_name, Fns_perform_service)
298 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
299 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
300 (ns_set_name): Remove unused variable view.
301 (x_set_menu_bar_lines): Remove unused variable olines.
302 (x_set_tool_bar_lines): Remove unused variable root_window.
303 (Fns_list_colors): Put () around assignment in while statement.
304 (Fns_perform_service): Remove unused variable len.
305 (Fns_display_usable_bounds): Remove unused variable top.
306 (syms_of_nsfns): Remove unused variable i.
307
b55b9f85
JD
308 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
309 memcpy (Bug#11907).
310
ed9265fc 3112012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
312
313 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
314 and free it with DestroyExceptionInfo (Bug#11558).
315
ef099b57
JB
3162012-07-13 Juanma Barranquero <lekktu@gmail.com>
317
318 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
319 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
320 Set here, not in nt/config.nt.
321
ea814a5d
EZ
3222012-07-13 Eli Zaretskii <eliz@gnu.org>
323
324 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
325 cursor overflow into the last glyph on display line when the right
326 fringe is off. (Bug#11832)
327
1a952767
PE
3282012-07-13 Paul Eggert <eggert@cs.ucla.edu>
329
330 * xdisp.c (produce_special_glyphs): Now static.
331 * dispextern.h (produce_special_glyphs): Remove decl.
332
983188fd
GM
3332012-07-13 Glenn Morris <rgm@gnu.org>
334
32fb4bb6
GM
335 * s/bsd-common, s/cygwin.h: Remove empty files.
336 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
337
983188fd
GM
338 * s/usg5-4-common.h (USG, USG5):
339 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
340 * s/sol2-6.h (SOLARIS2):
341 * s/irix6-5.h (IRIX6_5):
342 * s/hpux10-20.h (USG, USG5, HPUX):
343 * s/gnu-linux.h (USG, GNU_LINUX):
344 * s/freebsd.h (BSD_SYSTEM):
345 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
346 * s/cygwin.h (CYGWIN):
347 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
348 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
349
d1e68667 3502012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
351
352 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 353
6de0e799
GM
3542012-07-13 Glenn Morris <rgm@gnu.org>
355
739ae010
GM
356 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
357
dbee5793
GM
358 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
359
6de0e799
GM
360 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
361 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
362
b82da769
GM
3632012-07-12 Glenn Morris <rgm@gnu.org>
364
4fae5a7a 365 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
366
367 * process.c (init_process_emacs): Rename from init_process.
368 The old name is also the name of a Mach system call.
369 * lisp.h, emacs.c: Update for this name change.
370 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
371 longer needed.
372
5a979817
EZ
3732012-07-12 Eli Zaretskii <eliz@gnu.org>
374
375 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
376 memmove call that removes glyphs covered by the left truncation
377 glyph. Improve commentary.
378 (display_line): Fix display of continuation glyphs on GUI frames
379 when the right fringe is turned off and variable-size fonts are
380 used in the window. Move the code that appends a stretch glyph to
381 produce_special_glyphs, so that it could be used for truncation
382 and continuation glyphs alike.
383 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
384 glyph of a suitably computed width, to align the special glyphs at
385 the window margin. Code moved from display_line. (Bug#11832)
386
3e91a053
GM
3872012-07-12 Glenn Morris <rgm@gnu.org>
388
ba9e4b84
GM
389 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
390
391 * s/gnu-linux.h, s/hpux10-20.h:
392 Do not unconditionally define HAVE_XRMSETDATABASE.
393
3e91a053
GM
394 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
395
b300b1f4
PE
3962012-07-12 Paul Eggert <eggert@cs.ucla.edu>
397
398 Fix typos that broke OS X build.
399 Reported by Randal L. Schwartz in
400 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
401 * nsterm.m (ns_timeout): Add missing local decl.
402 (ns_get_color): snprintf -> sprintf, to fix typo.
403
6e777848
GM
4042012-07-12 Glenn Morris <rgm@gnu.org>
405
3f922c37
GM
406 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
407 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
408 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
409 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
410
0ab7b23a
GM
411 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
412 Move PTY_OPEN to configure.
413
6e777848
GM
414 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
415 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
416 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
417
4a7edc24
DA
4182012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
419
420 Use empty_unibyte_string where applicable.
421 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
422 * lread.c (read1): Likewise.
423 * xsettings.c (syms_of_xsettings): Likewise.
424
308aab79
GM
4252012-07-12 Glenn Morris <rgm@gnu.org>
426
42bd1719
GM
427 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
428 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
429 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
430 * s/hpux10-20.h (RUN_TIME_REMAP):
431 * s/bsd-common.h (TABDLY): Move to configure.
432
433 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
434
435 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
436
ea0bbd17 437 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 438 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
439
440 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 441
308aab79
GM
442 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
443 * s/template.h: Move NARROWPROTO to configure.
444
ee1cf5cf
GM
4452012-07-11 Glenn Morris <rgm@gnu.org>
446
30fe9bf4
GM
447 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
448 unused since 2011-01-17 change to systty.h.
449
ee1cf5cf
GM
450 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
451 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
452 Move HAVE_PTYS and HAVE_SOCKETS to configure.
453
63e47e07
PE
4542012-07-11 Paul Eggert <eggert@cs.ucla.edu>
455
456 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
457
c43fb4c3
GM
4582012-07-11 Glenn Morris <rgm@gnu.org>
459
460 * s/darwin.h, s/gnu-linux.h, s/template.h:
461 Move INTERRUPT_INPUT to configure.
462
e8df9267
DA
4632012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
464
465 Minor adjustments to interning code.
466 * lisp.h (intern, intern_c_string): Redefine as static inline
467 wrappers for intern_1 and intern_c_string_1, respectively.
468 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
469 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
470 Vobarray checking.
e8df9267
DA
471 * font.c (font_intern_prop): Likewise. Adjust comment.
472 * w32font.c (intern_font_name): Likewise.
473
34348bd4
AS
4742012-07-11 Andreas Schwab <schwab@linux-m68k.org>
475
d96a1e0c
AS
476 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
477
34348bd4
AS
478 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
479 of Fcar/Fcdr if possible.
480 * font.c (check_otf_features): Likewise.
481 * fontset.c (Fnew_fontset): Likewise.
482 * gnutls.c (Fgnutls_boot): Likewise.
483 * minibuf.c (read_minibuf): Likewise.
484 * msdos.c (IT_set_frame_parameters): Likewise.
485 * xmenu.c (Fx_popup_dialog): Likewise.
486 * w32menu.c (Fx_popup_dialog): Likewise.
487
c8add24e
GM
4882012-07-11 Glenn Morris <rgm@gnu.org>
489
4b575b3c
GM
490 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
491 since nothing has defined it on these platforms.
492
09f4e3b0
GM
493 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
494 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
495
172bedef
GM
496 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
497 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
498 Move CLASH_DETECTION to configure.
499
249685df
GM
500 * s/gnu.h: Remove file, which is now empty.
501
c8add24e
GM
502 * s/gnu.h, s/gnu-linux.h:
503 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
504
b41253a3
JW
5052012-07-11 John Wiegley <johnw@newartisans.com>
506
507 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
508 function attribute, so we only use it if it exists in the
509 compiler.
510
d923b542
DA
5112012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
512
513 Avoid call to strlen in fast_c_string_match_ignore_case.
514 * search.c (fast_c_string_match_ignore_case): Change to use
515 length argument. Adjust users accordingly.
516 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
517
5ebbef1d
PE
5182012-07-11 Paul Eggert <eggert@cs.ucla.edu>
519
bb352260
PE
520 Assume mkdir, rmdir.
521 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
522 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
523
57054ddd
PE
524 Assume rename.
525 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
526
b747d3f7
PE
527 Assume perror.
528 * s/hpux10-20.h (HAVE_PERROR): Remove.
529 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
530 Remove dummy definition, as this problem was obsolete long ago.
531
5ebbef1d
PE
532 Assume strerror.
533 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
534
984e7f30
DA
5352012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
536
537 Avoid calls to strlen in font processing functions.
538 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 539 (font_open_by_name): Change to use length argument. Adjust
984e7f30 540 users accordingly.
d923b542
DA
541 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
542 Adjust prototypes.
543 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
544 Change to return ptrdiff_t.
984e7f30
DA
545 (xfont_list_pattern, xfont_match): Use length returned by
546 xfont_decode_coding_xlfd.
547 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
548
20e94fdd
GM
5492012-07-11 Glenn Morris <rgm@gnu.org>
550
9d596af3
GM
551 * s/darwin.h, s/freebsd.h, s/netbsd.h:
552 Move DONT_REOPEN_PTY to configure.
553
20e94fdd
GM
554 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
555 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
556
e99a530f
PE
5572012-07-10 Paul Eggert <eggert@cs.ucla.edu>
558
22ffb973
PE
559 Remove "#define unix" that is no longer needed (Bug#11905).
560 * s/aix4-2.h (unix): Remove; no longer needed.
561
e9a9ae03
PE
562 EMACS_TIME simplification (Bug#11875).
563 This replaces macros (which typically do not work in GDB)
564 with functions, typedefs and enums, making the code easier to debug.
565 The functional style also makes code easier to read and maintain.
566 * systime.h: Include <sys/time.h> on all hosts, not just if
567 WINDOWSNT, since 'struct timeval' is needed in general.
568 (EMACS_TIME): Now a typedef, not a macro.
569 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
570 not macros.
571 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
572 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
573 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
574 (EMACS_TIME_LE): Now functions, not macros.
575 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
576 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
577 which are not functions. All uses rewritten to use:
578 (make_emacs_time): New function.
579 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
580 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
581 not functions. All uses rewritten to use the following, respectively:
582 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
583 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 584 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
585 * fileio.c (Fcopy_file):
586 * xterm.c (XTflash): Get the current time closer to when it's used.
587 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
588
ffacb126
PE
589 * bytecode.c (targets): Suppress -Woverride-init warnings.
590
e99a530f
PE
591 Simplify by avoiding confusing use of strncpy etc.
592 * doc.c (Fsnarf_documentation):
593 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
594 * frame.c (Fmake_terminal_frame):
595 * gtkutil.c (get_utf8_string):
596 * lread.c (openp):
597 * nsmenu.m (ns_update_menubar):
598 * regex.c (regerror):
599 Prefer memcpy to strncpy and strncat when either will do.
600 * fileio.c (Fsubstitute_in_file_name):
601 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
602 (menu_separator_name_p):
603 * nsmenu.m (ns_update_menubar):
604 Prefer memcmp to strncmp when either will do.
605 * nsterm.m: Include <ftoastr.h>.
606 (ns_get_color):
607 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
608 Prefer snprintf to strncpy.
609 * nsterm.m (ns_term_init):
610 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
611 * nsterm.m (ns_term_init):
612 Avoid the need for strncpy, by using build_string or
613 make_unibyte_string directly. Use dtoastr, not snprintf.
614 * process.c (Fmake_network_process): Diagnose service names that
615 are too long, rather than silently truncating them or creating
616 non-null-terminated names.
617 (Fnetwork_interface_info): Likewise, for interface names.
618 * sysdep.c (system_process_attributes) [GNU_LINUX]:
619 Prefer sprintf to strncat.
620 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
621 Prefer vsnprintf to vsprintf + strncpy.
622
c59592b3
GM
6232012-07-10 Glenn Morris <rgm@gnu.org>
624
625 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
626 Clarify fallback case.
627
7d7bbefd
DA
6282012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
629
630 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
631 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
632 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 633 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
634 where argument type is known to be a Lisp_Cons.
635
3a4c8000
TT
6362012-07-10 Tom Tromey <tromey@redhat.com>
637
638 * bytecode.c (BYTE_CODE_THREADED): New macro.
639 (BYTE_CODES): New macro. Replaces all old byte-code defines.
640 (enum byte_code_op): New type.
641 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
642 (exec_byte_code): Use them. Use token threading when applicable.
643
2a0213a6
DA
6442012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
645
646 Optimize pure C strings initialization.
647 * lisp.h (make_pure_string): Fix prototype.
648 (build_pure_c_string): New function, defined as static inline. This
649 provides a better opportunity to optimize away calls to strlen when
650 the function is called with compile-time constant argument.
651 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
652 argument, adjust users accordingly. Use build_pure_c_string where
653 appropriate.
654 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
655 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
656 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
657
cb1caeaf
DA
6582012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
659
660 Avoid calls to strlen in miscellaneous functions.
661 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
662 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
663 * lread.c (openp): Likewise.
664
c293e30c
DA
6652012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
666
667 Avoid calls to strlen in path processing functions.
668 * fileio.c (file_name_as_directory): Add comment. Change to add
669 srclen argument and return the length of result. Adjust users
670 accordingly.
671 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 672 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
673 users accordingly.
674 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
675
9e059e3f
GM
6762012-07-10 Glenn Morris <rgm@gnu.org>
677
d02eb359
GM
678 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
679 Move PENDING_OUTPUT_COUNT definition to configure.
680
882cf227
GM
681 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
682 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
683 * s/gnu.h (DATA_START): Move definitions to configure.
684
af6e839f
GM
685 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
686 We include usg5-4-common.h, which defines them both.
687
40289a12
GM
688 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
689 O_RDONLY already includes it).
690
9e059e3f
GM
691 Stop ns builds setting the EMACSLOADPATH environment variable.
692 * nsterm.m (ns_load_path): Rename from ns_init_paths.
693 Now it does not set EMACSLOADPATH, just returns the load-path string.
694 * nsterm.h: Update accordingly.
695 * lread.c [HAVE_NS]: Include nsterm.h.
696 (init_lread) [HAVE_NS]: Use ns_load_path.
697 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
698
7c4e8ec0
GM
6992012-07-09 Glenn Morris <rgm@gnu.org>
700
d4f600ff
GM
701 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
702 since the included bsd-common.h does so.
703
cbb31951
GM
704 Stop ns builds setting the EMACSPATH environment variable.
705 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
706 (ns_init_paths): Do not set EMACSPATH.
707 * nsterm.h (ns_exec_path): Add it.
708 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
709 Use ns_exec_path.
710
7c4e8ec0
GM
711 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
712
26bccfae
PE
7132012-07-09 Paul Eggert <eggert@cs.ucla.edu>
714
a0bee46f
PE
715 * process.c (wait_reading_process_output): 'waitchannels' was unset
716 when read_kbd || !NILP (wait_for_cell); fix this.
717
5994c183
PE
718 Add GCC-style 'const' attribute to functions that can use it.
719 * character.h (char_resolve_modifier_mask):
720 * keyboard.h (make_ctrl_char):
721 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
722 (init_character_once, next_almost_prime, init_fns, init_image)
723 (flush_pending_output, init_sound):
724 * mem-limits.h (start_of_data):
725 * menu.h (finish_menu_items):
726 Add ATTRIBUTE_CONST.
727 * emacs.c (DEFINE_DUMMY_FUNCTION):
728 Declare the dummy function with ATTRIBUTE_CONST.
729 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
730 Add decls with ATTRIBUTE_CONST.
731
26bccfae
PE
732 Minor improvements to make_formatted_string.
733 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
734 where int is good enough, as vsprintf returns an int.
735 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
736
a8290ec3
DA
7372012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
738
739 Use make_formatted_string to avoid double length calculation.
740 * lisp.h (make_formatted_string): New prototype.
741 * alloc.c (make_formatted_string): New function.
742 * buffer.c (Fgenerate_new_buffer_name): Use it.
743 * dbus.c (syms_of_dbusbind): Likewise.
744 * editfns.c (Fcurrent_time_zone): Likewise.
745 * filelock.c (get_boot_time): Likewise.
746 * frame.c (make_terminal_frame, set_term_frame_name)
747 (x_report_frame_params): Likewise.
748 * image.c (gs_load): Likewise.
749 * minibuf.c (get_minibuffer): Likewise.
750 * msdos.c (dos_set_window_size): Likewise.
751 * process.c (make_process): Likewise.
752 * xdisp.c (ensure_echo_area_buffers): Likewise.
753 * xsettings.c (apply_xft_settings): Likewise.
754
d01ba2f1
GM
7552012-07-09 Glenn Morris <rgm@gnu.org>
756
757 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
758 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
759 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
760 * nsterm.h (ns_etc_directory): Add it.
761 * callproc.c [HAVE_NS]: Include nsterm.h.
762 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
763
f1f924b6
DA
7642012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
765
766 Move marker debugging code under MARKER_DEBUG.
767 * marker.c (MARKER_DEBUG): Move marker debugging code under
768 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
769 for bootstrap with --enable-checking (~3x slowdown reported
770 by Juanma Barranquero <lekktu@gmail.com>).
771 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
772
ab531b66
PE
7732012-07-08 Paul Eggert <eggert@cs.ucla.edu>
774
775 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
776 See <http://bugs.gnu.org/11825#29>.
777
c4b3bc8a
EZ
7782012-07-08 Eli Zaretskii <eliz@gnu.org>
779
780 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
781 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
782 (display_line): Add commentary about displaying truncation glyphs
783 on GUI frames.
784 (produce_special_glyphs): Move here from term.c.
785
786 * term.c (produce_special_glyphs): Move to xdisp.c.
787
788 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
789 section.
c4b3bc8a 790
b676b881
AS
7912012-07-07 Andreas Schwab <schwab@linux-m68k.org>
792
f17c5273
AS
793 * xdisp.c (display_line): Avoid warning about implicit declaration
794 of FRAME_FONT.
795
298819b9
AS
796 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
797
b676b881
AS
798 * lisp.h: Remove empty conditional.
799
6045c4fd
PE
8002012-07-07 Paul Eggert <eggert@cs.ucla.edu>
801
b3350bf9
PE
802 * lread.c (load_path_check): Now static.
803
6045c4fd
PE
804 Fix some minor --with-ns problems found by static checking.
805 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
806 (x_set_font) [!HAVE_X_WINDOWS]:
807 * image.c (xpm_load_image) [HAVE_NS]:
808 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
809 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
810 Remove unused local.
811 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
812 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
813 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
814 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
815 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
816 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
817 Fix pointer signedness problem.
818 * xfaces.c (FRAME_X_FONT_TABLE):
819 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
820
929e7845
GM
8212012-07-07 Glenn Morris <rgm@gnu.org>
822
823 * lread.c (load_path_check): New function, split from init_lread.
824 (init_lread): Reorganize. Motivation:
825 If EMACSLOADPATH is set, check/warn about that rather than the
826 defaults, which we are not going to use. Hence we can remove
827 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
828 Don't warn if site-lisp directories are missing.
829 If not installed, start from a blank load-path, since
830 PATH_LOADSEARCH refers to the eventual installation directories.
831
58dd0aa4
EZ
8322012-07-07 Eli Zaretskii <eliz@gnu.org>
833
834 Support truncation and continuation glyphs on GUI frames, when
835 fringes are disabled. (Bug#11832)
836 * xdisp.c (init_iterator): Get dimensions of truncation and
837 continuation glyphs even if on GUI frames. Adjust
838 it->last_visible_x on GUI frames when the left or right fringes,
839 or both, are absent.
840 (start_display, move_it_in_display_line_to): Handle the case of a
841 GUI frame without a fringe to display continuation or truncation
842 glyphs.
843 (insert_left_trunc_glyphs): Support GUI frames: make sure
844 truncation glyphs overwrite enough glyphs from the current line to
845 have sufficient space in pixels.
846 (display_line): Support truncation and continuation glyphs on GUI
847 frames. If some spare pixels are left on the line after inserting
848 the truncation glyphs, fill that space with a stretch glyph of a
849 suitably computed width.
850
851 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
852 produce_glyphs, to support GUI sessions.
853
31571fd7
PE
8542012-07-07 Paul Eggert <eggert@cs.ucla.edu>
855
5a16b9bc
PE
856 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
857
f3047c75
PE
858 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
859
31571fd7
PE
860 Do not require float-time's arg to fit in time_t (Bug#11825).
861 This works better on hosts where time_t is unsigned, and where
862 float-time is applied to the (negative) difference between two times.
863 * editfns.c (decode_time_components): Last arg is now double *,
864 not int *, and means to store all the result as a double, without
865 worrying about whether the seconds part fits in time_t.
866 All callers changed.
867 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
868 All callers changed.
869 (Ffloat_time): Do not fail merely because the specified time falls
870 outside of time_t range.
871
4516fbef
GM
8722012-07-07 Glenn Morris <rgm@gnu.org>
873
874 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
875 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
876 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
877
07adc2c6
JB
8782012-07-07 Juanma Barranquero <lekktu@gmail.com>
879
880 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
881 Update dependencies.
882
883 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
884
fd573f31
PE
8852012-07-06 Paul Eggert <eggert@cs.ucla.edu>
886
fee5959d
PE
887 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
888 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
889 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
890 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
891 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
892 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
893
fd573f31
PE
894 * xfont.c (compare_font_names): Redo to omit the need for casts.
895
ddadbc0e
AS
8962012-07-06 Andreas Schwab <schwab@linux-m68k.org>
897
fca8d6b6
AS
898 * xfns.c (Fx_change_window_property): Doc fix.
899 * w32fns.c (Fx_change_window_property): Doc fix.
900
ddadbc0e
AS
901 * w32fns.c (Fx_window_property): Accept the same arguments as the
902 X Windows version. Doc fix.
903 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
904
ed9265fc 9052012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
906 Eli Zaretskii <eliz@gnu.org>
907
908 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
909 Windows-specific code from nt/config.nt moved here.
910 Obsolete settings removed.
911
216ee680
PE
9122012-07-06 Paul Eggert <eggert@cs.ucla.edu>
913
914 * process.c: Avoid unnecessary calls to gettime.
915 (wait_reading_process_output): Don't get the time of day
916 when gobbling data immediately and not waiting, as there's no need
917 for it in that case. This removes a FIXME.
918
bdd091e4
JD
9192012-07-06 Jan Djärv <jan.h.d@swipnet.se>
920
921 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
922 is defined (Bug#11768).
923
9d44f8ce
DA
9242012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
925
926 Fix marker debugging code.
927 * marker.c (byte_char_debug_check): Do not perform the check
928 if buffer is not multibyte.
090bd7cb
JB
929 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
930 Call byte_char_debug_check with correct arguments.
9d44f8ce 931
90fc4786
DA
9322012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
933
934 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
935 * marker.c (byte_char_debug_check, count_markers):
936 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
937 (byte_debug_flag): Remove.
938 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
939 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
940
7b7ae965
DA
9412012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
942
4e57b342
DA
943 Avoid code repetition in marker-related functions.
944 * marker.c (attach_marker): New function.
945 (Fset_marker, set_marker_restricted, set_marker_both)
946 (set_marker_restricted_both): Use it.
947 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
948 Consistently rename charno to charpos.
949 (marker_position): Add eassert.
950 (marker_byte_position): Convert to eassert.
951
9522012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
953
954 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 955 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 956 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 957
657924ff
DA
9582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
959
960 Introduce fast path for the widely used marker operation.
961 * alloc.c (build_marker): New function.
962 * lisp.h (build_marker): New prototype.
963 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
964 * composite.c (autocmp_chars): Likewise.
965 * editfns.c (buildmark): Remove.
966 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
967 (save_restriction_save): Use build_marker.
968 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
969 * window.c (save_window_save): Likewise.
970
041a49a6
DA
9712012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
972
973 Do not use Fdelete_overlay in delete_all_overlays
974 to avoid redundant calls to unchain_overlay.
975 * buffer.c (drop_overlay): New function.
976 (delete_all_overlays, Fdelete_overlay): Use it.
977 * minibuf.c (get_minibuffer): Fix comment.
978
7dca65a4
PE
9792012-07-06 Paul Eggert <eggert@cs.ucla.edu>
980
981 Port to OpenBSD 5.1 amd64.
982 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
983 This is needed for OpenBSD, and should be harmless on all BSD systems.
984 Also, include <sys/sysctl.h>, as it should be available on all
985 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
986 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
987 use p_pid member, not kp_proc.pid.
988
8eb876e2
GM
9892012-07-06 Glenn Morris <rgm@gnu.org>
990
991 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
992
38182d90
PE
9932012-07-05 Paul Eggert <eggert@cs.ucla.edu>
994
995 More xmalloc and related cleanup.
996 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
997 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
998 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
999 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1000 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1001 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1002 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1003 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1004 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1005 * xterm.c:
1006 Omit needless casts involving void * pointers and allocation.
1007 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1008 as the former is more robust if P's type is changed.
1009 Prefer xzalloc to xmalloc + memset 0.
1010 Simplify malloc-or-realloc to realloc.
1011 Don't worry about xmalloc returning a null pointer.
1012 Prefer xstrdup to xmalloc + strcpy.
1013 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1014 growing it.
1015 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1016 alloca of a constant.
1017
6dd5a677
EZ
10182012-07-05 Eli Zaretskii <eliz@gnu.org>
1019
1020 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1021 hscroll is larger than the line width. Fixes long and futile
1022 looping inside extend_face_to_end_of_line (on a TTY) producing
1023 glyphs that are not needed and thrown away.
1024
6b312f0f
DA
10252012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1026
1027 * marker.c (set_marker_restricted_both): Simplify by using
1028 clip_to_bounds.
1029
f520ef9b
PE
10302012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1031
1032 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1033
383b7c95
JD
10342012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1035
1036 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1037 not defined (Bug#11768).
1038 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1039 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1040 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1041 followed by gtk_box_set_homogeneous (Bug#11768).
1042 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1043 (update_theme_scrollbar_width, xg_create_scroll_bar):
1044 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1045 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1046 (is_box_type): New function (Bug#11768).
1047 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1048 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1049 with default display (Bug#11768).
1050
d6e7bf45
EZ
10512012-07-05 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (window_hscroll_limited): New function.
1054 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1055 coordinates when window's hscroll is set to insanely large
1056 values. (Bug#11857)
1057
431391ec
JB
10582012-07-05 Juanma Barranquero <lekktu@gmail.com>
1059
1060 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1061 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1062
23f86fce
DA
10632012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1064
1065 Cleanup xmalloc.
1066 * lisp.h (xzalloc): New prototype. Omit needless casts.
1067 * alloc.c (xzalloc): New function. Omit needless casts.
1068 * charset.c: Omit needless casts. Convert all calls to
1069 xmalloc with following memset to xzalloc.
1070 * dispnew.c: Likewise.
1071 * fringe.c: Likewise.
1072 * image.c: Likewise.
1073 * sound.c: Likewise.
1074 * term.c: Likewise.
1075 * w32fns.c: Likewise.
1076 * w32font.c: Likewise.
1077 * w32term.c: Likewise.
1078 * xfaces.c: Likewise.
1079 * xfns.c: Likewise.
1080 * xterm.c: Likewise.
1081 * atimer.c: Omit needless casts.
1082 * buffer.c: Likewise.
1083 * callproc.c: Likewise.
1084 * ccl.c: Likewise.
1085 * coding.c: Likewise.
1086 * composite.c: Likewise.
1087 * doc.c: Likewise.
1088 * doprnt.c: Likewise.
1089 * editfns.c: Likewise.
1090 * emacs.c: Likewise.
1091 * eval.c: Likewise.
1092 * filelock.c: Likewise.
1093 * fns.c: Likewise.
1094 * gtkutil.c: Likewise.
1095 * keyboard.c: Likewise.
1096 * lisp.h: Likewise.
1097 * lread.c: Likewise.
1098 * minibuf.c: Likewise.
1099 * msdos.c: Likewise.
1100 * print.c: Likewise.
1101 * process.c: Likewise.
1102 * region-cache.c: Likewise.
1103 * search.c: Likewise.
1104 * sysdep.c: Likewise.
1105 * termcap.c: Likewise.
1106 * terminal.c: Likewise.
1107 * tparam.c: Likewise.
1108 * w16select.c: Likewise.
1109 * w32.c: Likewise.
1110 * w32reg.c: Likewise.
1111 * w32select.c: Likewise.
1112 * w32uniscribe.c: Likewise.
1113 * widget.c: Likewise.
1114 * xdisp.c: Likewise.
1115 * xmenu.c: Likewise.
1116 * xrdb.c: Likewise.
1117 * xselect.c: Likewise.
1118
0497dc44
PE
11192012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 * fileio.c (time_error_value): Check the right error number.
1122 Problem reported by Troels Nielsen in
1123 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1124
356e7178
PE
11252012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1126
4e71fd89
PE
1127 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1128 This should be fixed in a better way; see Eli Zaretskii in
1129 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1130 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1131
f0941253
PE
1132 * fileio.c (time_error_value): Rename from special_mtime.
1133 The old name's problems were noted by Eli Zaretskii in
1134 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1135
065c9eb4
PE
1136 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1137 This variable's comment says Emacs needs at least one GDB-visible
1138 symbol of type enum pvec_type, to work around GDB problems.
1139 The symbol's value doesn't matter.
1140
356e7178
PE
1141 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1142 that causes compilation to fail on pre-C99 compilers.
1143
ed9265fc 11442012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1145
1146 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1147 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1148
3884d954
DA
11492012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1150
d209e2fb 1151 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1152 headers for buffer_defaults and buffer_local_symbols.
1153 Reported by Juanma Barranquero <lekktu@gmail.com>.
1154
ee28be33
SM
11552012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1156
1157 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1158 * lisp.h (enum pvec_type): Use fewer bits.
1159 (PSEUDOVECTOR_SIZE_BITS): New constant.
1160 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1161 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1162 change in pvec_type.
1163 (PSEUDOVECTOR_TYPEP): New macro.
1164 (TYPED_PSEUDOVECTORP): Use it.
1165 * fns.c (internal_equal): Adapt code to extract pvectype.
1166 * emacs.c (gdb_pvec_type): Update type.
1167 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1168 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1169 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1170 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1171 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1172 abusing vector->header.next.nbytes.
1173 (live_vector_p): Use PVEC_TYPE.
1174 (mark_object): Adapt code to extract pvectype. Use switch.
1175
c7f2cd7f
PE
11762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1179 Tighten new eassert a bit.
1180
8ce70ed2
DA
11812012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1182
1183 Fix compilation with --enable-gcc-warnings and -O1
1184 optimization level.
1185 * doprnt.c (doprnt): Change type of tem to int, initialize
1186 to avoid compiler warning. Add eassert.
1187 * search.c (simple_search): Initialize match_byte to avoid
1188 compiler warning. Add eassert.
1189
dea7f1e5
PE
11902012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1191
24a212eb
PE
1192 Avoid weird behavior with large horizontal scrolls.
1193 Without this change, for example, large hscroll values would
1194 mess up Emacs's display on Fedora 15 x86, presumably due to
1195 overflows in int calculations in the display code.
1196 Also, if buffers had long lines, Emacs would freeze.
1197 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1198 (set_window_hscroll): New function, containing the old guts of
1199 Fset_window_hscroll. Return the clipped value.
1200 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1201 This avoids the need to check against PTRDIFF_MAX.
1202
dea7f1e5
PE
1203 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1204
76046526
DA
12052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1208
39adff0d
PE
12092012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1210
63807d47
PE
1211 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1212 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1213 since GCC 4.4.6 issues a bogus warning for them.
1214
39adff0d
PE
1215 Fix bugs in file timestamp newness comparisons.
1216 * fileio.c (Ffile_newer_than_file_p):
1217 * lread.c (Fload): Use full timestamp resolution of files,
1218 not just the 1-second resolution, so that files that are only
1219 slightly newer still count as newer.
1220 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1221 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1222
dbeed9a6
PE
12232012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1224
1225 * fileio.c: Improve handling of file time marker. (Bug#11852)
1226 (special_mtime): New function.
1227 (Finsert_file_contents, Fverify_visited_file_modtime):
1228 Use it to set special mtime values consistently.
1229
636334d6
AS
12302012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1231
1232 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1233 marker for non-existing file. (Bug#11852)
1234
e2017fe2
GM
12352012-07-03 Glenn Morris <rgm@gnu.org>
1236
1237 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1238 and did not make it into globals.h).
1239
404dbd37
TT
12402012-07-03 Tom Tromey <tromey@redhat.com>
1241
1242 * window.c (Fset_window_margins, Fset_window_fringes)
1243 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1244 * textprop.c (Fprevious_property_change): No longer static.
1245 * syntax.c (Fsyntax_table_p): No longer static.
1246 * process.c (Fget_process, Fprocess_datagram_address): No longer
1247 static.
1248 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1249 * keyboard.c (Fcommand_execute): No longer static.
1250 Remove EXFUN.
1251 * insdel.c (Fcombine_after_change_execute): No longer static.
1252 * image.c (Finit_image_library): No longer static.
1253 * fileio.c (Fmake_symbolic_link): No longer static.
1254 * eval.c (Ffetch_bytecode): No longer static.
1255 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1256 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1257 No longer static.
404dbd37
TT
1258 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1259 static.
1260 * dired.c (Ffile_attributes): No longer static.
1261 * composite.c (Fcomposition_get_gstring): No longer static.
1262 * callproc.c (Fgetenv_internal): No longer static.
1263
1264 * ccl.h: Remove EXFUNs.
1265 * buffer.h: Remove EXFUNs.
1266 * dispextern.h: Remove EXFUNs.
1267 * intervals.h: Remove EXFUNs.
1268 * fontset.h: Remove EXFUN.
1269 * font.h: Remove EXFUNs.
1270 * dosfns.c (system_process_attributes): Remove EXFUN.
1271 * keymap.h: Remove EXFUNs.
1272 * lisp.h: Remove EXFUNs.
1273 * w32term.h: Remove EXFUNs.
1274 * window.h: Remove EXFUNs.
1275 * xsettings.h: Remove EXFUN.
1276 * xterm.h: Remove EXFUN.
1277
8e4fd1e1
GM
12782012-07-03 Glenn Morris <rgm@gnu.org>
1279
1280 * lisp.h (Frandom): Make it visible to C.
1281 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1282 buffer for invisible buffers. (Bug#1229)
1283
ca95b3eb
DA
12842012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1285
1286 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1287 values which aren't power of 2.
1288 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1289 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1290 accordingly.
1291
7555c33f
SM
12922012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1293
1294 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1295
1296 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1297
d12e8f5a
DA
12982012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1299
1300 * alloc.c (allocate_vector_block): Remove redundant
1301 calls to mallopt if DOUG_LEA_MALLOC is defined.
1302 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1303 avoid calls to mallopt if zero_vector is returned.
1304
296094c3
DA
13052012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1306
1307 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1308 is enabled, avoid dereferencing NULL current_sblock if
1309 running undumped.
1310
36429c89
DA
13112012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1312
1313 Cleanup basic buffer management.
1314 * buffer.h (struct buffer): Change layout to use generic vector
1315 marking code. Fix some comments. Change type of 'clip_changed'
1316 to bitfield. Remove unused #ifndef old.
1317 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1318 (GET_OVERLAYS_AT): Fix indentation.
1319 (for_each_per_buffer_object_at): New macro.
1320 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1321 (Fbuffer_local_variables): Use it.
1322 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1323 * alloc.c (allocate_buffer): Adjust to match new layout of
1324 struct buffer. Fix comment.
1325 (mark_overlay): New function.
1326 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1327 Lisp area of struct buffer.
1328 (mark_object): Use it. Adjust marking of misc objects
1329 and related comments.
1330
3b3e4cac
PE
13312012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1332
1333 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1334 wrapper that is not needed because the wrapped code is a no-op (zero
1335 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1336 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1337
cf5c0175
DA
13382012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1339
1340 * alloc.c (mark_buffer): Simplify. Remove prototype.
1341 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1342 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1343 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1344 redundant calls to mark_vectorlike for bool vectors.
1345
ca26824c
GM
13462012-06-30 Glenn Morris <rgm@gnu.org>
1347
2e4c5312
GM
1348 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1349
ca26824c
GM
1350 * epaths.in (PATH_SITELOADSEARCH): New.
1351 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1352 This is rather than relying on --enable-locallisppath elements
1353 having "site-lisp" in their names. (Bug#10208#25, 11658)
1354
0d23c240
EZ
13552012-06-30 Eli Zaretskii <eliz@gnu.org>
1356
c9240d7a
EZ
1357 * w32proc.c (sys_select): Accept and ignore one more argument.
1358
1359 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1360
0d23c240 1361 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1362 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1363
1364 * sysdep.c: Don't include dos.h and dosfns.h.
1365
1366 * process.c (sys_select):
1367 * msdos.c (sys_select): Accept one more argument and ignore it.
1368
1369 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1370 adapt data types and code to that.
1371
1372 * dosfns.c:
1373 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1374 which clashes with the gnulib function of the same name.
1375
af5a5a98
AS
13762012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1377
c5e4379c
AS
1378 * font.c (font_style_to_value, font_style_symbolic)
1379 (font_prop_validate_style): Add type checks for values in
1380 font_style_table.
1381
af5a5a98
AS
1382 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1383 argument.
1384 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1385 uses.
1386
8d38f461
EZ
13872012-06-29 Eli Zaretskii <eliz@gnu.org>
1388
2e5a6631
EZ
1389 * xdisp.c (try_window_id): Undo last change.
1390
8d38f461
EZ
1391 * w32.c (getwd): Adjust commentary about startup_dir.
1392 (init_environment): Always call sys_access, even in non-MSVC
1393 builds. Don't chdir to the directory of the Emacs executable.
1394 This undoes code from 1997 which was justified by the need to
1395 "avoid conflicts when removing and renaming directories". But its
1396 downside was that every relative file name was being interpreted
1397 relative to the directory of the Emacs executable, which can never
1398 be TRT. In particular, it broke sys_access when called with
1399 relative file names.
1400 (sys_access): Map GetLastError to errno.
1401
2af3565e
DA
14022012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1403
1404 * window.h (struct window): Change type of 'fringes_outside_margins'
1405 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1406 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1407 Adjust comment.
1408 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1409 to ptrdiff_t.
1410
c8d3a25c 14112012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1412
c8d3a25c
GM
1413 * gnutls.c (emacs_gnutls_handshake):
1414 Add QUIT to make the loop interruptible.
57570cd3 1415
c8d3a25c 14162012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1417
c8d3a25c
GM
1418 * charset.c (init_charset): Make lack of etc/charsets fatal.
1419
3e984ee8
DA
14202012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1421
1422 * editfns.c (region_limit): Fix type mismatch.
1423
ef884f23
DA
14242012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1425
1426 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1427 undefined. Convert from xassert to eassert.
1428 * nsmenu.m: Convert from xassert to eassert.
1429 * nsterm.m: Likewise.
1430
7d7e0027
SM
14312012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1432
1433 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1434
aa754e6a
PE
14352012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 Avoid integer overflow on scroll-left and scroll-right.
1438 * window.c (HSCROLL_MAX): New macro.
1439 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1440 overflow when requested scroll falls outside ptrdiff_t range.
1441
80b00b08
DA
14422012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1443
1444 * window.h (struct window): Change type of 'hscroll',
1445 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1446 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1447 Adjust users accordingly.
1448 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1449 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1450 from EMACS_INT to ptrdiff_t.
1451 (make_window): Omit redundant initialization.
1452
62b2bcf6
JB
14532012-06-28 Juanma Barranquero <lekktu@gmail.com>
1454
1455 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1456
45942c7d
DA
14572012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1458
1459 * window.h (struct window): Change type of 'use_time' and
1460 'sequence_number' from Lisp_Object to int.
1461 * frame.c (make_frame): Adjust users accordingly.
1462 * print.c (print_object): Likewise.
1463 * window.c (select_window, Fwindow_use_time, make_parent_window)
1464 (make_window): Likewise.
1465
e509cfa6
DA
14662012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1467
1468 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1469 enabled with --enable-checking=[all,glyphs] configure option.
1470 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1471 adjust comments accordingly.
1472 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1473 undefined, adjust comments accordingly.
1474 * image.c: Likewise.
1475 * scroll.c: Likewise.
1476 * w32fns.c: Likewise.
1477 * w32term.c: Likewise.
1478 * xdisp.c: Likewise.
1479 * xfaces.c: Likewise.
1480 * xfns.c: Likewise.
1481 * xterm.c: Likewise.
1482
a54e2c05
DA
14832012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 Generalize run-time debugging checks.
1486 * dispextern.h (XASSERTS): Remove.
1487 * fontset.c (xassert): Remove.
1488 Convert from xassert to eassert.
1489 * alloc.c: Convert from xassert to eassert.
1490 * bidi.c: Likewise.
1491 * dispnew.c: Likewise.
1492 * fns.c: Likewise.
1493 * fringe.c: Likewise.
1494 * ftfont.c: Likewise.
1495 * gtkutil.c: Likewise.
1496 * image.c: Likewise.
1497 * keyboard.c: Likewise.
1498 * menu.c: Likewise.
1499 * process.c: Likewise.
1500 * scroll.c: Likewise.
1501 * sound.c: Likewise.
1502 * term.c: Likewise.
1503 * w32console.c: Likewise.
1504 * w32fns.c: Likewise.
1505 * w32term.c: Likewise.
1506 * window.c: Likewise.
1507 * xdisp.c: Likewise.
1508 * xfaces.c: Likewise.
1509 * xfns.c: Likewise.
1510 * xselect.c: Likewise.
1511 * xterm.c: Likewise.
1512
1ec4b7b2
SM
15132012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1514
1515 * fns.c (maybe_resize_hash_table): Output message when growing the
1516 purify-hashtable.
1517
2014308a
DA
15182012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1519
1520 * alloc.c (allocate_string_data): Remove dead code.
1521 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1522 avoid GCC warning about unused macro.
1523
246155eb
DA
15242012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1525
1526 * alloc.c (allocate_string): Omit intervals initialization.
1527 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1528 as in make_pure_string and make_pure_c_string.
1529
43184b7b
DA
15302012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1531
d209e2fb 1532 * alloc.c (allocate_string): Fix last change.
43184b7b 1533
3fe6dd74
DA
15342012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1535
d209e2fb 1536 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1537 to memset, add explicit initialization where appropriate.
1538
1ba6038a
GM
15392012-06-27 Glenn Morris <rgm@gnu.org>
1540
1541 * lisp.mk (lisp): Remove paths.elc.
1542
c89926a5
CY
15432012-06-27 Chong Yidong <cyd@gnu.org>
1544
1545 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1546
ed6b3510
JW
15472012-06-26 John Wiegley <johnw@newartisans.com>
1548
1ec4b7b2 1549 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1550 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1551
ed6b3510
JW
1552 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1553 when building with Clang.
1554
8edd4a2b
SM
15552012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1556
1557 * eval.c (Fapply): Allow calling it with a single argument.
1558
f6f62d1b
EZ
15592012-06-26 Eli Zaretskii <eliz@gnu.org>
1560
1561 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1562 _stricmp and _strnicmp.
1563 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1564
62efea5e
DA
15652012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1566
1567 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1568 allocated window.
1569 (allocate_process): Likewise for new process.
8edd4a2b 1570 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1571 (allocate_frame): Likewise.
1572 * frame.c (make_frame): Omit redundant initialization.
1573 * window.c (make_parent_window): Use memset.
1574 (make_window): Omit redundant initialization.
1575 * process.c (make_process): Omit redundant initialization.
1576 * terminal.c (create_terminal): Likewise.
1577
42997f4d
DA
15782012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1579
1580 * term.c (delete_tty): Remove redundant call to memset.
1581
1130ecfc
DA
15822012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1583
1584 * alloc.c: Remove build_string.
1585 * lisp.h: Define build_string as static inline. This provides
1586 a better opportunity to optimize away calls to strlen when the
1587 function is called with compile-time constant argument.
1588 * image.c (imagemagick_error): Convert to build_string.
1589 * w32proc.c (sys_spawnve): Likewise.
1590 * xterm.c (x_term_init): Likewise.
1591
cf38a720
PE
15922012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1593
99027bdd
PE
1594 Use sprintf return value instead of invoking strlen on result.
1595 In the old days this wasn't portable, since some sprintf
1596 implementations returned char *. But they died out years ago and
1597 Emacs already assumes sprintf returns int.
1598 Similarly for float_to_string.
1599 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1600 * ccl.c (ccl_driver):
1601 * character.c (string_escape_byte8):
1602 * data.c (Fnumber_to_string):
1603 * doprnt.c (doprnt):
1604 * print.c (print_object):
1605 * xdisp.c (message_dolog):
1606 * xfns.c (syms_of_xfns):
1607 Use sprintf or float_to_string result to avoid need to call strlen.
1608 * data.c (Fnumber_to_string):
1609 Use make_unibyte_string, since the string must be ASCII.
1610 * lisp.h, print.c (float_to_string): Now returns int length.
1611 * term.c (produce_glyphless_glyph):
1612 Use sprintf result rather than recomputing it.
1613
cf38a720
PE
1614 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1615 * Makefile.in (ALL_CFLAGS):
1616 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1617 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1618
3511c784
DA
16192012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1620
0a08eb21 1621 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1622 strcasecmp if available.
1623 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1624
fb7da12e
AS
16252012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1626
1627 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1628 Avoid comma operator.
1629 * menu.c (push_submenu_start, push_submenu_end)
1630 (push_left_right_boundary, push_menu_pane): Likewise.
1631 * msdos.c (dos_rawgetc): Likewise.
1632
afa2ffd8
DA
16332012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1634
1635 * xfns.c (xic_create_fontsetname): Remove redundant calls
1636 to memset.
1637
b3b4476b
PE
16382012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1639
4495ff38
PE
1640 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1641 sprintf already null-terminates its output.
1642
b3b4476b
PE
1643 * xfns.c (x_window): Remove redundant cast.
1644
b00876c9
DA
16452012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1646
1647 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1648 `const char *' to `char *' to avoid compiler warning.
1649
d188e26b
PE
16502012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1651
885d1d74
PE
1652 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1653 instead of truncating it to 63 (admittedly a generous limit).
1654
d188e26b
PE
1655 * process.c: Fix spelling and caps in comments.
1656
e2f560b1
DN
16572012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1658
e86db54b 1659 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1660 * sysdep.c (setpgrp): Remove definition, not used in this file.
1661
7583a3a1
JB
16622012-06-24 Juanma Barranquero <lekktu@gmail.com>
1663
1664 * makefile.w32-in: Update dependencies.
1665
696056c2
EZ
16662012-06-24 Eli Zaretskii <eliz@gnu.org>
1667
1668 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1669 (SYSTIME_H): Add nt/inc/sys/time.h.
1670
1671 * systime.h [WINDOWSNT]: Include sys/time.h.
1672
1673 * s/ms-w32.h (struct timespec): Definition moved from
1674 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1675
845ca893
PE
16762012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1679 * buffer.h (buffer_slot_type_mismatch):
1680 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1681 * eval.c (unwind_to_catch):
1682 * image.c (my_png_error, my_error_exit):
1683 * keyboard.c (quit_throw_to_read_char, user_error)
1684 (Fexit_recursive_edit, Fabort_recursive_edit):
1685 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1686 (wrong_type_argument, buffer_overflow, __executable_start)
1687 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1688 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1689 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1690 (fatal):
1691 (child_setup) [!DOS_NT]:
1692 * lread.c (end_of_file_error, invalid_syntax):
1693 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1694 * puresize.h (pure_write_error):
1695 * search.c (matcher_overflow):
1696 * sound.c (sound_perror, alsa_sound_perror):
1697 * sysdep.c, syssignal.h (croak):
1698 * term.c (maybe_fatal, vfatal):
1699 * textprop.c (text_read_only):
1700 * undo.c (user_error):
1701 * unexmacosx.c (unexec_error):
1702 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1703 Use _Noreturn rather than NO_RETURN.
1704 No need for separate decl merely because of _Noreturn.
1705 * sound.c (sound_warning, parse_sound):
1706 Remove unnecessary forward decls.
1707
f1dd8073
PE
17082012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1709
1710 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1711 * lisp.h (WAIT_READING_MAX): New macro.
1712 * dispnew.c (Fsleep_for, sit_for):
1713 * keyboard.c (kbd_buffer_get_event):
1714 * process.c (Faccept_process_output):
1715 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1716 This improves on the previous patch, which introduced a bug
1717 when time_t is unsigned and as wide as intmax_t.
1718 See <http://bugs.gnu.org/9000#51>.
1719
b82c1755
EZ
17202012-06-23 Eli Zaretskii <eliz@gnu.org>
1721
1722 * dispnew.c (sit_for, Fsleep_for):
1723 * keyboard.c (kbd_buffer_get_event):
1724 * process.c (Faccept_process_output): Avoid compiler warnings when
1725 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1726
ca300656
JB
17272012-06-23 Juanma Barranquero <lekktu@gmail.com>
1728
049ec95b
JB
1729 * makefile.w32-in: Update dependencies.
1730
ca300656
JB
1731 * w32.c (ltime): Add return type and declare static.
1732 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1733
db7b8d06
PE
17342012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1735
1736 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1737 Privately reported by Herbert J. Skuhra.
1738 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1739 All uses changed.
1740 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1741 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1742
0bd8297f
EZ
17432012-06-23 Eli Zaretskii <eliz@gnu.org>
1744
96512555
EZ
1745 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1746 last argument of make_unibyte_string.
1747
0bd8297f
EZ
1748 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1749 language ID in the event parameters.
1750
1751 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1752 event.code, not the obscure "character set ID".
1753
63def6b6
CY
17542012-06-23 Chong Yidong <cyd@gnu.org>
1755
1756 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1757
e8a02204
EZ
17582012-06-23 Eli Zaretskii <eliz@gnu.org>
1759
388cdec0
EZ
1760 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1761 * w32.c (fdutimens): New function.
1762
1763 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1764
1765 * s/ms-w32.h (pselect): Redirect to sys_select.
1766
1767 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1768
e8a02204
EZ
1769 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1770 in the logic of incrementing and decrementing the value of
1771 use_relocatable_buffers.
1772
d054f3fb
PE
17732012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1776 Privately reported by Herbert J. Skuhra.
1777 [__FreeBSD__]: Remove "*/" typo after "#include".
1778 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1779 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1780 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1781 Don't assume EMACS_TIME and struct timeval are the same type.
1782
d35af63c
PE
17832012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1784
1785 Support higher-resolution time stamps (Bug#9000).
1786 The time stamps are only nanosecond-resolution at the C level,
1787 since that's the best that any real-world system supports now.
1788 But they are picosecond-resolution at the Lisp level, as that's
1789 easy, and leaves room for future OS improvements.
1790
1791 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1792 (LIBES): Use it.
1793
1794 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1795 Don't get current time unless it's needed.
1796
1797 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1798 now provides it if it's absent.
1799 (start_atimer): Port to higher-res time stamps.
1800 Check for time stamp overflow. Don't get current time more
1801 often than is needed.
1802
1803 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1804 Include systime.h, not time.h.
1805 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1806
1807 * dired.c: Include stat-time.h.
1808 (Ffile-attributes): File times now have higher resolution.
1809
1810 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1811 (struct image): Timestamp now has higher resolution.
1812
1813 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1814 has at least microseconds now. All uses removed.
1815 (update_frame, update_single_window, update_window, update_frame_1)
1816 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1817
1818 * editfns.c (time_overflow): Now extern.
1819 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1820 (float-time, Fformat_time_string, Fcurrent_time_string)
1821 (Fcurrent_time_zone): Accept and generate higher-resolution
1822 time stamps.
1823 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1824 (decode_time_components, lisp_seconds_argument): New functions.
1825 (make_time): Now static.
1826 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1827 Report an error if the time is invalid, rather than having the caller
1828 do that.
1829
1830 * fileio.c: Include <stat-time.h>
1831 (Fcopy_file): Copy higher-resolution time stamps.
1832 Prefer to set the time stamp via a file descriptor if that works.
1833 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1834 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1835 (Fvisited_file_modtime, Fset_visited_file_modtime):
1836 Support higher-resolution time stamps.
1837
1838 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1839
1840 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1841
1842 * image.c (prepare_image_for_display, clear_image_cache)
1843 (lookup_image): Port to higer-resolution time stamps.
1844
1845 * keyboard.c (start_polling, bind_polling_period):
1846 Check for time stamp overflow.
1847 (read_char, kbd_buffer_get_event, timer_start_idle)
1848 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1849 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1850 Port to higher-resolution time stamps. Do not assume time_t is signed.
1851 (decode_timer): New function. Timers are now vectors of length 9,
1852 not 8, to accommodate the picosecond component.
1853 (timer_check_2): Use it.
1854
1855 * nsterm.m (select_timeout, timeval_subtract): Remove.
1856 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1857 as they're a bit more accurate and handle overflow better.
1858 (ns_select): Change prototype to be compatible with pselect.
1859 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1860 * nsterm.h (ns_select): Adjust prototype.
1861
1862 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1863 us-resolution time stamps.
1864 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1865
1866 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1867
1868 * lisp.h (time_overflow): New decl.
1869 (wait_reading_process_output): First arg is now intmax_t, not int,
1870 to accommodate larger waits.
1871
1872 * process.h (struct Lisp_Process.read_output_delay):
1873 Now counts nanoseconds, not microseconds.
1874 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1875 EMACS_HAS_USECS.
1876 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1877 (wait_reading_process_output):
1878 Port to ns-resolution time stamps.
1879 (Faccept_process_output, wait_reading_process_output):
1880 Check for time stamp overflow. Do not assume time_t is signed.
1881 (select_wrapper): Remove; we now use pselect.
1882 (Fprocess_attributes): Now generates ns-resolution time stamps.
1883
1884 * sysdep.c: Include utimens.h. Don't include utime.h
1885 or worry about struct utimbuf; gnulib does that for us now.
1886 (gettimeofday): Remove; gnulib provides a substitute.
1887 (make_timeval): New function.
1888 (set_file_times): Now sets ns-resolution time stamps.
1889 New arg FD; all uses changed.
1890 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1891 (system_process_attributes):
1892 Now returns ns-resolution time stamp. All uses changed.
1893 Check for time stamp overflow.
1894
1895 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1896 provides a substitute now.
1897
1898 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1899 since it guarantees struct timespec.
1900 (EMACS_TIME): Now struct timespec, so that we can support
1901 ns-resolution time stamps.
1902 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1903 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1904 (EMACS_USECS): Remove.
1905 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1906 so multiply the arg by 1000 before storing it.
1907 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1908 New macros.
1909 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1910 Port to ns-resolution time stamps.
1911 (EMACS_TIME_NEG_P): Remove; replaced by....
1912 (EMACS_TIME_SIGN): New macro.
1913 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1914 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1915 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1916 (make_timeval, make_lisp_time, decode_time_components): New decls.
1917 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1918 that it mishandled time_t overflow. You can't compare by subtracting!
1919 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1920 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1921
1922 * term.c: Include <sys/time.h>.
1923 (timeval_to_Time): New function, for proper overflow wraparound.
1924 (term_mouse_position, term_mouse_click): Use it.
1925
1926 * undo.c (record_first_change): Support higher-resolution time stamps
1927 in the undo buffer.
1928 (Fprimitive_undo): Use them when restoring time stamps.
1929
1930 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1931 (w32_get_internal_run_time):
1932 Port to higher-resolution Emacs time stamps.
1933 (ltime): Now accepts single 64-bit integer, as that's more convenient
1934 for callers.
1935
1936 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1937
1938 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1939 for compatibility with pselect. Support ns-resolution time stamps.
1940
1941 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1942
1943 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1944 Check for time stamp overflow, and support ns-resolution time stamps.
1945
1946 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1947 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1948 (timeval_subtract): Remove; no longer needed.
1949 (XTflash, XTring_bell, x_wait_for_event):
1950 Port to ns-resolution time stamps. Don't assume time_t is signed.
1951
b6a92dfe
CY
19522012-06-22 Chong Yidong <cyd@gnu.org>
1953
1954 * xdisp.c (x_consider_frame_title): Revert last change.
1955
d251c37c
EZ
19562012-06-22 Eli Zaretskii <eliz@gnu.org>
1957
1958 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1959 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1960 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1961 staticidx goes up to 1597 out of 1600 = 0x640.)
1962
f10deafb
PE
19632012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1964
1965 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1966 Otherwise, the umask might be mistakenly 0 while handling input signals.
1967
ec6de1e2
SM
19682012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1969
1970 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1971
28be1ada
DA
19722012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1973
1974 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1975 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1976 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1977 access to `contents' member of Lisp_Vector objects with AREF and ASET
1978 where appropriate.
1979
c6bf3022
CY
19802012-06-19 Chong Yidong <cyd@gnu.org>
1981
1982 * frame.c (delete_frame): When selecting a frame on a different
1983 text terminal, do not alter the terminal's top-frame.
1984
1985 * xdisp.c (format_mode_line_unwind_data): Record the target
1986 frame's selected window and its terminal's top-frame.
1987 (unwind_format_mode_line): Restore them.
1988 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1989 Callers changed.
1990 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1991 since tty frames can be explicitly named.
1992 (prepare_menu_bars): Likewise.
1993
1994 * term.c (Ftty_top_frame): New function.
1995
defd4196
PE
19962012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1997
1998 Port byte-code-meter to modern targets.
1999 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2000 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2001 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2002 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2003 (METER_1, METER_2): Simplify.
2004
1053a871
SM
20052012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2006
2007 * data.c (Fdefalias): Return `symbol' (bug#11686).
2008
b7e8d081
MR
20092012-06-18 Martin Rudalics <rudalics@gmx.at>
2010
2011 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2012 gets killed during executing of this function (Bug#11665).
2013 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2014 (Vkill_buffer_query_functions): In doc-string say that functions
2015 run by this hook should not change the current buffer.
2016
7ea2b339
PE
20172012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 Fix recently-introduced process.c problems found by static checking.
2020 * process.c (write_queue_push, write_queue_pop, send_process):
2021 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2022 (write_queue_pop): Fix pointer signedness problem.
2023 (send_process): Remove unused local.
2024
96a313a1
CY
20252012-06-17 Chong Yidong <cyd@gnu.org>
2026
2027 * xdisp.c (redisplay_internal): No need to redisplay terminal
2028 frames that are not on top.
2029
20ca2e94
TN
20302012-06-17 Troels Nielsen <bn.troels@gmail.com>
2031
2032 * process.c (make_process): Initialize write_queue.
2033 (write_queue_push, write_queue_pop): New functions.
2034 (send_process): Use them to maintain correct ordering of process
2035 writes (Bug#10815).
2036
9a900ca9
PE
20372012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2038
310fbfa8
PE
2039 * lisp.h (eassert): Assume C89 or later.
2040 This removes the need for CHECK.
2041 (CHECK): Remove. Its comments about always evaluating its
2042 argument were confusing, as 'eassert' typically does not evaluate
2043 its argument.
2044
27bb1ca4
PE
2045 * coding.c (produce_chars): Use ptrdiff_t, not int.
2046
9a900ca9
PE
2047 * xterm.c (x_draw_underwave): Check for integer overflow.
2048 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2049
41b7f8bc 20502012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2051
2052 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2053 referenced (Bug#11583).
2054
9b0e3eba
AA
20552012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2056
2057 Implement wave-style variant of underlining.
2058 * dispextern.h (face_underline_type): New enum.
2059 (face): Add field for underline type.
2060 * nsterm.m (ns_draw_underwave): New function.
2061 (ns_draw_text_decoration): Use it.
2062 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2063 New functions.
2064 (x_draw_glyph_string): Use them.
2065 * xfaces.c (Qline, Qwave): New Lisp objects.
2066 (check_lface_attrs, merge_face_ref)
1053a871
SM
2067 (Finternal_set_lisp_face_attribute, realize_x_face):
2068 Handle wave-style underline face attributes.
9b0e3eba
AA
2069 * xterm.c (x_draw_underwave): New function.
2070 (x_draw_glyph_string): Use it.
2071
0fb52f11
JB
20722012-06-16 Juanma Barranquero <lekktu@gmail.com>
2073
2074 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2075 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2076 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2077 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2078 ($(BLD)/w32select.$(O)): Update dependencies.
2079
e5560ff7
AS
20802012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2081
2082 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2083 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2084 * character.c (_fetch_multibyte_char_p): Remove.
2085 * alloc.c: Include "character.h" before "buffer.h".
2086 * bidi.c: Likewise.
2087 * buffer.c: Likewise.
2088 * bytecode.c: Likewise.
2089 * callint.c: Likewise.
2090 * callproc.c: Likewise.
2091 * casefiddle.c: Likewise.
2092 * casetab.c: Likewise.
2093 * category.c: Likewise.
2094 * cmds.c: Likewise.
2095 * coding.c: Likewise.
2096 * composite.c: Likewise.
2097 * dired.c: Likewise.
2098 * dispnew.c: Likewise.
2099 * doc.c: Likewise.
2100 * dosfns.c: Likewise.
2101 * editfns.c: Likewise.
2102 * emacs.c: Likewise.
2103 * fileio.c: Likewise.
2104 * filelock.c: Likewise.
2105 * font.c: Likewise.
2106 * fontset.c: Likewise.
2107 * fringe.c: Likewise.
2108 * indent.c: Likewise.
2109 * insdel.c: Likewise.
2110 * intervals.c: Likewise.
2111 * keyboard.c: Likewise.
2112 * keymap.c: Likewise.
2113 * lread.c: Likewise.
2114 * macros.c: Likewise.
2115 * marker.c: Likewise.
2116 * minibuf.c: Likewise.
2117 * nsfns.m: Likewise.
2118 * nsmenu.m: Likewise.
2119 * print.c: Likewise.
2120 * process.c: Likewise.
2121 * regex.c: Likewise.
2122 * region-cache.c: Likewise.
2123 * search.c: Likewise.
2124 * syntax.c: Likewise.
2125 * term.c: Likewise.
2126 * textprop.c: Likewise.
2127 * undo.c: Likewise.
2128 * unexsol.c: Likewise.
2129 * w16select.c: Likewise.
2130 * w32fns.c: Likewise.
2131 * w32menu.c: Likewise.
2132 * window.c: Likewise.
2133 * xdisp.c: Likewise.
2134 * xfns.c: Likewise.
2135 * xmenu.c: Likewise.
2136 * xml.c: Likewise.
2137 * xselect.c: Likewise.
2138
2f07e6af
EZ
21392012-06-16 Eli Zaretskii <eliz@gnu.org>
2140
1053a871
SM
2141 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2142 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2143 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2144 row.
2145 (handle_face_prop): Use chunk-relative overlay string index when
2146 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2147 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2148 the rightmost. (Bug#11720)
2f07e6af 2149
29b83cec
AS
21502012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2151
2152 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2153 (CATEGORY_MEMBER): Enforce 1/0 value.
2154 * category.c (_temp_category_set): Remove.
2155
4c5501e9
EZ
21562012-06-16 Eli Zaretskii <eliz@gnu.org>
2157
2158 * window.c (Fdelete_other_windows_internal)
2159 (Fdelete_window_internal): Don't access frame's mouse highlight
2160 info of the initial frame. (Bug#11677)
2161
2b570124
PE
21622012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2163
e93864f9
PE
2164 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2165 Assume USE_2_TAGS_FOR_INTS.
2166 (xreload): Adjust $tagmask width to match recent lisp.h change.
2167
2b570124
PE
2168 Simplify lisp.h in minor ways that should not affect code.
2169 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2170 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2171 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2172 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2173 (INTTYPEBITS): New macro, for clarity.
2174 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2175 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2176 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2177 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2178 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2179
81755f69
JB
21802012-06-13 Juanma Barranquero <lekktu@gmail.com>
2181
2182 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2183
16192a57
GM
21842012-06-13 Glenn Morris <rgm@gnu.org>
2185
2186 * s/bsd-common.h (BSD4_3):
2187 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2188
646b5f55
AS
21892012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2190
2191 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2192 instead of union.
2193 (XLI, XIL): Define.
1053a871
SM
2194 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2195 Use them.
2196 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2197 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2198 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2199 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2200 * frame.c (delete_frame): Remove outdated comment.
2201 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2202 USE_LISP_UNION_TYPE.
2203 (Fw32_unregister_hot_key): Likewise.
2204 (Fw32_toggle_lock_key): Likewise.
2205 * w32menu.c (add_menu_item): Likewise.
2206 (w32_menu_display_help): Use XIL instead of checking
2207 USE_LISP_UNION_TYPE.
2208 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2209 (init_heap): Likewise.
2210 * w32term.c (w32_read_socket): Update comment.
2211
1d3823c9
GM
22122012-06-13 Glenn Morris <rgm@gnu.org>
2213
c62ff706
GM
2214 * s/usg5-4-common.h, src/s/unixware.h:
2215 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2216
1d3823c9
GM
2217 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2218
bfe3e0a2
PE
22192012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2222 * alloc.c (make_number) [!defined make_number]:
2223 Remove, as lisp.h always defines this now.
2224 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2225 (roundup_size): Verify that it is a power of 2.
2226 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2227 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2228 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2229 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2230 USE_LSB_TAG now is always defined to be either 0 or 1.
2231 All uses changed.
2232 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2233 code works fine either way, and efficiency is not a concern here,
2234 as the union type is for debugging, not for production.
2235 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2236 Use an inline function on all platforms when using the union type,
2237 since this is simpler and 'static inline' can be used portably
2238 within Emacs now.
2239 (LISP_INITIALLY_ZERO): New macro.
2240 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2241 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2242
45fa9c0f
GM
22432012-06-12 Glenn Morris <rgm@gnu.org>
2244
b4492cba
GM
2245 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2246
2247 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2248
45fa9c0f
GM
2249 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2250 Move BROKEN_SIGIO to configure.
2251
2252 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2253 Move NO_TERMIO to configure.
2254
0e25d334
CY
22552012-06-12 Chong Yidong <cyd@gnu.org>
2256
2257 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2258 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2259 MagickExportImagePixels is undefined.
2260
43682bb6
PE
22612012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2262
2263 * image.c (imagemagick_load_image): Remove unused label.
2264
a9be7d2b
GM
22652012-06-11 Glenn Morris <rgm@gnu.org>
2266
2267 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2268 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2269 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2270 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2271
3017f87f
SM
22722012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2273
2274 * alloc.c (make_byte_code): New function.
2275 (Fmake_byte_code): Use it. Don't purify here.
2276 * lread.c (read1): Use it as well to avoid extra allocation.
2277
1b9b4cf4
CY
22782012-06-11 Chong Yidong <cyd@gnu.org>
2279
2280 * image.c (imagemagick_load_image): Implement transparency.
2281
95988fcf
AS
22822012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2283
2284 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2285 account for preceding backslashes. (Bug#11663)
2286
cd4eb164
CY
22872012-06-09 Chong Yidong <cyd@gnu.org>
2288
2289 * term.c: Support italics in capable terminals (Bug#9652).
2290 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2291 (turn_on_face): Output using TS_enter_italic_mode if available.
2292 Don't handle unused blinking and alt-charset cases.
2293 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2294 and tty_alt_charset_p cases.
2295 (tty_capable_p, init_tty): Support italics.
2296
2297 * termchar.h (struct tty_display_info): Add field for italics.
2298 Remove unused blink field.
2299
2300 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2301 Handle slant.
2302
2303 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2304 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2305 tty_alt_charset_p. Add tty_italic_p.
2306
ff88beb8
MA
23072012-06-09 Michael Albinus <michael.albinus@gmx.de>
2308
2309 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2310 dbus_type_is_basic if available.
2311 (xd_extract_signed, xd_extract_unsigned): Rename from
2312 extract_signed and extract_unsigned, respectively. Adapt callers.
2313
44286096
CY
23142012-06-09 Chong Yidong <cyd@gnu.org>
2315
1682701f
CY
2316 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2317
44286096
CY
2318 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2319 case (Bug#9752).
2320
d86feb17
PE
23212012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 * xdisp.c (vmessage): Treat frame message as multibyte.
2324 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2325 would generate the diagnostic "Making \302\247 buffer-local while
2326 let-bound!".
2327
d5c20fe8
EZ
23282012-06-08 Eli Zaretskii <eliz@gnu.org>
2329
2330 * dispnew.c (showing_window_margins_p): Undo last change, which
2331 was done due to an inadvertent commit.
2332 (adjust_frame_glyphs_for_frame_redisplay): Do call
2333 showing_window_margins_p.
2334
513749ee
SM
23352012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2336
2337 * eval.c (Fmake_var_non_special): New primitive.
2338 (syms_of_eval): Defsubr it.
2339 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2340
d4a8f5c1
JB
23412012-06-08 Juanma Barranquero <lekktu@gmail.com>
2342
2343 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2344 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2345
8bbbc977
EZ
23462012-06-08 Eli Zaretskii <eliz@gnu.org>
2347
2348 * alloc.c (allocate_vectorlike): Fix last change.
2349
f3372c87
DA
23502012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2351
2352 Block-based vector allocation of small vectors.
2353 * lisp.h (struct vectorlike_header): New field `nbytes',
2354 adjust comment accordingly.
2355 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2356 to denote vector blocks. Adjust users (live_vector_p,
2357 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2358 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2359 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2360 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2361 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2362 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2363 (roundup_size): New constant.
2364 (struct vector_block): New data type.
2365 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2366 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2367 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2368 (sweep_vectors): New functions.
2369 (allocate_vectorlike): Return `zero_vector' as the only vector of
2370 0 items. Allocate new vector from block if vector size is less than
2371 or equal to VBLOCK_BYTES_MAX.
2372 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2373 (init_alloc_once): Add call to init_vectors.
2374
4f18a4ed
SM
23752012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2376
2377 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2378
86f158bc
PE
23792012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 * doprnt.c (doprnt): Truncate multibyte char correctly.
2382 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2383 would mishandle a string argument "Xc" if X was a multibyte
2384 character of length 2: it would truncate after X's first byte
2385 rather than including all of X.
2386
c5cfcbe0
CY
23872012-06-06 Chong Yidong <cyd@gnu.org>
2388
2389 * buffer.c (word_wrap): Doc fix.
2390
c05cf390
PE
23912012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2394
0c3461de
GM
23952012-06-03 Glenn Morris <rgm@gnu.org>
2396
2397 * xdisp.c (tool-bar-style): Doc fix.
2398
c71232db
UM
23992012-06-03 Ulrich Müller <ulm@gentoo.org>
2400
2401 * Makefile.in (PAXCTL): Define.
2402 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2403 binary via PaX flags if the paxctl utility is available.
2404 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2405 Restore PaX flags to their default. (Bug#11398)
2406
383f7350
CY
24072012-06-03 Chong Yidong <cyd@gnu.org>
2408
2409 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2410 buffer (Bug#11226).
2411
5f2c76c6
CY
24122012-06-03 Chong Yidong <cyd@gnu.org>
2413
2414 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2415 (note_mode_line_or_margin_highlight): If there is no help echo,
2416 use mode-line-default-help-echo. Handle the case where the mouse
2417 position is past the end of the mode line string.
2418
2419 * buffer.c (buffer_local_value_1): New function, split from
2420 Fbuffer_local_value; can return Qunbound.
2421 (Fbuffer_local_value): Use it.
2422 (Vmode_line_format): Docstring tweaks.
2423
773d47f6
PE
24242012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2425
2426 * sysdep.c (system_process_attributes): Improve comment.
2427
f2d6a3df
SM
24282012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2429
2430 * keyboard.c: Export real-this-command to Elisp.
2431 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2432 and DEFVAR it. Update all users.
2433
63810350
PE
24342012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2435
7bd5c1f4
PE
2436 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2437
63810350
PE
2438 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2439 Convert pctcpu and pctmem to Lisp float properly.
2440 Let the compiler fold better, as 100.0/0x8000 is exact.
2441
a2821611
AS
24422012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2443
2444 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2445 cons_block.
2446
5fceba1d
PE
24472012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2448
2449 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2450
c98ff5dd
DA
24512012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2452
2453 For a 'struct window', replace some Lisp_Object fields to
2454 bitfields where appropriate, remove unused fields.
2455 * window.h (struct window): Remove unused 'last_mark_x' and
2456 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2457 change it's type from Lisp_Object to bitfield.
2458 Change type of 'force_start', 'optional_new_start',
2459 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2460 fields from Lisp_Object to bitfield. Adjust users accordingly.
2461
ca34e0be
PE
24622012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 Pacify gcc -Wdouble-precision when using Xaw.
2465 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2466 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2467 Use 'float' consistently, rather than 'float' in most places
2468 and 'double' in a couple of places.
2469
efc00ab1 24702012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2471
2472 * xdisp.c (handle_stop): Detect whether we have overlay strings
2473 loaded by testing it->current.overlay_string_index to be
2474 non-negative, instead of checking whether n_overlay_strings is
2475 positive. (Bug#11587)
2476
efc00ab1 24772012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2478
2479 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2480
2481 * doc.c (Fsubstitute_command_keys): Doc fix.
2482
efc00ab1 24832012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2484
2485 * search.c (search_buffer): Remove calls to
2486 r_alloc_inhibit_buffer_relocation, as it is now called by
2487 maybe_unify_char, which was the cause of relocation of buffer text
2488 in bug#11519.
2489
efc00ab1 24902012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2491
2492 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2493 for the duration of call to load_charset, to avoid problems with
2494 callers of maybe_unify_char that access buffer text through C
2495 pointers.
2496
2497 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2498 decrement the inhibition flag, instead of just setting or
2499 resetting it.
2500
ba93a187
PE
25012012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 Remove obsolete '#define static' cruft.
2504 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2505 This #undef was "temporary" in 2000; it is no longer needed
2506 now that '#define static' has gone away.
2507 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2508 (gray_bitmap_bits): Remove; no longer needed.
2509 All uses replaced with definiens.
2510 * xterm.c: Include "bitmaps/gray.xbm".
2511
9e4bf381
PE
25122012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2513
2514 Clean up __executable_start, monstartup when --enable-profiling.
2515 The following changes affect the code only when profiling.
2516 * dispnew.c (__executable_start): Rename from safe_bcopy.
2517 Define only on platforms that need it.
2518 * emacs.c: Include <sys/gmon.h> when profiling.
2519 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2520 (__executable_start): Remove decl, since lisp.h does it now.
2521 (safe_bcopy): Remove decl; no longer has that name.
2522 (main): Coalesce #if into single bit of code, for simplicity.
2523 Cast pointers to uintptr_t, since standard libraries want integers
2524 and not pointers.
2525 * lisp.h (__executable_start): New decl.
2526
32d72c2f
GM
25272012-05-31 Glenn Morris <rgm@gnu.org>
2528
2529 * image.c (Fimagemagick_types): Doc fix.
2530
baac5bc7
JM
25312012-05-30 Jim Meyering <meyering@redhat.com>
2532
2533 * callproc.c (Fcall_process_region): Include directory component
2534 in mkstemp error message (Bug#11586).
2535
72cb32cf
PE
25362012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 * alloc.c, lisp.h (make_pure_vector): Now static.
2539
61b108cc
SM
25402012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2541
2542 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2543 Move to byte-run.el.
2544 (Fautoload): Do the hash-doc more carefully.
2545 * data.c (Fdefalias): Purify definition, except for keymaps.
2546 (Qdefun): Move from eval.c.
2547 * lisp.h (Qdefun): Remove.
2548 * lread.c (read1): Tiny simplification.
2549
471fe23d
TN
25502012-05-29 Troels Nielsen <bn.troels@gmail.com>
2551
934f3f58 2552 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2553 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2554 Bug#9642, but explicitly check that the buffer the overlay would
2555 be moved to is live and rearrange lines to make sure that errors
2556 will not put the overlay in an inconsistent state.
2557 (Fdelete_overlay): Cosmetics.
2558
85d0efd1
EZ
25592012-05-28 Eli Zaretskii <eliz@gnu.org>
2560
2561 * w32term.c (my_bring_window_to_top): New function.
2562 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2563 could be different from the original one.
2564 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2565 (Bug#11513)
2566
2567 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2568 by calling BringWindowToTop.
2569
2570 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2571 (WM_EMACS_END): Increase by one.
2572
da92a98c
PE
25732012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2574
2575 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2576 This avoids undefined behavior that might cause the eassert
2577 to not catch an out-of-range value.
2578
74d1f848
JB
25792012-05-28 Juanma Barranquero <lekktu@gmail.com>
2580
2581 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2582 Update dependencies.
2583
9e1a06fc
EZ
25842012-05-27 Eli Zaretskii <eliz@gnu.org>
2585
2586 * bidi.c (bidi_mirror_char): Fix last change.
2587
f3dd7312
AS
25882012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2589
2590 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2591 when referring to sectname field in printf format.
2592
81899c91
PE
25932012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2594
57b81a9f
PE
2595 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2596 Only r_alloc_inhibit_buffer_relocation needed to be added;
2597 the others were already declared.
2598
81899c91
PE
2599 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2600 before checking whether it's out of range. Put the check inside
2601 eassert. See
2602 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2603
33017faf 26042012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2605
2606 * callproc.c (Fcall_process): Restore a line that was accidentally
2607 commented out in the 2011-02-13 change (bug#11547).
2608
33017faf 26092012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2610
2611 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2612 defined on ralloc.c.
2613
2614 * buffer.c [REL_ALLOC]: Remove prototypes of
2615 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2616 they are now on lisp.h.
2617
2618 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2619
2620 * search.c (search_buffer): Use it to inhibit relocation of buffer
2621 text while re_search_2 is doing its job, because re_search_2 is
2622 passed C pointers to buffer text. (Bug#11519)
2623
23415acf
EZ
2624 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2625 Update value to 24.
2626
44e27368
EZ
2627 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2628 state after an additional call to move_it_in_display_line_to, keep
2629 the values of it->max_ascent and it->max_descent found for the
2630 entire line.
2631 (pos_visible_p): Revert the comparison against bottom_y to what it
2632 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2633 (Bug#11464)
2634
c1892f11
PE
26352012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2636
2637 Fix coding-related core dumps with gcc -ftrapv.
2638 The code was computing A - B, where A and B are pointers, and B is
2639 random garbage. This can lead to core dumps on platforms that
2640 have special pointer registers, and it also leads to core dumps on
2641 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2642 A - B only when B is initialized properly.
2643 * coding.c (coding_set_source, coding_set_destination): Return void.
2644 (coding_change_source, coding_change_destinations): New functions,
2645 with the old behaviors of coding_set_source and coding_set_destination.
2646 All callers that need an offset changed to use these new functions.
2647
eb7afdad
GM
26482012-05-26 Glenn Morris <rgm@gnu.org>
2649
2650 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2651
f12fdf02
EZ
26522012-05-26 Eli Zaretskii <eliz@gnu.org>
2653
53a63be6 2654 Extend mouse support on W32 text-mode console.
61b108cc
SM
2655 * xdisp.c (draw_row_with_mouse_face):
2656 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2657
eb3f6f01 2658 * w32console.c: Include window.h.
61b108cc
SM
2659 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2660 New functions.
eb3f6f01
EZ
2661 (initialize_w32_display): Initialize mouse-highlight data.
2662
53a63be6
EZ
2663 * w32inevt.c: Include termchar.h and window.h.
2664 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2665 moves, call note_mouse_highlight. If help_echo changed, call
2666 gen_help_event to produce help-echo message in the echo area.
2667 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2668 highlight info.
2669
4cfd81f6
PE
26702012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 * lread.c (read1): Simplify slightly to avoid an overflow warning
2673 with GCC 4.7.0 on x86-64.
2674
4446092a
EZ
26752012-05-26 Eli Zaretskii <eliz@gnu.org>
2676
2677 * bidi.c (bidi_mirror_char): Revert last change: an int is
2678 definitely wide enough here.
2679
42b2a986 26802012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2681
42b2a986 2682 Fix integer width and related bugs (Bug#9874).
eb106a49 2683 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2684 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2685 (string_bytes, check_sblock, allocate_string_data):
2686 (compact_small_strings, Fmake_bool_vector, make_string)
2687 (make_unibyte_string, make_multibyte_string)
2688 (make_string_from_bytes, make_specified_string)
2689 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2690 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2691 (mark_vectorlike):
2692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2693 (allocate_pseudovector):
2694 Use int, not EMACS_INT, where int is wide enough.
2695 (inhibit_garbage_collection, Fgarbage_collect):
2696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2697 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2698 int might not be wide enough.
2699 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2700 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2701 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2702 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2703 (bidi_level_of_next_char, bidi_move_to_visually_next):
2704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2705 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2706 (Fkill_buffer, Fset_buffer_major_mode)
2707 (advance_to_char_boundary, Fbuffer_swap_text)
2708 (Fset_buffer_multibyte, overlays_at, overlays_in)
2709 (overlay_touches_p, struct sortvec, record_overlay_string)
2710 (overlay_strings, recenter_overlay_lists)
2711 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2712 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2713 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2714 (Foverlay_recenter, last_overlay_modification_hooks_used)
2715 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2717 (validate_region): Omit unnecessary test for b <= e,
2718 since that's guaranteed by the previous test.
d311d28c
PE
2719 (adjust_overlays_for_delete): Avoid pos + length overflow.
2720 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2721 (report_overlay_modification):
2722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2723 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2724 Omit pointer cast, which isn't needed anyway, and doesn't work
2725 after the EMACS_INT -> ptrdiff_t change.
02481186 2726 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2727 * buffer.h: Adjust decls to match defn changes elsewhere.
2728 (struct buffer_text, struct buffer):
2729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2730 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2731 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2732 not int, to avoid needless 32-bit limit on 64-bit hosts.
2733 (exec_byte_code): Use tighter memory-full test, one that checks
2734 for alloca overflow. Don't compute the address of the object just
2735 before an array, as that's not portable. Use EMACS_INT, not
2736 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2737 * callint.c (Fcall_interactively):
2738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2739 * callproc.c (call_process_kill, Fcall_process):
2740 Don't assume pid_t fits into an Emacs fixnum.
2741 (call_process_cleanup, Fcall_process, child_setup):
2742 Don't assume pid_t fits into int.
2743 (call_process_cleanup, Fcall_process, delete_temp_file)
2744 (Fcall_process_region):
2745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2746 (Fcall_process): Simplify handling of volatile integers.
2747 Use int, not EMACS_INT, where int will do.
2748 * casefiddle.c (casify_object, casify_region, operate_on_word)
2749 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2751 (casify_object): Avoid integer overflow when overallocating buffer.
2752 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2753 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2754 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2755 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2756 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2757 integers are now checked earlier. All uses replaced with XINT.
2758 (ccl_driver):
2759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2760 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2761 (ccl_driver, Fregister_code_conversion_map):
2762 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2763 (resolve_symbol_ccl_program): Check that vector header is in range.
2764 Always copy the vector, so that we can check its contents reliably
2765 now rather than having to recheck each instruction as it's being
2766 executed. Check that vector words fit in 'int'.
2767 (ccl_get_compiled_code, Fregister_ccl_program)
2768 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2769 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2770 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2771 contents are in range.
2772 (Fccl_execute_on_string): Check that status is in range.
2773 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2774 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2775 Accept and return EMACS_INT, not int, because callers can pass values
2776 out of 'int' range.
2777 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2778 (multibyte_chars_in_text, parse_str_as_multibyte)
2779 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2780 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2781 (string_escape_byte8, Fget_byte):
2782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2783 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2784 avoid mishandling large integers.
2785 * character.h: Adjust decls to match defn changes elsewhere.
2786 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2787 (Ffind_charset_region):
2788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2789 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2790 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2791 Don't assume fixnum fits in int.
d311d28c
PE
2792 (load_charset_map_from_vector, Fmap_charset_chars):
2793 Remove now-unnecessary CHECK_NATNUMs.
2794 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2795 Don't rely on undefined behavior with signed left shift overflow.
2796 Don't assume unsigned int fits into fixnum, or that fixnum fits
2797 into unsigned int. Don't require max_code to be a valid fixnum;
2798 that's not true for gb10830 4-byte on a 32-bit host. Allow
2799 invalid_code to be a cons, for the same reason. Require code_offset
2800 to be a character. Avoid int overflow if max_char is close
2801 to INT_MAX.
2802 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2803 this is intended anyway and avoids some undefined behavior.
2804 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2805 INDEX_TO_CODE_POINT, as that's what it expects.
2806 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2807 * charset.h (DECODE_CHAR): Return int, not unsigned;
2808 this is what was intended anyway, and it avoids undefined behavior.
2809 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2810 integer-overflow issues.
2811 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2812 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2813 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2814 * chartab.c (Fmake_char_table, Fset_char_table_range)
2815 (uniprop_get_decoder, uniprop_get_encoder):
2816 Don't assume fixnum fits in int.
2817 * cmds.c (move_point): New function, that does the gist of
2818 Fforward_char and Fbackward_char, but does so while checking
2819 for integer overflow more accurately.
c96e5d6a 2820 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2821 (Fforward_line, Fend_of_line, internal_self_insert)
2822 (internal_self_insert):
2823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2824 Fix a FIXME, by checking for integer overflow when calculating
2825 target_clm and actual_clm.
2826 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2827 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2828 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2829 (coding_alloc_by_making_gap, alloc_destination)
2830 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2831 (encode_coding_utf_16, detect_coding_emacs_mule)
2832 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2833 (detect_coding_iso_2022, decode_coding_iso_2022)
2834 (encode_invocation_designation, encode_designation_at_bol)
2835 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2836 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2837 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2838 (encode_coding_ccl, encode_coding_raw_text)
2839 (detect_coding_charset, decode_coding_charset)
2840 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2841 (produce_composition, produce_charset, produce_annotation)
2842 (decode_coding, handle_composition_annotation)
2843 (handle_charset_annotation, consume_chars, decode_coding_gap)
2844 (decode_coding_object, encode_coding_object, detect_coding_system)
2845 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2846 (code_convert_region, code_convert_string)
8f50130c
PE
2847 (Fdefine_coding_system_internal)
2848 (coding_set_source, coding_set_destination):
d311d28c
PE
2849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2850 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2851 (Fdefine_coding_system_internal):
2852 Don't assume fixnums fit in int.
2853 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2854 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2855 (Funencodable_char_position, Fcheck_coding_systems_region)
2856 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2858 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2859 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2860 Don't access memory outside of the args array.
d311d28c 2861 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2862 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2863 result of ENCODE_CHAR.
d311d28c
PE
2864 * coding.h: Adjust decls to match defn changes elsewhere.
2865 (struct coding_system):
2866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2867 * composite.c (get_composition_id, find_composition)
2868 (run_composition_function, update_compositions)
2869 (compose_text, composition_gstring_put_cache)
2870 (composition_gstring_p, composition_gstring_width)
2871 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2872 (composition_compute_stop_pos, composition_reseat_it)
2873 (composition_update_it, struct position_record)
2874 (find_automatic_composition, composition_adjust_point)
2875 (Fcomposition_get_gstring, Ffind_composition_internal):
2876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2877 (update_compositions):
2878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2879 * composite.h: Adjust decls to match defn changes elsewhere.
2880 (struct composition):
2881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2882 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2883 Do not attempt to compute the address of the object just before a
2884 buffer; this is not portable.
2885 (Faref, Faset):
2886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2887 (Faset): Use int, not EMACS_INT, where int is wide enough.
2888 (Fstring_to_number): Don't assume fixnums fit in int.
2889 (Frem): Don't assume arg is nonnegative.
2890 * dbusbind.c (xd_append_arg): Check for integers out of range.
2891 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2892 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2893 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2894 (xd_get_connection_references): Return ptrdiff_t, not int.
2895 All uses changed.
2896 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2897 (xd_read_message_1):
2898 Use int, not unsigned, where the dbus API uses int.
2899 (Fdbus_message_internal): Don't overflow mtype.
2900 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2901 * dired.c (directory_files_internal, file_name_completion, scmp)
2902 (file_name_completion_stat):
2903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2904 (file_name_completion): Don't overflow matchcount.
2905 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2906 * dispextern.h: Adjust decls to match defn changes elsewhere.
2907 (struct text_pos, struct glyph, struct bidi_saved_info)
2908 (struct bidi_string_data, struct bidi_it, struct composition_it)
2909 (struct it):
2910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2911 (struct display_pos, struct composition_it, struct it):
2912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2913 * dispnew.c (increment_matrix_positions)
2914 (increment_row_positions, mode_line_string)
2915 (marginal_area_string):
2916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2917 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2919 (duration_to_sec_usec): New function, to check for overflow better.
2920 (Fsleep_for, sit_for): Use it.
2921 * doc.c (get_doc_string, store_function_docstring):
2922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2923 (get_doc_string, Fsnarf_documentation):
2924 Use int, not EMACS_INT, where int is wide enough.
2925 (get_doc_string):
2926 Use SAFE_ALLOCA, not alloca.
2927 Check for overflow when converting EMACS_INT to off_t.
2928 * doprnt.c (doprnt):
2929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2930 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2931 Don't assume uid_t fits into fixnum.
2932 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2933 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2934 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2935 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2936 (general_insert_function)
2937 (Finsert_char, make_buffer_string, make_buffer_string_both)
2938 (update_buffer_properties, Fbuffer_substring)
2939 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2940 (Fsubst_char_in_region, check_translation)
2941 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2942 (transpose_markers, Ftranspose_regions):
2943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2944 (clip_to_bounds): Move to lisp.h as an inline function).
2945 (Fconstrain_to_field): Don't assume integers are nonnegative.
2946 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2947 (Fsubst_char_in_region, Fsave_restriction):
2948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2949 (Femacs_pid): Don't assume pid_t fits into fixnum.
2950 (lo_time): Use int, not EMACS_INT, when int suffices.
2951 (lisp_time_argument): Check for usec out of range.
2952 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2953 (Fuser_login_name, Fuser_full_name): Signal an error
2954 if a uid argument is out of range, rather than relying on
2955 undefined behavior.
c8d5c857
PE
2956 (Fformat_time_string): Remove now-unnecessary check.
2957 lisp_time_argument checks for out-of-range usec now.
243e0530 2958 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2959 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2960 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2961 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2962 (init_cmdargs, Fdump_emacs):
2963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2964 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2965 the bottom (typically) 32 bits of the fixnum.
2966 * eval.c (specpdl_size, call_debugger):
2967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2968 (when_entered_debugger, Fbacktrace_debug):
2969 Don't assume fixnum can fit in int.
2970 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2971 the object just before a buffer; this is not portable.
2972 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2973 (grow_specpdl, unbind_to):
2974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2975 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2976 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2977 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2978 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2979 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2981 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2982 (a_write, e_write):
2983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2984 (Fcopy_file, non_regular_nbytes, read_non_regular)
2985 (Finsert_file_contents):
2986 Use int, not EMACS_INT, where int is wide enough.
2987 (READ_BUF_SIZE): Verify that it fits in int.
2988 (Finsert_file_contents): Check that counts are in proper range,
2989 rather than assuming fixnums fit into ptrdiff_t etc.
2990 Don't assume fixnums fit into int.
125b3835 2991 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2992 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2993 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2994 (string_char_to_byte, string_byte_to_char)
2995 (string_make_multibyte, string_to_multibyte)
2996 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2997 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2998 (substring_both, Fdelete, internal_equal, Ffillarray)
2999 (Fclear_string, mapcar1)
3000 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3001 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3002 (larger_vector, make_hash_table, maybe_resize_hash_table)
3003 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3004 (Fmaphash, secure_hash):
3005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3006 (concat): Check for string index and length overflow.
3007 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3008 (Frequire):
3009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3010 (larger_vector): New API (vec, incr_min, size_max) replaces old
3011 one (vec, new_size, init). This catches size overflow.
3012 INIT was removed because it was always Qnil.
3013 All callers changed.
3014 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3015 the upper bound on a hash table index size.
3016 (make_hash_table, maybe_resize_hash_table): Use it.
3017 (secure_hash): Computer start_byte and end_byte only after
3018 they're known to be in ptrdiff_t range.
3019 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3020 (Ffont_get_glyphs, Ffont_at):
3021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3022 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3023 (Flist_fonts, Fopen_font):
3024 Don't assume fixnum can fit in int.
3025 (check_gstring): Don't assume index can fit in int.
3026 (font_match_p): Check that fixnum is a character, not a nonnegative
3027 fixnum, since the later code needs to stuff it into an int.
3028 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3029 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3030 conversion overflow issues.
3031 (Fopen_font): Check for integer out of range.
3032 (Ffont_get_glyphs): Don't assume index can fit in int.
3033 * font.h: Adjust decls to match defn changes elsewhere.
3034 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3035 integer overflow.
3036 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3037 printmax_t, where ptrdiff_t is wide enough.
3038 (Finternal_char_font):
3039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3040 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3041 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3042 (Fset_frame_position, x_set_frame_parameters)
3043 (x_set_line_spacing, x_set_border_width)
3044 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3045 Check that fixnums are in proper range for system types.
3046 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3048 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3049 Use SAFE_ALLOCA_LISP, not alloca.
3050 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3051 intptr_t is wide enough.
3052 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3053 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3054 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3055 Check for fixnum out of range.
3056 * ftfont.c (ftfont_list): Don't assume index fits in int.
3057 Check that fixnums are in proper range for system types.
3058 (ftfont_shape_by_flt):
3059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3060 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3062 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3063 Check that fixnums are in proper range for system types.
3064 * gnutls.h: Adjust decls to match defn changes elsewhere.
3065 * gtkutil.c (xg_dialog_run):
3066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3067 (update_frame_tool_bar):
3068 Check that fixnums are in proper range for system types.
3069 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3070 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3071 * indent.c (last_known_column, last_known_column_point):
3072 (current_column_bol_cache):
3073 (skip_invisible, current_column, check_display_width):
3074 (check_display_width, scan_for_column, current_column_1)
3075 (Findent_to, Fcurrent_indentation, position_indentation)
3076 (indented_beyond_p, Fmove_to_column, compute_motion):
3077 (Fcompute_motion, Fvertical_motion):
3078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3079 (last_known_column_modified): Use EMACS_INT, not int.
3080 (check_display_width):
3081 (Fcompute_motion):
3082 Check that fixnums and floats are in proper range for system types.
3083 (compute_motion): Don't assume index or fixnum fits in int.
3084 (compute_motion, Fcompute_motion):
3085 Use int, not EMACS_INT, when it is wide enough.
3086 (vmotion): Omit local var start_hpos that is always 0; that way
3087 we don't need to worry about overflow in expressions involving it.
3088 * indent.h: Adjust decls to match defn changes elsewhere.
3089 (struct position):
3090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3091 Use int, not EMACS_INT, where int is wide enough.
3092 Remove unused members ovstring_chars_done and tab_offset;
3093 all uses removed.
3094 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3095 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3096 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3097 (make_gap, copy_text, insert, insert_and_inherit)
3098 (insert_before_markers, insert_before_markers_and_inherit)
3099 (insert_1, count_combining_before, count_combining_after)
3100 (insert_1_both, insert_from_string)
3101 (insert_from_string_before_markers, insert_from_string_1)
3102 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3103 (adjust_after_replace, adjust_after_insert, replace_range)
3104 (replace_range_2, del_range, del_range_1, del_range_byte)
3105 (del_range_both, del_range_2, modify_region)
3106 (prepare_to_modify_buffer, signal_before_change)
3107 (signal_after_change, Fcombine_after_change_execute):
3108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3109 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3110 (balance_an_interval, split_interval_right, split_interval_left)
3111 (find_interval, next_interval, update_interval)
3112 (adjust_intervals_for_insertion, delete_node, delete_interval)
3113 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3114 (static_offset_intervals, offset_intervals)
3115 (merge_interval_right, merge_interval_left, make_new_interval)
3116 (graft_intervals_into_buffer, temp_set_point_both)
3117 (temp_set_point, set_point, adjust_for_invis_intang)
3118 (set_point_both, move_if_not_intangible, get_property_and_range)
3119 (get_local_map, copy_intervals, copy_intervals_to_string)
3120 (compare_string_intervals, set_intervals_multibyte_1):
3121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3122 * intervals.h: Adjust decls to match defn changes elsewhere.
3123 (struct interval):
3124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3125 * keyboard.c (this_command_key_count, this_single_command_key_start)
3126 (before_command_key_count, before_command_echo_length, echo_now)
3127 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3128 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3129 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3130 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3132 (last_non_minibuf_size, last_point_position, echo_truncate)
3133 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3134 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3135 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3136 (stuff_buffered_input):
3137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3138 (last_auto_save, command_loop_1, read_char):
3139 Use EMACS_INT, not int, to avoid integer overflow.
3140 (record_char): Avoid overflow in total_keys computation.
3141 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3142 * keyboard.h: Adjust decls to match defn changes elsewhere.
3143 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3144 (Fkey_description, Fdescribe_vector, Flookup_key):
3145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3146 (click_position): New function, to check that positions are in range.
3147 (Fcurrent_active_maps):
3148 (describe_command):
3149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3150 (Faccessible_keymaps, Fkey_description):
3151 (preferred_sequence_p):
3152 Don't assume fixnum can fit into int.
3153 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3154 Check for integer overflow in size calculations.
3155 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3156 avoid mishandling large integers.
3157 * lisp.h: Adjust decls to match defn changes elsewhere.
3158 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3159 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3160 (struct Lisp_Marker):
3161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3162 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3163 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3164 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3165 All callers changed.
3166 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3167 Assume the arg has valid form, since it always does.
3168 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3169 unsigned integer system type.
3170 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3171 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3172 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3173 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3174 (duration_to_sec_usec): New decl.
3175 * lread.c (read_from_string_index, read_from_string_index_byte)
3176 (read_from_string_limit, readchar, unreadchar, openp)
3177 (read_internal_start, read1, oblookup):
3178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3179 (Fload, readevalloop, Feval_buffer, Feval_region):
3180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3181 (openp): Check for out-of-range argument to 'access'.
3182 (read1): Use int, not EMACS_INT, where int is wide enough.
3183 Don't assume fixnum fits into int.
6efdadfd 3184 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3185 (read_filtered_event): Use duration_to_sec_usec
3186 to do proper overflow checking on durations.
d311d28c
PE
3187 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3188 in size calculation.
3189 (Fexecute_kbd_macro):
3190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3191 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3192 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3193 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3194 (set_marker_both, set_marker_restricted_both, marker_position)
3195 (marker_byte_position, Fbuffer_has_markers_at):
3196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3197 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3198 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3199 It now merely ensures that the menu is large enough, without
3200 necessarily growing it, as this avoids some integer overflow issues.
3201 All callers changed.
3202 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3203 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3204 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3205 Use SAFE_ALLOCA_LISP, not alloca.
3206 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3207 to EMACS_INT. Check that fixnums are in proper range for system types.
3208 * minibuf.c (minibuf_prompt_width, string_to_object)
3209 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3210 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3212 (get_minibuffer, read_minibuf_unwind):
3213 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3214 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3215 this simplifies overflow checking. All callers changed.
3216 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3217 (Ftest_completion):
3218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3219 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3220 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3221 Check that fixnums are in proper range for system types.
3222 (Fx_create_frame, Fx_show_tip):
3223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3224 * nsfont.m (ns_findfonts, nsfont_list_family):
3225 Don't assume fixnum fits in long.
3226 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3228 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3229 wide enough.
17fdb222 3230 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3231 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3232 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3233 (PRINTDECLARE, PRINTPREPARE):
3234 (strout, print_string):
3235 (print, print_preprocess, print_check_string_charset_prop)
3236 (print_object):
3237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3238 (PRINTDECLARE):
3239 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3241 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3242 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3243 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3244 (print_error_message): Use SAFE_ALLOCA, not alloca.
3245 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3246 (print_depth, new_backquote_output, print_number_index):
3247 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3248 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3249 (Fset_process_window_size, Fformat_network_address)
3250 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3251 (sigchld_handler):
d311d28c 3252 Check that fixnums are in proper range for system types.
d44287d4 3253 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3254 Check for process-ids out of pid_t range rather than relying on
3255 undefined behavior.
e4d81efc 3256 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3257 (Fformat_network_address, read_process_output, send_process)
3258 (Fprocess_send_region, status_notify):
3259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3260 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3261 (wait_reading_process_output, read_process_output, exec_sentinel):
3262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3263 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3264 (Faccept_process_output): Use duration_to_sec_usec to do proper
3265 overflow checking on durations.
dde14581
PE
3266 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3267 Don't assume pid_t fits in int.
02481186
PE
3268 * process.h (struct Lisp_Process): Members tick and update_tick
3269 are now of type EMACS_INT, not int.
b62b53e8
PE
3270 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3271 configured --with-wide-int.
d311d28c
PE
3272 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3273 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3274 * search.c (looking_at_1, string_match_1):
3275 (fast_string_match, fast_c_string_match_ignore_case)
3276 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3277 (scan_newline, find_before_next_newline, search_command)
3278 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3279 (set_search_regs, wordify):
3280 (Freplace_match):
3281 (Fmatch_data):
3282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3283 (string_match_1, search_buffer, set_search_regs):
3284 (Fmatch_data):
3285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3286 (wordify): Check for overflow in size calculation.
3287 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3288 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3289 Check that fixnums are in proper range for system types.
3290 * sound.c (struct sound_device)
3291 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3292 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3293 (Fplay_sound_internal):
3294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3295 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3296 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3297 (Fparse_partial_sexp):
3298 Don't assume fixnums can fit in int.
3299 (struct lisp_parse_state, find_start_pos, find_start_value)
3300 (find_start_value_byte, find_start_begv)
3301 (update_syntax_table, char_quoted, dec_bytepos)
3302 (find_defun_start, prev_char_comend_first, back_comment):
3303 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3304 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3306 (Finternal_describe_syntax_value): Check that match_lisp is a
3307 character, not an integer, since the code stuffs it into int.
3308 (scan_words, scan_sexps_forward):
3309 Check that fixnums are in proper range for system types.
3310 (Fforward_word):
3311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3312 (scan_sexps_forward):
3313 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3314 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3315 * syntax.h: Adjust decls to match defn changes elsewhere.
3316 (struct gl_state_s):
3317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3318 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3319 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3320 * sysdep.c (wait_for_termination_1, wait_for_termination)
3321 (interruptible_wait_for_termination, mkdir):
3322 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3323 (emacs_read, emacs_write):
3324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3325 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3326 and double all fit in int.
d311d28c
PE
3327 * term.c (set_tty_color_mode):
3328 Check that fixnums are in proper range for system types.
3329 * termhooks.h (struct input_event):
3330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3331 * textprop.c (validate_interval_range, interval_of)
3332 (Fadd_text_properties, set_text_properties_1)
3333 (Fremove_text_properties, Fremove_list_of_text_properties)
3334 (Ftext_property_any, Ftext_property_not_all)
3335 (copy_text_properties, text_property_list, extend_property_ranges)
3336 (verify_interval_modification):
3337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3338 (Fnext_single_char_property_change)
3339 (Fprevious_single_char_property_change):
3340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3341 (copy_text_properties):
3342 Check for integer overflow in index calculation.
d311d28c
PE
3343 * undo.c (last_boundary_position, record_point, record_insert)
3344 (record_delete, record_marker_adjustment, record_change)
3345 (record_property_change):
3346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3347 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3349 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3350 (Fx_hide_tip, Fx_file_dialog):
3351 * w32menu.c (set_frame_menubar):
3352 Use ptrdiff_t, not int, for consistency with rest of code.
3353 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3354 (select_window, Fdelete_other_windows_internal)
3355 (window_scroll_pixel_based, window_scroll_line_based)
3356 (Frecenter, Fset_window_configuration):
3357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3358 (Fset_window_hscroll, run_window_configuration_change_hook)
3359 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3360 (Fscroll_other_window, Frecenter):
d311d28c
PE
3361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3362 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3363 Don't assume fixnum fits in int.
3364 (Fset_window_scroll_bars):
3365 Check that fixnums are in proper range for system types.
3366 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3367 (string_pos, c_string_pos, number_of_chars, init_iterator)
3368 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3369 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3370 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3371 (face_before_or_after_it_pos, handle_invisible_prop)
3372 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3373 (display_prop_intangible_p, string_buffer_position_lim)
3374 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3375 (get_overlay_strings_1, get_overlay_strings)
3376 (iterate_out_of_display_property, forward_to_next_line_start)
3377 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3378 (get_next_display_element, set_iterator_to_next)
3379 (get_visually_first_element, compute_stop_pos_backwards)
3380 (handle_stop_backwards, next_element_from_buffer)
3381 (move_it_in_display_line_to, move_it_in_display_line)
3382 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3383 (add_to_log, message_dolog, message_log_check_duplicate)
3384 (message2, message2_nolog, message3, message3_nolog
3385 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3386 (current_message_1, truncate_echo_area, truncate_message_1)
3387 (set_message, set_message_1, store_mode_line_noprop)
3388 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3389 (text_outside_line_unchanged_p, check_point_in_composition)
3390 (reconsider_clip_changes)
3391 (redisplay_internal, set_cursor_from_row, try_scrolling)
3392 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3393 (redisplay_window, find_last_unchanged_at_beg_row)
3394 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3395 (trailing_whitespace_p, find_row_edges, display_line)
3396 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3397 (display_mode_element, store_mode_line_string)
3398 (pint2str, pint2hrstr, decode_mode_spec)
3399 (display_count_lines, display_string, draw_glyphs)
3400 (x_produce_glyphs, x_insert_glyphs)
3401 (rows_from_pos_range, mouse_face_from_buffer_pos)
3402 (fast_find_string_pos, mouse_face_from_string_pos)
3403 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3405 (safe_call, init_from_display_pos, handle_fontified_prop)
3406 (handle_single_display_spec, load_overlay_strings)
3407 (with_echo_area_buffer, setup_echo_area_for_printing)
3408 (display_echo_area, echo_area_display)
3409 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3410 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3411 (redisplay_window, dump_glyph_row, display_mode_line)
3412 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3413 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3415 (handle_single_display_spec, build_desired_tool_bar_string)
3416 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3417 (get_specified_cursor_type):
3418 Check that fixnums are in proper range for system types.
3419 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3420 (Flookup_image_map):
3421 Don't assume fixnums fit in int.
3422 (compare_overlay_entries):
3423 Avoid mishandling comparisons due to subtraction overflow.
3424 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3425 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3426 (handle_tool_bar_click):
3427 Use int, not unsigned, since we prefer signed and the signedness
3428 doesn't matter here.
3429 (get_next_display_element, next_element_from_display_vector):
3430 Use int, not EMACS_INT, when int is wide enough.
3431 (start_hourglass): Use duration_to_sec_usec to do proper
3432 overflow checking on durations.
3433 * xfaces.c (Fbitmap_spec_p):
3434 Check that fixnums are in proper range for system types.
3435 (compare_fonts_by_sort_order):
3436 Avoid mishandling comparisons due to subtraction overflow.
3437 (Fx_family_fonts, realize_basic_faces):
3438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3439 (Fx_family_fonts):
3440 Don't assume fixnum fits in int.
3441 Use SAFE_ALLOCA_LISP, not alloca.
3442 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3443 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3444 (face_at_buffer_position, face_for_overlay_string)
3445 (face_at_string_position):
3446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3447 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3448 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3449 (Fx_show_tip):
3450 Check that fixnums are in proper range for system types.
3451 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3452 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3453 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3454 (Fx_change_window_property): Don't assume fixnums fit in int.
3455 * xfont.c (xfont_chars_supported):
3456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3457 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3458 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3460 * xml.c (parse_region):
3461 * xrdb.c (magic_file_p):
3462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3463 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3464 (x_get_local_selection, x_reply_selection_request)
3465 (x_handle_selection_request, wait_for_property_change):
3466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3467 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3468 short is wide enough.
3469 (x_send_client_event): Don't assume fixnum fits in int.
3470 * xterm.c (x_x_to_emacs_modifiers):
3471 Don't assume EMACS_INT overflows nicely into int.
3472 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3473 may come from Lisp.
3474 (handle_one_xevent): NATNUMP can eval its arg twice.
3475 (x_connection_closed):
3476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3477 * xterm.h: Adjust decls to match defn changes elsewhere.
3478 (struct scroll_bar): Use struct vectorlike_header
3479 rather than rolling our own approximation.
3480 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3481
c6574eb5
GM
34822012-05-25 Glenn Morris <rgm@gnu.org>
3483
3484 * lisp.mk (lisp): Update for more files being compiled now.
3485
e8d32c7e
SM
34862012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3487
48def666
SM
3488 * lread.c: Remove `read_pure' which makes no difference.
3489 (read_pure): Remove var.
3490 (unreadpure): Remove function.
3491 (readevalloop): Don't call read_list with -1 flag.
3492 (read1, read_vector): Don't test read_pure any more.
3493 (read_list): Simplify.
3494
e8d32c7e
SM
3495 * fileio.c, character.h: Minor style tweaks.
3496
4b2addb7
DA
34972012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3498
3499 * window.h (clip_changed): Remove useless declaration.
3500
584461b2
JB
35012012-05-22 Juanma Barranquero <lekktu@gmail.com>
3502
3503 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3504 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3505
34374650
PE
35062012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3507
3508 Remove src/m/*.
3509 This directory predates autoconf and is no longer needed nowadays.
3510 Move its few remaining bits of functionality to where they're needed.
3511 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3512 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3513 * m/template.h: Remove.
3514 * Makefile.in (M_FILE): Remove. All uses removed.
3515 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3516 * lisp.h (USE_LSB_TAG):
3517 * mem-limits.h (EXCEEDS_LISP_PTR):
3518 Use VAL_MAX, not VALBITS, in #if.
3519 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3520 (EMACS_UINT): Define unconditionally now.
3521 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3522 (BITS_PER_EMACS_INT): New constants, replacing
3523 what used to be in config.h, but not useful in #if.
3524 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3525 define them any more.
3526 (VAL_MAX): New macro.
3527 (VALMASK): Use it.
3528 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3529 BITS_PER_EMACS_INT, in #if.
3530 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3531 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3532 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3533 * s/ms-w32.h (DATA_START):
3534 Move here from removed file m/intel386.h.
3535 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3536 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3537
261cb4bb
PE
35382012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3539
3540 Assume C89 or later.
3541 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3542 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3543 (xrealloc):
3544 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3545 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3546 * textprop.c, tparam.c (NULL): Remove.
3547 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3548 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3549 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3550 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3551 * xterm.c (input_signal_count): Assume volatile works.
3552
ff23cd9f
KB
35532012-05-21 Ken Brown <kbrown@cornell.edu>
3554
3555 * xgselect.c (xg_select): Fix first argument in call to 'select'
3556 (bug#11508).
3557
1b170bc6
KB
35582012-05-20 Ken Brown <kbrown@cornell.edu>
3559
3560 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3561 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3562
b2f4d39f
KB
35632012-05-19 Ken Brown <kbrown@cornell.edu>
3564
3565 * xfns.c (x_in_use): Remove `static' qualifier.
3566 * xterm.h (x_in_use): Declare.
3567 * xgselect.c: Include xterm.h.
3568 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3569 and `display_arg' (bug#9754).
3570
003fdae2
PE
35712012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3572
9232a6d9
PE
3573 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3574
003fdae2
PE
3575 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3576 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3577
784b56e2
EZ
35782012-05-18 Eli Zaretskii <eliz@gnu.org>
3579
3580 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3581
3582 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3583 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3584
3585 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3586 reference to image_cache->refcount.
3587 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3588
a0a79cde
JL
35892012-05-17 Juri Linkov <juri@jurta.org>
3590
3591 * search.c (Fword_search_regexp, Fword_search_backward)
3592 (Fword_search_forward, Fword_search_backward_lax)
3593 (Fword_search_forward_lax): Move functions to isearch.el
3594 (bug#10145, bug#11381).
3595
b0572523
PE
35962012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3597
3598 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3599
9660f5fc
SM
36002012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3601
3602 * lread.c (init_obarray): Declare Qt and Qnil as special.
3603
4374de83
GM
36042012-05-14 Glenn Morris <rgm@gnu.org>
3605
3606 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3607 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3608
dc44c39a
PE
36092012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3610
078c97cb
PE
3611 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3612
dc44c39a
PE
3613 * unexaix.c: Port to more-recent AIX compilers.
3614 (report_error, report_error_1, make_hdr, copy_sym)
3615 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3616 Make arguments const char *, not char *, to avoid violations of C
3617 standard and to fix some AIX warnings reported by Gilles Pion.
3618
e18afed7 36192012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3620
3621 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3622 already have overlays loaded.
3623 (handle_single_display_spec): Before returning without displaying
3624 fringe bitmap, synchronize the bidi iterator with the main display
3625 iterator, by calling iterate_out_of_display_property.
3626 (iterate_out_of_display_property): Detect buffer iteration by
3627 testing that it->string is a Lisp string.
3628 (get_next_display_element): When the current object is exhausted,
3629 and there's something on it->stack, call set_iterator_to_next to
3630 proceed with what's on the stack, instead of returning zero.
3631 (set_iterator_to_next): If called at the end of a Lisp string,
3632 proceed to consider_string_end without incrementing string
3633 position. Don't increment display vector index past the end of
3634 the display vector. (Bug#11417)
c8fb9dc6
EZ
3635 (pos_visible_p): Don't report a position visible when move_it_to
3636 stopped at the last line of window, which happens to be scanned
3637 backwards by the bidi iteration. (Bug#11464)
ac268e67 3638
e18afed7 36392012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3640
3641 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3642 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3643 are on a TTY, and thus unable to display on the fringes.
3644 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3645 so we need to signal to the caller that this is a "replacing"
3646 display spec. This fixes display when the spec is invalid or we
3647 are on a TTY.
3648
e18afed7 36492012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3650
3651 * unexaix.c (make_hdr): Fix typo in prototype.
3652 This bug broke the build on AIX. Problem reported by Gilles Pion.
3653
9d0a235a
MA
36542012-05-14 Michael Albinus <michael.albinus@gmx.de>
3655
3656 * keyboard.c (kbd_buffer_get_event): Read special events also in
3657 batch mode. (Bug#11415)
3658
9e6b06ed
GM
36592012-05-12 Glenn Morris <rgm@gnu.org>
3660
3661 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3662
c1a1d7a3
EZ
36632012-05-12 Eli Zaretskii <eliz@gnu.org>
3664
3665 * lisp.mk (lisp): Add newcomment.elc.
3666
3fe7cdc8
GM
36672012-05-12 Glenn Morris <rgm@gnu.org>
3668
3669 * Makefile.in (MKDIR_P): New, set by configure.
3670 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3671
53f7d2c0
PE
36722012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3673
3674 Remove unused function hourglass_started.
3675 * dispextern.h (hourglass_started):
3676 * w32fns.c (hourglass_started):
3677 * xdisp.c (hourglass_started): Remove.
3678
75aafb17
JB
36792012-05-10 Juanma Barranquero <lekktu@gmail.com>
3680
3681 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3682 Update dependencies.
3683
12959e8e
PE
36842012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3685
97107e2e
PE
3686 * xgselect.c (xg_select): Put maxfds+1 into a var.
3687 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3688
12959e8e
PE
3689 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3690
836d29b3
DA
36912012-05-10 Dave Abrahams <dave@boostpro.com>
3692
3693 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3694 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3695
5cb67954
MA
36962012-05-09 Michael Albinus <michael.albinus@gmx.de>
3697
3698 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3699 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3700 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3701 Initialize xd_registered_buses.
3702
3478ec45
PE
37032012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3704
b263a6b0
PE
3705 Untag more efficiently if USE_LSB_TAG.
3706 This is based on a proposal by YAMAMOTO Mitsuharu in
3707 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3708 For an admittedly artificial (nth 8000 longlist) benchmark on
3709 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3710 Emacs's overall text size by 1%.
3711 * lisp.h (XUNTAG): New macro.
3712 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3713 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3714 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3715 * eval.c (Fautoload):
3716 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3717 * frame.h (XFRAME): Use XUNTAG.
3718
3478ec45
PE
3719 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3720 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3721 Remove unportable assumptions about print widths of types like
3722 dbus_uint32_t.
3723 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3724 intptr_t when converting between pointer and integer, to avoid GCC
3725 warnings about wrong width.
3726
666b903b 37272012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3728
3729 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3730 stack for each reader_thread, instead of defaulting to 8MB
3731 determined by the linker. This avoids failures in creating
3732 subprocesses on Windows 7, see the discussion in this thread:
3733 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3734
b120cc17
JC
37352012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3736
3737 Fix up display of the *Minibuf-0* buffer in the mini window.
3738 * keyboard.c (read_char): Don't clear the echo area if there's no
3739 message to clear.
3740 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3741 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3742
9a4b36f8
MA
37432012-05-07 Michael Albinus <michael.albinus@gmx.de>
3744
3745 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3746 batch mode.
3747
e5f9458f
CY
37482012-05-06 Chong Yidong <cyd@gnu.org>
3749
3750 * lisp.mk (lisp): Update.
3751
eceeb5fc 37522012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3753
3754 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3755
71873e2b
SM
37562012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3757
3758 * data.c (PUT_ERROR): New macro.
3759 (syms_of_data): Use it. Add new error type `user-error'.
3760 * undo.c (user_error): New function.
3761 (Fprimitive_undo): Use it.
3762 * print.c (print_error_message): Adjust print style for `user-error'.
3763 * keyboard.c (user_error): New function.
3764 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3765
ab0fa4e4
PE
37662012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3767
3768 Do not limit current-time-string to years 1000..9999.
3769 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3770 (Fcurrent_time_string): Support any year that is supported by the
3771 underlying localtime representation. Don't use asctime, as it
3772 has undefined behavior for years outside the range -999..9999.
3773
7ed806a7
PE
37742012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3775
3776 Fix race conditions involving setenv, gmtime, localtime, asctime.
3777 Without this fix, interrupts could mess up code that uses these
3778 nonreentrant functions, since setting TZ invalidates existing
3779 tm_zone or tzname values, and since most of these functions return
3780 pointers to static storage.
3781 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3782 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3783 Grow the critical sections to include not just invoking
3784 localtime/gmtime, but also accessing these functions' results
3785 including their tm_zone values if any, and any related TZ setting.
3786 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3787 so that the struct tm is saved in the critical section.
3788 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3789 motivated by the fact that memory allocation needs to be outside
3790 the critical section.
3791
0c16dfed
DA
37922012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3793
3794 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3795 with RESET_INTERVAL.
3796
3797 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3798 Remove duplicated buffer name initialization.
3799
3f83ace8
JM
38002012-05-02 Jim Meyering <jim@meyering.net>
3801
3802 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3803
c7b8541e
JM
3804 * xfns.c (x_window): Use xstrdup (Bug#11375).
3805
90207a15 38062012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3807
3808 * xdisp.c (pos_visible_p): If already at a newline from the
3809 display string before the 'while' loop, don't walk back the glyphs
3810 from it3.glyph_row. Solves assertion violation when the display
3811 string begins with a newline (egg.el). (Bug#11367)
3812
b593d6a9
AH
38132012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3814
3815 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3816 Move to simple.el.
3817
4737362e
GM
38182012-05-01 Glenn Morris <rgm@gnu.org>
3819
99cf43f9
GM
3820 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3821 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3822 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3823 All were removed before 23.1.
3824
9311dcff
GM
3825 * dispnew.c: Remove HAVE_LIBNCURSES test;
3826 it is always true on relevant platforms.
3827
4d5c6349
GM
3828 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3829 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3830
4737362e
GM
3831 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3832
74dd3a6b
AS
38332012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3834
3835 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3836 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3837 Remove.
3838
13c379ee
PE
38392012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3840
3841 Do not avoid creating empty evaporating overlays (Bug#9642).
3842 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3843 That is, do not delete an evaporating overlay if it becomes
3844 empty after its bounds are adjusted to fit within its buffer.
3845 This fix caused other problems, and I'm reverting it until we get
3846 to the bottom of them.
3847
a8e7d6d7 38482012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3849
3850 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3851
a8e7d6d7 38522012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3853
3854 * xdisp.c (pos_visible_p): If the window start position is beyond
3855 ZV, start the display from buffer beginning. Prevents assertion
3856 violation in init_iterator when the minibuffer window is scrolled
3857 via the scroll bar.
3858
3859 * window.c (window_scroll_pixel_based): Likewise.
3860
a8e7d6d7 38612012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3862
3863 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3864
a8e7d6d7 38652012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3866
3867 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3868 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3869
a8e7d6d7 38702012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3871
b593d6a9
AH
3872 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3873 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3874
1c6900d9
EZ
38752012-04-26 Eli Zaretskii <eliz@gnu.org>
3876
4c3fa1d9
EZ
3877 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3878 display element, check also the underlying string or buffer
3879 character. (Bug#11341)
3880
1c6900d9
EZ
3881 * w32menu.c: Include w32heap.h.
3882 (add_menu_item): If the call to AppendMenuW (via
3883 unicode_append_menu) fails, disable Unicode menus only if we are
3884 running on Windows 9X/Me.
3885
42bf8205
AS
38862012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3887
3888 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3889 (xgetint): Add missing shift for LSB tags.
3890
b1bac16e
MR
38912012-04-24 Martin Rudalics <rudalics@gmx.at>
3892
3893 * keyboard.c (read_char): Don't wipe echo area for select window
3894 events: These might get delayed via `mouse-autoselect-window'
3895 (Bug#11304).
3896
d69621cc
JB
38972012-04-24 Juanma Barranquero <lekktu@gmail.com>
3898
3899 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3900 manipulation of :loaded-from data.
3901
02fd101b
JB
39022012-04-23 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3905 now a cons (bug#11311).
3906
888bec30
PE
39072012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3908
89a438bd
PE
3909 Do not create empty overlays with the evaporate property (Bug#9642).
3910 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3911 if it becomes empty after its bounds are adjusted to fit within
3912 its buffer. Without this fix, in a nonempty buffer (let ((o
3913 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3914 yields an empty overlay that has the evaporate property, which is
3915 not supposed to happen.
3916
1068fe4d
PE
3917 Fix minor GTK3 problems found by static checking.
3918 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3919 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3920 (struct _EmacsFixedClass, emacs_fixed_get_type):
3921 Move decls here from emacsgtkfixed.h, since they needn't be public.
3922 (emacs_fixed_get_type): Now static.
3923 (emacs_fixed_class_init): Omit unused local.
3924 (emacs_fixed_child_type): Remove; unused.
3925 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3926 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3927 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3928 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3929 (EMACS_FIXED_GET_CLASS): Remove; unused.
3930 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3931
888bec30
PE
3932 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3933 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3934
de85e130
PE
39352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3936
d0baac98 3937 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3938 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3939 (__malloc_size_t, __malloc_ptrdiff_t):
3940 Remove. All uses removed, replaced by the definiens if needed,
3941 since we can assume C89 or better now.
3942 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3943 (protect_malloc_state, align, get_contiguous_space)
3944 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3945 (malloc_atfork_handler_child, malloc_enable_thread)
3946 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3947 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3948 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3949 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3950 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3951 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3952 Define using prototypes, not old style.
3953 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3954 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3955 (align): Don't assume that signed integer overflow wraps around.
3956 Omit unused local var.
3957 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3958 (_free_internal_nolock, memalign, mallochook, reallochook):
3959 Omit no-longer-needed casts.
3960 (valloc): Use getpagesize, not __getpagesize.
3961 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3962 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3963
de85e130
PE
3964 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3965
dcbf5805
MA
39662012-04-22 Michael Albinus <michael.albinus@gmx.de>
3967
3968 Move functions from C to Lisp. Make non-blocking method calls
3969 the default. Implement further D-Bus standard interfaces.
3970
3971 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3972 (QCdbus_request_name_allow_replacement)
3973 (QCdbus_request_name_replace_existing)
3974 (QCdbus_request_name_do_not_queue)
3975 (QCdbus_request_name_reply_primary_owner)
3976 (QCdbus_request_name_reply_in_queue)
3977 (QCdbus_request_name_reply_exists)
3978 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3979 (QCdbus_registered_serial, QCdbus_registered_method)
3980 (QCdbus_registered_signal): New Lisp objects.
3981 (XD_DEBUG_MESSAGE): Use sizeof.
3982 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3983 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3984 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3985 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3986 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3987 (xd_signature, xd_append_arg): Allow float for integer types.
3988 (xd_get_connection_references): New function.
b593d6a9
AH
3989 (xd_get_connection_address): Rename from xd_initialize.
3990 Return cached address.
dcbf5805
MA
3991 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3992 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3993 level.
3994 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3995 Return number of refcounts.
dcbf5805
MA
3996 (Fdbus_get_unique_name): Make stronger parameter check.
3997 (Fdbus_message_internal): New defun.
3998 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3999 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4000 (Fdbus_send_signal, Fdbus_register_service)
4001 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4002 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4003 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4004 (Vdbus_compiled_version, Vdbus_runtime_version)
4005 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4006 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4007 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4008 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4009 Adapt docstring.
dcbf5805 4010
52828e02
PE
40112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4012
da05bc4c
PE
4013 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4014 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4015 Do not assume ptrdiff_t is the same width as 'int'.
4016
52828e02
PE
4017 * alloc.c: Handle unusual debugging option combinations.
4018 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4019 since the two debugging options are incompatible.
4020 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4021 is defined.
4022 (mem_init, mem_insert, mem_insert_fixup):
4023 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4024 (NEED_MEM_INSERT): Remove; no longer needed.
4025
f01769f9
LL
40262012-04-22 Leo Liu <sdl.web@gmail.com>
4027
4028 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4029
5790543d
PE
40302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4031
4032 * sysdep.c [__FreeBSD__]: Minor cleanups.
4033 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4034 Use Emacs indenting style more consistently. Avoid some casts.
4035 Use 'double' consistently rather than mixing 'float' and 'double'.
4036
b91b7e4d
EW
40372012-04-21 Eduard Wiebe <usenet@pusto.de>
4038
b593d6a9
AH
4039 * sysdep.c (list_system_processes, system_process_attributes):
4040 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4041
6114eb15
AS
40422012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4043
4044 * lisp.mk (lisp): Update.
4045
2f38dff7
PE
40462012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4047
4048 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4049 It is never used otherwise.
4050
4ae29f89
SM
40512012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4052
4053 * print.c (print_preprocess): Only check print_depth if print-circle
4054 is nil.
4055 (print_object): Check for cycles even when print-circle is nil and
4056 print-gensym is t, but only check print_depth if print-circle is nil.
4057
f30d612a
CY
40582012-04-20 Chong Yidong <cyd@gnu.org>
4059
4060 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4061 set the status to "failed" and ensure that sentinel is run.
4062
c07a4c0b 40632012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4064
4065 * process.c (Fset_process_inherit_coding_system_flag)
4066 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4067 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4068
c07a4c0b 40692012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4070
4071 * xdisp.c (string_buffer_position_lim): Limit starting position to
4072 BEGV.
4073 (set_cursor_from_row): If called for a mode-line or header-line
4074 row, return zero immediately.
4075 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4076 farther than the first row after the header line, if any.
4077 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4078 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4079
c07a4c0b 40802012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4081
4ae29f89
SM
4082 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4083 (bug#11238).
ad3a2b41 4084
c07a4c0b 40852012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 40862012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4087
4088 configure: new option --enable-gcc-warnings (Bug#11207)
4089 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4090 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4091 (ALL_CFLAGS): Use new macros rather than old.
4092 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4093 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4094 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4095 -Wunused-result, -Wunused-variable. This should go away once
4096 the Emacs and Gnulib regex code is merged.
4097 (xmalloc, xrealloc): Now static.
4098
aba027e8
PE
40992012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4100
4101 * dired.c (Fsystem_groups): Remove unused local.
4102
e5a36063
GM
41032012-04-17 Glenn Morris <rgm@gnu.org>
4104
4105 * dired.c (Fsystem_users): Doc fix.
4106
316411f0
DA
41072012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4108
4109 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4110 (syms_of_dired): Add them.
4111
9426aba4
PE
41122012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4113
b62a57be
PE
4114 Fix minor alloc.c problems found by static checking.
4115 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4116 New extern decls, to avoid calling undeclared functions.
4117 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4118 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4119 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4120 (NEED_MEM_INSERT): New macro.
4121 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4122 Remove one incorrect comment and fix another.
b62a57be 4123
3539f31f
PE
4124 Fix minor ralloc.c problems found by static checking.
4125 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4126 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4127 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4128 (r_alloc_sbrk): Now static.
4129
a041960a
PE
4130 Improve ralloc.c interface checking.
4131 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4132 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4133 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4134 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4135 [REL_ALLOC]: ... to here, to check interface.
4136 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4137 Remove decls. This fixes an "It stinks!".
4138
9426aba4
PE
4139 * alloc.c (which_symbols): Fix alignment issue / type clash.
4140
d55c12ed
AS
41412012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4142
4143 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4144 (struct Lisp_Misc_Any): Likewise.
4145 (struct Lisp_Free): Likewise.
4146 * alloc.c (union aligned_Lisp_Symbol): Define.
4147 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4148 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4149 (union aligned_Lisp_Misc): Define.
4150 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4151 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4152 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4153
b948ce8b
PE
41542012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4155
4156 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4157 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4158 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4159 * s/netbsd.h, s/sol2-6.h:
4160 Remove definition of GC_MARK_STACK, since the default now works.
4161 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4162 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4163 no longer the default.
4164 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4165
35dc09a1 41662012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4167
35dc09a1
GM
4168 * lread.c (lisp_file_lexically_bound_p):
4169 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4170
35dc09a1
GM
41712012-04-14 Eli Zaretskii <eliz@gnu.org>
4172
4173 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4174 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4175
41762012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4177
4178 * nsterm.m (constrainFrameRect): Always constrain when there is only
4179 one screen (Bug#10962).
4180
bcd86815
KB
41812012-04-13 Ken Brown <kbrown@cornell.edu>
4182
4183 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4184
c25df26e
RT
41852012-04-13 Reuben Thomas <rrt@sc3d.org>
4186
4187 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4188
0fc59f1e
DC
41892012-04-11 Daniel Colascione <dancol@dancol.org>
4190
4191 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4192 against is gone. It's better to use vfork now so that when Cygwin
4193 gains a new, working vfork, we use it automatically (bug#10398).
4194
de8c03dc
SM
41952012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4196
4197 * window.c (save_window_save): Obey window-point-insertion-type.
4198
2f097256
GM
41992012-04-11 Glenn Morris <rgm@gnu.org>
4200
4201 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4202
453b951e
SM
42032012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4204
4205 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4206
75f1671a 42072012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4208
4209 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4210 (force_quit_count): New var.
4211 (handle_interrupt): Use it.
4212
2a8ce227
JB
42132012-04-10 Juanma Barranquero <lekktu@gmail.com>
4214
4215 * w32.c (w32_delayed_load): Record the full path of the library
4216 being loaded (bug#10424).
4217
935396c0
GM
42182012-04-09 Glenn Morris <rgm@gnu.org>
4219
05920a43
GM
4220 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4221 not just in the obarray, before snarfing them. (Bug#11036)
4222
935396c0
GM
4223 * Makefile.in ($(leimdir)/leim-list.el):
4224 Pass EMACS rather than BUILT_EMACS.
4225
a18ecafa
TZ
42262012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4227
4228 * process.c (make_process):
4229 * process.h: Add integer `gnutls_handshakes_tried' member to
4230 process struct.
4231
6bbef4e5
JC
4232 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4233 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4234
4235 * gnutls.c (gnutls_log_function2i): Convenience log function.
4236 (emacs_gnutls_read): Use new log functions,
4237 `gnutls_handshakes_tried' process member, and
4238 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4239 attempts per process (connection).
4240
b4d3bc10
CY
42412012-04-09 Chong Yidong <cyd@gnu.org>
4242
4243 * eval.c (Fuser_variable_p, user_variable_p_eh)
4244 (lisp_indirect_variable): Functions deleted.
4245 (Fdefvar): Caller changed.
4246
4247 * callint.c (Finteractive, Fcall_interactively):
4248 * minibuf.c (Fread_variable): Callers changed.
4249
70f4d973
EZ
42502012-04-09 Eli Zaretskii <eliz@gnu.org>
4251
4252 * xdisp.c (set_cursor_from_row): If the display string appears in
4253 the buffer at position that is closer to point than the position
4254 after the display string, display the cursor on the first glyph of
4255 the display string. Fixes cursor display when a 'display' text
4256 property immediately follows invisible text. (Bug#11094)
4257
cb3c2e3e
PE
42582012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 composite.c: use 'double' consistently
4261 * composite.c (get_composition_id): Use 'double' consistently
4262 instead of converting 'float' to 'double' and vice versa; this is
4263 easier to understand and avoids a GCC warning.
4264
fd06db5d
GM
42652012-04-09 Glenn Morris <rgm@gnu.org>
4266
50fe702a
GM
4267 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4268 preparation for dumping it with emacs. (Bug#4789)
4269 (leimdir): New variable.
4270 ($(leimdir)/leim-list.el): New rule.
4271 (emacs$(EXEEXT)): Depend on leim-list.el.
4272
fd06db5d
GM
4273 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4274 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4275 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4276
55c131ee
AS
42772012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4278
4279 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4280 proper alignment.
4281
9209588f
JB
42822012-04-07 Juanma Barranquero <lekktu@gmail.com>
4283
4284 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4285 Remove unused local variable.
4286
e3fb2efb
PE
42872012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4288
4289 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4290 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4291 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4292 objects, as mark_maybe_pointer will catch them otherwise.
4293 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4294 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4295
b5385551
PE
42962012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 Fix typo that broke non-Windows builds.
4299 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4300
9078ead6
EZ
43012012-04-07 Eli Zaretskii <eliz@gnu.org>
4302
4303 Support building on MS-Windows with libxml2.
4304
4305 * makefile.w32-in (OBJ2): Add xml.$(O).
4306 (GLOBAL_SOURCES): Add xml.c.
4307 ($(BLD)/xml.$(O)): New dependency list.
4308
4309 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4310 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4311 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4312 [!WINDOWSNT]: New macros.
4313 (init_libxml2_functions, libxml2_loaded_p): New functions.
4314 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4315 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4316 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4317 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4318 linked in).
6bbef4e5
JC
4319 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4320 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4321 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4322
4323 * emacs.c: Don't include libxml/parser.h.
4324 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4325 xmlCleanupParser directly.
4326
4327 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4328
3811fdf3
EZ
43292012-04-07 Eli Zaretskii <eliz@gnu.org>
4330
4331 * indent.c (Fvertical_motion): If there is a display string at
4332 point, use it.vpos to compute how many lines to backtrack after
4333 move_it_to point. (Bug#11133)
4334
2f8e16b2
EZ
43352012-04-06 Eli Zaretskii <eliz@gnu.org>
4336
4337 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4338 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4339 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4340 macros related to unification of CJK characters. For the details,
4341 see the discussion following the message here:
4342 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4343
3d439cd1
CY
43442012-04-04 Chong Yidong <cyd@gnu.org>
4345
4346 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4347
8bc53d00
EZ
43482012-04-01 Eli Zaretskii <eliz@gnu.org>
4349
4350 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4351 instead of alloca. (Bug#11138)
4352
3b0512a3
AS
43532012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4354
4355 * w32menu.c (is_simple_dialog): Properly check lisp types.
4356 (Bug#11141)
4357
8427ddd2
EZ
43582012-03-31 Eli Zaretskii <eliz@gnu.org>
4359
979022ef
EZ
4360 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4361 position we get to after a call to move_it_to fails the
4362 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4363 only if we wind up in a string from display property. (Bug#11063)
4364
a6b1c7cc
EZ
4365 * window.c (Fdelete_other_windows_internal): Invalidate the row
4366 and column information about mouse highlight, so that redisplay
4367 restores it after reallocating the glyph matrices. (Bug#7464)
4368
8427ddd2
EZ
4369 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4370 string comes from a `display' text property, use the buffer
4371 position of that property as if we actually saw that position in
4372 the row's glyphs.
697ba24b
EZ
4373 (move_it_by_lines): Remove the assertion that
4374 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4375 violated when there's a before-string at the beginning of a line.
4376 (Bug#11063)
8427ddd2 4377
65a0a738
EZ
43782012-03-30 Eli Zaretskii <eliz@gnu.org>
4379
4380 * xdisp.c (append_space_for_newline): If the default face was
4381 remapped, use the remapped face for the appended newline.
4382 (extend_face_to_end_of_line): Use the remapped default face for
4383 extending the face to the end of the line.
4384 (display_line): Call extend_face_to_end_of_line when the default
4385 face was remapped. (Bug#11068)
4386
581355cc
EZ
43872012-03-29 Eli Zaretskii <eliz@gnu.org>
4388
4389 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4390
e8fc049f
SM
43912012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4392
4393 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4394
4fb9a543
GM
43952012-03-27 Glenn Morris <rgm@gnu.org>
4396
4397 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4398 Doc fixes.
4399
679910f1
KH
44002012-03-26 Kenichi Handa <handa@m17n.org>
4401
4402 * dispextern.h (struct glyph): Fix previous change. Change the
4403 bit length of glyphless.ch to 25 (Bug#11082).
4404
90d49b7f
CY
44052012-03-26 Chong Yidong <cyd@gnu.org>
4406
4407 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4408 (command_loop_1): Use it; inhibit selection update for
4409 handle-select-window too (Bug#8996).
4410
f514f6f0
FP
44112012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4412
e8fc049f 4413 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4414
bf43fa51
KH
44152012-03-25 Kenichi Handa <handa@m17n.org>
4416
4417 * dispextern.h (struct glyph): Change the bit length of
4418 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4419
8a0c01dd
EZ
44202012-03-24 Eli Zaretskii <eliz@gnu.org>
4421
4422 * s/ms-w32.h (tzname): Include time.h before redirecting to
4423 _tzname. Fixes the MSVC build. (Bug#9960)
4424
7d1c3a76
AS
44252012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4426
8ed79523
AS
4427 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4428 characters.
4429
7d1c3a76
AS
4430 * xterm.c (XTread_socket): Only modify handling_signal if
4431 !SYNC_INPUT. (Bug#11080)
4432
e99a9b8b
EZ
44332012-03-23 Eli Zaretskii <eliz@gnu.org>
4434
4435 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4436 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4437 when fetching a multibyte character consumes more bytes than
4438 CHAR_BYTES returns, due to unification of CJK characters in
4439 string_char. (Bug#11073)
4440
5063c0e1
TN
44412012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4442
4443 * process.c (wait_reading_process_output): Handle pty disconnect
4444 by refraining from sending oneself a SIGCHLD (bug#10933).
4445
9f851fbd
CY
44462012-03-22 Chong Yidong <cyd@gnu.org>
4447
4448 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4449
5063c0e1 4450 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4451 Mark string as coming from a prefix property.
4452 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4453 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4454
fb5b8aca
CY
44552012-03-21 Chong Yidong <cyd@gnu.org>
4456
4457 * xfaces.c (Vface_remapping_alist): Doc fix.
4458
62356a1b
EZ
44592012-03-20 Eli Zaretskii <eliz@gnu.org>
4460
4461 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4462 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4463 Doc fixes.
62356a1b 4464
025de85b
CY
44652012-03-20 Chong Yidong <cyd@gnu.org>
4466
4467 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4468 to reflect default non-nil value of redisplay-dont-pause.
4469
4827f94e
KH
44702012-03-19 Kenichi Handa <handa@m17n.org>
4471
4472 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4473 it fit in a valid range (Bug#11003).
4474
e50a24a2
EZ
44752012-03-18 Eli Zaretskii <eliz@gnu.org>
4476
4477 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4478 that is not from display property, accept the row as a "cursor
4479 row" if one of the string's character has a non-nil `cursor'
4480 property. Fixes cursor positioning when there are newlines in
4481 overlay strings, e.g. in icomplete.el. (Bug#11035)
4482
9af5ed87
PE
44832012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4484
4485 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4486
d1f55f16
CY
44872012-03-12 Chong Yidong <cyd@gnu.org>
4488
4489 * eval.c (inhibit_lisp_code): Rename from
4490 inhibit_window_configuration_change_hook; move from window.c.
4491
4492 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4493 * window.c (run_window_configuration_change_hook)
4494 (syms_of_window): Callers changed.
4495
66c5eebd
CY
44962012-03-11 Chong Yidong <cyd@gnu.org>
4497
413df973
CY
4498 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4499
66c5eebd
CY
4500 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4501
1de11f56
CY
45022012-03-10 Chong Yidong <cyd@gnu.org>
4503
4504 * frame.c (other_visible_frames): Don't assume the selected frame
4505 is visible (Bug#10955).
4506
cae07000
SM
45072012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4508
4509 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4510
89c94350
JD
45112012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4512
4513 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4514 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4515 zero (Bug#10954).
4516
999dd333
GM
45172012-03-03 Glenn Morris <rgm@gnu.org>
4518
01a6dcc8 4519 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4520
de0100f2
EZ
45212012-03-02 Eli Zaretskii <eliz@gnu.org>
4522
4523 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4524 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4525 (redisplay_window, next_element_from_string): Fix typos in
4526 comments.
3e441275
EZ
4527 (redisplay_window): Pass to move_it_vertically the margin in
4528 pixels, not in screen lines.
de0100f2 4529
96a72ee9
GM
45302012-03-02 Glenn Morris <rgm@gnu.org>
4531
4532 * buffer.c (buffer-list-update-hook): Doc fix.
4533
312508d7
EZ
45342012-02-29 Eli Zaretskii <eliz@gnu.org>
4535
4536 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4537 push_it before setting up the iterator for the first overlay
4538 string, even if we have an empty string loaded.
4539 (next_overlay_string): If there's an empty string on the iterator
4540 stack, pop the stack. (Bug#10903)
4541
27f3c637
PE
45422012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4543
4544 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4545 Suggested by Stefan Monnier in
4546 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4547 * alloc.c (widen_to_Lisp_Object): New static function.
4548 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4549 and widening them to Lisp_Objects. This would work even if
4550 USE_LSB_TAG is defined and wide integers are used, which might
4551 happen in a future version of Emacs.
4552
3c9dfce6
CY
45532012-02-25 Chong Yidong <cyd@gnu.org>
4554
fa74b241
CY
4555 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4556 Doc fix.
4557
3c9dfce6
CY
4558 * xselect.c (Fx_selection_exists_p): Doc fix.
4559 (x_clipboard_manager_save_all): Print an informative message
4560 before saving to clipboard manager.
4561
9486df08
CY
45622012-02-24 Chong Yidong <cyd@gnu.org>
4563
4564 * keyboard.c (process_special_events): Handle all X selection
4565 requests in kbd_buffer, not just the next one (Bug#8869).
4566
f01d3321
CY
45672012-02-23 Chong Yidong <cyd@gnu.org>
4568
4569 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4570 call when setting menu-bar-lines and tool-bar-lines parameters.
4571 (unwind_create_frame_1): New helper function.
4572
4573 * window.c (inhibit_window_configuration_change_hook): New var.
4574 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4575 (syms_of_window): Initialize it.
f01d3321 4576
86b847b6
CY
45772012-02-22 Chong Yidong <cyd@gnu.org>
4578
4579 * xterm.c (x_draw_image_relief): Add missing type check for
4580 Vtool_bar_button_margin (Bug#10743).
4581
a59225b1
CY
45822012-02-21 Chong Yidong <cyd@gnu.org>
4583
4584 * fileio.c (Vfile_name_handler_alist): Doc fix.
4585
4586 * buffer.c (Fget_file_buffer): Protect against invalid file
4587 handler return value.
4588
310f5bd4
PE
45892012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4590
cb3a28cc
PE
4591 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4592 when computing $valmask.
4593
310f5bd4
PE
4594 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4595 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4596 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4597 It's useless in that case, and it can cause problems on hosts
4598 that allocate halves of EMACS_INT values separately.
4599 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4600 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4601 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4602 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4603 it avoids undefined behavior on hosts where shifting right by more
4604 than the word width has undefined behavior.
4605
2375c96a
CY
46062012-02-19 Chong Yidong <cyd@gnu.org>
4607
4608 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4609 (Funhandled_file_name_directory, Ffile_name_as_directory)
4610 (Fdirectory_file_name, Fexpand_file_name)
4611 (Fsubstitute_in_file_name): Protect against invalid file handler
4612 return values (Bug#10845).
4613
3eb49e71
EZ
46142012-02-18 Eli Zaretskii <eliz@gnu.org>
4615
4616 * .gdbinit (pitx): Fix incorrect references to fields of the
4617 iterator stack.
4618
7b926f3f
CY
46192012-02-17 Chong Yidong <cyd@gnu.org>
4620
4621 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4622
11273115
PE
46232012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4624
4625 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4626 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4627
c3a70e2b
CY
46282012-02-15 Chong Yidong <cyd@gnu.org>
4629
4630 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4631 marked as special. Also, starting docstrings with * is obsolete.
4632
0ca43699
AS
46332012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4634
4635 * gnutls.c (emacs_gnutls_write): Fix last change.
4636
2e8f3c56
LI
46372012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4638
4639 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4640 send_process.
4641
af70074f
SM
46422012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4643
4644 * keymap.c (Fsingle_key_description): Handle char ranges.
4645
95986d52
CY
46462012-02-12 Chong Yidong <cyd@gnu.org>
4647
afd83bd1
CY
4648 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4649 as that creates a dangerous corner case.
4650
95986d52
CY
4651 * window.c (Fdelete_window_internal): Invalidate the mouse
4652 highlight (Bug#9904).
4653
bd7da63e
GM
46542012-02-12 Glenn Morris <rgm@gnu.org>
4655
4656 * xselect.c (Fx_own_selection_internal)
4657 (Fx_get_selection_internal, Fx_disown_selection_internal)
4658 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4659 * nsselect.m (Fx_own_selection_internal)
4660 (Fx_disown_selection_internal, Fx_selection_exists_p)
4661 (Fx_selection_owner_p, Fx_get_selection_internal):
4662 Sync docs and argument specs with the xselect.c versions.
4663
77abcbc2
LI
46642012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4665
4666 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4667
90b671e2
EZ
46682012-02-11 Eli Zaretskii <eliz@gnu.org>
4669
1c0ca0b7
EZ
4670 * w32select.c (Fx_selection_exists_p): Sync doc string and
4671 argument list with xselect.c. (Bug#10783)
4672
4673 * w16select.c (Fx_selection_exists_p): Sync doc string and
4674 argument list with xselect.c. (Bug#10783)
90b671e2 4675
49241268
GM
46762012-02-10 Glenn Morris <rgm@gnu.org>
4677
4678 * fns.c (Fsecure_hash): Doc fix.
4679
f998bbe7 46802012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4681
4682 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4683
0992bd9c
CY
46842012-02-07 Chong Yidong <cyd@gnu.org>
4685
4686 * buffer.c (Fbuffer_local_variables)
4687 (buffer_lisp_local_variables): Handle unbound vars correctly;
4688 don't let Qunbound leak into Lisp.
4689
af008560
GM
46902012-02-07 Glenn Morris <rgm@gnu.org>
4691
dd605cc4
GM
4692 * image.c (Fimagemagick_types): Doc fix.
4693
af008560
GM
4694 * image.c (imagemagick-render-type): Change it from a lisp object
4695 to an integer. Move the doc here from the lisp manual.
4696 Treat all values not equal to 0 the same.
4697
1449fa1d
CY
46982012-02-06 Chong Yidong <cyd@gnu.org>
4699
4700 * doc.c (store_function_docstring): Avoid applying docstring of
4701 alias to base function (Bug#2603).
4702
3723ec07
AS
47032012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4704
4705 * .gdbinit (pp1, pv1): Remove redundant defines.
4706 (pr): Use pp.
4707
79c1cc1e
CY
47082012-02-04 Chong Yidong <cyd@gnu.org>
4709
4710 * nsterm.m: Declare a global (Bug#10694).
4711
d7f29f8e
EZ
47122012-02-04 Eli Zaretskii <eliz@gnu.org>
4713
cae07000
SM
4714 * w32.c (get_emacs_configuration_options):
4715 Include --enable-checking, if specified, in the return value.
d7f29f8e 4716
3b95a6f9
MR
47172012-02-04 Martin Rudalics <rudalics@gmx.at>
4718
4719 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4720 after rounding frame sizes. (Bug#9723)
4721
d6fa96a6
EZ
47222012-02-04 Eli Zaretskii <eliz@gnu.org>
4723
4724 * keyboard.c (adjust_point_for_property): Don't position point
4725 before BEGV. (Bug#10696)
4726
df0b2940
PE
47272012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4728
4729 Handle overflow when computing char display width (Bug#9496).
4730 * character.c (char_width): Return EMACS_INT, not int.
4731 (char_width, c_string_width): Check for overflow when
4732 computing the width; this is possible now that individual
4733 characters can have unbounded width. Problem introduced
4734 by merge from Emacs 23 on 2012-01-19.
4735
6bee44d6
MA
47362012-02-02 Michael Albinus <michael.albinus@gmx.de>
4737
4738 * dbusbind.c (Fdbus_register_method): Mention the return value
4739 :ignore in the docstring.
4740
44f92739
GM
47412012-02-02 Glenn Morris <rgm@gnu.org>
4742
1b9f60cc
GM
4743 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4744
44f92739
GM
4745 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4746 Unconditionally set to t. (Bug#10673)
4747 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4748 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4749 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4750
c5d3843c
KH
47512012-02-02 Kenichi Handa <handa@m17n.org>
4752
4753 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4754 0, do not call append_composite_glyph.
4755
159462d4 47562012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4757
4758 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4759 NULL (Bug#6988).
4760 (x_produce_glyphs): If the component of a composition is a null
4761 string, set it->pixel_width to 1 to avoid zero-width glyph.
4762
78cef877
EZ
47632012-02-01 Eli Zaretskii <eliz@gnu.org>
4764
4765 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4766 first 2 arguments are identical. This makes inserting large
4767 output from a subprocess an order of magnitude faster on
4768 MS-Windows, where all sbrk'ed memory is always contiguous.
4769
97897668
GM
47702012-01-31 Glenn Morris <rgm@gnu.org>
4771
4772 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4773 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4774 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4775
31fd3586
GM
47762012-01-29 Glenn Morris <rgm@gnu.org>
4777
4778 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4779
0e24a8b2
CY
47802012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4781
4782 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4783
cc0adcb0
CY
47842012-01-28 Chong Yidong <cyd@gnu.org>
4785
4786 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4787
acc28cb9
CY
47882012-01-26 Chong Yidong <cyd@gnu.org>
4789
9c69cfb7
CY
4790 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4791
acc28cb9
CY
4792 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4793 repeat counts (Bug#10507).
4794
48da7392
GM
47952012-01-26 Glenn Morris <rgm@gnu.org>
4796
4797 * lread.c (syms_of_lread): Doc fix.
4798
14af5f7f
CY
47992012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4800
4801 * coding.c (encode_designation_at_bol): Change return value to
4802 EMACS_INT.
4803
0b21c100
CY
48042012-01-25 Chong Yidong <cyd@gnu.org>
4805
4806 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4807
3c2907f7
CY
48082012-01-21 Chong Yidong <cyd@gnu.org>
4809
4810 * floatfns.c (Fcopysign): Make the second argument non-optional,
4811 since nil is not allowed anyway.
4812
959ad23f
AS
48132012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4814
4815 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4816 (send_process): Likewise.
4817
34a02f46
MR
48182012-01-19 Martin Rudalics <rudalics@gmx.at>
4819
4820 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4821 (Vwindow_persistent_parameters): Do not use Qstate.
4822 Rewrite doc-strings.
34a02f46 4823
1259009a 48242012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4825
4826 * character.c (char_width): New function.
70d4fdf6
GM
4827 (Fchar_width, c_string_width, lisp_string_width):
4828 Use char_width (Bug#9496).
25ed9e61 4829
6a6ee00d
MR
48302012-01-16 Martin Rudalics <rudalics@gmx.at>
4831
4832 * window.c (Vwindow_persistent_parameters): New variable.
4833 (Fset_window_configuration, save_window_save): Handle persistent
4834 window parameters.
4835
c85efaf7
EZ
48362012-01-14 Eli Zaretskii <eliz@gnu.org>
4837
4838 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4839 thrashing the stack of the thread. (Bug#9087)
4840
5944709e
PE
48412012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4842
4843 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4844
e71f5d99
EZ
48452012-01-11 Eli Zaretskii <eliz@gnu.org>
4846
4847 * xdisp.c (rows_from_pos_range): Handle the case where the
4848 highlight ends on a newline. (Bug#10464)
4849 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4850 he end column for display of highlight that ends on a newline
4851 before a R2L line.
4852
ce316182
GM
48532012-01-11 Glenn Morris <rgm@gnu.org>
4854
4855 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4856 from load-path also when installation-directory is nil. (Bug#10208)
4857
5b43da69
GM
48582012-01-10 Glenn Morris <rgm@gnu.org>
4859
74cc8ff9
GM
4860 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4861
7d8d6e4e
GM
4862 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4863 Update template values to be closer to their typical values these days.
5b43da69 4864
a0db8d43
EZ
48652012-01-09 Eli Zaretskii <eliz@gnu.org>
4866
4867 * xdisp.c (rows_from_pos_range): Accept additional argument
4868 DISP_STRING, and accept any glyph in a row whose object is that
4869 string as eligible for mouse highlight. Fixes mouse highlight of
4870 display strings from overlays. (Bug#10464)
4871
9a0115ab 48722012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4873
b9110d6a 4874 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4875 * fileio.c (auto_saving_dir_umask): New static var.
4876 (Fmake_directory_internal): Use it.
4877 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4878 creating the directory. The old code temporarily assigns
4879 too-generous permissions to the directory.
4880 (do_auto_save_eh): Clear it.
b9110d6a 4881 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4882 that the var is always cleared.
4883
6c1bd3f3
EZ
48842012-01-07 Eli Zaretskii <eliz@gnu.org>
4885
4886 * search.c (scan_buffer): Pass character positions to
4887 know_region_cache, not byte positions. (Bug#6540)
4888
069d2b50
L
48892012-01-07 LynX <_LynX@bk.ru> (tiny change)
4890
4891 * w32.c (sys_rename): Report EXDEV when rename of a directory
4892 fails because the target is on another logical disk. (Bug#10284)
4893
75bf0d33
DB
48942012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4895
4896 * xterm.c (x_embed_request_focus): New function.
4897
4898 * xterm.h: Add prototype.
4899
4900 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4901
1c6e5a32
GM
49022012-01-05 Glenn Morris <rgm@gnu.org>
4903
4904 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4905
651e947e
EZ
49062012-01-01 Eli Zaretskii <eliz@gnu.org>
4907
4908 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4909 Load gnutls_transport_set_lowat only if GnuTLS version is below
4910 2.11.1.
4911 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4912 GnuTLS versions below 2.11.1.
4913
3778cdd8
AL
49142011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4915
4916 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4917 to the doc string advising against its use for altering the way
4918 windows are scrolled.
4919
0e5317f7
KH
49202011-12-28 Kenichi Handa <handa@m17n.org>
4921
4922 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4923 coding-system ASCII compatible only when it does not produce BOM
4924 on encoding (Bug#10383).
4925
93d5ca1f
JD
49262011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4927
4928 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4929 can scroll.
4930 (create_and_show_popup_menu): Always use menu_position_func for
4931 Gtk3 (Bug#10361).
4932
ca22b785
AS
49332011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4934
4935 * callint.c (Fcall_interactively): Don't truncate prompt string.
4936
d048e1e6
EZ
49372011-12-23 Eli Zaretskii <eliz@gnu.org>
4938
4939 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4940 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4941 resumed from there (after widening). (Bug#10360)
d048e1e6 4942
5ccaba1f
JD
49432011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4944
4945 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4946
204ee57f
JD
49472011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4948
b81d40f0
JB
4949 * nsterm.m (x_free_frame_resources):
4950 Release f->output_data.ns->miniimage.
204ee57f
JD
4951 (ns_index_color): Fix indentation. Do not retain
4952 color_table->colors[i].
4953
4954 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4955 before returning.
4956
4957 * nsfns.m (x_set_background_color): Assign return value from
4958 ns_index_color to face-background instead of NSColor*.
4959 (ns_implicitly_set_icon_type): Fix indentation.
4960 Change assignment in for loop to comparison.
4961
4962 * emacs.c (ns_pool): New variable.
4963 (main): Assign ns_pool.
4964 (Fkill_emacs): Call ns_release_autorelease_pool.
4965
4966 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4967 autorelease fdesc, release fdAttrs and tdict.
4968 (ns_get_covering_families): Release charset.
4969 (ns_findfonts): Release NSFontDescriptor created with new.
4970 (ns_uni_to_glyphs): Fix indentation.
4971 (setString): Release attrStr before assigning new value.
4972
c803b2b7
JD
49732011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4974
678f4426
JD
4975 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4976 and NS_IMPL_COCOA.
4977 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4978 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4979
cd394be1 49802011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4981
5fecd5fc
JD
4982 * nsterm.m (ns_term_init): Subscribe for notifications
4983 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4984 to method trackingNotification in EmacsMenu.
4985
4986 * nsmenu.m (trackingMenu): New variable.
3771cb17 4987 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4988 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4989 from Aquamacs (Bug#7030).
678f4426
JD
4990
49912011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4992
c803b2b7
JD
4993 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4994 (symbol_to_nsstring): Fix indentation.
4995 (ns_symbol_to_pb): New function.
cae07000
SM
4996 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4997 (Fns_rotate_cut_buffers_internal): Remove.
4998 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4999 Fns_store_cut_buffer_internal.
5000 (ns_get_foreign_selection, Fx_own_selection_internal)
5001 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5002 (Fns_get_selection_internal, Fns_store_selection_internal):
5003 Use ns_symbol_to_pb and check if return value is nil.
5004 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5005 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5006 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5007 renamed to Sns_store_selection_internal.
5008 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5009 and remove this function.
5010 (ns_handle_selection_clear): Remove, never used.
5011 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5012 here.
5013
e1b01a3a
KB
50142011-12-17 Ken Brown <kbrown@cornell.edu>
5015
5016 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5017 GID is unknown (Bug#10257).
5018
2adb6e85
PE
50192011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5020
5021 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5022 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5023 which caused a build failure on GNU/Linux IA-64. This problem was
5024 introduced by my 2011-10-07 patch.
5025
d1d7b339
JL
50262011-12-15 Juri Linkov <juri@jurta.org>
5027
5028 * image.c (imagemagick_error): New function. (Bug#10112)
5029 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5030 Use `imagemagick_error' where ImageMagick functions return
5031 `MagickFalse'.
5032 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5033 proper order.
5034
100d5755
KH
50352011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5036
5037 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5038 fill background (Bug#8992).
5039
454592a6
MR
50402011-12-13 Martin Rudalics <rudalics@gmx.at>
5041
5042 * window.c (Vwindow_combination_resize)
5043 (Vwindow_combination_limit): Use t instead of non-nil in
5044 doc-strings.
61d4b438
MR
5045 (Vrecenter_redisplay): Add first sentence of doc-string on
5046 separate line.
53524d93 5047 (Frecenter): Fix doc-string typo.
454592a6 5048
3633e3aa
KH
50492011-12-11 Kenichi Handa <handa@m17n.org>
5050
5051 * coding.c (Funencodable_char_position): Pay attention to the
5052 buffer text relocation (Bug#9389).
5053
7b9d523a 50542011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5055
7b9d523a
JD
5056 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5057 gtk_init (Bug#10100).
5058
b73189c6
EZ
50592011-12-10 Eli Zaretskii <eliz@gnu.org>
5060
5061 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5062 IT->string is nil. (Bug#10263)
5063
f7dfe5d6
JD
50642011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5065
83faebb4
JD
5066 * nsterm.h (x_free_frame_resources): Declare.
5067
f7dfe5d6
JD
5068 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5069 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5070
5071 * nsterm.h (ns_get_defaults_value): Declare.
5072
5073 * nsterm.m (ns_default): Call ns_get_defaults_value.
5074
7cd4e72c
EZ
50752011-12-09 Eli Zaretskii <eliz@gnu.org>
5076
5077 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5078 (Bug#10170)
5079
b34d7317
YM
50802011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5081
5082 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5083 that where the value of an _OBJC_* symbol points to is in the .bss
5084 section (Bug#10240).
5085
76470ad1
KH
50862011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5087
5088 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5089 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5090
745fff94
KH
50912011-12-08 Kenichi Handa <handa@m17n.org>
5092
5093 * ftfont.c (get_adstyle_property): Fix previous change
5094 (Bug#10233).
5095
6e44397c
JB
50962011-12-07 Juanma Barranquero <lekktu@gmail.com>
5097
5098 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5099 dirs from the default value of EMACSLOADPATH (bug#10208).
5100
7efa6272
GM
51012011-12-07 Glenn Morris <rgm@gnu.org>
5102
5103 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5104 installation and source directories as well. (Bug#10208)
5105
f6fc4d87
CY
51062011-12-06 Chong Yidong <cyd@gnu.org>
5107
5108 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5109
2bf26180
GM
51102011-12-06 Glenn Morris <rgm@gnu.org>
5111
5112 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5113 as an error, not just -1. (Bug#10217)
5114
3a6ad4f0
CY
51152011-12-05 Chong Yidong <cyd@gnu.org>
5116
5117 * keyboard.c (process_special_events): New function.
5118 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5119
75a3b399
PE
51202011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5121
5122 * coding.c (encode_designation_at_bol): Don't use uninitialized
5123 local variable (Bug#9318).
5124
c3c9e25e
KH
51252011-12-05 Kenichi Handa <handa@m17n.org>
5126
5127 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5128 return Qnil (Bug#8046, Bug#10193).
5129
5eb05ea3
KH
51302011-12-05 Kenichi Handa <handa@m17n.org>
5131
5132 * coding.c (encode_designation_at_bol): New args charbuf_end and
5133 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5134 (coding_set_source): Return how many bytes coding->source was
5135 relocated.
5136 (coding_set_destination): Return how many bytes
5137 coding->destination was relocated.
5138 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5139 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5140
51412011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5142
5143 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5144 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5145 macro (Bug#9318).
5146
51472011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5148
5149 The following changes are to fix Bug#9318.
5150
a79703f5 5151 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5152 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5153 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5154 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5155
7dbda6df
JB
51562011-12-05 Juanma Barranquero <lekktu@gmail.com>
5157
5158 * lisp.h (process_quit_flag): Fix external declaration.
5159
6d5eb5b0
SM
51602011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5161
5162 Don't macro-inline non-performance-critical code.
5163 * eval.c (process_quit_flag): New function.
5164 * lisp.h (QUIT): Use it.
5165
a0c3fad0
JD
51662011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5167
5168 * nsfns.m (get_geometry_from_preferences): New function.
5169 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5170
6c07aac2
AS
51712011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5172
5173 * emacs.c (Qkill_emacs): Define.
5174 (syms_of_emacs): Initialize it.
5175 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5176 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5177 (quit_throw_to_read_char): Add parameter `from_signal'.
5178 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5179 * lisp.h (QUIT): Call Fkill_emacs if requested.
5180
c052ead4
JD
51812011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5182
5183 * widget.c (update_wm_hints): Return if wmshell is null.
5184 (widget_update_wm_size_hints): New function.
5185
5186 * widget.h (widget_update_wm_size_hints): Declare.
5187
5188 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5189 widget_update_wm_size_hints (Bug#10104).
5190
9e49252b
EZ
51912011-12-03 Eli Zaretskii <eliz@gnu.org>
5192
5193 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5194 before a newline, prepare the bidi iterator for consuming the
5195 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5196 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5197
02b16839
JL
51982011-12-02 Juri Linkov <juri@jurta.org>
5199
5200 * search.c (Fword_search_regexp): New Lisp function created from
5201 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5202 (Fword_search_backward, Fword_search_forward)
5203 (Fword_search_backward_lax, Fword_search_forward_lax):
5204 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5205 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5206
0068070e
SM
52072011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5208
5209 * fileio.c (Finsert_file_contents): Move after-change-function call
5210 to before the "handled:" label, since all "goto handled" appear in
5211 cases where the *-change-functions have already been properly called
5212 (bug#10117).
5213
3360a3fc
AS
52142011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5215
5216 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5217 waiting for input. (Bug#10169)
5218
73d6c093
EZ
52192011-11-30 Eli Zaretskii <eliz@gnu.org>
5220
5221 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5222 verifies glyph row's hash code--we have just reallocated the
5223 glyphs, so their contents can be complete garbage. (Bug#10164)
5224
febe6bea
JB
52252011-11-30 Juanma Barranquero <lekktu@gmail.com>
5226
5227 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5228
801a4313
EZ
52292011-11-30 Eli Zaretskii <eliz@gnu.org>
5230
5231 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5232 attributes are tested _before_ calling verify_row_hash, to protect
5233 against GCC re-ordering of the tests. (Bug#10164)
5234
2b56b87e
JD
52352011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5236
5237 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5238
5239 * xterm.c (handle_one_xevent): Only set async_visible and friends
5240 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5241 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5242 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5243
dbf31225
PE
52442011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5245
5246 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5247 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5248 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5249 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5250 All uses changed to use GCPRO1 etc.
5251 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5252 Revert to old implementation (i.e., before 2011-03-11).
5253
1305621b
YM
52542011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5255
5256 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5257 of scroll runs so as to avoid assigning disabled bogus rows and
5258 unnecessary graphics copy operations.
5259
8c9afb46
EZ
52602011-11-27 Eli Zaretskii <eliz@gnu.org>
5261
5262 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5263 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5264 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5265 (malloc, free, realloc, calloc): Redirect to e_* only when
5266 compiling Emacs.
5267
5268 * lisp.h (GCTYPEBITS): Move before first use.
5269 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5270 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5271 this macro definition.
5272
5273 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5274 _MSC_VER.
5275
54e9e3bf
JD
52762011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5277
6d5eb5b0
SM
5278 * gtkutil.c (xg_create_frame_widgets):
5279 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5280 present with Gtk+ 2.0.
5281
83aca1cb
PE
52822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5283
5284 * fileio.c (Finsert_file_contents): Undo previous change; see
5285 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5286
5b76caa4
PE
52872011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5288
5289 Rename locals to avoid shadowing.
5290 * fileio.c (Finsert_file_contents):
5291 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5292 * process.c (wait_reading_process_output):
5293 Rename inner 'proc' to 'p' to avoid shadowing.
5294 Indent for consistency with usual Emacs style.
5295
8c535114
EZ
52962011-11-25 Eli Zaretskii <eliz@gnu.org>
5297
5298 * xdisp.c (redisplay_window): If cursor row is not fully visible
5299 after recentering, and scroll-conservatively is set to a large
5300 number, scroll window by a few more lines to make the cursor fully
5301 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5302 (start_display): Don't move to the next line if the display should
5303 start at a newline that is part of a display vector or an overlay
5304 string. (Bug#10119)
8c535114 5305
fa4fdb5c
JL
53062011-11-24 Juri Linkov <juri@jurta.org>
5307
5308 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5309 after the `MagickPingImage' call. (Bug#10112)
5310
90ec88df
CY
53112011-11-23 Chong Yidong <cyd@gnu.org>
5312
5313 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5314
56e2e794
MR
53152011-11-23 Martin Rudalics <rudalics@gmx.at>
5316
5317 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5318 making another buffer current. (Bug#10114)
5319
b6e64c41
GM
53202011-11-23 Glenn Morris <rgm@gnu.org>
5321
5322 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5323
6b21de18
CY
53242011-11-23 Chong Yidong <cyd@gnu.org>
5325
5326 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5327 using it (Bug#5984).
5328
b12cd789
EZ
53292011-11-22 Eli Zaretskii <eliz@gnu.org>
5330
5331 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5332 and header-lines, as they don't have one computed for them.
5333 (Bug#10098)
5334
5335 * .gdbinit (prow): Make displayed values more self-explaining.
5336 Add row's hash code.
5337
261b6fd4
LMI
53382011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5339
5340 * process.c (wait_reading_process_output): Fix asynchrounous
5341 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5342 (wait_reading_process_output): Add comment and URL.
261b6fd4 5343
e7cfd277
JD
53442011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5345
5346 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5347
a9b9b7f5
CY
53482011-11-21 Chong Yidong <cyd@gnu.org>
5349
5350 * window.c (Fnext_window, Fprevious_window): Doc fix.
5351
b0d15b4f
SM
53522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5353
5354 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5355
fe7a3057
JB
53562011-11-20 Juanma Barranquero <lekktu@gmail.com>
5357
5358 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5359
d2999b1a
MR
53602011-11-20 Martin Rudalics <rudalics@gmx.at>
5361
5362 * window.c (Fset_window_combination_limit): Rename argument
5363 STATUS to LIMIT.
5364 (Vwindow_combination_limit): Remove "status" from doc-string.
5365
d5ff9cd0
AS
53662011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5367
5368 * m/ibms390.h: Remove.
5369 * m/ibms390x.h: Don't include "ibms390.h".
5370
a5bb9bd3
SM
53712011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5372
5373 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5374 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5375
cd1181db
JB
53762011-11-20 Juanma Barranquero <lekktu@gmail.com>
5377
5378 * casetab.c (Fset_case_table):
5379 * charset.c (Fcharset_after): Fix typos.
5380
615a3b8d 53812011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5382
17e845af
PE
5383 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5384 Otherwise, valgrind does not work on some platforms.
5385 Problem reported by Andreas Schwab in
6a0bf43d
PE
5386 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5387 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5388 is set, removing the need for VIRT_ADDRESS_VARIES.
5389 (PURE_P): Use a more-efficient implementation that needs just one
5390 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5391 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5392 to 4 (xorl, subq, cmpq, setbe).
5393 * alloc.c (pure): Always extern now, since that's the
5394 VIRT_ADDR_VARIES behavior.
5395 (PURE_POINTER_P): Use a single comparison, not two, for
5396 consistency with the new puresize.h.
5397 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5398 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5399 Remove VIRT_ADDR_VARIES no longer needed.
5400
f8fe6f96
EZ
54012011-11-19 Eli Zaretskii <eliz@gnu.org>
5402
5403 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5404 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5405 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5406 behave as if the cursor position were at the window margin.
5407
5408 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5409 and the cursor position is out of bounds, behave as if the cursor
5410 position were at the window margin. (Bug#10075)
5411
df05a53c
CY
54122011-11-18 Chong Yidong <cyd@gnu.org>
5413
5414 * window.c (Fwindow_combination_limit): Make first argument
5415 non-optional, since it is meaningless for live windows like the
5416 selected window.
61ccba97 5417
2071918e
DA
54182011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5419
5420 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5421
b50a28de
SM
54222011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5423
5424 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5425 (graft_intervals_into_buffer): Simplify.
5426
015137db
EZ
54272011-11-18 Eli Zaretskii <eliz@gnu.org>
5428
5429 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5430 hash values of the two rows.
5431 (copy_row_except_pointers): Preserve the used[] arrays and the
5432 hash values of the two rows. (Bug#10035)
68c95424 5433 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5434
5435 * xdisp.c (row_hash): New function, body extracted from
5436 compute_line_metrics.
5437 (compute_line_metrics): Call row_hash, instead of computing the
5438 hash code inline.
5439
5440 * dispnew.c (verify_row_hash): Call row_hash for computing the
5441 hash code of a row, instead of duplicating code from xdisp.c.
5442
5443 * dispextern.h (row_hash): Add prototype.
5444
a2addb04
TH
54452011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5446
5447 * frame.c (delete_frame): Don't delete the terminal when the last
5448 X frame is closed if emacs is built with GTK toolkit.
5449
df85d315
JB
54502011-11-17 Juanma Barranquero <lekktu@gmail.com>
5451
5452 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5453
a0c2d0ae
MR
54542011-11-17 Martin Rudalics <rudalics@gmx.at>
5455
5456 * window.c (Vwindow_splits): Rename to
5457 Vwindow_combination_resize. Suggested by Juri Linkov.
5458 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5459 of Vwindow_splits.
5460
58179cce
JB
54612011-11-16 Juanma Barranquero <lekktu@gmail.com>
5462
7877f373
JB
5463 * nsfns.m (Fns_font_name):
5464 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5465
b6f67890
MR
54662011-11-16 Martin Rudalics <rudalics@gmx.at>
5467
5468 * window.h (window): Rename slot "nest" to "combination_limit".
5469 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5470 (Fset_window_nest): Rename to Fset_window_combination_limit.
5471 (Vwindow_nest): Rename to Vwindow_combination_limit.
5472 (recombine_windows, make_parent_window, make_window)
5473 (Fsplit_window_internal, saved_window)
5474 (Fset_window_configuration, save_window_save): Rename all
5475 occurrences of window_nest to window_combination_limit.
5476
c7015153
JB
54772011-11-15 Juanma Barranquero <lekktu@gmail.com>
5478
5479 * image.c (imagemagick_load_image): Fix typo.
5480
322ad6ec
EZ
54812011-11-14 Eli Zaretskii <eliz@gnu.org>
5482
5483 * xdisp.c (display_line): Move the call to
5484 highlight_trailing_whitespace before the call to
5485 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5486 faces of all the glyphs to compute ROW's hash value.
5487 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5488
f067b8ec
JB
54892011-11-14 Juanma Barranquero <lekktu@gmail.com>
5490
5491 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5492 just return (bug#10044).
5493
1e5b2111
EZ
54942011-11-12 Eli Zaretskii <eliz@gnu.org>
5495
7ef3cbd5
EZ
5496 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5497 with user-defined heap size. Bump the default size of the temacs
5498 heap to 27MB, to avoid memory warning when running temacs.
5499 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5500
1e5b2111
EZ
5501 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5502 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5503 (verify_row_hash) [XASSERTS]: New function.
5504 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5505 that the hash value of glyph rows is correct.
1e5b2111 5506
89d61221
MR
55072011-11-12 Martin Rudalics <rudalics@gmx.at>
5508
5509 * window.h (window): Remove splits slot.
5510 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5511 (Fdelete_other_windows_internal, make_parent_window)
5512 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5513 (Fset_window_configuration, save_window_save): Don't deal with
5514 split status of windows.
5515 (saved_window): Remove splits slot.
5516 (Vwindow_splits): Rewrite doc-string.
5517
97f18cc8
JD
55182011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5519
5520 * xfns.c (unwind_create_frame):
5521 * nsfns.m (unwind_create_frame):
5522 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5523 Vframe_list (Bug#9999).
5524
22a648b4
DA
55252011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5526
0b381c7e 5527 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5528
659afede
KH
55292011-11-11 Kenichi Handa <handa@m17n.org>
5530
5531 * callproc.c (Fcall_process): Set the member dst_multibyte of
5532 process_coding.
5533
9ac0394b
KH
55342011-11-11 Johan Bockgård <bojohan@gnu.org>
5535
5536 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5537 avoid a crash (bug#9496).
5538
2fbdc249
CY
55392011-11-09 Chong Yidong <cyd@gnu.org>
5540
5541 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5542 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5543
ac6b1f81
PE
55442011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5545
5546 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5547
09db192c
PE
55482011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5549
5550 Avoid some portability problems by eschewing 'extern inline' functions.
5551 The trivial performance wins aren't worth the portability hassles; see
5552 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5553 et seq.
5554 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5555 (window_box_width, window_box_left, window_box_left_offset)
5556 (window_box_right, window_box_right_offset): Undo previous change,
5557 by removing the "extern"s.
5558 * intervals.c (adjust_intervals_for_insertion)
5559 (adjust_intervals_for_deletion): Undo previous change,
5560 making these static again.
5561 (offset_intervals, temp_set_point_both, temp_set_point)
5562 (copy_intervals_to_string): No longer inline.
5563 * xdisp.c (window_text_bottom_y, window_box_width)
5564 (window_box_height, window_box_left_offset)
5565 (window_box_right_offset, window_box_left, window_box_right)
5566 (window_box): No longer inline.
5567
105216ed
CY
55682011-11-08 Chong Yidong <cyd@gnu.org>
5569
5570 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5571 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5572 Signal an error if not a live window.
105216ed
CY
5573 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5574 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5575
ae9e237f
JB
55762011-11-07 Juanma Barranquero <lekktu@gmail.com>
5577
5578 * lisp.h (syms_of_abbrev): Remove declaration.
5579 Reported by CHENG Gao <chenggao@royau.me>.
5580
c7aa8333
EZ
55812011-11-07 Eli Zaretskii <eliz@gnu.org>
5582
5583 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5584 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5585 of temacs in GUI mode.
5586
be7f5545
MR
55872011-11-07 Martin Rudalics <rudalics@gmx.at>
5588
5589 * window.h: Declare delete_all_child_windows instead of
5590 delete_all_subwindows.
5591 * window.c (Fwindow_nest, Fset_window_nest)
5592 (Fset_window_new_total, Fset_window_new_normal)
5593 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5594 (delete_all_subwindows): Rename to delete_all_child_windows.
5595 (Fdelete_other_windows_internal, Fset_window_configuration):
5596 Call delete_all_child_windows instead of delete_all_subwindows.
5597 * frame.c (delete_frame): Call delete_all_child_windows instead
5598 of delete_all_subwindows.
5599
ca78dc43
PE
56002011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5601
5602 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5603 This is also needed for porting to any host where GC_MARK_STACK is
5604 not GC_MAKE_GCPROS_NOOPS.
5605 (which_symbols): Use it.
5606
a0241d01
KH
56072011-11-07 Kenichi Handa <handa@m17n.org>
5608
5609 * coding.c (coding_set_destination): Check coding->src_pos only
5610 when coding->src_object is a buffer (bug#9910).
5611
5612 * process.c (send_process): Set the member src_multibyte of coding
5613 to 0 (bug#9911) when sending a unibyte text.
5614
5615 * callproc.c (Fcall_process): Set the member src_multibyte of
5616 process_coding to 0 (bug#9912).
5617
a64bfdfa 56182011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5619
5620 * xmenu.c (cleanup_widget_value_tree): New function.
5621 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5622 calling free_menubar_widget_value_tree directly (Bug#9830).
5623
cb41b32a
PE
56242011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5625
5626 Fix some portability problems with 'inline'.
5627 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5628 (window_box_width, window_box_left, window_box_left_offset)
5629 (window_box_right, window_box_right_offset): Declare extern.
5630 Otherwise, these inline functions do not conform to C99 and
5631 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5632 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5633 * intervals.c (adjust_intervals_for_insertion)
5634 (adjust_intervals_for_deletion): Now extern, because otherwise the
5635 extern inline functions 'offset_intervals' couldn't refer to it.
5636 (static_offset_intervals): Remove.
5637 (offset_intervals): Rewrite using the old contents of
5638 static_offset_intervals. The old version didn't conform to C99
5639 because an extern inline function contained a reference to an
5640 identifier with static linkage.
5641
b7041366
AS
56422011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5643
5644 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5645 GC.
5646
88a37c4d
EZ
56472011-11-06 Eli Zaretskii <eliz@gnu.org>
5648
5649 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5650 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5651 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5652 return Qleft_to_right.
5653
49745b39
CY
56542011-11-06 Chong Yidong <cyd@gnu.org>
5655
5656 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5657 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5658 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5659 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5660 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5661 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5662 (Fwindow_vscroll): Doc fix.
5663 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5664 argument, since it makes no sense to pass a live window and for
5665 consistency with window-child.
5666
1f05cd82
CS
56672011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5668
5669 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5670 support MSVC.
5671
22610910
JR
56722011-11-05 Jason Rumney <jasonr@gnu.org>
5673
5674 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5675 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5676 fonts (Bug#6029).
5677 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5678 bitwise arithmetic preventing use of unicode-sip and non-truetype
5679 opentype fonts.
5680
a06776b2
EZ
56812011-11-05 Eli Zaretskii <eliz@gnu.org>
5682
3ad924ba
EZ
5683 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5684 "emacs"-only part.
5685
a06776b2
EZ
5686 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5687 initialization code to keep similarity to xfns.c after changes
5688 from 2011-11-05.
5689
c9e7db78
JD
56902011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5691
a97f8f3f
JD
5692 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5693 (unwind_create_frame): New function (Bug#9943).
5694 (Fx_create_frame): Restructure code to be more similar to the one in
5695 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5696 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5697 Move terminal->reference_count++ just before making the frame official
5698 (Bug#9943).
5699
5700 * nsterm.m (x_free_frame_resources): New function.
5701 (x_destroy_window): Move code to x_free_frame_resources.
5702
c9e7db78 5703 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5704 (Fx_create_frame, x_create_tip_frame):
5705 Move terminal->reference_count++ just before making the frame
75f1671a 5706 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5707 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5708
a6fc3b5c
EZ
57092011-11-05 Eli Zaretskii <eliz@gnu.org>
5710
5711 Support MSVC build with newer versions of Visual Studio.
5712 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5713 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5714 nt/gmake.defs.
5715
5716 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5717 which are not supported by MSVC.
5718 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5719 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5720 bitfields.
5721 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5722 types in bitfields.
5723 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5724
5725 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5726
58179cce 57272011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5728
5729 Support MSVC build with newer versions of Visual Studio.
5730 * w32.c: Don't include w32api.h for MSVC.
5731 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5732
5733 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5734 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5735 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5736 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5737 e_* cousins.
5738 (alloca) [_MSC_VER]: Define to _alloca.
5739
5740 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5741
5742 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5743
a58c13ed
EZ
57442011-11-04 Eli Zaretskii <eliz@gnu.org>
5745
5746 * xdisp.c (note_mouse_highlight): If either of
5747 previous/next-single-property-change returns nil, treat that as
5748 the beginning or the end of the buffer. (Bug#9955)
5749
fe0b6370
JD
57502011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5751
a58c13ed 5752 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5753 label is not null (Bug#9951).
5754 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5755 may be NULL.
5756
89bd5ee1
EZ
57572011-11-04 Eli Zaretskii <eliz@gnu.org>
5758
5759 * window.c (Fwindow_body_size): Mention in the doc string that the
5760 return value is in frame's canonical units. (Bug#9949)
5761
84c3edb9
EZ
57622011-11-03 Eli Zaretskii <eliz@gnu.org>
5763
4e2fb5c7
EZ
5764 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5765
84c3edb9 5766 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5767 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5768 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5769
bc17a887
EZ
57702011-11-01 Eli Zaretskii <eliz@gnu.org>
5771
5772 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5773 Don't stop backward scan on the continuation glyph, even though
5774 its CHARPOS is positive.
6d5eb5b0
SM
5775 (mouse_face_from_buffer_pos, note_mouse_highlight):
5776 Rename cover_string to disp_string.
bc17a887 5777
4ee88440
MR
57782011-11-01 Martin Rudalics <rudalics@gmx.at>
5779
5780 * window.c (temp_output_buffer_show): Don't use
5781 Vtemp_buffer_show_specifiers.
5782 (Vtemp_buffer_show_specifiers): Remove unused variable.
5783
c2ff3c02
EZ
57842011-10-30 Eli Zaretskii <eliz@gnu.org>
5785
5786 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5787 past the beginning of the current glyph matrix.
5788
58179cce 57892011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5790
5791 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5792 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5793 HAVE_GTK3 (Bug#9869).
b77a6a7f 5794
3b574623
JD
5795 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5796 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5797
b77a6a7f
JD
5798 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5799
5800 * xterm.c: Declare x_handle_net_wm_state to return int.
5801 (handle_one_xevent): Check if we are iconified but don't have
5802 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5803 (get_current_wm_state): Return non-zero if not hidden,
5804 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5805 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5806 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5807 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5808
196e41e4
PE
58092011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5810
5811 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5812 so that this new function doesn't get optimized away by a
5813 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5814
021f2e1a
AS
58152011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5816
5817 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5818
8b058d44
EZ
58192011-10-29 Eli Zaretskii <eliz@gnu.org>
5820
5821 Fix the `xbytecode' command.
5822 * .gdbinit (xprintbytestr): New command.
b50a28de 5823 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5824 (xbytecode): Print the byte-code string as well.
5825
4452fb80
EZ
58262011-10-29 Kim Storm <storm@cua.dk>
5827
8b058d44
EZ
5828 * alloc.c (which_symbols): New function.
5829
21b72067
AS
58302011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5831
5832 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5833 line. (Bug#9903)
5834
83ed7b5c
GM
58352011-10-29 Glenn Morris <rgm@gnu.org>
5836
5837 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5838 Not clear what it was for, and it causes various bugs. (Bug#9839)
5839
5a7a728b
EZ
58402011-10-28 Eli Zaretskii <eliz@gnu.org>
5841
5842 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5843 possible random value that matches one of those tested as
5844 condition to clear the mouse face.
5845
d3d0842f
CY
58462011-10-28 Chong Yidong <cyd@gnu.org>
5847
5848 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5849
31b39d13
DN
58502011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5851
5852 * window.c (make_window): Initialize phys_cursor_on_p.
5853
9aba6043
SM
58542011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5855
5856 * lisp.h (struct Lisp_Symbol): Update comments.
5857
c20992f4
JB
58582011-10-28 Juanma Barranquero <lekktu@gmail.com>
5859
5860 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5861
db4f02f2
EZ
58622011-10-28 Eli Zaretskii <eliz@gnu.org>
5863
5864 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5865 <oslsachem@gmail.com> for helping to debug this.
5866
5867 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5868 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5869 (g_b_init_get_glyph_outline_w): New static variables.
5870 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5871 (GetGlyphOutlineW_Proc): New typedefs.
5872 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5873 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5874 New functions.
5875 (w32font_open_internal, compute_metrics):
5876 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5877 instead of calling the "wide" APIs directly.
5878
5879 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5880
5881 * w32.h (syms_of_w32font): Add prototype.
5882
87e68db4
JB
58832011-10-27 Juanma Barranquero <lekktu@gmail.com>
5884
5885 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5886 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5887 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5888 (Fmove_to_window_line): Doc fix.
5889
435c1d67
CY
58902011-10-27 Chong Yidong <cyd@gnu.org>
5891
5892 * process.c (make_process): Set gnutls_state to NULL.
5893
5894 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5895 non-NULL, regardless of GNUTLS_INITSTAGE.
5896 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5897 an error. Set process slots as soon as we allocate them.
5898
5899 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5900
9c6c6f49
CY
59012011-10-27 Chong Yidong <cyd@gnu.org>
5902
9aba6043
SM
5903 * gnutls.c (emacs_gnutls_deinit): New function.
5904 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5905 (Fgnutls_deinit, Fgnutls_boot): Use it.
5906
5907 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5908 (deactivate_process): Call emacs_gnutls_deinit.
5909
657d08d3
JB
59102011-10-27 Juanma Barranquero <lekktu@gmail.com>
5911
5912 * image.c (x_create_x_image_and_pixmap):
5913 * w32.c (sys_rename, w32_delayed_load):
5914 * w32font.c (fill_in_logfont):
5915 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5916
5430d399
JB
59172011-10-26 Juanma Barranquero <lekktu@gmail.com>
5918
5919 * w32fns.c (w32_default_color_map): New function,
5920 extracted from Fw32_default_color_map.
a7ef684b 5921 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5922
fe0055fa
PE
59232011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5926
e6346438
SM
59272011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5928
5929 * keyboard.c (test_undefined): New function (bug#9751).
5930 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5931
e112cc37
ET
59322011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5933
5934 * sysdep.c (init_sys_modes): Fix the check for the controlling
5935 terminal (Bug#6649).
5936
7b5d6677
EZ
59372011-10-20 Eli Zaretskii <eliz@gnu.org>
5938
5939 * dispextern.h (struct bidi_it): New member next_en_type.
5940
5941 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5942 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5943 current character, check also for next_en_type being WEAK_EN.
5944 (bidi_resolve_weak): Don't enter the expensive loop if the current
5945 position is before next_en_pos. Record the bidi type of the first
5946 non-ET, non-BN character we find, in addition to its position.
5947 (bidi_level_of_next_char): Invalidate next_en_type when
5948 next_en_pos is over-stepped.
5949
7da0b018
PE
59502011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5951
5952 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5953 * editfns.c: Rewrite current-time-zone so that it invokes
5954 the equivalent of (format-time-string "%Z") to get the time zone name.
5955 This fixes a bug when the time zone name contains characters that
5956 need converting from the system time locale to Emacs internal format.
5957 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5958 that patch fixed format-time-string to do the conversion, but
5959 I forgot to fix current-time-zone.
5960 (format_time_string): New function, containing most of
5961 what Fformat_time_string used to contain.
5962 (Fformat_time_string): Rewrite in terms of format_time_string.
5963 This doesn't change this function's behavior.
5964 (current-time-zone): Rewrite to use format_time_string.
5965 This fixes the bug reported by Michael Schierl in
5966 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5967 Jason Rumney's 2007-06-07 change worked around this bug, but
5968 didn't fix it.
5969 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5970
8547b010
EZ
59712011-10-19 Eli Zaretskii <eliz@gnu.org>
5972
5973 * xdisp.c (start_display): If the character at POS is displayed
5974 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5975 (try_window_reusing_current_matrix): If a line ends in a display
5976 vector or the next line starts in a display vector, continue
5977 redrawing the window even though the character position of
5978 start_row was reached.
8547b010
EZ
5979 (Bug#9771, part 2)
5980
4e948d15
CY
59812011-10-18 Chong Yidong <cyd@gnu.org>
5982
5983 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5984 with nobreak-char-display too.
5985
4787455f
EZ
59862011-10-18 Eli Zaretskii <eliz@gnu.org>
5987
5988 Fix part 3 of bug#9771.
5989 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5990 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5991 non-neutral characters if the current character is a paragraph
5992 separator (a.k.a. Newline). This avoids running the same
5993 expensive loop twice, once when we consume the preceding newline
5994 and the other time when the line actually needs to be displayed.
5995 Avoid the loop when we see neutrals on the base embedding level
5996 following a character whose directionality is the same as the
5997 paragraph's. This avoids running the expensive loop when a line
5998 ends in a long sequence of neutrals, like control characters.
5999 Add assertion against STRONG_AL type. Slightly rearrange code
6000 that determines the type of a neutral given the first non-neutral
6001 that follows it.
6002 (bidi_level_of_next_char): Set next_en_pos to zero when
6003 invalidating its info.
6004
2c91f553
EZ
60052011-10-17 Eli Zaretskii <eliz@gnu.org>
6006
6007 * xdisp.c (push_display_prop): Determine whether to record string
6008 or buffer position by IT->string, not by IT->method. Allow
6009 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6010 (move_it_vertically_backward): Don't look for character position
6011 immediately after the newline when in a continuation line.
6012 (Bug#9771, part 1)
2c91f553 6013
c7b08b0d
MR
60142011-10-15 Martin Rudalics <rudalics@gmx.at>
6015
6016 * window.c (coordinates_in_window): Rewrite and delabelize
6017 vertical border check. (Bug#5357) (Bug#9618)
6018
6b02f655
SM
60192011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6020
6021 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6022 errors in XSetWindowBorder (bug#9310).
6023
81d40c92
DA
60242011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6025
6026 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6027 avoid crash when xmalloc overrun checking is enabled.
6028
d4172c3b
EZ
60292011-10-13 Eli Zaretskii <eliz@gnu.org>
6030
6031 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6032 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6033 cursor motion with <left> and <right> arrow keys.
6034
6035 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6036 some callers set that themselves.
6037
b00eea75
EZ
60382011-10-12 Eli Zaretskii <eliz@gnu.org>
6039
6040 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6041 display string and the previous row comes from the same string and
6042 is empty. (Bug#9739) (Bug#9738)
6043
8fe012c4
SM
60442011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6045
6046 * doc.c (get_doc_string): Encode file name (bug#9735).
6047
0074aef2
EZ
60482011-10-12 Eli Zaretskii <eliz@gnu.org>
6049
79beb178
EZ
6050 * bidi.c (bidi_level_of_next_char):
6051 * xdisp.c (get_visually_first_element): Remove old incorrect
6052 comments regarding the Unicode Line Separator character.
6053
0074aef2
EZ
6054 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6055
6e4b3fbe
DA
60562011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6057
6058 * alloc.c (Fgc_status): Do not access beyond zombies array
6059 boundary if nzombies > MAX_ZOMBIES.
6060 * alloc.c (dump_zombies): Add missing format specifier.
6061
0324f3af
PE
60622011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6063
b5525cac
PE
6064 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6065 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6066
0324f3af
PE
6067 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6068 Some packages use them to denote characters with modifiers.
6069
e9b5f888
AS
60702011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6071
6072 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6073 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6074 matching a pp-number. Rename parameter var to var1.
6075
127827c0
SM
60762011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6077
6078 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6079
c8fd3bd0
GM
60802011-10-08 Glenn Morris <rgm@gnu.org>
6081
6082 * callint.c (Fcall_interactively): Give a more explicit error for the
6083 'c' case with a non-character input. (Bug#8479)
6084
352ec8ff
EZ
60852011-10-08 Eli Zaretskii <eliz@gnu.org>
6086
03669ccb
EZ
6087 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6088 lines.
7061c986
EZ
6089 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6090 lines that are hscrolled on the left.
03669ccb 6091
352ec8ff
EZ
6092 * dispnew.c (buffer_posn_from_coords): Account for a possible
6093 presence of header-line. (Bug#4426)
6094
a66cfb1c
SM
60952011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6096
6b02f655
SM
6097 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6098 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6099
7c5ee88e
PE
61002011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6101
6102 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6103 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6104 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6105 this makes Emacs dump core during garbage collection on rare
6106 occasions. sizeof is obviously inferior to offsetof here, so
6107 stick with offsetof.
6108 (GC_POINTER_ALIGNMENT): New macro.
6109 (mark_memory): Omit 3rd (offset) arg; caller changed.
6110 Don't assume EMACS_INT alignment is the same as pointer alignment.
6111
df1bbe5b
SM
61122011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6113
6114 * keyboard.c (read_key_sequence_remapped): New var.
6115 (read_key_sequence): Compute remapping in the right buffer.
6116 (command_loop_1): Use read_key_sequence's remapping directly.
6117
51553db6
SM
61182011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6119
32c1fffd
SM
6120 * dired.c (file_name_completion): Don't expand file name.
6121 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6122 before checking file name handler.
6123
51553db6
SM
6124 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6125 they've been requested explicitly (bug#9591).
6126
b6bd1599 61272011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6128
6129 * keymap.c (Fsingle_key_description): Use make_specified_string
6130 instead of build_string to build string from push_key_description.
6131 (Bug#5193)
6132
f701dc2a
PE
61332011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6134
4222c55d
PE
6135 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6136 This fixes a Y2038 bug on 64-bit hosts.
6137 * buffer.c (reset_buffer):
6138 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6139 (Fclear_buffer_auto_save_failure):
6140 Use 0, not -1, to represent an unset failure time, since time_t
6141 might not be signed.
6142
f701dc2a
PE
6143 Remove dependency on glibc malloc internals.
6144 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6145 Move back here from lisp.h, but with their new implementations.
6146 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6147 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6148 * charset.c (charset_table_init): New static var.
6149 (syms_of_charset): Use it instead of xmalloc. This removes a
6150 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6151 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6152 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6153 Move back to alloc.c.
6154 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6155 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6156
9ceebf39
JD
61572011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6158
6159 * nsterm.m (windowDidResize): Call x_set_window_size only when
6160 ns_in_resize is true. Otherwise set pixelwidth/height and
6161 call change_frame_size (Bug#9628).
6162
cb993c58
PE
61632011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6164
3930c88b
PE
6165 Port --enable-checking=all to Fedora 14 x86-64.
6166 * charset.c (syms_of_charset): Also account for glibc malloc's
6167 internal overhead when calculating the initial malloc maximum.
6168
cb993c58
PE
6169 Port --enable-checking=all to Fedora 14 x86.
6170 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6171 Move to lisp.h.
6172 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6173 (overrun_check_realloc, overrun_check_free):
6174 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6175 That way, xmalloc returns a properly-aligned pointer even if
6176 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6177 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6178 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6179 into account when calculating the initial malloc maximum.
6180 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6181 Move here from alloc.c, so that charset.c can use it too.
6182 Properly align; the old code wasn't right for common 32-bit hosts
6183 when configured with --enable-checking=all.
6184 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6185 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6186
31bed486
EZ
61872011-09-29 Eli Zaretskii <eliz@gnu.org>
6188
04c70788 6189 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6190 use EDOM.
6191
fbcaa2f3
EZ
61922011-09-28 Eli Zaretskii <eliz@gnu.org>
6193
6194 * xdisp.c (compute_display_string_end): If there's no display
6195 string at CHARPOS, return -1.
6196
6197 * bidi.c (bidi_fetch_char): When compute_display_string_end
6198 returns a negative value, treat the character as a normal
6199 character not covered by a display string. (Bug#9624)
6200
a239d4e9
JB
62012011-09-28 Juanma Barranquero <lekktu@gmail.com>
6202
6203 * lread.c (Fread_from_string): Fix typo in docstring.
6204
88652fd5
EZ
62052011-09-27 Eli Zaretskii <eliz@gnu.org>
6206
6207 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6208 newline, reseat the iterator instead of bidi-iterating there one
6209 character at a time. (Bug#9610)
32c1fffd
SM
6210 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6211 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6212
ed497dd4
AS
62132011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6214
6215 * lread.c (readevalloop): Use correct code for NBSP.
6216 (read1): Likewise. (Bug#9608)
6217
b2bf61aa
MA
62182011-09-25 Michael Albinus <michael.albinus@gmx.de>
6219
6220 * dbusbind.c (Fdbus_register_signal): When service is not
6221 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6222
32bbb17c
GM
62232011-09-25 Glenn Morris <rgm@gnu.org>
6224
6225 * buffer.c (truncate-lines): Doc fix.
6226
94e0933e
CY
62272011-09-24 Chong Yidong <cyd@stupidchicken.com>
6228
6229 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6230 (Fset_window_next_buffers): Doc fix.
6231
cddde921
GM
62322011-09-24 Glenn Morris <rgm@gnu.org>
6233
6234 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6235
1260aef1
PE
62362011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6237
25b4bfa0
PE
6238 Fix minor problems found by static checking.
6239 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6240 * indent.c (Fvertical_motion): Fix == vs = typo.
6241
e3cbd34b
EZ
62422011-09-24 Eli Zaretskii <eliz@gnu.org>
6243
a66cfb1c
SM
6244 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6245 Default value is now t. Doc fix.
6bf7006f 6246
e3cbd34b 6247 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6248 logic when moving up, not only when moving down. Fix the
e3cbd34b 6249 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6250 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6251
6252 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6253 CHARPOS is covered by a display string which includes newlines.
6254 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6255 is covered by a display string with embedded newlines.
6256
a3de0cbd
MA
62572011-09-24 Michael Albinus <michael.albinus@gmx.de>
6258
6259 * dbusbind.c (Fdbus_register_signal): Add match rule to
6260 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6261 (Fdbus_register_method, Vdbus_registered_objects_table):
6262 Fix docstring.
a3de0cbd 6263
b260039d
JM
62642011-09-24 Jim Meyering <meyering@redhat.com>
6265
32c1fffd 6266 do not ignore write error for any output size
b260039d
JM
6267 The previous change was incomplete.
6268 While it makes emacs --batch detect the vast majority of stdout
6269 write failures, errors were still ignored whenever the output size is
6270 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6271 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6272 && echo FAIL: ignored write error
6273 FAIL: ignored write error
6274 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6275 && echo FAIL: ignored write error
6276 FAIL: ignored write error
6277 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6278
8eca8a7c
AS
62792011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6280
6281 * emacs.c (Fkill_emacs): In noninteractive mode exit
6282 non-successfully if a write error occurred on stdout. (Bug#9574)
6283
3341db62
EZ
62842011-09-21 Eli Zaretskii <eliz@gnu.org>
6285
6286 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6287 the xassert test.
6288
6289 * dispextern.h (struct it): Update the comment documenting what
6290 can it->OBJECT be.
6291
8c203dbf
EZ
62922011-09-20 Eli Zaretskii <eliz@gnu.org>
6293
6294 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6295 a display string, extend search for cursor position to end of row.
6296 (find_row_edges): If the row ends in a newline from a display
6297 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6298 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6299 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6300 non-empty line. Fixes confusing cursor motion with arrow keys at
6301 the beginning of a line that starts with whitespace.
8c203dbf 6302
a4824228
LMI
63032011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6304
6305 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6306 (bug#9493).
6307
33ed493b
CY
63082011-09-18 Chong Yidong <cyd@stupidchicken.com>
6309
6310 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6311 boolean (Bug#9154).
6312
56cd55c8
EZ
63132011-09-18 Eli Zaretskii <eliz@gnu.org>
6314
6315 * xdisp.c (display_line): Record maximum and minimum buffer
6316 positions even if no glyphs were produced (e.g., by a zero-width
6317 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6318 buffer positions that will be removed from the glyph row because
6319 they don't fit.
c02dcedf
EZ
6320 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6321 column is beyond frame width: don't subtract 1 "pixel" when
6322 computing width of the stretch.
3e62b7e0
EZ
6323 (reseat_at_next_visible_line_start): Undo the change made on
6324 2011-09-17 that saved paragraph information and restored it after
6325 the call to `reseat'. (Bug#9545)
56cd55c8 6326
5ed99d36 63272011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6328
6329 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6330 and turn window cursor on if cleared (Bug#9415).
6331
5ed99d36 63322011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6333
6334 * search.c (boyer_moore): Take unibyte characters from pattern
6335 literally. (Bug#9458)
6336
9bade7b2
EZ
63372011-09-18 Eli Zaretskii <eliz@gnu.org>
6338
6339 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6340
e5e9d610
PE
63412011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6342
87e4427a
PE
6343 Fix minor problem found by static checking.
6344 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6345 initialized, to pacify gcc -Wuninitialized.
6346
e5e9d610
PE
6347 * fileio.c: Report proper errno when syscall falls.
6348 (Finsert_file_contents): Save and restore errno,
6349 so that report_file_error outputs the correct diagnostic.
6350 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6351
a1674f0b
EZ
63522011-09-18 Eli Zaretskii <eliz@gnu.org>
6353
6354 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6355
fbfb6dd4
EZ
63562011-09-17 Eli Zaretskii <eliz@gnu.org>
6357
6358 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6359 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6360
bb187662
EZ
63612011-09-17 Eli Zaretskii <eliz@gnu.org>
6362
1137e8b8 6363 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6364 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6365
6366 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6367 (bidi_find_paragraph_start): Search back for paragraph beginning
6368 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6369 (bidi_move_to_visually_next): Only trigger paragraph-related
6370 computations when the last character is a newline or at EOB, not
6371 just any NEUTRAL_B. (Bug#9470)
6372
bb187662
EZ
6373 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6374 truncated lines if point is covered by a display string. (Bug#9524)
6375
2e621251
PE
63762011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6377
6378 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6379 (cons_to_x_long): New function.
6380 (lisp_data_to_selection_data): Use it. Correct the test for
6381 short-versus-long data; it was negated. Break out of vector
6382 loop, for efficiency, when a long datum is discovered.
6383
91a15bc6
SM
63842011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6385
6386 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6387
b41c3a35
EZ
63882011-09-16 Eli Zaretskii <eliz@gnu.org>
6389
6390 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6391 GCC PR/17406) by declaring this function with external scope.
6392
7812ba2d
PE
63932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6394
6395 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6396 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6397
cf7edc2a
AS
63982011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6399
6400 * editfns.c (Fformat): Correctly handle text properties on "%%".
6401
bd01620e
EZ
64022011-09-15 Eli Zaretskii <eliz@gnu.org>
6403
6404 * xterm.c (x_draw_composite_glyph_string_foreground):
6405 * w32term.c (x_draw_composite_glyph_string_foreground):
6406 * term.c (encode_terminal_code):
6407 * composite.c (composition_update_it, get_composition_id):
6408 * xdisp.c (get_next_display_element)
6409 (fill_composite_glyph_string): Add comments about special meaning
6410 of TAB characters in a composition.
6411
a02719a3
PE
64122011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6413
6414 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6415 This occurs when processing a multibyte format.
6416 Problem reported by Wolfgang Jenker.
a02719a3 6417
72589a3c
JB
64182011-09-15 Johan Bockgård <bojohan@gnu.org>
6419
6420 * xdisp.c (try_cursor_movement): Only check for exact match if
6421 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6422
1c14176c
PE
64232011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6424
6425 Remove unused external symbols.
6426 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6427 * xdisp.c (calc_pixel_width_or_height): Now static.
6428 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6429 * indent.c (check_display_width):
6430 * w32term.c: Fix comment to match code.
6431 * xterm.c, xterm.h (x_catching_errors): Remove.
6432
d2eea5b5
PE
64332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6434
6435 * xselect.c: Use signed conversions more consistently (Bug#9498).
6436 (selection_data_to_lisp_data): Assume incoming selection data are
6437 signed integers, not unsigned. This is to be consistent with
6438 outgoing selection data, which was modified to use signed integers
6439 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6440 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6441 expects long, not unsigned long.
6442
46888499
EZ
64432011-09-14 Eli Zaretskii <eliz@gnu.org>
6444
6445 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6446 computation of loop end. Reported by Johan Bockgård
6447 <bojohan@gnu.org>.
6448
ef8ef9fb
CY
64492011-09-13 Chong Yidong <cyd@stupidchicken.com>
6450
6451 * frame.c (Fother_visible_frames_p): Function deleted.
6452
fa819fed
EZ
64532011-09-12 Eli Zaretskii <eliz@gnu.org>
6454
6455 * indent.c (compute_motion): Process display vector front to back
6456 rather than the other way around. (Bug#2496)
6457
2ba8e008
SM
64582011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6459
6460 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6461
20f53c69
CY
64622011-09-11 Chong Yidong <cyd@stupidchicken.com>
6463
6464 * minibuf.c (Fread_from_minibuffer): Doc fix.
6465
d562d7a4
EZ
64662011-09-11 Eli Zaretskii <eliz@gnu.org>
6467
6468 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6469 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6470
1c4d7f3d
LMI
64712011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6472
6473 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6474 value for non-existent files.
6475
b885bf36
EZ
64762011-09-11 Eli Zaretskii <eliz@gnu.org>
6477
6478 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6479 set its "size" to -1. This will set the modtime_size field of
6480 the corresponding buffer to -1, which is what
6481 verify-visited-file-modtime expects for files that do not exist.
6482 (Bug#9139)
6483
6612f0bf
PE
64842011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6485
6486 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6487 here ...
6488 * lisp.h: ... from here. push_key_description is no longer
6489 defined in keyboard.c, so its declaration should not be in
6490 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6491 logically belongs with push_key_description.
6492
dfb3f755
PE
64932011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6494
6495 * buffer.h: Include <sys/types.h> instead of <time.h>.
6496 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6497 Problem reported by Herbert J. Skuhra.
6498
3134906c
LMI
64992011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6500
6501 * xml.c (parse_region): Make the parsing work for
6502 non-comment-starting XML files again (bug#9144).
6503
8d903f4e
AS
65042011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6505
6506 * image.c (gif_load): Fix calculation of bottom and right corner.
6507 (Bug#9468)
6508
80ad64f4
EZ
65092011-09-10 Eli Zaretskii <eliz@gnu.org>
6510
6511 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6512 redisplay in small windows.
6513
208a048d
EZ
65142011-09-09 Eli Zaretskii <eliz@gnu.org>
6515
6516 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6517
9b1c252e
MR
65182011-09-08 Martin Rudalics <rudalics@gmx.at>
6519
6520 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6521 Operate on live windows only.
6522
2949f33b
JB
65232011-09-08 Juanma Barranquero <lekktu@gmail.com>
6524
6525 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6526
e08dcafd
EZ
65272011-09-07 Eli Zaretskii <eliz@gnu.org>
6528
6529 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6530 only under bidi iteration.
6531
115b96bd
JD
65322011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6533
6534 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6535
c8199d0f
PE
65362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6537
6538 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6539 Without this fix, the command to link temacs failed due to an
6540 undefined symbol __builtin_isnan. This is because
6541 /usr/include/iso/math_c99.h #defines isnan(x) to
6542 __builtin_isnan(x), but the bundled gcc, which identifies itself
6543 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6544 a __builtin_isnan.
6545 * floatfns.c (isnan): #undef, and then #define to a clone of
6546 what's in data.c.
6547 (Fisnan): Always define, since it's always available now.
6548 (syms_of_floatfns): Always define isnan at the Lisp level.
6549
e39b275c 65502011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6551
6552 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6553
b2db44d9 65542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6555
f4af5137 6556 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6557 The previous code assumed that file offsets (off_t values) fit in
6558 EMACS_INT variables, which is not true on typical 32-bit hosts.
6559 The code messed up by falsely reporting buffer overflow in cases
6560 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6561 when "big" contains more than 2**29 bytes, even though this
6562 inserts just one byte and does not overflow the buffer.
6563 (Finsert_file_contents): Store file offsets as off_t
6564 values, not as EMACS_INT values. Check for overflow when
6565 converting between EMACS_INT and off_t. When checking for
6566 buffer overflow or for overlap, take the offsets into account.
6567 Don't use EMACS_INT for small values where int suffices.
6568 When checking for overlap, fix a typo: ZV was used where
6569 ZV_BYTE was intended.
6570 (Fwrite_region): Don't assume off_t fits into 'long'.
6571 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6572
ecfc0a49
MA
65732011-09-05 Michael Albinus <michael.albinus@gmx.de>
6574
6575 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6576
6511acf2 65772011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6578
0999621a 6579 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6580
6581 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6582 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6583 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6584 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6585 (modify_event_symbol): Do not assume that the length of
6586 name_alist_or_stem is safe to alloca and fits in int.
6587 (Fexecute_extended_command): Likewise for function name and binding.
6588 (Frecursion_depth): Wrap around reliably on integer overflow.
6589 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6590 since some callers pass EMACS_INT values.
6591 (Fsingle_key_description): Don't crash if symbol name contains more
6592 than MAX_ALLOCA bytes.
6593 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6594 (get_minibuffer): Arg is now EMACS_INT, not int.
6595 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6596 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6597 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6598
2be7d702
PE
6599 * dbusbind.c (signature_cat): New function.
6600 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6601 Do not overrun buffer; instead, report string overflow.
6602
9d1df220
PE
6603 * dispnew.c (add_window_display_history): Don't overrun buffer.
6604 Truncate instead; this is OK since it's just a log.
6605
33ef5c64
PE
6606 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6607 even if the time zone offset is outlandishly large.
6608 Don't mishandle offset == INT_MIN.
6609
66c6fdd5
PE
6610 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6611 when creating daemon; the previous buffer-overflow check was incorrect.
6612
d749b01b
PE
6613 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6614 which has the guts of the old verror function.
6615
b5cd1905
PE
6616 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6617 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6618
6e1a67fb
PE
6619 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6620 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6621 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6622 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6623 length of string rather than counting it via multiple sprintfs;
6624 that's simpler and more reliable.
c21721cc
PE
6625 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6626 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6627 sprintf, in case result does not fit in int.
6628
c57b67fc
PE
6629 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6630 (fontset_from_font): Print it.
6631
8a401434
PE
6632 * frame.c (tty_frame_count): Now printmax_t, not int.
6633 (make_terminal_frame, set_term_frame_name): Print it.
6634 (x_report_frame_params): In X, window IDs are unsigned long,
6635 not signed long, so print them as unsigned.
6636 (validate_x_resource_name): Check for implausibly long names,
6637 and don't assume name length fits in 'int'.
6638 (x_get_resource_string): Don't blindly alloca invocation name;
6639 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6640 not fit in int.
6641
6e1a67fb
PE
6642 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6643 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6644 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6645
0df02bf3
PE
6646 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6647 Use esprintf, not sprintf, in case result does not fit in int.
6648
48e30793
PE
6649 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6650 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6651 it as a large positive number.
6652 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6653 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6654
a66ff6d8
PE
6655 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6656 in case result does not fit in int.
6657
aca216ff
PE
6658 * print.c (float_to_string): Detect width overflow more reliably.
6659 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6660 buffer overrun. Don't assume list length fits in 'int'. Treat
6661 print length of 0 as 0, not as infinity; to be consistent with other
6662 uses of print length in this function. Don't overflow print length
6663 index. Don't assume hash table size fits in 'long', or that
6664 vectorlike size fits in 'unsigned long'.
6665
31c286f7
PE
6666 * process.c (make_process): Use printmax_t, not int, to format
6667 process-name gensyms.
6668
55e5faa1
PE
6669 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6670
80f2e268
PE
6671 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6672 to avoid potential buffer overrun.
6673
670741ab
PE
6674 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6675 if X resource line is longer than 512 bytes.
6676
b7163a50
PE
6677 * xfns.c (x_window): Make sprintf buffer a bit bigger
6678 to avoid potential buffer overrun.
6679
ae58ff1f
PE
6680 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6681
c43c8a6a
PE
6682 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6683
3f8236f4
PE
66842011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6685
53e9fe90 6686 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6687 Without these, Emacs silently mishandles large integers sometimes.
6688 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6689 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6690
6511acf2
PE
6691 * xdisp.c (try_window_id): Check Emacs fixnum range before
6692 converting to 'int'.
806add1d 6693
6511acf2 6694 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6695 Check that an Emacs fixnum is in range before assigning it to 'int'.
6696 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6697 values converted from Emacs fixnums.
6698 (Frecenter): Don't wrap around a line count if it is out of 'int'
6699 range; instead, treat it as an extreme value.
6700 (Fset_window_configuration, compare_window_configurations):
6701 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6702
6511acf2
PE
6703 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6704 that can exceed INT_MAX. Check that EMACS_INT value is in range
6705 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6706 (match_limit): Don't assume that a fixnum can fit in 'int'.
6707
6511acf2 6708 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6709 exceed INT_MAX.
6710
6511acf2 6711 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6712 (Fvertical_motion): Don't wrap around LINES values that don't fit
6713 in 'int'. Instead, treat them as extreme values. This is good
6714 enough for windows, which can't have more than INT_MAX lines anyway.
6715
fcb901a7
LMI
67162011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6717
0f2f6b6d
LMI
6718 * Require libxml/parser.h to avoid compilation warning.
6719
fcb901a7
LMI
6720 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6721
6722 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6723 since this reportedly can destroy thread storage.
6724
6e20a0d4
CY
67252011-08-30 Chong Yidong <cyd@stupidchicken.com>
6726
6727 * syntax.c (find_defun_start): Update all cache variables if
6728 exiting early (Bug#9401).
6729
148ae00e
EZ
67302011-08-30 Eli Zaretskii <eliz@gnu.org>
6731
f6cfbd8f
EZ
6732 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6733
148ae00e
EZ
6734 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6735 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6736 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6737
6738 * term.c (tty_append_glyph): New function.
6739 (produce_stretch_glyph): Static function and its prototype deleted.
6740
a66cfb1c
SM
6741 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6742 Add prototypes.
148ae00e 6743
c4a07a4c
PE
67442011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6745
6746 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6747 when checking :margin (Bug#9390).
6748 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6749 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6750 so that the name doesn't mislead. All uses changed.
6751
6bc8cd65
JB
67522011-08-28 Johan Bockgård <bojohan@gnu.org>
6753
6754 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6755 set_tty_hooks.
6756
dca4927e
EZ
67572011-08-27 Eli Zaretskii <eliz@gnu.org>
6758
6759 * xdisp.c (move_it_to): Don't bail out early when reaching
6760 position beyond to_charpos, if we are scanning backwards.
6761 (move_it_vertically_backward): When DY == 0, make sure we get to
6762 the first character in the line after the newline.
6763
f2cad773
PE
67642011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6765
6766 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6767 (ccl_driver): Do not generate an out-of-range pointer.
6768 (Fccl_execute_on_string): Remove unnecessary check for
6769 integer overflow, noted by Stefan Monnier in
6770 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6771 Remove a FIXME that didn't need fixing.
6772 Simplify the newly-introduced buffer reallocation code.
6773
0cae2cdb
JB
67742011-08-27 Juanma Barranquero <lekktu@gmail.com>
6775
6776 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6777
5fc295a4 67782011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6779
70c60eb2 6780 Integer and memory overflow issues (Bug#9196).
726e0ab1 6781
d31850da
PE
6782 * doc.c (get_doc_string): Rework so that
6783 get_doc_string_buffer_size is the actual buffer size, rather than
6784 being 1 less than the actual buffer size; this makes xpalloc more
6785 convenient.
6786
a69fbedb
PE
6787 * image.c (x_allocate_bitmap_record, cache_image):
6788 * xselect.c (Fx_register_dnd_atom):
6789 Simplify previous changes by using xpalloc.
6790
fe5c5d37
PE
6791 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6792 since either will do and ptrdiff_t is convenient with xpalloc.
6793
0065d054
PE
6794 * charset.c (charset_table_size)
6795 (struct charset_sort_data.priority): Now ptrdiff_t.
6796 (charset_compare): Don't overflow if priorities differ greatly.
6797 (Fsort_charsets): Don't assume list length fits in int.
6798 Check for size-calculation overflow when allocating sort data.
6799 (syms_of_charset): Allocate an initial charset table that is
6800 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6801
6802 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6803
6804 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6805 The actual value is always <= INT_MAX, and leaving it unsigned made
6806 overflow checking harder.
6807
6808 * dispextern.h (struct glyph_matrix.rows_allocated)
6809 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6810 with xpalloc. The values are still always <= INT_MAX.
6811
6812 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6813
6814 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6815 (SAFE_NALLOCA): New macro.
6816
6817 * region-cache.c (struct boundary.pos, find_cache_boundary)
6818 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6819 (set_cache_region, invalidate_region_cache)
6820 (revalidate_region_cache, know_region_cache, region_cache_forward)
6821 (region_cache_backward, pp_cache):
6822 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6823 so that ptrdiff_t * can be passed to xpalloc.
6824 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6825 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6826 (pp_cache): Don't assume cache_len fits in int.
6827 * region-cache.h: Adjust extern decls to match.
6828
6829 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6830 EMACS_INT, since either will do, for xpalloc.
6831
6832 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6833 (xnmalloc, xnrealloc, xpalloc): New functions.
6834
726e0ab1
PE
6835 * bidi.c (bidi_shelve_header_size): New constant.
6836 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6837 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6838
51f30bc5 6839 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6840 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6841 (overlay_strings):
6842 Don't update size of array until after memory allocation succeeds,
6843 because xmalloc/xrealloc may not return.
0065d054
PE
6844 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6845 now that we have proper integer overflow checking.
6846 (record_overlay_string, overlay_strings): Catch overflows when
6847 calculating size of overlay_str_buf.
726e0ab1 6848
0065d054
PE
6849 * callproc.c (Fcall_process): Check for size overflow when
6850 calculating size of args2.
6851 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6852 Normally we prefer signed values, but sticking with ptrdiff_t would
6853 require adding more-complicated checks.
726e0ab1
PE
6854
6855 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6856 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6857 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6858 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6859
6860 * character.c (Fstring): Check for size-calculation overflow.
6861
6862 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6863 unnecessary integer overflow. Check for size overflow.
6864 (encode_coding_object): Don't update size until xmalloc succeeds.
6865
6866 * composite.c (get_composition_id): Check for overflow in glyph
6867 length calculations.
6868
6869 Integer and memory overflow fixes for display code.
6870 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6871 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6872 (scrolling_window): Check for overflow in size calculations.
6873 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6874 Don't assume glyph table len fits in int.
6875 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6876 (row_table_size): Now ptrdiff_t, not int.
6877 (scrolling_window): Avoid overflow in size calculations.
6878 Don't update size until allocation succeeds.
6879 * fns.c (concat): Check for overflow in size calculations.
6880 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6881 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6882 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6883
6884 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6885 (get_doc_string): Check for size calculation overflow.
6886 Don't update size until allocation succeeds.
6887 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6888 EMACS_INT, where ptrdiff_t will do.
6889 (Fsubstitute_command_keys): Check for string overflow.
6890
6891 * editfns.c (set_time_zone_rule): Don't assume environment length
6892 fits in int.
6893 (message_length): Now ptrdiff_t, not int.
6894 (Fmessage_box): Don't update size until allocation succeeds.
6895 Don't assume message length fits in int.
6896 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6897
0065d054
PE
6898 * emacs.c (main): Do not reallocate argv, since there is a null at
6899 the end that can be overwritten, and this way there's no need to
6900 worry about size-calculation overflow.
6901 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6902
6903 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6904 alloc succeeds.
6905 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6906
6907 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6908 (x_set_scroll_bar_width, x_figure_window_size):
6909 Check for integer overflow.
6910 (x_set_alpha): Do not assume XINT fits in int.
6911
6912 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6913 This is for the members text_lines, text_cols, total_lines, total_cols,
6914 where the system imposes an 'int' limit.
6915
6916 * fringe.c (Fdefine_fringe_bitmap):
6917 Don't update size until alloc works.
6918
6919 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6920 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6921
6922 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6923 Check for size-calculation overflow.
6924 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6925 do, as we prefer signed integers.
6926 (id_to_widget.max_size, id_to_widget.used)
6927 (xg_store_widget_in_map, xg_remove_widget_from_map)
6928 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6929 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6930 Use and return ptrdiff_t, not int.
6931 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6932 * gtkutil.h: Change prototypes to match the above.
6933
6934 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6935 are duplicate now that they've been promoted to lisp.h.
6936 (x_allocate_bitmap_record, x_alloc_image_color)
6937 (make_image_cache, cache_image, xpm_load):
6938 Don't update size until alloc is done.
6939 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6940 (x_detect_edges):
3256efce 6941 Check for size calculation overflow.
726e0ab1
PE
6942 (ct_colors_allocated_max): New constant.
6943 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6944 overflow.
3256efce 6945
726e0ab1
PE
6946 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6947 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6948 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6949 Use ptrdiff_t, not int, to count maps.
6950 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6951 calculations. Don't update size until allocation succeeds.
6952 Redo calculations to avoid overflow.
726e0ab1
PE
6953 * keyboard.h: Change prototypes to match the above.
6954
6955 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6956 to count maps.
6957 (current_minor_maps): Check for size calculation overflow.
6958 * keymap.h: Change prototypes to match the above.
6959
6960 * lread.c (read1, init_obarray): Don't update size until alloc done.
6961
6962 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6963 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6964
726e0ab1
PE
6965 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6966 Now ptrdiff_t, not int.
6967 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6968 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6969
6970 * process.c (Fnetwork_interface_list): Check for overflow
6971 in size calculation.
6972
6973 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6974
6975 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6976 overflow. Don't bother calling xmalloc when xrealloc will do.
6977
6978 * search.c (Freplace_match): Check for size calculation overflow.
6979 (Fset_match_data): Don't assume list lengths fit in 'int'.
6980
6981 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6982 for command line length. Do not attempt to address one before the
6983 beginning of an array, as that's not portable.
6984
6985 * term.c (max_frame_lines): Remove; unused.
6986 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6987 not int.
6988 (encode_terminal_code, calculate_costs): Check for size
6989 calculation overflow.
6990 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6991 table lengths and related sizes. Don't update size until alloc
6992 done. Redo calculations to avoid overflow.
6993 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6994
6995 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6996 subtracting pointers.
6997 (gobble_line): Check for overflow more carefully. Don't update size
6998 until alloc done.
6999
7000 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7001 Don't update size until alloc done.
7002 Redo size calculations to avoid overflow.
7003 Check for size calculation overflow.
0065d054 7004 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7005
7006 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7007 Use ptrdiff_t, not int, for sizes.
7008 (store_mode_line_noprop_char): Don't update size until alloc done.
7009
0065d054
PE
7010 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7011 Use ptrdiff_t, not int, for sizes.
7012 (Finternal_make_lisp_face, cache_face):
7013 Check for size calculation overflow.
7014 (cache_face): Treat size calculation overflows as if they were
7015 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7016
7017 * xfns.c (x_encode_text, x_set_name_internal)
7018 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7019 sizes, since they can exceed INT_MAX in size. Check for size
7020 calculation overflow.
7021
0065d054
PE
7022 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7023 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7024 Don't update size until alloc done.
7025
0065d054 7026 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7027 as sprintf is limited to int lengths.
1d526e2f 7028
252c5ee1
PE
7029 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7030 (X_LONG_MIN): New macros.
864d7ce7
PE
7031 Use them to make the following changes clearer.
7032 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7033 This change doesn't affect the value now, but it may help remind
7034 future maintainers not to raise the value too much later.
7035 (SELECTION_QUANTUM): Remove, replacing with ...
7036 (selection_quantum): ... new function, which avoids overflow.
7037 All uses changed.
7038 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7039 assumption that selection length fits in 'int'.
7040 (x_reply_selection_request, x_handle_selection_request)
7041 (x_get_window_property, receive_incremental_selection)
7042 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7043 (lisp_data_to_selection_data, clean_local_selection_data):
7044 Use ptrdiff_t, not int, to record length of selection.
7045 (x_reply_selection_request, x_get_window_property)
7046 (receive_incremental_selection, x_property_data_to_lisp):
7047 Redo calculations to avoid overflow.
7048 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7049 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7050 something.
7051 (x_get_window_property, receive_incremental_selection)
7052 (lisp_data_to_selection_data, x_property_data_to_lisp):
7053 Check for size-calculation overflow.
7054 (x_get_window_property, receive_incremental_selection)
7055 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7056 Don't store size until memory allocation succeeds.
7057 (x_get_window_property): Plug memory leak on memory exhaustion.
7058 Don't double-block input; malloc is safe here. Don't assume 2**34
7059 - 4 fits in unsigned long. Add an xassert to check
7060 XGetWindowProperty overflow. Be more careful about overflow
7061 calculations, and distinguish size from memory overflow better.
7062 (receive_incremental_selection): When tracing, don't assume
7063 unsigned int is less than INT_MAX.
7064 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7065 harmful) conversions of unsigned short to int.
7066 (lisp_data_to_selection_data): Don't assume that integers
7067 in the range -65535 through -1 fit in an X unsigned short.
7068 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7069 result parameters unless successful. Rely on cons_to_unsigned
7070 to report problems with elements; the old code wasn't right anyway.
7071 (x_check_property_data): Check for int overflow; we cannot use
7072 a wider type due to X limits.
7073 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7074
726e0ab1 7075 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7076
0065d054
PE
7077 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7078 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7079 (x_color_cells): Don't store size until memory allocation succeeds.
7080 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7081 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7082 (x_term_init): Don't assume length fits in int (sprintf is limited
7083 to int size).
bc18e09d 7084
ebfa62c0
PE
7085 Use ptrdiff_t for composition IDs.
7086 * character.c (lisp_string_width):
7087 * composite.c (composition_table_size, n_compositions)
7088 (get_composition_id, composition_gstring_from_id):
7089 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7090 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7091 * window.c (Frecenter):
7092 Use ptrdiff_t, not int, for composition IDs.
7093 * composite.c (get_composition_id): Check for integer overflow.
7094 * composite.h: Adjust prototypes to match the above changes.
7095
d3411f89
PE
7096 Use ptrdiff_t for hash table indexes.
7097 * category.c (hash_get_category_set):
7098 * ccl.c (ccl_driver):
7099 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7100 * coding.c (coding_system_charset_list, detect_coding_system):
7101 * coding.h (struct coding_system.id):
7102 * composite.c (get_composition_id, gstring_lookup_cache):
7103 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7104 * image.c (xpm_get_color_table_h):
7105 * lisp.h (hash_lookup, hash_put):
7106 * minibuf.c (Ftest_completion):
7107 Use ptrdiff_t for hash table indexes, not int (which is too
7108 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7109 32-bit --with-wide-int hosts).
7110
e097a6fa
PE
7111 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7112 Add a FIXME comment about memory leaks.
7113 (syms_of_charset): Don't assume xmalloc returns.
7114
5637687f
PE
7115 Don't assume that stated character widths fit in int.
7116 * character.c (Fchar_width, c_string_width, lisp_string_width):
7117 * character.h (CHAR_WIDTH):
7118 * indent.c (MULTIBYTE_BYTES_WIDTH):
7119 Use sanitize_char_width to avoid undefined and/or bad behavior
7120 with outlandish widths.
a66cfb1c 7121 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7122 now that we have two such functions. All uses changed.
7123 (sanitize_char_width): New inline function.
7124
a2271ba2
PE
7125 Don't assume that tab-width fits in int.
7126 * character.h (sanitize_width): New inline function.
7127 (SANE_TAB_WIDTH): New macro.
7128 (ASCII_CHAR_WIDTH): Use it.
7129 * indent.c (sane_tab_width): Remove. All uses replaced by
7130 SANE_TAB_WIDTH (current_buffer).
7131 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7132
18c52557
PE
7133 * fileio.c: Integer overflow issues with file modes.
7134 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7135
caeeedc1
PE
7136 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7137 Remove unreachable code.
7138 (read_hex, load_charset_map_from_file): Check for integer overflow.
7139
6df6ae42 7140 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7141 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7142 (x_send_scroll_bar_event): Likewise. Check that the size does not
7143 exceed limits imposed by XClientMessageEvent, as well as the usual
7144 ptrdiff_t and size_t limits.
7145
b13995db
PE
7146 * keyboard.c: Overflow, signedness and related fixes.
7147 (make_lispy_movement): Use same integer type in forward decl
7148 that is used in the definition.
7149 (read_key_sequence, keyremap_step):
7150 Change bufsize argument back to int, undoing my 2011-03-30 change.
7151 We prefer signed types, and int is wide enough here.
7152 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7153 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7154 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7155 length, not size_t. Use ptrdiff_t for index, not int.
7156 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7157 possibility of integer overflow.
7158
13464394
PE
7159 Overflow, signedness and related fixes for images.
7160
7161 * dispextern.h (struct it.stack[0].u.image.image_id)
7162 (struct_it.image_id, struct image.id, struct image_cache.size)
7163 (struct image_cache.used, struct image_cache.ref_count):
7164 * gtkutil.c (update_frame_tool_bar):
7165 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7166 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7167 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7168 * nsmenu.m (update_frame_tool_bar):
7169 * xdisp.c (calc_pixel_width_or_height):
7170 * xfns.c (image_cache_refcount):
7171 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7172 on typical 64-bit hosts.
7173
7174 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7175 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7176 Omit unnecessary casts to int.
7177 (parse_image_spec): Check that integers fall into 'int' range
7178 when the callers expect that.
7179 (image_ascent): Redo ascent calculation to avoid int overflow.
7180 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7181 (lookup_image): Remove unnecessary tests.
7182 (xbm_image_p): Locals are now of int, not EMACS_INT,
7183 since parse_image_check makes sure they fit into int.
7184 (png_load, gif_load, svg_load_image):
7185 Prefer int to unsigned where either will do.
7186 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7187 old tiff_error_handler and tiff_warning_handler.
7188 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7189 stack buffer overflows. It uses only the features of vsnprintf
7190 that are common to both POSIX and native Microsoft.
7191 (tiff_error_handler, tiff_warning_handler): Use it.
7192 (tiff_load, gif_load, imagemagick_load_image):
7193 Don't assume :index value fits in 'int'.
7194 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7195 (imagemagick_load_image): Check that crop parameters fit into
7196 the integer types that MagickCropImage accepts. Don't assume
7197 Vimagemagick_render_type has a nonnegative value. Don't assume
7198 size_t fits in 'long'.
7199 (gs_load): Use printmax_t to print the widest integers possible.
7200 Check for integer overflow when computing image height and width.
7201
c11821d4
EZ
72022011-08-26 Eli Zaretskii <eliz@gnu.org>
7203
7204 * xdisp.c (redisplay_window): Don't force window start if point
7205 will be invisible in the resulting window. (Bug#9324)
7206
0c95fcf7
EZ
72072011-08-25 Eli Zaretskii <eliz@gnu.org>
7208
7209 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7210 the display spec is of the form `(space ...)'.
7211 (handle_display_spec): Return the value returned by
7212 handle_single_display_spec, not just 1 or zero.
7213 (handle_single_display_spec): If the display spec is of the form
7214 `(space ...)', and specifies display in the text area, return 2
7215 rather than 1.
fee65a97 7216 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7217 accurately, and prefer exact match for point under bidi.
7218 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7219
7220 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7221 into disp_prop; all users changed.
7222
7223 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7224 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7225 for the text covered by the display property.
7226
e4ed06f1
CY
72272011-08-25 Chong Yidong <cyd@stupidchicken.com>
7228
7229 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7230 Change return value to nil.
7231 (Frecord_buffer): Delete unused function.
7232
f67cdd7f
EZ
72332011-08-24 Eli Zaretskii <eliz@gnu.org>
7234
5980d4c6
EZ
7235 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7236 buffers, return left-to-right.
8610fe8b
EZ
7237 (set_cursor_from_row): Consider candidate row a win if its glyph
7238 represents a newline and point is on that newline. Fixes cursor
7239 positioning on the newline at EOL of R2L text within L2R
7240 paragraph, and vice versa.
7241 (try_cursor_movement): Check continued rows, in addition to
7242 continuation rows. Fixes unwarranted scroll when point enters a
7243 continued line of R2L text within an L2R paragraph, or vice versa.
7244 (cursor_row_p): Consider the case of point being equal to
7245 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7246 from the end of a short line to the beginning of a continued line
7247 of R2L text within L2R paragraph.
7248 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7249 composed characters.
5980d4c6 7250
f67cdd7f
EZ
7251 * bidi.c (bidi_check_type): Use xassert.
7252 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7253 members.
7254
bca633fb
EZ
72552011-08-23 Eli Zaretskii <eliz@gnu.org>
7256
7257 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7258 a character.
7259
4a5885a7
CY
72602011-08-23 Chong Yidong <cyd@stupidchicken.com>
7261
7262 * nsfont.m (ns_otf_to_script): Fix typo.
7263
0902a04e
KH
72642011-08-22 Kenichi Handa <handa@m17n.org>
7265
7266 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7267 extra slot even if the purpose is char-code-property-table.
7268
1a2e6670
EZ
72692011-08-23 Eli Zaretskii <eliz@gnu.org>
7270
8ddde651
EZ
7271 * xdisp.c (redisplay_window): When computing centering_position,
7272 account for the height of the header line. (Bug#8874)
7273
425cc014
EZ
7274 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7275 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7276 candidate is selected by the mouse, and that candidate has a
7277 composed character under the mouse.
7278
1a2e6670
EZ
7279 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7280 coordinates reported by pos-visible-in-window-p for a composed
7281 character in column zero.
7282
8b76d6f8
SM
72832011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7284
7285 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7286
dac347dd
EZ
72872011-08-22 Eli Zaretskii <eliz@gnu.org>
7288
7289 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7290 consider it a hit if to_charpos is anywhere in the range of the
7291 composed buffer positions.
7292
e013fb34
CY
72932011-08-22 Chong Yidong <cyd@stupidchicken.com>
7294
7295 * image.c (gif_load): Don't assume that each subimage has the same
7296 dimensions as the base image. Handle disposal method that is
7297 "undefined" by the gif spec (Bug#9335).
7298
bd1ba3e8
CY
72992011-08-20 Chong Yidong <cyd@stupidchicken.com>
7300
7301 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7302 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7303
54a1215b
EZ
73042011-08-19 Eli Zaretskii <eliz@gnu.org>
7305
823564e5
EZ
7306 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7307 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7308 from an Org mode buffer to a Speedbar frame.
7309
54a1215b
EZ
7310 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7311 a composition, take its buffer position from IT->cmp_it.charpos.
7312 Fixes cursor positioning at the beginning of a line that begins
7313 with a composed character.
7314
9778ebcc
EZ
73152011-08-18 Eli Zaretskii <eliz@gnu.org>
7316
0be6ee06
EZ
7317 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7318 character bidirectional type, use STRONG_L instead. Fixes crashes
7319 in a buffer produced by `describe-categories'.
7320
9778ebcc
EZ
7321 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7322 members before the level stack, so they would be saved and
7323 restored when copying iterator state. Fixes incorrect reordering
7324 around TABs covered by display properties.
7325
156bffbe
AS
73262011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7327
6b02f655 7328 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7329
72ad093b
CY
73302011-08-17 Chong Yidong <cyd@stupidchicken.com>
7331
7332 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7333 (internal_condition_case_2, internal_condition_case_n):
7334 Remove unnecessary aborts (Bug#9081).
72ad093b 7335
35774242
EZ
73362011-08-17 Eli Zaretskii <eliz@gnu.org>
7337
7338 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7339 has no `load' handler, try opening the file locally. (Bug#9311)
7340
db76dd85
KB
73412011-08-16 Ken Brown <kbrown@cornell.edu>
7342
7343 * gmalloc.c: Expand comment.
7344
b215eee5
EZ
73452011-08-16 Eli Zaretskii <eliz@gnu.org>
7346
7347 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7348 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7349
a4579d33
KB
73502011-08-16 Ken Brown <kbrown@cornell.edu>
7351
7352 Fix memory allocation problems in Cygwin build (Bug#9273).
7353
7354 * unexcw.c ( __malloc_initialized): Declare external variable.
7355 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7356
8b76d6f8
SM
7357 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7358 New variables.
a4579d33
KB
7359 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7360 dumped emacs.
7361 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7362 in the static heap.
7363 [CYGWIN] (special_realloc): New function.
7364 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7365 requests to realloc storage in the static heap.
7366
3ebec551
PE
73672011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7368
7369 * bidi.c (bidi_initialize): Remove unused local.
7370
9fd8be00
EZ
73712011-08-15 Eli Zaretskii <eliz@gnu.org>
7372
6b02f655
SM
7373 * bidimirror.h:
7374 * biditype.h: Remove file.
7375 * makefile.w32-in ($(BLD)/bidi.$(O)):
7376 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7377
7378 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7379
7380 * chartab.c: Improve commentary for the uniprop_table API.
7381
32413314
EZ
7382 * bidi.c (bidi_paragraph_init): Support zero value of
7383 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7384 (bidi_initialize): Use uniprop_table instead of including
7385 biditype.h and bidimirror.h.
32413314 7386
9fd8be00
EZ
7387 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7388 coordinates of the iterator when restoring from ppos_it.
7389 (Bug#9296)
7390
5cf2b69b
KH
73912011-08-14 Kenichi Handa <handa@m17n.org>
7392
7393 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7394 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7395
daf17d00
EZ
73962011-08-14 Eli Zaretskii <eliz@gnu.org>
7397
7398 * xdisp.c (move_it_in_display_line_to): Don't invoke
7399 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7400 ppos_it. Fixes vertical cursor motion when line beginning is
7401 covered by an image. (Bug#9296)
7402
08e3161a
JD
74032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7404
7405 * nsterm.h (ns_run_ascript): Declare.
7406 (NSAPP_DATA2_RUNASSCRIPT): Define.
7407
7408 * nsfns.m (as_script, as_result, as_status): New static variables.
7409 (ns_run_ascript): New function.
5e617bc2 7410 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7411 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7412 the event loop. Get status from as_status (Bug#7276).
7413
7414 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7415 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7416 the event loop (Bug#7276).
7417
a3720aa2
AS
74182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7419
7420 * gnutls.c (QCgnutls_bootprop_priority)
7421 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7422 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7423 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7424 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7425 (QCgnutls_bootprop_verify_hostname_error)
7426 (QCgnutls_bootprop_callbacks_verify): Rename from
7427 Qgnutls_bootprop_..., all uses changed.
7428
7429 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7430 uses changed.
7431
0a0d27fb
PE
74322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7433
19d5c50c
PE
7434 * xfaces.c (Qframe_set_background_mode): Now static.
7435 * dispextern.h (Qframe_set_background_mode): Remove decl.
7436
0a0d27fb
PE
7437 * process.c (Fnetwork_interface_info): Declare local only if needed.
7438
377538cb
JD
74392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7440
7441 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7442 (Fnetwork_interface_list): Allocate in increments of bytes instead
7443 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7444 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7445 sockaddr.
7446 (struct ifflag_def): notrailers is smart on OSX.
7447 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7448 Get hardware address with getifaddrs if available.
7449
08fff70c
EZ
74502011-08-12 Eli Zaretskii <eliz@gnu.org>
7451
7452 * xdisp.c (iterate_out_of_display_property): xassert that
7453 IT->position is set to within IT->object's boundaries. Break from
7454 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7455 when IT->position is set up wrongly due to some bug.
7456 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7457 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7458 entry. Force push_it to save on the stack the current
7459 buffer/string position, to be restored by pop_it. Fix flags in
7460 the iterator structure wrt the object coming from a display
7461 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7462 properties. (Bug#9284)
7463
7be1c708 74642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7465
7be1c708
CY
7466 * fontset.c (fontset_get_font_group): Add proper type checks.
7467 (Bug#9172)
aac0c6e3 7468
7be1c708 74692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7470
7be1c708
CY
7471 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7472 and LC_VERSION_MIN_MACOSX.
7473 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7474 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7475
97bb72a6
EZ
74762011-08-08 Eli Zaretskii <eliz@gnu.org>
7477
7478 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7479 no-display-properties-and-no-overlays under bidi display.
7480 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7481 properties and overlays.
97bb72a6 7482
d5617611
CY
74832011-08-08 Chong Yidong <cyd@stupidchicken.com>
7484
37e11a63
CY
7485 * editfns.c (Fset_time_zone_rule): Document relationship with the
7486 setenv function.
7487
d5617611
CY
7488 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7489 the font entity extracted from the cache (Bug#8109).
7490
58872834
CY
74912011-08-07 Chong Yidong <cyd@stupidchicken.com>
7492
7493 * composite.c (autocmp_chars): Don't reset point. That is done by
7494 restore_point_unwind (Bug#5984).
7495
75bfc667
JL
74962011-08-07 Juri Linkov <juri@jurta.org>
7497
7498 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7499 to show the arg `TIME' instead of `TIMEVAL'.
7500
d1410150
EZ
75012011-08-06 Eli Zaretskii <eliz@gnu.org>
7502
7503 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7504 display property strides EOL and includes a newline, as in
7505 longlines-mode. (Bug#9254)
75b771e4
EZ
7506 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7507 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7508
7509 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7510 is non-zero, even if the data buffer is NULL. Fixes a crash in
7511 vertical-motion with longlines-mode. (Bug#9254)
7512
35928349
EZ
75132011-08-05 Eli Zaretskii <eliz@gnu.org>
7514
ec7cc85b
EZ
7515 * bidi.c <bidi_cache_total_alloc>: Now static.
7516 (bidi_initialize): Initialize bidi_cache_total_alloc.
7517
8b76d6f8 7518 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7519 cache. (Bug#9221)
7520
7521 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7522 amount allocated this far in `bidi_cache_total_alloc'.
7523 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7524 non-zero, only free the data buffer without restoring the cache
7525 contents. All callers changed.
7526
7527 * dispextern.h (bidi_unshelve_cache): Update prototype.
7528
7529 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7530 (move_it_in_display_line, move_it_to)
7531 (move_it_vertically_backward, move_it_by_lines): Replace the call
7532 to xfree to an equivalent call to bidi_unshelve_cache.
7533 (move_it_in_display_line_to): Fix logic of returning
412b6358 7534 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7535
e2e2423b
EZ
75362011-08-05 Eli Zaretskii <eliz@gnu.org>
7537
7538 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7539 came from a string character with a `cursor' property. (Bug#9229)
7540
ae9e757a
JD
75412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7542
7543 * Makefile.in (LIB_PTHREAD): New variable.
7544 (LIBES): Add LIB_PTHREAD (Bug#9216).
7545
7546 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7547 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7548
213bd7f2
AS
75492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7550
6b02f655 7551 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7552
99aaf75f
JD
75532011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7554
7555 * xterm.c (x_find_topmost_parent): New function.
7556 (x_set_frame_alpha): Find topmost parent window with
7557 x_find_topmost_parent and set the property there also (bug#9181).
7558 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7559
c74e9d86
PE
75602011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7561
7562 * callproc.c (Fcall_process): Avoid vfork clobbering
7563 the local vars buffer, coding_systems, current_dir.
7564
640c8776
SM
75652011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7566
7567 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7568
f26d0e4c
PE
75692011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7570
8a10d76c
PE
7571 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7572 so that it is not optimized away.
7573
f26d0e4c
PE
7574 * xdisp.c (compute_display_string_pos): Remove unused local.
7575
55439c61
EZ
75762011-08-02 Eli Zaretskii <eliz@gnu.org>
7577
7578 Fix slow cursor motion and scrolling in large buffers with
7579 selective display, like Org Mode buffers. (Bug#9218)
7580
7581 * dispextern.h (struct bidi_it): New member disp_prop_p.
7582
7583 * xdisp.c: Remove one-slot cache of display string positions.
7584 (compute_display_string_pos): Accept an additional argument
5e617bc2 7585 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7586 for a display string or property. If found, set DISP_PROP_P
7587 non-zero.
7588
7589 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7590 DISP_PROP_P, and pass it to compute_display_string_pos.
7591 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7592 non-zero. All callers of bidi_fetch_char changed.
7593
fb33fa43
SM
75942011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7595
7596 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7597
b099e063
DM
75982010-12-03 Don March <don@ohspite.net>
7599
7600 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7601 last character M-[char] is translated to ESC [char] (bug#7541).
7602
5cc7f7af
KH
76032011-08-02 Kenichi Handa <handa@m17n.org>
7604
d0fffa3f 7605 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7606
7607 * chartab.c (uniprop_table): Make it non-static.
7608
525d5e6e
EZ
76092011-08-01 Eli Zaretskii <eliz@gnu.org>
7610
7611 * xdisp.c (forward_to_next_line_start): Accept additional argument
7612 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7613 on the newline.
7614 (reseat_at_next_visible_line_start): Use the bidi iterator state
7615 returned by forward_to_next_line_start to restore the state of
7616 it->bidi_it after backing up to previous newline. (Bug#9212)
7617
31011111
AS
76182011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7619
7620 * regex.c (re_comp): Protoize.
7621 (re_exec): Fix return type.
7622 (regexec): Fix type of `ret'. (Bug#9203)
7623
476371c4
PE
76242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7625
e5d76069
PE
7626 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7627 This is needed if max-image-size is a floating-point number.
7628
9a79b20c
AS
76292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7630
7631 * print.c (print_object): Print empty symbol as ##.
7632
7633 * lread.c (read1): Read ## as empty symbol.
7634
d8c2fa78
AA
76352011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7636
7637 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7638 setting frame foreground color (Bug#9175).
7639 (x_set_background_color): Likewise.
7640
ffe57a7a
AA
7641 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7642 contents (Bug#9176).
7643 (EmacsTooltip -init): Remove bezels and add shadows to
7644 tooltip windows.
7645
bf3492a5
AA
7646 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7647 or scroll bar (Bug#8470).
7648
d55e9c53
AA
7649 * nsfont.m (nsfont_open): Remove assignment to voffset and
7650 unnecessary vars hshink, expand, hd, full_height, min_height.
7651 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7652
7653 * nsterm.h (nsfont_info): Remove voffset field.
7654
d8c2fa78 76552011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7656
7657 Implement strike-through and overline on NextStep (Bug#8863).
7658
7659 * nsfont.m (nsfont_open): Use underline position provided by font,
7660 instead of hard-coded value of 2.
7661 (nsfont_draw): Call ns_draw_text_decoration instead.
7662
7663 * nsterm.h: Add declaration for ns_draw_text_decoration.
7664
7665 * nsterm.m (ns_draw_text_decoration): New function for drawing
7666 underline, overline, and strike-through.
7667 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7668 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7669 accommodate underlining, etc.
4843aac3 7670
4cc60b9b
EZ
76712011-07-28 Eli Zaretskii <eliz@gnu.org>
7672
bc7ece87
EZ
7673 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7674 default.
4cc60b9b 7675
476371c4
PE
76762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7677
66606eea
PE
7678 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7679 Without this fix, if a signal arrives just after memory fills up,
7680 'malloc' might be invoked reentrantly.
7681
476371c4
PE
7682 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7683 In other words, assume that every image size is allowed, on non-X
7684 hosts. This assumption is probably wrong, but it lets Emacs compile.
7685
f3fcc40d
AS
76862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7687
7688 * regex.c (re_iswctype): Convert return values to boolean.
7689
350c992f
EZ
76902011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7691
7692 * xdisp.c (compute_display_string_pos): Don't use cached display
7693 string position if the buffer had its restriction changed.
7694 (Bug#9184)
7695
5266b4bb
PE
76962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7697
7698 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7699
2573a837 77002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7701
41f55ccd 7702 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7703
39e378da
PE
7704 * bidi.c: Integer size and overflow fixes.
7705 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7706 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7707 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7708 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7709 (bidi_find_other_level_edge):
7710 Use ptrdiff_t instead of EMACS_INT where either will do.
7711 This works better on 32-bit hosts configured --with-wide-int.
7712 (bidi_cache_ensure_space): Check for size-calculation overflow.
7713 Use % rather than repeated addition, for better worst-case speed.
7714 Don't set bidi_cache_size until after xrealloc returns, because it
7715 might not return.
7716 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7717 (bidi_cache_ensure_space): Also check that the bidi cache size
7718 does not exceed that of the largest Lisp string or buffer. See Eli
7719 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7720
5e927815
PE
7721 * alloc.c (__malloc_size_t): Remove.
7722 All uses replaced by size_t. See Andreas Schwab's note
7723 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7724
ca4aa935
PE
7725 * image.c: Improve checking for integer overflow.
7726 (check_image_size): Assume that f is nonnull, since
7727 it is always nonnull in practice. This is one less thing to
7728 worry about when checking for integer overflow later.
7729 (x_check_image_size): New function, which checks for integer
7730 overflow issues inside X.
7731 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7732 This removes the need for a memory_full check.
7733 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7734 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7735 (xbm_read_bitmap_data): Change locals back to 'int', since
7736 their values must fit in 'int'.
7737 (xpm_load_image, png_load, tiff_load):
7738 Invoke x_create_x_image_and_pixmap earlier,
7739 to avoid much needless work if the image is too large.
7740 (tiff_load): Treat overly large images as if
7741 x_create_x_image_and_pixmap failed, not as malloc failures.
7742 (gs_load): Use x_check_image_size.
7743
5f8f9cc2
PE
7744 * gtkutil.c: Omit integer casts.
7745 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7746 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7747
5adf60bc
PE
7748 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7749
c8907a93
PE
7750 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7751 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7752 would wrongly return t on a 64-bit host.
7753
e3c25c68
PE
7754 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7755 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7756 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7757 and therefore cause GCC to emit a bogus diagnostic in some cases.
7758
3f791afe
PE
7759 * image.c: Integer signedness and overflow and related fixes.
7760 This is not an exhaustive set of fixes, but it's time to
7761 record what I've got.
7762 (lookup_pixel_color, check_image_size): Remove redundant decls.
7763 (check_image_size): Don't assume that arbitrary EMACS_INT values
7764 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7765 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7766 (tiff_load, imagemagick_load_image):
7767 Check for overflow in size calculations.
7768 (x_create_x_image_and_pixmap): Remove unnecessary test for
7769 xmalloc returning NULL; that can't happen.
7770 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7771 (xpm_color_bucket): Use better integer hashing function.
7772 (xpm_cache_color): Don't possibly over-allocate memory.
7773 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7774 (gif_memory_source):
7775 Use ptrdiff_t, not int or size_t, to record sizes.
7776 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7777 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7778 either works, as we prefer signed integers.
7779 (tiff_read_from_memory, tiff_write_from_memory):
7780 Return tsize_t, not size_t, since that's what the TIFF API wants.
7781 (tiff_read_from_memory): Don't fail simply because the read would
7782 go past EOF; instead, return a short read.
7783 (tiff_load): Omit no-longer-needed casts.
7784 (Fimagemagick_types): Don't assume size fits into 'int'.
7785
3cc5a532
PE
7786 Improve hashing quality when configured --with-wide-int.
7787 * fns.c (hash_string): New function, taken from sxhash_string.
7788 Do not discard information about ASCII character case; this
7789 discarding is no longer needed.
7790 (sxhash-string): Use it. Change sig to match it. Caller changed.
7791 * lisp.h: Declare it.
7792 * lread.c (hash_string): Remove, since we now use fns.c's version.
7793 The fns.c version returns a wider integer if --with-wide-int is
7794 specified, so this should help the quality of the hashing a bit.
7795
b312a492
PE
7796 * emacs.c: Integer overflow minor fix.
7797 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7798 Define only if GNU_LINUX.
7799 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7800
dfd153ae
PE
7801 * dispnew.c: Integer signedness and overflow fixes.
7802 Remove unnecessary forward decls, that were a maintenance hassle.
7803 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7804 All uses changed.
7805 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7806 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7807 (prepare_desired_row, line_draw_cost):
7808 Use int, not unsigned, where either works.
7809 (save_current_matrix, restore_current_matrix):
7810 Use ptrdiff_t, not size_t, where either works.
7811 (init_display): Check for overflow more accurately, and without
7812 relying on undefined behavior.
7813
a81d11a3
PE
7814 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7815 Remove, replacing with the new symbols in lisp.h. All uses changed.
7816 * fileio.c (make_temp_name):
7817 * filelock.c (lock_file_1, lock_file):
7818 * xdisp.c (message_dolog):
7819 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7820 Use pMd etc. instead.
7821 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7822 replacing the pWIDE etc. symbols removed from editfns.c.
7823
3300e6fd
PE
7824 * keyboard.h (num_input_events): Now uintmax_t.
7825 This is (very slightly) less likely to mess up due to wraparound.
7826 All uses changed.
7827
fd05c7e9
PE
7828 * buffer.c: Integer signedness fixes.
7829 (alloc_buffer_text, enlarge_buffer_text):
7830 Use ptrdiff_t rather than size_t when either will do, as we prefer
7831 signed integers.
7832
903fe15d
PE
7833 * alloc.c: Integer signedness and overflow fixes.
7834 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7835 (__malloc_size_t): Default to size_t, not to int.
7836 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7837 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7838 Prefer ptrdiff_t to size_t when either would do, as we prefer
7839 signed integers.
7840 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7841 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7842 Now const. Initialize with values that are in range even if char
7843 is signed.
7844 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7845 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7846 These functions do the right thing with sizes > 2**32.
7847 (check_depth): Now ptrdiff_t, not int.
7848 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7849 Adjust to new way of storing sizes. Check for size overflow bugs
7850 in rest of code.
7851 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7852 slightly wrong anyway, as it missed one instance of
7853 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7854 (refill_memory_reserve): Omit needless cast to size_t.
7855 (mark_object_loop_halt): Mark as externally visible.
7856
ac82cc6a
PE
7857 * xselect.c: Integer signedness and overflow fixes.
7858 (Fx_register_dnd_atom, x_handle_dnd_message):
7859 Use ptrdiff_t, not size_t, since we prefer signed.
7860 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7861 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7862 x_dnd_atoms_size and x_dnd_atoms_length.
7863
c2d1e36d
PE
7864 * doprnt.c: Prefer signed to unsigned when either works.
7865 * eval.c (verror):
7866 * doprnt.c (doprnt):
7867 * lisp.h (doprnt):
7868 * xdisp.c (vmessage):
7869 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7870 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7871 prefer signed arithmetic to avoid comparison confusion.
7872 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7873 but is a bit tricky.
7874
0e926e56
PE
7875 Assume freestanding C89 headers, string.h, stdlib.h.
7876 * data.c, doprnt.c, floatfns.c, print.c:
7877 Include float.h unconditionally.
7878 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7879 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7880 * regex.c: Likewise for stddef.h, string.h.
7881 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7882 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7883 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7884 (STDC_HEADERS): Remove obsolete defines.
7885 * sysdep.c: Include limits.h unconditionally.
7886
9cfdb3ec
PE
7887 Assume support for memcmp, memcpy, memmove, memset.
7888 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7889 * regex.c (memcmp, memcpy):
7890 Remove; we assume C89 now.
7891
7892 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7893 (__malloc_safe_bcopy): Remove; no longer needed.
7894
cf950e6b 7895 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7896 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7897 well either way, and we prefer signed to unsigned.
7898
dbf38e02
LMI
78992011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7900
7901 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7902 closes the connection while we're reading (bug#9182).
7903
d6f0886c 79042011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7905
d6f0886c
JD
7906 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7907 are specified (Bug#9168).
24e0f6b1 7908
2eb1f9e6
PE
79092011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7910
7911 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7912 Found by GCC static checking and --with-wide-int on a 32-bit host.
7913
22381272 79142011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7915
7916 * xdisp.c (compute_display_string_pos): Fix logic of caching
7917 previous display string position. Initialize cached_prev_pos to
7918 -1. Fixes slow-down at the beginning of a buffer.
7919
f25e39b4
EZ
79202011-07-24 Eli Zaretskii <eliz@gnu.org>
7921
7922 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7923 for attrs[LFACE_FONTSET_INDEX].
7924
04c4b52e
PE
79252011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7926
7927 * xml.c (parse_region): Remove unused local
7928 that was recently introduced.
7929
c1734fbd
EZ
79302011-07-23 Eli Zaretskii <eliz@gnu.org>
7931
be18c5a5
EZ
7932 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7933 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7934
c1734fbd
EZ
7935 * xdisp.c (move_it_in_display_line_to): Record the best matching
7936 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7937 exit if none of the characters scanned was an exact match.
7938 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7939 when exact match is impossible due to invisible text, and the
7940 lines are truncated.
7941
a258d627
JD
79422011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7943
7944 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7945 for OSX >= 10.7.
7946
b6d5a689
EZ
79472011-07-22 Eli Zaretskii <eliz@gnu.org>
7948
0f74f785
EZ
7949 Fix a significant slow-down of cursor motion with C-n, C-p,
7950 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7951 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7952 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7953 (next_element_from_buffer): Call compute_stop_pos_backwards to
7954 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7955 base_level_stop.
7956 (reseat): Don't look for prev_stop, as that could mean a very long
7957 run.
7958 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7959 <cached_disp_overlay_modiff>: Cache for last found display string
7960 position.
551918c1 7961 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7962 about the same buffer in the same area of character positions, and
7963 the buffer wasn't changed since the time the display string
7964 position was cached.
551918c1 7965
b2d0c91a
EZ
79662011-07-22 Eli Zaretskii <eliz@gnu.org>
7967
7968 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7969 is an integer, which is important for empty lines. (Bug#9149)
7970
043604ee
CY
79712011-07-22 Chong Yidong <cyd@stupidchicken.com>
7972
7973 * frame.c (Fmodify_frame_parameters): In tty case, update the
7974 default face if necessary (Bug#4238).
7975
da4adb04
CY
79762011-07-21 Chong Yidong <cyd@stupidchicken.com>
7977
7978 * editfns.c (Fstring_to_char): No need to explain what a character
7979 is in the docstring (Bug#6576).
7980
9abd0532
LMI
79812011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7982
7983 * xml.c (parse_region): Make sure we always return a tree.
7984
36881d16
HK
79852011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7986
7987 * xml.c (parse_region): If a document contains only comments,
7988 return that, too.
7989
1e98674d
LMI
79902011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7991
7992 * xml.c (make_dom): Return comments, too.
7993
590bd467
PE
79942011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7995
7996 Port to OpenBSD.
7997 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7998 and the surrounding thread.
7999 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8000 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8001 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8002 timer goes off.
8003 * s/openbsd.h (BROKEN_SIGIO): Define.
8004 * unexelf.c (unexec) [__OpenBSD__]:
8005 Don't update the .mdebug section of the Alpha COFF symbol table.
8006
f41628b2
LMI
80072011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8008
8009 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8010 (bug#8460).
8011
b59b67c5
PE
80122011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8013
15e3a074
PE
8014 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8015 This fixes some race conditions on the permissions of any newly
8016 created file.
8017
41bed37d
PE
8018 * alloc.c (valid_pointer_p): Use pipe, not open.
8019 This fixes some permissions issues when debugging.
8020
b59b67c5
PE
8021 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8022 If fchown fails to set both uid and gid, try to set just gid,
8023 as that is sometimes allowed. Adjust the file's mode to eliminate
8024 setuid or setgid bits that are inappropriate if fchown fails.
8025
925a6be7
SM
80262011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8027
8028 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8029 to compare Lisp_Objects.
8030 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8031 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8032 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8033
52968808
AS
80342011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8035
0a6a104b
AS
8036 * lread.c (read_integer): Unread even EOF character.
8037 (read1): Likewise. Properly record start position of symbol.
8038
52968808
AS
8039 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8040 symbol character follows.
8041
9e381cdd
PE
80422011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8043
8044 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8045 This works around a problem with the previous change to Fcopy_file.
8046 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8047 and without this change, GCC might complain about discarding
8048 fchown's return value.
8049
b5641435
JB
80502011-07-16 Juanma Barranquero <lekktu@gmail.com>
8051
8052 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8053
a8031457
PE
80542011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8055
8056 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8057
dd889327
LMI
80582011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8059
750c33f7
LMI
8060 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8061 it's used from the C level.
8062
dd889327
LMI
8063 * process.c: Use the same condition for POLL_FOR_INPUT in both
8064 keyboard.c and process.c (bug#1858).
8065
87e86684
LM
80662011-07-09 Lawrence Mitchell <wence@gmx.li>
8067
8068 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8069 (Fgnutls_boot): Use it.
8070
64348f40
AS
80712011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8072
8073 * doc.c (Fsubstitute_command_keys): Revert last change.
8074
1d698799
LMI
80752011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8076
f863868c
LMI
8077 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8078 quotes the next character, and doesn't affect other longer
8079 sequences (bug#8935).
8080
1d698799
LMI
8081 * lread.c (syms_of_lread): Clarify that is isn't only
8082 `eval-buffer' and `eval-defun' that's affected by
8083 `lexical-binding' (bug#8460).
8084
aa4b6df6
EZ
80852011-07-15 Eli Zaretskii <eliz@gnu.org>
8086
8087 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8088 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8089
5d856da6
PE
80902011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8091
ad6042bb
PE
8092 Fix minor problems found by static checking.
8093 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8094 (elsz): Now a signed constant, not a size_t var. We prefer signed
8095 types to unsigned, to avoid integer comparison confusion. Without
8096 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8097 "cannot optimize loop, the loop counter may overflow", a symptom
8098 of the confusion.
f00bbb22 8099 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8100 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8101
6468f31c
LMI
81022011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8103
49080b10
LMI
8104 * search.c (Fre_search_backward): Mention `case-fold-search' in
8105 all the re_search_* functions (bug#8138).
8106
6468f31c
LMI
8107 * keyboard.c (Fopen_dribble_file): Document when the file is
8108 closed (bug#8056).
8109
c965adc5
EZ
81102011-07-14 Eli Zaretskii <eliz@gnu.org>
8111
df9733bf
EZ
8112 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8113 bidi_cache_idx.
8114
0bb23927
EZ
8115 Support bidi reordering of display and overlay strings.
8116 * xdisp.c (compute_display_string_pos)
8117 (compute_display_string_end): Accept additional argument STRING.
8118 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8119 (reseat_to_string): Initialize bidi_it->string.s and
8120 bidi_it->string.schars.
8121 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8122 NULL (avoids a crash in bidi_paragraph_init).
8123 Initialize itb.string.lstring.
0bb23927
EZ
8124 (init_iterator): Call bidi_init_it only of a valid
8125 buffer position was specified. Initialize paragraph_embedding to
8126 L2R.
8127 (reseat_to_string): Initialize the bidi iterator.
8128 (display_string): If we need to ignore text properties of
8129 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8130 original value of -1 will not work with bidi.)
8131 (compute_display_string_pos): First arg is now struct
8132 `text_pos *'; all callers changed. Support display properties on
8133 Lisp strings.
8134 (compute_display_string_end): Support display properties on Lisp
8135 strings.
8136 (init_iterator, reseat_1, reseat_to_string): Initialize the
8137 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8138 when iterating on a string not from display properties).
640c8776
SM
8139 (compute_display_string_pos, compute_display_string_end):
8140 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8141 arrow keys.
8142 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8143 base_level_stop; instead, set base_level_stop to BEGV.
8144 Fixes crashes in vertical-motion.
0bb23927
EZ
8145 (next_element_from_buffer): Improve commentary for when
8146 the iterator is before prev_stop.
8147 (init_iterator): Initialize bidi_p from the default value of
8148 bidi-display-reordering, not from buffer-local value. Use the
8149 buffer-local value only if initializing for buffer iteration.
8150 (handle_invisible_prop): Support invisible properties on strings
8151 that are being bidi-reordered.
8152 (set_iterator_to_next): Support bidi reordering of C strings and
8153 Lisp strings.
8154 (next_element_from_string): Support bidi reordering of Lisp
8155 strings.
8156 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8157 (display_string): Support display of R2L glyph rows.
8158 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8159 (init_iterator): Don't initialize it->bidi_p for strings
8160 here.
8161 (reseat_to_string): Initialize it->bidi_p for strings here.
8162 (next_element_from_string, next_element_from_c_string)
8163 (next_element_from_buffer): Add xassert's for correspondence
8164 between IT's object being iterated and it->bidi_it.string
8165 structure.
8166 (face_before_or_after_it_pos): Support bidi iteration.
8167 (next_element_from_c_string): Handle the case of the first string
8168 character that is not the first one in the visual order.
8169 (get_visually_first_element): New function, refactored from common
8170 parts of next_element_from_buffer, next_element_from_string, and
8171 next_element_from_c_string.
8172 (tool_bar_lines_needed, redisplay_tool_bar)
8173 (display_menu_bar): Force left-to-right direction. Add a FIXME
8174 comment for making that be controlled by a user option.
8175 (push_it, pop_it): Save and restore the state of the
8176 bidi iterator. Save and restore the bidi_p flag.
8177 (pop_it): Iterate out of display property for string iteration as
8178 well.
8179 (iterate_out_of_display_property): Support iteration over strings.
8180 (handle_single_display_spec): Set up it->bidi_it for iteration
8181 over a display string, and call bidi_init_it.
8182 (handle_single_display_spec, next_overlay_string)
8183 (get_overlay_strings_1, push_display_prop): Set up the bidi
8184 iterator for displaying display or overlay strings.
8185 (forward_to_next_line_start): Don't use the shortcut if
8186 bidi-iterating.
8187 (back_to_previous_visible_line_start): If handle_display_prop
8188 pushed the iterator stack, restore the internal state of the bidi
8189 iterator by calling bidi_pop_it same number of times.
8190 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8191 and we are bidi-iterating, don't decrement the iterator position;
8192 instead, set the first_elt flag in the bidi iterator, to produce
8193 the same effect.
8194 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8195 (push_display_prop): xassert that we are iterating a buffer.
8196 (push_it, pop_it): Save and restore paragraph_embedding member.
8197 (handle_single_display_spec, next_overlay_string)
8198 (get_overlay_strings_1, reseat_1, reseat_to_string)
8199 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8200 correctly. Don't assume unibyte strings are not bidi-reordered.
8201 (compute_display_string_pos)
8202 (compute_display_string_end): Fix handling the case of C string.
8203 (push_it, pop_it): Save and restore from_disp_prop_p.
8204 (handle_single_display_spec, push_display_prop): Set the
8205 from_disp_prop_p flag.
8206 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8207 (pop_it): Call iterate_out_of_display_property only if we are
8208 popping after iteration over a string that came from a display
8209 property. Fix a typo in popping stretch info. Add an assertion
8210 for verifying that the iterator position is in sync with the bidi
8211 iterator.
8212 (handle_single_display_spec, get_overlay_strings_1)
8213 (push_display_prop): Fix initialization of paragraph direction for
8214 string when that of the parent object is not yet determined.
8215 (reseat_1): Call bidi_init_it to resync the bidi
8216 iterator with IT's position. (Bug#7616)
8217 (find_row_edges): If ROW->start.pos gives position
8218 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8219 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8220 Reset the from_disp_prop_p flag.
8221 (SAVE_IT, RESTORE_IT): New macros.
8222 (pos_visible_p, face_before_or_after_it_pos)
8223 (back_to_previous_visible_line_start)
8224 (move_it_in_display_line_to, move_it_in_display_line)
8225 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8226 (try_scrolling, redisplay_window, display_line): Use them when
8227 saving a temporary copy of the iterator and restoring it back.
8228 (back_to_previous_visible_line_start, reseat_1)
8229 (init_iterator): Empty the bidi cache "stack".
8230 (move_it_in_display_line_to): If iterator ended up at
8231 EOL, but we never saw any buffer positions smaller than
8232 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8233 motion in bidi-reordered lines.
8234 (move_it_in_display_line_to): Record prev_method and prev_pos
8235 immediately before the call to set_iterator_to_next. Fixes cursor
8236 motion in bidi-reordered lines with stretch glyphs and strings
8237 displayed in margins. (Bug#8133) (Bug#8867)
8238 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8239 TO_CHARPOS.
640c8776
SM
8240 (pos_visible_p): Support positions in bidi-reordered lines.
8241 Save and restore bidi cache.
0bb23927
EZ
8242
8243 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8244 (bidi_paragraph_info): Delete unused struct.
8245 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8246 (bidi_cache_start): New variable.
8247 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8248 to zero.
8249 (bidi_cache_fetch_state, bidi_cache_search)
8250 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8251 (bidi_cache_find, bidi_peek_at_next_level)
8252 (bidi_level_of_next_char, bidi_find_other_level_edge)
8253 (bidi_move_to_visually_next): Compare cache index with
8254 bidi_cache_start rather than with zero.
8255 (bidi_fetch_char): Accept new argument STRING; all callers
8256 changed. Support iteration over a string. Support strings with
8257 display properties. Support unibyte strings. Fix the type of
8258 `len' according to what STRING_CHAR_AND_LENGTH expects.
8259 (bidi_paragraph_init, bidi_resolve_explicit_1)
8260 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8261 (bidi_level_of_next_char, bidi_move_to_visually_next):
8262 Support iteration over a string.
0bb23927
EZ
8263 (bidi_set_sor_type, bidi_resolve_explicit_1)
8264 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8265 can now be zero (for strings); special values 0 and -1 were
8266 changed to -1 and -2, respectively.
8267 (bidi_char_at_pos): New function.
8268 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8269 Call it instead of FETCH_MULTIBYTE_CHAR.
8270 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8271 initialized to valid values.
8272 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8273 values.
8274 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8275 the test for valid cached positions. Fix the logic for looking up
8276 the sentinel state in the cache. GCPRO the Lisp string we are
8277 iterating.
8278 (bidi_push_it, bidi_pop_it): New functions.
8279 (bidi_initialize): Initialize the bidi cache start stack pointer.
8280 (bidi_cache_ensure_space): New function, refactored from part of
8281 bidi_cache_iterator_state. Don't assume the required size is just
8282 one BIDI_CACHE_CHUNK away.
8283 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8284 (bidi_count_bytes, bidi_char_at_pos): New functions.
8285 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8286 always valid if bidi_cache_idx is valid.
8287 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8288 is valid if it's going to be used.
8289 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8290 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8291 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8292 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8293 (bidi_find_other_level_edge, bidi_cache_start_stack):
8294 All variables related to cache indices are now EMACS_INT.
c965adc5 8295
0bb23927
EZ
8296 * dispextern.h (struct bidi_string_data): New structure.
8297 (struct bidi_it): New member `string'. Make flag members be 1-bit
8298 fields, and put them last in the struct.
640c8776
SM
8299 (compute_display_string_pos, compute_display_string_end):
8300 Update prototypes.
0bb23927
EZ
8301 (bidi_push_it, bidi_pop_it): Add prototypes.
8302 (struct iterator_stack_entry): New members bidi_p,
8303 paragraph_embedding, and from_disp_prop_p.
8304 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8305 (bidi_shelve_cache, bidi_unshelve_cache):
8306 Declare prototypes.
0bb23927
EZ
8307
8308 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8309 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8310 and vector-like objects.
8311
8312 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8313 cache around display iteration.
8314
8315 * window.c (Fwindow_end, window_scroll_pixel_based)
8316 (displayed_window_lines, Frecenter): Save and restore the bidi
8317 cache around display iteration.
8318
3bbd2265
LMI
83192011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8320
8321 * editfns.c (Fdelete_region): Clarify the use of the named
8322 parameters (bug#6788).
8323
adc47434
MR
83242011-07-14 Martin Rudalics <rudalics@gmx.at>
8325
8326 * indent.c (Fvertical_motion): Set and restore w->pointm when
8327 saving and restoring the window's buffer (Bug#9006).
8328
837c31f8
LMI
83292011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8330
8331 * editfns.c (Fstring_to_char): Clarify just what is returned
8332 (bug#6576). Text by Eli Zaretskii.
8333
ac389d0c
JB
83342011-07-13 Juanma Barranquero <lekktu@gmail.com>
8335
8336 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8337
0be0ce47
EZ
83382011-07-13 Eli Zaretskii <eliz@gnu.org>
8339
8340 * buffer.c (mmap_find): Fix a typo.
8341
cd18e7e3
JB
83422011-07-13 Johan Bockgård <bojohan@gnu.org>
8343
8344 Fix execution of x selection hooks.
8345 * xselect.c (Qx_lost_selection_functions)
8346 (Qx_sent_selection_functions): New vars.
8347 (syms_of_xselect): DEFSYM them.
8348 (x_handle_selection_request): Pass Qx_sent_selection_functions
8349 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8350 (x_handle_selection_clear,x_clear_frame_selections):
8351 Pass Qx_lost_selection_functions rather than
8352 Vx_lost_selection_functions to Frun_hook_with_args.
8353
47ea7f44
PE
83542011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8355
ac389d0c 8356 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8357 The old code sometimes used this field without initializing it.
8358
47ea7f44
PE
8359 * alloc.c (gc_sweep): Don't read past end of array.
8360 In theory, the old code could also have corrupted Emacs internals,
8361 though it'd be very unlikely.
8362
bc985c87
AS
83632011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8364
8365 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8366 argument. (Bug#4026)
bc985c87 8367
0cf34688
LMI
83682011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8369
b3dadd76
LMI
8370 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8371 key" (bug#4257).
8372
0cf34688
LMI
8373 * window.c (Fset_window_start): Doc fix (bug#4199).
8374 (Fset_window_hscroll): Ditto.
8375
270768cd
PE
83762011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8377
077e3dda 8378 Fix minor new problems caught by GCC 4.6.1.
270768cd 8379 * term.c (init_tty): Remove unused local.
490011a6 8380 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8381 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8382 not used otherwise.
270768cd 8383
b1f58454
CY
83842011-07-12 Chong Yidong <cyd@stupidchicken.com>
8385
8386 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8387
22b9578d
LMI
83882011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8389
6e70ab07
LMI
8390 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8391 are the mini-buffer and the echo area (bug#3320).
8392
22b9578d
LMI
8393 * term.c (init_tty): Remove support for supdup, c10 and perq
8394 terminals, which are no longer supported (bug#1482).
8395
8974cc9f
JB
83962011-07-10 Johan Bockgård <bojohan@gnu.org>
8397
8398 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8399
a560d974
JD
84002011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8401
8402 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8403 for non-popups (Bug#3642).
8404
1dae0f0a
AS
84052011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8406
268c2c36 8407 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8408 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8409 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8410 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8411 * data.c (fmod): Likewise.
8412 * dispnew.c (swap_glyphs_in_rows): Likewise.
8413 * emacs.c (memory_warning_signal): Likewise.
8414 * floatfns.c (float_error): Likewise.
8415 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8416 (otf_open, font_otf_capability, generate_otf_features)
8417 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8418 Likewise.
8419 * image.c (pbm_read_file): Likewise.
8420 * indent.c (string_display_width): Likewise.
8421 * intervals.c (check_for_interval, search_for_interval)
8422 (inc_interval_count, count_intervals, root_interval)
8423 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8424 * lread.c (defalias): Likewise.
268c2c36 8425 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8426 * regex.c (set_image_of_range_1, set_image_of_range)
8427 (regex_grow_registers): Likewise.
8428 * sysdep.c (strerror): Likewise.
8429 * termcap.c (valid_filename_p, tprint, main): Likewise.
8430 * tparam.c (main): Likewise.
8431 * unexhp9k800.c (run_time_remap, save_data_space)
8432 (update_file_ptrs, read_header, write_header, calculate_checksum)
8433 (copy_file, copy_rest, display_header): Likewise.
8434 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8435 Likewise.
8436 * xdisp.c (check_it): Likewise.
8437 * xfaces.c (register_color, unregister_color, unregister_colors):
8438 Likewise.
8439 * xfns.c (print_fontset_result): Likewise.
8440 * xrdb.c (member, fatal, main): Likewise.
8441
99033785
PE
84422011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8443
8444 Fix minor problems found by static checking (Bug#9031).
8445 * chartab.c (char_table_set_range, map_sub_char_table):
8446 Remove unused locals.
8447 (uniprop_table): Now static.
8448 * composite.c (_work_char): Remove unused static var.
8449
9cb2ac56
JB
84502011-07-09 Juanma Barranquero <lekktu@gmail.com>
8451
8452 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8453
f25661f0
JD
84542011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8455
8456 * gtkutil.c (qttip_cb): Remove code without function.
8457
8278c4fe
EZ
84582011-07-09 Eli Zaretskii <eliz@gnu.org>
8459
8460 * w32.c (pthread_sigmask): New stub.
8461
1692ae2d 84622011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8463
8a6ebd58 8464 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8465 sigprocmask is portable only for single-threaded applications, and
8466 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8467 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8468 (LIBES): Use it.
8469 * callproc.c (Fcall_process):
8470 * process.c (create_process):
8471 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8472 Use pthread_sigmask, not sigprocmask.
123403e4 8473
1b854618
JD
84742011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8475
8476 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8477 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8478 wrong (Bug#8591).
8479
3fe4b549
JD
84802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8481
0ce7e563
JD
8482 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8483 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8484 (xg_hide_tooltip): Fix comment.
8485
3fe4b549
JD
8486 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8487 in registerServicesMenuSendTypes.
8488 (validRequestorForSendType): Don't check ns_return_types.
8489
8490 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8491 ns_return_type.
8492
5df75e47
JR
84932011-07-08 Jason Rumney <jasonr@gnu.org>
8494
22610910
JR
8495 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8496 SH_SHOW for hidden windows (Bug#5482).
8497
5df75e47
JR
8498 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8499 frame struct members of non-existent frames (Bug#6284).
8500
699c10bd
JD
85012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8502
4393663b
JD
8503 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8504 variable firstTime not needed on OSX >= 10.6.
8505 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8506 >= 10.5. Use setKnobProportion, setDoubleValue.
8507
8508 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8509 (MAC_OS_X_VERSION_10_5): Define if not defined.
8510 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8511 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8512 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8513
8514 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8515 cString and lossyCString on OSX >= 10.4.
4393663b 8516
58179cce 8517 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8518 sizeToFit on OSX >= 10.2.
8519
8520 * nsimage.m (allocInitFromFile): Don't use deprecated method
8521 bestRepresentationForDevice on OSX >= 10.6.
8522
8523 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8524 to avoid warning.
8525
8526 * emacs.c: Declare unexec_init_emacs_zone.
8527
a63e0781
JD
8528 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8529
699c10bd
JD
8530 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8531
8532 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8533 on svcsMenu (Bug#8842).
8534
8535 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8536 ns_return_types.
8537 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8538
8539 * nsterm.m (QUTF8_STRING): Declare.
8540 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8541 (validRequestorForSendType): Return type is (id).
8542 Change indexOfObjectIdenticalTo to indexOfObject.
8543 Check if we have local selection before returning self (Bug#8842).
8544 (writeSelectionToPasteboard): Put local selection into paste board
8545 if we have a local selection (Bug#8842).
8546 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8547
8548 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8549 (ns_get_local_selection): Declare.
8550
54e10184
LMI
85512011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8552
9888ff71
LMI
8553 * keymap.c (describe_map_tree): Don't insert a double newline at
8554 the end of the buffer (bug#1169) and return whether we inserted
8555 something.
8556
54e10184
LMI
8557 * callint.c (Fcall_interactively): Change "reading args" to
8558 "providing args" to try to clarify what it does (bug#1010).
8559
15fa4783
KH
85602011-07-07 Kenichi Handa <handa@m17n.org>
8561
8562 * composite.c (composition_compute_stop_pos): Ignore a static
8563 composition starting before CHARPOS (Bug#8915).
8564
8565 * xdisp.c (handle_composition_prop): Likewise.
8566
a8815b00
EZ
85672011-07-07 Eli Zaretskii <eliz@gnu.org>
8568
8569 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8570 (Bug#9015)
8571
ef7b981d 85722011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8573
8574 * character.h (unicode_category_t): New enum type.
8575
8576 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8577 (Qchar_code_property_table): New variable.
8578 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8579 (UNIPROP_COMPRESSED_FORM_P): New macros.
8580 (char_table_ascii): Uncompress the compressed values.
8581 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8582 Uncompress the compressed values.
ac389d0c 8583 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8584 (char_table_ref_and_range): Uncompress the compressed values.
8585 (sub_char_table_set): New arg is_uniprop. Callers changed.
8586 Uncompress the compressed values.
8587 (sub_char_table_set_range): Args changed. Callers changed.
8588 (char_table_set_range): Adjuted for the above change.
8589 (map_sub_char_table): Delete args default_val and parent. Add arg
8590 top. Give decoded values to a Lisp function.
640c8776 8591 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8592 values to a Lisp function. Gcpro more variables.
8593 (uniprop_table_uncompress)
8594 (uniprop_decode_value_run_length): New functions.
8595 (uniprop_decoder, uniprop_decoder_count): New variables.
8596 (uniprop_get_decoder, uniprop_encode_value_character)
8597 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8598 New functions.
8599 (uniprop_encoder, uniprop_encoder_count): New variables.
8600 (uniprop_get_encoder, uniprop_table)
8601 (Funicode_property_table_internal, Fget_unicode_property_internal)
8602 (Fput_unicode_property_internal): New functions.
8603 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8604 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8605 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8606 char-code-property-alist.
8607
640c8776 8608 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8609 Vunicode_category_table.
8610
640c8776 8611 * font.c (font_range): Adjust for the change of
c805dec0
KH
8612 Vunicode_category_table.
8613
76b397fb
DN
86142011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8615
8616 * m/iris4d.h: Remove file, move contents ...
8617 * s/irix6-5.h: ... here.
8618
22b4128e
PE
86192011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8620
8621 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8622 * alloc.c (mark_buffer):
8623 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8624 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8625 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8626 This isn't true in general, and it's particularly not true
8627 if Emacs is configured with --with-wide-int.
8628 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8629 New macros, used in the buffer.c change.
8630
869795d6
JD
86312011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8632
8633 * xsettings.c: Use both GConf and GSettings if both are available.
8634 (store_config_changed_event): Add comment.
8635 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8636 (store_tool_bar_style_changed): New functions.
5e617bc2 8637 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8638 (struct xsettings): Move font inside HAVE_XFT.
8639 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8640 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8641 Move inside HAVE_XFT.
640c8776 8642 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8643 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8644 also.
8645 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8646 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8647 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8648 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8649 (parse_settings): Move check for font inside HAVE_XFT.
8650 (read_settings, apply_xft_settings): Add comment.
8651 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8652 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8653 call store_font_name_changed.
8654 (xft_settings_event): Add comment.
8655 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8656 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8657 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8658 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8659 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8660 (xsettings_get_system_font, xsettings_get_system_normal_font):
8661 Add comment.
869795d6 8662
d8ed26bd
PE
86632011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8664
8665 Random fixes. E.g., (random) never returned negative values.
8666 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8667 subseconds part to the entropy, as that's a bit more random.
8668 Prefer signed to unsigned, since the signedness doesn't matter and
8669 in general we prefer signed. When given a limit, use a
8670 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8671 latter isn't right if USE_2_TAGS_FOR_INTS.
8672 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8673 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8674
cabf1cac
SM
86752011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8676
8677 * textprop.c (text_property_stickiness):
8678 Obey Vtext_property_default_nonsticky.
8679 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8680 * w32fns.c (syms_of_w32fns):
8681 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8682
6e9b2be9
PE
86832011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8684
8685 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8686 This is more efficient than Ffile_directory_p and avoids a minor race.
8687
90186c68
LMI
86882011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8689
7c301272
LMI
8690 * buffer.c (Foverlay_put): Say what the return value is
8691 (bug#7835).
8692
c4f2d8d4
LMI
8693 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8694 is a directory before asking whether to use the file name
8695 (bug#7564).
ad637907
LMI
8696 (barf_or_query_if_file_exists): Make the "File is a directory"
8697 error be more correct.
c4f2d8d4 8698
90186c68
LMI
8699 * fns.c (Frequire): Remove the mention of the .gz files, since
8700 that's installation-specific, but keep the mention of
8701 `get-load-suffixes'.
8702
da64016e
PE
87032011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8704
8705 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8706 Report string overflow if the output is too long.
8707
7d47b580
JB
87082011-07-04 Juanma Barranquero <lekktu@gmail.com>
8709
a555cb87
JB
8710 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8711 (syms_of_gnutls): Remove duplicate DEFSYM for
8712 Qgnutls_bootprop_verify_hostname_error, an error for
8713 Qgnutls_bootprop_verify_error (which is no longer used).
8714
7d47b580
JB
8715 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8716 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8717 Also (re)move comments that are misplaced or no longer relevant.
8718
1e49bfab
LMI
87192011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8720
8721 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8722
1485f4c0
CY
87232011-07-03 Chong Yidong <cyd@stupidchicken.com>
8724
8725 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8726 and background color parameters if they have been changed.
8727
a9ab721e
LMI
87282011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8729
8730 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8731
cf7cff57
PE
87322011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8733
2e13213d
PE
8734 * xsettings.c (SYSTEM_FONT): Define only when used.
8735 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8736
cf7cff57
PE
8737 * keymap.c (access_keymap_1): Now static.
8738
7a8e04f7
CY
87392011-07-02 Chong Yidong <cyd@stupidchicken.com>
8740
8741 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8742 leave any prefix arg for the up event (Bug#1586).
8743
61352f62
LMI
87442011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8745
69bb1ef7
LMI
8746 * lread.c (syms_of_lread): Mention single symbols defined by
8747 `defvar' or `defconst' (bug#7154).
8748
61352f62 8749 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8750 (Frequire): Mention get-load-suffixes.
61352f62 8751
28545e04
MR
87522011-07-02 Martin Rudalics <rudalics@gmx.at>
8753
8754 * window.h (window): Remove clone_number slot.
8755 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8756 Remove.
8757 (make_parent_window, make_window, saved_window)
8758 (Fset_window_configuration, save_window_save): Don't deal with
8759 clone numbers.
8760 * buffer.c (Qclone_number): Remove declaration.
8761 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8762
3349e122
SM
87632011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8764
8765 Add multiple inheritance to keymaps.
8766 * keymap.c (Fmake_composed_keymap): New function.
8767 (Fset_keymap_parent): Simplify.
8768 (fix_submap_inheritance): Remove.
8769 (access_keymap_1): New function extracted from access_keymap to handle
8770 embedded parents and handle lists of maps.
8771 (access_keymap): Use it.
8772 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8773 (Fcopy_keymap): Handle embedded parents.
8774 (Fcommand_remapping, define_as_prefix): Simplify.
8775 (Fkey_binding): Simplify.
8776 (syms_of_keymap): Move minibuffer-local-completion-map,
8777 minibuffer-local-filename-completion-map,
8778 minibuffer-local-must-match-map, and
8779 minibuffer-local-filename-must-match-map to Elisp.
8780 (syms_of_keymap): Defsubr make-composed-keymap.
8781 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8782 (parse_menu_item): Trivial simplification.
8783
3279eb87
GM
87842011-07-01 Glenn Morris <rgm@gnu.org>
8785
8786 * Makefile.in (SETTINGS_LIBS): Fix typo.
8787
4550efdf
KI
87882011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8789
8790 * coding.c (Fencode_coding_string): Record the last coding system
8791 used, as the function doc string says (bug#8738).
8792
0949d2b6
JD
87932011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8794
8795 * xsettings.c (store_monospaced_changed): Take new font as arg and
8796 check for change against current_mono_font.
8797 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8798 (emacs_settings_constructor, emacs_settings_get_property)
8799 (emacs_settings_set_property, emacs_settings_class_init)
8800 (emacs_settings_init, gsettings_obj): Remove.
8801 (something_changedCB): New function for HAVE_GSETTINGS.
8802 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8803 with value as argument.
8804 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8805 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8806 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8807 "changed".
8808
8809 * xgselect.c: Add defined (HAVE_GSETTINGS).
8810 (xgselect_initialize): Ditto.
8811
8812 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8813 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8814 xg_select.
8815
bbc6b304
PE
88162011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8817
8818 * eval.c (struct backtrace): Simplify and port the data structure.
8819 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8820 signed bit field, as this assumption is not portable and it makes
8821 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8822 "char debug_on_exit : 1" as this is not portable either; instead,
8823 use the portable "unsigned int debug_on_exit : 1". Remove unused
8824 member evalargs. Remove obsolete comments about cc bombing out.
8825
9851bfc5
JD
88262011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8827
51bb811f 8828 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8829 Let HAVE_GSETTINGS override HAVE_GCONF.
8830 (store_monospaced_changed): New function.
8831 (EMACS_SETTINGS): A new type derived from GObject to handle
8832 GSettings notifications.
8833 (emacs_settings_constructor, emacs_settings_get_property)
8834 (emacs_settings_set_property, emacs_settings_class_init):
8835 New functions.
8836 (gsettings_client, gsettings_obj): New variables.
8837 (GSETTINGS_SCHEMA): New define.
8838 (something_changedCB): Call store_monospaced_changed.
8839 (init_gsettings): New function.
8840 (xsettings_initialize): Call init_gsettings.
8841 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8842 to NULL.
8843
640c8776 8844 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8845 GCONF_CFLAGS/LIBS.
8846
5386012d
MR
88472011-06-29 Martin Rudalics <rudalics@gmx.at>
8848
8849 * window.c (resize_root_window, grow_mini_window)
8850 (shrink_mini_window): Rename Qresize_root_window to
8851 Qwindow_resize_root_window and Qresize_root_window_vertically to
8852 Qwindow_resize_root_window_vertically.
8853
f13e0b08
PE
88542011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8855
8856 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8857
94515237
JB
88582011-06-27 Juanma Barranquero <lekktu@gmail.com>
8859
8860 * makefile.w32-in: Redesign dependencies so they reflect more
8861 clearly which files are directly included by each source file,
8862 and not through other includes.
8863
e43b6e43
MR
88642011-06-27 Martin Rudalics <rudalics@gmx.at>
8865
8866 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8867 (sort_overlays, overlay_strings): When an overlay's clone number
8868 matches the window's clone number process the overlay even if
8869 the overlay's window property doesn't match the current window.
8870
d68443dc
MR
8871 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8872 (Fwindow_hchild): Rename to Fwindow_left_child.
8873 (Fwindow_next): Rename to Fwindow_next_sibling.
8874 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8875 (resize_window_check): Rename to window_resize_check.
8876 (resize_window_apply): Rename to window_resize_apply.
8877 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8878 (Fdelete_other_windows_internal, resize_frame_windows)
8879 (Fsplit_window_internal, Fdelete_window_internal)
8880 (grow_mini_window, shrink_mini_window)
8881 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8882
c7e73be5
JD
88832011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8884
8885 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8886 (emacs_fixed_set_min_size): Remove.
8887 (emacs_fixed_new): Take frame as argument.
8888
8889 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8890 (_EmacsFixedPrivate): Remove minwidth/height.
8891 Add struct frame *f.
8892 (emacs_fixed_init): Initialize priv->f.
8893 (get_parent_class, emacs_fixed_set_min_size): Remove.
8894 (emacs_fixed_new): Set priv->f to argument.
8895 (emacs_fixed_get_preferred_width)
8896 (emacs_fixed_get_preferred_height): Use min_width/height from
8897 frames size_hint to set minimum and natural (Bug#8919).
8898 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8899 and use min_width/height from frames size_hint to set
8900 min_width/height (Bug#8919).
8901
8902 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8903 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8904 Fix indentation.
c7e73be5 8905
cf99dcf8
EZ
89062011-06-26 Eli Zaretskii <eliz@gnu.org>
8907
8908 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8909 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8910 called at ZV.
8911
029529ac
CY
89122011-06-26 Chong Yidong <cyd@stupidchicken.com>
8913
8914 * process.c (wait_reading_process_output): Bypass select if
8915 waiting for a cell while ignoring keyboard input, and input is
8916 pending. Suggested by Jan Djärv (Bug#8869).
8917
7a7ef429
PE
89182011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8919
8920 Use gnulib's dup2 module instead of rolling our own.
8921 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8922
11fdef7d 89232011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8924
8925 * dispnew.c (scrolling_window): Before scrolling, turn off a
8926 mouse-highlight in the window being scrolled.
8927
cd3520a4
JB
89282011-06-24 Juanma Barranquero <lekktu@gmail.com>
8929
8930 Move DEFSYM to lisp.h and use everywhere.
8931
8932 * character.h (DEFSYM): Move declaration...
8933 * lisp.h (DEFSYM): ...here.
8934
8935 * gnutls.c:
8936 * minibuf.c:
8937 * w32menu.c:
8938 * w32proc.c:
8939 * w32select.c: Don't include character.h.
8940
8941 * alloc.c (syms_of_alloc):
8942 * buffer.c (syms_of_buffer):
8943 * bytecode.c (syms_of_bytecode):
8944 * callint.c (syms_of_callint):
8945 * casefiddle.c (syms_of_casefiddle):
8946 * casetab.c (init_casetab_once):
8947 * category.c (init_category_once, syms_of_category):
8948 * ccl.c (syms_of_ccl):
8949 * cmds.c (syms_of_cmds):
8950 * composite.c (syms_of_composite):
8951 * dbusbind.c (syms_of_dbusbind):
8952 * dired.c (syms_of_dired):
8953 * dispnew.c (syms_of_display):
8954 * doc.c (syms_of_doc):
8955 * editfns.c (syms_of_editfns):
8956 * emacs.c (syms_of_emacs):
8957 * eval.c (syms_of_eval):
8958 * fileio.c (syms_of_fileio):
8959 * fns.c (syms_of_fns):
8960 * frame.c (syms_of_frame):
8961 * fringe.c (syms_of_fringe):
8962 * insdel.c (syms_of_insdel):
8963 * keymap.c (syms_of_keymap):
8964 * lread.c (init_obarray, syms_of_lread):
8965 * macros.c (syms_of_macros):
8966 * msdos.c (syms_of_msdos):
8967 * print.c (syms_of_print):
8968 * process.c (syms_of_process):
8969 * search.c (syms_of_search):
8970 * sound.c (syms_of_sound):
8971 * syntax.c (init_syntax_once, syms_of_syntax):
8972 * terminal.c (syms_of_terminal):
8973 * textprop.c (syms_of_textprop):
8974 * undo.c (syms_of_undo):
8975 * w32.c (globals_of_w32):
8976 * window.c (syms_of_window):
8977 * xdisp.c (syms_of_xdisp):
8978 * xfaces.c (syms_of_xfaces):
8979 * xfns.c (syms_of_xfns):
8980 * xmenu.c (syms_of_xmenu):
8981 * xsettings.c (syms_of_xsettings):
8982 * xterm.c (syms_of_xterm): Use DEFSYM.
8983
4228cf16
TZ
89842011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8985
cd3520a4 8986 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8987
7fcccf1e
PE
89882011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8989
7efb4e0e
PE
8990 Integer and buffer overflow fixes (Bug#8873).
8991
ff5844ad
PE
8992 * print.c (printchar, strout): Check for string overflow.
8993 (PRINTPREPARE, printchar, strout):
8994 Don't set size unless allocation succeeds.
8995
90532f02
PE
8996 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8997 for sizes. Check for string overflow more accurately.
8998 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8999
6d84508d
PE
9000 * macros.c: Integer and buffer overflow fixes.
9001 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9002 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9003 Use ptrdiff_t, not int, for sizes.
9004 Don't increment bufsize until after realloc succeeds.
9005 Check for size-calculation overflow.
9006 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9007
437b2cb4
PE
9008 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9009
8b9ac8b4
PE
9010 * lread.c: Integer overflow fixes.
9011 (read_integer): Radix is now EMACS_INT, not int,
9012 to improve quality of diagnostics for out-of-range radices.
9013 Calculate buffer size correctly for out-of-range radices.
9014 (read1): Check for integer overflow in radices, and in
9015 read-circle numbers.
82cb60d3
PE
9016 (read_escape): Avoid int overflow.
9017 (Fload, openp, read_buffer_size, read1)
9018 (substitute_object_recurse, read_vector, read_list, map_obarray):
9019 Use ptrdiff_t, not int, for sizes.
9020 (read1): Use EMACS_INT, not int, for sizes.
20270765 9021 Check for size overflow.
8b9ac8b4 9022
7fcccf1e
PE
9023 * image.c (cache_image): Check for size arithmetic overflow.
9024
bfbbd7e7
PE
9025 * lread.c: Integer overflow issues.
9026 (saved_doc_string_size, saved_doc_string_length)
9027 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9028 Now ptrdiff_t, not int.
9029 (read1): Don't assume doc string length fits in int. Check for
9030 out-of-range doc string lengths.
9031 (read_list): Don't assume file position fits in int.
39019e54 9032 (read_escape): Check for hex character overflow.
bfbbd7e7 9033
4e323265
LL
90342011-06-22 Leo Liu <sdl.web@gmail.com>
9035
9036 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9037 Move to minibuffer.el.
9038
85fece3e
PE
90392011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9040
20b84ce9 9041 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9042 The following patches are for when GLYPH_DEBUG && !XASSERT.
9043 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9044 * dispnew.c (flush_stdout):
9045 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9046 Mark as externally visible.
9047 * dispnew.c (check_window_matrix_pointers): Now static.
9048 * dispnew.c (window_to_frame_vpos):
9049 * xfns.c (unwind_create_frame):
9050 * xterm.c (x_check_font): Remove unused local.
9051 * scroll.c (CHECK_BOUNDS):
9052 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9053 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9054 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9055 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9056 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9057 Now static.
9058 (debug_method_add): Use va_list and vsprintf rather than relying
9059 on undefined behavior with wrong number of arguments.
9060 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9061 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9062 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9063 since we're not interested in debugging glyphs with old libraries.
9064 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9065 GCC 4.6.0's static checking.
9066
0766b489
PE
90672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9068
31fd4b32
PE
9069 Integer overflow and signedness fixes (Bug#8873).
9070 A few related buffer overrun fixes, too.
9071
b79e8648
PE
9072 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9073
0766b489
PE
9074 * dispextern.h (struct face.stipple):
9075 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9076 (x_bitmap_mask, x_allocate_bitmap_record)
9077 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9078 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9079 (x_create_bitmap_from_xpm_data):
9080 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9081 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9082 (.bitmaps_last):
9083 * xfaces.c (load_pixmap):
9084 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9085 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9086 (.bitmaps_last, struct x_output.icon_bitmap):
9087 Use ptrdiff_t, not int, for bitmap indexes.
9088 (x_allocate_bitmap_record): Check for size overflow.
9089 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9090
b081724f
PE
9091 Use ptrdiff_t, not int, for overlay counts.
9092 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9093 * editfns.c (overlays_around, get_pos_property):
9094 * textprop.c (get_char_property_and_overlay):
9095 * xdisp.c (next_overlay_change, note_mouse_highlight):
9096 * xfaces.c (face_at_buffer_position):
21514da7
PE
9097 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9098 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9099 (Fnext_overlay_change, Fprevious_overlay_change)
9100 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9101 Use ptrdiff_t, not int, for sizes.
21514da7 9102 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9103
3de73e5e
PE
9104 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9105
2606c57b
PE
9106 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9107 (x_session_initialize): Do not assume string length fits in int.
9108
aaafe47a
PE
9109 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9110 This is unlikely, but can occur if DPI is outlandish.
9111
2674ddc8 9112 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9113 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9114
28154962
PE
9115 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9116 * xrdb.c (magic_file_p, search_magic_path):
9117 Omit last arg SUFFIX; it was always 0. All callers changed.
9118 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9119
7de51af5
PE
9120 * xfont.c (xfont_match): Avoid need for strlen.
9121
25ed6cc3
PE
9122 * xfns.c: Don't assume strlen fits in int.
9123 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9124
4eab31dd
PE
9125 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9126 not unsigned long, as we prefer signed integers. All callers changed.
9127 Detect integer overflow in repeat count.
9128 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9129 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9130
171e2a58
PE
9131 * termcap.c: Don't assume sizes fit in int and never overflow.
9132 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9133 (gobble_line): Check for size-calculation overflow.
9134
ad39faca 9135 * minibuf.c (Fread_buffer):
6e5bb2dc 9136 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9137 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9138 Don't assume string length fits in int.
9139
52c61c22 9140 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9141 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9142
b5b8c9e5
PE
9143 * font.c: Don't assume string length fits in int.
9144 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9145 Use ptrdiff_t, not int.
ccd6111c
PE
9146 (font_intern_prop): Don't assume string length fits in int.
9147 Don't assume integer property fits in fixnum.
9148 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9149
882f0d81 9150 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9151 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9152 Reformulate so as not to need the command string.
9153 Invoke gzip -cd rather than gunzip, as it's more portable.
9154 (lock_info_type, lock_file_1, lock_file):
9155 Don't assume pid_t and time_t fit in unsigned long.
9156 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9157 (current_lock_owner): Prefer signed type for sizes.
9158 Use memcpy, not strncpy, where memcpy is what is really wanted.
9159 Don't assume (via atoi) that time_t and pid_t fit in int.
9160 Check for time_t and/or pid_t out of range, e.g., via a network share.
9161 Don't alloca where an auto var works fine.
9162
93f4cf88
PE
9163 * fileio.c: Fix some integer overflow issues.
9164 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9165 Don't assume string length fits in int.
9166 (directory_file_name): Don't assume string length fits in long.
9167 (make_temp_name): Don't assume pid fits in int, or that its print
9168 length is less than 20.
9169
f3e92b69
PE
9170 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9171
1bfdaf10
PE
9172 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9173
35016e9a
PE
9174 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9175
3d1e65a1
PE
9176 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9177 We prefer signed integers, even for size calculations.
9178
0b963a93
PE
9179 * emacs.c: Don't assume string length fits in 'int'.
9180 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9181 (main): Don't invoke strlen when not needed.
9182
573f4b54
PE
9183 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9184 (XD_DEBUG_MESSAGE): Don't waste a byte.
9185
989f33ba
PE
9186 * callproc.c (getenv_internal_1, getenv_internal)
9187 (Fgetenv_internal):
965d34eb
PE
9188 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9189
e4d29b33
PE
9190 * lread.c (invalid_syntax): Omit length argument.
9191 All uses changed. This doesn't fix a bug, but it simplifies the
9192 code away from its former Hollerith-constant appearance, and it's
9193 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9194 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9195
eb49b136
PE
9196 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9197 This didn't break anything, but it didn't help either.
9198 It's confusing to put a bogus integer in a place where the actual
9199 value does not matter.
9f62aeb1 9200 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9201 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9202
15375a22
PE
9203 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9204 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9205 implementation.
b61cc01c
PE
9206 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9207 We prefer signed types, and the value cannot exceed the EMACS_INT
9208 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9209 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9210 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9211 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9212
53b2623d
PE
9213 * indent.c (sane_tab_width): New function.
9214 (current_column, scan_for_column, Findent_to, position_indentation)
9215 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9216 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9217
51cab52b 9218 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9219
f2ed8a70
PE
9220 * lisp.h (lint_assume): New macro.
9221 * composite.c (composition_gstring_put_cache):
9222 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9223
abe80cc6
PE
9224 * editfns.c, insdel.c:
9225 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9226
b02c740e
PE
9227 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9228
ebc96716
PE
9229 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9230
b4e50fa0 9231 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9232 Use much-faster test for byte-length change.
311d5d7c 9233 Don't assume string byte-length fits in 'int'.
a4cf38e4 9234 Check that character arg fits in 'int'.
85461888 9235 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9236
c0c1ee9f
PE
9237 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9238
a498d7f4
PE
9239 * fns.c (concat): Catch string overflow earlier.
9240 Do not rely on integer wraparound.
9241
51cab52b
PE
9242 * dispextern.h (struct it.overlay_strings_charpos)
9243 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9244 * xdisp.c (forward_to_next_line_start)
9245 (back_to_previous_visible_line_start)
9246 (reseat_at_next_visible_line_start, next_element_from_buffer):
9247 Don't arbitrarily truncate the value of 'selective' to int.
9248
76031fad
PE
9249 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9250
5eb55db9
PE
9251 * composite.c: Don't truncate sizes to 'int'.
9252 (composition_gstring_p, composition_reseat_it)
9253 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9254 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9255 not EMACS_UINT, for indexes.
5eb55db9 9256
0703a717
PE
9257 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9258
d6202519
PE
9259 * buffer.c: Include <verify.h>.
9260 (struct sortvec.priority, struct sortstr.priority):
8961a454 9261 Now EMACS_INT, not int.
c20998a7 9262 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9263 (struct sortstr.size, record_overlay_string)
9264 (struct sortstrlist.size, struct sortlist.used):
9265 Don't truncate size to int.
9266 (record_overlay_string): Check for size-calculation overflow.
d6202519 9267 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9268
d5a19415
JM
92692011-06-22 Jim Meyering <meyering@redhat.com>
9270
029529ac 9271 Don't leak an XBM-image-sized buffer
d5a19415
JM
9272 * image.c (xbm_load): Free the image buffer after using it.
9273
a9041e6c
PE
92742011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9275
9276 Port to Sun C.
9277 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9278 that Sun C diagnosed.
9279 * fns.c (secure_hash): Fix pointer signedness issue.
9280 * intervals.c (static_offset_intervals): New function.
9281 (offset_intervals): Use it.
9282
7f3f739f
LL
92832011-06-21 Leo Liu <sdl.web@gmail.com>
9284
9285 * deps.mk (fns.o):
9286 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9287 sha512.h.
9288
9289 * fns.c (secure_hash): Rename from crypto_hash_function and change
9290 the first arg to accept symbols.
5b66d427 9291 (Fsecure_hash): New primitive.
7f3f739f
LL
9292 (syms_of_fns): New symbols.
9293
76147d94
DD
92942011-06-20 Deniz Dogan <deniz@dogan.se>
9295
9296 * process.c (Fset_process_buffer): Clarify return value in
9297 docstring.
9298
7d7d0045
CY
92992011-06-18 Chong Yidong <cyd@stupidchicken.com>
9300
9301 * dispnew.c (add_window_display_history): Use BVAR.
9302
9303 * xdisp.c (debug_method_add): Use BVAR.
9304 (check_window_end, dump_glyph_matrix, dump_glyph)
9305 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9306
9307 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9308 Likewise.
9309
9310 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9311 check till after the cache is created in init_frame_faces.
9312
ff2bc410
SM
93132011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9314
9315 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9316
28177add
PE
93172011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9318
dd3482fe
PE
9319 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9320 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9321 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9322
393d71f3 9323 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9324 * fileio.c (Finsert_file_contents):
9325 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9326 Remove the old (too-loose) buffer overflow checks.
9327 They weren't needed, since make_gap checks for buffer overflow.
9328 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9329 The old code merely checked for Emacs fixnum overflow, and relied
9330 on undefined (wraparound) behavior. The new code avoids undefined
9331 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9332
2e6813b0 9333 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9334 Tune. Don't use wider integers than needed. Don't use alloca.
9335 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9336
599a9e4f
PE
9337 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9338
99561444
PE
9339 * insdel.c, lisp.h (buffer_overflow): New function.
9340 (insert_from_buffer_1, replace_range, replace_range_2):
9341 * insdel.c (make_gap_larger):
9342 * editfns.c (Finsert_char):
9343 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9344
28177add
PE
9345 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9346
e69dafad
PE
93472011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9348
4baa020d 9349 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9350
b1c46f02
PE
9351 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9352 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9353
e69dafad
PE
9354 * fileio.c: Don't assume EMACS_INT fits in off_t.
9355 (emacs_lseek): New static function.
9356 (Finsert_file_contents, Fwrite_region): Use it.
9357 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9358
566684ea
PE
9359 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9360
e6966cd6
PE
9361 * fns.c: Don't overflow int when computing a list length.
9362 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9363 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9364 truncation on 64-bit hosts. Check for QUIT every
9365 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9366 faster and is responsive enough.
9367 (Flength): Report an error instead of overflowing an integer.
9368 (Fsafe_length): Return a float if the value is not representable
9369 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9370 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9371 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9372
dd0b0efb
PE
9373 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9374 (header_size, word_size): New constants.
9375 (allocate_vectorlike): Don't check size overflow here.
9376 (allocate_vector): Check it here instead, since this is the only
9377 caller of allocate_vectorlike that could cause overflow.
9378 Check that the new vector's length is representable as a fixnum.
9379
86fe5cfe
PE
9380 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9381 The previous code was bogus. For example, next_almost_prime (32)
9382 returned 39, which is undesirable as it is a multiple of 3; and
9383 next_almost_prime (24) returned 25, which is a multiple of 5 so
9384 why was the code bothering to check for multiples of 7?
9385
80e88859
PE
9386 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9387
4a2f0ad6
PE
9388 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9389
f66c7cf8
PE
9390 Variadic C functions now count arguments with ptrdiff_t.
9391 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9392 Back then I didn't know that the Emacs coding style prefers signed int.
9393 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9394 were being counted with int, which may truncate counts on 64-bit
9395 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9396 * lisp.h (struct Lisp_Subr.function.aMANY)
9397 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9398 Arg counts are now ptrdiff_t, not size_t.
9399 All variadic functions and their callers changed accordingly.
9400 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9401 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9402 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9403 * callint.c (Fcall_interactively): Check arg count for overflow,
9404 to avoid potential buffer overrun. Use signed char, not 'int',
9405 for 'varies' array, so that we needn't bother to check its size
9406 calculation for overflow.
9407 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9408 * eval.c (apply_lambda):
9409 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9410 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9411 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9412
a1759b76
PE
9413 * callint.c (Fcall_interactively): Don't use index var as event count.
9414
d96be9fc
PE
9415 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9416 * mem-limits.h (SIZE): Remove; no longer used.
9417
a690a978 9418 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9419
578c21e6
PE
9420 Remove unnecessary casts.
9421 * xterm.c (x_term_init):
9422 * xfns.c (x_set_border_pixel):
9423 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9424 These aren't needed now that we assume ANSI C.
9425
96f53c6c
PE
9426 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9427 It's more likely to cause problems (due to unsigned overflow)
9428 than to cure them.
9429
83c77d31
PE
9430 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9431
ee2079f1
PE
9432 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9433
6da65536
PE
9434 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9435
7147c4a4
PE
9436 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9437
193e32d9
PE
9438 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9439
e5533da6
PE
9440 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9441
9910e595
PE
9442 GLYPH_CODE_FACE returns EMACS_INT, not int.
9443 * dispextern.h (merge_faces):
9444 * xfaces.c (merge_faces):
01103c44
PE
9445 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9446 Don't assume EMACS_INT fits in int.
9910e595 9447
2638320e
PE
9448 * character.h (CHAR_VALID_P): Remove unused parameter.
9449 * fontset.c, lisp.h, xdisp.c: All uses changed.
9450
045eb8d9
PE
9451 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9452
c1f134b5
PE
9453 * fns.c (concat): Minor tuning based on overflow analysis.
9454 This doesn't fix any bugs. Use int to hold character, instead
9455 of constantly refetching from Emacs object. Use XFASTINT, not
9456 XINT, for value known to be a character. Don't bother comparing
9457 a single byte to 0400, as it's always less.
9458
395fcb93 9459 * floatfns.c (Fexpt):
327eeec8
PE
9460 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9461
abbd3d23
PE
9462 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9463 for characters.
9464
684a03ef
PE
9465 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9466
0fed43f3
PE
9467 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9468 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9469 incorrectly succeed when S was a string, because 4294967386 was
9470 truncated before it was used.
9471
8fd02eb7
PE
9472 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9473 Otherwise, an out-of-range integer could cause undefined behavior
9474 on a 64-bit host.
9475
f8c86b69
PE
9476 * composite.c: Use int, not EMACS_INT, for characters.
9477 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9478 EMACS_INT, for values that are known to be in character range.
9479 This doesn't fix any bugs but is the usual style inside Emacs and
9480 may generate better code on 32-bit machines.
9481
34206dd2
PE
9482 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9483 This is for reasons similar to the recent CHAR_STRING fix.
9484 * charset.c (Fencode_char): Check that character arg is actually
9485 a character. Pass an int to ENCODE_CHAR.
9486 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9487 wider than 'int', as a compile-time check to prevent future regressions
9488 in this area.
9489
c5958d4c 9490 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9491
9492 Make sure a 64-bit char is never passed to CHAR_STRING.
9493 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9494 by silently ignoring the top 32 bits, allowing some values
9495 that were far too large to be valid characters.
9496 * character.h: Include <verify.h>.
9497 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9498 arguments are no wider than unsigned, as a compile-time check
9499 to prevent future regressions in this area.
9500 * data.c (Faset):
01103c44 9501 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9502 (Fsubst_char_in_region):
9503 * fns.c (concat):
9504 * xdisp.c (decode_mode_spec_coding):
9505 Adjust to CHAR_STRING's new requirement.
9506 * editfns.c (Finsert_char, Fsubst_char_in_region):
9507 * fns.c (concat): Check that character args are actually
9508 characters. Without this test, these functions did the wrong
9509 thing with wildly out-of-range values on 64-bit hosts.
9510
d37ca623
PE
9511 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9512 These casts should not be needed on 32-bit hosts, either.
9513 * keyboard.c (read_char):
9514 * lread.c (Fload): Remove casts to unsigned.
9515
ea204efb
PE
9516 * lisp.h (UNSIGNED_CMP): New macro.
9517 This fixes comparison bugs on 64-bit hosts.
9518 (ASCII_CHAR_P): Use it.
9519 * casefiddle.c (casify_object):
01103c44 9520 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9521 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9522 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9523 * dispextern.h (FACE_FROM_ID):
9524 * keyboard.c (read_char): Use UNSIGNED_CMP.
9525
41cb286c
PE
9526 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9527 not to EMACS_INT, to avoid GCC warning.
9528
4a1b9832
PE
9529 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9530
55daad71
PE
9531 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9532 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9533 isn't needed on 32-bit machines.
8f95c75c 9534
01103c44
PE
9535 * buffer.c (Fgenerate_new_buffer_name):
9536 Use EMACS_INT for count, not int.
0ceccced 9537 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9538
9539 * data.c (Qcompiled_function): Now static.
9540
c6f072e7
PE
9541 * window.c (window_body_lines): Now static.
9542
20ce5912
PE
9543 * image.c (gif_load): Rename local to avoid shadowing.
9544
9c4c5f81
PE
9545 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9546 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9547 * alloc.c (make_save_value): Integer argument is now of type
9548 ptrdiff_t, not int.
9549 (mark_object): Use ptrdiff_t, not int.
9550 * lisp.h (pD): New macro.
9551 * print.c (print_object): Use it.
9552
c0c5c8ae
PE
9553 * alloc.c: Use EMACS_INT, not int, to count objects.
9554 (total_conses, total_markers, total_symbols, total_vector_size)
9555 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9556 (total_free_floats, total_floats, total_free_intervals)
9557 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9558 Now EMACS_INT, not int. All uses changed.
9559 (Fgarbage_collect): Compute overall total using a double, so that
9560 integer overflow is less likely to be a problem. Check for overflow
9561 when converting back to an integer.
5a25e253
PE
9562 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9563 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9564 These were 'int' variables that could overflow on 64-bit hosts;
9565 they were never used, so remove them instead of repairing them.
211a0b2a 9566 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9567 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9568 Previously, this ceilinged at INT_MAX, but that doesn't work on
9569 64-bit machines.
e46bb31a 9570 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9571
c78baabf 9572 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9573 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9574 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9575 when a (possibly-narrower) signed value would do just as well.
9576 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9577
c9d624c6
PE
9578 * alloc.c: Catch some string size overflows that we were missing.
9579 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9580 for convenience in STRING_BYTES_MAX.
9581 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9582 The definition here is exact; the one in lisp.h was approximate.
9583 (allocate_string_data): Check for string overflow. This catches
9584 some instances we weren't catching before. Also, it catches
9585 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9586 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9587 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9588
c9d624c6
PE
9589 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9590 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9591 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9592
353032ce
PE
9593 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9594
2bccce07
PE
9595 * alloc.c (Fmake_string): Check for out-of-range init.
9596
0ac30604
SM
95972011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9598
9599 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9600
c195f2de
JD
96012011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9602
9603 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9604 xg_get_default_scrollbar_width.
9605
9606 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9607 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9608 (style_changed_cb): Call update_theme_scrollbar_width and call
9609 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9610 all frames (Bug#8505).
9611 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9612 Call gtk_window_set_resizable if HAVE_GTK3.
9613 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9614 and height if HAVE_GTK3 (Bug#8505).
9615 (scroll_bar_width_for_theme): New variable.
9616 (update_theme_scrollbar_width): New function.
9617 (xg_get_default_scrollbar_width): Move code to
9618 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9619 (xg_initialize): Call update_theme_scrollbar_width.
9620
9621 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9622
9623 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9624
e10ac9f1
MR
96252011-06-12 Martin Rudalics <rudalics@gmx.at>
9626
9627 * frame.c (make_frame): Call other_buffer_safely instead of
9628 other_buffer.
9629
9630 * window.c (temp_output_buffer_show): Call display_buffer with
9631 second argument Vtemp_buffer_show_specifiers and reset latter
9632 immediately after the call.
9633 (Vtemp_buffer_show_specifiers): New variable.
9634 (auto_window_vscroll_p, next_screen_context_lines)
9635 (Vscroll_preserve_screen_position): Remove leading asterisks from
9636 doc-strings.
9637
2d3c217e 96382011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9639
7b7f97e8 9640 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9641 * buffer.c (Qclone_number): Remove for now, as it's unused.
9642 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9643 (record_buffer): Remove unused local.
9644 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9645 (set_frame_buffer_list): Remove; unused.
9646 * frame.h (other_visible_frames): Remove decl.
9647 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9648 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9649 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9650 if HAVE_GPM.
9651 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9652 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9653 Define only if HAVE_GPM.
9654 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9655 (update_hints_inhibit): Remove; never set. All uses removed.
9656 * widgetprv.h (emacsFrameClassRec): Remove decl.
9657 * window.c (delete_deletable_window): Now returns void, since it
9658 wasn't returning anything.
9659 (compare_window_configurations): Remove unused locals.
9660 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9661 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9662 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9663 the same widths as pointers. This follows up on the 2011-05-06 patch.
9664 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9665 * xterm.h: Likewise.
9666 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9667
1384b89e
JB
96682011-06-12 Juanma Barranquero <lekktu@gmail.com>
9669
9670 * makefile.w32-in: Update dependencies.
9671 (LISP_H): Add lib/intprops.h.
9672
1100a63c
CY
96732011-06-11 Chong Yidong <cyd@stupidchicken.com>
9674
9675 * image.c (gif_load): Add animation frame delay to the metadata.
9676 (syms_of_image): Use DEFSYM. New symbol `delay'.
9677
6198ccd0
MR
96782011-06-11 Martin Rudalics <rudalics@gmx.at>
9679
9680 * window.c (delete_deletable_window): Re-add.
9681 (Fset_window_configuration): Rewrite to handle dead buffers and
9682 consequently deletable windows.
9683 (window_tree, Fwindow_tree): Remove. Supply functionality in
9684 window.el.
9685 (compare_window_configurations): Simplify code.
9686
b6e3633c
AS
96872011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9688
1ab0dee5
AS
9689 * image.c (imagemagick_load_image): Fix type mismatch.
9690 (Fimagemagick_types): Likewise.
9691
b6e3633c
AS
9692 * window.h (replace_buffer_in_windows): Declare.
9693
9397e56f
MR
96942011-06-11 Martin Rudalics <rudalics@gmx.at>
9695
9696 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9697 Qclone_number. Remove external declaration of Qdelete_window.
9698 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9699 code.
640c8776
SM
9700 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9701 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9702 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9703 buffer list implementation.
9704 (other_buffer_safely): New function.
9705 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9706 calls to replace_buffer_in_windows and
9707 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9708 if allowed.
9709 (record_buffer): Inhibit quitting and rewrite using quittable
9710 functions. Run Qbuffer_list_update_hook if allowed.
9711 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9712 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9713 Move switch-to-buffer to window.el.
9397e56f
MR
9714 (bury-buffer): Move to window.el.
9715 (Vbuffer_list_update_hook): New variable.
9716
9717 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9718 section.
9719
9720 * window.h (resize_frame_windows): Move up in code.
9721 (Fwindow_frame): Remove EXFUN.
9722 (replace_buffer_in_all_windows): Remove prototype.
9723 (replace_buffer_in_windows_safely): Add prototype.
9724
9725 * window.c: Declare Qdelete_window static again. Move down
9726 declaration of select_count.
9727 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9728 (Fother_window): Move to window.el.
9729 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9730 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9731 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9732 window.el.
9733 (replace_buffer_in_windows): Implement by calling
9734 Qreplace_buffer_in_windows.
9735 (replace_buffer_in_all_windows): Remove with some functionality
9736 moved into replace_buffer_in_windows_safely.
9737 (replace_buffer_in_windows_safely): New function.
9738 (select_window_norecord, select_frame_norecord): Move in front
9739 of run_window_configuration_change_hook. Remove now obsolete
9740 declarations.
640c8776
SM
9741 (Fset_window_buffer): Rewrite doc-string.
9742 Call Qrecord_window_buffer.
9397e56f
MR
9743 (keys_of_window): Move binding for other-window to window.el.
9744
b50691aa
CY
97452011-06-11 Chong Yidong <cyd@stupidchicken.com>
9746
9747 * dispextern.h (struct image): Replace data member, whose int_val
9748 and ptr_val fields were not used by anything, with a single
9749 lisp_val object.
9750
9751 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9752 (gif_clear_image, gif_load, imagemagick_load_image)
9753 (gs_clear_image, gs_load): Callers changed.
9754
3f754b86
PE
97552011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9756
cca69397
PE
9757 * buffer.h: Include <time.h>, for time_t.
9758 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9759
109e28d0
PE
9760 Fix minor problems found by static checking.
9761
60737f02
PE
9762 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9763
4b66faf3
PE
9764 Make identifiers static if they are not used in other modules.
9765 * data.c (Qcompiled_function, Qframe, Qvector):
9766 * image.c (QimageMagick, Qsvg):
9767 * minibuf.c (Qmetadata):
9768 * window.c (resize_window_check, resize_root_window): Now static.
9769 * window.h (resize_window_check, resize_root_window): Remove decls.
9770
109e28d0
PE
9771 * window.c (window_deletion_count, delete_deletable_window):
9772 Remove; unused.
46a4ce9e
PE
9773 (window_body_lines): Now static.
9774 (Fdelete_other_windows_internal): Mark vars as initialized.
9775 Make sure 'resize_failed' is initialized.
9776 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9777 (resize_window_apply): Remove unused local.
9778 * window.h (delete_deletable_window): Remove decl.
9779
109e28d0 9780 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9781 (imagemagick_load_image): Fix pointer signedness problem by changing
9782 last arg from unsigned char * to char *. All uses changed.
9783 Also, fix a local for similar reasons.
9784 Remove unused locals. Remove locals to avoid shadowing.
9785 (fn_rsvg_handle_free): Remove; unused.
9786 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9787 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9788
3f754b86
PE
9789 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9790
2547adb1
CY
97912011-06-10 Chong Yidong <cyd@stupidchicken.com>
9792
9793 * image.c (gif_load): Fix omitted cast error introduced by
9794 2011-06-06 change.
9795
2c8e37d4
MR
97962011-06-10 Martin Rudalics <rudalics@gmx.at>
9797
9798 * window.h (resize_proportionally, orig_total_lines)
9799 (orig_top_line): Remove from window structure.
9800 (set_window_height, set_window_width, change_window_heights)
9801 (Fdelete_window): Remove prototypes.
9802 (resize_frame_windows): Remove duplicate declaration.
9803
440a42e3
EZ
98042011-06-10 Eli Zaretskii <eliz@gnu.org>
9805
9806 * window.h (resize_frame_windows, resize_window_check)
9807 (delete_deletable_window, resize_root_window)
9808 (resize_frame_windows): Declare prototypes.
9809
9810 * window.c (resize_window_apply): Make definition be "static" to
9811 match the prototype.
9812
562dd5e9
MR
98132011-06-10 Martin Rudalics <rudalics@gmx.at>
9814
9815 * window.c: Remove declarations of Qwindow_size_fixed,
9816 window_min_size_1, window_min_size_2, window_min_size,
9817 size_window, window_fixed_size_p, enlarge_window, delete_window.
9818 Remove static from declaration of Qdelete_window, it's
9819 temporarily needed by Fbury_buffer.
9820 (replace_window): Don't assign orig_top_line and
9821 orig_total_lines.
9822 (Fdelete_window, delete_window): Remove. Window deletion is
9823 handled by window.el.
640c8776
SM
9824 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9825 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9826 (Fdelete_other_windows): Remove. Deleting other windows is
9827 handled by window.el.
9828 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9829 handled in window.el.
9830 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9831 Window minimum sizes are handled in window.el.
9832 (shrink_windows, size_window, set_window_height)
9833 (set_window_width, change_window_heights, window_height)
9834 (window_width, CURBEG, CURSIZE, enlarge_window)
9835 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9836 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9837 handled in window.el.
9838 (make_dummy_parent): Rename to make_parent_window and give it a
9839 second argument horflag.
9840 (make_window): Don't set resize_proportionally any more.
9841 (Fsplit_window): Remove. Windows are split in window.el.
9842 (save_restore_action, save_restore_orig_size)
9843 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9844 Resize mini windows in window.el.
9845 (grow_mini_window, shrink_mini_window): Implement by calling
9846 Qresize_root_window_vertically, resize_window_check and
9847 resize_window_apply.
640c8776
SM
9848 (saved_window, Fset_window_configuration, save_window_save):
9849 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9850 resize_proportionally.
9851 (window_min_height, window_min_width): Move to window.el.
9852 (keys_of_window): Move bindings for delete-other-windows,
9853 split-window, delete-window and enlarge-window to window.el.
9854
9855 * buffer.c: Temporarily extern Qdelete_window.
9856 (Fbury_buffer): Temporarily call Qdelete_window instead of
9857 Fdelete_window (Fbury_buffer will move to window.el soon).
9858
9859 * frame.c (set_menu_bar_lines_1): Remove code handling
9860 orig_top_line and orig_total_lines.
9861
9862 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9863 set_window_height but set heights directly.
9864 (change_frame_size_1): Use resize_frame_windows.
9865
9866 * xdisp.c (init_xdisp): Don't use set_window_height but set
9867 heights directly.
9868
640c8776
SM
9869 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9870 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9871 run_window_configuration_change_hook.
9872
9873 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9874 instead of change_window_heights and run
9875 run_window_configuration_change_hook.
9876
1a13852e
MR
98772011-06-09 Martin Rudalics <rudalics@gmx.at>
9878
9879 * window.c (replace_window): Rename second argument REPLACEMENT to
9880 NEW. New third argument SETFLAG. Rewrite.
9881 (delete_window, make_dummy_parent): Call replace_window with
9882 third argument 1.
9883 (window_list_1): Move down in code.
9884 (run_window_configuration_change_hook): Move set_buffer part
9885 before select_frame_norecord part in order to unwind correctly.
9886 Rename count1 to count.
9887 (recombine_windows, delete_deletable_window, resize_root_window)
9888 (Fdelete_other_windows_internal)
9889 (Frun_window_configuration_change_hook, make_parent_window)
9890 (resize_window_check, resize_window_apply, Fresize_window_apply)
9891 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9892 (Fdelete_window_internal, Fresize_mini_window_internal):
9893 New functions.
1a13852e
MR
9894 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9895
f3d1777e
MR
98962011-06-08 Martin Rudalics <rudalics@gmx.at>
9897
496e208e
MR
9898 * window.h (window): Add some new members to window structure -
9899 normal_lines, normal_cols, new_total, new_normal, clone_number,
9900 splits, nest, prev_buffers, next_buffers.
9901 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9902 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9903
f3d1777e
MR
9904 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9905 Remove.
496e208e
MR
9906 (make_dummy_parent): Set new members of windows structure.
9907 (make_window): Move down in code. Handle new members of window
9908 structure.
9909 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9910 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9911 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9912 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9913 (Fset_window_next_buffers, Fset_window_clone_number):
9914 New functions.
496e208e
MR
9915 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9916 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9917 Doc-string fixes.
9918 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9919 Argument WINDOW can be now internal window too.
9920 (Fwindow_use_time): Move up in code.
9921 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9922 Rewrite doc-string.
9923 (Fset_window_configuration, saved_window)
9924 (Fcurrent_window_configuration, save_window_save): Handle new
9925 members of window structure.
b9e809c2
MR
9926 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9927 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9928 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9929 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9930 Qget_mru_window, Qresize_root_window,
9931 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9932 Qauto_buffer_name; staticpro them.
f3d1777e 9933
abde8f8c
MR
99342011-06-07 Martin Rudalics <rudalics@gmx.at>
9935
9936 * window.c (Fwindow_total_size, Fwindow_left_column)
9937 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9938 (Fwindow_list_1): New functions.
9939 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9940 (Fwindow_width, Fscroll_left, Fscroll_right):
9941 Use window_body_cols instead of window_box_text_cols.
9942 (delete_window, Fset_window_configuration):
9943 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9944 (delete_all_subwindows): Take a window as argument and not a
9945 structure. Rewrite.
190b47e6
MR
9946 (window_loop): Remove handling of GET_LRU_WINDOW and
9947 GET_LARGEST_WINDOW.
9948 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9949
9950 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9951 window_box_text_cols. delete_all_subwindows now takes a
9952 Lisp_Object as argument.
abde8f8c 9953
640c8776
SM
9954 * indent.c (compute_motion, Fcompute_motion):
9955 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9956
fa8a67e6
MR
9957 * frame.c (delete_frame): Call delete_all_subwindows with root
9958 window as argument.
9959
a54e3482
DC
99602011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9961
9962 * fns.c (Fputhash): Document return value.
9963
60002bf5
CY
99642011-06-06 Chong Yidong <cyd@stupidchicken.com>
9965
9966 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9967
0c671da6 99682011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9969
b862a52a 9970 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9971
be44ca6c
PE
9972 Check for overflow when converting integer to cons and back.
9973 * charset.c (Fdefine_charset_internal, Fdecode_char):
9974 Use cons_to_unsigned to catch overflow.
9975 (Fencode_char): Use INTEGER_TO_CONS.
9976 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9977 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9978 * data.c (long_to_cons, cons_to_long): Remove.
9979 (cons_to_unsigned, cons_to_signed): New functions.
9980 These signal an error for invalid or out-of-range values.
9981 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9982 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9983 * font.c (Ffont_variation_glyphs):
9984 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9985 * lisp.h: Include <intprops.h>.
9986 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9987 (cons_to_signed, cons_to_unsigned): New decls.
9988 (long_to_cons, cons_to_long): Remove decls.
9989 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9990 (Fprimitive_undo): Use CONS_TO_INTEGER.
9991 * xfns.c (Fx_window_property): Likewise.
9992 * xselect.c: Include <limits.h>.
9993 (x_own_selection, selection_data_to_lisp_data):
9994 Use INTEGER_TO_CONS.
9995 (x_handle_selection_request, x_handle_selection_clear)
9996 (x_get_foreign_selection, Fx_disown_selection_internal)
9997 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9998 (lisp_data_to_selection_data): Use cons_to_unsigned.
9999 (x_fill_property_data): Use cons_to_signed.
10000 Report values out of range.
10001
d1f3d2af
PE
10002 Check for buffer and string overflow more precisely.
10003 * buffer.h (BUF_BYTES_MAX): New macro.
10004 * lisp.h (STRING_BYTES_MAX): New macro.
10005 * alloc.c (Fmake_string):
10006 * character.c (string_escape_byte8):
10007 * coding.c (coding_alloc_by_realloc):
10008 * doprnt.c (doprnt):
10009 * editfns.c (Fformat):
10010 * eval.c (verror):
10011 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10012 since they may not be the same number.
10013 * editfns.c (Finsert_char):
10014 * fileio.c (Finsert_file_contents):
10015 Likewise for BUF_BYTES_MAX.
10016
dd52fcea
PE
10017 * image.c: Use ptrdiff_t, not int, for sizes.
10018 (slurp_file): Switch from int to ptrdiff_t.
10019 All uses changed.
10020 (slurp_file): Check that file size fits in both size_t (for
10021 malloc) and ptrdiff_t (for sanity and safety).
10022
7f9bbdbb
PE
10023 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10024 if b->modtime has its maximal value.
10025
dfe18f82
PE
10026 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10027
84acfcf0
PE
10028 Don't assume time_t can fit into int.
10029 * buffer.h (struct buffer.modtime): Now time_t, not int.
10030 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10031 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10032
ccd9a01a
PE
10033 Minor fixes for signed vs unsigned integers.
10034 * character.h (MAYBE_UNIFY_CHAR):
10035 * charset.c (maybe_unify_char):
10036 * keyboard.c (read_char, reorder_modifiers):
10037 XINT -> XFASTINT, since the integer must be nonnegative.
10038 * ftfont.c (ftfont_spec_pattern):
10039 * keymap.c (access_keymap, silly_event_symbol_error):
10040 XUINT -> XFASTINT, since the integer must be nonnegative.
10041 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10042 since it makes no difference and we prefer signed.
10043 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10044 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10045 nonnegative.
10046
d6d100dd
SM
100472011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10048
10049 * window.h (Fwindow_frame): Declare.
10050
2b6148e4
PE
100512011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10052
10053 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10054 (SPARE_MEMORY): Always define.
10055 (LARGE_REQUEST): Remove.
10056 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10057
f230ecc9
MR
100582011-06-06 Martin Rudalics <rudalics@gmx.at>
10059
727e958e
MR
10060 * lisp.h: Move EXFUNS for Fframe_root_window,
10061 Fframe_first_window and Fset_frame_selected_window to window.h.
10062
10063 * window.h: Move EXFUNS for Fframe_root_window,
10064 Fframe_first_window and Fset_frame_selected_window here from
10065 lisp.h.
10066
10067 * frame.c (Fwindow_frame, Fframe_first_window)
10068 (Fframe_root_window, Fframe_selected_window)
10069 (Fset_frame_selected_window): Move to window.c.
10070 (Factive_minibuffer_window): Move to minibuf.c.
10071 (Fother_visible_frames_p): New function.
10072
10073 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10074
f230ecc9
MR
10075 * window.c (decode_window, decode_any_window): Move up in code.
10076 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10077 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10078 (Fwindow_buffer): Move up and rewrite doc-string.
10079 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10080 (Fwindow_prev): New functions.
727e958e
MR
10081 (Fwindow_frame): Move here from frame.c. Accept any window as
10082 argument.
10083 (Fframe_root_window, Fframe_first_window)
10084 (Fframe_selected_window): Move here from frame.c. Accept frame
10085 or arbitrary window as argument. Update doc-strings.
10086 (Fminibuffer_window): Move up in code.
10087 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10088 (Fset_frame_selected_window): Move here from frame.c.
10089 Marginal rewrite.
727e958e
MR
10090 (Fselected_window, select_window, Fselect_window): Move up in
10091 code. Minor doc-string fixes.
f230ecc9 10092
4d09bcf6
PE
100932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10094
10095 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10096 Do not assume that spare memory exists; that assumption is valid
10097 only if SYSTEM_MALLOC.
10098 (LARGE_REQUEST): New macro, so that the issue of large requests
10099 is separated from the issue of spare memory.
10100
810928a2
AS
101012011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10102
172418ad
AS
10103 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10104 format. (Bug#8806)
10105
43f862f7
AS
10106 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10107
810928a2
AS
10108 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10109 before statements.
10110
a059fe24
JD
101112011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10112
10113 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10114
10115 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10116
10117 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10118 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10119
989bf368
JB
101202011-06-05 Juanma Barranquero <lekktu@gmail.com>
10121
10122 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10123
4b80f674
CY
101242011-06-04 Chong Yidong <cyd@stupidchicken.com>
10125
10126 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10127 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10128 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10129 New error handlers.
4b80f674
CY
10130 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10131 Obey Vx_select_enable_clipboard_manager. Catch errors in
10132 x_clipboard_manager_save (Bug#8779).
10133 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10134 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10135
99a33b77 101362011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10137
10138 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10139
99a33b77 101402011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10141
10142 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10143 in the current matrix if keep_current_p is non-zero.
10144
8264569d
EZ
101452011-06-04 Eli Zaretskii <eliz@gnu.org>
10146
10147 * bidi.c (bidi_level_of_next_char): Fix last change.
10148
57f97249
EZ
101492011-06-03 Eli Zaretskii <eliz@gnu.org>
10150
fec2107c 10151 Support bidi reordering of text covered by display properties.
57f97249 10152
fec2107c
EZ
10153 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10154 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10155 (bidi_cache_search, bidi_cache_iterator_state)
10156 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10157 (bidi_level_of_next_char, bidi_move_to_visually_next):
10158 Support character positions inside a run of characters covered by a
fec2107c
EZ
10159 display string.
10160 (bidi_paragraph_init, bidi_resolve_explicit_1)
10161 (bidi_level_of_next_char): Call bidi_fetch_char and
10162 bidi_fetch_char_advance instead of FETCH_CHAR and
10163 FETCH_CHAR_ADVANCE.
10164 (bidi_init_it): Initialize new members.
10165 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10166 definitions.
10167 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10168 instead of using explicit *_CHAR codes.
d6d100dd
SM
10169 (bidi_resolve_explicit, bidi_resolve_weak):
10170 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10171 bidirectional text is supported only in multibyte buffers.
10172 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10173 it to initialize the frame_window_p member of struct bidi_it.
10174 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10175 (bidi_resolve_explicit, bidi_resolve_weak)
10176 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10177 bidi_it->nchars is non-positive.
10178 (bidi_level_of_next_char): Don't try to lookup the cache for the
10179 next/previous character if nothing is cached there yet, or if we
10180 were just reseat()'ed to a new position.
c40e2fb2 10181
0e14fe90
EZ
10182 * xdisp.c (set_cursor_from_row): Set start and stop points
10183 according to the row's direction when priming the loop that looks
10184 for the glyph on which to display cursor.
10185 (single_display_spec_intangible_p): Function deleted.
10186 (display_prop_intangible_p): Reimplement to call
10187 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10188 Accept 3 additional arguments needed by handle_display_spec.
10189 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10190 values: lists, `(when COND...)' forms, etc.
10191 (single_display_spec_string_p): Support property values that are
10192 lists with the argument STRING its top-level element.
10193 (display_prop_string_p): Fix the condition for processing a
10194 property that is a list to be consistent with handle_display_spec.
fec2107c 10195 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10196 last portion of handle_display_prop.
10197 (compute_display_string_pos): Accept additional argument
10198 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10199 value of a `display' property is a "replacing spec".
10200 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10201 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10202 the display property, but just return a value indicating whether
10203 the display property will replace the characters it covers.
10204 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10205 frame_window_p members of struct bidi_it.
d6d100dd
SM
10206 (compute_display_string_pos, compute_display_string_end):
10207 New functions.
fec2107c
EZ
10208 (push_it): Accept second argument POSITION, where pop_it should
10209 jump to continue iteration.
10210 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10211
fec2107c
EZ
10212 * keyboard.c (adjust_point_for_property): Adjust the call to
10213 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10214
10215 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10216 (bidi_init_it): Update prototypes.
10217 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10218 (compute_display_string_pos, compute_display_string_end):
10219 Declare prototypes.
fec2107c
EZ
10220 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10221 EMACS_INT.
fc6f18ce 10222
40087514 102232011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10224
57f53182
PE
10225 Malloc failure behavior now depends on size of allocation.
10226 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10227 * lisp.h: Change signatures accordingly.
10228 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10229 All callers changed. (Bug#8762)
10230
10231 * gnutls.c: Use Emacs's memory allocators.
10232 Without this change, the gnutls library would invoke malloc etc.
10233 directly, which causes problems on non-SYNC_INPUT hosts, and which
10234 runs afoul of improving memory_full behavior. (Bug#8761)
10235 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10236 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10237 xfree instead of the default malloc, realloc, free.
10238 (Fgnutls_boot): No need to check for memory allocation failure,
10239 since xmalloc does that for us.
10240
ac32cd99 10241 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10242 * category.c (hash_get_category_set):
10243 * ccl.c (ccl_driver):
10244 * charset.c (Fdefine_charset_internal):
10245 * charset.h (struct charset.hash_index):
10246 * composite.c (get_composition_id, gstring_lookup_cache)
10247 (composition_gstring_put_cache):
10248 * composite.h (struct composition.hash_index):
10249 * dispextern.h (struct image.hash):
10250 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10251 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10252 (hashfn_equal, hashfn_user_defined, make_hash_table)
10253 (maybe_resize_hash_table, hash_lookup, hash_put)
10254 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10255 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10256 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10257 * image.c (make_image, search_image_cache, lookup_image)
10258 (xpm_put_color_table_h):
10259 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10260 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10261 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10262 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10263 * alloc.c (allocate_vectorlike):
10264 Check for overflow in vector size calculations.
10265 * ccl.c (ccl_driver):
10266 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10267 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10268 need to be updated by these changes.
40087514
PE
10269 * fns.c (make_hash_table, maybe_resize_hash_table):
10270 Check for integer overflow with large hash tables.
0de4bb68
PE
10271 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10272 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10273 (SXHASH_REDUCE): New macro.
10274 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10275 Use it instead of discarding useful hash info with large hash values.
10276 (sxhash_float): New function.
10277 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10278 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10279 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10280 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10281 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10282 Adjust signatures to match updated version of code.
10283 (consing_since_gc): Now EMACS_INT, since a single hash table can
10284 use more than INT_MAX bytes.
10285
698d32e2
DN
102862011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10287
10288 Make it possible to build with GCC-4.6+ -O2 -flto.
10289
10290 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10291
fd6fa53f
SM
102922011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10293
10294 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10295 Call minibuffer-inactive-mode.
10296
864db017
JB
102972011-05-31 Juanma Barranquero <lekktu@gmail.com>
10298
10299 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10300 Update dependencies.
10301
2ad0baf4
DN
103022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10303
10304 * data.c (init_data): Remove code for UTS, this system is not
10305 supported anymore.
10306
4fcc2638
DN
103072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10308
10309 Don't force ./temacs to start in terminal mode.
10310
10311 * frame.c (make_initial_frame): Initialize faces in all cases, not
10312 only when CANNOT_DUMP is defined.
10313 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10314
c56e0fd5
DN
103152011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10316
10317 * dispnew.c (add_window_display_history): Use const for the string
10318 pointer. Remove declaration, not needed.
10319
333d54da 103202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10321
55d4c1b2 10322 Use 'inline', not 'INLINE'.
333d54da 10323 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10324 * alloc.c, fontset.c (INLINE): Remove.
10325 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10326 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10327 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10328 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10329 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10330
738db178
DN
103312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10332
10333 Make it possible to run ./temacs.
10334
10335 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10336 syms_of_callproc does the same thing. Remove test for
10337 "initialized", do it in the caller.
10338 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10339
620c53a6
SM
103402011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10341
10342 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10343 (read_minibuf): Use get_minibuffer.
10344 (syms_of_minibuf): Use DEFSYM.
10345 (Qmetadata): New var.
10346 * data.c (Qbuffer): Don't make it static.
10347 (syms_of_data): Use DEFSYM.
10348
e003a292
PE
103492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10350
10351 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10352 (CCL_CODE_MIN): New macro.
10353
ed008a6d
PE
103542011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10355
3687c2ef
PE
10356 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10357
ed008a6d
PE
10358 * eval.c (Qdebug): Now static.
10359 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10360 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10361 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10362
d66c4c7c
CY
103632011-05-29 Chong Yidong <cyd@stupidchicken.com>
10364
10365 * image.c: Various fixes to ImageMagick code comments.
10366 (Fimagemagick_types): Doc fix.
10367
5fbc2025
PE
103682011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10369
0196f88a
PE
10370 Minor fixes prompted by GCC 4.6.0 warnings.
10371
10372 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10373
5fbc2025
PE
10374 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10375 (x_clipboard_manager_save_all): Move extern decl to ...
10376 * xterm.h: ... here, so that it can be checked for consistency.
10377
1dd3c2d9
CY
103782011-05-29 Chong Yidong <cyd@stupidchicken.com>
10379
10380 * xselect.c (x_clipboard_manager_save_frame)
10381 (x_clipboard_manager_save_all): New functions.
10382 (Fx_clipboard_manager_save): Lisp function deleted.
10383
10384 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10385 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10386
10387 * xterm.h: Update prototype.
10388
5ba6571d
WX
103892011-05-28 William Xu <william.xwl@gmail.com>
10390
10391 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10392 exiting (Bug#8239).
10393
3eaff834
JM
103942011-05-28 Jim Meyering <meyering@redhat.com>
10395
e1900994 10396 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10397 * fns.c (to_uchar): Define.
10398 (crypto_hash_function): Use it to convert some newly-signed
10399 variables to unsigned, to avoid sign-extension bugs. For example,
10400 without this change, (md5 "truc") would evaluate to
10401 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10402 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10403 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10404
0f6990a7
PE
104052011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10406
10407 Integer overflow fixes.
c8a9ca5a 10408
08686060
PE
10409 * dbusbind.c: Serial number integer overflow fixes.
10410 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10411 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10412 to hold a serial number that is too large for a fixnum.
10413 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10414 Check for serial numbers out of range. Decode any serial number
59568bf0 10415 that was so large that it became a float. (Bug#8722)
08686060 10416
2d1fc3c7
PE
10417 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10418 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10419 Use XFASTINT rather than XUINT when numbers are nonnegative.
10420 (xd_append_arg, Fdbus_method_return_internal):
10421 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10422 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10423 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10424 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10425 (Bug#8722)
2d1fc3c7 10426
c8a9ca5a
PE
10427 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10428
519e1d69
PE
10429 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10430
6df6ae42 10431 ccl: Add integer overflow checks.
30569699
PE
10432 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10433 (IN_INT_RANGE): New macros.
10434 (ccl_driver): Use them to check for integer overflow when
10435 decoding a CCL program. Many of the new checks are whether XINT (x)
10436 fits in int; it doesn't always, on 64-bit hosts. The new version
10437 doesn't catch all possible integer overflows, but it's an
847044ea 10438 improvement. (Bug#8719)
30569699 10439
c11285dc
PE
10440 * alloc.c (make_event_array): Use XINT, not XUINT.
10441 There's no need for unsigned here.
10442
fdccd48e
PE
10443 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10444 This follows up to the 2011-05-06 change that substituted uintptr_t
10445 for EMACS_INT. This case wasn't caught back then.
10446
37910ab2
PE
10447 Rework Fformat to avoid integer overflow issues.
10448 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10449 now (part of C89). Include <verify.h>.
10450 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10451 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10452 (Fformat): Avoid the prepass trying to compute sizes; it was only
10453 approximate and thus did not catch overflow reliably. Instead, walk
10454 through the format just once, formatting and computing sizes as we go,
10455 checking for integer overflow at every step, and allocating a larger
10456 buffer as needed. Keep track separately whether the format is
10457 multibyte. Keep only the most-recently calculated precision, rather
10458 than them all. Record whether each argument has been converted to
10459 string. Use EMACS_INT, not int, for byte and char and arg counts.
10460 Support field widths and precisions larger than INT_MAX. Avoid
10461 sprintf's undefined behavior with conversion specifications such as %#d
10462 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10463 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10464 formatting out-of-range floating point numbers with int
9173deec 10465 formats. (Bug#8668)
37910ab2 10466
2e6578fb
PE
10467 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10468
0ae6bdee
PE
10469 * data.c: Avoid integer truncation in expressions involving floats.
10470 * data.c: Include <intprops.h>.
10471 (arith_driver): When there's an integer overflow in an expression
10472 involving floating point, convert the integers to floating point
10473 so that the resulting value does not suffer from catastrophic
10474 integer truncation. For example, on a 64-bit host (* 4
10475 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10476 Do not rely on undefined behavior after integer overflow.
10477
de883a70
PE
10478 merge count_size_as_multibyte, parse_str_to_multibyte
10479 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10480 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10481 Check for integer overflow.
10482 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10483 since it's now a duplicate of the other. This is more of
10484 a character than a buffer op, so better that it's in character.c.
10485 * fns.c, print.c: Adjust to above changes.
10486
2ff916cb
PE
104872011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10488
10489 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10490
f1b54466
PE
104912011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10492
fb1ac845
PE
10493 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10494 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10495 (x_clipboard_manager_save): Now static.
10496 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10497
f1b54466
PE
10498 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10499 (crypto_hash_function): Now static.
10500 Fix pointer signedness problems. Avoid unnecessary initializations.
10501
a9f737ee
CY
105022011-05-27 Chong Yidong <cyd@stupidchicken.com>
10503
10504 * termhooks.h (Vselection_alist): Make it terminal-local.
10505
10506 * terminal.c (create_terminal): Initialize it.
10507
10508 * xselect.c: Support for clipboard managers.
10509 (Vselection_alist): Move to termhooks.h as terminal-local var.
10510 (LOCAL_SELECTION): New macro.
10511 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10512 (symbol_to_x_atom): Remove gratuitous arg.
10513 (x_handle_selection_request, lisp_data_to_selection_data)
10514 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10515 (x_own_selection, x_get_local_selection, x_convert_selection):
10516 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10517 (some_frame_on_display): Delete unused function.
10518 (Fx_own_selection_internal, Fx_get_selection_internal)
10519 (Fx_disown_selection_internal, Fx_selection_owner_p)
10520 (Fx_selection_exists_p): New optional frame arg.
10521 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10522 (x_handle_selection_clear): Don't treat other terminals with the
10523 same keyboard specially. Use the terminal-local Vselection_alist.
10524 (x_clear_frame_selections): Use Frun_hook_with_args.
10525
10526 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10527
10528 * xterm.h: Add support for those atoms.
10529
e067f0c1
CY
105302011-05-26 Chong Yidong <cyd@stupidchicken.com>
10531
10532 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10533 (converted_selections, conversion_fail_tag): New global variables.
10534 (x_selection_request_lisp_error): Free the above.
10535 (x_get_local_selection): Remove unnecessary code.
10536 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10537 of converted selections stored in converted_selections.
10538 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10539 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10540 (x_convert_selection): New function.
10541 (x_handle_selection_event): Simplify.
10542 (x_get_foreign_selection): Don't ignore incoming requests while
10543 waiting for an answer; this will fail when we implement
10544 SAVE_TARGETS, and seems unnecessary anyway.
10545 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10546 (Vx_sent_selection_functions): Doc fix.
10547
0f4aebc0
LL
105482011-05-26 Leo Liu <sdl.web@gmail.com>
10549
10550 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10551
e61124cd
YM
105522011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10553
10554 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10555
10556 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10557 for fringe update if it has periodic bitmap.
ac389d0c 10558 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10559 and fringe_bitmap_periodic_p.
10560
10561 * fringe.c (get_fringe_bitmap_data): New function.
10562 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10563 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10564 row. Mark glyph row for fringe update if periodicity changed.
10565
10566 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10567 for fringe update unless it has periodic bitmap.
10568
f16d9837
KH
105692011-05-25 Kenichi Handa <handa@m17n.org>
10570
10571 * xdisp.c (get_next_display_element): Set correct it->face_id for
10572 a static composition.
10573
e1b90ef6
LL
105742011-05-24 Leo Liu <sdl.web@gmail.com>
10575
10576 * deps.mk (fns.o):
10577 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10578
10579 * fns.c (crypto_hash_function, Fsha1): New function.
10580 (Fmd5): Use crypto_hash_function.
10581 (syms_of_fns): Add Ssha1.
10582
7400048f
PE
105832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10584
10585 * gnutls.c: Remove unused macros.
10586 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10587 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10588 Remove macros that are defined and never used.
10589 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10590
abb71cf4
CY
105912011-05-22 Chong Yidong <cyd@stupidchicken.com>
10592
10593 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10594 (Fx_get_selection_internal): Minor cleanup.
10595 (Fx_own_selection_internal): Rename arguments for consistency with
10596 select.el.
10597
6307db39
PE
105982011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10599
10600 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10601
f3d4e0a4
CY
106022011-05-22 Chong Yidong <cyd@stupidchicken.com>
10603
10604 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10605
4d8ade89
YM
106062011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10607
10608 * dispnew.c (scrolling_window): Don't exclude the case that the
10609 last enabled row in the desired matrix touches the bottom boundary.
10610
32078c8d
GM
106112011-05-21 Glenn Morris <rgm@gnu.org>
10612
10613 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10614 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10615 and add some more files.
32078c8d 10616
7285dc67
EZ
106172011-05-20 Eli Zaretskii <eliz@gnu.org>
10618
10619 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10620 report_file_error introduced by the change from 2011-05-07.
10621
89d1bd22
PE
106222011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10623
10624 * systime.h (Time): Define only if emacs is defined.
10625 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10626 where the include path doesn't have X11/X.h by default. See
10627 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10628
cd394be1 106292011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10630
10631 * composite.c (find_automatic_composition): Fix previous change.
10632
b9704ad9
GM
106332011-05-20 Glenn Morris <rgm@gnu.org>
10634
10635 * lisp.mk: New file, split from Makefile.in.
10636 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10637 (shortlisp): Remove.
10638 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10639
4a720484
GM
106402011-05-19 Glenn Morris <rgm@gnu.org>
10641
10642 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10643 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10644 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10645 (lisp): Set the order to that of loadup.el.
10646 (shortlisp): Make it a copy of $lisp.
10647 (SOME_MACHINE_LISP): Remove.
10648 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10649 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10650
a28d4396
KH
106512011-05-18 Kenichi Handa <handa@m17n.org>
10652
10653 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10654 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10655 (find_automatic_composition): Mostly rewrite for efficiency.
10656
a2b1fa8e
JB
106572011-05-18 Juanma Barranquero <lekktu@gmail.com>
10658
10659 * makefile.w32-in: Update dependencies.
10660
8e1f5610
CS
106612011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10662
10663 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10664 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10665
7025ee00 106662011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10667
cdfa6eab
PE
10668 Fix some integer overflow issues, such as string length overflow.
10669
06d6db33
PE
10670 * insdel.c (count_size_as_multibyte): Check for string overflow.
10671
2b4560a8
PE
10672 * character.c (lisp_string_width): Check for string overflow.
10673 Use EMACS_INT, not int, for string indexes and lengths; in
10674 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10675 the resulting string length overflows an EMACS_INT; instead,
10676 report a string overflow if no precision given. When checking for
10677 precision exhaustion, use a check that cannot possibly have
10678 integer overflow. (Bug#8675)
10679 * character.h (lisp_string_width): Adjust to new signature.
10680
cb93f9be
PE
10681 * alloc.c (string_overflow): New function.
10682 (Fmake_string): Use it. This doesn't change behavior, but saves
10683 a few bytes and will simplify future changes.
10684 * character.c (string_escape_byte8): Likewise.
10685 * lisp.h (string_overflow): New decl.
10686
1a1f3366
PE
10687 Fixups, following up to the user-interface timestamp change.
10688 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10689 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10690 * msdos.c (mouse_get_pos): Likewise.
10691 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10692 * w32gui.h (Time): Define by including "systime.h" rather than by
10693 declaring it ourselves. (Bug#8664)
10694
d4e3e4d3
PE
10695 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10696 * image.c (clear_image_cache): Likewise.
10697
f6a24d19
PE
10698 * term.c (term_mouse_position): Don't assume time_t wraparound.
10699
08dc5ae6
PE
10700 Be more systematic about user-interface timestamps.
10701 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10702 and sometimes 'EMACS_UINT', to represent these timestamps.
10703 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10704 This makes the code easier to follow, and makes it easier to catch
10705 integer overflow bugs such as Bug#8664.
10706 * frame.c (Fmouse_position, Fmouse_pixel_position):
10707 Use Time, not unsigned long, for user-interface timestamps.
10708 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10709 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10710 * keyboard.h (last_event_timestamp): Likewise.
10711 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10712 * menu.h (xmenu_show): Likewise.
10713 * term.c (term_mouse_position): Likewise.
10714 * termhooks.h (struct input_event.timestamp): Likewise.
10715 (struct terminal.mouse_position_hook): Likewise.
10716 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10717 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10718 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10719 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10720 what it was before.
10721 * menu.h, termhooks.h: Include "systime.h", for Time.
10722
8e55734a
PE
10723 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10724 Don't assume that the difference between two unsigned long values
10725 can fit into an integer. At this point, we know button_down_time
10726 <= event->timestamp, so the difference must be nonnegative, so
10727 there's no need to cast the result if double-click-time is
10728 nonnegative, as it should be; check that it's nonnegative, just in
10729 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10730 apart (about 25 days). (Bug#8664)
8e55734a 10731
841f1b75 10732 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10733 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10734
3e26f69c
PE
10735 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10736 that always fit in int. Use a sentinel instead of a counter, to
10737 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10738 * frame.h (struct frame): Use int for menu_bar_items_used
10739 instead of EMACS_INT, since it always fits in int.
3e26f69c 10740
5cc152c0
PE
10741 * menu.c (grow_menu_items): Check for int overflow.
10742
d89eb65e
PE
10743 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10744
5235bd3e
PE
10745 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10746 Before, the code was not consistent. These values cannot exceed
10747 2**31 - 1 so there's no need to make them unsigned.
10748 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10749 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10750 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10751 as modifiers.
10752 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10753
bc827e23
PE
10754 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10755 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10756 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10757 presumably because the widths might not match.
10758
78eb494e
PE
10759 * window.c (size_window): Avoid needless test at loop start.
10760
04f2d78b
CB
107612011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10762
10763 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10764
d2fc7e3d 107652011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10766
10767 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10768
d2fc7e3d 107692011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10770
10771 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10772 `width' to `bar_area_x' and `bar_area_width', respectively.
10773 (x_scroll_run): Take account of fringe background extension.
10774
04f2d78b
CB
10775 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10776 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10777 `bar_area_width', respectively.
10778 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10779 background extension.
10780
79b70037
GM
107812011-05-10 Jim Meyering <meyering@redhat.com>
10782
10783 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10784
2f142cc5
JB
107852011-05-10 Juanma Barranquero <lekktu@gmail.com>
10786
10787 * image.c (Finit_image_library): Return t for built-in image types,
10788 like pbm and xbm. (Bug#8640)
10789
57679c86
AS
107902011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10791
10792 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10793
888c9e86
EZ
107942011-05-07 Eli Zaretskii <eliz@gnu.org>
10795
b0512a1d
EZ
10796 * w32console.c (Fset_screen_color): Doc fix.
10797 (Fget_screen_color): New function.
10798 (syms_of_ntterm): Defsubr it.
10799
7285dc67
EZ
10800 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10801 unlink the temporary file if Fcall_process didn't create it in the
10802 first place.
10803 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10804 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10805 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10806 cue to call_process_cleanup not to close that handle.
10807
4d3fcc8e
BK
108082011-05-07 Ben Key <bkey76@gmail.com>
10809
10810 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10811 one of two shell specific rules, either bootstrap-temacs-CMD or
10812 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10813 to the previous implementation of the bootstrap-temacs rule.
10814 The bootstrap-temacs-CMD rule is similar to the previous
10815 implementation of the bootstrap-temacs rule except that it
10816 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10817 variable.
10818
10819 These changes, along with some changes to nt/configure.bat,
10820 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10821 earlier fix to add support for --cflags and --ldflags options
10822 that include quotes so that it works whether make uses cmd or
10823 sh as the shell.
10824
b4289b64
MA
108252011-05-06 Michael Albinus <michael.albinus@gmx.de>
10826
10827 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10828 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10829 is a constant.
10830 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10831 a string. Handle both cases.
10832 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10833 (Fdbus_register_method): Use Qinvalid_function.
10834
af4c0e28
JB
108352011-05-06 Juanma Barranquero <lekktu@gmail.com>
10836
10837 * makefile.w32-in: Update dependencies.
10838 (LISP_H): Add inttypes.h and stdin.h.
10839 (PROCESS_H): Add unistd.h.
10840
c51453d9
EZ
108412011-05-06 Eli Zaretskii <eliz@gnu.org>
10842
10843 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10844 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10845
8ff0ac3c 108462011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10847
4c4b566b
PE
10848 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10849
aab2b9b5
PE
10850 * term.c (vfatal): Remove stray call to va_end.
10851 It's not needed and the C Standard doesn't allow it here anyway.
10852
c378da0b
PE
10853 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10854 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10855
288b08c7
PE
10856 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10857 bytes.
10858
e3601888
PE
10859 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10860
db6c0e74
PE
10861 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10862
dd5963ea
PE
10863 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10864
88c9450f
PE
10865 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10866
2f9442b8
PE
10867 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10868
c032b5f8
PE
10869 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10870 * charset.c (Fdefine_charset_internal): Don't initialize
10871 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10872 32-bit int (Bug#8600).
a108c10b
PE
10873
10874 * lread.c (read_integer): Be more consistent with string-to-number.
10875 Use string_to_number to do the actual conversion; this avoids
10876 rounding errors and fixes some other screwups. Without this fix,
10877 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10878 (digit_to_number): Move earlier, for benefit of read_integer.
10879 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10880 not a digit in any supported base. (Bug#8602)
a108c10b 10881
ad5f9eea
PE
10882 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10883
aec1708a
PE
10884 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10885 to match comment at start of function. This also removes a
10886 GCC warning about overflow in a 32+64-bit port.
10887
47be4ab5
PE
10888 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10889
371cac43
PE
10890 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10891 Reported by Stefan Monnier in
10892 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10893 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10894 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10895
d01a7826
PE
10896 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10897 (EMACS_UINTPTR): Likewise, with uintptr_t.
10898
7fd47d5c
PE
10899 * lisp.h: Prefer 64-bit EMACS_INT if available.
10900 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10901 on 32-bit hosts that have 64-bit int, so that they can access
10902 large files.
122b0c86
PE
10903 However, temporarily disable this change unless the temporary
10904 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10905
8727937b
PE
10906 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10907
8ac068ac
PE
10908 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10909 This removes an assumption that EMACS_INT and long are the same
10910 width as pointers. The assumption is true for Emacs porting targets
10911 now, but we want to make other targets possible.
10912 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10913 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10914 In the rest of the code, change types of integers that hold casted
10915 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10916 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10917 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10918 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10919 No need to cast type when ORing.
10920 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10921 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10922 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10923 assume EMACS_INT is the same width as char *.
10924 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10925 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10926 Remove no-longer-needed casts.
10927 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10928 (xg_tool_bar_help_callback, xg_make_tool_item):
10929 Use EMACS_INTPTR to hold an integer
10930 that will be cast to void *; this can avoid a GCC warning
10931 if EMACS_INT is not the same width as void *.
10932 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10933 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10934 (current_message_1, set_message_1):
10935 Use a local to convert to proper width without a cast.
10936 * xmenu.c (dialog_selection_callback): Likewise.
10937
ede49d71
PE
10938 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10939 Also, don't assume VALBITS / RAND_BITS is less than 5,
10940 and don't rely on undefined behavior when shifting a 1 left into
10941 the sign bit.
10942 * lisp.h (get_random): Change signature to match.
10943
2f30ecd0
PE
10944 * lread.c (hash_string): Use size_t, not int, for hash computation.
10945 Normally we prefer signed values; but hashing is special, because
10946 it's better to use unsigned division on hash table sizes so that
10947 the remainder is nonnegative. Also, size_t is the natural width
10948 for hashing into memory. The previous code used 'int', which doesn't
10949 retain enough info to hash well into very large tables.
10950 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10951
2a866e7b
PE
10952 * dbusbind.c: Don't possibly lose pointer info when converting.
10953 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10954 Use XPNTR rather than XHASH, so that the high-order bits of
10955 the pointer aren't lost when converting through void *.
10956
51639eac
PE
10957 * eval.c (Fautoload): Don't double-shift a pointer.
10958
92394119
PE
10959 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10960
dbdb9a7c
JB
109612011-05-06 Juanma Barranquero <lekktu@gmail.com>
10962
10963 * gnutls.c (DEF_GNUTLS_FN):
10964 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10965
db7a0b4f
AS
109662011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10967
10968 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10969 marker. (Bug#8610)
10970
cd394be1 109712011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10972
10973 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10974 New version that can reserve upto 2GB of heap space.
10975
f7ff1b0f 109762011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10977
10978 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10979
639c109b
TZ
109802011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10981
10982 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10983 `gnutls_certificate_set_x509_key_file'.
10984
d2127135
JB
109852011-05-05 Juanma Barranquero <lekktu@gmail.com>
10986
10987 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10988 Update dependencies.
10989
e968f4f3
JB
109902011-05-04 Juanma Barranquero <lekktu@gmail.com>
10991
10992 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10993 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10994 Remove unused parameter `fildes'.
10995 * process.c (read_process_output, send_process): Don't pass it.
10996
84d358f0
JB
109972011-05-04 Juanma Barranquero <lekktu@gmail.com>
10998
10999 Fix previous change: the library cache is defined in w32.c.
11000 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11001 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11002
0898ca10
JB
110032011-05-04 Juanma Barranquero <lekktu@gmail.com>
11004
11005 Implement dynamic loading of GnuTLS on Windows.
11006
11007 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11008 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11009 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11010 Declare.
11011
11012 * gnutls.c (Qgnutls_dll): Define.
11013 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11014 (gnutls_*): Declare function pointers.
11015 (init_gnutls_functions): New function to initialize function pointers.
11016 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11017 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11018 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11019 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11020 (emacs_gnutls_write, emacs_gnutls_read)
11021 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11022 (Fgnutls_available_p): New function.
11023 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11024 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11025 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11026
11027 * image.c: Include w32.h.
11028 (Vimage_type_cache): Delete.
11029 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11030 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11031 (w32_delayed_load): Move to w32.c.
11032
11033 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11034
11035 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11036 (w32_delayed_load): Move from image.c. When loading a library, record
11037 its filename in the :loaded-from property of the library id.
11038 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11039 Initialize and staticpro them.
11040 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11041
11042 * process.c: Include lisp.h before w32.h, not after.
11043 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11044 instead of gnutls_record_check_pending.
11045
11046 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11047
ff4de4aa
TZ
110482011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11049
11050 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11051 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11052 as passed in.
11053
abe95abb
JD
110542011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11055
11056 * xterm.c (x_set_frame_alpha): Do not set property on anything
11057 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11058
e16e55d4
JB
110592011-05-02 Juanma Barranquero <lekktu@gmail.com>
11060
11061 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11062
bafcf6a5
JB
110632011-05-02 Juanma Barranquero <lekktu@gmail.com>
11064
11065 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11066 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11067 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11068 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11069 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11070 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11071 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11072 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11073 (Qgnutls_bootprop_callbacks_verify): Make static.
11074
e7a6747f
AS
110752011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11076
19ed11ba
AS
11077 * callproc.c: Indentation fixup.
11078
e7a6747f 11079 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11080 (wait_for_termination, interruptible_wait_for_termination):
11081 Move after wait_for_termination_1.
e7a6747f 11082
1ef14cb4
LMI
110832011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11084
11085 * sysdep.c (interruptible_wait_for_termination): New function
11086 which is like wait_for_termination, but allows keyboard
11087 interruptions.
11088
11089 * callproc.c (Fcall_process): Add (:file "file") as an option for
11090 the STDOUT buffer.
11091 (Fcall_process_region): Ditto.
11092
330d880c
EZ
110932011-04-30 Eli Zaretskii <eliz@gnu.org>
11094
8db90b73
EZ
11095 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11096 rather than `XVECTOR (FOO)->size'.
11097
330d880c
EZ
11098 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11099 inttypes.h, as a gnulib replacement is used if it not available in
11100 system headers.
11101
15cbd324
EZ
111022011-04-21 Eli Zaretskii <eliz@gnu.org>
11103
11104 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11105 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11106 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11107
11108 * coding.c (coding_alloc_by_realloc): Error out if destination
11109 will grow beyond MOST_POSITIVE_FIXNUM.
11110 (decode_coding_emacs_mule): Abort if there isn't enough place in
11111 charbuf for the composition carryover bytes. Reserve an extra
11112 space for up to 2 characters produced in a loop.
11113 (decode_coding_iso_2022): Abort if there isn't enough place in
11114 charbuf for the composition carryover bytes.
11115
111162011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11117
ae940cca
EZ
11118 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11119 aborting when %lld or %lll format is passed.
11120 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11121 %llo or %llx format is passed. (Bug#8545)
11122
03ab8921
EZ
11123 * window.c (window_scroll_line_based): Use a marker instead of
11124 simple variables to record original value of point. (Bug#7952)
11125
afda1437
EZ
11126 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11127 produced by %s or %c overflows available buffer space. (Bug#8545)
11128
f76dee0c
PE
111292011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11130
11131 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11132 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11133
fdc5744d
JB
111342011-04-28 Juanma Barranquero <lekktu@gmail.com>
11135
11136 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11137
638f053a
JB
111382011-04-28 Juanma Barranquero <lekktu@gmail.com>
11139
11140 * keyboard.c (Qdelayed_warnings_hook): Define.
11141 (command_loop_1): Run `delayed-warnings-hook'
11142 if Vdelayed_warnings_list is non-nil.
11143 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11144 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11145
d178f871
EZ
111462011-04-28 Eli Zaretskii <eliz@gnu.org>
11147
11148 * doprnt.c (doprnt): Don't return value smaller than the buffer
11149 size if the message was truncated. (Bug#8545).
11150
b124fd93
JB
111512011-04-28 Juanma Barranquero <lekktu@gmail.com>
11152
11153 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11154 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11155
e810457d
PE
111562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11157
11158 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11159
ea51cceb
JB
111602011-04-27 Juanma Barranquero <lekktu@gmail.com>
11161
11162 * makefile.w32-in: Update dependencies.
11163
94dcfacf
EZ
111642011-04-27 Eli Zaretskii <eliz@gnu.org>
11165
11166 Improve `doprnt' and its usage. (Bug#8545)
11167 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11168 `format_end'. Remove support for %l as a conversion specifier.
11169 Don't use xrealloc. Improve diagnostics when the %l size modifier
11170 is used. Update the commentary.
11171
11172 * eval.c (verror): Simplify calculation of size_t.
11173
11174 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11175 messages.
11176
f61f41d7
PE
111772011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11178
11179 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11180 change.
11181
96fb4434
PE
111822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11183
11184 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11185 This makes this file independent of the recent pseudovector change.
11186
671875da 111872011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11188
69e9b5a3
PE
11189 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11190
b5f869a7 11191 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11192 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11193 Remove unused local.
c8926152 11194 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11195
841a1577 11196 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11197 GCC 4.6.0 optimizes based on type-based alias analysis.
11198 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11199 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11200 != &v->size, and therefore "v->size = 1; b->size = 2; return
11201 v->size;" must therefore return 1. This assumption is incorrect
11202 for Emacs, since it type-puns struct Lisp_Vector * with many other
11203 types. To fix this problem, this patch adds a new type struct
f904488f 11204 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11205 and pseudovectors, and helps optimizing compilers not get fooled
11206 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11207 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11208 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11209 the size member.
eab3844f
PE
11210 (XSETPVECTYPE): Rewrite in terms of new macro.
11211 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11212 This is a bit clearer, and further avoids the possibility of
11213 undesirable aliasing.
11214 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11215 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11216 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11217 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11218 (ASIZE): Now uses header.size rather than size.
11219 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11220 to avoid the hassle of writing XVECTOR (foo)->header.size.
11221 (struct vectorlike_header): New type.
eab3844f
PE
11222 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11223 object, to help avoid aliasing.
11224 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11225 (SUBRP): Likewise, since Lisp_Subr is a special case.
11226 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11227 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11228 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11229 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11230 changed to be "header.size" and "header.next".
11231 * buffer.h (struct buffer): Likewise.
11232 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11233 * frame.h (struct frame): Likewise.
11234 * process.h (struct Lisp_Process): Likewise.
11235 * termhooks.h (struct terminal): Likewise.
11236 * window.c (struct save_window_data, struct saved_window): Likewise.
11237 * window.h (struct window): Likewise.
11238 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11239 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11240 * buffer.c (init_buffer_once): Likewise.
11241 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11242 special case.
11243 * process.c (Fformat_network_address): Use local var for size,
11244 for brevity.
11245
0df1eac5
PE
11246 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11247
847ab9d1 11248 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11249 * data.c (atof): Remove decl; no longer used or needed.
11250 (digit_to_number): Move to lread.c.
11251 (Fstring_to_number): Use new string_to_number function, to be
11252 consistent with how the Lisp reader treats infinities and NaNs.
11253 Do not assume that floating-point numbers represent EMACS_INT
11254 without losing information; this is not true on most 64-bit hosts.
11255 Avoid double-rounding errors, by insisting on integers when
11256 parsing non-base-10 numbers, as the documentation specifies.
11257 * lisp.h (string_to_number): New decl, replacing ...
11258 (isfloat_string): Remove.
bc0a5c13 11259 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11260 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11261 appears to have been a coding error. Similarly, do not accept
11262 strings like +-1e0 as floating point numbers. Do not report
11263 overflow for integer overflows unless the base is not 10 which
11264 means we have no simple and reliable way to continue.
11265 Break out the floating-point parsing into a new
11266 function string_to_number, so that Fstring_to_number parses
11267 floating point numbers consistently with the Lisp reader.
04f2d78b 11268 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11269 (E_CHAR, EXP_INT): Remove, replacing with ...
11270 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11271 (string_to_number): New function, replacing isfloat_string.
11272 This function checks for valid syntax and produces the resulting
11273 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11274 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11275 so that overflow for non-base-10 numbers is reported only when
11276 there's no portable and simple way to convert to floating point.
452f4150 11277
67769ffc
PE
11278 * textprop.c (set_text_properties_1): Rewrite for clarity,
11279 and to avoid GCC warning about integer overflow.
11280
c20db43f
PE
11281 * intervals.h (struct interval): Use EMACS_INT for members
11282 where EMACS_UINT might cause problems. See
11283 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11284 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11285 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11286 All uses changed.
37aa2f85
PE
11287 (offset_intervals): Tell GCC not to worry about length overflow
11288 when negating a negative length.
c20db43f 11289
2538aa2f
PE
11290 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11291 (overrun_check_free): Likewise.
11292
f2d3008d
PE
11293 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11294 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11295 word size.
11296
ec8df744
PE
11297 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11298 (gnutls_make_error): Rename local to avoid shadowing.
11299 (gnutls_emacs_global_deinit): ifdef out; not used.
11300 (Fgnutls_boot): Use const for pointer to readonly storage.
11301 Comment out unused local. Fix pointer signedness problems.
11302
640ee02d
PE
11303 * lread.c (openp): Don't stuff size_t into an 'int'.
11304 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11305 about possible signed overflow.
11306
6048fb2a
PE
11307 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11308 (GDK_KEY_g): Don't define if already defined.
11309 (xg_prepare_tooltip): Avoid pointer signedness problem.
11310 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11311
fa3c87e1
PE
11312 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11313 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11314
2172544b
PE
11315 * xfns.c (Fx_window_property): Simplify a bit,
11316 to make a bit faster and to avoid GCC 4.6.0 warning.
11317 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11318
9b821a21
PE
11319 * fns.c (internal_equal): Don't assume size_t fits in int.
11320
3c616cfa
PE
11321 * alloc.c (compact_small_strings): Tighten assertion a little.
11322
c2982e87
PE
11323 Replace pEd with more-general pI, and fix some printf arg casts.
11324 * lisp.h (pI): New macro, generalizing old pEd macro to other
11325 conversion specifiers. For example, use "...%"pI"d..." rather
11326 than "...%"pEd"...".
11327 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11328 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11329 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11330 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11331 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11332 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11333 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11334 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11335 64-bit hosts.
11336 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11337 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11338 * print.c (safe_debug_print, print_object): Likewise.
11339 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11340 to int.
6f04d126
PE
11341 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11342 avoiding the 0 flag, which is not portable.
c2982e87
PE
11343 * process.c (Fmake_network_process): Use pI to avoid cast.
11344 * region-cache.c (pp_cache): Likewise.
11345 * xdisp.c (decode_mode_spec): Likewise.
11346 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11347 behavior on 64-bit hosts with printf arg.
6f04d126 11348 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11349 (x_stop_queuing_selection_requests): Likewise.
11350 (x_get_window_property): Don't truncate byte count to an 'int'
11351 when tracing.
0b432f21 11352
5e073ec7
PE
11353 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11354 here, since it parses constructs like leading '-' and spaces,
11355 which are not wanted; and it overflows with large numbers.
11356 Instead, simply match F[0-9]+, which is what is wanted anyway.
11357
36372bf9
PE
11358 * alloc.c: Remove unportable assumptions about struct layout.
11359 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11360 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11361 (allocate_vectorlike, make_pure_vector): Use the new macros,
11362 plus offsetof, to remove unportable assumptions about struct layout.
11363 These assumptions hold on all porting targets that I know of, but
11364 they are not guaranteed, they're easy to remove, and removing them
11365 makes further changes easier.
11366
0b432f21
PE
11367 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11368 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11369 (string_overrun_cookie): Now const. Use initializers that
11370 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11371 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11372 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11373 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11374 multiple of sizeof (EMACS_INT); it need not be, if
11375 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11376 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11377
895009e1
JB
113782011-04-26 Juanma Barranquero <lekktu@gmail.com>
11379
11380 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11381
6a7a1b0b
TZ
113822011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11383
11384 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11385 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11386 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11387
841a1577 113882011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11389
11390 * lisp.h (Qdebug): List symbol.
895009e1 11391 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11392 * keyboard.c (debug-on-event): New variable.
11393 (handle_user_signal): Break into debugger when debug-on-event
11394 matches the current signal symbol.
11395
f2d3ba6f
DN
113962011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11397
11398 * alloc.c (check_sblock, check_string_bytes)
11399 (check_string_free_list): Convert to standard C.
11400
42ce4c63
TZ
114012011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11402
11403 * w32.c (emacs_gnutls_push): Fix typo.
11404
825cd63c
EZ
114052011-04-25 Eli Zaretskii <eliz@gnu.org>
11406
fb11d64d
EZ
11407 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11408 "cast to pointer from integer of different size".
11409
825cd63c
EZ
11410 Improve doprnt and its use in verror. (Bug#8545)
11411 * doprnt.c (doprnt): Document the set of format control sequences
11412 supported by the function. Use SAFE_ALLOCA instead of always
11413 using `alloca'.
11414
11415 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11416 is one byte too soon. Don't use xrealloc; instead xfree and
11417 xmalloc anew.
11418
e061a11b
TZ
114192011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11420
11421 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11422 callbacks stage.
11423
11424 * gnutls.c: Renamed global_initialized to
11425 gnutls_global_initialized. Added internals for the
11426 :verify-hostname-error, :verify-error, and :verify-flags
11427 parameters of `gnutls-boot' and documented those parameters in the
11428 docstring. Start callback support.
9173deec
JB
11429 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11430 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11431 on error. Return error code.
e061a11b
TZ
11432 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11433 (emacs_gnutls_read): Likewise.
11434 (Fgnutls_boot): Return handshake error code.
11435 (emacs_gnutls_handle_error): New function.
11436 (wsaerror_to_errno): Likewise.
11437
11438 * w32.h (emacs_gnutls_pull): Add prototype.
11439 (emacs_gnutls_push): Likewise.
11440
11441 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11442 (emacs_gnutls_push): Likewise.
11443
114442011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11445
11446 * process.c (wait_reading_process_output): Check if GnuTLS
11447 buffered some data internally if no FDs are set for TLS
11448 connections.
11449
11450 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11451 (LIBS): Link to USER_LIBS.
11452 ($(BLD)/gnutls.$(0)): New target.
11453
fa6996bc
EZ
114542011-04-24 Eli Zaretskii <eliz@gnu.org>
11455
eb35682e
EZ
11456 * xdisp.c (handle_single_display_spec): Rename the
11457 display_replaced_before_p argument into display_replaced_p, to
11458 make it consistent with the commentary. Fix typos in the
11459 commentary.
11460
e2ad650c
EZ
11461 * textprop.c (syms_of_textprop): Remove dead code.
11462 (copy_text_properties): Delete obsolete commentary about an
11463 interface that was deleted long ago. Fix typos in the description
11464 of arguments.
11465
1b2de274
EZ
11466 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11467 to changes in oldXMenu/XMenu.h from 2011-04-16.
11468 <menu_help_message, prev_menu_help_message>: Constify.
11469 (IT_menu_make_room): menu->help_text is now `const char **';
11470 adjust.
11471
11472 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11473 to changes in oldXMenu/XMenu.h from 2011-04-16.
11474 (struct XMenu): Declare `help_text' `const char **'.
11475
11476 * xfaces.c <Qunspecified>: Make extern again.
11477
11478 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11479 required by POSIX.
1b2de274 11480
762b15be
EZ
11481 * doc.c (get_doc_string): Improve the format passed to `error'.
11482
11483 * doprnt.c (doprnt): Improve commentary.
11484
11485 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11486
11487 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11488 them with etags.
11489
f1052e5d
EZ
11490 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11491 changes in globals.h immediately force recompilation.
762b15be
EZ
11492 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11493 $(CURDIR)/s/ms-w32.h.
11494 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11495
fa6996bc
EZ
11496 * character.c (Fchar_direction): Function deleted.
11497 (syms_of_character): Don't defsubr it.
11498 <char-direction-table>: Deleted.
11499
e6c3da20
EZ
115002011-04-23 Eli Zaretskii <eliz@gnu.org>
11501
11502 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11503 * doprnt.c: Include limits.h.
11504 (SIZE_MAX): New macro.
04f2d78b
CB
11505 (doprnt): Return a size_t value. 2nd arg is now size_t.
11506 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11507 Improve overflow protection. Support `l' modifier for integer
11508 conversions. Support %l conversion. Don't assume an EMACS_INT
11509 argument for integer conversions and for %c.
11510
11511 * lisp.h (doprnt): Restore prototype.
11512
11513 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11514 $(SRC)/character.h.
11515
11516 * Makefile.in (base_obj): Add back doprnt.o.
11517
11518 * deps.mk (doprnt.o): Add back prerequisites.
11519 (callint.o): Depend on character.h.
11520
11521 * eval.c (internal_lisp_condition_case): Include the handler
11522 representation in the error message.
11523 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11524 when breaking from the loop.
11525
11526 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11527
11528 * callint.c (Fcall_interactively): When displaying error message
11529 about invalid control letter, pass the character's codepoint, not
11530 a pointer to its multibyte form. Improve display of the character
11531 in octal and display also its hex code.
11532
11533 * character.c (char_string): Use %x to display the (unsigned)
11534 codepoint of an invalid character, to avoid displaying a bogus
11535 negative value.
11536
11537 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11538 `error', not SYMBOL_NAME itself.
11539
11540 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11541 character arguments to `error'.
11542
11543 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11544 to `error' in error message about FINAL_CHAR argument. Make sure
11545 FINAL_CHAR is a character, and use %c when it is passed as
11546 argument to `error'.
11547
4ffd0d6b 115482011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11549
11550 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11551
11552 * w32.c: Include <time.h>.
11553 (sys_localtime): New function.
11554
4ffd0d6b 115552011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11556
11557 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11558
4ffd0d6b 11559 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11560
4ffd0d6b 115612011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11562
4ffd0d6b
GM
11563 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11564 zombies (Bug#8467).
aac0c6e3 11565
04c56954
EZ
115662011-04-19 Eli Zaretskii <eliz@gnu.org>
11567
11568 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11569 gl_state.e_property when gl_state.object is Qt.
11570
11571 * insdel.c (make_gap_larger): Remove limitation of buffer size
11572 to <= INT_MAX.
11573
16a43933
CY
115742011-04-18 Chong Yidong <cyd@stupidchicken.com>
11575
11576 * xdisp.c (lookup_glyphless_char_display)
11577 (produce_glyphless_glyph): Handle cons cell entry in
11578 glyphless-char-display.
11579 (Vglyphless_char_display): Document it.
11580
11581 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11582 glyphless-char-display.
11583
4581706e
CY
115842011-04-17 Chong Yidong <cyd@stupidchicken.com>
11585
11586 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11587
11588 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11589
11590 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11591 definition for no-X builds.
11592
4887c6e2 115932011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11594
fd35b6f9
PE
11595 Static checks with GCC 4.6.0 and non-default toolkits.
11596
5c1ccb01
PE
11597 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11598
006c5daa
PE
11599 * process.c (keyboard_bit_set): Define only if SIGIO.
11600 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11601 (send_process): Repair possible setjmp clobbering.
11602
efc736d3
PE
11603 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11604
4e2fe2e6
PE
11605 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11606
f97334a2
PE
11607 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11608
4e75f29d
PE
11609 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11610 Define only if needed.
11611
90efadd1
PE
11612 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11613 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11614 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11615
3c647824
PE
11616 * dispextern.h (struct redisplay_interface): Rename param
11617 to avoid shadowing.
e264f262 11618 * termhooks.h (struct terminal): Likewise.
761383f4 11619 * xterm.c (xembed_send_message): Likewise.
3c647824 11620
b58c5c4a
PE
11621 * insdel.c (make_gap_smaller): Define only if
11622 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11623
cad59032
PE
11624 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11625 it.
11626
c339dc2e
PE
11627 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11628 so that we aren't warned about unused symbols.
11629
91a3e27b
PE
11630 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11631
399c71d3 11632 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11633
8ffc96f5
PE
11634 * xfns.c (x_real_positions): Mark locals as initialized.
11635
eef9bc79
PE
11636 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11637
098db9dd
PE
11638 * xterm.c: Fix problems found by static analysis with other toolkits.
11639 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11640 (x_dispatch_event): Declare static if USE_GTK, and
11641 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11642 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11643 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11644 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11645 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11646
eb18f6cc
PE
11647 * xmenu.c (menu_help_callback): Pointer type fixes.
11648 Use const pointers when pointing at readonly data. Avoid pointer
11649 signedness clashes.
11650 (FALSE): Remove unused macro.
11651 (update_frame_menubar): Remove unused decl.
11652
1fe72bf8
PE
11653 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11654
60d9e1db
PE
11655 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11656 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11657 (single_menu_item): Rename local to avoid shadowing.
11658
39261c26
PE
11659 * keyboard.c (make_lispy_event): Remove unused local var.
11660
018c5e19
PE
11661 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11662 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11663
63d2b86e
PE
11664 * bitmaps: Change bitmaps from unsigned char back to the X11
11665 compatible char. Avoid the old compiler warnings about
11666 out-of-range initializers by using, for example, '\xab' rather
11667 than 0xab.
11668
aefd87e1
PE
11669 * xgselect.c (xgselect_initialize): Check vs interface
11670 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11671
bf501fb9
PE
11672 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11673
e9829fdf
PE
11674 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11675 to read-only memory.
11676
1086c095
PE
11677 * fns.c (vector): Remove; this old hack is no longer needed.
11678
2baccd04 11679 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11680 Remove unused var.
dde42981 11681 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11682
72391843 11683 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11684
436c16df 11685 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11686 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11687 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11688
92bb796d 11689 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11690 (x_term_init): Remove local to avoid shadowing.
92bb796d 11691
764430a3 11692 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11693
11694 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11695 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11696
d1dfb56c
EZ
116972011-04-16 Eli Zaretskii <eliz@gnu.org>
11698
c4354cb4
EZ
11699 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11700
d1dfb56c
EZ
11701 Fix regex.c, syntax.c and friends for buffers > 2GB.
11702 * syntax.h (struct gl_state_s): Declare character position members
11703 EMACS_INT.
11704
11705 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11706
04f2d78b
CB
11707 * textprop.c (verify_interval_modification, interval_of):
11708 Declare arguments EMACS_INT.
d1dfb56c
EZ
11709
11710 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11711 EMACS_INT.
11712
11713 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11714
11715 * indent.c (Fvertical_motion): Local variable it_start is now
11716 EMACS_INT.
11717
11718 * regex.c (re_match, re_match_2, re_match_2_internal)
11719 (bcmp_translate, regcomp, regexec, print_double_string)
11720 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11721 (re_compile_pattern, re_exec): Declare arguments and local
11722 variables `size_t' and `ssize_t' and return values `regoff_t', as
11723 appropriate.
11724 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11725 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11726 <compile_stack_type>: `size' and `avail' are now `size_t'.
11727
11728 * regex.h <regoff_t>: Use ssize_t, not int.
11729 (re_search, re_search_2, re_match, re_match_2): Arguments that
11730 specify buffer/string position and length are now ssize_t and
11731 size_t. Return type is regoff_t.
11732
613052cd
BK
117332011-04-16 Ben Key <bkey76@gmail.com>
11734
11735 * nsfont.m: Fixed bugs in ns_get_family and
11736 ns_descriptor_to_entity that were caused by using free to
11737 deallocate memory blocks that were allocated by xmalloc (via
11738 xstrdup). This caused Emacs to crash when compiled with
11739 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11740 --enable-checking=xmallocoverrun). xfree is now used to
11741 deallocate these memory blocks.
11742
4170f62f 117432011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11744
71b41406
PE
11745 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11746
9587a89d
PE
11747 emacs_write: Accept and return EMACS_INT for sizes.
11748 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11749 et seq.
11750 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11751 Accept and return EMACS_INT.
11752 (emacs_gnutls_write): Return the number of bytes written on
11753 partial writes.
11754 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11755 (emacs_read, emacs_write): Remove check for negative size, as the
11756 Emacs source code has been audited now.
9587a89d
PE
11757 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11758 (emacs_read, emacs_write): Use it.
273a5f82
PE
11759 * process.c (send_process): Adjust to the new signatures of
11760 emacs_write and emacs_gnutls_write. Do not attempt to store
11761 a byte offset into an 'int'; it might overflow.
9587a89d 11762 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11763
3e047f51
PE
11764 * sound.c: Don't assume sizes fit in 'int'.
11765 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11766 Return EMACS_INT, not int.
3e047f51 11767 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11768 Accept EMACS_INT, not int.
11769 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11770 record read return values.
11771
cc39a9db
BK
117722011-04-15 Ben Key <bkey76@gmail.com>
11773
c9d0ec6d
JB
11774 * keyboard.c (Qundefined): Don't declare static since it is used
11775 in nsfns.m.
11776 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11777 static since they are used in nsfont.m.
cc39a9db 11778
6c60eb9f
SM
117792011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11780
11781 * process.c (Qprocessp): Don't declare static.
11782 * lisp.h (Qprocessp): Declare again.
11783
7990b61a
JB
117842011-04-15 Juanma Barranquero <lekktu@gmail.com>
11785
11786 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11787
5d4cb038
PE
117882011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11789
8bd7b830 11790 Improve C-level modularity by making more things 'static'.
cd64ea1d 11791
e3b27b31
PE
11792 Don't publish debugger-only interfaces to other modules.
11793 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11794 (verify_bytepos, count_markers): Move decls to the only modules
11795 that need them.
11796 * region-cache.h (pp_cache): Likewise.
11797 * window.h (check_all_windows): Likewise.
11798 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11799
5d4cb038
PE
11800 * sysdep.c (croak): Now static, if
11801 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11802 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11803
11804 * alloc.c (refill_memory_reserve): Now static if
11805 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11806 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11807
e87b6180
PE
11808 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11809 Define only if USE_LUCID.
11810
ac64929e
PE
11811 * xrdb.c (x_customization_string, x_rm_string): Now static.
11812
6f37259d
PE
11813 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11814 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11815
1683e3ab
PE
11816 * xdisp.c (draw_row_with_mouse_face): Now static.
11817 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11818
de9c2632
PE
11819 * window.h (check_all_windows): Mark externally visible.
11820
2b96acb7
PE
11821 * window.c (window_deletion_count): Now static.
11822
11823 * undo.c: Make symbols static if they're not exported.
11824 (last_undo_buffer, last_boundary_position, pending_boundary):
11825 Now static.
11826
50436f33
PE
11827 * textprop.c (interval_insert_behind_hooks): Now static.
11828 (interval_insert_in_front_hooks): Likewise.
11829
64520e5c
PE
11830 * term.c: Make symbols static if they're not exported.
11831 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11832 (max_frame_lines, tty_set_terminal_modes):
11833 (tty_reset_terminal_modes, tty_turn_off_highlight):
11834 (get_tty_terminal): Now static.
11835 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11836 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11837 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11838 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11839 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11840
1fa53021
PE
11841 * sysdep.c: Make symbols static if they're not exported.
11842 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11843 Now static.
11844 (sigprocmask_set, full_mask): Remove; unused.
11845 (wait_debugging): Mark as visible.
11846 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11847 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11848
d4b43b22
PE
11849 * syntax.c (syntax_temp): Define only if !__GNUC__.
11850
b7c513d0
PE
11851 * sound.c (current_sound_device, current_sound): Now static.
11852
989b29ad
PE
11853 * search.c (searchbufs, searchbuf_head): Now static.
11854
13a55a78
PE
11855 * scroll.c (scroll_cost): Remove; unused.
11856 * dispextern.h (scroll_cost): Remove decl.
11857
de68a1fc
PE
11858 * region-cache.h (pp_cache): Mark as externally visible.
11859
40ccffa6
PE
11860 * process.c: Make symbols static if they're not exported.
11861 (process_tick, update_tick, create_process, chan_process):
11862 (Vprocess_alist, proc_buffered_char, datagram_access):
11863 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11864 (deactivate_process): Mark defn as static, as well as decl.
11865 * lisp.h (create_process): Remove decl.
11866 * process.h (chan_process, Vprocess_alist): Remove decls.
11867
ad64fc97
PE
11868 * print.c: Make symbols static if they're not exported.
11869 (print_depth, new_backquote_output, being_printed, print_buffer):
11870 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11871 (print_interval, print_number_index, initial_stderr_stream):
11872 Now static.
11873 * lisp.h (Fprinc): Remove decl.
11874 (debug_output_compilation_hack): Mark as externally visible.
11875
adddb265
PE
11876 * sysdep.c (croak): Move decl from here to syssignal.h.
11877 * syssignal.h (croak): Put it here, so the API can be checked when
11878 'croak' is called from dissociate_if_controlling_tty.
11879
1717ede2
PE
11880 * minibuf.c: Make symbols static if they're not exported.
11881 (minibuf_save_list, choose_minibuf_frame): Now static.
11882 * lisp.h (choose_minibuf_frame): Remove decl.
11883
fa5fb2bc
PE
11884 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11885
1e3890d1
PE
11886 * lread.c: Make symbols static if they're not exported.
11887 (read_objects, initial_obarray, oblookup_last_bucket_number):
11888 Now static.
11889 (make_symbol): Remove; unused.
11890 * lisp.h (initial_obarray, make_symbol): Remove decls.
11891
8a1414fa
PE
11892 * keyboard.c: Make symbols static if they're not exported.
11893 (single_kboard, recent_keys_index, total_keys, recent_keys):
11894 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11895 (this_single_command_key_start, echoing, last_auto_save):
11896 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11897 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11898 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11899 (Vlispy_mouse_stem, double_click_count):
11900 Now static.
11901 (force_auto_save_soon): Define only if SIGDANGER.
11902 (ignore_mouse_drag_p): Now static if
11903 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11904 (print_help): Remove; unused.
11905 (stop_character, last_timer_event): Mark as externally visible.
11906 * keyboard.h (ignore_mouse_drag_p): Declare only if
11907 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11908 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11909 * lisp.h (echoing): Remove decl.
11910 (force_auto_save_soon): Declare only if SIGDANGER.
11911 * xdisp.c (redisplay_window): Simplify code, to make it more
11912 obvious that ignore_mouse_drag_p is not accessed if !defined
11913 USE_GTK && !defined HAVE_NS.
11914
93ea6e8f
PE
11915 * intervals.c: Make symbols static if they're not exported.
11916 (merge_properties_sticky, merge_interval_right, delete_interval):
11917 Now static.
11918 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11919
77382fcc
PE
11920 * insdel.c: Make symbols static if they're not exported.
11921 However, leave prepare_to_modify_buffer alone. It's never
11922 called from outside this function, but that appears to be a bug.
11923 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11924 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11925 (adjust_after_replace_noundo): Remove; unused.
11926 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11927 (signal_before_change): Remove decls.
77382fcc 11928
9306c32e
PE
11929 * indent.c (val_compute_motion, val_vmotion): Now static.
11930
cd44d2eb
PE
11931 * image.c: Make symbols static if they're not exported.
11932 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11933 if USE_GTK.
11934 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11935 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11936
ad9a7a06
PE
11937 * fringe.c (standard_bitmaps): Now static.
11938 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11939
81626931
PE
11940 * frame.c: Make symbols static if they're not exported.
11941 (x_report_frame_params, make_terminal_frame): Now static.
11942 (get_frame_param): Now static, unless HAVE_NS.
11943 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11944 (x_get_resource_string): Remove; not used.
11945 * frame.h (make_terminal_frame, x_report_frame_params):
11946 (x_get_resource_string); Remove decls.
11947 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11948 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11949
239f9db9
PE
11950 * font.c, fontset.c: Make symbols static if they're not exported.
11951 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11952 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11953 * font.c (font_close_object): Now static.
11954 * font.h (font_close_object): Remove.
11955 * fontset.c (FONTSET_OBJLIST): Remove.
11956 (free_realized_fontset) #if-0 the body, which does nothing.
11957 (face_suitable_for_char_p): #if-0, as it's never called.
11958 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11959 * xfaces.c (face_at_string_position):
11960 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11961 since 0 is always ASCII.
11962
dfcf3579
PE
11963 * fns.c (weak_hash_tables): Now static.
11964
5045092b
PE
11965 * fileio.c: Make symbols static if they're not exported.
11966 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11967 (Vwrite_region_annotation_buffers): Now static.
11968
57a96f5c
PE
11969 * eval.c: Make symbols static if they're not exported.
11970 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11971 * lisp.h (backtrace_list): Remove decl.
11972
35f08c38
PE
11973 * emacs.c: Make symbols static if they're not exported.
11974 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11975 (fatal_error_code, fatal_error_signal_hook, standard_args):
11976 Now static.
11977 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11978 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11979 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11980 * lisp.h (fatal_error_signal_hook): Remove decl.
11981 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11982
f44bd759
PE
11983 * editfns.c: Move a (normally-unused) function to its only use.
11984 * editfns.c, lisp.h (get_operating_system_release): Remove.
11985 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11986 worth the hassle of breaking this out.
11987
b532497d
PE
11988 * xterm.c: Make symbols static if they're not exported.
11989 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11990 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11991 (x_destroy_window, x_delete_display):
11992 Now static.
11993 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11994 (x_mouse_leave): Remove; unused.
11995 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11996 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11997 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11998 Remove decls.
11999 (x_mouse_leave): Declare only if WINDOWSNT.
12000 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12001 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12002 USE_X_TOOLKIT.
12003
1675728f
PE
12004 * ftxfont.c: Make symbols static if they're not exported.
12005 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12006 HAVE_FREETYPE.
12007 * font.h (ftxfont_driver): Likewise.
12008
e4cebfca
PE
12009 * xfns.c: Make symbols static if they're not exported.
12010 (x_last_font_name, x_display_info_for_name):
12011 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12012 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12013 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12014 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12015 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12016 (last_show_tip_args): Now static.
12017 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12018 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12019 (x_screen_planes): Remove; unused.
12020 * dispextern.h (x_screen_planes): Remove decl.
12021
5bf46f05
PE
12022 * dispnew.c: Make symbols static if they're not exported.
12023 * dispextern.h (redraw_garbaged_frames, scrolling):
12024 (increment_row_positions): Remove.
12025 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12026 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12027 Now static.
12028 (redraw_garbaged_frames): Remove; unused.
12029
435f4c28
PE
12030 * xfaces.c: Make symbols static if they're not exported.
12031 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12032 Remove decls.
12033 * xterm.h (defined_color): Remove decls.
12034 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12035 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12036 (menu_face_changed_default, defined_color, free_realized_face):
12037 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12038 (ascii_face_of_lisp_face): Remove; unused.
12039
8524aef3
PE
12040 * xdisp.c: Make symbols static if they're not exported.
12041 * dispextern.h (scratch_glyph_row, window_box_edges):
12042 (glyph_to_pixel_coords, set_cursor_from_row):
12043 (get_next_display_element, set_iterator_to_next):
12044 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12045 (show_mouse_face): Remove decls
12046 * frame.h (message_buf_print): Likewise.
12047 * lisp.h (pop_message, set_message, check_point_in_composition):
12048 Likewise.
12049 * xterm.h (set_vertical_scroll_bar): Likewise.
12050 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12051 (message_buf_print, scratch_glyph_row, displayed_buffer):
12052 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12053 (get_next_display_element, show_mouse_face, window_box_edges):
12054 (frame_to_window_pixel_xy, check_point_in_composition):
12055 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12056 (glyph_to_pixel_coords): Remove; unused.
12057
16390cd2
PE
12058 * dired.c (file_name_completion): Now static.
12059
12060 * dbusbind.c (xd_in_read_queued_messages): Now static.
12061
a25f4dfa
PE
12062 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12063 * data.c (circular_list_error): Remove.
12064
14a9c8df
PE
12065 * commands.h (last_point_position, last_point_position_buffer):
12066 (last_point_position_window): Remove decls.
12067 * keyboard.c: Make these variables static.
12068
04f2d78b
CB
12069 * coding.h (coding, code_convert_region, encode_coding_gap):
12070 Remove decls.
74ab6df5
PE
12071 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12072 (iso_code_class, detect_coding, code_convert_region): Now static.
12073 (encode_coding_gap): Remove; unused.
12074
38dfbee1
PE
12075 * chartab.c (chartab_chars, chartab_bits): Now static.
12076
a2cb4e63
PE
12077 * charset.h (charset_iso_8859_1): Remove decl.
12078 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12079 Now static.
12080
127198fd
PE
12081 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12082 * ccl.c (Vccl_program_table): Now static.
12083 (check_ccl_update): Remove; unused.
12084
d85b608f
PE
12085 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12086 * category.h: ... from here.
12087 * category.c (check_category_table, set_category_set): Now static.
12088
31cd66f3
PE
12089 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12090 * lisp.h: Remove these decls.
12091
c358e587
PE
12092 * buffer.c (buffer_count): Remove unused var.
12093
e78aecca
PE
12094 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12095 so that it's not optimized away.
12096 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12097 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12098 exported only to the debugger.
12099
e192d7d3 12100 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12101 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12102
92470028
PE
12103 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12104 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12105 was inaccessible from Lisp.
12106 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12107 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12108
244ed907
PE
12109 alloc.c: Import and export fewer symbols, and remove unused items.
12110 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12111 is defined.
12112 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12113 it's not optimized away by whole-program optimization.
12114 (message_enable_multibyte, free_misc): Remove.
12115 (catchlist, handlerlist, mark_backtrace):
12116 Declare only if BYTE_MARK_STACK.
12117 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12118 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12119 (message_enable_multibyte): Remove decl.
12120 (free_misc, interval_free_list, float_block, float_block_index):
12121 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12122 (cons_free_list, last_marked_index):
12123 Now static.
12124 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12125 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12126 (mark_backtrace): Define only if BYTE_MARK_STACK.
12127 * xdisp.c (message_enable_multibyte): Now static.
12128
61c2b50e 12129 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12130 This makes it easier for human readers (and static analyzers)
12131 to see whether these variables are used from other modules.
12132 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12133 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12134 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12135 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12136 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12137 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12138 * xmenu.c, xselect.c:
12139 Declare Q* vars static if they are not used in other modules.
12140 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12141 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12142 Remove decls of unexported vars.
12143 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12144
95c82688
PE
12145 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12146
16a97296
PE
12147 Make Emacs functions such as Fatom 'static' by default.
12148 This makes it easier for human readers (and static analyzers)
12149 to see whether these functions can be called from other modules.
12150 DEFUN now defines a static function. To make the function external
12151 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12152 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12153 (Finit_image_library):
16a97296
PE
12154 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12155 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12156 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12157 Remove decls, since these functions are now static.
12158 (Funintern, Fget_internal_run_time): New decls, since these functions
12159 were already external.
95c82688 12160
16a97296
PE
12161 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12162 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12163 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12164 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12165 * keyboard.c, keymap.c, lread.c:
12166 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12167 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12168 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12169 Mark functions with DEFUE instead of DEFUN,
12170 if they are used in other modules.
12171 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12172 decls for now-static functions.
12173 * buffer.h (Fdelete_overlay): Remove decl.
12174 * callproc.c (Fgetenv_internal): Mark as internal.
12175 * composite.c (Fremove_list_of_text_properties): Remove decl.
12176 (Fcomposition_get_gstring): New forward static decl.
12177 * composite.h (Fcomposite_get_gstring): Remove decl.
12178 * dired.c (Ffile_attributes): New forward static decl.
12179 * doc.c (Fdocumntation_property): New forward static decl.
12180 * eval.c (Ffetch_bytecode): New forward static decl.
12181 (Funintern): Remove extern decl; now in .h file where it belongs.
12182 * fileio.c (Fmake_symbolic_link): New forward static decl.
12183 * image.c (Finit_image_library): New forward static decl.
12184 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12185 * intervals.h (Fprevious_property_change):
12186 (Fremove_list_of_text_properties): Remove decls.
12187 * keyboard.c (Fthis_command_keys): Remove decl.
12188 (Fcommand_execute): New forward static decl.
12189 * keymap.c (Flookup_key): New forward static decl.
12190 (Fcopy_keymap): Now static.
12191 * keymap.h (Flookup_key): Remove decl.
12192 * process.c (Fget_process): New forward static decl.
12193 (Fprocess_datagram_address): Mark as internal.
12194 * syntax.c (Fsyntax_table_p): New forward static decl.
12195 (skip_chars): Remove duplicate decl.
12196 * textprop.c (Fprevious_property_change): New forward static decl.
12197 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12198 Now internal.
12199 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12200 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12201
785bbd42
PE
12202 * editfns.c (Fformat): Remove unreachable code.
12203
8b913b57
AS
122042011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12205
12206 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12207 change. (Bug#8496)
12208
a6744a35
EZ
122092011-04-13 Eli Zaretskii <eliz@gnu.org>
12210
12211 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12212 when at ZV. (Bug#8487)
12213
e7974947
AS
122142011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12215
baad03f0
AS
12216 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12217 (Bug#8437)
12218 * keyboard.c (parse_tool_bar_item): Likewise.
12219 * sound.c (sound_cleanup, alsa_close): Likewise.
12220 * termcap.c (tgetent): Likewise.
12221 * xfns.c (x_default_font_parameter): Likewise.
12222 * xsettings.c (read_and_apply_settings): Likewise.
12223
e7974947
AS
12224 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12225 (overrun_check_free): Protoize.
12226
28272684
PE
122272011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12228
12229 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12230 since callers should never pass a negative size.
12231 Change the signature to match that of plain 'read' and 'write'; see
12232 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12233 * lisp.h: Update prototypes of emacs_write and emacs_read.
12234
11997c76
EZ
122352011-04-11 Eli Zaretskii <eliz@gnu.org>
12236
12237 * xdisp.c (redisplay_window): Don't try to determine the character
12238 position of the scroll margin if the window start point w->startp
e896f03c 12239 is outside the buffer's accessible region. (Bug#8468)
11997c76 12240
8a2cbd72
EZ
122412011-04-10 Eli Zaretskii <eliz@gnu.org>
12242
12243 Fix write-region and its subroutines for buffers > 2GB.
12244 * fileio.c (a_write, e_write): Modify declaration of arguments and
12245 local variables to support buffers larger than 2GB.
12246 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12247
12248 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12249 argument, local variables, and return value.
12250
12251 * lisp.h: Update prototypes of emacs_write and emacs_read.
12252
12253 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12254
4073e537 122552011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12256
1ebfdcb6
PE
12257 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12258
b2ded58d
PE
12259 Fix more problems found by GCC 4.6.0's static checks.
12260
7d66342c
PE
12261 * xdisp.c (vmessage): Use a better test for character truncation.
12262
bbf47d44
PE
12263 * charset.c (load_charset_map): <, not <=, for optimization,
12264 and to avoid potential problems with integer overflow.
9248994d 12265 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12266 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12267 * editfns.c (Fformat): Likewise.
1e69125e 12268 * syntax.c (skip_chars): Likewise.
3befa583 12269
e3019616
PE
12270 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12271 This also lets GCC 4.6.0 generate slightly better loop code.
12272
becfa255
PE
12273 * callint.c (Fcall_interactively): <, not <=, for optimization.
12274 (Fcall_interactively): Count the number of arguments produced,
12275 not the number of arguments given. This is simpler and lets GCC
12276 4.6.0 generate slightly better code.
12277
dae0cd48
PE
12278 * ftfont.c: Distingish more carefully between FcChar8 and char.
12279 The previous code passed unsigned char * to a functions like
12280 strlen and xstrcasecmp that expect char *, which does not
12281 conform to the C standard.
12282 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12283 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12284 char * when the C standard requires it.
12285
76032d70
PE
12286 * keyboard.c (read_char): Remove unused var.
12287
eb3f1cc8
PE
12288 * eval.c: Port to Windows vsnprintf (Bug#8435).
12289 Include <limits.h>.
12290 (SIZE_MAX): Define if the headers do not.
12291 (verror): Do not give up if vsnprintf returns a negative count.
12292 Instead, grow the buffer. This ports to Windows vsnprintf, which
12293 does not conform to C99. Problem reported by Eli Zaretskii.
12294 Also, simplify the allocation scheme, by avoiding the need for
12295 calling realloc, and removing the ALLOCATED variable.
12296
70476b54
PE
12297 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12298
12020a9e
PE
12299 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12300 But keep the doprint source code for now, as we might revamp it
12301 and use it again (Bug#8435).
ea6c7ae6
PE
12302 * lisp.h (doprnt): Remove.
12303 * Makefile.in (base_obj): Remove doprnt.o.
12304 * deps.mk (doprnt.o): Remove.
12305
5fdb398c
PE
12306 error: Print 32- and 64-bit integers portably (Bug#8435).
12307 Without this change, on typical 64-bit hosts error ("...%d...", N)
12308 was used to print both 32- and 64-bit integers N, which relied on
12309 undefined behavior.
61bdb816 12310 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12311 * lisp.h (error, verror): Mark as printf-like functions.
12312 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12313 Report overflow in size calculations when allocating printf buffer.
12314 Do not truncate output string at its first null byte.
12315 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12316 Truncate the output at a character boundary, since vsnprintf does not
12317 do that.
12318 * charset.c (check_iso_charset_parameter): Convert internal
12319 character to string before calling 'error', since %c now has the
12320 printf meaning.
12321 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12322 overflow when computing char to be passed to 'error'. Do not
12323 pass Lisp_Object to 'error'; pass the integer instead.
12324 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12325 formatted with plain %d.
12326
b189fa66
PE
12327 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12328
bff87ef0
PE
12329 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12330
7e2cac20
PE
12331 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12332
ce4d90b5
PE
12333 * xterm.c (x_catch_errors): Remove duplicate declaration.
12334
266c9547
PE
12335 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12336
79c49ad2
PE
12337 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12338
368f4090
JM
123392011-04-10 Jim Meyering <meyering@redhat.com>
12340
12341 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12342 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12343 return ssize_t not "int", and use size_t as the buffer length.
12344 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12345 * gnutls.h: Update declarations.
12346 * process.c (read_process_output): Use ssize_t, to match.
12347 (send_process): Likewise.
12348
a32d4040
CY
123492011-04-09 Chong Yidong <cyd@stupidchicken.com>
12350
12351 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12352
8546720e 123532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12354
04f2d78b
CB
12355 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12356 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12357
8546720e
GM
12358 * xterm.c (handle_one_xevent):
12359 * xmenu.c (create_and_show_popup_menu):
12360 * xselect.c (x_decline_selection_request)
12361 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12362
0a2f5c1a 123632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12364
12365 Fix some uses of `int' instead of EMACS_INT.
12366 * search.c (string_match_1, fast_string_match)
12367 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12368 (scan_buffer, find_next_newline_no_quit)
12369 (find_before_next_newline, search_command, Freplace_match)
12370 (Fmatch_data): Make some `int' variables be EMACS_INT.
12371
12372 * xdisp.c (display_count_lines): 3rd argument and return value now
12373 EMACS_INT. All callers changed.
12374 (pint2hrstr): Last argument is now EMACS_INT.
12375
12376 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12377 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12378 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12379 (decode_coding_utf_16, decode_coding_emacs_mule)
12380 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12381 (decode_coding_ccl, decode_coding_charset)
12382 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12383 (decode_coding_iso_2022, decode_coding_emacs_mule)
12384 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12385 <char_offset, last_offset>: Declare EMACS_INT.
12386 (encode_coding_utf_8, encode_coding_utf_16)
12387 (encode_coding_emacs_mule, encode_invocation_designation)
12388 (encode_designation_at_bol, encode_coding_iso_2022)
12389 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12390 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12391 Declare EMACS_INT.
12392 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12393 (encode_invocation_designation): Last argument P_NCHARS is now
12394 EMACS_INT.
12395 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12396 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12397
12398 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12399 All users changed.
12400
12401 * ccl.c (Fccl_execute_on_string): Declare some variables
12402 EMACS_INT.
12403
8546720e 124042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12405
12406 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12407
4e19a977
CS
124082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12409
12410 * process.c (Fformat_network_address): Doc fix.
12411
87302331
R
124122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12413
ee7683eb 12414 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12415
cbb59342
CY
124162011-04-08 Chong Yidong <cyd@stupidchicken.com>
12417
12418 * keyboard.c (read_char): Call Lisp function help-form-show,
12419 instead of using internal_with_output_to_temp_buffer.
12420 (Qhelp_form_show): New var.
e0d38eeb 12421 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12422
12423 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12424
12425 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12426
e67a13ab
CY
124272011-04-06 Chong Yidong <cyd@stupidchicken.com>
12428
04f2d78b
CB
12429 * process.c (Flist_processes): Remove to Lisp.
12430 (list_processes_1): Delete.
e67a13ab 12431
973f782d
EZ
124322011-04-06 Eli Zaretskii <eliz@gnu.org>
12433
7c106b1e
EZ
12434 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12435
973f782d
EZ
12436 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12437
41cf7d1a 124382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12439
ca23cc88
PE
12440 Fix more problems found by GCC 4.6.0's static checks.
12441
f390e2d5
PE
12442 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12443
42eea0d0
PE
12444 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12445
b69769da 12446 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12447
f9541e84
PE
12448 * xdisp.c (vmessage): Mark as a printf-like function.
12449
13841b55
PE
12450 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12451
c136c10f
PE
12452 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12453
5e2d4a30
PE
12454 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12455 printf-like functions.
12456 (tiff_load): Add casts to remove these marks before passing them
12457 to system-supplied API.
12458
583f48b9
PE
12459 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12460
b25d760e
PE
12461 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12462 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12463 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12464 directly, rather than having caller test rule sign. This avoids
12465 some unnecessary tests.
12466 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12467 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12468 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12469
bc7b6697 12470 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12471 (xfont_open): Avoid unnecessary tests.
bc7b6697 12472
27ccc379
PE
12473 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12474
dcd5c89a
PE
12475 * composite.h, composite.c (composition_gstring_put_cache):
12476 Use EMACS_INT, not int, for length.
12477
b13a45c6
PE
12478 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12479 breaking out part of COMPOSITION_DECODE_RULE.
12480 (COMPOSITION_DECODE_RULE): Use it.
12481 * composite.c (get_composition_id): Remove unused local vars,
12482 by using the new macro.
12483
1e792e4d
PE
12484 * textprop.c (set_text_properties_1): Change while to do-while,
12485 since the condition is always true at first.
12486
dc6c6455 12487 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12488 (interval_deletion_adjustment): Return unsigned value.
12489 All uses changed.
dc6c6455 12490
aba7731a
PE
12491 * process.c (list_processes_1, create_pty, read_process_output):
12492 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12493 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12494 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12495 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12496 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12497
fdfc4bf3
PE
12498 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12499
fca8fe46 12500 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12501 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12502
06a0259a 12503 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12504 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12505 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12506
e7b9e80f
PE
12507 * print.c (print_error_message): Avoid int overflow.
12508
56201685
PE
12509 * font.c (font_list_entities): Redo for clarity,
12510 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12511
78834453 12512 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12513 (font_score): Avoid potential overflow in diff calculation.
78834453 12514
0bc0b309 12515 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12516 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12517
e610eaca
PE
12518 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12519
b895abce
PE
12520 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12521 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12522 can always succeed if overflow has undefined behavior.
12523
1f1d9321 12524 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12525 (wordify): Omit three unnecessary tests.
1f1d9321 12526
c59478bc
PE
12527 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12528 All callers changed. This avoids the need for an unused var.
12529
79b73827
PE
12530 * casefiddle.c (casify_region): Remove var that is set but not used.
12531
a4db5dfe
PE
12532 * dired.c (file_name_completion): Remove var that is set but not used.
12533
43aae36e
PE
12534 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12535
2a47c44d 12536 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12537 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12538
a37c69bf
PE
12539 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12540 Check for integer overflow on size calculations.
12541
328ab8e7
PE
12542 * buffer.c (Fprevious_overlay_change): Remove var that is set
12543 but not used.
12544
e5a2a5cb
PE
12545 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12546 Remove vars that are set but not used.
8d84a6eb 12547 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12548 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12549
a60e5f68
PE
12550 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12551
f661cb61 12552 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12553 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12554
f0397f5a
PE
12555 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12556 that are set but not used.
12557
8664db06 12558 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12559 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12560
6abdaa4a
PE
12561 * xselect.c (x_get_local_selection, x_handle_property_notify):
12562 Remove vars that are set but not used.
12563
0ce7538d 12564 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12565 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12566
9ae848fc
PE
12567 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12568 Remove var that is set but not used.
0b918413
PE
12569 (scroll_bar_windows_size): Now size_t, not int.
12570 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12571 Check for overflow.
9ae848fc 12572
a5a62657
PE
12573 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12574 (map_tty_color) [!defined MSDOS]: Likewise.
12575
5c5cdd39
PE
12576 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12577
66ebf983
PE
12578 * coding.c: Remove vars that are set but not used.
12579 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12580 All callers changed.
12581 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12582 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12583 (decode_coding_charset): Remove vars that are set but not used.
12584
1be4d761
PE
12585 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12586 that is set but not used.
12587
47553fa8
PE
12588 * print.c (print_object): Remove var that is set but not used.
12589
1f7196bf 12590 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12591 The gnulib version avoids calling malloc in the usual case,
12592 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12593 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12594 * filelock.c (current_lock_owner): Likewise.
12595 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12596 * sysdep.c: Include allocator.h, careadlinkat.h.
12597 (emacs_no_realloc_allocator): New static constant.
12598 (emacs_readlink): New function.
fdb61804
PE
12599 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12600 ../lib/careadlinkat.h.
d1fdcab7 12601
f84c17c7
SM
126022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12603
12604 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12605 first non-nil return value).
12606
ef3862ad
JD
126072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12608
12609 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12610 if not defined (Bug#8403).
12611
376a7006
JB
126122011-04-02 Juanma Barranquero <lekktu@gmail.com>
12613
12614 * xdisp.c (display_count_lines): Remove parameter `start',
12615 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12616 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12617 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12618 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12619 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12620 and thereabouts. All callers changed.
12621 (get_per_char_metric): Remove parameter `f', unused since
12622 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12623
6ca3801d
JM
126242011-04-02 Jim Meyering <meyering@redhat.com>
12625
12626 do not dereference NULL upon failed strdup
12627 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12628 (ns_get_family): Likewise.
12629
d8e2b5ba
JB
126302011-04-02 Juanma Barranquero <lekktu@gmail.com>
12631
12632 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12633
8c74fcbd
JD
126342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12635
12636 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12637 later (Bug#8403).
12638
7200d79c
SM
126392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12640
03408648 12641 Add lexical binding.
7200d79c 12642
03408648
SM
12643 * window.c (Ftemp_output_buffer_show): New fun.
12644 (Fsave_window_excursion):
12645 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12646
12647 * lread.c (lisp_file_lexically_bound_p): New function.
12648 (Fload): Bind Qlexical_binding.
12649 (readevalloop): Remove `evalfun' arg.
12650 Bind Qinternal_interpreter_environment.
12651 (Feval_buffer): Bind Qlexical_binding.
12652 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12653 Mark as dynamic.
12654 (syms_of_lread): Declare `lexical-binding'.
12655
12656 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12657
12658 * keyboard.c (eval_dyn): New fun.
12659 (menu_item_eval_property): Use it.
ca105506
SM
12660
12661 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12662
03408648
SM
12663 * fns.c (concat, mapcar1): Accept byte-code-functions.
12664
12665 * eval.c (Fsetq): Handle lexical vars.
12666 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12667 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12668 (FletX, Flet): Obey lexical binding.
12669 (Fcommandp): Handle closures.
12670 (Feval): New `lexical' arg.
12671 (eval_sub): New function extracted from Feval. Use it almost
12672 everywhere where Feval was used. Look up vars in lexical env.
12673 Handle closures.
12674 (Ffunctionp): Move from subr.el.
12675 (Ffuncall): Handle closures.
12676 (apply_lambda): Remove `eval_flags'.
12677 (funcall_lambda): Handle closures and new byte-code-functions.
12678 (Fspecial_variable_p): New function.
12679 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12680 but without exporting it to Lisp.
23aba0ea 12681
23aba0ea 12682 * doc.c (Fdocumentation, store_function_docstring):
03408648 12683 * data.c (Finteractive_form): Handle closures.
23aba0ea 12684
03408648
SM
12685 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12686 interactive spec.
ba83908c 12687
04f2d78b
CB
12688 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12689 New byte-codes.
03408648
SM
12690 (exec_byte_code): New function extracted from Fbyte_code to handle new
12691 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12692
03408648 12693 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12694
03408648 12695 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12696
e2abce01
JB
126972011-03-31 Juanma Barranquero <lekktu@gmail.com>
12698
12699 * xdisp.c (redisplay_internal): Fix prototype.
12700
63696a73 127012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12702
63696a73 12703 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12704 (try_scrolling): Use it when setting scroll_limit.
12705 Limit scrolling to 100 screen lines.
63696a73
EZ
12706 (redisplay_window): Even when falling back on "recentering",
12707 position point in the window according to scroll-conservatively,
12708 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12709
12710 (try_scrolling): When point is above the window, allow searching
12711 as far as scroll_max, or one screenful, to compute vertical
12712 distance from PT to the scroll margin position. This prevents
12713 try_scrolling from unnecessarily failing when
12714 scroll-conservatively is set to a value slightly larger than the
12715 window height. Clean up the case of PT below the margin at bottom
12716 of window: scroll_max can no longer be INT_MAX. When aggressive
12717 scrolling is in use, don't let point enter the opposite scroll
12718 margin as result of the scroll.
12719 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12720 threshold of 100 lines for never-recentering scrolling.
12721
e4cc2dfc
JB
127222011-03-31 Juanma Barranquero <lekktu@gmail.com>
12723
12724 * dispextern.h (move_it_by_lines):
12725 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12726 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12727 (message_log_check_duplicate): Remove parameters `prev_bol' and
12728 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12729 (redisplay_internal): Remove parameter `preserve_echo_area',
12730 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12731
12732 * indent.c (Fvertical_motion):
12733 * window.c (window_scroll_pixel_based, Frecenter):
12734 Don't pass `need_y_p' to `move_it_by_lines'.
12735
1c470562
SM
127362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12737
44f230aa
SM
12738 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12739 steal a few bits to be more compact.
12740 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12741 Remove unneeded casts.
12742
1c470562
SM
12743 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12744
888adce9
ZK
127452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12746
12747 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12748 binding" message (bug#7967).
12749
f838ed7b
PE
127502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12751
77861b95
PE
12752 Fix more problems found by GCC 4.6.0's static checks.
12753
de6dbc14
PE
12754 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12755 Remove unused local var.
12756
f838ed7b
PE
12757 * editfns.c (Fmessage_box): Remove unused local var.
12758
792c7b2b
PE
12759 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12760 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12761 Omit unused local vars.
c499e557 12762 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12763 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12764 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12765 Omit unused local var.
12766
ba0165e1
PE
12767 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12768 Don't assume string length fits in int.
32ad8845 12769 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12770 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12771
3c59b4c9
PE
12772 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12773 instead of alloca (Bug#8344).
12774
a3eed478 12775 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12776 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12777
eb4d412d
PE
12778 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12779
1658b401
PE
12780 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12781 concerns.
12782
12783 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12784
12785 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12786
9a2c6e05
PE
12787 * keyboard.c (syms_of_keyboard): Use the same style as later
12788 in this function when indexing through an array. This also
12789 works around GCC bug 48267.
12790
03d0a109
PE
12791 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12792
44f730c8
PE
12793 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12794
fe75f926
PE
12795 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12796 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12797
ffa8c828
PE
12798 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12799 This avoids undefined behavior on integer overflow, and is a bit
12800 more convenient anyway since it is compared to a size_t variable.
12801
c5101a77
PE
12802 Variadic C functions now count arguments with size_t, not int.
12803 This avoids an unnecessary limitation on 64-bit machines, which
12804 caused (substring ...) to crash on large vectors (Bug#8344).
12805 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12806 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12807 All variadic functions and their callers changed accordingly.
c5101a77
PE
12808 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12809 * data.c (arith_driver, float_arith_driver): Likewise.
12810 * editfns.c (general_insert_function): Likewise.
12811 * eval.c (struct backtrace.nargs, interactive_p)
12812 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12813 (funcall_lambda, mark_backtrace): Likewise.
12814 * fns.c (concat): Likewise.
12815 * frame.c (x_set_frame_parameters): Likewise.
12816 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12817 0 if not found, not -1. All callers changed.
12818
dd3f25f7
PE
12819 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12820 (stack_copy_size): Now size_t, not int.
12821 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12822
461c2ab9
JB
128232011-03-28 Juanma Barranquero <lekktu@gmail.com>
12824
12825 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12826 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12827 All callers changed.
12828
12829 * lisp.h (multibyte_char_to_unibyte):
12830 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12831 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12832 * character.h (CHAR_TO_BYTE8):
12833 * cmds.c (internal_self_insert):
12834 * editfns.c (general_insert_function):
12835 * keymap.c (push_key_description):
12836 * search.c (Freplace_match):
12837 * xdisp.c (message_dolog, set_message_1): All callers changed.
12838
f6d62986
SM
128392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12840
12841 * keyboard.c (safe_run_hook_funcall): New function.
12842 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12843 don't set the hook to nil, but remove the offending function instead.
12844 (Qcommand_hook_internal): Remove, unused.
12845 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12846 Vcommand_hook_internal.
12847
12848 * eval.c (enum run_hooks_condition): Remove.
12849 (funcall_nil, funcall_not): New functions.
12850 (run_hook_with_args): Call each function through a `funcall' argument.
12851 Remove `cond' argument, now redundant.
12852 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12853 (Frun_hook_with_args_until_failure): Adjust accordingly.
12854 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12855
1db5b1ad
JB
128562011-03-28 Juanma Barranquero <lekktu@gmail.com>
12857
12858 * dispextern.h (string_buffer_position): Remove declaration.
12859
12860 * print.c (strout): Remove parameter `multibyte', unused since
12861 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12862
12863 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12864 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12865 All callers changed.
12866
12867 * w32.c (_wsa_errlist): Use braces for struct initializers.
12868
12869 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12870 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12871 All callers changed.
12872 (string_buffer_position): Likewise. Also, make static (it's never
12873 used outside xdisp.c).
12874 (cursor_row_p): Remove parameter `w', unused since
12875 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12876 (decode_mode_spec): Remove parameter `precision', introduced during
12877 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12878 All callers changed.
12879
5ffb62aa
JD
128802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12881
12882 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12883
461c2ab9 128842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12885
12886 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12887 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12888 (ns_update_auto_hide_menu_bar): New functions.
12889 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12890 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12891 ns_constrain_all_frames.
12892 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12893 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12894
5c380ffb
JD
128952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12896
12897 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12898
9af30bdf
GM
128992011-03-27 Glenn Morris <rgm@gnu.org>
12900
12901 * syssignal.h: Replace RETSIGTYPE with void.
12902 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12903 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12904 Replace SIGTYPE with void everywhere.
12905 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12906 * s/template.h (SIGTYPE): Remove commented out definition.
12907
e2abce01
JB
129082011-03-26 Eli Zaretskii <eliz@gnu.org>
12909
12910 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12911 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12912
f868cd8a
JB
129132011-03-26 Juanma Barranquero <lekktu@gmail.com>
12914
59eb0929
JB
12915 * w32.c (read_unc_volume): Use parameter `henum', instead of
12916 global variable `wget_enum_handle'.
12917
12918 * keymap.c (describe_vector): Remove parameters `indices' and
12919 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12920 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12921
f868cd8a
JB
12922 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12923
12924 * keyboard.c (timer_check): Remove parameter `do_it_now',
12925 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12926 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12927 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12928
12929 * keyboard.c (read_char):
12930 * w32menu.c (w32_menu_display_help):
12931 * xmenu.c (show_help_event, menu_help_callback):
12932 Adjust calls to `show_help_echo'.
12933
12934 * gtkutil.c (xg_maybe_add_timer):
12935 * keyboard.c (readable_events):
12936 * process.c (wait_reading_process_output):
12937 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12938
12939 * insdel.c (adjust_markers_gap_motion):
12940 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12941 (gap_left, gap_right): Don't call it.
12942
2ecf6fdb
CY
129432011-03-25 Chong Yidong <cyd@stupidchicken.com>
12944
12945 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12946 incurred during fontification.
12947
6b1f9ba4
JB
129482011-03-25 Juanma Barranquero <lekktu@gmail.com>
12949
12950 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12951 (DEFVAR_PER_BUFFER): Don't pass it.
12952
12953 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12954 (scrolling_window): Don't pass it.
12955
0f4a96b5
JB
129562011-03-25 Juanma Barranquero <lekktu@gmail.com>
12957
12958 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12959
12960 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12961 and `suffix'.
12962 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12963 of variables specific to SELinux and computation of `encoded_absname'.
12964
12965 * image.c (XPutPixel): Remove unused variable `height'.
12966
12967 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12968
12969 * unexw32.c (get_section_info): Remove unused variable `section'.
12970
12971 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12972 (system_process_attributes): Remove unused variable `sess'.
12973 (sys_read): Remove unused variable `err'.
12974
12975 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12976 (w32_wnd_proc): Remove unused variable `isdead'.
12977 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12978 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12979 (x_create_tip_frame): Remove unused variable `tem'.
12980
12981 * w32inevt.c (w32_console_read_socket):
12982 Remove unused variable `no_events'.
12983
12984 * w32term.c (x_draw_composite_glyph_string_foreground):
12985 Remove unused variable `width'.
12986
1149507c
JB
129872011-03-24 Juanma Barranquero <lekktu@gmail.com>
12988
12989 * w32term.c (x_set_glyph_string_clipping):
12990 Don't pass uninitialized region to CombineRgn.
12991
9c88f339
JB
129922011-03-23 Juanma Barranquero <lekktu@gmail.com>
12993
12994 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12995 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12996 (Fx_close_connection): Remove unused variable `i'.
12997
12998 * w32font.c (w32font_draw): Return number of glyphs.
12999 (w32font_open_internal): Remove unused variable `i'.
13000 (w32font_driver): Add missing initializer.
13001
13002 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13003 (fill_in_menu): Remove unused variable `items_added'.
13004
13005 * w32term.c (last_mouse_press_frame): Remove static global variable.
13006 (w32_clip_to_row): Remove unused variable `f'.
13007 (x_delete_terminal): Remove unused variable `i'.
13008
13009 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13010 (NOTHING): Remove unused static global variable.
13011 (uniscribe_check_otf): Remove unused variable `table'.
13012 (uniscribe_font_driver): Add missing initializers.
13013
dee091a3
JD
130142011-03-23 Julien Danjou <julien@danjou.info>
13015
13016 * term.c (Fsuspend_tty, Fresume_tty):
13017 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13018 * window.c (temp_output_buffer_show):
13019 * insdel.c (signal_before_change):
13020 * frame.c (Fhandle_switch_frame):
13021 * fileio.c (Fdo_auto_save):
13022 * emacs.c (Fkill_emacs):
13023 * editfns.c (save_excursion_restore):
13024 * cmds.c (internal_self_insert):
13025 * callint.c (Fcall_interactively):
13026 * buffer.c (Fkill_all_local_variables):
13027 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13028 Use Frun_hooks.
0f4a96b5 13029 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13030 unconditionally since it does the check itself.
dee091a3 13031
2c520ab5 130322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13033
c9c49752
PE
13034 Fix more problems found by GCC 4.5.2's static checks.
13035
8abc3f12
PE
13036 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13037 the first time through the loop, since we know p0 < p1 then.
13038 This also avoids a gcc -Wstrict-overflow warning.
13039
a2d26660
PE
13040 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13041 leading to a memory leak, possible in functions like
13042 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13043 of objects (Bug#8318).
a2d26660 13044
916c72e9
PE
13045 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13046 that could (at least in theory) be that large.
13047
19ab8a18
PE
13048 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13049 This is less likely to overflow, and avoids undefined behavior if
13050 overflow does occur. All callers changed. Use strtoul to scan
13051 for the unsigned long integer.
b7cbbd6f
PE
13052 (pint2hrstr): Simplify and tune code slightly.
13053 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13054
f0641eff
PE
13055 * scroll.c (do_scrolling): Work around GCC bug 48228.
13056 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13057
7f650bb9
PE
13058 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13059 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13060 (validate_x_resource_name): Simplify count usage.
13061 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13062
37dd57d1
PE
13063 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13064 fail (Bug#8306).
81e56e61 13065
699979fc 13066 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13067
401bf9b4
PE
13068 * process.c (Fmake_network_process): Use socklen_t, not int,
13069 where POSIX says socklen_t is required in portable programs.
13070 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13071 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13072 (Fmake_network_process, server_accept_connection):
13073 (wait_reading_process_output, read_process_output):
13074 Likewise.
13075
b93aacde
PE
13076 * process.c: Rename or move locals to avoid shadowing.
13077 (list_processes_1, Fmake_network_process):
13078 (read_process_output_error_handler, exec_sentinel_error_handler):
13079 Rename or move locals.
4dc343ee 13080 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13081 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13082 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13083 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13084 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13085
af8a867c 13086 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13087 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13088 Include tparam.h instead, since it declares them.
af8a867c
PE
13089 * cm.h (PC): Remove extern decl; tparam.h now does this.
13090 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13091 * terminfo.c: Include tparam.h, to check interfaces.
13092 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13093 (tparam): Adjust signature to match interface in tparam.h;
13094 this removes some undefined behavior. Check that outstring and len
13095 are zero, which they always are with Emacs.
13096 * tparam.h (PC, BC, UP): New extern decls.
13097
0248044d 13098 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13099 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13100
8ff096c1 13101 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13102 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13103 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13104 (ftfont_list): Remove unused local.
49eaafba
PE
13105 (get_adstyle_property, ftfont_pattern_entity):
13106 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13107 Rename locals to avoid shadowing.
8ff096c1 13108
e2be39f6
PE
13109 * xfont.c (xfont_list_family): Mark var as initialized.
13110
c9735e30
PE
13111 * xml.c (make_dom): Now static.
13112
8f5201ae
PE
13113 * composite.c (composition_compute_stop_pos): Rename local to
13114 avoid shadowing.
b246f932
PE
13115 (composition_reseat_it): Remove unused locals.
13116 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13117 (composition_update_it): Mark var as initialized.
11b61122
PE
13118 (find_automatic_composition): Mark vars as initialized,
13119 with a FIXME (Bug#8290).
8f5201ae 13120
760fbc2c
PE
13121 character.h: Rename locals to avoid shadowing.
13122 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13123 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13124 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13125 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13126 to avoid shadowing.
13127
ff08eb85
PE
13128 * textprop.c (property_change_between_p): Remove; unused.
13129
fc7bf025
PE
13130 * intervals.c (interval_start_pos): Now static.
13131
235d7abc
PE
13132 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13133
44f230aa
SM
13134 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13135 Rename locals to avoid shadowing.
3e7d6594 13136
50060332
PE
13137 * sound.c (wav_play, au_play, Fplay_sound_internal):
13138 Fix pointer signedness.
d01f234b 13139 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13140 (wav_play): Initialize a variable to 0, to prevent undefined
13141 behavior (Bug#8278).
50060332 13142
c4fc4e30
PE
13143 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13144
918436ed
PE
13145 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13146
c939f91b
PE
13147 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13148 clobbering (Bug#8298).
b9c7f648
PE
13149 * sysdep.c (sys_subshell): Likewise.
13150 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13151
6bd8c144
PE
13152 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13153 This should get cleaned up, so that child_setup has the
13154 same signature on all platforms.
13155
7710357c 13156 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13157 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13158
c59da222
CY
131592011-03-22 Chong Yidong <cyd@stupidchicken.com>
13160
13161 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13162 not to be necessary, and produces flickering.
13163
66b87493
GM
131642011-03-20 Glenn Morris <rgm@gnu.org>
13165
13166 * config.in: Remove file.
13167
45b6f6d5
JB
131682011-03-20 Juanma Barranquero <lekktu@gmail.com>
13169
13170 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13171 are now in src/globals.h.
13172 (syms_of_minibuf): Remove spurious & from previous change.
13173
cd394be1 131742011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13175
13176 * minibuf.c (completing-read-function): New variable.
13177 (completing-read-default): Rename from completing-read.
13178 (completing-read): Call completing-read-function.
13179
b14e3e21
CY
131802011-03-19 Juanma Barranquero <lekktu@gmail.com>
13181
13182 * xfaces.c (Fx_load_color_file):
13183 Read color file from absolute filename (bug#8250).
13184
f2b726e6
JB
131852011-03-19 Juanma Barranquero <lekktu@gmail.com>
13186
13187 * makefile.w32-in: Update dependencies.
13188
09f6ff02
EZ
131892011-03-17 Eli Zaretskii <eliz@gnu.org>
13190
13191 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13192
29a6015a
PE
131932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13194
a3a6c54e
PE
13195 Fix more problems found by GCC 4.5.2's static checks.
13196
b766f867
PE
13197 * process.c (make_serial_process_unwind, send_process_trap):
13198 (sigchld_handler): Now static.
13199
be02381c
PE
13200 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13201 That way, the code declares only the vars that it needs.
13202 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13203 * s/cygwin.h (PTY_ITERATION): Likewise.
13204 * s/darwin.h (PTY_ITERATION): Likewise.
13205 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13206
57048744
PE
13207 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13208 * process.c (allocate_pty): Don't declare stb unless it's needed.
13209
7914961c 13210 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13211 (CONSTANTLIM): Remove; unused.
13212 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13213 Define only if needed.
7914961c 13214
b3967b18
PE
13215 * unexelf.c (unexec): Name an expression,
13216 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13217 Use a different way to cause a compilation error if anyone uses
13218 n rather than nn, a way that does not involve shadowing.
73366a00 13219 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13220
29a6015a
PE
13221 * deps.mk (unexalpha.o): Remove; unused.
13222
43cfc33e 13223 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13224 * unexec.h: New file.
ce701a33
PE
13225 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13226 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13227 Depend on unexec.h.
13228 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13229 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13230 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13231 Change as necessary to match prototype in unexec.h.
ce701a33 13232
01f44d5a
PE
13233 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13234 shadowing.
4f63c6bb 13235 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13236
a6670b0b
PE
13237 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13238 Rename locals to avoid shadowing.
13239
cef2010d 13240 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13241 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13242
d4d7173a
PE
13243 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13244
f08b802a
PE
13245 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13246 warning when compiling print.c.
13247
3ddb0639
PE
13248 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13249 instead of using an uninitialized var.
5ad03b97 13250 (font_sort_entities): Mark var as initialized.
3ddb0639 13251
170a2692
PE
13252 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13253
e663c700
PE
13254 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13255 pointers to constants.
89bc529a 13256 (font_parse_fcname): Remove unused vars.
7b81e2d0 13257 (font_delete_unmatched): Now static.
ea838e10 13258 (font_get_spec): Remove; unused.
13a547c6
PE
13259 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13260 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13261 Rename or move locals to avoid shadowing.
e663c700 13262
2a80c887 13263 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13264 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13265
1384fa33 13266 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13267 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13268
8b2c52e9
PE
13269 * alloc.c (mark_backtrace): Move decl from here ...
13270 * lisp.h: ... to here, so that it can be checked.
13271
475545b5 13272 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13273 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13274 (lisp_indirect_variable): Name an expression,
13275 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13276 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13277
b1349114 13278 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13279 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13280 Use const pointer when appropriate.
b1349114 13281
a2928364
PE
13282 * lisp.h (get_system_name, get_operating_system_release):
13283 Move decls here, to check interfaces.
13284 * process.c (get_operating_system_release): Move decl to lisp.h.
13285 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13286 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13287 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13288 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13289 (Fformat_time_string, Fencode_time, Finsert_char):
13290 (Ftranslate_region_internal, Fformat):
13291 Rename or remove local vars to avoid shadowing.
9710023e 13292 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13293
a415e694
PE
13294 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13295 avoid shadowing.
13296
8ef4622d
PE
13297 * lisp.h (eassert): Check that the argument compiles, even if
13298 ENABLE_CHECKING is not defined.
13299
946f9a5b
PE
13300 * data.c (Findirect_variable): Name an expression, to avoid
13301 gcc -Wbad-function-cast warning.
112396d6 13302 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13303 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13304 (Fmake_variable_buffer_local, Fmake_local_variable):
13305 Mark variables as initialized.
52746918 13306 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13307
e5aab7e7 13308 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13309 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13310 Rename locals to avoid shadowing.
dff45157
PE
13311 (mark_stack): Move local variables into the #ifdef region where
13312 they're used.
7bc26fdb
PE
13313 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13314 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13315 needed otherwise.
13316 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13317 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13318 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13319
e5aab7e7
PE
13320 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13321 avoids undefined behavior in theory.
13322
4da60324
PE
13323 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13324
88043301
PE
13325 Use functions, not macros, for up- and down-casing (Bug#8254).
13326 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13327 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13328 to use the following functions instead of these macros.
13329 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13330 EMACS_INT, since callers assume the returned value fits in int.
13331 (upcase1): Likewise, for UPCASE_TABLE.
13332 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13333 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13334 the race-condition problem in the old DOWNCASE.
88043301 13335
19ed5445
PE
13336 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13337 Rename locals to avoid shadowing.
13338 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13339 (regex_compile, re_search_2, re_match_2_internal):
13340 Remove unused local vars.
952db0d7
PE
13341 (FREE_VAR): Rewrite so as not to use empty "else",
13342 which gcc can warn about.
da053e48 13343 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13344 (RETALLOC_IF): Define only if needed.
13345 (WORDCHAR_P): Likewise. This one is never needed, but is used
13346 only in a comment talking about a compiler bug, so put inside
13347 the #if 0 of that comment.
13348 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13349 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13350 Remove; unused.
19ed5445 13351
1f3561e4 13352 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13353 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13354 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13355
ded6f8f7
PE
13356 * search.c (simple_search): Remove unused var.
13357
dbd37a95
PE
13358 * dired.c (compile_pattern): Move decl from here ...
13359 * lisp.h: ... to here, so that it can be checked.
13360 (struct re_registers): New forward decl.
13361
7e47afad
PE
13362 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13363
85f24f61
PE
13364 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13365 All uses changed.
13366 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13367 Rename locals to avoid shadowing.
5671df8f 13368 (Fvertical_motion): Mark locals as initialized.
85f24f61 13369
181aa2be 13370 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13371 (casify_region): Mark local as initialized.
181aa2be 13372
930d429c
PE
13373 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13374
7082eac6
PE
13375 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13376 New macros, so that the caller can use some names other than
13377 gcpro1, gcpro2, etc.
13378 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13379 of the new macros.
13380 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13381 argument, for consistency with GCPRO2_VAR, etc: it is now the
13382 prefix of the variable, not the variable itself. All uses
13383 changed.
38b2c076
PE
13384 * dired.c (directory_files_internal, file_name_completion):
13385 Rename locals to avoid shadowing.
13386
15206ed9
PE
13387 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13388 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13389 dired.c's scmp function, had undefined behavior.
13390 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13391 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13392 * buffer.h: ... to here, because these macros use current_buffer,
13393 and the new implementation with inline functions needs to have
13394 current_buffer in scope now, rather than later when the macros
13395 are used.
13396 (downcase, upcase1): New static inline functions.
13397 (DOWNCASE, UPCASE1): Reimplement using these functions.
13398 This avoids undefined behavior in expressions like
13399 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13400 from race conditions in accessing the global variables
13401 case_temp1 and case_temp2.
13402 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13403 * lisp.h (case_temp1, case_temp2): Remove their decls.
13404 * character.h (ASCII_CHAR_P): Move from here ...
13405 * lisp.h: ... to here, so that the inline functions mentioned
13406 above can use them.
13407
4a6bea26
PE
13408 * dired.c (directory_files_internal_unwind): Now static.
13409
f14b7e14
PE
13410 * fileio.c (file_name_as_directory, directory_file_name):
13411 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13412 Now static.
2893f146
PE
13413 (file_name_as_directory): Use const pointers when appropriate.
13414 (Fexpand_file_name): Likewise. In particular, newdir might
13415 point at constant storage, so make it a const pointer.
fd4ead52 13416 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13417 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13418 signedness issues.
f839df0c
PE
13419 (Fset_file_times, Finsert_file_contents, auto_save_error):
13420 Rename locals to avoid shadowing.
f14b7e14 13421
5716756e 13422 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13423 (Ftry_completion, Fall_completions): Rename or remove locals
13424 to avoid shadowing.
5716756e 13425
b4c3046a
PE
13426 * marker.c (bytepos_to_charpos): Remove; unused.
13427
b45db522
PE
13428 * lisp.h (verify_bytepos, count_markers): New decls,
13429 so that gcc does not warn that these functions aren't declared.
13430
85876d07
PE
13431 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13432 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13433 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13434 (copy_text): Remove unused local var.
85876d07 13435
03d78a21 13436 * filelock.c (within_one_second): Now static.
b3dd38ab 13437 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13438
5df8f01b
PE
13439 * buffer.c (fix_overlays_before): Mark locals as initialized.
13440 (fix_start_end_in_overlays): Likewise. This function should be
13441 simplified by using pointers-to-pointers, but that's a different
13442 matter.
b1d876f1 13443 (switch_to_buffer_1): Now static.
8f54f30a
PE
13444 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13445 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13446
a70072c9 13447 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13448 Fix pointer signedness issue.
edced198
PE
13449 (sys_subshell): Mark local as volatile if checking for lint,
13450 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13451 (MAXPATHLEN): Define only if needed.
a70072c9 13452
a0977c44
PE
13453 * process.c (serial_open, serial_configure): Move decls from here ...
13454 * systty.h: ... to here, so that they can be checked.
13455
a884fdcc
PE
13456 * fns.c (get_random, seed_random): Move extern decls from here ...
13457 * lisp.h: ... to here, so that they can be checked.
13458
604efe86 13459 * sysdep.c (reset_io): Now static.
b8950c94 13460 (wait_for_termination_signal): Remove; unused.
604efe86 13461
38fc62d9
PE
13462 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13463 (copy_keymap_item, append_key, push_text_char_description):
13464 Now static.
1004a21a 13465 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13466 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13467 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13468 (describe_map_tree):
13469 Rename locals to avoid shadowing.
38fc62d9 13470
2f2650da
PE
13471 * keyboard.c: Declare functions static if they are not used elsewhere.
13472 (echo_char, echo_dash, cmd_error, top_level_2):
13473 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13474 (read_char, kbd_buffer_get_event, make_lispy_position):
13475 (make_lispy_event, make_lispy_movement, apply_modifiers):
13476 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13477 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13478 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13479 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13480 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13481
a053e86c 13482 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13483 (mark_kboards): Move decl here ...
13484 * alloc.c (mark_kboards): ... from here.
a053e86c 13485
4752793e
PE
13486 * lisp.h (force_auto_save_soon): New decl.
13487
74f10ca7 13488 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13489 (DEFINE_DUMMY_FUNCTION): New macro.
13490 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13491 Use it.
c03cd23f
PE
13492 (main): Add casts to avoid warnings
13493 if GCC considers string literals to be constants.
74f10ca7 13494
022e70d4
PE
13495 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13496
59d6fe83
PE
13497 * dbusbind.c: Pointer signedness fixes.
13498 (xd_signature, xd_append_arg, xd_initialize):
13499 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13500 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13501 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13502 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13503
78320123
PE
13504 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13505 if GCC considers string literals to be constants.
49cebcca 13506 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13507
35ac2a97
SM
135082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13509
fb103ca9
SM
13510 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13511 (print_preprocess, print_object): New macro to fix last change.
13512
35ac2a97
SM
13513 * print.c (print_preprocess): Don't forget font objects.
13514
62973b41
JB
135152011-03-16 Juanma Barranquero <lekktu@gmail.com>
13516
13517 * emacs.c (USAGE3): Doc fixes.
13518
0e48bb22
AS
135192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13520
13521 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13522 structure.
13523
7684e57b
JB
135242011-03-14 Juanma Barranquero <lekktu@gmail.com>
13525
13526 * lisp.h (VWindow_system, Qfile_name_history):
13527 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13528 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13529 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13530
13531 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13532 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13533
13534 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13535 * w32console.c (detect_input_pending, read_input_pending)
13536 (encode_terminal_code):
13537 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13538 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13539 (w32_system_caret_y, Qfile_name_history):
13540 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13541 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13542 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13543 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13544 * w32proc.c (Qlocal, report_file_error):
13545 * w32term.c (Vwindow_system, updating_frame):
13546 * w32uniscribe.c (initialized, uniscribe_font_driver):
13547 Remove unneeded extern declarations.
13548
2aa46d6c
CY
135492011-03-14 Chong Yidong <cyd@stupidchicken.com>
13550
c96bbc66 13551 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13552
cffc6f3b
CY
135532011-03-13 Chong Yidong <cyd@stupidchicken.com>
13554
13555 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13556 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13557 These macros can no longer be used for assignment.
13558
44f230aa
SM
13559 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13560 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13561 (record_buffer_markers, fetch_buffer_markers): New functions for
13562 recording and fetching special buffer markers.
13563 (set_buffer_internal_1, set_buffer_temp): Use them.
13564
13565 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13566
13567 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13568
13569 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13570 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13571
13572 * xdisp.c (hscroll_window_tree):
13573 (reconsider_clip_changes): Use PT instead of BUF_PT.
13574
d251f04b
EZ
135752011-03-13 Eli Zaretskii <eliz@gnu.org>
13576
13577 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13578 $(EMACS_ROOT)/lib/intprops.h.
13579
f0c77cd1
PE
135802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13581
3eca4629
PE
13582 Fix more problems found by GCC 4.5.2's static checks.
13583
7c86ee98
PE
13584 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13585 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13586 (xg_free_frame_widgets): Make it clear that a local variable is
13587 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13588 (gdk_window_get_screen): Make it clear that this macro is needed
13589 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13590 (int_gtk_range_get_value): New function, which avoids a diagnostic
13591 from gcc -Wbad-function-cast.
13592 (xg_set_toolkit_scroll_bar_thumb): Use it.
13593 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13594 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13595 (get_utf8_string, xg_get_file_with_chooser):
13596 Rename locals to avoid shadowing.
13597 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13598
41729b81
PE
13599 * xgselect.c (xg_select): Remove unused var.
13600
f0c77cd1
PE
13601 * image.c (four_corners_best): Mark locals as initialized.
13602 (gif_load): Initialize transparent_p to zero (Bug#8238).
13603 Mark another local as initialized.
ec6cf4c6 13604 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13605
ce0ad53d 13606 * image.c (clear_image_cache): Now static.
d5d5a617 13607 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13608 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13609 (x_edge_detection): Remove unnecessary cast that
13610 gcc -Wbad-function-cast diagnoses.
2037898d 13611 (gif_load): Fix pointer signedness.
6ae141d6
PE
13612 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13613 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13614
33383987 136152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13616
d32df629
PE
13617 Improve quality of tests for time stamp overflow.
13618 For example, without this patch (encode-time 0 0 0 1 1
13619 1152921504606846976) returns the obviously-bogus value (-948597
13620 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13621 reports time overflow. See
13622 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13623 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13624 * editfns.c: Include limits.h and intprops.h.
13625 (TIME_T_MIN, TIME_T_MAX): New macros.
13626 (time_overflow): Move earlier, to before first use.
13627 (hi_time, lo_time): New functions, for an accurate test for
13628 out-of-range times.
13629 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13630 (Fget_internal_run_time): Don't assume time_t fits in int.
13631 (make_time): Use list2 instead of Fcons twice.
13632 (Fdecode_time): More accurate test for out-of-range times.
13633 (check_tm_member): New function.
13634 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13635 (lisp_time_argument): Don't rely on undefined left-shift and
13636 right-shift behavior when checking for time stamp overflow.
8be6f318 13637
fe31d94c
PE
13638 * editfns.c (time_overflow): New function, refactoring common code.
13639 (Fformat_time_string, Fdecode_time, Fencode_time):
13640 (Fcurrent_time_string): Use it.
13641
8be6f318
PE
13642 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13643 * dired.c (make_time): Move to ...
13644 * editfns.c (make_time): ... here.
13645 * systime.h: Note the move.
13646
09d9db2c 136472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13648
126bc0dc
YM
13649 * fringe.c (update_window_fringes): Remove unused variables.
13650
c47cbdfd
YM
13651 * unexmacosx.c (copy_data_segment): Also copy __got section.
13652 (Bug#8223)
13653
7ac80be9
EZ
136542011-03-12 Eli Zaretskii <eliz@gnu.org>
13655
c96bbc66 13656 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13657 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13658 Constify `char *' arguments and their references according to
13659 prototypes in tparam.h.
13660
ecb0f94d 13661 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13662
7ac80be9
EZ
13663 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13664 Adapt all references accordingly.
13665
13666 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13667
ef1fd07e
TT
136682011-03-11 Tom Tromey <tromey@redhat.com>
13669
13670 * buffer.c (syms_of_buffer): Remove obsolete comment.
13671
7ef4b50c
EZ
136722011-03-11 Eli Zaretskii <eliz@gnu.org>
13673
13674 * termhooks.h (encode_terminal_code): Declare prototype.
13675
13676 * msdos.c (encode_terminal_code): Don't declare prototype.
13677
13678 * term.c (encode_terminal_code): Now external again, used by
13679 w32console.c and msdos.c.
13680
44f230aa
SM
13681 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13682 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13683
4b1ec863 136842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13685
1714f52b 13686 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13687
4b1ec863
PE
13688 * fringe.c (update_window_fringes): Mark locals as initialized
13689 (Bug#8227).
13690 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13691
524c7aa6
PE
13692 * alloc.c (mark_fringe_data): Move decl from here ...
13693 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13694 to check its interface.
13695 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13696
a5c0af81 13697 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13698 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13699 (fontset_font): Mark local as initialized.
a9a06e0b 13700 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13701
b4716021
PE
13702 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13703
811e9bac 13704 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13705 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13706 (x_own_selection, Fx_disown_selection_internal): Rename locals
13707 to avoid shadowing.
13708 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13709
7e3ab302
PE
13710 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13711 so that the caller can use some name other than gcpro1.
13712 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13713 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13714 (Fx_backspace_delete_keys_p):
13715 Use them to avoid shadowing, and rename vars to avoid shadowing.
13716 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13717 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13718 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13719 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13720 Remove unused locals.
7e3ab302
PE
13721 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13722 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13723 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13724 macros.
f78faa98 13725
e2b13473
PE
13726 * xterm.h (x_mouse_leave): New decl.
13727
77f23912
PE
13728 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13729 Remove unused functions.
cdf4ba58
PE
13730 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13731 (x_calc_absolute_position): Now static.
7411c686 13732 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13733 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13734 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13735 unless they are used.
38d0b34a
PE
13736 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13737 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13738 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13739 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13740 (x_error_catcher, x_connection_closed, x_error_handler):
13741 (x_error_quitter, xembed_send_message, x_iconify_frame):
13742 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13743 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13744 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13745
44f230aa
SM
13746 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13747 Rename or move locals to avoid shadowing.
6b463e58 13748 (tty_defined_color, merge_face_heights): Now static.
5967d051 13749 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13750 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13751 does not deduce is never used uninitialized.
73719eba
PE
13752 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13753 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13754
426994c3 13755 * terminal.c (store_terminal_param): Now static.
5489860b 13756
032f1620 13757 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13758 (set_frame_menubar): Remove unused local.
d4323972 13759 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13760 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13761 since they might point to immutable storage.
281585b0
PE
13762 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13763 since it's unused otherwise.
032f1620 13764
367c19e5 13765 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13766 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13767 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13768 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13769 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13770 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13771 does not deduce are never used uninitialized.
70739cbe 13772
07b48fa9
PE
13773 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13774
8868a238 13775 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13776 * window.c (window_loop, size_window):
13777 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13778
7e5cf297 13779 * window.c (display_buffer): Now static.
d6550a9f
PE
13780 (size_window): Mark variables that gcc -Wuninitialized
13781 does not deduce are never used uninitialized.
a586633d
PE
13782 * window.h (check_all_windows): New decl, to forestall
13783 gcc -Wmissing-prototypes diagnostic.
5b555da1 13784 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13785
f6095868
PE
13786 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13787 shadowing.
13788 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13789 Include <limits.h>.
13790 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13791 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13792 (load_charset_map): Mark variables that gcc -Wuninitialized
13793 does not deduce are never used uninitialized.
53df7c11 13794 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13795
f38b440c
PE
13796 * coding.c (coding_set_source, coding_set_destination):
13797 Use "else { /* comment */ }" rather than "else /* comment */;"
13798 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13799 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13800 a block, when the outer 'i' will do.
13801 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13802 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13803 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13804 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13805 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13806 Rename locals to avoid shadowing.
13807 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13808 * coding.c (emacs_mule_char, encode_invocation_designation):
13809 Now static, since they're not used elsewhere.
413bb2db 13810 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13811 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13812 (decode_coding_emacs_mule): Mark variables that gcc
13813 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13814 (detect_coding_iso_2022): Initialize a local variable that might
13815 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13816 this initialization is needed. (Bug#8211)
5f58e762
PE
13817 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13818 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13819 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13820 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13821 Remove unused macros.
f38b440c 13822
232b38b9 13823 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13824 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13825 * character.c (string_count_byte8): Likewise.
232b38b9 13826
fb90da1b
PE
13827 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13828 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13829
fb93dbc2
PE
13830 * chartab.c (copy_sub_char_table): Now static, since it's not used
13831 elsewhere.
5c156ace
PE
13832 (sub_char_table_ref_and_range, char_table_ref_and_range):
13833 Rename locals to avoid shadowing.
bbcd0949 13834 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13835
7d3b3862 13836 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13837 (BIDI_BOB): Remove unused macro.
7d3b3862 13838
6be7d3da
PE
13839 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13840 deduce are never used uninitialized.
c2ed9c8b 13841 * term.c (encode_terminal_code): Likewise.
6be7d3da 13842
75f8807f 13843 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13844
50938595
PE
13845 * tparam.h: New file.
13846 * term.c, tparam.h: Include it.
13847 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13848 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13849 Move these decls to tparam.h, and make them agree with what
13850 is actually in tparam.c. The previous trick of using incompatible
13851 decls in different modules does not conform to the C standard.
13852 All callers of tparam changed to use tparam's actual API.
13853 * tparam.c (tparam1, tparam, tgoto):
13854 Use const pointers where appropriate.
13855
fbceeba2
PE
13856 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13857 * cm.h (struct cm): Likewise.
13858 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13859 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13860 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13861 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13862 (turn_on_face, init_tty): Likewise.
13863 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13864
7f3f1250
PE
13865 * term.c (term_mouse_position): Rename local to avoid shadowing.
13866
e6ca6543
PE
13867 * alloc.c (mark_ttys): Move decl from here ...
13868 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13869
c40f8d15
AS
138702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13871
13872 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13873
cfe0661d
JB
138742011-03-09 Juanma Barranquero <lekktu@gmail.com>
13875
13876 * search.c (compile_pattern_1): Remove argument regp, unused since
13877 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13878 (compile_pattern): Don't pass it.
13879
0afb4571
J
138802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13881
13882 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13883 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13884 for ! HAVE_GTK3.
13885 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13886
13887 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13888
13889 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13890 gdk_window_get_screen, gdk_window_get_geometry,
13891 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13892 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13893 (xg_get_pixbuf_from_pixmap): New function.
13894 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13895 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13896 Call xg_get_pixbuf_from_pixmap instead of
13897 gdk_pixbuf_get_from_drawable.
13898 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13899 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13900 (xg_check_special_colors): Use GtkStyleContext and its functions
13901 for HAVE_GTK3.
13902 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13903 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13904 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13905 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13906 Call gtk_widget_get_preferred_size.
0afb4571
J
13907 (xg_frame_resized): gdk_window_get_geometry only takes 5
13908 parameters.
44f230aa
SM
13909 (xg_win_to_widget, xg_event_is_for_menubar):
13910 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13911 (xg_set_widget_bg): New function.
13912 (delete_cb): New function.
895009e1 13913 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13914 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13915 (xg_set_background_color): Call xg_set_widget_bg.
13916 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13917 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13918 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13919 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13920 if ! HAVE_GTK3.
13921 (update_frame_tool_bar): Call gtk_widget_hide.
13922 (xg_initialize): Use GDK_KEY_g.
13923
13924 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13925 if ! HAVE_GTK3
13926 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13927
13928 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13929 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13930 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13931
1c2cc4ef
JB
139322011-03-08 Juanma Barranquero <lekktu@gmail.com>
13933
13934 * w32xfns.c (select_palette): Check success of RealizePalette against
13935 GDI_ERROR, not zero.
13936
33383987 13937See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13938
13939;; Local Variables:
13940;; coding: utf-8
aac0c6e3
MR
13941;; End:
13942
2f097256 13943 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13944
13945 This file is part of GNU Emacs.
13946
13947 GNU Emacs is free software: you can redistribute it and/or modify
13948 it under the terms of the GNU General Public License as published by
13949 the Free Software Foundation, either version 3 of the License, or
13950 (at your option) any later version.
13951
13952 GNU Emacs is distributed in the hope that it will be useful,
13953 but WITHOUT ANY WARRANTY; without even the implied warranty of
13954 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13955 GNU General Public License for more details.
13956
13957 You should have received a copy of the GNU General Public License
13958 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.