* keyboard.c (make_lispy_event): Fix problem in integer overflow.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d89eb65e
PE
12011-05-12 Paul Eggert <eggert@cs.ucla.edu>
2
8e55734a
PE
3 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4 Don't assume that the difference between two unsigned long values
5 can fit into an integer. At this point, we know button_down_time
6 <= event->timestamp, so the difference must be nonnegative, so
7 there's no need to cast the result if double-click-time is
8 nonnegative, as it should be; check that it's nonnegative, just in
9 case. This bug is triggered when events are more than 2**31 ms
10 apart (about 25 days).
11
841f1b75 12 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 13 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 14
3e26f69c
PE
15 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
16 that always fit in int. Use a sentinel instead of a counter, to
17 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
18 * frame.h (struct frame): Use int for menu_bar_items_used
19 instead of EMACS_INT, since it always fits in int.
3e26f69c 20
5cc152c0
PE
21 * menu.c (grow_menu_items): Check for int overflow.
22
d89eb65e
PE
23 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
24
78eb494e
PE
252011-05-11 Paul Eggert <eggert@cs.ucla.edu>
26
5235bd3e
PE
27 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
28 Before, the code was not consistent. These values cannot exceed
29 2**31 - 1 so there's no need to make them unsigned.
30 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
31 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
32 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
33 as modifiers.
34 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
35
bc827e23
PE
36 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
37 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
38 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
39 presumably because the widths might not match.
40
78eb494e
PE
41 * window.c (size_window): Avoid needless test at loop start.
42
2f142cc5
JB
432011-05-10 Juanma Barranquero <lekktu@gmail.com>
44
45 * image.c (Finit_image_library): Return t for built-in image types,
46 like pbm and xbm. (Bug#8640)
47
57679c86
AS
482011-05-09 Andreas Schwab <schwab@linux-m68k.org>
49
50 * w32menu.c (set_frame_menubar): Fix submenu allocation.
51
888c9e86
EZ
522011-05-07 Eli Zaretskii <eliz@gnu.org>
53
b0512a1d
EZ
54 * w32console.c (Fset_screen_color): Doc fix.
55 (Fget_screen_color): New function.
56 (syms_of_ntterm): Defsubr it.
57
888c9e86
EZ
58 * callproc.c (call_process_cleanup): Don't close and unlink the
59 temporary file if Fcall_process didn't create it in the first
60 place.
61 (Fcall_process): Don't create tempfile if stdout of the child
62 process will be redirected to a file specified with `:file'.
63 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
64 cue to call_process_cleanup not to close that handle.
65
4d3fcc8e
BK
662011-05-07 Ben Key <bkey76@gmail.com>
67
68 * makefile.w32-in: The bootstrap-temacs rule now makes use of
69 one of two shell specific rules, either bootstrap-temacs-CMD or
70 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
71 to the previous implementation of the bootstrap-temacs rule.
72 The bootstrap-temacs-CMD rule is similar to the previous
73 implementation of the bootstrap-temacs rule except that it
74 makes use of the ESC_CFLAGS variable instead of the CFLAGS
75 variable.
76
77 These changes, along with some changes to nt/configure.bat,
78 nt/gmake.defs, and nt/nmake.defs, are required to extend my
79 earlier fix to add support for --cflags and --ldflags options
80 that include quotes so that it works whether make uses cmd or
81 sh as the shell.
82
b4289b64
MA
832011-05-06 Michael Albinus <michael.albinus@gmx.de>
84
85 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
86 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
87 is a constant.
88 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
89 a string. Handle both cases.
90 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
91 (Fdbus_register_method): Use Qinvalid_function.
92
af4c0e28
JB
932011-05-06 Juanma Barranquero <lekktu@gmail.com>
94
95 * makefile.w32-in: Update dependencies.
96 (LISP_H): Add inttypes.h and stdin.h.
97 (PROCESS_H): Add unistd.h.
98
c51453d9
EZ
992011-05-06 Eli Zaretskii <eliz@gnu.org>
100
101 * lread.c: Include limits.h (fixes the MS-Windows build broken by
102 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
103
8ff0ac3c 1042011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 105
4c4b566b
PE
106 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
107
aab2b9b5
PE
108 * term.c (vfatal): Remove stray call to va_end.
109 It's not needed and the C Standard doesn't allow it here anyway.
110
c378da0b
PE
111 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
112 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
113
288b08c7
PE
114 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
115 bytes.
116
e3601888
PE
117 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
118
db6c0e74
PE
119 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
120
dd5963ea
PE
121 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
122
88c9450f
PE
123 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
124
2f9442b8
PE
125 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
126
c032b5f8
PE
127 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
128 * charset.c (Fdefine_charset_internal): Don't initialize
129 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 130 32-bit int (Bug#8600).
a108c10b
PE
131
132 * lread.c (read_integer): Be more consistent with string-to-number.
133 Use string_to_number to do the actual conversion; this avoids
134 rounding errors and fixes some other screwups. Without this fix,
135 for example, #x1fffffffffffffff was misread as -2305843009213693952.
136 (digit_to_number): Move earlier, for benefit of read_integer.
137 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 138 not a digit in any supported base. (Bug#8602)
a108c10b 139
ad5f9eea
PE
140 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
141
aec1708a
PE
142 * dispnew.c (scrolling_window): Return 1 if we scrolled,
143 to match comment at start of function. This also removes a
144 GCC warning about overflow in a 32+64-bit port.
145
47be4ab5
PE
146 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
147
371cac43
PE
148 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
149 Reported by Stefan Monnier in
150 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
151 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
152 SYMBOLP-guarded XSYMBOL, not XPNTR.
153
d01a7826
PE
154 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
155 (EMACS_UINTPTR): Likewise, with uintptr_t.
156
7fd47d5c
PE
157 * lisp.h: Prefer 64-bit EMACS_INT if available.
158 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
159 on 32-bit hosts that have 64-bit int, so that they can access
160 large files.
122b0c86
PE
161 However, temporarily disable this change unless the temporary
162 symbol WIDE_EMACS_INT is defined.
7fd47d5c 163
8727937b
PE
164 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
165
8ac068ac
PE
166 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
167 This removes an assumption that EMACS_INT and long are the same
168 width as pointers. The assumption is true for Emacs porting targets
169 now, but we want to make other targets possible.
170 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
171 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
172 In the rest of the code, change types of integers that hold casted
173 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
174 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
175 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
176 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
177 No need to cast type when ORing.
178 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
179 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
180 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
181 assume EMACS_INT is the same width as char *.
182 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
183 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
184 Remove no-longer-needed casts.
185 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
186 (xg_tool_bar_help_callback, xg_make_tool_item):
187 Use EMACS_INTPTR to hold an integer
188 that will be cast to void *; this can avoid a GCC warning
189 if EMACS_INT is not the same width as void *.
190 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
191 * xdisp.c (display_echo_area_1, resize_mini_window_1):
192 (current_message_1, set_message_1):
193 Use a local to convert to proper width without a cast.
194 * xmenu.c (dialog_selection_callback): Likewise.
195
ede49d71
PE
196 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
197 Also, don't assume VALBITS / RAND_BITS is less than 5,
198 and don't rely on undefined behavior when shifting a 1 left into
199 the sign bit.
200 * lisp.h (get_random): Change signature to match.
201
2f30ecd0
PE
202 * lread.c (hash_string): Use size_t, not int, for hash computation.
203 Normally we prefer signed values; but hashing is special, because
204 it's better to use unsigned division on hash table sizes so that
205 the remainder is nonnegative. Also, size_t is the natural width
206 for hashing into memory. The previous code used 'int', which doesn't
207 retain enough info to hash well into very large tables.
208 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
209
2a866e7b
PE
210 * dbusbind.c: Don't possibly lose pointer info when converting.
211 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
212 Use XPNTR rather than XHASH, so that the high-order bits of
213 the pointer aren't lost when converting through void *.
214
51639eac
PE
215 * eval.c (Fautoload): Don't double-shift a pointer.
216
92394119
PE
217 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
218
dbdb9a7c
JB
2192011-05-06 Juanma Barranquero <lekktu@gmail.com>
220
221 * gnutls.c (DEF_GNUTLS_FN):
222 * image.c (DEF_IMGLIB_FN): Make function pointers static.
223
db7a0b4f
AS
2242011-05-05 Andreas Schwab <schwab@linux-m68k.org>
225
226 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
227 marker. (Bug#8610)
228
f7ff1b0f 2292011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
230
231 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
232 New version that can reserve upto 2GB of heap space.
233
f7ff1b0f 2342011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
235
236 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
237
639c109b
TZ
2382011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
239
240 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
241 `gnutls_certificate_set_x509_key_file'.
242
d2127135
JB
2432011-05-05 Juanma Barranquero <lekktu@gmail.com>
244
245 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
246 Update dependencies.
247
e968f4f3
JB
2482011-05-04 Juanma Barranquero <lekktu@gmail.com>
249
250 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
251 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
252 Remove unused parameter `fildes'.
253 * process.c (read_process_output, send_process): Don't pass it.
254
84d358f0
JB
2552011-05-04 Juanma Barranquero <lekktu@gmail.com>
256
257 Fix previous change: the library cache is defined in w32.c.
258 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
259 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
260
0898ca10
JB
2612011-05-04 Juanma Barranquero <lekktu@gmail.com>
262
263 Implement dynamic loading of GnuTLS on Windows.
264
265 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
266 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
268 Declare.
269
270 * gnutls.c (Qgnutls_dll): Define.
271 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
272 (gnutls_*): Declare function pointers.
273 (init_gnutls_functions): New function to initialize function pointers.
274 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
275 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
276 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
277 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
278 (emacs_gnutls_write, emacs_gnutls_read)
279 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
280 (Fgnutls_available_p): New function.
281 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
282 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
283 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
284
285 * image.c: Include w32.h.
286 (Vimage_type_cache): Delete.
287 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
288 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
289 (w32_delayed_load): Move to w32.c.
290
291 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
292
293 * w32.c (QCloaded_from, Vlibrary_cache): Define.
294 (w32_delayed_load): Move from image.c. When loading a library, record
295 its filename in the :loaded-from property of the library id.
296 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
297 Initialize and staticpro them.
298 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
299
300 * process.c: Include lisp.h before w32.h, not after.
301 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
302 instead of gnutls_record_check_pending.
303
304 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
305
ff4de4aa
TZ
3062011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
307
308 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
309 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
310 as passed in.
311
abe95abb
JD
3122011-05-03 Jan Djärv <jan.h.d@swipnet.se>
313
314 * xterm.c (x_set_frame_alpha): Do not set property on anything
315 else than FRAME_X_OUTER_WINDOW (Bug#8608).
316
e16e55d4
JB
3172011-05-02 Juanma Barranquero <lekktu@gmail.com>
318
319 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
320
bafcf6a5
JB
3212011-05-02 Juanma Barranquero <lekktu@gmail.com>
322
323 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
324 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
325 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
326 (gnutls_global_initialized, Qgnutls_bootprop_priority)
327 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
328 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
329 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
330 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
331 (Qgnutls_bootprop_callbacks_verify): Make static.
332
e7a6747f
AS
3332011-05-01 Andreas Schwab <schwab@linux-m68k.org>
334
19ed11ba
AS
335 * callproc.c: Indentation fixup.
336
e7a6747f
AS
337 * sysdep.c (wait_for_termination_1): Make static.
338 (wait_for_termination, interruptible_wait_for_termination): Move
339 after wait_for_termination_1.
340
1ef14cb4
LMI
3412011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
342
343 * sysdep.c (interruptible_wait_for_termination): New function
344 which is like wait_for_termination, but allows keyboard
345 interruptions.
346
347 * callproc.c (Fcall_process): Add (:file "file") as an option for
348 the STDOUT buffer.
349 (Fcall_process_region): Ditto.
350
330d880c
EZ
3512011-04-30 Eli Zaretskii <eliz@gnu.org>
352
8db90b73
EZ
353 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
354 rather than `XVECTOR (FOO)->size'.
355
330d880c
EZ
356 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
357 inttypes.h, as a gnulib replacement is used if it not available in
358 system headers.
359
15cbd324
EZ
3602011-04-21 Eli Zaretskii <eliz@gnu.org>
361
362 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
363 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
364 of MOST_POSITIVE_FIXNUM. (Bug#8528)
365
366 * coding.c (coding_alloc_by_realloc): Error out if destination
367 will grow beyond MOST_POSITIVE_FIXNUM.
368 (decode_coding_emacs_mule): Abort if there isn't enough place in
369 charbuf for the composition carryover bytes. Reserve an extra
370 space for up to 2 characters produced in a loop.
371 (decode_coding_iso_2022): Abort if there isn't enough place in
372 charbuf for the composition carryover bytes.
373
3742011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 375
ae940cca
EZ
376 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
377 aborting when %lld or %lll format is passed.
378 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
379 %llo or %llx format is passed. (Bug#8545)
380
03ab8921
EZ
381 * window.c (window_scroll_line_based): Use a marker instead of
382 simple variables to record original value of point. (Bug#7952)
383
afda1437
EZ
384 * doprnt.c (doprnt): Fix the case where a multibyte sequence
385 produced by %s or %c overflows available buffer space. (Bug#8545)
386
f76dee0c
PE
3872011-04-28 Paul Eggert <eggert@cs.ucla.edu>
388
389 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 390 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 391
fdc5744d
JB
3922011-04-28 Juanma Barranquero <lekktu@gmail.com>
393
394 * w32.c (init_environment): Warn about defaulting HOME to C:\.
395
638f053a
JB
3962011-04-28 Juanma Barranquero <lekktu@gmail.com>
397
398 * keyboard.c (Qdelayed_warnings_hook): Define.
399 (command_loop_1): Run `delayed-warnings-hook'
400 if Vdelayed_warnings_list is non-nil.
401 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
402 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
403
d178f871
EZ
4042011-04-28 Eli Zaretskii <eliz@gnu.org>
405
406 * doprnt.c (doprnt): Don't return value smaller than the buffer
407 size if the message was truncated. (Bug#8545).
408
b124fd93
JB
4092011-04-28 Juanma Barranquero <lekktu@gmail.com>
410
411 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
412 (Fx_window_property): #if-0 the whole functions, not just the bodies.
413
e810457d
PE
4142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
415
416 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
417
ea51cceb
JB
4182011-04-27 Juanma Barranquero <lekktu@gmail.com>
419
420 * makefile.w32-in: Update dependencies.
421
94dcfacf
EZ
4222011-04-27 Eli Zaretskii <eliz@gnu.org>
423
424 Improve `doprnt' and its usage. (Bug#8545)
425 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
426 `format_end'. Remove support for %l as a conversion specifier.
427 Don't use xrealloc. Improve diagnostics when the %l size modifier
428 is used. Update the commentary.
429
430 * eval.c (verror): Simplify calculation of size_t.
431
432 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
433 messages.
434
f61f41d7
PE
4352011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
436
437 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
438 change.
439
96fb4434
PE
4402011-04-27 Paul Eggert <eggert@cs.ucla.edu>
441
442 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
443 This makes this file independent of the recent pseudovector change.
444
671875da 4452011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 446
69e9b5a3
PE
447 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
448
b5f869a7 449 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 450 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 451 Remove unused local.
c8926152 452 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 453
841a1577 454 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
455 GCC 4.6.0 optimizes based on type-based alias analysis. For
456 example, if b is of type struct buffer * and v of type struct
457 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
458 != &v->size, and therefore "v->size = 1; b->size = 2; return
459 v->size;" must therefore return 1. This assumption is incorrect
460 for Emacs, since it type-puns struct Lisp_Vector * with many other
461 types. To fix this problem, this patch adds a new type struct
f904488f 462 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
463 and pseudovectors, and helps optimizing compilers not get fooled
464 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
465 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
466 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
467 the size member.
eab3844f
PE
468 (XSETPVECTYPE): Rewrite in terms of new macro.
469 (XSETPVECTYPESIZE): New macro, specifying both type and size.
470 This is a bit clearer, and further avoids the possibility of
471 undesirable aliasing.
472 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 473 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
474 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
475 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
476 (ASIZE): Now uses header.size rather than size. All
477 previous uses of XVECTOR (foo)->size replaced to use this macro,
478 to avoid the hassle of writing XVECTOR (foo)->header.size.
479 (struct vectorlike_header): New type.
eab3844f
PE
480 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
481 object, to help avoid aliasing.
482 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
483 (SUBRP): Likewise, since Lisp_Subr is a special case.
484 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
485 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
486 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 487 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
488 changed to be "header.size" and "header.next".
489 * buffer.h (struct buffer): Likewise.
490 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
491 * frame.h (struct frame): Likewise.
492 * process.h (struct Lisp_Process): Likewise.
493 * termhooks.h (struct terminal): Likewise.
494 * window.c (struct save_window_data, struct saved_window): Likewise.
495 * window.h (struct window): Likewise.
496 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
497 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
498 * buffer.c (init_buffer_once): Likewise.
499 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
500 special case.
501 * process.c (Fformat_network_address): Use local var for size,
502 for brevity.
503
0df1eac5
PE
504 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
505
847ab9d1 506 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
507 * data.c (atof): Remove decl; no longer used or needed.
508 (digit_to_number): Move to lread.c.
509 (Fstring_to_number): Use new string_to_number function, to be
510 consistent with how the Lisp reader treats infinities and NaNs.
511 Do not assume that floating-point numbers represent EMACS_INT
512 without losing information; this is not true on most 64-bit hosts.
513 Avoid double-rounding errors, by insisting on integers when
514 parsing non-base-10 numbers, as the documentation specifies.
515 * lisp.h (string_to_number): New decl, replacing ...
516 (isfloat_string): Remove.
bc0a5c13 517 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 518 (read1): Do not accept +. and -. as integers; this
452f4150
PE
519 appears to have been a coding error. Similarly, do not accept
520 strings like +-1e0 as floating point numbers. Do not report
521 overflow for integer overflows unless the base is not 10 which
522 means we have no simple and reliable way to continue.
523 Break out the floating-point parsing into a new
524 function string_to_number, so that Fstring_to_number parses
525 floating point numbers consistently with the Lisp reader.
526 (digit_to_number): Moved here from data.c. Make it static inline.
527 (E_CHAR, EXP_INT): Remove, replacing with ...
528 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
529 (string_to_number): New function, replacing isfloat_string.
530 This function checks for valid syntax and produces the resulting
531 Lisp float number too. Rework it so that string-to-number
bc0a5c13 532 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
533 so that overflow for non-base-10 numbers is reported only when
534 there's no portable and simple way to convert to floating point.
452f4150 535
67769ffc
PE
536 * textprop.c (set_text_properties_1): Rewrite for clarity,
537 and to avoid GCC warning about integer overflow.
538
c20db43f
PE
539 * intervals.h (struct interval): Use EMACS_INT for members
540 where EMACS_UINT might cause problems. See
541 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
542 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
543 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
544 All uses changed.
37aa2f85
PE
545 (offset_intervals): Tell GCC not to worry about length overflow
546 when negating a negative length.
c20db43f 547
2538aa2f
PE
548 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
549 (overrun_check_free): Likewise.
550
f2d3008d
PE
551 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
552 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
553 word size.
554
ec8df744
PE
555 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
556 (gnutls_make_error): Rename local to avoid shadowing.
557 (gnutls_emacs_global_deinit): ifdef out; not used.
558 (Fgnutls_boot): Use const for pointer to readonly storage.
559 Comment out unused local. Fix pointer signedness problems.
560
640ee02d
PE
561 * lread.c (openp): Don't stuff size_t into an 'int'.
562 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
563 about possible signed overflow.
564
6048fb2a
PE
565 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
566 (GDK_KEY_g): Don't define if already defined.
567 (xg_prepare_tooltip): Avoid pointer signedness problem.
568 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
569
fa3c87e1
PE
570 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
571 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
572
2172544b
PE
573 * xfns.c (Fx_window_property): Simplify a bit,
574 to make a bit faster and to avoid GCC 4.6.0 warning.
575 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
576
9b821a21
PE
577 * fns.c (internal_equal): Don't assume size_t fits in int.
578
3c616cfa
PE
579 * alloc.c (compact_small_strings): Tighten assertion a little.
580
c2982e87
PE
581 Replace pEd with more-general pI, and fix some printf arg casts.
582 * lisp.h (pI): New macro, generalizing old pEd macro to other
583 conversion specifiers. For example, use "...%"pI"d..." rather
584 than "...%"pEd"...".
585 (pEd): Remove. All uses replaced with similar uses of pI.
586 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
587 * alloc.c (check_pure_size): Don't overflow by converting size to int.
588 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
589 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
590 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
591 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
592 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
593 64-bit hosts.
594 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
595 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
596 * print.c (safe_debug_print, print_object): Likewise.
597 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
598 to int.
6f04d126
PE
599 Use pI instead of if-then-else-abort. Use %p to avoid casts,
600 avoiding the 0 flag, which is not portable.
c2982e87
PE
601 * process.c (Fmake_network_process): Use pI to avoid cast.
602 * region-cache.c (pp_cache): Likewise.
603 * xdisp.c (decode_mode_spec): Likewise.
604 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
605 behavior on 64-bit hosts with printf arg.
6f04d126 606 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
607 (x_stop_queuing_selection_requests): Likewise.
608 (x_get_window_property): Don't truncate byte count to an 'int'
609 when tracing.
0b432f21 610
5e073ec7
PE
611 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
612 here, since it parses constructs like leading '-' and spaces,
613 which are not wanted; and it overflows with large numbers.
614 Instead, simply match F[0-9]+, which is what is wanted anyway.
615
36372bf9
PE
616 * alloc.c: Remove unportable assumptions about struct layout.
617 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
618 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
619 (allocate_vectorlike, make_pure_vector): Use the new macros,
620 plus offsetof, to remove unportable assumptions about struct layout.
621 These assumptions hold on all porting targets that I know of, but
622 they are not guaranteed, they're easy to remove, and removing them
623 makes further changes easier.
624
0b432f21
PE
625 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
626 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
627 (string_overrun_cookie): Now const. Use initializers that
628 don't formally overflow signed char, to avoid warnings.
000098c1
PE
629 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
630 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
631 (allocate_buffer): Don't assume sizeof (struct buffer) is a
632 multiple of sizeof (EMACS_INT); it need not be, if
633 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 634 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 635
895009e1
JB
6362011-04-26 Juanma Barranquero <lekktu@gmail.com>
637
638 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
639
6a7a1b0b
TZ
6402011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
641
642 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 643 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
644 Reported by Paul Eggert <eggert@cs.ucla.edu>.
645
841a1577 6462011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
647
648 * lisp.h (Qdebug): List symbol.
895009e1 649 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
650 * keyboard.c (debug-on-event): New variable.
651 (handle_user_signal): Break into debugger when debug-on-event
652 matches the current signal symbol.
653
f2d3ba6f
DN
6542011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
655
656 * alloc.c (check_sblock, check_string_bytes)
657 (check_string_free_list): Convert to standard C.
658
42ce4c63
TZ
6592011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
660
661 * w32.c (emacs_gnutls_push): Fix typo.
662
825cd63c
EZ
6632011-04-25 Eli Zaretskii <eliz@gnu.org>
664
fb11d64d
EZ
665 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
666 "cast to pointer from integer of different size".
667
825cd63c
EZ
668 Improve doprnt and its use in verror. (Bug#8545)
669 * doprnt.c (doprnt): Document the set of format control sequences
670 supported by the function. Use SAFE_ALLOCA instead of always
671 using `alloca'.
672
673 * eval.c (verror): Don't limit the buffer size at size_max-1, that
674 is one byte too soon. Don't use xrealloc; instead xfree and
675 xmalloc anew.
676
e061a11b
TZ
6772011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
678
679 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
680 callbacks stage.
681
682 * gnutls.c: Renamed global_initialized to
683 gnutls_global_initialized. Added internals for the
684 :verify-hostname-error, :verify-error, and :verify-flags
685 parameters of `gnutls-boot' and documented those parameters in the
686 docstring. Start callback support.
687 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
688 unless a fatal error occured. Call gnutls_alert_send_appropriate
689 on error. Return error code.
690 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
691 (emacs_gnutls_read): Likewise.
692 (Fgnutls_boot): Return handshake error code.
693 (emacs_gnutls_handle_error): New function.
694 (wsaerror_to_errno): Likewise.
695
696 * w32.h (emacs_gnutls_pull): Add prototype.
697 (emacs_gnutls_push): Likewise.
698
699 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
700 (emacs_gnutls_push): Likewise.
701
7022011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
703
704 * process.c (wait_reading_process_output): Check if GnuTLS
705 buffered some data internally if no FDs are set for TLS
706 connections.
707
708 * makefile.w32-in (OBJ2): Add gnutls.$(O).
709 (LIBS): Link to USER_LIBS.
710 ($(BLD)/gnutls.$(0)): New target.
711
fa6996bc
EZ
7122011-04-24 Eli Zaretskii <eliz@gnu.org>
713
eb35682e
EZ
714 * xdisp.c (handle_single_display_spec): Rename the
715 display_replaced_before_p argument into display_replaced_p, to
716 make it consistent with the commentary. Fix typos in the
717 commentary.
718
e2ad650c
EZ
719 * textprop.c (syms_of_textprop): Remove dead code.
720 (copy_text_properties): Delete obsolete commentary about an
721 interface that was deleted long ago. Fix typos in the description
722 of arguments.
723
1b2de274
EZ
724 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
725 to changes in oldXMenu/XMenu.h from 2011-04-16.
726 <menu_help_message, prev_menu_help_message>: Constify.
727 (IT_menu_make_room): menu->help_text is now `const char **';
728 adjust.
729
730 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
731 to changes in oldXMenu/XMenu.h from 2011-04-16.
732 (struct XMenu): Declare `help_text' `const char **'.
733
734 * xfaces.c <Qunspecified>: Make extern again.
735
736 * syntax.c: Include sys/types.h before including regex.h, as
737 required by Posix.
738
762b15be
EZ
739 * doc.c (get_doc_string): Improve the format passed to `error'.
740
741 * doprnt.c (doprnt): Improve commentary.
742
743 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
744
745 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
746 them with etags.
747
f1052e5d
EZ
748 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
749 changes in globals.h immediately force recompilation.
762b15be
EZ
750 (TAGS): Depend on $(CURDIR)/m/intel386.h and
751 $(CURDIR)/s/ms-w32.h.
752 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 753
fa6996bc
EZ
754 * character.c (Fchar_direction): Function deleted.
755 (syms_of_character): Don't defsubr it.
756 <char-direction-table>: Deleted.
757
e6c3da20
EZ
7582011-04-23 Eli Zaretskii <eliz@gnu.org>
759
760 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
761 * doprnt.c: Include limits.h.
762 (SIZE_MAX): New macro.
763 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
764 local variables are now size_t instead of int or unsigned.
765 Improve overflow protection. Support `l' modifier for integer
766 conversions. Support %l conversion. Don't assume an EMACS_INT
767 argument for integer conversions and for %c.
768
769 * lisp.h (doprnt): Restore prototype.
770
771 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
772 $(SRC)/character.h.
773
774 * Makefile.in (base_obj): Add back doprnt.o.
775
776 * deps.mk (doprnt.o): Add back prerequisites.
777 (callint.o): Depend on character.h.
778
779 * eval.c (internal_lisp_condition_case): Include the handler
780 representation in the error message.
781 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
782 when breaking from the loop.
783
784 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
785
786 * callint.c (Fcall_interactively): When displaying error message
787 about invalid control letter, pass the character's codepoint, not
788 a pointer to its multibyte form. Improve display of the character
789 in octal and display also its hex code.
790
791 * character.c (char_string): Use %x to display the (unsigned)
792 codepoint of an invalid character, to avoid displaying a bogus
793 negative value.
794
795 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
796 `error', not SYMBOL_NAME itself.
797
798 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
799 character arguments to `error'.
800
801 * charset.c (check_iso_charset_parameter): Fix incorrect argument
802 to `error' in error message about FINAL_CHAR argument. Make sure
803 FINAL_CHAR is a character, and use %c when it is passed as
804 argument to `error'.
805
4ffd0d6b 8062011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
807
808 * s/ms-w32.h (localtime): Redirect to sys_localtime.
809
810 * w32.c: Include <time.h>.
811 (sys_localtime): New function.
812
4ffd0d6b 8132011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
814
815 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
816
4ffd0d6b 817 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 818
4ffd0d6b 8192011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 820
4ffd0d6b
GM
821 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
822 zombies (Bug#8467).
aac0c6e3 823
04c56954
EZ
8242011-04-19 Eli Zaretskii <eliz@gnu.org>
825
826 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
827 gl_state.e_property when gl_state.object is Qt.
828
829 * insdel.c (make_gap_larger): Remove limitation of buffer size
830 to <= INT_MAX.
831
16a43933
CY
8322011-04-18 Chong Yidong <cyd@stupidchicken.com>
833
834 * xdisp.c (lookup_glyphless_char_display)
835 (produce_glyphless_glyph): Handle cons cell entry in
836 glyphless-char-display.
837 (Vglyphless_char_display): Document it.
838
839 * term.c (produce_glyphless_glyph): Handle cons cell entry in
840 glyphless-char-display.
841
4581706e
CY
8422011-04-17 Chong Yidong <cyd@stupidchicken.com>
843
844 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
845
846 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
847
848 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
849 definition for no-X builds.
850
4887c6e2 8512011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 852
fd35b6f9
PE
853 Static checks with GCC 4.6.0 and non-default toolkits.
854
5c1ccb01
PE
855 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
856
006c5daa
PE
857 * process.c (keyboard_bit_set): Define only if SIGIO.
858 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
859 (send_process): Repair possible setjmp clobbering.
860
efc736d3
PE
861 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
862
4e2fe2e6
PE
863 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
864
f97334a2
PE
865 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
866
4e75f29d
PE
867 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
868 Define only if needed.
869
90efadd1
PE
870 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
871 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 872 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 873
3c647824
PE
874 * dispextern.h (struct redisplay_interface): Rename param
875 to avoid shadowing.
e264f262 876 * termhooks.h (struct terminal): Likewise.
761383f4 877 * xterm.c (xembed_send_message): Likewise.
3c647824 878
b58c5c4a
PE
879 * insdel.c (make_gap_smaller): Define only if
880 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
881
cad59032
PE
882 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
883 it.
884
c339dc2e
PE
885 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
886 so that we aren't warned about unused symbols.
887
91a3e27b
PE
888 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
889
399c71d3 890 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 891
8ffc96f5
PE
892 * xfns.c (x_real_positions): Mark locals as initialized.
893
eef9bc79
PE
894 * xmenu.c (xmenu_show): Don't use uninitialized vars.
895
098db9dd
PE
896 * xterm.c: Fix problems found by static analysis with other toolkits.
897 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
898 (x_dispatch_event): Declare static if USE_GTK, and
899 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 900 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 901 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
902 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
903 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 904
eb18f6cc
PE
905 * xmenu.c (menu_help_callback): Pointer type fixes.
906 Use const pointers when pointing at readonly data. Avoid pointer
907 signedness clashes.
908 (FALSE): Remove unused macro.
909 (update_frame_menubar): Remove unused decl.
910
1fe72bf8
PE
911 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
912
60d9e1db
PE
913 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
914 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
915 (single_menu_item): Rename local to avoid shadowing.
916
39261c26
PE
917 * keyboard.c (make_lispy_event): Remove unused local var.
918
018c5e19
PE
919 * frame.c, frame.h (x_get_resource_string): Bring this back, but
920 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
921
63d2b86e
PE
922 * bitmaps: Change bitmaps from unsigned char back to the X11
923 compatible char. Avoid the old compiler warnings about
924 out-of-range initializers by using, for example, '\xab' rather
925 than 0xab.
926
aefd87e1
PE
927 * xgselect.c (xgselect_initialize): Check vs interface
928 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
929
bf501fb9
PE
930 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
931
e9829fdf
PE
932 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
933 to read-only memory.
934
1086c095
PE
935 * fns.c (vector): Remove; this old hack is no longer needed.
936
2baccd04 937 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 938 Remove unused var.
dde42981 939 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 940
72391843 941 * xrdb.c (x_load_resources): Omit unused local.
3565b346 942
436c16df 943 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 944 (x_window): Rename locals to avoid shadowing.
dc5ddd85 945 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 946
92bb796d 947 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 948 (x_term_init): Remove local to avoid shadowing.
92bb796d 949
764430a3 950 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
951
952 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
953 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
954
d1dfb56c
EZ
9552011-04-16 Eli Zaretskii <eliz@gnu.org>
956
c4354cb4
EZ
957 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
958
d1dfb56c
EZ
959 Fix regex.c, syntax.c and friends for buffers > 2GB.
960 * syntax.h (struct gl_state_s): Declare character position members
961 EMACS_INT.
962
963 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
964
965 * textprop.c (verify_interval_modification, interval_of): Declare
966 arguments EMACS_INT.
967
968 * intervals.c (adjust_intervals_for_insertion): Declare arguments
969 EMACS_INT.
970
971 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
972
973 * indent.c (Fvertical_motion): Local variable it_start is now
974 EMACS_INT.
975
976 * regex.c (re_match, re_match_2, re_match_2_internal)
977 (bcmp_translate, regcomp, regexec, print_double_string)
978 (group_in_compile_stack, re_search, re_search_2, regex_compile)
979 (re_compile_pattern, re_exec): Declare arguments and local
980 variables `size_t' and `ssize_t' and return values `regoff_t', as
981 appropriate.
982 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
983 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
984 <compile_stack_type>: `size' and `avail' are now `size_t'.
985
986 * regex.h <regoff_t>: Use ssize_t, not int.
987 (re_search, re_search_2, re_match, re_match_2): Arguments that
988 specify buffer/string position and length are now ssize_t and
989 size_t. Return type is regoff_t.
990
613052cd
BK
9912011-04-16 Ben Key <bkey76@gmail.com>
992
993 * nsfont.m: Fixed bugs in ns_get_family and
994 ns_descriptor_to_entity that were caused by using free to
995 deallocate memory blocks that were allocated by xmalloc (via
996 xstrdup). This caused Emacs to crash when compiled with
997 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
998 --enable-checking=xmallocoverrun). xfree is now used to
999 deallocate these memory blocks.
1000
4170f62f 10012011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1002
71b41406
PE
1003 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1004
9587a89d
PE
1005 emacs_write: Accept and return EMACS_INT for sizes.
1006 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1007 et seq.
1008 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1009 Accept and return EMACS_INT.
1010 (emacs_gnutls_write): Return the number of bytes written on
1011 partial writes.
1012 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1013 (emacs_read, emacs_write): Remove check for negative size, as the
1014 Emacs source code has been audited now.
9587a89d
PE
1015 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1016 (emacs_read, emacs_write): Use it.
273a5f82
PE
1017 * process.c (send_process): Adjust to the new signatures of
1018 emacs_write and emacs_gnutls_write. Do not attempt to store
1019 a byte offset into an 'int'; it might overflow.
9587a89d 1020 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1021
3e047f51
PE
1022 * sound.c: Don't assume sizes fit in 'int'.
1023 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1024 Return EMACS_INT, not int.
3e047f51 1025 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1026 Accept EMACS_INT, not int.
1027 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1028 record read return values.
1029
cc39a9db
BK
10302011-04-15 Ben Key <bkey76@gmail.com>
1031
c9d0ec6d
JB
1032 * keyboard.c (Qundefined): Don't declare static since it is used
1033 in nsfns.m.
1034 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1035 static since they are used in nsfont.m.
cc39a9db 1036
6c60eb9f
SM
10372011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1038
1039 * process.c (Qprocessp): Don't declare static.
1040 * lisp.h (Qprocessp): Declare again.
1041
7990b61a
JB
10422011-04-15 Juanma Barranquero <lekktu@gmail.com>
1043
1044 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1045
5d4cb038
PE
10462011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1047
8bd7b830 1048 Improve C-level modularity by making more things 'static'.
cd64ea1d 1049
e3b27b31
PE
1050 Don't publish debugger-only interfaces to other modules.
1051 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1052 (verify_bytepos, count_markers): Move decls to the only modules
1053 that need them.
1054 * region-cache.h (pp_cache): Likewise.
1055 * window.h (check_all_windows): Likewise.
1056 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1057
5d4cb038
PE
1058 * sysdep.c (croak): Now static, if
1059 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1060 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1061
1062 * alloc.c (refill_memory_reserve): Now static if
1063 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1064 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1065
e87b6180
PE
1066 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1067 Define only if USE_LUCID.
1068
ac64929e
PE
1069 * xrdb.c (x_customization_string, x_rm_string): Now static.
1070
6f37259d
PE
1071 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1072 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1073
1683e3ab
PE
1074 * xdisp.c (draw_row_with_mouse_face): Now static.
1075 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1076
de9c2632
PE
1077 * window.h (check_all_windows): Mark externally visible.
1078
2b96acb7
PE
1079 * window.c (window_deletion_count): Now static.
1080
1081 * undo.c: Make symbols static if they're not exported.
1082 (last_undo_buffer, last_boundary_position, pending_boundary):
1083 Now static.
1084
50436f33
PE
1085 * textprop.c (interval_insert_behind_hooks): Now static.
1086 (interval_insert_in_front_hooks): Likewise.
1087
64520e5c
PE
1088 * term.c: Make symbols static if they're not exported.
1089 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1090 (max_frame_lines, tty_set_terminal_modes):
1091 (tty_reset_terminal_modes, tty_turn_off_highlight):
1092 (get_tty_terminal): Now static.
1093 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1094 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1095 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1096 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1097 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1098
1fa53021
PE
1099 * sysdep.c: Make symbols static if they're not exported.
1100 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1101 Now static.
1102 (sigprocmask_set, full_mask): Remove; unused.
1103 (wait_debugging): Mark as visible.
1104 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1105 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1106
d4b43b22
PE
1107 * syntax.c (syntax_temp): Define only if !__GNUC__.
1108
b7c513d0
PE
1109 * sound.c (current_sound_device, current_sound): Now static.
1110
989b29ad
PE
1111 * search.c (searchbufs, searchbuf_head): Now static.
1112
13a55a78
PE
1113 * scroll.c (scroll_cost): Remove; unused.
1114 * dispextern.h (scroll_cost): Remove decl.
1115
de68a1fc
PE
1116 * region-cache.h (pp_cache): Mark as externally visible.
1117
40ccffa6
PE
1118 * process.c: Make symbols static if they're not exported.
1119 (process_tick, update_tick, create_process, chan_process):
1120 (Vprocess_alist, proc_buffered_char, datagram_access):
1121 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1122 (deactivate_process): Mark defn as static, as well as decl.
1123 * lisp.h (create_process): Remove decl.
1124 * process.h (chan_process, Vprocess_alist): Remove decls.
1125
ad64fc97
PE
1126 * print.c: Make symbols static if they're not exported.
1127 (print_depth, new_backquote_output, being_printed, print_buffer):
1128 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1129 (print_interval, print_number_index, initial_stderr_stream):
1130 Now static.
1131 * lisp.h (Fprinc): Remove decl.
1132 (debug_output_compilation_hack): Mark as externally visible.
1133
adddb265
PE
1134 * sysdep.c (croak): Move decl from here to syssignal.h.
1135 * syssignal.h (croak): Put it here, so the API can be checked when
1136 'croak' is called from dissociate_if_controlling_tty.
1137
1717ede2
PE
1138 * minibuf.c: Make symbols static if they're not exported.
1139 (minibuf_save_list, choose_minibuf_frame): Now static.
1140 * lisp.h (choose_minibuf_frame): Remove decl.
1141
fa5fb2bc
PE
1142 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1143
1e3890d1
PE
1144 * lread.c: Make symbols static if they're not exported.
1145 (read_objects, initial_obarray, oblookup_last_bucket_number):
1146 Now static.
1147 (make_symbol): Remove; unused.
1148 * lisp.h (initial_obarray, make_symbol): Remove decls.
1149
8a1414fa
PE
1150 * keyboard.c: Make symbols static if they're not exported.
1151 (single_kboard, recent_keys_index, total_keys, recent_keys):
1152 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1153 (this_single_command_key_start, echoing, last_auto_save):
1154 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1155 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1156 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1157 (Vlispy_mouse_stem, double_click_count):
1158 Now static.
1159 (force_auto_save_soon): Define only if SIGDANGER.
1160 (ignore_mouse_drag_p): Now static if
1161 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1162 (print_help): Remove; unused.
1163 (stop_character, last_timer_event): Mark as externally visible.
1164 * keyboard.h (ignore_mouse_drag_p): Declare only if
1165 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1166 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1167 * lisp.h (echoing): Remove decl.
1168 (force_auto_save_soon): Declare only if SIGDANGER.
1169 * xdisp.c (redisplay_window): Simplify code, to make it more
1170 obvious that ignore_mouse_drag_p is not accessed if !defined
1171 USE_GTK && !defined HAVE_NS.
1172
93ea6e8f
PE
1173 * intervals.c: Make symbols static if they're not exported.
1174 (merge_properties_sticky, merge_interval_right, delete_interval):
1175 Now static.
1176 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1177
77382fcc
PE
1178 * insdel.c: Make symbols static if they're not exported.
1179 However, leave prepare_to_modify_buffer alone. It's never
1180 called from outside this function, but that appears to be a bug.
1181 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1182 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1183 (adjust_after_replace_noundo): Remove; unused.
1184 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1185 (signal_before_change): Remove decls.
77382fcc 1186
9306c32e
PE
1187 * indent.c (val_compute_motion, val_vmotion): Now static.
1188
cd44d2eb
PE
1189 * image.c: Make symbols static if they're not exported.
1190 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1191 if USE_GTK.
1192 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1193 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1194
ad9a7a06
PE
1195 * fringe.c (standard_bitmaps): Now static.
1196 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1197
81626931
PE
1198 * frame.c: Make symbols static if they're not exported.
1199 (x_report_frame_params, make_terminal_frame): Now static.
1200 (get_frame_param): Now static, unless HAVE_NS.
1201 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1202 (x_get_resource_string): Remove; not used.
1203 * frame.h (make_terminal_frame, x_report_frame_params):
1204 (x_get_resource_string); Remove decls.
1205 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1206 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1207
239f9db9
PE
1208 * font.c, fontset.c: Make symbols static if they're not exported.
1209 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1210 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1211 * font.c (font_close_object): Now static.
1212 * font.h (font_close_object): Remove.
1213 * fontset.c (FONTSET_OBJLIST): Remove.
1214 (free_realized_fontset) #if-0 the body, which does nothing.
1215 (face_suitable_for_char_p): #if-0, as it's never called.
1216 * fontset.h (face_suitable_for_char_p): Remove decl.
1217 * xfaces.c (face_at_string_position): Use
1218 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1219 since 0 is always ASCII.
1220
dfcf3579
PE
1221 * fns.c (weak_hash_tables): Now static.
1222
5045092b
PE
1223 * fileio.c: Make symbols static if they're not exported.
1224 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1225 (Vwrite_region_annotation_buffers): Now static.
1226
57a96f5c
PE
1227 * eval.c: Make symbols static if they're not exported.
1228 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1229 * lisp.h (backtrace_list): Remove decl.
1230
35f08c38
PE
1231 * emacs.c: Make symbols static if they're not exported.
1232 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1233 (fatal_error_code, fatal_error_signal_hook, standard_args):
1234 Now static.
1235 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1236 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1237 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1238 * lisp.h (fatal_error_signal_hook): Remove decl.
1239 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1240
f44bd759
PE
1241 * editfns.c: Move a (normally-unused) function to its only use.
1242 * editfns.c, lisp.h (get_operating_system_release): Remove.
1243 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1244 worth the hassle of breaking this out.
1245
b532497d
PE
1246 * xterm.c: Make symbols static if they're not exported.
1247 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1248 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1249 (x_destroy_window, x_delete_display):
1250 Now static.
1251 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1252 (x_mouse_leave): Remove; unused.
1253 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1254 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1255 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1256 Remove decls.
1257 (x_mouse_leave): Declare only if WINDOWSNT.
1258 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1259 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1260 USE_X_TOOLKIT.
1261
1675728f
PE
1262 * ftxfont.c: Make symbols static if they're not exported.
1263 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1264 HAVE_FREETYPE.
1265 * font.h (ftxfont_driver): Likewise.
1266
e4cebfca
PE
1267 * xfns.c: Make symbols static if they're not exported.
1268 (x_last_font_name, x_display_info_for_name):
1269 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1270 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1271 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1272 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1273 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1274 (last_show_tip_args): Now static.
1275 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1276 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1277 (x_screen_planes): Remove; unused.
1278 * dispextern.h (x_screen_planes): Remove decl.
1279
5bf46f05
PE
1280 * dispnew.c: Make symbols static if they're not exported.
1281 * dispextern.h (redraw_garbaged_frames, scrolling):
1282 (increment_row_positions): Remove.
1283 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1284 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1285 Now static.
1286 (redraw_garbaged_frames): Remove; unused.
1287
435f4c28
PE
1288 * xfaces.c: Make symbols static if they're not exported.
1289 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1290 Remove decls.
1291 * xterm.h (defined_color): Remove decls.
1292 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1293 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1294 (menu_face_changed_default, defined_color, free_realized_face):
1295 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1296 (ascii_face_of_lisp_face): Remove; unused.
1297
8524aef3
PE
1298 * xdisp.c: Make symbols static if they're not exported.
1299 * dispextern.h (scratch_glyph_row, window_box_edges):
1300 (glyph_to_pixel_coords, set_cursor_from_row):
1301 (get_next_display_element, set_iterator_to_next):
1302 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1303 (show_mouse_face): Remove decls
1304 * frame.h (message_buf_print): Likewise.
1305 * lisp.h (pop_message, set_message, check_point_in_composition):
1306 Likewise.
1307 * xterm.h (set_vertical_scroll_bar): Likewise.
1308 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1309 (message_buf_print, scratch_glyph_row, displayed_buffer):
1310 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1311 (get_next_display_element, show_mouse_face, window_box_edges):
1312 (frame_to_window_pixel_xy, check_point_in_composition):
1313 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1314 (glyph_to_pixel_coords): Remove; unused.
1315
16390cd2
PE
1316 * dired.c (file_name_completion): Now static.
1317
1318 * dbusbind.c (xd_in_read_queued_messages): Now static.
1319
a25f4dfa
PE
1320 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1321 * data.c (circular_list_error): Remove.
1322
14a9c8df
PE
1323 * commands.h (last_point_position, last_point_position_buffer):
1324 (last_point_position_window): Remove decls.
1325 * keyboard.c: Make these variables static.
1326
74ab6df5
PE
1327 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1328 decls.
1329 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1330 (iso_code_class, detect_coding, code_convert_region): Now static.
1331 (encode_coding_gap): Remove; unused.
1332
38dfbee1
PE
1333 * chartab.c (chartab_chars, chartab_bits): Now static.
1334
a2cb4e63
PE
1335 * charset.h (charset_iso_8859_1): Remove decl.
1336 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1337 Now static.
1338
127198fd
PE
1339 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1340 * ccl.c (Vccl_program_table): Now static.
1341 (check_ccl_update): Remove; unused.
1342
d85b608f
PE
1343 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1344 * category.h: ... from here.
1345 * category.c (check_category_table, set_category_set): Now static.
1346
31cd66f3
PE
1347 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1348 * lisp.h: Remove these decls.
1349
c358e587
PE
1350 * buffer.c (buffer_count): Remove unused var.
1351
e78aecca
PE
1352 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1353 so that it's not optimized away.
1354 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1355 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1356 exported only to the debugger.
1357
e192d7d3
PE
1358 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1359 * atimer.h (run_all_atimers): Removed; not exported.
1360
92470028
PE
1361 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1362 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1363 was inaccessible from Lisp.
1364 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1365 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1366
244ed907
PE
1367 alloc.c: Import and export fewer symbols, and remove unused items.
1368 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1369 is defined.
1370 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1371 it's not optimized away by whole-program optimization.
1372 (message_enable_multibyte, free_misc): Remove.
1373 (catchlist, handlerlist, mark_backtrace):
1374 Declare only if BYTE_MARK_STACK.
1375 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1376 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1377 (message_enable_multibyte): Remove decl.
1378 (free_misc, interval_free_list, float_block, float_block_index):
1379 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1380 (cons_free_list, last_marked_index):
1381 Now static.
1382 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1383 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1384 (mark_backtrace): Define only if BYTE_MARK_STACK.
1385 * xdisp.c (message_enable_multibyte): Now static.
1386
61c2b50e 1387 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1388 This makes it easier for human readers (and static analyzers)
1389 to see whether these variables are used from other modules.
1390 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1391 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1392 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1393 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1394 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1395 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1396 * xmenu.c, xselect.c:
1397 Declare Q* vars static if they are not used in other modules.
1398 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1399 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1400 Remove decls of unexported vars.
1401 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1402
95c82688
PE
1403 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1404
16a97296
PE
1405 Make Emacs functions such as Fatom 'static' by default.
1406 This makes it easier for human readers (and static analyzers)
1407 to see whether these functions can be called from other modules.
1408 DEFUN now defines a static function. To make the function external
1409 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1410 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1411 (Finit_image_library):
16a97296
PE
1412 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1413 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1414 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1415 Remove decls, since these functions are now static.
1416 (Funintern, Fget_internal_run_time): New decls, since these functions
1417 were already external.
95c82688 1418
16a97296
PE
1419 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1420 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1421 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1422 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1423 * keyboard.c, keymap.c, lread.c:
1424 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1425 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1426 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1427 Mark functions with DEFUE instead of DEFUN,
1428 if they are used in other modules.
1429 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1430 decls for now-static functions.
1431 * buffer.h (Fdelete_overlay): Remove decl.
1432 * callproc.c (Fgetenv_internal): Mark as internal.
1433 * composite.c (Fremove_list_of_text_properties): Remove decl.
1434 (Fcomposition_get_gstring): New forward static decl.
1435 * composite.h (Fcomposite_get_gstring): Remove decl.
1436 * dired.c (Ffile_attributes): New forward static decl.
1437 * doc.c (Fdocumntation_property): New forward static decl.
1438 * eval.c (Ffetch_bytecode): New forward static decl.
1439 (Funintern): Remove extern decl; now in .h file where it belongs.
1440 * fileio.c (Fmake_symbolic_link): New forward static decl.
1441 * image.c (Finit_image_library): New forward static decl.
1442 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1443 * intervals.h (Fprevious_property_change):
1444 (Fremove_list_of_text_properties): Remove decls.
1445 * keyboard.c (Fthis_command_keys): Remove decl.
1446 (Fcommand_execute): New forward static decl.
1447 * keymap.c (Flookup_key): New forward static decl.
1448 (Fcopy_keymap): Now static.
1449 * keymap.h (Flookup_key): Remove decl.
1450 * process.c (Fget_process): New forward static decl.
1451 (Fprocess_datagram_address): Mark as internal.
1452 * syntax.c (Fsyntax_table_p): New forward static decl.
1453 (skip_chars): Remove duplicate decl.
1454 * textprop.c (Fprevious_property_change): New forward static decl.
1455 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1456 Now internal.
1457 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1458 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1459
785bbd42
PE
1460 * editfns.c (Fformat): Remove unreachable code.
1461
8b913b57
AS
14622011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1463
1464 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1465 change. (Bug#8496)
1466
a6744a35
EZ
14672011-04-13 Eli Zaretskii <eliz@gnu.org>
1468
1469 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1470 when at ZV. (Bug#8487)
1471
e7974947
AS
14722011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1473
baad03f0
AS
1474 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1475 (Bug#8437)
1476 * keyboard.c (parse_tool_bar_item): Likewise.
1477 * sound.c (sound_cleanup, alsa_close): Likewise.
1478 * termcap.c (tgetent): Likewise.
1479 * xfns.c (x_default_font_parameter): Likewise.
1480 * xsettings.c (read_and_apply_settings): Likewise.
1481
e7974947
AS
1482 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1483 (overrun_check_free): Protoize.
1484
28272684
PE
14852011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1488 since callers should never pass a negative size.
1489 Change the signature to match that of plain 'read' and 'write'; see
1490 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1491 * lisp.h: Update prototypes of emacs_write and emacs_read.
1492
11997c76
EZ
14932011-04-11 Eli Zaretskii <eliz@gnu.org>
1494
1495 * xdisp.c (redisplay_window): Don't try to determine the character
1496 position of the scroll margin if the window start point w->startp
e896f03c 1497 is outside the buffer's accessible region. (Bug#8468)
11997c76 1498
8a2cbd72
EZ
14992011-04-10 Eli Zaretskii <eliz@gnu.org>
1500
1501 Fix write-region and its subroutines for buffers > 2GB.
1502 * fileio.c (a_write, e_write): Modify declaration of arguments and
1503 local variables to support buffers larger than 2GB.
1504 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1505
1506 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1507 argument, local variables, and return value.
1508
1509 * lisp.h: Update prototypes of emacs_write and emacs_read.
1510
1511 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1512
4073e537 15132011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1514
1ebfdcb6
PE
1515 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1516
b2ded58d
PE
1517 Fix more problems found by GCC 4.6.0's static checks.
1518
7d66342c
PE
1519 * xdisp.c (vmessage): Use a better test for character truncation.
1520
bbf47d44
PE
1521 * charset.c (load_charset_map): <, not <=, for optimization,
1522 and to avoid potential problems with integer overflow.
9248994d 1523 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1524 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1525 * editfns.c (Fformat): Likewise.
1e69125e 1526 * syntax.c (skip_chars): Likewise.
3befa583 1527
e3019616
PE
1528 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1529 This also lets GCC 4.6.0 generate slightly better loop code.
1530
becfa255
PE
1531 * callint.c (Fcall_interactively): <, not <=, for optimization.
1532 (Fcall_interactively): Count the number of arguments produced,
1533 not the number of arguments given. This is simpler and lets GCC
1534 4.6.0 generate slightly better code.
1535
dae0cd48
PE
1536 * ftfont.c: Distingish more carefully between FcChar8 and char.
1537 The previous code passed unsigned char * to a functions like
1538 strlen and xstrcasecmp that expect char *, which does not
1539 conform to the C standard.
1540 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1541 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1542 char * when the C standard requires it.
1543
76032d70
PE
1544 * keyboard.c (read_char): Remove unused var.
1545
eb3f1cc8
PE
1546 * eval.c: Port to Windows vsnprintf (Bug#8435).
1547 Include <limits.h>.
1548 (SIZE_MAX): Define if the headers do not.
1549 (verror): Do not give up if vsnprintf returns a negative count.
1550 Instead, grow the buffer. This ports to Windows vsnprintf, which
1551 does not conform to C99. Problem reported by Eli Zaretskii.
1552 Also, simplify the allocation scheme, by avoiding the need for
1553 calling realloc, and removing the ALLOCATED variable.
1554
70476b54
PE
1555 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1556
12020a9e
PE
1557 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1558 But keep the doprint source code for now, as we might revamp it
1559 and use it again (Bug#8435).
ea6c7ae6
PE
1560 * lisp.h (doprnt): Remove.
1561 * Makefile.in (base_obj): Remove doprnt.o.
1562 * deps.mk (doprnt.o): Remove.
1563
5fdb398c
PE
1564 error: Print 32- and 64-bit integers portably (Bug#8435).
1565 Without this change, on typical 64-bit hosts error ("...%d...", N)
1566 was used to print both 32- and 64-bit integers N, which relied on
1567 undefined behavior.
1568 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1569 New macro.
1570 * lisp.h (error, verror): Mark as printf-like functions.
1571 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1572 Report overflow in size calculations when allocating printf buffer.
1573 Do not truncate output string at its first null byte.
1574 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1575 Truncate the output at a character boundary, since vsnprintf does not
1576 do that.
1577 * charset.c (check_iso_charset_parameter): Convert internal
1578 character to string before calling 'error', since %c now has the
1579 printf meaning.
1580 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1581 overflow when computing char to be passed to 'error'. Do not
1582 pass Lisp_Object to 'error'; pass the integer instead.
1583 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1584 formatted with plain %d.
1585
b189fa66
PE
1586 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1587
bff87ef0
PE
1588 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1589
7e2cac20
PE
1590 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1591
ce4d90b5
PE
1592 * xterm.c (x_catch_errors): Remove duplicate declaration.
1593
266c9547
PE
1594 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1595
79c49ad2
PE
1596 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1597
368f4090
JM
15982011-04-10 Jim Meyering <meyering@redhat.com>
1599
1600 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1601 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1602 return ssize_t not "int", and use size_t as the buffer length.
1603 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1604 * gnutls.h: Update declarations.
1605 * process.c (read_process_output): Use ssize_t, to match.
1606 (send_process): Likewise.
1607
a32d4040
CY
16082011-04-09 Chong Yidong <cyd@stupidchicken.com>
1609
1610 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1611
8546720e 16122011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1613
8546720e
GM
1614 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1615 unsigned char, to match FcChar8 type definition.
aac0c6e3 1616
8546720e
GM
1617 * xterm.c (handle_one_xevent):
1618 * xmenu.c (create_and_show_popup_menu):
1619 * xselect.c (x_decline_selection_request)
1620 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1621
0a2f5c1a 16222011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1623
1624 Fix some uses of `int' instead of EMACS_INT.
1625 * search.c (string_match_1, fast_string_match)
1626 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1627 (scan_buffer, find_next_newline_no_quit)
1628 (find_before_next_newline, search_command, Freplace_match)
1629 (Fmatch_data): Make some `int' variables be EMACS_INT.
1630
1631 * xdisp.c (display_count_lines): 3rd argument and return value now
1632 EMACS_INT. All callers changed.
1633 (pint2hrstr): Last argument is now EMACS_INT.
1634
1635 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1636 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1637 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1638 (decode_coding_utf_16, decode_coding_emacs_mule)
1639 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1640 (decode_coding_ccl, decode_coding_charset)
1641 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1642 (decode_coding_iso_2022, decode_coding_emacs_mule)
1643 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1644 <char_offset, last_offset>: Declare EMACS_INT.
1645 (encode_coding_utf_8, encode_coding_utf_16)
1646 (encode_coding_emacs_mule, encode_invocation_designation)
1647 (encode_designation_at_bol, encode_coding_iso_2022)
1648 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1649 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1650 Declare EMACS_INT.
1651 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1652 (encode_invocation_designation): Last argument P_NCHARS is now
1653 EMACS_INT.
1654 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1655 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1656
1657 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1658 All users changed.
1659
1660 * ccl.c (Fccl_execute_on_string): Declare some variables
1661 EMACS_INT.
1662
8546720e 16632011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1664
1665 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1666
4e19a977
CS
16672011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1668
1669 * process.c (Fformat_network_address): Doc fix.
1670
87302331
R
16712011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1672
1673 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1674
cbb59342
CY
16752011-04-08 Chong Yidong <cyd@stupidchicken.com>
1676
1677 * keyboard.c (read_char): Call Lisp function help-form-show,
1678 instead of using internal_with_output_to_temp_buffer.
1679 (Qhelp_form_show): New var.
e0d38eeb 1680 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1681
1682 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1683
1684 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1685
e67a13ab
CY
16862011-04-06 Chong Yidong <cyd@stupidchicken.com>
1687
1688 * process.c (Flist_processes): Removed to Lisp.
1689 (list_processes_1): Deleted.
1690
973f782d
EZ
16912011-04-06 Eli Zaretskii <eliz@gnu.org>
1692
7c106b1e
EZ
1693 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1694
973f782d
EZ
1695 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1696
41cf7d1a 16972011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1698
ca23cc88
PE
1699 Fix more problems found by GCC 4.6.0's static checks.
1700
f390e2d5
PE
1701 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1702
42eea0d0
PE
1703 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1704
b69769da 1705 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1706
f9541e84
PE
1707 * xdisp.c (vmessage): Mark as a printf-like function.
1708
13841b55
PE
1709 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1710
c136c10f
PE
1711 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1712
5e2d4a30
PE
1713 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1714 printf-like functions.
1715 (tiff_load): Add casts to remove these marks before passing them
1716 to system-supplied API.
1717
583f48b9
PE
1718 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1719
b25d760e
PE
1720 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1721 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1722 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1723 directly, rather than having caller test rule sign. This avoids
1724 some unnecessary tests.
1725 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1726 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1727 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1728
bc7b6697 1729 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1730 (xfont_open): Avoid unnecessary tests.
bc7b6697 1731
27ccc379
PE
1732 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1733
dcd5c89a
PE
1734 * composite.h, composite.c (composition_gstring_put_cache):
1735 Use EMACS_INT, not int, for length.
1736
b13a45c6
PE
1737 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1738 breaking out part of COMPOSITION_DECODE_RULE.
1739 (COMPOSITION_DECODE_RULE): Use it.
1740 * composite.c (get_composition_id): Remove unused local vars,
1741 by using the new macro.
1742
1e792e4d
PE
1743 * textprop.c (set_text_properties_1): Change while to do-while,
1744 since the condition is always true at first.
1745
dc6c6455 1746 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1747 (interval_deletion_adjustment): Return unsigned value.
1748 All uses changed.
dc6c6455 1749
aba7731a
PE
1750 * process.c (list_processes_1, create_pty, read_process_output):
1751 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1752 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1753 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1754 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1755 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1756
fdfc4bf3
PE
1757 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1758
fca8fe46 1759 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1760 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1761
06a0259a 1762 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1763 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1764 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1765
e7b9e80f
PE
1766 * print.c (print_error_message): Avoid int overflow.
1767
56201685
PE
1768 * font.c (font_list_entities): Redo for clarity,
1769 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1770
78834453 1771 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1772 (font_score): Avoid potential overflow in diff calculation.
78834453 1773
0bc0b309 1774 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1775 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1776
e610eaca
PE
1777 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1778
b895abce
PE
1779 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1780 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1781 can always succeed if overflow has undefined behavior.
1782
1f1d9321 1783 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1784 (wordify): Omit three unnecessary tests.
1f1d9321 1785
c59478bc
PE
1786 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1787 All callers changed. This avoids the need for an unused var.
1788
79b73827
PE
1789 * casefiddle.c (casify_region): Remove var that is set but not used.
1790
a4db5dfe
PE
1791 * dired.c (file_name_completion): Remove var that is set but not used.
1792
43aae36e
PE
1793 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1794
2a47c44d 1795 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1796 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1797
a37c69bf
PE
1798 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1799 Check for integer overflow on size calculations.
1800
328ab8e7
PE
1801 * buffer.c (Fprevious_overlay_change): Remove var that is set
1802 but not used.
1803
e5a2a5cb
PE
1804 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1805 Remove vars that are set but not used.
8d84a6eb 1806 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1807 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1808
a60e5f68
PE
1809 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1810
f661cb61 1811 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1812 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1813
f0397f5a
PE
1814 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1815 that are set but not used.
1816
8664db06 1817 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1818 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1819
6abdaa4a
PE
1820 * xselect.c (x_get_local_selection, x_handle_property_notify):
1821 Remove vars that are set but not used.
1822
0ce7538d 1823 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1824 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1825
9ae848fc
PE
1826 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1827 Remove var that is set but not used.
0b918413
PE
1828 (scroll_bar_windows_size): Now size_t, not int.
1829 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1830 Check for overflow.
9ae848fc 1831
a5a62657
PE
1832 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1833 (map_tty_color) [!defined MSDOS]: Likewise.
1834
5c5cdd39
PE
1835 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1836
66ebf983
PE
1837 * coding.c: Remove vars that are set but not used.
1838 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1839 All callers changed.
1840 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1841 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1842 (decode_coding_charset): Remove vars that are set but not used.
1843
1be4d761
PE
1844 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1845 that is set but not used.
1846
47553fa8
PE
1847 * print.c (print_object): Remove var that is set but not used.
1848
1f7196bf 1849 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1850 The gnulib version avoids calling malloc in the usual case,
1851 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1852 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1853 * filelock.c (current_lock_owner): Likewise.
1854 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1855 * sysdep.c: Include allocator.h, careadlinkat.h.
1856 (emacs_no_realloc_allocator): New static constant.
1857 (emacs_readlink): New function.
fdb61804
PE
1858 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1859 ../lib/careadlinkat.h.
d1fdcab7 1860
f84c17c7
SM
18612011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1862
1863 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1864 first non-nil return value).
1865
ef3862ad
JD
18662011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1867
1868 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1869 if not defined (Bug#8403).
1870
376a7006
JB
18712011-04-02 Juanma Barranquero <lekktu@gmail.com>
1872
1873 * xdisp.c (display_count_lines): Remove parameter `start',
1874 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1875 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1876 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1877 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1878 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1879 and thereabouts. All callers changed.
1880 (get_per_char_metric): Remove parameter `f', unused since
1881 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1882
6ca3801d
JM
18832011-04-02 Jim Meyering <meyering@redhat.com>
1884
1885 do not dereference NULL upon failed strdup
1886 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1887 (ns_get_family): Likewise.
1888
d8e2b5ba
JB
18892011-04-02 Juanma Barranquero <lekktu@gmail.com>
1890
1891 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1892
8c74fcbd
JD
18932011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1894
1895 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1896 later (Bug#8403).
1897
7200d79c
SM
18982011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1899
03408648 1900 Add lexical binding.
7200d79c 1901
03408648
SM
1902 * window.c (Ftemp_output_buffer_show): New fun.
1903 (Fsave_window_excursion):
1904 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1905
1906 * lread.c (lisp_file_lexically_bound_p): New function.
1907 (Fload): Bind Qlexical_binding.
1908 (readevalloop): Remove `evalfun' arg.
1909 Bind Qinternal_interpreter_environment.
1910 (Feval_buffer): Bind Qlexical_binding.
1911 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1912 Mark as dynamic.
1913 (syms_of_lread): Declare `lexical-binding'.
1914
1915 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1916
1917 * keyboard.c (eval_dyn): New fun.
1918 (menu_item_eval_property): Use it.
ca105506
SM
1919
1920 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1921
03408648
SM
1922 * fns.c (concat, mapcar1): Accept byte-code-functions.
1923
1924 * eval.c (Fsetq): Handle lexical vars.
1925 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1926 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1927 (FletX, Flet): Obey lexical binding.
1928 (Fcommandp): Handle closures.
1929 (Feval): New `lexical' arg.
1930 (eval_sub): New function extracted from Feval. Use it almost
1931 everywhere where Feval was used. Look up vars in lexical env.
1932 Handle closures.
1933 (Ffunctionp): Move from subr.el.
1934 (Ffuncall): Handle closures.
1935 (apply_lambda): Remove `eval_flags'.
1936 (funcall_lambda): Handle closures and new byte-code-functions.
1937 (Fspecial_variable_p): New function.
1938 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1939 but without exporting it to Lisp.
23aba0ea 1940
23aba0ea 1941 * doc.c (Fdocumentation, store_function_docstring):
03408648 1942 * data.c (Finteractive_form): Handle closures.
23aba0ea 1943
03408648
SM
1944 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1945 interactive spec.
ba83908c 1946
03408648
SM
1947 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1948 byte-codes.
1949 (exec_byte_code): New function extracted from Fbyte_code to handle new
1950 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1951
03408648 1952 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1953
03408648 1954 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1955
e2abce01
JB
19562011-03-31 Juanma Barranquero <lekktu@gmail.com>
1957
1958 * xdisp.c (redisplay_internal): Fix prototype.
1959
63696a73 19602011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1961
63696a73
EZ
1962 * xdisp.c (SCROLL_LIMIT): New macro.
1963 (try_scrolling): Use it when setting scroll_limit. Limit
1964 scrolling to 100 screen lines.
1965 (redisplay_window): Even when falling back on "recentering",
1966 position point in the window according to scroll-conservatively,
1967 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1968
1969 (try_scrolling): When point is above the window, allow searching
1970 as far as scroll_max, or one screenful, to compute vertical
1971 distance from PT to the scroll margin position. This prevents
1972 try_scrolling from unnecessarily failing when
1973 scroll-conservatively is set to a value slightly larger than the
1974 window height. Clean up the case of PT below the margin at bottom
1975 of window: scroll_max can no longer be INT_MAX. When aggressive
1976 scrolling is in use, don't let point enter the opposite scroll
1977 margin as result of the scroll.
1978 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1979 threshold of 100 lines for never-recentering scrolling.
1980
e4cc2dfc
JB
19812011-03-31 Juanma Barranquero <lekktu@gmail.com>
1982
1983 * dispextern.h (move_it_by_lines):
1984 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1985 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1986 (message_log_check_duplicate): Remove parameters `prev_bol' and
1987 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1988 (redisplay_internal): Remove parameter `preserve_echo_area',
1989 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1990
1991 * indent.c (Fvertical_motion):
1992 * window.c (window_scroll_pixel_based, Frecenter):
1993 Don't pass `need_y_p' to `move_it_by_lines'.
1994
1c470562
SM
19952011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1996
44f230aa
SM
1997 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1998 steal a few bits to be more compact.
1999 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2000 Remove unneeded casts.
2001
1c470562
SM
2002 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2003
888adce9
ZK
20042011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2005
2006 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2007 binding" message (bug#7967).
2008
f838ed7b
PE
20092011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2010
77861b95
PE
2011 Fix more problems found by GCC 4.6.0's static checks.
2012
de6dbc14
PE
2013 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2014 Remove unused local var.
2015
f838ed7b
PE
2016 * editfns.c (Fmessage_box): Remove unused local var.
2017
792c7b2b
PE
2018 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2019 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2020 Omit unused local vars.
c499e557 2021 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2022 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2023 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2024 Omit unused local var.
2025
ba0165e1
PE
2026 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2027 Don't assume string length fits in int.
32ad8845 2028 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2029 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2030
3c59b4c9
PE
2031 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2032 instead of alloca (Bug#8344).
2033
a3eed478 2034 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2035 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2036
eb4d412d
PE
2037 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2038
1658b401
PE
2039 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2040 concerns.
2041
2042 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2043
2044 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2045
9a2c6e05
PE
2046 * keyboard.c (syms_of_keyboard): Use the same style as later
2047 in this function when indexing through an array. This also
2048 works around GCC bug 48267.
2049
03d0a109
PE
2050 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2051
44f730c8
PE
2052 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2053
fe75f926
PE
2054 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2055 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2056
ffa8c828
PE
2057 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2058 This avoids undefined behavior on integer overflow, and is a bit
2059 more convenient anyway since it is compared to a size_t variable.
2060
c5101a77
PE
2061 Variadic C functions now count arguments with size_t, not int.
2062 This avoids an unnecessary limitation on 64-bit machines, which
2063 caused (substring ...) to crash on large vectors (Bug#8344).
2064 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2065 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2066 All variadic functions and their callers changed accordingly.
c5101a77
PE
2067 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2068 * data.c (arith_driver, float_arith_driver): Likewise.
2069 * editfns.c (general_insert_function): Likewise.
2070 * eval.c (struct backtrace.nargs, interactive_p)
2071 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2072 (funcall_lambda, mark_backtrace): Likewise.
2073 * fns.c (concat): Likewise.
2074 * frame.c (x_set_frame_parameters): Likewise.
2075 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2076 0 if not found, not -1. All callers changed.
2077
dd3f25f7
PE
2078 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2079 (stack_copy_size): Now size_t, not int.
2080 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2081
461c2ab9
JB
20822011-03-28 Juanma Barranquero <lekktu@gmail.com>
2083
2084 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2085 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2086 All callers changed.
2087
2088 * lisp.h (multibyte_char_to_unibyte):
2089 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2090 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2091 * character.h (CHAR_TO_BYTE8):
2092 * cmds.c (internal_self_insert):
2093 * editfns.c (general_insert_function):
2094 * keymap.c (push_key_description):
2095 * search.c (Freplace_match):
2096 * xdisp.c (message_dolog, set_message_1): All callers changed.
2097
f6d62986
SM
20982011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2099
2100 * keyboard.c (safe_run_hook_funcall): New function.
2101 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2102 don't set the hook to nil, but remove the offending function instead.
2103 (Qcommand_hook_internal): Remove, unused.
2104 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2105 Vcommand_hook_internal.
2106
2107 * eval.c (enum run_hooks_condition): Remove.
2108 (funcall_nil, funcall_not): New functions.
2109 (run_hook_with_args): Call each function through a `funcall' argument.
2110 Remove `cond' argument, now redundant.
2111 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2112 (Frun_hook_with_args_until_failure): Adjust accordingly.
2113 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2114
1db5b1ad
JB
21152011-03-28 Juanma Barranquero <lekktu@gmail.com>
2116
2117 * dispextern.h (string_buffer_position): Remove declaration.
2118
2119 * print.c (strout): Remove parameter `multibyte', unused since
2120 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2121
2122 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2123 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2124 All callers changed.
2125
2126 * w32.c (_wsa_errlist): Use braces for struct initializers.
2127
2128 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2129 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2130 All callers changed.
2131 (string_buffer_position): Likewise. Also, make static (it's never
2132 used outside xdisp.c).
2133 (cursor_row_p): Remove parameter `w', unused since
2134 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2135 (decode_mode_spec): Remove parameter `precision', introduced during
2136 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2137 All callers changed.
2138
5ffb62aa
JD
21392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2140
2141 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2142
461c2ab9 21432011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2144
2145 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2146 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2147 (ns_update_auto_hide_menu_bar): New functions.
2148 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2149 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2150 ns_constrain_all_frames.
2151 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2152 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2153
5c380ffb
JD
21542011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2155
2156 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2157
9af30bdf
GM
21582011-03-27 Glenn Morris <rgm@gnu.org>
2159
2160 * syssignal.h: Replace RETSIGTYPE with void.
2161 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2162 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2163 Replace SIGTYPE with void everywhere.
2164 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2165 * s/template.h (SIGTYPE): Remove commented out definition.
2166
e2abce01
JB
21672011-03-26 Eli Zaretskii <eliz@gnu.org>
2168
2169 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2170 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2171
f868cd8a
JB
21722011-03-26 Juanma Barranquero <lekktu@gmail.com>
2173
59eb0929
JB
2174 * w32.c (read_unc_volume): Use parameter `henum', instead of
2175 global variable `wget_enum_handle'.
2176
2177 * keymap.c (describe_vector): Remove parameters `indices' and
2178 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2179 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2180
f868cd8a
JB
2181 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2182
2183 * keyboard.c (timer_check): Remove parameter `do_it_now',
2184 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2185 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2186 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2187
2188 * keyboard.c (read_char):
2189 * w32menu.c (w32_menu_display_help):
2190 * xmenu.c (show_help_event, menu_help_callback):
2191 Adjust calls to `show_help_echo'.
2192
2193 * gtkutil.c (xg_maybe_add_timer):
2194 * keyboard.c (readable_events):
2195 * process.c (wait_reading_process_output):
2196 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2197
2198 * insdel.c (adjust_markers_gap_motion):
2199 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2200 (gap_left, gap_right): Don't call it.
2201
2ecf6fdb
CY
22022011-03-25 Chong Yidong <cyd@stupidchicken.com>
2203
2204 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2205 incurred during fontification.
2206
6b1f9ba4
JB
22072011-03-25 Juanma Barranquero <lekktu@gmail.com>
2208
2209 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2210 (DEFVAR_PER_BUFFER): Don't pass it.
2211
2212 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2213 (scrolling_window): Don't pass it.
2214
0f4a96b5
JB
22152011-03-25 Juanma Barranquero <lekktu@gmail.com>
2216
2217 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2218
2219 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2220 and `suffix'.
2221 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2222 of variables specific to SELinux and computation of `encoded_absname'.
2223
2224 * image.c (XPutPixel): Remove unused variable `height'.
2225
2226 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2227
2228 * unexw32.c (get_section_info): Remove unused variable `section'.
2229
2230 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2231 (system_process_attributes): Remove unused variable `sess'.
2232 (sys_read): Remove unused variable `err'.
2233
2234 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2235 (w32_wnd_proc): Remove unused variable `isdead'.
2236 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2237 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2238 (x_create_tip_frame): Remove unused variable `tem'.
2239
2240 * w32inevt.c (w32_console_read_socket):
2241 Remove unused variable `no_events'.
2242
2243 * w32term.c (x_draw_composite_glyph_string_foreground):
2244 Remove unused variable `width'.
2245
1149507c
JB
22462011-03-24 Juanma Barranquero <lekktu@gmail.com>
2247
2248 * w32term.c (x_set_glyph_string_clipping):
2249 Don't pass uninitialized region to CombineRgn.
2250
9c88f339
JB
22512011-03-23 Juanma Barranquero <lekktu@gmail.com>
2252
2253 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2254 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2255 (Fx_close_connection): Remove unused variable `i'.
2256
2257 * w32font.c (w32font_draw): Return number of glyphs.
2258 (w32font_open_internal): Remove unused variable `i'.
2259 (w32font_driver): Add missing initializer.
2260
2261 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2262 (fill_in_menu): Remove unused variable `items_added'.
2263
2264 * w32term.c (last_mouse_press_frame): Remove static global variable.
2265 (w32_clip_to_row): Remove unused variable `f'.
2266 (x_delete_terminal): Remove unused variable `i'.
2267
2268 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2269 (NOTHING): Remove unused static global variable.
2270 (uniscribe_check_otf): Remove unused variable `table'.
2271 (uniscribe_font_driver): Add missing initializers.
2272
dee091a3
JD
22732011-03-23 Julien Danjou <julien@danjou.info>
2274
2275 * term.c (Fsuspend_tty, Fresume_tty):
2276 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2277 * window.c (temp_output_buffer_show):
2278 * insdel.c (signal_before_change):
2279 * frame.c (Fhandle_switch_frame):
2280 * fileio.c (Fdo_auto_save):
2281 * emacs.c (Fkill_emacs):
2282 * editfns.c (save_excursion_restore):
2283 * cmds.c (internal_self_insert):
2284 * callint.c (Fcall_interactively):
2285 * buffer.c (Fkill_all_local_variables):
2286 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2287 Use Frun_hooks.
0f4a96b5 2288 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2289 unconditionnaly since it does the check itself.
2290
2c520ab5 22912011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2292
c9c49752
PE
2293 Fix more problems found by GCC 4.5.2's static checks.
2294
8abc3f12
PE
2295 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2296 the first time through the loop, since we know p0 < p1 then.
2297 This also avoids a gcc -Wstrict-overflow warning.
2298
a2d26660
PE
2299 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2300 leading to a memory leak, possible in functions like
2301 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2302 of objects (Bug#8318).
a2d26660 2303
916c72e9
PE
2304 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2305 that could (at least in theory) be that large.
2306
19ab8a18
PE
2307 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2308 This is less likely to overflow, and avoids undefined behavior if
2309 overflow does occur. All callers changed. Use strtoul to scan
2310 for the unsigned long integer.
b7cbbd6f
PE
2311 (pint2hrstr): Simplify and tune code slightly.
2312 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2313
f0641eff
PE
2314 * scroll.c (do_scrolling): Work around GCC bug 48228.
2315 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2316
7f650bb9
PE
2317 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2318 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2319 (validate_x_resource_name): Simplify count usage.
2320 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2321
37dd57d1
PE
2322 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2323 fail (Bug#8306).
81e56e61 2324
699979fc 2325 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2326
401bf9b4
PE
2327 * process.c (Fmake_network_process): Use socklen_t, not int,
2328 where POSIX says socklen_t is required in portable programs.
2329 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2330 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2331 (Fmake_network_process, server_accept_connection):
2332 (wait_reading_process_output, read_process_output):
2333 Likewise.
2334
b93aacde
PE
2335 * process.c: Rename or move locals to avoid shadowing.
2336 (list_processes_1, Fmake_network_process):
2337 (read_process_output_error_handler, exec_sentinel_error_handler):
2338 Rename or move locals.
4dc343ee 2339 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2340 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2341 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2342 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2343 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2344
af8a867c 2345 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2346 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2347 Include tparam.h instead, since it declares them.
af8a867c
PE
2348 * cm.h (PC): Remove extern decl; tparam.h now does this.
2349 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2350 * terminfo.c: Include tparam.h, to check interfaces.
2351 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2352 (tparam): Adjust signature to match interface in tparam.h;
2353 this removes some undefined behavior. Check that outstring and len
2354 are zero, which they always are with Emacs.
2355 * tparam.h (PC, BC, UP): New extern decls.
2356
0248044d 2357 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2358 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2359
8ff096c1 2360 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2361 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2362 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2363 (ftfont_list): Remove unused local.
49eaafba
PE
2364 (get_adstyle_property, ftfont_pattern_entity):
2365 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2366 Rename locals to avoid shadowing.
8ff096c1 2367
e2be39f6
PE
2368 * xfont.c (xfont_list_family): Mark var as initialized.
2369
c9735e30
PE
2370 * xml.c (make_dom): Now static.
2371
8f5201ae
PE
2372 * composite.c (composition_compute_stop_pos): Rename local to
2373 avoid shadowing.
b246f932
PE
2374 (composition_reseat_it): Remove unused locals.
2375 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2376 (composition_update_it): Mark var as initialized.
11b61122
PE
2377 (find_automatic_composition): Mark vars as initialized,
2378 with a FIXME (Bug#8290).
8f5201ae 2379
760fbc2c
PE
2380 character.h: Rename locals to avoid shadowing.
2381 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2382 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2383 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2384 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2385 to avoid shadowing.
2386
ff08eb85
PE
2387 * textprop.c (property_change_between_p): Remove; unused.
2388
fc7bf025
PE
2389 * intervals.c (interval_start_pos): Now static.
2390
235d7abc
PE
2391 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2392
44f230aa
SM
2393 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2394 Rename locals to avoid shadowing.
3e7d6594 2395
50060332
PE
2396 * sound.c (wav_play, au_play, Fplay_sound_internal):
2397 Fix pointer signedness.
d01f234b 2398 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2399 (wav_play): Initialize a variable to 0, to prevent undefined
2400 behavior (Bug#8278).
50060332 2401
c4fc4e30
PE
2402 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2403
918436ed
PE
2404 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2405
c939f91b
PE
2406 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2407 clobbering (Bug#8298).
b9c7f648
PE
2408 * sysdep.c (sys_subshell): Likewise.
2409 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2410
6bd8c144
PE
2411 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2412 This should get cleaned up, so that child_setup has the
2413 same signature on all platforms.
2414
7710357c 2415 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2416 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2417
c59da222
CY
24182011-03-22 Chong Yidong <cyd@stupidchicken.com>
2419
2420 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2421 not to be necessary, and produces flickering.
2422
66b87493
GM
24232011-03-20 Glenn Morris <rgm@gnu.org>
2424
2425 * config.in: Remove file.
2426
45b6f6d5
JB
24272011-03-20 Juanma Barranquero <lekktu@gmail.com>
2428
2429 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2430 are now in src/globals.h.
2431 (syms_of_minibuf): Remove spurious & from previous change.
2432
3ec03f7e
LL
24332011-03-20 Leo <sdl.web@gmail.com>
2434
2435 * minibuf.c (completing-read-function): New variable.
2436 (completing-read-default): Rename from completing-read.
2437 (completing-read): Call completing-read-function.
2438
b14e3e21
CY
24392011-03-19 Juanma Barranquero <lekktu@gmail.com>
2440
2441 * xfaces.c (Fx_load_color_file):
2442 Read color file from absolute filename (bug#8250).
2443
f2b726e6
JB
24442011-03-19 Juanma Barranquero <lekktu@gmail.com>
2445
2446 * makefile.w32-in: Update dependencies.
2447
09f6ff02
EZ
24482011-03-17 Eli Zaretskii <eliz@gnu.org>
2449
2450 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2451
29a6015a
PE
24522011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2453
a3a6c54e
PE
2454 Fix more problems found by GCC 4.5.2's static checks.
2455
b766f867
PE
2456 * process.c (make_serial_process_unwind, send_process_trap):
2457 (sigchld_handler): Now static.
2458
be02381c
PE
2459 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2460 That way, the code declares only the vars that it needs.
2461 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2462 * s/cygwin.h (PTY_ITERATION): Likewise.
2463 * s/darwin.h (PTY_ITERATION): Likewise.
2464 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2465
57048744
PE
2466 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2467 * process.c (allocate_pty): Don't declare stb unless it's needed.
2468
7914961c 2469 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2470 (CONSTANTLIM): Remove; unused.
2471 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2472 Define only if needed.
7914961c 2473
b3967b18
PE
2474 * unexelf.c (unexec): Name an expression,
2475 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2476 Use a different way to cause a compilation error if anyone uses
2477 n rather than nn, a way that does not involve shadowing.
73366a00 2478 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2479
29a6015a
PE
2480 * deps.mk (unexalpha.o): Remove; unused.
2481
43cfc33e 2482 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2483 * unexec.h: New file.
ce701a33
PE
2484 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2485 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2486 Depend on unexec.h.
2487 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2488 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2489 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2490 Change as necessary to match prototype in unexec.h.
ce701a33 2491
01f44d5a
PE
2492 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2493 shadowing.
4f63c6bb 2494 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2495
a6670b0b
PE
2496 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2497 Rename locals to avoid shadowing.
2498
cef2010d 2499 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2500 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2501
d4d7173a
PE
2502 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2503
f08b802a
PE
2504 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2505 warning when compiling print.c.
2506
3ddb0639
PE
2507 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2508 instead of using an uninitialized var.
5ad03b97 2509 (font_sort_entities): Mark var as initialized.
3ddb0639 2510
170a2692
PE
2511 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2512
e663c700
PE
2513 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2514 pointers to constants.
89bc529a 2515 (font_parse_fcname): Remove unused vars.
7b81e2d0 2516 (font_delete_unmatched): Now static.
ea838e10 2517 (font_get_spec): Remove; unused.
13a547c6
PE
2518 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2519 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2520 Rename or move locals to avoid shadowing.
e663c700 2521
2a80c887 2522 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2523 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2524
1384fa33 2525 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2526 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2527
8b2c52e9
PE
2528 * alloc.c (mark_backtrace): Move decl from here ...
2529 * lisp.h: ... to here, so that it can be checked.
2530
475545b5 2531 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2532 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2533 (lisp_indirect_variable): Name an expression,
2534 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2535 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2536
b1349114 2537 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2538 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2539 Use const pointer when appropriate.
b1349114 2540
a2928364
PE
2541 * lisp.h (get_system_name, get_operating_system_release):
2542 Move decls here, to check interfaces.
2543 * process.c (get_operating_system_release): Move decl to lisp.h.
2544 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2545 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2546 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2547 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2548 (Fformat_time_string, Fencode_time, Finsert_char):
2549 (Ftranslate_region_internal, Fformat):
2550 Rename or remove local vars to avoid shadowing.
9710023e 2551 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2552
a415e694
PE
2553 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2554 avoid shadowing.
2555
8ef4622d
PE
2556 * lisp.h (eassert): Check that the argument compiles, even if
2557 ENABLE_CHECKING is not defined.
2558
946f9a5b
PE
2559 * data.c (Findirect_variable): Name an expression, to avoid
2560 gcc -Wbad-function-cast warning.
112396d6 2561 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2562 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2563 (Fmake_variable_buffer_local, Fmake_local_variable):
2564 Mark variables as initialized.
52746918 2565 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2566
e5aab7e7 2567 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2568 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2569 Rename locals to avoid shadowing.
dff45157
PE
2570 (mark_stack): Move local variables into the #ifdef region where
2571 they're used.
7bc26fdb
PE
2572 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2573 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2574 needed otherwise.
2575 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2576 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2577 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2578
e5aab7e7
PE
2579 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2580 avoids undefined behavior in theory.
2581
4da60324
PE
2582 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2583
88043301
PE
2584 Use functions, not macros, for up- and down-casing (Bug#8254).
2585 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2586 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2587 to use the following functions instead of these macros.
2588 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2589 EMACS_INT, since callers assume the returned value fits in int.
2590 (upcase1): Likewise, for UPCASE_TABLE.
2591 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2592 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2593 the race-condition problem in the old DOWNCASE.
88043301 2594
19ed5445
PE
2595 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2596 Rename locals to avoid shadowing.
2597 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2598 (regex_compile, re_search_2, re_match_2_internal):
2599 Remove unused local vars.
952db0d7
PE
2600 (FREE_VAR): Rewrite so as not to use empty "else",
2601 which gcc can warn about.
da053e48 2602 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2603 (RETALLOC_IF): Define only if needed.
2604 (WORDCHAR_P): Likewise. This one is never needed, but is used
2605 only in a comment talking about a compiler bug, so put inside
2606 the #if 0 of that comment.
2607 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2608 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2609 Remove; unused.
19ed5445 2610
1f3561e4 2611 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2612 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2613 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2614
ded6f8f7
PE
2615 * search.c (simple_search): Remove unused var.
2616
dbd37a95
PE
2617 * dired.c (compile_pattern): Move decl from here ...
2618 * lisp.h: ... to here, so that it can be checked.
2619 (struct re_registers): New forward decl.
2620
7e47afad
PE
2621 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2622
85f24f61
PE
2623 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2624 All uses changed.
2625 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2626 Rename locals to avoid shadowing.
5671df8f 2627 (Fvertical_motion): Mark locals as initialized.
85f24f61 2628
181aa2be 2629 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2630 (casify_region): Mark local as initialized.
181aa2be 2631
930d429c
PE
2632 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2633
7082eac6
PE
2634 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2635 New macros, so that the caller can use some names other than
2636 gcpro1, gcpro2, etc.
2637 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2638 of the new macros.
2639 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2640 argument, for consistency with GCPRO2_VAR, etc: it is now the
2641 prefix of the variable, not the variable itself. All uses
2642 changed.
38b2c076
PE
2643 * dired.c (directory_files_internal, file_name_completion):
2644 Rename locals to avoid shadowing.
2645
15206ed9
PE
2646 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2647 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2648 dired.c's scmp function, had undefined behavior.
2649 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2650 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2651 * buffer.h: ... to here, because these macros use current_buffer,
2652 and the new implementation with inline functions needs to have
2653 current_buffer in scope now, rather than later when the macros
2654 are used.
2655 (downcase, upcase1): New static inline functions.
2656 (DOWNCASE, UPCASE1): Reimplement using these functions.
2657 This avoids undefined behavior in expressions like
2658 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2659 from race conditions in accessing the global variables
2660 case_temp1 and case_temp2.
2661 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2662 * lisp.h (case_temp1, case_temp2): Remove their decls.
2663 * character.h (ASCII_CHAR_P): Move from here ...
2664 * lisp.h: ... to here, so that the inline functions mentioned
2665 above can use them.
2666
4a6bea26
PE
2667 * dired.c (directory_files_internal_unwind): Now static.
2668
f14b7e14
PE
2669 * fileio.c (file_name_as_directory, directory_file_name):
2670 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2671 Now static.
2893f146
PE
2672 (file_name_as_directory): Use const pointers when appropriate.
2673 (Fexpand_file_name): Likewise. In particular, newdir might
2674 point at constant storage, so make it a const pointer.
fd4ead52 2675 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2676 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2677 signedness issues.
f839df0c
PE
2678 (Fset_file_times, Finsert_file_contents, auto_save_error):
2679 Rename locals to avoid shadowing.
f14b7e14 2680
5716756e 2681 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2682 (Ftry_completion, Fall_completions): Rename or remove locals
2683 to avoid shadowing.
5716756e 2684
b4c3046a
PE
2685 * marker.c (bytepos_to_charpos): Remove; unused.
2686
b45db522
PE
2687 * lisp.h (verify_bytepos, count_markers): New decls,
2688 so that gcc does not warn that these functions aren't declared.
2689
85876d07
PE
2690 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2691 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2692 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2693 (copy_text): Remove unused local var.
85876d07 2694
03d78a21 2695 * filelock.c (within_one_second): Now static.
b3dd38ab 2696 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2697
5df8f01b
PE
2698 * buffer.c (fix_overlays_before): Mark locals as initialized.
2699 (fix_start_end_in_overlays): Likewise. This function should be
2700 simplified by using pointers-to-pointers, but that's a different
2701 matter.
b1d876f1 2702 (switch_to_buffer_1): Now static.
8f54f30a
PE
2703 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2704 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2705
a70072c9 2706 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2707 Fix pointer signedness issue.
edced198
PE
2708 (sys_subshell): Mark local as volatile if checking for lint,
2709 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2710 (MAXPATHLEN): Define only if needed.
a70072c9 2711
a0977c44
PE
2712 * process.c (serial_open, serial_configure): Move decls from here ...
2713 * systty.h: ... to here, so that they can be checked.
2714
a884fdcc
PE
2715 * fns.c (get_random, seed_random): Move extern decls from here ...
2716 * lisp.h: ... to here, so that they can be checked.
2717
604efe86 2718 * sysdep.c (reset_io): Now static.
b8950c94 2719 (wait_for_termination_signal): Remove; unused.
604efe86 2720
38fc62d9
PE
2721 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2722 (copy_keymap_item, append_key, push_text_char_description):
2723 Now static.
1004a21a 2724 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2725 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2726 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2727 (describe_map_tree):
2728 Rename locals to avoid shadowing.
38fc62d9 2729
2f2650da
PE
2730 * keyboard.c: Declare functions static if they are not used elsewhere.
2731 (echo_char, echo_dash, cmd_error, top_level_2):
2732 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2733 (read_char, kbd_buffer_get_event, make_lispy_position):
2734 (make_lispy_event, make_lispy_movement, apply_modifiers):
2735 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2736 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2737 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2738 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2739 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2740
a053e86c 2741 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2742 (mark_kboards): Move decl here ...
2743 * alloc.c (mark_kboards): ... from here.
a053e86c 2744
4752793e
PE
2745 * lisp.h (force_auto_save_soon): New decl.
2746
74f10ca7 2747 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2748 (DEFINE_DUMMY_FUNCTION): New macro.
2749 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2750 Use it.
c03cd23f
PE
2751 (main): Add casts to avoid warnings
2752 if GCC considers string literals to be constants.
74f10ca7 2753
022e70d4
PE
2754 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2755
59d6fe83
PE
2756 * dbusbind.c: Pointer signedness fixes.
2757 (xd_signature, xd_append_arg, xd_initialize):
2758 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2759 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2760 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2761 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2762
78320123
PE
2763 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2764 if GCC considers string literals to be constants.
49cebcca 2765 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2766
35ac2a97
SM
27672011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2768
fb103ca9
SM
2769 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2770 (print_preprocess, print_object): New macro to fix last change.
2771
35ac2a97
SM
2772 * print.c (print_preprocess): Don't forget font objects.
2773
62973b41
JB
27742011-03-16 Juanma Barranquero <lekktu@gmail.com>
2775
2776 * emacs.c (USAGE3): Doc fixes.
2777
0e48bb22
AS
27782011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2779
2780 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2781 structure.
2782
7684e57b
JB
27832011-03-14 Juanma Barranquero <lekktu@gmail.com>
2784
2785 * lisp.h (VWindow_system, Qfile_name_history):
2786 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2787 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2788 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2789
2790 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2791 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2792
2793 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2794 * w32console.c (detect_input_pending, read_input_pending)
2795 (encode_terminal_code):
2796 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2797 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2798 (w32_system_caret_y, Qfile_name_history):
2799 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2800 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2801 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2802 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2803 * w32proc.c (Qlocal, report_file_error):
2804 * w32term.c (Vwindow_system, updating_frame):
2805 * w32uniscribe.c (initialized, uniscribe_font_driver):
2806 Remove unneeded extern declarations.
2807
2aa46d6c
CY
28082011-03-14 Chong Yidong <cyd@stupidchicken.com>
2809
c96bbc66 2810 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2811
cffc6f3b
CY
28122011-03-13 Chong Yidong <cyd@stupidchicken.com>
2813
2814 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2815 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2816 These macros can no longer be used for assignment.
2817
44f230aa
SM
2818 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2819 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2820 (record_buffer_markers, fetch_buffer_markers): New functions for
2821 recording and fetching special buffer markers.
2822 (set_buffer_internal_1, set_buffer_temp): Use them.
2823
2824 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2825
2826 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2827
2828 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2829 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2830
2831 * xdisp.c (hscroll_window_tree):
2832 (reconsider_clip_changes): Use PT instead of BUF_PT.
2833
d251f04b
EZ
28342011-03-13 Eli Zaretskii <eliz@gnu.org>
2835
2836 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2837 $(EMACS_ROOT)/lib/intprops.h.
2838
f0c77cd1
PE
28392011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2840
3eca4629
PE
2841 Fix more problems found by GCC 4.5.2's static checks.
2842
7c86ee98
PE
2843 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2844 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2845 (xg_free_frame_widgets): Make it clear that a local variable is
2846 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2847 (gdk_window_get_screen): Make it clear that this macro is needed
2848 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2849 (int_gtk_range_get_value): New function, which avoids a diagnostic
2850 from gcc -Wbad-function-cast.
2851 (xg_set_toolkit_scroll_bar_thumb): Use it.
2852 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2853 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2854 (get_utf8_string, xg_get_file_with_chooser):
2855 Rename locals to avoid shadowing.
2856 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2857
41729b81
PE
2858 * xgselect.c (xg_select): Remove unused var.
2859
f0c77cd1
PE
2860 * image.c (four_corners_best): Mark locals as initialized.
2861 (gif_load): Initialize transparent_p to zero (Bug#8238).
2862 Mark another local as initialized.
ec6cf4c6 2863 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2864
ce0ad53d 2865 * image.c (clear_image_cache): Now static.
d5d5a617 2866 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2867 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2868 (x_edge_detection): Remove unnecessary cast that
2869 gcc -Wbad-function-cast diagnoses.
2037898d 2870 (gif_load): Fix pointer signedness.
6ae141d6
PE
2871 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2872 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2873
33383987 28742011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2875
d32df629
PE
2876 Improve quality of tests for time stamp overflow.
2877 For example, without this patch (encode-time 0 0 0 1 1
2878 1152921504606846976) returns the obviously-bogus value (-948597
2879 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2880 reports time overflow. See
2881 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2882 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2883 * editfns.c: Include limits.h and intprops.h.
2884 (TIME_T_MIN, TIME_T_MAX): New macros.
2885 (time_overflow): Move earlier, to before first use.
2886 (hi_time, lo_time): New functions, for an accurate test for
2887 out-of-range times.
2888 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2889 (Fget_internal_run_time): Don't assume time_t fits in int.
2890 (make_time): Use list2 instead of Fcons twice.
2891 (Fdecode_time): More accurate test for out-of-range times.
2892 (check_tm_member): New function.
2893 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2894 (lisp_time_argument): Don't rely on undefined left-shift and
2895 right-shift behavior when checking for time stamp overflow.
8be6f318 2896
fe31d94c
PE
2897 * editfns.c (time_overflow): New function, refactoring common code.
2898 (Fformat_time_string, Fdecode_time, Fencode_time):
2899 (Fcurrent_time_string): Use it.
2900
8be6f318
PE
2901 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2902 * dired.c (make_time): Move to ...
2903 * editfns.c (make_time): ... here.
2904 * systime.h: Note the move.
2905
09d9db2c 29062011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2907
126bc0dc
YM
2908 * fringe.c (update_window_fringes): Remove unused variables.
2909
c47cbdfd
YM
2910 * unexmacosx.c (copy_data_segment): Also copy __got section.
2911 (Bug#8223)
2912
7ac80be9
EZ
29132011-03-12 Eli Zaretskii <eliz@gnu.org>
2914
c96bbc66 2915 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2916 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2917 Constify `char *' arguments and their references according to
2918 prototypes in tparam.h.
2919
ecb0f94d 2920 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2921
7ac80be9
EZ
2922 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2923 Adapt all references accordingly.
2924
2925 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2926
ef1fd07e
TT
29272011-03-11 Tom Tromey <tromey@redhat.com>
2928
2929 * buffer.c (syms_of_buffer): Remove obsolete comment.
2930
7ef4b50c
EZ
29312011-03-11 Eli Zaretskii <eliz@gnu.org>
2932
2933 * termhooks.h (encode_terminal_code): Declare prototype.
2934
2935 * msdos.c (encode_terminal_code): Don't declare prototype.
2936
2937 * term.c (encode_terminal_code): Now external again, used by
2938 w32console.c and msdos.c.
2939
44f230aa
SM
2940 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2941 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2942
4b1ec863 29432011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2944
1714f52b 2945 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2946
4b1ec863
PE
2947 * fringe.c (update_window_fringes): Mark locals as initialized
2948 (Bug#8227).
2949 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2950
524c7aa6
PE
2951 * alloc.c (mark_fringe_data): Move decl from here ...
2952 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2953 to check its interface.
2954 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2955
a5c0af81 2956 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2957 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2958 (fontset_font): Mark local as initialized.
a9a06e0b 2959 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2960
b4716021
PE
2961 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2962
811e9bac 2963 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2964 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2965 (x_own_selection, Fx_disown_selection_internal): Rename locals
2966 to avoid shadowing.
2967 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2968
7e3ab302
PE
2969 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2970 so that the caller can use some name other than gcpro1.
2971 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2972 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2973 (Fx_backspace_delete_keys_p):
2974 Use them to avoid shadowing, and rename vars to avoid shadowing.
2975 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2976 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2977 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2978 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2979 Remove unused locals.
7e3ab302
PE
2980 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2981 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2982 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2983 macros.
f78faa98 2984
e2b13473
PE
2985 * xterm.h (x_mouse_leave): New decl.
2986
77f23912
PE
2987 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2988 Remove unused functions.
cdf4ba58
PE
2989 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2990 (x_calc_absolute_position): Now static.
7411c686 2991 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2992 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2993 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2994 unless they are used.
38d0b34a
PE
2995 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2996 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2997 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2998 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2999 (x_error_catcher, x_connection_closed, x_error_handler):
3000 (x_error_quitter, xembed_send_message, x_iconify_frame):
3001 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3002 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3003 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3004
44f230aa
SM
3005 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3006 Rename or move locals to avoid shadowing.
6b463e58 3007 (tty_defined_color, merge_face_heights): Now static.
5967d051 3008 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3009 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3010 does not deduce is never used uninitialized.
73719eba
PE
3011 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3012 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3013
426994c3 3014 * terminal.c (store_terminal_param): Now static.
5489860b 3015
032f1620 3016 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3017 (set_frame_menubar): Remove unused local.
d4323972 3018 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3019 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3020 since they might point to immutable storage.
281585b0
PE
3021 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3022 since it's unused otherwise.
032f1620 3023
367c19e5 3024 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3025 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3026 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3027 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3028 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3029 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3030 does not deduce are never used uninitialized.
70739cbe 3031
07b48fa9
PE
3032 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3033
8868a238 3034 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3035 * window.c (window_loop, size_window):
3036 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3037
7e5cf297 3038 * window.c (display_buffer): Now static.
d6550a9f
PE
3039 (size_window): Mark variables that gcc -Wuninitialized
3040 does not deduce are never used uninitialized.
a586633d
PE
3041 * window.h (check_all_windows): New decl, to forestall
3042 gcc -Wmissing-prototypes diagnostic.
5b555da1 3043 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3044
f6095868
PE
3045 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3046 shadowing.
3047 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3048 Include <limits.h>.
3049 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3050 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3051 (load_charset_map): Mark variables that gcc -Wuninitialized
3052 does not deduce are never used uninitialized.
53df7c11 3053 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3054
f38b440c
PE
3055 * coding.c (coding_set_source, coding_set_destination):
3056 Use "else { /* comment */ }" rather than "else /* comment */;"
3057 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3058 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3059 a block, when the outer 'i' will do.
3060 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3061 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3062 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3063 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3064 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3065 Rename locals to avoid shadowing.
3066 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3067 * coding.c (emacs_mule_char, encode_invocation_designation):
3068 Now static, since they're not used elsewhere.
413bb2db 3069 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3070 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3071 (decode_coding_emacs_mule): Mark variables that gcc
3072 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3073 (detect_coding_iso_2022): Initialize a local variable that might
3074 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3075 this initialization is needed. (Bug#8211)
5f58e762
PE
3076 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3077 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3078 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3079 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3080 Remove unused macros.
f38b440c 3081
232b38b9 3082 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3083 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3084 * character.c (string_count_byte8): Likewise.
232b38b9 3085
fb90da1b
PE
3086 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3087 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3088
fb93dbc2
PE
3089 * chartab.c (copy_sub_char_table): Now static, since it's not used
3090 elsewhere.
5c156ace
PE
3091 (sub_char_table_ref_and_range, char_table_ref_and_range):
3092 Rename locals to avoid shadowing.
bbcd0949 3093 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3094
7d3b3862 3095 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3096 (BIDI_BOB): Remove unused macro.
7d3b3862 3097
6be7d3da
PE
3098 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3099 deduce are never used uninitialized.
c2ed9c8b 3100 * term.c (encode_terminal_code): Likewise.
6be7d3da 3101
75f8807f 3102 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3103
50938595
PE
3104 * tparam.h: New file.
3105 * term.c, tparam.h: Include it.
3106 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3107 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3108 Move these decls to tparam.h, and make them agree with what
3109 is actually in tparam.c. The previous trick of using incompatible
3110 decls in different modules does not conform to the C standard.
3111 All callers of tparam changed to use tparam's actual API.
3112 * tparam.c (tparam1, tparam, tgoto):
3113 Use const pointers where appropriate.
3114
fbceeba2
PE
3115 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3116 * cm.h (struct cm): Likewise.
3117 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3118 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3119 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3120 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3121 (turn_on_face, init_tty): Likewise.
3122 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3123
7f3f1250
PE
3124 * term.c (term_mouse_position): Rename local to avoid shadowing.
3125
e6ca6543
PE
3126 * alloc.c (mark_ttys): Move decl from here ...
3127 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3128
c40f8d15
AS
31292011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3130
3131 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3132
cfe0661d
JB
31332011-03-09 Juanma Barranquero <lekktu@gmail.com>
3134
3135 * search.c (compile_pattern_1): Remove argument regp, unused since
3136 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3137 (compile_pattern): Don't pass it.
3138
0afb4571
J
31392011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3140
3141 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3142 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3143 for ! HAVE_GTK3.
3144 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3145
3146 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3147
3148 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3149 gdk_window_get_screen, gdk_window_get_geometry,
3150 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3151 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3152 (xg_get_pixbuf_from_pixmap): New function.
3153 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3154 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3155 Call xg_get_pixbuf_from_pixmap instead of
3156 gdk_pixbuf_get_from_drawable.
3157 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3158 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3159 (xg_check_special_colors): Use GtkStyleContext and its functions
3160 for HAVE_GTK3.
3161 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3162 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3163 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3164 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3165 Call gtk_widget_get_preferred_size.
0afb4571
J
3166 (xg_frame_resized): gdk_window_get_geometry only takes 5
3167 parameters.
44f230aa
SM
3168 (xg_win_to_widget, xg_event_is_for_menubar):
3169 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3170 (xg_set_widget_bg): New function.
3171 (delete_cb): New function.
895009e1 3172 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3173 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3174 (xg_set_background_color): Call xg_set_widget_bg.
3175 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3176 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3177 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3178 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3179 if ! HAVE_GTK3.
3180 (update_frame_tool_bar): Call gtk_widget_hide.
3181 (xg_initialize): Use GDK_KEY_g.
3182
3183 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3184 if ! HAVE_GTK3
3185 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3186
3187 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3188 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3189 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3190
1c2cc4ef
JB
31912011-03-08 Juanma Barranquero <lekktu@gmail.com>
3192
3193 * w32xfns.c (select_palette): Check success of RealizePalette against
3194 GDI_ERROR, not zero.
3195
33383987 3196See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3197
3198;; Local Variables:
3199;; coding: utf-8
aac0c6e3
MR
3200;; End:
3201
33383987 3202 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3203
3204 This file is part of GNU Emacs.
3205
3206 GNU Emacs is free software: you can redistribute it and/or modify
3207 it under the terms of the GNU General Public License as published by
3208 the Free Software Foundation, either version 3 of the License, or
3209 (at your option) any later version.
3210
3211 GNU Emacs is distributed in the hope that it will be useful,
3212 but WITHOUT ANY WARRANTY; without even the implied warranty of
3213 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3214 GNU General Public License for more details.
3215
3216 You should have received a copy of the GNU General Public License
3217 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.