ChangeLog fix
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d1e68667 12012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
2
3 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4
6de0e799
GM
52012-07-13 Glenn Morris <rgm@gnu.org>
6
739ae010
GM
7 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
8
dbee5793
GM
9 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
10
6de0e799
GM
11 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
12 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
13
b82da769
GM
142012-07-12 Glenn Morris <rgm@gnu.org>
15
4fae5a7a 16 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
17
18 * process.c (init_process_emacs): Rename from init_process.
19 The old name is also the name of a Mach system call.
20 * lisp.h, emacs.c: Update for this name change.
21 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
22 longer needed.
23
5a979817
EZ
242012-07-12 Eli Zaretskii <eliz@gnu.org>
25
26 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
27 memmove call that removes glyphs covered by the left truncation
28 glyph. Improve commentary.
29 (display_line): Fix display of continuation glyphs on GUI frames
30 when the right fringe is turned off and variable-size fonts are
31 used in the window. Move the code that appends a stretch glyph to
32 produce_special_glyphs, so that it could be used for truncation
33 and continuation glyphs alike.
34 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
35 glyph of a suitably computed width, to align the special glyphs at
36 the window margin. Code moved from display_line. (Bug#11832)
37
3e91a053
GM
382012-07-12 Glenn Morris <rgm@gnu.org>
39
ba9e4b84
GM
40 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
41
42 * s/gnu-linux.h, s/hpux10-20.h:
43 Do not unconditionally define HAVE_XRMSETDATABASE.
44
3e91a053
GM
45 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
46
b300b1f4
PE
472012-07-12 Paul Eggert <eggert@cs.ucla.edu>
48
49 Fix typos that broke OS X build.
50 Reported by Randal L. Schwartz in
51 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
52 * nsterm.m (ns_timeout): Add missing local decl.
53 (ns_get_color): snprintf -> sprintf, to fix typo.
54
6e777848
GM
552012-07-12 Glenn Morris <rgm@gnu.org>
56
3f922c37
GM
57 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
58 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
59 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
60 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
61
0ab7b23a
GM
62 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
63 Move PTY_OPEN to configure.
64
6e777848
GM
65 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
66 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
67 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
68
4a7edc24
DA
692012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
70
71 Use empty_unibyte_string where applicable.
72 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
73 * lread.c (read1): Likewise.
74 * xsettings.c (syms_of_xsettings): Likewise.
75
308aab79
GM
762012-07-12 Glenn Morris <rgm@gnu.org>
77
42bd1719
GM
78 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
79 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
80 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
81 * s/hpux10-20.h (RUN_TIME_REMAP):
82 * s/bsd-common.h (TABDLY): Move to configure.
83
84 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
85
86 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
87
ea0bbd17 88 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 89 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
90
91 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 92
308aab79
GM
93 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
94 * s/template.h: Move NARROWPROTO to configure.
95
ee1cf5cf
GM
962012-07-11 Glenn Morris <rgm@gnu.org>
97
30fe9bf4
GM
98 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
99 unused since 2011-01-17 change to systty.h.
100
ee1cf5cf
GM
101 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
102 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
103 Move HAVE_PTYS and HAVE_SOCKETS to configure.
104
63e47e07
PE
1052012-07-11 Paul Eggert <eggert@cs.ucla.edu>
106
107 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
108
c43fb4c3
GM
1092012-07-11 Glenn Morris <rgm@gnu.org>
110
111 * s/darwin.h, s/gnu-linux.h, s/template.h:
112 Move INTERRUPT_INPUT to configure.
113
e8df9267
DA
1142012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
115
116 Minor adjustments to interning code.
117 * lisp.h (intern, intern_c_string): Redefine as static inline
118 wrappers for intern_1 and intern_c_string_1, respectively.
119 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
120 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
121 Vobarray checking.
e8df9267
DA
122 * font.c (font_intern_prop): Likewise. Adjust comment.
123 * w32font.c (intern_font_name): Likewise.
124
34348bd4
AS
1252012-07-11 Andreas Schwab <schwab@linux-m68k.org>
126
d96a1e0c
AS
127 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
128
34348bd4
AS
129 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
130 of Fcar/Fcdr if possible.
131 * font.c (check_otf_features): Likewise.
132 * fontset.c (Fnew_fontset): Likewise.
133 * gnutls.c (Fgnutls_boot): Likewise.
134 * minibuf.c (read_minibuf): Likewise.
135 * msdos.c (IT_set_frame_parameters): Likewise.
136 * xmenu.c (Fx_popup_dialog): Likewise.
137 * w32menu.c (Fx_popup_dialog): Likewise.
138
c8add24e
GM
1392012-07-11 Glenn Morris <rgm@gnu.org>
140
4b575b3c
GM
141 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
142 since nothing has defined it on these platforms.
143
09f4e3b0
GM
144 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
145 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
146
172bedef
GM
147 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
148 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
149 Move CLASH_DETECTION to configure.
150
249685df
GM
151 * s/gnu.h: Remove file, which is now empty.
152
c8add24e
GM
153 * s/gnu.h, s/gnu-linux.h:
154 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
155
b41253a3
JW
1562012-07-11 John Wiegley <johnw@newartisans.com>
157
158 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
159 function attribute, so we only use it if it exists in the
160 compiler.
161
d923b542
DA
1622012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
163
164 Avoid call to strlen in fast_c_string_match_ignore_case.
165 * search.c (fast_c_string_match_ignore_case): Change to use
166 length argument. Adjust users accordingly.
167 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
168
5ebbef1d
PE
1692012-07-11 Paul Eggert <eggert@cs.ucla.edu>
170
bb352260
PE
171 Assume mkdir, rmdir.
172 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
173 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
174
57054ddd
PE
175 Assume rename.
176 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
177
b747d3f7
PE
178 Assume perror.
179 * s/hpux10-20.h (HAVE_PERROR): Remove.
180 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
181 Remove dummy definition, as this problem was obsolete long ago.
182
5ebbef1d
PE
183 Assume strerror.
184 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
185
984e7f30
DA
1862012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
187
188 Avoid calls to strlen in font processing functions.
189 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 190 (font_open_by_name): Change to use length argument. Adjust
984e7f30 191 users accordingly.
d923b542
DA
192 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
193 Adjust prototypes.
194 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
195 Change to return ptrdiff_t.
984e7f30
DA
196 (xfont_list_pattern, xfont_match): Use length returned by
197 xfont_decode_coding_xlfd.
198 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
199
20e94fdd
GM
2002012-07-11 Glenn Morris <rgm@gnu.org>
201
9d596af3
GM
202 * s/darwin.h, s/freebsd.h, s/netbsd.h:
203 Move DONT_REOPEN_PTY to configure.
204
20e94fdd
GM
205 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
206 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
207
e99a530f
PE
2082012-07-10 Paul Eggert <eggert@cs.ucla.edu>
209
22ffb973
PE
210 Remove "#define unix" that is no longer needed (Bug#11905).
211 * s/aix4-2.h (unix): Remove; no longer needed.
212
e9a9ae03
PE
213 EMACS_TIME simplification (Bug#11875).
214 This replaces macros (which typically do not work in GDB)
215 with functions, typedefs and enums, making the code easier to debug.
216 The functional style also makes code easier to read and maintain.
217 * systime.h: Include <sys/time.h> on all hosts, not just if
218 WINDOWSNT, since 'struct timeval' is needed in general.
219 (EMACS_TIME): Now a typedef, not a macro.
220 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
221 not macros.
222 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
223 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
224 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
225 (EMACS_TIME_LE): Now functions, not macros.
226 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
227 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
228 which are not functions. All uses rewritten to use:
229 (make_emacs_time): New function.
230 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
231 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
232 not functions. All uses rewritten to use the following, respectively:
233 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
234 (add_emacs_time, sub_emacs_time): New functions.
235 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
236 * fileio.c (Fcopy_file):
237 * xterm.c (XTflash): Get the current time closer to when it's used.
238 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
239
ffacb126
PE
240 * bytecode.c (targets): Suppress -Woverride-init warnings.
241
e99a530f
PE
242 Simplify by avoiding confusing use of strncpy etc.
243 * doc.c (Fsnarf_documentation):
244 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
245 * frame.c (Fmake_terminal_frame):
246 * gtkutil.c (get_utf8_string):
247 * lread.c (openp):
248 * nsmenu.m (ns_update_menubar):
249 * regex.c (regerror):
250 Prefer memcpy to strncpy and strncat when either will do.
251 * fileio.c (Fsubstitute_in_file_name):
252 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
253 (menu_separator_name_p):
254 * nsmenu.m (ns_update_menubar):
255 Prefer memcmp to strncmp when either will do.
256 * nsterm.m: Include <ftoastr.h>.
257 (ns_get_color):
258 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
259 Prefer snprintf to strncpy.
260 * nsterm.m (ns_term_init):
261 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
262 * nsterm.m (ns_term_init):
263 Avoid the need for strncpy, by using build_string or
264 make_unibyte_string directly. Use dtoastr, not snprintf.
265 * process.c (Fmake_network_process): Diagnose service names that
266 are too long, rather than silently truncating them or creating
267 non-null-terminated names.
268 (Fnetwork_interface_info): Likewise, for interface names.
269 * sysdep.c (system_process_attributes) [GNU_LINUX]:
270 Prefer sprintf to strncat.
271 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
272 Prefer vsnprintf to vsprintf + strncpy.
273
c59592b3
GM
2742012-07-10 Glenn Morris <rgm@gnu.org>
275
276 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
277 Clarify fallback case.
278
7d7bbefd
DA
2792012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
280
281 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
282 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
283 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 284 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
285 where argument type is known to be a Lisp_Cons.
286
3a4c8000
TT
2872012-07-10 Tom Tromey <tromey@redhat.com>
288
289 * bytecode.c (BYTE_CODE_THREADED): New macro.
290 (BYTE_CODES): New macro. Replaces all old byte-code defines.
291 (enum byte_code_op): New type.
292 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
293 (exec_byte_code): Use them. Use token threading when applicable.
294
2a0213a6
DA
2952012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
296
297 Optimize pure C strings initialization.
298 * lisp.h (make_pure_string): Fix prototype.
299 (build_pure_c_string): New function, defined as static inline. This
300 provides a better opportunity to optimize away calls to strlen when
301 the function is called with compile-time constant argument.
302 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
303 argument, adjust users accordingly. Use build_pure_c_string where
304 appropriate.
305 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
306 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
307 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
308
cb1caeaf
DA
3092012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
310
311 Avoid calls to strlen in miscellaneous functions.
312 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
313 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
314 * lread.c (openp): Likewise.
315
c293e30c
DA
3162012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
317
318 Avoid calls to strlen in path processing functions.
319 * fileio.c (file_name_as_directory): Add comment. Change to add
320 srclen argument and return the length of result. Adjust users
321 accordingly.
322 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 323 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
324 users accordingly.
325 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
326
9e059e3f
GM
3272012-07-10 Glenn Morris <rgm@gnu.org>
328
d02eb359
GM
329 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
330 Move PENDING_OUTPUT_COUNT definition to configure.
331
882cf227
GM
332 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
333 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
334 * s/gnu.h (DATA_START): Move definitions to configure.
335
af6e839f
GM
336 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
337 We include usg5-4-common.h, which defines them both.
338
40289a12
GM
339 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
340 O_RDONLY already includes it).
341
9e059e3f
GM
342 Stop ns builds setting the EMACSLOADPATH environment variable.
343 * nsterm.m (ns_load_path): Rename from ns_init_paths.
344 Now it does not set EMACSLOADPATH, just returns the load-path string.
345 * nsterm.h: Update accordingly.
346 * lread.c [HAVE_NS]: Include nsterm.h.
347 (init_lread) [HAVE_NS]: Use ns_load_path.
348 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
349
7c4e8ec0
GM
3502012-07-09 Glenn Morris <rgm@gnu.org>
351
d4f600ff
GM
352 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
353 since the included bsd-common.h does so.
354
cbb31951
GM
355 Stop ns builds setting the EMACSPATH environment variable.
356 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
357 (ns_init_paths): Do not set EMACSPATH.
358 * nsterm.h (ns_exec_path): Add it.
359 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
360 Use ns_exec_path.
361
7c4e8ec0
GM
362 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
363
26bccfae
PE
3642012-07-09 Paul Eggert <eggert@cs.ucla.edu>
365
a0bee46f
PE
366 * process.c (wait_reading_process_output): 'waitchannels' was unset
367 when read_kbd || !NILP (wait_for_cell); fix this.
368
5994c183
PE
369 Add GCC-style 'const' attribute to functions that can use it.
370 * character.h (char_resolve_modifier_mask):
371 * keyboard.h (make_ctrl_char):
372 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
373 (init_character_once, next_almost_prime, init_fns, init_image)
374 (flush_pending_output, init_sound):
375 * mem-limits.h (start_of_data):
376 * menu.h (finish_menu_items):
377 Add ATTRIBUTE_CONST.
378 * emacs.c (DEFINE_DUMMY_FUNCTION):
379 Declare the dummy function with ATTRIBUTE_CONST.
380 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
381 Add decls with ATTRIBUTE_CONST.
382
26bccfae
PE
383 Minor improvements to make_formatted_string.
384 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
385 where int is good enough, as vsprintf returns an int.
386 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
387
a8290ec3
DA
3882012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
389
390 Use make_formatted_string to avoid double length calculation.
391 * lisp.h (make_formatted_string): New prototype.
392 * alloc.c (make_formatted_string): New function.
393 * buffer.c (Fgenerate_new_buffer_name): Use it.
394 * dbus.c (syms_of_dbusbind): Likewise.
395 * editfns.c (Fcurrent_time_zone): Likewise.
396 * filelock.c (get_boot_time): Likewise.
397 * frame.c (make_terminal_frame, set_term_frame_name)
398 (x_report_frame_params): Likewise.
399 * image.c (gs_load): Likewise.
400 * minibuf.c (get_minibuffer): Likewise.
401 * msdos.c (dos_set_window_size): Likewise.
402 * process.c (make_process): Likewise.
403 * xdisp.c (ensure_echo_area_buffers): Likewise.
404 * xsettings.c (apply_xft_settings): Likewise.
405
d01ba2f1
GM
4062012-07-09 Glenn Morris <rgm@gnu.org>
407
408 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
409 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
410 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
411 * nsterm.h (ns_etc_directory): Add it.
412 * callproc.c [HAVE_NS]: Include nsterm.h.
413 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
414
f1f924b6
DA
4152012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
416
417 Move marker debugging code under MARKER_DEBUG.
418 * marker.c (MARKER_DEBUG): Move marker debugging code under
419 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
420 for bootstrap with --enable-checking (~3x slowdown reported
421 by Juanma Barranquero <lekktu@gmail.com>).
422 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
423
ab531b66
PE
4242012-07-08 Paul Eggert <eggert@cs.ucla.edu>
425
426 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
427 See <http://bugs.gnu.org/11825#29>.
428
c4b3bc8a
EZ
4292012-07-08 Eli Zaretskii <eliz@gnu.org>
430
431 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
432 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
433 (display_line): Add commentary about displaying truncation glyphs
434 on GUI frames.
435 (produce_special_glyphs): Move here from term.c.
436
437 * term.c (produce_special_glyphs): Move to xdisp.c.
438
439 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
440 section.
c4b3bc8a 441
b676b881
AS
4422012-07-07 Andreas Schwab <schwab@linux-m68k.org>
443
f17c5273
AS
444 * xdisp.c (display_line): Avoid warning about implicit declaration
445 of FRAME_FONT.
446
298819b9
AS
447 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
448
b676b881
AS
449 * lisp.h: Remove empty conditional.
450
6045c4fd
PE
4512012-07-07 Paul Eggert <eggert@cs.ucla.edu>
452
b3350bf9
PE
453 * lread.c (load_path_check): Now static.
454
6045c4fd
PE
455 Fix some minor --with-ns problems found by static checking.
456 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
457 (x_set_font) [!HAVE_X_WINDOWS]:
458 * image.c (xpm_load_image) [HAVE_NS]:
459 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
460 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
461 Remove unused local.
462 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
463 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
464 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
465 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
466 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
467 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
468 Fix pointer signedness problem.
469 * xfaces.c (FRAME_X_FONT_TABLE):
470 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
471
929e7845
GM
4722012-07-07 Glenn Morris <rgm@gnu.org>
473
474 * lread.c (load_path_check): New function, split from init_lread.
475 (init_lread): Reorganize. Motivation:
476 If EMACSLOADPATH is set, check/warn about that rather than the
477 defaults, which we are not going to use. Hence we can remove
478 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
479 Don't warn if site-lisp directories are missing.
480 If not installed, start from a blank load-path, since
481 PATH_LOADSEARCH refers to the eventual installation directories.
482
58dd0aa4
EZ
4832012-07-07 Eli Zaretskii <eliz@gnu.org>
484
485 Support truncation and continuation glyphs on GUI frames, when
486 fringes are disabled. (Bug#11832)
487 * xdisp.c (init_iterator): Get dimensions of truncation and
488 continuation glyphs even if on GUI frames. Adjust
489 it->last_visible_x on GUI frames when the left or right fringes,
490 or both, are absent.
491 (start_display, move_it_in_display_line_to): Handle the case of a
492 GUI frame without a fringe to display continuation or truncation
493 glyphs.
494 (insert_left_trunc_glyphs): Support GUI frames: make sure
495 truncation glyphs overwrite enough glyphs from the current line to
496 have sufficient space in pixels.
497 (display_line): Support truncation and continuation glyphs on GUI
498 frames. If some spare pixels are left on the line after inserting
499 the truncation glyphs, fill that space with a stretch glyph of a
500 suitably computed width.
501
502 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
503 produce_glyphs, to support GUI sessions.
504
31571fd7
PE
5052012-07-07 Paul Eggert <eggert@cs.ucla.edu>
506
5a16b9bc
PE
507 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
508
f3047c75
PE
509 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
510
31571fd7
PE
511 Do not require float-time's arg to fit in time_t (Bug#11825).
512 This works better on hosts where time_t is unsigned, and where
513 float-time is applied to the (negative) difference between two times.
514 * editfns.c (decode_time_components): Last arg is now double *,
515 not int *, and means to store all the result as a double, without
516 worrying about whether the seconds part fits in time_t.
517 All callers changed.
518 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
519 All callers changed.
520 (Ffloat_time): Do not fail merely because the specified time falls
521 outside of time_t range.
522
4516fbef
GM
5232012-07-07 Glenn Morris <rgm@gnu.org>
524
525 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
526 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
527 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
528
07adc2c6
JB
5292012-07-07 Juanma Barranquero <lekktu@gmail.com>
530
531 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
532 Update dependencies.
533
534 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
535
fd573f31
PE
5362012-07-06 Paul Eggert <eggert@cs.ucla.edu>
537
fee5959d
PE
538 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
539 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
540 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
541 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
542 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
543 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
544
fd573f31
PE
545 * xfont.c (compare_font_names): Redo to omit the need for casts.
546
ddadbc0e
AS
5472012-07-06 Andreas Schwab <schwab@linux-m68k.org>
548
fca8d6b6
AS
549 * xfns.c (Fx_change_window_property): Doc fix.
550 * w32fns.c (Fx_change_window_property): Doc fix.
551
ddadbc0e
AS
552 * w32fns.c (Fx_window_property): Accept the same arguments as the
553 X Windows version. Doc fix.
554 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
555
f247498e
JB
5562012-07-06 Juanma Barranquero <lekktu@gmail.com>
557 Eli Zaretskii <eliz@gnu.org>
558
559 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
560 Windows-specific code from nt/config.nt moved here.
561 Obsolete settings removed.
562
216ee680
PE
5632012-07-06 Paul Eggert <eggert@cs.ucla.edu>
564
565 * process.c: Avoid unnecessary calls to gettime.
566 (wait_reading_process_output): Don't get the time of day
567 when gobbling data immediately and not waiting, as there's no need
568 for it in that case. This removes a FIXME.
569
bdd091e4
JD
5702012-07-06 Jan Djärv <jan.h.d@swipnet.se>
571
572 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
573 is defined (Bug#11768).
574
9d44f8ce
DA
5752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Fix marker debugging code.
578 * marker.c (byte_char_debug_check): Do not perform the check
579 if buffer is not multibyte.
090bd7cb
JB
580 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
581 Call byte_char_debug_check with correct arguments.
9d44f8ce 582
90fc4786
DA
5832012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
584
585 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
586 * marker.c (byte_char_debug_check, count_markers):
587 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
588 (byte_debug_flag): Remove.
589 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
590 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
591
7b7ae965
DA
5922012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
593
4e57b342
DA
594 Avoid code repetition in marker-related functions.
595 * marker.c (attach_marker): New function.
596 (Fset_marker, set_marker_restricted, set_marker_both)
597 (set_marker_restricted_both): Use it.
598 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
599 Consistently rename charno to charpos.
600 (marker_position): Add eassert.
601 (marker_byte_position): Convert to eassert.
602
6032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 606 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 607 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 608
657924ff
DA
6092012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
610
611 Introduce fast path for the widely used marker operation.
612 * alloc.c (build_marker): New function.
613 * lisp.h (build_marker): New prototype.
614 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
615 * composite.c (autocmp_chars): Likewise.
616 * editfns.c (buildmark): Remove.
617 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
618 (save_restriction_save): Use build_marker.
619 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
620 * window.c (save_window_save): Likewise.
621
041a49a6
DA
6222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
623
624 Do not use Fdelete_overlay in delete_all_overlays
625 to avoid redundant calls to unchain_overlay.
626 * buffer.c (drop_overlay): New function.
627 (delete_all_overlays, Fdelete_overlay): Use it.
628 * minibuf.c (get_minibuffer): Fix comment.
629
7dca65a4
PE
6302012-07-06 Paul Eggert <eggert@cs.ucla.edu>
631
632 Port to OpenBSD 5.1 amd64.
633 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
634 This is needed for OpenBSD, and should be harmless on all BSD systems.
635 Also, include <sys/sysctl.h>, as it should be available on all
636 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
637 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
638 use p_pid member, not kp_proc.pid.
639
8eb876e2
GM
6402012-07-06 Glenn Morris <rgm@gnu.org>
641
642 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
643
38182d90
PE
6442012-07-05 Paul Eggert <eggert@cs.ucla.edu>
645
646 More xmalloc and related cleanup.
647 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
648 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
649 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
650 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
651 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
652 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
653 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
654 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
655 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
656 * xterm.c:
657 Omit needless casts involving void * pointers and allocation.
658 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
659 as the former is more robust if P's type is changed.
660 Prefer xzalloc to xmalloc + memset 0.
661 Simplify malloc-or-realloc to realloc.
662 Don't worry about xmalloc returning a null pointer.
663 Prefer xstrdup to xmalloc + strcpy.
664 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
665 growing it.
666 * keyboard.c (apply_modifiers_uncached): Prefer local array to
667 alloca of a constant.
668
6dd5a677
EZ
6692012-07-05 Eli Zaretskii <eliz@gnu.org>
670
671 * xdisp.c (display_line): Fix horizontal pixel coordinates when
672 hscroll is larger than the line width. Fixes long and futile
673 looping inside extend_face_to_end_of_line (on a TTY) producing
674 glyphs that are not needed and thrown away.
675
6b312f0f
DA
6762012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
677
678 * marker.c (set_marker_restricted_both): Simplify by using
679 clip_to_bounds.
680
f520ef9b
PE
6812012-07-05 Paul Eggert <eggert@cs.ucla.edu>
682
683 * editfns.c (region_limit): Simplify by using clip_to_bounds.
684
383b7c95
JD
6852012-07-05 Jan Djärv <jan.h.d@swipnet.se>
686
687 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
688 not defined (Bug#11768).
689 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
690 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
691 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
692 followed by gtk_box_set_homogeneous (Bug#11768).
693 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
694 (update_theme_scrollbar_width, xg_create_scroll_bar):
695 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
696 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
697 (is_box_type): New function (Bug#11768).
698 (xg_tool_item_stale_p): Call is_box_type.
5293d758 699 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
700 with default display (Bug#11768).
701
d6e7bf45
EZ
7022012-07-05 Eli Zaretskii <eliz@gnu.org>
703
704 * xdisp.c (window_hscroll_limited): New function.
705 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
706 coordinates when window's hscroll is set to insanely large
707 values. (Bug#11857)
708
431391ec
JB
7092012-07-05 Juanma Barranquero <lekktu@gmail.com>
710
711 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
712 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
713
23f86fce
DA
7142012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
715
716 Cleanup xmalloc.
717 * lisp.h (xzalloc): New prototype. Omit needless casts.
718 * alloc.c (xzalloc): New function. Omit needless casts.
719 * charset.c: Omit needless casts. Convert all calls to
720 xmalloc with following memset to xzalloc.
721 * dispnew.c: Likewise.
722 * fringe.c: Likewise.
723 * image.c: Likewise.
724 * sound.c: Likewise.
725 * term.c: Likewise.
726 * w32fns.c: Likewise.
727 * w32font.c: Likewise.
728 * w32term.c: Likewise.
729 * xfaces.c: Likewise.
730 * xfns.c: Likewise.
731 * xterm.c: Likewise.
732 * atimer.c: Omit needless casts.
733 * buffer.c: Likewise.
734 * callproc.c: Likewise.
735 * ccl.c: Likewise.
736 * coding.c: Likewise.
737 * composite.c: Likewise.
738 * doc.c: Likewise.
739 * doprnt.c: Likewise.
740 * editfns.c: Likewise.
741 * emacs.c: Likewise.
742 * eval.c: Likewise.
743 * filelock.c: Likewise.
744 * fns.c: Likewise.
745 * gtkutil.c: Likewise.
746 * keyboard.c: Likewise.
747 * lisp.h: Likewise.
748 * lread.c: Likewise.
749 * minibuf.c: Likewise.
750 * msdos.c: Likewise.
751 * print.c: Likewise.
752 * process.c: Likewise.
753 * region-cache.c: Likewise.
754 * search.c: Likewise.
755 * sysdep.c: Likewise.
756 * termcap.c: Likewise.
757 * terminal.c: Likewise.
758 * tparam.c: Likewise.
759 * w16select.c: Likewise.
760 * w32.c: Likewise.
761 * w32reg.c: Likewise.
762 * w32select.c: Likewise.
763 * w32uniscribe.c: Likewise.
764 * widget.c: Likewise.
765 * xdisp.c: Likewise.
766 * xmenu.c: Likewise.
767 * xrdb.c: Likewise.
768 * xselect.c: Likewise.
769
0497dc44
PE
7702012-07-05 Paul Eggert <eggert@cs.ucla.edu>
771
772 * fileio.c (time_error_value): Check the right error number.
773 Problem reported by Troels Nielsen in
774 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
775
356e7178
PE
7762012-07-04 Paul Eggert <eggert@cs.ucla.edu>
777
4e71fd89
PE
778 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
779 This should be fixed in a better way; see Eli Zaretskii in
780 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
781 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
782
f0941253
PE
783 * fileio.c (time_error_value): Rename from special_mtime.
784 The old name's problems were noted by Eli Zaretskii in
785 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
786
065c9eb4
PE
787 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
788 This variable's comment says Emacs needs at least one GDB-visible
789 symbol of type enum pvec_type, to work around GDB problems.
790 The symbol's value doesn't matter.
791
356e7178
PE
792 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
793 that causes compilation to fail on pre-C99 compilers.
794
95f61aa2
JB
7952012-07-04 Juanma Barranquero <lekktu@gmail.com>
796
797 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
798 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
799
3884d954
DA
8002012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
801
d209e2fb 802 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
803 headers for buffer_defaults and buffer_local_symbols.
804 Reported by Juanma Barranquero <lekktu@gmail.com>.
805
ee28be33
SM
8062012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
807
808 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
809 * lisp.h (enum pvec_type): Use fewer bits.
810 (PSEUDOVECTOR_SIZE_BITS): New constant.
811 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
812 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
813 change in pvec_type.
814 (PSEUDOVECTOR_TYPEP): New macro.
815 (TYPED_PSEUDOVECTORP): Use it.
816 * fns.c (internal_equal): Adapt code to extract pvectype.
817 * emacs.c (gdb_pvec_type): Update type.
818 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
819 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
820 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
821 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
822 (sweep_vectors): Use it. Use local var `total_bytes' instead of
823 abusing vector->header.next.nbytes.
824 (live_vector_p): Use PVEC_TYPE.
825 (mark_object): Adapt code to extract pvectype. Use switch.
826
c7f2cd7f
PE
8272012-07-04 Paul Eggert <eggert@cs.ucla.edu>
828
829 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
830 Tighten new eassert a bit.
831
8ce70ed2
DA
8322012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
833
834 Fix compilation with --enable-gcc-warnings and -O1
835 optimization level.
836 * doprnt.c (doprnt): Change type of tem to int, initialize
837 to avoid compiler warning. Add eassert.
838 * search.c (simple_search): Initialize match_byte to avoid
839 compiler warning. Add eassert.
840
dea7f1e5
PE
8412012-07-04 Paul Eggert <eggert@cs.ucla.edu>
842
24a212eb
PE
843 Avoid weird behavior with large horizontal scrolls.
844 Without this change, for example, large hscroll values would
845 mess up Emacs's display on Fedora 15 x86, presumably due to
846 overflows in int calculations in the display code.
847 Also, if buffers had long lines, Emacs would freeze.
848 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
849 (set_window_hscroll): New function, containing the old guts of
850 Fset_window_hscroll. Return the clipped value.
851 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
852 This avoids the need to check against PTRDIFF_MAX.
853
dea7f1e5
PE
854 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
855
76046526
DA
8562012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
857
858 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
859
39adff0d
PE
8602012-07-04 Paul Eggert <eggert@cs.ucla.edu>
861
63807d47
PE
862 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
863 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
864 since GCC 4.4.6 issues a bogus warning for them.
865
39adff0d
PE
866 Fix bugs in file timestamp newness comparisons.
867 * fileio.c (Ffile_newer_than_file_p):
868 * lread.c (Fload): Use full timestamp resolution of files,
869 not just the 1-second resolution, so that files that are only
870 slightly newer still count as newer.
871 * fileio.c (Ffile_newer_than_file_p): Don't assume file
872 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
873
dbeed9a6
PE
8742012-07-03 Paul Eggert <eggert@cs.ucla.edu>
875
876 * fileio.c: Improve handling of file time marker. (Bug#11852)
877 (special_mtime): New function.
878 (Finsert_file_contents, Fverify_visited_file_modtime):
879 Use it to set special mtime values consistently.
880
636334d6
AS
8812012-07-03 Andreas Schwab <schwab@linux-m68k.org>
882
883 * fileio.c (Finsert_file_contents): Properly handle st_mtime
884 marker for non-existing file. (Bug#11852)
885
e2017fe2
GM
8862012-07-03 Glenn Morris <rgm@gnu.org>
887
888 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
889 and did not make it into globals.h).
890
404dbd37
TT
8912012-07-03 Tom Tromey <tromey@redhat.com>
892
893 * window.c (Fset_window_margins, Fset_window_fringes)
894 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
895 * textprop.c (Fprevious_property_change): No longer static.
896 * syntax.c (Fsyntax_table_p): No longer static.
897 * process.c (Fget_process, Fprocess_datagram_address): No longer
898 static.
899 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
900 * keyboard.c (Fcommand_execute): No longer static.
901 Remove EXFUN.
902 * insdel.c (Fcombine_after_change_execute): No longer static.
903 * image.c (Finit_image_library): No longer static.
904 * fileio.c (Fmake_symbolic_link): No longer static.
905 * eval.c (Ffetch_bytecode): No longer static.
906 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
907 * doc.c (Fdocumentation_property, Fsnarf_documentation):
908 No longer static.
404dbd37
TT
909 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
910 static.
911 * dired.c (Ffile_attributes): No longer static.
912 * composite.c (Fcomposition_get_gstring): No longer static.
913 * callproc.c (Fgetenv_internal): No longer static.
914
915 * ccl.h: Remove EXFUNs.
916 * buffer.h: Remove EXFUNs.
917 * dispextern.h: Remove EXFUNs.
918 * intervals.h: Remove EXFUNs.
919 * fontset.h: Remove EXFUN.
920 * font.h: Remove EXFUNs.
921 * dosfns.c (system_process_attributes): Remove EXFUN.
922 * keymap.h: Remove EXFUNs.
923 * lisp.h: Remove EXFUNs.
924 * w32term.h: Remove EXFUNs.
925 * window.h: Remove EXFUNs.
926 * xsettings.h: Remove EXFUN.
927 * xterm.h: Remove EXFUN.
928
8e4fd1e1
GM
9292012-07-03 Glenn Morris <rgm@gnu.org>
930
931 * lisp.h (Frandom): Make it visible to C.
932 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
933 buffer for invisible buffers. (Bug#1229)
934
ca95b3eb
DA
9352012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
936
937 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
938 values which aren't power of 2.
939 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
940 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
941 accordingly.
942
7555c33f
SM
9432012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
944
945 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
946
947 * alloc.c (mark_object): Revert part of last patch to use `switch'.
948
d12e8f5a
DA
9492012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
950
951 * alloc.c (allocate_vector_block): Remove redundant
952 calls to mallopt if DOUG_LEA_MALLOC is defined.
953 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
954 avoid calls to mallopt if zero_vector is returned.
955
296094c3
DA
9562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
957
958 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
959 is enabled, avoid dereferencing NULL current_sblock if
960 running undumped.
961
36429c89
DA
9622012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
963
964 Cleanup basic buffer management.
965 * buffer.h (struct buffer): Change layout to use generic vector
966 marking code. Fix some comments. Change type of 'clip_changed'
967 to bitfield. Remove unused #ifndef old.
968 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
969 (GET_OVERLAYS_AT): Fix indentation.
970 (for_each_per_buffer_object_at): New macro.
971 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
972 (Fbuffer_local_variables): Use it.
973 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
974 * alloc.c (allocate_buffer): Adjust to match new layout of
975 struct buffer. Fix comment.
976 (mark_overlay): New function.
977 (mark_buffer): Use it. Use mark_vectorlike to mark normal
978 Lisp area of struct buffer.
979 (mark_object): Use it. Adjust marking of misc objects
980 and related comments.
981
3b3e4cac
PE
9822012-07-02 Paul Eggert <eggert@cs.ucla.edu>
983
984 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
985 wrapper that is not needed because the wrapped code is a no-op (zero
986 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
987 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
988
cf5c0175
DA
9892012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
990
991 * alloc.c (mark_buffer): Simplify. Remove prototype.
992 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 993 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
994 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
995 redundant calls to mark_vectorlike for bool vectors.
996
ca26824c
GM
9972012-06-30 Glenn Morris <rgm@gnu.org>
998
2e4c5312
GM
999 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1000
ca26824c
GM
1001 * epaths.in (PATH_SITELOADSEARCH): New.
1002 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1003 This is rather than relying on --enable-locallisppath elements
1004 having "site-lisp" in their names. (Bug#10208#25, 11658)
1005
0d23c240
EZ
10062012-06-30 Eli Zaretskii <eliz@gnu.org>
1007
c9240d7a
EZ
1008 * w32proc.c (sys_select): Accept and ignore one more argument.
1009
1010 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1011
0d23c240 1012 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1013 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1014
1015 * sysdep.c: Don't include dos.h and dosfns.h.
1016
1017 * process.c (sys_select):
1018 * msdos.c (sys_select): Accept one more argument and ignore it.
1019
1020 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1021 adapt data types and code to that.
1022
1023 * dosfns.c:
1024 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1025 which clashes with the gnulib function of the same name.
1026
af5a5a98
AS
10272012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1028
c5e4379c
AS
1029 * font.c (font_style_to_value, font_style_symbolic)
1030 (font_prop_validate_style): Add type checks for values in
1031 font_style_table.
1032
af5a5a98
AS
1033 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1034 argument.
1035 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1036 uses.
1037
8d38f461
EZ
10382012-06-29 Eli Zaretskii <eliz@gnu.org>
1039
2e5a6631
EZ
1040 * xdisp.c (try_window_id): Undo last change.
1041
8d38f461
EZ
1042 * w32.c (getwd): Adjust commentary about startup_dir.
1043 (init_environment): Always call sys_access, even in non-MSVC
1044 builds. Don't chdir to the directory of the Emacs executable.
1045 This undoes code from 1997 which was justified by the need to
1046 "avoid conflicts when removing and renaming directories". But its
1047 downside was that every relative file name was being interpreted
1048 relative to the directory of the Emacs executable, which can never
1049 be TRT. In particular, it broke sys_access when called with
1050 relative file names.
1051 (sys_access): Map GetLastError to errno.
1052
2af3565e
DA
10532012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1054
1055 * window.h (struct window): Change type of 'fringes_outside_margins'
1056 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1057 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1058 Adjust comment.
1059 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1060 to ptrdiff_t.
1061
c8d3a25c 10622012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1063
c8d3a25c
GM
1064 * gnutls.c (emacs_gnutls_handshake):
1065 Add QUIT to make the loop interruptible.
57570cd3 1066
c8d3a25c 10672012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1068
c8d3a25c
GM
1069 * charset.c (init_charset): Make lack of etc/charsets fatal.
1070
3e984ee8
DA
10712012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1072
1073 * editfns.c (region_limit): Fix type mismatch.
1074
ef884f23
DA
10752012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1076
1077 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1078 undefined. Convert from xassert to eassert.
1079 * nsmenu.m: Convert from xassert to eassert.
1080 * nsterm.m: Likewise.
1081
7d7e0027
SM
10822012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1083
1084 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1085
aa754e6a
PE
10862012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1087
1088 Avoid integer overflow on scroll-left and scroll-right.
1089 * window.c (HSCROLL_MAX): New macro.
1090 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1091 overflow when requested scroll falls outside ptrdiff_t range.
1092
80b00b08
DA
10932012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1094
1095 * window.h (struct window): Change type of 'hscroll',
1096 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1097 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1098 Adjust users accordingly.
1099 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1100 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1101 from EMACS_INT to ptrdiff_t.
1102 (make_window): Omit redundant initialization.
1103
62b2bcf6
JB
11042012-06-28 Juanma Barranquero <lekktu@gmail.com>
1105
1106 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1107
45942c7d
DA
11082012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1109
1110 * window.h (struct window): Change type of 'use_time' and
1111 'sequence_number' from Lisp_Object to int.
1112 * frame.c (make_frame): Adjust users accordingly.
1113 * print.c (print_object): Likewise.
1114 * window.c (select_window, Fwindow_use_time, make_parent_window)
1115 (make_window): Likewise.
1116
e509cfa6
DA
11172012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1118
1119 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1120 enabled with --enable-checking=[all,glyphs] configure option.
1121 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1122 adjust comments accordingly.
1123 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1124 undefined, adjust comments accordingly.
1125 * image.c: Likewise.
1126 * scroll.c: Likewise.
1127 * w32fns.c: Likewise.
1128 * w32term.c: Likewise.
1129 * xdisp.c: Likewise.
1130 * xfaces.c: Likewise.
1131 * xfns.c: Likewise.
1132 * xterm.c: Likewise.
1133
a54e2c05
DA
11342012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1135
1136 Generalize run-time debugging checks.
1137 * dispextern.h (XASSERTS): Remove.
1138 * fontset.c (xassert): Remove.
1139 Convert from xassert to eassert.
1140 * alloc.c: Convert from xassert to eassert.
1141 * bidi.c: Likewise.
1142 * dispnew.c: Likewise.
1143 * fns.c: Likewise.
1144 * fringe.c: Likewise.
1145 * ftfont.c: Likewise.
1146 * gtkutil.c: Likewise.
1147 * image.c: Likewise.
1148 * keyboard.c: Likewise.
1149 * menu.c: Likewise.
1150 * process.c: Likewise.
1151 * scroll.c: Likewise.
1152 * sound.c: Likewise.
1153 * term.c: Likewise.
1154 * w32console.c: Likewise.
1155 * w32fns.c: Likewise.
1156 * w32term.c: Likewise.
1157 * window.c: Likewise.
1158 * xdisp.c: Likewise.
1159 * xfaces.c: Likewise.
1160 * xfns.c: Likewise.
1161 * xselect.c: Likewise.
1162 * xterm.c: Likewise.
1163
1ec4b7b2
SM
11642012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1165
1166 * fns.c (maybe_resize_hash_table): Output message when growing the
1167 purify-hashtable.
1168
2014308a
DA
11692012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 * alloc.c (allocate_string_data): Remove dead code.
1172 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1173 avoid GCC warning about unused macro.
1174
246155eb
DA
11752012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1176
1177 * alloc.c (allocate_string): Omit intervals initialization.
1178 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1179 as in make_pure_string and make_pure_c_string.
1180
43184b7b
DA
11812012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1182
d209e2fb 1183 * alloc.c (allocate_string): Fix last change.
43184b7b 1184
3fe6dd74
DA
11852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1186
d209e2fb 1187 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1188 to memset, add explicit initialization where appropriate.
1189
1ba6038a
GM
11902012-06-27 Glenn Morris <rgm@gnu.org>
1191
1192 * lisp.mk (lisp): Remove paths.elc.
1193
c89926a5
CY
11942012-06-27 Chong Yidong <cyd@gnu.org>
1195
1196 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1197
ed6b3510
JW
11982012-06-26 John Wiegley <johnw@newartisans.com>
1199
1ec4b7b2 1200 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1201 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1202
ed6b3510
JW
1203 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1204 when building with Clang.
1205
8edd4a2b
SM
12062012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1207
1208 * eval.c (Fapply): Allow calling it with a single argument.
1209
f6f62d1b
EZ
12102012-06-26 Eli Zaretskii <eliz@gnu.org>
1211
1212 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1213 _stricmp and _strnicmp.
1214 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1215
62efea5e
DA
12162012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1219 allocated window.
1220 (allocate_process): Likewise for new process.
8edd4a2b 1221 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1222 (allocate_frame): Likewise.
1223 * frame.c (make_frame): Omit redundant initialization.
1224 * window.c (make_parent_window): Use memset.
1225 (make_window): Omit redundant initialization.
1226 * process.c (make_process): Omit redundant initialization.
1227 * terminal.c (create_terminal): Likewise.
1228
42997f4d
DA
12292012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1230
1231 * term.c (delete_tty): Remove redundant call to memset.
1232
1130ecfc
DA
12332012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1234
1235 * alloc.c: Remove build_string.
1236 * lisp.h: Define build_string as static inline. This provides
1237 a better opportunity to optimize away calls to strlen when the
1238 function is called with compile-time constant argument.
1239 * image.c (imagemagick_error): Convert to build_string.
1240 * w32proc.c (sys_spawnve): Likewise.
1241 * xterm.c (x_term_init): Likewise.
1242
cf38a720
PE
12432012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1244
99027bdd
PE
1245 Use sprintf return value instead of invoking strlen on result.
1246 In the old days this wasn't portable, since some sprintf
1247 implementations returned char *. But they died out years ago and
1248 Emacs already assumes sprintf returns int.
1249 Similarly for float_to_string.
1250 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1251 * ccl.c (ccl_driver):
1252 * character.c (string_escape_byte8):
1253 * data.c (Fnumber_to_string):
1254 * doprnt.c (doprnt):
1255 * print.c (print_object):
1256 * xdisp.c (message_dolog):
1257 * xfns.c (syms_of_xfns):
1258 Use sprintf or float_to_string result to avoid need to call strlen.
1259 * data.c (Fnumber_to_string):
1260 Use make_unibyte_string, since the string must be ASCII.
1261 * lisp.h, print.c (float_to_string): Now returns int length.
1262 * term.c (produce_glyphless_glyph):
1263 Use sprintf result rather than recomputing it.
1264
cf38a720
PE
1265 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1266 * Makefile.in (ALL_CFLAGS):
1267 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1268 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1269
3511c784
DA
12702012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1271
0a08eb21 1272 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1273 strcasecmp if available.
1274 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1275
fb7da12e
AS
12762012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1277
1278 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1279 Avoid comma operator.
1280 * menu.c (push_submenu_start, push_submenu_end)
1281 (push_left_right_boundary, push_menu_pane): Likewise.
1282 * msdos.c (dos_rawgetc): Likewise.
1283
afa2ffd8
DA
12842012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1285
1286 * xfns.c (xic_create_fontsetname): Remove redundant calls
1287 to memset.
1288
b3b4476b
PE
12892012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1290
4495ff38
PE
1291 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1292 sprintf already null-terminates its output.
1293
b3b4476b
PE
1294 * xfns.c (x_window): Remove redundant cast.
1295
b00876c9
DA
12962012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1297
1298 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1299 `const char *' to `char *' to avoid compiler warning.
1300
d188e26b
PE
13012012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1302
885d1d74
PE
1303 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1304 instead of truncating it to 63 (admittedly a generous limit).
1305
d188e26b
PE
1306 * process.c: Fix spelling and caps in comments.
1307
e2f560b1
DN
13082012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1309
e86db54b 1310 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1311 * sysdep.c (setpgrp): Remove definition, not used in this file.
1312
7583a3a1
JB
13132012-06-24 Juanma Barranquero <lekktu@gmail.com>
1314
1315 * makefile.w32-in: Update dependencies.
1316
696056c2
EZ
13172012-06-24 Eli Zaretskii <eliz@gnu.org>
1318
1319 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1320 (SYSTIME_H): Add nt/inc/sys/time.h.
1321
1322 * systime.h [WINDOWSNT]: Include sys/time.h.
1323
1324 * s/ms-w32.h (struct timespec): Definition moved from
1325 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1326
845ca893
PE
13272012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1330 * buffer.h (buffer_slot_type_mismatch):
1331 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1332 * eval.c (unwind_to_catch):
1333 * image.c (my_png_error, my_error_exit):
1334 * keyboard.c (quit_throw_to_read_char, user_error)
1335 (Fexit_recursive_edit, Fabort_recursive_edit):
1336 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1337 (wrong_type_argument, buffer_overflow, __executable_start)
1338 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1339 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1340 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1341 (fatal):
1342 (child_setup) [!DOS_NT]:
1343 * lread.c (end_of_file_error, invalid_syntax):
1344 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1345 * puresize.h (pure_write_error):
1346 * search.c (matcher_overflow):
1347 * sound.c (sound_perror, alsa_sound_perror):
1348 * sysdep.c, syssignal.h (croak):
1349 * term.c (maybe_fatal, vfatal):
1350 * textprop.c (text_read_only):
1351 * undo.c (user_error):
1352 * unexmacosx.c (unexec_error):
1353 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1354 Use _Noreturn rather than NO_RETURN.
1355 No need for separate decl merely because of _Noreturn.
1356 * sound.c (sound_warning, parse_sound):
1357 Remove unnecessary forward decls.
1358
f1dd8073
PE
13592012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1362 * lisp.h (WAIT_READING_MAX): New macro.
1363 * dispnew.c (Fsleep_for, sit_for):
1364 * keyboard.c (kbd_buffer_get_event):
1365 * process.c (Faccept_process_output):
1366 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1367 This improves on the previous patch, which introduced a bug
1368 when time_t is unsigned and as wide as intmax_t.
1369 See <http://bugs.gnu.org/9000#51>.
1370
b82c1755
EZ
13712012-06-23 Eli Zaretskii <eliz@gnu.org>
1372
1373 * dispnew.c (sit_for, Fsleep_for):
1374 * keyboard.c (kbd_buffer_get_event):
1375 * process.c (Faccept_process_output): Avoid compiler warnings when
1376 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1377
ca300656
JB
13782012-06-23 Juanma Barranquero <lekktu@gmail.com>
1379
049ec95b
JB
1380 * makefile.w32-in: Update dependencies.
1381
ca300656
JB
1382 * w32.c (ltime): Add return type and declare static.
1383 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1384
db7b8d06
PE
13852012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1388 Privately reported by Herbert J. Skuhra.
1389 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1390 All uses changed.
1391 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1392 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1393
0bd8297f
EZ
13942012-06-23 Eli Zaretskii <eliz@gnu.org>
1395
96512555
EZ
1396 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1397 last argument of make_unibyte_string.
1398
0bd8297f
EZ
1399 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1400 language ID in the event parameters.
1401
1402 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1403 event.code, not the obscure "character set ID".
1404
63def6b6
CY
14052012-06-23 Chong Yidong <cyd@gnu.org>
1406
1407 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1408
e8a02204
EZ
14092012-06-23 Eli Zaretskii <eliz@gnu.org>
1410
388cdec0
EZ
1411 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1412 * w32.c (fdutimens): New function.
1413
1414 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1415
1416 * s/ms-w32.h (pselect): Redirect to sys_select.
1417
1418 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1419
e8a02204
EZ
1420 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1421 in the logic of incrementing and decrementing the value of
1422 use_relocatable_buffers.
1423
d054f3fb
PE
14242012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1427 Privately reported by Herbert J. Skuhra.
1428 [__FreeBSD__]: Remove "*/" typo after "#include".
1429 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1430 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1431 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1432 Don't assume EMACS_TIME and struct timeval are the same type.
1433
d35af63c
PE
14342012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1435
1436 Support higher-resolution time stamps (Bug#9000).
1437 The time stamps are only nanosecond-resolution at the C level,
1438 since that's the best that any real-world system supports now.
1439 But they are picosecond-resolution at the Lisp level, as that's
1440 easy, and leaves room for future OS improvements.
1441
1442 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1443 (LIBES): Use it.
1444
1445 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1446 Don't get current time unless it's needed.
1447
1448 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1449 now provides it if it's absent.
1450 (start_atimer): Port to higher-res time stamps.
1451 Check for time stamp overflow. Don't get current time more
1452 often than is needed.
1453
1454 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1455 Include systime.h, not time.h.
1456 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1457
1458 * dired.c: Include stat-time.h.
1459 (Ffile-attributes): File times now have higher resolution.
1460
1461 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1462 (struct image): Timestamp now has higher resolution.
1463
1464 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1465 has at least microseconds now. All uses removed.
1466 (update_frame, update_single_window, update_window, update_frame_1)
1467 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1468
1469 * editfns.c (time_overflow): Now extern.
1470 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1471 (float-time, Fformat_time_string, Fcurrent_time_string)
1472 (Fcurrent_time_zone): Accept and generate higher-resolution
1473 time stamps.
1474 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1475 (decode_time_components, lisp_seconds_argument): New functions.
1476 (make_time): Now static.
1477 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1478 Report an error if the time is invalid, rather than having the caller
1479 do that.
1480
1481 * fileio.c: Include <stat-time.h>
1482 (Fcopy_file): Copy higher-resolution time stamps.
1483 Prefer to set the time stamp via a file descriptor if that works.
1484 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1485 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1486 (Fvisited_file_modtime, Fset_visited_file_modtime):
1487 Support higher-resolution time stamps.
1488
1489 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1490
1491 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1492
1493 * image.c (prepare_image_for_display, clear_image_cache)
1494 (lookup_image): Port to higer-resolution time stamps.
1495
1496 * keyboard.c (start_polling, bind_polling_period):
1497 Check for time stamp overflow.
1498 (read_char, kbd_buffer_get_event, timer_start_idle)
1499 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1500 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1501 Port to higher-resolution time stamps. Do not assume time_t is signed.
1502 (decode_timer): New function. Timers are now vectors of length 9,
1503 not 8, to accommodate the picosecond component.
1504 (timer_check_2): Use it.
1505
1506 * nsterm.m (select_timeout, timeval_subtract): Remove.
1507 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1508 as they're a bit more accurate and handle overflow better.
1509 (ns_select): Change prototype to be compatible with pselect.
1510 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1511 * nsterm.h (ns_select): Adjust prototype.
1512
1513 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1514 us-resolution time stamps.
1515 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1516
1517 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1518
1519 * lisp.h (time_overflow): New decl.
1520 (wait_reading_process_output): First arg is now intmax_t, not int,
1521 to accommodate larger waits.
1522
1523 * process.h (struct Lisp_Process.read_output_delay):
1524 Now counts nanoseconds, not microseconds.
1525 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1526 EMACS_HAS_USECS.
1527 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1528 (wait_reading_process_output):
1529 Port to ns-resolution time stamps.
1530 (Faccept_process_output, wait_reading_process_output):
1531 Check for time stamp overflow. Do not assume time_t is signed.
1532 (select_wrapper): Remove; we now use pselect.
1533 (Fprocess_attributes): Now generates ns-resolution time stamps.
1534
1535 * sysdep.c: Include utimens.h. Don't include utime.h
1536 or worry about struct utimbuf; gnulib does that for us now.
1537 (gettimeofday): Remove; gnulib provides a substitute.
1538 (make_timeval): New function.
1539 (set_file_times): Now sets ns-resolution time stamps.
1540 New arg FD; all uses changed.
1541 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1542 (system_process_attributes):
1543 Now returns ns-resolution time stamp. All uses changed.
1544 Check for time stamp overflow.
1545
1546 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1547 provides a substitute now.
1548
1549 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1550 since it guarantees struct timespec.
1551 (EMACS_TIME): Now struct timespec, so that we can support
1552 ns-resolution time stamps.
1553 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1554 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1555 (EMACS_USECS): Remove.
1556 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1557 so multiply the arg by 1000 before storing it.
1558 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1559 New macros.
1560 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1561 Port to ns-resolution time stamps.
1562 (EMACS_TIME_NEG_P): Remove; replaced by....
1563 (EMACS_TIME_SIGN): New macro.
1564 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1565 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1566 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1567 (make_timeval, make_lisp_time, decode_time_components): New decls.
1568 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1569 that it mishandled time_t overflow. You can't compare by subtracting!
1570 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1571 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1572
1573 * term.c: Include <sys/time.h>.
1574 (timeval_to_Time): New function, for proper overflow wraparound.
1575 (term_mouse_position, term_mouse_click): Use it.
1576
1577 * undo.c (record_first_change): Support higher-resolution time stamps
1578 in the undo buffer.
1579 (Fprimitive_undo): Use them when restoring time stamps.
1580
1581 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1582 (w32_get_internal_run_time):
1583 Port to higher-resolution Emacs time stamps.
1584 (ltime): Now accepts single 64-bit integer, as that's more convenient
1585 for callers.
1586
1587 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1588
1589 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1590 for compatibility with pselect. Support ns-resolution time stamps.
1591
1592 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1593
1594 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1595 Check for time stamp overflow, and support ns-resolution time stamps.
1596
1597 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1598 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1599 (timeval_subtract): Remove; no longer needed.
1600 (XTflash, XTring_bell, x_wait_for_event):
1601 Port to ns-resolution time stamps. Don't assume time_t is signed.
1602
b6a92dfe
CY
16032012-06-22 Chong Yidong <cyd@gnu.org>
1604
1605 * xdisp.c (x_consider_frame_title): Revert last change.
1606
d251c37c
EZ
16072012-06-22 Eli Zaretskii <eliz@gnu.org>
1608
1609 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1610 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1611 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1612 staticidx goes up to 1597 out of 1600 = 0x640.)
1613
f10deafb
PE
16142012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1617 Otherwise, the umask might be mistakenly 0 while handling input signals.
1618
ec6de1e2
SM
16192012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1620
1621 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1622
28be1ada
DA
16232012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1624
1625 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1626 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1627 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1628 access to `contents' member of Lisp_Vector objects with AREF and ASET
1629 where appropriate.
1630
c6bf3022
CY
16312012-06-19 Chong Yidong <cyd@gnu.org>
1632
1633 * frame.c (delete_frame): When selecting a frame on a different
1634 text terminal, do not alter the terminal's top-frame.
1635
1636 * xdisp.c (format_mode_line_unwind_data): Record the target
1637 frame's selected window and its terminal's top-frame.
1638 (unwind_format_mode_line): Restore them.
1639 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1640 Callers changed.
1641 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1642 since tty frames can be explicitly named.
1643 (prepare_menu_bars): Likewise.
1644
1645 * term.c (Ftty_top_frame): New function.
1646
defd4196
PE
16472012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1648
1649 Port byte-code-meter to modern targets.
1650 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1651 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1652 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1653 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1654 (METER_1, METER_2): Simplify.
1655
1053a871
SM
16562012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1657
1658 * data.c (Fdefalias): Return `symbol' (bug#11686).
1659
b7e8d081
MR
16602012-06-18 Martin Rudalics <rudalics@gmx.at>
1661
1662 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1663 gets killed during executing of this function (Bug#11665).
1664 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1665 (Vkill_buffer_query_functions): In doc-string say that functions
1666 run by this hook should not change the current buffer.
1667
7ea2b339
PE
16682012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1669
1670 Fix recently-introduced process.c problems found by static checking.
1671 * process.c (write_queue_push, write_queue_pop, send_process):
1672 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1673 (write_queue_pop): Fix pointer signedness problem.
1674 (send_process): Remove unused local.
1675
96a313a1
CY
16762012-06-17 Chong Yidong <cyd@gnu.org>
1677
1678 * xdisp.c (redisplay_internal): No need to redisplay terminal
1679 frames that are not on top.
1680
20ca2e94
TN
16812012-06-17 Troels Nielsen <bn.troels@gmail.com>
1682
1683 * process.c (make_process): Initialize write_queue.
1684 (write_queue_push, write_queue_pop): New functions.
1685 (send_process): Use them to maintain correct ordering of process
1686 writes (Bug#10815).
1687
9a900ca9
PE
16882012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1689
310fbfa8
PE
1690 * lisp.h (eassert): Assume C89 or later.
1691 This removes the need for CHECK.
1692 (CHECK): Remove. Its comments about always evaluating its
1693 argument were confusing, as 'eassert' typically does not evaluate
1694 its argument.
1695
27bb1ca4
PE
1696 * coding.c (produce_chars): Use ptrdiff_t, not int.
1697
9a900ca9
PE
1698 * xterm.c (x_draw_underwave): Check for integer overflow.
1699 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1700
41b7f8bc 17012012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1702
1703 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1704 referenced (Bug#11583).
1705
9b0e3eba
AA
17062012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1707
1708 Implement wave-style variant of underlining.
1709 * dispextern.h (face_underline_type): New enum.
1710 (face): Add field for underline type.
1711 * nsterm.m (ns_draw_underwave): New function.
1712 (ns_draw_text_decoration): Use it.
1713 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1714 New functions.
1715 (x_draw_glyph_string): Use them.
1716 * xfaces.c (Qline, Qwave): New Lisp objects.
1717 (check_lface_attrs, merge_face_ref)
1053a871
SM
1718 (Finternal_set_lisp_face_attribute, realize_x_face):
1719 Handle wave-style underline face attributes.
9b0e3eba
AA
1720 * xterm.c (x_draw_underwave): New function.
1721 (x_draw_glyph_string): Use it.
1722
0fb52f11
JB
17232012-06-16 Juanma Barranquero <lekktu@gmail.com>
1724
1725 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1726 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1727 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1728 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1729 ($(BLD)/w32select.$(O)): Update dependencies.
1730
e5560ff7
AS
17312012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1732
1733 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1734 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1735 * character.c (_fetch_multibyte_char_p): Remove.
1736 * alloc.c: Include "character.h" before "buffer.h".
1737 * bidi.c: Likewise.
1738 * buffer.c: Likewise.
1739 * bytecode.c: Likewise.
1740 * callint.c: Likewise.
1741 * callproc.c: Likewise.
1742 * casefiddle.c: Likewise.
1743 * casetab.c: Likewise.
1744 * category.c: Likewise.
1745 * cmds.c: Likewise.
1746 * coding.c: Likewise.
1747 * composite.c: Likewise.
1748 * dired.c: Likewise.
1749 * dispnew.c: Likewise.
1750 * doc.c: Likewise.
1751 * dosfns.c: Likewise.
1752 * editfns.c: Likewise.
1753 * emacs.c: Likewise.
1754 * fileio.c: Likewise.
1755 * filelock.c: Likewise.
1756 * font.c: Likewise.
1757 * fontset.c: Likewise.
1758 * fringe.c: Likewise.
1759 * indent.c: Likewise.
1760 * insdel.c: Likewise.
1761 * intervals.c: Likewise.
1762 * keyboard.c: Likewise.
1763 * keymap.c: Likewise.
1764 * lread.c: Likewise.
1765 * macros.c: Likewise.
1766 * marker.c: Likewise.
1767 * minibuf.c: Likewise.
1768 * nsfns.m: Likewise.
1769 * nsmenu.m: Likewise.
1770 * print.c: Likewise.
1771 * process.c: Likewise.
1772 * regex.c: Likewise.
1773 * region-cache.c: Likewise.
1774 * search.c: Likewise.
1775 * syntax.c: Likewise.
1776 * term.c: Likewise.
1777 * textprop.c: Likewise.
1778 * undo.c: Likewise.
1779 * unexsol.c: Likewise.
1780 * w16select.c: Likewise.
1781 * w32fns.c: Likewise.
1782 * w32menu.c: Likewise.
1783 * window.c: Likewise.
1784 * xdisp.c: Likewise.
1785 * xfns.c: Likewise.
1786 * xmenu.c: Likewise.
1787 * xml.c: Likewise.
1788 * xselect.c: Likewise.
1789
2f07e6af
EZ
17902012-06-16 Eli Zaretskii <eliz@gnu.org>
1791
1053a871
SM
1792 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1793 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1794 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1795 row.
1796 (handle_face_prop): Use chunk-relative overlay string index when
1797 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1798 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1799 the rightmost. (Bug#11720)
2f07e6af 1800
29b83cec
AS
18012012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1802
1803 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1804 (CATEGORY_MEMBER): Enforce 1/0 value.
1805 * category.c (_temp_category_set): Remove.
1806
4c5501e9
EZ
18072012-06-16 Eli Zaretskii <eliz@gnu.org>
1808
1809 * window.c (Fdelete_other_windows_internal)
1810 (Fdelete_window_internal): Don't access frame's mouse highlight
1811 info of the initial frame. (Bug#11677)
1812
2b570124
PE
18132012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1814
e93864f9
PE
1815 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1816 Assume USE_2_TAGS_FOR_INTS.
1817 (xreload): Adjust $tagmask width to match recent lisp.h change.
1818
2b570124
PE
1819 Simplify lisp.h in minor ways that should not affect code.
1820 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1821 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1822 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1823 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1824 (INTTYPEBITS): New macro, for clarity.
1825 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1826 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1827 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1828 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1829 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1830
81755f69
JB
18312012-06-13 Juanma Barranquero <lekktu@gmail.com>
1832
1833 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1834
16192a57
GM
18352012-06-13 Glenn Morris <rgm@gnu.org>
1836
1837 * s/bsd-common.h (BSD4_3):
1838 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1839
646b5f55
AS
18402012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1841
1842 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1843 instead of union.
1844 (XLI, XIL): Define.
1053a871
SM
1845 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1846 Use them.
1847 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1848 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1849 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1850 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1851 * frame.c (delete_frame): Remove outdated comment.
1852 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1853 USE_LISP_UNION_TYPE.
1854 (Fw32_unregister_hot_key): Likewise.
1855 (Fw32_toggle_lock_key): Likewise.
1856 * w32menu.c (add_menu_item): Likewise.
1857 (w32_menu_display_help): Use XIL instead of checking
1858 USE_LISP_UNION_TYPE.
1859 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1860 (init_heap): Likewise.
1861 * w32term.c (w32_read_socket): Update comment.
1862
1d3823c9
GM
18632012-06-13 Glenn Morris <rgm@gnu.org>
1864
c62ff706
GM
1865 * s/usg5-4-common.h, src/s/unixware.h:
1866 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1867
1d3823c9
GM
1868 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1869
bfe3e0a2
PE
18702012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1873 * alloc.c (make_number) [!defined make_number]:
1874 Remove, as lisp.h always defines this now.
1875 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1876 (roundup_size): Verify that it is a power of 2.
1877 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1878 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1879 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1880 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1881 USE_LSB_TAG now is always defined to be either 0 or 1.
1882 All uses changed.
1883 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1884 code works fine either way, and efficiency is not a concern here,
1885 as the union type is for debugging, not for production.
1886 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1887 Use an inline function on all platforms when using the union type,
1888 since this is simpler and 'static inline' can be used portably
1889 within Emacs now.
1890 (LISP_INITIALLY_ZERO): New macro.
1891 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1892 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1893
45fa9c0f
GM
18942012-06-12 Glenn Morris <rgm@gnu.org>
1895
b4492cba
GM
1896 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1897
1898 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1899
45fa9c0f
GM
1900 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1901 Move BROKEN_SIGIO to configure.
1902
1903 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1904 Move NO_TERMIO to configure.
1905
0e25d334
CY
19062012-06-12 Chong Yidong <cyd@gnu.org>
1907
1908 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1909 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1910 MagickExportImagePixels is undefined.
1911
43682bb6
PE
19122012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 * image.c (imagemagick_load_image): Remove unused label.
1915
a9be7d2b
GM
19162012-06-11 Glenn Morris <rgm@gnu.org>
1917
1918 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1919 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1920 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1921 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1922
3017f87f
SM
19232012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1924
1925 * alloc.c (make_byte_code): New function.
1926 (Fmake_byte_code): Use it. Don't purify here.
1927 * lread.c (read1): Use it as well to avoid extra allocation.
1928
1b9b4cf4
CY
19292012-06-11 Chong Yidong <cyd@gnu.org>
1930
1931 * image.c (imagemagick_load_image): Implement transparency.
1932
95988fcf
AS
19332012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1934
1935 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1936 account for preceding backslashes. (Bug#11663)
1937
cd4eb164
CY
19382012-06-09 Chong Yidong <cyd@gnu.org>
1939
1940 * term.c: Support italics in capable terminals (Bug#9652).
1941 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1942 (turn_on_face): Output using TS_enter_italic_mode if available.
1943 Don't handle unused blinking and alt-charset cases.
1944 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1945 and tty_alt_charset_p cases.
1946 (tty_capable_p, init_tty): Support italics.
1947
1948 * termchar.h (struct tty_display_info): Add field for italics.
1949 Remove unused blink field.
1950
1951 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1952 Handle slant.
1953
1954 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1955 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1956 tty_alt_charset_p. Add tty_italic_p.
1957
ff88beb8
MA
19582012-06-09 Michael Albinus <michael.albinus@gmx.de>
1959
1960 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1961 dbus_type_is_basic if available.
1962 (xd_extract_signed, xd_extract_unsigned): Rename from
1963 extract_signed and extract_unsigned, respectively. Adapt callers.
1964
44286096
CY
19652012-06-09 Chong Yidong <cyd@gnu.org>
1966
1682701f
CY
1967 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1968
44286096
CY
1969 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1970 case (Bug#9752).
1971
d86feb17
PE
19722012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1973
1974 * xdisp.c (vmessage): Treat frame message as multibyte.
1975 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1976 would generate the diagnostic "Making \302\247 buffer-local while
1977 let-bound!".
1978
d5c20fe8
EZ
19792012-06-08 Eli Zaretskii <eliz@gnu.org>
1980
1981 * dispnew.c (showing_window_margins_p): Undo last change, which
1982 was done due to an inadvertent commit.
1983 (adjust_frame_glyphs_for_frame_redisplay): Do call
1984 showing_window_margins_p.
1985
513749ee
SM
19862012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1987
1988 * eval.c (Fmake_var_non_special): New primitive.
1989 (syms_of_eval): Defsubr it.
1990 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1991
d4a8f5c1
JB
19922012-06-08 Juanma Barranquero <lekktu@gmail.com>
1993
1994 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1995 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1996
8bbbc977
EZ
19972012-06-08 Eli Zaretskii <eliz@gnu.org>
1998
1999 * alloc.c (allocate_vectorlike): Fix last change.
2000
f3372c87
DA
20012012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2002
2003 Block-based vector allocation of small vectors.
2004 * lisp.h (struct vectorlike_header): New field `nbytes',
2005 adjust comment accordingly.
2006 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2007 to denote vector blocks. Adjust users (live_vector_p,
2008 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2009 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2010 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2011 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2012 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2013 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2014 (roundup_size): New constant.
2015 (struct vector_block): New data type.
2016 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2017 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2018 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2019 (sweep_vectors): New functions.
2020 (allocate_vectorlike): Return `zero_vector' as the only vector of
2021 0 items. Allocate new vector from block if vector size is less than
2022 or equal to VBLOCK_BYTES_MAX.
2023 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2024 (init_alloc_once): Add call to init_vectors.
2025
4f18a4ed
SM
20262012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2027
2028 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2029
86f158bc
PE
20302012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 * doprnt.c (doprnt): Truncate multibyte char correctly.
2033 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2034 would mishandle a string argument "Xc" if X was a multibyte
2035 character of length 2: it would truncate after X's first byte
2036 rather than including all of X.
2037
c5cfcbe0
CY
20382012-06-06 Chong Yidong <cyd@gnu.org>
2039
2040 * buffer.c (word_wrap): Doc fix.
2041
c05cf390
PE
20422012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2043
2044 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2045
0c3461de
GM
20462012-06-03 Glenn Morris <rgm@gnu.org>
2047
2048 * xdisp.c (tool-bar-style): Doc fix.
2049
c71232db
UM
20502012-06-03 Ulrich Müller <ulm@gentoo.org>
2051
2052 * Makefile.in (PAXCTL): Define.
2053 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2054 binary via PaX flags if the paxctl utility is available.
2055 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2056 Restore PaX flags to their default. (Bug#11398)
2057
383f7350
CY
20582012-06-03 Chong Yidong <cyd@gnu.org>
2059
2060 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2061 buffer (Bug#11226).
2062
5f2c76c6
CY
20632012-06-03 Chong Yidong <cyd@gnu.org>
2064
2065 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2066 (note_mode_line_or_margin_highlight): If there is no help echo,
2067 use mode-line-default-help-echo. Handle the case where the mouse
2068 position is past the end of the mode line string.
2069
2070 * buffer.c (buffer_local_value_1): New function, split from
2071 Fbuffer_local_value; can return Qunbound.
2072 (Fbuffer_local_value): Use it.
2073 (Vmode_line_format): Docstring tweaks.
2074
773d47f6
PE
20752012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 * sysdep.c (system_process_attributes): Improve comment.
2078
f2d6a3df
SM
20792012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2080
2081 * keyboard.c: Export real-this-command to Elisp.
2082 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2083 and DEFVAR it. Update all users.
2084
63810350
PE
20852012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2086
7bd5c1f4
PE
2087 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2088
63810350
PE
2089 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2090 Convert pctcpu and pctmem to Lisp float properly.
2091 Let the compiler fold better, as 100.0/0x8000 is exact.
2092
a2821611
AS
20932012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2094
2095 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2096 cons_block.
2097
5fceba1d
PE
20982012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2099
2100 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2101
c98ff5dd
DA
21022012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2103
2104 For a 'struct window', replace some Lisp_Object fields to
2105 bitfields where appropriate, remove unused fields.
2106 * window.h (struct window): Remove unused 'last_mark_x' and
2107 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2108 change it's type from Lisp_Object to bitfield.
2109 Change type of 'force_start', 'optional_new_start',
2110 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2111 fields from Lisp_Object to bitfield. Adjust users accordingly.
2112
ca34e0be
PE
21132012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2114
2115 Pacify gcc -Wdouble-precision when using Xaw.
2116 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2117 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2118 Use 'float' consistently, rather than 'float' in most places
2119 and 'double' in a couple of places.
2120
efc00ab1 21212012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2122
2123 * xdisp.c (handle_stop): Detect whether we have overlay strings
2124 loaded by testing it->current.overlay_string_index to be
2125 non-negative, instead of checking whether n_overlay_strings is
2126 positive. (Bug#11587)
2127
efc00ab1 21282012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2129
2130 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2131
2132 * doc.c (Fsubstitute_command_keys): Doc fix.
2133
efc00ab1 21342012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2135
2136 * search.c (search_buffer): Remove calls to
2137 r_alloc_inhibit_buffer_relocation, as it is now called by
2138 maybe_unify_char, which was the cause of relocation of buffer text
2139 in bug#11519.
2140
efc00ab1 21412012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2142
2143 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2144 for the duration of call to load_charset, to avoid problems with
2145 callers of maybe_unify_char that access buffer text through C
2146 pointers.
2147
2148 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2149 decrement the inhibition flag, instead of just setting or
2150 resetting it.
2151
ba93a187
PE
21522012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2153
2154 Remove obsolete '#define static' cruft.
2155 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2156 This #undef was "temporary" in 2000; it is no longer needed
2157 now that '#define static' has gone away.
2158 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2159 (gray_bitmap_bits): Remove; no longer needed.
2160 All uses replaced with definiens.
2161 * xterm.c: Include "bitmaps/gray.xbm".
2162
9e4bf381
PE
21632012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 Clean up __executable_start, monstartup when --enable-profiling.
2166 The following changes affect the code only when profiling.
2167 * dispnew.c (__executable_start): Rename from safe_bcopy.
2168 Define only on platforms that need it.
2169 * emacs.c: Include <sys/gmon.h> when profiling.
2170 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2171 (__executable_start): Remove decl, since lisp.h does it now.
2172 (safe_bcopy): Remove decl; no longer has that name.
2173 (main): Coalesce #if into single bit of code, for simplicity.
2174 Cast pointers to uintptr_t, since standard libraries want integers
2175 and not pointers.
2176 * lisp.h (__executable_start): New decl.
2177
32d72c2f
GM
21782012-05-31 Glenn Morris <rgm@gnu.org>
2179
2180 * image.c (Fimagemagick_types): Doc fix.
2181
baac5bc7
JM
21822012-05-30 Jim Meyering <meyering@redhat.com>
2183
2184 * callproc.c (Fcall_process_region): Include directory component
2185 in mkstemp error message (Bug#11586).
2186
72cb32cf
PE
21872012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 * alloc.c, lisp.h (make_pure_vector): Now static.
2190
61b108cc
SM
21912012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2192
2193 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2194 Move to byte-run.el.
2195 (Fautoload): Do the hash-doc more carefully.
2196 * data.c (Fdefalias): Purify definition, except for keymaps.
2197 (Qdefun): Move from eval.c.
2198 * lisp.h (Qdefun): Remove.
2199 * lread.c (read1): Tiny simplification.
2200
471fe23d
TN
22012012-05-29 Troels Nielsen <bn.troels@gmail.com>
2202
934f3f58 2203 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2204 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2205 Bug#9642, but explicitly check that the buffer the overlay would
2206 be moved to is live and rearrange lines to make sure that errors
2207 will not put the overlay in an inconsistent state.
2208 (Fdelete_overlay): Cosmetics.
2209
85d0efd1
EZ
22102012-05-28 Eli Zaretskii <eliz@gnu.org>
2211
2212 * w32term.c (my_bring_window_to_top): New function.
2213 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2214 could be different from the original one.
2215 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2216 (Bug#11513)
2217
2218 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2219 by calling BringWindowToTop.
2220
2221 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2222 (WM_EMACS_END): Increase by one.
2223
da92a98c
PE
22242012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2225
2226 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2227 This avoids undefined behavior that might cause the eassert
2228 to not catch an out-of-range value.
2229
74d1f848
JB
22302012-05-28 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2233 Update dependencies.
2234
9e1a06fc
EZ
22352012-05-27 Eli Zaretskii <eliz@gnu.org>
2236
2237 * bidi.c (bidi_mirror_char): Fix last change.
2238
f3dd7312
AS
22392012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2240
2241 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2242 when referring to sectname field in printf format.
2243
81899c91
PE
22442012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2245
57b81a9f
PE
2246 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2247 Only r_alloc_inhibit_buffer_relocation needed to be added;
2248 the others were already declared.
2249
81899c91
PE
2250 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2251 before checking whether it's out of range. Put the check inside
2252 eassert. See
2253 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2254
33017faf 22552012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2256
2257 * callproc.c (Fcall_process): Restore a line that was accidentally
2258 commented out in the 2011-02-13 change (bug#11547).
2259
33017faf 22602012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2261
2262 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2263 defined on ralloc.c.
2264
2265 * buffer.c [REL_ALLOC]: Remove prototypes of
2266 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2267 they are now on lisp.h.
2268
2269 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2270
2271 * search.c (search_buffer): Use it to inhibit relocation of buffer
2272 text while re_search_2 is doing its job, because re_search_2 is
2273 passed C pointers to buffer text. (Bug#11519)
2274
23415acf
EZ
2275 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2276 Update value to 24.
2277
44e27368
EZ
2278 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2279 state after an additional call to move_it_in_display_line_to, keep
2280 the values of it->max_ascent and it->max_descent found for the
2281 entire line.
2282 (pos_visible_p): Revert the comparison against bottom_y to what it
2283 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2284 (Bug#11464)
2285
c1892f11
PE
22862012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 Fix coding-related core dumps with gcc -ftrapv.
2289 The code was computing A - B, where A and B are pointers, and B is
2290 random garbage. This can lead to core dumps on platforms that
2291 have special pointer registers, and it also leads to core dumps on
2292 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2293 A - B only when B is initialized properly.
2294 * coding.c (coding_set_source, coding_set_destination): Return void.
2295 (coding_change_source, coding_change_destinations): New functions,
2296 with the old behaviors of coding_set_source and coding_set_destination.
2297 All callers that need an offset changed to use these new functions.
2298
eb7afdad
GM
22992012-05-26 Glenn Morris <rgm@gnu.org>
2300
2301 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2302
f12fdf02
EZ
23032012-05-26 Eli Zaretskii <eliz@gnu.org>
2304
53a63be6 2305 Extend mouse support on W32 text-mode console.
61b108cc
SM
2306 * xdisp.c (draw_row_with_mouse_face):
2307 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2308
eb3f6f01 2309 * w32console.c: Include window.h.
61b108cc
SM
2310 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2311 New functions.
eb3f6f01
EZ
2312 (initialize_w32_display): Initialize mouse-highlight data.
2313
53a63be6
EZ
2314 * w32inevt.c: Include termchar.h and window.h.
2315 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2316 moves, call note_mouse_highlight. If help_echo changed, call
2317 gen_help_event to produce help-echo message in the echo area.
2318 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2319 highlight info.
2320
4cfd81f6
PE
23212012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 * lread.c (read1): Simplify slightly to avoid an overflow warning
2324 with GCC 4.7.0 on x86-64.
2325
4446092a
EZ
23262012-05-26 Eli Zaretskii <eliz@gnu.org>
2327
2328 * bidi.c (bidi_mirror_char): Revert last change: an int is
2329 definitely wide enough here.
2330
42b2a986 23312012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2332
42b2a986 2333 Fix integer width and related bugs (Bug#9874).
eb106a49 2334 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2335 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2336 (string_bytes, check_sblock, allocate_string_data):
2337 (compact_small_strings, Fmake_bool_vector, make_string)
2338 (make_unibyte_string, make_multibyte_string)
2339 (make_string_from_bytes, make_specified_string)
2340 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2341 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2342 (mark_vectorlike):
2343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2344 (allocate_pseudovector):
2345 Use int, not EMACS_INT, where int is wide enough.
2346 (inhibit_garbage_collection, Fgarbage_collect):
2347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2348 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2349 int might not be wide enough.
2350 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2351 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2352 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2353 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2354 (bidi_level_of_next_char, bidi_move_to_visually_next):
2355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2356 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2357 (Fkill_buffer, Fset_buffer_major_mode)
2358 (advance_to_char_boundary, Fbuffer_swap_text)
2359 (Fset_buffer_multibyte, overlays_at, overlays_in)
2360 (overlay_touches_p, struct sortvec, record_overlay_string)
2361 (overlay_strings, recenter_overlay_lists)
2362 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2363 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2364 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2365 (Foverlay_recenter, last_overlay_modification_hooks_used)
2366 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2368 (validate_region): Omit unnecessary test for b <= e,
2369 since that's guaranteed by the previous test.
d311d28c
PE
2370 (adjust_overlays_for_delete): Avoid pos + length overflow.
2371 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2372 (report_overlay_modification):
2373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2374 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2375 Omit pointer cast, which isn't needed anyway, and doesn't work
2376 after the EMACS_INT -> ptrdiff_t change.
02481186 2377 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2378 * buffer.h: Adjust decls to match defn changes elsewhere.
2379 (struct buffer_text, struct buffer):
2380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2381 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2382 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2383 not int, to avoid needless 32-bit limit on 64-bit hosts.
2384 (exec_byte_code): Use tighter memory-full test, one that checks
2385 for alloca overflow. Don't compute the address of the object just
2386 before an array, as that's not portable. Use EMACS_INT, not
2387 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2388 * callint.c (Fcall_interactively):
2389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2390 * callproc.c (call_process_kill, Fcall_process):
2391 Don't assume pid_t fits into an Emacs fixnum.
2392 (call_process_cleanup, Fcall_process, child_setup):
2393 Don't assume pid_t fits into int.
2394 (call_process_cleanup, Fcall_process, delete_temp_file)
2395 (Fcall_process_region):
2396 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2397 (Fcall_process): Simplify handling of volatile integers.
2398 Use int, not EMACS_INT, where int will do.
2399 * casefiddle.c (casify_object, casify_region, operate_on_word)
2400 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2402 (casify_object): Avoid integer overflow when overallocating buffer.
2403 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2404 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2405 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2406 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2407 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2408 integers are now checked earlier. All uses replaced with XINT.
2409 (ccl_driver):
2410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2411 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2412 (ccl_driver, Fregister_code_conversion_map):
2413 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2414 (resolve_symbol_ccl_program): Check that vector header is in range.
2415 Always copy the vector, so that we can check its contents reliably
2416 now rather than having to recheck each instruction as it's being
2417 executed. Check that vector words fit in 'int'.
2418 (ccl_get_compiled_code, Fregister_ccl_program)
2419 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2420 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2421 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2422 contents are in range.
2423 (Fccl_execute_on_string): Check that status is in range.
2424 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2425 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2426 Accept and return EMACS_INT, not int, because callers can pass values
2427 out of 'int' range.
2428 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2429 (multibyte_chars_in_text, parse_str_as_multibyte)
2430 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2431 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2432 (string_escape_byte8, Fget_byte):
2433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2434 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2435 avoid mishandling large integers.
2436 * character.h: Adjust decls to match defn changes elsewhere.
2437 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2438 (Ffind_charset_region):
2439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2440 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2441 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2442 Don't assume fixnum fits in int.
d311d28c
PE
2443 (load_charset_map_from_vector, Fmap_charset_chars):
2444 Remove now-unnecessary CHECK_NATNUMs.
2445 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2446 Don't rely on undefined behavior with signed left shift overflow.
2447 Don't assume unsigned int fits into fixnum, or that fixnum fits
2448 into unsigned int. Don't require max_code to be a valid fixnum;
2449 that's not true for gb10830 4-byte on a 32-bit host. Allow
2450 invalid_code to be a cons, for the same reason. Require code_offset
2451 to be a character. Avoid int overflow if max_char is close
2452 to INT_MAX.
2453 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2454 this is intended anyway and avoids some undefined behavior.
2455 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2456 INDEX_TO_CODE_POINT, as that's what it expects.
2457 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2458 * charset.h (DECODE_CHAR): Return int, not unsigned;
2459 this is what was intended anyway, and it avoids undefined behavior.
2460 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2461 integer-overflow issues.
2462 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2463 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2464 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2465 * chartab.c (Fmake_char_table, Fset_char_table_range)
2466 (uniprop_get_decoder, uniprop_get_encoder):
2467 Don't assume fixnum fits in int.
2468 * cmds.c (move_point): New function, that does the gist of
2469 Fforward_char and Fbackward_char, but does so while checking
2470 for integer overflow more accurately.
c96e5d6a 2471 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2472 (Fforward_line, Fend_of_line, internal_self_insert)
2473 (internal_self_insert):
2474 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2475 Fix a FIXME, by checking for integer overflow when calculating
2476 target_clm and actual_clm.
2477 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2478 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2479 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2480 (coding_alloc_by_making_gap, alloc_destination)
2481 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2482 (encode_coding_utf_16, detect_coding_emacs_mule)
2483 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2484 (detect_coding_iso_2022, decode_coding_iso_2022)
2485 (encode_invocation_designation, encode_designation_at_bol)
2486 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2487 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2488 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2489 (encode_coding_ccl, encode_coding_raw_text)
2490 (detect_coding_charset, decode_coding_charset)
2491 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2492 (produce_composition, produce_charset, produce_annotation)
2493 (decode_coding, handle_composition_annotation)
2494 (handle_charset_annotation, consume_chars, decode_coding_gap)
2495 (decode_coding_object, encode_coding_object, detect_coding_system)
2496 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2497 (code_convert_region, code_convert_string)
8f50130c
PE
2498 (Fdefine_coding_system_internal)
2499 (coding_set_source, coding_set_destination):
d311d28c
PE
2500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2501 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2502 (Fdefine_coding_system_internal):
2503 Don't assume fixnums fit in int.
2504 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2505 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2506 (Funencodable_char_position, Fcheck_coding_systems_region)
2507 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2509 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2510 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2511 Don't access memory outside of the args array.
d311d28c 2512 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2513 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2514 result of ENCODE_CHAR.
d311d28c
PE
2515 * coding.h: Adjust decls to match defn changes elsewhere.
2516 (struct coding_system):
2517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2518 * composite.c (get_composition_id, find_composition)
2519 (run_composition_function, update_compositions)
2520 (compose_text, composition_gstring_put_cache)
2521 (composition_gstring_p, composition_gstring_width)
2522 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2523 (composition_compute_stop_pos, composition_reseat_it)
2524 (composition_update_it, struct position_record)
2525 (find_automatic_composition, composition_adjust_point)
2526 (Fcomposition_get_gstring, Ffind_composition_internal):
2527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2528 (update_compositions):
2529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2530 * composite.h: Adjust decls to match defn changes elsewhere.
2531 (struct composition):
2532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2533 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2534 Do not attempt to compute the address of the object just before a
2535 buffer; this is not portable.
2536 (Faref, Faset):
2537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2538 (Faset): Use int, not EMACS_INT, where int is wide enough.
2539 (Fstring_to_number): Don't assume fixnums fit in int.
2540 (Frem): Don't assume arg is nonnegative.
2541 * dbusbind.c (xd_append_arg): Check for integers out of range.
2542 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2543 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2544 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2545 (xd_get_connection_references): Return ptrdiff_t, not int.
2546 All uses changed.
2547 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2548 (xd_read_message_1):
2549 Use int, not unsigned, where the dbus API uses int.
2550 (Fdbus_message_internal): Don't overflow mtype.
2551 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2552 * dired.c (directory_files_internal, file_name_completion, scmp)
2553 (file_name_completion_stat):
2554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2555 (file_name_completion): Don't overflow matchcount.
2556 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2557 * dispextern.h: Adjust decls to match defn changes elsewhere.
2558 (struct text_pos, struct glyph, struct bidi_saved_info)
2559 (struct bidi_string_data, struct bidi_it, struct composition_it)
2560 (struct it):
2561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2562 (struct display_pos, struct composition_it, struct it):
2563 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2564 * dispnew.c (increment_matrix_positions)
2565 (increment_row_positions, mode_line_string)
2566 (marginal_area_string):
2567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2568 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2570 (duration_to_sec_usec): New function, to check for overflow better.
2571 (Fsleep_for, sit_for): Use it.
2572 * doc.c (get_doc_string, store_function_docstring):
2573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2574 (get_doc_string, Fsnarf_documentation):
2575 Use int, not EMACS_INT, where int is wide enough.
2576 (get_doc_string):
2577 Use SAFE_ALLOCA, not alloca.
2578 Check for overflow when converting EMACS_INT to off_t.
2579 * doprnt.c (doprnt):
2580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2581 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2582 Don't assume uid_t fits into fixnum.
2583 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2584 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2585 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2586 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2587 (general_insert_function)
2588 (Finsert_char, make_buffer_string, make_buffer_string_both)
2589 (update_buffer_properties, Fbuffer_substring)
2590 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2591 (Fsubst_char_in_region, check_translation)
2592 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2593 (transpose_markers, Ftranspose_regions):
2594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2595 (clip_to_bounds): Move to lisp.h as an inline function).
2596 (Fconstrain_to_field): Don't assume integers are nonnegative.
2597 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2598 (Fsubst_char_in_region, Fsave_restriction):
2599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2600 (Femacs_pid): Don't assume pid_t fits into fixnum.
2601 (lo_time): Use int, not EMACS_INT, when int suffices.
2602 (lisp_time_argument): Check for usec out of range.
2603 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2604 (Fuser_login_name, Fuser_full_name): Signal an error
2605 if a uid argument is out of range, rather than relying on
2606 undefined behavior.
c8d5c857
PE
2607 (Fformat_time_string): Remove now-unnecessary check.
2608 lisp_time_argument checks for out-of-range usec now.
243e0530 2609 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2610 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2611 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2612 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2613 (init_cmdargs, Fdump_emacs):
2614 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2615 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2616 the bottom (typically) 32 bits of the fixnum.
2617 * eval.c (specpdl_size, call_debugger):
2618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2619 (when_entered_debugger, Fbacktrace_debug):
2620 Don't assume fixnum can fit in int.
2621 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2622 the object just before a buffer; this is not portable.
2623 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2624 (grow_specpdl, unbind_to):
2625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2626 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2627 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2628 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2629 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2630 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2632 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2633 (a_write, e_write):
2634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2635 (Fcopy_file, non_regular_nbytes, read_non_regular)
2636 (Finsert_file_contents):
2637 Use int, not EMACS_INT, where int is wide enough.
2638 (READ_BUF_SIZE): Verify that it fits in int.
2639 (Finsert_file_contents): Check that counts are in proper range,
2640 rather than assuming fixnums fit into ptrdiff_t etc.
2641 Don't assume fixnums fit into int.
125b3835 2642 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2643 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2644 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2645 (string_char_to_byte, string_byte_to_char)
2646 (string_make_multibyte, string_to_multibyte)
2647 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2648 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2649 (substring_both, Fdelete, internal_equal, Ffillarray)
2650 (Fclear_string, mapcar1)
2651 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2652 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2653 (larger_vector, make_hash_table, maybe_resize_hash_table)
2654 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2655 (Fmaphash, secure_hash):
2656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2657 (concat): Check for string index and length overflow.
2658 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2659 (Frequire):
2660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2661 (larger_vector): New API (vec, incr_min, size_max) replaces old
2662 one (vec, new_size, init). This catches size overflow.
2663 INIT was removed because it was always Qnil.
2664 All callers changed.
2665 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2666 the upper bound on a hash table index size.
2667 (make_hash_table, maybe_resize_hash_table): Use it.
2668 (secure_hash): Computer start_byte and end_byte only after
2669 they're known to be in ptrdiff_t range.
2670 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2671 (Ffont_get_glyphs, Ffont_at):
2672 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2673 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2674 (Flist_fonts, Fopen_font):
2675 Don't assume fixnum can fit in int.
2676 (check_gstring): Don't assume index can fit in int.
2677 (font_match_p): Check that fixnum is a character, not a nonnegative
2678 fixnum, since the later code needs to stuff it into an int.
2679 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2680 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2681 conversion overflow issues.
2682 (Fopen_font): Check for integer out of range.
2683 (Ffont_get_glyphs): Don't assume index can fit in int.
2684 * font.h: Adjust decls to match defn changes elsewhere.
2685 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2686 integer overflow.
2687 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2688 printmax_t, where ptrdiff_t is wide enough.
2689 (Finternal_char_font):
2690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2691 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2692 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2693 (Fset_frame_position, x_set_frame_parameters)
2694 (x_set_line_spacing, x_set_border_width)
2695 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2696 Check that fixnums are in proper range for system types.
2697 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2699 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2700 Use SAFE_ALLOCA_LISP, not alloca.
2701 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2702 intptr_t is wide enough.
2703 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2704 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2705 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2706 Check for fixnum out of range.
2707 * ftfont.c (ftfont_list): Don't assume index fits in int.
2708 Check that fixnums are in proper range for system types.
2709 (ftfont_shape_by_flt):
2710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2711 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2713 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2714 Check that fixnums are in proper range for system types.
2715 * gnutls.h: Adjust decls to match defn changes elsewhere.
2716 * gtkutil.c (xg_dialog_run):
2717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2718 (update_frame_tool_bar):
2719 Check that fixnums are in proper range for system types.
2720 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2721 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2722 * indent.c (last_known_column, last_known_column_point):
2723 (current_column_bol_cache):
2724 (skip_invisible, current_column, check_display_width):
2725 (check_display_width, scan_for_column, current_column_1)
2726 (Findent_to, Fcurrent_indentation, position_indentation)
2727 (indented_beyond_p, Fmove_to_column, compute_motion):
2728 (Fcompute_motion, Fvertical_motion):
2729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2730 (last_known_column_modified): Use EMACS_INT, not int.
2731 (check_display_width):
2732 (Fcompute_motion):
2733 Check that fixnums and floats are in proper range for system types.
2734 (compute_motion): Don't assume index or fixnum fits in int.
2735 (compute_motion, Fcompute_motion):
2736 Use int, not EMACS_INT, when it is wide enough.
2737 (vmotion): Omit local var start_hpos that is always 0; that way
2738 we don't need to worry about overflow in expressions involving it.
2739 * indent.h: Adjust decls to match defn changes elsewhere.
2740 (struct position):
2741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2742 Use int, not EMACS_INT, where int is wide enough.
2743 Remove unused members ovstring_chars_done and tab_offset;
2744 all uses removed.
2745 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2746 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2747 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2748 (make_gap, copy_text, insert, insert_and_inherit)
2749 (insert_before_markers, insert_before_markers_and_inherit)
2750 (insert_1, count_combining_before, count_combining_after)
2751 (insert_1_both, insert_from_string)
2752 (insert_from_string_before_markers, insert_from_string_1)
2753 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2754 (adjust_after_replace, adjust_after_insert, replace_range)
2755 (replace_range_2, del_range, del_range_1, del_range_byte)
2756 (del_range_both, del_range_2, modify_region)
2757 (prepare_to_modify_buffer, signal_before_change)
2758 (signal_after_change, Fcombine_after_change_execute):
2759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2760 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2761 (balance_an_interval, split_interval_right, split_interval_left)
2762 (find_interval, next_interval, update_interval)
2763 (adjust_intervals_for_insertion, delete_node, delete_interval)
2764 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2765 (static_offset_intervals, offset_intervals)
2766 (merge_interval_right, merge_interval_left, make_new_interval)
2767 (graft_intervals_into_buffer, temp_set_point_both)
2768 (temp_set_point, set_point, adjust_for_invis_intang)
2769 (set_point_both, move_if_not_intangible, get_property_and_range)
2770 (get_local_map, copy_intervals, copy_intervals_to_string)
2771 (compare_string_intervals, set_intervals_multibyte_1):
2772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2773 * intervals.h: Adjust decls to match defn changes elsewhere.
2774 (struct interval):
2775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2776 * keyboard.c (this_command_key_count, this_single_command_key_start)
2777 (before_command_key_count, before_command_echo_length, echo_now)
2778 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2779 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2780 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2781 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2783 (last_non_minibuf_size, last_point_position, echo_truncate)
2784 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2785 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2786 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2787 (stuff_buffered_input):
2788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2789 (last_auto_save, command_loop_1, read_char):
2790 Use EMACS_INT, not int, to avoid integer overflow.
2791 (record_char): Avoid overflow in total_keys computation.
2792 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2793 * keyboard.h: Adjust decls to match defn changes elsewhere.
2794 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2795 (Fkey_description, Fdescribe_vector, Flookup_key):
2796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2797 (click_position): New function, to check that positions are in range.
2798 (Fcurrent_active_maps):
2799 (describe_command):
2800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2801 (Faccessible_keymaps, Fkey_description):
2802 (preferred_sequence_p):
2803 Don't assume fixnum can fit into int.
2804 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2805 Check for integer overflow in size calculations.
2806 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2807 avoid mishandling large integers.
2808 * lisp.h: Adjust decls to match defn changes elsewhere.
2809 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2810 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2811 (struct Lisp_Marker):
2812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2813 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2814 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2815 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2816 All callers changed.
2817 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2818 Assume the arg has valid form, since it always does.
2819 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2820 unsigned integer system type.
2821 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2822 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2823 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2824 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2825 (duration_to_sec_usec): New decl.
2826 * lread.c (read_from_string_index, read_from_string_index_byte)
2827 (read_from_string_limit, readchar, unreadchar, openp)
2828 (read_internal_start, read1, oblookup):
2829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2830 (Fload, readevalloop, Feval_buffer, Feval_region):
2831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2832 (openp): Check for out-of-range argument to 'access'.
2833 (read1): Use int, not EMACS_INT, where int is wide enough.
2834 Don't assume fixnum fits into int.
6efdadfd 2835 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2836 (read_filtered_event): Use duration_to_sec_usec
2837 to do proper overflow checking on durations.
d311d28c
PE
2838 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2839 in size calculation.
2840 (Fexecute_kbd_macro):
2841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2842 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2843 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2844 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2845 (set_marker_both, set_marker_restricted_both, marker_position)
2846 (marker_byte_position, Fbuffer_has_markers_at):
2847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2848 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2849 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2850 It now merely ensures that the menu is large enough, without
2851 necessarily growing it, as this avoids some integer overflow issues.
2852 All callers changed.
2853 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2855 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2856 Use SAFE_ALLOCA_LISP, not alloca.
2857 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2858 to EMACS_INT. Check that fixnums are in proper range for system types.
2859 * minibuf.c (minibuf_prompt_width, string_to_object)
2860 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2861 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2863 (get_minibuffer, read_minibuf_unwind):
2864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2865 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2866 this simplifies overflow checking. All callers changed.
2867 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2868 (Ftest_completion):
2869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2870 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2871 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2872 Check that fixnums are in proper range for system types.
2873 (Fx_create_frame, Fx_show_tip):
2874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2875 * nsfont.m (ns_findfonts, nsfont_list_family):
2876 Don't assume fixnum fits in long.
2877 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2879 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2880 wide enough.
17fdb222 2881 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2883 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2884 (PRINTDECLARE, PRINTPREPARE):
2885 (strout, print_string):
2886 (print, print_preprocess, print_check_string_charset_prop)
2887 (print_object):
2888 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2889 (PRINTDECLARE):
2890 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2892 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2893 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2894 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2895 (print_error_message): Use SAFE_ALLOCA, not alloca.
2896 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2897 (print_depth, new_backquote_output, print_number_index):
2898 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2899 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2900 (Fset_process_window_size, Fformat_network_address)
2901 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2902 (sigchld_handler):
d311d28c 2903 Check that fixnums are in proper range for system types.
d44287d4 2904 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2905 Check for process-ids out of pid_t range rather than relying on
2906 undefined behavior.
e4d81efc 2907 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2908 (Fformat_network_address, read_process_output, send_process)
2909 (Fprocess_send_region, status_notify):
2910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2911 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2912 (wait_reading_process_output, read_process_output, exec_sentinel):
2913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2914 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2915 (Faccept_process_output): Use duration_to_sec_usec to do proper
2916 overflow checking on durations.
dde14581
PE
2917 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2918 Don't assume pid_t fits in int.
02481186
PE
2919 * process.h (struct Lisp_Process): Members tick and update_tick
2920 are now of type EMACS_INT, not int.
b62b53e8
PE
2921 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2922 configured --with-wide-int.
d311d28c
PE
2923 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2924 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2925 * search.c (looking_at_1, string_match_1):
2926 (fast_string_match, fast_c_string_match_ignore_case)
2927 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2928 (scan_newline, find_before_next_newline, search_command)
2929 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2930 (set_search_regs, wordify):
2931 (Freplace_match):
2932 (Fmatch_data):
2933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2934 (string_match_1, search_buffer, set_search_regs):
2935 (Fmatch_data):
2936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2937 (wordify): Check for overflow in size calculation.
2938 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2939 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2940 Check that fixnums are in proper range for system types.
2941 * sound.c (struct sound_device)
2942 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2944 (Fplay_sound_internal):
2945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2946 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2947 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2948 (Fparse_partial_sexp):
2949 Don't assume fixnums can fit in int.
2950 (struct lisp_parse_state, find_start_pos, find_start_value)
2951 (find_start_value_byte, find_start_begv)
2952 (update_syntax_table, char_quoted, dec_bytepos)
2953 (find_defun_start, prev_char_comend_first, back_comment):
2954 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2955 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2957 (Finternal_describe_syntax_value): Check that match_lisp is a
2958 character, not an integer, since the code stuffs it into int.
2959 (scan_words, scan_sexps_forward):
2960 Check that fixnums are in proper range for system types.
2961 (Fforward_word):
2962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2963 (scan_sexps_forward):
2964 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2965 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2966 * syntax.h: Adjust decls to match defn changes elsewhere.
2967 (struct gl_state_s):
2968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2969 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2970 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2971 * sysdep.c (wait_for_termination_1, wait_for_termination)
2972 (interruptible_wait_for_termination, mkdir):
2973 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2974 (emacs_read, emacs_write):
2975 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2976 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2977 and double all fit in int.
d311d28c
PE
2978 * term.c (set_tty_color_mode):
2979 Check that fixnums are in proper range for system types.
2980 * termhooks.h (struct input_event):
2981 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2982 * textprop.c (validate_interval_range, interval_of)
2983 (Fadd_text_properties, set_text_properties_1)
2984 (Fremove_text_properties, Fremove_list_of_text_properties)
2985 (Ftext_property_any, Ftext_property_not_all)
2986 (copy_text_properties, text_property_list, extend_property_ranges)
2987 (verify_interval_modification):
2988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2989 (Fnext_single_char_property_change)
2990 (Fprevious_single_char_property_change):
2991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2992 (copy_text_properties):
2993 Check for integer overflow in index calculation.
d311d28c
PE
2994 * undo.c (last_boundary_position, record_point, record_insert)
2995 (record_delete, record_marker_adjustment, record_change)
2996 (record_property_change):
2997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2998 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3000 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3001 (Fx_hide_tip, Fx_file_dialog):
3002 * w32menu.c (set_frame_menubar):
3003 Use ptrdiff_t, not int, for consistency with rest of code.
3004 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3005 (select_window, Fdelete_other_windows_internal)
3006 (window_scroll_pixel_based, window_scroll_line_based)
3007 (Frecenter, Fset_window_configuration):
3008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3009 (Fset_window_hscroll, run_window_configuration_change_hook)
3010 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3011 (Fscroll_other_window, Frecenter):
d311d28c
PE
3012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3013 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3014 Don't assume fixnum fits in int.
3015 (Fset_window_scroll_bars):
3016 Check that fixnums are in proper range for system types.
3017 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3018 (string_pos, c_string_pos, number_of_chars, init_iterator)
3019 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3020 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3021 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3022 (face_before_or_after_it_pos, handle_invisible_prop)
3023 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3024 (display_prop_intangible_p, string_buffer_position_lim)
3025 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3026 (get_overlay_strings_1, get_overlay_strings)
3027 (iterate_out_of_display_property, forward_to_next_line_start)
3028 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3029 (get_next_display_element, set_iterator_to_next)
3030 (get_visually_first_element, compute_stop_pos_backwards)
3031 (handle_stop_backwards, next_element_from_buffer)
3032 (move_it_in_display_line_to, move_it_in_display_line)
3033 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3034 (add_to_log, message_dolog, message_log_check_duplicate)
3035 (message2, message2_nolog, message3, message3_nolog
3036 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3037 (current_message_1, truncate_echo_area, truncate_message_1)
3038 (set_message, set_message_1, store_mode_line_noprop)
3039 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3040 (text_outside_line_unchanged_p, check_point_in_composition)
3041 (reconsider_clip_changes)
3042 (redisplay_internal, set_cursor_from_row, try_scrolling)
3043 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3044 (redisplay_window, find_last_unchanged_at_beg_row)
3045 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3046 (trailing_whitespace_p, find_row_edges, display_line)
3047 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3048 (display_mode_element, store_mode_line_string)
3049 (pint2str, pint2hrstr, decode_mode_spec)
3050 (display_count_lines, display_string, draw_glyphs)
3051 (x_produce_glyphs, x_insert_glyphs)
3052 (rows_from_pos_range, mouse_face_from_buffer_pos)
3053 (fast_find_string_pos, mouse_face_from_string_pos)
3054 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3056 (safe_call, init_from_display_pos, handle_fontified_prop)
3057 (handle_single_display_spec, load_overlay_strings)
3058 (with_echo_area_buffer, setup_echo_area_for_printing)
3059 (display_echo_area, echo_area_display)
3060 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3061 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3062 (redisplay_window, dump_glyph_row, display_mode_line)
3063 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3064 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3066 (handle_single_display_spec, build_desired_tool_bar_string)
3067 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3068 (get_specified_cursor_type):
3069 Check that fixnums are in proper range for system types.
3070 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3071 (Flookup_image_map):
3072 Don't assume fixnums fit in int.
3073 (compare_overlay_entries):
3074 Avoid mishandling comparisons due to subtraction overflow.
3075 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3076 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3077 (handle_tool_bar_click):
3078 Use int, not unsigned, since we prefer signed and the signedness
3079 doesn't matter here.
3080 (get_next_display_element, next_element_from_display_vector):
3081 Use int, not EMACS_INT, when int is wide enough.
3082 (start_hourglass): Use duration_to_sec_usec to do proper
3083 overflow checking on durations.
3084 * xfaces.c (Fbitmap_spec_p):
3085 Check that fixnums are in proper range for system types.
3086 (compare_fonts_by_sort_order):
3087 Avoid mishandling comparisons due to subtraction overflow.
3088 (Fx_family_fonts, realize_basic_faces):
3089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3090 (Fx_family_fonts):
3091 Don't assume fixnum fits in int.
3092 Use SAFE_ALLOCA_LISP, not alloca.
3093 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3094 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3095 (face_at_buffer_position, face_for_overlay_string)
3096 (face_at_string_position):
3097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3098 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3099 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3100 (Fx_show_tip):
3101 Check that fixnums are in proper range for system types.
3102 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3103 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3105 (Fx_change_window_property): Don't assume fixnums fit in int.
3106 * xfont.c (xfont_chars_supported):
3107 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3108 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3109 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3111 * xml.c (parse_region):
3112 * xrdb.c (magic_file_p):
3113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3114 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3115 (x_get_local_selection, x_reply_selection_request)
3116 (x_handle_selection_request, wait_for_property_change):
3117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3118 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3119 short is wide enough.
3120 (x_send_client_event): Don't assume fixnum fits in int.
3121 * xterm.c (x_x_to_emacs_modifiers):
3122 Don't assume EMACS_INT overflows nicely into int.
3123 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3124 may come from Lisp.
3125 (handle_one_xevent): NATNUMP can eval its arg twice.
3126 (x_connection_closed):
3127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3128 * xterm.h: Adjust decls to match defn changes elsewhere.
3129 (struct scroll_bar): Use struct vectorlike_header
3130 rather than rolling our own approximation.
3131 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3132
c6574eb5
GM
31332012-05-25 Glenn Morris <rgm@gnu.org>
3134
3135 * lisp.mk (lisp): Update for more files being compiled now.
3136
e8d32c7e
SM
31372012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3138
48def666
SM
3139 * lread.c: Remove `read_pure' which makes no difference.
3140 (read_pure): Remove var.
3141 (unreadpure): Remove function.
3142 (readevalloop): Don't call read_list with -1 flag.
3143 (read1, read_vector): Don't test read_pure any more.
3144 (read_list): Simplify.
3145
e8d32c7e
SM
3146 * fileio.c, character.h: Minor style tweaks.
3147
4b2addb7
DA
31482012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3149
3150 * window.h (clip_changed): Remove useless declaration.
3151
584461b2
JB
31522012-05-22 Juanma Barranquero <lekktu@gmail.com>
3153
3154 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3155 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3156
34374650
PE
31572012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3158
3159 Remove src/m/*.
3160 This directory predates autoconf and is no longer needed nowadays.
3161 Move its few remaining bits of functionality to where they're needed.
3162 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3163 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3164 * m/template.h: Remove.
3165 * Makefile.in (M_FILE): Remove. All uses removed.
3166 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3167 * lisp.h (USE_LSB_TAG):
3168 * mem-limits.h (EXCEEDS_LISP_PTR):
3169 Use VAL_MAX, not VALBITS, in #if.
3170 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3171 (EMACS_UINT): Define unconditionally now.
3172 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3173 (BITS_PER_EMACS_INT): New constants, replacing
3174 what used to be in config.h, but not useful in #if.
3175 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3176 define them any more.
3177 (VAL_MAX): New macro.
3178 (VALMASK): Use it.
3179 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3180 BITS_PER_EMACS_INT, in #if.
3181 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3182 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3183 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3184 * s/ms-w32.h (DATA_START):
3185 Move here from removed file m/intel386.h.
3186 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3187 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3188
261cb4bb
PE
31892012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3190
3191 Assume C89 or later.
3192 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3193 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3194 (xrealloc):
3195 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3196 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3197 * textprop.c, tparam.c (NULL): Remove.
3198 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3199 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3200 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3201 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3202 * xterm.c (input_signal_count): Assume volatile works.
3203
ff23cd9f
KB
32042012-05-21 Ken Brown <kbrown@cornell.edu>
3205
3206 * xgselect.c (xg_select): Fix first argument in call to 'select'
3207 (bug#11508).
3208
1b170bc6
KB
32092012-05-20 Ken Brown <kbrown@cornell.edu>
3210
3211 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3212 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3213
b2f4d39f
KB
32142012-05-19 Ken Brown <kbrown@cornell.edu>
3215
3216 * xfns.c (x_in_use): Remove `static' qualifier.
3217 * xterm.h (x_in_use): Declare.
3218 * xgselect.c: Include xterm.h.
3219 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3220 and `display_arg' (bug#9754).
3221
003fdae2
PE
32222012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3223
9232a6d9
PE
3224 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3225
003fdae2
PE
3226 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3227 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3228
784b56e2
EZ
32292012-05-18 Eli Zaretskii <eliz@gnu.org>
3230
3231 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3232
3233 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3234 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3235
3236 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3237 reference to image_cache->refcount.
3238 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3239
a0a79cde
JL
32402012-05-17 Juri Linkov <juri@jurta.org>
3241
3242 * search.c (Fword_search_regexp, Fword_search_backward)
3243 (Fword_search_forward, Fword_search_backward_lax)
3244 (Fword_search_forward_lax): Move functions to isearch.el
3245 (bug#10145, bug#11381).
3246
b0572523
PE
32472012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3248
3249 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3250
9660f5fc
SM
32512012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3252
3253 * lread.c (init_obarray): Declare Qt and Qnil as special.
3254
4374de83
GM
32552012-05-14 Glenn Morris <rgm@gnu.org>
3256
3257 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3258 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3259
dc44c39a
PE
32602012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3261
078c97cb
PE
3262 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3263
dc44c39a
PE
3264 * unexaix.c: Port to more-recent AIX compilers.
3265 (report_error, report_error_1, make_hdr, copy_sym)
3266 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3267 Make arguments const char *, not char *, to avoid violations of C
3268 standard and to fix some AIX warnings reported by Gilles Pion.
3269
e18afed7 32702012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3271
3272 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3273 already have overlays loaded.
3274 (handle_single_display_spec): Before returning without displaying
3275 fringe bitmap, synchronize the bidi iterator with the main display
3276 iterator, by calling iterate_out_of_display_property.
3277 (iterate_out_of_display_property): Detect buffer iteration by
3278 testing that it->string is a Lisp string.
3279 (get_next_display_element): When the current object is exhausted,
3280 and there's something on it->stack, call set_iterator_to_next to
3281 proceed with what's on the stack, instead of returning zero.
3282 (set_iterator_to_next): If called at the end of a Lisp string,
3283 proceed to consider_string_end without incrementing string
3284 position. Don't increment display vector index past the end of
3285 the display vector. (Bug#11417)
c8fb9dc6
EZ
3286 (pos_visible_p): Don't report a position visible when move_it_to
3287 stopped at the last line of window, which happens to be scanned
3288 backwards by the bidi iteration. (Bug#11464)
ac268e67 3289
e18afed7 32902012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3291
3292 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3293 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3294 are on a TTY, and thus unable to display on the fringes.
3295 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3296 so we need to signal to the caller that this is a "replacing"
3297 display spec. This fixes display when the spec is invalid or we
3298 are on a TTY.
3299
e18afed7 33002012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3301
3302 * unexaix.c (make_hdr): Fix typo in prototype.
3303 This bug broke the build on AIX. Problem reported by Gilles Pion.
3304
9d0a235a
MA
33052012-05-14 Michael Albinus <michael.albinus@gmx.de>
3306
3307 * keyboard.c (kbd_buffer_get_event): Read special events also in
3308 batch mode. (Bug#11415)
3309
9e6b06ed
GM
33102012-05-12 Glenn Morris <rgm@gnu.org>
3311
3312 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3313
c1a1d7a3
EZ
33142012-05-12 Eli Zaretskii <eliz@gnu.org>
3315
3316 * lisp.mk (lisp): Add newcomment.elc.
3317
3fe7cdc8
GM
33182012-05-12 Glenn Morris <rgm@gnu.org>
3319
3320 * Makefile.in (MKDIR_P): New, set by configure.
3321 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3322
53f7d2c0
PE
33232012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 Remove unused function hourglass_started.
3326 * dispextern.h (hourglass_started):
3327 * w32fns.c (hourglass_started):
3328 * xdisp.c (hourglass_started): Remove.
3329
75aafb17
JB
33302012-05-10 Juanma Barranquero <lekktu@gmail.com>
3331
3332 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3333 Update dependencies.
3334
12959e8e
PE
33352012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3336
97107e2e
PE
3337 * xgselect.c (xg_select): Put maxfds+1 into a var.
3338 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3339
12959e8e
PE
3340 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3341
836d29b3
DA
33422012-05-10 Dave Abrahams <dave@boostpro.com>
3343
3344 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3345 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3346
5cb67954
MA
33472012-05-09 Michael Albinus <michael.albinus@gmx.de>
3348
3349 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3350 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3351 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3352 Initialize xd_registered_buses.
3353
3478ec45
PE
33542012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3355
b263a6b0
PE
3356 Untag more efficiently if USE_LSB_TAG.
3357 This is based on a proposal by YAMAMOTO Mitsuharu in
3358 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3359 For an admittedly artificial (nth 8000 longlist) benchmark on
3360 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3361 Emacs's overall text size by 1%.
3362 * lisp.h (XUNTAG): New macro.
3363 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3364 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3365 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3366 * eval.c (Fautoload):
3367 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3368 * frame.h (XFRAME): Use XUNTAG.
3369
3478ec45
PE
3370 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3371 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3372 Remove unportable assumptions about print widths of types like
3373 dbus_uint32_t.
3374 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3375 intptr_t when converting between pointer and integer, to avoid GCC
3376 warnings about wrong width.
3377
666b903b 33782012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3379
3380 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3381 stack for each reader_thread, instead of defaulting to 8MB
3382 determined by the linker. This avoids failures in creating
3383 subprocesses on Windows 7, see the discussion in this thread:
3384 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3385
b120cc17
JC
33862012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3387
3388 Fix up display of the *Minibuf-0* buffer in the mini window.
3389 * keyboard.c (read_char): Don't clear the echo area if there's no
3390 message to clear.
3391 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3392 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3393
9a4b36f8
MA
33942012-05-07 Michael Albinus <michael.albinus@gmx.de>
3395
3396 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3397 batch mode.
3398
e5f9458f
CY
33992012-05-06 Chong Yidong <cyd@gnu.org>
3400
3401 * lisp.mk (lisp): Update.
3402
eceeb5fc 34032012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3404
3405 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3406
71873e2b
SM
34072012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3408
3409 * data.c (PUT_ERROR): New macro.
3410 (syms_of_data): Use it. Add new error type `user-error'.
3411 * undo.c (user_error): New function.
3412 (Fprimitive_undo): Use it.
3413 * print.c (print_error_message): Adjust print style for `user-error'.
3414 * keyboard.c (user_error): New function.
3415 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3416
ab0fa4e4
PE
34172012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3418
3419 Do not limit current-time-string to years 1000..9999.
3420 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3421 (Fcurrent_time_string): Support any year that is supported by the
3422 underlying localtime representation. Don't use asctime, as it
3423 has undefined behavior for years outside the range -999..9999.
3424
7ed806a7
PE
34252012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3426
3427 Fix race conditions involving setenv, gmtime, localtime, asctime.
3428 Without this fix, interrupts could mess up code that uses these
3429 nonreentrant functions, since setting TZ invalidates existing
3430 tm_zone or tzname values, and since most of these functions return
3431 pointers to static storage.
3432 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3433 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3434 Grow the critical sections to include not just invoking
3435 localtime/gmtime, but also accessing these functions' results
3436 including their tm_zone values if any, and any related TZ setting.
3437 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3438 so that the struct tm is saved in the critical section.
3439 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3440 motivated by the fact that memory allocation needs to be outside
3441 the critical section.
3442
0c16dfed
DA
34432012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3444
3445 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3446 with RESET_INTERVAL.
3447
3448 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3449 Remove duplicated buffer name initialization.
3450
3f83ace8
JM
34512012-05-02 Jim Meyering <jim@meyering.net>
3452
3453 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3454
c7b8541e
JM
3455 * xfns.c (x_window): Use xstrdup (Bug#11375).
3456
90207a15 34572012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3458
3459 * xdisp.c (pos_visible_p): If already at a newline from the
3460 display string before the 'while' loop, don't walk back the glyphs
3461 from it3.glyph_row. Solves assertion violation when the display
3462 string begins with a newline (egg.el). (Bug#11367)
3463
b593d6a9
AH
34642012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3465
3466 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3467 Move to simple.el.
3468
4737362e
GM
34692012-05-01 Glenn Morris <rgm@gnu.org>
3470
99cf43f9
GM
3471 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3472 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3473 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3474 All were removed before 23.1.
3475
9311dcff
GM
3476 * dispnew.c: Remove HAVE_LIBNCURSES test;
3477 it is always true on relevant platforms.
3478
4d5c6349
GM
3479 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3480 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3481
4737362e
GM
3482 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3483
74dd3a6b
AS
34842012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3485
3486 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3487 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3488 Remove.
3489
13c379ee
PE
34902012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 Do not avoid creating empty evaporating overlays (Bug#9642).
3493 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3494 That is, do not delete an evaporating overlay if it becomes
3495 empty after its bounds are adjusted to fit within its buffer.
3496 This fix caused other problems, and I'm reverting it until we get
3497 to the bottom of them.
3498
a8e7d6d7 34992012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3500
3501 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3502
a8e7d6d7 35032012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3504
3505 * xdisp.c (pos_visible_p): If the window start position is beyond
3506 ZV, start the display from buffer beginning. Prevents assertion
3507 violation in init_iterator when the minibuffer window is scrolled
3508 via the scroll bar.
3509
3510 * window.c (window_scroll_pixel_based): Likewise.
3511
a8e7d6d7 35122012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3513
3514 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3515
a8e7d6d7 35162012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3517
3518 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3519 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3520
a8e7d6d7 35212012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3522
b593d6a9
AH
3523 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3524 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3525
1c6900d9
EZ
35262012-04-26 Eli Zaretskii <eliz@gnu.org>
3527
4c3fa1d9
EZ
3528 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3529 display element, check also the underlying string or buffer
3530 character. (Bug#11341)
3531
1c6900d9
EZ
3532 * w32menu.c: Include w32heap.h.
3533 (add_menu_item): If the call to AppendMenuW (via
3534 unicode_append_menu) fails, disable Unicode menus only if we are
3535 running on Windows 9X/Me.
3536
42bf8205
AS
35372012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3538
3539 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3540 (xgetint): Add missing shift for LSB tags.
3541
b1bac16e
MR
35422012-04-24 Martin Rudalics <rudalics@gmx.at>
3543
3544 * keyboard.c (read_char): Don't wipe echo area for select window
3545 events: These might get delayed via `mouse-autoselect-window'
3546 (Bug#11304).
3547
d69621cc
JB
35482012-04-24 Juanma Barranquero <lekktu@gmail.com>
3549
3550 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3551 manipulation of :loaded-from data.
3552
02fd101b
JB
35532012-04-23 Juanma Barranquero <lekktu@gmail.com>
3554
3555 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3556 now a cons (bug#11311).
3557
888bec30
PE
35582012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3559
89a438bd
PE
3560 Do not create empty overlays with the evaporate property (Bug#9642).
3561 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3562 if it becomes empty after its bounds are adjusted to fit within
3563 its buffer. Without this fix, in a nonempty buffer (let ((o
3564 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3565 yields an empty overlay that has the evaporate property, which is
3566 not supposed to happen.
3567
1068fe4d
PE
3568 Fix minor GTK3 problems found by static checking.
3569 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3570 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3571 (struct _EmacsFixedClass, emacs_fixed_get_type):
3572 Move decls here from emacsgtkfixed.h, since they needn't be public.
3573 (emacs_fixed_get_type): Now static.
3574 (emacs_fixed_class_init): Omit unused local.
3575 (emacs_fixed_child_type): Remove; unused.
3576 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3577 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3578 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3579 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3580 (EMACS_FIXED_GET_CLASS): Remove; unused.
3581 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3582
888bec30
PE
3583 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3584 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3585
de85e130
PE
35862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3587
d0baac98 3588 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3589 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3590 (__malloc_size_t, __malloc_ptrdiff_t):
3591 Remove. All uses removed, replaced by the definiens if needed,
3592 since we can assume C89 or better now.
3593 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3594 (protect_malloc_state, align, get_contiguous_space)
3595 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3596 (malloc_atfork_handler_child, malloc_enable_thread)
3597 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3598 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3599 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3600 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3601 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3602 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3603 Define using prototypes, not old style.
3604 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3605 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3606 (align): Don't assume that signed integer overflow wraps around.
3607 Omit unused local var.
3608 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3609 (_free_internal_nolock, memalign, mallochook, reallochook):
3610 Omit no-longer-needed casts.
3611 (valloc): Use getpagesize, not __getpagesize.
3612 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3613 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3614
de85e130
PE
3615 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3616
dcbf5805
MA
36172012-04-22 Michael Albinus <michael.albinus@gmx.de>
3618
3619 Move functions from C to Lisp. Make non-blocking method calls
3620 the default. Implement further D-Bus standard interfaces.
3621
3622 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3623 (QCdbus_request_name_allow_replacement)
3624 (QCdbus_request_name_replace_existing)
3625 (QCdbus_request_name_do_not_queue)
3626 (QCdbus_request_name_reply_primary_owner)
3627 (QCdbus_request_name_reply_in_queue)
3628 (QCdbus_request_name_reply_exists)
3629 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3630 (QCdbus_registered_serial, QCdbus_registered_method)
3631 (QCdbus_registered_signal): New Lisp objects.
3632 (XD_DEBUG_MESSAGE): Use sizeof.
3633 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3634 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3635 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3636 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3637 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3638 (xd_signature, xd_append_arg): Allow float for integer types.
3639 (xd_get_connection_references): New function.
b593d6a9
AH
3640 (xd_get_connection_address): Rename from xd_initialize.
3641 Return cached address.
dcbf5805
MA
3642 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3643 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3644 level.
3645 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3646 Return number of refcounts.
dcbf5805
MA
3647 (Fdbus_get_unique_name): Make stronger parameter check.
3648 (Fdbus_message_internal): New defun.
3649 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3650 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3651 (Fdbus_send_signal, Fdbus_register_service)
3652 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3653 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3654 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3655 (Vdbus_compiled_version, Vdbus_runtime_version)
3656 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3657 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3658 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3659 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3660 Adapt docstring.
dcbf5805 3661
52828e02
PE
36622012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3663
da05bc4c
PE
3664 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3665 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3666 Do not assume ptrdiff_t is the same width as 'int'.
3667
52828e02
PE
3668 * alloc.c: Handle unusual debugging option combinations.
3669 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3670 since the two debugging options are incompatible.
3671 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3672 is defined.
3673 (mem_init, mem_insert, mem_insert_fixup):
3674 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3675 (NEED_MEM_INSERT): Remove; no longer needed.
3676
f01769f9
LL
36772012-04-22 Leo Liu <sdl.web@gmail.com>
3678
3679 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3680
5790543d
PE
36812012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 * sysdep.c [__FreeBSD__]: Minor cleanups.
3684 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3685 Use Emacs indenting style more consistently. Avoid some casts.
3686 Use 'double' consistently rather than mixing 'float' and 'double'.
3687
b91b7e4d
EW
36882012-04-21 Eduard Wiebe <usenet@pusto.de>
3689
b593d6a9
AH
3690 * sysdep.c (list_system_processes, system_process_attributes):
3691 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3692
6114eb15
AS
36932012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3694
3695 * lisp.mk (lisp): Update.
3696
2f38dff7
PE
36972012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3700 It is never used otherwise.
3701
4ae29f89
SM
37022012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3703
3704 * print.c (print_preprocess): Only check print_depth if print-circle
3705 is nil.
3706 (print_object): Check for cycles even when print-circle is nil and
3707 print-gensym is t, but only check print_depth if print-circle is nil.
3708
f30d612a
CY
37092012-04-20 Chong Yidong <cyd@gnu.org>
3710
3711 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3712 set the status to "failed" and ensure that sentinel is run.
3713
c07a4c0b 37142012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3715
3716 * process.c (Fset_process_inherit_coding_system_flag)
3717 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3718 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3719
c07a4c0b 37202012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3721
3722 * xdisp.c (string_buffer_position_lim): Limit starting position to
3723 BEGV.
3724 (set_cursor_from_row): If called for a mode-line or header-line
3725 row, return zero immediately.
3726 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3727 farther than the first row after the header line, if any.
3728 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3729 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3730
c07a4c0b 37312012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3732
4ae29f89
SM
3733 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3734 (bug#11238).
ad3a2b41 3735
c07a4c0b 37362012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 37372012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3738
3739 configure: new option --enable-gcc-warnings (Bug#11207)
3740 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3741 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3742 (ALL_CFLAGS): Use new macros rather than old.
3743 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3744 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3745 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3746 -Wunused-result, -Wunused-variable. This should go away once
3747 the Emacs and Gnulib regex code is merged.
3748 (xmalloc, xrealloc): Now static.
3749
aba027e8
PE
37502012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3751
3752 * dired.c (Fsystem_groups): Remove unused local.
3753
e5a36063
GM
37542012-04-17 Glenn Morris <rgm@gnu.org>
3755
3756 * dired.c (Fsystem_users): Doc fix.
3757
316411f0
DA
37582012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3759
3760 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3761 (syms_of_dired): Add them.
3762
9426aba4
PE
37632012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3764
b62a57be
PE
3765 Fix minor alloc.c problems found by static checking.
3766 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3767 New extern decls, to avoid calling undeclared functions.
3768 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3769 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3770 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3771 (NEED_MEM_INSERT): New macro.
3772 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3773 Remove one incorrect comment and fix another.
b62a57be 3774
3539f31f
PE
3775 Fix minor ralloc.c problems found by static checking.
3776 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3777 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3778 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3779 (r_alloc_sbrk): Now static.
3780
a041960a
PE
3781 Improve ralloc.c interface checking.
3782 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3783 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3784 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3785 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3786 [REL_ALLOC]: ... to here, to check interface.
3787 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3788 Remove decls. This fixes an "It stinks!".
3789
9426aba4
PE
3790 * alloc.c (which_symbols): Fix alignment issue / type clash.
3791
d55c12ed
AS
37922012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3793
3794 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3795 (struct Lisp_Misc_Any): Likewise.
3796 (struct Lisp_Free): Likewise.
3797 * alloc.c (union aligned_Lisp_Symbol): Define.
3798 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3799 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3800 (union aligned_Lisp_Misc): Define.
3801 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3802 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3803 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3804
b948ce8b
PE
38052012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3806
3807 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3808 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3809 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3810 * s/netbsd.h, s/sol2-6.h:
3811 Remove definition of GC_MARK_STACK, since the default now works.
3812 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3813 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3814 no longer the default.
3815 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3816
35dc09a1 38172012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3818
35dc09a1
GM
3819 * lread.c (lisp_file_lexically_bound_p):
3820 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3821
35dc09a1
GM
38222012-04-14 Eli Zaretskii <eliz@gnu.org>
3823
3824 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3825 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3826
38272012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3828
3829 * nsterm.m (constrainFrameRect): Always constrain when there is only
3830 one screen (Bug#10962).
3831
bcd86815
KB
38322012-04-13 Ken Brown <kbrown@cornell.edu>
3833
3834 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3835
c25df26e
RT
38362012-04-13 Reuben Thomas <rrt@sc3d.org>
3837
3838 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3839
0fc59f1e
DC
38402012-04-11 Daniel Colascione <dancol@dancol.org>
3841
3842 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3843 against is gone. It's better to use vfork now so that when Cygwin
3844 gains a new, working vfork, we use it automatically (bug#10398).
3845
de8c03dc
SM
38462012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3847
3848 * window.c (save_window_save): Obey window-point-insertion-type.
3849
2f097256
GM
38502012-04-11 Glenn Morris <rgm@gnu.org>
3851
3852 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3853
453b951e
SM
38542012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3855
3856 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3857
75f1671a 38582012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3859
3860 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3861 (force_quit_count): New var.
3862 (handle_interrupt): Use it.
3863
2a8ce227
JB
38642012-04-10 Juanma Barranquero <lekktu@gmail.com>
3865
3866 * w32.c (w32_delayed_load): Record the full path of the library
3867 being loaded (bug#10424).
3868
935396c0
GM
38692012-04-09 Glenn Morris <rgm@gnu.org>
3870
05920a43
GM
3871 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3872 not just in the obarray, before snarfing them. (Bug#11036)
3873
935396c0
GM
3874 * Makefile.in ($(leimdir)/leim-list.el):
3875 Pass EMACS rather than BUILT_EMACS.
3876
a18ecafa
TZ
38772012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3878
3879 * process.c (make_process):
3880 * process.h: Add integer `gnutls_handshakes_tried' member to
3881 process struct.
3882
6bbef4e5
JC
3883 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3884 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3885
3886 * gnutls.c (gnutls_log_function2i): Convenience log function.
3887 (emacs_gnutls_read): Use new log functions,
3888 `gnutls_handshakes_tried' process member, and
3889 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3890 attempts per process (connection).
3891
b4d3bc10
CY
38922012-04-09 Chong Yidong <cyd@gnu.org>
3893
3894 * eval.c (Fuser_variable_p, user_variable_p_eh)
3895 (lisp_indirect_variable): Functions deleted.
3896 (Fdefvar): Caller changed.
3897
3898 * callint.c (Finteractive, Fcall_interactively):
3899 * minibuf.c (Fread_variable): Callers changed.
3900
70f4d973
EZ
39012012-04-09 Eli Zaretskii <eliz@gnu.org>
3902
3903 * xdisp.c (set_cursor_from_row): If the display string appears in
3904 the buffer at position that is closer to point than the position
3905 after the display string, display the cursor on the first glyph of
3906 the display string. Fixes cursor display when a 'display' text
3907 property immediately follows invisible text. (Bug#11094)
3908
cb3c2e3e
PE
39092012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 composite.c: use 'double' consistently
3912 * composite.c (get_composition_id): Use 'double' consistently
3913 instead of converting 'float' to 'double' and vice versa; this is
3914 easier to understand and avoids a GCC warning.
3915
fd06db5d
GM
39162012-04-09 Glenn Morris <rgm@gnu.org>
3917
50fe702a
GM
3918 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3919 preparation for dumping it with emacs. (Bug#4789)
3920 (leimdir): New variable.
3921 ($(leimdir)/leim-list.el): New rule.
3922 (emacs$(EXEEXT)): Depend on leim-list.el.
3923
fd06db5d
GM
3924 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3925 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3926 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3927
55c131ee
AS
39282012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3929
3930 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3931 proper alignment.
3932
9209588f
JB
39332012-04-07 Juanma Barranquero <lekktu@gmail.com>
3934
3935 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3936 Remove unused local variable.
3937
e3fb2efb
PE
39382012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3939
3940 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3941 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3942 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3943 objects, as mark_maybe_pointer will catch them otherwise.
3944 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3945 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3946
b5385551
PE
39472012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3948
3949 Fix typo that broke non-Windows builds.
3950 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3951
9078ead6
EZ
39522012-04-07 Eli Zaretskii <eliz@gnu.org>
3953
3954 Support building on MS-Windows with libxml2.
3955
3956 * makefile.w32-in (OBJ2): Add xml.$(O).
3957 (GLOBAL_SOURCES): Add xml.c.
3958 ($(BLD)/xml.$(O)): New dependency list.
3959
3960 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3961 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3962 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3963 [!WINDOWSNT]: New macros.
3964 (init_libxml2_functions, libxml2_loaded_p): New functions.
3965 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3966 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3967 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3968 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3969 linked in).
6bbef4e5
JC
3970 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3971 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3972 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3973
3974 * emacs.c: Don't include libxml/parser.h.
3975 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3976 xmlCleanupParser directly.
3977
3978 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3979
3811fdf3
EZ
39802012-04-07 Eli Zaretskii <eliz@gnu.org>
3981
3982 * indent.c (Fvertical_motion): If there is a display string at
3983 point, use it.vpos to compute how many lines to backtrack after
3984 move_it_to point. (Bug#11133)
3985
2f8e16b2
EZ
39862012-04-06 Eli Zaretskii <eliz@gnu.org>
3987
3988 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3989 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3990 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3991 macros related to unification of CJK characters. For the details,
3992 see the discussion following the message here:
3993 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3994
3d439cd1
CY
39952012-04-04 Chong Yidong <cyd@gnu.org>
3996
3997 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3998
8bc53d00
EZ
39992012-04-01 Eli Zaretskii <eliz@gnu.org>
4000
4001 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4002 instead of alloca. (Bug#11138)
4003
3b0512a3
AS
40042012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4005
4006 * w32menu.c (is_simple_dialog): Properly check lisp types.
4007 (Bug#11141)
4008
8427ddd2
EZ
40092012-03-31 Eli Zaretskii <eliz@gnu.org>
4010
979022ef
EZ
4011 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4012 position we get to after a call to move_it_to fails the
4013 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4014 only if we wind up in a string from display property. (Bug#11063)
4015
a6b1c7cc
EZ
4016 * window.c (Fdelete_other_windows_internal): Invalidate the row
4017 and column information about mouse highlight, so that redisplay
4018 restores it after reallocating the glyph matrices. (Bug#7464)
4019
8427ddd2
EZ
4020 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4021 string comes from a `display' text property, use the buffer
4022 position of that property as if we actually saw that position in
4023 the row's glyphs.
697ba24b
EZ
4024 (move_it_by_lines): Remove the assertion that
4025 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4026 violated when there's a before-string at the beginning of a line.
4027 (Bug#11063)
8427ddd2 4028
65a0a738
EZ
40292012-03-30 Eli Zaretskii <eliz@gnu.org>
4030
4031 * xdisp.c (append_space_for_newline): If the default face was
4032 remapped, use the remapped face for the appended newline.
4033 (extend_face_to_end_of_line): Use the remapped default face for
4034 extending the face to the end of the line.
4035 (display_line): Call extend_face_to_end_of_line when the default
4036 face was remapped. (Bug#11068)
4037
581355cc
EZ
40382012-03-29 Eli Zaretskii <eliz@gnu.org>
4039
4040 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4041
e8fc049f
SM
40422012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4043
4044 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4045
4fb9a543
GM
40462012-03-27 Glenn Morris <rgm@gnu.org>
4047
4048 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4049 Doc fixes.
4050
679910f1
KH
40512012-03-26 Kenichi Handa <handa@m17n.org>
4052
4053 * dispextern.h (struct glyph): Fix previous change. Change the
4054 bit length of glyphless.ch to 25 (Bug#11082).
4055
90d49b7f
CY
40562012-03-26 Chong Yidong <cyd@gnu.org>
4057
4058 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4059 (command_loop_1): Use it; inhibit selection update for
4060 handle-select-window too (Bug#8996).
4061
f514f6f0
FP
40622012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4063
e8fc049f 4064 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4065
bf43fa51
KH
40662012-03-25 Kenichi Handa <handa@m17n.org>
4067
4068 * dispextern.h (struct glyph): Change the bit length of
4069 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4070
8a0c01dd
EZ
40712012-03-24 Eli Zaretskii <eliz@gnu.org>
4072
4073 * s/ms-w32.h (tzname): Include time.h before redirecting to
4074 _tzname. Fixes the MSVC build. (Bug#9960)
4075
7d1c3a76
AS
40762012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4077
8ed79523
AS
4078 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4079 characters.
4080
7d1c3a76
AS
4081 * xterm.c (XTread_socket): Only modify handling_signal if
4082 !SYNC_INPUT. (Bug#11080)
4083
e99a9b8b
EZ
40842012-03-23 Eli Zaretskii <eliz@gnu.org>
4085
4086 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4087 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4088 when fetching a multibyte character consumes more bytes than
4089 CHAR_BYTES returns, due to unification of CJK characters in
4090 string_char. (Bug#11073)
4091
5063c0e1
TN
40922012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4093
4094 * process.c (wait_reading_process_output): Handle pty disconnect
4095 by refraining from sending oneself a SIGCHLD (bug#10933).
4096
9f851fbd
CY
40972012-03-22 Chong Yidong <cyd@gnu.org>
4098
4099 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4100
5063c0e1 4101 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4102 Mark string as coming from a prefix property.
4103 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4104 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4105
fb5b8aca
CY
41062012-03-21 Chong Yidong <cyd@gnu.org>
4107
4108 * xfaces.c (Vface_remapping_alist): Doc fix.
4109
62356a1b
EZ
41102012-03-20 Eli Zaretskii <eliz@gnu.org>
4111
4112 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4113 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4114 Doc fixes.
62356a1b 4115
025de85b
CY
41162012-03-20 Chong Yidong <cyd@gnu.org>
4117
4118 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4119 to reflect default non-nil value of redisplay-dont-pause.
4120
4827f94e
KH
41212012-03-19 Kenichi Handa <handa@m17n.org>
4122
4123 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4124 it fit in a valid range (Bug#11003).
4125
e50a24a2
EZ
41262012-03-18 Eli Zaretskii <eliz@gnu.org>
4127
4128 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4129 that is not from display property, accept the row as a "cursor
4130 row" if one of the string's character has a non-nil `cursor'
4131 property. Fixes cursor positioning when there are newlines in
4132 overlay strings, e.g. in icomplete.el. (Bug#11035)
4133
9af5ed87
PE
41342012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4137
d1f55f16
CY
41382012-03-12 Chong Yidong <cyd@gnu.org>
4139
4140 * eval.c (inhibit_lisp_code): Rename from
4141 inhibit_window_configuration_change_hook; move from window.c.
4142
4143 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4144 * window.c (run_window_configuration_change_hook)
4145 (syms_of_window): Callers changed.
4146
66c5eebd
CY
41472012-03-11 Chong Yidong <cyd@gnu.org>
4148
413df973
CY
4149 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4150
66c5eebd
CY
4151 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4152
1de11f56
CY
41532012-03-10 Chong Yidong <cyd@gnu.org>
4154
4155 * frame.c (other_visible_frames): Don't assume the selected frame
4156 is visible (Bug#10955).
4157
cae07000
SM
41582012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4159
4160 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4161
89c94350
JD
41622012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4163
4164 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4165 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4166 zero (Bug#10954).
4167
999dd333
GM
41682012-03-03 Glenn Morris <rgm@gnu.org>
4169
01a6dcc8 4170 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4171
de0100f2
EZ
41722012-03-02 Eli Zaretskii <eliz@gnu.org>
4173
4174 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4175 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4176 (redisplay_window, next_element_from_string): Fix typos in
4177 comments.
3e441275
EZ
4178 (redisplay_window): Pass to move_it_vertically the margin in
4179 pixels, not in screen lines.
de0100f2 4180
96a72ee9
GM
41812012-03-02 Glenn Morris <rgm@gnu.org>
4182
4183 * buffer.c (buffer-list-update-hook): Doc fix.
4184
312508d7
EZ
41852012-02-29 Eli Zaretskii <eliz@gnu.org>
4186
4187 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4188 push_it before setting up the iterator for the first overlay
4189 string, even if we have an empty string loaded.
4190 (next_overlay_string): If there's an empty string on the iterator
4191 stack, pop the stack. (Bug#10903)
4192
27f3c637
PE
41932012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4194
4195 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4196 Suggested by Stefan Monnier in
4197 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4198 * alloc.c (widen_to_Lisp_Object): New static function.
4199 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4200 and widening them to Lisp_Objects. This would work even if
4201 USE_LSB_TAG is defined and wide integers are used, which might
4202 happen in a future version of Emacs.
4203
3c9dfce6
CY
42042012-02-25 Chong Yidong <cyd@gnu.org>
4205
fa74b241
CY
4206 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4207 Doc fix.
4208
3c9dfce6
CY
4209 * xselect.c (Fx_selection_exists_p): Doc fix.
4210 (x_clipboard_manager_save_all): Print an informative message
4211 before saving to clipboard manager.
4212
9486df08
CY
42132012-02-24 Chong Yidong <cyd@gnu.org>
4214
4215 * keyboard.c (process_special_events): Handle all X selection
4216 requests in kbd_buffer, not just the next one (Bug#8869).
4217
f01d3321
CY
42182012-02-23 Chong Yidong <cyd@gnu.org>
4219
4220 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4221 call when setting menu-bar-lines and tool-bar-lines parameters.
4222 (unwind_create_frame_1): New helper function.
4223
4224 * window.c (inhibit_window_configuration_change_hook): New var.
4225 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4226 (syms_of_window): Initialize it.
f01d3321 4227
86b847b6
CY
42282012-02-22 Chong Yidong <cyd@gnu.org>
4229
4230 * xterm.c (x_draw_image_relief): Add missing type check for
4231 Vtool_bar_button_margin (Bug#10743).
4232
a59225b1
CY
42332012-02-21 Chong Yidong <cyd@gnu.org>
4234
4235 * fileio.c (Vfile_name_handler_alist): Doc fix.
4236
4237 * buffer.c (Fget_file_buffer): Protect against invalid file
4238 handler return value.
4239
310f5bd4
PE
42402012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4241
cb3a28cc
PE
4242 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4243 when computing $valmask.
4244
310f5bd4
PE
4245 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4246 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4247 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4248 It's useless in that case, and it can cause problems on hosts
4249 that allocate halves of EMACS_INT values separately.
4250 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4251 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4252 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4253 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4254 it avoids undefined behavior on hosts where shifting right by more
4255 than the word width has undefined behavior.
4256
2375c96a
CY
42572012-02-19 Chong Yidong <cyd@gnu.org>
4258
4259 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4260 (Funhandled_file_name_directory, Ffile_name_as_directory)
4261 (Fdirectory_file_name, Fexpand_file_name)
4262 (Fsubstitute_in_file_name): Protect against invalid file handler
4263 return values (Bug#10845).
4264
3eb49e71
EZ
42652012-02-18 Eli Zaretskii <eliz@gnu.org>
4266
4267 * .gdbinit (pitx): Fix incorrect references to fields of the
4268 iterator stack.
4269
7b926f3f
CY
42702012-02-17 Chong Yidong <cyd@gnu.org>
4271
4272 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4273
11273115
PE
42742012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4275
4276 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4277 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4278
c3a70e2b
CY
42792012-02-15 Chong Yidong <cyd@gnu.org>
4280
4281 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4282 marked as special. Also, starting docstrings with * is obsolete.
4283
0ca43699
AS
42842012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4285
4286 * gnutls.c (emacs_gnutls_write): Fix last change.
4287
2e8f3c56
LI
42882012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4289
4290 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4291 send_process.
4292
af70074f
SM
42932012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4294
4295 * keymap.c (Fsingle_key_description): Handle char ranges.
4296
95986d52
CY
42972012-02-12 Chong Yidong <cyd@gnu.org>
4298
afd83bd1
CY
4299 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4300 as that creates a dangerous corner case.
4301
95986d52
CY
4302 * window.c (Fdelete_window_internal): Invalidate the mouse
4303 highlight (Bug#9904).
4304
bd7da63e
GM
43052012-02-12 Glenn Morris <rgm@gnu.org>
4306
4307 * xselect.c (Fx_own_selection_internal)
4308 (Fx_get_selection_internal, Fx_disown_selection_internal)
4309 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4310 * nsselect.m (Fx_own_selection_internal)
4311 (Fx_disown_selection_internal, Fx_selection_exists_p)
4312 (Fx_selection_owner_p, Fx_get_selection_internal):
4313 Sync docs and argument specs with the xselect.c versions.
4314
77abcbc2
LI
43152012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4316
4317 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4318
90b671e2
EZ
43192012-02-11 Eli Zaretskii <eliz@gnu.org>
4320
1c0ca0b7
EZ
4321 * w32select.c (Fx_selection_exists_p): Sync doc string and
4322 argument list with xselect.c. (Bug#10783)
4323
4324 * w16select.c (Fx_selection_exists_p): Sync doc string and
4325 argument list with xselect.c. (Bug#10783)
90b671e2 4326
49241268
GM
43272012-02-10 Glenn Morris <rgm@gnu.org>
4328
4329 * fns.c (Fsecure_hash): Doc fix.
4330
f998bbe7 43312012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4332
4333 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4334
0992bd9c
CY
43352012-02-07 Chong Yidong <cyd@gnu.org>
4336
4337 * buffer.c (Fbuffer_local_variables)
4338 (buffer_lisp_local_variables): Handle unbound vars correctly;
4339 don't let Qunbound leak into Lisp.
4340
af008560
GM
43412012-02-07 Glenn Morris <rgm@gnu.org>
4342
dd605cc4
GM
4343 * image.c (Fimagemagick_types): Doc fix.
4344
af008560
GM
4345 * image.c (imagemagick-render-type): Change it from a lisp object
4346 to an integer. Move the doc here from the lisp manual.
4347 Treat all values not equal to 0 the same.
4348
1449fa1d
CY
43492012-02-06 Chong Yidong <cyd@gnu.org>
4350
4351 * doc.c (store_function_docstring): Avoid applying docstring of
4352 alias to base function (Bug#2603).
4353
3723ec07
AS
43542012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4355
4356 * .gdbinit (pp1, pv1): Remove redundant defines.
4357 (pr): Use pp.
4358
79c1cc1e
CY
43592012-02-04 Chong Yidong <cyd@gnu.org>
4360
4361 * nsterm.m: Declare a global (Bug#10694).
4362
d7f29f8e
EZ
43632012-02-04 Eli Zaretskii <eliz@gnu.org>
4364
cae07000
SM
4365 * w32.c (get_emacs_configuration_options):
4366 Include --enable-checking, if specified, in the return value.
d7f29f8e 4367
3b95a6f9
MR
43682012-02-04 Martin Rudalics <rudalics@gmx.at>
4369
4370 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4371 after rounding frame sizes. (Bug#9723)
4372
d6fa96a6
EZ
43732012-02-04 Eli Zaretskii <eliz@gnu.org>
4374
4375 * keyboard.c (adjust_point_for_property): Don't position point
4376 before BEGV. (Bug#10696)
4377
df0b2940
PE
43782012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 Handle overflow when computing char display width (Bug#9496).
4381 * character.c (char_width): Return EMACS_INT, not int.
4382 (char_width, c_string_width): Check for overflow when
4383 computing the width; this is possible now that individual
4384 characters can have unbounded width. Problem introduced
4385 by merge from Emacs 23 on 2012-01-19.
4386
6bee44d6
MA
43872012-02-02 Michael Albinus <michael.albinus@gmx.de>
4388
4389 * dbusbind.c (Fdbus_register_method): Mention the return value
4390 :ignore in the docstring.
4391
44f92739
GM
43922012-02-02 Glenn Morris <rgm@gnu.org>
4393
1b9f60cc
GM
4394 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4395
44f92739
GM
4396 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4397 Unconditionally set to t. (Bug#10673)
4398 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4399 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4400 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4401
c5d3843c
KH
44022012-02-02 Kenichi Handa <handa@m17n.org>
4403
4404 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4405 0, do not call append_composite_glyph.
4406
159462d4 44072012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4408
4409 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4410 NULL (Bug#6988).
4411 (x_produce_glyphs): If the component of a composition is a null
4412 string, set it->pixel_width to 1 to avoid zero-width glyph.
4413
78cef877
EZ
44142012-02-01 Eli Zaretskii <eliz@gnu.org>
4415
4416 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4417 first 2 arguments are identical. This makes inserting large
4418 output from a subprocess an order of magnitude faster on
4419 MS-Windows, where all sbrk'ed memory is always contiguous.
4420
97897668
GM
44212012-01-31 Glenn Morris <rgm@gnu.org>
4422
4423 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4424 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4425 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4426
31fd3586
GM
44272012-01-29 Glenn Morris <rgm@gnu.org>
4428
4429 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4430
0e24a8b2
CY
44312012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4432
4433 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4434
cc0adcb0
CY
44352012-01-28 Chong Yidong <cyd@gnu.org>
4436
4437 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4438
acc28cb9
CY
44392012-01-26 Chong Yidong <cyd@gnu.org>
4440
9c69cfb7
CY
4441 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4442
acc28cb9
CY
4443 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4444 repeat counts (Bug#10507).
4445
48da7392
GM
44462012-01-26 Glenn Morris <rgm@gnu.org>
4447
4448 * lread.c (syms_of_lread): Doc fix.
4449
14af5f7f
CY
44502012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4451
4452 * coding.c (encode_designation_at_bol): Change return value to
4453 EMACS_INT.
4454
0b21c100
CY
44552012-01-25 Chong Yidong <cyd@gnu.org>
4456
4457 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4458
3c2907f7
CY
44592012-01-21 Chong Yidong <cyd@gnu.org>
4460
4461 * floatfns.c (Fcopysign): Make the second argument non-optional,
4462 since nil is not allowed anyway.
4463
959ad23f
AS
44642012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4465
4466 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4467 (send_process): Likewise.
4468
34a02f46
MR
44692012-01-19 Martin Rudalics <rudalics@gmx.at>
4470
4471 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4472 (Vwindow_persistent_parameters): Do not use Qstate.
4473 Rewrite doc-strings.
34a02f46 4474
1259009a 44752012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4476
4477 * character.c (char_width): New function.
70d4fdf6
GM
4478 (Fchar_width, c_string_width, lisp_string_width):
4479 Use char_width (Bug#9496).
25ed9e61 4480
6a6ee00d
MR
44812012-01-16 Martin Rudalics <rudalics@gmx.at>
4482
4483 * window.c (Vwindow_persistent_parameters): New variable.
4484 (Fset_window_configuration, save_window_save): Handle persistent
4485 window parameters.
4486
c85efaf7
EZ
44872012-01-14 Eli Zaretskii <eliz@gnu.org>
4488
4489 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4490 thrashing the stack of the thread. (Bug#9087)
4491
5944709e
PE
44922012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4493
4494 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4495
e71f5d99
EZ
44962012-01-11 Eli Zaretskii <eliz@gnu.org>
4497
4498 * xdisp.c (rows_from_pos_range): Handle the case where the
4499 highlight ends on a newline. (Bug#10464)
4500 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4501 he end column for display of highlight that ends on a newline
4502 before a R2L line.
4503
ce316182
GM
45042012-01-11 Glenn Morris <rgm@gnu.org>
4505
4506 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4507 from load-path also when installation-directory is nil. (Bug#10208)
4508
5b43da69
GM
45092012-01-10 Glenn Morris <rgm@gnu.org>
4510
74cc8ff9
GM
4511 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4512
7d8d6e4e
GM
4513 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4514 Update template values to be closer to their typical values these days.
5b43da69 4515
a0db8d43
EZ
45162012-01-09 Eli Zaretskii <eliz@gnu.org>
4517
4518 * xdisp.c (rows_from_pos_range): Accept additional argument
4519 DISP_STRING, and accept any glyph in a row whose object is that
4520 string as eligible for mouse highlight. Fixes mouse highlight of
4521 display strings from overlays. (Bug#10464)
4522
9a0115ab 45232012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4524
b9110d6a 4525 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4526 * fileio.c (auto_saving_dir_umask): New static var.
4527 (Fmake_directory_internal): Use it.
4528 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4529 creating the directory. The old code temporarily assigns
4530 too-generous permissions to the directory.
4531 (do_auto_save_eh): Clear it.
b9110d6a 4532 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4533 that the var is always cleared.
4534
6c1bd3f3
EZ
45352012-01-07 Eli Zaretskii <eliz@gnu.org>
4536
4537 * search.c (scan_buffer): Pass character positions to
4538 know_region_cache, not byte positions. (Bug#6540)
4539
069d2b50
L
45402012-01-07 LynX <_LynX@bk.ru> (tiny change)
4541
4542 * w32.c (sys_rename): Report EXDEV when rename of a directory
4543 fails because the target is on another logical disk. (Bug#10284)
4544
75bf0d33
DB
45452012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4546
4547 * xterm.c (x_embed_request_focus): New function.
4548
4549 * xterm.h: Add prototype.
4550
4551 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4552
1c6e5a32
GM
45532012-01-05 Glenn Morris <rgm@gnu.org>
4554
4555 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4556
651e947e
EZ
45572012-01-01 Eli Zaretskii <eliz@gnu.org>
4558
4559 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4560 Load gnutls_transport_set_lowat only if GnuTLS version is below
4561 2.11.1.
4562 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4563 GnuTLS versions below 2.11.1.
4564
3778cdd8
AL
45652011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4566
4567 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4568 to the doc string advising against its use for altering the way
4569 windows are scrolled.
4570
0e5317f7
KH
45712011-12-28 Kenichi Handa <handa@m17n.org>
4572
4573 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4574 coding-system ASCII compatible only when it does not produce BOM
4575 on encoding (Bug#10383).
4576
93d5ca1f
JD
45772011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4578
4579 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4580 can scroll.
4581 (create_and_show_popup_menu): Always use menu_position_func for
4582 Gtk3 (Bug#10361).
4583
ca22b785
AS
45842011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4585
4586 * callint.c (Fcall_interactively): Don't truncate prompt string.
4587
d048e1e6
EZ
45882011-12-23 Eli Zaretskii <eliz@gnu.org>
4589
4590 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4591 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4592 resumed from there (after widening). (Bug#10360)
d048e1e6 4593
5ccaba1f
JD
45942011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4595
4596 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4597
204ee57f
JD
45982011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4599
b81d40f0
JB
4600 * nsterm.m (x_free_frame_resources):
4601 Release f->output_data.ns->miniimage.
204ee57f
JD
4602 (ns_index_color): Fix indentation. Do not retain
4603 color_table->colors[i].
4604
4605 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4606 before returning.
4607
4608 * nsfns.m (x_set_background_color): Assign return value from
4609 ns_index_color to face-background instead of NSColor*.
4610 (ns_implicitly_set_icon_type): Fix indentation.
4611 Change assignment in for loop to comparison.
4612
4613 * emacs.c (ns_pool): New variable.
4614 (main): Assign ns_pool.
4615 (Fkill_emacs): Call ns_release_autorelease_pool.
4616
4617 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4618 autorelease fdesc, release fdAttrs and tdict.
4619 (ns_get_covering_families): Release charset.
4620 (ns_findfonts): Release NSFontDescriptor created with new.
4621 (ns_uni_to_glyphs): Fix indentation.
4622 (setString): Release attrStr before assigning new value.
4623
c803b2b7
JD
46242011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4625
678f4426
JD
4626 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4627 and NS_IMPL_COCOA.
4628 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4629 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4630
cd394be1 46312011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4632
5fecd5fc
JD
4633 * nsterm.m (ns_term_init): Subscribe for notifications
4634 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4635 to method trackingNotification in EmacsMenu.
4636
4637 * nsmenu.m (trackingMenu): New variable.
3771cb17 4638 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4639 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4640 from Aquamacs (Bug#7030).
678f4426
JD
4641
46422011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4643
c803b2b7
JD
4644 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4645 (symbol_to_nsstring): Fix indentation.
4646 (ns_symbol_to_pb): New function.
cae07000
SM
4647 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4648 (Fns_rotate_cut_buffers_internal): Remove.
4649 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4650 Fns_store_cut_buffer_internal.
4651 (ns_get_foreign_selection, Fx_own_selection_internal)
4652 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4653 (Fns_get_selection_internal, Fns_store_selection_internal):
4654 Use ns_symbol_to_pb and check if return value is nil.
4655 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4656 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4657 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4658 renamed to Sns_store_selection_internal.
4659 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4660 and remove this function.
4661 (ns_handle_selection_clear): Remove, never used.
4662 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4663 here.
4664
e1b01a3a
KB
46652011-12-17 Ken Brown <kbrown@cornell.edu>
4666
4667 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4668 GID is unknown (Bug#10257).
4669
2adb6e85
PE
46702011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4671
4672 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4673 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4674 which caused a build failure on GNU/Linux IA-64. This problem was
4675 introduced by my 2011-10-07 patch.
4676
d1d7b339
JL
46772011-12-15 Juri Linkov <juri@jurta.org>
4678
4679 * image.c (imagemagick_error): New function. (Bug#10112)
4680 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4681 Use `imagemagick_error' where ImageMagick functions return
4682 `MagickFalse'.
4683 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4684 proper order.
4685
100d5755
KH
46862011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4687
4688 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4689 fill background (Bug#8992).
4690
454592a6
MR
46912011-12-13 Martin Rudalics <rudalics@gmx.at>
4692
4693 * window.c (Vwindow_combination_resize)
4694 (Vwindow_combination_limit): Use t instead of non-nil in
4695 doc-strings.
61d4b438
MR
4696 (Vrecenter_redisplay): Add first sentence of doc-string on
4697 separate line.
53524d93 4698 (Frecenter): Fix doc-string typo.
454592a6 4699
3633e3aa
KH
47002011-12-11 Kenichi Handa <handa@m17n.org>
4701
4702 * coding.c (Funencodable_char_position): Pay attention to the
4703 buffer text relocation (Bug#9389).
4704
7b9d523a 47052011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4706
7b9d523a
JD
4707 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4708 gtk_init (Bug#10100).
4709
b73189c6
EZ
47102011-12-10 Eli Zaretskii <eliz@gnu.org>
4711
4712 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4713 IT->string is nil. (Bug#10263)
4714
f7dfe5d6
JD
47152011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4716
83faebb4
JD
4717 * nsterm.h (x_free_frame_resources): Declare.
4718
f7dfe5d6
JD
4719 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4720 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4721
4722 * nsterm.h (ns_get_defaults_value): Declare.
4723
4724 * nsterm.m (ns_default): Call ns_get_defaults_value.
4725
7cd4e72c
EZ
47262011-12-09 Eli Zaretskii <eliz@gnu.org>
4727
4728 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4729 (Bug#10170)
4730
b34d7317
YM
47312011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4732
4733 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4734 that where the value of an _OBJC_* symbol points to is in the .bss
4735 section (Bug#10240).
4736
76470ad1
KH
47372011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4738
4739 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4740 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4741
745fff94
KH
47422011-12-08 Kenichi Handa <handa@m17n.org>
4743
4744 * ftfont.c (get_adstyle_property): Fix previous change
4745 (Bug#10233).
4746
6e44397c
JB
47472011-12-07 Juanma Barranquero <lekktu@gmail.com>
4748
4749 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4750 dirs from the default value of EMACSLOADPATH (bug#10208).
4751
7efa6272
GM
47522011-12-07 Glenn Morris <rgm@gnu.org>
4753
4754 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4755 installation and source directories as well. (Bug#10208)
4756
f6fc4d87
CY
47572011-12-06 Chong Yidong <cyd@gnu.org>
4758
4759 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4760
2bf26180
GM
47612011-12-06 Glenn Morris <rgm@gnu.org>
4762
4763 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4764 as an error, not just -1. (Bug#10217)
4765
3a6ad4f0
CY
47662011-12-05 Chong Yidong <cyd@gnu.org>
4767
4768 * keyboard.c (process_special_events): New function.
4769 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4770
75a3b399
PE
47712011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4772
4773 * coding.c (encode_designation_at_bol): Don't use uninitialized
4774 local variable (Bug#9318).
4775
c3c9e25e
KH
47762011-12-05 Kenichi Handa <handa@m17n.org>
4777
4778 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4779 return Qnil (Bug#8046, Bug#10193).
4780
5eb05ea3
KH
47812011-12-05 Kenichi Handa <handa@m17n.org>
4782
4783 * coding.c (encode_designation_at_bol): New args charbuf_end and
4784 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4785 (coding_set_source): Return how many bytes coding->source was
4786 relocated.
4787 (coding_set_destination): Return how many bytes
4788 coding->destination was relocated.
4789 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4790 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4791
47922011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4793
4794 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4795 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4796 macro (Bug#9318).
4797
47982011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4799
4800 The following changes are to fix Bug#9318.
4801
a79703f5 4802 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4803 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4804 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4805 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4806
7dbda6df
JB
48072011-12-05 Juanma Barranquero <lekktu@gmail.com>
4808
4809 * lisp.h (process_quit_flag): Fix external declaration.
4810
6d5eb5b0
SM
48112011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4812
4813 Don't macro-inline non-performance-critical code.
4814 * eval.c (process_quit_flag): New function.
4815 * lisp.h (QUIT): Use it.
4816
a0c3fad0
JD
48172011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4818
4819 * nsfns.m (get_geometry_from_preferences): New function.
4820 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4821
6c07aac2
AS
48222011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4823
4824 * emacs.c (Qkill_emacs): Define.
4825 (syms_of_emacs): Initialize it.
4826 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4827 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4828 (quit_throw_to_read_char): Add parameter `from_signal'.
4829 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4830 * lisp.h (QUIT): Call Fkill_emacs if requested.
4831
c052ead4
JD
48322011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4833
4834 * widget.c (update_wm_hints): Return if wmshell is null.
4835 (widget_update_wm_size_hints): New function.
4836
4837 * widget.h (widget_update_wm_size_hints): Declare.
4838
4839 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4840 widget_update_wm_size_hints (Bug#10104).
4841
9e49252b
EZ
48422011-12-03 Eli Zaretskii <eliz@gnu.org>
4843
4844 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4845 before a newline, prepare the bidi iterator for consuming the
4846 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4847 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4848
02b16839
JL
48492011-12-02 Juri Linkov <juri@jurta.org>
4850
4851 * search.c (Fword_search_regexp): New Lisp function created from
4852 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4853 (Fword_search_backward, Fword_search_forward)
4854 (Fword_search_backward_lax, Fword_search_forward_lax):
4855 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4856 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4857
0068070e
SM
48582011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4859
4860 * fileio.c (Finsert_file_contents): Move after-change-function call
4861 to before the "handled:" label, since all "goto handled" appear in
4862 cases where the *-change-functions have already been properly called
4863 (bug#10117).
4864
3360a3fc
AS
48652011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4866
4867 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4868 waiting for input. (Bug#10169)
4869
73d6c093
EZ
48702011-11-30 Eli Zaretskii <eliz@gnu.org>
4871
4872 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4873 verifies glyph row's hash code--we have just reallocated the
4874 glyphs, so their contents can be complete garbage. (Bug#10164)
4875
febe6bea
JB
48762011-11-30 Juanma Barranquero <lekktu@gmail.com>
4877
4878 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4879
801a4313
EZ
48802011-11-30 Eli Zaretskii <eliz@gnu.org>
4881
4882 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4883 attributes are tested _before_ calling verify_row_hash, to protect
4884 against GCC re-ordering of the tests. (Bug#10164)
4885
2b56b87e
JD
48862011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4887
4888 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4889
4890 * xterm.c (handle_one_xevent): Only set async_visible and friends
4891 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4892 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4893 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4894
dbf31225
PE
48952011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4896
4897 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4898 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4899 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4900 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4901 All uses changed to use GCPRO1 etc.
4902 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4903 Revert to old implementation (i.e., before 2011-03-11).
4904
1305621b
YM
49052011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4906
4907 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4908 of scroll runs so as to avoid assigning disabled bogus rows and
4909 unnecessary graphics copy operations.
4910
8c9afb46
EZ
49112011-11-27 Eli Zaretskii <eliz@gnu.org>
4912
4913 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4914 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4915 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4916 (malloc, free, realloc, calloc): Redirect to e_* only when
4917 compiling Emacs.
4918
4919 * lisp.h (GCTYPEBITS): Move before first use.
4920 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4921 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4922 this macro definition.
4923
4924 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4925 _MSC_VER.
4926
54e9e3bf
JD
49272011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4928
6d5eb5b0
SM
4929 * gtkutil.c (xg_create_frame_widgets):
4930 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4931 present with Gtk+ 2.0.
4932
83aca1cb
PE
49332011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4934
4935 * fileio.c (Finsert_file_contents): Undo previous change; see
4936 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4937
5b76caa4
PE
49382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4939
4940 Rename locals to avoid shadowing.
4941 * fileio.c (Finsert_file_contents):
4942 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4943 * process.c (wait_reading_process_output):
4944 Rename inner 'proc' to 'p' to avoid shadowing.
4945 Indent for consistency with usual Emacs style.
4946
8c535114
EZ
49472011-11-25 Eli Zaretskii <eliz@gnu.org>
4948
4949 * xdisp.c (redisplay_window): If cursor row is not fully visible
4950 after recentering, and scroll-conservatively is set to a large
4951 number, scroll window by a few more lines to make the cursor fully
4952 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4953 (start_display): Don't move to the next line if the display should
4954 start at a newline that is part of a display vector or an overlay
4955 string. (Bug#10119)
8c535114 4956
fa4fdb5c
JL
49572011-11-24 Juri Linkov <juri@jurta.org>
4958
4959 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4960 after the `MagickPingImage' call. (Bug#10112)
4961
90ec88df
CY
49622011-11-23 Chong Yidong <cyd@gnu.org>
4963
4964 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4965
56e2e794
MR
49662011-11-23 Martin Rudalics <rudalics@gmx.at>
4967
4968 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4969 making another buffer current. (Bug#10114)
4970
b6e64c41
GM
49712011-11-23 Glenn Morris <rgm@gnu.org>
4972
4973 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4974
6b21de18
CY
49752011-11-23 Chong Yidong <cyd@gnu.org>
4976
4977 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4978 using it (Bug#5984).
4979
b12cd789
EZ
49802011-11-22 Eli Zaretskii <eliz@gnu.org>
4981
4982 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4983 and header-lines, as they don't have one computed for them.
4984 (Bug#10098)
4985
4986 * .gdbinit (prow): Make displayed values more self-explaining.
4987 Add row's hash code.
4988
261b6fd4
LMI
49892011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4990
4991 * process.c (wait_reading_process_output): Fix asynchrounous
4992 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4993 (wait_reading_process_output): Add comment and URL.
261b6fd4 4994
e7cfd277
JD
49952011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4996
4997 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4998
a9b9b7f5
CY
49992011-11-21 Chong Yidong <cyd@gnu.org>
5000
5001 * window.c (Fnext_window, Fprevious_window): Doc fix.
5002
b0d15b4f
SM
50032011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5004
5005 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5006
fe7a3057
JB
50072011-11-20 Juanma Barranquero <lekktu@gmail.com>
5008
5009 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5010
d2999b1a
MR
50112011-11-20 Martin Rudalics <rudalics@gmx.at>
5012
5013 * window.c (Fset_window_combination_limit): Rename argument
5014 STATUS to LIMIT.
5015 (Vwindow_combination_limit): Remove "status" from doc-string.
5016
d5ff9cd0
AS
50172011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5018
5019 * m/ibms390.h: Remove.
5020 * m/ibms390x.h: Don't include "ibms390.h".
5021
a5bb9bd3
SM
50222011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5023
5024 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5025 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5026
cd1181db
JB
50272011-11-20 Juanma Barranquero <lekktu@gmail.com>
5028
5029 * casetab.c (Fset_case_table):
5030 * charset.c (Fcharset_after): Fix typos.
5031
615a3b8d 50322011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5033
17e845af
PE
5034 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5035 Otherwise, valgrind does not work on some platforms.
5036 Problem reported by Andreas Schwab in
6a0bf43d
PE
5037 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5038 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5039 is set, removing the need for VIRT_ADDRESS_VARIES.
5040 (PURE_P): Use a more-efficient implementation that needs just one
5041 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5042 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5043 to 4 (xorl, subq, cmpq, setbe).
5044 * alloc.c (pure): Always extern now, since that's the
5045 VIRT_ADDR_VARIES behavior.
5046 (PURE_POINTER_P): Use a single comparison, not two, for
5047 consistency with the new puresize.h.
5048 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5049 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5050 Remove VIRT_ADDR_VARIES no longer needed.
5051
f8fe6f96
EZ
50522011-11-19 Eli Zaretskii <eliz@gnu.org>
5053
5054 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5055 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5056 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5057 behave as if the cursor position were at the window margin.
5058
5059 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5060 and the cursor position is out of bounds, behave as if the cursor
5061 position were at the window margin. (Bug#10075)
5062
df05a53c
CY
50632011-11-18 Chong Yidong <cyd@gnu.org>
5064
5065 * window.c (Fwindow_combination_limit): Make first argument
5066 non-optional, since it is meaningless for live windows like the
5067 selected window.
61ccba97 5068
2071918e
DA
50692011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5070
5071 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5072
b50a28de
SM
50732011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5074
5075 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5076 (graft_intervals_into_buffer): Simplify.
5077
015137db
EZ
50782011-11-18 Eli Zaretskii <eliz@gnu.org>
5079
5080 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5081 hash values of the two rows.
5082 (copy_row_except_pointers): Preserve the used[] arrays and the
5083 hash values of the two rows. (Bug#10035)
68c95424 5084 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5085
5086 * xdisp.c (row_hash): New function, body extracted from
5087 compute_line_metrics.
5088 (compute_line_metrics): Call row_hash, instead of computing the
5089 hash code inline.
5090
5091 * dispnew.c (verify_row_hash): Call row_hash for computing the
5092 hash code of a row, instead of duplicating code from xdisp.c.
5093
5094 * dispextern.h (row_hash): Add prototype.
5095
a2addb04
TH
50962011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5097
5098 * frame.c (delete_frame): Don't delete the terminal when the last
5099 X frame is closed if emacs is built with GTK toolkit.
5100
df85d315
JB
51012011-11-17 Juanma Barranquero <lekktu@gmail.com>
5102
5103 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5104
a0c2d0ae
MR
51052011-11-17 Martin Rudalics <rudalics@gmx.at>
5106
5107 * window.c (Vwindow_splits): Rename to
5108 Vwindow_combination_resize. Suggested by Juri Linkov.
5109 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5110 of Vwindow_splits.
5111
58179cce
JB
51122011-11-16 Juanma Barranquero <lekktu@gmail.com>
5113
7877f373
JB
5114 * nsfns.m (Fns_font_name):
5115 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5116
b6f67890
MR
51172011-11-16 Martin Rudalics <rudalics@gmx.at>
5118
5119 * window.h (window): Rename slot "nest" to "combination_limit".
5120 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5121 (Fset_window_nest): Rename to Fset_window_combination_limit.
5122 (Vwindow_nest): Rename to Vwindow_combination_limit.
5123 (recombine_windows, make_parent_window, make_window)
5124 (Fsplit_window_internal, saved_window)
5125 (Fset_window_configuration, save_window_save): Rename all
5126 occurrences of window_nest to window_combination_limit.
5127
c7015153
JB
51282011-11-15 Juanma Barranquero <lekktu@gmail.com>
5129
5130 * image.c (imagemagick_load_image): Fix typo.
5131
322ad6ec
EZ
51322011-11-14 Eli Zaretskii <eliz@gnu.org>
5133
5134 * xdisp.c (display_line): Move the call to
5135 highlight_trailing_whitespace before the call to
5136 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5137 faces of all the glyphs to compute ROW's hash value.
5138 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5139
f067b8ec
JB
51402011-11-14 Juanma Barranquero <lekktu@gmail.com>
5141
5142 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5143 just return (bug#10044).
5144
1e5b2111
EZ
51452011-11-12 Eli Zaretskii <eliz@gnu.org>
5146
7ef3cbd5
EZ
5147 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5148 with user-defined heap size. Bump the default size of the temacs
5149 heap to 27MB, to avoid memory warning when running temacs.
5150 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5151
1e5b2111
EZ
5152 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5153 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5154 (verify_row_hash) [XASSERTS]: New function.
5155 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5156 that the hash value of glyph rows is correct.
1e5b2111 5157
89d61221
MR
51582011-11-12 Martin Rudalics <rudalics@gmx.at>
5159
5160 * window.h (window): Remove splits slot.
5161 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5162 (Fdelete_other_windows_internal, make_parent_window)
5163 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5164 (Fset_window_configuration, save_window_save): Don't deal with
5165 split status of windows.
5166 (saved_window): Remove splits slot.
5167 (Vwindow_splits): Rewrite doc-string.
5168
97f18cc8
JD
51692011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5170
5171 * xfns.c (unwind_create_frame):
5172 * nsfns.m (unwind_create_frame):
5173 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5174 Vframe_list (Bug#9999).
5175
22a648b4
DA
51762011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5177
0b381c7e 5178 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5179
659afede
KH
51802011-11-11 Kenichi Handa <handa@m17n.org>
5181
5182 * callproc.c (Fcall_process): Set the member dst_multibyte of
5183 process_coding.
5184
9ac0394b
KH
51852011-11-11 Johan Bockgård <bojohan@gnu.org>
5186
5187 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5188 avoid a crash (bug#9496).
5189
2fbdc249
CY
51902011-11-09 Chong Yidong <cyd@gnu.org>
5191
5192 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5193 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5194
ac6b1f81
PE
51952011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5196
5197 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5198
09db192c
PE
51992011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5200
5201 Avoid some portability problems by eschewing 'extern inline' functions.
5202 The trivial performance wins aren't worth the portability hassles; see
5203 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5204 et seq.
5205 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5206 (window_box_width, window_box_left, window_box_left_offset)
5207 (window_box_right, window_box_right_offset): Undo previous change,
5208 by removing the "extern"s.
5209 * intervals.c (adjust_intervals_for_insertion)
5210 (adjust_intervals_for_deletion): Undo previous change,
5211 making these static again.
5212 (offset_intervals, temp_set_point_both, temp_set_point)
5213 (copy_intervals_to_string): No longer inline.
5214 * xdisp.c (window_text_bottom_y, window_box_width)
5215 (window_box_height, window_box_left_offset)
5216 (window_box_right_offset, window_box_left, window_box_right)
5217 (window_box): No longer inline.
5218
105216ed
CY
52192011-11-08 Chong Yidong <cyd@gnu.org>
5220
5221 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5222 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5223 Signal an error if not a live window.
105216ed
CY
5224 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5225 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5226
ae9e237f
JB
52272011-11-07 Juanma Barranquero <lekktu@gmail.com>
5228
5229 * lisp.h (syms_of_abbrev): Remove declaration.
5230 Reported by CHENG Gao <chenggao@royau.me>.
5231
c7aa8333
EZ
52322011-11-07 Eli Zaretskii <eliz@gnu.org>
5233
5234 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5235 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5236 of temacs in GUI mode.
5237
be7f5545
MR
52382011-11-07 Martin Rudalics <rudalics@gmx.at>
5239
5240 * window.h: Declare delete_all_child_windows instead of
5241 delete_all_subwindows.
5242 * window.c (Fwindow_nest, Fset_window_nest)
5243 (Fset_window_new_total, Fset_window_new_normal)
5244 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5245 (delete_all_subwindows): Rename to delete_all_child_windows.
5246 (Fdelete_other_windows_internal, Fset_window_configuration):
5247 Call delete_all_child_windows instead of delete_all_subwindows.
5248 * frame.c (delete_frame): Call delete_all_child_windows instead
5249 of delete_all_subwindows.
5250
ca78dc43
PE
52512011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5252
5253 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5254 This is also needed for porting to any host where GC_MARK_STACK is
5255 not GC_MAKE_GCPROS_NOOPS.
5256 (which_symbols): Use it.
5257
a0241d01
KH
52582011-11-07 Kenichi Handa <handa@m17n.org>
5259
5260 * coding.c (coding_set_destination): Check coding->src_pos only
5261 when coding->src_object is a buffer (bug#9910).
5262
5263 * process.c (send_process): Set the member src_multibyte of coding
5264 to 0 (bug#9911) when sending a unibyte text.
5265
5266 * callproc.c (Fcall_process): Set the member src_multibyte of
5267 process_coding to 0 (bug#9912).
5268
a64bfdfa 52692011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5270
5271 * xmenu.c (cleanup_widget_value_tree): New function.
5272 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5273 calling free_menubar_widget_value_tree directly (Bug#9830).
5274
cb41b32a
PE
52752011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5276
5277 Fix some portability problems with 'inline'.
5278 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5279 (window_box_width, window_box_left, window_box_left_offset)
5280 (window_box_right, window_box_right_offset): Declare extern.
5281 Otherwise, these inline functions do not conform to C99 and
5282 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5283 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5284 * intervals.c (adjust_intervals_for_insertion)
5285 (adjust_intervals_for_deletion): Now extern, because otherwise the
5286 extern inline functions 'offset_intervals' couldn't refer to it.
5287 (static_offset_intervals): Remove.
5288 (offset_intervals): Rewrite using the old contents of
5289 static_offset_intervals. The old version didn't conform to C99
5290 because an extern inline function contained a reference to an
5291 identifier with static linkage.
5292
b7041366
AS
52932011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5294
5295 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5296 GC.
5297
88a37c4d
EZ
52982011-11-06 Eli Zaretskii <eliz@gnu.org>
5299
5300 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5301 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5302 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5303 return Qleft_to_right.
5304
49745b39
CY
53052011-11-06 Chong Yidong <cyd@gnu.org>
5306
5307 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5308 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5309 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5310 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5311 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5312 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5313 (Fwindow_vscroll): Doc fix.
5314 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5315 argument, since it makes no sense to pass a live window and for
5316 consistency with window-child.
5317
1f05cd82
CS
53182011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5319
5320 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5321 support MSVC.
5322
22610910
JR
53232011-11-05 Jason Rumney <jasonr@gnu.org>
5324
5325 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5326 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5327 fonts (Bug#6029).
5328 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5329 bitwise arithmetic preventing use of unicode-sip and non-truetype
5330 opentype fonts.
5331
a06776b2
EZ
53322011-11-05 Eli Zaretskii <eliz@gnu.org>
5333
3ad924ba
EZ
5334 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5335 "emacs"-only part.
5336
a06776b2
EZ
5337 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5338 initialization code to keep similarity to xfns.c after changes
5339 from 2011-11-05.
5340
c9e7db78
JD
53412011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5342
a97f8f3f
JD
5343 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5344 (unwind_create_frame): New function (Bug#9943).
5345 (Fx_create_frame): Restructure code to be more similar to the one in
5346 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5347 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5348 Move terminal->reference_count++ just before making the frame official
5349 (Bug#9943).
5350
5351 * nsterm.m (x_free_frame_resources): New function.
5352 (x_destroy_window): Move code to x_free_frame_resources.
5353
c9e7db78 5354 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5355 (Fx_create_frame, x_create_tip_frame):
5356 Move terminal->reference_count++ just before making the frame
75f1671a 5357 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5358 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5359
a6fc3b5c
EZ
53602011-11-05 Eli Zaretskii <eliz@gnu.org>
5361
5362 Support MSVC build with newer versions of Visual Studio.
5363 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5364 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5365 nt/gmake.defs.
5366
5367 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5368 which are not supported by MSVC.
5369 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5370 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5371 bitfields.
5372 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5373 types in bitfields.
5374 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5375
5376 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5377
58179cce 53782011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5379
5380 Support MSVC build with newer versions of Visual Studio.
5381 * w32.c: Don't include w32api.h for MSVC.
5382 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5383
5384 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5385 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5386 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5387 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5388 e_* cousins.
5389 (alloca) [_MSC_VER]: Define to _alloca.
5390
5391 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5392
5393 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5394
a58c13ed
EZ
53952011-11-04 Eli Zaretskii <eliz@gnu.org>
5396
5397 * xdisp.c (note_mouse_highlight): If either of
5398 previous/next-single-property-change returns nil, treat that as
5399 the beginning or the end of the buffer. (Bug#9955)
5400
fe0b6370
JD
54012011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5402
a58c13ed 5403 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5404 label is not null (Bug#9951).
5405 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5406 may be NULL.
5407
89bd5ee1
EZ
54082011-11-04 Eli Zaretskii <eliz@gnu.org>
5409
5410 * window.c (Fwindow_body_size): Mention in the doc string that the
5411 return value is in frame's canonical units. (Bug#9949)
5412
84c3edb9
EZ
54132011-11-03 Eli Zaretskii <eliz@gnu.org>
5414
4e2fb5c7
EZ
5415 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5416
84c3edb9 5417 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5418 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5419 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5420
bc17a887
EZ
54212011-11-01 Eli Zaretskii <eliz@gnu.org>
5422
5423 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5424 Don't stop backward scan on the continuation glyph, even though
5425 its CHARPOS is positive.
6d5eb5b0
SM
5426 (mouse_face_from_buffer_pos, note_mouse_highlight):
5427 Rename cover_string to disp_string.
bc17a887 5428
4ee88440
MR
54292011-11-01 Martin Rudalics <rudalics@gmx.at>
5430
5431 * window.c (temp_output_buffer_show): Don't use
5432 Vtemp_buffer_show_specifiers.
5433 (Vtemp_buffer_show_specifiers): Remove unused variable.
5434
c2ff3c02
EZ
54352011-10-30 Eli Zaretskii <eliz@gnu.org>
5436
5437 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5438 past the beginning of the current glyph matrix.
5439
58179cce 54402011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5441
5442 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5443 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5444 HAVE_GTK3 (Bug#9869).
b77a6a7f 5445
3b574623
JD
5446 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5447 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5448
b77a6a7f
JD
5449 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5450
5451 * xterm.c: Declare x_handle_net_wm_state to return int.
5452 (handle_one_xevent): Check if we are iconified but don't have
5453 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5454 (get_current_wm_state): Return non-zero if not hidden,
5455 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5456 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5457 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5458 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5459
196e41e4
PE
54602011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5461
5462 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5463 so that this new function doesn't get optimized away by a
5464 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5465
021f2e1a
AS
54662011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5467
5468 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5469
8b058d44
EZ
54702011-10-29 Eli Zaretskii <eliz@gnu.org>
5471
5472 Fix the `xbytecode' command.
5473 * .gdbinit (xprintbytestr): New command.
b50a28de 5474 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5475 (xbytecode): Print the byte-code string as well.
5476
4452fb80
EZ
54772011-10-29 Kim Storm <storm@cua.dk>
5478
8b058d44
EZ
5479 * alloc.c (which_symbols): New function.
5480
21b72067
AS
54812011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5482
5483 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5484 line. (Bug#9903)
5485
83ed7b5c
GM
54862011-10-29 Glenn Morris <rgm@gnu.org>
5487
5488 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5489 Not clear what it was for, and it causes various bugs. (Bug#9839)
5490
5a7a728b
EZ
54912011-10-28 Eli Zaretskii <eliz@gnu.org>
5492
5493 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5494 possible random value that matches one of those tested as
5495 condition to clear the mouse face.
5496
d3d0842f
CY
54972011-10-28 Chong Yidong <cyd@gnu.org>
5498
5499 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5500
31b39d13
DN
55012011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5502
5503 * window.c (make_window): Initialize phys_cursor_on_p.
5504
9aba6043
SM
55052011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5506
5507 * lisp.h (struct Lisp_Symbol): Update comments.
5508
c20992f4
JB
55092011-10-28 Juanma Barranquero <lekktu@gmail.com>
5510
5511 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5512
db4f02f2
EZ
55132011-10-28 Eli Zaretskii <eliz@gnu.org>
5514
5515 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5516 <oslsachem@gmail.com> for helping to debug this.
5517
5518 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5519 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5520 (g_b_init_get_glyph_outline_w): New static variables.
5521 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5522 (GetGlyphOutlineW_Proc): New typedefs.
5523 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5524 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5525 New functions.
5526 (w32font_open_internal, compute_metrics):
5527 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5528 instead of calling the "wide" APIs directly.
5529
5530 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5531
5532 * w32.h (syms_of_w32font): Add prototype.
5533
87e68db4
JB
55342011-10-27 Juanma Barranquero <lekktu@gmail.com>
5535
5536 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5537 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5538 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5539 (Fmove_to_window_line): Doc fix.
5540
435c1d67
CY
55412011-10-27 Chong Yidong <cyd@gnu.org>
5542
5543 * process.c (make_process): Set gnutls_state to NULL.
5544
5545 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5546 non-NULL, regardless of GNUTLS_INITSTAGE.
5547 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5548 an error. Set process slots as soon as we allocate them.
5549
5550 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5551
9c6c6f49
CY
55522011-10-27 Chong Yidong <cyd@gnu.org>
5553
9aba6043
SM
5554 * gnutls.c (emacs_gnutls_deinit): New function.
5555 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5556 (Fgnutls_deinit, Fgnutls_boot): Use it.
5557
5558 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5559 (deactivate_process): Call emacs_gnutls_deinit.
5560
657d08d3
JB
55612011-10-27 Juanma Barranquero <lekktu@gmail.com>
5562
5563 * image.c (x_create_x_image_and_pixmap):
5564 * w32.c (sys_rename, w32_delayed_load):
5565 * w32font.c (fill_in_logfont):
5566 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5567
5430d399
JB
55682011-10-26 Juanma Barranquero <lekktu@gmail.com>
5569
5570 * w32fns.c (w32_default_color_map): New function,
5571 extracted from Fw32_default_color_map.
a7ef684b 5572 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5573
fe0055fa
PE
55742011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5575
5576 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5577
e6346438
SM
55782011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5579
5580 * keyboard.c (test_undefined): New function (bug#9751).
5581 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5582
e112cc37
ET
55832011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5584
5585 * sysdep.c (init_sys_modes): Fix the check for the controlling
5586 terminal (Bug#6649).
5587
7b5d6677
EZ
55882011-10-20 Eli Zaretskii <eliz@gnu.org>
5589
5590 * dispextern.h (struct bidi_it): New member next_en_type.
5591
5592 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5593 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5594 current character, check also for next_en_type being WEAK_EN.
5595 (bidi_resolve_weak): Don't enter the expensive loop if the current
5596 position is before next_en_pos. Record the bidi type of the first
5597 non-ET, non-BN character we find, in addition to its position.
5598 (bidi_level_of_next_char): Invalidate next_en_type when
5599 next_en_pos is over-stepped.
5600
7da0b018
PE
56012011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5602
5603 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5604 * editfns.c: Rewrite current-time-zone so that it invokes
5605 the equivalent of (format-time-string "%Z") to get the time zone name.
5606 This fixes a bug when the time zone name contains characters that
5607 need converting from the system time locale to Emacs internal format.
5608 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5609 that patch fixed format-time-string to do the conversion, but
5610 I forgot to fix current-time-zone.
5611 (format_time_string): New function, containing most of
5612 what Fformat_time_string used to contain.
5613 (Fformat_time_string): Rewrite in terms of format_time_string.
5614 This doesn't change this function's behavior.
5615 (current-time-zone): Rewrite to use format_time_string.
5616 This fixes the bug reported by Michael Schierl in
5617 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5618 Jason Rumney's 2007-06-07 change worked around this bug, but
5619 didn't fix it.
5620 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5621
8547b010
EZ
56222011-10-19 Eli Zaretskii <eliz@gnu.org>
5623
5624 * xdisp.c (start_display): If the character at POS is displayed
5625 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5626 (try_window_reusing_current_matrix): If a line ends in a display
5627 vector or the next line starts in a display vector, continue
5628 redrawing the window even though the character position of
5629 start_row was reached.
8547b010
EZ
5630 (Bug#9771, part 2)
5631
4e948d15
CY
56322011-10-18 Chong Yidong <cyd@gnu.org>
5633
5634 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5635 with nobreak-char-display too.
5636
4787455f
EZ
56372011-10-18 Eli Zaretskii <eliz@gnu.org>
5638
5639 Fix part 3 of bug#9771.
5640 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5641 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5642 non-neutral characters if the current character is a paragraph
5643 separator (a.k.a. Newline). This avoids running the same
5644 expensive loop twice, once when we consume the preceding newline
5645 and the other time when the line actually needs to be displayed.
5646 Avoid the loop when we see neutrals on the base embedding level
5647 following a character whose directionality is the same as the
5648 paragraph's. This avoids running the expensive loop when a line
5649 ends in a long sequence of neutrals, like control characters.
5650 Add assertion against STRONG_AL type. Slightly rearrange code
5651 that determines the type of a neutral given the first non-neutral
5652 that follows it.
5653 (bidi_level_of_next_char): Set next_en_pos to zero when
5654 invalidating its info.
5655
2c91f553
EZ
56562011-10-17 Eli Zaretskii <eliz@gnu.org>
5657
5658 * xdisp.c (push_display_prop): Determine whether to record string
5659 or buffer position by IT->string, not by IT->method. Allow
5660 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5661 (move_it_vertically_backward): Don't look for character position
5662 immediately after the newline when in a continuation line.
5663 (Bug#9771, part 1)
2c91f553 5664
c7b08b0d
MR
56652011-10-15 Martin Rudalics <rudalics@gmx.at>
5666
5667 * window.c (coordinates_in_window): Rewrite and delabelize
5668 vertical border check. (Bug#5357) (Bug#9618)
5669
6b02f655
SM
56702011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5671
5672 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5673 errors in XSetWindowBorder (bug#9310).
5674
81d40c92
DA
56752011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5676
5677 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5678 avoid crash when xmalloc overrun checking is enabled.
5679
d4172c3b
EZ
56802011-10-13 Eli Zaretskii <eliz@gnu.org>
5681
5682 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5683 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5684 cursor motion with <left> and <right> arrow keys.
5685
5686 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5687 some callers set that themselves.
5688
b00eea75
EZ
56892011-10-12 Eli Zaretskii <eliz@gnu.org>
5690
5691 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5692 display string and the previous row comes from the same string and
5693 is empty. (Bug#9739) (Bug#9738)
5694
8fe012c4
SM
56952011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5696
5697 * doc.c (get_doc_string): Encode file name (bug#9735).
5698
0074aef2
EZ
56992011-10-12 Eli Zaretskii <eliz@gnu.org>
5700
79beb178
EZ
5701 * bidi.c (bidi_level_of_next_char):
5702 * xdisp.c (get_visually_first_element): Remove old incorrect
5703 comments regarding the Unicode Line Separator character.
5704
0074aef2
EZ
5705 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5706
6e4b3fbe
DA
57072011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5708
5709 * alloc.c (Fgc_status): Do not access beyond zombies array
5710 boundary if nzombies > MAX_ZOMBIES.
5711 * alloc.c (dump_zombies): Add missing format specifier.
5712
0324f3af
PE
57132011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5714
b5525cac
PE
5715 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5716 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5717
0324f3af
PE
5718 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5719 Some packages use them to denote characters with modifiers.
5720
e9b5f888
AS
57212011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5722
5723 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5724 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5725 matching a pp-number. Rename parameter var to var1.
5726
127827c0
SM
57272011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5728
5729 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5730
c8fd3bd0
GM
57312011-10-08 Glenn Morris <rgm@gnu.org>
5732
5733 * callint.c (Fcall_interactively): Give a more explicit error for the
5734 'c' case with a non-character input. (Bug#8479)
5735
352ec8ff
EZ
57362011-10-08 Eli Zaretskii <eliz@gnu.org>
5737
03669ccb
EZ
5738 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5739 lines.
7061c986
EZ
5740 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5741 lines that are hscrolled on the left.
03669ccb 5742
352ec8ff
EZ
5743 * dispnew.c (buffer_posn_from_coords): Account for a possible
5744 presence of header-line. (Bug#4426)
5745
a66cfb1c
SM
57462011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5747
6b02f655
SM
5748 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5749 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5750
7c5ee88e
PE
57512011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5752
5753 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5754 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5755 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5756 this makes Emacs dump core during garbage collection on rare
5757 occasions. sizeof is obviously inferior to offsetof here, so
5758 stick with offsetof.
5759 (GC_POINTER_ALIGNMENT): New macro.
5760 (mark_memory): Omit 3rd (offset) arg; caller changed.
5761 Don't assume EMACS_INT alignment is the same as pointer alignment.
5762
df1bbe5b
SM
57632011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5764
5765 * keyboard.c (read_key_sequence_remapped): New var.
5766 (read_key_sequence): Compute remapping in the right buffer.
5767 (command_loop_1): Use read_key_sequence's remapping directly.
5768
51553db6
SM
57692011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5770
32c1fffd
SM
5771 * dired.c (file_name_completion): Don't expand file name.
5772 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5773 before checking file name handler.
5774
51553db6
SM
5775 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5776 they've been requested explicitly (bug#9591).
5777
b6bd1599 57782011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5779
5780 * keymap.c (Fsingle_key_description): Use make_specified_string
5781 instead of build_string to build string from push_key_description.
5782 (Bug#5193)
5783
f701dc2a
PE
57842011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5785
4222c55d
PE
5786 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5787 This fixes a Y2038 bug on 64-bit hosts.
5788 * buffer.c (reset_buffer):
5789 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5790 (Fclear_buffer_auto_save_failure):
5791 Use 0, not -1, to represent an unset failure time, since time_t
5792 might not be signed.
5793
f701dc2a
PE
5794 Remove dependency on glibc malloc internals.
5795 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5796 Move back here from lisp.h, but with their new implementations.
5797 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5798 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5799 * charset.c (charset_table_init): New static var.
5800 (syms_of_charset): Use it instead of xmalloc. This removes a
5801 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5802 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5803 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5804 Move back to alloc.c.
5805 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5806 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5807
9ceebf39
JD
58082011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5809
5810 * nsterm.m (windowDidResize): Call x_set_window_size only when
5811 ns_in_resize is true. Otherwise set pixelwidth/height and
5812 call change_frame_size (Bug#9628).
5813
cb993c58
PE
58142011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5815
3930c88b
PE
5816 Port --enable-checking=all to Fedora 14 x86-64.
5817 * charset.c (syms_of_charset): Also account for glibc malloc's
5818 internal overhead when calculating the initial malloc maximum.
5819
cb993c58
PE
5820 Port --enable-checking=all to Fedora 14 x86.
5821 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5822 Move to lisp.h.
5823 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5824 (overrun_check_realloc, overrun_check_free):
5825 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5826 That way, xmalloc returns a properly-aligned pointer even if
5827 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5828 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5829 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5830 into account when calculating the initial malloc maximum.
5831 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5832 Move here from alloc.c, so that charset.c can use it too.
5833 Properly align; the old code wasn't right for common 32-bit hosts
5834 when configured with --enable-checking=all.
5835 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5836 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5837
31bed486
EZ
58382011-09-29 Eli Zaretskii <eliz@gnu.org>
5839
04c70788 5840 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5841 use EDOM.
5842
fbcaa2f3
EZ
58432011-09-28 Eli Zaretskii <eliz@gnu.org>
5844
5845 * xdisp.c (compute_display_string_end): If there's no display
5846 string at CHARPOS, return -1.
5847
5848 * bidi.c (bidi_fetch_char): When compute_display_string_end
5849 returns a negative value, treat the character as a normal
5850 character not covered by a display string. (Bug#9624)
5851
a239d4e9
JB
58522011-09-28 Juanma Barranquero <lekktu@gmail.com>
5853
5854 * lread.c (Fread_from_string): Fix typo in docstring.
5855
88652fd5
EZ
58562011-09-27 Eli Zaretskii <eliz@gnu.org>
5857
5858 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5859 newline, reseat the iterator instead of bidi-iterating there one
5860 character at a time. (Bug#9610)
32c1fffd
SM
5861 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5862 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5863
ed497dd4
AS
58642011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5865
5866 * lread.c (readevalloop): Use correct code for NBSP.
5867 (read1): Likewise. (Bug#9608)
5868
b2bf61aa
MA
58692011-09-25 Michael Albinus <michael.albinus@gmx.de>
5870
5871 * dbusbind.c (Fdbus_register_signal): When service is not
5872 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5873
32bbb17c
GM
58742011-09-25 Glenn Morris <rgm@gnu.org>
5875
5876 * buffer.c (truncate-lines): Doc fix.
5877
94e0933e
CY
58782011-09-24 Chong Yidong <cyd@stupidchicken.com>
5879
5880 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5881 (Fset_window_next_buffers): Doc fix.
5882
cddde921
GM
58832011-09-24 Glenn Morris <rgm@gnu.org>
5884
5885 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5886
1260aef1
PE
58872011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5888
25b4bfa0
PE
5889 Fix minor problems found by static checking.
5890 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5891 * indent.c (Fvertical_motion): Fix == vs = typo.
5892
e3cbd34b
EZ
58932011-09-24 Eli Zaretskii <eliz@gnu.org>
5894
a66cfb1c
SM
5895 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5896 Default value is now t. Doc fix.
6bf7006f 5897
e3cbd34b 5898 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5899 logic when moving up, not only when moving down. Fix the
e3cbd34b 5900 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5901 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5902
5903 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5904 CHARPOS is covered by a display string which includes newlines.
5905 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5906 is covered by a display string with embedded newlines.
5907
a3de0cbd
MA
59082011-09-24 Michael Albinus <michael.albinus@gmx.de>
5909
5910 * dbusbind.c (Fdbus_register_signal): Add match rule to
5911 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5912 (Fdbus_register_method, Vdbus_registered_objects_table):
5913 Fix docstring.
a3de0cbd 5914
b260039d
JM
59152011-09-24 Jim Meyering <meyering@redhat.com>
5916
32c1fffd 5917 do not ignore write error for any output size
b260039d
JM
5918 The previous change was incomplete.
5919 While it makes emacs --batch detect the vast majority of stdout
5920 write failures, errors were still ignored whenever the output size is
5921 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5922 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5923 && echo FAIL: ignored write error
5924 FAIL: ignored write error
5925 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5926 && echo FAIL: ignored write error
5927 FAIL: ignored write error
5928 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5929
8eca8a7c
AS
59302011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5931
5932 * emacs.c (Fkill_emacs): In noninteractive mode exit
5933 non-successfully if a write error occurred on stdout. (Bug#9574)
5934
3341db62
EZ
59352011-09-21 Eli Zaretskii <eliz@gnu.org>
5936
5937 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5938 the xassert test.
5939
5940 * dispextern.h (struct it): Update the comment documenting what
5941 can it->OBJECT be.
5942
8c203dbf
EZ
59432011-09-20 Eli Zaretskii <eliz@gnu.org>
5944
5945 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5946 a display string, extend search for cursor position to end of row.
5947 (find_row_edges): If the row ends in a newline from a display
5948 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5949 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5950 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5951 non-empty line. Fixes confusing cursor motion with arrow keys at
5952 the beginning of a line that starts with whitespace.
8c203dbf 5953
a4824228
LMI
59542011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5955
5956 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5957 (bug#9493).
5958
33ed493b
CY
59592011-09-18 Chong Yidong <cyd@stupidchicken.com>
5960
5961 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5962 boolean (Bug#9154).
5963
56cd55c8
EZ
59642011-09-18 Eli Zaretskii <eliz@gnu.org>
5965
5966 * xdisp.c (display_line): Record maximum and minimum buffer
5967 positions even if no glyphs were produced (e.g., by a zero-width
5968 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5969 buffer positions that will be removed from the glyph row because
5970 they don't fit.
c02dcedf
EZ
5971 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5972 column is beyond frame width: don't subtract 1 "pixel" when
5973 computing width of the stretch.
3e62b7e0
EZ
5974 (reseat_at_next_visible_line_start): Undo the change made on
5975 2011-09-17 that saved paragraph information and restored it after
5976 the call to `reseat'. (Bug#9545)
56cd55c8 5977
5ed99d36 59782011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5979
5980 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5981 and turn window cursor on if cleared (Bug#9415).
5982
5ed99d36 59832011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5984
5985 * search.c (boyer_moore): Take unibyte characters from pattern
5986 literally. (Bug#9458)
5987
9bade7b2
EZ
59882011-09-18 Eli Zaretskii <eliz@gnu.org>
5989
5990 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5991
e5e9d610
PE
59922011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5993
87e4427a
PE
5994 Fix minor problem found by static checking.
5995 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5996 initialized, to pacify gcc -Wuninitialized.
5997
e5e9d610
PE
5998 * fileio.c: Report proper errno when syscall falls.
5999 (Finsert_file_contents): Save and restore errno,
6000 so that report_file_error outputs the correct diagnostic.
6001 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6002
a1674f0b
EZ
60032011-09-18 Eli Zaretskii <eliz@gnu.org>
6004
6005 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6006
fbfb6dd4
EZ
60072011-09-17 Eli Zaretskii <eliz@gnu.org>
6008
6009 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6010 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6011
bb187662
EZ
60122011-09-17 Eli Zaretskii <eliz@gnu.org>
6013
1137e8b8 6014 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6015 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6016
6017 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6018 (bidi_find_paragraph_start): Search back for paragraph beginning
6019 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6020 (bidi_move_to_visually_next): Only trigger paragraph-related
6021 computations when the last character is a newline or at EOB, not
6022 just any NEUTRAL_B. (Bug#9470)
6023
bb187662
EZ
6024 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6025 truncated lines if point is covered by a display string. (Bug#9524)
6026
2e621251
PE
60272011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6030 (cons_to_x_long): New function.
6031 (lisp_data_to_selection_data): Use it. Correct the test for
6032 short-versus-long data; it was negated. Break out of vector
6033 loop, for efficiency, when a long datum is discovered.
6034
91a15bc6
SM
60352011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6036
6037 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6038
b41c3a35
EZ
60392011-09-16 Eli Zaretskii <eliz@gnu.org>
6040
6041 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6042 GCC PR/17406) by declaring this function with external scope.
6043
7812ba2d
PE
60442011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6045
6046 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6047 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6048
cf7edc2a
AS
60492011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6050
6051 * editfns.c (Fformat): Correctly handle text properties on "%%".
6052
bd01620e
EZ
60532011-09-15 Eli Zaretskii <eliz@gnu.org>
6054
6055 * xterm.c (x_draw_composite_glyph_string_foreground):
6056 * w32term.c (x_draw_composite_glyph_string_foreground):
6057 * term.c (encode_terminal_code):
6058 * composite.c (composition_update_it, get_composition_id):
6059 * xdisp.c (get_next_display_element)
6060 (fill_composite_glyph_string): Add comments about special meaning
6061 of TAB characters in a composition.
6062
a02719a3
PE
60632011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6066 This occurs when processing a multibyte format.
6067 Problem reported by Wolfgang Jenker.
a02719a3 6068
72589a3c
JB
60692011-09-15 Johan Bockgård <bojohan@gnu.org>
6070
6071 * xdisp.c (try_cursor_movement): Only check for exact match if
6072 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6073
1c14176c
PE
60742011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6075
6076 Remove unused external symbols.
6077 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6078 * xdisp.c (calc_pixel_width_or_height): Now static.
6079 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6080 * indent.c (check_display_width):
6081 * w32term.c: Fix comment to match code.
6082 * xterm.c, xterm.h (x_catching_errors): Remove.
6083
d2eea5b5
PE
60842011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6085
6086 * xselect.c: Use signed conversions more consistently (Bug#9498).
6087 (selection_data_to_lisp_data): Assume incoming selection data are
6088 signed integers, not unsigned. This is to be consistent with
6089 outgoing selection data, which was modified to use signed integers
6090 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6091 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6092 expects long, not unsigned long.
6093
46888499
EZ
60942011-09-14 Eli Zaretskii <eliz@gnu.org>
6095
6096 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6097 computation of loop end. Reported by Johan Bockgård
6098 <bojohan@gnu.org>.
6099
ef8ef9fb
CY
61002011-09-13 Chong Yidong <cyd@stupidchicken.com>
6101
6102 * frame.c (Fother_visible_frames_p): Function deleted.
6103
fa819fed
EZ
61042011-09-12 Eli Zaretskii <eliz@gnu.org>
6105
6106 * indent.c (compute_motion): Process display vector front to back
6107 rather than the other way around. (Bug#2496)
6108
2ba8e008
SM
61092011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6110
6111 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6112
20f53c69
CY
61132011-09-11 Chong Yidong <cyd@stupidchicken.com>
6114
6115 * minibuf.c (Fread_from_minibuffer): Doc fix.
6116
d562d7a4
EZ
61172011-09-11 Eli Zaretskii <eliz@gnu.org>
6118
6119 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6120 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6121
1c4d7f3d
LMI
61222011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6123
6124 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6125 value for non-existent files.
6126
b885bf36
EZ
61272011-09-11 Eli Zaretskii <eliz@gnu.org>
6128
6129 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6130 set its "size" to -1. This will set the modtime_size field of
6131 the corresponding buffer to -1, which is what
6132 verify-visited-file-modtime expects for files that do not exist.
6133 (Bug#9139)
6134
6612f0bf
PE
61352011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6136
6137 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6138 here ...
6139 * lisp.h: ... from here. push_key_description is no longer
6140 defined in keyboard.c, so its declaration should not be in
6141 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6142 logically belongs with push_key_description.
6143
dfb3f755
PE
61442011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6145
6146 * buffer.h: Include <sys/types.h> instead of <time.h>.
6147 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6148 Problem reported by Herbert J. Skuhra.
6149
3134906c
LMI
61502011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6151
6152 * xml.c (parse_region): Make the parsing work for
6153 non-comment-starting XML files again (bug#9144).
6154
8d903f4e
AS
61552011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6156
6157 * image.c (gif_load): Fix calculation of bottom and right corner.
6158 (Bug#9468)
6159
80ad64f4
EZ
61602011-09-10 Eli Zaretskii <eliz@gnu.org>
6161
6162 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6163 redisplay in small windows.
6164
208a048d
EZ
61652011-09-09 Eli Zaretskii <eliz@gnu.org>
6166
6167 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6168
9b1c252e
MR
61692011-09-08 Martin Rudalics <rudalics@gmx.at>
6170
6171 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6172 Operate on live windows only.
6173
2949f33b
JB
61742011-09-08 Juanma Barranquero <lekktu@gmail.com>
6175
6176 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6177
e08dcafd
EZ
61782011-09-07 Eli Zaretskii <eliz@gnu.org>
6179
6180 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6181 only under bidi iteration.
6182
115b96bd
JD
61832011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6184
6185 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6186
c8199d0f
PE
61872011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6188
6189 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6190 Without this fix, the command to link temacs failed due to an
6191 undefined symbol __builtin_isnan. This is because
6192 /usr/include/iso/math_c99.h #defines isnan(x) to
6193 __builtin_isnan(x), but the bundled gcc, which identifies itself
6194 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6195 a __builtin_isnan.
6196 * floatfns.c (isnan): #undef, and then #define to a clone of
6197 what's in data.c.
6198 (Fisnan): Always define, since it's always available now.
6199 (syms_of_floatfns): Always define isnan at the Lisp level.
6200
e39b275c 62012011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6202
6203 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6204
b2db44d9 62052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6206
f4af5137 6207 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6208 The previous code assumed that file offsets (off_t values) fit in
6209 EMACS_INT variables, which is not true on typical 32-bit hosts.
6210 The code messed up by falsely reporting buffer overflow in cases
6211 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6212 when "big" contains more than 2**29 bytes, even though this
6213 inserts just one byte and does not overflow the buffer.
6214 (Finsert_file_contents): Store file offsets as off_t
6215 values, not as EMACS_INT values. Check for overflow when
6216 converting between EMACS_INT and off_t. When checking for
6217 buffer overflow or for overlap, take the offsets into account.
6218 Don't use EMACS_INT for small values where int suffices.
6219 When checking for overlap, fix a typo: ZV was used where
6220 ZV_BYTE was intended.
6221 (Fwrite_region): Don't assume off_t fits into 'long'.
6222 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6223
ecfc0a49
MA
62242011-09-05 Michael Albinus <michael.albinus@gmx.de>
6225
6226 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6227
6511acf2 62282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6229
0999621a 6230 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6231
6232 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6233 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6234 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6235 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6236 (modify_event_symbol): Do not assume that the length of
6237 name_alist_or_stem is safe to alloca and fits in int.
6238 (Fexecute_extended_command): Likewise for function name and binding.
6239 (Frecursion_depth): Wrap around reliably on integer overflow.
6240 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6241 since some callers pass EMACS_INT values.
6242 (Fsingle_key_description): Don't crash if symbol name contains more
6243 than MAX_ALLOCA bytes.
6244 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6245 (get_minibuffer): Arg is now EMACS_INT, not int.
6246 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6247 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6248 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6249
2be7d702
PE
6250 * dbusbind.c (signature_cat): New function.
6251 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6252 Do not overrun buffer; instead, report string overflow.
6253
9d1df220
PE
6254 * dispnew.c (add_window_display_history): Don't overrun buffer.
6255 Truncate instead; this is OK since it's just a log.
6256
33ef5c64
PE
6257 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6258 even if the time zone offset is outlandishly large.
6259 Don't mishandle offset == INT_MIN.
6260
66c6fdd5
PE
6261 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6262 when creating daemon; the previous buffer-overflow check was incorrect.
6263
d749b01b
PE
6264 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6265 which has the guts of the old verror function.
6266
b5cd1905
PE
6267 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6268 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6269
6e1a67fb
PE
6270 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6271 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6272 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6273 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6274 length of string rather than counting it via multiple sprintfs;
6275 that's simpler and more reliable.
c21721cc
PE
6276 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6277 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6278 sprintf, in case result does not fit in int.
6279
c57b67fc
PE
6280 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6281 (fontset_from_font): Print it.
6282
8a401434
PE
6283 * frame.c (tty_frame_count): Now printmax_t, not int.
6284 (make_terminal_frame, set_term_frame_name): Print it.
6285 (x_report_frame_params): In X, window IDs are unsigned long,
6286 not signed long, so print them as unsigned.
6287 (validate_x_resource_name): Check for implausibly long names,
6288 and don't assume name length fits in 'int'.
6289 (x_get_resource_string): Don't blindly alloca invocation name;
6290 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6291 not fit in int.
6292
6e1a67fb
PE
6293 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6294 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6295 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6296
0df02bf3
PE
6297 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6298 Use esprintf, not sprintf, in case result does not fit in int.
6299
48e30793
PE
6300 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6301 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6302 it as a large positive number.
6303 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6304 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6305
a66ff6d8
PE
6306 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6307 in case result does not fit in int.
6308
aca216ff
PE
6309 * print.c (float_to_string): Detect width overflow more reliably.
6310 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6311 buffer overrun. Don't assume list length fits in 'int'. Treat
6312 print length of 0 as 0, not as infinity; to be consistent with other
6313 uses of print length in this function. Don't overflow print length
6314 index. Don't assume hash table size fits in 'long', or that
6315 vectorlike size fits in 'unsigned long'.
6316
31c286f7
PE
6317 * process.c (make_process): Use printmax_t, not int, to format
6318 process-name gensyms.
6319
55e5faa1
PE
6320 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6321
80f2e268
PE
6322 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6323 to avoid potential buffer overrun.
6324
670741ab
PE
6325 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6326 if X resource line is longer than 512 bytes.
6327
b7163a50
PE
6328 * xfns.c (x_window): Make sprintf buffer a bit bigger
6329 to avoid potential buffer overrun.
6330
ae58ff1f
PE
6331 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6332
c43c8a6a
PE
6333 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6334
3f8236f4
PE
63352011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6336
53e9fe90 6337 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6338 Without these, Emacs silently mishandles large integers sometimes.
6339 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6340 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6341
6511acf2
PE
6342 * xdisp.c (try_window_id): Check Emacs fixnum range before
6343 converting to 'int'.
806add1d 6344
6511acf2 6345 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6346 Check that an Emacs fixnum is in range before assigning it to 'int'.
6347 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6348 values converted from Emacs fixnums.
6349 (Frecenter): Don't wrap around a line count if it is out of 'int'
6350 range; instead, treat it as an extreme value.
6351 (Fset_window_configuration, compare_window_configurations):
6352 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6353
6511acf2
PE
6354 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6355 that can exceed INT_MAX. Check that EMACS_INT value is in range
6356 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6357 (match_limit): Don't assume that a fixnum can fit in 'int'.
6358
6511acf2 6359 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6360 exceed INT_MAX.
6361
6511acf2 6362 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6363 (Fvertical_motion): Don't wrap around LINES values that don't fit
6364 in 'int'. Instead, treat them as extreme values. This is good
6365 enough for windows, which can't have more than INT_MAX lines anyway.
6366
fcb901a7
LMI
63672011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6368
0f2f6b6d
LMI
6369 * Require libxml/parser.h to avoid compilation warning.
6370
fcb901a7
LMI
6371 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6372
6373 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6374 since this reportedly can destroy thread storage.
6375
6e20a0d4
CY
63762011-08-30 Chong Yidong <cyd@stupidchicken.com>
6377
6378 * syntax.c (find_defun_start): Update all cache variables if
6379 exiting early (Bug#9401).
6380
148ae00e
EZ
63812011-08-30 Eli Zaretskii <eliz@gnu.org>
6382
f6cfbd8f
EZ
6383 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6384
148ae00e
EZ
6385 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6386 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6387 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6388
6389 * term.c (tty_append_glyph): New function.
6390 (produce_stretch_glyph): Static function and its prototype deleted.
6391
a66cfb1c
SM
6392 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6393 Add prototypes.
148ae00e 6394
c4a07a4c
PE
63952011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6396
6397 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6398 when checking :margin (Bug#9390).
6399 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6400 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6401 so that the name doesn't mislead. All uses changed.
6402
6bc8cd65
JB
64032011-08-28 Johan Bockgård <bojohan@gnu.org>
6404
6405 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6406 set_tty_hooks.
6407
dca4927e
EZ
64082011-08-27 Eli Zaretskii <eliz@gnu.org>
6409
6410 * xdisp.c (move_it_to): Don't bail out early when reaching
6411 position beyond to_charpos, if we are scanning backwards.
6412 (move_it_vertically_backward): When DY == 0, make sure we get to
6413 the first character in the line after the newline.
6414
f2cad773
PE
64152011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6416
6417 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6418 (ccl_driver): Do not generate an out-of-range pointer.
6419 (Fccl_execute_on_string): Remove unnecessary check for
6420 integer overflow, noted by Stefan Monnier in
6421 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6422 Remove a FIXME that didn't need fixing.
6423 Simplify the newly-introduced buffer reallocation code.
6424
0cae2cdb
JB
64252011-08-27 Juanma Barranquero <lekktu@gmail.com>
6426
6427 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6428
5fc295a4 64292011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6430
70c60eb2 6431 Integer and memory overflow issues (Bug#9196).
726e0ab1 6432
d31850da
PE
6433 * doc.c (get_doc_string): Rework so that
6434 get_doc_string_buffer_size is the actual buffer size, rather than
6435 being 1 less than the actual buffer size; this makes xpalloc more
6436 convenient.
6437
a69fbedb
PE
6438 * image.c (x_allocate_bitmap_record, cache_image):
6439 * xselect.c (Fx_register_dnd_atom):
6440 Simplify previous changes by using xpalloc.
6441
fe5c5d37
PE
6442 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6443 since either will do and ptrdiff_t is convenient with xpalloc.
6444
0065d054
PE
6445 * charset.c (charset_table_size)
6446 (struct charset_sort_data.priority): Now ptrdiff_t.
6447 (charset_compare): Don't overflow if priorities differ greatly.
6448 (Fsort_charsets): Don't assume list length fits in int.
6449 Check for size-calculation overflow when allocating sort data.
6450 (syms_of_charset): Allocate an initial charset table that is
6451 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6452
6453 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6454
6455 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6456 The actual value is always <= INT_MAX, and leaving it unsigned made
6457 overflow checking harder.
6458
6459 * dispextern.h (struct glyph_matrix.rows_allocated)
6460 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6461 with xpalloc. The values are still always <= INT_MAX.
6462
6463 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6464
6465 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6466 (SAFE_NALLOCA): New macro.
6467
6468 * region-cache.c (struct boundary.pos, find_cache_boundary)
6469 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6470 (set_cache_region, invalidate_region_cache)
6471 (revalidate_region_cache, know_region_cache, region_cache_forward)
6472 (region_cache_backward, pp_cache):
6473 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6474 so that ptrdiff_t * can be passed to xpalloc.
6475 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6476 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6477 (pp_cache): Don't assume cache_len fits in int.
6478 * region-cache.h: Adjust extern decls to match.
6479
6480 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6481 EMACS_INT, since either will do, for xpalloc.
6482
6483 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6484 (xnmalloc, xnrealloc, xpalloc): New functions.
6485
726e0ab1
PE
6486 * bidi.c (bidi_shelve_header_size): New constant.
6487 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6488 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6489
51f30bc5 6490 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6491 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6492 (overlay_strings):
6493 Don't update size of array until after memory allocation succeeds,
6494 because xmalloc/xrealloc may not return.
0065d054
PE
6495 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6496 now that we have proper integer overflow checking.
6497 (record_overlay_string, overlay_strings): Catch overflows when
6498 calculating size of overlay_str_buf.
726e0ab1 6499
0065d054
PE
6500 * callproc.c (Fcall_process): Check for size overflow when
6501 calculating size of args2.
6502 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6503 Normally we prefer signed values, but sticking with ptrdiff_t would
6504 require adding more-complicated checks.
726e0ab1
PE
6505
6506 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6507 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6508 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6509 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6510
6511 * character.c (Fstring): Check for size-calculation overflow.
6512
6513 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6514 unnecessary integer overflow. Check for size overflow.
6515 (encode_coding_object): Don't update size until xmalloc succeeds.
6516
6517 * composite.c (get_composition_id): Check for overflow in glyph
6518 length calculations.
6519
6520 Integer and memory overflow fixes for display code.
6521 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6522 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6523 (scrolling_window): Check for overflow in size calculations.
6524 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6525 Don't assume glyph table len fits in int.
6526 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6527 (row_table_size): Now ptrdiff_t, not int.
6528 (scrolling_window): Avoid overflow in size calculations.
6529 Don't update size until allocation succeeds.
6530 * fns.c (concat): Check for overflow in size calculations.
6531 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6532 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6533 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6534
6535 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6536 (get_doc_string): Check for size calculation overflow.
6537 Don't update size until allocation succeeds.
6538 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6539 EMACS_INT, where ptrdiff_t will do.
6540 (Fsubstitute_command_keys): Check for string overflow.
6541
6542 * editfns.c (set_time_zone_rule): Don't assume environment length
6543 fits in int.
6544 (message_length): Now ptrdiff_t, not int.
6545 (Fmessage_box): Don't update size until allocation succeeds.
6546 Don't assume message length fits in int.
6547 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6548
0065d054
PE
6549 * emacs.c (main): Do not reallocate argv, since there is a null at
6550 the end that can be overwritten, and this way there's no need to
6551 worry about size-calculation overflow.
6552 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6553
6554 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6555 alloc succeeds.
6556 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6557
6558 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6559 (x_set_scroll_bar_width, x_figure_window_size):
6560 Check for integer overflow.
6561 (x_set_alpha): Do not assume XINT fits in int.
6562
6563 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6564 This is for the members text_lines, text_cols, total_lines, total_cols,
6565 where the system imposes an 'int' limit.
6566
6567 * fringe.c (Fdefine_fringe_bitmap):
6568 Don't update size until alloc works.
6569
6570 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6571 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6572
6573 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6574 Check for size-calculation overflow.
6575 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6576 do, as we prefer signed integers.
6577 (id_to_widget.max_size, id_to_widget.used)
6578 (xg_store_widget_in_map, xg_remove_widget_from_map)
6579 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6580 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6581 Use and return ptrdiff_t, not int.
6582 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6583 * gtkutil.h: Change prototypes to match the above.
6584
6585 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6586 are duplicate now that they've been promoted to lisp.h.
6587 (x_allocate_bitmap_record, x_alloc_image_color)
6588 (make_image_cache, cache_image, xpm_load):
6589 Don't update size until alloc is done.
6590 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6591 (x_detect_edges):
3256efce 6592 Check for size calculation overflow.
726e0ab1
PE
6593 (ct_colors_allocated_max): New constant.
6594 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6595 overflow.
3256efce 6596
726e0ab1
PE
6597 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6598 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6599 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6600 Use ptrdiff_t, not int, to count maps.
6601 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6602 calculations. Don't update size until allocation succeeds.
6603 Redo calculations to avoid overflow.
726e0ab1
PE
6604 * keyboard.h: Change prototypes to match the above.
6605
6606 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6607 to count maps.
6608 (current_minor_maps): Check for size calculation overflow.
6609 * keymap.h: Change prototypes to match the above.
6610
6611 * lread.c (read1, init_obarray): Don't update size until alloc done.
6612
6613 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6614 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6615
726e0ab1
PE
6616 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6617 Now ptrdiff_t, not int.
6618 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6619 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6620
6621 * process.c (Fnetwork_interface_list): Check for overflow
6622 in size calculation.
6623
6624 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6625
6626 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6627 overflow. Don't bother calling xmalloc when xrealloc will do.
6628
6629 * search.c (Freplace_match): Check for size calculation overflow.
6630 (Fset_match_data): Don't assume list lengths fit in 'int'.
6631
6632 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6633 for command line length. Do not attempt to address one before the
6634 beginning of an array, as that's not portable.
6635
6636 * term.c (max_frame_lines): Remove; unused.
6637 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6638 not int.
6639 (encode_terminal_code, calculate_costs): Check for size
6640 calculation overflow.
6641 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6642 table lengths and related sizes. Don't update size until alloc
6643 done. Redo calculations to avoid overflow.
6644 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6645
6646 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6647 subtracting pointers.
6648 (gobble_line): Check for overflow more carefully. Don't update size
6649 until alloc done.
6650
6651 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6652 Don't update size until alloc done.
6653 Redo size calculations to avoid overflow.
6654 Check for size calculation overflow.
0065d054 6655 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6656
6657 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6658 Use ptrdiff_t, not int, for sizes.
6659 (store_mode_line_noprop_char): Don't update size until alloc done.
6660
0065d054
PE
6661 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6662 Use ptrdiff_t, not int, for sizes.
6663 (Finternal_make_lisp_face, cache_face):
6664 Check for size calculation overflow.
6665 (cache_face): Treat size calculation overflows as if they were
6666 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6667
6668 * xfns.c (x_encode_text, x_set_name_internal)
6669 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6670 sizes, since they can exceed INT_MAX in size. Check for size
6671 calculation overflow.
6672
0065d054
PE
6673 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6674 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6675 Don't update size until alloc done.
6676
0065d054 6677 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6678 as sprintf is limited to int lengths.
1d526e2f 6679
252c5ee1
PE
6680 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6681 (X_LONG_MIN): New macros.
864d7ce7
PE
6682 Use them to make the following changes clearer.
6683 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6684 This change doesn't affect the value now, but it may help remind
6685 future maintainers not to raise the value too much later.
6686 (SELECTION_QUANTUM): Remove, replacing with ...
6687 (selection_quantum): ... new function, which avoids overflow.
6688 All uses changed.
6689 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6690 assumption that selection length fits in 'int'.
6691 (x_reply_selection_request, x_handle_selection_request)
6692 (x_get_window_property, receive_incremental_selection)
6693 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6694 (lisp_data_to_selection_data, clean_local_selection_data):
6695 Use ptrdiff_t, not int, to record length of selection.
6696 (x_reply_selection_request, x_get_window_property)
6697 (receive_incremental_selection, x_property_data_to_lisp):
6698 Redo calculations to avoid overflow.
6699 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6700 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6701 something.
6702 (x_get_window_property, receive_incremental_selection)
6703 (lisp_data_to_selection_data, x_property_data_to_lisp):
6704 Check for size-calculation overflow.
6705 (x_get_window_property, receive_incremental_selection)
6706 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6707 Don't store size until memory allocation succeeds.
6708 (x_get_window_property): Plug memory leak on memory exhaustion.
6709 Don't double-block input; malloc is safe here. Don't assume 2**34
6710 - 4 fits in unsigned long. Add an xassert to check
6711 XGetWindowProperty overflow. Be more careful about overflow
6712 calculations, and distinguish size from memory overflow better.
6713 (receive_incremental_selection): When tracing, don't assume
6714 unsigned int is less than INT_MAX.
6715 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6716 harmful) conversions of unsigned short to int.
6717 (lisp_data_to_selection_data): Don't assume that integers
6718 in the range -65535 through -1 fit in an X unsigned short.
6719 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6720 result parameters unless successful. Rely on cons_to_unsigned
6721 to report problems with elements; the old code wasn't right anyway.
6722 (x_check_property_data): Check for int overflow; we cannot use
6723 a wider type due to X limits.
6724 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6725
726e0ab1 6726 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6727
0065d054
PE
6728 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6729 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6730 (x_color_cells): Don't store size until memory allocation succeeds.
6731 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6732 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6733 (x_term_init): Don't assume length fits in int (sprintf is limited
6734 to int size).
bc18e09d 6735
ebfa62c0
PE
6736 Use ptrdiff_t for composition IDs.
6737 * character.c (lisp_string_width):
6738 * composite.c (composition_table_size, n_compositions)
6739 (get_composition_id, composition_gstring_from_id):
6740 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6741 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6742 * window.c (Frecenter):
6743 Use ptrdiff_t, not int, for composition IDs.
6744 * composite.c (get_composition_id): Check for integer overflow.
6745 * composite.h: Adjust prototypes to match the above changes.
6746
d3411f89
PE
6747 Use ptrdiff_t for hash table indexes.
6748 * category.c (hash_get_category_set):
6749 * ccl.c (ccl_driver):
6750 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6751 * coding.c (coding_system_charset_list, detect_coding_system):
6752 * coding.h (struct coding_system.id):
6753 * composite.c (get_composition_id, gstring_lookup_cache):
6754 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6755 * image.c (xpm_get_color_table_h):
6756 * lisp.h (hash_lookup, hash_put):
6757 * minibuf.c (Ftest_completion):
6758 Use ptrdiff_t for hash table indexes, not int (which is too
6759 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6760 32-bit --with-wide-int hosts).
6761
e097a6fa
PE
6762 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6763 Add a FIXME comment about memory leaks.
6764 (syms_of_charset): Don't assume xmalloc returns.
6765
5637687f
PE
6766 Don't assume that stated character widths fit in int.
6767 * character.c (Fchar_width, c_string_width, lisp_string_width):
6768 * character.h (CHAR_WIDTH):
6769 * indent.c (MULTIBYTE_BYTES_WIDTH):
6770 Use sanitize_char_width to avoid undefined and/or bad behavior
6771 with outlandish widths.
a66cfb1c 6772 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6773 now that we have two such functions. All uses changed.
6774 (sanitize_char_width): New inline function.
6775
a2271ba2
PE
6776 Don't assume that tab-width fits in int.
6777 * character.h (sanitize_width): New inline function.
6778 (SANE_TAB_WIDTH): New macro.
6779 (ASCII_CHAR_WIDTH): Use it.
6780 * indent.c (sane_tab_width): Remove. All uses replaced by
6781 SANE_TAB_WIDTH (current_buffer).
6782 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6783
18c52557
PE
6784 * fileio.c: Integer overflow issues with file modes.
6785 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6786
caeeedc1
PE
6787 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6788 Remove unreachable code.
6789 (read_hex, load_charset_map_from_file): Check for integer overflow.
6790
6df6ae42 6791 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6792 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6793 (x_send_scroll_bar_event): Likewise. Check that the size does not
6794 exceed limits imposed by XClientMessageEvent, as well as the usual
6795 ptrdiff_t and size_t limits.
6796
b13995db
PE
6797 * keyboard.c: Overflow, signedness and related fixes.
6798 (make_lispy_movement): Use same integer type in forward decl
6799 that is used in the definition.
6800 (read_key_sequence, keyremap_step):
6801 Change bufsize argument back to int, undoing my 2011-03-30 change.
6802 We prefer signed types, and int is wide enough here.
6803 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6804 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6805 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6806 length, not size_t. Use ptrdiff_t for index, not int.
6807 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6808 possibility of integer overflow.
6809
13464394
PE
6810 Overflow, signedness and related fixes for images.
6811
6812 * dispextern.h (struct it.stack[0].u.image.image_id)
6813 (struct_it.image_id, struct image.id, struct image_cache.size)
6814 (struct image_cache.used, struct image_cache.ref_count):
6815 * gtkutil.c (update_frame_tool_bar):
6816 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6817 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6818 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6819 * nsmenu.m (update_frame_tool_bar):
6820 * xdisp.c (calc_pixel_width_or_height):
6821 * xfns.c (image_cache_refcount):
6822 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6823 on typical 64-bit hosts.
6824
6825 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6826 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6827 Omit unnecessary casts to int.
6828 (parse_image_spec): Check that integers fall into 'int' range
6829 when the callers expect that.
6830 (image_ascent): Redo ascent calculation to avoid int overflow.
6831 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6832 (lookup_image): Remove unnecessary tests.
6833 (xbm_image_p): Locals are now of int, not EMACS_INT,
6834 since parse_image_check makes sure they fit into int.
6835 (png_load, gif_load, svg_load_image):
6836 Prefer int to unsigned where either will do.
6837 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6838 old tiff_error_handler and tiff_warning_handler.
6839 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6840 stack buffer overflows. It uses only the features of vsnprintf
6841 that are common to both POSIX and native Microsoft.
6842 (tiff_error_handler, tiff_warning_handler): Use it.
6843 (tiff_load, gif_load, imagemagick_load_image):
6844 Don't assume :index value fits in 'int'.
6845 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6846 (imagemagick_load_image): Check that crop parameters fit into
6847 the integer types that MagickCropImage accepts. Don't assume
6848 Vimagemagick_render_type has a nonnegative value. Don't assume
6849 size_t fits in 'long'.
6850 (gs_load): Use printmax_t to print the widest integers possible.
6851 Check for integer overflow when computing image height and width.
6852
c11821d4
EZ
68532011-08-26 Eli Zaretskii <eliz@gnu.org>
6854
6855 * xdisp.c (redisplay_window): Don't force window start if point
6856 will be invisible in the resulting window. (Bug#9324)
6857
0c95fcf7
EZ
68582011-08-25 Eli Zaretskii <eliz@gnu.org>
6859
6860 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6861 the display spec is of the form `(space ...)'.
6862 (handle_display_spec): Return the value returned by
6863 handle_single_display_spec, not just 1 or zero.
6864 (handle_single_display_spec): If the display spec is of the form
6865 `(space ...)', and specifies display in the text area, return 2
6866 rather than 1.
fee65a97 6867 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6868 accurately, and prefer exact match for point under bidi.
6869 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6870
6871 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6872 into disp_prop; all users changed.
6873
6874 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6875 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6876 for the text covered by the display property.
6877
e4ed06f1
CY
68782011-08-25 Chong Yidong <cyd@stupidchicken.com>
6879
6880 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6881 Change return value to nil.
6882 (Frecord_buffer): Delete unused function.
6883
f67cdd7f
EZ
68842011-08-24 Eli Zaretskii <eliz@gnu.org>
6885
5980d4c6
EZ
6886 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6887 buffers, return left-to-right.
8610fe8b
EZ
6888 (set_cursor_from_row): Consider candidate row a win if its glyph
6889 represents a newline and point is on that newline. Fixes cursor
6890 positioning on the newline at EOL of R2L text within L2R
6891 paragraph, and vice versa.
6892 (try_cursor_movement): Check continued rows, in addition to
6893 continuation rows. Fixes unwarranted scroll when point enters a
6894 continued line of R2L text within an L2R paragraph, or vice versa.
6895 (cursor_row_p): Consider the case of point being equal to
6896 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6897 from the end of a short line to the beginning of a continued line
6898 of R2L text within L2R paragraph.
6899 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6900 composed characters.
5980d4c6 6901
f67cdd7f
EZ
6902 * bidi.c (bidi_check_type): Use xassert.
6903 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6904 members.
6905
bca633fb
EZ
69062011-08-23 Eli Zaretskii <eliz@gnu.org>
6907
6908 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6909 a character.
6910
4a5885a7
CY
69112011-08-23 Chong Yidong <cyd@stupidchicken.com>
6912
6913 * nsfont.m (ns_otf_to_script): Fix typo.
6914
0902a04e
KH
69152011-08-22 Kenichi Handa <handa@m17n.org>
6916
6917 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6918 extra slot even if the purpose is char-code-property-table.
6919
1a2e6670
EZ
69202011-08-23 Eli Zaretskii <eliz@gnu.org>
6921
8ddde651
EZ
6922 * xdisp.c (redisplay_window): When computing centering_position,
6923 account for the height of the header line. (Bug#8874)
6924
425cc014
EZ
6925 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6926 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6927 candidate is selected by the mouse, and that candidate has a
6928 composed character under the mouse.
6929
1a2e6670
EZ
6930 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6931 coordinates reported by pos-visible-in-window-p for a composed
6932 character in column zero.
6933
8b76d6f8
SM
69342011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6935
6936 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6937
dac347dd
EZ
69382011-08-22 Eli Zaretskii <eliz@gnu.org>
6939
6940 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6941 consider it a hit if to_charpos is anywhere in the range of the
6942 composed buffer positions.
6943
e013fb34
CY
69442011-08-22 Chong Yidong <cyd@stupidchicken.com>
6945
6946 * image.c (gif_load): Don't assume that each subimage has the same
6947 dimensions as the base image. Handle disposal method that is
6948 "undefined" by the gif spec (Bug#9335).
6949
bd1ba3e8
CY
69502011-08-20 Chong Yidong <cyd@stupidchicken.com>
6951
6952 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6953 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6954
54a1215b
EZ
69552011-08-19 Eli Zaretskii <eliz@gnu.org>
6956
823564e5
EZ
6957 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6958 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6959 from an Org mode buffer to a Speedbar frame.
6960
54a1215b
EZ
6961 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6962 a composition, take its buffer position from IT->cmp_it.charpos.
6963 Fixes cursor positioning at the beginning of a line that begins
6964 with a composed character.
6965
9778ebcc
EZ
69662011-08-18 Eli Zaretskii <eliz@gnu.org>
6967
0be6ee06
EZ
6968 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6969 character bidirectional type, use STRONG_L instead. Fixes crashes
6970 in a buffer produced by `describe-categories'.
6971
9778ebcc
EZ
6972 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6973 members before the level stack, so they would be saved and
6974 restored when copying iterator state. Fixes incorrect reordering
6975 around TABs covered by display properties.
6976
156bffbe
AS
69772011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6978
6b02f655 6979 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6980
72ad093b
CY
69812011-08-17 Chong Yidong <cyd@stupidchicken.com>
6982
6983 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6984 (internal_condition_case_2, internal_condition_case_n):
6985 Remove unnecessary aborts (Bug#9081).
72ad093b 6986
35774242
EZ
69872011-08-17 Eli Zaretskii <eliz@gnu.org>
6988
6989 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6990 has no `load' handler, try opening the file locally. (Bug#9311)
6991
db76dd85
KB
69922011-08-16 Ken Brown <kbrown@cornell.edu>
6993
6994 * gmalloc.c: Expand comment.
6995
b215eee5
EZ
69962011-08-16 Eli Zaretskii <eliz@gnu.org>
6997
6998 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6999 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7000
a4579d33
KB
70012011-08-16 Ken Brown <kbrown@cornell.edu>
7002
7003 Fix memory allocation problems in Cygwin build (Bug#9273).
7004
7005 * unexcw.c ( __malloc_initialized): Declare external variable.
7006 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7007
8b76d6f8
SM
7008 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7009 New variables.
a4579d33
KB
7010 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7011 dumped emacs.
7012 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7013 in the static heap.
7014 [CYGWIN] (special_realloc): New function.
7015 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7016 requests to realloc storage in the static heap.
7017
3ebec551
PE
70182011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7019
7020 * bidi.c (bidi_initialize): Remove unused local.
7021
9fd8be00
EZ
70222011-08-15 Eli Zaretskii <eliz@gnu.org>
7023
6b02f655
SM
7024 * bidimirror.h:
7025 * biditype.h: Remove file.
7026 * makefile.w32-in ($(BLD)/bidi.$(O)):
7027 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7028
7029 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7030
7031 * chartab.c: Improve commentary for the uniprop_table API.
7032
32413314
EZ
7033 * bidi.c (bidi_paragraph_init): Support zero value of
7034 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7035 (bidi_initialize): Use uniprop_table instead of including
7036 biditype.h and bidimirror.h.
32413314 7037
9fd8be00
EZ
7038 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7039 coordinates of the iterator when restoring from ppos_it.
7040 (Bug#9296)
7041
5cf2b69b
KH
70422011-08-14 Kenichi Handa <handa@m17n.org>
7043
7044 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7045 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7046
daf17d00
EZ
70472011-08-14 Eli Zaretskii <eliz@gnu.org>
7048
7049 * xdisp.c (move_it_in_display_line_to): Don't invoke
7050 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7051 ppos_it. Fixes vertical cursor motion when line beginning is
7052 covered by an image. (Bug#9296)
7053
08e3161a
JD
70542011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7055
7056 * nsterm.h (ns_run_ascript): Declare.
7057 (NSAPP_DATA2_RUNASSCRIPT): Define.
7058
7059 * nsfns.m (as_script, as_result, as_status): New static variables.
7060 (ns_run_ascript): New function.
5e617bc2 7061 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7062 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7063 the event loop. Get status from as_status (Bug#7276).
7064
7065 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7066 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7067 the event loop (Bug#7276).
7068
a3720aa2
AS
70692011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7070
7071 * gnutls.c (QCgnutls_bootprop_priority)
7072 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7073 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7074 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7075 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7076 (QCgnutls_bootprop_verify_hostname_error)
7077 (QCgnutls_bootprop_callbacks_verify): Rename from
7078 Qgnutls_bootprop_..., all uses changed.
7079
7080 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7081 uses changed.
7082
0a0d27fb
PE
70832011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7084
19d5c50c
PE
7085 * xfaces.c (Qframe_set_background_mode): Now static.
7086 * dispextern.h (Qframe_set_background_mode): Remove decl.
7087
0a0d27fb
PE
7088 * process.c (Fnetwork_interface_info): Declare local only if needed.
7089
377538cb
JD
70902011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7091
7092 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7093 (Fnetwork_interface_list): Allocate in increments of bytes instead
7094 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7095 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7096 sockaddr.
7097 (struct ifflag_def): notrailers is smart on OSX.
7098 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7099 Get hardware address with getifaddrs if available.
7100
08fff70c
EZ
71012011-08-12 Eli Zaretskii <eliz@gnu.org>
7102
7103 * xdisp.c (iterate_out_of_display_property): xassert that
7104 IT->position is set to within IT->object's boundaries. Break from
7105 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7106 when IT->position is set up wrongly due to some bug.
7107 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7108 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7109 entry. Force push_it to save on the stack the current
7110 buffer/string position, to be restored by pop_it. Fix flags in
7111 the iterator structure wrt the object coming from a display
7112 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7113 properties. (Bug#9284)
7114
7be1c708 71152011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7116
7be1c708
CY
7117 * fontset.c (fontset_get_font_group): Add proper type checks.
7118 (Bug#9172)
aac0c6e3 7119
7be1c708 71202011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7121
7be1c708
CY
7122 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7123 and LC_VERSION_MIN_MACOSX.
7124 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7125 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7126
97bb72a6
EZ
71272011-08-08 Eli Zaretskii <eliz@gnu.org>
7128
7129 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7130 no-display-properties-and-no-overlays under bidi display.
7131 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7132 properties and overlays.
97bb72a6 7133
d5617611
CY
71342011-08-08 Chong Yidong <cyd@stupidchicken.com>
7135
37e11a63
CY
7136 * editfns.c (Fset_time_zone_rule): Document relationship with the
7137 setenv function.
7138
d5617611
CY
7139 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7140 the font entity extracted from the cache (Bug#8109).
7141
58872834
CY
71422011-08-07 Chong Yidong <cyd@stupidchicken.com>
7143
7144 * composite.c (autocmp_chars): Don't reset point. That is done by
7145 restore_point_unwind (Bug#5984).
7146
75bfc667
JL
71472011-08-07 Juri Linkov <juri@jurta.org>
7148
7149 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7150 to show the arg `TIME' instead of `TIMEVAL'.
7151
d1410150
EZ
71522011-08-06 Eli Zaretskii <eliz@gnu.org>
7153
7154 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7155 display property strides EOL and includes a newline, as in
7156 longlines-mode. (Bug#9254)
75b771e4
EZ
7157 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7158 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7159
7160 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7161 is non-zero, even if the data buffer is NULL. Fixes a crash in
7162 vertical-motion with longlines-mode. (Bug#9254)
7163
35928349
EZ
71642011-08-05 Eli Zaretskii <eliz@gnu.org>
7165
ec7cc85b
EZ
7166 * bidi.c <bidi_cache_total_alloc>: Now static.
7167 (bidi_initialize): Initialize bidi_cache_total_alloc.
7168
8b76d6f8 7169 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7170 cache. (Bug#9221)
7171
7172 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7173 amount allocated this far in `bidi_cache_total_alloc'.
7174 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7175 non-zero, only free the data buffer without restoring the cache
7176 contents. All callers changed.
7177
7178 * dispextern.h (bidi_unshelve_cache): Update prototype.
7179
7180 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7181 (move_it_in_display_line, move_it_to)
7182 (move_it_vertically_backward, move_it_by_lines): Replace the call
7183 to xfree to an equivalent call to bidi_unshelve_cache.
7184 (move_it_in_display_line_to): Fix logic of returning
412b6358 7185 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7186
e2e2423b
EZ
71872011-08-05 Eli Zaretskii <eliz@gnu.org>
7188
7189 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7190 came from a string character with a `cursor' property. (Bug#9229)
7191
ae9e757a
JD
71922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7193
7194 * Makefile.in (LIB_PTHREAD): New variable.
7195 (LIBES): Add LIB_PTHREAD (Bug#9216).
7196
7197 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7198 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7199
213bd7f2
AS
72002011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7201
6b02f655 7202 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7203
99aaf75f
JD
72042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7205
7206 * xterm.c (x_find_topmost_parent): New function.
7207 (x_set_frame_alpha): Find topmost parent window with
7208 x_find_topmost_parent and set the property there also (bug#9181).
7209 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7210
c74e9d86
PE
72112011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7212
7213 * callproc.c (Fcall_process): Avoid vfork clobbering
7214 the local vars buffer, coding_systems, current_dir.
7215
640c8776
SM
72162011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7217
7218 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7219
f26d0e4c
PE
72202011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7221
8a10d76c
PE
7222 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7223 so that it is not optimized away.
7224
f26d0e4c
PE
7225 * xdisp.c (compute_display_string_pos): Remove unused local.
7226
55439c61
EZ
72272011-08-02 Eli Zaretskii <eliz@gnu.org>
7228
7229 Fix slow cursor motion and scrolling in large buffers with
7230 selective display, like Org Mode buffers. (Bug#9218)
7231
7232 * dispextern.h (struct bidi_it): New member disp_prop_p.
7233
7234 * xdisp.c: Remove one-slot cache of display string positions.
7235 (compute_display_string_pos): Accept an additional argument
5e617bc2 7236 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7237 for a display string or property. If found, set DISP_PROP_P
7238 non-zero.
7239
7240 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7241 DISP_PROP_P, and pass it to compute_display_string_pos.
7242 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7243 non-zero. All callers of bidi_fetch_char changed.
7244
fb33fa43
SM
72452011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7246
7247 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7248
b099e063
DM
72492010-12-03 Don March <don@ohspite.net>
7250
7251 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7252 last character M-[char] is translated to ESC [char] (bug#7541).
7253
5cc7f7af
KH
72542011-08-02 Kenichi Handa <handa@m17n.org>
7255
d0fffa3f 7256 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7257
7258 * chartab.c (uniprop_table): Make it non-static.
7259
525d5e6e
EZ
72602011-08-01 Eli Zaretskii <eliz@gnu.org>
7261
7262 * xdisp.c (forward_to_next_line_start): Accept additional argument
7263 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7264 on the newline.
7265 (reseat_at_next_visible_line_start): Use the bidi iterator state
7266 returned by forward_to_next_line_start to restore the state of
7267 it->bidi_it after backing up to previous newline. (Bug#9212)
7268
31011111
AS
72692011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7270
7271 * regex.c (re_comp): Protoize.
7272 (re_exec): Fix return type.
7273 (regexec): Fix type of `ret'. (Bug#9203)
7274
476371c4
PE
72752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7276
e5d76069
PE
7277 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7278 This is needed if max-image-size is a floating-point number.
7279
9a79b20c
AS
72802011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7281
7282 * print.c (print_object): Print empty symbol as ##.
7283
7284 * lread.c (read1): Read ## as empty symbol.
7285
d8c2fa78
AA
72862011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7287
7288 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7289 setting frame foreground color (Bug#9175).
7290 (x_set_background_color): Likewise.
7291
ffe57a7a
AA
7292 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7293 contents (Bug#9176).
7294 (EmacsTooltip -init): Remove bezels and add shadows to
7295 tooltip windows.
7296
bf3492a5
AA
7297 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7298 or scroll bar (Bug#8470).
7299
d55e9c53
AA
7300 * nsfont.m (nsfont_open): Remove assignment to voffset and
7301 unnecessary vars hshink, expand, hd, full_height, min_height.
7302 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7303
7304 * nsterm.h (nsfont_info): Remove voffset field.
7305
d8c2fa78 73062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7307
7308 Implement strike-through and overline on NextStep (Bug#8863).
7309
7310 * nsfont.m (nsfont_open): Use underline position provided by font,
7311 instead of hard-coded value of 2.
7312 (nsfont_draw): Call ns_draw_text_decoration instead.
7313
7314 * nsterm.h: Add declaration for ns_draw_text_decoration.
7315
7316 * nsterm.m (ns_draw_text_decoration): New function for drawing
7317 underline, overline, and strike-through.
7318 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7319 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7320 accommodate underlining, etc.
4843aac3 7321
4cc60b9b
EZ
73222011-07-28 Eli Zaretskii <eliz@gnu.org>
7323
bc7ece87
EZ
7324 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7325 default.
4cc60b9b 7326
476371c4
PE
73272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7328
66606eea
PE
7329 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7330 Without this fix, if a signal arrives just after memory fills up,
7331 'malloc' might be invoked reentrantly.
7332
476371c4
PE
7333 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7334 In other words, assume that every image size is allowed, on non-X
7335 hosts. This assumption is probably wrong, but it lets Emacs compile.
7336
f3fcc40d
AS
73372011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7338
7339 * regex.c (re_iswctype): Convert return values to boolean.
7340
350c992f
EZ
73412011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7342
7343 * xdisp.c (compute_display_string_pos): Don't use cached display
7344 string position if the buffer had its restriction changed.
7345 (Bug#9184)
7346
5266b4bb
PE
73472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7348
7349 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7350
2573a837 73512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7352
41f55ccd 7353 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7354
39e378da
PE
7355 * bidi.c: Integer size and overflow fixes.
7356 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7357 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7358 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7359 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7360 (bidi_find_other_level_edge):
7361 Use ptrdiff_t instead of EMACS_INT where either will do.
7362 This works better on 32-bit hosts configured --with-wide-int.
7363 (bidi_cache_ensure_space): Check for size-calculation overflow.
7364 Use % rather than repeated addition, for better worst-case speed.
7365 Don't set bidi_cache_size until after xrealloc returns, because it
7366 might not return.
7367 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7368 (bidi_cache_ensure_space): Also check that the bidi cache size
7369 does not exceed that of the largest Lisp string or buffer. See Eli
7370 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7371
5e927815
PE
7372 * alloc.c (__malloc_size_t): Remove.
7373 All uses replaced by size_t. See Andreas Schwab's note
7374 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7375
ca4aa935
PE
7376 * image.c: Improve checking for integer overflow.
7377 (check_image_size): Assume that f is nonnull, since
7378 it is always nonnull in practice. This is one less thing to
7379 worry about when checking for integer overflow later.
7380 (x_check_image_size): New function, which checks for integer
7381 overflow issues inside X.
7382 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7383 This removes the need for a memory_full check.
7384 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7385 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7386 (xbm_read_bitmap_data): Change locals back to 'int', since
7387 their values must fit in 'int'.
7388 (xpm_load_image, png_load, tiff_load):
7389 Invoke x_create_x_image_and_pixmap earlier,
7390 to avoid much needless work if the image is too large.
7391 (tiff_load): Treat overly large images as if
7392 x_create_x_image_and_pixmap failed, not as malloc failures.
7393 (gs_load): Use x_check_image_size.
7394
5f8f9cc2
PE
7395 * gtkutil.c: Omit integer casts.
7396 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7397 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7398
5adf60bc
PE
7399 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7400
c8907a93
PE
7401 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7402 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7403 would wrongly return t on a 64-bit host.
7404
e3c25c68
PE
7405 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7406 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7407 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7408 and therefore cause GCC to emit a bogus diagnostic in some cases.
7409
3f791afe
PE
7410 * image.c: Integer signedness and overflow and related fixes.
7411 This is not an exhaustive set of fixes, but it's time to
7412 record what I've got.
7413 (lookup_pixel_color, check_image_size): Remove redundant decls.
7414 (check_image_size): Don't assume that arbitrary EMACS_INT values
7415 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7416 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7417 (tiff_load, imagemagick_load_image):
7418 Check for overflow in size calculations.
7419 (x_create_x_image_and_pixmap): Remove unnecessary test for
7420 xmalloc returning NULL; that can't happen.
7421 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7422 (xpm_color_bucket): Use better integer hashing function.
7423 (xpm_cache_color): Don't possibly over-allocate memory.
7424 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7425 (gif_memory_source):
7426 Use ptrdiff_t, not int or size_t, to record sizes.
7427 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7428 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7429 either works, as we prefer signed integers.
7430 (tiff_read_from_memory, tiff_write_from_memory):
7431 Return tsize_t, not size_t, since that's what the TIFF API wants.
7432 (tiff_read_from_memory): Don't fail simply because the read would
7433 go past EOF; instead, return a short read.
7434 (tiff_load): Omit no-longer-needed casts.
7435 (Fimagemagick_types): Don't assume size fits into 'int'.
7436
3cc5a532
PE
7437 Improve hashing quality when configured --with-wide-int.
7438 * fns.c (hash_string): New function, taken from sxhash_string.
7439 Do not discard information about ASCII character case; this
7440 discarding is no longer needed.
7441 (sxhash-string): Use it. Change sig to match it. Caller changed.
7442 * lisp.h: Declare it.
7443 * lread.c (hash_string): Remove, since we now use fns.c's version.
7444 The fns.c version returns a wider integer if --with-wide-int is
7445 specified, so this should help the quality of the hashing a bit.
7446
b312a492
PE
7447 * emacs.c: Integer overflow minor fix.
7448 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7449 Define only if GNU_LINUX.
7450 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7451
dfd153ae
PE
7452 * dispnew.c: Integer signedness and overflow fixes.
7453 Remove unnecessary forward decls, that were a maintenance hassle.
7454 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7455 All uses changed.
7456 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7457 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7458 (prepare_desired_row, line_draw_cost):
7459 Use int, not unsigned, where either works.
7460 (save_current_matrix, restore_current_matrix):
7461 Use ptrdiff_t, not size_t, where either works.
7462 (init_display): Check for overflow more accurately, and without
7463 relying on undefined behavior.
7464
a81d11a3
PE
7465 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7466 Remove, replacing with the new symbols in lisp.h. All uses changed.
7467 * fileio.c (make_temp_name):
7468 * filelock.c (lock_file_1, lock_file):
7469 * xdisp.c (message_dolog):
7470 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7471 Use pMd etc. instead.
7472 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7473 replacing the pWIDE etc. symbols removed from editfns.c.
7474
3300e6fd
PE
7475 * keyboard.h (num_input_events): Now uintmax_t.
7476 This is (very slightly) less likely to mess up due to wraparound.
7477 All uses changed.
7478
fd05c7e9
PE
7479 * buffer.c: Integer signedness fixes.
7480 (alloc_buffer_text, enlarge_buffer_text):
7481 Use ptrdiff_t rather than size_t when either will do, as we prefer
7482 signed integers.
7483
903fe15d
PE
7484 * alloc.c: Integer signedness and overflow fixes.
7485 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7486 (__malloc_size_t): Default to size_t, not to int.
7487 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7488 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7489 Prefer ptrdiff_t to size_t when either would do, as we prefer
7490 signed integers.
7491 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7492 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7493 Now const. Initialize with values that are in range even if char
7494 is signed.
7495 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7496 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7497 These functions do the right thing with sizes > 2**32.
7498 (check_depth): Now ptrdiff_t, not int.
7499 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7500 Adjust to new way of storing sizes. Check for size overflow bugs
7501 in rest of code.
7502 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7503 slightly wrong anyway, as it missed one instance of
7504 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7505 (refill_memory_reserve): Omit needless cast to size_t.
7506 (mark_object_loop_halt): Mark as externally visible.
7507
ac82cc6a
PE
7508 * xselect.c: Integer signedness and overflow fixes.
7509 (Fx_register_dnd_atom, x_handle_dnd_message):
7510 Use ptrdiff_t, not size_t, since we prefer signed.
7511 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7512 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7513 x_dnd_atoms_size and x_dnd_atoms_length.
7514
c2d1e36d
PE
7515 * doprnt.c: Prefer signed to unsigned when either works.
7516 * eval.c (verror):
7517 * doprnt.c (doprnt):
7518 * lisp.h (doprnt):
7519 * xdisp.c (vmessage):
7520 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7521 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7522 prefer signed arithmetic to avoid comparison confusion.
7523 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7524 but is a bit tricky.
7525
0e926e56
PE
7526 Assume freestanding C89 headers, string.h, stdlib.h.
7527 * data.c, doprnt.c, floatfns.c, print.c:
7528 Include float.h unconditionally.
7529 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7530 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7531 * regex.c: Likewise for stddef.h, string.h.
7532 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7533 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7534 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7535 (STDC_HEADERS): Remove obsolete defines.
7536 * sysdep.c: Include limits.h unconditionally.
7537
9cfdb3ec
PE
7538 Assume support for memcmp, memcpy, memmove, memset.
7539 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7540 * regex.c (memcmp, memcpy):
7541 Remove; we assume C89 now.
7542
7543 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7544 (__malloc_safe_bcopy): Remove; no longer needed.
7545
cf950e6b 7546 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7547 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7548 well either way, and we prefer signed to unsigned.
7549
dbf38e02
LMI
75502011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7551
7552 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7553 closes the connection while we're reading (bug#9182).
7554
d6f0886c 75552011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7556
d6f0886c
JD
7557 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7558 are specified (Bug#9168).
24e0f6b1 7559
2eb1f9e6
PE
75602011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7561
7562 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7563 Found by GCC static checking and --with-wide-int on a 32-bit host.
7564
22381272 75652011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7566
7567 * xdisp.c (compute_display_string_pos): Fix logic of caching
7568 previous display string position. Initialize cached_prev_pos to
7569 -1. Fixes slow-down at the beginning of a buffer.
7570
f25e39b4
EZ
75712011-07-24 Eli Zaretskii <eliz@gnu.org>
7572
7573 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7574 for attrs[LFACE_FONTSET_INDEX].
7575
04c4b52e
PE
75762011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7577
7578 * xml.c (parse_region): Remove unused local
7579 that was recently introduced.
7580
c1734fbd
EZ
75812011-07-23 Eli Zaretskii <eliz@gnu.org>
7582
be18c5a5
EZ
7583 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7584 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7585
c1734fbd
EZ
7586 * xdisp.c (move_it_in_display_line_to): Record the best matching
7587 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7588 exit if none of the characters scanned was an exact match.
7589 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7590 when exact match is impossible due to invisible text, and the
7591 lines are truncated.
7592
a258d627
JD
75932011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7594
7595 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7596 for OSX >= 10.7.
7597
b6d5a689
EZ
75982011-07-22 Eli Zaretskii <eliz@gnu.org>
7599
0f74f785
EZ
7600 Fix a significant slow-down of cursor motion with C-n, C-p,
7601 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7602 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7603 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7604 (next_element_from_buffer): Call compute_stop_pos_backwards to
7605 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7606 base_level_stop.
7607 (reseat): Don't look for prev_stop, as that could mean a very long
7608 run.
7609 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7610 <cached_disp_overlay_modiff>: Cache for last found display string
7611 position.
551918c1 7612 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7613 about the same buffer in the same area of character positions, and
7614 the buffer wasn't changed since the time the display string
7615 position was cached.
551918c1 7616
b2d0c91a
EZ
76172011-07-22 Eli Zaretskii <eliz@gnu.org>
7618
7619 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7620 is an integer, which is important for empty lines. (Bug#9149)
7621
043604ee
CY
76222011-07-22 Chong Yidong <cyd@stupidchicken.com>
7623
7624 * frame.c (Fmodify_frame_parameters): In tty case, update the
7625 default face if necessary (Bug#4238).
7626
da4adb04
CY
76272011-07-21 Chong Yidong <cyd@stupidchicken.com>
7628
7629 * editfns.c (Fstring_to_char): No need to explain what a character
7630 is in the docstring (Bug#6576).
7631
9abd0532
LMI
76322011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7633
7634 * xml.c (parse_region): Make sure we always return a tree.
7635
36881d16
HK
76362011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7637
7638 * xml.c (parse_region): If a document contains only comments,
7639 return that, too.
7640
1e98674d
LMI
76412011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7642
7643 * xml.c (make_dom): Return comments, too.
7644
590bd467
PE
76452011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7646
7647 Port to OpenBSD.
7648 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7649 and the surrounding thread.
7650 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7651 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7652 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7653 timer goes off.
7654 * s/openbsd.h (BROKEN_SIGIO): Define.
7655 * unexelf.c (unexec) [__OpenBSD__]:
7656 Don't update the .mdebug section of the Alpha COFF symbol table.
7657
f41628b2
LMI
76582011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7659
7660 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7661 (bug#8460).
7662
b59b67c5
PE
76632011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7664
15e3a074
PE
7665 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7666 This fixes some race conditions on the permissions of any newly
7667 created file.
7668
41bed37d
PE
7669 * alloc.c (valid_pointer_p): Use pipe, not open.
7670 This fixes some permissions issues when debugging.
7671
b59b67c5
PE
7672 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7673 If fchown fails to set both uid and gid, try to set just gid,
7674 as that is sometimes allowed. Adjust the file's mode to eliminate
7675 setuid or setgid bits that are inappropriate if fchown fails.
7676
925a6be7
SM
76772011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7678
7679 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7680 to compare Lisp_Objects.
7681 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7682 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7683 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7684
52968808
AS
76852011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7686
0a6a104b
AS
7687 * lread.c (read_integer): Unread even EOF character.
7688 (read1): Likewise. Properly record start position of symbol.
7689
52968808
AS
7690 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7691 symbol character follows.
7692
9e381cdd
PE
76932011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7694
7695 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7696 This works around a problem with the previous change to Fcopy_file.
7697 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7698 and without this change, GCC might complain about discarding
7699 fchown's return value.
7700
b5641435
JB
77012011-07-16 Juanma Barranquero <lekktu@gmail.com>
7702
7703 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7704
a8031457
PE
77052011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7706
7707 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7708
dd889327
LMI
77092011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7710
750c33f7
LMI
7711 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7712 it's used from the C level.
7713
dd889327
LMI
7714 * process.c: Use the same condition for POLL_FOR_INPUT in both
7715 keyboard.c and process.c (bug#1858).
7716
87e86684
LM
77172011-07-09 Lawrence Mitchell <wence@gmx.li>
7718
7719 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7720 (Fgnutls_boot): Use it.
7721
64348f40
AS
77222011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7723
7724 * doc.c (Fsubstitute_command_keys): Revert last change.
7725
1d698799
LMI
77262011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7727
f863868c
LMI
7728 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7729 quotes the next character, and doesn't affect other longer
7730 sequences (bug#8935).
7731
1d698799
LMI
7732 * lread.c (syms_of_lread): Clarify that is isn't only
7733 `eval-buffer' and `eval-defun' that's affected by
7734 `lexical-binding' (bug#8460).
7735
aa4b6df6
EZ
77362011-07-15 Eli Zaretskii <eliz@gnu.org>
7737
7738 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7739 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7740
5d856da6
PE
77412011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7742
ad6042bb
PE
7743 Fix minor problems found by static checking.
7744 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7745 (elsz): Now a signed constant, not a size_t var. We prefer signed
7746 types to unsigned, to avoid integer comparison confusion. Without
7747 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7748 "cannot optimize loop, the loop counter may overflow", a symptom
7749 of the confusion.
f00bbb22 7750 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7751 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7752
6468f31c
LMI
77532011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7754
49080b10
LMI
7755 * search.c (Fre_search_backward): Mention `case-fold-search' in
7756 all the re_search_* functions (bug#8138).
7757
6468f31c
LMI
7758 * keyboard.c (Fopen_dribble_file): Document when the file is
7759 closed (bug#8056).
7760
c965adc5
EZ
77612011-07-14 Eli Zaretskii <eliz@gnu.org>
7762
df9733bf
EZ
7763 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7764 bidi_cache_idx.
7765
0bb23927
EZ
7766 Support bidi reordering of display and overlay strings.
7767 * xdisp.c (compute_display_string_pos)
7768 (compute_display_string_end): Accept additional argument STRING.
7769 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7770 (reseat_to_string): Initialize bidi_it->string.s and
7771 bidi_it->string.schars.
7772 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7773 NULL (avoids a crash in bidi_paragraph_init).
7774 Initialize itb.string.lstring.
0bb23927
EZ
7775 (init_iterator): Call bidi_init_it only of a valid
7776 buffer position was specified. Initialize paragraph_embedding to
7777 L2R.
7778 (reseat_to_string): Initialize the bidi iterator.
7779 (display_string): If we need to ignore text properties of
7780 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7781 original value of -1 will not work with bidi.)
7782 (compute_display_string_pos): First arg is now struct
7783 `text_pos *'; all callers changed. Support display properties on
7784 Lisp strings.
7785 (compute_display_string_end): Support display properties on Lisp
7786 strings.
7787 (init_iterator, reseat_1, reseat_to_string): Initialize the
7788 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7789 when iterating on a string not from display properties).
640c8776
SM
7790 (compute_display_string_pos, compute_display_string_end):
7791 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7792 arrow keys.
7793 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7794 base_level_stop; instead, set base_level_stop to BEGV.
7795 Fixes crashes in vertical-motion.
0bb23927
EZ
7796 (next_element_from_buffer): Improve commentary for when
7797 the iterator is before prev_stop.
7798 (init_iterator): Initialize bidi_p from the default value of
7799 bidi-display-reordering, not from buffer-local value. Use the
7800 buffer-local value only if initializing for buffer iteration.
7801 (handle_invisible_prop): Support invisible properties on strings
7802 that are being bidi-reordered.
7803 (set_iterator_to_next): Support bidi reordering of C strings and
7804 Lisp strings.
7805 (next_element_from_string): Support bidi reordering of Lisp
7806 strings.
7807 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7808 (display_string): Support display of R2L glyph rows.
7809 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7810 (init_iterator): Don't initialize it->bidi_p for strings
7811 here.
7812 (reseat_to_string): Initialize it->bidi_p for strings here.
7813 (next_element_from_string, next_element_from_c_string)
7814 (next_element_from_buffer): Add xassert's for correspondence
7815 between IT's object being iterated and it->bidi_it.string
7816 structure.
7817 (face_before_or_after_it_pos): Support bidi iteration.
7818 (next_element_from_c_string): Handle the case of the first string
7819 character that is not the first one in the visual order.
7820 (get_visually_first_element): New function, refactored from common
7821 parts of next_element_from_buffer, next_element_from_string, and
7822 next_element_from_c_string.
7823 (tool_bar_lines_needed, redisplay_tool_bar)
7824 (display_menu_bar): Force left-to-right direction. Add a FIXME
7825 comment for making that be controlled by a user option.
7826 (push_it, pop_it): Save and restore the state of the
7827 bidi iterator. Save and restore the bidi_p flag.
7828 (pop_it): Iterate out of display property for string iteration as
7829 well.
7830 (iterate_out_of_display_property): Support iteration over strings.
7831 (handle_single_display_spec): Set up it->bidi_it for iteration
7832 over a display string, and call bidi_init_it.
7833 (handle_single_display_spec, next_overlay_string)
7834 (get_overlay_strings_1, push_display_prop): Set up the bidi
7835 iterator for displaying display or overlay strings.
7836 (forward_to_next_line_start): Don't use the shortcut if
7837 bidi-iterating.
7838 (back_to_previous_visible_line_start): If handle_display_prop
7839 pushed the iterator stack, restore the internal state of the bidi
7840 iterator by calling bidi_pop_it same number of times.
7841 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7842 and we are bidi-iterating, don't decrement the iterator position;
7843 instead, set the first_elt flag in the bidi iterator, to produce
7844 the same effect.
7845 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7846 (push_display_prop): xassert that we are iterating a buffer.
7847 (push_it, pop_it): Save and restore paragraph_embedding member.
7848 (handle_single_display_spec, next_overlay_string)
7849 (get_overlay_strings_1, reseat_1, reseat_to_string)
7850 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7851 correctly. Don't assume unibyte strings are not bidi-reordered.
7852 (compute_display_string_pos)
7853 (compute_display_string_end): Fix handling the case of C string.
7854 (push_it, pop_it): Save and restore from_disp_prop_p.
7855 (handle_single_display_spec, push_display_prop): Set the
7856 from_disp_prop_p flag.
7857 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7858 (pop_it): Call iterate_out_of_display_property only if we are
7859 popping after iteration over a string that came from a display
7860 property. Fix a typo in popping stretch info. Add an assertion
7861 for verifying that the iterator position is in sync with the bidi
7862 iterator.
7863 (handle_single_display_spec, get_overlay_strings_1)
7864 (push_display_prop): Fix initialization of paragraph direction for
7865 string when that of the parent object is not yet determined.
7866 (reseat_1): Call bidi_init_it to resync the bidi
7867 iterator with IT's position. (Bug#7616)
7868 (find_row_edges): If ROW->start.pos gives position
7869 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7870 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7871 Reset the from_disp_prop_p flag.
7872 (SAVE_IT, RESTORE_IT): New macros.
7873 (pos_visible_p, face_before_or_after_it_pos)
7874 (back_to_previous_visible_line_start)
7875 (move_it_in_display_line_to, move_it_in_display_line)
7876 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7877 (try_scrolling, redisplay_window, display_line): Use them when
7878 saving a temporary copy of the iterator and restoring it back.
7879 (back_to_previous_visible_line_start, reseat_1)
7880 (init_iterator): Empty the bidi cache "stack".
7881 (move_it_in_display_line_to): If iterator ended up at
7882 EOL, but we never saw any buffer positions smaller than
7883 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7884 motion in bidi-reordered lines.
7885 (move_it_in_display_line_to): Record prev_method and prev_pos
7886 immediately before the call to set_iterator_to_next. Fixes cursor
7887 motion in bidi-reordered lines with stretch glyphs and strings
7888 displayed in margins. (Bug#8133) (Bug#8867)
7889 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7890 TO_CHARPOS.
640c8776
SM
7891 (pos_visible_p): Support positions in bidi-reordered lines.
7892 Save and restore bidi cache.
0bb23927
EZ
7893
7894 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7895 (bidi_paragraph_info): Delete unused struct.
7896 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7897 (bidi_cache_start): New variable.
7898 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7899 to zero.
7900 (bidi_cache_fetch_state, bidi_cache_search)
7901 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7902 (bidi_cache_find, bidi_peek_at_next_level)
7903 (bidi_level_of_next_char, bidi_find_other_level_edge)
7904 (bidi_move_to_visually_next): Compare cache index with
7905 bidi_cache_start rather than with zero.
7906 (bidi_fetch_char): Accept new argument STRING; all callers
7907 changed. Support iteration over a string. Support strings with
7908 display properties. Support unibyte strings. Fix the type of
7909 `len' according to what STRING_CHAR_AND_LENGTH expects.
7910 (bidi_paragraph_init, bidi_resolve_explicit_1)
7911 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7912 (bidi_level_of_next_char, bidi_move_to_visually_next):
7913 Support iteration over a string.
0bb23927
EZ
7914 (bidi_set_sor_type, bidi_resolve_explicit_1)
7915 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7916 can now be zero (for strings); special values 0 and -1 were
7917 changed to -1 and -2, respectively.
7918 (bidi_char_at_pos): New function.
7919 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7920 Call it instead of FETCH_MULTIBYTE_CHAR.
7921 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7922 initialized to valid values.
7923 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7924 values.
7925 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7926 the test for valid cached positions. Fix the logic for looking up
7927 the sentinel state in the cache. GCPRO the Lisp string we are
7928 iterating.
7929 (bidi_push_it, bidi_pop_it): New functions.
7930 (bidi_initialize): Initialize the bidi cache start stack pointer.
7931 (bidi_cache_ensure_space): New function, refactored from part of
7932 bidi_cache_iterator_state. Don't assume the required size is just
7933 one BIDI_CACHE_CHUNK away.
7934 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7935 (bidi_count_bytes, bidi_char_at_pos): New functions.
7936 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7937 always valid if bidi_cache_idx is valid.
7938 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7939 is valid if it's going to be used.
7940 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7941 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7942 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7943 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7944 (bidi_find_other_level_edge, bidi_cache_start_stack):
7945 All variables related to cache indices are now EMACS_INT.
c965adc5 7946
0bb23927
EZ
7947 * dispextern.h (struct bidi_string_data): New structure.
7948 (struct bidi_it): New member `string'. Make flag members be 1-bit
7949 fields, and put them last in the struct.
640c8776
SM
7950 (compute_display_string_pos, compute_display_string_end):
7951 Update prototypes.
0bb23927
EZ
7952 (bidi_push_it, bidi_pop_it): Add prototypes.
7953 (struct iterator_stack_entry): New members bidi_p,
7954 paragraph_embedding, and from_disp_prop_p.
7955 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7956 (bidi_shelve_cache, bidi_unshelve_cache):
7957 Declare prototypes.
0bb23927
EZ
7958
7959 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7960 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7961 and vector-like objects.
7962
7963 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7964 cache around display iteration.
7965
7966 * window.c (Fwindow_end, window_scroll_pixel_based)
7967 (displayed_window_lines, Frecenter): Save and restore the bidi
7968 cache around display iteration.
7969
3bbd2265
LMI
79702011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7971
7972 * editfns.c (Fdelete_region): Clarify the use of the named
7973 parameters (bug#6788).
7974
adc47434
MR
79752011-07-14 Martin Rudalics <rudalics@gmx.at>
7976
7977 * indent.c (Fvertical_motion): Set and restore w->pointm when
7978 saving and restoring the window's buffer (Bug#9006).
7979
837c31f8
LMI
79802011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7981
7982 * editfns.c (Fstring_to_char): Clarify just what is returned
7983 (bug#6576). Text by Eli Zaretskii.
7984
ac389d0c
JB
79852011-07-13 Juanma Barranquero <lekktu@gmail.com>
7986
7987 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7988
0be0ce47
EZ
79892011-07-13 Eli Zaretskii <eliz@gnu.org>
7990
7991 * buffer.c (mmap_find): Fix a typo.
7992
cd18e7e3
JB
79932011-07-13 Johan Bockgård <bojohan@gnu.org>
7994
7995 Fix execution of x selection hooks.
7996 * xselect.c (Qx_lost_selection_functions)
7997 (Qx_sent_selection_functions): New vars.
7998 (syms_of_xselect): DEFSYM them.
7999 (x_handle_selection_request): Pass Qx_sent_selection_functions
8000 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8001 (x_handle_selection_clear,x_clear_frame_selections):
8002 Pass Qx_lost_selection_functions rather than
8003 Vx_lost_selection_functions to Frun_hook_with_args.
8004
47ea7f44
PE
80052011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8006
ac389d0c 8007 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8008 The old code sometimes used this field without initializing it.
8009
47ea7f44
PE
8010 * alloc.c (gc_sweep): Don't read past end of array.
8011 In theory, the old code could also have corrupted Emacs internals,
8012 though it'd be very unlikely.
8013
bc985c87
AS
80142011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8015
8016 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8017 argument. (Bug#4026)
bc985c87 8018
0cf34688
LMI
80192011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8020
b3dadd76
LMI
8021 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8022 key" (bug#4257).
8023
0cf34688
LMI
8024 * window.c (Fset_window_start): Doc fix (bug#4199).
8025 (Fset_window_hscroll): Ditto.
8026
270768cd
PE
80272011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8028
077e3dda 8029 Fix minor new problems caught by GCC 4.6.1.
270768cd 8030 * term.c (init_tty): Remove unused local.
490011a6 8031 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8032 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8033 not used otherwise.
270768cd 8034
b1f58454
CY
80352011-07-12 Chong Yidong <cyd@stupidchicken.com>
8036
8037 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8038
22b9578d
LMI
80392011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8040
6e70ab07
LMI
8041 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8042 are the mini-buffer and the echo area (bug#3320).
8043
22b9578d
LMI
8044 * term.c (init_tty): Remove support for supdup, c10 and perq
8045 terminals, which are no longer supported (bug#1482).
8046
8974cc9f
JB
80472011-07-10 Johan Bockgård <bojohan@gnu.org>
8048
8049 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8050
a560d974
JD
80512011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8052
8053 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8054 for non-popups (Bug#3642).
8055
1dae0f0a
AS
80562011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8057
268c2c36 8058 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8059 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8060 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8061 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8062 * data.c (fmod): Likewise.
8063 * dispnew.c (swap_glyphs_in_rows): Likewise.
8064 * emacs.c (memory_warning_signal): Likewise.
8065 * floatfns.c (float_error): Likewise.
8066 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8067 (otf_open, font_otf_capability, generate_otf_features)
8068 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8069 Likewise.
8070 * image.c (pbm_read_file): Likewise.
8071 * indent.c (string_display_width): Likewise.
8072 * intervals.c (check_for_interval, search_for_interval)
8073 (inc_interval_count, count_intervals, root_interval)
8074 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8075 * lread.c (defalias): Likewise.
268c2c36 8076 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8077 * regex.c (set_image_of_range_1, set_image_of_range)
8078 (regex_grow_registers): Likewise.
8079 * sysdep.c (strerror): Likewise.
8080 * termcap.c (valid_filename_p, tprint, main): Likewise.
8081 * tparam.c (main): Likewise.
8082 * unexhp9k800.c (run_time_remap, save_data_space)
8083 (update_file_ptrs, read_header, write_header, calculate_checksum)
8084 (copy_file, copy_rest, display_header): Likewise.
8085 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8086 Likewise.
8087 * xdisp.c (check_it): Likewise.
8088 * xfaces.c (register_color, unregister_color, unregister_colors):
8089 Likewise.
8090 * xfns.c (print_fontset_result): Likewise.
8091 * xrdb.c (member, fatal, main): Likewise.
8092
99033785
PE
80932011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8094
8095 Fix minor problems found by static checking (Bug#9031).
8096 * chartab.c (char_table_set_range, map_sub_char_table):
8097 Remove unused locals.
8098 (uniprop_table): Now static.
8099 * composite.c (_work_char): Remove unused static var.
8100
9cb2ac56
JB
81012011-07-09 Juanma Barranquero <lekktu@gmail.com>
8102
8103 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8104
f25661f0
JD
81052011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8106
8107 * gtkutil.c (qttip_cb): Remove code without function.
8108
8278c4fe
EZ
81092011-07-09 Eli Zaretskii <eliz@gnu.org>
8110
8111 * w32.c (pthread_sigmask): New stub.
8112
1692ae2d 81132011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8114
8a6ebd58 8115 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8116 sigprocmask is portable only for single-threaded applications, and
8117 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8118 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8119 (LIBES): Use it.
8120 * callproc.c (Fcall_process):
8121 * process.c (create_process):
8122 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8123 Use pthread_sigmask, not sigprocmask.
123403e4 8124
1b854618
JD
81252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8126
8127 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8128 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8129 wrong (Bug#8591).
8130
3fe4b549
JD
81312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8132
0ce7e563
JD
8133 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8134 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8135 (xg_hide_tooltip): Fix comment.
8136
3fe4b549
JD
8137 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8138 in registerServicesMenuSendTypes.
8139 (validRequestorForSendType): Don't check ns_return_types.
8140
8141 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8142 ns_return_type.
8143
5df75e47
JR
81442011-07-08 Jason Rumney <jasonr@gnu.org>
8145
22610910
JR
8146 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8147 SH_SHOW for hidden windows (Bug#5482).
8148
5df75e47
JR
8149 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8150 frame struct members of non-existent frames (Bug#6284).
8151
699c10bd
JD
81522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8153
4393663b
JD
8154 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8155 variable firstTime not needed on OSX >= 10.6.
8156 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8157 >= 10.5. Use setKnobProportion, setDoubleValue.
8158
8159 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8160 (MAC_OS_X_VERSION_10_5): Define if not defined.
8161 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8162 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8163 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8164
8165 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8166 cString and lossyCString on OSX >= 10.4.
4393663b 8167
58179cce 8168 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8169 sizeToFit on OSX >= 10.2.
8170
8171 * nsimage.m (allocInitFromFile): Don't use deprecated method
8172 bestRepresentationForDevice on OSX >= 10.6.
8173
8174 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8175 to avoid warning.
8176
8177 * emacs.c: Declare unexec_init_emacs_zone.
8178
a63e0781
JD
8179 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8180
699c10bd
JD
8181 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8182
8183 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8184 on svcsMenu (Bug#8842).
8185
8186 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8187 ns_return_types.
8188 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8189
8190 * nsterm.m (QUTF8_STRING): Declare.
8191 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8192 (validRequestorForSendType): Return type is (id).
8193 Change indexOfObjectIdenticalTo to indexOfObject.
8194 Check if we have local selection before returning self (Bug#8842).
8195 (writeSelectionToPasteboard): Put local selection into paste board
8196 if we have a local selection (Bug#8842).
8197 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8198
8199 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8200 (ns_get_local_selection): Declare.
8201
54e10184
LMI
82022011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8203
9888ff71
LMI
8204 * keymap.c (describe_map_tree): Don't insert a double newline at
8205 the end of the buffer (bug#1169) and return whether we inserted
8206 something.
8207
54e10184
LMI
8208 * callint.c (Fcall_interactively): Change "reading args" to
8209 "providing args" to try to clarify what it does (bug#1010).
8210
15fa4783
KH
82112011-07-07 Kenichi Handa <handa@m17n.org>
8212
8213 * composite.c (composition_compute_stop_pos): Ignore a static
8214 composition starting before CHARPOS (Bug#8915).
8215
8216 * xdisp.c (handle_composition_prop): Likewise.
8217
a8815b00
EZ
82182011-07-07 Eli Zaretskii <eliz@gnu.org>
8219
8220 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8221 (Bug#9015)
8222
ef7b981d 82232011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8224
8225 * character.h (unicode_category_t): New enum type.
8226
8227 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8228 (Qchar_code_property_table): New variable.
8229 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8230 (UNIPROP_COMPRESSED_FORM_P): New macros.
8231 (char_table_ascii): Uncompress the compressed values.
8232 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8233 Uncompress the compressed values.
ac389d0c 8234 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8235 (char_table_ref_and_range): Uncompress the compressed values.
8236 (sub_char_table_set): New arg is_uniprop. Callers changed.
8237 Uncompress the compressed values.
8238 (sub_char_table_set_range): Args changed. Callers changed.
8239 (char_table_set_range): Adjuted for the above change.
8240 (map_sub_char_table): Delete args default_val and parent. Add arg
8241 top. Give decoded values to a Lisp function.
640c8776 8242 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8243 values to a Lisp function. Gcpro more variables.
8244 (uniprop_table_uncompress)
8245 (uniprop_decode_value_run_length): New functions.
8246 (uniprop_decoder, uniprop_decoder_count): New variables.
8247 (uniprop_get_decoder, uniprop_encode_value_character)
8248 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8249 New functions.
8250 (uniprop_encoder, uniprop_encoder_count): New variables.
8251 (uniprop_get_encoder, uniprop_table)
8252 (Funicode_property_table_internal, Fget_unicode_property_internal)
8253 (Fput_unicode_property_internal): New functions.
8254 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8255 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8256 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8257 char-code-property-alist.
8258
640c8776 8259 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8260 Vunicode_category_table.
8261
640c8776 8262 * font.c (font_range): Adjust for the change of
c805dec0
KH
8263 Vunicode_category_table.
8264
76b397fb
DN
82652011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8266
8267 * m/iris4d.h: Remove file, move contents ...
8268 * s/irix6-5.h: ... here.
8269
22b4128e
PE
82702011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8271
8272 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8273 * alloc.c (mark_buffer):
8274 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8275 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8276 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8277 This isn't true in general, and it's particularly not true
8278 if Emacs is configured with --with-wide-int.
8279 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8280 New macros, used in the buffer.c change.
8281
869795d6
JD
82822011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8283
8284 * xsettings.c: Use both GConf and GSettings if both are available.
8285 (store_config_changed_event): Add comment.
8286 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8287 (store_tool_bar_style_changed): New functions.
5e617bc2 8288 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8289 (struct xsettings): Move font inside HAVE_XFT.
8290 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8291 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8292 Move inside HAVE_XFT.
640c8776 8293 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8294 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8295 also.
8296 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8297 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8298 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8299 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8300 (parse_settings): Move check for font inside HAVE_XFT.
8301 (read_settings, apply_xft_settings): Add comment.
8302 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8303 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8304 call store_font_name_changed.
8305 (xft_settings_event): Add comment.
8306 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8307 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8308 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8309 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8310 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8311 (xsettings_get_system_font, xsettings_get_system_normal_font):
8312 Add comment.
869795d6 8313
d8ed26bd
PE
83142011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8315
8316 Random fixes. E.g., (random) never returned negative values.
8317 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8318 subseconds part to the entropy, as that's a bit more random.
8319 Prefer signed to unsigned, since the signedness doesn't matter and
8320 in general we prefer signed. When given a limit, use a
8321 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8322 latter isn't right if USE_2_TAGS_FOR_INTS.
8323 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8324 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8325
cabf1cac
SM
83262011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8327
8328 * textprop.c (text_property_stickiness):
8329 Obey Vtext_property_default_nonsticky.
8330 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8331 * w32fns.c (syms_of_w32fns):
8332 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8333
6e9b2be9
PE
83342011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8335
8336 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8337 This is more efficient than Ffile_directory_p and avoids a minor race.
8338
90186c68
LMI
83392011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8340
7c301272
LMI
8341 * buffer.c (Foverlay_put): Say what the return value is
8342 (bug#7835).
8343
c4f2d8d4
LMI
8344 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8345 is a directory before asking whether to use the file name
8346 (bug#7564).
ad637907
LMI
8347 (barf_or_query_if_file_exists): Make the "File is a directory"
8348 error be more correct.
c4f2d8d4 8349
90186c68
LMI
8350 * fns.c (Frequire): Remove the mention of the .gz files, since
8351 that's installation-specific, but keep the mention of
8352 `get-load-suffixes'.
8353
da64016e
PE
83542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8355
8356 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8357 Report string overflow if the output is too long.
8358
7d47b580
JB
83592011-07-04 Juanma Barranquero <lekktu@gmail.com>
8360
a555cb87
JB
8361 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8362 (syms_of_gnutls): Remove duplicate DEFSYM for
8363 Qgnutls_bootprop_verify_hostname_error, an error for
8364 Qgnutls_bootprop_verify_error (which is no longer used).
8365
7d47b580
JB
8366 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8367 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8368 Also (re)move comments that are misplaced or no longer relevant.
8369
1e49bfab
LMI
83702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8371
8372 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8373
1485f4c0
CY
83742011-07-03 Chong Yidong <cyd@stupidchicken.com>
8375
8376 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8377 and background color parameters if they have been changed.
8378
a9ab721e
LMI
83792011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8380
8381 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8382
cf7cff57
PE
83832011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8384
2e13213d
PE
8385 * xsettings.c (SYSTEM_FONT): Define only when used.
8386 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8387
cf7cff57
PE
8388 * keymap.c (access_keymap_1): Now static.
8389
7a8e04f7
CY
83902011-07-02 Chong Yidong <cyd@stupidchicken.com>
8391
8392 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8393 leave any prefix arg for the up event (Bug#1586).
8394
61352f62
LMI
83952011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8396
69bb1ef7
LMI
8397 * lread.c (syms_of_lread): Mention single symbols defined by
8398 `defvar' or `defconst' (bug#7154).
8399
61352f62 8400 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8401 (Frequire): Mention get-load-suffixes.
61352f62 8402
28545e04
MR
84032011-07-02 Martin Rudalics <rudalics@gmx.at>
8404
8405 * window.h (window): Remove clone_number slot.
8406 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8407 Remove.
8408 (make_parent_window, make_window, saved_window)
8409 (Fset_window_configuration, save_window_save): Don't deal with
8410 clone numbers.
8411 * buffer.c (Qclone_number): Remove declaration.
8412 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8413
3349e122
SM
84142011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8415
8416 Add multiple inheritance to keymaps.
8417 * keymap.c (Fmake_composed_keymap): New function.
8418 (Fset_keymap_parent): Simplify.
8419 (fix_submap_inheritance): Remove.
8420 (access_keymap_1): New function extracted from access_keymap to handle
8421 embedded parents and handle lists of maps.
8422 (access_keymap): Use it.
8423 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8424 (Fcopy_keymap): Handle embedded parents.
8425 (Fcommand_remapping, define_as_prefix): Simplify.
8426 (Fkey_binding): Simplify.
8427 (syms_of_keymap): Move minibuffer-local-completion-map,
8428 minibuffer-local-filename-completion-map,
8429 minibuffer-local-must-match-map, and
8430 minibuffer-local-filename-must-match-map to Elisp.
8431 (syms_of_keymap): Defsubr make-composed-keymap.
8432 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8433 (parse_menu_item): Trivial simplification.
8434
3279eb87
GM
84352011-07-01 Glenn Morris <rgm@gnu.org>
8436
8437 * Makefile.in (SETTINGS_LIBS): Fix typo.
8438
4550efdf
KI
84392011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8440
8441 * coding.c (Fencode_coding_string): Record the last coding system
8442 used, as the function doc string says (bug#8738).
8443
0949d2b6
JD
84442011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8445
8446 * xsettings.c (store_monospaced_changed): Take new font as arg and
8447 check for change against current_mono_font.
8448 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8449 (emacs_settings_constructor, emacs_settings_get_property)
8450 (emacs_settings_set_property, emacs_settings_class_init)
8451 (emacs_settings_init, gsettings_obj): Remove.
8452 (something_changedCB): New function for HAVE_GSETTINGS.
8453 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8454 with value as argument.
8455 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8456 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8457 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8458 "changed".
8459
8460 * xgselect.c: Add defined (HAVE_GSETTINGS).
8461 (xgselect_initialize): Ditto.
8462
8463 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8464 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8465 xg_select.
8466
bbc6b304
PE
84672011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8468
8469 * eval.c (struct backtrace): Simplify and port the data structure.
8470 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8471 signed bit field, as this assumption is not portable and it makes
8472 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8473 "char debug_on_exit : 1" as this is not portable either; instead,
8474 use the portable "unsigned int debug_on_exit : 1". Remove unused
8475 member evalargs. Remove obsolete comments about cc bombing out.
8476
9851bfc5
JD
84772011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8478
51bb811f 8479 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8480 Let HAVE_GSETTINGS override HAVE_GCONF.
8481 (store_monospaced_changed): New function.
8482 (EMACS_SETTINGS): A new type derived from GObject to handle
8483 GSettings notifications.
8484 (emacs_settings_constructor, emacs_settings_get_property)
8485 (emacs_settings_set_property, emacs_settings_class_init):
8486 New functions.
8487 (gsettings_client, gsettings_obj): New variables.
8488 (GSETTINGS_SCHEMA): New define.
8489 (something_changedCB): Call store_monospaced_changed.
8490 (init_gsettings): New function.
8491 (xsettings_initialize): Call init_gsettings.
8492 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8493 to NULL.
8494
640c8776 8495 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8496 GCONF_CFLAGS/LIBS.
8497
5386012d
MR
84982011-06-29 Martin Rudalics <rudalics@gmx.at>
8499
8500 * window.c (resize_root_window, grow_mini_window)
8501 (shrink_mini_window): Rename Qresize_root_window to
8502 Qwindow_resize_root_window and Qresize_root_window_vertically to
8503 Qwindow_resize_root_window_vertically.
8504
f13e0b08
PE
85052011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8506
8507 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8508
94515237
JB
85092011-06-27 Juanma Barranquero <lekktu@gmail.com>
8510
8511 * makefile.w32-in: Redesign dependencies so they reflect more
8512 clearly which files are directly included by each source file,
8513 and not through other includes.
8514
e43b6e43
MR
85152011-06-27 Martin Rudalics <rudalics@gmx.at>
8516
8517 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8518 (sort_overlays, overlay_strings): When an overlay's clone number
8519 matches the window's clone number process the overlay even if
8520 the overlay's window property doesn't match the current window.
8521
d68443dc
MR
8522 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8523 (Fwindow_hchild): Rename to Fwindow_left_child.
8524 (Fwindow_next): Rename to Fwindow_next_sibling.
8525 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8526 (resize_window_check): Rename to window_resize_check.
8527 (resize_window_apply): Rename to window_resize_apply.
8528 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8529 (Fdelete_other_windows_internal, resize_frame_windows)
8530 (Fsplit_window_internal, Fdelete_window_internal)
8531 (grow_mini_window, shrink_mini_window)
8532 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8533
c7e73be5
JD
85342011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8535
8536 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8537 (emacs_fixed_set_min_size): Remove.
8538 (emacs_fixed_new): Take frame as argument.
8539
8540 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8541 (_EmacsFixedPrivate): Remove minwidth/height.
8542 Add struct frame *f.
8543 (emacs_fixed_init): Initialize priv->f.
8544 (get_parent_class, emacs_fixed_set_min_size): Remove.
8545 (emacs_fixed_new): Set priv->f to argument.
8546 (emacs_fixed_get_preferred_width)
8547 (emacs_fixed_get_preferred_height): Use min_width/height from
8548 frames size_hint to set minimum and natural (Bug#8919).
8549 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8550 and use min_width/height from frames size_hint to set
8551 min_width/height (Bug#8919).
8552
8553 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8554 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8555 Fix indentation.
c7e73be5 8556
cf99dcf8
EZ
85572011-06-26 Eli Zaretskii <eliz@gnu.org>
8558
8559 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8560 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8561 called at ZV.
8562
029529ac
CY
85632011-06-26 Chong Yidong <cyd@stupidchicken.com>
8564
8565 * process.c (wait_reading_process_output): Bypass select if
8566 waiting for a cell while ignoring keyboard input, and input is
8567 pending. Suggested by Jan Djärv (Bug#8869).
8568
7a7ef429
PE
85692011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8570
8571 Use gnulib's dup2 module instead of rolling our own.
8572 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8573
11fdef7d 85742011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8575
8576 * dispnew.c (scrolling_window): Before scrolling, turn off a
8577 mouse-highlight in the window being scrolled.
8578
cd3520a4
JB
85792011-06-24 Juanma Barranquero <lekktu@gmail.com>
8580
8581 Move DEFSYM to lisp.h and use everywhere.
8582
8583 * character.h (DEFSYM): Move declaration...
8584 * lisp.h (DEFSYM): ...here.
8585
8586 * gnutls.c:
8587 * minibuf.c:
8588 * w32menu.c:
8589 * w32proc.c:
8590 * w32select.c: Don't include character.h.
8591
8592 * alloc.c (syms_of_alloc):
8593 * buffer.c (syms_of_buffer):
8594 * bytecode.c (syms_of_bytecode):
8595 * callint.c (syms_of_callint):
8596 * casefiddle.c (syms_of_casefiddle):
8597 * casetab.c (init_casetab_once):
8598 * category.c (init_category_once, syms_of_category):
8599 * ccl.c (syms_of_ccl):
8600 * cmds.c (syms_of_cmds):
8601 * composite.c (syms_of_composite):
8602 * dbusbind.c (syms_of_dbusbind):
8603 * dired.c (syms_of_dired):
8604 * dispnew.c (syms_of_display):
8605 * doc.c (syms_of_doc):
8606 * editfns.c (syms_of_editfns):
8607 * emacs.c (syms_of_emacs):
8608 * eval.c (syms_of_eval):
8609 * fileio.c (syms_of_fileio):
8610 * fns.c (syms_of_fns):
8611 * frame.c (syms_of_frame):
8612 * fringe.c (syms_of_fringe):
8613 * insdel.c (syms_of_insdel):
8614 * keymap.c (syms_of_keymap):
8615 * lread.c (init_obarray, syms_of_lread):
8616 * macros.c (syms_of_macros):
8617 * msdos.c (syms_of_msdos):
8618 * print.c (syms_of_print):
8619 * process.c (syms_of_process):
8620 * search.c (syms_of_search):
8621 * sound.c (syms_of_sound):
8622 * syntax.c (init_syntax_once, syms_of_syntax):
8623 * terminal.c (syms_of_terminal):
8624 * textprop.c (syms_of_textprop):
8625 * undo.c (syms_of_undo):
8626 * w32.c (globals_of_w32):
8627 * window.c (syms_of_window):
8628 * xdisp.c (syms_of_xdisp):
8629 * xfaces.c (syms_of_xfaces):
8630 * xfns.c (syms_of_xfns):
8631 * xmenu.c (syms_of_xmenu):
8632 * xsettings.c (syms_of_xsettings):
8633 * xterm.c (syms_of_xterm): Use DEFSYM.
8634
4228cf16
TZ
86352011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8636
cd3520a4 8637 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8638
7fcccf1e
PE
86392011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8640
7efb4e0e
PE
8641 Integer and buffer overflow fixes (Bug#8873).
8642
ff5844ad
PE
8643 * print.c (printchar, strout): Check for string overflow.
8644 (PRINTPREPARE, printchar, strout):
8645 Don't set size unless allocation succeeds.
8646
90532f02
PE
8647 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8648 for sizes. Check for string overflow more accurately.
8649 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8650
6d84508d
PE
8651 * macros.c: Integer and buffer overflow fixes.
8652 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8653 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8654 Use ptrdiff_t, not int, for sizes.
8655 Don't increment bufsize until after realloc succeeds.
8656 Check for size-calculation overflow.
8657 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8658
437b2cb4
PE
8659 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8660
8b9ac8b4
PE
8661 * lread.c: Integer overflow fixes.
8662 (read_integer): Radix is now EMACS_INT, not int,
8663 to improve quality of diagnostics for out-of-range radices.
8664 Calculate buffer size correctly for out-of-range radices.
8665 (read1): Check for integer overflow in radices, and in
8666 read-circle numbers.
82cb60d3
PE
8667 (read_escape): Avoid int overflow.
8668 (Fload, openp, read_buffer_size, read1)
8669 (substitute_object_recurse, read_vector, read_list, map_obarray):
8670 Use ptrdiff_t, not int, for sizes.
8671 (read1): Use EMACS_INT, not int, for sizes.
20270765 8672 Check for size overflow.
8b9ac8b4 8673
7fcccf1e
PE
8674 * image.c (cache_image): Check for size arithmetic overflow.
8675
bfbbd7e7
PE
8676 * lread.c: Integer overflow issues.
8677 (saved_doc_string_size, saved_doc_string_length)
8678 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8679 Now ptrdiff_t, not int.
8680 (read1): Don't assume doc string length fits in int. Check for
8681 out-of-range doc string lengths.
8682 (read_list): Don't assume file position fits in int.
39019e54 8683 (read_escape): Check for hex character overflow.
bfbbd7e7 8684
4e323265
LL
86852011-06-22 Leo Liu <sdl.web@gmail.com>
8686
8687 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8688 Move to minibuffer.el.
8689
85fece3e
PE
86902011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8691
20b84ce9 8692 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8693 The following patches are for when GLYPH_DEBUG && !XASSERT.
8694 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8695 * dispnew.c (flush_stdout):
8696 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8697 Mark as externally visible.
8698 * dispnew.c (check_window_matrix_pointers): Now static.
8699 * dispnew.c (window_to_frame_vpos):
8700 * xfns.c (unwind_create_frame):
8701 * xterm.c (x_check_font): Remove unused local.
8702 * scroll.c (CHECK_BOUNDS):
8703 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8704 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8705 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8706 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8707 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8708 Now static.
8709 (debug_method_add): Use va_list and vsprintf rather than relying
8710 on undefined behavior with wrong number of arguments.
8711 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8712 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8713 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8714 since we're not interested in debugging glyphs with old libraries.
8715 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8716 GCC 4.6.0's static checking.
8717
0766b489
PE
87182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8719
31fd4b32
PE
8720 Integer overflow and signedness fixes (Bug#8873).
8721 A few related buffer overrun fixes, too.
8722
b79e8648
PE
8723 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8724
0766b489
PE
8725 * dispextern.h (struct face.stipple):
8726 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8727 (x_bitmap_mask, x_allocate_bitmap_record)
8728 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8729 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8730 (x_create_bitmap_from_xpm_data):
8731 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8732 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8733 (.bitmaps_last):
8734 * xfaces.c (load_pixmap):
8735 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8736 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8737 (.bitmaps_last, struct x_output.icon_bitmap):
8738 Use ptrdiff_t, not int, for bitmap indexes.
8739 (x_allocate_bitmap_record): Check for size overflow.
8740 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8741
b081724f
PE
8742 Use ptrdiff_t, not int, for overlay counts.
8743 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8744 * editfns.c (overlays_around, get_pos_property):
8745 * textprop.c (get_char_property_and_overlay):
8746 * xdisp.c (next_overlay_change, note_mouse_highlight):
8747 * xfaces.c (face_at_buffer_position):
21514da7
PE
8748 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8749 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8750 (Fnext_overlay_change, Fprevious_overlay_change)
8751 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8752 Use ptrdiff_t, not int, for sizes.
21514da7 8753 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8754
3de73e5e
PE
8755 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8756
2606c57b
PE
8757 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8758 (x_session_initialize): Do not assume string length fits in int.
8759
aaafe47a
PE
8760 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8761 This is unlikely, but can occur if DPI is outlandish.
8762
2674ddc8 8763 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8764 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8765
28154962
PE
8766 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8767 * xrdb.c (magic_file_p, search_magic_path):
8768 Omit last arg SUFFIX; it was always 0. All callers changed.
8769 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8770
7de51af5
PE
8771 * xfont.c (xfont_match): Avoid need for strlen.
8772
25ed6cc3
PE
8773 * xfns.c: Don't assume strlen fits in int.
8774 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8775
4eab31dd
PE
8776 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8777 not unsigned long, as we prefer signed integers. All callers changed.
8778 Detect integer overflow in repeat count.
8779 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8780 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8781
171e2a58
PE
8782 * termcap.c: Don't assume sizes fit in int and never overflow.
8783 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8784 (gobble_line): Check for size-calculation overflow.
8785
ad39faca 8786 * minibuf.c (Fread_buffer):
6e5bb2dc 8787 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8788 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8789 Don't assume string length fits in int.
8790
52c61c22 8791 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8792 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8793
b5b8c9e5
PE
8794 * font.c: Don't assume string length fits in int.
8795 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8796 Use ptrdiff_t, not int.
ccd6111c
PE
8797 (font_intern_prop): Don't assume string length fits in int.
8798 Don't assume integer property fits in fixnum.
8799 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8800
882f0d81 8801 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8802 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8803 Reformulate so as not to need the command string.
8804 Invoke gzip -cd rather than gunzip, as it's more portable.
8805 (lock_info_type, lock_file_1, lock_file):
8806 Don't assume pid_t and time_t fit in unsigned long.
8807 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8808 (current_lock_owner): Prefer signed type for sizes.
8809 Use memcpy, not strncpy, where memcpy is what is really wanted.
8810 Don't assume (via atoi) that time_t and pid_t fit in int.
8811 Check for time_t and/or pid_t out of range, e.g., via a network share.
8812 Don't alloca where an auto var works fine.
8813
93f4cf88
PE
8814 * fileio.c: Fix some integer overflow issues.
8815 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8816 Don't assume string length fits in int.
8817 (directory_file_name): Don't assume string length fits in long.
8818 (make_temp_name): Don't assume pid fits in int, or that its print
8819 length is less than 20.
8820
f3e92b69
PE
8821 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8822
1bfdaf10
PE
8823 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8824
35016e9a
PE
8825 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8826
3d1e65a1
PE
8827 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8828 We prefer signed integers, even for size calculations.
8829
0b963a93
PE
8830 * emacs.c: Don't assume string length fits in 'int'.
8831 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8832 (main): Don't invoke strlen when not needed.
8833
573f4b54
PE
8834 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8835 (XD_DEBUG_MESSAGE): Don't waste a byte.
8836
989f33ba
PE
8837 * callproc.c (getenv_internal_1, getenv_internal)
8838 (Fgetenv_internal):
965d34eb
PE
8839 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8840
e4d29b33
PE
8841 * lread.c (invalid_syntax): Omit length argument.
8842 All uses changed. This doesn't fix a bug, but it simplifies the
8843 code away from its former Hollerith-constant appearance, and it's
8844 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8845 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8846
eb49b136
PE
8847 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8848 This didn't break anything, but it didn't help either.
8849 It's confusing to put a bogus integer in a place where the actual
8850 value does not matter.
9f62aeb1 8851 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8852 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8853
15375a22
PE
8854 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8855 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8856 implementation.
b61cc01c
PE
8857 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8858 We prefer signed types, and the value cannot exceed the EMACS_INT
8859 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8860 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8861 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8862 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8863
53b2623d
PE
8864 * indent.c (sane_tab_width): New function.
8865 (current_column, scan_for_column, Findent_to, position_indentation)
8866 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8867 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8868
51cab52b 8869 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8870
f2ed8a70
PE
8871 * lisp.h (lint_assume): New macro.
8872 * composite.c (composition_gstring_put_cache):
8873 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8874
abe80cc6
PE
8875 * editfns.c, insdel.c:
8876 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8877
b02c740e
PE
8878 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8879
ebc96716
PE
8880 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8881
b4e50fa0 8882 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8883 Use much-faster test for byte-length change.
311d5d7c 8884 Don't assume string byte-length fits in 'int'.
a4cf38e4 8885 Check that character arg fits in 'int'.
85461888 8886 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8887
c0c1ee9f
PE
8888 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8889
a498d7f4
PE
8890 * fns.c (concat): Catch string overflow earlier.
8891 Do not rely on integer wraparound.
8892
51cab52b
PE
8893 * dispextern.h (struct it.overlay_strings_charpos)
8894 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8895 * xdisp.c (forward_to_next_line_start)
8896 (back_to_previous_visible_line_start)
8897 (reseat_at_next_visible_line_start, next_element_from_buffer):
8898 Don't arbitrarily truncate the value of 'selective' to int.
8899
76031fad
PE
8900 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8901
5eb55db9
PE
8902 * composite.c: Don't truncate sizes to 'int'.
8903 (composition_gstring_p, composition_reseat_it)
8904 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8905 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8906 not EMACS_UINT, for indexes.
5eb55db9 8907
0703a717
PE
8908 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8909
d6202519
PE
8910 * buffer.c: Include <verify.h>.
8911 (struct sortvec.priority, struct sortstr.priority):
8961a454 8912 Now EMACS_INT, not int.
c20998a7 8913 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8914 (struct sortstr.size, record_overlay_string)
8915 (struct sortstrlist.size, struct sortlist.used):
8916 Don't truncate size to int.
8917 (record_overlay_string): Check for size-calculation overflow.
d6202519 8918 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8919
d5a19415
JM
89202011-06-22 Jim Meyering <meyering@redhat.com>
8921
029529ac 8922 Don't leak an XBM-image-sized buffer
d5a19415
JM
8923 * image.c (xbm_load): Free the image buffer after using it.
8924
a9041e6c
PE
89252011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8926
8927 Port to Sun C.
8928 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8929 that Sun C diagnosed.
8930 * fns.c (secure_hash): Fix pointer signedness issue.
8931 * intervals.c (static_offset_intervals): New function.
8932 (offset_intervals): Use it.
8933
7f3f739f
LL
89342011-06-21 Leo Liu <sdl.web@gmail.com>
8935
8936 * deps.mk (fns.o):
8937 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8938 sha512.h.
8939
8940 * fns.c (secure_hash): Rename from crypto_hash_function and change
8941 the first arg to accept symbols.
5b66d427 8942 (Fsecure_hash): New primitive.
7f3f739f
LL
8943 (syms_of_fns): New symbols.
8944
76147d94
DD
89452011-06-20 Deniz Dogan <deniz@dogan.se>
8946
8947 * process.c (Fset_process_buffer): Clarify return value in
8948 docstring.
8949
7d7d0045
CY
89502011-06-18 Chong Yidong <cyd@stupidchicken.com>
8951
8952 * dispnew.c (add_window_display_history): Use BVAR.
8953
8954 * xdisp.c (debug_method_add): Use BVAR.
8955 (check_window_end, dump_glyph_matrix, dump_glyph)
8956 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8957
8958 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8959 Likewise.
8960
8961 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8962 check till after the cache is created in init_frame_faces.
8963
ff2bc410
SM
89642011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8965
8966 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8967
28177add
PE
89682011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8969
dd3482fe
PE
8970 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8971 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8972 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8973
393d71f3 8974 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8975 * fileio.c (Finsert_file_contents):
8976 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8977 Remove the old (too-loose) buffer overflow checks.
8978 They weren't needed, since make_gap checks for buffer overflow.
8979 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8980 The old code merely checked for Emacs fixnum overflow, and relied
8981 on undefined (wraparound) behavior. The new code avoids undefined
8982 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8983
2e6813b0 8984 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8985 Tune. Don't use wider integers than needed. Don't use alloca.
8986 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8987
599a9e4f
PE
8988 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8989
99561444
PE
8990 * insdel.c, lisp.h (buffer_overflow): New function.
8991 (insert_from_buffer_1, replace_range, replace_range_2):
8992 * insdel.c (make_gap_larger):
8993 * editfns.c (Finsert_char):
8994 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8995
28177add
PE
8996 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8997
e69dafad
PE
89982011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8999
4baa020d 9000 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9001
b1c46f02
PE
9002 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9003 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9004
e69dafad
PE
9005 * fileio.c: Don't assume EMACS_INT fits in off_t.
9006 (emacs_lseek): New static function.
9007 (Finsert_file_contents, Fwrite_region): Use it.
9008 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9009
566684ea
PE
9010 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9011
e6966cd6
PE
9012 * fns.c: Don't overflow int when computing a list length.
9013 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9014 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9015 truncation on 64-bit hosts. Check for QUIT every
9016 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9017 faster and is responsive enough.
9018 (Flength): Report an error instead of overflowing an integer.
9019 (Fsafe_length): Return a float if the value is not representable
9020 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9021 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9022 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9023
dd0b0efb
PE
9024 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9025 (header_size, word_size): New constants.
9026 (allocate_vectorlike): Don't check size overflow here.
9027 (allocate_vector): Check it here instead, since this is the only
9028 caller of allocate_vectorlike that could cause overflow.
9029 Check that the new vector's length is representable as a fixnum.
9030
86fe5cfe
PE
9031 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9032 The previous code was bogus. For example, next_almost_prime (32)
9033 returned 39, which is undesirable as it is a multiple of 3; and
9034 next_almost_prime (24) returned 25, which is a multiple of 5 so
9035 why was the code bothering to check for multiples of 7?
9036
80e88859
PE
9037 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9038
4a2f0ad6
PE
9039 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9040
f66c7cf8
PE
9041 Variadic C functions now count arguments with ptrdiff_t.
9042 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9043 Back then I didn't know that the Emacs coding style prefers signed int.
9044 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9045 were being counted with int, which may truncate counts on 64-bit
9046 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9047 * lisp.h (struct Lisp_Subr.function.aMANY)
9048 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9049 Arg counts are now ptrdiff_t, not size_t.
9050 All variadic functions and their callers changed accordingly.
9051 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9052 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9053 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9054 * callint.c (Fcall_interactively): Check arg count for overflow,
9055 to avoid potential buffer overrun. Use signed char, not 'int',
9056 for 'varies' array, so that we needn't bother to check its size
9057 calculation for overflow.
9058 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9059 * eval.c (apply_lambda):
9060 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9061 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9062 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9063
a1759b76
PE
9064 * callint.c (Fcall_interactively): Don't use index var as event count.
9065
d96be9fc
PE
9066 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9067 * mem-limits.h (SIZE): Remove; no longer used.
9068
a690a978 9069 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9070
578c21e6
PE
9071 Remove unnecessary casts.
9072 * xterm.c (x_term_init):
9073 * xfns.c (x_set_border_pixel):
9074 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9075 These aren't needed now that we assume ANSI C.
9076
96f53c6c
PE
9077 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9078 It's more likely to cause problems (due to unsigned overflow)
9079 than to cure them.
9080
83c77d31
PE
9081 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9082
ee2079f1
PE
9083 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9084
6da65536
PE
9085 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9086
7147c4a4
PE
9087 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9088
193e32d9
PE
9089 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9090
e5533da6
PE
9091 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9092
9910e595
PE
9093 GLYPH_CODE_FACE returns EMACS_INT, not int.
9094 * dispextern.h (merge_faces):
9095 * xfaces.c (merge_faces):
01103c44
PE
9096 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9097 Don't assume EMACS_INT fits in int.
9910e595 9098
2638320e
PE
9099 * character.h (CHAR_VALID_P): Remove unused parameter.
9100 * fontset.c, lisp.h, xdisp.c: All uses changed.
9101
045eb8d9
PE
9102 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9103
c1f134b5
PE
9104 * fns.c (concat): Minor tuning based on overflow analysis.
9105 This doesn't fix any bugs. Use int to hold character, instead
9106 of constantly refetching from Emacs object. Use XFASTINT, not
9107 XINT, for value known to be a character. Don't bother comparing
9108 a single byte to 0400, as it's always less.
9109
395fcb93 9110 * floatfns.c (Fexpt):
327eeec8
PE
9111 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9112
abbd3d23
PE
9113 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9114 for characters.
9115
684a03ef
PE
9116 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9117
0fed43f3
PE
9118 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9119 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9120 incorrectly succeed when S was a string, because 4294967386 was
9121 truncated before it was used.
9122
8fd02eb7
PE
9123 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9124 Otherwise, an out-of-range integer could cause undefined behavior
9125 on a 64-bit host.
9126
f8c86b69
PE
9127 * composite.c: Use int, not EMACS_INT, for characters.
9128 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9129 EMACS_INT, for values that are known to be in character range.
9130 This doesn't fix any bugs but is the usual style inside Emacs and
9131 may generate better code on 32-bit machines.
9132
34206dd2
PE
9133 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9134 This is for reasons similar to the recent CHAR_STRING fix.
9135 * charset.c (Fencode_char): Check that character arg is actually
9136 a character. Pass an int to ENCODE_CHAR.
9137 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9138 wider than 'int', as a compile-time check to prevent future regressions
9139 in this area.
9140
c5958d4c 9141 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9142
9143 Make sure a 64-bit char is never passed to CHAR_STRING.
9144 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9145 by silently ignoring the top 32 bits, allowing some values
9146 that were far too large to be valid characters.
9147 * character.h: Include <verify.h>.
9148 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9149 arguments are no wider than unsigned, as a compile-time check
9150 to prevent future regressions in this area.
9151 * data.c (Faset):
01103c44 9152 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9153 (Fsubst_char_in_region):
9154 * fns.c (concat):
9155 * xdisp.c (decode_mode_spec_coding):
9156 Adjust to CHAR_STRING's new requirement.
9157 * editfns.c (Finsert_char, Fsubst_char_in_region):
9158 * fns.c (concat): Check that character args are actually
9159 characters. Without this test, these functions did the wrong
9160 thing with wildly out-of-range values on 64-bit hosts.
9161
d37ca623
PE
9162 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9163 These casts should not be needed on 32-bit hosts, either.
9164 * keyboard.c (read_char):
9165 * lread.c (Fload): Remove casts to unsigned.
9166
ea204efb
PE
9167 * lisp.h (UNSIGNED_CMP): New macro.
9168 This fixes comparison bugs on 64-bit hosts.
9169 (ASCII_CHAR_P): Use it.
9170 * casefiddle.c (casify_object):
01103c44 9171 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9172 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9173 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9174 * dispextern.h (FACE_FROM_ID):
9175 * keyboard.c (read_char): Use UNSIGNED_CMP.
9176
41cb286c
PE
9177 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9178 not to EMACS_INT, to avoid GCC warning.
9179
4a1b9832
PE
9180 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9181
55daad71
PE
9182 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9183 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9184 isn't needed on 32-bit machines.
8f95c75c 9185
01103c44
PE
9186 * buffer.c (Fgenerate_new_buffer_name):
9187 Use EMACS_INT for count, not int.
0ceccced 9188 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9189
9190 * data.c (Qcompiled_function): Now static.
9191
c6f072e7
PE
9192 * window.c (window_body_lines): Now static.
9193
20ce5912
PE
9194 * image.c (gif_load): Rename local to avoid shadowing.
9195
9c4c5f81
PE
9196 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9197 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9198 * alloc.c (make_save_value): Integer argument is now of type
9199 ptrdiff_t, not int.
9200 (mark_object): Use ptrdiff_t, not int.
9201 * lisp.h (pD): New macro.
9202 * print.c (print_object): Use it.
9203
c0c5c8ae
PE
9204 * alloc.c: Use EMACS_INT, not int, to count objects.
9205 (total_conses, total_markers, total_symbols, total_vector_size)
9206 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9207 (total_free_floats, total_floats, total_free_intervals)
9208 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9209 Now EMACS_INT, not int. All uses changed.
9210 (Fgarbage_collect): Compute overall total using a double, so that
9211 integer overflow is less likely to be a problem. Check for overflow
9212 when converting back to an integer.
5a25e253
PE
9213 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9214 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9215 These were 'int' variables that could overflow on 64-bit hosts;
9216 they were never used, so remove them instead of repairing them.
211a0b2a 9217 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9218 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9219 Previously, this ceilinged at INT_MAX, but that doesn't work on
9220 64-bit machines.
e46bb31a 9221 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9222
c78baabf 9223 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9224 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9225 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9226 when a (possibly-narrower) signed value would do just as well.
9227 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9228
c9d624c6
PE
9229 * alloc.c: Catch some string size overflows that we were missing.
9230 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9231 for convenience in STRING_BYTES_MAX.
9232 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9233 The definition here is exact; the one in lisp.h was approximate.
9234 (allocate_string_data): Check for string overflow. This catches
9235 some instances we weren't catching before. Also, it catches
9236 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9237 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9238 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9239
c9d624c6
PE
9240 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9241 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9242 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9243
353032ce
PE
9244 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9245
2bccce07
PE
9246 * alloc.c (Fmake_string): Check for out-of-range init.
9247
0ac30604
SM
92482011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9249
9250 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9251
c195f2de
JD
92522011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9253
9254 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9255 xg_get_default_scrollbar_width.
9256
9257 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9258 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9259 (style_changed_cb): Call update_theme_scrollbar_width and call
9260 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9261 all frames (Bug#8505).
9262 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9263 Call gtk_window_set_resizable if HAVE_GTK3.
9264 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9265 and height if HAVE_GTK3 (Bug#8505).
9266 (scroll_bar_width_for_theme): New variable.
9267 (update_theme_scrollbar_width): New function.
9268 (xg_get_default_scrollbar_width): Move code to
9269 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9270 (xg_initialize): Call update_theme_scrollbar_width.
9271
9272 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9273
9274 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9275
e10ac9f1
MR
92762011-06-12 Martin Rudalics <rudalics@gmx.at>
9277
9278 * frame.c (make_frame): Call other_buffer_safely instead of
9279 other_buffer.
9280
9281 * window.c (temp_output_buffer_show): Call display_buffer with
9282 second argument Vtemp_buffer_show_specifiers and reset latter
9283 immediately after the call.
9284 (Vtemp_buffer_show_specifiers): New variable.
9285 (auto_window_vscroll_p, next_screen_context_lines)
9286 (Vscroll_preserve_screen_position): Remove leading asterisks from
9287 doc-strings.
9288
2d3c217e 92892011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9290
7b7f97e8 9291 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9292 * buffer.c (Qclone_number): Remove for now, as it's unused.
9293 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9294 (record_buffer): Remove unused local.
9295 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9296 (set_frame_buffer_list): Remove; unused.
9297 * frame.h (other_visible_frames): Remove decl.
9298 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9299 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9300 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9301 if HAVE_GPM.
9302 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9303 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9304 Define only if HAVE_GPM.
9305 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9306 (update_hints_inhibit): Remove; never set. All uses removed.
9307 * widgetprv.h (emacsFrameClassRec): Remove decl.
9308 * window.c (delete_deletable_window): Now returns void, since it
9309 wasn't returning anything.
9310 (compare_window_configurations): Remove unused locals.
9311 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9312 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9313 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9314 the same widths as pointers. This follows up on the 2011-05-06 patch.
9315 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9316 * xterm.h: Likewise.
9317 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9318
1384b89e
JB
93192011-06-12 Juanma Barranquero <lekktu@gmail.com>
9320
9321 * makefile.w32-in: Update dependencies.
9322 (LISP_H): Add lib/intprops.h.
9323
1100a63c
CY
93242011-06-11 Chong Yidong <cyd@stupidchicken.com>
9325
9326 * image.c (gif_load): Add animation frame delay to the metadata.
9327 (syms_of_image): Use DEFSYM. New symbol `delay'.
9328
6198ccd0
MR
93292011-06-11 Martin Rudalics <rudalics@gmx.at>
9330
9331 * window.c (delete_deletable_window): Re-add.
9332 (Fset_window_configuration): Rewrite to handle dead buffers and
9333 consequently deletable windows.
9334 (window_tree, Fwindow_tree): Remove. Supply functionality in
9335 window.el.
9336 (compare_window_configurations): Simplify code.
9337
b6e3633c
AS
93382011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9339
1ab0dee5
AS
9340 * image.c (imagemagick_load_image): Fix type mismatch.
9341 (Fimagemagick_types): Likewise.
9342
b6e3633c
AS
9343 * window.h (replace_buffer_in_windows): Declare.
9344
9397e56f
MR
93452011-06-11 Martin Rudalics <rudalics@gmx.at>
9346
9347 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9348 Qclone_number. Remove external declaration of Qdelete_window.
9349 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9350 code.
640c8776
SM
9351 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9352 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9353 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9354 buffer list implementation.
9355 (other_buffer_safely): New function.
9356 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9357 calls to replace_buffer_in_windows and
9358 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9359 if allowed.
9360 (record_buffer): Inhibit quitting and rewrite using quittable
9361 functions. Run Qbuffer_list_update_hook if allowed.
9362 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9363 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9364 Move switch-to-buffer to window.el.
9397e56f
MR
9365 (bury-buffer): Move to window.el.
9366 (Vbuffer_list_update_hook): New variable.
9367
9368 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9369 section.
9370
9371 * window.h (resize_frame_windows): Move up in code.
9372 (Fwindow_frame): Remove EXFUN.
9373 (replace_buffer_in_all_windows): Remove prototype.
9374 (replace_buffer_in_windows_safely): Add prototype.
9375
9376 * window.c: Declare Qdelete_window static again. Move down
9377 declaration of select_count.
9378 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9379 (Fother_window): Move to window.el.
9380 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9381 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9382 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9383 window.el.
9384 (replace_buffer_in_windows): Implement by calling
9385 Qreplace_buffer_in_windows.
9386 (replace_buffer_in_all_windows): Remove with some functionality
9387 moved into replace_buffer_in_windows_safely.
9388 (replace_buffer_in_windows_safely): New function.
9389 (select_window_norecord, select_frame_norecord): Move in front
9390 of run_window_configuration_change_hook. Remove now obsolete
9391 declarations.
640c8776
SM
9392 (Fset_window_buffer): Rewrite doc-string.
9393 Call Qrecord_window_buffer.
9397e56f
MR
9394 (keys_of_window): Move binding for other-window to window.el.
9395
b50691aa
CY
93962011-06-11 Chong Yidong <cyd@stupidchicken.com>
9397
9398 * dispextern.h (struct image): Replace data member, whose int_val
9399 and ptr_val fields were not used by anything, with a single
9400 lisp_val object.
9401
9402 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9403 (gif_clear_image, gif_load, imagemagick_load_image)
9404 (gs_clear_image, gs_load): Callers changed.
9405
3f754b86
PE
94062011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9407
cca69397
PE
9408 * buffer.h: Include <time.h>, for time_t.
9409 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9410
109e28d0
PE
9411 Fix minor problems found by static checking.
9412
60737f02
PE
9413 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9414
4b66faf3
PE
9415 Make identifiers static if they are not used in other modules.
9416 * data.c (Qcompiled_function, Qframe, Qvector):
9417 * image.c (QimageMagick, Qsvg):
9418 * minibuf.c (Qmetadata):
9419 * window.c (resize_window_check, resize_root_window): Now static.
9420 * window.h (resize_window_check, resize_root_window): Remove decls.
9421
109e28d0
PE
9422 * window.c (window_deletion_count, delete_deletable_window):
9423 Remove; unused.
46a4ce9e
PE
9424 (window_body_lines): Now static.
9425 (Fdelete_other_windows_internal): Mark vars as initialized.
9426 Make sure 'resize_failed' is initialized.
9427 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9428 (resize_window_apply): Remove unused local.
9429 * window.h (delete_deletable_window): Remove decl.
9430
109e28d0 9431 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9432 (imagemagick_load_image): Fix pointer signedness problem by changing
9433 last arg from unsigned char * to char *. All uses changed.
9434 Also, fix a local for similar reasons.
9435 Remove unused locals. Remove locals to avoid shadowing.
9436 (fn_rsvg_handle_free): Remove; unused.
9437 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9438 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9439
3f754b86
PE
9440 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9441
2547adb1
CY
94422011-06-10 Chong Yidong <cyd@stupidchicken.com>
9443
9444 * image.c (gif_load): Fix omitted cast error introduced by
9445 2011-06-06 change.
9446
2c8e37d4
MR
94472011-06-10 Martin Rudalics <rudalics@gmx.at>
9448
9449 * window.h (resize_proportionally, orig_total_lines)
9450 (orig_top_line): Remove from window structure.
9451 (set_window_height, set_window_width, change_window_heights)
9452 (Fdelete_window): Remove prototypes.
9453 (resize_frame_windows): Remove duplicate declaration.
9454
440a42e3
EZ
94552011-06-10 Eli Zaretskii <eliz@gnu.org>
9456
9457 * window.h (resize_frame_windows, resize_window_check)
9458 (delete_deletable_window, resize_root_window)
9459 (resize_frame_windows): Declare prototypes.
9460
9461 * window.c (resize_window_apply): Make definition be "static" to
9462 match the prototype.
9463
562dd5e9
MR
94642011-06-10 Martin Rudalics <rudalics@gmx.at>
9465
9466 * window.c: Remove declarations of Qwindow_size_fixed,
9467 window_min_size_1, window_min_size_2, window_min_size,
9468 size_window, window_fixed_size_p, enlarge_window, delete_window.
9469 Remove static from declaration of Qdelete_window, it's
9470 temporarily needed by Fbury_buffer.
9471 (replace_window): Don't assign orig_top_line and
9472 orig_total_lines.
9473 (Fdelete_window, delete_window): Remove. Window deletion is
9474 handled by window.el.
640c8776
SM
9475 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9476 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9477 (Fdelete_other_windows): Remove. Deleting other windows is
9478 handled by window.el.
9479 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9480 handled in window.el.
9481 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9482 Window minimum sizes are handled in window.el.
9483 (shrink_windows, size_window, set_window_height)
9484 (set_window_width, change_window_heights, window_height)
9485 (window_width, CURBEG, CURSIZE, enlarge_window)
9486 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9487 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9488 handled in window.el.
9489 (make_dummy_parent): Rename to make_parent_window and give it a
9490 second argument horflag.
9491 (make_window): Don't set resize_proportionally any more.
9492 (Fsplit_window): Remove. Windows are split in window.el.
9493 (save_restore_action, save_restore_orig_size)
9494 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9495 Resize mini windows in window.el.
9496 (grow_mini_window, shrink_mini_window): Implement by calling
9497 Qresize_root_window_vertically, resize_window_check and
9498 resize_window_apply.
640c8776
SM
9499 (saved_window, Fset_window_configuration, save_window_save):
9500 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9501 resize_proportionally.
9502 (window_min_height, window_min_width): Move to window.el.
9503 (keys_of_window): Move bindings for delete-other-windows,
9504 split-window, delete-window and enlarge-window to window.el.
9505
9506 * buffer.c: Temporarily extern Qdelete_window.
9507 (Fbury_buffer): Temporarily call Qdelete_window instead of
9508 Fdelete_window (Fbury_buffer will move to window.el soon).
9509
9510 * frame.c (set_menu_bar_lines_1): Remove code handling
9511 orig_top_line and orig_total_lines.
9512
9513 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9514 set_window_height but set heights directly.
9515 (change_frame_size_1): Use resize_frame_windows.
9516
9517 * xdisp.c (init_xdisp): Don't use set_window_height but set
9518 heights directly.
9519
640c8776
SM
9520 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9521 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9522 run_window_configuration_change_hook.
9523
9524 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9525 instead of change_window_heights and run
9526 run_window_configuration_change_hook.
9527
1a13852e
MR
95282011-06-09 Martin Rudalics <rudalics@gmx.at>
9529
9530 * window.c (replace_window): Rename second argument REPLACEMENT to
9531 NEW. New third argument SETFLAG. Rewrite.
9532 (delete_window, make_dummy_parent): Call replace_window with
9533 third argument 1.
9534 (window_list_1): Move down in code.
9535 (run_window_configuration_change_hook): Move set_buffer part
9536 before select_frame_norecord part in order to unwind correctly.
9537 Rename count1 to count.
9538 (recombine_windows, delete_deletable_window, resize_root_window)
9539 (Fdelete_other_windows_internal)
9540 (Frun_window_configuration_change_hook, make_parent_window)
9541 (resize_window_check, resize_window_apply, Fresize_window_apply)
9542 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9543 (Fdelete_window_internal, Fresize_mini_window_internal):
9544 New functions.
1a13852e
MR
9545 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9546
f3d1777e
MR
95472011-06-08 Martin Rudalics <rudalics@gmx.at>
9548
496e208e
MR
9549 * window.h (window): Add some new members to window structure -
9550 normal_lines, normal_cols, new_total, new_normal, clone_number,
9551 splits, nest, prev_buffers, next_buffers.
9552 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9553 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9554
f3d1777e
MR
9555 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9556 Remove.
496e208e
MR
9557 (make_dummy_parent): Set new members of windows structure.
9558 (make_window): Move down in code. Handle new members of window
9559 structure.
9560 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9561 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9562 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9563 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9564 (Fset_window_next_buffers, Fset_window_clone_number):
9565 New functions.
496e208e
MR
9566 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9567 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9568 Doc-string fixes.
9569 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9570 Argument WINDOW can be now internal window too.
9571 (Fwindow_use_time): Move up in code.
9572 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9573 Rewrite doc-string.
9574 (Fset_window_configuration, saved_window)
9575 (Fcurrent_window_configuration, save_window_save): Handle new
9576 members of window structure.
b9e809c2
MR
9577 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9578 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9579 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9580 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9581 Qget_mru_window, Qresize_root_window,
9582 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9583 Qauto_buffer_name; staticpro them.
f3d1777e 9584
abde8f8c
MR
95852011-06-07 Martin Rudalics <rudalics@gmx.at>
9586
9587 * window.c (Fwindow_total_size, Fwindow_left_column)
9588 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9589 (Fwindow_list_1): New functions.
9590 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9591 (Fwindow_width, Fscroll_left, Fscroll_right):
9592 Use window_body_cols instead of window_box_text_cols.
9593 (delete_window, Fset_window_configuration):
9594 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9595 (delete_all_subwindows): Take a window as argument and not a
9596 structure. Rewrite.
190b47e6
MR
9597 (window_loop): Remove handling of GET_LRU_WINDOW and
9598 GET_LARGEST_WINDOW.
9599 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9600
9601 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9602 window_box_text_cols. delete_all_subwindows now takes a
9603 Lisp_Object as argument.
abde8f8c 9604
640c8776
SM
9605 * indent.c (compute_motion, Fcompute_motion):
9606 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9607
fa8a67e6
MR
9608 * frame.c (delete_frame): Call delete_all_subwindows with root
9609 window as argument.
9610
a54e3482
DC
96112011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9612
9613 * fns.c (Fputhash): Document return value.
9614
60002bf5
CY
96152011-06-06 Chong Yidong <cyd@stupidchicken.com>
9616
9617 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9618
0c671da6 96192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9620
b862a52a 9621 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9622
be44ca6c
PE
9623 Check for overflow when converting integer to cons and back.
9624 * charset.c (Fdefine_charset_internal, Fdecode_char):
9625 Use cons_to_unsigned to catch overflow.
9626 (Fencode_char): Use INTEGER_TO_CONS.
9627 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9628 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9629 * data.c (long_to_cons, cons_to_long): Remove.
9630 (cons_to_unsigned, cons_to_signed): New functions.
9631 These signal an error for invalid or out-of-range values.
9632 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9633 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9634 * font.c (Ffont_variation_glyphs):
9635 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9636 * lisp.h: Include <intprops.h>.
9637 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9638 (cons_to_signed, cons_to_unsigned): New decls.
9639 (long_to_cons, cons_to_long): Remove decls.
9640 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9641 (Fprimitive_undo): Use CONS_TO_INTEGER.
9642 * xfns.c (Fx_window_property): Likewise.
9643 * xselect.c: Include <limits.h>.
9644 (x_own_selection, selection_data_to_lisp_data):
9645 Use INTEGER_TO_CONS.
9646 (x_handle_selection_request, x_handle_selection_clear)
9647 (x_get_foreign_selection, Fx_disown_selection_internal)
9648 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9649 (lisp_data_to_selection_data): Use cons_to_unsigned.
9650 (x_fill_property_data): Use cons_to_signed.
9651 Report values out of range.
9652
d1f3d2af
PE
9653 Check for buffer and string overflow more precisely.
9654 * buffer.h (BUF_BYTES_MAX): New macro.
9655 * lisp.h (STRING_BYTES_MAX): New macro.
9656 * alloc.c (Fmake_string):
9657 * character.c (string_escape_byte8):
9658 * coding.c (coding_alloc_by_realloc):
9659 * doprnt.c (doprnt):
9660 * editfns.c (Fformat):
9661 * eval.c (verror):
9662 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9663 since they may not be the same number.
9664 * editfns.c (Finsert_char):
9665 * fileio.c (Finsert_file_contents):
9666 Likewise for BUF_BYTES_MAX.
9667
dd52fcea
PE
9668 * image.c: Use ptrdiff_t, not int, for sizes.
9669 (slurp_file): Switch from int to ptrdiff_t.
9670 All uses changed.
9671 (slurp_file): Check that file size fits in both size_t (for
9672 malloc) and ptrdiff_t (for sanity and safety).
9673
7f9bbdbb
PE
9674 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9675 if b->modtime has its maximal value.
9676
dfe18f82
PE
9677 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9678
84acfcf0
PE
9679 Don't assume time_t can fit into int.
9680 * buffer.h (struct buffer.modtime): Now time_t, not int.
9681 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9682 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9683
ccd9a01a
PE
9684 Minor fixes for signed vs unsigned integers.
9685 * character.h (MAYBE_UNIFY_CHAR):
9686 * charset.c (maybe_unify_char):
9687 * keyboard.c (read_char, reorder_modifiers):
9688 XINT -> XFASTINT, since the integer must be nonnegative.
9689 * ftfont.c (ftfont_spec_pattern):
9690 * keymap.c (access_keymap, silly_event_symbol_error):
9691 XUINT -> XFASTINT, since the integer must be nonnegative.
9692 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9693 since it makes no difference and we prefer signed.
9694 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9695 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9696 nonnegative.
9697
d6d100dd
SM
96982011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9699
9700 * window.h (Fwindow_frame): Declare.
9701
2b6148e4
PE
97022011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9703
9704 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9705 (SPARE_MEMORY): Always define.
9706 (LARGE_REQUEST): Remove.
9707 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9708
f230ecc9
MR
97092011-06-06 Martin Rudalics <rudalics@gmx.at>
9710
727e958e
MR
9711 * lisp.h: Move EXFUNS for Fframe_root_window,
9712 Fframe_first_window and Fset_frame_selected_window to window.h.
9713
9714 * window.h: Move EXFUNS for Fframe_root_window,
9715 Fframe_first_window and Fset_frame_selected_window here from
9716 lisp.h.
9717
9718 * frame.c (Fwindow_frame, Fframe_first_window)
9719 (Fframe_root_window, Fframe_selected_window)
9720 (Fset_frame_selected_window): Move to window.c.
9721 (Factive_minibuffer_window): Move to minibuf.c.
9722 (Fother_visible_frames_p): New function.
9723
9724 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9725
f230ecc9
MR
9726 * window.c (decode_window, decode_any_window): Move up in code.
9727 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9728 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9729 (Fwindow_buffer): Move up and rewrite doc-string.
9730 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9731 (Fwindow_prev): New functions.
727e958e
MR
9732 (Fwindow_frame): Move here from frame.c. Accept any window as
9733 argument.
9734 (Fframe_root_window, Fframe_first_window)
9735 (Fframe_selected_window): Move here from frame.c. Accept frame
9736 or arbitrary window as argument. Update doc-strings.
9737 (Fminibuffer_window): Move up in code.
9738 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9739 (Fset_frame_selected_window): Move here from frame.c.
9740 Marginal rewrite.
727e958e
MR
9741 (Fselected_window, select_window, Fselect_window): Move up in
9742 code. Minor doc-string fixes.
f230ecc9 9743
4d09bcf6
PE
97442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9745
9746 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9747 Do not assume that spare memory exists; that assumption is valid
9748 only if SYSTEM_MALLOC.
9749 (LARGE_REQUEST): New macro, so that the issue of large requests
9750 is separated from the issue of spare memory.
9751
810928a2
AS
97522011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9753
172418ad
AS
9754 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9755 format. (Bug#8806)
9756
43f862f7
AS
9757 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9758
810928a2
AS
9759 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9760 before statements.
9761
a059fe24
JD
97622011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9763
9764 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9765
9766 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9767
9768 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9769 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9770
989bf368
JB
97712011-06-05 Juanma Barranquero <lekktu@gmail.com>
9772
9773 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9774
4b80f674
CY
97752011-06-04 Chong Yidong <cyd@stupidchicken.com>
9776
9777 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9778 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9779 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9780 New error handlers.
4b80f674
CY
9781 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9782 Obey Vx_select_enable_clipboard_manager. Catch errors in
9783 x_clipboard_manager_save (Bug#8779).
9784 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9785 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9786
99a33b77 97872011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9788
9789 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9790
99a33b77 97912011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9792
9793 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9794 in the current matrix if keep_current_p is non-zero.
9795
8264569d
EZ
97962011-06-04 Eli Zaretskii <eliz@gnu.org>
9797
9798 * bidi.c (bidi_level_of_next_char): Fix last change.
9799
57f97249
EZ
98002011-06-03 Eli Zaretskii <eliz@gnu.org>
9801
fec2107c 9802 Support bidi reordering of text covered by display properties.
57f97249 9803
fec2107c
EZ
9804 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9805 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9806 (bidi_cache_search, bidi_cache_iterator_state)
9807 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9808 (bidi_level_of_next_char, bidi_move_to_visually_next):
9809 Support character positions inside a run of characters covered by a
fec2107c
EZ
9810 display string.
9811 (bidi_paragraph_init, bidi_resolve_explicit_1)
9812 (bidi_level_of_next_char): Call bidi_fetch_char and
9813 bidi_fetch_char_advance instead of FETCH_CHAR and
9814 FETCH_CHAR_ADVANCE.
9815 (bidi_init_it): Initialize new members.
9816 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9817 definitions.
9818 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9819 instead of using explicit *_CHAR codes.
d6d100dd
SM
9820 (bidi_resolve_explicit, bidi_resolve_weak):
9821 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9822 bidirectional text is supported only in multibyte buffers.
9823 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9824 it to initialize the frame_window_p member of struct bidi_it.
9825 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9826 (bidi_resolve_explicit, bidi_resolve_weak)
9827 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9828 bidi_it->nchars is non-positive.
9829 (bidi_level_of_next_char): Don't try to lookup the cache for the
9830 next/previous character if nothing is cached there yet, or if we
9831 were just reseat()'ed to a new position.
c40e2fb2 9832
0e14fe90
EZ
9833 * xdisp.c (set_cursor_from_row): Set start and stop points
9834 according to the row's direction when priming the loop that looks
9835 for the glyph on which to display cursor.
9836 (single_display_spec_intangible_p): Function deleted.
9837 (display_prop_intangible_p): Reimplement to call
9838 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9839 Accept 3 additional arguments needed by handle_display_spec.
9840 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9841 values: lists, `(when COND...)' forms, etc.
9842 (single_display_spec_string_p): Support property values that are
9843 lists with the argument STRING its top-level element.
9844 (display_prop_string_p): Fix the condition for processing a
9845 property that is a list to be consistent with handle_display_spec.
fec2107c 9846 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9847 last portion of handle_display_prop.
9848 (compute_display_string_pos): Accept additional argument
9849 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9850 value of a `display' property is a "replacing spec".
9851 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9852 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9853 the display property, but just return a value indicating whether
9854 the display property will replace the characters it covers.
9855 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9856 frame_window_p members of struct bidi_it.
d6d100dd
SM
9857 (compute_display_string_pos, compute_display_string_end):
9858 New functions.
fec2107c
EZ
9859 (push_it): Accept second argument POSITION, where pop_it should
9860 jump to continue iteration.
9861 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9862
fec2107c
EZ
9863 * keyboard.c (adjust_point_for_property): Adjust the call to
9864 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9865
9866 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9867 (bidi_init_it): Update prototypes.
9868 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9869 (compute_display_string_pos, compute_display_string_end):
9870 Declare prototypes.
fec2107c
EZ
9871 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9872 EMACS_INT.
fc6f18ce 9873
40087514 98742011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9875
57f53182
PE
9876 Malloc failure behavior now depends on size of allocation.
9877 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9878 * lisp.h: Change signatures accordingly.
9879 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9880 All callers changed. (Bug#8762)
9881
9882 * gnutls.c: Use Emacs's memory allocators.
9883 Without this change, the gnutls library would invoke malloc etc.
9884 directly, which causes problems on non-SYNC_INPUT hosts, and which
9885 runs afoul of improving memory_full behavior. (Bug#8761)
9886 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9887 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9888 xfree instead of the default malloc, realloc, free.
9889 (Fgnutls_boot): No need to check for memory allocation failure,
9890 since xmalloc does that for us.
9891
ac32cd99 9892 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9893 * category.c (hash_get_category_set):
9894 * ccl.c (ccl_driver):
9895 * charset.c (Fdefine_charset_internal):
9896 * charset.h (struct charset.hash_index):
9897 * composite.c (get_composition_id, gstring_lookup_cache)
9898 (composition_gstring_put_cache):
9899 * composite.h (struct composition.hash_index):
9900 * dispextern.h (struct image.hash):
9901 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9902 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9903 (hashfn_equal, hashfn_user_defined, make_hash_table)
9904 (maybe_resize_hash_table, hash_lookup, hash_put)
9905 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9906 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9907 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9908 * image.c (make_image, search_image_cache, lookup_image)
9909 (xpm_put_color_table_h):
9910 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9911 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9912 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9913 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9914 * alloc.c (allocate_vectorlike):
9915 Check for overflow in vector size calculations.
9916 * ccl.c (ccl_driver):
9917 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9918 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9919 need to be updated by these changes.
40087514
PE
9920 * fns.c (make_hash_table, maybe_resize_hash_table):
9921 Check for integer overflow with large hash tables.
0de4bb68
PE
9922 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9923 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9924 (SXHASH_REDUCE): New macro.
9925 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9926 Use it instead of discarding useful hash info with large hash values.
9927 (sxhash_float): New function.
9928 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9929 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9930 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9931 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9932 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9933 Adjust signatures to match updated version of code.
9934 (consing_since_gc): Now EMACS_INT, since a single hash table can
9935 use more than INT_MAX bytes.
9936
698d32e2
DN
99372011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9938
9939 Make it possible to build with GCC-4.6+ -O2 -flto.
9940
9941 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9942
fd6fa53f
SM
99432011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9944
9945 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9946 Call minibuffer-inactive-mode.
9947
864db017
JB
99482011-05-31 Juanma Barranquero <lekktu@gmail.com>
9949
9950 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9951 Update dependencies.
9952
2ad0baf4
DN
99532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9954
9955 * data.c (init_data): Remove code for UTS, this system is not
9956 supported anymore.
9957
4fcc2638
DN
99582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9959
9960 Don't force ./temacs to start in terminal mode.
9961
9962 * frame.c (make_initial_frame): Initialize faces in all cases, not
9963 only when CANNOT_DUMP is defined.
9964 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9965
c56e0fd5
DN
99662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9967
9968 * dispnew.c (add_window_display_history): Use const for the string
9969 pointer. Remove declaration, not needed.
9970
333d54da 99712011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9972
55d4c1b2 9973 Use 'inline', not 'INLINE'.
333d54da 9974 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9975 * alloc.c, fontset.c (INLINE): Remove.
9976 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9977 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9978 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9979 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9980 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9981
738db178
DN
99822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9983
9984 Make it possible to run ./temacs.
9985
9986 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9987 syms_of_callproc does the same thing. Remove test for
9988 "initialized", do it in the caller.
9989 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9990
620c53a6
SM
99912011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9992
9993 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9994 (read_minibuf): Use get_minibuffer.
9995 (syms_of_minibuf): Use DEFSYM.
9996 (Qmetadata): New var.
9997 * data.c (Qbuffer): Don't make it static.
9998 (syms_of_data): Use DEFSYM.
9999
e003a292
PE
100002011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10001
10002 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10003 (CCL_CODE_MIN): New macro.
10004
ed008a6d
PE
100052011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10006
3687c2ef
PE
10007 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10008
ed008a6d
PE
10009 * eval.c (Qdebug): Now static.
10010 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10011 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10012 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10013
d66c4c7c
CY
100142011-05-29 Chong Yidong <cyd@stupidchicken.com>
10015
10016 * image.c: Various fixes to ImageMagick code comments.
10017 (Fimagemagick_types): Doc fix.
10018
5fbc2025
PE
100192011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10020
0196f88a
PE
10021 Minor fixes prompted by GCC 4.6.0 warnings.
10022
10023 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10024
5fbc2025
PE
10025 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10026 (x_clipboard_manager_save_all): Move extern decl to ...
10027 * xterm.h: ... here, so that it can be checked for consistency.
10028
1dd3c2d9
CY
100292011-05-29 Chong Yidong <cyd@stupidchicken.com>
10030
10031 * xselect.c (x_clipboard_manager_save_frame)
10032 (x_clipboard_manager_save_all): New functions.
10033 (Fx_clipboard_manager_save): Lisp function deleted.
10034
10035 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10036 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10037
10038 * xterm.h: Update prototype.
10039
5ba6571d
WX
100402011-05-28 William Xu <william.xwl@gmail.com>
10041
10042 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10043 exiting (Bug#8239).
10044
3eaff834
JM
100452011-05-28 Jim Meyering <meyering@redhat.com>
10046
e1900994 10047 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10048 * fns.c (to_uchar): Define.
10049 (crypto_hash_function): Use it to convert some newly-signed
10050 variables to unsigned, to avoid sign-extension bugs. For example,
10051 without this change, (md5 "truc") would evaluate to
10052 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10053 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10054 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10055
0f6990a7
PE
100562011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10057
10058 Integer overflow fixes.
c8a9ca5a 10059
08686060
PE
10060 * dbusbind.c: Serial number integer overflow fixes.
10061 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10062 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10063 to hold a serial number that is too large for a fixnum.
10064 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10065 Check for serial numbers out of range. Decode any serial number
59568bf0 10066 that was so large that it became a float. (Bug#8722)
08686060 10067
2d1fc3c7
PE
10068 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10069 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10070 Use XFASTINT rather than XUINT when numbers are nonnegative.
10071 (xd_append_arg, Fdbus_method_return_internal):
10072 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10073 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10074 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10075 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10076 (Bug#8722)
2d1fc3c7 10077
c8a9ca5a
PE
10078 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10079
519e1d69
PE
10080 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10081
6df6ae42 10082 ccl: Add integer overflow checks.
30569699
PE
10083 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10084 (IN_INT_RANGE): New macros.
10085 (ccl_driver): Use them to check for integer overflow when
10086 decoding a CCL program. Many of the new checks are whether XINT (x)
10087 fits in int; it doesn't always, on 64-bit hosts. The new version
10088 doesn't catch all possible integer overflows, but it's an
847044ea 10089 improvement. (Bug#8719)
30569699 10090
c11285dc
PE
10091 * alloc.c (make_event_array): Use XINT, not XUINT.
10092 There's no need for unsigned here.
10093
fdccd48e
PE
10094 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10095 This follows up to the 2011-05-06 change that substituted uintptr_t
10096 for EMACS_INT. This case wasn't caught back then.
10097
37910ab2
PE
10098 Rework Fformat to avoid integer overflow issues.
10099 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10100 now (part of C89). Include <verify.h>.
10101 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10102 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10103 (Fformat): Avoid the prepass trying to compute sizes; it was only
10104 approximate and thus did not catch overflow reliably. Instead, walk
10105 through the format just once, formatting and computing sizes as we go,
10106 checking for integer overflow at every step, and allocating a larger
10107 buffer as needed. Keep track separately whether the format is
10108 multibyte. Keep only the most-recently calculated precision, rather
10109 than them all. Record whether each argument has been converted to
10110 string. Use EMACS_INT, not int, for byte and char and arg counts.
10111 Support field widths and precisions larger than INT_MAX. Avoid
10112 sprintf's undefined behavior with conversion specifications such as %#d
10113 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10114 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10115 formatting out-of-range floating point numbers with int
9173deec 10116 formats. (Bug#8668)
37910ab2 10117
2e6578fb
PE
10118 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10119
0ae6bdee
PE
10120 * data.c: Avoid integer truncation in expressions involving floats.
10121 * data.c: Include <intprops.h>.
10122 (arith_driver): When there's an integer overflow in an expression
10123 involving floating point, convert the integers to floating point
10124 so that the resulting value does not suffer from catastrophic
10125 integer truncation. For example, on a 64-bit host (* 4
10126 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10127 Do not rely on undefined behavior after integer overflow.
10128
de883a70
PE
10129 merge count_size_as_multibyte, parse_str_to_multibyte
10130 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10131 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10132 Check for integer overflow.
10133 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10134 since it's now a duplicate of the other. This is more of
10135 a character than a buffer op, so better that it's in character.c.
10136 * fns.c, print.c: Adjust to above changes.
10137
2ff916cb
PE
101382011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10139
10140 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10141
f1b54466
PE
101422011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10143
fb1ac845
PE
10144 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10145 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10146 (x_clipboard_manager_save): Now static.
10147 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10148
f1b54466
PE
10149 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10150 (crypto_hash_function): Now static.
10151 Fix pointer signedness problems. Avoid unnecessary initializations.
10152
a9f737ee
CY
101532011-05-27 Chong Yidong <cyd@stupidchicken.com>
10154
10155 * termhooks.h (Vselection_alist): Make it terminal-local.
10156
10157 * terminal.c (create_terminal): Initialize it.
10158
10159 * xselect.c: Support for clipboard managers.
10160 (Vselection_alist): Move to termhooks.h as terminal-local var.
10161 (LOCAL_SELECTION): New macro.
10162 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10163 (symbol_to_x_atom): Remove gratuitous arg.
10164 (x_handle_selection_request, lisp_data_to_selection_data)
10165 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10166 (x_own_selection, x_get_local_selection, x_convert_selection):
10167 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10168 (some_frame_on_display): Delete unused function.
10169 (Fx_own_selection_internal, Fx_get_selection_internal)
10170 (Fx_disown_selection_internal, Fx_selection_owner_p)
10171 (Fx_selection_exists_p): New optional frame arg.
10172 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10173 (x_handle_selection_clear): Don't treat other terminals with the
10174 same keyboard specially. Use the terminal-local Vselection_alist.
10175 (x_clear_frame_selections): Use Frun_hook_with_args.
10176
10177 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10178
10179 * xterm.h: Add support for those atoms.
10180
e067f0c1
CY
101812011-05-26 Chong Yidong <cyd@stupidchicken.com>
10182
10183 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10184 (converted_selections, conversion_fail_tag): New global variables.
10185 (x_selection_request_lisp_error): Free the above.
10186 (x_get_local_selection): Remove unnecessary code.
10187 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10188 of converted selections stored in converted_selections.
10189 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10190 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10191 (x_convert_selection): New function.
10192 (x_handle_selection_event): Simplify.
10193 (x_get_foreign_selection): Don't ignore incoming requests while
10194 waiting for an answer; this will fail when we implement
10195 SAVE_TARGETS, and seems unnecessary anyway.
10196 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10197 (Vx_sent_selection_functions): Doc fix.
10198
0f4aebc0
LL
101992011-05-26 Leo Liu <sdl.web@gmail.com>
10200
10201 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10202
e61124cd
YM
102032011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10204
10205 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10206
10207 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10208 for fringe update if it has periodic bitmap.
ac389d0c 10209 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10210 and fringe_bitmap_periodic_p.
10211
10212 * fringe.c (get_fringe_bitmap_data): New function.
10213 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10214 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10215 row. Mark glyph row for fringe update if periodicity changed.
10216
10217 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10218 for fringe update unless it has periodic bitmap.
10219
f16d9837
KH
102202011-05-25 Kenichi Handa <handa@m17n.org>
10221
10222 * xdisp.c (get_next_display_element): Set correct it->face_id for
10223 a static composition.
10224
e1b90ef6
LL
102252011-05-24 Leo Liu <sdl.web@gmail.com>
10226
10227 * deps.mk (fns.o):
10228 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10229
10230 * fns.c (crypto_hash_function, Fsha1): New function.
10231 (Fmd5): Use crypto_hash_function.
10232 (syms_of_fns): Add Ssha1.
10233
7400048f
PE
102342011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10235
10236 * gnutls.c: Remove unused macros.
10237 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10238 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10239 Remove macros that are defined and never used.
10240 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10241
abb71cf4
CY
102422011-05-22 Chong Yidong <cyd@stupidchicken.com>
10243
10244 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10245 (Fx_get_selection_internal): Minor cleanup.
10246 (Fx_own_selection_internal): Rename arguments for consistency with
10247 select.el.
10248
6307db39
PE
102492011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10250
10251 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10252
f3d4e0a4
CY
102532011-05-22 Chong Yidong <cyd@stupidchicken.com>
10254
10255 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10256
4d8ade89
YM
102572011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10258
10259 * dispnew.c (scrolling_window): Don't exclude the case that the
10260 last enabled row in the desired matrix touches the bottom boundary.
10261
32078c8d
GM
102622011-05-21 Glenn Morris <rgm@gnu.org>
10263
10264 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10265 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10266 and add some more files.
32078c8d 10267
7285dc67
EZ
102682011-05-20 Eli Zaretskii <eliz@gnu.org>
10269
10270 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10271 report_file_error introduced by the change from 2011-05-07.
10272
89d1bd22
PE
102732011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10274
10275 * systime.h (Time): Define only if emacs is defined.
10276 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10277 where the include path doesn't have X11/X.h by default. See
10278 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10279
cd394be1 102802011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10281
10282 * composite.c (find_automatic_composition): Fix previous change.
10283
b9704ad9
GM
102842011-05-20 Glenn Morris <rgm@gnu.org>
10285
10286 * lisp.mk: New file, split from Makefile.in.
10287 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10288 (shortlisp): Remove.
10289 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10290
4a720484
GM
102912011-05-19 Glenn Morris <rgm@gnu.org>
10292
10293 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10294 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10295 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10296 (lisp): Set the order to that of loadup.el.
10297 (shortlisp): Make it a copy of $lisp.
10298 (SOME_MACHINE_LISP): Remove.
10299 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10300 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10301
a28d4396
KH
103022011-05-18 Kenichi Handa <handa@m17n.org>
10303
10304 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10305 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10306 (find_automatic_composition): Mostly rewrite for efficiency.
10307
a2b1fa8e
JB
103082011-05-18 Juanma Barranquero <lekktu@gmail.com>
10309
10310 * makefile.w32-in: Update dependencies.
10311
8e1f5610
CS
103122011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10313
10314 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10315 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10316
7025ee00 103172011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10318
cdfa6eab
PE
10319 Fix some integer overflow issues, such as string length overflow.
10320
06d6db33
PE
10321 * insdel.c (count_size_as_multibyte): Check for string overflow.
10322
2b4560a8
PE
10323 * character.c (lisp_string_width): Check for string overflow.
10324 Use EMACS_INT, not int, for string indexes and lengths; in
10325 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10326 the resulting string length overflows an EMACS_INT; instead,
10327 report a string overflow if no precision given. When checking for
10328 precision exhaustion, use a check that cannot possibly have
10329 integer overflow. (Bug#8675)
10330 * character.h (lisp_string_width): Adjust to new signature.
10331
cb93f9be
PE
10332 * alloc.c (string_overflow): New function.
10333 (Fmake_string): Use it. This doesn't change behavior, but saves
10334 a few bytes and will simplify future changes.
10335 * character.c (string_escape_byte8): Likewise.
10336 * lisp.h (string_overflow): New decl.
10337
1a1f3366
PE
10338 Fixups, following up to the user-interface timestamp change.
10339 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10340 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10341 * msdos.c (mouse_get_pos): Likewise.
10342 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10343 * w32gui.h (Time): Define by including "systime.h" rather than by
10344 declaring it ourselves. (Bug#8664)
10345
d4e3e4d3
PE
10346 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10347 * image.c (clear_image_cache): Likewise.
10348
f6a24d19
PE
10349 * term.c (term_mouse_position): Don't assume time_t wraparound.
10350
08dc5ae6
PE
10351 Be more systematic about user-interface timestamps.
10352 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10353 and sometimes 'EMACS_UINT', to represent these timestamps.
10354 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10355 This makes the code easier to follow, and makes it easier to catch
10356 integer overflow bugs such as Bug#8664.
10357 * frame.c (Fmouse_position, Fmouse_pixel_position):
10358 Use Time, not unsigned long, for user-interface timestamps.
10359 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10360 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10361 * keyboard.h (last_event_timestamp): Likewise.
10362 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10363 * menu.h (xmenu_show): Likewise.
10364 * term.c (term_mouse_position): Likewise.
10365 * termhooks.h (struct input_event.timestamp): Likewise.
10366 (struct terminal.mouse_position_hook): Likewise.
10367 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10368 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10369 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10370 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10371 what it was before.
10372 * menu.h, termhooks.h: Include "systime.h", for Time.
10373
8e55734a
PE
10374 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10375 Don't assume that the difference between two unsigned long values
10376 can fit into an integer. At this point, we know button_down_time
10377 <= event->timestamp, so the difference must be nonnegative, so
10378 there's no need to cast the result if double-click-time is
10379 nonnegative, as it should be; check that it's nonnegative, just in
10380 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10381 apart (about 25 days). (Bug#8664)
8e55734a 10382
841f1b75 10383 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10384 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10385
3e26f69c
PE
10386 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10387 that always fit in int. Use a sentinel instead of a counter, to
10388 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10389 * frame.h (struct frame): Use int for menu_bar_items_used
10390 instead of EMACS_INT, since it always fits in int.
3e26f69c 10391
5cc152c0
PE
10392 * menu.c (grow_menu_items): Check for int overflow.
10393
d89eb65e
PE
10394 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10395
5235bd3e
PE
10396 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10397 Before, the code was not consistent. These values cannot exceed
10398 2**31 - 1 so there's no need to make them unsigned.
10399 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10400 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10401 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10402 as modifiers.
10403 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10404
bc827e23
PE
10405 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10406 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10407 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10408 presumably because the widths might not match.
10409
78eb494e
PE
10410 * window.c (size_window): Avoid needless test at loop start.
10411
04f2d78b
CB
104122011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10413
10414 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10415
d2fc7e3d 104162011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10417
10418 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10419
d2fc7e3d 104202011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10421
10422 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10423 `width' to `bar_area_x' and `bar_area_width', respectively.
10424 (x_scroll_run): Take account of fringe background extension.
10425
04f2d78b
CB
10426 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10427 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10428 `bar_area_width', respectively.
10429 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10430 background extension.
10431
79b70037
GM
104322011-05-10 Jim Meyering <meyering@redhat.com>
10433
10434 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10435
2f142cc5
JB
104362011-05-10 Juanma Barranquero <lekktu@gmail.com>
10437
10438 * image.c (Finit_image_library): Return t for built-in image types,
10439 like pbm and xbm. (Bug#8640)
10440
57679c86
AS
104412011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10442
10443 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10444
888c9e86
EZ
104452011-05-07 Eli Zaretskii <eliz@gnu.org>
10446
b0512a1d
EZ
10447 * w32console.c (Fset_screen_color): Doc fix.
10448 (Fget_screen_color): New function.
10449 (syms_of_ntterm): Defsubr it.
10450
7285dc67
EZ
10451 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10452 unlink the temporary file if Fcall_process didn't create it in the
10453 first place.
10454 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10455 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10456 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10457 cue to call_process_cleanup not to close that handle.
10458
4d3fcc8e
BK
104592011-05-07 Ben Key <bkey76@gmail.com>
10460
10461 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10462 one of two shell specific rules, either bootstrap-temacs-CMD or
10463 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10464 to the previous implementation of the bootstrap-temacs rule.
10465 The bootstrap-temacs-CMD rule is similar to the previous
10466 implementation of the bootstrap-temacs rule except that it
10467 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10468 variable.
10469
10470 These changes, along with some changes to nt/configure.bat,
10471 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10472 earlier fix to add support for --cflags and --ldflags options
10473 that include quotes so that it works whether make uses cmd or
10474 sh as the shell.
10475
b4289b64
MA
104762011-05-06 Michael Albinus <michael.albinus@gmx.de>
10477
10478 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10479 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10480 is a constant.
10481 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10482 a string. Handle both cases.
10483 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10484 (Fdbus_register_method): Use Qinvalid_function.
10485
af4c0e28
JB
104862011-05-06 Juanma Barranquero <lekktu@gmail.com>
10487
10488 * makefile.w32-in: Update dependencies.
10489 (LISP_H): Add inttypes.h and stdin.h.
10490 (PROCESS_H): Add unistd.h.
10491
c51453d9
EZ
104922011-05-06 Eli Zaretskii <eliz@gnu.org>
10493
10494 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10495 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10496
8ff0ac3c 104972011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10498
4c4b566b
PE
10499 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10500
aab2b9b5
PE
10501 * term.c (vfatal): Remove stray call to va_end.
10502 It's not needed and the C Standard doesn't allow it here anyway.
10503
c378da0b
PE
10504 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10505 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10506
288b08c7
PE
10507 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10508 bytes.
10509
e3601888
PE
10510 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10511
db6c0e74
PE
10512 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10513
dd5963ea
PE
10514 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10515
88c9450f
PE
10516 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10517
2f9442b8
PE
10518 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10519
c032b5f8
PE
10520 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10521 * charset.c (Fdefine_charset_internal): Don't initialize
10522 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10523 32-bit int (Bug#8600).
a108c10b
PE
10524
10525 * lread.c (read_integer): Be more consistent with string-to-number.
10526 Use string_to_number to do the actual conversion; this avoids
10527 rounding errors and fixes some other screwups. Without this fix,
10528 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10529 (digit_to_number): Move earlier, for benefit of read_integer.
10530 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10531 not a digit in any supported base. (Bug#8602)
a108c10b 10532
ad5f9eea
PE
10533 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10534
aec1708a
PE
10535 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10536 to match comment at start of function. This also removes a
10537 GCC warning about overflow in a 32+64-bit port.
10538
47be4ab5
PE
10539 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10540
371cac43
PE
10541 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10542 Reported by Stefan Monnier in
10543 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10544 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10545 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10546
d01a7826
PE
10547 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10548 (EMACS_UINTPTR): Likewise, with uintptr_t.
10549
7fd47d5c
PE
10550 * lisp.h: Prefer 64-bit EMACS_INT if available.
10551 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10552 on 32-bit hosts that have 64-bit int, so that they can access
10553 large files.
122b0c86
PE
10554 However, temporarily disable this change unless the temporary
10555 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10556
8727937b
PE
10557 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10558
8ac068ac
PE
10559 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10560 This removes an assumption that EMACS_INT and long are the same
10561 width as pointers. The assumption is true for Emacs porting targets
10562 now, but we want to make other targets possible.
10563 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10564 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10565 In the rest of the code, change types of integers that hold casted
10566 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10567 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10568 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10569 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10570 No need to cast type when ORing.
10571 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10572 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10573 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10574 assume EMACS_INT is the same width as char *.
10575 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10576 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10577 Remove no-longer-needed casts.
10578 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10579 (xg_tool_bar_help_callback, xg_make_tool_item):
10580 Use EMACS_INTPTR to hold an integer
10581 that will be cast to void *; this can avoid a GCC warning
10582 if EMACS_INT is not the same width as void *.
10583 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10584 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10585 (current_message_1, set_message_1):
10586 Use a local to convert to proper width without a cast.
10587 * xmenu.c (dialog_selection_callback): Likewise.
10588
ede49d71
PE
10589 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10590 Also, don't assume VALBITS / RAND_BITS is less than 5,
10591 and don't rely on undefined behavior when shifting a 1 left into
10592 the sign bit.
10593 * lisp.h (get_random): Change signature to match.
10594
2f30ecd0
PE
10595 * lread.c (hash_string): Use size_t, not int, for hash computation.
10596 Normally we prefer signed values; but hashing is special, because
10597 it's better to use unsigned division on hash table sizes so that
10598 the remainder is nonnegative. Also, size_t is the natural width
10599 for hashing into memory. The previous code used 'int', which doesn't
10600 retain enough info to hash well into very large tables.
10601 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10602
2a866e7b
PE
10603 * dbusbind.c: Don't possibly lose pointer info when converting.
10604 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10605 Use XPNTR rather than XHASH, so that the high-order bits of
10606 the pointer aren't lost when converting through void *.
10607
51639eac
PE
10608 * eval.c (Fautoload): Don't double-shift a pointer.
10609
92394119
PE
10610 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10611
dbdb9a7c
JB
106122011-05-06 Juanma Barranquero <lekktu@gmail.com>
10613
10614 * gnutls.c (DEF_GNUTLS_FN):
10615 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10616
db7a0b4f
AS
106172011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10618
10619 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10620 marker. (Bug#8610)
10621
cd394be1 106222011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10623
10624 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10625 New version that can reserve upto 2GB of heap space.
10626
f7ff1b0f 106272011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10628
10629 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10630
639c109b
TZ
106312011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10632
10633 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10634 `gnutls_certificate_set_x509_key_file'.
10635
d2127135
JB
106362011-05-05 Juanma Barranquero <lekktu@gmail.com>
10637
10638 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10639 Update dependencies.
10640
e968f4f3
JB
106412011-05-04 Juanma Barranquero <lekktu@gmail.com>
10642
10643 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10644 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10645 Remove unused parameter `fildes'.
10646 * process.c (read_process_output, send_process): Don't pass it.
10647
84d358f0
JB
106482011-05-04 Juanma Barranquero <lekktu@gmail.com>
10649
10650 Fix previous change: the library cache is defined in w32.c.
10651 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10652 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10653
0898ca10
JB
106542011-05-04 Juanma Barranquero <lekktu@gmail.com>
10655
10656 Implement dynamic loading of GnuTLS on Windows.
10657
10658 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10659 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10660 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10661 Declare.
10662
10663 * gnutls.c (Qgnutls_dll): Define.
10664 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10665 (gnutls_*): Declare function pointers.
10666 (init_gnutls_functions): New function to initialize function pointers.
10667 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10668 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10669 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10670 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10671 (emacs_gnutls_write, emacs_gnutls_read)
10672 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10673 (Fgnutls_available_p): New function.
10674 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10675 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10676 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10677
10678 * image.c: Include w32.h.
10679 (Vimage_type_cache): Delete.
10680 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10681 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10682 (w32_delayed_load): Move to w32.c.
10683
10684 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10685
10686 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10687 (w32_delayed_load): Move from image.c. When loading a library, record
10688 its filename in the :loaded-from property of the library id.
10689 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10690 Initialize and staticpro them.
10691 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10692
10693 * process.c: Include lisp.h before w32.h, not after.
10694 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10695 instead of gnutls_record_check_pending.
10696
10697 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10698
ff4de4aa
TZ
106992011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10700
10701 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10702 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10703 as passed in.
10704
abe95abb
JD
107052011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10706
10707 * xterm.c (x_set_frame_alpha): Do not set property on anything
10708 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10709
e16e55d4
JB
107102011-05-02 Juanma Barranquero <lekktu@gmail.com>
10711
10712 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10713
bafcf6a5
JB
107142011-05-02 Juanma Barranquero <lekktu@gmail.com>
10715
10716 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10717 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10718 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10719 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10720 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10721 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10722 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10723 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10724 (Qgnutls_bootprop_callbacks_verify): Make static.
10725
e7a6747f
AS
107262011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10727
19ed11ba
AS
10728 * callproc.c: Indentation fixup.
10729
e7a6747f 10730 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10731 (wait_for_termination, interruptible_wait_for_termination):
10732 Move after wait_for_termination_1.
e7a6747f 10733
1ef14cb4
LMI
107342011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10735
10736 * sysdep.c (interruptible_wait_for_termination): New function
10737 which is like wait_for_termination, but allows keyboard
10738 interruptions.
10739
10740 * callproc.c (Fcall_process): Add (:file "file") as an option for
10741 the STDOUT buffer.
10742 (Fcall_process_region): Ditto.
10743
330d880c
EZ
107442011-04-30 Eli Zaretskii <eliz@gnu.org>
10745
8db90b73
EZ
10746 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10747 rather than `XVECTOR (FOO)->size'.
10748
330d880c
EZ
10749 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10750 inttypes.h, as a gnulib replacement is used if it not available in
10751 system headers.
10752
15cbd324
EZ
107532011-04-21 Eli Zaretskii <eliz@gnu.org>
10754
10755 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10756 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10757 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10758
10759 * coding.c (coding_alloc_by_realloc): Error out if destination
10760 will grow beyond MOST_POSITIVE_FIXNUM.
10761 (decode_coding_emacs_mule): Abort if there isn't enough place in
10762 charbuf for the composition carryover bytes. Reserve an extra
10763 space for up to 2 characters produced in a loop.
10764 (decode_coding_iso_2022): Abort if there isn't enough place in
10765 charbuf for the composition carryover bytes.
10766
107672011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10768
ae940cca
EZ
10769 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10770 aborting when %lld or %lll format is passed.
10771 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10772 %llo or %llx format is passed. (Bug#8545)
10773
03ab8921
EZ
10774 * window.c (window_scroll_line_based): Use a marker instead of
10775 simple variables to record original value of point. (Bug#7952)
10776
afda1437
EZ
10777 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10778 produced by %s or %c overflows available buffer space. (Bug#8545)
10779
f76dee0c
PE
107802011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10781
10782 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10783 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10784
fdc5744d
JB
107852011-04-28 Juanma Barranquero <lekktu@gmail.com>
10786
10787 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10788
638f053a
JB
107892011-04-28 Juanma Barranquero <lekktu@gmail.com>
10790
10791 * keyboard.c (Qdelayed_warnings_hook): Define.
10792 (command_loop_1): Run `delayed-warnings-hook'
10793 if Vdelayed_warnings_list is non-nil.
10794 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10795 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10796
d178f871
EZ
107972011-04-28 Eli Zaretskii <eliz@gnu.org>
10798
10799 * doprnt.c (doprnt): Don't return value smaller than the buffer
10800 size if the message was truncated. (Bug#8545).
10801
b124fd93
JB
108022011-04-28 Juanma Barranquero <lekktu@gmail.com>
10803
10804 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10805 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10806
e810457d
PE
108072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10808
10809 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10810
ea51cceb
JB
108112011-04-27 Juanma Barranquero <lekktu@gmail.com>
10812
10813 * makefile.w32-in: Update dependencies.
10814
94dcfacf
EZ
108152011-04-27 Eli Zaretskii <eliz@gnu.org>
10816
10817 Improve `doprnt' and its usage. (Bug#8545)
10818 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10819 `format_end'. Remove support for %l as a conversion specifier.
10820 Don't use xrealloc. Improve diagnostics when the %l size modifier
10821 is used. Update the commentary.
10822
10823 * eval.c (verror): Simplify calculation of size_t.
10824
10825 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10826 messages.
10827
f61f41d7
PE
108282011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10829
10830 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10831 change.
10832
96fb4434
PE
108332011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10834
10835 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10836 This makes this file independent of the recent pseudovector change.
10837
671875da 108382011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10839
69e9b5a3
PE
10840 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10841
b5f869a7 10842 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10843 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10844 Remove unused local.
c8926152 10845 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10846
841a1577 10847 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10848 GCC 4.6.0 optimizes based on type-based alias analysis.
10849 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10850 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10851 != &v->size, and therefore "v->size = 1; b->size = 2; return
10852 v->size;" must therefore return 1. This assumption is incorrect
10853 for Emacs, since it type-puns struct Lisp_Vector * with many other
10854 types. To fix this problem, this patch adds a new type struct
f904488f 10855 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10856 and pseudovectors, and helps optimizing compilers not get fooled
10857 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10858 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10859 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10860 the size member.
eab3844f
PE
10861 (XSETPVECTYPE): Rewrite in terms of new macro.
10862 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10863 This is a bit clearer, and further avoids the possibility of
10864 undesirable aliasing.
10865 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10866 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10867 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10868 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10869 (ASIZE): Now uses header.size rather than size.
10870 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10871 to avoid the hassle of writing XVECTOR (foo)->header.size.
10872 (struct vectorlike_header): New type.
eab3844f
PE
10873 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10874 object, to help avoid aliasing.
10875 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10876 (SUBRP): Likewise, since Lisp_Subr is a special case.
10877 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10878 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10879 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10880 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10881 changed to be "header.size" and "header.next".
10882 * buffer.h (struct buffer): Likewise.
10883 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10884 * frame.h (struct frame): Likewise.
10885 * process.h (struct Lisp_Process): Likewise.
10886 * termhooks.h (struct terminal): Likewise.
10887 * window.c (struct save_window_data, struct saved_window): Likewise.
10888 * window.h (struct window): Likewise.
10889 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10890 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10891 * buffer.c (init_buffer_once): Likewise.
10892 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10893 special case.
10894 * process.c (Fformat_network_address): Use local var for size,
10895 for brevity.
10896
0df1eac5
PE
10897 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10898
847ab9d1 10899 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10900 * data.c (atof): Remove decl; no longer used or needed.
10901 (digit_to_number): Move to lread.c.
10902 (Fstring_to_number): Use new string_to_number function, to be
10903 consistent with how the Lisp reader treats infinities and NaNs.
10904 Do not assume that floating-point numbers represent EMACS_INT
10905 without losing information; this is not true on most 64-bit hosts.
10906 Avoid double-rounding errors, by insisting on integers when
10907 parsing non-base-10 numbers, as the documentation specifies.
10908 * lisp.h (string_to_number): New decl, replacing ...
10909 (isfloat_string): Remove.
bc0a5c13 10910 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10911 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10912 appears to have been a coding error. Similarly, do not accept
10913 strings like +-1e0 as floating point numbers. Do not report
10914 overflow for integer overflows unless the base is not 10 which
10915 means we have no simple and reliable way to continue.
10916 Break out the floating-point parsing into a new
10917 function string_to_number, so that Fstring_to_number parses
10918 floating point numbers consistently with the Lisp reader.
04f2d78b 10919 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10920 (E_CHAR, EXP_INT): Remove, replacing with ...
10921 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10922 (string_to_number): New function, replacing isfloat_string.
10923 This function checks for valid syntax and produces the resulting
10924 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10925 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10926 so that overflow for non-base-10 numbers is reported only when
10927 there's no portable and simple way to convert to floating point.
452f4150 10928
67769ffc
PE
10929 * textprop.c (set_text_properties_1): Rewrite for clarity,
10930 and to avoid GCC warning about integer overflow.
10931
c20db43f
PE
10932 * intervals.h (struct interval): Use EMACS_INT for members
10933 where EMACS_UINT might cause problems. See
10934 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10935 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10936 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10937 All uses changed.
37aa2f85
PE
10938 (offset_intervals): Tell GCC not to worry about length overflow
10939 when negating a negative length.
c20db43f 10940
2538aa2f
PE
10941 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10942 (overrun_check_free): Likewise.
10943
f2d3008d
PE
10944 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10945 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10946 word size.
10947
ec8df744
PE
10948 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10949 (gnutls_make_error): Rename local to avoid shadowing.
10950 (gnutls_emacs_global_deinit): ifdef out; not used.
10951 (Fgnutls_boot): Use const for pointer to readonly storage.
10952 Comment out unused local. Fix pointer signedness problems.
10953
640ee02d
PE
10954 * lread.c (openp): Don't stuff size_t into an 'int'.
10955 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10956 about possible signed overflow.
10957
6048fb2a
PE
10958 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10959 (GDK_KEY_g): Don't define if already defined.
10960 (xg_prepare_tooltip): Avoid pointer signedness problem.
10961 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10962
fa3c87e1
PE
10963 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10964 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10965
2172544b
PE
10966 * xfns.c (Fx_window_property): Simplify a bit,
10967 to make a bit faster and to avoid GCC 4.6.0 warning.
10968 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10969
9b821a21
PE
10970 * fns.c (internal_equal): Don't assume size_t fits in int.
10971
3c616cfa
PE
10972 * alloc.c (compact_small_strings): Tighten assertion a little.
10973
c2982e87
PE
10974 Replace pEd with more-general pI, and fix some printf arg casts.
10975 * lisp.h (pI): New macro, generalizing old pEd macro to other
10976 conversion specifiers. For example, use "...%"pI"d..." rather
10977 than "...%"pEd"...".
10978 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10979 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10980 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10981 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10982 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10983 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10984 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10985 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10986 64-bit hosts.
10987 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10988 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10989 * print.c (safe_debug_print, print_object): Likewise.
10990 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10991 to int.
6f04d126
PE
10992 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10993 avoiding the 0 flag, which is not portable.
c2982e87
PE
10994 * process.c (Fmake_network_process): Use pI to avoid cast.
10995 * region-cache.c (pp_cache): Likewise.
10996 * xdisp.c (decode_mode_spec): Likewise.
10997 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10998 behavior on 64-bit hosts with printf arg.
6f04d126 10999 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11000 (x_stop_queuing_selection_requests): Likewise.
11001 (x_get_window_property): Don't truncate byte count to an 'int'
11002 when tracing.
0b432f21 11003
5e073ec7
PE
11004 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11005 here, since it parses constructs like leading '-' and spaces,
11006 which are not wanted; and it overflows with large numbers.
11007 Instead, simply match F[0-9]+, which is what is wanted anyway.
11008
36372bf9
PE
11009 * alloc.c: Remove unportable assumptions about struct layout.
11010 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11011 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11012 (allocate_vectorlike, make_pure_vector): Use the new macros,
11013 plus offsetof, to remove unportable assumptions about struct layout.
11014 These assumptions hold on all porting targets that I know of, but
11015 they are not guaranteed, they're easy to remove, and removing them
11016 makes further changes easier.
11017
0b432f21
PE
11018 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11019 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11020 (string_overrun_cookie): Now const. Use initializers that
11021 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11022 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11023 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11024 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11025 multiple of sizeof (EMACS_INT); it need not be, if
11026 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11027 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11028
895009e1
JB
110292011-04-26 Juanma Barranquero <lekktu@gmail.com>
11030
11031 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11032
6a7a1b0b
TZ
110332011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11034
11035 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11036 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11037 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11038
841a1577 110392011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11040
11041 * lisp.h (Qdebug): List symbol.
895009e1 11042 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11043 * keyboard.c (debug-on-event): New variable.
11044 (handle_user_signal): Break into debugger when debug-on-event
11045 matches the current signal symbol.
11046
f2d3ba6f
DN
110472011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11048
11049 * alloc.c (check_sblock, check_string_bytes)
11050 (check_string_free_list): Convert to standard C.
11051
42ce4c63
TZ
110522011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11053
11054 * w32.c (emacs_gnutls_push): Fix typo.
11055
825cd63c
EZ
110562011-04-25 Eli Zaretskii <eliz@gnu.org>
11057
fb11d64d
EZ
11058 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11059 "cast to pointer from integer of different size".
11060
825cd63c
EZ
11061 Improve doprnt and its use in verror. (Bug#8545)
11062 * doprnt.c (doprnt): Document the set of format control sequences
11063 supported by the function. Use SAFE_ALLOCA instead of always
11064 using `alloca'.
11065
11066 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11067 is one byte too soon. Don't use xrealloc; instead xfree and
11068 xmalloc anew.
11069
e061a11b
TZ
110702011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11071
11072 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11073 callbacks stage.
11074
11075 * gnutls.c: Renamed global_initialized to
11076 gnutls_global_initialized. Added internals for the
11077 :verify-hostname-error, :verify-error, and :verify-flags
11078 parameters of `gnutls-boot' and documented those parameters in the
11079 docstring. Start callback support.
9173deec
JB
11080 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11081 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11082 on error. Return error code.
e061a11b
TZ
11083 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11084 (emacs_gnutls_read): Likewise.
11085 (Fgnutls_boot): Return handshake error code.
11086 (emacs_gnutls_handle_error): New function.
11087 (wsaerror_to_errno): Likewise.
11088
11089 * w32.h (emacs_gnutls_pull): Add prototype.
11090 (emacs_gnutls_push): Likewise.
11091
11092 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11093 (emacs_gnutls_push): Likewise.
11094
110952011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11096
11097 * process.c (wait_reading_process_output): Check if GnuTLS
11098 buffered some data internally if no FDs are set for TLS
11099 connections.
11100
11101 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11102 (LIBS): Link to USER_LIBS.
11103 ($(BLD)/gnutls.$(0)): New target.
11104
fa6996bc
EZ
111052011-04-24 Eli Zaretskii <eliz@gnu.org>
11106
eb35682e
EZ
11107 * xdisp.c (handle_single_display_spec): Rename the
11108 display_replaced_before_p argument into display_replaced_p, to
11109 make it consistent with the commentary. Fix typos in the
11110 commentary.
11111
e2ad650c
EZ
11112 * textprop.c (syms_of_textprop): Remove dead code.
11113 (copy_text_properties): Delete obsolete commentary about an
11114 interface that was deleted long ago. Fix typos in the description
11115 of arguments.
11116
1b2de274
EZ
11117 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11118 to changes in oldXMenu/XMenu.h from 2011-04-16.
11119 <menu_help_message, prev_menu_help_message>: Constify.
11120 (IT_menu_make_room): menu->help_text is now `const char **';
11121 adjust.
11122
11123 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11124 to changes in oldXMenu/XMenu.h from 2011-04-16.
11125 (struct XMenu): Declare `help_text' `const char **'.
11126
11127 * xfaces.c <Qunspecified>: Make extern again.
11128
11129 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11130 required by POSIX.
1b2de274 11131
762b15be
EZ
11132 * doc.c (get_doc_string): Improve the format passed to `error'.
11133
11134 * doprnt.c (doprnt): Improve commentary.
11135
11136 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11137
11138 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11139 them with etags.
11140
f1052e5d
EZ
11141 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11142 changes in globals.h immediately force recompilation.
762b15be
EZ
11143 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11144 $(CURDIR)/s/ms-w32.h.
11145 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11146
fa6996bc
EZ
11147 * character.c (Fchar_direction): Function deleted.
11148 (syms_of_character): Don't defsubr it.
11149 <char-direction-table>: Deleted.
11150
e6c3da20
EZ
111512011-04-23 Eli Zaretskii <eliz@gnu.org>
11152
11153 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11154 * doprnt.c: Include limits.h.
11155 (SIZE_MAX): New macro.
04f2d78b
CB
11156 (doprnt): Return a size_t value. 2nd arg is now size_t.
11157 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11158 Improve overflow protection. Support `l' modifier for integer
11159 conversions. Support %l conversion. Don't assume an EMACS_INT
11160 argument for integer conversions and for %c.
11161
11162 * lisp.h (doprnt): Restore prototype.
11163
11164 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11165 $(SRC)/character.h.
11166
11167 * Makefile.in (base_obj): Add back doprnt.o.
11168
11169 * deps.mk (doprnt.o): Add back prerequisites.
11170 (callint.o): Depend on character.h.
11171
11172 * eval.c (internal_lisp_condition_case): Include the handler
11173 representation in the error message.
11174 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11175 when breaking from the loop.
11176
11177 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11178
11179 * callint.c (Fcall_interactively): When displaying error message
11180 about invalid control letter, pass the character's codepoint, not
11181 a pointer to its multibyte form. Improve display of the character
11182 in octal and display also its hex code.
11183
11184 * character.c (char_string): Use %x to display the (unsigned)
11185 codepoint of an invalid character, to avoid displaying a bogus
11186 negative value.
11187
11188 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11189 `error', not SYMBOL_NAME itself.
11190
11191 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11192 character arguments to `error'.
11193
11194 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11195 to `error' in error message about FINAL_CHAR argument. Make sure
11196 FINAL_CHAR is a character, and use %c when it is passed as
11197 argument to `error'.
11198
4ffd0d6b 111992011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11200
11201 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11202
11203 * w32.c: Include <time.h>.
11204 (sys_localtime): New function.
11205
4ffd0d6b 112062011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11207
11208 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11209
4ffd0d6b 11210 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11211
4ffd0d6b 112122011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11213
4ffd0d6b
GM
11214 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11215 zombies (Bug#8467).
aac0c6e3 11216
04c56954
EZ
112172011-04-19 Eli Zaretskii <eliz@gnu.org>
11218
11219 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11220 gl_state.e_property when gl_state.object is Qt.
11221
11222 * insdel.c (make_gap_larger): Remove limitation of buffer size
11223 to <= INT_MAX.
11224
16a43933
CY
112252011-04-18 Chong Yidong <cyd@stupidchicken.com>
11226
11227 * xdisp.c (lookup_glyphless_char_display)
11228 (produce_glyphless_glyph): Handle cons cell entry in
11229 glyphless-char-display.
11230 (Vglyphless_char_display): Document it.
11231
11232 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11233 glyphless-char-display.
11234
4581706e
CY
112352011-04-17 Chong Yidong <cyd@stupidchicken.com>
11236
11237 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11238
11239 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11240
11241 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11242 definition for no-X builds.
11243
4887c6e2 112442011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11245
fd35b6f9
PE
11246 Static checks with GCC 4.6.0 and non-default toolkits.
11247
5c1ccb01
PE
11248 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11249
006c5daa
PE
11250 * process.c (keyboard_bit_set): Define only if SIGIO.
11251 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11252 (send_process): Repair possible setjmp clobbering.
11253
efc736d3
PE
11254 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11255
4e2fe2e6
PE
11256 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11257
f97334a2
PE
11258 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11259
4e75f29d
PE
11260 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11261 Define only if needed.
11262
90efadd1
PE
11263 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11264 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11265 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11266
3c647824
PE
11267 * dispextern.h (struct redisplay_interface): Rename param
11268 to avoid shadowing.
e264f262 11269 * termhooks.h (struct terminal): Likewise.
761383f4 11270 * xterm.c (xembed_send_message): Likewise.
3c647824 11271
b58c5c4a
PE
11272 * insdel.c (make_gap_smaller): Define only if
11273 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11274
cad59032
PE
11275 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11276 it.
11277
c339dc2e
PE
11278 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11279 so that we aren't warned about unused symbols.
11280
91a3e27b
PE
11281 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11282
399c71d3 11283 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11284
8ffc96f5
PE
11285 * xfns.c (x_real_positions): Mark locals as initialized.
11286
eef9bc79
PE
11287 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11288
098db9dd
PE
11289 * xterm.c: Fix problems found by static analysis with other toolkits.
11290 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11291 (x_dispatch_event): Declare static if USE_GTK, and
11292 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11293 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11294 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11295 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11296 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11297
eb18f6cc
PE
11298 * xmenu.c (menu_help_callback): Pointer type fixes.
11299 Use const pointers when pointing at readonly data. Avoid pointer
11300 signedness clashes.
11301 (FALSE): Remove unused macro.
11302 (update_frame_menubar): Remove unused decl.
11303
1fe72bf8
PE
11304 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11305
60d9e1db
PE
11306 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11307 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11308 (single_menu_item): Rename local to avoid shadowing.
11309
39261c26
PE
11310 * keyboard.c (make_lispy_event): Remove unused local var.
11311
018c5e19
PE
11312 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11313 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11314
63d2b86e
PE
11315 * bitmaps: Change bitmaps from unsigned char back to the X11
11316 compatible char. Avoid the old compiler warnings about
11317 out-of-range initializers by using, for example, '\xab' rather
11318 than 0xab.
11319
aefd87e1
PE
11320 * xgselect.c (xgselect_initialize): Check vs interface
11321 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11322
bf501fb9
PE
11323 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11324
e9829fdf
PE
11325 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11326 to read-only memory.
11327
1086c095
PE
11328 * fns.c (vector): Remove; this old hack is no longer needed.
11329
2baccd04 11330 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11331 Remove unused var.
dde42981 11332 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11333
72391843 11334 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11335
436c16df 11336 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11337 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11338 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11339
92bb796d 11340 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11341 (x_term_init): Remove local to avoid shadowing.
92bb796d 11342
764430a3 11343 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11344
11345 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11346 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11347
d1dfb56c
EZ
113482011-04-16 Eli Zaretskii <eliz@gnu.org>
11349
c4354cb4
EZ
11350 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11351
d1dfb56c
EZ
11352 Fix regex.c, syntax.c and friends for buffers > 2GB.
11353 * syntax.h (struct gl_state_s): Declare character position members
11354 EMACS_INT.
11355
11356 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11357
04f2d78b
CB
11358 * textprop.c (verify_interval_modification, interval_of):
11359 Declare arguments EMACS_INT.
d1dfb56c
EZ
11360
11361 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11362 EMACS_INT.
11363
11364 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11365
11366 * indent.c (Fvertical_motion): Local variable it_start is now
11367 EMACS_INT.
11368
11369 * regex.c (re_match, re_match_2, re_match_2_internal)
11370 (bcmp_translate, regcomp, regexec, print_double_string)
11371 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11372 (re_compile_pattern, re_exec): Declare arguments and local
11373 variables `size_t' and `ssize_t' and return values `regoff_t', as
11374 appropriate.
11375 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11376 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11377 <compile_stack_type>: `size' and `avail' are now `size_t'.
11378
11379 * regex.h <regoff_t>: Use ssize_t, not int.
11380 (re_search, re_search_2, re_match, re_match_2): Arguments that
11381 specify buffer/string position and length are now ssize_t and
11382 size_t. Return type is regoff_t.
11383
613052cd
BK
113842011-04-16 Ben Key <bkey76@gmail.com>
11385
11386 * nsfont.m: Fixed bugs in ns_get_family and
11387 ns_descriptor_to_entity that were caused by using free to
11388 deallocate memory blocks that were allocated by xmalloc (via
11389 xstrdup). This caused Emacs to crash when compiled with
11390 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11391 --enable-checking=xmallocoverrun). xfree is now used to
11392 deallocate these memory blocks.
11393
4170f62f 113942011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11395
71b41406
PE
11396 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11397
9587a89d
PE
11398 emacs_write: Accept and return EMACS_INT for sizes.
11399 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11400 et seq.
11401 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11402 Accept and return EMACS_INT.
11403 (emacs_gnutls_write): Return the number of bytes written on
11404 partial writes.
11405 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11406 (emacs_read, emacs_write): Remove check for negative size, as the
11407 Emacs source code has been audited now.
9587a89d
PE
11408 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11409 (emacs_read, emacs_write): Use it.
273a5f82
PE
11410 * process.c (send_process): Adjust to the new signatures of
11411 emacs_write and emacs_gnutls_write. Do not attempt to store
11412 a byte offset into an 'int'; it might overflow.
9587a89d 11413 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11414
3e047f51
PE
11415 * sound.c: Don't assume sizes fit in 'int'.
11416 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11417 Return EMACS_INT, not int.
3e047f51 11418 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11419 Accept EMACS_INT, not int.
11420 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11421 record read return values.
11422
cc39a9db
BK
114232011-04-15 Ben Key <bkey76@gmail.com>
11424
c9d0ec6d
JB
11425 * keyboard.c (Qundefined): Don't declare static since it is used
11426 in nsfns.m.
11427 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11428 static since they are used in nsfont.m.
cc39a9db 11429
6c60eb9f
SM
114302011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11431
11432 * process.c (Qprocessp): Don't declare static.
11433 * lisp.h (Qprocessp): Declare again.
11434
7990b61a
JB
114352011-04-15 Juanma Barranquero <lekktu@gmail.com>
11436
11437 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11438
5d4cb038
PE
114392011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11440
8bd7b830 11441 Improve C-level modularity by making more things 'static'.
cd64ea1d 11442
e3b27b31
PE
11443 Don't publish debugger-only interfaces to other modules.
11444 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11445 (verify_bytepos, count_markers): Move decls to the only modules
11446 that need them.
11447 * region-cache.h (pp_cache): Likewise.
11448 * window.h (check_all_windows): Likewise.
11449 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11450
5d4cb038
PE
11451 * sysdep.c (croak): Now static, if
11452 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11453 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11454
11455 * alloc.c (refill_memory_reserve): Now static if
11456 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11457 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11458
e87b6180
PE
11459 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11460 Define only if USE_LUCID.
11461
ac64929e
PE
11462 * xrdb.c (x_customization_string, x_rm_string): Now static.
11463
6f37259d
PE
11464 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11465 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11466
1683e3ab
PE
11467 * xdisp.c (draw_row_with_mouse_face): Now static.
11468 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11469
de9c2632
PE
11470 * window.h (check_all_windows): Mark externally visible.
11471
2b96acb7
PE
11472 * window.c (window_deletion_count): Now static.
11473
11474 * undo.c: Make symbols static if they're not exported.
11475 (last_undo_buffer, last_boundary_position, pending_boundary):
11476 Now static.
11477
50436f33
PE
11478 * textprop.c (interval_insert_behind_hooks): Now static.
11479 (interval_insert_in_front_hooks): Likewise.
11480
64520e5c
PE
11481 * term.c: Make symbols static if they're not exported.
11482 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11483 (max_frame_lines, tty_set_terminal_modes):
11484 (tty_reset_terminal_modes, tty_turn_off_highlight):
11485 (get_tty_terminal): Now static.
11486 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11487 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11488 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11489 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11490 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11491
1fa53021
PE
11492 * sysdep.c: Make symbols static if they're not exported.
11493 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11494 Now static.
11495 (sigprocmask_set, full_mask): Remove; unused.
11496 (wait_debugging): Mark as visible.
11497 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11498 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11499
d4b43b22
PE
11500 * syntax.c (syntax_temp): Define only if !__GNUC__.
11501
b7c513d0
PE
11502 * sound.c (current_sound_device, current_sound): Now static.
11503
989b29ad
PE
11504 * search.c (searchbufs, searchbuf_head): Now static.
11505
13a55a78
PE
11506 * scroll.c (scroll_cost): Remove; unused.
11507 * dispextern.h (scroll_cost): Remove decl.
11508
de68a1fc
PE
11509 * region-cache.h (pp_cache): Mark as externally visible.
11510
40ccffa6
PE
11511 * process.c: Make symbols static if they're not exported.
11512 (process_tick, update_tick, create_process, chan_process):
11513 (Vprocess_alist, proc_buffered_char, datagram_access):
11514 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11515 (deactivate_process): Mark defn as static, as well as decl.
11516 * lisp.h (create_process): Remove decl.
11517 * process.h (chan_process, Vprocess_alist): Remove decls.
11518
ad64fc97
PE
11519 * print.c: Make symbols static if they're not exported.
11520 (print_depth, new_backquote_output, being_printed, print_buffer):
11521 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11522 (print_interval, print_number_index, initial_stderr_stream):
11523 Now static.
11524 * lisp.h (Fprinc): Remove decl.
11525 (debug_output_compilation_hack): Mark as externally visible.
11526
adddb265
PE
11527 * sysdep.c (croak): Move decl from here to syssignal.h.
11528 * syssignal.h (croak): Put it here, so the API can be checked when
11529 'croak' is called from dissociate_if_controlling_tty.
11530
1717ede2
PE
11531 * minibuf.c: Make symbols static if they're not exported.
11532 (minibuf_save_list, choose_minibuf_frame): Now static.
11533 * lisp.h (choose_minibuf_frame): Remove decl.
11534
fa5fb2bc
PE
11535 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11536
1e3890d1
PE
11537 * lread.c: Make symbols static if they're not exported.
11538 (read_objects, initial_obarray, oblookup_last_bucket_number):
11539 Now static.
11540 (make_symbol): Remove; unused.
11541 * lisp.h (initial_obarray, make_symbol): Remove decls.
11542
8a1414fa
PE
11543 * keyboard.c: Make symbols static if they're not exported.
11544 (single_kboard, recent_keys_index, total_keys, recent_keys):
11545 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11546 (this_single_command_key_start, echoing, last_auto_save):
11547 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11548 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11549 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11550 (Vlispy_mouse_stem, double_click_count):
11551 Now static.
11552 (force_auto_save_soon): Define only if SIGDANGER.
11553 (ignore_mouse_drag_p): Now static if
11554 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11555 (print_help): Remove; unused.
11556 (stop_character, last_timer_event): Mark as externally visible.
11557 * keyboard.h (ignore_mouse_drag_p): Declare only if
11558 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11559 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11560 * lisp.h (echoing): Remove decl.
11561 (force_auto_save_soon): Declare only if SIGDANGER.
11562 * xdisp.c (redisplay_window): Simplify code, to make it more
11563 obvious that ignore_mouse_drag_p is not accessed if !defined
11564 USE_GTK && !defined HAVE_NS.
11565
93ea6e8f
PE
11566 * intervals.c: Make symbols static if they're not exported.
11567 (merge_properties_sticky, merge_interval_right, delete_interval):
11568 Now static.
11569 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11570
77382fcc
PE
11571 * insdel.c: Make symbols static if they're not exported.
11572 However, leave prepare_to_modify_buffer alone. It's never
11573 called from outside this function, but that appears to be a bug.
11574 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11575 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11576 (adjust_after_replace_noundo): Remove; unused.
11577 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11578 (signal_before_change): Remove decls.
77382fcc 11579
9306c32e
PE
11580 * indent.c (val_compute_motion, val_vmotion): Now static.
11581
cd44d2eb
PE
11582 * image.c: Make symbols static if they're not exported.
11583 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11584 if USE_GTK.
11585 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11586 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11587
ad9a7a06
PE
11588 * fringe.c (standard_bitmaps): Now static.
11589 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11590
81626931
PE
11591 * frame.c: Make symbols static if they're not exported.
11592 (x_report_frame_params, make_terminal_frame): Now static.
11593 (get_frame_param): Now static, unless HAVE_NS.
11594 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11595 (x_get_resource_string): Remove; not used.
11596 * frame.h (make_terminal_frame, x_report_frame_params):
11597 (x_get_resource_string); Remove decls.
11598 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11599 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11600
239f9db9
PE
11601 * font.c, fontset.c: Make symbols static if they're not exported.
11602 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11603 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11604 * font.c (font_close_object): Now static.
11605 * font.h (font_close_object): Remove.
11606 * fontset.c (FONTSET_OBJLIST): Remove.
11607 (free_realized_fontset) #if-0 the body, which does nothing.
11608 (face_suitable_for_char_p): #if-0, as it's never called.
11609 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11610 * xfaces.c (face_at_string_position):
11611 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11612 since 0 is always ASCII.
11613
dfcf3579
PE
11614 * fns.c (weak_hash_tables): Now static.
11615
5045092b
PE
11616 * fileio.c: Make symbols static if they're not exported.
11617 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11618 (Vwrite_region_annotation_buffers): Now static.
11619
57a96f5c
PE
11620 * eval.c: Make symbols static if they're not exported.
11621 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11622 * lisp.h (backtrace_list): Remove decl.
11623
35f08c38
PE
11624 * emacs.c: Make symbols static if they're not exported.
11625 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11626 (fatal_error_code, fatal_error_signal_hook, standard_args):
11627 Now static.
11628 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11629 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11630 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11631 * lisp.h (fatal_error_signal_hook): Remove decl.
11632 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11633
f44bd759
PE
11634 * editfns.c: Move a (normally-unused) function to its only use.
11635 * editfns.c, lisp.h (get_operating_system_release): Remove.
11636 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11637 worth the hassle of breaking this out.
11638
b532497d
PE
11639 * xterm.c: Make symbols static if they're not exported.
11640 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11641 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11642 (x_destroy_window, x_delete_display):
11643 Now static.
11644 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11645 (x_mouse_leave): Remove; unused.
11646 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11647 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11648 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11649 Remove decls.
11650 (x_mouse_leave): Declare only if WINDOWSNT.
11651 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11652 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11653 USE_X_TOOLKIT.
11654
1675728f
PE
11655 * ftxfont.c: Make symbols static if they're not exported.
11656 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11657 HAVE_FREETYPE.
11658 * font.h (ftxfont_driver): Likewise.
11659
e4cebfca
PE
11660 * xfns.c: Make symbols static if they're not exported.
11661 (x_last_font_name, x_display_info_for_name):
11662 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11663 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11664 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11665 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11666 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11667 (last_show_tip_args): Now static.
11668 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11669 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11670 (x_screen_planes): Remove; unused.
11671 * dispextern.h (x_screen_planes): Remove decl.
11672
5bf46f05
PE
11673 * dispnew.c: Make symbols static if they're not exported.
11674 * dispextern.h (redraw_garbaged_frames, scrolling):
11675 (increment_row_positions): Remove.
11676 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11677 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11678 Now static.
11679 (redraw_garbaged_frames): Remove; unused.
11680
435f4c28
PE
11681 * xfaces.c: Make symbols static if they're not exported.
11682 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11683 Remove decls.
11684 * xterm.h (defined_color): Remove decls.
11685 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11686 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11687 (menu_face_changed_default, defined_color, free_realized_face):
11688 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11689 (ascii_face_of_lisp_face): Remove; unused.
11690
8524aef3
PE
11691 * xdisp.c: Make symbols static if they're not exported.
11692 * dispextern.h (scratch_glyph_row, window_box_edges):
11693 (glyph_to_pixel_coords, set_cursor_from_row):
11694 (get_next_display_element, set_iterator_to_next):
11695 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11696 (show_mouse_face): Remove decls
11697 * frame.h (message_buf_print): Likewise.
11698 * lisp.h (pop_message, set_message, check_point_in_composition):
11699 Likewise.
11700 * xterm.h (set_vertical_scroll_bar): Likewise.
11701 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11702 (message_buf_print, scratch_glyph_row, displayed_buffer):
11703 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11704 (get_next_display_element, show_mouse_face, window_box_edges):
11705 (frame_to_window_pixel_xy, check_point_in_composition):
11706 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11707 (glyph_to_pixel_coords): Remove; unused.
11708
16390cd2
PE
11709 * dired.c (file_name_completion): Now static.
11710
11711 * dbusbind.c (xd_in_read_queued_messages): Now static.
11712
a25f4dfa
PE
11713 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11714 * data.c (circular_list_error): Remove.
11715
14a9c8df
PE
11716 * commands.h (last_point_position, last_point_position_buffer):
11717 (last_point_position_window): Remove decls.
11718 * keyboard.c: Make these variables static.
11719
04f2d78b
CB
11720 * coding.h (coding, code_convert_region, encode_coding_gap):
11721 Remove decls.
74ab6df5
PE
11722 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11723 (iso_code_class, detect_coding, code_convert_region): Now static.
11724 (encode_coding_gap): Remove; unused.
11725
38dfbee1
PE
11726 * chartab.c (chartab_chars, chartab_bits): Now static.
11727
a2cb4e63
PE
11728 * charset.h (charset_iso_8859_1): Remove decl.
11729 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11730 Now static.
11731
127198fd
PE
11732 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11733 * ccl.c (Vccl_program_table): Now static.
11734 (check_ccl_update): Remove; unused.
11735
d85b608f
PE
11736 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11737 * category.h: ... from here.
11738 * category.c (check_category_table, set_category_set): Now static.
11739
31cd66f3
PE
11740 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11741 * lisp.h: Remove these decls.
11742
c358e587
PE
11743 * buffer.c (buffer_count): Remove unused var.
11744
e78aecca
PE
11745 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11746 so that it's not optimized away.
11747 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11748 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11749 exported only to the debugger.
11750
e192d7d3 11751 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11752 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11753
92470028
PE
11754 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11755 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11756 was inaccessible from Lisp.
11757 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11758 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11759
244ed907
PE
11760 alloc.c: Import and export fewer symbols, and remove unused items.
11761 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11762 is defined.
11763 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11764 it's not optimized away by whole-program optimization.
11765 (message_enable_multibyte, free_misc): Remove.
11766 (catchlist, handlerlist, mark_backtrace):
11767 Declare only if BYTE_MARK_STACK.
11768 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11769 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11770 (message_enable_multibyte): Remove decl.
11771 (free_misc, interval_free_list, float_block, float_block_index):
11772 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11773 (cons_free_list, last_marked_index):
11774 Now static.
11775 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11776 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11777 (mark_backtrace): Define only if BYTE_MARK_STACK.
11778 * xdisp.c (message_enable_multibyte): Now static.
11779
61c2b50e 11780 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11781 This makes it easier for human readers (and static analyzers)
11782 to see whether these variables are used from other modules.
11783 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11784 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11785 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11786 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11787 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11788 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11789 * xmenu.c, xselect.c:
11790 Declare Q* vars static if they are not used in other modules.
11791 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11792 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11793 Remove decls of unexported vars.
11794 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11795
95c82688
PE
11796 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11797
16a97296
PE
11798 Make Emacs functions such as Fatom 'static' by default.
11799 This makes it easier for human readers (and static analyzers)
11800 to see whether these functions can be called from other modules.
11801 DEFUN now defines a static function. To make the function external
11802 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11803 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11804 (Finit_image_library):
16a97296
PE
11805 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11806 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11807 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11808 Remove decls, since these functions are now static.
11809 (Funintern, Fget_internal_run_time): New decls, since these functions
11810 were already external.
95c82688 11811
16a97296
PE
11812 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11813 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11814 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11815 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11816 * keyboard.c, keymap.c, lread.c:
11817 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11818 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11819 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11820 Mark functions with DEFUE instead of DEFUN,
11821 if they are used in other modules.
11822 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11823 decls for now-static functions.
11824 * buffer.h (Fdelete_overlay): Remove decl.
11825 * callproc.c (Fgetenv_internal): Mark as internal.
11826 * composite.c (Fremove_list_of_text_properties): Remove decl.
11827 (Fcomposition_get_gstring): New forward static decl.
11828 * composite.h (Fcomposite_get_gstring): Remove decl.
11829 * dired.c (Ffile_attributes): New forward static decl.
11830 * doc.c (Fdocumntation_property): New forward static decl.
11831 * eval.c (Ffetch_bytecode): New forward static decl.
11832 (Funintern): Remove extern decl; now in .h file where it belongs.
11833 * fileio.c (Fmake_symbolic_link): New forward static decl.
11834 * image.c (Finit_image_library): New forward static decl.
11835 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11836 * intervals.h (Fprevious_property_change):
11837 (Fremove_list_of_text_properties): Remove decls.
11838 * keyboard.c (Fthis_command_keys): Remove decl.
11839 (Fcommand_execute): New forward static decl.
11840 * keymap.c (Flookup_key): New forward static decl.
11841 (Fcopy_keymap): Now static.
11842 * keymap.h (Flookup_key): Remove decl.
11843 * process.c (Fget_process): New forward static decl.
11844 (Fprocess_datagram_address): Mark as internal.
11845 * syntax.c (Fsyntax_table_p): New forward static decl.
11846 (skip_chars): Remove duplicate decl.
11847 * textprop.c (Fprevious_property_change): New forward static decl.
11848 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11849 Now internal.
11850 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11851 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11852
785bbd42
PE
11853 * editfns.c (Fformat): Remove unreachable code.
11854
8b913b57
AS
118552011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11856
11857 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11858 change. (Bug#8496)
11859
a6744a35
EZ
118602011-04-13 Eli Zaretskii <eliz@gnu.org>
11861
11862 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11863 when at ZV. (Bug#8487)
11864
e7974947
AS
118652011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11866
baad03f0
AS
11867 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11868 (Bug#8437)
11869 * keyboard.c (parse_tool_bar_item): Likewise.
11870 * sound.c (sound_cleanup, alsa_close): Likewise.
11871 * termcap.c (tgetent): Likewise.
11872 * xfns.c (x_default_font_parameter): Likewise.
11873 * xsettings.c (read_and_apply_settings): Likewise.
11874
e7974947
AS
11875 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11876 (overrun_check_free): Protoize.
11877
28272684
PE
118782011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11879
11880 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11881 since callers should never pass a negative size.
11882 Change the signature to match that of plain 'read' and 'write'; see
11883 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11884 * lisp.h: Update prototypes of emacs_write and emacs_read.
11885
11997c76
EZ
118862011-04-11 Eli Zaretskii <eliz@gnu.org>
11887
11888 * xdisp.c (redisplay_window): Don't try to determine the character
11889 position of the scroll margin if the window start point w->startp
e896f03c 11890 is outside the buffer's accessible region. (Bug#8468)
11997c76 11891
8a2cbd72
EZ
118922011-04-10 Eli Zaretskii <eliz@gnu.org>
11893
11894 Fix write-region and its subroutines for buffers > 2GB.
11895 * fileio.c (a_write, e_write): Modify declaration of arguments and
11896 local variables to support buffers larger than 2GB.
11897 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11898
11899 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11900 argument, local variables, and return value.
11901
11902 * lisp.h: Update prototypes of emacs_write and emacs_read.
11903
11904 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11905
4073e537 119062011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11907
1ebfdcb6
PE
11908 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11909
b2ded58d
PE
11910 Fix more problems found by GCC 4.6.0's static checks.
11911
7d66342c
PE
11912 * xdisp.c (vmessage): Use a better test for character truncation.
11913
bbf47d44
PE
11914 * charset.c (load_charset_map): <, not <=, for optimization,
11915 and to avoid potential problems with integer overflow.
9248994d 11916 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11917 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11918 * editfns.c (Fformat): Likewise.
1e69125e 11919 * syntax.c (skip_chars): Likewise.
3befa583 11920
e3019616
PE
11921 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11922 This also lets GCC 4.6.0 generate slightly better loop code.
11923
becfa255
PE
11924 * callint.c (Fcall_interactively): <, not <=, for optimization.
11925 (Fcall_interactively): Count the number of arguments produced,
11926 not the number of arguments given. This is simpler and lets GCC
11927 4.6.0 generate slightly better code.
11928
dae0cd48
PE
11929 * ftfont.c: Distingish more carefully between FcChar8 and char.
11930 The previous code passed unsigned char * to a functions like
11931 strlen and xstrcasecmp that expect char *, which does not
11932 conform to the C standard.
11933 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11934 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11935 char * when the C standard requires it.
11936
76032d70
PE
11937 * keyboard.c (read_char): Remove unused var.
11938
eb3f1cc8
PE
11939 * eval.c: Port to Windows vsnprintf (Bug#8435).
11940 Include <limits.h>.
11941 (SIZE_MAX): Define if the headers do not.
11942 (verror): Do not give up if vsnprintf returns a negative count.
11943 Instead, grow the buffer. This ports to Windows vsnprintf, which
11944 does not conform to C99. Problem reported by Eli Zaretskii.
11945 Also, simplify the allocation scheme, by avoiding the need for
11946 calling realloc, and removing the ALLOCATED variable.
11947
70476b54
PE
11948 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11949
12020a9e
PE
11950 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11951 But keep the doprint source code for now, as we might revamp it
11952 and use it again (Bug#8435).
ea6c7ae6
PE
11953 * lisp.h (doprnt): Remove.
11954 * Makefile.in (base_obj): Remove doprnt.o.
11955 * deps.mk (doprnt.o): Remove.
11956
5fdb398c
PE
11957 error: Print 32- and 64-bit integers portably (Bug#8435).
11958 Without this change, on typical 64-bit hosts error ("...%d...", N)
11959 was used to print both 32- and 64-bit integers N, which relied on
11960 undefined behavior.
61bdb816 11961 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11962 * lisp.h (error, verror): Mark as printf-like functions.
11963 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11964 Report overflow in size calculations when allocating printf buffer.
11965 Do not truncate output string at its first null byte.
11966 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11967 Truncate the output at a character boundary, since vsnprintf does not
11968 do that.
11969 * charset.c (check_iso_charset_parameter): Convert internal
11970 character to string before calling 'error', since %c now has the
11971 printf meaning.
11972 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11973 overflow when computing char to be passed to 'error'. Do not
11974 pass Lisp_Object to 'error'; pass the integer instead.
11975 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11976 formatted with plain %d.
11977
b189fa66
PE
11978 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11979
bff87ef0
PE
11980 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11981
7e2cac20
PE
11982 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11983
ce4d90b5
PE
11984 * xterm.c (x_catch_errors): Remove duplicate declaration.
11985
266c9547
PE
11986 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11987
79c49ad2
PE
11988 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11989
368f4090
JM
119902011-04-10 Jim Meyering <meyering@redhat.com>
11991
11992 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11993 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11994 return ssize_t not "int", and use size_t as the buffer length.
11995 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11996 * gnutls.h: Update declarations.
11997 * process.c (read_process_output): Use ssize_t, to match.
11998 (send_process): Likewise.
11999
a32d4040
CY
120002011-04-09 Chong Yidong <cyd@stupidchicken.com>
12001
12002 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12003
8546720e 120042011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12005
04f2d78b
CB
12006 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12007 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12008
8546720e
GM
12009 * xterm.c (handle_one_xevent):
12010 * xmenu.c (create_and_show_popup_menu):
12011 * xselect.c (x_decline_selection_request)
12012 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12013
0a2f5c1a 120142011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12015
12016 Fix some uses of `int' instead of EMACS_INT.
12017 * search.c (string_match_1, fast_string_match)
12018 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12019 (scan_buffer, find_next_newline_no_quit)
12020 (find_before_next_newline, search_command, Freplace_match)
12021 (Fmatch_data): Make some `int' variables be EMACS_INT.
12022
12023 * xdisp.c (display_count_lines): 3rd argument and return value now
12024 EMACS_INT. All callers changed.
12025 (pint2hrstr): Last argument is now EMACS_INT.
12026
12027 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12028 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12029 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12030 (decode_coding_utf_16, decode_coding_emacs_mule)
12031 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12032 (decode_coding_ccl, decode_coding_charset)
12033 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12034 (decode_coding_iso_2022, decode_coding_emacs_mule)
12035 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12036 <char_offset, last_offset>: Declare EMACS_INT.
12037 (encode_coding_utf_8, encode_coding_utf_16)
12038 (encode_coding_emacs_mule, encode_invocation_designation)
12039 (encode_designation_at_bol, encode_coding_iso_2022)
12040 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12041 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12042 Declare EMACS_INT.
12043 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12044 (encode_invocation_designation): Last argument P_NCHARS is now
12045 EMACS_INT.
12046 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12047 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12048
12049 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12050 All users changed.
12051
12052 * ccl.c (Fccl_execute_on_string): Declare some variables
12053 EMACS_INT.
12054
8546720e 120552011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12056
12057 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12058
4e19a977
CS
120592011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12060
12061 * process.c (Fformat_network_address): Doc fix.
12062
87302331
R
120632011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12064
ee7683eb 12065 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12066
cbb59342
CY
120672011-04-08 Chong Yidong <cyd@stupidchicken.com>
12068
12069 * keyboard.c (read_char): Call Lisp function help-form-show,
12070 instead of using internal_with_output_to_temp_buffer.
12071 (Qhelp_form_show): New var.
e0d38eeb 12072 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12073
12074 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12075
12076 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12077
e67a13ab
CY
120782011-04-06 Chong Yidong <cyd@stupidchicken.com>
12079
04f2d78b
CB
12080 * process.c (Flist_processes): Remove to Lisp.
12081 (list_processes_1): Delete.
e67a13ab 12082
973f782d
EZ
120832011-04-06 Eli Zaretskii <eliz@gnu.org>
12084
7c106b1e
EZ
12085 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12086
973f782d
EZ
12087 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12088
41cf7d1a 120892011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12090
ca23cc88
PE
12091 Fix more problems found by GCC 4.6.0's static checks.
12092
f390e2d5
PE
12093 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12094
42eea0d0
PE
12095 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12096
b69769da 12097 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12098
f9541e84
PE
12099 * xdisp.c (vmessage): Mark as a printf-like function.
12100
13841b55
PE
12101 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12102
c136c10f
PE
12103 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12104
5e2d4a30
PE
12105 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12106 printf-like functions.
12107 (tiff_load): Add casts to remove these marks before passing them
12108 to system-supplied API.
12109
583f48b9
PE
12110 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12111
b25d760e
PE
12112 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12113 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12114 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12115 directly, rather than having caller test rule sign. This avoids
12116 some unnecessary tests.
12117 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12118 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12119 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12120
bc7b6697 12121 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12122 (xfont_open): Avoid unnecessary tests.
bc7b6697 12123
27ccc379
PE
12124 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12125
dcd5c89a
PE
12126 * composite.h, composite.c (composition_gstring_put_cache):
12127 Use EMACS_INT, not int, for length.
12128
b13a45c6
PE
12129 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12130 breaking out part of COMPOSITION_DECODE_RULE.
12131 (COMPOSITION_DECODE_RULE): Use it.
12132 * composite.c (get_composition_id): Remove unused local vars,
12133 by using the new macro.
12134
1e792e4d
PE
12135 * textprop.c (set_text_properties_1): Change while to do-while,
12136 since the condition is always true at first.
12137
dc6c6455 12138 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12139 (interval_deletion_adjustment): Return unsigned value.
12140 All uses changed.
dc6c6455 12141
aba7731a
PE
12142 * process.c (list_processes_1, create_pty, read_process_output):
12143 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12144 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12145 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12146 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12147 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12148
fdfc4bf3
PE
12149 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12150
fca8fe46 12151 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12152 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12153
06a0259a 12154 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12155 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12156 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12157
e7b9e80f
PE
12158 * print.c (print_error_message): Avoid int overflow.
12159
56201685
PE
12160 * font.c (font_list_entities): Redo for clarity,
12161 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12162
78834453 12163 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12164 (font_score): Avoid potential overflow in diff calculation.
78834453 12165
0bc0b309 12166 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12167 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12168
e610eaca
PE
12169 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12170
b895abce
PE
12171 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12172 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12173 can always succeed if overflow has undefined behavior.
12174
1f1d9321 12175 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12176 (wordify): Omit three unnecessary tests.
1f1d9321 12177
c59478bc
PE
12178 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12179 All callers changed. This avoids the need for an unused var.
12180
79b73827
PE
12181 * casefiddle.c (casify_region): Remove var that is set but not used.
12182
a4db5dfe
PE
12183 * dired.c (file_name_completion): Remove var that is set but not used.
12184
43aae36e
PE
12185 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12186
2a47c44d 12187 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12188 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12189
a37c69bf
PE
12190 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12191 Check for integer overflow on size calculations.
12192
328ab8e7
PE
12193 * buffer.c (Fprevious_overlay_change): Remove var that is set
12194 but not used.
12195
e5a2a5cb
PE
12196 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12197 Remove vars that are set but not used.
8d84a6eb 12198 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12199 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12200
a60e5f68
PE
12201 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12202
f661cb61 12203 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12204 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12205
f0397f5a
PE
12206 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12207 that are set but not used.
12208
8664db06 12209 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12210 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12211
6abdaa4a
PE
12212 * xselect.c (x_get_local_selection, x_handle_property_notify):
12213 Remove vars that are set but not used.
12214
0ce7538d 12215 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12216 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12217
9ae848fc
PE
12218 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12219 Remove var that is set but not used.
0b918413
PE
12220 (scroll_bar_windows_size): Now size_t, not int.
12221 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12222 Check for overflow.
9ae848fc 12223
a5a62657
PE
12224 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12225 (map_tty_color) [!defined MSDOS]: Likewise.
12226
5c5cdd39
PE
12227 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12228
66ebf983
PE
12229 * coding.c: Remove vars that are set but not used.
12230 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12231 All callers changed.
12232 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12233 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12234 (decode_coding_charset): Remove vars that are set but not used.
12235
1be4d761
PE
12236 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12237 that is set but not used.
12238
47553fa8
PE
12239 * print.c (print_object): Remove var that is set but not used.
12240
1f7196bf 12241 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12242 The gnulib version avoids calling malloc in the usual case,
12243 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12244 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12245 * filelock.c (current_lock_owner): Likewise.
12246 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12247 * sysdep.c: Include allocator.h, careadlinkat.h.
12248 (emacs_no_realloc_allocator): New static constant.
12249 (emacs_readlink): New function.
fdb61804
PE
12250 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12251 ../lib/careadlinkat.h.
d1fdcab7 12252
f84c17c7
SM
122532011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12254
12255 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12256 first non-nil return value).
12257
ef3862ad
JD
122582011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12259
12260 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12261 if not defined (Bug#8403).
12262
376a7006
JB
122632011-04-02 Juanma Barranquero <lekktu@gmail.com>
12264
12265 * xdisp.c (display_count_lines): Remove parameter `start',
12266 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12267 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12268 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12269 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12270 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12271 and thereabouts. All callers changed.
12272 (get_per_char_metric): Remove parameter `f', unused since
12273 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12274
6ca3801d
JM
122752011-04-02 Jim Meyering <meyering@redhat.com>
12276
12277 do not dereference NULL upon failed strdup
12278 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12279 (ns_get_family): Likewise.
12280
d8e2b5ba
JB
122812011-04-02 Juanma Barranquero <lekktu@gmail.com>
12282
12283 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12284
8c74fcbd
JD
122852011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12286
12287 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12288 later (Bug#8403).
12289
7200d79c
SM
122902011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12291
03408648 12292 Add lexical binding.
7200d79c 12293
03408648
SM
12294 * window.c (Ftemp_output_buffer_show): New fun.
12295 (Fsave_window_excursion):
12296 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12297
12298 * lread.c (lisp_file_lexically_bound_p): New function.
12299 (Fload): Bind Qlexical_binding.
12300 (readevalloop): Remove `evalfun' arg.
12301 Bind Qinternal_interpreter_environment.
12302 (Feval_buffer): Bind Qlexical_binding.
12303 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12304 Mark as dynamic.
12305 (syms_of_lread): Declare `lexical-binding'.
12306
12307 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12308
12309 * keyboard.c (eval_dyn): New fun.
12310 (menu_item_eval_property): Use it.
ca105506
SM
12311
12312 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12313
03408648
SM
12314 * fns.c (concat, mapcar1): Accept byte-code-functions.
12315
12316 * eval.c (Fsetq): Handle lexical vars.
12317 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12318 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12319 (FletX, Flet): Obey lexical binding.
12320 (Fcommandp): Handle closures.
12321 (Feval): New `lexical' arg.
12322 (eval_sub): New function extracted from Feval. Use it almost
12323 everywhere where Feval was used. Look up vars in lexical env.
12324 Handle closures.
12325 (Ffunctionp): Move from subr.el.
12326 (Ffuncall): Handle closures.
12327 (apply_lambda): Remove `eval_flags'.
12328 (funcall_lambda): Handle closures and new byte-code-functions.
12329 (Fspecial_variable_p): New function.
12330 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12331 but without exporting it to Lisp.
23aba0ea 12332
23aba0ea 12333 * doc.c (Fdocumentation, store_function_docstring):
03408648 12334 * data.c (Finteractive_form): Handle closures.
23aba0ea 12335
03408648
SM
12336 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12337 interactive spec.
ba83908c 12338
04f2d78b
CB
12339 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12340 New byte-codes.
03408648
SM
12341 (exec_byte_code): New function extracted from Fbyte_code to handle new
12342 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12343
03408648 12344 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12345
03408648 12346 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12347
e2abce01
JB
123482011-03-31 Juanma Barranquero <lekktu@gmail.com>
12349
12350 * xdisp.c (redisplay_internal): Fix prototype.
12351
63696a73 123522011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12353
63696a73 12354 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12355 (try_scrolling): Use it when setting scroll_limit.
12356 Limit scrolling to 100 screen lines.
63696a73
EZ
12357 (redisplay_window): Even when falling back on "recentering",
12358 position point in the window according to scroll-conservatively,
12359 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12360
12361 (try_scrolling): When point is above the window, allow searching
12362 as far as scroll_max, or one screenful, to compute vertical
12363 distance from PT to the scroll margin position. This prevents
12364 try_scrolling from unnecessarily failing when
12365 scroll-conservatively is set to a value slightly larger than the
12366 window height. Clean up the case of PT below the margin at bottom
12367 of window: scroll_max can no longer be INT_MAX. When aggressive
12368 scrolling is in use, don't let point enter the opposite scroll
12369 margin as result of the scroll.
12370 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12371 threshold of 100 lines for never-recentering scrolling.
12372
e4cc2dfc
JB
123732011-03-31 Juanma Barranquero <lekktu@gmail.com>
12374
12375 * dispextern.h (move_it_by_lines):
12376 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12377 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12378 (message_log_check_duplicate): Remove parameters `prev_bol' and
12379 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12380 (redisplay_internal): Remove parameter `preserve_echo_area',
12381 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12382
12383 * indent.c (Fvertical_motion):
12384 * window.c (window_scroll_pixel_based, Frecenter):
12385 Don't pass `need_y_p' to `move_it_by_lines'.
12386
1c470562
SM
123872011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12388
44f230aa
SM
12389 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12390 steal a few bits to be more compact.
12391 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12392 Remove unneeded casts.
12393
1c470562
SM
12394 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12395
888adce9
ZK
123962011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12397
12398 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12399 binding" message (bug#7967).
12400
f838ed7b
PE
124012011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12402
77861b95
PE
12403 Fix more problems found by GCC 4.6.0's static checks.
12404
de6dbc14
PE
12405 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12406 Remove unused local var.
12407
f838ed7b
PE
12408 * editfns.c (Fmessage_box): Remove unused local var.
12409
792c7b2b
PE
12410 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12411 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12412 Omit unused local vars.
c499e557 12413 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12414 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12415 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12416 Omit unused local var.
12417
ba0165e1
PE
12418 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12419 Don't assume string length fits in int.
32ad8845 12420 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12421 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12422
3c59b4c9
PE
12423 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12424 instead of alloca (Bug#8344).
12425
a3eed478 12426 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12427 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12428
eb4d412d
PE
12429 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12430
1658b401
PE
12431 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12432 concerns.
12433
12434 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12435
12436 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12437
9a2c6e05
PE
12438 * keyboard.c (syms_of_keyboard): Use the same style as later
12439 in this function when indexing through an array. This also
12440 works around GCC bug 48267.
12441
03d0a109
PE
12442 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12443
44f730c8
PE
12444 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12445
fe75f926
PE
12446 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12447 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12448
ffa8c828
PE
12449 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12450 This avoids undefined behavior on integer overflow, and is a bit
12451 more convenient anyway since it is compared to a size_t variable.
12452
c5101a77
PE
12453 Variadic C functions now count arguments with size_t, not int.
12454 This avoids an unnecessary limitation on 64-bit machines, which
12455 caused (substring ...) to crash on large vectors (Bug#8344).
12456 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12457 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12458 All variadic functions and their callers changed accordingly.
c5101a77
PE
12459 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12460 * data.c (arith_driver, float_arith_driver): Likewise.
12461 * editfns.c (general_insert_function): Likewise.
12462 * eval.c (struct backtrace.nargs, interactive_p)
12463 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12464 (funcall_lambda, mark_backtrace): Likewise.
12465 * fns.c (concat): Likewise.
12466 * frame.c (x_set_frame_parameters): Likewise.
12467 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12468 0 if not found, not -1. All callers changed.
12469
dd3f25f7
PE
12470 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12471 (stack_copy_size): Now size_t, not int.
12472 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12473
461c2ab9
JB
124742011-03-28 Juanma Barranquero <lekktu@gmail.com>
12475
12476 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12477 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12478 All callers changed.
12479
12480 * lisp.h (multibyte_char_to_unibyte):
12481 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12482 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12483 * character.h (CHAR_TO_BYTE8):
12484 * cmds.c (internal_self_insert):
12485 * editfns.c (general_insert_function):
12486 * keymap.c (push_key_description):
12487 * search.c (Freplace_match):
12488 * xdisp.c (message_dolog, set_message_1): All callers changed.
12489
f6d62986
SM
124902011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12491
12492 * keyboard.c (safe_run_hook_funcall): New function.
12493 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12494 don't set the hook to nil, but remove the offending function instead.
12495 (Qcommand_hook_internal): Remove, unused.
12496 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12497 Vcommand_hook_internal.
12498
12499 * eval.c (enum run_hooks_condition): Remove.
12500 (funcall_nil, funcall_not): New functions.
12501 (run_hook_with_args): Call each function through a `funcall' argument.
12502 Remove `cond' argument, now redundant.
12503 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12504 (Frun_hook_with_args_until_failure): Adjust accordingly.
12505 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12506
1db5b1ad
JB
125072011-03-28 Juanma Barranquero <lekktu@gmail.com>
12508
12509 * dispextern.h (string_buffer_position): Remove declaration.
12510
12511 * print.c (strout): Remove parameter `multibyte', unused since
12512 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12513
12514 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12515 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12516 All callers changed.
12517
12518 * w32.c (_wsa_errlist): Use braces for struct initializers.
12519
12520 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12521 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12522 All callers changed.
12523 (string_buffer_position): Likewise. Also, make static (it's never
12524 used outside xdisp.c).
12525 (cursor_row_p): Remove parameter `w', unused since
12526 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12527 (decode_mode_spec): Remove parameter `precision', introduced during
12528 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12529 All callers changed.
12530
5ffb62aa
JD
125312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12532
12533 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12534
461c2ab9 125352011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12536
12537 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12538 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12539 (ns_update_auto_hide_menu_bar): New functions.
12540 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12541 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12542 ns_constrain_all_frames.
12543 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12544 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12545
5c380ffb
JD
125462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12547
12548 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12549
9af30bdf
GM
125502011-03-27 Glenn Morris <rgm@gnu.org>
12551
12552 * syssignal.h: Replace RETSIGTYPE with void.
12553 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12554 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12555 Replace SIGTYPE with void everywhere.
12556 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12557 * s/template.h (SIGTYPE): Remove commented out definition.
12558
e2abce01
JB
125592011-03-26 Eli Zaretskii <eliz@gnu.org>
12560
12561 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12562 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12563
f868cd8a
JB
125642011-03-26 Juanma Barranquero <lekktu@gmail.com>
12565
59eb0929
JB
12566 * w32.c (read_unc_volume): Use parameter `henum', instead of
12567 global variable `wget_enum_handle'.
12568
12569 * keymap.c (describe_vector): Remove parameters `indices' and
12570 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12571 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12572
f868cd8a
JB
12573 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12574
12575 * keyboard.c (timer_check): Remove parameter `do_it_now',
12576 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12577 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12578 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12579
12580 * keyboard.c (read_char):
12581 * w32menu.c (w32_menu_display_help):
12582 * xmenu.c (show_help_event, menu_help_callback):
12583 Adjust calls to `show_help_echo'.
12584
12585 * gtkutil.c (xg_maybe_add_timer):
12586 * keyboard.c (readable_events):
12587 * process.c (wait_reading_process_output):
12588 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12589
12590 * insdel.c (adjust_markers_gap_motion):
12591 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12592 (gap_left, gap_right): Don't call it.
12593
2ecf6fdb
CY
125942011-03-25 Chong Yidong <cyd@stupidchicken.com>
12595
12596 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12597 incurred during fontification.
12598
6b1f9ba4
JB
125992011-03-25 Juanma Barranquero <lekktu@gmail.com>
12600
12601 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12602 (DEFVAR_PER_BUFFER): Don't pass it.
12603
12604 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12605 (scrolling_window): Don't pass it.
12606
0f4a96b5
JB
126072011-03-25 Juanma Barranquero <lekktu@gmail.com>
12608
12609 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12610
12611 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12612 and `suffix'.
12613 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12614 of variables specific to SELinux and computation of `encoded_absname'.
12615
12616 * image.c (XPutPixel): Remove unused variable `height'.
12617
12618 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12619
12620 * unexw32.c (get_section_info): Remove unused variable `section'.
12621
12622 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12623 (system_process_attributes): Remove unused variable `sess'.
12624 (sys_read): Remove unused variable `err'.
12625
12626 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12627 (w32_wnd_proc): Remove unused variable `isdead'.
12628 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12629 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12630 (x_create_tip_frame): Remove unused variable `tem'.
12631
12632 * w32inevt.c (w32_console_read_socket):
12633 Remove unused variable `no_events'.
12634
12635 * w32term.c (x_draw_composite_glyph_string_foreground):
12636 Remove unused variable `width'.
12637
1149507c
JB
126382011-03-24 Juanma Barranquero <lekktu@gmail.com>
12639
12640 * w32term.c (x_set_glyph_string_clipping):
12641 Don't pass uninitialized region to CombineRgn.
12642
9c88f339
JB
126432011-03-23 Juanma Barranquero <lekktu@gmail.com>
12644
12645 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12646 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12647 (Fx_close_connection): Remove unused variable `i'.
12648
12649 * w32font.c (w32font_draw): Return number of glyphs.
12650 (w32font_open_internal): Remove unused variable `i'.
12651 (w32font_driver): Add missing initializer.
12652
12653 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12654 (fill_in_menu): Remove unused variable `items_added'.
12655
12656 * w32term.c (last_mouse_press_frame): Remove static global variable.
12657 (w32_clip_to_row): Remove unused variable `f'.
12658 (x_delete_terminal): Remove unused variable `i'.
12659
12660 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12661 (NOTHING): Remove unused static global variable.
12662 (uniscribe_check_otf): Remove unused variable `table'.
12663 (uniscribe_font_driver): Add missing initializers.
12664
dee091a3
JD
126652011-03-23 Julien Danjou <julien@danjou.info>
12666
12667 * term.c (Fsuspend_tty, Fresume_tty):
12668 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12669 * window.c (temp_output_buffer_show):
12670 * insdel.c (signal_before_change):
12671 * frame.c (Fhandle_switch_frame):
12672 * fileio.c (Fdo_auto_save):
12673 * emacs.c (Fkill_emacs):
12674 * editfns.c (save_excursion_restore):
12675 * cmds.c (internal_self_insert):
12676 * callint.c (Fcall_interactively):
12677 * buffer.c (Fkill_all_local_variables):
12678 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12679 Use Frun_hooks.
0f4a96b5 12680 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12681 unconditionally since it does the check itself.
dee091a3 12682
2c520ab5 126832011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12684
c9c49752
PE
12685 Fix more problems found by GCC 4.5.2's static checks.
12686
8abc3f12
PE
12687 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12688 the first time through the loop, since we know p0 < p1 then.
12689 This also avoids a gcc -Wstrict-overflow warning.
12690
a2d26660
PE
12691 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12692 leading to a memory leak, possible in functions like
12693 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12694 of objects (Bug#8318).
a2d26660 12695
916c72e9
PE
12696 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12697 that could (at least in theory) be that large.
12698
19ab8a18
PE
12699 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12700 This is less likely to overflow, and avoids undefined behavior if
12701 overflow does occur. All callers changed. Use strtoul to scan
12702 for the unsigned long integer.
b7cbbd6f
PE
12703 (pint2hrstr): Simplify and tune code slightly.
12704 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12705
f0641eff
PE
12706 * scroll.c (do_scrolling): Work around GCC bug 48228.
12707 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12708
7f650bb9
PE
12709 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12710 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12711 (validate_x_resource_name): Simplify count usage.
12712 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12713
37dd57d1
PE
12714 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12715 fail (Bug#8306).
81e56e61 12716
699979fc 12717 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12718
401bf9b4
PE
12719 * process.c (Fmake_network_process): Use socklen_t, not int,
12720 where POSIX says socklen_t is required in portable programs.
12721 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12722 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12723 (Fmake_network_process, server_accept_connection):
12724 (wait_reading_process_output, read_process_output):
12725 Likewise.
12726
b93aacde
PE
12727 * process.c: Rename or move locals to avoid shadowing.
12728 (list_processes_1, Fmake_network_process):
12729 (read_process_output_error_handler, exec_sentinel_error_handler):
12730 Rename or move locals.
4dc343ee 12731 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12732 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12733 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12734 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12735 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12736
af8a867c 12737 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12738 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12739 Include tparam.h instead, since it declares them.
af8a867c
PE
12740 * cm.h (PC): Remove extern decl; tparam.h now does this.
12741 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12742 * terminfo.c: Include tparam.h, to check interfaces.
12743 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12744 (tparam): Adjust signature to match interface in tparam.h;
12745 this removes some undefined behavior. Check that outstring and len
12746 are zero, which they always are with Emacs.
12747 * tparam.h (PC, BC, UP): New extern decls.
12748
0248044d 12749 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12750 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12751
8ff096c1 12752 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12753 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12754 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12755 (ftfont_list): Remove unused local.
49eaafba
PE
12756 (get_adstyle_property, ftfont_pattern_entity):
12757 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12758 Rename locals to avoid shadowing.
8ff096c1 12759
e2be39f6
PE
12760 * xfont.c (xfont_list_family): Mark var as initialized.
12761
c9735e30
PE
12762 * xml.c (make_dom): Now static.
12763
8f5201ae
PE
12764 * composite.c (composition_compute_stop_pos): Rename local to
12765 avoid shadowing.
b246f932
PE
12766 (composition_reseat_it): Remove unused locals.
12767 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12768 (composition_update_it): Mark var as initialized.
11b61122
PE
12769 (find_automatic_composition): Mark vars as initialized,
12770 with a FIXME (Bug#8290).
8f5201ae 12771
760fbc2c
PE
12772 character.h: Rename locals to avoid shadowing.
12773 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12774 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12775 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12776 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12777 to avoid shadowing.
12778
ff08eb85
PE
12779 * textprop.c (property_change_between_p): Remove; unused.
12780
fc7bf025
PE
12781 * intervals.c (interval_start_pos): Now static.
12782
235d7abc
PE
12783 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12784
44f230aa
SM
12785 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12786 Rename locals to avoid shadowing.
3e7d6594 12787
50060332
PE
12788 * sound.c (wav_play, au_play, Fplay_sound_internal):
12789 Fix pointer signedness.
d01f234b 12790 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12791 (wav_play): Initialize a variable to 0, to prevent undefined
12792 behavior (Bug#8278).
50060332 12793
c4fc4e30
PE
12794 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12795
918436ed
PE
12796 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12797
c939f91b
PE
12798 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12799 clobbering (Bug#8298).
b9c7f648
PE
12800 * sysdep.c (sys_subshell): Likewise.
12801 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12802
6bd8c144
PE
12803 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12804 This should get cleaned up, so that child_setup has the
12805 same signature on all platforms.
12806
7710357c 12807 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12808 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12809
c59da222
CY
128102011-03-22 Chong Yidong <cyd@stupidchicken.com>
12811
12812 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12813 not to be necessary, and produces flickering.
12814
66b87493
GM
128152011-03-20 Glenn Morris <rgm@gnu.org>
12816
12817 * config.in: Remove file.
12818
45b6f6d5
JB
128192011-03-20 Juanma Barranquero <lekktu@gmail.com>
12820
12821 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12822 are now in src/globals.h.
12823 (syms_of_minibuf): Remove spurious & from previous change.
12824
cd394be1 128252011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12826
12827 * minibuf.c (completing-read-function): New variable.
12828 (completing-read-default): Rename from completing-read.
12829 (completing-read): Call completing-read-function.
12830
b14e3e21
CY
128312011-03-19 Juanma Barranquero <lekktu@gmail.com>
12832
12833 * xfaces.c (Fx_load_color_file):
12834 Read color file from absolute filename (bug#8250).
12835
f2b726e6
JB
128362011-03-19 Juanma Barranquero <lekktu@gmail.com>
12837
12838 * makefile.w32-in: Update dependencies.
12839
09f6ff02
EZ
128402011-03-17 Eli Zaretskii <eliz@gnu.org>
12841
12842 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12843
29a6015a
PE
128442011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12845
a3a6c54e
PE
12846 Fix more problems found by GCC 4.5.2's static checks.
12847
b766f867
PE
12848 * process.c (make_serial_process_unwind, send_process_trap):
12849 (sigchld_handler): Now static.
12850
be02381c
PE
12851 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12852 That way, the code declares only the vars that it needs.
12853 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12854 * s/cygwin.h (PTY_ITERATION): Likewise.
12855 * s/darwin.h (PTY_ITERATION): Likewise.
12856 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12857
57048744
PE
12858 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12859 * process.c (allocate_pty): Don't declare stb unless it's needed.
12860
7914961c 12861 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12862 (CONSTANTLIM): Remove; unused.
12863 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12864 Define only if needed.
7914961c 12865
b3967b18
PE
12866 * unexelf.c (unexec): Name an expression,
12867 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12868 Use a different way to cause a compilation error if anyone uses
12869 n rather than nn, a way that does not involve shadowing.
73366a00 12870 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12871
29a6015a
PE
12872 * deps.mk (unexalpha.o): Remove; unused.
12873
43cfc33e 12874 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12875 * unexec.h: New file.
ce701a33
PE
12876 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12877 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12878 Depend on unexec.h.
12879 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12880 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12881 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12882 Change as necessary to match prototype in unexec.h.
ce701a33 12883
01f44d5a
PE
12884 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12885 shadowing.
4f63c6bb 12886 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12887
a6670b0b
PE
12888 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12889 Rename locals to avoid shadowing.
12890
cef2010d 12891 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12892 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12893
d4d7173a
PE
12894 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12895
f08b802a
PE
12896 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12897 warning when compiling print.c.
12898
3ddb0639
PE
12899 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12900 instead of using an uninitialized var.
5ad03b97 12901 (font_sort_entities): Mark var as initialized.
3ddb0639 12902
170a2692
PE
12903 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12904
e663c700
PE
12905 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12906 pointers to constants.
89bc529a 12907 (font_parse_fcname): Remove unused vars.
7b81e2d0 12908 (font_delete_unmatched): Now static.
ea838e10 12909 (font_get_spec): Remove; unused.
13a547c6
PE
12910 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12911 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12912 Rename or move locals to avoid shadowing.
e663c700 12913
2a80c887 12914 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12915 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12916
1384fa33 12917 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12918 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12919
8b2c52e9
PE
12920 * alloc.c (mark_backtrace): Move decl from here ...
12921 * lisp.h: ... to here, so that it can be checked.
12922
475545b5 12923 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12924 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12925 (lisp_indirect_variable): Name an expression,
12926 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12927 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12928
b1349114 12929 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12930 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12931 Use const pointer when appropriate.
b1349114 12932
a2928364
PE
12933 * lisp.h (get_system_name, get_operating_system_release):
12934 Move decls here, to check interfaces.
12935 * process.c (get_operating_system_release): Move decl to lisp.h.
12936 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12937 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12938 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12939 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12940 (Fformat_time_string, Fencode_time, Finsert_char):
12941 (Ftranslate_region_internal, Fformat):
12942 Rename or remove local vars to avoid shadowing.
9710023e 12943 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12944
a415e694
PE
12945 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12946 avoid shadowing.
12947
8ef4622d
PE
12948 * lisp.h (eassert): Check that the argument compiles, even if
12949 ENABLE_CHECKING is not defined.
12950
946f9a5b
PE
12951 * data.c (Findirect_variable): Name an expression, to avoid
12952 gcc -Wbad-function-cast warning.
112396d6 12953 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12954 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12955 (Fmake_variable_buffer_local, Fmake_local_variable):
12956 Mark variables as initialized.
52746918 12957 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12958
e5aab7e7 12959 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12960 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12961 Rename locals to avoid shadowing.
dff45157
PE
12962 (mark_stack): Move local variables into the #ifdef region where
12963 they're used.
7bc26fdb
PE
12964 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12965 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12966 needed otherwise.
12967 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12968 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12969 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12970
e5aab7e7
PE
12971 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12972 avoids undefined behavior in theory.
12973
4da60324
PE
12974 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12975
88043301
PE
12976 Use functions, not macros, for up- and down-casing (Bug#8254).
12977 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12978 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12979 to use the following functions instead of these macros.
12980 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12981 EMACS_INT, since callers assume the returned value fits in int.
12982 (upcase1): Likewise, for UPCASE_TABLE.
12983 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12984 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12985 the race-condition problem in the old DOWNCASE.
88043301 12986
19ed5445
PE
12987 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12988 Rename locals to avoid shadowing.
12989 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12990 (regex_compile, re_search_2, re_match_2_internal):
12991 Remove unused local vars.
952db0d7
PE
12992 (FREE_VAR): Rewrite so as not to use empty "else",
12993 which gcc can warn about.
da053e48 12994 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12995 (RETALLOC_IF): Define only if needed.
12996 (WORDCHAR_P): Likewise. This one is never needed, but is used
12997 only in a comment talking about a compiler bug, so put inside
12998 the #if 0 of that comment.
12999 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13000 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13001 Remove; unused.
19ed5445 13002
1f3561e4 13003 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13004 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13005 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13006
ded6f8f7
PE
13007 * search.c (simple_search): Remove unused var.
13008
dbd37a95
PE
13009 * dired.c (compile_pattern): Move decl from here ...
13010 * lisp.h: ... to here, so that it can be checked.
13011 (struct re_registers): New forward decl.
13012
7e47afad
PE
13013 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13014
85f24f61
PE
13015 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13016 All uses changed.
13017 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13018 Rename locals to avoid shadowing.
5671df8f 13019 (Fvertical_motion): Mark locals as initialized.
85f24f61 13020
181aa2be 13021 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13022 (casify_region): Mark local as initialized.
181aa2be 13023
930d429c
PE
13024 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13025
7082eac6
PE
13026 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13027 New macros, so that the caller can use some names other than
13028 gcpro1, gcpro2, etc.
13029 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13030 of the new macros.
13031 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13032 argument, for consistency with GCPRO2_VAR, etc: it is now the
13033 prefix of the variable, not the variable itself. All uses
13034 changed.
38b2c076
PE
13035 * dired.c (directory_files_internal, file_name_completion):
13036 Rename locals to avoid shadowing.
13037
15206ed9
PE
13038 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13039 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13040 dired.c's scmp function, had undefined behavior.
13041 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13042 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13043 * buffer.h: ... to here, because these macros use current_buffer,
13044 and the new implementation with inline functions needs to have
13045 current_buffer in scope now, rather than later when the macros
13046 are used.
13047 (downcase, upcase1): New static inline functions.
13048 (DOWNCASE, UPCASE1): Reimplement using these functions.
13049 This avoids undefined behavior in expressions like
13050 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13051 from race conditions in accessing the global variables
13052 case_temp1 and case_temp2.
13053 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13054 * lisp.h (case_temp1, case_temp2): Remove their decls.
13055 * character.h (ASCII_CHAR_P): Move from here ...
13056 * lisp.h: ... to here, so that the inline functions mentioned
13057 above can use them.
13058
4a6bea26
PE
13059 * dired.c (directory_files_internal_unwind): Now static.
13060
f14b7e14
PE
13061 * fileio.c (file_name_as_directory, directory_file_name):
13062 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13063 Now static.
2893f146
PE
13064 (file_name_as_directory): Use const pointers when appropriate.
13065 (Fexpand_file_name): Likewise. In particular, newdir might
13066 point at constant storage, so make it a const pointer.
fd4ead52 13067 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13068 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13069 signedness issues.
f839df0c
PE
13070 (Fset_file_times, Finsert_file_contents, auto_save_error):
13071 Rename locals to avoid shadowing.
f14b7e14 13072
5716756e 13073 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13074 (Ftry_completion, Fall_completions): Rename or remove locals
13075 to avoid shadowing.
5716756e 13076
b4c3046a
PE
13077 * marker.c (bytepos_to_charpos): Remove; unused.
13078
b45db522
PE
13079 * lisp.h (verify_bytepos, count_markers): New decls,
13080 so that gcc does not warn that these functions aren't declared.
13081
85876d07
PE
13082 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13083 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13084 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13085 (copy_text): Remove unused local var.
85876d07 13086
03d78a21 13087 * filelock.c (within_one_second): Now static.
b3dd38ab 13088 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13089
5df8f01b
PE
13090 * buffer.c (fix_overlays_before): Mark locals as initialized.
13091 (fix_start_end_in_overlays): Likewise. This function should be
13092 simplified by using pointers-to-pointers, but that's a different
13093 matter.
b1d876f1 13094 (switch_to_buffer_1): Now static.
8f54f30a
PE
13095 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13096 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13097
a70072c9 13098 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13099 Fix pointer signedness issue.
edced198
PE
13100 (sys_subshell): Mark local as volatile if checking for lint,
13101 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13102 (MAXPATHLEN): Define only if needed.
a70072c9 13103
a0977c44
PE
13104 * process.c (serial_open, serial_configure): Move decls from here ...
13105 * systty.h: ... to here, so that they can be checked.
13106
a884fdcc
PE
13107 * fns.c (get_random, seed_random): Move extern decls from here ...
13108 * lisp.h: ... to here, so that they can be checked.
13109
604efe86 13110 * sysdep.c (reset_io): Now static.
b8950c94 13111 (wait_for_termination_signal): Remove; unused.
604efe86 13112
38fc62d9
PE
13113 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13114 (copy_keymap_item, append_key, push_text_char_description):
13115 Now static.
1004a21a 13116 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13117 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13118 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13119 (describe_map_tree):
13120 Rename locals to avoid shadowing.
38fc62d9 13121
2f2650da
PE
13122 * keyboard.c: Declare functions static if they are not used elsewhere.
13123 (echo_char, echo_dash, cmd_error, top_level_2):
13124 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13125 (read_char, kbd_buffer_get_event, make_lispy_position):
13126 (make_lispy_event, make_lispy_movement, apply_modifiers):
13127 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13128 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13129 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13130 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13131 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13132
a053e86c 13133 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13134 (mark_kboards): Move decl here ...
13135 * alloc.c (mark_kboards): ... from here.
a053e86c 13136
4752793e
PE
13137 * lisp.h (force_auto_save_soon): New decl.
13138
74f10ca7 13139 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13140 (DEFINE_DUMMY_FUNCTION): New macro.
13141 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13142 Use it.
c03cd23f
PE
13143 (main): Add casts to avoid warnings
13144 if GCC considers string literals to be constants.
74f10ca7 13145
022e70d4
PE
13146 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13147
59d6fe83
PE
13148 * dbusbind.c: Pointer signedness fixes.
13149 (xd_signature, xd_append_arg, xd_initialize):
13150 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13151 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13152 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13153 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13154
78320123
PE
13155 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13156 if GCC considers string literals to be constants.
49cebcca 13157 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13158
35ac2a97
SM
131592011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13160
fb103ca9
SM
13161 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13162 (print_preprocess, print_object): New macro to fix last change.
13163
35ac2a97
SM
13164 * print.c (print_preprocess): Don't forget font objects.
13165
62973b41
JB
131662011-03-16 Juanma Barranquero <lekktu@gmail.com>
13167
13168 * emacs.c (USAGE3): Doc fixes.
13169
0e48bb22
AS
131702011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13171
13172 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13173 structure.
13174
7684e57b
JB
131752011-03-14 Juanma Barranquero <lekktu@gmail.com>
13176
13177 * lisp.h (VWindow_system, Qfile_name_history):
13178 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13179 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13180 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13181
13182 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13183 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13184
13185 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13186 * w32console.c (detect_input_pending, read_input_pending)
13187 (encode_terminal_code):
13188 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13189 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13190 (w32_system_caret_y, Qfile_name_history):
13191 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13192 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13193 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13194 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13195 * w32proc.c (Qlocal, report_file_error):
13196 * w32term.c (Vwindow_system, updating_frame):
13197 * w32uniscribe.c (initialized, uniscribe_font_driver):
13198 Remove unneeded extern declarations.
13199
2aa46d6c
CY
132002011-03-14 Chong Yidong <cyd@stupidchicken.com>
13201
c96bbc66 13202 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13203
cffc6f3b
CY
132042011-03-13 Chong Yidong <cyd@stupidchicken.com>
13205
13206 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13207 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13208 These macros can no longer be used for assignment.
13209
44f230aa
SM
13210 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13211 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13212 (record_buffer_markers, fetch_buffer_markers): New functions for
13213 recording and fetching special buffer markers.
13214 (set_buffer_internal_1, set_buffer_temp): Use them.
13215
13216 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13217
13218 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13219
13220 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13221 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13222
13223 * xdisp.c (hscroll_window_tree):
13224 (reconsider_clip_changes): Use PT instead of BUF_PT.
13225
d251f04b
EZ
132262011-03-13 Eli Zaretskii <eliz@gnu.org>
13227
13228 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13229 $(EMACS_ROOT)/lib/intprops.h.
13230
f0c77cd1
PE
132312011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13232
3eca4629
PE
13233 Fix more problems found by GCC 4.5.2's static checks.
13234
7c86ee98
PE
13235 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13236 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13237 (xg_free_frame_widgets): Make it clear that a local variable is
13238 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13239 (gdk_window_get_screen): Make it clear that this macro is needed
13240 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13241 (int_gtk_range_get_value): New function, which avoids a diagnostic
13242 from gcc -Wbad-function-cast.
13243 (xg_set_toolkit_scroll_bar_thumb): Use it.
13244 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13245 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13246 (get_utf8_string, xg_get_file_with_chooser):
13247 Rename locals to avoid shadowing.
13248 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13249
41729b81
PE
13250 * xgselect.c (xg_select): Remove unused var.
13251
f0c77cd1
PE
13252 * image.c (four_corners_best): Mark locals as initialized.
13253 (gif_load): Initialize transparent_p to zero (Bug#8238).
13254 Mark another local as initialized.
ec6cf4c6 13255 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13256
ce0ad53d 13257 * image.c (clear_image_cache): Now static.
d5d5a617 13258 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13259 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13260 (x_edge_detection): Remove unnecessary cast that
13261 gcc -Wbad-function-cast diagnoses.
2037898d 13262 (gif_load): Fix pointer signedness.
6ae141d6
PE
13263 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13264 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13265
33383987 132662011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13267
d32df629
PE
13268 Improve quality of tests for time stamp overflow.
13269 For example, without this patch (encode-time 0 0 0 1 1
13270 1152921504606846976) returns the obviously-bogus value (-948597
13271 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13272 reports time overflow. See
13273 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13274 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13275 * editfns.c: Include limits.h and intprops.h.
13276 (TIME_T_MIN, TIME_T_MAX): New macros.
13277 (time_overflow): Move earlier, to before first use.
13278 (hi_time, lo_time): New functions, for an accurate test for
13279 out-of-range times.
13280 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13281 (Fget_internal_run_time): Don't assume time_t fits in int.
13282 (make_time): Use list2 instead of Fcons twice.
13283 (Fdecode_time): More accurate test for out-of-range times.
13284 (check_tm_member): New function.
13285 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13286 (lisp_time_argument): Don't rely on undefined left-shift and
13287 right-shift behavior when checking for time stamp overflow.
8be6f318 13288
fe31d94c
PE
13289 * editfns.c (time_overflow): New function, refactoring common code.
13290 (Fformat_time_string, Fdecode_time, Fencode_time):
13291 (Fcurrent_time_string): Use it.
13292
8be6f318
PE
13293 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13294 * dired.c (make_time): Move to ...
13295 * editfns.c (make_time): ... here.
13296 * systime.h: Note the move.
13297
09d9db2c 132982011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13299
126bc0dc
YM
13300 * fringe.c (update_window_fringes): Remove unused variables.
13301
c47cbdfd
YM
13302 * unexmacosx.c (copy_data_segment): Also copy __got section.
13303 (Bug#8223)
13304
7ac80be9
EZ
133052011-03-12 Eli Zaretskii <eliz@gnu.org>
13306
c96bbc66 13307 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13308 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13309 Constify `char *' arguments and their references according to
13310 prototypes in tparam.h.
13311
ecb0f94d 13312 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13313
7ac80be9
EZ
13314 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13315 Adapt all references accordingly.
13316
13317 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13318
ef1fd07e
TT
133192011-03-11 Tom Tromey <tromey@redhat.com>
13320
13321 * buffer.c (syms_of_buffer): Remove obsolete comment.
13322
7ef4b50c
EZ
133232011-03-11 Eli Zaretskii <eliz@gnu.org>
13324
13325 * termhooks.h (encode_terminal_code): Declare prototype.
13326
13327 * msdos.c (encode_terminal_code): Don't declare prototype.
13328
13329 * term.c (encode_terminal_code): Now external again, used by
13330 w32console.c and msdos.c.
13331
44f230aa
SM
13332 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13333 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13334
4b1ec863 133352011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13336
1714f52b 13337 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13338
4b1ec863
PE
13339 * fringe.c (update_window_fringes): Mark locals as initialized
13340 (Bug#8227).
13341 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13342
524c7aa6
PE
13343 * alloc.c (mark_fringe_data): Move decl from here ...
13344 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13345 to check its interface.
13346 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13347
a5c0af81 13348 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13349 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13350 (fontset_font): Mark local as initialized.
a9a06e0b 13351 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13352
b4716021
PE
13353 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13354
811e9bac 13355 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13356 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13357 (x_own_selection, Fx_disown_selection_internal): Rename locals
13358 to avoid shadowing.
13359 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13360
7e3ab302
PE
13361 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13362 so that the caller can use some name other than gcpro1.
13363 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13364 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13365 (Fx_backspace_delete_keys_p):
13366 Use them to avoid shadowing, and rename vars to avoid shadowing.
13367 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13368 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13369 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13370 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13371 Remove unused locals.
7e3ab302
PE
13372 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13373 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13374 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13375 macros.
f78faa98 13376
e2b13473
PE
13377 * xterm.h (x_mouse_leave): New decl.
13378
77f23912
PE
13379 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13380 Remove unused functions.
cdf4ba58
PE
13381 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13382 (x_calc_absolute_position): Now static.
7411c686 13383 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13384 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13385 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13386 unless they are used.
38d0b34a
PE
13387 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13388 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13389 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13390 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13391 (x_error_catcher, x_connection_closed, x_error_handler):
13392 (x_error_quitter, xembed_send_message, x_iconify_frame):
13393 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13394 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13395 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13396
44f230aa
SM
13397 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13398 Rename or move locals to avoid shadowing.
6b463e58 13399 (tty_defined_color, merge_face_heights): Now static.
5967d051 13400 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13401 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13402 does not deduce is never used uninitialized.
73719eba
PE
13403 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13404 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13405
426994c3 13406 * terminal.c (store_terminal_param): Now static.
5489860b 13407
032f1620 13408 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13409 (set_frame_menubar): Remove unused local.
d4323972 13410 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13411 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13412 since they might point to immutable storage.
281585b0
PE
13413 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13414 since it's unused otherwise.
032f1620 13415
367c19e5 13416 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13417 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13418 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13419 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13420 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13421 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13422 does not deduce are never used uninitialized.
70739cbe 13423
07b48fa9
PE
13424 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13425
8868a238 13426 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13427 * window.c (window_loop, size_window):
13428 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13429
7e5cf297 13430 * window.c (display_buffer): Now static.
d6550a9f
PE
13431 (size_window): Mark variables that gcc -Wuninitialized
13432 does not deduce are never used uninitialized.
a586633d
PE
13433 * window.h (check_all_windows): New decl, to forestall
13434 gcc -Wmissing-prototypes diagnostic.
5b555da1 13435 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13436
f6095868
PE
13437 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13438 shadowing.
13439 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13440 Include <limits.h>.
13441 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13442 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13443 (load_charset_map): Mark variables that gcc -Wuninitialized
13444 does not deduce are never used uninitialized.
53df7c11 13445 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13446
f38b440c
PE
13447 * coding.c (coding_set_source, coding_set_destination):
13448 Use "else { /* comment */ }" rather than "else /* comment */;"
13449 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13450 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13451 a block, when the outer 'i' will do.
13452 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13453 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13454 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13455 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13456 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13457 Rename locals to avoid shadowing.
13458 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13459 * coding.c (emacs_mule_char, encode_invocation_designation):
13460 Now static, since they're not used elsewhere.
413bb2db 13461 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13462 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13463 (decode_coding_emacs_mule): Mark variables that gcc
13464 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13465 (detect_coding_iso_2022): Initialize a local variable that might
13466 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13467 this initialization is needed. (Bug#8211)
5f58e762
PE
13468 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13469 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13470 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13471 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13472 Remove unused macros.
f38b440c 13473
232b38b9 13474 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13475 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13476 * character.c (string_count_byte8): Likewise.
232b38b9 13477
fb90da1b
PE
13478 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13479 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13480
fb93dbc2
PE
13481 * chartab.c (copy_sub_char_table): Now static, since it's not used
13482 elsewhere.
5c156ace
PE
13483 (sub_char_table_ref_and_range, char_table_ref_and_range):
13484 Rename locals to avoid shadowing.
bbcd0949 13485 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13486
7d3b3862 13487 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13488 (BIDI_BOB): Remove unused macro.
7d3b3862 13489
6be7d3da
PE
13490 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13491 deduce are never used uninitialized.
c2ed9c8b 13492 * term.c (encode_terminal_code): Likewise.
6be7d3da 13493
75f8807f 13494 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13495
50938595
PE
13496 * tparam.h: New file.
13497 * term.c, tparam.h: Include it.
13498 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13499 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13500 Move these decls to tparam.h, and make them agree with what
13501 is actually in tparam.c. The previous trick of using incompatible
13502 decls in different modules does not conform to the C standard.
13503 All callers of tparam changed to use tparam's actual API.
13504 * tparam.c (tparam1, tparam, tgoto):
13505 Use const pointers where appropriate.
13506
fbceeba2
PE
13507 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13508 * cm.h (struct cm): Likewise.
13509 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13510 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13511 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13512 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13513 (turn_on_face, init_tty): Likewise.
13514 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13515
7f3f1250
PE
13516 * term.c (term_mouse_position): Rename local to avoid shadowing.
13517
e6ca6543
PE
13518 * alloc.c (mark_ttys): Move decl from here ...
13519 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13520
c40f8d15
AS
135212011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13522
13523 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13524
cfe0661d
JB
135252011-03-09 Juanma Barranquero <lekktu@gmail.com>
13526
13527 * search.c (compile_pattern_1): Remove argument regp, unused since
13528 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13529 (compile_pattern): Don't pass it.
13530
0afb4571
J
135312011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13532
13533 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13534 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13535 for ! HAVE_GTK3.
13536 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13537
13538 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13539
13540 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13541 gdk_window_get_screen, gdk_window_get_geometry,
13542 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13543 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13544 (xg_get_pixbuf_from_pixmap): New function.
13545 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13546 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13547 Call xg_get_pixbuf_from_pixmap instead of
13548 gdk_pixbuf_get_from_drawable.
13549 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13550 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13551 (xg_check_special_colors): Use GtkStyleContext and its functions
13552 for HAVE_GTK3.
13553 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13554 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13555 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13556 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13557 Call gtk_widget_get_preferred_size.
0afb4571
J
13558 (xg_frame_resized): gdk_window_get_geometry only takes 5
13559 parameters.
44f230aa
SM
13560 (xg_win_to_widget, xg_event_is_for_menubar):
13561 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13562 (xg_set_widget_bg): New function.
13563 (delete_cb): New function.
895009e1 13564 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13565 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13566 (xg_set_background_color): Call xg_set_widget_bg.
13567 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13568 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13569 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13570 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13571 if ! HAVE_GTK3.
13572 (update_frame_tool_bar): Call gtk_widget_hide.
13573 (xg_initialize): Use GDK_KEY_g.
13574
13575 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13576 if ! HAVE_GTK3
13577 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13578
13579 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13580 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13581 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13582
1c2cc4ef
JB
135832011-03-08 Juanma Barranquero <lekktu@gmail.com>
13584
13585 * w32xfns.c (select_palette): Check success of RealizePalette against
13586 GDI_ERROR, not zero.
13587
33383987 13588See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13589
13590;; Local Variables:
13591;; coding: utf-8
aac0c6e3
MR
13592;; End:
13593
2f097256 13594 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13595
13596 This file is part of GNU Emacs.
13597
13598 GNU Emacs is free software: you can redistribute it and/or modify
13599 it under the terms of the GNU General Public License as published by
13600 the Free Software Foundation, either version 3 of the License, or
13601 (at your option) any later version.
13602
13603 GNU Emacs is distributed in the hope that it will be useful,
13604 but WITHOUT ANY WARRANTY; without even the implied warranty of
13605 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13606 GNU General Public License for more details.
13607
13608 You should have received a copy of the GNU General Public License
13609 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.