Ensure correct ordering of process writes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
20ca2e94
TN
12012-06-17 Troels Nielsen <bn.troels@gmail.com>
2
3 * process.c (make_process): Initialize write_queue.
4 (write_queue_push, write_queue_pop): New functions.
5 (send_process): Use them to maintain correct ordering of process
6 writes (Bug#10815).
7
9a900ca9
PE
82012-06-17 Paul Eggert <eggert@cs.ucla.edu>
9
310fbfa8
PE
10 * lisp.h (eassert): Assume C89 or later.
11 This removes the need for CHECK.
12 (CHECK): Remove. Its comments about always evaluating its
13 argument were confusing, as 'eassert' typically does not evaluate
14 its argument.
15
27bb1ca4
PE
16 * coding.c (produce_chars): Use ptrdiff_t, not int.
17
9a900ca9
PE
18 * xterm.c (x_draw_underwave): Check for integer overflow.
19 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
20
41b7f8bc 212012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
22
23 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
24 referenced (Bug#11583).
25
9b0e3eba
AA
262012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
27
28 Implement wave-style variant of underlining.
29 * dispextern.h (face_underline_type): New enum.
30 (face): Add field for underline type.
31 * nsterm.m (ns_draw_underwave): New function.
32 (ns_draw_text_decoration): Use it.
33 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
34 New functions.
35 (x_draw_glyph_string): Use them.
36 * xfaces.c (Qline, Qwave): New Lisp objects.
37 (check_lface_attrs, merge_face_ref)
38 (Finternal_set_lisp_face_attribute, realize_x_face): Handle
39 wave-style underline face attributes.
40 * xterm.c (x_draw_underwave): New function.
41 (x_draw_glyph_string): Use it.
42
0fb52f11
JB
432012-06-16 Juanma Barranquero <lekktu@gmail.com>
44
45 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
46 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
47 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
48 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
49 ($(BLD)/w32select.$(O)): Update dependencies.
50
e5560ff7
AS
512012-06-16 Andreas Schwab <schwab@linux-m68k.org>
52
53 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
54 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
55 * character.c (_fetch_multibyte_char_p): Remove.
56 * alloc.c: Include "character.h" before "buffer.h".
57 * bidi.c: Likewise.
58 * buffer.c: Likewise.
59 * bytecode.c: Likewise.
60 * callint.c: Likewise.
61 * callproc.c: Likewise.
62 * casefiddle.c: Likewise.
63 * casetab.c: Likewise.
64 * category.c: Likewise.
65 * cmds.c: Likewise.
66 * coding.c: Likewise.
67 * composite.c: Likewise.
68 * dired.c: Likewise.
69 * dispnew.c: Likewise.
70 * doc.c: Likewise.
71 * dosfns.c: Likewise.
72 * editfns.c: Likewise.
73 * emacs.c: Likewise.
74 * fileio.c: Likewise.
75 * filelock.c: Likewise.
76 * font.c: Likewise.
77 * fontset.c: Likewise.
78 * fringe.c: Likewise.
79 * indent.c: Likewise.
80 * insdel.c: Likewise.
81 * intervals.c: Likewise.
82 * keyboard.c: Likewise.
83 * keymap.c: Likewise.
84 * lread.c: Likewise.
85 * macros.c: Likewise.
86 * marker.c: Likewise.
87 * minibuf.c: Likewise.
88 * nsfns.m: Likewise.
89 * nsmenu.m: Likewise.
90 * print.c: Likewise.
91 * process.c: Likewise.
92 * regex.c: Likewise.
93 * region-cache.c: Likewise.
94 * search.c: Likewise.
95 * syntax.c: Likewise.
96 * term.c: Likewise.
97 * textprop.c: Likewise.
98 * undo.c: Likewise.
99 * unexsol.c: Likewise.
100 * w16select.c: Likewise.
101 * w32fns.c: Likewise.
102 * w32menu.c: Likewise.
103 * window.c: Likewise.
104 * xdisp.c: Likewise.
105 * xfns.c: Likewise.
106 * xmenu.c: Likewise.
107 * xml.c: Likewise.
108 * xselect.c: Likewise.
109
2f07e6af
EZ
1102012-06-16 Eli Zaretskii <eliz@gnu.org>
111
112 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
113 all the glyphs of the glyph row came from strings, and we have no
114 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
115 row.
116 (handle_face_prop): Use chunk-relative overlay string index when
117 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
118 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
119 the rightmost. (Bug#11720)
2f07e6af 120
29b83cec
AS
1212012-06-16 Andreas Schwab <schwab@linux-m68k.org>
122
123 * category.h (CHAR_HAS_CATEGORY): Define as inline.
124 (CATEGORY_MEMBER): Enforce 1/0 value.
125 * category.c (_temp_category_set): Remove.
126
4c5501e9
EZ
1272012-06-16 Eli Zaretskii <eliz@gnu.org>
128
129 * window.c (Fdelete_other_windows_internal)
130 (Fdelete_window_internal): Don't access frame's mouse highlight
131 info of the initial frame. (Bug#11677)
132
2b570124
PE
1332012-06-14 Paul Eggert <eggert@cs.ucla.edu>
134
e93864f9
PE
135 * .gdbinit (xgetint): Fix recently-introduced paren typo.
136 Assume USE_2_TAGS_FOR_INTS.
137 (xreload): Adjust $tagmask width to match recent lisp.h change.
138
2b570124
PE
139 Simplify lisp.h in minor ways that should not affect code.
140 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
141 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
142 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
143 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
144 (INTTYPEBITS): New macro, for clarity.
145 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
146 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
147 now that USE_LSB_TAG is always defined.
148 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
149 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
150
81755f69
JB
1512012-06-13 Juanma Barranquero <lekktu@gmail.com>
152
153 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
154
16192a57
GM
1552012-06-13 Glenn Morris <rgm@gnu.org>
156
157 * s/bsd-common.h (BSD4_3):
158 * s/usg5-4-common.h (USG5_4): No longer define; unused.
159
646b5f55
AS
1602012-06-13 Andreas Schwab <schwab@linux-m68k.org>
161
162 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
163 instead of union.
164 (XLI, XIL): Define.
165 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
166 them.
167 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
168 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
169 * alloc.c (widen_to_Lisp_Object): Removed.
170 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
171 * frame.c (delete_frame): Remove outdated comment.
172 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
173 USE_LISP_UNION_TYPE.
174 (Fw32_unregister_hot_key): Likewise.
175 (Fw32_toggle_lock_key): Likewise.
176 * w32menu.c (add_menu_item): Likewise.
177 (w32_menu_display_help): Use XIL instead of checking
178 USE_LISP_UNION_TYPE.
179 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
180 (init_heap): Likewise.
181 * w32term.c (w32_read_socket): Update comment.
182
1d3823c9
GM
1832012-06-13 Glenn Morris <rgm@gnu.org>
184
c62ff706
GM
185 * s/usg5-4-common.h, src/s/unixware.h:
186 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
187
1d3823c9
GM
188 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
189
bfe3e0a2
PE
1902012-06-13 Paul Eggert <eggert@cs.ucla.edu>
191
192 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
193 * alloc.c (make_number) [!defined make_number]:
194 Remove, as lisp.h always defines this now.
195 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
196 (roundup_size): Verify that it is a power of 2.
197 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
198 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
199 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
200 -DUSE_LSB_TAG=0, to override the automatically-selected default.
201 USE_LSB_TAG now is always defined to be either 0 or 1.
202 All uses changed.
203 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
204 code works fine either way, and efficiency is not a concern here,
205 as the union type is for debugging, not for production.
206 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
207 Use an inline function on all platforms when using the union type,
208 since this is simpler and 'static inline' can be used portably
209 within Emacs now.
210 (LISP_INITIALLY_ZERO): New macro.
211 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
212 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
213
45fa9c0f
GM
2142012-06-12 Glenn Morris <rgm@gnu.org>
215
b4492cba
GM
216 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
217
218 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 219
45fa9c0f
GM
220 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
221 Move BROKEN_SIGIO to configure.
222
223 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
224 Move NO_TERMIO to configure.
225
0e25d334
CY
2262012-06-12 Chong Yidong <cyd@gnu.org>
227
228 * image.c (imagemagick_load_image): Use MagickFlattenImage if
229 MagickMergeImageLayers is undefined. Use pixel pusher loop if
230 MagickExportImagePixels is undefined.
231
43682bb6
PE
2322012-06-12 Paul Eggert <eggert@cs.ucla.edu>
233
234 * image.c (imagemagick_load_image): Remove unused label.
235
a9be7d2b
GM
2362012-06-11 Glenn Morris <rgm@gnu.org>
237
238 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
239 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
240 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
241 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
242
3017f87f
SM
2432012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
244
245 * alloc.c (make_byte_code): New function.
246 (Fmake_byte_code): Use it. Don't purify here.
247 * lread.c (read1): Use it as well to avoid extra allocation.
248
1b9b4cf4
CY
2492012-06-11 Chong Yidong <cyd@gnu.org>
250
251 * image.c (imagemagick_load_image): Implement transparency.
252
95988fcf
AS
2532012-06-10 Andreas Schwab <schwab@linux-m68k.org>
254
255 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
256 account for preceding backslashes. (Bug#11663)
257
cd4eb164
CY
2582012-06-09 Chong Yidong <cyd@gnu.org>
259
260 * term.c: Support italics in capable terminals (Bug#9652).
261 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
262 (turn_on_face): Output using TS_enter_italic_mode if available.
263 Don't handle unused blinking and alt-charset cases.
264 (turn_off_face): Handle italic case; discard unused tty_blinking_p
265 and tty_alt_charset_p cases.
266 (tty_capable_p, init_tty): Support italics.
267
268 * termchar.h (struct tty_display_info): Add field for italics.
269 Remove unused blink field.
270
271 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
272 Handle slant.
273
274 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
275 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
276 tty_alt_charset_p. Add tty_italic_p.
277
ff88beb8
MA
2782012-06-09 Michael Albinus <michael.albinus@gmx.de>
279
280 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
281 dbus_type_is_basic if available.
282 (xd_extract_signed, xd_extract_unsigned): Rename from
283 extract_signed and extract_unsigned, respectively. Adapt callers.
284
44286096
CY
2852012-06-09 Chong Yidong <cyd@gnu.org>
286
1682701f
CY
287 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
288
44286096
CY
289 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
290 case (Bug#9752).
291
d86feb17
PE
2922012-06-08 Paul Eggert <eggert@cs.ucla.edu>
293
294 * xdisp.c (vmessage): Treat frame message as multibyte.
295 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
296 would generate the diagnostic "Making \302\247 buffer-local while
297 let-bound!".
298
d5c20fe8
EZ
2992012-06-08 Eli Zaretskii <eliz@gnu.org>
300
301 * dispnew.c (showing_window_margins_p): Undo last change, which
302 was done due to an inadvertent commit.
303 (adjust_frame_glyphs_for_frame_redisplay): Do call
304 showing_window_margins_p.
305
513749ee
SM
3062012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
307
308 * eval.c (Fmake_var_non_special): New primitive.
309 (syms_of_eval): Defsubr it.
310 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
311
d4a8f5c1
JB
3122012-06-08 Juanma Barranquero <lekktu@gmail.com>
313
314 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
315 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
316
8bbbc977
EZ
3172012-06-08 Eli Zaretskii <eliz@gnu.org>
318
319 * alloc.c (allocate_vectorlike): Fix last change.
320
f3372c87
DA
3212012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
322
323 Block-based vector allocation of small vectors.
324 * lisp.h (struct vectorlike_header): New field `nbytes',
325 adjust comment accordingly.
326 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
327 to denote vector blocks. Adjust users (live_vector_p,
328 mark_maybe_pointer, valid_lisp_object_p) accordingly.
329 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
330 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
331 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
332 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
333 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
334 (roundup_size): New constant.
335 (struct vector_block): New data type.
336 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 337 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
338 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
339 (sweep_vectors): New functions.
340 (allocate_vectorlike): Return `zero_vector' as the only vector of
341 0 items. Allocate new vector from block if vector size is less than
342 or equal to VBLOCK_BYTES_MAX.
343 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
344 (init_alloc_once): Add call to init_vectors.
345
4f18a4ed
SM
3462012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
347
348 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
349
86f158bc
PE
3502012-06-07 Paul Eggert <eggert@cs.ucla.edu>
351
352 * doprnt.c (doprnt): Truncate multibyte char correctly.
353 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
354 would mishandle a string argument "Xc" if X was a multibyte
355 character of length 2: it would truncate after X's first byte
356 rather than including all of X.
357
c5cfcbe0
CY
3582012-06-06 Chong Yidong <cyd@gnu.org>
359
360 * buffer.c (word_wrap): Doc fix.
361
c05cf390
PE
3622012-06-04 Paul Eggert <eggert@cs.ucla.edu>
363
364 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
365
0c3461de
GM
3662012-06-03 Glenn Morris <rgm@gnu.org>
367
368 * xdisp.c (tool-bar-style): Doc fix.
369
c71232db
UM
3702012-06-03 Ulrich Müller <ulm@gentoo.org>
371
372 * Makefile.in (PAXCTL): Define.
373 (temacs$(EXEEXT)): Disable memory randomization for the temacs
374 binary via PaX flags if the paxctl utility is available.
375 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
376 Restore PaX flags to their default. (Bug#11398)
377
383f7350
CY
3782012-06-03 Chong Yidong <cyd@gnu.org>
379
380 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
381 buffer (Bug#11226).
382
5f2c76c6
CY
3832012-06-03 Chong Yidong <cyd@gnu.org>
384
385 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
386 (note_mode_line_or_margin_highlight): If there is no help echo,
387 use mode-line-default-help-echo. Handle the case where the mouse
388 position is past the end of the mode line string.
389
390 * buffer.c (buffer_local_value_1): New function, split from
391 Fbuffer_local_value; can return Qunbound.
392 (Fbuffer_local_value): Use it.
393 (Vmode_line_format): Docstring tweaks.
394
773d47f6
PE
3952012-06-02 Paul Eggert <eggert@cs.ucla.edu>
396
397 * sysdep.c (system_process_attributes): Improve comment.
398
f2d6a3df
SM
3992012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
400
401 * keyboard.c: Export real-this-command to Elisp.
402 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
403 and DEFVAR it. Update all users.
404
63810350
PE
4052012-06-02 Paul Eggert <eggert@cs.ucla.edu>
406
7bd5c1f4
PE
407 * minibuf.c (Fassoc_string): Remove duplicate declaration.
408
63810350
PE
409 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
410 Convert pctcpu and pctmem to Lisp float properly.
411 Let the compiler fold better, as 100.0/0x8000 is exact.
412
a2821611
AS
4132012-06-02 Andreas Schwab <schwab@linux-m68k.org>
414
415 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
416 cons_block.
417
5fceba1d
PE
4182012-06-01 Paul Eggert <eggert@cs.ucla.edu>
419
420 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
421
c98ff5dd
DA
4222012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
423
424 For a 'struct window', replace some Lisp_Object fields to
425 bitfields where appropriate, remove unused fields.
426 * window.h (struct window): Remove unused 'last_mark_x' and
427 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
428 change it's type from Lisp_Object to bitfield.
429 Change type of 'force_start', 'optional_new_start',
430 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
431 fields from Lisp_Object to bitfield. Adjust users accordingly.
432
ca34e0be
PE
4332012-05-31 Paul Eggert <eggert@cs.ucla.edu>
434
435 Pacify gcc -Wdouble-precision when using Xaw.
436 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
437 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
438 Use 'float' consistently, rather than 'float' in most places
439 and 'double' in a couple of places.
440
efc00ab1 4412012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
442
443 * xdisp.c (handle_stop): Detect whether we have overlay strings
444 loaded by testing it->current.overlay_string_index to be
445 non-negative, instead of checking whether n_overlay_strings is
446 positive. (Bug#11587)
447
efc00ab1 4482012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
449
450 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
451
452 * doc.c (Fsubstitute_command_keys): Doc fix.
453
efc00ab1 4542012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
455
456 * search.c (search_buffer): Remove calls to
457 r_alloc_inhibit_buffer_relocation, as it is now called by
458 maybe_unify_char, which was the cause of relocation of buffer text
459 in bug#11519.
460
efc00ab1 4612012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
462
463 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
464 for the duration of call to load_charset, to avoid problems with
465 callers of maybe_unify_char that access buffer text through C
466 pointers.
467
468 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
469 decrement the inhibition flag, instead of just setting or
470 resetting it.
471
ba93a187
PE
4722012-05-31 Paul Eggert <eggert@cs.ucla.edu>
473
474 Remove obsolete '#define static' cruft.
475 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
476 This #undef was "temporary" in 2000; it is no longer needed
477 now that '#define static' has gone away.
478 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
479 (gray_bitmap_bits): Remove; no longer needed.
480 All uses replaced with definiens.
481 * xterm.c: Include "bitmaps/gray.xbm".
482
9e4bf381
PE
4832012-05-30 Paul Eggert <eggert@cs.ucla.edu>
484
485 Clean up __executable_start, monstartup when --enable-profiling.
486 The following changes affect the code only when profiling.
487 * dispnew.c (__executable_start): Rename from safe_bcopy.
488 Define only on platforms that need it.
489 * emacs.c: Include <sys/gmon.h> when profiling.
490 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
491 (__executable_start): Remove decl, since lisp.h does it now.
492 (safe_bcopy): Remove decl; no longer has that name.
493 (main): Coalesce #if into single bit of code, for simplicity.
494 Cast pointers to uintptr_t, since standard libraries want integers
495 and not pointers.
496 * lisp.h (__executable_start): New decl.
497
32d72c2f
GM
4982012-05-31 Glenn Morris <rgm@gnu.org>
499
500 * image.c (Fimagemagick_types): Doc fix.
501
baac5bc7
JM
5022012-05-30 Jim Meyering <meyering@redhat.com>
503
504 * callproc.c (Fcall_process_region): Include directory component
505 in mkstemp error message (Bug#11586).
506
72cb32cf
PE
5072012-05-30 Paul Eggert <eggert@cs.ucla.edu>
508
509 * alloc.c, lisp.h (make_pure_vector): Now static.
510
61b108cc
SM
5112012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
512
513 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
514 Move to byte-run.el.
515 (Fautoload): Do the hash-doc more carefully.
516 * data.c (Fdefalias): Purify definition, except for keymaps.
517 (Qdefun): Move from eval.c.
518 * lisp.h (Qdefun): Remove.
519 * lread.c (read1): Tiny simplification.
520
471fe23d
TN
5212012-05-29 Troels Nielsen <bn.troels@gmail.com>
522
934f3f58 523 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
524 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
525 Bug#9642, but explicitly check that the buffer the overlay would
526 be moved to is live and rearrange lines to make sure that errors
527 will not put the overlay in an inconsistent state.
528 (Fdelete_overlay): Cosmetics.
529
85d0efd1
EZ
5302012-05-28 Eli Zaretskii <eliz@gnu.org>
531
532 * w32term.c (my_bring_window_to_top): New function.
533 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
534 could be different from the original one.
535 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
536 (Bug#11513)
537
538 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
539 by calling BringWindowToTop.
540
541 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
542 (WM_EMACS_END): Increase by one.
543
da92a98c
PE
5442012-05-28 Paul Eggert <eggert@cs.ucla.edu>
545
546 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
547 This avoids undefined behavior that might cause the eassert
548 to not catch an out-of-range value.
549
74d1f848
JB
5502012-05-28 Juanma Barranquero <lekktu@gmail.com>
551
552 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
553 Update dependencies.
554
9e1a06fc
EZ
5552012-05-27 Eli Zaretskii <eliz@gnu.org>
556
557 * bidi.c (bidi_mirror_char): Fix last change.
558
f3dd7312
AS
5592012-05-27 Andreas Schwab <schwab@linux-m68k.org>
560
561 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
562 when referring to sectname field in printf format.
563
81899c91
PE
5642012-05-27 Paul Eggert <eggert@cs.ucla.edu>
565
57b81a9f
PE
566 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
567 Only r_alloc_inhibit_buffer_relocation needed to be added;
568 the others were already declared.
569
81899c91
PE
570 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
571 before checking whether it's out of range. Put the check inside
572 eassert. See
573 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
574
33017faf 5752012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
576
577 * callproc.c (Fcall_process): Restore a line that was accidentally
578 commented out in the 2011-02-13 change (bug#11547).
579
33017faf 5802012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
581
582 * lisp.h [REL_ALLOC]: Add prototypes for external functions
583 defined on ralloc.c.
584
585 * buffer.c [REL_ALLOC]: Remove prototypes of
586 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
587 they are now on lisp.h.
588
589 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
590
591 * search.c (search_buffer): Use it to inhibit relocation of buffer
592 text while re_search_2 is doing its job, because re_search_2 is
593 passed C pointers to buffer text. (Bug#11519)
594
23415acf
EZ
595 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
596 Update value to 24.
597
44e27368
EZ
598 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
599 state after an additional call to move_it_in_display_line_to, keep
600 the values of it->max_ascent and it->max_descent found for the
601 entire line.
602 (pos_visible_p): Revert the comparison against bottom_y to what it
603 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
604 (Bug#11464)
605
c1892f11
PE
6062012-05-26 Paul Eggert <eggert@cs.ucla.edu>
607
608 Fix coding-related core dumps with gcc -ftrapv.
609 The code was computing A - B, where A and B are pointers, and B is
610 random garbage. This can lead to core dumps on platforms that
611 have special pointer registers, and it also leads to core dumps on
612 x86-64 when compiled with gcc -ftrapv. The fix is to compute
613 A - B only when B is initialized properly.
614 * coding.c (coding_set_source, coding_set_destination): Return void.
615 (coding_change_source, coding_change_destinations): New functions,
616 with the old behaviors of coding_set_source and coding_set_destination.
617 All callers that need an offset changed to use these new functions.
618
eb7afdad
GM
6192012-05-26 Glenn Morris <rgm@gnu.org>
620
621 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
622
f12fdf02
EZ
6232012-05-26 Eli Zaretskii <eliz@gnu.org>
624
53a63be6 625 Extend mouse support on W32 text-mode console.
61b108cc
SM
626 * xdisp.c (draw_row_with_mouse_face):
627 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 628
eb3f6f01 629 * w32console.c: Include window.h.
61b108cc
SM
630 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
631 New functions.
eb3f6f01
EZ
632 (initialize_w32_display): Initialize mouse-highlight data.
633
53a63be6
EZ
634 * w32inevt.c: Include termchar.h and window.h.
635 (do_mouse_event): Support mouse-autoselect-window. When the mouse
636 moves, call note_mouse_highlight. If help_echo changed, call
637 gen_help_event to produce help-echo message in the echo area.
638 Call clear_mouse_face if mouse_face_hidden is set in the mouse
639 highlight info.
640
4cfd81f6
PE
6412012-05-26 Paul Eggert <eggert@cs.ucla.edu>
642
643 * lread.c (read1): Simplify slightly to avoid an overflow warning
644 with GCC 4.7.0 on x86-64.
645
4446092a
EZ
6462012-05-26 Eli Zaretskii <eliz@gnu.org>
647
648 * bidi.c (bidi_mirror_char): Revert last change: an int is
649 definitely wide enough here.
650
42b2a986 6512012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 652
42b2a986 653 Fix integer width and related bugs (Bug#9874).
eb106a49 654 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
655 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
656 (string_bytes, check_sblock, allocate_string_data):
657 (compact_small_strings, Fmake_bool_vector, make_string)
658 (make_unibyte_string, make_multibyte_string)
659 (make_string_from_bytes, make_specified_string)
660 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
661 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
662 (mark_vectorlike):
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 (allocate_pseudovector):
665 Use int, not EMACS_INT, where int is wide enough.
666 (inhibit_garbage_collection, Fgarbage_collect):
667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
668 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
669 int might not be wide enough.
670 (bidi_cache_search, bidi_cache_find, bidi_init_it)
671 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
672 (bidi_at_paragraph_end, bidi_find_paragraph_start)
673 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
674 (bidi_level_of_next_char, bidi_move_to_visually_next):
675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
676 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
677 (Fkill_buffer, Fset_buffer_major_mode)
678 (advance_to_char_boundary, Fbuffer_swap_text)
679 (Fset_buffer_multibyte, overlays_at, overlays_in)
680 (overlay_touches_p, struct sortvec, record_overlay_string)
681 (overlay_strings, recenter_overlay_lists)
682 (adjust_overlays_for_insert, adjust_overlays_for_delete)
683 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
684 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
685 (Foverlay_recenter, last_overlay_modification_hooks_used)
686 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
688 (validate_region): Omit unnecessary test for b <= e,
689 since that's guaranteed by the previous test.
d311d28c
PE
690 (adjust_overlays_for_delete): Avoid pos + length overflow.
691 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
692 (report_overlay_modification):
693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
694 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
695 Omit pointer cast, which isn't needed anyway, and doesn't work
696 after the EMACS_INT -> ptrdiff_t change.
02481186 697 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
698 * buffer.h: Adjust decls to match defn changes elsewhere.
699 (struct buffer_text, struct buffer):
700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
701 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
702 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
703 not int, to avoid needless 32-bit limit on 64-bit hosts.
704 (exec_byte_code): Use tighter memory-full test, one that checks
705 for alloca overflow. Don't compute the address of the object just
706 before an array, as that's not portable. Use EMACS_INT, not
707 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
708 * callint.c (Fcall_interactively):
709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
710 * callproc.c (call_process_kill, Fcall_process):
711 Don't assume pid_t fits into an Emacs fixnum.
712 (call_process_cleanup, Fcall_process, child_setup):
713 Don't assume pid_t fits into int.
714 (call_process_cleanup, Fcall_process, delete_temp_file)
715 (Fcall_process_region):
716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
717 (Fcall_process): Simplify handling of volatile integers.
718 Use int, not EMACS_INT, where int will do.
719 * casefiddle.c (casify_object, casify_region, operate_on_word)
720 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
722 (casify_object): Avoid integer overflow when overallocating buffer.
723 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 724 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
725 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
726 * category.h (CATEGORYP): Don't assume arg is nonnegative.
727 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
728 integers are now checked earlier. All uses replaced with XINT.
729 (ccl_driver):
730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
731 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
732 (ccl_driver, Fregister_code_conversion_map):
733 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
734 (resolve_symbol_ccl_program): Check that vector header is in range.
735 Always copy the vector, so that we can check its contents reliably
736 now rather than having to recheck each instruction as it's being
737 executed. Check that vector words fit in 'int'.
738 (ccl_get_compiled_code, Fregister_ccl_program)
739 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
740 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
741 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
742 contents are in range.
743 (Fccl_execute_on_string): Check that status is in range.
744 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
745 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
746 Accept and return EMACS_INT, not int, because callers can pass values
747 out of 'int' range.
748 (c_string_width, strwidth, lisp_string_width, chars_in_text)
749 (multibyte_chars_in_text, parse_str_as_multibyte)
750 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
751 (str_as_unibyte, str_to_unibyte, string_count_byte8)
752 (string_escape_byte8, Fget_byte):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 754 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
755 avoid mishandling large integers.
756 * character.h: Adjust decls to match defn changes elsewhere.
757 * charset.c (load_charset_map_from_file, find_charsets_in_text)
758 (Ffind_charset_region):
759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
760 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
761 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 762 Don't assume fixnum fits in int.
d311d28c
PE
763 (load_charset_map_from_vector, Fmap_charset_chars):
764 Remove now-unnecessary CHECK_NATNUMs.
765 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
766 Don't rely on undefined behavior with signed left shift overflow.
767 Don't assume unsigned int fits into fixnum, or that fixnum fits
768 into unsigned int. Don't require max_code to be a valid fixnum;
769 that's not true for gb10830 4-byte on a 32-bit host. Allow
770 invalid_code to be a cons, for the same reason. Require code_offset
771 to be a character. Avoid int overflow if max_char is close
772 to INT_MAX.
773 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
774 this is intended anyway and avoids some undefined behavior.
775 (load_charset_map): Pass unsigned, not int, as 2nd arg of
776 INDEX_TO_CODE_POINT, as that's what it expects.
777 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
778 * charset.h (DECODE_CHAR): Return int, not unsigned;
779 this is what was intended anyway, and it avoids undefined behavior.
780 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
781 integer-overflow issues.
782 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
783 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
784 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
785 * chartab.c (Fmake_char_table, Fset_char_table_range)
786 (uniprop_get_decoder, uniprop_get_encoder):
787 Don't assume fixnum fits in int.
788 * cmds.c (move_point): New function, that does the gist of
789 Fforward_char and Fbackward_char, but does so while checking
790 for integer overflow more accurately.
c96e5d6a 791 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
792 (Fforward_line, Fend_of_line, internal_self_insert)
793 (internal_self_insert):
794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
795 Fix a FIXME, by checking for integer overflow when calculating
796 target_clm and actual_clm.
797 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 798 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
799 (ASSURE_DESTINATION, coding_alloc_by_realloc)
800 (coding_alloc_by_making_gap, alloc_destination)
801 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
802 (encode_coding_utf_16, detect_coding_emacs_mule)
803 (decode_coding_emacs_mule, encode_coding_emacs_mule)
804 (detect_coding_iso_2022, decode_coding_iso_2022)
805 (encode_invocation_designation, encode_designation_at_bol)
806 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
807 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
808 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
809 (encode_coding_ccl, encode_coding_raw_text)
810 (detect_coding_charset, decode_coding_charset)
811 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
812 (produce_composition, produce_charset, produce_annotation)
813 (decode_coding, handle_composition_annotation)
814 (handle_charset_annotation, consume_chars, decode_coding_gap)
815 (decode_coding_object, encode_coding_object, detect_coding_system)
816 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
817 (code_convert_region, code_convert_string)
8f50130c
PE
818 (Fdefine_coding_system_internal)
819 (coding_set_source, coding_set_destination):
d311d28c
PE
820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
821 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
822 (Fdefine_coding_system_internal):
823 Don't assume fixnums fit in int.
824 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 825 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
826 (Funencodable_char_position, Fcheck_coding_systems_region)
827 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 829 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 830 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 831 Don't access memory outside of the args array.
d311d28c 832 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
833 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
834 result of ENCODE_CHAR.
d311d28c
PE
835 * coding.h: Adjust decls to match defn changes elsewhere.
836 (struct coding_system):
837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
838 * composite.c (get_composition_id, find_composition)
839 (run_composition_function, update_compositions)
840 (compose_text, composition_gstring_put_cache)
841 (composition_gstring_p, composition_gstring_width)
842 (fill_gstring_header, fill_gstring_body, autocmp_chars)
843 (composition_compute_stop_pos, composition_reseat_it)
844 (composition_update_it, struct position_record)
845 (find_automatic_composition, composition_adjust_point)
846 (Fcomposition_get_gstring, Ffind_composition_internal):
847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
848 (update_compositions):
849 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
850 * composite.h: Adjust decls to match defn changes elsewhere.
851 (struct composition):
852 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
853 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
854 Do not attempt to compute the address of the object just before a
855 buffer; this is not portable.
856 (Faref, Faset):
857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
858 (Faset): Use int, not EMACS_INT, where int is wide enough.
859 (Fstring_to_number): Don't assume fixnums fit in int.
860 (Frem): Don't assume arg is nonnegative.
861 * dbusbind.c (xd_append_arg): Check for integers out of range.
862 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 863 (extract_signed, extract_unsigned): New functions.
243e0530
PE
864 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
865 (xd_get_connection_references): Return ptrdiff_t, not int.
866 All uses changed.
867 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
868 (xd_read_message_1):
869 Use int, not unsigned, where the dbus API uses int.
870 (Fdbus_message_internal): Don't overflow mtype.
871 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
872 * dired.c (directory_files_internal, file_name_completion, scmp)
873 (file_name_completion_stat):
874 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
875 (file_name_completion): Don't overflow matchcount.
876 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
877 * dispextern.h: Adjust decls to match defn changes elsewhere.
878 (struct text_pos, struct glyph, struct bidi_saved_info)
879 (struct bidi_string_data, struct bidi_it, struct composition_it)
880 (struct it):
881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
882 (struct display_pos, struct composition_it, struct it):
883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
884 * dispnew.c (increment_matrix_positions)
885 (increment_row_positions, mode_line_string)
886 (marginal_area_string):
887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 888 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
890 (duration_to_sec_usec): New function, to check for overflow better.
891 (Fsleep_for, sit_for): Use it.
892 * doc.c (get_doc_string, store_function_docstring):
893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
894 (get_doc_string, Fsnarf_documentation):
895 Use int, not EMACS_INT, where int is wide enough.
896 (get_doc_string):
897 Use SAFE_ALLOCA, not alloca.
898 Check for overflow when converting EMACS_INT to off_t.
899 * doprnt.c (doprnt):
900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
901 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
902 Don't assume uid_t fits into fixnum.
903 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
904 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
905 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
906 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
907 (general_insert_function)
908 (Finsert_char, make_buffer_string, make_buffer_string_both)
909 (update_buffer_properties, Fbuffer_substring)
910 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
911 (Fsubst_char_in_region, check_translation)
912 (Ftranslate_region_internal, save_restriction_restore, Fformat)
913 (transpose_markers, Ftranspose_regions):
914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
915 (clip_to_bounds): Move to lisp.h as an inline function).
916 (Fconstrain_to_field): Don't assume integers are nonnegative.
917 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
918 (Fsubst_char_in_region, Fsave_restriction):
919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
920 (Femacs_pid): Don't assume pid_t fits into fixnum.
921 (lo_time): Use int, not EMACS_INT, when int suffices.
922 (lisp_time_argument): Check for usec out of range.
923 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
924 (Fuser_login_name, Fuser_full_name): Signal an error
925 if a uid argument is out of range, rather than relying on
926 undefined behavior.
c8d5c857
PE
927 (Fformat_time_string): Remove now-unnecessary check.
928 lisp_time_argument checks for out-of-range usec now.
243e0530 929 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
930 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
931 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
932 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
933 (init_cmdargs, Fdump_emacs):
934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
935 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
936 the bottom (typically) 32 bits of the fixnum.
937 * eval.c (specpdl_size, call_debugger):
938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
939 (when_entered_debugger, Fbacktrace_debug):
940 Don't assume fixnum can fit in int.
941 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
942 the object just before a buffer; this is not portable.
943 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
944 (grow_specpdl, unbind_to):
945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
946 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
947 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 948 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
949 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
950 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
951 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
952 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
953 (a_write, e_write):
954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
955 (Fcopy_file, non_regular_nbytes, read_non_regular)
956 (Finsert_file_contents):
957 Use int, not EMACS_INT, where int is wide enough.
958 (READ_BUF_SIZE): Verify that it fits in int.
959 (Finsert_file_contents): Check that counts are in proper range,
960 rather than assuming fixnums fit into ptrdiff_t etc.
961 Don't assume fixnums fit into int.
125b3835 962 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
963 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
964 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
965 (string_char_to_byte, string_byte_to_char)
966 (string_make_multibyte, string_to_multibyte)
967 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
968 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
969 (substring_both, Fdelete, internal_equal, Ffillarray)
970 (Fclear_string, mapcar1)
971 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
972 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
973 (larger_vector, make_hash_table, maybe_resize_hash_table)
974 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
975 (Fmaphash, secure_hash):
976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977 (concat): Check for string index and length overflow.
978 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
979 (Frequire):
980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
981 (larger_vector): New API (vec, incr_min, size_max) replaces old
982 one (vec, new_size, init). This catches size overflow.
983 INIT was removed because it was always Qnil.
984 All callers changed.
985 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
986 the upper bound on a hash table index size.
987 (make_hash_table, maybe_resize_hash_table): Use it.
988 (secure_hash): Computer start_byte and end_byte only after
989 they're known to be in ptrdiff_t range.
990 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
991 (Ffont_get_glyphs, Ffont_at):
992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
993 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
994 (Flist_fonts, Fopen_font):
995 Don't assume fixnum can fit in int.
996 (check_gstring): Don't assume index can fit in int.
997 (font_match_p): Check that fixnum is a character, not a nonnegative
998 fixnum, since the later code needs to stuff it into an int.
999 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1000 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1001 conversion overflow issues.
1002 (Fopen_font): Check for integer out of range.
1003 (Ffont_get_glyphs): Don't assume index can fit in int.
1004 * font.h: Adjust decls to match defn changes elsewhere.
1005 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1006 integer overflow.
1007 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1008 printmax_t, where ptrdiff_t is wide enough.
1009 (Finternal_char_font):
1010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1011 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1012 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1013 (Fset_frame_position, x_set_frame_parameters)
1014 (x_set_line_spacing, x_set_border_width)
1015 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1016 Check that fixnums are in proper range for system types.
1017 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1019 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1020 Use SAFE_ALLOCA_LISP, not alloca.
1021 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1022 intptr_t is wide enough.
1023 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1024 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1025 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1026 Check for fixnum out of range.
1027 * ftfont.c (ftfont_list): Don't assume index fits in int.
1028 Check that fixnums are in proper range for system types.
1029 (ftfont_shape_by_flt):
1030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1031 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1033 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1034 Check that fixnums are in proper range for system types.
1035 * gnutls.h: Adjust decls to match defn changes elsewhere.
1036 * gtkutil.c (xg_dialog_run):
1037 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1038 (update_frame_tool_bar):
1039 Check that fixnums are in proper range for system types.
1040 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1041 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1042 * indent.c (last_known_column, last_known_column_point):
1043 (current_column_bol_cache):
1044 (skip_invisible, current_column, check_display_width):
1045 (check_display_width, scan_for_column, current_column_1)
1046 (Findent_to, Fcurrent_indentation, position_indentation)
1047 (indented_beyond_p, Fmove_to_column, compute_motion):
1048 (Fcompute_motion, Fvertical_motion):
1049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1050 (last_known_column_modified): Use EMACS_INT, not int.
1051 (check_display_width):
1052 (Fcompute_motion):
1053 Check that fixnums and floats are in proper range for system types.
1054 (compute_motion): Don't assume index or fixnum fits in int.
1055 (compute_motion, Fcompute_motion):
1056 Use int, not EMACS_INT, when it is wide enough.
1057 (vmotion): Omit local var start_hpos that is always 0; that way
1058 we don't need to worry about overflow in expressions involving it.
1059 * indent.h: Adjust decls to match defn changes elsewhere.
1060 (struct position):
1061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1062 Use int, not EMACS_INT, where int is wide enough.
1063 Remove unused members ovstring_chars_done and tab_offset;
1064 all uses removed.
1065 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1066 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1067 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1068 (make_gap, copy_text, insert, insert_and_inherit)
1069 (insert_before_markers, insert_before_markers_and_inherit)
1070 (insert_1, count_combining_before, count_combining_after)
1071 (insert_1_both, insert_from_string)
1072 (insert_from_string_before_markers, insert_from_string_1)
1073 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1074 (adjust_after_replace, adjust_after_insert, replace_range)
1075 (replace_range_2, del_range, del_range_1, del_range_byte)
1076 (del_range_both, del_range_2, modify_region)
1077 (prepare_to_modify_buffer, signal_before_change)
1078 (signal_after_change, Fcombine_after_change_execute):
1079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1080 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1081 (balance_an_interval, split_interval_right, split_interval_left)
1082 (find_interval, next_interval, update_interval)
1083 (adjust_intervals_for_insertion, delete_node, delete_interval)
1084 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1085 (static_offset_intervals, offset_intervals)
1086 (merge_interval_right, merge_interval_left, make_new_interval)
1087 (graft_intervals_into_buffer, temp_set_point_both)
1088 (temp_set_point, set_point, adjust_for_invis_intang)
1089 (set_point_both, move_if_not_intangible, get_property_and_range)
1090 (get_local_map, copy_intervals, copy_intervals_to_string)
1091 (compare_string_intervals, set_intervals_multibyte_1):
1092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1093 * intervals.h: Adjust decls to match defn changes elsewhere.
1094 (struct interval):
1095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1096 * keyboard.c (this_command_key_count, this_single_command_key_start)
1097 (before_command_key_count, before_command_echo_length, echo_now)
1098 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1099 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1100 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1101 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1103 (last_non_minibuf_size, last_point_position, echo_truncate)
1104 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1105 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1106 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1107 (stuff_buffered_input):
1108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1109 (last_auto_save, command_loop_1, read_char):
1110 Use EMACS_INT, not int, to avoid integer overflow.
1111 (record_char): Avoid overflow in total_keys computation.
1112 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1113 * keyboard.h: Adjust decls to match defn changes elsewhere.
1114 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1115 (Fkey_description, Fdescribe_vector, Flookup_key):
1116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1117 (click_position): New function, to check that positions are in range.
1118 (Fcurrent_active_maps):
1119 (describe_command):
1120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1121 (Faccessible_keymaps, Fkey_description):
1122 (preferred_sequence_p):
1123 Don't assume fixnum can fit into int.
1124 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1125 Check for integer overflow in size calculations.
1126 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1127 avoid mishandling large integers.
1128 * lisp.h: Adjust decls to match defn changes elsewhere.
1129 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1130 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1131 (struct Lisp_Marker):
1132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1133 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1134 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1135 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1136 All callers changed.
1137 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1138 Assume the arg has valid form, since it always does.
1139 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1140 unsigned integer system type.
1141 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1142 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1144 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1145 (duration_to_sec_usec): New decl.
1146 * lread.c (read_from_string_index, read_from_string_index_byte)
1147 (read_from_string_limit, readchar, unreadchar, openp)
1148 (read_internal_start, read1, oblookup):
1149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1150 (Fload, readevalloop, Feval_buffer, Feval_region):
1151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1152 (openp): Check for out-of-range argument to 'access'.
1153 (read1): Use int, not EMACS_INT, where int is wide enough.
1154 Don't assume fixnum fits into int.
6efdadfd 1155 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1156 (read_filtered_event): Use duration_to_sec_usec
1157 to do proper overflow checking on durations.
d311d28c
PE
1158 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1159 in size calculation.
1160 (Fexecute_kbd_macro):
1161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1162 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1163 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1164 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1165 (set_marker_both, set_marker_restricted_both, marker_position)
1166 (marker_byte_position, Fbuffer_has_markers_at):
1167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1168 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1169 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1170 It now merely ensures that the menu is large enough, without
1171 necessarily growing it, as this avoids some integer overflow issues.
1172 All callers changed.
1173 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1175 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1176 Use SAFE_ALLOCA_LISP, not alloca.
1177 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1178 to EMACS_INT. Check that fixnums are in proper range for system types.
1179 * minibuf.c (minibuf_prompt_width, string_to_object)
1180 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1181 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1183 (get_minibuffer, read_minibuf_unwind):
1184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1185 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1186 this simplifies overflow checking. All callers changed.
1187 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1188 (Ftest_completion):
1189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1190 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1191 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1192 Check that fixnums are in proper range for system types.
1193 (Fx_create_frame, Fx_show_tip):
1194 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1195 * nsfont.m (ns_findfonts, nsfont_list_family):
1196 Don't assume fixnum fits in long.
1197 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1199 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1200 wide enough.
17fdb222 1201 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1203 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1204 (PRINTDECLARE, PRINTPREPARE):
1205 (strout, print_string):
1206 (print, print_preprocess, print_check_string_charset_prop)
1207 (print_object):
1208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1209 (PRINTDECLARE):
1210 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1212 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1213 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1214 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1215 (print_error_message): Use SAFE_ALLOCA, not alloca.
1216 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1217 (print_depth, new_backquote_output, print_number_index):
1218 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1219 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1220 (Fset_process_window_size, Fformat_network_address)
1221 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1222 (sigchld_handler):
d311d28c 1223 Check that fixnums are in proper range for system types.
d44287d4 1224 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1225 Check for process-ids out of pid_t range rather than relying on
1226 undefined behavior.
e4d81efc 1227 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1228 (Fformat_network_address, read_process_output, send_process)
1229 (Fprocess_send_region, status_notify):
1230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1231 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1232 (wait_reading_process_output, read_process_output, exec_sentinel):
1233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1234 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1235 (Faccept_process_output): Use duration_to_sec_usec to do proper
1236 overflow checking on durations.
dde14581
PE
1237 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1238 Don't assume pid_t fits in int.
02481186
PE
1239 * process.h (struct Lisp_Process): Members tick and update_tick
1240 are now of type EMACS_INT, not int.
b62b53e8
PE
1241 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1242 configured --with-wide-int.
d311d28c
PE
1243 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1244 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1245 * search.c (looking_at_1, string_match_1):
1246 (fast_string_match, fast_c_string_match_ignore_case)
1247 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1248 (scan_newline, find_before_next_newline, search_command)
1249 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1250 (set_search_regs, wordify):
1251 (Freplace_match):
1252 (Fmatch_data):
1253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1254 (string_match_1, search_buffer, set_search_regs):
1255 (Fmatch_data):
1256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1257 (wordify): Check for overflow in size calculation.
1258 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1259 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1260 Check that fixnums are in proper range for system types.
1261 * sound.c (struct sound_device)
1262 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1264 (Fplay_sound_internal):
1265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1266 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1267 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1268 (Fparse_partial_sexp):
1269 Don't assume fixnums can fit in int.
1270 (struct lisp_parse_state, find_start_pos, find_start_value)
1271 (find_start_value_byte, find_start_begv)
1272 (update_syntax_table, char_quoted, dec_bytepos)
1273 (find_defun_start, prev_char_comend_first, back_comment):
1274 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1275 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1277 (Finternal_describe_syntax_value): Check that match_lisp is a
1278 character, not an integer, since the code stuffs it into int.
1279 (scan_words, scan_sexps_forward):
1280 Check that fixnums are in proper range for system types.
1281 (Fforward_word):
1282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1283 (scan_sexps_forward):
1284 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1285 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1286 * syntax.h: Adjust decls to match defn changes elsewhere.
1287 (struct gl_state_s):
1288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1289 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1290 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1291 * sysdep.c (wait_for_termination_1, wait_for_termination)
1292 (interruptible_wait_for_termination, mkdir):
1293 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1294 (emacs_read, emacs_write):
1295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1296 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1297 and double all fit in int.
d311d28c
PE
1298 * term.c (set_tty_color_mode):
1299 Check that fixnums are in proper range for system types.
1300 * termhooks.h (struct input_event):
1301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1302 * textprop.c (validate_interval_range, interval_of)
1303 (Fadd_text_properties, set_text_properties_1)
1304 (Fremove_text_properties, Fremove_list_of_text_properties)
1305 (Ftext_property_any, Ftext_property_not_all)
1306 (copy_text_properties, text_property_list, extend_property_ranges)
1307 (verify_interval_modification):
1308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1309 (Fnext_single_char_property_change)
1310 (Fprevious_single_char_property_change):
1311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1312 (copy_text_properties):
1313 Check for integer overflow in index calculation.
d311d28c
PE
1314 * undo.c (last_boundary_position, record_point, record_insert)
1315 (record_delete, record_marker_adjustment, record_change)
1316 (record_property_change):
1317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1318 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1320 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1321 (Fx_hide_tip, Fx_file_dialog):
1322 * w32menu.c (set_frame_menubar):
1323 Use ptrdiff_t, not int, for consistency with rest of code.
1324 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1325 (select_window, Fdelete_other_windows_internal)
1326 (window_scroll_pixel_based, window_scroll_line_based)
1327 (Frecenter, Fset_window_configuration):
1328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1329 (Fset_window_hscroll, run_window_configuration_change_hook)
1330 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1331 (Fscroll_other_window, Frecenter):
d311d28c
PE
1332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1333 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1334 Don't assume fixnum fits in int.
1335 (Fset_window_scroll_bars):
1336 Check that fixnums are in proper range for system types.
1337 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1338 (string_pos, c_string_pos, number_of_chars, init_iterator)
1339 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1340 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1341 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1342 (face_before_or_after_it_pos, handle_invisible_prop)
1343 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1344 (display_prop_intangible_p, string_buffer_position_lim)
1345 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1346 (get_overlay_strings_1, get_overlay_strings)
1347 (iterate_out_of_display_property, forward_to_next_line_start)
1348 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1349 (get_next_display_element, set_iterator_to_next)
1350 (get_visually_first_element, compute_stop_pos_backwards)
1351 (handle_stop_backwards, next_element_from_buffer)
1352 (move_it_in_display_line_to, move_it_in_display_line)
1353 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1354 (add_to_log, message_dolog, message_log_check_duplicate)
1355 (message2, message2_nolog, message3, message3_nolog
1356 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1357 (current_message_1, truncate_echo_area, truncate_message_1)
1358 (set_message, set_message_1, store_mode_line_noprop)
1359 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1360 (text_outside_line_unchanged_p, check_point_in_composition)
1361 (reconsider_clip_changes)
1362 (redisplay_internal, set_cursor_from_row, try_scrolling)
1363 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1364 (redisplay_window, find_last_unchanged_at_beg_row)
1365 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1366 (trailing_whitespace_p, find_row_edges, display_line)
1367 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1368 (display_mode_element, store_mode_line_string)
1369 (pint2str, pint2hrstr, decode_mode_spec)
1370 (display_count_lines, display_string, draw_glyphs)
1371 (x_produce_glyphs, x_insert_glyphs)
1372 (rows_from_pos_range, mouse_face_from_buffer_pos)
1373 (fast_find_string_pos, mouse_face_from_string_pos)
1374 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1376 (safe_call, init_from_display_pos, handle_fontified_prop)
1377 (handle_single_display_spec, load_overlay_strings)
1378 (with_echo_area_buffer, setup_echo_area_for_printing)
1379 (display_echo_area, echo_area_display)
1380 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1381 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1382 (redisplay_window, dump_glyph_row, display_mode_line)
1383 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1384 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1386 (handle_single_display_spec, build_desired_tool_bar_string)
1387 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1388 (get_specified_cursor_type):
1389 Check that fixnums are in proper range for system types.
1390 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1391 (Flookup_image_map):
1392 Don't assume fixnums fit in int.
1393 (compare_overlay_entries):
1394 Avoid mishandling comparisons due to subtraction overflow.
1395 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1396 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1397 (handle_tool_bar_click):
1398 Use int, not unsigned, since we prefer signed and the signedness
1399 doesn't matter here.
1400 (get_next_display_element, next_element_from_display_vector):
1401 Use int, not EMACS_INT, when int is wide enough.
1402 (start_hourglass): Use duration_to_sec_usec to do proper
1403 overflow checking on durations.
1404 * xfaces.c (Fbitmap_spec_p):
1405 Check that fixnums are in proper range for system types.
1406 (compare_fonts_by_sort_order):
1407 Avoid mishandling comparisons due to subtraction overflow.
1408 (Fx_family_fonts, realize_basic_faces):
1409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1410 (Fx_family_fonts):
1411 Don't assume fixnum fits in int.
1412 Use SAFE_ALLOCA_LISP, not alloca.
1413 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1414 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1415 (face_at_buffer_position, face_for_overlay_string)
1416 (face_at_string_position):
1417 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1418 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1419 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1420 (Fx_show_tip):
1421 Check that fixnums are in proper range for system types.
1422 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1423 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1425 (Fx_change_window_property): Don't assume fixnums fit in int.
1426 * xfont.c (xfont_chars_supported):
1427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1428 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1429 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1431 * xml.c (parse_region):
1432 * xrdb.c (magic_file_p):
1433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1434 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1435 (x_get_local_selection, x_reply_selection_request)
1436 (x_handle_selection_request, wait_for_property_change):
1437 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1438 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1439 short is wide enough.
1440 (x_send_client_event): Don't assume fixnum fits in int.
1441 * xterm.c (x_x_to_emacs_modifiers):
1442 Don't assume EMACS_INT overflows nicely into int.
1443 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1444 may come from Lisp.
1445 (handle_one_xevent): NATNUMP can eval its arg twice.
1446 (x_connection_closed):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 * xterm.h: Adjust decls to match defn changes elsewhere.
1449 (struct scroll_bar): Use struct vectorlike_header
1450 rather than rolling our own approximation.
1451 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1452
c6574eb5
GM
14532012-05-25 Glenn Morris <rgm@gnu.org>
1454
1455 * lisp.mk (lisp): Update for more files being compiled now.
1456
e8d32c7e
SM
14572012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1458
48def666
SM
1459 * lread.c: Remove `read_pure' which makes no difference.
1460 (read_pure): Remove var.
1461 (unreadpure): Remove function.
1462 (readevalloop): Don't call read_list with -1 flag.
1463 (read1, read_vector): Don't test read_pure any more.
1464 (read_list): Simplify.
1465
e8d32c7e
SM
1466 * fileio.c, character.h: Minor style tweaks.
1467
4b2addb7
DA
14682012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1469
1470 * window.h (clip_changed): Remove useless declaration.
1471
584461b2
JB
14722012-05-22 Juanma Barranquero <lekktu@gmail.com>
1473
1474 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1475 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1476
34374650
PE
14772012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1478
1479 Remove src/m/*.
1480 This directory predates autoconf and is no longer needed nowadays.
1481 Move its few remaining bits of functionality to where they're needed.
1482 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1483 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1484 * m/template.h: Remove.
1485 * Makefile.in (M_FILE): Remove. All uses removed.
1486 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1487 * lisp.h (USE_LSB_TAG):
1488 * mem-limits.h (EXCEEDS_LISP_PTR):
1489 Use VAL_MAX, not VALBITS, in #if.
1490 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1491 (EMACS_UINT): Define unconditionally now.
1492 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1493 (BITS_PER_EMACS_INT): New constants, replacing
1494 what used to be in config.h, but not useful in #if.
1495 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1496 define them any more.
1497 (VAL_MAX): New macro.
1498 (VALMASK): Use it.
1499 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1500 BITS_PER_EMACS_INT, in #if.
1501 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1502 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1503 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1504 * s/ms-w32.h (DATA_START):
1505 Move here from removed file m/intel386.h.
1506 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1507 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1508
261cb4bb
PE
15092012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1510
1511 Assume C89 or later.
1512 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1513 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1514 (xrealloc):
1515 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1516 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1517 * textprop.c, tparam.c (NULL): Remove.
1518 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1519 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1520 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1521 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1522 * xterm.c (input_signal_count): Assume volatile works.
1523
ff23cd9f
KB
15242012-05-21 Ken Brown <kbrown@cornell.edu>
1525
1526 * xgselect.c (xg_select): Fix first argument in call to 'select'
1527 (bug#11508).
1528
1b170bc6
KB
15292012-05-20 Ken Brown <kbrown@cornell.edu>
1530
1531 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1532 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1533
b2f4d39f
KB
15342012-05-19 Ken Brown <kbrown@cornell.edu>
1535
1536 * xfns.c (x_in_use): Remove `static' qualifier.
1537 * xterm.h (x_in_use): Declare.
1538 * xgselect.c: Include xterm.h.
1539 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1540 and `display_arg' (bug#9754).
1541
003fdae2
PE
15422012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1543
9232a6d9
PE
1544 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1545
003fdae2
PE
1546 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1547 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1548
784b56e2
EZ
15492012-05-18 Eli Zaretskii <eliz@gnu.org>
1550
1551 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1552
1553 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1554 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1555
1556 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1557 reference to image_cache->refcount.
1558 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1559
a0a79cde
JL
15602012-05-17 Juri Linkov <juri@jurta.org>
1561
1562 * search.c (Fword_search_regexp, Fword_search_backward)
1563 (Fword_search_forward, Fword_search_backward_lax)
1564 (Fword_search_forward_lax): Move functions to isearch.el
1565 (bug#10145, bug#11381).
1566
b0572523
PE
15672012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1568
1569 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1570
9660f5fc
SM
15712012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1572
1573 * lread.c (init_obarray): Declare Qt and Qnil as special.
1574
4374de83
GM
15752012-05-14 Glenn Morris <rgm@gnu.org>
1576
1577 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1578 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1579
dc44c39a
PE
15802012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1581
078c97cb
PE
1582 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1583
dc44c39a
PE
1584 * unexaix.c: Port to more-recent AIX compilers.
1585 (report_error, report_error_1, make_hdr, copy_sym)
1586 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1587 Make arguments const char *, not char *, to avoid violations of C
1588 standard and to fix some AIX warnings reported by Gilles Pion.
1589
e18afed7 15902012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1591
1592 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1593 already have overlays loaded.
1594 (handle_single_display_spec): Before returning without displaying
1595 fringe bitmap, synchronize the bidi iterator with the main display
1596 iterator, by calling iterate_out_of_display_property.
1597 (iterate_out_of_display_property): Detect buffer iteration by
1598 testing that it->string is a Lisp string.
1599 (get_next_display_element): When the current object is exhausted,
1600 and there's something on it->stack, call set_iterator_to_next to
1601 proceed with what's on the stack, instead of returning zero.
1602 (set_iterator_to_next): If called at the end of a Lisp string,
1603 proceed to consider_string_end without incrementing string
1604 position. Don't increment display vector index past the end of
1605 the display vector. (Bug#11417)
c8fb9dc6
EZ
1606 (pos_visible_p): Don't report a position visible when move_it_to
1607 stopped at the last line of window, which happens to be scanned
1608 backwards by the bidi iteration. (Bug#11464)
ac268e67 1609
e18afed7 16102012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1611
1612 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1613 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1614 are on a TTY, and thus unable to display on the fringes.
1615 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1616 so we need to signal to the caller that this is a "replacing"
1617 display spec. This fixes display when the spec is invalid or we
1618 are on a TTY.
1619
e18afed7 16202012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1621
1622 * unexaix.c (make_hdr): Fix typo in prototype.
1623 This bug broke the build on AIX. Problem reported by Gilles Pion.
1624
9d0a235a
MA
16252012-05-14 Michael Albinus <michael.albinus@gmx.de>
1626
1627 * keyboard.c (kbd_buffer_get_event): Read special events also in
1628 batch mode. (Bug#11415)
1629
9e6b06ed
GM
16302012-05-12 Glenn Morris <rgm@gnu.org>
1631
1632 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1633
c1a1d7a3
EZ
16342012-05-12 Eli Zaretskii <eliz@gnu.org>
1635
1636 * lisp.mk (lisp): Add newcomment.elc.
1637
3fe7cdc8
GM
16382012-05-12 Glenn Morris <rgm@gnu.org>
1639
1640 * Makefile.in (MKDIR_P): New, set by configure.
1641 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1642
53f7d2c0
PE
16432012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1644
1645 Remove unused function hourglass_started.
1646 * dispextern.h (hourglass_started):
1647 * w32fns.c (hourglass_started):
1648 * xdisp.c (hourglass_started): Remove.
1649
75aafb17
JB
16502012-05-10 Juanma Barranquero <lekktu@gmail.com>
1651
1652 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1653 Update dependencies.
1654
12959e8e
PE
16552012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1656
97107e2e
PE
1657 * xgselect.c (xg_select): Put maxfds+1 into a var.
1658 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1659
12959e8e
PE
1660 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1661
836d29b3
DA
16622012-05-10 Dave Abrahams <dave@boostpro.com>
1663
1664 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1665 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1666
5cb67954
MA
16672012-05-09 Michael Albinus <michael.albinus@gmx.de>
1668
1669 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1670 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1671 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1672 Initialize xd_registered_buses.
1673
3478ec45
PE
16742012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1675
b263a6b0
PE
1676 Untag more efficiently if USE_LSB_TAG.
1677 This is based on a proposal by YAMAMOTO Mitsuharu in
1678 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1679 For an admittedly artificial (nth 8000 longlist) benchmark on
1680 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1681 Emacs's overall text size by 1%.
1682 * lisp.h (XUNTAG): New macro.
1683 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1684 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1685 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1686 * eval.c (Fautoload):
1687 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1688 * frame.h (XFRAME): Use XUNTAG.
1689
3478ec45
PE
1690 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1691 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1692 Remove unportable assumptions about print widths of types like
1693 dbus_uint32_t.
1694 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1695 intptr_t when converting between pointer and integer, to avoid GCC
1696 warnings about wrong width.
1697
666b903b 16982012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1699
1700 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1701 stack for each reader_thread, instead of defaulting to 8MB
1702 determined by the linker. This avoids failures in creating
1703 subprocesses on Windows 7, see the discussion in this thread:
1704 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1705
b120cc17
JC
17062012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1707
1708 Fix up display of the *Minibuf-0* buffer in the mini window.
1709 * keyboard.c (read_char): Don't clear the echo area if there's no
1710 message to clear.
1711 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1712 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1713
9a4b36f8
MA
17142012-05-07 Michael Albinus <michael.albinus@gmx.de>
1715
1716 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1717 batch mode.
1718
e5f9458f
CY
17192012-05-06 Chong Yidong <cyd@gnu.org>
1720
1721 * lisp.mk (lisp): Update.
1722
eceeb5fc 17232012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1724
1725 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1726
71873e2b
SM
17272012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1728
1729 * data.c (PUT_ERROR): New macro.
1730 (syms_of_data): Use it. Add new error type `user-error'.
1731 * undo.c (user_error): New function.
1732 (Fprimitive_undo): Use it.
1733 * print.c (print_error_message): Adjust print style for `user-error'.
1734 * keyboard.c (user_error): New function.
1735 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1736
ab0fa4e4
PE
17372012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1738
1739 Do not limit current-time-string to years 1000..9999.
1740 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1741 (Fcurrent_time_string): Support any year that is supported by the
1742 underlying localtime representation. Don't use asctime, as it
1743 has undefined behavior for years outside the range -999..9999.
1744
7ed806a7
PE
17452012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1746
1747 Fix race conditions involving setenv, gmtime, localtime, asctime.
1748 Without this fix, interrupts could mess up code that uses these
1749 nonreentrant functions, since setting TZ invalidates existing
1750 tm_zone or tzname values, and since most of these functions return
1751 pointers to static storage.
1752 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1753 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1754 Grow the critical sections to include not just invoking
1755 localtime/gmtime, but also accessing these functions' results
1756 including their tm_zone values if any, and any related TZ setting.
1757 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1758 so that the struct tm is saved in the critical section.
1759 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1760 motivated by the fact that memory allocation needs to be outside
1761 the critical section.
1762
0c16dfed
DA
17632012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1764
1765 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1766 with RESET_INTERVAL.
1767
1768 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1769 Remove duplicated buffer name initialization.
1770
3f83ace8
JM
17712012-05-02 Jim Meyering <jim@meyering.net>
1772
1773 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1774
c7b8541e
JM
1775 * xfns.c (x_window): Use xstrdup (Bug#11375).
1776
90207a15 17772012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1778
1779 * xdisp.c (pos_visible_p): If already at a newline from the
1780 display string before the 'while' loop, don't walk back the glyphs
1781 from it3.glyph_row. Solves assertion violation when the display
1782 string begins with a newline (egg.el). (Bug#11367)
1783
b593d6a9
AH
17842012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1785
1786 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1787 Move to simple.el.
1788
4737362e
GM
17892012-05-01 Glenn Morris <rgm@gnu.org>
1790
99cf43f9
GM
1791 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1792 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1793 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1794 All were removed before 23.1.
1795
9311dcff
GM
1796 * dispnew.c: Remove HAVE_LIBNCURSES test;
1797 it is always true on relevant platforms.
1798
4d5c6349
GM
1799 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1800 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1801
4737362e
GM
1802 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1803
74dd3a6b
AS
18042012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1805
1806 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1807 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1808 Remove.
1809
13c379ee
PE
18102012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 Do not avoid creating empty evaporating overlays (Bug#9642).
1813 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1814 That is, do not delete an evaporating overlay if it becomes
1815 empty after its bounds are adjusted to fit within its buffer.
1816 This fix caused other problems, and I'm reverting it until we get
1817 to the bottom of them.
1818
a8e7d6d7 18192012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1820
1821 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1822
a8e7d6d7 18232012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1824
1825 * xdisp.c (pos_visible_p): If the window start position is beyond
1826 ZV, start the display from buffer beginning. Prevents assertion
1827 violation in init_iterator when the minibuffer window is scrolled
1828 via the scroll bar.
1829
1830 * window.c (window_scroll_pixel_based): Likewise.
1831
a8e7d6d7 18322012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1833
1834 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1835
a8e7d6d7 18362012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1837
1838 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1839 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1840
a8e7d6d7 18412012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1842
b593d6a9
AH
1843 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1844 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1845
1c6900d9
EZ
18462012-04-26 Eli Zaretskii <eliz@gnu.org>
1847
4c3fa1d9
EZ
1848 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1849 display element, check also the underlying string or buffer
1850 character. (Bug#11341)
1851
1c6900d9
EZ
1852 * w32menu.c: Include w32heap.h.
1853 (add_menu_item): If the call to AppendMenuW (via
1854 unicode_append_menu) fails, disable Unicode menus only if we are
1855 running on Windows 9X/Me.
1856
42bf8205
AS
18572012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1858
1859 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1860 (xgetint): Add missing shift for LSB tags.
1861
b1bac16e
MR
18622012-04-24 Martin Rudalics <rudalics@gmx.at>
1863
1864 * keyboard.c (read_char): Don't wipe echo area for select window
1865 events: These might get delayed via `mouse-autoselect-window'
1866 (Bug#11304).
1867
d69621cc
JB
18682012-04-24 Juanma Barranquero <lekktu@gmail.com>
1869
1870 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1871 manipulation of :loaded-from data.
1872
02fd101b
JB
18732012-04-23 Juanma Barranquero <lekktu@gmail.com>
1874
1875 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1876 now a cons (bug#11311).
1877
888bec30
PE
18782012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1879
89a438bd
PE
1880 Do not create empty overlays with the evaporate property (Bug#9642).
1881 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1882 if it becomes empty after its bounds are adjusted to fit within
1883 its buffer. Without this fix, in a nonempty buffer (let ((o
1884 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1885 yields an empty overlay that has the evaporate property, which is
1886 not supposed to happen.
1887
1068fe4d
PE
1888 Fix minor GTK3 problems found by static checking.
1889 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1890 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1891 (struct _EmacsFixedClass, emacs_fixed_get_type):
1892 Move decls here from emacsgtkfixed.h, since they needn't be public.
1893 (emacs_fixed_get_type): Now static.
1894 (emacs_fixed_class_init): Omit unused local.
1895 (emacs_fixed_child_type): Remove; unused.
1896 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1897 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1898 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1899 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1900 (EMACS_FIXED_GET_CLASS): Remove; unused.
1901 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1902
888bec30
PE
1903 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1904 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1905
de85e130
PE
19062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1907
d0baac98 1908 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1909 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1910 (__malloc_size_t, __malloc_ptrdiff_t):
1911 Remove. All uses removed, replaced by the definiens if needed,
1912 since we can assume C89 or better now.
1913 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1914 (protect_malloc_state, align, get_contiguous_space)
1915 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1916 (malloc_atfork_handler_child, malloc_enable_thread)
1917 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1918 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1919 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1920 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1921 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1922 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1923 Define using prototypes, not old style.
1924 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1925 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1926 (align): Don't assume that signed integer overflow wraps around.
1927 Omit unused local var.
1928 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1929 (_free_internal_nolock, memalign, mallochook, reallochook):
1930 Omit no-longer-needed casts.
1931 (valloc): Use getpagesize, not __getpagesize.
1932 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1933 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1934
de85e130
PE
1935 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1936
dcbf5805
MA
19372012-04-22 Michael Albinus <michael.albinus@gmx.de>
1938
1939 Move functions from C to Lisp. Make non-blocking method calls
1940 the default. Implement further D-Bus standard interfaces.
1941
1942 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1943 (QCdbus_request_name_allow_replacement)
1944 (QCdbus_request_name_replace_existing)
1945 (QCdbus_request_name_do_not_queue)
1946 (QCdbus_request_name_reply_primary_owner)
1947 (QCdbus_request_name_reply_in_queue)
1948 (QCdbus_request_name_reply_exists)
1949 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1950 (QCdbus_registered_serial, QCdbus_registered_method)
1951 (QCdbus_registered_signal): New Lisp objects.
1952 (XD_DEBUG_MESSAGE): Use sizeof.
1953 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1954 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1955 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1956 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1957 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1958 (xd_signature, xd_append_arg): Allow float for integer types.
1959 (xd_get_connection_references): New function.
b593d6a9
AH
1960 (xd_get_connection_address): Rename from xd_initialize.
1961 Return cached address.
dcbf5805
MA
1962 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1963 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1964 level.
1965 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1966 Return number of refcounts.
dcbf5805
MA
1967 (Fdbus_get_unique_name): Make stronger parameter check.
1968 (Fdbus_message_internal): New defun.
1969 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1970 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1971 (Fdbus_send_signal, Fdbus_register_service)
1972 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1973 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1974 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1975 (Vdbus_compiled_version, Vdbus_runtime_version)
1976 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1977 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1978 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1979 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1980 Adapt docstring.
dcbf5805 1981
52828e02
PE
19822012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1983
da05bc4c
PE
1984 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1985 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1986 Do not assume ptrdiff_t is the same width as 'int'.
1987
52828e02
PE
1988 * alloc.c: Handle unusual debugging option combinations.
1989 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1990 since the two debugging options are incompatible.
1991 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1992 is defined.
1993 (mem_init, mem_insert, mem_insert_fixup):
1994 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1995 (NEED_MEM_INSERT): Remove; no longer needed.
1996
f01769f9
LL
19972012-04-22 Leo Liu <sdl.web@gmail.com>
1998
1999 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2000
5790543d
PE
20012012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * sysdep.c [__FreeBSD__]: Minor cleanups.
2004 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2005 Use Emacs indenting style more consistently. Avoid some casts.
2006 Use 'double' consistently rather than mixing 'float' and 'double'.
2007
b91b7e4d
EW
20082012-04-21 Eduard Wiebe <usenet@pusto.de>
2009
b593d6a9
AH
2010 * sysdep.c (list_system_processes, system_process_attributes):
2011 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2012
6114eb15
AS
20132012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2014
2015 * lisp.mk (lisp): Update.
2016
2f38dff7
PE
20172012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2020 It is never used otherwise.
2021
4ae29f89
SM
20222012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2023
2024 * print.c (print_preprocess): Only check print_depth if print-circle
2025 is nil.
2026 (print_object): Check for cycles even when print-circle is nil and
2027 print-gensym is t, but only check print_depth if print-circle is nil.
2028
f30d612a
CY
20292012-04-20 Chong Yidong <cyd@gnu.org>
2030
2031 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2032 set the status to "failed" and ensure that sentinel is run.
2033
c07a4c0b 20342012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2035
2036 * process.c (Fset_process_inherit_coding_system_flag)
2037 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2038 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2039
c07a4c0b 20402012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2041
2042 * xdisp.c (string_buffer_position_lim): Limit starting position to
2043 BEGV.
2044 (set_cursor_from_row): If called for a mode-line or header-line
2045 row, return zero immediately.
2046 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2047 farther than the first row after the header line, if any.
2048 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2049 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2050
c07a4c0b 20512012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2052
4ae29f89
SM
2053 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2054 (bug#11238).
ad3a2b41 2055
c07a4c0b 20562012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 20572012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2058
2059 configure: new option --enable-gcc-warnings (Bug#11207)
2060 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2061 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2062 (ALL_CFLAGS): Use new macros rather than old.
2063 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2064 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2065 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2066 -Wunused-result, -Wunused-variable. This should go away once
2067 the Emacs and Gnulib regex code is merged.
2068 (xmalloc, xrealloc): Now static.
2069
aba027e8
PE
20702012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2071
2072 * dired.c (Fsystem_groups): Remove unused local.
2073
e5a36063
GM
20742012-04-17 Glenn Morris <rgm@gnu.org>
2075
2076 * dired.c (Fsystem_users): Doc fix.
2077
316411f0
DA
20782012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2079
2080 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2081 (syms_of_dired): Add them.
2082
9426aba4
PE
20832012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2084
b62a57be
PE
2085 Fix minor alloc.c problems found by static checking.
2086 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2087 New extern decls, to avoid calling undeclared functions.
2088 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2089 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2090 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2091 (NEED_MEM_INSERT): New macro.
2092 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2093 Remove one incorrect comment and fix another.
b62a57be 2094
3539f31f
PE
2095 Fix minor ralloc.c problems found by static checking.
2096 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2097 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2098 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2099 (r_alloc_sbrk): Now static.
2100
a041960a
PE
2101 Improve ralloc.c interface checking.
2102 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2103 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2104 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2105 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2106 [REL_ALLOC]: ... to here, to check interface.
2107 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2108 Remove decls. This fixes an "It stinks!".
2109
9426aba4
PE
2110 * alloc.c (which_symbols): Fix alignment issue / type clash.
2111
d55c12ed
AS
21122012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2115 (struct Lisp_Misc_Any): Likewise.
2116 (struct Lisp_Free): Likewise.
2117 * alloc.c (union aligned_Lisp_Symbol): Define.
2118 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2119 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2120 (union aligned_Lisp_Misc): Define.
2121 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2122 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2123 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2124
b948ce8b
PE
21252012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2126
2127 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2128 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2129 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2130 * s/netbsd.h, s/sol2-6.h:
2131 Remove definition of GC_MARK_STACK, since the default now works.
2132 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2133 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2134 no longer the default.
2135 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2136
35dc09a1 21372012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2138
35dc09a1
GM
2139 * lread.c (lisp_file_lexically_bound_p):
2140 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2141
35dc09a1
GM
21422012-04-14 Eli Zaretskii <eliz@gnu.org>
2143
2144 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2145 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2146
21472012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2148
2149 * nsterm.m (constrainFrameRect): Always constrain when there is only
2150 one screen (Bug#10962).
2151
bcd86815
KB
21522012-04-13 Ken Brown <kbrown@cornell.edu>
2153
2154 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2155
c25df26e
RT
21562012-04-13 Reuben Thomas <rrt@sc3d.org>
2157
2158 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2159
0fc59f1e
DC
21602012-04-11 Daniel Colascione <dancol@dancol.org>
2161
2162 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2163 against is gone. It's better to use vfork now so that when Cygwin
2164 gains a new, working vfork, we use it automatically (bug#10398).
2165
de8c03dc
SM
21662012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2167
2168 * window.c (save_window_save): Obey window-point-insertion-type.
2169
2f097256
GM
21702012-04-11 Glenn Morris <rgm@gnu.org>
2171
2172 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2173
453b951e
SM
21742012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2175
2176 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2177
75f1671a 21782012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2179
2180 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2181 (force_quit_count): New var.
2182 (handle_interrupt): Use it.
2183
2a8ce227
JB
21842012-04-10 Juanma Barranquero <lekktu@gmail.com>
2185
2186 * w32.c (w32_delayed_load): Record the full path of the library
2187 being loaded (bug#10424).
2188
935396c0
GM
21892012-04-09 Glenn Morris <rgm@gnu.org>
2190
05920a43
GM
2191 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2192 not just in the obarray, before snarfing them. (Bug#11036)
2193
935396c0
GM
2194 * Makefile.in ($(leimdir)/leim-list.el):
2195 Pass EMACS rather than BUILT_EMACS.
2196
a18ecafa
TZ
21972012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2198
2199 * process.c (make_process):
2200 * process.h: Add integer `gnutls_handshakes_tried' member to
2201 process struct.
2202
6bbef4e5
JC
2203 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2204 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2205
2206 * gnutls.c (gnutls_log_function2i): Convenience log function.
2207 (emacs_gnutls_read): Use new log functions,
2208 `gnutls_handshakes_tried' process member, and
2209 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2210 attempts per process (connection).
2211
b4d3bc10
CY
22122012-04-09 Chong Yidong <cyd@gnu.org>
2213
2214 * eval.c (Fuser_variable_p, user_variable_p_eh)
2215 (lisp_indirect_variable): Functions deleted.
2216 (Fdefvar): Caller changed.
2217
2218 * callint.c (Finteractive, Fcall_interactively):
2219 * minibuf.c (Fread_variable): Callers changed.
2220
70f4d973
EZ
22212012-04-09 Eli Zaretskii <eliz@gnu.org>
2222
2223 * xdisp.c (set_cursor_from_row): If the display string appears in
2224 the buffer at position that is closer to point than the position
2225 after the display string, display the cursor on the first glyph of
2226 the display string. Fixes cursor display when a 'display' text
2227 property immediately follows invisible text. (Bug#11094)
2228
cb3c2e3e
PE
22292012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2230
2231 composite.c: use 'double' consistently
2232 * composite.c (get_composition_id): Use 'double' consistently
2233 instead of converting 'float' to 'double' and vice versa; this is
2234 easier to understand and avoids a GCC warning.
2235
fd06db5d
GM
22362012-04-09 Glenn Morris <rgm@gnu.org>
2237
50fe702a
GM
2238 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2239 preparation for dumping it with emacs. (Bug#4789)
2240 (leimdir): New variable.
2241 ($(leimdir)/leim-list.el): New rule.
2242 (emacs$(EXEEXT)): Depend on leim-list.el.
2243
fd06db5d
GM
2244 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2245 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2246 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2247
55c131ee
AS
22482012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2249
2250 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2251 proper alignment.
2252
9209588f
JB
22532012-04-07 Juanma Barranquero <lekktu@gmail.com>
2254
2255 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2256 Remove unused local variable.
2257
e3fb2efb
PE
22582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2261 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2262 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2263 objects, as mark_maybe_pointer will catch them otherwise.
2264 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2265 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2266
b5385551
PE
22672012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 Fix typo that broke non-Windows builds.
2270 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2271
9078ead6
EZ
22722012-04-07 Eli Zaretskii <eliz@gnu.org>
2273
2274 Support building on MS-Windows with libxml2.
2275
2276 * makefile.w32-in (OBJ2): Add xml.$(O).
2277 (GLOBAL_SOURCES): Add xml.c.
2278 ($(BLD)/xml.$(O)): New dependency list.
2279
2280 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2281 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2282 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2283 [!WINDOWSNT]: New macros.
2284 (init_libxml2_functions, libxml2_loaded_p): New functions.
2285 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2286 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2287 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2288 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2289 linked in).
6bbef4e5
JC
2290 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2291 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2292 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2293
2294 * emacs.c: Don't include libxml/parser.h.
2295 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2296 xmlCleanupParser directly.
2297
2298 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2299
3811fdf3
EZ
23002012-04-07 Eli Zaretskii <eliz@gnu.org>
2301
2302 * indent.c (Fvertical_motion): If there is a display string at
2303 point, use it.vpos to compute how many lines to backtrack after
2304 move_it_to point. (Bug#11133)
2305
2f8e16b2
EZ
23062012-04-06 Eli Zaretskii <eliz@gnu.org>
2307
2308 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2309 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2310 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2311 macros related to unification of CJK characters. For the details,
2312 see the discussion following the message here:
2313 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2314
3d439cd1
CY
23152012-04-04 Chong Yidong <cyd@gnu.org>
2316
2317 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2318
8bc53d00
EZ
23192012-04-01 Eli Zaretskii <eliz@gnu.org>
2320
2321 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2322 instead of alloca. (Bug#11138)
2323
3b0512a3
AS
23242012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2325
2326 * w32menu.c (is_simple_dialog): Properly check lisp types.
2327 (Bug#11141)
2328
8427ddd2
EZ
23292012-03-31 Eli Zaretskii <eliz@gnu.org>
2330
979022ef
EZ
2331 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2332 position we get to after a call to move_it_to fails the
2333 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2334 only if we wind up in a string from display property. (Bug#11063)
2335
a6b1c7cc
EZ
2336 * window.c (Fdelete_other_windows_internal): Invalidate the row
2337 and column information about mouse highlight, so that redisplay
2338 restores it after reallocating the glyph matrices. (Bug#7464)
2339
8427ddd2
EZ
2340 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2341 string comes from a `display' text property, use the buffer
2342 position of that property as if we actually saw that position in
2343 the row's glyphs.
697ba24b
EZ
2344 (move_it_by_lines): Remove the assertion that
2345 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2346 violated when there's a before-string at the beginning of a line.
2347 (Bug#11063)
8427ddd2 2348
65a0a738
EZ
23492012-03-30 Eli Zaretskii <eliz@gnu.org>
2350
2351 * xdisp.c (append_space_for_newline): If the default face was
2352 remapped, use the remapped face for the appended newline.
2353 (extend_face_to_end_of_line): Use the remapped default face for
2354 extending the face to the end of the line.
2355 (display_line): Call extend_face_to_end_of_line when the default
2356 face was remapped. (Bug#11068)
2357
581355cc
EZ
23582012-03-29 Eli Zaretskii <eliz@gnu.org>
2359
2360 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2361
e8fc049f
SM
23622012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2363
2364 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2365
4fb9a543
GM
23662012-03-27 Glenn Morris <rgm@gnu.org>
2367
2368 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2369 Doc fixes.
2370
679910f1
KH
23712012-03-26 Kenichi Handa <handa@m17n.org>
2372
2373 * dispextern.h (struct glyph): Fix previous change. Change the
2374 bit length of glyphless.ch to 25 (Bug#11082).
2375
90d49b7f
CY
23762012-03-26 Chong Yidong <cyd@gnu.org>
2377
2378 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2379 (command_loop_1): Use it; inhibit selection update for
2380 handle-select-window too (Bug#8996).
2381
f514f6f0
FP
23822012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2383
e8fc049f 2384 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2385
bf43fa51
KH
23862012-03-25 Kenichi Handa <handa@m17n.org>
2387
2388 * dispextern.h (struct glyph): Change the bit length of
2389 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2390
8a0c01dd
EZ
23912012-03-24 Eli Zaretskii <eliz@gnu.org>
2392
2393 * s/ms-w32.h (tzname): Include time.h before redirecting to
2394 _tzname. Fixes the MSVC build. (Bug#9960)
2395
7d1c3a76
AS
23962012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2397
8ed79523
AS
2398 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2399 characters.
2400
7d1c3a76
AS
2401 * xterm.c (XTread_socket): Only modify handling_signal if
2402 !SYNC_INPUT. (Bug#11080)
2403
e99a9b8b
EZ
24042012-03-23 Eli Zaretskii <eliz@gnu.org>
2405
2406 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2407 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2408 when fetching a multibyte character consumes more bytes than
2409 CHAR_BYTES returns, due to unification of CJK characters in
2410 string_char. (Bug#11073)
2411
5063c0e1
TN
24122012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2413
2414 * process.c (wait_reading_process_output): Handle pty disconnect
2415 by refraining from sending oneself a SIGCHLD (bug#10933).
2416
9f851fbd
CY
24172012-03-22 Chong Yidong <cyd@gnu.org>
2418
2419 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2420
5063c0e1 2421 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2422 Mark string as coming from a prefix property.
2423 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2424 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2425
fb5b8aca
CY
24262012-03-21 Chong Yidong <cyd@gnu.org>
2427
2428 * xfaces.c (Vface_remapping_alist): Doc fix.
2429
62356a1b
EZ
24302012-03-20 Eli Zaretskii <eliz@gnu.org>
2431
2432 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2433 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2434 Doc fixes.
62356a1b 2435
025de85b
CY
24362012-03-20 Chong Yidong <cyd@gnu.org>
2437
2438 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2439 to reflect default non-nil value of redisplay-dont-pause.
2440
4827f94e
KH
24412012-03-19 Kenichi Handa <handa@m17n.org>
2442
2443 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2444 it fit in a valid range (Bug#11003).
2445
e50a24a2
EZ
24462012-03-18 Eli Zaretskii <eliz@gnu.org>
2447
2448 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2449 that is not from display property, accept the row as a "cursor
2450 row" if one of the string's character has a non-nil `cursor'
2451 property. Fixes cursor positioning when there are newlines in
2452 overlay strings, e.g. in icomplete.el. (Bug#11035)
2453
9af5ed87
PE
24542012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2455
2456 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2457
d1f55f16
CY
24582012-03-12 Chong Yidong <cyd@gnu.org>
2459
2460 * eval.c (inhibit_lisp_code): Rename from
2461 inhibit_window_configuration_change_hook; move from window.c.
2462
2463 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2464 * window.c (run_window_configuration_change_hook)
2465 (syms_of_window): Callers changed.
2466
66c5eebd
CY
24672012-03-11 Chong Yidong <cyd@gnu.org>
2468
413df973
CY
2469 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2470
66c5eebd
CY
2471 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2472
1de11f56
CY
24732012-03-10 Chong Yidong <cyd@gnu.org>
2474
2475 * frame.c (other_visible_frames): Don't assume the selected frame
2476 is visible (Bug#10955).
2477
cae07000
SM
24782012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2479
2480 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2481
89c94350
JD
24822012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2483
2484 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2485 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2486 zero (Bug#10954).
2487
999dd333
GM
24882012-03-03 Glenn Morris <rgm@gnu.org>
2489
01a6dcc8 2490 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2491
de0100f2
EZ
24922012-03-02 Eli Zaretskii <eliz@gnu.org>
2493
2494 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2495 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2496 (redisplay_window, next_element_from_string): Fix typos in
2497 comments.
3e441275
EZ
2498 (redisplay_window): Pass to move_it_vertically the margin in
2499 pixels, not in screen lines.
de0100f2 2500
96a72ee9
GM
25012012-03-02 Glenn Morris <rgm@gnu.org>
2502
2503 * buffer.c (buffer-list-update-hook): Doc fix.
2504
312508d7
EZ
25052012-02-29 Eli Zaretskii <eliz@gnu.org>
2506
2507 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2508 push_it before setting up the iterator for the first overlay
2509 string, even if we have an empty string loaded.
2510 (next_overlay_string): If there's an empty string on the iterator
2511 stack, pop the stack. (Bug#10903)
2512
27f3c637
PE
25132012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2514
2515 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2516 Suggested by Stefan Monnier in
2517 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2518 * alloc.c (widen_to_Lisp_Object): New static function.
2519 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2520 and widening them to Lisp_Objects. This would work even if
2521 USE_LSB_TAG is defined and wide integers are used, which might
2522 happen in a future version of Emacs.
2523
3c9dfce6
CY
25242012-02-25 Chong Yidong <cyd@gnu.org>
2525
fa74b241
CY
2526 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2527 Doc fix.
2528
3c9dfce6
CY
2529 * xselect.c (Fx_selection_exists_p): Doc fix.
2530 (x_clipboard_manager_save_all): Print an informative message
2531 before saving to clipboard manager.
2532
9486df08
CY
25332012-02-24 Chong Yidong <cyd@gnu.org>
2534
2535 * keyboard.c (process_special_events): Handle all X selection
2536 requests in kbd_buffer, not just the next one (Bug#8869).
2537
f01d3321
CY
25382012-02-23 Chong Yidong <cyd@gnu.org>
2539
2540 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2541 call when setting menu-bar-lines and tool-bar-lines parameters.
2542 (unwind_create_frame_1): New helper function.
2543
2544 * window.c (inhibit_window_configuration_change_hook): New var.
2545 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2546 (syms_of_window): Initialize it.
f01d3321 2547
86b847b6
CY
25482012-02-22 Chong Yidong <cyd@gnu.org>
2549
2550 * xterm.c (x_draw_image_relief): Add missing type check for
2551 Vtool_bar_button_margin (Bug#10743).
2552
a59225b1
CY
25532012-02-21 Chong Yidong <cyd@gnu.org>
2554
2555 * fileio.c (Vfile_name_handler_alist): Doc fix.
2556
2557 * buffer.c (Fget_file_buffer): Protect against invalid file
2558 handler return value.
2559
310f5bd4
PE
25602012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2561
cb3a28cc
PE
2562 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2563 when computing $valmask.
2564
310f5bd4
PE
2565 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2566 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2567 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2568 It's useless in that case, and it can cause problems on hosts
2569 that allocate halves of EMACS_INT values separately.
2570 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2571 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2572 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2573 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2574 it avoids undefined behavior on hosts where shifting right by more
2575 than the word width has undefined behavior.
2576
2375c96a
CY
25772012-02-19 Chong Yidong <cyd@gnu.org>
2578
2579 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2580 (Funhandled_file_name_directory, Ffile_name_as_directory)
2581 (Fdirectory_file_name, Fexpand_file_name)
2582 (Fsubstitute_in_file_name): Protect against invalid file handler
2583 return values (Bug#10845).
2584
3eb49e71
EZ
25852012-02-18 Eli Zaretskii <eliz@gnu.org>
2586
2587 * .gdbinit (pitx): Fix incorrect references to fields of the
2588 iterator stack.
2589
7b926f3f
CY
25902012-02-17 Chong Yidong <cyd@gnu.org>
2591
2592 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2593
11273115
PE
25942012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2597 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2598
c3a70e2b
CY
25992012-02-15 Chong Yidong <cyd@gnu.org>
2600
2601 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2602 marked as special. Also, starting docstrings with * is obsolete.
2603
0ca43699
AS
26042012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2605
2606 * gnutls.c (emacs_gnutls_write): Fix last change.
2607
2e8f3c56
LI
26082012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2609
2610 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2611 send_process.
2612
af70074f
SM
26132012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2614
2615 * keymap.c (Fsingle_key_description): Handle char ranges.
2616
95986d52
CY
26172012-02-12 Chong Yidong <cyd@gnu.org>
2618
afd83bd1
CY
2619 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2620 as that creates a dangerous corner case.
2621
95986d52
CY
2622 * window.c (Fdelete_window_internal): Invalidate the mouse
2623 highlight (Bug#9904).
2624
bd7da63e
GM
26252012-02-12 Glenn Morris <rgm@gnu.org>
2626
2627 * xselect.c (Fx_own_selection_internal)
2628 (Fx_get_selection_internal, Fx_disown_selection_internal)
2629 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2630 * nsselect.m (Fx_own_selection_internal)
2631 (Fx_disown_selection_internal, Fx_selection_exists_p)
2632 (Fx_selection_owner_p, Fx_get_selection_internal):
2633 Sync docs and argument specs with the xselect.c versions.
2634
77abcbc2
LI
26352012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2636
2637 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2638
90b671e2
EZ
26392012-02-11 Eli Zaretskii <eliz@gnu.org>
2640
1c0ca0b7
EZ
2641 * w32select.c (Fx_selection_exists_p): Sync doc string and
2642 argument list with xselect.c. (Bug#10783)
2643
2644 * w16select.c (Fx_selection_exists_p): Sync doc string and
2645 argument list with xselect.c. (Bug#10783)
90b671e2 2646
49241268
GM
26472012-02-10 Glenn Morris <rgm@gnu.org>
2648
2649 * fns.c (Fsecure_hash): Doc fix.
2650
f998bbe7 26512012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2652
2653 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2654
0992bd9c
CY
26552012-02-07 Chong Yidong <cyd@gnu.org>
2656
2657 * buffer.c (Fbuffer_local_variables)
2658 (buffer_lisp_local_variables): Handle unbound vars correctly;
2659 don't let Qunbound leak into Lisp.
2660
af008560
GM
26612012-02-07 Glenn Morris <rgm@gnu.org>
2662
dd605cc4
GM
2663 * image.c (Fimagemagick_types): Doc fix.
2664
af008560
GM
2665 * image.c (imagemagick-render-type): Change it from a lisp object
2666 to an integer. Move the doc here from the lisp manual.
2667 Treat all values not equal to 0 the same.
2668
1449fa1d
CY
26692012-02-06 Chong Yidong <cyd@gnu.org>
2670
2671 * doc.c (store_function_docstring): Avoid applying docstring of
2672 alias to base function (Bug#2603).
2673
3723ec07
AS
26742012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2675
2676 * .gdbinit (pp1, pv1): Remove redundant defines.
2677 (pr): Use pp.
2678
79c1cc1e
CY
26792012-02-04 Chong Yidong <cyd@gnu.org>
2680
2681 * nsterm.m: Declare a global (Bug#10694).
2682
d7f29f8e
EZ
26832012-02-04 Eli Zaretskii <eliz@gnu.org>
2684
cae07000
SM
2685 * w32.c (get_emacs_configuration_options):
2686 Include --enable-checking, if specified, in the return value.
d7f29f8e 2687
3b95a6f9
MR
26882012-02-04 Martin Rudalics <rudalics@gmx.at>
2689
2690 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2691 after rounding frame sizes. (Bug#9723)
2692
d6fa96a6
EZ
26932012-02-04 Eli Zaretskii <eliz@gnu.org>
2694
2695 * keyboard.c (adjust_point_for_property): Don't position point
2696 before BEGV. (Bug#10696)
2697
df0b2940
PE
26982012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2699
2700 Handle overflow when computing char display width (Bug#9496).
2701 * character.c (char_width): Return EMACS_INT, not int.
2702 (char_width, c_string_width): Check for overflow when
2703 computing the width; this is possible now that individual
2704 characters can have unbounded width. Problem introduced
2705 by merge from Emacs 23 on 2012-01-19.
2706
6bee44d6
MA
27072012-02-02 Michael Albinus <michael.albinus@gmx.de>
2708
2709 * dbusbind.c (Fdbus_register_method): Mention the return value
2710 :ignore in the docstring.
2711
44f92739
GM
27122012-02-02 Glenn Morris <rgm@gnu.org>
2713
1b9f60cc
GM
2714 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2715
44f92739
GM
2716 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2717 Unconditionally set to t. (Bug#10673)
2718 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2719 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2720 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2721
c5d3843c
KH
27222012-02-02 Kenichi Handa <handa@m17n.org>
2723
2724 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2725 0, do not call append_composite_glyph.
2726
159462d4 27272012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2728
2729 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2730 NULL (Bug#6988).
2731 (x_produce_glyphs): If the component of a composition is a null
2732 string, set it->pixel_width to 1 to avoid zero-width glyph.
2733
78cef877
EZ
27342012-02-01 Eli Zaretskii <eliz@gnu.org>
2735
2736 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2737 first 2 arguments are identical. This makes inserting large
2738 output from a subprocess an order of magnitude faster on
2739 MS-Windows, where all sbrk'ed memory is always contiguous.
2740
97897668
GM
27412012-01-31 Glenn Morris <rgm@gnu.org>
2742
2743 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2744 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2745 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2746
31fd3586
GM
27472012-01-29 Glenn Morris <rgm@gnu.org>
2748
2749 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2750
0e24a8b2
CY
27512012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2752
2753 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2754
cc0adcb0
CY
27552012-01-28 Chong Yidong <cyd@gnu.org>
2756
2757 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2758
acc28cb9
CY
27592012-01-26 Chong Yidong <cyd@gnu.org>
2760
9c69cfb7
CY
2761 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2762
acc28cb9
CY
2763 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2764 repeat counts (Bug#10507).
2765
48da7392
GM
27662012-01-26 Glenn Morris <rgm@gnu.org>
2767
2768 * lread.c (syms_of_lread): Doc fix.
2769
14af5f7f
CY
27702012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2771
2772 * coding.c (encode_designation_at_bol): Change return value to
2773 EMACS_INT.
2774
0b21c100
CY
27752012-01-25 Chong Yidong <cyd@gnu.org>
2776
2777 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2778
3c2907f7
CY
27792012-01-21 Chong Yidong <cyd@gnu.org>
2780
2781 * floatfns.c (Fcopysign): Make the second argument non-optional,
2782 since nil is not allowed anyway.
2783
959ad23f
AS
27842012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2785
2786 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2787 (send_process): Likewise.
2788
34a02f46
MR
27892012-01-19 Martin Rudalics <rudalics@gmx.at>
2790
2791 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2792 (Vwindow_persistent_parameters): Do not use Qstate.
2793 Rewrite doc-strings.
34a02f46 2794
1259009a 27952012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2796
2797 * character.c (char_width): New function.
70d4fdf6
GM
2798 (Fchar_width, c_string_width, lisp_string_width):
2799 Use char_width (Bug#9496).
25ed9e61 2800
6a6ee00d
MR
28012012-01-16 Martin Rudalics <rudalics@gmx.at>
2802
2803 * window.c (Vwindow_persistent_parameters): New variable.
2804 (Fset_window_configuration, save_window_save): Handle persistent
2805 window parameters.
2806
c85efaf7
EZ
28072012-01-14 Eli Zaretskii <eliz@gnu.org>
2808
2809 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2810 thrashing the stack of the thread. (Bug#9087)
2811
5944709e
PE
28122012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2813
2814 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2815
e71f5d99
EZ
28162012-01-11 Eli Zaretskii <eliz@gnu.org>
2817
2818 * xdisp.c (rows_from_pos_range): Handle the case where the
2819 highlight ends on a newline. (Bug#10464)
2820 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2821 he end column for display of highlight that ends on a newline
2822 before a R2L line.
2823
ce316182
GM
28242012-01-11 Glenn Morris <rgm@gnu.org>
2825
2826 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2827 from load-path also when installation-directory is nil. (Bug#10208)
2828
5b43da69
GM
28292012-01-10 Glenn Morris <rgm@gnu.org>
2830
74cc8ff9
GM
2831 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2832
7d8d6e4e
GM
2833 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2834 Update template values to be closer to their typical values these days.
5b43da69 2835
a0db8d43
EZ
28362012-01-09 Eli Zaretskii <eliz@gnu.org>
2837
2838 * xdisp.c (rows_from_pos_range): Accept additional argument
2839 DISP_STRING, and accept any glyph in a row whose object is that
2840 string as eligible for mouse highlight. Fixes mouse highlight of
2841 display strings from overlays. (Bug#10464)
2842
9a0115ab 28432012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2844
b9110d6a 2845 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2846 * fileio.c (auto_saving_dir_umask): New static var.
2847 (Fmake_directory_internal): Use it.
2848 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2849 creating the directory. The old code temporarily assigns
2850 too-generous permissions to the directory.
2851 (do_auto_save_eh): Clear it.
b9110d6a 2852 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2853 that the var is always cleared.
2854
6c1bd3f3
EZ
28552012-01-07 Eli Zaretskii <eliz@gnu.org>
2856
2857 * search.c (scan_buffer): Pass character positions to
2858 know_region_cache, not byte positions. (Bug#6540)
2859
069d2b50
L
28602012-01-07 LynX <_LynX@bk.ru> (tiny change)
2861
2862 * w32.c (sys_rename): Report EXDEV when rename of a directory
2863 fails because the target is on another logical disk. (Bug#10284)
2864
75bf0d33
DB
28652012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2866
2867 * xterm.c (x_embed_request_focus): New function.
2868
2869 * xterm.h: Add prototype.
2870
2871 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2872
1c6e5a32
GM
28732012-01-05 Glenn Morris <rgm@gnu.org>
2874
2875 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2876
651e947e
EZ
28772012-01-01 Eli Zaretskii <eliz@gnu.org>
2878
2879 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2880 Load gnutls_transport_set_lowat only if GnuTLS version is below
2881 2.11.1.
2882 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2883 GnuTLS versions below 2.11.1.
2884
3778cdd8
AL
28852011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2886
2887 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2888 to the doc string advising against its use for altering the way
2889 windows are scrolled.
2890
0e5317f7
KH
28912011-12-28 Kenichi Handa <handa@m17n.org>
2892
2893 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2894 coding-system ASCII compatible only when it does not produce BOM
2895 on encoding (Bug#10383).
2896
93d5ca1f
JD
28972011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2898
2899 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2900 can scroll.
2901 (create_and_show_popup_menu): Always use menu_position_func for
2902 Gtk3 (Bug#10361).
2903
ca22b785
AS
29042011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2905
2906 * callint.c (Fcall_interactively): Don't truncate prompt string.
2907
d048e1e6
EZ
29082011-12-23 Eli Zaretskii <eliz@gnu.org>
2909
2910 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2911 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2912 resumed from there (after widening). (Bug#10360)
d048e1e6 2913
5ccaba1f
JD
29142011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2915
2916 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2917
204ee57f
JD
29182011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2919
b81d40f0
JB
2920 * nsterm.m (x_free_frame_resources):
2921 Release f->output_data.ns->miniimage.
204ee57f
JD
2922 (ns_index_color): Fix indentation. Do not retain
2923 color_table->colors[i].
2924
2925 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2926 before returning.
2927
2928 * nsfns.m (x_set_background_color): Assign return value from
2929 ns_index_color to face-background instead of NSColor*.
2930 (ns_implicitly_set_icon_type): Fix indentation.
2931 Change assignment in for loop to comparison.
2932
2933 * emacs.c (ns_pool): New variable.
2934 (main): Assign ns_pool.
2935 (Fkill_emacs): Call ns_release_autorelease_pool.
2936
2937 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2938 autorelease fdesc, release fdAttrs and tdict.
2939 (ns_get_covering_families): Release charset.
2940 (ns_findfonts): Release NSFontDescriptor created with new.
2941 (ns_uni_to_glyphs): Fix indentation.
2942 (setString): Release attrStr before assigning new value.
2943
c803b2b7
JD
29442011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2945
678f4426
JD
2946 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2947 and NS_IMPL_COCOA.
2948 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2949 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2950
cd394be1 29512011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2952
5fecd5fc
JD
2953 * nsterm.m (ns_term_init): Subscribe for notifications
2954 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2955 to method trackingNotification in EmacsMenu.
2956
2957 * nsmenu.m (trackingMenu): New variable.
3771cb17 2958 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2959 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2960 from Aquamacs (Bug#7030).
678f4426
JD
2961
29622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2963
c803b2b7
JD
2964 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2965 (symbol_to_nsstring): Fix indentation.
2966 (ns_symbol_to_pb): New function.
cae07000
SM
2967 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2968 (Fns_rotate_cut_buffers_internal): Remove.
2969 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2970 Fns_store_cut_buffer_internal.
2971 (ns_get_foreign_selection, Fx_own_selection_internal)
2972 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2973 (Fns_get_selection_internal, Fns_store_selection_internal):
2974 Use ns_symbol_to_pb and check if return value is nil.
2975 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2976 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2977 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2978 renamed to Sns_store_selection_internal.
2979 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2980 and remove this function.
2981 (ns_handle_selection_clear): Remove, never used.
2982 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2983 here.
2984
e1b01a3a
KB
29852011-12-17 Ken Brown <kbrown@cornell.edu>
2986
2987 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2988 GID is unknown (Bug#10257).
2989
2adb6e85
PE
29902011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2993 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2994 which caused a build failure on GNU/Linux IA-64. This problem was
2995 introduced by my 2011-10-07 patch.
2996
d1d7b339
JL
29972011-12-15 Juri Linkov <juri@jurta.org>
2998
2999 * image.c (imagemagick_error): New function. (Bug#10112)
3000 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3001 Use `imagemagick_error' where ImageMagick functions return
3002 `MagickFalse'.
3003 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3004 proper order.
3005
100d5755
KH
30062011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3007
3008 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3009 fill background (Bug#8992).
3010
454592a6
MR
30112011-12-13 Martin Rudalics <rudalics@gmx.at>
3012
3013 * window.c (Vwindow_combination_resize)
3014 (Vwindow_combination_limit): Use t instead of non-nil in
3015 doc-strings.
61d4b438
MR
3016 (Vrecenter_redisplay): Add first sentence of doc-string on
3017 separate line.
53524d93 3018 (Frecenter): Fix doc-string typo.
454592a6 3019
3633e3aa
KH
30202011-12-11 Kenichi Handa <handa@m17n.org>
3021
3022 * coding.c (Funencodable_char_position): Pay attention to the
3023 buffer text relocation (Bug#9389).
3024
7b9d523a 30252011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3026
7b9d523a
JD
3027 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3028 gtk_init (Bug#10100).
3029
b73189c6
EZ
30302011-12-10 Eli Zaretskii <eliz@gnu.org>
3031
3032 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3033 IT->string is nil. (Bug#10263)
3034
f7dfe5d6
JD
30352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3036
83faebb4
JD
3037 * nsterm.h (x_free_frame_resources): Declare.
3038
f7dfe5d6
JD
3039 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3040 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3041
3042 * nsterm.h (ns_get_defaults_value): Declare.
3043
3044 * nsterm.m (ns_default): Call ns_get_defaults_value.
3045
7cd4e72c
EZ
30462011-12-09 Eli Zaretskii <eliz@gnu.org>
3047
3048 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3049 (Bug#10170)
3050
b34d7317
YM
30512011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3052
3053 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3054 that where the value of an _OBJC_* symbol points to is in the .bss
3055 section (Bug#10240).
3056
76470ad1
KH
30572011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3058
3059 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3060 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3061
745fff94
KH
30622011-12-08 Kenichi Handa <handa@m17n.org>
3063
3064 * ftfont.c (get_adstyle_property): Fix previous change
3065 (Bug#10233).
3066
6e44397c
JB
30672011-12-07 Juanma Barranquero <lekktu@gmail.com>
3068
3069 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3070 dirs from the default value of EMACSLOADPATH (bug#10208).
3071
7efa6272
GM
30722011-12-07 Glenn Morris <rgm@gnu.org>
3073
3074 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3075 installation and source directories as well. (Bug#10208)
3076
f6fc4d87
CY
30772011-12-06 Chong Yidong <cyd@gnu.org>
3078
3079 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3080
2bf26180
GM
30812011-12-06 Glenn Morris <rgm@gnu.org>
3082
3083 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3084 as an error, not just -1. (Bug#10217)
3085
3a6ad4f0
CY
30862011-12-05 Chong Yidong <cyd@gnu.org>
3087
3088 * keyboard.c (process_special_events): New function.
3089 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3090
75a3b399
PE
30912011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3092
3093 * coding.c (encode_designation_at_bol): Don't use uninitialized
3094 local variable (Bug#9318).
3095
c3c9e25e
KH
30962011-12-05 Kenichi Handa <handa@m17n.org>
3097
3098 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3099 return Qnil (Bug#8046, Bug#10193).
3100
5eb05ea3
KH
31012011-12-05 Kenichi Handa <handa@m17n.org>
3102
3103 * coding.c (encode_designation_at_bol): New args charbuf_end and
3104 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3105 (coding_set_source): Return how many bytes coding->source was
3106 relocated.
3107 (coding_set_destination): Return how many bytes
3108 coding->destination was relocated.
3109 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3110 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3111
31122011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3113
3114 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3115 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3116 macro (Bug#9318).
3117
31182011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3119
3120 The following changes are to fix Bug#9318.
3121
a79703f5 3122 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3123 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3124 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3125 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3126
7dbda6df
JB
31272011-12-05 Juanma Barranquero <lekktu@gmail.com>
3128
3129 * lisp.h (process_quit_flag): Fix external declaration.
3130
6d5eb5b0
SM
31312011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3132
3133 Don't macro-inline non-performance-critical code.
3134 * eval.c (process_quit_flag): New function.
3135 * lisp.h (QUIT): Use it.
3136
a0c3fad0
JD
31372011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3138
3139 * nsfns.m (get_geometry_from_preferences): New function.
3140 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3141
6c07aac2
AS
31422011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3143
3144 * emacs.c (Qkill_emacs): Define.
3145 (syms_of_emacs): Initialize it.
3146 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3147 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3148 (quit_throw_to_read_char): Add parameter `from_signal'.
3149 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3150 * lisp.h (QUIT): Call Fkill_emacs if requested.
3151
c052ead4
JD
31522011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3153
3154 * widget.c (update_wm_hints): Return if wmshell is null.
3155 (widget_update_wm_size_hints): New function.
3156
3157 * widget.h (widget_update_wm_size_hints): Declare.
3158
3159 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3160 widget_update_wm_size_hints (Bug#10104).
3161
9e49252b
EZ
31622011-12-03 Eli Zaretskii <eliz@gnu.org>
3163
3164 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3165 before a newline, prepare the bidi iterator for consuming the
3166 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3167 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3168
02b16839
JL
31692011-12-02 Juri Linkov <juri@jurta.org>
3170
3171 * search.c (Fword_search_regexp): New Lisp function created from
3172 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3173 (Fword_search_backward, Fword_search_forward)
3174 (Fword_search_backward_lax, Fword_search_forward_lax):
3175 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3176 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3177
0068070e
SM
31782011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3179
3180 * fileio.c (Finsert_file_contents): Move after-change-function call
3181 to before the "handled:" label, since all "goto handled" appear in
3182 cases where the *-change-functions have already been properly called
3183 (bug#10117).
3184
3360a3fc
AS
31852011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3186
3187 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3188 waiting for input. (Bug#10169)
3189
73d6c093
EZ
31902011-11-30 Eli Zaretskii <eliz@gnu.org>
3191
3192 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3193 verifies glyph row's hash code--we have just reallocated the
3194 glyphs, so their contents can be complete garbage. (Bug#10164)
3195
febe6bea
JB
31962011-11-30 Juanma Barranquero <lekktu@gmail.com>
3197
3198 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3199
801a4313
EZ
32002011-11-30 Eli Zaretskii <eliz@gnu.org>
3201
3202 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3203 attributes are tested _before_ calling verify_row_hash, to protect
3204 against GCC re-ordering of the tests. (Bug#10164)
3205
2b56b87e
JD
32062011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3207
3208 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3209
3210 * xterm.c (handle_one_xevent): Only set async_visible and friends
3211 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3212 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3213 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3214
dbf31225
PE
32152011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3218 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3219 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3220 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3221 All uses changed to use GCPRO1 etc.
3222 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3223 Revert to old implementation (i.e., before 2011-03-11).
3224
1305621b
YM
32252011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3226
3227 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3228 of scroll runs so as to avoid assigning disabled bogus rows and
3229 unnecessary graphics copy operations.
3230
8c9afb46
EZ
32312011-11-27 Eli Zaretskii <eliz@gnu.org>
3232
3233 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3234 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3235 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3236 (malloc, free, realloc, calloc): Redirect to e_* only when
3237 compiling Emacs.
3238
3239 * lisp.h (GCTYPEBITS): Move before first use.
3240 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3241 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3242 this macro definition.
3243
3244 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3245 _MSC_VER.
3246
54e9e3bf
JD
32472011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3248
6d5eb5b0
SM
3249 * gtkutil.c (xg_create_frame_widgets):
3250 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3251 present with Gtk+ 2.0.
3252
83aca1cb
PE
32532011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3254
3255 * fileio.c (Finsert_file_contents): Undo previous change; see
3256 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3257
5b76caa4
PE
32582011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3259
3260 Rename locals to avoid shadowing.
3261 * fileio.c (Finsert_file_contents):
3262 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3263 * process.c (wait_reading_process_output):
3264 Rename inner 'proc' to 'p' to avoid shadowing.
3265 Indent for consistency with usual Emacs style.
3266
8c535114
EZ
32672011-11-25 Eli Zaretskii <eliz@gnu.org>
3268
3269 * xdisp.c (redisplay_window): If cursor row is not fully visible
3270 after recentering, and scroll-conservatively is set to a large
3271 number, scroll window by a few more lines to make the cursor fully
3272 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3273 (start_display): Don't move to the next line if the display should
3274 start at a newline that is part of a display vector or an overlay
3275 string. (Bug#10119)
8c535114 3276
fa4fdb5c
JL
32772011-11-24 Juri Linkov <juri@jurta.org>
3278
3279 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3280 after the `MagickPingImage' call. (Bug#10112)
3281
90ec88df
CY
32822011-11-23 Chong Yidong <cyd@gnu.org>
3283
3284 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3285
56e2e794
MR
32862011-11-23 Martin Rudalics <rudalics@gmx.at>
3287
3288 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3289 making another buffer current. (Bug#10114)
3290
b6e64c41
GM
32912011-11-23 Glenn Morris <rgm@gnu.org>
3292
3293 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3294
6b21de18
CY
32952011-11-23 Chong Yidong <cyd@gnu.org>
3296
3297 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3298 using it (Bug#5984).
3299
b12cd789
EZ
33002011-11-22 Eli Zaretskii <eliz@gnu.org>
3301
3302 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3303 and header-lines, as they don't have one computed for them.
3304 (Bug#10098)
3305
3306 * .gdbinit (prow): Make displayed values more self-explaining.
3307 Add row's hash code.
3308
261b6fd4
LMI
33092011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3310
3311 * process.c (wait_reading_process_output): Fix asynchrounous
3312 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3313 (wait_reading_process_output): Add comment and URL.
261b6fd4 3314
e7cfd277
JD
33152011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3316
3317 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3318
a9b9b7f5
CY
33192011-11-21 Chong Yidong <cyd@gnu.org>
3320
3321 * window.c (Fnext_window, Fprevious_window): Doc fix.
3322
b0d15b4f
SM
33232011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3324
3325 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3326
fe7a3057
JB
33272011-11-20 Juanma Barranquero <lekktu@gmail.com>
3328
3329 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3330
d2999b1a
MR
33312011-11-20 Martin Rudalics <rudalics@gmx.at>
3332
3333 * window.c (Fset_window_combination_limit): Rename argument
3334 STATUS to LIMIT.
3335 (Vwindow_combination_limit): Remove "status" from doc-string.
3336
d5ff9cd0
AS
33372011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3338
3339 * m/ibms390.h: Remove.
3340 * m/ibms390x.h: Don't include "ibms390.h".
3341
a5bb9bd3
SM
33422011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3343
3344 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3345 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3346
cd1181db
JB
33472011-11-20 Juanma Barranquero <lekktu@gmail.com>
3348
3349 * casetab.c (Fset_case_table):
3350 * charset.c (Fcharset_after): Fix typos.
3351
615a3b8d 33522011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3353
17e845af
PE
3354 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3355 Otherwise, valgrind does not work on some platforms.
3356 Problem reported by Andreas Schwab in
6a0bf43d
PE
3357 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3358 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3359 is set, removing the need for VIRT_ADDRESS_VARIES.
3360 (PURE_P): Use a more-efficient implementation that needs just one
3361 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3362 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3363 to 4 (xorl, subq, cmpq, setbe).
3364 * alloc.c (pure): Always extern now, since that's the
3365 VIRT_ADDR_VARIES behavior.
3366 (PURE_POINTER_P): Use a single comparison, not two, for
3367 consistency with the new puresize.h.
3368 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3369 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3370 Remove VIRT_ADDR_VARIES no longer needed.
3371
f8fe6f96
EZ
33722011-11-19 Eli Zaretskii <eliz@gnu.org>
3373
3374 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3375 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3376 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3377 behave as if the cursor position were at the window margin.
3378
3379 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3380 and the cursor position is out of bounds, behave as if the cursor
3381 position were at the window margin. (Bug#10075)
3382
df05a53c
CY
33832011-11-18 Chong Yidong <cyd@gnu.org>
3384
3385 * window.c (Fwindow_combination_limit): Make first argument
3386 non-optional, since it is meaningless for live windows like the
3387 selected window.
61ccba97 3388
2071918e
DA
33892011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3390
3391 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3392
b50a28de
SM
33932011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3394
3395 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3396 (graft_intervals_into_buffer): Simplify.
3397
015137db
EZ
33982011-11-18 Eli Zaretskii <eliz@gnu.org>
3399
3400 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3401 hash values of the two rows.
3402 (copy_row_except_pointers): Preserve the used[] arrays and the
3403 hash values of the two rows. (Bug#10035)
68c95424 3404 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3405
3406 * xdisp.c (row_hash): New function, body extracted from
3407 compute_line_metrics.
3408 (compute_line_metrics): Call row_hash, instead of computing the
3409 hash code inline.
3410
3411 * dispnew.c (verify_row_hash): Call row_hash for computing the
3412 hash code of a row, instead of duplicating code from xdisp.c.
3413
3414 * dispextern.h (row_hash): Add prototype.
3415
a2addb04
TH
34162011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3417
3418 * frame.c (delete_frame): Don't delete the terminal when the last
3419 X frame is closed if emacs is built with GTK toolkit.
3420
df85d315
JB
34212011-11-17 Juanma Barranquero <lekktu@gmail.com>
3422
3423 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3424
a0c2d0ae
MR
34252011-11-17 Martin Rudalics <rudalics@gmx.at>
3426
3427 * window.c (Vwindow_splits): Rename to
3428 Vwindow_combination_resize. Suggested by Juri Linkov.
3429 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3430 of Vwindow_splits.
3431
58179cce
JB
34322011-11-16 Juanma Barranquero <lekktu@gmail.com>
3433
7877f373
JB
3434 * nsfns.m (Fns_font_name):
3435 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3436
b6f67890
MR
34372011-11-16 Martin Rudalics <rudalics@gmx.at>
3438
3439 * window.h (window): Rename slot "nest" to "combination_limit".
3440 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3441 (Fset_window_nest): Rename to Fset_window_combination_limit.
3442 (Vwindow_nest): Rename to Vwindow_combination_limit.
3443 (recombine_windows, make_parent_window, make_window)
3444 (Fsplit_window_internal, saved_window)
3445 (Fset_window_configuration, save_window_save): Rename all
3446 occurrences of window_nest to window_combination_limit.
3447
c7015153
JB
34482011-11-15 Juanma Barranquero <lekktu@gmail.com>
3449
3450 * image.c (imagemagick_load_image): Fix typo.
3451
322ad6ec
EZ
34522011-11-14 Eli Zaretskii <eliz@gnu.org>
3453
3454 * xdisp.c (display_line): Move the call to
3455 highlight_trailing_whitespace before the call to
3456 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3457 faces of all the glyphs to compute ROW's hash value.
3458 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3459
f067b8ec
JB
34602011-11-14 Juanma Barranquero <lekktu@gmail.com>
3461
3462 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3463 just return (bug#10044).
3464
1e5b2111
EZ
34652011-11-12 Eli Zaretskii <eliz@gnu.org>
3466
7ef3cbd5
EZ
3467 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3468 with user-defined heap size. Bump the default size of the temacs
3469 heap to 27MB, to avoid memory warning when running temacs.
3470 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3471
1e5b2111
EZ
3472 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3473 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3474 (verify_row_hash) [XASSERTS]: New function.
3475 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3476 that the hash value of glyph rows is correct.
1e5b2111 3477
89d61221
MR
34782011-11-12 Martin Rudalics <rudalics@gmx.at>
3479
3480 * window.h (window): Remove splits slot.
3481 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3482 (Fdelete_other_windows_internal, make_parent_window)
3483 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3484 (Fset_window_configuration, save_window_save): Don't deal with
3485 split status of windows.
3486 (saved_window): Remove splits slot.
3487 (Vwindow_splits): Rewrite doc-string.
3488
97f18cc8
JD
34892011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3490
3491 * xfns.c (unwind_create_frame):
3492 * nsfns.m (unwind_create_frame):
3493 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3494 Vframe_list (Bug#9999).
3495
22a648b4
DA
34962011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3497
0b381c7e 3498 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3499
659afede
KH
35002011-11-11 Kenichi Handa <handa@m17n.org>
3501
3502 * callproc.c (Fcall_process): Set the member dst_multibyte of
3503 process_coding.
3504
9ac0394b
KH
35052011-11-11 Johan Bockgård <bojohan@gnu.org>
3506
3507 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3508 avoid a crash (bug#9496).
3509
2fbdc249
CY
35102011-11-09 Chong Yidong <cyd@gnu.org>
3511
3512 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3513 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3514
ac6b1f81
PE
35152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3518
09db192c
PE
35192011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 Avoid some portability problems by eschewing 'extern inline' functions.
3522 The trivial performance wins aren't worth the portability hassles; see
3523 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3524 et seq.
3525 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3526 (window_box_width, window_box_left, window_box_left_offset)
3527 (window_box_right, window_box_right_offset): Undo previous change,
3528 by removing the "extern"s.
3529 * intervals.c (adjust_intervals_for_insertion)
3530 (adjust_intervals_for_deletion): Undo previous change,
3531 making these static again.
3532 (offset_intervals, temp_set_point_both, temp_set_point)
3533 (copy_intervals_to_string): No longer inline.
3534 * xdisp.c (window_text_bottom_y, window_box_width)
3535 (window_box_height, window_box_left_offset)
3536 (window_box_right_offset, window_box_left, window_box_right)
3537 (window_box): No longer inline.
3538
105216ed
CY
35392011-11-08 Chong Yidong <cyd@gnu.org>
3540
3541 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3542 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3543 Signal an error if not a live window.
105216ed
CY
3544 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3545 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3546
ae9e237f
JB
35472011-11-07 Juanma Barranquero <lekktu@gmail.com>
3548
3549 * lisp.h (syms_of_abbrev): Remove declaration.
3550 Reported by CHENG Gao <chenggao@royau.me>.
3551
c7aa8333
EZ
35522011-11-07 Eli Zaretskii <eliz@gnu.org>
3553
3554 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3555 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3556 of temacs in GUI mode.
3557
be7f5545
MR
35582011-11-07 Martin Rudalics <rudalics@gmx.at>
3559
3560 * window.h: Declare delete_all_child_windows instead of
3561 delete_all_subwindows.
3562 * window.c (Fwindow_nest, Fset_window_nest)
3563 (Fset_window_new_total, Fset_window_new_normal)
3564 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3565 (delete_all_subwindows): Rename to delete_all_child_windows.
3566 (Fdelete_other_windows_internal, Fset_window_configuration):
3567 Call delete_all_child_windows instead of delete_all_subwindows.
3568 * frame.c (delete_frame): Call delete_all_child_windows instead
3569 of delete_all_subwindows.
3570
ca78dc43
PE
35712011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3572
3573 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3574 This is also needed for porting to any host where GC_MARK_STACK is
3575 not GC_MAKE_GCPROS_NOOPS.
3576 (which_symbols): Use it.
3577
a0241d01
KH
35782011-11-07 Kenichi Handa <handa@m17n.org>
3579
3580 * coding.c (coding_set_destination): Check coding->src_pos only
3581 when coding->src_object is a buffer (bug#9910).
3582
3583 * process.c (send_process): Set the member src_multibyte of coding
3584 to 0 (bug#9911) when sending a unibyte text.
3585
3586 * callproc.c (Fcall_process): Set the member src_multibyte of
3587 process_coding to 0 (bug#9912).
3588
a64bfdfa 35892011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3590
3591 * xmenu.c (cleanup_widget_value_tree): New function.
3592 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3593 calling free_menubar_widget_value_tree directly (Bug#9830).
3594
cb41b32a
PE
35952011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Fix some portability problems with 'inline'.
3598 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3599 (window_box_width, window_box_left, window_box_left_offset)
3600 (window_box_right, window_box_right_offset): Declare extern.
3601 Otherwise, these inline functions do not conform to C99 and
3602 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3603 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3604 * intervals.c (adjust_intervals_for_insertion)
3605 (adjust_intervals_for_deletion): Now extern, because otherwise the
3606 extern inline functions 'offset_intervals' couldn't refer to it.
3607 (static_offset_intervals): Remove.
3608 (offset_intervals): Rewrite using the old contents of
3609 static_offset_intervals. The old version didn't conform to C99
3610 because an extern inline function contained a reference to an
3611 identifier with static linkage.
3612
b7041366
AS
36132011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3614
3615 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3616 GC.
3617
88a37c4d
EZ
36182011-11-06 Eli Zaretskii <eliz@gnu.org>
3619
3620 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3621 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3622 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3623 return Qleft_to_right.
3624
49745b39
CY
36252011-11-06 Chong Yidong <cyd@gnu.org>
3626
3627 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3628 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3629 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3630 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3631 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3632 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3633 (Fwindow_vscroll): Doc fix.
3634 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3635 argument, since it makes no sense to pass a live window and for
3636 consistency with window-child.
3637
1f05cd82
CS
36382011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3639
3640 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3641 support MSVC.
3642
22610910
JR
36432011-11-05 Jason Rumney <jasonr@gnu.org>
3644
3645 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3646 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3647 fonts (Bug#6029).
3648 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3649 bitwise arithmetic preventing use of unicode-sip and non-truetype
3650 opentype fonts.
3651
a06776b2
EZ
36522011-11-05 Eli Zaretskii <eliz@gnu.org>
3653
3ad924ba
EZ
3654 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3655 "emacs"-only part.
3656
a06776b2
EZ
3657 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3658 initialization code to keep similarity to xfns.c after changes
3659 from 2011-11-05.
3660
c9e7db78
JD
36612011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3662
a97f8f3f
JD
3663 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3664 (unwind_create_frame): New function (Bug#9943).
3665 (Fx_create_frame): Restructure code to be more similar to the one in
3666 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3667 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3668 Move terminal->reference_count++ just before making the frame official
3669 (Bug#9943).
3670
3671 * nsterm.m (x_free_frame_resources): New function.
3672 (x_destroy_window): Move code to x_free_frame_resources.
3673
c9e7db78 3674 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3675 (Fx_create_frame, x_create_tip_frame):
3676 Move terminal->reference_count++ just before making the frame
75f1671a 3677 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3678 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3679
a6fc3b5c
EZ
36802011-11-05 Eli Zaretskii <eliz@gnu.org>
3681
3682 Support MSVC build with newer versions of Visual Studio.
3683 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3684 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3685 nt/gmake.defs.
3686
3687 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3688 which are not supported by MSVC.
3689 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3690 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3691 bitfields.
3692 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3693 types in bitfields.
3694 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3695
3696 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3697
58179cce 36982011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3699
3700 Support MSVC build with newer versions of Visual Studio.
3701 * w32.c: Don't include w32api.h for MSVC.
3702 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3703
3704 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3705 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3706 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3707 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3708 e_* cousins.
3709 (alloca) [_MSC_VER]: Define to _alloca.
3710
3711 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3712
3713 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3714
a58c13ed
EZ
37152011-11-04 Eli Zaretskii <eliz@gnu.org>
3716
3717 * xdisp.c (note_mouse_highlight): If either of
3718 previous/next-single-property-change returns nil, treat that as
3719 the beginning or the end of the buffer. (Bug#9955)
3720
fe0b6370
JD
37212011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3722
a58c13ed 3723 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3724 label is not null (Bug#9951).
3725 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3726 may be NULL.
3727
89bd5ee1
EZ
37282011-11-04 Eli Zaretskii <eliz@gnu.org>
3729
3730 * window.c (Fwindow_body_size): Mention in the doc string that the
3731 return value is in frame's canonical units. (Bug#9949)
3732
84c3edb9
EZ
37332011-11-03 Eli Zaretskii <eliz@gnu.org>
3734
4e2fb5c7
EZ
3735 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3736
84c3edb9 3737 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3738 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3739 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3740
bc17a887
EZ
37412011-11-01 Eli Zaretskii <eliz@gnu.org>
3742
3743 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3744 Don't stop backward scan on the continuation glyph, even though
3745 its CHARPOS is positive.
6d5eb5b0
SM
3746 (mouse_face_from_buffer_pos, note_mouse_highlight):
3747 Rename cover_string to disp_string.
bc17a887 3748
4ee88440
MR
37492011-11-01 Martin Rudalics <rudalics@gmx.at>
3750
3751 * window.c (temp_output_buffer_show): Don't use
3752 Vtemp_buffer_show_specifiers.
3753 (Vtemp_buffer_show_specifiers): Remove unused variable.
3754
c2ff3c02
EZ
37552011-10-30 Eli Zaretskii <eliz@gnu.org>
3756
3757 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3758 past the beginning of the current glyph matrix.
3759
58179cce 37602011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3761
3762 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3763 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3764 HAVE_GTK3 (Bug#9869).
b77a6a7f 3765
3b574623
JD
3766 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3767 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3768
b77a6a7f
JD
3769 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3770
3771 * xterm.c: Declare x_handle_net_wm_state to return int.
3772 (handle_one_xevent): Check if we are iconified but don't have
3773 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3774 (get_current_wm_state): Return non-zero if not hidden,
3775 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3776 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3777 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3778 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3779
196e41e4
PE
37802011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3781
3782 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3783 so that this new function doesn't get optimized away by a
3784 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3785
021f2e1a
AS
37862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3787
3788 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3789
8b058d44
EZ
37902011-10-29 Eli Zaretskii <eliz@gnu.org>
3791
3792 Fix the `xbytecode' command.
3793 * .gdbinit (xprintbytestr): New command.
b50a28de 3794 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3795 (xbytecode): Print the byte-code string as well.
3796
4452fb80
EZ
37972011-10-29 Kim Storm <storm@cua.dk>
3798
8b058d44
EZ
3799 * alloc.c (which_symbols): New function.
3800
21b72067
AS
38012011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3802
3803 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3804 line. (Bug#9903)
3805
83ed7b5c
GM
38062011-10-29 Glenn Morris <rgm@gnu.org>
3807
3808 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3809 Not clear what it was for, and it causes various bugs. (Bug#9839)
3810
5a7a728b
EZ
38112011-10-28 Eli Zaretskii <eliz@gnu.org>
3812
3813 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3814 possible random value that matches one of those tested as
3815 condition to clear the mouse face.
3816
d3d0842f
CY
38172011-10-28 Chong Yidong <cyd@gnu.org>
3818
3819 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3820
31b39d13
DN
38212011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3822
3823 * window.c (make_window): Initialize phys_cursor_on_p.
3824
9aba6043
SM
38252011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3826
3827 * lisp.h (struct Lisp_Symbol): Update comments.
3828
c20992f4
JB
38292011-10-28 Juanma Barranquero <lekktu@gmail.com>
3830
3831 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3832
db4f02f2
EZ
38332011-10-28 Eli Zaretskii <eliz@gnu.org>
3834
3835 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3836 <oslsachem@gmail.com> for helping to debug this.
3837
3838 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3839 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3840 (g_b_init_get_glyph_outline_w): New static variables.
3841 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3842 (GetGlyphOutlineW_Proc): New typedefs.
3843 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3844 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3845 New functions.
3846 (w32font_open_internal, compute_metrics):
3847 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3848 instead of calling the "wide" APIs directly.
3849
3850 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3851
3852 * w32.h (syms_of_w32font): Add prototype.
3853
87e68db4
JB
38542011-10-27 Juanma Barranquero <lekktu@gmail.com>
3855
3856 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3857 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3858 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3859 (Fmove_to_window_line): Doc fix.
3860
435c1d67
CY
38612011-10-27 Chong Yidong <cyd@gnu.org>
3862
3863 * process.c (make_process): Set gnutls_state to NULL.
3864
3865 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3866 non-NULL, regardless of GNUTLS_INITSTAGE.
3867 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3868 an error. Set process slots as soon as we allocate them.
3869
3870 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3871
9c6c6f49
CY
38722011-10-27 Chong Yidong <cyd@gnu.org>
3873
9aba6043
SM
3874 * gnutls.c (emacs_gnutls_deinit): New function.
3875 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3876 (Fgnutls_deinit, Fgnutls_boot): Use it.
3877
3878 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3879 (deactivate_process): Call emacs_gnutls_deinit.
3880
657d08d3
JB
38812011-10-27 Juanma Barranquero <lekktu@gmail.com>
3882
3883 * image.c (x_create_x_image_and_pixmap):
3884 * w32.c (sys_rename, w32_delayed_load):
3885 * w32font.c (fill_in_logfont):
3886 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3887
5430d399
JB
38882011-10-26 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * w32fns.c (w32_default_color_map): New function,
3891 extracted from Fw32_default_color_map.
a7ef684b 3892 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3893
fe0055fa
PE
38942011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3895
3896 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3897
e6346438
SM
38982011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3899
3900 * keyboard.c (test_undefined): New function (bug#9751).
3901 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3902
e112cc37
ET
39032011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3904
3905 * sysdep.c (init_sys_modes): Fix the check for the controlling
3906 terminal (Bug#6649).
3907
7b5d6677
EZ
39082011-10-20 Eli Zaretskii <eliz@gnu.org>
3909
3910 * dispextern.h (struct bidi_it): New member next_en_type.
3911
3912 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3913 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3914 current character, check also for next_en_type being WEAK_EN.
3915 (bidi_resolve_weak): Don't enter the expensive loop if the current
3916 position is before next_en_pos. Record the bidi type of the first
3917 non-ET, non-BN character we find, in addition to its position.
3918 (bidi_level_of_next_char): Invalidate next_en_type when
3919 next_en_pos is over-stepped.
3920
7da0b018
PE
39212011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3924 * editfns.c: Rewrite current-time-zone so that it invokes
3925 the equivalent of (format-time-string "%Z") to get the time zone name.
3926 This fixes a bug when the time zone name contains characters that
3927 need converting from the system time locale to Emacs internal format.
3928 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3929 that patch fixed format-time-string to do the conversion, but
3930 I forgot to fix current-time-zone.
3931 (format_time_string): New function, containing most of
3932 what Fformat_time_string used to contain.
3933 (Fformat_time_string): Rewrite in terms of format_time_string.
3934 This doesn't change this function's behavior.
3935 (current-time-zone): Rewrite to use format_time_string.
3936 This fixes the bug reported by Michael Schierl in
3937 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3938 Jason Rumney's 2007-06-07 change worked around this bug, but
3939 didn't fix it.
3940 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3941
8547b010
EZ
39422011-10-19 Eli Zaretskii <eliz@gnu.org>
3943
3944 * xdisp.c (start_display): If the character at POS is displayed
3945 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3946 (try_window_reusing_current_matrix): If a line ends in a display
3947 vector or the next line starts in a display vector, continue
3948 redrawing the window even though the character position of
3949 start_row was reached.
8547b010
EZ
3950 (Bug#9771, part 2)
3951
4e948d15
CY
39522011-10-18 Chong Yidong <cyd@gnu.org>
3953
3954 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3955 with nobreak-char-display too.
3956
4787455f
EZ
39572011-10-18 Eli Zaretskii <eliz@gnu.org>
3958
3959 Fix part 3 of bug#9771.
3960 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3961 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3962 non-neutral characters if the current character is a paragraph
3963 separator (a.k.a. Newline). This avoids running the same
3964 expensive loop twice, once when we consume the preceding newline
3965 and the other time when the line actually needs to be displayed.
3966 Avoid the loop when we see neutrals on the base embedding level
3967 following a character whose directionality is the same as the
3968 paragraph's. This avoids running the expensive loop when a line
3969 ends in a long sequence of neutrals, like control characters.
3970 Add assertion against STRONG_AL type. Slightly rearrange code
3971 that determines the type of a neutral given the first non-neutral
3972 that follows it.
3973 (bidi_level_of_next_char): Set next_en_pos to zero when
3974 invalidating its info.
3975
2c91f553
EZ
39762011-10-17 Eli Zaretskii <eliz@gnu.org>
3977
3978 * xdisp.c (push_display_prop): Determine whether to record string
3979 or buffer position by IT->string, not by IT->method. Allow
3980 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3981 (move_it_vertically_backward): Don't look for character position
3982 immediately after the newline when in a continuation line.
3983 (Bug#9771, part 1)
2c91f553 3984
c7b08b0d
MR
39852011-10-15 Martin Rudalics <rudalics@gmx.at>
3986
3987 * window.c (coordinates_in_window): Rewrite and delabelize
3988 vertical border check. (Bug#5357) (Bug#9618)
3989
6b02f655
SM
39902011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3991
3992 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3993 errors in XSetWindowBorder (bug#9310).
3994
81d40c92
DA
39952011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3996
3997 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3998 avoid crash when xmalloc overrun checking is enabled.
3999
d4172c3b
EZ
40002011-10-13 Eli Zaretskii <eliz@gnu.org>
4001
4002 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4003 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4004 cursor motion with <left> and <right> arrow keys.
4005
4006 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4007 some callers set that themselves.
4008
b00eea75
EZ
40092011-10-12 Eli Zaretskii <eliz@gnu.org>
4010
4011 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4012 display string and the previous row comes from the same string and
4013 is empty. (Bug#9739) (Bug#9738)
4014
8fe012c4
SM
40152011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4016
4017 * doc.c (get_doc_string): Encode file name (bug#9735).
4018
0074aef2
EZ
40192011-10-12 Eli Zaretskii <eliz@gnu.org>
4020
79beb178
EZ
4021 * bidi.c (bidi_level_of_next_char):
4022 * xdisp.c (get_visually_first_element): Remove old incorrect
4023 comments regarding the Unicode Line Separator character.
4024
0074aef2
EZ
4025 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4026
6e4b3fbe
DA
40272011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4028
4029 * alloc.c (Fgc_status): Do not access beyond zombies array
4030 boundary if nzombies > MAX_ZOMBIES.
4031 * alloc.c (dump_zombies): Add missing format specifier.
4032
0324f3af
PE
40332011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4034
b5525cac
PE
4035 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4036 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4037
0324f3af
PE
4038 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4039 Some packages use them to denote characters with modifiers.
4040
e9b5f888
AS
40412011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4042
4043 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4044 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4045 matching a pp-number. Rename parameter var to var1.
4046
127827c0
SM
40472011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4048
4049 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4050
c8fd3bd0
GM
40512011-10-08 Glenn Morris <rgm@gnu.org>
4052
4053 * callint.c (Fcall_interactively): Give a more explicit error for the
4054 'c' case with a non-character input. (Bug#8479)
4055
352ec8ff
EZ
40562011-10-08 Eli Zaretskii <eliz@gnu.org>
4057
03669ccb
EZ
4058 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4059 lines.
7061c986
EZ
4060 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4061 lines that are hscrolled on the left.
03669ccb 4062
352ec8ff
EZ
4063 * dispnew.c (buffer_posn_from_coords): Account for a possible
4064 presence of header-line. (Bug#4426)
4065
a66cfb1c
SM
40662011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4067
6b02f655
SM
4068 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4069 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4070
7c5ee88e
PE
40712011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4072
4073 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4074 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4075 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4076 this makes Emacs dump core during garbage collection on rare
4077 occasions. sizeof is obviously inferior to offsetof here, so
4078 stick with offsetof.
4079 (GC_POINTER_ALIGNMENT): New macro.
4080 (mark_memory): Omit 3rd (offset) arg; caller changed.
4081 Don't assume EMACS_INT alignment is the same as pointer alignment.
4082
df1bbe5b
SM
40832011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4084
4085 * keyboard.c (read_key_sequence_remapped): New var.
4086 (read_key_sequence): Compute remapping in the right buffer.
4087 (command_loop_1): Use read_key_sequence's remapping directly.
4088
51553db6
SM
40892011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4090
32c1fffd
SM
4091 * dired.c (file_name_completion): Don't expand file name.
4092 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4093 before checking file name handler.
4094
51553db6
SM
4095 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4096 they've been requested explicitly (bug#9591).
4097
b6bd1599 40982011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4099
4100 * keymap.c (Fsingle_key_description): Use make_specified_string
4101 instead of build_string to build string from push_key_description.
4102 (Bug#5193)
4103
f701dc2a
PE
41042011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4105
4222c55d
PE
4106 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4107 This fixes a Y2038 bug on 64-bit hosts.
4108 * buffer.c (reset_buffer):
4109 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4110 (Fclear_buffer_auto_save_failure):
4111 Use 0, not -1, to represent an unset failure time, since time_t
4112 might not be signed.
4113
f701dc2a
PE
4114 Remove dependency on glibc malloc internals.
4115 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4116 Move back here from lisp.h, but with their new implementations.
4117 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4118 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4119 * charset.c (charset_table_init): New static var.
4120 (syms_of_charset): Use it instead of xmalloc. This removes a
4121 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4122 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4123 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4124 Move back to alloc.c.
4125 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4126 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4127
9ceebf39
JD
41282011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4129
4130 * nsterm.m (windowDidResize): Call x_set_window_size only when
4131 ns_in_resize is true. Otherwise set pixelwidth/height and
4132 call change_frame_size (Bug#9628).
4133
cb993c58
PE
41342011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4135
3930c88b
PE
4136 Port --enable-checking=all to Fedora 14 x86-64.
4137 * charset.c (syms_of_charset): Also account for glibc malloc's
4138 internal overhead when calculating the initial malloc maximum.
4139
cb993c58
PE
4140 Port --enable-checking=all to Fedora 14 x86.
4141 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4142 Move to lisp.h.
4143 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4144 (overrun_check_realloc, overrun_check_free):
4145 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4146 That way, xmalloc returns a properly-aligned pointer even if
4147 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4148 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4149 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4150 into account when calculating the initial malloc maximum.
4151 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4152 Move here from alloc.c, so that charset.c can use it too.
4153 Properly align; the old code wasn't right for common 32-bit hosts
4154 when configured with --enable-checking=all.
4155 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4156 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4157
31bed486
EZ
41582011-09-29 Eli Zaretskii <eliz@gnu.org>
4159
04c70788 4160 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4161 use EDOM.
4162
fbcaa2f3
EZ
41632011-09-28 Eli Zaretskii <eliz@gnu.org>
4164
4165 * xdisp.c (compute_display_string_end): If there's no display
4166 string at CHARPOS, return -1.
4167
4168 * bidi.c (bidi_fetch_char): When compute_display_string_end
4169 returns a negative value, treat the character as a normal
4170 character not covered by a display string. (Bug#9624)
4171
a239d4e9
JB
41722011-09-28 Juanma Barranquero <lekktu@gmail.com>
4173
4174 * lread.c (Fread_from_string): Fix typo in docstring.
4175
88652fd5
EZ
41762011-09-27 Eli Zaretskii <eliz@gnu.org>
4177
4178 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4179 newline, reseat the iterator instead of bidi-iterating there one
4180 character at a time. (Bug#9610)
32c1fffd
SM
4181 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4182 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4183
ed497dd4
AS
41842011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4185
4186 * lread.c (readevalloop): Use correct code for NBSP.
4187 (read1): Likewise. (Bug#9608)
4188
b2bf61aa
MA
41892011-09-25 Michael Albinus <michael.albinus@gmx.de>
4190
4191 * dbusbind.c (Fdbus_register_signal): When service is not
4192 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4193
32bbb17c
GM
41942011-09-25 Glenn Morris <rgm@gnu.org>
4195
4196 * buffer.c (truncate-lines): Doc fix.
4197
94e0933e
CY
41982011-09-24 Chong Yidong <cyd@stupidchicken.com>
4199
4200 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4201 (Fset_window_next_buffers): Doc fix.
4202
cddde921
GM
42032011-09-24 Glenn Morris <rgm@gnu.org>
4204
4205 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4206
1260aef1
PE
42072011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4208
25b4bfa0
PE
4209 Fix minor problems found by static checking.
4210 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4211 * indent.c (Fvertical_motion): Fix == vs = typo.
4212
e3cbd34b
EZ
42132011-09-24 Eli Zaretskii <eliz@gnu.org>
4214
a66cfb1c
SM
4215 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4216 Default value is now t. Doc fix.
6bf7006f 4217
e3cbd34b 4218 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4219 logic when moving up, not only when moving down. Fix the
e3cbd34b 4220 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4221 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4222
4223 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4224 CHARPOS is covered by a display string which includes newlines.
4225 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4226 is covered by a display string with embedded newlines.
4227
a3de0cbd
MA
42282011-09-24 Michael Albinus <michael.albinus@gmx.de>
4229
4230 * dbusbind.c (Fdbus_register_signal): Add match rule to
4231 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4232 (Fdbus_register_method, Vdbus_registered_objects_table):
4233 Fix docstring.
a3de0cbd 4234
b260039d
JM
42352011-09-24 Jim Meyering <meyering@redhat.com>
4236
32c1fffd 4237 do not ignore write error for any output size
b260039d
JM
4238 The previous change was incomplete.
4239 While it makes emacs --batch detect the vast majority of stdout
4240 write failures, errors were still ignored whenever the output size is
4241 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4242 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4243 && echo FAIL: ignored write error
4244 FAIL: ignored write error
4245 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4246 && echo FAIL: ignored write error
4247 FAIL: ignored write error
4248 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4249
8eca8a7c
AS
42502011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4251
4252 * emacs.c (Fkill_emacs): In noninteractive mode exit
4253 non-successfully if a write error occurred on stdout. (Bug#9574)
4254
3341db62
EZ
42552011-09-21 Eli Zaretskii <eliz@gnu.org>
4256
4257 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4258 the xassert test.
4259
4260 * dispextern.h (struct it): Update the comment documenting what
4261 can it->OBJECT be.
4262
8c203dbf
EZ
42632011-09-20 Eli Zaretskii <eliz@gnu.org>
4264
4265 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4266 a display string, extend search for cursor position to end of row.
4267 (find_row_edges): If the row ends in a newline from a display
4268 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4269 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4270 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4271 non-empty line. Fixes confusing cursor motion with arrow keys at
4272 the beginning of a line that starts with whitespace.
8c203dbf 4273
a4824228
LMI
42742011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4275
4276 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4277 (bug#9493).
4278
33ed493b
CY
42792011-09-18 Chong Yidong <cyd@stupidchicken.com>
4280
4281 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4282 boolean (Bug#9154).
4283
56cd55c8
EZ
42842011-09-18 Eli Zaretskii <eliz@gnu.org>
4285
4286 * xdisp.c (display_line): Record maximum and minimum buffer
4287 positions even if no glyphs were produced (e.g., by a zero-width
4288 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4289 buffer positions that will be removed from the glyph row because
4290 they don't fit.
c02dcedf
EZ
4291 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4292 column is beyond frame width: don't subtract 1 "pixel" when
4293 computing width of the stretch.
3e62b7e0
EZ
4294 (reseat_at_next_visible_line_start): Undo the change made on
4295 2011-09-17 that saved paragraph information and restored it after
4296 the call to `reseat'. (Bug#9545)
56cd55c8 4297
5ed99d36 42982011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4299
4300 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4301 and turn window cursor on if cleared (Bug#9415).
4302
5ed99d36 43032011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4304
4305 * search.c (boyer_moore): Take unibyte characters from pattern
4306 literally. (Bug#9458)
4307
9bade7b2
EZ
43082011-09-18 Eli Zaretskii <eliz@gnu.org>
4309
4310 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4311
e5e9d610
PE
43122011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4313
87e4427a
PE
4314 Fix minor problem found by static checking.
4315 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4316 initialized, to pacify gcc -Wuninitialized.
4317
e5e9d610
PE
4318 * fileio.c: Report proper errno when syscall falls.
4319 (Finsert_file_contents): Save and restore errno,
4320 so that report_file_error outputs the correct diagnostic.
4321 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4322
a1674f0b
EZ
43232011-09-18 Eli Zaretskii <eliz@gnu.org>
4324
4325 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4326
fbfb6dd4
EZ
43272011-09-17 Eli Zaretskii <eliz@gnu.org>
4328
4329 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4330 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4331
bb187662
EZ
43322011-09-17 Eli Zaretskii <eliz@gnu.org>
4333
1137e8b8 4334 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4335 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4336
4337 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4338 (bidi_find_paragraph_start): Search back for paragraph beginning
4339 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4340 (bidi_move_to_visually_next): Only trigger paragraph-related
4341 computations when the last character is a newline or at EOB, not
4342 just any NEUTRAL_B. (Bug#9470)
4343
bb187662
EZ
4344 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4345 truncated lines if point is covered by a display string. (Bug#9524)
4346
2e621251
PE
43472011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4348
4349 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4350 (cons_to_x_long): New function.
4351 (lisp_data_to_selection_data): Use it. Correct the test for
4352 short-versus-long data; it was negated. Break out of vector
4353 loop, for efficiency, when a long datum is discovered.
4354
91a15bc6
SM
43552011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4356
4357 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4358
b41c3a35
EZ
43592011-09-16 Eli Zaretskii <eliz@gnu.org>
4360
4361 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4362 GCC PR/17406) by declaring this function with external scope.
4363
7812ba2d
PE
43642011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4365
4366 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4367 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4368
cf7edc2a
AS
43692011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4370
4371 * editfns.c (Fformat): Correctly handle text properties on "%%".
4372
bd01620e
EZ
43732011-09-15 Eli Zaretskii <eliz@gnu.org>
4374
4375 * xterm.c (x_draw_composite_glyph_string_foreground):
4376 * w32term.c (x_draw_composite_glyph_string_foreground):
4377 * term.c (encode_terminal_code):
4378 * composite.c (composition_update_it, get_composition_id):
4379 * xdisp.c (get_next_display_element)
4380 (fill_composite_glyph_string): Add comments about special meaning
4381 of TAB characters in a composition.
4382
a02719a3
PE
43832011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4384
4385 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4386 This occurs when processing a multibyte format.
4387 Problem reported by Wolfgang Jenker.
a02719a3 4388
72589a3c
JB
43892011-09-15 Johan Bockgård <bojohan@gnu.org>
4390
4391 * xdisp.c (try_cursor_movement): Only check for exact match if
4392 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4393
1c14176c
PE
43942011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4395
4396 Remove unused external symbols.
4397 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4398 * xdisp.c (calc_pixel_width_or_height): Now static.
4399 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4400 * indent.c (check_display_width):
4401 * w32term.c: Fix comment to match code.
4402 * xterm.c, xterm.h (x_catching_errors): Remove.
4403
d2eea5b5
PE
44042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4405
4406 * xselect.c: Use signed conversions more consistently (Bug#9498).
4407 (selection_data_to_lisp_data): Assume incoming selection data are
4408 signed integers, not unsigned. This is to be consistent with
4409 outgoing selection data, which was modified to use signed integers
4410 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4411 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4412 expects long, not unsigned long.
4413
46888499
EZ
44142011-09-14 Eli Zaretskii <eliz@gnu.org>
4415
4416 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4417 computation of loop end. Reported by Johan Bockgård
4418 <bojohan@gnu.org>.
4419
ef8ef9fb
CY
44202011-09-13 Chong Yidong <cyd@stupidchicken.com>
4421
4422 * frame.c (Fother_visible_frames_p): Function deleted.
4423
fa819fed
EZ
44242011-09-12 Eli Zaretskii <eliz@gnu.org>
4425
4426 * indent.c (compute_motion): Process display vector front to back
4427 rather than the other way around. (Bug#2496)
4428
2ba8e008
SM
44292011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4430
4431 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4432
20f53c69
CY
44332011-09-11 Chong Yidong <cyd@stupidchicken.com>
4434
4435 * minibuf.c (Fread_from_minibuffer): Doc fix.
4436
d562d7a4
EZ
44372011-09-11 Eli Zaretskii <eliz@gnu.org>
4438
4439 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4440 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4441
1c4d7f3d
LMI
44422011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4443
4444 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4445 value for non-existent files.
4446
b885bf36
EZ
44472011-09-11 Eli Zaretskii <eliz@gnu.org>
4448
4449 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4450 set its "size" to -1. This will set the modtime_size field of
4451 the corresponding buffer to -1, which is what
4452 verify-visited-file-modtime expects for files that do not exist.
4453 (Bug#9139)
4454
6612f0bf
PE
44552011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4456
4457 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4458 here ...
4459 * lisp.h: ... from here. push_key_description is no longer
4460 defined in keyboard.c, so its declaration should not be in
4461 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4462 logically belongs with push_key_description.
4463
dfb3f755
PE
44642011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4465
4466 * buffer.h: Include <sys/types.h> instead of <time.h>.
4467 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4468 Problem reported by Herbert J. Skuhra.
4469
3134906c
LMI
44702011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4471
4472 * xml.c (parse_region): Make the parsing work for
4473 non-comment-starting XML files again (bug#9144).
4474
8d903f4e
AS
44752011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4476
4477 * image.c (gif_load): Fix calculation of bottom and right corner.
4478 (Bug#9468)
4479
80ad64f4
EZ
44802011-09-10 Eli Zaretskii <eliz@gnu.org>
4481
4482 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4483 redisplay in small windows.
4484
208a048d
EZ
44852011-09-09 Eli Zaretskii <eliz@gnu.org>
4486
4487 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4488
9b1c252e
MR
44892011-09-08 Martin Rudalics <rudalics@gmx.at>
4490
4491 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4492 Operate on live windows only.
4493
2949f33b
JB
44942011-09-08 Juanma Barranquero <lekktu@gmail.com>
4495
4496 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4497
e08dcafd
EZ
44982011-09-07 Eli Zaretskii <eliz@gnu.org>
4499
4500 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4501 only under bidi iteration.
4502
115b96bd
JD
45032011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4504
4505 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4506
c8199d0f
PE
45072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4510 Without this fix, the command to link temacs failed due to an
4511 undefined symbol __builtin_isnan. This is because
4512 /usr/include/iso/math_c99.h #defines isnan(x) to
4513 __builtin_isnan(x), but the bundled gcc, which identifies itself
4514 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4515 a __builtin_isnan.
4516 * floatfns.c (isnan): #undef, and then #define to a clone of
4517 what's in data.c.
4518 (Fisnan): Always define, since it's always available now.
4519 (syms_of_floatfns): Always define isnan at the Lisp level.
4520
e39b275c 45212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4522
4523 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4524
b2db44d9 45252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4526
f4af5137 4527 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4528 The previous code assumed that file offsets (off_t values) fit in
4529 EMACS_INT variables, which is not true on typical 32-bit hosts.
4530 The code messed up by falsely reporting buffer overflow in cases
4531 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4532 when "big" contains more than 2**29 bytes, even though this
4533 inserts just one byte and does not overflow the buffer.
4534 (Finsert_file_contents): Store file offsets as off_t
4535 values, not as EMACS_INT values. Check for overflow when
4536 converting between EMACS_INT and off_t. When checking for
4537 buffer overflow or for overlap, take the offsets into account.
4538 Don't use EMACS_INT for small values where int suffices.
4539 When checking for overlap, fix a typo: ZV was used where
4540 ZV_BYTE was intended.
4541 (Fwrite_region): Don't assume off_t fits into 'long'.
4542 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4543
ecfc0a49
MA
45442011-09-05 Michael Albinus <michael.albinus@gmx.de>
4545
4546 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4547
6511acf2 45482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4549
0999621a 4550 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4551
4552 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4553 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4554 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4555 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4556 (modify_event_symbol): Do not assume that the length of
4557 name_alist_or_stem is safe to alloca and fits in int.
4558 (Fexecute_extended_command): Likewise for function name and binding.
4559 (Frecursion_depth): Wrap around reliably on integer overflow.
4560 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4561 since some callers pass EMACS_INT values.
4562 (Fsingle_key_description): Don't crash if symbol name contains more
4563 than MAX_ALLOCA bytes.
4564 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4565 (get_minibuffer): Arg is now EMACS_INT, not int.
4566 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4567 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4568 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4569
2be7d702
PE
4570 * dbusbind.c (signature_cat): New function.
4571 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4572 Do not overrun buffer; instead, report string overflow.
4573
9d1df220
PE
4574 * dispnew.c (add_window_display_history): Don't overrun buffer.
4575 Truncate instead; this is OK since it's just a log.
4576
33ef5c64
PE
4577 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4578 even if the time zone offset is outlandishly large.
4579 Don't mishandle offset == INT_MIN.
4580
66c6fdd5
PE
4581 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4582 when creating daemon; the previous buffer-overflow check was incorrect.
4583
d749b01b
PE
4584 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4585 which has the guts of the old verror function.
4586
b5cd1905
PE
4587 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4588 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4589
6e1a67fb
PE
4590 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4591 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4592 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4593 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4594 length of string rather than counting it via multiple sprintfs;
4595 that's simpler and more reliable.
c21721cc
PE
4596 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4597 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4598 sprintf, in case result does not fit in int.
4599
c57b67fc
PE
4600 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4601 (fontset_from_font): Print it.
4602
8a401434
PE
4603 * frame.c (tty_frame_count): Now printmax_t, not int.
4604 (make_terminal_frame, set_term_frame_name): Print it.
4605 (x_report_frame_params): In X, window IDs are unsigned long,
4606 not signed long, so print them as unsigned.
4607 (validate_x_resource_name): Check for implausibly long names,
4608 and don't assume name length fits in 'int'.
4609 (x_get_resource_string): Don't blindly alloca invocation name;
4610 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4611 not fit in int.
4612
6e1a67fb
PE
4613 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4614 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4615 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4616
0df02bf3
PE
4617 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4618 Use esprintf, not sprintf, in case result does not fit in int.
4619
48e30793
PE
4620 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4621 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4622 it as a large positive number.
4623 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4624 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4625
a66ff6d8
PE
4626 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4627 in case result does not fit in int.
4628
aca216ff
PE
4629 * print.c (float_to_string): Detect width overflow more reliably.
4630 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4631 buffer overrun. Don't assume list length fits in 'int'. Treat
4632 print length of 0 as 0, not as infinity; to be consistent with other
4633 uses of print length in this function. Don't overflow print length
4634 index. Don't assume hash table size fits in 'long', or that
4635 vectorlike size fits in 'unsigned long'.
4636
31c286f7
PE
4637 * process.c (make_process): Use printmax_t, not int, to format
4638 process-name gensyms.
4639
55e5faa1
PE
4640 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4641
80f2e268
PE
4642 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4643 to avoid potential buffer overrun.
4644
670741ab
PE
4645 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4646 if X resource line is longer than 512 bytes.
4647
b7163a50
PE
4648 * xfns.c (x_window): Make sprintf buffer a bit bigger
4649 to avoid potential buffer overrun.
4650
ae58ff1f
PE
4651 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4652
c43c8a6a
PE
4653 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4654
3f8236f4
PE
46552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4656
53e9fe90 4657 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4658 Without these, Emacs silently mishandles large integers sometimes.
4659 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4660 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4661
6511acf2
PE
4662 * xdisp.c (try_window_id): Check Emacs fixnum range before
4663 converting to 'int'.
806add1d 4664
6511acf2 4665 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4666 Check that an Emacs fixnum is in range before assigning it to 'int'.
4667 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4668 values converted from Emacs fixnums.
4669 (Frecenter): Don't wrap around a line count if it is out of 'int'
4670 range; instead, treat it as an extreme value.
4671 (Fset_window_configuration, compare_window_configurations):
4672 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4673
6511acf2
PE
4674 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4675 that can exceed INT_MAX. Check that EMACS_INT value is in range
4676 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4677 (match_limit): Don't assume that a fixnum can fit in 'int'.
4678
6511acf2 4679 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4680 exceed INT_MAX.
4681
6511acf2 4682 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4683 (Fvertical_motion): Don't wrap around LINES values that don't fit
4684 in 'int'. Instead, treat them as extreme values. This is good
4685 enough for windows, which can't have more than INT_MAX lines anyway.
4686
fcb901a7
LMI
46872011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4688
0f2f6b6d
LMI
4689 * Require libxml/parser.h to avoid compilation warning.
4690
fcb901a7
LMI
4691 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4692
4693 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4694 since this reportedly can destroy thread storage.
4695
6e20a0d4
CY
46962011-08-30 Chong Yidong <cyd@stupidchicken.com>
4697
4698 * syntax.c (find_defun_start): Update all cache variables if
4699 exiting early (Bug#9401).
4700
148ae00e
EZ
47012011-08-30 Eli Zaretskii <eliz@gnu.org>
4702
f6cfbd8f
EZ
4703 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4704
148ae00e
EZ
4705 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4706 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4707 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4708
4709 * term.c (tty_append_glyph): New function.
4710 (produce_stretch_glyph): Static function and its prototype deleted.
4711
a66cfb1c
SM
4712 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4713 Add prototypes.
148ae00e 4714
c4a07a4c
PE
47152011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4716
4717 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4718 when checking :margin (Bug#9390).
4719 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4720 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4721 so that the name doesn't mislead. All uses changed.
4722
6bc8cd65
JB
47232011-08-28 Johan Bockgård <bojohan@gnu.org>
4724
4725 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4726 set_tty_hooks.
4727
dca4927e
EZ
47282011-08-27 Eli Zaretskii <eliz@gnu.org>
4729
4730 * xdisp.c (move_it_to): Don't bail out early when reaching
4731 position beyond to_charpos, if we are scanning backwards.
4732 (move_it_vertically_backward): When DY == 0, make sure we get to
4733 the first character in the line after the newline.
4734
f2cad773
PE
47352011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4736
4737 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4738 (ccl_driver): Do not generate an out-of-range pointer.
4739 (Fccl_execute_on_string): Remove unnecessary check for
4740 integer overflow, noted by Stefan Monnier in
4741 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4742 Remove a FIXME that didn't need fixing.
4743 Simplify the newly-introduced buffer reallocation code.
4744
0cae2cdb
JB
47452011-08-27 Juanma Barranquero <lekktu@gmail.com>
4746
4747 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4748
5fc295a4 47492011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4750
70c60eb2 4751 Integer and memory overflow issues (Bug#9196).
726e0ab1 4752
d31850da
PE
4753 * doc.c (get_doc_string): Rework so that
4754 get_doc_string_buffer_size is the actual buffer size, rather than
4755 being 1 less than the actual buffer size; this makes xpalloc more
4756 convenient.
4757
a69fbedb
PE
4758 * image.c (x_allocate_bitmap_record, cache_image):
4759 * xselect.c (Fx_register_dnd_atom):
4760 Simplify previous changes by using xpalloc.
4761
fe5c5d37
PE
4762 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4763 since either will do and ptrdiff_t is convenient with xpalloc.
4764
0065d054
PE
4765 * charset.c (charset_table_size)
4766 (struct charset_sort_data.priority): Now ptrdiff_t.
4767 (charset_compare): Don't overflow if priorities differ greatly.
4768 (Fsort_charsets): Don't assume list length fits in int.
4769 Check for size-calculation overflow when allocating sort data.
4770 (syms_of_charset): Allocate an initial charset table that is
4771 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4772
4773 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4774
4775 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4776 The actual value is always <= INT_MAX, and leaving it unsigned made
4777 overflow checking harder.
4778
4779 * dispextern.h (struct glyph_matrix.rows_allocated)
4780 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4781 with xpalloc. The values are still always <= INT_MAX.
4782
4783 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4784
4785 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4786 (SAFE_NALLOCA): New macro.
4787
4788 * region-cache.c (struct boundary.pos, find_cache_boundary)
4789 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4790 (set_cache_region, invalidate_region_cache)
4791 (revalidate_region_cache, know_region_cache, region_cache_forward)
4792 (region_cache_backward, pp_cache):
4793 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4794 so that ptrdiff_t * can be passed to xpalloc.
4795 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4796 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4797 (pp_cache): Don't assume cache_len fits in int.
4798 * region-cache.h: Adjust extern decls to match.
4799
4800 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4801 EMACS_INT, since either will do, for xpalloc.
4802
4803 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4804 (xnmalloc, xnrealloc, xpalloc): New functions.
4805
726e0ab1
PE
4806 * bidi.c (bidi_shelve_header_size): New constant.
4807 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4808 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4809
51f30bc5 4810 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4811 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4812 (overlay_strings):
4813 Don't update size of array until after memory allocation succeeds,
4814 because xmalloc/xrealloc may not return.
0065d054
PE
4815 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4816 now that we have proper integer overflow checking.
4817 (record_overlay_string, overlay_strings): Catch overflows when
4818 calculating size of overlay_str_buf.
726e0ab1 4819
0065d054
PE
4820 * callproc.c (Fcall_process): Check for size overflow when
4821 calculating size of args2.
4822 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4823 Normally we prefer signed values, but sticking with ptrdiff_t would
4824 require adding more-complicated checks.
726e0ab1
PE
4825
4826 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4827 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4828 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4829 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4830
4831 * character.c (Fstring): Check for size-calculation overflow.
4832
4833 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4834 unnecessary integer overflow. Check for size overflow.
4835 (encode_coding_object): Don't update size until xmalloc succeeds.
4836
4837 * composite.c (get_composition_id): Check for overflow in glyph
4838 length calculations.
4839
4840 Integer and memory overflow fixes for display code.
4841 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4842 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4843 (scrolling_window): Check for overflow in size calculations.
4844 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4845 Don't assume glyph table len fits in int.
4846 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4847 (row_table_size): Now ptrdiff_t, not int.
4848 (scrolling_window): Avoid overflow in size calculations.
4849 Don't update size until allocation succeeds.
4850 * fns.c (concat): Check for overflow in size calculations.
4851 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4852 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4853 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4854
4855 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4856 (get_doc_string): Check for size calculation overflow.
4857 Don't update size until allocation succeeds.
4858 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4859 EMACS_INT, where ptrdiff_t will do.
4860 (Fsubstitute_command_keys): Check for string overflow.
4861
4862 * editfns.c (set_time_zone_rule): Don't assume environment length
4863 fits in int.
4864 (message_length): Now ptrdiff_t, not int.
4865 (Fmessage_box): Don't update size until allocation succeeds.
4866 Don't assume message length fits in int.
4867 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4868
0065d054
PE
4869 * emacs.c (main): Do not reallocate argv, since there is a null at
4870 the end that can be overwritten, and this way there's no need to
4871 worry about size-calculation overflow.
4872 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4873
4874 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4875 alloc succeeds.
4876 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4877
4878 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4879 (x_set_scroll_bar_width, x_figure_window_size):
4880 Check for integer overflow.
4881 (x_set_alpha): Do not assume XINT fits in int.
4882
4883 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4884 This is for the members text_lines, text_cols, total_lines, total_cols,
4885 where the system imposes an 'int' limit.
4886
4887 * fringe.c (Fdefine_fringe_bitmap):
4888 Don't update size until alloc works.
4889
4890 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4891 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4892
4893 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4894 Check for size-calculation overflow.
4895 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4896 do, as we prefer signed integers.
4897 (id_to_widget.max_size, id_to_widget.used)
4898 (xg_store_widget_in_map, xg_remove_widget_from_map)
4899 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4900 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4901 Use and return ptrdiff_t, not int.
4902 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4903 * gtkutil.h: Change prototypes to match the above.
4904
4905 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4906 are duplicate now that they've been promoted to lisp.h.
4907 (x_allocate_bitmap_record, x_alloc_image_color)
4908 (make_image_cache, cache_image, xpm_load):
4909 Don't update size until alloc is done.
4910 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4911 (x_detect_edges):
3256efce 4912 Check for size calculation overflow.
726e0ab1
PE
4913 (ct_colors_allocated_max): New constant.
4914 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4915 overflow.
3256efce 4916
726e0ab1
PE
4917 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4918 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4919 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4920 Use ptrdiff_t, not int, to count maps.
4921 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4922 calculations. Don't update size until allocation succeeds.
4923 Redo calculations to avoid overflow.
726e0ab1
PE
4924 * keyboard.h: Change prototypes to match the above.
4925
4926 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4927 to count maps.
4928 (current_minor_maps): Check for size calculation overflow.
4929 * keymap.h: Change prototypes to match the above.
4930
4931 * lread.c (read1, init_obarray): Don't update size until alloc done.
4932
4933 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4934 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4935
726e0ab1
PE
4936 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4937 Now ptrdiff_t, not int.
4938 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4939 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4940
4941 * process.c (Fnetwork_interface_list): Check for overflow
4942 in size calculation.
4943
4944 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4945
4946 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4947 overflow. Don't bother calling xmalloc when xrealloc will do.
4948
4949 * search.c (Freplace_match): Check for size calculation overflow.
4950 (Fset_match_data): Don't assume list lengths fit in 'int'.
4951
4952 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4953 for command line length. Do not attempt to address one before the
4954 beginning of an array, as that's not portable.
4955
4956 * term.c (max_frame_lines): Remove; unused.
4957 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4958 not int.
4959 (encode_terminal_code, calculate_costs): Check for size
4960 calculation overflow.
4961 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4962 table lengths and related sizes. Don't update size until alloc
4963 done. Redo calculations to avoid overflow.
4964 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4965
4966 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4967 subtracting pointers.
4968 (gobble_line): Check for overflow more carefully. Don't update size
4969 until alloc done.
4970
4971 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4972 Don't update size until alloc done.
4973 Redo size calculations to avoid overflow.
4974 Check for size calculation overflow.
0065d054 4975 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4976
4977 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4978 Use ptrdiff_t, not int, for sizes.
4979 (store_mode_line_noprop_char): Don't update size until alloc done.
4980
0065d054
PE
4981 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4982 Use ptrdiff_t, not int, for sizes.
4983 (Finternal_make_lisp_face, cache_face):
4984 Check for size calculation overflow.
4985 (cache_face): Treat size calculation overflows as if they were
4986 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4987
4988 * xfns.c (x_encode_text, x_set_name_internal)
4989 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4990 sizes, since they can exceed INT_MAX in size. Check for size
4991 calculation overflow.
4992
0065d054
PE
4993 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4994 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4995 Don't update size until alloc done.
4996
0065d054 4997 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4998 as sprintf is limited to int lengths.
1d526e2f 4999
252c5ee1
PE
5000 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5001 (X_LONG_MIN): New macros.
864d7ce7
PE
5002 Use them to make the following changes clearer.
5003 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5004 This change doesn't affect the value now, but it may help remind
5005 future maintainers not to raise the value too much later.
5006 (SELECTION_QUANTUM): Remove, replacing with ...
5007 (selection_quantum): ... new function, which avoids overflow.
5008 All uses changed.
5009 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5010 assumption that selection length fits in 'int'.
5011 (x_reply_selection_request, x_handle_selection_request)
5012 (x_get_window_property, receive_incremental_selection)
5013 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5014 (lisp_data_to_selection_data, clean_local_selection_data):
5015 Use ptrdiff_t, not int, to record length of selection.
5016 (x_reply_selection_request, x_get_window_property)
5017 (receive_incremental_selection, x_property_data_to_lisp):
5018 Redo calculations to avoid overflow.
5019 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5020 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5021 something.
5022 (x_get_window_property, receive_incremental_selection)
5023 (lisp_data_to_selection_data, x_property_data_to_lisp):
5024 Check for size-calculation overflow.
5025 (x_get_window_property, receive_incremental_selection)
5026 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5027 Don't store size until memory allocation succeeds.
5028 (x_get_window_property): Plug memory leak on memory exhaustion.
5029 Don't double-block input; malloc is safe here. Don't assume 2**34
5030 - 4 fits in unsigned long. Add an xassert to check
5031 XGetWindowProperty overflow. Be more careful about overflow
5032 calculations, and distinguish size from memory overflow better.
5033 (receive_incremental_selection): When tracing, don't assume
5034 unsigned int is less than INT_MAX.
5035 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5036 harmful) conversions of unsigned short to int.
5037 (lisp_data_to_selection_data): Don't assume that integers
5038 in the range -65535 through -1 fit in an X unsigned short.
5039 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5040 result parameters unless successful. Rely on cons_to_unsigned
5041 to report problems with elements; the old code wasn't right anyway.
5042 (x_check_property_data): Check for int overflow; we cannot use
5043 a wider type due to X limits.
5044 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5045
726e0ab1 5046 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5047
0065d054
PE
5048 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5049 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5050 (x_color_cells): Don't store size until memory allocation succeeds.
5051 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5052 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5053 (x_term_init): Don't assume length fits in int (sprintf is limited
5054 to int size).
bc18e09d 5055
ebfa62c0
PE
5056 Use ptrdiff_t for composition IDs.
5057 * character.c (lisp_string_width):
5058 * composite.c (composition_table_size, n_compositions)
5059 (get_composition_id, composition_gstring_from_id):
5060 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5061 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5062 * window.c (Frecenter):
5063 Use ptrdiff_t, not int, for composition IDs.
5064 * composite.c (get_composition_id): Check for integer overflow.
5065 * composite.h: Adjust prototypes to match the above changes.
5066
d3411f89
PE
5067 Use ptrdiff_t for hash table indexes.
5068 * category.c (hash_get_category_set):
5069 * ccl.c (ccl_driver):
5070 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5071 * coding.c (coding_system_charset_list, detect_coding_system):
5072 * coding.h (struct coding_system.id):
5073 * composite.c (get_composition_id, gstring_lookup_cache):
5074 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5075 * image.c (xpm_get_color_table_h):
5076 * lisp.h (hash_lookup, hash_put):
5077 * minibuf.c (Ftest_completion):
5078 Use ptrdiff_t for hash table indexes, not int (which is too
5079 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5080 32-bit --with-wide-int hosts).
5081
e097a6fa
PE
5082 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5083 Add a FIXME comment about memory leaks.
5084 (syms_of_charset): Don't assume xmalloc returns.
5085
5637687f
PE
5086 Don't assume that stated character widths fit in int.
5087 * character.c (Fchar_width, c_string_width, lisp_string_width):
5088 * character.h (CHAR_WIDTH):
5089 * indent.c (MULTIBYTE_BYTES_WIDTH):
5090 Use sanitize_char_width to avoid undefined and/or bad behavior
5091 with outlandish widths.
a66cfb1c 5092 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5093 now that we have two such functions. All uses changed.
5094 (sanitize_char_width): New inline function.
5095
a2271ba2
PE
5096 Don't assume that tab-width fits in int.
5097 * character.h (sanitize_width): New inline function.
5098 (SANE_TAB_WIDTH): New macro.
5099 (ASCII_CHAR_WIDTH): Use it.
5100 * indent.c (sane_tab_width): Remove. All uses replaced by
5101 SANE_TAB_WIDTH (current_buffer).
5102 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5103
18c52557
PE
5104 * fileio.c: Integer overflow issues with file modes.
5105 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5106
caeeedc1
PE
5107 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5108 Remove unreachable code.
5109 (read_hex, load_charset_map_from_file): Check for integer overflow.
5110
6df6ae42 5111 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5112 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5113 (x_send_scroll_bar_event): Likewise. Check that the size does not
5114 exceed limits imposed by XClientMessageEvent, as well as the usual
5115 ptrdiff_t and size_t limits.
5116
b13995db
PE
5117 * keyboard.c: Overflow, signedness and related fixes.
5118 (make_lispy_movement): Use same integer type in forward decl
5119 that is used in the definition.
5120 (read_key_sequence, keyremap_step):
5121 Change bufsize argument back to int, undoing my 2011-03-30 change.
5122 We prefer signed types, and int is wide enough here.
5123 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5124 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5125 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5126 length, not size_t. Use ptrdiff_t for index, not int.
5127 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5128 possibility of integer overflow.
5129
13464394
PE
5130 Overflow, signedness and related fixes for images.
5131
5132 * dispextern.h (struct it.stack[0].u.image.image_id)
5133 (struct_it.image_id, struct image.id, struct image_cache.size)
5134 (struct image_cache.used, struct image_cache.ref_count):
5135 * gtkutil.c (update_frame_tool_bar):
5136 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5137 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5138 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5139 * nsmenu.m (update_frame_tool_bar):
5140 * xdisp.c (calc_pixel_width_or_height):
5141 * xfns.c (image_cache_refcount):
5142 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5143 on typical 64-bit hosts.
5144
5145 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5146 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5147 Omit unnecessary casts to int.
5148 (parse_image_spec): Check that integers fall into 'int' range
5149 when the callers expect that.
5150 (image_ascent): Redo ascent calculation to avoid int overflow.
5151 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5152 (lookup_image): Remove unnecessary tests.
5153 (xbm_image_p): Locals are now of int, not EMACS_INT,
5154 since parse_image_check makes sure they fit into int.
5155 (png_load, gif_load, svg_load_image):
5156 Prefer int to unsigned where either will do.
5157 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5158 old tiff_error_handler and tiff_warning_handler.
5159 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5160 stack buffer overflows. It uses only the features of vsnprintf
5161 that are common to both POSIX and native Microsoft.
5162 (tiff_error_handler, tiff_warning_handler): Use it.
5163 (tiff_load, gif_load, imagemagick_load_image):
5164 Don't assume :index value fits in 'int'.
5165 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5166 (imagemagick_load_image): Check that crop parameters fit into
5167 the integer types that MagickCropImage accepts. Don't assume
5168 Vimagemagick_render_type has a nonnegative value. Don't assume
5169 size_t fits in 'long'.
5170 (gs_load): Use printmax_t to print the widest integers possible.
5171 Check for integer overflow when computing image height and width.
5172
c11821d4
EZ
51732011-08-26 Eli Zaretskii <eliz@gnu.org>
5174
5175 * xdisp.c (redisplay_window): Don't force window start if point
5176 will be invisible in the resulting window. (Bug#9324)
5177
0c95fcf7
EZ
51782011-08-25 Eli Zaretskii <eliz@gnu.org>
5179
5180 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5181 the display spec is of the form `(space ...)'.
5182 (handle_display_spec): Return the value returned by
5183 handle_single_display_spec, not just 1 or zero.
5184 (handle_single_display_spec): If the display spec is of the form
5185 `(space ...)', and specifies display in the text area, return 2
5186 rather than 1.
fee65a97 5187 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5188 accurately, and prefer exact match for point under bidi.
5189 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5190
5191 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5192 into disp_prop; all users changed.
5193
5194 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5195 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5196 for the text covered by the display property.
5197
e4ed06f1
CY
51982011-08-25 Chong Yidong <cyd@stupidchicken.com>
5199
5200 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5201 Change return value to nil.
5202 (Frecord_buffer): Delete unused function.
5203
f67cdd7f
EZ
52042011-08-24 Eli Zaretskii <eliz@gnu.org>
5205
5980d4c6
EZ
5206 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5207 buffers, return left-to-right.
8610fe8b
EZ
5208 (set_cursor_from_row): Consider candidate row a win if its glyph
5209 represents a newline and point is on that newline. Fixes cursor
5210 positioning on the newline at EOL of R2L text within L2R
5211 paragraph, and vice versa.
5212 (try_cursor_movement): Check continued rows, in addition to
5213 continuation rows. Fixes unwarranted scroll when point enters a
5214 continued line of R2L text within an L2R paragraph, or vice versa.
5215 (cursor_row_p): Consider the case of point being equal to
5216 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5217 from the end of a short line to the beginning of a continued line
5218 of R2L text within L2R paragraph.
5219 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5220 composed characters.
5980d4c6 5221
f67cdd7f
EZ
5222 * bidi.c (bidi_check_type): Use xassert.
5223 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5224 members.
5225
bca633fb
EZ
52262011-08-23 Eli Zaretskii <eliz@gnu.org>
5227
5228 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5229 a character.
5230
4a5885a7
CY
52312011-08-23 Chong Yidong <cyd@stupidchicken.com>
5232
5233 * nsfont.m (ns_otf_to_script): Fix typo.
5234
0902a04e
KH
52352011-08-22 Kenichi Handa <handa@m17n.org>
5236
5237 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5238 extra slot even if the purpose is char-code-property-table.
5239
1a2e6670
EZ
52402011-08-23 Eli Zaretskii <eliz@gnu.org>
5241
8ddde651
EZ
5242 * xdisp.c (redisplay_window): When computing centering_position,
5243 account for the height of the header line. (Bug#8874)
5244
425cc014
EZ
5245 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5246 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5247 candidate is selected by the mouse, and that candidate has a
5248 composed character under the mouse.
5249
1a2e6670
EZ
5250 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5251 coordinates reported by pos-visible-in-window-p for a composed
5252 character in column zero.
5253
8b76d6f8
SM
52542011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5255
5256 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5257
dac347dd
EZ
52582011-08-22 Eli Zaretskii <eliz@gnu.org>
5259
5260 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5261 consider it a hit if to_charpos is anywhere in the range of the
5262 composed buffer positions.
5263
e013fb34
CY
52642011-08-22 Chong Yidong <cyd@stupidchicken.com>
5265
5266 * image.c (gif_load): Don't assume that each subimage has the same
5267 dimensions as the base image. Handle disposal method that is
5268 "undefined" by the gif spec (Bug#9335).
5269
bd1ba3e8
CY
52702011-08-20 Chong Yidong <cyd@stupidchicken.com>
5271
5272 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5273 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5274
54a1215b
EZ
52752011-08-19 Eli Zaretskii <eliz@gnu.org>
5276
823564e5
EZ
5277 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5278 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5279 from an Org mode buffer to a Speedbar frame.
5280
54a1215b
EZ
5281 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5282 a composition, take its buffer position from IT->cmp_it.charpos.
5283 Fixes cursor positioning at the beginning of a line that begins
5284 with a composed character.
5285
9778ebcc
EZ
52862011-08-18 Eli Zaretskii <eliz@gnu.org>
5287
0be6ee06
EZ
5288 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5289 character bidirectional type, use STRONG_L instead. Fixes crashes
5290 in a buffer produced by `describe-categories'.
5291
9778ebcc
EZ
5292 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5293 members before the level stack, so they would be saved and
5294 restored when copying iterator state. Fixes incorrect reordering
5295 around TABs covered by display properties.
5296
156bffbe
AS
52972011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5298
6b02f655 5299 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5300
72ad093b
CY
53012011-08-17 Chong Yidong <cyd@stupidchicken.com>
5302
5303 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5304 (internal_condition_case_2, internal_condition_case_n):
5305 Remove unnecessary aborts (Bug#9081).
72ad093b 5306
35774242
EZ
53072011-08-17 Eli Zaretskii <eliz@gnu.org>
5308
5309 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5310 has no `load' handler, try opening the file locally. (Bug#9311)
5311
db76dd85
KB
53122011-08-16 Ken Brown <kbrown@cornell.edu>
5313
5314 * gmalloc.c: Expand comment.
5315
b215eee5
EZ
53162011-08-16 Eli Zaretskii <eliz@gnu.org>
5317
5318 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5319 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5320
a4579d33
KB
53212011-08-16 Ken Brown <kbrown@cornell.edu>
5322
5323 Fix memory allocation problems in Cygwin build (Bug#9273).
5324
5325 * unexcw.c ( __malloc_initialized): Declare external variable.
5326 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5327
8b76d6f8
SM
5328 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5329 New variables.
a4579d33
KB
5330 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5331 dumped emacs.
5332 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5333 in the static heap.
5334 [CYGWIN] (special_realloc): New function.
5335 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5336 requests to realloc storage in the static heap.
5337
3ebec551
PE
53382011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5339
5340 * bidi.c (bidi_initialize): Remove unused local.
5341
9fd8be00
EZ
53422011-08-15 Eli Zaretskii <eliz@gnu.org>
5343
6b02f655
SM
5344 * bidimirror.h:
5345 * biditype.h: Remove file.
5346 * makefile.w32-in ($(BLD)/bidi.$(O)):
5347 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5348
5349 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5350
5351 * chartab.c: Improve commentary for the uniprop_table API.
5352
32413314
EZ
5353 * bidi.c (bidi_paragraph_init): Support zero value of
5354 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5355 (bidi_initialize): Use uniprop_table instead of including
5356 biditype.h and bidimirror.h.
32413314 5357
9fd8be00
EZ
5358 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5359 coordinates of the iterator when restoring from ppos_it.
5360 (Bug#9296)
5361
5cf2b69b
KH
53622011-08-14 Kenichi Handa <handa@m17n.org>
5363
5364 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5365 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5366
daf17d00
EZ
53672011-08-14 Eli Zaretskii <eliz@gnu.org>
5368
5369 * xdisp.c (move_it_in_display_line_to): Don't invoke
5370 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5371 ppos_it. Fixes vertical cursor motion when line beginning is
5372 covered by an image. (Bug#9296)
5373
08e3161a
JD
53742011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5375
5376 * nsterm.h (ns_run_ascript): Declare.
5377 (NSAPP_DATA2_RUNASSCRIPT): Define.
5378
5379 * nsfns.m (as_script, as_result, as_status): New static variables.
5380 (ns_run_ascript): New function.
5e617bc2 5381 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5382 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5383 the event loop. Get status from as_status (Bug#7276).
5384
5385 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5386 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5387 the event loop (Bug#7276).
5388
a3720aa2
AS
53892011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5390
5391 * gnutls.c (QCgnutls_bootprop_priority)
5392 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5393 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5394 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5395 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5396 (QCgnutls_bootprop_verify_hostname_error)
5397 (QCgnutls_bootprop_callbacks_verify): Rename from
5398 Qgnutls_bootprop_..., all uses changed.
5399
5400 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5401 uses changed.
5402
0a0d27fb
PE
54032011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5404
19d5c50c
PE
5405 * xfaces.c (Qframe_set_background_mode): Now static.
5406 * dispextern.h (Qframe_set_background_mode): Remove decl.
5407
0a0d27fb
PE
5408 * process.c (Fnetwork_interface_info): Declare local only if needed.
5409
377538cb
JD
54102011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5411
5412 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5413 (Fnetwork_interface_list): Allocate in increments of bytes instead
5414 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5415 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5416 sockaddr.
5417 (struct ifflag_def): notrailers is smart on OSX.
5418 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5419 Get hardware address with getifaddrs if available.
5420
08fff70c
EZ
54212011-08-12 Eli Zaretskii <eliz@gnu.org>
5422
5423 * xdisp.c (iterate_out_of_display_property): xassert that
5424 IT->position is set to within IT->object's boundaries. Break from
5425 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5426 when IT->position is set up wrongly due to some bug.
5427 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5428 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5429 entry. Force push_it to save on the stack the current
5430 buffer/string position, to be restored by pop_it. Fix flags in
5431 the iterator structure wrt the object coming from a display
5432 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5433 properties. (Bug#9284)
5434
7be1c708 54352011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5436
7be1c708
CY
5437 * fontset.c (fontset_get_font_group): Add proper type checks.
5438 (Bug#9172)
aac0c6e3 5439
7be1c708 54402011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5441
7be1c708
CY
5442 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5443 and LC_VERSION_MIN_MACOSX.
5444 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5445 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5446
97bb72a6
EZ
54472011-08-08 Eli Zaretskii <eliz@gnu.org>
5448
5449 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5450 no-display-properties-and-no-overlays under bidi display.
5451 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5452 properties and overlays.
97bb72a6 5453
d5617611
CY
54542011-08-08 Chong Yidong <cyd@stupidchicken.com>
5455
37e11a63
CY
5456 * editfns.c (Fset_time_zone_rule): Document relationship with the
5457 setenv function.
5458
d5617611
CY
5459 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5460 the font entity extracted from the cache (Bug#8109).
5461
58872834
CY
54622011-08-07 Chong Yidong <cyd@stupidchicken.com>
5463
5464 * composite.c (autocmp_chars): Don't reset point. That is done by
5465 restore_point_unwind (Bug#5984).
5466
75bfc667
JL
54672011-08-07 Juri Linkov <juri@jurta.org>
5468
5469 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5470 to show the arg `TIME' instead of `TIMEVAL'.
5471
d1410150
EZ
54722011-08-06 Eli Zaretskii <eliz@gnu.org>
5473
5474 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5475 display property strides EOL and includes a newline, as in
5476 longlines-mode. (Bug#9254)
75b771e4
EZ
5477 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5478 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5479
5480 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5481 is non-zero, even if the data buffer is NULL. Fixes a crash in
5482 vertical-motion with longlines-mode. (Bug#9254)
5483
35928349
EZ
54842011-08-05 Eli Zaretskii <eliz@gnu.org>
5485
ec7cc85b
EZ
5486 * bidi.c <bidi_cache_total_alloc>: Now static.
5487 (bidi_initialize): Initialize bidi_cache_total_alloc.
5488
8b76d6f8 5489 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5490 cache. (Bug#9221)
5491
5492 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5493 amount allocated this far in `bidi_cache_total_alloc'.
5494 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5495 non-zero, only free the data buffer without restoring the cache
5496 contents. All callers changed.
5497
5498 * dispextern.h (bidi_unshelve_cache): Update prototype.
5499
5500 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5501 (move_it_in_display_line, move_it_to)
5502 (move_it_vertically_backward, move_it_by_lines): Replace the call
5503 to xfree to an equivalent call to bidi_unshelve_cache.
5504 (move_it_in_display_line_to): Fix logic of returning
412b6358 5505 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5506
e2e2423b
EZ
55072011-08-05 Eli Zaretskii <eliz@gnu.org>
5508
5509 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5510 came from a string character with a `cursor' property. (Bug#9229)
5511
ae9e757a
JD
55122011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5513
5514 * Makefile.in (LIB_PTHREAD): New variable.
5515 (LIBES): Add LIB_PTHREAD (Bug#9216).
5516
5517 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5518 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5519
213bd7f2
AS
55202011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5521
6b02f655 5522 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5523
99aaf75f
JD
55242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5525
5526 * xterm.c (x_find_topmost_parent): New function.
5527 (x_set_frame_alpha): Find topmost parent window with
5528 x_find_topmost_parent and set the property there also (bug#9181).
5529 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5530
c74e9d86
PE
55312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5532
5533 * callproc.c (Fcall_process): Avoid vfork clobbering
5534 the local vars buffer, coding_systems, current_dir.
5535
640c8776
SM
55362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5537
5538 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5539
f26d0e4c
PE
55402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5541
8a10d76c
PE
5542 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5543 so that it is not optimized away.
5544
f26d0e4c
PE
5545 * xdisp.c (compute_display_string_pos): Remove unused local.
5546
55439c61
EZ
55472011-08-02 Eli Zaretskii <eliz@gnu.org>
5548
5549 Fix slow cursor motion and scrolling in large buffers with
5550 selective display, like Org Mode buffers. (Bug#9218)
5551
5552 * dispextern.h (struct bidi_it): New member disp_prop_p.
5553
5554 * xdisp.c: Remove one-slot cache of display string positions.
5555 (compute_display_string_pos): Accept an additional argument
5e617bc2 5556 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5557 for a display string or property. If found, set DISP_PROP_P
5558 non-zero.
5559
5560 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5561 DISP_PROP_P, and pass it to compute_display_string_pos.
5562 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5563 non-zero. All callers of bidi_fetch_char changed.
5564
fb33fa43
SM
55652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5566
5567 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5568
b099e063
DM
55692010-12-03 Don March <don@ohspite.net>
5570
5571 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5572 last character M-[char] is translated to ESC [char] (bug#7541).
5573
5cc7f7af
KH
55742011-08-02 Kenichi Handa <handa@m17n.org>
5575
d0fffa3f 5576 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5577
5578 * chartab.c (uniprop_table): Make it non-static.
5579
525d5e6e
EZ
55802011-08-01 Eli Zaretskii <eliz@gnu.org>
5581
5582 * xdisp.c (forward_to_next_line_start): Accept additional argument
5583 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5584 on the newline.
5585 (reseat_at_next_visible_line_start): Use the bidi iterator state
5586 returned by forward_to_next_line_start to restore the state of
5587 it->bidi_it after backing up to previous newline. (Bug#9212)
5588
31011111
AS
55892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5590
5591 * regex.c (re_comp): Protoize.
5592 (re_exec): Fix return type.
5593 (regexec): Fix type of `ret'. (Bug#9203)
5594
476371c4
PE
55952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5596
e5d76069
PE
5597 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5598 This is needed if max-image-size is a floating-point number.
5599
9a79b20c
AS
56002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5601
5602 * print.c (print_object): Print empty symbol as ##.
5603
5604 * lread.c (read1): Read ## as empty symbol.
5605
d8c2fa78
AA
56062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5607
5608 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5609 setting frame foreground color (Bug#9175).
5610 (x_set_background_color): Likewise.
5611
ffe57a7a
AA
5612 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5613 contents (Bug#9176).
5614 (EmacsTooltip -init): Remove bezels and add shadows to
5615 tooltip windows.
5616
bf3492a5
AA
5617 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5618 or scroll bar (Bug#8470).
5619
d55e9c53
AA
5620 * nsfont.m (nsfont_open): Remove assignment to voffset and
5621 unnecessary vars hshink, expand, hd, full_height, min_height.
5622 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5623
5624 * nsterm.h (nsfont_info): Remove voffset field.
5625
d8c2fa78 56262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5627
5628 Implement strike-through and overline on NextStep (Bug#8863).
5629
5630 * nsfont.m (nsfont_open): Use underline position provided by font,
5631 instead of hard-coded value of 2.
5632 (nsfont_draw): Call ns_draw_text_decoration instead.
5633
5634 * nsterm.h: Add declaration for ns_draw_text_decoration.
5635
5636 * nsterm.m (ns_draw_text_decoration): New function for drawing
5637 underline, overline, and strike-through.
5638 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5639 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5640 accommodate underlining, etc.
4843aac3 5641
4cc60b9b
EZ
56422011-07-28 Eli Zaretskii <eliz@gnu.org>
5643
bc7ece87
EZ
5644 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5645 default.
4cc60b9b 5646
476371c4
PE
56472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5648
66606eea
PE
5649 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5650 Without this fix, if a signal arrives just after memory fills up,
5651 'malloc' might be invoked reentrantly.
5652
476371c4
PE
5653 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5654 In other words, assume that every image size is allowed, on non-X
5655 hosts. This assumption is probably wrong, but it lets Emacs compile.
5656
f3fcc40d
AS
56572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5658
5659 * regex.c (re_iswctype): Convert return values to boolean.
5660
350c992f
EZ
56612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5662
5663 * xdisp.c (compute_display_string_pos): Don't use cached display
5664 string position if the buffer had its restriction changed.
5665 (Bug#9184)
5666
5266b4bb
PE
56672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5668
5669 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5670
2573a837 56712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5672
41f55ccd 5673 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5674
39e378da
PE
5675 * bidi.c: Integer size and overflow fixes.
5676 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5677 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5678 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5679 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5680 (bidi_find_other_level_edge):
5681 Use ptrdiff_t instead of EMACS_INT where either will do.
5682 This works better on 32-bit hosts configured --with-wide-int.
5683 (bidi_cache_ensure_space): Check for size-calculation overflow.
5684 Use % rather than repeated addition, for better worst-case speed.
5685 Don't set bidi_cache_size until after xrealloc returns, because it
5686 might not return.
5687 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5688 (bidi_cache_ensure_space): Also check that the bidi cache size
5689 does not exceed that of the largest Lisp string or buffer. See Eli
5690 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5691
5e927815
PE
5692 * alloc.c (__malloc_size_t): Remove.
5693 All uses replaced by size_t. See Andreas Schwab's note
5694 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5695
ca4aa935
PE
5696 * image.c: Improve checking for integer overflow.
5697 (check_image_size): Assume that f is nonnull, since
5698 it is always nonnull in practice. This is one less thing to
5699 worry about when checking for integer overflow later.
5700 (x_check_image_size): New function, which checks for integer
5701 overflow issues inside X.
5702 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5703 This removes the need for a memory_full check.
5704 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5705 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5706 (xbm_read_bitmap_data): Change locals back to 'int', since
5707 their values must fit in 'int'.
5708 (xpm_load_image, png_load, tiff_load):
5709 Invoke x_create_x_image_and_pixmap earlier,
5710 to avoid much needless work if the image is too large.
5711 (tiff_load): Treat overly large images as if
5712 x_create_x_image_and_pixmap failed, not as malloc failures.
5713 (gs_load): Use x_check_image_size.
5714
5f8f9cc2
PE
5715 * gtkutil.c: Omit integer casts.
5716 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5717 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5718
5adf60bc
PE
5719 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5720
c8907a93
PE
5721 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5722 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5723 would wrongly return t on a 64-bit host.
5724
e3c25c68
PE
5725 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5726 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5727 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5728 and therefore cause GCC to emit a bogus diagnostic in some cases.
5729
3f791afe
PE
5730 * image.c: Integer signedness and overflow and related fixes.
5731 This is not an exhaustive set of fixes, but it's time to
5732 record what I've got.
5733 (lookup_pixel_color, check_image_size): Remove redundant decls.
5734 (check_image_size): Don't assume that arbitrary EMACS_INT values
5735 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5736 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5737 (tiff_load, imagemagick_load_image):
5738 Check for overflow in size calculations.
5739 (x_create_x_image_and_pixmap): Remove unnecessary test for
5740 xmalloc returning NULL; that can't happen.
5741 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5742 (xpm_color_bucket): Use better integer hashing function.
5743 (xpm_cache_color): Don't possibly over-allocate memory.
5744 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5745 (gif_memory_source):
5746 Use ptrdiff_t, not int or size_t, to record sizes.
5747 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5748 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5749 either works, as we prefer signed integers.
5750 (tiff_read_from_memory, tiff_write_from_memory):
5751 Return tsize_t, not size_t, since that's what the TIFF API wants.
5752 (tiff_read_from_memory): Don't fail simply because the read would
5753 go past EOF; instead, return a short read.
5754 (tiff_load): Omit no-longer-needed casts.
5755 (Fimagemagick_types): Don't assume size fits into 'int'.
5756
3cc5a532
PE
5757 Improve hashing quality when configured --with-wide-int.
5758 * fns.c (hash_string): New function, taken from sxhash_string.
5759 Do not discard information about ASCII character case; this
5760 discarding is no longer needed.
5761 (sxhash-string): Use it. Change sig to match it. Caller changed.
5762 * lisp.h: Declare it.
5763 * lread.c (hash_string): Remove, since we now use fns.c's version.
5764 The fns.c version returns a wider integer if --with-wide-int is
5765 specified, so this should help the quality of the hashing a bit.
5766
b312a492
PE
5767 * emacs.c: Integer overflow minor fix.
5768 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5769 Define only if GNU_LINUX.
5770 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5771
dfd153ae
PE
5772 * dispnew.c: Integer signedness and overflow fixes.
5773 Remove unnecessary forward decls, that were a maintenance hassle.
5774 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5775 All uses changed.
5776 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5777 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5778 (prepare_desired_row, line_draw_cost):
5779 Use int, not unsigned, where either works.
5780 (save_current_matrix, restore_current_matrix):
5781 Use ptrdiff_t, not size_t, where either works.
5782 (init_display): Check for overflow more accurately, and without
5783 relying on undefined behavior.
5784
a81d11a3
PE
5785 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5786 Remove, replacing with the new symbols in lisp.h. All uses changed.
5787 * fileio.c (make_temp_name):
5788 * filelock.c (lock_file_1, lock_file):
5789 * xdisp.c (message_dolog):
5790 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5791 Use pMd etc. instead.
5792 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5793 replacing the pWIDE etc. symbols removed from editfns.c.
5794
3300e6fd
PE
5795 * keyboard.h (num_input_events): Now uintmax_t.
5796 This is (very slightly) less likely to mess up due to wraparound.
5797 All uses changed.
5798
fd05c7e9
PE
5799 * buffer.c: Integer signedness fixes.
5800 (alloc_buffer_text, enlarge_buffer_text):
5801 Use ptrdiff_t rather than size_t when either will do, as we prefer
5802 signed integers.
5803
903fe15d
PE
5804 * alloc.c: Integer signedness and overflow fixes.
5805 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5806 (__malloc_size_t): Default to size_t, not to int.
5807 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5808 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5809 Prefer ptrdiff_t to size_t when either would do, as we prefer
5810 signed integers.
5811 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5812 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5813 Now const. Initialize with values that are in range even if char
5814 is signed.
5815 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5816 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5817 These functions do the right thing with sizes > 2**32.
5818 (check_depth): Now ptrdiff_t, not int.
5819 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5820 Adjust to new way of storing sizes. Check for size overflow bugs
5821 in rest of code.
5822 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5823 slightly wrong anyway, as it missed one instance of
5824 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5825 (refill_memory_reserve): Omit needless cast to size_t.
5826 (mark_object_loop_halt): Mark as externally visible.
5827
ac82cc6a
PE
5828 * xselect.c: Integer signedness and overflow fixes.
5829 (Fx_register_dnd_atom, x_handle_dnd_message):
5830 Use ptrdiff_t, not size_t, since we prefer signed.
5831 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5832 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5833 x_dnd_atoms_size and x_dnd_atoms_length.
5834
c2d1e36d
PE
5835 * doprnt.c: Prefer signed to unsigned when either works.
5836 * eval.c (verror):
5837 * doprnt.c (doprnt):
5838 * lisp.h (doprnt):
5839 * xdisp.c (vmessage):
5840 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5841 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5842 prefer signed arithmetic to avoid comparison confusion.
5843 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5844 but is a bit tricky.
5845
0e926e56
PE
5846 Assume freestanding C89 headers, string.h, stdlib.h.
5847 * data.c, doprnt.c, floatfns.c, print.c:
5848 Include float.h unconditionally.
5849 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5850 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5851 * regex.c: Likewise for stddef.h, string.h.
5852 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5853 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5854 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5855 (STDC_HEADERS): Remove obsolete defines.
5856 * sysdep.c: Include limits.h unconditionally.
5857
9cfdb3ec
PE
5858 Assume support for memcmp, memcpy, memmove, memset.
5859 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5860 * regex.c (memcmp, memcpy):
5861 Remove; we assume C89 now.
5862
5863 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5864 (__malloc_safe_bcopy): Remove; no longer needed.
5865
cf950e6b 5866 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5867 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5868 well either way, and we prefer signed to unsigned.
5869
dbf38e02
LMI
58702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5871
5872 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5873 closes the connection while we're reading (bug#9182).
5874
d6f0886c 58752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5876
d6f0886c
JD
5877 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5878 are specified (Bug#9168).
24e0f6b1 5879
2eb1f9e6
PE
58802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5881
5882 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5883 Found by GCC static checking and --with-wide-int on a 32-bit host.
5884
22381272 58852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5886
5887 * xdisp.c (compute_display_string_pos): Fix logic of caching
5888 previous display string position. Initialize cached_prev_pos to
5889 -1. Fixes slow-down at the beginning of a buffer.
5890
f25e39b4
EZ
58912011-07-24 Eli Zaretskii <eliz@gnu.org>
5892
5893 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5894 for attrs[LFACE_FONTSET_INDEX].
5895
04c4b52e
PE
58962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5897
5898 * xml.c (parse_region): Remove unused local
5899 that was recently introduced.
5900
c1734fbd
EZ
59012011-07-23 Eli Zaretskii <eliz@gnu.org>
5902
be18c5a5
EZ
5903 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5904 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5905
c1734fbd
EZ
5906 * xdisp.c (move_it_in_display_line_to): Record the best matching
5907 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5908 exit if none of the characters scanned was an exact match.
5909 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5910 when exact match is impossible due to invisible text, and the
5911 lines are truncated.
5912
a258d627
JD
59132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5914
5915 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5916 for OSX >= 10.7.
5917
b6d5a689
EZ
59182011-07-22 Eli Zaretskii <eliz@gnu.org>
5919
0f74f785
EZ
5920 Fix a significant slow-down of cursor motion with C-n, C-p,
5921 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5922 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5923 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5924 (next_element_from_buffer): Call compute_stop_pos_backwards to
5925 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5926 base_level_stop.
5927 (reseat): Don't look for prev_stop, as that could mean a very long
5928 run.
5929 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5930 <cached_disp_overlay_modiff>: Cache for last found display string
5931 position.
551918c1 5932 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5933 about the same buffer in the same area of character positions, and
5934 the buffer wasn't changed since the time the display string
5935 position was cached.
551918c1 5936
b2d0c91a
EZ
59372011-07-22 Eli Zaretskii <eliz@gnu.org>
5938
5939 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5940 is an integer, which is important for empty lines. (Bug#9149)
5941
043604ee
CY
59422011-07-22 Chong Yidong <cyd@stupidchicken.com>
5943
5944 * frame.c (Fmodify_frame_parameters): In tty case, update the
5945 default face if necessary (Bug#4238).
5946
da4adb04
CY
59472011-07-21 Chong Yidong <cyd@stupidchicken.com>
5948
5949 * editfns.c (Fstring_to_char): No need to explain what a character
5950 is in the docstring (Bug#6576).
5951
9abd0532
LMI
59522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5953
5954 * xml.c (parse_region): Make sure we always return a tree.
5955
36881d16
HK
59562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5957
5958 * xml.c (parse_region): If a document contains only comments,
5959 return that, too.
5960
1e98674d
LMI
59612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5962
5963 * xml.c (make_dom): Return comments, too.
5964
590bd467
PE
59652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5966
5967 Port to OpenBSD.
5968 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5969 and the surrounding thread.
5970 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5971 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5972 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5973 timer goes off.
5974 * s/openbsd.h (BROKEN_SIGIO): Define.
5975 * unexelf.c (unexec) [__OpenBSD__]:
5976 Don't update the .mdebug section of the Alpha COFF symbol table.
5977
f41628b2
LMI
59782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5979
5980 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5981 (bug#8460).
5982
b59b67c5
PE
59832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5984
15e3a074
PE
5985 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5986 This fixes some race conditions on the permissions of any newly
5987 created file.
5988
41bed37d
PE
5989 * alloc.c (valid_pointer_p): Use pipe, not open.
5990 This fixes some permissions issues when debugging.
5991
b59b67c5
PE
5992 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5993 If fchown fails to set both uid and gid, try to set just gid,
5994 as that is sometimes allowed. Adjust the file's mode to eliminate
5995 setuid or setgid bits that are inappropriate if fchown fails.
5996
925a6be7
SM
59972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5998
5999 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6000 to compare Lisp_Objects.
6001 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6002 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6003 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6004
52968808
AS
60052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6006
0a6a104b
AS
6007 * lread.c (read_integer): Unread even EOF character.
6008 (read1): Likewise. Properly record start position of symbol.
6009
52968808
AS
6010 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6011 symbol character follows.
6012
9e381cdd
PE
60132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6014
6015 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6016 This works around a problem with the previous change to Fcopy_file.
6017 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6018 and without this change, GCC might complain about discarding
6019 fchown's return value.
6020
b5641435
JB
60212011-07-16 Juanma Barranquero <lekktu@gmail.com>
6022
6023 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6024
a8031457
PE
60252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6026
6027 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6028
dd889327
LMI
60292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6030
750c33f7
LMI
6031 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6032 it's used from the C level.
6033
dd889327
LMI
6034 * process.c: Use the same condition for POLL_FOR_INPUT in both
6035 keyboard.c and process.c (bug#1858).
6036
87e86684
LM
60372011-07-09 Lawrence Mitchell <wence@gmx.li>
6038
6039 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6040 (Fgnutls_boot): Use it.
6041
64348f40
AS
60422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6043
6044 * doc.c (Fsubstitute_command_keys): Revert last change.
6045
1d698799
LMI
60462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6047
f863868c
LMI
6048 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6049 quotes the next character, and doesn't affect other longer
6050 sequences (bug#8935).
6051
1d698799
LMI
6052 * lread.c (syms_of_lread): Clarify that is isn't only
6053 `eval-buffer' and `eval-defun' that's affected by
6054 `lexical-binding' (bug#8460).
6055
aa4b6df6
EZ
60562011-07-15 Eli Zaretskii <eliz@gnu.org>
6057
6058 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6059 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6060
5d856da6
PE
60612011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6062
ad6042bb
PE
6063 Fix minor problems found by static checking.
6064 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6065 (elsz): Now a signed constant, not a size_t var. We prefer signed
6066 types to unsigned, to avoid integer comparison confusion. Without
6067 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6068 "cannot optimize loop, the loop counter may overflow", a symptom
6069 of the confusion.
f00bbb22 6070 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6071 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6072
6468f31c
LMI
60732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6074
49080b10
LMI
6075 * search.c (Fre_search_backward): Mention `case-fold-search' in
6076 all the re_search_* functions (bug#8138).
6077
6468f31c
LMI
6078 * keyboard.c (Fopen_dribble_file): Document when the file is
6079 closed (bug#8056).
6080
c965adc5
EZ
60812011-07-14 Eli Zaretskii <eliz@gnu.org>
6082
df9733bf
EZ
6083 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6084 bidi_cache_idx.
6085
0bb23927
EZ
6086 Support bidi reordering of display and overlay strings.
6087 * xdisp.c (compute_display_string_pos)
6088 (compute_display_string_end): Accept additional argument STRING.
6089 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6090 (reseat_to_string): Initialize bidi_it->string.s and
6091 bidi_it->string.schars.
6092 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6093 NULL (avoids a crash in bidi_paragraph_init).
6094 Initialize itb.string.lstring.
0bb23927
EZ
6095 (init_iterator): Call bidi_init_it only of a valid
6096 buffer position was specified. Initialize paragraph_embedding to
6097 L2R.
6098 (reseat_to_string): Initialize the bidi iterator.
6099 (display_string): If we need to ignore text properties of
6100 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6101 original value of -1 will not work with bidi.)
6102 (compute_display_string_pos): First arg is now struct
6103 `text_pos *'; all callers changed. Support display properties on
6104 Lisp strings.
6105 (compute_display_string_end): Support display properties on Lisp
6106 strings.
6107 (init_iterator, reseat_1, reseat_to_string): Initialize the
6108 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6109 when iterating on a string not from display properties).
640c8776
SM
6110 (compute_display_string_pos, compute_display_string_end):
6111 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6112 arrow keys.
6113 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6114 base_level_stop; instead, set base_level_stop to BEGV.
6115 Fixes crashes in vertical-motion.
0bb23927
EZ
6116 (next_element_from_buffer): Improve commentary for when
6117 the iterator is before prev_stop.
6118 (init_iterator): Initialize bidi_p from the default value of
6119 bidi-display-reordering, not from buffer-local value. Use the
6120 buffer-local value only if initializing for buffer iteration.
6121 (handle_invisible_prop): Support invisible properties on strings
6122 that are being bidi-reordered.
6123 (set_iterator_to_next): Support bidi reordering of C strings and
6124 Lisp strings.
6125 (next_element_from_string): Support bidi reordering of Lisp
6126 strings.
6127 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6128 (display_string): Support display of R2L glyph rows.
6129 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6130 (init_iterator): Don't initialize it->bidi_p for strings
6131 here.
6132 (reseat_to_string): Initialize it->bidi_p for strings here.
6133 (next_element_from_string, next_element_from_c_string)
6134 (next_element_from_buffer): Add xassert's for correspondence
6135 between IT's object being iterated and it->bidi_it.string
6136 structure.
6137 (face_before_or_after_it_pos): Support bidi iteration.
6138 (next_element_from_c_string): Handle the case of the first string
6139 character that is not the first one in the visual order.
6140 (get_visually_first_element): New function, refactored from common
6141 parts of next_element_from_buffer, next_element_from_string, and
6142 next_element_from_c_string.
6143 (tool_bar_lines_needed, redisplay_tool_bar)
6144 (display_menu_bar): Force left-to-right direction. Add a FIXME
6145 comment for making that be controlled by a user option.
6146 (push_it, pop_it): Save and restore the state of the
6147 bidi iterator. Save and restore the bidi_p flag.
6148 (pop_it): Iterate out of display property for string iteration as
6149 well.
6150 (iterate_out_of_display_property): Support iteration over strings.
6151 (handle_single_display_spec): Set up it->bidi_it for iteration
6152 over a display string, and call bidi_init_it.
6153 (handle_single_display_spec, next_overlay_string)
6154 (get_overlay_strings_1, push_display_prop): Set up the bidi
6155 iterator for displaying display or overlay strings.
6156 (forward_to_next_line_start): Don't use the shortcut if
6157 bidi-iterating.
6158 (back_to_previous_visible_line_start): If handle_display_prop
6159 pushed the iterator stack, restore the internal state of the bidi
6160 iterator by calling bidi_pop_it same number of times.
6161 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6162 and we are bidi-iterating, don't decrement the iterator position;
6163 instead, set the first_elt flag in the bidi iterator, to produce
6164 the same effect.
6165 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6166 (push_display_prop): xassert that we are iterating a buffer.
6167 (push_it, pop_it): Save and restore paragraph_embedding member.
6168 (handle_single_display_spec, next_overlay_string)
6169 (get_overlay_strings_1, reseat_1, reseat_to_string)
6170 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6171 correctly. Don't assume unibyte strings are not bidi-reordered.
6172 (compute_display_string_pos)
6173 (compute_display_string_end): Fix handling the case of C string.
6174 (push_it, pop_it): Save and restore from_disp_prop_p.
6175 (handle_single_display_spec, push_display_prop): Set the
6176 from_disp_prop_p flag.
6177 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6178 (pop_it): Call iterate_out_of_display_property only if we are
6179 popping after iteration over a string that came from a display
6180 property. Fix a typo in popping stretch info. Add an assertion
6181 for verifying that the iterator position is in sync with the bidi
6182 iterator.
6183 (handle_single_display_spec, get_overlay_strings_1)
6184 (push_display_prop): Fix initialization of paragraph direction for
6185 string when that of the parent object is not yet determined.
6186 (reseat_1): Call bidi_init_it to resync the bidi
6187 iterator with IT's position. (Bug#7616)
6188 (find_row_edges): If ROW->start.pos gives position
6189 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6190 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6191 Reset the from_disp_prop_p flag.
6192 (SAVE_IT, RESTORE_IT): New macros.
6193 (pos_visible_p, face_before_or_after_it_pos)
6194 (back_to_previous_visible_line_start)
6195 (move_it_in_display_line_to, move_it_in_display_line)
6196 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6197 (try_scrolling, redisplay_window, display_line): Use them when
6198 saving a temporary copy of the iterator and restoring it back.
6199 (back_to_previous_visible_line_start, reseat_1)
6200 (init_iterator): Empty the bidi cache "stack".
6201 (move_it_in_display_line_to): If iterator ended up at
6202 EOL, but we never saw any buffer positions smaller than
6203 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6204 motion in bidi-reordered lines.
6205 (move_it_in_display_line_to): Record prev_method and prev_pos
6206 immediately before the call to set_iterator_to_next. Fixes cursor
6207 motion in bidi-reordered lines with stretch glyphs and strings
6208 displayed in margins. (Bug#8133) (Bug#8867)
6209 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6210 TO_CHARPOS.
640c8776
SM
6211 (pos_visible_p): Support positions in bidi-reordered lines.
6212 Save and restore bidi cache.
0bb23927
EZ
6213
6214 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6215 (bidi_paragraph_info): Delete unused struct.
6216 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6217 (bidi_cache_start): New variable.
6218 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6219 to zero.
6220 (bidi_cache_fetch_state, bidi_cache_search)
6221 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6222 (bidi_cache_find, bidi_peek_at_next_level)
6223 (bidi_level_of_next_char, bidi_find_other_level_edge)
6224 (bidi_move_to_visually_next): Compare cache index with
6225 bidi_cache_start rather than with zero.
6226 (bidi_fetch_char): Accept new argument STRING; all callers
6227 changed. Support iteration over a string. Support strings with
6228 display properties. Support unibyte strings. Fix the type of
6229 `len' according to what STRING_CHAR_AND_LENGTH expects.
6230 (bidi_paragraph_init, bidi_resolve_explicit_1)
6231 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6232 (bidi_level_of_next_char, bidi_move_to_visually_next):
6233 Support iteration over a string.
0bb23927
EZ
6234 (bidi_set_sor_type, bidi_resolve_explicit_1)
6235 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6236 can now be zero (for strings); special values 0 and -1 were
6237 changed to -1 and -2, respectively.
6238 (bidi_char_at_pos): New function.
6239 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6240 Call it instead of FETCH_MULTIBYTE_CHAR.
6241 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6242 initialized to valid values.
6243 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6244 values.
6245 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6246 the test for valid cached positions. Fix the logic for looking up
6247 the sentinel state in the cache. GCPRO the Lisp string we are
6248 iterating.
6249 (bidi_push_it, bidi_pop_it): New functions.
6250 (bidi_initialize): Initialize the bidi cache start stack pointer.
6251 (bidi_cache_ensure_space): New function, refactored from part of
6252 bidi_cache_iterator_state. Don't assume the required size is just
6253 one BIDI_CACHE_CHUNK away.
6254 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6255 (bidi_count_bytes, bidi_char_at_pos): New functions.
6256 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6257 always valid if bidi_cache_idx is valid.
6258 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6259 is valid if it's going to be used.
6260 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6261 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6262 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6263 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6264 (bidi_find_other_level_edge, bidi_cache_start_stack):
6265 All variables related to cache indices are now EMACS_INT.
c965adc5 6266
0bb23927
EZ
6267 * dispextern.h (struct bidi_string_data): New structure.
6268 (struct bidi_it): New member `string'. Make flag members be 1-bit
6269 fields, and put them last in the struct.
640c8776
SM
6270 (compute_display_string_pos, compute_display_string_end):
6271 Update prototypes.
0bb23927
EZ
6272 (bidi_push_it, bidi_pop_it): Add prototypes.
6273 (struct iterator_stack_entry): New members bidi_p,
6274 paragraph_embedding, and from_disp_prop_p.
6275 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6276 (bidi_shelve_cache, bidi_unshelve_cache):
6277 Declare prototypes.
0bb23927
EZ
6278
6279 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6280 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6281 and vector-like objects.
6282
6283 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6284 cache around display iteration.
6285
6286 * window.c (Fwindow_end, window_scroll_pixel_based)
6287 (displayed_window_lines, Frecenter): Save and restore the bidi
6288 cache around display iteration.
6289
3bbd2265
LMI
62902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6291
6292 * editfns.c (Fdelete_region): Clarify the use of the named
6293 parameters (bug#6788).
6294
adc47434
MR
62952011-07-14 Martin Rudalics <rudalics@gmx.at>
6296
6297 * indent.c (Fvertical_motion): Set and restore w->pointm when
6298 saving and restoring the window's buffer (Bug#9006).
6299
837c31f8
LMI
63002011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6301
6302 * editfns.c (Fstring_to_char): Clarify just what is returned
6303 (bug#6576). Text by Eli Zaretskii.
6304
ac389d0c
JB
63052011-07-13 Juanma Barranquero <lekktu@gmail.com>
6306
6307 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6308
0be0ce47
EZ
63092011-07-13 Eli Zaretskii <eliz@gnu.org>
6310
6311 * buffer.c (mmap_find): Fix a typo.
6312
cd18e7e3
JB
63132011-07-13 Johan Bockgård <bojohan@gnu.org>
6314
6315 Fix execution of x selection hooks.
6316 * xselect.c (Qx_lost_selection_functions)
6317 (Qx_sent_selection_functions): New vars.
6318 (syms_of_xselect): DEFSYM them.
6319 (x_handle_selection_request): Pass Qx_sent_selection_functions
6320 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6321 (x_handle_selection_clear,x_clear_frame_selections):
6322 Pass Qx_lost_selection_functions rather than
6323 Vx_lost_selection_functions to Frun_hook_with_args.
6324
47ea7f44
PE
63252011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6326
ac389d0c 6327 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6328 The old code sometimes used this field without initializing it.
6329
47ea7f44
PE
6330 * alloc.c (gc_sweep): Don't read past end of array.
6331 In theory, the old code could also have corrupted Emacs internals,
6332 though it'd be very unlikely.
6333
bc985c87
AS
63342011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6335
6336 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6337 argument. (Bug#4026)
bc985c87 6338
0cf34688
LMI
63392011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6340
b3dadd76
LMI
6341 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6342 key" (bug#4257).
6343
0cf34688
LMI
6344 * window.c (Fset_window_start): Doc fix (bug#4199).
6345 (Fset_window_hscroll): Ditto.
6346
270768cd
PE
63472011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6348
077e3dda 6349 Fix minor new problems caught by GCC 4.6.1.
270768cd 6350 * term.c (init_tty): Remove unused local.
490011a6 6351 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6352 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6353 not used otherwise.
270768cd 6354
b1f58454
CY
63552011-07-12 Chong Yidong <cyd@stupidchicken.com>
6356
6357 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6358
22b9578d
LMI
63592011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6360
6e70ab07
LMI
6361 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6362 are the mini-buffer and the echo area (bug#3320).
6363
22b9578d
LMI
6364 * term.c (init_tty): Remove support for supdup, c10 and perq
6365 terminals, which are no longer supported (bug#1482).
6366
8974cc9f
JB
63672011-07-10 Johan Bockgård <bojohan@gnu.org>
6368
6369 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6370
a560d974
JD
63712011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6372
6373 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6374 for non-popups (Bug#3642).
6375
1dae0f0a
AS
63762011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6377
268c2c36 6378 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6379 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6380 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6381 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6382 * data.c (fmod): Likewise.
6383 * dispnew.c (swap_glyphs_in_rows): Likewise.
6384 * emacs.c (memory_warning_signal): Likewise.
6385 * floatfns.c (float_error): Likewise.
6386 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6387 (otf_open, font_otf_capability, generate_otf_features)
6388 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6389 Likewise.
6390 * image.c (pbm_read_file): Likewise.
6391 * indent.c (string_display_width): Likewise.
6392 * intervals.c (check_for_interval, search_for_interval)
6393 (inc_interval_count, count_intervals, root_interval)
6394 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6395 * lread.c (defalias): Likewise.
268c2c36 6396 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6397 * regex.c (set_image_of_range_1, set_image_of_range)
6398 (regex_grow_registers): Likewise.
6399 * sysdep.c (strerror): Likewise.
6400 * termcap.c (valid_filename_p, tprint, main): Likewise.
6401 * tparam.c (main): Likewise.
6402 * unexhp9k800.c (run_time_remap, save_data_space)
6403 (update_file_ptrs, read_header, write_header, calculate_checksum)
6404 (copy_file, copy_rest, display_header): Likewise.
6405 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6406 Likewise.
6407 * xdisp.c (check_it): Likewise.
6408 * xfaces.c (register_color, unregister_color, unregister_colors):
6409 Likewise.
6410 * xfns.c (print_fontset_result): Likewise.
6411 * xrdb.c (member, fatal, main): Likewise.
6412
99033785
PE
64132011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6414
6415 Fix minor problems found by static checking (Bug#9031).
6416 * chartab.c (char_table_set_range, map_sub_char_table):
6417 Remove unused locals.
6418 (uniprop_table): Now static.
6419 * composite.c (_work_char): Remove unused static var.
6420
9cb2ac56
JB
64212011-07-09 Juanma Barranquero <lekktu@gmail.com>
6422
6423 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6424
f25661f0
JD
64252011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6426
6427 * gtkutil.c (qttip_cb): Remove code without function.
6428
8278c4fe
EZ
64292011-07-09 Eli Zaretskii <eliz@gnu.org>
6430
6431 * w32.c (pthread_sigmask): New stub.
6432
1692ae2d 64332011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6434
8a6ebd58 6435 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6436 sigprocmask is portable only for single-threaded applications, and
6437 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6438 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6439 (LIBES): Use it.
6440 * callproc.c (Fcall_process):
6441 * process.c (create_process):
6442 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6443 Use pthread_sigmask, not sigprocmask.
123403e4 6444
1b854618
JD
64452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6446
6447 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6448 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6449 wrong (Bug#8591).
6450
3fe4b549
JD
64512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6452
0ce7e563
JD
6453 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6454 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6455 (xg_hide_tooltip): Fix comment.
6456
3fe4b549
JD
6457 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6458 in registerServicesMenuSendTypes.
6459 (validRequestorForSendType): Don't check ns_return_types.
6460
6461 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6462 ns_return_type.
6463
5df75e47
JR
64642011-07-08 Jason Rumney <jasonr@gnu.org>
6465
22610910
JR
6466 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6467 SH_SHOW for hidden windows (Bug#5482).
6468
5df75e47
JR
6469 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6470 frame struct members of non-existent frames (Bug#6284).
6471
699c10bd
JD
64722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6473
4393663b
JD
6474 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6475 variable firstTime not needed on OSX >= 10.6.
6476 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6477 >= 10.5. Use setKnobProportion, setDoubleValue.
6478
6479 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6480 (MAC_OS_X_VERSION_10_5): Define if not defined.
6481 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6482 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6483 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6484
6485 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6486 cString and lossyCString on OSX >= 10.4
6487
58179cce 6488 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6489 sizeToFit on OSX >= 10.2.
6490
6491 * nsimage.m (allocInitFromFile): Don't use deprecated method
6492 bestRepresentationForDevice on OSX >= 10.6.
6493
6494 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6495 to avoid warning.
6496
6497 * emacs.c: Declare unexec_init_emacs_zone.
6498
a63e0781
JD
6499 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6500
699c10bd
JD
6501 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6502
6503 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6504 on svcsMenu (Bug#8842).
6505
6506 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6507 ns_return_types.
6508 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6509
6510 * nsterm.m (QUTF8_STRING): Declare.
6511 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6512 (validRequestorForSendType): Return type is (id).
6513 Change indexOfObjectIdenticalTo to indexOfObject.
6514 Check if we have local selection before returning self (Bug#8842).
6515 (writeSelectionToPasteboard): Put local selection into paste board
6516 if we have a local selection (Bug#8842).
6517 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6518
6519 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6520 (ns_get_local_selection): Declare.
6521
54e10184
LMI
65222011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6523
9888ff71
LMI
6524 * keymap.c (describe_map_tree): Don't insert a double newline at
6525 the end of the buffer (bug#1169) and return whether we inserted
6526 something.
6527
54e10184
LMI
6528 * callint.c (Fcall_interactively): Change "reading args" to
6529 "providing args" to try to clarify what it does (bug#1010).
6530
15fa4783
KH
65312011-07-07 Kenichi Handa <handa@m17n.org>
6532
6533 * composite.c (composition_compute_stop_pos): Ignore a static
6534 composition starting before CHARPOS (Bug#8915).
6535
6536 * xdisp.c (handle_composition_prop): Likewise.
6537
a8815b00
EZ
65382011-07-07 Eli Zaretskii <eliz@gnu.org>
6539
6540 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6541 (Bug#9015)
6542
ef7b981d 65432011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6544
6545 * character.h (unicode_category_t): New enum type.
6546
6547 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6548 (Qchar_code_property_table): New variable.
6549 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6550 (UNIPROP_COMPRESSED_FORM_P): New macros.
6551 (char_table_ascii): Uncompress the compressed values.
6552 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6553 Uncompress the compressed values.
ac389d0c 6554 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6555 (char_table_ref_and_range): Uncompress the compressed values.
6556 (sub_char_table_set): New arg is_uniprop. Callers changed.
6557 Uncompress the compressed values.
6558 (sub_char_table_set_range): Args changed. Callers changed.
6559 (char_table_set_range): Adjuted for the above change.
6560 (map_sub_char_table): Delete args default_val and parent. Add arg
6561 top. Give decoded values to a Lisp function.
640c8776 6562 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6563 values to a Lisp function. Gcpro more variables.
6564 (uniprop_table_uncompress)
6565 (uniprop_decode_value_run_length): New functions.
6566 (uniprop_decoder, uniprop_decoder_count): New variables.
6567 (uniprop_get_decoder, uniprop_encode_value_character)
6568 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6569 New functions.
6570 (uniprop_encoder, uniprop_encoder_count): New variables.
6571 (uniprop_get_encoder, uniprop_table)
6572 (Funicode_property_table_internal, Fget_unicode_property_internal)
6573 (Fput_unicode_property_internal): New functions.
6574 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6575 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6576 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6577 char-code-property-alist.
6578
640c8776 6579 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6580 Vunicode_category_table.
6581
640c8776 6582 * font.c (font_range): Adjust for the change of
c805dec0
KH
6583 Vunicode_category_table.
6584
76b397fb
DN
65852011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6586
6587 * m/iris4d.h: Remove file, move contents ...
6588 * s/irix6-5.h: ... here.
6589
22b4128e
PE
65902011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6591
6592 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6593 * alloc.c (mark_buffer):
6594 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6595 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6596 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6597 This isn't true in general, and it's particularly not true
6598 if Emacs is configured with --with-wide-int.
6599 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6600 New macros, used in the buffer.c change.
6601
869795d6
JD
66022011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6603
6604 * xsettings.c: Use both GConf and GSettings if both are available.
6605 (store_config_changed_event): Add comment.
6606 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6607 (store_tool_bar_style_changed): New functions.
5e617bc2 6608 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6609 (struct xsettings): Move font inside HAVE_XFT.
6610 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6611 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6612 Move inside HAVE_XFT.
640c8776 6613 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6614 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6615 also.
6616 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6617 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6618 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6619 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6620 (parse_settings): Move check for font inside HAVE_XFT.
6621 (read_settings, apply_xft_settings): Add comment.
6622 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6623 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6624 call store_font_name_changed.
6625 (xft_settings_event): Add comment.
6626 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6627 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6628 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6629 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6630 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6631 (xsettings_get_system_font, xsettings_get_system_normal_font):
6632 Add comment.
869795d6 6633
d8ed26bd
PE
66342011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6635
6636 Random fixes. E.g., (random) never returned negative values.
6637 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6638 subseconds part to the entropy, as that's a bit more random.
6639 Prefer signed to unsigned, since the signedness doesn't matter and
6640 in general we prefer signed. When given a limit, use a
6641 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6642 latter isn't right if USE_2_TAGS_FOR_INTS.
6643 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6644 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6645
cabf1cac
SM
66462011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6647
6648 * textprop.c (text_property_stickiness):
6649 Obey Vtext_property_default_nonsticky.
6650 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6651 * w32fns.c (syms_of_w32fns):
6652 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6653
6e9b2be9
PE
66542011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6655
6656 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6657 This is more efficient than Ffile_directory_p and avoids a minor race.
6658
90186c68
LMI
66592011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6660
7c301272
LMI
6661 * buffer.c (Foverlay_put): Say what the return value is
6662 (bug#7835).
6663
c4f2d8d4
LMI
6664 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6665 is a directory before asking whether to use the file name
6666 (bug#7564).
ad637907
LMI
6667 (barf_or_query_if_file_exists): Make the "File is a directory"
6668 error be more correct.
c4f2d8d4 6669
90186c68
LMI
6670 * fns.c (Frequire): Remove the mention of the .gz files, since
6671 that's installation-specific, but keep the mention of
6672 `get-load-suffixes'.
6673
da64016e
PE
66742011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6675
6676 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6677 Report string overflow if the output is too long.
6678
7d47b580
JB
66792011-07-04 Juanma Barranquero <lekktu@gmail.com>
6680
a555cb87
JB
6681 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6682 (syms_of_gnutls): Remove duplicate DEFSYM for
6683 Qgnutls_bootprop_verify_hostname_error, an error for
6684 Qgnutls_bootprop_verify_error (which is no longer used).
6685
7d47b580
JB
6686 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6687 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6688 Also (re)move comments that are misplaced or no longer relevant.
6689
1e49bfab
LMI
66902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6691
6692 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6693
1485f4c0
CY
66942011-07-03 Chong Yidong <cyd@stupidchicken.com>
6695
6696 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6697 and background color parameters if they have been changed.
6698
a9ab721e
LMI
66992011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6700
6701 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6702
cf7cff57
PE
67032011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6704
2e13213d
PE
6705 * xsettings.c (SYSTEM_FONT): Define only when used.
6706 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6707
cf7cff57
PE
6708 * keymap.c (access_keymap_1): Now static.
6709
7a8e04f7
CY
67102011-07-02 Chong Yidong <cyd@stupidchicken.com>
6711
6712 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6713 leave any prefix arg for the up event (Bug#1586).
6714
61352f62
LMI
67152011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6716
69bb1ef7
LMI
6717 * lread.c (syms_of_lread): Mention single symbols defined by
6718 `defvar' or `defconst' (bug#7154).
6719
61352f62 6720 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6721 (Frequire): Mention get-load-suffixes.
61352f62 6722
28545e04
MR
67232011-07-02 Martin Rudalics <rudalics@gmx.at>
6724
6725 * window.h (window): Remove clone_number slot.
6726 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6727 Remove.
6728 (make_parent_window, make_window, saved_window)
6729 (Fset_window_configuration, save_window_save): Don't deal with
6730 clone numbers.
6731 * buffer.c (Qclone_number): Remove declaration.
6732 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6733
3349e122
SM
67342011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6735
6736 Add multiple inheritance to keymaps.
6737 * keymap.c (Fmake_composed_keymap): New function.
6738 (Fset_keymap_parent): Simplify.
6739 (fix_submap_inheritance): Remove.
6740 (access_keymap_1): New function extracted from access_keymap to handle
6741 embedded parents and handle lists of maps.
6742 (access_keymap): Use it.
6743 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6744 (Fcopy_keymap): Handle embedded parents.
6745 (Fcommand_remapping, define_as_prefix): Simplify.
6746 (Fkey_binding): Simplify.
6747 (syms_of_keymap): Move minibuffer-local-completion-map,
6748 minibuffer-local-filename-completion-map,
6749 minibuffer-local-must-match-map, and
6750 minibuffer-local-filename-must-match-map to Elisp.
6751 (syms_of_keymap): Defsubr make-composed-keymap.
6752 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6753 (parse_menu_item): Trivial simplification.
6754
3279eb87
GM
67552011-07-01 Glenn Morris <rgm@gnu.org>
6756
6757 * Makefile.in (SETTINGS_LIBS): Fix typo.
6758
4550efdf
KI
67592011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6760
6761 * coding.c (Fencode_coding_string): Record the last coding system
6762 used, as the function doc string says (bug#8738).
6763
0949d2b6
JD
67642011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6765
6766 * xsettings.c (store_monospaced_changed): Take new font as arg and
6767 check for change against current_mono_font.
6768 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6769 (emacs_settings_constructor, emacs_settings_get_property)
6770 (emacs_settings_set_property, emacs_settings_class_init)
6771 (emacs_settings_init, gsettings_obj): Remove.
6772 (something_changedCB): New function for HAVE_GSETTINGS.
6773 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6774 with value as argument.
6775 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6776 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6777 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6778 "changed".
6779
6780 * xgselect.c: Add defined (HAVE_GSETTINGS).
6781 (xgselect_initialize): Ditto.
6782
6783 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6784 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6785 xg_select.
6786
bbc6b304
PE
67872011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6788
6789 * eval.c (struct backtrace): Simplify and port the data structure.
6790 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6791 signed bit field, as this assumption is not portable and it makes
6792 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6793 "char debug_on_exit : 1" as this is not portable either; instead,
6794 use the portable "unsigned int debug_on_exit : 1". Remove unused
6795 member evalargs. Remove obsolete comments about cc bombing out.
6796
9851bfc5
JD
67972011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6798
51bb811f 6799 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6800 Let HAVE_GSETTINGS override HAVE_GCONF.
6801 (store_monospaced_changed): New function.
6802 (EMACS_SETTINGS): A new type derived from GObject to handle
6803 GSettings notifications.
6804 (emacs_settings_constructor, emacs_settings_get_property)
6805 (emacs_settings_set_property, emacs_settings_class_init):
6806 New functions.
6807 (gsettings_client, gsettings_obj): New variables.
6808 (GSETTINGS_SCHEMA): New define.
6809 (something_changedCB): Call store_monospaced_changed.
6810 (init_gsettings): New function.
6811 (xsettings_initialize): Call init_gsettings.
6812 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6813 to NULL.
6814
640c8776 6815 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6816 GCONF_CFLAGS/LIBS.
6817
5386012d
MR
68182011-06-29 Martin Rudalics <rudalics@gmx.at>
6819
6820 * window.c (resize_root_window, grow_mini_window)
6821 (shrink_mini_window): Rename Qresize_root_window to
6822 Qwindow_resize_root_window and Qresize_root_window_vertically to
6823 Qwindow_resize_root_window_vertically.
6824
f13e0b08
PE
68252011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6826
6827 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6828
94515237
JB
68292011-06-27 Juanma Barranquero <lekktu@gmail.com>
6830
6831 * makefile.w32-in: Redesign dependencies so they reflect more
6832 clearly which files are directly included by each source file,
6833 and not through other includes.
6834
e43b6e43
MR
68352011-06-27 Martin Rudalics <rudalics@gmx.at>
6836
6837 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6838 (sort_overlays, overlay_strings): When an overlay's clone number
6839 matches the window's clone number process the overlay even if
6840 the overlay's window property doesn't match the current window.
6841
d68443dc
MR
6842 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6843 (Fwindow_hchild): Rename to Fwindow_left_child.
6844 (Fwindow_next): Rename to Fwindow_next_sibling.
6845 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6846 (resize_window_check): Rename to window_resize_check.
6847 (resize_window_apply): Rename to window_resize_apply.
6848 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6849 (Fdelete_other_windows_internal, resize_frame_windows)
6850 (Fsplit_window_internal, Fdelete_window_internal)
6851 (grow_mini_window, shrink_mini_window)
6852 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6853
c7e73be5
JD
68542011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6855
6856 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6857 (emacs_fixed_set_min_size): Remove.
6858 (emacs_fixed_new): Take frame as argument.
6859
6860 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6861 (_EmacsFixedPrivate): Remove minwidth/height.
6862 Add struct frame *f.
6863 (emacs_fixed_init): Initialize priv->f.
6864 (get_parent_class, emacs_fixed_set_min_size): Remove.
6865 (emacs_fixed_new): Set priv->f to argument.
6866 (emacs_fixed_get_preferred_width)
6867 (emacs_fixed_get_preferred_height): Use min_width/height from
6868 frames size_hint to set minimum and natural (Bug#8919).
6869 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6870 and use min_width/height from frames size_hint to set
6871 min_width/height (Bug#8919).
6872
6873 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6874 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6875 Fix indentation.
c7e73be5 6876
cf99dcf8
EZ
68772011-06-26 Eli Zaretskii <eliz@gnu.org>
6878
6879 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6880 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6881 called at ZV.
6882
029529ac
CY
68832011-06-26 Chong Yidong <cyd@stupidchicken.com>
6884
6885 * process.c (wait_reading_process_output): Bypass select if
6886 waiting for a cell while ignoring keyboard input, and input is
6887 pending. Suggested by Jan Djärv (Bug#8869).
6888
7a7ef429
PE
68892011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6890
6891 Use gnulib's dup2 module instead of rolling our own.
6892 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6893
11fdef7d 68942011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6895
6896 * dispnew.c (scrolling_window): Before scrolling, turn off a
6897 mouse-highlight in the window being scrolled.
6898
cd3520a4
JB
68992011-06-24 Juanma Barranquero <lekktu@gmail.com>
6900
6901 Move DEFSYM to lisp.h and use everywhere.
6902
6903 * character.h (DEFSYM): Move declaration...
6904 * lisp.h (DEFSYM): ...here.
6905
6906 * gnutls.c:
6907 * minibuf.c:
6908 * w32menu.c:
6909 * w32proc.c:
6910 * w32select.c: Don't include character.h.
6911
6912 * alloc.c (syms_of_alloc):
6913 * buffer.c (syms_of_buffer):
6914 * bytecode.c (syms_of_bytecode):
6915 * callint.c (syms_of_callint):
6916 * casefiddle.c (syms_of_casefiddle):
6917 * casetab.c (init_casetab_once):
6918 * category.c (init_category_once, syms_of_category):
6919 * ccl.c (syms_of_ccl):
6920 * cmds.c (syms_of_cmds):
6921 * composite.c (syms_of_composite):
6922 * dbusbind.c (syms_of_dbusbind):
6923 * dired.c (syms_of_dired):
6924 * dispnew.c (syms_of_display):
6925 * doc.c (syms_of_doc):
6926 * editfns.c (syms_of_editfns):
6927 * emacs.c (syms_of_emacs):
6928 * eval.c (syms_of_eval):
6929 * fileio.c (syms_of_fileio):
6930 * fns.c (syms_of_fns):
6931 * frame.c (syms_of_frame):
6932 * fringe.c (syms_of_fringe):
6933 * insdel.c (syms_of_insdel):
6934 * keymap.c (syms_of_keymap):
6935 * lread.c (init_obarray, syms_of_lread):
6936 * macros.c (syms_of_macros):
6937 * msdos.c (syms_of_msdos):
6938 * print.c (syms_of_print):
6939 * process.c (syms_of_process):
6940 * search.c (syms_of_search):
6941 * sound.c (syms_of_sound):
6942 * syntax.c (init_syntax_once, syms_of_syntax):
6943 * terminal.c (syms_of_terminal):
6944 * textprop.c (syms_of_textprop):
6945 * undo.c (syms_of_undo):
6946 * w32.c (globals_of_w32):
6947 * window.c (syms_of_window):
6948 * xdisp.c (syms_of_xdisp):
6949 * xfaces.c (syms_of_xfaces):
6950 * xfns.c (syms_of_xfns):
6951 * xmenu.c (syms_of_xmenu):
6952 * xsettings.c (syms_of_xsettings):
6953 * xterm.c (syms_of_xterm): Use DEFSYM.
6954
4228cf16
TZ
69552011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6956
cd3520a4 6957 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6958
7fcccf1e
PE
69592011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6960
7efb4e0e
PE
6961 Integer and buffer overflow fixes (Bug#8873).
6962
ff5844ad
PE
6963 * print.c (printchar, strout): Check for string overflow.
6964 (PRINTPREPARE, printchar, strout):
6965 Don't set size unless allocation succeeds.
6966
90532f02
PE
6967 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6968 for sizes. Check for string overflow more accurately.
6969 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6970
6d84508d
PE
6971 * macros.c: Integer and buffer overflow fixes.
6972 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6973 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6974 Use ptrdiff_t, not int, for sizes.
6975 Don't increment bufsize until after realloc succeeds.
6976 Check for size-calculation overflow.
6977 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6978
437b2cb4
PE
6979 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6980
8b9ac8b4
PE
6981 * lread.c: Integer overflow fixes.
6982 (read_integer): Radix is now EMACS_INT, not int,
6983 to improve quality of diagnostics for out-of-range radices.
6984 Calculate buffer size correctly for out-of-range radices.
6985 (read1): Check for integer overflow in radices, and in
6986 read-circle numbers.
82cb60d3
PE
6987 (read_escape): Avoid int overflow.
6988 (Fload, openp, read_buffer_size, read1)
6989 (substitute_object_recurse, read_vector, read_list, map_obarray):
6990 Use ptrdiff_t, not int, for sizes.
6991 (read1): Use EMACS_INT, not int, for sizes.
20270765 6992 Check for size overflow.
8b9ac8b4 6993
7fcccf1e
PE
6994 * image.c (cache_image): Check for size arithmetic overflow.
6995
bfbbd7e7
PE
6996 * lread.c: Integer overflow issues.
6997 (saved_doc_string_size, saved_doc_string_length)
6998 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6999 Now ptrdiff_t, not int.
7000 (read1): Don't assume doc string length fits in int. Check for
7001 out-of-range doc string lengths.
7002 (read_list): Don't assume file position fits in int.
39019e54 7003 (read_escape): Check for hex character overflow.
bfbbd7e7 7004
4e323265
LL
70052011-06-22 Leo Liu <sdl.web@gmail.com>
7006
7007 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7008 Move to minibuffer.el.
7009
85fece3e
PE
70102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7011
20b84ce9 7012 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7013 The following patches are for when GLYPH_DEBUG && !XASSERT.
7014 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7015 * dispnew.c (flush_stdout):
7016 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7017 Mark as externally visible.
7018 * dispnew.c (check_window_matrix_pointers): Now static.
7019 * dispnew.c (window_to_frame_vpos):
7020 * xfns.c (unwind_create_frame):
7021 * xterm.c (x_check_font): Remove unused local.
7022 * scroll.c (CHECK_BOUNDS):
7023 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7024 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7025 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7026 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7027 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7028 Now static.
7029 (debug_method_add): Use va_list and vsprintf rather than relying
7030 on undefined behavior with wrong number of arguments.
7031 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7032 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7033 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7034 since we're not interested in debugging glyphs with old libraries.
7035 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7036 GCC 4.6.0's static checking.
7037
0766b489
PE
70382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7039
31fd4b32
PE
7040 Integer overflow and signedness fixes (Bug#8873).
7041 A few related buffer overrun fixes, too.
7042
b79e8648
PE
7043 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7044
0766b489
PE
7045 * dispextern.h (struct face.stipple):
7046 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7047 (x_bitmap_mask, x_allocate_bitmap_record)
7048 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7049 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7050 (x_create_bitmap_from_xpm_data):
7051 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7052 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7053 (.bitmaps_last):
7054 * xfaces.c (load_pixmap):
7055 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7056 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7057 (.bitmaps_last, struct x_output.icon_bitmap):
7058 Use ptrdiff_t, not int, for bitmap indexes.
7059 (x_allocate_bitmap_record): Check for size overflow.
7060 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7061
b081724f
PE
7062 Use ptrdiff_t, not int, for overlay counts.
7063 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7064 * editfns.c (overlays_around, get_pos_property):
7065 * textprop.c (get_char_property_and_overlay):
7066 * xdisp.c (next_overlay_change, note_mouse_highlight):
7067 * xfaces.c (face_at_buffer_position):
21514da7
PE
7068 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7069 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7070 (Fnext_overlay_change, Fprevious_overlay_change)
7071 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7072 Use ptrdiff_t, not int, for sizes.
21514da7 7073 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7074
3de73e5e
PE
7075 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7076
2606c57b
PE
7077 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7078 (x_session_initialize): Do not assume string length fits in int.
7079
aaafe47a
PE
7080 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7081 This is unlikely, but can occur if DPI is outlandish.
7082
2674ddc8 7083 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7084 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7085
28154962
PE
7086 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7087 * xrdb.c (magic_file_p, search_magic_path):
7088 Omit last arg SUFFIX; it was always 0. All callers changed.
7089 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7090
7de51af5
PE
7091 * xfont.c (xfont_match): Avoid need for strlen.
7092
25ed6cc3
PE
7093 * xfns.c: Don't assume strlen fits in int.
7094 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7095
4eab31dd
PE
7096 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7097 not unsigned long, as we prefer signed integers. All callers changed.
7098 Detect integer overflow in repeat count.
7099 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7100 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7101
171e2a58
PE
7102 * termcap.c: Don't assume sizes fit in int and never overflow.
7103 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7104 (gobble_line): Check for size-calculation overflow.
7105
ad39faca 7106 * minibuf.c (Fread_buffer):
6e5bb2dc 7107 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7108 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7109 Don't assume string length fits in int.
7110
52c61c22 7111 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7112 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7113
b5b8c9e5
PE
7114 * font.c: Don't assume string length fits in int.
7115 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7116 Use ptrdiff_t, not int.
ccd6111c
PE
7117 (font_intern_prop): Don't assume string length fits in int.
7118 Don't assume integer property fits in fixnum.
7119 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7120
882f0d81 7121 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7122 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7123 Reformulate so as not to need the command string.
7124 Invoke gzip -cd rather than gunzip, as it's more portable.
7125 (lock_info_type, lock_file_1, lock_file):
7126 Don't assume pid_t and time_t fit in unsigned long.
7127 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7128 (current_lock_owner): Prefer signed type for sizes.
7129 Use memcpy, not strncpy, where memcpy is what is really wanted.
7130 Don't assume (via atoi) that time_t and pid_t fit in int.
7131 Check for time_t and/or pid_t out of range, e.g., via a network share.
7132 Don't alloca where an auto var works fine.
7133
93f4cf88
PE
7134 * fileio.c: Fix some integer overflow issues.
7135 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7136 Don't assume string length fits in int.
7137 (directory_file_name): Don't assume string length fits in long.
7138 (make_temp_name): Don't assume pid fits in int, or that its print
7139 length is less than 20.
7140
f3e92b69
PE
7141 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7142
1bfdaf10
PE
7143 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7144
35016e9a
PE
7145 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7146
3d1e65a1
PE
7147 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7148 We prefer signed integers, even for size calculations.
7149
0b963a93
PE
7150 * emacs.c: Don't assume string length fits in 'int'.
7151 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7152 (main): Don't invoke strlen when not needed.
7153
573f4b54
PE
7154 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7155 (XD_DEBUG_MESSAGE): Don't waste a byte.
7156
989f33ba
PE
7157 * callproc.c (getenv_internal_1, getenv_internal)
7158 (Fgetenv_internal):
965d34eb
PE
7159 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7160
e4d29b33
PE
7161 * lread.c (invalid_syntax): Omit length argument.
7162 All uses changed. This doesn't fix a bug, but it simplifies the
7163 code away from its former Hollerith-constant appearance, and it's
7164 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7165 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7166
eb49b136
PE
7167 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7168 This didn't break anything, but it didn't help either.
7169 It's confusing to put a bogus integer in a place where the actual
7170 value does not matter.
9f62aeb1 7171 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7172 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7173
15375a22
PE
7174 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7175 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7176 implementation.
b61cc01c
PE
7177 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7178 We prefer signed types, and the value cannot exceed the EMACS_INT
7179 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7180 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7181 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7182 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7183
53b2623d
PE
7184 * indent.c (sane_tab_width): New function.
7185 (current_column, scan_for_column, Findent_to, position_indentation)
7186 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7187 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7188
51cab52b 7189 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7190
f2ed8a70
PE
7191 * lisp.h (lint_assume): New macro.
7192 * composite.c (composition_gstring_put_cache):
7193 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7194
abe80cc6
PE
7195 * editfns.c, insdel.c:
7196 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7197
b02c740e
PE
7198 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7199
ebc96716
PE
7200 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7201
b4e50fa0 7202 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7203 Use much-faster test for byte-length change.
311d5d7c 7204 Don't assume string byte-length fits in 'int'.
a4cf38e4 7205 Check that character arg fits in 'int'.
85461888 7206 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7207
c0c1ee9f
PE
7208 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7209
a498d7f4
PE
7210 * fns.c (concat): Catch string overflow earlier.
7211 Do not rely on integer wraparound.
7212
51cab52b
PE
7213 * dispextern.h (struct it.overlay_strings_charpos)
7214 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7215 * xdisp.c (forward_to_next_line_start)
7216 (back_to_previous_visible_line_start)
7217 (reseat_at_next_visible_line_start, next_element_from_buffer):
7218 Don't arbitrarily truncate the value of 'selective' to int.
7219
76031fad
PE
7220 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7221
5eb55db9
PE
7222 * composite.c: Don't truncate sizes to 'int'.
7223 (composition_gstring_p, composition_reseat_it)
7224 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7225 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7226 not EMACS_UINT, for indexes.
5eb55db9 7227
0703a717
PE
7228 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7229
d6202519
PE
7230 * buffer.c: Include <verify.h>.
7231 (struct sortvec.priority, struct sortstr.priority):
8961a454 7232 Now EMACS_INT, not int.
c20998a7 7233 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7234 (struct sortstr.size, record_overlay_string)
7235 (struct sortstrlist.size, struct sortlist.used):
7236 Don't truncate size to int.
7237 (record_overlay_string): Check for size-calculation overflow.
d6202519 7238 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7239
d5a19415
JM
72402011-06-22 Jim Meyering <meyering@redhat.com>
7241
029529ac 7242 Don't leak an XBM-image-sized buffer
d5a19415
JM
7243 * image.c (xbm_load): Free the image buffer after using it.
7244
a9041e6c
PE
72452011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7246
7247 Port to Sun C.
7248 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7249 that Sun C diagnosed.
7250 * fns.c (secure_hash): Fix pointer signedness issue.
7251 * intervals.c (static_offset_intervals): New function.
7252 (offset_intervals): Use it.
7253
7f3f739f
LL
72542011-06-21 Leo Liu <sdl.web@gmail.com>
7255
7256 * deps.mk (fns.o):
7257 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7258 sha512.h.
7259
7260 * fns.c (secure_hash): Rename from crypto_hash_function and change
7261 the first arg to accept symbols.
5b66d427 7262 (Fsecure_hash): New primitive.
7f3f739f
LL
7263 (syms_of_fns): New symbols.
7264
76147d94
DD
72652011-06-20 Deniz Dogan <deniz@dogan.se>
7266
7267 * process.c (Fset_process_buffer): Clarify return value in
7268 docstring.
7269
7d7d0045
CY
72702011-06-18 Chong Yidong <cyd@stupidchicken.com>
7271
7272 * dispnew.c (add_window_display_history): Use BVAR.
7273
7274 * xdisp.c (debug_method_add): Use BVAR.
7275 (check_window_end, dump_glyph_matrix, dump_glyph)
7276 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7277
7278 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7279 Likewise.
7280
7281 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7282 check till after the cache is created in init_frame_faces.
7283
ff2bc410
SM
72842011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7285
7286 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7287
28177add
PE
72882011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7289
dd3482fe
PE
7290 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7291 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7292 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7293
393d71f3 7294 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7295 * fileio.c (Finsert_file_contents):
7296 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7297 Remove the old (too-loose) buffer overflow checks.
7298 They weren't needed, since make_gap checks for buffer overflow.
7299 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7300 The old code merely checked for Emacs fixnum overflow, and relied
7301 on undefined (wraparound) behavior. The new code avoids undefined
7302 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7303
2e6813b0 7304 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7305 Tune. Don't use wider integers than needed. Don't use alloca.
7306 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7307
599a9e4f
PE
7308 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7309
99561444
PE
7310 * insdel.c, lisp.h (buffer_overflow): New function.
7311 (insert_from_buffer_1, replace_range, replace_range_2):
7312 * insdel.c (make_gap_larger):
7313 * editfns.c (Finsert_char):
7314 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7315
28177add
PE
7316 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7317
e69dafad
PE
73182011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7319
4baa020d 7320 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7321
b1c46f02
PE
7322 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7323 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7324
e69dafad
PE
7325 * fileio.c: Don't assume EMACS_INT fits in off_t.
7326 (emacs_lseek): New static function.
7327 (Finsert_file_contents, Fwrite_region): Use it.
7328 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7329
566684ea
PE
7330 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7331
e6966cd6
PE
7332 * fns.c: Don't overflow int when computing a list length.
7333 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7334 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7335 truncation on 64-bit hosts. Check for QUIT every
7336 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7337 faster and is responsive enough.
7338 (Flength): Report an error instead of overflowing an integer.
7339 (Fsafe_length): Return a float if the value is not representable
7340 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7341 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7342 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7343
dd0b0efb
PE
7344 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7345 (header_size, word_size): New constants.
7346 (allocate_vectorlike): Don't check size overflow here.
7347 (allocate_vector): Check it here instead, since this is the only
7348 caller of allocate_vectorlike that could cause overflow.
7349 Check that the new vector's length is representable as a fixnum.
7350
86fe5cfe
PE
7351 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7352 The previous code was bogus. For example, next_almost_prime (32)
7353 returned 39, which is undesirable as it is a multiple of 3; and
7354 next_almost_prime (24) returned 25, which is a multiple of 5 so
7355 why was the code bothering to check for multiples of 7?
7356
80e88859
PE
7357 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7358
4a2f0ad6
PE
7359 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7360
f66c7cf8
PE
7361 Variadic C functions now count arguments with ptrdiff_t.
7362 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7363 Back then I didn't know that the Emacs coding style prefers signed int.
7364 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7365 were being counted with int, which may truncate counts on 64-bit
7366 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7367 * lisp.h (struct Lisp_Subr.function.aMANY)
7368 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7369 Arg counts are now ptrdiff_t, not size_t.
7370 All variadic functions and their callers changed accordingly.
7371 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7372 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7373 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7374 * callint.c (Fcall_interactively): Check arg count for overflow,
7375 to avoid potential buffer overrun. Use signed char, not 'int',
7376 for 'varies' array, so that we needn't bother to check its size
7377 calculation for overflow.
7378 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7379 * eval.c (apply_lambda):
7380 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7381 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7382 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7383
a1759b76
PE
7384 * callint.c (Fcall_interactively): Don't use index var as event count.
7385
d96be9fc
PE
7386 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7387 * mem-limits.h (SIZE): Remove; no longer used.
7388
a690a978 7389 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7390
578c21e6
PE
7391 Remove unnecessary casts.
7392 * xterm.c (x_term_init):
7393 * xfns.c (x_set_border_pixel):
7394 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7395 These aren't needed now that we assume ANSI C.
7396
96f53c6c
PE
7397 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7398 It's more likely to cause problems (due to unsigned overflow)
7399 than to cure them.
7400
83c77d31
PE
7401 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7402
ee2079f1
PE
7403 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7404
6da65536
PE
7405 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7406
7147c4a4
PE
7407 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7408
193e32d9
PE
7409 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7410
e5533da6
PE
7411 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7412
9910e595
PE
7413 GLYPH_CODE_FACE returns EMACS_INT, not int.
7414 * dispextern.h (merge_faces):
7415 * xfaces.c (merge_faces):
01103c44
PE
7416 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7417 Don't assume EMACS_INT fits in int.
9910e595 7418
2638320e
PE
7419 * character.h (CHAR_VALID_P): Remove unused parameter.
7420 * fontset.c, lisp.h, xdisp.c: All uses changed.
7421
045eb8d9
PE
7422 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7423
c1f134b5
PE
7424 * fns.c (concat): Minor tuning based on overflow analysis.
7425 This doesn't fix any bugs. Use int to hold character, instead
7426 of constantly refetching from Emacs object. Use XFASTINT, not
7427 XINT, for value known to be a character. Don't bother comparing
7428 a single byte to 0400, as it's always less.
7429
395fcb93 7430 * floatfns.c (Fexpt):
327eeec8
PE
7431 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7432
abbd3d23
PE
7433 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7434 for characters.
7435
684a03ef
PE
7436 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7437
0fed43f3
PE
7438 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7439 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7440 incorrectly succeed when S was a string, because 4294967386 was
7441 truncated before it was used.
7442
8fd02eb7
PE
7443 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7444 Otherwise, an out-of-range integer could cause undefined behavior
7445 on a 64-bit host.
7446
f8c86b69
PE
7447 * composite.c: Use int, not EMACS_INT, for characters.
7448 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7449 EMACS_INT, for values that are known to be in character range.
7450 This doesn't fix any bugs but is the usual style inside Emacs and
7451 may generate better code on 32-bit machines.
7452
34206dd2
PE
7453 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7454 This is for reasons similar to the recent CHAR_STRING fix.
7455 * charset.c (Fencode_char): Check that character arg is actually
7456 a character. Pass an int to ENCODE_CHAR.
7457 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7458 wider than 'int', as a compile-time check to prevent future regressions
7459 in this area.
7460
c5958d4c 7461 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7462
7463 Make sure a 64-bit char is never passed to CHAR_STRING.
7464 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7465 by silently ignoring the top 32 bits, allowing some values
7466 that were far too large to be valid characters.
7467 * character.h: Include <verify.h>.
7468 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7469 arguments are no wider than unsigned, as a compile-time check
7470 to prevent future regressions in this area.
7471 * data.c (Faset):
01103c44 7472 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7473 (Fsubst_char_in_region):
7474 * fns.c (concat):
7475 * xdisp.c (decode_mode_spec_coding):
7476 Adjust to CHAR_STRING's new requirement.
7477 * editfns.c (Finsert_char, Fsubst_char_in_region):
7478 * fns.c (concat): Check that character args are actually
7479 characters. Without this test, these functions did the wrong
7480 thing with wildly out-of-range values on 64-bit hosts.
7481
d37ca623
PE
7482 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7483 These casts should not be needed on 32-bit hosts, either.
7484 * keyboard.c (read_char):
7485 * lread.c (Fload): Remove casts to unsigned.
7486
ea204efb
PE
7487 * lisp.h (UNSIGNED_CMP): New macro.
7488 This fixes comparison bugs on 64-bit hosts.
7489 (ASCII_CHAR_P): Use it.
7490 * casefiddle.c (casify_object):
01103c44 7491 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7492 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7493 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7494 * dispextern.h (FACE_FROM_ID):
7495 * keyboard.c (read_char): Use UNSIGNED_CMP.
7496
41cb286c
PE
7497 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7498 not to EMACS_INT, to avoid GCC warning.
7499
4a1b9832
PE
7500 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7501
55daad71
PE
7502 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7503 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7504 isn't needed on 32-bit machines.
8f95c75c 7505
01103c44
PE
7506 * buffer.c (Fgenerate_new_buffer_name):
7507 Use EMACS_INT for count, not int.
0ceccced 7508 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7509
7510 * data.c (Qcompiled_function): Now static.
7511
c6f072e7
PE
7512 * window.c (window_body_lines): Now static.
7513
20ce5912
PE
7514 * image.c (gif_load): Rename local to avoid shadowing.
7515
9c4c5f81
PE
7516 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7517 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7518 * alloc.c (make_save_value): Integer argument is now of type
7519 ptrdiff_t, not int.
7520 (mark_object): Use ptrdiff_t, not int.
7521 * lisp.h (pD): New macro.
7522 * print.c (print_object): Use it.
7523
c0c5c8ae
PE
7524 * alloc.c: Use EMACS_INT, not int, to count objects.
7525 (total_conses, total_markers, total_symbols, total_vector_size)
7526 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7527 (total_free_floats, total_floats, total_free_intervals)
7528 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7529 Now EMACS_INT, not int. All uses changed.
7530 (Fgarbage_collect): Compute overall total using a double, so that
7531 integer overflow is less likely to be a problem. Check for overflow
7532 when converting back to an integer.
5a25e253
PE
7533 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7534 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7535 These were 'int' variables that could overflow on 64-bit hosts;
7536 they were never used, so remove them instead of repairing them.
211a0b2a 7537 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7538 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7539 Previously, this ceilinged at INT_MAX, but that doesn't work on
7540 64-bit machines.
e46bb31a 7541 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7542
c78baabf 7543 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7544 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7545 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7546 when a (possibly-narrower) signed value would do just as well.
7547 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7548
c9d624c6
PE
7549 * alloc.c: Catch some string size overflows that we were missing.
7550 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7551 for convenience in STRING_BYTES_MAX.
7552 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7553 The definition here is exact; the one in lisp.h was approximate.
7554 (allocate_string_data): Check for string overflow. This catches
7555 some instances we weren't catching before. Also, it catches
7556 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7557 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7558 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7559
c9d624c6
PE
7560 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7561 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7562 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7563
353032ce
PE
7564 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7565
2bccce07
PE
7566 * alloc.c (Fmake_string): Check for out-of-range init.
7567
0ac30604
SM
75682011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7569
7570 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7571
c195f2de
JD
75722011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7573
7574 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7575 xg_get_default_scrollbar_width.
7576
7577 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7578 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7579 (style_changed_cb): Call update_theme_scrollbar_width and call
7580 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7581 all frames (Bug#8505).
7582 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7583 Call gtk_window_set_resizable if HAVE_GTK3.
7584 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7585 and height if HAVE_GTK3 (Bug#8505).
7586 (scroll_bar_width_for_theme): New variable.
7587 (update_theme_scrollbar_width): New function.
7588 (xg_get_default_scrollbar_width): Move code to
7589 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7590 (xg_initialize): Call update_theme_scrollbar_width.
7591
7592 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7593
7594 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7595
e10ac9f1
MR
75962011-06-12 Martin Rudalics <rudalics@gmx.at>
7597
7598 * frame.c (make_frame): Call other_buffer_safely instead of
7599 other_buffer.
7600
7601 * window.c (temp_output_buffer_show): Call display_buffer with
7602 second argument Vtemp_buffer_show_specifiers and reset latter
7603 immediately after the call.
7604 (Vtemp_buffer_show_specifiers): New variable.
7605 (auto_window_vscroll_p, next_screen_context_lines)
7606 (Vscroll_preserve_screen_position): Remove leading asterisks from
7607 doc-strings.
7608
2d3c217e 76092011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7610
7b7f97e8 7611 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7612 * buffer.c (Qclone_number): Remove for now, as it's unused.
7613 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7614 (record_buffer): Remove unused local.
7615 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7616 (set_frame_buffer_list): Remove; unused.
7617 * frame.h (other_visible_frames): Remove decl.
7618 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7619 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7620 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7621 if HAVE_GPM.
7622 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7623 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7624 Define only if HAVE_GPM.
7625 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7626 (update_hints_inhibit): Remove; never set. All uses removed.
7627 * widgetprv.h (emacsFrameClassRec): Remove decl.
7628 * window.c (delete_deletable_window): Now returns void, since it
7629 wasn't returning anything.
7630 (compare_window_configurations): Remove unused locals.
7631 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7632 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7633 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7634 the same widths as pointers. This follows up on the 2011-05-06 patch.
7635 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7636 * xterm.h: Likewise.
7637 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7638
1384b89e
JB
76392011-06-12 Juanma Barranquero <lekktu@gmail.com>
7640
7641 * makefile.w32-in: Update dependencies.
7642 (LISP_H): Add lib/intprops.h.
7643
1100a63c
CY
76442011-06-11 Chong Yidong <cyd@stupidchicken.com>
7645
7646 * image.c (gif_load): Add animation frame delay to the metadata.
7647 (syms_of_image): Use DEFSYM. New symbol `delay'.
7648
6198ccd0
MR
76492011-06-11 Martin Rudalics <rudalics@gmx.at>
7650
7651 * window.c (delete_deletable_window): Re-add.
7652 (Fset_window_configuration): Rewrite to handle dead buffers and
7653 consequently deletable windows.
7654 (window_tree, Fwindow_tree): Remove. Supply functionality in
7655 window.el.
7656 (compare_window_configurations): Simplify code.
7657
b6e3633c
AS
76582011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7659
1ab0dee5
AS
7660 * image.c (imagemagick_load_image): Fix type mismatch.
7661 (Fimagemagick_types): Likewise.
7662
b6e3633c
AS
7663 * window.h (replace_buffer_in_windows): Declare.
7664
9397e56f
MR
76652011-06-11 Martin Rudalics <rudalics@gmx.at>
7666
7667 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7668 Qclone_number. Remove external declaration of Qdelete_window.
7669 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7670 code.
640c8776
SM
7671 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7672 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7673 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7674 buffer list implementation.
7675 (other_buffer_safely): New function.
7676 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7677 calls to replace_buffer_in_windows and
7678 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7679 if allowed.
7680 (record_buffer): Inhibit quitting and rewrite using quittable
7681 functions. Run Qbuffer_list_update_hook if allowed.
7682 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7683 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7684 Move switch-to-buffer to window.el.
9397e56f
MR
7685 (bury-buffer): Move to window.el.
7686 (Vbuffer_list_update_hook): New variable.
7687
7688 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7689 section.
7690
7691 * window.h (resize_frame_windows): Move up in code.
7692 (Fwindow_frame): Remove EXFUN.
7693 (replace_buffer_in_all_windows): Remove prototype.
7694 (replace_buffer_in_windows_safely): Add prototype.
7695
7696 * window.c: Declare Qdelete_window static again. Move down
7697 declaration of select_count.
7698 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7699 (Fother_window): Move to window.el.
7700 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7701 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7702 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7703 window.el.
7704 (replace_buffer_in_windows): Implement by calling
7705 Qreplace_buffer_in_windows.
7706 (replace_buffer_in_all_windows): Remove with some functionality
7707 moved into replace_buffer_in_windows_safely.
7708 (replace_buffer_in_windows_safely): New function.
7709 (select_window_norecord, select_frame_norecord): Move in front
7710 of run_window_configuration_change_hook. Remove now obsolete
7711 declarations.
640c8776
SM
7712 (Fset_window_buffer): Rewrite doc-string.
7713 Call Qrecord_window_buffer.
9397e56f
MR
7714 (keys_of_window): Move binding for other-window to window.el.
7715
b50691aa
CY
77162011-06-11 Chong Yidong <cyd@stupidchicken.com>
7717
7718 * dispextern.h (struct image): Replace data member, whose int_val
7719 and ptr_val fields were not used by anything, with a single
7720 lisp_val object.
7721
7722 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7723 (gif_clear_image, gif_load, imagemagick_load_image)
7724 (gs_clear_image, gs_load): Callers changed.
7725
3f754b86
PE
77262011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7727
cca69397
PE
7728 * buffer.h: Include <time.h>, for time_t.
7729 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7730
109e28d0
PE
7731 Fix minor problems found by static checking.
7732
60737f02
PE
7733 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7734
4b66faf3
PE
7735 Make identifiers static if they are not used in other modules.
7736 * data.c (Qcompiled_function, Qframe, Qvector):
7737 * image.c (QimageMagick, Qsvg):
7738 * minibuf.c (Qmetadata):
7739 * window.c (resize_window_check, resize_root_window): Now static.
7740 * window.h (resize_window_check, resize_root_window): Remove decls.
7741
109e28d0
PE
7742 * window.c (window_deletion_count, delete_deletable_window):
7743 Remove; unused.
46a4ce9e
PE
7744 (window_body_lines): Now static.
7745 (Fdelete_other_windows_internal): Mark vars as initialized.
7746 Make sure 'resize_failed' is initialized.
7747 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7748 (resize_window_apply): Remove unused local.
7749 * window.h (delete_deletable_window): Remove decl.
7750
109e28d0 7751 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7752 (imagemagick_load_image): Fix pointer signedness problem by changing
7753 last arg from unsigned char * to char *. All uses changed.
7754 Also, fix a local for similar reasons.
7755 Remove unused locals. Remove locals to avoid shadowing.
7756 (fn_rsvg_handle_free): Remove; unused.
7757 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7758 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7759
3f754b86
PE
7760 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7761
2547adb1
CY
77622011-06-10 Chong Yidong <cyd@stupidchicken.com>
7763
7764 * image.c (gif_load): Fix omitted cast error introduced by
7765 2011-06-06 change.
7766
2c8e37d4
MR
77672011-06-10 Martin Rudalics <rudalics@gmx.at>
7768
7769 * window.h (resize_proportionally, orig_total_lines)
7770 (orig_top_line): Remove from window structure.
7771 (set_window_height, set_window_width, change_window_heights)
7772 (Fdelete_window): Remove prototypes.
7773 (resize_frame_windows): Remove duplicate declaration.
7774
440a42e3
EZ
77752011-06-10 Eli Zaretskii <eliz@gnu.org>
7776
7777 * window.h (resize_frame_windows, resize_window_check)
7778 (delete_deletable_window, resize_root_window)
7779 (resize_frame_windows): Declare prototypes.
7780
7781 * window.c (resize_window_apply): Make definition be "static" to
7782 match the prototype.
7783
562dd5e9
MR
77842011-06-10 Martin Rudalics <rudalics@gmx.at>
7785
7786 * window.c: Remove declarations of Qwindow_size_fixed,
7787 window_min_size_1, window_min_size_2, window_min_size,
7788 size_window, window_fixed_size_p, enlarge_window, delete_window.
7789 Remove static from declaration of Qdelete_window, it's
7790 temporarily needed by Fbury_buffer.
7791 (replace_window): Don't assign orig_top_line and
7792 orig_total_lines.
7793 (Fdelete_window, delete_window): Remove. Window deletion is
7794 handled by window.el.
640c8776
SM
7795 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7796 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7797 (Fdelete_other_windows): Remove. Deleting other windows is
7798 handled by window.el.
7799 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7800 handled in window.el.
7801 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7802 Window minimum sizes are handled in window.el.
7803 (shrink_windows, size_window, set_window_height)
7804 (set_window_width, change_window_heights, window_height)
7805 (window_width, CURBEG, CURSIZE, enlarge_window)
7806 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7807 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7808 handled in window.el.
7809 (make_dummy_parent): Rename to make_parent_window and give it a
7810 second argument horflag.
7811 (make_window): Don't set resize_proportionally any more.
7812 (Fsplit_window): Remove. Windows are split in window.el.
7813 (save_restore_action, save_restore_orig_size)
7814 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7815 Resize mini windows in window.el.
7816 (grow_mini_window, shrink_mini_window): Implement by calling
7817 Qresize_root_window_vertically, resize_window_check and
7818 resize_window_apply.
640c8776
SM
7819 (saved_window, Fset_window_configuration, save_window_save):
7820 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7821 resize_proportionally.
7822 (window_min_height, window_min_width): Move to window.el.
7823 (keys_of_window): Move bindings for delete-other-windows,
7824 split-window, delete-window and enlarge-window to window.el.
7825
7826 * buffer.c: Temporarily extern Qdelete_window.
7827 (Fbury_buffer): Temporarily call Qdelete_window instead of
7828 Fdelete_window (Fbury_buffer will move to window.el soon).
7829
7830 * frame.c (set_menu_bar_lines_1): Remove code handling
7831 orig_top_line and orig_total_lines.
7832
7833 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7834 set_window_height but set heights directly.
7835 (change_frame_size_1): Use resize_frame_windows.
7836
7837 * xdisp.c (init_xdisp): Don't use set_window_height but set
7838 heights directly.
7839
640c8776
SM
7840 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7841 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7842 run_window_configuration_change_hook.
7843
7844 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7845 instead of change_window_heights and run
7846 run_window_configuration_change_hook.
7847
1a13852e
MR
78482011-06-09 Martin Rudalics <rudalics@gmx.at>
7849
7850 * window.c (replace_window): Rename second argument REPLACEMENT to
7851 NEW. New third argument SETFLAG. Rewrite.
7852 (delete_window, make_dummy_parent): Call replace_window with
7853 third argument 1.
7854 (window_list_1): Move down in code.
7855 (run_window_configuration_change_hook): Move set_buffer part
7856 before select_frame_norecord part in order to unwind correctly.
7857 Rename count1 to count.
7858 (recombine_windows, delete_deletable_window, resize_root_window)
7859 (Fdelete_other_windows_internal)
7860 (Frun_window_configuration_change_hook, make_parent_window)
7861 (resize_window_check, resize_window_apply, Fresize_window_apply)
7862 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7863 (Fdelete_window_internal, Fresize_mini_window_internal):
7864 New functions.
1a13852e
MR
7865 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7866
f3d1777e
MR
78672011-06-08 Martin Rudalics <rudalics@gmx.at>
7868
496e208e
MR
7869 * window.h (window): Add some new members to window structure -
7870 normal_lines, normal_cols, new_total, new_normal, clone_number,
7871 splits, nest, prev_buffers, next_buffers.
7872 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7873 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7874
f3d1777e
MR
7875 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7876 Remove.
496e208e
MR
7877 (make_dummy_parent): Set new members of windows structure.
7878 (make_window): Move down in code. Handle new members of window
7879 structure.
7880 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7881 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7882 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7883 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7884 (Fset_window_next_buffers, Fset_window_clone_number):
7885 New functions.
496e208e
MR
7886 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7887 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7888 Doc-string fixes.
7889 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7890 Argument WINDOW can be now internal window too.
7891 (Fwindow_use_time): Move up in code.
7892 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7893 Rewrite doc-string.
7894 (Fset_window_configuration, saved_window)
7895 (Fcurrent_window_configuration, save_window_save): Handle new
7896 members of window structure.
b9e809c2
MR
7897 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7898 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7899 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7900 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7901 Qget_mru_window, Qresize_root_window,
7902 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7903 Qauto_buffer_name; staticpro them.
f3d1777e 7904
abde8f8c
MR
79052011-06-07 Martin Rudalics <rudalics@gmx.at>
7906
7907 * window.c (Fwindow_total_size, Fwindow_left_column)
7908 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7909 (Fwindow_list_1): New functions.
7910 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7911 (Fwindow_width, Fscroll_left, Fscroll_right):
7912 Use window_body_cols instead of window_box_text_cols.
7913 (delete_window, Fset_window_configuration):
7914 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7915 (delete_all_subwindows): Take a window as argument and not a
7916 structure. Rewrite.
190b47e6
MR
7917 (window_loop): Remove handling of GET_LRU_WINDOW and
7918 GET_LARGEST_WINDOW.
7919 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7920
7921 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7922 window_box_text_cols. delete_all_subwindows now takes a
7923 Lisp_Object as argument.
abde8f8c 7924
640c8776
SM
7925 * indent.c (compute_motion, Fcompute_motion):
7926 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7927
fa8a67e6
MR
7928 * frame.c (delete_frame): Call delete_all_subwindows with root
7929 window as argument.
7930
a54e3482
DC
79312011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7932
7933 * fns.c (Fputhash): Document return value.
7934
60002bf5
CY
79352011-06-06 Chong Yidong <cyd@stupidchicken.com>
7936
7937 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7938
0c671da6 79392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7940
b862a52a 7941 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7942
be44ca6c
PE
7943 Check for overflow when converting integer to cons and back.
7944 * charset.c (Fdefine_charset_internal, Fdecode_char):
7945 Use cons_to_unsigned to catch overflow.
7946 (Fencode_char): Use INTEGER_TO_CONS.
7947 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7948 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7949 * data.c (long_to_cons, cons_to_long): Remove.
7950 (cons_to_unsigned, cons_to_signed): New functions.
7951 These signal an error for invalid or out-of-range values.
7952 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7953 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7954 * font.c (Ffont_variation_glyphs):
7955 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7956 * lisp.h: Include <intprops.h>.
7957 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7958 (cons_to_signed, cons_to_unsigned): New decls.
7959 (long_to_cons, cons_to_long): Remove decls.
7960 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7961 (Fprimitive_undo): Use CONS_TO_INTEGER.
7962 * xfns.c (Fx_window_property): Likewise.
7963 * xselect.c: Include <limits.h>.
7964 (x_own_selection, selection_data_to_lisp_data):
7965 Use INTEGER_TO_CONS.
7966 (x_handle_selection_request, x_handle_selection_clear)
7967 (x_get_foreign_selection, Fx_disown_selection_internal)
7968 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7969 (lisp_data_to_selection_data): Use cons_to_unsigned.
7970 (x_fill_property_data): Use cons_to_signed.
7971 Report values out of range.
7972
d1f3d2af
PE
7973 Check for buffer and string overflow more precisely.
7974 * buffer.h (BUF_BYTES_MAX): New macro.
7975 * lisp.h (STRING_BYTES_MAX): New macro.
7976 * alloc.c (Fmake_string):
7977 * character.c (string_escape_byte8):
7978 * coding.c (coding_alloc_by_realloc):
7979 * doprnt.c (doprnt):
7980 * editfns.c (Fformat):
7981 * eval.c (verror):
7982 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7983 since they may not be the same number.
7984 * editfns.c (Finsert_char):
7985 * fileio.c (Finsert_file_contents):
7986 Likewise for BUF_BYTES_MAX.
7987
dd52fcea
PE
7988 * image.c: Use ptrdiff_t, not int, for sizes.
7989 (slurp_file): Switch from int to ptrdiff_t.
7990 All uses changed.
7991 (slurp_file): Check that file size fits in both size_t (for
7992 malloc) and ptrdiff_t (for sanity and safety).
7993
7f9bbdbb
PE
7994 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7995 if b->modtime has its maximal value.
7996
dfe18f82
PE
7997 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7998
84acfcf0
PE
7999 Don't assume time_t can fit into int.
8000 * buffer.h (struct buffer.modtime): Now time_t, not int.
8001 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8002 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8003
ccd9a01a
PE
8004 Minor fixes for signed vs unsigned integers.
8005 * character.h (MAYBE_UNIFY_CHAR):
8006 * charset.c (maybe_unify_char):
8007 * keyboard.c (read_char, reorder_modifiers):
8008 XINT -> XFASTINT, since the integer must be nonnegative.
8009 * ftfont.c (ftfont_spec_pattern):
8010 * keymap.c (access_keymap, silly_event_symbol_error):
8011 XUINT -> XFASTINT, since the integer must be nonnegative.
8012 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8013 since it makes no difference and we prefer signed.
8014 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8015 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8016 nonnegative.
8017
d6d100dd
SM
80182011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8019
8020 * window.h (Fwindow_frame): Declare.
8021
2b6148e4
PE
80222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8023
8024 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8025 (SPARE_MEMORY): Always define.
8026 (LARGE_REQUEST): Remove.
8027 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8028
f230ecc9
MR
80292011-06-06 Martin Rudalics <rudalics@gmx.at>
8030
727e958e
MR
8031 * lisp.h: Move EXFUNS for Fframe_root_window,
8032 Fframe_first_window and Fset_frame_selected_window to window.h.
8033
8034 * window.h: Move EXFUNS for Fframe_root_window,
8035 Fframe_first_window and Fset_frame_selected_window here from
8036 lisp.h.
8037
8038 * frame.c (Fwindow_frame, Fframe_first_window)
8039 (Fframe_root_window, Fframe_selected_window)
8040 (Fset_frame_selected_window): Move to window.c.
8041 (Factive_minibuffer_window): Move to minibuf.c.
8042 (Fother_visible_frames_p): New function.
8043
8044 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8045
f230ecc9
MR
8046 * window.c (decode_window, decode_any_window): Move up in code.
8047 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8048 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8049 (Fwindow_buffer): Move up and rewrite doc-string.
8050 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8051 (Fwindow_prev): New functions.
727e958e
MR
8052 (Fwindow_frame): Move here from frame.c. Accept any window as
8053 argument.
8054 (Fframe_root_window, Fframe_first_window)
8055 (Fframe_selected_window): Move here from frame.c. Accept frame
8056 or arbitrary window as argument. Update doc-strings.
8057 (Fminibuffer_window): Move up in code.
8058 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8059 (Fset_frame_selected_window): Move here from frame.c.
8060 Marginal rewrite.
727e958e
MR
8061 (Fselected_window, select_window, Fselect_window): Move up in
8062 code. Minor doc-string fixes.
f230ecc9 8063
4d09bcf6
PE
80642011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8065
8066 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8067 Do not assume that spare memory exists; that assumption is valid
8068 only if SYSTEM_MALLOC.
8069 (LARGE_REQUEST): New macro, so that the issue of large requests
8070 is separated from the issue of spare memory.
8071
810928a2
AS
80722011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8073
172418ad
AS
8074 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8075 format. (Bug#8806)
8076
43f862f7
AS
8077 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8078
810928a2
AS
8079 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8080 before statements.
8081
a059fe24
JD
80822011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8083
8084 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8085
8086 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8087
8088 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8089 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8090
989bf368
JB
80912011-06-05 Juanma Barranquero <lekktu@gmail.com>
8092
8093 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8094
4b80f674
CY
80952011-06-04 Chong Yidong <cyd@stupidchicken.com>
8096
8097 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8098 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8099 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8100 New error handlers.
4b80f674
CY
8101 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8102 Obey Vx_select_enable_clipboard_manager. Catch errors in
8103 x_clipboard_manager_save (Bug#8779).
8104 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8105 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8106
99a33b77 81072011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8108
8109 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8110
99a33b77 81112011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8112
8113 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8114 in the current matrix if keep_current_p is non-zero.
8115
8264569d
EZ
81162011-06-04 Eli Zaretskii <eliz@gnu.org>
8117
8118 * bidi.c (bidi_level_of_next_char): Fix last change.
8119
57f97249
EZ
81202011-06-03 Eli Zaretskii <eliz@gnu.org>
8121
fec2107c 8122 Support bidi reordering of text covered by display properties.
57f97249 8123
fec2107c
EZ
8124 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8125 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8126 (bidi_cache_search, bidi_cache_iterator_state)
8127 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8128 (bidi_level_of_next_char, bidi_move_to_visually_next):
8129 Support character positions inside a run of characters covered by a
fec2107c
EZ
8130 display string.
8131 (bidi_paragraph_init, bidi_resolve_explicit_1)
8132 (bidi_level_of_next_char): Call bidi_fetch_char and
8133 bidi_fetch_char_advance instead of FETCH_CHAR and
8134 FETCH_CHAR_ADVANCE.
8135 (bidi_init_it): Initialize new members.
8136 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8137 definitions.
8138 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8139 instead of using explicit *_CHAR codes.
d6d100dd
SM
8140 (bidi_resolve_explicit, bidi_resolve_weak):
8141 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8142 bidirectional text is supported only in multibyte buffers.
8143 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8144 it to initialize the frame_window_p member of struct bidi_it.
8145 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8146 (bidi_resolve_explicit, bidi_resolve_weak)
8147 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8148 bidi_it->nchars is non-positive.
8149 (bidi_level_of_next_char): Don't try to lookup the cache for the
8150 next/previous character if nothing is cached there yet, or if we
8151 were just reseat()'ed to a new position.
c40e2fb2 8152
0e14fe90
EZ
8153 * xdisp.c (set_cursor_from_row): Set start and stop points
8154 according to the row's direction when priming the loop that looks
8155 for the glyph on which to display cursor.
8156 (single_display_spec_intangible_p): Function deleted.
8157 (display_prop_intangible_p): Reimplement to call
8158 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8159 Accept 3 additional arguments needed by handle_display_spec.
8160 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8161 values: lists, `(when COND...)' forms, etc.
8162 (single_display_spec_string_p): Support property values that are
8163 lists with the argument STRING its top-level element.
8164 (display_prop_string_p): Fix the condition for processing a
8165 property that is a list to be consistent with handle_display_spec.
fec2107c 8166 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8167 last portion of handle_display_prop.
8168 (compute_display_string_pos): Accept additional argument
8169 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8170 value of a `display' property is a "replacing spec".
8171 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8172 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8173 the display property, but just return a value indicating whether
8174 the display property will replace the characters it covers.
8175 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8176 frame_window_p members of struct bidi_it.
d6d100dd
SM
8177 (compute_display_string_pos, compute_display_string_end):
8178 New functions.
fec2107c
EZ
8179 (push_it): Accept second argument POSITION, where pop_it should
8180 jump to continue iteration.
8181 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8182
fec2107c
EZ
8183 * keyboard.c (adjust_point_for_property): Adjust the call to
8184 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8185
8186 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8187 (bidi_init_it): Update prototypes.
8188 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8189 (compute_display_string_pos, compute_display_string_end):
8190 Declare prototypes.
fec2107c
EZ
8191 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8192 EMACS_INT.
fc6f18ce 8193
40087514 81942011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8195
57f53182
PE
8196 Malloc failure behavior now depends on size of allocation.
8197 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8198 * lisp.h: Change signatures accordingly.
8199 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8200 All callers changed. (Bug#8762)
8201
8202 * gnutls.c: Use Emacs's memory allocators.
8203 Without this change, the gnutls library would invoke malloc etc.
8204 directly, which causes problems on non-SYNC_INPUT hosts, and which
8205 runs afoul of improving memory_full behavior. (Bug#8761)
8206 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8207 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8208 xfree instead of the default malloc, realloc, free.
8209 (Fgnutls_boot): No need to check for memory allocation failure,
8210 since xmalloc does that for us.
8211
ac32cd99 8212 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8213 * category.c (hash_get_category_set):
8214 * ccl.c (ccl_driver):
8215 * charset.c (Fdefine_charset_internal):
8216 * charset.h (struct charset.hash_index):
8217 * composite.c (get_composition_id, gstring_lookup_cache)
8218 (composition_gstring_put_cache):
8219 * composite.h (struct composition.hash_index):
8220 * dispextern.h (struct image.hash):
8221 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8222 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8223 (hashfn_equal, hashfn_user_defined, make_hash_table)
8224 (maybe_resize_hash_table, hash_lookup, hash_put)
8225 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8226 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8227 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8228 * image.c (make_image, search_image_cache, lookup_image)
8229 (xpm_put_color_table_h):
8230 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8231 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8232 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8233 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8234 * alloc.c (allocate_vectorlike):
8235 Check for overflow in vector size calculations.
8236 * ccl.c (ccl_driver):
8237 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8238 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8239 need to be updated by these changes.
40087514
PE
8240 * fns.c (make_hash_table, maybe_resize_hash_table):
8241 Check for integer overflow with large hash tables.
0de4bb68
PE
8242 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8243 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8244 (SXHASH_REDUCE): New macro.
8245 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8246 Use it instead of discarding useful hash info with large hash values.
8247 (sxhash_float): New function.
8248 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8249 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8250 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8251 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8252 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8253 Adjust signatures to match updated version of code.
8254 (consing_since_gc): Now EMACS_INT, since a single hash table can
8255 use more than INT_MAX bytes.
8256
698d32e2
DN
82572011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8258
8259 Make it possible to build with GCC-4.6+ -O2 -flto.
8260
8261 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8262
fd6fa53f
SM
82632011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8264
8265 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8266 Call minibuffer-inactive-mode.
8267
864db017
JB
82682011-05-31 Juanma Barranquero <lekktu@gmail.com>
8269
8270 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8271 Update dependencies.
8272
2ad0baf4
DN
82732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8274
8275 * data.c (init_data): Remove code for UTS, this system is not
8276 supported anymore.
8277
4fcc2638
DN
82782011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8279
8280 Don't force ./temacs to start in terminal mode.
8281
8282 * frame.c (make_initial_frame): Initialize faces in all cases, not
8283 only when CANNOT_DUMP is defined.
8284 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8285
c56e0fd5
DN
82862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8287
8288 * dispnew.c (add_window_display_history): Use const for the string
8289 pointer. Remove declaration, not needed.
8290
333d54da 82912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8292
55d4c1b2 8293 Use 'inline', not 'INLINE'.
333d54da 8294 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8295 * alloc.c, fontset.c (INLINE): Remove.
8296 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8297 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8298 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8299 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8300 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8301
738db178
DN
83022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8303
8304 Make it possible to run ./temacs.
8305
8306 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8307 syms_of_callproc does the same thing. Remove test for
8308 "initialized", do it in the caller.
8309 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8310
620c53a6
SM
83112011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8312
8313 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8314 (read_minibuf): Use get_minibuffer.
8315 (syms_of_minibuf): Use DEFSYM.
8316 (Qmetadata): New var.
8317 * data.c (Qbuffer): Don't make it static.
8318 (syms_of_data): Use DEFSYM.
8319
e003a292
PE
83202011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8321
8322 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8323 (CCL_CODE_MIN): New macro.
8324
ed008a6d
PE
83252011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8326
3687c2ef
PE
8327 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8328
ed008a6d
PE
8329 * eval.c (Qdebug): Now static.
8330 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8331 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8332 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8333
d66c4c7c
CY
83342011-05-29 Chong Yidong <cyd@stupidchicken.com>
8335
8336 * image.c: Various fixes to ImageMagick code comments.
8337 (Fimagemagick_types): Doc fix.
8338
5fbc2025
PE
83392011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8340
0196f88a
PE
8341 Minor fixes prompted by GCC 4.6.0 warnings.
8342
8343 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8344
5fbc2025
PE
8345 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8346 (x_clipboard_manager_save_all): Move extern decl to ...
8347 * xterm.h: ... here, so that it can be checked for consistency.
8348
1dd3c2d9
CY
83492011-05-29 Chong Yidong <cyd@stupidchicken.com>
8350
8351 * xselect.c (x_clipboard_manager_save_frame)
8352 (x_clipboard_manager_save_all): New functions.
8353 (Fx_clipboard_manager_save): Lisp function deleted.
8354
8355 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8356 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8357
8358 * xterm.h: Update prototype.
8359
5ba6571d
WX
83602011-05-28 William Xu <william.xwl@gmail.com>
8361
8362 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8363 exiting (Bug#8239).
8364
3eaff834
JM
83652011-05-28 Jim Meyering <meyering@redhat.com>
8366
e1900994 8367 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8368 * fns.c (to_uchar): Define.
8369 (crypto_hash_function): Use it to convert some newly-signed
8370 variables to unsigned, to avoid sign-extension bugs. For example,
8371 without this change, (md5 "truc") would evaluate to
8372 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8373 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8374 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8375
0f6990a7
PE
83762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8377
8378 Integer overflow fixes.
c8a9ca5a 8379
08686060
PE
8380 * dbusbind.c: Serial number integer overflow fixes.
8381 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8382 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8383 to hold a serial number that is too large for a fixnum.
8384 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8385 Check for serial numbers out of range. Decode any serial number
59568bf0 8386 that was so large that it became a float. (Bug#8722)
08686060 8387
2d1fc3c7
PE
8388 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8389 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8390 Use XFASTINT rather than XUINT when numbers are nonnegative.
8391 (xd_append_arg, Fdbus_method_return_internal):
8392 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8393 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8394 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8395 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8396 (Bug#8722)
2d1fc3c7 8397
c8a9ca5a
PE
8398 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8399
519e1d69
PE
8400 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8401
6df6ae42 8402 ccl: Add integer overflow checks.
30569699
PE
8403 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8404 (IN_INT_RANGE): New macros.
8405 (ccl_driver): Use them to check for integer overflow when
8406 decoding a CCL program. Many of the new checks are whether XINT (x)
8407 fits in int; it doesn't always, on 64-bit hosts. The new version
8408 doesn't catch all possible integer overflows, but it's an
847044ea 8409 improvement. (Bug#8719)
30569699 8410
c11285dc
PE
8411 * alloc.c (make_event_array): Use XINT, not XUINT.
8412 There's no need for unsigned here.
8413
fdccd48e
PE
8414 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8415 This follows up to the 2011-05-06 change that substituted uintptr_t
8416 for EMACS_INT. This case wasn't caught back then.
8417
37910ab2
PE
8418 Rework Fformat to avoid integer overflow issues.
8419 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8420 now (part of C89). Include <verify.h>.
8421 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8422 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8423 (Fformat): Avoid the prepass trying to compute sizes; it was only
8424 approximate and thus did not catch overflow reliably. Instead, walk
8425 through the format just once, formatting and computing sizes as we go,
8426 checking for integer overflow at every step, and allocating a larger
8427 buffer as needed. Keep track separately whether the format is
8428 multibyte. Keep only the most-recently calculated precision, rather
8429 than them all. Record whether each argument has been converted to
8430 string. Use EMACS_INT, not int, for byte and char and arg counts.
8431 Support field widths and precisions larger than INT_MAX. Avoid
8432 sprintf's undefined behavior with conversion specifications such as %#d
8433 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8434 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8435 formatting out-of-range floating point numbers with int
9173deec 8436 formats. (Bug#8668)
37910ab2 8437
2e6578fb
PE
8438 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8439
0ae6bdee
PE
8440 * data.c: Avoid integer truncation in expressions involving floats.
8441 * data.c: Include <intprops.h>.
8442 (arith_driver): When there's an integer overflow in an expression
8443 involving floating point, convert the integers to floating point
8444 so that the resulting value does not suffer from catastrophic
8445 integer truncation. For example, on a 64-bit host (* 4
8446 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8447 Do not rely on undefined behavior after integer overflow.
8448
de883a70
PE
8449 merge count_size_as_multibyte, parse_str_to_multibyte
8450 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8451 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8452 Check for integer overflow.
8453 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8454 since it's now a duplicate of the other. This is more of
8455 a character than a buffer op, so better that it's in character.c.
8456 * fns.c, print.c: Adjust to above changes.
8457
2ff916cb
PE
84582011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8459
8460 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8461
f1b54466
PE
84622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8463
fb1ac845
PE
8464 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8465 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8466 (x_clipboard_manager_save): Now static.
8467 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8468
f1b54466
PE
8469 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8470 (crypto_hash_function): Now static.
8471 Fix pointer signedness problems. Avoid unnecessary initializations.
8472
a9f737ee
CY
84732011-05-27 Chong Yidong <cyd@stupidchicken.com>
8474
8475 * termhooks.h (Vselection_alist): Make it terminal-local.
8476
8477 * terminal.c (create_terminal): Initialize it.
8478
8479 * xselect.c: Support for clipboard managers.
8480 (Vselection_alist): Move to termhooks.h as terminal-local var.
8481 (LOCAL_SELECTION): New macro.
8482 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8483 (symbol_to_x_atom): Remove gratuitous arg.
8484 (x_handle_selection_request, lisp_data_to_selection_data)
8485 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8486 (x_own_selection, x_get_local_selection, x_convert_selection):
8487 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8488 (some_frame_on_display): Delete unused function.
8489 (Fx_own_selection_internal, Fx_get_selection_internal)
8490 (Fx_disown_selection_internal, Fx_selection_owner_p)
8491 (Fx_selection_exists_p): New optional frame arg.
8492 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8493 (x_handle_selection_clear): Don't treat other terminals with the
8494 same keyboard specially. Use the terminal-local Vselection_alist.
8495 (x_clear_frame_selections): Use Frun_hook_with_args.
8496
8497 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8498
8499 * xterm.h: Add support for those atoms.
8500
e067f0c1
CY
85012011-05-26 Chong Yidong <cyd@stupidchicken.com>
8502
8503 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8504 (converted_selections, conversion_fail_tag): New global variables.
8505 (x_selection_request_lisp_error): Free the above.
8506 (x_get_local_selection): Remove unnecessary code.
8507 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8508 of converted selections stored in converted_selections.
8509 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8510 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8511 (x_convert_selection): New function.
8512 (x_handle_selection_event): Simplify.
8513 (x_get_foreign_selection): Don't ignore incoming requests while
8514 waiting for an answer; this will fail when we implement
8515 SAVE_TARGETS, and seems unnecessary anyway.
8516 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8517 (Vx_sent_selection_functions): Doc fix.
8518
0f4aebc0
LL
85192011-05-26 Leo Liu <sdl.web@gmail.com>
8520
8521 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8522
e61124cd
YM
85232011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8524
8525 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8526
8527 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8528 for fringe update if it has periodic bitmap.
ac389d0c 8529 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8530 and fringe_bitmap_periodic_p.
8531
8532 * fringe.c (get_fringe_bitmap_data): New function.
8533 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8534 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8535 row. Mark glyph row for fringe update if periodicity changed.
8536
8537 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8538 for fringe update unless it has periodic bitmap.
8539
f16d9837
KH
85402011-05-25 Kenichi Handa <handa@m17n.org>
8541
8542 * xdisp.c (get_next_display_element): Set correct it->face_id for
8543 a static composition.
8544
e1b90ef6
LL
85452011-05-24 Leo Liu <sdl.web@gmail.com>
8546
8547 * deps.mk (fns.o):
8548 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8549
8550 * fns.c (crypto_hash_function, Fsha1): New function.
8551 (Fmd5): Use crypto_hash_function.
8552 (syms_of_fns): Add Ssha1.
8553
7400048f
PE
85542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8555
8556 * gnutls.c: Remove unused macros.
8557 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8558 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8559 Remove macros that are defined and never used.
8560 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8561
abb71cf4
CY
85622011-05-22 Chong Yidong <cyd@stupidchicken.com>
8563
8564 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8565 (Fx_get_selection_internal): Minor cleanup.
8566 (Fx_own_selection_internal): Rename arguments for consistency with
8567 select.el.
8568
6307db39
PE
85692011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8570
8571 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8572
f3d4e0a4
CY
85732011-05-22 Chong Yidong <cyd@stupidchicken.com>
8574
8575 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8576
4d8ade89
YM
85772011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8578
8579 * dispnew.c (scrolling_window): Don't exclude the case that the
8580 last enabled row in the desired matrix touches the bottom boundary.
8581
32078c8d
GM
85822011-05-21 Glenn Morris <rgm@gnu.org>
8583
8584 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8585 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8586 and add some more files.
32078c8d 8587
7285dc67
EZ
85882011-05-20 Eli Zaretskii <eliz@gnu.org>
8589
8590 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8591 report_file_error introduced by the change from 2011-05-07.
8592
89d1bd22
PE
85932011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8594
8595 * systime.h (Time): Define only if emacs is defined.
8596 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8597 where the include path doesn't have X11/X.h by default. See
8598 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8599
cd394be1 86002011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8601
8602 * composite.c (find_automatic_composition): Fix previous change.
8603
b9704ad9
GM
86042011-05-20 Glenn Morris <rgm@gnu.org>
8605
8606 * lisp.mk: New file, split from Makefile.in.
8607 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8608 (shortlisp): Remove.
8609 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8610
4a720484
GM
86112011-05-19 Glenn Morris <rgm@gnu.org>
8612
8613 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8614 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8615 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8616 (lisp): Set the order to that of loadup.el.
8617 (shortlisp): Make it a copy of $lisp.
8618 (SOME_MACHINE_LISP): Remove.
8619 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8620 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8621
a28d4396
KH
86222011-05-18 Kenichi Handa <handa@m17n.org>
8623
8624 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8625 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8626 (find_automatic_composition): Mostly rewrite for efficiency.
8627
a2b1fa8e
JB
86282011-05-18 Juanma Barranquero <lekktu@gmail.com>
8629
8630 * makefile.w32-in: Update dependencies.
8631
8e1f5610
CS
86322011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8633
8634 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8635 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8636
7025ee00 86372011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8638
cdfa6eab
PE
8639 Fix some integer overflow issues, such as string length overflow.
8640
06d6db33
PE
8641 * insdel.c (count_size_as_multibyte): Check for string overflow.
8642
2b4560a8
PE
8643 * character.c (lisp_string_width): Check for string overflow.
8644 Use EMACS_INT, not int, for string indexes and lengths; in
8645 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8646 the resulting string length overflows an EMACS_INT; instead,
8647 report a string overflow if no precision given. When checking for
8648 precision exhaustion, use a check that cannot possibly have
8649 integer overflow. (Bug#8675)
8650 * character.h (lisp_string_width): Adjust to new signature.
8651
cb93f9be
PE
8652 * alloc.c (string_overflow): New function.
8653 (Fmake_string): Use it. This doesn't change behavior, but saves
8654 a few bytes and will simplify future changes.
8655 * character.c (string_escape_byte8): Likewise.
8656 * lisp.h (string_overflow): New decl.
8657
1a1f3366
PE
8658 Fixups, following up to the user-interface timestamp change.
8659 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8660 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8661 * msdos.c (mouse_get_pos): Likewise.
8662 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8663 * w32gui.h (Time): Define by including "systime.h" rather than by
8664 declaring it ourselves. (Bug#8664)
8665
d4e3e4d3
PE
8666 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8667 * image.c (clear_image_cache): Likewise.
8668
f6a24d19
PE
8669 * term.c (term_mouse_position): Don't assume time_t wraparound.
8670
08dc5ae6
PE
8671 Be more systematic about user-interface timestamps.
8672 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8673 and sometimes 'EMACS_UINT', to represent these timestamps.
8674 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8675 This makes the code easier to follow, and makes it easier to catch
8676 integer overflow bugs such as Bug#8664.
8677 * frame.c (Fmouse_position, Fmouse_pixel_position):
8678 Use Time, not unsigned long, for user-interface timestamps.
8679 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8680 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8681 * keyboard.h (last_event_timestamp): Likewise.
8682 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8683 * menu.h (xmenu_show): Likewise.
8684 * term.c (term_mouse_position): Likewise.
8685 * termhooks.h (struct input_event.timestamp): Likewise.
8686 (struct terminal.mouse_position_hook): Likewise.
8687 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8688 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8689 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8690 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8691 what it was before.
8692 * menu.h, termhooks.h: Include "systime.h", for Time.
8693
8e55734a
PE
8694 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8695 Don't assume that the difference between two unsigned long values
8696 can fit into an integer. At this point, we know button_down_time
8697 <= event->timestamp, so the difference must be nonnegative, so
8698 there's no need to cast the result if double-click-time is
8699 nonnegative, as it should be; check that it's nonnegative, just in
8700 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8701 apart (about 25 days). (Bug#8664)
8e55734a 8702
841f1b75 8703 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8704 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8705
3e26f69c
PE
8706 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8707 that always fit in int. Use a sentinel instead of a counter, to
8708 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8709 * frame.h (struct frame): Use int for menu_bar_items_used
8710 instead of EMACS_INT, since it always fits in int.
3e26f69c 8711
5cc152c0
PE
8712 * menu.c (grow_menu_items): Check for int overflow.
8713
d89eb65e
PE
8714 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8715
5235bd3e
PE
8716 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8717 Before, the code was not consistent. These values cannot exceed
8718 2**31 - 1 so there's no need to make them unsigned.
8719 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8720 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8721 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8722 as modifiers.
8723 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8724
bc827e23
PE
8725 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8726 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8727 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8728 presumably because the widths might not match.
8729
78eb494e
PE
8730 * window.c (size_window): Avoid needless test at loop start.
8731
04f2d78b
CB
87322011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8733
8734 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8735
d2fc7e3d 87362011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8737
8738 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8739
d2fc7e3d 87402011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8741
8742 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8743 `width' to `bar_area_x' and `bar_area_width', respectively.
8744 (x_scroll_run): Take account of fringe background extension.
8745
04f2d78b
CB
8746 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8747 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8748 `bar_area_width', respectively.
8749 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8750 background extension.
8751
79b70037
GM
87522011-05-10 Jim Meyering <meyering@redhat.com>
8753
8754 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8755
2f142cc5
JB
87562011-05-10 Juanma Barranquero <lekktu@gmail.com>
8757
8758 * image.c (Finit_image_library): Return t for built-in image types,
8759 like pbm and xbm. (Bug#8640)
8760
57679c86
AS
87612011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8762
8763 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8764
888c9e86
EZ
87652011-05-07 Eli Zaretskii <eliz@gnu.org>
8766
b0512a1d
EZ
8767 * w32console.c (Fset_screen_color): Doc fix.
8768 (Fget_screen_color): New function.
8769 (syms_of_ntterm): Defsubr it.
8770
7285dc67
EZ
8771 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8772 unlink the temporary file if Fcall_process didn't create it in the
8773 first place.
8774 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8775 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8776 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8777 cue to call_process_cleanup not to close that handle.
8778
4d3fcc8e
BK
87792011-05-07 Ben Key <bkey76@gmail.com>
8780
8781 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8782 one of two shell specific rules, either bootstrap-temacs-CMD or
8783 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8784 to the previous implementation of the bootstrap-temacs rule.
8785 The bootstrap-temacs-CMD rule is similar to the previous
8786 implementation of the bootstrap-temacs rule except that it
8787 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8788 variable.
8789
8790 These changes, along with some changes to nt/configure.bat,
8791 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8792 earlier fix to add support for --cflags and --ldflags options
8793 that include quotes so that it works whether make uses cmd or
8794 sh as the shell.
8795
b4289b64
MA
87962011-05-06 Michael Albinus <michael.albinus@gmx.de>
8797
8798 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8799 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8800 is a constant.
8801 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8802 a string. Handle both cases.
8803 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8804 (Fdbus_register_method): Use Qinvalid_function.
8805
af4c0e28
JB
88062011-05-06 Juanma Barranquero <lekktu@gmail.com>
8807
8808 * makefile.w32-in: Update dependencies.
8809 (LISP_H): Add inttypes.h and stdin.h.
8810 (PROCESS_H): Add unistd.h.
8811
c51453d9
EZ
88122011-05-06 Eli Zaretskii <eliz@gnu.org>
8813
8814 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8815 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8816
8ff0ac3c 88172011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8818
4c4b566b
PE
8819 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8820
aab2b9b5
PE
8821 * term.c (vfatal): Remove stray call to va_end.
8822 It's not needed and the C Standard doesn't allow it here anyway.
8823
c378da0b
PE
8824 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8825 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8826
288b08c7
PE
8827 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8828 bytes.
8829
e3601888
PE
8830 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8831
db6c0e74
PE
8832 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8833
dd5963ea
PE
8834 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8835
88c9450f
PE
8836 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8837
2f9442b8
PE
8838 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8839
c032b5f8
PE
8840 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8841 * charset.c (Fdefine_charset_internal): Don't initialize
8842 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8843 32-bit int (Bug#8600).
a108c10b
PE
8844
8845 * lread.c (read_integer): Be more consistent with string-to-number.
8846 Use string_to_number to do the actual conversion; this avoids
8847 rounding errors and fixes some other screwups. Without this fix,
8848 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8849 (digit_to_number): Move earlier, for benefit of read_integer.
8850 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8851 not a digit in any supported base. (Bug#8602)
a108c10b 8852
ad5f9eea
PE
8853 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8854
aec1708a
PE
8855 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8856 to match comment at start of function. This also removes a
8857 GCC warning about overflow in a 32+64-bit port.
8858
47be4ab5
PE
8859 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8860
371cac43
PE
8861 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8862 Reported by Stefan Monnier in
8863 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8864 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8865 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8866
d01a7826
PE
8867 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8868 (EMACS_UINTPTR): Likewise, with uintptr_t.
8869
7fd47d5c
PE
8870 * lisp.h: Prefer 64-bit EMACS_INT if available.
8871 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8872 on 32-bit hosts that have 64-bit int, so that they can access
8873 large files.
122b0c86
PE
8874 However, temporarily disable this change unless the temporary
8875 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8876
8727937b
PE
8877 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8878
8ac068ac
PE
8879 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8880 This removes an assumption that EMACS_INT and long are the same
8881 width as pointers. The assumption is true for Emacs porting targets
8882 now, but we want to make other targets possible.
8883 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8884 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8885 In the rest of the code, change types of integers that hold casted
8886 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8887 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8888 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8889 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8890 No need to cast type when ORing.
8891 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8892 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8893 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8894 assume EMACS_INT is the same width as char *.
8895 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8896 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8897 Remove no-longer-needed casts.
8898 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8899 (xg_tool_bar_help_callback, xg_make_tool_item):
8900 Use EMACS_INTPTR to hold an integer
8901 that will be cast to void *; this can avoid a GCC warning
8902 if EMACS_INT is not the same width as void *.
8903 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8904 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8905 (current_message_1, set_message_1):
8906 Use a local to convert to proper width without a cast.
8907 * xmenu.c (dialog_selection_callback): Likewise.
8908
ede49d71
PE
8909 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8910 Also, don't assume VALBITS / RAND_BITS is less than 5,
8911 and don't rely on undefined behavior when shifting a 1 left into
8912 the sign bit.
8913 * lisp.h (get_random): Change signature to match.
8914
2f30ecd0
PE
8915 * lread.c (hash_string): Use size_t, not int, for hash computation.
8916 Normally we prefer signed values; but hashing is special, because
8917 it's better to use unsigned division on hash table sizes so that
8918 the remainder is nonnegative. Also, size_t is the natural width
8919 for hashing into memory. The previous code used 'int', which doesn't
8920 retain enough info to hash well into very large tables.
8921 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8922
2a866e7b
PE
8923 * dbusbind.c: Don't possibly lose pointer info when converting.
8924 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8925 Use XPNTR rather than XHASH, so that the high-order bits of
8926 the pointer aren't lost when converting through void *.
8927
51639eac
PE
8928 * eval.c (Fautoload): Don't double-shift a pointer.
8929
92394119
PE
8930 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8931
dbdb9a7c
JB
89322011-05-06 Juanma Barranquero <lekktu@gmail.com>
8933
8934 * gnutls.c (DEF_GNUTLS_FN):
8935 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8936
db7a0b4f
AS
89372011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8938
8939 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8940 marker. (Bug#8610)
8941
cd394be1 89422011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8943
8944 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8945 New version that can reserve upto 2GB of heap space.
8946
f7ff1b0f 89472011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8948
8949 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8950
639c109b
TZ
89512011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8952
8953 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8954 `gnutls_certificate_set_x509_key_file'.
8955
d2127135
JB
89562011-05-05 Juanma Barranquero <lekktu@gmail.com>
8957
8958 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8959 Update dependencies.
8960
e968f4f3
JB
89612011-05-04 Juanma Barranquero <lekktu@gmail.com>
8962
8963 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8964 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8965 Remove unused parameter `fildes'.
8966 * process.c (read_process_output, send_process): Don't pass it.
8967
84d358f0
JB
89682011-05-04 Juanma Barranquero <lekktu@gmail.com>
8969
8970 Fix previous change: the library cache is defined in w32.c.
8971 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8972 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8973
0898ca10
JB
89742011-05-04 Juanma Barranquero <lekktu@gmail.com>
8975
8976 Implement dynamic loading of GnuTLS on Windows.
8977
8978 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8979 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8980 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8981 Declare.
8982
8983 * gnutls.c (Qgnutls_dll): Define.
8984 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8985 (gnutls_*): Declare function pointers.
8986 (init_gnutls_functions): New function to initialize function pointers.
8987 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8988 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8989 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8990 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8991 (emacs_gnutls_write, emacs_gnutls_read)
8992 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8993 (Fgnutls_available_p): New function.
8994 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8995 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8996 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8997
8998 * image.c: Include w32.h.
8999 (Vimage_type_cache): Delete.
9000 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9001 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9002 (w32_delayed_load): Move to w32.c.
9003
9004 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9005
9006 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9007 (w32_delayed_load): Move from image.c. When loading a library, record
9008 its filename in the :loaded-from property of the library id.
9009 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9010 Initialize and staticpro them.
9011 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9012
9013 * process.c: Include lisp.h before w32.h, not after.
9014 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9015 instead of gnutls_record_check_pending.
9016
9017 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9018
ff4de4aa
TZ
90192011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9020
9021 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9022 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9023 as passed in.
9024
abe95abb
JD
90252011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9026
9027 * xterm.c (x_set_frame_alpha): Do not set property on anything
9028 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9029
e16e55d4
JB
90302011-05-02 Juanma Barranquero <lekktu@gmail.com>
9031
9032 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9033
bafcf6a5
JB
90342011-05-02 Juanma Barranquero <lekktu@gmail.com>
9035
9036 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9037 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9038 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9039 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9040 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9041 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9042 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9043 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9044 (Qgnutls_bootprop_callbacks_verify): Make static.
9045
e7a6747f
AS
90462011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9047
19ed11ba
AS
9048 * callproc.c: Indentation fixup.
9049
e7a6747f 9050 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9051 (wait_for_termination, interruptible_wait_for_termination):
9052 Move after wait_for_termination_1.
e7a6747f 9053
1ef14cb4
LMI
90542011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9055
9056 * sysdep.c (interruptible_wait_for_termination): New function
9057 which is like wait_for_termination, but allows keyboard
9058 interruptions.
9059
9060 * callproc.c (Fcall_process): Add (:file "file") as an option for
9061 the STDOUT buffer.
9062 (Fcall_process_region): Ditto.
9063
330d880c
EZ
90642011-04-30 Eli Zaretskii <eliz@gnu.org>
9065
8db90b73
EZ
9066 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9067 rather than `XVECTOR (FOO)->size'.
9068
330d880c
EZ
9069 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9070 inttypes.h, as a gnulib replacement is used if it not available in
9071 system headers.
9072
15cbd324
EZ
90732011-04-21 Eli Zaretskii <eliz@gnu.org>
9074
9075 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9076 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9077 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9078
9079 * coding.c (coding_alloc_by_realloc): Error out if destination
9080 will grow beyond MOST_POSITIVE_FIXNUM.
9081 (decode_coding_emacs_mule): Abort if there isn't enough place in
9082 charbuf for the composition carryover bytes. Reserve an extra
9083 space for up to 2 characters produced in a loop.
9084 (decode_coding_iso_2022): Abort if there isn't enough place in
9085 charbuf for the composition carryover bytes.
9086
90872011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9088
ae940cca
EZ
9089 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9090 aborting when %lld or %lll format is passed.
9091 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9092 %llo or %llx format is passed. (Bug#8545)
9093
03ab8921
EZ
9094 * window.c (window_scroll_line_based): Use a marker instead of
9095 simple variables to record original value of point. (Bug#7952)
9096
afda1437
EZ
9097 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9098 produced by %s or %c overflows available buffer space. (Bug#8545)
9099
f76dee0c
PE
91002011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9101
9102 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9103 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9104
fdc5744d
JB
91052011-04-28 Juanma Barranquero <lekktu@gmail.com>
9106
9107 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9108
638f053a
JB
91092011-04-28 Juanma Barranquero <lekktu@gmail.com>
9110
9111 * keyboard.c (Qdelayed_warnings_hook): Define.
9112 (command_loop_1): Run `delayed-warnings-hook'
9113 if Vdelayed_warnings_list is non-nil.
9114 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9115 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9116
d178f871
EZ
91172011-04-28 Eli Zaretskii <eliz@gnu.org>
9118
9119 * doprnt.c (doprnt): Don't return value smaller than the buffer
9120 size if the message was truncated. (Bug#8545).
9121
b124fd93
JB
91222011-04-28 Juanma Barranquero <lekktu@gmail.com>
9123
9124 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9125 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9126
e810457d
PE
91272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9128
9129 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9130
ea51cceb
JB
91312011-04-27 Juanma Barranquero <lekktu@gmail.com>
9132
9133 * makefile.w32-in: Update dependencies.
9134
94dcfacf
EZ
91352011-04-27 Eli Zaretskii <eliz@gnu.org>
9136
9137 Improve `doprnt' and its usage. (Bug#8545)
9138 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9139 `format_end'. Remove support for %l as a conversion specifier.
9140 Don't use xrealloc. Improve diagnostics when the %l size modifier
9141 is used. Update the commentary.
9142
9143 * eval.c (verror): Simplify calculation of size_t.
9144
9145 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9146 messages.
9147
f61f41d7
PE
91482011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9149
9150 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9151 change.
9152
96fb4434
PE
91532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9154
9155 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9156 This makes this file independent of the recent pseudovector change.
9157
671875da 91582011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9159
69e9b5a3
PE
9160 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9161
b5f869a7 9162 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9163 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9164 Remove unused local.
c8926152 9165 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9166
841a1577 9167 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9168 GCC 4.6.0 optimizes based on type-based alias analysis.
9169 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9170 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9171 != &v->size, and therefore "v->size = 1; b->size = 2; return
9172 v->size;" must therefore return 1. This assumption is incorrect
9173 for Emacs, since it type-puns struct Lisp_Vector * with many other
9174 types. To fix this problem, this patch adds a new type struct
f904488f 9175 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9176 and pseudovectors, and helps optimizing compilers not get fooled
9177 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9178 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9179 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9180 the size member.
eab3844f
PE
9181 (XSETPVECTYPE): Rewrite in terms of new macro.
9182 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9183 This is a bit clearer, and further avoids the possibility of
9184 undesirable aliasing.
9185 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9186 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9187 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9188 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9189 (ASIZE): Now uses header.size rather than size.
9190 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9191 to avoid the hassle of writing XVECTOR (foo)->header.size.
9192 (struct vectorlike_header): New type.
eab3844f
PE
9193 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9194 object, to help avoid aliasing.
9195 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9196 (SUBRP): Likewise, since Lisp_Subr is a special case.
9197 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9198 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9199 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9200 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9201 changed to be "header.size" and "header.next".
9202 * buffer.h (struct buffer): Likewise.
9203 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9204 * frame.h (struct frame): Likewise.
9205 * process.h (struct Lisp_Process): Likewise.
9206 * termhooks.h (struct terminal): Likewise.
9207 * window.c (struct save_window_data, struct saved_window): Likewise.
9208 * window.h (struct window): Likewise.
9209 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9210 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9211 * buffer.c (init_buffer_once): Likewise.
9212 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9213 special case.
9214 * process.c (Fformat_network_address): Use local var for size,
9215 for brevity.
9216
0df1eac5
PE
9217 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9218
847ab9d1 9219 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9220 * data.c (atof): Remove decl; no longer used or needed.
9221 (digit_to_number): Move to lread.c.
9222 (Fstring_to_number): Use new string_to_number function, to be
9223 consistent with how the Lisp reader treats infinities and NaNs.
9224 Do not assume that floating-point numbers represent EMACS_INT
9225 without losing information; this is not true on most 64-bit hosts.
9226 Avoid double-rounding errors, by insisting on integers when
9227 parsing non-base-10 numbers, as the documentation specifies.
9228 * lisp.h (string_to_number): New decl, replacing ...
9229 (isfloat_string): Remove.
bc0a5c13 9230 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9231 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9232 appears to have been a coding error. Similarly, do not accept
9233 strings like +-1e0 as floating point numbers. Do not report
9234 overflow for integer overflows unless the base is not 10 which
9235 means we have no simple and reliable way to continue.
9236 Break out the floating-point parsing into a new
9237 function string_to_number, so that Fstring_to_number parses
9238 floating point numbers consistently with the Lisp reader.
04f2d78b 9239 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9240 (E_CHAR, EXP_INT): Remove, replacing with ...
9241 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9242 (string_to_number): New function, replacing isfloat_string.
9243 This function checks for valid syntax and produces the resulting
9244 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9245 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9246 so that overflow for non-base-10 numbers is reported only when
9247 there's no portable and simple way to convert to floating point.
452f4150 9248
67769ffc
PE
9249 * textprop.c (set_text_properties_1): Rewrite for clarity,
9250 and to avoid GCC warning about integer overflow.
9251
c20db43f
PE
9252 * intervals.h (struct interval): Use EMACS_INT for members
9253 where EMACS_UINT might cause problems. See
9254 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9255 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9256 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9257 All uses changed.
37aa2f85
PE
9258 (offset_intervals): Tell GCC not to worry about length overflow
9259 when negating a negative length.
c20db43f 9260
2538aa2f
PE
9261 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9262 (overrun_check_free): Likewise.
9263
f2d3008d
PE
9264 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9265 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9266 word size.
9267
ec8df744
PE
9268 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9269 (gnutls_make_error): Rename local to avoid shadowing.
9270 (gnutls_emacs_global_deinit): ifdef out; not used.
9271 (Fgnutls_boot): Use const for pointer to readonly storage.
9272 Comment out unused local. Fix pointer signedness problems.
9273
640ee02d
PE
9274 * lread.c (openp): Don't stuff size_t into an 'int'.
9275 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9276 about possible signed overflow.
9277
6048fb2a
PE
9278 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9279 (GDK_KEY_g): Don't define if already defined.
9280 (xg_prepare_tooltip): Avoid pointer signedness problem.
9281 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9282
fa3c87e1
PE
9283 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9284 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9285
2172544b
PE
9286 * xfns.c (Fx_window_property): Simplify a bit,
9287 to make a bit faster and to avoid GCC 4.6.0 warning.
9288 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9289
9b821a21
PE
9290 * fns.c (internal_equal): Don't assume size_t fits in int.
9291
3c616cfa
PE
9292 * alloc.c (compact_small_strings): Tighten assertion a little.
9293
c2982e87
PE
9294 Replace pEd with more-general pI, and fix some printf arg casts.
9295 * lisp.h (pI): New macro, generalizing old pEd macro to other
9296 conversion specifiers. For example, use "...%"pI"d..." rather
9297 than "...%"pEd"...".
9298 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9299 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9300 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9301 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9302 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9303 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9304 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9305 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9306 64-bit hosts.
9307 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9308 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9309 * print.c (safe_debug_print, print_object): Likewise.
9310 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9311 to int.
6f04d126
PE
9312 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9313 avoiding the 0 flag, which is not portable.
c2982e87
PE
9314 * process.c (Fmake_network_process): Use pI to avoid cast.
9315 * region-cache.c (pp_cache): Likewise.
9316 * xdisp.c (decode_mode_spec): Likewise.
9317 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9318 behavior on 64-bit hosts with printf arg.
6f04d126 9319 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9320 (x_stop_queuing_selection_requests): Likewise.
9321 (x_get_window_property): Don't truncate byte count to an 'int'
9322 when tracing.
0b432f21 9323
5e073ec7
PE
9324 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9325 here, since it parses constructs like leading '-' and spaces,
9326 which are not wanted; and it overflows with large numbers.
9327 Instead, simply match F[0-9]+, which is what is wanted anyway.
9328
36372bf9
PE
9329 * alloc.c: Remove unportable assumptions about struct layout.
9330 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9331 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9332 (allocate_vectorlike, make_pure_vector): Use the new macros,
9333 plus offsetof, to remove unportable assumptions about struct layout.
9334 These assumptions hold on all porting targets that I know of, but
9335 they are not guaranteed, they're easy to remove, and removing them
9336 makes further changes easier.
9337
0b432f21
PE
9338 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9339 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9340 (string_overrun_cookie): Now const. Use initializers that
9341 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9342 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9343 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9344 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9345 multiple of sizeof (EMACS_INT); it need not be, if
9346 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9347 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9348
895009e1
JB
93492011-04-26 Juanma Barranquero <lekktu@gmail.com>
9350
9351 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9352
6a7a1b0b
TZ
93532011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9354
9355 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9356 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9357 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9358
841a1577 93592011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9360
9361 * lisp.h (Qdebug): List symbol.
895009e1 9362 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9363 * keyboard.c (debug-on-event): New variable.
9364 (handle_user_signal): Break into debugger when debug-on-event
9365 matches the current signal symbol.
9366
f2d3ba6f
DN
93672011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9368
9369 * alloc.c (check_sblock, check_string_bytes)
9370 (check_string_free_list): Convert to standard C.
9371
42ce4c63
TZ
93722011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9373
9374 * w32.c (emacs_gnutls_push): Fix typo.
9375
825cd63c
EZ
93762011-04-25 Eli Zaretskii <eliz@gnu.org>
9377
fb11d64d
EZ
9378 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9379 "cast to pointer from integer of different size".
9380
825cd63c
EZ
9381 Improve doprnt and its use in verror. (Bug#8545)
9382 * doprnt.c (doprnt): Document the set of format control sequences
9383 supported by the function. Use SAFE_ALLOCA instead of always
9384 using `alloca'.
9385
9386 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9387 is one byte too soon. Don't use xrealloc; instead xfree and
9388 xmalloc anew.
9389
e061a11b
TZ
93902011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9391
9392 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9393 callbacks stage.
9394
9395 * gnutls.c: Renamed global_initialized to
9396 gnutls_global_initialized. Added internals for the
9397 :verify-hostname-error, :verify-error, and :verify-flags
9398 parameters of `gnutls-boot' and documented those parameters in the
9399 docstring. Start callback support.
9173deec
JB
9400 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9401 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9402 on error. Return error code.
e061a11b
TZ
9403 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9404 (emacs_gnutls_read): Likewise.
9405 (Fgnutls_boot): Return handshake error code.
9406 (emacs_gnutls_handle_error): New function.
9407 (wsaerror_to_errno): Likewise.
9408
9409 * w32.h (emacs_gnutls_pull): Add prototype.
9410 (emacs_gnutls_push): Likewise.
9411
9412 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9413 (emacs_gnutls_push): Likewise.
9414
94152011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9416
9417 * process.c (wait_reading_process_output): Check if GnuTLS
9418 buffered some data internally if no FDs are set for TLS
9419 connections.
9420
9421 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9422 (LIBS): Link to USER_LIBS.
9423 ($(BLD)/gnutls.$(0)): New target.
9424
fa6996bc
EZ
94252011-04-24 Eli Zaretskii <eliz@gnu.org>
9426
eb35682e
EZ
9427 * xdisp.c (handle_single_display_spec): Rename the
9428 display_replaced_before_p argument into display_replaced_p, to
9429 make it consistent with the commentary. Fix typos in the
9430 commentary.
9431
e2ad650c
EZ
9432 * textprop.c (syms_of_textprop): Remove dead code.
9433 (copy_text_properties): Delete obsolete commentary about an
9434 interface that was deleted long ago. Fix typos in the description
9435 of arguments.
9436
1b2de274
EZ
9437 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9438 to changes in oldXMenu/XMenu.h from 2011-04-16.
9439 <menu_help_message, prev_menu_help_message>: Constify.
9440 (IT_menu_make_room): menu->help_text is now `const char **';
9441 adjust.
9442
9443 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9444 to changes in oldXMenu/XMenu.h from 2011-04-16.
9445 (struct XMenu): Declare `help_text' `const char **'.
9446
9447 * xfaces.c <Qunspecified>: Make extern again.
9448
9449 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9450 required by POSIX.
1b2de274 9451
762b15be
EZ
9452 * doc.c (get_doc_string): Improve the format passed to `error'.
9453
9454 * doprnt.c (doprnt): Improve commentary.
9455
9456 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9457
9458 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9459 them with etags.
9460
f1052e5d
EZ
9461 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9462 changes in globals.h immediately force recompilation.
762b15be
EZ
9463 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9464 $(CURDIR)/s/ms-w32.h.
9465 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9466
fa6996bc
EZ
9467 * character.c (Fchar_direction): Function deleted.
9468 (syms_of_character): Don't defsubr it.
9469 <char-direction-table>: Deleted.
9470
e6c3da20
EZ
94712011-04-23 Eli Zaretskii <eliz@gnu.org>
9472
9473 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9474 * doprnt.c: Include limits.h.
9475 (SIZE_MAX): New macro.
04f2d78b
CB
9476 (doprnt): Return a size_t value. 2nd arg is now size_t.
9477 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9478 Improve overflow protection. Support `l' modifier for integer
9479 conversions. Support %l conversion. Don't assume an EMACS_INT
9480 argument for integer conversions and for %c.
9481
9482 * lisp.h (doprnt): Restore prototype.
9483
9484 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9485 $(SRC)/character.h.
9486
9487 * Makefile.in (base_obj): Add back doprnt.o.
9488
9489 * deps.mk (doprnt.o): Add back prerequisites.
9490 (callint.o): Depend on character.h.
9491
9492 * eval.c (internal_lisp_condition_case): Include the handler
9493 representation in the error message.
9494 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9495 when breaking from the loop.
9496
9497 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9498
9499 * callint.c (Fcall_interactively): When displaying error message
9500 about invalid control letter, pass the character's codepoint, not
9501 a pointer to its multibyte form. Improve display of the character
9502 in octal and display also its hex code.
9503
9504 * character.c (char_string): Use %x to display the (unsigned)
9505 codepoint of an invalid character, to avoid displaying a bogus
9506 negative value.
9507
9508 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9509 `error', not SYMBOL_NAME itself.
9510
9511 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9512 character arguments to `error'.
9513
9514 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9515 to `error' in error message about FINAL_CHAR argument. Make sure
9516 FINAL_CHAR is a character, and use %c when it is passed as
9517 argument to `error'.
9518
4ffd0d6b 95192011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9520
9521 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9522
9523 * w32.c: Include <time.h>.
9524 (sys_localtime): New function.
9525
4ffd0d6b 95262011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9527
9528 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9529
4ffd0d6b 9530 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9531
4ffd0d6b 95322011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9533
4ffd0d6b
GM
9534 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9535 zombies (Bug#8467).
aac0c6e3 9536
04c56954
EZ
95372011-04-19 Eli Zaretskii <eliz@gnu.org>
9538
9539 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9540 gl_state.e_property when gl_state.object is Qt.
9541
9542 * insdel.c (make_gap_larger): Remove limitation of buffer size
9543 to <= INT_MAX.
9544
16a43933
CY
95452011-04-18 Chong Yidong <cyd@stupidchicken.com>
9546
9547 * xdisp.c (lookup_glyphless_char_display)
9548 (produce_glyphless_glyph): Handle cons cell entry in
9549 glyphless-char-display.
9550 (Vglyphless_char_display): Document it.
9551
9552 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9553 glyphless-char-display.
9554
4581706e
CY
95552011-04-17 Chong Yidong <cyd@stupidchicken.com>
9556
9557 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9558
9559 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9560
9561 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9562 definition for no-X builds.
9563
4887c6e2 95642011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9565
fd35b6f9
PE
9566 Static checks with GCC 4.6.0 and non-default toolkits.
9567
5c1ccb01
PE
9568 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9569
006c5daa
PE
9570 * process.c (keyboard_bit_set): Define only if SIGIO.
9571 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9572 (send_process): Repair possible setjmp clobbering.
9573
efc736d3
PE
9574 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9575
4e2fe2e6
PE
9576 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9577
f97334a2
PE
9578 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9579
4e75f29d
PE
9580 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9581 Define only if needed.
9582
90efadd1
PE
9583 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9584 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9585 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9586
3c647824
PE
9587 * dispextern.h (struct redisplay_interface): Rename param
9588 to avoid shadowing.
e264f262 9589 * termhooks.h (struct terminal): Likewise.
761383f4 9590 * xterm.c (xembed_send_message): Likewise.
3c647824 9591
b58c5c4a
PE
9592 * insdel.c (make_gap_smaller): Define only if
9593 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9594
cad59032
PE
9595 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9596 it.
9597
c339dc2e
PE
9598 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9599 so that we aren't warned about unused symbols.
9600
91a3e27b
PE
9601 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9602
399c71d3 9603 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9604
8ffc96f5
PE
9605 * xfns.c (x_real_positions): Mark locals as initialized.
9606
eef9bc79
PE
9607 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9608
098db9dd
PE
9609 * xterm.c: Fix problems found by static analysis with other toolkits.
9610 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9611 (x_dispatch_event): Declare static if USE_GTK, and
9612 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9613 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9614 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9615 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9616 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9617
eb18f6cc
PE
9618 * xmenu.c (menu_help_callback): Pointer type fixes.
9619 Use const pointers when pointing at readonly data. Avoid pointer
9620 signedness clashes.
9621 (FALSE): Remove unused macro.
9622 (update_frame_menubar): Remove unused decl.
9623
1fe72bf8
PE
9624 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9625
60d9e1db
PE
9626 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9627 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9628 (single_menu_item): Rename local to avoid shadowing.
9629
39261c26
PE
9630 * keyboard.c (make_lispy_event): Remove unused local var.
9631
018c5e19
PE
9632 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9633 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9634
63d2b86e
PE
9635 * bitmaps: Change bitmaps from unsigned char back to the X11
9636 compatible char. Avoid the old compiler warnings about
9637 out-of-range initializers by using, for example, '\xab' rather
9638 than 0xab.
9639
aefd87e1
PE
9640 * xgselect.c (xgselect_initialize): Check vs interface
9641 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9642
bf501fb9
PE
9643 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9644
e9829fdf
PE
9645 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9646 to read-only memory.
9647
1086c095
PE
9648 * fns.c (vector): Remove; this old hack is no longer needed.
9649
2baccd04 9650 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9651 Remove unused var.
dde42981 9652 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9653
72391843 9654 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9655
436c16df 9656 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9657 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9658 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9659
92bb796d 9660 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9661 (x_term_init): Remove local to avoid shadowing.
92bb796d 9662
764430a3 9663 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9664
9665 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9666 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9667
d1dfb56c
EZ
96682011-04-16 Eli Zaretskii <eliz@gnu.org>
9669
c4354cb4
EZ
9670 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9671
d1dfb56c
EZ
9672 Fix regex.c, syntax.c and friends for buffers > 2GB.
9673 * syntax.h (struct gl_state_s): Declare character position members
9674 EMACS_INT.
9675
9676 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9677
04f2d78b
CB
9678 * textprop.c (verify_interval_modification, interval_of):
9679 Declare arguments EMACS_INT.
d1dfb56c
EZ
9680
9681 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9682 EMACS_INT.
9683
9684 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9685
9686 * indent.c (Fvertical_motion): Local variable it_start is now
9687 EMACS_INT.
9688
9689 * regex.c (re_match, re_match_2, re_match_2_internal)
9690 (bcmp_translate, regcomp, regexec, print_double_string)
9691 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9692 (re_compile_pattern, re_exec): Declare arguments and local
9693 variables `size_t' and `ssize_t' and return values `regoff_t', as
9694 appropriate.
9695 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9696 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9697 <compile_stack_type>: `size' and `avail' are now `size_t'.
9698
9699 * regex.h <regoff_t>: Use ssize_t, not int.
9700 (re_search, re_search_2, re_match, re_match_2): Arguments that
9701 specify buffer/string position and length are now ssize_t and
9702 size_t. Return type is regoff_t.
9703
613052cd
BK
97042011-04-16 Ben Key <bkey76@gmail.com>
9705
9706 * nsfont.m: Fixed bugs in ns_get_family and
9707 ns_descriptor_to_entity that were caused by using free to
9708 deallocate memory blocks that were allocated by xmalloc (via
9709 xstrdup). This caused Emacs to crash when compiled with
9710 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9711 --enable-checking=xmallocoverrun). xfree is now used to
9712 deallocate these memory blocks.
9713
4170f62f 97142011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9715
71b41406
PE
9716 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9717
9587a89d
PE
9718 emacs_write: Accept and return EMACS_INT for sizes.
9719 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9720 et seq.
9721 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9722 Accept and return EMACS_INT.
9723 (emacs_gnutls_write): Return the number of bytes written on
9724 partial writes.
9725 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9726 (emacs_read, emacs_write): Remove check for negative size, as the
9727 Emacs source code has been audited now.
9587a89d
PE
9728 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9729 (emacs_read, emacs_write): Use it.
273a5f82
PE
9730 * process.c (send_process): Adjust to the new signatures of
9731 emacs_write and emacs_gnutls_write. Do not attempt to store
9732 a byte offset into an 'int'; it might overflow.
9587a89d 9733 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9734
3e047f51
PE
9735 * sound.c: Don't assume sizes fit in 'int'.
9736 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9737 Return EMACS_INT, not int.
3e047f51 9738 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9739 Accept EMACS_INT, not int.
9740 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9741 record read return values.
9742
cc39a9db
BK
97432011-04-15 Ben Key <bkey76@gmail.com>
9744
c9d0ec6d
JB
9745 * keyboard.c (Qundefined): Don't declare static since it is used
9746 in nsfns.m.
9747 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9748 static since they are used in nsfont.m.
cc39a9db 9749
6c60eb9f
SM
97502011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9751
9752 * process.c (Qprocessp): Don't declare static.
9753 * lisp.h (Qprocessp): Declare again.
9754
7990b61a
JB
97552011-04-15 Juanma Barranquero <lekktu@gmail.com>
9756
9757 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9758
5d4cb038
PE
97592011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9760
8bd7b830 9761 Improve C-level modularity by making more things 'static'.
cd64ea1d 9762
e3b27b31
PE
9763 Don't publish debugger-only interfaces to other modules.
9764 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9765 (verify_bytepos, count_markers): Move decls to the only modules
9766 that need them.
9767 * region-cache.h (pp_cache): Likewise.
9768 * window.h (check_all_windows): Likewise.
9769 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9770
5d4cb038
PE
9771 * sysdep.c (croak): Now static, if
9772 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9773 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9774
9775 * alloc.c (refill_memory_reserve): Now static if
9776 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9777 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9778
e87b6180
PE
9779 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9780 Define only if USE_LUCID.
9781
ac64929e
PE
9782 * xrdb.c (x_customization_string, x_rm_string): Now static.
9783
6f37259d
PE
9784 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9785 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9786
1683e3ab
PE
9787 * xdisp.c (draw_row_with_mouse_face): Now static.
9788 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9789
de9c2632
PE
9790 * window.h (check_all_windows): Mark externally visible.
9791
2b96acb7
PE
9792 * window.c (window_deletion_count): Now static.
9793
9794 * undo.c: Make symbols static if they're not exported.
9795 (last_undo_buffer, last_boundary_position, pending_boundary):
9796 Now static.
9797
50436f33
PE
9798 * textprop.c (interval_insert_behind_hooks): Now static.
9799 (interval_insert_in_front_hooks): Likewise.
9800
64520e5c
PE
9801 * term.c: Make symbols static if they're not exported.
9802 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9803 (max_frame_lines, tty_set_terminal_modes):
9804 (tty_reset_terminal_modes, tty_turn_off_highlight):
9805 (get_tty_terminal): Now static.
9806 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9807 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9808 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9809 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9810 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9811
1fa53021
PE
9812 * sysdep.c: Make symbols static if they're not exported.
9813 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9814 Now static.
9815 (sigprocmask_set, full_mask): Remove; unused.
9816 (wait_debugging): Mark as visible.
9817 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9818 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9819
d4b43b22
PE
9820 * syntax.c (syntax_temp): Define only if !__GNUC__.
9821
b7c513d0
PE
9822 * sound.c (current_sound_device, current_sound): Now static.
9823
989b29ad
PE
9824 * search.c (searchbufs, searchbuf_head): Now static.
9825
13a55a78
PE
9826 * scroll.c (scroll_cost): Remove; unused.
9827 * dispextern.h (scroll_cost): Remove decl.
9828
de68a1fc
PE
9829 * region-cache.h (pp_cache): Mark as externally visible.
9830
40ccffa6
PE
9831 * process.c: Make symbols static if they're not exported.
9832 (process_tick, update_tick, create_process, chan_process):
9833 (Vprocess_alist, proc_buffered_char, datagram_access):
9834 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9835 (deactivate_process): Mark defn as static, as well as decl.
9836 * lisp.h (create_process): Remove decl.
9837 * process.h (chan_process, Vprocess_alist): Remove decls.
9838
ad64fc97
PE
9839 * print.c: Make symbols static if they're not exported.
9840 (print_depth, new_backquote_output, being_printed, print_buffer):
9841 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9842 (print_interval, print_number_index, initial_stderr_stream):
9843 Now static.
9844 * lisp.h (Fprinc): Remove decl.
9845 (debug_output_compilation_hack): Mark as externally visible.
9846
adddb265
PE
9847 * sysdep.c (croak): Move decl from here to syssignal.h.
9848 * syssignal.h (croak): Put it here, so the API can be checked when
9849 'croak' is called from dissociate_if_controlling_tty.
9850
1717ede2
PE
9851 * minibuf.c: Make symbols static if they're not exported.
9852 (minibuf_save_list, choose_minibuf_frame): Now static.
9853 * lisp.h (choose_minibuf_frame): Remove decl.
9854
fa5fb2bc
PE
9855 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9856
1e3890d1
PE
9857 * lread.c: Make symbols static if they're not exported.
9858 (read_objects, initial_obarray, oblookup_last_bucket_number):
9859 Now static.
9860 (make_symbol): Remove; unused.
9861 * lisp.h (initial_obarray, make_symbol): Remove decls.
9862
8a1414fa
PE
9863 * keyboard.c: Make symbols static if they're not exported.
9864 (single_kboard, recent_keys_index, total_keys, recent_keys):
9865 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9866 (this_single_command_key_start, echoing, last_auto_save):
9867 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9868 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9869 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9870 (Vlispy_mouse_stem, double_click_count):
9871 Now static.
9872 (force_auto_save_soon): Define only if SIGDANGER.
9873 (ignore_mouse_drag_p): Now static if
9874 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9875 (print_help): Remove; unused.
9876 (stop_character, last_timer_event): Mark as externally visible.
9877 * keyboard.h (ignore_mouse_drag_p): Declare only if
9878 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9879 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9880 * lisp.h (echoing): Remove decl.
9881 (force_auto_save_soon): Declare only if SIGDANGER.
9882 * xdisp.c (redisplay_window): Simplify code, to make it more
9883 obvious that ignore_mouse_drag_p is not accessed if !defined
9884 USE_GTK && !defined HAVE_NS.
9885
93ea6e8f
PE
9886 * intervals.c: Make symbols static if they're not exported.
9887 (merge_properties_sticky, merge_interval_right, delete_interval):
9888 Now static.
9889 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9890
77382fcc
PE
9891 * insdel.c: Make symbols static if they're not exported.
9892 However, leave prepare_to_modify_buffer alone. It's never
9893 called from outside this function, but that appears to be a bug.
9894 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9895 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9896 (adjust_after_replace_noundo): Remove; unused.
9897 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9898 (signal_before_change): Remove decls.
77382fcc 9899
9306c32e
PE
9900 * indent.c (val_compute_motion, val_vmotion): Now static.
9901
cd44d2eb
PE
9902 * image.c: Make symbols static if they're not exported.
9903 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9904 if USE_GTK.
9905 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9906 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9907
ad9a7a06
PE
9908 * fringe.c (standard_bitmaps): Now static.
9909 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9910
81626931
PE
9911 * frame.c: Make symbols static if they're not exported.
9912 (x_report_frame_params, make_terminal_frame): Now static.
9913 (get_frame_param): Now static, unless HAVE_NS.
9914 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9915 (x_get_resource_string): Remove; not used.
9916 * frame.h (make_terminal_frame, x_report_frame_params):
9917 (x_get_resource_string); Remove decls.
9918 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9919 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9920
239f9db9
PE
9921 * font.c, fontset.c: Make symbols static if they're not exported.
9922 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9923 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9924 * font.c (font_close_object): Now static.
9925 * font.h (font_close_object): Remove.
9926 * fontset.c (FONTSET_OBJLIST): Remove.
9927 (free_realized_fontset) #if-0 the body, which does nothing.
9928 (face_suitable_for_char_p): #if-0, as it's never called.
9929 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9930 * xfaces.c (face_at_string_position):
9931 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9932 since 0 is always ASCII.
9933
dfcf3579
PE
9934 * fns.c (weak_hash_tables): Now static.
9935
5045092b
PE
9936 * fileio.c: Make symbols static if they're not exported.
9937 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9938 (Vwrite_region_annotation_buffers): Now static.
9939
57a96f5c
PE
9940 * eval.c: Make symbols static if they're not exported.
9941 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9942 * lisp.h (backtrace_list): Remove decl.
9943
35f08c38
PE
9944 * emacs.c: Make symbols static if they're not exported.
9945 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9946 (fatal_error_code, fatal_error_signal_hook, standard_args):
9947 Now static.
9948 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9949 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9950 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9951 * lisp.h (fatal_error_signal_hook): Remove decl.
9952 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9953
f44bd759
PE
9954 * editfns.c: Move a (normally-unused) function to its only use.
9955 * editfns.c, lisp.h (get_operating_system_release): Remove.
9956 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9957 worth the hassle of breaking this out.
9958
b532497d
PE
9959 * xterm.c: Make symbols static if they're not exported.
9960 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9961 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9962 (x_destroy_window, x_delete_display):
9963 Now static.
9964 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9965 (x_mouse_leave): Remove; unused.
9966 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9967 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9968 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9969 Remove decls.
9970 (x_mouse_leave): Declare only if WINDOWSNT.
9971 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9972 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9973 USE_X_TOOLKIT.
9974
1675728f
PE
9975 * ftxfont.c: Make symbols static if they're not exported.
9976 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9977 HAVE_FREETYPE.
9978 * font.h (ftxfont_driver): Likewise.
9979
e4cebfca
PE
9980 * xfns.c: Make symbols static if they're not exported.
9981 (x_last_font_name, x_display_info_for_name):
9982 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9983 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9984 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9985 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9986 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9987 (last_show_tip_args): Now static.
9988 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9989 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9990 (x_screen_planes): Remove; unused.
9991 * dispextern.h (x_screen_planes): Remove decl.
9992
5bf46f05
PE
9993 * dispnew.c: Make symbols static if they're not exported.
9994 * dispextern.h (redraw_garbaged_frames, scrolling):
9995 (increment_row_positions): Remove.
9996 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9997 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9998 Now static.
9999 (redraw_garbaged_frames): Remove; unused.
10000
435f4c28
PE
10001 * xfaces.c: Make symbols static if they're not exported.
10002 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10003 Remove decls.
10004 * xterm.h (defined_color): Remove decls.
10005 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10006 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10007 (menu_face_changed_default, defined_color, free_realized_face):
10008 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10009 (ascii_face_of_lisp_face): Remove; unused.
10010
8524aef3
PE
10011 * xdisp.c: Make symbols static if they're not exported.
10012 * dispextern.h (scratch_glyph_row, window_box_edges):
10013 (glyph_to_pixel_coords, set_cursor_from_row):
10014 (get_next_display_element, set_iterator_to_next):
10015 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10016 (show_mouse_face): Remove decls
10017 * frame.h (message_buf_print): Likewise.
10018 * lisp.h (pop_message, set_message, check_point_in_composition):
10019 Likewise.
10020 * xterm.h (set_vertical_scroll_bar): Likewise.
10021 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10022 (message_buf_print, scratch_glyph_row, displayed_buffer):
10023 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10024 (get_next_display_element, show_mouse_face, window_box_edges):
10025 (frame_to_window_pixel_xy, check_point_in_composition):
10026 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10027 (glyph_to_pixel_coords): Remove; unused.
10028
16390cd2
PE
10029 * dired.c (file_name_completion): Now static.
10030
10031 * dbusbind.c (xd_in_read_queued_messages): Now static.
10032
a25f4dfa
PE
10033 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10034 * data.c (circular_list_error): Remove.
10035
14a9c8df
PE
10036 * commands.h (last_point_position, last_point_position_buffer):
10037 (last_point_position_window): Remove decls.
10038 * keyboard.c: Make these variables static.
10039
04f2d78b
CB
10040 * coding.h (coding, code_convert_region, encode_coding_gap):
10041 Remove decls.
74ab6df5
PE
10042 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10043 (iso_code_class, detect_coding, code_convert_region): Now static.
10044 (encode_coding_gap): Remove; unused.
10045
38dfbee1
PE
10046 * chartab.c (chartab_chars, chartab_bits): Now static.
10047
a2cb4e63
PE
10048 * charset.h (charset_iso_8859_1): Remove decl.
10049 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10050 Now static.
10051
127198fd
PE
10052 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10053 * ccl.c (Vccl_program_table): Now static.
10054 (check_ccl_update): Remove; unused.
10055
d85b608f
PE
10056 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10057 * category.h: ... from here.
10058 * category.c (check_category_table, set_category_set): Now static.
10059
31cd66f3
PE
10060 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10061 * lisp.h: Remove these decls.
10062
c358e587
PE
10063 * buffer.c (buffer_count): Remove unused var.
10064
e78aecca
PE
10065 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10066 so that it's not optimized away.
10067 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10068 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10069 exported only to the debugger.
10070
e192d7d3 10071 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10072 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10073
92470028
PE
10074 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10075 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10076 was inaccessible from Lisp.
10077 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10078 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10079
244ed907
PE
10080 alloc.c: Import and export fewer symbols, and remove unused items.
10081 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10082 is defined.
10083 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10084 it's not optimized away by whole-program optimization.
10085 (message_enable_multibyte, free_misc): Remove.
10086 (catchlist, handlerlist, mark_backtrace):
10087 Declare only if BYTE_MARK_STACK.
10088 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10089 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10090 (message_enable_multibyte): Remove decl.
10091 (free_misc, interval_free_list, float_block, float_block_index):
10092 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10093 (cons_free_list, last_marked_index):
10094 Now static.
10095 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10096 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10097 (mark_backtrace): Define only if BYTE_MARK_STACK.
10098 * xdisp.c (message_enable_multibyte): Now static.
10099
61c2b50e 10100 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10101 This makes it easier for human readers (and static analyzers)
10102 to see whether these variables are used from other modules.
10103 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10104 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10105 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10106 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10107 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10108 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10109 * xmenu.c, xselect.c:
10110 Declare Q* vars static if they are not used in other modules.
10111 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10112 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10113 Remove decls of unexported vars.
10114 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10115
95c82688
PE
10116 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10117
16a97296
PE
10118 Make Emacs functions such as Fatom 'static' by default.
10119 This makes it easier for human readers (and static analyzers)
10120 to see whether these functions can be called from other modules.
10121 DEFUN now defines a static function. To make the function external
10122 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10123 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10124 (Finit_image_library):
16a97296
PE
10125 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10126 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10127 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10128 Remove decls, since these functions are now static.
10129 (Funintern, Fget_internal_run_time): New decls, since these functions
10130 were already external.
95c82688 10131
16a97296
PE
10132 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10133 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10134 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10135 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10136 * keyboard.c, keymap.c, lread.c:
10137 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10138 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10139 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10140 Mark functions with DEFUE instead of DEFUN,
10141 if they are used in other modules.
10142 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10143 decls for now-static functions.
10144 * buffer.h (Fdelete_overlay): Remove decl.
10145 * callproc.c (Fgetenv_internal): Mark as internal.
10146 * composite.c (Fremove_list_of_text_properties): Remove decl.
10147 (Fcomposition_get_gstring): New forward static decl.
10148 * composite.h (Fcomposite_get_gstring): Remove decl.
10149 * dired.c (Ffile_attributes): New forward static decl.
10150 * doc.c (Fdocumntation_property): New forward static decl.
10151 * eval.c (Ffetch_bytecode): New forward static decl.
10152 (Funintern): Remove extern decl; now in .h file where it belongs.
10153 * fileio.c (Fmake_symbolic_link): New forward static decl.
10154 * image.c (Finit_image_library): New forward static decl.
10155 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10156 * intervals.h (Fprevious_property_change):
10157 (Fremove_list_of_text_properties): Remove decls.
10158 * keyboard.c (Fthis_command_keys): Remove decl.
10159 (Fcommand_execute): New forward static decl.
10160 * keymap.c (Flookup_key): New forward static decl.
10161 (Fcopy_keymap): Now static.
10162 * keymap.h (Flookup_key): Remove decl.
10163 * process.c (Fget_process): New forward static decl.
10164 (Fprocess_datagram_address): Mark as internal.
10165 * syntax.c (Fsyntax_table_p): New forward static decl.
10166 (skip_chars): Remove duplicate decl.
10167 * textprop.c (Fprevious_property_change): New forward static decl.
10168 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10169 Now internal.
10170 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10171 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10172
785bbd42
PE
10173 * editfns.c (Fformat): Remove unreachable code.
10174
8b913b57
AS
101752011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10176
10177 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10178 change. (Bug#8496)
10179
a6744a35
EZ
101802011-04-13 Eli Zaretskii <eliz@gnu.org>
10181
10182 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10183 when at ZV. (Bug#8487)
10184
e7974947
AS
101852011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10186
baad03f0
AS
10187 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10188 (Bug#8437)
10189 * keyboard.c (parse_tool_bar_item): Likewise.
10190 * sound.c (sound_cleanup, alsa_close): Likewise.
10191 * termcap.c (tgetent): Likewise.
10192 * xfns.c (x_default_font_parameter): Likewise.
10193 * xsettings.c (read_and_apply_settings): Likewise.
10194
e7974947
AS
10195 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10196 (overrun_check_free): Protoize.
10197
28272684
PE
101982011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10199
10200 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10201 since callers should never pass a negative size.
10202 Change the signature to match that of plain 'read' and 'write'; see
10203 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10204 * lisp.h: Update prototypes of emacs_write and emacs_read.
10205
11997c76
EZ
102062011-04-11 Eli Zaretskii <eliz@gnu.org>
10207
10208 * xdisp.c (redisplay_window): Don't try to determine the character
10209 position of the scroll margin if the window start point w->startp
e896f03c 10210 is outside the buffer's accessible region. (Bug#8468)
11997c76 10211
8a2cbd72
EZ
102122011-04-10 Eli Zaretskii <eliz@gnu.org>
10213
10214 Fix write-region and its subroutines for buffers > 2GB.
10215 * fileio.c (a_write, e_write): Modify declaration of arguments and
10216 local variables to support buffers larger than 2GB.
10217 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10218
10219 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10220 argument, local variables, and return value.
10221
10222 * lisp.h: Update prototypes of emacs_write and emacs_read.
10223
10224 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10225
4073e537 102262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10227
1ebfdcb6
PE
10228 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10229
b2ded58d
PE
10230 Fix more problems found by GCC 4.6.0's static checks.
10231
7d66342c
PE
10232 * xdisp.c (vmessage): Use a better test for character truncation.
10233
bbf47d44
PE
10234 * charset.c (load_charset_map): <, not <=, for optimization,
10235 and to avoid potential problems with integer overflow.
9248994d 10236 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10237 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10238 * editfns.c (Fformat): Likewise.
1e69125e 10239 * syntax.c (skip_chars): Likewise.
3befa583 10240
e3019616
PE
10241 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10242 This also lets GCC 4.6.0 generate slightly better loop code.
10243
becfa255
PE
10244 * callint.c (Fcall_interactively): <, not <=, for optimization.
10245 (Fcall_interactively): Count the number of arguments produced,
10246 not the number of arguments given. This is simpler and lets GCC
10247 4.6.0 generate slightly better code.
10248
dae0cd48
PE
10249 * ftfont.c: Distingish more carefully between FcChar8 and char.
10250 The previous code passed unsigned char * to a functions like
10251 strlen and xstrcasecmp that expect char *, which does not
10252 conform to the C standard.
10253 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10254 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10255 char * when the C standard requires it.
10256
76032d70
PE
10257 * keyboard.c (read_char): Remove unused var.
10258
eb3f1cc8
PE
10259 * eval.c: Port to Windows vsnprintf (Bug#8435).
10260 Include <limits.h>.
10261 (SIZE_MAX): Define if the headers do not.
10262 (verror): Do not give up if vsnprintf returns a negative count.
10263 Instead, grow the buffer. This ports to Windows vsnprintf, which
10264 does not conform to C99. Problem reported by Eli Zaretskii.
10265 Also, simplify the allocation scheme, by avoiding the need for
10266 calling realloc, and removing the ALLOCATED variable.
10267
70476b54
PE
10268 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10269
12020a9e
PE
10270 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10271 But keep the doprint source code for now, as we might revamp it
10272 and use it again (Bug#8435).
ea6c7ae6
PE
10273 * lisp.h (doprnt): Remove.
10274 * Makefile.in (base_obj): Remove doprnt.o.
10275 * deps.mk (doprnt.o): Remove.
10276
5fdb398c
PE
10277 error: Print 32- and 64-bit integers portably (Bug#8435).
10278 Without this change, on typical 64-bit hosts error ("...%d...", N)
10279 was used to print both 32- and 64-bit integers N, which relied on
10280 undefined behavior.
61bdb816 10281 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10282 * lisp.h (error, verror): Mark as printf-like functions.
10283 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10284 Report overflow in size calculations when allocating printf buffer.
10285 Do not truncate output string at its first null byte.
10286 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10287 Truncate the output at a character boundary, since vsnprintf does not
10288 do that.
10289 * charset.c (check_iso_charset_parameter): Convert internal
10290 character to string before calling 'error', since %c now has the
10291 printf meaning.
10292 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10293 overflow when computing char to be passed to 'error'. Do not
10294 pass Lisp_Object to 'error'; pass the integer instead.
10295 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10296 formatted with plain %d.
10297
b189fa66
PE
10298 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10299
bff87ef0
PE
10300 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10301
7e2cac20
PE
10302 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10303
ce4d90b5
PE
10304 * xterm.c (x_catch_errors): Remove duplicate declaration.
10305
266c9547
PE
10306 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10307
79c49ad2
PE
10308 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10309
368f4090
JM
103102011-04-10 Jim Meyering <meyering@redhat.com>
10311
10312 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10313 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10314 return ssize_t not "int", and use size_t as the buffer length.
10315 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10316 * gnutls.h: Update declarations.
10317 * process.c (read_process_output): Use ssize_t, to match.
10318 (send_process): Likewise.
10319
a32d4040
CY
103202011-04-09 Chong Yidong <cyd@stupidchicken.com>
10321
10322 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10323
8546720e 103242011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10325
04f2d78b
CB
10326 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10327 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10328
8546720e
GM
10329 * xterm.c (handle_one_xevent):
10330 * xmenu.c (create_and_show_popup_menu):
10331 * xselect.c (x_decline_selection_request)
10332 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10333
0a2f5c1a 103342011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10335
10336 Fix some uses of `int' instead of EMACS_INT.
10337 * search.c (string_match_1, fast_string_match)
10338 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10339 (scan_buffer, find_next_newline_no_quit)
10340 (find_before_next_newline, search_command, Freplace_match)
10341 (Fmatch_data): Make some `int' variables be EMACS_INT.
10342
10343 * xdisp.c (display_count_lines): 3rd argument and return value now
10344 EMACS_INT. All callers changed.
10345 (pint2hrstr): Last argument is now EMACS_INT.
10346
10347 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10348 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10349 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10350 (decode_coding_utf_16, decode_coding_emacs_mule)
10351 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10352 (decode_coding_ccl, decode_coding_charset)
10353 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10354 (decode_coding_iso_2022, decode_coding_emacs_mule)
10355 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10356 <char_offset, last_offset>: Declare EMACS_INT.
10357 (encode_coding_utf_8, encode_coding_utf_16)
10358 (encode_coding_emacs_mule, encode_invocation_designation)
10359 (encode_designation_at_bol, encode_coding_iso_2022)
10360 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10361 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10362 Declare EMACS_INT.
10363 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10364 (encode_invocation_designation): Last argument P_NCHARS is now
10365 EMACS_INT.
10366 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10367 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10368
10369 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10370 All users changed.
10371
10372 * ccl.c (Fccl_execute_on_string): Declare some variables
10373 EMACS_INT.
10374
8546720e 103752011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10376
10377 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10378
4e19a977
CS
103792011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10380
10381 * process.c (Fformat_network_address): Doc fix.
10382
87302331
R
103832011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10384
ee7683eb 10385 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10386
cbb59342
CY
103872011-04-08 Chong Yidong <cyd@stupidchicken.com>
10388
10389 * keyboard.c (read_char): Call Lisp function help-form-show,
10390 instead of using internal_with_output_to_temp_buffer.
10391 (Qhelp_form_show): New var.
e0d38eeb 10392 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10393
10394 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10395
10396 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10397
e67a13ab
CY
103982011-04-06 Chong Yidong <cyd@stupidchicken.com>
10399
04f2d78b
CB
10400 * process.c (Flist_processes): Remove to Lisp.
10401 (list_processes_1): Delete.
e67a13ab 10402
973f782d
EZ
104032011-04-06 Eli Zaretskii <eliz@gnu.org>
10404
7c106b1e
EZ
10405 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10406
973f782d
EZ
10407 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10408
41cf7d1a 104092011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10410
ca23cc88
PE
10411 Fix more problems found by GCC 4.6.0's static checks.
10412
f390e2d5
PE
10413 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10414
42eea0d0
PE
10415 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10416
b69769da 10417 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10418
f9541e84
PE
10419 * xdisp.c (vmessage): Mark as a printf-like function.
10420
13841b55
PE
10421 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10422
c136c10f
PE
10423 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10424
5e2d4a30
PE
10425 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10426 printf-like functions.
10427 (tiff_load): Add casts to remove these marks before passing them
10428 to system-supplied API.
10429
583f48b9
PE
10430 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10431
b25d760e
PE
10432 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10433 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10434 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10435 directly, rather than having caller test rule sign. This avoids
10436 some unnecessary tests.
10437 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10438 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10439 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10440
bc7b6697 10441 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10442 (xfont_open): Avoid unnecessary tests.
bc7b6697 10443
27ccc379
PE
10444 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10445
dcd5c89a
PE
10446 * composite.h, composite.c (composition_gstring_put_cache):
10447 Use EMACS_INT, not int, for length.
10448
b13a45c6
PE
10449 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10450 breaking out part of COMPOSITION_DECODE_RULE.
10451 (COMPOSITION_DECODE_RULE): Use it.
10452 * composite.c (get_composition_id): Remove unused local vars,
10453 by using the new macro.
10454
1e792e4d
PE
10455 * textprop.c (set_text_properties_1): Change while to do-while,
10456 since the condition is always true at first.
10457
dc6c6455 10458 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10459 (interval_deletion_adjustment): Return unsigned value.
10460 All uses changed.
dc6c6455 10461
aba7731a
PE
10462 * process.c (list_processes_1, create_pty, read_process_output):
10463 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10464 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10465 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10466 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10467 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10468
fdfc4bf3
PE
10469 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10470
fca8fe46 10471 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10472 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10473
06a0259a 10474 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10475 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10476 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10477
e7b9e80f
PE
10478 * print.c (print_error_message): Avoid int overflow.
10479
56201685
PE
10480 * font.c (font_list_entities): Redo for clarity,
10481 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10482
78834453 10483 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10484 (font_score): Avoid potential overflow in diff calculation.
78834453 10485
0bc0b309 10486 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10487 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10488
e610eaca
PE
10489 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10490
b895abce
PE
10491 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10492 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10493 can always succeed if overflow has undefined behavior.
10494
1f1d9321 10495 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10496 (wordify): Omit three unnecessary tests.
1f1d9321 10497
c59478bc
PE
10498 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10499 All callers changed. This avoids the need for an unused var.
10500
79b73827
PE
10501 * casefiddle.c (casify_region): Remove var that is set but not used.
10502
a4db5dfe
PE
10503 * dired.c (file_name_completion): Remove var that is set but not used.
10504
43aae36e
PE
10505 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10506
2a47c44d 10507 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10508 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10509
a37c69bf
PE
10510 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10511 Check for integer overflow on size calculations.
10512
328ab8e7
PE
10513 * buffer.c (Fprevious_overlay_change): Remove var that is set
10514 but not used.
10515
e5a2a5cb
PE
10516 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10517 Remove vars that are set but not used.
8d84a6eb 10518 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10519 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10520
a60e5f68
PE
10521 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10522
f661cb61 10523 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10524 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10525
f0397f5a
PE
10526 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10527 that are set but not used.
10528
8664db06 10529 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10530 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10531
6abdaa4a
PE
10532 * xselect.c (x_get_local_selection, x_handle_property_notify):
10533 Remove vars that are set but not used.
10534
0ce7538d 10535 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10536 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10537
9ae848fc
PE
10538 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10539 Remove var that is set but not used.
0b918413
PE
10540 (scroll_bar_windows_size): Now size_t, not int.
10541 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10542 Check for overflow.
9ae848fc 10543
a5a62657
PE
10544 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10545 (map_tty_color) [!defined MSDOS]: Likewise.
10546
5c5cdd39
PE
10547 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10548
66ebf983
PE
10549 * coding.c: Remove vars that are set but not used.
10550 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10551 All callers changed.
10552 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10553 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10554 (decode_coding_charset): Remove vars that are set but not used.
10555
1be4d761
PE
10556 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10557 that is set but not used.
10558
47553fa8
PE
10559 * print.c (print_object): Remove var that is set but not used.
10560
1f7196bf 10561 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10562 The gnulib version avoids calling malloc in the usual case,
10563 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10564 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10565 * filelock.c (current_lock_owner): Likewise.
10566 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10567 * sysdep.c: Include allocator.h, careadlinkat.h.
10568 (emacs_no_realloc_allocator): New static constant.
10569 (emacs_readlink): New function.
fdb61804
PE
10570 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10571 ../lib/careadlinkat.h.
d1fdcab7 10572
f84c17c7
SM
105732011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10574
10575 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10576 first non-nil return value).
10577
ef3862ad
JD
105782011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10579
10580 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10581 if not defined (Bug#8403).
10582
376a7006
JB
105832011-04-02 Juanma Barranquero <lekktu@gmail.com>
10584
10585 * xdisp.c (display_count_lines): Remove parameter `start',
10586 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10587 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10588 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10589 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10590 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10591 and thereabouts. All callers changed.
10592 (get_per_char_metric): Remove parameter `f', unused since
10593 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10594
6ca3801d
JM
105952011-04-02 Jim Meyering <meyering@redhat.com>
10596
10597 do not dereference NULL upon failed strdup
10598 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10599 (ns_get_family): Likewise.
10600
d8e2b5ba
JB
106012011-04-02 Juanma Barranquero <lekktu@gmail.com>
10602
10603 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10604
8c74fcbd
JD
106052011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10606
10607 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10608 later (Bug#8403).
10609
7200d79c
SM
106102011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10611
03408648 10612 Add lexical binding.
7200d79c 10613
03408648
SM
10614 * window.c (Ftemp_output_buffer_show): New fun.
10615 (Fsave_window_excursion):
10616 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10617
10618 * lread.c (lisp_file_lexically_bound_p): New function.
10619 (Fload): Bind Qlexical_binding.
10620 (readevalloop): Remove `evalfun' arg.
10621 Bind Qinternal_interpreter_environment.
10622 (Feval_buffer): Bind Qlexical_binding.
10623 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10624 Mark as dynamic.
10625 (syms_of_lread): Declare `lexical-binding'.
10626
10627 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10628
10629 * keyboard.c (eval_dyn): New fun.
10630 (menu_item_eval_property): Use it.
ca105506
SM
10631
10632 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10633
03408648
SM
10634 * fns.c (concat, mapcar1): Accept byte-code-functions.
10635
10636 * eval.c (Fsetq): Handle lexical vars.
10637 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10638 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10639 (FletX, Flet): Obey lexical binding.
10640 (Fcommandp): Handle closures.
10641 (Feval): New `lexical' arg.
10642 (eval_sub): New function extracted from Feval. Use it almost
10643 everywhere where Feval was used. Look up vars in lexical env.
10644 Handle closures.
10645 (Ffunctionp): Move from subr.el.
10646 (Ffuncall): Handle closures.
10647 (apply_lambda): Remove `eval_flags'.
10648 (funcall_lambda): Handle closures and new byte-code-functions.
10649 (Fspecial_variable_p): New function.
10650 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10651 but without exporting it to Lisp.
23aba0ea 10652
23aba0ea 10653 * doc.c (Fdocumentation, store_function_docstring):
03408648 10654 * data.c (Finteractive_form): Handle closures.
23aba0ea 10655
03408648
SM
10656 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10657 interactive spec.
ba83908c 10658
04f2d78b
CB
10659 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10660 New byte-codes.
03408648
SM
10661 (exec_byte_code): New function extracted from Fbyte_code to handle new
10662 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10663
03408648 10664 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10665
03408648 10666 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10667
e2abce01
JB
106682011-03-31 Juanma Barranquero <lekktu@gmail.com>
10669
10670 * xdisp.c (redisplay_internal): Fix prototype.
10671
63696a73 106722011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10673
63696a73 10674 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10675 (try_scrolling): Use it when setting scroll_limit.
10676 Limit scrolling to 100 screen lines.
63696a73
EZ
10677 (redisplay_window): Even when falling back on "recentering",
10678 position point in the window according to scroll-conservatively,
10679 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10680
10681 (try_scrolling): When point is above the window, allow searching
10682 as far as scroll_max, or one screenful, to compute vertical
10683 distance from PT to the scroll margin position. This prevents
10684 try_scrolling from unnecessarily failing when
10685 scroll-conservatively is set to a value slightly larger than the
10686 window height. Clean up the case of PT below the margin at bottom
10687 of window: scroll_max can no longer be INT_MAX. When aggressive
10688 scrolling is in use, don't let point enter the opposite scroll
10689 margin as result of the scroll.
10690 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10691 threshold of 100 lines for never-recentering scrolling.
10692
e4cc2dfc
JB
106932011-03-31 Juanma Barranquero <lekktu@gmail.com>
10694
10695 * dispextern.h (move_it_by_lines):
10696 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10697 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10698 (message_log_check_duplicate): Remove parameters `prev_bol' and
10699 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10700 (redisplay_internal): Remove parameter `preserve_echo_area',
10701 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10702
10703 * indent.c (Fvertical_motion):
10704 * window.c (window_scroll_pixel_based, Frecenter):
10705 Don't pass `need_y_p' to `move_it_by_lines'.
10706
1c470562
SM
107072011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10708
44f230aa
SM
10709 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10710 steal a few bits to be more compact.
10711 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10712 Remove unneeded casts.
10713
1c470562
SM
10714 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10715
888adce9
ZK
107162011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10717
10718 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10719 binding" message (bug#7967).
10720
f838ed7b
PE
107212011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10722
77861b95
PE
10723 Fix more problems found by GCC 4.6.0's static checks.
10724
de6dbc14
PE
10725 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10726 Remove unused local var.
10727
f838ed7b
PE
10728 * editfns.c (Fmessage_box): Remove unused local var.
10729
792c7b2b
PE
10730 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10731 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10732 Omit unused local vars.
c499e557 10733 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10734 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10735 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10736 Omit unused local var.
10737
ba0165e1
PE
10738 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10739 Don't assume string length fits in int.
32ad8845 10740 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10741 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10742
3c59b4c9
PE
10743 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10744 instead of alloca (Bug#8344).
10745
a3eed478 10746 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10747 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10748
eb4d412d
PE
10749 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10750
1658b401
PE
10751 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10752 concerns.
10753
10754 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10755
10756 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10757
9a2c6e05
PE
10758 * keyboard.c (syms_of_keyboard): Use the same style as later
10759 in this function when indexing through an array. This also
10760 works around GCC bug 48267.
10761
03d0a109
PE
10762 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10763
44f730c8
PE
10764 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10765
fe75f926
PE
10766 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10767 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10768
ffa8c828
PE
10769 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10770 This avoids undefined behavior on integer overflow, and is a bit
10771 more convenient anyway since it is compared to a size_t variable.
10772
c5101a77
PE
10773 Variadic C functions now count arguments with size_t, not int.
10774 This avoids an unnecessary limitation on 64-bit machines, which
10775 caused (substring ...) to crash on large vectors (Bug#8344).
10776 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10777 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10778 All variadic functions and their callers changed accordingly.
c5101a77
PE
10779 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10780 * data.c (arith_driver, float_arith_driver): Likewise.
10781 * editfns.c (general_insert_function): Likewise.
10782 * eval.c (struct backtrace.nargs, interactive_p)
10783 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10784 (funcall_lambda, mark_backtrace): Likewise.
10785 * fns.c (concat): Likewise.
10786 * frame.c (x_set_frame_parameters): Likewise.
10787 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10788 0 if not found, not -1. All callers changed.
10789
dd3f25f7
PE
10790 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10791 (stack_copy_size): Now size_t, not int.
10792 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10793
461c2ab9
JB
107942011-03-28 Juanma Barranquero <lekktu@gmail.com>
10795
10796 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10797 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10798 All callers changed.
10799
10800 * lisp.h (multibyte_char_to_unibyte):
10801 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10802 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10803 * character.h (CHAR_TO_BYTE8):
10804 * cmds.c (internal_self_insert):
10805 * editfns.c (general_insert_function):
10806 * keymap.c (push_key_description):
10807 * search.c (Freplace_match):
10808 * xdisp.c (message_dolog, set_message_1): All callers changed.
10809
f6d62986
SM
108102011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10811
10812 * keyboard.c (safe_run_hook_funcall): New function.
10813 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10814 don't set the hook to nil, but remove the offending function instead.
10815 (Qcommand_hook_internal): Remove, unused.
10816 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10817 Vcommand_hook_internal.
10818
10819 * eval.c (enum run_hooks_condition): Remove.
10820 (funcall_nil, funcall_not): New functions.
10821 (run_hook_with_args): Call each function through a `funcall' argument.
10822 Remove `cond' argument, now redundant.
10823 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10824 (Frun_hook_with_args_until_failure): Adjust accordingly.
10825 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10826
1db5b1ad
JB
108272011-03-28 Juanma Barranquero <lekktu@gmail.com>
10828
10829 * dispextern.h (string_buffer_position): Remove declaration.
10830
10831 * print.c (strout): Remove parameter `multibyte', unused since
10832 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10833
10834 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10835 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10836 All callers changed.
10837
10838 * w32.c (_wsa_errlist): Use braces for struct initializers.
10839
10840 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10841 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10842 All callers changed.
10843 (string_buffer_position): Likewise. Also, make static (it's never
10844 used outside xdisp.c).
10845 (cursor_row_p): Remove parameter `w', unused since
10846 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10847 (decode_mode_spec): Remove parameter `precision', introduced during
10848 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10849 All callers changed.
10850
5ffb62aa
JD
108512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10852
10853 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10854
461c2ab9 108552011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10856
10857 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10858 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10859 (ns_update_auto_hide_menu_bar): New functions.
10860 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10861 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10862 ns_constrain_all_frames.
10863 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10864 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10865
5c380ffb
JD
108662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10867
10868 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10869
9af30bdf
GM
108702011-03-27 Glenn Morris <rgm@gnu.org>
10871
10872 * syssignal.h: Replace RETSIGTYPE with void.
10873 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10874 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10875 Replace SIGTYPE with void everywhere.
10876 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10877 * s/template.h (SIGTYPE): Remove commented out definition.
10878
e2abce01
JB
108792011-03-26 Eli Zaretskii <eliz@gnu.org>
10880
10881 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10882 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10883
f868cd8a
JB
108842011-03-26 Juanma Barranquero <lekktu@gmail.com>
10885
59eb0929
JB
10886 * w32.c (read_unc_volume): Use parameter `henum', instead of
10887 global variable `wget_enum_handle'.
10888
10889 * keymap.c (describe_vector): Remove parameters `indices' and
10890 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10891 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10892
f868cd8a
JB
10893 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10894
10895 * keyboard.c (timer_check): Remove parameter `do_it_now',
10896 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10897 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10898 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10899
10900 * keyboard.c (read_char):
10901 * w32menu.c (w32_menu_display_help):
10902 * xmenu.c (show_help_event, menu_help_callback):
10903 Adjust calls to `show_help_echo'.
10904
10905 * gtkutil.c (xg_maybe_add_timer):
10906 * keyboard.c (readable_events):
10907 * process.c (wait_reading_process_output):
10908 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10909
10910 * insdel.c (adjust_markers_gap_motion):
10911 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10912 (gap_left, gap_right): Don't call it.
10913
2ecf6fdb
CY
109142011-03-25 Chong Yidong <cyd@stupidchicken.com>
10915
10916 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10917 incurred during fontification.
10918
6b1f9ba4
JB
109192011-03-25 Juanma Barranquero <lekktu@gmail.com>
10920
10921 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10922 (DEFVAR_PER_BUFFER): Don't pass it.
10923
10924 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10925 (scrolling_window): Don't pass it.
10926
0f4a96b5
JB
109272011-03-25 Juanma Barranquero <lekktu@gmail.com>
10928
10929 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10930
10931 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10932 and `suffix'.
10933 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10934 of variables specific to SELinux and computation of `encoded_absname'.
10935
10936 * image.c (XPutPixel): Remove unused variable `height'.
10937
10938 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10939
10940 * unexw32.c (get_section_info): Remove unused variable `section'.
10941
10942 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10943 (system_process_attributes): Remove unused variable `sess'.
10944 (sys_read): Remove unused variable `err'.
10945
10946 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10947 (w32_wnd_proc): Remove unused variable `isdead'.
10948 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10949 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10950 (x_create_tip_frame): Remove unused variable `tem'.
10951
10952 * w32inevt.c (w32_console_read_socket):
10953 Remove unused variable `no_events'.
10954
10955 * w32term.c (x_draw_composite_glyph_string_foreground):
10956 Remove unused variable `width'.
10957
1149507c
JB
109582011-03-24 Juanma Barranquero <lekktu@gmail.com>
10959
10960 * w32term.c (x_set_glyph_string_clipping):
10961 Don't pass uninitialized region to CombineRgn.
10962
9c88f339
JB
109632011-03-23 Juanma Barranquero <lekktu@gmail.com>
10964
10965 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10966 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10967 (Fx_close_connection): Remove unused variable `i'.
10968
10969 * w32font.c (w32font_draw): Return number of glyphs.
10970 (w32font_open_internal): Remove unused variable `i'.
10971 (w32font_driver): Add missing initializer.
10972
10973 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10974 (fill_in_menu): Remove unused variable `items_added'.
10975
10976 * w32term.c (last_mouse_press_frame): Remove static global variable.
10977 (w32_clip_to_row): Remove unused variable `f'.
10978 (x_delete_terminal): Remove unused variable `i'.
10979
10980 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10981 (NOTHING): Remove unused static global variable.
10982 (uniscribe_check_otf): Remove unused variable `table'.
10983 (uniscribe_font_driver): Add missing initializers.
10984
dee091a3
JD
109852011-03-23 Julien Danjou <julien@danjou.info>
10986
10987 * term.c (Fsuspend_tty, Fresume_tty):
10988 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10989 * window.c (temp_output_buffer_show):
10990 * insdel.c (signal_before_change):
10991 * frame.c (Fhandle_switch_frame):
10992 * fileio.c (Fdo_auto_save):
10993 * emacs.c (Fkill_emacs):
10994 * editfns.c (save_excursion_restore):
10995 * cmds.c (internal_self_insert):
10996 * callint.c (Fcall_interactively):
10997 * buffer.c (Fkill_all_local_variables):
10998 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10999 Use Frun_hooks.
0f4a96b5 11000 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11001 unconditionally since it does the check itself.
dee091a3 11002
2c520ab5 110032011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11004
c9c49752
PE
11005 Fix more problems found by GCC 4.5.2's static checks.
11006
8abc3f12
PE
11007 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11008 the first time through the loop, since we know p0 < p1 then.
11009 This also avoids a gcc -Wstrict-overflow warning.
11010
a2d26660
PE
11011 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11012 leading to a memory leak, possible in functions like
11013 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11014 of objects (Bug#8318).
a2d26660 11015
916c72e9
PE
11016 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11017 that could (at least in theory) be that large.
11018
19ab8a18
PE
11019 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11020 This is less likely to overflow, and avoids undefined behavior if
11021 overflow does occur. All callers changed. Use strtoul to scan
11022 for the unsigned long integer.
b7cbbd6f
PE
11023 (pint2hrstr): Simplify and tune code slightly.
11024 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11025
f0641eff
PE
11026 * scroll.c (do_scrolling): Work around GCC bug 48228.
11027 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11028
7f650bb9
PE
11029 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11030 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11031 (validate_x_resource_name): Simplify count usage.
11032 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11033
37dd57d1
PE
11034 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11035 fail (Bug#8306).
81e56e61 11036
699979fc 11037 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11038
401bf9b4
PE
11039 * process.c (Fmake_network_process): Use socklen_t, not int,
11040 where POSIX says socklen_t is required in portable programs.
11041 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11042 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11043 (Fmake_network_process, server_accept_connection):
11044 (wait_reading_process_output, read_process_output):
11045 Likewise.
11046
b93aacde
PE
11047 * process.c: Rename or move locals to avoid shadowing.
11048 (list_processes_1, Fmake_network_process):
11049 (read_process_output_error_handler, exec_sentinel_error_handler):
11050 Rename or move locals.
4dc343ee 11051 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11052 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11053 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11054 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11055 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11056
af8a867c 11057 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11058 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11059 Include tparam.h instead, since it declares them.
af8a867c
PE
11060 * cm.h (PC): Remove extern decl; tparam.h now does this.
11061 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11062 * terminfo.c: Include tparam.h, to check interfaces.
11063 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11064 (tparam): Adjust signature to match interface in tparam.h;
11065 this removes some undefined behavior. Check that outstring and len
11066 are zero, which they always are with Emacs.
11067 * tparam.h (PC, BC, UP): New extern decls.
11068
0248044d 11069 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11070 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11071
8ff096c1 11072 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11073 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11074 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11075 (ftfont_list): Remove unused local.
49eaafba
PE
11076 (get_adstyle_property, ftfont_pattern_entity):
11077 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11078 Rename locals to avoid shadowing.
8ff096c1 11079
e2be39f6
PE
11080 * xfont.c (xfont_list_family): Mark var as initialized.
11081
c9735e30
PE
11082 * xml.c (make_dom): Now static.
11083
8f5201ae
PE
11084 * composite.c (composition_compute_stop_pos): Rename local to
11085 avoid shadowing.
b246f932
PE
11086 (composition_reseat_it): Remove unused locals.
11087 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11088 (composition_update_it): Mark var as initialized.
11b61122
PE
11089 (find_automatic_composition): Mark vars as initialized,
11090 with a FIXME (Bug#8290).
8f5201ae 11091
760fbc2c
PE
11092 character.h: Rename locals to avoid shadowing.
11093 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11094 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11095 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11096 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11097 to avoid shadowing.
11098
ff08eb85
PE
11099 * textprop.c (property_change_between_p): Remove; unused.
11100
fc7bf025
PE
11101 * intervals.c (interval_start_pos): Now static.
11102
235d7abc
PE
11103 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11104
44f230aa
SM
11105 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11106 Rename locals to avoid shadowing.
3e7d6594 11107
50060332
PE
11108 * sound.c (wav_play, au_play, Fplay_sound_internal):
11109 Fix pointer signedness.
d01f234b 11110 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11111 (wav_play): Initialize a variable to 0, to prevent undefined
11112 behavior (Bug#8278).
50060332 11113
c4fc4e30
PE
11114 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11115
918436ed
PE
11116 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11117
c939f91b
PE
11118 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11119 clobbering (Bug#8298).
b9c7f648
PE
11120 * sysdep.c (sys_subshell): Likewise.
11121 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11122
6bd8c144
PE
11123 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11124 This should get cleaned up, so that child_setup has the
11125 same signature on all platforms.
11126
7710357c 11127 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11128 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11129
c59da222
CY
111302011-03-22 Chong Yidong <cyd@stupidchicken.com>
11131
11132 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11133 not to be necessary, and produces flickering.
11134
66b87493
GM
111352011-03-20 Glenn Morris <rgm@gnu.org>
11136
11137 * config.in: Remove file.
11138
45b6f6d5
JB
111392011-03-20 Juanma Barranquero <lekktu@gmail.com>
11140
11141 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11142 are now in src/globals.h.
11143 (syms_of_minibuf): Remove spurious & from previous change.
11144
cd394be1 111452011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11146
11147 * minibuf.c (completing-read-function): New variable.
11148 (completing-read-default): Rename from completing-read.
11149 (completing-read): Call completing-read-function.
11150
b14e3e21
CY
111512011-03-19 Juanma Barranquero <lekktu@gmail.com>
11152
11153 * xfaces.c (Fx_load_color_file):
11154 Read color file from absolute filename (bug#8250).
11155
f2b726e6
JB
111562011-03-19 Juanma Barranquero <lekktu@gmail.com>
11157
11158 * makefile.w32-in: Update dependencies.
11159
09f6ff02
EZ
111602011-03-17 Eli Zaretskii <eliz@gnu.org>
11161
11162 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11163
29a6015a
PE
111642011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11165
a3a6c54e
PE
11166 Fix more problems found by GCC 4.5.2's static checks.
11167
b766f867
PE
11168 * process.c (make_serial_process_unwind, send_process_trap):
11169 (sigchld_handler): Now static.
11170
be02381c
PE
11171 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11172 That way, the code declares only the vars that it needs.
11173 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11174 * s/cygwin.h (PTY_ITERATION): Likewise.
11175 * s/darwin.h (PTY_ITERATION): Likewise.
11176 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11177
57048744
PE
11178 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11179 * process.c (allocate_pty): Don't declare stb unless it's needed.
11180
7914961c 11181 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11182 (CONSTANTLIM): Remove; unused.
11183 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11184 Define only if needed.
7914961c 11185
b3967b18
PE
11186 * unexelf.c (unexec): Name an expression,
11187 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11188 Use a different way to cause a compilation error if anyone uses
11189 n rather than nn, a way that does not involve shadowing.
73366a00 11190 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11191
29a6015a
PE
11192 * deps.mk (unexalpha.o): Remove; unused.
11193
43cfc33e 11194 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11195 * unexec.h: New file.
ce701a33
PE
11196 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11197 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11198 Depend on unexec.h.
11199 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11200 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11201 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11202 Change as necessary to match prototype in unexec.h.
ce701a33 11203
01f44d5a
PE
11204 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11205 shadowing.
4f63c6bb 11206 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11207
a6670b0b
PE
11208 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11209 Rename locals to avoid shadowing.
11210
cef2010d 11211 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11212 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11213
d4d7173a
PE
11214 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11215
f08b802a
PE
11216 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11217 warning when compiling print.c.
11218
3ddb0639
PE
11219 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11220 instead of using an uninitialized var.
5ad03b97 11221 (font_sort_entities): Mark var as initialized.
3ddb0639 11222
170a2692
PE
11223 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11224
e663c700
PE
11225 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11226 pointers to constants.
89bc529a 11227 (font_parse_fcname): Remove unused vars.
7b81e2d0 11228 (font_delete_unmatched): Now static.
ea838e10 11229 (font_get_spec): Remove; unused.
13a547c6
PE
11230 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11231 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11232 Rename or move locals to avoid shadowing.
e663c700 11233
2a80c887 11234 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11235 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11236
1384fa33 11237 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11238 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11239
8b2c52e9
PE
11240 * alloc.c (mark_backtrace): Move decl from here ...
11241 * lisp.h: ... to here, so that it can be checked.
11242
475545b5 11243 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11244 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11245 (lisp_indirect_variable): Name an expression,
11246 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11247 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11248
b1349114 11249 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11250 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11251 Use const pointer when appropriate.
b1349114 11252
a2928364
PE
11253 * lisp.h (get_system_name, get_operating_system_release):
11254 Move decls here, to check interfaces.
11255 * process.c (get_operating_system_release): Move decl to lisp.h.
11256 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11257 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11258 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11259 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11260 (Fformat_time_string, Fencode_time, Finsert_char):
11261 (Ftranslate_region_internal, Fformat):
11262 Rename or remove local vars to avoid shadowing.
9710023e 11263 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11264
a415e694
PE
11265 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11266 avoid shadowing.
11267
8ef4622d
PE
11268 * lisp.h (eassert): Check that the argument compiles, even if
11269 ENABLE_CHECKING is not defined.
11270
946f9a5b
PE
11271 * data.c (Findirect_variable): Name an expression, to avoid
11272 gcc -Wbad-function-cast warning.
112396d6 11273 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11274 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11275 (Fmake_variable_buffer_local, Fmake_local_variable):
11276 Mark variables as initialized.
52746918 11277 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11278
e5aab7e7 11279 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11280 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11281 Rename locals to avoid shadowing.
dff45157
PE
11282 (mark_stack): Move local variables into the #ifdef region where
11283 they're used.
7bc26fdb
PE
11284 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11285 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11286 needed otherwise.
11287 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11288 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11289 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11290
e5aab7e7
PE
11291 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11292 avoids undefined behavior in theory.
11293
4da60324
PE
11294 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11295
88043301
PE
11296 Use functions, not macros, for up- and down-casing (Bug#8254).
11297 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11298 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11299 to use the following functions instead of these macros.
11300 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11301 EMACS_INT, since callers assume the returned value fits in int.
11302 (upcase1): Likewise, for UPCASE_TABLE.
11303 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11304 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11305 the race-condition problem in the old DOWNCASE.
88043301 11306
19ed5445
PE
11307 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11308 Rename locals to avoid shadowing.
11309 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11310 (regex_compile, re_search_2, re_match_2_internal):
11311 Remove unused local vars.
952db0d7
PE
11312 (FREE_VAR): Rewrite so as not to use empty "else",
11313 which gcc can warn about.
da053e48 11314 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11315 (RETALLOC_IF): Define only if needed.
11316 (WORDCHAR_P): Likewise. This one is never needed, but is used
11317 only in a comment talking about a compiler bug, so put inside
11318 the #if 0 of that comment.
11319 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11320 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11321 Remove; unused.
19ed5445 11322
1f3561e4 11323 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11324 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11325 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11326
ded6f8f7
PE
11327 * search.c (simple_search): Remove unused var.
11328
dbd37a95
PE
11329 * dired.c (compile_pattern): Move decl from here ...
11330 * lisp.h: ... to here, so that it can be checked.
11331 (struct re_registers): New forward decl.
11332
7e47afad
PE
11333 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11334
85f24f61
PE
11335 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11336 All uses changed.
11337 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11338 Rename locals to avoid shadowing.
5671df8f 11339 (Fvertical_motion): Mark locals as initialized.
85f24f61 11340
181aa2be 11341 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11342 (casify_region): Mark local as initialized.
181aa2be 11343
930d429c
PE
11344 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11345
7082eac6
PE
11346 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11347 New macros, so that the caller can use some names other than
11348 gcpro1, gcpro2, etc.
11349 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11350 of the new macros.
11351 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11352 argument, for consistency with GCPRO2_VAR, etc: it is now the
11353 prefix of the variable, not the variable itself. All uses
11354 changed.
38b2c076
PE
11355 * dired.c (directory_files_internal, file_name_completion):
11356 Rename locals to avoid shadowing.
11357
15206ed9
PE
11358 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11359 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11360 dired.c's scmp function, had undefined behavior.
11361 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11362 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11363 * buffer.h: ... to here, because these macros use current_buffer,
11364 and the new implementation with inline functions needs to have
11365 current_buffer in scope now, rather than later when the macros
11366 are used.
11367 (downcase, upcase1): New static inline functions.
11368 (DOWNCASE, UPCASE1): Reimplement using these functions.
11369 This avoids undefined behavior in expressions like
11370 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11371 from race conditions in accessing the global variables
11372 case_temp1 and case_temp2.
11373 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11374 * lisp.h (case_temp1, case_temp2): Remove their decls.
11375 * character.h (ASCII_CHAR_P): Move from here ...
11376 * lisp.h: ... to here, so that the inline functions mentioned
11377 above can use them.
11378
4a6bea26
PE
11379 * dired.c (directory_files_internal_unwind): Now static.
11380
f14b7e14
PE
11381 * fileio.c (file_name_as_directory, directory_file_name):
11382 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11383 Now static.
2893f146
PE
11384 (file_name_as_directory): Use const pointers when appropriate.
11385 (Fexpand_file_name): Likewise. In particular, newdir might
11386 point at constant storage, so make it a const pointer.
fd4ead52 11387 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11388 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11389 signedness issues.
f839df0c
PE
11390 (Fset_file_times, Finsert_file_contents, auto_save_error):
11391 Rename locals to avoid shadowing.
f14b7e14 11392
5716756e 11393 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11394 (Ftry_completion, Fall_completions): Rename or remove locals
11395 to avoid shadowing.
5716756e 11396
b4c3046a
PE
11397 * marker.c (bytepos_to_charpos): Remove; unused.
11398
b45db522
PE
11399 * lisp.h (verify_bytepos, count_markers): New decls,
11400 so that gcc does not warn that these functions aren't declared.
11401
85876d07
PE
11402 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11403 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11404 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11405 (copy_text): Remove unused local var.
85876d07 11406
03d78a21 11407 * filelock.c (within_one_second): Now static.
b3dd38ab 11408 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11409
5df8f01b
PE
11410 * buffer.c (fix_overlays_before): Mark locals as initialized.
11411 (fix_start_end_in_overlays): Likewise. This function should be
11412 simplified by using pointers-to-pointers, but that's a different
11413 matter.
b1d876f1 11414 (switch_to_buffer_1): Now static.
8f54f30a
PE
11415 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11416 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11417
a70072c9 11418 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11419 Fix pointer signedness issue.
edced198
PE
11420 (sys_subshell): Mark local as volatile if checking for lint,
11421 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11422 (MAXPATHLEN): Define only if needed.
a70072c9 11423
a0977c44
PE
11424 * process.c (serial_open, serial_configure): Move decls from here ...
11425 * systty.h: ... to here, so that they can be checked.
11426
a884fdcc
PE
11427 * fns.c (get_random, seed_random): Move extern decls from here ...
11428 * lisp.h: ... to here, so that they can be checked.
11429
604efe86 11430 * sysdep.c (reset_io): Now static.
b8950c94 11431 (wait_for_termination_signal): Remove; unused.
604efe86 11432
38fc62d9
PE
11433 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11434 (copy_keymap_item, append_key, push_text_char_description):
11435 Now static.
1004a21a 11436 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11437 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11438 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11439 (describe_map_tree):
11440 Rename locals to avoid shadowing.
38fc62d9 11441
2f2650da
PE
11442 * keyboard.c: Declare functions static if they are not used elsewhere.
11443 (echo_char, echo_dash, cmd_error, top_level_2):
11444 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11445 (read_char, kbd_buffer_get_event, make_lispy_position):
11446 (make_lispy_event, make_lispy_movement, apply_modifiers):
11447 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11448 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11449 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11450 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11451 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11452
a053e86c 11453 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11454 (mark_kboards): Move decl here ...
11455 * alloc.c (mark_kboards): ... from here.
a053e86c 11456
4752793e
PE
11457 * lisp.h (force_auto_save_soon): New decl.
11458
74f10ca7 11459 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11460 (DEFINE_DUMMY_FUNCTION): New macro.
11461 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11462 Use it.
c03cd23f
PE
11463 (main): Add casts to avoid warnings
11464 if GCC considers string literals to be constants.
74f10ca7 11465
022e70d4
PE
11466 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11467
59d6fe83
PE
11468 * dbusbind.c: Pointer signedness fixes.
11469 (xd_signature, xd_append_arg, xd_initialize):
11470 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11471 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11472 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11473 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11474
78320123
PE
11475 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11476 if GCC considers string literals to be constants.
49cebcca 11477 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11478
35ac2a97
SM
114792011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11480
fb103ca9
SM
11481 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11482 (print_preprocess, print_object): New macro to fix last change.
11483
35ac2a97
SM
11484 * print.c (print_preprocess): Don't forget font objects.
11485
62973b41
JB
114862011-03-16 Juanma Barranquero <lekktu@gmail.com>
11487
11488 * emacs.c (USAGE3): Doc fixes.
11489
0e48bb22
AS
114902011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11491
11492 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11493 structure.
11494
7684e57b
JB
114952011-03-14 Juanma Barranquero <lekktu@gmail.com>
11496
11497 * lisp.h (VWindow_system, Qfile_name_history):
11498 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11499 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11500 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11501
11502 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11503 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11504
11505 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11506 * w32console.c (detect_input_pending, read_input_pending)
11507 (encode_terminal_code):
11508 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11509 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11510 (w32_system_caret_y, Qfile_name_history):
11511 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11512 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11513 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11514 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11515 * w32proc.c (Qlocal, report_file_error):
11516 * w32term.c (Vwindow_system, updating_frame):
11517 * w32uniscribe.c (initialized, uniscribe_font_driver):
11518 Remove unneeded extern declarations.
11519
2aa46d6c
CY
115202011-03-14 Chong Yidong <cyd@stupidchicken.com>
11521
c96bbc66 11522 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11523
cffc6f3b
CY
115242011-03-13 Chong Yidong <cyd@stupidchicken.com>
11525
11526 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11527 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11528 These macros can no longer be used for assignment.
11529
44f230aa
SM
11530 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11531 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11532 (record_buffer_markers, fetch_buffer_markers): New functions for
11533 recording and fetching special buffer markers.
11534 (set_buffer_internal_1, set_buffer_temp): Use them.
11535
11536 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11537
11538 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11539
11540 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11541 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11542
11543 * xdisp.c (hscroll_window_tree):
11544 (reconsider_clip_changes): Use PT instead of BUF_PT.
11545
d251f04b
EZ
115462011-03-13 Eli Zaretskii <eliz@gnu.org>
11547
11548 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11549 $(EMACS_ROOT)/lib/intprops.h.
11550
f0c77cd1
PE
115512011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11552
3eca4629
PE
11553 Fix more problems found by GCC 4.5.2's static checks.
11554
7c86ee98
PE
11555 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11556 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11557 (xg_free_frame_widgets): Make it clear that a local variable is
11558 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11559 (gdk_window_get_screen): Make it clear that this macro is needed
11560 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11561 (int_gtk_range_get_value): New function, which avoids a diagnostic
11562 from gcc -Wbad-function-cast.
11563 (xg_set_toolkit_scroll_bar_thumb): Use it.
11564 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11565 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11566 (get_utf8_string, xg_get_file_with_chooser):
11567 Rename locals to avoid shadowing.
11568 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11569
41729b81
PE
11570 * xgselect.c (xg_select): Remove unused var.
11571
f0c77cd1
PE
11572 * image.c (four_corners_best): Mark locals as initialized.
11573 (gif_load): Initialize transparent_p to zero (Bug#8238).
11574 Mark another local as initialized.
ec6cf4c6 11575 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11576
ce0ad53d 11577 * image.c (clear_image_cache): Now static.
d5d5a617 11578 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11579 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11580 (x_edge_detection): Remove unnecessary cast that
11581 gcc -Wbad-function-cast diagnoses.
2037898d 11582 (gif_load): Fix pointer signedness.
6ae141d6
PE
11583 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11584 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11585
33383987 115862011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11587
d32df629
PE
11588 Improve quality of tests for time stamp overflow.
11589 For example, without this patch (encode-time 0 0 0 1 1
11590 1152921504606846976) returns the obviously-bogus value (-948597
11591 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11592 reports time overflow. See
11593 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11594 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11595 * editfns.c: Include limits.h and intprops.h.
11596 (TIME_T_MIN, TIME_T_MAX): New macros.
11597 (time_overflow): Move earlier, to before first use.
11598 (hi_time, lo_time): New functions, for an accurate test for
11599 out-of-range times.
11600 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11601 (Fget_internal_run_time): Don't assume time_t fits in int.
11602 (make_time): Use list2 instead of Fcons twice.
11603 (Fdecode_time): More accurate test for out-of-range times.
11604 (check_tm_member): New function.
11605 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11606 (lisp_time_argument): Don't rely on undefined left-shift and
11607 right-shift behavior when checking for time stamp overflow.
8be6f318 11608
fe31d94c
PE
11609 * editfns.c (time_overflow): New function, refactoring common code.
11610 (Fformat_time_string, Fdecode_time, Fencode_time):
11611 (Fcurrent_time_string): Use it.
11612
8be6f318
PE
11613 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11614 * dired.c (make_time): Move to ...
11615 * editfns.c (make_time): ... here.
11616 * systime.h: Note the move.
11617
09d9db2c 116182011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11619
126bc0dc
YM
11620 * fringe.c (update_window_fringes): Remove unused variables.
11621
c47cbdfd
YM
11622 * unexmacosx.c (copy_data_segment): Also copy __got section.
11623 (Bug#8223)
11624
7ac80be9
EZ
116252011-03-12 Eli Zaretskii <eliz@gnu.org>
11626
c96bbc66 11627 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11628 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11629 Constify `char *' arguments and their references according to
11630 prototypes in tparam.h.
11631
ecb0f94d 11632 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11633
7ac80be9
EZ
11634 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11635 Adapt all references accordingly.
11636
11637 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11638
ef1fd07e
TT
116392011-03-11 Tom Tromey <tromey@redhat.com>
11640
11641 * buffer.c (syms_of_buffer): Remove obsolete comment.
11642
7ef4b50c
EZ
116432011-03-11 Eli Zaretskii <eliz@gnu.org>
11644
11645 * termhooks.h (encode_terminal_code): Declare prototype.
11646
11647 * msdos.c (encode_terminal_code): Don't declare prototype.
11648
11649 * term.c (encode_terminal_code): Now external again, used by
11650 w32console.c and msdos.c.
11651
44f230aa
SM
11652 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11653 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11654
4b1ec863 116552011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11656
1714f52b 11657 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11658
4b1ec863
PE
11659 * fringe.c (update_window_fringes): Mark locals as initialized
11660 (Bug#8227).
11661 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11662
524c7aa6
PE
11663 * alloc.c (mark_fringe_data): Move decl from here ...
11664 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11665 to check its interface.
11666 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11667
a5c0af81 11668 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11669 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11670 (fontset_font): Mark local as initialized.
a9a06e0b 11671 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11672
b4716021
PE
11673 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11674
811e9bac 11675 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11676 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11677 (x_own_selection, Fx_disown_selection_internal): Rename locals
11678 to avoid shadowing.
11679 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11680
7e3ab302
PE
11681 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11682 so that the caller can use some name other than gcpro1.
11683 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11684 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11685 (Fx_backspace_delete_keys_p):
11686 Use them to avoid shadowing, and rename vars to avoid shadowing.
11687 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11688 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11689 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11690 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11691 Remove unused locals.
7e3ab302
PE
11692 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11693 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11694 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11695 macros.
f78faa98 11696
e2b13473
PE
11697 * xterm.h (x_mouse_leave): New decl.
11698
77f23912
PE
11699 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11700 Remove unused functions.
cdf4ba58
PE
11701 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11702 (x_calc_absolute_position): Now static.
7411c686 11703 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11704 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11705 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11706 unless they are used.
38d0b34a
PE
11707 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11708 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11709 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11710 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11711 (x_error_catcher, x_connection_closed, x_error_handler):
11712 (x_error_quitter, xembed_send_message, x_iconify_frame):
11713 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11714 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11715 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11716
44f230aa
SM
11717 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11718 Rename or move locals to avoid shadowing.
6b463e58 11719 (tty_defined_color, merge_face_heights): Now static.
5967d051 11720 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11721 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11722 does not deduce is never used uninitialized.
73719eba
PE
11723 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11724 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11725
426994c3 11726 * terminal.c (store_terminal_param): Now static.
5489860b 11727
032f1620 11728 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11729 (set_frame_menubar): Remove unused local.
d4323972 11730 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11731 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11732 since they might point to immutable storage.
281585b0
PE
11733 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11734 since it's unused otherwise.
032f1620 11735
367c19e5 11736 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11737 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11738 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11739 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11740 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11741 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11742 does not deduce are never used uninitialized.
70739cbe 11743
07b48fa9
PE
11744 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11745
8868a238 11746 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11747 * window.c (window_loop, size_window):
11748 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11749
7e5cf297 11750 * window.c (display_buffer): Now static.
d6550a9f
PE
11751 (size_window): Mark variables that gcc -Wuninitialized
11752 does not deduce are never used uninitialized.
a586633d
PE
11753 * window.h (check_all_windows): New decl, to forestall
11754 gcc -Wmissing-prototypes diagnostic.
5b555da1 11755 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11756
f6095868
PE
11757 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11758 shadowing.
11759 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11760 Include <limits.h>.
11761 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11762 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11763 (load_charset_map): Mark variables that gcc -Wuninitialized
11764 does not deduce are never used uninitialized.
53df7c11 11765 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11766
f38b440c
PE
11767 * coding.c (coding_set_source, coding_set_destination):
11768 Use "else { /* comment */ }" rather than "else /* comment */;"
11769 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11770 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11771 a block, when the outer 'i' will do.
11772 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11773 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11774 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11775 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11776 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11777 Rename locals to avoid shadowing.
11778 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11779 * coding.c (emacs_mule_char, encode_invocation_designation):
11780 Now static, since they're not used elsewhere.
413bb2db 11781 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11782 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11783 (decode_coding_emacs_mule): Mark variables that gcc
11784 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11785 (detect_coding_iso_2022): Initialize a local variable that might
11786 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11787 this initialization is needed. (Bug#8211)
5f58e762
PE
11788 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11789 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11790 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11791 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11792 Remove unused macros.
f38b440c 11793
232b38b9 11794 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11795 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11796 * character.c (string_count_byte8): Likewise.
232b38b9 11797
fb90da1b
PE
11798 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11799 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11800
fb93dbc2
PE
11801 * chartab.c (copy_sub_char_table): Now static, since it's not used
11802 elsewhere.
5c156ace
PE
11803 (sub_char_table_ref_and_range, char_table_ref_and_range):
11804 Rename locals to avoid shadowing.
bbcd0949 11805 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11806
7d3b3862 11807 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11808 (BIDI_BOB): Remove unused macro.
7d3b3862 11809
6be7d3da
PE
11810 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11811 deduce are never used uninitialized.
c2ed9c8b 11812 * term.c (encode_terminal_code): Likewise.
6be7d3da 11813
75f8807f 11814 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11815
50938595
PE
11816 * tparam.h: New file.
11817 * term.c, tparam.h: Include it.
11818 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11819 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11820 Move these decls to tparam.h, and make them agree with what
11821 is actually in tparam.c. The previous trick of using incompatible
11822 decls in different modules does not conform to the C standard.
11823 All callers of tparam changed to use tparam's actual API.
11824 * tparam.c (tparam1, tparam, tgoto):
11825 Use const pointers where appropriate.
11826
fbceeba2
PE
11827 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11828 * cm.h (struct cm): Likewise.
11829 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11830 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11831 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11832 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11833 (turn_on_face, init_tty): Likewise.
11834 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11835
7f3f1250
PE
11836 * term.c (term_mouse_position): Rename local to avoid shadowing.
11837
e6ca6543
PE
11838 * alloc.c (mark_ttys): Move decl from here ...
11839 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11840
c40f8d15
AS
118412011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11842
11843 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11844
cfe0661d
JB
118452011-03-09 Juanma Barranquero <lekktu@gmail.com>
11846
11847 * search.c (compile_pattern_1): Remove argument regp, unused since
11848 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11849 (compile_pattern): Don't pass it.
11850
0afb4571
J
118512011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11852
11853 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11854 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11855 for ! HAVE_GTK3.
11856 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11857
11858 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11859
11860 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11861 gdk_window_get_screen, gdk_window_get_geometry,
11862 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11863 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11864 (xg_get_pixbuf_from_pixmap): New function.
11865 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11866 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11867 Call xg_get_pixbuf_from_pixmap instead of
11868 gdk_pixbuf_get_from_drawable.
11869 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11870 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11871 (xg_check_special_colors): Use GtkStyleContext and its functions
11872 for HAVE_GTK3.
11873 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11874 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11875 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11876 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11877 Call gtk_widget_get_preferred_size.
0afb4571
J
11878 (xg_frame_resized): gdk_window_get_geometry only takes 5
11879 parameters.
44f230aa
SM
11880 (xg_win_to_widget, xg_event_is_for_menubar):
11881 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11882 (xg_set_widget_bg): New function.
11883 (delete_cb): New function.
895009e1 11884 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11885 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11886 (xg_set_background_color): Call xg_set_widget_bg.
11887 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11888 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11889 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11890 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11891 if ! HAVE_GTK3.
11892 (update_frame_tool_bar): Call gtk_widget_hide.
11893 (xg_initialize): Use GDK_KEY_g.
11894
11895 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11896 if ! HAVE_GTK3
11897 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11898
11899 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11900 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11901 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11902
1c2cc4ef
JB
119032011-03-08 Juanma Barranquero <lekktu@gmail.com>
11904
11905 * w32xfns.c (select_palette): Check success of RealizePalette against
11906 GDI_ERROR, not zero.
11907
33383987 11908See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11909
11910;; Local Variables:
11911;; coding: utf-8
aac0c6e3
MR
11912;; End:
11913
2f097256 11914 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11915
11916 This file is part of GNU Emacs.
11917
11918 GNU Emacs is free software: you can redistribute it and/or modify
11919 it under the terms of the GNU General Public License as published by
11920 the Free Software Foundation, either version 3 of the License, or
11921 (at your option) any later version.
11922
11923 GNU Emacs is distributed in the hope that it will be useful,
11924 but WITHOUT ANY WARRANTY; without even the implied warranty of
11925 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11926 GNU General Public License for more details.
11927
11928 You should have received a copy of the GNU General Public License
11929 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.