* syntax.c (skip_chars): Likewise.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
762f8d96 12011-04-09 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2
bbf47d44
PE
3 * charset.c (load_charset_map): <, not <=, for optimization,
4 and to avoid potential problems with integer overflow.
9248994d 5 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7 * editfns.c (Fformat): Likewise.
1e69125e 8 * syntax.c (skip_chars): Likewise.
3befa583 9
e3019616
PE
10 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11 This also lets GCC 4.6.0 generate slightly better loop code.
12
becfa255
PE
13 * callint.c (Fcall_interactively): <, not <=, for optimization.
14 (Fcall_interactively): Count the number of arguments produced,
15 not the number of arguments given. This is simpler and lets GCC
16 4.6.0 generate slightly better code.
17
dae0cd48
PE
18 * ftfont.c: Distingish more carefully between FcChar8 and char.
19 The previous code passed unsigned char * to a functions like
20 strlen and xstrcasecmp that expect char *, which does not
21 conform to the C standard.
22 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
23 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
24 char * when the C standard requires it.
25
76032d70
PE
26 * keyboard.c (read_char): Remove unused var.
27
eb3f1cc8
PE
28 * eval.c: Port to Windows vsnprintf (Bug#8435).
29 Include <limits.h>.
30 (SIZE_MAX): Define if the headers do not.
31 (verror): Do not give up if vsnprintf returns a negative count.
32 Instead, grow the buffer. This ports to Windows vsnprintf, which
33 does not conform to C99. Problem reported by Eli Zaretskii.
34 Also, simplify the allocation scheme, by avoiding the need for
35 calling realloc, and removing the ALLOCATED variable.
36
70476b54
PE
37 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
38
ea6c7ae6
PE
39 Remove the doprnt implementation, as Emacs now uses vsnprintf.
40 * doprnt.c: Remove.
41 * lisp.h (doprnt): Remove.
42 * Makefile.in (base_obj): Remove doprnt.o.
43 * deps.mk (doprnt.o): Remove.
44
5fdb398c
PE
45 error: Print 32- and 64-bit integers portably (Bug#8435).
46 Without this change, on typical 64-bit hosts error ("...%d...", N)
47 was used to print both 32- and 64-bit integers N, which relied on
48 undefined behavior.
49 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
50 New macro.
51 * lisp.h (error, verror): Mark as printf-like functions.
52 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
53 Report overflow in size calculations when allocating printf buffer.
54 Do not truncate output string at its first null byte.
55 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
56 Truncate the output at a character boundary, since vsnprintf does not
57 do that.
58 * charset.c (check_iso_charset_parameter): Convert internal
59 character to string before calling 'error', since %c now has the
60 printf meaning.
61 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
62 overflow when computing char to be passed to 'error'. Do not
63 pass Lisp_Object to 'error'; pass the integer instead.
64 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
65 formatted with plain %d.
66
b189fa66
PE
67 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
68
bff87ef0
PE
69 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
70
7e2cac20
PE
71 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
72
ce4d90b5
PE
73 * xterm.c (x_catch_errors): Remove duplicate declaration.
74
266c9547
PE
75 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
76
79c49ad2
PE
77 * xdisp.c, lisp.h (message_nolog): Remove; unused.
78
8546720e 792011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 80
8546720e
GM
81 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
82 unsigned char, to match FcChar8 type definition.
aac0c6e3 83
8546720e
GM
84 * xterm.c (handle_one_xevent):
85 * xmenu.c (create_and_show_popup_menu):
86 * xselect.c (x_decline_selection_request)
87 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 88
a53e2e89
EZ
892011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
90
91 Fix some uses of `int' instead of EMACS_INT.
92 * search.c (string_match_1, fast_string_match)
93 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
94 (scan_buffer, find_next_newline_no_quit)
95 (find_before_next_newline, search_command, Freplace_match)
96 (Fmatch_data): Make some `int' variables be EMACS_INT.
97
98 * xdisp.c (display_count_lines): 3rd argument and return value now
99 EMACS_INT. All callers changed.
100 (pint2hrstr): Last argument is now EMACS_INT.
101
102 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
103 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
104 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
105 (decode_coding_utf_16, decode_coding_emacs_mule)
106 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
107 (decode_coding_ccl, decode_coding_charset)
108 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
109 (decode_coding_iso_2022, decode_coding_emacs_mule)
110 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
111 <char_offset, last_offset>: Declare EMACS_INT.
112 (encode_coding_utf_8, encode_coding_utf_16)
113 (encode_coding_emacs_mule, encode_invocation_designation)
114 (encode_designation_at_bol, encode_coding_iso_2022)
115 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
116 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
117 Declare EMACS_INT.
118 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
119 (encode_invocation_designation): Last argument P_NCHARS is now
120 EMACS_INT.
121 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
122 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
123
124 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
125 All users changed.
126
127 * ccl.c (Fccl_execute_on_string): Declare some variables
128 EMACS_INT.
129
8546720e 1302011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
131
132 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
133
4e19a977
CS
1342011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
135
136 * process.c (Fformat_network_address): Doc fix.
137
87302331
R
1382011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
139
140 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
141
cbb59342
CY
1422011-04-08 Chong Yidong <cyd@stupidchicken.com>
143
144 * keyboard.c (read_char): Call Lisp function help-form-show,
145 instead of using internal_with_output_to_temp_buffer.
146 (Qhelp_form_show): New var.
e0d38eeb 147 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
148
149 * print.c (internal_with_output_to_temp_buffer): Function deleted.
150
151 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
152
e67a13ab
CY
1532011-04-06 Chong Yidong <cyd@stupidchicken.com>
154
155 * process.c (Flist_processes): Removed to Lisp.
156 (list_processes_1): Deleted.
157
973f782d
EZ
1582011-04-06 Eli Zaretskii <eliz@gnu.org>
159
7c106b1e
EZ
160 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
161
973f782d
EZ
162 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
163
41cf7d1a 1642011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 165
ca23cc88
PE
166 Fix more problems found by GCC 4.6.0's static checks.
167
f390e2d5
PE
168 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
169
42eea0d0
PE
170 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
171
b69769da 172 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 173
f9541e84
PE
174 * xdisp.c (vmessage): Mark as a printf-like function.
175
13841b55
PE
176 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
177
c136c10f
PE
178 * sound.c (sound_warning): Don't crash if arg contains a printf format.
179
5e2d4a30
PE
180 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
181 printf-like functions.
182 (tiff_load): Add casts to remove these marks before passing them
183 to system-supplied API.
184
583f48b9
PE
185 * eval.c (Fsignal): Remove excess argument to 'fatal'.
186
b25d760e
PE
187 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
188 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
189 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
190 directly, rather than having caller test rule sign. This avoids
191 some unnecessary tests.
192 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
193 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
194 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 195
bc7b6697 196 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 197 (xfont_open): Avoid unnecessary tests.
bc7b6697 198
27ccc379
PE
199 * composite.c (composition_gstring_put_cache): Use unsigned integer.
200
dcd5c89a
PE
201 * composite.h, composite.c (composition_gstring_put_cache):
202 Use EMACS_INT, not int, for length.
203
b13a45c6
PE
204 * composite.h (COMPOSITION_DECODE_REFS): New macro,
205 breaking out part of COMPOSITION_DECODE_RULE.
206 (COMPOSITION_DECODE_RULE): Use it.
207 * composite.c (get_composition_id): Remove unused local vars,
208 by using the new macro.
209
1e792e4d
PE
210 * textprop.c (set_text_properties_1): Change while to do-while,
211 since the condition is always true at first.
212
dc6c6455 213 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
214 (interval_deletion_adjustment): Return unsigned value.
215 All uses changed.
dc6c6455 216
aba7731a
PE
217 * process.c (list_processes_1, create_pty, read_process_output):
218 (exec_sentinel): Remove vars that were set but not used.
afd4052b 219 (create_pty): Remove unnecessary "volatile"s.
bc57d757 220 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 221 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 222 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 223
fdfc4bf3
PE
224 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
225
fca8fe46 226 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 227 (update_syntax_table): Use unsigned instead of int.
fca8fe46 228
06a0259a 229 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 230 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 231 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 232
e7b9e80f
PE
233 * print.c (print_error_message): Avoid int overflow.
234
56201685
PE
235 * font.c (font_list_entities): Redo for clarity,
236 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
237
78834453 238 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 239 (font_score): Avoid potential overflow in diff calculation.
78834453 240
0bc0b309 241 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 242 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 243
e610eaca
PE
244 * eval.c (funcall_lambda): Rename local to avoid shadowing.
245
b895abce
PE
246 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
247 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
248 can always succeed if overflow has undefined behavior.
249
1f1d9321 250 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 251 (wordify): Omit three unnecessary tests.
1f1d9321 252
c59478bc
PE
253 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
254 All callers changed. This avoids the need for an unused var.
255
79b73827
PE
256 * casefiddle.c (casify_region): Remove var that is set but not used.
257
a4db5dfe
PE
258 * dired.c (file_name_completion): Remove var that is set but not used.
259
43aae36e
PE
260 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
261
2a47c44d 262 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 263 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 264
a37c69bf
PE
265 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
266 Check for integer overflow on size calculations.
267
328ab8e7
PE
268 * buffer.c (Fprevious_overlay_change): Remove var that is set
269 but not used.
270
e5a2a5cb
PE
271 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
272 Remove vars that are set but not used.
8d84a6eb 273 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 274 (timer_check_2): Mark vars as initialized.
e5a2a5cb 275
a60e5f68
PE
276 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
277
f661cb61 278 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 279 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 280
f0397f5a
PE
281 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
282 that are set but not used.
283
8664db06 284 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 285 if XCreateBitmapFromData fails (Bug#8410).
8664db06 286
6abdaa4a
PE
287 * xselect.c (x_get_local_selection, x_handle_property_notify):
288 Remove vars that are set but not used.
289
0ce7538d 290 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 291 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 292
9ae848fc
PE
293 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
294 Remove var that is set but not used.
0b918413
PE
295 (scroll_bar_windows_size): Now size_t, not int.
296 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
297 Check for overflow.
9ae848fc 298
a5a62657
PE
299 * xfaces.c (realize_named_face): Remove vars that are set but not used.
300 (map_tty_color) [!defined MSDOS]: Likewise.
301
5c5cdd39
PE
302 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
303
66ebf983
PE
304 * coding.c: Remove vars that are set but not used.
305 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
306 All callers changed.
307 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
308 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
309 (decode_coding_charset): Remove vars that are set but not used.
310
1be4d761
PE
311 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
312 that is set but not used.
313
47553fa8
PE
314 * print.c (print_object): Remove var that is set but not used.
315
1f7196bf 316 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
317 The gnulib version avoids calling malloc in the usual case,
318 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
319 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
320 * filelock.c (current_lock_owner): Likewise.
321 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
322 * sysdep.c: Include allocator.h, careadlinkat.h.
323 (emacs_no_realloc_allocator): New static constant.
324 (emacs_readlink): New function.
fdb61804
PE
325 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
326 ../lib/careadlinkat.h.
d1fdcab7 327
f84c17c7
SM
3282011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
329
330 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
331 first non-nil return value).
332
ef3862ad
JD
3332011-04-03 Jan Djärv <jan.h.d@swipnet.se>
334
335 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
336 if not defined (Bug#8403).
337
376a7006
JB
3382011-04-02 Juanma Barranquero <lekktu@gmail.com>
339
340 * xdisp.c (display_count_lines): Remove parameter `start',
341 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
342 (get_char_face_and_encoding): Remove parameter `multibyte_p',
343 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
344 (fill_stretch_glyph_string): Remove parameters `row' and `area',
345 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
346 and thereabouts. All callers changed.
347 (get_per_char_metric): Remove parameter `f', unused since
348 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
349
6ca3801d
JM
3502011-04-02 Jim Meyering <meyering@redhat.com>
351
352 do not dereference NULL upon failed strdup
353 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
354 (ns_get_family): Likewise.
355
d8e2b5ba
JB
3562011-04-02 Juanma Barranquero <lekktu@gmail.com>
357
358 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
359
8c74fcbd
JD
3602011-04-02 Jan Djärv <jan.h.d@swipnet.se>
361
362 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
363 later (Bug#8403).
364
7200d79c
SM
3652011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
366
03408648 367 Add lexical binding.
7200d79c 368
03408648
SM
369 * window.c (Ftemp_output_buffer_show): New fun.
370 (Fsave_window_excursion):
371 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
372
373 * lread.c (lisp_file_lexically_bound_p): New function.
374 (Fload): Bind Qlexical_binding.
375 (readevalloop): Remove `evalfun' arg.
376 Bind Qinternal_interpreter_environment.
377 (Feval_buffer): Bind Qlexical_binding.
378 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
379 Mark as dynamic.
380 (syms_of_lread): Declare `lexical-binding'.
381
382 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
383
384 * keyboard.c (eval_dyn): New fun.
385 (menu_item_eval_property): Use it.
ca105506
SM
386
387 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 388
03408648
SM
389 * fns.c (concat, mapcar1): Accept byte-code-functions.
390
391 * eval.c (Fsetq): Handle lexical vars.
392 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
393 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
394 (FletX, Flet): Obey lexical binding.
395 (Fcommandp): Handle closures.
396 (Feval): New `lexical' arg.
397 (eval_sub): New function extracted from Feval. Use it almost
398 everywhere where Feval was used. Look up vars in lexical env.
399 Handle closures.
400 (Ffunctionp): Move from subr.el.
401 (Ffuncall): Handle closures.
402 (apply_lambda): Remove `eval_flags'.
403 (funcall_lambda): Handle closures and new byte-code-functions.
404 (Fspecial_variable_p): New function.
405 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
406 but without exporting it to Lisp.
23aba0ea 407
23aba0ea 408 * doc.c (Fdocumentation, store_function_docstring):
03408648 409 * data.c (Finteractive_form): Handle closures.
23aba0ea 410
03408648
SM
411 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
412 interactive spec.
ba83908c 413
03408648
SM
414 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
415 byte-codes.
416 (exec_byte_code): New function extracted from Fbyte_code to handle new
417 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 418
03408648 419 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 420
03408648 421 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 422
e2abce01
JB
4232011-03-31 Juanma Barranquero <lekktu@gmail.com>
424
425 * xdisp.c (redisplay_internal): Fix prototype.
426
63696a73 4272011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 428
63696a73
EZ
429 * xdisp.c (SCROLL_LIMIT): New macro.
430 (try_scrolling): Use it when setting scroll_limit. Limit
431 scrolling to 100 screen lines.
432 (redisplay_window): Even when falling back on "recentering",
433 position point in the window according to scroll-conservatively,
434 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
435
436 (try_scrolling): When point is above the window, allow searching
437 as far as scroll_max, or one screenful, to compute vertical
438 distance from PT to the scroll margin position. This prevents
439 try_scrolling from unnecessarily failing when
440 scroll-conservatively is set to a value slightly larger than the
441 window height. Clean up the case of PT below the margin at bottom
442 of window: scroll_max can no longer be INT_MAX. When aggressive
443 scrolling is in use, don't let point enter the opposite scroll
444 margin as result of the scroll.
445 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
446 threshold of 100 lines for never-recentering scrolling.
447
e4cc2dfc
JB
4482011-03-31 Juanma Barranquero <lekktu@gmail.com>
449
450 * dispextern.h (move_it_by_lines):
451 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
452 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
453 (message_log_check_duplicate): Remove parameters `prev_bol' and
454 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
455 (redisplay_internal): Remove parameter `preserve_echo_area',
456 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
457
458 * indent.c (Fvertical_motion):
459 * window.c (window_scroll_pixel_based, Frecenter):
460 Don't pass `need_y_p' to `move_it_by_lines'.
461
1c470562
SM
4622011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
463
44f230aa
SM
464 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
465 steal a few bits to be more compact.
466 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
467 Remove unneeded casts.
468
1c470562
SM
469 * bytecode.c (Fbyte_code): CAR and CDR can GC.
470
888adce9
ZK
4712011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
472
473 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
474 binding" message (bug#7967).
475
f838ed7b
PE
4762011-03-30 Paul Eggert <eggert@cs.ucla.edu>
477
77861b95
PE
478 Fix more problems found by GCC 4.6.0's static checks.
479
de6dbc14
PE
480 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
481 Remove unused local var.
482
f838ed7b
PE
483 * editfns.c (Fmessage_box): Remove unused local var.
484
792c7b2b
PE
485 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
486 (note_mode_line_or_margin_highlight, note_mouse_highlight):
487 Omit unused local vars.
c499e557 488 * window.c (shrink_windows): Omit unused local var.
b01a1c29 489 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
490 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
491 Omit unused local var.
492
ba0165e1
PE
493 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
494 Don't assume string length fits in int.
32ad8845 495 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 496 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 497
3c59b4c9
PE
498 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
499 instead of alloca (Bug#8344).
500
a3eed478 501 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 502 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 503
eb4d412d
PE
504 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
505
1658b401
PE
506 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
507 concerns.
508
509 * term.c (produce_glyphless_glyph): Remove unnecessary test.
510
511 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 512
9a2c6e05
PE
513 * keyboard.c (syms_of_keyboard): Use the same style as later
514 in this function when indexing through an array. This also
515 works around GCC bug 48267.
516
03d0a109
PE
517 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
518
44f730c8
PE
519 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
520
fe75f926
PE
521 * chartab.c (sub_char_table_ref_and_range): Redo for slight
522 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
523
ffa8c828
PE
524 * keyboard.c, keyboard.h (num_input_events): Now size_t.
525 This avoids undefined behavior on integer overflow, and is a bit
526 more convenient anyway since it is compared to a size_t variable.
527
c5101a77
PE
528 Variadic C functions now count arguments with size_t, not int.
529 This avoids an unnecessary limitation on 64-bit machines, which
530 caused (substring ...) to crash on large vectors (Bug#8344).
531 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
532 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 533 All variadic functions and their callers changed accordingly.
c5101a77
PE
534 (struct gcpro.nvars): Now size_t, not int. All uses changed.
535 * data.c (arith_driver, float_arith_driver): Likewise.
536 * editfns.c (general_insert_function): Likewise.
537 * eval.c (struct backtrace.nargs, interactive_p)
538 (internal_condition_case_n, run_hook_with_args, apply_lambda)
539 (funcall_lambda, mark_backtrace): Likewise.
540 * fns.c (concat): Likewise.
541 * frame.c (x_set_frame_parameters): Likewise.
542 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
543 0 if not found, not -1. All callers changed.
544
dd3f25f7
PE
545 * alloc.c (garbage_collect): Don't assume stack size fits in int.
546 (stack_copy_size): Now size_t, not int.
547 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
548
461c2ab9
JB
5492011-03-28 Juanma Barranquero <lekktu@gmail.com>
550
551 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
552 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
553 All callers changed.
554
555 * lisp.h (multibyte_char_to_unibyte):
556 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
557 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
558 * character.h (CHAR_TO_BYTE8):
559 * cmds.c (internal_self_insert):
560 * editfns.c (general_insert_function):
561 * keymap.c (push_key_description):
562 * search.c (Freplace_match):
563 * xdisp.c (message_dolog, set_message_1): All callers changed.
564
f6d62986
SM
5652011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
566
567 * keyboard.c (safe_run_hook_funcall): New function.
568 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
569 don't set the hook to nil, but remove the offending function instead.
570 (Qcommand_hook_internal): Remove, unused.
571 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
572 Vcommand_hook_internal.
573
574 * eval.c (enum run_hooks_condition): Remove.
575 (funcall_nil, funcall_not): New functions.
576 (run_hook_with_args): Call each function through a `funcall' argument.
577 Remove `cond' argument, now redundant.
578 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
579 (Frun_hook_with_args_until_failure): Adjust accordingly.
580 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
581
1db5b1ad
JB
5822011-03-28 Juanma Barranquero <lekktu@gmail.com>
583
584 * dispextern.h (string_buffer_position): Remove declaration.
585
586 * print.c (strout): Remove parameter `multibyte', unused since
587 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
588
589 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
590 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
591 All callers changed.
592
593 * w32.c (_wsa_errlist): Use braces for struct initializers.
594
595 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
596 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
597 All callers changed.
598 (string_buffer_position): Likewise. Also, make static (it's never
599 used outside xdisp.c).
600 (cursor_row_p): Remove parameter `w', unused since
601 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
602 (decode_mode_spec): Remove parameter `precision', introduced during
603 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
604 All callers changed.
605
5ffb62aa
JD
6062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
607
608 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
609
461c2ab9 6102011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
611
612 * nsterm.m (ns_menu_bar_is_hidden): New variable.
613 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
614 (ns_update_auto_hide_menu_bar): New functions.
615 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
616 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
617 ns_constrain_all_frames.
618 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
619 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
620
5c380ffb
JD
6212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
622
623 * nsmenu.m (runDialogAt): Remove argument to timer_check.
624
9af30bdf
GM
6252011-03-27 Glenn Morris <rgm@gnu.org>
626
627 * syssignal.h: Replace RETSIGTYPE with void.
628 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
629 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
630 Replace SIGTYPE with void everywhere.
631 * s/usg5-4-common.h (SIGTYPE): Remove definition.
632 * s/template.h (SIGTYPE): Remove commented out definition.
633
e2abce01
JB
6342011-03-26 Eli Zaretskii <eliz@gnu.org>
635
636 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
637 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
638
f868cd8a
JB
6392011-03-26 Juanma Barranquero <lekktu@gmail.com>
640
59eb0929
JB
641 * w32.c (read_unc_volume): Use parameter `henum', instead of
642 global variable `wget_enum_handle'.
643
644 * keymap.c (describe_vector): Remove parameters `indices' and
645 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
646 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
647
f868cd8a
JB
648 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
649
650 * keyboard.c (timer_check): Remove parameter `do_it_now',
651 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
652 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
653 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
654
655 * keyboard.c (read_char):
656 * w32menu.c (w32_menu_display_help):
657 * xmenu.c (show_help_event, menu_help_callback):
658 Adjust calls to `show_help_echo'.
659
660 * gtkutil.c (xg_maybe_add_timer):
661 * keyboard.c (readable_events):
662 * process.c (wait_reading_process_output):
663 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
664
665 * insdel.c (adjust_markers_gap_motion):
666 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
667 (gap_left, gap_right): Don't call it.
668
2ecf6fdb
CY
6692011-03-25 Chong Yidong <cyd@stupidchicken.com>
670
671 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
672 incurred during fontification.
673
6b1f9ba4
JB
6742011-03-25 Juanma Barranquero <lekktu@gmail.com>
675
676 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
677 (DEFVAR_PER_BUFFER): Don't pass it.
678
679 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
680 (scrolling_window): Don't pass it.
681
0f4a96b5
JB
6822011-03-25 Juanma Barranquero <lekktu@gmail.com>
683
684 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
685
686 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
687 and `suffix'.
688 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
689 of variables specific to SELinux and computation of `encoded_absname'.
690
691 * image.c (XPutPixel): Remove unused variable `height'.
692
693 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
694
695 * unexw32.c (get_section_info): Remove unused variable `section'.
696
697 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
698 (system_process_attributes): Remove unused variable `sess'.
699 (sys_read): Remove unused variable `err'.
700
701 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
702 (w32_wnd_proc): Remove unused variable `isdead'.
703 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
704 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
705 (x_create_tip_frame): Remove unused variable `tem'.
706
707 * w32inevt.c (w32_console_read_socket):
708 Remove unused variable `no_events'.
709
710 * w32term.c (x_draw_composite_glyph_string_foreground):
711 Remove unused variable `width'.
712
1149507c
JB
7132011-03-24 Juanma Barranquero <lekktu@gmail.com>
714
715 * w32term.c (x_set_glyph_string_clipping):
716 Don't pass uninitialized region to CombineRgn.
717
9c88f339
JB
7182011-03-23 Juanma Barranquero <lekktu@gmail.com>
719
720 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
721 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
722 (Fx_close_connection): Remove unused variable `i'.
723
724 * w32font.c (w32font_draw): Return number of glyphs.
725 (w32font_open_internal): Remove unused variable `i'.
726 (w32font_driver): Add missing initializer.
727
728 * w32menu.c (utf8to16): Remove unused variable `utf16'.
729 (fill_in_menu): Remove unused variable `items_added'.
730
731 * w32term.c (last_mouse_press_frame): Remove static global variable.
732 (w32_clip_to_row): Remove unused variable `f'.
733 (x_delete_terminal): Remove unused variable `i'.
734
735 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
736 (NOTHING): Remove unused static global variable.
737 (uniscribe_check_otf): Remove unused variable `table'.
738 (uniscribe_font_driver): Add missing initializers.
739
dee091a3
JD
7402011-03-23 Julien Danjou <julien@danjou.info>
741
742 * term.c (Fsuspend_tty, Fresume_tty):
743 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
744 * window.c (temp_output_buffer_show):
745 * insdel.c (signal_before_change):
746 * frame.c (Fhandle_switch_frame):
747 * fileio.c (Fdo_auto_save):
748 * emacs.c (Fkill_emacs):
749 * editfns.c (save_excursion_restore):
750 * cmds.c (internal_self_insert):
751 * callint.c (Fcall_interactively):
752 * buffer.c (Fkill_all_local_variables):
753 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
754 Use Frun_hooks.
0f4a96b5 755 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
756 unconditionnaly since it does the check itself.
757
2c520ab5 7582011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 759
c9c49752
PE
760 Fix more problems found by GCC 4.5.2's static checks.
761
8abc3f12
PE
762 * coding.c (encode_coding_raw_text): Avoid unnecessary test
763 the first time through the loop, since we know p0 < p1 then.
764 This also avoids a gcc -Wstrict-overflow warning.
765
a2d26660
PE
766 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
767 leading to a memory leak, possible in functions like
768 load_charset_map_from_file that can allocate an unbounded number
b12ef411 769 of objects (Bug#8318).
a2d26660 770
916c72e9
PE
771 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
772 that could (at least in theory) be that large.
773
19ab8a18
PE
774 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
775 This is less likely to overflow, and avoids undefined behavior if
776 overflow does occur. All callers changed. Use strtoul to scan
777 for the unsigned long integer.
b7cbbd6f
PE
778 (pint2hrstr): Simplify and tune code slightly.
779 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 780
f0641eff
PE
781 * scroll.c (do_scrolling): Work around GCC bug 48228.
782 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
783
7f650bb9
PE
784 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
785 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
786 (validate_x_resource_name): Simplify count usage.
787 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 788
37dd57d1
PE
789 * fileio.c (Fcopy_file): Report error if fchown or fchmod
790 fail (Bug#8306).
81e56e61 791
699979fc 792 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 793
401bf9b4
PE
794 * process.c (Fmake_network_process): Use socklen_t, not int,
795 where POSIX says socklen_t is required in portable programs.
796 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 797 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
798 (Fmake_network_process, server_accept_connection):
799 (wait_reading_process_output, read_process_output):
800 Likewise.
801
b93aacde
PE
802 * process.c: Rename or move locals to avoid shadowing.
803 (list_processes_1, Fmake_network_process):
804 (read_process_output_error_handler, exec_sentinel_error_handler):
805 Rename or move locals.
4dc343ee 806 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 807 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 808 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 809 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 810 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 811
af8a867c 812 Make tparam.h and terminfo.c consistent.
44f230aa
SM
813 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
814 Include tparam.h instead, since it declares them.
af8a867c
PE
815 * cm.h (PC): Remove extern decl; tparam.h now does this.
816 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
817 * terminfo.c: Include tparam.h, to check interfaces.
818 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
819 (tparam): Adjust signature to match interface in tparam.h;
820 this removes some undefined behavior. Check that outstring and len
821 are zero, which they always are with Emacs.
822 * tparam.h (PC, BC, UP): New extern decls.
823
0248044d 824 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 825 (xftfont_open): Rename locals to avoid shadowing.
0248044d 826
8ff096c1 827 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
828 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
829 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 830 (ftfont_list): Remove unused local.
49eaafba
PE
831 (get_adstyle_property, ftfont_pattern_entity):
832 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
833 Rename locals to avoid shadowing.
8ff096c1 834
e2be39f6
PE
835 * xfont.c (xfont_list_family): Mark var as initialized.
836
c9735e30
PE
837 * xml.c (make_dom): Now static.
838
8f5201ae
PE
839 * composite.c (composition_compute_stop_pos): Rename local to
840 avoid shadowing.
b246f932
PE
841 (composition_reseat_it): Remove unused locals.
842 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 843 (composition_update_it): Mark var as initialized.
11b61122
PE
844 (find_automatic_composition): Mark vars as initialized,
845 with a FIXME (Bug#8290).
8f5201ae 846
760fbc2c
PE
847 character.h: Rename locals to avoid shadowing.
848 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
849 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
850 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
851 (BUF_DEC_POS): Be more systematic about renaming local temporaries
852 to avoid shadowing.
853
ff08eb85
PE
854 * textprop.c (property_change_between_p): Remove; unused.
855
fc7bf025
PE
856 * intervals.c (interval_start_pos): Now static.
857
235d7abc
PE
858 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
859
44f230aa
SM
860 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
861 Rename locals to avoid shadowing.
3e7d6594 862
50060332
PE
863 * sound.c (wav_play, au_play, Fplay_sound_internal):
864 Fix pointer signedness.
d01f234b 865 (alsa_choose_format): Remove unused local var.
c83b8872
PE
866 (wav_play): Initialize a variable to 0, to prevent undefined
867 behavior (Bug#8278).
50060332 868
c4fc4e30
PE
869 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
870
918436ed
PE
871 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
872
c939f91b
PE
873 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
874 clobbering (Bug#8298).
b9c7f648
PE
875 * sysdep.c (sys_subshell): Likewise.
876 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 877
6bd8c144
PE
878 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
879 This should get cleaned up, so that child_setup has the
880 same signature on all platforms.
881
7710357c 882 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 883 (relocate_fd): Rename locals to avoid shadowing.
7710357c 884
c59da222
CY
8852011-03-22 Chong Yidong <cyd@stupidchicken.com>
886
887 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
888 not to be necessary, and produces flickering.
889
66b87493
GM
8902011-03-20 Glenn Morris <rgm@gnu.org>
891
892 * config.in: Remove file.
893
45b6f6d5
JB
8942011-03-20 Juanma Barranquero <lekktu@gmail.com>
895
896 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
897 are now in src/globals.h.
898 (syms_of_minibuf): Remove spurious & from previous change.
899
3ec03f7e
LL
9002011-03-20 Leo <sdl.web@gmail.com>
901
902 * minibuf.c (completing-read-function): New variable.
903 (completing-read-default): Rename from completing-read.
904 (completing-read): Call completing-read-function.
905
b14e3e21
CY
9062011-03-19 Juanma Barranquero <lekktu@gmail.com>
907
908 * xfaces.c (Fx_load_color_file):
909 Read color file from absolute filename (bug#8250).
910
f2b726e6
JB
9112011-03-19 Juanma Barranquero <lekktu@gmail.com>
912
913 * makefile.w32-in: Update dependencies.
914
09f6ff02
EZ
9152011-03-17 Eli Zaretskii <eliz@gnu.org>
916
917 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
918
29a6015a
PE
9192011-03-17 Paul Eggert <eggert@cs.ucla.edu>
920
a3a6c54e
PE
921 Fix more problems found by GCC 4.5.2's static checks.
922
b766f867
PE
923 * process.c (make_serial_process_unwind, send_process_trap):
924 (sigchld_handler): Now static.
925
be02381c
PE
926 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
927 That way, the code declares only the vars that it needs.
928 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
929 * s/cygwin.h (PTY_ITERATION): Likewise.
930 * s/darwin.h (PTY_ITERATION): Likewise.
931 * s/gnu-linux.h (PTY_ITERATION): Likewise.
932
57048744
PE
933 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
934 * process.c (allocate_pty): Don't declare stb unless it's needed.
935
7914961c 936 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
937 (CONSTANTLIM): Remove; unused.
938 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
939 Define only if needed.
7914961c 940
b3967b18
PE
941 * unexelf.c (unexec): Name an expression,
942 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
943 Use a different way to cause a compilation error if anyone uses
944 n rather than nn, a way that does not involve shadowing.
73366a00 945 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 946
29a6015a
PE
947 * deps.mk (unexalpha.o): Remove; unused.
948
43cfc33e 949 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 950 * unexec.h: New file.
ce701a33
PE
951 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
952 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
953 Depend on unexec.h.
954 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
955 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
956 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 957 Change as necessary to match prototype in unexec.h.
ce701a33 958
01f44d5a
PE
959 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
960 shadowing.
4f63c6bb 961 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 962
a6670b0b
PE
963 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
964 Rename locals to avoid shadowing.
965
cef2010d 966 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 967 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 968
d4d7173a
PE
969 * print.c (Fredirect_debugging_output): Fix pointer signedess.
970
f08b802a
PE
971 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
972 warning when compiling print.c.
973
3ddb0639
PE
974 * font.c (font_unparse_fcname): Abort in an "impossible" situation
975 instead of using an uninitialized var.
5ad03b97 976 (font_sort_entities): Mark var as initialized.
3ddb0639 977
170a2692
PE
978 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
979
e663c700
PE
980 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
981 pointers to constants.
89bc529a 982 (font_parse_fcname): Remove unused vars.
7b81e2d0 983 (font_delete_unmatched): Now static.
ea838e10 984 (font_get_spec): Remove; unused.
13a547c6
PE
985 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
986 (font_update_drivers, Ffont_get_glyphs, font_add_log):
987 Rename or move locals to avoid shadowing.
e663c700 988
2a80c887 989 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 990 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 991
1384fa33 992 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 993 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 994
8b2c52e9
PE
995 * alloc.c (mark_backtrace): Move decl from here ...
996 * lisp.h: ... to here, so that it can be checked.
997
475545b5 998 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 999 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1000 (lisp_indirect_variable): Name an expression,
1001 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1002 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1003
b1349114 1004 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1005 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1006 Use const pointer when appropriate.
b1349114 1007
a2928364
PE
1008 * lisp.h (get_system_name, get_operating_system_release):
1009 Move decls here, to check interfaces.
1010 * process.c (get_operating_system_release): Move decl to lisp.h.
1011 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1012 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1013 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1014 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1015 (Fformat_time_string, Fencode_time, Finsert_char):
1016 (Ftranslate_region_internal, Fformat):
1017 Rename or remove local vars to avoid shadowing.
9710023e 1018 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1019
a415e694
PE
1020 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1021 avoid shadowing.
1022
8ef4622d
PE
1023 * lisp.h (eassert): Check that the argument compiles, even if
1024 ENABLE_CHECKING is not defined.
1025
946f9a5b
PE
1026 * data.c (Findirect_variable): Name an expression, to avoid
1027 gcc -Wbad-function-cast warning.
112396d6 1028 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1029 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1030 (Fmake_variable_buffer_local, Fmake_local_variable):
1031 Mark variables as initialized.
52746918 1032 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1033
e5aab7e7 1034 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1035 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1036 Rename locals to avoid shadowing.
dff45157
PE
1037 (mark_stack): Move local variables into the #ifdef region where
1038 they're used.
7bc26fdb
PE
1039 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1040 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1041 needed otherwise.
1042 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1043 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1044 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1045
e5aab7e7
PE
1046 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1047 avoids undefined behavior in theory.
1048
4da60324
PE
1049 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1050
88043301
PE
1051 Use functions, not macros, for up- and down-casing (Bug#8254).
1052 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1053 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1054 to use the following functions instead of these macros.
1055 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1056 EMACS_INT, since callers assume the returned value fits in int.
1057 (upcase1): Likewise, for UPCASE_TABLE.
1058 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1059 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1060 the race-condition problem in the old DOWNCASE.
88043301 1061
19ed5445
PE
1062 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1063 Rename locals to avoid shadowing.
1064 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1065 (regex_compile, re_search_2, re_match_2_internal):
1066 Remove unused local vars.
952db0d7
PE
1067 (FREE_VAR): Rewrite so as not to use empty "else",
1068 which gcc can warn about.
da053e48 1069 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1070 (RETALLOC_IF): Define only if needed.
1071 (WORDCHAR_P): Likewise. This one is never needed, but is used
1072 only in a comment talking about a compiler bug, so put inside
1073 the #if 0 of that comment.
1074 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1075 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1076 Remove; unused.
19ed5445 1077
1f3561e4 1078 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1079 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1080 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1081
ded6f8f7
PE
1082 * search.c (simple_search): Remove unused var.
1083
dbd37a95
PE
1084 * dired.c (compile_pattern): Move decl from here ...
1085 * lisp.h: ... to here, so that it can be checked.
1086 (struct re_registers): New forward decl.
1087
7e47afad
PE
1088 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1089
85f24f61
PE
1090 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1091 All uses changed.
1092 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1093 Rename locals to avoid shadowing.
5671df8f 1094 (Fvertical_motion): Mark locals as initialized.
85f24f61 1095
181aa2be 1096 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1097 (casify_region): Mark local as initialized.
181aa2be 1098
930d429c
PE
1099 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1100
7082eac6
PE
1101 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1102 New macros, so that the caller can use some names other than
1103 gcpro1, gcpro2, etc.
1104 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1105 of the new macros.
1106 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1107 argument, for consistency with GCPRO2_VAR, etc: it is now the
1108 prefix of the variable, not the variable itself. All uses
1109 changed.
38b2c076
PE
1110 * dired.c (directory_files_internal, file_name_completion):
1111 Rename locals to avoid shadowing.
1112
15206ed9
PE
1113 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1114 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1115 dired.c's scmp function, had undefined behavior.
1116 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1117 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1118 * buffer.h: ... to here, because these macros use current_buffer,
1119 and the new implementation with inline functions needs to have
1120 current_buffer in scope now, rather than later when the macros
1121 are used.
1122 (downcase, upcase1): New static inline functions.
1123 (DOWNCASE, UPCASE1): Reimplement using these functions.
1124 This avoids undefined behavior in expressions like
1125 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1126 from race conditions in accessing the global variables
1127 case_temp1 and case_temp2.
1128 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1129 * lisp.h (case_temp1, case_temp2): Remove their decls.
1130 * character.h (ASCII_CHAR_P): Move from here ...
1131 * lisp.h: ... to here, so that the inline functions mentioned
1132 above can use them.
1133
4a6bea26
PE
1134 * dired.c (directory_files_internal_unwind): Now static.
1135
f14b7e14
PE
1136 * fileio.c (file_name_as_directory, directory_file_name):
1137 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1138 Now static.
2893f146
PE
1139 (file_name_as_directory): Use const pointers when appropriate.
1140 (Fexpand_file_name): Likewise. In particular, newdir might
1141 point at constant storage, so make it a const pointer.
fd4ead52 1142 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1143 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1144 signedness issues.
f839df0c
PE
1145 (Fset_file_times, Finsert_file_contents, auto_save_error):
1146 Rename locals to avoid shadowing.
f14b7e14 1147
5716756e 1148 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1149 (Ftry_completion, Fall_completions): Rename or remove locals
1150 to avoid shadowing.
5716756e 1151
b4c3046a
PE
1152 * marker.c (bytepos_to_charpos): Remove; unused.
1153
b45db522
PE
1154 * lisp.h (verify_bytepos, count_markers): New decls,
1155 so that gcc does not warn that these functions aren't declared.
1156
85876d07
PE
1157 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1158 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1159 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1160 (copy_text): Remove unused local var.
85876d07 1161
03d78a21 1162 * filelock.c (within_one_second): Now static.
b3dd38ab 1163 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1164
5df8f01b
PE
1165 * buffer.c (fix_overlays_before): Mark locals as initialized.
1166 (fix_start_end_in_overlays): Likewise. This function should be
1167 simplified by using pointers-to-pointers, but that's a different
1168 matter.
b1d876f1 1169 (switch_to_buffer_1): Now static.
8f54f30a
PE
1170 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1171 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1172
a70072c9 1173 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1174 Fix pointer signedness issue.
edced198
PE
1175 (sys_subshell): Mark local as volatile if checking for lint,
1176 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1177 (MAXPATHLEN): Define only if needed.
a70072c9 1178
a0977c44
PE
1179 * process.c (serial_open, serial_configure): Move decls from here ...
1180 * systty.h: ... to here, so that they can be checked.
1181
a884fdcc
PE
1182 * fns.c (get_random, seed_random): Move extern decls from here ...
1183 * lisp.h: ... to here, so that they can be checked.
1184
604efe86 1185 * sysdep.c (reset_io): Now static.
b8950c94 1186 (wait_for_termination_signal): Remove; unused.
604efe86 1187
38fc62d9
PE
1188 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1189 (copy_keymap_item, append_key, push_text_char_description):
1190 Now static.
1004a21a 1191 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1192 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1193 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1194 (describe_map_tree):
1195 Rename locals to avoid shadowing.
38fc62d9 1196
2f2650da
PE
1197 * keyboard.c: Declare functions static if they are not used elsewhere.
1198 (echo_char, echo_dash, cmd_error, top_level_2):
1199 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1200 (read_char, kbd_buffer_get_event, make_lispy_position):
1201 (make_lispy_event, make_lispy_movement, apply_modifiers):
1202 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1203 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1204 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1205 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1206 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1207
a053e86c 1208 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1209 (mark_kboards): Move decl here ...
1210 * alloc.c (mark_kboards): ... from here.
a053e86c 1211
4752793e
PE
1212 * lisp.h (force_auto_save_soon): New decl.
1213
74f10ca7 1214 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1215 (DEFINE_DUMMY_FUNCTION): New macro.
1216 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1217 Use it.
c03cd23f
PE
1218 (main): Add casts to avoid warnings
1219 if GCC considers string literals to be constants.
74f10ca7 1220
022e70d4
PE
1221 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1222
59d6fe83
PE
1223 * dbusbind.c: Pointer signedness fixes.
1224 (xd_signature, xd_append_arg, xd_initialize):
1225 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1226 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1227 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1228 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1229
78320123
PE
1230 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1231 if GCC considers string literals to be constants.
49cebcca 1232 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1233
35ac2a97
SM
12342011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1235
fb103ca9
SM
1236 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1237 (print_preprocess, print_object): New macro to fix last change.
1238
35ac2a97
SM
1239 * print.c (print_preprocess): Don't forget font objects.
1240
62973b41
JB
12412011-03-16 Juanma Barranquero <lekktu@gmail.com>
1242
1243 * emacs.c (USAGE3): Doc fixes.
1244
0e48bb22
AS
12452011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1246
1247 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1248 structure.
1249
7684e57b
JB
12502011-03-14 Juanma Barranquero <lekktu@gmail.com>
1251
1252 * lisp.h (VWindow_system, Qfile_name_history):
1253 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1254 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1255 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1256
1257 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1258 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1259
1260 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1261 * w32console.c (detect_input_pending, read_input_pending)
1262 (encode_terminal_code):
1263 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1264 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1265 (w32_system_caret_y, Qfile_name_history):
1266 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1267 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1268 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1269 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1270 * w32proc.c (Qlocal, report_file_error):
1271 * w32term.c (Vwindow_system, updating_frame):
1272 * w32uniscribe.c (initialized, uniscribe_font_driver):
1273 Remove unneeded extern declarations.
1274
2aa46d6c
CY
12752011-03-14 Chong Yidong <cyd@stupidchicken.com>
1276
c96bbc66 1277 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1278
cffc6f3b
CY
12792011-03-13 Chong Yidong <cyd@stupidchicken.com>
1280
1281 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1282 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1283 These macros can no longer be used for assignment.
1284
44f230aa
SM
1285 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1286 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1287 (record_buffer_markers, fetch_buffer_markers): New functions for
1288 recording and fetching special buffer markers.
1289 (set_buffer_internal_1, set_buffer_temp): Use them.
1290
1291 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1292
1293 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1294
1295 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1296 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1297
1298 * xdisp.c (hscroll_window_tree):
1299 (reconsider_clip_changes): Use PT instead of BUF_PT.
1300
d251f04b
EZ
13012011-03-13 Eli Zaretskii <eliz@gnu.org>
1302
1303 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1304 $(EMACS_ROOT)/lib/intprops.h.
1305
f0c77cd1
PE
13062011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1307
3eca4629
PE
1308 Fix more problems found by GCC 4.5.2's static checks.
1309
7c86ee98
PE
1310 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1311 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1312 (xg_free_frame_widgets): Make it clear that a local variable is
1313 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1314 (gdk_window_get_screen): Make it clear that this macro is needed
1315 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1316 (int_gtk_range_get_value): New function, which avoids a diagnostic
1317 from gcc -Wbad-function-cast.
1318 (xg_set_toolkit_scroll_bar_thumb): Use it.
1319 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1320 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1321 (get_utf8_string, xg_get_file_with_chooser):
1322 Rename locals to avoid shadowing.
1323 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1324
41729b81
PE
1325 * xgselect.c (xg_select): Remove unused var.
1326
f0c77cd1
PE
1327 * image.c (four_corners_best): Mark locals as initialized.
1328 (gif_load): Initialize transparent_p to zero (Bug#8238).
1329 Mark another local as initialized.
ec6cf4c6 1330 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1331
ce0ad53d 1332 * image.c (clear_image_cache): Now static.
d5d5a617 1333 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1334 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1335 (x_edge_detection): Remove unnecessary cast that
1336 gcc -Wbad-function-cast diagnoses.
2037898d 1337 (gif_load): Fix pointer signedness.
6ae141d6
PE
1338 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1339 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1340
33383987 13412011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1342
d32df629
PE
1343 Improve quality of tests for time stamp overflow.
1344 For example, without this patch (encode-time 0 0 0 1 1
1345 1152921504606846976) returns the obviously-bogus value (-948597
1346 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1347 reports time overflow. See
1348 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1349 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1350 * editfns.c: Include limits.h and intprops.h.
1351 (TIME_T_MIN, TIME_T_MAX): New macros.
1352 (time_overflow): Move earlier, to before first use.
1353 (hi_time, lo_time): New functions, for an accurate test for
1354 out-of-range times.
1355 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1356 (Fget_internal_run_time): Don't assume time_t fits in int.
1357 (make_time): Use list2 instead of Fcons twice.
1358 (Fdecode_time): More accurate test for out-of-range times.
1359 (check_tm_member): New function.
1360 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1361 (lisp_time_argument): Don't rely on undefined left-shift and
1362 right-shift behavior when checking for time stamp overflow.
8be6f318 1363
fe31d94c
PE
1364 * editfns.c (time_overflow): New function, refactoring common code.
1365 (Fformat_time_string, Fdecode_time, Fencode_time):
1366 (Fcurrent_time_string): Use it.
1367
8be6f318
PE
1368 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1369 * dired.c (make_time): Move to ...
1370 * editfns.c (make_time): ... here.
1371 * systime.h: Note the move.
1372
09d9db2c 13732011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1374
126bc0dc
YM
1375 * fringe.c (update_window_fringes): Remove unused variables.
1376
c47cbdfd
YM
1377 * unexmacosx.c (copy_data_segment): Also copy __got section.
1378 (Bug#8223)
1379
7ac80be9
EZ
13802011-03-12 Eli Zaretskii <eliz@gnu.org>
1381
c96bbc66 1382 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1383 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1384 Constify `char *' arguments and their references according to
1385 prototypes in tparam.h.
1386
ecb0f94d 1387 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1388
7ac80be9
EZ
1389 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1390 Adapt all references accordingly.
1391
1392 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1393
ef1fd07e
TT
13942011-03-11 Tom Tromey <tromey@redhat.com>
1395
1396 * buffer.c (syms_of_buffer): Remove obsolete comment.
1397
7ef4b50c
EZ
13982011-03-11 Eli Zaretskii <eliz@gnu.org>
1399
1400 * termhooks.h (encode_terminal_code): Declare prototype.
1401
1402 * msdos.c (encode_terminal_code): Don't declare prototype.
1403
1404 * term.c (encode_terminal_code): Now external again, used by
1405 w32console.c and msdos.c.
1406
44f230aa
SM
1407 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1408 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1409
4b1ec863 14102011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1411
1714f52b 1412 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1413
4b1ec863
PE
1414 * fringe.c (update_window_fringes): Mark locals as initialized
1415 (Bug#8227).
1416 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1417
524c7aa6
PE
1418 * alloc.c (mark_fringe_data): Move decl from here ...
1419 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1420 to check its interface.
1421 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1422
a5c0af81 1423 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1424 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1425 (fontset_font): Mark local as initialized.
a9a06e0b 1426 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1427
b4716021
PE
1428 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1429
811e9bac 1430 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1431 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1432 (x_own_selection, Fx_disown_selection_internal): Rename locals
1433 to avoid shadowing.
1434 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1435
7e3ab302
PE
1436 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1437 so that the caller can use some name other than gcpro1.
1438 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1439 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1440 (Fx_backspace_delete_keys_p):
1441 Use them to avoid shadowing, and rename vars to avoid shadowing.
1442 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1443 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1444 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1445 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1446 Remove unused locals.
7e3ab302
PE
1447 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1448 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1449 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1450 macros.
f78faa98 1451
e2b13473
PE
1452 * xterm.h (x_mouse_leave): New decl.
1453
77f23912
PE
1454 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1455 Remove unused functions.
cdf4ba58
PE
1456 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1457 (x_calc_absolute_position): Now static.
7411c686 1458 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1459 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1460 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1461 unless they are used.
38d0b34a
PE
1462 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1463 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1464 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1465 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1466 (x_error_catcher, x_connection_closed, x_error_handler):
1467 (x_error_quitter, xembed_send_message, x_iconify_frame):
1468 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1469 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1470 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1471
44f230aa
SM
1472 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1473 Rename or move locals to avoid shadowing.
6b463e58 1474 (tty_defined_color, merge_face_heights): Now static.
5967d051 1475 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1476 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1477 does not deduce is never used uninitialized.
73719eba
PE
1478 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1479 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1480
426994c3 1481 * terminal.c (store_terminal_param): Now static.
5489860b 1482
032f1620 1483 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1484 (set_frame_menubar): Remove unused local.
d4323972 1485 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1486 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1487 since they might point to immutable storage.
281585b0
PE
1488 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1489 since it's unused otherwise.
032f1620 1490
367c19e5 1491 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1492 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1493 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1494 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1495 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1496 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1497 does not deduce are never used uninitialized.
70739cbe 1498
07b48fa9
PE
1499 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1500
8868a238 1501 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1502 * window.c (window_loop, size_window):
1503 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1504
7e5cf297 1505 * window.c (display_buffer): Now static.
d6550a9f
PE
1506 (size_window): Mark variables that gcc -Wuninitialized
1507 does not deduce are never used uninitialized.
a586633d
PE
1508 * window.h (check_all_windows): New decl, to forestall
1509 gcc -Wmissing-prototypes diagnostic.
5b555da1 1510 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1511
f6095868
PE
1512 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1513 shadowing.
1514 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1515 Include <limits.h>.
1516 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1517 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1518 (load_charset_map): Mark variables that gcc -Wuninitialized
1519 does not deduce are never used uninitialized.
53df7c11 1520 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1521
f38b440c
PE
1522 * coding.c (coding_set_source, coding_set_destination):
1523 Use "else { /* comment */ }" rather than "else /* comment */;"
1524 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1525 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1526 a block, when the outer 'i' will do.
1527 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1528 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1529 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1530 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1531 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1532 Rename locals to avoid shadowing.
1533 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1534 * coding.c (emacs_mule_char, encode_invocation_designation):
1535 Now static, since they're not used elsewhere.
413bb2db 1536 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1537 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1538 (decode_coding_emacs_mule): Mark variables that gcc
1539 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1540 (detect_coding_iso_2022): Initialize a local variable that might
1541 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1542 this initialization is needed. (Bug#8211)
5f58e762
PE
1543 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1544 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1545 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1546 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1547 Remove unused macros.
f38b440c 1548
232b38b9 1549 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1550 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1551 * character.c (string_count_byte8): Likewise.
232b38b9 1552
fb90da1b
PE
1553 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1554 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1555
fb93dbc2
PE
1556 * chartab.c (copy_sub_char_table): Now static, since it's not used
1557 elsewhere.
5c156ace
PE
1558 (sub_char_table_ref_and_range, char_table_ref_and_range):
1559 Rename locals to avoid shadowing.
bbcd0949 1560 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1561
7d3b3862 1562 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1563 (BIDI_BOB): Remove unused macro.
7d3b3862 1564
6be7d3da
PE
1565 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1566 deduce are never used uninitialized.
c2ed9c8b 1567 * term.c (encode_terminal_code): Likewise.
6be7d3da 1568
75f8807f 1569 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1570
50938595
PE
1571 * tparam.h: New file.
1572 * term.c, tparam.h: Include it.
1573 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1574 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1575 Move these decls to tparam.h, and make them agree with what
1576 is actually in tparam.c. The previous trick of using incompatible
1577 decls in different modules does not conform to the C standard.
1578 All callers of tparam changed to use tparam's actual API.
1579 * tparam.c (tparam1, tparam, tgoto):
1580 Use const pointers where appropriate.
1581
fbceeba2
PE
1582 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1583 * cm.h (struct cm): Likewise.
1584 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1585 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1586 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1587 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1588 (turn_on_face, init_tty): Likewise.
1589 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1590
7f3f1250
PE
1591 * term.c (term_mouse_position): Rename local to avoid shadowing.
1592
e6ca6543
PE
1593 * alloc.c (mark_ttys): Move decl from here ...
1594 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1595
c40f8d15
AS
15962011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1597
1598 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1599
cfe0661d
JB
16002011-03-09 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * search.c (compile_pattern_1): Remove argument regp, unused since
1603 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1604 (compile_pattern): Don't pass it.
1605
0afb4571
J
16062011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1607
1608 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1609 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1610 for ! HAVE_GTK3.
1611 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1612
1613 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1614
1615 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1616 gdk_window_get_screen, gdk_window_get_geometry,
1617 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1618 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1619 (xg_get_pixbuf_from_pixmap): New function.
1620 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1621 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1622 Call xg_get_pixbuf_from_pixmap instead of
1623 gdk_pixbuf_get_from_drawable.
1624 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1625 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1626 (xg_check_special_colors): Use GtkStyleContext and its functions
1627 for HAVE_GTK3.
1628 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1629 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1630 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1631 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1632 Call gtk_widget_get_preferred_size.
0afb4571
J
1633 (xg_frame_resized): gdk_window_get_geometry only takes 5
1634 parameters.
44f230aa
SM
1635 (xg_win_to_widget, xg_event_is_for_menubar):
1636 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1637 (xg_set_widget_bg): New function.
1638 (delete_cb): New function.
1639 (xg_create_frame_widgets): connect delete-event to delete_cb.
1640 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1641 (xg_set_background_color): Call xg_set_widget_bg.
1642 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1643 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1644 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1645 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1646 if ! HAVE_GTK3.
1647 (update_frame_tool_bar): Call gtk_widget_hide.
1648 (xg_initialize): Use GDK_KEY_g.
1649
1650 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1651 if ! HAVE_GTK3
1652 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1653
1654 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1655 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1656 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1657
1c2cc4ef
JB
16582011-03-08 Juanma Barranquero <lekktu@gmail.com>
1659
1660 * w32xfns.c (select_palette): Check success of RealizePalette against
1661 GDI_ERROR, not zero.
1662
33383987 1663See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1664
1665;; Local Variables:
1666;; coding: utf-8
aac0c6e3
MR
1667;; End:
1668
33383987 1669 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1670
1671 This file is part of GNU Emacs.
1672
1673 GNU Emacs is free software: you can redistribute it and/or modify
1674 it under the terms of the GNU General Public License as published by
1675 the Free Software Foundation, either version 3 of the License, or
1676 (at your option) any later version.
1677
1678 GNU Emacs is distributed in the hope that it will be useful,
1679 but WITHOUT ANY WARRANTY; without even the implied warranty of
1680 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1681 GNU General Public License for more details.
1682
1683 You should have received a copy of the GNU General Public License
1684 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.