Assume mkdir, rmdir.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c8add24e
GM
12012-07-11 Glenn Morris <rgm@gnu.org>
2
249685df
GM
3 * s/gnu.h: Remove file, which is now empty.
4
c8add24e
GM
5 * s/gnu.h, s/gnu-linux.h:
6 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
7
b41253a3
JW
82012-07-11 John Wiegley <johnw@newartisans.com>
9
10 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
11 function attribute, so we only use it if it exists in the
12 compiler.
13
d923b542
DA
142012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
15
16 Avoid call to strlen in fast_c_string_match_ignore_case.
17 * search.c (fast_c_string_match_ignore_case): Change to use
18 length argument. Adjust users accordingly.
19 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
20
5ebbef1d
PE
212012-07-11 Paul Eggert <eggert@cs.ucla.edu>
22
bb352260
PE
23 Assume mkdir, rmdir.
24 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
25 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
26
57054ddd
PE
27 Assume rename.
28 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
29
b747d3f7
PE
30 Assume perror.
31 * s/hpux10-20.h (HAVE_PERROR): Remove.
32 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
33 Remove dummy definition, as this problem was obsolete long ago.
34
5ebbef1d
PE
35 Assume strerror.
36 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
37
984e7f30
DA
382012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
39
40 Avoid calls to strlen in font processing functions.
41 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 42 (font_open_by_name): Change to use length argument. Adjust
984e7f30 43 users accordingly.
d923b542
DA
44 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
45 Adjust prototypes.
46 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
47 Change to return ptrdiff_t.
984e7f30
DA
48 (xfont_list_pattern, xfont_match): Use length returned by
49 xfont_decode_coding_xlfd.
50 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
51
20e94fdd
GM
522012-07-11 Glenn Morris <rgm@gnu.org>
53
9d596af3
GM
54 * s/darwin.h, s/freebsd.h, s/netbsd.h:
55 Move DONT_REOPEN_PTY to configure.
56
20e94fdd
GM
57 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
58 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
59
e99a530f
PE
602012-07-10 Paul Eggert <eggert@cs.ucla.edu>
61
22ffb973
PE
62 Remove "#define unix" that is no longer needed (Bug#11905).
63 * s/aix4-2.h (unix): Remove; no longer needed.
64
e9a9ae03
PE
65 EMACS_TIME simplification (Bug#11875).
66 This replaces macros (which typically do not work in GDB)
67 with functions, typedefs and enums, making the code easier to debug.
68 The functional style also makes code easier to read and maintain.
69 * systime.h: Include <sys/time.h> on all hosts, not just if
70 WINDOWSNT, since 'struct timeval' is needed in general.
71 (EMACS_TIME): Now a typedef, not a macro.
72 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
73 not macros.
74 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
75 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
76 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
77 (EMACS_TIME_LE): Now functions, not macros.
78 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
79 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
80 which are not functions. All uses rewritten to use:
81 (make_emacs_time): New function.
82 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
83 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
84 not functions. All uses rewritten to use the following, respectively:
85 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
86 (add_emacs_time, sub_emacs_time): New functions.
87 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
88 * fileio.c (Fcopy_file):
89 * xterm.c (XTflash): Get the current time closer to when it's used.
90 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
91
ffacb126
PE
92 * bytecode.c (targets): Suppress -Woverride-init warnings.
93
e99a530f
PE
94 Simplify by avoiding confusing use of strncpy etc.
95 * doc.c (Fsnarf_documentation):
96 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
97 * frame.c (Fmake_terminal_frame):
98 * gtkutil.c (get_utf8_string):
99 * lread.c (openp):
100 * nsmenu.m (ns_update_menubar):
101 * regex.c (regerror):
102 Prefer memcpy to strncpy and strncat when either will do.
103 * fileio.c (Fsubstitute_in_file_name):
104 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
105 (menu_separator_name_p):
106 * nsmenu.m (ns_update_menubar):
107 Prefer memcmp to strncmp when either will do.
108 * nsterm.m: Include <ftoastr.h>.
109 (ns_get_color):
110 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
111 Prefer snprintf to strncpy.
112 * nsterm.m (ns_term_init):
113 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
114 * nsterm.m (ns_term_init):
115 Avoid the need for strncpy, by using build_string or
116 make_unibyte_string directly. Use dtoastr, not snprintf.
117 * process.c (Fmake_network_process): Diagnose service names that
118 are too long, rather than silently truncating them or creating
119 non-null-terminated names.
120 (Fnetwork_interface_info): Likewise, for interface names.
121 * sysdep.c (system_process_attributes) [GNU_LINUX]:
122 Prefer sprintf to strncat.
123 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
124 Prefer vsnprintf to vsprintf + strncpy.
125
c59592b3
GM
1262012-07-10 Glenn Morris <rgm@gnu.org>
127
128 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
129 Clarify fallback case.
130
7d7bbefd
DA
1312012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
132
133 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
134 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
135 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 136 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
137 where argument type is known to be a Lisp_Cons.
138
3a4c8000
TT
1392012-07-10 Tom Tromey <tromey@redhat.com>
140
141 * bytecode.c (BYTE_CODE_THREADED): New macro.
142 (BYTE_CODES): New macro. Replaces all old byte-code defines.
143 (enum byte_code_op): New type.
144 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
145 (exec_byte_code): Use them. Use token threading when applicable.
146
2a0213a6
DA
1472012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
148
149 Optimize pure C strings initialization.
150 * lisp.h (make_pure_string): Fix prototype.
151 (build_pure_c_string): New function, defined as static inline. This
152 provides a better opportunity to optimize away calls to strlen when
153 the function is called with compile-time constant argument.
154 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
155 argument, adjust users accordingly. Use build_pure_c_string where
156 appropriate.
157 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
158 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
159 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
160
cb1caeaf
DA
1612012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
162
163 Avoid calls to strlen in miscellaneous functions.
164 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
165 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
166 * lread.c (openp): Likewise.
167
c293e30c
DA
1682012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
169
170 Avoid calls to strlen in path processing functions.
171 * fileio.c (file_name_as_directory): Add comment. Change to add
172 srclen argument and return the length of result. Adjust users
173 accordingly.
174 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 175 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
176 users accordingly.
177 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
178
9e059e3f
GM
1792012-07-10 Glenn Morris <rgm@gnu.org>
180
d02eb359
GM
181 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
182 Move PENDING_OUTPUT_COUNT definition to configure.
183
882cf227
GM
184 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
185 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
186 * s/gnu.h (DATA_START): Move definitions to configure.
187
af6e839f
GM
188 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
189 We include usg5-4-common.h, which defines them both.
190
40289a12
GM
191 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
192 O_RDONLY already includes it).
193
9e059e3f
GM
194 Stop ns builds setting the EMACSLOADPATH environment variable.
195 * nsterm.m (ns_load_path): Rename from ns_init_paths.
196 Now it does not set EMACSLOADPATH, just returns the load-path string.
197 * nsterm.h: Update accordingly.
198 * lread.c [HAVE_NS]: Include nsterm.h.
199 (init_lread) [HAVE_NS]: Use ns_load_path.
200 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
201
7c4e8ec0
GM
2022012-07-09 Glenn Morris <rgm@gnu.org>
203
d4f600ff
GM
204 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
205 since the included bsd-common.h does so.
206
cbb31951
GM
207 Stop ns builds setting the EMACSPATH environment variable.
208 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
209 (ns_init_paths): Do not set EMACSPATH.
210 * nsterm.h (ns_exec_path): Add it.
211 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
212 Use ns_exec_path.
213
7c4e8ec0
GM
214 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
215
26bccfae
PE
2162012-07-09 Paul Eggert <eggert@cs.ucla.edu>
217
a0bee46f
PE
218 * process.c (wait_reading_process_output): 'waitchannels' was unset
219 when read_kbd || !NILP (wait_for_cell); fix this.
220
5994c183
PE
221 Add GCC-style 'const' attribute to functions that can use it.
222 * character.h (char_resolve_modifier_mask):
223 * keyboard.h (make_ctrl_char):
224 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
225 (init_character_once, next_almost_prime, init_fns, init_image)
226 (flush_pending_output, init_sound):
227 * mem-limits.h (start_of_data):
228 * menu.h (finish_menu_items):
229 Add ATTRIBUTE_CONST.
230 * emacs.c (DEFINE_DUMMY_FUNCTION):
231 Declare the dummy function with ATTRIBUTE_CONST.
232 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
233 Add decls with ATTRIBUTE_CONST.
234
26bccfae
PE
235 Minor improvements to make_formatted_string.
236 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
237 where int is good enough, as vsprintf returns an int.
238 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
239
a8290ec3
DA
2402012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
241
242 Use make_formatted_string to avoid double length calculation.
243 * lisp.h (make_formatted_string): New prototype.
244 * alloc.c (make_formatted_string): New function.
245 * buffer.c (Fgenerate_new_buffer_name): Use it.
246 * dbus.c (syms_of_dbusbind): Likewise.
247 * editfns.c (Fcurrent_time_zone): Likewise.
248 * filelock.c (get_boot_time): Likewise.
249 * frame.c (make_terminal_frame, set_term_frame_name)
250 (x_report_frame_params): Likewise.
251 * image.c (gs_load): Likewise.
252 * minibuf.c (get_minibuffer): Likewise.
253 * msdos.c (dos_set_window_size): Likewise.
254 * process.c (make_process): Likewise.
255 * xdisp.c (ensure_echo_area_buffers): Likewise.
256 * xsettings.c (apply_xft_settings): Likewise.
257
d01ba2f1
GM
2582012-07-09 Glenn Morris <rgm@gnu.org>
259
260 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
261 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
262 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
263 * nsterm.h (ns_etc_directory): Add it.
264 * callproc.c [HAVE_NS]: Include nsterm.h.
265 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
266
f1f924b6
DA
2672012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
268
269 Move marker debugging code under MARKER_DEBUG.
270 * marker.c (MARKER_DEBUG): Move marker debugging code under
271 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
272 for bootstrap with --enable-checking (~3x slowdown reported
273 by Juanma Barranquero <lekktu@gmail.com>).
274 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
275
ab531b66
PE
2762012-07-08 Paul Eggert <eggert@cs.ucla.edu>
277
278 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
279 See <http://bugs.gnu.org/11825#29>.
280
c4b3bc8a
EZ
2812012-07-08 Eli Zaretskii <eliz@gnu.org>
282
283 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
284 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
285 (display_line): Add commentary about displaying truncation glyphs
286 on GUI frames.
287 (produce_special_glyphs): Move here from term.c.
288
289 * term.c (produce_special_glyphs): Move to xdisp.c.
290
291 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
292 section.
c4b3bc8a 293
b676b881
AS
2942012-07-07 Andreas Schwab <schwab@linux-m68k.org>
295
f17c5273
AS
296 * xdisp.c (display_line): Avoid warning about implicit declaration
297 of FRAME_FONT.
298
298819b9
AS
299 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
300
b676b881
AS
301 * lisp.h: Remove empty conditional.
302
6045c4fd
PE
3032012-07-07 Paul Eggert <eggert@cs.ucla.edu>
304
b3350bf9
PE
305 * lread.c (load_path_check): Now static.
306
6045c4fd
PE
307 Fix some minor --with-ns problems found by static checking.
308 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
309 (x_set_font) [!HAVE_X_WINDOWS]:
310 * image.c (xpm_load_image) [HAVE_NS]:
311 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
312 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
313 Remove unused local.
314 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
315 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
316 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
317 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
318 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
319 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
320 Fix pointer signedness problem.
321 * xfaces.c (FRAME_X_FONT_TABLE):
322 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
323
929e7845
GM
3242012-07-07 Glenn Morris <rgm@gnu.org>
325
326 * lread.c (load_path_check): New function, split from init_lread.
327 (init_lread): Reorganize. Motivation:
328 If EMACSLOADPATH is set, check/warn about that rather than the
329 defaults, which we are not going to use. Hence we can remove
330 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
331 Don't warn if site-lisp directories are missing.
332 If not installed, start from a blank load-path, since
333 PATH_LOADSEARCH refers to the eventual installation directories.
334
58dd0aa4
EZ
3352012-07-07 Eli Zaretskii <eliz@gnu.org>
336
337 Support truncation and continuation glyphs on GUI frames, when
338 fringes are disabled. (Bug#11832)
339 * xdisp.c (init_iterator): Get dimensions of truncation and
340 continuation glyphs even if on GUI frames. Adjust
341 it->last_visible_x on GUI frames when the left or right fringes,
342 or both, are absent.
343 (start_display, move_it_in_display_line_to): Handle the case of a
344 GUI frame without a fringe to display continuation or truncation
345 glyphs.
346 (insert_left_trunc_glyphs): Support GUI frames: make sure
347 truncation glyphs overwrite enough glyphs from the current line to
348 have sufficient space in pixels.
349 (display_line): Support truncation and continuation glyphs on GUI
350 frames. If some spare pixels are left on the line after inserting
351 the truncation glyphs, fill that space with a stretch glyph of a
352 suitably computed width.
353
354 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
355 produce_glyphs, to support GUI sessions.
356
31571fd7
PE
3572012-07-07 Paul Eggert <eggert@cs.ucla.edu>
358
5a16b9bc
PE
359 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
360
f3047c75
PE
361 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
362
31571fd7
PE
363 Do not require float-time's arg to fit in time_t (Bug#11825).
364 This works better on hosts where time_t is unsigned, and where
365 float-time is applied to the (negative) difference between two times.
366 * editfns.c (decode_time_components): Last arg is now double *,
367 not int *, and means to store all the result as a double, without
368 worrying about whether the seconds part fits in time_t.
369 All callers changed.
370 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
371 All callers changed.
372 (Ffloat_time): Do not fail merely because the specified time falls
373 outside of time_t range.
374
4516fbef
GM
3752012-07-07 Glenn Morris <rgm@gnu.org>
376
377 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
378 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
379 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
380
07adc2c6
JB
3812012-07-07 Juanma Barranquero <lekktu@gmail.com>
382
383 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
384 Update dependencies.
385
386 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
387
fd573f31
PE
3882012-07-06 Paul Eggert <eggert@cs.ucla.edu>
389
fee5959d
PE
390 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
391 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
392 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
393 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
394 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
395 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
396
fd573f31
PE
397 * xfont.c (compare_font_names): Redo to omit the need for casts.
398
ddadbc0e
AS
3992012-07-06 Andreas Schwab <schwab@linux-m68k.org>
400
fca8d6b6
AS
401 * xfns.c (Fx_change_window_property): Doc fix.
402 * w32fns.c (Fx_change_window_property): Doc fix.
403
ddadbc0e
AS
404 * w32fns.c (Fx_window_property): Accept the same arguments as the
405 X Windows version. Doc fix.
406 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
407
f247498e
JB
4082012-07-06 Juanma Barranquero <lekktu@gmail.com>
409 Eli Zaretskii <eliz@gnu.org>
410
411 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
412 Windows-specific code from nt/config.nt moved here.
413 Obsolete settings removed.
414
216ee680
PE
4152012-07-06 Paul Eggert <eggert@cs.ucla.edu>
416
417 * process.c: Avoid unnecessary calls to gettime.
418 (wait_reading_process_output): Don't get the time of day
419 when gobbling data immediately and not waiting, as there's no need
420 for it in that case. This removes a FIXME.
421
bdd091e4
JD
4222012-07-06 Jan Djärv <jan.h.d@swipnet.se>
423
424 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
425 is defined (Bug#11768).
426
9d44f8ce
DA
4272012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
428
429 Fix marker debugging code.
430 * marker.c (byte_char_debug_check): Do not perform the check
431 if buffer is not multibyte.
090bd7cb
JB
432 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
433 Call byte_char_debug_check with correct arguments.
9d44f8ce 434
90fc4786
DA
4352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
436
437 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
438 * marker.c (byte_char_debug_check, count_markers):
439 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
440 (byte_debug_flag): Remove.
441 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
442 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
443
7b7ae965
DA
4442012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
445
4e57b342
DA
446 Avoid code repetition in marker-related functions.
447 * marker.c (attach_marker): New function.
448 (Fset_marker, set_marker_restricted, set_marker_both)
449 (set_marker_restricted_both): Use it.
450 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
451 Consistently rename charno to charpos.
452 (marker_position): Add eassert.
453 (marker_byte_position): Convert to eassert.
454
4552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
456
457 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 458 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 459 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 460
657924ff
DA
4612012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Introduce fast path for the widely used marker operation.
464 * alloc.c (build_marker): New function.
465 * lisp.h (build_marker): New prototype.
466 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
467 * composite.c (autocmp_chars): Likewise.
468 * editfns.c (buildmark): Remove.
469 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
470 (save_restriction_save): Use build_marker.
471 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
472 * window.c (save_window_save): Likewise.
473
041a49a6
DA
4742012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
475
476 Do not use Fdelete_overlay in delete_all_overlays
477 to avoid redundant calls to unchain_overlay.
478 * buffer.c (drop_overlay): New function.
479 (delete_all_overlays, Fdelete_overlay): Use it.
480 * minibuf.c (get_minibuffer): Fix comment.
481
7dca65a4
PE
4822012-07-06 Paul Eggert <eggert@cs.ucla.edu>
483
484 Port to OpenBSD 5.1 amd64.
485 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
486 This is needed for OpenBSD, and should be harmless on all BSD systems.
487 Also, include <sys/sysctl.h>, as it should be available on all
488 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
489 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
490 use p_pid member, not kp_proc.pid.
491
8eb876e2
GM
4922012-07-06 Glenn Morris <rgm@gnu.org>
493
494 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
495
38182d90
PE
4962012-07-05 Paul Eggert <eggert@cs.ucla.edu>
497
498 More xmalloc and related cleanup.
499 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
500 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
501 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
502 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
503 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
504 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
505 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
506 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
507 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
508 * xterm.c:
509 Omit needless casts involving void * pointers and allocation.
510 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
511 as the former is more robust if P's type is changed.
512 Prefer xzalloc to xmalloc + memset 0.
513 Simplify malloc-or-realloc to realloc.
514 Don't worry about xmalloc returning a null pointer.
515 Prefer xstrdup to xmalloc + strcpy.
516 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
517 growing it.
518 * keyboard.c (apply_modifiers_uncached): Prefer local array to
519 alloca of a constant.
520
6dd5a677
EZ
5212012-07-05 Eli Zaretskii <eliz@gnu.org>
522
523 * xdisp.c (display_line): Fix horizontal pixel coordinates when
524 hscroll is larger than the line width. Fixes long and futile
525 looping inside extend_face_to_end_of_line (on a TTY) producing
526 glyphs that are not needed and thrown away.
527
6b312f0f
DA
5282012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
529
530 * marker.c (set_marker_restricted_both): Simplify by using
531 clip_to_bounds.
532
f520ef9b
PE
5332012-07-05 Paul Eggert <eggert@cs.ucla.edu>
534
535 * editfns.c (region_limit): Simplify by using clip_to_bounds.
536
383b7c95
JD
5372012-07-05 Jan Djärv <jan.h.d@swipnet.se>
538
539 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
540 not defined (Bug#11768).
541 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
542 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
543 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
544 followed by gtk_box_set_homogeneous (Bug#11768).
545 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
546 (update_theme_scrollbar_width, xg_create_scroll_bar):
547 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
548 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
549 (is_box_type): New function (Bug#11768).
550 (xg_tool_item_stale_p): Call is_box_type.
5293d758 551 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
552 with default display (Bug#11768).
553
d6e7bf45
EZ
5542012-07-05 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (window_hscroll_limited): New function.
557 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
558 coordinates when window's hscroll is set to insanely large
559 values. (Bug#11857)
560
431391ec
JB
5612012-07-05 Juanma Barranquero <lekktu@gmail.com>
562
563 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
564 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
565
23f86fce
DA
5662012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
567
568 Cleanup xmalloc.
569 * lisp.h (xzalloc): New prototype. Omit needless casts.
570 * alloc.c (xzalloc): New function. Omit needless casts.
571 * charset.c: Omit needless casts. Convert all calls to
572 xmalloc with following memset to xzalloc.
573 * dispnew.c: Likewise.
574 * fringe.c: Likewise.
575 * image.c: Likewise.
576 * sound.c: Likewise.
577 * term.c: Likewise.
578 * w32fns.c: Likewise.
579 * w32font.c: Likewise.
580 * w32term.c: Likewise.
581 * xfaces.c: Likewise.
582 * xfns.c: Likewise.
583 * xterm.c: Likewise.
584 * atimer.c: Omit needless casts.
585 * buffer.c: Likewise.
586 * callproc.c: Likewise.
587 * ccl.c: Likewise.
588 * coding.c: Likewise.
589 * composite.c: Likewise.
590 * doc.c: Likewise.
591 * doprnt.c: Likewise.
592 * editfns.c: Likewise.
593 * emacs.c: Likewise.
594 * eval.c: Likewise.
595 * filelock.c: Likewise.
596 * fns.c: Likewise.
597 * gtkutil.c: Likewise.
598 * keyboard.c: Likewise.
599 * lisp.h: Likewise.
600 * lread.c: Likewise.
601 * minibuf.c: Likewise.
602 * msdos.c: Likewise.
603 * print.c: Likewise.
604 * process.c: Likewise.
605 * region-cache.c: Likewise.
606 * search.c: Likewise.
607 * sysdep.c: Likewise.
608 * termcap.c: Likewise.
609 * terminal.c: Likewise.
610 * tparam.c: Likewise.
611 * w16select.c: Likewise.
612 * w32.c: Likewise.
613 * w32reg.c: Likewise.
614 * w32select.c: Likewise.
615 * w32uniscribe.c: Likewise.
616 * widget.c: Likewise.
617 * xdisp.c: Likewise.
618 * xmenu.c: Likewise.
619 * xrdb.c: Likewise.
620 * xselect.c: Likewise.
621
0497dc44
PE
6222012-07-05 Paul Eggert <eggert@cs.ucla.edu>
623
624 * fileio.c (time_error_value): Check the right error number.
625 Problem reported by Troels Nielsen in
626 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
627
356e7178
PE
6282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
629
4e71fd89
PE
630 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
631 This should be fixed in a better way; see Eli Zaretskii in
632 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
633 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
634
f0941253
PE
635 * fileio.c (time_error_value): Rename from special_mtime.
636 The old name's problems were noted by Eli Zaretskii in
637 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
638
065c9eb4
PE
639 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
640 This variable's comment says Emacs needs at least one GDB-visible
641 symbol of type enum pvec_type, to work around GDB problems.
642 The symbol's value doesn't matter.
643
356e7178
PE
644 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
645 that causes compilation to fail on pre-C99 compilers.
646
95f61aa2
JB
6472012-07-04 Juanma Barranquero <lekktu@gmail.com>
648
649 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
650 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
651
3884d954
DA
6522012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
653
d209e2fb 654 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
655 headers for buffer_defaults and buffer_local_symbols.
656 Reported by Juanma Barranquero <lekktu@gmail.com>.
657
ee28be33
SM
6582012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
659
660 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
661 * lisp.h (enum pvec_type): Use fewer bits.
662 (PSEUDOVECTOR_SIZE_BITS): New constant.
663 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
664 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
665 change in pvec_type.
666 (PSEUDOVECTOR_TYPEP): New macro.
667 (TYPED_PSEUDOVECTORP): Use it.
668 * fns.c (internal_equal): Adapt code to extract pvectype.
669 * emacs.c (gdb_pvec_type): Update type.
670 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
671 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
672 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
673 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
674 (sweep_vectors): Use it. Use local var `total_bytes' instead of
675 abusing vector->header.next.nbytes.
676 (live_vector_p): Use PVEC_TYPE.
677 (mark_object): Adapt code to extract pvectype. Use switch.
678
c7f2cd7f
PE
6792012-07-04 Paul Eggert <eggert@cs.ucla.edu>
680
681 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
682 Tighten new eassert a bit.
683
8ce70ed2
DA
6842012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
685
686 Fix compilation with --enable-gcc-warnings and -O1
687 optimization level.
688 * doprnt.c (doprnt): Change type of tem to int, initialize
689 to avoid compiler warning. Add eassert.
690 * search.c (simple_search): Initialize match_byte to avoid
691 compiler warning. Add eassert.
692
dea7f1e5
PE
6932012-07-04 Paul Eggert <eggert@cs.ucla.edu>
694
24a212eb
PE
695 Avoid weird behavior with large horizontal scrolls.
696 Without this change, for example, large hscroll values would
697 mess up Emacs's display on Fedora 15 x86, presumably due to
698 overflows in int calculations in the display code.
699 Also, if buffers had long lines, Emacs would freeze.
700 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
701 (set_window_hscroll): New function, containing the old guts of
702 Fset_window_hscroll. Return the clipped value.
703 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
704 This avoids the need to check against PTRDIFF_MAX.
705
dea7f1e5
PE
706 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
707
76046526
DA
7082012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
709
710 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
711
39adff0d
PE
7122012-07-04 Paul Eggert <eggert@cs.ucla.edu>
713
63807d47
PE
714 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
715 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
716 since GCC 4.4.6 issues a bogus warning for them.
717
39adff0d
PE
718 Fix bugs in file timestamp newness comparisons.
719 * fileio.c (Ffile_newer_than_file_p):
720 * lread.c (Fload): Use full timestamp resolution of files,
721 not just the 1-second resolution, so that files that are only
722 slightly newer still count as newer.
723 * fileio.c (Ffile_newer_than_file_p): Don't assume file
724 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
725
dbeed9a6
PE
7262012-07-03 Paul Eggert <eggert@cs.ucla.edu>
727
728 * fileio.c: Improve handling of file time marker. (Bug#11852)
729 (special_mtime): New function.
730 (Finsert_file_contents, Fverify_visited_file_modtime):
731 Use it to set special mtime values consistently.
732
636334d6
AS
7332012-07-03 Andreas Schwab <schwab@linux-m68k.org>
734
735 * fileio.c (Finsert_file_contents): Properly handle st_mtime
736 marker for non-existing file. (Bug#11852)
737
e2017fe2
GM
7382012-07-03 Glenn Morris <rgm@gnu.org>
739
740 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
741 and did not make it into globals.h).
742
404dbd37
TT
7432012-07-03 Tom Tromey <tromey@redhat.com>
744
745 * window.c (Fset_window_margins, Fset_window_fringes)
746 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
747 * textprop.c (Fprevious_property_change): No longer static.
748 * syntax.c (Fsyntax_table_p): No longer static.
749 * process.c (Fget_process, Fprocess_datagram_address): No longer
750 static.
751 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
752 * keyboard.c (Fcommand_execute): No longer static.
753 Remove EXFUN.
754 * insdel.c (Fcombine_after_change_execute): No longer static.
755 * image.c (Finit_image_library): No longer static.
756 * fileio.c (Fmake_symbolic_link): No longer static.
757 * eval.c (Ffetch_bytecode): No longer static.
758 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
759 * doc.c (Fdocumentation_property, Fsnarf_documentation):
760 No longer static.
404dbd37
TT
761 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
762 static.
763 * dired.c (Ffile_attributes): No longer static.
764 * composite.c (Fcomposition_get_gstring): No longer static.
765 * callproc.c (Fgetenv_internal): No longer static.
766
767 * ccl.h: Remove EXFUNs.
768 * buffer.h: Remove EXFUNs.
769 * dispextern.h: Remove EXFUNs.
770 * intervals.h: Remove EXFUNs.
771 * fontset.h: Remove EXFUN.
772 * font.h: Remove EXFUNs.
773 * dosfns.c (system_process_attributes): Remove EXFUN.
774 * keymap.h: Remove EXFUNs.
775 * lisp.h: Remove EXFUNs.
776 * w32term.h: Remove EXFUNs.
777 * window.h: Remove EXFUNs.
778 * xsettings.h: Remove EXFUN.
779 * xterm.h: Remove EXFUN.
780
8e4fd1e1
GM
7812012-07-03 Glenn Morris <rgm@gnu.org>
782
783 * lisp.h (Frandom): Make it visible to C.
784 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
785 buffer for invisible buffers. (Bug#1229)
786
ca95b3eb
DA
7872012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
788
789 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
790 values which aren't power of 2.
791 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
792 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
793 accordingly.
794
7555c33f
SM
7952012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
798
799 * alloc.c (mark_object): Revert part of last patch to use `switch'.
800
d12e8f5a
DA
8012012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
802
803 * alloc.c (allocate_vector_block): Remove redundant
804 calls to mallopt if DOUG_LEA_MALLOC is defined.
805 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
806 avoid calls to mallopt if zero_vector is returned.
807
296094c3
DA
8082012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
809
810 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
811 is enabled, avoid dereferencing NULL current_sblock if
812 running undumped.
813
36429c89
DA
8142012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
815
816 Cleanup basic buffer management.
817 * buffer.h (struct buffer): Change layout to use generic vector
818 marking code. Fix some comments. Change type of 'clip_changed'
819 to bitfield. Remove unused #ifndef old.
820 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
821 (GET_OVERLAYS_AT): Fix indentation.
822 (for_each_per_buffer_object_at): New macro.
823 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
824 (Fbuffer_local_variables): Use it.
825 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
826 * alloc.c (allocate_buffer): Adjust to match new layout of
827 struct buffer. Fix comment.
828 (mark_overlay): New function.
829 (mark_buffer): Use it. Use mark_vectorlike to mark normal
830 Lisp area of struct buffer.
831 (mark_object): Use it. Adjust marking of misc objects
832 and related comments.
833
3b3e4cac
PE
8342012-07-02 Paul Eggert <eggert@cs.ucla.edu>
835
836 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
837 wrapper that is not needed because the wrapped code is a no-op (zero
838 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
839 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
840
cf5c0175
DA
8412012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
842
843 * alloc.c (mark_buffer): Simplify. Remove prototype.
844 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 845 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
846 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
847 redundant calls to mark_vectorlike for bool vectors.
848
ca26824c
GM
8492012-06-30 Glenn Morris <rgm@gnu.org>
850
2e4c5312
GM
851 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
852
ca26824c
GM
853 * epaths.in (PATH_SITELOADSEARCH): New.
854 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
855 This is rather than relying on --enable-locallisppath elements
856 having "site-lisp" in their names. (Bug#10208#25, 11658)
857
0d23c240
EZ
8582012-06-30 Eli Zaretskii <eliz@gnu.org>
859
c9240d7a
EZ
860 * w32proc.c (sys_select): Accept and ignore one more argument.
861
862 * w32.c (emacs_gnutls_pull): Call select with one more argument.
863
0d23c240 864 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 865 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
866
867 * sysdep.c: Don't include dos.h and dosfns.h.
868
869 * process.c (sys_select):
870 * msdos.c (sys_select): Accept one more argument and ignore it.
871
872 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
873 adapt data types and code to that.
874
875 * dosfns.c:
876 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
877 which clashes with the gnulib function of the same name.
878
af5a5a98
AS
8792012-06-30 Andreas Schwab <schwab@linux-m68k.org>
880
c5e4379c
AS
881 * font.c (font_style_to_value, font_style_symbolic)
882 (font_prop_validate_style): Add type checks for values in
883 font_style_table.
884
af5a5a98
AS
885 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
886 argument.
887 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
888 uses.
889
8d38f461
EZ
8902012-06-29 Eli Zaretskii <eliz@gnu.org>
891
2e5a6631
EZ
892 * xdisp.c (try_window_id): Undo last change.
893
8d38f461
EZ
894 * w32.c (getwd): Adjust commentary about startup_dir.
895 (init_environment): Always call sys_access, even in non-MSVC
896 builds. Don't chdir to the directory of the Emacs executable.
897 This undoes code from 1997 which was justified by the need to
898 "avoid conflicts when removing and renaming directories". But its
899 downside was that every relative file name was being interpreted
900 relative to the directory of the Emacs executable, which can never
901 be TRT. In particular, it broke sys_access when called with
902 relative file names.
903 (sys_access): Map GetLastError to errno.
904
2af3565e
DA
9052012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
906
907 * window.h (struct window): Change type of 'fringes_outside_margins'
908 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 909 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
910 Adjust comment.
911 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
912 to ptrdiff_t.
913
c8d3a25c 9142012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 915
c8d3a25c
GM
916 * gnutls.c (emacs_gnutls_handshake):
917 Add QUIT to make the loop interruptible.
57570cd3 918
c8d3a25c 9192012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 920
c8d3a25c
GM
921 * charset.c (init_charset): Make lack of etc/charsets fatal.
922
3e984ee8
DA
9232012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
924
925 * editfns.c (region_limit): Fix type mismatch.
926
ef884f23
DA
9272012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
928
929 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
930 undefined. Convert from xassert to eassert.
931 * nsmenu.m: Convert from xassert to eassert.
932 * nsterm.m: Likewise.
933
7d7e0027
SM
9342012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
935
936 * editfns.c (region_limit): Clip to narrowing (bug#11770).
937
aa754e6a
PE
9382012-06-28 Paul Eggert <eggert@cs.ucla.edu>
939
940 Avoid integer overflow on scroll-left and scroll-right.
941 * window.c (HSCROLL_MAX): New macro.
942 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
943 overflow when requested scroll falls outside ptrdiff_t range.
944
80b00b08
DA
9452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
946
947 * window.h (struct window): Change type of 'hscroll',
948 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
949 'last_modified' and 'last_overlay_modified' to EMACS_INT.
950 Adjust users accordingly.
951 * xdisp.c (try_cursor_movement): Replace type check with eassert.
952 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
953 from EMACS_INT to ptrdiff_t.
954 (make_window): Omit redundant initialization.
955
62b2bcf6
JB
9562012-06-28 Juanma Barranquero <lekktu@gmail.com>
957
958 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
959
45942c7d
DA
9602012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
961
962 * window.h (struct window): Change type of 'use_time' and
963 'sequence_number' from Lisp_Object to int.
964 * frame.c (make_frame): Adjust users accordingly.
965 * print.c (print_object): Likewise.
966 * window.c (select_window, Fwindow_use_time, make_parent_window)
967 (make_window): Likewise.
968
e509cfa6
DA
9692012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
970
971 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
972 enabled with --enable-checking=[all,glyphs] configure option.
973 Fix GLYPH_DEBUG usage assuming that it may be undefined,
974 adjust comments accordingly.
975 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
976 undefined, adjust comments accordingly.
977 * image.c: Likewise.
978 * scroll.c: Likewise.
979 * w32fns.c: Likewise.
980 * w32term.c: Likewise.
981 * xdisp.c: Likewise.
982 * xfaces.c: Likewise.
983 * xfns.c: Likewise.
984 * xterm.c: Likewise.
985
a54e2c05
DA
9862012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
987
988 Generalize run-time debugging checks.
989 * dispextern.h (XASSERTS): Remove.
990 * fontset.c (xassert): Remove.
991 Convert from xassert to eassert.
992 * alloc.c: Convert from xassert to eassert.
993 * bidi.c: Likewise.
994 * dispnew.c: Likewise.
995 * fns.c: Likewise.
996 * fringe.c: Likewise.
997 * ftfont.c: Likewise.
998 * gtkutil.c: Likewise.
999 * image.c: Likewise.
1000 * keyboard.c: Likewise.
1001 * menu.c: Likewise.
1002 * process.c: Likewise.
1003 * scroll.c: Likewise.
1004 * sound.c: Likewise.
1005 * term.c: Likewise.
1006 * w32console.c: Likewise.
1007 * w32fns.c: Likewise.
1008 * w32term.c: Likewise.
1009 * window.c: Likewise.
1010 * xdisp.c: Likewise.
1011 * xfaces.c: Likewise.
1012 * xfns.c: Likewise.
1013 * xselect.c: Likewise.
1014 * xterm.c: Likewise.
1015
1ec4b7b2
SM
10162012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1017
1018 * fns.c (maybe_resize_hash_table): Output message when growing the
1019 purify-hashtable.
1020
2014308a
DA
10212012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1022
1023 * alloc.c (allocate_string_data): Remove dead code.
1024 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1025 avoid GCC warning about unused macro.
1026
246155eb
DA
10272012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1028
1029 * alloc.c (allocate_string): Omit intervals initialization.
1030 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1031 as in make_pure_string and make_pure_c_string.
1032
43184b7b
DA
10332012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1034
d209e2fb 1035 * alloc.c (allocate_string): Fix last change.
43184b7b 1036
3fe6dd74
DA
10372012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1038
d209e2fb 1039 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1040 to memset, add explicit initialization where appropriate.
1041
1ba6038a
GM
10422012-06-27 Glenn Morris <rgm@gnu.org>
1043
1044 * lisp.mk (lisp): Remove paths.elc.
1045
c89926a5
CY
10462012-06-27 Chong Yidong <cyd@gnu.org>
1047
1048 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1049
ed6b3510
JW
10502012-06-26 John Wiegley <johnw@newartisans.com>
1051
1ec4b7b2 1052 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1053 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1054
ed6b3510
JW
1055 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1056 when building with Clang.
1057
8edd4a2b
SM
10582012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1059
1060 * eval.c (Fapply): Allow calling it with a single argument.
1061
f6f62d1b
EZ
10622012-06-26 Eli Zaretskii <eliz@gnu.org>
1063
1064 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1065 _stricmp and _strnicmp.
1066 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1067
62efea5e
DA
10682012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1069
1070 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1071 allocated window.
1072 (allocate_process): Likewise for new process.
8edd4a2b 1073 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1074 (allocate_frame): Likewise.
1075 * frame.c (make_frame): Omit redundant initialization.
1076 * window.c (make_parent_window): Use memset.
1077 (make_window): Omit redundant initialization.
1078 * process.c (make_process): Omit redundant initialization.
1079 * terminal.c (create_terminal): Likewise.
1080
42997f4d
DA
10812012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1082
1083 * term.c (delete_tty): Remove redundant call to memset.
1084
1130ecfc
DA
10852012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1086
1087 * alloc.c: Remove build_string.
1088 * lisp.h: Define build_string as static inline. This provides
1089 a better opportunity to optimize away calls to strlen when the
1090 function is called with compile-time constant argument.
1091 * image.c (imagemagick_error): Convert to build_string.
1092 * w32proc.c (sys_spawnve): Likewise.
1093 * xterm.c (x_term_init): Likewise.
1094
cf38a720
PE
10952012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1096
99027bdd
PE
1097 Use sprintf return value instead of invoking strlen on result.
1098 In the old days this wasn't portable, since some sprintf
1099 implementations returned char *. But they died out years ago and
1100 Emacs already assumes sprintf returns int.
1101 Similarly for float_to_string.
1102 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1103 * ccl.c (ccl_driver):
1104 * character.c (string_escape_byte8):
1105 * data.c (Fnumber_to_string):
1106 * doprnt.c (doprnt):
1107 * print.c (print_object):
1108 * xdisp.c (message_dolog):
1109 * xfns.c (syms_of_xfns):
1110 Use sprintf or float_to_string result to avoid need to call strlen.
1111 * data.c (Fnumber_to_string):
1112 Use make_unibyte_string, since the string must be ASCII.
1113 * lisp.h, print.c (float_to_string): Now returns int length.
1114 * term.c (produce_glyphless_glyph):
1115 Use sprintf result rather than recomputing it.
1116
cf38a720
PE
1117 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1118 * Makefile.in (ALL_CFLAGS):
1119 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1120 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1121
3511c784
DA
11222012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1123
0a08eb21 1124 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1125 strcasecmp if available.
1126 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1127
fb7da12e
AS
11282012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1129
1130 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1131 Avoid comma operator.
1132 * menu.c (push_submenu_start, push_submenu_end)
1133 (push_left_right_boundary, push_menu_pane): Likewise.
1134 * msdos.c (dos_rawgetc): Likewise.
1135
afa2ffd8
DA
11362012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1137
1138 * xfns.c (xic_create_fontsetname): Remove redundant calls
1139 to memset.
1140
b3b4476b
PE
11412012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1142
4495ff38
PE
1143 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1144 sprintf already null-terminates its output.
1145
b3b4476b
PE
1146 * xfns.c (x_window): Remove redundant cast.
1147
b00876c9
DA
11482012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1149
1150 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1151 `const char *' to `char *' to avoid compiler warning.
1152
d188e26b
PE
11532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1154
885d1d74
PE
1155 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1156 instead of truncating it to 63 (admittedly a generous limit).
1157
d188e26b
PE
1158 * process.c: Fix spelling and caps in comments.
1159
e2f560b1
DN
11602012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1161
e86db54b 1162 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1163 * sysdep.c (setpgrp): Remove definition, not used in this file.
1164
7583a3a1
JB
11652012-06-24 Juanma Barranquero <lekktu@gmail.com>
1166
1167 * makefile.w32-in: Update dependencies.
1168
696056c2
EZ
11692012-06-24 Eli Zaretskii <eliz@gnu.org>
1170
1171 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1172 (SYSTIME_H): Add nt/inc/sys/time.h.
1173
1174 * systime.h [WINDOWSNT]: Include sys/time.h.
1175
1176 * s/ms-w32.h (struct timespec): Definition moved from
1177 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1178
845ca893
PE
11792012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1182 * buffer.h (buffer_slot_type_mismatch):
1183 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1184 * eval.c (unwind_to_catch):
1185 * image.c (my_png_error, my_error_exit):
1186 * keyboard.c (quit_throw_to_read_char, user_error)
1187 (Fexit_recursive_edit, Fabort_recursive_edit):
1188 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1189 (wrong_type_argument, buffer_overflow, __executable_start)
1190 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1191 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1192 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1193 (fatal):
1194 (child_setup) [!DOS_NT]:
1195 * lread.c (end_of_file_error, invalid_syntax):
1196 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1197 * puresize.h (pure_write_error):
1198 * search.c (matcher_overflow):
1199 * sound.c (sound_perror, alsa_sound_perror):
1200 * sysdep.c, syssignal.h (croak):
1201 * term.c (maybe_fatal, vfatal):
1202 * textprop.c (text_read_only):
1203 * undo.c (user_error):
1204 * unexmacosx.c (unexec_error):
1205 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1206 Use _Noreturn rather than NO_RETURN.
1207 No need for separate decl merely because of _Noreturn.
1208 * sound.c (sound_warning, parse_sound):
1209 Remove unnecessary forward decls.
1210
f1dd8073
PE
12112012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1212
1213 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1214 * lisp.h (WAIT_READING_MAX): New macro.
1215 * dispnew.c (Fsleep_for, sit_for):
1216 * keyboard.c (kbd_buffer_get_event):
1217 * process.c (Faccept_process_output):
1218 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1219 This improves on the previous patch, which introduced a bug
1220 when time_t is unsigned and as wide as intmax_t.
1221 See <http://bugs.gnu.org/9000#51>.
1222
b82c1755
EZ
12232012-06-23 Eli Zaretskii <eliz@gnu.org>
1224
1225 * dispnew.c (sit_for, Fsleep_for):
1226 * keyboard.c (kbd_buffer_get_event):
1227 * process.c (Faccept_process_output): Avoid compiler warnings when
1228 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1229
ca300656
JB
12302012-06-23 Juanma Barranquero <lekktu@gmail.com>
1231
049ec95b
JB
1232 * makefile.w32-in: Update dependencies.
1233
ca300656
JB
1234 * w32.c (ltime): Add return type and declare static.
1235 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1236
db7b8d06
PE
12372012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1240 Privately reported by Herbert J. Skuhra.
1241 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1242 All uses changed.
1243 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1244 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1245
0bd8297f
EZ
12462012-06-23 Eli Zaretskii <eliz@gnu.org>
1247
96512555
EZ
1248 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1249 last argument of make_unibyte_string.
1250
0bd8297f
EZ
1251 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1252 language ID in the event parameters.
1253
1254 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1255 event.code, not the obscure "character set ID".
1256
63def6b6
CY
12572012-06-23 Chong Yidong <cyd@gnu.org>
1258
1259 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1260
e8a02204
EZ
12612012-06-23 Eli Zaretskii <eliz@gnu.org>
1262
388cdec0
EZ
1263 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1264 * w32.c (fdutimens): New function.
1265
1266 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1267
1268 * s/ms-w32.h (pselect): Redirect to sys_select.
1269
1270 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1271
e8a02204
EZ
1272 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1273 in the logic of incrementing and decrementing the value of
1274 use_relocatable_buffers.
1275
d054f3fb
PE
12762012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1279 Privately reported by Herbert J. Skuhra.
1280 [__FreeBSD__]: Remove "*/" typo after "#include".
1281 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1282 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1283 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1284 Don't assume EMACS_TIME and struct timeval are the same type.
1285
d35af63c
PE
12862012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 Support higher-resolution time stamps (Bug#9000).
1289 The time stamps are only nanosecond-resolution at the C level,
1290 since that's the best that any real-world system supports now.
1291 But they are picosecond-resolution at the Lisp level, as that's
1292 easy, and leaves room for future OS improvements.
1293
1294 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1295 (LIBES): Use it.
1296
1297 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1298 Don't get current time unless it's needed.
1299
1300 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1301 now provides it if it's absent.
1302 (start_atimer): Port to higher-res time stamps.
1303 Check for time stamp overflow. Don't get current time more
1304 often than is needed.
1305
1306 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1307 Include systime.h, not time.h.
1308 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1309
1310 * dired.c: Include stat-time.h.
1311 (Ffile-attributes): File times now have higher resolution.
1312
1313 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1314 (struct image): Timestamp now has higher resolution.
1315
1316 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1317 has at least microseconds now. All uses removed.
1318 (update_frame, update_single_window, update_window, update_frame_1)
1319 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1320
1321 * editfns.c (time_overflow): Now extern.
1322 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1323 (float-time, Fformat_time_string, Fcurrent_time_string)
1324 (Fcurrent_time_zone): Accept and generate higher-resolution
1325 time stamps.
1326 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1327 (decode_time_components, lisp_seconds_argument): New functions.
1328 (make_time): Now static.
1329 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1330 Report an error if the time is invalid, rather than having the caller
1331 do that.
1332
1333 * fileio.c: Include <stat-time.h>
1334 (Fcopy_file): Copy higher-resolution time stamps.
1335 Prefer to set the time stamp via a file descriptor if that works.
1336 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1337 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1338 (Fvisited_file_modtime, Fset_visited_file_modtime):
1339 Support higher-resolution time stamps.
1340
1341 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1342
1343 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1344
1345 * image.c (prepare_image_for_display, clear_image_cache)
1346 (lookup_image): Port to higer-resolution time stamps.
1347
1348 * keyboard.c (start_polling, bind_polling_period):
1349 Check for time stamp overflow.
1350 (read_char, kbd_buffer_get_event, timer_start_idle)
1351 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1352 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1353 Port to higher-resolution time stamps. Do not assume time_t is signed.
1354 (decode_timer): New function. Timers are now vectors of length 9,
1355 not 8, to accommodate the picosecond component.
1356 (timer_check_2): Use it.
1357
1358 * nsterm.m (select_timeout, timeval_subtract): Remove.
1359 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1360 as they're a bit more accurate and handle overflow better.
1361 (ns_select): Change prototype to be compatible with pselect.
1362 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1363 * nsterm.h (ns_select): Adjust prototype.
1364
1365 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1366 us-resolution time stamps.
1367 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1368
1369 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1370
1371 * lisp.h (time_overflow): New decl.
1372 (wait_reading_process_output): First arg is now intmax_t, not int,
1373 to accommodate larger waits.
1374
1375 * process.h (struct Lisp_Process.read_output_delay):
1376 Now counts nanoseconds, not microseconds.
1377 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1378 EMACS_HAS_USECS.
1379 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1380 (wait_reading_process_output):
1381 Port to ns-resolution time stamps.
1382 (Faccept_process_output, wait_reading_process_output):
1383 Check for time stamp overflow. Do not assume time_t is signed.
1384 (select_wrapper): Remove; we now use pselect.
1385 (Fprocess_attributes): Now generates ns-resolution time stamps.
1386
1387 * sysdep.c: Include utimens.h. Don't include utime.h
1388 or worry about struct utimbuf; gnulib does that for us now.
1389 (gettimeofday): Remove; gnulib provides a substitute.
1390 (make_timeval): New function.
1391 (set_file_times): Now sets ns-resolution time stamps.
1392 New arg FD; all uses changed.
1393 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1394 (system_process_attributes):
1395 Now returns ns-resolution time stamp. All uses changed.
1396 Check for time stamp overflow.
1397
1398 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1399 provides a substitute now.
1400
1401 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1402 since it guarantees struct timespec.
1403 (EMACS_TIME): Now struct timespec, so that we can support
1404 ns-resolution time stamps.
1405 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1406 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1407 (EMACS_USECS): Remove.
1408 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1409 so multiply the arg by 1000 before storing it.
1410 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1411 New macros.
1412 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1413 Port to ns-resolution time stamps.
1414 (EMACS_TIME_NEG_P): Remove; replaced by....
1415 (EMACS_TIME_SIGN): New macro.
1416 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1417 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1418 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1419 (make_timeval, make_lisp_time, decode_time_components): New decls.
1420 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1421 that it mishandled time_t overflow. You can't compare by subtracting!
1422 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1423 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1424
1425 * term.c: Include <sys/time.h>.
1426 (timeval_to_Time): New function, for proper overflow wraparound.
1427 (term_mouse_position, term_mouse_click): Use it.
1428
1429 * undo.c (record_first_change): Support higher-resolution time stamps
1430 in the undo buffer.
1431 (Fprimitive_undo): Use them when restoring time stamps.
1432
1433 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1434 (w32_get_internal_run_time):
1435 Port to higher-resolution Emacs time stamps.
1436 (ltime): Now accepts single 64-bit integer, as that's more convenient
1437 for callers.
1438
1439 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1440
1441 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1442 for compatibility with pselect. Support ns-resolution time stamps.
1443
1444 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1445
1446 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1447 Check for time stamp overflow, and support ns-resolution time stamps.
1448
1449 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1450 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1451 (timeval_subtract): Remove; no longer needed.
1452 (XTflash, XTring_bell, x_wait_for_event):
1453 Port to ns-resolution time stamps. Don't assume time_t is signed.
1454
b6a92dfe
CY
14552012-06-22 Chong Yidong <cyd@gnu.org>
1456
1457 * xdisp.c (x_consider_frame_title): Revert last change.
1458
d251c37c
EZ
14592012-06-22 Eli Zaretskii <eliz@gnu.org>
1460
1461 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1462 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1463 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1464 staticidx goes up to 1597 out of 1600 = 0x640.)
1465
f10deafb
PE
14662012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1469 Otherwise, the umask might be mistakenly 0 while handling input signals.
1470
ec6de1e2
SM
14712012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1472
1473 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1474
28be1ada
DA
14752012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1478 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1479 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1480 access to `contents' member of Lisp_Vector objects with AREF and ASET
1481 where appropriate.
1482
c6bf3022
CY
14832012-06-19 Chong Yidong <cyd@gnu.org>
1484
1485 * frame.c (delete_frame): When selecting a frame on a different
1486 text terminal, do not alter the terminal's top-frame.
1487
1488 * xdisp.c (format_mode_line_unwind_data): Record the target
1489 frame's selected window and its terminal's top-frame.
1490 (unwind_format_mode_line): Restore them.
1491 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1492 Callers changed.
1493 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1494 since tty frames can be explicitly named.
1495 (prepare_menu_bars): Likewise.
1496
1497 * term.c (Ftty_top_frame): New function.
1498
defd4196
PE
14992012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1500
1501 Port byte-code-meter to modern targets.
1502 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1503 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1504 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1505 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1506 (METER_1, METER_2): Simplify.
1507
1053a871
SM
15082012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1509
1510 * data.c (Fdefalias): Return `symbol' (bug#11686).
1511
b7e8d081
MR
15122012-06-18 Martin Rudalics <rudalics@gmx.at>
1513
1514 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1515 gets killed during executing of this function (Bug#11665).
1516 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1517 (Vkill_buffer_query_functions): In doc-string say that functions
1518 run by this hook should not change the current buffer.
1519
7ea2b339
PE
15202012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1521
1522 Fix recently-introduced process.c problems found by static checking.
1523 * process.c (write_queue_push, write_queue_pop, send_process):
1524 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1525 (write_queue_pop): Fix pointer signedness problem.
1526 (send_process): Remove unused local.
1527
96a313a1
CY
15282012-06-17 Chong Yidong <cyd@gnu.org>
1529
1530 * xdisp.c (redisplay_internal): No need to redisplay terminal
1531 frames that are not on top.
1532
20ca2e94
TN
15332012-06-17 Troels Nielsen <bn.troels@gmail.com>
1534
1535 * process.c (make_process): Initialize write_queue.
1536 (write_queue_push, write_queue_pop): New functions.
1537 (send_process): Use them to maintain correct ordering of process
1538 writes (Bug#10815).
1539
9a900ca9
PE
15402012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1541
310fbfa8
PE
1542 * lisp.h (eassert): Assume C89 or later.
1543 This removes the need for CHECK.
1544 (CHECK): Remove. Its comments about always evaluating its
1545 argument were confusing, as 'eassert' typically does not evaluate
1546 its argument.
1547
27bb1ca4
PE
1548 * coding.c (produce_chars): Use ptrdiff_t, not int.
1549
9a900ca9
PE
1550 * xterm.c (x_draw_underwave): Check for integer overflow.
1551 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1552
41b7f8bc 15532012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1554
1555 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1556 referenced (Bug#11583).
1557
9b0e3eba
AA
15582012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1559
1560 Implement wave-style variant of underlining.
1561 * dispextern.h (face_underline_type): New enum.
1562 (face): Add field for underline type.
1563 * nsterm.m (ns_draw_underwave): New function.
1564 (ns_draw_text_decoration): Use it.
1565 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1566 New functions.
1567 (x_draw_glyph_string): Use them.
1568 * xfaces.c (Qline, Qwave): New Lisp objects.
1569 (check_lface_attrs, merge_face_ref)
1053a871
SM
1570 (Finternal_set_lisp_face_attribute, realize_x_face):
1571 Handle wave-style underline face attributes.
9b0e3eba
AA
1572 * xterm.c (x_draw_underwave): New function.
1573 (x_draw_glyph_string): Use it.
1574
0fb52f11
JB
15752012-06-16 Juanma Barranquero <lekktu@gmail.com>
1576
1577 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1578 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1579 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1580 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1581 ($(BLD)/w32select.$(O)): Update dependencies.
1582
e5560ff7
AS
15832012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1584
1585 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1586 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1587 * character.c (_fetch_multibyte_char_p): Remove.
1588 * alloc.c: Include "character.h" before "buffer.h".
1589 * bidi.c: Likewise.
1590 * buffer.c: Likewise.
1591 * bytecode.c: Likewise.
1592 * callint.c: Likewise.
1593 * callproc.c: Likewise.
1594 * casefiddle.c: Likewise.
1595 * casetab.c: Likewise.
1596 * category.c: Likewise.
1597 * cmds.c: Likewise.
1598 * coding.c: Likewise.
1599 * composite.c: Likewise.
1600 * dired.c: Likewise.
1601 * dispnew.c: Likewise.
1602 * doc.c: Likewise.
1603 * dosfns.c: Likewise.
1604 * editfns.c: Likewise.
1605 * emacs.c: Likewise.
1606 * fileio.c: Likewise.
1607 * filelock.c: Likewise.
1608 * font.c: Likewise.
1609 * fontset.c: Likewise.
1610 * fringe.c: Likewise.
1611 * indent.c: Likewise.
1612 * insdel.c: Likewise.
1613 * intervals.c: Likewise.
1614 * keyboard.c: Likewise.
1615 * keymap.c: Likewise.
1616 * lread.c: Likewise.
1617 * macros.c: Likewise.
1618 * marker.c: Likewise.
1619 * minibuf.c: Likewise.
1620 * nsfns.m: Likewise.
1621 * nsmenu.m: Likewise.
1622 * print.c: Likewise.
1623 * process.c: Likewise.
1624 * regex.c: Likewise.
1625 * region-cache.c: Likewise.
1626 * search.c: Likewise.
1627 * syntax.c: Likewise.
1628 * term.c: Likewise.
1629 * textprop.c: Likewise.
1630 * undo.c: Likewise.
1631 * unexsol.c: Likewise.
1632 * w16select.c: Likewise.
1633 * w32fns.c: Likewise.
1634 * w32menu.c: Likewise.
1635 * window.c: Likewise.
1636 * xdisp.c: Likewise.
1637 * xfns.c: Likewise.
1638 * xmenu.c: Likewise.
1639 * xml.c: Likewise.
1640 * xselect.c: Likewise.
1641
2f07e6af
EZ
16422012-06-16 Eli Zaretskii <eliz@gnu.org>
1643
1053a871
SM
1644 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1645 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1646 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1647 row.
1648 (handle_face_prop): Use chunk-relative overlay string index when
1649 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1650 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1651 the rightmost. (Bug#11720)
2f07e6af 1652
29b83cec
AS
16532012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1654
1655 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1656 (CATEGORY_MEMBER): Enforce 1/0 value.
1657 * category.c (_temp_category_set): Remove.
1658
4c5501e9
EZ
16592012-06-16 Eli Zaretskii <eliz@gnu.org>
1660
1661 * window.c (Fdelete_other_windows_internal)
1662 (Fdelete_window_internal): Don't access frame's mouse highlight
1663 info of the initial frame. (Bug#11677)
1664
2b570124
PE
16652012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1666
e93864f9
PE
1667 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1668 Assume USE_2_TAGS_FOR_INTS.
1669 (xreload): Adjust $tagmask width to match recent lisp.h change.
1670
2b570124
PE
1671 Simplify lisp.h in minor ways that should not affect code.
1672 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1673 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1674 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1675 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1676 (INTTYPEBITS): New macro, for clarity.
1677 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1678 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1679 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1680 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1681 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1682
81755f69
JB
16832012-06-13 Juanma Barranquero <lekktu@gmail.com>
1684
1685 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1686
16192a57
GM
16872012-06-13 Glenn Morris <rgm@gnu.org>
1688
1689 * s/bsd-common.h (BSD4_3):
1690 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1691
646b5f55
AS
16922012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1693
1694 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1695 instead of union.
1696 (XLI, XIL): Define.
1053a871
SM
1697 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1698 Use them.
1699 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1700 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1701 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1702 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1703 * frame.c (delete_frame): Remove outdated comment.
1704 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1705 USE_LISP_UNION_TYPE.
1706 (Fw32_unregister_hot_key): Likewise.
1707 (Fw32_toggle_lock_key): Likewise.
1708 * w32menu.c (add_menu_item): Likewise.
1709 (w32_menu_display_help): Use XIL instead of checking
1710 USE_LISP_UNION_TYPE.
1711 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1712 (init_heap): Likewise.
1713 * w32term.c (w32_read_socket): Update comment.
1714
1d3823c9
GM
17152012-06-13 Glenn Morris <rgm@gnu.org>
1716
c62ff706
GM
1717 * s/usg5-4-common.h, src/s/unixware.h:
1718 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1719
1d3823c9
GM
1720 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1721
bfe3e0a2
PE
17222012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1723
1724 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1725 * alloc.c (make_number) [!defined make_number]:
1726 Remove, as lisp.h always defines this now.
1727 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1728 (roundup_size): Verify that it is a power of 2.
1729 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1730 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1731 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1732 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1733 USE_LSB_TAG now is always defined to be either 0 or 1.
1734 All uses changed.
1735 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1736 code works fine either way, and efficiency is not a concern here,
1737 as the union type is for debugging, not for production.
1738 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1739 Use an inline function on all platforms when using the union type,
1740 since this is simpler and 'static inline' can be used portably
1741 within Emacs now.
1742 (LISP_INITIALLY_ZERO): New macro.
1743 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1744 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1745
45fa9c0f
GM
17462012-06-12 Glenn Morris <rgm@gnu.org>
1747
b4492cba
GM
1748 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1749
1750 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1751
45fa9c0f
GM
1752 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1753 Move BROKEN_SIGIO to configure.
1754
1755 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1756 Move NO_TERMIO to configure.
1757
0e25d334
CY
17582012-06-12 Chong Yidong <cyd@gnu.org>
1759
1760 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1761 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1762 MagickExportImagePixels is undefined.
1763
43682bb6
PE
17642012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1765
1766 * image.c (imagemagick_load_image): Remove unused label.
1767
a9be7d2b
GM
17682012-06-11 Glenn Morris <rgm@gnu.org>
1769
1770 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1771 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1772 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1773 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1774
3017f87f
SM
17752012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1776
1777 * alloc.c (make_byte_code): New function.
1778 (Fmake_byte_code): Use it. Don't purify here.
1779 * lread.c (read1): Use it as well to avoid extra allocation.
1780
1b9b4cf4
CY
17812012-06-11 Chong Yidong <cyd@gnu.org>
1782
1783 * image.c (imagemagick_load_image): Implement transparency.
1784
95988fcf
AS
17852012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1786
1787 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1788 account for preceding backslashes. (Bug#11663)
1789
cd4eb164
CY
17902012-06-09 Chong Yidong <cyd@gnu.org>
1791
1792 * term.c: Support italics in capable terminals (Bug#9652).
1793 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1794 (turn_on_face): Output using TS_enter_italic_mode if available.
1795 Don't handle unused blinking and alt-charset cases.
1796 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1797 and tty_alt_charset_p cases.
1798 (tty_capable_p, init_tty): Support italics.
1799
1800 * termchar.h (struct tty_display_info): Add field for italics.
1801 Remove unused blink field.
1802
1803 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1804 Handle slant.
1805
1806 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1807 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1808 tty_alt_charset_p. Add tty_italic_p.
1809
ff88beb8
MA
18102012-06-09 Michael Albinus <michael.albinus@gmx.de>
1811
1812 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1813 dbus_type_is_basic if available.
1814 (xd_extract_signed, xd_extract_unsigned): Rename from
1815 extract_signed and extract_unsigned, respectively. Adapt callers.
1816
44286096
CY
18172012-06-09 Chong Yidong <cyd@gnu.org>
1818
1682701f
CY
1819 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1820
44286096
CY
1821 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1822 case (Bug#9752).
1823
d86feb17
PE
18242012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * xdisp.c (vmessage): Treat frame message as multibyte.
1827 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1828 would generate the diagnostic "Making \302\247 buffer-local while
1829 let-bound!".
1830
d5c20fe8
EZ
18312012-06-08 Eli Zaretskii <eliz@gnu.org>
1832
1833 * dispnew.c (showing_window_margins_p): Undo last change, which
1834 was done due to an inadvertent commit.
1835 (adjust_frame_glyphs_for_frame_redisplay): Do call
1836 showing_window_margins_p.
1837
513749ee
SM
18382012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1839
1840 * eval.c (Fmake_var_non_special): New primitive.
1841 (syms_of_eval): Defsubr it.
1842 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1843
d4a8f5c1
JB
18442012-06-08 Juanma Barranquero <lekktu@gmail.com>
1845
1846 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1847 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1848
8bbbc977
EZ
18492012-06-08 Eli Zaretskii <eliz@gnu.org>
1850
1851 * alloc.c (allocate_vectorlike): Fix last change.
1852
f3372c87
DA
18532012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1854
1855 Block-based vector allocation of small vectors.
1856 * lisp.h (struct vectorlike_header): New field `nbytes',
1857 adjust comment accordingly.
1858 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1859 to denote vector blocks. Adjust users (live_vector_p,
1860 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1861 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1862 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1863 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1864 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1865 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1866 (roundup_size): New constant.
1867 (struct vector_block): New data type.
1868 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1869 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1870 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1871 (sweep_vectors): New functions.
1872 (allocate_vectorlike): Return `zero_vector' as the only vector of
1873 0 items. Allocate new vector from block if vector size is less than
1874 or equal to VBLOCK_BYTES_MAX.
1875 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1876 (init_alloc_once): Add call to init_vectors.
1877
4f18a4ed
SM
18782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1879
1880 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1881
86f158bc
PE
18822012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1883
1884 * doprnt.c (doprnt): Truncate multibyte char correctly.
1885 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1886 would mishandle a string argument "Xc" if X was a multibyte
1887 character of length 2: it would truncate after X's first byte
1888 rather than including all of X.
1889
c5cfcbe0
CY
18902012-06-06 Chong Yidong <cyd@gnu.org>
1891
1892 * buffer.c (word_wrap): Doc fix.
1893
c05cf390
PE
18942012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1895
1896 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1897
0c3461de
GM
18982012-06-03 Glenn Morris <rgm@gnu.org>
1899
1900 * xdisp.c (tool-bar-style): Doc fix.
1901
c71232db
UM
19022012-06-03 Ulrich Müller <ulm@gentoo.org>
1903
1904 * Makefile.in (PAXCTL): Define.
1905 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1906 binary via PaX flags if the paxctl utility is available.
1907 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1908 Restore PaX flags to their default. (Bug#11398)
1909
383f7350
CY
19102012-06-03 Chong Yidong <cyd@gnu.org>
1911
1912 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1913 buffer (Bug#11226).
1914
5f2c76c6
CY
19152012-06-03 Chong Yidong <cyd@gnu.org>
1916
1917 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1918 (note_mode_line_or_margin_highlight): If there is no help echo,
1919 use mode-line-default-help-echo. Handle the case where the mouse
1920 position is past the end of the mode line string.
1921
1922 * buffer.c (buffer_local_value_1): New function, split from
1923 Fbuffer_local_value; can return Qunbound.
1924 (Fbuffer_local_value): Use it.
1925 (Vmode_line_format): Docstring tweaks.
1926
773d47f6
PE
19272012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 * sysdep.c (system_process_attributes): Improve comment.
1930
f2d6a3df
SM
19312012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1932
1933 * keyboard.c: Export real-this-command to Elisp.
1934 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1935 and DEFVAR it. Update all users.
1936
63810350
PE
19372012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1938
7bd5c1f4
PE
1939 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1940
63810350
PE
1941 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1942 Convert pctcpu and pctmem to Lisp float properly.
1943 Let the compiler fold better, as 100.0/0x8000 is exact.
1944
a2821611
AS
19452012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1946
1947 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1948 cons_block.
1949
5fceba1d
PE
19502012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1953
c98ff5dd
DA
19542012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1955
1956 For a 'struct window', replace some Lisp_Object fields to
1957 bitfields where appropriate, remove unused fields.
1958 * window.h (struct window): Remove unused 'last_mark_x' and
1959 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1960 change it's type from Lisp_Object to bitfield.
1961 Change type of 'force_start', 'optional_new_start',
1962 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1963 fields from Lisp_Object to bitfield. Adjust users accordingly.
1964
ca34e0be
PE
19652012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 Pacify gcc -Wdouble-precision when using Xaw.
1968 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1969 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1970 Use 'float' consistently, rather than 'float' in most places
1971 and 'double' in a couple of places.
1972
efc00ab1 19732012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1974
1975 * xdisp.c (handle_stop): Detect whether we have overlay strings
1976 loaded by testing it->current.overlay_string_index to be
1977 non-negative, instead of checking whether n_overlay_strings is
1978 positive. (Bug#11587)
1979
efc00ab1 19802012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1981
1982 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1983
1984 * doc.c (Fsubstitute_command_keys): Doc fix.
1985
efc00ab1 19862012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1987
1988 * search.c (search_buffer): Remove calls to
1989 r_alloc_inhibit_buffer_relocation, as it is now called by
1990 maybe_unify_char, which was the cause of relocation of buffer text
1991 in bug#11519.
1992
efc00ab1 19932012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1994
1995 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1996 for the duration of call to load_charset, to avoid problems with
1997 callers of maybe_unify_char that access buffer text through C
1998 pointers.
1999
2000 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2001 decrement the inhibition flag, instead of just setting or
2002 resetting it.
2003
ba93a187
PE
20042012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2005
2006 Remove obsolete '#define static' cruft.
2007 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2008 This #undef was "temporary" in 2000; it is no longer needed
2009 now that '#define static' has gone away.
2010 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2011 (gray_bitmap_bits): Remove; no longer needed.
2012 All uses replaced with definiens.
2013 * xterm.c: Include "bitmaps/gray.xbm".
2014
9e4bf381
PE
20152012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2016
2017 Clean up __executable_start, monstartup when --enable-profiling.
2018 The following changes affect the code only when profiling.
2019 * dispnew.c (__executable_start): Rename from safe_bcopy.
2020 Define only on platforms that need it.
2021 * emacs.c: Include <sys/gmon.h> when profiling.
2022 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2023 (__executable_start): Remove decl, since lisp.h does it now.
2024 (safe_bcopy): Remove decl; no longer has that name.
2025 (main): Coalesce #if into single bit of code, for simplicity.
2026 Cast pointers to uintptr_t, since standard libraries want integers
2027 and not pointers.
2028 * lisp.h (__executable_start): New decl.
2029
32d72c2f
GM
20302012-05-31 Glenn Morris <rgm@gnu.org>
2031
2032 * image.c (Fimagemagick_types): Doc fix.
2033
baac5bc7
JM
20342012-05-30 Jim Meyering <meyering@redhat.com>
2035
2036 * callproc.c (Fcall_process_region): Include directory component
2037 in mkstemp error message (Bug#11586).
2038
72cb32cf
PE
20392012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2040
2041 * alloc.c, lisp.h (make_pure_vector): Now static.
2042
61b108cc
SM
20432012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2044
2045 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2046 Move to byte-run.el.
2047 (Fautoload): Do the hash-doc more carefully.
2048 * data.c (Fdefalias): Purify definition, except for keymaps.
2049 (Qdefun): Move from eval.c.
2050 * lisp.h (Qdefun): Remove.
2051 * lread.c (read1): Tiny simplification.
2052
471fe23d
TN
20532012-05-29 Troels Nielsen <bn.troels@gmail.com>
2054
934f3f58 2055 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2056 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2057 Bug#9642, but explicitly check that the buffer the overlay would
2058 be moved to is live and rearrange lines to make sure that errors
2059 will not put the overlay in an inconsistent state.
2060 (Fdelete_overlay): Cosmetics.
2061
85d0efd1
EZ
20622012-05-28 Eli Zaretskii <eliz@gnu.org>
2063
2064 * w32term.c (my_bring_window_to_top): New function.
2065 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2066 could be different from the original one.
2067 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2068 (Bug#11513)
2069
2070 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2071 by calling BringWindowToTop.
2072
2073 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2074 (WM_EMACS_END): Increase by one.
2075
da92a98c
PE
20762012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2077
2078 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2079 This avoids undefined behavior that might cause the eassert
2080 to not catch an out-of-range value.
2081
74d1f848
JB
20822012-05-28 Juanma Barranquero <lekktu@gmail.com>
2083
2084 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2085 Update dependencies.
2086
9e1a06fc
EZ
20872012-05-27 Eli Zaretskii <eliz@gnu.org>
2088
2089 * bidi.c (bidi_mirror_char): Fix last change.
2090
f3dd7312
AS
20912012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2092
2093 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2094 when referring to sectname field in printf format.
2095
81899c91
PE
20962012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2097
57b81a9f
PE
2098 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2099 Only r_alloc_inhibit_buffer_relocation needed to be added;
2100 the others were already declared.
2101
81899c91
PE
2102 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2103 before checking whether it's out of range. Put the check inside
2104 eassert. See
2105 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2106
33017faf 21072012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2108
2109 * callproc.c (Fcall_process): Restore a line that was accidentally
2110 commented out in the 2011-02-13 change (bug#11547).
2111
33017faf 21122012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2113
2114 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2115 defined on ralloc.c.
2116
2117 * buffer.c [REL_ALLOC]: Remove prototypes of
2118 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2119 they are now on lisp.h.
2120
2121 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2122
2123 * search.c (search_buffer): Use it to inhibit relocation of buffer
2124 text while re_search_2 is doing its job, because re_search_2 is
2125 passed C pointers to buffer text. (Bug#11519)
2126
23415acf
EZ
2127 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2128 Update value to 24.
2129
44e27368
EZ
2130 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2131 state after an additional call to move_it_in_display_line_to, keep
2132 the values of it->max_ascent and it->max_descent found for the
2133 entire line.
2134 (pos_visible_p): Revert the comparison against bottom_y to what it
2135 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2136 (Bug#11464)
2137
c1892f11
PE
21382012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 Fix coding-related core dumps with gcc -ftrapv.
2141 The code was computing A - B, where A and B are pointers, and B is
2142 random garbage. This can lead to core dumps on platforms that
2143 have special pointer registers, and it also leads to core dumps on
2144 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2145 A - B only when B is initialized properly.
2146 * coding.c (coding_set_source, coding_set_destination): Return void.
2147 (coding_change_source, coding_change_destinations): New functions,
2148 with the old behaviors of coding_set_source and coding_set_destination.
2149 All callers that need an offset changed to use these new functions.
2150
eb7afdad
GM
21512012-05-26 Glenn Morris <rgm@gnu.org>
2152
2153 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2154
f12fdf02
EZ
21552012-05-26 Eli Zaretskii <eliz@gnu.org>
2156
53a63be6 2157 Extend mouse support on W32 text-mode console.
61b108cc
SM
2158 * xdisp.c (draw_row_with_mouse_face):
2159 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2160
eb3f6f01 2161 * w32console.c: Include window.h.
61b108cc
SM
2162 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2163 New functions.
eb3f6f01
EZ
2164 (initialize_w32_display): Initialize mouse-highlight data.
2165
53a63be6
EZ
2166 * w32inevt.c: Include termchar.h and window.h.
2167 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2168 moves, call note_mouse_highlight. If help_echo changed, call
2169 gen_help_event to produce help-echo message in the echo area.
2170 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2171 highlight info.
2172
4cfd81f6
PE
21732012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2174
2175 * lread.c (read1): Simplify slightly to avoid an overflow warning
2176 with GCC 4.7.0 on x86-64.
2177
4446092a
EZ
21782012-05-26 Eli Zaretskii <eliz@gnu.org>
2179
2180 * bidi.c (bidi_mirror_char): Revert last change: an int is
2181 definitely wide enough here.
2182
42b2a986 21832012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2184
42b2a986 2185 Fix integer width and related bugs (Bug#9874).
eb106a49 2186 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2187 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2188 (string_bytes, check_sblock, allocate_string_data):
2189 (compact_small_strings, Fmake_bool_vector, make_string)
2190 (make_unibyte_string, make_multibyte_string)
2191 (make_string_from_bytes, make_specified_string)
2192 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2193 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2194 (mark_vectorlike):
2195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2196 (allocate_pseudovector):
2197 Use int, not EMACS_INT, where int is wide enough.
2198 (inhibit_garbage_collection, Fgarbage_collect):
2199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2200 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2201 int might not be wide enough.
2202 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2203 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2204 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2205 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2206 (bidi_level_of_next_char, bidi_move_to_visually_next):
2207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2208 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2209 (Fkill_buffer, Fset_buffer_major_mode)
2210 (advance_to_char_boundary, Fbuffer_swap_text)
2211 (Fset_buffer_multibyte, overlays_at, overlays_in)
2212 (overlay_touches_p, struct sortvec, record_overlay_string)
2213 (overlay_strings, recenter_overlay_lists)
2214 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2215 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2216 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2217 (Foverlay_recenter, last_overlay_modification_hooks_used)
2218 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2220 (validate_region): Omit unnecessary test for b <= e,
2221 since that's guaranteed by the previous test.
d311d28c
PE
2222 (adjust_overlays_for_delete): Avoid pos + length overflow.
2223 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2224 (report_overlay_modification):
2225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2226 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2227 Omit pointer cast, which isn't needed anyway, and doesn't work
2228 after the EMACS_INT -> ptrdiff_t change.
02481186 2229 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2230 * buffer.h: Adjust decls to match defn changes elsewhere.
2231 (struct buffer_text, struct buffer):
2232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2233 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2234 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2235 not int, to avoid needless 32-bit limit on 64-bit hosts.
2236 (exec_byte_code): Use tighter memory-full test, one that checks
2237 for alloca overflow. Don't compute the address of the object just
2238 before an array, as that's not portable. Use EMACS_INT, not
2239 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2240 * callint.c (Fcall_interactively):
2241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2242 * callproc.c (call_process_kill, Fcall_process):
2243 Don't assume pid_t fits into an Emacs fixnum.
2244 (call_process_cleanup, Fcall_process, child_setup):
2245 Don't assume pid_t fits into int.
2246 (call_process_cleanup, Fcall_process, delete_temp_file)
2247 (Fcall_process_region):
2248 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2249 (Fcall_process): Simplify handling of volatile integers.
2250 Use int, not EMACS_INT, where int will do.
2251 * casefiddle.c (casify_object, casify_region, operate_on_word)
2252 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2254 (casify_object): Avoid integer overflow when overallocating buffer.
2255 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2256 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2257 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2258 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2259 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2260 integers are now checked earlier. All uses replaced with XINT.
2261 (ccl_driver):
2262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2263 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2264 (ccl_driver, Fregister_code_conversion_map):
2265 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2266 (resolve_symbol_ccl_program): Check that vector header is in range.
2267 Always copy the vector, so that we can check its contents reliably
2268 now rather than having to recheck each instruction as it's being
2269 executed. Check that vector words fit in 'int'.
2270 (ccl_get_compiled_code, Fregister_ccl_program)
2271 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2272 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2273 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2274 contents are in range.
2275 (Fccl_execute_on_string): Check that status is in range.
2276 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2277 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2278 Accept and return EMACS_INT, not int, because callers can pass values
2279 out of 'int' range.
2280 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2281 (multibyte_chars_in_text, parse_str_as_multibyte)
2282 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2283 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2284 (string_escape_byte8, Fget_byte):
2285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2286 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2287 avoid mishandling large integers.
2288 * character.h: Adjust decls to match defn changes elsewhere.
2289 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2290 (Ffind_charset_region):
2291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2292 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2293 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2294 Don't assume fixnum fits in int.
d311d28c
PE
2295 (load_charset_map_from_vector, Fmap_charset_chars):
2296 Remove now-unnecessary CHECK_NATNUMs.
2297 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2298 Don't rely on undefined behavior with signed left shift overflow.
2299 Don't assume unsigned int fits into fixnum, or that fixnum fits
2300 into unsigned int. Don't require max_code to be a valid fixnum;
2301 that's not true for gb10830 4-byte on a 32-bit host. Allow
2302 invalid_code to be a cons, for the same reason. Require code_offset
2303 to be a character. Avoid int overflow if max_char is close
2304 to INT_MAX.
2305 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2306 this is intended anyway and avoids some undefined behavior.
2307 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2308 INDEX_TO_CODE_POINT, as that's what it expects.
2309 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2310 * charset.h (DECODE_CHAR): Return int, not unsigned;
2311 this is what was intended anyway, and it avoids undefined behavior.
2312 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2313 integer-overflow issues.
2314 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2315 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2316 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2317 * chartab.c (Fmake_char_table, Fset_char_table_range)
2318 (uniprop_get_decoder, uniprop_get_encoder):
2319 Don't assume fixnum fits in int.
2320 * cmds.c (move_point): New function, that does the gist of
2321 Fforward_char and Fbackward_char, but does so while checking
2322 for integer overflow more accurately.
c96e5d6a 2323 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2324 (Fforward_line, Fend_of_line, internal_self_insert)
2325 (internal_self_insert):
2326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2327 Fix a FIXME, by checking for integer overflow when calculating
2328 target_clm and actual_clm.
2329 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2330 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2331 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2332 (coding_alloc_by_making_gap, alloc_destination)
2333 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2334 (encode_coding_utf_16, detect_coding_emacs_mule)
2335 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2336 (detect_coding_iso_2022, decode_coding_iso_2022)
2337 (encode_invocation_designation, encode_designation_at_bol)
2338 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2339 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2340 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2341 (encode_coding_ccl, encode_coding_raw_text)
2342 (detect_coding_charset, decode_coding_charset)
2343 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2344 (produce_composition, produce_charset, produce_annotation)
2345 (decode_coding, handle_composition_annotation)
2346 (handle_charset_annotation, consume_chars, decode_coding_gap)
2347 (decode_coding_object, encode_coding_object, detect_coding_system)
2348 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2349 (code_convert_region, code_convert_string)
8f50130c
PE
2350 (Fdefine_coding_system_internal)
2351 (coding_set_source, coding_set_destination):
d311d28c
PE
2352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2353 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2354 (Fdefine_coding_system_internal):
2355 Don't assume fixnums fit in int.
2356 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2357 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2358 (Funencodable_char_position, Fcheck_coding_systems_region)
2359 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2361 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2362 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2363 Don't access memory outside of the args array.
d311d28c 2364 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2365 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2366 result of ENCODE_CHAR.
d311d28c
PE
2367 * coding.h: Adjust decls to match defn changes elsewhere.
2368 (struct coding_system):
2369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2370 * composite.c (get_composition_id, find_composition)
2371 (run_composition_function, update_compositions)
2372 (compose_text, composition_gstring_put_cache)
2373 (composition_gstring_p, composition_gstring_width)
2374 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2375 (composition_compute_stop_pos, composition_reseat_it)
2376 (composition_update_it, struct position_record)
2377 (find_automatic_composition, composition_adjust_point)
2378 (Fcomposition_get_gstring, Ffind_composition_internal):
2379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2380 (update_compositions):
2381 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2382 * composite.h: Adjust decls to match defn changes elsewhere.
2383 (struct composition):
2384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2385 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2386 Do not attempt to compute the address of the object just before a
2387 buffer; this is not portable.
2388 (Faref, Faset):
2389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2390 (Faset): Use int, not EMACS_INT, where int is wide enough.
2391 (Fstring_to_number): Don't assume fixnums fit in int.
2392 (Frem): Don't assume arg is nonnegative.
2393 * dbusbind.c (xd_append_arg): Check for integers out of range.
2394 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2395 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2396 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2397 (xd_get_connection_references): Return ptrdiff_t, not int.
2398 All uses changed.
2399 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2400 (xd_read_message_1):
2401 Use int, not unsigned, where the dbus API uses int.
2402 (Fdbus_message_internal): Don't overflow mtype.
2403 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2404 * dired.c (directory_files_internal, file_name_completion, scmp)
2405 (file_name_completion_stat):
2406 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2407 (file_name_completion): Don't overflow matchcount.
2408 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2409 * dispextern.h: Adjust decls to match defn changes elsewhere.
2410 (struct text_pos, struct glyph, struct bidi_saved_info)
2411 (struct bidi_string_data, struct bidi_it, struct composition_it)
2412 (struct it):
2413 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2414 (struct display_pos, struct composition_it, struct it):
2415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2416 * dispnew.c (increment_matrix_positions)
2417 (increment_row_positions, mode_line_string)
2418 (marginal_area_string):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2420 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2422 (duration_to_sec_usec): New function, to check for overflow better.
2423 (Fsleep_for, sit_for): Use it.
2424 * doc.c (get_doc_string, store_function_docstring):
2425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2426 (get_doc_string, Fsnarf_documentation):
2427 Use int, not EMACS_INT, where int is wide enough.
2428 (get_doc_string):
2429 Use SAFE_ALLOCA, not alloca.
2430 Check for overflow when converting EMACS_INT to off_t.
2431 * doprnt.c (doprnt):
2432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2433 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2434 Don't assume uid_t fits into fixnum.
2435 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2436 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2437 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2438 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2439 (general_insert_function)
2440 (Finsert_char, make_buffer_string, make_buffer_string_both)
2441 (update_buffer_properties, Fbuffer_substring)
2442 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2443 (Fsubst_char_in_region, check_translation)
2444 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2445 (transpose_markers, Ftranspose_regions):
2446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2447 (clip_to_bounds): Move to lisp.h as an inline function).
2448 (Fconstrain_to_field): Don't assume integers are nonnegative.
2449 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2450 (Fsubst_char_in_region, Fsave_restriction):
2451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2452 (Femacs_pid): Don't assume pid_t fits into fixnum.
2453 (lo_time): Use int, not EMACS_INT, when int suffices.
2454 (lisp_time_argument): Check for usec out of range.
2455 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2456 (Fuser_login_name, Fuser_full_name): Signal an error
2457 if a uid argument is out of range, rather than relying on
2458 undefined behavior.
c8d5c857
PE
2459 (Fformat_time_string): Remove now-unnecessary check.
2460 lisp_time_argument checks for out-of-range usec now.
243e0530 2461 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2462 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2463 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2464 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2465 (init_cmdargs, Fdump_emacs):
2466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2467 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2468 the bottom (typically) 32 bits of the fixnum.
2469 * eval.c (specpdl_size, call_debugger):
2470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2471 (when_entered_debugger, Fbacktrace_debug):
2472 Don't assume fixnum can fit in int.
2473 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2474 the object just before a buffer; this is not portable.
2475 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2476 (grow_specpdl, unbind_to):
2477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2478 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2479 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2480 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2481 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2482 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2484 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2485 (a_write, e_write):
2486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2487 (Fcopy_file, non_regular_nbytes, read_non_regular)
2488 (Finsert_file_contents):
2489 Use int, not EMACS_INT, where int is wide enough.
2490 (READ_BUF_SIZE): Verify that it fits in int.
2491 (Finsert_file_contents): Check that counts are in proper range,
2492 rather than assuming fixnums fit into ptrdiff_t etc.
2493 Don't assume fixnums fit into int.
125b3835 2494 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2495 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2496 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2497 (string_char_to_byte, string_byte_to_char)
2498 (string_make_multibyte, string_to_multibyte)
2499 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2500 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2501 (substring_both, Fdelete, internal_equal, Ffillarray)
2502 (Fclear_string, mapcar1)
2503 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2504 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2505 (larger_vector, make_hash_table, maybe_resize_hash_table)
2506 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2507 (Fmaphash, secure_hash):
2508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2509 (concat): Check for string index and length overflow.
2510 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2511 (Frequire):
2512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2513 (larger_vector): New API (vec, incr_min, size_max) replaces old
2514 one (vec, new_size, init). This catches size overflow.
2515 INIT was removed because it was always Qnil.
2516 All callers changed.
2517 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2518 the upper bound on a hash table index size.
2519 (make_hash_table, maybe_resize_hash_table): Use it.
2520 (secure_hash): Computer start_byte and end_byte only after
2521 they're known to be in ptrdiff_t range.
2522 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2523 (Ffont_get_glyphs, Ffont_at):
2524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2525 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2526 (Flist_fonts, Fopen_font):
2527 Don't assume fixnum can fit in int.
2528 (check_gstring): Don't assume index can fit in int.
2529 (font_match_p): Check that fixnum is a character, not a nonnegative
2530 fixnum, since the later code needs to stuff it into an int.
2531 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2532 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2533 conversion overflow issues.
2534 (Fopen_font): Check for integer out of range.
2535 (Ffont_get_glyphs): Don't assume index can fit in int.
2536 * font.h: Adjust decls to match defn changes elsewhere.
2537 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2538 integer overflow.
2539 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2540 printmax_t, where ptrdiff_t is wide enough.
2541 (Finternal_char_font):
2542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2543 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2544 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2545 (Fset_frame_position, x_set_frame_parameters)
2546 (x_set_line_spacing, x_set_border_width)
2547 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2548 Check that fixnums are in proper range for system types.
2549 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2551 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2552 Use SAFE_ALLOCA_LISP, not alloca.
2553 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2554 intptr_t is wide enough.
2555 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2556 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2557 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2558 Check for fixnum out of range.
2559 * ftfont.c (ftfont_list): Don't assume index fits in int.
2560 Check that fixnums are in proper range for system types.
2561 (ftfont_shape_by_flt):
2562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2563 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2565 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2566 Check that fixnums are in proper range for system types.
2567 * gnutls.h: Adjust decls to match defn changes elsewhere.
2568 * gtkutil.c (xg_dialog_run):
2569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2570 (update_frame_tool_bar):
2571 Check that fixnums are in proper range for system types.
2572 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2573 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2574 * indent.c (last_known_column, last_known_column_point):
2575 (current_column_bol_cache):
2576 (skip_invisible, current_column, check_display_width):
2577 (check_display_width, scan_for_column, current_column_1)
2578 (Findent_to, Fcurrent_indentation, position_indentation)
2579 (indented_beyond_p, Fmove_to_column, compute_motion):
2580 (Fcompute_motion, Fvertical_motion):
2581 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 (last_known_column_modified): Use EMACS_INT, not int.
2583 (check_display_width):
2584 (Fcompute_motion):
2585 Check that fixnums and floats are in proper range for system types.
2586 (compute_motion): Don't assume index or fixnum fits in int.
2587 (compute_motion, Fcompute_motion):
2588 Use int, not EMACS_INT, when it is wide enough.
2589 (vmotion): Omit local var start_hpos that is always 0; that way
2590 we don't need to worry about overflow in expressions involving it.
2591 * indent.h: Adjust decls to match defn changes elsewhere.
2592 (struct position):
2593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2594 Use int, not EMACS_INT, where int is wide enough.
2595 Remove unused members ovstring_chars_done and tab_offset;
2596 all uses removed.
2597 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2598 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2599 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2600 (make_gap, copy_text, insert, insert_and_inherit)
2601 (insert_before_markers, insert_before_markers_and_inherit)
2602 (insert_1, count_combining_before, count_combining_after)
2603 (insert_1_both, insert_from_string)
2604 (insert_from_string_before_markers, insert_from_string_1)
2605 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2606 (adjust_after_replace, adjust_after_insert, replace_range)
2607 (replace_range_2, del_range, del_range_1, del_range_byte)
2608 (del_range_both, del_range_2, modify_region)
2609 (prepare_to_modify_buffer, signal_before_change)
2610 (signal_after_change, Fcombine_after_change_execute):
2611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2612 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2613 (balance_an_interval, split_interval_right, split_interval_left)
2614 (find_interval, next_interval, update_interval)
2615 (adjust_intervals_for_insertion, delete_node, delete_interval)
2616 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2617 (static_offset_intervals, offset_intervals)
2618 (merge_interval_right, merge_interval_left, make_new_interval)
2619 (graft_intervals_into_buffer, temp_set_point_both)
2620 (temp_set_point, set_point, adjust_for_invis_intang)
2621 (set_point_both, move_if_not_intangible, get_property_and_range)
2622 (get_local_map, copy_intervals, copy_intervals_to_string)
2623 (compare_string_intervals, set_intervals_multibyte_1):
2624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2625 * intervals.h: Adjust decls to match defn changes elsewhere.
2626 (struct interval):
2627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2628 * keyboard.c (this_command_key_count, this_single_command_key_start)
2629 (before_command_key_count, before_command_echo_length, echo_now)
2630 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2631 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2632 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2633 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2635 (last_non_minibuf_size, last_point_position, echo_truncate)
2636 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2637 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2638 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2639 (stuff_buffered_input):
2640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2641 (last_auto_save, command_loop_1, read_char):
2642 Use EMACS_INT, not int, to avoid integer overflow.
2643 (record_char): Avoid overflow in total_keys computation.
2644 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2645 * keyboard.h: Adjust decls to match defn changes elsewhere.
2646 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2647 (Fkey_description, Fdescribe_vector, Flookup_key):
2648 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2649 (click_position): New function, to check that positions are in range.
2650 (Fcurrent_active_maps):
2651 (describe_command):
2652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2653 (Faccessible_keymaps, Fkey_description):
2654 (preferred_sequence_p):
2655 Don't assume fixnum can fit into int.
2656 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2657 Check for integer overflow in size calculations.
2658 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2659 avoid mishandling large integers.
2660 * lisp.h: Adjust decls to match defn changes elsewhere.
2661 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2662 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2663 (struct Lisp_Marker):
2664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2665 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2666 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2667 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2668 All callers changed.
2669 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2670 Assume the arg has valid form, since it always does.
2671 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2672 unsigned integer system type.
2673 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2674 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2676 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2677 (duration_to_sec_usec): New decl.
2678 * lread.c (read_from_string_index, read_from_string_index_byte)
2679 (read_from_string_limit, readchar, unreadchar, openp)
2680 (read_internal_start, read1, oblookup):
2681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2682 (Fload, readevalloop, Feval_buffer, Feval_region):
2683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2684 (openp): Check for out-of-range argument to 'access'.
2685 (read1): Use int, not EMACS_INT, where int is wide enough.
2686 Don't assume fixnum fits into int.
6efdadfd 2687 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2688 (read_filtered_event): Use duration_to_sec_usec
2689 to do proper overflow checking on durations.
d311d28c
PE
2690 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2691 in size calculation.
2692 (Fexecute_kbd_macro):
2693 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2694 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2695 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2696 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2697 (set_marker_both, set_marker_restricted_both, marker_position)
2698 (marker_byte_position, Fbuffer_has_markers_at):
2699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2700 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2701 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2702 It now merely ensures that the menu is large enough, without
2703 necessarily growing it, as this avoids some integer overflow issues.
2704 All callers changed.
2705 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2707 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2708 Use SAFE_ALLOCA_LISP, not alloca.
2709 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2710 to EMACS_INT. Check that fixnums are in proper range for system types.
2711 * minibuf.c (minibuf_prompt_width, string_to_object)
2712 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2713 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2715 (get_minibuffer, read_minibuf_unwind):
2716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2717 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2718 this simplifies overflow checking. All callers changed.
2719 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2720 (Ftest_completion):
2721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2722 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2723 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2724 Check that fixnums are in proper range for system types.
2725 (Fx_create_frame, Fx_show_tip):
2726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2727 * nsfont.m (ns_findfonts, nsfont_list_family):
2728 Don't assume fixnum fits in long.
2729 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2731 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2732 wide enough.
17fdb222 2733 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2735 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2736 (PRINTDECLARE, PRINTPREPARE):
2737 (strout, print_string):
2738 (print, print_preprocess, print_check_string_charset_prop)
2739 (print_object):
2740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2741 (PRINTDECLARE):
2742 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2744 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2745 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2746 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2747 (print_error_message): Use SAFE_ALLOCA, not alloca.
2748 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2749 (print_depth, new_backquote_output, print_number_index):
2750 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2751 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2752 (Fset_process_window_size, Fformat_network_address)
2753 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2754 (sigchld_handler):
d311d28c 2755 Check that fixnums are in proper range for system types.
d44287d4 2756 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2757 Check for process-ids out of pid_t range rather than relying on
2758 undefined behavior.
e4d81efc 2759 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2760 (Fformat_network_address, read_process_output, send_process)
2761 (Fprocess_send_region, status_notify):
2762 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2763 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2764 (wait_reading_process_output, read_process_output, exec_sentinel):
2765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2766 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2767 (Faccept_process_output): Use duration_to_sec_usec to do proper
2768 overflow checking on durations.
dde14581
PE
2769 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2770 Don't assume pid_t fits in int.
02481186
PE
2771 * process.h (struct Lisp_Process): Members tick and update_tick
2772 are now of type EMACS_INT, not int.
b62b53e8
PE
2773 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2774 configured --with-wide-int.
d311d28c
PE
2775 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2776 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2777 * search.c (looking_at_1, string_match_1):
2778 (fast_string_match, fast_c_string_match_ignore_case)
2779 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2780 (scan_newline, find_before_next_newline, search_command)
2781 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2782 (set_search_regs, wordify):
2783 (Freplace_match):
2784 (Fmatch_data):
2785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2786 (string_match_1, search_buffer, set_search_regs):
2787 (Fmatch_data):
2788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2789 (wordify): Check for overflow in size calculation.
2790 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2791 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2792 Check that fixnums are in proper range for system types.
2793 * sound.c (struct sound_device)
2794 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2796 (Fplay_sound_internal):
2797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2798 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2799 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2800 (Fparse_partial_sexp):
2801 Don't assume fixnums can fit in int.
2802 (struct lisp_parse_state, find_start_pos, find_start_value)
2803 (find_start_value_byte, find_start_begv)
2804 (update_syntax_table, char_quoted, dec_bytepos)
2805 (find_defun_start, prev_char_comend_first, back_comment):
2806 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2807 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2809 (Finternal_describe_syntax_value): Check that match_lisp is a
2810 character, not an integer, since the code stuffs it into int.
2811 (scan_words, scan_sexps_forward):
2812 Check that fixnums are in proper range for system types.
2813 (Fforward_word):
2814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2815 (scan_sexps_forward):
2816 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2817 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2818 * syntax.h: Adjust decls to match defn changes elsewhere.
2819 (struct gl_state_s):
2820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2821 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2822 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2823 * sysdep.c (wait_for_termination_1, wait_for_termination)
2824 (interruptible_wait_for_termination, mkdir):
2825 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2826 (emacs_read, emacs_write):
2827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2828 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2829 and double all fit in int.
d311d28c
PE
2830 * term.c (set_tty_color_mode):
2831 Check that fixnums are in proper range for system types.
2832 * termhooks.h (struct input_event):
2833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2834 * textprop.c (validate_interval_range, interval_of)
2835 (Fadd_text_properties, set_text_properties_1)
2836 (Fremove_text_properties, Fremove_list_of_text_properties)
2837 (Ftext_property_any, Ftext_property_not_all)
2838 (copy_text_properties, text_property_list, extend_property_ranges)
2839 (verify_interval_modification):
2840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2841 (Fnext_single_char_property_change)
2842 (Fprevious_single_char_property_change):
2843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2844 (copy_text_properties):
2845 Check for integer overflow in index calculation.
d311d28c
PE
2846 * undo.c (last_boundary_position, record_point, record_insert)
2847 (record_delete, record_marker_adjustment, record_change)
2848 (record_property_change):
2849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2850 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2852 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2853 (Fx_hide_tip, Fx_file_dialog):
2854 * w32menu.c (set_frame_menubar):
2855 Use ptrdiff_t, not int, for consistency with rest of code.
2856 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2857 (select_window, Fdelete_other_windows_internal)
2858 (window_scroll_pixel_based, window_scroll_line_based)
2859 (Frecenter, Fset_window_configuration):
2860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2861 (Fset_window_hscroll, run_window_configuration_change_hook)
2862 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2863 (Fscroll_other_window, Frecenter):
d311d28c
PE
2864 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2865 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2866 Don't assume fixnum fits in int.
2867 (Fset_window_scroll_bars):
2868 Check that fixnums are in proper range for system types.
2869 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2870 (string_pos, c_string_pos, number_of_chars, init_iterator)
2871 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2872 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2873 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2874 (face_before_or_after_it_pos, handle_invisible_prop)
2875 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2876 (display_prop_intangible_p, string_buffer_position_lim)
2877 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2878 (get_overlay_strings_1, get_overlay_strings)
2879 (iterate_out_of_display_property, forward_to_next_line_start)
2880 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2881 (get_next_display_element, set_iterator_to_next)
2882 (get_visually_first_element, compute_stop_pos_backwards)
2883 (handle_stop_backwards, next_element_from_buffer)
2884 (move_it_in_display_line_to, move_it_in_display_line)
2885 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2886 (add_to_log, message_dolog, message_log_check_duplicate)
2887 (message2, message2_nolog, message3, message3_nolog
2888 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2889 (current_message_1, truncate_echo_area, truncate_message_1)
2890 (set_message, set_message_1, store_mode_line_noprop)
2891 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2892 (text_outside_line_unchanged_p, check_point_in_composition)
2893 (reconsider_clip_changes)
2894 (redisplay_internal, set_cursor_from_row, try_scrolling)
2895 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2896 (redisplay_window, find_last_unchanged_at_beg_row)
2897 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2898 (trailing_whitespace_p, find_row_edges, display_line)
2899 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2900 (display_mode_element, store_mode_line_string)
2901 (pint2str, pint2hrstr, decode_mode_spec)
2902 (display_count_lines, display_string, draw_glyphs)
2903 (x_produce_glyphs, x_insert_glyphs)
2904 (rows_from_pos_range, mouse_face_from_buffer_pos)
2905 (fast_find_string_pos, mouse_face_from_string_pos)
2906 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2908 (safe_call, init_from_display_pos, handle_fontified_prop)
2909 (handle_single_display_spec, load_overlay_strings)
2910 (with_echo_area_buffer, setup_echo_area_for_printing)
2911 (display_echo_area, echo_area_display)
2912 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2913 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2914 (redisplay_window, dump_glyph_row, display_mode_line)
2915 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2916 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2918 (handle_single_display_spec, build_desired_tool_bar_string)
2919 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2920 (get_specified_cursor_type):
2921 Check that fixnums are in proper range for system types.
2922 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2923 (Flookup_image_map):
2924 Don't assume fixnums fit in int.
2925 (compare_overlay_entries):
2926 Avoid mishandling comparisons due to subtraction overflow.
2927 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2928 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2929 (handle_tool_bar_click):
2930 Use int, not unsigned, since we prefer signed and the signedness
2931 doesn't matter here.
2932 (get_next_display_element, next_element_from_display_vector):
2933 Use int, not EMACS_INT, when int is wide enough.
2934 (start_hourglass): Use duration_to_sec_usec to do proper
2935 overflow checking on durations.
2936 * xfaces.c (Fbitmap_spec_p):
2937 Check that fixnums are in proper range for system types.
2938 (compare_fonts_by_sort_order):
2939 Avoid mishandling comparisons due to subtraction overflow.
2940 (Fx_family_fonts, realize_basic_faces):
2941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2942 (Fx_family_fonts):
2943 Don't assume fixnum fits in int.
2944 Use SAFE_ALLOCA_LISP, not alloca.
2945 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2946 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2947 (face_at_buffer_position, face_for_overlay_string)
2948 (face_at_string_position):
2949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2950 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2951 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2952 (Fx_show_tip):
2953 Check that fixnums are in proper range for system types.
2954 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2955 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2957 (Fx_change_window_property): Don't assume fixnums fit in int.
2958 * xfont.c (xfont_chars_supported):
2959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2960 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2961 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2962 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2963 * xml.c (parse_region):
2964 * xrdb.c (magic_file_p):
2965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2966 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2967 (x_get_local_selection, x_reply_selection_request)
2968 (x_handle_selection_request, wait_for_property_change):
2969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2970 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2971 short is wide enough.
2972 (x_send_client_event): Don't assume fixnum fits in int.
2973 * xterm.c (x_x_to_emacs_modifiers):
2974 Don't assume EMACS_INT overflows nicely into int.
2975 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2976 may come from Lisp.
2977 (handle_one_xevent): NATNUMP can eval its arg twice.
2978 (x_connection_closed):
2979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2980 * xterm.h: Adjust decls to match defn changes elsewhere.
2981 (struct scroll_bar): Use struct vectorlike_header
2982 rather than rolling our own approximation.
2983 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2984
c6574eb5
GM
29852012-05-25 Glenn Morris <rgm@gnu.org>
2986
2987 * lisp.mk (lisp): Update for more files being compiled now.
2988
e8d32c7e
SM
29892012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2990
48def666
SM
2991 * lread.c: Remove `read_pure' which makes no difference.
2992 (read_pure): Remove var.
2993 (unreadpure): Remove function.
2994 (readevalloop): Don't call read_list with -1 flag.
2995 (read1, read_vector): Don't test read_pure any more.
2996 (read_list): Simplify.
2997
e8d32c7e
SM
2998 * fileio.c, character.h: Minor style tweaks.
2999
4b2addb7
DA
30002012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3001
3002 * window.h (clip_changed): Remove useless declaration.
3003
584461b2
JB
30042012-05-22 Juanma Barranquero <lekktu@gmail.com>
3005
3006 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3007 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3008
34374650
PE
30092012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3010
3011 Remove src/m/*.
3012 This directory predates autoconf and is no longer needed nowadays.
3013 Move its few remaining bits of functionality to where they're needed.
3014 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3015 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3016 * m/template.h: Remove.
3017 * Makefile.in (M_FILE): Remove. All uses removed.
3018 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3019 * lisp.h (USE_LSB_TAG):
3020 * mem-limits.h (EXCEEDS_LISP_PTR):
3021 Use VAL_MAX, not VALBITS, in #if.
3022 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3023 (EMACS_UINT): Define unconditionally now.
3024 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3025 (BITS_PER_EMACS_INT): New constants, replacing
3026 what used to be in config.h, but not useful in #if.
3027 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3028 define them any more.
3029 (VAL_MAX): New macro.
3030 (VALMASK): Use it.
3031 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3032 BITS_PER_EMACS_INT, in #if.
3033 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3034 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3035 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3036 * s/ms-w32.h (DATA_START):
3037 Move here from removed file m/intel386.h.
3038 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3039 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3040
261cb4bb
PE
30412012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3042
3043 Assume C89 or later.
3044 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3045 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3046 (xrealloc):
3047 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3048 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3049 * textprop.c, tparam.c (NULL): Remove.
3050 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3051 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3052 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3053 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3054 * xterm.c (input_signal_count): Assume volatile works.
3055
ff23cd9f
KB
30562012-05-21 Ken Brown <kbrown@cornell.edu>
3057
3058 * xgselect.c (xg_select): Fix first argument in call to 'select'
3059 (bug#11508).
3060
1b170bc6
KB
30612012-05-20 Ken Brown <kbrown@cornell.edu>
3062
3063 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3064 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3065
b2f4d39f
KB
30662012-05-19 Ken Brown <kbrown@cornell.edu>
3067
3068 * xfns.c (x_in_use): Remove `static' qualifier.
3069 * xterm.h (x_in_use): Declare.
3070 * xgselect.c: Include xterm.h.
3071 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3072 and `display_arg' (bug#9754).
3073
003fdae2
PE
30742012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3075
9232a6d9
PE
3076 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3077
003fdae2
PE
3078 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3079 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3080
784b56e2
EZ
30812012-05-18 Eli Zaretskii <eliz@gnu.org>
3082
3083 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3084
3085 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3086 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3087
3088 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3089 reference to image_cache->refcount.
3090 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3091
a0a79cde
JL
30922012-05-17 Juri Linkov <juri@jurta.org>
3093
3094 * search.c (Fword_search_regexp, Fword_search_backward)
3095 (Fword_search_forward, Fword_search_backward_lax)
3096 (Fword_search_forward_lax): Move functions to isearch.el
3097 (bug#10145, bug#11381).
3098
b0572523
PE
30992012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3100
3101 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3102
9660f5fc
SM
31032012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3104
3105 * lread.c (init_obarray): Declare Qt and Qnil as special.
3106
4374de83
GM
31072012-05-14 Glenn Morris <rgm@gnu.org>
3108
3109 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3110 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3111
dc44c39a
PE
31122012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3113
078c97cb
PE
3114 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3115
dc44c39a
PE
3116 * unexaix.c: Port to more-recent AIX compilers.
3117 (report_error, report_error_1, make_hdr, copy_sym)
3118 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3119 Make arguments const char *, not char *, to avoid violations of C
3120 standard and to fix some AIX warnings reported by Gilles Pion.
3121
e18afed7 31222012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3123
3124 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3125 already have overlays loaded.
3126 (handle_single_display_spec): Before returning without displaying
3127 fringe bitmap, synchronize the bidi iterator with the main display
3128 iterator, by calling iterate_out_of_display_property.
3129 (iterate_out_of_display_property): Detect buffer iteration by
3130 testing that it->string is a Lisp string.
3131 (get_next_display_element): When the current object is exhausted,
3132 and there's something on it->stack, call set_iterator_to_next to
3133 proceed with what's on the stack, instead of returning zero.
3134 (set_iterator_to_next): If called at the end of a Lisp string,
3135 proceed to consider_string_end without incrementing string
3136 position. Don't increment display vector index past the end of
3137 the display vector. (Bug#11417)
c8fb9dc6
EZ
3138 (pos_visible_p): Don't report a position visible when move_it_to
3139 stopped at the last line of window, which happens to be scanned
3140 backwards by the bidi iteration. (Bug#11464)
ac268e67 3141
e18afed7 31422012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3143
3144 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3145 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3146 are on a TTY, and thus unable to display on the fringes.
3147 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3148 so we need to signal to the caller that this is a "replacing"
3149 display spec. This fixes display when the spec is invalid or we
3150 are on a TTY.
3151
e18afed7 31522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3153
3154 * unexaix.c (make_hdr): Fix typo in prototype.
3155 This bug broke the build on AIX. Problem reported by Gilles Pion.
3156
9d0a235a
MA
31572012-05-14 Michael Albinus <michael.albinus@gmx.de>
3158
3159 * keyboard.c (kbd_buffer_get_event): Read special events also in
3160 batch mode. (Bug#11415)
3161
9e6b06ed
GM
31622012-05-12 Glenn Morris <rgm@gnu.org>
3163
3164 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3165
c1a1d7a3
EZ
31662012-05-12 Eli Zaretskii <eliz@gnu.org>
3167
3168 * lisp.mk (lisp): Add newcomment.elc.
3169
3fe7cdc8
GM
31702012-05-12 Glenn Morris <rgm@gnu.org>
3171
3172 * Makefile.in (MKDIR_P): New, set by configure.
3173 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3174
53f7d2c0
PE
31752012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 Remove unused function hourglass_started.
3178 * dispextern.h (hourglass_started):
3179 * w32fns.c (hourglass_started):
3180 * xdisp.c (hourglass_started): Remove.
3181
75aafb17
JB
31822012-05-10 Juanma Barranquero <lekktu@gmail.com>
3183
3184 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3185 Update dependencies.
3186
12959e8e
PE
31872012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3188
97107e2e
PE
3189 * xgselect.c (xg_select): Put maxfds+1 into a var.
3190 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3191
12959e8e
PE
3192 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3193
836d29b3
DA
31942012-05-10 Dave Abrahams <dave@boostpro.com>
3195
3196 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3197 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3198
5cb67954
MA
31992012-05-09 Michael Albinus <michael.albinus@gmx.de>
3200
3201 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3202 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3203 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3204 Initialize xd_registered_buses.
3205
3478ec45
PE
32062012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3207
b263a6b0
PE
3208 Untag more efficiently if USE_LSB_TAG.
3209 This is based on a proposal by YAMAMOTO Mitsuharu in
3210 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3211 For an admittedly artificial (nth 8000 longlist) benchmark on
3212 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3213 Emacs's overall text size by 1%.
3214 * lisp.h (XUNTAG): New macro.
3215 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3216 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3217 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3218 * eval.c (Fautoload):
3219 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3220 * frame.h (XFRAME): Use XUNTAG.
3221
3478ec45
PE
3222 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3223 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3224 Remove unportable assumptions about print widths of types like
3225 dbus_uint32_t.
3226 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3227 intptr_t when converting between pointer and integer, to avoid GCC
3228 warnings about wrong width.
3229
666b903b 32302012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3231
3232 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3233 stack for each reader_thread, instead of defaulting to 8MB
3234 determined by the linker. This avoids failures in creating
3235 subprocesses on Windows 7, see the discussion in this thread:
3236 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3237
b120cc17
JC
32382012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3239
3240 Fix up display of the *Minibuf-0* buffer in the mini window.
3241 * keyboard.c (read_char): Don't clear the echo area if there's no
3242 message to clear.
3243 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3244 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3245
9a4b36f8
MA
32462012-05-07 Michael Albinus <michael.albinus@gmx.de>
3247
3248 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3249 batch mode.
3250
e5f9458f
CY
32512012-05-06 Chong Yidong <cyd@gnu.org>
3252
3253 * lisp.mk (lisp): Update.
3254
eceeb5fc 32552012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3256
3257 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3258
71873e2b
SM
32592012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3260
3261 * data.c (PUT_ERROR): New macro.
3262 (syms_of_data): Use it. Add new error type `user-error'.
3263 * undo.c (user_error): New function.
3264 (Fprimitive_undo): Use it.
3265 * print.c (print_error_message): Adjust print style for `user-error'.
3266 * keyboard.c (user_error): New function.
3267 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3268
ab0fa4e4
PE
32692012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3270
3271 Do not limit current-time-string to years 1000..9999.
3272 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3273 (Fcurrent_time_string): Support any year that is supported by the
3274 underlying localtime representation. Don't use asctime, as it
3275 has undefined behavior for years outside the range -999..9999.
3276
7ed806a7
PE
32772012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3278
3279 Fix race conditions involving setenv, gmtime, localtime, asctime.
3280 Without this fix, interrupts could mess up code that uses these
3281 nonreentrant functions, since setting TZ invalidates existing
3282 tm_zone or tzname values, and since most of these functions return
3283 pointers to static storage.
3284 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3285 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3286 Grow the critical sections to include not just invoking
3287 localtime/gmtime, but also accessing these functions' results
3288 including their tm_zone values if any, and any related TZ setting.
3289 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3290 so that the struct tm is saved in the critical section.
3291 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3292 motivated by the fact that memory allocation needs to be outside
3293 the critical section.
3294
0c16dfed
DA
32952012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3296
3297 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3298 with RESET_INTERVAL.
3299
3300 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3301 Remove duplicated buffer name initialization.
3302
3f83ace8
JM
33032012-05-02 Jim Meyering <jim@meyering.net>
3304
3305 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3306
c7b8541e
JM
3307 * xfns.c (x_window): Use xstrdup (Bug#11375).
3308
90207a15 33092012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3310
3311 * xdisp.c (pos_visible_p): If already at a newline from the
3312 display string before the 'while' loop, don't walk back the glyphs
3313 from it3.glyph_row. Solves assertion violation when the display
3314 string begins with a newline (egg.el). (Bug#11367)
3315
b593d6a9
AH
33162012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3317
3318 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3319 Move to simple.el.
3320
4737362e
GM
33212012-05-01 Glenn Morris <rgm@gnu.org>
3322
99cf43f9
GM
3323 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3324 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3325 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3326 All were removed before 23.1.
3327
9311dcff
GM
3328 * dispnew.c: Remove HAVE_LIBNCURSES test;
3329 it is always true on relevant platforms.
3330
4d5c6349
GM
3331 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3332 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3333
4737362e
GM
3334 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3335
74dd3a6b
AS
33362012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3337
3338 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3339 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3340 Remove.
3341
13c379ee
PE
33422012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3343
3344 Do not avoid creating empty evaporating overlays (Bug#9642).
3345 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3346 That is, do not delete an evaporating overlay if it becomes
3347 empty after its bounds are adjusted to fit within its buffer.
3348 This fix caused other problems, and I'm reverting it until we get
3349 to the bottom of them.
3350
a8e7d6d7 33512012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3352
3353 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3354
a8e7d6d7 33552012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3356
3357 * xdisp.c (pos_visible_p): If the window start position is beyond
3358 ZV, start the display from buffer beginning. Prevents assertion
3359 violation in init_iterator when the minibuffer window is scrolled
3360 via the scroll bar.
3361
3362 * window.c (window_scroll_pixel_based): Likewise.
3363
a8e7d6d7 33642012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3365
3366 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3367
a8e7d6d7 33682012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3369
3370 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3371 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3372
a8e7d6d7 33732012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3374
b593d6a9
AH
3375 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3376 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3377
1c6900d9
EZ
33782012-04-26 Eli Zaretskii <eliz@gnu.org>
3379
4c3fa1d9
EZ
3380 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3381 display element, check also the underlying string or buffer
3382 character. (Bug#11341)
3383
1c6900d9
EZ
3384 * w32menu.c: Include w32heap.h.
3385 (add_menu_item): If the call to AppendMenuW (via
3386 unicode_append_menu) fails, disable Unicode menus only if we are
3387 running on Windows 9X/Me.
3388
42bf8205
AS
33892012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3390
3391 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3392 (xgetint): Add missing shift for LSB tags.
3393
b1bac16e
MR
33942012-04-24 Martin Rudalics <rudalics@gmx.at>
3395
3396 * keyboard.c (read_char): Don't wipe echo area for select window
3397 events: These might get delayed via `mouse-autoselect-window'
3398 (Bug#11304).
3399
d69621cc
JB
34002012-04-24 Juanma Barranquero <lekktu@gmail.com>
3401
3402 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3403 manipulation of :loaded-from data.
3404
02fd101b
JB
34052012-04-23 Juanma Barranquero <lekktu@gmail.com>
3406
3407 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3408 now a cons (bug#11311).
3409
888bec30
PE
34102012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3411
89a438bd
PE
3412 Do not create empty overlays with the evaporate property (Bug#9642).
3413 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3414 if it becomes empty after its bounds are adjusted to fit within
3415 its buffer. Without this fix, in a nonempty buffer (let ((o
3416 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3417 yields an empty overlay that has the evaporate property, which is
3418 not supposed to happen.
3419
1068fe4d
PE
3420 Fix minor GTK3 problems found by static checking.
3421 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3422 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3423 (struct _EmacsFixedClass, emacs_fixed_get_type):
3424 Move decls here from emacsgtkfixed.h, since they needn't be public.
3425 (emacs_fixed_get_type): Now static.
3426 (emacs_fixed_class_init): Omit unused local.
3427 (emacs_fixed_child_type): Remove; unused.
3428 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3429 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3430 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3431 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3432 (EMACS_FIXED_GET_CLASS): Remove; unused.
3433 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3434
888bec30
PE
3435 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3436 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3437
de85e130
PE
34382012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3439
d0baac98 3440 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3441 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3442 (__malloc_size_t, __malloc_ptrdiff_t):
3443 Remove. All uses removed, replaced by the definiens if needed,
3444 since we can assume C89 or better now.
3445 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3446 (protect_malloc_state, align, get_contiguous_space)
3447 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3448 (malloc_atfork_handler_child, malloc_enable_thread)
3449 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3450 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3451 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3452 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3453 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3454 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3455 Define using prototypes, not old style.
3456 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3457 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3458 (align): Don't assume that signed integer overflow wraps around.
3459 Omit unused local var.
3460 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3461 (_free_internal_nolock, memalign, mallochook, reallochook):
3462 Omit no-longer-needed casts.
3463 (valloc): Use getpagesize, not __getpagesize.
3464 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3465 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3466
de85e130
PE
3467 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3468
dcbf5805
MA
34692012-04-22 Michael Albinus <michael.albinus@gmx.de>
3470
3471 Move functions from C to Lisp. Make non-blocking method calls
3472 the default. Implement further D-Bus standard interfaces.
3473
3474 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3475 (QCdbus_request_name_allow_replacement)
3476 (QCdbus_request_name_replace_existing)
3477 (QCdbus_request_name_do_not_queue)
3478 (QCdbus_request_name_reply_primary_owner)
3479 (QCdbus_request_name_reply_in_queue)
3480 (QCdbus_request_name_reply_exists)
3481 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3482 (QCdbus_registered_serial, QCdbus_registered_method)
3483 (QCdbus_registered_signal): New Lisp objects.
3484 (XD_DEBUG_MESSAGE): Use sizeof.
3485 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3486 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3487 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3488 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3489 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3490 (xd_signature, xd_append_arg): Allow float for integer types.
3491 (xd_get_connection_references): New function.
b593d6a9
AH
3492 (xd_get_connection_address): Rename from xd_initialize.
3493 Return cached address.
dcbf5805
MA
3494 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3495 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3496 level.
3497 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3498 Return number of refcounts.
dcbf5805
MA
3499 (Fdbus_get_unique_name): Make stronger parameter check.
3500 (Fdbus_message_internal): New defun.
3501 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3502 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3503 (Fdbus_send_signal, Fdbus_register_service)
3504 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3505 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3506 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3507 (Vdbus_compiled_version, Vdbus_runtime_version)
3508 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3509 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3510 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3511 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3512 Adapt docstring.
dcbf5805 3513
52828e02
PE
35142012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3515
da05bc4c
PE
3516 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3517 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3518 Do not assume ptrdiff_t is the same width as 'int'.
3519
52828e02
PE
3520 * alloc.c: Handle unusual debugging option combinations.
3521 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3522 since the two debugging options are incompatible.
3523 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3524 is defined.
3525 (mem_init, mem_insert, mem_insert_fixup):
3526 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3527 (NEED_MEM_INSERT): Remove; no longer needed.
3528
f01769f9
LL
35292012-04-22 Leo Liu <sdl.web@gmail.com>
3530
3531 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3532
5790543d
PE
35332012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3534
3535 * sysdep.c [__FreeBSD__]: Minor cleanups.
3536 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3537 Use Emacs indenting style more consistently. Avoid some casts.
3538 Use 'double' consistently rather than mixing 'float' and 'double'.
3539
b91b7e4d
EW
35402012-04-21 Eduard Wiebe <usenet@pusto.de>
3541
b593d6a9
AH
3542 * sysdep.c (list_system_processes, system_process_attributes):
3543 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3544
6114eb15
AS
35452012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3546
3547 * lisp.mk (lisp): Update.
3548
2f38dff7
PE
35492012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3552 It is never used otherwise.
3553
4ae29f89
SM
35542012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3555
3556 * print.c (print_preprocess): Only check print_depth if print-circle
3557 is nil.
3558 (print_object): Check for cycles even when print-circle is nil and
3559 print-gensym is t, but only check print_depth if print-circle is nil.
3560
f30d612a
CY
35612012-04-20 Chong Yidong <cyd@gnu.org>
3562
3563 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3564 set the status to "failed" and ensure that sentinel is run.
3565
c07a4c0b 35662012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3567
3568 * process.c (Fset_process_inherit_coding_system_flag)
3569 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3570 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3571
c07a4c0b 35722012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3573
3574 * xdisp.c (string_buffer_position_lim): Limit starting position to
3575 BEGV.
3576 (set_cursor_from_row): If called for a mode-line or header-line
3577 row, return zero immediately.
3578 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3579 farther than the first row after the header line, if any.
3580 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3581 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3582
c07a4c0b 35832012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3584
4ae29f89
SM
3585 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3586 (bug#11238).
ad3a2b41 3587
c07a4c0b 35882012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 35892012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3590
3591 configure: new option --enable-gcc-warnings (Bug#11207)
3592 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3593 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3594 (ALL_CFLAGS): Use new macros rather than old.
3595 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3596 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3597 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3598 -Wunused-result, -Wunused-variable. This should go away once
3599 the Emacs and Gnulib regex code is merged.
3600 (xmalloc, xrealloc): Now static.
3601
aba027e8
PE
36022012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 * dired.c (Fsystem_groups): Remove unused local.
3605
e5a36063
GM
36062012-04-17 Glenn Morris <rgm@gnu.org>
3607
3608 * dired.c (Fsystem_users): Doc fix.
3609
316411f0
DA
36102012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3611
3612 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3613 (syms_of_dired): Add them.
3614
9426aba4
PE
36152012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3616
b62a57be
PE
3617 Fix minor alloc.c problems found by static checking.
3618 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3619 New extern decls, to avoid calling undeclared functions.
3620 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3621 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3622 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3623 (NEED_MEM_INSERT): New macro.
3624 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3625 Remove one incorrect comment and fix another.
b62a57be 3626
3539f31f
PE
3627 Fix minor ralloc.c problems found by static checking.
3628 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3629 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3630 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3631 (r_alloc_sbrk): Now static.
3632
a041960a
PE
3633 Improve ralloc.c interface checking.
3634 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3635 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3636 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3637 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3638 [REL_ALLOC]: ... to here, to check interface.
3639 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3640 Remove decls. This fixes an "It stinks!".
3641
9426aba4
PE
3642 * alloc.c (which_symbols): Fix alignment issue / type clash.
3643
d55c12ed
AS
36442012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3645
3646 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3647 (struct Lisp_Misc_Any): Likewise.
3648 (struct Lisp_Free): Likewise.
3649 * alloc.c (union aligned_Lisp_Symbol): Define.
3650 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3651 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3652 (union aligned_Lisp_Misc): Define.
3653 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3654 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3655 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3656
b948ce8b
PE
36572012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3658
3659 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3660 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3661 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3662 * s/netbsd.h, s/sol2-6.h:
3663 Remove definition of GC_MARK_STACK, since the default now works.
3664 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3665 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3666 no longer the default.
3667 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3668
35dc09a1 36692012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3670
35dc09a1
GM
3671 * lread.c (lisp_file_lexically_bound_p):
3672 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3673
35dc09a1
GM
36742012-04-14 Eli Zaretskii <eliz@gnu.org>
3675
3676 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3677 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3678
36792012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3680
3681 * nsterm.m (constrainFrameRect): Always constrain when there is only
3682 one screen (Bug#10962).
3683
bcd86815
KB
36842012-04-13 Ken Brown <kbrown@cornell.edu>
3685
3686 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3687
c25df26e
RT
36882012-04-13 Reuben Thomas <rrt@sc3d.org>
3689
3690 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3691
0fc59f1e
DC
36922012-04-11 Daniel Colascione <dancol@dancol.org>
3693
3694 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3695 against is gone. It's better to use vfork now so that when Cygwin
3696 gains a new, working vfork, we use it automatically (bug#10398).
3697
de8c03dc
SM
36982012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3699
3700 * window.c (save_window_save): Obey window-point-insertion-type.
3701
2f097256
GM
37022012-04-11 Glenn Morris <rgm@gnu.org>
3703
3704 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3705
453b951e
SM
37062012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3707
3708 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3709
75f1671a 37102012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3711
3712 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3713 (force_quit_count): New var.
3714 (handle_interrupt): Use it.
3715
2a8ce227
JB
37162012-04-10 Juanma Barranquero <lekktu@gmail.com>
3717
3718 * w32.c (w32_delayed_load): Record the full path of the library
3719 being loaded (bug#10424).
3720
935396c0
GM
37212012-04-09 Glenn Morris <rgm@gnu.org>
3722
05920a43
GM
3723 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3724 not just in the obarray, before snarfing them. (Bug#11036)
3725
935396c0
GM
3726 * Makefile.in ($(leimdir)/leim-list.el):
3727 Pass EMACS rather than BUILT_EMACS.
3728
a18ecafa
TZ
37292012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3730
3731 * process.c (make_process):
3732 * process.h: Add integer `gnutls_handshakes_tried' member to
3733 process struct.
3734
6bbef4e5
JC
3735 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3736 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3737
3738 * gnutls.c (gnutls_log_function2i): Convenience log function.
3739 (emacs_gnutls_read): Use new log functions,
3740 `gnutls_handshakes_tried' process member, and
3741 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3742 attempts per process (connection).
3743
b4d3bc10
CY
37442012-04-09 Chong Yidong <cyd@gnu.org>
3745
3746 * eval.c (Fuser_variable_p, user_variable_p_eh)
3747 (lisp_indirect_variable): Functions deleted.
3748 (Fdefvar): Caller changed.
3749
3750 * callint.c (Finteractive, Fcall_interactively):
3751 * minibuf.c (Fread_variable): Callers changed.
3752
70f4d973
EZ
37532012-04-09 Eli Zaretskii <eliz@gnu.org>
3754
3755 * xdisp.c (set_cursor_from_row): If the display string appears in
3756 the buffer at position that is closer to point than the position
3757 after the display string, display the cursor on the first glyph of
3758 the display string. Fixes cursor display when a 'display' text
3759 property immediately follows invisible text. (Bug#11094)
3760
cb3c2e3e
PE
37612012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3762
3763 composite.c: use 'double' consistently
3764 * composite.c (get_composition_id): Use 'double' consistently
3765 instead of converting 'float' to 'double' and vice versa; this is
3766 easier to understand and avoids a GCC warning.
3767
fd06db5d
GM
37682012-04-09 Glenn Morris <rgm@gnu.org>
3769
50fe702a
GM
3770 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3771 preparation for dumping it with emacs. (Bug#4789)
3772 (leimdir): New variable.
3773 ($(leimdir)/leim-list.el): New rule.
3774 (emacs$(EXEEXT)): Depend on leim-list.el.
3775
fd06db5d
GM
3776 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3777 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3778 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3779
55c131ee
AS
37802012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3781
3782 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3783 proper alignment.
3784
9209588f
JB
37852012-04-07 Juanma Barranquero <lekktu@gmail.com>
3786
3787 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3788 Remove unused local variable.
3789
e3fb2efb
PE
37902012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3791
3792 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3793 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3794 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3795 objects, as mark_maybe_pointer will catch them otherwise.
3796 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3797 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3798
b5385551
PE
37992012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3800
3801 Fix typo that broke non-Windows builds.
3802 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3803
9078ead6
EZ
38042012-04-07 Eli Zaretskii <eliz@gnu.org>
3805
3806 Support building on MS-Windows with libxml2.
3807
3808 * makefile.w32-in (OBJ2): Add xml.$(O).
3809 (GLOBAL_SOURCES): Add xml.c.
3810 ($(BLD)/xml.$(O)): New dependency list.
3811
3812 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3813 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3814 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3815 [!WINDOWSNT]: New macros.
3816 (init_libxml2_functions, libxml2_loaded_p): New functions.
3817 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3818 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3819 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3820 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3821 linked in).
6bbef4e5
JC
3822 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3823 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3824 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3825
3826 * emacs.c: Don't include libxml/parser.h.
3827 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3828 xmlCleanupParser directly.
3829
3830 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3831
3811fdf3
EZ
38322012-04-07 Eli Zaretskii <eliz@gnu.org>
3833
3834 * indent.c (Fvertical_motion): If there is a display string at
3835 point, use it.vpos to compute how many lines to backtrack after
3836 move_it_to point. (Bug#11133)
3837
2f8e16b2
EZ
38382012-04-06 Eli Zaretskii <eliz@gnu.org>
3839
3840 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3841 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3842 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3843 macros related to unification of CJK characters. For the details,
3844 see the discussion following the message here:
3845 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3846
3d439cd1
CY
38472012-04-04 Chong Yidong <cyd@gnu.org>
3848
3849 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3850
8bc53d00
EZ
38512012-04-01 Eli Zaretskii <eliz@gnu.org>
3852
3853 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3854 instead of alloca. (Bug#11138)
3855
3b0512a3
AS
38562012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3857
3858 * w32menu.c (is_simple_dialog): Properly check lisp types.
3859 (Bug#11141)
3860
8427ddd2
EZ
38612012-03-31 Eli Zaretskii <eliz@gnu.org>
3862
979022ef
EZ
3863 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3864 position we get to after a call to move_it_to fails the
3865 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3866 only if we wind up in a string from display property. (Bug#11063)
3867
a6b1c7cc
EZ
3868 * window.c (Fdelete_other_windows_internal): Invalidate the row
3869 and column information about mouse highlight, so that redisplay
3870 restores it after reallocating the glyph matrices. (Bug#7464)
3871
8427ddd2
EZ
3872 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3873 string comes from a `display' text property, use the buffer
3874 position of that property as if we actually saw that position in
3875 the row's glyphs.
697ba24b
EZ
3876 (move_it_by_lines): Remove the assertion that
3877 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3878 violated when there's a before-string at the beginning of a line.
3879 (Bug#11063)
8427ddd2 3880
65a0a738
EZ
38812012-03-30 Eli Zaretskii <eliz@gnu.org>
3882
3883 * xdisp.c (append_space_for_newline): If the default face was
3884 remapped, use the remapped face for the appended newline.
3885 (extend_face_to_end_of_line): Use the remapped default face for
3886 extending the face to the end of the line.
3887 (display_line): Call extend_face_to_end_of_line when the default
3888 face was remapped. (Bug#11068)
3889
581355cc
EZ
38902012-03-29 Eli Zaretskii <eliz@gnu.org>
3891
3892 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3893
e8fc049f
SM
38942012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3895
3896 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3897
4fb9a543
GM
38982012-03-27 Glenn Morris <rgm@gnu.org>
3899
3900 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3901 Doc fixes.
3902
679910f1
KH
39032012-03-26 Kenichi Handa <handa@m17n.org>
3904
3905 * dispextern.h (struct glyph): Fix previous change. Change the
3906 bit length of glyphless.ch to 25 (Bug#11082).
3907
90d49b7f
CY
39082012-03-26 Chong Yidong <cyd@gnu.org>
3909
3910 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3911 (command_loop_1): Use it; inhibit selection update for
3912 handle-select-window too (Bug#8996).
3913
f514f6f0
FP
39142012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3915
e8fc049f 3916 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3917
bf43fa51
KH
39182012-03-25 Kenichi Handa <handa@m17n.org>
3919
3920 * dispextern.h (struct glyph): Change the bit length of
3921 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3922
8a0c01dd
EZ
39232012-03-24 Eli Zaretskii <eliz@gnu.org>
3924
3925 * s/ms-w32.h (tzname): Include time.h before redirecting to
3926 _tzname. Fixes the MSVC build. (Bug#9960)
3927
7d1c3a76
AS
39282012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3929
8ed79523
AS
3930 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3931 characters.
3932
7d1c3a76
AS
3933 * xterm.c (XTread_socket): Only modify handling_signal if
3934 !SYNC_INPUT. (Bug#11080)
3935
e99a9b8b
EZ
39362012-03-23 Eli Zaretskii <eliz@gnu.org>
3937
3938 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3939 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3940 when fetching a multibyte character consumes more bytes than
3941 CHAR_BYTES returns, due to unification of CJK characters in
3942 string_char. (Bug#11073)
3943
5063c0e1
TN
39442012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3945
3946 * process.c (wait_reading_process_output): Handle pty disconnect
3947 by refraining from sending oneself a SIGCHLD (bug#10933).
3948
9f851fbd
CY
39492012-03-22 Chong Yidong <cyd@gnu.org>
3950
3951 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3952
5063c0e1 3953 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3954 Mark string as coming from a prefix property.
3955 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3956 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3957
fb5b8aca
CY
39582012-03-21 Chong Yidong <cyd@gnu.org>
3959
3960 * xfaces.c (Vface_remapping_alist): Doc fix.
3961
62356a1b
EZ
39622012-03-20 Eli Zaretskii <eliz@gnu.org>
3963
3964 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3965 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3966 Doc fixes.
62356a1b 3967
025de85b
CY
39682012-03-20 Chong Yidong <cyd@gnu.org>
3969
3970 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3971 to reflect default non-nil value of redisplay-dont-pause.
3972
4827f94e
KH
39732012-03-19 Kenichi Handa <handa@m17n.org>
3974
3975 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3976 it fit in a valid range (Bug#11003).
3977
e50a24a2
EZ
39782012-03-18 Eli Zaretskii <eliz@gnu.org>
3979
3980 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3981 that is not from display property, accept the row as a "cursor
3982 row" if one of the string's character has a non-nil `cursor'
3983 property. Fixes cursor positioning when there are newlines in
3984 overlay strings, e.g. in icomplete.el. (Bug#11035)
3985
9af5ed87
PE
39862012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3989
d1f55f16
CY
39902012-03-12 Chong Yidong <cyd@gnu.org>
3991
3992 * eval.c (inhibit_lisp_code): Rename from
3993 inhibit_window_configuration_change_hook; move from window.c.
3994
3995 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3996 * window.c (run_window_configuration_change_hook)
3997 (syms_of_window): Callers changed.
3998
66c5eebd
CY
39992012-03-11 Chong Yidong <cyd@gnu.org>
4000
413df973
CY
4001 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4002
66c5eebd
CY
4003 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4004
1de11f56
CY
40052012-03-10 Chong Yidong <cyd@gnu.org>
4006
4007 * frame.c (other_visible_frames): Don't assume the selected frame
4008 is visible (Bug#10955).
4009
cae07000
SM
40102012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4011
4012 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4013
89c94350
JD
40142012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4015
4016 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4017 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4018 zero (Bug#10954).
4019
999dd333
GM
40202012-03-03 Glenn Morris <rgm@gnu.org>
4021
01a6dcc8 4022 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4023
de0100f2
EZ
40242012-03-02 Eli Zaretskii <eliz@gnu.org>
4025
4026 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4027 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4028 (redisplay_window, next_element_from_string): Fix typos in
4029 comments.
3e441275
EZ
4030 (redisplay_window): Pass to move_it_vertically the margin in
4031 pixels, not in screen lines.
de0100f2 4032
96a72ee9
GM
40332012-03-02 Glenn Morris <rgm@gnu.org>
4034
4035 * buffer.c (buffer-list-update-hook): Doc fix.
4036
312508d7
EZ
40372012-02-29 Eli Zaretskii <eliz@gnu.org>
4038
4039 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4040 push_it before setting up the iterator for the first overlay
4041 string, even if we have an empty string loaded.
4042 (next_overlay_string): If there's an empty string on the iterator
4043 stack, pop the stack. (Bug#10903)
4044
27f3c637
PE
40452012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4046
4047 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4048 Suggested by Stefan Monnier in
4049 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4050 * alloc.c (widen_to_Lisp_Object): New static function.
4051 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4052 and widening them to Lisp_Objects. This would work even if
4053 USE_LSB_TAG is defined and wide integers are used, which might
4054 happen in a future version of Emacs.
4055
3c9dfce6
CY
40562012-02-25 Chong Yidong <cyd@gnu.org>
4057
fa74b241
CY
4058 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4059 Doc fix.
4060
3c9dfce6
CY
4061 * xselect.c (Fx_selection_exists_p): Doc fix.
4062 (x_clipboard_manager_save_all): Print an informative message
4063 before saving to clipboard manager.
4064
9486df08
CY
40652012-02-24 Chong Yidong <cyd@gnu.org>
4066
4067 * keyboard.c (process_special_events): Handle all X selection
4068 requests in kbd_buffer, not just the next one (Bug#8869).
4069
f01d3321
CY
40702012-02-23 Chong Yidong <cyd@gnu.org>
4071
4072 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4073 call when setting menu-bar-lines and tool-bar-lines parameters.
4074 (unwind_create_frame_1): New helper function.
4075
4076 * window.c (inhibit_window_configuration_change_hook): New var.
4077 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4078 (syms_of_window): Initialize it.
f01d3321 4079
86b847b6
CY
40802012-02-22 Chong Yidong <cyd@gnu.org>
4081
4082 * xterm.c (x_draw_image_relief): Add missing type check for
4083 Vtool_bar_button_margin (Bug#10743).
4084
a59225b1
CY
40852012-02-21 Chong Yidong <cyd@gnu.org>
4086
4087 * fileio.c (Vfile_name_handler_alist): Doc fix.
4088
4089 * buffer.c (Fget_file_buffer): Protect against invalid file
4090 handler return value.
4091
310f5bd4
PE
40922012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4093
cb3a28cc
PE
4094 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4095 when computing $valmask.
4096
310f5bd4
PE
4097 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4098 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4099 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4100 It's useless in that case, and it can cause problems on hosts
4101 that allocate halves of EMACS_INT values separately.
4102 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4103 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4104 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4105 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4106 it avoids undefined behavior on hosts where shifting right by more
4107 than the word width has undefined behavior.
4108
2375c96a
CY
41092012-02-19 Chong Yidong <cyd@gnu.org>
4110
4111 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4112 (Funhandled_file_name_directory, Ffile_name_as_directory)
4113 (Fdirectory_file_name, Fexpand_file_name)
4114 (Fsubstitute_in_file_name): Protect against invalid file handler
4115 return values (Bug#10845).
4116
3eb49e71
EZ
41172012-02-18 Eli Zaretskii <eliz@gnu.org>
4118
4119 * .gdbinit (pitx): Fix incorrect references to fields of the
4120 iterator stack.
4121
7b926f3f
CY
41222012-02-17 Chong Yidong <cyd@gnu.org>
4123
4124 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4125
11273115
PE
41262012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4127
4128 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4129 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4130
c3a70e2b
CY
41312012-02-15 Chong Yidong <cyd@gnu.org>
4132
4133 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4134 marked as special. Also, starting docstrings with * is obsolete.
4135
0ca43699
AS
41362012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4137
4138 * gnutls.c (emacs_gnutls_write): Fix last change.
4139
2e8f3c56
LI
41402012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4141
4142 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4143 send_process.
4144
af70074f
SM
41452012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4146
4147 * keymap.c (Fsingle_key_description): Handle char ranges.
4148
95986d52
CY
41492012-02-12 Chong Yidong <cyd@gnu.org>
4150
afd83bd1
CY
4151 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4152 as that creates a dangerous corner case.
4153
95986d52
CY
4154 * window.c (Fdelete_window_internal): Invalidate the mouse
4155 highlight (Bug#9904).
4156
bd7da63e
GM
41572012-02-12 Glenn Morris <rgm@gnu.org>
4158
4159 * xselect.c (Fx_own_selection_internal)
4160 (Fx_get_selection_internal, Fx_disown_selection_internal)
4161 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4162 * nsselect.m (Fx_own_selection_internal)
4163 (Fx_disown_selection_internal, Fx_selection_exists_p)
4164 (Fx_selection_owner_p, Fx_get_selection_internal):
4165 Sync docs and argument specs with the xselect.c versions.
4166
77abcbc2
LI
41672012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4168
4169 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4170
90b671e2
EZ
41712012-02-11 Eli Zaretskii <eliz@gnu.org>
4172
1c0ca0b7
EZ
4173 * w32select.c (Fx_selection_exists_p): Sync doc string and
4174 argument list with xselect.c. (Bug#10783)
4175
4176 * w16select.c (Fx_selection_exists_p): Sync doc string and
4177 argument list with xselect.c. (Bug#10783)
90b671e2 4178
49241268
GM
41792012-02-10 Glenn Morris <rgm@gnu.org>
4180
4181 * fns.c (Fsecure_hash): Doc fix.
4182
f998bbe7 41832012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4184
4185 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4186
0992bd9c
CY
41872012-02-07 Chong Yidong <cyd@gnu.org>
4188
4189 * buffer.c (Fbuffer_local_variables)
4190 (buffer_lisp_local_variables): Handle unbound vars correctly;
4191 don't let Qunbound leak into Lisp.
4192
af008560
GM
41932012-02-07 Glenn Morris <rgm@gnu.org>
4194
dd605cc4
GM
4195 * image.c (Fimagemagick_types): Doc fix.
4196
af008560
GM
4197 * image.c (imagemagick-render-type): Change it from a lisp object
4198 to an integer. Move the doc here from the lisp manual.
4199 Treat all values not equal to 0 the same.
4200
1449fa1d
CY
42012012-02-06 Chong Yidong <cyd@gnu.org>
4202
4203 * doc.c (store_function_docstring): Avoid applying docstring of
4204 alias to base function (Bug#2603).
4205
3723ec07
AS
42062012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4207
4208 * .gdbinit (pp1, pv1): Remove redundant defines.
4209 (pr): Use pp.
4210
79c1cc1e
CY
42112012-02-04 Chong Yidong <cyd@gnu.org>
4212
4213 * nsterm.m: Declare a global (Bug#10694).
4214
d7f29f8e
EZ
42152012-02-04 Eli Zaretskii <eliz@gnu.org>
4216
cae07000
SM
4217 * w32.c (get_emacs_configuration_options):
4218 Include --enable-checking, if specified, in the return value.
d7f29f8e 4219
3b95a6f9
MR
42202012-02-04 Martin Rudalics <rudalics@gmx.at>
4221
4222 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4223 after rounding frame sizes. (Bug#9723)
4224
d6fa96a6
EZ
42252012-02-04 Eli Zaretskii <eliz@gnu.org>
4226
4227 * keyboard.c (adjust_point_for_property): Don't position point
4228 before BEGV. (Bug#10696)
4229
df0b2940
PE
42302012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4231
4232 Handle overflow when computing char display width (Bug#9496).
4233 * character.c (char_width): Return EMACS_INT, not int.
4234 (char_width, c_string_width): Check for overflow when
4235 computing the width; this is possible now that individual
4236 characters can have unbounded width. Problem introduced
4237 by merge from Emacs 23 on 2012-01-19.
4238
6bee44d6
MA
42392012-02-02 Michael Albinus <michael.albinus@gmx.de>
4240
4241 * dbusbind.c (Fdbus_register_method): Mention the return value
4242 :ignore in the docstring.
4243
44f92739
GM
42442012-02-02 Glenn Morris <rgm@gnu.org>
4245
1b9f60cc
GM
4246 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4247
44f92739
GM
4248 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4249 Unconditionally set to t. (Bug#10673)
4250 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4251 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4252 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4253
c5d3843c
KH
42542012-02-02 Kenichi Handa <handa@m17n.org>
4255
4256 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4257 0, do not call append_composite_glyph.
4258
159462d4 42592012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4260
4261 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4262 NULL (Bug#6988).
4263 (x_produce_glyphs): If the component of a composition is a null
4264 string, set it->pixel_width to 1 to avoid zero-width glyph.
4265
78cef877
EZ
42662012-02-01 Eli Zaretskii <eliz@gnu.org>
4267
4268 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4269 first 2 arguments are identical. This makes inserting large
4270 output from a subprocess an order of magnitude faster on
4271 MS-Windows, where all sbrk'ed memory is always contiguous.
4272
97897668
GM
42732012-01-31 Glenn Morris <rgm@gnu.org>
4274
4275 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4276 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4277 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4278
31fd3586
GM
42792012-01-29 Glenn Morris <rgm@gnu.org>
4280
4281 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4282
0e24a8b2
CY
42832012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4284
4285 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4286
cc0adcb0
CY
42872012-01-28 Chong Yidong <cyd@gnu.org>
4288
4289 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4290
acc28cb9
CY
42912012-01-26 Chong Yidong <cyd@gnu.org>
4292
9c69cfb7
CY
4293 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4294
acc28cb9
CY
4295 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4296 repeat counts (Bug#10507).
4297
48da7392
GM
42982012-01-26 Glenn Morris <rgm@gnu.org>
4299
4300 * lread.c (syms_of_lread): Doc fix.
4301
14af5f7f
CY
43022012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4303
4304 * coding.c (encode_designation_at_bol): Change return value to
4305 EMACS_INT.
4306
0b21c100
CY
43072012-01-25 Chong Yidong <cyd@gnu.org>
4308
4309 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4310
3c2907f7
CY
43112012-01-21 Chong Yidong <cyd@gnu.org>
4312
4313 * floatfns.c (Fcopysign): Make the second argument non-optional,
4314 since nil is not allowed anyway.
4315
959ad23f
AS
43162012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4317
4318 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4319 (send_process): Likewise.
4320
34a02f46
MR
43212012-01-19 Martin Rudalics <rudalics@gmx.at>
4322
4323 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4324 (Vwindow_persistent_parameters): Do not use Qstate.
4325 Rewrite doc-strings.
34a02f46 4326
1259009a 43272012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4328
4329 * character.c (char_width): New function.
70d4fdf6
GM
4330 (Fchar_width, c_string_width, lisp_string_width):
4331 Use char_width (Bug#9496).
25ed9e61 4332
6a6ee00d
MR
43332012-01-16 Martin Rudalics <rudalics@gmx.at>
4334
4335 * window.c (Vwindow_persistent_parameters): New variable.
4336 (Fset_window_configuration, save_window_save): Handle persistent
4337 window parameters.
4338
c85efaf7
EZ
43392012-01-14 Eli Zaretskii <eliz@gnu.org>
4340
4341 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4342 thrashing the stack of the thread. (Bug#9087)
4343
5944709e
PE
43442012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4347
e71f5d99
EZ
43482012-01-11 Eli Zaretskii <eliz@gnu.org>
4349
4350 * xdisp.c (rows_from_pos_range): Handle the case where the
4351 highlight ends on a newline. (Bug#10464)
4352 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4353 he end column for display of highlight that ends on a newline
4354 before a R2L line.
4355
ce316182
GM
43562012-01-11 Glenn Morris <rgm@gnu.org>
4357
4358 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4359 from load-path also when installation-directory is nil. (Bug#10208)
4360
5b43da69
GM
43612012-01-10 Glenn Morris <rgm@gnu.org>
4362
74cc8ff9
GM
4363 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4364
7d8d6e4e
GM
4365 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4366 Update template values to be closer to their typical values these days.
5b43da69 4367
a0db8d43
EZ
43682012-01-09 Eli Zaretskii <eliz@gnu.org>
4369
4370 * xdisp.c (rows_from_pos_range): Accept additional argument
4371 DISP_STRING, and accept any glyph in a row whose object is that
4372 string as eligible for mouse highlight. Fixes mouse highlight of
4373 display strings from overlays. (Bug#10464)
4374
9a0115ab 43752012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4376
b9110d6a 4377 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4378 * fileio.c (auto_saving_dir_umask): New static var.
4379 (Fmake_directory_internal): Use it.
4380 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4381 creating the directory. The old code temporarily assigns
4382 too-generous permissions to the directory.
4383 (do_auto_save_eh): Clear it.
b9110d6a 4384 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4385 that the var is always cleared.
4386
6c1bd3f3
EZ
43872012-01-07 Eli Zaretskii <eliz@gnu.org>
4388
4389 * search.c (scan_buffer): Pass character positions to
4390 know_region_cache, not byte positions. (Bug#6540)
4391
069d2b50
L
43922012-01-07 LynX <_LynX@bk.ru> (tiny change)
4393
4394 * w32.c (sys_rename): Report EXDEV when rename of a directory
4395 fails because the target is on another logical disk. (Bug#10284)
4396
75bf0d33
DB
43972012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4398
4399 * xterm.c (x_embed_request_focus): New function.
4400
4401 * xterm.h: Add prototype.
4402
4403 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4404
1c6e5a32
GM
44052012-01-05 Glenn Morris <rgm@gnu.org>
4406
4407 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4408
651e947e
EZ
44092012-01-01 Eli Zaretskii <eliz@gnu.org>
4410
4411 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4412 Load gnutls_transport_set_lowat only if GnuTLS version is below
4413 2.11.1.
4414 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4415 GnuTLS versions below 2.11.1.
4416
3778cdd8
AL
44172011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4418
4419 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4420 to the doc string advising against its use for altering the way
4421 windows are scrolled.
4422
0e5317f7
KH
44232011-12-28 Kenichi Handa <handa@m17n.org>
4424
4425 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4426 coding-system ASCII compatible only when it does not produce BOM
4427 on encoding (Bug#10383).
4428
93d5ca1f
JD
44292011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4430
4431 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4432 can scroll.
4433 (create_and_show_popup_menu): Always use menu_position_func for
4434 Gtk3 (Bug#10361).
4435
ca22b785
AS
44362011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4437
4438 * callint.c (Fcall_interactively): Don't truncate prompt string.
4439
d048e1e6
EZ
44402011-12-23 Eli Zaretskii <eliz@gnu.org>
4441
4442 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4443 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4444 resumed from there (after widening). (Bug#10360)
d048e1e6 4445
5ccaba1f
JD
44462011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4447
4448 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4449
204ee57f
JD
44502011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4451
b81d40f0
JB
4452 * nsterm.m (x_free_frame_resources):
4453 Release f->output_data.ns->miniimage.
204ee57f
JD
4454 (ns_index_color): Fix indentation. Do not retain
4455 color_table->colors[i].
4456
4457 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4458 before returning.
4459
4460 * nsfns.m (x_set_background_color): Assign return value from
4461 ns_index_color to face-background instead of NSColor*.
4462 (ns_implicitly_set_icon_type): Fix indentation.
4463 Change assignment in for loop to comparison.
4464
4465 * emacs.c (ns_pool): New variable.
4466 (main): Assign ns_pool.
4467 (Fkill_emacs): Call ns_release_autorelease_pool.
4468
4469 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4470 autorelease fdesc, release fdAttrs and tdict.
4471 (ns_get_covering_families): Release charset.
4472 (ns_findfonts): Release NSFontDescriptor created with new.
4473 (ns_uni_to_glyphs): Fix indentation.
4474 (setString): Release attrStr before assigning new value.
4475
c803b2b7
JD
44762011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4477
678f4426
JD
4478 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4479 and NS_IMPL_COCOA.
4480 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4481 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4482
cd394be1 44832011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4484
5fecd5fc
JD
4485 * nsterm.m (ns_term_init): Subscribe for notifications
4486 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4487 to method trackingNotification in EmacsMenu.
4488
4489 * nsmenu.m (trackingMenu): New variable.
3771cb17 4490 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4491 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4492 from Aquamacs (Bug#7030).
678f4426
JD
4493
44942011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4495
c803b2b7
JD
4496 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4497 (symbol_to_nsstring): Fix indentation.
4498 (ns_symbol_to_pb): New function.
cae07000
SM
4499 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4500 (Fns_rotate_cut_buffers_internal): Remove.
4501 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4502 Fns_store_cut_buffer_internal.
4503 (ns_get_foreign_selection, Fx_own_selection_internal)
4504 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4505 (Fns_get_selection_internal, Fns_store_selection_internal):
4506 Use ns_symbol_to_pb and check if return value is nil.
4507 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4508 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4509 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4510 renamed to Sns_store_selection_internal.
4511 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4512 and remove this function.
4513 (ns_handle_selection_clear): Remove, never used.
4514 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4515 here.
4516
e1b01a3a
KB
45172011-12-17 Ken Brown <kbrown@cornell.edu>
4518
4519 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4520 GID is unknown (Bug#10257).
4521
2adb6e85
PE
45222011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4523
4524 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4525 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4526 which caused a build failure on GNU/Linux IA-64. This problem was
4527 introduced by my 2011-10-07 patch.
4528
d1d7b339
JL
45292011-12-15 Juri Linkov <juri@jurta.org>
4530
4531 * image.c (imagemagick_error): New function. (Bug#10112)
4532 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4533 Use `imagemagick_error' where ImageMagick functions return
4534 `MagickFalse'.
4535 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4536 proper order.
4537
100d5755
KH
45382011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4539
4540 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4541 fill background (Bug#8992).
4542
454592a6
MR
45432011-12-13 Martin Rudalics <rudalics@gmx.at>
4544
4545 * window.c (Vwindow_combination_resize)
4546 (Vwindow_combination_limit): Use t instead of non-nil in
4547 doc-strings.
61d4b438
MR
4548 (Vrecenter_redisplay): Add first sentence of doc-string on
4549 separate line.
53524d93 4550 (Frecenter): Fix doc-string typo.
454592a6 4551
3633e3aa
KH
45522011-12-11 Kenichi Handa <handa@m17n.org>
4553
4554 * coding.c (Funencodable_char_position): Pay attention to the
4555 buffer text relocation (Bug#9389).
4556
7b9d523a 45572011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4558
7b9d523a
JD
4559 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4560 gtk_init (Bug#10100).
4561
b73189c6
EZ
45622011-12-10 Eli Zaretskii <eliz@gnu.org>
4563
4564 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4565 IT->string is nil. (Bug#10263)
4566
f7dfe5d6
JD
45672011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4568
83faebb4
JD
4569 * nsterm.h (x_free_frame_resources): Declare.
4570
f7dfe5d6
JD
4571 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4572 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4573
4574 * nsterm.h (ns_get_defaults_value): Declare.
4575
4576 * nsterm.m (ns_default): Call ns_get_defaults_value.
4577
7cd4e72c
EZ
45782011-12-09 Eli Zaretskii <eliz@gnu.org>
4579
4580 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4581 (Bug#10170)
4582
b34d7317
YM
45832011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4584
4585 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4586 that where the value of an _OBJC_* symbol points to is in the .bss
4587 section (Bug#10240).
4588
76470ad1
KH
45892011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4590
4591 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4592 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4593
745fff94
KH
45942011-12-08 Kenichi Handa <handa@m17n.org>
4595
4596 * ftfont.c (get_adstyle_property): Fix previous change
4597 (Bug#10233).
4598
6e44397c
JB
45992011-12-07 Juanma Barranquero <lekktu@gmail.com>
4600
4601 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4602 dirs from the default value of EMACSLOADPATH (bug#10208).
4603
7efa6272
GM
46042011-12-07 Glenn Morris <rgm@gnu.org>
4605
4606 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4607 installation and source directories as well. (Bug#10208)
4608
f6fc4d87
CY
46092011-12-06 Chong Yidong <cyd@gnu.org>
4610
4611 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4612
2bf26180
GM
46132011-12-06 Glenn Morris <rgm@gnu.org>
4614
4615 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4616 as an error, not just -1. (Bug#10217)
4617
3a6ad4f0
CY
46182011-12-05 Chong Yidong <cyd@gnu.org>
4619
4620 * keyboard.c (process_special_events): New function.
4621 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4622
75a3b399
PE
46232011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4624
4625 * coding.c (encode_designation_at_bol): Don't use uninitialized
4626 local variable (Bug#9318).
4627
c3c9e25e
KH
46282011-12-05 Kenichi Handa <handa@m17n.org>
4629
4630 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4631 return Qnil (Bug#8046, Bug#10193).
4632
5eb05ea3
KH
46332011-12-05 Kenichi Handa <handa@m17n.org>
4634
4635 * coding.c (encode_designation_at_bol): New args charbuf_end and
4636 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4637 (coding_set_source): Return how many bytes coding->source was
4638 relocated.
4639 (coding_set_destination): Return how many bytes
4640 coding->destination was relocated.
4641 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4642 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4643
46442011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4645
4646 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4647 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4648 macro (Bug#9318).
4649
46502011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4651
4652 The following changes are to fix Bug#9318.
4653
a79703f5 4654 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4655 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4656 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4657 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4658
7dbda6df
JB
46592011-12-05 Juanma Barranquero <lekktu@gmail.com>
4660
4661 * lisp.h (process_quit_flag): Fix external declaration.
4662
6d5eb5b0
SM
46632011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4664
4665 Don't macro-inline non-performance-critical code.
4666 * eval.c (process_quit_flag): New function.
4667 * lisp.h (QUIT): Use it.
4668
a0c3fad0
JD
46692011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4670
4671 * nsfns.m (get_geometry_from_preferences): New function.
4672 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4673
6c07aac2
AS
46742011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4675
4676 * emacs.c (Qkill_emacs): Define.
4677 (syms_of_emacs): Initialize it.
4678 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4679 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4680 (quit_throw_to_read_char): Add parameter `from_signal'.
4681 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4682 * lisp.h (QUIT): Call Fkill_emacs if requested.
4683
c052ead4
JD
46842011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4685
4686 * widget.c (update_wm_hints): Return if wmshell is null.
4687 (widget_update_wm_size_hints): New function.
4688
4689 * widget.h (widget_update_wm_size_hints): Declare.
4690
4691 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4692 widget_update_wm_size_hints (Bug#10104).
4693
9e49252b
EZ
46942011-12-03 Eli Zaretskii <eliz@gnu.org>
4695
4696 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4697 before a newline, prepare the bidi iterator for consuming the
4698 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4699 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4700
02b16839
JL
47012011-12-02 Juri Linkov <juri@jurta.org>
4702
4703 * search.c (Fword_search_regexp): New Lisp function created from
4704 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4705 (Fword_search_backward, Fword_search_forward)
4706 (Fword_search_backward_lax, Fword_search_forward_lax):
4707 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4708 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4709
0068070e
SM
47102011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4711
4712 * fileio.c (Finsert_file_contents): Move after-change-function call
4713 to before the "handled:" label, since all "goto handled" appear in
4714 cases where the *-change-functions have already been properly called
4715 (bug#10117).
4716
3360a3fc
AS
47172011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4718
4719 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4720 waiting for input. (Bug#10169)
4721
73d6c093
EZ
47222011-11-30 Eli Zaretskii <eliz@gnu.org>
4723
4724 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4725 verifies glyph row's hash code--we have just reallocated the
4726 glyphs, so their contents can be complete garbage. (Bug#10164)
4727
febe6bea
JB
47282011-11-30 Juanma Barranquero <lekktu@gmail.com>
4729
4730 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4731
801a4313
EZ
47322011-11-30 Eli Zaretskii <eliz@gnu.org>
4733
4734 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4735 attributes are tested _before_ calling verify_row_hash, to protect
4736 against GCC re-ordering of the tests. (Bug#10164)
4737
2b56b87e
JD
47382011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4739
4740 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4741
4742 * xterm.c (handle_one_xevent): Only set async_visible and friends
4743 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4744 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4745 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4746
dbf31225
PE
47472011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4748
4749 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4750 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4751 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4752 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4753 All uses changed to use GCPRO1 etc.
4754 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4755 Revert to old implementation (i.e., before 2011-03-11).
4756
1305621b
YM
47572011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4758
4759 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4760 of scroll runs so as to avoid assigning disabled bogus rows and
4761 unnecessary graphics copy operations.
4762
8c9afb46
EZ
47632011-11-27 Eli Zaretskii <eliz@gnu.org>
4764
4765 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4766 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4767 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4768 (malloc, free, realloc, calloc): Redirect to e_* only when
4769 compiling Emacs.
4770
4771 * lisp.h (GCTYPEBITS): Move before first use.
4772 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4773 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4774 this macro definition.
4775
4776 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4777 _MSC_VER.
4778
54e9e3bf
JD
47792011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4780
6d5eb5b0
SM
4781 * gtkutil.c (xg_create_frame_widgets):
4782 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4783 present with Gtk+ 2.0.
4784
83aca1cb
PE
47852011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4786
4787 * fileio.c (Finsert_file_contents): Undo previous change; see
4788 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4789
5b76caa4
PE
47902011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4791
4792 Rename locals to avoid shadowing.
4793 * fileio.c (Finsert_file_contents):
4794 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4795 * process.c (wait_reading_process_output):
4796 Rename inner 'proc' to 'p' to avoid shadowing.
4797 Indent for consistency with usual Emacs style.
4798
8c535114
EZ
47992011-11-25 Eli Zaretskii <eliz@gnu.org>
4800
4801 * xdisp.c (redisplay_window): If cursor row is not fully visible
4802 after recentering, and scroll-conservatively is set to a large
4803 number, scroll window by a few more lines to make the cursor fully
4804 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4805 (start_display): Don't move to the next line if the display should
4806 start at a newline that is part of a display vector or an overlay
4807 string. (Bug#10119)
8c535114 4808
fa4fdb5c
JL
48092011-11-24 Juri Linkov <juri@jurta.org>
4810
4811 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4812 after the `MagickPingImage' call. (Bug#10112)
4813
90ec88df
CY
48142011-11-23 Chong Yidong <cyd@gnu.org>
4815
4816 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4817
56e2e794
MR
48182011-11-23 Martin Rudalics <rudalics@gmx.at>
4819
4820 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4821 making another buffer current. (Bug#10114)
4822
b6e64c41
GM
48232011-11-23 Glenn Morris <rgm@gnu.org>
4824
4825 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4826
6b21de18
CY
48272011-11-23 Chong Yidong <cyd@gnu.org>
4828
4829 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4830 using it (Bug#5984).
4831
b12cd789
EZ
48322011-11-22 Eli Zaretskii <eliz@gnu.org>
4833
4834 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4835 and header-lines, as they don't have one computed for them.
4836 (Bug#10098)
4837
4838 * .gdbinit (prow): Make displayed values more self-explaining.
4839 Add row's hash code.
4840
261b6fd4
LMI
48412011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4842
4843 * process.c (wait_reading_process_output): Fix asynchrounous
4844 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4845 (wait_reading_process_output): Add comment and URL.
261b6fd4 4846
e7cfd277
JD
48472011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4848
4849 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4850
a9b9b7f5
CY
48512011-11-21 Chong Yidong <cyd@gnu.org>
4852
4853 * window.c (Fnext_window, Fprevious_window): Doc fix.
4854
b0d15b4f
SM
48552011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4856
4857 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4858
fe7a3057
JB
48592011-11-20 Juanma Barranquero <lekktu@gmail.com>
4860
4861 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4862
d2999b1a
MR
48632011-11-20 Martin Rudalics <rudalics@gmx.at>
4864
4865 * window.c (Fset_window_combination_limit): Rename argument
4866 STATUS to LIMIT.
4867 (Vwindow_combination_limit): Remove "status" from doc-string.
4868
d5ff9cd0
AS
48692011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4870
4871 * m/ibms390.h: Remove.
4872 * m/ibms390x.h: Don't include "ibms390.h".
4873
a5bb9bd3
SM
48742011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4875
4876 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4877 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4878
cd1181db
JB
48792011-11-20 Juanma Barranquero <lekktu@gmail.com>
4880
4881 * casetab.c (Fset_case_table):
4882 * charset.c (Fcharset_after): Fix typos.
4883
615a3b8d 48842011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4885
17e845af
PE
4886 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4887 Otherwise, valgrind does not work on some platforms.
4888 Problem reported by Andreas Schwab in
6a0bf43d
PE
4889 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4890 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4891 is set, removing the need for VIRT_ADDRESS_VARIES.
4892 (PURE_P): Use a more-efficient implementation that needs just one
4893 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4894 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4895 to 4 (xorl, subq, cmpq, setbe).
4896 * alloc.c (pure): Always extern now, since that's the
4897 VIRT_ADDR_VARIES behavior.
4898 (PURE_POINTER_P): Use a single comparison, not two, for
4899 consistency with the new puresize.h.
4900 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4901 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4902 Remove VIRT_ADDR_VARIES no longer needed.
4903
f8fe6f96
EZ
49042011-11-19 Eli Zaretskii <eliz@gnu.org>
4905
4906 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4907 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4908 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4909 behave as if the cursor position were at the window margin.
4910
4911 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4912 and the cursor position is out of bounds, behave as if the cursor
4913 position were at the window margin. (Bug#10075)
4914
df05a53c
CY
49152011-11-18 Chong Yidong <cyd@gnu.org>
4916
4917 * window.c (Fwindow_combination_limit): Make first argument
4918 non-optional, since it is meaningless for live windows like the
4919 selected window.
61ccba97 4920
2071918e
DA
49212011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4922
4923 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4924
b50a28de
SM
49252011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4926
4927 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4928 (graft_intervals_into_buffer): Simplify.
4929
015137db
EZ
49302011-11-18 Eli Zaretskii <eliz@gnu.org>
4931
4932 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4933 hash values of the two rows.
4934 (copy_row_except_pointers): Preserve the used[] arrays and the
4935 hash values of the two rows. (Bug#10035)
68c95424 4936 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4937
4938 * xdisp.c (row_hash): New function, body extracted from
4939 compute_line_metrics.
4940 (compute_line_metrics): Call row_hash, instead of computing the
4941 hash code inline.
4942
4943 * dispnew.c (verify_row_hash): Call row_hash for computing the
4944 hash code of a row, instead of duplicating code from xdisp.c.
4945
4946 * dispextern.h (row_hash): Add prototype.
4947
a2addb04
TH
49482011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4949
4950 * frame.c (delete_frame): Don't delete the terminal when the last
4951 X frame is closed if emacs is built with GTK toolkit.
4952
df85d315
JB
49532011-11-17 Juanma Barranquero <lekktu@gmail.com>
4954
4955 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4956
a0c2d0ae
MR
49572011-11-17 Martin Rudalics <rudalics@gmx.at>
4958
4959 * window.c (Vwindow_splits): Rename to
4960 Vwindow_combination_resize. Suggested by Juri Linkov.
4961 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4962 of Vwindow_splits.
4963
58179cce
JB
49642011-11-16 Juanma Barranquero <lekktu@gmail.com>
4965
7877f373
JB
4966 * nsfns.m (Fns_font_name):
4967 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4968
b6f67890
MR
49692011-11-16 Martin Rudalics <rudalics@gmx.at>
4970
4971 * window.h (window): Rename slot "nest" to "combination_limit".
4972 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4973 (Fset_window_nest): Rename to Fset_window_combination_limit.
4974 (Vwindow_nest): Rename to Vwindow_combination_limit.
4975 (recombine_windows, make_parent_window, make_window)
4976 (Fsplit_window_internal, saved_window)
4977 (Fset_window_configuration, save_window_save): Rename all
4978 occurrences of window_nest to window_combination_limit.
4979
c7015153
JB
49802011-11-15 Juanma Barranquero <lekktu@gmail.com>
4981
4982 * image.c (imagemagick_load_image): Fix typo.
4983
322ad6ec
EZ
49842011-11-14 Eli Zaretskii <eliz@gnu.org>
4985
4986 * xdisp.c (display_line): Move the call to
4987 highlight_trailing_whitespace before the call to
4988 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4989 faces of all the glyphs to compute ROW's hash value.
4990 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4991
f067b8ec
JB
49922011-11-14 Juanma Barranquero <lekktu@gmail.com>
4993
4994 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4995 just return (bug#10044).
4996
1e5b2111
EZ
49972011-11-12 Eli Zaretskii <eliz@gnu.org>
4998
7ef3cbd5
EZ
4999 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5000 with user-defined heap size. Bump the default size of the temacs
5001 heap to 27MB, to avoid memory warning when running temacs.
5002 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5003
1e5b2111
EZ
5004 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5005 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5006 (verify_row_hash) [XASSERTS]: New function.
5007 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5008 that the hash value of glyph rows is correct.
1e5b2111 5009
89d61221
MR
50102011-11-12 Martin Rudalics <rudalics@gmx.at>
5011
5012 * window.h (window): Remove splits slot.
5013 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5014 (Fdelete_other_windows_internal, make_parent_window)
5015 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5016 (Fset_window_configuration, save_window_save): Don't deal with
5017 split status of windows.
5018 (saved_window): Remove splits slot.
5019 (Vwindow_splits): Rewrite doc-string.
5020
97f18cc8
JD
50212011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5022
5023 * xfns.c (unwind_create_frame):
5024 * nsfns.m (unwind_create_frame):
5025 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5026 Vframe_list (Bug#9999).
5027
22a648b4
DA
50282011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5029
0b381c7e 5030 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5031
659afede
KH
50322011-11-11 Kenichi Handa <handa@m17n.org>
5033
5034 * callproc.c (Fcall_process): Set the member dst_multibyte of
5035 process_coding.
5036
9ac0394b
KH
50372011-11-11 Johan Bockgård <bojohan@gnu.org>
5038
5039 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5040 avoid a crash (bug#9496).
5041
2fbdc249
CY
50422011-11-09 Chong Yidong <cyd@gnu.org>
5043
5044 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5045 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5046
ac6b1f81
PE
50472011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5048
5049 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5050
09db192c
PE
50512011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5052
5053 Avoid some portability problems by eschewing 'extern inline' functions.
5054 The trivial performance wins aren't worth the portability hassles; see
5055 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5056 et seq.
5057 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5058 (window_box_width, window_box_left, window_box_left_offset)
5059 (window_box_right, window_box_right_offset): Undo previous change,
5060 by removing the "extern"s.
5061 * intervals.c (adjust_intervals_for_insertion)
5062 (adjust_intervals_for_deletion): Undo previous change,
5063 making these static again.
5064 (offset_intervals, temp_set_point_both, temp_set_point)
5065 (copy_intervals_to_string): No longer inline.
5066 * xdisp.c (window_text_bottom_y, window_box_width)
5067 (window_box_height, window_box_left_offset)
5068 (window_box_right_offset, window_box_left, window_box_right)
5069 (window_box): No longer inline.
5070
105216ed
CY
50712011-11-08 Chong Yidong <cyd@gnu.org>
5072
5073 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5074 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5075 Signal an error if not a live window.
105216ed
CY
5076 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5077 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5078
ae9e237f
JB
50792011-11-07 Juanma Barranquero <lekktu@gmail.com>
5080
5081 * lisp.h (syms_of_abbrev): Remove declaration.
5082 Reported by CHENG Gao <chenggao@royau.me>.
5083
c7aa8333
EZ
50842011-11-07 Eli Zaretskii <eliz@gnu.org>
5085
5086 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5087 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5088 of temacs in GUI mode.
5089
be7f5545
MR
50902011-11-07 Martin Rudalics <rudalics@gmx.at>
5091
5092 * window.h: Declare delete_all_child_windows instead of
5093 delete_all_subwindows.
5094 * window.c (Fwindow_nest, Fset_window_nest)
5095 (Fset_window_new_total, Fset_window_new_normal)
5096 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5097 (delete_all_subwindows): Rename to delete_all_child_windows.
5098 (Fdelete_other_windows_internal, Fset_window_configuration):
5099 Call delete_all_child_windows instead of delete_all_subwindows.
5100 * frame.c (delete_frame): Call delete_all_child_windows instead
5101 of delete_all_subwindows.
5102
ca78dc43
PE
51032011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5104
5105 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5106 This is also needed for porting to any host where GC_MARK_STACK is
5107 not GC_MAKE_GCPROS_NOOPS.
5108 (which_symbols): Use it.
5109
a0241d01
KH
51102011-11-07 Kenichi Handa <handa@m17n.org>
5111
5112 * coding.c (coding_set_destination): Check coding->src_pos only
5113 when coding->src_object is a buffer (bug#9910).
5114
5115 * process.c (send_process): Set the member src_multibyte of coding
5116 to 0 (bug#9911) when sending a unibyte text.
5117
5118 * callproc.c (Fcall_process): Set the member src_multibyte of
5119 process_coding to 0 (bug#9912).
5120
a64bfdfa 51212011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5122
5123 * xmenu.c (cleanup_widget_value_tree): New function.
5124 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5125 calling free_menubar_widget_value_tree directly (Bug#9830).
5126
cb41b32a
PE
51272011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5128
5129 Fix some portability problems with 'inline'.
5130 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5131 (window_box_width, window_box_left, window_box_left_offset)
5132 (window_box_right, window_box_right_offset): Declare extern.
5133 Otherwise, these inline functions do not conform to C99 and
5134 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5135 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5136 * intervals.c (adjust_intervals_for_insertion)
5137 (adjust_intervals_for_deletion): Now extern, because otherwise the
5138 extern inline functions 'offset_intervals' couldn't refer to it.
5139 (static_offset_intervals): Remove.
5140 (offset_intervals): Rewrite using the old contents of
5141 static_offset_intervals. The old version didn't conform to C99
5142 because an extern inline function contained a reference to an
5143 identifier with static linkage.
5144
b7041366
AS
51452011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5146
5147 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5148 GC.
5149
88a37c4d
EZ
51502011-11-06 Eli Zaretskii <eliz@gnu.org>
5151
5152 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5153 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5154 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5155 return Qleft_to_right.
5156
49745b39
CY
51572011-11-06 Chong Yidong <cyd@gnu.org>
5158
5159 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5160 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5161 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5162 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5163 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5164 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5165 (Fwindow_vscroll): Doc fix.
5166 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5167 argument, since it makes no sense to pass a live window and for
5168 consistency with window-child.
5169
1f05cd82
CS
51702011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5171
5172 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5173 support MSVC.
5174
22610910
JR
51752011-11-05 Jason Rumney <jasonr@gnu.org>
5176
5177 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5178 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5179 fonts (Bug#6029).
5180 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5181 bitwise arithmetic preventing use of unicode-sip and non-truetype
5182 opentype fonts.
5183
a06776b2
EZ
51842011-11-05 Eli Zaretskii <eliz@gnu.org>
5185
3ad924ba
EZ
5186 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5187 "emacs"-only part.
5188
a06776b2
EZ
5189 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5190 initialization code to keep similarity to xfns.c after changes
5191 from 2011-11-05.
5192
c9e7db78
JD
51932011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5194
a97f8f3f
JD
5195 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5196 (unwind_create_frame): New function (Bug#9943).
5197 (Fx_create_frame): Restructure code to be more similar to the one in
5198 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5199 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5200 Move terminal->reference_count++ just before making the frame official
5201 (Bug#9943).
5202
5203 * nsterm.m (x_free_frame_resources): New function.
5204 (x_destroy_window): Move code to x_free_frame_resources.
5205
c9e7db78 5206 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5207 (Fx_create_frame, x_create_tip_frame):
5208 Move terminal->reference_count++ just before making the frame
75f1671a 5209 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5210 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5211
a6fc3b5c
EZ
52122011-11-05 Eli Zaretskii <eliz@gnu.org>
5213
5214 Support MSVC build with newer versions of Visual Studio.
5215 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5216 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5217 nt/gmake.defs.
5218
5219 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5220 which are not supported by MSVC.
5221 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5222 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5223 bitfields.
5224 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5225 types in bitfields.
5226 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5227
5228 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5229
58179cce 52302011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5231
5232 Support MSVC build with newer versions of Visual Studio.
5233 * w32.c: Don't include w32api.h for MSVC.
5234 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5235
5236 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5237 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5238 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5239 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5240 e_* cousins.
5241 (alloca) [_MSC_VER]: Define to _alloca.
5242
5243 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5244
5245 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5246
a58c13ed
EZ
52472011-11-04 Eli Zaretskii <eliz@gnu.org>
5248
5249 * xdisp.c (note_mouse_highlight): If either of
5250 previous/next-single-property-change returns nil, treat that as
5251 the beginning or the end of the buffer. (Bug#9955)
5252
fe0b6370
JD
52532011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5254
a58c13ed 5255 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5256 label is not null (Bug#9951).
5257 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5258 may be NULL.
5259
89bd5ee1
EZ
52602011-11-04 Eli Zaretskii <eliz@gnu.org>
5261
5262 * window.c (Fwindow_body_size): Mention in the doc string that the
5263 return value is in frame's canonical units. (Bug#9949)
5264
84c3edb9
EZ
52652011-11-03 Eli Zaretskii <eliz@gnu.org>
5266
4e2fb5c7
EZ
5267 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5268
84c3edb9 5269 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5270 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5271 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5272
bc17a887
EZ
52732011-11-01 Eli Zaretskii <eliz@gnu.org>
5274
5275 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5276 Don't stop backward scan on the continuation glyph, even though
5277 its CHARPOS is positive.
6d5eb5b0
SM
5278 (mouse_face_from_buffer_pos, note_mouse_highlight):
5279 Rename cover_string to disp_string.
bc17a887 5280
4ee88440
MR
52812011-11-01 Martin Rudalics <rudalics@gmx.at>
5282
5283 * window.c (temp_output_buffer_show): Don't use
5284 Vtemp_buffer_show_specifiers.
5285 (Vtemp_buffer_show_specifiers): Remove unused variable.
5286
c2ff3c02
EZ
52872011-10-30 Eli Zaretskii <eliz@gnu.org>
5288
5289 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5290 past the beginning of the current glyph matrix.
5291
58179cce 52922011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5293
5294 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5295 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5296 HAVE_GTK3 (Bug#9869).
b77a6a7f 5297
3b574623
JD
5298 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5299 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5300
b77a6a7f
JD
5301 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5302
5303 * xterm.c: Declare x_handle_net_wm_state to return int.
5304 (handle_one_xevent): Check if we are iconified but don't have
5305 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5306 (get_current_wm_state): Return non-zero if not hidden,
5307 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5308 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5309 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5310 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5311
196e41e4
PE
53122011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5313
5314 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5315 so that this new function doesn't get optimized away by a
5316 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5317
021f2e1a
AS
53182011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5319
5320 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5321
8b058d44
EZ
53222011-10-29 Eli Zaretskii <eliz@gnu.org>
5323
5324 Fix the `xbytecode' command.
5325 * .gdbinit (xprintbytestr): New command.
b50a28de 5326 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5327 (xbytecode): Print the byte-code string as well.
5328
4452fb80
EZ
53292011-10-29 Kim Storm <storm@cua.dk>
5330
8b058d44
EZ
5331 * alloc.c (which_symbols): New function.
5332
21b72067
AS
53332011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5334
5335 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5336 line. (Bug#9903)
5337
83ed7b5c
GM
53382011-10-29 Glenn Morris <rgm@gnu.org>
5339
5340 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5341 Not clear what it was for, and it causes various bugs. (Bug#9839)
5342
5a7a728b
EZ
53432011-10-28 Eli Zaretskii <eliz@gnu.org>
5344
5345 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5346 possible random value that matches one of those tested as
5347 condition to clear the mouse face.
5348
d3d0842f
CY
53492011-10-28 Chong Yidong <cyd@gnu.org>
5350
5351 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5352
31b39d13
DN
53532011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5354
5355 * window.c (make_window): Initialize phys_cursor_on_p.
5356
9aba6043
SM
53572011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5358
5359 * lisp.h (struct Lisp_Symbol): Update comments.
5360
c20992f4
JB
53612011-10-28 Juanma Barranquero <lekktu@gmail.com>
5362
5363 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5364
db4f02f2
EZ
53652011-10-28 Eli Zaretskii <eliz@gnu.org>
5366
5367 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5368 <oslsachem@gmail.com> for helping to debug this.
5369
5370 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5371 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5372 (g_b_init_get_glyph_outline_w): New static variables.
5373 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5374 (GetGlyphOutlineW_Proc): New typedefs.
5375 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5376 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5377 New functions.
5378 (w32font_open_internal, compute_metrics):
5379 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5380 instead of calling the "wide" APIs directly.
5381
5382 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5383
5384 * w32.h (syms_of_w32font): Add prototype.
5385
87e68db4
JB
53862011-10-27 Juanma Barranquero <lekktu@gmail.com>
5387
5388 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5389 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5390 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5391 (Fmove_to_window_line): Doc fix.
5392
435c1d67
CY
53932011-10-27 Chong Yidong <cyd@gnu.org>
5394
5395 * process.c (make_process): Set gnutls_state to NULL.
5396
5397 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5398 non-NULL, regardless of GNUTLS_INITSTAGE.
5399 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5400 an error. Set process slots as soon as we allocate them.
5401
5402 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5403
9c6c6f49
CY
54042011-10-27 Chong Yidong <cyd@gnu.org>
5405
9aba6043
SM
5406 * gnutls.c (emacs_gnutls_deinit): New function.
5407 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5408 (Fgnutls_deinit, Fgnutls_boot): Use it.
5409
5410 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5411 (deactivate_process): Call emacs_gnutls_deinit.
5412
657d08d3
JB
54132011-10-27 Juanma Barranquero <lekktu@gmail.com>
5414
5415 * image.c (x_create_x_image_and_pixmap):
5416 * w32.c (sys_rename, w32_delayed_load):
5417 * w32font.c (fill_in_logfont):
5418 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5419
5430d399
JB
54202011-10-26 Juanma Barranquero <lekktu@gmail.com>
5421
5422 * w32fns.c (w32_default_color_map): New function,
5423 extracted from Fw32_default_color_map.
a7ef684b 5424 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5425
fe0055fa
PE
54262011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5427
5428 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5429
e6346438
SM
54302011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5431
5432 * keyboard.c (test_undefined): New function (bug#9751).
5433 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5434
e112cc37
ET
54352011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5436
5437 * sysdep.c (init_sys_modes): Fix the check for the controlling
5438 terminal (Bug#6649).
5439
7b5d6677
EZ
54402011-10-20 Eli Zaretskii <eliz@gnu.org>
5441
5442 * dispextern.h (struct bidi_it): New member next_en_type.
5443
5444 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5445 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5446 current character, check also for next_en_type being WEAK_EN.
5447 (bidi_resolve_weak): Don't enter the expensive loop if the current
5448 position is before next_en_pos. Record the bidi type of the first
5449 non-ET, non-BN character we find, in addition to its position.
5450 (bidi_level_of_next_char): Invalidate next_en_type when
5451 next_en_pos is over-stepped.
5452
7da0b018
PE
54532011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5454
5455 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5456 * editfns.c: Rewrite current-time-zone so that it invokes
5457 the equivalent of (format-time-string "%Z") to get the time zone name.
5458 This fixes a bug when the time zone name contains characters that
5459 need converting from the system time locale to Emacs internal format.
5460 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5461 that patch fixed format-time-string to do the conversion, but
5462 I forgot to fix current-time-zone.
5463 (format_time_string): New function, containing most of
5464 what Fformat_time_string used to contain.
5465 (Fformat_time_string): Rewrite in terms of format_time_string.
5466 This doesn't change this function's behavior.
5467 (current-time-zone): Rewrite to use format_time_string.
5468 This fixes the bug reported by Michael Schierl in
5469 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5470 Jason Rumney's 2007-06-07 change worked around this bug, but
5471 didn't fix it.
5472 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5473
8547b010
EZ
54742011-10-19 Eli Zaretskii <eliz@gnu.org>
5475
5476 * xdisp.c (start_display): If the character at POS is displayed
5477 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5478 (try_window_reusing_current_matrix): If a line ends in a display
5479 vector or the next line starts in a display vector, continue
5480 redrawing the window even though the character position of
5481 start_row was reached.
8547b010
EZ
5482 (Bug#9771, part 2)
5483
4e948d15
CY
54842011-10-18 Chong Yidong <cyd@gnu.org>
5485
5486 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5487 with nobreak-char-display too.
5488
4787455f
EZ
54892011-10-18 Eli Zaretskii <eliz@gnu.org>
5490
5491 Fix part 3 of bug#9771.
5492 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5493 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5494 non-neutral characters if the current character is a paragraph
5495 separator (a.k.a. Newline). This avoids running the same
5496 expensive loop twice, once when we consume the preceding newline
5497 and the other time when the line actually needs to be displayed.
5498 Avoid the loop when we see neutrals on the base embedding level
5499 following a character whose directionality is the same as the
5500 paragraph's. This avoids running the expensive loop when a line
5501 ends in a long sequence of neutrals, like control characters.
5502 Add assertion against STRONG_AL type. Slightly rearrange code
5503 that determines the type of a neutral given the first non-neutral
5504 that follows it.
5505 (bidi_level_of_next_char): Set next_en_pos to zero when
5506 invalidating its info.
5507
2c91f553
EZ
55082011-10-17 Eli Zaretskii <eliz@gnu.org>
5509
5510 * xdisp.c (push_display_prop): Determine whether to record string
5511 or buffer position by IT->string, not by IT->method. Allow
5512 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5513 (move_it_vertically_backward): Don't look for character position
5514 immediately after the newline when in a continuation line.
5515 (Bug#9771, part 1)
2c91f553 5516
c7b08b0d
MR
55172011-10-15 Martin Rudalics <rudalics@gmx.at>
5518
5519 * window.c (coordinates_in_window): Rewrite and delabelize
5520 vertical border check. (Bug#5357) (Bug#9618)
5521
6b02f655
SM
55222011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5523
5524 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5525 errors in XSetWindowBorder (bug#9310).
5526
81d40c92
DA
55272011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5528
5529 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5530 avoid crash when xmalloc overrun checking is enabled.
5531
d4172c3b
EZ
55322011-10-13 Eli Zaretskii <eliz@gnu.org>
5533
5534 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5535 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5536 cursor motion with <left> and <right> arrow keys.
5537
5538 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5539 some callers set that themselves.
5540
b00eea75
EZ
55412011-10-12 Eli Zaretskii <eliz@gnu.org>
5542
5543 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5544 display string and the previous row comes from the same string and
5545 is empty. (Bug#9739) (Bug#9738)
5546
8fe012c4
SM
55472011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5548
5549 * doc.c (get_doc_string): Encode file name (bug#9735).
5550
0074aef2
EZ
55512011-10-12 Eli Zaretskii <eliz@gnu.org>
5552
79beb178
EZ
5553 * bidi.c (bidi_level_of_next_char):
5554 * xdisp.c (get_visually_first_element): Remove old incorrect
5555 comments regarding the Unicode Line Separator character.
5556
0074aef2
EZ
5557 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5558
6e4b3fbe
DA
55592011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5560
5561 * alloc.c (Fgc_status): Do not access beyond zombies array
5562 boundary if nzombies > MAX_ZOMBIES.
5563 * alloc.c (dump_zombies): Add missing format specifier.
5564
0324f3af
PE
55652011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5566
b5525cac
PE
5567 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5568 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5569
0324f3af
PE
5570 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5571 Some packages use them to denote characters with modifiers.
5572
e9b5f888
AS
55732011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5574
5575 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5576 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5577 matching a pp-number. Rename parameter var to var1.
5578
127827c0
SM
55792011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5580
5581 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5582
c8fd3bd0
GM
55832011-10-08 Glenn Morris <rgm@gnu.org>
5584
5585 * callint.c (Fcall_interactively): Give a more explicit error for the
5586 'c' case with a non-character input. (Bug#8479)
5587
352ec8ff
EZ
55882011-10-08 Eli Zaretskii <eliz@gnu.org>
5589
03669ccb
EZ
5590 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5591 lines.
7061c986
EZ
5592 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5593 lines that are hscrolled on the left.
03669ccb 5594
352ec8ff
EZ
5595 * dispnew.c (buffer_posn_from_coords): Account for a possible
5596 presence of header-line. (Bug#4426)
5597
a66cfb1c
SM
55982011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5599
6b02f655
SM
5600 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5601 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5602
7c5ee88e
PE
56032011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5604
5605 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5606 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5607 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5608 this makes Emacs dump core during garbage collection on rare
5609 occasions. sizeof is obviously inferior to offsetof here, so
5610 stick with offsetof.
5611 (GC_POINTER_ALIGNMENT): New macro.
5612 (mark_memory): Omit 3rd (offset) arg; caller changed.
5613 Don't assume EMACS_INT alignment is the same as pointer alignment.
5614
df1bbe5b
SM
56152011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5616
5617 * keyboard.c (read_key_sequence_remapped): New var.
5618 (read_key_sequence): Compute remapping in the right buffer.
5619 (command_loop_1): Use read_key_sequence's remapping directly.
5620
51553db6
SM
56212011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5622
32c1fffd
SM
5623 * dired.c (file_name_completion): Don't expand file name.
5624 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5625 before checking file name handler.
5626
51553db6
SM
5627 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5628 they've been requested explicitly (bug#9591).
5629
b6bd1599 56302011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5631
5632 * keymap.c (Fsingle_key_description): Use make_specified_string
5633 instead of build_string to build string from push_key_description.
5634 (Bug#5193)
5635
f701dc2a
PE
56362011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5637
4222c55d
PE
5638 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5639 This fixes a Y2038 bug on 64-bit hosts.
5640 * buffer.c (reset_buffer):
5641 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5642 (Fclear_buffer_auto_save_failure):
5643 Use 0, not -1, to represent an unset failure time, since time_t
5644 might not be signed.
5645
f701dc2a
PE
5646 Remove dependency on glibc malloc internals.
5647 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5648 Move back here from lisp.h, but with their new implementations.
5649 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5650 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5651 * charset.c (charset_table_init): New static var.
5652 (syms_of_charset): Use it instead of xmalloc. This removes a
5653 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5654 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5655 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5656 Move back to alloc.c.
5657 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5658 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5659
9ceebf39
JD
56602011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5661
5662 * nsterm.m (windowDidResize): Call x_set_window_size only when
5663 ns_in_resize is true. Otherwise set pixelwidth/height and
5664 call change_frame_size (Bug#9628).
5665
cb993c58
PE
56662011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5667
3930c88b
PE
5668 Port --enable-checking=all to Fedora 14 x86-64.
5669 * charset.c (syms_of_charset): Also account for glibc malloc's
5670 internal overhead when calculating the initial malloc maximum.
5671
cb993c58
PE
5672 Port --enable-checking=all to Fedora 14 x86.
5673 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5674 Move to lisp.h.
5675 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5676 (overrun_check_realloc, overrun_check_free):
5677 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5678 That way, xmalloc returns a properly-aligned pointer even if
5679 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5680 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5681 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5682 into account when calculating the initial malloc maximum.
5683 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5684 Move here from alloc.c, so that charset.c can use it too.
5685 Properly align; the old code wasn't right for common 32-bit hosts
5686 when configured with --enable-checking=all.
5687 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5688 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5689
31bed486
EZ
56902011-09-29 Eli Zaretskii <eliz@gnu.org>
5691
04c70788 5692 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5693 use EDOM.
5694
fbcaa2f3
EZ
56952011-09-28 Eli Zaretskii <eliz@gnu.org>
5696
5697 * xdisp.c (compute_display_string_end): If there's no display
5698 string at CHARPOS, return -1.
5699
5700 * bidi.c (bidi_fetch_char): When compute_display_string_end
5701 returns a negative value, treat the character as a normal
5702 character not covered by a display string. (Bug#9624)
5703
a239d4e9
JB
57042011-09-28 Juanma Barranquero <lekktu@gmail.com>
5705
5706 * lread.c (Fread_from_string): Fix typo in docstring.
5707
88652fd5
EZ
57082011-09-27 Eli Zaretskii <eliz@gnu.org>
5709
5710 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5711 newline, reseat the iterator instead of bidi-iterating there one
5712 character at a time. (Bug#9610)
32c1fffd
SM
5713 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5714 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5715
ed497dd4
AS
57162011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5717
5718 * lread.c (readevalloop): Use correct code for NBSP.
5719 (read1): Likewise. (Bug#9608)
5720
b2bf61aa
MA
57212011-09-25 Michael Albinus <michael.albinus@gmx.de>
5722
5723 * dbusbind.c (Fdbus_register_signal): When service is not
5724 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5725
32bbb17c
GM
57262011-09-25 Glenn Morris <rgm@gnu.org>
5727
5728 * buffer.c (truncate-lines): Doc fix.
5729
94e0933e
CY
57302011-09-24 Chong Yidong <cyd@stupidchicken.com>
5731
5732 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5733 (Fset_window_next_buffers): Doc fix.
5734
cddde921
GM
57352011-09-24 Glenn Morris <rgm@gnu.org>
5736
5737 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5738
1260aef1
PE
57392011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5740
25b4bfa0
PE
5741 Fix minor problems found by static checking.
5742 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5743 * indent.c (Fvertical_motion): Fix == vs = typo.
5744
e3cbd34b
EZ
57452011-09-24 Eli Zaretskii <eliz@gnu.org>
5746
a66cfb1c
SM
5747 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5748 Default value is now t. Doc fix.
6bf7006f 5749
e3cbd34b 5750 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5751 logic when moving up, not only when moving down. Fix the
e3cbd34b 5752 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5753 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5754
5755 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5756 CHARPOS is covered by a display string which includes newlines.
5757 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5758 is covered by a display string with embedded newlines.
5759
a3de0cbd
MA
57602011-09-24 Michael Albinus <michael.albinus@gmx.de>
5761
5762 * dbusbind.c (Fdbus_register_signal): Add match rule to
5763 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5764 (Fdbus_register_method, Vdbus_registered_objects_table):
5765 Fix docstring.
a3de0cbd 5766
b260039d
JM
57672011-09-24 Jim Meyering <meyering@redhat.com>
5768
32c1fffd 5769 do not ignore write error for any output size
b260039d
JM
5770 The previous change was incomplete.
5771 While it makes emacs --batch detect the vast majority of stdout
5772 write failures, errors were still ignored whenever the output size is
5773 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5774 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5775 && echo FAIL: ignored write error
5776 FAIL: ignored write error
5777 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5778 && echo FAIL: ignored write error
5779 FAIL: ignored write error
5780 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5781
8eca8a7c
AS
57822011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5783
5784 * emacs.c (Fkill_emacs): In noninteractive mode exit
5785 non-successfully if a write error occurred on stdout. (Bug#9574)
5786
3341db62
EZ
57872011-09-21 Eli Zaretskii <eliz@gnu.org>
5788
5789 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5790 the xassert test.
5791
5792 * dispextern.h (struct it): Update the comment documenting what
5793 can it->OBJECT be.
5794
8c203dbf
EZ
57952011-09-20 Eli Zaretskii <eliz@gnu.org>
5796
5797 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5798 a display string, extend search for cursor position to end of row.
5799 (find_row_edges): If the row ends in a newline from a display
5800 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5801 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5802 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5803 non-empty line. Fixes confusing cursor motion with arrow keys at
5804 the beginning of a line that starts with whitespace.
8c203dbf 5805
a4824228
LMI
58062011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5807
5808 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5809 (bug#9493).
5810
33ed493b
CY
58112011-09-18 Chong Yidong <cyd@stupidchicken.com>
5812
5813 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5814 boolean (Bug#9154).
5815
56cd55c8
EZ
58162011-09-18 Eli Zaretskii <eliz@gnu.org>
5817
5818 * xdisp.c (display_line): Record maximum and minimum buffer
5819 positions even if no glyphs were produced (e.g., by a zero-width
5820 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5821 buffer positions that will be removed from the glyph row because
5822 they don't fit.
c02dcedf
EZ
5823 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5824 column is beyond frame width: don't subtract 1 "pixel" when
5825 computing width of the stretch.
3e62b7e0
EZ
5826 (reseat_at_next_visible_line_start): Undo the change made on
5827 2011-09-17 that saved paragraph information and restored it after
5828 the call to `reseat'. (Bug#9545)
56cd55c8 5829
5ed99d36 58302011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5831
5832 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5833 and turn window cursor on if cleared (Bug#9415).
5834
5ed99d36 58352011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5836
5837 * search.c (boyer_moore): Take unibyte characters from pattern
5838 literally. (Bug#9458)
5839
9bade7b2
EZ
58402011-09-18 Eli Zaretskii <eliz@gnu.org>
5841
5842 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5843
e5e9d610
PE
58442011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5845
87e4427a
PE
5846 Fix minor problem found by static checking.
5847 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5848 initialized, to pacify gcc -Wuninitialized.
5849
e5e9d610
PE
5850 * fileio.c: Report proper errno when syscall falls.
5851 (Finsert_file_contents): Save and restore errno,
5852 so that report_file_error outputs the correct diagnostic.
5853 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5854
a1674f0b
EZ
58552011-09-18 Eli Zaretskii <eliz@gnu.org>
5856
5857 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5858
fbfb6dd4
EZ
58592011-09-17 Eli Zaretskii <eliz@gnu.org>
5860
5861 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5862 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5863
bb187662
EZ
58642011-09-17 Eli Zaretskii <eliz@gnu.org>
5865
1137e8b8 5866 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5867 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5868
5869 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5870 (bidi_find_paragraph_start): Search back for paragraph beginning
5871 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5872 (bidi_move_to_visually_next): Only trigger paragraph-related
5873 computations when the last character is a newline or at EOB, not
5874 just any NEUTRAL_B. (Bug#9470)
5875
bb187662
EZ
5876 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5877 truncated lines if point is covered by a display string. (Bug#9524)
5878
2e621251
PE
58792011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5880
5881 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5882 (cons_to_x_long): New function.
5883 (lisp_data_to_selection_data): Use it. Correct the test for
5884 short-versus-long data; it was negated. Break out of vector
5885 loop, for efficiency, when a long datum is discovered.
5886
91a15bc6
SM
58872011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5888
5889 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5890
b41c3a35
EZ
58912011-09-16 Eli Zaretskii <eliz@gnu.org>
5892
5893 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5894 GCC PR/17406) by declaring this function with external scope.
5895
7812ba2d
PE
58962011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5897
5898 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5899 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5900
cf7edc2a
AS
59012011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5902
5903 * editfns.c (Fformat): Correctly handle text properties on "%%".
5904
bd01620e
EZ
59052011-09-15 Eli Zaretskii <eliz@gnu.org>
5906
5907 * xterm.c (x_draw_composite_glyph_string_foreground):
5908 * w32term.c (x_draw_composite_glyph_string_foreground):
5909 * term.c (encode_terminal_code):
5910 * composite.c (composition_update_it, get_composition_id):
5911 * xdisp.c (get_next_display_element)
5912 (fill_composite_glyph_string): Add comments about special meaning
5913 of TAB characters in a composition.
5914
a02719a3
PE
59152011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5916
5917 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5918 This occurs when processing a multibyte format.
5919 Problem reported by Wolfgang Jenker.
a02719a3 5920
72589a3c
JB
59212011-09-15 Johan Bockgård <bojohan@gnu.org>
5922
5923 * xdisp.c (try_cursor_movement): Only check for exact match if
5924 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5925
1c14176c
PE
59262011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5927
5928 Remove unused external symbols.
5929 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5930 * xdisp.c (calc_pixel_width_or_height): Now static.
5931 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5932 * indent.c (check_display_width):
5933 * w32term.c: Fix comment to match code.
5934 * xterm.c, xterm.h (x_catching_errors): Remove.
5935
d2eea5b5
PE
59362011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 * xselect.c: Use signed conversions more consistently (Bug#9498).
5939 (selection_data_to_lisp_data): Assume incoming selection data are
5940 signed integers, not unsigned. This is to be consistent with
5941 outgoing selection data, which was modified to use signed integers
5942 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5943 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5944 expects long, not unsigned long.
5945
46888499
EZ
59462011-09-14 Eli Zaretskii <eliz@gnu.org>
5947
5948 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5949 computation of loop end. Reported by Johan Bockgård
5950 <bojohan@gnu.org>.
5951
ef8ef9fb
CY
59522011-09-13 Chong Yidong <cyd@stupidchicken.com>
5953
5954 * frame.c (Fother_visible_frames_p): Function deleted.
5955
fa819fed
EZ
59562011-09-12 Eli Zaretskii <eliz@gnu.org>
5957
5958 * indent.c (compute_motion): Process display vector front to back
5959 rather than the other way around. (Bug#2496)
5960
2ba8e008
SM
59612011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5962
5963 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5964
20f53c69
CY
59652011-09-11 Chong Yidong <cyd@stupidchicken.com>
5966
5967 * minibuf.c (Fread_from_minibuffer): Doc fix.
5968
d562d7a4
EZ
59692011-09-11 Eli Zaretskii <eliz@gnu.org>
5970
5971 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5972 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5973
1c4d7f3d
LMI
59742011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5975
5976 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5977 value for non-existent files.
5978
b885bf36
EZ
59792011-09-11 Eli Zaretskii <eliz@gnu.org>
5980
5981 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5982 set its "size" to -1. This will set the modtime_size field of
5983 the corresponding buffer to -1, which is what
5984 verify-visited-file-modtime expects for files that do not exist.
5985 (Bug#9139)
5986
6612f0bf
PE
59872011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5988
5989 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5990 here ...
5991 * lisp.h: ... from here. push_key_description is no longer
5992 defined in keyboard.c, so its declaration should not be in
5993 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5994 logically belongs with push_key_description.
5995
dfb3f755
PE
59962011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5997
5998 * buffer.h: Include <sys/types.h> instead of <time.h>.
5999 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6000 Problem reported by Herbert J. Skuhra.
6001
3134906c
LMI
60022011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6003
6004 * xml.c (parse_region): Make the parsing work for
6005 non-comment-starting XML files again (bug#9144).
6006
8d903f4e
AS
60072011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6008
6009 * image.c (gif_load): Fix calculation of bottom and right corner.
6010 (Bug#9468)
6011
80ad64f4
EZ
60122011-09-10 Eli Zaretskii <eliz@gnu.org>
6013
6014 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6015 redisplay in small windows.
6016
208a048d
EZ
60172011-09-09 Eli Zaretskii <eliz@gnu.org>
6018
6019 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6020
9b1c252e
MR
60212011-09-08 Martin Rudalics <rudalics@gmx.at>
6022
6023 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6024 Operate on live windows only.
6025
2949f33b
JB
60262011-09-08 Juanma Barranquero <lekktu@gmail.com>
6027
6028 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6029
e08dcafd
EZ
60302011-09-07 Eli Zaretskii <eliz@gnu.org>
6031
6032 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6033 only under bidi iteration.
6034
115b96bd
JD
60352011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6036
6037 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6038
c8199d0f
PE
60392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6040
6041 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6042 Without this fix, the command to link temacs failed due to an
6043 undefined symbol __builtin_isnan. This is because
6044 /usr/include/iso/math_c99.h #defines isnan(x) to
6045 __builtin_isnan(x), but the bundled gcc, which identifies itself
6046 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6047 a __builtin_isnan.
6048 * floatfns.c (isnan): #undef, and then #define to a clone of
6049 what's in data.c.
6050 (Fisnan): Always define, since it's always available now.
6051 (syms_of_floatfns): Always define isnan at the Lisp level.
6052
e39b275c 60532011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6054
6055 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6056
b2db44d9 60572011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6058
f4af5137 6059 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6060 The previous code assumed that file offsets (off_t values) fit in
6061 EMACS_INT variables, which is not true on typical 32-bit hosts.
6062 The code messed up by falsely reporting buffer overflow in cases
6063 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6064 when "big" contains more than 2**29 bytes, even though this
6065 inserts just one byte and does not overflow the buffer.
6066 (Finsert_file_contents): Store file offsets as off_t
6067 values, not as EMACS_INT values. Check for overflow when
6068 converting between EMACS_INT and off_t. When checking for
6069 buffer overflow or for overlap, take the offsets into account.
6070 Don't use EMACS_INT for small values where int suffices.
6071 When checking for overlap, fix a typo: ZV was used where
6072 ZV_BYTE was intended.
6073 (Fwrite_region): Don't assume off_t fits into 'long'.
6074 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6075
ecfc0a49
MA
60762011-09-05 Michael Albinus <michael.albinus@gmx.de>
6077
6078 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6079
6511acf2 60802011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6081
0999621a 6082 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6083
6084 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6085 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6086 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6087 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6088 (modify_event_symbol): Do not assume that the length of
6089 name_alist_or_stem is safe to alloca and fits in int.
6090 (Fexecute_extended_command): Likewise for function name and binding.
6091 (Frecursion_depth): Wrap around reliably on integer overflow.
6092 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6093 since some callers pass EMACS_INT values.
6094 (Fsingle_key_description): Don't crash if symbol name contains more
6095 than MAX_ALLOCA bytes.
6096 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6097 (get_minibuffer): Arg is now EMACS_INT, not int.
6098 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6099 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6100 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6101
2be7d702
PE
6102 * dbusbind.c (signature_cat): New function.
6103 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6104 Do not overrun buffer; instead, report string overflow.
6105
9d1df220
PE
6106 * dispnew.c (add_window_display_history): Don't overrun buffer.
6107 Truncate instead; this is OK since it's just a log.
6108
33ef5c64
PE
6109 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6110 even if the time zone offset is outlandishly large.
6111 Don't mishandle offset == INT_MIN.
6112
66c6fdd5
PE
6113 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6114 when creating daemon; the previous buffer-overflow check was incorrect.
6115
d749b01b
PE
6116 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6117 which has the guts of the old verror function.
6118
b5cd1905
PE
6119 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6120 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6121
6e1a67fb
PE
6122 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6123 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6124 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6125 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6126 length of string rather than counting it via multiple sprintfs;
6127 that's simpler and more reliable.
c21721cc
PE
6128 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6129 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6130 sprintf, in case result does not fit in int.
6131
c57b67fc
PE
6132 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6133 (fontset_from_font): Print it.
6134
8a401434
PE
6135 * frame.c (tty_frame_count): Now printmax_t, not int.
6136 (make_terminal_frame, set_term_frame_name): Print it.
6137 (x_report_frame_params): In X, window IDs are unsigned long,
6138 not signed long, so print them as unsigned.
6139 (validate_x_resource_name): Check for implausibly long names,
6140 and don't assume name length fits in 'int'.
6141 (x_get_resource_string): Don't blindly alloca invocation name;
6142 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6143 not fit in int.
6144
6e1a67fb
PE
6145 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6146 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6147 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6148
0df02bf3
PE
6149 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6150 Use esprintf, not sprintf, in case result does not fit in int.
6151
48e30793
PE
6152 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6153 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6154 it as a large positive number.
6155 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6156 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6157
a66ff6d8
PE
6158 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6159 in case result does not fit in int.
6160
aca216ff
PE
6161 * print.c (float_to_string): Detect width overflow more reliably.
6162 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6163 buffer overrun. Don't assume list length fits in 'int'. Treat
6164 print length of 0 as 0, not as infinity; to be consistent with other
6165 uses of print length in this function. Don't overflow print length
6166 index. Don't assume hash table size fits in 'long', or that
6167 vectorlike size fits in 'unsigned long'.
6168
31c286f7
PE
6169 * process.c (make_process): Use printmax_t, not int, to format
6170 process-name gensyms.
6171
55e5faa1
PE
6172 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6173
80f2e268
PE
6174 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6175 to avoid potential buffer overrun.
6176
670741ab
PE
6177 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6178 if X resource line is longer than 512 bytes.
6179
b7163a50
PE
6180 * xfns.c (x_window): Make sprintf buffer a bit bigger
6181 to avoid potential buffer overrun.
6182
ae58ff1f
PE
6183 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6184
c43c8a6a
PE
6185 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6186
3f8236f4
PE
61872011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6188
53e9fe90 6189 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6190 Without these, Emacs silently mishandles large integers sometimes.
6191 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6192 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6193
6511acf2
PE
6194 * xdisp.c (try_window_id): Check Emacs fixnum range before
6195 converting to 'int'.
806add1d 6196
6511acf2 6197 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6198 Check that an Emacs fixnum is in range before assigning it to 'int'.
6199 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6200 values converted from Emacs fixnums.
6201 (Frecenter): Don't wrap around a line count if it is out of 'int'
6202 range; instead, treat it as an extreme value.
6203 (Fset_window_configuration, compare_window_configurations):
6204 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6205
6511acf2
PE
6206 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6207 that can exceed INT_MAX. Check that EMACS_INT value is in range
6208 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6209 (match_limit): Don't assume that a fixnum can fit in 'int'.
6210
6511acf2 6211 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6212 exceed INT_MAX.
6213
6511acf2 6214 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6215 (Fvertical_motion): Don't wrap around LINES values that don't fit
6216 in 'int'. Instead, treat them as extreme values. This is good
6217 enough for windows, which can't have more than INT_MAX lines anyway.
6218
fcb901a7
LMI
62192011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6220
0f2f6b6d
LMI
6221 * Require libxml/parser.h to avoid compilation warning.
6222
fcb901a7
LMI
6223 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6224
6225 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6226 since this reportedly can destroy thread storage.
6227
6e20a0d4
CY
62282011-08-30 Chong Yidong <cyd@stupidchicken.com>
6229
6230 * syntax.c (find_defun_start): Update all cache variables if
6231 exiting early (Bug#9401).
6232
148ae00e
EZ
62332011-08-30 Eli Zaretskii <eliz@gnu.org>
6234
f6cfbd8f
EZ
6235 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6236
148ae00e
EZ
6237 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6238 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6239 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6240
6241 * term.c (tty_append_glyph): New function.
6242 (produce_stretch_glyph): Static function and its prototype deleted.
6243
a66cfb1c
SM
6244 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6245 Add prototypes.
148ae00e 6246
c4a07a4c
PE
62472011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6248
6249 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6250 when checking :margin (Bug#9390).
6251 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6252 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6253 so that the name doesn't mislead. All uses changed.
6254
6bc8cd65
JB
62552011-08-28 Johan Bockgård <bojohan@gnu.org>
6256
6257 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6258 set_tty_hooks.
6259
dca4927e
EZ
62602011-08-27 Eli Zaretskii <eliz@gnu.org>
6261
6262 * xdisp.c (move_it_to): Don't bail out early when reaching
6263 position beyond to_charpos, if we are scanning backwards.
6264 (move_it_vertically_backward): When DY == 0, make sure we get to
6265 the first character in the line after the newline.
6266
f2cad773
PE
62672011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6268
6269 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6270 (ccl_driver): Do not generate an out-of-range pointer.
6271 (Fccl_execute_on_string): Remove unnecessary check for
6272 integer overflow, noted by Stefan Monnier in
6273 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6274 Remove a FIXME that didn't need fixing.
6275 Simplify the newly-introduced buffer reallocation code.
6276
0cae2cdb
JB
62772011-08-27 Juanma Barranquero <lekktu@gmail.com>
6278
6279 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6280
5fc295a4 62812011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6282
70c60eb2 6283 Integer and memory overflow issues (Bug#9196).
726e0ab1 6284
d31850da
PE
6285 * doc.c (get_doc_string): Rework so that
6286 get_doc_string_buffer_size is the actual buffer size, rather than
6287 being 1 less than the actual buffer size; this makes xpalloc more
6288 convenient.
6289
a69fbedb
PE
6290 * image.c (x_allocate_bitmap_record, cache_image):
6291 * xselect.c (Fx_register_dnd_atom):
6292 Simplify previous changes by using xpalloc.
6293
fe5c5d37
PE
6294 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6295 since either will do and ptrdiff_t is convenient with xpalloc.
6296
0065d054
PE
6297 * charset.c (charset_table_size)
6298 (struct charset_sort_data.priority): Now ptrdiff_t.
6299 (charset_compare): Don't overflow if priorities differ greatly.
6300 (Fsort_charsets): Don't assume list length fits in int.
6301 Check for size-calculation overflow when allocating sort data.
6302 (syms_of_charset): Allocate an initial charset table that is
6303 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6304
6305 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6306
6307 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6308 The actual value is always <= INT_MAX, and leaving it unsigned made
6309 overflow checking harder.
6310
6311 * dispextern.h (struct glyph_matrix.rows_allocated)
6312 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6313 with xpalloc. The values are still always <= INT_MAX.
6314
6315 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6316
6317 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6318 (SAFE_NALLOCA): New macro.
6319
6320 * region-cache.c (struct boundary.pos, find_cache_boundary)
6321 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6322 (set_cache_region, invalidate_region_cache)
6323 (revalidate_region_cache, know_region_cache, region_cache_forward)
6324 (region_cache_backward, pp_cache):
6325 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6326 so that ptrdiff_t * can be passed to xpalloc.
6327 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6328 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6329 (pp_cache): Don't assume cache_len fits in int.
6330 * region-cache.h: Adjust extern decls to match.
6331
6332 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6333 EMACS_INT, since either will do, for xpalloc.
6334
6335 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6336 (xnmalloc, xnrealloc, xpalloc): New functions.
6337
726e0ab1
PE
6338 * bidi.c (bidi_shelve_header_size): New constant.
6339 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6340 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6341
51f30bc5 6342 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6343 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6344 (overlay_strings):
6345 Don't update size of array until after memory allocation succeeds,
6346 because xmalloc/xrealloc may not return.
0065d054
PE
6347 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6348 now that we have proper integer overflow checking.
6349 (record_overlay_string, overlay_strings): Catch overflows when
6350 calculating size of overlay_str_buf.
726e0ab1 6351
0065d054
PE
6352 * callproc.c (Fcall_process): Check for size overflow when
6353 calculating size of args2.
6354 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6355 Normally we prefer signed values, but sticking with ptrdiff_t would
6356 require adding more-complicated checks.
726e0ab1
PE
6357
6358 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6359 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6360 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6361 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6362
6363 * character.c (Fstring): Check for size-calculation overflow.
6364
6365 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6366 unnecessary integer overflow. Check for size overflow.
6367 (encode_coding_object): Don't update size until xmalloc succeeds.
6368
6369 * composite.c (get_composition_id): Check for overflow in glyph
6370 length calculations.
6371
6372 Integer and memory overflow fixes for display code.
6373 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6374 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6375 (scrolling_window): Check for overflow in size calculations.
6376 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6377 Don't assume glyph table len fits in int.
6378 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6379 (row_table_size): Now ptrdiff_t, not int.
6380 (scrolling_window): Avoid overflow in size calculations.
6381 Don't update size until allocation succeeds.
6382 * fns.c (concat): Check for overflow in size calculations.
6383 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6384 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6385 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6386
6387 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6388 (get_doc_string): Check for size calculation overflow.
6389 Don't update size until allocation succeeds.
6390 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6391 EMACS_INT, where ptrdiff_t will do.
6392 (Fsubstitute_command_keys): Check for string overflow.
6393
6394 * editfns.c (set_time_zone_rule): Don't assume environment length
6395 fits in int.
6396 (message_length): Now ptrdiff_t, not int.
6397 (Fmessage_box): Don't update size until allocation succeeds.
6398 Don't assume message length fits in int.
6399 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6400
0065d054
PE
6401 * emacs.c (main): Do not reallocate argv, since there is a null at
6402 the end that can be overwritten, and this way there's no need to
6403 worry about size-calculation overflow.
6404 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6405
6406 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6407 alloc succeeds.
6408 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6409
6410 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6411 (x_set_scroll_bar_width, x_figure_window_size):
6412 Check for integer overflow.
6413 (x_set_alpha): Do not assume XINT fits in int.
6414
6415 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6416 This is for the members text_lines, text_cols, total_lines, total_cols,
6417 where the system imposes an 'int' limit.
6418
6419 * fringe.c (Fdefine_fringe_bitmap):
6420 Don't update size until alloc works.
6421
6422 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6423 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6424
6425 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6426 Check for size-calculation overflow.
6427 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6428 do, as we prefer signed integers.
6429 (id_to_widget.max_size, id_to_widget.used)
6430 (xg_store_widget_in_map, xg_remove_widget_from_map)
6431 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6432 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6433 Use and return ptrdiff_t, not int.
6434 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6435 * gtkutil.h: Change prototypes to match the above.
6436
6437 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6438 are duplicate now that they've been promoted to lisp.h.
6439 (x_allocate_bitmap_record, x_alloc_image_color)
6440 (make_image_cache, cache_image, xpm_load):
6441 Don't update size until alloc is done.
6442 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6443 (x_detect_edges):
3256efce 6444 Check for size calculation overflow.
726e0ab1
PE
6445 (ct_colors_allocated_max): New constant.
6446 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6447 overflow.
3256efce 6448
726e0ab1
PE
6449 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6450 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6451 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6452 Use ptrdiff_t, not int, to count maps.
6453 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6454 calculations. Don't update size until allocation succeeds.
6455 Redo calculations to avoid overflow.
726e0ab1
PE
6456 * keyboard.h: Change prototypes to match the above.
6457
6458 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6459 to count maps.
6460 (current_minor_maps): Check for size calculation overflow.
6461 * keymap.h: Change prototypes to match the above.
6462
6463 * lread.c (read1, init_obarray): Don't update size until alloc done.
6464
6465 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6466 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6467
726e0ab1
PE
6468 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6469 Now ptrdiff_t, not int.
6470 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6471 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6472
6473 * process.c (Fnetwork_interface_list): Check for overflow
6474 in size calculation.
6475
6476 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6477
6478 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6479 overflow. Don't bother calling xmalloc when xrealloc will do.
6480
6481 * search.c (Freplace_match): Check for size calculation overflow.
6482 (Fset_match_data): Don't assume list lengths fit in 'int'.
6483
6484 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6485 for command line length. Do not attempt to address one before the
6486 beginning of an array, as that's not portable.
6487
6488 * term.c (max_frame_lines): Remove; unused.
6489 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6490 not int.
6491 (encode_terminal_code, calculate_costs): Check for size
6492 calculation overflow.
6493 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6494 table lengths and related sizes. Don't update size until alloc
6495 done. Redo calculations to avoid overflow.
6496 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6497
6498 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6499 subtracting pointers.
6500 (gobble_line): Check for overflow more carefully. Don't update size
6501 until alloc done.
6502
6503 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6504 Don't update size until alloc done.
6505 Redo size calculations to avoid overflow.
6506 Check for size calculation overflow.
0065d054 6507 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6508
6509 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6510 Use ptrdiff_t, not int, for sizes.
6511 (store_mode_line_noprop_char): Don't update size until alloc done.
6512
0065d054
PE
6513 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6514 Use ptrdiff_t, not int, for sizes.
6515 (Finternal_make_lisp_face, cache_face):
6516 Check for size calculation overflow.
6517 (cache_face): Treat size calculation overflows as if they were
6518 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6519
6520 * xfns.c (x_encode_text, x_set_name_internal)
6521 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6522 sizes, since they can exceed INT_MAX in size. Check for size
6523 calculation overflow.
6524
0065d054
PE
6525 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6526 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6527 Don't update size until alloc done.
6528
0065d054 6529 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6530 as sprintf is limited to int lengths.
1d526e2f 6531
252c5ee1
PE
6532 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6533 (X_LONG_MIN): New macros.
864d7ce7
PE
6534 Use them to make the following changes clearer.
6535 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6536 This change doesn't affect the value now, but it may help remind
6537 future maintainers not to raise the value too much later.
6538 (SELECTION_QUANTUM): Remove, replacing with ...
6539 (selection_quantum): ... new function, which avoids overflow.
6540 All uses changed.
6541 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6542 assumption that selection length fits in 'int'.
6543 (x_reply_selection_request, x_handle_selection_request)
6544 (x_get_window_property, receive_incremental_selection)
6545 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6546 (lisp_data_to_selection_data, clean_local_selection_data):
6547 Use ptrdiff_t, not int, to record length of selection.
6548 (x_reply_selection_request, x_get_window_property)
6549 (receive_incremental_selection, x_property_data_to_lisp):
6550 Redo calculations to avoid overflow.
6551 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6552 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6553 something.
6554 (x_get_window_property, receive_incremental_selection)
6555 (lisp_data_to_selection_data, x_property_data_to_lisp):
6556 Check for size-calculation overflow.
6557 (x_get_window_property, receive_incremental_selection)
6558 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6559 Don't store size until memory allocation succeeds.
6560 (x_get_window_property): Plug memory leak on memory exhaustion.
6561 Don't double-block input; malloc is safe here. Don't assume 2**34
6562 - 4 fits in unsigned long. Add an xassert to check
6563 XGetWindowProperty overflow. Be more careful about overflow
6564 calculations, and distinguish size from memory overflow better.
6565 (receive_incremental_selection): When tracing, don't assume
6566 unsigned int is less than INT_MAX.
6567 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6568 harmful) conversions of unsigned short to int.
6569 (lisp_data_to_selection_data): Don't assume that integers
6570 in the range -65535 through -1 fit in an X unsigned short.
6571 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6572 result parameters unless successful. Rely on cons_to_unsigned
6573 to report problems with elements; the old code wasn't right anyway.
6574 (x_check_property_data): Check for int overflow; we cannot use
6575 a wider type due to X limits.
6576 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6577
726e0ab1 6578 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6579
0065d054
PE
6580 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6581 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6582 (x_color_cells): Don't store size until memory allocation succeeds.
6583 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6584 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6585 (x_term_init): Don't assume length fits in int (sprintf is limited
6586 to int size).
bc18e09d 6587
ebfa62c0
PE
6588 Use ptrdiff_t for composition IDs.
6589 * character.c (lisp_string_width):
6590 * composite.c (composition_table_size, n_compositions)
6591 (get_composition_id, composition_gstring_from_id):
6592 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6593 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6594 * window.c (Frecenter):
6595 Use ptrdiff_t, not int, for composition IDs.
6596 * composite.c (get_composition_id): Check for integer overflow.
6597 * composite.h: Adjust prototypes to match the above changes.
6598
d3411f89
PE
6599 Use ptrdiff_t for hash table indexes.
6600 * category.c (hash_get_category_set):
6601 * ccl.c (ccl_driver):
6602 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6603 * coding.c (coding_system_charset_list, detect_coding_system):
6604 * coding.h (struct coding_system.id):
6605 * composite.c (get_composition_id, gstring_lookup_cache):
6606 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6607 * image.c (xpm_get_color_table_h):
6608 * lisp.h (hash_lookup, hash_put):
6609 * minibuf.c (Ftest_completion):
6610 Use ptrdiff_t for hash table indexes, not int (which is too
6611 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6612 32-bit --with-wide-int hosts).
6613
e097a6fa
PE
6614 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6615 Add a FIXME comment about memory leaks.
6616 (syms_of_charset): Don't assume xmalloc returns.
6617
5637687f
PE
6618 Don't assume that stated character widths fit in int.
6619 * character.c (Fchar_width, c_string_width, lisp_string_width):
6620 * character.h (CHAR_WIDTH):
6621 * indent.c (MULTIBYTE_BYTES_WIDTH):
6622 Use sanitize_char_width to avoid undefined and/or bad behavior
6623 with outlandish widths.
a66cfb1c 6624 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6625 now that we have two such functions. All uses changed.
6626 (sanitize_char_width): New inline function.
6627
a2271ba2
PE
6628 Don't assume that tab-width fits in int.
6629 * character.h (sanitize_width): New inline function.
6630 (SANE_TAB_WIDTH): New macro.
6631 (ASCII_CHAR_WIDTH): Use it.
6632 * indent.c (sane_tab_width): Remove. All uses replaced by
6633 SANE_TAB_WIDTH (current_buffer).
6634 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6635
18c52557
PE
6636 * fileio.c: Integer overflow issues with file modes.
6637 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6638
caeeedc1
PE
6639 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6640 Remove unreachable code.
6641 (read_hex, load_charset_map_from_file): Check for integer overflow.
6642
6df6ae42 6643 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6644 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6645 (x_send_scroll_bar_event): Likewise. Check that the size does not
6646 exceed limits imposed by XClientMessageEvent, as well as the usual
6647 ptrdiff_t and size_t limits.
6648
b13995db
PE
6649 * keyboard.c: Overflow, signedness and related fixes.
6650 (make_lispy_movement): Use same integer type in forward decl
6651 that is used in the definition.
6652 (read_key_sequence, keyremap_step):
6653 Change bufsize argument back to int, undoing my 2011-03-30 change.
6654 We prefer signed types, and int is wide enough here.
6655 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6656 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6657 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6658 length, not size_t. Use ptrdiff_t for index, not int.
6659 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6660 possibility of integer overflow.
6661
13464394
PE
6662 Overflow, signedness and related fixes for images.
6663
6664 * dispextern.h (struct it.stack[0].u.image.image_id)
6665 (struct_it.image_id, struct image.id, struct image_cache.size)
6666 (struct image_cache.used, struct image_cache.ref_count):
6667 * gtkutil.c (update_frame_tool_bar):
6668 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6669 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6670 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6671 * nsmenu.m (update_frame_tool_bar):
6672 * xdisp.c (calc_pixel_width_or_height):
6673 * xfns.c (image_cache_refcount):
6674 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6675 on typical 64-bit hosts.
6676
6677 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6678 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6679 Omit unnecessary casts to int.
6680 (parse_image_spec): Check that integers fall into 'int' range
6681 when the callers expect that.
6682 (image_ascent): Redo ascent calculation to avoid int overflow.
6683 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6684 (lookup_image): Remove unnecessary tests.
6685 (xbm_image_p): Locals are now of int, not EMACS_INT,
6686 since parse_image_check makes sure they fit into int.
6687 (png_load, gif_load, svg_load_image):
6688 Prefer int to unsigned where either will do.
6689 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6690 old tiff_error_handler and tiff_warning_handler.
6691 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6692 stack buffer overflows. It uses only the features of vsnprintf
6693 that are common to both POSIX and native Microsoft.
6694 (tiff_error_handler, tiff_warning_handler): Use it.
6695 (tiff_load, gif_load, imagemagick_load_image):
6696 Don't assume :index value fits in 'int'.
6697 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6698 (imagemagick_load_image): Check that crop parameters fit into
6699 the integer types that MagickCropImage accepts. Don't assume
6700 Vimagemagick_render_type has a nonnegative value. Don't assume
6701 size_t fits in 'long'.
6702 (gs_load): Use printmax_t to print the widest integers possible.
6703 Check for integer overflow when computing image height and width.
6704
c11821d4
EZ
67052011-08-26 Eli Zaretskii <eliz@gnu.org>
6706
6707 * xdisp.c (redisplay_window): Don't force window start if point
6708 will be invisible in the resulting window. (Bug#9324)
6709
0c95fcf7
EZ
67102011-08-25 Eli Zaretskii <eliz@gnu.org>
6711
6712 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6713 the display spec is of the form `(space ...)'.
6714 (handle_display_spec): Return the value returned by
6715 handle_single_display_spec, not just 1 or zero.
6716 (handle_single_display_spec): If the display spec is of the form
6717 `(space ...)', and specifies display in the text area, return 2
6718 rather than 1.
fee65a97 6719 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6720 accurately, and prefer exact match for point under bidi.
6721 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6722
6723 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6724 into disp_prop; all users changed.
6725
6726 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6727 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6728 for the text covered by the display property.
6729
e4ed06f1
CY
67302011-08-25 Chong Yidong <cyd@stupidchicken.com>
6731
6732 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6733 Change return value to nil.
6734 (Frecord_buffer): Delete unused function.
6735
f67cdd7f
EZ
67362011-08-24 Eli Zaretskii <eliz@gnu.org>
6737
5980d4c6
EZ
6738 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6739 buffers, return left-to-right.
8610fe8b
EZ
6740 (set_cursor_from_row): Consider candidate row a win if its glyph
6741 represents a newline and point is on that newline. Fixes cursor
6742 positioning on the newline at EOL of R2L text within L2R
6743 paragraph, and vice versa.
6744 (try_cursor_movement): Check continued rows, in addition to
6745 continuation rows. Fixes unwarranted scroll when point enters a
6746 continued line of R2L text within an L2R paragraph, or vice versa.
6747 (cursor_row_p): Consider the case of point being equal to
6748 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6749 from the end of a short line to the beginning of a continued line
6750 of R2L text within L2R paragraph.
6751 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6752 composed characters.
5980d4c6 6753
f67cdd7f
EZ
6754 * bidi.c (bidi_check_type): Use xassert.
6755 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6756 members.
6757
bca633fb
EZ
67582011-08-23 Eli Zaretskii <eliz@gnu.org>
6759
6760 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6761 a character.
6762
4a5885a7
CY
67632011-08-23 Chong Yidong <cyd@stupidchicken.com>
6764
6765 * nsfont.m (ns_otf_to_script): Fix typo.
6766
0902a04e
KH
67672011-08-22 Kenichi Handa <handa@m17n.org>
6768
6769 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6770 extra slot even if the purpose is char-code-property-table.
6771
1a2e6670
EZ
67722011-08-23 Eli Zaretskii <eliz@gnu.org>
6773
8ddde651
EZ
6774 * xdisp.c (redisplay_window): When computing centering_position,
6775 account for the height of the header line. (Bug#8874)
6776
425cc014
EZ
6777 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6778 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6779 candidate is selected by the mouse, and that candidate has a
6780 composed character under the mouse.
6781
1a2e6670
EZ
6782 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6783 coordinates reported by pos-visible-in-window-p for a composed
6784 character in column zero.
6785
8b76d6f8
SM
67862011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6787
6788 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6789
dac347dd
EZ
67902011-08-22 Eli Zaretskii <eliz@gnu.org>
6791
6792 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6793 consider it a hit if to_charpos is anywhere in the range of the
6794 composed buffer positions.
6795
e013fb34
CY
67962011-08-22 Chong Yidong <cyd@stupidchicken.com>
6797
6798 * image.c (gif_load): Don't assume that each subimage has the same
6799 dimensions as the base image. Handle disposal method that is
6800 "undefined" by the gif spec (Bug#9335).
6801
bd1ba3e8
CY
68022011-08-20 Chong Yidong <cyd@stupidchicken.com>
6803
6804 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6805 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6806
54a1215b
EZ
68072011-08-19 Eli Zaretskii <eliz@gnu.org>
6808
823564e5
EZ
6809 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6810 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6811 from an Org mode buffer to a Speedbar frame.
6812
54a1215b
EZ
6813 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6814 a composition, take its buffer position from IT->cmp_it.charpos.
6815 Fixes cursor positioning at the beginning of a line that begins
6816 with a composed character.
6817
9778ebcc
EZ
68182011-08-18 Eli Zaretskii <eliz@gnu.org>
6819
0be6ee06
EZ
6820 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6821 character bidirectional type, use STRONG_L instead. Fixes crashes
6822 in a buffer produced by `describe-categories'.
6823
9778ebcc
EZ
6824 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6825 members before the level stack, so they would be saved and
6826 restored when copying iterator state. Fixes incorrect reordering
6827 around TABs covered by display properties.
6828
156bffbe
AS
68292011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6830
6b02f655 6831 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6832
72ad093b
CY
68332011-08-17 Chong Yidong <cyd@stupidchicken.com>
6834
6835 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6836 (internal_condition_case_2, internal_condition_case_n):
6837 Remove unnecessary aborts (Bug#9081).
72ad093b 6838
35774242
EZ
68392011-08-17 Eli Zaretskii <eliz@gnu.org>
6840
6841 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6842 has no `load' handler, try opening the file locally. (Bug#9311)
6843
db76dd85
KB
68442011-08-16 Ken Brown <kbrown@cornell.edu>
6845
6846 * gmalloc.c: Expand comment.
6847
b215eee5
EZ
68482011-08-16 Eli Zaretskii <eliz@gnu.org>
6849
6850 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6851 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6852
a4579d33
KB
68532011-08-16 Ken Brown <kbrown@cornell.edu>
6854
6855 Fix memory allocation problems in Cygwin build (Bug#9273).
6856
6857 * unexcw.c ( __malloc_initialized): Declare external variable.
6858 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6859
8b76d6f8
SM
6860 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6861 New variables.
a4579d33
KB
6862 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6863 dumped emacs.
6864 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6865 in the static heap.
6866 [CYGWIN] (special_realloc): New function.
6867 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6868 requests to realloc storage in the static heap.
6869
3ebec551
PE
68702011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6871
6872 * bidi.c (bidi_initialize): Remove unused local.
6873
9fd8be00
EZ
68742011-08-15 Eli Zaretskii <eliz@gnu.org>
6875
6b02f655
SM
6876 * bidimirror.h:
6877 * biditype.h: Remove file.
6878 * makefile.w32-in ($(BLD)/bidi.$(O)):
6879 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6880
6881 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6882
6883 * chartab.c: Improve commentary for the uniprop_table API.
6884
32413314
EZ
6885 * bidi.c (bidi_paragraph_init): Support zero value of
6886 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6887 (bidi_initialize): Use uniprop_table instead of including
6888 biditype.h and bidimirror.h.
32413314 6889
9fd8be00
EZ
6890 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6891 coordinates of the iterator when restoring from ppos_it.
6892 (Bug#9296)
6893
5cf2b69b
KH
68942011-08-14 Kenichi Handa <handa@m17n.org>
6895
6896 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6897 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6898
daf17d00
EZ
68992011-08-14 Eli Zaretskii <eliz@gnu.org>
6900
6901 * xdisp.c (move_it_in_display_line_to): Don't invoke
6902 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6903 ppos_it. Fixes vertical cursor motion when line beginning is
6904 covered by an image. (Bug#9296)
6905
08e3161a
JD
69062011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6907
6908 * nsterm.h (ns_run_ascript): Declare.
6909 (NSAPP_DATA2_RUNASSCRIPT): Define.
6910
6911 * nsfns.m (as_script, as_result, as_status): New static variables.
6912 (ns_run_ascript): New function.
5e617bc2 6913 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6914 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6915 the event loop. Get status from as_status (Bug#7276).
6916
6917 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6918 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6919 the event loop (Bug#7276).
6920
a3720aa2
AS
69212011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6922
6923 * gnutls.c (QCgnutls_bootprop_priority)
6924 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6925 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6926 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6927 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6928 (QCgnutls_bootprop_verify_hostname_error)
6929 (QCgnutls_bootprop_callbacks_verify): Rename from
6930 Qgnutls_bootprop_..., all uses changed.
6931
6932 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6933 uses changed.
6934
0a0d27fb
PE
69352011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6936
19d5c50c
PE
6937 * xfaces.c (Qframe_set_background_mode): Now static.
6938 * dispextern.h (Qframe_set_background_mode): Remove decl.
6939
0a0d27fb
PE
6940 * process.c (Fnetwork_interface_info): Declare local only if needed.
6941
377538cb
JD
69422011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6943
6944 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6945 (Fnetwork_interface_list): Allocate in increments of bytes instead
6946 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6947 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6948 sockaddr.
6949 (struct ifflag_def): notrailers is smart on OSX.
6950 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6951 Get hardware address with getifaddrs if available.
6952
08fff70c
EZ
69532011-08-12 Eli Zaretskii <eliz@gnu.org>
6954
6955 * xdisp.c (iterate_out_of_display_property): xassert that
6956 IT->position is set to within IT->object's boundaries. Break from
6957 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6958 when IT->position is set up wrongly due to some bug.
6959 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6960 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6961 entry. Force push_it to save on the stack the current
6962 buffer/string position, to be restored by pop_it. Fix flags in
6963 the iterator structure wrt the object coming from a display
6964 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6965 properties. (Bug#9284)
6966
7be1c708 69672011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6968
7be1c708
CY
6969 * fontset.c (fontset_get_font_group): Add proper type checks.
6970 (Bug#9172)
aac0c6e3 6971
7be1c708 69722011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6973
7be1c708
CY
6974 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6975 and LC_VERSION_MIN_MACOSX.
6976 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6977 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6978
97bb72a6
EZ
69792011-08-08 Eli Zaretskii <eliz@gnu.org>
6980
6981 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6982 no-display-properties-and-no-overlays under bidi display.
6983 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6984 properties and overlays.
97bb72a6 6985
d5617611
CY
69862011-08-08 Chong Yidong <cyd@stupidchicken.com>
6987
37e11a63
CY
6988 * editfns.c (Fset_time_zone_rule): Document relationship with the
6989 setenv function.
6990
d5617611
CY
6991 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6992 the font entity extracted from the cache (Bug#8109).
6993
58872834
CY
69942011-08-07 Chong Yidong <cyd@stupidchicken.com>
6995
6996 * composite.c (autocmp_chars): Don't reset point. That is done by
6997 restore_point_unwind (Bug#5984).
6998
75bfc667
JL
69992011-08-07 Juri Linkov <juri@jurta.org>
7000
7001 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7002 to show the arg `TIME' instead of `TIMEVAL'.
7003
d1410150
EZ
70042011-08-06 Eli Zaretskii <eliz@gnu.org>
7005
7006 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7007 display property strides EOL and includes a newline, as in
7008 longlines-mode. (Bug#9254)
75b771e4
EZ
7009 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7010 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7011
7012 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7013 is non-zero, even if the data buffer is NULL. Fixes a crash in
7014 vertical-motion with longlines-mode. (Bug#9254)
7015
35928349
EZ
70162011-08-05 Eli Zaretskii <eliz@gnu.org>
7017
ec7cc85b
EZ
7018 * bidi.c <bidi_cache_total_alloc>: Now static.
7019 (bidi_initialize): Initialize bidi_cache_total_alloc.
7020
8b76d6f8 7021 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7022 cache. (Bug#9221)
7023
7024 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7025 amount allocated this far in `bidi_cache_total_alloc'.
7026 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7027 non-zero, only free the data buffer without restoring the cache
7028 contents. All callers changed.
7029
7030 * dispextern.h (bidi_unshelve_cache): Update prototype.
7031
7032 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7033 (move_it_in_display_line, move_it_to)
7034 (move_it_vertically_backward, move_it_by_lines): Replace the call
7035 to xfree to an equivalent call to bidi_unshelve_cache.
7036 (move_it_in_display_line_to): Fix logic of returning
412b6358 7037 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7038
e2e2423b
EZ
70392011-08-05 Eli Zaretskii <eliz@gnu.org>
7040
7041 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7042 came from a string character with a `cursor' property. (Bug#9229)
7043
ae9e757a
JD
70442011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7045
7046 * Makefile.in (LIB_PTHREAD): New variable.
7047 (LIBES): Add LIB_PTHREAD (Bug#9216).
7048
7049 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7050 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7051
213bd7f2
AS
70522011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7053
6b02f655 7054 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7055
99aaf75f
JD
70562011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7057
7058 * xterm.c (x_find_topmost_parent): New function.
7059 (x_set_frame_alpha): Find topmost parent window with
7060 x_find_topmost_parent and set the property there also (bug#9181).
7061 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7062
c74e9d86
PE
70632011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7064
7065 * callproc.c (Fcall_process): Avoid vfork clobbering
7066 the local vars buffer, coding_systems, current_dir.
7067
640c8776
SM
70682011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7069
7070 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7071
f26d0e4c
PE
70722011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7073
8a10d76c
PE
7074 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7075 so that it is not optimized away.
7076
f26d0e4c
PE
7077 * xdisp.c (compute_display_string_pos): Remove unused local.
7078
55439c61
EZ
70792011-08-02 Eli Zaretskii <eliz@gnu.org>
7080
7081 Fix slow cursor motion and scrolling in large buffers with
7082 selective display, like Org Mode buffers. (Bug#9218)
7083
7084 * dispextern.h (struct bidi_it): New member disp_prop_p.
7085
7086 * xdisp.c: Remove one-slot cache of display string positions.
7087 (compute_display_string_pos): Accept an additional argument
5e617bc2 7088 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7089 for a display string or property. If found, set DISP_PROP_P
7090 non-zero.
7091
7092 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7093 DISP_PROP_P, and pass it to compute_display_string_pos.
7094 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7095 non-zero. All callers of bidi_fetch_char changed.
7096
fb33fa43
SM
70972011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7098
7099 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7100
b099e063
DM
71012010-12-03 Don March <don@ohspite.net>
7102
7103 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7104 last character M-[char] is translated to ESC [char] (bug#7541).
7105
5cc7f7af
KH
71062011-08-02 Kenichi Handa <handa@m17n.org>
7107
d0fffa3f 7108 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7109
7110 * chartab.c (uniprop_table): Make it non-static.
7111
525d5e6e
EZ
71122011-08-01 Eli Zaretskii <eliz@gnu.org>
7113
7114 * xdisp.c (forward_to_next_line_start): Accept additional argument
7115 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7116 on the newline.
7117 (reseat_at_next_visible_line_start): Use the bidi iterator state
7118 returned by forward_to_next_line_start to restore the state of
7119 it->bidi_it after backing up to previous newline. (Bug#9212)
7120
31011111
AS
71212011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7122
7123 * regex.c (re_comp): Protoize.
7124 (re_exec): Fix return type.
7125 (regexec): Fix type of `ret'. (Bug#9203)
7126
476371c4
PE
71272011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7128
e5d76069
PE
7129 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7130 This is needed if max-image-size is a floating-point number.
7131
9a79b20c
AS
71322011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7133
7134 * print.c (print_object): Print empty symbol as ##.
7135
7136 * lread.c (read1): Read ## as empty symbol.
7137
d8c2fa78
AA
71382011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7139
7140 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7141 setting frame foreground color (Bug#9175).
7142 (x_set_background_color): Likewise.
7143
ffe57a7a
AA
7144 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7145 contents (Bug#9176).
7146 (EmacsTooltip -init): Remove bezels and add shadows to
7147 tooltip windows.
7148
bf3492a5
AA
7149 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7150 or scroll bar (Bug#8470).
7151
d55e9c53
AA
7152 * nsfont.m (nsfont_open): Remove assignment to voffset and
7153 unnecessary vars hshink, expand, hd, full_height, min_height.
7154 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7155
7156 * nsterm.h (nsfont_info): Remove voffset field.
7157
d8c2fa78 71582011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7159
7160 Implement strike-through and overline on NextStep (Bug#8863).
7161
7162 * nsfont.m (nsfont_open): Use underline position provided by font,
7163 instead of hard-coded value of 2.
7164 (nsfont_draw): Call ns_draw_text_decoration instead.
7165
7166 * nsterm.h: Add declaration for ns_draw_text_decoration.
7167
7168 * nsterm.m (ns_draw_text_decoration): New function for drawing
7169 underline, overline, and strike-through.
7170 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7171 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7172 accommodate underlining, etc.
4843aac3 7173
4cc60b9b
EZ
71742011-07-28 Eli Zaretskii <eliz@gnu.org>
7175
bc7ece87
EZ
7176 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7177 default.
4cc60b9b 7178
476371c4
PE
71792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7180
66606eea
PE
7181 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7182 Without this fix, if a signal arrives just after memory fills up,
7183 'malloc' might be invoked reentrantly.
7184
476371c4
PE
7185 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7186 In other words, assume that every image size is allowed, on non-X
7187 hosts. This assumption is probably wrong, but it lets Emacs compile.
7188
f3fcc40d
AS
71892011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7190
7191 * regex.c (re_iswctype): Convert return values to boolean.
7192
350c992f
EZ
71932011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7194
7195 * xdisp.c (compute_display_string_pos): Don't use cached display
7196 string position if the buffer had its restriction changed.
7197 (Bug#9184)
7198
5266b4bb
PE
71992011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7200
7201 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7202
2573a837 72032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7204
41f55ccd 7205 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7206
39e378da
PE
7207 * bidi.c: Integer size and overflow fixes.
7208 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7209 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7210 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7211 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7212 (bidi_find_other_level_edge):
7213 Use ptrdiff_t instead of EMACS_INT where either will do.
7214 This works better on 32-bit hosts configured --with-wide-int.
7215 (bidi_cache_ensure_space): Check for size-calculation overflow.
7216 Use % rather than repeated addition, for better worst-case speed.
7217 Don't set bidi_cache_size until after xrealloc returns, because it
7218 might not return.
7219 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7220 (bidi_cache_ensure_space): Also check that the bidi cache size
7221 does not exceed that of the largest Lisp string or buffer. See Eli
7222 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7223
5e927815
PE
7224 * alloc.c (__malloc_size_t): Remove.
7225 All uses replaced by size_t. See Andreas Schwab's note
7226 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7227
ca4aa935
PE
7228 * image.c: Improve checking for integer overflow.
7229 (check_image_size): Assume that f is nonnull, since
7230 it is always nonnull in practice. This is one less thing to
7231 worry about when checking for integer overflow later.
7232 (x_check_image_size): New function, which checks for integer
7233 overflow issues inside X.
7234 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7235 This removes the need for a memory_full check.
7236 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7237 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7238 (xbm_read_bitmap_data): Change locals back to 'int', since
7239 their values must fit in 'int'.
7240 (xpm_load_image, png_load, tiff_load):
7241 Invoke x_create_x_image_and_pixmap earlier,
7242 to avoid much needless work if the image is too large.
7243 (tiff_load): Treat overly large images as if
7244 x_create_x_image_and_pixmap failed, not as malloc failures.
7245 (gs_load): Use x_check_image_size.
7246
5f8f9cc2
PE
7247 * gtkutil.c: Omit integer casts.
7248 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7249 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7250
5adf60bc
PE
7251 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7252
c8907a93
PE
7253 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7254 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7255 would wrongly return t on a 64-bit host.
7256
e3c25c68
PE
7257 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7258 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7259 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7260 and therefore cause GCC to emit a bogus diagnostic in some cases.
7261
3f791afe
PE
7262 * image.c: Integer signedness and overflow and related fixes.
7263 This is not an exhaustive set of fixes, but it's time to
7264 record what I've got.
7265 (lookup_pixel_color, check_image_size): Remove redundant decls.
7266 (check_image_size): Don't assume that arbitrary EMACS_INT values
7267 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7268 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7269 (tiff_load, imagemagick_load_image):
7270 Check for overflow in size calculations.
7271 (x_create_x_image_and_pixmap): Remove unnecessary test for
7272 xmalloc returning NULL; that can't happen.
7273 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7274 (xpm_color_bucket): Use better integer hashing function.
7275 (xpm_cache_color): Don't possibly over-allocate memory.
7276 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7277 (gif_memory_source):
7278 Use ptrdiff_t, not int or size_t, to record sizes.
7279 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7280 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7281 either works, as we prefer signed integers.
7282 (tiff_read_from_memory, tiff_write_from_memory):
7283 Return tsize_t, not size_t, since that's what the TIFF API wants.
7284 (tiff_read_from_memory): Don't fail simply because the read would
7285 go past EOF; instead, return a short read.
7286 (tiff_load): Omit no-longer-needed casts.
7287 (Fimagemagick_types): Don't assume size fits into 'int'.
7288
3cc5a532
PE
7289 Improve hashing quality when configured --with-wide-int.
7290 * fns.c (hash_string): New function, taken from sxhash_string.
7291 Do not discard information about ASCII character case; this
7292 discarding is no longer needed.
7293 (sxhash-string): Use it. Change sig to match it. Caller changed.
7294 * lisp.h: Declare it.
7295 * lread.c (hash_string): Remove, since we now use fns.c's version.
7296 The fns.c version returns a wider integer if --with-wide-int is
7297 specified, so this should help the quality of the hashing a bit.
7298
b312a492
PE
7299 * emacs.c: Integer overflow minor fix.
7300 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7301 Define only if GNU_LINUX.
7302 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7303
dfd153ae
PE
7304 * dispnew.c: Integer signedness and overflow fixes.
7305 Remove unnecessary forward decls, that were a maintenance hassle.
7306 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7307 All uses changed.
7308 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7309 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7310 (prepare_desired_row, line_draw_cost):
7311 Use int, not unsigned, where either works.
7312 (save_current_matrix, restore_current_matrix):
7313 Use ptrdiff_t, not size_t, where either works.
7314 (init_display): Check for overflow more accurately, and without
7315 relying on undefined behavior.
7316
a81d11a3
PE
7317 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7318 Remove, replacing with the new symbols in lisp.h. All uses changed.
7319 * fileio.c (make_temp_name):
7320 * filelock.c (lock_file_1, lock_file):
7321 * xdisp.c (message_dolog):
7322 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7323 Use pMd etc. instead.
7324 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7325 replacing the pWIDE etc. symbols removed from editfns.c.
7326
3300e6fd
PE
7327 * keyboard.h (num_input_events): Now uintmax_t.
7328 This is (very slightly) less likely to mess up due to wraparound.
7329 All uses changed.
7330
fd05c7e9
PE
7331 * buffer.c: Integer signedness fixes.
7332 (alloc_buffer_text, enlarge_buffer_text):
7333 Use ptrdiff_t rather than size_t when either will do, as we prefer
7334 signed integers.
7335
903fe15d
PE
7336 * alloc.c: Integer signedness and overflow fixes.
7337 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7338 (__malloc_size_t): Default to size_t, not to int.
7339 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7340 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7341 Prefer ptrdiff_t to size_t when either would do, as we prefer
7342 signed integers.
7343 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7344 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7345 Now const. Initialize with values that are in range even if char
7346 is signed.
7347 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7348 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7349 These functions do the right thing with sizes > 2**32.
7350 (check_depth): Now ptrdiff_t, not int.
7351 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7352 Adjust to new way of storing sizes. Check for size overflow bugs
7353 in rest of code.
7354 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7355 slightly wrong anyway, as it missed one instance of
7356 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7357 (refill_memory_reserve): Omit needless cast to size_t.
7358 (mark_object_loop_halt): Mark as externally visible.
7359
ac82cc6a
PE
7360 * xselect.c: Integer signedness and overflow fixes.
7361 (Fx_register_dnd_atom, x_handle_dnd_message):
7362 Use ptrdiff_t, not size_t, since we prefer signed.
7363 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7364 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7365 x_dnd_atoms_size and x_dnd_atoms_length.
7366
c2d1e36d
PE
7367 * doprnt.c: Prefer signed to unsigned when either works.
7368 * eval.c (verror):
7369 * doprnt.c (doprnt):
7370 * lisp.h (doprnt):
7371 * xdisp.c (vmessage):
7372 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7373 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7374 prefer signed arithmetic to avoid comparison confusion.
7375 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7376 but is a bit tricky.
7377
0e926e56
PE
7378 Assume freestanding C89 headers, string.h, stdlib.h.
7379 * data.c, doprnt.c, floatfns.c, print.c:
7380 Include float.h unconditionally.
7381 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7382 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7383 * regex.c: Likewise for stddef.h, string.h.
7384 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7385 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7386 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7387 (STDC_HEADERS): Remove obsolete defines.
7388 * sysdep.c: Include limits.h unconditionally.
7389
9cfdb3ec
PE
7390 Assume support for memcmp, memcpy, memmove, memset.
7391 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7392 * regex.c (memcmp, memcpy):
7393 Remove; we assume C89 now.
7394
7395 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7396 (__malloc_safe_bcopy): Remove; no longer needed.
7397
cf950e6b 7398 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7399 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7400 well either way, and we prefer signed to unsigned.
7401
dbf38e02
LMI
74022011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7403
7404 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7405 closes the connection while we're reading (bug#9182).
7406
d6f0886c 74072011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7408
d6f0886c
JD
7409 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7410 are specified (Bug#9168).
24e0f6b1 7411
2eb1f9e6
PE
74122011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7413
7414 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7415 Found by GCC static checking and --with-wide-int on a 32-bit host.
7416
22381272 74172011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7418
7419 * xdisp.c (compute_display_string_pos): Fix logic of caching
7420 previous display string position. Initialize cached_prev_pos to
7421 -1. Fixes slow-down at the beginning of a buffer.
7422
f25e39b4
EZ
74232011-07-24 Eli Zaretskii <eliz@gnu.org>
7424
7425 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7426 for attrs[LFACE_FONTSET_INDEX].
7427
04c4b52e
PE
74282011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7429
7430 * xml.c (parse_region): Remove unused local
7431 that was recently introduced.
7432
c1734fbd
EZ
74332011-07-23 Eli Zaretskii <eliz@gnu.org>
7434
be18c5a5
EZ
7435 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7436 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7437
c1734fbd
EZ
7438 * xdisp.c (move_it_in_display_line_to): Record the best matching
7439 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7440 exit if none of the characters scanned was an exact match.
7441 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7442 when exact match is impossible due to invisible text, and the
7443 lines are truncated.
7444
a258d627
JD
74452011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7446
7447 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7448 for OSX >= 10.7.
7449
b6d5a689
EZ
74502011-07-22 Eli Zaretskii <eliz@gnu.org>
7451
0f74f785
EZ
7452 Fix a significant slow-down of cursor motion with C-n, C-p,
7453 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7454 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7455 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7456 (next_element_from_buffer): Call compute_stop_pos_backwards to
7457 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7458 base_level_stop.
7459 (reseat): Don't look for prev_stop, as that could mean a very long
7460 run.
7461 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7462 <cached_disp_overlay_modiff>: Cache for last found display string
7463 position.
551918c1 7464 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7465 about the same buffer in the same area of character positions, and
7466 the buffer wasn't changed since the time the display string
7467 position was cached.
551918c1 7468
b2d0c91a
EZ
74692011-07-22 Eli Zaretskii <eliz@gnu.org>
7470
7471 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7472 is an integer, which is important for empty lines. (Bug#9149)
7473
043604ee
CY
74742011-07-22 Chong Yidong <cyd@stupidchicken.com>
7475
7476 * frame.c (Fmodify_frame_parameters): In tty case, update the
7477 default face if necessary (Bug#4238).
7478
da4adb04
CY
74792011-07-21 Chong Yidong <cyd@stupidchicken.com>
7480
7481 * editfns.c (Fstring_to_char): No need to explain what a character
7482 is in the docstring (Bug#6576).
7483
9abd0532
LMI
74842011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7485
7486 * xml.c (parse_region): Make sure we always return a tree.
7487
36881d16
HK
74882011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7489
7490 * xml.c (parse_region): If a document contains only comments,
7491 return that, too.
7492
1e98674d
LMI
74932011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7494
7495 * xml.c (make_dom): Return comments, too.
7496
590bd467
PE
74972011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7498
7499 Port to OpenBSD.
7500 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7501 and the surrounding thread.
7502 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7503 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7504 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7505 timer goes off.
7506 * s/openbsd.h (BROKEN_SIGIO): Define.
7507 * unexelf.c (unexec) [__OpenBSD__]:
7508 Don't update the .mdebug section of the Alpha COFF symbol table.
7509
f41628b2
LMI
75102011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7511
7512 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7513 (bug#8460).
7514
b59b67c5
PE
75152011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7516
15e3a074
PE
7517 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7518 This fixes some race conditions on the permissions of any newly
7519 created file.
7520
41bed37d
PE
7521 * alloc.c (valid_pointer_p): Use pipe, not open.
7522 This fixes some permissions issues when debugging.
7523
b59b67c5
PE
7524 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7525 If fchown fails to set both uid and gid, try to set just gid,
7526 as that is sometimes allowed. Adjust the file's mode to eliminate
7527 setuid or setgid bits that are inappropriate if fchown fails.
7528
925a6be7
SM
75292011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7530
7531 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7532 to compare Lisp_Objects.
7533 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7534 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7535 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7536
52968808
AS
75372011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7538
0a6a104b
AS
7539 * lread.c (read_integer): Unread even EOF character.
7540 (read1): Likewise. Properly record start position of symbol.
7541
52968808
AS
7542 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7543 symbol character follows.
7544
9e381cdd
PE
75452011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7546
7547 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7548 This works around a problem with the previous change to Fcopy_file.
7549 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7550 and without this change, GCC might complain about discarding
7551 fchown's return value.
7552
b5641435
JB
75532011-07-16 Juanma Barranquero <lekktu@gmail.com>
7554
7555 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7556
a8031457
PE
75572011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7558
7559 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7560
dd889327
LMI
75612011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7562
750c33f7
LMI
7563 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7564 it's used from the C level.
7565
dd889327
LMI
7566 * process.c: Use the same condition for POLL_FOR_INPUT in both
7567 keyboard.c and process.c (bug#1858).
7568
87e86684
LM
75692011-07-09 Lawrence Mitchell <wence@gmx.li>
7570
7571 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7572 (Fgnutls_boot): Use it.
7573
64348f40
AS
75742011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7575
7576 * doc.c (Fsubstitute_command_keys): Revert last change.
7577
1d698799
LMI
75782011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7579
f863868c
LMI
7580 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7581 quotes the next character, and doesn't affect other longer
7582 sequences (bug#8935).
7583
1d698799
LMI
7584 * lread.c (syms_of_lread): Clarify that is isn't only
7585 `eval-buffer' and `eval-defun' that's affected by
7586 `lexical-binding' (bug#8460).
7587
aa4b6df6
EZ
75882011-07-15 Eli Zaretskii <eliz@gnu.org>
7589
7590 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7591 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7592
5d856da6
PE
75932011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7594
ad6042bb
PE
7595 Fix minor problems found by static checking.
7596 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7597 (elsz): Now a signed constant, not a size_t var. We prefer signed
7598 types to unsigned, to avoid integer comparison confusion. Without
7599 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7600 "cannot optimize loop, the loop counter may overflow", a symptom
7601 of the confusion.
f00bbb22 7602 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7603 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7604
6468f31c
LMI
76052011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7606
49080b10
LMI
7607 * search.c (Fre_search_backward): Mention `case-fold-search' in
7608 all the re_search_* functions (bug#8138).
7609
6468f31c
LMI
7610 * keyboard.c (Fopen_dribble_file): Document when the file is
7611 closed (bug#8056).
7612
c965adc5
EZ
76132011-07-14 Eli Zaretskii <eliz@gnu.org>
7614
df9733bf
EZ
7615 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7616 bidi_cache_idx.
7617
0bb23927
EZ
7618 Support bidi reordering of display and overlay strings.
7619 * xdisp.c (compute_display_string_pos)
7620 (compute_display_string_end): Accept additional argument STRING.
7621 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7622 (reseat_to_string): Initialize bidi_it->string.s and
7623 bidi_it->string.schars.
7624 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7625 NULL (avoids a crash in bidi_paragraph_init).
7626 Initialize itb.string.lstring.
0bb23927
EZ
7627 (init_iterator): Call bidi_init_it only of a valid
7628 buffer position was specified. Initialize paragraph_embedding to
7629 L2R.
7630 (reseat_to_string): Initialize the bidi iterator.
7631 (display_string): If we need to ignore text properties of
7632 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7633 original value of -1 will not work with bidi.)
7634 (compute_display_string_pos): First arg is now struct
7635 `text_pos *'; all callers changed. Support display properties on
7636 Lisp strings.
7637 (compute_display_string_end): Support display properties on Lisp
7638 strings.
7639 (init_iterator, reseat_1, reseat_to_string): Initialize the
7640 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7641 when iterating on a string not from display properties).
640c8776
SM
7642 (compute_display_string_pos, compute_display_string_end):
7643 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7644 arrow keys.
7645 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7646 base_level_stop; instead, set base_level_stop to BEGV.
7647 Fixes crashes in vertical-motion.
0bb23927
EZ
7648 (next_element_from_buffer): Improve commentary for when
7649 the iterator is before prev_stop.
7650 (init_iterator): Initialize bidi_p from the default value of
7651 bidi-display-reordering, not from buffer-local value. Use the
7652 buffer-local value only if initializing for buffer iteration.
7653 (handle_invisible_prop): Support invisible properties on strings
7654 that are being bidi-reordered.
7655 (set_iterator_to_next): Support bidi reordering of C strings and
7656 Lisp strings.
7657 (next_element_from_string): Support bidi reordering of Lisp
7658 strings.
7659 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7660 (display_string): Support display of R2L glyph rows.
7661 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7662 (init_iterator): Don't initialize it->bidi_p for strings
7663 here.
7664 (reseat_to_string): Initialize it->bidi_p for strings here.
7665 (next_element_from_string, next_element_from_c_string)
7666 (next_element_from_buffer): Add xassert's for correspondence
7667 between IT's object being iterated and it->bidi_it.string
7668 structure.
7669 (face_before_or_after_it_pos): Support bidi iteration.
7670 (next_element_from_c_string): Handle the case of the first string
7671 character that is not the first one in the visual order.
7672 (get_visually_first_element): New function, refactored from common
7673 parts of next_element_from_buffer, next_element_from_string, and
7674 next_element_from_c_string.
7675 (tool_bar_lines_needed, redisplay_tool_bar)
7676 (display_menu_bar): Force left-to-right direction. Add a FIXME
7677 comment for making that be controlled by a user option.
7678 (push_it, pop_it): Save and restore the state of the
7679 bidi iterator. Save and restore the bidi_p flag.
7680 (pop_it): Iterate out of display property for string iteration as
7681 well.
7682 (iterate_out_of_display_property): Support iteration over strings.
7683 (handle_single_display_spec): Set up it->bidi_it for iteration
7684 over a display string, and call bidi_init_it.
7685 (handle_single_display_spec, next_overlay_string)
7686 (get_overlay_strings_1, push_display_prop): Set up the bidi
7687 iterator for displaying display or overlay strings.
7688 (forward_to_next_line_start): Don't use the shortcut if
7689 bidi-iterating.
7690 (back_to_previous_visible_line_start): If handle_display_prop
7691 pushed the iterator stack, restore the internal state of the bidi
7692 iterator by calling bidi_pop_it same number of times.
7693 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7694 and we are bidi-iterating, don't decrement the iterator position;
7695 instead, set the first_elt flag in the bidi iterator, to produce
7696 the same effect.
7697 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7698 (push_display_prop): xassert that we are iterating a buffer.
7699 (push_it, pop_it): Save and restore paragraph_embedding member.
7700 (handle_single_display_spec, next_overlay_string)
7701 (get_overlay_strings_1, reseat_1, reseat_to_string)
7702 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7703 correctly. Don't assume unibyte strings are not bidi-reordered.
7704 (compute_display_string_pos)
7705 (compute_display_string_end): Fix handling the case of C string.
7706 (push_it, pop_it): Save and restore from_disp_prop_p.
7707 (handle_single_display_spec, push_display_prop): Set the
7708 from_disp_prop_p flag.
7709 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7710 (pop_it): Call iterate_out_of_display_property only if we are
7711 popping after iteration over a string that came from a display
7712 property. Fix a typo in popping stretch info. Add an assertion
7713 for verifying that the iterator position is in sync with the bidi
7714 iterator.
7715 (handle_single_display_spec, get_overlay_strings_1)
7716 (push_display_prop): Fix initialization of paragraph direction for
7717 string when that of the parent object is not yet determined.
7718 (reseat_1): Call bidi_init_it to resync the bidi
7719 iterator with IT's position. (Bug#7616)
7720 (find_row_edges): If ROW->start.pos gives position
7721 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7722 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7723 Reset the from_disp_prop_p flag.
7724 (SAVE_IT, RESTORE_IT): New macros.
7725 (pos_visible_p, face_before_or_after_it_pos)
7726 (back_to_previous_visible_line_start)
7727 (move_it_in_display_line_to, move_it_in_display_line)
7728 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7729 (try_scrolling, redisplay_window, display_line): Use them when
7730 saving a temporary copy of the iterator and restoring it back.
7731 (back_to_previous_visible_line_start, reseat_1)
7732 (init_iterator): Empty the bidi cache "stack".
7733 (move_it_in_display_line_to): If iterator ended up at
7734 EOL, but we never saw any buffer positions smaller than
7735 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7736 motion in bidi-reordered lines.
7737 (move_it_in_display_line_to): Record prev_method and prev_pos
7738 immediately before the call to set_iterator_to_next. Fixes cursor
7739 motion in bidi-reordered lines with stretch glyphs and strings
7740 displayed in margins. (Bug#8133) (Bug#8867)
7741 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7742 TO_CHARPOS.
640c8776
SM
7743 (pos_visible_p): Support positions in bidi-reordered lines.
7744 Save and restore bidi cache.
0bb23927
EZ
7745
7746 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7747 (bidi_paragraph_info): Delete unused struct.
7748 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7749 (bidi_cache_start): New variable.
7750 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7751 to zero.
7752 (bidi_cache_fetch_state, bidi_cache_search)
7753 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7754 (bidi_cache_find, bidi_peek_at_next_level)
7755 (bidi_level_of_next_char, bidi_find_other_level_edge)
7756 (bidi_move_to_visually_next): Compare cache index with
7757 bidi_cache_start rather than with zero.
7758 (bidi_fetch_char): Accept new argument STRING; all callers
7759 changed. Support iteration over a string. Support strings with
7760 display properties. Support unibyte strings. Fix the type of
7761 `len' according to what STRING_CHAR_AND_LENGTH expects.
7762 (bidi_paragraph_init, bidi_resolve_explicit_1)
7763 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7764 (bidi_level_of_next_char, bidi_move_to_visually_next):
7765 Support iteration over a string.
0bb23927
EZ
7766 (bidi_set_sor_type, bidi_resolve_explicit_1)
7767 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7768 can now be zero (for strings); special values 0 and -1 were
7769 changed to -1 and -2, respectively.
7770 (bidi_char_at_pos): New function.
7771 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7772 Call it instead of FETCH_MULTIBYTE_CHAR.
7773 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7774 initialized to valid values.
7775 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7776 values.
7777 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7778 the test for valid cached positions. Fix the logic for looking up
7779 the sentinel state in the cache. GCPRO the Lisp string we are
7780 iterating.
7781 (bidi_push_it, bidi_pop_it): New functions.
7782 (bidi_initialize): Initialize the bidi cache start stack pointer.
7783 (bidi_cache_ensure_space): New function, refactored from part of
7784 bidi_cache_iterator_state. Don't assume the required size is just
7785 one BIDI_CACHE_CHUNK away.
7786 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7787 (bidi_count_bytes, bidi_char_at_pos): New functions.
7788 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7789 always valid if bidi_cache_idx is valid.
7790 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7791 is valid if it's going to be used.
7792 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7793 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7794 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7795 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7796 (bidi_find_other_level_edge, bidi_cache_start_stack):
7797 All variables related to cache indices are now EMACS_INT.
c965adc5 7798
0bb23927
EZ
7799 * dispextern.h (struct bidi_string_data): New structure.
7800 (struct bidi_it): New member `string'. Make flag members be 1-bit
7801 fields, and put them last in the struct.
640c8776
SM
7802 (compute_display_string_pos, compute_display_string_end):
7803 Update prototypes.
0bb23927
EZ
7804 (bidi_push_it, bidi_pop_it): Add prototypes.
7805 (struct iterator_stack_entry): New members bidi_p,
7806 paragraph_embedding, and from_disp_prop_p.
7807 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7808 (bidi_shelve_cache, bidi_unshelve_cache):
7809 Declare prototypes.
0bb23927
EZ
7810
7811 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7812 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7813 and vector-like objects.
7814
7815 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7816 cache around display iteration.
7817
7818 * window.c (Fwindow_end, window_scroll_pixel_based)
7819 (displayed_window_lines, Frecenter): Save and restore the bidi
7820 cache around display iteration.
7821
3bbd2265
LMI
78222011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7823
7824 * editfns.c (Fdelete_region): Clarify the use of the named
7825 parameters (bug#6788).
7826
adc47434
MR
78272011-07-14 Martin Rudalics <rudalics@gmx.at>
7828
7829 * indent.c (Fvertical_motion): Set and restore w->pointm when
7830 saving and restoring the window's buffer (Bug#9006).
7831
837c31f8
LMI
78322011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7833
7834 * editfns.c (Fstring_to_char): Clarify just what is returned
7835 (bug#6576). Text by Eli Zaretskii.
7836
ac389d0c
JB
78372011-07-13 Juanma Barranquero <lekktu@gmail.com>
7838
7839 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7840
0be0ce47
EZ
78412011-07-13 Eli Zaretskii <eliz@gnu.org>
7842
7843 * buffer.c (mmap_find): Fix a typo.
7844
cd18e7e3
JB
78452011-07-13 Johan Bockgård <bojohan@gnu.org>
7846
7847 Fix execution of x selection hooks.
7848 * xselect.c (Qx_lost_selection_functions)
7849 (Qx_sent_selection_functions): New vars.
7850 (syms_of_xselect): DEFSYM them.
7851 (x_handle_selection_request): Pass Qx_sent_selection_functions
7852 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7853 (x_handle_selection_clear,x_clear_frame_selections):
7854 Pass Qx_lost_selection_functions rather than
7855 Vx_lost_selection_functions to Frun_hook_with_args.
7856
47ea7f44
PE
78572011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7858
ac389d0c 7859 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7860 The old code sometimes used this field without initializing it.
7861
47ea7f44
PE
7862 * alloc.c (gc_sweep): Don't read past end of array.
7863 In theory, the old code could also have corrupted Emacs internals,
7864 though it'd be very unlikely.
7865
bc985c87
AS
78662011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7867
7868 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7869 argument. (Bug#4026)
bc985c87 7870
0cf34688
LMI
78712011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7872
b3dadd76
LMI
7873 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7874 key" (bug#4257).
7875
0cf34688
LMI
7876 * window.c (Fset_window_start): Doc fix (bug#4199).
7877 (Fset_window_hscroll): Ditto.
7878
270768cd
PE
78792011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7880
077e3dda 7881 Fix minor new problems caught by GCC 4.6.1.
270768cd 7882 * term.c (init_tty): Remove unused local.
490011a6 7883 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7884 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7885 not used otherwise.
270768cd 7886
b1f58454
CY
78872011-07-12 Chong Yidong <cyd@stupidchicken.com>
7888
7889 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7890
22b9578d
LMI
78912011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7892
6e70ab07
LMI
7893 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7894 are the mini-buffer and the echo area (bug#3320).
7895
22b9578d
LMI
7896 * term.c (init_tty): Remove support for supdup, c10 and perq
7897 terminals, which are no longer supported (bug#1482).
7898
8974cc9f
JB
78992011-07-10 Johan Bockgård <bojohan@gnu.org>
7900
7901 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7902
a560d974
JD
79032011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7904
7905 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7906 for non-popups (Bug#3642).
7907
1dae0f0a
AS
79082011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7909
268c2c36 7910 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7911 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7912 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7913 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7914 * data.c (fmod): Likewise.
7915 * dispnew.c (swap_glyphs_in_rows): Likewise.
7916 * emacs.c (memory_warning_signal): Likewise.
7917 * floatfns.c (float_error): Likewise.
7918 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7919 (otf_open, font_otf_capability, generate_otf_features)
7920 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7921 Likewise.
7922 * image.c (pbm_read_file): Likewise.
7923 * indent.c (string_display_width): Likewise.
7924 * intervals.c (check_for_interval, search_for_interval)
7925 (inc_interval_count, count_intervals, root_interval)
7926 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7927 * lread.c (defalias): Likewise.
268c2c36 7928 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7929 * regex.c (set_image_of_range_1, set_image_of_range)
7930 (regex_grow_registers): Likewise.
7931 * sysdep.c (strerror): Likewise.
7932 * termcap.c (valid_filename_p, tprint, main): Likewise.
7933 * tparam.c (main): Likewise.
7934 * unexhp9k800.c (run_time_remap, save_data_space)
7935 (update_file_ptrs, read_header, write_header, calculate_checksum)
7936 (copy_file, copy_rest, display_header): Likewise.
7937 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7938 Likewise.
7939 * xdisp.c (check_it): Likewise.
7940 * xfaces.c (register_color, unregister_color, unregister_colors):
7941 Likewise.
7942 * xfns.c (print_fontset_result): Likewise.
7943 * xrdb.c (member, fatal, main): Likewise.
7944
99033785
PE
79452011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7946
7947 Fix minor problems found by static checking (Bug#9031).
7948 * chartab.c (char_table_set_range, map_sub_char_table):
7949 Remove unused locals.
7950 (uniprop_table): Now static.
7951 * composite.c (_work_char): Remove unused static var.
7952
9cb2ac56
JB
79532011-07-09 Juanma Barranquero <lekktu@gmail.com>
7954
7955 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7956
f25661f0
JD
79572011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7958
7959 * gtkutil.c (qttip_cb): Remove code without function.
7960
8278c4fe
EZ
79612011-07-09 Eli Zaretskii <eliz@gnu.org>
7962
7963 * w32.c (pthread_sigmask): New stub.
7964
1692ae2d 79652011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7966
8a6ebd58 7967 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7968 sigprocmask is portable only for single-threaded applications, and
7969 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7970 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7971 (LIBES): Use it.
7972 * callproc.c (Fcall_process):
7973 * process.c (create_process):
7974 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7975 Use pthread_sigmask, not sigprocmask.
123403e4 7976
1b854618
JD
79772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7978
7979 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7980 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7981 wrong (Bug#8591).
7982
3fe4b549
JD
79832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7984
0ce7e563
JD
7985 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7986 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7987 (xg_hide_tooltip): Fix comment.
7988
3fe4b549
JD
7989 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7990 in registerServicesMenuSendTypes.
7991 (validRequestorForSendType): Don't check ns_return_types.
7992
7993 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7994 ns_return_type.
7995
5df75e47
JR
79962011-07-08 Jason Rumney <jasonr@gnu.org>
7997
22610910
JR
7998 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7999 SH_SHOW for hidden windows (Bug#5482).
8000
5df75e47
JR
8001 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8002 frame struct members of non-existent frames (Bug#6284).
8003
699c10bd
JD
80042011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8005
4393663b
JD
8006 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8007 variable firstTime not needed on OSX >= 10.6.
8008 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8009 >= 10.5. Use setKnobProportion, setDoubleValue.
8010
8011 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8012 (MAC_OS_X_VERSION_10_5): Define if not defined.
8013 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8014 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8015 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8016
8017 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8018 cString and lossyCString on OSX >= 10.4.
4393663b 8019
58179cce 8020 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8021 sizeToFit on OSX >= 10.2.
8022
8023 * nsimage.m (allocInitFromFile): Don't use deprecated method
8024 bestRepresentationForDevice on OSX >= 10.6.
8025
8026 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8027 to avoid warning.
8028
8029 * emacs.c: Declare unexec_init_emacs_zone.
8030
a63e0781
JD
8031 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8032
699c10bd
JD
8033 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8034
8035 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8036 on svcsMenu (Bug#8842).
8037
8038 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8039 ns_return_types.
8040 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8041
8042 * nsterm.m (QUTF8_STRING): Declare.
8043 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8044 (validRequestorForSendType): Return type is (id).
8045 Change indexOfObjectIdenticalTo to indexOfObject.
8046 Check if we have local selection before returning self (Bug#8842).
8047 (writeSelectionToPasteboard): Put local selection into paste board
8048 if we have a local selection (Bug#8842).
8049 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8050
8051 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8052 (ns_get_local_selection): Declare.
8053
54e10184
LMI
80542011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8055
9888ff71
LMI
8056 * keymap.c (describe_map_tree): Don't insert a double newline at
8057 the end of the buffer (bug#1169) and return whether we inserted
8058 something.
8059
54e10184
LMI
8060 * callint.c (Fcall_interactively): Change "reading args" to
8061 "providing args" to try to clarify what it does (bug#1010).
8062
15fa4783
KH
80632011-07-07 Kenichi Handa <handa@m17n.org>
8064
8065 * composite.c (composition_compute_stop_pos): Ignore a static
8066 composition starting before CHARPOS (Bug#8915).
8067
8068 * xdisp.c (handle_composition_prop): Likewise.
8069
a8815b00
EZ
80702011-07-07 Eli Zaretskii <eliz@gnu.org>
8071
8072 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8073 (Bug#9015)
8074
ef7b981d 80752011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8076
8077 * character.h (unicode_category_t): New enum type.
8078
8079 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8080 (Qchar_code_property_table): New variable.
8081 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8082 (UNIPROP_COMPRESSED_FORM_P): New macros.
8083 (char_table_ascii): Uncompress the compressed values.
8084 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8085 Uncompress the compressed values.
ac389d0c 8086 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8087 (char_table_ref_and_range): Uncompress the compressed values.
8088 (sub_char_table_set): New arg is_uniprop. Callers changed.
8089 Uncompress the compressed values.
8090 (sub_char_table_set_range): Args changed. Callers changed.
8091 (char_table_set_range): Adjuted for the above change.
8092 (map_sub_char_table): Delete args default_val and parent. Add arg
8093 top. Give decoded values to a Lisp function.
640c8776 8094 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8095 values to a Lisp function. Gcpro more variables.
8096 (uniprop_table_uncompress)
8097 (uniprop_decode_value_run_length): New functions.
8098 (uniprop_decoder, uniprop_decoder_count): New variables.
8099 (uniprop_get_decoder, uniprop_encode_value_character)
8100 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8101 New functions.
8102 (uniprop_encoder, uniprop_encoder_count): New variables.
8103 (uniprop_get_encoder, uniprop_table)
8104 (Funicode_property_table_internal, Fget_unicode_property_internal)
8105 (Fput_unicode_property_internal): New functions.
8106 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8107 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8108 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8109 char-code-property-alist.
8110
640c8776 8111 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8112 Vunicode_category_table.
8113
640c8776 8114 * font.c (font_range): Adjust for the change of
c805dec0
KH
8115 Vunicode_category_table.
8116
76b397fb
DN
81172011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8118
8119 * m/iris4d.h: Remove file, move contents ...
8120 * s/irix6-5.h: ... here.
8121
22b4128e
PE
81222011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8123
8124 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8125 * alloc.c (mark_buffer):
8126 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8127 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8128 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8129 This isn't true in general, and it's particularly not true
8130 if Emacs is configured with --with-wide-int.
8131 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8132 New macros, used in the buffer.c change.
8133
869795d6
JD
81342011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8135
8136 * xsettings.c: Use both GConf and GSettings if both are available.
8137 (store_config_changed_event): Add comment.
8138 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8139 (store_tool_bar_style_changed): New functions.
5e617bc2 8140 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8141 (struct xsettings): Move font inside HAVE_XFT.
8142 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8143 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8144 Move inside HAVE_XFT.
640c8776 8145 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8146 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8147 also.
8148 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8149 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8150 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8151 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8152 (parse_settings): Move check for font inside HAVE_XFT.
8153 (read_settings, apply_xft_settings): Add comment.
8154 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8155 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8156 call store_font_name_changed.
8157 (xft_settings_event): Add comment.
8158 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8159 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8160 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8161 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8162 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8163 (xsettings_get_system_font, xsettings_get_system_normal_font):
8164 Add comment.
869795d6 8165
d8ed26bd
PE
81662011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8167
8168 Random fixes. E.g., (random) never returned negative values.
8169 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8170 subseconds part to the entropy, as that's a bit more random.
8171 Prefer signed to unsigned, since the signedness doesn't matter and
8172 in general we prefer signed. When given a limit, use a
8173 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8174 latter isn't right if USE_2_TAGS_FOR_INTS.
8175 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8176 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8177
cabf1cac
SM
81782011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8179
8180 * textprop.c (text_property_stickiness):
8181 Obey Vtext_property_default_nonsticky.
8182 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8183 * w32fns.c (syms_of_w32fns):
8184 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8185
6e9b2be9
PE
81862011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8187
8188 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8189 This is more efficient than Ffile_directory_p and avoids a minor race.
8190
90186c68
LMI
81912011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8192
7c301272
LMI
8193 * buffer.c (Foverlay_put): Say what the return value is
8194 (bug#7835).
8195
c4f2d8d4
LMI
8196 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8197 is a directory before asking whether to use the file name
8198 (bug#7564).
ad637907
LMI
8199 (barf_or_query_if_file_exists): Make the "File is a directory"
8200 error be more correct.
c4f2d8d4 8201
90186c68
LMI
8202 * fns.c (Frequire): Remove the mention of the .gz files, since
8203 that's installation-specific, but keep the mention of
8204 `get-load-suffixes'.
8205
da64016e
PE
82062011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8207
8208 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8209 Report string overflow if the output is too long.
8210
7d47b580
JB
82112011-07-04 Juanma Barranquero <lekktu@gmail.com>
8212
a555cb87
JB
8213 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8214 (syms_of_gnutls): Remove duplicate DEFSYM for
8215 Qgnutls_bootprop_verify_hostname_error, an error for
8216 Qgnutls_bootprop_verify_error (which is no longer used).
8217
7d47b580
JB
8218 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8219 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8220 Also (re)move comments that are misplaced or no longer relevant.
8221
1e49bfab
LMI
82222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8223
8224 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8225
1485f4c0
CY
82262011-07-03 Chong Yidong <cyd@stupidchicken.com>
8227
8228 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8229 and background color parameters if they have been changed.
8230
a9ab721e
LMI
82312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8232
8233 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8234
cf7cff57
PE
82352011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8236
2e13213d
PE
8237 * xsettings.c (SYSTEM_FONT): Define only when used.
8238 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8239
cf7cff57
PE
8240 * keymap.c (access_keymap_1): Now static.
8241
7a8e04f7
CY
82422011-07-02 Chong Yidong <cyd@stupidchicken.com>
8243
8244 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8245 leave any prefix arg for the up event (Bug#1586).
8246
61352f62
LMI
82472011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8248
69bb1ef7
LMI
8249 * lread.c (syms_of_lread): Mention single symbols defined by
8250 `defvar' or `defconst' (bug#7154).
8251
61352f62 8252 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8253 (Frequire): Mention get-load-suffixes.
61352f62 8254
28545e04
MR
82552011-07-02 Martin Rudalics <rudalics@gmx.at>
8256
8257 * window.h (window): Remove clone_number slot.
8258 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8259 Remove.
8260 (make_parent_window, make_window, saved_window)
8261 (Fset_window_configuration, save_window_save): Don't deal with
8262 clone numbers.
8263 * buffer.c (Qclone_number): Remove declaration.
8264 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8265
3349e122
SM
82662011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8267
8268 Add multiple inheritance to keymaps.
8269 * keymap.c (Fmake_composed_keymap): New function.
8270 (Fset_keymap_parent): Simplify.
8271 (fix_submap_inheritance): Remove.
8272 (access_keymap_1): New function extracted from access_keymap to handle
8273 embedded parents and handle lists of maps.
8274 (access_keymap): Use it.
8275 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8276 (Fcopy_keymap): Handle embedded parents.
8277 (Fcommand_remapping, define_as_prefix): Simplify.
8278 (Fkey_binding): Simplify.
8279 (syms_of_keymap): Move minibuffer-local-completion-map,
8280 minibuffer-local-filename-completion-map,
8281 minibuffer-local-must-match-map, and
8282 minibuffer-local-filename-must-match-map to Elisp.
8283 (syms_of_keymap): Defsubr make-composed-keymap.
8284 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8285 (parse_menu_item): Trivial simplification.
8286
3279eb87
GM
82872011-07-01 Glenn Morris <rgm@gnu.org>
8288
8289 * Makefile.in (SETTINGS_LIBS): Fix typo.
8290
4550efdf
KI
82912011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8292
8293 * coding.c (Fencode_coding_string): Record the last coding system
8294 used, as the function doc string says (bug#8738).
8295
0949d2b6
JD
82962011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8297
8298 * xsettings.c (store_monospaced_changed): Take new font as arg and
8299 check for change against current_mono_font.
8300 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8301 (emacs_settings_constructor, emacs_settings_get_property)
8302 (emacs_settings_set_property, emacs_settings_class_init)
8303 (emacs_settings_init, gsettings_obj): Remove.
8304 (something_changedCB): New function for HAVE_GSETTINGS.
8305 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8306 with value as argument.
8307 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8308 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8309 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8310 "changed".
8311
8312 * xgselect.c: Add defined (HAVE_GSETTINGS).
8313 (xgselect_initialize): Ditto.
8314
8315 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8316 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8317 xg_select.
8318
bbc6b304
PE
83192011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8320
8321 * eval.c (struct backtrace): Simplify and port the data structure.
8322 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8323 signed bit field, as this assumption is not portable and it makes
8324 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8325 "char debug_on_exit : 1" as this is not portable either; instead,
8326 use the portable "unsigned int debug_on_exit : 1". Remove unused
8327 member evalargs. Remove obsolete comments about cc bombing out.
8328
9851bfc5
JD
83292011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8330
51bb811f 8331 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8332 Let HAVE_GSETTINGS override HAVE_GCONF.
8333 (store_monospaced_changed): New function.
8334 (EMACS_SETTINGS): A new type derived from GObject to handle
8335 GSettings notifications.
8336 (emacs_settings_constructor, emacs_settings_get_property)
8337 (emacs_settings_set_property, emacs_settings_class_init):
8338 New functions.
8339 (gsettings_client, gsettings_obj): New variables.
8340 (GSETTINGS_SCHEMA): New define.
8341 (something_changedCB): Call store_monospaced_changed.
8342 (init_gsettings): New function.
8343 (xsettings_initialize): Call init_gsettings.
8344 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8345 to NULL.
8346
640c8776 8347 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8348 GCONF_CFLAGS/LIBS.
8349
5386012d
MR
83502011-06-29 Martin Rudalics <rudalics@gmx.at>
8351
8352 * window.c (resize_root_window, grow_mini_window)
8353 (shrink_mini_window): Rename Qresize_root_window to
8354 Qwindow_resize_root_window and Qresize_root_window_vertically to
8355 Qwindow_resize_root_window_vertically.
8356
f13e0b08
PE
83572011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8358
8359 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8360
94515237
JB
83612011-06-27 Juanma Barranquero <lekktu@gmail.com>
8362
8363 * makefile.w32-in: Redesign dependencies so they reflect more
8364 clearly which files are directly included by each source file,
8365 and not through other includes.
8366
e43b6e43
MR
83672011-06-27 Martin Rudalics <rudalics@gmx.at>
8368
8369 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8370 (sort_overlays, overlay_strings): When an overlay's clone number
8371 matches the window's clone number process the overlay even if
8372 the overlay's window property doesn't match the current window.
8373
d68443dc
MR
8374 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8375 (Fwindow_hchild): Rename to Fwindow_left_child.
8376 (Fwindow_next): Rename to Fwindow_next_sibling.
8377 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8378 (resize_window_check): Rename to window_resize_check.
8379 (resize_window_apply): Rename to window_resize_apply.
8380 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8381 (Fdelete_other_windows_internal, resize_frame_windows)
8382 (Fsplit_window_internal, Fdelete_window_internal)
8383 (grow_mini_window, shrink_mini_window)
8384 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8385
c7e73be5
JD
83862011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8387
8388 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8389 (emacs_fixed_set_min_size): Remove.
8390 (emacs_fixed_new): Take frame as argument.
8391
8392 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8393 (_EmacsFixedPrivate): Remove minwidth/height.
8394 Add struct frame *f.
8395 (emacs_fixed_init): Initialize priv->f.
8396 (get_parent_class, emacs_fixed_set_min_size): Remove.
8397 (emacs_fixed_new): Set priv->f to argument.
8398 (emacs_fixed_get_preferred_width)
8399 (emacs_fixed_get_preferred_height): Use min_width/height from
8400 frames size_hint to set minimum and natural (Bug#8919).
8401 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8402 and use min_width/height from frames size_hint to set
8403 min_width/height (Bug#8919).
8404
8405 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8406 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8407 Fix indentation.
c7e73be5 8408
cf99dcf8
EZ
84092011-06-26 Eli Zaretskii <eliz@gnu.org>
8410
8411 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8412 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8413 called at ZV.
8414
029529ac
CY
84152011-06-26 Chong Yidong <cyd@stupidchicken.com>
8416
8417 * process.c (wait_reading_process_output): Bypass select if
8418 waiting for a cell while ignoring keyboard input, and input is
8419 pending. Suggested by Jan Djärv (Bug#8869).
8420
7a7ef429
PE
84212011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8422
8423 Use gnulib's dup2 module instead of rolling our own.
8424 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8425
11fdef7d 84262011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8427
8428 * dispnew.c (scrolling_window): Before scrolling, turn off a
8429 mouse-highlight in the window being scrolled.
8430
cd3520a4
JB
84312011-06-24 Juanma Barranquero <lekktu@gmail.com>
8432
8433 Move DEFSYM to lisp.h and use everywhere.
8434
8435 * character.h (DEFSYM): Move declaration...
8436 * lisp.h (DEFSYM): ...here.
8437
8438 * gnutls.c:
8439 * minibuf.c:
8440 * w32menu.c:
8441 * w32proc.c:
8442 * w32select.c: Don't include character.h.
8443
8444 * alloc.c (syms_of_alloc):
8445 * buffer.c (syms_of_buffer):
8446 * bytecode.c (syms_of_bytecode):
8447 * callint.c (syms_of_callint):
8448 * casefiddle.c (syms_of_casefiddle):
8449 * casetab.c (init_casetab_once):
8450 * category.c (init_category_once, syms_of_category):
8451 * ccl.c (syms_of_ccl):
8452 * cmds.c (syms_of_cmds):
8453 * composite.c (syms_of_composite):
8454 * dbusbind.c (syms_of_dbusbind):
8455 * dired.c (syms_of_dired):
8456 * dispnew.c (syms_of_display):
8457 * doc.c (syms_of_doc):
8458 * editfns.c (syms_of_editfns):
8459 * emacs.c (syms_of_emacs):
8460 * eval.c (syms_of_eval):
8461 * fileio.c (syms_of_fileio):
8462 * fns.c (syms_of_fns):
8463 * frame.c (syms_of_frame):
8464 * fringe.c (syms_of_fringe):
8465 * insdel.c (syms_of_insdel):
8466 * keymap.c (syms_of_keymap):
8467 * lread.c (init_obarray, syms_of_lread):
8468 * macros.c (syms_of_macros):
8469 * msdos.c (syms_of_msdos):
8470 * print.c (syms_of_print):
8471 * process.c (syms_of_process):
8472 * search.c (syms_of_search):
8473 * sound.c (syms_of_sound):
8474 * syntax.c (init_syntax_once, syms_of_syntax):
8475 * terminal.c (syms_of_terminal):
8476 * textprop.c (syms_of_textprop):
8477 * undo.c (syms_of_undo):
8478 * w32.c (globals_of_w32):
8479 * window.c (syms_of_window):
8480 * xdisp.c (syms_of_xdisp):
8481 * xfaces.c (syms_of_xfaces):
8482 * xfns.c (syms_of_xfns):
8483 * xmenu.c (syms_of_xmenu):
8484 * xsettings.c (syms_of_xsettings):
8485 * xterm.c (syms_of_xterm): Use DEFSYM.
8486
4228cf16
TZ
84872011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8488
cd3520a4 8489 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8490
7fcccf1e
PE
84912011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8492
7efb4e0e
PE
8493 Integer and buffer overflow fixes (Bug#8873).
8494
ff5844ad
PE
8495 * print.c (printchar, strout): Check for string overflow.
8496 (PRINTPREPARE, printchar, strout):
8497 Don't set size unless allocation succeeds.
8498
90532f02
PE
8499 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8500 for sizes. Check for string overflow more accurately.
8501 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8502
6d84508d
PE
8503 * macros.c: Integer and buffer overflow fixes.
8504 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8505 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8506 Use ptrdiff_t, not int, for sizes.
8507 Don't increment bufsize until after realloc succeeds.
8508 Check for size-calculation overflow.
8509 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8510
437b2cb4
PE
8511 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8512
8b9ac8b4
PE
8513 * lread.c: Integer overflow fixes.
8514 (read_integer): Radix is now EMACS_INT, not int,
8515 to improve quality of diagnostics for out-of-range radices.
8516 Calculate buffer size correctly for out-of-range radices.
8517 (read1): Check for integer overflow in radices, and in
8518 read-circle numbers.
82cb60d3
PE
8519 (read_escape): Avoid int overflow.
8520 (Fload, openp, read_buffer_size, read1)
8521 (substitute_object_recurse, read_vector, read_list, map_obarray):
8522 Use ptrdiff_t, not int, for sizes.
8523 (read1): Use EMACS_INT, not int, for sizes.
20270765 8524 Check for size overflow.
8b9ac8b4 8525
7fcccf1e
PE
8526 * image.c (cache_image): Check for size arithmetic overflow.
8527
bfbbd7e7
PE
8528 * lread.c: Integer overflow issues.
8529 (saved_doc_string_size, saved_doc_string_length)
8530 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8531 Now ptrdiff_t, not int.
8532 (read1): Don't assume doc string length fits in int. Check for
8533 out-of-range doc string lengths.
8534 (read_list): Don't assume file position fits in int.
39019e54 8535 (read_escape): Check for hex character overflow.
bfbbd7e7 8536
4e323265
LL
85372011-06-22 Leo Liu <sdl.web@gmail.com>
8538
8539 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8540 Move to minibuffer.el.
8541
85fece3e
PE
85422011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8543
20b84ce9 8544 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8545 The following patches are for when GLYPH_DEBUG && !XASSERT.
8546 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8547 * dispnew.c (flush_stdout):
8548 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8549 Mark as externally visible.
8550 * dispnew.c (check_window_matrix_pointers): Now static.
8551 * dispnew.c (window_to_frame_vpos):
8552 * xfns.c (unwind_create_frame):
8553 * xterm.c (x_check_font): Remove unused local.
8554 * scroll.c (CHECK_BOUNDS):
8555 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8556 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8557 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8558 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8559 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8560 Now static.
8561 (debug_method_add): Use va_list and vsprintf rather than relying
8562 on undefined behavior with wrong number of arguments.
8563 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8564 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8565 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8566 since we're not interested in debugging glyphs with old libraries.
8567 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8568 GCC 4.6.0's static checking.
8569
0766b489
PE
85702011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8571
31fd4b32
PE
8572 Integer overflow and signedness fixes (Bug#8873).
8573 A few related buffer overrun fixes, too.
8574
b79e8648
PE
8575 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8576
0766b489
PE
8577 * dispextern.h (struct face.stipple):
8578 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8579 (x_bitmap_mask, x_allocate_bitmap_record)
8580 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8581 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8582 (x_create_bitmap_from_xpm_data):
8583 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8584 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8585 (.bitmaps_last):
8586 * xfaces.c (load_pixmap):
8587 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8588 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8589 (.bitmaps_last, struct x_output.icon_bitmap):
8590 Use ptrdiff_t, not int, for bitmap indexes.
8591 (x_allocate_bitmap_record): Check for size overflow.
8592 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8593
b081724f
PE
8594 Use ptrdiff_t, not int, for overlay counts.
8595 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8596 * editfns.c (overlays_around, get_pos_property):
8597 * textprop.c (get_char_property_and_overlay):
8598 * xdisp.c (next_overlay_change, note_mouse_highlight):
8599 * xfaces.c (face_at_buffer_position):
21514da7
PE
8600 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8601 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8602 (Fnext_overlay_change, Fprevious_overlay_change)
8603 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8604 Use ptrdiff_t, not int, for sizes.
21514da7 8605 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8606
3de73e5e
PE
8607 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8608
2606c57b
PE
8609 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8610 (x_session_initialize): Do not assume string length fits in int.
8611
aaafe47a
PE
8612 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8613 This is unlikely, but can occur if DPI is outlandish.
8614
2674ddc8 8615 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8616 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8617
28154962
PE
8618 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8619 * xrdb.c (magic_file_p, search_magic_path):
8620 Omit last arg SUFFIX; it was always 0. All callers changed.
8621 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8622
7de51af5
PE
8623 * xfont.c (xfont_match): Avoid need for strlen.
8624
25ed6cc3
PE
8625 * xfns.c: Don't assume strlen fits in int.
8626 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8627
4eab31dd
PE
8628 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8629 not unsigned long, as we prefer signed integers. All callers changed.
8630 Detect integer overflow in repeat count.
8631 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8632 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8633
171e2a58
PE
8634 * termcap.c: Don't assume sizes fit in int and never overflow.
8635 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8636 (gobble_line): Check for size-calculation overflow.
8637
ad39faca 8638 * minibuf.c (Fread_buffer):
6e5bb2dc 8639 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8640 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8641 Don't assume string length fits in int.
8642
52c61c22 8643 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8644 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8645
b5b8c9e5
PE
8646 * font.c: Don't assume string length fits in int.
8647 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8648 Use ptrdiff_t, not int.
ccd6111c
PE
8649 (font_intern_prop): Don't assume string length fits in int.
8650 Don't assume integer property fits in fixnum.
8651 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8652
882f0d81 8653 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8654 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8655 Reformulate so as not to need the command string.
8656 Invoke gzip -cd rather than gunzip, as it's more portable.
8657 (lock_info_type, lock_file_1, lock_file):
8658 Don't assume pid_t and time_t fit in unsigned long.
8659 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8660 (current_lock_owner): Prefer signed type for sizes.
8661 Use memcpy, not strncpy, where memcpy is what is really wanted.
8662 Don't assume (via atoi) that time_t and pid_t fit in int.
8663 Check for time_t and/or pid_t out of range, e.g., via a network share.
8664 Don't alloca where an auto var works fine.
8665
93f4cf88
PE
8666 * fileio.c: Fix some integer overflow issues.
8667 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8668 Don't assume string length fits in int.
8669 (directory_file_name): Don't assume string length fits in long.
8670 (make_temp_name): Don't assume pid fits in int, or that its print
8671 length is less than 20.
8672
f3e92b69
PE
8673 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8674
1bfdaf10
PE
8675 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8676
35016e9a
PE
8677 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8678
3d1e65a1
PE
8679 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8680 We prefer signed integers, even for size calculations.
8681
0b963a93
PE
8682 * emacs.c: Don't assume string length fits in 'int'.
8683 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8684 (main): Don't invoke strlen when not needed.
8685
573f4b54
PE
8686 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8687 (XD_DEBUG_MESSAGE): Don't waste a byte.
8688
989f33ba
PE
8689 * callproc.c (getenv_internal_1, getenv_internal)
8690 (Fgetenv_internal):
965d34eb
PE
8691 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8692
e4d29b33
PE
8693 * lread.c (invalid_syntax): Omit length argument.
8694 All uses changed. This doesn't fix a bug, but it simplifies the
8695 code away from its former Hollerith-constant appearance, and it's
8696 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8697 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8698
eb49b136
PE
8699 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8700 This didn't break anything, but it didn't help either.
8701 It's confusing to put a bogus integer in a place where the actual
8702 value does not matter.
9f62aeb1 8703 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8704 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8705
15375a22
PE
8706 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8707 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8708 implementation.
b61cc01c
PE
8709 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8710 We prefer signed types, and the value cannot exceed the EMACS_INT
8711 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8712 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8713 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8714 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8715
53b2623d
PE
8716 * indent.c (sane_tab_width): New function.
8717 (current_column, scan_for_column, Findent_to, position_indentation)
8718 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8719 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8720
51cab52b 8721 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8722
f2ed8a70
PE
8723 * lisp.h (lint_assume): New macro.
8724 * composite.c (composition_gstring_put_cache):
8725 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8726
abe80cc6
PE
8727 * editfns.c, insdel.c:
8728 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8729
b02c740e
PE
8730 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8731
ebc96716
PE
8732 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8733
b4e50fa0 8734 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8735 Use much-faster test for byte-length change.
311d5d7c 8736 Don't assume string byte-length fits in 'int'.
a4cf38e4 8737 Check that character arg fits in 'int'.
85461888 8738 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8739
c0c1ee9f
PE
8740 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8741
a498d7f4
PE
8742 * fns.c (concat): Catch string overflow earlier.
8743 Do not rely on integer wraparound.
8744
51cab52b
PE
8745 * dispextern.h (struct it.overlay_strings_charpos)
8746 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8747 * xdisp.c (forward_to_next_line_start)
8748 (back_to_previous_visible_line_start)
8749 (reseat_at_next_visible_line_start, next_element_from_buffer):
8750 Don't arbitrarily truncate the value of 'selective' to int.
8751
76031fad
PE
8752 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8753
5eb55db9
PE
8754 * composite.c: Don't truncate sizes to 'int'.
8755 (composition_gstring_p, composition_reseat_it)
8756 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8757 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8758 not EMACS_UINT, for indexes.
5eb55db9 8759
0703a717
PE
8760 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8761
d6202519
PE
8762 * buffer.c: Include <verify.h>.
8763 (struct sortvec.priority, struct sortstr.priority):
8961a454 8764 Now EMACS_INT, not int.
c20998a7 8765 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8766 (struct sortstr.size, record_overlay_string)
8767 (struct sortstrlist.size, struct sortlist.used):
8768 Don't truncate size to int.
8769 (record_overlay_string): Check for size-calculation overflow.
d6202519 8770 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8771
d5a19415
JM
87722011-06-22 Jim Meyering <meyering@redhat.com>
8773
029529ac 8774 Don't leak an XBM-image-sized buffer
d5a19415
JM
8775 * image.c (xbm_load): Free the image buffer after using it.
8776
a9041e6c
PE
87772011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8778
8779 Port to Sun C.
8780 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8781 that Sun C diagnosed.
8782 * fns.c (secure_hash): Fix pointer signedness issue.
8783 * intervals.c (static_offset_intervals): New function.
8784 (offset_intervals): Use it.
8785
7f3f739f
LL
87862011-06-21 Leo Liu <sdl.web@gmail.com>
8787
8788 * deps.mk (fns.o):
8789 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8790 sha512.h.
8791
8792 * fns.c (secure_hash): Rename from crypto_hash_function and change
8793 the first arg to accept symbols.
5b66d427 8794 (Fsecure_hash): New primitive.
7f3f739f
LL
8795 (syms_of_fns): New symbols.
8796
76147d94
DD
87972011-06-20 Deniz Dogan <deniz@dogan.se>
8798
8799 * process.c (Fset_process_buffer): Clarify return value in
8800 docstring.
8801
7d7d0045
CY
88022011-06-18 Chong Yidong <cyd@stupidchicken.com>
8803
8804 * dispnew.c (add_window_display_history): Use BVAR.
8805
8806 * xdisp.c (debug_method_add): Use BVAR.
8807 (check_window_end, dump_glyph_matrix, dump_glyph)
8808 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8809
8810 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8811 Likewise.
8812
8813 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8814 check till after the cache is created in init_frame_faces.
8815
ff2bc410
SM
88162011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8817
8818 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8819
28177add
PE
88202011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8821
dd3482fe
PE
8822 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8823 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8824 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8825
393d71f3 8826 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8827 * fileio.c (Finsert_file_contents):
8828 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8829 Remove the old (too-loose) buffer overflow checks.
8830 They weren't needed, since make_gap checks for buffer overflow.
8831 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8832 The old code merely checked for Emacs fixnum overflow, and relied
8833 on undefined (wraparound) behavior. The new code avoids undefined
8834 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8835
2e6813b0 8836 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8837 Tune. Don't use wider integers than needed. Don't use alloca.
8838 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8839
599a9e4f
PE
8840 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8841
99561444
PE
8842 * insdel.c, lisp.h (buffer_overflow): New function.
8843 (insert_from_buffer_1, replace_range, replace_range_2):
8844 * insdel.c (make_gap_larger):
8845 * editfns.c (Finsert_char):
8846 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8847
28177add
PE
8848 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8849
e69dafad
PE
88502011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8851
4baa020d 8852 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8853
b1c46f02
PE
8854 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8855 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8856
e69dafad
PE
8857 * fileio.c: Don't assume EMACS_INT fits in off_t.
8858 (emacs_lseek): New static function.
8859 (Finsert_file_contents, Fwrite_region): Use it.
8860 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8861
566684ea
PE
8862 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8863
e6966cd6
PE
8864 * fns.c: Don't overflow int when computing a list length.
8865 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8866 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8867 truncation on 64-bit hosts. Check for QUIT every
8868 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8869 faster and is responsive enough.
8870 (Flength): Report an error instead of overflowing an integer.
8871 (Fsafe_length): Return a float if the value is not representable
8872 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8873 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8874 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8875
dd0b0efb
PE
8876 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8877 (header_size, word_size): New constants.
8878 (allocate_vectorlike): Don't check size overflow here.
8879 (allocate_vector): Check it here instead, since this is the only
8880 caller of allocate_vectorlike that could cause overflow.
8881 Check that the new vector's length is representable as a fixnum.
8882
86fe5cfe
PE
8883 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8884 The previous code was bogus. For example, next_almost_prime (32)
8885 returned 39, which is undesirable as it is a multiple of 3; and
8886 next_almost_prime (24) returned 25, which is a multiple of 5 so
8887 why was the code bothering to check for multiples of 7?
8888
80e88859
PE
8889 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8890
4a2f0ad6
PE
8891 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8892
f66c7cf8
PE
8893 Variadic C functions now count arguments with ptrdiff_t.
8894 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8895 Back then I didn't know that the Emacs coding style prefers signed int.
8896 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8897 were being counted with int, which may truncate counts on 64-bit
8898 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8899 * lisp.h (struct Lisp_Subr.function.aMANY)
8900 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8901 Arg counts are now ptrdiff_t, not size_t.
8902 All variadic functions and their callers changed accordingly.
8903 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8904 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8905 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8906 * callint.c (Fcall_interactively): Check arg count for overflow,
8907 to avoid potential buffer overrun. Use signed char, not 'int',
8908 for 'varies' array, so that we needn't bother to check its size
8909 calculation for overflow.
8910 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8911 * eval.c (apply_lambda):
8912 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8913 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8914 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8915
a1759b76
PE
8916 * callint.c (Fcall_interactively): Don't use index var as event count.
8917
d96be9fc
PE
8918 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8919 * mem-limits.h (SIZE): Remove; no longer used.
8920
a690a978 8921 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8922
578c21e6
PE
8923 Remove unnecessary casts.
8924 * xterm.c (x_term_init):
8925 * xfns.c (x_set_border_pixel):
8926 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8927 These aren't needed now that we assume ANSI C.
8928
96f53c6c
PE
8929 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8930 It's more likely to cause problems (due to unsigned overflow)
8931 than to cure them.
8932
83c77d31
PE
8933 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8934
ee2079f1
PE
8935 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8936
6da65536
PE
8937 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8938
7147c4a4
PE
8939 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8940
193e32d9
PE
8941 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8942
e5533da6
PE
8943 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8944
9910e595
PE
8945 GLYPH_CODE_FACE returns EMACS_INT, not int.
8946 * dispextern.h (merge_faces):
8947 * xfaces.c (merge_faces):
01103c44
PE
8948 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8949 Don't assume EMACS_INT fits in int.
9910e595 8950
2638320e
PE
8951 * character.h (CHAR_VALID_P): Remove unused parameter.
8952 * fontset.c, lisp.h, xdisp.c: All uses changed.
8953
045eb8d9
PE
8954 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8955
c1f134b5
PE
8956 * fns.c (concat): Minor tuning based on overflow analysis.
8957 This doesn't fix any bugs. Use int to hold character, instead
8958 of constantly refetching from Emacs object. Use XFASTINT, not
8959 XINT, for value known to be a character. Don't bother comparing
8960 a single byte to 0400, as it's always less.
8961
395fcb93 8962 * floatfns.c (Fexpt):
327eeec8
PE
8963 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8964
abbd3d23
PE
8965 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8966 for characters.
8967
684a03ef
PE
8968 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8969
0fed43f3
PE
8970 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8971 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8972 incorrectly succeed when S was a string, because 4294967386 was
8973 truncated before it was used.
8974
8fd02eb7
PE
8975 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8976 Otherwise, an out-of-range integer could cause undefined behavior
8977 on a 64-bit host.
8978
f8c86b69
PE
8979 * composite.c: Use int, not EMACS_INT, for characters.
8980 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8981 EMACS_INT, for values that are known to be in character range.
8982 This doesn't fix any bugs but is the usual style inside Emacs and
8983 may generate better code on 32-bit machines.
8984
34206dd2
PE
8985 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8986 This is for reasons similar to the recent CHAR_STRING fix.
8987 * charset.c (Fencode_char): Check that character arg is actually
8988 a character. Pass an int to ENCODE_CHAR.
8989 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8990 wider than 'int', as a compile-time check to prevent future regressions
8991 in this area.
8992
c5958d4c 8993 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8994
8995 Make sure a 64-bit char is never passed to CHAR_STRING.
8996 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8997 by silently ignoring the top 32 bits, allowing some values
8998 that were far too large to be valid characters.
8999 * character.h: Include <verify.h>.
9000 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9001 arguments are no wider than unsigned, as a compile-time check
9002 to prevent future regressions in this area.
9003 * data.c (Faset):
01103c44 9004 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9005 (Fsubst_char_in_region):
9006 * fns.c (concat):
9007 * xdisp.c (decode_mode_spec_coding):
9008 Adjust to CHAR_STRING's new requirement.
9009 * editfns.c (Finsert_char, Fsubst_char_in_region):
9010 * fns.c (concat): Check that character args are actually
9011 characters. Without this test, these functions did the wrong
9012 thing with wildly out-of-range values on 64-bit hosts.
9013
d37ca623
PE
9014 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9015 These casts should not be needed on 32-bit hosts, either.
9016 * keyboard.c (read_char):
9017 * lread.c (Fload): Remove casts to unsigned.
9018
ea204efb
PE
9019 * lisp.h (UNSIGNED_CMP): New macro.
9020 This fixes comparison bugs on 64-bit hosts.
9021 (ASCII_CHAR_P): Use it.
9022 * casefiddle.c (casify_object):
01103c44 9023 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9024 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9025 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9026 * dispextern.h (FACE_FROM_ID):
9027 * keyboard.c (read_char): Use UNSIGNED_CMP.
9028
41cb286c
PE
9029 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9030 not to EMACS_INT, to avoid GCC warning.
9031
4a1b9832
PE
9032 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9033
55daad71
PE
9034 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9035 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9036 isn't needed on 32-bit machines.
8f95c75c 9037
01103c44
PE
9038 * buffer.c (Fgenerate_new_buffer_name):
9039 Use EMACS_INT for count, not int.
0ceccced 9040 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9041
9042 * data.c (Qcompiled_function): Now static.
9043
c6f072e7
PE
9044 * window.c (window_body_lines): Now static.
9045
20ce5912
PE
9046 * image.c (gif_load): Rename local to avoid shadowing.
9047
9c4c5f81
PE
9048 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9049 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9050 * alloc.c (make_save_value): Integer argument is now of type
9051 ptrdiff_t, not int.
9052 (mark_object): Use ptrdiff_t, not int.
9053 * lisp.h (pD): New macro.
9054 * print.c (print_object): Use it.
9055
c0c5c8ae
PE
9056 * alloc.c: Use EMACS_INT, not int, to count objects.
9057 (total_conses, total_markers, total_symbols, total_vector_size)
9058 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9059 (total_free_floats, total_floats, total_free_intervals)
9060 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9061 Now EMACS_INT, not int. All uses changed.
9062 (Fgarbage_collect): Compute overall total using a double, so that
9063 integer overflow is less likely to be a problem. Check for overflow
9064 when converting back to an integer.
5a25e253
PE
9065 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9066 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9067 These were 'int' variables that could overflow on 64-bit hosts;
9068 they were never used, so remove them instead of repairing them.
211a0b2a 9069 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9070 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9071 Previously, this ceilinged at INT_MAX, but that doesn't work on
9072 64-bit machines.
e46bb31a 9073 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9074
c78baabf 9075 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9076 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9077 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9078 when a (possibly-narrower) signed value would do just as well.
9079 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9080
c9d624c6
PE
9081 * alloc.c: Catch some string size overflows that we were missing.
9082 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9083 for convenience in STRING_BYTES_MAX.
9084 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9085 The definition here is exact; the one in lisp.h was approximate.
9086 (allocate_string_data): Check for string overflow. This catches
9087 some instances we weren't catching before. Also, it catches
9088 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9089 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9090 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9091
c9d624c6
PE
9092 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9093 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9094 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9095
353032ce
PE
9096 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9097
2bccce07
PE
9098 * alloc.c (Fmake_string): Check for out-of-range init.
9099
0ac30604
SM
91002011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9101
9102 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9103
c195f2de
JD
91042011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9105
9106 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9107 xg_get_default_scrollbar_width.
9108
9109 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9110 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9111 (style_changed_cb): Call update_theme_scrollbar_width and call
9112 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9113 all frames (Bug#8505).
9114 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9115 Call gtk_window_set_resizable if HAVE_GTK3.
9116 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9117 and height if HAVE_GTK3 (Bug#8505).
9118 (scroll_bar_width_for_theme): New variable.
9119 (update_theme_scrollbar_width): New function.
9120 (xg_get_default_scrollbar_width): Move code to
9121 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9122 (xg_initialize): Call update_theme_scrollbar_width.
9123
9124 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9125
9126 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9127
e10ac9f1
MR
91282011-06-12 Martin Rudalics <rudalics@gmx.at>
9129
9130 * frame.c (make_frame): Call other_buffer_safely instead of
9131 other_buffer.
9132
9133 * window.c (temp_output_buffer_show): Call display_buffer with
9134 second argument Vtemp_buffer_show_specifiers and reset latter
9135 immediately after the call.
9136 (Vtemp_buffer_show_specifiers): New variable.
9137 (auto_window_vscroll_p, next_screen_context_lines)
9138 (Vscroll_preserve_screen_position): Remove leading asterisks from
9139 doc-strings.
9140
2d3c217e 91412011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9142
7b7f97e8 9143 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9144 * buffer.c (Qclone_number): Remove for now, as it's unused.
9145 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9146 (record_buffer): Remove unused local.
9147 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9148 (set_frame_buffer_list): Remove; unused.
9149 * frame.h (other_visible_frames): Remove decl.
9150 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9151 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9152 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9153 if HAVE_GPM.
9154 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9155 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9156 Define only if HAVE_GPM.
9157 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9158 (update_hints_inhibit): Remove; never set. All uses removed.
9159 * widgetprv.h (emacsFrameClassRec): Remove decl.
9160 * window.c (delete_deletable_window): Now returns void, since it
9161 wasn't returning anything.
9162 (compare_window_configurations): Remove unused locals.
9163 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9164 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9165 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9166 the same widths as pointers. This follows up on the 2011-05-06 patch.
9167 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9168 * xterm.h: Likewise.
9169 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9170
1384b89e
JB
91712011-06-12 Juanma Barranquero <lekktu@gmail.com>
9172
9173 * makefile.w32-in: Update dependencies.
9174 (LISP_H): Add lib/intprops.h.
9175
1100a63c
CY
91762011-06-11 Chong Yidong <cyd@stupidchicken.com>
9177
9178 * image.c (gif_load): Add animation frame delay to the metadata.
9179 (syms_of_image): Use DEFSYM. New symbol `delay'.
9180
6198ccd0
MR
91812011-06-11 Martin Rudalics <rudalics@gmx.at>
9182
9183 * window.c (delete_deletable_window): Re-add.
9184 (Fset_window_configuration): Rewrite to handle dead buffers and
9185 consequently deletable windows.
9186 (window_tree, Fwindow_tree): Remove. Supply functionality in
9187 window.el.
9188 (compare_window_configurations): Simplify code.
9189
b6e3633c
AS
91902011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9191
1ab0dee5
AS
9192 * image.c (imagemagick_load_image): Fix type mismatch.
9193 (Fimagemagick_types): Likewise.
9194
b6e3633c
AS
9195 * window.h (replace_buffer_in_windows): Declare.
9196
9397e56f
MR
91972011-06-11 Martin Rudalics <rudalics@gmx.at>
9198
9199 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9200 Qclone_number. Remove external declaration of Qdelete_window.
9201 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9202 code.
640c8776
SM
9203 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9204 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9205 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9206 buffer list implementation.
9207 (other_buffer_safely): New function.
9208 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9209 calls to replace_buffer_in_windows and
9210 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9211 if allowed.
9212 (record_buffer): Inhibit quitting and rewrite using quittable
9213 functions. Run Qbuffer_list_update_hook if allowed.
9214 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9215 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9216 Move switch-to-buffer to window.el.
9397e56f
MR
9217 (bury-buffer): Move to window.el.
9218 (Vbuffer_list_update_hook): New variable.
9219
9220 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9221 section.
9222
9223 * window.h (resize_frame_windows): Move up in code.
9224 (Fwindow_frame): Remove EXFUN.
9225 (replace_buffer_in_all_windows): Remove prototype.
9226 (replace_buffer_in_windows_safely): Add prototype.
9227
9228 * window.c: Declare Qdelete_window static again. Move down
9229 declaration of select_count.
9230 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9231 (Fother_window): Move to window.el.
9232 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9233 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9234 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9235 window.el.
9236 (replace_buffer_in_windows): Implement by calling
9237 Qreplace_buffer_in_windows.
9238 (replace_buffer_in_all_windows): Remove with some functionality
9239 moved into replace_buffer_in_windows_safely.
9240 (replace_buffer_in_windows_safely): New function.
9241 (select_window_norecord, select_frame_norecord): Move in front
9242 of run_window_configuration_change_hook. Remove now obsolete
9243 declarations.
640c8776
SM
9244 (Fset_window_buffer): Rewrite doc-string.
9245 Call Qrecord_window_buffer.
9397e56f
MR
9246 (keys_of_window): Move binding for other-window to window.el.
9247
b50691aa
CY
92482011-06-11 Chong Yidong <cyd@stupidchicken.com>
9249
9250 * dispextern.h (struct image): Replace data member, whose int_val
9251 and ptr_val fields were not used by anything, with a single
9252 lisp_val object.
9253
9254 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9255 (gif_clear_image, gif_load, imagemagick_load_image)
9256 (gs_clear_image, gs_load): Callers changed.
9257
3f754b86
PE
92582011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9259
cca69397
PE
9260 * buffer.h: Include <time.h>, for time_t.
9261 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9262
109e28d0
PE
9263 Fix minor problems found by static checking.
9264
60737f02
PE
9265 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9266
4b66faf3
PE
9267 Make identifiers static if they are not used in other modules.
9268 * data.c (Qcompiled_function, Qframe, Qvector):
9269 * image.c (QimageMagick, Qsvg):
9270 * minibuf.c (Qmetadata):
9271 * window.c (resize_window_check, resize_root_window): Now static.
9272 * window.h (resize_window_check, resize_root_window): Remove decls.
9273
109e28d0
PE
9274 * window.c (window_deletion_count, delete_deletable_window):
9275 Remove; unused.
46a4ce9e
PE
9276 (window_body_lines): Now static.
9277 (Fdelete_other_windows_internal): Mark vars as initialized.
9278 Make sure 'resize_failed' is initialized.
9279 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9280 (resize_window_apply): Remove unused local.
9281 * window.h (delete_deletable_window): Remove decl.
9282
109e28d0 9283 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9284 (imagemagick_load_image): Fix pointer signedness problem by changing
9285 last arg from unsigned char * to char *. All uses changed.
9286 Also, fix a local for similar reasons.
9287 Remove unused locals. Remove locals to avoid shadowing.
9288 (fn_rsvg_handle_free): Remove; unused.
9289 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9290 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9291
3f754b86
PE
9292 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9293
2547adb1
CY
92942011-06-10 Chong Yidong <cyd@stupidchicken.com>
9295
9296 * image.c (gif_load): Fix omitted cast error introduced by
9297 2011-06-06 change.
9298
2c8e37d4
MR
92992011-06-10 Martin Rudalics <rudalics@gmx.at>
9300
9301 * window.h (resize_proportionally, orig_total_lines)
9302 (orig_top_line): Remove from window structure.
9303 (set_window_height, set_window_width, change_window_heights)
9304 (Fdelete_window): Remove prototypes.
9305 (resize_frame_windows): Remove duplicate declaration.
9306
440a42e3
EZ
93072011-06-10 Eli Zaretskii <eliz@gnu.org>
9308
9309 * window.h (resize_frame_windows, resize_window_check)
9310 (delete_deletable_window, resize_root_window)
9311 (resize_frame_windows): Declare prototypes.
9312
9313 * window.c (resize_window_apply): Make definition be "static" to
9314 match the prototype.
9315
562dd5e9
MR
93162011-06-10 Martin Rudalics <rudalics@gmx.at>
9317
9318 * window.c: Remove declarations of Qwindow_size_fixed,
9319 window_min_size_1, window_min_size_2, window_min_size,
9320 size_window, window_fixed_size_p, enlarge_window, delete_window.
9321 Remove static from declaration of Qdelete_window, it's
9322 temporarily needed by Fbury_buffer.
9323 (replace_window): Don't assign orig_top_line and
9324 orig_total_lines.
9325 (Fdelete_window, delete_window): Remove. Window deletion is
9326 handled by window.el.
640c8776
SM
9327 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9328 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9329 (Fdelete_other_windows): Remove. Deleting other windows is
9330 handled by window.el.
9331 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9332 handled in window.el.
9333 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9334 Window minimum sizes are handled in window.el.
9335 (shrink_windows, size_window, set_window_height)
9336 (set_window_width, change_window_heights, window_height)
9337 (window_width, CURBEG, CURSIZE, enlarge_window)
9338 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9339 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9340 handled in window.el.
9341 (make_dummy_parent): Rename to make_parent_window and give it a
9342 second argument horflag.
9343 (make_window): Don't set resize_proportionally any more.
9344 (Fsplit_window): Remove. Windows are split in window.el.
9345 (save_restore_action, save_restore_orig_size)
9346 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9347 Resize mini windows in window.el.
9348 (grow_mini_window, shrink_mini_window): Implement by calling
9349 Qresize_root_window_vertically, resize_window_check and
9350 resize_window_apply.
640c8776
SM
9351 (saved_window, Fset_window_configuration, save_window_save):
9352 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9353 resize_proportionally.
9354 (window_min_height, window_min_width): Move to window.el.
9355 (keys_of_window): Move bindings for delete-other-windows,
9356 split-window, delete-window and enlarge-window to window.el.
9357
9358 * buffer.c: Temporarily extern Qdelete_window.
9359 (Fbury_buffer): Temporarily call Qdelete_window instead of
9360 Fdelete_window (Fbury_buffer will move to window.el soon).
9361
9362 * frame.c (set_menu_bar_lines_1): Remove code handling
9363 orig_top_line and orig_total_lines.
9364
9365 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9366 set_window_height but set heights directly.
9367 (change_frame_size_1): Use resize_frame_windows.
9368
9369 * xdisp.c (init_xdisp): Don't use set_window_height but set
9370 heights directly.
9371
640c8776
SM
9372 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9373 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9374 run_window_configuration_change_hook.
9375
9376 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9377 instead of change_window_heights and run
9378 run_window_configuration_change_hook.
9379
1a13852e
MR
93802011-06-09 Martin Rudalics <rudalics@gmx.at>
9381
9382 * window.c (replace_window): Rename second argument REPLACEMENT to
9383 NEW. New third argument SETFLAG. Rewrite.
9384 (delete_window, make_dummy_parent): Call replace_window with
9385 third argument 1.
9386 (window_list_1): Move down in code.
9387 (run_window_configuration_change_hook): Move set_buffer part
9388 before select_frame_norecord part in order to unwind correctly.
9389 Rename count1 to count.
9390 (recombine_windows, delete_deletable_window, resize_root_window)
9391 (Fdelete_other_windows_internal)
9392 (Frun_window_configuration_change_hook, make_parent_window)
9393 (resize_window_check, resize_window_apply, Fresize_window_apply)
9394 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9395 (Fdelete_window_internal, Fresize_mini_window_internal):
9396 New functions.
1a13852e
MR
9397 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9398
f3d1777e
MR
93992011-06-08 Martin Rudalics <rudalics@gmx.at>
9400
496e208e
MR
9401 * window.h (window): Add some new members to window structure -
9402 normal_lines, normal_cols, new_total, new_normal, clone_number,
9403 splits, nest, prev_buffers, next_buffers.
9404 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9405 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9406
f3d1777e
MR
9407 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9408 Remove.
496e208e
MR
9409 (make_dummy_parent): Set new members of windows structure.
9410 (make_window): Move down in code. Handle new members of window
9411 structure.
9412 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9413 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9414 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9415 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9416 (Fset_window_next_buffers, Fset_window_clone_number):
9417 New functions.
496e208e
MR
9418 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9419 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9420 Doc-string fixes.
9421 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9422 Argument WINDOW can be now internal window too.
9423 (Fwindow_use_time): Move up in code.
9424 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9425 Rewrite doc-string.
9426 (Fset_window_configuration, saved_window)
9427 (Fcurrent_window_configuration, save_window_save): Handle new
9428 members of window structure.
b9e809c2
MR
9429 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9430 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9431 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9432 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9433 Qget_mru_window, Qresize_root_window,
9434 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9435 Qauto_buffer_name; staticpro them.
f3d1777e 9436
abde8f8c
MR
94372011-06-07 Martin Rudalics <rudalics@gmx.at>
9438
9439 * window.c (Fwindow_total_size, Fwindow_left_column)
9440 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9441 (Fwindow_list_1): New functions.
9442 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9443 (Fwindow_width, Fscroll_left, Fscroll_right):
9444 Use window_body_cols instead of window_box_text_cols.
9445 (delete_window, Fset_window_configuration):
9446 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9447 (delete_all_subwindows): Take a window as argument and not a
9448 structure. Rewrite.
190b47e6
MR
9449 (window_loop): Remove handling of GET_LRU_WINDOW and
9450 GET_LARGEST_WINDOW.
9451 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9452
9453 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9454 window_box_text_cols. delete_all_subwindows now takes a
9455 Lisp_Object as argument.
abde8f8c 9456
640c8776
SM
9457 * indent.c (compute_motion, Fcompute_motion):
9458 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9459
fa8a67e6
MR
9460 * frame.c (delete_frame): Call delete_all_subwindows with root
9461 window as argument.
9462
a54e3482
DC
94632011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9464
9465 * fns.c (Fputhash): Document return value.
9466
60002bf5
CY
94672011-06-06 Chong Yidong <cyd@stupidchicken.com>
9468
9469 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9470
0c671da6 94712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9472
b862a52a 9473 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9474
be44ca6c
PE
9475 Check for overflow when converting integer to cons and back.
9476 * charset.c (Fdefine_charset_internal, Fdecode_char):
9477 Use cons_to_unsigned to catch overflow.
9478 (Fencode_char): Use INTEGER_TO_CONS.
9479 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9480 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9481 * data.c (long_to_cons, cons_to_long): Remove.
9482 (cons_to_unsigned, cons_to_signed): New functions.
9483 These signal an error for invalid or out-of-range values.
9484 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9485 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9486 * font.c (Ffont_variation_glyphs):
9487 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9488 * lisp.h: Include <intprops.h>.
9489 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9490 (cons_to_signed, cons_to_unsigned): New decls.
9491 (long_to_cons, cons_to_long): Remove decls.
9492 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9493 (Fprimitive_undo): Use CONS_TO_INTEGER.
9494 * xfns.c (Fx_window_property): Likewise.
9495 * xselect.c: Include <limits.h>.
9496 (x_own_selection, selection_data_to_lisp_data):
9497 Use INTEGER_TO_CONS.
9498 (x_handle_selection_request, x_handle_selection_clear)
9499 (x_get_foreign_selection, Fx_disown_selection_internal)
9500 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9501 (lisp_data_to_selection_data): Use cons_to_unsigned.
9502 (x_fill_property_data): Use cons_to_signed.
9503 Report values out of range.
9504
d1f3d2af
PE
9505 Check for buffer and string overflow more precisely.
9506 * buffer.h (BUF_BYTES_MAX): New macro.
9507 * lisp.h (STRING_BYTES_MAX): New macro.
9508 * alloc.c (Fmake_string):
9509 * character.c (string_escape_byte8):
9510 * coding.c (coding_alloc_by_realloc):
9511 * doprnt.c (doprnt):
9512 * editfns.c (Fformat):
9513 * eval.c (verror):
9514 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9515 since they may not be the same number.
9516 * editfns.c (Finsert_char):
9517 * fileio.c (Finsert_file_contents):
9518 Likewise for BUF_BYTES_MAX.
9519
dd52fcea
PE
9520 * image.c: Use ptrdiff_t, not int, for sizes.
9521 (slurp_file): Switch from int to ptrdiff_t.
9522 All uses changed.
9523 (slurp_file): Check that file size fits in both size_t (for
9524 malloc) and ptrdiff_t (for sanity and safety).
9525
7f9bbdbb
PE
9526 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9527 if b->modtime has its maximal value.
9528
dfe18f82
PE
9529 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9530
84acfcf0
PE
9531 Don't assume time_t can fit into int.
9532 * buffer.h (struct buffer.modtime): Now time_t, not int.
9533 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9534 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9535
ccd9a01a
PE
9536 Minor fixes for signed vs unsigned integers.
9537 * character.h (MAYBE_UNIFY_CHAR):
9538 * charset.c (maybe_unify_char):
9539 * keyboard.c (read_char, reorder_modifiers):
9540 XINT -> XFASTINT, since the integer must be nonnegative.
9541 * ftfont.c (ftfont_spec_pattern):
9542 * keymap.c (access_keymap, silly_event_symbol_error):
9543 XUINT -> XFASTINT, since the integer must be nonnegative.
9544 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9545 since it makes no difference and we prefer signed.
9546 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9547 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9548 nonnegative.
9549
d6d100dd
SM
95502011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9551
9552 * window.h (Fwindow_frame): Declare.
9553
2b6148e4
PE
95542011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9555
9556 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9557 (SPARE_MEMORY): Always define.
9558 (LARGE_REQUEST): Remove.
9559 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9560
f230ecc9
MR
95612011-06-06 Martin Rudalics <rudalics@gmx.at>
9562
727e958e
MR
9563 * lisp.h: Move EXFUNS for Fframe_root_window,
9564 Fframe_first_window and Fset_frame_selected_window to window.h.
9565
9566 * window.h: Move EXFUNS for Fframe_root_window,
9567 Fframe_first_window and Fset_frame_selected_window here from
9568 lisp.h.
9569
9570 * frame.c (Fwindow_frame, Fframe_first_window)
9571 (Fframe_root_window, Fframe_selected_window)
9572 (Fset_frame_selected_window): Move to window.c.
9573 (Factive_minibuffer_window): Move to minibuf.c.
9574 (Fother_visible_frames_p): New function.
9575
9576 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9577
f230ecc9
MR
9578 * window.c (decode_window, decode_any_window): Move up in code.
9579 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9580 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9581 (Fwindow_buffer): Move up and rewrite doc-string.
9582 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9583 (Fwindow_prev): New functions.
727e958e
MR
9584 (Fwindow_frame): Move here from frame.c. Accept any window as
9585 argument.
9586 (Fframe_root_window, Fframe_first_window)
9587 (Fframe_selected_window): Move here from frame.c. Accept frame
9588 or arbitrary window as argument. Update doc-strings.
9589 (Fminibuffer_window): Move up in code.
9590 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9591 (Fset_frame_selected_window): Move here from frame.c.
9592 Marginal rewrite.
727e958e
MR
9593 (Fselected_window, select_window, Fselect_window): Move up in
9594 code. Minor doc-string fixes.
f230ecc9 9595
4d09bcf6
PE
95962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9597
9598 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9599 Do not assume that spare memory exists; that assumption is valid
9600 only if SYSTEM_MALLOC.
9601 (LARGE_REQUEST): New macro, so that the issue of large requests
9602 is separated from the issue of spare memory.
9603
810928a2
AS
96042011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9605
172418ad
AS
9606 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9607 format. (Bug#8806)
9608
43f862f7
AS
9609 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9610
810928a2
AS
9611 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9612 before statements.
9613
a059fe24
JD
96142011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9615
9616 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9617
9618 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9619
9620 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9621 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9622
989bf368
JB
96232011-06-05 Juanma Barranquero <lekktu@gmail.com>
9624
9625 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9626
4b80f674
CY
96272011-06-04 Chong Yidong <cyd@stupidchicken.com>
9628
9629 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9630 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9631 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9632 New error handlers.
4b80f674
CY
9633 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9634 Obey Vx_select_enable_clipboard_manager. Catch errors in
9635 x_clipboard_manager_save (Bug#8779).
9636 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9637 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9638
99a33b77 96392011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9640
9641 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9642
99a33b77 96432011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9644
9645 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9646 in the current matrix if keep_current_p is non-zero.
9647
8264569d
EZ
96482011-06-04 Eli Zaretskii <eliz@gnu.org>
9649
9650 * bidi.c (bidi_level_of_next_char): Fix last change.
9651
57f97249
EZ
96522011-06-03 Eli Zaretskii <eliz@gnu.org>
9653
fec2107c 9654 Support bidi reordering of text covered by display properties.
57f97249 9655
fec2107c
EZ
9656 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9657 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9658 (bidi_cache_search, bidi_cache_iterator_state)
9659 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9660 (bidi_level_of_next_char, bidi_move_to_visually_next):
9661 Support character positions inside a run of characters covered by a
fec2107c
EZ
9662 display string.
9663 (bidi_paragraph_init, bidi_resolve_explicit_1)
9664 (bidi_level_of_next_char): Call bidi_fetch_char and
9665 bidi_fetch_char_advance instead of FETCH_CHAR and
9666 FETCH_CHAR_ADVANCE.
9667 (bidi_init_it): Initialize new members.
9668 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9669 definitions.
9670 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9671 instead of using explicit *_CHAR codes.
d6d100dd
SM
9672 (bidi_resolve_explicit, bidi_resolve_weak):
9673 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9674 bidirectional text is supported only in multibyte buffers.
9675 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9676 it to initialize the frame_window_p member of struct bidi_it.
9677 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9678 (bidi_resolve_explicit, bidi_resolve_weak)
9679 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9680 bidi_it->nchars is non-positive.
9681 (bidi_level_of_next_char): Don't try to lookup the cache for the
9682 next/previous character if nothing is cached there yet, or if we
9683 were just reseat()'ed to a new position.
c40e2fb2 9684
0e14fe90
EZ
9685 * xdisp.c (set_cursor_from_row): Set start and stop points
9686 according to the row's direction when priming the loop that looks
9687 for the glyph on which to display cursor.
9688 (single_display_spec_intangible_p): Function deleted.
9689 (display_prop_intangible_p): Reimplement to call
9690 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9691 Accept 3 additional arguments needed by handle_display_spec.
9692 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9693 values: lists, `(when COND...)' forms, etc.
9694 (single_display_spec_string_p): Support property values that are
9695 lists with the argument STRING its top-level element.
9696 (display_prop_string_p): Fix the condition for processing a
9697 property that is a list to be consistent with handle_display_spec.
fec2107c 9698 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9699 last portion of handle_display_prop.
9700 (compute_display_string_pos): Accept additional argument
9701 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9702 value of a `display' property is a "replacing spec".
9703 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9704 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9705 the display property, but just return a value indicating whether
9706 the display property will replace the characters it covers.
9707 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9708 frame_window_p members of struct bidi_it.
d6d100dd
SM
9709 (compute_display_string_pos, compute_display_string_end):
9710 New functions.
fec2107c
EZ
9711 (push_it): Accept second argument POSITION, where pop_it should
9712 jump to continue iteration.
9713 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9714
fec2107c
EZ
9715 * keyboard.c (adjust_point_for_property): Adjust the call to
9716 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9717
9718 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9719 (bidi_init_it): Update prototypes.
9720 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9721 (compute_display_string_pos, compute_display_string_end):
9722 Declare prototypes.
fec2107c
EZ
9723 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9724 EMACS_INT.
fc6f18ce 9725
40087514 97262011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9727
57f53182
PE
9728 Malloc failure behavior now depends on size of allocation.
9729 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9730 * lisp.h: Change signatures accordingly.
9731 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9732 All callers changed. (Bug#8762)
9733
9734 * gnutls.c: Use Emacs's memory allocators.
9735 Without this change, the gnutls library would invoke malloc etc.
9736 directly, which causes problems on non-SYNC_INPUT hosts, and which
9737 runs afoul of improving memory_full behavior. (Bug#8761)
9738 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9739 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9740 xfree instead of the default malloc, realloc, free.
9741 (Fgnutls_boot): No need to check for memory allocation failure,
9742 since xmalloc does that for us.
9743
ac32cd99 9744 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9745 * category.c (hash_get_category_set):
9746 * ccl.c (ccl_driver):
9747 * charset.c (Fdefine_charset_internal):
9748 * charset.h (struct charset.hash_index):
9749 * composite.c (get_composition_id, gstring_lookup_cache)
9750 (composition_gstring_put_cache):
9751 * composite.h (struct composition.hash_index):
9752 * dispextern.h (struct image.hash):
9753 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9754 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9755 (hashfn_equal, hashfn_user_defined, make_hash_table)
9756 (maybe_resize_hash_table, hash_lookup, hash_put)
9757 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9758 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9759 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9760 * image.c (make_image, search_image_cache, lookup_image)
9761 (xpm_put_color_table_h):
9762 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9763 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9764 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9765 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9766 * alloc.c (allocate_vectorlike):
9767 Check for overflow in vector size calculations.
9768 * ccl.c (ccl_driver):
9769 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9770 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9771 need to be updated by these changes.
40087514
PE
9772 * fns.c (make_hash_table, maybe_resize_hash_table):
9773 Check for integer overflow with large hash tables.
0de4bb68
PE
9774 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9775 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9776 (SXHASH_REDUCE): New macro.
9777 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9778 Use it instead of discarding useful hash info with large hash values.
9779 (sxhash_float): New function.
9780 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9781 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9782 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9783 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9784 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9785 Adjust signatures to match updated version of code.
9786 (consing_since_gc): Now EMACS_INT, since a single hash table can
9787 use more than INT_MAX bytes.
9788
698d32e2
DN
97892011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9790
9791 Make it possible to build with GCC-4.6+ -O2 -flto.
9792
9793 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9794
fd6fa53f
SM
97952011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9796
9797 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9798 Call minibuffer-inactive-mode.
9799
864db017
JB
98002011-05-31 Juanma Barranquero <lekktu@gmail.com>
9801
9802 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9803 Update dependencies.
9804
2ad0baf4
DN
98052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9806
9807 * data.c (init_data): Remove code for UTS, this system is not
9808 supported anymore.
9809
4fcc2638
DN
98102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9811
9812 Don't force ./temacs to start in terminal mode.
9813
9814 * frame.c (make_initial_frame): Initialize faces in all cases, not
9815 only when CANNOT_DUMP is defined.
9816 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9817
c56e0fd5
DN
98182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9819
9820 * dispnew.c (add_window_display_history): Use const for the string
9821 pointer. Remove declaration, not needed.
9822
333d54da 98232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9824
55d4c1b2 9825 Use 'inline', not 'INLINE'.
333d54da 9826 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9827 * alloc.c, fontset.c (INLINE): Remove.
9828 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9829 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9830 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9831 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9832 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9833
738db178
DN
98342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9835
9836 Make it possible to run ./temacs.
9837
9838 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9839 syms_of_callproc does the same thing. Remove test for
9840 "initialized", do it in the caller.
9841 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9842
620c53a6
SM
98432011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9844
9845 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9846 (read_minibuf): Use get_minibuffer.
9847 (syms_of_minibuf): Use DEFSYM.
9848 (Qmetadata): New var.
9849 * data.c (Qbuffer): Don't make it static.
9850 (syms_of_data): Use DEFSYM.
9851
e003a292
PE
98522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9853
9854 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9855 (CCL_CODE_MIN): New macro.
9856
ed008a6d
PE
98572011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9858
3687c2ef
PE
9859 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9860
ed008a6d
PE
9861 * eval.c (Qdebug): Now static.
9862 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9863 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9864 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9865
d66c4c7c
CY
98662011-05-29 Chong Yidong <cyd@stupidchicken.com>
9867
9868 * image.c: Various fixes to ImageMagick code comments.
9869 (Fimagemagick_types): Doc fix.
9870
5fbc2025
PE
98712011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9872
0196f88a
PE
9873 Minor fixes prompted by GCC 4.6.0 warnings.
9874
9875 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9876
5fbc2025
PE
9877 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9878 (x_clipboard_manager_save_all): Move extern decl to ...
9879 * xterm.h: ... here, so that it can be checked for consistency.
9880
1dd3c2d9
CY
98812011-05-29 Chong Yidong <cyd@stupidchicken.com>
9882
9883 * xselect.c (x_clipboard_manager_save_frame)
9884 (x_clipboard_manager_save_all): New functions.
9885 (Fx_clipboard_manager_save): Lisp function deleted.
9886
9887 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9888 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9889
9890 * xterm.h: Update prototype.
9891
5ba6571d
WX
98922011-05-28 William Xu <william.xwl@gmail.com>
9893
9894 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9895 exiting (Bug#8239).
9896
3eaff834
JM
98972011-05-28 Jim Meyering <meyering@redhat.com>
9898
e1900994 9899 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9900 * fns.c (to_uchar): Define.
9901 (crypto_hash_function): Use it to convert some newly-signed
9902 variables to unsigned, to avoid sign-extension bugs. For example,
9903 without this change, (md5 "truc") would evaluate to
9904 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9905 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9906 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9907
0f6990a7
PE
99082011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9909
9910 Integer overflow fixes.
c8a9ca5a 9911
08686060
PE
9912 * dbusbind.c: Serial number integer overflow fixes.
9913 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9914 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9915 to hold a serial number that is too large for a fixnum.
9916 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9917 Check for serial numbers out of range. Decode any serial number
59568bf0 9918 that was so large that it became a float. (Bug#8722)
08686060 9919
2d1fc3c7
PE
9920 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9921 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9922 Use XFASTINT rather than XUINT when numbers are nonnegative.
9923 (xd_append_arg, Fdbus_method_return_internal):
9924 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9925 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9926 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9927 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9928 (Bug#8722)
2d1fc3c7 9929
c8a9ca5a
PE
9930 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9931
519e1d69
PE
9932 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9933
6df6ae42 9934 ccl: Add integer overflow checks.
30569699
PE
9935 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9936 (IN_INT_RANGE): New macros.
9937 (ccl_driver): Use them to check for integer overflow when
9938 decoding a CCL program. Many of the new checks are whether XINT (x)
9939 fits in int; it doesn't always, on 64-bit hosts. The new version
9940 doesn't catch all possible integer overflows, but it's an
847044ea 9941 improvement. (Bug#8719)
30569699 9942
c11285dc
PE
9943 * alloc.c (make_event_array): Use XINT, not XUINT.
9944 There's no need for unsigned here.
9945
fdccd48e
PE
9946 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9947 This follows up to the 2011-05-06 change that substituted uintptr_t
9948 for EMACS_INT. This case wasn't caught back then.
9949
37910ab2
PE
9950 Rework Fformat to avoid integer overflow issues.
9951 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9952 now (part of C89). Include <verify.h>.
9953 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9954 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9955 (Fformat): Avoid the prepass trying to compute sizes; it was only
9956 approximate and thus did not catch overflow reliably. Instead, walk
9957 through the format just once, formatting and computing sizes as we go,
9958 checking for integer overflow at every step, and allocating a larger
9959 buffer as needed. Keep track separately whether the format is
9960 multibyte. Keep only the most-recently calculated precision, rather
9961 than them all. Record whether each argument has been converted to
9962 string. Use EMACS_INT, not int, for byte and char and arg counts.
9963 Support field widths and precisions larger than INT_MAX. Avoid
9964 sprintf's undefined behavior with conversion specifications such as %#d
9965 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9966 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9967 formatting out-of-range floating point numbers with int
9173deec 9968 formats. (Bug#8668)
37910ab2 9969
2e6578fb
PE
9970 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9971
0ae6bdee
PE
9972 * data.c: Avoid integer truncation in expressions involving floats.
9973 * data.c: Include <intprops.h>.
9974 (arith_driver): When there's an integer overflow in an expression
9975 involving floating point, convert the integers to floating point
9976 so that the resulting value does not suffer from catastrophic
9977 integer truncation. For example, on a 64-bit host (* 4
9978 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9979 Do not rely on undefined behavior after integer overflow.
9980
de883a70
PE
9981 merge count_size_as_multibyte, parse_str_to_multibyte
9982 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9983 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9984 Check for integer overflow.
9985 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9986 since it's now a duplicate of the other. This is more of
9987 a character than a buffer op, so better that it's in character.c.
9988 * fns.c, print.c: Adjust to above changes.
9989
2ff916cb
PE
99902011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9991
9992 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9993
f1b54466
PE
99942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9995
fb1ac845
PE
9996 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9997 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9998 (x_clipboard_manager_save): Now static.
9999 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10000
f1b54466
PE
10001 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10002 (crypto_hash_function): Now static.
10003 Fix pointer signedness problems. Avoid unnecessary initializations.
10004
a9f737ee
CY
100052011-05-27 Chong Yidong <cyd@stupidchicken.com>
10006
10007 * termhooks.h (Vselection_alist): Make it terminal-local.
10008
10009 * terminal.c (create_terminal): Initialize it.
10010
10011 * xselect.c: Support for clipboard managers.
10012 (Vselection_alist): Move to termhooks.h as terminal-local var.
10013 (LOCAL_SELECTION): New macro.
10014 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10015 (symbol_to_x_atom): Remove gratuitous arg.
10016 (x_handle_selection_request, lisp_data_to_selection_data)
10017 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10018 (x_own_selection, x_get_local_selection, x_convert_selection):
10019 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10020 (some_frame_on_display): Delete unused function.
10021 (Fx_own_selection_internal, Fx_get_selection_internal)
10022 (Fx_disown_selection_internal, Fx_selection_owner_p)
10023 (Fx_selection_exists_p): New optional frame arg.
10024 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10025 (x_handle_selection_clear): Don't treat other terminals with the
10026 same keyboard specially. Use the terminal-local Vselection_alist.
10027 (x_clear_frame_selections): Use Frun_hook_with_args.
10028
10029 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10030
10031 * xterm.h: Add support for those atoms.
10032
e067f0c1
CY
100332011-05-26 Chong Yidong <cyd@stupidchicken.com>
10034
10035 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10036 (converted_selections, conversion_fail_tag): New global variables.
10037 (x_selection_request_lisp_error): Free the above.
10038 (x_get_local_selection): Remove unnecessary code.
10039 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10040 of converted selections stored in converted_selections.
10041 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10042 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10043 (x_convert_selection): New function.
10044 (x_handle_selection_event): Simplify.
10045 (x_get_foreign_selection): Don't ignore incoming requests while
10046 waiting for an answer; this will fail when we implement
10047 SAVE_TARGETS, and seems unnecessary anyway.
10048 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10049 (Vx_sent_selection_functions): Doc fix.
10050
0f4aebc0
LL
100512011-05-26 Leo Liu <sdl.web@gmail.com>
10052
10053 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10054
e61124cd
YM
100552011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10056
10057 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10058
10059 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10060 for fringe update if it has periodic bitmap.
ac389d0c 10061 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10062 and fringe_bitmap_periodic_p.
10063
10064 * fringe.c (get_fringe_bitmap_data): New function.
10065 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10066 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10067 row. Mark glyph row for fringe update if periodicity changed.
10068
10069 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10070 for fringe update unless it has periodic bitmap.
10071
f16d9837
KH
100722011-05-25 Kenichi Handa <handa@m17n.org>
10073
10074 * xdisp.c (get_next_display_element): Set correct it->face_id for
10075 a static composition.
10076
e1b90ef6
LL
100772011-05-24 Leo Liu <sdl.web@gmail.com>
10078
10079 * deps.mk (fns.o):
10080 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10081
10082 * fns.c (crypto_hash_function, Fsha1): New function.
10083 (Fmd5): Use crypto_hash_function.
10084 (syms_of_fns): Add Ssha1.
10085
7400048f
PE
100862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10087
10088 * gnutls.c: Remove unused macros.
10089 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10090 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10091 Remove macros that are defined and never used.
10092 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10093
abb71cf4
CY
100942011-05-22 Chong Yidong <cyd@stupidchicken.com>
10095
10096 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10097 (Fx_get_selection_internal): Minor cleanup.
10098 (Fx_own_selection_internal): Rename arguments for consistency with
10099 select.el.
10100
6307db39
PE
101012011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10102
10103 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10104
f3d4e0a4
CY
101052011-05-22 Chong Yidong <cyd@stupidchicken.com>
10106
10107 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10108
4d8ade89
YM
101092011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10110
10111 * dispnew.c (scrolling_window): Don't exclude the case that the
10112 last enabled row in the desired matrix touches the bottom boundary.
10113
32078c8d
GM
101142011-05-21 Glenn Morris <rgm@gnu.org>
10115
10116 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10117 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10118 and add some more files.
32078c8d 10119
7285dc67
EZ
101202011-05-20 Eli Zaretskii <eliz@gnu.org>
10121
10122 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10123 report_file_error introduced by the change from 2011-05-07.
10124
89d1bd22
PE
101252011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10126
10127 * systime.h (Time): Define only if emacs is defined.
10128 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10129 where the include path doesn't have X11/X.h by default. See
10130 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10131
cd394be1 101322011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10133
10134 * composite.c (find_automatic_composition): Fix previous change.
10135
b9704ad9
GM
101362011-05-20 Glenn Morris <rgm@gnu.org>
10137
10138 * lisp.mk: New file, split from Makefile.in.
10139 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10140 (shortlisp): Remove.
10141 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10142
4a720484
GM
101432011-05-19 Glenn Morris <rgm@gnu.org>
10144
10145 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10146 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10147 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10148 (lisp): Set the order to that of loadup.el.
10149 (shortlisp): Make it a copy of $lisp.
10150 (SOME_MACHINE_LISP): Remove.
10151 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10152 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10153
a28d4396
KH
101542011-05-18 Kenichi Handa <handa@m17n.org>
10155
10156 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10157 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10158 (find_automatic_composition): Mostly rewrite for efficiency.
10159
a2b1fa8e
JB
101602011-05-18 Juanma Barranquero <lekktu@gmail.com>
10161
10162 * makefile.w32-in: Update dependencies.
10163
8e1f5610
CS
101642011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10165
10166 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10167 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10168
7025ee00 101692011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10170
cdfa6eab
PE
10171 Fix some integer overflow issues, such as string length overflow.
10172
06d6db33
PE
10173 * insdel.c (count_size_as_multibyte): Check for string overflow.
10174
2b4560a8
PE
10175 * character.c (lisp_string_width): Check for string overflow.
10176 Use EMACS_INT, not int, for string indexes and lengths; in
10177 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10178 the resulting string length overflows an EMACS_INT; instead,
10179 report a string overflow if no precision given. When checking for
10180 precision exhaustion, use a check that cannot possibly have
10181 integer overflow. (Bug#8675)
10182 * character.h (lisp_string_width): Adjust to new signature.
10183
cb93f9be
PE
10184 * alloc.c (string_overflow): New function.
10185 (Fmake_string): Use it. This doesn't change behavior, but saves
10186 a few bytes and will simplify future changes.
10187 * character.c (string_escape_byte8): Likewise.
10188 * lisp.h (string_overflow): New decl.
10189
1a1f3366
PE
10190 Fixups, following up to the user-interface timestamp change.
10191 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10192 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10193 * msdos.c (mouse_get_pos): Likewise.
10194 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10195 * w32gui.h (Time): Define by including "systime.h" rather than by
10196 declaring it ourselves. (Bug#8664)
10197
d4e3e4d3
PE
10198 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10199 * image.c (clear_image_cache): Likewise.
10200
f6a24d19
PE
10201 * term.c (term_mouse_position): Don't assume time_t wraparound.
10202
08dc5ae6
PE
10203 Be more systematic about user-interface timestamps.
10204 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10205 and sometimes 'EMACS_UINT', to represent these timestamps.
10206 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10207 This makes the code easier to follow, and makes it easier to catch
10208 integer overflow bugs such as Bug#8664.
10209 * frame.c (Fmouse_position, Fmouse_pixel_position):
10210 Use Time, not unsigned long, for user-interface timestamps.
10211 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10212 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10213 * keyboard.h (last_event_timestamp): Likewise.
10214 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10215 * menu.h (xmenu_show): Likewise.
10216 * term.c (term_mouse_position): Likewise.
10217 * termhooks.h (struct input_event.timestamp): Likewise.
10218 (struct terminal.mouse_position_hook): Likewise.
10219 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10220 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10221 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10222 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10223 what it was before.
10224 * menu.h, termhooks.h: Include "systime.h", for Time.
10225
8e55734a
PE
10226 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10227 Don't assume that the difference between two unsigned long values
10228 can fit into an integer. At this point, we know button_down_time
10229 <= event->timestamp, so the difference must be nonnegative, so
10230 there's no need to cast the result if double-click-time is
10231 nonnegative, as it should be; check that it's nonnegative, just in
10232 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10233 apart (about 25 days). (Bug#8664)
8e55734a 10234
841f1b75 10235 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10236 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10237
3e26f69c
PE
10238 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10239 that always fit in int. Use a sentinel instead of a counter, to
10240 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10241 * frame.h (struct frame): Use int for menu_bar_items_used
10242 instead of EMACS_INT, since it always fits in int.
3e26f69c 10243
5cc152c0
PE
10244 * menu.c (grow_menu_items): Check for int overflow.
10245
d89eb65e
PE
10246 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10247
5235bd3e
PE
10248 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10249 Before, the code was not consistent. These values cannot exceed
10250 2**31 - 1 so there's no need to make them unsigned.
10251 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10252 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10253 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10254 as modifiers.
10255 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10256
bc827e23
PE
10257 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10258 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10259 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10260 presumably because the widths might not match.
10261
78eb494e
PE
10262 * window.c (size_window): Avoid needless test at loop start.
10263
04f2d78b
CB
102642011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10265
10266 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10267
d2fc7e3d 102682011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10269
10270 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10271
d2fc7e3d 102722011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10273
10274 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10275 `width' to `bar_area_x' and `bar_area_width', respectively.
10276 (x_scroll_run): Take account of fringe background extension.
10277
04f2d78b
CB
10278 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10279 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10280 `bar_area_width', respectively.
10281 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10282 background extension.
10283
79b70037
GM
102842011-05-10 Jim Meyering <meyering@redhat.com>
10285
10286 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10287
2f142cc5
JB
102882011-05-10 Juanma Barranquero <lekktu@gmail.com>
10289
10290 * image.c (Finit_image_library): Return t for built-in image types,
10291 like pbm and xbm. (Bug#8640)
10292
57679c86
AS
102932011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10294
10295 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10296
888c9e86
EZ
102972011-05-07 Eli Zaretskii <eliz@gnu.org>
10298
b0512a1d
EZ
10299 * w32console.c (Fset_screen_color): Doc fix.
10300 (Fget_screen_color): New function.
10301 (syms_of_ntterm): Defsubr it.
10302
7285dc67
EZ
10303 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10304 unlink the temporary file if Fcall_process didn't create it in the
10305 first place.
10306 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10307 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10308 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10309 cue to call_process_cleanup not to close that handle.
10310
4d3fcc8e
BK
103112011-05-07 Ben Key <bkey76@gmail.com>
10312
10313 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10314 one of two shell specific rules, either bootstrap-temacs-CMD or
10315 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10316 to the previous implementation of the bootstrap-temacs rule.
10317 The bootstrap-temacs-CMD rule is similar to the previous
10318 implementation of the bootstrap-temacs rule except that it
10319 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10320 variable.
10321
10322 These changes, along with some changes to nt/configure.bat,
10323 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10324 earlier fix to add support for --cflags and --ldflags options
10325 that include quotes so that it works whether make uses cmd or
10326 sh as the shell.
10327
b4289b64
MA
103282011-05-06 Michael Albinus <michael.albinus@gmx.de>
10329
10330 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10331 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10332 is a constant.
10333 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10334 a string. Handle both cases.
10335 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10336 (Fdbus_register_method): Use Qinvalid_function.
10337
af4c0e28
JB
103382011-05-06 Juanma Barranquero <lekktu@gmail.com>
10339
10340 * makefile.w32-in: Update dependencies.
10341 (LISP_H): Add inttypes.h and stdin.h.
10342 (PROCESS_H): Add unistd.h.
10343
c51453d9
EZ
103442011-05-06 Eli Zaretskii <eliz@gnu.org>
10345
10346 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10347 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10348
8ff0ac3c 103492011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10350
4c4b566b
PE
10351 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10352
aab2b9b5
PE
10353 * term.c (vfatal): Remove stray call to va_end.
10354 It's not needed and the C Standard doesn't allow it here anyway.
10355
c378da0b
PE
10356 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10357 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10358
288b08c7
PE
10359 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10360 bytes.
10361
e3601888
PE
10362 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10363
db6c0e74
PE
10364 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10365
dd5963ea
PE
10366 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10367
88c9450f
PE
10368 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10369
2f9442b8
PE
10370 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10371
c032b5f8
PE
10372 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10373 * charset.c (Fdefine_charset_internal): Don't initialize
10374 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10375 32-bit int (Bug#8600).
a108c10b
PE
10376
10377 * lread.c (read_integer): Be more consistent with string-to-number.
10378 Use string_to_number to do the actual conversion; this avoids
10379 rounding errors and fixes some other screwups. Without this fix,
10380 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10381 (digit_to_number): Move earlier, for benefit of read_integer.
10382 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10383 not a digit in any supported base. (Bug#8602)
a108c10b 10384
ad5f9eea
PE
10385 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10386
aec1708a
PE
10387 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10388 to match comment at start of function. This also removes a
10389 GCC warning about overflow in a 32+64-bit port.
10390
47be4ab5
PE
10391 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10392
371cac43
PE
10393 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10394 Reported by Stefan Monnier in
10395 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10396 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10397 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10398
d01a7826
PE
10399 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10400 (EMACS_UINTPTR): Likewise, with uintptr_t.
10401
7fd47d5c
PE
10402 * lisp.h: Prefer 64-bit EMACS_INT if available.
10403 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10404 on 32-bit hosts that have 64-bit int, so that they can access
10405 large files.
122b0c86
PE
10406 However, temporarily disable this change unless the temporary
10407 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10408
8727937b
PE
10409 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10410
8ac068ac
PE
10411 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10412 This removes an assumption that EMACS_INT and long are the same
10413 width as pointers. The assumption is true for Emacs porting targets
10414 now, but we want to make other targets possible.
10415 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10416 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10417 In the rest of the code, change types of integers that hold casted
10418 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10419 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10420 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10421 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10422 No need to cast type when ORing.
10423 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10424 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10425 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10426 assume EMACS_INT is the same width as char *.
10427 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10428 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10429 Remove no-longer-needed casts.
10430 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10431 (xg_tool_bar_help_callback, xg_make_tool_item):
10432 Use EMACS_INTPTR to hold an integer
10433 that will be cast to void *; this can avoid a GCC warning
10434 if EMACS_INT is not the same width as void *.
10435 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10436 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10437 (current_message_1, set_message_1):
10438 Use a local to convert to proper width without a cast.
10439 * xmenu.c (dialog_selection_callback): Likewise.
10440
ede49d71
PE
10441 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10442 Also, don't assume VALBITS / RAND_BITS is less than 5,
10443 and don't rely on undefined behavior when shifting a 1 left into
10444 the sign bit.
10445 * lisp.h (get_random): Change signature to match.
10446
2f30ecd0
PE
10447 * lread.c (hash_string): Use size_t, not int, for hash computation.
10448 Normally we prefer signed values; but hashing is special, because
10449 it's better to use unsigned division on hash table sizes so that
10450 the remainder is nonnegative. Also, size_t is the natural width
10451 for hashing into memory. The previous code used 'int', which doesn't
10452 retain enough info to hash well into very large tables.
10453 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10454
2a866e7b
PE
10455 * dbusbind.c: Don't possibly lose pointer info when converting.
10456 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10457 Use XPNTR rather than XHASH, so that the high-order bits of
10458 the pointer aren't lost when converting through void *.
10459
51639eac
PE
10460 * eval.c (Fautoload): Don't double-shift a pointer.
10461
92394119
PE
10462 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10463
dbdb9a7c
JB
104642011-05-06 Juanma Barranquero <lekktu@gmail.com>
10465
10466 * gnutls.c (DEF_GNUTLS_FN):
10467 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10468
db7a0b4f
AS
104692011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10470
10471 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10472 marker. (Bug#8610)
10473
cd394be1 104742011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10475
10476 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10477 New version that can reserve upto 2GB of heap space.
10478
f7ff1b0f 104792011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10480
10481 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10482
639c109b
TZ
104832011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10484
10485 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10486 `gnutls_certificate_set_x509_key_file'.
10487
d2127135
JB
104882011-05-05 Juanma Barranquero <lekktu@gmail.com>
10489
10490 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10491 Update dependencies.
10492
e968f4f3
JB
104932011-05-04 Juanma Barranquero <lekktu@gmail.com>
10494
10495 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10496 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10497 Remove unused parameter `fildes'.
10498 * process.c (read_process_output, send_process): Don't pass it.
10499
84d358f0
JB
105002011-05-04 Juanma Barranquero <lekktu@gmail.com>
10501
10502 Fix previous change: the library cache is defined in w32.c.
10503 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10504 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10505
0898ca10
JB
105062011-05-04 Juanma Barranquero <lekktu@gmail.com>
10507
10508 Implement dynamic loading of GnuTLS on Windows.
10509
10510 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10511 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10512 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10513 Declare.
10514
10515 * gnutls.c (Qgnutls_dll): Define.
10516 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10517 (gnutls_*): Declare function pointers.
10518 (init_gnutls_functions): New function to initialize function pointers.
10519 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10520 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10521 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10522 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10523 (emacs_gnutls_write, emacs_gnutls_read)
10524 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10525 (Fgnutls_available_p): New function.
10526 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10527 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10528 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10529
10530 * image.c: Include w32.h.
10531 (Vimage_type_cache): Delete.
10532 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10533 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10534 (w32_delayed_load): Move to w32.c.
10535
10536 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10537
10538 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10539 (w32_delayed_load): Move from image.c. When loading a library, record
10540 its filename in the :loaded-from property of the library id.
10541 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10542 Initialize and staticpro them.
10543 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10544
10545 * process.c: Include lisp.h before w32.h, not after.
10546 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10547 instead of gnutls_record_check_pending.
10548
10549 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10550
ff4de4aa
TZ
105512011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10552
10553 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10554 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10555 as passed in.
10556
abe95abb
JD
105572011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10558
10559 * xterm.c (x_set_frame_alpha): Do not set property on anything
10560 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10561
e16e55d4
JB
105622011-05-02 Juanma Barranquero <lekktu@gmail.com>
10563
10564 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10565
bafcf6a5
JB
105662011-05-02 Juanma Barranquero <lekktu@gmail.com>
10567
10568 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10569 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10570 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10571 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10572 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10573 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10574 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10575 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10576 (Qgnutls_bootprop_callbacks_verify): Make static.
10577
e7a6747f
AS
105782011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10579
19ed11ba
AS
10580 * callproc.c: Indentation fixup.
10581
e7a6747f 10582 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10583 (wait_for_termination, interruptible_wait_for_termination):
10584 Move after wait_for_termination_1.
e7a6747f 10585
1ef14cb4
LMI
105862011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10587
10588 * sysdep.c (interruptible_wait_for_termination): New function
10589 which is like wait_for_termination, but allows keyboard
10590 interruptions.
10591
10592 * callproc.c (Fcall_process): Add (:file "file") as an option for
10593 the STDOUT buffer.
10594 (Fcall_process_region): Ditto.
10595
330d880c
EZ
105962011-04-30 Eli Zaretskii <eliz@gnu.org>
10597
8db90b73
EZ
10598 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10599 rather than `XVECTOR (FOO)->size'.
10600
330d880c
EZ
10601 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10602 inttypes.h, as a gnulib replacement is used if it not available in
10603 system headers.
10604
15cbd324
EZ
106052011-04-21 Eli Zaretskii <eliz@gnu.org>
10606
10607 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10608 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10609 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10610
10611 * coding.c (coding_alloc_by_realloc): Error out if destination
10612 will grow beyond MOST_POSITIVE_FIXNUM.
10613 (decode_coding_emacs_mule): Abort if there isn't enough place in
10614 charbuf for the composition carryover bytes. Reserve an extra
10615 space for up to 2 characters produced in a loop.
10616 (decode_coding_iso_2022): Abort if there isn't enough place in
10617 charbuf for the composition carryover bytes.
10618
106192011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10620
ae940cca
EZ
10621 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10622 aborting when %lld or %lll format is passed.
10623 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10624 %llo or %llx format is passed. (Bug#8545)
10625
03ab8921
EZ
10626 * window.c (window_scroll_line_based): Use a marker instead of
10627 simple variables to record original value of point. (Bug#7952)
10628
afda1437
EZ
10629 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10630 produced by %s or %c overflows available buffer space. (Bug#8545)
10631
f76dee0c
PE
106322011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10633
10634 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10635 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10636
fdc5744d
JB
106372011-04-28 Juanma Barranquero <lekktu@gmail.com>
10638
10639 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10640
638f053a
JB
106412011-04-28 Juanma Barranquero <lekktu@gmail.com>
10642
10643 * keyboard.c (Qdelayed_warnings_hook): Define.
10644 (command_loop_1): Run `delayed-warnings-hook'
10645 if Vdelayed_warnings_list is non-nil.
10646 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10647 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10648
d178f871
EZ
106492011-04-28 Eli Zaretskii <eliz@gnu.org>
10650
10651 * doprnt.c (doprnt): Don't return value smaller than the buffer
10652 size if the message was truncated. (Bug#8545).
10653
b124fd93
JB
106542011-04-28 Juanma Barranquero <lekktu@gmail.com>
10655
10656 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10657 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10658
e810457d
PE
106592011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10660
10661 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10662
ea51cceb
JB
106632011-04-27 Juanma Barranquero <lekktu@gmail.com>
10664
10665 * makefile.w32-in: Update dependencies.
10666
94dcfacf
EZ
106672011-04-27 Eli Zaretskii <eliz@gnu.org>
10668
10669 Improve `doprnt' and its usage. (Bug#8545)
10670 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10671 `format_end'. Remove support for %l as a conversion specifier.
10672 Don't use xrealloc. Improve diagnostics when the %l size modifier
10673 is used. Update the commentary.
10674
10675 * eval.c (verror): Simplify calculation of size_t.
10676
10677 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10678 messages.
10679
f61f41d7
PE
106802011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10681
10682 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10683 change.
10684
96fb4434
PE
106852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10686
10687 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10688 This makes this file independent of the recent pseudovector change.
10689
671875da 106902011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10691
69e9b5a3
PE
10692 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10693
b5f869a7 10694 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10695 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10696 Remove unused local.
c8926152 10697 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10698
841a1577 10699 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10700 GCC 4.6.0 optimizes based on type-based alias analysis.
10701 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10702 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10703 != &v->size, and therefore "v->size = 1; b->size = 2; return
10704 v->size;" must therefore return 1. This assumption is incorrect
10705 for Emacs, since it type-puns struct Lisp_Vector * with many other
10706 types. To fix this problem, this patch adds a new type struct
f904488f 10707 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10708 and pseudovectors, and helps optimizing compilers not get fooled
10709 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10710 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10711 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10712 the size member.
eab3844f
PE
10713 (XSETPVECTYPE): Rewrite in terms of new macro.
10714 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10715 This is a bit clearer, and further avoids the possibility of
10716 undesirable aliasing.
10717 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10718 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10719 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10720 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10721 (ASIZE): Now uses header.size rather than size.
10722 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10723 to avoid the hassle of writing XVECTOR (foo)->header.size.
10724 (struct vectorlike_header): New type.
eab3844f
PE
10725 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10726 object, to help avoid aliasing.
10727 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10728 (SUBRP): Likewise, since Lisp_Subr is a special case.
10729 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10730 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10731 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10732 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10733 changed to be "header.size" and "header.next".
10734 * buffer.h (struct buffer): Likewise.
10735 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10736 * frame.h (struct frame): Likewise.
10737 * process.h (struct Lisp_Process): Likewise.
10738 * termhooks.h (struct terminal): Likewise.
10739 * window.c (struct save_window_data, struct saved_window): Likewise.
10740 * window.h (struct window): Likewise.
10741 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10742 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10743 * buffer.c (init_buffer_once): Likewise.
10744 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10745 special case.
10746 * process.c (Fformat_network_address): Use local var for size,
10747 for brevity.
10748
0df1eac5
PE
10749 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10750
847ab9d1 10751 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10752 * data.c (atof): Remove decl; no longer used or needed.
10753 (digit_to_number): Move to lread.c.
10754 (Fstring_to_number): Use new string_to_number function, to be
10755 consistent with how the Lisp reader treats infinities and NaNs.
10756 Do not assume that floating-point numbers represent EMACS_INT
10757 without losing information; this is not true on most 64-bit hosts.
10758 Avoid double-rounding errors, by insisting on integers when
10759 parsing non-base-10 numbers, as the documentation specifies.
10760 * lisp.h (string_to_number): New decl, replacing ...
10761 (isfloat_string): Remove.
bc0a5c13 10762 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10763 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10764 appears to have been a coding error. Similarly, do not accept
10765 strings like +-1e0 as floating point numbers. Do not report
10766 overflow for integer overflows unless the base is not 10 which
10767 means we have no simple and reliable way to continue.
10768 Break out the floating-point parsing into a new
10769 function string_to_number, so that Fstring_to_number parses
10770 floating point numbers consistently with the Lisp reader.
04f2d78b 10771 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10772 (E_CHAR, EXP_INT): Remove, replacing with ...
10773 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10774 (string_to_number): New function, replacing isfloat_string.
10775 This function checks for valid syntax and produces the resulting
10776 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10777 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10778 so that overflow for non-base-10 numbers is reported only when
10779 there's no portable and simple way to convert to floating point.
452f4150 10780
67769ffc
PE
10781 * textprop.c (set_text_properties_1): Rewrite for clarity,
10782 and to avoid GCC warning about integer overflow.
10783
c20db43f
PE
10784 * intervals.h (struct interval): Use EMACS_INT for members
10785 where EMACS_UINT might cause problems. See
10786 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10787 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10788 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10789 All uses changed.
37aa2f85
PE
10790 (offset_intervals): Tell GCC not to worry about length overflow
10791 when negating a negative length.
c20db43f 10792
2538aa2f
PE
10793 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10794 (overrun_check_free): Likewise.
10795
f2d3008d
PE
10796 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10797 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10798 word size.
10799
ec8df744
PE
10800 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10801 (gnutls_make_error): Rename local to avoid shadowing.
10802 (gnutls_emacs_global_deinit): ifdef out; not used.
10803 (Fgnutls_boot): Use const for pointer to readonly storage.
10804 Comment out unused local. Fix pointer signedness problems.
10805
640ee02d
PE
10806 * lread.c (openp): Don't stuff size_t into an 'int'.
10807 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10808 about possible signed overflow.
10809
6048fb2a
PE
10810 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10811 (GDK_KEY_g): Don't define if already defined.
10812 (xg_prepare_tooltip): Avoid pointer signedness problem.
10813 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10814
fa3c87e1
PE
10815 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10816 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10817
2172544b
PE
10818 * xfns.c (Fx_window_property): Simplify a bit,
10819 to make a bit faster and to avoid GCC 4.6.0 warning.
10820 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10821
9b821a21
PE
10822 * fns.c (internal_equal): Don't assume size_t fits in int.
10823
3c616cfa
PE
10824 * alloc.c (compact_small_strings): Tighten assertion a little.
10825
c2982e87
PE
10826 Replace pEd with more-general pI, and fix some printf arg casts.
10827 * lisp.h (pI): New macro, generalizing old pEd macro to other
10828 conversion specifiers. For example, use "...%"pI"d..." rather
10829 than "...%"pEd"...".
10830 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10831 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10832 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10833 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10834 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10835 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10836 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10837 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10838 64-bit hosts.
10839 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10840 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10841 * print.c (safe_debug_print, print_object): Likewise.
10842 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10843 to int.
6f04d126
PE
10844 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10845 avoiding the 0 flag, which is not portable.
c2982e87
PE
10846 * process.c (Fmake_network_process): Use pI to avoid cast.
10847 * region-cache.c (pp_cache): Likewise.
10848 * xdisp.c (decode_mode_spec): Likewise.
10849 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10850 behavior on 64-bit hosts with printf arg.
6f04d126 10851 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10852 (x_stop_queuing_selection_requests): Likewise.
10853 (x_get_window_property): Don't truncate byte count to an 'int'
10854 when tracing.
0b432f21 10855
5e073ec7
PE
10856 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10857 here, since it parses constructs like leading '-' and spaces,
10858 which are not wanted; and it overflows with large numbers.
10859 Instead, simply match F[0-9]+, which is what is wanted anyway.
10860
36372bf9
PE
10861 * alloc.c: Remove unportable assumptions about struct layout.
10862 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10863 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10864 (allocate_vectorlike, make_pure_vector): Use the new macros,
10865 plus offsetof, to remove unportable assumptions about struct layout.
10866 These assumptions hold on all porting targets that I know of, but
10867 they are not guaranteed, they're easy to remove, and removing them
10868 makes further changes easier.
10869
0b432f21
PE
10870 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10871 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10872 (string_overrun_cookie): Now const. Use initializers that
10873 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10874 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10875 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10876 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10877 multiple of sizeof (EMACS_INT); it need not be, if
10878 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10879 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10880
895009e1
JB
108812011-04-26 Juanma Barranquero <lekktu@gmail.com>
10882
10883 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10884
6a7a1b0b
TZ
108852011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10886
10887 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10888 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10889 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10890
841a1577 108912011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10892
10893 * lisp.h (Qdebug): List symbol.
895009e1 10894 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10895 * keyboard.c (debug-on-event): New variable.
10896 (handle_user_signal): Break into debugger when debug-on-event
10897 matches the current signal symbol.
10898
f2d3ba6f
DN
108992011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10900
10901 * alloc.c (check_sblock, check_string_bytes)
10902 (check_string_free_list): Convert to standard C.
10903
42ce4c63
TZ
109042011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10905
10906 * w32.c (emacs_gnutls_push): Fix typo.
10907
825cd63c
EZ
109082011-04-25 Eli Zaretskii <eliz@gnu.org>
10909
fb11d64d
EZ
10910 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10911 "cast to pointer from integer of different size".
10912
825cd63c
EZ
10913 Improve doprnt and its use in verror. (Bug#8545)
10914 * doprnt.c (doprnt): Document the set of format control sequences
10915 supported by the function. Use SAFE_ALLOCA instead of always
10916 using `alloca'.
10917
10918 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10919 is one byte too soon. Don't use xrealloc; instead xfree and
10920 xmalloc anew.
10921
e061a11b
TZ
109222011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10923
10924 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10925 callbacks stage.
10926
10927 * gnutls.c: Renamed global_initialized to
10928 gnutls_global_initialized. Added internals for the
10929 :verify-hostname-error, :verify-error, and :verify-flags
10930 parameters of `gnutls-boot' and documented those parameters in the
10931 docstring. Start callback support.
9173deec
JB
10932 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10933 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10934 on error. Return error code.
e061a11b
TZ
10935 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10936 (emacs_gnutls_read): Likewise.
10937 (Fgnutls_boot): Return handshake error code.
10938 (emacs_gnutls_handle_error): New function.
10939 (wsaerror_to_errno): Likewise.
10940
10941 * w32.h (emacs_gnutls_pull): Add prototype.
10942 (emacs_gnutls_push): Likewise.
10943
10944 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10945 (emacs_gnutls_push): Likewise.
10946
109472011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10948
10949 * process.c (wait_reading_process_output): Check if GnuTLS
10950 buffered some data internally if no FDs are set for TLS
10951 connections.
10952
10953 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10954 (LIBS): Link to USER_LIBS.
10955 ($(BLD)/gnutls.$(0)): New target.
10956
fa6996bc
EZ
109572011-04-24 Eli Zaretskii <eliz@gnu.org>
10958
eb35682e
EZ
10959 * xdisp.c (handle_single_display_spec): Rename the
10960 display_replaced_before_p argument into display_replaced_p, to
10961 make it consistent with the commentary. Fix typos in the
10962 commentary.
10963
e2ad650c
EZ
10964 * textprop.c (syms_of_textprop): Remove dead code.
10965 (copy_text_properties): Delete obsolete commentary about an
10966 interface that was deleted long ago. Fix typos in the description
10967 of arguments.
10968
1b2de274
EZ
10969 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10970 to changes in oldXMenu/XMenu.h from 2011-04-16.
10971 <menu_help_message, prev_menu_help_message>: Constify.
10972 (IT_menu_make_room): menu->help_text is now `const char **';
10973 adjust.
10974
10975 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10976 to changes in oldXMenu/XMenu.h from 2011-04-16.
10977 (struct XMenu): Declare `help_text' `const char **'.
10978
10979 * xfaces.c <Qunspecified>: Make extern again.
10980
10981 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10982 required by POSIX.
1b2de274 10983
762b15be
EZ
10984 * doc.c (get_doc_string): Improve the format passed to `error'.
10985
10986 * doprnt.c (doprnt): Improve commentary.
10987
10988 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10989
10990 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10991 them with etags.
10992
f1052e5d
EZ
10993 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10994 changes in globals.h immediately force recompilation.
762b15be
EZ
10995 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10996 $(CURDIR)/s/ms-w32.h.
10997 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10998
fa6996bc
EZ
10999 * character.c (Fchar_direction): Function deleted.
11000 (syms_of_character): Don't defsubr it.
11001 <char-direction-table>: Deleted.
11002
e6c3da20
EZ
110032011-04-23 Eli Zaretskii <eliz@gnu.org>
11004
11005 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11006 * doprnt.c: Include limits.h.
11007 (SIZE_MAX): New macro.
04f2d78b
CB
11008 (doprnt): Return a size_t value. 2nd arg is now size_t.
11009 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11010 Improve overflow protection. Support `l' modifier for integer
11011 conversions. Support %l conversion. Don't assume an EMACS_INT
11012 argument for integer conversions and for %c.
11013
11014 * lisp.h (doprnt): Restore prototype.
11015
11016 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11017 $(SRC)/character.h.
11018
11019 * Makefile.in (base_obj): Add back doprnt.o.
11020
11021 * deps.mk (doprnt.o): Add back prerequisites.
11022 (callint.o): Depend on character.h.
11023
11024 * eval.c (internal_lisp_condition_case): Include the handler
11025 representation in the error message.
11026 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11027 when breaking from the loop.
11028
11029 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11030
11031 * callint.c (Fcall_interactively): When displaying error message
11032 about invalid control letter, pass the character's codepoint, not
11033 a pointer to its multibyte form. Improve display of the character
11034 in octal and display also its hex code.
11035
11036 * character.c (char_string): Use %x to display the (unsigned)
11037 codepoint of an invalid character, to avoid displaying a bogus
11038 negative value.
11039
11040 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11041 `error', not SYMBOL_NAME itself.
11042
11043 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11044 character arguments to `error'.
11045
11046 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11047 to `error' in error message about FINAL_CHAR argument. Make sure
11048 FINAL_CHAR is a character, and use %c when it is passed as
11049 argument to `error'.
11050
4ffd0d6b 110512011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11052
11053 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11054
11055 * w32.c: Include <time.h>.
11056 (sys_localtime): New function.
11057
4ffd0d6b 110582011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11059
11060 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11061
4ffd0d6b 11062 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11063
4ffd0d6b 110642011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11065
4ffd0d6b
GM
11066 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11067 zombies (Bug#8467).
aac0c6e3 11068
04c56954
EZ
110692011-04-19 Eli Zaretskii <eliz@gnu.org>
11070
11071 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11072 gl_state.e_property when gl_state.object is Qt.
11073
11074 * insdel.c (make_gap_larger): Remove limitation of buffer size
11075 to <= INT_MAX.
11076
16a43933
CY
110772011-04-18 Chong Yidong <cyd@stupidchicken.com>
11078
11079 * xdisp.c (lookup_glyphless_char_display)
11080 (produce_glyphless_glyph): Handle cons cell entry in
11081 glyphless-char-display.
11082 (Vglyphless_char_display): Document it.
11083
11084 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11085 glyphless-char-display.
11086
4581706e
CY
110872011-04-17 Chong Yidong <cyd@stupidchicken.com>
11088
11089 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11090
11091 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11092
11093 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11094 definition for no-X builds.
11095
4887c6e2 110962011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11097
fd35b6f9
PE
11098 Static checks with GCC 4.6.0 and non-default toolkits.
11099
5c1ccb01
PE
11100 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11101
006c5daa
PE
11102 * process.c (keyboard_bit_set): Define only if SIGIO.
11103 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11104 (send_process): Repair possible setjmp clobbering.
11105
efc736d3
PE
11106 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11107
4e2fe2e6
PE
11108 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11109
f97334a2
PE
11110 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11111
4e75f29d
PE
11112 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11113 Define only if needed.
11114
90efadd1
PE
11115 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11116 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11117 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11118
3c647824
PE
11119 * dispextern.h (struct redisplay_interface): Rename param
11120 to avoid shadowing.
e264f262 11121 * termhooks.h (struct terminal): Likewise.
761383f4 11122 * xterm.c (xembed_send_message): Likewise.
3c647824 11123
b58c5c4a
PE
11124 * insdel.c (make_gap_smaller): Define only if
11125 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11126
cad59032
PE
11127 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11128 it.
11129
c339dc2e
PE
11130 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11131 so that we aren't warned about unused symbols.
11132
91a3e27b
PE
11133 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11134
399c71d3 11135 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11136
8ffc96f5
PE
11137 * xfns.c (x_real_positions): Mark locals as initialized.
11138
eef9bc79
PE
11139 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11140
098db9dd
PE
11141 * xterm.c: Fix problems found by static analysis with other toolkits.
11142 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11143 (x_dispatch_event): Declare static if USE_GTK, and
11144 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11145 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11146 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11147 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11148 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11149
eb18f6cc
PE
11150 * xmenu.c (menu_help_callback): Pointer type fixes.
11151 Use const pointers when pointing at readonly data. Avoid pointer
11152 signedness clashes.
11153 (FALSE): Remove unused macro.
11154 (update_frame_menubar): Remove unused decl.
11155
1fe72bf8
PE
11156 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11157
60d9e1db
PE
11158 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11159 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11160 (single_menu_item): Rename local to avoid shadowing.
11161
39261c26
PE
11162 * keyboard.c (make_lispy_event): Remove unused local var.
11163
018c5e19
PE
11164 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11165 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11166
63d2b86e
PE
11167 * bitmaps: Change bitmaps from unsigned char back to the X11
11168 compatible char. Avoid the old compiler warnings about
11169 out-of-range initializers by using, for example, '\xab' rather
11170 than 0xab.
11171
aefd87e1
PE
11172 * xgselect.c (xgselect_initialize): Check vs interface
11173 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11174
bf501fb9
PE
11175 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11176
e9829fdf
PE
11177 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11178 to read-only memory.
11179
1086c095
PE
11180 * fns.c (vector): Remove; this old hack is no longer needed.
11181
2baccd04 11182 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11183 Remove unused var.
dde42981 11184 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11185
72391843 11186 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11187
436c16df 11188 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11189 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11190 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11191
92bb796d 11192 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11193 (x_term_init): Remove local to avoid shadowing.
92bb796d 11194
764430a3 11195 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11196
11197 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11198 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11199
d1dfb56c
EZ
112002011-04-16 Eli Zaretskii <eliz@gnu.org>
11201
c4354cb4
EZ
11202 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11203
d1dfb56c
EZ
11204 Fix regex.c, syntax.c and friends for buffers > 2GB.
11205 * syntax.h (struct gl_state_s): Declare character position members
11206 EMACS_INT.
11207
11208 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11209
04f2d78b
CB
11210 * textprop.c (verify_interval_modification, interval_of):
11211 Declare arguments EMACS_INT.
d1dfb56c
EZ
11212
11213 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11214 EMACS_INT.
11215
11216 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11217
11218 * indent.c (Fvertical_motion): Local variable it_start is now
11219 EMACS_INT.
11220
11221 * regex.c (re_match, re_match_2, re_match_2_internal)
11222 (bcmp_translate, regcomp, regexec, print_double_string)
11223 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11224 (re_compile_pattern, re_exec): Declare arguments and local
11225 variables `size_t' and `ssize_t' and return values `regoff_t', as
11226 appropriate.
11227 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11228 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11229 <compile_stack_type>: `size' and `avail' are now `size_t'.
11230
11231 * regex.h <regoff_t>: Use ssize_t, not int.
11232 (re_search, re_search_2, re_match, re_match_2): Arguments that
11233 specify buffer/string position and length are now ssize_t and
11234 size_t. Return type is regoff_t.
11235
613052cd
BK
112362011-04-16 Ben Key <bkey76@gmail.com>
11237
11238 * nsfont.m: Fixed bugs in ns_get_family and
11239 ns_descriptor_to_entity that were caused by using free to
11240 deallocate memory blocks that were allocated by xmalloc (via
11241 xstrdup). This caused Emacs to crash when compiled with
11242 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11243 --enable-checking=xmallocoverrun). xfree is now used to
11244 deallocate these memory blocks.
11245
4170f62f 112462011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11247
71b41406
PE
11248 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11249
9587a89d
PE
11250 emacs_write: Accept and return EMACS_INT for sizes.
11251 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11252 et seq.
11253 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11254 Accept and return EMACS_INT.
11255 (emacs_gnutls_write): Return the number of bytes written on
11256 partial writes.
11257 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11258 (emacs_read, emacs_write): Remove check for negative size, as the
11259 Emacs source code has been audited now.
9587a89d
PE
11260 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11261 (emacs_read, emacs_write): Use it.
273a5f82
PE
11262 * process.c (send_process): Adjust to the new signatures of
11263 emacs_write and emacs_gnutls_write. Do not attempt to store
11264 a byte offset into an 'int'; it might overflow.
9587a89d 11265 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11266
3e047f51
PE
11267 * sound.c: Don't assume sizes fit in 'int'.
11268 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11269 Return EMACS_INT, not int.
3e047f51 11270 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11271 Accept EMACS_INT, not int.
11272 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11273 record read return values.
11274
cc39a9db
BK
112752011-04-15 Ben Key <bkey76@gmail.com>
11276
c9d0ec6d
JB
11277 * keyboard.c (Qundefined): Don't declare static since it is used
11278 in nsfns.m.
11279 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11280 static since they are used in nsfont.m.
cc39a9db 11281
6c60eb9f
SM
112822011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11283
11284 * process.c (Qprocessp): Don't declare static.
11285 * lisp.h (Qprocessp): Declare again.
11286
7990b61a
JB
112872011-04-15 Juanma Barranquero <lekktu@gmail.com>
11288
11289 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11290
5d4cb038
PE
112912011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11292
8bd7b830 11293 Improve C-level modularity by making more things 'static'.
cd64ea1d 11294
e3b27b31
PE
11295 Don't publish debugger-only interfaces to other modules.
11296 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11297 (verify_bytepos, count_markers): Move decls to the only modules
11298 that need them.
11299 * region-cache.h (pp_cache): Likewise.
11300 * window.h (check_all_windows): Likewise.
11301 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11302
5d4cb038
PE
11303 * sysdep.c (croak): Now static, if
11304 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11305 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11306
11307 * alloc.c (refill_memory_reserve): Now static if
11308 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11309 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11310
e87b6180
PE
11311 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11312 Define only if USE_LUCID.
11313
ac64929e
PE
11314 * xrdb.c (x_customization_string, x_rm_string): Now static.
11315
6f37259d
PE
11316 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11317 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11318
1683e3ab
PE
11319 * xdisp.c (draw_row_with_mouse_face): Now static.
11320 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11321
de9c2632
PE
11322 * window.h (check_all_windows): Mark externally visible.
11323
2b96acb7
PE
11324 * window.c (window_deletion_count): Now static.
11325
11326 * undo.c: Make symbols static if they're not exported.
11327 (last_undo_buffer, last_boundary_position, pending_boundary):
11328 Now static.
11329
50436f33
PE
11330 * textprop.c (interval_insert_behind_hooks): Now static.
11331 (interval_insert_in_front_hooks): Likewise.
11332
64520e5c
PE
11333 * term.c: Make symbols static if they're not exported.
11334 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11335 (max_frame_lines, tty_set_terminal_modes):
11336 (tty_reset_terminal_modes, tty_turn_off_highlight):
11337 (get_tty_terminal): Now static.
11338 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11339 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11340 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11341 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11342 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11343
1fa53021
PE
11344 * sysdep.c: Make symbols static if they're not exported.
11345 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11346 Now static.
11347 (sigprocmask_set, full_mask): Remove; unused.
11348 (wait_debugging): Mark as visible.
11349 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11350 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11351
d4b43b22
PE
11352 * syntax.c (syntax_temp): Define only if !__GNUC__.
11353
b7c513d0
PE
11354 * sound.c (current_sound_device, current_sound): Now static.
11355
989b29ad
PE
11356 * search.c (searchbufs, searchbuf_head): Now static.
11357
13a55a78
PE
11358 * scroll.c (scroll_cost): Remove; unused.
11359 * dispextern.h (scroll_cost): Remove decl.
11360
de68a1fc
PE
11361 * region-cache.h (pp_cache): Mark as externally visible.
11362
40ccffa6
PE
11363 * process.c: Make symbols static if they're not exported.
11364 (process_tick, update_tick, create_process, chan_process):
11365 (Vprocess_alist, proc_buffered_char, datagram_access):
11366 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11367 (deactivate_process): Mark defn as static, as well as decl.
11368 * lisp.h (create_process): Remove decl.
11369 * process.h (chan_process, Vprocess_alist): Remove decls.
11370
ad64fc97
PE
11371 * print.c: Make symbols static if they're not exported.
11372 (print_depth, new_backquote_output, being_printed, print_buffer):
11373 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11374 (print_interval, print_number_index, initial_stderr_stream):
11375 Now static.
11376 * lisp.h (Fprinc): Remove decl.
11377 (debug_output_compilation_hack): Mark as externally visible.
11378
adddb265
PE
11379 * sysdep.c (croak): Move decl from here to syssignal.h.
11380 * syssignal.h (croak): Put it here, so the API can be checked when
11381 'croak' is called from dissociate_if_controlling_tty.
11382
1717ede2
PE
11383 * minibuf.c: Make symbols static if they're not exported.
11384 (minibuf_save_list, choose_minibuf_frame): Now static.
11385 * lisp.h (choose_minibuf_frame): Remove decl.
11386
fa5fb2bc
PE
11387 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11388
1e3890d1
PE
11389 * lread.c: Make symbols static if they're not exported.
11390 (read_objects, initial_obarray, oblookup_last_bucket_number):
11391 Now static.
11392 (make_symbol): Remove; unused.
11393 * lisp.h (initial_obarray, make_symbol): Remove decls.
11394
8a1414fa
PE
11395 * keyboard.c: Make symbols static if they're not exported.
11396 (single_kboard, recent_keys_index, total_keys, recent_keys):
11397 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11398 (this_single_command_key_start, echoing, last_auto_save):
11399 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11400 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11401 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11402 (Vlispy_mouse_stem, double_click_count):
11403 Now static.
11404 (force_auto_save_soon): Define only if SIGDANGER.
11405 (ignore_mouse_drag_p): Now static if
11406 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11407 (print_help): Remove; unused.
11408 (stop_character, last_timer_event): Mark as externally visible.
11409 * keyboard.h (ignore_mouse_drag_p): Declare only if
11410 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11411 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11412 * lisp.h (echoing): Remove decl.
11413 (force_auto_save_soon): Declare only if SIGDANGER.
11414 * xdisp.c (redisplay_window): Simplify code, to make it more
11415 obvious that ignore_mouse_drag_p is not accessed if !defined
11416 USE_GTK && !defined HAVE_NS.
11417
93ea6e8f
PE
11418 * intervals.c: Make symbols static if they're not exported.
11419 (merge_properties_sticky, merge_interval_right, delete_interval):
11420 Now static.
11421 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11422
77382fcc
PE
11423 * insdel.c: Make symbols static if they're not exported.
11424 However, leave prepare_to_modify_buffer alone. It's never
11425 called from outside this function, but that appears to be a bug.
11426 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11427 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11428 (adjust_after_replace_noundo): Remove; unused.
11429 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11430 (signal_before_change): Remove decls.
77382fcc 11431
9306c32e
PE
11432 * indent.c (val_compute_motion, val_vmotion): Now static.
11433
cd44d2eb
PE
11434 * image.c: Make symbols static if they're not exported.
11435 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11436 if USE_GTK.
11437 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11438 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11439
ad9a7a06
PE
11440 * fringe.c (standard_bitmaps): Now static.
11441 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11442
81626931
PE
11443 * frame.c: Make symbols static if they're not exported.
11444 (x_report_frame_params, make_terminal_frame): Now static.
11445 (get_frame_param): Now static, unless HAVE_NS.
11446 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11447 (x_get_resource_string): Remove; not used.
11448 * frame.h (make_terminal_frame, x_report_frame_params):
11449 (x_get_resource_string); Remove decls.
11450 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11451 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11452
239f9db9
PE
11453 * font.c, fontset.c: Make symbols static if they're not exported.
11454 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11455 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11456 * font.c (font_close_object): Now static.
11457 * font.h (font_close_object): Remove.
11458 * fontset.c (FONTSET_OBJLIST): Remove.
11459 (free_realized_fontset) #if-0 the body, which does nothing.
11460 (face_suitable_for_char_p): #if-0, as it's never called.
11461 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11462 * xfaces.c (face_at_string_position):
11463 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11464 since 0 is always ASCII.
11465
dfcf3579
PE
11466 * fns.c (weak_hash_tables): Now static.
11467
5045092b
PE
11468 * fileio.c: Make symbols static if they're not exported.
11469 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11470 (Vwrite_region_annotation_buffers): Now static.
11471
57a96f5c
PE
11472 * eval.c: Make symbols static if they're not exported.
11473 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11474 * lisp.h (backtrace_list): Remove decl.
11475
35f08c38
PE
11476 * emacs.c: Make symbols static if they're not exported.
11477 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11478 (fatal_error_code, fatal_error_signal_hook, standard_args):
11479 Now static.
11480 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11481 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11482 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11483 * lisp.h (fatal_error_signal_hook): Remove decl.
11484 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11485
f44bd759
PE
11486 * editfns.c: Move a (normally-unused) function to its only use.
11487 * editfns.c, lisp.h (get_operating_system_release): Remove.
11488 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11489 worth the hassle of breaking this out.
11490
b532497d
PE
11491 * xterm.c: Make symbols static if they're not exported.
11492 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11493 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11494 (x_destroy_window, x_delete_display):
11495 Now static.
11496 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11497 (x_mouse_leave): Remove; unused.
11498 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11499 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11500 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11501 Remove decls.
11502 (x_mouse_leave): Declare only if WINDOWSNT.
11503 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11504 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11505 USE_X_TOOLKIT.
11506
1675728f
PE
11507 * ftxfont.c: Make symbols static if they're not exported.
11508 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11509 HAVE_FREETYPE.
11510 * font.h (ftxfont_driver): Likewise.
11511
e4cebfca
PE
11512 * xfns.c: Make symbols static if they're not exported.
11513 (x_last_font_name, x_display_info_for_name):
11514 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11515 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11516 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11517 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11518 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11519 (last_show_tip_args): Now static.
11520 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11521 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11522 (x_screen_planes): Remove; unused.
11523 * dispextern.h (x_screen_planes): Remove decl.
11524
5bf46f05
PE
11525 * dispnew.c: Make symbols static if they're not exported.
11526 * dispextern.h (redraw_garbaged_frames, scrolling):
11527 (increment_row_positions): Remove.
11528 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11529 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11530 Now static.
11531 (redraw_garbaged_frames): Remove; unused.
11532
435f4c28
PE
11533 * xfaces.c: Make symbols static if they're not exported.
11534 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11535 Remove decls.
11536 * xterm.h (defined_color): Remove decls.
11537 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11538 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11539 (menu_face_changed_default, defined_color, free_realized_face):
11540 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11541 (ascii_face_of_lisp_face): Remove; unused.
11542
8524aef3
PE
11543 * xdisp.c: Make symbols static if they're not exported.
11544 * dispextern.h (scratch_glyph_row, window_box_edges):
11545 (glyph_to_pixel_coords, set_cursor_from_row):
11546 (get_next_display_element, set_iterator_to_next):
11547 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11548 (show_mouse_face): Remove decls
11549 * frame.h (message_buf_print): Likewise.
11550 * lisp.h (pop_message, set_message, check_point_in_composition):
11551 Likewise.
11552 * xterm.h (set_vertical_scroll_bar): Likewise.
11553 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11554 (message_buf_print, scratch_glyph_row, displayed_buffer):
11555 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11556 (get_next_display_element, show_mouse_face, window_box_edges):
11557 (frame_to_window_pixel_xy, check_point_in_composition):
11558 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11559 (glyph_to_pixel_coords): Remove; unused.
11560
16390cd2
PE
11561 * dired.c (file_name_completion): Now static.
11562
11563 * dbusbind.c (xd_in_read_queued_messages): Now static.
11564
a25f4dfa
PE
11565 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11566 * data.c (circular_list_error): Remove.
11567
14a9c8df
PE
11568 * commands.h (last_point_position, last_point_position_buffer):
11569 (last_point_position_window): Remove decls.
11570 * keyboard.c: Make these variables static.
11571
04f2d78b
CB
11572 * coding.h (coding, code_convert_region, encode_coding_gap):
11573 Remove decls.
74ab6df5
PE
11574 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11575 (iso_code_class, detect_coding, code_convert_region): Now static.
11576 (encode_coding_gap): Remove; unused.
11577
38dfbee1
PE
11578 * chartab.c (chartab_chars, chartab_bits): Now static.
11579
a2cb4e63
PE
11580 * charset.h (charset_iso_8859_1): Remove decl.
11581 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11582 Now static.
11583
127198fd
PE
11584 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11585 * ccl.c (Vccl_program_table): Now static.
11586 (check_ccl_update): Remove; unused.
11587
d85b608f
PE
11588 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11589 * category.h: ... from here.
11590 * category.c (check_category_table, set_category_set): Now static.
11591
31cd66f3
PE
11592 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11593 * lisp.h: Remove these decls.
11594
c358e587
PE
11595 * buffer.c (buffer_count): Remove unused var.
11596
e78aecca
PE
11597 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11598 so that it's not optimized away.
11599 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11600 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11601 exported only to the debugger.
11602
e192d7d3 11603 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11604 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11605
92470028
PE
11606 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11607 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11608 was inaccessible from Lisp.
11609 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11610 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11611
244ed907
PE
11612 alloc.c: Import and export fewer symbols, and remove unused items.
11613 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11614 is defined.
11615 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11616 it's not optimized away by whole-program optimization.
11617 (message_enable_multibyte, free_misc): Remove.
11618 (catchlist, handlerlist, mark_backtrace):
11619 Declare only if BYTE_MARK_STACK.
11620 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11621 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11622 (message_enable_multibyte): Remove decl.
11623 (free_misc, interval_free_list, float_block, float_block_index):
11624 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11625 (cons_free_list, last_marked_index):
11626 Now static.
11627 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11628 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11629 (mark_backtrace): Define only if BYTE_MARK_STACK.
11630 * xdisp.c (message_enable_multibyte): Now static.
11631
61c2b50e 11632 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11633 This makes it easier for human readers (and static analyzers)
11634 to see whether these variables are used from other modules.
11635 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11636 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11637 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11638 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11639 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11640 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11641 * xmenu.c, xselect.c:
11642 Declare Q* vars static if they are not used in other modules.
11643 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11644 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11645 Remove decls of unexported vars.
11646 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11647
95c82688
PE
11648 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11649
16a97296
PE
11650 Make Emacs functions such as Fatom 'static' by default.
11651 This makes it easier for human readers (and static analyzers)
11652 to see whether these functions can be called from other modules.
11653 DEFUN now defines a static function. To make the function external
11654 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11655 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11656 (Finit_image_library):
16a97296
PE
11657 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11658 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11659 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11660 Remove decls, since these functions are now static.
11661 (Funintern, Fget_internal_run_time): New decls, since these functions
11662 were already external.
95c82688 11663
16a97296
PE
11664 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11665 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11666 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11667 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11668 * keyboard.c, keymap.c, lread.c:
11669 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11670 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11671 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11672 Mark functions with DEFUE instead of DEFUN,
11673 if they are used in other modules.
11674 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11675 decls for now-static functions.
11676 * buffer.h (Fdelete_overlay): Remove decl.
11677 * callproc.c (Fgetenv_internal): Mark as internal.
11678 * composite.c (Fremove_list_of_text_properties): Remove decl.
11679 (Fcomposition_get_gstring): New forward static decl.
11680 * composite.h (Fcomposite_get_gstring): Remove decl.
11681 * dired.c (Ffile_attributes): New forward static decl.
11682 * doc.c (Fdocumntation_property): New forward static decl.
11683 * eval.c (Ffetch_bytecode): New forward static decl.
11684 (Funintern): Remove extern decl; now in .h file where it belongs.
11685 * fileio.c (Fmake_symbolic_link): New forward static decl.
11686 * image.c (Finit_image_library): New forward static decl.
11687 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11688 * intervals.h (Fprevious_property_change):
11689 (Fremove_list_of_text_properties): Remove decls.
11690 * keyboard.c (Fthis_command_keys): Remove decl.
11691 (Fcommand_execute): New forward static decl.
11692 * keymap.c (Flookup_key): New forward static decl.
11693 (Fcopy_keymap): Now static.
11694 * keymap.h (Flookup_key): Remove decl.
11695 * process.c (Fget_process): New forward static decl.
11696 (Fprocess_datagram_address): Mark as internal.
11697 * syntax.c (Fsyntax_table_p): New forward static decl.
11698 (skip_chars): Remove duplicate decl.
11699 * textprop.c (Fprevious_property_change): New forward static decl.
11700 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11701 Now internal.
11702 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11703 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11704
785bbd42
PE
11705 * editfns.c (Fformat): Remove unreachable code.
11706
8b913b57
AS
117072011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11708
11709 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11710 change. (Bug#8496)
11711
a6744a35
EZ
117122011-04-13 Eli Zaretskii <eliz@gnu.org>
11713
11714 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11715 when at ZV. (Bug#8487)
11716
e7974947
AS
117172011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11718
baad03f0
AS
11719 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11720 (Bug#8437)
11721 * keyboard.c (parse_tool_bar_item): Likewise.
11722 * sound.c (sound_cleanup, alsa_close): Likewise.
11723 * termcap.c (tgetent): Likewise.
11724 * xfns.c (x_default_font_parameter): Likewise.
11725 * xsettings.c (read_and_apply_settings): Likewise.
11726
e7974947
AS
11727 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11728 (overrun_check_free): Protoize.
11729
28272684
PE
117302011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11731
11732 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11733 since callers should never pass a negative size.
11734 Change the signature to match that of plain 'read' and 'write'; see
11735 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11736 * lisp.h: Update prototypes of emacs_write and emacs_read.
11737
11997c76
EZ
117382011-04-11 Eli Zaretskii <eliz@gnu.org>
11739
11740 * xdisp.c (redisplay_window): Don't try to determine the character
11741 position of the scroll margin if the window start point w->startp
e896f03c 11742 is outside the buffer's accessible region. (Bug#8468)
11997c76 11743
8a2cbd72
EZ
117442011-04-10 Eli Zaretskii <eliz@gnu.org>
11745
11746 Fix write-region and its subroutines for buffers > 2GB.
11747 * fileio.c (a_write, e_write): Modify declaration of arguments and
11748 local variables to support buffers larger than 2GB.
11749 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11750
11751 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11752 argument, local variables, and return value.
11753
11754 * lisp.h: Update prototypes of emacs_write and emacs_read.
11755
11756 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11757
4073e537 117582011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11759
1ebfdcb6
PE
11760 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11761
b2ded58d
PE
11762 Fix more problems found by GCC 4.6.0's static checks.
11763
7d66342c
PE
11764 * xdisp.c (vmessage): Use a better test for character truncation.
11765
bbf47d44
PE
11766 * charset.c (load_charset_map): <, not <=, for optimization,
11767 and to avoid potential problems with integer overflow.
9248994d 11768 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11769 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11770 * editfns.c (Fformat): Likewise.
1e69125e 11771 * syntax.c (skip_chars): Likewise.
3befa583 11772
e3019616
PE
11773 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11774 This also lets GCC 4.6.0 generate slightly better loop code.
11775
becfa255
PE
11776 * callint.c (Fcall_interactively): <, not <=, for optimization.
11777 (Fcall_interactively): Count the number of arguments produced,
11778 not the number of arguments given. This is simpler and lets GCC
11779 4.6.0 generate slightly better code.
11780
dae0cd48
PE
11781 * ftfont.c: Distingish more carefully between FcChar8 and char.
11782 The previous code passed unsigned char * to a functions like
11783 strlen and xstrcasecmp that expect char *, which does not
11784 conform to the C standard.
11785 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11786 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11787 char * when the C standard requires it.
11788
76032d70
PE
11789 * keyboard.c (read_char): Remove unused var.
11790
eb3f1cc8
PE
11791 * eval.c: Port to Windows vsnprintf (Bug#8435).
11792 Include <limits.h>.
11793 (SIZE_MAX): Define if the headers do not.
11794 (verror): Do not give up if vsnprintf returns a negative count.
11795 Instead, grow the buffer. This ports to Windows vsnprintf, which
11796 does not conform to C99. Problem reported by Eli Zaretskii.
11797 Also, simplify the allocation scheme, by avoiding the need for
11798 calling realloc, and removing the ALLOCATED variable.
11799
70476b54
PE
11800 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11801
12020a9e
PE
11802 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11803 But keep the doprint source code for now, as we might revamp it
11804 and use it again (Bug#8435).
ea6c7ae6
PE
11805 * lisp.h (doprnt): Remove.
11806 * Makefile.in (base_obj): Remove doprnt.o.
11807 * deps.mk (doprnt.o): Remove.
11808
5fdb398c
PE
11809 error: Print 32- and 64-bit integers portably (Bug#8435).
11810 Without this change, on typical 64-bit hosts error ("...%d...", N)
11811 was used to print both 32- and 64-bit integers N, which relied on
11812 undefined behavior.
61bdb816 11813 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11814 * lisp.h (error, verror): Mark as printf-like functions.
11815 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11816 Report overflow in size calculations when allocating printf buffer.
11817 Do not truncate output string at its first null byte.
11818 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11819 Truncate the output at a character boundary, since vsnprintf does not
11820 do that.
11821 * charset.c (check_iso_charset_parameter): Convert internal
11822 character to string before calling 'error', since %c now has the
11823 printf meaning.
11824 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11825 overflow when computing char to be passed to 'error'. Do not
11826 pass Lisp_Object to 'error'; pass the integer instead.
11827 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11828 formatted with plain %d.
11829
b189fa66
PE
11830 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11831
bff87ef0
PE
11832 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11833
7e2cac20
PE
11834 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11835
ce4d90b5
PE
11836 * xterm.c (x_catch_errors): Remove duplicate declaration.
11837
266c9547
PE
11838 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11839
79c49ad2
PE
11840 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11841
368f4090
JM
118422011-04-10 Jim Meyering <meyering@redhat.com>
11843
11844 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11845 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11846 return ssize_t not "int", and use size_t as the buffer length.
11847 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11848 * gnutls.h: Update declarations.
11849 * process.c (read_process_output): Use ssize_t, to match.
11850 (send_process): Likewise.
11851
a32d4040
CY
118522011-04-09 Chong Yidong <cyd@stupidchicken.com>
11853
11854 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11855
8546720e 118562011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11857
04f2d78b
CB
11858 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11859 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11860
8546720e
GM
11861 * xterm.c (handle_one_xevent):
11862 * xmenu.c (create_and_show_popup_menu):
11863 * xselect.c (x_decline_selection_request)
11864 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11865
0a2f5c1a 118662011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11867
11868 Fix some uses of `int' instead of EMACS_INT.
11869 * search.c (string_match_1, fast_string_match)
11870 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11871 (scan_buffer, find_next_newline_no_quit)
11872 (find_before_next_newline, search_command, Freplace_match)
11873 (Fmatch_data): Make some `int' variables be EMACS_INT.
11874
11875 * xdisp.c (display_count_lines): 3rd argument and return value now
11876 EMACS_INT. All callers changed.
11877 (pint2hrstr): Last argument is now EMACS_INT.
11878
11879 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11880 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11881 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11882 (decode_coding_utf_16, decode_coding_emacs_mule)
11883 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11884 (decode_coding_ccl, decode_coding_charset)
11885 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11886 (decode_coding_iso_2022, decode_coding_emacs_mule)
11887 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11888 <char_offset, last_offset>: Declare EMACS_INT.
11889 (encode_coding_utf_8, encode_coding_utf_16)
11890 (encode_coding_emacs_mule, encode_invocation_designation)
11891 (encode_designation_at_bol, encode_coding_iso_2022)
11892 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11893 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11894 Declare EMACS_INT.
11895 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11896 (encode_invocation_designation): Last argument P_NCHARS is now
11897 EMACS_INT.
11898 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11899 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11900
11901 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11902 All users changed.
11903
11904 * ccl.c (Fccl_execute_on_string): Declare some variables
11905 EMACS_INT.
11906
8546720e 119072011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11908
11909 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11910
4e19a977
CS
119112011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11912
11913 * process.c (Fformat_network_address): Doc fix.
11914
87302331
R
119152011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11916
ee7683eb 11917 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11918
cbb59342
CY
119192011-04-08 Chong Yidong <cyd@stupidchicken.com>
11920
11921 * keyboard.c (read_char): Call Lisp function help-form-show,
11922 instead of using internal_with_output_to_temp_buffer.
11923 (Qhelp_form_show): New var.
e0d38eeb 11924 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11925
11926 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11927
11928 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11929
e67a13ab
CY
119302011-04-06 Chong Yidong <cyd@stupidchicken.com>
11931
04f2d78b
CB
11932 * process.c (Flist_processes): Remove to Lisp.
11933 (list_processes_1): Delete.
e67a13ab 11934
973f782d
EZ
119352011-04-06 Eli Zaretskii <eliz@gnu.org>
11936
7c106b1e
EZ
11937 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11938
973f782d
EZ
11939 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11940
41cf7d1a 119412011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11942
ca23cc88
PE
11943 Fix more problems found by GCC 4.6.0's static checks.
11944
f390e2d5
PE
11945 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11946
42eea0d0
PE
11947 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11948
b69769da 11949 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11950
f9541e84
PE
11951 * xdisp.c (vmessage): Mark as a printf-like function.
11952
13841b55
PE
11953 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11954
c136c10f
PE
11955 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11956
5e2d4a30
PE
11957 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11958 printf-like functions.
11959 (tiff_load): Add casts to remove these marks before passing them
11960 to system-supplied API.
11961
583f48b9
PE
11962 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11963
b25d760e
PE
11964 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11965 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11966 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11967 directly, rather than having caller test rule sign. This avoids
11968 some unnecessary tests.
11969 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11970 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11971 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11972
bc7b6697 11973 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11974 (xfont_open): Avoid unnecessary tests.
bc7b6697 11975
27ccc379
PE
11976 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11977
dcd5c89a
PE
11978 * composite.h, composite.c (composition_gstring_put_cache):
11979 Use EMACS_INT, not int, for length.
11980
b13a45c6
PE
11981 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11982 breaking out part of COMPOSITION_DECODE_RULE.
11983 (COMPOSITION_DECODE_RULE): Use it.
11984 * composite.c (get_composition_id): Remove unused local vars,
11985 by using the new macro.
11986
1e792e4d
PE
11987 * textprop.c (set_text_properties_1): Change while to do-while,
11988 since the condition is always true at first.
11989
dc6c6455 11990 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11991 (interval_deletion_adjustment): Return unsigned value.
11992 All uses changed.
dc6c6455 11993
aba7731a
PE
11994 * process.c (list_processes_1, create_pty, read_process_output):
11995 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11996 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11997 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11998 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11999 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12000
fdfc4bf3
PE
12001 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12002
fca8fe46 12003 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12004 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12005
06a0259a 12006 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12007 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12008 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12009
e7b9e80f
PE
12010 * print.c (print_error_message): Avoid int overflow.
12011
56201685
PE
12012 * font.c (font_list_entities): Redo for clarity,
12013 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12014
78834453 12015 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12016 (font_score): Avoid potential overflow in diff calculation.
78834453 12017
0bc0b309 12018 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12019 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12020
e610eaca
PE
12021 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12022
b895abce
PE
12023 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12024 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12025 can always succeed if overflow has undefined behavior.
12026
1f1d9321 12027 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12028 (wordify): Omit three unnecessary tests.
1f1d9321 12029
c59478bc
PE
12030 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12031 All callers changed. This avoids the need for an unused var.
12032
79b73827
PE
12033 * casefiddle.c (casify_region): Remove var that is set but not used.
12034
a4db5dfe
PE
12035 * dired.c (file_name_completion): Remove var that is set but not used.
12036
43aae36e
PE
12037 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12038
2a47c44d 12039 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12040 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12041
a37c69bf
PE
12042 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12043 Check for integer overflow on size calculations.
12044
328ab8e7
PE
12045 * buffer.c (Fprevious_overlay_change): Remove var that is set
12046 but not used.
12047
e5a2a5cb
PE
12048 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12049 Remove vars that are set but not used.
8d84a6eb 12050 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12051 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12052
a60e5f68
PE
12053 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12054
f661cb61 12055 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12056 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12057
f0397f5a
PE
12058 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12059 that are set but not used.
12060
8664db06 12061 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12062 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12063
6abdaa4a
PE
12064 * xselect.c (x_get_local_selection, x_handle_property_notify):
12065 Remove vars that are set but not used.
12066
0ce7538d 12067 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12068 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12069
9ae848fc
PE
12070 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12071 Remove var that is set but not used.
0b918413
PE
12072 (scroll_bar_windows_size): Now size_t, not int.
12073 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12074 Check for overflow.
9ae848fc 12075
a5a62657
PE
12076 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12077 (map_tty_color) [!defined MSDOS]: Likewise.
12078
5c5cdd39
PE
12079 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12080
66ebf983
PE
12081 * coding.c: Remove vars that are set but not used.
12082 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12083 All callers changed.
12084 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12085 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12086 (decode_coding_charset): Remove vars that are set but not used.
12087
1be4d761
PE
12088 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12089 that is set but not used.
12090
47553fa8
PE
12091 * print.c (print_object): Remove var that is set but not used.
12092
1f7196bf 12093 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12094 The gnulib version avoids calling malloc in the usual case,
12095 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12096 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12097 * filelock.c (current_lock_owner): Likewise.
12098 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12099 * sysdep.c: Include allocator.h, careadlinkat.h.
12100 (emacs_no_realloc_allocator): New static constant.
12101 (emacs_readlink): New function.
fdb61804
PE
12102 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12103 ../lib/careadlinkat.h.
d1fdcab7 12104
f84c17c7
SM
121052011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12106
12107 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12108 first non-nil return value).
12109
ef3862ad
JD
121102011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12111
12112 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12113 if not defined (Bug#8403).
12114
376a7006
JB
121152011-04-02 Juanma Barranquero <lekktu@gmail.com>
12116
12117 * xdisp.c (display_count_lines): Remove parameter `start',
12118 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12119 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12120 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12121 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12122 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12123 and thereabouts. All callers changed.
12124 (get_per_char_metric): Remove parameter `f', unused since
12125 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12126
6ca3801d
JM
121272011-04-02 Jim Meyering <meyering@redhat.com>
12128
12129 do not dereference NULL upon failed strdup
12130 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12131 (ns_get_family): Likewise.
12132
d8e2b5ba
JB
121332011-04-02 Juanma Barranquero <lekktu@gmail.com>
12134
12135 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12136
8c74fcbd
JD
121372011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12138
12139 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12140 later (Bug#8403).
12141
7200d79c
SM
121422011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12143
03408648 12144 Add lexical binding.
7200d79c 12145
03408648
SM
12146 * window.c (Ftemp_output_buffer_show): New fun.
12147 (Fsave_window_excursion):
12148 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12149
12150 * lread.c (lisp_file_lexically_bound_p): New function.
12151 (Fload): Bind Qlexical_binding.
12152 (readevalloop): Remove `evalfun' arg.
12153 Bind Qinternal_interpreter_environment.
12154 (Feval_buffer): Bind Qlexical_binding.
12155 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12156 Mark as dynamic.
12157 (syms_of_lread): Declare `lexical-binding'.
12158
12159 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12160
12161 * keyboard.c (eval_dyn): New fun.
12162 (menu_item_eval_property): Use it.
ca105506
SM
12163
12164 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12165
03408648
SM
12166 * fns.c (concat, mapcar1): Accept byte-code-functions.
12167
12168 * eval.c (Fsetq): Handle lexical vars.
12169 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12170 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12171 (FletX, Flet): Obey lexical binding.
12172 (Fcommandp): Handle closures.
12173 (Feval): New `lexical' arg.
12174 (eval_sub): New function extracted from Feval. Use it almost
12175 everywhere where Feval was used. Look up vars in lexical env.
12176 Handle closures.
12177 (Ffunctionp): Move from subr.el.
12178 (Ffuncall): Handle closures.
12179 (apply_lambda): Remove `eval_flags'.
12180 (funcall_lambda): Handle closures and new byte-code-functions.
12181 (Fspecial_variable_p): New function.
12182 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12183 but without exporting it to Lisp.
23aba0ea 12184
23aba0ea 12185 * doc.c (Fdocumentation, store_function_docstring):
03408648 12186 * data.c (Finteractive_form): Handle closures.
23aba0ea 12187
03408648
SM
12188 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12189 interactive spec.
ba83908c 12190
04f2d78b
CB
12191 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12192 New byte-codes.
03408648
SM
12193 (exec_byte_code): New function extracted from Fbyte_code to handle new
12194 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12195
03408648 12196 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12197
03408648 12198 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12199
e2abce01
JB
122002011-03-31 Juanma Barranquero <lekktu@gmail.com>
12201
12202 * xdisp.c (redisplay_internal): Fix prototype.
12203
63696a73 122042011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12205
63696a73 12206 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12207 (try_scrolling): Use it when setting scroll_limit.
12208 Limit scrolling to 100 screen lines.
63696a73
EZ
12209 (redisplay_window): Even when falling back on "recentering",
12210 position point in the window according to scroll-conservatively,
12211 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12212
12213 (try_scrolling): When point is above the window, allow searching
12214 as far as scroll_max, or one screenful, to compute vertical
12215 distance from PT to the scroll margin position. This prevents
12216 try_scrolling from unnecessarily failing when
12217 scroll-conservatively is set to a value slightly larger than the
12218 window height. Clean up the case of PT below the margin at bottom
12219 of window: scroll_max can no longer be INT_MAX. When aggressive
12220 scrolling is in use, don't let point enter the opposite scroll
12221 margin as result of the scroll.
12222 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12223 threshold of 100 lines for never-recentering scrolling.
12224
e4cc2dfc
JB
122252011-03-31 Juanma Barranquero <lekktu@gmail.com>
12226
12227 * dispextern.h (move_it_by_lines):
12228 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12229 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12230 (message_log_check_duplicate): Remove parameters `prev_bol' and
12231 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12232 (redisplay_internal): Remove parameter `preserve_echo_area',
12233 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12234
12235 * indent.c (Fvertical_motion):
12236 * window.c (window_scroll_pixel_based, Frecenter):
12237 Don't pass `need_y_p' to `move_it_by_lines'.
12238
1c470562
SM
122392011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12240
44f230aa
SM
12241 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12242 steal a few bits to be more compact.
12243 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12244 Remove unneeded casts.
12245
1c470562
SM
12246 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12247
888adce9
ZK
122482011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12249
12250 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12251 binding" message (bug#7967).
12252
f838ed7b
PE
122532011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12254
77861b95
PE
12255 Fix more problems found by GCC 4.6.0's static checks.
12256
de6dbc14
PE
12257 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12258 Remove unused local var.
12259
f838ed7b
PE
12260 * editfns.c (Fmessage_box): Remove unused local var.
12261
792c7b2b
PE
12262 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12263 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12264 Omit unused local vars.
c499e557 12265 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12266 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12267 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12268 Omit unused local var.
12269
ba0165e1
PE
12270 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12271 Don't assume string length fits in int.
32ad8845 12272 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12273 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12274
3c59b4c9
PE
12275 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12276 instead of alloca (Bug#8344).
12277
a3eed478 12278 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12279 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12280
eb4d412d
PE
12281 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12282
1658b401
PE
12283 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12284 concerns.
12285
12286 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12287
12288 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12289
9a2c6e05
PE
12290 * keyboard.c (syms_of_keyboard): Use the same style as later
12291 in this function when indexing through an array. This also
12292 works around GCC bug 48267.
12293
03d0a109
PE
12294 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12295
44f730c8
PE
12296 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12297
fe75f926
PE
12298 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12299 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12300
ffa8c828
PE
12301 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12302 This avoids undefined behavior on integer overflow, and is a bit
12303 more convenient anyway since it is compared to a size_t variable.
12304
c5101a77
PE
12305 Variadic C functions now count arguments with size_t, not int.
12306 This avoids an unnecessary limitation on 64-bit machines, which
12307 caused (substring ...) to crash on large vectors (Bug#8344).
12308 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12309 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12310 All variadic functions and their callers changed accordingly.
c5101a77
PE
12311 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12312 * data.c (arith_driver, float_arith_driver): Likewise.
12313 * editfns.c (general_insert_function): Likewise.
12314 * eval.c (struct backtrace.nargs, interactive_p)
12315 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12316 (funcall_lambda, mark_backtrace): Likewise.
12317 * fns.c (concat): Likewise.
12318 * frame.c (x_set_frame_parameters): Likewise.
12319 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12320 0 if not found, not -1. All callers changed.
12321
dd3f25f7
PE
12322 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12323 (stack_copy_size): Now size_t, not int.
12324 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12325
461c2ab9
JB
123262011-03-28 Juanma Barranquero <lekktu@gmail.com>
12327
12328 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12329 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12330 All callers changed.
12331
12332 * lisp.h (multibyte_char_to_unibyte):
12333 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12334 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12335 * character.h (CHAR_TO_BYTE8):
12336 * cmds.c (internal_self_insert):
12337 * editfns.c (general_insert_function):
12338 * keymap.c (push_key_description):
12339 * search.c (Freplace_match):
12340 * xdisp.c (message_dolog, set_message_1): All callers changed.
12341
f6d62986
SM
123422011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12343
12344 * keyboard.c (safe_run_hook_funcall): New function.
12345 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12346 don't set the hook to nil, but remove the offending function instead.
12347 (Qcommand_hook_internal): Remove, unused.
12348 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12349 Vcommand_hook_internal.
12350
12351 * eval.c (enum run_hooks_condition): Remove.
12352 (funcall_nil, funcall_not): New functions.
12353 (run_hook_with_args): Call each function through a `funcall' argument.
12354 Remove `cond' argument, now redundant.
12355 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12356 (Frun_hook_with_args_until_failure): Adjust accordingly.
12357 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12358
1db5b1ad
JB
123592011-03-28 Juanma Barranquero <lekktu@gmail.com>
12360
12361 * dispextern.h (string_buffer_position): Remove declaration.
12362
12363 * print.c (strout): Remove parameter `multibyte', unused since
12364 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12365
12366 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12367 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12368 All callers changed.
12369
12370 * w32.c (_wsa_errlist): Use braces for struct initializers.
12371
12372 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12373 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12374 All callers changed.
12375 (string_buffer_position): Likewise. Also, make static (it's never
12376 used outside xdisp.c).
12377 (cursor_row_p): Remove parameter `w', unused since
12378 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12379 (decode_mode_spec): Remove parameter `precision', introduced during
12380 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12381 All callers changed.
12382
5ffb62aa
JD
123832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12384
12385 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12386
461c2ab9 123872011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12388
12389 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12390 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12391 (ns_update_auto_hide_menu_bar): New functions.
12392 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12393 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12394 ns_constrain_all_frames.
12395 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12396 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12397
5c380ffb
JD
123982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12399
12400 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12401
9af30bdf
GM
124022011-03-27 Glenn Morris <rgm@gnu.org>
12403
12404 * syssignal.h: Replace RETSIGTYPE with void.
12405 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12406 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12407 Replace SIGTYPE with void everywhere.
12408 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12409 * s/template.h (SIGTYPE): Remove commented out definition.
12410
e2abce01
JB
124112011-03-26 Eli Zaretskii <eliz@gnu.org>
12412
12413 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12414 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12415
f868cd8a
JB
124162011-03-26 Juanma Barranquero <lekktu@gmail.com>
12417
59eb0929
JB
12418 * w32.c (read_unc_volume): Use parameter `henum', instead of
12419 global variable `wget_enum_handle'.
12420
12421 * keymap.c (describe_vector): Remove parameters `indices' and
12422 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12423 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12424
f868cd8a
JB
12425 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12426
12427 * keyboard.c (timer_check): Remove parameter `do_it_now',
12428 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12429 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12430 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12431
12432 * keyboard.c (read_char):
12433 * w32menu.c (w32_menu_display_help):
12434 * xmenu.c (show_help_event, menu_help_callback):
12435 Adjust calls to `show_help_echo'.
12436
12437 * gtkutil.c (xg_maybe_add_timer):
12438 * keyboard.c (readable_events):
12439 * process.c (wait_reading_process_output):
12440 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12441
12442 * insdel.c (adjust_markers_gap_motion):
12443 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12444 (gap_left, gap_right): Don't call it.
12445
2ecf6fdb
CY
124462011-03-25 Chong Yidong <cyd@stupidchicken.com>
12447
12448 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12449 incurred during fontification.
12450
6b1f9ba4
JB
124512011-03-25 Juanma Barranquero <lekktu@gmail.com>
12452
12453 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12454 (DEFVAR_PER_BUFFER): Don't pass it.
12455
12456 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12457 (scrolling_window): Don't pass it.
12458
0f4a96b5
JB
124592011-03-25 Juanma Barranquero <lekktu@gmail.com>
12460
12461 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12462
12463 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12464 and `suffix'.
12465 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12466 of variables specific to SELinux and computation of `encoded_absname'.
12467
12468 * image.c (XPutPixel): Remove unused variable `height'.
12469
12470 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12471
12472 * unexw32.c (get_section_info): Remove unused variable `section'.
12473
12474 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12475 (system_process_attributes): Remove unused variable `sess'.
12476 (sys_read): Remove unused variable `err'.
12477
12478 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12479 (w32_wnd_proc): Remove unused variable `isdead'.
12480 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12481 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12482 (x_create_tip_frame): Remove unused variable `tem'.
12483
12484 * w32inevt.c (w32_console_read_socket):
12485 Remove unused variable `no_events'.
12486
12487 * w32term.c (x_draw_composite_glyph_string_foreground):
12488 Remove unused variable `width'.
12489
1149507c
JB
124902011-03-24 Juanma Barranquero <lekktu@gmail.com>
12491
12492 * w32term.c (x_set_glyph_string_clipping):
12493 Don't pass uninitialized region to CombineRgn.
12494
9c88f339
JB
124952011-03-23 Juanma Barranquero <lekktu@gmail.com>
12496
12497 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12498 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12499 (Fx_close_connection): Remove unused variable `i'.
12500
12501 * w32font.c (w32font_draw): Return number of glyphs.
12502 (w32font_open_internal): Remove unused variable `i'.
12503 (w32font_driver): Add missing initializer.
12504
12505 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12506 (fill_in_menu): Remove unused variable `items_added'.
12507
12508 * w32term.c (last_mouse_press_frame): Remove static global variable.
12509 (w32_clip_to_row): Remove unused variable `f'.
12510 (x_delete_terminal): Remove unused variable `i'.
12511
12512 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12513 (NOTHING): Remove unused static global variable.
12514 (uniscribe_check_otf): Remove unused variable `table'.
12515 (uniscribe_font_driver): Add missing initializers.
12516
dee091a3
JD
125172011-03-23 Julien Danjou <julien@danjou.info>
12518
12519 * term.c (Fsuspend_tty, Fresume_tty):
12520 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12521 * window.c (temp_output_buffer_show):
12522 * insdel.c (signal_before_change):
12523 * frame.c (Fhandle_switch_frame):
12524 * fileio.c (Fdo_auto_save):
12525 * emacs.c (Fkill_emacs):
12526 * editfns.c (save_excursion_restore):
12527 * cmds.c (internal_self_insert):
12528 * callint.c (Fcall_interactively):
12529 * buffer.c (Fkill_all_local_variables):
12530 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12531 Use Frun_hooks.
0f4a96b5 12532 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12533 unconditionally since it does the check itself.
dee091a3 12534
2c520ab5 125352011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12536
c9c49752
PE
12537 Fix more problems found by GCC 4.5.2's static checks.
12538
8abc3f12
PE
12539 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12540 the first time through the loop, since we know p0 < p1 then.
12541 This also avoids a gcc -Wstrict-overflow warning.
12542
a2d26660
PE
12543 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12544 leading to a memory leak, possible in functions like
12545 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12546 of objects (Bug#8318).
a2d26660 12547
916c72e9
PE
12548 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12549 that could (at least in theory) be that large.
12550
19ab8a18
PE
12551 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12552 This is less likely to overflow, and avoids undefined behavior if
12553 overflow does occur. All callers changed. Use strtoul to scan
12554 for the unsigned long integer.
b7cbbd6f
PE
12555 (pint2hrstr): Simplify and tune code slightly.
12556 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12557
f0641eff
PE
12558 * scroll.c (do_scrolling): Work around GCC bug 48228.
12559 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12560
7f650bb9
PE
12561 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12562 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12563 (validate_x_resource_name): Simplify count usage.
12564 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12565
37dd57d1
PE
12566 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12567 fail (Bug#8306).
81e56e61 12568
699979fc 12569 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12570
401bf9b4
PE
12571 * process.c (Fmake_network_process): Use socklen_t, not int,
12572 where POSIX says socklen_t is required in portable programs.
12573 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12574 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12575 (Fmake_network_process, server_accept_connection):
12576 (wait_reading_process_output, read_process_output):
12577 Likewise.
12578
b93aacde
PE
12579 * process.c: Rename or move locals to avoid shadowing.
12580 (list_processes_1, Fmake_network_process):
12581 (read_process_output_error_handler, exec_sentinel_error_handler):
12582 Rename or move locals.
4dc343ee 12583 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12584 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12585 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12586 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12587 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12588
af8a867c 12589 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12590 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12591 Include tparam.h instead, since it declares them.
af8a867c
PE
12592 * cm.h (PC): Remove extern decl; tparam.h now does this.
12593 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12594 * terminfo.c: Include tparam.h, to check interfaces.
12595 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12596 (tparam): Adjust signature to match interface in tparam.h;
12597 this removes some undefined behavior. Check that outstring and len
12598 are zero, which they always are with Emacs.
12599 * tparam.h (PC, BC, UP): New extern decls.
12600
0248044d 12601 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12602 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12603
8ff096c1 12604 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12605 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12606 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12607 (ftfont_list): Remove unused local.
49eaafba
PE
12608 (get_adstyle_property, ftfont_pattern_entity):
12609 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12610 Rename locals to avoid shadowing.
8ff096c1 12611
e2be39f6
PE
12612 * xfont.c (xfont_list_family): Mark var as initialized.
12613
c9735e30
PE
12614 * xml.c (make_dom): Now static.
12615
8f5201ae
PE
12616 * composite.c (composition_compute_stop_pos): Rename local to
12617 avoid shadowing.
b246f932
PE
12618 (composition_reseat_it): Remove unused locals.
12619 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12620 (composition_update_it): Mark var as initialized.
11b61122
PE
12621 (find_automatic_composition): Mark vars as initialized,
12622 with a FIXME (Bug#8290).
8f5201ae 12623
760fbc2c
PE
12624 character.h: Rename locals to avoid shadowing.
12625 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12626 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12627 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12628 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12629 to avoid shadowing.
12630
ff08eb85
PE
12631 * textprop.c (property_change_between_p): Remove; unused.
12632
fc7bf025
PE
12633 * intervals.c (interval_start_pos): Now static.
12634
235d7abc
PE
12635 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12636
44f230aa
SM
12637 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12638 Rename locals to avoid shadowing.
3e7d6594 12639
50060332
PE
12640 * sound.c (wav_play, au_play, Fplay_sound_internal):
12641 Fix pointer signedness.
d01f234b 12642 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12643 (wav_play): Initialize a variable to 0, to prevent undefined
12644 behavior (Bug#8278).
50060332 12645
c4fc4e30
PE
12646 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12647
918436ed
PE
12648 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12649
c939f91b
PE
12650 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12651 clobbering (Bug#8298).
b9c7f648
PE
12652 * sysdep.c (sys_subshell): Likewise.
12653 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12654
6bd8c144
PE
12655 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12656 This should get cleaned up, so that child_setup has the
12657 same signature on all platforms.
12658
7710357c 12659 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12660 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12661
c59da222
CY
126622011-03-22 Chong Yidong <cyd@stupidchicken.com>
12663
12664 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12665 not to be necessary, and produces flickering.
12666
66b87493
GM
126672011-03-20 Glenn Morris <rgm@gnu.org>
12668
12669 * config.in: Remove file.
12670
45b6f6d5
JB
126712011-03-20 Juanma Barranquero <lekktu@gmail.com>
12672
12673 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12674 are now in src/globals.h.
12675 (syms_of_minibuf): Remove spurious & from previous change.
12676
cd394be1 126772011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12678
12679 * minibuf.c (completing-read-function): New variable.
12680 (completing-read-default): Rename from completing-read.
12681 (completing-read): Call completing-read-function.
12682
b14e3e21
CY
126832011-03-19 Juanma Barranquero <lekktu@gmail.com>
12684
12685 * xfaces.c (Fx_load_color_file):
12686 Read color file from absolute filename (bug#8250).
12687
f2b726e6
JB
126882011-03-19 Juanma Barranquero <lekktu@gmail.com>
12689
12690 * makefile.w32-in: Update dependencies.
12691
09f6ff02
EZ
126922011-03-17 Eli Zaretskii <eliz@gnu.org>
12693
12694 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12695
29a6015a
PE
126962011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12697
a3a6c54e
PE
12698 Fix more problems found by GCC 4.5.2's static checks.
12699
b766f867
PE
12700 * process.c (make_serial_process_unwind, send_process_trap):
12701 (sigchld_handler): Now static.
12702
be02381c
PE
12703 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12704 That way, the code declares only the vars that it needs.
12705 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12706 * s/cygwin.h (PTY_ITERATION): Likewise.
12707 * s/darwin.h (PTY_ITERATION): Likewise.
12708 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12709
57048744
PE
12710 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12711 * process.c (allocate_pty): Don't declare stb unless it's needed.
12712
7914961c 12713 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12714 (CONSTANTLIM): Remove; unused.
12715 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12716 Define only if needed.
7914961c 12717
b3967b18
PE
12718 * unexelf.c (unexec): Name an expression,
12719 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12720 Use a different way to cause a compilation error if anyone uses
12721 n rather than nn, a way that does not involve shadowing.
73366a00 12722 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12723
29a6015a
PE
12724 * deps.mk (unexalpha.o): Remove; unused.
12725
43cfc33e 12726 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12727 * unexec.h: New file.
ce701a33
PE
12728 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12729 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12730 Depend on unexec.h.
12731 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12732 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12733 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12734 Change as necessary to match prototype in unexec.h.
ce701a33 12735
01f44d5a
PE
12736 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12737 shadowing.
4f63c6bb 12738 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12739
a6670b0b
PE
12740 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12741 Rename locals to avoid shadowing.
12742
cef2010d 12743 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12744 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12745
d4d7173a
PE
12746 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12747
f08b802a
PE
12748 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12749 warning when compiling print.c.
12750
3ddb0639
PE
12751 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12752 instead of using an uninitialized var.
5ad03b97 12753 (font_sort_entities): Mark var as initialized.
3ddb0639 12754
170a2692
PE
12755 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12756
e663c700
PE
12757 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12758 pointers to constants.
89bc529a 12759 (font_parse_fcname): Remove unused vars.
7b81e2d0 12760 (font_delete_unmatched): Now static.
ea838e10 12761 (font_get_spec): Remove; unused.
13a547c6
PE
12762 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12763 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12764 Rename or move locals to avoid shadowing.
e663c700 12765
2a80c887 12766 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12767 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12768
1384fa33 12769 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12770 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12771
8b2c52e9
PE
12772 * alloc.c (mark_backtrace): Move decl from here ...
12773 * lisp.h: ... to here, so that it can be checked.
12774
475545b5 12775 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12776 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12777 (lisp_indirect_variable): Name an expression,
12778 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12779 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12780
b1349114 12781 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12782 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12783 Use const pointer when appropriate.
b1349114 12784
a2928364
PE
12785 * lisp.h (get_system_name, get_operating_system_release):
12786 Move decls here, to check interfaces.
12787 * process.c (get_operating_system_release): Move decl to lisp.h.
12788 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12789 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12790 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12791 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12792 (Fformat_time_string, Fencode_time, Finsert_char):
12793 (Ftranslate_region_internal, Fformat):
12794 Rename or remove local vars to avoid shadowing.
9710023e 12795 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12796
a415e694
PE
12797 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12798 avoid shadowing.
12799
8ef4622d
PE
12800 * lisp.h (eassert): Check that the argument compiles, even if
12801 ENABLE_CHECKING is not defined.
12802
946f9a5b
PE
12803 * data.c (Findirect_variable): Name an expression, to avoid
12804 gcc -Wbad-function-cast warning.
112396d6 12805 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12806 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12807 (Fmake_variable_buffer_local, Fmake_local_variable):
12808 Mark variables as initialized.
52746918 12809 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12810
e5aab7e7 12811 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12812 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12813 Rename locals to avoid shadowing.
dff45157
PE
12814 (mark_stack): Move local variables into the #ifdef region where
12815 they're used.
7bc26fdb
PE
12816 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12817 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12818 needed otherwise.
12819 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12820 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12821 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12822
e5aab7e7
PE
12823 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12824 avoids undefined behavior in theory.
12825
4da60324
PE
12826 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12827
88043301
PE
12828 Use functions, not macros, for up- and down-casing (Bug#8254).
12829 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12830 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12831 to use the following functions instead of these macros.
12832 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12833 EMACS_INT, since callers assume the returned value fits in int.
12834 (upcase1): Likewise, for UPCASE_TABLE.
12835 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12836 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12837 the race-condition problem in the old DOWNCASE.
88043301 12838
19ed5445
PE
12839 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12840 Rename locals to avoid shadowing.
12841 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12842 (regex_compile, re_search_2, re_match_2_internal):
12843 Remove unused local vars.
952db0d7
PE
12844 (FREE_VAR): Rewrite so as not to use empty "else",
12845 which gcc can warn about.
da053e48 12846 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12847 (RETALLOC_IF): Define only if needed.
12848 (WORDCHAR_P): Likewise. This one is never needed, but is used
12849 only in a comment talking about a compiler bug, so put inside
12850 the #if 0 of that comment.
12851 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12852 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12853 Remove; unused.
19ed5445 12854
1f3561e4 12855 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12856 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12857 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12858
ded6f8f7
PE
12859 * search.c (simple_search): Remove unused var.
12860
dbd37a95
PE
12861 * dired.c (compile_pattern): Move decl from here ...
12862 * lisp.h: ... to here, so that it can be checked.
12863 (struct re_registers): New forward decl.
12864
7e47afad
PE
12865 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12866
85f24f61
PE
12867 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12868 All uses changed.
12869 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12870 Rename locals to avoid shadowing.
5671df8f 12871 (Fvertical_motion): Mark locals as initialized.
85f24f61 12872
181aa2be 12873 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12874 (casify_region): Mark local as initialized.
181aa2be 12875
930d429c
PE
12876 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12877
7082eac6
PE
12878 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12879 New macros, so that the caller can use some names other than
12880 gcpro1, gcpro2, etc.
12881 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12882 of the new macros.
12883 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12884 argument, for consistency with GCPRO2_VAR, etc: it is now the
12885 prefix of the variable, not the variable itself. All uses
12886 changed.
38b2c076
PE
12887 * dired.c (directory_files_internal, file_name_completion):
12888 Rename locals to avoid shadowing.
12889
15206ed9
PE
12890 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12891 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12892 dired.c's scmp function, had undefined behavior.
12893 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12894 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12895 * buffer.h: ... to here, because these macros use current_buffer,
12896 and the new implementation with inline functions needs to have
12897 current_buffer in scope now, rather than later when the macros
12898 are used.
12899 (downcase, upcase1): New static inline functions.
12900 (DOWNCASE, UPCASE1): Reimplement using these functions.
12901 This avoids undefined behavior in expressions like
12902 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12903 from race conditions in accessing the global variables
12904 case_temp1 and case_temp2.
12905 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12906 * lisp.h (case_temp1, case_temp2): Remove their decls.
12907 * character.h (ASCII_CHAR_P): Move from here ...
12908 * lisp.h: ... to here, so that the inline functions mentioned
12909 above can use them.
12910
4a6bea26
PE
12911 * dired.c (directory_files_internal_unwind): Now static.
12912
f14b7e14
PE
12913 * fileio.c (file_name_as_directory, directory_file_name):
12914 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12915 Now static.
2893f146
PE
12916 (file_name_as_directory): Use const pointers when appropriate.
12917 (Fexpand_file_name): Likewise. In particular, newdir might
12918 point at constant storage, so make it a const pointer.
fd4ead52 12919 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12920 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12921 signedness issues.
f839df0c
PE
12922 (Fset_file_times, Finsert_file_contents, auto_save_error):
12923 Rename locals to avoid shadowing.
f14b7e14 12924
5716756e 12925 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12926 (Ftry_completion, Fall_completions): Rename or remove locals
12927 to avoid shadowing.
5716756e 12928
b4c3046a
PE
12929 * marker.c (bytepos_to_charpos): Remove; unused.
12930
b45db522
PE
12931 * lisp.h (verify_bytepos, count_markers): New decls,
12932 so that gcc does not warn that these functions aren't declared.
12933
85876d07
PE
12934 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12935 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12936 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12937 (copy_text): Remove unused local var.
85876d07 12938
03d78a21 12939 * filelock.c (within_one_second): Now static.
b3dd38ab 12940 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12941
5df8f01b
PE
12942 * buffer.c (fix_overlays_before): Mark locals as initialized.
12943 (fix_start_end_in_overlays): Likewise. This function should be
12944 simplified by using pointers-to-pointers, but that's a different
12945 matter.
b1d876f1 12946 (switch_to_buffer_1): Now static.
8f54f30a
PE
12947 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12948 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12949
a70072c9 12950 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12951 Fix pointer signedness issue.
edced198
PE
12952 (sys_subshell): Mark local as volatile if checking for lint,
12953 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12954 (MAXPATHLEN): Define only if needed.
a70072c9 12955
a0977c44
PE
12956 * process.c (serial_open, serial_configure): Move decls from here ...
12957 * systty.h: ... to here, so that they can be checked.
12958
a884fdcc
PE
12959 * fns.c (get_random, seed_random): Move extern decls from here ...
12960 * lisp.h: ... to here, so that they can be checked.
12961
604efe86 12962 * sysdep.c (reset_io): Now static.
b8950c94 12963 (wait_for_termination_signal): Remove; unused.
604efe86 12964
38fc62d9
PE
12965 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12966 (copy_keymap_item, append_key, push_text_char_description):
12967 Now static.
1004a21a 12968 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12969 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12970 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12971 (describe_map_tree):
12972 Rename locals to avoid shadowing.
38fc62d9 12973
2f2650da
PE
12974 * keyboard.c: Declare functions static if they are not used elsewhere.
12975 (echo_char, echo_dash, cmd_error, top_level_2):
12976 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12977 (read_char, kbd_buffer_get_event, make_lispy_position):
12978 (make_lispy_event, make_lispy_movement, apply_modifiers):
12979 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12980 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12981 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12982 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12983 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12984
a053e86c 12985 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12986 (mark_kboards): Move decl here ...
12987 * alloc.c (mark_kboards): ... from here.
a053e86c 12988
4752793e
PE
12989 * lisp.h (force_auto_save_soon): New decl.
12990
74f10ca7 12991 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12992 (DEFINE_DUMMY_FUNCTION): New macro.
12993 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12994 Use it.
c03cd23f
PE
12995 (main): Add casts to avoid warnings
12996 if GCC considers string literals to be constants.
74f10ca7 12997
022e70d4
PE
12998 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12999
59d6fe83
PE
13000 * dbusbind.c: Pointer signedness fixes.
13001 (xd_signature, xd_append_arg, xd_initialize):
13002 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13003 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13004 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13005 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13006
78320123
PE
13007 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13008 if GCC considers string literals to be constants.
49cebcca 13009 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13010
35ac2a97
SM
130112011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13012
fb103ca9
SM
13013 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13014 (print_preprocess, print_object): New macro to fix last change.
13015
35ac2a97
SM
13016 * print.c (print_preprocess): Don't forget font objects.
13017
62973b41
JB
130182011-03-16 Juanma Barranquero <lekktu@gmail.com>
13019
13020 * emacs.c (USAGE3): Doc fixes.
13021
0e48bb22
AS
130222011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13023
13024 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13025 structure.
13026
7684e57b
JB
130272011-03-14 Juanma Barranquero <lekktu@gmail.com>
13028
13029 * lisp.h (VWindow_system, Qfile_name_history):
13030 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13031 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13032 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13033
13034 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13035 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13036
13037 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13038 * w32console.c (detect_input_pending, read_input_pending)
13039 (encode_terminal_code):
13040 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13041 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13042 (w32_system_caret_y, Qfile_name_history):
13043 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13044 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13045 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13046 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13047 * w32proc.c (Qlocal, report_file_error):
13048 * w32term.c (Vwindow_system, updating_frame):
13049 * w32uniscribe.c (initialized, uniscribe_font_driver):
13050 Remove unneeded extern declarations.
13051
2aa46d6c
CY
130522011-03-14 Chong Yidong <cyd@stupidchicken.com>
13053
c96bbc66 13054 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13055
cffc6f3b
CY
130562011-03-13 Chong Yidong <cyd@stupidchicken.com>
13057
13058 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13059 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13060 These macros can no longer be used for assignment.
13061
44f230aa
SM
13062 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13063 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13064 (record_buffer_markers, fetch_buffer_markers): New functions for
13065 recording and fetching special buffer markers.
13066 (set_buffer_internal_1, set_buffer_temp): Use them.
13067
13068 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13069
13070 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13071
13072 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13073 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13074
13075 * xdisp.c (hscroll_window_tree):
13076 (reconsider_clip_changes): Use PT instead of BUF_PT.
13077
d251f04b
EZ
130782011-03-13 Eli Zaretskii <eliz@gnu.org>
13079
13080 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13081 $(EMACS_ROOT)/lib/intprops.h.
13082
f0c77cd1
PE
130832011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13084
3eca4629
PE
13085 Fix more problems found by GCC 4.5.2's static checks.
13086
7c86ee98
PE
13087 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13088 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13089 (xg_free_frame_widgets): Make it clear that a local variable is
13090 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13091 (gdk_window_get_screen): Make it clear that this macro is needed
13092 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13093 (int_gtk_range_get_value): New function, which avoids a diagnostic
13094 from gcc -Wbad-function-cast.
13095 (xg_set_toolkit_scroll_bar_thumb): Use it.
13096 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13097 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13098 (get_utf8_string, xg_get_file_with_chooser):
13099 Rename locals to avoid shadowing.
13100 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13101
41729b81
PE
13102 * xgselect.c (xg_select): Remove unused var.
13103
f0c77cd1
PE
13104 * image.c (four_corners_best): Mark locals as initialized.
13105 (gif_load): Initialize transparent_p to zero (Bug#8238).
13106 Mark another local as initialized.
ec6cf4c6 13107 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13108
ce0ad53d 13109 * image.c (clear_image_cache): Now static.
d5d5a617 13110 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13111 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13112 (x_edge_detection): Remove unnecessary cast that
13113 gcc -Wbad-function-cast diagnoses.
2037898d 13114 (gif_load): Fix pointer signedness.
6ae141d6
PE
13115 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13116 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13117
33383987 131182011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13119
d32df629
PE
13120 Improve quality of tests for time stamp overflow.
13121 For example, without this patch (encode-time 0 0 0 1 1
13122 1152921504606846976) returns the obviously-bogus value (-948597
13123 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13124 reports time overflow. See
13125 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13126 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13127 * editfns.c: Include limits.h and intprops.h.
13128 (TIME_T_MIN, TIME_T_MAX): New macros.
13129 (time_overflow): Move earlier, to before first use.
13130 (hi_time, lo_time): New functions, for an accurate test for
13131 out-of-range times.
13132 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13133 (Fget_internal_run_time): Don't assume time_t fits in int.
13134 (make_time): Use list2 instead of Fcons twice.
13135 (Fdecode_time): More accurate test for out-of-range times.
13136 (check_tm_member): New function.
13137 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13138 (lisp_time_argument): Don't rely on undefined left-shift and
13139 right-shift behavior when checking for time stamp overflow.
8be6f318 13140
fe31d94c
PE
13141 * editfns.c (time_overflow): New function, refactoring common code.
13142 (Fformat_time_string, Fdecode_time, Fencode_time):
13143 (Fcurrent_time_string): Use it.
13144
8be6f318
PE
13145 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13146 * dired.c (make_time): Move to ...
13147 * editfns.c (make_time): ... here.
13148 * systime.h: Note the move.
13149
09d9db2c 131502011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13151
126bc0dc
YM
13152 * fringe.c (update_window_fringes): Remove unused variables.
13153
c47cbdfd
YM
13154 * unexmacosx.c (copy_data_segment): Also copy __got section.
13155 (Bug#8223)
13156
7ac80be9
EZ
131572011-03-12 Eli Zaretskii <eliz@gnu.org>
13158
c96bbc66 13159 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13160 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13161 Constify `char *' arguments and their references according to
13162 prototypes in tparam.h.
13163
ecb0f94d 13164 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13165
7ac80be9
EZ
13166 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13167 Adapt all references accordingly.
13168
13169 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13170
ef1fd07e
TT
131712011-03-11 Tom Tromey <tromey@redhat.com>
13172
13173 * buffer.c (syms_of_buffer): Remove obsolete comment.
13174
7ef4b50c
EZ
131752011-03-11 Eli Zaretskii <eliz@gnu.org>
13176
13177 * termhooks.h (encode_terminal_code): Declare prototype.
13178
13179 * msdos.c (encode_terminal_code): Don't declare prototype.
13180
13181 * term.c (encode_terminal_code): Now external again, used by
13182 w32console.c and msdos.c.
13183
44f230aa
SM
13184 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13185 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13186
4b1ec863 131872011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13188
1714f52b 13189 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13190
4b1ec863
PE
13191 * fringe.c (update_window_fringes): Mark locals as initialized
13192 (Bug#8227).
13193 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13194
524c7aa6
PE
13195 * alloc.c (mark_fringe_data): Move decl from here ...
13196 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13197 to check its interface.
13198 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13199
a5c0af81 13200 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13201 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13202 (fontset_font): Mark local as initialized.
a9a06e0b 13203 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13204
b4716021
PE
13205 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13206
811e9bac 13207 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13208 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13209 (x_own_selection, Fx_disown_selection_internal): Rename locals
13210 to avoid shadowing.
13211 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13212
7e3ab302
PE
13213 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13214 so that the caller can use some name other than gcpro1.
13215 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13216 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13217 (Fx_backspace_delete_keys_p):
13218 Use them to avoid shadowing, and rename vars to avoid shadowing.
13219 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13220 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13221 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13222 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13223 Remove unused locals.
7e3ab302
PE
13224 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13225 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13226 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13227 macros.
f78faa98 13228
e2b13473
PE
13229 * xterm.h (x_mouse_leave): New decl.
13230
77f23912
PE
13231 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13232 Remove unused functions.
cdf4ba58
PE
13233 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13234 (x_calc_absolute_position): Now static.
7411c686 13235 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13236 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13237 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13238 unless they are used.
38d0b34a
PE
13239 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13240 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13241 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13242 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13243 (x_error_catcher, x_connection_closed, x_error_handler):
13244 (x_error_quitter, xembed_send_message, x_iconify_frame):
13245 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13246 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13247 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13248
44f230aa
SM
13249 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13250 Rename or move locals to avoid shadowing.
6b463e58 13251 (tty_defined_color, merge_face_heights): Now static.
5967d051 13252 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13253 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13254 does not deduce is never used uninitialized.
73719eba
PE
13255 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13256 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13257
426994c3 13258 * terminal.c (store_terminal_param): Now static.
5489860b 13259
032f1620 13260 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13261 (set_frame_menubar): Remove unused local.
d4323972 13262 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13263 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13264 since they might point to immutable storage.
281585b0
PE
13265 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13266 since it's unused otherwise.
032f1620 13267
367c19e5 13268 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13269 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13270 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13271 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13272 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13273 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13274 does not deduce are never used uninitialized.
70739cbe 13275
07b48fa9
PE
13276 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13277
8868a238 13278 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13279 * window.c (window_loop, size_window):
13280 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13281
7e5cf297 13282 * window.c (display_buffer): Now static.
d6550a9f
PE
13283 (size_window): Mark variables that gcc -Wuninitialized
13284 does not deduce are never used uninitialized.
a586633d
PE
13285 * window.h (check_all_windows): New decl, to forestall
13286 gcc -Wmissing-prototypes diagnostic.
5b555da1 13287 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13288
f6095868
PE
13289 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13290 shadowing.
13291 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13292 Include <limits.h>.
13293 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13294 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13295 (load_charset_map): Mark variables that gcc -Wuninitialized
13296 does not deduce are never used uninitialized.
53df7c11 13297 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13298
f38b440c
PE
13299 * coding.c (coding_set_source, coding_set_destination):
13300 Use "else { /* comment */ }" rather than "else /* comment */;"
13301 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13302 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13303 a block, when the outer 'i' will do.
13304 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13305 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13306 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13307 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13308 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13309 Rename locals to avoid shadowing.
13310 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13311 * coding.c (emacs_mule_char, encode_invocation_designation):
13312 Now static, since they're not used elsewhere.
413bb2db 13313 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13314 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13315 (decode_coding_emacs_mule): Mark variables that gcc
13316 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13317 (detect_coding_iso_2022): Initialize a local variable that might
13318 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13319 this initialization is needed. (Bug#8211)
5f58e762
PE
13320 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13321 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13322 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13323 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13324 Remove unused macros.
f38b440c 13325
232b38b9 13326 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13327 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13328 * character.c (string_count_byte8): Likewise.
232b38b9 13329
fb90da1b
PE
13330 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13331 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13332
fb93dbc2
PE
13333 * chartab.c (copy_sub_char_table): Now static, since it's not used
13334 elsewhere.
5c156ace
PE
13335 (sub_char_table_ref_and_range, char_table_ref_and_range):
13336 Rename locals to avoid shadowing.
bbcd0949 13337 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13338
7d3b3862 13339 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13340 (BIDI_BOB): Remove unused macro.
7d3b3862 13341
6be7d3da
PE
13342 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13343 deduce are never used uninitialized.
c2ed9c8b 13344 * term.c (encode_terminal_code): Likewise.
6be7d3da 13345
75f8807f 13346 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13347
50938595
PE
13348 * tparam.h: New file.
13349 * term.c, tparam.h: Include it.
13350 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13351 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13352 Move these decls to tparam.h, and make them agree with what
13353 is actually in tparam.c. The previous trick of using incompatible
13354 decls in different modules does not conform to the C standard.
13355 All callers of tparam changed to use tparam's actual API.
13356 * tparam.c (tparam1, tparam, tgoto):
13357 Use const pointers where appropriate.
13358
fbceeba2
PE
13359 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13360 * cm.h (struct cm): Likewise.
13361 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13362 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13363 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13364 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13365 (turn_on_face, init_tty): Likewise.
13366 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13367
7f3f1250
PE
13368 * term.c (term_mouse_position): Rename local to avoid shadowing.
13369
e6ca6543
PE
13370 * alloc.c (mark_ttys): Move decl from here ...
13371 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13372
c40f8d15
AS
133732011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13374
13375 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13376
cfe0661d
JB
133772011-03-09 Juanma Barranquero <lekktu@gmail.com>
13378
13379 * search.c (compile_pattern_1): Remove argument regp, unused since
13380 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13381 (compile_pattern): Don't pass it.
13382
0afb4571
J
133832011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13384
13385 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13386 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13387 for ! HAVE_GTK3.
13388 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13389
13390 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13391
13392 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13393 gdk_window_get_screen, gdk_window_get_geometry,
13394 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13395 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13396 (xg_get_pixbuf_from_pixmap): New function.
13397 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13398 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13399 Call xg_get_pixbuf_from_pixmap instead of
13400 gdk_pixbuf_get_from_drawable.
13401 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13402 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13403 (xg_check_special_colors): Use GtkStyleContext and its functions
13404 for HAVE_GTK3.
13405 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13406 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13407 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13408 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13409 Call gtk_widget_get_preferred_size.
0afb4571
J
13410 (xg_frame_resized): gdk_window_get_geometry only takes 5
13411 parameters.
44f230aa
SM
13412 (xg_win_to_widget, xg_event_is_for_menubar):
13413 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13414 (xg_set_widget_bg): New function.
13415 (delete_cb): New function.
895009e1 13416 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13417 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13418 (xg_set_background_color): Call xg_set_widget_bg.
13419 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13420 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13421 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13422 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13423 if ! HAVE_GTK3.
13424 (update_frame_tool_bar): Call gtk_widget_hide.
13425 (xg_initialize): Use GDK_KEY_g.
13426
13427 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13428 if ! HAVE_GTK3
13429 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13430
13431 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13432 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13433 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13434
1c2cc4ef
JB
134352011-03-08 Juanma Barranquero <lekktu@gmail.com>
13436
13437 * w32xfns.c (select_palette): Check success of RealizePalette against
13438 GDI_ERROR, not zero.
13439
33383987 13440See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13441
13442;; Local Variables:
13443;; coding: utf-8
aac0c6e3
MR
13444;; End:
13445
2f097256 13446 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13447
13448 This file is part of GNU Emacs.
13449
13450 GNU Emacs is free software: you can redistribute it and/or modify
13451 it under the terms of the GNU General Public License as published by
13452 the Free Software Foundation, either version 3 of the License, or
13453 (at your option) any later version.
13454
13455 GNU Emacs is distributed in the hope that it will be useful,
13456 but WITHOUT ANY WARRANTY; without even the implied warranty of
13457 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13458 GNU General Public License for more details.
13459
13460 You should have received a copy of the GNU General Public License
13461 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.