Fix minor ralloc.c problems found by static checking.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9426aba4
PE
12012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2
3539f31f
PE
3 Fix minor ralloc.c problems found by static checking.
4 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
6 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
7 (r_alloc_sbrk): Now static.
8
a041960a
PE
9 Improve ralloc.c interface checking.
10 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
11 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
12 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
13 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
14 [REL_ALLOC]: ... to here, to check interface.
15 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
16 Remove decls. This fixes an "It stinks!".
17
9426aba4
PE
18 * alloc.c (which_symbols): Fix alignment issue / type clash.
19
d55c12ed
AS
202012-04-15 Andreas Schwab <schwab@linux-m68k.org>
21
22 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
23 (struct Lisp_Misc_Any): Likewise.
24 (struct Lisp_Free): Likewise.
25 * alloc.c (union aligned_Lisp_Symbol): Define.
26 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
27 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
28 (union aligned_Lisp_Misc): Define.
29 (MARKER_BLOCK_SIZE, struct marker_block): Use union
30 aligned_Lisp_Misc instead of union Lisp_Misc.
31 (Fmake_symbol, allocate_misc, gc_sweep): Adjust
32
b948ce8b
PE
332012-04-14 Paul Eggert <eggert@cs.ucla.edu>
34
35 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
36 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
37 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
38 * s/netbsd.h, s/sol2-6.h:
39 Remove definition of GC_MARK_STACK, since the default now works.
40 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
41 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
42 no longer the default.
43 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
44
35dc09a1 452012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 46
35dc09a1
GM
47 * lread.c (lisp_file_lexically_bound_p):
48 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 49
35dc09a1
GM
502012-04-14 Eli Zaretskii <eliz@gnu.org>
51
52 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
53 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
54
552012-04-14 Jan Djärv <jan.h.d@swipnet.se>
56
57 * nsterm.m (constrainFrameRect): Always constrain when there is only
58 one screen (Bug#10962).
59
bcd86815
KB
602012-04-13 Ken Brown <kbrown@cornell.edu>
61
62 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
63
c25df26e
RT
642012-04-13 Reuben Thomas <rrt@sc3d.org>
65
66 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
67
0fc59f1e
DC
682012-04-11 Daniel Colascione <dancol@dancol.org>
69
70 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
71 against is gone. It's better to use vfork now so that when Cygwin
72 gains a new, working vfork, we use it automatically (bug#10398).
73
de8c03dc
SM
742012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
75
76 * window.c (save_window_save): Obey window-point-insertion-type.
77
2f097256
GM
782012-04-11 Glenn Morris <rgm@gnu.org>
79
80 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
81
453b951e
SM
822012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
83
84 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
85
75f1671a 862012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
87
88 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
89 (force_quit_count): New var.
90 (handle_interrupt): Use it.
91
2a8ce227
JB
922012-04-10 Juanma Barranquero <lekktu@gmail.com>
93
94 * w32.c (w32_delayed_load): Record the full path of the library
95 being loaded (bug#10424).
96
935396c0
GM
972012-04-09 Glenn Morris <rgm@gnu.org>
98
05920a43
GM
99 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
100 not just in the obarray, before snarfing them. (Bug#11036)
101
935396c0
GM
102 * Makefile.in ($(leimdir)/leim-list.el):
103 Pass EMACS rather than BUILT_EMACS.
104
a18ecafa
TZ
1052012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
106
107 * process.c (make_process):
108 * process.h: Add integer `gnutls_handshakes_tried' member to
109 process struct.
110
6bbef4e5
JC
111 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
112 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
113
114 * gnutls.c (gnutls_log_function2i): Convenience log function.
115 (emacs_gnutls_read): Use new log functions,
116 `gnutls_handshakes_tried' process member, and
117 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
118 attempts per process (connection).
119
b4d3bc10
CY
1202012-04-09 Chong Yidong <cyd@gnu.org>
121
122 * eval.c (Fuser_variable_p, user_variable_p_eh)
123 (lisp_indirect_variable): Functions deleted.
124 (Fdefvar): Caller changed.
125
126 * callint.c (Finteractive, Fcall_interactively):
127 * minibuf.c (Fread_variable): Callers changed.
128
70f4d973
EZ
1292012-04-09 Eli Zaretskii <eliz@gnu.org>
130
131 * xdisp.c (set_cursor_from_row): If the display string appears in
132 the buffer at position that is closer to point than the position
133 after the display string, display the cursor on the first glyph of
134 the display string. Fixes cursor display when a 'display' text
135 property immediately follows invisible text. (Bug#11094)
136
cb3c2e3e
PE
1372012-04-09 Paul Eggert <eggert@cs.ucla.edu>
138
139 composite.c: use 'double' consistently
140 * composite.c (get_composition_id): Use 'double' consistently
141 instead of converting 'float' to 'double' and vice versa; this is
142 easier to understand and avoids a GCC warning.
143
fd06db5d
GM
1442012-04-09 Glenn Morris <rgm@gnu.org>
145
50fe702a
GM
146 * Makefile.in: Generate leim-list with bootstrap-emacs, in
147 preparation for dumping it with emacs. (Bug#4789)
148 (leimdir): New variable.
149 ($(leimdir)/leim-list.el): New rule.
150 (emacs$(EXEEXT)): Depend on leim-list.el.
151
fd06db5d
GM
152 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
153 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
154 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
155
55c131ee
AS
1562012-04-08 Andreas Schwab <schwab@linux-m68k.org>
157
158 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
159 proper alignment.
160
9209588f
JB
1612012-04-07 Juanma Barranquero <lekktu@gmail.com>
162
163 * xml.c (init_libxml2_functions) [WINDOWSNT]:
164 Remove unused local variable.
165
e3fb2efb
PE
1662012-04-07 Paul Eggert <eggert@cs.ucla.edu>
167
168 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
169 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
170 (mark_memory): Mark Lisp_Objects only if pointers might hide in
171 objects, as mark_maybe_pointer will catch them otherwise.
172 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
173 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
174
b5385551
PE
1752012-04-07 Paul Eggert <eggert@cs.ucla.edu>
176
177 Fix typo that broke non-Windows builds.
178 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
179
9078ead6
EZ
1802012-04-07 Eli Zaretskii <eliz@gnu.org>
181
182 Support building on MS-Windows with libxml2.
183
184 * makefile.w32-in (OBJ2): Add xml.$(O).
185 (GLOBAL_SOURCES): Add xml.c.
186 ($(BLD)/xml.$(O)): New dependency list.
187
188 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
189 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
190 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
191 [!WINDOWSNT]: New macros.
192 (init_libxml2_functions, libxml2_loaded_p): New functions.
193 (parse_region): Call fn_xmlCheckVersion instead of using the macro
194 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
195 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
196 Calls xmlCleanupParser only if libxml2 was loaded (or statically
197 linked in).
6bbef4e5
JC
198 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
199 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
200 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
201
202 * emacs.c: Don't include libxml/parser.h.
203 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
204 xmlCleanupParser directly.
205
206 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
207
3811fdf3
EZ
2082012-04-07 Eli Zaretskii <eliz@gnu.org>
209
210 * indent.c (Fvertical_motion): If there is a display string at
211 point, use it.vpos to compute how many lines to backtrack after
212 move_it_to point. (Bug#11133)
213
2f8e16b2
EZ
2142012-04-06 Eli Zaretskii <eliz@gnu.org>
215
216 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
217 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
218 about subtle differences between FETCH_CHAR* and STRING_CHAR*
219 macros related to unification of CJK characters. For the details,
220 see the discussion following the message here:
221 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
222
3d439cd1
CY
2232012-04-04 Chong Yidong <cyd@gnu.org>
224
225 * keyboard.c (Vdelayed_warnings_list): Doc fix.
226
8bc53d00
EZ
2272012-04-01 Eli Zaretskii <eliz@gnu.org>
228
229 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
230 instead of alloca. (Bug#11138)
231
3b0512a3
AS
2322012-04-01 Andreas Schwab <schwab@linux-m68k.org>
233
234 * w32menu.c (is_simple_dialog): Properly check lisp types.
235 (Bug#11141)
236
8427ddd2
EZ
2372012-03-31 Eli Zaretskii <eliz@gnu.org>
238
979022ef
EZ
239 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
240 position we get to after a call to move_it_to fails the
241 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
242 only if we wind up in a string from display property. (Bug#11063)
243
a6b1c7cc
EZ
244 * window.c (Fdelete_other_windows_internal): Invalidate the row
245 and column information about mouse highlight, so that redisplay
246 restores it after reallocating the glyph matrices. (Bug#7464)
247
8427ddd2
EZ
248 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
249 string comes from a `display' text property, use the buffer
250 position of that property as if we actually saw that position in
251 the row's glyphs.
697ba24b
EZ
252 (move_it_by_lines): Remove the assertion that
253 "it->current_x == 0 && it->hpos == 0" which can be legitimately
254 violated when there's a before-string at the beginning of a line.
255 (Bug#11063)
8427ddd2 256
65a0a738
EZ
2572012-03-30 Eli Zaretskii <eliz@gnu.org>
258
259 * xdisp.c (append_space_for_newline): If the default face was
260 remapped, use the remapped face for the appended newline.
261 (extend_face_to_end_of_line): Use the remapped default face for
262 extending the face to the end of the line.
263 (display_line): Call extend_face_to_end_of_line when the default
264 face was remapped. (Bug#11068)
265
581355cc
EZ
2662012-03-29 Eli Zaretskii <eliz@gnu.org>
267
268 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
269
e8fc049f
SM
2702012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
271
272 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
273
4fb9a543
GM
2742012-03-27 Glenn Morris <rgm@gnu.org>
275
276 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
277 Doc fixes.
278
679910f1
KH
2792012-03-26 Kenichi Handa <handa@m17n.org>
280
281 * dispextern.h (struct glyph): Fix previous change. Change the
282 bit length of glyphless.ch to 25 (Bug#11082).
283
90d49b7f
CY
2842012-03-26 Chong Yidong <cyd@gnu.org>
285
286 * keyboard.c (Vselection_inhibit_update_commands): New variable.
287 (command_loop_1): Use it; inhibit selection update for
288 handle-select-window too (Bug#8996).
289
f514f6f0
FP
2902012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
291
e8fc049f 292 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 293
bf43fa51
KH
2942012-03-25 Kenichi Handa <handa@m17n.org>
295
296 * dispextern.h (struct glyph): Change the bit length of
297 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
298
8a0c01dd
EZ
2992012-03-24 Eli Zaretskii <eliz@gnu.org>
300
301 * s/ms-w32.h (tzname): Include time.h before redirecting to
302 _tzname. Fixes the MSVC build. (Bug#9960)
303
7d1c3a76
AS
3042012-03-24 Andreas Schwab <schwab@linux-m68k.org>
305
8ed79523
AS
306 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
307 characters.
308
7d1c3a76
AS
309 * xterm.c (XTread_socket): Only modify handling_signal if
310 !SYNC_INPUT. (Bug#11080)
311
e99a9b8b
EZ
3122012-03-23 Eli Zaretskii <eliz@gnu.org>
313
314 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
315 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
316 when fetching a multibyte character consumes more bytes than
317 CHAR_BYTES returns, due to unification of CJK characters in
318 string_char. (Bug#11073)
319
5063c0e1
TN
3202012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
321
322 * process.c (wait_reading_process_output): Handle pty disconnect
323 by refraining from sending oneself a SIGCHLD (bug#10933).
324
9f851fbd
CY
3252012-03-22 Chong Yidong <cyd@gnu.org>
326
327 * dispextern.h (struct it): New member string_from_prefix_prop_p.
328
5063c0e1 329 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
330 Mark string as coming from a prefix property.
331 (handle_face_prop): Use default face for prefix strings (Bug#4281).
332 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
333
fb5b8aca
CY
3342012-03-21 Chong Yidong <cyd@gnu.org>
335
336 * xfaces.c (Vface_remapping_alist): Doc fix.
337
62356a1b
EZ
3382012-03-20 Eli Zaretskii <eliz@gnu.org>
339
340 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
341 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
342 Doc fixes.
62356a1b 343
025de85b
CY
3442012-03-20 Chong Yidong <cyd@gnu.org>
345
346 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
347 to reflect default non-nil value of redisplay-dont-pause.
348
4827f94e
KH
3492012-03-19 Kenichi Handa <handa@m17n.org>
350
351 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
352 it fit in a valid range (Bug#11003).
353
e50a24a2
EZ
3542012-03-18 Eli Zaretskii <eliz@gnu.org>
355
356 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
357 that is not from display property, accept the row as a "cursor
358 row" if one of the string's character has a non-nil `cursor'
359 property. Fixes cursor positioning when there are newlines in
360 overlay strings, e.g. in icomplete.el. (Bug#11035)
361
9af5ed87
PE
3622012-03-12 Paul Eggert <eggert@cs.ucla.edu>
363
364 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
365
d1f55f16
CY
3662012-03-12 Chong Yidong <cyd@gnu.org>
367
368 * eval.c (inhibit_lisp_code): Rename from
369 inhibit_window_configuration_change_hook; move from window.c.
370
371 * xfns.c (unwind_create_frame_1, Fx_create_frame):
372 * window.c (run_window_configuration_change_hook)
373 (syms_of_window): Callers changed.
374
66c5eebd
CY
3752012-03-11 Chong Yidong <cyd@gnu.org>
376
413df973
CY
377 * keymap.c (Fkey_description): Doc fix (Bug#9700).
378
66c5eebd
CY
379 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
380
1de11f56
CY
3812012-03-10 Chong Yidong <cyd@gnu.org>
382
383 * frame.c (other_visible_frames): Don't assume the selected frame
384 is visible (Bug#10955).
385
cae07000
SM
3862012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
387
388 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
389
89c94350
JD
3902012-03-08 Jan Djärv <jan.h.d@swipnet.se>
391
392 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
393 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
394 zero (Bug#10954).
395
999dd333
GM
3962012-03-03 Glenn Morris <rgm@gnu.org>
397
01a6dcc8 398 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 399
de0100f2
EZ
4002012-03-02 Eli Zaretskii <eliz@gnu.org>
401
402 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
403 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
404 (redisplay_window, next_element_from_string): Fix typos in
405 comments.
3e441275
EZ
406 (redisplay_window): Pass to move_it_vertically the margin in
407 pixels, not in screen lines.
de0100f2 408
96a72ee9
GM
4092012-03-02 Glenn Morris <rgm@gnu.org>
410
411 * buffer.c (buffer-list-update-hook): Doc fix.
412
312508d7
EZ
4132012-02-29 Eli Zaretskii <eliz@gnu.org>
414
415 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
416 push_it before setting up the iterator for the first overlay
417 string, even if we have an empty string loaded.
418 (next_overlay_string): If there's an empty string on the iterator
419 stack, pop the stack. (Bug#10903)
420
27f3c637
PE
4212012-02-25 Paul Eggert <eggert@cs.ucla.edu>
422
423 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
424 Suggested by Stefan Monnier in
425 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
426 * alloc.c (widen_to_Lisp_Object): New static function.
427 (mark_memory): Also mark Lisp_Objects by fetching pointer words
428 and widening them to Lisp_Objects. This would work even if
429 USE_LSB_TAG is defined and wide integers are used, which might
430 happen in a future version of Emacs.
431
3c9dfce6
CY
4322012-02-25 Chong Yidong <cyd@gnu.org>
433
fa74b241
CY
434 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
435 Doc fix.
436
3c9dfce6
CY
437 * xselect.c (Fx_selection_exists_p): Doc fix.
438 (x_clipboard_manager_save_all): Print an informative message
439 before saving to clipboard manager.
440
9486df08
CY
4412012-02-24 Chong Yidong <cyd@gnu.org>
442
443 * keyboard.c (process_special_events): Handle all X selection
444 requests in kbd_buffer, not just the next one (Bug#8869).
445
f01d3321
CY
4462012-02-23 Chong Yidong <cyd@gnu.org>
447
448 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
449 call when setting menu-bar-lines and tool-bar-lines parameters.
450 (unwind_create_frame_1): New helper function.
451
452 * window.c (inhibit_window_configuration_change_hook): New var.
453 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 454 (syms_of_window): Initialize it.
f01d3321 455
86b847b6
CY
4562012-02-22 Chong Yidong <cyd@gnu.org>
457
458 * xterm.c (x_draw_image_relief): Add missing type check for
459 Vtool_bar_button_margin (Bug#10743).
460
a59225b1
CY
4612012-02-21 Chong Yidong <cyd@gnu.org>
462
463 * fileio.c (Vfile_name_handler_alist): Doc fix.
464
465 * buffer.c (Fget_file_buffer): Protect against invalid file
466 handler return value.
467
310f5bd4
PE
4682012-02-20 Paul Eggert <eggert@cs.ucla.edu>
469
cb3a28cc
PE
470 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
471 when computing $valmask.
472
310f5bd4
PE
473 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
474 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
475 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
476 It's useless in that case, and it can cause problems on hosts
477 that allocate halves of EMACS_INT values separately.
478 Reported by Dan Horák. Diagnosed by Andreas Schwab in
479 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
480 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
481 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
482 it avoids undefined behavior on hosts where shifting right by more
483 than the word width has undefined behavior.
484
2375c96a
CY
4852012-02-19 Chong Yidong <cyd@gnu.org>
486
487 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
488 (Funhandled_file_name_directory, Ffile_name_as_directory)
489 (Fdirectory_file_name, Fexpand_file_name)
490 (Fsubstitute_in_file_name): Protect against invalid file handler
491 return values (Bug#10845).
492
3eb49e71
EZ
4932012-02-18 Eli Zaretskii <eliz@gnu.org>
494
495 * .gdbinit (pitx): Fix incorrect references to fields of the
496 iterator stack.
497
7b926f3f
CY
4982012-02-17 Chong Yidong <cyd@gnu.org>
499
500 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
501
11273115
PE
5022012-02-15 Paul Eggert <eggert@cs.ucla.edu>
503
504 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
505 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
506
c3a70e2b
CY
5072012-02-15 Chong Yidong <cyd@gnu.org>
508
509 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
510 marked as special. Also, starting docstrings with * is obsolete.
511
0ca43699
AS
5122012-02-13 Andreas Schwab <schwab@linux-m68k.org>
513
514 * gnutls.c (emacs_gnutls_write): Fix last change.
515
2e8f3c56
LI
5162012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
517
518 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
519 send_process.
520
af70074f
SM
5212012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
522
523 * keymap.c (Fsingle_key_description): Handle char ranges.
524
95986d52
CY
5252012-02-12 Chong Yidong <cyd@gnu.org>
526
afd83bd1
CY
527 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
528 as that creates a dangerous corner case.
529
95986d52
CY
530 * window.c (Fdelete_window_internal): Invalidate the mouse
531 highlight (Bug#9904).
532
bd7da63e
GM
5332012-02-12 Glenn Morris <rgm@gnu.org>
534
535 * xselect.c (Fx_own_selection_internal)
536 (Fx_get_selection_internal, Fx_disown_selection_internal)
537 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
538 * nsselect.m (Fx_own_selection_internal)
539 (Fx_disown_selection_internal, Fx_selection_exists_p)
540 (Fx_selection_owner_p, Fx_get_selection_internal):
541 Sync docs and argument specs with the xselect.c versions.
542
77abcbc2
LI
5432012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
544
545 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
546
90b671e2
EZ
5472012-02-11 Eli Zaretskii <eliz@gnu.org>
548
1c0ca0b7
EZ
549 * w32select.c (Fx_selection_exists_p): Sync doc string and
550 argument list with xselect.c. (Bug#10783)
551
552 * w16select.c (Fx_selection_exists_p): Sync doc string and
553 argument list with xselect.c. (Bug#10783)
90b671e2 554
49241268
GM
5552012-02-10 Glenn Morris <rgm@gnu.org>
556
557 * fns.c (Fsecure_hash): Doc fix.
558
f998bbe7 5592012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
560
561 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
562
0992bd9c
CY
5632012-02-07 Chong Yidong <cyd@gnu.org>
564
565 * buffer.c (Fbuffer_local_variables)
566 (buffer_lisp_local_variables): Handle unbound vars correctly;
567 don't let Qunbound leak into Lisp.
568
af008560
GM
5692012-02-07 Glenn Morris <rgm@gnu.org>
570
dd605cc4
GM
571 * image.c (Fimagemagick_types): Doc fix.
572
af008560
GM
573 * image.c (imagemagick-render-type): Change it from a lisp object
574 to an integer. Move the doc here from the lisp manual.
575 Treat all values not equal to 0 the same.
576
1449fa1d
CY
5772012-02-06 Chong Yidong <cyd@gnu.org>
578
579 * doc.c (store_function_docstring): Avoid applying docstring of
580 alias to base function (Bug#2603).
581
3723ec07
AS
5822012-02-04 Andreas Schwab <schwab@linux-m68k.org>
583
584 * .gdbinit (pp1, pv1): Remove redundant defines.
585 (pr): Use pp.
586
79c1cc1e
CY
5872012-02-04 Chong Yidong <cyd@gnu.org>
588
589 * nsterm.m: Declare a global (Bug#10694).
590
d7f29f8e
EZ
5912012-02-04 Eli Zaretskii <eliz@gnu.org>
592
cae07000
SM
593 * w32.c (get_emacs_configuration_options):
594 Include --enable-checking, if specified, in the return value.
d7f29f8e 595
3b95a6f9
MR
5962012-02-04 Martin Rudalics <rudalics@gmx.at>
597
598 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
599 after rounding frame sizes. (Bug#9723)
600
d6fa96a6
EZ
6012012-02-04 Eli Zaretskii <eliz@gnu.org>
602
603 * keyboard.c (adjust_point_for_property): Don't position point
604 before BEGV. (Bug#10696)
605
df0b2940
PE
6062012-02-03 Paul Eggert <eggert@cs.ucla.edu>
607
608 Handle overflow when computing char display width (Bug#9496).
609 * character.c (char_width): Return EMACS_INT, not int.
610 (char_width, c_string_width): Check for overflow when
611 computing the width; this is possible now that individual
612 characters can have unbounded width. Problem introduced
613 by merge from Emacs 23 on 2012-01-19.
614
6bee44d6
MA
6152012-02-02 Michael Albinus <michael.albinus@gmx.de>
616
617 * dbusbind.c (Fdbus_register_method): Mention the return value
618 :ignore in the docstring.
619
44f92739
GM
6202012-02-02 Glenn Morris <rgm@gnu.org>
621
1b9f60cc
GM
622 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
623
44f92739
GM
624 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
625 Unconditionally set to t. (Bug#10673)
626 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
627 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
628 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
629
c5d3843c
KH
6302012-02-02 Kenichi Handa <handa@m17n.org>
631
632 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
633 0, do not call append_composite_glyph.
634
159462d4 6352012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
636
637 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
638 NULL (Bug#6988).
639 (x_produce_glyphs): If the component of a composition is a null
640 string, set it->pixel_width to 1 to avoid zero-width glyph.
641
78cef877
EZ
6422012-02-01 Eli Zaretskii <eliz@gnu.org>
643
644 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
645 first 2 arguments are identical. This makes inserting large
646 output from a subprocess an order of magnitude faster on
647 MS-Windows, where all sbrk'ed memory is always contiguous.
648
97897668
GM
6492012-01-31 Glenn Morris <rgm@gnu.org>
650
651 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 652 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
653 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
654
31fd3586
GM
6552012-01-29 Glenn Morris <rgm@gnu.org>
656
657 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
658
0e24a8b2
CY
6592012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
660
661 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
662
cc0adcb0
CY
6632012-01-28 Chong Yidong <cyd@gnu.org>
664
665 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
666
acc28cb9
CY
6672012-01-26 Chong Yidong <cyd@gnu.org>
668
9c69cfb7
CY
669 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
670
acc28cb9
CY
671 * search.c (Fsearch_forward, Fsearch_backward): Document negative
672 repeat counts (Bug#10507).
673
48da7392
GM
6742012-01-26 Glenn Morris <rgm@gnu.org>
675
676 * lread.c (syms_of_lread): Doc fix.
677
14af5f7f
CY
6782012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
679
680 * coding.c (encode_designation_at_bol): Change return value to
681 EMACS_INT.
682
0b21c100
CY
6832012-01-25 Chong Yidong <cyd@gnu.org>
684
685 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
686
3c2907f7
CY
6872012-01-21 Chong Yidong <cyd@gnu.org>
688
689 * floatfns.c (Fcopysign): Make the second argument non-optional,
690 since nil is not allowed anyway.
691
959ad23f
AS
6922012-01-21 Andreas Schwab <schwab@linux-m68k.org>
693
694 * process.c (read_process_output): Use p instead of XPROCESS (proc).
695 (send_process): Likewise.
696
34a02f46
MR
6972012-01-19 Martin Rudalics <rudalics@gmx.at>
698
699 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
700 (Vwindow_persistent_parameters): Do not use Qstate.
701 Rewrite doc-strings.
34a02f46 702
1259009a 7032012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
704
705 * character.c (char_width): New function.
70d4fdf6
GM
706 (Fchar_width, c_string_width, lisp_string_width):
707 Use char_width (Bug#9496).
25ed9e61 708
6a6ee00d
MR
7092012-01-16 Martin Rudalics <rudalics@gmx.at>
710
711 * window.c (Vwindow_persistent_parameters): New variable.
712 (Fset_window_configuration, save_window_save): Handle persistent
713 window parameters.
714
c85efaf7
EZ
7152012-01-14 Eli Zaretskii <eliz@gnu.org>
716
717 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
718 thrashing the stack of the thread. (Bug#9087)
719
5944709e
PE
7202012-01-12 Paul Eggert <eggert@cs.ucla.edu>
721
722 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
723
e71f5d99
EZ
7242012-01-11 Eli Zaretskii <eliz@gnu.org>
725
726 * xdisp.c (rows_from_pos_range): Handle the case where the
727 highlight ends on a newline. (Bug#10464)
728 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
729 he end column for display of highlight that ends on a newline
730 before a R2L line.
731
ce316182
GM
7322012-01-11 Glenn Morris <rgm@gnu.org>
733
734 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
735 from load-path also when installation-directory is nil. (Bug#10208)
736
5b43da69
GM
7372012-01-10 Glenn Morris <rgm@gnu.org>
738
74cc8ff9
GM
739 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
740
7d8d6e4e
GM
741 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
742 Update template values to be closer to their typical values these days.
5b43da69 743
a0db8d43
EZ
7442012-01-09 Eli Zaretskii <eliz@gnu.org>
745
746 * xdisp.c (rows_from_pos_range): Accept additional argument
747 DISP_STRING, and accept any glyph in a row whose object is that
748 string as eligible for mouse highlight. Fixes mouse highlight of
749 display strings from overlays. (Bug#10464)
750
9a0115ab 7512012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 752
b9110d6a 753 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
754 * fileio.c (auto_saving_dir_umask): New static var.
755 (Fmake_directory_internal): Use it.
756 (do_auto_save_make_dir): Set it, instead of invoking chmod after
757 creating the directory. The old code temporarily assigns
758 too-generous permissions to the directory.
759 (do_auto_save_eh): Clear it.
b9110d6a 760 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
761 that the var is always cleared.
762
6c1bd3f3
EZ
7632012-01-07 Eli Zaretskii <eliz@gnu.org>
764
765 * search.c (scan_buffer): Pass character positions to
766 know_region_cache, not byte positions. (Bug#6540)
767
069d2b50
L
7682012-01-07 LynX <_LynX@bk.ru> (tiny change)
769
770 * w32.c (sys_rename): Report EXDEV when rename of a directory
771 fails because the target is on another logical disk. (Bug#10284)
772
75bf0d33
DB
7732012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
774
775 * xterm.c (x_embed_request_focus): New function.
776
777 * xterm.h: Add prototype.
778
779 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
780
1c6e5a32
GM
7812012-01-05 Glenn Morris <rgm@gnu.org>
782
783 * emacs.c (emacs_copyright): Update short copyright year to 2012.
784
651e947e
EZ
7852012-01-01 Eli Zaretskii <eliz@gnu.org>
786
787 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
788 Load gnutls_transport_set_lowat only if GnuTLS version is below
789 2.11.1.
790 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
791 GnuTLS versions below 2.11.1.
792
3778cdd8
AL
7932011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
794
795 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
796 to the doc string advising against its use for altering the way
797 windows are scrolled.
798
0e5317f7
KH
7992011-12-28 Kenichi Handa <handa@m17n.org>
800
801 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
802 coding-system ASCII compatible only when it does not produce BOM
803 on encoding (Bug#10383).
804
93d5ca1f
JD
8052011-12-26 Jan Djärv <jan.h.d@swipnet.se>
806
807 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
808 can scroll.
809 (create_and_show_popup_menu): Always use menu_position_func for
810 Gtk3 (Bug#10361).
811
ca22b785
AS
8122011-12-24 Andreas Schwab <schwab@linux-m68k.org>
813
814 * callint.c (Fcall_interactively): Don't truncate prompt string.
815
d048e1e6
EZ
8162011-12-23 Eli Zaretskii <eliz@gnu.org>
817
818 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
819 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 820 resumed from there (after widening). (Bug#10360)
d048e1e6 821
5ccaba1f
JD
8222011-12-22 Jan Djärv <jan.h.d@swipnet.se>
823
824 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
825
204ee57f
JD
8262011-12-21 Jan Djärv <jan.h.d@swipnet.se>
827
b81d40f0
JB
828 * nsterm.m (x_free_frame_resources):
829 Release f->output_data.ns->miniimage.
204ee57f
JD
830 (ns_index_color): Fix indentation. Do not retain
831 color_table->colors[i].
832
833 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
834 before returning.
835
836 * nsfns.m (x_set_background_color): Assign return value from
837 ns_index_color to face-background instead of NSColor*.
838 (ns_implicitly_set_icon_type): Fix indentation.
839 Change assignment in for loop to comparison.
840
841 * emacs.c (ns_pool): New variable.
842 (main): Assign ns_pool.
843 (Fkill_emacs): Call ns_release_autorelease_pool.
844
845 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
846 autorelease fdesc, release fdAttrs and tdict.
847 (ns_get_covering_families): Release charset.
848 (ns_findfonts): Release NSFontDescriptor created with new.
849 (ns_uni_to_glyphs): Fix indentation.
850 (setString): Release attrStr before assigning new value.
851
c803b2b7
JD
8522011-12-18 Jan Djärv <jan.h.d@swipnet.se>
853
678f4426
JD
854 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
855 and NS_IMPL_COCOA.
856 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
857 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
858
cd394be1 8592011-12-18 David Reitter <reitter@cmu.edu>
678f4426 860
5fecd5fc
JD
861 * nsterm.m (ns_term_init): Subscribe for notifications
862 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
863 to method trackingNotification in EmacsMenu.
864
865 * nsmenu.m (trackingMenu): New variable.
3771cb17 866 (trackingNotification): New method (from Aquamacs).
5fecd5fc 867 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 868 from Aquamacs (Bug#7030).
678f4426
JD
869
8702011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 871
c803b2b7
JD
872 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
873 (symbol_to_nsstring): Fix indentation.
874 (ns_symbol_to_pb): New function.
cae07000
SM
875 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
876 (Fns_rotate_cut_buffers_internal): Remove.
877 (Fns_store_selection_internal): Rename from
c803b2b7
JD
878 Fns_store_cut_buffer_internal.
879 (ns_get_foreign_selection, Fx_own_selection_internal)
880 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
881 (Fns_get_selection_internal, Fns_store_selection_internal):
882 Use ns_symbol_to_pb and check if return value is nil.
883 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
884 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
885 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
886 renamed to Sns_store_selection_internal.
887 (ns_handle_selection_request): Move code to Fx_own_selection_internal
888 and remove this function.
889 (ns_handle_selection_clear): Remove, never used.
890 (Fx_own_selection_internal): Move code from ns_handle_selection_request
891 here.
892
e1b01a3a
KB
8932011-12-17 Ken Brown <kbrown@cornell.edu>
894
895 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
896 GID is unknown (Bug#10257).
897
2adb6e85
PE
8982011-12-17 Paul Eggert <eggert@cs.ucla.edu>
899
900 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
901 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
902 which caused a build failure on GNU/Linux IA-64. This problem was
903 introduced by my 2011-10-07 patch.
904
d1d7b339
JL
9052011-12-15 Juri Linkov <juri@jurta.org>
906
907 * image.c (imagemagick_error): New function. (Bug#10112)
908 (imagemagick_load_image): Comment out `MagickSetResolution' call.
909 Use `imagemagick_error' where ImageMagick functions return
910 `MagickFalse'.
911 (Fimagemagick_types): Add `Fnreverse' to return the list in the
912 proper order.
913
100d5755
KH
9142011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
915
916 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
917 fill background (Bug#8992).
918
454592a6
MR
9192011-12-13 Martin Rudalics <rudalics@gmx.at>
920
921 * window.c (Vwindow_combination_resize)
922 (Vwindow_combination_limit): Use t instead of non-nil in
923 doc-strings.
61d4b438
MR
924 (Vrecenter_redisplay): Add first sentence of doc-string on
925 separate line.
53524d93 926 (Frecenter): Fix doc-string typo.
454592a6 927
3633e3aa
KH
9282011-12-11 Kenichi Handa <handa@m17n.org>
929
930 * coding.c (Funencodable_char_position): Pay attention to the
931 buffer text relocation (Bug#9389).
932
7b9d523a
JD
9332011-12-10 Jan Djärv <jan.h.d@swipnet.se>
934
935 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
936 gtk_init (Bug#10100).
937
b73189c6
EZ
9382011-12-10 Eli Zaretskii <eliz@gnu.org>
939
940 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
941 IT->string is nil. (Bug#10263)
942
f7dfe5d6
JD
9432011-12-10 Jan Djärv <jan.h.d@swipnet.se>
944
83faebb4
JD
945 * nsterm.h (x_free_frame_resources): Declare.
946
f7dfe5d6
JD
947 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
948 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
949
950 * nsterm.h (ns_get_defaults_value): Declare.
951
952 * nsterm.m (ns_default): Call ns_get_defaults_value.
953
7cd4e72c
EZ
9542011-12-09 Eli Zaretskii <eliz@gnu.org>
955
956 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
957 (Bug#10170)
958
b34d7317
YM
9592011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
960
961 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
962 that where the value of an _OBJC_* symbol points to is in the .bss
963 section (Bug#10240).
964
76470ad1
KH
9652011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
966
967 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 968 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 969
745fff94
KH
9702011-12-08 Kenichi Handa <handa@m17n.org>
971
972 * ftfont.c (get_adstyle_property): Fix previous change
973 (Bug#10233).
974
6e44397c
JB
9752011-12-07 Juanma Barranquero <lekktu@gmail.com>
976
977 * w32.c (init_environment): If no_site_lisp, remove site-lisp
978 dirs from the default value of EMACSLOADPATH (bug#10208).
979
7efa6272
GM
9802011-12-07 Glenn Morris <rgm@gnu.org>
981
982 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
983 installation and source directories as well. (Bug#10208)
984
f6fc4d87
CY
9852011-12-06 Chong Yidong <cyd@gnu.org>
986
987 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
988
2bf26180
GM
9892011-12-06 Glenn Morris <rgm@gnu.org>
990
991 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
992 as an error, not just -1. (Bug#10217)
993
3a6ad4f0
CY
9942011-12-05 Chong Yidong <cyd@gnu.org>
995
996 * keyboard.c (process_special_events): New function.
997 (swallow_events, Finput_pending_p): Use it (Bug#10195).
998
75a3b399
PE
9992011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1000
1001 * coding.c (encode_designation_at_bol): Don't use uninitialized
1002 local variable (Bug#9318).
1003
c3c9e25e
KH
10042011-12-05 Kenichi Handa <handa@m17n.org>
1005
1006 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1007 return Qnil (Bug#8046, Bug#10193).
1008
5eb05ea3
KH
10092011-12-05 Kenichi Handa <handa@m17n.org>
1010
1011 * coding.c (encode_designation_at_bol): New args charbuf_end and
1012 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1013 (coding_set_source): Return how many bytes coding->source was
1014 relocated.
1015 (coding_set_destination): Return how many bytes
1016 coding->destination was relocated.
1017 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1018 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1019
10202011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1021
1022 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1023 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1024 macro (Bug#9318).
1025
10262011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1027
1028 The following changes are to fix Bug#9318.
1029
a79703f5 1030 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1031 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1032 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1033 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1034
7dbda6df
JB
10352011-12-05 Juanma Barranquero <lekktu@gmail.com>
1036
1037 * lisp.h (process_quit_flag): Fix external declaration.
1038
6d5eb5b0
SM
10392011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1040
1041 Don't macro-inline non-performance-critical code.
1042 * eval.c (process_quit_flag): New function.
1043 * lisp.h (QUIT): Use it.
1044
a0c3fad0
JD
10452011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1046
1047 * nsfns.m (get_geometry_from_preferences): New function.
1048 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1049
6c07aac2
AS
10502011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1051
1052 * emacs.c (Qkill_emacs): Define.
1053 (syms_of_emacs): Initialize it.
1054 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1055 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1056 (quit_throw_to_read_char): Add parameter `from_signal'.
1057 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1058 * lisp.h (QUIT): Call Fkill_emacs if requested.
1059
c052ead4
JD
10602011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1061
1062 * widget.c (update_wm_hints): Return if wmshell is null.
1063 (widget_update_wm_size_hints): New function.
1064
1065 * widget.h (widget_update_wm_size_hints): Declare.
1066
1067 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1068 widget_update_wm_size_hints (Bug#10104).
1069
9e49252b
EZ
10702011-12-03 Eli Zaretskii <eliz@gnu.org>
1071
1072 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1073 before a newline, prepare the bidi iterator for consuming the
1074 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1075 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1076
02b16839
JL
10772011-12-02 Juri Linkov <juri@jurta.org>
1078
1079 * search.c (Fword_search_regexp): New Lisp function created from
1080 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1081 (Fword_search_backward, Fword_search_forward)
1082 (Fword_search_backward_lax, Fword_search_forward_lax):
1083 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1084 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1085
0068070e
SM
10862011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1087
1088 * fileio.c (Finsert_file_contents): Move after-change-function call
1089 to before the "handled:" label, since all "goto handled" appear in
1090 cases where the *-change-functions have already been properly called
1091 (bug#10117).
1092
3360a3fc
AS
10932011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1094
1095 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1096 waiting for input. (Bug#10169)
1097
73d6c093
EZ
10982011-11-30 Eli Zaretskii <eliz@gnu.org>
1099
1100 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1101 verifies glyph row's hash code--we have just reallocated the
1102 glyphs, so their contents can be complete garbage. (Bug#10164)
1103
febe6bea
JB
11042011-11-30 Juanma Barranquero <lekktu@gmail.com>
1105
1106 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1107
801a4313
EZ
11082011-11-30 Eli Zaretskii <eliz@gnu.org>
1109
1110 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1111 attributes are tested _before_ calling verify_row_hash, to protect
1112 against GCC re-ordering of the tests. (Bug#10164)
1113
2b56b87e
JD
11142011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1115
1116 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1117
1118 * xterm.c (handle_one_xevent): Only set async_visible and friends
1119 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1120 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1121 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1122
dbf31225
PE
11232011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1126 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1127 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1128 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1129 All uses changed to use GCPRO1 etc.
1130 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1131 Revert to old implementation (i.e., before 2011-03-11).
1132
1305621b
YM
11332011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1134
1135 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1136 of scroll runs so as to avoid assigning disabled bogus rows and
1137 unnecessary graphics copy operations.
1138
8c9afb46
EZ
11392011-11-27 Eli Zaretskii <eliz@gnu.org>
1140
1141 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1142 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1143 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1144 (malloc, free, realloc, calloc): Redirect to e_* only when
1145 compiling Emacs.
1146
1147 * lisp.h (GCTYPEBITS): Move before first use.
1148 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1149 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1150 this macro definition.
1151
1152 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1153 _MSC_VER.
1154
54e9e3bf
JD
11552011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1156
6d5eb5b0
SM
1157 * gtkutil.c (xg_create_frame_widgets):
1158 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1159 present with Gtk+ 2.0.
1160
83aca1cb
PE
11612011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 * fileio.c (Finsert_file_contents): Undo previous change; see
1164 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1165
5b76caa4
PE
11662011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1167
1168 Rename locals to avoid shadowing.
1169 * fileio.c (Finsert_file_contents):
1170 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1171 * process.c (wait_reading_process_output):
1172 Rename inner 'proc' to 'p' to avoid shadowing.
1173 Indent for consistency with usual Emacs style.
1174
8c535114
EZ
11752011-11-25 Eli Zaretskii <eliz@gnu.org>
1176
1177 * xdisp.c (redisplay_window): If cursor row is not fully visible
1178 after recentering, and scroll-conservatively is set to a large
1179 number, scroll window by a few more lines to make the cursor fully
1180 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1181 (start_display): Don't move to the next line if the display should
1182 start at a newline that is part of a display vector or an overlay
1183 string. (Bug#10119)
8c535114 1184
fa4fdb5c
JL
11852011-11-24 Juri Linkov <juri@jurta.org>
1186
1187 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1188 after the `MagickPingImage' call. (Bug#10112)
1189
90ec88df
CY
11902011-11-23 Chong Yidong <cyd@gnu.org>
1191
1192 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1193
56e2e794
MR
11942011-11-23 Martin Rudalics <rudalics@gmx.at>
1195
1196 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1197 making another buffer current. (Bug#10114)
1198
b6e64c41
GM
11992011-11-23 Glenn Morris <rgm@gnu.org>
1200
1201 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1202
6b21de18
CY
12032011-11-23 Chong Yidong <cyd@gnu.org>
1204
1205 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1206 using it (Bug#5984).
1207
b12cd789
EZ
12082011-11-22 Eli Zaretskii <eliz@gnu.org>
1209
1210 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1211 and header-lines, as they don't have one computed for them.
1212 (Bug#10098)
1213
1214 * .gdbinit (prow): Make displayed values more self-explaining.
1215 Add row's hash code.
1216
261b6fd4
LMI
12172011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1218
1219 * process.c (wait_reading_process_output): Fix asynchrounous
1220 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1221 (wait_reading_process_output): Add comment and URL.
261b6fd4 1222
e7cfd277
JD
12232011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1224
1225 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1226
a9b9b7f5
CY
12272011-11-21 Chong Yidong <cyd@gnu.org>
1228
1229 * window.c (Fnext_window, Fprevious_window): Doc fix.
1230
b0d15b4f
SM
12312011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1232
1233 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1234
fe7a3057
JB
12352011-11-20 Juanma Barranquero <lekktu@gmail.com>
1236
1237 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1238
d2999b1a
MR
12392011-11-20 Martin Rudalics <rudalics@gmx.at>
1240
1241 * window.c (Fset_window_combination_limit): Rename argument
1242 STATUS to LIMIT.
1243 (Vwindow_combination_limit): Remove "status" from doc-string.
1244
d5ff9cd0
AS
12452011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1246
1247 * m/ibms390.h: Remove.
1248 * m/ibms390x.h: Don't include "ibms390.h".
1249
a5bb9bd3
SM
12502011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1251
1252 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1253 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1254
cd1181db
JB
12552011-11-20 Juanma Barranquero <lekktu@gmail.com>
1256
1257 * casetab.c (Fset_case_table):
1258 * charset.c (Fcharset_after): Fix typos.
1259
615a3b8d 12602011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1261
17e845af
PE
1262 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1263 Otherwise, valgrind does not work on some platforms.
1264 Problem reported by Andreas Schwab in
6a0bf43d
PE
1265 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1266 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1267 is set, removing the need for VIRT_ADDRESS_VARIES.
1268 (PURE_P): Use a more-efficient implementation that needs just one
1269 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1270 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1271 to 4 (xorl, subq, cmpq, setbe).
1272 * alloc.c (pure): Always extern now, since that's the
1273 VIRT_ADDR_VARIES behavior.
1274 (PURE_POINTER_P): Use a single comparison, not two, for
1275 consistency with the new puresize.h.
1276 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1277 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1278 Remove VIRT_ADDR_VARIES no longer needed.
1279
f8fe6f96
EZ
12802011-11-19 Eli Zaretskii <eliz@gnu.org>
1281
1282 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1283 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1284 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1285 behave as if the cursor position were at the window margin.
1286
1287 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1288 and the cursor position is out of bounds, behave as if the cursor
1289 position were at the window margin. (Bug#10075)
1290
df05a53c
CY
12912011-11-18 Chong Yidong <cyd@gnu.org>
1292
1293 * window.c (Fwindow_combination_limit): Make first argument
1294 non-optional, since it is meaningless for live windows like the
1295 selected window.
1296
2071918e
DA
12972011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1298
1299 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1300
b50a28de
SM
13012011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1302
1303 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1304 (graft_intervals_into_buffer): Simplify.
1305
015137db
EZ
13062011-11-18 Eli Zaretskii <eliz@gnu.org>
1307
1308 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1309 hash values of the two rows.
1310 (copy_row_except_pointers): Preserve the used[] arrays and the
1311 hash values of the two rows. (Bug#10035)
68c95424 1312 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1313
1314 * xdisp.c (row_hash): New function, body extracted from
1315 compute_line_metrics.
1316 (compute_line_metrics): Call row_hash, instead of computing the
1317 hash code inline.
1318
1319 * dispnew.c (verify_row_hash): Call row_hash for computing the
1320 hash code of a row, instead of duplicating code from xdisp.c.
1321
1322 * dispextern.h (row_hash): Add prototype.
1323
a2addb04
TH
13242011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1325
1326 * frame.c (delete_frame): Don't delete the terminal when the last
1327 X frame is closed if emacs is built with GTK toolkit.
1328
df85d315
JB
13292011-11-17 Juanma Barranquero <lekktu@gmail.com>
1330
1331 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1332
a0c2d0ae
MR
13332011-11-17 Martin Rudalics <rudalics@gmx.at>
1334
1335 * window.c (Vwindow_splits): Rename to
1336 Vwindow_combination_resize. Suggested by Juri Linkov.
1337 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1338 of Vwindow_splits.
1339
58179cce
JB
13402011-11-16 Juanma Barranquero <lekktu@gmail.com>
1341
7877f373
JB
1342 * nsfns.m (Fns_font_name):
1343 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1344
b6f67890
MR
13452011-11-16 Martin Rudalics <rudalics@gmx.at>
1346
1347 * window.h (window): Rename slot "nest" to "combination_limit".
1348 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1349 (Fset_window_nest): Rename to Fset_window_combination_limit.
1350 (Vwindow_nest): Rename to Vwindow_combination_limit.
1351 (recombine_windows, make_parent_window, make_window)
1352 (Fsplit_window_internal, saved_window)
1353 (Fset_window_configuration, save_window_save): Rename all
1354 occurrences of window_nest to window_combination_limit.
1355
c7015153
JB
13562011-11-15 Juanma Barranquero <lekktu@gmail.com>
1357
1358 * image.c (imagemagick_load_image): Fix typo.
1359
322ad6ec
EZ
13602011-11-14 Eli Zaretskii <eliz@gnu.org>
1361
1362 * xdisp.c (display_line): Move the call to
1363 highlight_trailing_whitespace before the call to
1364 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1365 faces of all the glyphs to compute ROW's hash value.
1366 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1367
f067b8ec
JB
13682011-11-14 Juanma Barranquero <lekktu@gmail.com>
1369
1370 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1371 just return (bug#10044).
1372
1e5b2111
EZ
13732011-11-12 Eli Zaretskii <eliz@gnu.org>
1374
7ef3cbd5
EZ
1375 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1376 with user-defined heap size. Bump the default size of the temacs
1377 heap to 27MB, to avoid memory warning when running temacs.
1378 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1379
1e5b2111
EZ
1380 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1381 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1382 (verify_row_hash) [XASSERTS]: New function.
1383 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1384 that the hash value of glyph rows is correct.
1e5b2111 1385
89d61221
MR
13862011-11-12 Martin Rudalics <rudalics@gmx.at>
1387
1388 * window.h (window): Remove splits slot.
1389 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1390 (Fdelete_other_windows_internal, make_parent_window)
1391 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1392 (Fset_window_configuration, save_window_save): Don't deal with
1393 split status of windows.
1394 (saved_window): Remove splits slot.
1395 (Vwindow_splits): Rewrite doc-string.
1396
97f18cc8
JD
13972011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1398
1399 * xfns.c (unwind_create_frame):
1400 * nsfns.m (unwind_create_frame):
1401 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1402 Vframe_list (Bug#9999).
1403
22a648b4
DA
14042011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1405
0b381c7e 1406 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1407
659afede
KH
14082011-11-11 Kenichi Handa <handa@m17n.org>
1409
1410 * callproc.c (Fcall_process): Set the member dst_multibyte of
1411 process_coding.
1412
9ac0394b
KH
14132011-11-11 Johan Bockgård <bojohan@gnu.org>
1414
1415 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1416 avoid a crash (bug#9496).
1417
2fbdc249
CY
14182011-11-09 Chong Yidong <cyd@gnu.org>
1419
1420 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1421 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1422
ac6b1f81
PE
14232011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1424
1425 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1426
09db192c
PE
14272011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1428
1429 Avoid some portability problems by eschewing 'extern inline' functions.
1430 The trivial performance wins aren't worth the portability hassles; see
1431 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1432 et seq.
1433 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1434 (window_box_width, window_box_left, window_box_left_offset)
1435 (window_box_right, window_box_right_offset): Undo previous change,
1436 by removing the "extern"s.
1437 * intervals.c (adjust_intervals_for_insertion)
1438 (adjust_intervals_for_deletion): Undo previous change,
1439 making these static again.
1440 (offset_intervals, temp_set_point_both, temp_set_point)
1441 (copy_intervals_to_string): No longer inline.
1442 * xdisp.c (window_text_bottom_y, window_box_width)
1443 (window_box_height, window_box_left_offset)
1444 (window_box_right_offset, window_box_left, window_box_right)
1445 (window_box): No longer inline.
1446
105216ed
CY
14472011-11-08 Chong Yidong <cyd@gnu.org>
1448
1449 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1450 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1451 Signal an error if not a live window.
105216ed
CY
1452 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1453 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1454
ae9e237f
JB
14552011-11-07 Juanma Barranquero <lekktu@gmail.com>
1456
1457 * lisp.h (syms_of_abbrev): Remove declaration.
1458 Reported by CHENG Gao <chenggao@royau.me>.
1459
c7aa8333
EZ
14602011-11-07 Eli Zaretskii <eliz@gnu.org>
1461
1462 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1463 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1464 of temacs in GUI mode.
1465
be7f5545
MR
14662011-11-07 Martin Rudalics <rudalics@gmx.at>
1467
1468 * window.h: Declare delete_all_child_windows instead of
1469 delete_all_subwindows.
1470 * window.c (Fwindow_nest, Fset_window_nest)
1471 (Fset_window_new_total, Fset_window_new_normal)
1472 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1473 (delete_all_subwindows): Rename to delete_all_child_windows.
1474 (Fdelete_other_windows_internal, Fset_window_configuration):
1475 Call delete_all_child_windows instead of delete_all_subwindows.
1476 * frame.c (delete_frame): Call delete_all_child_windows instead
1477 of delete_all_subwindows.
1478
ca78dc43
PE
14792011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1482 This is also needed for porting to any host where GC_MARK_STACK is
1483 not GC_MAKE_GCPROS_NOOPS.
1484 (which_symbols): Use it.
1485
a0241d01
KH
14862011-11-07 Kenichi Handa <handa@m17n.org>
1487
1488 * coding.c (coding_set_destination): Check coding->src_pos only
1489 when coding->src_object is a buffer (bug#9910).
1490
1491 * process.c (send_process): Set the member src_multibyte of coding
1492 to 0 (bug#9911) when sending a unibyte text.
1493
1494 * callproc.c (Fcall_process): Set the member src_multibyte of
1495 process_coding to 0 (bug#9912).
1496
a64bfdfa 14972011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1498
1499 * xmenu.c (cleanup_widget_value_tree): New function.
1500 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1501 calling free_menubar_widget_value_tree directly (Bug#9830).
1502
cb41b32a
PE
15032011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1504
1505 Fix some portability problems with 'inline'.
1506 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1507 (window_box_width, window_box_left, window_box_left_offset)
1508 (window_box_right, window_box_right_offset): Declare extern.
1509 Otherwise, these inline functions do not conform to C99 and
1510 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1511 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1512 * intervals.c (adjust_intervals_for_insertion)
1513 (adjust_intervals_for_deletion): Now extern, because otherwise the
1514 extern inline functions 'offset_intervals' couldn't refer to it.
1515 (static_offset_intervals): Remove.
1516 (offset_intervals): Rewrite using the old contents of
1517 static_offset_intervals. The old version didn't conform to C99
1518 because an extern inline function contained a reference to an
1519 identifier with static linkage.
1520
b7041366
AS
15212011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1522
1523 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1524 GC.
1525
88a37c4d
EZ
15262011-11-06 Eli Zaretskii <eliz@gnu.org>
1527
1528 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1529 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1530 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1531 return Qleft_to_right.
1532
49745b39
CY
15332011-11-06 Chong Yidong <cyd@gnu.org>
1534
1535 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1536 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1537 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1538 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1539 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1540 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1541 (Fwindow_vscroll): Doc fix.
1542 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1543 argument, since it makes no sense to pass a live window and for
1544 consistency with window-child.
1545
1f05cd82
CS
15462011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1547
1548 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1549 support MSVC.
1550
22610910
JR
15512011-11-05 Jason Rumney <jasonr@gnu.org>
1552
1553 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1554 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1555 fonts (Bug#6029).
1556 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1557 bitwise arithmetic preventing use of unicode-sip and non-truetype
1558 opentype fonts.
1559
a06776b2
EZ
15602011-11-05 Eli Zaretskii <eliz@gnu.org>
1561
3ad924ba
EZ
1562 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1563 "emacs"-only part.
1564
a06776b2
EZ
1565 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1566 initialization code to keep similarity to xfns.c after changes
1567 from 2011-11-05.
1568
c9e7db78
JD
15692011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1570
a97f8f3f
JD
1571 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1572 (unwind_create_frame): New function (Bug#9943).
1573 (Fx_create_frame): Restructure code to be more similar to the one in
1574 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1575 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1576 Move terminal->reference_count++ just before making the frame official
1577 (Bug#9943).
1578
1579 * nsterm.m (x_free_frame_resources): New function.
1580 (x_destroy_window): Move code to x_free_frame_resources.
1581
c9e7db78 1582 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1583 (Fx_create_frame, x_create_tip_frame):
1584 Move terminal->reference_count++ just before making the frame
75f1671a 1585 official. Move initialization of image_cache_refcount and
c9e7db78
JD
1586 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1587
a6fc3b5c
EZ
15882011-11-05 Eli Zaretskii <eliz@gnu.org>
1589
1590 Support MSVC build with newer versions of Visual Studio.
1591 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1592 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1593 nt/gmake.defs.
1594
1595 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1596 which are not supported by MSVC.
1597 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1598 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1599 bitfields.
1600 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1601 types in bitfields.
1602 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1603
1604 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1605
58179cce 16062011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1607
1608 Support MSVC build with newer versions of Visual Studio.
1609 * w32.c: Don't include w32api.h for MSVC.
1610 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1611
1612 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1613 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1614 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1615 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1616 e_* cousins.
1617 (alloca) [_MSC_VER]: Define to _alloca.
1618
1619 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1620
1621 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1622
a58c13ed
EZ
16232011-11-04 Eli Zaretskii <eliz@gnu.org>
1624
1625 * xdisp.c (note_mouse_highlight): If either of
1626 previous/next-single-property-change returns nil, treat that as
1627 the beginning or the end of the buffer. (Bug#9955)
1628
fe0b6370
JD
16292011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1630
a58c13ed 1631 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1632 label is not null (Bug#9951).
1633 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1634 may be NULL.
1635
89bd5ee1
EZ
16362011-11-04 Eli Zaretskii <eliz@gnu.org>
1637
1638 * window.c (Fwindow_body_size): Mention in the doc string that the
1639 return value is in frame's canonical units. (Bug#9949)
1640
84c3edb9
EZ
16412011-11-03 Eli Zaretskii <eliz@gnu.org>
1642
4e2fb5c7
EZ
1643 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1644
84c3edb9 1645 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1646 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1647 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1648
bc17a887
EZ
16492011-11-01 Eli Zaretskii <eliz@gnu.org>
1650
1651 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1652 Don't stop backward scan on the continuation glyph, even though
1653 its CHARPOS is positive.
6d5eb5b0
SM
1654 (mouse_face_from_buffer_pos, note_mouse_highlight):
1655 Rename cover_string to disp_string.
bc17a887 1656
4ee88440
MR
16572011-11-01 Martin Rudalics <rudalics@gmx.at>
1658
1659 * window.c (temp_output_buffer_show): Don't use
1660 Vtemp_buffer_show_specifiers.
1661 (Vtemp_buffer_show_specifiers): Remove unused variable.
1662
c2ff3c02
EZ
16632011-10-30 Eli Zaretskii <eliz@gnu.org>
1664
1665 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1666 past the beginning of the current glyph matrix.
1667
58179cce 16682011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1669
1670 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1671 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1672 HAVE_GTK3 (Bug#9869).
b77a6a7f 1673
3b574623
JD
1674 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1675 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1676
b77a6a7f
JD
1677 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1678
1679 * xterm.c: Declare x_handle_net_wm_state to return int.
1680 (handle_one_xevent): Check if we are iconified but don't have
1681 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1682 (get_current_wm_state): Return non-zero if not hidden,
1683 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1684 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1685 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1686 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1687
196e41e4
PE
16882011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1689
1690 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1691 so that this new function doesn't get optimized away by a
1692 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1693
021f2e1a
AS
16942011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1695
1696 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1697
8b058d44
EZ
16982011-10-29 Eli Zaretskii <eliz@gnu.org>
1699
1700 Fix the `xbytecode' command.
1701 * .gdbinit (xprintbytestr): New command.
b50a28de 1702 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1703 (xbytecode): Print the byte-code string as well.
1704
4452fb80
EZ
17052011-10-29 Kim Storm <storm@cua.dk>
1706
8b058d44
EZ
1707 * alloc.c (which_symbols): New function.
1708
21b72067
AS
17092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1710
1711 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1712 line. (Bug#9903)
1713
83ed7b5c
GM
17142011-10-29 Glenn Morris <rgm@gnu.org>
1715
1716 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1717 Not clear what it was for, and it causes various bugs. (Bug#9839)
1718
5a7a728b
EZ
17192011-10-28 Eli Zaretskii <eliz@gnu.org>
1720
1721 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1722 possible random value that matches one of those tested as
1723 condition to clear the mouse face.
1724
d3d0842f
CY
17252011-10-28 Chong Yidong <cyd@gnu.org>
1726
1727 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1728
31b39d13
DN
17292011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1730
1731 * window.c (make_window): Initialize phys_cursor_on_p.
1732
9aba6043
SM
17332011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1734
1735 * lisp.h (struct Lisp_Symbol): Update comments.
1736
c20992f4
JB
17372011-10-28 Juanma Barranquero <lekktu@gmail.com>
1738
1739 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1740
db4f02f2
EZ
17412011-10-28 Eli Zaretskii <eliz@gnu.org>
1742
1743 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1744 <oslsachem@gmail.com> for helping to debug this.
1745
1746 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1747 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1748 (g_b_init_get_glyph_outline_w): New static variables.
1749 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1750 (GetGlyphOutlineW_Proc): New typedefs.
1751 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1752 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1753 New functions.
1754 (w32font_open_internal, compute_metrics):
1755 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1756 instead of calling the "wide" APIs directly.
1757
1758 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1759
1760 * w32.h (syms_of_w32font): Add prototype.
1761
87e68db4
JB
17622011-10-27 Juanma Barranquero <lekktu@gmail.com>
1763
1764 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1765 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1766 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1767 (Fmove_to_window_line): Doc fix.
1768
435c1d67
CY
17692011-10-27 Chong Yidong <cyd@gnu.org>
1770
1771 * process.c (make_process): Set gnutls_state to NULL.
1772
1773 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1774 non-NULL, regardless of GNUTLS_INITSTAGE.
1775 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1776 an error. Set process slots as soon as we allocate them.
1777
1778 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1779
9c6c6f49
CY
17802011-10-27 Chong Yidong <cyd@gnu.org>
1781
9aba6043
SM
1782 * gnutls.c (emacs_gnutls_deinit): New function.
1783 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1784 (Fgnutls_deinit, Fgnutls_boot): Use it.
1785
1786 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1787 (deactivate_process): Call emacs_gnutls_deinit.
1788
657d08d3
JB
17892011-10-27 Juanma Barranquero <lekktu@gmail.com>
1790
1791 * image.c (x_create_x_image_and_pixmap):
1792 * w32.c (sys_rename, w32_delayed_load):
1793 * w32font.c (fill_in_logfont):
1794 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1795
5430d399
JB
17962011-10-26 Juanma Barranquero <lekktu@gmail.com>
1797
1798 * w32fns.c (w32_default_color_map): New function,
1799 extracted from Fw32_default_color_map.
a7ef684b 1800 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1801
fe0055fa
PE
18022011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1803
1804 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1805
e6346438
SM
18062011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1807
1808 * keyboard.c (test_undefined): New function (bug#9751).
1809 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1810
e112cc37
ET
18112011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1812
1813 * sysdep.c (init_sys_modes): Fix the check for the controlling
1814 terminal (Bug#6649).
1815
7b5d6677
EZ
18162011-10-20 Eli Zaretskii <eliz@gnu.org>
1817
1818 * dispextern.h (struct bidi_it): New member next_en_type.
1819
1820 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1821 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1822 current character, check also for next_en_type being WEAK_EN.
1823 (bidi_resolve_weak): Don't enter the expensive loop if the current
1824 position is before next_en_pos. Record the bidi type of the first
1825 non-ET, non-BN character we find, in addition to its position.
1826 (bidi_level_of_next_char): Invalidate next_en_type when
1827 next_en_pos is over-stepped.
1828
7da0b018
PE
18292011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1830
1831 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1832 * editfns.c: Rewrite current-time-zone so that it invokes
1833 the equivalent of (format-time-string "%Z") to get the time zone name.
1834 This fixes a bug when the time zone name contains characters that
1835 need converting from the system time locale to Emacs internal format.
1836 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1837 that patch fixed format-time-string to do the conversion, but
1838 I forgot to fix current-time-zone.
1839 (format_time_string): New function, containing most of
1840 what Fformat_time_string used to contain.
1841 (Fformat_time_string): Rewrite in terms of format_time_string.
1842 This doesn't change this function's behavior.
1843 (current-time-zone): Rewrite to use format_time_string.
1844 This fixes the bug reported by Michael Schierl in
1845 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1846 Jason Rumney's 2007-06-07 change worked around this bug, but
1847 didn't fix it.
1848 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1849
8547b010
EZ
18502011-10-19 Eli Zaretskii <eliz@gnu.org>
1851
1852 * xdisp.c (start_display): If the character at POS is displayed
1853 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1854 (try_window_reusing_current_matrix): If a line ends in a display
1855 vector or the next line starts in a display vector, continue
1856 redrawing the window even though the character position of
1857 start_row was reached.
8547b010
EZ
1858 (Bug#9771, part 2)
1859
4e948d15
CY
18602011-10-18 Chong Yidong <cyd@gnu.org>
1861
1862 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1863 with nobreak-char-display too.
1864
4787455f
EZ
18652011-10-18 Eli Zaretskii <eliz@gnu.org>
1866
1867 Fix part 3 of bug#9771.
1868 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1869 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1870 non-neutral characters if the current character is a paragraph
1871 separator (a.k.a. Newline). This avoids running the same
1872 expensive loop twice, once when we consume the preceding newline
1873 and the other time when the line actually needs to be displayed.
1874 Avoid the loop when we see neutrals on the base embedding level
1875 following a character whose directionality is the same as the
1876 paragraph's. This avoids running the expensive loop when a line
1877 ends in a long sequence of neutrals, like control characters.
1878 Add assertion against STRONG_AL type. Slightly rearrange code
1879 that determines the type of a neutral given the first non-neutral
1880 that follows it.
1881 (bidi_level_of_next_char): Set next_en_pos to zero when
1882 invalidating its info.
1883
2c91f553
EZ
18842011-10-17 Eli Zaretskii <eliz@gnu.org>
1885
1886 * xdisp.c (push_display_prop): Determine whether to record string
1887 or buffer position by IT->string, not by IT->method. Allow
1888 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1889 (move_it_vertically_backward): Don't look for character position
1890 immediately after the newline when in a continuation line.
1891 (Bug#9771, part 1)
2c91f553 1892
c7b08b0d
MR
18932011-10-15 Martin Rudalics <rudalics@gmx.at>
1894
1895 * window.c (coordinates_in_window): Rewrite and delabelize
1896 vertical border check. (Bug#5357) (Bug#9618)
1897
6b02f655
SM
18982011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1899
1900 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1901 errors in XSetWindowBorder (bug#9310).
1902
81d40c92
DA
19032011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1904
1905 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1906 avoid crash when xmalloc overrun checking is enabled.
1907
d4172c3b
EZ
19082011-10-13 Eli Zaretskii <eliz@gnu.org>
1909
1910 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1911 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1912 cursor motion with <left> and <right> arrow keys.
1913
1914 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1915 some callers set that themselves.
1916
b00eea75
EZ
19172011-10-12 Eli Zaretskii <eliz@gnu.org>
1918
1919 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1920 display string and the previous row comes from the same string and
1921 is empty. (Bug#9739) (Bug#9738)
1922
8fe012c4
SM
19232011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1924
1925 * doc.c (get_doc_string): Encode file name (bug#9735).
1926
0074aef2
EZ
19272011-10-12 Eli Zaretskii <eliz@gnu.org>
1928
79beb178
EZ
1929 * bidi.c (bidi_level_of_next_char):
1930 * xdisp.c (get_visually_first_element): Remove old incorrect
1931 comments regarding the Unicode Line Separator character.
1932
0074aef2
EZ
1933 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1934
6e4b3fbe
DA
19352011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1936
1937 * alloc.c (Fgc_status): Do not access beyond zombies array
1938 boundary if nzombies > MAX_ZOMBIES.
1939 * alloc.c (dump_zombies): Add missing format specifier.
1940
0324f3af
PE
19412011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1942
b5525cac
PE
1943 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1944 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1945
0324f3af
PE
1946 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1947 Some packages use them to denote characters with modifiers.
1948
e9b5f888
AS
19492011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1950
1951 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1952 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1953 matching a pp-number. Rename parameter var to var1.
1954
127827c0
SM
19552011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1956
1957 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1958
c8fd3bd0
GM
19592011-10-08 Glenn Morris <rgm@gnu.org>
1960
1961 * callint.c (Fcall_interactively): Give a more explicit error for the
1962 'c' case with a non-character input. (Bug#8479)
1963
352ec8ff
EZ
19642011-10-08 Eli Zaretskii <eliz@gnu.org>
1965
03669ccb
EZ
1966 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1967 lines.
7061c986
EZ
1968 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1969 lines that are hscrolled on the left.
03669ccb 1970
352ec8ff
EZ
1971 * dispnew.c (buffer_posn_from_coords): Account for a possible
1972 presence of header-line. (Bug#4426)
1973
a66cfb1c
SM
19742011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1975
6b02f655
SM
1976 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1977 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1978
7c5ee88e
PE
19792011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1980
1981 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1982 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1983 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1984 this makes Emacs dump core during garbage collection on rare
1985 occasions. sizeof is obviously inferior to offsetof here, so
1986 stick with offsetof.
1987 (GC_POINTER_ALIGNMENT): New macro.
1988 (mark_memory): Omit 3rd (offset) arg; caller changed.
1989 Don't assume EMACS_INT alignment is the same as pointer alignment.
1990
df1bbe5b
SM
19912011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1992
1993 * keyboard.c (read_key_sequence_remapped): New var.
1994 (read_key_sequence): Compute remapping in the right buffer.
1995 (command_loop_1): Use read_key_sequence's remapping directly.
1996
51553db6
SM
19972011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1998
32c1fffd
SM
1999 * dired.c (file_name_completion): Don't expand file name.
2000 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2001 before checking file name handler.
2002
51553db6
SM
2003 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2004 they've been requested explicitly (bug#9591).
2005
b6bd1599 20062011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2007
2008 * keymap.c (Fsingle_key_description): Use make_specified_string
2009 instead of build_string to build string from push_key_description.
2010 (Bug#5193)
2011
f701dc2a
PE
20122011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2013
4222c55d
PE
2014 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2015 This fixes a Y2038 bug on 64-bit hosts.
2016 * buffer.c (reset_buffer):
2017 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2018 (Fclear_buffer_auto_save_failure):
2019 Use 0, not -1, to represent an unset failure time, since time_t
2020 might not be signed.
2021
f701dc2a
PE
2022 Remove dependency on glibc malloc internals.
2023 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2024 Move back here from lisp.h, but with their new implementations.
2025 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2026 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2027 * charset.c (charset_table_init): New static var.
2028 (syms_of_charset): Use it instead of xmalloc. This removes a
2029 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2030 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2031 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2032 Move back to alloc.c.
2033 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2034 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2035
9ceebf39
JD
20362011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2037
2038 * nsterm.m (windowDidResize): Call x_set_window_size only when
2039 ns_in_resize is true. Otherwise set pixelwidth/height and
2040 call change_frame_size (Bug#9628).
2041
cb993c58
PE
20422011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2043
3930c88b
PE
2044 Port --enable-checking=all to Fedora 14 x86-64.
2045 * charset.c (syms_of_charset): Also account for glibc malloc's
2046 internal overhead when calculating the initial malloc maximum.
2047
cb993c58
PE
2048 Port --enable-checking=all to Fedora 14 x86.
2049 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2050 Move to lisp.h.
2051 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2052 (overrun_check_realloc, overrun_check_free):
2053 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2054 That way, xmalloc returns a properly-aligned pointer even if
2055 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2056 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2057 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2058 into account when calculating the initial malloc maximum.
2059 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2060 Move here from alloc.c, so that charset.c can use it too.
2061 Properly align; the old code wasn't right for common 32-bit hosts
2062 when configured with --enable-checking=all.
2063 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2064 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2065
31bed486
EZ
20662011-09-29 Eli Zaretskii <eliz@gnu.org>
2067
04c70788 2068 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2069 use EDOM.
2070
fbcaa2f3
EZ
20712011-09-28 Eli Zaretskii <eliz@gnu.org>
2072
2073 * xdisp.c (compute_display_string_end): If there's no display
2074 string at CHARPOS, return -1.
2075
2076 * bidi.c (bidi_fetch_char): When compute_display_string_end
2077 returns a negative value, treat the character as a normal
2078 character not covered by a display string. (Bug#9624)
2079
a239d4e9
JB
20802011-09-28 Juanma Barranquero <lekktu@gmail.com>
2081
2082 * lread.c (Fread_from_string): Fix typo in docstring.
2083
88652fd5
EZ
20842011-09-27 Eli Zaretskii <eliz@gnu.org>
2085
2086 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2087 newline, reseat the iterator instead of bidi-iterating there one
2088 character at a time. (Bug#9610)
32c1fffd
SM
2089 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2090 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2091
ed497dd4
AS
20922011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2093
2094 * lread.c (readevalloop): Use correct code for NBSP.
2095 (read1): Likewise. (Bug#9608)
2096
b2bf61aa
MA
20972011-09-25 Michael Albinus <michael.albinus@gmx.de>
2098
2099 * dbusbind.c (Fdbus_register_signal): When service is not
2100 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2101
32bbb17c
GM
21022011-09-25 Glenn Morris <rgm@gnu.org>
2103
2104 * buffer.c (truncate-lines): Doc fix.
2105
94e0933e
CY
21062011-09-24 Chong Yidong <cyd@stupidchicken.com>
2107
2108 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2109 (Fset_window_next_buffers): Doc fix.
2110
cddde921
GM
21112011-09-24 Glenn Morris <rgm@gnu.org>
2112
2113 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2114
1260aef1
PE
21152011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2116
25b4bfa0
PE
2117 Fix minor problems found by static checking.
2118 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2119 * indent.c (Fvertical_motion): Fix == vs = typo.
2120
e3cbd34b
EZ
21212011-09-24 Eli Zaretskii <eliz@gnu.org>
2122
a66cfb1c
SM
2123 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2124 Default value is now t. Doc fix.
6bf7006f 2125
e3cbd34b 2126 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2127 logic when moving up, not only when moving down. Fix the
e3cbd34b 2128 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2129 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2130
2131 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2132 CHARPOS is covered by a display string which includes newlines.
2133 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2134 is covered by a display string with embedded newlines.
2135
a3de0cbd
MA
21362011-09-24 Michael Albinus <michael.albinus@gmx.de>
2137
2138 * dbusbind.c (Fdbus_register_signal): Add match rule to
2139 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2140 (Fdbus_register_method, Vdbus_registered_objects_table):
2141 Fix docstring.
a3de0cbd 2142
b260039d
JM
21432011-09-24 Jim Meyering <meyering@redhat.com>
2144
32c1fffd 2145 do not ignore write error for any output size
b260039d
JM
2146 The previous change was incomplete.
2147 While it makes emacs --batch detect the vast majority of stdout
2148 write failures, errors were still ignored whenever the output size is
2149 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2150 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2151 && echo FAIL: ignored write error
2152 FAIL: ignored write error
2153 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2154 && echo FAIL: ignored write error
2155 FAIL: ignored write error
2156 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2157
8eca8a7c
AS
21582011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2159
2160 * emacs.c (Fkill_emacs): In noninteractive mode exit
2161 non-successfully if a write error occurred on stdout. (Bug#9574)
2162
3341db62
EZ
21632011-09-21 Eli Zaretskii <eliz@gnu.org>
2164
2165 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2166 the xassert test.
2167
2168 * dispextern.h (struct it): Update the comment documenting what
2169 can it->OBJECT be.
2170
8c203dbf
EZ
21712011-09-20 Eli Zaretskii <eliz@gnu.org>
2172
2173 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2174 a display string, extend search for cursor position to end of row.
2175 (find_row_edges): If the row ends in a newline from a display
2176 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2177 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2178 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2179 non-empty line. Fixes confusing cursor motion with arrow keys at
2180 the beginning of a line that starts with whitespace.
8c203dbf 2181
a4824228
LMI
21822011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2183
2184 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2185 (bug#9493).
2186
33ed493b
CY
21872011-09-18 Chong Yidong <cyd@stupidchicken.com>
2188
2189 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2190 boolean (Bug#9154).
2191
56cd55c8
EZ
21922011-09-18 Eli Zaretskii <eliz@gnu.org>
2193
2194 * xdisp.c (display_line): Record maximum and minimum buffer
2195 positions even if no glyphs were produced (e.g., by a zero-width
2196 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2197 buffer positions that will be removed from the glyph row because
2198 they don't fit.
c02dcedf
EZ
2199 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2200 column is beyond frame width: don't subtract 1 "pixel" when
2201 computing width of the stretch.
3e62b7e0
EZ
2202 (reseat_at_next_visible_line_start): Undo the change made on
2203 2011-09-17 that saved paragraph information and restored it after
2204 the call to `reseat'. (Bug#9545)
56cd55c8 2205
5ed99d36 22062011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2207
2208 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2209 and turn window cursor on if cleared (Bug#9415).
2210
5ed99d36 22112011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2212
2213 * search.c (boyer_moore): Take unibyte characters from pattern
2214 literally. (Bug#9458)
2215
9bade7b2
EZ
22162011-09-18 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2219
e5e9d610
PE
22202011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2221
87e4427a
PE
2222 Fix minor problem found by static checking.
2223 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2224 initialized, to pacify gcc -Wuninitialized.
2225
e5e9d610
PE
2226 * fileio.c: Report proper errno when syscall falls.
2227 (Finsert_file_contents): Save and restore errno,
2228 so that report_file_error outputs the correct diagnostic.
2229 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2230
a1674f0b
EZ
22312011-09-18 Eli Zaretskii <eliz@gnu.org>
2232
2233 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2234
fbfb6dd4
EZ
22352011-09-17 Eli Zaretskii <eliz@gnu.org>
2236
2237 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2238 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2239
bb187662
EZ
22402011-09-17 Eli Zaretskii <eliz@gnu.org>
2241
1137e8b8 2242 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2243 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2244
2245 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2246 (bidi_find_paragraph_start): Search back for paragraph beginning
2247 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2248 (bidi_move_to_visually_next): Only trigger paragraph-related
2249 computations when the last character is a newline or at EOB, not
2250 just any NEUTRAL_B. (Bug#9470)
2251
bb187662
EZ
2252 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2253 truncated lines if point is covered by a display string. (Bug#9524)
2254
2e621251
PE
22552011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2256
2257 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2258 (cons_to_x_long): New function.
2259 (lisp_data_to_selection_data): Use it. Correct the test for
2260 short-versus-long data; it was negated. Break out of vector
2261 loop, for efficiency, when a long datum is discovered.
2262
91a15bc6
SM
22632011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2264
2265 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2266
b41c3a35
EZ
22672011-09-16 Eli Zaretskii <eliz@gnu.org>
2268
2269 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2270 GCC PR/17406) by declaring this function with external scope.
2271
7812ba2d
PE
22722011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2275 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2276
cf7edc2a
AS
22772011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2278
2279 * editfns.c (Fformat): Correctly handle text properties on "%%".
2280
bd01620e
EZ
22812011-09-15 Eli Zaretskii <eliz@gnu.org>
2282
2283 * xterm.c (x_draw_composite_glyph_string_foreground):
2284 * w32term.c (x_draw_composite_glyph_string_foreground):
2285 * term.c (encode_terminal_code):
2286 * composite.c (composition_update_it, get_composition_id):
2287 * xdisp.c (get_next_display_element)
2288 (fill_composite_glyph_string): Add comments about special meaning
2289 of TAB characters in a composition.
2290
a02719a3
PE
22912011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2292
2293 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2294 This occurs when processing a multibyte format.
2295 Problem reported by Wolfgang Jenker.
a02719a3 2296
72589a3c
JB
22972011-09-15 Johan Bockgård <bojohan@gnu.org>
2298
2299 * xdisp.c (try_cursor_movement): Only check for exact match if
2300 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2301
1c14176c
PE
23022011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 Remove unused external symbols.
2305 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2306 * xdisp.c (calc_pixel_width_or_height): Now static.
2307 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2308 * indent.c (check_display_width):
2309 * w32term.c: Fix comment to match code.
2310 * xterm.c, xterm.h (x_catching_errors): Remove.
2311
d2eea5b5
PE
23122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2313
2314 * xselect.c: Use signed conversions more consistently (Bug#9498).
2315 (selection_data_to_lisp_data): Assume incoming selection data are
2316 signed integers, not unsigned. This is to be consistent with
2317 outgoing selection data, which was modified to use signed integers
2318 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2319 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2320 expects long, not unsigned long.
2321
46888499
EZ
23222011-09-14 Eli Zaretskii <eliz@gnu.org>
2323
2324 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2325 computation of loop end. Reported by Johan Bockgård
2326 <bojohan@gnu.org>.
2327
ef8ef9fb
CY
23282011-09-13 Chong Yidong <cyd@stupidchicken.com>
2329
2330 * frame.c (Fother_visible_frames_p): Function deleted.
2331
fa819fed
EZ
23322011-09-12 Eli Zaretskii <eliz@gnu.org>
2333
2334 * indent.c (compute_motion): Process display vector front to back
2335 rather than the other way around. (Bug#2496)
2336
2ba8e008
SM
23372011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2338
2339 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2340
20f53c69
CY
23412011-09-11 Chong Yidong <cyd@stupidchicken.com>
2342
2343 * minibuf.c (Fread_from_minibuffer): Doc fix.
2344
d562d7a4
EZ
23452011-09-11 Eli Zaretskii <eliz@gnu.org>
2346
2347 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2348 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2349
1c4d7f3d
LMI
23502011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2351
2352 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2353 value for non-existent files.
2354
b885bf36
EZ
23552011-09-11 Eli Zaretskii <eliz@gnu.org>
2356
2357 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2358 set its "size" to -1. This will set the modtime_size field of
2359 the corresponding buffer to -1, which is what
2360 verify-visited-file-modtime expects for files that do not exist.
2361 (Bug#9139)
2362
6612f0bf
PE
23632011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2366 here ...
2367 * lisp.h: ... from here. push_key_description is no longer
2368 defined in keyboard.c, so its declaration should not be in
2369 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2370 logically belongs with push_key_description.
2371
dfb3f755
PE
23722011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2373
2374 * buffer.h: Include <sys/types.h> instead of <time.h>.
2375 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2376 Problem reported by Herbert J. Skuhra.
2377
3134906c
LMI
23782011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2379
2380 * xml.c (parse_region): Make the parsing work for
2381 non-comment-starting XML files again (bug#9144).
2382
8d903f4e
AS
23832011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2384
2385 * image.c (gif_load): Fix calculation of bottom and right corner.
2386 (Bug#9468)
2387
80ad64f4
EZ
23882011-09-10 Eli Zaretskii <eliz@gnu.org>
2389
2390 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2391 redisplay in small windows.
2392
208a048d
EZ
23932011-09-09 Eli Zaretskii <eliz@gnu.org>
2394
2395 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2396
9b1c252e
MR
23972011-09-08 Martin Rudalics <rudalics@gmx.at>
2398
2399 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2400 Operate on live windows only.
2401
2949f33b
JB
24022011-09-08 Juanma Barranquero <lekktu@gmail.com>
2403
2404 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2405
e08dcafd
EZ
24062011-09-07 Eli Zaretskii <eliz@gnu.org>
2407
2408 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2409 only under bidi iteration.
2410
115b96bd
JD
24112011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2412
2413 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2414
c8199d0f
PE
24152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2418 Without this fix, the command to link temacs failed due to an
2419 undefined symbol __builtin_isnan. This is because
2420 /usr/include/iso/math_c99.h #defines isnan(x) to
2421 __builtin_isnan(x), but the bundled gcc, which identifies itself
2422 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2423 a __builtin_isnan.
2424 * floatfns.c (isnan): #undef, and then #define to a clone of
2425 what's in data.c.
2426 (Fisnan): Always define, since it's always available now.
2427 (syms_of_floatfns): Always define isnan at the Lisp level.
2428
e39b275c 24292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2430
2431 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2432
b2db44d9 24332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2434
f4af5137 2435 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2436 The previous code assumed that file offsets (off_t values) fit in
2437 EMACS_INT variables, which is not true on typical 32-bit hosts.
2438 The code messed up by falsely reporting buffer overflow in cases
2439 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2440 when "big" contains more than 2**29 bytes, even though this
2441 inserts just one byte and does not overflow the buffer.
2442 (Finsert_file_contents): Store file offsets as off_t
2443 values, not as EMACS_INT values. Check for overflow when
2444 converting between EMACS_INT and off_t. When checking for
2445 buffer overflow or for overlap, take the offsets into account.
2446 Don't use EMACS_INT for small values where int suffices.
2447 When checking for overlap, fix a typo: ZV was used where
2448 ZV_BYTE was intended.
2449 (Fwrite_region): Don't assume off_t fits into 'long'.
2450 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2451
ecfc0a49
MA
24522011-09-05 Michael Albinus <michael.albinus@gmx.de>
2453
2454 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2455
6511acf2 24562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2457
0999621a 2458 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2459
2460 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2461 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2462 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2463 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2464 (modify_event_symbol): Do not assume that the length of
2465 name_alist_or_stem is safe to alloca and fits in int.
2466 (Fexecute_extended_command): Likewise for function name and binding.
2467 (Frecursion_depth): Wrap around reliably on integer overflow.
2468 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2469 since some callers pass EMACS_INT values.
2470 (Fsingle_key_description): Don't crash if symbol name contains more
2471 than MAX_ALLOCA bytes.
2472 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2473 (get_minibuffer): Arg is now EMACS_INT, not int.
2474 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2475 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2476 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2477
2be7d702
PE
2478 * dbusbind.c (signature_cat): New function.
2479 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2480 Do not overrun buffer; instead, report string overflow.
2481
9d1df220
PE
2482 * dispnew.c (add_window_display_history): Don't overrun buffer.
2483 Truncate instead; this is OK since it's just a log.
2484
33ef5c64
PE
2485 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2486 even if the time zone offset is outlandishly large.
2487 Don't mishandle offset == INT_MIN.
2488
66c6fdd5
PE
2489 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2490 when creating daemon; the previous buffer-overflow check was incorrect.
2491
d749b01b
PE
2492 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2493 which has the guts of the old verror function.
2494
b5cd1905
PE
2495 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2496 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2497
6e1a67fb
PE
2498 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2499 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2500 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2501 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2502 length of string rather than counting it via multiple sprintfs;
2503 that's simpler and more reliable.
c21721cc
PE
2504 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2505 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2506 sprintf, in case result does not fit in int.
2507
c57b67fc
PE
2508 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2509 (fontset_from_font): Print it.
2510
8a401434
PE
2511 * frame.c (tty_frame_count): Now printmax_t, not int.
2512 (make_terminal_frame, set_term_frame_name): Print it.
2513 (x_report_frame_params): In X, window IDs are unsigned long,
2514 not signed long, so print them as unsigned.
2515 (validate_x_resource_name): Check for implausibly long names,
2516 and don't assume name length fits in 'int'.
2517 (x_get_resource_string): Don't blindly alloca invocation name;
2518 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2519 not fit in int.
2520
6e1a67fb
PE
2521 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2522 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2523 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2524
0df02bf3
PE
2525 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2526 Use esprintf, not sprintf, in case result does not fit in int.
2527
48e30793
PE
2528 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2529 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2530 it as a large positive number.
2531 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2532 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2533
a66ff6d8
PE
2534 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2535 in case result does not fit in int.
2536
aca216ff
PE
2537 * print.c (float_to_string): Detect width overflow more reliably.
2538 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2539 buffer overrun. Don't assume list length fits in 'int'. Treat
2540 print length of 0 as 0, not as infinity; to be consistent with other
2541 uses of print length in this function. Don't overflow print length
2542 index. Don't assume hash table size fits in 'long', or that
2543 vectorlike size fits in 'unsigned long'.
2544
31c286f7
PE
2545 * process.c (make_process): Use printmax_t, not int, to format
2546 process-name gensyms.
2547
55e5faa1
PE
2548 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2549
80f2e268
PE
2550 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2551 to avoid potential buffer overrun.
2552
670741ab
PE
2553 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2554 if X resource line is longer than 512 bytes.
2555
b7163a50
PE
2556 * xfns.c (x_window): Make sprintf buffer a bit bigger
2557 to avoid potential buffer overrun.
2558
ae58ff1f
PE
2559 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2560
c43c8a6a
PE
2561 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2562
3f8236f4
PE
25632011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2564
53e9fe90 2565 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2566 Without these, Emacs silently mishandles large integers sometimes.
2567 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2568 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2569
6511acf2
PE
2570 * xdisp.c (try_window_id): Check Emacs fixnum range before
2571 converting to 'int'.
806add1d 2572
6511acf2 2573 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2574 Check that an Emacs fixnum is in range before assigning it to 'int'.
2575 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2576 values converted from Emacs fixnums.
2577 (Frecenter): Don't wrap around a line count if it is out of 'int'
2578 range; instead, treat it as an extreme value.
2579 (Fset_window_configuration, compare_window_configurations):
2580 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2581
6511acf2
PE
2582 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2583 that can exceed INT_MAX. Check that EMACS_INT value is in range
2584 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2585 (match_limit): Don't assume that a fixnum can fit in 'int'.
2586
6511acf2 2587 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2588 exceed INT_MAX.
2589
6511acf2 2590 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2591 (Fvertical_motion): Don't wrap around LINES values that don't fit
2592 in 'int'. Instead, treat them as extreme values. This is good
2593 enough for windows, which can't have more than INT_MAX lines anyway.
2594
fcb901a7
LMI
25952011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2596
0f2f6b6d
LMI
2597 * Require libxml/parser.h to avoid compilation warning.
2598
fcb901a7
LMI
2599 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2600
2601 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2602 since this reportedly can destroy thread storage.
2603
6e20a0d4
CY
26042011-08-30 Chong Yidong <cyd@stupidchicken.com>
2605
2606 * syntax.c (find_defun_start): Update all cache variables if
2607 exiting early (Bug#9401).
2608
148ae00e
EZ
26092011-08-30 Eli Zaretskii <eliz@gnu.org>
2610
f6cfbd8f
EZ
2611 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2612
148ae00e
EZ
2613 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2614 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2615 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2616
2617 * term.c (tty_append_glyph): New function.
2618 (produce_stretch_glyph): Static function and its prototype deleted.
2619
a66cfb1c
SM
2620 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2621 Add prototypes.
148ae00e 2622
c4a07a4c
PE
26232011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2626 when checking :margin (Bug#9390).
2627 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2628 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2629 so that the name doesn't mislead. All uses changed.
2630
6bc8cd65
JB
26312011-08-28 Johan Bockgård <bojohan@gnu.org>
2632
2633 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2634 set_tty_hooks.
2635
dca4927e
EZ
26362011-08-27 Eli Zaretskii <eliz@gnu.org>
2637
2638 * xdisp.c (move_it_to): Don't bail out early when reaching
2639 position beyond to_charpos, if we are scanning backwards.
2640 (move_it_vertically_backward): When DY == 0, make sure we get to
2641 the first character in the line after the newline.
2642
f2cad773
PE
26432011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2646 (ccl_driver): Do not generate an out-of-range pointer.
2647 (Fccl_execute_on_string): Remove unnecessary check for
2648 integer overflow, noted by Stefan Monnier in
2649 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2650 Remove a FIXME that didn't need fixing.
2651 Simplify the newly-introduced buffer reallocation code.
2652
0cae2cdb
JB
26532011-08-27 Juanma Barranquero <lekktu@gmail.com>
2654
2655 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2656
5fc295a4 26572011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2658
70c60eb2 2659 Integer and memory overflow issues (Bug#9196).
726e0ab1 2660
d31850da
PE
2661 * doc.c (get_doc_string): Rework so that
2662 get_doc_string_buffer_size is the actual buffer size, rather than
2663 being 1 less than the actual buffer size; this makes xpalloc more
2664 convenient.
2665
a69fbedb
PE
2666 * image.c (x_allocate_bitmap_record, cache_image):
2667 * xselect.c (Fx_register_dnd_atom):
2668 Simplify previous changes by using xpalloc.
2669
fe5c5d37
PE
2670 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2671 since either will do and ptrdiff_t is convenient with xpalloc.
2672
0065d054
PE
2673 * charset.c (charset_table_size)
2674 (struct charset_sort_data.priority): Now ptrdiff_t.
2675 (charset_compare): Don't overflow if priorities differ greatly.
2676 (Fsort_charsets): Don't assume list length fits in int.
2677 Check for size-calculation overflow when allocating sort data.
2678 (syms_of_charset): Allocate an initial charset table that is
2679 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2680
2681 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2682
2683 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2684 The actual value is always <= INT_MAX, and leaving it unsigned made
2685 overflow checking harder.
2686
2687 * dispextern.h (struct glyph_matrix.rows_allocated)
2688 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2689 with xpalloc. The values are still always <= INT_MAX.
2690
2691 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2692
2693 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2694 (SAFE_NALLOCA): New macro.
2695
2696 * region-cache.c (struct boundary.pos, find_cache_boundary)
2697 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2698 (set_cache_region, invalidate_region_cache)
2699 (revalidate_region_cache, know_region_cache, region_cache_forward)
2700 (region_cache_backward, pp_cache):
2701 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2702 so that ptrdiff_t * can be passed to xpalloc.
2703 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2704 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2705 (pp_cache): Don't assume cache_len fits in int.
2706 * region-cache.h: Adjust extern decls to match.
2707
2708 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2709 EMACS_INT, since either will do, for xpalloc.
2710
2711 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2712 (xnmalloc, xnrealloc, xpalloc): New functions.
2713
726e0ab1
PE
2714 * bidi.c (bidi_shelve_header_size): New constant.
2715 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2716 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2717
51f30bc5 2718 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2719 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2720 (overlay_strings):
2721 Don't update size of array until after memory allocation succeeds,
2722 because xmalloc/xrealloc may not return.
0065d054
PE
2723 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2724 now that we have proper integer overflow checking.
2725 (record_overlay_string, overlay_strings): Catch overflows when
2726 calculating size of overlay_str_buf.
726e0ab1 2727
0065d054
PE
2728 * callproc.c (Fcall_process): Check for size overflow when
2729 calculating size of args2.
2730 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2731 Normally we prefer signed values, but sticking with ptrdiff_t would
2732 require adding more-complicated checks.
726e0ab1
PE
2733
2734 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2735 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2736 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2737 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2738
2739 * character.c (Fstring): Check for size-calculation overflow.
2740
2741 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2742 unnecessary integer overflow. Check for size overflow.
2743 (encode_coding_object): Don't update size until xmalloc succeeds.
2744
2745 * composite.c (get_composition_id): Check for overflow in glyph
2746 length calculations.
2747
2748 Integer and memory overflow fixes for display code.
2749 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2750 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2751 (scrolling_window): Check for overflow in size calculations.
2752 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2753 Don't assume glyph table len fits in int.
2754 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2755 (row_table_size): Now ptrdiff_t, not int.
2756 (scrolling_window): Avoid overflow in size calculations.
2757 Don't update size until allocation succeeds.
2758 * fns.c (concat): Check for overflow in size calculations.
2759 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2760 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2761 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2762
2763 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2764 (get_doc_string): Check for size calculation overflow.
2765 Don't update size until allocation succeeds.
2766 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2767 EMACS_INT, where ptrdiff_t will do.
2768 (Fsubstitute_command_keys): Check for string overflow.
2769
2770 * editfns.c (set_time_zone_rule): Don't assume environment length
2771 fits in int.
2772 (message_length): Now ptrdiff_t, not int.
2773 (Fmessage_box): Don't update size until allocation succeeds.
2774 Don't assume message length fits in int.
2775 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2776
0065d054
PE
2777 * emacs.c (main): Do not reallocate argv, since there is a null at
2778 the end that can be overwritten, and this way there's no need to
2779 worry about size-calculation overflow.
2780 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2781
2782 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2783 alloc succeeds.
2784 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2785
2786 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2787 (x_set_scroll_bar_width, x_figure_window_size):
2788 Check for integer overflow.
2789 (x_set_alpha): Do not assume XINT fits in int.
2790
2791 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2792 This is for the members text_lines, text_cols, total_lines, total_cols,
2793 where the system imposes an 'int' limit.
2794
2795 * fringe.c (Fdefine_fringe_bitmap):
2796 Don't update size until alloc works.
2797
2798 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2799 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2800
2801 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2802 Check for size-calculation overflow.
2803 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2804 do, as we prefer signed integers.
2805 (id_to_widget.max_size, id_to_widget.used)
2806 (xg_store_widget_in_map, xg_remove_widget_from_map)
2807 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2808 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2809 Use and return ptrdiff_t, not int.
2810 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2811 * gtkutil.h: Change prototypes to match the above.
2812
2813 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2814 are duplicate now that they've been promoted to lisp.h.
2815 (x_allocate_bitmap_record, x_alloc_image_color)
2816 (make_image_cache, cache_image, xpm_load):
2817 Don't update size until alloc is done.
2818 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2819 (x_detect_edges):
3256efce 2820 Check for size calculation overflow.
726e0ab1
PE
2821 (ct_colors_allocated_max): New constant.
2822 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2823 overflow.
3256efce 2824
726e0ab1
PE
2825 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2826 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2827 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2828 Use ptrdiff_t, not int, to count maps.
2829 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2830 calculations. Don't update size until allocation succeeds.
2831 Redo calculations to avoid overflow.
726e0ab1
PE
2832 * keyboard.h: Change prototypes to match the above.
2833
2834 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2835 to count maps.
2836 (current_minor_maps): Check for size calculation overflow.
2837 * keymap.h: Change prototypes to match the above.
2838
2839 * lread.c (read1, init_obarray): Don't update size until alloc done.
2840
2841 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2842 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2843
726e0ab1
PE
2844 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2845 Now ptrdiff_t, not int.
2846 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2847 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2848
2849 * process.c (Fnetwork_interface_list): Check for overflow
2850 in size calculation.
2851
2852 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2853
2854 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2855 overflow. Don't bother calling xmalloc when xrealloc will do.
2856
2857 * search.c (Freplace_match): Check for size calculation overflow.
2858 (Fset_match_data): Don't assume list lengths fit in 'int'.
2859
2860 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2861 for command line length. Do not attempt to address one before the
2862 beginning of an array, as that's not portable.
2863
2864 * term.c (max_frame_lines): Remove; unused.
2865 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2866 not int.
2867 (encode_terminal_code, calculate_costs): Check for size
2868 calculation overflow.
2869 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2870 table lengths and related sizes. Don't update size until alloc
2871 done. Redo calculations to avoid overflow.
2872 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2873
2874 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2875 subtracting pointers.
2876 (gobble_line): Check for overflow more carefully. Don't update size
2877 until alloc done.
2878
2879 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2880 Don't update size until alloc done.
2881 Redo size calculations to avoid overflow.
2882 Check for size calculation overflow.
0065d054 2883 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2884
2885 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2886 Use ptrdiff_t, not int, for sizes.
2887 (store_mode_line_noprop_char): Don't update size until alloc done.
2888
0065d054
PE
2889 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2890 Use ptrdiff_t, not int, for sizes.
2891 (Finternal_make_lisp_face, cache_face):
2892 Check for size calculation overflow.
2893 (cache_face): Treat size calculation overflows as if they were
2894 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2895
2896 * xfns.c (x_encode_text, x_set_name_internal)
2897 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2898 sizes, since they can exceed INT_MAX in size. Check for size
2899 calculation overflow.
2900
0065d054
PE
2901 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2902 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2903 Don't update size until alloc done.
2904
0065d054 2905 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2906 as sprintf is limited to int lengths.
1d526e2f 2907
252c5ee1
PE
2908 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2909 (X_LONG_MIN): New macros.
864d7ce7
PE
2910 Use them to make the following changes clearer.
2911 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2912 This change doesn't affect the value now, but it may help remind
2913 future maintainers not to raise the value too much later.
2914 (SELECTION_QUANTUM): Remove, replacing with ...
2915 (selection_quantum): ... new function, which avoids overflow.
2916 All uses changed.
2917 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2918 assumption that selection length fits in 'int'.
2919 (x_reply_selection_request, x_handle_selection_request)
2920 (x_get_window_property, receive_incremental_selection)
2921 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2922 (lisp_data_to_selection_data, clean_local_selection_data):
2923 Use ptrdiff_t, not int, to record length of selection.
2924 (x_reply_selection_request, x_get_window_property)
2925 (receive_incremental_selection, x_property_data_to_lisp):
2926 Redo calculations to avoid overflow.
2927 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2928 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2929 something.
2930 (x_get_window_property, receive_incremental_selection)
2931 (lisp_data_to_selection_data, x_property_data_to_lisp):
2932 Check for size-calculation overflow.
2933 (x_get_window_property, receive_incremental_selection)
2934 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2935 Don't store size until memory allocation succeeds.
2936 (x_get_window_property): Plug memory leak on memory exhaustion.
2937 Don't double-block input; malloc is safe here. Don't assume 2**34
2938 - 4 fits in unsigned long. Add an xassert to check
2939 XGetWindowProperty overflow. Be more careful about overflow
2940 calculations, and distinguish size from memory overflow better.
2941 (receive_incremental_selection): When tracing, don't assume
2942 unsigned int is less than INT_MAX.
2943 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2944 harmful) conversions of unsigned short to int.
2945 (lisp_data_to_selection_data): Don't assume that integers
2946 in the range -65535 through -1 fit in an X unsigned short.
2947 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2948 result parameters unless successful. Rely on cons_to_unsigned
2949 to report problems with elements; the old code wasn't right anyway.
2950 (x_check_property_data): Check for int overflow; we cannot use
2951 a wider type due to X limits.
2952 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2953
726e0ab1 2954 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2955
0065d054
PE
2956 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2957 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2958 (x_color_cells): Don't store size until memory allocation succeeds.
2959 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2960 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2961 (x_term_init): Don't assume length fits in int (sprintf is limited
2962 to int size).
bc18e09d 2963
ebfa62c0
PE
2964 Use ptrdiff_t for composition IDs.
2965 * character.c (lisp_string_width):
2966 * composite.c (composition_table_size, n_compositions)
2967 (get_composition_id, composition_gstring_from_id):
2968 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2969 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2970 * window.c (Frecenter):
2971 Use ptrdiff_t, not int, for composition IDs.
2972 * composite.c (get_composition_id): Check for integer overflow.
2973 * composite.h: Adjust prototypes to match the above changes.
2974
d3411f89
PE
2975 Use ptrdiff_t for hash table indexes.
2976 * category.c (hash_get_category_set):
2977 * ccl.c (ccl_driver):
2978 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2979 * coding.c (coding_system_charset_list, detect_coding_system):
2980 * coding.h (struct coding_system.id):
2981 * composite.c (get_composition_id, gstring_lookup_cache):
2982 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2983 * image.c (xpm_get_color_table_h):
2984 * lisp.h (hash_lookup, hash_put):
2985 * minibuf.c (Ftest_completion):
2986 Use ptrdiff_t for hash table indexes, not int (which is too
2987 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2988 32-bit --with-wide-int hosts).
2989
e097a6fa
PE
2990 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2991 Add a FIXME comment about memory leaks.
2992 (syms_of_charset): Don't assume xmalloc returns.
2993
5637687f
PE
2994 Don't assume that stated character widths fit in int.
2995 * character.c (Fchar_width, c_string_width, lisp_string_width):
2996 * character.h (CHAR_WIDTH):
2997 * indent.c (MULTIBYTE_BYTES_WIDTH):
2998 Use sanitize_char_width to avoid undefined and/or bad behavior
2999 with outlandish widths.
a66cfb1c 3000 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3001 now that we have two such functions. All uses changed.
3002 (sanitize_char_width): New inline function.
3003
a2271ba2
PE
3004 Don't assume that tab-width fits in int.
3005 * character.h (sanitize_width): New inline function.
3006 (SANE_TAB_WIDTH): New macro.
3007 (ASCII_CHAR_WIDTH): Use it.
3008 * indent.c (sane_tab_width): Remove. All uses replaced by
3009 SANE_TAB_WIDTH (current_buffer).
3010 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3011
18c52557
PE
3012 * fileio.c: Integer overflow issues with file modes.
3013 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3014
caeeedc1
PE
3015 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3016 Remove unreachable code.
3017 (read_hex, load_charset_map_from_file): Check for integer overflow.
3018
6df6ae42 3019 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3020 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3021 (x_send_scroll_bar_event): Likewise. Check that the size does not
3022 exceed limits imposed by XClientMessageEvent, as well as the usual
3023 ptrdiff_t and size_t limits.
3024
b13995db
PE
3025 * keyboard.c: Overflow, signedness and related fixes.
3026 (make_lispy_movement): Use same integer type in forward decl
3027 that is used in the definition.
3028 (read_key_sequence, keyremap_step):
3029 Change bufsize argument back to int, undoing my 2011-03-30 change.
3030 We prefer signed types, and int is wide enough here.
3031 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3032 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3033 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3034 length, not size_t. Use ptrdiff_t for index, not int.
3035 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3036 possibility of integer overflow.
3037
13464394
PE
3038 Overflow, signedness and related fixes for images.
3039
3040 * dispextern.h (struct it.stack[0].u.image.image_id)
3041 (struct_it.image_id, struct image.id, struct image_cache.size)
3042 (struct image_cache.used, struct image_cache.ref_count):
3043 * gtkutil.c (update_frame_tool_bar):
3044 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3045 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3046 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3047 * nsmenu.m (update_frame_tool_bar):
3048 * xdisp.c (calc_pixel_width_or_height):
3049 * xfns.c (image_cache_refcount):
3050 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3051 on typical 64-bit hosts.
3052
3053 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3054 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3055 Omit unnecessary casts to int.
3056 (parse_image_spec): Check that integers fall into 'int' range
3057 when the callers expect that.
3058 (image_ascent): Redo ascent calculation to avoid int overflow.
3059 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3060 (lookup_image): Remove unnecessary tests.
3061 (xbm_image_p): Locals are now of int, not EMACS_INT,
3062 since parse_image_check makes sure they fit into int.
3063 (png_load, gif_load, svg_load_image):
3064 Prefer int to unsigned where either will do.
3065 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3066 old tiff_error_handler and tiff_warning_handler.
3067 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3068 stack buffer overflows. It uses only the features of vsnprintf
3069 that are common to both POSIX and native Microsoft.
3070 (tiff_error_handler, tiff_warning_handler): Use it.
3071 (tiff_load, gif_load, imagemagick_load_image):
3072 Don't assume :index value fits in 'int'.
3073 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3074 (imagemagick_load_image): Check that crop parameters fit into
3075 the integer types that MagickCropImage accepts. Don't assume
3076 Vimagemagick_render_type has a nonnegative value. Don't assume
3077 size_t fits in 'long'.
3078 (gs_load): Use printmax_t to print the widest integers possible.
3079 Check for integer overflow when computing image height and width.
3080
c11821d4
EZ
30812011-08-26 Eli Zaretskii <eliz@gnu.org>
3082
3083 * xdisp.c (redisplay_window): Don't force window start if point
3084 will be invisible in the resulting window. (Bug#9324)
3085
0c95fcf7
EZ
30862011-08-25 Eli Zaretskii <eliz@gnu.org>
3087
3088 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3089 the display spec is of the form `(space ...)'.
3090 (handle_display_spec): Return the value returned by
3091 handle_single_display_spec, not just 1 or zero.
3092 (handle_single_display_spec): If the display spec is of the form
3093 `(space ...)', and specifies display in the text area, return 2
3094 rather than 1.
fee65a97 3095 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3096 accurately, and prefer exact match for point under bidi.
3097 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3098
3099 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3100 into disp_prop; all users changed.
3101
3102 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3103 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3104 for the text covered by the display property.
3105
e4ed06f1
CY
31062011-08-25 Chong Yidong <cyd@stupidchicken.com>
3107
3108 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3109 Change return value to nil.
3110 (Frecord_buffer): Delete unused function.
3111
f67cdd7f
EZ
31122011-08-24 Eli Zaretskii <eliz@gnu.org>
3113
5980d4c6
EZ
3114 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3115 buffers, return left-to-right.
8610fe8b
EZ
3116 (set_cursor_from_row): Consider candidate row a win if its glyph
3117 represents a newline and point is on that newline. Fixes cursor
3118 positioning on the newline at EOL of R2L text within L2R
3119 paragraph, and vice versa.
3120 (try_cursor_movement): Check continued rows, in addition to
3121 continuation rows. Fixes unwarranted scroll when point enters a
3122 continued line of R2L text within an L2R paragraph, or vice versa.
3123 (cursor_row_p): Consider the case of point being equal to
3124 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3125 from the end of a short line to the beginning of a continued line
3126 of R2L text within L2R paragraph.
3127 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3128 composed characters.
5980d4c6 3129
f67cdd7f
EZ
3130 * bidi.c (bidi_check_type): Use xassert.
3131 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3132 members.
3133
bca633fb
EZ
31342011-08-23 Eli Zaretskii <eliz@gnu.org>
3135
3136 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3137 a character.
3138
4a5885a7
CY
31392011-08-23 Chong Yidong <cyd@stupidchicken.com>
3140
3141 * nsfont.m (ns_otf_to_script): Fix typo.
3142
0902a04e
KH
31432011-08-22 Kenichi Handa <handa@m17n.org>
3144
3145 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3146 extra slot even if the purpose is char-code-property-table.
3147
1a2e6670
EZ
31482011-08-23 Eli Zaretskii <eliz@gnu.org>
3149
8ddde651
EZ
3150 * xdisp.c (redisplay_window): When computing centering_position,
3151 account for the height of the header line. (Bug#8874)
3152
425cc014
EZ
3153 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3154 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3155 candidate is selected by the mouse, and that candidate has a
3156 composed character under the mouse.
3157
1a2e6670
EZ
3158 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3159 coordinates reported by pos-visible-in-window-p for a composed
3160 character in column zero.
3161
8b76d6f8
SM
31622011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3163
3164 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3165
dac347dd
EZ
31662011-08-22 Eli Zaretskii <eliz@gnu.org>
3167
3168 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3169 consider it a hit if to_charpos is anywhere in the range of the
3170 composed buffer positions.
3171
e013fb34
CY
31722011-08-22 Chong Yidong <cyd@stupidchicken.com>
3173
3174 * image.c (gif_load): Don't assume that each subimage has the same
3175 dimensions as the base image. Handle disposal method that is
3176 "undefined" by the gif spec (Bug#9335).
3177
bd1ba3e8
CY
31782011-08-20 Chong Yidong <cyd@stupidchicken.com>
3179
3180 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3181 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3182
54a1215b
EZ
31832011-08-19 Eli Zaretskii <eliz@gnu.org>
3184
823564e5
EZ
3185 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3186 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3187 from an Org mode buffer to a Speedbar frame.
3188
54a1215b
EZ
3189 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3190 a composition, take its buffer position from IT->cmp_it.charpos.
3191 Fixes cursor positioning at the beginning of a line that begins
3192 with a composed character.
3193
9778ebcc
EZ
31942011-08-18 Eli Zaretskii <eliz@gnu.org>
3195
0be6ee06
EZ
3196 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3197 character bidirectional type, use STRONG_L instead. Fixes crashes
3198 in a buffer produced by `describe-categories'.
3199
9778ebcc
EZ
3200 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3201 members before the level stack, so they would be saved and
3202 restored when copying iterator state. Fixes incorrect reordering
3203 around TABs covered by display properties.
3204
156bffbe
AS
32052011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3206
6b02f655 3207 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3208
72ad093b
CY
32092011-08-17 Chong Yidong <cyd@stupidchicken.com>
3210
3211 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3212 (internal_condition_case_2, internal_condition_case_n):
3213 Remove unnecessary aborts (Bug#9081).
72ad093b 3214
35774242
EZ
32152011-08-17 Eli Zaretskii <eliz@gnu.org>
3216
3217 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3218 has no `load' handler, try opening the file locally. (Bug#9311)
3219
db76dd85
KB
32202011-08-16 Ken Brown <kbrown@cornell.edu>
3221
3222 * gmalloc.c: Expand comment.
3223
b215eee5
EZ
32242011-08-16 Eli Zaretskii <eliz@gnu.org>
3225
3226 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3227 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3228
a4579d33
KB
32292011-08-16 Ken Brown <kbrown@cornell.edu>
3230
3231 Fix memory allocation problems in Cygwin build (Bug#9273).
3232
3233 * unexcw.c ( __malloc_initialized): Declare external variable.
3234 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3235
8b76d6f8
SM
3236 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3237 New variables.
a4579d33
KB
3238 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3239 dumped emacs.
3240 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3241 in the static heap.
3242 [CYGWIN] (special_realloc): New function.
3243 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3244 requests to realloc storage in the static heap.
3245
3ebec551
PE
32462011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3247
3248 * bidi.c (bidi_initialize): Remove unused local.
3249
9fd8be00
EZ
32502011-08-15 Eli Zaretskii <eliz@gnu.org>
3251
6b02f655
SM
3252 * bidimirror.h:
3253 * biditype.h: Remove file.
3254 * makefile.w32-in ($(BLD)/bidi.$(O)):
3255 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3256
3257 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3258
3259 * chartab.c: Improve commentary for the uniprop_table API.
3260
32413314
EZ
3261 * bidi.c (bidi_paragraph_init): Support zero value of
3262 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3263 (bidi_initialize): Use uniprop_table instead of including
3264 biditype.h and bidimirror.h.
32413314 3265
9fd8be00
EZ
3266 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3267 coordinates of the iterator when restoring from ppos_it.
3268 (Bug#9296)
3269
5cf2b69b
KH
32702011-08-14 Kenichi Handa <handa@m17n.org>
3271
3272 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3273 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3274
daf17d00
EZ
32752011-08-14 Eli Zaretskii <eliz@gnu.org>
3276
3277 * xdisp.c (move_it_in_display_line_to): Don't invoke
3278 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3279 ppos_it. Fixes vertical cursor motion when line beginning is
3280 covered by an image. (Bug#9296)
3281
08e3161a
JD
32822011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3283
3284 * nsterm.h (ns_run_ascript): Declare.
3285 (NSAPP_DATA2_RUNASSCRIPT): Define.
3286
3287 * nsfns.m (as_script, as_result, as_status): New static variables.
3288 (ns_run_ascript): New function.
5e617bc2 3289 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3290 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3291 the event loop. Get status from as_status (Bug#7276).
3292
3293 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3294 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3295 the event loop (Bug#7276).
3296
a3720aa2
AS
32972011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3298
3299 * gnutls.c (QCgnutls_bootprop_priority)
3300 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3301 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3302 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3303 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3304 (QCgnutls_bootprop_verify_hostname_error)
3305 (QCgnutls_bootprop_callbacks_verify): Rename from
3306 Qgnutls_bootprop_..., all uses changed.
3307
3308 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3309 uses changed.
3310
0a0d27fb
PE
33112011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3312
19d5c50c
PE
3313 * xfaces.c (Qframe_set_background_mode): Now static.
3314 * dispextern.h (Qframe_set_background_mode): Remove decl.
3315
0a0d27fb
PE
3316 * process.c (Fnetwork_interface_info): Declare local only if needed.
3317
377538cb
JD
33182011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3319
3320 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3321 (Fnetwork_interface_list): Allocate in increments of bytes instead
3322 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3323 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3324 sockaddr.
3325 (struct ifflag_def): notrailers is smart on OSX.
3326 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3327 Get hardware address with getifaddrs if available.
3328
08fff70c
EZ
33292011-08-12 Eli Zaretskii <eliz@gnu.org>
3330
3331 * xdisp.c (iterate_out_of_display_property): xassert that
3332 IT->position is set to within IT->object's boundaries. Break from
3333 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3334 when IT->position is set up wrongly due to some bug.
3335 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3336 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3337 entry. Force push_it to save on the stack the current
3338 buffer/string position, to be restored by pop_it. Fix flags in
3339 the iterator structure wrt the object coming from a display
3340 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3341 properties. (Bug#9284)
3342
7be1c708 33432011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3344
7be1c708
CY
3345 * fontset.c (fontset_get_font_group): Add proper type checks.
3346 (Bug#9172)
aac0c6e3 3347
7be1c708 33482011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3349
7be1c708
CY
3350 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3351 and LC_VERSION_MIN_MACOSX.
3352 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3353 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3354
97bb72a6
EZ
33552011-08-08 Eli Zaretskii <eliz@gnu.org>
3356
3357 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3358 no-display-properties-and-no-overlays under bidi display.
3359 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3360 properties and overlays.
97bb72a6 3361
d5617611
CY
33622011-08-08 Chong Yidong <cyd@stupidchicken.com>
3363
37e11a63
CY
3364 * editfns.c (Fset_time_zone_rule): Document relationship with the
3365 setenv function.
3366
d5617611
CY
3367 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3368 the font entity extracted from the cache (Bug#8109).
3369
58872834
CY
33702011-08-07 Chong Yidong <cyd@stupidchicken.com>
3371
3372 * composite.c (autocmp_chars): Don't reset point. That is done by
3373 restore_point_unwind (Bug#5984).
3374
75bfc667
JL
33752011-08-07 Juri Linkov <juri@jurta.org>
3376
3377 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3378 to show the arg `TIME' instead of `TIMEVAL'.
3379
d1410150
EZ
33802011-08-06 Eli Zaretskii <eliz@gnu.org>
3381
3382 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3383 display property strides EOL and includes a newline, as in
3384 longlines-mode. (Bug#9254)
75b771e4
EZ
3385 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3386 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3387
3388 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3389 is non-zero, even if the data buffer is NULL. Fixes a crash in
3390 vertical-motion with longlines-mode. (Bug#9254)
3391
35928349
EZ
33922011-08-05 Eli Zaretskii <eliz@gnu.org>
3393
ec7cc85b
EZ
3394 * bidi.c <bidi_cache_total_alloc>: Now static.
3395 (bidi_initialize): Initialize bidi_cache_total_alloc.
3396
8b76d6f8 3397 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3398 cache. (Bug#9221)
3399
3400 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3401 amount allocated this far in `bidi_cache_total_alloc'.
3402 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3403 non-zero, only free the data buffer without restoring the cache
3404 contents. All callers changed.
3405
3406 * dispextern.h (bidi_unshelve_cache): Update prototype.
3407
3408 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3409 (move_it_in_display_line, move_it_to)
3410 (move_it_vertically_backward, move_it_by_lines): Replace the call
3411 to xfree to an equivalent call to bidi_unshelve_cache.
3412 (move_it_in_display_line_to): Fix logic of returning
412b6358 3413 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3414
e2e2423b
EZ
34152011-08-05 Eli Zaretskii <eliz@gnu.org>
3416
3417 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3418 came from a string character with a `cursor' property. (Bug#9229)
3419
ae9e757a
JD
34202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3421
3422 * Makefile.in (LIB_PTHREAD): New variable.
3423 (LIBES): Add LIB_PTHREAD (Bug#9216).
3424
3425 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3426 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3427
213bd7f2
AS
34282011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3429
6b02f655 3430 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3431
99aaf75f
JD
34322011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3433
3434 * xterm.c (x_find_topmost_parent): New function.
3435 (x_set_frame_alpha): Find topmost parent window with
3436 x_find_topmost_parent and set the property there also (bug#9181).
3437 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3438
c74e9d86
PE
34392011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 * callproc.c (Fcall_process): Avoid vfork clobbering
3442 the local vars buffer, coding_systems, current_dir.
3443
640c8776
SM
34442011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3445
3446 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3447
f26d0e4c
PE
34482011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3449
8a10d76c
PE
3450 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3451 so that it is not optimized away.
3452
f26d0e4c
PE
3453 * xdisp.c (compute_display_string_pos): Remove unused local.
3454
55439c61
EZ
34552011-08-02 Eli Zaretskii <eliz@gnu.org>
3456
3457 Fix slow cursor motion and scrolling in large buffers with
3458 selective display, like Org Mode buffers. (Bug#9218)
3459
3460 * dispextern.h (struct bidi_it): New member disp_prop_p.
3461
3462 * xdisp.c: Remove one-slot cache of display string positions.
3463 (compute_display_string_pos): Accept an additional argument
5e617bc2 3464 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3465 for a display string or property. If found, set DISP_PROP_P
3466 non-zero.
3467
3468 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3469 DISP_PROP_P, and pass it to compute_display_string_pos.
3470 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3471 non-zero. All callers of bidi_fetch_char changed.
3472
fb33fa43
SM
34732011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3474
3475 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3476
b099e063
DM
34772010-12-03 Don March <don@ohspite.net>
3478
3479 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3480 last character M-[char] is translated to ESC [char] (bug#7541).
3481
5cc7f7af
KH
34822011-08-02 Kenichi Handa <handa@m17n.org>
3483
d0fffa3f 3484 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3485
3486 * chartab.c (uniprop_table): Make it non-static.
3487
525d5e6e
EZ
34882011-08-01 Eli Zaretskii <eliz@gnu.org>
3489
3490 * xdisp.c (forward_to_next_line_start): Accept additional argument
3491 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3492 on the newline.
3493 (reseat_at_next_visible_line_start): Use the bidi iterator state
3494 returned by forward_to_next_line_start to restore the state of
3495 it->bidi_it after backing up to previous newline. (Bug#9212)
3496
31011111
AS
34972011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3498
3499 * regex.c (re_comp): Protoize.
3500 (re_exec): Fix return type.
3501 (regexec): Fix type of `ret'. (Bug#9203)
3502
476371c4
PE
35032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3504
e5d76069
PE
3505 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3506 This is needed if max-image-size is a floating-point number.
3507
9a79b20c
AS
35082011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3509
3510 * print.c (print_object): Print empty symbol as ##.
3511
3512 * lread.c (read1): Read ## as empty symbol.
3513
d8c2fa78
AA
35142011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3515
3516 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3517 setting frame foreground color (Bug#9175).
3518 (x_set_background_color): Likewise.
3519
ffe57a7a
AA
3520 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3521 contents (Bug#9176).
3522 (EmacsTooltip -init): Remove bezels and add shadows to
3523 tooltip windows.
3524
bf3492a5
AA
3525 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3526 or scroll bar (Bug#8470).
3527
d55e9c53
AA
3528 * nsfont.m (nsfont_open): Remove assignment to voffset and
3529 unnecessary vars hshink, expand, hd, full_height, min_height.
3530 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3531
3532 * nsterm.h (nsfont_info): Remove voffset field.
3533
d8c2fa78 35342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3535
3536 Implement strike-through and overline on NextStep (Bug#8863).
3537
3538 * nsfont.m (nsfont_open): Use underline position provided by font,
3539 instead of hard-coded value of 2.
3540 (nsfont_draw): Call ns_draw_text_decoration instead.
3541
3542 * nsterm.h: Add declaration for ns_draw_text_decoration.
3543
3544 * nsterm.m (ns_draw_text_decoration): New function for drawing
3545 underline, overline, and strike-through.
3546 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3547 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3548 accommodate underlining, etc.
4843aac3 3549
4cc60b9b
EZ
35502011-07-28 Eli Zaretskii <eliz@gnu.org>
3551
bc7ece87
EZ
3552 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3553 default.
4cc60b9b 3554
476371c4
PE
35552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3556
66606eea
PE
3557 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3558 Without this fix, if a signal arrives just after memory fills up,
3559 'malloc' might be invoked reentrantly.
3560
476371c4
PE
3561 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3562 In other words, assume that every image size is allowed, on non-X
3563 hosts. This assumption is probably wrong, but it lets Emacs compile.
3564
f3fcc40d
AS
35652011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3566
3567 * regex.c (re_iswctype): Convert return values to boolean.
3568
350c992f
EZ
35692011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3570
3571 * xdisp.c (compute_display_string_pos): Don't use cached display
3572 string position if the buffer had its restriction changed.
3573 (Bug#9184)
3574
5266b4bb
PE
35752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3576
3577 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3578
2573a837 35792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3580
41f55ccd 3581 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3582
39e378da
PE
3583 * bidi.c: Integer size and overflow fixes.
3584 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3585 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3586 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3587 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3588 (bidi_find_other_level_edge):
3589 Use ptrdiff_t instead of EMACS_INT where either will do.
3590 This works better on 32-bit hosts configured --with-wide-int.
3591 (bidi_cache_ensure_space): Check for size-calculation overflow.
3592 Use % rather than repeated addition, for better worst-case speed.
3593 Don't set bidi_cache_size until after xrealloc returns, because it
3594 might not return.
3595 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3596 (bidi_cache_ensure_space): Also check that the bidi cache size
3597 does not exceed that of the largest Lisp string or buffer. See Eli
3598 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3599
5e927815
PE
3600 * alloc.c (__malloc_size_t): Remove.
3601 All uses replaced by size_t. See Andreas Schwab's note
3602 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3603
ca4aa935
PE
3604 * image.c: Improve checking for integer overflow.
3605 (check_image_size): Assume that f is nonnull, since
3606 it is always nonnull in practice. This is one less thing to
3607 worry about when checking for integer overflow later.
3608 (x_check_image_size): New function, which checks for integer
3609 overflow issues inside X.
3610 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3611 This removes the need for a memory_full check.
3612 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3613 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3614 (xbm_read_bitmap_data): Change locals back to 'int', since
3615 their values must fit in 'int'.
3616 (xpm_load_image, png_load, tiff_load):
3617 Invoke x_create_x_image_and_pixmap earlier,
3618 to avoid much needless work if the image is too large.
3619 (tiff_load): Treat overly large images as if
3620 x_create_x_image_and_pixmap failed, not as malloc failures.
3621 (gs_load): Use x_check_image_size.
3622
5f8f9cc2
PE
3623 * gtkutil.c: Omit integer casts.
3624 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3625 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3626
5adf60bc
PE
3627 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3628
c8907a93
PE
3629 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3630 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3631 would wrongly return t on a 64-bit host.
3632
e3c25c68
PE
3633 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3634 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3635 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3636 and therefore cause GCC to emit a bogus diagnostic in some cases.
3637
3f791afe
PE
3638 * image.c: Integer signedness and overflow and related fixes.
3639 This is not an exhaustive set of fixes, but it's time to
3640 record what I've got.
3641 (lookup_pixel_color, check_image_size): Remove redundant decls.
3642 (check_image_size): Don't assume that arbitrary EMACS_INT values
3643 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3644 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3645 (tiff_load, imagemagick_load_image):
3646 Check for overflow in size calculations.
3647 (x_create_x_image_and_pixmap): Remove unnecessary test for
3648 xmalloc returning NULL; that can't happen.
3649 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3650 (xpm_color_bucket): Use better integer hashing function.
3651 (xpm_cache_color): Don't possibly over-allocate memory.
3652 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3653 (gif_memory_source):
3654 Use ptrdiff_t, not int or size_t, to record sizes.
3655 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3656 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3657 either works, as we prefer signed integers.
3658 (tiff_read_from_memory, tiff_write_from_memory):
3659 Return tsize_t, not size_t, since that's what the TIFF API wants.
3660 (tiff_read_from_memory): Don't fail simply because the read would
3661 go past EOF; instead, return a short read.
3662 (tiff_load): Omit no-longer-needed casts.
3663 (Fimagemagick_types): Don't assume size fits into 'int'.
3664
3cc5a532
PE
3665 Improve hashing quality when configured --with-wide-int.
3666 * fns.c (hash_string): New function, taken from sxhash_string.
3667 Do not discard information about ASCII character case; this
3668 discarding is no longer needed.
3669 (sxhash-string): Use it. Change sig to match it. Caller changed.
3670 * lisp.h: Declare it.
3671 * lread.c (hash_string): Remove, since we now use fns.c's version.
3672 The fns.c version returns a wider integer if --with-wide-int is
3673 specified, so this should help the quality of the hashing a bit.
3674
b312a492
PE
3675 * emacs.c: Integer overflow minor fix.
3676 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3677 Define only if GNU_LINUX.
3678 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3679
dfd153ae
PE
3680 * dispnew.c: Integer signedness and overflow fixes.
3681 Remove unnecessary forward decls, that were a maintenance hassle.
3682 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3683 All uses changed.
3684 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3685 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3686 (prepare_desired_row, line_draw_cost):
3687 Use int, not unsigned, where either works.
3688 (save_current_matrix, restore_current_matrix):
3689 Use ptrdiff_t, not size_t, where either works.
3690 (init_display): Check for overflow more accurately, and without
3691 relying on undefined behavior.
3692
a81d11a3
PE
3693 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3694 Remove, replacing with the new symbols in lisp.h. All uses changed.
3695 * fileio.c (make_temp_name):
3696 * filelock.c (lock_file_1, lock_file):
3697 * xdisp.c (message_dolog):
3698 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3699 Use pMd etc. instead.
3700 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3701 replacing the pWIDE etc. symbols removed from editfns.c.
3702
3300e6fd
PE
3703 * keyboard.h (num_input_events): Now uintmax_t.
3704 This is (very slightly) less likely to mess up due to wraparound.
3705 All uses changed.
3706
fd05c7e9
PE
3707 * buffer.c: Integer signedness fixes.
3708 (alloc_buffer_text, enlarge_buffer_text):
3709 Use ptrdiff_t rather than size_t when either will do, as we prefer
3710 signed integers.
3711
903fe15d
PE
3712 * alloc.c: Integer signedness and overflow fixes.
3713 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3714 (__malloc_size_t): Default to size_t, not to int.
3715 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3716 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3717 Prefer ptrdiff_t to size_t when either would do, as we prefer
3718 signed integers.
3719 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3720 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3721 Now const. Initialize with values that are in range even if char
3722 is signed.
3723 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3724 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3725 These functions do the right thing with sizes > 2**32.
3726 (check_depth): Now ptrdiff_t, not int.
3727 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3728 Adjust to new way of storing sizes. Check for size overflow bugs
3729 in rest of code.
3730 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3731 slightly wrong anyway, as it missed one instance of
3732 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3733 (refill_memory_reserve): Omit needless cast to size_t.
3734 (mark_object_loop_halt): Mark as externally visible.
3735
ac82cc6a
PE
3736 * xselect.c: Integer signedness and overflow fixes.
3737 (Fx_register_dnd_atom, x_handle_dnd_message):
3738 Use ptrdiff_t, not size_t, since we prefer signed.
3739 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3740 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3741 x_dnd_atoms_size and x_dnd_atoms_length.
3742
c2d1e36d
PE
3743 * doprnt.c: Prefer signed to unsigned when either works.
3744 * eval.c (verror):
3745 * doprnt.c (doprnt):
3746 * lisp.h (doprnt):
3747 * xdisp.c (vmessage):
3748 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3749 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3750 prefer signed arithmetic to avoid comparison confusion.
3751 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3752 but is a bit tricky.
3753
0e926e56
PE
3754 Assume freestanding C89 headers, string.h, stdlib.h.
3755 * data.c, doprnt.c, floatfns.c, print.c:
3756 Include float.h unconditionally.
3757 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3758 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3759 * regex.c: Likewise for stddef.h, string.h.
3760 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3761 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3762 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3763 (STDC_HEADERS): Remove obsolete defines.
3764 * sysdep.c: Include limits.h unconditionally.
3765
9cfdb3ec
PE
3766 Assume support for memcmp, memcpy, memmove, memset.
3767 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3768 * regex.c (memcmp, memcpy):
3769 Remove; we assume C89 now.
3770
3771 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3772 (__malloc_safe_bcopy): Remove; no longer needed.
3773
cf950e6b 3774 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3775 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3776 well either way, and we prefer signed to unsigned.
3777
dbf38e02
LMI
37782011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3779
3780 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3781 closes the connection while we're reading (bug#9182).
3782
d6f0886c 37832011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3784
d6f0886c
JD
3785 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3786 are specified (Bug#9168).
24e0f6b1 3787
2eb1f9e6
PE
37882011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3789
3790 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3791 Found by GCC static checking and --with-wide-int on a 32-bit host.
3792
22381272 37932011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3794
3795 * xdisp.c (compute_display_string_pos): Fix logic of caching
3796 previous display string position. Initialize cached_prev_pos to
3797 -1. Fixes slow-down at the beginning of a buffer.
3798
f25e39b4
EZ
37992011-07-24 Eli Zaretskii <eliz@gnu.org>
3800
3801 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3802 for attrs[LFACE_FONTSET_INDEX].
3803
04c4b52e
PE
38042011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3805
3806 * xml.c (parse_region): Remove unused local
3807 that was recently introduced.
3808
c1734fbd
EZ
38092011-07-23 Eli Zaretskii <eliz@gnu.org>
3810
be18c5a5
EZ
3811 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3812 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3813
c1734fbd
EZ
3814 * xdisp.c (move_it_in_display_line_to): Record the best matching
3815 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3816 exit if none of the characters scanned was an exact match.
3817 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3818 when exact match is impossible due to invisible text, and the
3819 lines are truncated.
3820
a258d627
JD
38212011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3824 for OSX >= 10.7.
3825
b6d5a689
EZ
38262011-07-22 Eli Zaretskii <eliz@gnu.org>
3827
0f74f785
EZ
3828 Fix a significant slow-down of cursor motion with C-n, C-p,
3829 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3830 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3831 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3832 (next_element_from_buffer): Call compute_stop_pos_backwards to
3833 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3834 base_level_stop.
3835 (reseat): Don't look for prev_stop, as that could mean a very long
3836 run.
3837 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3838 <cached_disp_overlay_modiff>: Cache for last found display string
3839 position.
551918c1 3840 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3841 about the same buffer in the same area of character positions, and
3842 the buffer wasn't changed since the time the display string
3843 position was cached.
551918c1 3844
b2d0c91a
EZ
38452011-07-22 Eli Zaretskii <eliz@gnu.org>
3846
3847 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3848 is an integer, which is important for empty lines. (Bug#9149)
3849
043604ee
CY
38502011-07-22 Chong Yidong <cyd@stupidchicken.com>
3851
3852 * frame.c (Fmodify_frame_parameters): In tty case, update the
3853 default face if necessary (Bug#4238).
3854
da4adb04
CY
38552011-07-21 Chong Yidong <cyd@stupidchicken.com>
3856
3857 * editfns.c (Fstring_to_char): No need to explain what a character
3858 is in the docstring (Bug#6576).
3859
9abd0532
LMI
38602011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3861
3862 * xml.c (parse_region): Make sure we always return a tree.
3863
36881d16
HK
38642011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3865
3866 * xml.c (parse_region): If a document contains only comments,
3867 return that, too.
3868
1e98674d
LMI
38692011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3870
3871 * xml.c (make_dom): Return comments, too.
3872
590bd467
PE
38732011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3874
3875 Port to OpenBSD.
3876 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3877 and the surrounding thread.
3878 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3879 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3880 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3881 timer goes off.
3882 * s/openbsd.h (BROKEN_SIGIO): Define.
3883 * unexelf.c (unexec) [__OpenBSD__]:
3884 Don't update the .mdebug section of the Alpha COFF symbol table.
3885
f41628b2
LMI
38862011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3887
3888 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3889 (bug#8460).
3890
b59b67c5
PE
38912011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3892
15e3a074
PE
3893 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3894 This fixes some race conditions on the permissions of any newly
3895 created file.
3896
41bed37d
PE
3897 * alloc.c (valid_pointer_p): Use pipe, not open.
3898 This fixes some permissions issues when debugging.
3899
b59b67c5
PE
3900 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3901 If fchown fails to set both uid and gid, try to set just gid,
3902 as that is sometimes allowed. Adjust the file's mode to eliminate
3903 setuid or setgid bits that are inappropriate if fchown fails.
3904
925a6be7
SM
39052011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3906
3907 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3908 to compare Lisp_Objects.
3909 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3910 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3911 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3912
52968808
AS
39132011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3914
0a6a104b
AS
3915 * lread.c (read_integer): Unread even EOF character.
3916 (read1): Likewise. Properly record start position of symbol.
3917
52968808
AS
3918 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3919 symbol character follows.
3920
9e381cdd
PE
39212011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3922
3923 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3924 This works around a problem with the previous change to Fcopy_file.
3925 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3926 and without this change, GCC might complain about discarding
3927 fchown's return value.
3928
b5641435
JB
39292011-07-16 Juanma Barranquero <lekktu@gmail.com>
3930
3931 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3932
a8031457
PE
39332011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3934
3935 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3936
dd889327
LMI
39372011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3938
750c33f7
LMI
3939 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3940 it's used from the C level.
3941
dd889327
LMI
3942 * process.c: Use the same condition for POLL_FOR_INPUT in both
3943 keyboard.c and process.c (bug#1858).
3944
87e86684
LM
39452011-07-09 Lawrence Mitchell <wence@gmx.li>
3946
3947 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3948 (Fgnutls_boot): Use it.
3949
64348f40
AS
39502011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3951
3952 * doc.c (Fsubstitute_command_keys): Revert last change.
3953
1d698799
LMI
39542011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3955
f863868c
LMI
3956 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3957 quotes the next character, and doesn't affect other longer
3958 sequences (bug#8935).
3959
1d698799
LMI
3960 * lread.c (syms_of_lread): Clarify that is isn't only
3961 `eval-buffer' and `eval-defun' that's affected by
3962 `lexical-binding' (bug#8460).
3963
aa4b6df6
EZ
39642011-07-15 Eli Zaretskii <eliz@gnu.org>
3965
3966 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3967 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3968
5d856da6
PE
39692011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3970
ad6042bb
PE
3971 Fix minor problems found by static checking.
3972 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3973 (elsz): Now a signed constant, not a size_t var. We prefer signed
3974 types to unsigned, to avoid integer comparison confusion. Without
3975 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3976 "cannot optimize loop, the loop counter may overflow", a symptom
3977 of the confusion.
f00bbb22 3978 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3979 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3980
6468f31c
LMI
39812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3982
49080b10
LMI
3983 * search.c (Fre_search_backward): Mention `case-fold-search' in
3984 all the re_search_* functions (bug#8138).
3985
6468f31c
LMI
3986 * keyboard.c (Fopen_dribble_file): Document when the file is
3987 closed (bug#8056).
3988
c965adc5
EZ
39892011-07-14 Eli Zaretskii <eliz@gnu.org>
3990
df9733bf
EZ
3991 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3992 bidi_cache_idx.
3993
0bb23927
EZ
3994 Support bidi reordering of display and overlay strings.
3995 * xdisp.c (compute_display_string_pos)
3996 (compute_display_string_end): Accept additional argument STRING.
3997 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3998 (reseat_to_string): Initialize bidi_it->string.s and
3999 bidi_it->string.schars.
4000 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4001 NULL (avoids a crash in bidi_paragraph_init).
4002 Initialize itb.string.lstring.
0bb23927
EZ
4003 (init_iterator): Call bidi_init_it only of a valid
4004 buffer position was specified. Initialize paragraph_embedding to
4005 L2R.
4006 (reseat_to_string): Initialize the bidi iterator.
4007 (display_string): If we need to ignore text properties of
4008 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4009 original value of -1 will not work with bidi.)
4010 (compute_display_string_pos): First arg is now struct
4011 `text_pos *'; all callers changed. Support display properties on
4012 Lisp strings.
4013 (compute_display_string_end): Support display properties on Lisp
4014 strings.
4015 (init_iterator, reseat_1, reseat_to_string): Initialize the
4016 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4017 when iterating on a string not from display properties).
640c8776
SM
4018 (compute_display_string_pos, compute_display_string_end):
4019 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4020 arrow keys.
4021 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4022 base_level_stop; instead, set base_level_stop to BEGV.
4023 Fixes crashes in vertical-motion.
0bb23927
EZ
4024 (next_element_from_buffer): Improve commentary for when
4025 the iterator is before prev_stop.
4026 (init_iterator): Initialize bidi_p from the default value of
4027 bidi-display-reordering, not from buffer-local value. Use the
4028 buffer-local value only if initializing for buffer iteration.
4029 (handle_invisible_prop): Support invisible properties on strings
4030 that are being bidi-reordered.
4031 (set_iterator_to_next): Support bidi reordering of C strings and
4032 Lisp strings.
4033 (next_element_from_string): Support bidi reordering of Lisp
4034 strings.
4035 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4036 (display_string): Support display of R2L glyph rows.
4037 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4038 (init_iterator): Don't initialize it->bidi_p for strings
4039 here.
4040 (reseat_to_string): Initialize it->bidi_p for strings here.
4041 (next_element_from_string, next_element_from_c_string)
4042 (next_element_from_buffer): Add xassert's for correspondence
4043 between IT's object being iterated and it->bidi_it.string
4044 structure.
4045 (face_before_or_after_it_pos): Support bidi iteration.
4046 (next_element_from_c_string): Handle the case of the first string
4047 character that is not the first one in the visual order.
4048 (get_visually_first_element): New function, refactored from common
4049 parts of next_element_from_buffer, next_element_from_string, and
4050 next_element_from_c_string.
4051 (tool_bar_lines_needed, redisplay_tool_bar)
4052 (display_menu_bar): Force left-to-right direction. Add a FIXME
4053 comment for making that be controlled by a user option.
4054 (push_it, pop_it): Save and restore the state of the
4055 bidi iterator. Save and restore the bidi_p flag.
4056 (pop_it): Iterate out of display property for string iteration as
4057 well.
4058 (iterate_out_of_display_property): Support iteration over strings.
4059 (handle_single_display_spec): Set up it->bidi_it for iteration
4060 over a display string, and call bidi_init_it.
4061 (handle_single_display_spec, next_overlay_string)
4062 (get_overlay_strings_1, push_display_prop): Set up the bidi
4063 iterator for displaying display or overlay strings.
4064 (forward_to_next_line_start): Don't use the shortcut if
4065 bidi-iterating.
4066 (back_to_previous_visible_line_start): If handle_display_prop
4067 pushed the iterator stack, restore the internal state of the bidi
4068 iterator by calling bidi_pop_it same number of times.
4069 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4070 and we are bidi-iterating, don't decrement the iterator position;
4071 instead, set the first_elt flag in the bidi iterator, to produce
4072 the same effect.
4073 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4074 (push_display_prop): xassert that we are iterating a buffer.
4075 (push_it, pop_it): Save and restore paragraph_embedding member.
4076 (handle_single_display_spec, next_overlay_string)
4077 (get_overlay_strings_1, reseat_1, reseat_to_string)
4078 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4079 correctly. Don't assume unibyte strings are not bidi-reordered.
4080 (compute_display_string_pos)
4081 (compute_display_string_end): Fix handling the case of C string.
4082 (push_it, pop_it): Save and restore from_disp_prop_p.
4083 (handle_single_display_spec, push_display_prop): Set the
4084 from_disp_prop_p flag.
4085 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4086 (pop_it): Call iterate_out_of_display_property only if we are
4087 popping after iteration over a string that came from a display
4088 property. Fix a typo in popping stretch info. Add an assertion
4089 for verifying that the iterator position is in sync with the bidi
4090 iterator.
4091 (handle_single_display_spec, get_overlay_strings_1)
4092 (push_display_prop): Fix initialization of paragraph direction for
4093 string when that of the parent object is not yet determined.
4094 (reseat_1): Call bidi_init_it to resync the bidi
4095 iterator with IT's position. (Bug#7616)
4096 (find_row_edges): If ROW->start.pos gives position
4097 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4098 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4099 Reset the from_disp_prop_p flag.
4100 (SAVE_IT, RESTORE_IT): New macros.
4101 (pos_visible_p, face_before_or_after_it_pos)
4102 (back_to_previous_visible_line_start)
4103 (move_it_in_display_line_to, move_it_in_display_line)
4104 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4105 (try_scrolling, redisplay_window, display_line): Use them when
4106 saving a temporary copy of the iterator and restoring it back.
4107 (back_to_previous_visible_line_start, reseat_1)
4108 (init_iterator): Empty the bidi cache "stack".
4109 (move_it_in_display_line_to): If iterator ended up at
4110 EOL, but we never saw any buffer positions smaller than
4111 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4112 motion in bidi-reordered lines.
4113 (move_it_in_display_line_to): Record prev_method and prev_pos
4114 immediately before the call to set_iterator_to_next. Fixes cursor
4115 motion in bidi-reordered lines with stretch glyphs and strings
4116 displayed in margins. (Bug#8133) (Bug#8867)
4117 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4118 TO_CHARPOS.
640c8776
SM
4119 (pos_visible_p): Support positions in bidi-reordered lines.
4120 Save and restore bidi cache.
0bb23927
EZ
4121
4122 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4123 (bidi_paragraph_info): Delete unused struct.
4124 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4125 (bidi_cache_start): New variable.
4126 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4127 to zero.
4128 (bidi_cache_fetch_state, bidi_cache_search)
4129 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4130 (bidi_cache_find, bidi_peek_at_next_level)
4131 (bidi_level_of_next_char, bidi_find_other_level_edge)
4132 (bidi_move_to_visually_next): Compare cache index with
4133 bidi_cache_start rather than with zero.
4134 (bidi_fetch_char): Accept new argument STRING; all callers
4135 changed. Support iteration over a string. Support strings with
4136 display properties. Support unibyte strings. Fix the type of
4137 `len' according to what STRING_CHAR_AND_LENGTH expects.
4138 (bidi_paragraph_init, bidi_resolve_explicit_1)
4139 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4140 (bidi_level_of_next_char, bidi_move_to_visually_next):
4141 Support iteration over a string.
0bb23927
EZ
4142 (bidi_set_sor_type, bidi_resolve_explicit_1)
4143 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4144 can now be zero (for strings); special values 0 and -1 were
4145 changed to -1 and -2, respectively.
4146 (bidi_char_at_pos): New function.
4147 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4148 Call it instead of FETCH_MULTIBYTE_CHAR.
4149 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4150 initialized to valid values.
4151 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4152 values.
4153 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4154 the test for valid cached positions. Fix the logic for looking up
4155 the sentinel state in the cache. GCPRO the Lisp string we are
4156 iterating.
4157 (bidi_push_it, bidi_pop_it): New functions.
4158 (bidi_initialize): Initialize the bidi cache start stack pointer.
4159 (bidi_cache_ensure_space): New function, refactored from part of
4160 bidi_cache_iterator_state. Don't assume the required size is just
4161 one BIDI_CACHE_CHUNK away.
4162 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4163 (bidi_count_bytes, bidi_char_at_pos): New functions.
4164 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4165 always valid if bidi_cache_idx is valid.
4166 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4167 is valid if it's going to be used.
4168 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4169 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4170 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4171 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4172 (bidi_find_other_level_edge, bidi_cache_start_stack):
4173 All variables related to cache indices are now EMACS_INT.
c965adc5 4174
0bb23927
EZ
4175 * dispextern.h (struct bidi_string_data): New structure.
4176 (struct bidi_it): New member `string'. Make flag members be 1-bit
4177 fields, and put them last in the struct.
640c8776
SM
4178 (compute_display_string_pos, compute_display_string_end):
4179 Update prototypes.
0bb23927
EZ
4180 (bidi_push_it, bidi_pop_it): Add prototypes.
4181 (struct iterator_stack_entry): New members bidi_p,
4182 paragraph_embedding, and from_disp_prop_p.
4183 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4184 (bidi_shelve_cache, bidi_unshelve_cache):
4185 Declare prototypes.
0bb23927
EZ
4186
4187 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4188 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4189 and vector-like objects.
4190
4191 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4192 cache around display iteration.
4193
4194 * window.c (Fwindow_end, window_scroll_pixel_based)
4195 (displayed_window_lines, Frecenter): Save and restore the bidi
4196 cache around display iteration.
4197
3bbd2265
LMI
41982011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4199
4200 * editfns.c (Fdelete_region): Clarify the use of the named
4201 parameters (bug#6788).
4202
adc47434
MR
42032011-07-14 Martin Rudalics <rudalics@gmx.at>
4204
4205 * indent.c (Fvertical_motion): Set and restore w->pointm when
4206 saving and restoring the window's buffer (Bug#9006).
4207
837c31f8
LMI
42082011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4209
4210 * editfns.c (Fstring_to_char): Clarify just what is returned
4211 (bug#6576). Text by Eli Zaretskii.
4212
ac389d0c
JB
42132011-07-13 Juanma Barranquero <lekktu@gmail.com>
4214
4215 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4216
0be0ce47
EZ
42172011-07-13 Eli Zaretskii <eliz@gnu.org>
4218
4219 * buffer.c (mmap_find): Fix a typo.
4220
cd18e7e3
JB
42212011-07-13 Johan Bockgård <bojohan@gnu.org>
4222
4223 Fix execution of x selection hooks.
4224 * xselect.c (Qx_lost_selection_functions)
4225 (Qx_sent_selection_functions): New vars.
4226 (syms_of_xselect): DEFSYM them.
4227 (x_handle_selection_request): Pass Qx_sent_selection_functions
4228 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4229 (x_handle_selection_clear,x_clear_frame_selections):
4230 Pass Qx_lost_selection_functions rather than
4231 Vx_lost_selection_functions to Frun_hook_with_args.
4232
47ea7f44
PE
42332011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4234
ac389d0c 4235 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4236 The old code sometimes used this field without initializing it.
4237
47ea7f44
PE
4238 * alloc.c (gc_sweep): Don't read past end of array.
4239 In theory, the old code could also have corrupted Emacs internals,
4240 though it'd be very unlikely.
4241
bc985c87
AS
42422011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4243
4244 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4245 argument. (Bug#4026)
bc985c87 4246
0cf34688
LMI
42472011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4248
b3dadd76
LMI
4249 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4250 key" (bug#4257).
4251
0cf34688
LMI
4252 * window.c (Fset_window_start): Doc fix (bug#4199).
4253 (Fset_window_hscroll): Ditto.
4254
270768cd
PE
42552011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4256
077e3dda 4257 Fix minor new problems caught by GCC 4.6.1.
270768cd 4258 * term.c (init_tty): Remove unused local.
490011a6 4259 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4260 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4261 not used otherwise.
270768cd 4262
b1f58454
CY
42632011-07-12 Chong Yidong <cyd@stupidchicken.com>
4264
4265 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4266
22b9578d
LMI
42672011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4268
6e70ab07
LMI
4269 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4270 are the mini-buffer and the echo area (bug#3320).
4271
22b9578d
LMI
4272 * term.c (init_tty): Remove support for supdup, c10 and perq
4273 terminals, which are no longer supported (bug#1482).
4274
8974cc9f
JB
42752011-07-10 Johan Bockgård <bojohan@gnu.org>
4276
4277 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4278
a560d974
JD
42792011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4280
4281 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4282 for non-popups (Bug#3642).
4283
1dae0f0a
AS
42842011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4285
268c2c36 4286 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4287 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4288 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4289 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4290 * data.c (fmod): Likewise.
4291 * dispnew.c (swap_glyphs_in_rows): Likewise.
4292 * emacs.c (memory_warning_signal): Likewise.
4293 * floatfns.c (float_error): Likewise.
4294 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4295 (otf_open, font_otf_capability, generate_otf_features)
4296 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4297 Likewise.
4298 * image.c (pbm_read_file): Likewise.
4299 * indent.c (string_display_width): Likewise.
4300 * intervals.c (check_for_interval, search_for_interval)
4301 (inc_interval_count, count_intervals, root_interval)
4302 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4303 * lread.c (defalias): Likewise.
268c2c36 4304 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4305 * regex.c (set_image_of_range_1, set_image_of_range)
4306 (regex_grow_registers): Likewise.
4307 * sysdep.c (strerror): Likewise.
4308 * termcap.c (valid_filename_p, tprint, main): Likewise.
4309 * tparam.c (main): Likewise.
4310 * unexhp9k800.c (run_time_remap, save_data_space)
4311 (update_file_ptrs, read_header, write_header, calculate_checksum)
4312 (copy_file, copy_rest, display_header): Likewise.
4313 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4314 Likewise.
4315 * xdisp.c (check_it): Likewise.
4316 * xfaces.c (register_color, unregister_color, unregister_colors):
4317 Likewise.
4318 * xfns.c (print_fontset_result): Likewise.
4319 * xrdb.c (member, fatal, main): Likewise.
4320
99033785
PE
43212011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4322
4323 Fix minor problems found by static checking (Bug#9031).
4324 * chartab.c (char_table_set_range, map_sub_char_table):
4325 Remove unused locals.
4326 (uniprop_table): Now static.
4327 * composite.c (_work_char): Remove unused static var.
4328
9cb2ac56
JB
43292011-07-09 Juanma Barranquero <lekktu@gmail.com>
4330
4331 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4332
f25661f0
JD
43332011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4334
4335 * gtkutil.c (qttip_cb): Remove code without function.
4336
8278c4fe
EZ
43372011-07-09 Eli Zaretskii <eliz@gnu.org>
4338
4339 * w32.c (pthread_sigmask): New stub.
4340
1692ae2d 43412011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4342
8a6ebd58 4343 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4344 sigprocmask is portable only for single-threaded applications, and
4345 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4346 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4347 (LIBES): Use it.
4348 * callproc.c (Fcall_process):
4349 * process.c (create_process):
4350 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4351 Use pthread_sigmask, not sigprocmask.
123403e4 4352
1b854618
JD
43532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4354
4355 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4356 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4357 wrong (Bug#8591).
4358
3fe4b549
JD
43592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4360
0ce7e563
JD
4361 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4362 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4363 (xg_hide_tooltip): Fix comment.
4364
3fe4b549
JD
4365 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4366 in registerServicesMenuSendTypes.
4367 (validRequestorForSendType): Don't check ns_return_types.
4368
4369 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4370 ns_return_type.
4371
5df75e47
JR
43722011-07-08 Jason Rumney <jasonr@gnu.org>
4373
22610910
JR
4374 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4375 SH_SHOW for hidden windows (Bug#5482).
4376
5df75e47
JR
4377 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4378 frame struct members of non-existent frames (Bug#6284).
4379
699c10bd
JD
43802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4381
4393663b
JD
4382 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4383 variable firstTime not needed on OSX >= 10.6.
4384 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4385 >= 10.5. Use setKnobProportion, setDoubleValue.
4386
4387 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4388 (MAC_OS_X_VERSION_10_5): Define if not defined.
4389 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4390 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4391 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4392
4393 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4394 cString and lossyCString on OSX >= 10.4
4395
58179cce 4396 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4397 sizeToFit on OSX >= 10.2.
4398
4399 * nsimage.m (allocInitFromFile): Don't use deprecated method
4400 bestRepresentationForDevice on OSX >= 10.6.
4401
4402 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4403 to avoid warning.
4404
4405 * emacs.c: Declare unexec_init_emacs_zone.
4406
a63e0781
JD
4407 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4408
699c10bd
JD
4409 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4410
4411 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4412 on svcsMenu (Bug#8842).
4413
4414 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4415 ns_return_types.
4416 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4417
4418 * nsterm.m (QUTF8_STRING): Declare.
4419 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4420 (validRequestorForSendType): Return type is (id).
4421 Change indexOfObjectIdenticalTo to indexOfObject.
4422 Check if we have local selection before returning self (Bug#8842).
4423 (writeSelectionToPasteboard): Put local selection into paste board
4424 if we have a local selection (Bug#8842).
4425 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4426
4427 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4428 (ns_get_local_selection): Declare.
4429
54e10184
LMI
44302011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4431
9888ff71
LMI
4432 * keymap.c (describe_map_tree): Don't insert a double newline at
4433 the end of the buffer (bug#1169) and return whether we inserted
4434 something.
4435
54e10184
LMI
4436 * callint.c (Fcall_interactively): Change "reading args" to
4437 "providing args" to try to clarify what it does (bug#1010).
4438
15fa4783
KH
44392011-07-07 Kenichi Handa <handa@m17n.org>
4440
4441 * composite.c (composition_compute_stop_pos): Ignore a static
4442 composition starting before CHARPOS (Bug#8915).
4443
4444 * xdisp.c (handle_composition_prop): Likewise.
4445
a8815b00
EZ
44462011-07-07 Eli Zaretskii <eliz@gnu.org>
4447
4448 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4449 (Bug#9015)
4450
ef7b981d 44512011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4452
4453 * character.h (unicode_category_t): New enum type.
4454
4455 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4456 (Qchar_code_property_table): New variable.
4457 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4458 (UNIPROP_COMPRESSED_FORM_P): New macros.
4459 (char_table_ascii): Uncompress the compressed values.
4460 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4461 Uncompress the compressed values.
ac389d0c 4462 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4463 (char_table_ref_and_range): Uncompress the compressed values.
4464 (sub_char_table_set): New arg is_uniprop. Callers changed.
4465 Uncompress the compressed values.
4466 (sub_char_table_set_range): Args changed. Callers changed.
4467 (char_table_set_range): Adjuted for the above change.
4468 (map_sub_char_table): Delete args default_val and parent. Add arg
4469 top. Give decoded values to a Lisp function.
640c8776 4470 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4471 values to a Lisp function. Gcpro more variables.
4472 (uniprop_table_uncompress)
4473 (uniprop_decode_value_run_length): New functions.
4474 (uniprop_decoder, uniprop_decoder_count): New variables.
4475 (uniprop_get_decoder, uniprop_encode_value_character)
4476 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4477 New functions.
4478 (uniprop_encoder, uniprop_encoder_count): New variables.
4479 (uniprop_get_encoder, uniprop_table)
4480 (Funicode_property_table_internal, Fget_unicode_property_internal)
4481 (Fput_unicode_property_internal): New functions.
4482 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4483 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4484 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4485 char-code-property-alist.
4486
640c8776 4487 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4488 Vunicode_category_table.
4489
640c8776 4490 * font.c (font_range): Adjust for the change of
c805dec0
KH
4491 Vunicode_category_table.
4492
76b397fb
DN
44932011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4494
4495 * m/iris4d.h: Remove file, move contents ...
4496 * s/irix6-5.h: ... here.
4497
22b4128e
PE
44982011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4499
4500 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4501 * alloc.c (mark_buffer):
4502 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4503 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4504 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4505 This isn't true in general, and it's particularly not true
4506 if Emacs is configured with --with-wide-int.
4507 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4508 New macros, used in the buffer.c change.
4509
869795d6
JD
45102011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4511
4512 * xsettings.c: Use both GConf and GSettings if both are available.
4513 (store_config_changed_event): Add comment.
4514 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4515 (store_tool_bar_style_changed): New functions.
5e617bc2 4516 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4517 (struct xsettings): Move font inside HAVE_XFT.
4518 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4519 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4520 Move inside HAVE_XFT.
640c8776 4521 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4522 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4523 also.
4524 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4525 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4526 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4527 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4528 (parse_settings): Move check for font inside HAVE_XFT.
4529 (read_settings, apply_xft_settings): Add comment.
4530 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4531 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4532 call store_font_name_changed.
4533 (xft_settings_event): Add comment.
4534 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4535 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4536 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4537 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4538 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4539 (xsettings_get_system_font, xsettings_get_system_normal_font):
4540 Add comment.
869795d6 4541
d8ed26bd
PE
45422011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4543
4544 Random fixes. E.g., (random) never returned negative values.
4545 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4546 subseconds part to the entropy, as that's a bit more random.
4547 Prefer signed to unsigned, since the signedness doesn't matter and
4548 in general we prefer signed. When given a limit, use a
4549 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4550 latter isn't right if USE_2_TAGS_FOR_INTS.
4551 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4552 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4553
cabf1cac
SM
45542011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4555
4556 * textprop.c (text_property_stickiness):
4557 Obey Vtext_property_default_nonsticky.
4558 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4559 * w32fns.c (syms_of_w32fns):
4560 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4561
6e9b2be9
PE
45622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4563
4564 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4565 This is more efficient than Ffile_directory_p and avoids a minor race.
4566
90186c68
LMI
45672011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4568
7c301272
LMI
4569 * buffer.c (Foverlay_put): Say what the return value is
4570 (bug#7835).
4571
c4f2d8d4
LMI
4572 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4573 is a directory before asking whether to use the file name
4574 (bug#7564).
ad637907
LMI
4575 (barf_or_query_if_file_exists): Make the "File is a directory"
4576 error be more correct.
c4f2d8d4 4577
90186c68
LMI
4578 * fns.c (Frequire): Remove the mention of the .gz files, since
4579 that's installation-specific, but keep the mention of
4580 `get-load-suffixes'.
4581
da64016e
PE
45822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4583
4584 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4585 Report string overflow if the output is too long.
4586
7d47b580
JB
45872011-07-04 Juanma Barranquero <lekktu@gmail.com>
4588
a555cb87
JB
4589 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4590 (syms_of_gnutls): Remove duplicate DEFSYM for
4591 Qgnutls_bootprop_verify_hostname_error, an error for
4592 Qgnutls_bootprop_verify_error (which is no longer used).
4593
7d47b580
JB
4594 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4595 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4596 Also (re)move comments that are misplaced or no longer relevant.
4597
1e49bfab
LMI
45982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4599
4600 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4601
1485f4c0
CY
46022011-07-03 Chong Yidong <cyd@stupidchicken.com>
4603
4604 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4605 and background color parameters if they have been changed.
4606
a9ab721e
LMI
46072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4608
4609 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4610
cf7cff57
PE
46112011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4612
2e13213d
PE
4613 * xsettings.c (SYSTEM_FONT): Define only when used.
4614 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4615
cf7cff57
PE
4616 * keymap.c (access_keymap_1): Now static.
4617
7a8e04f7
CY
46182011-07-02 Chong Yidong <cyd@stupidchicken.com>
4619
4620 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4621 leave any prefix arg for the up event (Bug#1586).
4622
61352f62
LMI
46232011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4624
69bb1ef7
LMI
4625 * lread.c (syms_of_lread): Mention single symbols defined by
4626 `defvar' or `defconst' (bug#7154).
4627
61352f62 4628 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4629 (Frequire): Mention get-load-suffixes.
61352f62 4630
28545e04
MR
46312011-07-02 Martin Rudalics <rudalics@gmx.at>
4632
4633 * window.h (window): Remove clone_number slot.
4634 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4635 Remove.
4636 (make_parent_window, make_window, saved_window)
4637 (Fset_window_configuration, save_window_save): Don't deal with
4638 clone numbers.
4639 * buffer.c (Qclone_number): Remove declaration.
4640 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4641
3349e122
SM
46422011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4643
4644 Add multiple inheritance to keymaps.
4645 * keymap.c (Fmake_composed_keymap): New function.
4646 (Fset_keymap_parent): Simplify.
4647 (fix_submap_inheritance): Remove.
4648 (access_keymap_1): New function extracted from access_keymap to handle
4649 embedded parents and handle lists of maps.
4650 (access_keymap): Use it.
4651 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4652 (Fcopy_keymap): Handle embedded parents.
4653 (Fcommand_remapping, define_as_prefix): Simplify.
4654 (Fkey_binding): Simplify.
4655 (syms_of_keymap): Move minibuffer-local-completion-map,
4656 minibuffer-local-filename-completion-map,
4657 minibuffer-local-must-match-map, and
4658 minibuffer-local-filename-must-match-map to Elisp.
4659 (syms_of_keymap): Defsubr make-composed-keymap.
4660 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4661 (parse_menu_item): Trivial simplification.
4662
3279eb87
GM
46632011-07-01 Glenn Morris <rgm@gnu.org>
4664
4665 * Makefile.in (SETTINGS_LIBS): Fix typo.
4666
4550efdf
KI
46672011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4668
4669 * coding.c (Fencode_coding_string): Record the last coding system
4670 used, as the function doc string says (bug#8738).
4671
0949d2b6
JD
46722011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4673
4674 * xsettings.c (store_monospaced_changed): Take new font as arg and
4675 check for change against current_mono_font.
4676 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4677 (emacs_settings_constructor, emacs_settings_get_property)
4678 (emacs_settings_set_property, emacs_settings_class_init)
4679 (emacs_settings_init, gsettings_obj): Remove.
4680 (something_changedCB): New function for HAVE_GSETTINGS.
4681 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4682 with value as argument.
4683 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4684 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4685 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4686 "changed".
4687
4688 * xgselect.c: Add defined (HAVE_GSETTINGS).
4689 (xgselect_initialize): Ditto.
4690
4691 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4692 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4693 xg_select.
4694
bbc6b304
PE
46952011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4696
4697 * eval.c (struct backtrace): Simplify and port the data structure.
4698 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4699 signed bit field, as this assumption is not portable and it makes
4700 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4701 "char debug_on_exit : 1" as this is not portable either; instead,
4702 use the portable "unsigned int debug_on_exit : 1". Remove unused
4703 member evalargs. Remove obsolete comments about cc bombing out.
4704
9851bfc5
JD
47052011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4706
51bb811f 4707 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4708 Let HAVE_GSETTINGS override HAVE_GCONF.
4709 (store_monospaced_changed): New function.
4710 (EMACS_SETTINGS): A new type derived from GObject to handle
4711 GSettings notifications.
4712 (emacs_settings_constructor, emacs_settings_get_property)
4713 (emacs_settings_set_property, emacs_settings_class_init):
4714 New functions.
4715 (gsettings_client, gsettings_obj): New variables.
4716 (GSETTINGS_SCHEMA): New define.
4717 (something_changedCB): Call store_monospaced_changed.
4718 (init_gsettings): New function.
4719 (xsettings_initialize): Call init_gsettings.
4720 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4721 to NULL.
4722
640c8776 4723 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4724 GCONF_CFLAGS/LIBS.
4725
5386012d
MR
47262011-06-29 Martin Rudalics <rudalics@gmx.at>
4727
4728 * window.c (resize_root_window, grow_mini_window)
4729 (shrink_mini_window): Rename Qresize_root_window to
4730 Qwindow_resize_root_window and Qresize_root_window_vertically to
4731 Qwindow_resize_root_window_vertically.
4732
f13e0b08
PE
47332011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4734
4735 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4736
94515237
JB
47372011-06-27 Juanma Barranquero <lekktu@gmail.com>
4738
4739 * makefile.w32-in: Redesign dependencies so they reflect more
4740 clearly which files are directly included by each source file,
4741 and not through other includes.
4742
e43b6e43
MR
47432011-06-27 Martin Rudalics <rudalics@gmx.at>
4744
4745 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4746 (sort_overlays, overlay_strings): When an overlay's clone number
4747 matches the window's clone number process the overlay even if
4748 the overlay's window property doesn't match the current window.
4749
d68443dc
MR
4750 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4751 (Fwindow_hchild): Rename to Fwindow_left_child.
4752 (Fwindow_next): Rename to Fwindow_next_sibling.
4753 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4754 (resize_window_check): Rename to window_resize_check.
4755 (resize_window_apply): Rename to window_resize_apply.
4756 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4757 (Fdelete_other_windows_internal, resize_frame_windows)
4758 (Fsplit_window_internal, Fdelete_window_internal)
4759 (grow_mini_window, shrink_mini_window)
4760 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4761
c7e73be5
JD
47622011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4763
4764 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4765 (emacs_fixed_set_min_size): Remove.
4766 (emacs_fixed_new): Take frame as argument.
4767
4768 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4769 (_EmacsFixedPrivate): Remove minwidth/height.
4770 Add struct frame *f.
4771 (emacs_fixed_init): Initialize priv->f.
4772 (get_parent_class, emacs_fixed_set_min_size): Remove.
4773 (emacs_fixed_new): Set priv->f to argument.
4774 (emacs_fixed_get_preferred_width)
4775 (emacs_fixed_get_preferred_height): Use min_width/height from
4776 frames size_hint to set minimum and natural (Bug#8919).
4777 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4778 and use min_width/height from frames size_hint to set
4779 min_width/height (Bug#8919).
4780
4781 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4782 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4783 Fix indentation.
c7e73be5 4784
cf99dcf8
EZ
47852011-06-26 Eli Zaretskii <eliz@gnu.org>
4786
4787 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4788 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4789 called at ZV.
4790
029529ac
CY
47912011-06-26 Chong Yidong <cyd@stupidchicken.com>
4792
4793 * process.c (wait_reading_process_output): Bypass select if
4794 waiting for a cell while ignoring keyboard input, and input is
4795 pending. Suggested by Jan Djärv (Bug#8869).
4796
7a7ef429
PE
47972011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4798
4799 Use gnulib's dup2 module instead of rolling our own.
4800 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4801
11fdef7d 48022011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4803
4804 * dispnew.c (scrolling_window): Before scrolling, turn off a
4805 mouse-highlight in the window being scrolled.
4806
cd3520a4
JB
48072011-06-24 Juanma Barranquero <lekktu@gmail.com>
4808
4809 Move DEFSYM to lisp.h and use everywhere.
4810
4811 * character.h (DEFSYM): Move declaration...
4812 * lisp.h (DEFSYM): ...here.
4813
4814 * gnutls.c:
4815 * minibuf.c:
4816 * w32menu.c:
4817 * w32proc.c:
4818 * w32select.c: Don't include character.h.
4819
4820 * alloc.c (syms_of_alloc):
4821 * buffer.c (syms_of_buffer):
4822 * bytecode.c (syms_of_bytecode):
4823 * callint.c (syms_of_callint):
4824 * casefiddle.c (syms_of_casefiddle):
4825 * casetab.c (init_casetab_once):
4826 * category.c (init_category_once, syms_of_category):
4827 * ccl.c (syms_of_ccl):
4828 * cmds.c (syms_of_cmds):
4829 * composite.c (syms_of_composite):
4830 * dbusbind.c (syms_of_dbusbind):
4831 * dired.c (syms_of_dired):
4832 * dispnew.c (syms_of_display):
4833 * doc.c (syms_of_doc):
4834 * editfns.c (syms_of_editfns):
4835 * emacs.c (syms_of_emacs):
4836 * eval.c (syms_of_eval):
4837 * fileio.c (syms_of_fileio):
4838 * fns.c (syms_of_fns):
4839 * frame.c (syms_of_frame):
4840 * fringe.c (syms_of_fringe):
4841 * insdel.c (syms_of_insdel):
4842 * keymap.c (syms_of_keymap):
4843 * lread.c (init_obarray, syms_of_lread):
4844 * macros.c (syms_of_macros):
4845 * msdos.c (syms_of_msdos):
4846 * print.c (syms_of_print):
4847 * process.c (syms_of_process):
4848 * search.c (syms_of_search):
4849 * sound.c (syms_of_sound):
4850 * syntax.c (init_syntax_once, syms_of_syntax):
4851 * terminal.c (syms_of_terminal):
4852 * textprop.c (syms_of_textprop):
4853 * undo.c (syms_of_undo):
4854 * w32.c (globals_of_w32):
4855 * window.c (syms_of_window):
4856 * xdisp.c (syms_of_xdisp):
4857 * xfaces.c (syms_of_xfaces):
4858 * xfns.c (syms_of_xfns):
4859 * xmenu.c (syms_of_xmenu):
4860 * xsettings.c (syms_of_xsettings):
4861 * xterm.c (syms_of_xterm): Use DEFSYM.
4862
4228cf16
TZ
48632011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4864
cd3520a4 4865 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4866
7fcccf1e
PE
48672011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4868
7efb4e0e
PE
4869 Integer and buffer overflow fixes (Bug#8873).
4870
ff5844ad
PE
4871 * print.c (printchar, strout): Check for string overflow.
4872 (PRINTPREPARE, printchar, strout):
4873 Don't set size unless allocation succeeds.
4874
90532f02
PE
4875 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4876 for sizes. Check for string overflow more accurately.
4877 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4878
6d84508d
PE
4879 * macros.c: Integer and buffer overflow fixes.
4880 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4881 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4882 Use ptrdiff_t, not int, for sizes.
4883 Don't increment bufsize until after realloc succeeds.
4884 Check for size-calculation overflow.
4885 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4886
437b2cb4
PE
4887 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4888
8b9ac8b4
PE
4889 * lread.c: Integer overflow fixes.
4890 (read_integer): Radix is now EMACS_INT, not int,
4891 to improve quality of diagnostics for out-of-range radices.
4892 Calculate buffer size correctly for out-of-range radices.
4893 (read1): Check for integer overflow in radices, and in
4894 read-circle numbers.
82cb60d3
PE
4895 (read_escape): Avoid int overflow.
4896 (Fload, openp, read_buffer_size, read1)
4897 (substitute_object_recurse, read_vector, read_list, map_obarray):
4898 Use ptrdiff_t, not int, for sizes.
4899 (read1): Use EMACS_INT, not int, for sizes.
20270765 4900 Check for size overflow.
8b9ac8b4 4901
7fcccf1e
PE
4902 * image.c (cache_image): Check for size arithmetic overflow.
4903
bfbbd7e7
PE
4904 * lread.c: Integer overflow issues.
4905 (saved_doc_string_size, saved_doc_string_length)
4906 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4907 Now ptrdiff_t, not int.
4908 (read1): Don't assume doc string length fits in int. Check for
4909 out-of-range doc string lengths.
4910 (read_list): Don't assume file position fits in int.
39019e54 4911 (read_escape): Check for hex character overflow.
bfbbd7e7 4912
4e323265
LL
49132011-06-22 Leo Liu <sdl.web@gmail.com>
4914
4915 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4916 Move to minibuffer.el.
4917
85fece3e
PE
49182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4919
20b84ce9 4920 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4921 The following patches are for when GLYPH_DEBUG && !XASSERT.
4922 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4923 * dispnew.c (flush_stdout):
4924 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4925 Mark as externally visible.
4926 * dispnew.c (check_window_matrix_pointers): Now static.
4927 * dispnew.c (window_to_frame_vpos):
4928 * xfns.c (unwind_create_frame):
4929 * xterm.c (x_check_font): Remove unused local.
4930 * scroll.c (CHECK_BOUNDS):
4931 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4932 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4933 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4934 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4935 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4936 Now static.
4937 (debug_method_add): Use va_list and vsprintf rather than relying
4938 on undefined behavior with wrong number of arguments.
4939 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4940 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4941 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4942 since we're not interested in debugging glyphs with old libraries.
4943 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4944 GCC 4.6.0's static checking.
4945
0766b489
PE
49462011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4947
31fd4b32
PE
4948 Integer overflow and signedness fixes (Bug#8873).
4949 A few related buffer overrun fixes, too.
4950
b79e8648
PE
4951 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4952
0766b489
PE
4953 * dispextern.h (struct face.stipple):
4954 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4955 (x_bitmap_mask, x_allocate_bitmap_record)
4956 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4957 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4958 (x_create_bitmap_from_xpm_data):
4959 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4960 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4961 (.bitmaps_last):
4962 * xfaces.c (load_pixmap):
4963 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4964 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4965 (.bitmaps_last, struct x_output.icon_bitmap):
4966 Use ptrdiff_t, not int, for bitmap indexes.
4967 (x_allocate_bitmap_record): Check for size overflow.
4968 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4969
b081724f
PE
4970 Use ptrdiff_t, not int, for overlay counts.
4971 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4972 * editfns.c (overlays_around, get_pos_property):
4973 * textprop.c (get_char_property_and_overlay):
4974 * xdisp.c (next_overlay_change, note_mouse_highlight):
4975 * xfaces.c (face_at_buffer_position):
21514da7
PE
4976 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4977 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4978 (Fnext_overlay_change, Fprevious_overlay_change)
4979 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4980 Use ptrdiff_t, not int, for sizes.
21514da7 4981 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4982
3de73e5e
PE
4983 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4984
2606c57b
PE
4985 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4986 (x_session_initialize): Do not assume string length fits in int.
4987
aaafe47a
PE
4988 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4989 This is unlikely, but can occur if DPI is outlandish.
4990
2674ddc8 4991 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4992 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4993
28154962
PE
4994 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4995 * xrdb.c (magic_file_p, search_magic_path):
4996 Omit last arg SUFFIX; it was always 0. All callers changed.
4997 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4998
7de51af5
PE
4999 * xfont.c (xfont_match): Avoid need for strlen.
5000
25ed6cc3
PE
5001 * xfns.c: Don't assume strlen fits in int.
5002 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5003
4eab31dd
PE
5004 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5005 not unsigned long, as we prefer signed integers. All callers changed.
5006 Detect integer overflow in repeat count.
5007 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5008 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5009
171e2a58
PE
5010 * termcap.c: Don't assume sizes fit in int and never overflow.
5011 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5012 (gobble_line): Check for size-calculation overflow.
5013
ad39faca 5014 * minibuf.c (Fread_buffer):
6e5bb2dc 5015 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5016 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5017 Don't assume string length fits in int.
5018
52c61c22 5019 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5020 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5021
b5b8c9e5
PE
5022 * font.c: Don't assume string length fits in int.
5023 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5024 Use ptrdiff_t, not int.
ccd6111c
PE
5025 (font_intern_prop): Don't assume string length fits in int.
5026 Don't assume integer property fits in fixnum.
5027 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5028
882f0d81 5029 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5030 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5031 Reformulate so as not to need the command string.
5032 Invoke gzip -cd rather than gunzip, as it's more portable.
5033 (lock_info_type, lock_file_1, lock_file):
5034 Don't assume pid_t and time_t fit in unsigned long.
5035 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5036 (current_lock_owner): Prefer signed type for sizes.
5037 Use memcpy, not strncpy, where memcpy is what is really wanted.
5038 Don't assume (via atoi) that time_t and pid_t fit in int.
5039 Check for time_t and/or pid_t out of range, e.g., via a network share.
5040 Don't alloca where an auto var works fine.
5041
93f4cf88
PE
5042 * fileio.c: Fix some integer overflow issues.
5043 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5044 Don't assume string length fits in int.
5045 (directory_file_name): Don't assume string length fits in long.
5046 (make_temp_name): Don't assume pid fits in int, or that its print
5047 length is less than 20.
5048
f3e92b69
PE
5049 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5050
1bfdaf10
PE
5051 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5052
35016e9a
PE
5053 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5054
3d1e65a1
PE
5055 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5056 We prefer signed integers, even for size calculations.
5057
0b963a93
PE
5058 * emacs.c: Don't assume string length fits in 'int'.
5059 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5060 (main): Don't invoke strlen when not needed.
5061
573f4b54
PE
5062 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5063 (XD_DEBUG_MESSAGE): Don't waste a byte.
5064
989f33ba
PE
5065 * callproc.c (getenv_internal_1, getenv_internal)
5066 (Fgetenv_internal):
965d34eb
PE
5067 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5068
e4d29b33
PE
5069 * lread.c (invalid_syntax): Omit length argument.
5070 All uses changed. This doesn't fix a bug, but it simplifies the
5071 code away from its former Hollerith-constant appearance, and it's
5072 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5073 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5074
eb49b136
PE
5075 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5076 This didn't break anything, but it didn't help either.
5077 It's confusing to put a bogus integer in a place where the actual
5078 value does not matter.
9f62aeb1 5079 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5080 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5081
15375a22
PE
5082 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5083 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5084 implementation.
b61cc01c
PE
5085 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5086 We prefer signed types, and the value cannot exceed the EMACS_INT
5087 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5088 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5089 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5090 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5091
53b2623d
PE
5092 * indent.c (sane_tab_width): New function.
5093 (current_column, scan_for_column, Findent_to, position_indentation)
5094 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5095 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5096
51cab52b 5097 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5098
f2ed8a70
PE
5099 * lisp.h (lint_assume): New macro.
5100 * composite.c (composition_gstring_put_cache):
5101 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5102
abe80cc6
PE
5103 * editfns.c, insdel.c:
5104 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5105
b02c740e
PE
5106 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5107
ebc96716
PE
5108 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5109
b4e50fa0 5110 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5111 Use much-faster test for byte-length change.
311d5d7c 5112 Don't assume string byte-length fits in 'int'.
a4cf38e4 5113 Check that character arg fits in 'int'.
85461888 5114 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5115
c0c1ee9f
PE
5116 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5117
a498d7f4
PE
5118 * fns.c (concat): Catch string overflow earlier.
5119 Do not rely on integer wraparound.
5120
51cab52b
PE
5121 * dispextern.h (struct it.overlay_strings_charpos)
5122 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5123 * xdisp.c (forward_to_next_line_start)
5124 (back_to_previous_visible_line_start)
5125 (reseat_at_next_visible_line_start, next_element_from_buffer):
5126 Don't arbitrarily truncate the value of 'selective' to int.
5127
76031fad
PE
5128 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5129
5eb55db9
PE
5130 * composite.c: Don't truncate sizes to 'int'.
5131 (composition_gstring_p, composition_reseat_it)
5132 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5133 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5134 not EMACS_UINT, for indexes.
5eb55db9 5135
0703a717
PE
5136 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5137
d6202519
PE
5138 * buffer.c: Include <verify.h>.
5139 (struct sortvec.priority, struct sortstr.priority):
8961a454 5140 Now EMACS_INT, not int.
c20998a7 5141 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5142 (struct sortstr.size, record_overlay_string)
5143 (struct sortstrlist.size, struct sortlist.used):
5144 Don't truncate size to int.
5145 (record_overlay_string): Check for size-calculation overflow.
d6202519 5146 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5147
d5a19415
JM
51482011-06-22 Jim Meyering <meyering@redhat.com>
5149
029529ac 5150 Don't leak an XBM-image-sized buffer
d5a19415
JM
5151 * image.c (xbm_load): Free the image buffer after using it.
5152
a9041e6c
PE
51532011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5154
5155 Port to Sun C.
5156 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5157 that Sun C diagnosed.
5158 * fns.c (secure_hash): Fix pointer signedness issue.
5159 * intervals.c (static_offset_intervals): New function.
5160 (offset_intervals): Use it.
5161
7f3f739f
LL
51622011-06-21 Leo Liu <sdl.web@gmail.com>
5163
5164 * deps.mk (fns.o):
5165 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5166 sha512.h.
5167
5168 * fns.c (secure_hash): Rename from crypto_hash_function and change
5169 the first arg to accept symbols.
5b66d427 5170 (Fsecure_hash): New primitive.
7f3f739f
LL
5171 (syms_of_fns): New symbols.
5172
76147d94
DD
51732011-06-20 Deniz Dogan <deniz@dogan.se>
5174
5175 * process.c (Fset_process_buffer): Clarify return value in
5176 docstring.
5177
7d7d0045
CY
51782011-06-18 Chong Yidong <cyd@stupidchicken.com>
5179
5180 * dispnew.c (add_window_display_history): Use BVAR.
5181
5182 * xdisp.c (debug_method_add): Use BVAR.
5183 (check_window_end, dump_glyph_matrix, dump_glyph)
5184 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5185
5186 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5187 Likewise.
5188
5189 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5190 check till after the cache is created in init_frame_faces.
5191
ff2bc410
SM
51922011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5193
5194 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5195
28177add
PE
51962011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5197
dd3482fe
PE
5198 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5199 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5200 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5201
393d71f3 5202 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5203 * fileio.c (Finsert_file_contents):
5204 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5205 Remove the old (too-loose) buffer overflow checks.
5206 They weren't needed, since make_gap checks for buffer overflow.
5207 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5208 The old code merely checked for Emacs fixnum overflow, and relied
5209 on undefined (wraparound) behavior. The new code avoids undefined
5210 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5211
2e6813b0 5212 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5213 Tune. Don't use wider integers than needed. Don't use alloca.
5214 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5215
599a9e4f
PE
5216 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5217
99561444
PE
5218 * insdel.c, lisp.h (buffer_overflow): New function.
5219 (insert_from_buffer_1, replace_range, replace_range_2):
5220 * insdel.c (make_gap_larger):
5221 * editfns.c (Finsert_char):
5222 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5223
28177add
PE
5224 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5225
e69dafad
PE
52262011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5227
4baa020d 5228 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5229
b1c46f02
PE
5230 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5231 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5232
e69dafad
PE
5233 * fileio.c: Don't assume EMACS_INT fits in off_t.
5234 (emacs_lseek): New static function.
5235 (Finsert_file_contents, Fwrite_region): Use it.
5236 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5237
566684ea
PE
5238 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5239
e6966cd6
PE
5240 * fns.c: Don't overflow int when computing a list length.
5241 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5242 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5243 truncation on 64-bit hosts. Check for QUIT every
5244 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5245 faster and is responsive enough.
5246 (Flength): Report an error instead of overflowing an integer.
5247 (Fsafe_length): Return a float if the value is not representable
5248 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5249 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5250 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5251
dd0b0efb
PE
5252 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5253 (header_size, word_size): New constants.
5254 (allocate_vectorlike): Don't check size overflow here.
5255 (allocate_vector): Check it here instead, since this is the only
5256 caller of allocate_vectorlike that could cause overflow.
5257 Check that the new vector's length is representable as a fixnum.
5258
86fe5cfe
PE
5259 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5260 The previous code was bogus. For example, next_almost_prime (32)
5261 returned 39, which is undesirable as it is a multiple of 3; and
5262 next_almost_prime (24) returned 25, which is a multiple of 5 so
5263 why was the code bothering to check for multiples of 7?
5264
80e88859
PE
5265 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5266
4a2f0ad6
PE
5267 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5268
f66c7cf8
PE
5269 Variadic C functions now count arguments with ptrdiff_t.
5270 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5271 Back then I didn't know that the Emacs coding style prefers signed int.
5272 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5273 were being counted with int, which may truncate counts on 64-bit
5274 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5275 * lisp.h (struct Lisp_Subr.function.aMANY)
5276 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5277 Arg counts are now ptrdiff_t, not size_t.
5278 All variadic functions and their callers changed accordingly.
5279 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5280 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5281 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5282 * callint.c (Fcall_interactively): Check arg count for overflow,
5283 to avoid potential buffer overrun. Use signed char, not 'int',
5284 for 'varies' array, so that we needn't bother to check its size
5285 calculation for overflow.
5286 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5287 * eval.c (apply_lambda):
5288 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5289 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5290 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5291
a1759b76
PE
5292 * callint.c (Fcall_interactively): Don't use index var as event count.
5293
d96be9fc
PE
5294 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5295 * mem-limits.h (SIZE): Remove; no longer used.
5296
a690a978 5297 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5298
578c21e6
PE
5299 Remove unnecessary casts.
5300 * xterm.c (x_term_init):
5301 * xfns.c (x_set_border_pixel):
5302 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5303 These aren't needed now that we assume ANSI C.
5304
96f53c6c
PE
5305 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5306 It's more likely to cause problems (due to unsigned overflow)
5307 than to cure them.
5308
83c77d31
PE
5309 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5310
ee2079f1
PE
5311 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5312
6da65536
PE
5313 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5314
7147c4a4
PE
5315 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5316
193e32d9
PE
5317 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5318
e5533da6
PE
5319 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5320
9910e595
PE
5321 GLYPH_CODE_FACE returns EMACS_INT, not int.
5322 * dispextern.h (merge_faces):
5323 * xfaces.c (merge_faces):
01103c44
PE
5324 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5325 Don't assume EMACS_INT fits in int.
9910e595 5326
2638320e
PE
5327 * character.h (CHAR_VALID_P): Remove unused parameter.
5328 * fontset.c, lisp.h, xdisp.c: All uses changed.
5329
045eb8d9
PE
5330 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5331
c1f134b5
PE
5332 * fns.c (concat): Minor tuning based on overflow analysis.
5333 This doesn't fix any bugs. Use int to hold character, instead
5334 of constantly refetching from Emacs object. Use XFASTINT, not
5335 XINT, for value known to be a character. Don't bother comparing
5336 a single byte to 0400, as it's always less.
5337
395fcb93 5338 * floatfns.c (Fexpt):
327eeec8
PE
5339 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5340
abbd3d23
PE
5341 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5342 for characters.
5343
684a03ef
PE
5344 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5345
0fed43f3
PE
5346 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5347 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5348 incorrectly succeed when S was a string, because 4294967386 was
5349 truncated before it was used.
5350
8fd02eb7
PE
5351 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5352 Otherwise, an out-of-range integer could cause undefined behavior
5353 on a 64-bit host.
5354
f8c86b69
PE
5355 * composite.c: Use int, not EMACS_INT, for characters.
5356 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5357 EMACS_INT, for values that are known to be in character range.
5358 This doesn't fix any bugs but is the usual style inside Emacs and
5359 may generate better code on 32-bit machines.
5360
34206dd2
PE
5361 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5362 This is for reasons similar to the recent CHAR_STRING fix.
5363 * charset.c (Fencode_char): Check that character arg is actually
5364 a character. Pass an int to ENCODE_CHAR.
5365 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5366 wider than 'int', as a compile-time check to prevent future regressions
5367 in this area.
5368
c5958d4c 5369 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5370
5371 Make sure a 64-bit char is never passed to CHAR_STRING.
5372 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5373 by silently ignoring the top 32 bits, allowing some values
5374 that were far too large to be valid characters.
5375 * character.h: Include <verify.h>.
5376 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5377 arguments are no wider than unsigned, as a compile-time check
5378 to prevent future regressions in this area.
5379 * data.c (Faset):
01103c44 5380 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5381 (Fsubst_char_in_region):
5382 * fns.c (concat):
5383 * xdisp.c (decode_mode_spec_coding):
5384 Adjust to CHAR_STRING's new requirement.
5385 * editfns.c (Finsert_char, Fsubst_char_in_region):
5386 * fns.c (concat): Check that character args are actually
5387 characters. Without this test, these functions did the wrong
5388 thing with wildly out-of-range values on 64-bit hosts.
5389
d37ca623
PE
5390 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5391 These casts should not be needed on 32-bit hosts, either.
5392 * keyboard.c (read_char):
5393 * lread.c (Fload): Remove casts to unsigned.
5394
ea204efb
PE
5395 * lisp.h (UNSIGNED_CMP): New macro.
5396 This fixes comparison bugs on 64-bit hosts.
5397 (ASCII_CHAR_P): Use it.
5398 * casefiddle.c (casify_object):
01103c44 5399 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5400 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5401 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5402 * dispextern.h (FACE_FROM_ID):
5403 * keyboard.c (read_char): Use UNSIGNED_CMP.
5404
41cb286c
PE
5405 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5406 not to EMACS_INT, to avoid GCC warning.
5407
4a1b9832
PE
5408 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5409
55daad71
PE
5410 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5411 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5412 isn't needed on 32-bit machines.
8f95c75c 5413
01103c44
PE
5414 * buffer.c (Fgenerate_new_buffer_name):
5415 Use EMACS_INT for count, not int.
0ceccced 5416 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5417
5418 * data.c (Qcompiled_function): Now static.
5419
c6f072e7
PE
5420 * window.c (window_body_lines): Now static.
5421
20ce5912
PE
5422 * image.c (gif_load): Rename local to avoid shadowing.
5423
9c4c5f81
PE
5424 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5425 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5426 * alloc.c (make_save_value): Integer argument is now of type
5427 ptrdiff_t, not int.
5428 (mark_object): Use ptrdiff_t, not int.
5429 * lisp.h (pD): New macro.
5430 * print.c (print_object): Use it.
5431
c0c5c8ae
PE
5432 * alloc.c: Use EMACS_INT, not int, to count objects.
5433 (total_conses, total_markers, total_symbols, total_vector_size)
5434 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5435 (total_free_floats, total_floats, total_free_intervals)
5436 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5437 Now EMACS_INT, not int. All uses changed.
5438 (Fgarbage_collect): Compute overall total using a double, so that
5439 integer overflow is less likely to be a problem. Check for overflow
5440 when converting back to an integer.
5a25e253
PE
5441 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5442 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5443 These were 'int' variables that could overflow on 64-bit hosts;
5444 they were never used, so remove them instead of repairing them.
211a0b2a 5445 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5446 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5447 Previously, this ceilinged at INT_MAX, but that doesn't work on
5448 64-bit machines.
e46bb31a 5449 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5450
c78baabf 5451 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5452 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5453 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5454 when a (possibly-narrower) signed value would do just as well.
5455 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5456
c9d624c6
PE
5457 * alloc.c: Catch some string size overflows that we were missing.
5458 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5459 for convenience in STRING_BYTES_MAX.
5460 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5461 The definition here is exact; the one in lisp.h was approximate.
5462 (allocate_string_data): Check for string overflow. This catches
5463 some instances we weren't catching before. Also, it catches
5464 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5465 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5466 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5467
c9d624c6
PE
5468 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5469 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5470 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5471
353032ce
PE
5472 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5473
2bccce07
PE
5474 * alloc.c (Fmake_string): Check for out-of-range init.
5475
0ac30604
SM
54762011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5477
5478 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5479
c195f2de
JD
54802011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5481
5482 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5483 xg_get_default_scrollbar_width.
5484
5485 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5486 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5487 (style_changed_cb): Call update_theme_scrollbar_width and call
5488 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5489 all frames (Bug#8505).
5490 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5491 Call gtk_window_set_resizable if HAVE_GTK3.
5492 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5493 and height if HAVE_GTK3 (Bug#8505).
5494 (scroll_bar_width_for_theme): New variable.
5495 (update_theme_scrollbar_width): New function.
5496 (xg_get_default_scrollbar_width): Move code to
5497 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5498 (xg_initialize): Call update_theme_scrollbar_width.
5499
5500 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5501
5502 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5503
e10ac9f1
MR
55042011-06-12 Martin Rudalics <rudalics@gmx.at>
5505
5506 * frame.c (make_frame): Call other_buffer_safely instead of
5507 other_buffer.
5508
5509 * window.c (temp_output_buffer_show): Call display_buffer with
5510 second argument Vtemp_buffer_show_specifiers and reset latter
5511 immediately after the call.
5512 (Vtemp_buffer_show_specifiers): New variable.
5513 (auto_window_vscroll_p, next_screen_context_lines)
5514 (Vscroll_preserve_screen_position): Remove leading asterisks from
5515 doc-strings.
5516
2d3c217e 55172011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5518
7b7f97e8 5519 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5520 * buffer.c (Qclone_number): Remove for now, as it's unused.
5521 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5522 (record_buffer): Remove unused local.
5523 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5524 (set_frame_buffer_list): Remove; unused.
5525 * frame.h (other_visible_frames): Remove decl.
5526 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5527 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5528 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5529 if HAVE_GPM.
5530 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5531 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5532 Define only if HAVE_GPM.
5533 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5534 (update_hints_inhibit): Remove; never set. All uses removed.
5535 * widgetprv.h (emacsFrameClassRec): Remove decl.
5536 * window.c (delete_deletable_window): Now returns void, since it
5537 wasn't returning anything.
5538 (compare_window_configurations): Remove unused locals.
5539 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5540 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5541 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5542 the same widths as pointers. This follows up on the 2011-05-06 patch.
5543 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5544 * xterm.h: Likewise.
5545 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5546
1384b89e
JB
55472011-06-12 Juanma Barranquero <lekktu@gmail.com>
5548
5549 * makefile.w32-in: Update dependencies.
5550 (LISP_H): Add lib/intprops.h.
5551
1100a63c
CY
55522011-06-11 Chong Yidong <cyd@stupidchicken.com>
5553
5554 * image.c (gif_load): Add animation frame delay to the metadata.
5555 (syms_of_image): Use DEFSYM. New symbol `delay'.
5556
6198ccd0
MR
55572011-06-11 Martin Rudalics <rudalics@gmx.at>
5558
5559 * window.c (delete_deletable_window): Re-add.
5560 (Fset_window_configuration): Rewrite to handle dead buffers and
5561 consequently deletable windows.
5562 (window_tree, Fwindow_tree): Remove. Supply functionality in
5563 window.el.
5564 (compare_window_configurations): Simplify code.
5565
b6e3633c
AS
55662011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5567
1ab0dee5
AS
5568 * image.c (imagemagick_load_image): Fix type mismatch.
5569 (Fimagemagick_types): Likewise.
5570
b6e3633c
AS
5571 * window.h (replace_buffer_in_windows): Declare.
5572
9397e56f
MR
55732011-06-11 Martin Rudalics <rudalics@gmx.at>
5574
5575 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5576 Qclone_number. Remove external declaration of Qdelete_window.
5577 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5578 code.
640c8776
SM
5579 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5580 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5581 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5582 buffer list implementation.
5583 (other_buffer_safely): New function.
5584 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5585 calls to replace_buffer_in_windows and
5586 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5587 if allowed.
5588 (record_buffer): Inhibit quitting and rewrite using quittable
5589 functions. Run Qbuffer_list_update_hook if allowed.
5590 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5591 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5592 Move switch-to-buffer to window.el.
9397e56f
MR
5593 (bury-buffer): Move to window.el.
5594 (Vbuffer_list_update_hook): New variable.
5595
5596 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5597 section.
5598
5599 * window.h (resize_frame_windows): Move up in code.
5600 (Fwindow_frame): Remove EXFUN.
5601 (replace_buffer_in_all_windows): Remove prototype.
5602 (replace_buffer_in_windows_safely): Add prototype.
5603
5604 * window.c: Declare Qdelete_window static again. Move down
5605 declaration of select_count.
5606 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5607 (Fother_window): Move to window.el.
5608 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5609 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5610 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5611 window.el.
5612 (replace_buffer_in_windows): Implement by calling
5613 Qreplace_buffer_in_windows.
5614 (replace_buffer_in_all_windows): Remove with some functionality
5615 moved into replace_buffer_in_windows_safely.
5616 (replace_buffer_in_windows_safely): New function.
5617 (select_window_norecord, select_frame_norecord): Move in front
5618 of run_window_configuration_change_hook. Remove now obsolete
5619 declarations.
640c8776
SM
5620 (Fset_window_buffer): Rewrite doc-string.
5621 Call Qrecord_window_buffer.
9397e56f
MR
5622 (keys_of_window): Move binding for other-window to window.el.
5623
b50691aa
CY
56242011-06-11 Chong Yidong <cyd@stupidchicken.com>
5625
5626 * dispextern.h (struct image): Replace data member, whose int_val
5627 and ptr_val fields were not used by anything, with a single
5628 lisp_val object.
5629
5630 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5631 (gif_clear_image, gif_load, imagemagick_load_image)
5632 (gs_clear_image, gs_load): Callers changed.
5633
3f754b86
PE
56342011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5635
cca69397
PE
5636 * buffer.h: Include <time.h>, for time_t.
5637 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5638
109e28d0
PE
5639 Fix minor problems found by static checking.
5640
60737f02
PE
5641 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5642
4b66faf3
PE
5643 Make identifiers static if they are not used in other modules.
5644 * data.c (Qcompiled_function, Qframe, Qvector):
5645 * image.c (QimageMagick, Qsvg):
5646 * minibuf.c (Qmetadata):
5647 * window.c (resize_window_check, resize_root_window): Now static.
5648 * window.h (resize_window_check, resize_root_window): Remove decls.
5649
109e28d0
PE
5650 * window.c (window_deletion_count, delete_deletable_window):
5651 Remove; unused.
46a4ce9e
PE
5652 (window_body_lines): Now static.
5653 (Fdelete_other_windows_internal): Mark vars as initialized.
5654 Make sure 'resize_failed' is initialized.
5655 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5656 (resize_window_apply): Remove unused local.
5657 * window.h (delete_deletable_window): Remove decl.
5658
109e28d0 5659 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5660 (imagemagick_load_image): Fix pointer signedness problem by changing
5661 last arg from unsigned char * to char *. All uses changed.
5662 Also, fix a local for similar reasons.
5663 Remove unused locals. Remove locals to avoid shadowing.
5664 (fn_rsvg_handle_free): Remove; unused.
5665 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5666 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5667
3f754b86
PE
5668 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5669
2547adb1
CY
56702011-06-10 Chong Yidong <cyd@stupidchicken.com>
5671
5672 * image.c (gif_load): Fix omitted cast error introduced by
5673 2011-06-06 change.
5674
2c8e37d4
MR
56752011-06-10 Martin Rudalics <rudalics@gmx.at>
5676
5677 * window.h (resize_proportionally, orig_total_lines)
5678 (orig_top_line): Remove from window structure.
5679 (set_window_height, set_window_width, change_window_heights)
5680 (Fdelete_window): Remove prototypes.
5681 (resize_frame_windows): Remove duplicate declaration.
5682
440a42e3
EZ
56832011-06-10 Eli Zaretskii <eliz@gnu.org>
5684
5685 * window.h (resize_frame_windows, resize_window_check)
5686 (delete_deletable_window, resize_root_window)
5687 (resize_frame_windows): Declare prototypes.
5688
5689 * window.c (resize_window_apply): Make definition be "static" to
5690 match the prototype.
5691
562dd5e9
MR
56922011-06-10 Martin Rudalics <rudalics@gmx.at>
5693
5694 * window.c: Remove declarations of Qwindow_size_fixed,
5695 window_min_size_1, window_min_size_2, window_min_size,
5696 size_window, window_fixed_size_p, enlarge_window, delete_window.
5697 Remove static from declaration of Qdelete_window, it's
5698 temporarily needed by Fbury_buffer.
5699 (replace_window): Don't assign orig_top_line and
5700 orig_total_lines.
5701 (Fdelete_window, delete_window): Remove. Window deletion is
5702 handled by window.el.
640c8776
SM
5703 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5704 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5705 (Fdelete_other_windows): Remove. Deleting other windows is
5706 handled by window.el.
5707 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5708 handled in window.el.
5709 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5710 Window minimum sizes are handled in window.el.
5711 (shrink_windows, size_window, set_window_height)
5712 (set_window_width, change_window_heights, window_height)
5713 (window_width, CURBEG, CURSIZE, enlarge_window)
5714 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5715 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5716 handled in window.el.
5717 (make_dummy_parent): Rename to make_parent_window and give it a
5718 second argument horflag.
5719 (make_window): Don't set resize_proportionally any more.
5720 (Fsplit_window): Remove. Windows are split in window.el.
5721 (save_restore_action, save_restore_orig_size)
5722 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5723 Resize mini windows in window.el.
5724 (grow_mini_window, shrink_mini_window): Implement by calling
5725 Qresize_root_window_vertically, resize_window_check and
5726 resize_window_apply.
640c8776
SM
5727 (saved_window, Fset_window_configuration, save_window_save):
5728 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5729 resize_proportionally.
5730 (window_min_height, window_min_width): Move to window.el.
5731 (keys_of_window): Move bindings for delete-other-windows,
5732 split-window, delete-window and enlarge-window to window.el.
5733
5734 * buffer.c: Temporarily extern Qdelete_window.
5735 (Fbury_buffer): Temporarily call Qdelete_window instead of
5736 Fdelete_window (Fbury_buffer will move to window.el soon).
5737
5738 * frame.c (set_menu_bar_lines_1): Remove code handling
5739 orig_top_line and orig_total_lines.
5740
5741 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5742 set_window_height but set heights directly.
5743 (change_frame_size_1): Use resize_frame_windows.
5744
5745 * xdisp.c (init_xdisp): Don't use set_window_height but set
5746 heights directly.
5747
640c8776
SM
5748 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5749 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5750 run_window_configuration_change_hook.
5751
5752 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5753 instead of change_window_heights and run
5754 run_window_configuration_change_hook.
5755
1a13852e
MR
57562011-06-09 Martin Rudalics <rudalics@gmx.at>
5757
5758 * window.c (replace_window): Rename second argument REPLACEMENT to
5759 NEW. New third argument SETFLAG. Rewrite.
5760 (delete_window, make_dummy_parent): Call replace_window with
5761 third argument 1.
5762 (window_list_1): Move down in code.
5763 (run_window_configuration_change_hook): Move set_buffer part
5764 before select_frame_norecord part in order to unwind correctly.
5765 Rename count1 to count.
5766 (recombine_windows, delete_deletable_window, resize_root_window)
5767 (Fdelete_other_windows_internal)
5768 (Frun_window_configuration_change_hook, make_parent_window)
5769 (resize_window_check, resize_window_apply, Fresize_window_apply)
5770 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5771 (Fdelete_window_internal, Fresize_mini_window_internal):
5772 New functions.
1a13852e
MR
5773 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5774
f3d1777e
MR
57752011-06-08 Martin Rudalics <rudalics@gmx.at>
5776
496e208e
MR
5777 * window.h (window): Add some new members to window structure -
5778 normal_lines, normal_cols, new_total, new_normal, clone_number,
5779 splits, nest, prev_buffers, next_buffers.
5780 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5781 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5782
f3d1777e
MR
5783 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5784 Remove.
496e208e
MR
5785 (make_dummy_parent): Set new members of windows structure.
5786 (make_window): Move down in code. Handle new members of window
5787 structure.
5788 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5789 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5790 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5791 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5792 (Fset_window_next_buffers, Fset_window_clone_number):
5793 New functions.
496e208e
MR
5794 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5795 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5796 Doc-string fixes.
5797 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5798 Argument WINDOW can be now internal window too.
5799 (Fwindow_use_time): Move up in code.
5800 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5801 Rewrite doc-string.
5802 (Fset_window_configuration, saved_window)
5803 (Fcurrent_window_configuration, save_window_save): Handle new
5804 members of window structure.
b9e809c2
MR
5805 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5806 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5807 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5808 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5809 Qget_mru_window, Qresize_root_window,
5810 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5811 Qauto_buffer_name; staticpro them.
f3d1777e 5812
abde8f8c
MR
58132011-06-07 Martin Rudalics <rudalics@gmx.at>
5814
5815 * window.c (Fwindow_total_size, Fwindow_left_column)
5816 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5817 (Fwindow_list_1): New functions.
5818 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5819 (Fwindow_width, Fscroll_left, Fscroll_right):
5820 Use window_body_cols instead of window_box_text_cols.
5821 (delete_window, Fset_window_configuration):
5822 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5823 (delete_all_subwindows): Take a window as argument and not a
5824 structure. Rewrite.
190b47e6
MR
5825 (window_loop): Remove handling of GET_LRU_WINDOW and
5826 GET_LARGEST_WINDOW.
5827 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5828
5829 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5830 window_box_text_cols. delete_all_subwindows now takes a
5831 Lisp_Object as argument.
abde8f8c 5832
640c8776
SM
5833 * indent.c (compute_motion, Fcompute_motion):
5834 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5835
fa8a67e6
MR
5836 * frame.c (delete_frame): Call delete_all_subwindows with root
5837 window as argument.
5838
a54e3482
DC
58392011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5840
5841 * fns.c (Fputhash): Document return value.
5842
60002bf5
CY
58432011-06-06 Chong Yidong <cyd@stupidchicken.com>
5844
5845 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5846
0c671da6 58472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5848
b862a52a 5849 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5850
be44ca6c
PE
5851 Check for overflow when converting integer to cons and back.
5852 * charset.c (Fdefine_charset_internal, Fdecode_char):
5853 Use cons_to_unsigned to catch overflow.
5854 (Fencode_char): Use INTEGER_TO_CONS.
5855 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5856 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5857 * data.c (long_to_cons, cons_to_long): Remove.
5858 (cons_to_unsigned, cons_to_signed): New functions.
5859 These signal an error for invalid or out-of-range values.
5860 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5861 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5862 * font.c (Ffont_variation_glyphs):
5863 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5864 * lisp.h: Include <intprops.h>.
5865 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5866 (cons_to_signed, cons_to_unsigned): New decls.
5867 (long_to_cons, cons_to_long): Remove decls.
5868 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5869 (Fprimitive_undo): Use CONS_TO_INTEGER.
5870 * xfns.c (Fx_window_property): Likewise.
5871 * xselect.c: Include <limits.h>.
5872 (x_own_selection, selection_data_to_lisp_data):
5873 Use INTEGER_TO_CONS.
5874 (x_handle_selection_request, x_handle_selection_clear)
5875 (x_get_foreign_selection, Fx_disown_selection_internal)
5876 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5877 (lisp_data_to_selection_data): Use cons_to_unsigned.
5878 (x_fill_property_data): Use cons_to_signed.
5879 Report values out of range.
5880
d1f3d2af
PE
5881 Check for buffer and string overflow more precisely.
5882 * buffer.h (BUF_BYTES_MAX): New macro.
5883 * lisp.h (STRING_BYTES_MAX): New macro.
5884 * alloc.c (Fmake_string):
5885 * character.c (string_escape_byte8):
5886 * coding.c (coding_alloc_by_realloc):
5887 * doprnt.c (doprnt):
5888 * editfns.c (Fformat):
5889 * eval.c (verror):
5890 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5891 since they may not be the same number.
5892 * editfns.c (Finsert_char):
5893 * fileio.c (Finsert_file_contents):
5894 Likewise for BUF_BYTES_MAX.
5895
dd52fcea
PE
5896 * image.c: Use ptrdiff_t, not int, for sizes.
5897 (slurp_file): Switch from int to ptrdiff_t.
5898 All uses changed.
5899 (slurp_file): Check that file size fits in both size_t (for
5900 malloc) and ptrdiff_t (for sanity and safety).
5901
7f9bbdbb
PE
5902 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5903 if b->modtime has its maximal value.
5904
dfe18f82
PE
5905 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5906
84acfcf0
PE
5907 Don't assume time_t can fit into int.
5908 * buffer.h (struct buffer.modtime): Now time_t, not int.
5909 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5910 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5911
ccd9a01a
PE
5912 Minor fixes for signed vs unsigned integers.
5913 * character.h (MAYBE_UNIFY_CHAR):
5914 * charset.c (maybe_unify_char):
5915 * keyboard.c (read_char, reorder_modifiers):
5916 XINT -> XFASTINT, since the integer must be nonnegative.
5917 * ftfont.c (ftfont_spec_pattern):
5918 * keymap.c (access_keymap, silly_event_symbol_error):
5919 XUINT -> XFASTINT, since the integer must be nonnegative.
5920 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5921 since it makes no difference and we prefer signed.
5922 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5923 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5924 nonnegative.
5925
d6d100dd
SM
59262011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5927
5928 * window.h (Fwindow_frame): Declare.
5929
2b6148e4
PE
59302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5933 (SPARE_MEMORY): Always define.
5934 (LARGE_REQUEST): Remove.
5935 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5936
f230ecc9
MR
59372011-06-06 Martin Rudalics <rudalics@gmx.at>
5938
727e958e
MR
5939 * lisp.h: Move EXFUNS for Fframe_root_window,
5940 Fframe_first_window and Fset_frame_selected_window to window.h.
5941
5942 * window.h: Move EXFUNS for Fframe_root_window,
5943 Fframe_first_window and Fset_frame_selected_window here from
5944 lisp.h.
5945
5946 * frame.c (Fwindow_frame, Fframe_first_window)
5947 (Fframe_root_window, Fframe_selected_window)
5948 (Fset_frame_selected_window): Move to window.c.
5949 (Factive_minibuffer_window): Move to minibuf.c.
5950 (Fother_visible_frames_p): New function.
5951
5952 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5953
f230ecc9
MR
5954 * window.c (decode_window, decode_any_window): Move up in code.
5955 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5956 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5957 (Fwindow_buffer): Move up and rewrite doc-string.
5958 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5959 (Fwindow_prev): New functions.
727e958e
MR
5960 (Fwindow_frame): Move here from frame.c. Accept any window as
5961 argument.
5962 (Fframe_root_window, Fframe_first_window)
5963 (Fframe_selected_window): Move here from frame.c. Accept frame
5964 or arbitrary window as argument. Update doc-strings.
5965 (Fminibuffer_window): Move up in code.
5966 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5967 (Fset_frame_selected_window): Move here from frame.c.
5968 Marginal rewrite.
727e958e
MR
5969 (Fselected_window, select_window, Fselect_window): Move up in
5970 code. Minor doc-string fixes.
f230ecc9 5971
4d09bcf6
PE
59722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5973
5974 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5975 Do not assume that spare memory exists; that assumption is valid
5976 only if SYSTEM_MALLOC.
5977 (LARGE_REQUEST): New macro, so that the issue of large requests
5978 is separated from the issue of spare memory.
5979
810928a2
AS
59802011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5981
172418ad
AS
5982 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5983 format. (Bug#8806)
5984
43f862f7
AS
5985 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5986
810928a2
AS
5987 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5988 before statements.
5989
a059fe24
JD
59902011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5991
5992 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5993
5994 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5995
5996 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5997 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5998
989bf368
JB
59992011-06-05 Juanma Barranquero <lekktu@gmail.com>
6000
6001 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6002
4b80f674
CY
60032011-06-04 Chong Yidong <cyd@stupidchicken.com>
6004
6005 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6006 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6007 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6008 New error handlers.
4b80f674
CY
6009 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6010 Obey Vx_select_enable_clipboard_manager. Catch errors in
6011 x_clipboard_manager_save (Bug#8779).
6012 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6013 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6014
99a33b77 60152011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6016
6017 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6018
99a33b77 60192011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6020
6021 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6022 in the current matrix if keep_current_p is non-zero.
6023
8264569d
EZ
60242011-06-04 Eli Zaretskii <eliz@gnu.org>
6025
6026 * bidi.c (bidi_level_of_next_char): Fix last change.
6027
57f97249
EZ
60282011-06-03 Eli Zaretskii <eliz@gnu.org>
6029
fec2107c 6030 Support bidi reordering of text covered by display properties.
57f97249 6031
fec2107c
EZ
6032 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6033 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6034 (bidi_cache_search, bidi_cache_iterator_state)
6035 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6036 (bidi_level_of_next_char, bidi_move_to_visually_next):
6037 Support character positions inside a run of characters covered by a
fec2107c
EZ
6038 display string.
6039 (bidi_paragraph_init, bidi_resolve_explicit_1)
6040 (bidi_level_of_next_char): Call bidi_fetch_char and
6041 bidi_fetch_char_advance instead of FETCH_CHAR and
6042 FETCH_CHAR_ADVANCE.
6043 (bidi_init_it): Initialize new members.
6044 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6045 definitions.
6046 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6047 instead of using explicit *_CHAR codes.
d6d100dd
SM
6048 (bidi_resolve_explicit, bidi_resolve_weak):
6049 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6050 bidirectional text is supported only in multibyte buffers.
6051 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6052 it to initialize the frame_window_p member of struct bidi_it.
6053 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6054 (bidi_resolve_explicit, bidi_resolve_weak)
6055 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6056 bidi_it->nchars is non-positive.
6057 (bidi_level_of_next_char): Don't try to lookup the cache for the
6058 next/previous character if nothing is cached there yet, or if we
6059 were just reseat()'ed to a new position.
c40e2fb2 6060
0e14fe90
EZ
6061 * xdisp.c (set_cursor_from_row): Set start and stop points
6062 according to the row's direction when priming the loop that looks
6063 for the glyph on which to display cursor.
6064 (single_display_spec_intangible_p): Function deleted.
6065 (display_prop_intangible_p): Reimplement to call
6066 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6067 Accept 3 additional arguments needed by handle_display_spec.
6068 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6069 values: lists, `(when COND...)' forms, etc.
6070 (single_display_spec_string_p): Support property values that are
6071 lists with the argument STRING its top-level element.
6072 (display_prop_string_p): Fix the condition for processing a
6073 property that is a list to be consistent with handle_display_spec.
fec2107c 6074 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6075 last portion of handle_display_prop.
6076 (compute_display_string_pos): Accept additional argument
6077 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6078 value of a `display' property is a "replacing spec".
6079 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6080 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6081 the display property, but just return a value indicating whether
6082 the display property will replace the characters it covers.
6083 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6084 frame_window_p members of struct bidi_it.
d6d100dd
SM
6085 (compute_display_string_pos, compute_display_string_end):
6086 New functions.
fec2107c
EZ
6087 (push_it): Accept second argument POSITION, where pop_it should
6088 jump to continue iteration.
6089 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6090
fec2107c
EZ
6091 * keyboard.c (adjust_point_for_property): Adjust the call to
6092 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6093
6094 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6095 (bidi_init_it): Update prototypes.
6096 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6097 (compute_display_string_pos, compute_display_string_end):
6098 Declare prototypes.
fec2107c
EZ
6099 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6100 EMACS_INT.
fc6f18ce 6101
40087514 61022011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6103
57f53182
PE
6104 Malloc failure behavior now depends on size of allocation.
6105 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6106 * lisp.h: Change signatures accordingly.
6107 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6108 All callers changed. (Bug#8762)
6109
6110 * gnutls.c: Use Emacs's memory allocators.
6111 Without this change, the gnutls library would invoke malloc etc.
6112 directly, which causes problems on non-SYNC_INPUT hosts, and which
6113 runs afoul of improving memory_full behavior. (Bug#8761)
6114 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6115 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6116 xfree instead of the default malloc, realloc, free.
6117 (Fgnutls_boot): No need to check for memory allocation failure,
6118 since xmalloc does that for us.
6119
ac32cd99 6120 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6121 * category.c (hash_get_category_set):
6122 * ccl.c (ccl_driver):
6123 * charset.c (Fdefine_charset_internal):
6124 * charset.h (struct charset.hash_index):
6125 * composite.c (get_composition_id, gstring_lookup_cache)
6126 (composition_gstring_put_cache):
6127 * composite.h (struct composition.hash_index):
6128 * dispextern.h (struct image.hash):
6129 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6130 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6131 (hashfn_equal, hashfn_user_defined, make_hash_table)
6132 (maybe_resize_hash_table, hash_lookup, hash_put)
6133 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6134 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6135 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6136 * image.c (make_image, search_image_cache, lookup_image)
6137 (xpm_put_color_table_h):
6138 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6139 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6140 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6141 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6142 * alloc.c (allocate_vectorlike):
6143 Check for overflow in vector size calculations.
6144 * ccl.c (ccl_driver):
6145 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6146 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6147 need to be updated by these changes.
40087514
PE
6148 * fns.c (make_hash_table, maybe_resize_hash_table):
6149 Check for integer overflow with large hash tables.
0de4bb68
PE
6150 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6151 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6152 (SXHASH_REDUCE): New macro.
6153 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6154 Use it instead of discarding useful hash info with large hash values.
6155 (sxhash_float): New function.
6156 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6157 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6158 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6159 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6160 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6161 Adjust signatures to match updated version of code.
6162 (consing_since_gc): Now EMACS_INT, since a single hash table can
6163 use more than INT_MAX bytes.
6164
698d32e2
DN
61652011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6166
6167 Make it possible to build with GCC-4.6+ -O2 -flto.
6168
6169 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6170
fd6fa53f
SM
61712011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6172
6173 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6174 Call minibuffer-inactive-mode.
6175
864db017
JB
61762011-05-31 Juanma Barranquero <lekktu@gmail.com>
6177
6178 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6179 Update dependencies.
6180
2ad0baf4
DN
61812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6182
6183 * data.c (init_data): Remove code for UTS, this system is not
6184 supported anymore.
6185
4fcc2638
DN
61862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6187
6188 Don't force ./temacs to start in terminal mode.
6189
6190 * frame.c (make_initial_frame): Initialize faces in all cases, not
6191 only when CANNOT_DUMP is defined.
6192 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6193
c56e0fd5
DN
61942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6195
6196 * dispnew.c (add_window_display_history): Use const for the string
6197 pointer. Remove declaration, not needed.
6198
333d54da 61992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6200
55d4c1b2 6201 Use 'inline', not 'INLINE'.
333d54da 6202 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6203 * alloc.c, fontset.c (INLINE): Remove.
6204 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6205 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6206 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6207 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6208 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6209
738db178
DN
62102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6211
6212 Make it possible to run ./temacs.
6213
6214 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6215 syms_of_callproc does the same thing. Remove test for
6216 "initialized", do it in the caller.
6217 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6218
620c53a6
SM
62192011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6220
6221 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6222 (read_minibuf): Use get_minibuffer.
6223 (syms_of_minibuf): Use DEFSYM.
6224 (Qmetadata): New var.
6225 * data.c (Qbuffer): Don't make it static.
6226 (syms_of_data): Use DEFSYM.
6227
e003a292
PE
62282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6229
6230 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6231 (CCL_CODE_MIN): New macro.
6232
ed008a6d
PE
62332011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6234
3687c2ef
PE
6235 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6236
ed008a6d
PE
6237 * eval.c (Qdebug): Now static.
6238 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6239 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6240 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6241
d66c4c7c
CY
62422011-05-29 Chong Yidong <cyd@stupidchicken.com>
6243
6244 * image.c: Various fixes to ImageMagick code comments.
6245 (Fimagemagick_types): Doc fix.
6246
5fbc2025
PE
62472011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6248
0196f88a
PE
6249 Minor fixes prompted by GCC 4.6.0 warnings.
6250
6251 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6252
5fbc2025
PE
6253 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6254 (x_clipboard_manager_save_all): Move extern decl to ...
6255 * xterm.h: ... here, so that it can be checked for consistency.
6256
1dd3c2d9
CY
62572011-05-29 Chong Yidong <cyd@stupidchicken.com>
6258
6259 * xselect.c (x_clipboard_manager_save_frame)
6260 (x_clipboard_manager_save_all): New functions.
6261 (Fx_clipboard_manager_save): Lisp function deleted.
6262
6263 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6264 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6265
6266 * xterm.h: Update prototype.
6267
5ba6571d
WX
62682011-05-28 William Xu <william.xwl@gmail.com>
6269
6270 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6271 exiting (Bug#8239).
6272
3eaff834
JM
62732011-05-28 Jim Meyering <meyering@redhat.com>
6274
e1900994 6275 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6276 * fns.c (to_uchar): Define.
6277 (crypto_hash_function): Use it to convert some newly-signed
6278 variables to unsigned, to avoid sign-extension bugs. For example,
6279 without this change, (md5 "truc") would evaluate to
6280 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6281 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6282 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6283
0f6990a7
PE
62842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6285
6286 Integer overflow fixes.
c8a9ca5a 6287
08686060
PE
6288 * dbusbind.c: Serial number integer overflow fixes.
6289 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6290 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6291 to hold a serial number that is too large for a fixnum.
6292 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6293 Check for serial numbers out of range. Decode any serial number
59568bf0 6294 that was so large that it became a float. (Bug#8722)
08686060 6295
2d1fc3c7
PE
6296 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6297 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6298 Use XFASTINT rather than XUINT when numbers are nonnegative.
6299 (xd_append_arg, Fdbus_method_return_internal):
6300 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6301 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6302 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6303 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6304 (Bug#8722)
2d1fc3c7 6305
c8a9ca5a
PE
6306 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6307
519e1d69
PE
6308 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6309
6df6ae42 6310 ccl: Add integer overflow checks.
30569699
PE
6311 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6312 (IN_INT_RANGE): New macros.
6313 (ccl_driver): Use them to check for integer overflow when
6314 decoding a CCL program. Many of the new checks are whether XINT (x)
6315 fits in int; it doesn't always, on 64-bit hosts. The new version
6316 doesn't catch all possible integer overflows, but it's an
847044ea 6317 improvement. (Bug#8719)
30569699 6318
c11285dc
PE
6319 * alloc.c (make_event_array): Use XINT, not XUINT.
6320 There's no need for unsigned here.
6321
fdccd48e
PE
6322 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6323 This follows up to the 2011-05-06 change that substituted uintptr_t
6324 for EMACS_INT. This case wasn't caught back then.
6325
37910ab2
PE
6326 Rework Fformat to avoid integer overflow issues.
6327 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6328 now (part of C89). Include <verify.h>.
6329 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6330 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6331 (Fformat): Avoid the prepass trying to compute sizes; it was only
6332 approximate and thus did not catch overflow reliably. Instead, walk
6333 through the format just once, formatting and computing sizes as we go,
6334 checking for integer overflow at every step, and allocating a larger
6335 buffer as needed. Keep track separately whether the format is
6336 multibyte. Keep only the most-recently calculated precision, rather
6337 than them all. Record whether each argument has been converted to
6338 string. Use EMACS_INT, not int, for byte and char and arg counts.
6339 Support field widths and precisions larger than INT_MAX. Avoid
6340 sprintf's undefined behavior with conversion specifications such as %#d
6341 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6342 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6343 formatting out-of-range floating point numbers with int
9173deec 6344 formats. (Bug#8668)
37910ab2 6345
2e6578fb
PE
6346 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6347
0ae6bdee
PE
6348 * data.c: Avoid integer truncation in expressions involving floats.
6349 * data.c: Include <intprops.h>.
6350 (arith_driver): When there's an integer overflow in an expression
6351 involving floating point, convert the integers to floating point
6352 so that the resulting value does not suffer from catastrophic
6353 integer truncation. For example, on a 64-bit host (* 4
6354 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6355 Do not rely on undefined behavior after integer overflow.
6356
de883a70
PE
6357 merge count_size_as_multibyte, parse_str_to_multibyte
6358 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6359 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6360 Check for integer overflow.
6361 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6362 since it's now a duplicate of the other. This is more of
6363 a character than a buffer op, so better that it's in character.c.
6364 * fns.c, print.c: Adjust to above changes.
6365
2ff916cb
PE
63662011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6367
6368 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6369
f1b54466
PE
63702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6371
fb1ac845
PE
6372 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6373 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6374 (x_clipboard_manager_save): Now static.
6375 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6376
f1b54466
PE
6377 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6378 (crypto_hash_function): Now static.
6379 Fix pointer signedness problems. Avoid unnecessary initializations.
6380
a9f737ee
CY
63812011-05-27 Chong Yidong <cyd@stupidchicken.com>
6382
6383 * termhooks.h (Vselection_alist): Make it terminal-local.
6384
6385 * terminal.c (create_terminal): Initialize it.
6386
6387 * xselect.c: Support for clipboard managers.
6388 (Vselection_alist): Move to termhooks.h as terminal-local var.
6389 (LOCAL_SELECTION): New macro.
6390 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6391 (symbol_to_x_atom): Remove gratuitous arg.
6392 (x_handle_selection_request, lisp_data_to_selection_data)
6393 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6394 (x_own_selection, x_get_local_selection, x_convert_selection):
6395 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6396 (some_frame_on_display): Delete unused function.
6397 (Fx_own_selection_internal, Fx_get_selection_internal)
6398 (Fx_disown_selection_internal, Fx_selection_owner_p)
6399 (Fx_selection_exists_p): New optional frame arg.
6400 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6401 (x_handle_selection_clear): Don't treat other terminals with the
6402 same keyboard specially. Use the terminal-local Vselection_alist.
6403 (x_clear_frame_selections): Use Frun_hook_with_args.
6404
6405 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6406
6407 * xterm.h: Add support for those atoms.
6408
e067f0c1
CY
64092011-05-26 Chong Yidong <cyd@stupidchicken.com>
6410
6411 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6412 (converted_selections, conversion_fail_tag): New global variables.
6413 (x_selection_request_lisp_error): Free the above.
6414 (x_get_local_selection): Remove unnecessary code.
6415 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6416 of converted selections stored in converted_selections.
6417 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6418 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6419 (x_convert_selection): New function.
6420 (x_handle_selection_event): Simplify.
6421 (x_get_foreign_selection): Don't ignore incoming requests while
6422 waiting for an answer; this will fail when we implement
6423 SAVE_TARGETS, and seems unnecessary anyway.
6424 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6425 (Vx_sent_selection_functions): Doc fix.
6426
0f4aebc0
LL
64272011-05-26 Leo Liu <sdl.web@gmail.com>
6428
6429 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6430
e61124cd
YM
64312011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6432
6433 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6434
6435 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6436 for fringe update if it has periodic bitmap.
ac389d0c 6437 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6438 and fringe_bitmap_periodic_p.
6439
6440 * fringe.c (get_fringe_bitmap_data): New function.
6441 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6442 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6443 row. Mark glyph row for fringe update if periodicity changed.
6444
6445 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6446 for fringe update unless it has periodic bitmap.
6447
f16d9837
KH
64482011-05-25 Kenichi Handa <handa@m17n.org>
6449
6450 * xdisp.c (get_next_display_element): Set correct it->face_id for
6451 a static composition.
6452
e1b90ef6
LL
64532011-05-24 Leo Liu <sdl.web@gmail.com>
6454
6455 * deps.mk (fns.o):
6456 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6457
6458 * fns.c (crypto_hash_function, Fsha1): New function.
6459 (Fmd5): Use crypto_hash_function.
6460 (syms_of_fns): Add Ssha1.
6461
7400048f
PE
64622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6463
6464 * gnutls.c: Remove unused macros.
6465 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6466 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6467 Remove macros that are defined and never used.
6468 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6469
abb71cf4
CY
64702011-05-22 Chong Yidong <cyd@stupidchicken.com>
6471
6472 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6473 (Fx_get_selection_internal): Minor cleanup.
6474 (Fx_own_selection_internal): Rename arguments for consistency with
6475 select.el.
6476
6307db39
PE
64772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6478
6479 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6480
f3d4e0a4
CY
64812011-05-22 Chong Yidong <cyd@stupidchicken.com>
6482
6483 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6484
4d8ade89
YM
64852011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6486
6487 * dispnew.c (scrolling_window): Don't exclude the case that the
6488 last enabled row in the desired matrix touches the bottom boundary.
6489
32078c8d
GM
64902011-05-21 Glenn Morris <rgm@gnu.org>
6491
6492 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6493 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6494 and add some more files.
32078c8d 6495
7285dc67
EZ
64962011-05-20 Eli Zaretskii <eliz@gnu.org>
6497
6498 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6499 report_file_error introduced by the change from 2011-05-07.
6500
89d1bd22
PE
65012011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6502
6503 * systime.h (Time): Define only if emacs is defined.
6504 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6505 where the include path doesn't have X11/X.h by default. See
6506 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6507
cd394be1 65082011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6509
6510 * composite.c (find_automatic_composition): Fix previous change.
6511
b9704ad9
GM
65122011-05-20 Glenn Morris <rgm@gnu.org>
6513
6514 * lisp.mk: New file, split from Makefile.in.
6515 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6516 (shortlisp): Remove.
6517 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6518
4a720484
GM
65192011-05-19 Glenn Morris <rgm@gnu.org>
6520
6521 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6522 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6523 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6524 (lisp): Set the order to that of loadup.el.
6525 (shortlisp): Make it a copy of $lisp.
6526 (SOME_MACHINE_LISP): Remove.
6527 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6528 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6529
a28d4396
KH
65302011-05-18 Kenichi Handa <handa@m17n.org>
6531
6532 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6533 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6534 (find_automatic_composition): Mostly rewrite for efficiency.
6535
a2b1fa8e
JB
65362011-05-18 Juanma Barranquero <lekktu@gmail.com>
6537
6538 * makefile.w32-in: Update dependencies.
6539
8e1f5610
CS
65402011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6541
6542 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6543 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6544
7025ee00 65452011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6546
cdfa6eab
PE
6547 Fix some integer overflow issues, such as string length overflow.
6548
06d6db33
PE
6549 * insdel.c (count_size_as_multibyte): Check for string overflow.
6550
2b4560a8
PE
6551 * character.c (lisp_string_width): Check for string overflow.
6552 Use EMACS_INT, not int, for string indexes and lengths; in
6553 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6554 the resulting string length overflows an EMACS_INT; instead,
6555 report a string overflow if no precision given. When checking for
6556 precision exhaustion, use a check that cannot possibly have
6557 integer overflow. (Bug#8675)
6558 * character.h (lisp_string_width): Adjust to new signature.
6559
cb93f9be
PE
6560 * alloc.c (string_overflow): New function.
6561 (Fmake_string): Use it. This doesn't change behavior, but saves
6562 a few bytes and will simplify future changes.
6563 * character.c (string_escape_byte8): Likewise.
6564 * lisp.h (string_overflow): New decl.
6565
1a1f3366
PE
6566 Fixups, following up to the user-interface timestamp change.
6567 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6568 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6569 * msdos.c (mouse_get_pos): Likewise.
6570 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6571 * w32gui.h (Time): Define by including "systime.h" rather than by
6572 declaring it ourselves. (Bug#8664)
6573
d4e3e4d3
PE
6574 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6575 * image.c (clear_image_cache): Likewise.
6576
f6a24d19
PE
6577 * term.c (term_mouse_position): Don't assume time_t wraparound.
6578
08dc5ae6
PE
6579 Be more systematic about user-interface timestamps.
6580 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6581 and sometimes 'EMACS_UINT', to represent these timestamps.
6582 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6583 This makes the code easier to follow, and makes it easier to catch
6584 integer overflow bugs such as Bug#8664.
6585 * frame.c (Fmouse_position, Fmouse_pixel_position):
6586 Use Time, not unsigned long, for user-interface timestamps.
6587 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6588 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6589 * keyboard.h (last_event_timestamp): Likewise.
6590 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6591 * menu.h (xmenu_show): Likewise.
6592 * term.c (term_mouse_position): Likewise.
6593 * termhooks.h (struct input_event.timestamp): Likewise.
6594 (struct terminal.mouse_position_hook): Likewise.
6595 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6596 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6597 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6598 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6599 what it was before.
6600 * menu.h, termhooks.h: Include "systime.h", for Time.
6601
8e55734a
PE
6602 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6603 Don't assume that the difference between two unsigned long values
6604 can fit into an integer. At this point, we know button_down_time
6605 <= event->timestamp, so the difference must be nonnegative, so
6606 there's no need to cast the result if double-click-time is
6607 nonnegative, as it should be; check that it's nonnegative, just in
6608 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6609 apart (about 25 days). (Bug#8664)
8e55734a 6610
841f1b75 6611 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6612 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6613
3e26f69c
PE
6614 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6615 that always fit in int. Use a sentinel instead of a counter, to
6616 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6617 * frame.h (struct frame): Use int for menu_bar_items_used
6618 instead of EMACS_INT, since it always fits in int.
3e26f69c 6619
5cc152c0
PE
6620 * menu.c (grow_menu_items): Check for int overflow.
6621
d89eb65e
PE
6622 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6623
5235bd3e
PE
6624 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6625 Before, the code was not consistent. These values cannot exceed
6626 2**31 - 1 so there's no need to make them unsigned.
6627 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6628 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6629 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6630 as modifiers.
6631 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6632
bc827e23
PE
6633 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6634 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6635 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6636 presumably because the widths might not match.
6637
78eb494e
PE
6638 * window.c (size_window): Avoid needless test at loop start.
6639
04f2d78b
CB
66402011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6641
6642 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6643
d2fc7e3d 66442011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6645
6646 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6647
d2fc7e3d 66482011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6649
6650 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6651 `width' to `bar_area_x' and `bar_area_width', respectively.
6652 (x_scroll_run): Take account of fringe background extension.
6653
04f2d78b
CB
6654 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6655 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6656 `bar_area_width', respectively.
6657 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6658 background extension.
6659
79b70037
GM
66602011-05-10 Jim Meyering <meyering@redhat.com>
6661
6662 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6663
2f142cc5
JB
66642011-05-10 Juanma Barranquero <lekktu@gmail.com>
6665
6666 * image.c (Finit_image_library): Return t for built-in image types,
6667 like pbm and xbm. (Bug#8640)
6668
57679c86
AS
66692011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6670
6671 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6672
888c9e86
EZ
66732011-05-07 Eli Zaretskii <eliz@gnu.org>
6674
b0512a1d
EZ
6675 * w32console.c (Fset_screen_color): Doc fix.
6676 (Fget_screen_color): New function.
6677 (syms_of_ntterm): Defsubr it.
6678
7285dc67
EZ
6679 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6680 unlink the temporary file if Fcall_process didn't create it in the
6681 first place.
6682 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6683 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6684 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6685 cue to call_process_cleanup not to close that handle.
6686
4d3fcc8e
BK
66872011-05-07 Ben Key <bkey76@gmail.com>
6688
6689 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6690 one of two shell specific rules, either bootstrap-temacs-CMD or
6691 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6692 to the previous implementation of the bootstrap-temacs rule.
6693 The bootstrap-temacs-CMD rule is similar to the previous
6694 implementation of the bootstrap-temacs rule except that it
6695 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6696 variable.
6697
6698 These changes, along with some changes to nt/configure.bat,
6699 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6700 earlier fix to add support for --cflags and --ldflags options
6701 that include quotes so that it works whether make uses cmd or
6702 sh as the shell.
6703
b4289b64
MA
67042011-05-06 Michael Albinus <michael.albinus@gmx.de>
6705
6706 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6707 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6708 is a constant.
6709 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6710 a string. Handle both cases.
6711 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6712 (Fdbus_register_method): Use Qinvalid_function.
6713
af4c0e28
JB
67142011-05-06 Juanma Barranquero <lekktu@gmail.com>
6715
6716 * makefile.w32-in: Update dependencies.
6717 (LISP_H): Add inttypes.h and stdin.h.
6718 (PROCESS_H): Add unistd.h.
6719
c51453d9
EZ
67202011-05-06 Eli Zaretskii <eliz@gnu.org>
6721
6722 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6723 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6724
8ff0ac3c 67252011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6726
4c4b566b
PE
6727 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6728
aab2b9b5
PE
6729 * term.c (vfatal): Remove stray call to va_end.
6730 It's not needed and the C Standard doesn't allow it here anyway.
6731
c378da0b
PE
6732 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6733 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6734
288b08c7
PE
6735 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6736 bytes.
6737
e3601888
PE
6738 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6739
db6c0e74
PE
6740 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6741
dd5963ea
PE
6742 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6743
88c9450f
PE
6744 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6745
2f9442b8
PE
6746 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6747
c032b5f8
PE
6748 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6749 * charset.c (Fdefine_charset_internal): Don't initialize
6750 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6751 32-bit int (Bug#8600).
a108c10b
PE
6752
6753 * lread.c (read_integer): Be more consistent with string-to-number.
6754 Use string_to_number to do the actual conversion; this avoids
6755 rounding errors and fixes some other screwups. Without this fix,
6756 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6757 (digit_to_number): Move earlier, for benefit of read_integer.
6758 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6759 not a digit in any supported base. (Bug#8602)
a108c10b 6760
ad5f9eea
PE
6761 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6762
aec1708a
PE
6763 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6764 to match comment at start of function. This also removes a
6765 GCC warning about overflow in a 32+64-bit port.
6766
47be4ab5
PE
6767 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6768
371cac43
PE
6769 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6770 Reported by Stefan Monnier in
6771 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6772 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6773 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6774
d01a7826
PE
6775 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6776 (EMACS_UINTPTR): Likewise, with uintptr_t.
6777
7fd47d5c
PE
6778 * lisp.h: Prefer 64-bit EMACS_INT if available.
6779 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6780 on 32-bit hosts that have 64-bit int, so that they can access
6781 large files.
122b0c86
PE
6782 However, temporarily disable this change unless the temporary
6783 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6784
8727937b
PE
6785 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6786
8ac068ac
PE
6787 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6788 This removes an assumption that EMACS_INT and long are the same
6789 width as pointers. The assumption is true for Emacs porting targets
6790 now, but we want to make other targets possible.
6791 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6792 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6793 In the rest of the code, change types of integers that hold casted
6794 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6795 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6796 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6797 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6798 No need to cast type when ORing.
6799 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6800 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6801 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6802 assume EMACS_INT is the same width as char *.
6803 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6804 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6805 Remove no-longer-needed casts.
6806 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6807 (xg_tool_bar_help_callback, xg_make_tool_item):
6808 Use EMACS_INTPTR to hold an integer
6809 that will be cast to void *; this can avoid a GCC warning
6810 if EMACS_INT is not the same width as void *.
6811 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6812 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6813 (current_message_1, set_message_1):
6814 Use a local to convert to proper width without a cast.
6815 * xmenu.c (dialog_selection_callback): Likewise.
6816
ede49d71
PE
6817 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6818 Also, don't assume VALBITS / RAND_BITS is less than 5,
6819 and don't rely on undefined behavior when shifting a 1 left into
6820 the sign bit.
6821 * lisp.h (get_random): Change signature to match.
6822
2f30ecd0
PE
6823 * lread.c (hash_string): Use size_t, not int, for hash computation.
6824 Normally we prefer signed values; but hashing is special, because
6825 it's better to use unsigned division on hash table sizes so that
6826 the remainder is nonnegative. Also, size_t is the natural width
6827 for hashing into memory. The previous code used 'int', which doesn't
6828 retain enough info to hash well into very large tables.
6829 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6830
2a866e7b
PE
6831 * dbusbind.c: Don't possibly lose pointer info when converting.
6832 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6833 Use XPNTR rather than XHASH, so that the high-order bits of
6834 the pointer aren't lost when converting through void *.
6835
51639eac
PE
6836 * eval.c (Fautoload): Don't double-shift a pointer.
6837
92394119
PE
6838 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6839
dbdb9a7c
JB
68402011-05-06 Juanma Barranquero <lekktu@gmail.com>
6841
6842 * gnutls.c (DEF_GNUTLS_FN):
6843 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6844
db7a0b4f
AS
68452011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6846
6847 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6848 marker. (Bug#8610)
6849
cd394be1 68502011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6851
6852 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6853 New version that can reserve upto 2GB of heap space.
6854
f7ff1b0f 68552011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6856
6857 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6858
639c109b
TZ
68592011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6860
6861 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6862 `gnutls_certificate_set_x509_key_file'.
6863
d2127135
JB
68642011-05-05 Juanma Barranquero <lekktu@gmail.com>
6865
6866 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6867 Update dependencies.
6868
e968f4f3
JB
68692011-05-04 Juanma Barranquero <lekktu@gmail.com>
6870
6871 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6872 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6873 Remove unused parameter `fildes'.
6874 * process.c (read_process_output, send_process): Don't pass it.
6875
84d358f0
JB
68762011-05-04 Juanma Barranquero <lekktu@gmail.com>
6877
6878 Fix previous change: the library cache is defined in w32.c.
6879 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6880 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6881
0898ca10
JB
68822011-05-04 Juanma Barranquero <lekktu@gmail.com>
6883
6884 Implement dynamic loading of GnuTLS on Windows.
6885
6886 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6887 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6888 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6889 Declare.
6890
6891 * gnutls.c (Qgnutls_dll): Define.
6892 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6893 (gnutls_*): Declare function pointers.
6894 (init_gnutls_functions): New function to initialize function pointers.
6895 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6896 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6897 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6898 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6899 (emacs_gnutls_write, emacs_gnutls_read)
6900 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6901 (Fgnutls_available_p): New function.
6902 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6903 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6904 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6905
6906 * image.c: Include w32.h.
6907 (Vimage_type_cache): Delete.
6908 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6909 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6910 (w32_delayed_load): Move to w32.c.
6911
6912 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6913
6914 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6915 (w32_delayed_load): Move from image.c. When loading a library, record
6916 its filename in the :loaded-from property of the library id.
6917 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6918 Initialize and staticpro them.
6919 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6920
6921 * process.c: Include lisp.h before w32.h, not after.
6922 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6923 instead of gnutls_record_check_pending.
6924
6925 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6926
ff4de4aa
TZ
69272011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6928
6929 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6930 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6931 as passed in.
6932
abe95abb
JD
69332011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6934
6935 * xterm.c (x_set_frame_alpha): Do not set property on anything
6936 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6937
e16e55d4
JB
69382011-05-02 Juanma Barranquero <lekktu@gmail.com>
6939
6940 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6941
bafcf6a5
JB
69422011-05-02 Juanma Barranquero <lekktu@gmail.com>
6943
6944 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6945 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6946 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6947 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6948 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6949 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6950 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6951 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6952 (Qgnutls_bootprop_callbacks_verify): Make static.
6953
e7a6747f
AS
69542011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6955
19ed11ba
AS
6956 * callproc.c: Indentation fixup.
6957
e7a6747f 6958 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6959 (wait_for_termination, interruptible_wait_for_termination):
6960 Move after wait_for_termination_1.
e7a6747f 6961
1ef14cb4
LMI
69622011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6963
6964 * sysdep.c (interruptible_wait_for_termination): New function
6965 which is like wait_for_termination, but allows keyboard
6966 interruptions.
6967
6968 * callproc.c (Fcall_process): Add (:file "file") as an option for
6969 the STDOUT buffer.
6970 (Fcall_process_region): Ditto.
6971
330d880c
EZ
69722011-04-30 Eli Zaretskii <eliz@gnu.org>
6973
8db90b73
EZ
6974 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6975 rather than `XVECTOR (FOO)->size'.
6976
330d880c
EZ
6977 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6978 inttypes.h, as a gnulib replacement is used if it not available in
6979 system headers.
6980
15cbd324
EZ
69812011-04-21 Eli Zaretskii <eliz@gnu.org>
6982
6983 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6984 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6985 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6986
6987 * coding.c (coding_alloc_by_realloc): Error out if destination
6988 will grow beyond MOST_POSITIVE_FIXNUM.
6989 (decode_coding_emacs_mule): Abort if there isn't enough place in
6990 charbuf for the composition carryover bytes. Reserve an extra
6991 space for up to 2 characters produced in a loop.
6992 (decode_coding_iso_2022): Abort if there isn't enough place in
6993 charbuf for the composition carryover bytes.
6994
69952011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6996
ae940cca
EZ
6997 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6998 aborting when %lld or %lll format is passed.
6999 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7000 %llo or %llx format is passed. (Bug#8545)
7001
03ab8921
EZ
7002 * window.c (window_scroll_line_based): Use a marker instead of
7003 simple variables to record original value of point. (Bug#7952)
7004
afda1437
EZ
7005 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7006 produced by %s or %c overflows available buffer space. (Bug#8545)
7007
f76dee0c
PE
70082011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7009
7010 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7011 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7012
fdc5744d
JB
70132011-04-28 Juanma Barranquero <lekktu@gmail.com>
7014
7015 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7016
638f053a
JB
70172011-04-28 Juanma Barranquero <lekktu@gmail.com>
7018
7019 * keyboard.c (Qdelayed_warnings_hook): Define.
7020 (command_loop_1): Run `delayed-warnings-hook'
7021 if Vdelayed_warnings_list is non-nil.
7022 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7023 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7024
d178f871
EZ
70252011-04-28 Eli Zaretskii <eliz@gnu.org>
7026
7027 * doprnt.c (doprnt): Don't return value smaller than the buffer
7028 size if the message was truncated. (Bug#8545).
7029
b124fd93
JB
70302011-04-28 Juanma Barranquero <lekktu@gmail.com>
7031
7032 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7033 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7034
e810457d
PE
70352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7036
7037 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7038
ea51cceb
JB
70392011-04-27 Juanma Barranquero <lekktu@gmail.com>
7040
7041 * makefile.w32-in: Update dependencies.
7042
94dcfacf
EZ
70432011-04-27 Eli Zaretskii <eliz@gnu.org>
7044
7045 Improve `doprnt' and its usage. (Bug#8545)
7046 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7047 `format_end'. Remove support for %l as a conversion specifier.
7048 Don't use xrealloc. Improve diagnostics when the %l size modifier
7049 is used. Update the commentary.
7050
7051 * eval.c (verror): Simplify calculation of size_t.
7052
7053 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7054 messages.
7055
f61f41d7
PE
70562011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7057
7058 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7059 change.
7060
96fb4434
PE
70612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7062
7063 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7064 This makes this file independent of the recent pseudovector change.
7065
671875da 70662011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7067
69e9b5a3
PE
7068 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7069
b5f869a7 7070 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7071 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7072 Remove unused local.
c8926152 7073 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7074
841a1577 7075 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7076 GCC 4.6.0 optimizes based on type-based alias analysis.
7077 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7078 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7079 != &v->size, and therefore "v->size = 1; b->size = 2; return
7080 v->size;" must therefore return 1. This assumption is incorrect
7081 for Emacs, since it type-puns struct Lisp_Vector * with many other
7082 types. To fix this problem, this patch adds a new type struct
f904488f 7083 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7084 and pseudovectors, and helps optimizing compilers not get fooled
7085 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7086 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7087 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7088 the size member.
eab3844f
PE
7089 (XSETPVECTYPE): Rewrite in terms of new macro.
7090 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7091 This is a bit clearer, and further avoids the possibility of
7092 undesirable aliasing.
7093 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7094 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7095 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7096 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7097 (ASIZE): Now uses header.size rather than size.
7098 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7099 to avoid the hassle of writing XVECTOR (foo)->header.size.
7100 (struct vectorlike_header): New type.
eab3844f
PE
7101 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7102 object, to help avoid aliasing.
7103 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7104 (SUBRP): Likewise, since Lisp_Subr is a special case.
7105 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7106 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7107 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7108 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7109 changed to be "header.size" and "header.next".
7110 * buffer.h (struct buffer): Likewise.
7111 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7112 * frame.h (struct frame): Likewise.
7113 * process.h (struct Lisp_Process): Likewise.
7114 * termhooks.h (struct terminal): Likewise.
7115 * window.c (struct save_window_data, struct saved_window): Likewise.
7116 * window.h (struct window): Likewise.
7117 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7118 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7119 * buffer.c (init_buffer_once): Likewise.
7120 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7121 special case.
7122 * process.c (Fformat_network_address): Use local var for size,
7123 for brevity.
7124
0df1eac5
PE
7125 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7126
847ab9d1 7127 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7128 * data.c (atof): Remove decl; no longer used or needed.
7129 (digit_to_number): Move to lread.c.
7130 (Fstring_to_number): Use new string_to_number function, to be
7131 consistent with how the Lisp reader treats infinities and NaNs.
7132 Do not assume that floating-point numbers represent EMACS_INT
7133 without losing information; this is not true on most 64-bit hosts.
7134 Avoid double-rounding errors, by insisting on integers when
7135 parsing non-base-10 numbers, as the documentation specifies.
7136 * lisp.h (string_to_number): New decl, replacing ...
7137 (isfloat_string): Remove.
bc0a5c13 7138 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7139 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7140 appears to have been a coding error. Similarly, do not accept
7141 strings like +-1e0 as floating point numbers. Do not report
7142 overflow for integer overflows unless the base is not 10 which
7143 means we have no simple and reliable way to continue.
7144 Break out the floating-point parsing into a new
7145 function string_to_number, so that Fstring_to_number parses
7146 floating point numbers consistently with the Lisp reader.
04f2d78b 7147 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7148 (E_CHAR, EXP_INT): Remove, replacing with ...
7149 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7150 (string_to_number): New function, replacing isfloat_string.
7151 This function checks for valid syntax and produces the resulting
7152 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7153 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7154 so that overflow for non-base-10 numbers is reported only when
7155 there's no portable and simple way to convert to floating point.
452f4150 7156
67769ffc
PE
7157 * textprop.c (set_text_properties_1): Rewrite for clarity,
7158 and to avoid GCC warning about integer overflow.
7159
c20db43f
PE
7160 * intervals.h (struct interval): Use EMACS_INT for members
7161 where EMACS_UINT might cause problems. See
7162 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7163 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7164 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7165 All uses changed.
37aa2f85
PE
7166 (offset_intervals): Tell GCC not to worry about length overflow
7167 when negating a negative length.
c20db43f 7168
2538aa2f
PE
7169 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7170 (overrun_check_free): Likewise.
7171
f2d3008d
PE
7172 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7173 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7174 word size.
7175
ec8df744
PE
7176 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7177 (gnutls_make_error): Rename local to avoid shadowing.
7178 (gnutls_emacs_global_deinit): ifdef out; not used.
7179 (Fgnutls_boot): Use const for pointer to readonly storage.
7180 Comment out unused local. Fix pointer signedness problems.
7181
640ee02d
PE
7182 * lread.c (openp): Don't stuff size_t into an 'int'.
7183 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7184 about possible signed overflow.
7185
6048fb2a
PE
7186 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7187 (GDK_KEY_g): Don't define if already defined.
7188 (xg_prepare_tooltip): Avoid pointer signedness problem.
7189 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7190
fa3c87e1
PE
7191 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7192 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7193
2172544b
PE
7194 * xfns.c (Fx_window_property): Simplify a bit,
7195 to make a bit faster and to avoid GCC 4.6.0 warning.
7196 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7197
9b821a21
PE
7198 * fns.c (internal_equal): Don't assume size_t fits in int.
7199
3c616cfa
PE
7200 * alloc.c (compact_small_strings): Tighten assertion a little.
7201
c2982e87
PE
7202 Replace pEd with more-general pI, and fix some printf arg casts.
7203 * lisp.h (pI): New macro, generalizing old pEd macro to other
7204 conversion specifiers. For example, use "...%"pI"d..." rather
7205 than "...%"pEd"...".
7206 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7207 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7208 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7209 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7210 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7211 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7212 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7213 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7214 64-bit hosts.
7215 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7216 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7217 * print.c (safe_debug_print, print_object): Likewise.
7218 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7219 to int.
6f04d126
PE
7220 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7221 avoiding the 0 flag, which is not portable.
c2982e87
PE
7222 * process.c (Fmake_network_process): Use pI to avoid cast.
7223 * region-cache.c (pp_cache): Likewise.
7224 * xdisp.c (decode_mode_spec): Likewise.
7225 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7226 behavior on 64-bit hosts with printf arg.
6f04d126 7227 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7228 (x_stop_queuing_selection_requests): Likewise.
7229 (x_get_window_property): Don't truncate byte count to an 'int'
7230 when tracing.
0b432f21 7231
5e073ec7
PE
7232 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7233 here, since it parses constructs like leading '-' and spaces,
7234 which are not wanted; and it overflows with large numbers.
7235 Instead, simply match F[0-9]+, which is what is wanted anyway.
7236
36372bf9
PE
7237 * alloc.c: Remove unportable assumptions about struct layout.
7238 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7239 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7240 (allocate_vectorlike, make_pure_vector): Use the new macros,
7241 plus offsetof, to remove unportable assumptions about struct layout.
7242 These assumptions hold on all porting targets that I know of, but
7243 they are not guaranteed, they're easy to remove, and removing them
7244 makes further changes easier.
7245
0b432f21
PE
7246 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7247 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7248 (string_overrun_cookie): Now const. Use initializers that
7249 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7250 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7251 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7252 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7253 multiple of sizeof (EMACS_INT); it need not be, if
7254 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7255 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7256
895009e1
JB
72572011-04-26 Juanma Barranquero <lekktu@gmail.com>
7258
7259 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7260
6a7a1b0b
TZ
72612011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7262
7263 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7264 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7265 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7266
841a1577 72672011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7268
7269 * lisp.h (Qdebug): List symbol.
895009e1 7270 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7271 * keyboard.c (debug-on-event): New variable.
7272 (handle_user_signal): Break into debugger when debug-on-event
7273 matches the current signal symbol.
7274
f2d3ba6f
DN
72752011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7276
7277 * alloc.c (check_sblock, check_string_bytes)
7278 (check_string_free_list): Convert to standard C.
7279
42ce4c63
TZ
72802011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7281
7282 * w32.c (emacs_gnutls_push): Fix typo.
7283
825cd63c
EZ
72842011-04-25 Eli Zaretskii <eliz@gnu.org>
7285
fb11d64d
EZ
7286 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7287 "cast to pointer from integer of different size".
7288
825cd63c
EZ
7289 Improve doprnt and its use in verror. (Bug#8545)
7290 * doprnt.c (doprnt): Document the set of format control sequences
7291 supported by the function. Use SAFE_ALLOCA instead of always
7292 using `alloca'.
7293
7294 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7295 is one byte too soon. Don't use xrealloc; instead xfree and
7296 xmalloc anew.
7297
e061a11b
TZ
72982011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7299
7300 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7301 callbacks stage.
7302
7303 * gnutls.c: Renamed global_initialized to
7304 gnutls_global_initialized. Added internals for the
7305 :verify-hostname-error, :verify-error, and :verify-flags
7306 parameters of `gnutls-boot' and documented those parameters in the
7307 docstring. Start callback support.
9173deec
JB
7308 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7309 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7310 on error. Return error code.
e061a11b
TZ
7311 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7312 (emacs_gnutls_read): Likewise.
7313 (Fgnutls_boot): Return handshake error code.
7314 (emacs_gnutls_handle_error): New function.
7315 (wsaerror_to_errno): Likewise.
7316
7317 * w32.h (emacs_gnutls_pull): Add prototype.
7318 (emacs_gnutls_push): Likewise.
7319
7320 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7321 (emacs_gnutls_push): Likewise.
7322
73232011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7324
7325 * process.c (wait_reading_process_output): Check if GnuTLS
7326 buffered some data internally if no FDs are set for TLS
7327 connections.
7328
7329 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7330 (LIBS): Link to USER_LIBS.
7331 ($(BLD)/gnutls.$(0)): New target.
7332
fa6996bc
EZ
73332011-04-24 Eli Zaretskii <eliz@gnu.org>
7334
eb35682e
EZ
7335 * xdisp.c (handle_single_display_spec): Rename the
7336 display_replaced_before_p argument into display_replaced_p, to
7337 make it consistent with the commentary. Fix typos in the
7338 commentary.
7339
e2ad650c
EZ
7340 * textprop.c (syms_of_textprop): Remove dead code.
7341 (copy_text_properties): Delete obsolete commentary about an
7342 interface that was deleted long ago. Fix typos in the description
7343 of arguments.
7344
1b2de274
EZ
7345 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7346 to changes in oldXMenu/XMenu.h from 2011-04-16.
7347 <menu_help_message, prev_menu_help_message>: Constify.
7348 (IT_menu_make_room): menu->help_text is now `const char **';
7349 adjust.
7350
7351 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7352 to changes in oldXMenu/XMenu.h from 2011-04-16.
7353 (struct XMenu): Declare `help_text' `const char **'.
7354
7355 * xfaces.c <Qunspecified>: Make extern again.
7356
7357 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7358 required by POSIX.
1b2de274 7359
762b15be
EZ
7360 * doc.c (get_doc_string): Improve the format passed to `error'.
7361
7362 * doprnt.c (doprnt): Improve commentary.
7363
7364 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7365
7366 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7367 them with etags.
7368
f1052e5d
EZ
7369 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7370 changes in globals.h immediately force recompilation.
762b15be
EZ
7371 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7372 $(CURDIR)/s/ms-w32.h.
7373 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7374
fa6996bc
EZ
7375 * character.c (Fchar_direction): Function deleted.
7376 (syms_of_character): Don't defsubr it.
7377 <char-direction-table>: Deleted.
7378
e6c3da20
EZ
73792011-04-23 Eli Zaretskii <eliz@gnu.org>
7380
7381 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7382 * doprnt.c: Include limits.h.
7383 (SIZE_MAX): New macro.
04f2d78b
CB
7384 (doprnt): Return a size_t value. 2nd arg is now size_t.
7385 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7386 Improve overflow protection. Support `l' modifier for integer
7387 conversions. Support %l conversion. Don't assume an EMACS_INT
7388 argument for integer conversions and for %c.
7389
7390 * lisp.h (doprnt): Restore prototype.
7391
7392 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7393 $(SRC)/character.h.
7394
7395 * Makefile.in (base_obj): Add back doprnt.o.
7396
7397 * deps.mk (doprnt.o): Add back prerequisites.
7398 (callint.o): Depend on character.h.
7399
7400 * eval.c (internal_lisp_condition_case): Include the handler
7401 representation in the error message.
7402 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7403 when breaking from the loop.
7404
7405 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7406
7407 * callint.c (Fcall_interactively): When displaying error message
7408 about invalid control letter, pass the character's codepoint, not
7409 a pointer to its multibyte form. Improve display of the character
7410 in octal and display also its hex code.
7411
7412 * character.c (char_string): Use %x to display the (unsigned)
7413 codepoint of an invalid character, to avoid displaying a bogus
7414 negative value.
7415
7416 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7417 `error', not SYMBOL_NAME itself.
7418
7419 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7420 character arguments to `error'.
7421
7422 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7423 to `error' in error message about FINAL_CHAR argument. Make sure
7424 FINAL_CHAR is a character, and use %c when it is passed as
7425 argument to `error'.
7426
4ffd0d6b 74272011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7428
7429 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7430
7431 * w32.c: Include <time.h>.
7432 (sys_localtime): New function.
7433
4ffd0d6b 74342011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7435
7436 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7437
4ffd0d6b 7438 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7439
4ffd0d6b 74402011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7441
4ffd0d6b
GM
7442 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7443 zombies (Bug#8467).
aac0c6e3 7444
04c56954
EZ
74452011-04-19 Eli Zaretskii <eliz@gnu.org>
7446
7447 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7448 gl_state.e_property when gl_state.object is Qt.
7449
7450 * insdel.c (make_gap_larger): Remove limitation of buffer size
7451 to <= INT_MAX.
7452
16a43933
CY
74532011-04-18 Chong Yidong <cyd@stupidchicken.com>
7454
7455 * xdisp.c (lookup_glyphless_char_display)
7456 (produce_glyphless_glyph): Handle cons cell entry in
7457 glyphless-char-display.
7458 (Vglyphless_char_display): Document it.
7459
7460 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7461 glyphless-char-display.
7462
4581706e
CY
74632011-04-17 Chong Yidong <cyd@stupidchicken.com>
7464
7465 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7466
7467 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7468
7469 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7470 definition for no-X builds.
7471
4887c6e2 74722011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7473
fd35b6f9
PE
7474 Static checks with GCC 4.6.0 and non-default toolkits.
7475
5c1ccb01
PE
7476 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7477
006c5daa
PE
7478 * process.c (keyboard_bit_set): Define only if SIGIO.
7479 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7480 (send_process): Repair possible setjmp clobbering.
7481
efc736d3
PE
7482 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7483
4e2fe2e6
PE
7484 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7485
f97334a2
PE
7486 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7487
4e75f29d
PE
7488 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7489 Define only if needed.
7490
90efadd1
PE
7491 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7492 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7493 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7494
3c647824
PE
7495 * dispextern.h (struct redisplay_interface): Rename param
7496 to avoid shadowing.
e264f262 7497 * termhooks.h (struct terminal): Likewise.
761383f4 7498 * xterm.c (xembed_send_message): Likewise.
3c647824 7499
b58c5c4a
PE
7500 * insdel.c (make_gap_smaller): Define only if
7501 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7502
cad59032
PE
7503 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7504 it.
7505
c339dc2e
PE
7506 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7507 so that we aren't warned about unused symbols.
7508
91a3e27b
PE
7509 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7510
399c71d3 7511 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7512
8ffc96f5
PE
7513 * xfns.c (x_real_positions): Mark locals as initialized.
7514
eef9bc79
PE
7515 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7516
098db9dd
PE
7517 * xterm.c: Fix problems found by static analysis with other toolkits.
7518 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7519 (x_dispatch_event): Declare static if USE_GTK, and
7520 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7521 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7522 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7523 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7524 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7525
eb18f6cc
PE
7526 * xmenu.c (menu_help_callback): Pointer type fixes.
7527 Use const pointers when pointing at readonly data. Avoid pointer
7528 signedness clashes.
7529 (FALSE): Remove unused macro.
7530 (update_frame_menubar): Remove unused decl.
7531
1fe72bf8
PE
7532 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7533
60d9e1db
PE
7534 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7535 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7536 (single_menu_item): Rename local to avoid shadowing.
7537
39261c26
PE
7538 * keyboard.c (make_lispy_event): Remove unused local var.
7539
018c5e19
PE
7540 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7541 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7542
63d2b86e
PE
7543 * bitmaps: Change bitmaps from unsigned char back to the X11
7544 compatible char. Avoid the old compiler warnings about
7545 out-of-range initializers by using, for example, '\xab' rather
7546 than 0xab.
7547
aefd87e1
PE
7548 * xgselect.c (xgselect_initialize): Check vs interface
7549 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7550
bf501fb9
PE
7551 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7552
e9829fdf
PE
7553 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7554 to read-only memory.
7555
1086c095
PE
7556 * fns.c (vector): Remove; this old hack is no longer needed.
7557
2baccd04 7558 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7559 Remove unused var.
dde42981 7560 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7561
72391843 7562 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7563
436c16df 7564 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7565 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7566 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7567
92bb796d 7568 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7569 (x_term_init): Remove local to avoid shadowing.
92bb796d 7570
764430a3 7571 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7572
7573 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7574 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7575
d1dfb56c
EZ
75762011-04-16 Eli Zaretskii <eliz@gnu.org>
7577
c4354cb4
EZ
7578 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7579
d1dfb56c
EZ
7580 Fix regex.c, syntax.c and friends for buffers > 2GB.
7581 * syntax.h (struct gl_state_s): Declare character position members
7582 EMACS_INT.
7583
7584 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7585
04f2d78b
CB
7586 * textprop.c (verify_interval_modification, interval_of):
7587 Declare arguments EMACS_INT.
d1dfb56c
EZ
7588
7589 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7590 EMACS_INT.
7591
7592 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7593
7594 * indent.c (Fvertical_motion): Local variable it_start is now
7595 EMACS_INT.
7596
7597 * regex.c (re_match, re_match_2, re_match_2_internal)
7598 (bcmp_translate, regcomp, regexec, print_double_string)
7599 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7600 (re_compile_pattern, re_exec): Declare arguments and local
7601 variables `size_t' and `ssize_t' and return values `regoff_t', as
7602 appropriate.
7603 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7604 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7605 <compile_stack_type>: `size' and `avail' are now `size_t'.
7606
7607 * regex.h <regoff_t>: Use ssize_t, not int.
7608 (re_search, re_search_2, re_match, re_match_2): Arguments that
7609 specify buffer/string position and length are now ssize_t and
7610 size_t. Return type is regoff_t.
7611
613052cd
BK
76122011-04-16 Ben Key <bkey76@gmail.com>
7613
7614 * nsfont.m: Fixed bugs in ns_get_family and
7615 ns_descriptor_to_entity that were caused by using free to
7616 deallocate memory blocks that were allocated by xmalloc (via
7617 xstrdup). This caused Emacs to crash when compiled with
7618 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7619 --enable-checking=xmallocoverrun). xfree is now used to
7620 deallocate these memory blocks.
7621
4170f62f 76222011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7623
71b41406
PE
7624 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7625
9587a89d
PE
7626 emacs_write: Accept and return EMACS_INT for sizes.
7627 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7628 et seq.
7629 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7630 Accept and return EMACS_INT.
7631 (emacs_gnutls_write): Return the number of bytes written on
7632 partial writes.
7633 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7634 (emacs_read, emacs_write): Remove check for negative size, as the
7635 Emacs source code has been audited now.
9587a89d
PE
7636 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7637 (emacs_read, emacs_write): Use it.
273a5f82
PE
7638 * process.c (send_process): Adjust to the new signatures of
7639 emacs_write and emacs_gnutls_write. Do not attempt to store
7640 a byte offset into an 'int'; it might overflow.
9587a89d 7641 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7642
3e047f51
PE
7643 * sound.c: Don't assume sizes fit in 'int'.
7644 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7645 Return EMACS_INT, not int.
3e047f51 7646 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7647 Accept EMACS_INT, not int.
7648 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7649 record read return values.
7650
cc39a9db
BK
76512011-04-15 Ben Key <bkey76@gmail.com>
7652
c9d0ec6d
JB
7653 * keyboard.c (Qundefined): Don't declare static since it is used
7654 in nsfns.m.
7655 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7656 static since they are used in nsfont.m.
cc39a9db 7657
6c60eb9f
SM
76582011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7659
7660 * process.c (Qprocessp): Don't declare static.
7661 * lisp.h (Qprocessp): Declare again.
7662
7990b61a
JB
76632011-04-15 Juanma Barranquero <lekktu@gmail.com>
7664
7665 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7666
5d4cb038
PE
76672011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7668
8bd7b830 7669 Improve C-level modularity by making more things 'static'.
cd64ea1d 7670
e3b27b31
PE
7671 Don't publish debugger-only interfaces to other modules.
7672 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7673 (verify_bytepos, count_markers): Move decls to the only modules
7674 that need them.
7675 * region-cache.h (pp_cache): Likewise.
7676 * window.h (check_all_windows): Likewise.
7677 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7678
5d4cb038
PE
7679 * sysdep.c (croak): Now static, if
7680 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7681 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7682
7683 * alloc.c (refill_memory_reserve): Now static if
7684 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7685 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7686
e87b6180
PE
7687 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7688 Define only if USE_LUCID.
7689
ac64929e
PE
7690 * xrdb.c (x_customization_string, x_rm_string): Now static.
7691
6f37259d
PE
7692 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7693 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7694
1683e3ab
PE
7695 * xdisp.c (draw_row_with_mouse_face): Now static.
7696 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7697
de9c2632
PE
7698 * window.h (check_all_windows): Mark externally visible.
7699
2b96acb7
PE
7700 * window.c (window_deletion_count): Now static.
7701
7702 * undo.c: Make symbols static if they're not exported.
7703 (last_undo_buffer, last_boundary_position, pending_boundary):
7704 Now static.
7705
50436f33
PE
7706 * textprop.c (interval_insert_behind_hooks): Now static.
7707 (interval_insert_in_front_hooks): Likewise.
7708
64520e5c
PE
7709 * term.c: Make symbols static if they're not exported.
7710 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7711 (max_frame_lines, tty_set_terminal_modes):
7712 (tty_reset_terminal_modes, tty_turn_off_highlight):
7713 (get_tty_terminal): Now static.
7714 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7715 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7716 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7717 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7718 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7719
1fa53021
PE
7720 * sysdep.c: Make symbols static if they're not exported.
7721 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7722 Now static.
7723 (sigprocmask_set, full_mask): Remove; unused.
7724 (wait_debugging): Mark as visible.
7725 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7726 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7727
d4b43b22
PE
7728 * syntax.c (syntax_temp): Define only if !__GNUC__.
7729
b7c513d0
PE
7730 * sound.c (current_sound_device, current_sound): Now static.
7731
989b29ad
PE
7732 * search.c (searchbufs, searchbuf_head): Now static.
7733
13a55a78
PE
7734 * scroll.c (scroll_cost): Remove; unused.
7735 * dispextern.h (scroll_cost): Remove decl.
7736
de68a1fc
PE
7737 * region-cache.h (pp_cache): Mark as externally visible.
7738
40ccffa6
PE
7739 * process.c: Make symbols static if they're not exported.
7740 (process_tick, update_tick, create_process, chan_process):
7741 (Vprocess_alist, proc_buffered_char, datagram_access):
7742 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7743 (deactivate_process): Mark defn as static, as well as decl.
7744 * lisp.h (create_process): Remove decl.
7745 * process.h (chan_process, Vprocess_alist): Remove decls.
7746
ad64fc97
PE
7747 * print.c: Make symbols static if they're not exported.
7748 (print_depth, new_backquote_output, being_printed, print_buffer):
7749 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7750 (print_interval, print_number_index, initial_stderr_stream):
7751 Now static.
7752 * lisp.h (Fprinc): Remove decl.
7753 (debug_output_compilation_hack): Mark as externally visible.
7754
adddb265
PE
7755 * sysdep.c (croak): Move decl from here to syssignal.h.
7756 * syssignal.h (croak): Put it here, so the API can be checked when
7757 'croak' is called from dissociate_if_controlling_tty.
7758
1717ede2
PE
7759 * minibuf.c: Make symbols static if they're not exported.
7760 (minibuf_save_list, choose_minibuf_frame): Now static.
7761 * lisp.h (choose_minibuf_frame): Remove decl.
7762
fa5fb2bc
PE
7763 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7764
1e3890d1
PE
7765 * lread.c: Make symbols static if they're not exported.
7766 (read_objects, initial_obarray, oblookup_last_bucket_number):
7767 Now static.
7768 (make_symbol): Remove; unused.
7769 * lisp.h (initial_obarray, make_symbol): Remove decls.
7770
8a1414fa
PE
7771 * keyboard.c: Make symbols static if they're not exported.
7772 (single_kboard, recent_keys_index, total_keys, recent_keys):
7773 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7774 (this_single_command_key_start, echoing, last_auto_save):
7775 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7776 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7777 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7778 (Vlispy_mouse_stem, double_click_count):
7779 Now static.
7780 (force_auto_save_soon): Define only if SIGDANGER.
7781 (ignore_mouse_drag_p): Now static if
7782 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7783 (print_help): Remove; unused.
7784 (stop_character, last_timer_event): Mark as externally visible.
7785 * keyboard.h (ignore_mouse_drag_p): Declare only if
7786 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7787 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7788 * lisp.h (echoing): Remove decl.
7789 (force_auto_save_soon): Declare only if SIGDANGER.
7790 * xdisp.c (redisplay_window): Simplify code, to make it more
7791 obvious that ignore_mouse_drag_p is not accessed if !defined
7792 USE_GTK && !defined HAVE_NS.
7793
93ea6e8f
PE
7794 * intervals.c: Make symbols static if they're not exported.
7795 (merge_properties_sticky, merge_interval_right, delete_interval):
7796 Now static.
7797 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7798
77382fcc
PE
7799 * insdel.c: Make symbols static if they're not exported.
7800 However, leave prepare_to_modify_buffer alone. It's never
7801 called from outside this function, but that appears to be a bug.
7802 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7803 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7804 (adjust_after_replace_noundo): Remove; unused.
7805 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7806 (signal_before_change): Remove decls.
77382fcc 7807
9306c32e
PE
7808 * indent.c (val_compute_motion, val_vmotion): Now static.
7809
cd44d2eb
PE
7810 * image.c: Make symbols static if they're not exported.
7811 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7812 if USE_GTK.
7813 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7814 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7815
ad9a7a06
PE
7816 * fringe.c (standard_bitmaps): Now static.
7817 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7818
81626931
PE
7819 * frame.c: Make symbols static if they're not exported.
7820 (x_report_frame_params, make_terminal_frame): Now static.
7821 (get_frame_param): Now static, unless HAVE_NS.
7822 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7823 (x_get_resource_string): Remove; not used.
7824 * frame.h (make_terminal_frame, x_report_frame_params):
7825 (x_get_resource_string); Remove decls.
7826 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7827 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7828
239f9db9
PE
7829 * font.c, fontset.c: Make symbols static if they're not exported.
7830 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7831 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7832 * font.c (font_close_object): Now static.
7833 * font.h (font_close_object): Remove.
7834 * fontset.c (FONTSET_OBJLIST): Remove.
7835 (free_realized_fontset) #if-0 the body, which does nothing.
7836 (face_suitable_for_char_p): #if-0, as it's never called.
7837 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7838 * xfaces.c (face_at_string_position):
7839 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7840 since 0 is always ASCII.
7841
dfcf3579
PE
7842 * fns.c (weak_hash_tables): Now static.
7843
5045092b
PE
7844 * fileio.c: Make symbols static if they're not exported.
7845 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7846 (Vwrite_region_annotation_buffers): Now static.
7847
57a96f5c
PE
7848 * eval.c: Make symbols static if they're not exported.
7849 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7850 * lisp.h (backtrace_list): Remove decl.
7851
35f08c38
PE
7852 * emacs.c: Make symbols static if they're not exported.
7853 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7854 (fatal_error_code, fatal_error_signal_hook, standard_args):
7855 Now static.
7856 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7857 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7858 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7859 * lisp.h (fatal_error_signal_hook): Remove decl.
7860 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7861
f44bd759
PE
7862 * editfns.c: Move a (normally-unused) function to its only use.
7863 * editfns.c, lisp.h (get_operating_system_release): Remove.
7864 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7865 worth the hassle of breaking this out.
7866
b532497d
PE
7867 * xterm.c: Make symbols static if they're not exported.
7868 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7869 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7870 (x_destroy_window, x_delete_display):
7871 Now static.
7872 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7873 (x_mouse_leave): Remove; unused.
7874 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7875 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7876 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7877 Remove decls.
7878 (x_mouse_leave): Declare only if WINDOWSNT.
7879 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7880 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7881 USE_X_TOOLKIT.
7882
1675728f
PE
7883 * ftxfont.c: Make symbols static if they're not exported.
7884 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7885 HAVE_FREETYPE.
7886 * font.h (ftxfont_driver): Likewise.
7887
e4cebfca
PE
7888 * xfns.c: Make symbols static if they're not exported.
7889 (x_last_font_name, x_display_info_for_name):
7890 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7891 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7892 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7893 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7894 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7895 (last_show_tip_args): Now static.
7896 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7897 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7898 (x_screen_planes): Remove; unused.
7899 * dispextern.h (x_screen_planes): Remove decl.
7900
5bf46f05
PE
7901 * dispnew.c: Make symbols static if they're not exported.
7902 * dispextern.h (redraw_garbaged_frames, scrolling):
7903 (increment_row_positions): Remove.
7904 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7905 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7906 Now static.
7907 (redraw_garbaged_frames): Remove; unused.
7908
435f4c28
PE
7909 * xfaces.c: Make symbols static if they're not exported.
7910 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7911 Remove decls.
7912 * xterm.h (defined_color): Remove decls.
7913 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7914 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7915 (menu_face_changed_default, defined_color, free_realized_face):
7916 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7917 (ascii_face_of_lisp_face): Remove; unused.
7918
8524aef3
PE
7919 * xdisp.c: Make symbols static if they're not exported.
7920 * dispextern.h (scratch_glyph_row, window_box_edges):
7921 (glyph_to_pixel_coords, set_cursor_from_row):
7922 (get_next_display_element, set_iterator_to_next):
7923 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7924 (show_mouse_face): Remove decls
7925 * frame.h (message_buf_print): Likewise.
7926 * lisp.h (pop_message, set_message, check_point_in_composition):
7927 Likewise.
7928 * xterm.h (set_vertical_scroll_bar): Likewise.
7929 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7930 (message_buf_print, scratch_glyph_row, displayed_buffer):
7931 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7932 (get_next_display_element, show_mouse_face, window_box_edges):
7933 (frame_to_window_pixel_xy, check_point_in_composition):
7934 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7935 (glyph_to_pixel_coords): Remove; unused.
7936
16390cd2
PE
7937 * dired.c (file_name_completion): Now static.
7938
7939 * dbusbind.c (xd_in_read_queued_messages): Now static.
7940
a25f4dfa
PE
7941 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7942 * data.c (circular_list_error): Remove.
7943
14a9c8df
PE
7944 * commands.h (last_point_position, last_point_position_buffer):
7945 (last_point_position_window): Remove decls.
7946 * keyboard.c: Make these variables static.
7947
04f2d78b
CB
7948 * coding.h (coding, code_convert_region, encode_coding_gap):
7949 Remove decls.
74ab6df5
PE
7950 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7951 (iso_code_class, detect_coding, code_convert_region): Now static.
7952 (encode_coding_gap): Remove; unused.
7953
38dfbee1
PE
7954 * chartab.c (chartab_chars, chartab_bits): Now static.
7955
a2cb4e63
PE
7956 * charset.h (charset_iso_8859_1): Remove decl.
7957 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7958 Now static.
7959
127198fd
PE
7960 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7961 * ccl.c (Vccl_program_table): Now static.
7962 (check_ccl_update): Remove; unused.
7963
d85b608f
PE
7964 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7965 * category.h: ... from here.
7966 * category.c (check_category_table, set_category_set): Now static.
7967
31cd66f3
PE
7968 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7969 * lisp.h: Remove these decls.
7970
c358e587
PE
7971 * buffer.c (buffer_count): Remove unused var.
7972
e78aecca
PE
7973 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7974 so that it's not optimized away.
7975 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7976 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7977 exported only to the debugger.
7978
e192d7d3 7979 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7980 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7981
92470028
PE
7982 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7983 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7984 was inaccessible from Lisp.
7985 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7986 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7987
244ed907
PE
7988 alloc.c: Import and export fewer symbols, and remove unused items.
7989 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7990 is defined.
7991 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7992 it's not optimized away by whole-program optimization.
7993 (message_enable_multibyte, free_misc): Remove.
7994 (catchlist, handlerlist, mark_backtrace):
7995 Declare only if BYTE_MARK_STACK.
7996 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7997 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7998 (message_enable_multibyte): Remove decl.
7999 (free_misc, interval_free_list, float_block, float_block_index):
8000 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8001 (cons_free_list, last_marked_index):
8002 Now static.
8003 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8004 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8005 (mark_backtrace): Define only if BYTE_MARK_STACK.
8006 * xdisp.c (message_enable_multibyte): Now static.
8007
61c2b50e 8008 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8009 This makes it easier for human readers (and static analyzers)
8010 to see whether these variables are used from other modules.
8011 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8012 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8013 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8014 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8015 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8016 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8017 * xmenu.c, xselect.c:
8018 Declare Q* vars static if they are not used in other modules.
8019 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8020 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8021 Remove decls of unexported vars.
8022 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8023
95c82688
PE
8024 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8025
16a97296
PE
8026 Make Emacs functions such as Fatom 'static' by default.
8027 This makes it easier for human readers (and static analyzers)
8028 to see whether these functions can be called from other modules.
8029 DEFUN now defines a static function. To make the function external
8030 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8031 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8032 (Finit_image_library):
16a97296
PE
8033 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8034 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8035 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8036 Remove decls, since these functions are now static.
8037 (Funintern, Fget_internal_run_time): New decls, since these functions
8038 were already external.
95c82688 8039
16a97296
PE
8040 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8041 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8042 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8043 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8044 * keyboard.c, keymap.c, lread.c:
8045 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8046 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8047 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8048 Mark functions with DEFUE instead of DEFUN,
8049 if they are used in other modules.
8050 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8051 decls for now-static functions.
8052 * buffer.h (Fdelete_overlay): Remove decl.
8053 * callproc.c (Fgetenv_internal): Mark as internal.
8054 * composite.c (Fremove_list_of_text_properties): Remove decl.
8055 (Fcomposition_get_gstring): New forward static decl.
8056 * composite.h (Fcomposite_get_gstring): Remove decl.
8057 * dired.c (Ffile_attributes): New forward static decl.
8058 * doc.c (Fdocumntation_property): New forward static decl.
8059 * eval.c (Ffetch_bytecode): New forward static decl.
8060 (Funintern): Remove extern decl; now in .h file where it belongs.
8061 * fileio.c (Fmake_symbolic_link): New forward static decl.
8062 * image.c (Finit_image_library): New forward static decl.
8063 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8064 * intervals.h (Fprevious_property_change):
8065 (Fremove_list_of_text_properties): Remove decls.
8066 * keyboard.c (Fthis_command_keys): Remove decl.
8067 (Fcommand_execute): New forward static decl.
8068 * keymap.c (Flookup_key): New forward static decl.
8069 (Fcopy_keymap): Now static.
8070 * keymap.h (Flookup_key): Remove decl.
8071 * process.c (Fget_process): New forward static decl.
8072 (Fprocess_datagram_address): Mark as internal.
8073 * syntax.c (Fsyntax_table_p): New forward static decl.
8074 (skip_chars): Remove duplicate decl.
8075 * textprop.c (Fprevious_property_change): New forward static decl.
8076 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8077 Now internal.
8078 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8079 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8080
785bbd42
PE
8081 * editfns.c (Fformat): Remove unreachable code.
8082
8b913b57
AS
80832011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8084
8085 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8086 change. (Bug#8496)
8087
a6744a35
EZ
80882011-04-13 Eli Zaretskii <eliz@gnu.org>
8089
8090 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8091 when at ZV. (Bug#8487)
8092
e7974947
AS
80932011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8094
baad03f0
AS
8095 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8096 (Bug#8437)
8097 * keyboard.c (parse_tool_bar_item): Likewise.
8098 * sound.c (sound_cleanup, alsa_close): Likewise.
8099 * termcap.c (tgetent): Likewise.
8100 * xfns.c (x_default_font_parameter): Likewise.
8101 * xsettings.c (read_and_apply_settings): Likewise.
8102
e7974947
AS
8103 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8104 (overrun_check_free): Protoize.
8105
28272684
PE
81062011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8107
8108 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8109 since callers should never pass a negative size.
8110 Change the signature to match that of plain 'read' and 'write'; see
8111 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8112 * lisp.h: Update prototypes of emacs_write and emacs_read.
8113
11997c76
EZ
81142011-04-11 Eli Zaretskii <eliz@gnu.org>
8115
8116 * xdisp.c (redisplay_window): Don't try to determine the character
8117 position of the scroll margin if the window start point w->startp
e896f03c 8118 is outside the buffer's accessible region. (Bug#8468)
11997c76 8119
8a2cbd72
EZ
81202011-04-10 Eli Zaretskii <eliz@gnu.org>
8121
8122 Fix write-region and its subroutines for buffers > 2GB.
8123 * fileio.c (a_write, e_write): Modify declaration of arguments and
8124 local variables to support buffers larger than 2GB.
8125 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8126
8127 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8128 argument, local variables, and return value.
8129
8130 * lisp.h: Update prototypes of emacs_write and emacs_read.
8131
8132 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8133
4073e537 81342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8135
1ebfdcb6
PE
8136 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8137
b2ded58d
PE
8138 Fix more problems found by GCC 4.6.0's static checks.
8139
7d66342c
PE
8140 * xdisp.c (vmessage): Use a better test for character truncation.
8141
bbf47d44
PE
8142 * charset.c (load_charset_map): <, not <=, for optimization,
8143 and to avoid potential problems with integer overflow.
9248994d 8144 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8145 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8146 * editfns.c (Fformat): Likewise.
1e69125e 8147 * syntax.c (skip_chars): Likewise.
3befa583 8148
e3019616
PE
8149 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8150 This also lets GCC 4.6.0 generate slightly better loop code.
8151
becfa255
PE
8152 * callint.c (Fcall_interactively): <, not <=, for optimization.
8153 (Fcall_interactively): Count the number of arguments produced,
8154 not the number of arguments given. This is simpler and lets GCC
8155 4.6.0 generate slightly better code.
8156
dae0cd48
PE
8157 * ftfont.c: Distingish more carefully between FcChar8 and char.
8158 The previous code passed unsigned char * to a functions like
8159 strlen and xstrcasecmp that expect char *, which does not
8160 conform to the C standard.
8161 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8162 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8163 char * when the C standard requires it.
8164
76032d70
PE
8165 * keyboard.c (read_char): Remove unused var.
8166
eb3f1cc8
PE
8167 * eval.c: Port to Windows vsnprintf (Bug#8435).
8168 Include <limits.h>.
8169 (SIZE_MAX): Define if the headers do not.
8170 (verror): Do not give up if vsnprintf returns a negative count.
8171 Instead, grow the buffer. This ports to Windows vsnprintf, which
8172 does not conform to C99. Problem reported by Eli Zaretskii.
8173 Also, simplify the allocation scheme, by avoiding the need for
8174 calling realloc, and removing the ALLOCATED variable.
8175
70476b54
PE
8176 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8177
12020a9e
PE
8178 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8179 But keep the doprint source code for now, as we might revamp it
8180 and use it again (Bug#8435).
ea6c7ae6
PE
8181 * lisp.h (doprnt): Remove.
8182 * Makefile.in (base_obj): Remove doprnt.o.
8183 * deps.mk (doprnt.o): Remove.
8184
5fdb398c
PE
8185 error: Print 32- and 64-bit integers portably (Bug#8435).
8186 Without this change, on typical 64-bit hosts error ("...%d...", N)
8187 was used to print both 32- and 64-bit integers N, which relied on
8188 undefined behavior.
61bdb816 8189 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8190 * lisp.h (error, verror): Mark as printf-like functions.
8191 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8192 Report overflow in size calculations when allocating printf buffer.
8193 Do not truncate output string at its first null byte.
8194 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8195 Truncate the output at a character boundary, since vsnprintf does not
8196 do that.
8197 * charset.c (check_iso_charset_parameter): Convert internal
8198 character to string before calling 'error', since %c now has the
8199 printf meaning.
8200 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8201 overflow when computing char to be passed to 'error'. Do not
8202 pass Lisp_Object to 'error'; pass the integer instead.
8203 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8204 formatted with plain %d.
8205
b189fa66
PE
8206 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8207
bff87ef0
PE
8208 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8209
7e2cac20
PE
8210 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8211
ce4d90b5
PE
8212 * xterm.c (x_catch_errors): Remove duplicate declaration.
8213
266c9547
PE
8214 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8215
79c49ad2
PE
8216 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8217
368f4090
JM
82182011-04-10 Jim Meyering <meyering@redhat.com>
8219
8220 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8221 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8222 return ssize_t not "int", and use size_t as the buffer length.
8223 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8224 * gnutls.h: Update declarations.
8225 * process.c (read_process_output): Use ssize_t, to match.
8226 (send_process): Likewise.
8227
a32d4040
CY
82282011-04-09 Chong Yidong <cyd@stupidchicken.com>
8229
8230 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8231
8546720e 82322011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8233
04f2d78b
CB
8234 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8235 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8236
8546720e
GM
8237 * xterm.c (handle_one_xevent):
8238 * xmenu.c (create_and_show_popup_menu):
8239 * xselect.c (x_decline_selection_request)
8240 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8241
0a2f5c1a 82422011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8243
8244 Fix some uses of `int' instead of EMACS_INT.
8245 * search.c (string_match_1, fast_string_match)
8246 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8247 (scan_buffer, find_next_newline_no_quit)
8248 (find_before_next_newline, search_command, Freplace_match)
8249 (Fmatch_data): Make some `int' variables be EMACS_INT.
8250
8251 * xdisp.c (display_count_lines): 3rd argument and return value now
8252 EMACS_INT. All callers changed.
8253 (pint2hrstr): Last argument is now EMACS_INT.
8254
8255 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8256 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8257 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8258 (decode_coding_utf_16, decode_coding_emacs_mule)
8259 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8260 (decode_coding_ccl, decode_coding_charset)
8261 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8262 (decode_coding_iso_2022, decode_coding_emacs_mule)
8263 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8264 <char_offset, last_offset>: Declare EMACS_INT.
8265 (encode_coding_utf_8, encode_coding_utf_16)
8266 (encode_coding_emacs_mule, encode_invocation_designation)
8267 (encode_designation_at_bol, encode_coding_iso_2022)
8268 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8269 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8270 Declare EMACS_INT.
8271 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8272 (encode_invocation_designation): Last argument P_NCHARS is now
8273 EMACS_INT.
8274 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8275 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8276
8277 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8278 All users changed.
8279
8280 * ccl.c (Fccl_execute_on_string): Declare some variables
8281 EMACS_INT.
8282
8546720e 82832011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8284
8285 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8286
4e19a977
CS
82872011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8288
8289 * process.c (Fformat_network_address): Doc fix.
8290
87302331
R
82912011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8292
ee7683eb 8293 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8294
cbb59342
CY
82952011-04-08 Chong Yidong <cyd@stupidchicken.com>
8296
8297 * keyboard.c (read_char): Call Lisp function help-form-show,
8298 instead of using internal_with_output_to_temp_buffer.
8299 (Qhelp_form_show): New var.
e0d38eeb 8300 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8301
8302 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8303
8304 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8305
e67a13ab
CY
83062011-04-06 Chong Yidong <cyd@stupidchicken.com>
8307
04f2d78b
CB
8308 * process.c (Flist_processes): Remove to Lisp.
8309 (list_processes_1): Delete.
e67a13ab 8310
973f782d
EZ
83112011-04-06 Eli Zaretskii <eliz@gnu.org>
8312
7c106b1e
EZ
8313 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8314
973f782d
EZ
8315 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8316
41cf7d1a 83172011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8318
ca23cc88
PE
8319 Fix more problems found by GCC 4.6.0's static checks.
8320
f390e2d5
PE
8321 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8322
42eea0d0
PE
8323 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8324
b69769da 8325 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8326
f9541e84
PE
8327 * xdisp.c (vmessage): Mark as a printf-like function.
8328
13841b55
PE
8329 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8330
c136c10f
PE
8331 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8332
5e2d4a30
PE
8333 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8334 printf-like functions.
8335 (tiff_load): Add casts to remove these marks before passing them
8336 to system-supplied API.
8337
583f48b9
PE
8338 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8339
b25d760e
PE
8340 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8341 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8342 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8343 directly, rather than having caller test rule sign. This avoids
8344 some unnecessary tests.
8345 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8346 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8347 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8348
bc7b6697 8349 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8350 (xfont_open): Avoid unnecessary tests.
bc7b6697 8351
27ccc379
PE
8352 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8353
dcd5c89a
PE
8354 * composite.h, composite.c (composition_gstring_put_cache):
8355 Use EMACS_INT, not int, for length.
8356
b13a45c6
PE
8357 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8358 breaking out part of COMPOSITION_DECODE_RULE.
8359 (COMPOSITION_DECODE_RULE): Use it.
8360 * composite.c (get_composition_id): Remove unused local vars,
8361 by using the new macro.
8362
1e792e4d
PE
8363 * textprop.c (set_text_properties_1): Change while to do-while,
8364 since the condition is always true at first.
8365
dc6c6455 8366 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8367 (interval_deletion_adjustment): Return unsigned value.
8368 All uses changed.
dc6c6455 8369
aba7731a
PE
8370 * process.c (list_processes_1, create_pty, read_process_output):
8371 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8372 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8373 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8374 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8375 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8376
fdfc4bf3
PE
8377 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8378
fca8fe46 8379 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8380 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8381
06a0259a 8382 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8383 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8384 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8385
e7b9e80f
PE
8386 * print.c (print_error_message): Avoid int overflow.
8387
56201685
PE
8388 * font.c (font_list_entities): Redo for clarity,
8389 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8390
78834453 8391 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8392 (font_score): Avoid potential overflow in diff calculation.
78834453 8393
0bc0b309 8394 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8395 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8396
e610eaca
PE
8397 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8398
b895abce
PE
8399 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8400 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8401 can always succeed if overflow has undefined behavior.
8402
1f1d9321 8403 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8404 (wordify): Omit three unnecessary tests.
1f1d9321 8405
c59478bc
PE
8406 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8407 All callers changed. This avoids the need for an unused var.
8408
79b73827
PE
8409 * casefiddle.c (casify_region): Remove var that is set but not used.
8410
a4db5dfe
PE
8411 * dired.c (file_name_completion): Remove var that is set but not used.
8412
43aae36e
PE
8413 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8414
2a47c44d 8415 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8416 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8417
a37c69bf
PE
8418 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8419 Check for integer overflow on size calculations.
8420
328ab8e7
PE
8421 * buffer.c (Fprevious_overlay_change): Remove var that is set
8422 but not used.
8423
e5a2a5cb
PE
8424 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8425 Remove vars that are set but not used.
8d84a6eb 8426 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8427 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8428
a60e5f68
PE
8429 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8430
f661cb61 8431 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8432 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8433
f0397f5a
PE
8434 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8435 that are set but not used.
8436
8664db06 8437 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8438 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8439
6abdaa4a
PE
8440 * xselect.c (x_get_local_selection, x_handle_property_notify):
8441 Remove vars that are set but not used.
8442
0ce7538d 8443 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8444 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8445
9ae848fc
PE
8446 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8447 Remove var that is set but not used.
0b918413
PE
8448 (scroll_bar_windows_size): Now size_t, not int.
8449 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8450 Check for overflow.
9ae848fc 8451
a5a62657
PE
8452 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8453 (map_tty_color) [!defined MSDOS]: Likewise.
8454
5c5cdd39
PE
8455 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8456
66ebf983
PE
8457 * coding.c: Remove vars that are set but not used.
8458 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8459 All callers changed.
8460 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8461 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8462 (decode_coding_charset): Remove vars that are set but not used.
8463
1be4d761
PE
8464 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8465 that is set but not used.
8466
47553fa8
PE
8467 * print.c (print_object): Remove var that is set but not used.
8468
1f7196bf 8469 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8470 The gnulib version avoids calling malloc in the usual case,
8471 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8472 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8473 * filelock.c (current_lock_owner): Likewise.
8474 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8475 * sysdep.c: Include allocator.h, careadlinkat.h.
8476 (emacs_no_realloc_allocator): New static constant.
8477 (emacs_readlink): New function.
fdb61804
PE
8478 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8479 ../lib/careadlinkat.h.
d1fdcab7 8480
f84c17c7
SM
84812011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8482
8483 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8484 first non-nil return value).
8485
ef3862ad
JD
84862011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8487
8488 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8489 if not defined (Bug#8403).
8490
376a7006
JB
84912011-04-02 Juanma Barranquero <lekktu@gmail.com>
8492
8493 * xdisp.c (display_count_lines): Remove parameter `start',
8494 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8495 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8496 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8497 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8498 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8499 and thereabouts. All callers changed.
8500 (get_per_char_metric): Remove parameter `f', unused since
8501 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8502
6ca3801d
JM
85032011-04-02 Jim Meyering <meyering@redhat.com>
8504
8505 do not dereference NULL upon failed strdup
8506 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8507 (ns_get_family): Likewise.
8508
d8e2b5ba
JB
85092011-04-02 Juanma Barranquero <lekktu@gmail.com>
8510
8511 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8512
8c74fcbd
JD
85132011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8514
8515 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8516 later (Bug#8403).
8517
7200d79c
SM
85182011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8519
03408648 8520 Add lexical binding.
7200d79c 8521
03408648
SM
8522 * window.c (Ftemp_output_buffer_show): New fun.
8523 (Fsave_window_excursion):
8524 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8525
8526 * lread.c (lisp_file_lexically_bound_p): New function.
8527 (Fload): Bind Qlexical_binding.
8528 (readevalloop): Remove `evalfun' arg.
8529 Bind Qinternal_interpreter_environment.
8530 (Feval_buffer): Bind Qlexical_binding.
8531 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8532 Mark as dynamic.
8533 (syms_of_lread): Declare `lexical-binding'.
8534
8535 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8536
8537 * keyboard.c (eval_dyn): New fun.
8538 (menu_item_eval_property): Use it.
ca105506
SM
8539
8540 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8541
03408648
SM
8542 * fns.c (concat, mapcar1): Accept byte-code-functions.
8543
8544 * eval.c (Fsetq): Handle lexical vars.
8545 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8546 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8547 (FletX, Flet): Obey lexical binding.
8548 (Fcommandp): Handle closures.
8549 (Feval): New `lexical' arg.
8550 (eval_sub): New function extracted from Feval. Use it almost
8551 everywhere where Feval was used. Look up vars in lexical env.
8552 Handle closures.
8553 (Ffunctionp): Move from subr.el.
8554 (Ffuncall): Handle closures.
8555 (apply_lambda): Remove `eval_flags'.
8556 (funcall_lambda): Handle closures and new byte-code-functions.
8557 (Fspecial_variable_p): New function.
8558 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8559 but without exporting it to Lisp.
23aba0ea 8560
23aba0ea 8561 * doc.c (Fdocumentation, store_function_docstring):
03408648 8562 * data.c (Finteractive_form): Handle closures.
23aba0ea 8563
03408648
SM
8564 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8565 interactive spec.
ba83908c 8566
04f2d78b
CB
8567 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8568 New byte-codes.
03408648
SM
8569 (exec_byte_code): New function extracted from Fbyte_code to handle new
8570 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8571
03408648 8572 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8573
03408648 8574 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8575
e2abce01
JB
85762011-03-31 Juanma Barranquero <lekktu@gmail.com>
8577
8578 * xdisp.c (redisplay_internal): Fix prototype.
8579
63696a73 85802011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8581
63696a73 8582 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8583 (try_scrolling): Use it when setting scroll_limit.
8584 Limit scrolling to 100 screen lines.
63696a73
EZ
8585 (redisplay_window): Even when falling back on "recentering",
8586 position point in the window according to scroll-conservatively,
8587 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8588
8589 (try_scrolling): When point is above the window, allow searching
8590 as far as scroll_max, or one screenful, to compute vertical
8591 distance from PT to the scroll margin position. This prevents
8592 try_scrolling from unnecessarily failing when
8593 scroll-conservatively is set to a value slightly larger than the
8594 window height. Clean up the case of PT below the margin at bottom
8595 of window: scroll_max can no longer be INT_MAX. When aggressive
8596 scrolling is in use, don't let point enter the opposite scroll
8597 margin as result of the scroll.
8598 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8599 threshold of 100 lines for never-recentering scrolling.
8600
e4cc2dfc
JB
86012011-03-31 Juanma Barranquero <lekktu@gmail.com>
8602
8603 * dispextern.h (move_it_by_lines):
8604 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8605 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8606 (message_log_check_duplicate): Remove parameters `prev_bol' and
8607 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8608 (redisplay_internal): Remove parameter `preserve_echo_area',
8609 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8610
8611 * indent.c (Fvertical_motion):
8612 * window.c (window_scroll_pixel_based, Frecenter):
8613 Don't pass `need_y_p' to `move_it_by_lines'.
8614
1c470562
SM
86152011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8616
44f230aa
SM
8617 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8618 steal a few bits to be more compact.
8619 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8620 Remove unneeded casts.
8621
1c470562
SM
8622 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8623
888adce9
ZK
86242011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8625
8626 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8627 binding" message (bug#7967).
8628
f838ed7b
PE
86292011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8630
77861b95
PE
8631 Fix more problems found by GCC 4.6.0's static checks.
8632
de6dbc14
PE
8633 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8634 Remove unused local var.
8635
f838ed7b
PE
8636 * editfns.c (Fmessage_box): Remove unused local var.
8637
792c7b2b
PE
8638 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8639 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8640 Omit unused local vars.
c499e557 8641 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8642 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8643 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8644 Omit unused local var.
8645
ba0165e1
PE
8646 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8647 Don't assume string length fits in int.
32ad8845 8648 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8649 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8650
3c59b4c9
PE
8651 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8652 instead of alloca (Bug#8344).
8653
a3eed478 8654 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8655 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8656
eb4d412d
PE
8657 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8658
1658b401
PE
8659 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8660 concerns.
8661
8662 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8663
8664 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8665
9a2c6e05
PE
8666 * keyboard.c (syms_of_keyboard): Use the same style as later
8667 in this function when indexing through an array. This also
8668 works around GCC bug 48267.
8669
03d0a109
PE
8670 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8671
44f730c8
PE
8672 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8673
fe75f926
PE
8674 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8675 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8676
ffa8c828
PE
8677 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8678 This avoids undefined behavior on integer overflow, and is a bit
8679 more convenient anyway since it is compared to a size_t variable.
8680
c5101a77
PE
8681 Variadic C functions now count arguments with size_t, not int.
8682 This avoids an unnecessary limitation on 64-bit machines, which
8683 caused (substring ...) to crash on large vectors (Bug#8344).
8684 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8685 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8686 All variadic functions and their callers changed accordingly.
c5101a77
PE
8687 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8688 * data.c (arith_driver, float_arith_driver): Likewise.
8689 * editfns.c (general_insert_function): Likewise.
8690 * eval.c (struct backtrace.nargs, interactive_p)
8691 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8692 (funcall_lambda, mark_backtrace): Likewise.
8693 * fns.c (concat): Likewise.
8694 * frame.c (x_set_frame_parameters): Likewise.
8695 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8696 0 if not found, not -1. All callers changed.
8697
dd3f25f7
PE
8698 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8699 (stack_copy_size): Now size_t, not int.
8700 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8701
461c2ab9
JB
87022011-03-28 Juanma Barranquero <lekktu@gmail.com>
8703
8704 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8705 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8706 All callers changed.
8707
8708 * lisp.h (multibyte_char_to_unibyte):
8709 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8710 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8711 * character.h (CHAR_TO_BYTE8):
8712 * cmds.c (internal_self_insert):
8713 * editfns.c (general_insert_function):
8714 * keymap.c (push_key_description):
8715 * search.c (Freplace_match):
8716 * xdisp.c (message_dolog, set_message_1): All callers changed.
8717
f6d62986
SM
87182011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8719
8720 * keyboard.c (safe_run_hook_funcall): New function.
8721 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8722 don't set the hook to nil, but remove the offending function instead.
8723 (Qcommand_hook_internal): Remove, unused.
8724 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8725 Vcommand_hook_internal.
8726
8727 * eval.c (enum run_hooks_condition): Remove.
8728 (funcall_nil, funcall_not): New functions.
8729 (run_hook_with_args): Call each function through a `funcall' argument.
8730 Remove `cond' argument, now redundant.
8731 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8732 (Frun_hook_with_args_until_failure): Adjust accordingly.
8733 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8734
1db5b1ad
JB
87352011-03-28 Juanma Barranquero <lekktu@gmail.com>
8736
8737 * dispextern.h (string_buffer_position): Remove declaration.
8738
8739 * print.c (strout): Remove parameter `multibyte', unused since
8740 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8741
8742 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8743 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8744 All callers changed.
8745
8746 * w32.c (_wsa_errlist): Use braces for struct initializers.
8747
8748 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8749 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8750 All callers changed.
8751 (string_buffer_position): Likewise. Also, make static (it's never
8752 used outside xdisp.c).
8753 (cursor_row_p): Remove parameter `w', unused since
8754 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8755 (decode_mode_spec): Remove parameter `precision', introduced during
8756 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8757 All callers changed.
8758
5ffb62aa
JD
87592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8760
8761 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8762
461c2ab9 87632011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8764
8765 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8766 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8767 (ns_update_auto_hide_menu_bar): New functions.
8768 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8769 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8770 ns_constrain_all_frames.
8771 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8772 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8773
5c380ffb
JD
87742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8775
8776 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8777
9af30bdf
GM
87782011-03-27 Glenn Morris <rgm@gnu.org>
8779
8780 * syssignal.h: Replace RETSIGTYPE with void.
8781 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8782 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8783 Replace SIGTYPE with void everywhere.
8784 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8785 * s/template.h (SIGTYPE): Remove commented out definition.
8786
e2abce01
JB
87872011-03-26 Eli Zaretskii <eliz@gnu.org>
8788
8789 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8790 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8791
f868cd8a
JB
87922011-03-26 Juanma Barranquero <lekktu@gmail.com>
8793
59eb0929
JB
8794 * w32.c (read_unc_volume): Use parameter `henum', instead of
8795 global variable `wget_enum_handle'.
8796
8797 * keymap.c (describe_vector): Remove parameters `indices' and
8798 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8799 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8800
f868cd8a
JB
8801 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8802
8803 * keyboard.c (timer_check): Remove parameter `do_it_now',
8804 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8805 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8806 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8807
8808 * keyboard.c (read_char):
8809 * w32menu.c (w32_menu_display_help):
8810 * xmenu.c (show_help_event, menu_help_callback):
8811 Adjust calls to `show_help_echo'.
8812
8813 * gtkutil.c (xg_maybe_add_timer):
8814 * keyboard.c (readable_events):
8815 * process.c (wait_reading_process_output):
8816 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8817
8818 * insdel.c (adjust_markers_gap_motion):
8819 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8820 (gap_left, gap_right): Don't call it.
8821
2ecf6fdb
CY
88222011-03-25 Chong Yidong <cyd@stupidchicken.com>
8823
8824 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8825 incurred during fontification.
8826
6b1f9ba4
JB
88272011-03-25 Juanma Barranquero <lekktu@gmail.com>
8828
8829 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8830 (DEFVAR_PER_BUFFER): Don't pass it.
8831
8832 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8833 (scrolling_window): Don't pass it.
8834
0f4a96b5
JB
88352011-03-25 Juanma Barranquero <lekktu@gmail.com>
8836
8837 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8838
8839 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8840 and `suffix'.
8841 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8842 of variables specific to SELinux and computation of `encoded_absname'.
8843
8844 * image.c (XPutPixel): Remove unused variable `height'.
8845
8846 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8847
8848 * unexw32.c (get_section_info): Remove unused variable `section'.
8849
8850 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8851 (system_process_attributes): Remove unused variable `sess'.
8852 (sys_read): Remove unused variable `err'.
8853
8854 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8855 (w32_wnd_proc): Remove unused variable `isdead'.
8856 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8857 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8858 (x_create_tip_frame): Remove unused variable `tem'.
8859
8860 * w32inevt.c (w32_console_read_socket):
8861 Remove unused variable `no_events'.
8862
8863 * w32term.c (x_draw_composite_glyph_string_foreground):
8864 Remove unused variable `width'.
8865
1149507c
JB
88662011-03-24 Juanma Barranquero <lekktu@gmail.com>
8867
8868 * w32term.c (x_set_glyph_string_clipping):
8869 Don't pass uninitialized region to CombineRgn.
8870
9c88f339
JB
88712011-03-23 Juanma Barranquero <lekktu@gmail.com>
8872
8873 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8874 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8875 (Fx_close_connection): Remove unused variable `i'.
8876
8877 * w32font.c (w32font_draw): Return number of glyphs.
8878 (w32font_open_internal): Remove unused variable `i'.
8879 (w32font_driver): Add missing initializer.
8880
8881 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8882 (fill_in_menu): Remove unused variable `items_added'.
8883
8884 * w32term.c (last_mouse_press_frame): Remove static global variable.
8885 (w32_clip_to_row): Remove unused variable `f'.
8886 (x_delete_terminal): Remove unused variable `i'.
8887
8888 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8889 (NOTHING): Remove unused static global variable.
8890 (uniscribe_check_otf): Remove unused variable `table'.
8891 (uniscribe_font_driver): Add missing initializers.
8892
dee091a3
JD
88932011-03-23 Julien Danjou <julien@danjou.info>
8894
8895 * term.c (Fsuspend_tty, Fresume_tty):
8896 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8897 * window.c (temp_output_buffer_show):
8898 * insdel.c (signal_before_change):
8899 * frame.c (Fhandle_switch_frame):
8900 * fileio.c (Fdo_auto_save):
8901 * emacs.c (Fkill_emacs):
8902 * editfns.c (save_excursion_restore):
8903 * cmds.c (internal_self_insert):
8904 * callint.c (Fcall_interactively):
8905 * buffer.c (Fkill_all_local_variables):
8906 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8907 Use Frun_hooks.
0f4a96b5 8908 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8909 unconditionally since it does the check itself.
dee091a3 8910
2c520ab5 89112011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8912
c9c49752
PE
8913 Fix more problems found by GCC 4.5.2's static checks.
8914
8abc3f12
PE
8915 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8916 the first time through the loop, since we know p0 < p1 then.
8917 This also avoids a gcc -Wstrict-overflow warning.
8918
a2d26660
PE
8919 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8920 leading to a memory leak, possible in functions like
8921 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8922 of objects (Bug#8318).
a2d26660 8923
916c72e9
PE
8924 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8925 that could (at least in theory) be that large.
8926
19ab8a18
PE
8927 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8928 This is less likely to overflow, and avoids undefined behavior if
8929 overflow does occur. All callers changed. Use strtoul to scan
8930 for the unsigned long integer.
b7cbbd6f
PE
8931 (pint2hrstr): Simplify and tune code slightly.
8932 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8933
f0641eff
PE
8934 * scroll.c (do_scrolling): Work around GCC bug 48228.
8935 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8936
7f650bb9
PE
8937 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8938 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8939 (validate_x_resource_name): Simplify count usage.
8940 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8941
37dd57d1
PE
8942 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8943 fail (Bug#8306).
81e56e61 8944
699979fc 8945 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8946
401bf9b4
PE
8947 * process.c (Fmake_network_process): Use socklen_t, not int,
8948 where POSIX says socklen_t is required in portable programs.
8949 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8950 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8951 (Fmake_network_process, server_accept_connection):
8952 (wait_reading_process_output, read_process_output):
8953 Likewise.
8954
b93aacde
PE
8955 * process.c: Rename or move locals to avoid shadowing.
8956 (list_processes_1, Fmake_network_process):
8957 (read_process_output_error_handler, exec_sentinel_error_handler):
8958 Rename or move locals.
4dc343ee 8959 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8960 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8961 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8962 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8963 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8964
af8a867c 8965 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8966 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8967 Include tparam.h instead, since it declares them.
af8a867c
PE
8968 * cm.h (PC): Remove extern decl; tparam.h now does this.
8969 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8970 * terminfo.c: Include tparam.h, to check interfaces.
8971 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8972 (tparam): Adjust signature to match interface in tparam.h;
8973 this removes some undefined behavior. Check that outstring and len
8974 are zero, which they always are with Emacs.
8975 * tparam.h (PC, BC, UP): New extern decls.
8976
0248044d 8977 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8978 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8979
8ff096c1 8980 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8981 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8982 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8983 (ftfont_list): Remove unused local.
49eaafba
PE
8984 (get_adstyle_property, ftfont_pattern_entity):
8985 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8986 Rename locals to avoid shadowing.
8ff096c1 8987
e2be39f6
PE
8988 * xfont.c (xfont_list_family): Mark var as initialized.
8989
c9735e30
PE
8990 * xml.c (make_dom): Now static.
8991
8f5201ae
PE
8992 * composite.c (composition_compute_stop_pos): Rename local to
8993 avoid shadowing.
b246f932
PE
8994 (composition_reseat_it): Remove unused locals.
8995 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8996 (composition_update_it): Mark var as initialized.
11b61122
PE
8997 (find_automatic_composition): Mark vars as initialized,
8998 with a FIXME (Bug#8290).
8f5201ae 8999
760fbc2c
PE
9000 character.h: Rename locals to avoid shadowing.
9001 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9002 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9003 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9004 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9005 to avoid shadowing.
9006
ff08eb85
PE
9007 * textprop.c (property_change_between_p): Remove; unused.
9008
fc7bf025
PE
9009 * intervals.c (interval_start_pos): Now static.
9010
235d7abc
PE
9011 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9012
44f230aa
SM
9013 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9014 Rename locals to avoid shadowing.
3e7d6594 9015
50060332
PE
9016 * sound.c (wav_play, au_play, Fplay_sound_internal):
9017 Fix pointer signedness.
d01f234b 9018 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9019 (wav_play): Initialize a variable to 0, to prevent undefined
9020 behavior (Bug#8278).
50060332 9021
c4fc4e30
PE
9022 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9023
918436ed
PE
9024 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9025
c939f91b
PE
9026 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9027 clobbering (Bug#8298).
b9c7f648
PE
9028 * sysdep.c (sys_subshell): Likewise.
9029 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9030
6bd8c144
PE
9031 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9032 This should get cleaned up, so that child_setup has the
9033 same signature on all platforms.
9034
7710357c 9035 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9036 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9037
c59da222
CY
90382011-03-22 Chong Yidong <cyd@stupidchicken.com>
9039
9040 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9041 not to be necessary, and produces flickering.
9042
66b87493
GM
90432011-03-20 Glenn Morris <rgm@gnu.org>
9044
9045 * config.in: Remove file.
9046
45b6f6d5
JB
90472011-03-20 Juanma Barranquero <lekktu@gmail.com>
9048
9049 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9050 are now in src/globals.h.
9051 (syms_of_minibuf): Remove spurious & from previous change.
9052
cd394be1 90532011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9054
9055 * minibuf.c (completing-read-function): New variable.
9056 (completing-read-default): Rename from completing-read.
9057 (completing-read): Call completing-read-function.
9058
b14e3e21
CY
90592011-03-19 Juanma Barranquero <lekktu@gmail.com>
9060
9061 * xfaces.c (Fx_load_color_file):
9062 Read color file from absolute filename (bug#8250).
9063
f2b726e6
JB
90642011-03-19 Juanma Barranquero <lekktu@gmail.com>
9065
9066 * makefile.w32-in: Update dependencies.
9067
09f6ff02
EZ
90682011-03-17 Eli Zaretskii <eliz@gnu.org>
9069
9070 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9071
29a6015a
PE
90722011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9073
a3a6c54e
PE
9074 Fix more problems found by GCC 4.5.2's static checks.
9075
b766f867
PE
9076 * process.c (make_serial_process_unwind, send_process_trap):
9077 (sigchld_handler): Now static.
9078
be02381c
PE
9079 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9080 That way, the code declares only the vars that it needs.
9081 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9082 * s/cygwin.h (PTY_ITERATION): Likewise.
9083 * s/darwin.h (PTY_ITERATION): Likewise.
9084 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9085
57048744
PE
9086 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9087 * process.c (allocate_pty): Don't declare stb unless it's needed.
9088
7914961c 9089 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9090 (CONSTANTLIM): Remove; unused.
9091 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9092 Define only if needed.
7914961c 9093
b3967b18
PE
9094 * unexelf.c (unexec): Name an expression,
9095 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9096 Use a different way to cause a compilation error if anyone uses
9097 n rather than nn, a way that does not involve shadowing.
73366a00 9098 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9099
29a6015a
PE
9100 * deps.mk (unexalpha.o): Remove; unused.
9101
43cfc33e 9102 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9103 * unexec.h: New file.
ce701a33
PE
9104 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9105 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9106 Depend on unexec.h.
9107 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9108 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9109 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9110 Change as necessary to match prototype in unexec.h.
ce701a33 9111
01f44d5a
PE
9112 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9113 shadowing.
4f63c6bb 9114 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9115
a6670b0b
PE
9116 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9117 Rename locals to avoid shadowing.
9118
cef2010d 9119 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9120 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9121
d4d7173a
PE
9122 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9123
f08b802a
PE
9124 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9125 warning when compiling print.c.
9126
3ddb0639
PE
9127 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9128 instead of using an uninitialized var.
5ad03b97 9129 (font_sort_entities): Mark var as initialized.
3ddb0639 9130
170a2692
PE
9131 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9132
e663c700
PE
9133 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9134 pointers to constants.
89bc529a 9135 (font_parse_fcname): Remove unused vars.
7b81e2d0 9136 (font_delete_unmatched): Now static.
ea838e10 9137 (font_get_spec): Remove; unused.
13a547c6
PE
9138 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9139 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9140 Rename or move locals to avoid shadowing.
e663c700 9141
2a80c887 9142 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9143 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9144
1384fa33 9145 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9146 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9147
8b2c52e9
PE
9148 * alloc.c (mark_backtrace): Move decl from here ...
9149 * lisp.h: ... to here, so that it can be checked.
9150
475545b5 9151 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9152 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9153 (lisp_indirect_variable): Name an expression,
9154 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9155 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9156
b1349114 9157 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9158 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9159 Use const pointer when appropriate.
b1349114 9160
a2928364
PE
9161 * lisp.h (get_system_name, get_operating_system_release):
9162 Move decls here, to check interfaces.
9163 * process.c (get_operating_system_release): Move decl to lisp.h.
9164 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9165 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9166 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9167 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9168 (Fformat_time_string, Fencode_time, Finsert_char):
9169 (Ftranslate_region_internal, Fformat):
9170 Rename or remove local vars to avoid shadowing.
9710023e 9171 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9172
a415e694
PE
9173 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9174 avoid shadowing.
9175
8ef4622d
PE
9176 * lisp.h (eassert): Check that the argument compiles, even if
9177 ENABLE_CHECKING is not defined.
9178
946f9a5b
PE
9179 * data.c (Findirect_variable): Name an expression, to avoid
9180 gcc -Wbad-function-cast warning.
112396d6 9181 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9182 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9183 (Fmake_variable_buffer_local, Fmake_local_variable):
9184 Mark variables as initialized.
52746918 9185 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9186
e5aab7e7 9187 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9188 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9189 Rename locals to avoid shadowing.
dff45157
PE
9190 (mark_stack): Move local variables into the #ifdef region where
9191 they're used.
7bc26fdb
PE
9192 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9193 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9194 needed otherwise.
9195 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9196 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9197 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9198
e5aab7e7
PE
9199 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9200 avoids undefined behavior in theory.
9201
4da60324
PE
9202 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9203
88043301
PE
9204 Use functions, not macros, for up- and down-casing (Bug#8254).
9205 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9206 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9207 to use the following functions instead of these macros.
9208 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9209 EMACS_INT, since callers assume the returned value fits in int.
9210 (upcase1): Likewise, for UPCASE_TABLE.
9211 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9212 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9213 the race-condition problem in the old DOWNCASE.
88043301 9214
19ed5445
PE
9215 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9216 Rename locals to avoid shadowing.
9217 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9218 (regex_compile, re_search_2, re_match_2_internal):
9219 Remove unused local vars.
952db0d7
PE
9220 (FREE_VAR): Rewrite so as not to use empty "else",
9221 which gcc can warn about.
da053e48 9222 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9223 (RETALLOC_IF): Define only if needed.
9224 (WORDCHAR_P): Likewise. This one is never needed, but is used
9225 only in a comment talking about a compiler bug, so put inside
9226 the #if 0 of that comment.
9227 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9228 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9229 Remove; unused.
19ed5445 9230
1f3561e4 9231 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9232 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9233 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9234
ded6f8f7
PE
9235 * search.c (simple_search): Remove unused var.
9236
dbd37a95
PE
9237 * dired.c (compile_pattern): Move decl from here ...
9238 * lisp.h: ... to here, so that it can be checked.
9239 (struct re_registers): New forward decl.
9240
7e47afad
PE
9241 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9242
85f24f61
PE
9243 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9244 All uses changed.
9245 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9246 Rename locals to avoid shadowing.
5671df8f 9247 (Fvertical_motion): Mark locals as initialized.
85f24f61 9248
181aa2be 9249 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9250 (casify_region): Mark local as initialized.
181aa2be 9251
930d429c
PE
9252 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9253
7082eac6
PE
9254 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9255 New macros, so that the caller can use some names other than
9256 gcpro1, gcpro2, etc.
9257 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9258 of the new macros.
9259 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9260 argument, for consistency with GCPRO2_VAR, etc: it is now the
9261 prefix of the variable, not the variable itself. All uses
9262 changed.
38b2c076
PE
9263 * dired.c (directory_files_internal, file_name_completion):
9264 Rename locals to avoid shadowing.
9265
15206ed9
PE
9266 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9267 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9268 dired.c's scmp function, had undefined behavior.
9269 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9270 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9271 * buffer.h: ... to here, because these macros use current_buffer,
9272 and the new implementation with inline functions needs to have
9273 current_buffer in scope now, rather than later when the macros
9274 are used.
9275 (downcase, upcase1): New static inline functions.
9276 (DOWNCASE, UPCASE1): Reimplement using these functions.
9277 This avoids undefined behavior in expressions like
9278 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9279 from race conditions in accessing the global variables
9280 case_temp1 and case_temp2.
9281 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9282 * lisp.h (case_temp1, case_temp2): Remove their decls.
9283 * character.h (ASCII_CHAR_P): Move from here ...
9284 * lisp.h: ... to here, so that the inline functions mentioned
9285 above can use them.
9286
4a6bea26
PE
9287 * dired.c (directory_files_internal_unwind): Now static.
9288
f14b7e14
PE
9289 * fileio.c (file_name_as_directory, directory_file_name):
9290 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9291 Now static.
2893f146
PE
9292 (file_name_as_directory): Use const pointers when appropriate.
9293 (Fexpand_file_name): Likewise. In particular, newdir might
9294 point at constant storage, so make it a const pointer.
fd4ead52 9295 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9296 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9297 signedness issues.
f839df0c
PE
9298 (Fset_file_times, Finsert_file_contents, auto_save_error):
9299 Rename locals to avoid shadowing.
f14b7e14 9300
5716756e 9301 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9302 (Ftry_completion, Fall_completions): Rename or remove locals
9303 to avoid shadowing.
5716756e 9304
b4c3046a
PE
9305 * marker.c (bytepos_to_charpos): Remove; unused.
9306
b45db522
PE
9307 * lisp.h (verify_bytepos, count_markers): New decls,
9308 so that gcc does not warn that these functions aren't declared.
9309
85876d07
PE
9310 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9311 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9312 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9313 (copy_text): Remove unused local var.
85876d07 9314
03d78a21 9315 * filelock.c (within_one_second): Now static.
b3dd38ab 9316 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9317
5df8f01b
PE
9318 * buffer.c (fix_overlays_before): Mark locals as initialized.
9319 (fix_start_end_in_overlays): Likewise. This function should be
9320 simplified by using pointers-to-pointers, but that's a different
9321 matter.
b1d876f1 9322 (switch_to_buffer_1): Now static.
8f54f30a
PE
9323 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9324 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9325
a70072c9 9326 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9327 Fix pointer signedness issue.
edced198
PE
9328 (sys_subshell): Mark local as volatile if checking for lint,
9329 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9330 (MAXPATHLEN): Define only if needed.
a70072c9 9331
a0977c44
PE
9332 * process.c (serial_open, serial_configure): Move decls from here ...
9333 * systty.h: ... to here, so that they can be checked.
9334
a884fdcc
PE
9335 * fns.c (get_random, seed_random): Move extern decls from here ...
9336 * lisp.h: ... to here, so that they can be checked.
9337
604efe86 9338 * sysdep.c (reset_io): Now static.
b8950c94 9339 (wait_for_termination_signal): Remove; unused.
604efe86 9340
38fc62d9
PE
9341 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9342 (copy_keymap_item, append_key, push_text_char_description):
9343 Now static.
1004a21a 9344 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9345 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9346 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9347 (describe_map_tree):
9348 Rename locals to avoid shadowing.
38fc62d9 9349
2f2650da
PE
9350 * keyboard.c: Declare functions static if they are not used elsewhere.
9351 (echo_char, echo_dash, cmd_error, top_level_2):
9352 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9353 (read_char, kbd_buffer_get_event, make_lispy_position):
9354 (make_lispy_event, make_lispy_movement, apply_modifiers):
9355 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9356 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9357 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9358 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9359 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9360
a053e86c 9361 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9362 (mark_kboards): Move decl here ...
9363 * alloc.c (mark_kboards): ... from here.
a053e86c 9364
4752793e
PE
9365 * lisp.h (force_auto_save_soon): New decl.
9366
74f10ca7 9367 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9368 (DEFINE_DUMMY_FUNCTION): New macro.
9369 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9370 Use it.
c03cd23f
PE
9371 (main): Add casts to avoid warnings
9372 if GCC considers string literals to be constants.
74f10ca7 9373
022e70d4
PE
9374 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9375
59d6fe83
PE
9376 * dbusbind.c: Pointer signedness fixes.
9377 (xd_signature, xd_append_arg, xd_initialize):
9378 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9379 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9380 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9381 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9382
78320123
PE
9383 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9384 if GCC considers string literals to be constants.
49cebcca 9385 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9386
35ac2a97
SM
93872011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9388
fb103ca9
SM
9389 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9390 (print_preprocess, print_object): New macro to fix last change.
9391
35ac2a97
SM
9392 * print.c (print_preprocess): Don't forget font objects.
9393
62973b41
JB
93942011-03-16 Juanma Barranquero <lekktu@gmail.com>
9395
9396 * emacs.c (USAGE3): Doc fixes.
9397
0e48bb22
AS
93982011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9399
9400 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9401 structure.
9402
7684e57b
JB
94032011-03-14 Juanma Barranquero <lekktu@gmail.com>
9404
9405 * lisp.h (VWindow_system, Qfile_name_history):
9406 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9407 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9408 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9409
9410 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9411 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9412
9413 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9414 * w32console.c (detect_input_pending, read_input_pending)
9415 (encode_terminal_code):
9416 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9417 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9418 (w32_system_caret_y, Qfile_name_history):
9419 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9420 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9421 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9422 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9423 * w32proc.c (Qlocal, report_file_error):
9424 * w32term.c (Vwindow_system, updating_frame):
9425 * w32uniscribe.c (initialized, uniscribe_font_driver):
9426 Remove unneeded extern declarations.
9427
2aa46d6c
CY
94282011-03-14 Chong Yidong <cyd@stupidchicken.com>
9429
c96bbc66 9430 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9431
cffc6f3b
CY
94322011-03-13 Chong Yidong <cyd@stupidchicken.com>
9433
9434 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9435 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9436 These macros can no longer be used for assignment.
9437
44f230aa
SM
9438 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9439 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9440 (record_buffer_markers, fetch_buffer_markers): New functions for
9441 recording and fetching special buffer markers.
9442 (set_buffer_internal_1, set_buffer_temp): Use them.
9443
9444 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9445
9446 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9447
9448 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9449 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9450
9451 * xdisp.c (hscroll_window_tree):
9452 (reconsider_clip_changes): Use PT instead of BUF_PT.
9453
d251f04b
EZ
94542011-03-13 Eli Zaretskii <eliz@gnu.org>
9455
9456 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9457 $(EMACS_ROOT)/lib/intprops.h.
9458
f0c77cd1
PE
94592011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9460
3eca4629
PE
9461 Fix more problems found by GCC 4.5.2's static checks.
9462
7c86ee98
PE
9463 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9464 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9465 (xg_free_frame_widgets): Make it clear that a local variable is
9466 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9467 (gdk_window_get_screen): Make it clear that this macro is needed
9468 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9469 (int_gtk_range_get_value): New function, which avoids a diagnostic
9470 from gcc -Wbad-function-cast.
9471 (xg_set_toolkit_scroll_bar_thumb): Use it.
9472 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9473 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9474 (get_utf8_string, xg_get_file_with_chooser):
9475 Rename locals to avoid shadowing.
9476 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9477
41729b81
PE
9478 * xgselect.c (xg_select): Remove unused var.
9479
f0c77cd1
PE
9480 * image.c (four_corners_best): Mark locals as initialized.
9481 (gif_load): Initialize transparent_p to zero (Bug#8238).
9482 Mark another local as initialized.
ec6cf4c6 9483 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9484
ce0ad53d 9485 * image.c (clear_image_cache): Now static.
d5d5a617 9486 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9487 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9488 (x_edge_detection): Remove unnecessary cast that
9489 gcc -Wbad-function-cast diagnoses.
2037898d 9490 (gif_load): Fix pointer signedness.
6ae141d6
PE
9491 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9492 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9493
33383987 94942011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9495
d32df629
PE
9496 Improve quality of tests for time stamp overflow.
9497 For example, without this patch (encode-time 0 0 0 1 1
9498 1152921504606846976) returns the obviously-bogus value (-948597
9499 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9500 reports time overflow. See
9501 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9502 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9503 * editfns.c: Include limits.h and intprops.h.
9504 (TIME_T_MIN, TIME_T_MAX): New macros.
9505 (time_overflow): Move earlier, to before first use.
9506 (hi_time, lo_time): New functions, for an accurate test for
9507 out-of-range times.
9508 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9509 (Fget_internal_run_time): Don't assume time_t fits in int.
9510 (make_time): Use list2 instead of Fcons twice.
9511 (Fdecode_time): More accurate test for out-of-range times.
9512 (check_tm_member): New function.
9513 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9514 (lisp_time_argument): Don't rely on undefined left-shift and
9515 right-shift behavior when checking for time stamp overflow.
8be6f318 9516
fe31d94c
PE
9517 * editfns.c (time_overflow): New function, refactoring common code.
9518 (Fformat_time_string, Fdecode_time, Fencode_time):
9519 (Fcurrent_time_string): Use it.
9520
8be6f318
PE
9521 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9522 * dired.c (make_time): Move to ...
9523 * editfns.c (make_time): ... here.
9524 * systime.h: Note the move.
9525
09d9db2c 95262011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9527
126bc0dc
YM
9528 * fringe.c (update_window_fringes): Remove unused variables.
9529
c47cbdfd
YM
9530 * unexmacosx.c (copy_data_segment): Also copy __got section.
9531 (Bug#8223)
9532
7ac80be9
EZ
95332011-03-12 Eli Zaretskii <eliz@gnu.org>
9534
c96bbc66 9535 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9536 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9537 Constify `char *' arguments and their references according to
9538 prototypes in tparam.h.
9539
ecb0f94d 9540 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9541
7ac80be9
EZ
9542 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9543 Adapt all references accordingly.
9544
9545 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9546
ef1fd07e
TT
95472011-03-11 Tom Tromey <tromey@redhat.com>
9548
9549 * buffer.c (syms_of_buffer): Remove obsolete comment.
9550
7ef4b50c
EZ
95512011-03-11 Eli Zaretskii <eliz@gnu.org>
9552
9553 * termhooks.h (encode_terminal_code): Declare prototype.
9554
9555 * msdos.c (encode_terminal_code): Don't declare prototype.
9556
9557 * term.c (encode_terminal_code): Now external again, used by
9558 w32console.c and msdos.c.
9559
44f230aa
SM
9560 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9561 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9562
4b1ec863 95632011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9564
1714f52b 9565 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9566
4b1ec863
PE
9567 * fringe.c (update_window_fringes): Mark locals as initialized
9568 (Bug#8227).
9569 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9570
524c7aa6
PE
9571 * alloc.c (mark_fringe_data): Move decl from here ...
9572 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9573 to check its interface.
9574 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9575
a5c0af81 9576 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9577 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9578 (fontset_font): Mark local as initialized.
a9a06e0b 9579 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9580
b4716021
PE
9581 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9582
811e9bac 9583 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9584 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9585 (x_own_selection, Fx_disown_selection_internal): Rename locals
9586 to avoid shadowing.
9587 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9588
7e3ab302
PE
9589 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9590 so that the caller can use some name other than gcpro1.
9591 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9592 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9593 (Fx_backspace_delete_keys_p):
9594 Use them to avoid shadowing, and rename vars to avoid shadowing.
9595 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9596 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9597 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9598 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9599 Remove unused locals.
7e3ab302
PE
9600 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9601 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9602 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9603 macros.
f78faa98 9604
e2b13473
PE
9605 * xterm.h (x_mouse_leave): New decl.
9606
77f23912
PE
9607 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9608 Remove unused functions.
cdf4ba58
PE
9609 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9610 (x_calc_absolute_position): Now static.
7411c686 9611 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9612 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9613 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9614 unless they are used.
38d0b34a
PE
9615 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9616 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9617 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9618 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9619 (x_error_catcher, x_connection_closed, x_error_handler):
9620 (x_error_quitter, xembed_send_message, x_iconify_frame):
9621 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9622 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9623 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9624
44f230aa
SM
9625 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9626 Rename or move locals to avoid shadowing.
6b463e58 9627 (tty_defined_color, merge_face_heights): Now static.
5967d051 9628 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9629 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9630 does not deduce is never used uninitialized.
73719eba
PE
9631 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9632 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9633
426994c3 9634 * terminal.c (store_terminal_param): Now static.
5489860b 9635
032f1620 9636 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9637 (set_frame_menubar): Remove unused local.
d4323972 9638 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9639 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9640 since they might point to immutable storage.
281585b0
PE
9641 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9642 since it's unused otherwise.
032f1620 9643
367c19e5 9644 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9645 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9646 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9647 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9648 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9649 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9650 does not deduce are never used uninitialized.
70739cbe 9651
07b48fa9
PE
9652 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9653
8868a238 9654 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9655 * window.c (window_loop, size_window):
9656 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9657
7e5cf297 9658 * window.c (display_buffer): Now static.
d6550a9f
PE
9659 (size_window): Mark variables that gcc -Wuninitialized
9660 does not deduce are never used uninitialized.
a586633d
PE
9661 * window.h (check_all_windows): New decl, to forestall
9662 gcc -Wmissing-prototypes diagnostic.
5b555da1 9663 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9664
f6095868
PE
9665 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9666 shadowing.
9667 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9668 Include <limits.h>.
9669 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9670 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9671 (load_charset_map): Mark variables that gcc -Wuninitialized
9672 does not deduce are never used uninitialized.
53df7c11 9673 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9674
f38b440c
PE
9675 * coding.c (coding_set_source, coding_set_destination):
9676 Use "else { /* comment */ }" rather than "else /* comment */;"
9677 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9678 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9679 a block, when the outer 'i' will do.
9680 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9681 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9682 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9683 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9684 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9685 Rename locals to avoid shadowing.
9686 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9687 * coding.c (emacs_mule_char, encode_invocation_designation):
9688 Now static, since they're not used elsewhere.
413bb2db 9689 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9690 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9691 (decode_coding_emacs_mule): Mark variables that gcc
9692 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9693 (detect_coding_iso_2022): Initialize a local variable that might
9694 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9695 this initialization is needed. (Bug#8211)
5f58e762
PE
9696 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9697 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9698 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9699 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9700 Remove unused macros.
f38b440c 9701
232b38b9 9702 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9703 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9704 * character.c (string_count_byte8): Likewise.
232b38b9 9705
fb90da1b
PE
9706 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9707 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9708
fb93dbc2
PE
9709 * chartab.c (copy_sub_char_table): Now static, since it's not used
9710 elsewhere.
5c156ace
PE
9711 (sub_char_table_ref_and_range, char_table_ref_and_range):
9712 Rename locals to avoid shadowing.
bbcd0949 9713 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9714
7d3b3862 9715 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9716 (BIDI_BOB): Remove unused macro.
7d3b3862 9717
6be7d3da
PE
9718 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9719 deduce are never used uninitialized.
c2ed9c8b 9720 * term.c (encode_terminal_code): Likewise.
6be7d3da 9721
75f8807f 9722 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9723
50938595
PE
9724 * tparam.h: New file.
9725 * term.c, tparam.h: Include it.
9726 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9727 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9728 Move these decls to tparam.h, and make them agree with what
9729 is actually in tparam.c. The previous trick of using incompatible
9730 decls in different modules does not conform to the C standard.
9731 All callers of tparam changed to use tparam's actual API.
9732 * tparam.c (tparam1, tparam, tgoto):
9733 Use const pointers where appropriate.
9734
fbceeba2
PE
9735 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9736 * cm.h (struct cm): Likewise.
9737 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9738 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9739 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9740 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9741 (turn_on_face, init_tty): Likewise.
9742 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9743
7f3f1250
PE
9744 * term.c (term_mouse_position): Rename local to avoid shadowing.
9745
e6ca6543
PE
9746 * alloc.c (mark_ttys): Move decl from here ...
9747 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9748
c40f8d15
AS
97492011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9750
9751 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9752
cfe0661d
JB
97532011-03-09 Juanma Barranquero <lekktu@gmail.com>
9754
9755 * search.c (compile_pattern_1): Remove argument regp, unused since
9756 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9757 (compile_pattern): Don't pass it.
9758
0afb4571
J
97592011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9760
9761 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9762 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9763 for ! HAVE_GTK3.
9764 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9765
9766 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9767
9768 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9769 gdk_window_get_screen, gdk_window_get_geometry,
9770 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9771 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9772 (xg_get_pixbuf_from_pixmap): New function.
9773 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9774 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9775 Call xg_get_pixbuf_from_pixmap instead of
9776 gdk_pixbuf_get_from_drawable.
9777 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9778 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9779 (xg_check_special_colors): Use GtkStyleContext and its functions
9780 for HAVE_GTK3.
9781 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9782 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9783 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9784 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9785 Call gtk_widget_get_preferred_size.
0afb4571
J
9786 (xg_frame_resized): gdk_window_get_geometry only takes 5
9787 parameters.
44f230aa
SM
9788 (xg_win_to_widget, xg_event_is_for_menubar):
9789 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9790 (xg_set_widget_bg): New function.
9791 (delete_cb): New function.
895009e1 9792 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9793 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9794 (xg_set_background_color): Call xg_set_widget_bg.
9795 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9796 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9797 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9798 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9799 if ! HAVE_GTK3.
9800 (update_frame_tool_bar): Call gtk_widget_hide.
9801 (xg_initialize): Use GDK_KEY_g.
9802
9803 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9804 if ! HAVE_GTK3
9805 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9806
9807 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9808 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9809 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9810
1c2cc4ef
JB
98112011-03-08 Juanma Barranquero <lekktu@gmail.com>
9812
9813 * w32xfns.c (select_palette): Check success of RealizePalette against
9814 GDI_ERROR, not zero.
9815
33383987 9816See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9817
9818;; Local Variables:
9819;; coding: utf-8
aac0c6e3
MR
9820;; End:
9821
2f097256 9822 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9823
9824 This file is part of GNU Emacs.
9825
9826 GNU Emacs is free software: you can redistribute it and/or modify
9827 it under the terms of the GNU General Public License as published by
9828 the Free Software Foundation, either version 3 of the License, or
9829 (at your option) any later version.
9830
9831 GNU Emacs is distributed in the hope that it will be useful,
9832 but WITHOUT ANY WARRANTY; without even the implied warranty of
9833 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9834 GNU General Public License for more details.
9835
9836 You should have received a copy of the GNU General Public License
9837 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.