admin/MAINTAINERS: Update Eli Z.'s responsibilities & interests.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
9e49252b
EZ
12011-12-03 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4 before a newline, prepare the bidi iterator for consuming the
5 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 7
02b16839
JL
82011-12-02 Juri Linkov <juri@jurta.org>
9
10 * search.c (Fword_search_regexp): New Lisp function created from
11 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
12 (Fword_search_backward, Fword_search_forward)
13 (Fword_search_backward_lax, Fword_search_forward_lax):
14 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
15 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
16
0068070e
SM
172011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
18
19 * fileio.c (Finsert_file_contents): Move after-change-function call
20 to before the "handled:" label, since all "goto handled" appear in
21 cases where the *-change-functions have already been properly called
22 (bug#10117).
23
3360a3fc
AS
242011-12-01 Andreas Schwab <schwab@linux-m68k.org>
25
26 * keyboard.c (interrupt_signal): Don't call kill-emacs when
27 waiting for input. (Bug#10169)
28
73d6c093
EZ
292011-11-30 Eli Zaretskii <eliz@gnu.org>
30
31 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
32 verifies glyph row's hash code--we have just reallocated the
33 glyphs, so their contents can be complete garbage. (Bug#10164)
34
febe6bea
JB
352011-11-30 Juanma Barranquero <lekktu@gmail.com>
36
37 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
38
801a4313
EZ
392011-11-30 Eli Zaretskii <eliz@gnu.org>
40
41 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
42 attributes are tested _before_ calling verify_row_hash, to protect
43 against GCC re-ordering of the tests. (Bug#10164)
44
2b56b87e
JD
452011-11-29 Jan Djärv <jan.h.d@swipnet.se>
46
47 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
48
49 * xterm.c (handle_one_xevent): Only set async_visible and friends
50 if net_wm_state_hidden_seen is non-zero (Bug#10002)
51 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
52 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
53
dbf31225
PE
542011-11-28 Paul Eggert <eggert@cs.ucla.edu>
55
56 Remove GCPRO-related macros that exist only to avoid shadowing locals.
57 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
58 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
59 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
60 All uses changed to use GCPRO1 etc.
61 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
62 Revert to old implementation (i.e., before 2011-03-11).
63
1305621b
YM
642011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
65
66 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
67 of scroll runs so as to avoid assigning disabled bogus rows and
68 unnecessary graphics copy operations.
69
8c9afb46
EZ
702011-11-27 Eli Zaretskii <eliz@gnu.org>
71
72 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
73 (snprintf) [_MSC_VER]: Redirect to _snprintf.
74 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
75 (malloc, free, realloc, calloc): Redirect to e_* only when
76 compiling Emacs.
77
78 * lisp.h (GCTYPEBITS): Move before first use.
79 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
80 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
81 this macro definition.
82
83 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
84 _MSC_VER.
85
54e9e3bf
JD
862011-11-27 Jan Djärv <jan.h.d@swipnet.se>
87
88 * gtkutil.c (xg_create_frame_widgets): Call
89 gtk_window_set_has_resize_grip (FALSE) if that function is
90 present with Gtk+ 2.0.
91
83aca1cb
PE
922011-11-26 Paul Eggert <eggert@cs.ucla.edu>
93
94 * fileio.c (Finsert_file_contents): Undo previous change; see
95 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
96
5b76caa4
PE
972011-11-26 Paul Eggert <eggert@cs.ucla.edu>
98
99 Rename locals to avoid shadowing.
100 * fileio.c (Finsert_file_contents):
101 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
102 * process.c (wait_reading_process_output):
103 Rename inner 'proc' to 'p' to avoid shadowing.
104 Indent for consistency with usual Emacs style.
105
8c535114
EZ
1062011-11-25 Eli Zaretskii <eliz@gnu.org>
107
108 * xdisp.c (redisplay_window): If cursor row is not fully visible
109 after recentering, and scroll-conservatively is set to a large
110 number, scroll window by a few more lines to make the cursor fully
111 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
112 (start_display): Don't move to the next line if the display should
113 start at a newline that is part of a display vector or an overlay
114 string. (Bug#10119)
8c535114 115
fa4fdb5c
JL
1162011-11-24 Juri Linkov <juri@jurta.org>
117
118 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
119 after the `MagickPingImage' call. (Bug#10112)
120
90ec88df
CY
1212011-11-23 Chong Yidong <cyd@gnu.org>
122
123 * window.c (Fcoordinates_in_window_p): Accept only live windows.
124
56e2e794
MR
1252011-11-23 Martin Rudalics <rudalics@gmx.at>
126
127 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
128 making another buffer current. (Bug#10114)
129
b6e64c41
GM
1302011-11-23 Glenn Morris <rgm@gnu.org>
131
132 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
133
6b21de18
CY
1342011-11-23 Chong Yidong <cyd@gnu.org>
135
136 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
137 using it (Bug#5984).
138
b12cd789
EZ
1392011-11-22 Eli Zaretskii <eliz@gnu.org>
140
141 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
142 and header-lines, as they don't have one computed for them.
143 (Bug#10098)
144
145 * .gdbinit (prow): Make displayed values more self-explaining.
146 Add row's hash code.
147
261b6fd4
LMI
1482011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
149
150 * process.c (wait_reading_process_output): Fix asynchrounous
151 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 152 (wait_reading_process_output): Add comment and URL.
261b6fd4 153
e7cfd277
JD
1542011-11-21 Jan Djärv <jan.h.d@swipnet.se>
155
156 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
157
a9b9b7f5
CY
1582011-11-21 Chong Yidong <cyd@gnu.org>
159
160 * window.c (Fnext_window, Fprevious_window): Doc fix.
161
b0d15b4f
SM
1622011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
163
164 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
165
fe7a3057
JB
1662011-11-20 Juanma Barranquero <lekktu@gmail.com>
167
168 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
169
d2999b1a
MR
1702011-11-20 Martin Rudalics <rudalics@gmx.at>
171
172 * window.c (Fset_window_combination_limit): Rename argument
173 STATUS to LIMIT.
174 (Vwindow_combination_limit): Remove "status" from doc-string.
175
d5ff9cd0
AS
1762011-11-20 Andreas Schwab <schwab@linux-m68k.org>
177
178 * m/ibms390.h: Remove.
179 * m/ibms390x.h: Don't include "ibms390.h".
180
a5bb9bd3
SM
1812011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
182
183 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
184 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
185
cd1181db
JB
1862011-11-20 Juanma Barranquero <lekktu@gmail.com>
187
188 * casetab.c (Fset_case_table):
189 * charset.c (Fcharset_after): Fix typos.
190
615a3b8d 1912011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 192
17e845af
PE
193 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
194 Otherwise, valgrind does not work on some platforms.
195 Problem reported by Andreas Schwab in
6a0bf43d
PE
196 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
197 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
198 is set, removing the need for VIRT_ADDRESS_VARIES.
199 (PURE_P): Use a more-efficient implementation that needs just one
200 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
201 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
202 to 4 (xorl, subq, cmpq, setbe).
203 * alloc.c (pure): Always extern now, since that's the
204 VIRT_ADDR_VARIES behavior.
205 (PURE_POINTER_P): Use a single comparison, not two, for
206 consistency with the new puresize.h.
207 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
208 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
209 Remove VIRT_ADDR_VARIES no longer needed.
210
f8fe6f96
EZ
2112011-11-19 Eli Zaretskii <eliz@gnu.org>
212
213 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
214 (erase_phys_cursor, update_window_cursor, show_mouse_face)
215 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
216 behave as if the cursor position were at the window margin.
217
218 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
219 and the cursor position is out of bounds, behave as if the cursor
220 position were at the window margin. (Bug#10075)
221
df05a53c
CY
2222011-11-18 Chong Yidong <cyd@gnu.org>
223
224 * window.c (Fwindow_combination_limit): Make first argument
225 non-optional, since it is meaningless for live windows like the
226 selected window.
227
2071918e
DA
2282011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
229
230 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
231
b50a28de
SM
2322011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
233
234 * intervals.c: Fix grafting over the whole buffer (bug#10071).
235 (graft_intervals_into_buffer): Simplify.
236
015137db
EZ
2372011-11-18 Eli Zaretskii <eliz@gnu.org>
238
239 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
240 hash values of the two rows.
241 (copy_row_except_pointers): Preserve the used[] arrays and the
242 hash values of the two rows. (Bug#10035)
68c95424 243 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
244
245 * xdisp.c (row_hash): New function, body extracted from
246 compute_line_metrics.
247 (compute_line_metrics): Call row_hash, instead of computing the
248 hash code inline.
249
250 * dispnew.c (verify_row_hash): Call row_hash for computing the
251 hash code of a row, instead of duplicating code from xdisp.c.
252
253 * dispextern.h (row_hash): Add prototype.
254
a2addb04
TH
2552011-11-18 Tassilo Horn <tassilo@member.fsf.org>
256
257 * frame.c (delete_frame): Don't delete the terminal when the last
258 X frame is closed if emacs is built with GTK toolkit.
259
df85d315
JB
2602011-11-17 Juanma Barranquero <lekktu@gmail.com>
261
262 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
263
a0c2d0ae
MR
2642011-11-17 Martin Rudalics <rudalics@gmx.at>
265
266 * window.c (Vwindow_splits): Rename to
267 Vwindow_combination_resize. Suggested by Juri Linkov.
268 (Fsplit_window_internal): Use Vwindow_combination_resize instead
269 of Vwindow_splits.
270
58179cce
JB
2712011-11-16 Juanma Barranquero <lekktu@gmail.com>
272
7877f373
JB
273 * nsfns.m (Fns_font_name):
274 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 275
b6f67890
MR
2762011-11-16 Martin Rudalics <rudalics@gmx.at>
277
278 * window.h (window): Rename slot "nest" to "combination_limit".
279 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
280 (Fset_window_nest): Rename to Fset_window_combination_limit.
281 (Vwindow_nest): Rename to Vwindow_combination_limit.
282 (recombine_windows, make_parent_window, make_window)
283 (Fsplit_window_internal, saved_window)
284 (Fset_window_configuration, save_window_save): Rename all
285 occurrences of window_nest to window_combination_limit.
286
c7015153
JB
2872011-11-15 Juanma Barranquero <lekktu@gmail.com>
288
289 * image.c (imagemagick_load_image): Fix typo.
290
322ad6ec
EZ
2912011-11-14 Eli Zaretskii <eliz@gnu.org>
292
293 * xdisp.c (display_line): Move the call to
294 highlight_trailing_whitespace before the call to
295 compute_line_metrics, since the latter needs to see the final
296 faces of all the glyphs to compute ROW's hash value. Fixes
297 assertion violations in row_equal_p. (Bug#10035)
298
f067b8ec
JB
2992011-11-14 Juanma Barranquero <lekktu@gmail.com>
300
301 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
302 just return (bug#10044).
303
1e5b2111
EZ
3042011-11-12 Eli Zaretskii <eliz@gnu.org>
305
7ef3cbd5
EZ
306 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
307 with user-defined heap size. Bump the default size of the temacs
308 heap to 27MB, to avoid memory warning when running temacs.
309 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
310
1e5b2111
EZ
311 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
312 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
313 (verify_row_hash) [XASSERTS]: New function.
314 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
315 that the hash value of glyph rows is correct.
1e5b2111 316
89d61221
MR
3172011-11-12 Martin Rudalics <rudalics@gmx.at>
318
319 * window.h (window): Remove splits slot.
320 * window.c (Fwindow_splits, Fset_window_splits): Remove.
321 (Fdelete_other_windows_internal, make_parent_window)
322 (make_window, Fsplit_window_internal, Fdelete_window_internal)
323 (Fset_window_configuration, save_window_save): Don't deal with
324 split status of windows.
325 (saved_window): Remove splits slot.
326 (Vwindow_splits): Rewrite doc-string.
327
97f18cc8
JD
3282011-11-11 Jan Djärv <jan.h.d@swipnet.se>
329
330 * xfns.c (unwind_create_frame):
331 * nsfns.m (unwind_create_frame):
332 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
333 Vframe_list (Bug#9999).
334
22a648b4
DA
3352011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
336
0b381c7e 337 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 338
659afede
KH
3392011-11-11 Kenichi Handa <handa@m17n.org>
340
341 * callproc.c (Fcall_process): Set the member dst_multibyte of
342 process_coding.
343
9ac0394b
KH
3442011-11-11 Johan Bockgård <bojohan@gnu.org>
345
346 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
347 avoid a crash (bug#9496).
348
2fbdc249
CY
3492011-11-09 Chong Yidong <cyd@gnu.org>
350
351 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
352 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
353
ac6b1f81
PE
3542011-11-08 Paul Eggert <eggert@cs.ucla.edu>
355
356 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
357
09db192c
PE
3582011-11-08 Paul Eggert <eggert@cs.ucla.edu>
359
360 Avoid some portability problems by eschewing 'extern inline' functions.
361 The trivial performance wins aren't worth the portability hassles; see
362 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
363 et seq.
364 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
365 (window_box_width, window_box_left, window_box_left_offset)
366 (window_box_right, window_box_right_offset): Undo previous change,
367 by removing the "extern"s.
368 * intervals.c (adjust_intervals_for_insertion)
369 (adjust_intervals_for_deletion): Undo previous change,
370 making these static again.
371 (offset_intervals, temp_set_point_both, temp_set_point)
372 (copy_intervals_to_string): No longer inline.
373 * xdisp.c (window_text_bottom_y, window_box_width)
374 (window_box_height, window_box_left_offset)
375 (window_box_right_offset, window_box_left, window_box_right)
376 (window_box): No longer inline.
377
105216ed
CY
3782011-11-08 Chong Yidong <cyd@gnu.org>
379
380 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
381 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
382 an error if not a live window.
383 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
384 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
385
ae9e237f
JB
3862011-11-07 Juanma Barranquero <lekktu@gmail.com>
387
388 * lisp.h (syms_of_abbrev): Remove declaration.
389 Reported by CHENG Gao <chenggao@royau.me>.
390
c7aa8333
EZ
3912011-11-07 Eli Zaretskii <eliz@gnu.org>
392
393 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
394 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
395 of temacs in GUI mode.
396
be7f5545
MR
3972011-11-07 Martin Rudalics <rudalics@gmx.at>
398
399 * window.h: Declare delete_all_child_windows instead of
400 delete_all_subwindows.
401 * window.c (Fwindow_nest, Fset_window_nest)
402 (Fset_window_new_total, Fset_window_new_normal)
403 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
404 (delete_all_subwindows): Rename to delete_all_child_windows.
405 (Fdelete_other_windows_internal, Fset_window_configuration):
406 Call delete_all_child_windows instead of delete_all_subwindows.
407 * frame.c (delete_frame): Call delete_all_child_windows instead
408 of delete_all_subwindows.
409
ca78dc43
PE
4102011-11-07 Paul Eggert <eggert@cs.ucla.edu>
411
412 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
413 This is also needed for porting to any host where GC_MARK_STACK is
414 not GC_MAKE_GCPROS_NOOPS.
415 (which_symbols): Use it.
416
a0241d01
KH
4172011-11-07 Kenichi Handa <handa@m17n.org>
418
419 * coding.c (coding_set_destination): Check coding->src_pos only
420 when coding->src_object is a buffer (bug#9910).
421
422 * process.c (send_process): Set the member src_multibyte of coding
423 to 0 (bug#9911) when sending a unibyte text.
424
425 * callproc.c (Fcall_process): Set the member src_multibyte of
426 process_coding to 0 (bug#9912).
427
a64bfdfa 4282011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
429
430 * xmenu.c (cleanup_widget_value_tree): New function.
431 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
432 calling free_menubar_widget_value_tree directly (Bug#9830).
433
cb41b32a
PE
4342011-11-06 Paul Eggert <eggert@cs.ucla.edu>
435
436 Fix some portability problems with 'inline'.
437 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
438 (window_box_width, window_box_left, window_box_left_offset)
439 (window_box_right, window_box_right_offset): Declare extern.
440 Otherwise, these inline functions do not conform to C99 and
441 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
442 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
443 * intervals.c (adjust_intervals_for_insertion)
444 (adjust_intervals_for_deletion): Now extern, because otherwise the
445 extern inline functions 'offset_intervals' couldn't refer to it.
446 (static_offset_intervals): Remove.
447 (offset_intervals): Rewrite using the old contents of
448 static_offset_intervals. The old version didn't conform to C99
449 because an extern inline function contained a reference to an
450 identifier with static linkage.
451
b7041366
AS
4522011-11-06 Andreas Schwab <schwab@linux-m68k.org>
453
454 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
455 GC.
456
88a37c4d
EZ
4572011-11-06 Eli Zaretskii <eliz@gnu.org>
458
459 * xdisp.c (init_iterator, reseat_to_string): Don't set the
460 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
461 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
462 return Qleft_to_right.
463
49745b39
CY
4642011-11-06 Chong Yidong <cyd@gnu.org>
465
466 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
467 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
468 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
469 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
470 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
471 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
472 (Fwindow_vscroll): Doc fix.
473 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
474 argument, since it makes no sense to pass a live window and for
475 consistency with window-child.
476
1f05cd82
CS
4772011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
478
479 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
480 support MSVC.
481
22610910
JR
4822011-11-05 Jason Rumney <jasonr@gnu.org>
483
484 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
485 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
486 fonts (Bug#6029).
487 (add_font_entity_to_list): Fix logic errors in mixed boolean and
488 bitwise arithmetic preventing use of unicode-sip and non-truetype
489 opentype fonts.
490
a06776b2
EZ
4912011-11-05 Eli Zaretskii <eliz@gnu.org>
492
3ad924ba
EZ
493 * s/ms-w32.h (fstat, stat, utime): Move redirections to
494 "emacs"-only part.
495
a06776b2
EZ
496 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
497 initialization code to keep similarity to xfns.c after changes
498 from 2011-11-05.
499
c9e7db78
JD
5002011-11-05 Jan Djärv <jan.h.d@swipnet.se>
501
a97f8f3f
JD
502 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
503 (unwind_create_frame): New function (Bug#9943).
504 (Fx_create_frame): Restructure code to be more similar to the one in
505 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
506 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
507 Move terminal->reference_count++ just before making the frame official
508 (Bug#9943).
509
510 * nsterm.m (x_free_frame_resources): New function.
511 (x_destroy_window): Move code to x_free_frame_resources.
512
c9e7db78
JD
513 * xfns.c (unwind_create_frame): Fix comment.
514 (Fx_create_frame, x_create_tip_frame): Move
515 terminal->reference_count++ just before making the frame
516 official. Move initialization of image_cache_refcount and
517 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
518
a6fc3b5c
EZ
5192011-11-05 Eli Zaretskii <eliz@gnu.org>
520
521 Support MSVC build with newer versions of Visual Studio.
522 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
523 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
524 nt/gmake.defs.
525
526 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
527 which are not supported by MSVC.
528 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
529 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
530 bitfields.
531 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
532 types in bitfields.
533 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
534
535 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
536
58179cce 5372011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
538
539 Support MSVC build with newer versions of Visual Studio.
540 * w32.c: Don't include w32api.h for MSVC.
541 (init_environment) [_MSC_VER]: Call sys_access, not _access.
542
543 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
544 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
545 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
546 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
547 e_* cousins.
548 (alloca) [_MSC_VER]: Define to _alloca.
549
550 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
551
552 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
553
a58c13ed
EZ
5542011-11-04 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (note_mouse_highlight): If either of
557 previous/next-single-property-change returns nil, treat that as
558 the beginning or the end of the buffer. (Bug#9955)
559
fe0b6370
JD
5602011-11-04 Jan Djärv <jan.h.d@swipnet.se>
561
a58c13ed 562 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
563 label is not null (Bug#9951).
564 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
565 may be NULL.
566
89bd5ee1
EZ
5672011-11-04 Eli Zaretskii <eliz@gnu.org>
568
569 * window.c (Fwindow_body_size): Mention in the doc string that the
570 return value is in frame's canonical units. (Bug#9949)
571
84c3edb9
EZ
5722011-11-03 Eli Zaretskii <eliz@gnu.org>
573
4e2fb5c7
EZ
574 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
575
84c3edb9 576 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 577 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 578 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 579
bc17a887
EZ
5802011-11-01 Eli Zaretskii <eliz@gnu.org>
581
582 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
583 Don't stop backward scan on the continuation glyph, even though
584 its CHARPOS is positive.
26b46e51
EZ
585 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
586 cover_string to disp_string.
bc17a887 587
4ee88440
MR
5882011-11-01 Martin Rudalics <rudalics@gmx.at>
589
590 * window.c (temp_output_buffer_show): Don't use
591 Vtemp_buffer_show_specifiers.
592 (Vtemp_buffer_show_specifiers): Remove unused variable.
593
c2ff3c02
EZ
5942011-10-30 Eli Zaretskii <eliz@gnu.org>
595
596 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
597 past the beginning of the current glyph matrix.
598
58179cce 5992011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
600
601 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
602 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
603 HAVE_GTK3 (Bug#9869).
b77a6a7f 604
3b574623
JD
605 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
606 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
607
b77a6a7f
JD
608 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
609
610 * xterm.c: Declare x_handle_net_wm_state to return int.
611 (handle_one_xevent): Check if we are iconified but don't have
612 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
613 (get_current_wm_state): Return non-zero if not hidden,
614 check for _NET_WM_STATE_HIDDEN (Bug#9893).
615 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
616 (x_handle_net_wm_state): Return what get_current_wm_state returns.
617 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
618
196e41e4
PE
6192011-10-29 Paul Eggert <eggert@cs.ucla.edu>
620
621 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
622 so that this new function doesn't get optimized away by a
623 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
624
021f2e1a
AS
6252011-10-29 Andreas Schwab <schwab@linux-m68k.org>
626
627 * frame.h (MOUSE_HL_INFO): Remove excess parens.
628
8b058d44
EZ
6292011-10-29 Eli Zaretskii <eliz@gnu.org>
630
631 Fix the `xbytecode' command.
632 * .gdbinit (xprintbytestr): New command.
b50a28de 633 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
634 (xbytecode): Print the byte-code string as well.
635
4452fb80
EZ
6362011-10-29 Kim Storm <storm@cua.dk>
637
8b058d44
EZ
638 * alloc.c (which_symbols): New function.
639
21b72067
AS
6402011-10-29 Andreas Schwab <schwab@linux-m68k.org>
641
642 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
643 line. (Bug#9903)
644
83ed7b5c
GM
6452011-10-29 Glenn Morris <rgm@gnu.org>
646
647 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
648 Not clear what it was for, and it causes various bugs. (Bug#9839)
649
5a7a728b
EZ
6502011-10-28 Eli Zaretskii <eliz@gnu.org>
651
652 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
653 possible random value that matches one of those tested as
654 condition to clear the mouse face.
655
d3d0842f
CY
6562011-10-28 Chong Yidong <cyd@gnu.org>
657
658 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
659
31b39d13
DN
6602011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
661
662 * window.c (make_window): Initialize phys_cursor_on_p.
663
9aba6043
SM
6642011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
665
666 * lisp.h (struct Lisp_Symbol): Update comments.
667
c20992f4
JB
6682011-10-28 Juanma Barranquero <lekktu@gmail.com>
669
670 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
671
db4f02f2
EZ
6722011-10-28 Eli Zaretskii <eliz@gnu.org>
673
674 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
675 <oslsachem@gmail.com> for helping to debug this.
676
677 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
678 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
679 (g_b_init_get_glyph_outline_w): New static variables.
680 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
681 (GetGlyphOutlineW_Proc): New typedefs.
682 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
683 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
684 New functions.
685 (w32font_open_internal, compute_metrics):
686 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
687 instead of calling the "wide" APIs directly.
688
689 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
690
691 * w32.h (syms_of_w32font): Add prototype.
692
87e68db4
JB
6932011-10-27 Juanma Barranquero <lekktu@gmail.com>
694
695 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
696 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
697 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
698 (Fmove_to_window_line): Doc fix.
699
435c1d67
CY
7002011-10-27 Chong Yidong <cyd@gnu.org>
701
702 * process.c (make_process): Set gnutls_state to NULL.
703
704 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
705 non-NULL, regardless of GNUTLS_INITSTAGE.
706 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
707 an error. Set process slots as soon as we allocate them.
708
709 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
710
9c6c6f49
CY
7112011-10-27 Chong Yidong <cyd@gnu.org>
712
9aba6043
SM
713 * gnutls.c (emacs_gnutls_deinit): New function.
714 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
715 (Fgnutls_deinit, Fgnutls_boot): Use it.
716
717 * process.c (make_process): Initialize GnuTLS credentials to NULL.
718 (deactivate_process): Call emacs_gnutls_deinit.
719
657d08d3
JB
7202011-10-27 Juanma Barranquero <lekktu@gmail.com>
721
722 * image.c (x_create_x_image_and_pixmap):
723 * w32.c (sys_rename, w32_delayed_load):
724 * w32font.c (fill_in_logfont):
725 * w32reg.c (x_get_string_resource): Silence compiler warnings.
726
5430d399
JB
7272011-10-26 Juanma Barranquero <lekktu@gmail.com>
728
729 * w32fns.c (w32_default_color_map): New function,
730 extracted from Fw32_default_color_map.
a7ef684b 731 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 732
fe0055fa
PE
7332011-10-25 Paul Eggert <eggert@cs.ucla.edu>
734
735 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
736
e6346438
SM
7372011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
738
739 * keyboard.c (test_undefined): New function (bug#9751).
740 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
741
e112cc37
ET
7422011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
743
744 * sysdep.c (init_sys_modes): Fix the check for the controlling
745 terminal (Bug#6649).
746
7b5d6677
EZ
7472011-10-20 Eli Zaretskii <eliz@gnu.org>
748
749 * dispextern.h (struct bidi_it): New member next_en_type.
750
751 * bidi.c (bidi_line_init): Initialize the next_en_type member.
752 (bidi_resolve_explicit_1): When next_en_pos is valid for the
753 current character, check also for next_en_type being WEAK_EN.
754 (bidi_resolve_weak): Don't enter the expensive loop if the current
755 position is before next_en_pos. Record the bidi type of the first
756 non-ET, non-BN character we find, in addition to its position.
757 (bidi_level_of_next_char): Invalidate next_en_type when
758 next_en_pos is over-stepped.
759
7da0b018
PE
7602011-10-20 Paul Eggert <eggert@cs.ucla.edu>
761
762 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
763 * editfns.c: Rewrite current-time-zone so that it invokes
764 the equivalent of (format-time-string "%Z") to get the time zone name.
765 This fixes a bug when the time zone name contains characters that
766 need converting from the system time locale to Emacs internal format.
767 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
768 that patch fixed format-time-string to do the conversion, but
769 I forgot to fix current-time-zone.
770 (format_time_string): New function, containing most of
771 what Fformat_time_string used to contain.
772 (Fformat_time_string): Rewrite in terms of format_time_string.
773 This doesn't change this function's behavior.
774 (current-time-zone): Rewrite to use format_time_string.
775 This fixes the bug reported by Michael Schierl in
776 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
777 Jason Rumney's 2007-06-07 change worked around this bug, but
778 didn't fix it.
779 * systime.h (tzname, timezone): Remove no-longer-used declarations.
780
8547b010
EZ
7812011-10-19 Eli Zaretskii <eliz@gnu.org>
782
783 * xdisp.c (start_display): If the character at POS is displayed
784 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
785 (try_window_reusing_current_matrix): If a line ends in a display
786 vector or the next line starts in a display vector, continue
787 redrawing the window even though the character position of
788 start_row was reached.
8547b010
EZ
789 (Bug#9771, part 2)
790
4e948d15
CY
7912011-10-18 Chong Yidong <cyd@gnu.org>
792
793 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
794 with nobreak-char-display too.
795
4787455f
EZ
7962011-10-18 Eli Zaretskii <eliz@gnu.org>
797
798 Fix part 3 of bug#9771.
799 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
800 (bidi_resolve_neutral): Don't enter the expensive loop looking for
801 non-neutral characters if the current character is a paragraph
802 separator (a.k.a. Newline). This avoids running the same
803 expensive loop twice, once when we consume the preceding newline
804 and the other time when the line actually needs to be displayed.
805 Avoid the loop when we see neutrals on the base embedding level
806 following a character whose directionality is the same as the
807 paragraph's. This avoids running the expensive loop when a line
808 ends in a long sequence of neutrals, like control characters.
809 Add assertion against STRONG_AL type. Slightly rearrange code
810 that determines the type of a neutral given the first non-neutral
811 that follows it.
812 (bidi_level_of_next_char): Set next_en_pos to zero when
813 invalidating its info.
814
2c91f553
EZ
8152011-10-17 Eli Zaretskii <eliz@gnu.org>
816
817 * xdisp.c (push_display_prop): Determine whether to record string
818 or buffer position by IT->string, not by IT->method. Allow
819 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
820 (move_it_vertically_backward): Don't look for character position
821 immediately after the newline when in a continuation line.
822 (Bug#9771, part 1)
2c91f553 823
c7b08b0d
MR
8242011-10-15 Martin Rudalics <rudalics@gmx.at>
825
826 * window.c (coordinates_in_window): Rewrite and delabelize
827 vertical border check. (Bug#5357) (Bug#9618)
828
6b02f655
SM
8292011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
830
831 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
832 errors in XSetWindowBorder (bug#9310).
833
81d40c92
DA
8342011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
835
836 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
837 avoid crash when xmalloc overrun checking is enabled.
838
d4172c3b
EZ
8392011-10-13 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
842 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
843 cursor motion with <left> and <right> arrow keys.
844
845 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
846 some callers set that themselves.
847
b00eea75
EZ
8482011-10-12 Eli Zaretskii <eliz@gnu.org>
849
850 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
851 display string and the previous row comes from the same string and
852 is empty. (Bug#9739) (Bug#9738)
853
8fe012c4
SM
8542011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * doc.c (get_doc_string): Encode file name (bug#9735).
857
0074aef2
EZ
8582011-10-12 Eli Zaretskii <eliz@gnu.org>
859
79beb178
EZ
860 * bidi.c (bidi_level_of_next_char):
861 * xdisp.c (get_visually_first_element): Remove old incorrect
862 comments regarding the Unicode Line Separator character.
863
0074aef2
EZ
864 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
865
6e4b3fbe
DA
8662011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
867
868 * alloc.c (Fgc_status): Do not access beyond zombies array
869 boundary if nzombies > MAX_ZOMBIES.
870 * alloc.c (dump_zombies): Add missing format specifier.
871
0324f3af
PE
8722011-10-12 Paul Eggert <eggert@cs.ucla.edu>
873
b5525cac
PE
874 * xdisp.c (set_cursor_from_row): Simplify conditionals,
875 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
876
0324f3af
PE
877 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
878 Some packages use them to denote characters with modifiers.
879
e9b5f888
AS
8802011-10-11 Andreas Schwab <schwab@linux-m68k.org>
881
882 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
883 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
884 matching a pp-number. Rename parameter var to var1.
885
127827c0
SM
8862011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
887
888 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
889
c8fd3bd0
GM
8902011-10-08 Glenn Morris <rgm@gnu.org>
891
892 * callint.c (Fcall_interactively): Give a more explicit error for the
893 'c' case with a non-character input. (Bug#8479)
894
352ec8ff
EZ
8952011-10-08 Eli Zaretskii <eliz@gnu.org>
896
03669ccb
EZ
897 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
898 lines.
7061c986
EZ
899 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
900 lines that are hscrolled on the left.
03669ccb 901
352ec8ff
EZ
902 * dispnew.c (buffer_posn_from_coords): Account for a possible
903 presence of header-line. (Bug#4426)
904
a66cfb1c
SM
9052011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
906
6b02f655
SM
907 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
908 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 909
7c5ee88e
PE
9102011-10-07 Paul Eggert <eggert@cs.ucla.edu>
911
912 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
913 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
914 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
915 this makes Emacs dump core during garbage collection on rare
916 occasions. sizeof is obviously inferior to offsetof here, so
917 stick with offsetof.
918 (GC_POINTER_ALIGNMENT): New macro.
919 (mark_memory): Omit 3rd (offset) arg; caller changed.
920 Don't assume EMACS_INT alignment is the same as pointer alignment.
921
df1bbe5b
SM
9222011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
923
924 * keyboard.c (read_key_sequence_remapped): New var.
925 (read_key_sequence): Compute remapping in the right buffer.
926 (command_loop_1): Use read_key_sequence's remapping directly.
927
51553db6
SM
9282011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
929
32c1fffd
SM
930 * dired.c (file_name_completion): Don't expand file name.
931 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
932 before checking file name handler.
933
51553db6
SM
934 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
935 they've been requested explicitly (bug#9591).
936
b6bd1599 9372011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
938
939 * keymap.c (Fsingle_key_description): Use make_specified_string
940 instead of build_string to build string from push_key_description.
941 (Bug#5193)
942
f701dc2a
PE
9432011-09-30 Paul Eggert <eggert@cs.ucla.edu>
944
4222c55d
PE
945 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
946 This fixes a Y2038 bug on 64-bit hosts.
947 * buffer.c (reset_buffer):
948 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
949 (Fclear_buffer_auto_save_failure):
950 Use 0, not -1, to represent an unset failure time, since time_t
951 might not be signed.
952
f701dc2a
PE
953 Remove dependency on glibc malloc internals.
954 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
955 Move back here from lisp.h, but with their new implementations.
956 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
957 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
958 * charset.c (charset_table_init): New static var.
959 (syms_of_charset): Use it instead of xmalloc. This removes a
960 dependency on glibc malloc internals. See Eli Zaretskii's comment in
961 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
962 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
963 Move back to alloc.c.
964 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
965 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
966
9ceebf39
JD
9672011-09-30 Jan Djärv <jan.h.d@swipnet.se>
968
969 * nsterm.m (windowDidResize): Call x_set_window_size only when
970 ns_in_resize is true. Otherwise set pixelwidth/height and
971 call change_frame_size (Bug#9628).
972
cb993c58
PE
9732011-09-30 Paul Eggert <eggert@cs.ucla.edu>
974
3930c88b
PE
975 Port --enable-checking=all to Fedora 14 x86-64.
976 * charset.c (syms_of_charset): Also account for glibc malloc's
977 internal overhead when calculating the initial malloc maximum.
978
cb993c58
PE
979 Port --enable-checking=all to Fedora 14 x86.
980 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
981 Move to lisp.h.
982 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
983 (overrun_check_realloc, overrun_check_free):
984 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
985 That way, xmalloc returns a properly-aligned pointer even if
986 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
987 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
988 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
989 into account when calculating the initial malloc maximum.
990 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
991 Move here from alloc.c, so that charset.c can use it too.
992 Properly align; the old code wasn't right for common 32-bit hosts
993 when configured with --enable-checking=all.
994 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
995 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
996
31bed486
EZ
9972011-09-29 Eli Zaretskii <eliz@gnu.org>
998
04c70788 999 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1000 use EDOM.
1001
fbcaa2f3
EZ
10022011-09-28 Eli Zaretskii <eliz@gnu.org>
1003
1004 * xdisp.c (compute_display_string_end): If there's no display
1005 string at CHARPOS, return -1.
1006
1007 * bidi.c (bidi_fetch_char): When compute_display_string_end
1008 returns a negative value, treat the character as a normal
1009 character not covered by a display string. (Bug#9624)
1010
a239d4e9
JB
10112011-09-28 Juanma Barranquero <lekktu@gmail.com>
1012
1013 * lread.c (Fread_from_string): Fix typo in docstring.
1014
88652fd5
EZ
10152011-09-27 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1018 newline, reseat the iterator instead of bidi-iterating there one
1019 character at a time. (Bug#9610)
32c1fffd
SM
1020 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1021 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1022
ed497dd4
AS
10232011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1024
1025 * lread.c (readevalloop): Use correct code for NBSP.
1026 (read1): Likewise. (Bug#9608)
1027
b2bf61aa
MA
10282011-09-25 Michael Albinus <michael.albinus@gmx.de>
1029
1030 * dbusbind.c (Fdbus_register_signal): When service is not
1031 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1032
32bbb17c
GM
10332011-09-25 Glenn Morris <rgm@gnu.org>
1034
1035 * buffer.c (truncate-lines): Doc fix.
1036
94e0933e
CY
10372011-09-24 Chong Yidong <cyd@stupidchicken.com>
1038
1039 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1040 (Fset_window_next_buffers): Doc fix.
1041
cddde921
GM
10422011-09-24 Glenn Morris <rgm@gnu.org>
1043
1044 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1045
1260aef1
PE
10462011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1047
25b4bfa0
PE
1048 Fix minor problems found by static checking.
1049 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1050 * indent.c (Fvertical_motion): Fix == vs = typo.
1051
e3cbd34b
EZ
10522011-09-24 Eli Zaretskii <eliz@gnu.org>
1053
a66cfb1c
SM
1054 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1055 Default value is now t. Doc fix.
6bf7006f 1056
e3cbd34b 1057 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1058 logic when moving up, not only when moving down. Fix the
e3cbd34b 1059 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1060 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1061
1062 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1063 CHARPOS is covered by a display string which includes newlines.
1064 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1065 is covered by a display string with embedded newlines.
1066
a3de0cbd
MA
10672011-09-24 Michael Albinus <michael.albinus@gmx.de>
1068
1069 * dbusbind.c (Fdbus_register_signal): Add match rule to
1070 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1071 (Fdbus_register_method, Vdbus_registered_objects_table):
1072 Fix docstring.
a3de0cbd 1073
b260039d
JM
10742011-09-24 Jim Meyering <meyering@redhat.com>
1075
32c1fffd 1076 do not ignore write error for any output size
b260039d
JM
1077 The previous change was incomplete.
1078 While it makes emacs --batch detect the vast majority of stdout
1079 write failures, errors were still ignored whenever the output size is
1080 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1081 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1082 && echo FAIL: ignored write error
1083 FAIL: ignored write error
1084 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1085 && echo FAIL: ignored write error
1086 FAIL: ignored write error
1087 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1088
8eca8a7c
AS
10892011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1090
1091 * emacs.c (Fkill_emacs): In noninteractive mode exit
1092 non-successfully if a write error occurred on stdout. (Bug#9574)
1093
3341db62
EZ
10942011-09-21 Eli Zaretskii <eliz@gnu.org>
1095
1096 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1097 the xassert test.
1098
1099 * dispextern.h (struct it): Update the comment documenting what
1100 can it->OBJECT be.
1101
8c203dbf
EZ
11022011-09-20 Eli Zaretskii <eliz@gnu.org>
1103
1104 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1105 a display string, extend search for cursor position to end of row.
1106 (find_row_edges): If the row ends in a newline from a display
1107 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1108 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1109 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1110 non-empty line. Fixes confusing cursor motion with arrow keys at
1111 the beginning of a line that starts with whitespace.
8c203dbf 1112
a4824228
LMI
11132011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1114
1115 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1116 (bug#9493).
1117
33ed493b
CY
11182011-09-18 Chong Yidong <cyd@stupidchicken.com>
1119
1120 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1121 boolean (Bug#9154).
1122
56cd55c8
EZ
11232011-09-18 Eli Zaretskii <eliz@gnu.org>
1124
1125 * xdisp.c (display_line): Record maximum and minimum buffer
1126 positions even if no glyphs were produced (e.g., by a zero-width
1127 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1128 buffer positions that will be removed from the glyph row because
1129 they don't fit.
c02dcedf
EZ
1130 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1131 column is beyond frame width: don't subtract 1 "pixel" when
1132 computing width of the stretch.
3e62b7e0
EZ
1133 (reseat_at_next_visible_line_start): Undo the change made on
1134 2011-09-17 that saved paragraph information and restored it after
1135 the call to `reseat'. (Bug#9545)
56cd55c8 1136
5ed99d36 11372011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1138
1139 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1140 and turn window cursor on if cleared (Bug#9415).
1141
5ed99d36 11422011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1143
1144 * search.c (boyer_moore): Take unibyte characters from pattern
1145 literally. (Bug#9458)
1146
9bade7b2
EZ
11472011-09-18 Eli Zaretskii <eliz@gnu.org>
1148
1149 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1150
e5e9d610
PE
11512011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1152
87e4427a
PE
1153 Fix minor problem found by static checking.
1154 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1155 initialized, to pacify gcc -Wuninitialized.
1156
e5e9d610
PE
1157 * fileio.c: Report proper errno when syscall falls.
1158 (Finsert_file_contents): Save and restore errno,
1159 so that report_file_error outputs the correct diagnostic.
1160 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1161
a1674f0b
EZ
11622011-09-18 Eli Zaretskii <eliz@gnu.org>
1163
1164 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1165
fbfb6dd4
EZ
11662011-09-17 Eli Zaretskii <eliz@gnu.org>
1167
1168 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1169 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1170
bb187662
EZ
11712011-09-17 Eli Zaretskii <eliz@gnu.org>
1172
1137e8b8 1173 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1174 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1175
1176 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1177 (bidi_find_paragraph_start): Search back for paragraph beginning
1178 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1179 (bidi_move_to_visually_next): Only trigger paragraph-related
1180 computations when the last character is a newline or at EOB, not
1181 just any NEUTRAL_B. (Bug#9470)
1182
bb187662
EZ
1183 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1184 truncated lines if point is covered by a display string. (Bug#9524)
1185
2e621251
PE
11862011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1189 (cons_to_x_long): New function.
1190 (lisp_data_to_selection_data): Use it. Correct the test for
1191 short-versus-long data; it was negated. Break out of vector
1192 loop, for efficiency, when a long datum is discovered.
1193
91a15bc6
SM
11942011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1195
1196 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1197
b41c3a35
EZ
11982011-09-16 Eli Zaretskii <eliz@gnu.org>
1199
1200 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1201 GCC PR/17406) by declaring this function with external scope.
1202
7812ba2d
PE
12032011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1206 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1207
cf7edc2a
AS
12082011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1209
1210 * editfns.c (Fformat): Correctly handle text properties on "%%".
1211
bd01620e
EZ
12122011-09-15 Eli Zaretskii <eliz@gnu.org>
1213
1214 * xterm.c (x_draw_composite_glyph_string_foreground):
1215 * w32term.c (x_draw_composite_glyph_string_foreground):
1216 * term.c (encode_terminal_code):
1217 * composite.c (composition_update_it, get_composition_id):
1218 * xdisp.c (get_next_display_element)
1219 (fill_composite_glyph_string): Add comments about special meaning
1220 of TAB characters in a composition.
1221
a02719a3
PE
12222011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1223
1224 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1225 This occurs when processing a multibyte format.
1226 Problem reported by Wolfgang Jenker.
a02719a3 1227
72589a3c
JB
12282011-09-15 Johan Bockgård <bojohan@gnu.org>
1229
1230 * xdisp.c (try_cursor_movement): Only check for exact match if
1231 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1232
1c14176c
PE
12332011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1234
1235 Remove unused external symbols.
1236 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1237 * xdisp.c (calc_pixel_width_or_height): Now static.
1238 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1239 * indent.c (check_display_width):
1240 * w32term.c: Fix comment to match code.
1241 * xterm.c, xterm.h (x_catching_errors): Remove.
1242
d2eea5b5
PE
12432011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 * xselect.c: Use signed conversions more consistently (Bug#9498).
1246 (selection_data_to_lisp_data): Assume incoming selection data are
1247 signed integers, not unsigned. This is to be consistent with
1248 outgoing selection data, which was modified to use signed integers
1249 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1250 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1251 expects long, not unsigned long.
1252
46888499
EZ
12532011-09-14 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1256 computation of loop end. Reported by Johan Bockgård
1257 <bojohan@gnu.org>.
1258
ef8ef9fb
CY
12592011-09-13 Chong Yidong <cyd@stupidchicken.com>
1260
1261 * frame.c (Fother_visible_frames_p): Function deleted.
1262
fa819fed
EZ
12632011-09-12 Eli Zaretskii <eliz@gnu.org>
1264
1265 * indent.c (compute_motion): Process display vector front to back
1266 rather than the other way around. (Bug#2496)
1267
2ba8e008
SM
12682011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1269
1270 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1271
20f53c69
CY
12722011-09-11 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * minibuf.c (Fread_from_minibuffer): Doc fix.
1275
d562d7a4
EZ
12762011-09-11 Eli Zaretskii <eliz@gnu.org>
1277
1278 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1279 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1280
1c4d7f3d
LMI
12812011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1282
1283 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1284 value for non-existent files.
1285
b885bf36
EZ
12862011-09-11 Eli Zaretskii <eliz@gnu.org>
1287
1288 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1289 set its "size" to -1. This will set the modtime_size field of
1290 the corresponding buffer to -1, which is what
1291 verify-visited-file-modtime expects for files that do not exist.
1292 (Bug#9139)
1293
6612f0bf
PE
12942011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1297 here ...
1298 * lisp.h: ... from here. push_key_description is no longer
1299 defined in keyboard.c, so its declaration should not be in
1300 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1301 logically belongs with push_key_description.
1302
dfb3f755
PE
13032011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1304
1305 * buffer.h: Include <sys/types.h> instead of <time.h>.
1306 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1307 Problem reported by Herbert J. Skuhra.
1308
3134906c
LMI
13092011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1310
1311 * xml.c (parse_region): Make the parsing work for
1312 non-comment-starting XML files again (bug#9144).
1313
8d903f4e
AS
13142011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1315
1316 * image.c (gif_load): Fix calculation of bottom and right corner.
1317 (Bug#9468)
1318
80ad64f4
EZ
13192011-09-10 Eli Zaretskii <eliz@gnu.org>
1320
1321 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1322 redisplay in small windows.
1323
208a048d
EZ
13242011-09-09 Eli Zaretskii <eliz@gnu.org>
1325
1326 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1327
9b1c252e
MR
13282011-09-08 Martin Rudalics <rudalics@gmx.at>
1329
1330 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1331 Operate on live windows only.
1332
2949f33b
JB
13332011-09-08 Juanma Barranquero <lekktu@gmail.com>
1334
1335 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1336
e08dcafd
EZ
13372011-09-07 Eli Zaretskii <eliz@gnu.org>
1338
1339 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1340 only under bidi iteration.
1341
115b96bd
JD
13422011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1343
1344 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1345
c8199d0f
PE
13462011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1349 Without this fix, the command to link temacs failed due to an
1350 undefined symbol __builtin_isnan. This is because
1351 /usr/include/iso/math_c99.h #defines isnan(x) to
1352 __builtin_isnan(x), but the bundled gcc, which identifies itself
1353 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1354 a __builtin_isnan.
1355 * floatfns.c (isnan): #undef, and then #define to a clone of
1356 what's in data.c.
1357 (Fisnan): Always define, since it's always available now.
1358 (syms_of_floatfns): Always define isnan at the Lisp level.
1359
e39b275c 13602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1361
1362 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1363
b2db44d9 13642011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1365
f4af5137 1366 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1367 The previous code assumed that file offsets (off_t values) fit in
1368 EMACS_INT variables, which is not true on typical 32-bit hosts.
1369 The code messed up by falsely reporting buffer overflow in cases
1370 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1371 when "big" contains more than 2**29 bytes, even though this
1372 inserts just one byte and does not overflow the buffer.
1373 (Finsert_file_contents): Store file offsets as off_t
1374 values, not as EMACS_INT values. Check for overflow when
1375 converting between EMACS_INT and off_t. When checking for
1376 buffer overflow or for overlap, take the offsets into account.
1377 Don't use EMACS_INT for small values where int suffices.
1378 When checking for overlap, fix a typo: ZV was used where
1379 ZV_BYTE was intended.
1380 (Fwrite_region): Don't assume off_t fits into 'long'.
1381 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1382
ecfc0a49
MA
13832011-09-05 Michael Albinus <michael.albinus@gmx.de>
1384
1385 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1386
6511acf2 13872011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1388
0999621a 1389 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1390
1391 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1392 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1393 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1394 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1395 (modify_event_symbol): Do not assume that the length of
1396 name_alist_or_stem is safe to alloca and fits in int.
1397 (Fexecute_extended_command): Likewise for function name and binding.
1398 (Frecursion_depth): Wrap around reliably on integer overflow.
1399 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1400 since some callers pass EMACS_INT values.
1401 (Fsingle_key_description): Don't crash if symbol name contains more
1402 than MAX_ALLOCA bytes.
1403 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1404 (get_minibuffer): Arg is now EMACS_INT, not int.
1405 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1406 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1407 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1408
2be7d702
PE
1409 * dbusbind.c (signature_cat): New function.
1410 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1411 Do not overrun buffer; instead, report string overflow.
1412
9d1df220
PE
1413 * dispnew.c (add_window_display_history): Don't overrun buffer.
1414 Truncate instead; this is OK since it's just a log.
1415
33ef5c64
PE
1416 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1417 even if the time zone offset is outlandishly large.
1418 Don't mishandle offset == INT_MIN.
1419
66c6fdd5
PE
1420 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1421 when creating daemon; the previous buffer-overflow check was incorrect.
1422
d749b01b
PE
1423 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1424 which has the guts of the old verror function.
1425
b5cd1905
PE
1426 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1427 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1428
6e1a67fb
PE
1429 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1430 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1431 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1432 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1433 length of string rather than counting it via multiple sprintfs;
1434 that's simpler and more reliable.
c21721cc
PE
1435 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1436 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1437 sprintf, in case result does not fit in int.
1438
c57b67fc
PE
1439 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1440 (fontset_from_font): Print it.
1441
8a401434
PE
1442 * frame.c (tty_frame_count): Now printmax_t, not int.
1443 (make_terminal_frame, set_term_frame_name): Print it.
1444 (x_report_frame_params): In X, window IDs are unsigned long,
1445 not signed long, so print them as unsigned.
1446 (validate_x_resource_name): Check for implausibly long names,
1447 and don't assume name length fits in 'int'.
1448 (x_get_resource_string): Don't blindly alloca invocation name;
1449 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1450 not fit in int.
1451
6e1a67fb
PE
1452 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1453 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1454 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1455
0df02bf3
PE
1456 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1457 Use esprintf, not sprintf, in case result does not fit in int.
1458
48e30793
PE
1459 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1460 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1461 it as a large positive number.
1462 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1463 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1464
a66ff6d8
PE
1465 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1466 in case result does not fit in int.
1467
aca216ff
PE
1468 * print.c (float_to_string): Detect width overflow more reliably.
1469 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1470 buffer overrun. Don't assume list length fits in 'int'. Treat
1471 print length of 0 as 0, not as infinity; to be consistent with other
1472 uses of print length in this function. Don't overflow print length
1473 index. Don't assume hash table size fits in 'long', or that
1474 vectorlike size fits in 'unsigned long'.
1475
31c286f7
PE
1476 * process.c (make_process): Use printmax_t, not int, to format
1477 process-name gensyms.
1478
55e5faa1
PE
1479 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1480
80f2e268
PE
1481 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1482 to avoid potential buffer overrun.
1483
670741ab
PE
1484 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1485 if X resource line is longer than 512 bytes.
1486
b7163a50
PE
1487 * xfns.c (x_window): Make sprintf buffer a bit bigger
1488 to avoid potential buffer overrun.
1489
ae58ff1f
PE
1490 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1491
c43c8a6a
PE
1492 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1493
3f8236f4
PE
14942011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1495
53e9fe90 1496 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1497 Without these, Emacs silently mishandles large integers sometimes.
1498 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1499 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1500
6511acf2
PE
1501 * xdisp.c (try_window_id): Check Emacs fixnum range before
1502 converting to 'int'.
806add1d 1503
6511acf2 1504 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1505 Check that an Emacs fixnum is in range before assigning it to 'int'.
1506 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1507 values converted from Emacs fixnums.
1508 (Frecenter): Don't wrap around a line count if it is out of 'int'
1509 range; instead, treat it as an extreme value.
1510 (Fset_window_configuration, compare_window_configurations):
1511 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1512
6511acf2
PE
1513 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1514 that can exceed INT_MAX. Check that EMACS_INT value is in range
1515 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1516 (match_limit): Don't assume that a fixnum can fit in 'int'.
1517
6511acf2 1518 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1519 exceed INT_MAX.
1520
6511acf2 1521 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1522 (Fvertical_motion): Don't wrap around LINES values that don't fit
1523 in 'int'. Instead, treat them as extreme values. This is good
1524 enough for windows, which can't have more than INT_MAX lines anyway.
1525
fcb901a7
LMI
15262011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1527
0f2f6b6d
LMI
1528 * Require libxml/parser.h to avoid compilation warning.
1529
fcb901a7
LMI
1530 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1531
1532 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1533 since this reportedly can destroy thread storage.
1534
6e20a0d4
CY
15352011-08-30 Chong Yidong <cyd@stupidchicken.com>
1536
1537 * syntax.c (find_defun_start): Update all cache variables if
1538 exiting early (Bug#9401).
1539
148ae00e
EZ
15402011-08-30 Eli Zaretskii <eliz@gnu.org>
1541
f6cfbd8f
EZ
1542 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1543
148ae00e
EZ
1544 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1545 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1546 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1547
1548 * term.c (tty_append_glyph): New function.
1549 (produce_stretch_glyph): Static function and its prototype deleted.
1550
a66cfb1c
SM
1551 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1552 Add prototypes.
148ae00e 1553
c4a07a4c
PE
15542011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1555
1556 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1557 when checking :margin (Bug#9390).
1558 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1559 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1560 so that the name doesn't mislead. All uses changed.
1561
6bc8cd65
JB
15622011-08-28 Johan Bockgård <bojohan@gnu.org>
1563
1564 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1565 set_tty_hooks.
1566
dca4927e
EZ
15672011-08-27 Eli Zaretskii <eliz@gnu.org>
1568
1569 * xdisp.c (move_it_to): Don't bail out early when reaching
1570 position beyond to_charpos, if we are scanning backwards.
1571 (move_it_vertically_backward): When DY == 0, make sure we get to
1572 the first character in the line after the newline.
1573
f2cad773
PE
15742011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1575
1576 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1577 (ccl_driver): Do not generate an out-of-range pointer.
1578 (Fccl_execute_on_string): Remove unnecessary check for
1579 integer overflow, noted by Stefan Monnier in
1580 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1581 Remove a FIXME that didn't need fixing.
1582 Simplify the newly-introduced buffer reallocation code.
1583
0cae2cdb
JB
15842011-08-27 Juanma Barranquero <lekktu@gmail.com>
1585
1586 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1587
5fc295a4 15882011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1589
70c60eb2 1590 Integer and memory overflow issues (Bug#9196).
726e0ab1 1591
d31850da
PE
1592 * doc.c (get_doc_string): Rework so that
1593 get_doc_string_buffer_size is the actual buffer size, rather than
1594 being 1 less than the actual buffer size; this makes xpalloc more
1595 convenient.
1596
a69fbedb
PE
1597 * image.c (x_allocate_bitmap_record, cache_image):
1598 * xselect.c (Fx_register_dnd_atom):
1599 Simplify previous changes by using xpalloc.
1600
fe5c5d37
PE
1601 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1602 since either will do and ptrdiff_t is convenient with xpalloc.
1603
0065d054
PE
1604 * charset.c (charset_table_size)
1605 (struct charset_sort_data.priority): Now ptrdiff_t.
1606 (charset_compare): Don't overflow if priorities differ greatly.
1607 (Fsort_charsets): Don't assume list length fits in int.
1608 Check for size-calculation overflow when allocating sort data.
1609 (syms_of_charset): Allocate an initial charset table that is
1610 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1611
1612 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1613
1614 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1615 The actual value is always <= INT_MAX, and leaving it unsigned made
1616 overflow checking harder.
1617
1618 * dispextern.h (struct glyph_matrix.rows_allocated)
1619 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1620 with xpalloc. The values are still always <= INT_MAX.
1621
1622 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1623
1624 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1625 (SAFE_NALLOCA): New macro.
1626
1627 * region-cache.c (struct boundary.pos, find_cache_boundary)
1628 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1629 (set_cache_region, invalidate_region_cache)
1630 (revalidate_region_cache, know_region_cache, region_cache_forward)
1631 (region_cache_backward, pp_cache):
1632 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1633 so that ptrdiff_t * can be passed to xpalloc.
1634 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1635 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1636 (pp_cache): Don't assume cache_len fits in int.
1637 * region-cache.h: Adjust extern decls to match.
1638
1639 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1640 EMACS_INT, since either will do, for xpalloc.
1641
1642 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1643 (xnmalloc, xnrealloc, xpalloc): New functions.
1644
726e0ab1
PE
1645 * bidi.c (bidi_shelve_header_size): New constant.
1646 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1647 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1648
51f30bc5 1649 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1650 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1651 (overlay_strings):
1652 Don't update size of array until after memory allocation succeeds,
1653 because xmalloc/xrealloc may not return.
0065d054
PE
1654 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1655 now that we have proper integer overflow checking.
1656 (record_overlay_string, overlay_strings): Catch overflows when
1657 calculating size of overlay_str_buf.
726e0ab1 1658
0065d054
PE
1659 * callproc.c (Fcall_process): Check for size overflow when
1660 calculating size of args2.
1661 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1662 Normally we prefer signed values, but sticking with ptrdiff_t would
1663 require adding more-complicated checks.
726e0ab1
PE
1664
1665 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1666 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1667 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1668 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1669
1670 * character.c (Fstring): Check for size-calculation overflow.
1671
1672 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1673 unnecessary integer overflow. Check for size overflow.
1674 (encode_coding_object): Don't update size until xmalloc succeeds.
1675
1676 * composite.c (get_composition_id): Check for overflow in glyph
1677 length calculations.
1678
1679 Integer and memory overflow fixes for display code.
1680 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1681 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1682 (scrolling_window): Check for overflow in size calculations.
1683 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1684 Don't assume glyph table len fits in int.
1685 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1686 (row_table_size): Now ptrdiff_t, not int.
1687 (scrolling_window): Avoid overflow in size calculations.
1688 Don't update size until allocation succeeds.
1689 * fns.c (concat): Check for overflow in size calculations.
1690 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1691 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1692 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1693
1694 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1695 (get_doc_string): Check for size calculation overflow.
1696 Don't update size until allocation succeeds.
1697 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1698 EMACS_INT, where ptrdiff_t will do.
1699 (Fsubstitute_command_keys): Check for string overflow.
1700
1701 * editfns.c (set_time_zone_rule): Don't assume environment length
1702 fits in int.
1703 (message_length): Now ptrdiff_t, not int.
1704 (Fmessage_box): Don't update size until allocation succeeds.
1705 Don't assume message length fits in int.
1706 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1707
0065d054
PE
1708 * emacs.c (main): Do not reallocate argv, since there is a null at
1709 the end that can be overwritten, and this way there's no need to
1710 worry about size-calculation overflow.
1711 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1712
1713 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1714 alloc succeeds.
1715 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1716
1717 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1718 (x_set_scroll_bar_width, x_figure_window_size):
1719 Check for integer overflow.
1720 (x_set_alpha): Do not assume XINT fits in int.
1721
1722 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1723 This is for the members text_lines, text_cols, total_lines, total_cols,
1724 where the system imposes an 'int' limit.
1725
1726 * fringe.c (Fdefine_fringe_bitmap):
1727 Don't update size until alloc works.
1728
1729 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1730 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1731
1732 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1733 Check for size-calculation overflow.
1734 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1735 do, as we prefer signed integers.
1736 (id_to_widget.max_size, id_to_widget.used)
1737 (xg_store_widget_in_map, xg_remove_widget_from_map)
1738 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1739 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1740 Use and return ptrdiff_t, not int.
1741 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1742 * gtkutil.h: Change prototypes to match the above.
1743
1744 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1745 are duplicate now that they've been promoted to lisp.h.
1746 (x_allocate_bitmap_record, x_alloc_image_color)
1747 (make_image_cache, cache_image, xpm_load):
1748 Don't update size until alloc is done.
1749 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1750 (x_detect_edges):
3256efce 1751 Check for size calculation overflow.
726e0ab1
PE
1752 (ct_colors_allocated_max): New constant.
1753 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1754 overflow.
3256efce 1755
726e0ab1
PE
1756 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1757 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1758 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1759 Use ptrdiff_t, not int, to count maps.
1760 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1761 calculations. Don't update size until allocation succeeds.
1762 Redo calculations to avoid overflow.
726e0ab1
PE
1763 * keyboard.h: Change prototypes to match the above.
1764
1765 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1766 to count maps.
1767 (current_minor_maps): Check for size calculation overflow.
1768 * keymap.h: Change prototypes to match the above.
1769
1770 * lread.c (read1, init_obarray): Don't update size until alloc done.
1771
1772 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1773 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1774
726e0ab1
PE
1775 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1776 Now ptrdiff_t, not int.
1777 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1778 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1779
1780 * process.c (Fnetwork_interface_list): Check for overflow
1781 in size calculation.
1782
1783 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1784
1785 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1786 overflow. Don't bother calling xmalloc when xrealloc will do.
1787
1788 * search.c (Freplace_match): Check for size calculation overflow.
1789 (Fset_match_data): Don't assume list lengths fit in 'int'.
1790
1791 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1792 for command line length. Do not attempt to address one before the
1793 beginning of an array, as that's not portable.
1794
1795 * term.c (max_frame_lines): Remove; unused.
1796 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1797 not int.
1798 (encode_terminal_code, calculate_costs): Check for size
1799 calculation overflow.
1800 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1801 table lengths and related sizes. Don't update size until alloc
1802 done. Redo calculations to avoid overflow.
1803 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1804
1805 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1806 subtracting pointers.
1807 (gobble_line): Check for overflow more carefully. Don't update size
1808 until alloc done.
1809
1810 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1811 Don't update size until alloc done.
1812 Redo size calculations to avoid overflow.
1813 Check for size calculation overflow.
0065d054 1814 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1815
1816 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1817 Use ptrdiff_t, not int, for sizes.
1818 (store_mode_line_noprop_char): Don't update size until alloc done.
1819
0065d054
PE
1820 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1821 Use ptrdiff_t, not int, for sizes.
1822 (Finternal_make_lisp_face, cache_face):
1823 Check for size calculation overflow.
1824 (cache_face): Treat size calculation overflows as if they were
1825 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1826
1827 * xfns.c (x_encode_text, x_set_name_internal)
1828 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1829 sizes, since they can exceed INT_MAX in size. Check for size
1830 calculation overflow.
1831
0065d054
PE
1832 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1833 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1834 Don't update size until alloc done.
1835
0065d054 1836 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1837 as sprintf is limited to int lengths.
1d526e2f 1838
252c5ee1
PE
1839 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1840 (X_LONG_MIN): New macros.
864d7ce7
PE
1841 Use them to make the following changes clearer.
1842 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1843 This change doesn't affect the value now, but it may help remind
1844 future maintainers not to raise the value too much later.
1845 (SELECTION_QUANTUM): Remove, replacing with ...
1846 (selection_quantum): ... new function, which avoids overflow.
1847 All uses changed.
1848 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1849 assumption that selection length fits in 'int'.
1850 (x_reply_selection_request, x_handle_selection_request)
1851 (x_get_window_property, receive_incremental_selection)
1852 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1853 (lisp_data_to_selection_data, clean_local_selection_data):
1854 Use ptrdiff_t, not int, to record length of selection.
1855 (x_reply_selection_request, x_get_window_property)
1856 (receive_incremental_selection, x_property_data_to_lisp):
1857 Redo calculations to avoid overflow.
1858 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1859 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1860 something.
1861 (x_get_window_property, receive_incremental_selection)
1862 (lisp_data_to_selection_data, x_property_data_to_lisp):
1863 Check for size-calculation overflow.
1864 (x_get_window_property, receive_incremental_selection)
1865 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1866 Don't store size until memory allocation succeeds.
1867 (x_get_window_property): Plug memory leak on memory exhaustion.
1868 Don't double-block input; malloc is safe here. Don't assume 2**34
1869 - 4 fits in unsigned long. Add an xassert to check
1870 XGetWindowProperty overflow. Be more careful about overflow
1871 calculations, and distinguish size from memory overflow better.
1872 (receive_incremental_selection): When tracing, don't assume
1873 unsigned int is less than INT_MAX.
1874 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1875 harmful) conversions of unsigned short to int.
1876 (lisp_data_to_selection_data): Don't assume that integers
1877 in the range -65535 through -1 fit in an X unsigned short.
1878 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1879 result parameters unless successful. Rely on cons_to_unsigned
1880 to report problems with elements; the old code wasn't right anyway.
1881 (x_check_property_data): Check for int overflow; we cannot use
1882 a wider type due to X limits.
1883 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1884
726e0ab1 1885 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1886
0065d054
PE
1887 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1888 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1889 (x_color_cells): Don't store size until memory allocation succeeds.
1890 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1891 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1892 (x_term_init): Don't assume length fits in int (sprintf is limited
1893 to int size).
bc18e09d 1894
ebfa62c0
PE
1895 Use ptrdiff_t for composition IDs.
1896 * character.c (lisp_string_width):
1897 * composite.c (composition_table_size, n_compositions)
1898 (get_composition_id, composition_gstring_from_id):
1899 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1900 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1901 * window.c (Frecenter):
1902 Use ptrdiff_t, not int, for composition IDs.
1903 * composite.c (get_composition_id): Check for integer overflow.
1904 * composite.h: Adjust prototypes to match the above changes.
1905
d3411f89
PE
1906 Use ptrdiff_t for hash table indexes.
1907 * category.c (hash_get_category_set):
1908 * ccl.c (ccl_driver):
1909 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1910 * coding.c (coding_system_charset_list, detect_coding_system):
1911 * coding.h (struct coding_system.id):
1912 * composite.c (get_composition_id, gstring_lookup_cache):
1913 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1914 * image.c (xpm_get_color_table_h):
1915 * lisp.h (hash_lookup, hash_put):
1916 * minibuf.c (Ftest_completion):
1917 Use ptrdiff_t for hash table indexes, not int (which is too
1918 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1919 32-bit --with-wide-int hosts).
1920
e097a6fa
PE
1921 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1922 Add a FIXME comment about memory leaks.
1923 (syms_of_charset): Don't assume xmalloc returns.
1924
5637687f
PE
1925 Don't assume that stated character widths fit in int.
1926 * character.c (Fchar_width, c_string_width, lisp_string_width):
1927 * character.h (CHAR_WIDTH):
1928 * indent.c (MULTIBYTE_BYTES_WIDTH):
1929 Use sanitize_char_width to avoid undefined and/or bad behavior
1930 with outlandish widths.
a66cfb1c 1931 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1932 now that we have two such functions. All uses changed.
1933 (sanitize_char_width): New inline function.
1934
a2271ba2
PE
1935 Don't assume that tab-width fits in int.
1936 * character.h (sanitize_width): New inline function.
1937 (SANE_TAB_WIDTH): New macro.
1938 (ASCII_CHAR_WIDTH): Use it.
1939 * indent.c (sane_tab_width): Remove. All uses replaced by
1940 SANE_TAB_WIDTH (current_buffer).
1941 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1942
18c52557
PE
1943 * fileio.c: Integer overflow issues with file modes.
1944 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1945
caeeedc1
PE
1946 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1947 Remove unreachable code.
1948 (read_hex, load_charset_map_from_file): Check for integer overflow.
1949
50849c52
PE
1950 * xterm.c: don't go over XClientMessageEvent limit
1951 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1952 (x_send_scroll_bar_event): Likewise. Check that the size does not
1953 exceed limits imposed by XClientMessageEvent, as well as the usual
1954 ptrdiff_t and size_t limits.
1955
b13995db
PE
1956 * keyboard.c: Overflow, signedness and related fixes.
1957 (make_lispy_movement): Use same integer type in forward decl
1958 that is used in the definition.
1959 (read_key_sequence, keyremap_step):
1960 Change bufsize argument back to int, undoing my 2011-03-30 change.
1961 We prefer signed types, and int is wide enough here.
1962 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1963 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1964 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1965 length, not size_t. Use ptrdiff_t for index, not int.
1966 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1967 possibility of integer overflow.
1968
13464394
PE
1969 Overflow, signedness and related fixes for images.
1970
1971 * dispextern.h (struct it.stack[0].u.image.image_id)
1972 (struct_it.image_id, struct image.id, struct image_cache.size)
1973 (struct image_cache.used, struct image_cache.ref_count):
1974 * gtkutil.c (update_frame_tool_bar):
1975 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1976 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1977 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1978 * nsmenu.m (update_frame_tool_bar):
1979 * xdisp.c (calc_pixel_width_or_height):
1980 * xfns.c (image_cache_refcount):
1981 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1982 on typical 64-bit hosts.
1983
1984 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1985 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1986 Omit unnecessary casts to int.
1987 (parse_image_spec): Check that integers fall into 'int' range
1988 when the callers expect that.
1989 (image_ascent): Redo ascent calculation to avoid int overflow.
1990 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1991 (lookup_image): Remove unnecessary tests.
1992 (xbm_image_p): Locals are now of int, not EMACS_INT,
1993 since parse_image_check makes sure they fit into int.
1994 (png_load, gif_load, svg_load_image):
1995 Prefer int to unsigned where either will do.
1996 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1997 old tiff_error_handler and tiff_warning_handler.
1998 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1999 stack buffer overflows. It uses only the features of vsnprintf
2000 that are common to both POSIX and native Microsoft.
2001 (tiff_error_handler, tiff_warning_handler): Use it.
2002 (tiff_load, gif_load, imagemagick_load_image):
2003 Don't assume :index value fits in 'int'.
2004 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2005 (imagemagick_load_image): Check that crop parameters fit into
2006 the integer types that MagickCropImage accepts. Don't assume
2007 Vimagemagick_render_type has a nonnegative value. Don't assume
2008 size_t fits in 'long'.
2009 (gs_load): Use printmax_t to print the widest integers possible.
2010 Check for integer overflow when computing image height and width.
2011
c11821d4
EZ
20122011-08-26 Eli Zaretskii <eliz@gnu.org>
2013
2014 * xdisp.c (redisplay_window): Don't force window start if point
2015 will be invisible in the resulting window. (Bug#9324)
2016
0c95fcf7
EZ
20172011-08-25 Eli Zaretskii <eliz@gnu.org>
2018
2019 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2020 the display spec is of the form `(space ...)'.
2021 (handle_display_spec): Return the value returned by
2022 handle_single_display_spec, not just 1 or zero.
2023 (handle_single_display_spec): If the display spec is of the form
2024 `(space ...)', and specifies display in the text area, return 2
2025 rather than 1.
fee65a97 2026 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2027 accurately, and prefer exact match for point under bidi.
2028 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2029
2030 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2031 into disp_prop; all users changed.
2032
2033 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2034 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2035 for the text covered by the display property.
2036
e4ed06f1
CY
20372011-08-25 Chong Yidong <cyd@stupidchicken.com>
2038
2039 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2040 Change return value to nil.
2041 (Frecord_buffer): Delete unused function.
2042
f67cdd7f
EZ
20432011-08-24 Eli Zaretskii <eliz@gnu.org>
2044
5980d4c6
EZ
2045 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2046 buffers, return left-to-right.
8610fe8b
EZ
2047 (set_cursor_from_row): Consider candidate row a win if its glyph
2048 represents a newline and point is on that newline. Fixes cursor
2049 positioning on the newline at EOL of R2L text within L2R
2050 paragraph, and vice versa.
2051 (try_cursor_movement): Check continued rows, in addition to
2052 continuation rows. Fixes unwarranted scroll when point enters a
2053 continued line of R2L text within an L2R paragraph, or vice versa.
2054 (cursor_row_p): Consider the case of point being equal to
2055 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2056 from the end of a short line to the beginning of a continued line
2057 of R2L text within L2R paragraph.
2058 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2059 composed characters.
5980d4c6 2060
f67cdd7f
EZ
2061 * bidi.c (bidi_check_type): Use xassert.
2062 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2063 members.
2064
bca633fb
EZ
20652011-08-23 Eli Zaretskii <eliz@gnu.org>
2066
2067 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2068 a character.
2069
4a5885a7
CY
20702011-08-23 Chong Yidong <cyd@stupidchicken.com>
2071
2072 * nsfont.m (ns_otf_to_script): Fix typo.
2073
0902a04e
KH
20742011-08-22 Kenichi Handa <handa@m17n.org>
2075
2076 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2077 extra slot even if the purpose is char-code-property-table.
2078
1a2e6670
EZ
20792011-08-23 Eli Zaretskii <eliz@gnu.org>
2080
8ddde651
EZ
2081 * xdisp.c (redisplay_window): When computing centering_position,
2082 account for the height of the header line. (Bug#8874)
2083
425cc014
EZ
2084 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2085 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2086 candidate is selected by the mouse, and that candidate has a
2087 composed character under the mouse.
2088
1a2e6670
EZ
2089 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2090 coordinates reported by pos-visible-in-window-p for a composed
2091 character in column zero.
2092
8b76d6f8
SM
20932011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2094
2095 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2096
dac347dd
EZ
20972011-08-22 Eli Zaretskii <eliz@gnu.org>
2098
2099 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2100 consider it a hit if to_charpos is anywhere in the range of the
2101 composed buffer positions.
2102
e013fb34
CY
21032011-08-22 Chong Yidong <cyd@stupidchicken.com>
2104
2105 * image.c (gif_load): Don't assume that each subimage has the same
2106 dimensions as the base image. Handle disposal method that is
2107 "undefined" by the gif spec (Bug#9335).
2108
bd1ba3e8
CY
21092011-08-20 Chong Yidong <cyd@stupidchicken.com>
2110
2111 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2112 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2113
54a1215b
EZ
21142011-08-19 Eli Zaretskii <eliz@gnu.org>
2115
823564e5
EZ
2116 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2117 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2118 from an Org mode buffer to a Speedbar frame.
2119
54a1215b
EZ
2120 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2121 a composition, take its buffer position from IT->cmp_it.charpos.
2122 Fixes cursor positioning at the beginning of a line that begins
2123 with a composed character.
2124
9778ebcc
EZ
21252011-08-18 Eli Zaretskii <eliz@gnu.org>
2126
0be6ee06
EZ
2127 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2128 character bidirectional type, use STRONG_L instead. Fixes crashes
2129 in a buffer produced by `describe-categories'.
2130
9778ebcc
EZ
2131 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2132 members before the level stack, so they would be saved and
2133 restored when copying iterator state. Fixes incorrect reordering
2134 around TABs covered by display properties.
2135
156bffbe
AS
21362011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2137
6b02f655 2138 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2139
72ad093b
CY
21402011-08-17 Chong Yidong <cyd@stupidchicken.com>
2141
2142 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2143 (internal_condition_case_2, internal_condition_case_n):
2144 Remove unnecessary aborts (Bug#9081).
72ad093b 2145
35774242
EZ
21462011-08-17 Eli Zaretskii <eliz@gnu.org>
2147
2148 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2149 has no `load' handler, try opening the file locally. (Bug#9311)
2150
db76dd85
KB
21512011-08-16 Ken Brown <kbrown@cornell.edu>
2152
2153 * gmalloc.c: Expand comment.
2154
b215eee5
EZ
21552011-08-16 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2158 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2159
a4579d33
KB
21602011-08-16 Ken Brown <kbrown@cornell.edu>
2161
2162 Fix memory allocation problems in Cygwin build (Bug#9273).
2163
2164 * unexcw.c ( __malloc_initialized): Declare external variable.
2165 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2166
8b76d6f8
SM
2167 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2168 New variables.
a4579d33
KB
2169 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2170 dumped emacs.
2171 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2172 in the static heap.
2173 [CYGWIN] (special_realloc): New function.
2174 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2175 requests to realloc storage in the static heap.
2176
3ebec551
PE
21772011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2178
2179 * bidi.c (bidi_initialize): Remove unused local.
2180
9fd8be00
EZ
21812011-08-15 Eli Zaretskii <eliz@gnu.org>
2182
6b02f655
SM
2183 * bidimirror.h:
2184 * biditype.h: Remove file.
2185 * makefile.w32-in ($(BLD)/bidi.$(O)):
2186 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2187
2188 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2189
2190 * chartab.c: Improve commentary for the uniprop_table API.
2191
32413314
EZ
2192 * bidi.c (bidi_paragraph_init): Support zero value of
2193 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2194 (bidi_initialize): Use uniprop_table instead of including
2195 biditype.h and bidimirror.h.
32413314 2196
9fd8be00
EZ
2197 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2198 coordinates of the iterator when restoring from ppos_it.
2199 (Bug#9296)
2200
5cf2b69b
KH
22012011-08-14 Kenichi Handa <handa@m17n.org>
2202
2203 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2204 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2205
daf17d00
EZ
22062011-08-14 Eli Zaretskii <eliz@gnu.org>
2207
2208 * xdisp.c (move_it_in_display_line_to): Don't invoke
2209 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2210 ppos_it. Fixes vertical cursor motion when line beginning is
2211 covered by an image. (Bug#9296)
2212
08e3161a
JD
22132011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2214
2215 * nsterm.h (ns_run_ascript): Declare.
2216 (NSAPP_DATA2_RUNASSCRIPT): Define.
2217
2218 * nsfns.m (as_script, as_result, as_status): New static variables.
2219 (ns_run_ascript): New function.
5e617bc2 2220 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2221 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2222 the event loop. Get status from as_status (Bug#7276).
2223
2224 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2225 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2226 the event loop (Bug#7276).
2227
a3720aa2
AS
22282011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2229
2230 * gnutls.c (QCgnutls_bootprop_priority)
2231 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2232 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2233 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2234 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2235 (QCgnutls_bootprop_verify_hostname_error)
2236 (QCgnutls_bootprop_callbacks_verify): Rename from
2237 Qgnutls_bootprop_..., all uses changed.
2238
2239 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2240 uses changed.
2241
0a0d27fb
PE
22422011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2243
19d5c50c
PE
2244 * xfaces.c (Qframe_set_background_mode): Now static.
2245 * dispextern.h (Qframe_set_background_mode): Remove decl.
2246
0a0d27fb
PE
2247 * process.c (Fnetwork_interface_info): Declare local only if needed.
2248
377538cb
JD
22492011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2250
2251 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2252 (Fnetwork_interface_list): Allocate in increments of bytes instead
2253 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2254 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2255 sockaddr.
2256 (struct ifflag_def): notrailers is smart on OSX.
2257 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2258 Get hardware address with getifaddrs if available.
2259
08fff70c
EZ
22602011-08-12 Eli Zaretskii <eliz@gnu.org>
2261
2262 * xdisp.c (iterate_out_of_display_property): xassert that
2263 IT->position is set to within IT->object's boundaries. Break from
2264 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2265 when IT->position is set up wrongly due to some bug.
2266 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2267 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2268 entry. Force push_it to save on the stack the current
2269 buffer/string position, to be restored by pop_it. Fix flags in
2270 the iterator structure wrt the object coming from a display
2271 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2272 properties. (Bug#9284)
2273
7be1c708 22742011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2275
7be1c708
CY
2276 * fontset.c (fontset_get_font_group): Add proper type checks.
2277 (Bug#9172)
aac0c6e3 2278
7be1c708 22792011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2280
7be1c708
CY
2281 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2282 and LC_VERSION_MIN_MACOSX.
2283 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2284 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2285
97bb72a6
EZ
22862011-08-08 Eli Zaretskii <eliz@gnu.org>
2287
2288 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2289 no-display-properties-and-no-overlays under bidi display.
2290 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2291 properties and overlays.
97bb72a6 2292
d5617611
CY
22932011-08-08 Chong Yidong <cyd@stupidchicken.com>
2294
37e11a63
CY
2295 * editfns.c (Fset_time_zone_rule): Document relationship with the
2296 setenv function.
2297
d5617611
CY
2298 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2299 the font entity extracted from the cache (Bug#8109).
2300
58872834
CY
23012011-08-07 Chong Yidong <cyd@stupidchicken.com>
2302
2303 * composite.c (autocmp_chars): Don't reset point. That is done by
2304 restore_point_unwind (Bug#5984).
2305
75bfc667
JL
23062011-08-07 Juri Linkov <juri@jurta.org>
2307
2308 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2309 to show the arg `TIME' instead of `TIMEVAL'.
2310
d1410150
EZ
23112011-08-06 Eli Zaretskii <eliz@gnu.org>
2312
2313 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2314 display property strides EOL and includes a newline, as in
2315 longlines-mode. (Bug#9254)
75b771e4
EZ
2316 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2317 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2318
2319 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2320 is non-zero, even if the data buffer is NULL. Fixes a crash in
2321 vertical-motion with longlines-mode. (Bug#9254)
2322
35928349
EZ
23232011-08-05 Eli Zaretskii <eliz@gnu.org>
2324
ec7cc85b
EZ
2325 * bidi.c <bidi_cache_total_alloc>: Now static.
2326 (bidi_initialize): Initialize bidi_cache_total_alloc.
2327
8b76d6f8 2328 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2329 cache. (Bug#9221)
2330
2331 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2332 amount allocated this far in `bidi_cache_total_alloc'.
2333 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2334 non-zero, only free the data buffer without restoring the cache
2335 contents. All callers changed.
2336
2337 * dispextern.h (bidi_unshelve_cache): Update prototype.
2338
2339 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2340 (move_it_in_display_line, move_it_to)
2341 (move_it_vertically_backward, move_it_by_lines): Replace the call
2342 to xfree to an equivalent call to bidi_unshelve_cache.
2343 (move_it_in_display_line_to): Fix logic of returning
412b6358 2344 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2345
e2e2423b
EZ
23462011-08-05 Eli Zaretskii <eliz@gnu.org>
2347
2348 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2349 came from a string character with a `cursor' property. (Bug#9229)
2350
ae9e757a
JD
23512011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2352
2353 * Makefile.in (LIB_PTHREAD): New variable.
2354 (LIBES): Add LIB_PTHREAD (Bug#9216).
2355
2356 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2357 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2358
213bd7f2
AS
23592011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2360
6b02f655 2361 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2362
99aaf75f
JD
23632011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2364
2365 * xterm.c (x_find_topmost_parent): New function.
2366 (x_set_frame_alpha): Find topmost parent window with
2367 x_find_topmost_parent and set the property there also (bug#9181).
2368 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2369
c74e9d86
PE
23702011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2371
2372 * callproc.c (Fcall_process): Avoid vfork clobbering
2373 the local vars buffer, coding_systems, current_dir.
2374
640c8776
SM
23752011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2376
2377 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2378
f26d0e4c
PE
23792011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2380
8a10d76c
PE
2381 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2382 so that it is not optimized away.
2383
f26d0e4c
PE
2384 * xdisp.c (compute_display_string_pos): Remove unused local.
2385
55439c61
EZ
23862011-08-02 Eli Zaretskii <eliz@gnu.org>
2387
2388 Fix slow cursor motion and scrolling in large buffers with
2389 selective display, like Org Mode buffers. (Bug#9218)
2390
2391 * dispextern.h (struct bidi_it): New member disp_prop_p.
2392
2393 * xdisp.c: Remove one-slot cache of display string positions.
2394 (compute_display_string_pos): Accept an additional argument
5e617bc2 2395 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2396 for a display string or property. If found, set DISP_PROP_P
2397 non-zero.
2398
2399 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2400 DISP_PROP_P, and pass it to compute_display_string_pos.
2401 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2402 non-zero. All callers of bidi_fetch_char changed.
2403
fb33fa43
SM
24042011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2405
2406 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2407
b099e063
DM
24082010-12-03 Don March <don@ohspite.net>
2409
2410 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2411 last character M-[char] is translated to ESC [char] (bug#7541).
2412
5cc7f7af
KH
24132011-08-02 Kenichi Handa <handa@m17n.org>
2414
d0fffa3f 2415 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2416
2417 * chartab.c (uniprop_table): Make it non-static.
2418
525d5e6e
EZ
24192011-08-01 Eli Zaretskii <eliz@gnu.org>
2420
2421 * xdisp.c (forward_to_next_line_start): Accept additional argument
2422 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2423 on the newline.
2424 (reseat_at_next_visible_line_start): Use the bidi iterator state
2425 returned by forward_to_next_line_start to restore the state of
2426 it->bidi_it after backing up to previous newline. (Bug#9212)
2427
31011111
AS
24282011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2429
2430 * regex.c (re_comp): Protoize.
2431 (re_exec): Fix return type.
2432 (regexec): Fix type of `ret'. (Bug#9203)
2433
476371c4
PE
24342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2435
e5d76069
PE
2436 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2437 This is needed if max-image-size is a floating-point number.
2438
9a79b20c
AS
24392011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2440
2441 * print.c (print_object): Print empty symbol as ##.
2442
2443 * lread.c (read1): Read ## as empty symbol.
2444
d8c2fa78
AA
24452011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2446
2447 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2448 setting frame foreground color (Bug#9175).
2449 (x_set_background_color): Likewise.
2450
ffe57a7a
AA
2451 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2452 contents (Bug#9176).
2453 (EmacsTooltip -init): Remove bezels and add shadows to
2454 tooltip windows.
2455
bf3492a5
AA
2456 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2457 or scroll bar (Bug#8470).
2458
d55e9c53
AA
2459 * nsfont.m (nsfont_open): Remove assignment to voffset and
2460 unnecessary vars hshink, expand, hd, full_height, min_height.
2461 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2462
2463 * nsterm.h (nsfont_info): Remove voffset field.
2464
d8c2fa78 24652011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2466
2467 Implement strike-through and overline on NextStep (Bug#8863).
2468
2469 * nsfont.m (nsfont_open): Use underline position provided by font,
2470 instead of hard-coded value of 2.
2471 (nsfont_draw): Call ns_draw_text_decoration instead.
2472
2473 * nsterm.h: Add declaration for ns_draw_text_decoration.
2474
2475 * nsterm.m (ns_draw_text_decoration): New function for drawing
2476 underline, overline, and strike-through.
2477 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2478 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2479 accommodate underlining, etc.
4843aac3 2480
4cc60b9b
EZ
24812011-07-28 Eli Zaretskii <eliz@gnu.org>
2482
bc7ece87
EZ
2483 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2484 default.
4cc60b9b 2485
476371c4
PE
24862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2487
66606eea
PE
2488 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2489 Without this fix, if a signal arrives just after memory fills up,
2490 'malloc' might be invoked reentrantly.
2491
476371c4
PE
2492 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2493 In other words, assume that every image size is allowed, on non-X
2494 hosts. This assumption is probably wrong, but it lets Emacs compile.
2495
f3fcc40d
AS
24962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2497
2498 * regex.c (re_iswctype): Convert return values to boolean.
2499
350c992f
EZ
25002011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2501
2502 * xdisp.c (compute_display_string_pos): Don't use cached display
2503 string position if the buffer had its restriction changed.
2504 (Bug#9184)
2505
5266b4bb
PE
25062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2507
2508 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2509
2573a837 25102011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2511
41f55ccd 2512 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2513
39e378da
PE
2514 * bidi.c: Integer size and overflow fixes.
2515 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2516 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2517 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2518 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2519 (bidi_find_other_level_edge):
2520 Use ptrdiff_t instead of EMACS_INT where either will do.
2521 This works better on 32-bit hosts configured --with-wide-int.
2522 (bidi_cache_ensure_space): Check for size-calculation overflow.
2523 Use % rather than repeated addition, for better worst-case speed.
2524 Don't set bidi_cache_size until after xrealloc returns, because it
2525 might not return.
2526 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2527 (bidi_cache_ensure_space): Also check that the bidi cache size
2528 does not exceed that of the largest Lisp string or buffer. See Eli
2529 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2530
5e927815
PE
2531 * alloc.c (__malloc_size_t): Remove.
2532 All uses replaced by size_t. See Andreas Schwab's note
2533 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2534
ca4aa935
PE
2535 * image.c: Improve checking for integer overflow.
2536 (check_image_size): Assume that f is nonnull, since
2537 it is always nonnull in practice. This is one less thing to
2538 worry about when checking for integer overflow later.
2539 (x_check_image_size): New function, which checks for integer
2540 overflow issues inside X.
2541 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2542 This removes the need for a memory_full check.
2543 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2544 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2545 (xbm_read_bitmap_data): Change locals back to 'int', since
2546 their values must fit in 'int'.
2547 (xpm_load_image, png_load, tiff_load):
2548 Invoke x_create_x_image_and_pixmap earlier,
2549 to avoid much needless work if the image is too large.
2550 (tiff_load): Treat overly large images as if
2551 x_create_x_image_and_pixmap failed, not as malloc failures.
2552 (gs_load): Use x_check_image_size.
2553
5f8f9cc2
PE
2554 * gtkutil.c: Omit integer casts.
2555 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2556 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2557
5adf60bc
PE
2558 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2559
c8907a93
PE
2560 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2561 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2562 would wrongly return t on a 64-bit host.
2563
e3c25c68
PE
2564 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2565 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2566 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2567 and therefore cause GCC to emit a bogus diagnostic in some cases.
2568
3f791afe
PE
2569 * image.c: Integer signedness and overflow and related fixes.
2570 This is not an exhaustive set of fixes, but it's time to
2571 record what I've got.
2572 (lookup_pixel_color, check_image_size): Remove redundant decls.
2573 (check_image_size): Don't assume that arbitrary EMACS_INT values
2574 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2575 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2576 (tiff_load, imagemagick_load_image):
2577 Check for overflow in size calculations.
2578 (x_create_x_image_and_pixmap): Remove unnecessary test for
2579 xmalloc returning NULL; that can't happen.
2580 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2581 (xpm_color_bucket): Use better integer hashing function.
2582 (xpm_cache_color): Don't possibly over-allocate memory.
2583 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2584 (gif_memory_source):
2585 Use ptrdiff_t, not int or size_t, to record sizes.
2586 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2587 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2588 either works, as we prefer signed integers.
2589 (tiff_read_from_memory, tiff_write_from_memory):
2590 Return tsize_t, not size_t, since that's what the TIFF API wants.
2591 (tiff_read_from_memory): Don't fail simply because the read would
2592 go past EOF; instead, return a short read.
2593 (tiff_load): Omit no-longer-needed casts.
2594 (Fimagemagick_types): Don't assume size fits into 'int'.
2595
3cc5a532
PE
2596 Improve hashing quality when configured --with-wide-int.
2597 * fns.c (hash_string): New function, taken from sxhash_string.
2598 Do not discard information about ASCII character case; this
2599 discarding is no longer needed.
2600 (sxhash-string): Use it. Change sig to match it. Caller changed.
2601 * lisp.h: Declare it.
2602 * lread.c (hash_string): Remove, since we now use fns.c's version.
2603 The fns.c version returns a wider integer if --with-wide-int is
2604 specified, so this should help the quality of the hashing a bit.
2605
b312a492
PE
2606 * emacs.c: Integer overflow minor fix.
2607 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2608 Define only if GNU_LINUX.
2609 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2610
dfd153ae
PE
2611 * dispnew.c: Integer signedness and overflow fixes.
2612 Remove unnecessary forward decls, that were a maintenance hassle.
2613 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2614 All uses changed.
2615 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2616 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2617 (prepare_desired_row, line_draw_cost):
2618 Use int, not unsigned, where either works.
2619 (save_current_matrix, restore_current_matrix):
2620 Use ptrdiff_t, not size_t, where either works.
2621 (init_display): Check for overflow more accurately, and without
2622 relying on undefined behavior.
2623
a81d11a3
PE
2624 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2625 Remove, replacing with the new symbols in lisp.h. All uses changed.
2626 * fileio.c (make_temp_name):
2627 * filelock.c (lock_file_1, lock_file):
2628 * xdisp.c (message_dolog):
2629 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2630 Use pMd etc. instead.
2631 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2632 replacing the pWIDE etc. symbols removed from editfns.c.
2633
3300e6fd
PE
2634 * keyboard.h (num_input_events): Now uintmax_t.
2635 This is (very slightly) less likely to mess up due to wraparound.
2636 All uses changed.
2637
fd05c7e9
PE
2638 * buffer.c: Integer signedness fixes.
2639 (alloc_buffer_text, enlarge_buffer_text):
2640 Use ptrdiff_t rather than size_t when either will do, as we prefer
2641 signed integers.
2642
903fe15d
PE
2643 * alloc.c: Integer signedness and overflow fixes.
2644 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2645 (__malloc_size_t): Default to size_t, not to int.
2646 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2647 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2648 Prefer ptrdiff_t to size_t when either would do, as we prefer
2649 signed integers.
2650 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2651 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2652 Now const. Initialize with values that are in range even if char
2653 is signed.
2654 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2655 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2656 These functions do the right thing with sizes > 2**32.
2657 (check_depth): Now ptrdiff_t, not int.
2658 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2659 Adjust to new way of storing sizes. Check for size overflow bugs
2660 in rest of code.
2661 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2662 slightly wrong anyway, as it missed one instance of
2663 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2664 (refill_memory_reserve): Omit needless cast to size_t.
2665 (mark_object_loop_halt): Mark as externally visible.
2666
ac82cc6a
PE
2667 * xselect.c: Integer signedness and overflow fixes.
2668 (Fx_register_dnd_atom, x_handle_dnd_message):
2669 Use ptrdiff_t, not size_t, since we prefer signed.
2670 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2671 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2672 x_dnd_atoms_size and x_dnd_atoms_length.
2673
c2d1e36d
PE
2674 * doprnt.c: Prefer signed to unsigned when either works.
2675 * eval.c (verror):
2676 * doprnt.c (doprnt):
2677 * lisp.h (doprnt):
2678 * xdisp.c (vmessage):
2679 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2680 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2681 prefer signed arithmetic to avoid comparison confusion.
2682 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2683 but is a bit tricky.
2684
0e926e56
PE
2685 Assume freestanding C89 headers, string.h, stdlib.h.
2686 * data.c, doprnt.c, floatfns.c, print.c:
2687 Include float.h unconditionally.
2688 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2689 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2690 * regex.c: Likewise for stddef.h, string.h.
2691 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2692 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2693 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2694 (STDC_HEADERS): Remove obsolete defines.
2695 * sysdep.c: Include limits.h unconditionally.
2696
9cfdb3ec
PE
2697 Assume support for memcmp, memcpy, memmove, memset.
2698 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2699 * regex.c (memcmp, memcpy):
2700 Remove; we assume C89 now.
2701
2702 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2703 (__malloc_safe_bcopy): Remove; no longer needed.
2704
cf950e6b 2705 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2706 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2707 well either way, and we prefer signed to unsigned.
2708
dbf38e02
LMI
27092011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2710
2711 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2712 closes the connection while we're reading (bug#9182).
2713
d6f0886c 27142011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2715
d6f0886c
JD
2716 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2717 are specified (Bug#9168).
24e0f6b1 2718
2eb1f9e6
PE
27192011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2722 Found by GCC static checking and --with-wide-int on a 32-bit host.
2723
22381272 27242011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2725
2726 * xdisp.c (compute_display_string_pos): Fix logic of caching
2727 previous display string position. Initialize cached_prev_pos to
2728 -1. Fixes slow-down at the beginning of a buffer.
2729
f25e39b4
EZ
27302011-07-24 Eli Zaretskii <eliz@gnu.org>
2731
2732 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2733 for attrs[LFACE_FONTSET_INDEX].
2734
04c4b52e
PE
27352011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 * xml.c (parse_region): Remove unused local
2738 that was recently introduced.
2739
c1734fbd
EZ
27402011-07-23 Eli Zaretskii <eliz@gnu.org>
2741
be18c5a5
EZ
2742 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2743 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2744
c1734fbd
EZ
2745 * xdisp.c (move_it_in_display_line_to): Record the best matching
2746 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2747 exit if none of the characters scanned was an exact match.
2748 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2749 when exact match is impossible due to invisible text, and the
2750 lines are truncated.
2751
a258d627
JD
27522011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2753
2754 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2755 for OSX >= 10.7.
2756
b6d5a689
EZ
27572011-07-22 Eli Zaretskii <eliz@gnu.org>
2758
0f74f785
EZ
2759 Fix a significant slow-down of cursor motion with C-n, C-p,
2760 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2761 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2762 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2763 (next_element_from_buffer): Call compute_stop_pos_backwards to
2764 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2765 base_level_stop.
2766 (reseat): Don't look for prev_stop, as that could mean a very long
2767 run.
2768 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2769 <cached_disp_overlay_modiff>: Cache for last found display string
2770 position.
551918c1 2771 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2772 about the same buffer in the same area of character positions, and
2773 the buffer wasn't changed since the time the display string
2774 position was cached.
551918c1 2775
b2d0c91a
EZ
27762011-07-22 Eli Zaretskii <eliz@gnu.org>
2777
2778 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2779 is an integer, which is important for empty lines. (Bug#9149)
2780
043604ee
CY
27812011-07-22 Chong Yidong <cyd@stupidchicken.com>
2782
2783 * frame.c (Fmodify_frame_parameters): In tty case, update the
2784 default face if necessary (Bug#4238).
2785
da4adb04
CY
27862011-07-21 Chong Yidong <cyd@stupidchicken.com>
2787
2788 * editfns.c (Fstring_to_char): No need to explain what a character
2789 is in the docstring (Bug#6576).
2790
9abd0532
LMI
27912011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2792
2793 * xml.c (parse_region): Make sure we always return a tree.
2794
36881d16
HK
27952011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2796
2797 * xml.c (parse_region): If a document contains only comments,
2798 return that, too.
2799
1e98674d
LMI
28002011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2801
2802 * xml.c (make_dom): Return comments, too.
2803
590bd467
PE
28042011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2805
2806 Port to OpenBSD.
2807 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2808 and the surrounding thread.
2809 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2810 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2811 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2812 timer goes off.
2813 * s/openbsd.h (BROKEN_SIGIO): Define.
2814 * unexelf.c (unexec) [__OpenBSD__]:
2815 Don't update the .mdebug section of the Alpha COFF symbol table.
2816
f41628b2
LMI
28172011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2818
2819 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2820 (bug#8460).
2821
b59b67c5
PE
28222011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2823
15e3a074
PE
2824 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2825 This fixes some race conditions on the permissions of any newly
2826 created file.
2827
41bed37d
PE
2828 * alloc.c (valid_pointer_p): Use pipe, not open.
2829 This fixes some permissions issues when debugging.
2830
b59b67c5
PE
2831 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2832 If fchown fails to set both uid and gid, try to set just gid,
2833 as that is sometimes allowed. Adjust the file's mode to eliminate
2834 setuid or setgid bits that are inappropriate if fchown fails.
2835
925a6be7
SM
28362011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2837
2838 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2839 to compare Lisp_Objects.
2840 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2841 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2842 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2843
52968808
AS
28442011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2845
0a6a104b
AS
2846 * lread.c (read_integer): Unread even EOF character.
2847 (read1): Likewise. Properly record start position of symbol.
2848
52968808
AS
2849 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2850 symbol character follows.
2851
9e381cdd
PE
28522011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2853
2854 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2855 This works around a problem with the previous change to Fcopy_file.
2856 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2857 and without this change, GCC might complain about discarding
2858 fchown's return value.
2859
b5641435
JB
28602011-07-16 Juanma Barranquero <lekktu@gmail.com>
2861
2862 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2863
a8031457
PE
28642011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2867
dd889327
LMI
28682011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2869
750c33f7
LMI
2870 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2871 it's used from the C level.
2872
dd889327
LMI
2873 * process.c: Use the same condition for POLL_FOR_INPUT in both
2874 keyboard.c and process.c (bug#1858).
2875
87e86684
LM
28762011-07-09 Lawrence Mitchell <wence@gmx.li>
2877
2878 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2879 (Fgnutls_boot): Use it.
2880
64348f40
AS
28812011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2882
2883 * doc.c (Fsubstitute_command_keys): Revert last change.
2884
1d698799
LMI
28852011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2886
f863868c
LMI
2887 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2888 quotes the next character, and doesn't affect other longer
2889 sequences (bug#8935).
2890
1d698799
LMI
2891 * lread.c (syms_of_lread): Clarify that is isn't only
2892 `eval-buffer' and `eval-defun' that's affected by
2893 `lexical-binding' (bug#8460).
2894
aa4b6df6
EZ
28952011-07-15 Eli Zaretskii <eliz@gnu.org>
2896
2897 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2898 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2899
5d856da6
PE
29002011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2901
ad6042bb
PE
2902 Fix minor problems found by static checking.
2903 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2904 (elsz): Now a signed constant, not a size_t var. We prefer signed
2905 types to unsigned, to avoid integer comparison confusion. Without
2906 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2907 "cannot optimize loop, the loop counter may overflow", a symptom
2908 of the confusion.
f00bbb22 2909 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2910 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2911
6468f31c
LMI
29122011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2913
49080b10
LMI
2914 * search.c (Fre_search_backward): Mention `case-fold-search' in
2915 all the re_search_* functions (bug#8138).
2916
6468f31c
LMI
2917 * keyboard.c (Fopen_dribble_file): Document when the file is
2918 closed (bug#8056).
2919
c965adc5
EZ
29202011-07-14 Eli Zaretskii <eliz@gnu.org>
2921
df9733bf
EZ
2922 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2923 bidi_cache_idx.
2924
0bb23927
EZ
2925 Support bidi reordering of display and overlay strings.
2926 * xdisp.c (compute_display_string_pos)
2927 (compute_display_string_end): Accept additional argument STRING.
2928 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2929 (reseat_to_string): Initialize bidi_it->string.s and
2930 bidi_it->string.schars.
2931 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2932 NULL (avoids a crash in bidi_paragraph_init).
2933 Initialize itb.string.lstring.
0bb23927
EZ
2934 (init_iterator): Call bidi_init_it only of a valid
2935 buffer position was specified. Initialize paragraph_embedding to
2936 L2R.
2937 (reseat_to_string): Initialize the bidi iterator.
2938 (display_string): If we need to ignore text properties of
2939 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2940 original value of -1 will not work with bidi.)
2941 (compute_display_string_pos): First arg is now struct
2942 `text_pos *'; all callers changed. Support display properties on
2943 Lisp strings.
2944 (compute_display_string_end): Support display properties on Lisp
2945 strings.
2946 (init_iterator, reseat_1, reseat_to_string): Initialize the
2947 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2948 when iterating on a string not from display properties).
640c8776
SM
2949 (compute_display_string_pos, compute_display_string_end):
2950 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2951 arrow keys.
2952 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2953 base_level_stop; instead, set base_level_stop to BEGV.
2954 Fixes crashes in vertical-motion.
0bb23927
EZ
2955 (next_element_from_buffer): Improve commentary for when
2956 the iterator is before prev_stop.
2957 (init_iterator): Initialize bidi_p from the default value of
2958 bidi-display-reordering, not from buffer-local value. Use the
2959 buffer-local value only if initializing for buffer iteration.
2960 (handle_invisible_prop): Support invisible properties on strings
2961 that are being bidi-reordered.
2962 (set_iterator_to_next): Support bidi reordering of C strings and
2963 Lisp strings.
2964 (next_element_from_string): Support bidi reordering of Lisp
2965 strings.
2966 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2967 (display_string): Support display of R2L glyph rows.
2968 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2969 (init_iterator): Don't initialize it->bidi_p for strings
2970 here.
2971 (reseat_to_string): Initialize it->bidi_p for strings here.
2972 (next_element_from_string, next_element_from_c_string)
2973 (next_element_from_buffer): Add xassert's for correspondence
2974 between IT's object being iterated and it->bidi_it.string
2975 structure.
2976 (face_before_or_after_it_pos): Support bidi iteration.
2977 (next_element_from_c_string): Handle the case of the first string
2978 character that is not the first one in the visual order.
2979 (get_visually_first_element): New function, refactored from common
2980 parts of next_element_from_buffer, next_element_from_string, and
2981 next_element_from_c_string.
2982 (tool_bar_lines_needed, redisplay_tool_bar)
2983 (display_menu_bar): Force left-to-right direction. Add a FIXME
2984 comment for making that be controlled by a user option.
2985 (push_it, pop_it): Save and restore the state of the
2986 bidi iterator. Save and restore the bidi_p flag.
2987 (pop_it): Iterate out of display property for string iteration as
2988 well.
2989 (iterate_out_of_display_property): Support iteration over strings.
2990 (handle_single_display_spec): Set up it->bidi_it for iteration
2991 over a display string, and call bidi_init_it.
2992 (handle_single_display_spec, next_overlay_string)
2993 (get_overlay_strings_1, push_display_prop): Set up the bidi
2994 iterator for displaying display or overlay strings.
2995 (forward_to_next_line_start): Don't use the shortcut if
2996 bidi-iterating.
2997 (back_to_previous_visible_line_start): If handle_display_prop
2998 pushed the iterator stack, restore the internal state of the bidi
2999 iterator by calling bidi_pop_it same number of times.
3000 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3001 and we are bidi-iterating, don't decrement the iterator position;
3002 instead, set the first_elt flag in the bidi iterator, to produce
3003 the same effect.
3004 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3005 (push_display_prop): xassert that we are iterating a buffer.
3006 (push_it, pop_it): Save and restore paragraph_embedding member.
3007 (handle_single_display_spec, next_overlay_string)
3008 (get_overlay_strings_1, reseat_1, reseat_to_string)
3009 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3010 correctly. Don't assume unibyte strings are not bidi-reordered.
3011 (compute_display_string_pos)
3012 (compute_display_string_end): Fix handling the case of C string.
3013 (push_it, pop_it): Save and restore from_disp_prop_p.
3014 (handle_single_display_spec, push_display_prop): Set the
3015 from_disp_prop_p flag.
3016 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3017 (pop_it): Call iterate_out_of_display_property only if we are
3018 popping after iteration over a string that came from a display
3019 property. Fix a typo in popping stretch info. Add an assertion
3020 for verifying that the iterator position is in sync with the bidi
3021 iterator.
3022 (handle_single_display_spec, get_overlay_strings_1)
3023 (push_display_prop): Fix initialization of paragraph direction for
3024 string when that of the parent object is not yet determined.
3025 (reseat_1): Call bidi_init_it to resync the bidi
3026 iterator with IT's position. (Bug#7616)
3027 (find_row_edges): If ROW->start.pos gives position
3028 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3029 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3030 Reset the from_disp_prop_p flag.
3031 (SAVE_IT, RESTORE_IT): New macros.
3032 (pos_visible_p, face_before_or_after_it_pos)
3033 (back_to_previous_visible_line_start)
3034 (move_it_in_display_line_to, move_it_in_display_line)
3035 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3036 (try_scrolling, redisplay_window, display_line): Use them when
3037 saving a temporary copy of the iterator and restoring it back.
3038 (back_to_previous_visible_line_start, reseat_1)
3039 (init_iterator): Empty the bidi cache "stack".
3040 (move_it_in_display_line_to): If iterator ended up at
3041 EOL, but we never saw any buffer positions smaller than
3042 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3043 motion in bidi-reordered lines.
3044 (move_it_in_display_line_to): Record prev_method and prev_pos
3045 immediately before the call to set_iterator_to_next. Fixes cursor
3046 motion in bidi-reordered lines with stretch glyphs and strings
3047 displayed in margins. (Bug#8133) (Bug#8867)
3048 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3049 TO_CHARPOS.
640c8776
SM
3050 (pos_visible_p): Support positions in bidi-reordered lines.
3051 Save and restore bidi cache.
0bb23927
EZ
3052
3053 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3054 (bidi_paragraph_info): Delete unused struct.
3055 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3056 (bidi_cache_start): New variable.
3057 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3058 to zero.
3059 (bidi_cache_fetch_state, bidi_cache_search)
3060 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3061 (bidi_cache_find, bidi_peek_at_next_level)
3062 (bidi_level_of_next_char, bidi_find_other_level_edge)
3063 (bidi_move_to_visually_next): Compare cache index with
3064 bidi_cache_start rather than with zero.
3065 (bidi_fetch_char): Accept new argument STRING; all callers
3066 changed. Support iteration over a string. Support strings with
3067 display properties. Support unibyte strings. Fix the type of
3068 `len' according to what STRING_CHAR_AND_LENGTH expects.
3069 (bidi_paragraph_init, bidi_resolve_explicit_1)
3070 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3071 (bidi_level_of_next_char, bidi_move_to_visually_next):
3072 Support iteration over a string.
0bb23927
EZ
3073 (bidi_set_sor_type, bidi_resolve_explicit_1)
3074 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3075 can now be zero (for strings); special values 0 and -1 were
3076 changed to -1 and -2, respectively.
3077 (bidi_char_at_pos): New function.
3078 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3079 Call it instead of FETCH_MULTIBYTE_CHAR.
3080 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3081 initialized to valid values.
3082 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3083 values.
3084 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3085 the test for valid cached positions. Fix the logic for looking up
3086 the sentinel state in the cache. GCPRO the Lisp string we are
3087 iterating.
3088 (bidi_push_it, bidi_pop_it): New functions.
3089 (bidi_initialize): Initialize the bidi cache start stack pointer.
3090 (bidi_cache_ensure_space): New function, refactored from part of
3091 bidi_cache_iterator_state. Don't assume the required size is just
3092 one BIDI_CACHE_CHUNK away.
3093 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3094 (bidi_count_bytes, bidi_char_at_pos): New functions.
3095 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3096 always valid if bidi_cache_idx is valid.
3097 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3098 is valid if it's going to be used.
3099 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3100 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3101 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3102 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3103 (bidi_find_other_level_edge, bidi_cache_start_stack):
3104 All variables related to cache indices are now EMACS_INT.
c965adc5 3105
0bb23927
EZ
3106 * dispextern.h (struct bidi_string_data): New structure.
3107 (struct bidi_it): New member `string'. Make flag members be 1-bit
3108 fields, and put them last in the struct.
640c8776
SM
3109 (compute_display_string_pos, compute_display_string_end):
3110 Update prototypes.
0bb23927
EZ
3111 (bidi_push_it, bidi_pop_it): Add prototypes.
3112 (struct iterator_stack_entry): New members bidi_p,
3113 paragraph_embedding, and from_disp_prop_p.
3114 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3115 (bidi_shelve_cache, bidi_unshelve_cache):
3116 Declare prototypes.
0bb23927
EZ
3117
3118 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3119 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3120 and vector-like objects.
3121
3122 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3123 cache around display iteration.
3124
3125 * window.c (Fwindow_end, window_scroll_pixel_based)
3126 (displayed_window_lines, Frecenter): Save and restore the bidi
3127 cache around display iteration.
3128
3bbd2265
LMI
31292011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3130
3131 * editfns.c (Fdelete_region): Clarify the use of the named
3132 parameters (bug#6788).
3133
adc47434
MR
31342011-07-14 Martin Rudalics <rudalics@gmx.at>
3135
3136 * indent.c (Fvertical_motion): Set and restore w->pointm when
3137 saving and restoring the window's buffer (Bug#9006).
3138
837c31f8
LMI
31392011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3140
3141 * editfns.c (Fstring_to_char): Clarify just what is returned
3142 (bug#6576). Text by Eli Zaretskii.
3143
ac389d0c
JB
31442011-07-13 Juanma Barranquero <lekktu@gmail.com>
3145
3146 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3147
0be0ce47
EZ
31482011-07-13 Eli Zaretskii <eliz@gnu.org>
3149
3150 * buffer.c (mmap_find): Fix a typo.
3151
cd18e7e3
JB
31522011-07-13 Johan Bockgård <bojohan@gnu.org>
3153
3154 Fix execution of x selection hooks.
3155 * xselect.c (Qx_lost_selection_functions)
3156 (Qx_sent_selection_functions): New vars.
3157 (syms_of_xselect): DEFSYM them.
3158 (x_handle_selection_request): Pass Qx_sent_selection_functions
3159 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3160 (x_handle_selection_clear,x_clear_frame_selections):
3161 Pass Qx_lost_selection_functions rather than
3162 Vx_lost_selection_functions to Frun_hook_with_args.
3163
47ea7f44
PE
31642011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3165
ac389d0c 3166 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3167 The old code sometimes used this field without initializing it.
3168
47ea7f44
PE
3169 * alloc.c (gc_sweep): Don't read past end of array.
3170 In theory, the old code could also have corrupted Emacs internals,
3171 though it'd be very unlikely.
3172
bc985c87
AS
31732011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3174
3175 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3176 argument. (Bug#4026)
bc985c87 3177
0cf34688
LMI
31782011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3179
b3dadd76
LMI
3180 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3181 key" (bug#4257).
3182
0cf34688
LMI
3183 * window.c (Fset_window_start): Doc fix (bug#4199).
3184 (Fset_window_hscroll): Ditto.
3185
270768cd
PE
31862011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3187
077e3dda 3188 Fix minor new problems caught by GCC 4.6.1.
270768cd 3189 * term.c (init_tty): Remove unused local.
490011a6 3190 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3191 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3192 not used otherwise.
270768cd 3193
b1f58454
CY
31942011-07-12 Chong Yidong <cyd@stupidchicken.com>
3195
3196 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3197
22b9578d
LMI
31982011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3199
6e70ab07
LMI
3200 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3201 are the mini-buffer and the echo area (bug#3320).
3202
22b9578d
LMI
3203 * term.c (init_tty): Remove support for supdup, c10 and perq
3204 terminals, which are no longer supported (bug#1482).
3205
8974cc9f
JB
32062011-07-10 Johan Bockgård <bojohan@gnu.org>
3207
3208 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3209
a560d974
JD
32102011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3211
3212 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3213 for non-popups (Bug#3642).
3214
1dae0f0a
AS
32152011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3216
268c2c36 3217 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3218 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3219 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3220 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3221 * data.c (fmod): Likewise.
3222 * dispnew.c (swap_glyphs_in_rows): Likewise.
3223 * emacs.c (memory_warning_signal): Likewise.
3224 * floatfns.c (float_error): Likewise.
3225 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3226 (otf_open, font_otf_capability, generate_otf_features)
3227 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3228 Likewise.
3229 * image.c (pbm_read_file): Likewise.
3230 * indent.c (string_display_width): Likewise.
3231 * intervals.c (check_for_interval, search_for_interval)
3232 (inc_interval_count, count_intervals, root_interval)
3233 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3234 * lread.c (defalias): Likewise.
268c2c36 3235 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3236 * regex.c (set_image_of_range_1, set_image_of_range)
3237 (regex_grow_registers): Likewise.
3238 * sysdep.c (strerror): Likewise.
3239 * termcap.c (valid_filename_p, tprint, main): Likewise.
3240 * tparam.c (main): Likewise.
3241 * unexhp9k800.c (run_time_remap, save_data_space)
3242 (update_file_ptrs, read_header, write_header, calculate_checksum)
3243 (copy_file, copy_rest, display_header): Likewise.
3244 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3245 Likewise.
3246 * xdisp.c (check_it): Likewise.
3247 * xfaces.c (register_color, unregister_color, unregister_colors):
3248 Likewise.
3249 * xfns.c (print_fontset_result): Likewise.
3250 * xrdb.c (member, fatal, main): Likewise.
3251
99033785
PE
32522011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3253
3254 Fix minor problems found by static checking (Bug#9031).
3255 * chartab.c (char_table_set_range, map_sub_char_table):
3256 Remove unused locals.
3257 (uniprop_table): Now static.
3258 * composite.c (_work_char): Remove unused static var.
3259
9cb2ac56
JB
32602011-07-09 Juanma Barranquero <lekktu@gmail.com>
3261
3262 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3263
f25661f0
JD
32642011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3265
3266 * gtkutil.c (qttip_cb): Remove code without function.
3267
8278c4fe
EZ
32682011-07-09 Eli Zaretskii <eliz@gnu.org>
3269
3270 * w32.c (pthread_sigmask): New stub.
3271
1692ae2d 32722011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3273
8a6ebd58 3274 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3275 sigprocmask is portable only for single-threaded applications, and
3276 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3277 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3278 (LIBES): Use it.
3279 * callproc.c (Fcall_process):
3280 * process.c (create_process):
3281 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3282 Use pthread_sigmask, not sigprocmask.
123403e4 3283
1b854618
JD
32842011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3285
3286 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3287 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3288 wrong (Bug#8591).
3289
3fe4b549
JD
32902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3291
0ce7e563
JD
3292 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3293 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3294 (xg_hide_tooltip): Fix comment.
3295
3fe4b549
JD
3296 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3297 in registerServicesMenuSendTypes.
3298 (validRequestorForSendType): Don't check ns_return_types.
3299
3300 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3301 ns_return_type.
3302
5df75e47
JR
33032011-07-08 Jason Rumney <jasonr@gnu.org>
3304
22610910
JR
3305 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3306 SH_SHOW for hidden windows (Bug#5482).
3307
5df75e47
JR
3308 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3309 frame struct members of non-existent frames (Bug#6284).
3310
699c10bd
JD
33112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3312
4393663b
JD
3313 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3314 variable firstTime not needed on OSX >= 10.6.
3315 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3316 >= 10.5. Use setKnobProportion, setDoubleValue.
3317
3318 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3319 (MAC_OS_X_VERSION_10_5): Define if not defined.
3320 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3321 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3322 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3323
3324 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3325 cString and lossyCString on OSX >= 10.4
3326
58179cce 3327 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3328 sizeToFit on OSX >= 10.2.
3329
3330 * nsimage.m (allocInitFromFile): Don't use deprecated method
3331 bestRepresentationForDevice on OSX >= 10.6.
3332
3333 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3334 to avoid warning.
3335
3336 * emacs.c: Declare unexec_init_emacs_zone.
3337
a63e0781
JD
3338 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3339
699c10bd
JD
3340 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3341
3342 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3343 on svcsMenu (Bug#8842).
3344
3345 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3346 ns_return_types.
3347 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3348
3349 * nsterm.m (QUTF8_STRING): Declare.
3350 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3351 (validRequestorForSendType): Return type is (id).
3352 Change indexOfObjectIdenticalTo to indexOfObject.
3353 Check if we have local selection before returning self (Bug#8842).
3354 (writeSelectionToPasteboard): Put local selection into paste board
3355 if we have a local selection (Bug#8842).
3356 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3357
3358 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3359 (ns_get_local_selection): Declare.
3360
54e10184
LMI
33612011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3362
9888ff71
LMI
3363 * keymap.c (describe_map_tree): Don't insert a double newline at
3364 the end of the buffer (bug#1169) and return whether we inserted
3365 something.
3366
54e10184
LMI
3367 * callint.c (Fcall_interactively): Change "reading args" to
3368 "providing args" to try to clarify what it does (bug#1010).
3369
15fa4783
KH
33702011-07-07 Kenichi Handa <handa@m17n.org>
3371
3372 * composite.c (composition_compute_stop_pos): Ignore a static
3373 composition starting before CHARPOS (Bug#8915).
3374
3375 * xdisp.c (handle_composition_prop): Likewise.
3376
a8815b00
EZ
33772011-07-07 Eli Zaretskii <eliz@gnu.org>
3378
3379 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3380 (Bug#9015)
3381
ef7b981d 33822011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3383
3384 * character.h (unicode_category_t): New enum type.
3385
3386 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3387 (Qchar_code_property_table): New variable.
3388 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3389 (UNIPROP_COMPRESSED_FORM_P): New macros.
3390 (char_table_ascii): Uncompress the compressed values.
3391 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3392 Uncompress the compressed values.
ac389d0c 3393 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3394 (char_table_ref_and_range): Uncompress the compressed values.
3395 (sub_char_table_set): New arg is_uniprop. Callers changed.
3396 Uncompress the compressed values.
3397 (sub_char_table_set_range): Args changed. Callers changed.
3398 (char_table_set_range): Adjuted for the above change.
3399 (map_sub_char_table): Delete args default_val and parent. Add arg
3400 top. Give decoded values to a Lisp function.
640c8776 3401 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3402 values to a Lisp function. Gcpro more variables.
3403 (uniprop_table_uncompress)
3404 (uniprop_decode_value_run_length): New functions.
3405 (uniprop_decoder, uniprop_decoder_count): New variables.
3406 (uniprop_get_decoder, uniprop_encode_value_character)
3407 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3408 New functions.
3409 (uniprop_encoder, uniprop_encoder_count): New variables.
3410 (uniprop_get_encoder, uniprop_table)
3411 (Funicode_property_table_internal, Fget_unicode_property_internal)
3412 (Fput_unicode_property_internal): New functions.
3413 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3414 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3415 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3416 char-code-property-alist.
3417
640c8776 3418 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3419 Vunicode_category_table.
3420
640c8776 3421 * font.c (font_range): Adjust for the change of
c805dec0
KH
3422 Vunicode_category_table.
3423
76b397fb
DN
34242011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3425
3426 * m/iris4d.h: Remove file, move contents ...
3427 * s/irix6-5.h: ... here.
3428
22b4128e
PE
34292011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3430
3431 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3432 * alloc.c (mark_buffer):
3433 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3434 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3435 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3436 This isn't true in general, and it's particularly not true
3437 if Emacs is configured with --with-wide-int.
3438 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3439 New macros, used in the buffer.c change.
3440
869795d6
JD
34412011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3442
3443 * xsettings.c: Use both GConf and GSettings if both are available.
3444 (store_config_changed_event): Add comment.
3445 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3446 (store_tool_bar_style_changed): New functions.
5e617bc2 3447 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3448 (struct xsettings): Move font inside HAVE_XFT.
3449 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3450 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3451 Move inside HAVE_XFT.
640c8776 3452 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3453 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3454 also.
3455 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3456 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3457 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3458 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3459 (parse_settings): Move check for font inside HAVE_XFT.
3460 (read_settings, apply_xft_settings): Add comment.
3461 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3462 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3463 call store_font_name_changed.
3464 (xft_settings_event): Add comment.
3465 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3466 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3467 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3468 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3469 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3470 (xsettings_get_system_font, xsettings_get_system_normal_font):
3471 Add comment.
869795d6 3472
d8ed26bd
PE
34732011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3474
3475 Random fixes. E.g., (random) never returned negative values.
3476 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3477 subseconds part to the entropy, as that's a bit more random.
3478 Prefer signed to unsigned, since the signedness doesn't matter and
3479 in general we prefer signed. When given a limit, use a
3480 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3481 latter isn't right if USE_2_TAGS_FOR_INTS.
3482 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3483 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3484
cabf1cac
SM
34852011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3486
3487 * textprop.c (text_property_stickiness):
3488 Obey Vtext_property_default_nonsticky.
3489 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3490 * w32fns.c (syms_of_w32fns):
3491 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3492
6e9b2be9
PE
34932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3496 This is more efficient than Ffile_directory_p and avoids a minor race.
3497
90186c68
LMI
34982011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3499
7c301272
LMI
3500 * buffer.c (Foverlay_put): Say what the return value is
3501 (bug#7835).
3502
c4f2d8d4
LMI
3503 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3504 is a directory before asking whether to use the file name
3505 (bug#7564).
ad637907
LMI
3506 (barf_or_query_if_file_exists): Make the "File is a directory"
3507 error be more correct.
c4f2d8d4 3508
90186c68
LMI
3509 * fns.c (Frequire): Remove the mention of the .gz files, since
3510 that's installation-specific, but keep the mention of
3511 `get-load-suffixes'.
3512
da64016e
PE
35132011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3514
3515 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3516 Report string overflow if the output is too long.
3517
7d47b580
JB
35182011-07-04 Juanma Barranquero <lekktu@gmail.com>
3519
a555cb87
JB
3520 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3521 (syms_of_gnutls): Remove duplicate DEFSYM for
3522 Qgnutls_bootprop_verify_hostname_error, an error for
3523 Qgnutls_bootprop_verify_error (which is no longer used).
3524
7d47b580
JB
3525 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3526 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3527 Also (re)move comments that are misplaced or no longer relevant.
3528
1e49bfab
LMI
35292011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3530
3531 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3532
1485f4c0
CY
35332011-07-03 Chong Yidong <cyd@stupidchicken.com>
3534
3535 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3536 and background color parameters if they have been changed.
3537
a9ab721e
LMI
35382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3539
3540 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3541
cf7cff57
PE
35422011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3543
2e13213d
PE
3544 * xsettings.c (SYSTEM_FONT): Define only when used.
3545 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3546
cf7cff57
PE
3547 * keymap.c (access_keymap_1): Now static.
3548
7a8e04f7
CY
35492011-07-02 Chong Yidong <cyd@stupidchicken.com>
3550
3551 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3552 leave any prefix arg for the up event (Bug#1586).
3553
61352f62
LMI
35542011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3555
69bb1ef7
LMI
3556 * lread.c (syms_of_lread): Mention single symbols defined by
3557 `defvar' or `defconst' (bug#7154).
3558
61352f62 3559 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3560 (Frequire): Mention get-load-suffixes.
61352f62 3561
28545e04
MR
35622011-07-02 Martin Rudalics <rudalics@gmx.at>
3563
3564 * window.h (window): Remove clone_number slot.
3565 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3566 Remove.
3567 (make_parent_window, make_window, saved_window)
3568 (Fset_window_configuration, save_window_save): Don't deal with
3569 clone numbers.
3570 * buffer.c (Qclone_number): Remove declaration.
3571 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3572
3349e122
SM
35732011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3574
3575 Add multiple inheritance to keymaps.
3576 * keymap.c (Fmake_composed_keymap): New function.
3577 (Fset_keymap_parent): Simplify.
3578 (fix_submap_inheritance): Remove.
3579 (access_keymap_1): New function extracted from access_keymap to handle
3580 embedded parents and handle lists of maps.
3581 (access_keymap): Use it.
3582 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3583 (Fcopy_keymap): Handle embedded parents.
3584 (Fcommand_remapping, define_as_prefix): Simplify.
3585 (Fkey_binding): Simplify.
3586 (syms_of_keymap): Move minibuffer-local-completion-map,
3587 minibuffer-local-filename-completion-map,
3588 minibuffer-local-must-match-map, and
3589 minibuffer-local-filename-must-match-map to Elisp.
3590 (syms_of_keymap): Defsubr make-composed-keymap.
3591 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3592 (parse_menu_item): Trivial simplification.
3593
3279eb87
GM
35942011-07-01 Glenn Morris <rgm@gnu.org>
3595
3596 * Makefile.in (SETTINGS_LIBS): Fix typo.
3597
4550efdf
KI
35982011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3599
3600 * coding.c (Fencode_coding_string): Record the last coding system
3601 used, as the function doc string says (bug#8738).
3602
0949d2b6
JD
36032011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3604
3605 * xsettings.c (store_monospaced_changed): Take new font as arg and
3606 check for change against current_mono_font.
3607 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3608 (emacs_settings_constructor, emacs_settings_get_property)
3609 (emacs_settings_set_property, emacs_settings_class_init)
3610 (emacs_settings_init, gsettings_obj): Remove.
3611 (something_changedCB): New function for HAVE_GSETTINGS.
3612 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3613 with value as argument.
3614 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3615 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3616 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3617 "changed".
3618
3619 * xgselect.c: Add defined (HAVE_GSETTINGS).
3620 (xgselect_initialize): Ditto.
3621
3622 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3623 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3624 xg_select.
3625
bbc6b304
PE
36262011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3627
3628 * eval.c (struct backtrace): Simplify and port the data structure.
3629 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3630 signed bit field, as this assumption is not portable and it makes
3631 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3632 "char debug_on_exit : 1" as this is not portable either; instead,
3633 use the portable "unsigned int debug_on_exit : 1". Remove unused
3634 member evalargs. Remove obsolete comments about cc bombing out.
3635
9851bfc5
JD
36362011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3637
51bb811f 3638 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3639 Let HAVE_GSETTINGS override HAVE_GCONF.
3640 (store_monospaced_changed): New function.
3641 (EMACS_SETTINGS): A new type derived from GObject to handle
3642 GSettings notifications.
3643 (emacs_settings_constructor, emacs_settings_get_property)
3644 (emacs_settings_set_property, emacs_settings_class_init):
3645 New functions.
3646 (gsettings_client, gsettings_obj): New variables.
3647 (GSETTINGS_SCHEMA): New define.
3648 (something_changedCB): Call store_monospaced_changed.
3649 (init_gsettings): New function.
3650 (xsettings_initialize): Call init_gsettings.
3651 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3652 to NULL.
3653
640c8776 3654 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3655 GCONF_CFLAGS/LIBS.
3656
5386012d
MR
36572011-06-29 Martin Rudalics <rudalics@gmx.at>
3658
3659 * window.c (resize_root_window, grow_mini_window)
3660 (shrink_mini_window): Rename Qresize_root_window to
3661 Qwindow_resize_root_window and Qresize_root_window_vertically to
3662 Qwindow_resize_root_window_vertically.
3663
f13e0b08
PE
36642011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3665
3666 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3667
94515237
JB
36682011-06-27 Juanma Barranquero <lekktu@gmail.com>
3669
3670 * makefile.w32-in: Redesign dependencies so they reflect more
3671 clearly which files are directly included by each source file,
3672 and not through other includes.
3673
e43b6e43
MR
36742011-06-27 Martin Rudalics <rudalics@gmx.at>
3675
3676 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3677 (sort_overlays, overlay_strings): When an overlay's clone number
3678 matches the window's clone number process the overlay even if
3679 the overlay's window property doesn't match the current window.
3680
d68443dc
MR
3681 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3682 (Fwindow_hchild): Rename to Fwindow_left_child.
3683 (Fwindow_next): Rename to Fwindow_next_sibling.
3684 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3685 (resize_window_check): Rename to window_resize_check.
3686 (resize_window_apply): Rename to window_resize_apply.
3687 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3688 (Fdelete_other_windows_internal, resize_frame_windows)
3689 (Fsplit_window_internal, Fdelete_window_internal)
3690 (grow_mini_window, shrink_mini_window)
3691 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3692
c7e73be5
JD
36932011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3694
3695 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3696 (emacs_fixed_set_min_size): Remove.
3697 (emacs_fixed_new): Take frame as argument.
3698
3699 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3700 (_EmacsFixedPrivate): Remove minwidth/height.
3701 Add struct frame *f.
3702 (emacs_fixed_init): Initialize priv->f.
3703 (get_parent_class, emacs_fixed_set_min_size): Remove.
3704 (emacs_fixed_new): Set priv->f to argument.
3705 (emacs_fixed_get_preferred_width)
3706 (emacs_fixed_get_preferred_height): Use min_width/height from
3707 frames size_hint to set minimum and natural (Bug#8919).
3708 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3709 and use min_width/height from frames size_hint to set
3710 min_width/height (Bug#8919).
3711
3712 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3713 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3714 Fix indentation.
c7e73be5 3715
cf99dcf8
EZ
37162011-06-26 Eli Zaretskii <eliz@gnu.org>
3717
3718 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3719 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3720 called at ZV.
3721
029529ac
CY
37222011-06-26 Chong Yidong <cyd@stupidchicken.com>
3723
3724 * process.c (wait_reading_process_output): Bypass select if
3725 waiting for a cell while ignoring keyboard input, and input is
3726 pending. Suggested by Jan Djärv (Bug#8869).
3727
7a7ef429
PE
37282011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 Use gnulib's dup2 module instead of rolling our own.
3731 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3732
11fdef7d 37332011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3734
3735 * dispnew.c (scrolling_window): Before scrolling, turn off a
3736 mouse-highlight in the window being scrolled.
3737
cd3520a4
JB
37382011-06-24 Juanma Barranquero <lekktu@gmail.com>
3739
3740 Move DEFSYM to lisp.h and use everywhere.
3741
3742 * character.h (DEFSYM): Move declaration...
3743 * lisp.h (DEFSYM): ...here.
3744
3745 * gnutls.c:
3746 * minibuf.c:
3747 * w32menu.c:
3748 * w32proc.c:
3749 * w32select.c: Don't include character.h.
3750
3751 * alloc.c (syms_of_alloc):
3752 * buffer.c (syms_of_buffer):
3753 * bytecode.c (syms_of_bytecode):
3754 * callint.c (syms_of_callint):
3755 * casefiddle.c (syms_of_casefiddle):
3756 * casetab.c (init_casetab_once):
3757 * category.c (init_category_once, syms_of_category):
3758 * ccl.c (syms_of_ccl):
3759 * cmds.c (syms_of_cmds):
3760 * composite.c (syms_of_composite):
3761 * dbusbind.c (syms_of_dbusbind):
3762 * dired.c (syms_of_dired):
3763 * dispnew.c (syms_of_display):
3764 * doc.c (syms_of_doc):
3765 * editfns.c (syms_of_editfns):
3766 * emacs.c (syms_of_emacs):
3767 * eval.c (syms_of_eval):
3768 * fileio.c (syms_of_fileio):
3769 * fns.c (syms_of_fns):
3770 * frame.c (syms_of_frame):
3771 * fringe.c (syms_of_fringe):
3772 * insdel.c (syms_of_insdel):
3773 * keymap.c (syms_of_keymap):
3774 * lread.c (init_obarray, syms_of_lread):
3775 * macros.c (syms_of_macros):
3776 * msdos.c (syms_of_msdos):
3777 * print.c (syms_of_print):
3778 * process.c (syms_of_process):
3779 * search.c (syms_of_search):
3780 * sound.c (syms_of_sound):
3781 * syntax.c (init_syntax_once, syms_of_syntax):
3782 * terminal.c (syms_of_terminal):
3783 * textprop.c (syms_of_textprop):
3784 * undo.c (syms_of_undo):
3785 * w32.c (globals_of_w32):
3786 * window.c (syms_of_window):
3787 * xdisp.c (syms_of_xdisp):
3788 * xfaces.c (syms_of_xfaces):
3789 * xfns.c (syms_of_xfns):
3790 * xmenu.c (syms_of_xmenu):
3791 * xsettings.c (syms_of_xsettings):
3792 * xterm.c (syms_of_xterm): Use DEFSYM.
3793
4228cf16
TZ
37942011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3795
cd3520a4 3796 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3797
7fcccf1e
PE
37982011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3799
7efb4e0e
PE
3800 Integer and buffer overflow fixes (Bug#8873).
3801
ff5844ad
PE
3802 * print.c (printchar, strout): Check for string overflow.
3803 (PRINTPREPARE, printchar, strout):
3804 Don't set size unless allocation succeeds.
3805
90532f02
PE
3806 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3807 for sizes. Check for string overflow more accurately.
3808 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3809
6d84508d
PE
3810 * macros.c: Integer and buffer overflow fixes.
3811 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3812 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3813 Use ptrdiff_t, not int, for sizes.
3814 Don't increment bufsize until after realloc succeeds.
3815 Check for size-calculation overflow.
3816 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3817
437b2cb4
PE
3818 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3819
8b9ac8b4
PE
3820 * lread.c: Integer overflow fixes.
3821 (read_integer): Radix is now EMACS_INT, not int,
3822 to improve quality of diagnostics for out-of-range radices.
3823 Calculate buffer size correctly for out-of-range radices.
3824 (read1): Check for integer overflow in radices, and in
3825 read-circle numbers.
82cb60d3
PE
3826 (read_escape): Avoid int overflow.
3827 (Fload, openp, read_buffer_size, read1)
3828 (substitute_object_recurse, read_vector, read_list, map_obarray):
3829 Use ptrdiff_t, not int, for sizes.
3830 (read1): Use EMACS_INT, not int, for sizes.
20270765 3831 Check for size overflow.
8b9ac8b4 3832
7fcccf1e
PE
3833 * image.c (cache_image): Check for size arithmetic overflow.
3834
bfbbd7e7
PE
3835 * lread.c: Integer overflow issues.
3836 (saved_doc_string_size, saved_doc_string_length)
3837 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3838 Now ptrdiff_t, not int.
3839 (read1): Don't assume doc string length fits in int. Check for
3840 out-of-range doc string lengths.
3841 (read_list): Don't assume file position fits in int.
39019e54 3842 (read_escape): Check for hex character overflow.
bfbbd7e7 3843
4e323265
LL
38442011-06-22 Leo Liu <sdl.web@gmail.com>
3845
3846 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3847 Move to minibuffer.el.
3848
85fece3e
PE
38492011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3850
20b84ce9 3851 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3852 The following patches are for when GLYPH_DEBUG && !XASSERT.
3853 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3854 * dispnew.c (flush_stdout):
3855 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3856 Mark as externally visible.
3857 * dispnew.c (check_window_matrix_pointers): Now static.
3858 * dispnew.c (window_to_frame_vpos):
3859 * xfns.c (unwind_create_frame):
3860 * xterm.c (x_check_font): Remove unused local.
3861 * scroll.c (CHECK_BOUNDS):
3862 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3863 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3864 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3865 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3866 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3867 Now static.
3868 (debug_method_add): Use va_list and vsprintf rather than relying
3869 on undefined behavior with wrong number of arguments.
3870 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3871 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3872 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3873 since we're not interested in debugging glyphs with old libraries.
3874 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3875 GCC 4.6.0's static checking.
3876
0766b489
PE
38772011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3878
31fd4b32
PE
3879 Integer overflow and signedness fixes (Bug#8873).
3880 A few related buffer overrun fixes, too.
3881
b79e8648
PE
3882 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3883
0766b489
PE
3884 * dispextern.h (struct face.stipple):
3885 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3886 (x_bitmap_mask, x_allocate_bitmap_record)
3887 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3888 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3889 (x_create_bitmap_from_xpm_data):
3890 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3891 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3892 (.bitmaps_last):
3893 * xfaces.c (load_pixmap):
3894 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3895 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3896 (.bitmaps_last, struct x_output.icon_bitmap):
3897 Use ptrdiff_t, not int, for bitmap indexes.
3898 (x_allocate_bitmap_record): Check for size overflow.
3899 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3900
b081724f
PE
3901 Use ptrdiff_t, not int, for overlay counts.
3902 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3903 * editfns.c (overlays_around, get_pos_property):
3904 * textprop.c (get_char_property_and_overlay):
3905 * xdisp.c (next_overlay_change, note_mouse_highlight):
3906 * xfaces.c (face_at_buffer_position):
21514da7
PE
3907 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3908 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3909 (Fnext_overlay_change, Fprevious_overlay_change)
3910 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3911 Use ptrdiff_t, not int, for sizes.
21514da7 3912 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3913
3de73e5e
PE
3914 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3915
2606c57b
PE
3916 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3917 (x_session_initialize): Do not assume string length fits in int.
3918
aaafe47a
PE
3919 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3920 This is unlikely, but can occur if DPI is outlandish.
3921
2674ddc8 3922 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3923 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3924
28154962
PE
3925 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3926 * xrdb.c (magic_file_p, search_magic_path):
3927 Omit last arg SUFFIX; it was always 0. All callers changed.
3928 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3929
7de51af5
PE
3930 * xfont.c (xfont_match): Avoid need for strlen.
3931
25ed6cc3
PE
3932 * xfns.c: Don't assume strlen fits in int.
3933 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3934
4eab31dd
PE
3935 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3936 not unsigned long, as we prefer signed integers. All callers changed.
3937 Detect integer overflow in repeat count.
3938 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3939 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3940
171e2a58
PE
3941 * termcap.c: Don't assume sizes fit in int and never overflow.
3942 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3943 (gobble_line): Check for size-calculation overflow.
3944
ad39faca 3945 * minibuf.c (Fread_buffer):
6e5bb2dc 3946 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3947 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3948 Don't assume string length fits in int.
3949
52c61c22 3950 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3951 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3952
b5b8c9e5
PE
3953 * font.c: Don't assume string length fits in int.
3954 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3955 Use ptrdiff_t, not int.
ccd6111c
PE
3956 (font_intern_prop): Don't assume string length fits in int.
3957 Don't assume integer property fits in fixnum.
3958 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3959
882f0d81 3960 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3961 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3962 Reformulate so as not to need the command string.
3963 Invoke gzip -cd rather than gunzip, as it's more portable.
3964 (lock_info_type, lock_file_1, lock_file):
3965 Don't assume pid_t and time_t fit in unsigned long.
3966 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3967 (current_lock_owner): Prefer signed type for sizes.
3968 Use memcpy, not strncpy, where memcpy is what is really wanted.
3969 Don't assume (via atoi) that time_t and pid_t fit in int.
3970 Check for time_t and/or pid_t out of range, e.g., via a network share.
3971 Don't alloca where an auto var works fine.
3972
93f4cf88
PE
3973 * fileio.c: Fix some integer overflow issues.
3974 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3975 Don't assume string length fits in int.
3976 (directory_file_name): Don't assume string length fits in long.
3977 (make_temp_name): Don't assume pid fits in int, or that its print
3978 length is less than 20.
3979
f3e92b69
PE
3980 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3981
1bfdaf10
PE
3982 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3983
35016e9a
PE
3984 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3985
3d1e65a1
PE
3986 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3987 We prefer signed integers, even for size calculations.
3988
0b963a93
PE
3989 * emacs.c: Don't assume string length fits in 'int'.
3990 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3991 (main): Don't invoke strlen when not needed.
3992
573f4b54
PE
3993 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3994 (XD_DEBUG_MESSAGE): Don't waste a byte.
3995
989f33ba
PE
3996 * callproc.c (getenv_internal_1, getenv_internal)
3997 (Fgetenv_internal):
965d34eb
PE
3998 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3999
e4d29b33
PE
4000 * lread.c (invalid_syntax): Omit length argument.
4001 All uses changed. This doesn't fix a bug, but it simplifies the
4002 code away from its former Hollerith-constant appearance, and it's
4003 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4004 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4005
eb49b136
PE
4006 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4007 This didn't break anything, but it didn't help either.
4008 It's confusing to put a bogus integer in a place where the actual
4009 value does not matter.
9f62aeb1 4010 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4011 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4012
15375a22
PE
4013 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4014 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4015 implementation.
b61cc01c
PE
4016 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4017 We prefer signed types, and the value cannot exceed the EMACS_INT
4018 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4019 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4020 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4021 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4022
53b2623d
PE
4023 * indent.c (sane_tab_width): New function.
4024 (current_column, scan_for_column, Findent_to, position_indentation)
4025 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4026 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4027
51cab52b 4028 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4029
f2ed8a70
PE
4030 * lisp.h (lint_assume): New macro.
4031 * composite.c (composition_gstring_put_cache):
4032 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4033
abe80cc6
PE
4034 * editfns.c, insdel.c:
4035 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4036
b02c740e
PE
4037 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4038
ebc96716
PE
4039 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4040
b4e50fa0 4041 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4042 Use much-faster test for byte-length change.
311d5d7c 4043 Don't assume string byte-length fits in 'int'.
a4cf38e4 4044 Check that character arg fits in 'int'.
85461888 4045 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4046
c0c1ee9f
PE
4047 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4048
a498d7f4
PE
4049 * fns.c (concat): Catch string overflow earlier.
4050 Do not rely on integer wraparound.
4051
51cab52b
PE
4052 * dispextern.h (struct it.overlay_strings_charpos)
4053 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4054 * xdisp.c (forward_to_next_line_start)
4055 (back_to_previous_visible_line_start)
4056 (reseat_at_next_visible_line_start, next_element_from_buffer):
4057 Don't arbitrarily truncate the value of 'selective' to int.
4058
76031fad
PE
4059 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4060
5eb55db9
PE
4061 * composite.c: Don't truncate sizes to 'int'.
4062 (composition_gstring_p, composition_reseat_it)
4063 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4064 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4065 not EMACS_UINT, for indexes.
5eb55db9 4066
0703a717
PE
4067 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4068
d6202519
PE
4069 * buffer.c: Include <verify.h>.
4070 (struct sortvec.priority, struct sortstr.priority):
8961a454 4071 Now EMACS_INT, not int.
c20998a7 4072 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4073 (struct sortstr.size, record_overlay_string)
4074 (struct sortstrlist.size, struct sortlist.used):
4075 Don't truncate size to int.
4076 (record_overlay_string): Check for size-calculation overflow.
d6202519 4077 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4078
d5a19415
JM
40792011-06-22 Jim Meyering <meyering@redhat.com>
4080
029529ac 4081 Don't leak an XBM-image-sized buffer
d5a19415
JM
4082 * image.c (xbm_load): Free the image buffer after using it.
4083
a9041e6c
PE
40842011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4085
4086 Port to Sun C.
4087 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4088 that Sun C diagnosed.
4089 * fns.c (secure_hash): Fix pointer signedness issue.
4090 * intervals.c (static_offset_intervals): New function.
4091 (offset_intervals): Use it.
4092
7f3f739f
LL
40932011-06-21 Leo Liu <sdl.web@gmail.com>
4094
4095 * deps.mk (fns.o):
4096 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4097 sha512.h.
4098
4099 * fns.c (secure_hash): Rename from crypto_hash_function and change
4100 the first arg to accept symbols.
5b66d427 4101 (Fsecure_hash): New primitive.
7f3f739f
LL
4102 (syms_of_fns): New symbols.
4103
76147d94
DD
41042011-06-20 Deniz Dogan <deniz@dogan.se>
4105
4106 * process.c (Fset_process_buffer): Clarify return value in
4107 docstring.
4108
7d7d0045
CY
41092011-06-18 Chong Yidong <cyd@stupidchicken.com>
4110
4111 * dispnew.c (add_window_display_history): Use BVAR.
4112
4113 * xdisp.c (debug_method_add): Use BVAR.
4114 (check_window_end, dump_glyph_matrix, dump_glyph)
4115 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4116
4117 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4118 Likewise.
4119
4120 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4121 check till after the cache is created in init_frame_faces.
4122
ff2bc410
SM
41232011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4124
4125 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4126
28177add
PE
41272011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4128
dd3482fe
PE
4129 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4130 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4131 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4132
393d71f3 4133 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4134 * fileio.c (Finsert_file_contents):
4135 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4136 Remove the old (too-loose) buffer overflow checks.
4137 They weren't needed, since make_gap checks for buffer overflow.
4138 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4139 The old code merely checked for Emacs fixnum overflow, and relied
4140 on undefined (wraparound) behavior. The new code avoids undefined
4141 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4142
2e6813b0 4143 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4144 Tune. Don't use wider integers than needed. Don't use alloca.
4145 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4146
599a9e4f
PE
4147 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4148
99561444
PE
4149 * insdel.c, lisp.h (buffer_overflow): New function.
4150 (insert_from_buffer_1, replace_range, replace_range_2):
4151 * insdel.c (make_gap_larger):
4152 * editfns.c (Finsert_char):
4153 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4154
28177add
PE
4155 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4156
e69dafad
PE
41572011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4158
a7af7fde 4159 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4160
b1c46f02
PE
4161 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4162 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4163
e69dafad
PE
4164 * fileio.c: Don't assume EMACS_INT fits in off_t.
4165 (emacs_lseek): New static function.
4166 (Finsert_file_contents, Fwrite_region): Use it.
4167 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4168
566684ea
PE
4169 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4170
e6966cd6
PE
4171 * fns.c: Don't overflow int when computing a list length.
4172 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4173 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4174 truncation on 64-bit hosts. Check for QUIT every
4175 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4176 faster and is responsive enough.
4177 (Flength): Report an error instead of overflowing an integer.
4178 (Fsafe_length): Return a float if the value is not representable
4179 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4180 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4181 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4182
dd0b0efb
PE
4183 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4184 (header_size, word_size): New constants.
4185 (allocate_vectorlike): Don't check size overflow here.
4186 (allocate_vector): Check it here instead, since this is the only
4187 caller of allocate_vectorlike that could cause overflow.
4188 Check that the new vector's length is representable as a fixnum.
4189
86fe5cfe
PE
4190 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4191 The previous code was bogus. For example, next_almost_prime (32)
4192 returned 39, which is undesirable as it is a multiple of 3; and
4193 next_almost_prime (24) returned 25, which is a multiple of 5 so
4194 why was the code bothering to check for multiples of 7?
4195
80e88859
PE
4196 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4197
4a2f0ad6
PE
4198 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4199
f66c7cf8
PE
4200 Variadic C functions now count arguments with ptrdiff_t.
4201 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4202 Back then I didn't know that the Emacs coding style prefers signed int.
4203 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4204 were being counted with int, which may truncate counts on 64-bit
4205 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4206 * lisp.h (struct Lisp_Subr.function.aMANY)
4207 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4208 Arg counts are now ptrdiff_t, not size_t.
4209 All variadic functions and their callers changed accordingly.
4210 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4211 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4212 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4213 * callint.c (Fcall_interactively): Check arg count for overflow,
4214 to avoid potential buffer overrun. Use signed char, not 'int',
4215 for 'varies' array, so that we needn't bother to check its size
4216 calculation for overflow.
4217 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4218 * eval.c (apply_lambda):
4219 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4220 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4221 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4222
a1759b76
PE
4223 * callint.c (Fcall_interactively): Don't use index var as event count.
4224
d96be9fc
PE
4225 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4226 * mem-limits.h (SIZE): Remove; no longer used.
4227
a690a978 4228 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4229
578c21e6
PE
4230 Remove unnecessary casts.
4231 * xterm.c (x_term_init):
4232 * xfns.c (x_set_border_pixel):
4233 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4234 These aren't needed now that we assume ANSI C.
4235
96f53c6c
PE
4236 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4237 It's more likely to cause problems (due to unsigned overflow)
4238 than to cure them.
4239
83c77d31
PE
4240 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4241
ee2079f1
PE
4242 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4243
6da65536
PE
4244 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4245
7147c4a4
PE
4246 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4247
193e32d9
PE
4248 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4249
e5533da6
PE
4250 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4251
9910e595
PE
4252 GLYPH_CODE_FACE returns EMACS_INT, not int.
4253 * dispextern.h (merge_faces):
4254 * xfaces.c (merge_faces):
01103c44
PE
4255 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4256 Don't assume EMACS_INT fits in int.
9910e595 4257
2638320e
PE
4258 * character.h (CHAR_VALID_P): Remove unused parameter.
4259 * fontset.c, lisp.h, xdisp.c: All uses changed.
4260
045eb8d9
PE
4261 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4262
c1f134b5
PE
4263 * fns.c (concat): Minor tuning based on overflow analysis.
4264 This doesn't fix any bugs. Use int to hold character, instead
4265 of constantly refetching from Emacs object. Use XFASTINT, not
4266 XINT, for value known to be a character. Don't bother comparing
4267 a single byte to 0400, as it's always less.
4268
395fcb93 4269 * floatfns.c (Fexpt):
327eeec8
PE
4270 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4271
abbd3d23
PE
4272 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4273 for characters.
4274
684a03ef
PE
4275 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4276
0fed43f3
PE
4277 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4278 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4279 incorrectly succeed when S was a string, because 4294967386 was
4280 truncated before it was used.
4281
8fd02eb7
PE
4282 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4283 Otherwise, an out-of-range integer could cause undefined behavior
4284 on a 64-bit host.
4285
f8c86b69
PE
4286 * composite.c: Use int, not EMACS_INT, for characters.
4287 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4288 EMACS_INT, for values that are known to be in character range.
4289 This doesn't fix any bugs but is the usual style inside Emacs and
4290 may generate better code on 32-bit machines.
4291
34206dd2
PE
4292 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4293 This is for reasons similar to the recent CHAR_STRING fix.
4294 * charset.c (Fencode_char): Check that character arg is actually
4295 a character. Pass an int to ENCODE_CHAR.
4296 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4297 wider than 'int', as a compile-time check to prevent future regressions
4298 in this area.
4299
c5958d4c 4300 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4301
4302 Make sure a 64-bit char is never passed to CHAR_STRING.
4303 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4304 by silently ignoring the top 32 bits, allowing some values
4305 that were far too large to be valid characters.
4306 * character.h: Include <verify.h>.
4307 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4308 arguments are no wider than unsigned, as a compile-time check
4309 to prevent future regressions in this area.
4310 * data.c (Faset):
01103c44 4311 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4312 (Fsubst_char_in_region):
4313 * fns.c (concat):
4314 * xdisp.c (decode_mode_spec_coding):
4315 Adjust to CHAR_STRING's new requirement.
4316 * editfns.c (Finsert_char, Fsubst_char_in_region):
4317 * fns.c (concat): Check that character args are actually
4318 characters. Without this test, these functions did the wrong
4319 thing with wildly out-of-range values on 64-bit hosts.
4320
d37ca623
PE
4321 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4322 These casts should not be needed on 32-bit hosts, either.
4323 * keyboard.c (read_char):
4324 * lread.c (Fload): Remove casts to unsigned.
4325
ea204efb
PE
4326 * lisp.h (UNSIGNED_CMP): New macro.
4327 This fixes comparison bugs on 64-bit hosts.
4328 (ASCII_CHAR_P): Use it.
4329 * casefiddle.c (casify_object):
01103c44 4330 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4331 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4332 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4333 * dispextern.h (FACE_FROM_ID):
4334 * keyboard.c (read_char): Use UNSIGNED_CMP.
4335
41cb286c
PE
4336 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4337 not to EMACS_INT, to avoid GCC warning.
4338
4a1b9832
PE
4339 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4340
55daad71
PE
4341 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4342 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4343 isn't needed on 32-bit machines.
8f95c75c 4344
01103c44
PE
4345 * buffer.c (Fgenerate_new_buffer_name):
4346 Use EMACS_INT for count, not int.
0ceccced 4347 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4348
4349 * data.c (Qcompiled_function): Now static.
4350
c6f072e7
PE
4351 * window.c (window_body_lines): Now static.
4352
20ce5912
PE
4353 * image.c (gif_load): Rename local to avoid shadowing.
4354
9c4c5f81
PE
4355 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4356 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4357 * alloc.c (make_save_value): Integer argument is now of type
4358 ptrdiff_t, not int.
4359 (mark_object): Use ptrdiff_t, not int.
4360 * lisp.h (pD): New macro.
4361 * print.c (print_object): Use it.
4362
c0c5c8ae
PE
4363 * alloc.c: Use EMACS_INT, not int, to count objects.
4364 (total_conses, total_markers, total_symbols, total_vector_size)
4365 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4366 (total_free_floats, total_floats, total_free_intervals)
4367 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4368 Now EMACS_INT, not int. All uses changed.
4369 (Fgarbage_collect): Compute overall total using a double, so that
4370 integer overflow is less likely to be a problem. Check for overflow
4371 when converting back to an integer.
5a25e253
PE
4372 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4373 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4374 These were 'int' variables that could overflow on 64-bit hosts;
4375 they were never used, so remove them instead of repairing them.
211a0b2a 4376 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4377 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4378 Previously, this ceilinged at INT_MAX, but that doesn't work on
4379 64-bit machines.
e46bb31a 4380 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4381
c78baabf 4382 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4383 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4384 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4385 when a (possibly-narrower) signed value would do just as well.
4386 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4387
c9d624c6
PE
4388 * alloc.c: Catch some string size overflows that we were missing.
4389 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4390 for convenience in STRING_BYTES_MAX.
4391 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4392 The definition here is exact; the one in lisp.h was approximate.
4393 (allocate_string_data): Check for string overflow. This catches
4394 some instances we weren't catching before. Also, it catches
4395 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4396 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4397 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4398
c9d624c6
PE
4399 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4400 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4401 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4402
353032ce
PE
4403 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4404
2bccce07
PE
4405 * alloc.c (Fmake_string): Check for out-of-range init.
4406
0ac30604
SM
44072011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4408
4409 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4410
c195f2de
JD
44112011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4412
4413 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4414 xg_get_default_scrollbar_width.
4415
4416 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4417 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4418 (style_changed_cb): Call update_theme_scrollbar_width and call
4419 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4420 all frames (Bug#8505).
4421 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4422 Call gtk_window_set_resizable if HAVE_GTK3.
4423 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4424 and height if HAVE_GTK3 (Bug#8505).
4425 (scroll_bar_width_for_theme): New variable.
4426 (update_theme_scrollbar_width): New function.
4427 (xg_get_default_scrollbar_width): Move code to
4428 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4429 (xg_initialize): Call update_theme_scrollbar_width.
4430
4431 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4432
4433 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4434
e10ac9f1
MR
44352011-06-12 Martin Rudalics <rudalics@gmx.at>
4436
4437 * frame.c (make_frame): Call other_buffer_safely instead of
4438 other_buffer.
4439
4440 * window.c (temp_output_buffer_show): Call display_buffer with
4441 second argument Vtemp_buffer_show_specifiers and reset latter
4442 immediately after the call.
4443 (Vtemp_buffer_show_specifiers): New variable.
4444 (auto_window_vscroll_p, next_screen_context_lines)
4445 (Vscroll_preserve_screen_position): Remove leading asterisks from
4446 doc-strings.
4447
2d3c217e 44482011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4449
7b7f97e8 4450 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4451 * buffer.c (Qclone_number): Remove for now, as it's unused.
4452 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4453 (record_buffer): Remove unused local.
4454 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4455 (set_frame_buffer_list): Remove; unused.
4456 * frame.h (other_visible_frames): Remove decl.
4457 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4458 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4459 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4460 if HAVE_GPM.
4461 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4462 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4463 Define only if HAVE_GPM.
4464 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4465 (update_hints_inhibit): Remove; never set. All uses removed.
4466 * widgetprv.h (emacsFrameClassRec): Remove decl.
4467 * window.c (delete_deletable_window): Now returns void, since it
4468 wasn't returning anything.
4469 (compare_window_configurations): Remove unused locals.
4470 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4471 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4472 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4473 the same widths as pointers. This follows up on the 2011-05-06 patch.
4474 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4475 * xterm.h: Likewise.
4476 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4477
1384b89e
JB
44782011-06-12 Juanma Barranquero <lekktu@gmail.com>
4479
4480 * makefile.w32-in: Update dependencies.
4481 (LISP_H): Add lib/intprops.h.
4482
1100a63c
CY
44832011-06-11 Chong Yidong <cyd@stupidchicken.com>
4484
4485 * image.c (gif_load): Add animation frame delay to the metadata.
4486 (syms_of_image): Use DEFSYM. New symbol `delay'.
4487
6198ccd0
MR
44882011-06-11 Martin Rudalics <rudalics@gmx.at>
4489
4490 * window.c (delete_deletable_window): Re-add.
4491 (Fset_window_configuration): Rewrite to handle dead buffers and
4492 consequently deletable windows.
4493 (window_tree, Fwindow_tree): Remove. Supply functionality in
4494 window.el.
4495 (compare_window_configurations): Simplify code.
4496
b6e3633c
AS
44972011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4498
1ab0dee5
AS
4499 * image.c (imagemagick_load_image): Fix type mismatch.
4500 (Fimagemagick_types): Likewise.
4501
b6e3633c
AS
4502 * window.h (replace_buffer_in_windows): Declare.
4503
9397e56f
MR
45042011-06-11 Martin Rudalics <rudalics@gmx.at>
4505
4506 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4507 Qclone_number. Remove external declaration of Qdelete_window.
4508 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4509 code.
640c8776
SM
4510 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4511 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4512 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4513 buffer list implementation.
4514 (other_buffer_safely): New function.
4515 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4516 calls to replace_buffer_in_windows and
4517 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4518 if allowed.
4519 (record_buffer): Inhibit quitting and rewrite using quittable
4520 functions. Run Qbuffer_list_update_hook if allowed.
4521 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4522 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4523 Move switch-to-buffer to window.el.
9397e56f
MR
4524 (bury-buffer): Move to window.el.
4525 (Vbuffer_list_update_hook): New variable.
4526
4527 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4528 section.
4529
4530 * window.h (resize_frame_windows): Move up in code.
4531 (Fwindow_frame): Remove EXFUN.
4532 (replace_buffer_in_all_windows): Remove prototype.
4533 (replace_buffer_in_windows_safely): Add prototype.
4534
4535 * window.c: Declare Qdelete_window static again. Move down
4536 declaration of select_count.
4537 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4538 (Fother_window): Move to window.el.
4539 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4540 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4541 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4542 window.el.
4543 (replace_buffer_in_windows): Implement by calling
4544 Qreplace_buffer_in_windows.
4545 (replace_buffer_in_all_windows): Remove with some functionality
4546 moved into replace_buffer_in_windows_safely.
4547 (replace_buffer_in_windows_safely): New function.
4548 (select_window_norecord, select_frame_norecord): Move in front
4549 of run_window_configuration_change_hook. Remove now obsolete
4550 declarations.
640c8776
SM
4551 (Fset_window_buffer): Rewrite doc-string.
4552 Call Qrecord_window_buffer.
9397e56f
MR
4553 (keys_of_window): Move binding for other-window to window.el.
4554
b50691aa
CY
45552011-06-11 Chong Yidong <cyd@stupidchicken.com>
4556
4557 * dispextern.h (struct image): Replace data member, whose int_val
4558 and ptr_val fields were not used by anything, with a single
4559 lisp_val object.
4560
4561 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4562 (gif_clear_image, gif_load, imagemagick_load_image)
4563 (gs_clear_image, gs_load): Callers changed.
4564
3f754b86
PE
45652011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4566
cca69397
PE
4567 * buffer.h: Include <time.h>, for time_t.
4568 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4569
109e28d0
PE
4570 Fix minor problems found by static checking.
4571
60737f02
PE
4572 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4573
4b66faf3
PE
4574 Make identifiers static if they are not used in other modules.
4575 * data.c (Qcompiled_function, Qframe, Qvector):
4576 * image.c (QimageMagick, Qsvg):
4577 * minibuf.c (Qmetadata):
4578 * window.c (resize_window_check, resize_root_window): Now static.
4579 * window.h (resize_window_check, resize_root_window): Remove decls.
4580
109e28d0
PE
4581 * window.c (window_deletion_count, delete_deletable_window):
4582 Remove; unused.
46a4ce9e
PE
4583 (window_body_lines): Now static.
4584 (Fdelete_other_windows_internal): Mark vars as initialized.
4585 Make sure 'resize_failed' is initialized.
4586 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4587 (resize_window_apply): Remove unused local.
4588 * window.h (delete_deletable_window): Remove decl.
4589
109e28d0 4590 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4591 (imagemagick_load_image): Fix pointer signedness problem by changing
4592 last arg from unsigned char * to char *. All uses changed.
4593 Also, fix a local for similar reasons.
4594 Remove unused locals. Remove locals to avoid shadowing.
4595 (fn_rsvg_handle_free): Remove; unused.
4596 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4597 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4598
3f754b86
PE
4599 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4600
2547adb1
CY
46012011-06-10 Chong Yidong <cyd@stupidchicken.com>
4602
4603 * image.c (gif_load): Fix omitted cast error introduced by
4604 2011-06-06 change.
4605
2c8e37d4
MR
46062011-06-10 Martin Rudalics <rudalics@gmx.at>
4607
4608 * window.h (resize_proportionally, orig_total_lines)
4609 (orig_top_line): Remove from window structure.
4610 (set_window_height, set_window_width, change_window_heights)
4611 (Fdelete_window): Remove prototypes.
4612 (resize_frame_windows): Remove duplicate declaration.
4613
440a42e3
EZ
46142011-06-10 Eli Zaretskii <eliz@gnu.org>
4615
4616 * window.h (resize_frame_windows, resize_window_check)
4617 (delete_deletable_window, resize_root_window)
4618 (resize_frame_windows): Declare prototypes.
4619
4620 * window.c (resize_window_apply): Make definition be "static" to
4621 match the prototype.
4622
562dd5e9
MR
46232011-06-10 Martin Rudalics <rudalics@gmx.at>
4624
4625 * window.c: Remove declarations of Qwindow_size_fixed,
4626 window_min_size_1, window_min_size_2, window_min_size,
4627 size_window, window_fixed_size_p, enlarge_window, delete_window.
4628 Remove static from declaration of Qdelete_window, it's
4629 temporarily needed by Fbury_buffer.
4630 (replace_window): Don't assign orig_top_line and
4631 orig_total_lines.
4632 (Fdelete_window, delete_window): Remove. Window deletion is
4633 handled by window.el.
640c8776
SM
4634 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4635 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4636 (Fdelete_other_windows): Remove. Deleting other windows is
4637 handled by window.el.
4638 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4639 handled in window.el.
4640 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4641 Window minimum sizes are handled in window.el.
4642 (shrink_windows, size_window, set_window_height)
4643 (set_window_width, change_window_heights, window_height)
4644 (window_width, CURBEG, CURSIZE, enlarge_window)
4645 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4646 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4647 handled in window.el.
4648 (make_dummy_parent): Rename to make_parent_window and give it a
4649 second argument horflag.
4650 (make_window): Don't set resize_proportionally any more.
4651 (Fsplit_window): Remove. Windows are split in window.el.
4652 (save_restore_action, save_restore_orig_size)
4653 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4654 Resize mini windows in window.el.
4655 (grow_mini_window, shrink_mini_window): Implement by calling
4656 Qresize_root_window_vertically, resize_window_check and
4657 resize_window_apply.
640c8776
SM
4658 (saved_window, Fset_window_configuration, save_window_save):
4659 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4660 resize_proportionally.
4661 (window_min_height, window_min_width): Move to window.el.
4662 (keys_of_window): Move bindings for delete-other-windows,
4663 split-window, delete-window and enlarge-window to window.el.
4664
4665 * buffer.c: Temporarily extern Qdelete_window.
4666 (Fbury_buffer): Temporarily call Qdelete_window instead of
4667 Fdelete_window (Fbury_buffer will move to window.el soon).
4668
4669 * frame.c (set_menu_bar_lines_1): Remove code handling
4670 orig_top_line and orig_total_lines.
4671
4672 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4673 set_window_height but set heights directly.
4674 (change_frame_size_1): Use resize_frame_windows.
4675
4676 * xdisp.c (init_xdisp): Don't use set_window_height but set
4677 heights directly.
4678
640c8776
SM
4679 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4680 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4681 run_window_configuration_change_hook.
4682
4683 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4684 instead of change_window_heights and run
4685 run_window_configuration_change_hook.
4686
1a13852e
MR
46872011-06-09 Martin Rudalics <rudalics@gmx.at>
4688
4689 * window.c (replace_window): Rename second argument REPLACEMENT to
4690 NEW. New third argument SETFLAG. Rewrite.
4691 (delete_window, make_dummy_parent): Call replace_window with
4692 third argument 1.
4693 (window_list_1): Move down in code.
4694 (run_window_configuration_change_hook): Move set_buffer part
4695 before select_frame_norecord part in order to unwind correctly.
4696 Rename count1 to count.
4697 (recombine_windows, delete_deletable_window, resize_root_window)
4698 (Fdelete_other_windows_internal)
4699 (Frun_window_configuration_change_hook, make_parent_window)
4700 (resize_window_check, resize_window_apply, Fresize_window_apply)
4701 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4702 (Fdelete_window_internal, Fresize_mini_window_internal):
4703 New functions.
1a13852e
MR
4704 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4705
f3d1777e
MR
47062011-06-08 Martin Rudalics <rudalics@gmx.at>
4707
496e208e
MR
4708 * window.h (window): Add some new members to window structure -
4709 normal_lines, normal_cols, new_total, new_normal, clone_number,
4710 splits, nest, prev_buffers, next_buffers.
4711 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4712 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4713
f3d1777e
MR
4714 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4715 Remove.
496e208e
MR
4716 (make_dummy_parent): Set new members of windows structure.
4717 (make_window): Move down in code. Handle new members of window
4718 structure.
4719 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4720 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4721 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4722 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4723 (Fset_window_next_buffers, Fset_window_clone_number):
4724 New functions.
496e208e
MR
4725 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4726 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4727 Doc-string fixes.
4728 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4729 Argument WINDOW can be now internal window too.
4730 (Fwindow_use_time): Move up in code.
4731 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4732 Rewrite doc-string.
4733 (Fset_window_configuration, saved_window)
4734 (Fcurrent_window_configuration, save_window_save): Handle new
4735 members of window structure.
b9e809c2
MR
4736 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4737 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4738 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4739 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4740 Qget_mru_window, Qresize_root_window,
4741 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4742 Qauto_buffer_name; staticpro them.
f3d1777e 4743
abde8f8c
MR
47442011-06-07 Martin Rudalics <rudalics@gmx.at>
4745
4746 * window.c (Fwindow_total_size, Fwindow_left_column)
4747 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4748 (Fwindow_list_1): New functions.
4749 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4750 (Fwindow_width, Fscroll_left, Fscroll_right):
4751 Use window_body_cols instead of window_box_text_cols.
4752 (delete_window, Fset_window_configuration):
4753 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4754 (delete_all_subwindows): Take a window as argument and not a
4755 structure. Rewrite.
190b47e6
MR
4756 (window_loop): Remove handling of GET_LRU_WINDOW and
4757 GET_LARGEST_WINDOW.
4758 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4759
4760 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4761 window_box_text_cols. delete_all_subwindows now takes a
4762 Lisp_Object as argument.
abde8f8c 4763
640c8776
SM
4764 * indent.c (compute_motion, Fcompute_motion):
4765 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4766
fa8a67e6
MR
4767 * frame.c (delete_frame): Call delete_all_subwindows with root
4768 window as argument.
4769
a54e3482
DC
47702011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4771
4772 * fns.c (Fputhash): Document return value.
4773
60002bf5
CY
47742011-06-06 Chong Yidong <cyd@stupidchicken.com>
4775
4776 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4777
0c671da6 47782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4779
b862a52a 4780 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4781
be44ca6c
PE
4782 Check for overflow when converting integer to cons and back.
4783 * charset.c (Fdefine_charset_internal, Fdecode_char):
4784 Use cons_to_unsigned to catch overflow.
4785 (Fencode_char): Use INTEGER_TO_CONS.
4786 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4787 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4788 * data.c (long_to_cons, cons_to_long): Remove.
4789 (cons_to_unsigned, cons_to_signed): New functions.
4790 These signal an error for invalid or out-of-range values.
4791 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4792 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4793 * font.c (Ffont_variation_glyphs):
4794 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4795 * lisp.h: Include <intprops.h>.
4796 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4797 (cons_to_signed, cons_to_unsigned): New decls.
4798 (long_to_cons, cons_to_long): Remove decls.
4799 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4800 (Fprimitive_undo): Use CONS_TO_INTEGER.
4801 * xfns.c (Fx_window_property): Likewise.
4802 * xselect.c: Include <limits.h>.
4803 (x_own_selection, selection_data_to_lisp_data):
4804 Use INTEGER_TO_CONS.
4805 (x_handle_selection_request, x_handle_selection_clear)
4806 (x_get_foreign_selection, Fx_disown_selection_internal)
4807 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4808 (lisp_data_to_selection_data): Use cons_to_unsigned.
4809 (x_fill_property_data): Use cons_to_signed.
4810 Report values out of range.
4811
d1f3d2af
PE
4812 Check for buffer and string overflow more precisely.
4813 * buffer.h (BUF_BYTES_MAX): New macro.
4814 * lisp.h (STRING_BYTES_MAX): New macro.
4815 * alloc.c (Fmake_string):
4816 * character.c (string_escape_byte8):
4817 * coding.c (coding_alloc_by_realloc):
4818 * doprnt.c (doprnt):
4819 * editfns.c (Fformat):
4820 * eval.c (verror):
4821 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4822 since they may not be the same number.
4823 * editfns.c (Finsert_char):
4824 * fileio.c (Finsert_file_contents):
4825 Likewise for BUF_BYTES_MAX.
4826
dd52fcea
PE
4827 * image.c: Use ptrdiff_t, not int, for sizes.
4828 (slurp_file): Switch from int to ptrdiff_t.
4829 All uses changed.
4830 (slurp_file): Check that file size fits in both size_t (for
4831 malloc) and ptrdiff_t (for sanity and safety).
4832
7f9bbdbb
PE
4833 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4834 if b->modtime has its maximal value.
4835
dfe18f82
PE
4836 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4837
84acfcf0
PE
4838 Don't assume time_t can fit into int.
4839 * buffer.h (struct buffer.modtime): Now time_t, not int.
4840 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4841 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4842
ccd9a01a
PE
4843 Minor fixes for signed vs unsigned integers.
4844 * character.h (MAYBE_UNIFY_CHAR):
4845 * charset.c (maybe_unify_char):
4846 * keyboard.c (read_char, reorder_modifiers):
4847 XINT -> XFASTINT, since the integer must be nonnegative.
4848 * ftfont.c (ftfont_spec_pattern):
4849 * keymap.c (access_keymap, silly_event_symbol_error):
4850 XUINT -> XFASTINT, since the integer must be nonnegative.
4851 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4852 since it makes no difference and we prefer signed.
4853 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4854 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4855 nonnegative.
4856
d6d100dd
SM
48572011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4858
4859 * window.h (Fwindow_frame): Declare.
4860
2b6148e4
PE
48612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4862
4863 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4864 (SPARE_MEMORY): Always define.
4865 (LARGE_REQUEST): Remove.
4866 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4867
f230ecc9
MR
48682011-06-06 Martin Rudalics <rudalics@gmx.at>
4869
727e958e
MR
4870 * lisp.h: Move EXFUNS for Fframe_root_window,
4871 Fframe_first_window and Fset_frame_selected_window to window.h.
4872
4873 * window.h: Move EXFUNS for Fframe_root_window,
4874 Fframe_first_window and Fset_frame_selected_window here from
4875 lisp.h.
4876
4877 * frame.c (Fwindow_frame, Fframe_first_window)
4878 (Fframe_root_window, Fframe_selected_window)
4879 (Fset_frame_selected_window): Move to window.c.
4880 (Factive_minibuffer_window): Move to minibuf.c.
4881 (Fother_visible_frames_p): New function.
4882
4883 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4884
f230ecc9
MR
4885 * window.c (decode_window, decode_any_window): Move up in code.
4886 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4887 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4888 (Fwindow_buffer): Move up and rewrite doc-string.
4889 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4890 (Fwindow_prev): New functions.
727e958e
MR
4891 (Fwindow_frame): Move here from frame.c. Accept any window as
4892 argument.
4893 (Fframe_root_window, Fframe_first_window)
4894 (Fframe_selected_window): Move here from frame.c. Accept frame
4895 or arbitrary window as argument. Update doc-strings.
4896 (Fminibuffer_window): Move up in code.
4897 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4898 (Fset_frame_selected_window): Move here from frame.c.
4899 Marginal rewrite.
727e958e
MR
4900 (Fselected_window, select_window, Fselect_window): Move up in
4901 code. Minor doc-string fixes.
f230ecc9 4902
4d09bcf6
PE
49032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4904
4905 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4906 Do not assume that spare memory exists; that assumption is valid
4907 only if SYSTEM_MALLOC.
4908 (LARGE_REQUEST): New macro, so that the issue of large requests
4909 is separated from the issue of spare memory.
4910
810928a2
AS
49112011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4912
172418ad
AS
4913 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4914 format. (Bug#8806)
4915
43f862f7
AS
4916 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4917
810928a2
AS
4918 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4919 before statements.
4920
a059fe24
JD
49212011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4922
4923 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4924
4925 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4926
4927 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4928 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4929
989bf368
JB
49302011-06-05 Juanma Barranquero <lekktu@gmail.com>
4931
4932 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4933
4b80f674
CY
49342011-06-04 Chong Yidong <cyd@stupidchicken.com>
4935
4936 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4937 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4938 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4939 New error handlers.
4b80f674
CY
4940 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4941 Obey Vx_select_enable_clipboard_manager. Catch errors in
4942 x_clipboard_manager_save (Bug#8779).
4943 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4944 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4945
99a33b77 49462011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4947
4948 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4949
99a33b77 49502011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4951
4952 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4953 in the current matrix if keep_current_p is non-zero.
4954
8264569d
EZ
49552011-06-04 Eli Zaretskii <eliz@gnu.org>
4956
4957 * bidi.c (bidi_level_of_next_char): Fix last change.
4958
57f97249
EZ
49592011-06-03 Eli Zaretskii <eliz@gnu.org>
4960
fec2107c 4961 Support bidi reordering of text covered by display properties.
57f97249 4962
fec2107c
EZ
4963 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4964 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4965 (bidi_cache_search, bidi_cache_iterator_state)
4966 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4967 (bidi_level_of_next_char, bidi_move_to_visually_next):
4968 Support character positions inside a run of characters covered by a
fec2107c
EZ
4969 display string.
4970 (bidi_paragraph_init, bidi_resolve_explicit_1)
4971 (bidi_level_of_next_char): Call bidi_fetch_char and
4972 bidi_fetch_char_advance instead of FETCH_CHAR and
4973 FETCH_CHAR_ADVANCE.
4974 (bidi_init_it): Initialize new members.
4975 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4976 definitions.
4977 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4978 instead of using explicit *_CHAR codes.
d6d100dd
SM
4979 (bidi_resolve_explicit, bidi_resolve_weak):
4980 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4981 bidirectional text is supported only in multibyte buffers.
4982 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4983 it to initialize the frame_window_p member of struct bidi_it.
4984 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4985 (bidi_resolve_explicit, bidi_resolve_weak)
4986 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4987 bidi_it->nchars is non-positive.
4988 (bidi_level_of_next_char): Don't try to lookup the cache for the
4989 next/previous character if nothing is cached there yet, or if we
4990 were just reseat()'ed to a new position.
c40e2fb2 4991
0e14fe90
EZ
4992 * xdisp.c (set_cursor_from_row): Set start and stop points
4993 according to the row's direction when priming the loop that looks
4994 for the glyph on which to display cursor.
4995 (single_display_spec_intangible_p): Function deleted.
4996 (display_prop_intangible_p): Reimplement to call
4997 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4998 Accept 3 additional arguments needed by handle_display_spec.
4999 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5000 values: lists, `(when COND...)' forms, etc.
5001 (single_display_spec_string_p): Support property values that are
5002 lists with the argument STRING its top-level element.
5003 (display_prop_string_p): Fix the condition for processing a
5004 property that is a list to be consistent with handle_display_spec.
fec2107c 5005 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5006 last portion of handle_display_prop.
5007 (compute_display_string_pos): Accept additional argument
5008 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5009 value of a `display' property is a "replacing spec".
5010 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5011 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5012 the display property, but just return a value indicating whether
5013 the display property will replace the characters it covers.
5014 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5015 frame_window_p members of struct bidi_it.
d6d100dd
SM
5016 (compute_display_string_pos, compute_display_string_end):
5017 New functions.
fec2107c
EZ
5018 (push_it): Accept second argument POSITION, where pop_it should
5019 jump to continue iteration.
5020 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5021
fec2107c
EZ
5022 * keyboard.c (adjust_point_for_property): Adjust the call to
5023 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5024
5025 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5026 (bidi_init_it): Update prototypes.
5027 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5028 (compute_display_string_pos, compute_display_string_end):
5029 Declare prototypes.
fec2107c
EZ
5030 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5031 EMACS_INT.
fc6f18ce 5032
40087514 50332011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5034
57f53182
PE
5035 Malloc failure behavior now depends on size of allocation.
5036 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5037 * lisp.h: Change signatures accordingly.
5038 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5039 All callers changed. (Bug#8762)
5040
5041 * gnutls.c: Use Emacs's memory allocators.
5042 Without this change, the gnutls library would invoke malloc etc.
5043 directly, which causes problems on non-SYNC_INPUT hosts, and which
5044 runs afoul of improving memory_full behavior. (Bug#8761)
5045 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5046 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5047 xfree instead of the default malloc, realloc, free.
5048 (Fgnutls_boot): No need to check for memory allocation failure,
5049 since xmalloc does that for us.
5050
ac32cd99 5051 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5052 * category.c (hash_get_category_set):
5053 * ccl.c (ccl_driver):
5054 * charset.c (Fdefine_charset_internal):
5055 * charset.h (struct charset.hash_index):
5056 * composite.c (get_composition_id, gstring_lookup_cache)
5057 (composition_gstring_put_cache):
5058 * composite.h (struct composition.hash_index):
5059 * dispextern.h (struct image.hash):
5060 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5061 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5062 (hashfn_equal, hashfn_user_defined, make_hash_table)
5063 (maybe_resize_hash_table, hash_lookup, hash_put)
5064 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5065 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5066 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5067 * image.c (make_image, search_image_cache, lookup_image)
5068 (xpm_put_color_table_h):
5069 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5070 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5071 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5072 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5073 * alloc.c (allocate_vectorlike):
5074 Check for overflow in vector size calculations.
5075 * ccl.c (ccl_driver):
5076 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5077 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5078 need to be updated by these changes.
40087514
PE
5079 * fns.c (make_hash_table, maybe_resize_hash_table):
5080 Check for integer overflow with large hash tables.
0de4bb68
PE
5081 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5082 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5083 (SXHASH_REDUCE): New macro.
5084 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5085 Use it instead of discarding useful hash info with large hash values.
5086 (sxhash_float): New function.
5087 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5088 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5089 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5090 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5091 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5092 Adjust signatures to match updated version of code.
5093 (consing_since_gc): Now EMACS_INT, since a single hash table can
5094 use more than INT_MAX bytes.
5095
698d32e2
DN
50962011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5097
5098 Make it possible to build with GCC-4.6+ -O2 -flto.
5099
5100 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5101
fd6fa53f
SM
51022011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5103
5104 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5105 Call minibuffer-inactive-mode.
5106
864db017
JB
51072011-05-31 Juanma Barranquero <lekktu@gmail.com>
5108
5109 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5110 Update dependencies.
5111
2ad0baf4
DN
51122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5113
5114 * data.c (init_data): Remove code for UTS, this system is not
5115 supported anymore.
5116
4fcc2638
DN
51172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5118
5119 Don't force ./temacs to start in terminal mode.
5120
5121 * frame.c (make_initial_frame): Initialize faces in all cases, not
5122 only when CANNOT_DUMP is defined.
5123 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5124
c56e0fd5
DN
51252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5126
5127 * dispnew.c (add_window_display_history): Use const for the string
5128 pointer. Remove declaration, not needed.
5129
333d54da 51302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5131
55d4c1b2 5132 Use 'inline', not 'INLINE'.
333d54da 5133 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5134 * alloc.c, fontset.c (INLINE): Remove.
5135 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5136 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5137 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5138 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5139 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5140
738db178
DN
51412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5142
5143 Make it possible to run ./temacs.
5144
5145 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5146 syms_of_callproc does the same thing. Remove test for
5147 "initialized", do it in the caller.
5148 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5149
620c53a6
SM
51502011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5151
5152 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5153 (read_minibuf): Use get_minibuffer.
5154 (syms_of_minibuf): Use DEFSYM.
5155 (Qmetadata): New var.
5156 * data.c (Qbuffer): Don't make it static.
5157 (syms_of_data): Use DEFSYM.
5158
e003a292
PE
51592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5160
5161 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5162 (CCL_CODE_MIN): New macro.
5163
ed008a6d
PE
51642011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5165
3687c2ef
PE
5166 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5167
ed008a6d
PE
5168 * eval.c (Qdebug): Now static.
5169 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5170 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5171 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5172
d66c4c7c
CY
51732011-05-29 Chong Yidong <cyd@stupidchicken.com>
5174
5175 * image.c: Various fixes to ImageMagick code comments.
5176 (Fimagemagick_types): Doc fix.
5177
5fbc2025
PE
51782011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5179
0196f88a
PE
5180 Minor fixes prompted by GCC 4.6.0 warnings.
5181
5182 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5183
5fbc2025
PE
5184 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5185 (x_clipboard_manager_save_all): Move extern decl to ...
5186 * xterm.h: ... here, so that it can be checked for consistency.
5187
1dd3c2d9
CY
51882011-05-29 Chong Yidong <cyd@stupidchicken.com>
5189
5190 * xselect.c (x_clipboard_manager_save_frame)
5191 (x_clipboard_manager_save_all): New functions.
5192 (Fx_clipboard_manager_save): Lisp function deleted.
5193
5194 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5195 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5196
5197 * xterm.h: Update prototype.
5198
5ba6571d
WX
51992011-05-28 William Xu <william.xwl@gmail.com>
5200
5201 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5202 exiting (Bug#8239).
5203
3eaff834
JM
52042011-05-28 Jim Meyering <meyering@redhat.com>
5205
e1900994 5206 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5207 * fns.c (to_uchar): Define.
5208 (crypto_hash_function): Use it to convert some newly-signed
5209 variables to unsigned, to avoid sign-extension bugs. For example,
5210 without this change, (md5 "truc") would evaluate to
5211 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5212 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5213 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5214
0f6990a7
PE
52152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5216
5217 Integer overflow fixes.
c8a9ca5a 5218
08686060
PE
5219 * dbusbind.c: Serial number integer overflow fixes.
5220 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5221 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5222 to hold a serial number that is too large for a fixnum.
5223 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5224 Check for serial numbers out of range. Decode any serial number
59568bf0 5225 that was so large that it became a float. (Bug#8722)
08686060 5226
2d1fc3c7
PE
5227 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5228 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5229 Use XFASTINT rather than XUINT when numbers are nonnegative.
5230 (xd_append_arg, Fdbus_method_return_internal):
5231 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5232 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5233 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5234 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5235 (Bug#8722)
2d1fc3c7 5236
c8a9ca5a
PE
5237 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5238
519e1d69
PE
5239 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5240
30569699
PE
5241 ccl: add integer overflow checks
5242 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5243 (IN_INT_RANGE): New macros.
5244 (ccl_driver): Use them to check for integer overflow when
5245 decoding a CCL program. Many of the new checks are whether XINT (x)
5246 fits in int; it doesn't always, on 64-bit hosts. The new version
5247 doesn't catch all possible integer overflows, but it's an
847044ea 5248 improvement. (Bug#8719)
30569699 5249
c11285dc
PE
5250 * alloc.c (make_event_array): Use XINT, not XUINT.
5251 There's no need for unsigned here.
5252
fdccd48e
PE
5253 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5254 This follows up to the 2011-05-06 change that substituted uintptr_t
5255 for EMACS_INT. This case wasn't caught back then.
5256
37910ab2
PE
5257 Rework Fformat to avoid integer overflow issues.
5258 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5259 now (part of C89). Include <verify.h>.
5260 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5261 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5262 (Fformat): Avoid the prepass trying to compute sizes; it was only
5263 approximate and thus did not catch overflow reliably. Instead, walk
5264 through the format just once, formatting and computing sizes as we go,
5265 checking for integer overflow at every step, and allocating a larger
5266 buffer as needed. Keep track separately whether the format is
5267 multibyte. Keep only the most-recently calculated precision, rather
5268 than them all. Record whether each argument has been converted to
5269 string. Use EMACS_INT, not int, for byte and char and arg counts.
5270 Support field widths and precisions larger than INT_MAX. Avoid
5271 sprintf's undefined behavior with conversion specifications such as %#d
5272 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5273 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5274 formatting out-of-range floating point numbers with int
9173deec 5275 formats. (Bug#8668)
37910ab2 5276
2e6578fb
PE
5277 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5278
0ae6bdee
PE
5279 * data.c: Avoid integer truncation in expressions involving floats.
5280 * data.c: Include <intprops.h>.
5281 (arith_driver): When there's an integer overflow in an expression
5282 involving floating point, convert the integers to floating point
5283 so that the resulting value does not suffer from catastrophic
5284 integer truncation. For example, on a 64-bit host (* 4
5285 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5286 Do not rely on undefined behavior after integer overflow.
5287
de883a70
PE
5288 merge count_size_as_multibyte, parse_str_to_multibyte
5289 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5290 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5291 Check for integer overflow.
5292 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5293 since it's now a duplicate of the other. This is more of
5294 a character than a buffer op, so better that it's in character.c.
5295 * fns.c, print.c: Adjust to above changes.
5296
2ff916cb
PE
52972011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5298
5299 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5300
f1b54466
PE
53012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5302
fb1ac845
PE
5303 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5304 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5305 (x_clipboard_manager_save): Now static.
5306 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5307
f1b54466
PE
5308 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5309 (crypto_hash_function): Now static.
5310 Fix pointer signedness problems. Avoid unnecessary initializations.
5311
a9f737ee
CY
53122011-05-27 Chong Yidong <cyd@stupidchicken.com>
5313
5314 * termhooks.h (Vselection_alist): Make it terminal-local.
5315
5316 * terminal.c (create_terminal): Initialize it.
5317
5318 * xselect.c: Support for clipboard managers.
5319 (Vselection_alist): Move to termhooks.h as terminal-local var.
5320 (LOCAL_SELECTION): New macro.
5321 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5322 (symbol_to_x_atom): Remove gratuitous arg.
5323 (x_handle_selection_request, lisp_data_to_selection_data)
5324 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5325 (x_own_selection, x_get_local_selection, x_convert_selection):
5326 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5327 (some_frame_on_display): Delete unused function.
5328 (Fx_own_selection_internal, Fx_get_selection_internal)
5329 (Fx_disown_selection_internal, Fx_selection_owner_p)
5330 (Fx_selection_exists_p): New optional frame arg.
5331 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5332 (x_handle_selection_clear): Don't treat other terminals with the
5333 same keyboard specially. Use the terminal-local Vselection_alist.
5334 (x_clear_frame_selections): Use Frun_hook_with_args.
5335
5336 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5337
5338 * xterm.h: Add support for those atoms.
5339
e067f0c1
CY
53402011-05-26 Chong Yidong <cyd@stupidchicken.com>
5341
5342 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5343 (converted_selections, conversion_fail_tag): New global variables.
5344 (x_selection_request_lisp_error): Free the above.
5345 (x_get_local_selection): Remove unnecessary code.
5346 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5347 of converted selections stored in converted_selections.
5348 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5349 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5350 (x_convert_selection): New function.
5351 (x_handle_selection_event): Simplify.
5352 (x_get_foreign_selection): Don't ignore incoming requests while
5353 waiting for an answer; this will fail when we implement
5354 SAVE_TARGETS, and seems unnecessary anyway.
5355 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5356 (Vx_sent_selection_functions): Doc fix.
5357
0f4aebc0
LL
53582011-05-26 Leo Liu <sdl.web@gmail.com>
5359
5360 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5361
e61124cd
YM
53622011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5363
5364 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5365
5366 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5367 for fringe update if it has periodic bitmap.
ac389d0c 5368 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5369 and fringe_bitmap_periodic_p.
5370
5371 * fringe.c (get_fringe_bitmap_data): New function.
5372 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5373 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5374 row. Mark glyph row for fringe update if periodicity changed.
5375
5376 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5377 for fringe update unless it has periodic bitmap.
5378
f16d9837
KH
53792011-05-25 Kenichi Handa <handa@m17n.org>
5380
5381 * xdisp.c (get_next_display_element): Set correct it->face_id for
5382 a static composition.
5383
e1b90ef6
LL
53842011-05-24 Leo Liu <sdl.web@gmail.com>
5385
5386 * deps.mk (fns.o):
5387 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5388
5389 * fns.c (crypto_hash_function, Fsha1): New function.
5390 (Fmd5): Use crypto_hash_function.
5391 (syms_of_fns): Add Ssha1.
5392
7400048f
PE
53932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5394
5395 * gnutls.c: Remove unused macros.
5396 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5397 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5398 Remove macros that are defined and never used.
5399 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5400
abb71cf4
CY
54012011-05-22 Chong Yidong <cyd@stupidchicken.com>
5402
5403 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5404 (Fx_get_selection_internal): Minor cleanup.
5405 (Fx_own_selection_internal): Rename arguments for consistency with
5406 select.el.
5407
6307db39
PE
54082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5409
5410 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5411
f3d4e0a4
CY
54122011-05-22 Chong Yidong <cyd@stupidchicken.com>
5413
5414 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5415
4d8ade89
YM
54162011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5417
5418 * dispnew.c (scrolling_window): Don't exclude the case that the
5419 last enabled row in the desired matrix touches the bottom boundary.
5420
32078c8d
GM
54212011-05-21 Glenn Morris <rgm@gnu.org>
5422
5423 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5424 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5425 and add some more files.
32078c8d 5426
7285dc67
EZ
54272011-05-20 Eli Zaretskii <eliz@gnu.org>
5428
5429 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5430 report_file_error introduced by the change from 2011-05-07.
5431
89d1bd22
PE
54322011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5433
5434 * systime.h (Time): Define only if emacs is defined.
5435 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5436 where the include path doesn't have X11/X.h by default. See
5437 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5438
e23640bb 54392011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5440
5441 * composite.c (find_automatic_composition): Fix previous change.
5442
b9704ad9
GM
54432011-05-20 Glenn Morris <rgm@gnu.org>
5444
5445 * lisp.mk: New file, split from Makefile.in.
5446 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5447 (shortlisp): Remove.
5448 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5449
4a720484
GM
54502011-05-19 Glenn Morris <rgm@gnu.org>
5451
5452 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5453 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5454 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5455 (lisp): Set the order to that of loadup.el.
5456 (shortlisp): Make it a copy of $lisp.
5457 (SOME_MACHINE_LISP): Remove.
5458 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5459 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5460
a28d4396
KH
54612011-05-18 Kenichi Handa <handa@m17n.org>
5462
5463 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5464 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5465 (find_automatic_composition): Mostly rewrite for efficiency.
5466
a2b1fa8e
JB
54672011-05-18 Juanma Barranquero <lekktu@gmail.com>
5468
5469 * makefile.w32-in: Update dependencies.
5470
8e1f5610
CS
54712011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5472
5473 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5474 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5475
7025ee00 54762011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5477
cdfa6eab
PE
5478 Fix some integer overflow issues, such as string length overflow.
5479
06d6db33
PE
5480 * insdel.c (count_size_as_multibyte): Check for string overflow.
5481
2b4560a8
PE
5482 * character.c (lisp_string_width): Check for string overflow.
5483 Use EMACS_INT, not int, for string indexes and lengths; in
5484 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5485 the resulting string length overflows an EMACS_INT; instead,
5486 report a string overflow if no precision given. When checking for
5487 precision exhaustion, use a check that cannot possibly have
5488 integer overflow. (Bug#8675)
5489 * character.h (lisp_string_width): Adjust to new signature.
5490
cb93f9be
PE
5491 * alloc.c (string_overflow): New function.
5492 (Fmake_string): Use it. This doesn't change behavior, but saves
5493 a few bytes and will simplify future changes.
5494 * character.c (string_escape_byte8): Likewise.
5495 * lisp.h (string_overflow): New decl.
5496
1a1f3366
PE
5497 Fixups, following up to the user-interface timestamp change.
5498 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5499 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5500 * msdos.c (mouse_get_pos): Likewise.
5501 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5502 * w32gui.h (Time): Define by including "systime.h" rather than by
5503 declaring it ourselves. (Bug#8664)
5504
d4e3e4d3
PE
5505 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5506 * image.c (clear_image_cache): Likewise.
5507
f6a24d19
PE
5508 * term.c (term_mouse_position): Don't assume time_t wraparound.
5509
08dc5ae6
PE
5510 Be more systematic about user-interface timestamps.
5511 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5512 and sometimes 'EMACS_UINT', to represent these timestamps.
5513 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5514 This makes the code easier to follow, and makes it easier to catch
5515 integer overflow bugs such as Bug#8664.
5516 * frame.c (Fmouse_position, Fmouse_pixel_position):
5517 Use Time, not unsigned long, for user-interface timestamps.
5518 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5519 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5520 * keyboard.h (last_event_timestamp): Likewise.
5521 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5522 * menu.h (xmenu_show): Likewise.
5523 * term.c (term_mouse_position): Likewise.
5524 * termhooks.h (struct input_event.timestamp): Likewise.
5525 (struct terminal.mouse_position_hook): Likewise.
5526 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5527 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5528 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5529 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5530 what it was before.
5531 * menu.h, termhooks.h: Include "systime.h", for Time.
5532
8e55734a
PE
5533 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5534 Don't assume that the difference between two unsigned long values
5535 can fit into an integer. At this point, we know button_down_time
5536 <= event->timestamp, so the difference must be nonnegative, so
5537 there's no need to cast the result if double-click-time is
5538 nonnegative, as it should be; check that it's nonnegative, just in
5539 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5540 apart (about 25 days). (Bug#8664)
8e55734a 5541
841f1b75 5542 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5543 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5544
3e26f69c
PE
5545 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5546 that always fit in int. Use a sentinel instead of a counter, to
5547 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5548 * frame.h (struct frame): Use int for menu_bar_items_used
5549 instead of EMACS_INT, since it always fits in int.
3e26f69c 5550
5cc152c0
PE
5551 * menu.c (grow_menu_items): Check for int overflow.
5552
d89eb65e
PE
5553 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5554
5235bd3e
PE
5555 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5556 Before, the code was not consistent. These values cannot exceed
5557 2**31 - 1 so there's no need to make them unsigned.
5558 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5559 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5560 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5561 as modifiers.
5562 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5563
bc827e23
PE
5564 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5565 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5566 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5567 presumably because the widths might not match.
5568
78eb494e
PE
5569 * window.c (size_window): Avoid needless test at loop start.
5570
04f2d78b
CB
55712011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5572
5573 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5574
d2fc7e3d 55752011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5576
5577 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5578
d2fc7e3d 55792011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5580
5581 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5582 `width' to `bar_area_x' and `bar_area_width', respectively.
5583 (x_scroll_run): Take account of fringe background extension.
5584
04f2d78b
CB
5585 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5586 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5587 `bar_area_width', respectively.
5588 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5589 background extension.
5590
79b70037
GM
55912011-05-10 Jim Meyering <meyering@redhat.com>
5592
5593 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5594
2f142cc5
JB
55952011-05-10 Juanma Barranquero <lekktu@gmail.com>
5596
5597 * image.c (Finit_image_library): Return t for built-in image types,
5598 like pbm and xbm. (Bug#8640)
5599
57679c86
AS
56002011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5601
5602 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5603
888c9e86
EZ
56042011-05-07 Eli Zaretskii <eliz@gnu.org>
5605
b0512a1d
EZ
5606 * w32console.c (Fset_screen_color): Doc fix.
5607 (Fget_screen_color): New function.
5608 (syms_of_ntterm): Defsubr it.
5609
7285dc67
EZ
5610 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5611 unlink the temporary file if Fcall_process didn't create it in the
5612 first place.
5613 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5614 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5615 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5616 cue to call_process_cleanup not to close that handle.
5617
4d3fcc8e
BK
56182011-05-07 Ben Key <bkey76@gmail.com>
5619
5620 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5621 one of two shell specific rules, either bootstrap-temacs-CMD or
5622 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5623 to the previous implementation of the bootstrap-temacs rule.
5624 The bootstrap-temacs-CMD rule is similar to the previous
5625 implementation of the bootstrap-temacs rule except that it
5626 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5627 variable.
5628
5629 These changes, along with some changes to nt/configure.bat,
5630 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5631 earlier fix to add support for --cflags and --ldflags options
5632 that include quotes so that it works whether make uses cmd or
5633 sh as the shell.
5634
b4289b64
MA
56352011-05-06 Michael Albinus <michael.albinus@gmx.de>
5636
5637 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5638 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5639 is a constant.
5640 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5641 a string. Handle both cases.
5642 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5643 (Fdbus_register_method): Use Qinvalid_function.
5644
af4c0e28
JB
56452011-05-06 Juanma Barranquero <lekktu@gmail.com>
5646
5647 * makefile.w32-in: Update dependencies.
5648 (LISP_H): Add inttypes.h and stdin.h.
5649 (PROCESS_H): Add unistd.h.
5650
c51453d9
EZ
56512011-05-06 Eli Zaretskii <eliz@gnu.org>
5652
5653 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5654 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5655
8ff0ac3c 56562011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5657
4c4b566b
PE
5658 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5659
aab2b9b5
PE
5660 * term.c (vfatal): Remove stray call to va_end.
5661 It's not needed and the C Standard doesn't allow it here anyway.
5662
c378da0b
PE
5663 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5664 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5665
288b08c7
PE
5666 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5667 bytes.
5668
e3601888
PE
5669 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5670
db6c0e74
PE
5671 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5672
dd5963ea
PE
5673 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5674
88c9450f
PE
5675 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5676
2f9442b8
PE
5677 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5678
c032b5f8
PE
5679 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5680 * charset.c (Fdefine_charset_internal): Don't initialize
5681 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5682 32-bit int (Bug#8600).
a108c10b
PE
5683
5684 * lread.c (read_integer): Be more consistent with string-to-number.
5685 Use string_to_number to do the actual conversion; this avoids
5686 rounding errors and fixes some other screwups. Without this fix,
5687 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5688 (digit_to_number): Move earlier, for benefit of read_integer.
5689 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5690 not a digit in any supported base. (Bug#8602)
a108c10b 5691
ad5f9eea
PE
5692 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5693
aec1708a
PE
5694 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5695 to match comment at start of function. This also removes a
5696 GCC warning about overflow in a 32+64-bit port.
5697
47be4ab5
PE
5698 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5699
371cac43
PE
5700 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5701 Reported by Stefan Monnier in
5702 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5703 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5704 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5705
d01a7826
PE
5706 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5707 (EMACS_UINTPTR): Likewise, with uintptr_t.
5708
7fd47d5c
PE
5709 * lisp.h: Prefer 64-bit EMACS_INT if available.
5710 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5711 on 32-bit hosts that have 64-bit int, so that they can access
5712 large files.
122b0c86
PE
5713 However, temporarily disable this change unless the temporary
5714 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5715
8727937b
PE
5716 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5717
8ac068ac
PE
5718 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5719 This removes an assumption that EMACS_INT and long are the same
5720 width as pointers. The assumption is true for Emacs porting targets
5721 now, but we want to make other targets possible.
5722 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5723 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5724 In the rest of the code, change types of integers that hold casted
5725 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5726 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5727 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5728 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5729 No need to cast type when ORing.
5730 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5731 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5732 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5733 assume EMACS_INT is the same width as char *.
5734 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5735 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5736 Remove no-longer-needed casts.
5737 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5738 (xg_tool_bar_help_callback, xg_make_tool_item):
5739 Use EMACS_INTPTR to hold an integer
5740 that will be cast to void *; this can avoid a GCC warning
5741 if EMACS_INT is not the same width as void *.
5742 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5743 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5744 (current_message_1, set_message_1):
5745 Use a local to convert to proper width without a cast.
5746 * xmenu.c (dialog_selection_callback): Likewise.
5747
ede49d71
PE
5748 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5749 Also, don't assume VALBITS / RAND_BITS is less than 5,
5750 and don't rely on undefined behavior when shifting a 1 left into
5751 the sign bit.
5752 * lisp.h (get_random): Change signature to match.
5753
2f30ecd0
PE
5754 * lread.c (hash_string): Use size_t, not int, for hash computation.
5755 Normally we prefer signed values; but hashing is special, because
5756 it's better to use unsigned division on hash table sizes so that
5757 the remainder is nonnegative. Also, size_t is the natural width
5758 for hashing into memory. The previous code used 'int', which doesn't
5759 retain enough info to hash well into very large tables.
5760 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5761
2a866e7b
PE
5762 * dbusbind.c: Don't possibly lose pointer info when converting.
5763 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5764 Use XPNTR rather than XHASH, so that the high-order bits of
5765 the pointer aren't lost when converting through void *.
5766
51639eac
PE
5767 * eval.c (Fautoload): Don't double-shift a pointer.
5768
92394119
PE
5769 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5770
dbdb9a7c
JB
57712011-05-06 Juanma Barranquero <lekktu@gmail.com>
5772
5773 * gnutls.c (DEF_GNUTLS_FN):
5774 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5775
db7a0b4f
AS
57762011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5777
5778 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5779 marker. (Bug#8610)
5780
f7ff1b0f 57812011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5782
5783 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5784 New version that can reserve upto 2GB of heap space.
5785
f7ff1b0f 57862011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5787
5788 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5789
639c109b
TZ
57902011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5791
5792 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5793 `gnutls_certificate_set_x509_key_file'.
5794
d2127135
JB
57952011-05-05 Juanma Barranquero <lekktu@gmail.com>
5796
5797 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5798 Update dependencies.
5799
e968f4f3
JB
58002011-05-04 Juanma Barranquero <lekktu@gmail.com>
5801
5802 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5803 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5804 Remove unused parameter `fildes'.
5805 * process.c (read_process_output, send_process): Don't pass it.
5806
84d358f0
JB
58072011-05-04 Juanma Barranquero <lekktu@gmail.com>
5808
5809 Fix previous change: the library cache is defined in w32.c.
5810 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5811 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5812
0898ca10
JB
58132011-05-04 Juanma Barranquero <lekktu@gmail.com>
5814
5815 Implement dynamic loading of GnuTLS on Windows.
5816
5817 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5818 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5819 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5820 Declare.
5821
5822 * gnutls.c (Qgnutls_dll): Define.
5823 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5824 (gnutls_*): Declare function pointers.
5825 (init_gnutls_functions): New function to initialize function pointers.
5826 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5827 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5828 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5829 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5830 (emacs_gnutls_write, emacs_gnutls_read)
5831 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5832 (Fgnutls_available_p): New function.
5833 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5834 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5835 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5836
5837 * image.c: Include w32.h.
5838 (Vimage_type_cache): Delete.
5839 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5840 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5841 (w32_delayed_load): Move to w32.c.
5842
5843 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5844
5845 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5846 (w32_delayed_load): Move from image.c. When loading a library, record
5847 its filename in the :loaded-from property of the library id.
5848 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5849 Initialize and staticpro them.
5850 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5851
5852 * process.c: Include lisp.h before w32.h, not after.
5853 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5854 instead of gnutls_record_check_pending.
5855
5856 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5857
ff4de4aa
TZ
58582011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5859
5860 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5861 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5862 as passed in.
5863
abe95abb
JD
58642011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5865
5866 * xterm.c (x_set_frame_alpha): Do not set property on anything
5867 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5868
e16e55d4
JB
58692011-05-02 Juanma Barranquero <lekktu@gmail.com>
5870
5871 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5872
bafcf6a5
JB
58732011-05-02 Juanma Barranquero <lekktu@gmail.com>
5874
5875 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5876 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5877 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5878 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5879 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5880 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5881 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5882 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5883 (Qgnutls_bootprop_callbacks_verify): Make static.
5884
e7a6747f
AS
58852011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5886
19ed11ba
AS
5887 * callproc.c: Indentation fixup.
5888
e7a6747f 5889 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5890 (wait_for_termination, interruptible_wait_for_termination):
5891 Move after wait_for_termination_1.
e7a6747f 5892
1ef14cb4
LMI
58932011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5894
5895 * sysdep.c (interruptible_wait_for_termination): New function
5896 which is like wait_for_termination, but allows keyboard
5897 interruptions.
5898
5899 * callproc.c (Fcall_process): Add (:file "file") as an option for
5900 the STDOUT buffer.
5901 (Fcall_process_region): Ditto.
5902
330d880c
EZ
59032011-04-30 Eli Zaretskii <eliz@gnu.org>
5904
8db90b73
EZ
5905 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5906 rather than `XVECTOR (FOO)->size'.
5907
330d880c
EZ
5908 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5909 inttypes.h, as a gnulib replacement is used if it not available in
5910 system headers.
5911
15cbd324
EZ
59122011-04-21 Eli Zaretskii <eliz@gnu.org>
5913
5914 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5915 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5916 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5917
5918 * coding.c (coding_alloc_by_realloc): Error out if destination
5919 will grow beyond MOST_POSITIVE_FIXNUM.
5920 (decode_coding_emacs_mule): Abort if there isn't enough place in
5921 charbuf for the composition carryover bytes. Reserve an extra
5922 space for up to 2 characters produced in a loop.
5923 (decode_coding_iso_2022): Abort if there isn't enough place in
5924 charbuf for the composition carryover bytes.
5925
59262011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5927
ae940cca
EZ
5928 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5929 aborting when %lld or %lll format is passed.
5930 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5931 %llo or %llx format is passed. (Bug#8545)
5932
03ab8921
EZ
5933 * window.c (window_scroll_line_based): Use a marker instead of
5934 simple variables to record original value of point. (Bug#7952)
5935
afda1437
EZ
5936 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5937 produced by %s or %c overflows available buffer space. (Bug#8545)
5938
f76dee0c
PE
59392011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5940
5941 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5942 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5943
fdc5744d
JB
59442011-04-28 Juanma Barranquero <lekktu@gmail.com>
5945
5946 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5947
638f053a
JB
59482011-04-28 Juanma Barranquero <lekktu@gmail.com>
5949
5950 * keyboard.c (Qdelayed_warnings_hook): Define.
5951 (command_loop_1): Run `delayed-warnings-hook'
5952 if Vdelayed_warnings_list is non-nil.
5953 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5954 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5955
d178f871
EZ
59562011-04-28 Eli Zaretskii <eliz@gnu.org>
5957
5958 * doprnt.c (doprnt): Don't return value smaller than the buffer
5959 size if the message was truncated. (Bug#8545).
5960
b124fd93
JB
59612011-04-28 Juanma Barranquero <lekktu@gmail.com>
5962
5963 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5964 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5965
e810457d
PE
59662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5967
5968 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5969
ea51cceb
JB
59702011-04-27 Juanma Barranquero <lekktu@gmail.com>
5971
5972 * makefile.w32-in: Update dependencies.
5973
94dcfacf
EZ
59742011-04-27 Eli Zaretskii <eliz@gnu.org>
5975
5976 Improve `doprnt' and its usage. (Bug#8545)
5977 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5978 `format_end'. Remove support for %l as a conversion specifier.
5979 Don't use xrealloc. Improve diagnostics when the %l size modifier
5980 is used. Update the commentary.
5981
5982 * eval.c (verror): Simplify calculation of size_t.
5983
5984 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5985 messages.
5986
f61f41d7
PE
59872011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5988
5989 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5990 change.
5991
96fb4434
PE
59922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5993
5994 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5995 This makes this file independent of the recent pseudovector change.
5996
671875da 59972011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5998
69e9b5a3
PE
5999 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6000
b5f869a7 6001 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6002 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6003 Remove unused local.
c8926152 6004 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6005
841a1577 6006 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6007 GCC 4.6.0 optimizes based on type-based alias analysis.
6008 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6009 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6010 != &v->size, and therefore "v->size = 1; b->size = 2; return
6011 v->size;" must therefore return 1. This assumption is incorrect
6012 for Emacs, since it type-puns struct Lisp_Vector * with many other
6013 types. To fix this problem, this patch adds a new type struct
f904488f 6014 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6015 and pseudovectors, and helps optimizing compilers not get fooled
6016 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6017 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6018 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6019 the size member.
eab3844f
PE
6020 (XSETPVECTYPE): Rewrite in terms of new macro.
6021 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6022 This is a bit clearer, and further avoids the possibility of
6023 undesirable aliasing.
6024 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6025 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6026 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6027 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6028 (ASIZE): Now uses header.size rather than size.
6029 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6030 to avoid the hassle of writing XVECTOR (foo)->header.size.
6031 (struct vectorlike_header): New type.
eab3844f
PE
6032 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6033 object, to help avoid aliasing.
6034 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6035 (SUBRP): Likewise, since Lisp_Subr is a special case.
6036 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6037 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6038 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6039 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6040 changed to be "header.size" and "header.next".
6041 * buffer.h (struct buffer): Likewise.
6042 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6043 * frame.h (struct frame): Likewise.
6044 * process.h (struct Lisp_Process): Likewise.
6045 * termhooks.h (struct terminal): Likewise.
6046 * window.c (struct save_window_data, struct saved_window): Likewise.
6047 * window.h (struct window): Likewise.
6048 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6049 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6050 * buffer.c (init_buffer_once): Likewise.
6051 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6052 special case.
6053 * process.c (Fformat_network_address): Use local var for size,
6054 for brevity.
6055
0df1eac5
PE
6056 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6057
847ab9d1 6058 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6059 * data.c (atof): Remove decl; no longer used or needed.
6060 (digit_to_number): Move to lread.c.
6061 (Fstring_to_number): Use new string_to_number function, to be
6062 consistent with how the Lisp reader treats infinities and NaNs.
6063 Do not assume that floating-point numbers represent EMACS_INT
6064 without losing information; this is not true on most 64-bit hosts.
6065 Avoid double-rounding errors, by insisting on integers when
6066 parsing non-base-10 numbers, as the documentation specifies.
6067 * lisp.h (string_to_number): New decl, replacing ...
6068 (isfloat_string): Remove.
bc0a5c13 6069 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6070 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6071 appears to have been a coding error. Similarly, do not accept
6072 strings like +-1e0 as floating point numbers. Do not report
6073 overflow for integer overflows unless the base is not 10 which
6074 means we have no simple and reliable way to continue.
6075 Break out the floating-point parsing into a new
6076 function string_to_number, so that Fstring_to_number parses
6077 floating point numbers consistently with the Lisp reader.
04f2d78b 6078 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6079 (E_CHAR, EXP_INT): Remove, replacing with ...
6080 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6081 (string_to_number): New function, replacing isfloat_string.
6082 This function checks for valid syntax and produces the resulting
6083 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6084 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6085 so that overflow for non-base-10 numbers is reported only when
6086 there's no portable and simple way to convert to floating point.
452f4150 6087
67769ffc
PE
6088 * textprop.c (set_text_properties_1): Rewrite for clarity,
6089 and to avoid GCC warning about integer overflow.
6090
c20db43f
PE
6091 * intervals.h (struct interval): Use EMACS_INT for members
6092 where EMACS_UINT might cause problems. See
6093 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6094 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6095 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6096 All uses changed.
37aa2f85
PE
6097 (offset_intervals): Tell GCC not to worry about length overflow
6098 when negating a negative length.
c20db43f 6099
2538aa2f
PE
6100 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6101 (overrun_check_free): Likewise.
6102
f2d3008d
PE
6103 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6104 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6105 word size.
6106
ec8df744
PE
6107 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6108 (gnutls_make_error): Rename local to avoid shadowing.
6109 (gnutls_emacs_global_deinit): ifdef out; not used.
6110 (Fgnutls_boot): Use const for pointer to readonly storage.
6111 Comment out unused local. Fix pointer signedness problems.
6112
640ee02d
PE
6113 * lread.c (openp): Don't stuff size_t into an 'int'.
6114 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6115 about possible signed overflow.
6116
6048fb2a
PE
6117 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6118 (GDK_KEY_g): Don't define if already defined.
6119 (xg_prepare_tooltip): Avoid pointer signedness problem.
6120 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6121
fa3c87e1
PE
6122 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6123 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6124
2172544b
PE
6125 * xfns.c (Fx_window_property): Simplify a bit,
6126 to make a bit faster and to avoid GCC 4.6.0 warning.
6127 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6128
9b821a21
PE
6129 * fns.c (internal_equal): Don't assume size_t fits in int.
6130
3c616cfa
PE
6131 * alloc.c (compact_small_strings): Tighten assertion a little.
6132
c2982e87
PE
6133 Replace pEd with more-general pI, and fix some printf arg casts.
6134 * lisp.h (pI): New macro, generalizing old pEd macro to other
6135 conversion specifiers. For example, use "...%"pI"d..." rather
6136 than "...%"pEd"...".
6137 (pEd): Remove. All uses replaced with similar uses of pI.
6138 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6139 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6140 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6141 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6142 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6143 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6144 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6145 64-bit hosts.
6146 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6147 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6148 * print.c (safe_debug_print, print_object): Likewise.
6149 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6150 to int.
6f04d126
PE
6151 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6152 avoiding the 0 flag, which is not portable.
c2982e87
PE
6153 * process.c (Fmake_network_process): Use pI to avoid cast.
6154 * region-cache.c (pp_cache): Likewise.
6155 * xdisp.c (decode_mode_spec): Likewise.
6156 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6157 behavior on 64-bit hosts with printf arg.
6f04d126 6158 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6159 (x_stop_queuing_selection_requests): Likewise.
6160 (x_get_window_property): Don't truncate byte count to an 'int'
6161 when tracing.
0b432f21 6162
5e073ec7
PE
6163 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6164 here, since it parses constructs like leading '-' and spaces,
6165 which are not wanted; and it overflows with large numbers.
6166 Instead, simply match F[0-9]+, which is what is wanted anyway.
6167
36372bf9
PE
6168 * alloc.c: Remove unportable assumptions about struct layout.
6169 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6170 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6171 (allocate_vectorlike, make_pure_vector): Use the new macros,
6172 plus offsetof, to remove unportable assumptions about struct layout.
6173 These assumptions hold on all porting targets that I know of, but
6174 they are not guaranteed, they're easy to remove, and removing them
6175 makes further changes easier.
6176
0b432f21
PE
6177 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6178 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6179 (string_overrun_cookie): Now const. Use initializers that
6180 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6181 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6182 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6183 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6184 multiple of sizeof (EMACS_INT); it need not be, if
6185 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6186 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6187
895009e1
JB
61882011-04-26 Juanma Barranquero <lekktu@gmail.com>
6189
6190 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6191
6a7a1b0b
TZ
61922011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6193
6194 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6195 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6196 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6197
841a1577 61982011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6199
6200 * lisp.h (Qdebug): List symbol.
895009e1 6201 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6202 * keyboard.c (debug-on-event): New variable.
6203 (handle_user_signal): Break into debugger when debug-on-event
6204 matches the current signal symbol.
6205
f2d3ba6f
DN
62062011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6207
6208 * alloc.c (check_sblock, check_string_bytes)
6209 (check_string_free_list): Convert to standard C.
6210
42ce4c63
TZ
62112011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6212
6213 * w32.c (emacs_gnutls_push): Fix typo.
6214
825cd63c
EZ
62152011-04-25 Eli Zaretskii <eliz@gnu.org>
6216
fb11d64d
EZ
6217 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6218 "cast to pointer from integer of different size".
6219
825cd63c
EZ
6220 Improve doprnt and its use in verror. (Bug#8545)
6221 * doprnt.c (doprnt): Document the set of format control sequences
6222 supported by the function. Use SAFE_ALLOCA instead of always
6223 using `alloca'.
6224
6225 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6226 is one byte too soon. Don't use xrealloc; instead xfree and
6227 xmalloc anew.
6228
e061a11b
TZ
62292011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6230
6231 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6232 callbacks stage.
6233
6234 * gnutls.c: Renamed global_initialized to
6235 gnutls_global_initialized. Added internals for the
6236 :verify-hostname-error, :verify-error, and :verify-flags
6237 parameters of `gnutls-boot' and documented those parameters in the
6238 docstring. Start callback support.
9173deec
JB
6239 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6240 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6241 on error. Return error code.
e061a11b
TZ
6242 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6243 (emacs_gnutls_read): Likewise.
6244 (Fgnutls_boot): Return handshake error code.
6245 (emacs_gnutls_handle_error): New function.
6246 (wsaerror_to_errno): Likewise.
6247
6248 * w32.h (emacs_gnutls_pull): Add prototype.
6249 (emacs_gnutls_push): Likewise.
6250
6251 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6252 (emacs_gnutls_push): Likewise.
6253
62542011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6255
6256 * process.c (wait_reading_process_output): Check if GnuTLS
6257 buffered some data internally if no FDs are set for TLS
6258 connections.
6259
6260 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6261 (LIBS): Link to USER_LIBS.
6262 ($(BLD)/gnutls.$(0)): New target.
6263
fa6996bc
EZ
62642011-04-24 Eli Zaretskii <eliz@gnu.org>
6265
eb35682e
EZ
6266 * xdisp.c (handle_single_display_spec): Rename the
6267 display_replaced_before_p argument into display_replaced_p, to
6268 make it consistent with the commentary. Fix typos in the
6269 commentary.
6270
e2ad650c
EZ
6271 * textprop.c (syms_of_textprop): Remove dead code.
6272 (copy_text_properties): Delete obsolete commentary about an
6273 interface that was deleted long ago. Fix typos in the description
6274 of arguments.
6275
1b2de274
EZ
6276 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6277 to changes in oldXMenu/XMenu.h from 2011-04-16.
6278 <menu_help_message, prev_menu_help_message>: Constify.
6279 (IT_menu_make_room): menu->help_text is now `const char **';
6280 adjust.
6281
6282 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6283 to changes in oldXMenu/XMenu.h from 2011-04-16.
6284 (struct XMenu): Declare `help_text' `const char **'.
6285
6286 * xfaces.c <Qunspecified>: Make extern again.
6287
6288 * syntax.c: Include sys/types.h before including regex.h, as
6289 required by Posix.
6290
762b15be
EZ
6291 * doc.c (get_doc_string): Improve the format passed to `error'.
6292
6293 * doprnt.c (doprnt): Improve commentary.
6294
6295 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6296
6297 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6298 them with etags.
6299
f1052e5d
EZ
6300 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6301 changes in globals.h immediately force recompilation.
762b15be
EZ
6302 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6303 $(CURDIR)/s/ms-w32.h.
6304 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6305
fa6996bc
EZ
6306 * character.c (Fchar_direction): Function deleted.
6307 (syms_of_character): Don't defsubr it.
6308 <char-direction-table>: Deleted.
6309
e6c3da20
EZ
63102011-04-23 Eli Zaretskii <eliz@gnu.org>
6311
6312 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6313 * doprnt.c: Include limits.h.
6314 (SIZE_MAX): New macro.
04f2d78b
CB
6315 (doprnt): Return a size_t value. 2nd arg is now size_t.
6316 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6317 Improve overflow protection. Support `l' modifier for integer
6318 conversions. Support %l conversion. Don't assume an EMACS_INT
6319 argument for integer conversions and for %c.
6320
6321 * lisp.h (doprnt): Restore prototype.
6322
6323 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6324 $(SRC)/character.h.
6325
6326 * Makefile.in (base_obj): Add back doprnt.o.
6327
6328 * deps.mk (doprnt.o): Add back prerequisites.
6329 (callint.o): Depend on character.h.
6330
6331 * eval.c (internal_lisp_condition_case): Include the handler
6332 representation in the error message.
6333 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6334 when breaking from the loop.
6335
6336 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6337
6338 * callint.c (Fcall_interactively): When displaying error message
6339 about invalid control letter, pass the character's codepoint, not
6340 a pointer to its multibyte form. Improve display of the character
6341 in octal and display also its hex code.
6342
6343 * character.c (char_string): Use %x to display the (unsigned)
6344 codepoint of an invalid character, to avoid displaying a bogus
6345 negative value.
6346
6347 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6348 `error', not SYMBOL_NAME itself.
6349
6350 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6351 character arguments to `error'.
6352
6353 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6354 to `error' in error message about FINAL_CHAR argument. Make sure
6355 FINAL_CHAR is a character, and use %c when it is passed as
6356 argument to `error'.
6357
4ffd0d6b 63582011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6359
6360 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6361
6362 * w32.c: Include <time.h>.
6363 (sys_localtime): New function.
6364
4ffd0d6b 63652011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6366
6367 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6368
4ffd0d6b 6369 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6370
4ffd0d6b 63712011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6372
4ffd0d6b
GM
6373 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6374 zombies (Bug#8467).
aac0c6e3 6375
04c56954
EZ
63762011-04-19 Eli Zaretskii <eliz@gnu.org>
6377
6378 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6379 gl_state.e_property when gl_state.object is Qt.
6380
6381 * insdel.c (make_gap_larger): Remove limitation of buffer size
6382 to <= INT_MAX.
6383
16a43933
CY
63842011-04-18 Chong Yidong <cyd@stupidchicken.com>
6385
6386 * xdisp.c (lookup_glyphless_char_display)
6387 (produce_glyphless_glyph): Handle cons cell entry in
6388 glyphless-char-display.
6389 (Vglyphless_char_display): Document it.
6390
6391 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6392 glyphless-char-display.
6393
4581706e
CY
63942011-04-17 Chong Yidong <cyd@stupidchicken.com>
6395
6396 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6397
6398 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6399
6400 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6401 definition for no-X builds.
6402
4887c6e2 64032011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6404
fd35b6f9
PE
6405 Static checks with GCC 4.6.0 and non-default toolkits.
6406
5c1ccb01
PE
6407 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6408
006c5daa
PE
6409 * process.c (keyboard_bit_set): Define only if SIGIO.
6410 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6411 (send_process): Repair possible setjmp clobbering.
6412
efc736d3
PE
6413 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6414
4e2fe2e6
PE
6415 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6416
f97334a2
PE
6417 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6418
4e75f29d
PE
6419 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6420 Define only if needed.
6421
90efadd1
PE
6422 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6423 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6424 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6425
3c647824
PE
6426 * dispextern.h (struct redisplay_interface): Rename param
6427 to avoid shadowing.
e264f262 6428 * termhooks.h (struct terminal): Likewise.
761383f4 6429 * xterm.c (xembed_send_message): Likewise.
3c647824 6430
b58c5c4a
PE
6431 * insdel.c (make_gap_smaller): Define only if
6432 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6433
cad59032
PE
6434 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6435 it.
6436
c339dc2e
PE
6437 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6438 so that we aren't warned about unused symbols.
6439
91a3e27b
PE
6440 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6441
399c71d3 6442 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6443
8ffc96f5
PE
6444 * xfns.c (x_real_positions): Mark locals as initialized.
6445
eef9bc79
PE
6446 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6447
098db9dd
PE
6448 * xterm.c: Fix problems found by static analysis with other toolkits.
6449 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6450 (x_dispatch_event): Declare static if USE_GTK, and
6451 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6452 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6453 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6454 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6455 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6456
eb18f6cc
PE
6457 * xmenu.c (menu_help_callback): Pointer type fixes.
6458 Use const pointers when pointing at readonly data. Avoid pointer
6459 signedness clashes.
6460 (FALSE): Remove unused macro.
6461 (update_frame_menubar): Remove unused decl.
6462
1fe72bf8
PE
6463 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6464
60d9e1db
PE
6465 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6466 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6467 (single_menu_item): Rename local to avoid shadowing.
6468
39261c26
PE
6469 * keyboard.c (make_lispy_event): Remove unused local var.
6470
018c5e19
PE
6471 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6472 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6473
63d2b86e
PE
6474 * bitmaps: Change bitmaps from unsigned char back to the X11
6475 compatible char. Avoid the old compiler warnings about
6476 out-of-range initializers by using, for example, '\xab' rather
6477 than 0xab.
6478
aefd87e1
PE
6479 * xgselect.c (xgselect_initialize): Check vs interface
6480 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6481
bf501fb9
PE
6482 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6483
e9829fdf
PE
6484 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6485 to read-only memory.
6486
1086c095
PE
6487 * fns.c (vector): Remove; this old hack is no longer needed.
6488
2baccd04 6489 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6490 Remove unused var.
dde42981 6491 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6492
72391843 6493 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6494
436c16df 6495 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6496 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6497 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6498
92bb796d 6499 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6500 (x_term_init): Remove local to avoid shadowing.
92bb796d 6501
764430a3 6502 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6503
6504 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6505 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6506
d1dfb56c
EZ
65072011-04-16 Eli Zaretskii <eliz@gnu.org>
6508
c4354cb4
EZ
6509 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6510
d1dfb56c
EZ
6511 Fix regex.c, syntax.c and friends for buffers > 2GB.
6512 * syntax.h (struct gl_state_s): Declare character position members
6513 EMACS_INT.
6514
6515 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6516
04f2d78b
CB
6517 * textprop.c (verify_interval_modification, interval_of):
6518 Declare arguments EMACS_INT.
d1dfb56c
EZ
6519
6520 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6521 EMACS_INT.
6522
6523 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6524
6525 * indent.c (Fvertical_motion): Local variable it_start is now
6526 EMACS_INT.
6527
6528 * regex.c (re_match, re_match_2, re_match_2_internal)
6529 (bcmp_translate, regcomp, regexec, print_double_string)
6530 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6531 (re_compile_pattern, re_exec): Declare arguments and local
6532 variables `size_t' and `ssize_t' and return values `regoff_t', as
6533 appropriate.
6534 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6535 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6536 <compile_stack_type>: `size' and `avail' are now `size_t'.
6537
6538 * regex.h <regoff_t>: Use ssize_t, not int.
6539 (re_search, re_search_2, re_match, re_match_2): Arguments that
6540 specify buffer/string position and length are now ssize_t and
6541 size_t. Return type is regoff_t.
6542
613052cd
BK
65432011-04-16 Ben Key <bkey76@gmail.com>
6544
6545 * nsfont.m: Fixed bugs in ns_get_family and
6546 ns_descriptor_to_entity that were caused by using free to
6547 deallocate memory blocks that were allocated by xmalloc (via
6548 xstrdup). This caused Emacs to crash when compiled with
6549 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6550 --enable-checking=xmallocoverrun). xfree is now used to
6551 deallocate these memory blocks.
6552
4170f62f 65532011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6554
71b41406
PE
6555 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6556
9587a89d
PE
6557 emacs_write: Accept and return EMACS_INT for sizes.
6558 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6559 et seq.
6560 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6561 Accept and return EMACS_INT.
6562 (emacs_gnutls_write): Return the number of bytes written on
6563 partial writes.
6564 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6565 (emacs_read, emacs_write): Remove check for negative size, as the
6566 Emacs source code has been audited now.
9587a89d
PE
6567 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6568 (emacs_read, emacs_write): Use it.
273a5f82
PE
6569 * process.c (send_process): Adjust to the new signatures of
6570 emacs_write and emacs_gnutls_write. Do not attempt to store
6571 a byte offset into an 'int'; it might overflow.
9587a89d 6572 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6573
3e047f51
PE
6574 * sound.c: Don't assume sizes fit in 'int'.
6575 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6576 Return EMACS_INT, not int.
3e047f51 6577 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6578 Accept EMACS_INT, not int.
6579 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6580 record read return values.
6581
cc39a9db
BK
65822011-04-15 Ben Key <bkey76@gmail.com>
6583
c9d0ec6d
JB
6584 * keyboard.c (Qundefined): Don't declare static since it is used
6585 in nsfns.m.
6586 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6587 static since they are used in nsfont.m.
cc39a9db 6588
6c60eb9f
SM
65892011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6590
6591 * process.c (Qprocessp): Don't declare static.
6592 * lisp.h (Qprocessp): Declare again.
6593
7990b61a
JB
65942011-04-15 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6597
5d4cb038
PE
65982011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6599
8bd7b830 6600 Improve C-level modularity by making more things 'static'.
cd64ea1d 6601
e3b27b31
PE
6602 Don't publish debugger-only interfaces to other modules.
6603 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6604 (verify_bytepos, count_markers): Move decls to the only modules
6605 that need them.
6606 * region-cache.h (pp_cache): Likewise.
6607 * window.h (check_all_windows): Likewise.
6608 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6609
5d4cb038
PE
6610 * sysdep.c (croak): Now static, if
6611 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6612 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6613
6614 * alloc.c (refill_memory_reserve): Now static if
6615 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6616 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6617
e87b6180
PE
6618 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6619 Define only if USE_LUCID.
6620
ac64929e
PE
6621 * xrdb.c (x_customization_string, x_rm_string): Now static.
6622
6f37259d
PE
6623 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6624 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6625
1683e3ab
PE
6626 * xdisp.c (draw_row_with_mouse_face): Now static.
6627 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6628
de9c2632
PE
6629 * window.h (check_all_windows): Mark externally visible.
6630
2b96acb7
PE
6631 * window.c (window_deletion_count): Now static.
6632
6633 * undo.c: Make symbols static if they're not exported.
6634 (last_undo_buffer, last_boundary_position, pending_boundary):
6635 Now static.
6636
50436f33
PE
6637 * textprop.c (interval_insert_behind_hooks): Now static.
6638 (interval_insert_in_front_hooks): Likewise.
6639
64520e5c
PE
6640 * term.c: Make symbols static if they're not exported.
6641 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6642 (max_frame_lines, tty_set_terminal_modes):
6643 (tty_reset_terminal_modes, tty_turn_off_highlight):
6644 (get_tty_terminal): Now static.
6645 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6646 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6647 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6648 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6649 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6650
1fa53021
PE
6651 * sysdep.c: Make symbols static if they're not exported.
6652 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6653 Now static.
6654 (sigprocmask_set, full_mask): Remove; unused.
6655 (wait_debugging): Mark as visible.
6656 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6657 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6658
d4b43b22
PE
6659 * syntax.c (syntax_temp): Define only if !__GNUC__.
6660
b7c513d0
PE
6661 * sound.c (current_sound_device, current_sound): Now static.
6662
989b29ad
PE
6663 * search.c (searchbufs, searchbuf_head): Now static.
6664
13a55a78
PE
6665 * scroll.c (scroll_cost): Remove; unused.
6666 * dispextern.h (scroll_cost): Remove decl.
6667
de68a1fc
PE
6668 * region-cache.h (pp_cache): Mark as externally visible.
6669
40ccffa6
PE
6670 * process.c: Make symbols static if they're not exported.
6671 (process_tick, update_tick, create_process, chan_process):
6672 (Vprocess_alist, proc_buffered_char, datagram_access):
6673 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6674 (deactivate_process): Mark defn as static, as well as decl.
6675 * lisp.h (create_process): Remove decl.
6676 * process.h (chan_process, Vprocess_alist): Remove decls.
6677
ad64fc97
PE
6678 * print.c: Make symbols static if they're not exported.
6679 (print_depth, new_backquote_output, being_printed, print_buffer):
6680 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6681 (print_interval, print_number_index, initial_stderr_stream):
6682 Now static.
6683 * lisp.h (Fprinc): Remove decl.
6684 (debug_output_compilation_hack): Mark as externally visible.
6685
adddb265
PE
6686 * sysdep.c (croak): Move decl from here to syssignal.h.
6687 * syssignal.h (croak): Put it here, so the API can be checked when
6688 'croak' is called from dissociate_if_controlling_tty.
6689
1717ede2
PE
6690 * minibuf.c: Make symbols static if they're not exported.
6691 (minibuf_save_list, choose_minibuf_frame): Now static.
6692 * lisp.h (choose_minibuf_frame): Remove decl.
6693
fa5fb2bc
PE
6694 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6695
1e3890d1
PE
6696 * lread.c: Make symbols static if they're not exported.
6697 (read_objects, initial_obarray, oblookup_last_bucket_number):
6698 Now static.
6699 (make_symbol): Remove; unused.
6700 * lisp.h (initial_obarray, make_symbol): Remove decls.
6701
8a1414fa
PE
6702 * keyboard.c: Make symbols static if they're not exported.
6703 (single_kboard, recent_keys_index, total_keys, recent_keys):
6704 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6705 (this_single_command_key_start, echoing, last_auto_save):
6706 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6707 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6708 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6709 (Vlispy_mouse_stem, double_click_count):
6710 Now static.
6711 (force_auto_save_soon): Define only if SIGDANGER.
6712 (ignore_mouse_drag_p): Now static if
6713 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6714 (print_help): Remove; unused.
6715 (stop_character, last_timer_event): Mark as externally visible.
6716 * keyboard.h (ignore_mouse_drag_p): Declare only if
6717 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6718 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6719 * lisp.h (echoing): Remove decl.
6720 (force_auto_save_soon): Declare only if SIGDANGER.
6721 * xdisp.c (redisplay_window): Simplify code, to make it more
6722 obvious that ignore_mouse_drag_p is not accessed if !defined
6723 USE_GTK && !defined HAVE_NS.
6724
93ea6e8f
PE
6725 * intervals.c: Make symbols static if they're not exported.
6726 (merge_properties_sticky, merge_interval_right, delete_interval):
6727 Now static.
6728 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6729
77382fcc
PE
6730 * insdel.c: Make symbols static if they're not exported.
6731 However, leave prepare_to_modify_buffer alone. It's never
6732 called from outside this function, but that appears to be a bug.
6733 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6734 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6735 (adjust_after_replace_noundo): Remove; unused.
6736 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6737 (signal_before_change): Remove decls.
77382fcc 6738
9306c32e
PE
6739 * indent.c (val_compute_motion, val_vmotion): Now static.
6740
cd44d2eb
PE
6741 * image.c: Make symbols static if they're not exported.
6742 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6743 if USE_GTK.
6744 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6745 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6746
ad9a7a06
PE
6747 * fringe.c (standard_bitmaps): Now static.
6748 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6749
81626931
PE
6750 * frame.c: Make symbols static if they're not exported.
6751 (x_report_frame_params, make_terminal_frame): Now static.
6752 (get_frame_param): Now static, unless HAVE_NS.
6753 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6754 (x_get_resource_string): Remove; not used.
6755 * frame.h (make_terminal_frame, x_report_frame_params):
6756 (x_get_resource_string); Remove decls.
6757 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6758 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6759
239f9db9
PE
6760 * font.c, fontset.c: Make symbols static if they're not exported.
6761 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6762 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6763 * font.c (font_close_object): Now static.
6764 * font.h (font_close_object): Remove.
6765 * fontset.c (FONTSET_OBJLIST): Remove.
6766 (free_realized_fontset) #if-0 the body, which does nothing.
6767 (face_suitable_for_char_p): #if-0, as it's never called.
6768 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6769 * xfaces.c (face_at_string_position):
6770 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6771 since 0 is always ASCII.
6772
dfcf3579
PE
6773 * fns.c (weak_hash_tables): Now static.
6774
5045092b
PE
6775 * fileio.c: Make symbols static if they're not exported.
6776 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6777 (Vwrite_region_annotation_buffers): Now static.
6778
57a96f5c
PE
6779 * eval.c: Make symbols static if they're not exported.
6780 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6781 * lisp.h (backtrace_list): Remove decl.
6782
35f08c38
PE
6783 * emacs.c: Make symbols static if they're not exported.
6784 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6785 (fatal_error_code, fatal_error_signal_hook, standard_args):
6786 Now static.
6787 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6788 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6789 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6790 * lisp.h (fatal_error_signal_hook): Remove decl.
6791 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6792
f44bd759
PE
6793 * editfns.c: Move a (normally-unused) function to its only use.
6794 * editfns.c, lisp.h (get_operating_system_release): Remove.
6795 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6796 worth the hassle of breaking this out.
6797
b532497d
PE
6798 * xterm.c: Make symbols static if they're not exported.
6799 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6800 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6801 (x_destroy_window, x_delete_display):
6802 Now static.
6803 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6804 (x_mouse_leave): Remove; unused.
6805 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6806 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6807 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6808 Remove decls.
6809 (x_mouse_leave): Declare only if WINDOWSNT.
6810 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6811 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6812 USE_X_TOOLKIT.
6813
1675728f
PE
6814 * ftxfont.c: Make symbols static if they're not exported.
6815 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6816 HAVE_FREETYPE.
6817 * font.h (ftxfont_driver): Likewise.
6818
e4cebfca
PE
6819 * xfns.c: Make symbols static if they're not exported.
6820 (x_last_font_name, x_display_info_for_name):
6821 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6822 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6823 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6824 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6825 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6826 (last_show_tip_args): Now static.
6827 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6828 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6829 (x_screen_planes): Remove; unused.
6830 * dispextern.h (x_screen_planes): Remove decl.
6831
5bf46f05
PE
6832 * dispnew.c: Make symbols static if they're not exported.
6833 * dispextern.h (redraw_garbaged_frames, scrolling):
6834 (increment_row_positions): Remove.
6835 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6836 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6837 Now static.
6838 (redraw_garbaged_frames): Remove; unused.
6839
435f4c28
PE
6840 * xfaces.c: Make symbols static if they're not exported.
6841 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6842 Remove decls.
6843 * xterm.h (defined_color): Remove decls.
6844 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6845 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6846 (menu_face_changed_default, defined_color, free_realized_face):
6847 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6848 (ascii_face_of_lisp_face): Remove; unused.
6849
8524aef3
PE
6850 * xdisp.c: Make symbols static if they're not exported.
6851 * dispextern.h (scratch_glyph_row, window_box_edges):
6852 (glyph_to_pixel_coords, set_cursor_from_row):
6853 (get_next_display_element, set_iterator_to_next):
6854 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6855 (show_mouse_face): Remove decls
6856 * frame.h (message_buf_print): Likewise.
6857 * lisp.h (pop_message, set_message, check_point_in_composition):
6858 Likewise.
6859 * xterm.h (set_vertical_scroll_bar): Likewise.
6860 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6861 (message_buf_print, scratch_glyph_row, displayed_buffer):
6862 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6863 (get_next_display_element, show_mouse_face, window_box_edges):
6864 (frame_to_window_pixel_xy, check_point_in_composition):
6865 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6866 (glyph_to_pixel_coords): Remove; unused.
6867
16390cd2
PE
6868 * dired.c (file_name_completion): Now static.
6869
6870 * dbusbind.c (xd_in_read_queued_messages): Now static.
6871
a25f4dfa
PE
6872 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6873 * data.c (circular_list_error): Remove.
6874
14a9c8df
PE
6875 * commands.h (last_point_position, last_point_position_buffer):
6876 (last_point_position_window): Remove decls.
6877 * keyboard.c: Make these variables static.
6878
04f2d78b
CB
6879 * coding.h (coding, code_convert_region, encode_coding_gap):
6880 Remove decls.
74ab6df5
PE
6881 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6882 (iso_code_class, detect_coding, code_convert_region): Now static.
6883 (encode_coding_gap): Remove; unused.
6884
38dfbee1
PE
6885 * chartab.c (chartab_chars, chartab_bits): Now static.
6886
a2cb4e63
PE
6887 * charset.h (charset_iso_8859_1): Remove decl.
6888 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6889 Now static.
6890
127198fd
PE
6891 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6892 * ccl.c (Vccl_program_table): Now static.
6893 (check_ccl_update): Remove; unused.
6894
d85b608f
PE
6895 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6896 * category.h: ... from here.
6897 * category.c (check_category_table, set_category_set): Now static.
6898
31cd66f3
PE
6899 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6900 * lisp.h: Remove these decls.
6901
c358e587
PE
6902 * buffer.c (buffer_count): Remove unused var.
6903
e78aecca
PE
6904 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6905 so that it's not optimized away.
6906 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6907 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6908 exported only to the debugger.
6909
e192d7d3 6910 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6911 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6912
92470028
PE
6913 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6914 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6915 was inaccessible from Lisp.
6916 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6917 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6918
244ed907
PE
6919 alloc.c: Import and export fewer symbols, and remove unused items.
6920 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6921 is defined.
6922 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6923 it's not optimized away by whole-program optimization.
6924 (message_enable_multibyte, free_misc): Remove.
6925 (catchlist, handlerlist, mark_backtrace):
6926 Declare only if BYTE_MARK_STACK.
6927 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6928 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6929 (message_enable_multibyte): Remove decl.
6930 (free_misc, interval_free_list, float_block, float_block_index):
6931 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6932 (cons_free_list, last_marked_index):
6933 Now static.
6934 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6935 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6936 (mark_backtrace): Define only if BYTE_MARK_STACK.
6937 * xdisp.c (message_enable_multibyte): Now static.
6938
61c2b50e 6939 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6940 This makes it easier for human readers (and static analyzers)
6941 to see whether these variables are used from other modules.
6942 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6943 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6944 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6945 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6946 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6947 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6948 * xmenu.c, xselect.c:
6949 Declare Q* vars static if they are not used in other modules.
6950 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6951 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6952 Remove decls of unexported vars.
6953 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6954
95c82688
PE
6955 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6956
16a97296
PE
6957 Make Emacs functions such as Fatom 'static' by default.
6958 This makes it easier for human readers (and static analyzers)
6959 to see whether these functions can be called from other modules.
6960 DEFUN now defines a static function. To make the function external
6961 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6962 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6963 (Finit_image_library):
16a97296
PE
6964 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6965 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6966 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6967 Remove decls, since these functions are now static.
6968 (Funintern, Fget_internal_run_time): New decls, since these functions
6969 were already external.
95c82688 6970
16a97296
PE
6971 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6972 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6973 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6974 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6975 * keyboard.c, keymap.c, lread.c:
6976 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6977 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6978 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6979 Mark functions with DEFUE instead of DEFUN,
6980 if they are used in other modules.
6981 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6982 decls for now-static functions.
6983 * buffer.h (Fdelete_overlay): Remove decl.
6984 * callproc.c (Fgetenv_internal): Mark as internal.
6985 * composite.c (Fremove_list_of_text_properties): Remove decl.
6986 (Fcomposition_get_gstring): New forward static decl.
6987 * composite.h (Fcomposite_get_gstring): Remove decl.
6988 * dired.c (Ffile_attributes): New forward static decl.
6989 * doc.c (Fdocumntation_property): New forward static decl.
6990 * eval.c (Ffetch_bytecode): New forward static decl.
6991 (Funintern): Remove extern decl; now in .h file where it belongs.
6992 * fileio.c (Fmake_symbolic_link): New forward static decl.
6993 * image.c (Finit_image_library): New forward static decl.
6994 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6995 * intervals.h (Fprevious_property_change):
6996 (Fremove_list_of_text_properties): Remove decls.
6997 * keyboard.c (Fthis_command_keys): Remove decl.
6998 (Fcommand_execute): New forward static decl.
6999 * keymap.c (Flookup_key): New forward static decl.
7000 (Fcopy_keymap): Now static.
7001 * keymap.h (Flookup_key): Remove decl.
7002 * process.c (Fget_process): New forward static decl.
7003 (Fprocess_datagram_address): Mark as internal.
7004 * syntax.c (Fsyntax_table_p): New forward static decl.
7005 (skip_chars): Remove duplicate decl.
7006 * textprop.c (Fprevious_property_change): New forward static decl.
7007 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7008 Now internal.
7009 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7010 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7011
785bbd42
PE
7012 * editfns.c (Fformat): Remove unreachable code.
7013
8b913b57
AS
70142011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7015
7016 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7017 change. (Bug#8496)
7018
a6744a35
EZ
70192011-04-13 Eli Zaretskii <eliz@gnu.org>
7020
7021 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7022 when at ZV. (Bug#8487)
7023
e7974947
AS
70242011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7025
baad03f0
AS
7026 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7027 (Bug#8437)
7028 * keyboard.c (parse_tool_bar_item): Likewise.
7029 * sound.c (sound_cleanup, alsa_close): Likewise.
7030 * termcap.c (tgetent): Likewise.
7031 * xfns.c (x_default_font_parameter): Likewise.
7032 * xsettings.c (read_and_apply_settings): Likewise.
7033
e7974947
AS
7034 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7035 (overrun_check_free): Protoize.
7036
28272684
PE
70372011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7038
7039 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7040 since callers should never pass a negative size.
7041 Change the signature to match that of plain 'read' and 'write'; see
7042 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7043 * lisp.h: Update prototypes of emacs_write and emacs_read.
7044
11997c76
EZ
70452011-04-11 Eli Zaretskii <eliz@gnu.org>
7046
7047 * xdisp.c (redisplay_window): Don't try to determine the character
7048 position of the scroll margin if the window start point w->startp
e896f03c 7049 is outside the buffer's accessible region. (Bug#8468)
11997c76 7050
8a2cbd72
EZ
70512011-04-10 Eli Zaretskii <eliz@gnu.org>
7052
7053 Fix write-region and its subroutines for buffers > 2GB.
7054 * fileio.c (a_write, e_write): Modify declaration of arguments and
7055 local variables to support buffers larger than 2GB.
7056 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7057
7058 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7059 argument, local variables, and return value.
7060
7061 * lisp.h: Update prototypes of emacs_write and emacs_read.
7062
7063 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7064
4073e537 70652011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7066
1ebfdcb6
PE
7067 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7068
b2ded58d
PE
7069 Fix more problems found by GCC 4.6.0's static checks.
7070
7d66342c
PE
7071 * xdisp.c (vmessage): Use a better test for character truncation.
7072
bbf47d44
PE
7073 * charset.c (load_charset_map): <, not <=, for optimization,
7074 and to avoid potential problems with integer overflow.
9248994d 7075 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7076 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7077 * editfns.c (Fformat): Likewise.
1e69125e 7078 * syntax.c (skip_chars): Likewise.
3befa583 7079
e3019616
PE
7080 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7081 This also lets GCC 4.6.0 generate slightly better loop code.
7082
becfa255
PE
7083 * callint.c (Fcall_interactively): <, not <=, for optimization.
7084 (Fcall_interactively): Count the number of arguments produced,
7085 not the number of arguments given. This is simpler and lets GCC
7086 4.6.0 generate slightly better code.
7087
dae0cd48
PE
7088 * ftfont.c: Distingish more carefully between FcChar8 and char.
7089 The previous code passed unsigned char * to a functions like
7090 strlen and xstrcasecmp that expect char *, which does not
7091 conform to the C standard.
7092 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7093 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7094 char * when the C standard requires it.
7095
76032d70
PE
7096 * keyboard.c (read_char): Remove unused var.
7097
eb3f1cc8
PE
7098 * eval.c: Port to Windows vsnprintf (Bug#8435).
7099 Include <limits.h>.
7100 (SIZE_MAX): Define if the headers do not.
7101 (verror): Do not give up if vsnprintf returns a negative count.
7102 Instead, grow the buffer. This ports to Windows vsnprintf, which
7103 does not conform to C99. Problem reported by Eli Zaretskii.
7104 Also, simplify the allocation scheme, by avoiding the need for
7105 calling realloc, and removing the ALLOCATED variable.
7106
70476b54
PE
7107 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7108
12020a9e
PE
7109 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7110 But keep the doprint source code for now, as we might revamp it
7111 and use it again (Bug#8435).
ea6c7ae6
PE
7112 * lisp.h (doprnt): Remove.
7113 * Makefile.in (base_obj): Remove doprnt.o.
7114 * deps.mk (doprnt.o): Remove.
7115
5fdb398c
PE
7116 error: Print 32- and 64-bit integers portably (Bug#8435).
7117 Without this change, on typical 64-bit hosts error ("...%d...", N)
7118 was used to print both 32- and 64-bit integers N, which relied on
7119 undefined behavior.
7120 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7121 New macro.
7122 * lisp.h (error, verror): Mark as printf-like functions.
7123 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7124 Report overflow in size calculations when allocating printf buffer.
7125 Do not truncate output string at its first null byte.
7126 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7127 Truncate the output at a character boundary, since vsnprintf does not
7128 do that.
7129 * charset.c (check_iso_charset_parameter): Convert internal
7130 character to string before calling 'error', since %c now has the
7131 printf meaning.
7132 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7133 overflow when computing char to be passed to 'error'. Do not
7134 pass Lisp_Object to 'error'; pass the integer instead.
7135 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7136 formatted with plain %d.
7137
b189fa66
PE
7138 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7139
bff87ef0
PE
7140 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7141
7e2cac20
PE
7142 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7143
ce4d90b5
PE
7144 * xterm.c (x_catch_errors): Remove duplicate declaration.
7145
266c9547
PE
7146 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7147
79c49ad2
PE
7148 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7149
368f4090
JM
71502011-04-10 Jim Meyering <meyering@redhat.com>
7151
7152 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7153 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7154 return ssize_t not "int", and use size_t as the buffer length.
7155 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7156 * gnutls.h: Update declarations.
7157 * process.c (read_process_output): Use ssize_t, to match.
7158 (send_process): Likewise.
7159
a32d4040
CY
71602011-04-09 Chong Yidong <cyd@stupidchicken.com>
7161
7162 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7163
8546720e 71642011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7165
04f2d78b
CB
7166 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7167 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7168
8546720e
GM
7169 * xterm.c (handle_one_xevent):
7170 * xmenu.c (create_and_show_popup_menu):
7171 * xselect.c (x_decline_selection_request)
7172 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7173
0a2f5c1a 71742011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7175
7176 Fix some uses of `int' instead of EMACS_INT.
7177 * search.c (string_match_1, fast_string_match)
7178 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7179 (scan_buffer, find_next_newline_no_quit)
7180 (find_before_next_newline, search_command, Freplace_match)
7181 (Fmatch_data): Make some `int' variables be EMACS_INT.
7182
7183 * xdisp.c (display_count_lines): 3rd argument and return value now
7184 EMACS_INT. All callers changed.
7185 (pint2hrstr): Last argument is now EMACS_INT.
7186
7187 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7188 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7189 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7190 (decode_coding_utf_16, decode_coding_emacs_mule)
7191 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7192 (decode_coding_ccl, decode_coding_charset)
7193 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7194 (decode_coding_iso_2022, decode_coding_emacs_mule)
7195 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7196 <char_offset, last_offset>: Declare EMACS_INT.
7197 (encode_coding_utf_8, encode_coding_utf_16)
7198 (encode_coding_emacs_mule, encode_invocation_designation)
7199 (encode_designation_at_bol, encode_coding_iso_2022)
7200 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7201 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7202 Declare EMACS_INT.
7203 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7204 (encode_invocation_designation): Last argument P_NCHARS is now
7205 EMACS_INT.
7206 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7207 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7208
7209 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7210 All users changed.
7211
7212 * ccl.c (Fccl_execute_on_string): Declare some variables
7213 EMACS_INT.
7214
8546720e 72152011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7216
7217 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7218
4e19a977
CS
72192011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7220
7221 * process.c (Fformat_network_address): Doc fix.
7222
87302331
R
72232011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7224
ee7683eb 7225 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7226
cbb59342
CY
72272011-04-08 Chong Yidong <cyd@stupidchicken.com>
7228
7229 * keyboard.c (read_char): Call Lisp function help-form-show,
7230 instead of using internal_with_output_to_temp_buffer.
7231 (Qhelp_form_show): New var.
e0d38eeb 7232 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7233
7234 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7235
7236 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7237
e67a13ab
CY
72382011-04-06 Chong Yidong <cyd@stupidchicken.com>
7239
04f2d78b
CB
7240 * process.c (Flist_processes): Remove to Lisp.
7241 (list_processes_1): Delete.
e67a13ab 7242
973f782d
EZ
72432011-04-06 Eli Zaretskii <eliz@gnu.org>
7244
7c106b1e
EZ
7245 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7246
973f782d
EZ
7247 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7248
41cf7d1a 72492011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7250
ca23cc88
PE
7251 Fix more problems found by GCC 4.6.0's static checks.
7252
f390e2d5
PE
7253 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7254
42eea0d0
PE
7255 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7256
b69769da 7257 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7258
f9541e84
PE
7259 * xdisp.c (vmessage): Mark as a printf-like function.
7260
13841b55
PE
7261 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7262
c136c10f
PE
7263 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7264
5e2d4a30
PE
7265 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7266 printf-like functions.
7267 (tiff_load): Add casts to remove these marks before passing them
7268 to system-supplied API.
7269
583f48b9
PE
7270 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7271
b25d760e
PE
7272 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7273 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7274 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7275 directly, rather than having caller test rule sign. This avoids
7276 some unnecessary tests.
7277 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7278 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7279 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7280
bc7b6697 7281 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7282 (xfont_open): Avoid unnecessary tests.
bc7b6697 7283
27ccc379
PE
7284 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7285
dcd5c89a
PE
7286 * composite.h, composite.c (composition_gstring_put_cache):
7287 Use EMACS_INT, not int, for length.
7288
b13a45c6
PE
7289 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7290 breaking out part of COMPOSITION_DECODE_RULE.
7291 (COMPOSITION_DECODE_RULE): Use it.
7292 * composite.c (get_composition_id): Remove unused local vars,
7293 by using the new macro.
7294
1e792e4d
PE
7295 * textprop.c (set_text_properties_1): Change while to do-while,
7296 since the condition is always true at first.
7297
dc6c6455 7298 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7299 (interval_deletion_adjustment): Return unsigned value.
7300 All uses changed.
dc6c6455 7301
aba7731a
PE
7302 * process.c (list_processes_1, create_pty, read_process_output):
7303 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7304 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7305 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7306 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7307 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7308
fdfc4bf3
PE
7309 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7310
fca8fe46 7311 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7312 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7313
06a0259a 7314 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7315 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7316 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7317
e7b9e80f
PE
7318 * print.c (print_error_message): Avoid int overflow.
7319
56201685
PE
7320 * font.c (font_list_entities): Redo for clarity,
7321 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7322
78834453 7323 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7324 (font_score): Avoid potential overflow in diff calculation.
78834453 7325
0bc0b309 7326 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7327 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7328
e610eaca
PE
7329 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7330
b895abce
PE
7331 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7332 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7333 can always succeed if overflow has undefined behavior.
7334
1f1d9321 7335 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7336 (wordify): Omit three unnecessary tests.
1f1d9321 7337
c59478bc
PE
7338 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7339 All callers changed. This avoids the need for an unused var.
7340
79b73827
PE
7341 * casefiddle.c (casify_region): Remove var that is set but not used.
7342
a4db5dfe
PE
7343 * dired.c (file_name_completion): Remove var that is set but not used.
7344
43aae36e
PE
7345 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7346
2a47c44d 7347 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7348 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7349
a37c69bf
PE
7350 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7351 Check for integer overflow on size calculations.
7352
328ab8e7
PE
7353 * buffer.c (Fprevious_overlay_change): Remove var that is set
7354 but not used.
7355
e5a2a5cb
PE
7356 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7357 Remove vars that are set but not used.
8d84a6eb 7358 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7359 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7360
a60e5f68
PE
7361 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7362
f661cb61 7363 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7364 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7365
f0397f5a
PE
7366 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7367 that are set but not used.
7368
8664db06 7369 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7370 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7371
6abdaa4a
PE
7372 * xselect.c (x_get_local_selection, x_handle_property_notify):
7373 Remove vars that are set but not used.
7374
0ce7538d 7375 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7376 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7377
9ae848fc
PE
7378 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7379 Remove var that is set but not used.
0b918413
PE
7380 (scroll_bar_windows_size): Now size_t, not int.
7381 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7382 Check for overflow.
9ae848fc 7383
a5a62657
PE
7384 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7385 (map_tty_color) [!defined MSDOS]: Likewise.
7386
5c5cdd39
PE
7387 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7388
66ebf983
PE
7389 * coding.c: Remove vars that are set but not used.
7390 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7391 All callers changed.
7392 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7393 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7394 (decode_coding_charset): Remove vars that are set but not used.
7395
1be4d761
PE
7396 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7397 that is set but not used.
7398
47553fa8
PE
7399 * print.c (print_object): Remove var that is set but not used.
7400
1f7196bf 7401 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7402 The gnulib version avoids calling malloc in the usual case,
7403 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7404 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7405 * filelock.c (current_lock_owner): Likewise.
7406 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7407 * sysdep.c: Include allocator.h, careadlinkat.h.
7408 (emacs_no_realloc_allocator): New static constant.
7409 (emacs_readlink): New function.
fdb61804
PE
7410 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7411 ../lib/careadlinkat.h.
d1fdcab7 7412
f84c17c7
SM
74132011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7414
7415 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7416 first non-nil return value).
7417
ef3862ad
JD
74182011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7419
7420 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7421 if not defined (Bug#8403).
7422
376a7006
JB
74232011-04-02 Juanma Barranquero <lekktu@gmail.com>
7424
7425 * xdisp.c (display_count_lines): Remove parameter `start',
7426 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7427 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7428 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7429 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7430 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7431 and thereabouts. All callers changed.
7432 (get_per_char_metric): Remove parameter `f', unused since
7433 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7434
6ca3801d
JM
74352011-04-02 Jim Meyering <meyering@redhat.com>
7436
7437 do not dereference NULL upon failed strdup
7438 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7439 (ns_get_family): Likewise.
7440
d8e2b5ba
JB
74412011-04-02 Juanma Barranquero <lekktu@gmail.com>
7442
7443 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7444
8c74fcbd
JD
74452011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7446
7447 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7448 later (Bug#8403).
7449
7200d79c
SM
74502011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7451
03408648 7452 Add lexical binding.
7200d79c 7453
03408648
SM
7454 * window.c (Ftemp_output_buffer_show): New fun.
7455 (Fsave_window_excursion):
7456 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7457
7458 * lread.c (lisp_file_lexically_bound_p): New function.
7459 (Fload): Bind Qlexical_binding.
7460 (readevalloop): Remove `evalfun' arg.
7461 Bind Qinternal_interpreter_environment.
7462 (Feval_buffer): Bind Qlexical_binding.
7463 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7464 Mark as dynamic.
7465 (syms_of_lread): Declare `lexical-binding'.
7466
7467 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7468
7469 * keyboard.c (eval_dyn): New fun.
7470 (menu_item_eval_property): Use it.
ca105506
SM
7471
7472 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7473
03408648
SM
7474 * fns.c (concat, mapcar1): Accept byte-code-functions.
7475
7476 * eval.c (Fsetq): Handle lexical vars.
7477 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7478 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7479 (FletX, Flet): Obey lexical binding.
7480 (Fcommandp): Handle closures.
7481 (Feval): New `lexical' arg.
7482 (eval_sub): New function extracted from Feval. Use it almost
7483 everywhere where Feval was used. Look up vars in lexical env.
7484 Handle closures.
7485 (Ffunctionp): Move from subr.el.
7486 (Ffuncall): Handle closures.
7487 (apply_lambda): Remove `eval_flags'.
7488 (funcall_lambda): Handle closures and new byte-code-functions.
7489 (Fspecial_variable_p): New function.
7490 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7491 but without exporting it to Lisp.
23aba0ea 7492
23aba0ea 7493 * doc.c (Fdocumentation, store_function_docstring):
03408648 7494 * data.c (Finteractive_form): Handle closures.
23aba0ea 7495
03408648
SM
7496 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7497 interactive spec.
ba83908c 7498
04f2d78b
CB
7499 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7500 New byte-codes.
03408648
SM
7501 (exec_byte_code): New function extracted from Fbyte_code to handle new
7502 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7503
03408648 7504 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7505
03408648 7506 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7507
e2abce01
JB
75082011-03-31 Juanma Barranquero <lekktu@gmail.com>
7509
7510 * xdisp.c (redisplay_internal): Fix prototype.
7511
63696a73 75122011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7513
63696a73 7514 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7515 (try_scrolling): Use it when setting scroll_limit.
7516 Limit scrolling to 100 screen lines.
63696a73
EZ
7517 (redisplay_window): Even when falling back on "recentering",
7518 position point in the window according to scroll-conservatively,
7519 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7520
7521 (try_scrolling): When point is above the window, allow searching
7522 as far as scroll_max, or one screenful, to compute vertical
7523 distance from PT to the scroll margin position. This prevents
7524 try_scrolling from unnecessarily failing when
7525 scroll-conservatively is set to a value slightly larger than the
7526 window height. Clean up the case of PT below the margin at bottom
7527 of window: scroll_max can no longer be INT_MAX. When aggressive
7528 scrolling is in use, don't let point enter the opposite scroll
7529 margin as result of the scroll.
7530 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7531 threshold of 100 lines for never-recentering scrolling.
7532
e4cc2dfc
JB
75332011-03-31 Juanma Barranquero <lekktu@gmail.com>
7534
7535 * dispextern.h (move_it_by_lines):
7536 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7537 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7538 (message_log_check_duplicate): Remove parameters `prev_bol' and
7539 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7540 (redisplay_internal): Remove parameter `preserve_echo_area',
7541 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7542
7543 * indent.c (Fvertical_motion):
7544 * window.c (window_scroll_pixel_based, Frecenter):
7545 Don't pass `need_y_p' to `move_it_by_lines'.
7546
1c470562
SM
75472011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7548
44f230aa
SM
7549 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7550 steal a few bits to be more compact.
7551 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7552 Remove unneeded casts.
7553
1c470562
SM
7554 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7555
888adce9
ZK
75562011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7557
7558 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7559 binding" message (bug#7967).
7560
f838ed7b
PE
75612011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7562
77861b95
PE
7563 Fix more problems found by GCC 4.6.0's static checks.
7564
de6dbc14
PE
7565 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7566 Remove unused local var.
7567
f838ed7b
PE
7568 * editfns.c (Fmessage_box): Remove unused local var.
7569
792c7b2b
PE
7570 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7571 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7572 Omit unused local vars.
c499e557 7573 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7574 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7575 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7576 Omit unused local var.
7577
ba0165e1
PE
7578 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7579 Don't assume string length fits in int.
32ad8845 7580 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7581 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7582
3c59b4c9
PE
7583 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7584 instead of alloca (Bug#8344).
7585
a3eed478 7586 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7587 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7588
eb4d412d
PE
7589 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7590
1658b401
PE
7591 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7592 concerns.
7593
7594 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7595
7596 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7597
9a2c6e05
PE
7598 * keyboard.c (syms_of_keyboard): Use the same style as later
7599 in this function when indexing through an array. This also
7600 works around GCC bug 48267.
7601
03d0a109
PE
7602 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7603
44f730c8
PE
7604 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7605
fe75f926
PE
7606 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7607 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7608
ffa8c828
PE
7609 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7610 This avoids undefined behavior on integer overflow, and is a bit
7611 more convenient anyway since it is compared to a size_t variable.
7612
c5101a77
PE
7613 Variadic C functions now count arguments with size_t, not int.
7614 This avoids an unnecessary limitation on 64-bit machines, which
7615 caused (substring ...) to crash on large vectors (Bug#8344).
7616 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7617 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7618 All variadic functions and their callers changed accordingly.
c5101a77
PE
7619 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7620 * data.c (arith_driver, float_arith_driver): Likewise.
7621 * editfns.c (general_insert_function): Likewise.
7622 * eval.c (struct backtrace.nargs, interactive_p)
7623 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7624 (funcall_lambda, mark_backtrace): Likewise.
7625 * fns.c (concat): Likewise.
7626 * frame.c (x_set_frame_parameters): Likewise.
7627 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7628 0 if not found, not -1. All callers changed.
7629
dd3f25f7
PE
7630 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7631 (stack_copy_size): Now size_t, not int.
7632 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7633
461c2ab9
JB
76342011-03-28 Juanma Barranquero <lekktu@gmail.com>
7635
7636 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7637 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7638 All callers changed.
7639
7640 * lisp.h (multibyte_char_to_unibyte):
7641 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7642 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7643 * character.h (CHAR_TO_BYTE8):
7644 * cmds.c (internal_self_insert):
7645 * editfns.c (general_insert_function):
7646 * keymap.c (push_key_description):
7647 * search.c (Freplace_match):
7648 * xdisp.c (message_dolog, set_message_1): All callers changed.
7649
f6d62986
SM
76502011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7651
7652 * keyboard.c (safe_run_hook_funcall): New function.
7653 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7654 don't set the hook to nil, but remove the offending function instead.
7655 (Qcommand_hook_internal): Remove, unused.
7656 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7657 Vcommand_hook_internal.
7658
7659 * eval.c (enum run_hooks_condition): Remove.
7660 (funcall_nil, funcall_not): New functions.
7661 (run_hook_with_args): Call each function through a `funcall' argument.
7662 Remove `cond' argument, now redundant.
7663 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7664 (Frun_hook_with_args_until_failure): Adjust accordingly.
7665 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7666
1db5b1ad
JB
76672011-03-28 Juanma Barranquero <lekktu@gmail.com>
7668
7669 * dispextern.h (string_buffer_position): Remove declaration.
7670
7671 * print.c (strout): Remove parameter `multibyte', unused since
7672 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7673
7674 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7675 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7676 All callers changed.
7677
7678 * w32.c (_wsa_errlist): Use braces for struct initializers.
7679
7680 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7681 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7682 All callers changed.
7683 (string_buffer_position): Likewise. Also, make static (it's never
7684 used outside xdisp.c).
7685 (cursor_row_p): Remove parameter `w', unused since
7686 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7687 (decode_mode_spec): Remove parameter `precision', introduced during
7688 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7689 All callers changed.
7690
5ffb62aa
JD
76912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7692
7693 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7694
461c2ab9 76952011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7696
7697 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7698 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7699 (ns_update_auto_hide_menu_bar): New functions.
7700 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7701 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7702 ns_constrain_all_frames.
7703 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7704 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7705
5c380ffb
JD
77062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7707
7708 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7709
9af30bdf
GM
77102011-03-27 Glenn Morris <rgm@gnu.org>
7711
7712 * syssignal.h: Replace RETSIGTYPE with void.
7713 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7714 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7715 Replace SIGTYPE with void everywhere.
7716 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7717 * s/template.h (SIGTYPE): Remove commented out definition.
7718
e2abce01
JB
77192011-03-26 Eli Zaretskii <eliz@gnu.org>
7720
7721 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7722 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7723
f868cd8a
JB
77242011-03-26 Juanma Barranquero <lekktu@gmail.com>
7725
59eb0929
JB
7726 * w32.c (read_unc_volume): Use parameter `henum', instead of
7727 global variable `wget_enum_handle'.
7728
7729 * keymap.c (describe_vector): Remove parameters `indices' and
7730 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7731 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7732
f868cd8a
JB
7733 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7734
7735 * keyboard.c (timer_check): Remove parameter `do_it_now',
7736 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7737 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7738 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7739
7740 * keyboard.c (read_char):
7741 * w32menu.c (w32_menu_display_help):
7742 * xmenu.c (show_help_event, menu_help_callback):
7743 Adjust calls to `show_help_echo'.
7744
7745 * gtkutil.c (xg_maybe_add_timer):
7746 * keyboard.c (readable_events):
7747 * process.c (wait_reading_process_output):
7748 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7749
7750 * insdel.c (adjust_markers_gap_motion):
7751 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7752 (gap_left, gap_right): Don't call it.
7753
2ecf6fdb
CY
77542011-03-25 Chong Yidong <cyd@stupidchicken.com>
7755
7756 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7757 incurred during fontification.
7758
6b1f9ba4
JB
77592011-03-25 Juanma Barranquero <lekktu@gmail.com>
7760
7761 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7762 (DEFVAR_PER_BUFFER): Don't pass it.
7763
7764 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7765 (scrolling_window): Don't pass it.
7766
0f4a96b5
JB
77672011-03-25 Juanma Barranquero <lekktu@gmail.com>
7768
7769 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7770
7771 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7772 and `suffix'.
7773 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7774 of variables specific to SELinux and computation of `encoded_absname'.
7775
7776 * image.c (XPutPixel): Remove unused variable `height'.
7777
7778 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7779
7780 * unexw32.c (get_section_info): Remove unused variable `section'.
7781
7782 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7783 (system_process_attributes): Remove unused variable `sess'.
7784 (sys_read): Remove unused variable `err'.
7785
7786 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7787 (w32_wnd_proc): Remove unused variable `isdead'.
7788 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7789 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7790 (x_create_tip_frame): Remove unused variable `tem'.
7791
7792 * w32inevt.c (w32_console_read_socket):
7793 Remove unused variable `no_events'.
7794
7795 * w32term.c (x_draw_composite_glyph_string_foreground):
7796 Remove unused variable `width'.
7797
1149507c
JB
77982011-03-24 Juanma Barranquero <lekktu@gmail.com>
7799
7800 * w32term.c (x_set_glyph_string_clipping):
7801 Don't pass uninitialized region to CombineRgn.
7802
9c88f339
JB
78032011-03-23 Juanma Barranquero <lekktu@gmail.com>
7804
7805 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7806 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7807 (Fx_close_connection): Remove unused variable `i'.
7808
7809 * w32font.c (w32font_draw): Return number of glyphs.
7810 (w32font_open_internal): Remove unused variable `i'.
7811 (w32font_driver): Add missing initializer.
7812
7813 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7814 (fill_in_menu): Remove unused variable `items_added'.
7815
7816 * w32term.c (last_mouse_press_frame): Remove static global variable.
7817 (w32_clip_to_row): Remove unused variable `f'.
7818 (x_delete_terminal): Remove unused variable `i'.
7819
7820 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7821 (NOTHING): Remove unused static global variable.
7822 (uniscribe_check_otf): Remove unused variable `table'.
7823 (uniscribe_font_driver): Add missing initializers.
7824
dee091a3
JD
78252011-03-23 Julien Danjou <julien@danjou.info>
7826
7827 * term.c (Fsuspend_tty, Fresume_tty):
7828 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7829 * window.c (temp_output_buffer_show):
7830 * insdel.c (signal_before_change):
7831 * frame.c (Fhandle_switch_frame):
7832 * fileio.c (Fdo_auto_save):
7833 * emacs.c (Fkill_emacs):
7834 * editfns.c (save_excursion_restore):
7835 * cmds.c (internal_self_insert):
7836 * callint.c (Fcall_interactively):
7837 * buffer.c (Fkill_all_local_variables):
7838 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7839 Use Frun_hooks.
0f4a96b5 7840 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7841 unconditionally since it does the check itself.
dee091a3 7842
2c520ab5 78432011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7844
c9c49752
PE
7845 Fix more problems found by GCC 4.5.2's static checks.
7846
8abc3f12
PE
7847 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7848 the first time through the loop, since we know p0 < p1 then.
7849 This also avoids a gcc -Wstrict-overflow warning.
7850
a2d26660
PE
7851 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7852 leading to a memory leak, possible in functions like
7853 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7854 of objects (Bug#8318).
a2d26660 7855
916c72e9
PE
7856 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7857 that could (at least in theory) be that large.
7858
19ab8a18
PE
7859 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7860 This is less likely to overflow, and avoids undefined behavior if
7861 overflow does occur. All callers changed. Use strtoul to scan
7862 for the unsigned long integer.
b7cbbd6f
PE
7863 (pint2hrstr): Simplify and tune code slightly.
7864 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7865
f0641eff
PE
7866 * scroll.c (do_scrolling): Work around GCC bug 48228.
7867 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7868
7f650bb9
PE
7869 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7870 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7871 (validate_x_resource_name): Simplify count usage.
7872 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7873
37dd57d1
PE
7874 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7875 fail (Bug#8306).
81e56e61 7876
699979fc 7877 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7878
401bf9b4
PE
7879 * process.c (Fmake_network_process): Use socklen_t, not int,
7880 where POSIX says socklen_t is required in portable programs.
7881 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7882 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7883 (Fmake_network_process, server_accept_connection):
7884 (wait_reading_process_output, read_process_output):
7885 Likewise.
7886
b93aacde
PE
7887 * process.c: Rename or move locals to avoid shadowing.
7888 (list_processes_1, Fmake_network_process):
7889 (read_process_output_error_handler, exec_sentinel_error_handler):
7890 Rename or move locals.
4dc343ee 7891 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7892 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7893 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7894 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7895 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7896
af8a867c 7897 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7898 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7899 Include tparam.h instead, since it declares them.
af8a867c
PE
7900 * cm.h (PC): Remove extern decl; tparam.h now does this.
7901 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7902 * terminfo.c: Include tparam.h, to check interfaces.
7903 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7904 (tparam): Adjust signature to match interface in tparam.h;
7905 this removes some undefined behavior. Check that outstring and len
7906 are zero, which they always are with Emacs.
7907 * tparam.h (PC, BC, UP): New extern decls.
7908
0248044d 7909 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7910 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7911
8ff096c1 7912 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7913 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7914 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7915 (ftfont_list): Remove unused local.
49eaafba
PE
7916 (get_adstyle_property, ftfont_pattern_entity):
7917 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7918 Rename locals to avoid shadowing.
8ff096c1 7919
e2be39f6
PE
7920 * xfont.c (xfont_list_family): Mark var as initialized.
7921
c9735e30
PE
7922 * xml.c (make_dom): Now static.
7923
8f5201ae
PE
7924 * composite.c (composition_compute_stop_pos): Rename local to
7925 avoid shadowing.
b246f932
PE
7926 (composition_reseat_it): Remove unused locals.
7927 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7928 (composition_update_it): Mark var as initialized.
11b61122
PE
7929 (find_automatic_composition): Mark vars as initialized,
7930 with a FIXME (Bug#8290).
8f5201ae 7931
760fbc2c
PE
7932 character.h: Rename locals to avoid shadowing.
7933 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7934 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7935 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7936 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7937 to avoid shadowing.
7938
ff08eb85
PE
7939 * textprop.c (property_change_between_p): Remove; unused.
7940
fc7bf025
PE
7941 * intervals.c (interval_start_pos): Now static.
7942
235d7abc
PE
7943 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7944
44f230aa
SM
7945 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7946 Rename locals to avoid shadowing.
3e7d6594 7947
50060332
PE
7948 * sound.c (wav_play, au_play, Fplay_sound_internal):
7949 Fix pointer signedness.
d01f234b 7950 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7951 (wav_play): Initialize a variable to 0, to prevent undefined
7952 behavior (Bug#8278).
50060332 7953
c4fc4e30
PE
7954 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7955
918436ed
PE
7956 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7957
c939f91b
PE
7958 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7959 clobbering (Bug#8298).
b9c7f648
PE
7960 * sysdep.c (sys_subshell): Likewise.
7961 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7962
6bd8c144
PE
7963 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7964 This should get cleaned up, so that child_setup has the
7965 same signature on all platforms.
7966
7710357c 7967 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7968 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7969
c59da222
CY
79702011-03-22 Chong Yidong <cyd@stupidchicken.com>
7971
7972 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7973 not to be necessary, and produces flickering.
7974
66b87493
GM
79752011-03-20 Glenn Morris <rgm@gnu.org>
7976
7977 * config.in: Remove file.
7978
45b6f6d5
JB
79792011-03-20 Juanma Barranquero <lekktu@gmail.com>
7980
7981 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7982 are now in src/globals.h.
7983 (syms_of_minibuf): Remove spurious & from previous change.
7984
3ec03f7e
LL
79852011-03-20 Leo <sdl.web@gmail.com>
7986
7987 * minibuf.c (completing-read-function): New variable.
7988 (completing-read-default): Rename from completing-read.
7989 (completing-read): Call completing-read-function.
7990
b14e3e21
CY
79912011-03-19 Juanma Barranquero <lekktu@gmail.com>
7992
7993 * xfaces.c (Fx_load_color_file):
7994 Read color file from absolute filename (bug#8250).
7995
f2b726e6
JB
79962011-03-19 Juanma Barranquero <lekktu@gmail.com>
7997
7998 * makefile.w32-in: Update dependencies.
7999
09f6ff02
EZ
80002011-03-17 Eli Zaretskii <eliz@gnu.org>
8001
8002 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8003
29a6015a
PE
80042011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8005
a3a6c54e
PE
8006 Fix more problems found by GCC 4.5.2's static checks.
8007
b766f867
PE
8008 * process.c (make_serial_process_unwind, send_process_trap):
8009 (sigchld_handler): Now static.
8010
be02381c
PE
8011 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8012 That way, the code declares only the vars that it needs.
8013 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8014 * s/cygwin.h (PTY_ITERATION): Likewise.
8015 * s/darwin.h (PTY_ITERATION): Likewise.
8016 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8017
57048744
PE
8018 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8019 * process.c (allocate_pty): Don't declare stb unless it's needed.
8020
7914961c 8021 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8022 (CONSTANTLIM): Remove; unused.
8023 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8024 Define only if needed.
7914961c 8025
b3967b18
PE
8026 * unexelf.c (unexec): Name an expression,
8027 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8028 Use a different way to cause a compilation error if anyone uses
8029 n rather than nn, a way that does not involve shadowing.
73366a00 8030 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8031
29a6015a
PE
8032 * deps.mk (unexalpha.o): Remove; unused.
8033
43cfc33e 8034 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8035 * unexec.h: New file.
ce701a33
PE
8036 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8037 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8038 Depend on unexec.h.
8039 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8040 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8041 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8042 Change as necessary to match prototype in unexec.h.
ce701a33 8043
01f44d5a
PE
8044 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8045 shadowing.
4f63c6bb 8046 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8047
a6670b0b
PE
8048 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8049 Rename locals to avoid shadowing.
8050
cef2010d 8051 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8052 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8053
d4d7173a
PE
8054 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8055
f08b802a
PE
8056 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8057 warning when compiling print.c.
8058
3ddb0639
PE
8059 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8060 instead of using an uninitialized var.
5ad03b97 8061 (font_sort_entities): Mark var as initialized.
3ddb0639 8062
170a2692
PE
8063 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8064
e663c700
PE
8065 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8066 pointers to constants.
89bc529a 8067 (font_parse_fcname): Remove unused vars.
7b81e2d0 8068 (font_delete_unmatched): Now static.
ea838e10 8069 (font_get_spec): Remove; unused.
13a547c6
PE
8070 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8071 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8072 Rename or move locals to avoid shadowing.
e663c700 8073
2a80c887 8074 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8075 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8076
1384fa33 8077 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8078 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8079
8b2c52e9
PE
8080 * alloc.c (mark_backtrace): Move decl from here ...
8081 * lisp.h: ... to here, so that it can be checked.
8082
475545b5 8083 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8084 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8085 (lisp_indirect_variable): Name an expression,
8086 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8087 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8088
b1349114 8089 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8090 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8091 Use const pointer when appropriate.
b1349114 8092
a2928364
PE
8093 * lisp.h (get_system_name, get_operating_system_release):
8094 Move decls here, to check interfaces.
8095 * process.c (get_operating_system_release): Move decl to lisp.h.
8096 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8097 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8098 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8099 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8100 (Fformat_time_string, Fencode_time, Finsert_char):
8101 (Ftranslate_region_internal, Fformat):
8102 Rename or remove local vars to avoid shadowing.
9710023e 8103 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8104
a415e694
PE
8105 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8106 avoid shadowing.
8107
8ef4622d
PE
8108 * lisp.h (eassert): Check that the argument compiles, even if
8109 ENABLE_CHECKING is not defined.
8110
946f9a5b
PE
8111 * data.c (Findirect_variable): Name an expression, to avoid
8112 gcc -Wbad-function-cast warning.
112396d6 8113 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8114 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8115 (Fmake_variable_buffer_local, Fmake_local_variable):
8116 Mark variables as initialized.
52746918 8117 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8118
e5aab7e7 8119 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8120 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8121 Rename locals to avoid shadowing.
dff45157
PE
8122 (mark_stack): Move local variables into the #ifdef region where
8123 they're used.
7bc26fdb
PE
8124 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8125 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8126 needed otherwise.
8127 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8128 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8129 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8130
e5aab7e7
PE
8131 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8132 avoids undefined behavior in theory.
8133
4da60324
PE
8134 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8135
88043301
PE
8136 Use functions, not macros, for up- and down-casing (Bug#8254).
8137 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8138 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8139 to use the following functions instead of these macros.
8140 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8141 EMACS_INT, since callers assume the returned value fits in int.
8142 (upcase1): Likewise, for UPCASE_TABLE.
8143 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8144 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8145 the race-condition problem in the old DOWNCASE.
88043301 8146
19ed5445
PE
8147 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8148 Rename locals to avoid shadowing.
8149 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8150 (regex_compile, re_search_2, re_match_2_internal):
8151 Remove unused local vars.
952db0d7
PE
8152 (FREE_VAR): Rewrite so as not to use empty "else",
8153 which gcc can warn about.
da053e48 8154 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8155 (RETALLOC_IF): Define only if needed.
8156 (WORDCHAR_P): Likewise. This one is never needed, but is used
8157 only in a comment talking about a compiler bug, so put inside
8158 the #if 0 of that comment.
8159 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8160 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8161 Remove; unused.
19ed5445 8162
1f3561e4 8163 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8164 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8165 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8166
ded6f8f7
PE
8167 * search.c (simple_search): Remove unused var.
8168
dbd37a95
PE
8169 * dired.c (compile_pattern): Move decl from here ...
8170 * lisp.h: ... to here, so that it can be checked.
8171 (struct re_registers): New forward decl.
8172
7e47afad
PE
8173 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8174
85f24f61
PE
8175 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8176 All uses changed.
8177 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8178 Rename locals to avoid shadowing.
5671df8f 8179 (Fvertical_motion): Mark locals as initialized.
85f24f61 8180
181aa2be 8181 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8182 (casify_region): Mark local as initialized.
181aa2be 8183
930d429c
PE
8184 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8185
7082eac6
PE
8186 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8187 New macros, so that the caller can use some names other than
8188 gcpro1, gcpro2, etc.
8189 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8190 of the new macros.
8191 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8192 argument, for consistency with GCPRO2_VAR, etc: it is now the
8193 prefix of the variable, not the variable itself. All uses
8194 changed.
38b2c076
PE
8195 * dired.c (directory_files_internal, file_name_completion):
8196 Rename locals to avoid shadowing.
8197
15206ed9
PE
8198 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8199 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8200 dired.c's scmp function, had undefined behavior.
8201 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8202 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8203 * buffer.h: ... to here, because these macros use current_buffer,
8204 and the new implementation with inline functions needs to have
8205 current_buffer in scope now, rather than later when the macros
8206 are used.
8207 (downcase, upcase1): New static inline functions.
8208 (DOWNCASE, UPCASE1): Reimplement using these functions.
8209 This avoids undefined behavior in expressions like
8210 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8211 from race conditions in accessing the global variables
8212 case_temp1 and case_temp2.
8213 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8214 * lisp.h (case_temp1, case_temp2): Remove their decls.
8215 * character.h (ASCII_CHAR_P): Move from here ...
8216 * lisp.h: ... to here, so that the inline functions mentioned
8217 above can use them.
8218
4a6bea26
PE
8219 * dired.c (directory_files_internal_unwind): Now static.
8220
f14b7e14
PE
8221 * fileio.c (file_name_as_directory, directory_file_name):
8222 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8223 Now static.
2893f146
PE
8224 (file_name_as_directory): Use const pointers when appropriate.
8225 (Fexpand_file_name): Likewise. In particular, newdir might
8226 point at constant storage, so make it a const pointer.
fd4ead52 8227 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8228 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8229 signedness issues.
f839df0c
PE
8230 (Fset_file_times, Finsert_file_contents, auto_save_error):
8231 Rename locals to avoid shadowing.
f14b7e14 8232
5716756e 8233 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8234 (Ftry_completion, Fall_completions): Rename or remove locals
8235 to avoid shadowing.
5716756e 8236
b4c3046a
PE
8237 * marker.c (bytepos_to_charpos): Remove; unused.
8238
b45db522
PE
8239 * lisp.h (verify_bytepos, count_markers): New decls,
8240 so that gcc does not warn that these functions aren't declared.
8241
85876d07
PE
8242 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8243 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8244 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8245 (copy_text): Remove unused local var.
85876d07 8246
03d78a21 8247 * filelock.c (within_one_second): Now static.
b3dd38ab 8248 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8249
5df8f01b
PE
8250 * buffer.c (fix_overlays_before): Mark locals as initialized.
8251 (fix_start_end_in_overlays): Likewise. This function should be
8252 simplified by using pointers-to-pointers, but that's a different
8253 matter.
b1d876f1 8254 (switch_to_buffer_1): Now static.
8f54f30a
PE
8255 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8256 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8257
a70072c9 8258 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8259 Fix pointer signedness issue.
edced198
PE
8260 (sys_subshell): Mark local as volatile if checking for lint,
8261 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8262 (MAXPATHLEN): Define only if needed.
a70072c9 8263
a0977c44
PE
8264 * process.c (serial_open, serial_configure): Move decls from here ...
8265 * systty.h: ... to here, so that they can be checked.
8266
a884fdcc
PE
8267 * fns.c (get_random, seed_random): Move extern decls from here ...
8268 * lisp.h: ... to here, so that they can be checked.
8269
604efe86 8270 * sysdep.c (reset_io): Now static.
b8950c94 8271 (wait_for_termination_signal): Remove; unused.
604efe86 8272
38fc62d9
PE
8273 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8274 (copy_keymap_item, append_key, push_text_char_description):
8275 Now static.
1004a21a 8276 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8277 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8278 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8279 (describe_map_tree):
8280 Rename locals to avoid shadowing.
38fc62d9 8281
2f2650da
PE
8282 * keyboard.c: Declare functions static if they are not used elsewhere.
8283 (echo_char, echo_dash, cmd_error, top_level_2):
8284 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8285 (read_char, kbd_buffer_get_event, make_lispy_position):
8286 (make_lispy_event, make_lispy_movement, apply_modifiers):
8287 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8288 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8289 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8290 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8291 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8292
a053e86c 8293 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8294 (mark_kboards): Move decl here ...
8295 * alloc.c (mark_kboards): ... from here.
a053e86c 8296
4752793e
PE
8297 * lisp.h (force_auto_save_soon): New decl.
8298
74f10ca7 8299 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8300 (DEFINE_DUMMY_FUNCTION): New macro.
8301 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8302 Use it.
c03cd23f
PE
8303 (main): Add casts to avoid warnings
8304 if GCC considers string literals to be constants.
74f10ca7 8305
022e70d4
PE
8306 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8307
59d6fe83
PE
8308 * dbusbind.c: Pointer signedness fixes.
8309 (xd_signature, xd_append_arg, xd_initialize):
8310 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8311 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8312 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8313 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8314
78320123
PE
8315 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8316 if GCC considers string literals to be constants.
49cebcca 8317 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8318
35ac2a97
SM
83192011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8320
fb103ca9
SM
8321 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8322 (print_preprocess, print_object): New macro to fix last change.
8323
35ac2a97
SM
8324 * print.c (print_preprocess): Don't forget font objects.
8325
62973b41
JB
83262011-03-16 Juanma Barranquero <lekktu@gmail.com>
8327
8328 * emacs.c (USAGE3): Doc fixes.
8329
0e48bb22
AS
83302011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8331
8332 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8333 structure.
8334
7684e57b
JB
83352011-03-14 Juanma Barranquero <lekktu@gmail.com>
8336
8337 * lisp.h (VWindow_system, Qfile_name_history):
8338 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8339 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8340 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8341
8342 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8343 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8344
8345 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8346 * w32console.c (detect_input_pending, read_input_pending)
8347 (encode_terminal_code):
8348 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8349 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8350 (w32_system_caret_y, Qfile_name_history):
8351 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8352 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8353 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8354 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8355 * w32proc.c (Qlocal, report_file_error):
8356 * w32term.c (Vwindow_system, updating_frame):
8357 * w32uniscribe.c (initialized, uniscribe_font_driver):
8358 Remove unneeded extern declarations.
8359
2aa46d6c
CY
83602011-03-14 Chong Yidong <cyd@stupidchicken.com>
8361
c96bbc66 8362 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8363
cffc6f3b
CY
83642011-03-13 Chong Yidong <cyd@stupidchicken.com>
8365
8366 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8367 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8368 These macros can no longer be used for assignment.
8369
44f230aa
SM
8370 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8371 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8372 (record_buffer_markers, fetch_buffer_markers): New functions for
8373 recording and fetching special buffer markers.
8374 (set_buffer_internal_1, set_buffer_temp): Use them.
8375
8376 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8377
8378 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8379
8380 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8381 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8382
8383 * xdisp.c (hscroll_window_tree):
8384 (reconsider_clip_changes): Use PT instead of BUF_PT.
8385
d251f04b
EZ
83862011-03-13 Eli Zaretskii <eliz@gnu.org>
8387
8388 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8389 $(EMACS_ROOT)/lib/intprops.h.
8390
f0c77cd1
PE
83912011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8392
3eca4629
PE
8393 Fix more problems found by GCC 4.5.2's static checks.
8394
7c86ee98
PE
8395 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8396 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8397 (xg_free_frame_widgets): Make it clear that a local variable is
8398 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8399 (gdk_window_get_screen): Make it clear that this macro is needed
8400 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8401 (int_gtk_range_get_value): New function, which avoids a diagnostic
8402 from gcc -Wbad-function-cast.
8403 (xg_set_toolkit_scroll_bar_thumb): Use it.
8404 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8405 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8406 (get_utf8_string, xg_get_file_with_chooser):
8407 Rename locals to avoid shadowing.
8408 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8409
41729b81
PE
8410 * xgselect.c (xg_select): Remove unused var.
8411
f0c77cd1
PE
8412 * image.c (four_corners_best): Mark locals as initialized.
8413 (gif_load): Initialize transparent_p to zero (Bug#8238).
8414 Mark another local as initialized.
ec6cf4c6 8415 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8416
ce0ad53d 8417 * image.c (clear_image_cache): Now static.
d5d5a617 8418 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8419 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8420 (x_edge_detection): Remove unnecessary cast that
8421 gcc -Wbad-function-cast diagnoses.
2037898d 8422 (gif_load): Fix pointer signedness.
6ae141d6
PE
8423 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8424 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8425
33383987 84262011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8427
d32df629
PE
8428 Improve quality of tests for time stamp overflow.
8429 For example, without this patch (encode-time 0 0 0 1 1
8430 1152921504606846976) returns the obviously-bogus value (-948597
8431 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8432 reports time overflow. See
8433 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8434 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8435 * editfns.c: Include limits.h and intprops.h.
8436 (TIME_T_MIN, TIME_T_MAX): New macros.
8437 (time_overflow): Move earlier, to before first use.
8438 (hi_time, lo_time): New functions, for an accurate test for
8439 out-of-range times.
8440 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8441 (Fget_internal_run_time): Don't assume time_t fits in int.
8442 (make_time): Use list2 instead of Fcons twice.
8443 (Fdecode_time): More accurate test for out-of-range times.
8444 (check_tm_member): New function.
8445 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8446 (lisp_time_argument): Don't rely on undefined left-shift and
8447 right-shift behavior when checking for time stamp overflow.
8be6f318 8448
fe31d94c
PE
8449 * editfns.c (time_overflow): New function, refactoring common code.
8450 (Fformat_time_string, Fdecode_time, Fencode_time):
8451 (Fcurrent_time_string): Use it.
8452
8be6f318
PE
8453 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8454 * dired.c (make_time): Move to ...
8455 * editfns.c (make_time): ... here.
8456 * systime.h: Note the move.
8457
09d9db2c 84582011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8459
126bc0dc
YM
8460 * fringe.c (update_window_fringes): Remove unused variables.
8461
c47cbdfd
YM
8462 * unexmacosx.c (copy_data_segment): Also copy __got section.
8463 (Bug#8223)
8464
7ac80be9
EZ
84652011-03-12 Eli Zaretskii <eliz@gnu.org>
8466
c96bbc66 8467 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8468 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8469 Constify `char *' arguments and their references according to
8470 prototypes in tparam.h.
8471
ecb0f94d 8472 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8473
7ac80be9
EZ
8474 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8475 Adapt all references accordingly.
8476
8477 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8478
ef1fd07e
TT
84792011-03-11 Tom Tromey <tromey@redhat.com>
8480
8481 * buffer.c (syms_of_buffer): Remove obsolete comment.
8482
7ef4b50c
EZ
84832011-03-11 Eli Zaretskii <eliz@gnu.org>
8484
8485 * termhooks.h (encode_terminal_code): Declare prototype.
8486
8487 * msdos.c (encode_terminal_code): Don't declare prototype.
8488
8489 * term.c (encode_terminal_code): Now external again, used by
8490 w32console.c and msdos.c.
8491
44f230aa
SM
8492 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8493 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8494
4b1ec863 84952011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8496
1714f52b 8497 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8498
4b1ec863
PE
8499 * fringe.c (update_window_fringes): Mark locals as initialized
8500 (Bug#8227).
8501 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8502
524c7aa6
PE
8503 * alloc.c (mark_fringe_data): Move decl from here ...
8504 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8505 to check its interface.
8506 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8507
a5c0af81 8508 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8509 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8510 (fontset_font): Mark local as initialized.
a9a06e0b 8511 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8512
b4716021
PE
8513 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8514
811e9bac 8515 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8516 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8517 (x_own_selection, Fx_disown_selection_internal): Rename locals
8518 to avoid shadowing.
8519 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8520
7e3ab302
PE
8521 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8522 so that the caller can use some name other than gcpro1.
8523 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8524 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8525 (Fx_backspace_delete_keys_p):
8526 Use them to avoid shadowing, and rename vars to avoid shadowing.
8527 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8528 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8529 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8530 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8531 Remove unused locals.
7e3ab302
PE
8532 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8533 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8534 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8535 macros.
f78faa98 8536
e2b13473
PE
8537 * xterm.h (x_mouse_leave): New decl.
8538
77f23912
PE
8539 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8540 Remove unused functions.
cdf4ba58
PE
8541 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8542 (x_calc_absolute_position): Now static.
7411c686 8543 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8544 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8545 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8546 unless they are used.
38d0b34a
PE
8547 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8548 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8549 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8550 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8551 (x_error_catcher, x_connection_closed, x_error_handler):
8552 (x_error_quitter, xembed_send_message, x_iconify_frame):
8553 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8554 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8555 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8556
44f230aa
SM
8557 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8558 Rename or move locals to avoid shadowing.
6b463e58 8559 (tty_defined_color, merge_face_heights): Now static.
5967d051 8560 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8561 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8562 does not deduce is never used uninitialized.
73719eba
PE
8563 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8564 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8565
426994c3 8566 * terminal.c (store_terminal_param): Now static.
5489860b 8567
032f1620 8568 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8569 (set_frame_menubar): Remove unused local.
d4323972 8570 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8571 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8572 since they might point to immutable storage.
281585b0
PE
8573 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8574 since it's unused otherwise.
032f1620 8575
367c19e5 8576 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8577 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8578 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8579 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8580 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8581 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8582 does not deduce are never used uninitialized.
70739cbe 8583
07b48fa9
PE
8584 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8585
8868a238 8586 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8587 * window.c (window_loop, size_window):
8588 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8589
7e5cf297 8590 * window.c (display_buffer): Now static.
d6550a9f
PE
8591 (size_window): Mark variables that gcc -Wuninitialized
8592 does not deduce are never used uninitialized.
a586633d
PE
8593 * window.h (check_all_windows): New decl, to forestall
8594 gcc -Wmissing-prototypes diagnostic.
5b555da1 8595 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8596
f6095868
PE
8597 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8598 shadowing.
8599 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8600 Include <limits.h>.
8601 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8602 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8603 (load_charset_map): Mark variables that gcc -Wuninitialized
8604 does not deduce are never used uninitialized.
53df7c11 8605 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8606
f38b440c
PE
8607 * coding.c (coding_set_source, coding_set_destination):
8608 Use "else { /* comment */ }" rather than "else /* comment */;"
8609 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8610 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8611 a block, when the outer 'i' will do.
8612 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8613 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8614 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8615 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8616 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8617 Rename locals to avoid shadowing.
8618 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8619 * coding.c (emacs_mule_char, encode_invocation_designation):
8620 Now static, since they're not used elsewhere.
413bb2db 8621 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8622 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8623 (decode_coding_emacs_mule): Mark variables that gcc
8624 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8625 (detect_coding_iso_2022): Initialize a local variable that might
8626 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8627 this initialization is needed. (Bug#8211)
5f58e762
PE
8628 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8629 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8630 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8631 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8632 Remove unused macros.
f38b440c 8633
232b38b9 8634 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8635 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8636 * character.c (string_count_byte8): Likewise.
232b38b9 8637
fb90da1b
PE
8638 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8639 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8640
fb93dbc2
PE
8641 * chartab.c (copy_sub_char_table): Now static, since it's not used
8642 elsewhere.
5c156ace
PE
8643 (sub_char_table_ref_and_range, char_table_ref_and_range):
8644 Rename locals to avoid shadowing.
bbcd0949 8645 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8646
7d3b3862 8647 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8648 (BIDI_BOB): Remove unused macro.
7d3b3862 8649
6be7d3da
PE
8650 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8651 deduce are never used uninitialized.
c2ed9c8b 8652 * term.c (encode_terminal_code): Likewise.
6be7d3da 8653
75f8807f 8654 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8655
50938595
PE
8656 * tparam.h: New file.
8657 * term.c, tparam.h: Include it.
8658 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8659 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8660 Move these decls to tparam.h, and make them agree with what
8661 is actually in tparam.c. The previous trick of using incompatible
8662 decls in different modules does not conform to the C standard.
8663 All callers of tparam changed to use tparam's actual API.
8664 * tparam.c (tparam1, tparam, tgoto):
8665 Use const pointers where appropriate.
8666
fbceeba2
PE
8667 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8668 * cm.h (struct cm): Likewise.
8669 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8670 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8671 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8672 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8673 (turn_on_face, init_tty): Likewise.
8674 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8675
7f3f1250
PE
8676 * term.c (term_mouse_position): Rename local to avoid shadowing.
8677
e6ca6543
PE
8678 * alloc.c (mark_ttys): Move decl from here ...
8679 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8680
c40f8d15
AS
86812011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8682
8683 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8684
cfe0661d
JB
86852011-03-09 Juanma Barranquero <lekktu@gmail.com>
8686
8687 * search.c (compile_pattern_1): Remove argument regp, unused since
8688 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8689 (compile_pattern): Don't pass it.
8690
0afb4571
J
86912011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8692
8693 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8694 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8695 for ! HAVE_GTK3.
8696 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8697
8698 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8699
8700 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8701 gdk_window_get_screen, gdk_window_get_geometry,
8702 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8703 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8704 (xg_get_pixbuf_from_pixmap): New function.
8705 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8706 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8707 Call xg_get_pixbuf_from_pixmap instead of
8708 gdk_pixbuf_get_from_drawable.
8709 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8710 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8711 (xg_check_special_colors): Use GtkStyleContext and its functions
8712 for HAVE_GTK3.
8713 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8714 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8715 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8716 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8717 Call gtk_widget_get_preferred_size.
0afb4571
J
8718 (xg_frame_resized): gdk_window_get_geometry only takes 5
8719 parameters.
44f230aa
SM
8720 (xg_win_to_widget, xg_event_is_for_menubar):
8721 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8722 (xg_set_widget_bg): New function.
8723 (delete_cb): New function.
895009e1 8724 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8725 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8726 (xg_set_background_color): Call xg_set_widget_bg.
8727 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8728 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8729 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8730 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8731 if ! HAVE_GTK3.
8732 (update_frame_tool_bar): Call gtk_widget_hide.
8733 (xg_initialize): Use GDK_KEY_g.
8734
8735 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8736 if ! HAVE_GTK3
8737 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8738
8739 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8740 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8741 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8742
1c2cc4ef
JB
87432011-03-08 Juanma Barranquero <lekktu@gmail.com>
8744
8745 * w32xfns.c (select_palette): Check success of RealizePalette against
8746 GDI_ERROR, not zero.
8747
33383987 8748See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8749
8750;; Local Variables:
8751;; coding: utf-8
aac0c6e3
MR
8752;; End:
8753
33383987 8754 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8755
8756 This file is part of GNU Emacs.
8757
8758 GNU Emacs is free software: you can redistribute it and/or modify
8759 it under the terms of the GNU General Public License as published by
8760 the Free Software Foundation, either version 3 of the License, or
8761 (at your option) any later version.
8762
8763 GNU Emacs is distributed in the hope that it will be useful,
8764 but WITHOUT ANY WARRANTY; without even the implied warranty of
8765 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8766 GNU General Public License for more details.
8767
8768 You should have received a copy of the GNU General Public License
8769 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.