* sysdep.c (list_system_processes): Port to NetBSD-current.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
31571fd7
PE
12012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2
f3047c75
PE
3 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4
31571fd7
PE
5 Do not require float-time's arg to fit in time_t (Bug#11825).
6 This works better on hosts where time_t is unsigned, and where
7 float-time is applied to the (negative) difference between two times.
8 * editfns.c (decode_time_components): Last arg is now double *,
9 not int *, and means to store all the result as a double, without
10 worrying about whether the seconds part fits in time_t.
11 All callers changed.
12 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
13 All callers changed.
14 (Ffloat_time): Do not fail merely because the specified time falls
15 outside of time_t range.
16
4516fbef
GM
172012-07-07 Glenn Morris <rgm@gnu.org>
18
19 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
20 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
21 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
22
07adc2c6
JB
232012-07-07 Juanma Barranquero <lekktu@gmail.com>
24
25 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
26 Update dependencies.
27
28 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
29
fd573f31
PE
302012-07-06 Paul Eggert <eggert@cs.ucla.edu>
31
fee5959d
PE
32 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
33 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
34 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
35 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
36 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
37 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
38
fd573f31
PE
39 * xfont.c (compare_font_names): Redo to omit the need for casts.
40
ddadbc0e
AS
412012-07-06 Andreas Schwab <schwab@linux-m68k.org>
42
fca8d6b6
AS
43 * xfns.c (Fx_change_window_property): Doc fix.
44 * w32fns.c (Fx_change_window_property): Doc fix.
45
ddadbc0e
AS
46 * w32fns.c (Fx_window_property): Accept the same arguments as the
47 X Windows version. Doc fix.
48 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
49
f247498e
JB
502012-07-06 Juanma Barranquero <lekktu@gmail.com>
51 Eli Zaretskii <eliz@gnu.org>
52
53 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
54 Windows-specific code from nt/config.nt moved here.
55 Obsolete settings removed.
56
216ee680
PE
572012-07-06 Paul Eggert <eggert@cs.ucla.edu>
58
59 * process.c: Avoid unnecessary calls to gettime.
60 (wait_reading_process_output): Don't get the time of day
61 when gobbling data immediately and not waiting, as there's no need
62 for it in that case. This removes a FIXME.
63
bdd091e4
JD
642012-07-06 Jan Djärv <jan.h.d@swipnet.se>
65
66 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
67 is defined (Bug#11768).
68
9d44f8ce
DA
692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
70
71 Fix marker debugging code.
72 * marker.c (byte_char_debug_check): Do not perform the check
73 if buffer is not multibyte.
74 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
75 byte_char_debug_check with correct arguments.
76
90fc4786
DA
772012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
78
79 Compile marker debugging code only if ENABLE_CHECKING is defined.
80 * marker.c (byte_char_debug_check, count_markers): Use
81 only if ENABLE_CHECKING is defined.
82 (byte_debug_flag): Remove.
83 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
84 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
85
7b7ae965
DA
862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
87
4e57b342
DA
88 Avoid code repetition in marker-related functions.
89 * marker.c (attach_marker): New function.
90 (Fset_marker, set_marker_restricted, set_marker_both)
91 (set_marker_restricted_both): Use it.
92 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
93 Consistently rename charno to charpos.
94 (marker_position): Add eassert.
95 (marker_byte_position): Convert to eassert.
96
972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
98
99 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 100 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 101 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 102
657924ff
DA
1032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
104
105 Introduce fast path for the widely used marker operation.
106 * alloc.c (build_marker): New function.
107 * lisp.h (build_marker): New prototype.
108 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
109 * composite.c (autocmp_chars): Likewise.
110 * editfns.c (buildmark): Remove.
111 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
112 (save_restriction_save): Use build_marker.
113 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
114 * window.c (save_window_save): Likewise.
115
041a49a6
DA
1162012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
117
118 Do not use Fdelete_overlay in delete_all_overlays
119 to avoid redundant calls to unchain_overlay.
120 * buffer.c (drop_overlay): New function.
121 (delete_all_overlays, Fdelete_overlay): Use it.
122 * minibuf.c (get_minibuffer): Fix comment.
123
7dca65a4
PE
1242012-07-06 Paul Eggert <eggert@cs.ucla.edu>
125
126 Port to OpenBSD 5.1 amd64.
127 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
128 This is needed for OpenBSD, and should be harmless on all BSD systems.
129 Also, include <sys/sysctl.h>, as it should be available on all
130 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
131 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
132 use p_pid member, not kp_proc.pid.
133
8eb876e2
GM
1342012-07-06 Glenn Morris <rgm@gnu.org>
135
136 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
137
38182d90
PE
1382012-07-05 Paul Eggert <eggert@cs.ucla.edu>
139
140 More xmalloc and related cleanup.
141 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
142 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
143 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
144 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
145 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
146 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
147 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
148 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
149 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
150 * xterm.c:
151 Omit needless casts involving void * pointers and allocation.
152 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
153 as the former is more robust if P's type is changed.
154 Prefer xzalloc to xmalloc + memset 0.
155 Simplify malloc-or-realloc to realloc.
156 Don't worry about xmalloc returning a null pointer.
157 Prefer xstrdup to xmalloc + strcpy.
158 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
159 growing it.
160 * keyboard.c (apply_modifiers_uncached): Prefer local array to
161 alloca of a constant.
162
6dd5a677
EZ
1632012-07-05 Eli Zaretskii <eliz@gnu.org>
164
165 * xdisp.c (display_line): Fix horizontal pixel coordinates when
166 hscroll is larger than the line width. Fixes long and futile
167 looping inside extend_face_to_end_of_line (on a TTY) producing
168 glyphs that are not needed and thrown away.
169
6b312f0f
DA
1702012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
171
172 * marker.c (set_marker_restricted_both): Simplify by using
173 clip_to_bounds.
174
f520ef9b
PE
1752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
176
177 * editfns.c (region_limit): Simplify by using clip_to_bounds.
178
383b7c95
JD
1792012-07-05 Jan Djärv <jan.h.d@swipnet.se>
180
181 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
182 not defined (Bug#11768).
183 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
184 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
185 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
186 followed by gtk_box_set_homogeneous (Bug#11768).
187 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
188 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
189 gtk_scrollbar_new (Bug#11768).
190 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
191 (is_box_type): New function (Bug#11768).
192 (xg_tool_item_stale_p): Call is_box_type.
5293d758 193 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
194 with default display (Bug#11768).
195
d6e7bf45
EZ
1962012-07-05 Eli Zaretskii <eliz@gnu.org>
197
198 * xdisp.c (window_hscroll_limited): New function.
199 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
200 coordinates when window's hscroll is set to insanely large
201 values. (Bug#11857)
202
431391ec
JB
2032012-07-05 Juanma Barranquero <lekktu@gmail.com>
204
205 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
206 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
207
23f86fce
DA
2082012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Cleanup xmalloc.
211 * lisp.h (xzalloc): New prototype. Omit needless casts.
212 * alloc.c (xzalloc): New function. Omit needless casts.
213 * charset.c: Omit needless casts. Convert all calls to
214 xmalloc with following memset to xzalloc.
215 * dispnew.c: Likewise.
216 * fringe.c: Likewise.
217 * image.c: Likewise.
218 * sound.c: Likewise.
219 * term.c: Likewise.
220 * w32fns.c: Likewise.
221 * w32font.c: Likewise.
222 * w32term.c: Likewise.
223 * xfaces.c: Likewise.
224 * xfns.c: Likewise.
225 * xterm.c: Likewise.
226 * atimer.c: Omit needless casts.
227 * buffer.c: Likewise.
228 * callproc.c: Likewise.
229 * ccl.c: Likewise.
230 * coding.c: Likewise.
231 * composite.c: Likewise.
232 * doc.c: Likewise.
233 * doprnt.c: Likewise.
234 * editfns.c: Likewise.
235 * emacs.c: Likewise.
236 * eval.c: Likewise.
237 * filelock.c: Likewise.
238 * fns.c: Likewise.
239 * gtkutil.c: Likewise.
240 * keyboard.c: Likewise.
241 * lisp.h: Likewise.
242 * lread.c: Likewise.
243 * minibuf.c: Likewise.
244 * msdos.c: Likewise.
245 * print.c: Likewise.
246 * process.c: Likewise.
247 * region-cache.c: Likewise.
248 * search.c: Likewise.
249 * sysdep.c: Likewise.
250 * termcap.c: Likewise.
251 * terminal.c: Likewise.
252 * tparam.c: Likewise.
253 * w16select.c: Likewise.
254 * w32.c: Likewise.
255 * w32reg.c: Likewise.
256 * w32select.c: Likewise.
257 * w32uniscribe.c: Likewise.
258 * widget.c: Likewise.
259 * xdisp.c: Likewise.
260 * xmenu.c: Likewise.
261 * xrdb.c: Likewise.
262 * xselect.c: Likewise.
263
0497dc44
PE
2642012-07-05 Paul Eggert <eggert@cs.ucla.edu>
265
266 * fileio.c (time_error_value): Check the right error number.
267 Problem reported by Troels Nielsen in
268 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
269
356e7178
PE
2702012-07-04 Paul Eggert <eggert@cs.ucla.edu>
271
4e71fd89
PE
272 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
273 This should be fixed in a better way; see Eli Zaretskii in
274 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
275 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
276
f0941253
PE
277 * fileio.c (time_error_value): Rename from special_mtime.
278 The old name's problems were noted by Eli Zaretskii in
279 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
280
065c9eb4
PE
281 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
282 This variable's comment says Emacs needs at least one GDB-visible
283 symbol of type enum pvec_type, to work around GDB problems.
284 The symbol's value doesn't matter.
285
356e7178
PE
286 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
287 that causes compilation to fail on pre-C99 compilers.
288
95f61aa2
JB
2892012-07-04 Juanma Barranquero <lekktu@gmail.com>
290
291 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
292 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
293
3884d954
DA
2942012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
295
d209e2fb 296 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
297 headers for buffer_defaults and buffer_local_symbols.
298 Reported by Juanma Barranquero <lekktu@gmail.com>.
299
ee28be33
SM
3002012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
301
302 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
303 * lisp.h (enum pvec_type): Use fewer bits.
304 (PSEUDOVECTOR_SIZE_BITS): New constant.
305 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
306 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
307 change in pvec_type.
308 (PSEUDOVECTOR_TYPEP): New macro.
309 (TYPED_PSEUDOVECTORP): Use it.
310 * fns.c (internal_equal): Adapt code to extract pvectype.
311 * emacs.c (gdb_pvec_type): Update type.
312 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
313 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
314 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
315 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
316 (sweep_vectors): Use it. Use local var `total_bytes' instead of
317 abusing vector->header.next.nbytes.
318 (live_vector_p): Use PVEC_TYPE.
319 (mark_object): Adapt code to extract pvectype. Use switch.
320
c7f2cd7f
PE
3212012-07-04 Paul Eggert <eggert@cs.ucla.edu>
322
323 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
324 Tighten new eassert a bit.
325
8ce70ed2
DA
3262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
327
328 Fix compilation with --enable-gcc-warnings and -O1
329 optimization level.
330 * doprnt.c (doprnt): Change type of tem to int, initialize
331 to avoid compiler warning. Add eassert.
332 * search.c (simple_search): Initialize match_byte to avoid
333 compiler warning. Add eassert.
334
dea7f1e5
PE
3352012-07-04 Paul Eggert <eggert@cs.ucla.edu>
336
24a212eb
PE
337 Avoid weird behavior with large horizontal scrolls.
338 Without this change, for example, large hscroll values would
339 mess up Emacs's display on Fedora 15 x86, presumably due to
340 overflows in int calculations in the display code.
341 Also, if buffers had long lines, Emacs would freeze.
342 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
343 (set_window_hscroll): New function, containing the old guts of
344 Fset_window_hscroll. Return the clipped value.
345 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
346 This avoids the need to check against PTRDIFF_MAX.
347
dea7f1e5
PE
348 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
349
76046526
DA
3502012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
351
352 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
353
39adff0d
PE
3542012-07-04 Paul Eggert <eggert@cs.ucla.edu>
355
63807d47
PE
356 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
357 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
358 since GCC 4.4.6 issues a bogus warning for them.
359
39adff0d
PE
360 Fix bugs in file timestamp newness comparisons.
361 * fileio.c (Ffile_newer_than_file_p):
362 * lread.c (Fload): Use full timestamp resolution of files,
363 not just the 1-second resolution, so that files that are only
364 slightly newer still count as newer.
365 * fileio.c (Ffile_newer_than_file_p): Don't assume file
366 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
367
dbeed9a6
PE
3682012-07-03 Paul Eggert <eggert@cs.ucla.edu>
369
370 * fileio.c: Improve handling of file time marker. (Bug#11852)
371 (special_mtime): New function.
372 (Finsert_file_contents, Fverify_visited_file_modtime):
373 Use it to set special mtime values consistently.
374
636334d6
AS
3752012-07-03 Andreas Schwab <schwab@linux-m68k.org>
376
377 * fileio.c (Finsert_file_contents): Properly handle st_mtime
378 marker for non-existing file. (Bug#11852)
379
e2017fe2
GM
3802012-07-03 Glenn Morris <rgm@gnu.org>
381
382 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
383 and did not make it into globals.h).
384
404dbd37
TT
3852012-07-03 Tom Tromey <tromey@redhat.com>
386
387 * window.c (Fset_window_margins, Fset_window_fringes)
388 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
389 * textprop.c (Fprevious_property_change): No longer static.
390 * syntax.c (Fsyntax_table_p): No longer static.
391 * process.c (Fget_process, Fprocess_datagram_address): No longer
392 static.
393 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
394 * keyboard.c (Fcommand_execute): No longer static.
395 Remove EXFUN.
396 * insdel.c (Fcombine_after_change_execute): No longer static.
397 * image.c (Finit_image_library): No longer static.
398 * fileio.c (Fmake_symbolic_link): No longer static.
399 * eval.c (Ffetch_bytecode): No longer static.
400 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
401 * doc.c (Fdocumentation_property, Fsnarf_documentation):
402 No longer static.
404dbd37
TT
403 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
404 static.
405 * dired.c (Ffile_attributes): No longer static.
406 * composite.c (Fcomposition_get_gstring): No longer static.
407 * callproc.c (Fgetenv_internal): No longer static.
408
409 * ccl.h: Remove EXFUNs.
410 * buffer.h: Remove EXFUNs.
411 * dispextern.h: Remove EXFUNs.
412 * intervals.h: Remove EXFUNs.
413 * fontset.h: Remove EXFUN.
414 * font.h: Remove EXFUNs.
415 * dosfns.c (system_process_attributes): Remove EXFUN.
416 * keymap.h: Remove EXFUNs.
417 * lisp.h: Remove EXFUNs.
418 * w32term.h: Remove EXFUNs.
419 * window.h: Remove EXFUNs.
420 * xsettings.h: Remove EXFUN.
421 * xterm.h: Remove EXFUN.
422
8e4fd1e1
GM
4232012-07-03 Glenn Morris <rgm@gnu.org>
424
425 * lisp.h (Frandom): Make it visible to C.
426 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
427 buffer for invisible buffers. (Bug#1229)
428
ca95b3eb
DA
4292012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
430
431 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
432 values which aren't power of 2.
433 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
434 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
435 accordingly.
436
7555c33f
SM
4372012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
438
439 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
440
441 * alloc.c (mark_object): Revert part of last patch to use `switch'.
442
d12e8f5a
DA
4432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
444
445 * alloc.c (allocate_vector_block): Remove redundant
446 calls to mallopt if DOUG_LEA_MALLOC is defined.
447 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
448 avoid calls to mallopt if zero_vector is returned.
449
296094c3
DA
4502012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
451
452 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
453 is enabled, avoid dereferencing NULL current_sblock if
454 running undumped.
455
36429c89
DA
4562012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
457
458 Cleanup basic buffer management.
459 * buffer.h (struct buffer): Change layout to use generic vector
460 marking code. Fix some comments. Change type of 'clip_changed'
461 to bitfield. Remove unused #ifndef old.
462 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
463 (GET_OVERLAYS_AT): Fix indentation.
464 (for_each_per_buffer_object_at): New macro.
465 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
466 (Fbuffer_local_variables): Use it.
467 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
468 * alloc.c (allocate_buffer): Adjust to match new layout of
469 struct buffer. Fix comment.
470 (mark_overlay): New function.
471 (mark_buffer): Use it. Use mark_vectorlike to mark normal
472 Lisp area of struct buffer.
473 (mark_object): Use it. Adjust marking of misc objects
474 and related comments.
475
3b3e4cac
PE
4762012-07-02 Paul Eggert <eggert@cs.ucla.edu>
477
478 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
479 wrapper that is not needed because the wrapped code is a no-op (zero
480 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
481 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
482
cf5c0175
DA
4832012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
484
485 * alloc.c (mark_buffer): Simplify. Remove prototype.
486 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 487 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
488 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
489 redundant calls to mark_vectorlike for bool vectors.
490
ca26824c
GM
4912012-06-30 Glenn Morris <rgm@gnu.org>
492
2e4c5312
GM
493 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
494
ca26824c
GM
495 * epaths.in (PATH_SITELOADSEARCH): New.
496 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
497 This is rather than relying on --enable-locallisppath elements
498 having "site-lisp" in their names. (Bug#10208#25, 11658)
499
0d23c240
EZ
5002012-06-30 Eli Zaretskii <eliz@gnu.org>
501
c9240d7a
EZ
502 * w32proc.c (sys_select): Accept and ignore one more argument.
503
504 * w32.c (emacs_gnutls_pull): Call select with one more argument.
505
0d23c240 506 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 507 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
508
509 * sysdep.c: Don't include dos.h and dosfns.h.
510
511 * process.c (sys_select):
512 * msdos.c (sys_select): Accept one more argument and ignore it.
513
514 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
515 adapt data types and code to that.
516
517 * dosfns.c:
518 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
519 which clashes with the gnulib function of the same name.
520
af5a5a98
AS
5212012-06-30 Andreas Schwab <schwab@linux-m68k.org>
522
c5e4379c
AS
523 * font.c (font_style_to_value, font_style_symbolic)
524 (font_prop_validate_style): Add type checks for values in
525 font_style_table.
526
af5a5a98
AS
527 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
528 argument.
529 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
530 uses.
531
8d38f461
EZ
5322012-06-29 Eli Zaretskii <eliz@gnu.org>
533
2e5a6631
EZ
534 * xdisp.c (try_window_id): Undo last change.
535
8d38f461
EZ
536 * w32.c (getwd): Adjust commentary about startup_dir.
537 (init_environment): Always call sys_access, even in non-MSVC
538 builds. Don't chdir to the directory of the Emacs executable.
539 This undoes code from 1997 which was justified by the need to
540 "avoid conflicts when removing and renaming directories". But its
541 downside was that every relative file name was being interpreted
542 relative to the directory of the Emacs executable, which can never
543 be TRT. In particular, it broke sys_access when called with
544 relative file names.
545 (sys_access): Map GetLastError to errno.
546
2af3565e
DA
5472012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
548
549 * window.h (struct window): Change type of 'fringes_outside_margins'
550 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 551 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
552 Adjust comment.
553 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
554 to ptrdiff_t.
555
c8d3a25c 5562012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 557
c8d3a25c
GM
558 * gnutls.c (emacs_gnutls_handshake):
559 Add QUIT to make the loop interruptible.
57570cd3 560
c8d3a25c 5612012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 562
c8d3a25c
GM
563 * charset.c (init_charset): Make lack of etc/charsets fatal.
564
3e984ee8
DA
5652012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
566
567 * editfns.c (region_limit): Fix type mismatch.
568
ef884f23
DA
5692012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
570
571 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
572 undefined. Convert from xassert to eassert.
573 * nsmenu.m: Convert from xassert to eassert.
574 * nsterm.m: Likewise.
575
7d7e0027
SM
5762012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
577
578 * editfns.c (region_limit): Clip to narrowing (bug#11770).
579
aa754e6a
PE
5802012-06-28 Paul Eggert <eggert@cs.ucla.edu>
581
582 Avoid integer overflow on scroll-left and scroll-right.
583 * window.c (HSCROLL_MAX): New macro.
584 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
585 overflow when requested scroll falls outside ptrdiff_t range.
586
80b00b08
DA
5872012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
588
589 * window.h (struct window): Change type of 'hscroll',
590 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
591 'last_modified' and 'last_overlay_modified' to EMACS_INT.
592 Adjust users accordingly.
593 * xdisp.c (try_cursor_movement): Replace type check with eassert.
594 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
595 from EMACS_INT to ptrdiff_t.
596 (make_window): Omit redundant initialization.
597
62b2bcf6
JB
5982012-06-28 Juanma Barranquero <lekktu@gmail.com>
599
600 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
601
45942c7d
DA
6022012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
603
604 * window.h (struct window): Change type of 'use_time' and
605 'sequence_number' from Lisp_Object to int.
606 * frame.c (make_frame): Adjust users accordingly.
607 * print.c (print_object): Likewise.
608 * window.c (select_window, Fwindow_use_time, make_parent_window)
609 (make_window): Likewise.
610
e509cfa6
DA
6112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
612
613 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
614 enabled with --enable-checking=[all,glyphs] configure option.
615 Fix GLYPH_DEBUG usage assuming that it may be undefined,
616 adjust comments accordingly.
617 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
618 undefined, adjust comments accordingly.
619 * image.c: Likewise.
620 * scroll.c: Likewise.
621 * w32fns.c: Likewise.
622 * w32term.c: Likewise.
623 * xdisp.c: Likewise.
624 * xfaces.c: Likewise.
625 * xfns.c: Likewise.
626 * xterm.c: Likewise.
627
a54e2c05
DA
6282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
629
630 Generalize run-time debugging checks.
631 * dispextern.h (XASSERTS): Remove.
632 * fontset.c (xassert): Remove.
633 Convert from xassert to eassert.
634 * alloc.c: Convert from xassert to eassert.
635 * bidi.c: Likewise.
636 * dispnew.c: Likewise.
637 * fns.c: Likewise.
638 * fringe.c: Likewise.
639 * ftfont.c: Likewise.
640 * gtkutil.c: Likewise.
641 * image.c: Likewise.
642 * keyboard.c: Likewise.
643 * menu.c: Likewise.
644 * process.c: Likewise.
645 * scroll.c: Likewise.
646 * sound.c: Likewise.
647 * term.c: Likewise.
648 * w32console.c: Likewise.
649 * w32fns.c: Likewise.
650 * w32term.c: Likewise.
651 * window.c: Likewise.
652 * xdisp.c: Likewise.
653 * xfaces.c: Likewise.
654 * xfns.c: Likewise.
655 * xselect.c: Likewise.
656 * xterm.c: Likewise.
657
1ec4b7b2
SM
6582012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
659
660 * fns.c (maybe_resize_hash_table): Output message when growing the
661 purify-hashtable.
662
2014308a
DA
6632012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
664
665 * alloc.c (allocate_string_data): Remove dead code.
666 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
667 avoid GCC warning about unused macro.
668
246155eb
DA
6692012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
670
671 * alloc.c (allocate_string): Omit intervals initialization.
672 * alloc.c (make_uninit_multibyte_string): Initialize intervals
673 as in make_pure_string and make_pure_c_string.
674
43184b7b
DA
6752012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
676
d209e2fb 677 * alloc.c (allocate_string): Fix last change.
43184b7b 678
3fe6dd74
DA
6792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
680
d209e2fb 681 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
682 to memset, add explicit initialization where appropriate.
683
1ba6038a
GM
6842012-06-27 Glenn Morris <rgm@gnu.org>
685
686 * lisp.mk (lisp): Remove paths.elc.
687
c89926a5
CY
6882012-06-27 Chong Yidong <cyd@gnu.org>
689
690 * doc.c (Fsubstitute_command_keys): Fix punctuation.
691
ed6b3510
JW
6922012-06-26 John Wiegley <johnw@newartisans.com>
693
1ec4b7b2 694 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
695 on Mac OS X Lion: __mod_init_func and __mod_term_func.
696
ed6b3510
JW
697 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
698 when building with Clang.
699
8edd4a2b
SM
7002012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
701
702 * eval.c (Fapply): Allow calling it with a single argument.
703
f6f62d1b
EZ
7042012-06-26 Eli Zaretskii <eliz@gnu.org>
705
706 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
707 _stricmp and _strnicmp.
708 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
709
62efea5e
DA
7102012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
711
712 * alloc.c (allocate_window): Zero out non-Lisp part of newly
713 allocated window.
714 (allocate_process): Likewise for new process.
8edd4a2b 715 (allocate_terminal): Change to use offsetof.
62efea5e
DA
716 (allocate_frame): Likewise.
717 * frame.c (make_frame): Omit redundant initialization.
718 * window.c (make_parent_window): Use memset.
719 (make_window): Omit redundant initialization.
720 * process.c (make_process): Omit redundant initialization.
721 * terminal.c (create_terminal): Likewise.
722
42997f4d
DA
7232012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
724
725 * term.c (delete_tty): Remove redundant call to memset.
726
1130ecfc
DA
7272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
728
729 * alloc.c: Remove build_string.
730 * lisp.h: Define build_string as static inline. This provides
731 a better opportunity to optimize away calls to strlen when the
732 function is called with compile-time constant argument.
733 * image.c (imagemagick_error): Convert to build_string.
734 * w32proc.c (sys_spawnve): Likewise.
735 * xterm.c (x_term_init): Likewise.
736
cf38a720
PE
7372012-06-26 Paul Eggert <eggert@cs.ucla.edu>
738
99027bdd
PE
739 Use sprintf return value instead of invoking strlen on result.
740 In the old days this wasn't portable, since some sprintf
741 implementations returned char *. But they died out years ago and
742 Emacs already assumes sprintf returns int.
743 Similarly for float_to_string.
744 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
745 * ccl.c (ccl_driver):
746 * character.c (string_escape_byte8):
747 * data.c (Fnumber_to_string):
748 * doprnt.c (doprnt):
749 * print.c (print_object):
750 * xdisp.c (message_dolog):
751 * xfns.c (syms_of_xfns):
752 Use sprintf or float_to_string result to avoid need to call strlen.
753 * data.c (Fnumber_to_string):
754 Use make_unibyte_string, since the string must be ASCII.
755 * lisp.h, print.c (float_to_string): Now returns int length.
756 * term.c (produce_glyphless_glyph):
757 Use sprintf result rather than recomputing it.
758
cf38a720
PE
759 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
760 * Makefile.in (ALL_CFLAGS):
761 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
762 * gmalloc.c, regex.c: Include <config.h> unconditionally.
763
3511c784
DA
7642012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
765
0a08eb21 766 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
767 strcasecmp if available.
768 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
769
fb7da12e
AS
7702012-06-25 Andreas Schwab <schwab@linux-m68k.org>
771
772 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
773 Avoid comma operator.
774 * menu.c (push_submenu_start, push_submenu_end)
775 (push_left_right_boundary, push_menu_pane): Likewise.
776 * msdos.c (dos_rawgetc): Likewise.
777
afa2ffd8
DA
7782012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
779
780 * xfns.c (xic_create_fontsetname): Remove redundant calls
781 to memset.
782
b3b4476b
PE
7832012-06-25 Paul Eggert <eggert@cs.ucla.edu>
784
4495ff38
PE
785 * gtkutil.c (get_utf8_string): Remove redundant assignment.
786 sprintf already null-terminates its output.
787
b3b4476b
PE
788 * xfns.c (x_window): Remove redundant cast.
789
b00876c9
DA
7902012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
791
792 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
793 `const char *' to `char *' to avoid compiler warning.
794
d188e26b
PE
7952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
796
885d1d74
PE
797 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
798 instead of truncating it to 63 (admittedly a generous limit).
799
d188e26b
PE
800 * process.c: Fix spelling and caps in comments.
801
e2f560b1
DN
8022012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
803
e86db54b 804 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
805 * sysdep.c (setpgrp): Remove definition, not used in this file.
806
7583a3a1
JB
8072012-06-24 Juanma Barranquero <lekktu@gmail.com>
808
809 * makefile.w32-in: Update dependencies.
810
696056c2
EZ
8112012-06-24 Eli Zaretskii <eliz@gnu.org>
812
813 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
814 (SYSTIME_H): Add nt/inc/sys/time.h.
815
816 * systime.h [WINDOWSNT]: Include sys/time.h.
817
818 * s/ms-w32.h (struct timespec): Definition moved from
819 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
820
845ca893
PE
8212012-06-24 Paul Eggert <eggert@cs.ucla.edu>
822
823 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
824 * buffer.h (buffer_slot_type_mismatch):
825 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
826 * eval.c (unwind_to_catch):
827 * image.c (my_png_error, my_error_exit):
828 * keyboard.c (quit_throw_to_read_char, user_error)
829 (Fexit_recursive_edit, Fabort_recursive_edit):
830 * lisp.h (die, args_out_of_range, args_out_of_range_3)
831 (wrong_type_argument, buffer_overflow, __executable_start)
832 (memory_full, buffer_memory_full, string_overflow, Fthrow)
833 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
834 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
835 (fatal):
836 (child_setup) [!DOS_NT]:
837 * lread.c (end_of_file_error, invalid_syntax):
838 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
839 * puresize.h (pure_write_error):
840 * search.c (matcher_overflow):
841 * sound.c (sound_perror, alsa_sound_perror):
842 * sysdep.c, syssignal.h (croak):
843 * term.c (maybe_fatal, vfatal):
844 * textprop.c (text_read_only):
845 * undo.c (user_error):
846 * unexmacosx.c (unexec_error):
847 * xterm.c (x_ins_del_lines, x_delete_glyphs):
848 Use _Noreturn rather than NO_RETURN.
849 No need for separate decl merely because of _Noreturn.
850 * sound.c (sound_warning, parse_sound):
851 Remove unnecessary forward decls.
852
f1dd8073
PE
8532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
854
855 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
856 * lisp.h (WAIT_READING_MAX): New macro.
857 * dispnew.c (Fsleep_for, sit_for):
858 * keyboard.c (kbd_buffer_get_event):
859 * process.c (Faccept_process_output):
860 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
861 This improves on the previous patch, which introduced a bug
862 when time_t is unsigned and as wide as intmax_t.
863 See <http://bugs.gnu.org/9000#51>.
864
b82c1755
EZ
8652012-06-23 Eli Zaretskii <eliz@gnu.org>
866
867 * dispnew.c (sit_for, Fsleep_for):
868 * keyboard.c (kbd_buffer_get_event):
869 * process.c (Faccept_process_output): Avoid compiler warnings when
870 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
871
ca300656
JB
8722012-06-23 Juanma Barranquero <lekktu@gmail.com>
873
049ec95b
JB
874 * makefile.w32-in: Update dependencies.
875
ca300656
JB
876 * w32.c (ltime): Add return type and declare static.
877 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
878
db7b8d06
PE
8792012-06-23 Paul Eggert <eggert@cs.ucla.edu>
880
881 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
882 Privately reported by Herbert J. Skuhra.
883 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
884 All uses changed.
885 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
886 not make_lisp_timeval, when the argument is of type EMACS_TIME.
887
0bd8297f
EZ
8882012-06-23 Eli Zaretskii <eliz@gnu.org>
889
96512555
EZ
890 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
891 last argument of make_unibyte_string.
892
0bd8297f
EZ
893 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
894 language ID in the event parameters.
895
896 * w32term.c (w32_read_socket): Put the new keyboard codepage into
897 event.code, not the obscure "character set ID".
898
63def6b6
CY
8992012-06-23 Chong Yidong <cyd@gnu.org>
900
901 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
902
e8a02204
EZ
9032012-06-23 Eli Zaretskii <eliz@gnu.org>
904
388cdec0
EZ
905 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
906 * w32.c (fdutimens): New function.
907
908 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
909
910 * s/ms-w32.h (pselect): Redirect to sys_select.
911
912 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
913
e8a02204
EZ
914 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
915 in the logic of incrementing and decrementing the value of
916 use_relocatable_buffers.
917
d054f3fb
PE
9182012-06-23 Paul Eggert <eggert@cs.ucla.edu>
919
920 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
921 Privately reported by Herbert J. Skuhra.
922 [__FreeBSD__]: Remove "*/" typo after "#include".
923 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
924 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
925 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
926 Don't assume EMACS_TIME and struct timeval are the same type.
927
d35af63c
PE
9282012-06-22 Paul Eggert <eggert@cs.ucla.edu>
929
930 Support higher-resolution time stamps (Bug#9000).
931 The time stamps are only nanosecond-resolution at the C level,
932 since that's the best that any real-world system supports now.
933 But they are picosecond-resolution at the Lisp level, as that's
934 easy, and leaves room for future OS improvements.
935
936 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
937 (LIBES): Use it.
938
939 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
940 Don't get current time unless it's needed.
941
942 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
943 now provides it if it's absent.
944 (start_atimer): Port to higher-res time stamps.
945 Check for time stamp overflow. Don't get current time more
946 often than is needed.
947
948 * buffer.h (struct buffer): Buffer modtime now has high resolution.
949 Include systime.h, not time.h.
950 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
951
952 * dired.c: Include stat-time.h.
953 (Ffile-attributes): File times now have higher resolution.
954
955 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
956 (struct image): Timestamp now has higher resolution.
957
958 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
959 has at least microseconds now. All uses removed.
960 (update_frame, update_single_window, update_window, update_frame_1)
961 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
962
963 * editfns.c (time_overflow): Now extern.
964 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
965 (float-time, Fformat_time_string, Fcurrent_time_string)
966 (Fcurrent_time_zone): Accept and generate higher-resolution
967 time stamps.
968 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
969 (decode_time_components, lisp_seconds_argument): New functions.
970 (make_time): Now static.
971 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
972 Report an error if the time is invalid, rather than having the caller
973 do that.
974
975 * fileio.c: Include <stat-time.h>
976 (Fcopy_file): Copy higher-resolution time stamps.
977 Prefer to set the time stamp via a file descriptor if that works.
978 (Fset_file_times, Finsert_file_contents, Fwrite_region)
979 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
980 (Fvisited_file_modtime, Fset_visited_file_modtime):
981 Support higher-resolution time stamps.
982
983 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
984
985 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
986
987 * image.c (prepare_image_for_display, clear_image_cache)
988 (lookup_image): Port to higer-resolution time stamps.
989
990 * keyboard.c (start_polling, bind_polling_period):
991 Check for time stamp overflow.
992 (read_char, kbd_buffer_get_event, timer_start_idle)
993 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
994 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
995 Port to higher-resolution time stamps. Do not assume time_t is signed.
996 (decode_timer): New function. Timers are now vectors of length 9,
997 not 8, to accommodate the picosecond component.
998 (timer_check_2): Use it.
999
1000 * nsterm.m (select_timeout, timeval_subtract): Remove.
1001 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1002 as they're a bit more accurate and handle overflow better.
1003 (ns_select): Change prototype to be compatible with pselect.
1004 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1005 * nsterm.h (ns_select): Adjust prototype.
1006
1007 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1008 us-resolution time stamps.
1009 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1010
1011 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1012
1013 * lisp.h (time_overflow): New decl.
1014 (wait_reading_process_output): First arg is now intmax_t, not int,
1015 to accommodate larger waits.
1016
1017 * process.h (struct Lisp_Process.read_output_delay):
1018 Now counts nanoseconds, not microseconds.
1019 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1020 EMACS_HAS_USECS.
1021 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1022 (wait_reading_process_output):
1023 Port to ns-resolution time stamps.
1024 (Faccept_process_output, wait_reading_process_output):
1025 Check for time stamp overflow. Do not assume time_t is signed.
1026 (select_wrapper): Remove; we now use pselect.
1027 (Fprocess_attributes): Now generates ns-resolution time stamps.
1028
1029 * sysdep.c: Include utimens.h. Don't include utime.h
1030 or worry about struct utimbuf; gnulib does that for us now.
1031 (gettimeofday): Remove; gnulib provides a substitute.
1032 (make_timeval): New function.
1033 (set_file_times): Now sets ns-resolution time stamps.
1034 New arg FD; all uses changed.
1035 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1036 (system_process_attributes):
1037 Now returns ns-resolution time stamp. All uses changed.
1038 Check for time stamp overflow.
1039
1040 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1041 provides a substitute now.
1042
1043 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1044 since it guarantees struct timespec.
1045 (EMACS_TIME): Now struct timespec, so that we can support
1046 ns-resolution time stamps.
1047 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1048 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1049 (EMACS_USECS): Remove.
1050 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1051 so multiply the arg by 1000 before storing it.
1052 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1053 New macros.
1054 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1055 Port to ns-resolution time stamps.
1056 (EMACS_TIME_NEG_P): Remove; replaced by....
1057 (EMACS_TIME_SIGN): New macro.
1058 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1059 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1060 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1061 (make_timeval, make_lisp_time, decode_time_components): New decls.
1062 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1063 that it mishandled time_t overflow. You can't compare by subtracting!
1064 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1065 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1066
1067 * term.c: Include <sys/time.h>.
1068 (timeval_to_Time): New function, for proper overflow wraparound.
1069 (term_mouse_position, term_mouse_click): Use it.
1070
1071 * undo.c (record_first_change): Support higher-resolution time stamps
1072 in the undo buffer.
1073 (Fprimitive_undo): Use them when restoring time stamps.
1074
1075 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1076 (w32_get_internal_run_time):
1077 Port to higher-resolution Emacs time stamps.
1078 (ltime): Now accepts single 64-bit integer, as that's more convenient
1079 for callers.
1080
1081 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1082
1083 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1084 for compatibility with pselect. Support ns-resolution time stamps.
1085
1086 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1087
1088 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1089 Check for time stamp overflow, and support ns-resolution time stamps.
1090
1091 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1092 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1093 (timeval_subtract): Remove; no longer needed.
1094 (XTflash, XTring_bell, x_wait_for_event):
1095 Port to ns-resolution time stamps. Don't assume time_t is signed.
1096
b6a92dfe
CY
10972012-06-22 Chong Yidong <cyd@gnu.org>
1098
1099 * xdisp.c (x_consider_frame_title): Revert last change.
1100
d251c37c
EZ
11012012-06-22 Eli Zaretskii <eliz@gnu.org>
1102
1103 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1104 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1105 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1106 staticidx goes up to 1597 out of 1600 = 0x640.)
1107
f10deafb
PE
11082012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1111 Otherwise, the umask might be mistakenly 0 while handling input signals.
1112
ec6de1e2
SM
11132012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1114
1115 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1116
28be1ada
DA
11172012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1118
1119 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1120 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1121 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1122 access to `contents' member of Lisp_Vector objects with AREF and ASET
1123 where appropriate.
1124
c6bf3022
CY
11252012-06-19 Chong Yidong <cyd@gnu.org>
1126
1127 * frame.c (delete_frame): When selecting a frame on a different
1128 text terminal, do not alter the terminal's top-frame.
1129
1130 * xdisp.c (format_mode_line_unwind_data): Record the target
1131 frame's selected window and its terminal's top-frame.
1132 (unwind_format_mode_line): Restore them.
1133 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1134 Callers changed.
1135 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1136 since tty frames can be explicitly named.
1137 (prepare_menu_bars): Likewise.
1138
1139 * term.c (Ftty_top_frame): New function.
1140
defd4196
PE
11412012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1142
1143 Port byte-code-meter to modern targets.
1144 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1145 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1146 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1147 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1148 (METER_1, METER_2): Simplify.
1149
1053a871
SM
11502012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1151
1152 * data.c (Fdefalias): Return `symbol' (bug#11686).
1153
b7e8d081
MR
11542012-06-18 Martin Rudalics <rudalics@gmx.at>
1155
1156 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1157 gets killed during executing of this function (Bug#11665).
1158 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1159 (Vkill_buffer_query_functions): In doc-string say that functions
1160 run by this hook should not change the current buffer.
1161
7ea2b339
PE
11622012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 Fix recently-introduced process.c problems found by static checking.
1165 * process.c (write_queue_push, write_queue_pop, send_process):
1166 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1167 (write_queue_pop): Fix pointer signedness problem.
1168 (send_process): Remove unused local.
1169
96a313a1
CY
11702012-06-17 Chong Yidong <cyd@gnu.org>
1171
1172 * xdisp.c (redisplay_internal): No need to redisplay terminal
1173 frames that are not on top.
1174
20ca2e94
TN
11752012-06-17 Troels Nielsen <bn.troels@gmail.com>
1176
1177 * process.c (make_process): Initialize write_queue.
1178 (write_queue_push, write_queue_pop): New functions.
1179 (send_process): Use them to maintain correct ordering of process
1180 writes (Bug#10815).
1181
9a900ca9
PE
11822012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1183
310fbfa8
PE
1184 * lisp.h (eassert): Assume C89 or later.
1185 This removes the need for CHECK.
1186 (CHECK): Remove. Its comments about always evaluating its
1187 argument were confusing, as 'eassert' typically does not evaluate
1188 its argument.
1189
27bb1ca4
PE
1190 * coding.c (produce_chars): Use ptrdiff_t, not int.
1191
9a900ca9
PE
1192 * xterm.c (x_draw_underwave): Check for integer overflow.
1193 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1194
41b7f8bc 11952012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1196
1197 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1198 referenced (Bug#11583).
1199
9b0e3eba
AA
12002012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1201
1202 Implement wave-style variant of underlining.
1203 * dispextern.h (face_underline_type): New enum.
1204 (face): Add field for underline type.
1205 * nsterm.m (ns_draw_underwave): New function.
1206 (ns_draw_text_decoration): Use it.
1207 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1208 New functions.
1209 (x_draw_glyph_string): Use them.
1210 * xfaces.c (Qline, Qwave): New Lisp objects.
1211 (check_lface_attrs, merge_face_ref)
1053a871
SM
1212 (Finternal_set_lisp_face_attribute, realize_x_face):
1213 Handle wave-style underline face attributes.
9b0e3eba
AA
1214 * xterm.c (x_draw_underwave): New function.
1215 (x_draw_glyph_string): Use it.
1216
0fb52f11
JB
12172012-06-16 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1220 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1221 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1222 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1223 ($(BLD)/w32select.$(O)): Update dependencies.
1224
e5560ff7
AS
12252012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1226
1227 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1228 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1229 * character.c (_fetch_multibyte_char_p): Remove.
1230 * alloc.c: Include "character.h" before "buffer.h".
1231 * bidi.c: Likewise.
1232 * buffer.c: Likewise.
1233 * bytecode.c: Likewise.
1234 * callint.c: Likewise.
1235 * callproc.c: Likewise.
1236 * casefiddle.c: Likewise.
1237 * casetab.c: Likewise.
1238 * category.c: Likewise.
1239 * cmds.c: Likewise.
1240 * coding.c: Likewise.
1241 * composite.c: Likewise.
1242 * dired.c: Likewise.
1243 * dispnew.c: Likewise.
1244 * doc.c: Likewise.
1245 * dosfns.c: Likewise.
1246 * editfns.c: Likewise.
1247 * emacs.c: Likewise.
1248 * fileio.c: Likewise.
1249 * filelock.c: Likewise.
1250 * font.c: Likewise.
1251 * fontset.c: Likewise.
1252 * fringe.c: Likewise.
1253 * indent.c: Likewise.
1254 * insdel.c: Likewise.
1255 * intervals.c: Likewise.
1256 * keyboard.c: Likewise.
1257 * keymap.c: Likewise.
1258 * lread.c: Likewise.
1259 * macros.c: Likewise.
1260 * marker.c: Likewise.
1261 * minibuf.c: Likewise.
1262 * nsfns.m: Likewise.
1263 * nsmenu.m: Likewise.
1264 * print.c: Likewise.
1265 * process.c: Likewise.
1266 * regex.c: Likewise.
1267 * region-cache.c: Likewise.
1268 * search.c: Likewise.
1269 * syntax.c: Likewise.
1270 * term.c: Likewise.
1271 * textprop.c: Likewise.
1272 * undo.c: Likewise.
1273 * unexsol.c: Likewise.
1274 * w16select.c: Likewise.
1275 * w32fns.c: Likewise.
1276 * w32menu.c: Likewise.
1277 * window.c: Likewise.
1278 * xdisp.c: Likewise.
1279 * xfns.c: Likewise.
1280 * xmenu.c: Likewise.
1281 * xml.c: Likewise.
1282 * xselect.c: Likewise.
1283
2f07e6af
EZ
12842012-06-16 Eli Zaretskii <eliz@gnu.org>
1285
1053a871
SM
1286 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1287 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1288 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1289 row.
1290 (handle_face_prop): Use chunk-relative overlay string index when
1291 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1292 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1293 the rightmost. (Bug#11720)
2f07e6af 1294
29b83cec
AS
12952012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1296
1297 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1298 (CATEGORY_MEMBER): Enforce 1/0 value.
1299 * category.c (_temp_category_set): Remove.
1300
4c5501e9
EZ
13012012-06-16 Eli Zaretskii <eliz@gnu.org>
1302
1303 * window.c (Fdelete_other_windows_internal)
1304 (Fdelete_window_internal): Don't access frame's mouse highlight
1305 info of the initial frame. (Bug#11677)
1306
2b570124
PE
13072012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1308
e93864f9
PE
1309 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1310 Assume USE_2_TAGS_FOR_INTS.
1311 (xreload): Adjust $tagmask width to match recent lisp.h change.
1312
2b570124
PE
1313 Simplify lisp.h in minor ways that should not affect code.
1314 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1315 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1316 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1317 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1318 (INTTYPEBITS): New macro, for clarity.
1319 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1320 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1321 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1322 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1323 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1324
81755f69
JB
13252012-06-13 Juanma Barranquero <lekktu@gmail.com>
1326
1327 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1328
16192a57
GM
13292012-06-13 Glenn Morris <rgm@gnu.org>
1330
1331 * s/bsd-common.h (BSD4_3):
1332 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1333
646b5f55
AS
13342012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1335
1336 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1337 instead of union.
1338 (XLI, XIL): Define.
1053a871
SM
1339 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1340 Use them.
1341 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1342 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1343 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1344 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1345 * frame.c (delete_frame): Remove outdated comment.
1346 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1347 USE_LISP_UNION_TYPE.
1348 (Fw32_unregister_hot_key): Likewise.
1349 (Fw32_toggle_lock_key): Likewise.
1350 * w32menu.c (add_menu_item): Likewise.
1351 (w32_menu_display_help): Use XIL instead of checking
1352 USE_LISP_UNION_TYPE.
1353 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1354 (init_heap): Likewise.
1355 * w32term.c (w32_read_socket): Update comment.
1356
1d3823c9
GM
13572012-06-13 Glenn Morris <rgm@gnu.org>
1358
c62ff706
GM
1359 * s/usg5-4-common.h, src/s/unixware.h:
1360 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1361
1d3823c9
GM
1362 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1363
bfe3e0a2
PE
13642012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1367 * alloc.c (make_number) [!defined make_number]:
1368 Remove, as lisp.h always defines this now.
1369 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1370 (roundup_size): Verify that it is a power of 2.
1371 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1372 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1373 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1374 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1375 USE_LSB_TAG now is always defined to be either 0 or 1.
1376 All uses changed.
1377 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1378 code works fine either way, and efficiency is not a concern here,
1379 as the union type is for debugging, not for production.
1380 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1381 Use an inline function on all platforms when using the union type,
1382 since this is simpler and 'static inline' can be used portably
1383 within Emacs now.
1384 (LISP_INITIALLY_ZERO): New macro.
1385 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1386 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1387
45fa9c0f
GM
13882012-06-12 Glenn Morris <rgm@gnu.org>
1389
b4492cba
GM
1390 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1391
1392 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1393
45fa9c0f
GM
1394 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1395 Move BROKEN_SIGIO to configure.
1396
1397 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1398 Move NO_TERMIO to configure.
1399
0e25d334
CY
14002012-06-12 Chong Yidong <cyd@gnu.org>
1401
1402 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1403 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1404 MagickExportImagePixels is undefined.
1405
43682bb6
PE
14062012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1407
1408 * image.c (imagemagick_load_image): Remove unused label.
1409
a9be7d2b
GM
14102012-06-11 Glenn Morris <rgm@gnu.org>
1411
1412 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1413 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1414 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1415 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1416
3017f87f
SM
14172012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * alloc.c (make_byte_code): New function.
1420 (Fmake_byte_code): Use it. Don't purify here.
1421 * lread.c (read1): Use it as well to avoid extra allocation.
1422
1b9b4cf4
CY
14232012-06-11 Chong Yidong <cyd@gnu.org>
1424
1425 * image.c (imagemagick_load_image): Implement transparency.
1426
95988fcf
AS
14272012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1428
1429 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1430 account for preceding backslashes. (Bug#11663)
1431
cd4eb164
CY
14322012-06-09 Chong Yidong <cyd@gnu.org>
1433
1434 * term.c: Support italics in capable terminals (Bug#9652).
1435 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1436 (turn_on_face): Output using TS_enter_italic_mode if available.
1437 Don't handle unused blinking and alt-charset cases.
1438 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1439 and tty_alt_charset_p cases.
1440 (tty_capable_p, init_tty): Support italics.
1441
1442 * termchar.h (struct tty_display_info): Add field for italics.
1443 Remove unused blink field.
1444
1445 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1446 Handle slant.
1447
1448 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1449 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1450 tty_alt_charset_p. Add tty_italic_p.
1451
ff88beb8
MA
14522012-06-09 Michael Albinus <michael.albinus@gmx.de>
1453
1454 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1455 dbus_type_is_basic if available.
1456 (xd_extract_signed, xd_extract_unsigned): Rename from
1457 extract_signed and extract_unsigned, respectively. Adapt callers.
1458
44286096
CY
14592012-06-09 Chong Yidong <cyd@gnu.org>
1460
1682701f
CY
1461 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1462
44286096
CY
1463 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1464 case (Bug#9752).
1465
d86feb17
PE
14662012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 * xdisp.c (vmessage): Treat frame message as multibyte.
1469 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1470 would generate the diagnostic "Making \302\247 buffer-local while
1471 let-bound!".
1472
d5c20fe8
EZ
14732012-06-08 Eli Zaretskii <eliz@gnu.org>
1474
1475 * dispnew.c (showing_window_margins_p): Undo last change, which
1476 was done due to an inadvertent commit.
1477 (adjust_frame_glyphs_for_frame_redisplay): Do call
1478 showing_window_margins_p.
1479
513749ee
SM
14802012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1481
1482 * eval.c (Fmake_var_non_special): New primitive.
1483 (syms_of_eval): Defsubr it.
1484 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1485
d4a8f5c1
JB
14862012-06-08 Juanma Barranquero <lekktu@gmail.com>
1487
1488 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1489 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1490
8bbbc977
EZ
14912012-06-08 Eli Zaretskii <eliz@gnu.org>
1492
1493 * alloc.c (allocate_vectorlike): Fix last change.
1494
f3372c87
DA
14952012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1496
1497 Block-based vector allocation of small vectors.
1498 * lisp.h (struct vectorlike_header): New field `nbytes',
1499 adjust comment accordingly.
1500 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1501 to denote vector blocks. Adjust users (live_vector_p,
1502 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1503 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1504 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1505 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1506 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1507 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1508 (roundup_size): New constant.
1509 (struct vector_block): New data type.
1510 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1511 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1512 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1513 (sweep_vectors): New functions.
1514 (allocate_vectorlike): Return `zero_vector' as the only vector of
1515 0 items. Allocate new vector from block if vector size is less than
1516 or equal to VBLOCK_BYTES_MAX.
1517 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1518 (init_alloc_once): Add call to init_vectors.
1519
4f18a4ed
SM
15202012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1521
1522 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1523
86f158bc
PE
15242012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1525
1526 * doprnt.c (doprnt): Truncate multibyte char correctly.
1527 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1528 would mishandle a string argument "Xc" if X was a multibyte
1529 character of length 2: it would truncate after X's first byte
1530 rather than including all of X.
1531
c5cfcbe0
CY
15322012-06-06 Chong Yidong <cyd@gnu.org>
1533
1534 * buffer.c (word_wrap): Doc fix.
1535
c05cf390
PE
15362012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1537
1538 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1539
0c3461de
GM
15402012-06-03 Glenn Morris <rgm@gnu.org>
1541
1542 * xdisp.c (tool-bar-style): Doc fix.
1543
c71232db
UM
15442012-06-03 Ulrich Müller <ulm@gentoo.org>
1545
1546 * Makefile.in (PAXCTL): Define.
1547 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1548 binary via PaX flags if the paxctl utility is available.
1549 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1550 Restore PaX flags to their default. (Bug#11398)
1551
383f7350
CY
15522012-06-03 Chong Yidong <cyd@gnu.org>
1553
1554 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1555 buffer (Bug#11226).
1556
5f2c76c6
CY
15572012-06-03 Chong Yidong <cyd@gnu.org>
1558
1559 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1560 (note_mode_line_or_margin_highlight): If there is no help echo,
1561 use mode-line-default-help-echo. Handle the case where the mouse
1562 position is past the end of the mode line string.
1563
1564 * buffer.c (buffer_local_value_1): New function, split from
1565 Fbuffer_local_value; can return Qunbound.
1566 (Fbuffer_local_value): Use it.
1567 (Vmode_line_format): Docstring tweaks.
1568
773d47f6
PE
15692012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1570
1571 * sysdep.c (system_process_attributes): Improve comment.
1572
f2d6a3df
SM
15732012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1574
1575 * keyboard.c: Export real-this-command to Elisp.
1576 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1577 and DEFVAR it. Update all users.
1578
63810350
PE
15792012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1580
7bd5c1f4
PE
1581 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1582
63810350
PE
1583 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1584 Convert pctcpu and pctmem to Lisp float properly.
1585 Let the compiler fold better, as 100.0/0x8000 is exact.
1586
a2821611
AS
15872012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1588
1589 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1590 cons_block.
1591
5fceba1d
PE
15922012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1595
c98ff5dd
DA
15962012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1597
1598 For a 'struct window', replace some Lisp_Object fields to
1599 bitfields where appropriate, remove unused fields.
1600 * window.h (struct window): Remove unused 'last_mark_x' and
1601 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1602 change it's type from Lisp_Object to bitfield.
1603 Change type of 'force_start', 'optional_new_start',
1604 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1605 fields from Lisp_Object to bitfield. Adjust users accordingly.
1606
ca34e0be
PE
16072012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1608
1609 Pacify gcc -Wdouble-precision when using Xaw.
1610 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1611 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1612 Use 'float' consistently, rather than 'float' in most places
1613 and 'double' in a couple of places.
1614
efc00ab1 16152012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1616
1617 * xdisp.c (handle_stop): Detect whether we have overlay strings
1618 loaded by testing it->current.overlay_string_index to be
1619 non-negative, instead of checking whether n_overlay_strings is
1620 positive. (Bug#11587)
1621
efc00ab1 16222012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1623
1624 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1625
1626 * doc.c (Fsubstitute_command_keys): Doc fix.
1627
efc00ab1 16282012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1629
1630 * search.c (search_buffer): Remove calls to
1631 r_alloc_inhibit_buffer_relocation, as it is now called by
1632 maybe_unify_char, which was the cause of relocation of buffer text
1633 in bug#11519.
1634
efc00ab1 16352012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1636
1637 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1638 for the duration of call to load_charset, to avoid problems with
1639 callers of maybe_unify_char that access buffer text through C
1640 pointers.
1641
1642 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1643 decrement the inhibition flag, instead of just setting or
1644 resetting it.
1645
ba93a187
PE
16462012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1647
1648 Remove obsolete '#define static' cruft.
1649 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1650 This #undef was "temporary" in 2000; it is no longer needed
1651 now that '#define static' has gone away.
1652 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1653 (gray_bitmap_bits): Remove; no longer needed.
1654 All uses replaced with definiens.
1655 * xterm.c: Include "bitmaps/gray.xbm".
1656
9e4bf381
PE
16572012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 Clean up __executable_start, monstartup when --enable-profiling.
1660 The following changes affect the code only when profiling.
1661 * dispnew.c (__executable_start): Rename from safe_bcopy.
1662 Define only on platforms that need it.
1663 * emacs.c: Include <sys/gmon.h> when profiling.
1664 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1665 (__executable_start): Remove decl, since lisp.h does it now.
1666 (safe_bcopy): Remove decl; no longer has that name.
1667 (main): Coalesce #if into single bit of code, for simplicity.
1668 Cast pointers to uintptr_t, since standard libraries want integers
1669 and not pointers.
1670 * lisp.h (__executable_start): New decl.
1671
32d72c2f
GM
16722012-05-31 Glenn Morris <rgm@gnu.org>
1673
1674 * image.c (Fimagemagick_types): Doc fix.
1675
baac5bc7
JM
16762012-05-30 Jim Meyering <meyering@redhat.com>
1677
1678 * callproc.c (Fcall_process_region): Include directory component
1679 in mkstemp error message (Bug#11586).
1680
72cb32cf
PE
16812012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1682
1683 * alloc.c, lisp.h (make_pure_vector): Now static.
1684
61b108cc
SM
16852012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1686
1687 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1688 Move to byte-run.el.
1689 (Fautoload): Do the hash-doc more carefully.
1690 * data.c (Fdefalias): Purify definition, except for keymaps.
1691 (Qdefun): Move from eval.c.
1692 * lisp.h (Qdefun): Remove.
1693 * lread.c (read1): Tiny simplification.
1694
471fe23d
TN
16952012-05-29 Troels Nielsen <bn.troels@gmail.com>
1696
934f3f58 1697 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1698 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1699 Bug#9642, but explicitly check that the buffer the overlay would
1700 be moved to is live and rearrange lines to make sure that errors
1701 will not put the overlay in an inconsistent state.
1702 (Fdelete_overlay): Cosmetics.
1703
85d0efd1
EZ
17042012-05-28 Eli Zaretskii <eliz@gnu.org>
1705
1706 * w32term.c (my_bring_window_to_top): New function.
1707 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1708 could be different from the original one.
1709 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1710 (Bug#11513)
1711
1712 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1713 by calling BringWindowToTop.
1714
1715 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1716 (WM_EMACS_END): Increase by one.
1717
da92a98c
PE
17182012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1719
1720 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1721 This avoids undefined behavior that might cause the eassert
1722 to not catch an out-of-range value.
1723
74d1f848
JB
17242012-05-28 Juanma Barranquero <lekktu@gmail.com>
1725
1726 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1727 Update dependencies.
1728
9e1a06fc
EZ
17292012-05-27 Eli Zaretskii <eliz@gnu.org>
1730
1731 * bidi.c (bidi_mirror_char): Fix last change.
1732
f3dd7312
AS
17332012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1734
1735 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1736 when referring to sectname field in printf format.
1737
81899c91
PE
17382012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1739
57b81a9f
PE
1740 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1741 Only r_alloc_inhibit_buffer_relocation needed to be added;
1742 the others were already declared.
1743
81899c91
PE
1744 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1745 before checking whether it's out of range. Put the check inside
1746 eassert. See
1747 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1748
33017faf 17492012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1750
1751 * callproc.c (Fcall_process): Restore a line that was accidentally
1752 commented out in the 2011-02-13 change (bug#11547).
1753
33017faf 17542012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1755
1756 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1757 defined on ralloc.c.
1758
1759 * buffer.c [REL_ALLOC]: Remove prototypes of
1760 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1761 they are now on lisp.h.
1762
1763 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1764
1765 * search.c (search_buffer): Use it to inhibit relocation of buffer
1766 text while re_search_2 is doing its job, because re_search_2 is
1767 passed C pointers to buffer text. (Bug#11519)
1768
23415acf
EZ
1769 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1770 Update value to 24.
1771
44e27368
EZ
1772 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1773 state after an additional call to move_it_in_display_line_to, keep
1774 the values of it->max_ascent and it->max_descent found for the
1775 entire line.
1776 (pos_visible_p): Revert the comparison against bottom_y to what it
1777 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1778 (Bug#11464)
1779
c1892f11
PE
17802012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1781
1782 Fix coding-related core dumps with gcc -ftrapv.
1783 The code was computing A - B, where A and B are pointers, and B is
1784 random garbage. This can lead to core dumps on platforms that
1785 have special pointer registers, and it also leads to core dumps on
1786 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1787 A - B only when B is initialized properly.
1788 * coding.c (coding_set_source, coding_set_destination): Return void.
1789 (coding_change_source, coding_change_destinations): New functions,
1790 with the old behaviors of coding_set_source and coding_set_destination.
1791 All callers that need an offset changed to use these new functions.
1792
eb7afdad
GM
17932012-05-26 Glenn Morris <rgm@gnu.org>
1794
1795 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1796
f12fdf02
EZ
17972012-05-26 Eli Zaretskii <eliz@gnu.org>
1798
53a63be6 1799 Extend mouse support on W32 text-mode console.
61b108cc
SM
1800 * xdisp.c (draw_row_with_mouse_face):
1801 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1802
eb3f6f01 1803 * w32console.c: Include window.h.
61b108cc
SM
1804 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1805 New functions.
eb3f6f01
EZ
1806 (initialize_w32_display): Initialize mouse-highlight data.
1807
53a63be6
EZ
1808 * w32inevt.c: Include termchar.h and window.h.
1809 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1810 moves, call note_mouse_highlight. If help_echo changed, call
1811 gen_help_event to produce help-echo message in the echo area.
1812 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1813 highlight info.
1814
4cfd81f6
PE
18152012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 * lread.c (read1): Simplify slightly to avoid an overflow warning
1818 with GCC 4.7.0 on x86-64.
1819
4446092a
EZ
18202012-05-26 Eli Zaretskii <eliz@gnu.org>
1821
1822 * bidi.c (bidi_mirror_char): Revert last change: an int is
1823 definitely wide enough here.
1824
42b2a986 18252012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1826
42b2a986 1827 Fix integer width and related bugs (Bug#9874).
eb106a49 1828 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1829 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1830 (string_bytes, check_sblock, allocate_string_data):
1831 (compact_small_strings, Fmake_bool_vector, make_string)
1832 (make_unibyte_string, make_multibyte_string)
1833 (make_string_from_bytes, make_specified_string)
1834 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1835 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1836 (mark_vectorlike):
1837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1838 (allocate_pseudovector):
1839 Use int, not EMACS_INT, where int is wide enough.
1840 (inhibit_garbage_collection, Fgarbage_collect):
1841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1842 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1843 int might not be wide enough.
1844 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1845 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1846 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1847 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1848 (bidi_level_of_next_char, bidi_move_to_visually_next):
1849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1850 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1851 (Fkill_buffer, Fset_buffer_major_mode)
1852 (advance_to_char_boundary, Fbuffer_swap_text)
1853 (Fset_buffer_multibyte, overlays_at, overlays_in)
1854 (overlay_touches_p, struct sortvec, record_overlay_string)
1855 (overlay_strings, recenter_overlay_lists)
1856 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1857 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1858 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1859 (Foverlay_recenter, last_overlay_modification_hooks_used)
1860 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1862 (validate_region): Omit unnecessary test for b <= e,
1863 since that's guaranteed by the previous test.
d311d28c
PE
1864 (adjust_overlays_for_delete): Avoid pos + length overflow.
1865 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1866 (report_overlay_modification):
1867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1868 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1869 Omit pointer cast, which isn't needed anyway, and doesn't work
1870 after the EMACS_INT -> ptrdiff_t change.
02481186 1871 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1872 * buffer.h: Adjust decls to match defn changes elsewhere.
1873 (struct buffer_text, struct buffer):
1874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1875 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1876 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1877 not int, to avoid needless 32-bit limit on 64-bit hosts.
1878 (exec_byte_code): Use tighter memory-full test, one that checks
1879 for alloca overflow. Don't compute the address of the object just
1880 before an array, as that's not portable. Use EMACS_INT, not
1881 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1882 * callint.c (Fcall_interactively):
1883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1884 * callproc.c (call_process_kill, Fcall_process):
1885 Don't assume pid_t fits into an Emacs fixnum.
1886 (call_process_cleanup, Fcall_process, child_setup):
1887 Don't assume pid_t fits into int.
1888 (call_process_cleanup, Fcall_process, delete_temp_file)
1889 (Fcall_process_region):
1890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1891 (Fcall_process): Simplify handling of volatile integers.
1892 Use int, not EMACS_INT, where int will do.
1893 * casefiddle.c (casify_object, casify_region, operate_on_word)
1894 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1895 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1896 (casify_object): Avoid integer overflow when overallocating buffer.
1897 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1898 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1899 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1900 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1901 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1902 integers are now checked earlier. All uses replaced with XINT.
1903 (ccl_driver):
1904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1905 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1906 (ccl_driver, Fregister_code_conversion_map):
1907 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1908 (resolve_symbol_ccl_program): Check that vector header is in range.
1909 Always copy the vector, so that we can check its contents reliably
1910 now rather than having to recheck each instruction as it's being
1911 executed. Check that vector words fit in 'int'.
1912 (ccl_get_compiled_code, Fregister_ccl_program)
1913 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1914 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1915 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1916 contents are in range.
1917 (Fccl_execute_on_string): Check that status is in range.
1918 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1919 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1920 Accept and return EMACS_INT, not int, because callers can pass values
1921 out of 'int' range.
1922 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1923 (multibyte_chars_in_text, parse_str_as_multibyte)
1924 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1925 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1926 (string_escape_byte8, Fget_byte):
1927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1928 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1929 avoid mishandling large integers.
1930 * character.h: Adjust decls to match defn changes elsewhere.
1931 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1932 (Ffind_charset_region):
1933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1934 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1935 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1936 Don't assume fixnum fits in int.
d311d28c
PE
1937 (load_charset_map_from_vector, Fmap_charset_chars):
1938 Remove now-unnecessary CHECK_NATNUMs.
1939 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1940 Don't rely on undefined behavior with signed left shift overflow.
1941 Don't assume unsigned int fits into fixnum, or that fixnum fits
1942 into unsigned int. Don't require max_code to be a valid fixnum;
1943 that's not true for gb10830 4-byte on a 32-bit host. Allow
1944 invalid_code to be a cons, for the same reason. Require code_offset
1945 to be a character. Avoid int overflow if max_char is close
1946 to INT_MAX.
1947 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1948 this is intended anyway and avoids some undefined behavior.
1949 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1950 INDEX_TO_CODE_POINT, as that's what it expects.
1951 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1952 * charset.h (DECODE_CHAR): Return int, not unsigned;
1953 this is what was intended anyway, and it avoids undefined behavior.
1954 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1955 integer-overflow issues.
1956 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1957 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1958 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1959 * chartab.c (Fmake_char_table, Fset_char_table_range)
1960 (uniprop_get_decoder, uniprop_get_encoder):
1961 Don't assume fixnum fits in int.
1962 * cmds.c (move_point): New function, that does the gist of
1963 Fforward_char and Fbackward_char, but does so while checking
1964 for integer overflow more accurately.
c96e5d6a 1965 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1966 (Fforward_line, Fend_of_line, internal_self_insert)
1967 (internal_self_insert):
1968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1969 Fix a FIXME, by checking for integer overflow when calculating
1970 target_clm and actual_clm.
1971 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1972 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1973 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1974 (coding_alloc_by_making_gap, alloc_destination)
1975 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1976 (encode_coding_utf_16, detect_coding_emacs_mule)
1977 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1978 (detect_coding_iso_2022, decode_coding_iso_2022)
1979 (encode_invocation_designation, encode_designation_at_bol)
1980 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1981 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1982 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1983 (encode_coding_ccl, encode_coding_raw_text)
1984 (detect_coding_charset, decode_coding_charset)
1985 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1986 (produce_composition, produce_charset, produce_annotation)
1987 (decode_coding, handle_composition_annotation)
1988 (handle_charset_annotation, consume_chars, decode_coding_gap)
1989 (decode_coding_object, encode_coding_object, detect_coding_system)
1990 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1991 (code_convert_region, code_convert_string)
8f50130c
PE
1992 (Fdefine_coding_system_internal)
1993 (coding_set_source, coding_set_destination):
d311d28c
PE
1994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1995 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1996 (Fdefine_coding_system_internal):
1997 Don't assume fixnums fit in int.
1998 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1999 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2000 (Funencodable_char_position, Fcheck_coding_systems_region)
2001 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2003 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2004 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2005 Don't access memory outside of the args array.
d311d28c 2006 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2007 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2008 result of ENCODE_CHAR.
d311d28c
PE
2009 * coding.h: Adjust decls to match defn changes elsewhere.
2010 (struct coding_system):
2011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2012 * composite.c (get_composition_id, find_composition)
2013 (run_composition_function, update_compositions)
2014 (compose_text, composition_gstring_put_cache)
2015 (composition_gstring_p, composition_gstring_width)
2016 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2017 (composition_compute_stop_pos, composition_reseat_it)
2018 (composition_update_it, struct position_record)
2019 (find_automatic_composition, composition_adjust_point)
2020 (Fcomposition_get_gstring, Ffind_composition_internal):
2021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2022 (update_compositions):
2023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2024 * composite.h: Adjust decls to match defn changes elsewhere.
2025 (struct composition):
2026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2027 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2028 Do not attempt to compute the address of the object just before a
2029 buffer; this is not portable.
2030 (Faref, Faset):
2031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2032 (Faset): Use int, not EMACS_INT, where int is wide enough.
2033 (Fstring_to_number): Don't assume fixnums fit in int.
2034 (Frem): Don't assume arg is nonnegative.
2035 * dbusbind.c (xd_append_arg): Check for integers out of range.
2036 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2037 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2038 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2039 (xd_get_connection_references): Return ptrdiff_t, not int.
2040 All uses changed.
2041 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2042 (xd_read_message_1):
2043 Use int, not unsigned, where the dbus API uses int.
2044 (Fdbus_message_internal): Don't overflow mtype.
2045 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2046 * dired.c (directory_files_internal, file_name_completion, scmp)
2047 (file_name_completion_stat):
2048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2049 (file_name_completion): Don't overflow matchcount.
2050 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2051 * dispextern.h: Adjust decls to match defn changes elsewhere.
2052 (struct text_pos, struct glyph, struct bidi_saved_info)
2053 (struct bidi_string_data, struct bidi_it, struct composition_it)
2054 (struct it):
2055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2056 (struct display_pos, struct composition_it, struct it):
2057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2058 * dispnew.c (increment_matrix_positions)
2059 (increment_row_positions, mode_line_string)
2060 (marginal_area_string):
2061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2062 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2064 (duration_to_sec_usec): New function, to check for overflow better.
2065 (Fsleep_for, sit_for): Use it.
2066 * doc.c (get_doc_string, store_function_docstring):
2067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2068 (get_doc_string, Fsnarf_documentation):
2069 Use int, not EMACS_INT, where int is wide enough.
2070 (get_doc_string):
2071 Use SAFE_ALLOCA, not alloca.
2072 Check for overflow when converting EMACS_INT to off_t.
2073 * doprnt.c (doprnt):
2074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2075 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2076 Don't assume uid_t fits into fixnum.
2077 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2078 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2079 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2080 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2081 (general_insert_function)
2082 (Finsert_char, make_buffer_string, make_buffer_string_both)
2083 (update_buffer_properties, Fbuffer_substring)
2084 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2085 (Fsubst_char_in_region, check_translation)
2086 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2087 (transpose_markers, Ftranspose_regions):
2088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2089 (clip_to_bounds): Move to lisp.h as an inline function).
2090 (Fconstrain_to_field): Don't assume integers are nonnegative.
2091 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2092 (Fsubst_char_in_region, Fsave_restriction):
2093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2094 (Femacs_pid): Don't assume pid_t fits into fixnum.
2095 (lo_time): Use int, not EMACS_INT, when int suffices.
2096 (lisp_time_argument): Check for usec out of range.
2097 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2098 (Fuser_login_name, Fuser_full_name): Signal an error
2099 if a uid argument is out of range, rather than relying on
2100 undefined behavior.
c8d5c857
PE
2101 (Fformat_time_string): Remove now-unnecessary check.
2102 lisp_time_argument checks for out-of-range usec now.
243e0530 2103 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2104 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2105 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2106 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2107 (init_cmdargs, Fdump_emacs):
2108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2109 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2110 the bottom (typically) 32 bits of the fixnum.
2111 * eval.c (specpdl_size, call_debugger):
2112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2113 (when_entered_debugger, Fbacktrace_debug):
2114 Don't assume fixnum can fit in int.
2115 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2116 the object just before a buffer; this is not portable.
2117 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2118 (grow_specpdl, unbind_to):
2119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2120 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2121 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2122 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2123 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2124 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2126 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2127 (a_write, e_write):
2128 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2129 (Fcopy_file, non_regular_nbytes, read_non_regular)
2130 (Finsert_file_contents):
2131 Use int, not EMACS_INT, where int is wide enough.
2132 (READ_BUF_SIZE): Verify that it fits in int.
2133 (Finsert_file_contents): Check that counts are in proper range,
2134 rather than assuming fixnums fit into ptrdiff_t etc.
2135 Don't assume fixnums fit into int.
125b3835 2136 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2137 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2138 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2139 (string_char_to_byte, string_byte_to_char)
2140 (string_make_multibyte, string_to_multibyte)
2141 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2142 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2143 (substring_both, Fdelete, internal_equal, Ffillarray)
2144 (Fclear_string, mapcar1)
2145 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2146 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2147 (larger_vector, make_hash_table, maybe_resize_hash_table)
2148 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2149 (Fmaphash, secure_hash):
2150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2151 (concat): Check for string index and length overflow.
2152 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2153 (Frequire):
2154 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2155 (larger_vector): New API (vec, incr_min, size_max) replaces old
2156 one (vec, new_size, init). This catches size overflow.
2157 INIT was removed because it was always Qnil.
2158 All callers changed.
2159 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2160 the upper bound on a hash table index size.
2161 (make_hash_table, maybe_resize_hash_table): Use it.
2162 (secure_hash): Computer start_byte and end_byte only after
2163 they're known to be in ptrdiff_t range.
2164 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2165 (Ffont_get_glyphs, Ffont_at):
2166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2167 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2168 (Flist_fonts, Fopen_font):
2169 Don't assume fixnum can fit in int.
2170 (check_gstring): Don't assume index can fit in int.
2171 (font_match_p): Check that fixnum is a character, not a nonnegative
2172 fixnum, since the later code needs to stuff it into an int.
2173 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2174 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2175 conversion overflow issues.
2176 (Fopen_font): Check for integer out of range.
2177 (Ffont_get_glyphs): Don't assume index can fit in int.
2178 * font.h: Adjust decls to match defn changes elsewhere.
2179 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2180 integer overflow.
2181 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2182 printmax_t, where ptrdiff_t is wide enough.
2183 (Finternal_char_font):
2184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2185 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2186 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2187 (Fset_frame_position, x_set_frame_parameters)
2188 (x_set_line_spacing, x_set_border_width)
2189 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2190 Check that fixnums are in proper range for system types.
2191 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2193 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2194 Use SAFE_ALLOCA_LISP, not alloca.
2195 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2196 intptr_t is wide enough.
2197 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2198 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2199 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2200 Check for fixnum out of range.
2201 * ftfont.c (ftfont_list): Don't assume index fits in int.
2202 Check that fixnums are in proper range for system types.
2203 (ftfont_shape_by_flt):
2204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2205 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2207 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2208 Check that fixnums are in proper range for system types.
2209 * gnutls.h: Adjust decls to match defn changes elsewhere.
2210 * gtkutil.c (xg_dialog_run):
2211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2212 (update_frame_tool_bar):
2213 Check that fixnums are in proper range for system types.
2214 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2215 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2216 * indent.c (last_known_column, last_known_column_point):
2217 (current_column_bol_cache):
2218 (skip_invisible, current_column, check_display_width):
2219 (check_display_width, scan_for_column, current_column_1)
2220 (Findent_to, Fcurrent_indentation, position_indentation)
2221 (indented_beyond_p, Fmove_to_column, compute_motion):
2222 (Fcompute_motion, Fvertical_motion):
2223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2224 (last_known_column_modified): Use EMACS_INT, not int.
2225 (check_display_width):
2226 (Fcompute_motion):
2227 Check that fixnums and floats are in proper range for system types.
2228 (compute_motion): Don't assume index or fixnum fits in int.
2229 (compute_motion, Fcompute_motion):
2230 Use int, not EMACS_INT, when it is wide enough.
2231 (vmotion): Omit local var start_hpos that is always 0; that way
2232 we don't need to worry about overflow in expressions involving it.
2233 * indent.h: Adjust decls to match defn changes elsewhere.
2234 (struct position):
2235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2236 Use int, not EMACS_INT, where int is wide enough.
2237 Remove unused members ovstring_chars_done and tab_offset;
2238 all uses removed.
2239 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2240 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2241 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2242 (make_gap, copy_text, insert, insert_and_inherit)
2243 (insert_before_markers, insert_before_markers_and_inherit)
2244 (insert_1, count_combining_before, count_combining_after)
2245 (insert_1_both, insert_from_string)
2246 (insert_from_string_before_markers, insert_from_string_1)
2247 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2248 (adjust_after_replace, adjust_after_insert, replace_range)
2249 (replace_range_2, del_range, del_range_1, del_range_byte)
2250 (del_range_both, del_range_2, modify_region)
2251 (prepare_to_modify_buffer, signal_before_change)
2252 (signal_after_change, Fcombine_after_change_execute):
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2254 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2255 (balance_an_interval, split_interval_right, split_interval_left)
2256 (find_interval, next_interval, update_interval)
2257 (adjust_intervals_for_insertion, delete_node, delete_interval)
2258 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2259 (static_offset_intervals, offset_intervals)
2260 (merge_interval_right, merge_interval_left, make_new_interval)
2261 (graft_intervals_into_buffer, temp_set_point_both)
2262 (temp_set_point, set_point, adjust_for_invis_intang)
2263 (set_point_both, move_if_not_intangible, get_property_and_range)
2264 (get_local_map, copy_intervals, copy_intervals_to_string)
2265 (compare_string_intervals, set_intervals_multibyte_1):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 * intervals.h: Adjust decls to match defn changes elsewhere.
2268 (struct interval):
2269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2270 * keyboard.c (this_command_key_count, this_single_command_key_start)
2271 (before_command_key_count, before_command_echo_length, echo_now)
2272 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2273 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2274 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2275 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2277 (last_non_minibuf_size, last_point_position, echo_truncate)
2278 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2279 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2280 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2281 (stuff_buffered_input):
2282 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2283 (last_auto_save, command_loop_1, read_char):
2284 Use EMACS_INT, not int, to avoid integer overflow.
2285 (record_char): Avoid overflow in total_keys computation.
2286 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2287 * keyboard.h: Adjust decls to match defn changes elsewhere.
2288 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2289 (Fkey_description, Fdescribe_vector, Flookup_key):
2290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2291 (click_position): New function, to check that positions are in range.
2292 (Fcurrent_active_maps):
2293 (describe_command):
2294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2295 (Faccessible_keymaps, Fkey_description):
2296 (preferred_sequence_p):
2297 Don't assume fixnum can fit into int.
2298 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2299 Check for integer overflow in size calculations.
2300 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2301 avoid mishandling large integers.
2302 * lisp.h: Adjust decls to match defn changes elsewhere.
2303 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2304 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2305 (struct Lisp_Marker):
2306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2307 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2308 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2309 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2310 All callers changed.
2311 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2312 Assume the arg has valid form, since it always does.
2313 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2314 unsigned integer system type.
2315 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2316 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2318 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2319 (duration_to_sec_usec): New decl.
2320 * lread.c (read_from_string_index, read_from_string_index_byte)
2321 (read_from_string_limit, readchar, unreadchar, openp)
2322 (read_internal_start, read1, oblookup):
2323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2324 (Fload, readevalloop, Feval_buffer, Feval_region):
2325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2326 (openp): Check for out-of-range argument to 'access'.
2327 (read1): Use int, not EMACS_INT, where int is wide enough.
2328 Don't assume fixnum fits into int.
6efdadfd 2329 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2330 (read_filtered_event): Use duration_to_sec_usec
2331 to do proper overflow checking on durations.
d311d28c
PE
2332 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2333 in size calculation.
2334 (Fexecute_kbd_macro):
2335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2336 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2337 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2338 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2339 (set_marker_both, set_marker_restricted_both, marker_position)
2340 (marker_byte_position, Fbuffer_has_markers_at):
2341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2342 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2343 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2344 It now merely ensures that the menu is large enough, without
2345 necessarily growing it, as this avoids some integer overflow issues.
2346 All callers changed.
2347 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2349 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2350 Use SAFE_ALLOCA_LISP, not alloca.
2351 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2352 to EMACS_INT. Check that fixnums are in proper range for system types.
2353 * minibuf.c (minibuf_prompt_width, string_to_object)
2354 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2355 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2357 (get_minibuffer, read_minibuf_unwind):
2358 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2359 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2360 this simplifies overflow checking. All callers changed.
2361 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2362 (Ftest_completion):
2363 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2364 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2365 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2366 Check that fixnums are in proper range for system types.
2367 (Fx_create_frame, Fx_show_tip):
2368 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2369 * nsfont.m (ns_findfonts, nsfont_list_family):
2370 Don't assume fixnum fits in long.
2371 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2372 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2373 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2374 wide enough.
17fdb222 2375 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2377 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2378 (PRINTDECLARE, PRINTPREPARE):
2379 (strout, print_string):
2380 (print, print_preprocess, print_check_string_charset_prop)
2381 (print_object):
2382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2383 (PRINTDECLARE):
2384 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2386 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2387 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2388 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2389 (print_error_message): Use SAFE_ALLOCA, not alloca.
2390 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2391 (print_depth, new_backquote_output, print_number_index):
2392 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2393 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2394 (Fset_process_window_size, Fformat_network_address)
2395 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2396 (sigchld_handler):
d311d28c 2397 Check that fixnums are in proper range for system types.
d44287d4 2398 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2399 Check for process-ids out of pid_t range rather than relying on
2400 undefined behavior.
e4d81efc 2401 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2402 (Fformat_network_address, read_process_output, send_process)
2403 (Fprocess_send_region, status_notify):
2404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2405 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2406 (wait_reading_process_output, read_process_output, exec_sentinel):
2407 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2408 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2409 (Faccept_process_output): Use duration_to_sec_usec to do proper
2410 overflow checking on durations.
dde14581
PE
2411 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2412 Don't assume pid_t fits in int.
02481186
PE
2413 * process.h (struct Lisp_Process): Members tick and update_tick
2414 are now of type EMACS_INT, not int.
b62b53e8
PE
2415 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2416 configured --with-wide-int.
d311d28c
PE
2417 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2418 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2419 * search.c (looking_at_1, string_match_1):
2420 (fast_string_match, fast_c_string_match_ignore_case)
2421 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2422 (scan_newline, find_before_next_newline, search_command)
2423 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2424 (set_search_regs, wordify):
2425 (Freplace_match):
2426 (Fmatch_data):
2427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2428 (string_match_1, search_buffer, set_search_regs):
2429 (Fmatch_data):
2430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2431 (wordify): Check for overflow in size calculation.
2432 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2433 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2434 Check that fixnums are in proper range for system types.
2435 * sound.c (struct sound_device)
2436 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2438 (Fplay_sound_internal):
2439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2440 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2441 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2442 (Fparse_partial_sexp):
2443 Don't assume fixnums can fit in int.
2444 (struct lisp_parse_state, find_start_pos, find_start_value)
2445 (find_start_value_byte, find_start_begv)
2446 (update_syntax_table, char_quoted, dec_bytepos)
2447 (find_defun_start, prev_char_comend_first, back_comment):
2448 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2449 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2450 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2451 (Finternal_describe_syntax_value): Check that match_lisp is a
2452 character, not an integer, since the code stuffs it into int.
2453 (scan_words, scan_sexps_forward):
2454 Check that fixnums are in proper range for system types.
2455 (Fforward_word):
2456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2457 (scan_sexps_forward):
2458 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2459 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2460 * syntax.h: Adjust decls to match defn changes elsewhere.
2461 (struct gl_state_s):
2462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2463 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2464 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2465 * sysdep.c (wait_for_termination_1, wait_for_termination)
2466 (interruptible_wait_for_termination, mkdir):
2467 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2468 (emacs_read, emacs_write):
2469 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2470 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2471 and double all fit in int.
d311d28c
PE
2472 * term.c (set_tty_color_mode):
2473 Check that fixnums are in proper range for system types.
2474 * termhooks.h (struct input_event):
2475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2476 * textprop.c (validate_interval_range, interval_of)
2477 (Fadd_text_properties, set_text_properties_1)
2478 (Fremove_text_properties, Fremove_list_of_text_properties)
2479 (Ftext_property_any, Ftext_property_not_all)
2480 (copy_text_properties, text_property_list, extend_property_ranges)
2481 (verify_interval_modification):
2482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2483 (Fnext_single_char_property_change)
2484 (Fprevious_single_char_property_change):
2485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2486 (copy_text_properties):
2487 Check for integer overflow in index calculation.
d311d28c
PE
2488 * undo.c (last_boundary_position, record_point, record_insert)
2489 (record_delete, record_marker_adjustment, record_change)
2490 (record_property_change):
2491 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2492 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2493 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2494 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2495 (Fx_hide_tip, Fx_file_dialog):
2496 * w32menu.c (set_frame_menubar):
2497 Use ptrdiff_t, not int, for consistency with rest of code.
2498 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2499 (select_window, Fdelete_other_windows_internal)
2500 (window_scroll_pixel_based, window_scroll_line_based)
2501 (Frecenter, Fset_window_configuration):
2502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2503 (Fset_window_hscroll, run_window_configuration_change_hook)
2504 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2505 (Fscroll_other_window, Frecenter):
d311d28c
PE
2506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2507 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2508 Don't assume fixnum fits in int.
2509 (Fset_window_scroll_bars):
2510 Check that fixnums are in proper range for system types.
2511 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2512 (string_pos, c_string_pos, number_of_chars, init_iterator)
2513 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2514 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2515 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2516 (face_before_or_after_it_pos, handle_invisible_prop)
2517 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2518 (display_prop_intangible_p, string_buffer_position_lim)
2519 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2520 (get_overlay_strings_1, get_overlay_strings)
2521 (iterate_out_of_display_property, forward_to_next_line_start)
2522 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2523 (get_next_display_element, set_iterator_to_next)
2524 (get_visually_first_element, compute_stop_pos_backwards)
2525 (handle_stop_backwards, next_element_from_buffer)
2526 (move_it_in_display_line_to, move_it_in_display_line)
2527 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2528 (add_to_log, message_dolog, message_log_check_duplicate)
2529 (message2, message2_nolog, message3, message3_nolog
2530 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2531 (current_message_1, truncate_echo_area, truncate_message_1)
2532 (set_message, set_message_1, store_mode_line_noprop)
2533 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2534 (text_outside_line_unchanged_p, check_point_in_composition)
2535 (reconsider_clip_changes)
2536 (redisplay_internal, set_cursor_from_row, try_scrolling)
2537 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2538 (redisplay_window, find_last_unchanged_at_beg_row)
2539 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2540 (trailing_whitespace_p, find_row_edges, display_line)
2541 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2542 (display_mode_element, store_mode_line_string)
2543 (pint2str, pint2hrstr, decode_mode_spec)
2544 (display_count_lines, display_string, draw_glyphs)
2545 (x_produce_glyphs, x_insert_glyphs)
2546 (rows_from_pos_range, mouse_face_from_buffer_pos)
2547 (fast_find_string_pos, mouse_face_from_string_pos)
2548 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2550 (safe_call, init_from_display_pos, handle_fontified_prop)
2551 (handle_single_display_spec, load_overlay_strings)
2552 (with_echo_area_buffer, setup_echo_area_for_printing)
2553 (display_echo_area, echo_area_display)
2554 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2555 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2556 (redisplay_window, dump_glyph_row, display_mode_line)
2557 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2558 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2559 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2560 (handle_single_display_spec, build_desired_tool_bar_string)
2561 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2562 (get_specified_cursor_type):
2563 Check that fixnums are in proper range for system types.
2564 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2565 (Flookup_image_map):
2566 Don't assume fixnums fit in int.
2567 (compare_overlay_entries):
2568 Avoid mishandling comparisons due to subtraction overflow.
2569 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2570 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2571 (handle_tool_bar_click):
2572 Use int, not unsigned, since we prefer signed and the signedness
2573 doesn't matter here.
2574 (get_next_display_element, next_element_from_display_vector):
2575 Use int, not EMACS_INT, when int is wide enough.
2576 (start_hourglass): Use duration_to_sec_usec to do proper
2577 overflow checking on durations.
2578 * xfaces.c (Fbitmap_spec_p):
2579 Check that fixnums are in proper range for system types.
2580 (compare_fonts_by_sort_order):
2581 Avoid mishandling comparisons due to subtraction overflow.
2582 (Fx_family_fonts, realize_basic_faces):
2583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2584 (Fx_family_fonts):
2585 Don't assume fixnum fits in int.
2586 Use SAFE_ALLOCA_LISP, not alloca.
2587 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2588 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2589 (face_at_buffer_position, face_for_overlay_string)
2590 (face_at_string_position):
2591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2592 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2593 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2594 (Fx_show_tip):
2595 Check that fixnums are in proper range for system types.
2596 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2597 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2598 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2599 (Fx_change_window_property): Don't assume fixnums fit in int.
2600 * xfont.c (xfont_chars_supported):
2601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2602 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2603 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2605 * xml.c (parse_region):
2606 * xrdb.c (magic_file_p):
2607 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2608 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2609 (x_get_local_selection, x_reply_selection_request)
2610 (x_handle_selection_request, wait_for_property_change):
2611 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2612 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2613 short is wide enough.
2614 (x_send_client_event): Don't assume fixnum fits in int.
2615 * xterm.c (x_x_to_emacs_modifiers):
2616 Don't assume EMACS_INT overflows nicely into int.
2617 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2618 may come from Lisp.
2619 (handle_one_xevent): NATNUMP can eval its arg twice.
2620 (x_connection_closed):
2621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2622 * xterm.h: Adjust decls to match defn changes elsewhere.
2623 (struct scroll_bar): Use struct vectorlike_header
2624 rather than rolling our own approximation.
2625 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2626
c6574eb5
GM
26272012-05-25 Glenn Morris <rgm@gnu.org>
2628
2629 * lisp.mk (lisp): Update for more files being compiled now.
2630
e8d32c7e
SM
26312012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2632
48def666
SM
2633 * lread.c: Remove `read_pure' which makes no difference.
2634 (read_pure): Remove var.
2635 (unreadpure): Remove function.
2636 (readevalloop): Don't call read_list with -1 flag.
2637 (read1, read_vector): Don't test read_pure any more.
2638 (read_list): Simplify.
2639
e8d32c7e
SM
2640 * fileio.c, character.h: Minor style tweaks.
2641
4b2addb7
DA
26422012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2643
2644 * window.h (clip_changed): Remove useless declaration.
2645
584461b2
JB
26462012-05-22 Juanma Barranquero <lekktu@gmail.com>
2647
2648 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2649 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2650
34374650
PE
26512012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2652
2653 Remove src/m/*.
2654 This directory predates autoconf and is no longer needed nowadays.
2655 Move its few remaining bits of functionality to where they're needed.
2656 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2657 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2658 * m/template.h: Remove.
2659 * Makefile.in (M_FILE): Remove. All uses removed.
2660 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2661 * lisp.h (USE_LSB_TAG):
2662 * mem-limits.h (EXCEEDS_LISP_PTR):
2663 Use VAL_MAX, not VALBITS, in #if.
2664 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2665 (EMACS_UINT): Define unconditionally now.
2666 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2667 (BITS_PER_EMACS_INT): New constants, replacing
2668 what used to be in config.h, but not useful in #if.
2669 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2670 define them any more.
2671 (VAL_MAX): New macro.
2672 (VALMASK): Use it.
2673 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2674 BITS_PER_EMACS_INT, in #if.
2675 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2676 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2677 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2678 * s/ms-w32.h (DATA_START):
2679 Move here from removed file m/intel386.h.
2680 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2681 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2682
261cb4bb
PE
26832012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2684
2685 Assume C89 or later.
2686 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2687 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2688 (xrealloc):
2689 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2690 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2691 * textprop.c, tparam.c (NULL): Remove.
2692 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2693 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2694 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2695 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2696 * xterm.c (input_signal_count): Assume volatile works.
2697
ff23cd9f
KB
26982012-05-21 Ken Brown <kbrown@cornell.edu>
2699
2700 * xgselect.c (xg_select): Fix first argument in call to 'select'
2701 (bug#11508).
2702
1b170bc6
KB
27032012-05-20 Ken Brown <kbrown@cornell.edu>
2704
2705 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2706 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2707
b2f4d39f
KB
27082012-05-19 Ken Brown <kbrown@cornell.edu>
2709
2710 * xfns.c (x_in_use): Remove `static' qualifier.
2711 * xterm.h (x_in_use): Declare.
2712 * xgselect.c: Include xterm.h.
2713 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2714 and `display_arg' (bug#9754).
2715
003fdae2
PE
27162012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2717
9232a6d9
PE
2718 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2719
003fdae2
PE
2720 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2721 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2722
784b56e2
EZ
27232012-05-18 Eli Zaretskii <eliz@gnu.org>
2724
2725 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2726
2727 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2728 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2729
2730 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2731 reference to image_cache->refcount.
2732 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2733
a0a79cde
JL
27342012-05-17 Juri Linkov <juri@jurta.org>
2735
2736 * search.c (Fword_search_regexp, Fword_search_backward)
2737 (Fword_search_forward, Fword_search_backward_lax)
2738 (Fword_search_forward_lax): Move functions to isearch.el
2739 (bug#10145, bug#11381).
2740
b0572523
PE
27412012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2742
2743 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2744
9660f5fc
SM
27452012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2746
2747 * lread.c (init_obarray): Declare Qt and Qnil as special.
2748
4374de83
GM
27492012-05-14 Glenn Morris <rgm@gnu.org>
2750
2751 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2752 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2753
dc44c39a
PE
27542012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2755
078c97cb
PE
2756 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2757
dc44c39a
PE
2758 * unexaix.c: Port to more-recent AIX compilers.
2759 (report_error, report_error_1, make_hdr, copy_sym)
2760 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2761 Make arguments const char *, not char *, to avoid violations of C
2762 standard and to fix some AIX warnings reported by Gilles Pion.
2763
e18afed7 27642012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2765
2766 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2767 already have overlays loaded.
2768 (handle_single_display_spec): Before returning without displaying
2769 fringe bitmap, synchronize the bidi iterator with the main display
2770 iterator, by calling iterate_out_of_display_property.
2771 (iterate_out_of_display_property): Detect buffer iteration by
2772 testing that it->string is a Lisp string.
2773 (get_next_display_element): When the current object is exhausted,
2774 and there's something on it->stack, call set_iterator_to_next to
2775 proceed with what's on the stack, instead of returning zero.
2776 (set_iterator_to_next): If called at the end of a Lisp string,
2777 proceed to consider_string_end without incrementing string
2778 position. Don't increment display vector index past the end of
2779 the display vector. (Bug#11417)
c8fb9dc6
EZ
2780 (pos_visible_p): Don't report a position visible when move_it_to
2781 stopped at the last line of window, which happens to be scanned
2782 backwards by the bidi iteration. (Bug#11464)
ac268e67 2783
e18afed7 27842012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2785
2786 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2787 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2788 are on a TTY, and thus unable to display on the fringes.
2789 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2790 so we need to signal to the caller that this is a "replacing"
2791 display spec. This fixes display when the spec is invalid or we
2792 are on a TTY.
2793
e18afed7 27942012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2795
2796 * unexaix.c (make_hdr): Fix typo in prototype.
2797 This bug broke the build on AIX. Problem reported by Gilles Pion.
2798
9d0a235a
MA
27992012-05-14 Michael Albinus <michael.albinus@gmx.de>
2800
2801 * keyboard.c (kbd_buffer_get_event): Read special events also in
2802 batch mode. (Bug#11415)
2803
9e6b06ed
GM
28042012-05-12 Glenn Morris <rgm@gnu.org>
2805
2806 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2807
c1a1d7a3
EZ
28082012-05-12 Eli Zaretskii <eliz@gnu.org>
2809
2810 * lisp.mk (lisp): Add newcomment.elc.
2811
3fe7cdc8
GM
28122012-05-12 Glenn Morris <rgm@gnu.org>
2813
2814 * Makefile.in (MKDIR_P): New, set by configure.
2815 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2816
53f7d2c0
PE
28172012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 Remove unused function hourglass_started.
2820 * dispextern.h (hourglass_started):
2821 * w32fns.c (hourglass_started):
2822 * xdisp.c (hourglass_started): Remove.
2823
75aafb17
JB
28242012-05-10 Juanma Barranquero <lekktu@gmail.com>
2825
2826 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2827 Update dependencies.
2828
12959e8e
PE
28292012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2830
97107e2e
PE
2831 * xgselect.c (xg_select): Put maxfds+1 into a var.
2832 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2833
12959e8e
PE
2834 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2835
836d29b3
DA
28362012-05-10 Dave Abrahams <dave@boostpro.com>
2837
2838 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2839 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2840
5cb67954
MA
28412012-05-09 Michael Albinus <michael.albinus@gmx.de>
2842
2843 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2844 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2845 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2846 Initialize xd_registered_buses.
2847
3478ec45
PE
28482012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2849
b263a6b0
PE
2850 Untag more efficiently if USE_LSB_TAG.
2851 This is based on a proposal by YAMAMOTO Mitsuharu in
2852 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2853 For an admittedly artificial (nth 8000 longlist) benchmark on
2854 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2855 Emacs's overall text size by 1%.
2856 * lisp.h (XUNTAG): New macro.
2857 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2858 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2859 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2860 * eval.c (Fautoload):
2861 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2862 * frame.h (XFRAME): Use XUNTAG.
2863
3478ec45
PE
2864 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2865 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2866 Remove unportable assumptions about print widths of types like
2867 dbus_uint32_t.
2868 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2869 intptr_t when converting between pointer and integer, to avoid GCC
2870 warnings about wrong width.
2871
666b903b 28722012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2873
2874 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2875 stack for each reader_thread, instead of defaulting to 8MB
2876 determined by the linker. This avoids failures in creating
2877 subprocesses on Windows 7, see the discussion in this thread:
2878 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2879
b120cc17
JC
28802012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2881
2882 Fix up display of the *Minibuf-0* buffer in the mini window.
2883 * keyboard.c (read_char): Don't clear the echo area if there's no
2884 message to clear.
2885 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2886 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2887
9a4b36f8
MA
28882012-05-07 Michael Albinus <michael.albinus@gmx.de>
2889
2890 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2891 batch mode.
2892
e5f9458f
CY
28932012-05-06 Chong Yidong <cyd@gnu.org>
2894
2895 * lisp.mk (lisp): Update.
2896
eceeb5fc 28972012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2898
2899 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2900
71873e2b
SM
29012012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2902
2903 * data.c (PUT_ERROR): New macro.
2904 (syms_of_data): Use it. Add new error type `user-error'.
2905 * undo.c (user_error): New function.
2906 (Fprimitive_undo): Use it.
2907 * print.c (print_error_message): Adjust print style for `user-error'.
2908 * keyboard.c (user_error): New function.
2909 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2910
ab0fa4e4
PE
29112012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 Do not limit current-time-string to years 1000..9999.
2914 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2915 (Fcurrent_time_string): Support any year that is supported by the
2916 underlying localtime representation. Don't use asctime, as it
2917 has undefined behavior for years outside the range -999..9999.
2918
7ed806a7
PE
29192012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2920
2921 Fix race conditions involving setenv, gmtime, localtime, asctime.
2922 Without this fix, interrupts could mess up code that uses these
2923 nonreentrant functions, since setting TZ invalidates existing
2924 tm_zone or tzname values, and since most of these functions return
2925 pointers to static storage.
2926 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2927 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2928 Grow the critical sections to include not just invoking
2929 localtime/gmtime, but also accessing these functions' results
2930 including their tm_zone values if any, and any related TZ setting.
2931 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2932 so that the struct tm is saved in the critical section.
2933 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2934 motivated by the fact that memory allocation needs to be outside
2935 the critical section.
2936
0c16dfed
DA
29372012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2938
2939 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2940 with RESET_INTERVAL.
2941
2942 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2943 Remove duplicated buffer name initialization.
2944
3f83ace8
JM
29452012-05-02 Jim Meyering <jim@meyering.net>
2946
2947 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2948
c7b8541e
JM
2949 * xfns.c (x_window): Use xstrdup (Bug#11375).
2950
90207a15 29512012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2952
2953 * xdisp.c (pos_visible_p): If already at a newline from the
2954 display string before the 'while' loop, don't walk back the glyphs
2955 from it3.glyph_row. Solves assertion violation when the display
2956 string begins with a newline (egg.el). (Bug#11367)
2957
b593d6a9
AH
29582012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2959
2960 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2961 Move to simple.el.
2962
4737362e
GM
29632012-05-01 Glenn Morris <rgm@gnu.org>
2964
99cf43f9
GM
2965 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2966 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2967 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2968 All were removed before 23.1.
2969
9311dcff
GM
2970 * dispnew.c: Remove HAVE_LIBNCURSES test;
2971 it is always true on relevant platforms.
2972
4d5c6349
GM
2973 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2974 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2975
4737362e
GM
2976 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2977
74dd3a6b
AS
29782012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2979
2980 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2981 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2982 Remove.
2983
13c379ee
PE
29842012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2985
2986 Do not avoid creating empty evaporating overlays (Bug#9642).
2987 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2988 That is, do not delete an evaporating overlay if it becomes
2989 empty after its bounds are adjusted to fit within its buffer.
2990 This fix caused other problems, and I'm reverting it until we get
2991 to the bottom of them.
2992
a8e7d6d7 29932012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2994
2995 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2996
a8e7d6d7 29972012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2998
2999 * xdisp.c (pos_visible_p): If the window start position is beyond
3000 ZV, start the display from buffer beginning. Prevents assertion
3001 violation in init_iterator when the minibuffer window is scrolled
3002 via the scroll bar.
3003
3004 * window.c (window_scroll_pixel_based): Likewise.
3005
a8e7d6d7 30062012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3007
3008 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3009
a8e7d6d7 30102012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3011
3012 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3013 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3014
a8e7d6d7 30152012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3016
b593d6a9
AH
3017 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3018 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3019
1c6900d9
EZ
30202012-04-26 Eli Zaretskii <eliz@gnu.org>
3021
4c3fa1d9
EZ
3022 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3023 display element, check also the underlying string or buffer
3024 character. (Bug#11341)
3025
1c6900d9
EZ
3026 * w32menu.c: Include w32heap.h.
3027 (add_menu_item): If the call to AppendMenuW (via
3028 unicode_append_menu) fails, disable Unicode menus only if we are
3029 running on Windows 9X/Me.
3030
42bf8205
AS
30312012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3032
3033 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3034 (xgetint): Add missing shift for LSB tags.
3035
b1bac16e
MR
30362012-04-24 Martin Rudalics <rudalics@gmx.at>
3037
3038 * keyboard.c (read_char): Don't wipe echo area for select window
3039 events: These might get delayed via `mouse-autoselect-window'
3040 (Bug#11304).
3041
d69621cc
JB
30422012-04-24 Juanma Barranquero <lekktu@gmail.com>
3043
3044 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3045 manipulation of :loaded-from data.
3046
02fd101b
JB
30472012-04-23 Juanma Barranquero <lekktu@gmail.com>
3048
3049 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3050 now a cons (bug#11311).
3051
888bec30
PE
30522012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3053
89a438bd
PE
3054 Do not create empty overlays with the evaporate property (Bug#9642).
3055 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3056 if it becomes empty after its bounds are adjusted to fit within
3057 its buffer. Without this fix, in a nonempty buffer (let ((o
3058 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3059 yields an empty overlay that has the evaporate property, which is
3060 not supposed to happen.
3061
1068fe4d
PE
3062 Fix minor GTK3 problems found by static checking.
3063 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3064 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3065 (struct _EmacsFixedClass, emacs_fixed_get_type):
3066 Move decls here from emacsgtkfixed.h, since they needn't be public.
3067 (emacs_fixed_get_type): Now static.
3068 (emacs_fixed_class_init): Omit unused local.
3069 (emacs_fixed_child_type): Remove; unused.
3070 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3071 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3072 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3073 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3074 (EMACS_FIXED_GET_CLASS): Remove; unused.
3075 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3076
888bec30
PE
3077 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3078 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3079
de85e130
PE
30802012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3081
d0baac98 3082 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3083 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3084 (__malloc_size_t, __malloc_ptrdiff_t):
3085 Remove. All uses removed, replaced by the definiens if needed,
3086 since we can assume C89 or better now.
3087 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3088 (protect_malloc_state, align, get_contiguous_space)
3089 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3090 (malloc_atfork_handler_child, malloc_enable_thread)
3091 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3092 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3093 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3094 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3095 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3096 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3097 Define using prototypes, not old style.
3098 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3099 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3100 (align): Don't assume that signed integer overflow wraps around.
3101 Omit unused local var.
3102 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3103 (_free_internal_nolock, memalign, mallochook, reallochook):
3104 Omit no-longer-needed casts.
3105 (valloc): Use getpagesize, not __getpagesize.
3106 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3107 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3108
de85e130
PE
3109 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3110
dcbf5805
MA
31112012-04-22 Michael Albinus <michael.albinus@gmx.de>
3112
3113 Move functions from C to Lisp. Make non-blocking method calls
3114 the default. Implement further D-Bus standard interfaces.
3115
3116 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3117 (QCdbus_request_name_allow_replacement)
3118 (QCdbus_request_name_replace_existing)
3119 (QCdbus_request_name_do_not_queue)
3120 (QCdbus_request_name_reply_primary_owner)
3121 (QCdbus_request_name_reply_in_queue)
3122 (QCdbus_request_name_reply_exists)
3123 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3124 (QCdbus_registered_serial, QCdbus_registered_method)
3125 (QCdbus_registered_signal): New Lisp objects.
3126 (XD_DEBUG_MESSAGE): Use sizeof.
3127 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3128 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3129 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3130 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3131 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3132 (xd_signature, xd_append_arg): Allow float for integer types.
3133 (xd_get_connection_references): New function.
b593d6a9
AH
3134 (xd_get_connection_address): Rename from xd_initialize.
3135 Return cached address.
dcbf5805
MA
3136 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3137 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3138 level.
3139 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3140 Return number of refcounts.
dcbf5805
MA
3141 (Fdbus_get_unique_name): Make stronger parameter check.
3142 (Fdbus_message_internal): New defun.
3143 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3144 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3145 (Fdbus_send_signal, Fdbus_register_service)
3146 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3147 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3148 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3149 (Vdbus_compiled_version, Vdbus_runtime_version)
3150 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3151 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3152 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3153 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3154 Adapt docstring.
dcbf5805 3155
52828e02
PE
31562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3157
da05bc4c
PE
3158 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3159 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3160 Do not assume ptrdiff_t is the same width as 'int'.
3161
52828e02
PE
3162 * alloc.c: Handle unusual debugging option combinations.
3163 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3164 since the two debugging options are incompatible.
3165 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3166 is defined.
3167 (mem_init, mem_insert, mem_insert_fixup):
3168 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3169 (NEED_MEM_INSERT): Remove; no longer needed.
3170
f01769f9
LL
31712012-04-22 Leo Liu <sdl.web@gmail.com>
3172
3173 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3174
5790543d
PE
31752012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3176
3177 * sysdep.c [__FreeBSD__]: Minor cleanups.
3178 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3179 Use Emacs indenting style more consistently. Avoid some casts.
3180 Use 'double' consistently rather than mixing 'float' and 'double'.
3181
b91b7e4d
EW
31822012-04-21 Eduard Wiebe <usenet@pusto.de>
3183
b593d6a9
AH
3184 * sysdep.c (list_system_processes, system_process_attributes):
3185 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3186
6114eb15
AS
31872012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3188
3189 * lisp.mk (lisp): Update.
3190
2f38dff7
PE
31912012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3194 It is never used otherwise.
3195
4ae29f89
SM
31962012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3197
3198 * print.c (print_preprocess): Only check print_depth if print-circle
3199 is nil.
3200 (print_object): Check for cycles even when print-circle is nil and
3201 print-gensym is t, but only check print_depth if print-circle is nil.
3202
f30d612a
CY
32032012-04-20 Chong Yidong <cyd@gnu.org>
3204
3205 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3206 set the status to "failed" and ensure that sentinel is run.
3207
c07a4c0b 32082012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3209
3210 * process.c (Fset_process_inherit_coding_system_flag)
3211 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3212 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3213
c07a4c0b 32142012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3215
3216 * xdisp.c (string_buffer_position_lim): Limit starting position to
3217 BEGV.
3218 (set_cursor_from_row): If called for a mode-line or header-line
3219 row, return zero immediately.
3220 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3221 farther than the first row after the header line, if any.
3222 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3223 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3224
c07a4c0b 32252012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3226
4ae29f89
SM
3227 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3228 (bug#11238).
ad3a2b41 3229
c07a4c0b 32302012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 32312012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3232
3233 configure: new option --enable-gcc-warnings (Bug#11207)
3234 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3235 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3236 (ALL_CFLAGS): Use new macros rather than old.
3237 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3238 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3239 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3240 -Wunused-result, -Wunused-variable. This should go away once
3241 the Emacs and Gnulib regex code is merged.
3242 (xmalloc, xrealloc): Now static.
3243
aba027e8
PE
32442012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3245
3246 * dired.c (Fsystem_groups): Remove unused local.
3247
e5a36063
GM
32482012-04-17 Glenn Morris <rgm@gnu.org>
3249
3250 * dired.c (Fsystem_users): Doc fix.
3251
316411f0
DA
32522012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3253
3254 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3255 (syms_of_dired): Add them.
3256
9426aba4
PE
32572012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3258
b62a57be
PE
3259 Fix minor alloc.c problems found by static checking.
3260 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3261 New extern decls, to avoid calling undeclared functions.
3262 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3263 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3264 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3265 (NEED_MEM_INSERT): New macro.
3266 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3267 Remove one incorrect comment and fix another.
b62a57be 3268
3539f31f
PE
3269 Fix minor ralloc.c problems found by static checking.
3270 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3271 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3272 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3273 (r_alloc_sbrk): Now static.
3274
a041960a
PE
3275 Improve ralloc.c interface checking.
3276 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3277 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3278 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3279 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3280 [REL_ALLOC]: ... to here, to check interface.
3281 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3282 Remove decls. This fixes an "It stinks!".
3283
9426aba4
PE
3284 * alloc.c (which_symbols): Fix alignment issue / type clash.
3285
d55c12ed
AS
32862012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3287
3288 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3289 (struct Lisp_Misc_Any): Likewise.
3290 (struct Lisp_Free): Likewise.
3291 * alloc.c (union aligned_Lisp_Symbol): Define.
3292 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3293 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3294 (union aligned_Lisp_Misc): Define.
3295 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3296 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3297 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3298
b948ce8b
PE
32992012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3300
3301 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3302 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3303 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3304 * s/netbsd.h, s/sol2-6.h:
3305 Remove definition of GC_MARK_STACK, since the default now works.
3306 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3307 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3308 no longer the default.
3309 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3310
35dc09a1 33112012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3312
35dc09a1
GM
3313 * lread.c (lisp_file_lexically_bound_p):
3314 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3315
35dc09a1
GM
33162012-04-14 Eli Zaretskii <eliz@gnu.org>
3317
3318 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3319 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3320
33212012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3322
3323 * nsterm.m (constrainFrameRect): Always constrain when there is only
3324 one screen (Bug#10962).
3325
bcd86815
KB
33262012-04-13 Ken Brown <kbrown@cornell.edu>
3327
3328 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3329
c25df26e
RT
33302012-04-13 Reuben Thomas <rrt@sc3d.org>
3331
3332 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3333
0fc59f1e
DC
33342012-04-11 Daniel Colascione <dancol@dancol.org>
3335
3336 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3337 against is gone. It's better to use vfork now so that when Cygwin
3338 gains a new, working vfork, we use it automatically (bug#10398).
3339
de8c03dc
SM
33402012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3341
3342 * window.c (save_window_save): Obey window-point-insertion-type.
3343
2f097256
GM
33442012-04-11 Glenn Morris <rgm@gnu.org>
3345
3346 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3347
453b951e
SM
33482012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3349
3350 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3351
75f1671a 33522012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3353
3354 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3355 (force_quit_count): New var.
3356 (handle_interrupt): Use it.
3357
2a8ce227
JB
33582012-04-10 Juanma Barranquero <lekktu@gmail.com>
3359
3360 * w32.c (w32_delayed_load): Record the full path of the library
3361 being loaded (bug#10424).
3362
935396c0
GM
33632012-04-09 Glenn Morris <rgm@gnu.org>
3364
05920a43
GM
3365 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3366 not just in the obarray, before snarfing them. (Bug#11036)
3367
935396c0
GM
3368 * Makefile.in ($(leimdir)/leim-list.el):
3369 Pass EMACS rather than BUILT_EMACS.
3370
a18ecafa
TZ
33712012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3372
3373 * process.c (make_process):
3374 * process.h: Add integer `gnutls_handshakes_tried' member to
3375 process struct.
3376
6bbef4e5
JC
3377 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3378 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3379
3380 * gnutls.c (gnutls_log_function2i): Convenience log function.
3381 (emacs_gnutls_read): Use new log functions,
3382 `gnutls_handshakes_tried' process member, and
3383 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3384 attempts per process (connection).
3385
b4d3bc10
CY
33862012-04-09 Chong Yidong <cyd@gnu.org>
3387
3388 * eval.c (Fuser_variable_p, user_variable_p_eh)
3389 (lisp_indirect_variable): Functions deleted.
3390 (Fdefvar): Caller changed.
3391
3392 * callint.c (Finteractive, Fcall_interactively):
3393 * minibuf.c (Fread_variable): Callers changed.
3394
70f4d973
EZ
33952012-04-09 Eli Zaretskii <eliz@gnu.org>
3396
3397 * xdisp.c (set_cursor_from_row): If the display string appears in
3398 the buffer at position that is closer to point than the position
3399 after the display string, display the cursor on the first glyph of
3400 the display string. Fixes cursor display when a 'display' text
3401 property immediately follows invisible text. (Bug#11094)
3402
cb3c2e3e
PE
34032012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3404
3405 composite.c: use 'double' consistently
3406 * composite.c (get_composition_id): Use 'double' consistently
3407 instead of converting 'float' to 'double' and vice versa; this is
3408 easier to understand and avoids a GCC warning.
3409
fd06db5d
GM
34102012-04-09 Glenn Morris <rgm@gnu.org>
3411
50fe702a
GM
3412 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3413 preparation for dumping it with emacs. (Bug#4789)
3414 (leimdir): New variable.
3415 ($(leimdir)/leim-list.el): New rule.
3416 (emacs$(EXEEXT)): Depend on leim-list.el.
3417
fd06db5d
GM
3418 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3419 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3420 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3421
55c131ee
AS
34222012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3423
3424 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3425 proper alignment.
3426
9209588f
JB
34272012-04-07 Juanma Barranquero <lekktu@gmail.com>
3428
3429 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3430 Remove unused local variable.
3431
e3fb2efb
PE
34322012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3433
3434 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3435 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3436 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3437 objects, as mark_maybe_pointer will catch them otherwise.
3438 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3439 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3440
b5385551
PE
34412012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3442
3443 Fix typo that broke non-Windows builds.
3444 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3445
9078ead6
EZ
34462012-04-07 Eli Zaretskii <eliz@gnu.org>
3447
3448 Support building on MS-Windows with libxml2.
3449
3450 * makefile.w32-in (OBJ2): Add xml.$(O).
3451 (GLOBAL_SOURCES): Add xml.c.
3452 ($(BLD)/xml.$(O)): New dependency list.
3453
3454 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3455 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3456 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3457 [!WINDOWSNT]: New macros.
3458 (init_libxml2_functions, libxml2_loaded_p): New functions.
3459 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3460 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3461 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3462 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3463 linked in).
6bbef4e5
JC
3464 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3465 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3466 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3467
3468 * emacs.c: Don't include libxml/parser.h.
3469 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3470 xmlCleanupParser directly.
3471
3472 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3473
3811fdf3
EZ
34742012-04-07 Eli Zaretskii <eliz@gnu.org>
3475
3476 * indent.c (Fvertical_motion): If there is a display string at
3477 point, use it.vpos to compute how many lines to backtrack after
3478 move_it_to point. (Bug#11133)
3479
2f8e16b2
EZ
34802012-04-06 Eli Zaretskii <eliz@gnu.org>
3481
3482 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3483 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3484 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3485 macros related to unification of CJK characters. For the details,
3486 see the discussion following the message here:
3487 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3488
3d439cd1
CY
34892012-04-04 Chong Yidong <cyd@gnu.org>
3490
3491 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3492
8bc53d00
EZ
34932012-04-01 Eli Zaretskii <eliz@gnu.org>
3494
3495 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3496 instead of alloca. (Bug#11138)
3497
3b0512a3
AS
34982012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3499
3500 * w32menu.c (is_simple_dialog): Properly check lisp types.
3501 (Bug#11141)
3502
8427ddd2
EZ
35032012-03-31 Eli Zaretskii <eliz@gnu.org>
3504
979022ef
EZ
3505 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3506 position we get to after a call to move_it_to fails the
3507 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3508 only if we wind up in a string from display property. (Bug#11063)
3509
a6b1c7cc
EZ
3510 * window.c (Fdelete_other_windows_internal): Invalidate the row
3511 and column information about mouse highlight, so that redisplay
3512 restores it after reallocating the glyph matrices. (Bug#7464)
3513
8427ddd2
EZ
3514 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3515 string comes from a `display' text property, use the buffer
3516 position of that property as if we actually saw that position in
3517 the row's glyphs.
697ba24b
EZ
3518 (move_it_by_lines): Remove the assertion that
3519 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3520 violated when there's a before-string at the beginning of a line.
3521 (Bug#11063)
8427ddd2 3522
65a0a738
EZ
35232012-03-30 Eli Zaretskii <eliz@gnu.org>
3524
3525 * xdisp.c (append_space_for_newline): If the default face was
3526 remapped, use the remapped face for the appended newline.
3527 (extend_face_to_end_of_line): Use the remapped default face for
3528 extending the face to the end of the line.
3529 (display_line): Call extend_face_to_end_of_line when the default
3530 face was remapped. (Bug#11068)
3531
581355cc
EZ
35322012-03-29 Eli Zaretskii <eliz@gnu.org>
3533
3534 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3535
e8fc049f
SM
35362012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3537
3538 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3539
4fb9a543
GM
35402012-03-27 Glenn Morris <rgm@gnu.org>
3541
3542 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3543 Doc fixes.
3544
679910f1
KH
35452012-03-26 Kenichi Handa <handa@m17n.org>
3546
3547 * dispextern.h (struct glyph): Fix previous change. Change the
3548 bit length of glyphless.ch to 25 (Bug#11082).
3549
90d49b7f
CY
35502012-03-26 Chong Yidong <cyd@gnu.org>
3551
3552 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3553 (command_loop_1): Use it; inhibit selection update for
3554 handle-select-window too (Bug#8996).
3555
f514f6f0
FP
35562012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3557
e8fc049f 3558 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3559
bf43fa51
KH
35602012-03-25 Kenichi Handa <handa@m17n.org>
3561
3562 * dispextern.h (struct glyph): Change the bit length of
3563 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3564
8a0c01dd
EZ
35652012-03-24 Eli Zaretskii <eliz@gnu.org>
3566
3567 * s/ms-w32.h (tzname): Include time.h before redirecting to
3568 _tzname. Fixes the MSVC build. (Bug#9960)
3569
7d1c3a76
AS
35702012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3571
8ed79523
AS
3572 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3573 characters.
3574
7d1c3a76
AS
3575 * xterm.c (XTread_socket): Only modify handling_signal if
3576 !SYNC_INPUT. (Bug#11080)
3577
e99a9b8b
EZ
35782012-03-23 Eli Zaretskii <eliz@gnu.org>
3579
3580 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3581 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3582 when fetching a multibyte character consumes more bytes than
3583 CHAR_BYTES returns, due to unification of CJK characters in
3584 string_char. (Bug#11073)
3585
5063c0e1
TN
35862012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3587
3588 * process.c (wait_reading_process_output): Handle pty disconnect
3589 by refraining from sending oneself a SIGCHLD (bug#10933).
3590
9f851fbd
CY
35912012-03-22 Chong Yidong <cyd@gnu.org>
3592
3593 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3594
5063c0e1 3595 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3596 Mark string as coming from a prefix property.
3597 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3598 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3599
fb5b8aca
CY
36002012-03-21 Chong Yidong <cyd@gnu.org>
3601
3602 * xfaces.c (Vface_remapping_alist): Doc fix.
3603
62356a1b
EZ
36042012-03-20 Eli Zaretskii <eliz@gnu.org>
3605
3606 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3607 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3608 Doc fixes.
62356a1b 3609
025de85b
CY
36102012-03-20 Chong Yidong <cyd@gnu.org>
3611
3612 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3613 to reflect default non-nil value of redisplay-dont-pause.
3614
4827f94e
KH
36152012-03-19 Kenichi Handa <handa@m17n.org>
3616
3617 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3618 it fit in a valid range (Bug#11003).
3619
e50a24a2
EZ
36202012-03-18 Eli Zaretskii <eliz@gnu.org>
3621
3622 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3623 that is not from display property, accept the row as a "cursor
3624 row" if one of the string's character has a non-nil `cursor'
3625 property. Fixes cursor positioning when there are newlines in
3626 overlay strings, e.g. in icomplete.el. (Bug#11035)
3627
9af5ed87
PE
36282012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3631
d1f55f16
CY
36322012-03-12 Chong Yidong <cyd@gnu.org>
3633
3634 * eval.c (inhibit_lisp_code): Rename from
3635 inhibit_window_configuration_change_hook; move from window.c.
3636
3637 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3638 * window.c (run_window_configuration_change_hook)
3639 (syms_of_window): Callers changed.
3640
66c5eebd
CY
36412012-03-11 Chong Yidong <cyd@gnu.org>
3642
413df973
CY
3643 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3644
66c5eebd
CY
3645 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3646
1de11f56
CY
36472012-03-10 Chong Yidong <cyd@gnu.org>
3648
3649 * frame.c (other_visible_frames): Don't assume the selected frame
3650 is visible (Bug#10955).
3651
cae07000
SM
36522012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3653
3654 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3655
89c94350
JD
36562012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3657
3658 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3659 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3660 zero (Bug#10954).
3661
999dd333
GM
36622012-03-03 Glenn Morris <rgm@gnu.org>
3663
01a6dcc8 3664 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3665
de0100f2
EZ
36662012-03-02 Eli Zaretskii <eliz@gnu.org>
3667
3668 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3669 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3670 (redisplay_window, next_element_from_string): Fix typos in
3671 comments.
3e441275
EZ
3672 (redisplay_window): Pass to move_it_vertically the margin in
3673 pixels, not in screen lines.
de0100f2 3674
96a72ee9
GM
36752012-03-02 Glenn Morris <rgm@gnu.org>
3676
3677 * buffer.c (buffer-list-update-hook): Doc fix.
3678
312508d7
EZ
36792012-02-29 Eli Zaretskii <eliz@gnu.org>
3680
3681 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3682 push_it before setting up the iterator for the first overlay
3683 string, even if we have an empty string loaded.
3684 (next_overlay_string): If there's an empty string on the iterator
3685 stack, pop the stack. (Bug#10903)
3686
27f3c637
PE
36872012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3688
3689 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3690 Suggested by Stefan Monnier in
3691 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3692 * alloc.c (widen_to_Lisp_Object): New static function.
3693 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3694 and widening them to Lisp_Objects. This would work even if
3695 USE_LSB_TAG is defined and wide integers are used, which might
3696 happen in a future version of Emacs.
3697
3c9dfce6
CY
36982012-02-25 Chong Yidong <cyd@gnu.org>
3699
fa74b241
CY
3700 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3701 Doc fix.
3702
3c9dfce6
CY
3703 * xselect.c (Fx_selection_exists_p): Doc fix.
3704 (x_clipboard_manager_save_all): Print an informative message
3705 before saving to clipboard manager.
3706
9486df08
CY
37072012-02-24 Chong Yidong <cyd@gnu.org>
3708
3709 * keyboard.c (process_special_events): Handle all X selection
3710 requests in kbd_buffer, not just the next one (Bug#8869).
3711
f01d3321
CY
37122012-02-23 Chong Yidong <cyd@gnu.org>
3713
3714 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3715 call when setting menu-bar-lines and tool-bar-lines parameters.
3716 (unwind_create_frame_1): New helper function.
3717
3718 * window.c (inhibit_window_configuration_change_hook): New var.
3719 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3720 (syms_of_window): Initialize it.
f01d3321 3721
86b847b6
CY
37222012-02-22 Chong Yidong <cyd@gnu.org>
3723
3724 * xterm.c (x_draw_image_relief): Add missing type check for
3725 Vtool_bar_button_margin (Bug#10743).
3726
a59225b1
CY
37272012-02-21 Chong Yidong <cyd@gnu.org>
3728
3729 * fileio.c (Vfile_name_handler_alist): Doc fix.
3730
3731 * buffer.c (Fget_file_buffer): Protect against invalid file
3732 handler return value.
3733
310f5bd4
PE
37342012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3735
cb3a28cc
PE
3736 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3737 when computing $valmask.
3738
310f5bd4
PE
3739 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3740 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3741 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3742 It's useless in that case, and it can cause problems on hosts
3743 that allocate halves of EMACS_INT values separately.
3744 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3745 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3746 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3747 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3748 it avoids undefined behavior on hosts where shifting right by more
3749 than the word width has undefined behavior.
3750
2375c96a
CY
37512012-02-19 Chong Yidong <cyd@gnu.org>
3752
3753 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3754 (Funhandled_file_name_directory, Ffile_name_as_directory)
3755 (Fdirectory_file_name, Fexpand_file_name)
3756 (Fsubstitute_in_file_name): Protect against invalid file handler
3757 return values (Bug#10845).
3758
3eb49e71
EZ
37592012-02-18 Eli Zaretskii <eliz@gnu.org>
3760
3761 * .gdbinit (pitx): Fix incorrect references to fields of the
3762 iterator stack.
3763
7b926f3f
CY
37642012-02-17 Chong Yidong <cyd@gnu.org>
3765
3766 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3767
11273115
PE
37682012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3769
3770 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3771 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3772
c3a70e2b
CY
37732012-02-15 Chong Yidong <cyd@gnu.org>
3774
3775 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3776 marked as special. Also, starting docstrings with * is obsolete.
3777
0ca43699
AS
37782012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3779
3780 * gnutls.c (emacs_gnutls_write): Fix last change.
3781
2e8f3c56
LI
37822012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3783
3784 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3785 send_process.
3786
af70074f
SM
37872012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3788
3789 * keymap.c (Fsingle_key_description): Handle char ranges.
3790
95986d52
CY
37912012-02-12 Chong Yidong <cyd@gnu.org>
3792
afd83bd1
CY
3793 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3794 as that creates a dangerous corner case.
3795
95986d52
CY
3796 * window.c (Fdelete_window_internal): Invalidate the mouse
3797 highlight (Bug#9904).
3798
bd7da63e
GM
37992012-02-12 Glenn Morris <rgm@gnu.org>
3800
3801 * xselect.c (Fx_own_selection_internal)
3802 (Fx_get_selection_internal, Fx_disown_selection_internal)
3803 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3804 * nsselect.m (Fx_own_selection_internal)
3805 (Fx_disown_selection_internal, Fx_selection_exists_p)
3806 (Fx_selection_owner_p, Fx_get_selection_internal):
3807 Sync docs and argument specs with the xselect.c versions.
3808
77abcbc2
LI
38092012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3810
3811 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3812
90b671e2
EZ
38132012-02-11 Eli Zaretskii <eliz@gnu.org>
3814
1c0ca0b7
EZ
3815 * w32select.c (Fx_selection_exists_p): Sync doc string and
3816 argument list with xselect.c. (Bug#10783)
3817
3818 * w16select.c (Fx_selection_exists_p): Sync doc string and
3819 argument list with xselect.c. (Bug#10783)
90b671e2 3820
49241268
GM
38212012-02-10 Glenn Morris <rgm@gnu.org>
3822
3823 * fns.c (Fsecure_hash): Doc fix.
3824
f998bbe7 38252012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3826
3827 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3828
0992bd9c
CY
38292012-02-07 Chong Yidong <cyd@gnu.org>
3830
3831 * buffer.c (Fbuffer_local_variables)
3832 (buffer_lisp_local_variables): Handle unbound vars correctly;
3833 don't let Qunbound leak into Lisp.
3834
af008560
GM
38352012-02-07 Glenn Morris <rgm@gnu.org>
3836
dd605cc4
GM
3837 * image.c (Fimagemagick_types): Doc fix.
3838
af008560
GM
3839 * image.c (imagemagick-render-type): Change it from a lisp object
3840 to an integer. Move the doc here from the lisp manual.
3841 Treat all values not equal to 0 the same.
3842
1449fa1d
CY
38432012-02-06 Chong Yidong <cyd@gnu.org>
3844
3845 * doc.c (store_function_docstring): Avoid applying docstring of
3846 alias to base function (Bug#2603).
3847
3723ec07
AS
38482012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3849
3850 * .gdbinit (pp1, pv1): Remove redundant defines.
3851 (pr): Use pp.
3852
79c1cc1e
CY
38532012-02-04 Chong Yidong <cyd@gnu.org>
3854
3855 * nsterm.m: Declare a global (Bug#10694).
3856
d7f29f8e
EZ
38572012-02-04 Eli Zaretskii <eliz@gnu.org>
3858
cae07000
SM
3859 * w32.c (get_emacs_configuration_options):
3860 Include --enable-checking, if specified, in the return value.
d7f29f8e 3861
3b95a6f9
MR
38622012-02-04 Martin Rudalics <rudalics@gmx.at>
3863
3864 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3865 after rounding frame sizes. (Bug#9723)
3866
d6fa96a6
EZ
38672012-02-04 Eli Zaretskii <eliz@gnu.org>
3868
3869 * keyboard.c (adjust_point_for_property): Don't position point
3870 before BEGV. (Bug#10696)
3871
df0b2940
PE
38722012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3873
3874 Handle overflow when computing char display width (Bug#9496).
3875 * character.c (char_width): Return EMACS_INT, not int.
3876 (char_width, c_string_width): Check for overflow when
3877 computing the width; this is possible now that individual
3878 characters can have unbounded width. Problem introduced
3879 by merge from Emacs 23 on 2012-01-19.
3880
6bee44d6
MA
38812012-02-02 Michael Albinus <michael.albinus@gmx.de>
3882
3883 * dbusbind.c (Fdbus_register_method): Mention the return value
3884 :ignore in the docstring.
3885
44f92739
GM
38862012-02-02 Glenn Morris <rgm@gnu.org>
3887
1b9f60cc
GM
3888 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3889
44f92739
GM
3890 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3891 Unconditionally set to t. (Bug#10673)
3892 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3893 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3894 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3895
c5d3843c
KH
38962012-02-02 Kenichi Handa <handa@m17n.org>
3897
3898 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3899 0, do not call append_composite_glyph.
3900
159462d4 39012012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3902
3903 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3904 NULL (Bug#6988).
3905 (x_produce_glyphs): If the component of a composition is a null
3906 string, set it->pixel_width to 1 to avoid zero-width glyph.
3907
78cef877
EZ
39082012-02-01 Eli Zaretskii <eliz@gnu.org>
3909
3910 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3911 first 2 arguments are identical. This makes inserting large
3912 output from a subprocess an order of magnitude faster on
3913 MS-Windows, where all sbrk'ed memory is always contiguous.
3914
97897668
GM
39152012-01-31 Glenn Morris <rgm@gnu.org>
3916
3917 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3918 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3919 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3920
31fd3586
GM
39212012-01-29 Glenn Morris <rgm@gnu.org>
3922
3923 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3924
0e24a8b2
CY
39252012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3926
3927 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3928
cc0adcb0
CY
39292012-01-28 Chong Yidong <cyd@gnu.org>
3930
3931 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3932
acc28cb9
CY
39332012-01-26 Chong Yidong <cyd@gnu.org>
3934
9c69cfb7
CY
3935 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3936
acc28cb9
CY
3937 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3938 repeat counts (Bug#10507).
3939
48da7392
GM
39402012-01-26 Glenn Morris <rgm@gnu.org>
3941
3942 * lread.c (syms_of_lread): Doc fix.
3943
14af5f7f
CY
39442012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3945
3946 * coding.c (encode_designation_at_bol): Change return value to
3947 EMACS_INT.
3948
0b21c100
CY
39492012-01-25 Chong Yidong <cyd@gnu.org>
3950
3951 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3952
3c2907f7
CY
39532012-01-21 Chong Yidong <cyd@gnu.org>
3954
3955 * floatfns.c (Fcopysign): Make the second argument non-optional,
3956 since nil is not allowed anyway.
3957
959ad23f
AS
39582012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3959
3960 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3961 (send_process): Likewise.
3962
34a02f46
MR
39632012-01-19 Martin Rudalics <rudalics@gmx.at>
3964
3965 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3966 (Vwindow_persistent_parameters): Do not use Qstate.
3967 Rewrite doc-strings.
34a02f46 3968
1259009a 39692012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3970
3971 * character.c (char_width): New function.
70d4fdf6
GM
3972 (Fchar_width, c_string_width, lisp_string_width):
3973 Use char_width (Bug#9496).
25ed9e61 3974
6a6ee00d
MR
39752012-01-16 Martin Rudalics <rudalics@gmx.at>
3976
3977 * window.c (Vwindow_persistent_parameters): New variable.
3978 (Fset_window_configuration, save_window_save): Handle persistent
3979 window parameters.
3980
c85efaf7
EZ
39812012-01-14 Eli Zaretskii <eliz@gnu.org>
3982
3983 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3984 thrashing the stack of the thread. (Bug#9087)
3985
5944709e
PE
39862012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3989
e71f5d99
EZ
39902012-01-11 Eli Zaretskii <eliz@gnu.org>
3991
3992 * xdisp.c (rows_from_pos_range): Handle the case where the
3993 highlight ends on a newline. (Bug#10464)
3994 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3995 he end column for display of highlight that ends on a newline
3996 before a R2L line.
3997
ce316182
GM
39982012-01-11 Glenn Morris <rgm@gnu.org>
3999
4000 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4001 from load-path also when installation-directory is nil. (Bug#10208)
4002
5b43da69
GM
40032012-01-10 Glenn Morris <rgm@gnu.org>
4004
74cc8ff9
GM
4005 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4006
7d8d6e4e
GM
4007 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4008 Update template values to be closer to their typical values these days.
5b43da69 4009
a0db8d43
EZ
40102012-01-09 Eli Zaretskii <eliz@gnu.org>
4011
4012 * xdisp.c (rows_from_pos_range): Accept additional argument
4013 DISP_STRING, and accept any glyph in a row whose object is that
4014 string as eligible for mouse highlight. Fixes mouse highlight of
4015 display strings from overlays. (Bug#10464)
4016
9a0115ab 40172012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4018
b9110d6a 4019 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4020 * fileio.c (auto_saving_dir_umask): New static var.
4021 (Fmake_directory_internal): Use it.
4022 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4023 creating the directory. The old code temporarily assigns
4024 too-generous permissions to the directory.
4025 (do_auto_save_eh): Clear it.
b9110d6a 4026 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4027 that the var is always cleared.
4028
6c1bd3f3
EZ
40292012-01-07 Eli Zaretskii <eliz@gnu.org>
4030
4031 * search.c (scan_buffer): Pass character positions to
4032 know_region_cache, not byte positions. (Bug#6540)
4033
069d2b50
L
40342012-01-07 LynX <_LynX@bk.ru> (tiny change)
4035
4036 * w32.c (sys_rename): Report EXDEV when rename of a directory
4037 fails because the target is on another logical disk. (Bug#10284)
4038
75bf0d33
DB
40392012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4040
4041 * xterm.c (x_embed_request_focus): New function.
4042
4043 * xterm.h: Add prototype.
4044
4045 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4046
1c6e5a32
GM
40472012-01-05 Glenn Morris <rgm@gnu.org>
4048
4049 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4050
651e947e
EZ
40512012-01-01 Eli Zaretskii <eliz@gnu.org>
4052
4053 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4054 Load gnutls_transport_set_lowat only if GnuTLS version is below
4055 2.11.1.
4056 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4057 GnuTLS versions below 2.11.1.
4058
3778cdd8
AL
40592011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4060
4061 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4062 to the doc string advising against its use for altering the way
4063 windows are scrolled.
4064
0e5317f7
KH
40652011-12-28 Kenichi Handa <handa@m17n.org>
4066
4067 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4068 coding-system ASCII compatible only when it does not produce BOM
4069 on encoding (Bug#10383).
4070
93d5ca1f
JD
40712011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4072
4073 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4074 can scroll.
4075 (create_and_show_popup_menu): Always use menu_position_func for
4076 Gtk3 (Bug#10361).
4077
ca22b785
AS
40782011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4079
4080 * callint.c (Fcall_interactively): Don't truncate prompt string.
4081
d048e1e6
EZ
40822011-12-23 Eli Zaretskii <eliz@gnu.org>
4083
4084 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4085 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4086 resumed from there (after widening). (Bug#10360)
d048e1e6 4087
5ccaba1f
JD
40882011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4089
4090 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4091
204ee57f
JD
40922011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4093
b81d40f0
JB
4094 * nsterm.m (x_free_frame_resources):
4095 Release f->output_data.ns->miniimage.
204ee57f
JD
4096 (ns_index_color): Fix indentation. Do not retain
4097 color_table->colors[i].
4098
4099 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4100 before returning.
4101
4102 * nsfns.m (x_set_background_color): Assign return value from
4103 ns_index_color to face-background instead of NSColor*.
4104 (ns_implicitly_set_icon_type): Fix indentation.
4105 Change assignment in for loop to comparison.
4106
4107 * emacs.c (ns_pool): New variable.
4108 (main): Assign ns_pool.
4109 (Fkill_emacs): Call ns_release_autorelease_pool.
4110
4111 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4112 autorelease fdesc, release fdAttrs and tdict.
4113 (ns_get_covering_families): Release charset.
4114 (ns_findfonts): Release NSFontDescriptor created with new.
4115 (ns_uni_to_glyphs): Fix indentation.
4116 (setString): Release attrStr before assigning new value.
4117
c803b2b7
JD
41182011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4119
678f4426
JD
4120 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4121 and NS_IMPL_COCOA.
4122 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4123 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4124
cd394be1 41252011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4126
5fecd5fc
JD
4127 * nsterm.m (ns_term_init): Subscribe for notifications
4128 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4129 to method trackingNotification in EmacsMenu.
4130
4131 * nsmenu.m (trackingMenu): New variable.
3771cb17 4132 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4133 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4134 from Aquamacs (Bug#7030).
678f4426
JD
4135
41362011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4137
c803b2b7
JD
4138 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4139 (symbol_to_nsstring): Fix indentation.
4140 (ns_symbol_to_pb): New function.
cae07000
SM
4141 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4142 (Fns_rotate_cut_buffers_internal): Remove.
4143 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4144 Fns_store_cut_buffer_internal.
4145 (ns_get_foreign_selection, Fx_own_selection_internal)
4146 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4147 (Fns_get_selection_internal, Fns_store_selection_internal):
4148 Use ns_symbol_to_pb and check if return value is nil.
4149 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4150 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4151 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4152 renamed to Sns_store_selection_internal.
4153 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4154 and remove this function.
4155 (ns_handle_selection_clear): Remove, never used.
4156 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4157 here.
4158
e1b01a3a
KB
41592011-12-17 Ken Brown <kbrown@cornell.edu>
4160
4161 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4162 GID is unknown (Bug#10257).
4163
2adb6e85
PE
41642011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4165
4166 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4167 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4168 which caused a build failure on GNU/Linux IA-64. This problem was
4169 introduced by my 2011-10-07 patch.
4170
d1d7b339
JL
41712011-12-15 Juri Linkov <juri@jurta.org>
4172
4173 * image.c (imagemagick_error): New function. (Bug#10112)
4174 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4175 Use `imagemagick_error' where ImageMagick functions return
4176 `MagickFalse'.
4177 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4178 proper order.
4179
100d5755
KH
41802011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4181
4182 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4183 fill background (Bug#8992).
4184
454592a6
MR
41852011-12-13 Martin Rudalics <rudalics@gmx.at>
4186
4187 * window.c (Vwindow_combination_resize)
4188 (Vwindow_combination_limit): Use t instead of non-nil in
4189 doc-strings.
61d4b438
MR
4190 (Vrecenter_redisplay): Add first sentence of doc-string on
4191 separate line.
53524d93 4192 (Frecenter): Fix doc-string typo.
454592a6 4193
3633e3aa
KH
41942011-12-11 Kenichi Handa <handa@m17n.org>
4195
4196 * coding.c (Funencodable_char_position): Pay attention to the
4197 buffer text relocation (Bug#9389).
4198
7b9d523a 41992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4200
7b9d523a
JD
4201 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4202 gtk_init (Bug#10100).
4203
b73189c6
EZ
42042011-12-10 Eli Zaretskii <eliz@gnu.org>
4205
4206 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4207 IT->string is nil. (Bug#10263)
4208
f7dfe5d6
JD
42092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4210
83faebb4
JD
4211 * nsterm.h (x_free_frame_resources): Declare.
4212
f7dfe5d6
JD
4213 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4214 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4215
4216 * nsterm.h (ns_get_defaults_value): Declare.
4217
4218 * nsterm.m (ns_default): Call ns_get_defaults_value.
4219
7cd4e72c
EZ
42202011-12-09 Eli Zaretskii <eliz@gnu.org>
4221
4222 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4223 (Bug#10170)
4224
b34d7317
YM
42252011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4226
4227 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4228 that where the value of an _OBJC_* symbol points to is in the .bss
4229 section (Bug#10240).
4230
76470ad1
KH
42312011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4232
4233 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4234 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4235
745fff94
KH
42362011-12-08 Kenichi Handa <handa@m17n.org>
4237
4238 * ftfont.c (get_adstyle_property): Fix previous change
4239 (Bug#10233).
4240
6e44397c
JB
42412011-12-07 Juanma Barranquero <lekktu@gmail.com>
4242
4243 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4244 dirs from the default value of EMACSLOADPATH (bug#10208).
4245
7efa6272
GM
42462011-12-07 Glenn Morris <rgm@gnu.org>
4247
4248 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4249 installation and source directories as well. (Bug#10208)
4250
f6fc4d87
CY
42512011-12-06 Chong Yidong <cyd@gnu.org>
4252
4253 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4254
2bf26180
GM
42552011-12-06 Glenn Morris <rgm@gnu.org>
4256
4257 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4258 as an error, not just -1. (Bug#10217)
4259
3a6ad4f0
CY
42602011-12-05 Chong Yidong <cyd@gnu.org>
4261
4262 * keyboard.c (process_special_events): New function.
4263 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4264
75a3b399
PE
42652011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4266
4267 * coding.c (encode_designation_at_bol): Don't use uninitialized
4268 local variable (Bug#9318).
4269
c3c9e25e
KH
42702011-12-05 Kenichi Handa <handa@m17n.org>
4271
4272 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4273 return Qnil (Bug#8046, Bug#10193).
4274
5eb05ea3
KH
42752011-12-05 Kenichi Handa <handa@m17n.org>
4276
4277 * coding.c (encode_designation_at_bol): New args charbuf_end and
4278 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4279 (coding_set_source): Return how many bytes coding->source was
4280 relocated.
4281 (coding_set_destination): Return how many bytes
4282 coding->destination was relocated.
4283 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4284 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4285
42862011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4287
4288 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4289 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4290 macro (Bug#9318).
4291
42922011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4293
4294 The following changes are to fix Bug#9318.
4295
a79703f5 4296 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4297 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4298 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4299 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4300
7dbda6df
JB
43012011-12-05 Juanma Barranquero <lekktu@gmail.com>
4302
4303 * lisp.h (process_quit_flag): Fix external declaration.
4304
6d5eb5b0
SM
43052011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4306
4307 Don't macro-inline non-performance-critical code.
4308 * eval.c (process_quit_flag): New function.
4309 * lisp.h (QUIT): Use it.
4310
a0c3fad0
JD
43112011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4312
4313 * nsfns.m (get_geometry_from_preferences): New function.
4314 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4315
6c07aac2
AS
43162011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4317
4318 * emacs.c (Qkill_emacs): Define.
4319 (syms_of_emacs): Initialize it.
4320 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4321 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4322 (quit_throw_to_read_char): Add parameter `from_signal'.
4323 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4324 * lisp.h (QUIT): Call Fkill_emacs if requested.
4325
c052ead4
JD
43262011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4327
4328 * widget.c (update_wm_hints): Return if wmshell is null.
4329 (widget_update_wm_size_hints): New function.
4330
4331 * widget.h (widget_update_wm_size_hints): Declare.
4332
4333 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4334 widget_update_wm_size_hints (Bug#10104).
4335
9e49252b
EZ
43362011-12-03 Eli Zaretskii <eliz@gnu.org>
4337
4338 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4339 before a newline, prepare the bidi iterator for consuming the
4340 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4341 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4342
02b16839
JL
43432011-12-02 Juri Linkov <juri@jurta.org>
4344
4345 * search.c (Fword_search_regexp): New Lisp function created from
4346 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4347 (Fword_search_backward, Fword_search_forward)
4348 (Fword_search_backward_lax, Fword_search_forward_lax):
4349 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4350 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4351
0068070e
SM
43522011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4353
4354 * fileio.c (Finsert_file_contents): Move after-change-function call
4355 to before the "handled:" label, since all "goto handled" appear in
4356 cases where the *-change-functions have already been properly called
4357 (bug#10117).
4358
3360a3fc
AS
43592011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4360
4361 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4362 waiting for input. (Bug#10169)
4363
73d6c093
EZ
43642011-11-30 Eli Zaretskii <eliz@gnu.org>
4365
4366 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4367 verifies glyph row's hash code--we have just reallocated the
4368 glyphs, so their contents can be complete garbage. (Bug#10164)
4369
febe6bea
JB
43702011-11-30 Juanma Barranquero <lekktu@gmail.com>
4371
4372 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4373
801a4313
EZ
43742011-11-30 Eli Zaretskii <eliz@gnu.org>
4375
4376 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4377 attributes are tested _before_ calling verify_row_hash, to protect
4378 against GCC re-ordering of the tests. (Bug#10164)
4379
2b56b87e
JD
43802011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4381
4382 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4383
4384 * xterm.c (handle_one_xevent): Only set async_visible and friends
4385 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4386 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4387 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4388
dbf31225
PE
43892011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4390
4391 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4392 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4393 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4394 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4395 All uses changed to use GCPRO1 etc.
4396 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4397 Revert to old implementation (i.e., before 2011-03-11).
4398
1305621b
YM
43992011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4400
4401 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4402 of scroll runs so as to avoid assigning disabled bogus rows and
4403 unnecessary graphics copy operations.
4404
8c9afb46
EZ
44052011-11-27 Eli Zaretskii <eliz@gnu.org>
4406
4407 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4408 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4409 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4410 (malloc, free, realloc, calloc): Redirect to e_* only when
4411 compiling Emacs.
4412
4413 * lisp.h (GCTYPEBITS): Move before first use.
4414 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4415 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4416 this macro definition.
4417
4418 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4419 _MSC_VER.
4420
54e9e3bf
JD
44212011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4422
6d5eb5b0
SM
4423 * gtkutil.c (xg_create_frame_widgets):
4424 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4425 present with Gtk+ 2.0.
4426
83aca1cb
PE
44272011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4428
4429 * fileio.c (Finsert_file_contents): Undo previous change; see
4430 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4431
5b76caa4
PE
44322011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4433
4434 Rename locals to avoid shadowing.
4435 * fileio.c (Finsert_file_contents):
4436 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4437 * process.c (wait_reading_process_output):
4438 Rename inner 'proc' to 'p' to avoid shadowing.
4439 Indent for consistency with usual Emacs style.
4440
8c535114
EZ
44412011-11-25 Eli Zaretskii <eliz@gnu.org>
4442
4443 * xdisp.c (redisplay_window): If cursor row is not fully visible
4444 after recentering, and scroll-conservatively is set to a large
4445 number, scroll window by a few more lines to make the cursor fully
4446 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4447 (start_display): Don't move to the next line if the display should
4448 start at a newline that is part of a display vector or an overlay
4449 string. (Bug#10119)
8c535114 4450
fa4fdb5c
JL
44512011-11-24 Juri Linkov <juri@jurta.org>
4452
4453 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4454 after the `MagickPingImage' call. (Bug#10112)
4455
90ec88df
CY
44562011-11-23 Chong Yidong <cyd@gnu.org>
4457
4458 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4459
56e2e794
MR
44602011-11-23 Martin Rudalics <rudalics@gmx.at>
4461
4462 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4463 making another buffer current. (Bug#10114)
4464
b6e64c41
GM
44652011-11-23 Glenn Morris <rgm@gnu.org>
4466
4467 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4468
6b21de18
CY
44692011-11-23 Chong Yidong <cyd@gnu.org>
4470
4471 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4472 using it (Bug#5984).
4473
b12cd789
EZ
44742011-11-22 Eli Zaretskii <eliz@gnu.org>
4475
4476 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4477 and header-lines, as they don't have one computed for them.
4478 (Bug#10098)
4479
4480 * .gdbinit (prow): Make displayed values more self-explaining.
4481 Add row's hash code.
4482
261b6fd4
LMI
44832011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4484
4485 * process.c (wait_reading_process_output): Fix asynchrounous
4486 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4487 (wait_reading_process_output): Add comment and URL.
261b6fd4 4488
e7cfd277
JD
44892011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4490
4491 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4492
a9b9b7f5
CY
44932011-11-21 Chong Yidong <cyd@gnu.org>
4494
4495 * window.c (Fnext_window, Fprevious_window): Doc fix.
4496
b0d15b4f
SM
44972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4498
4499 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4500
fe7a3057
JB
45012011-11-20 Juanma Barranquero <lekktu@gmail.com>
4502
4503 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4504
d2999b1a
MR
45052011-11-20 Martin Rudalics <rudalics@gmx.at>
4506
4507 * window.c (Fset_window_combination_limit): Rename argument
4508 STATUS to LIMIT.
4509 (Vwindow_combination_limit): Remove "status" from doc-string.
4510
d5ff9cd0
AS
45112011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4512
4513 * m/ibms390.h: Remove.
4514 * m/ibms390x.h: Don't include "ibms390.h".
4515
a5bb9bd3
SM
45162011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4517
4518 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4519 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4520
cd1181db
JB
45212011-11-20 Juanma Barranquero <lekktu@gmail.com>
4522
4523 * casetab.c (Fset_case_table):
4524 * charset.c (Fcharset_after): Fix typos.
4525
615a3b8d 45262011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4527
17e845af
PE
4528 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4529 Otherwise, valgrind does not work on some platforms.
4530 Problem reported by Andreas Schwab in
6a0bf43d
PE
4531 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4532 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4533 is set, removing the need for VIRT_ADDRESS_VARIES.
4534 (PURE_P): Use a more-efficient implementation that needs just one
4535 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4536 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4537 to 4 (xorl, subq, cmpq, setbe).
4538 * alloc.c (pure): Always extern now, since that's the
4539 VIRT_ADDR_VARIES behavior.
4540 (PURE_POINTER_P): Use a single comparison, not two, for
4541 consistency with the new puresize.h.
4542 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4543 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4544 Remove VIRT_ADDR_VARIES no longer needed.
4545
f8fe6f96
EZ
45462011-11-19 Eli Zaretskii <eliz@gnu.org>
4547
4548 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4549 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4550 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4551 behave as if the cursor position were at the window margin.
4552
4553 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4554 and the cursor position is out of bounds, behave as if the cursor
4555 position were at the window margin. (Bug#10075)
4556
df05a53c
CY
45572011-11-18 Chong Yidong <cyd@gnu.org>
4558
4559 * window.c (Fwindow_combination_limit): Make first argument
4560 non-optional, since it is meaningless for live windows like the
4561 selected window.
61ccba97 4562
2071918e
DA
45632011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4564
4565 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4566
b50a28de
SM
45672011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4568
4569 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4570 (graft_intervals_into_buffer): Simplify.
4571
015137db
EZ
45722011-11-18 Eli Zaretskii <eliz@gnu.org>
4573
4574 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4575 hash values of the two rows.
4576 (copy_row_except_pointers): Preserve the used[] arrays and the
4577 hash values of the two rows. (Bug#10035)
68c95424 4578 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4579
4580 * xdisp.c (row_hash): New function, body extracted from
4581 compute_line_metrics.
4582 (compute_line_metrics): Call row_hash, instead of computing the
4583 hash code inline.
4584
4585 * dispnew.c (verify_row_hash): Call row_hash for computing the
4586 hash code of a row, instead of duplicating code from xdisp.c.
4587
4588 * dispextern.h (row_hash): Add prototype.
4589
a2addb04
TH
45902011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4591
4592 * frame.c (delete_frame): Don't delete the terminal when the last
4593 X frame is closed if emacs is built with GTK toolkit.
4594
df85d315
JB
45952011-11-17 Juanma Barranquero <lekktu@gmail.com>
4596
4597 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4598
a0c2d0ae
MR
45992011-11-17 Martin Rudalics <rudalics@gmx.at>
4600
4601 * window.c (Vwindow_splits): Rename to
4602 Vwindow_combination_resize. Suggested by Juri Linkov.
4603 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4604 of Vwindow_splits.
4605
58179cce
JB
46062011-11-16 Juanma Barranquero <lekktu@gmail.com>
4607
7877f373
JB
4608 * nsfns.m (Fns_font_name):
4609 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4610
b6f67890
MR
46112011-11-16 Martin Rudalics <rudalics@gmx.at>
4612
4613 * window.h (window): Rename slot "nest" to "combination_limit".
4614 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4615 (Fset_window_nest): Rename to Fset_window_combination_limit.
4616 (Vwindow_nest): Rename to Vwindow_combination_limit.
4617 (recombine_windows, make_parent_window, make_window)
4618 (Fsplit_window_internal, saved_window)
4619 (Fset_window_configuration, save_window_save): Rename all
4620 occurrences of window_nest to window_combination_limit.
4621
c7015153
JB
46222011-11-15 Juanma Barranquero <lekktu@gmail.com>
4623
4624 * image.c (imagemagick_load_image): Fix typo.
4625
322ad6ec
EZ
46262011-11-14 Eli Zaretskii <eliz@gnu.org>
4627
4628 * xdisp.c (display_line): Move the call to
4629 highlight_trailing_whitespace before the call to
4630 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4631 faces of all the glyphs to compute ROW's hash value.
4632 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4633
f067b8ec
JB
46342011-11-14 Juanma Barranquero <lekktu@gmail.com>
4635
4636 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4637 just return (bug#10044).
4638
1e5b2111
EZ
46392011-11-12 Eli Zaretskii <eliz@gnu.org>
4640
7ef3cbd5
EZ
4641 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4642 with user-defined heap size. Bump the default size of the temacs
4643 heap to 27MB, to avoid memory warning when running temacs.
4644 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4645
1e5b2111
EZ
4646 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4647 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4648 (verify_row_hash) [XASSERTS]: New function.
4649 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4650 that the hash value of glyph rows is correct.
1e5b2111 4651
89d61221
MR
46522011-11-12 Martin Rudalics <rudalics@gmx.at>
4653
4654 * window.h (window): Remove splits slot.
4655 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4656 (Fdelete_other_windows_internal, make_parent_window)
4657 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4658 (Fset_window_configuration, save_window_save): Don't deal with
4659 split status of windows.
4660 (saved_window): Remove splits slot.
4661 (Vwindow_splits): Rewrite doc-string.
4662
97f18cc8
JD
46632011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4664
4665 * xfns.c (unwind_create_frame):
4666 * nsfns.m (unwind_create_frame):
4667 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4668 Vframe_list (Bug#9999).
4669
22a648b4
DA
46702011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4671
0b381c7e 4672 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4673
659afede
KH
46742011-11-11 Kenichi Handa <handa@m17n.org>
4675
4676 * callproc.c (Fcall_process): Set the member dst_multibyte of
4677 process_coding.
4678
9ac0394b
KH
46792011-11-11 Johan Bockgård <bojohan@gnu.org>
4680
4681 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4682 avoid a crash (bug#9496).
4683
2fbdc249
CY
46842011-11-09 Chong Yidong <cyd@gnu.org>
4685
4686 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4687 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4688
ac6b1f81
PE
46892011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4690
4691 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4692
09db192c
PE
46932011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4694
4695 Avoid some portability problems by eschewing 'extern inline' functions.
4696 The trivial performance wins aren't worth the portability hassles; see
4697 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4698 et seq.
4699 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4700 (window_box_width, window_box_left, window_box_left_offset)
4701 (window_box_right, window_box_right_offset): Undo previous change,
4702 by removing the "extern"s.
4703 * intervals.c (adjust_intervals_for_insertion)
4704 (adjust_intervals_for_deletion): Undo previous change,
4705 making these static again.
4706 (offset_intervals, temp_set_point_both, temp_set_point)
4707 (copy_intervals_to_string): No longer inline.
4708 * xdisp.c (window_text_bottom_y, window_box_width)
4709 (window_box_height, window_box_left_offset)
4710 (window_box_right_offset, window_box_left, window_box_right)
4711 (window_box): No longer inline.
4712
105216ed
CY
47132011-11-08 Chong Yidong <cyd@gnu.org>
4714
4715 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4716 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4717 Signal an error if not a live window.
105216ed
CY
4718 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4719 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4720
ae9e237f
JB
47212011-11-07 Juanma Barranquero <lekktu@gmail.com>
4722
4723 * lisp.h (syms_of_abbrev): Remove declaration.
4724 Reported by CHENG Gao <chenggao@royau.me>.
4725
c7aa8333
EZ
47262011-11-07 Eli Zaretskii <eliz@gnu.org>
4727
4728 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4729 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4730 of temacs in GUI mode.
4731
be7f5545
MR
47322011-11-07 Martin Rudalics <rudalics@gmx.at>
4733
4734 * window.h: Declare delete_all_child_windows instead of
4735 delete_all_subwindows.
4736 * window.c (Fwindow_nest, Fset_window_nest)
4737 (Fset_window_new_total, Fset_window_new_normal)
4738 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4739 (delete_all_subwindows): Rename to delete_all_child_windows.
4740 (Fdelete_other_windows_internal, Fset_window_configuration):
4741 Call delete_all_child_windows instead of delete_all_subwindows.
4742 * frame.c (delete_frame): Call delete_all_child_windows instead
4743 of delete_all_subwindows.
4744
ca78dc43
PE
47452011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4746
4747 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4748 This is also needed for porting to any host where GC_MARK_STACK is
4749 not GC_MAKE_GCPROS_NOOPS.
4750 (which_symbols): Use it.
4751
a0241d01
KH
47522011-11-07 Kenichi Handa <handa@m17n.org>
4753
4754 * coding.c (coding_set_destination): Check coding->src_pos only
4755 when coding->src_object is a buffer (bug#9910).
4756
4757 * process.c (send_process): Set the member src_multibyte of coding
4758 to 0 (bug#9911) when sending a unibyte text.
4759
4760 * callproc.c (Fcall_process): Set the member src_multibyte of
4761 process_coding to 0 (bug#9912).
4762
a64bfdfa 47632011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4764
4765 * xmenu.c (cleanup_widget_value_tree): New function.
4766 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4767 calling free_menubar_widget_value_tree directly (Bug#9830).
4768
cb41b32a
PE
47692011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4770
4771 Fix some portability problems with 'inline'.
4772 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4773 (window_box_width, window_box_left, window_box_left_offset)
4774 (window_box_right, window_box_right_offset): Declare extern.
4775 Otherwise, these inline functions do not conform to C99 and
4776 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4777 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4778 * intervals.c (adjust_intervals_for_insertion)
4779 (adjust_intervals_for_deletion): Now extern, because otherwise the
4780 extern inline functions 'offset_intervals' couldn't refer to it.
4781 (static_offset_intervals): Remove.
4782 (offset_intervals): Rewrite using the old contents of
4783 static_offset_intervals. The old version didn't conform to C99
4784 because an extern inline function contained a reference to an
4785 identifier with static linkage.
4786
b7041366
AS
47872011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4788
4789 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4790 GC.
4791
88a37c4d
EZ
47922011-11-06 Eli Zaretskii <eliz@gnu.org>
4793
4794 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4795 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4796 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4797 return Qleft_to_right.
4798
49745b39
CY
47992011-11-06 Chong Yidong <cyd@gnu.org>
4800
4801 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4802 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4803 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4804 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4805 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4806 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4807 (Fwindow_vscroll): Doc fix.
4808 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4809 argument, since it makes no sense to pass a live window and for
4810 consistency with window-child.
4811
1f05cd82
CS
48122011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4813
4814 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4815 support MSVC.
4816
22610910
JR
48172011-11-05 Jason Rumney <jasonr@gnu.org>
4818
4819 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4820 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4821 fonts (Bug#6029).
4822 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4823 bitwise arithmetic preventing use of unicode-sip and non-truetype
4824 opentype fonts.
4825
a06776b2
EZ
48262011-11-05 Eli Zaretskii <eliz@gnu.org>
4827
3ad924ba
EZ
4828 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4829 "emacs"-only part.
4830
a06776b2
EZ
4831 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4832 initialization code to keep similarity to xfns.c after changes
4833 from 2011-11-05.
4834
c9e7db78
JD
48352011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4836
a97f8f3f
JD
4837 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4838 (unwind_create_frame): New function (Bug#9943).
4839 (Fx_create_frame): Restructure code to be more similar to the one in
4840 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4841 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4842 Move terminal->reference_count++ just before making the frame official
4843 (Bug#9943).
4844
4845 * nsterm.m (x_free_frame_resources): New function.
4846 (x_destroy_window): Move code to x_free_frame_resources.
4847
c9e7db78 4848 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4849 (Fx_create_frame, x_create_tip_frame):
4850 Move terminal->reference_count++ just before making the frame
75f1671a 4851 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4852 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4853
a6fc3b5c
EZ
48542011-11-05 Eli Zaretskii <eliz@gnu.org>
4855
4856 Support MSVC build with newer versions of Visual Studio.
4857 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4858 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4859 nt/gmake.defs.
4860
4861 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4862 which are not supported by MSVC.
4863 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4864 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4865 bitfields.
4866 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4867 types in bitfields.
4868 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4869
4870 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4871
58179cce 48722011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4873
4874 Support MSVC build with newer versions of Visual Studio.
4875 * w32.c: Don't include w32api.h for MSVC.
4876 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4877
4878 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4879 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4880 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4881 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4882 e_* cousins.
4883 (alloca) [_MSC_VER]: Define to _alloca.
4884
4885 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4886
4887 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4888
a58c13ed
EZ
48892011-11-04 Eli Zaretskii <eliz@gnu.org>
4890
4891 * xdisp.c (note_mouse_highlight): If either of
4892 previous/next-single-property-change returns nil, treat that as
4893 the beginning or the end of the buffer. (Bug#9955)
4894
fe0b6370
JD
48952011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4896
a58c13ed 4897 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4898 label is not null (Bug#9951).
4899 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4900 may be NULL.
4901
89bd5ee1
EZ
49022011-11-04 Eli Zaretskii <eliz@gnu.org>
4903
4904 * window.c (Fwindow_body_size): Mention in the doc string that the
4905 return value is in frame's canonical units. (Bug#9949)
4906
84c3edb9
EZ
49072011-11-03 Eli Zaretskii <eliz@gnu.org>
4908
4e2fb5c7
EZ
4909 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4910
84c3edb9 4911 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4912 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4913 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4914
bc17a887
EZ
49152011-11-01 Eli Zaretskii <eliz@gnu.org>
4916
4917 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4918 Don't stop backward scan on the continuation glyph, even though
4919 its CHARPOS is positive.
6d5eb5b0
SM
4920 (mouse_face_from_buffer_pos, note_mouse_highlight):
4921 Rename cover_string to disp_string.
bc17a887 4922
4ee88440
MR
49232011-11-01 Martin Rudalics <rudalics@gmx.at>
4924
4925 * window.c (temp_output_buffer_show): Don't use
4926 Vtemp_buffer_show_specifiers.
4927 (Vtemp_buffer_show_specifiers): Remove unused variable.
4928
c2ff3c02
EZ
49292011-10-30 Eli Zaretskii <eliz@gnu.org>
4930
4931 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4932 past the beginning of the current glyph matrix.
4933
58179cce 49342011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4935
4936 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4937 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4938 HAVE_GTK3 (Bug#9869).
b77a6a7f 4939
3b574623
JD
4940 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4941 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4942
b77a6a7f
JD
4943 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4944
4945 * xterm.c: Declare x_handle_net_wm_state to return int.
4946 (handle_one_xevent): Check if we are iconified but don't have
4947 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4948 (get_current_wm_state): Return non-zero if not hidden,
4949 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4950 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4951 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4952 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4953
196e41e4
PE
49542011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4955
4956 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4957 so that this new function doesn't get optimized away by a
4958 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4959
021f2e1a
AS
49602011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4961
4962 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4963
8b058d44
EZ
49642011-10-29 Eli Zaretskii <eliz@gnu.org>
4965
4966 Fix the `xbytecode' command.
4967 * .gdbinit (xprintbytestr): New command.
b50a28de 4968 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4969 (xbytecode): Print the byte-code string as well.
4970
4452fb80
EZ
49712011-10-29 Kim Storm <storm@cua.dk>
4972
8b058d44
EZ
4973 * alloc.c (which_symbols): New function.
4974
21b72067
AS
49752011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4976
4977 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4978 line. (Bug#9903)
4979
83ed7b5c
GM
49802011-10-29 Glenn Morris <rgm@gnu.org>
4981
4982 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4983 Not clear what it was for, and it causes various bugs. (Bug#9839)
4984
5a7a728b
EZ
49852011-10-28 Eli Zaretskii <eliz@gnu.org>
4986
4987 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4988 possible random value that matches one of those tested as
4989 condition to clear the mouse face.
4990
d3d0842f
CY
49912011-10-28 Chong Yidong <cyd@gnu.org>
4992
4993 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4994
31b39d13
DN
49952011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4996
4997 * window.c (make_window): Initialize phys_cursor_on_p.
4998
9aba6043
SM
49992011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5000
5001 * lisp.h (struct Lisp_Symbol): Update comments.
5002
c20992f4
JB
50032011-10-28 Juanma Barranquero <lekktu@gmail.com>
5004
5005 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5006
db4f02f2
EZ
50072011-10-28 Eli Zaretskii <eliz@gnu.org>
5008
5009 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5010 <oslsachem@gmail.com> for helping to debug this.
5011
5012 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5013 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5014 (g_b_init_get_glyph_outline_w): New static variables.
5015 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5016 (GetGlyphOutlineW_Proc): New typedefs.
5017 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5018 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5019 New functions.
5020 (w32font_open_internal, compute_metrics):
5021 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5022 instead of calling the "wide" APIs directly.
5023
5024 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5025
5026 * w32.h (syms_of_w32font): Add prototype.
5027
87e68db4
JB
50282011-10-27 Juanma Barranquero <lekktu@gmail.com>
5029
5030 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5031 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5032 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5033 (Fmove_to_window_line): Doc fix.
5034
435c1d67
CY
50352011-10-27 Chong Yidong <cyd@gnu.org>
5036
5037 * process.c (make_process): Set gnutls_state to NULL.
5038
5039 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5040 non-NULL, regardless of GNUTLS_INITSTAGE.
5041 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5042 an error. Set process slots as soon as we allocate them.
5043
5044 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5045
9c6c6f49
CY
50462011-10-27 Chong Yidong <cyd@gnu.org>
5047
9aba6043
SM
5048 * gnutls.c (emacs_gnutls_deinit): New function.
5049 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5050 (Fgnutls_deinit, Fgnutls_boot): Use it.
5051
5052 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5053 (deactivate_process): Call emacs_gnutls_deinit.
5054
657d08d3
JB
50552011-10-27 Juanma Barranquero <lekktu@gmail.com>
5056
5057 * image.c (x_create_x_image_and_pixmap):
5058 * w32.c (sys_rename, w32_delayed_load):
5059 * w32font.c (fill_in_logfont):
5060 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5061
5430d399
JB
50622011-10-26 Juanma Barranquero <lekktu@gmail.com>
5063
5064 * w32fns.c (w32_default_color_map): New function,
5065 extracted from Fw32_default_color_map.
a7ef684b 5066 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5067
fe0055fa
PE
50682011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5069
5070 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5071
e6346438
SM
50722011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5073
5074 * keyboard.c (test_undefined): New function (bug#9751).
5075 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5076
e112cc37
ET
50772011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5078
5079 * sysdep.c (init_sys_modes): Fix the check for the controlling
5080 terminal (Bug#6649).
5081
7b5d6677
EZ
50822011-10-20 Eli Zaretskii <eliz@gnu.org>
5083
5084 * dispextern.h (struct bidi_it): New member next_en_type.
5085
5086 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5087 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5088 current character, check also for next_en_type being WEAK_EN.
5089 (bidi_resolve_weak): Don't enter the expensive loop if the current
5090 position is before next_en_pos. Record the bidi type of the first
5091 non-ET, non-BN character we find, in addition to its position.
5092 (bidi_level_of_next_char): Invalidate next_en_type when
5093 next_en_pos is over-stepped.
5094
7da0b018
PE
50952011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5096
5097 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5098 * editfns.c: Rewrite current-time-zone so that it invokes
5099 the equivalent of (format-time-string "%Z") to get the time zone name.
5100 This fixes a bug when the time zone name contains characters that
5101 need converting from the system time locale to Emacs internal format.
5102 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5103 that patch fixed format-time-string to do the conversion, but
5104 I forgot to fix current-time-zone.
5105 (format_time_string): New function, containing most of
5106 what Fformat_time_string used to contain.
5107 (Fformat_time_string): Rewrite in terms of format_time_string.
5108 This doesn't change this function's behavior.
5109 (current-time-zone): Rewrite to use format_time_string.
5110 This fixes the bug reported by Michael Schierl in
5111 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5112 Jason Rumney's 2007-06-07 change worked around this bug, but
5113 didn't fix it.
5114 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5115
8547b010
EZ
51162011-10-19 Eli Zaretskii <eliz@gnu.org>
5117
5118 * xdisp.c (start_display): If the character at POS is displayed
5119 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5120 (try_window_reusing_current_matrix): If a line ends in a display
5121 vector or the next line starts in a display vector, continue
5122 redrawing the window even though the character position of
5123 start_row was reached.
8547b010
EZ
5124 (Bug#9771, part 2)
5125
4e948d15
CY
51262011-10-18 Chong Yidong <cyd@gnu.org>
5127
5128 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5129 with nobreak-char-display too.
5130
4787455f
EZ
51312011-10-18 Eli Zaretskii <eliz@gnu.org>
5132
5133 Fix part 3 of bug#9771.
5134 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5135 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5136 non-neutral characters if the current character is a paragraph
5137 separator (a.k.a. Newline). This avoids running the same
5138 expensive loop twice, once when we consume the preceding newline
5139 and the other time when the line actually needs to be displayed.
5140 Avoid the loop when we see neutrals on the base embedding level
5141 following a character whose directionality is the same as the
5142 paragraph's. This avoids running the expensive loop when a line
5143 ends in a long sequence of neutrals, like control characters.
5144 Add assertion against STRONG_AL type. Slightly rearrange code
5145 that determines the type of a neutral given the first non-neutral
5146 that follows it.
5147 (bidi_level_of_next_char): Set next_en_pos to zero when
5148 invalidating its info.
5149
2c91f553
EZ
51502011-10-17 Eli Zaretskii <eliz@gnu.org>
5151
5152 * xdisp.c (push_display_prop): Determine whether to record string
5153 or buffer position by IT->string, not by IT->method. Allow
5154 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5155 (move_it_vertically_backward): Don't look for character position
5156 immediately after the newline when in a continuation line.
5157 (Bug#9771, part 1)
2c91f553 5158
c7b08b0d
MR
51592011-10-15 Martin Rudalics <rudalics@gmx.at>
5160
5161 * window.c (coordinates_in_window): Rewrite and delabelize
5162 vertical border check. (Bug#5357) (Bug#9618)
5163
6b02f655
SM
51642011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5165
5166 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5167 errors in XSetWindowBorder (bug#9310).
5168
81d40c92
DA
51692011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5170
5171 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5172 avoid crash when xmalloc overrun checking is enabled.
5173
d4172c3b
EZ
51742011-10-13 Eli Zaretskii <eliz@gnu.org>
5175
5176 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5177 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5178 cursor motion with <left> and <right> arrow keys.
5179
5180 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5181 some callers set that themselves.
5182
b00eea75
EZ
51832011-10-12 Eli Zaretskii <eliz@gnu.org>
5184
5185 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5186 display string and the previous row comes from the same string and
5187 is empty. (Bug#9739) (Bug#9738)
5188
8fe012c4
SM
51892011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5190
5191 * doc.c (get_doc_string): Encode file name (bug#9735).
5192
0074aef2
EZ
51932011-10-12 Eli Zaretskii <eliz@gnu.org>
5194
79beb178
EZ
5195 * bidi.c (bidi_level_of_next_char):
5196 * xdisp.c (get_visually_first_element): Remove old incorrect
5197 comments regarding the Unicode Line Separator character.
5198
0074aef2
EZ
5199 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5200
6e4b3fbe
DA
52012011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5202
5203 * alloc.c (Fgc_status): Do not access beyond zombies array
5204 boundary if nzombies > MAX_ZOMBIES.
5205 * alloc.c (dump_zombies): Add missing format specifier.
5206
0324f3af
PE
52072011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5208
b5525cac
PE
5209 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5210 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5211
0324f3af
PE
5212 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5213 Some packages use them to denote characters with modifiers.
5214
e9b5f888
AS
52152011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5216
5217 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5218 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5219 matching a pp-number. Rename parameter var to var1.
5220
127827c0
SM
52212011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5222
5223 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5224
c8fd3bd0
GM
52252011-10-08 Glenn Morris <rgm@gnu.org>
5226
5227 * callint.c (Fcall_interactively): Give a more explicit error for the
5228 'c' case with a non-character input. (Bug#8479)
5229
352ec8ff
EZ
52302011-10-08 Eli Zaretskii <eliz@gnu.org>
5231
03669ccb
EZ
5232 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5233 lines.
7061c986
EZ
5234 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5235 lines that are hscrolled on the left.
03669ccb 5236
352ec8ff
EZ
5237 * dispnew.c (buffer_posn_from_coords): Account for a possible
5238 presence of header-line. (Bug#4426)
5239
a66cfb1c
SM
52402011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5241
6b02f655
SM
5242 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5243 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5244
7c5ee88e
PE
52452011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5246
5247 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5248 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5249 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5250 this makes Emacs dump core during garbage collection on rare
5251 occasions. sizeof is obviously inferior to offsetof here, so
5252 stick with offsetof.
5253 (GC_POINTER_ALIGNMENT): New macro.
5254 (mark_memory): Omit 3rd (offset) arg; caller changed.
5255 Don't assume EMACS_INT alignment is the same as pointer alignment.
5256
df1bbe5b
SM
52572011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5258
5259 * keyboard.c (read_key_sequence_remapped): New var.
5260 (read_key_sequence): Compute remapping in the right buffer.
5261 (command_loop_1): Use read_key_sequence's remapping directly.
5262
51553db6
SM
52632011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5264
32c1fffd
SM
5265 * dired.c (file_name_completion): Don't expand file name.
5266 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5267 before checking file name handler.
5268
51553db6
SM
5269 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5270 they've been requested explicitly (bug#9591).
5271
b6bd1599 52722011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5273
5274 * keymap.c (Fsingle_key_description): Use make_specified_string
5275 instead of build_string to build string from push_key_description.
5276 (Bug#5193)
5277
f701dc2a
PE
52782011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5279
4222c55d
PE
5280 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5281 This fixes a Y2038 bug on 64-bit hosts.
5282 * buffer.c (reset_buffer):
5283 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5284 (Fclear_buffer_auto_save_failure):
5285 Use 0, not -1, to represent an unset failure time, since time_t
5286 might not be signed.
5287
f701dc2a
PE
5288 Remove dependency on glibc malloc internals.
5289 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5290 Move back here from lisp.h, but with their new implementations.
5291 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5292 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5293 * charset.c (charset_table_init): New static var.
5294 (syms_of_charset): Use it instead of xmalloc. This removes a
5295 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5296 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5297 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5298 Move back to alloc.c.
5299 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5300 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5301
9ceebf39
JD
53022011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5303
5304 * nsterm.m (windowDidResize): Call x_set_window_size only when
5305 ns_in_resize is true. Otherwise set pixelwidth/height and
5306 call change_frame_size (Bug#9628).
5307
cb993c58
PE
53082011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5309
3930c88b
PE
5310 Port --enable-checking=all to Fedora 14 x86-64.
5311 * charset.c (syms_of_charset): Also account for glibc malloc's
5312 internal overhead when calculating the initial malloc maximum.
5313
cb993c58
PE
5314 Port --enable-checking=all to Fedora 14 x86.
5315 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5316 Move to lisp.h.
5317 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5318 (overrun_check_realloc, overrun_check_free):
5319 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5320 That way, xmalloc returns a properly-aligned pointer even if
5321 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5322 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5323 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5324 into account when calculating the initial malloc maximum.
5325 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5326 Move here from alloc.c, so that charset.c can use it too.
5327 Properly align; the old code wasn't right for common 32-bit hosts
5328 when configured with --enable-checking=all.
5329 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5330 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5331
31bed486
EZ
53322011-09-29 Eli Zaretskii <eliz@gnu.org>
5333
04c70788 5334 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5335 use EDOM.
5336
fbcaa2f3
EZ
53372011-09-28 Eli Zaretskii <eliz@gnu.org>
5338
5339 * xdisp.c (compute_display_string_end): If there's no display
5340 string at CHARPOS, return -1.
5341
5342 * bidi.c (bidi_fetch_char): When compute_display_string_end
5343 returns a negative value, treat the character as a normal
5344 character not covered by a display string. (Bug#9624)
5345
a239d4e9
JB
53462011-09-28 Juanma Barranquero <lekktu@gmail.com>
5347
5348 * lread.c (Fread_from_string): Fix typo in docstring.
5349
88652fd5
EZ
53502011-09-27 Eli Zaretskii <eliz@gnu.org>
5351
5352 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5353 newline, reseat the iterator instead of bidi-iterating there one
5354 character at a time. (Bug#9610)
32c1fffd
SM
5355 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5356 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5357
ed497dd4
AS
53582011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5359
5360 * lread.c (readevalloop): Use correct code for NBSP.
5361 (read1): Likewise. (Bug#9608)
5362
b2bf61aa
MA
53632011-09-25 Michael Albinus <michael.albinus@gmx.de>
5364
5365 * dbusbind.c (Fdbus_register_signal): When service is not
5366 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5367
32bbb17c
GM
53682011-09-25 Glenn Morris <rgm@gnu.org>
5369
5370 * buffer.c (truncate-lines): Doc fix.
5371
94e0933e
CY
53722011-09-24 Chong Yidong <cyd@stupidchicken.com>
5373
5374 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5375 (Fset_window_next_buffers): Doc fix.
5376
cddde921
GM
53772011-09-24 Glenn Morris <rgm@gnu.org>
5378
5379 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5380
1260aef1
PE
53812011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5382
25b4bfa0
PE
5383 Fix minor problems found by static checking.
5384 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5385 * indent.c (Fvertical_motion): Fix == vs = typo.
5386
e3cbd34b
EZ
53872011-09-24 Eli Zaretskii <eliz@gnu.org>
5388
a66cfb1c
SM
5389 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5390 Default value is now t. Doc fix.
6bf7006f 5391
e3cbd34b 5392 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5393 logic when moving up, not only when moving down. Fix the
e3cbd34b 5394 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5395 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5396
5397 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5398 CHARPOS is covered by a display string which includes newlines.
5399 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5400 is covered by a display string with embedded newlines.
5401
a3de0cbd
MA
54022011-09-24 Michael Albinus <michael.albinus@gmx.de>
5403
5404 * dbusbind.c (Fdbus_register_signal): Add match rule to
5405 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5406 (Fdbus_register_method, Vdbus_registered_objects_table):
5407 Fix docstring.
a3de0cbd 5408
b260039d
JM
54092011-09-24 Jim Meyering <meyering@redhat.com>
5410
32c1fffd 5411 do not ignore write error for any output size
b260039d
JM
5412 The previous change was incomplete.
5413 While it makes emacs --batch detect the vast majority of stdout
5414 write failures, errors were still ignored whenever the output size is
5415 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5416 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5417 && echo FAIL: ignored write error
5418 FAIL: ignored write error
5419 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5420 && echo FAIL: ignored write error
5421 FAIL: ignored write error
5422 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5423
8eca8a7c
AS
54242011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5425
5426 * emacs.c (Fkill_emacs): In noninteractive mode exit
5427 non-successfully if a write error occurred on stdout. (Bug#9574)
5428
3341db62
EZ
54292011-09-21 Eli Zaretskii <eliz@gnu.org>
5430
5431 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5432 the xassert test.
5433
5434 * dispextern.h (struct it): Update the comment documenting what
5435 can it->OBJECT be.
5436
8c203dbf
EZ
54372011-09-20 Eli Zaretskii <eliz@gnu.org>
5438
5439 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5440 a display string, extend search for cursor position to end of row.
5441 (find_row_edges): If the row ends in a newline from a display
5442 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5443 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5444 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5445 non-empty line. Fixes confusing cursor motion with arrow keys at
5446 the beginning of a line that starts with whitespace.
8c203dbf 5447
a4824228
LMI
54482011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5449
5450 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5451 (bug#9493).
5452
33ed493b
CY
54532011-09-18 Chong Yidong <cyd@stupidchicken.com>
5454
5455 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5456 boolean (Bug#9154).
5457
56cd55c8
EZ
54582011-09-18 Eli Zaretskii <eliz@gnu.org>
5459
5460 * xdisp.c (display_line): Record maximum and minimum buffer
5461 positions even if no glyphs were produced (e.g., by a zero-width
5462 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5463 buffer positions that will be removed from the glyph row because
5464 they don't fit.
c02dcedf
EZ
5465 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5466 column is beyond frame width: don't subtract 1 "pixel" when
5467 computing width of the stretch.
3e62b7e0
EZ
5468 (reseat_at_next_visible_line_start): Undo the change made on
5469 2011-09-17 that saved paragraph information and restored it after
5470 the call to `reseat'. (Bug#9545)
56cd55c8 5471
5ed99d36 54722011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5473
5474 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5475 and turn window cursor on if cleared (Bug#9415).
5476
5ed99d36 54772011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5478
5479 * search.c (boyer_moore): Take unibyte characters from pattern
5480 literally. (Bug#9458)
5481
9bade7b2
EZ
54822011-09-18 Eli Zaretskii <eliz@gnu.org>
5483
5484 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5485
e5e9d610
PE
54862011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5487
87e4427a
PE
5488 Fix minor problem found by static checking.
5489 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5490 initialized, to pacify gcc -Wuninitialized.
5491
e5e9d610
PE
5492 * fileio.c: Report proper errno when syscall falls.
5493 (Finsert_file_contents): Save and restore errno,
5494 so that report_file_error outputs the correct diagnostic.
5495 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5496
a1674f0b
EZ
54972011-09-18 Eli Zaretskii <eliz@gnu.org>
5498
5499 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5500
fbfb6dd4
EZ
55012011-09-17 Eli Zaretskii <eliz@gnu.org>
5502
5503 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5504 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5505
bb187662
EZ
55062011-09-17 Eli Zaretskii <eliz@gnu.org>
5507
1137e8b8 5508 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5509 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5510
5511 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5512 (bidi_find_paragraph_start): Search back for paragraph beginning
5513 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5514 (bidi_move_to_visually_next): Only trigger paragraph-related
5515 computations when the last character is a newline or at EOB, not
5516 just any NEUTRAL_B. (Bug#9470)
5517
bb187662
EZ
5518 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5519 truncated lines if point is covered by a display string. (Bug#9524)
5520
2e621251
PE
55212011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5522
5523 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5524 (cons_to_x_long): New function.
5525 (lisp_data_to_selection_data): Use it. Correct the test for
5526 short-versus-long data; it was negated. Break out of vector
5527 loop, for efficiency, when a long datum is discovered.
5528
91a15bc6
SM
55292011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5530
5531 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5532
b41c3a35
EZ
55332011-09-16 Eli Zaretskii <eliz@gnu.org>
5534
5535 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5536 GCC PR/17406) by declaring this function with external scope.
5537
7812ba2d
PE
55382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5539
5540 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5541 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5542
cf7edc2a
AS
55432011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5544
5545 * editfns.c (Fformat): Correctly handle text properties on "%%".
5546
bd01620e
EZ
55472011-09-15 Eli Zaretskii <eliz@gnu.org>
5548
5549 * xterm.c (x_draw_composite_glyph_string_foreground):
5550 * w32term.c (x_draw_composite_glyph_string_foreground):
5551 * term.c (encode_terminal_code):
5552 * composite.c (composition_update_it, get_composition_id):
5553 * xdisp.c (get_next_display_element)
5554 (fill_composite_glyph_string): Add comments about special meaning
5555 of TAB characters in a composition.
5556
a02719a3
PE
55572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5558
5559 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5560 This occurs when processing a multibyte format.
5561 Problem reported by Wolfgang Jenker.
a02719a3 5562
72589a3c
JB
55632011-09-15 Johan Bockgård <bojohan@gnu.org>
5564
5565 * xdisp.c (try_cursor_movement): Only check for exact match if
5566 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5567
1c14176c
PE
55682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5569
5570 Remove unused external symbols.
5571 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5572 * xdisp.c (calc_pixel_width_or_height): Now static.
5573 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5574 * indent.c (check_display_width):
5575 * w32term.c: Fix comment to match code.
5576 * xterm.c, xterm.h (x_catching_errors): Remove.
5577
d2eea5b5
PE
55782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5579
5580 * xselect.c: Use signed conversions more consistently (Bug#9498).
5581 (selection_data_to_lisp_data): Assume incoming selection data are
5582 signed integers, not unsigned. This is to be consistent with
5583 outgoing selection data, which was modified to use signed integers
5584 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5585 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5586 expects long, not unsigned long.
5587
46888499
EZ
55882011-09-14 Eli Zaretskii <eliz@gnu.org>
5589
5590 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5591 computation of loop end. Reported by Johan Bockgård
5592 <bojohan@gnu.org>.
5593
ef8ef9fb
CY
55942011-09-13 Chong Yidong <cyd@stupidchicken.com>
5595
5596 * frame.c (Fother_visible_frames_p): Function deleted.
5597
fa819fed
EZ
55982011-09-12 Eli Zaretskii <eliz@gnu.org>
5599
5600 * indent.c (compute_motion): Process display vector front to back
5601 rather than the other way around. (Bug#2496)
5602
2ba8e008
SM
56032011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5604
5605 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5606
20f53c69
CY
56072011-09-11 Chong Yidong <cyd@stupidchicken.com>
5608
5609 * minibuf.c (Fread_from_minibuffer): Doc fix.
5610
d562d7a4
EZ
56112011-09-11 Eli Zaretskii <eliz@gnu.org>
5612
5613 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5614 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5615
1c4d7f3d
LMI
56162011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5617
5618 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5619 value for non-existent files.
5620
b885bf36
EZ
56212011-09-11 Eli Zaretskii <eliz@gnu.org>
5622
5623 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5624 set its "size" to -1. This will set the modtime_size field of
5625 the corresponding buffer to -1, which is what
5626 verify-visited-file-modtime expects for files that do not exist.
5627 (Bug#9139)
5628
6612f0bf
PE
56292011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5630
5631 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5632 here ...
5633 * lisp.h: ... from here. push_key_description is no longer
5634 defined in keyboard.c, so its declaration should not be in
5635 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5636 logically belongs with push_key_description.
5637
dfb3f755
PE
56382011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5639
5640 * buffer.h: Include <sys/types.h> instead of <time.h>.
5641 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5642 Problem reported by Herbert J. Skuhra.
5643
3134906c
LMI
56442011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5645
5646 * xml.c (parse_region): Make the parsing work for
5647 non-comment-starting XML files again (bug#9144).
5648
8d903f4e
AS
56492011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5650
5651 * image.c (gif_load): Fix calculation of bottom and right corner.
5652 (Bug#9468)
5653
80ad64f4
EZ
56542011-09-10 Eli Zaretskii <eliz@gnu.org>
5655
5656 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5657 redisplay in small windows.
5658
208a048d
EZ
56592011-09-09 Eli Zaretskii <eliz@gnu.org>
5660
5661 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5662
9b1c252e
MR
56632011-09-08 Martin Rudalics <rudalics@gmx.at>
5664
5665 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5666 Operate on live windows only.
5667
2949f33b
JB
56682011-09-08 Juanma Barranquero <lekktu@gmail.com>
5669
5670 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5671
e08dcafd
EZ
56722011-09-07 Eli Zaretskii <eliz@gnu.org>
5673
5674 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5675 only under bidi iteration.
5676
115b96bd
JD
56772011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5678
5679 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5680
c8199d0f
PE
56812011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5682
5683 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5684 Without this fix, the command to link temacs failed due to an
5685 undefined symbol __builtin_isnan. This is because
5686 /usr/include/iso/math_c99.h #defines isnan(x) to
5687 __builtin_isnan(x), but the bundled gcc, which identifies itself
5688 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5689 a __builtin_isnan.
5690 * floatfns.c (isnan): #undef, and then #define to a clone of
5691 what's in data.c.
5692 (Fisnan): Always define, since it's always available now.
5693 (syms_of_floatfns): Always define isnan at the Lisp level.
5694
e39b275c 56952011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5696
5697 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5698
b2db44d9 56992011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5700
f4af5137 5701 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5702 The previous code assumed that file offsets (off_t values) fit in
5703 EMACS_INT variables, which is not true on typical 32-bit hosts.
5704 The code messed up by falsely reporting buffer overflow in cases
5705 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5706 when "big" contains more than 2**29 bytes, even though this
5707 inserts just one byte and does not overflow the buffer.
5708 (Finsert_file_contents): Store file offsets as off_t
5709 values, not as EMACS_INT values. Check for overflow when
5710 converting between EMACS_INT and off_t. When checking for
5711 buffer overflow or for overlap, take the offsets into account.
5712 Don't use EMACS_INT for small values where int suffices.
5713 When checking for overlap, fix a typo: ZV was used where
5714 ZV_BYTE was intended.
5715 (Fwrite_region): Don't assume off_t fits into 'long'.
5716 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5717
ecfc0a49
MA
57182011-09-05 Michael Albinus <michael.albinus@gmx.de>
5719
5720 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5721
6511acf2 57222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5723
0999621a 5724 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5725
5726 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5727 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5728 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5729 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5730 (modify_event_symbol): Do not assume that the length of
5731 name_alist_or_stem is safe to alloca and fits in int.
5732 (Fexecute_extended_command): Likewise for function name and binding.
5733 (Frecursion_depth): Wrap around reliably on integer overflow.
5734 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5735 since some callers pass EMACS_INT values.
5736 (Fsingle_key_description): Don't crash if symbol name contains more
5737 than MAX_ALLOCA bytes.
5738 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5739 (get_minibuffer): Arg is now EMACS_INT, not int.
5740 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5741 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5742 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5743
2be7d702
PE
5744 * dbusbind.c (signature_cat): New function.
5745 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5746 Do not overrun buffer; instead, report string overflow.
5747
9d1df220
PE
5748 * dispnew.c (add_window_display_history): Don't overrun buffer.
5749 Truncate instead; this is OK since it's just a log.
5750
33ef5c64
PE
5751 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5752 even if the time zone offset is outlandishly large.
5753 Don't mishandle offset == INT_MIN.
5754
66c6fdd5
PE
5755 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5756 when creating daemon; the previous buffer-overflow check was incorrect.
5757
d749b01b
PE
5758 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5759 which has the guts of the old verror function.
5760
b5cd1905
PE
5761 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5762 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5763
6e1a67fb
PE
5764 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5765 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5766 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5767 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5768 length of string rather than counting it via multiple sprintfs;
5769 that's simpler and more reliable.
c21721cc
PE
5770 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5771 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5772 sprintf, in case result does not fit in int.
5773
c57b67fc
PE
5774 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5775 (fontset_from_font): Print it.
5776
8a401434
PE
5777 * frame.c (tty_frame_count): Now printmax_t, not int.
5778 (make_terminal_frame, set_term_frame_name): Print it.
5779 (x_report_frame_params): In X, window IDs are unsigned long,
5780 not signed long, so print them as unsigned.
5781 (validate_x_resource_name): Check for implausibly long names,
5782 and don't assume name length fits in 'int'.
5783 (x_get_resource_string): Don't blindly alloca invocation name;
5784 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5785 not fit in int.
5786
6e1a67fb
PE
5787 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5788 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5789 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5790
0df02bf3
PE
5791 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5792 Use esprintf, not sprintf, in case result does not fit in int.
5793
48e30793
PE
5794 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5795 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5796 it as a large positive number.
5797 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5798 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5799
a66ff6d8
PE
5800 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5801 in case result does not fit in int.
5802
aca216ff
PE
5803 * print.c (float_to_string): Detect width overflow more reliably.
5804 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5805 buffer overrun. Don't assume list length fits in 'int'. Treat
5806 print length of 0 as 0, not as infinity; to be consistent with other
5807 uses of print length in this function. Don't overflow print length
5808 index. Don't assume hash table size fits in 'long', or that
5809 vectorlike size fits in 'unsigned long'.
5810
31c286f7
PE
5811 * process.c (make_process): Use printmax_t, not int, to format
5812 process-name gensyms.
5813
55e5faa1
PE
5814 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5815
80f2e268
PE
5816 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5817 to avoid potential buffer overrun.
5818
670741ab
PE
5819 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5820 if X resource line is longer than 512 bytes.
5821
b7163a50
PE
5822 * xfns.c (x_window): Make sprintf buffer a bit bigger
5823 to avoid potential buffer overrun.
5824
ae58ff1f
PE
5825 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5826
c43c8a6a
PE
5827 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5828
3f8236f4
PE
58292011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5830
53e9fe90 5831 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5832 Without these, Emacs silently mishandles large integers sometimes.
5833 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5834 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5835
6511acf2
PE
5836 * xdisp.c (try_window_id): Check Emacs fixnum range before
5837 converting to 'int'.
806add1d 5838
6511acf2 5839 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5840 Check that an Emacs fixnum is in range before assigning it to 'int'.
5841 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5842 values converted from Emacs fixnums.
5843 (Frecenter): Don't wrap around a line count if it is out of 'int'
5844 range; instead, treat it as an extreme value.
5845 (Fset_window_configuration, compare_window_configurations):
5846 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5847
6511acf2
PE
5848 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5849 that can exceed INT_MAX. Check that EMACS_INT value is in range
5850 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5851 (match_limit): Don't assume that a fixnum can fit in 'int'.
5852
6511acf2 5853 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5854 exceed INT_MAX.
5855
6511acf2 5856 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5857 (Fvertical_motion): Don't wrap around LINES values that don't fit
5858 in 'int'. Instead, treat them as extreme values. This is good
5859 enough for windows, which can't have more than INT_MAX lines anyway.
5860
fcb901a7
LMI
58612011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5862
0f2f6b6d
LMI
5863 * Require libxml/parser.h to avoid compilation warning.
5864
fcb901a7
LMI
5865 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5866
5867 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5868 since this reportedly can destroy thread storage.
5869
6e20a0d4
CY
58702011-08-30 Chong Yidong <cyd@stupidchicken.com>
5871
5872 * syntax.c (find_defun_start): Update all cache variables if
5873 exiting early (Bug#9401).
5874
148ae00e
EZ
58752011-08-30 Eli Zaretskii <eliz@gnu.org>
5876
f6cfbd8f
EZ
5877 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5878
148ae00e
EZ
5879 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5880 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5881 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5882
5883 * term.c (tty_append_glyph): New function.
5884 (produce_stretch_glyph): Static function and its prototype deleted.
5885
a66cfb1c
SM
5886 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5887 Add prototypes.
148ae00e 5888
c4a07a4c
PE
58892011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5890
5891 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5892 when checking :margin (Bug#9390).
5893 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5894 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5895 so that the name doesn't mislead. All uses changed.
5896
6bc8cd65
JB
58972011-08-28 Johan Bockgård <bojohan@gnu.org>
5898
5899 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5900 set_tty_hooks.
5901
dca4927e
EZ
59022011-08-27 Eli Zaretskii <eliz@gnu.org>
5903
5904 * xdisp.c (move_it_to): Don't bail out early when reaching
5905 position beyond to_charpos, if we are scanning backwards.
5906 (move_it_vertically_backward): When DY == 0, make sure we get to
5907 the first character in the line after the newline.
5908
f2cad773
PE
59092011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5910
5911 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5912 (ccl_driver): Do not generate an out-of-range pointer.
5913 (Fccl_execute_on_string): Remove unnecessary check for
5914 integer overflow, noted by Stefan Monnier in
5915 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5916 Remove a FIXME that didn't need fixing.
5917 Simplify the newly-introduced buffer reallocation code.
5918
0cae2cdb
JB
59192011-08-27 Juanma Barranquero <lekktu@gmail.com>
5920
5921 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5922
5fc295a4 59232011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5924
70c60eb2 5925 Integer and memory overflow issues (Bug#9196).
726e0ab1 5926
d31850da
PE
5927 * doc.c (get_doc_string): Rework so that
5928 get_doc_string_buffer_size is the actual buffer size, rather than
5929 being 1 less than the actual buffer size; this makes xpalloc more
5930 convenient.
5931
a69fbedb
PE
5932 * image.c (x_allocate_bitmap_record, cache_image):
5933 * xselect.c (Fx_register_dnd_atom):
5934 Simplify previous changes by using xpalloc.
5935
fe5c5d37
PE
5936 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5937 since either will do and ptrdiff_t is convenient with xpalloc.
5938
0065d054
PE
5939 * charset.c (charset_table_size)
5940 (struct charset_sort_data.priority): Now ptrdiff_t.
5941 (charset_compare): Don't overflow if priorities differ greatly.
5942 (Fsort_charsets): Don't assume list length fits in int.
5943 Check for size-calculation overflow when allocating sort data.
5944 (syms_of_charset): Allocate an initial charset table that is
5945 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5946
5947 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5948
5949 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5950 The actual value is always <= INT_MAX, and leaving it unsigned made
5951 overflow checking harder.
5952
5953 * dispextern.h (struct glyph_matrix.rows_allocated)
5954 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5955 with xpalloc. The values are still always <= INT_MAX.
5956
5957 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5958
5959 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5960 (SAFE_NALLOCA): New macro.
5961
5962 * region-cache.c (struct boundary.pos, find_cache_boundary)
5963 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5964 (set_cache_region, invalidate_region_cache)
5965 (revalidate_region_cache, know_region_cache, region_cache_forward)
5966 (region_cache_backward, pp_cache):
5967 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5968 so that ptrdiff_t * can be passed to xpalloc.
5969 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5970 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5971 (pp_cache): Don't assume cache_len fits in int.
5972 * region-cache.h: Adjust extern decls to match.
5973
5974 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5975 EMACS_INT, since either will do, for xpalloc.
5976
5977 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5978 (xnmalloc, xnrealloc, xpalloc): New functions.
5979
726e0ab1
PE
5980 * bidi.c (bidi_shelve_header_size): New constant.
5981 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5982 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5983
51f30bc5 5984 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5985 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5986 (overlay_strings):
5987 Don't update size of array until after memory allocation succeeds,
5988 because xmalloc/xrealloc may not return.
0065d054
PE
5989 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5990 now that we have proper integer overflow checking.
5991 (record_overlay_string, overlay_strings): Catch overflows when
5992 calculating size of overlay_str_buf.
726e0ab1 5993
0065d054
PE
5994 * callproc.c (Fcall_process): Check for size overflow when
5995 calculating size of args2.
5996 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5997 Normally we prefer signed values, but sticking with ptrdiff_t would
5998 require adding more-complicated checks.
726e0ab1
PE
5999
6000 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6001 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6002 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6003 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6004
6005 * character.c (Fstring): Check for size-calculation overflow.
6006
6007 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6008 unnecessary integer overflow. Check for size overflow.
6009 (encode_coding_object): Don't update size until xmalloc succeeds.
6010
6011 * composite.c (get_composition_id): Check for overflow in glyph
6012 length calculations.
6013
6014 Integer and memory overflow fixes for display code.
6015 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6016 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6017 (scrolling_window): Check for overflow in size calculations.
6018 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6019 Don't assume glyph table len fits in int.
6020 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6021 (row_table_size): Now ptrdiff_t, not int.
6022 (scrolling_window): Avoid overflow in size calculations.
6023 Don't update size until allocation succeeds.
6024 * fns.c (concat): Check for overflow in size calculations.
6025 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6026 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6027 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6028
6029 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6030 (get_doc_string): Check for size calculation overflow.
6031 Don't update size until allocation succeeds.
6032 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6033 EMACS_INT, where ptrdiff_t will do.
6034 (Fsubstitute_command_keys): Check for string overflow.
6035
6036 * editfns.c (set_time_zone_rule): Don't assume environment length
6037 fits in int.
6038 (message_length): Now ptrdiff_t, not int.
6039 (Fmessage_box): Don't update size until allocation succeeds.
6040 Don't assume message length fits in int.
6041 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6042
0065d054
PE
6043 * emacs.c (main): Do not reallocate argv, since there is a null at
6044 the end that can be overwritten, and this way there's no need to
6045 worry about size-calculation overflow.
6046 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6047
6048 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6049 alloc succeeds.
6050 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6051
6052 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6053 (x_set_scroll_bar_width, x_figure_window_size):
6054 Check for integer overflow.
6055 (x_set_alpha): Do not assume XINT fits in int.
6056
6057 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6058 This is for the members text_lines, text_cols, total_lines, total_cols,
6059 where the system imposes an 'int' limit.
6060
6061 * fringe.c (Fdefine_fringe_bitmap):
6062 Don't update size until alloc works.
6063
6064 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6065 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6066
6067 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6068 Check for size-calculation overflow.
6069 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6070 do, as we prefer signed integers.
6071 (id_to_widget.max_size, id_to_widget.used)
6072 (xg_store_widget_in_map, xg_remove_widget_from_map)
6073 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6074 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6075 Use and return ptrdiff_t, not int.
6076 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6077 * gtkutil.h: Change prototypes to match the above.
6078
6079 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6080 are duplicate now that they've been promoted to lisp.h.
6081 (x_allocate_bitmap_record, x_alloc_image_color)
6082 (make_image_cache, cache_image, xpm_load):
6083 Don't update size until alloc is done.
6084 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6085 (x_detect_edges):
3256efce 6086 Check for size calculation overflow.
726e0ab1
PE
6087 (ct_colors_allocated_max): New constant.
6088 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6089 overflow.
3256efce 6090
726e0ab1
PE
6091 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6092 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6093 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6094 Use ptrdiff_t, not int, to count maps.
6095 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6096 calculations. Don't update size until allocation succeeds.
6097 Redo calculations to avoid overflow.
726e0ab1
PE
6098 * keyboard.h: Change prototypes to match the above.
6099
6100 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6101 to count maps.
6102 (current_minor_maps): Check for size calculation overflow.
6103 * keymap.h: Change prototypes to match the above.
6104
6105 * lread.c (read1, init_obarray): Don't update size until alloc done.
6106
6107 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6108 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6109
726e0ab1
PE
6110 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6111 Now ptrdiff_t, not int.
6112 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6113 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6114
6115 * process.c (Fnetwork_interface_list): Check for overflow
6116 in size calculation.
6117
6118 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6119
6120 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6121 overflow. Don't bother calling xmalloc when xrealloc will do.
6122
6123 * search.c (Freplace_match): Check for size calculation overflow.
6124 (Fset_match_data): Don't assume list lengths fit in 'int'.
6125
6126 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6127 for command line length. Do not attempt to address one before the
6128 beginning of an array, as that's not portable.
6129
6130 * term.c (max_frame_lines): Remove; unused.
6131 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6132 not int.
6133 (encode_terminal_code, calculate_costs): Check for size
6134 calculation overflow.
6135 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6136 table lengths and related sizes. Don't update size until alloc
6137 done. Redo calculations to avoid overflow.
6138 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6139
6140 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6141 subtracting pointers.
6142 (gobble_line): Check for overflow more carefully. Don't update size
6143 until alloc done.
6144
6145 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6146 Don't update size until alloc done.
6147 Redo size calculations to avoid overflow.
6148 Check for size calculation overflow.
0065d054 6149 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6150
6151 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6152 Use ptrdiff_t, not int, for sizes.
6153 (store_mode_line_noprop_char): Don't update size until alloc done.
6154
0065d054
PE
6155 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6156 Use ptrdiff_t, not int, for sizes.
6157 (Finternal_make_lisp_face, cache_face):
6158 Check for size calculation overflow.
6159 (cache_face): Treat size calculation overflows as if they were
6160 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6161
6162 * xfns.c (x_encode_text, x_set_name_internal)
6163 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6164 sizes, since they can exceed INT_MAX in size. Check for size
6165 calculation overflow.
6166
0065d054
PE
6167 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6168 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6169 Don't update size until alloc done.
6170
0065d054 6171 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6172 as sprintf is limited to int lengths.
1d526e2f 6173
252c5ee1
PE
6174 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6175 (X_LONG_MIN): New macros.
864d7ce7
PE
6176 Use them to make the following changes clearer.
6177 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6178 This change doesn't affect the value now, but it may help remind
6179 future maintainers not to raise the value too much later.
6180 (SELECTION_QUANTUM): Remove, replacing with ...
6181 (selection_quantum): ... new function, which avoids overflow.
6182 All uses changed.
6183 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6184 assumption that selection length fits in 'int'.
6185 (x_reply_selection_request, x_handle_selection_request)
6186 (x_get_window_property, receive_incremental_selection)
6187 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6188 (lisp_data_to_selection_data, clean_local_selection_data):
6189 Use ptrdiff_t, not int, to record length of selection.
6190 (x_reply_selection_request, x_get_window_property)
6191 (receive_incremental_selection, x_property_data_to_lisp):
6192 Redo calculations to avoid overflow.
6193 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6194 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6195 something.
6196 (x_get_window_property, receive_incremental_selection)
6197 (lisp_data_to_selection_data, x_property_data_to_lisp):
6198 Check for size-calculation overflow.
6199 (x_get_window_property, receive_incremental_selection)
6200 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6201 Don't store size until memory allocation succeeds.
6202 (x_get_window_property): Plug memory leak on memory exhaustion.
6203 Don't double-block input; malloc is safe here. Don't assume 2**34
6204 - 4 fits in unsigned long. Add an xassert to check
6205 XGetWindowProperty overflow. Be more careful about overflow
6206 calculations, and distinguish size from memory overflow better.
6207 (receive_incremental_selection): When tracing, don't assume
6208 unsigned int is less than INT_MAX.
6209 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6210 harmful) conversions of unsigned short to int.
6211 (lisp_data_to_selection_data): Don't assume that integers
6212 in the range -65535 through -1 fit in an X unsigned short.
6213 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6214 result parameters unless successful. Rely on cons_to_unsigned
6215 to report problems with elements; the old code wasn't right anyway.
6216 (x_check_property_data): Check for int overflow; we cannot use
6217 a wider type due to X limits.
6218 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6219
726e0ab1 6220 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6221
0065d054
PE
6222 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6223 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6224 (x_color_cells): Don't store size until memory allocation succeeds.
6225 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6226 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6227 (x_term_init): Don't assume length fits in int (sprintf is limited
6228 to int size).
bc18e09d 6229
ebfa62c0
PE
6230 Use ptrdiff_t for composition IDs.
6231 * character.c (lisp_string_width):
6232 * composite.c (composition_table_size, n_compositions)
6233 (get_composition_id, composition_gstring_from_id):
6234 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6235 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6236 * window.c (Frecenter):
6237 Use ptrdiff_t, not int, for composition IDs.
6238 * composite.c (get_composition_id): Check for integer overflow.
6239 * composite.h: Adjust prototypes to match the above changes.
6240
d3411f89
PE
6241 Use ptrdiff_t for hash table indexes.
6242 * category.c (hash_get_category_set):
6243 * ccl.c (ccl_driver):
6244 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6245 * coding.c (coding_system_charset_list, detect_coding_system):
6246 * coding.h (struct coding_system.id):
6247 * composite.c (get_composition_id, gstring_lookup_cache):
6248 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6249 * image.c (xpm_get_color_table_h):
6250 * lisp.h (hash_lookup, hash_put):
6251 * minibuf.c (Ftest_completion):
6252 Use ptrdiff_t for hash table indexes, not int (which is too
6253 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6254 32-bit --with-wide-int hosts).
6255
e097a6fa
PE
6256 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6257 Add a FIXME comment about memory leaks.
6258 (syms_of_charset): Don't assume xmalloc returns.
6259
5637687f
PE
6260 Don't assume that stated character widths fit in int.
6261 * character.c (Fchar_width, c_string_width, lisp_string_width):
6262 * character.h (CHAR_WIDTH):
6263 * indent.c (MULTIBYTE_BYTES_WIDTH):
6264 Use sanitize_char_width to avoid undefined and/or bad behavior
6265 with outlandish widths.
a66cfb1c 6266 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6267 now that we have two such functions. All uses changed.
6268 (sanitize_char_width): New inline function.
6269
a2271ba2
PE
6270 Don't assume that tab-width fits in int.
6271 * character.h (sanitize_width): New inline function.
6272 (SANE_TAB_WIDTH): New macro.
6273 (ASCII_CHAR_WIDTH): Use it.
6274 * indent.c (sane_tab_width): Remove. All uses replaced by
6275 SANE_TAB_WIDTH (current_buffer).
6276 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6277
18c52557
PE
6278 * fileio.c: Integer overflow issues with file modes.
6279 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6280
caeeedc1
PE
6281 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6282 Remove unreachable code.
6283 (read_hex, load_charset_map_from_file): Check for integer overflow.
6284
6df6ae42 6285 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6286 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6287 (x_send_scroll_bar_event): Likewise. Check that the size does not
6288 exceed limits imposed by XClientMessageEvent, as well as the usual
6289 ptrdiff_t and size_t limits.
6290
b13995db
PE
6291 * keyboard.c: Overflow, signedness and related fixes.
6292 (make_lispy_movement): Use same integer type in forward decl
6293 that is used in the definition.
6294 (read_key_sequence, keyremap_step):
6295 Change bufsize argument back to int, undoing my 2011-03-30 change.
6296 We prefer signed types, and int is wide enough here.
6297 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6298 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6299 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6300 length, not size_t. Use ptrdiff_t for index, not int.
6301 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6302 possibility of integer overflow.
6303
13464394
PE
6304 Overflow, signedness and related fixes for images.
6305
6306 * dispextern.h (struct it.stack[0].u.image.image_id)
6307 (struct_it.image_id, struct image.id, struct image_cache.size)
6308 (struct image_cache.used, struct image_cache.ref_count):
6309 * gtkutil.c (update_frame_tool_bar):
6310 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6311 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6312 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6313 * nsmenu.m (update_frame_tool_bar):
6314 * xdisp.c (calc_pixel_width_or_height):
6315 * xfns.c (image_cache_refcount):
6316 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6317 on typical 64-bit hosts.
6318
6319 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6320 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6321 Omit unnecessary casts to int.
6322 (parse_image_spec): Check that integers fall into 'int' range
6323 when the callers expect that.
6324 (image_ascent): Redo ascent calculation to avoid int overflow.
6325 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6326 (lookup_image): Remove unnecessary tests.
6327 (xbm_image_p): Locals are now of int, not EMACS_INT,
6328 since parse_image_check makes sure they fit into int.
6329 (png_load, gif_load, svg_load_image):
6330 Prefer int to unsigned where either will do.
6331 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6332 old tiff_error_handler and tiff_warning_handler.
6333 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6334 stack buffer overflows. It uses only the features of vsnprintf
6335 that are common to both POSIX and native Microsoft.
6336 (tiff_error_handler, tiff_warning_handler): Use it.
6337 (tiff_load, gif_load, imagemagick_load_image):
6338 Don't assume :index value fits in 'int'.
6339 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6340 (imagemagick_load_image): Check that crop parameters fit into
6341 the integer types that MagickCropImage accepts. Don't assume
6342 Vimagemagick_render_type has a nonnegative value. Don't assume
6343 size_t fits in 'long'.
6344 (gs_load): Use printmax_t to print the widest integers possible.
6345 Check for integer overflow when computing image height and width.
6346
c11821d4
EZ
63472011-08-26 Eli Zaretskii <eliz@gnu.org>
6348
6349 * xdisp.c (redisplay_window): Don't force window start if point
6350 will be invisible in the resulting window. (Bug#9324)
6351
0c95fcf7
EZ
63522011-08-25 Eli Zaretskii <eliz@gnu.org>
6353
6354 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6355 the display spec is of the form `(space ...)'.
6356 (handle_display_spec): Return the value returned by
6357 handle_single_display_spec, not just 1 or zero.
6358 (handle_single_display_spec): If the display spec is of the form
6359 `(space ...)', and specifies display in the text area, return 2
6360 rather than 1.
fee65a97 6361 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6362 accurately, and prefer exact match for point under bidi.
6363 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6364
6365 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6366 into disp_prop; all users changed.
6367
6368 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6369 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6370 for the text covered by the display property.
6371
e4ed06f1
CY
63722011-08-25 Chong Yidong <cyd@stupidchicken.com>
6373
6374 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6375 Change return value to nil.
6376 (Frecord_buffer): Delete unused function.
6377
f67cdd7f
EZ
63782011-08-24 Eli Zaretskii <eliz@gnu.org>
6379
5980d4c6
EZ
6380 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6381 buffers, return left-to-right.
8610fe8b
EZ
6382 (set_cursor_from_row): Consider candidate row a win if its glyph
6383 represents a newline and point is on that newline. Fixes cursor
6384 positioning on the newline at EOL of R2L text within L2R
6385 paragraph, and vice versa.
6386 (try_cursor_movement): Check continued rows, in addition to
6387 continuation rows. Fixes unwarranted scroll when point enters a
6388 continued line of R2L text within an L2R paragraph, or vice versa.
6389 (cursor_row_p): Consider the case of point being equal to
6390 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6391 from the end of a short line to the beginning of a continued line
6392 of R2L text within L2R paragraph.
6393 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6394 composed characters.
5980d4c6 6395
f67cdd7f
EZ
6396 * bidi.c (bidi_check_type): Use xassert.
6397 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6398 members.
6399
bca633fb
EZ
64002011-08-23 Eli Zaretskii <eliz@gnu.org>
6401
6402 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6403 a character.
6404
4a5885a7
CY
64052011-08-23 Chong Yidong <cyd@stupidchicken.com>
6406
6407 * nsfont.m (ns_otf_to_script): Fix typo.
6408
0902a04e
KH
64092011-08-22 Kenichi Handa <handa@m17n.org>
6410
6411 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6412 extra slot even if the purpose is char-code-property-table.
6413
1a2e6670
EZ
64142011-08-23 Eli Zaretskii <eliz@gnu.org>
6415
8ddde651
EZ
6416 * xdisp.c (redisplay_window): When computing centering_position,
6417 account for the height of the header line. (Bug#8874)
6418
425cc014
EZ
6419 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6420 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6421 candidate is selected by the mouse, and that candidate has a
6422 composed character under the mouse.
6423
1a2e6670
EZ
6424 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6425 coordinates reported by pos-visible-in-window-p for a composed
6426 character in column zero.
6427
8b76d6f8
SM
64282011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6429
6430 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6431
dac347dd
EZ
64322011-08-22 Eli Zaretskii <eliz@gnu.org>
6433
6434 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6435 consider it a hit if to_charpos is anywhere in the range of the
6436 composed buffer positions.
6437
e013fb34
CY
64382011-08-22 Chong Yidong <cyd@stupidchicken.com>
6439
6440 * image.c (gif_load): Don't assume that each subimage has the same
6441 dimensions as the base image. Handle disposal method that is
6442 "undefined" by the gif spec (Bug#9335).
6443
bd1ba3e8
CY
64442011-08-20 Chong Yidong <cyd@stupidchicken.com>
6445
6446 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6447 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6448
54a1215b
EZ
64492011-08-19 Eli Zaretskii <eliz@gnu.org>
6450
823564e5
EZ
6451 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6452 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6453 from an Org mode buffer to a Speedbar frame.
6454
54a1215b
EZ
6455 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6456 a composition, take its buffer position from IT->cmp_it.charpos.
6457 Fixes cursor positioning at the beginning of a line that begins
6458 with a composed character.
6459
9778ebcc
EZ
64602011-08-18 Eli Zaretskii <eliz@gnu.org>
6461
0be6ee06
EZ
6462 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6463 character bidirectional type, use STRONG_L instead. Fixes crashes
6464 in a buffer produced by `describe-categories'.
6465
9778ebcc
EZ
6466 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6467 members before the level stack, so they would be saved and
6468 restored when copying iterator state. Fixes incorrect reordering
6469 around TABs covered by display properties.
6470
156bffbe
AS
64712011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6472
6b02f655 6473 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6474
72ad093b
CY
64752011-08-17 Chong Yidong <cyd@stupidchicken.com>
6476
6477 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6478 (internal_condition_case_2, internal_condition_case_n):
6479 Remove unnecessary aborts (Bug#9081).
72ad093b 6480
35774242
EZ
64812011-08-17 Eli Zaretskii <eliz@gnu.org>
6482
6483 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6484 has no `load' handler, try opening the file locally. (Bug#9311)
6485
db76dd85
KB
64862011-08-16 Ken Brown <kbrown@cornell.edu>
6487
6488 * gmalloc.c: Expand comment.
6489
b215eee5
EZ
64902011-08-16 Eli Zaretskii <eliz@gnu.org>
6491
6492 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6493 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6494
a4579d33
KB
64952011-08-16 Ken Brown <kbrown@cornell.edu>
6496
6497 Fix memory allocation problems in Cygwin build (Bug#9273).
6498
6499 * unexcw.c ( __malloc_initialized): Declare external variable.
6500 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6501
8b76d6f8
SM
6502 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6503 New variables.
a4579d33
KB
6504 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6505 dumped emacs.
6506 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6507 in the static heap.
6508 [CYGWIN] (special_realloc): New function.
6509 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6510 requests to realloc storage in the static heap.
6511
3ebec551
PE
65122011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6513
6514 * bidi.c (bidi_initialize): Remove unused local.
6515
9fd8be00
EZ
65162011-08-15 Eli Zaretskii <eliz@gnu.org>
6517
6b02f655
SM
6518 * bidimirror.h:
6519 * biditype.h: Remove file.
6520 * makefile.w32-in ($(BLD)/bidi.$(O)):
6521 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6522
6523 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6524
6525 * chartab.c: Improve commentary for the uniprop_table API.
6526
32413314
EZ
6527 * bidi.c (bidi_paragraph_init): Support zero value of
6528 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6529 (bidi_initialize): Use uniprop_table instead of including
6530 biditype.h and bidimirror.h.
32413314 6531
9fd8be00
EZ
6532 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6533 coordinates of the iterator when restoring from ppos_it.
6534 (Bug#9296)
6535
5cf2b69b
KH
65362011-08-14 Kenichi Handa <handa@m17n.org>
6537
6538 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6539 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6540
daf17d00
EZ
65412011-08-14 Eli Zaretskii <eliz@gnu.org>
6542
6543 * xdisp.c (move_it_in_display_line_to): Don't invoke
6544 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6545 ppos_it. Fixes vertical cursor motion when line beginning is
6546 covered by an image. (Bug#9296)
6547
08e3161a
JD
65482011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6549
6550 * nsterm.h (ns_run_ascript): Declare.
6551 (NSAPP_DATA2_RUNASSCRIPT): Define.
6552
6553 * nsfns.m (as_script, as_result, as_status): New static variables.
6554 (ns_run_ascript): New function.
5e617bc2 6555 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6556 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6557 the event loop. Get status from as_status (Bug#7276).
6558
6559 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6560 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6561 the event loop (Bug#7276).
6562
a3720aa2
AS
65632011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6564
6565 * gnutls.c (QCgnutls_bootprop_priority)
6566 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6567 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6568 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6569 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6570 (QCgnutls_bootprop_verify_hostname_error)
6571 (QCgnutls_bootprop_callbacks_verify): Rename from
6572 Qgnutls_bootprop_..., all uses changed.
6573
6574 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6575 uses changed.
6576
0a0d27fb
PE
65772011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6578
19d5c50c
PE
6579 * xfaces.c (Qframe_set_background_mode): Now static.
6580 * dispextern.h (Qframe_set_background_mode): Remove decl.
6581
0a0d27fb
PE
6582 * process.c (Fnetwork_interface_info): Declare local only if needed.
6583
377538cb
JD
65842011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6585
6586 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6587 (Fnetwork_interface_list): Allocate in increments of bytes instead
6588 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6589 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6590 sockaddr.
6591 (struct ifflag_def): notrailers is smart on OSX.
6592 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6593 Get hardware address with getifaddrs if available.
6594
08fff70c
EZ
65952011-08-12 Eli Zaretskii <eliz@gnu.org>
6596
6597 * xdisp.c (iterate_out_of_display_property): xassert that
6598 IT->position is set to within IT->object's boundaries. Break from
6599 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6600 when IT->position is set up wrongly due to some bug.
6601 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6602 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6603 entry. Force push_it to save on the stack the current
6604 buffer/string position, to be restored by pop_it. Fix flags in
6605 the iterator structure wrt the object coming from a display
6606 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6607 properties. (Bug#9284)
6608
7be1c708 66092011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6610
7be1c708
CY
6611 * fontset.c (fontset_get_font_group): Add proper type checks.
6612 (Bug#9172)
aac0c6e3 6613
7be1c708 66142011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6615
7be1c708
CY
6616 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6617 and LC_VERSION_MIN_MACOSX.
6618 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6619 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6620
97bb72a6
EZ
66212011-08-08 Eli Zaretskii <eliz@gnu.org>
6622
6623 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6624 no-display-properties-and-no-overlays under bidi display.
6625 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6626 properties and overlays.
97bb72a6 6627
d5617611
CY
66282011-08-08 Chong Yidong <cyd@stupidchicken.com>
6629
37e11a63
CY
6630 * editfns.c (Fset_time_zone_rule): Document relationship with the
6631 setenv function.
6632
d5617611
CY
6633 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6634 the font entity extracted from the cache (Bug#8109).
6635
58872834
CY
66362011-08-07 Chong Yidong <cyd@stupidchicken.com>
6637
6638 * composite.c (autocmp_chars): Don't reset point. That is done by
6639 restore_point_unwind (Bug#5984).
6640
75bfc667
JL
66412011-08-07 Juri Linkov <juri@jurta.org>
6642
6643 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6644 to show the arg `TIME' instead of `TIMEVAL'.
6645
d1410150
EZ
66462011-08-06 Eli Zaretskii <eliz@gnu.org>
6647
6648 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6649 display property strides EOL and includes a newline, as in
6650 longlines-mode. (Bug#9254)
75b771e4
EZ
6651 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6652 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6653
6654 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6655 is non-zero, even if the data buffer is NULL. Fixes a crash in
6656 vertical-motion with longlines-mode. (Bug#9254)
6657
35928349
EZ
66582011-08-05 Eli Zaretskii <eliz@gnu.org>
6659
ec7cc85b
EZ
6660 * bidi.c <bidi_cache_total_alloc>: Now static.
6661 (bidi_initialize): Initialize bidi_cache_total_alloc.
6662
8b76d6f8 6663 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6664 cache. (Bug#9221)
6665
6666 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6667 amount allocated this far in `bidi_cache_total_alloc'.
6668 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6669 non-zero, only free the data buffer without restoring the cache
6670 contents. All callers changed.
6671
6672 * dispextern.h (bidi_unshelve_cache): Update prototype.
6673
6674 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6675 (move_it_in_display_line, move_it_to)
6676 (move_it_vertically_backward, move_it_by_lines): Replace the call
6677 to xfree to an equivalent call to bidi_unshelve_cache.
6678 (move_it_in_display_line_to): Fix logic of returning
412b6358 6679 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6680
e2e2423b
EZ
66812011-08-05 Eli Zaretskii <eliz@gnu.org>
6682
6683 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6684 came from a string character with a `cursor' property. (Bug#9229)
6685
ae9e757a
JD
66862011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6687
6688 * Makefile.in (LIB_PTHREAD): New variable.
6689 (LIBES): Add LIB_PTHREAD (Bug#9216).
6690
6691 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6692 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6693
213bd7f2
AS
66942011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6695
6b02f655 6696 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6697
99aaf75f
JD
66982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6699
6700 * xterm.c (x_find_topmost_parent): New function.
6701 (x_set_frame_alpha): Find topmost parent window with
6702 x_find_topmost_parent and set the property there also (bug#9181).
6703 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6704
c74e9d86
PE
67052011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6706
6707 * callproc.c (Fcall_process): Avoid vfork clobbering
6708 the local vars buffer, coding_systems, current_dir.
6709
640c8776
SM
67102011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6711
6712 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6713
f26d0e4c
PE
67142011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6715
8a10d76c
PE
6716 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6717 so that it is not optimized away.
6718
f26d0e4c
PE
6719 * xdisp.c (compute_display_string_pos): Remove unused local.
6720
55439c61
EZ
67212011-08-02 Eli Zaretskii <eliz@gnu.org>
6722
6723 Fix slow cursor motion and scrolling in large buffers with
6724 selective display, like Org Mode buffers. (Bug#9218)
6725
6726 * dispextern.h (struct bidi_it): New member disp_prop_p.
6727
6728 * xdisp.c: Remove one-slot cache of display string positions.
6729 (compute_display_string_pos): Accept an additional argument
5e617bc2 6730 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6731 for a display string or property. If found, set DISP_PROP_P
6732 non-zero.
6733
6734 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6735 DISP_PROP_P, and pass it to compute_display_string_pos.
6736 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6737 non-zero. All callers of bidi_fetch_char changed.
6738
fb33fa43
SM
67392011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6740
6741 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6742
b099e063
DM
67432010-12-03 Don March <don@ohspite.net>
6744
6745 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6746 last character M-[char] is translated to ESC [char] (bug#7541).
6747
5cc7f7af
KH
67482011-08-02 Kenichi Handa <handa@m17n.org>
6749
d0fffa3f 6750 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6751
6752 * chartab.c (uniprop_table): Make it non-static.
6753
525d5e6e
EZ
67542011-08-01 Eli Zaretskii <eliz@gnu.org>
6755
6756 * xdisp.c (forward_to_next_line_start): Accept additional argument
6757 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6758 on the newline.
6759 (reseat_at_next_visible_line_start): Use the bidi iterator state
6760 returned by forward_to_next_line_start to restore the state of
6761 it->bidi_it after backing up to previous newline. (Bug#9212)
6762
31011111
AS
67632011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6764
6765 * regex.c (re_comp): Protoize.
6766 (re_exec): Fix return type.
6767 (regexec): Fix type of `ret'. (Bug#9203)
6768
476371c4
PE
67692011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6770
e5d76069
PE
6771 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6772 This is needed if max-image-size is a floating-point number.
6773
9a79b20c
AS
67742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6775
6776 * print.c (print_object): Print empty symbol as ##.
6777
6778 * lread.c (read1): Read ## as empty symbol.
6779
d8c2fa78
AA
67802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6781
6782 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6783 setting frame foreground color (Bug#9175).
6784 (x_set_background_color): Likewise.
6785
ffe57a7a
AA
6786 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6787 contents (Bug#9176).
6788 (EmacsTooltip -init): Remove bezels and add shadows to
6789 tooltip windows.
6790
bf3492a5
AA
6791 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6792 or scroll bar (Bug#8470).
6793
d55e9c53
AA
6794 * nsfont.m (nsfont_open): Remove assignment to voffset and
6795 unnecessary vars hshink, expand, hd, full_height, min_height.
6796 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6797
6798 * nsterm.h (nsfont_info): Remove voffset field.
6799
d8c2fa78 68002011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6801
6802 Implement strike-through and overline on NextStep (Bug#8863).
6803
6804 * nsfont.m (nsfont_open): Use underline position provided by font,
6805 instead of hard-coded value of 2.
6806 (nsfont_draw): Call ns_draw_text_decoration instead.
6807
6808 * nsterm.h: Add declaration for ns_draw_text_decoration.
6809
6810 * nsterm.m (ns_draw_text_decoration): New function for drawing
6811 underline, overline, and strike-through.
6812 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6813 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6814 accommodate underlining, etc.
4843aac3 6815
4cc60b9b
EZ
68162011-07-28 Eli Zaretskii <eliz@gnu.org>
6817
bc7ece87
EZ
6818 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6819 default.
4cc60b9b 6820
476371c4
PE
68212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6822
66606eea
PE
6823 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6824 Without this fix, if a signal arrives just after memory fills up,
6825 'malloc' might be invoked reentrantly.
6826
476371c4
PE
6827 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6828 In other words, assume that every image size is allowed, on non-X
6829 hosts. This assumption is probably wrong, but it lets Emacs compile.
6830
f3fcc40d
AS
68312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6832
6833 * regex.c (re_iswctype): Convert return values to boolean.
6834
350c992f
EZ
68352011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6836
6837 * xdisp.c (compute_display_string_pos): Don't use cached display
6838 string position if the buffer had its restriction changed.
6839 (Bug#9184)
6840
5266b4bb
PE
68412011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6842
6843 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6844
2573a837 68452011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6846
41f55ccd 6847 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6848
39e378da
PE
6849 * bidi.c: Integer size and overflow fixes.
6850 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6851 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6852 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6853 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6854 (bidi_find_other_level_edge):
6855 Use ptrdiff_t instead of EMACS_INT where either will do.
6856 This works better on 32-bit hosts configured --with-wide-int.
6857 (bidi_cache_ensure_space): Check for size-calculation overflow.
6858 Use % rather than repeated addition, for better worst-case speed.
6859 Don't set bidi_cache_size until after xrealloc returns, because it
6860 might not return.
6861 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6862 (bidi_cache_ensure_space): Also check that the bidi cache size
6863 does not exceed that of the largest Lisp string or buffer. See Eli
6864 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6865
5e927815
PE
6866 * alloc.c (__malloc_size_t): Remove.
6867 All uses replaced by size_t. See Andreas Schwab's note
6868 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6869
ca4aa935
PE
6870 * image.c: Improve checking for integer overflow.
6871 (check_image_size): Assume that f is nonnull, since
6872 it is always nonnull in practice. This is one less thing to
6873 worry about when checking for integer overflow later.
6874 (x_check_image_size): New function, which checks for integer
6875 overflow issues inside X.
6876 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6877 This removes the need for a memory_full check.
6878 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6879 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6880 (xbm_read_bitmap_data): Change locals back to 'int', since
6881 their values must fit in 'int'.
6882 (xpm_load_image, png_load, tiff_load):
6883 Invoke x_create_x_image_and_pixmap earlier,
6884 to avoid much needless work if the image is too large.
6885 (tiff_load): Treat overly large images as if
6886 x_create_x_image_and_pixmap failed, not as malloc failures.
6887 (gs_load): Use x_check_image_size.
6888
5f8f9cc2
PE
6889 * gtkutil.c: Omit integer casts.
6890 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6891 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6892
5adf60bc
PE
6893 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6894
c8907a93
PE
6895 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6896 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6897 would wrongly return t on a 64-bit host.
6898
e3c25c68
PE
6899 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6900 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6901 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6902 and therefore cause GCC to emit a bogus diagnostic in some cases.
6903
3f791afe
PE
6904 * image.c: Integer signedness and overflow and related fixes.
6905 This is not an exhaustive set of fixes, but it's time to
6906 record what I've got.
6907 (lookup_pixel_color, check_image_size): Remove redundant decls.
6908 (check_image_size): Don't assume that arbitrary EMACS_INT values
6909 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6910 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6911 (tiff_load, imagemagick_load_image):
6912 Check for overflow in size calculations.
6913 (x_create_x_image_and_pixmap): Remove unnecessary test for
6914 xmalloc returning NULL; that can't happen.
6915 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6916 (xpm_color_bucket): Use better integer hashing function.
6917 (xpm_cache_color): Don't possibly over-allocate memory.
6918 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6919 (gif_memory_source):
6920 Use ptrdiff_t, not int or size_t, to record sizes.
6921 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6922 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6923 either works, as we prefer signed integers.
6924 (tiff_read_from_memory, tiff_write_from_memory):
6925 Return tsize_t, not size_t, since that's what the TIFF API wants.
6926 (tiff_read_from_memory): Don't fail simply because the read would
6927 go past EOF; instead, return a short read.
6928 (tiff_load): Omit no-longer-needed casts.
6929 (Fimagemagick_types): Don't assume size fits into 'int'.
6930
3cc5a532
PE
6931 Improve hashing quality when configured --with-wide-int.
6932 * fns.c (hash_string): New function, taken from sxhash_string.
6933 Do not discard information about ASCII character case; this
6934 discarding is no longer needed.
6935 (sxhash-string): Use it. Change sig to match it. Caller changed.
6936 * lisp.h: Declare it.
6937 * lread.c (hash_string): Remove, since we now use fns.c's version.
6938 The fns.c version returns a wider integer if --with-wide-int is
6939 specified, so this should help the quality of the hashing a bit.
6940
b312a492
PE
6941 * emacs.c: Integer overflow minor fix.
6942 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6943 Define only if GNU_LINUX.
6944 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6945
dfd153ae
PE
6946 * dispnew.c: Integer signedness and overflow fixes.
6947 Remove unnecessary forward decls, that were a maintenance hassle.
6948 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6949 All uses changed.
6950 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6951 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6952 (prepare_desired_row, line_draw_cost):
6953 Use int, not unsigned, where either works.
6954 (save_current_matrix, restore_current_matrix):
6955 Use ptrdiff_t, not size_t, where either works.
6956 (init_display): Check for overflow more accurately, and without
6957 relying on undefined behavior.
6958
a81d11a3
PE
6959 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6960 Remove, replacing with the new symbols in lisp.h. All uses changed.
6961 * fileio.c (make_temp_name):
6962 * filelock.c (lock_file_1, lock_file):
6963 * xdisp.c (message_dolog):
6964 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6965 Use pMd etc. instead.
6966 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6967 replacing the pWIDE etc. symbols removed from editfns.c.
6968
3300e6fd
PE
6969 * keyboard.h (num_input_events): Now uintmax_t.
6970 This is (very slightly) less likely to mess up due to wraparound.
6971 All uses changed.
6972
fd05c7e9
PE
6973 * buffer.c: Integer signedness fixes.
6974 (alloc_buffer_text, enlarge_buffer_text):
6975 Use ptrdiff_t rather than size_t when either will do, as we prefer
6976 signed integers.
6977
903fe15d
PE
6978 * alloc.c: Integer signedness and overflow fixes.
6979 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6980 (__malloc_size_t): Default to size_t, not to int.
6981 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6982 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6983 Prefer ptrdiff_t to size_t when either would do, as we prefer
6984 signed integers.
6985 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6986 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6987 Now const. Initialize with values that are in range even if char
6988 is signed.
6989 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6990 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6991 These functions do the right thing with sizes > 2**32.
6992 (check_depth): Now ptrdiff_t, not int.
6993 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6994 Adjust to new way of storing sizes. Check for size overflow bugs
6995 in rest of code.
6996 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6997 slightly wrong anyway, as it missed one instance of
6998 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6999 (refill_memory_reserve): Omit needless cast to size_t.
7000 (mark_object_loop_halt): Mark as externally visible.
7001
ac82cc6a
PE
7002 * xselect.c: Integer signedness and overflow fixes.
7003 (Fx_register_dnd_atom, x_handle_dnd_message):
7004 Use ptrdiff_t, not size_t, since we prefer signed.
7005 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7006 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7007 x_dnd_atoms_size and x_dnd_atoms_length.
7008
c2d1e36d
PE
7009 * doprnt.c: Prefer signed to unsigned when either works.
7010 * eval.c (verror):
7011 * doprnt.c (doprnt):
7012 * lisp.h (doprnt):
7013 * xdisp.c (vmessage):
7014 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7015 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7016 prefer signed arithmetic to avoid comparison confusion.
7017 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7018 but is a bit tricky.
7019
0e926e56
PE
7020 Assume freestanding C89 headers, string.h, stdlib.h.
7021 * data.c, doprnt.c, floatfns.c, print.c:
7022 Include float.h unconditionally.
7023 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7024 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7025 * regex.c: Likewise for stddef.h, string.h.
7026 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7027 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7028 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7029 (STDC_HEADERS): Remove obsolete defines.
7030 * sysdep.c: Include limits.h unconditionally.
7031
9cfdb3ec
PE
7032 Assume support for memcmp, memcpy, memmove, memset.
7033 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7034 * regex.c (memcmp, memcpy):
7035 Remove; we assume C89 now.
7036
7037 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7038 (__malloc_safe_bcopy): Remove; no longer needed.
7039
cf950e6b 7040 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7041 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7042 well either way, and we prefer signed to unsigned.
7043
dbf38e02
LMI
70442011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7045
7046 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7047 closes the connection while we're reading (bug#9182).
7048
d6f0886c 70492011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7050
d6f0886c
JD
7051 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7052 are specified (Bug#9168).
24e0f6b1 7053
2eb1f9e6
PE
70542011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7055
7056 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7057 Found by GCC static checking and --with-wide-int on a 32-bit host.
7058
22381272 70592011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7060
7061 * xdisp.c (compute_display_string_pos): Fix logic of caching
7062 previous display string position. Initialize cached_prev_pos to
7063 -1. Fixes slow-down at the beginning of a buffer.
7064
f25e39b4
EZ
70652011-07-24 Eli Zaretskii <eliz@gnu.org>
7066
7067 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7068 for attrs[LFACE_FONTSET_INDEX].
7069
04c4b52e
PE
70702011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7071
7072 * xml.c (parse_region): Remove unused local
7073 that was recently introduced.
7074
c1734fbd
EZ
70752011-07-23 Eli Zaretskii <eliz@gnu.org>
7076
be18c5a5
EZ
7077 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7078 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7079
c1734fbd
EZ
7080 * xdisp.c (move_it_in_display_line_to): Record the best matching
7081 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7082 exit if none of the characters scanned was an exact match.
7083 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7084 when exact match is impossible due to invisible text, and the
7085 lines are truncated.
7086
a258d627
JD
70872011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7088
7089 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7090 for OSX >= 10.7.
7091
b6d5a689
EZ
70922011-07-22 Eli Zaretskii <eliz@gnu.org>
7093
0f74f785
EZ
7094 Fix a significant slow-down of cursor motion with C-n, C-p,
7095 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7096 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7097 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7098 (next_element_from_buffer): Call compute_stop_pos_backwards to
7099 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7100 base_level_stop.
7101 (reseat): Don't look for prev_stop, as that could mean a very long
7102 run.
7103 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7104 <cached_disp_overlay_modiff>: Cache for last found display string
7105 position.
551918c1 7106 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7107 about the same buffer in the same area of character positions, and
7108 the buffer wasn't changed since the time the display string
7109 position was cached.
551918c1 7110
b2d0c91a
EZ
71112011-07-22 Eli Zaretskii <eliz@gnu.org>
7112
7113 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7114 is an integer, which is important for empty lines. (Bug#9149)
7115
043604ee
CY
71162011-07-22 Chong Yidong <cyd@stupidchicken.com>
7117
7118 * frame.c (Fmodify_frame_parameters): In tty case, update the
7119 default face if necessary (Bug#4238).
7120
da4adb04
CY
71212011-07-21 Chong Yidong <cyd@stupidchicken.com>
7122
7123 * editfns.c (Fstring_to_char): No need to explain what a character
7124 is in the docstring (Bug#6576).
7125
9abd0532
LMI
71262011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7127
7128 * xml.c (parse_region): Make sure we always return a tree.
7129
36881d16
HK
71302011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7131
7132 * xml.c (parse_region): If a document contains only comments,
7133 return that, too.
7134
1e98674d
LMI
71352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7136
7137 * xml.c (make_dom): Return comments, too.
7138
590bd467
PE
71392011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7140
7141 Port to OpenBSD.
7142 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7143 and the surrounding thread.
7144 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7145 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7146 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7147 timer goes off.
7148 * s/openbsd.h (BROKEN_SIGIO): Define.
7149 * unexelf.c (unexec) [__OpenBSD__]:
7150 Don't update the .mdebug section of the Alpha COFF symbol table.
7151
f41628b2
LMI
71522011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7153
7154 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7155 (bug#8460).
7156
b59b67c5
PE
71572011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7158
15e3a074
PE
7159 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7160 This fixes some race conditions on the permissions of any newly
7161 created file.
7162
41bed37d
PE
7163 * alloc.c (valid_pointer_p): Use pipe, not open.
7164 This fixes some permissions issues when debugging.
7165
b59b67c5
PE
7166 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7167 If fchown fails to set both uid and gid, try to set just gid,
7168 as that is sometimes allowed. Adjust the file's mode to eliminate
7169 setuid or setgid bits that are inappropriate if fchown fails.
7170
925a6be7
SM
71712011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7172
7173 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7174 to compare Lisp_Objects.
7175 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7176 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7177 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7178
52968808
AS
71792011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7180
0a6a104b
AS
7181 * lread.c (read_integer): Unread even EOF character.
7182 (read1): Likewise. Properly record start position of symbol.
7183
52968808
AS
7184 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7185 symbol character follows.
7186
9e381cdd
PE
71872011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7188
7189 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7190 This works around a problem with the previous change to Fcopy_file.
7191 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7192 and without this change, GCC might complain about discarding
7193 fchown's return value.
7194
b5641435
JB
71952011-07-16 Juanma Barranquero <lekktu@gmail.com>
7196
7197 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7198
a8031457
PE
71992011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7200
7201 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7202
dd889327
LMI
72032011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7204
750c33f7
LMI
7205 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7206 it's used from the C level.
7207
dd889327
LMI
7208 * process.c: Use the same condition for POLL_FOR_INPUT in both
7209 keyboard.c and process.c (bug#1858).
7210
87e86684
LM
72112011-07-09 Lawrence Mitchell <wence@gmx.li>
7212
7213 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7214 (Fgnutls_boot): Use it.
7215
64348f40
AS
72162011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7217
7218 * doc.c (Fsubstitute_command_keys): Revert last change.
7219
1d698799
LMI
72202011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7221
f863868c
LMI
7222 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7223 quotes the next character, and doesn't affect other longer
7224 sequences (bug#8935).
7225
1d698799
LMI
7226 * lread.c (syms_of_lread): Clarify that is isn't only
7227 `eval-buffer' and `eval-defun' that's affected by
7228 `lexical-binding' (bug#8460).
7229
aa4b6df6
EZ
72302011-07-15 Eli Zaretskii <eliz@gnu.org>
7231
7232 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7233 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7234
5d856da6
PE
72352011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7236
ad6042bb
PE
7237 Fix minor problems found by static checking.
7238 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7239 (elsz): Now a signed constant, not a size_t var. We prefer signed
7240 types to unsigned, to avoid integer comparison confusion. Without
7241 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7242 "cannot optimize loop, the loop counter may overflow", a symptom
7243 of the confusion.
f00bbb22 7244 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7245 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7246
6468f31c
LMI
72472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7248
49080b10
LMI
7249 * search.c (Fre_search_backward): Mention `case-fold-search' in
7250 all the re_search_* functions (bug#8138).
7251
6468f31c
LMI
7252 * keyboard.c (Fopen_dribble_file): Document when the file is
7253 closed (bug#8056).
7254
c965adc5
EZ
72552011-07-14 Eli Zaretskii <eliz@gnu.org>
7256
df9733bf
EZ
7257 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7258 bidi_cache_idx.
7259
0bb23927
EZ
7260 Support bidi reordering of display and overlay strings.
7261 * xdisp.c (compute_display_string_pos)
7262 (compute_display_string_end): Accept additional argument STRING.
7263 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7264 (reseat_to_string): Initialize bidi_it->string.s and
7265 bidi_it->string.schars.
7266 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7267 NULL (avoids a crash in bidi_paragraph_init).
7268 Initialize itb.string.lstring.
0bb23927
EZ
7269 (init_iterator): Call bidi_init_it only of a valid
7270 buffer position was specified. Initialize paragraph_embedding to
7271 L2R.
7272 (reseat_to_string): Initialize the bidi iterator.
7273 (display_string): If we need to ignore text properties of
7274 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7275 original value of -1 will not work with bidi.)
7276 (compute_display_string_pos): First arg is now struct
7277 `text_pos *'; all callers changed. Support display properties on
7278 Lisp strings.
7279 (compute_display_string_end): Support display properties on Lisp
7280 strings.
7281 (init_iterator, reseat_1, reseat_to_string): Initialize the
7282 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7283 when iterating on a string not from display properties).
640c8776
SM
7284 (compute_display_string_pos, compute_display_string_end):
7285 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7286 arrow keys.
7287 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7288 base_level_stop; instead, set base_level_stop to BEGV.
7289 Fixes crashes in vertical-motion.
0bb23927
EZ
7290 (next_element_from_buffer): Improve commentary for when
7291 the iterator is before prev_stop.
7292 (init_iterator): Initialize bidi_p from the default value of
7293 bidi-display-reordering, not from buffer-local value. Use the
7294 buffer-local value only if initializing for buffer iteration.
7295 (handle_invisible_prop): Support invisible properties on strings
7296 that are being bidi-reordered.
7297 (set_iterator_to_next): Support bidi reordering of C strings and
7298 Lisp strings.
7299 (next_element_from_string): Support bidi reordering of Lisp
7300 strings.
7301 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7302 (display_string): Support display of R2L glyph rows.
7303 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7304 (init_iterator): Don't initialize it->bidi_p for strings
7305 here.
7306 (reseat_to_string): Initialize it->bidi_p for strings here.
7307 (next_element_from_string, next_element_from_c_string)
7308 (next_element_from_buffer): Add xassert's for correspondence
7309 between IT's object being iterated and it->bidi_it.string
7310 structure.
7311 (face_before_or_after_it_pos): Support bidi iteration.
7312 (next_element_from_c_string): Handle the case of the first string
7313 character that is not the first one in the visual order.
7314 (get_visually_first_element): New function, refactored from common
7315 parts of next_element_from_buffer, next_element_from_string, and
7316 next_element_from_c_string.
7317 (tool_bar_lines_needed, redisplay_tool_bar)
7318 (display_menu_bar): Force left-to-right direction. Add a FIXME
7319 comment for making that be controlled by a user option.
7320 (push_it, pop_it): Save and restore the state of the
7321 bidi iterator. Save and restore the bidi_p flag.
7322 (pop_it): Iterate out of display property for string iteration as
7323 well.
7324 (iterate_out_of_display_property): Support iteration over strings.
7325 (handle_single_display_spec): Set up it->bidi_it for iteration
7326 over a display string, and call bidi_init_it.
7327 (handle_single_display_spec, next_overlay_string)
7328 (get_overlay_strings_1, push_display_prop): Set up the bidi
7329 iterator for displaying display or overlay strings.
7330 (forward_to_next_line_start): Don't use the shortcut if
7331 bidi-iterating.
7332 (back_to_previous_visible_line_start): If handle_display_prop
7333 pushed the iterator stack, restore the internal state of the bidi
7334 iterator by calling bidi_pop_it same number of times.
7335 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7336 and we are bidi-iterating, don't decrement the iterator position;
7337 instead, set the first_elt flag in the bidi iterator, to produce
7338 the same effect.
7339 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7340 (push_display_prop): xassert that we are iterating a buffer.
7341 (push_it, pop_it): Save and restore paragraph_embedding member.
7342 (handle_single_display_spec, next_overlay_string)
7343 (get_overlay_strings_1, reseat_1, reseat_to_string)
7344 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7345 correctly. Don't assume unibyte strings are not bidi-reordered.
7346 (compute_display_string_pos)
7347 (compute_display_string_end): Fix handling the case of C string.
7348 (push_it, pop_it): Save and restore from_disp_prop_p.
7349 (handle_single_display_spec, push_display_prop): Set the
7350 from_disp_prop_p flag.
7351 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7352 (pop_it): Call iterate_out_of_display_property only if we are
7353 popping after iteration over a string that came from a display
7354 property. Fix a typo in popping stretch info. Add an assertion
7355 for verifying that the iterator position is in sync with the bidi
7356 iterator.
7357 (handle_single_display_spec, get_overlay_strings_1)
7358 (push_display_prop): Fix initialization of paragraph direction for
7359 string when that of the parent object is not yet determined.
7360 (reseat_1): Call bidi_init_it to resync the bidi
7361 iterator with IT's position. (Bug#7616)
7362 (find_row_edges): If ROW->start.pos gives position
7363 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7364 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7365 Reset the from_disp_prop_p flag.
7366 (SAVE_IT, RESTORE_IT): New macros.
7367 (pos_visible_p, face_before_or_after_it_pos)
7368 (back_to_previous_visible_line_start)
7369 (move_it_in_display_line_to, move_it_in_display_line)
7370 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7371 (try_scrolling, redisplay_window, display_line): Use them when
7372 saving a temporary copy of the iterator and restoring it back.
7373 (back_to_previous_visible_line_start, reseat_1)
7374 (init_iterator): Empty the bidi cache "stack".
7375 (move_it_in_display_line_to): If iterator ended up at
7376 EOL, but we never saw any buffer positions smaller than
7377 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7378 motion in bidi-reordered lines.
7379 (move_it_in_display_line_to): Record prev_method and prev_pos
7380 immediately before the call to set_iterator_to_next. Fixes cursor
7381 motion in bidi-reordered lines with stretch glyphs and strings
7382 displayed in margins. (Bug#8133) (Bug#8867)
7383 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7384 TO_CHARPOS.
640c8776
SM
7385 (pos_visible_p): Support positions in bidi-reordered lines.
7386 Save and restore bidi cache.
0bb23927
EZ
7387
7388 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7389 (bidi_paragraph_info): Delete unused struct.
7390 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7391 (bidi_cache_start): New variable.
7392 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7393 to zero.
7394 (bidi_cache_fetch_state, bidi_cache_search)
7395 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7396 (bidi_cache_find, bidi_peek_at_next_level)
7397 (bidi_level_of_next_char, bidi_find_other_level_edge)
7398 (bidi_move_to_visually_next): Compare cache index with
7399 bidi_cache_start rather than with zero.
7400 (bidi_fetch_char): Accept new argument STRING; all callers
7401 changed. Support iteration over a string. Support strings with
7402 display properties. Support unibyte strings. Fix the type of
7403 `len' according to what STRING_CHAR_AND_LENGTH expects.
7404 (bidi_paragraph_init, bidi_resolve_explicit_1)
7405 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7406 (bidi_level_of_next_char, bidi_move_to_visually_next):
7407 Support iteration over a string.
0bb23927
EZ
7408 (bidi_set_sor_type, bidi_resolve_explicit_1)
7409 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7410 can now be zero (for strings); special values 0 and -1 were
7411 changed to -1 and -2, respectively.
7412 (bidi_char_at_pos): New function.
7413 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7414 Call it instead of FETCH_MULTIBYTE_CHAR.
7415 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7416 initialized to valid values.
7417 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7418 values.
7419 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7420 the test for valid cached positions. Fix the logic for looking up
7421 the sentinel state in the cache. GCPRO the Lisp string we are
7422 iterating.
7423 (bidi_push_it, bidi_pop_it): New functions.
7424 (bidi_initialize): Initialize the bidi cache start stack pointer.
7425 (bidi_cache_ensure_space): New function, refactored from part of
7426 bidi_cache_iterator_state. Don't assume the required size is just
7427 one BIDI_CACHE_CHUNK away.
7428 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7429 (bidi_count_bytes, bidi_char_at_pos): New functions.
7430 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7431 always valid if bidi_cache_idx is valid.
7432 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7433 is valid if it's going to be used.
7434 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7435 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7436 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7437 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7438 (bidi_find_other_level_edge, bidi_cache_start_stack):
7439 All variables related to cache indices are now EMACS_INT.
c965adc5 7440
0bb23927
EZ
7441 * dispextern.h (struct bidi_string_data): New structure.
7442 (struct bidi_it): New member `string'. Make flag members be 1-bit
7443 fields, and put them last in the struct.
640c8776
SM
7444 (compute_display_string_pos, compute_display_string_end):
7445 Update prototypes.
0bb23927
EZ
7446 (bidi_push_it, bidi_pop_it): Add prototypes.
7447 (struct iterator_stack_entry): New members bidi_p,
7448 paragraph_embedding, and from_disp_prop_p.
7449 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7450 (bidi_shelve_cache, bidi_unshelve_cache):
7451 Declare prototypes.
0bb23927
EZ
7452
7453 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7454 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7455 and vector-like objects.
7456
7457 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7458 cache around display iteration.
7459
7460 * window.c (Fwindow_end, window_scroll_pixel_based)
7461 (displayed_window_lines, Frecenter): Save and restore the bidi
7462 cache around display iteration.
7463
3bbd2265
LMI
74642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7465
7466 * editfns.c (Fdelete_region): Clarify the use of the named
7467 parameters (bug#6788).
7468
adc47434
MR
74692011-07-14 Martin Rudalics <rudalics@gmx.at>
7470
7471 * indent.c (Fvertical_motion): Set and restore w->pointm when
7472 saving and restoring the window's buffer (Bug#9006).
7473
837c31f8
LMI
74742011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7475
7476 * editfns.c (Fstring_to_char): Clarify just what is returned
7477 (bug#6576). Text by Eli Zaretskii.
7478
ac389d0c
JB
74792011-07-13 Juanma Barranquero <lekktu@gmail.com>
7480
7481 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7482
0be0ce47
EZ
74832011-07-13 Eli Zaretskii <eliz@gnu.org>
7484
7485 * buffer.c (mmap_find): Fix a typo.
7486
cd18e7e3
JB
74872011-07-13 Johan Bockgård <bojohan@gnu.org>
7488
7489 Fix execution of x selection hooks.
7490 * xselect.c (Qx_lost_selection_functions)
7491 (Qx_sent_selection_functions): New vars.
7492 (syms_of_xselect): DEFSYM them.
7493 (x_handle_selection_request): Pass Qx_sent_selection_functions
7494 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7495 (x_handle_selection_clear,x_clear_frame_selections):
7496 Pass Qx_lost_selection_functions rather than
7497 Vx_lost_selection_functions to Frun_hook_with_args.
7498
47ea7f44
PE
74992011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7500
ac389d0c 7501 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7502 The old code sometimes used this field without initializing it.
7503
47ea7f44
PE
7504 * alloc.c (gc_sweep): Don't read past end of array.
7505 In theory, the old code could also have corrupted Emacs internals,
7506 though it'd be very unlikely.
7507
bc985c87
AS
75082011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7509
7510 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7511 argument. (Bug#4026)
bc985c87 7512
0cf34688
LMI
75132011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7514
b3dadd76
LMI
7515 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7516 key" (bug#4257).
7517
0cf34688
LMI
7518 * window.c (Fset_window_start): Doc fix (bug#4199).
7519 (Fset_window_hscroll): Ditto.
7520
270768cd
PE
75212011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7522
077e3dda 7523 Fix minor new problems caught by GCC 4.6.1.
270768cd 7524 * term.c (init_tty): Remove unused local.
490011a6 7525 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7526 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7527 not used otherwise.
270768cd 7528
b1f58454
CY
75292011-07-12 Chong Yidong <cyd@stupidchicken.com>
7530
7531 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7532
22b9578d
LMI
75332011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7534
6e70ab07
LMI
7535 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7536 are the mini-buffer and the echo area (bug#3320).
7537
22b9578d
LMI
7538 * term.c (init_tty): Remove support for supdup, c10 and perq
7539 terminals, which are no longer supported (bug#1482).
7540
8974cc9f
JB
75412011-07-10 Johan Bockgård <bojohan@gnu.org>
7542
7543 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7544
a560d974
JD
75452011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7546
7547 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7548 for non-popups (Bug#3642).
7549
1dae0f0a
AS
75502011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7551
268c2c36 7552 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7553 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7554 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7555 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7556 * data.c (fmod): Likewise.
7557 * dispnew.c (swap_glyphs_in_rows): Likewise.
7558 * emacs.c (memory_warning_signal): Likewise.
7559 * floatfns.c (float_error): Likewise.
7560 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7561 (otf_open, font_otf_capability, generate_otf_features)
7562 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7563 Likewise.
7564 * image.c (pbm_read_file): Likewise.
7565 * indent.c (string_display_width): Likewise.
7566 * intervals.c (check_for_interval, search_for_interval)
7567 (inc_interval_count, count_intervals, root_interval)
7568 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7569 * lread.c (defalias): Likewise.
268c2c36 7570 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7571 * regex.c (set_image_of_range_1, set_image_of_range)
7572 (regex_grow_registers): Likewise.
7573 * sysdep.c (strerror): Likewise.
7574 * termcap.c (valid_filename_p, tprint, main): Likewise.
7575 * tparam.c (main): Likewise.
7576 * unexhp9k800.c (run_time_remap, save_data_space)
7577 (update_file_ptrs, read_header, write_header, calculate_checksum)
7578 (copy_file, copy_rest, display_header): Likewise.
7579 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7580 Likewise.
7581 * xdisp.c (check_it): Likewise.
7582 * xfaces.c (register_color, unregister_color, unregister_colors):
7583 Likewise.
7584 * xfns.c (print_fontset_result): Likewise.
7585 * xrdb.c (member, fatal, main): Likewise.
7586
99033785
PE
75872011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7588
7589 Fix minor problems found by static checking (Bug#9031).
7590 * chartab.c (char_table_set_range, map_sub_char_table):
7591 Remove unused locals.
7592 (uniprop_table): Now static.
7593 * composite.c (_work_char): Remove unused static var.
7594
9cb2ac56
JB
75952011-07-09 Juanma Barranquero <lekktu@gmail.com>
7596
7597 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7598
f25661f0
JD
75992011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7600
7601 * gtkutil.c (qttip_cb): Remove code without function.
7602
8278c4fe
EZ
76032011-07-09 Eli Zaretskii <eliz@gnu.org>
7604
7605 * w32.c (pthread_sigmask): New stub.
7606
1692ae2d 76072011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7608
8a6ebd58 7609 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7610 sigprocmask is portable only for single-threaded applications, and
7611 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7612 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7613 (LIBES): Use it.
7614 * callproc.c (Fcall_process):
7615 * process.c (create_process):
7616 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7617 Use pthread_sigmask, not sigprocmask.
123403e4 7618
1b854618
JD
76192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7620
7621 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7622 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7623 wrong (Bug#8591).
7624
3fe4b549
JD
76252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7626
0ce7e563
JD
7627 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7628 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7629 (xg_hide_tooltip): Fix comment.
7630
3fe4b549
JD
7631 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7632 in registerServicesMenuSendTypes.
7633 (validRequestorForSendType): Don't check ns_return_types.
7634
7635 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7636 ns_return_type.
7637
5df75e47
JR
76382011-07-08 Jason Rumney <jasonr@gnu.org>
7639
22610910
JR
7640 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7641 SH_SHOW for hidden windows (Bug#5482).
7642
5df75e47
JR
7643 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7644 frame struct members of non-existent frames (Bug#6284).
7645
699c10bd
JD
76462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7647
4393663b
JD
7648 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7649 variable firstTime not needed on OSX >= 10.6.
7650 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7651 >= 10.5. Use setKnobProportion, setDoubleValue.
7652
7653 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7654 (MAC_OS_X_VERSION_10_5): Define if not defined.
7655 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7656 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7657 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7658
7659 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7660 cString and lossyCString on OSX >= 10.4
7661
58179cce 7662 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7663 sizeToFit on OSX >= 10.2.
7664
7665 * nsimage.m (allocInitFromFile): Don't use deprecated method
7666 bestRepresentationForDevice on OSX >= 10.6.
7667
7668 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7669 to avoid warning.
7670
7671 * emacs.c: Declare unexec_init_emacs_zone.
7672
a63e0781
JD
7673 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7674
699c10bd
JD
7675 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7676
7677 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7678 on svcsMenu (Bug#8842).
7679
7680 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7681 ns_return_types.
7682 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7683
7684 * nsterm.m (QUTF8_STRING): Declare.
7685 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7686 (validRequestorForSendType): Return type is (id).
7687 Change indexOfObjectIdenticalTo to indexOfObject.
7688 Check if we have local selection before returning self (Bug#8842).
7689 (writeSelectionToPasteboard): Put local selection into paste board
7690 if we have a local selection (Bug#8842).
7691 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7692
7693 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7694 (ns_get_local_selection): Declare.
7695
54e10184
LMI
76962011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7697
9888ff71
LMI
7698 * keymap.c (describe_map_tree): Don't insert a double newline at
7699 the end of the buffer (bug#1169) and return whether we inserted
7700 something.
7701
54e10184
LMI
7702 * callint.c (Fcall_interactively): Change "reading args" to
7703 "providing args" to try to clarify what it does (bug#1010).
7704
15fa4783
KH
77052011-07-07 Kenichi Handa <handa@m17n.org>
7706
7707 * composite.c (composition_compute_stop_pos): Ignore a static
7708 composition starting before CHARPOS (Bug#8915).
7709
7710 * xdisp.c (handle_composition_prop): Likewise.
7711
a8815b00
EZ
77122011-07-07 Eli Zaretskii <eliz@gnu.org>
7713
7714 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7715 (Bug#9015)
7716
ef7b981d 77172011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7718
7719 * character.h (unicode_category_t): New enum type.
7720
7721 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7722 (Qchar_code_property_table): New variable.
7723 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7724 (UNIPROP_COMPRESSED_FORM_P): New macros.
7725 (char_table_ascii): Uncompress the compressed values.
7726 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7727 Uncompress the compressed values.
ac389d0c 7728 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7729 (char_table_ref_and_range): Uncompress the compressed values.
7730 (sub_char_table_set): New arg is_uniprop. Callers changed.
7731 Uncompress the compressed values.
7732 (sub_char_table_set_range): Args changed. Callers changed.
7733 (char_table_set_range): Adjuted for the above change.
7734 (map_sub_char_table): Delete args default_val and parent. Add arg
7735 top. Give decoded values to a Lisp function.
640c8776 7736 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7737 values to a Lisp function. Gcpro more variables.
7738 (uniprop_table_uncompress)
7739 (uniprop_decode_value_run_length): New functions.
7740 (uniprop_decoder, uniprop_decoder_count): New variables.
7741 (uniprop_get_decoder, uniprop_encode_value_character)
7742 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7743 New functions.
7744 (uniprop_encoder, uniprop_encoder_count): New variables.
7745 (uniprop_get_encoder, uniprop_table)
7746 (Funicode_property_table_internal, Fget_unicode_property_internal)
7747 (Fput_unicode_property_internal): New functions.
7748 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7749 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7750 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7751 char-code-property-alist.
7752
640c8776 7753 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7754 Vunicode_category_table.
7755
640c8776 7756 * font.c (font_range): Adjust for the change of
c805dec0
KH
7757 Vunicode_category_table.
7758
76b397fb
DN
77592011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7760
7761 * m/iris4d.h: Remove file, move contents ...
7762 * s/irix6-5.h: ... here.
7763
22b4128e
PE
77642011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7765
7766 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7767 * alloc.c (mark_buffer):
7768 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7769 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7770 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7771 This isn't true in general, and it's particularly not true
7772 if Emacs is configured with --with-wide-int.
7773 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7774 New macros, used in the buffer.c change.
7775
869795d6
JD
77762011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7777
7778 * xsettings.c: Use both GConf and GSettings if both are available.
7779 (store_config_changed_event): Add comment.
7780 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7781 (store_tool_bar_style_changed): New functions.
5e617bc2 7782 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7783 (struct xsettings): Move font inside HAVE_XFT.
7784 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7785 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7786 Move inside HAVE_XFT.
640c8776 7787 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7788 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7789 also.
7790 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7791 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7792 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7793 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7794 (parse_settings): Move check for font inside HAVE_XFT.
7795 (read_settings, apply_xft_settings): Add comment.
7796 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7797 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7798 call store_font_name_changed.
7799 (xft_settings_event): Add comment.
7800 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7801 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7802 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7803 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7804 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7805 (xsettings_get_system_font, xsettings_get_system_normal_font):
7806 Add comment.
869795d6 7807
d8ed26bd
PE
78082011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7809
7810 Random fixes. E.g., (random) never returned negative values.
7811 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7812 subseconds part to the entropy, as that's a bit more random.
7813 Prefer signed to unsigned, since the signedness doesn't matter and
7814 in general we prefer signed. When given a limit, use a
7815 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7816 latter isn't right if USE_2_TAGS_FOR_INTS.
7817 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7818 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7819
cabf1cac
SM
78202011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7821
7822 * textprop.c (text_property_stickiness):
7823 Obey Vtext_property_default_nonsticky.
7824 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7825 * w32fns.c (syms_of_w32fns):
7826 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7827
6e9b2be9
PE
78282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7829
7830 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7831 This is more efficient than Ffile_directory_p and avoids a minor race.
7832
90186c68
LMI
78332011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7834
7c301272
LMI
7835 * buffer.c (Foverlay_put): Say what the return value is
7836 (bug#7835).
7837
c4f2d8d4
LMI
7838 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7839 is a directory before asking whether to use the file name
7840 (bug#7564).
ad637907
LMI
7841 (barf_or_query_if_file_exists): Make the "File is a directory"
7842 error be more correct.
c4f2d8d4 7843
90186c68
LMI
7844 * fns.c (Frequire): Remove the mention of the .gz files, since
7845 that's installation-specific, but keep the mention of
7846 `get-load-suffixes'.
7847
da64016e
PE
78482011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7849
7850 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7851 Report string overflow if the output is too long.
7852
7d47b580
JB
78532011-07-04 Juanma Barranquero <lekktu@gmail.com>
7854
a555cb87
JB
7855 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7856 (syms_of_gnutls): Remove duplicate DEFSYM for
7857 Qgnutls_bootprop_verify_hostname_error, an error for
7858 Qgnutls_bootprop_verify_error (which is no longer used).
7859
7d47b580
JB
7860 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7861 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7862 Also (re)move comments that are misplaced or no longer relevant.
7863
1e49bfab
LMI
78642011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7865
7866 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7867
1485f4c0
CY
78682011-07-03 Chong Yidong <cyd@stupidchicken.com>
7869
7870 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7871 and background color parameters if they have been changed.
7872
a9ab721e
LMI
78732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7874
7875 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7876
cf7cff57
PE
78772011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7878
2e13213d
PE
7879 * xsettings.c (SYSTEM_FONT): Define only when used.
7880 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7881
cf7cff57
PE
7882 * keymap.c (access_keymap_1): Now static.
7883
7a8e04f7
CY
78842011-07-02 Chong Yidong <cyd@stupidchicken.com>
7885
7886 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7887 leave any prefix arg for the up event (Bug#1586).
7888
61352f62
LMI
78892011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7890
69bb1ef7
LMI
7891 * lread.c (syms_of_lread): Mention single symbols defined by
7892 `defvar' or `defconst' (bug#7154).
7893
61352f62 7894 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7895 (Frequire): Mention get-load-suffixes.
61352f62 7896
28545e04
MR
78972011-07-02 Martin Rudalics <rudalics@gmx.at>
7898
7899 * window.h (window): Remove clone_number slot.
7900 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7901 Remove.
7902 (make_parent_window, make_window, saved_window)
7903 (Fset_window_configuration, save_window_save): Don't deal with
7904 clone numbers.
7905 * buffer.c (Qclone_number): Remove declaration.
7906 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7907
3349e122
SM
79082011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7909
7910 Add multiple inheritance to keymaps.
7911 * keymap.c (Fmake_composed_keymap): New function.
7912 (Fset_keymap_parent): Simplify.
7913 (fix_submap_inheritance): Remove.
7914 (access_keymap_1): New function extracted from access_keymap to handle
7915 embedded parents and handle lists of maps.
7916 (access_keymap): Use it.
7917 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7918 (Fcopy_keymap): Handle embedded parents.
7919 (Fcommand_remapping, define_as_prefix): Simplify.
7920 (Fkey_binding): Simplify.
7921 (syms_of_keymap): Move minibuffer-local-completion-map,
7922 minibuffer-local-filename-completion-map,
7923 minibuffer-local-must-match-map, and
7924 minibuffer-local-filename-must-match-map to Elisp.
7925 (syms_of_keymap): Defsubr make-composed-keymap.
7926 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7927 (parse_menu_item): Trivial simplification.
7928
3279eb87
GM
79292011-07-01 Glenn Morris <rgm@gnu.org>
7930
7931 * Makefile.in (SETTINGS_LIBS): Fix typo.
7932
4550efdf
KI
79332011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7934
7935 * coding.c (Fencode_coding_string): Record the last coding system
7936 used, as the function doc string says (bug#8738).
7937
0949d2b6
JD
79382011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7939
7940 * xsettings.c (store_monospaced_changed): Take new font as arg and
7941 check for change against current_mono_font.
7942 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7943 (emacs_settings_constructor, emacs_settings_get_property)
7944 (emacs_settings_set_property, emacs_settings_class_init)
7945 (emacs_settings_init, gsettings_obj): Remove.
7946 (something_changedCB): New function for HAVE_GSETTINGS.
7947 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7948 with value as argument.
7949 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7950 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7951 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7952 "changed".
7953
7954 * xgselect.c: Add defined (HAVE_GSETTINGS).
7955 (xgselect_initialize): Ditto.
7956
7957 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7958 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7959 xg_select.
7960
bbc6b304
PE
79612011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7962
7963 * eval.c (struct backtrace): Simplify and port the data structure.
7964 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7965 signed bit field, as this assumption is not portable and it makes
7966 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7967 "char debug_on_exit : 1" as this is not portable either; instead,
7968 use the portable "unsigned int debug_on_exit : 1". Remove unused
7969 member evalargs. Remove obsolete comments about cc bombing out.
7970
9851bfc5
JD
79712011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7972
51bb811f 7973 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7974 Let HAVE_GSETTINGS override HAVE_GCONF.
7975 (store_monospaced_changed): New function.
7976 (EMACS_SETTINGS): A new type derived from GObject to handle
7977 GSettings notifications.
7978 (emacs_settings_constructor, emacs_settings_get_property)
7979 (emacs_settings_set_property, emacs_settings_class_init):
7980 New functions.
7981 (gsettings_client, gsettings_obj): New variables.
7982 (GSETTINGS_SCHEMA): New define.
7983 (something_changedCB): Call store_monospaced_changed.
7984 (init_gsettings): New function.
7985 (xsettings_initialize): Call init_gsettings.
7986 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7987 to NULL.
7988
640c8776 7989 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7990 GCONF_CFLAGS/LIBS.
7991
5386012d
MR
79922011-06-29 Martin Rudalics <rudalics@gmx.at>
7993
7994 * window.c (resize_root_window, grow_mini_window)
7995 (shrink_mini_window): Rename Qresize_root_window to
7996 Qwindow_resize_root_window and Qresize_root_window_vertically to
7997 Qwindow_resize_root_window_vertically.
7998
f13e0b08
PE
79992011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8000
8001 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8002
94515237
JB
80032011-06-27 Juanma Barranquero <lekktu@gmail.com>
8004
8005 * makefile.w32-in: Redesign dependencies so they reflect more
8006 clearly which files are directly included by each source file,
8007 and not through other includes.
8008
e43b6e43
MR
80092011-06-27 Martin Rudalics <rudalics@gmx.at>
8010
8011 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8012 (sort_overlays, overlay_strings): When an overlay's clone number
8013 matches the window's clone number process the overlay even if
8014 the overlay's window property doesn't match the current window.
8015
d68443dc
MR
8016 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8017 (Fwindow_hchild): Rename to Fwindow_left_child.
8018 (Fwindow_next): Rename to Fwindow_next_sibling.
8019 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8020 (resize_window_check): Rename to window_resize_check.
8021 (resize_window_apply): Rename to window_resize_apply.
8022 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8023 (Fdelete_other_windows_internal, resize_frame_windows)
8024 (Fsplit_window_internal, Fdelete_window_internal)
8025 (grow_mini_window, shrink_mini_window)
8026 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8027
c7e73be5
JD
80282011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8029
8030 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8031 (emacs_fixed_set_min_size): Remove.
8032 (emacs_fixed_new): Take frame as argument.
8033
8034 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8035 (_EmacsFixedPrivate): Remove minwidth/height.
8036 Add struct frame *f.
8037 (emacs_fixed_init): Initialize priv->f.
8038 (get_parent_class, emacs_fixed_set_min_size): Remove.
8039 (emacs_fixed_new): Set priv->f to argument.
8040 (emacs_fixed_get_preferred_width)
8041 (emacs_fixed_get_preferred_height): Use min_width/height from
8042 frames size_hint to set minimum and natural (Bug#8919).
8043 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8044 and use min_width/height from frames size_hint to set
8045 min_width/height (Bug#8919).
8046
8047 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8048 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8049 Fix indentation.
c7e73be5 8050
cf99dcf8
EZ
80512011-06-26 Eli Zaretskii <eliz@gnu.org>
8052
8053 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8054 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8055 called at ZV.
8056
029529ac
CY
80572011-06-26 Chong Yidong <cyd@stupidchicken.com>
8058
8059 * process.c (wait_reading_process_output): Bypass select if
8060 waiting for a cell while ignoring keyboard input, and input is
8061 pending. Suggested by Jan Djärv (Bug#8869).
8062
7a7ef429
PE
80632011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8064
8065 Use gnulib's dup2 module instead of rolling our own.
8066 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8067
11fdef7d 80682011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8069
8070 * dispnew.c (scrolling_window): Before scrolling, turn off a
8071 mouse-highlight in the window being scrolled.
8072
cd3520a4
JB
80732011-06-24 Juanma Barranquero <lekktu@gmail.com>
8074
8075 Move DEFSYM to lisp.h and use everywhere.
8076
8077 * character.h (DEFSYM): Move declaration...
8078 * lisp.h (DEFSYM): ...here.
8079
8080 * gnutls.c:
8081 * minibuf.c:
8082 * w32menu.c:
8083 * w32proc.c:
8084 * w32select.c: Don't include character.h.
8085
8086 * alloc.c (syms_of_alloc):
8087 * buffer.c (syms_of_buffer):
8088 * bytecode.c (syms_of_bytecode):
8089 * callint.c (syms_of_callint):
8090 * casefiddle.c (syms_of_casefiddle):
8091 * casetab.c (init_casetab_once):
8092 * category.c (init_category_once, syms_of_category):
8093 * ccl.c (syms_of_ccl):
8094 * cmds.c (syms_of_cmds):
8095 * composite.c (syms_of_composite):
8096 * dbusbind.c (syms_of_dbusbind):
8097 * dired.c (syms_of_dired):
8098 * dispnew.c (syms_of_display):
8099 * doc.c (syms_of_doc):
8100 * editfns.c (syms_of_editfns):
8101 * emacs.c (syms_of_emacs):
8102 * eval.c (syms_of_eval):
8103 * fileio.c (syms_of_fileio):
8104 * fns.c (syms_of_fns):
8105 * frame.c (syms_of_frame):
8106 * fringe.c (syms_of_fringe):
8107 * insdel.c (syms_of_insdel):
8108 * keymap.c (syms_of_keymap):
8109 * lread.c (init_obarray, syms_of_lread):
8110 * macros.c (syms_of_macros):
8111 * msdos.c (syms_of_msdos):
8112 * print.c (syms_of_print):
8113 * process.c (syms_of_process):
8114 * search.c (syms_of_search):
8115 * sound.c (syms_of_sound):
8116 * syntax.c (init_syntax_once, syms_of_syntax):
8117 * terminal.c (syms_of_terminal):
8118 * textprop.c (syms_of_textprop):
8119 * undo.c (syms_of_undo):
8120 * w32.c (globals_of_w32):
8121 * window.c (syms_of_window):
8122 * xdisp.c (syms_of_xdisp):
8123 * xfaces.c (syms_of_xfaces):
8124 * xfns.c (syms_of_xfns):
8125 * xmenu.c (syms_of_xmenu):
8126 * xsettings.c (syms_of_xsettings):
8127 * xterm.c (syms_of_xterm): Use DEFSYM.
8128
4228cf16
TZ
81292011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8130
cd3520a4 8131 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8132
7fcccf1e
PE
81332011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8134
7efb4e0e
PE
8135 Integer and buffer overflow fixes (Bug#8873).
8136
ff5844ad
PE
8137 * print.c (printchar, strout): Check for string overflow.
8138 (PRINTPREPARE, printchar, strout):
8139 Don't set size unless allocation succeeds.
8140
90532f02
PE
8141 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8142 for sizes. Check for string overflow more accurately.
8143 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8144
6d84508d
PE
8145 * macros.c: Integer and buffer overflow fixes.
8146 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8147 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8148 Use ptrdiff_t, not int, for sizes.
8149 Don't increment bufsize until after realloc succeeds.
8150 Check for size-calculation overflow.
8151 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8152
437b2cb4
PE
8153 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8154
8b9ac8b4
PE
8155 * lread.c: Integer overflow fixes.
8156 (read_integer): Radix is now EMACS_INT, not int,
8157 to improve quality of diagnostics for out-of-range radices.
8158 Calculate buffer size correctly for out-of-range radices.
8159 (read1): Check for integer overflow in radices, and in
8160 read-circle numbers.
82cb60d3
PE
8161 (read_escape): Avoid int overflow.
8162 (Fload, openp, read_buffer_size, read1)
8163 (substitute_object_recurse, read_vector, read_list, map_obarray):
8164 Use ptrdiff_t, not int, for sizes.
8165 (read1): Use EMACS_INT, not int, for sizes.
20270765 8166 Check for size overflow.
8b9ac8b4 8167
7fcccf1e
PE
8168 * image.c (cache_image): Check for size arithmetic overflow.
8169
bfbbd7e7
PE
8170 * lread.c: Integer overflow issues.
8171 (saved_doc_string_size, saved_doc_string_length)
8172 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8173 Now ptrdiff_t, not int.
8174 (read1): Don't assume doc string length fits in int. Check for
8175 out-of-range doc string lengths.
8176 (read_list): Don't assume file position fits in int.
39019e54 8177 (read_escape): Check for hex character overflow.
bfbbd7e7 8178
4e323265
LL
81792011-06-22 Leo Liu <sdl.web@gmail.com>
8180
8181 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8182 Move to minibuffer.el.
8183
85fece3e
PE
81842011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8185
20b84ce9 8186 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8187 The following patches are for when GLYPH_DEBUG && !XASSERT.
8188 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8189 * dispnew.c (flush_stdout):
8190 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8191 Mark as externally visible.
8192 * dispnew.c (check_window_matrix_pointers): Now static.
8193 * dispnew.c (window_to_frame_vpos):
8194 * xfns.c (unwind_create_frame):
8195 * xterm.c (x_check_font): Remove unused local.
8196 * scroll.c (CHECK_BOUNDS):
8197 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8198 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8199 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8200 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8201 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8202 Now static.
8203 (debug_method_add): Use va_list and vsprintf rather than relying
8204 on undefined behavior with wrong number of arguments.
8205 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8206 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8207 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8208 since we're not interested in debugging glyphs with old libraries.
8209 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8210 GCC 4.6.0's static checking.
8211
0766b489
PE
82122011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8213
31fd4b32
PE
8214 Integer overflow and signedness fixes (Bug#8873).
8215 A few related buffer overrun fixes, too.
8216
b79e8648
PE
8217 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8218
0766b489
PE
8219 * dispextern.h (struct face.stipple):
8220 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8221 (x_bitmap_mask, x_allocate_bitmap_record)
8222 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8223 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8224 (x_create_bitmap_from_xpm_data):
8225 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8226 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8227 (.bitmaps_last):
8228 * xfaces.c (load_pixmap):
8229 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8230 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8231 (.bitmaps_last, struct x_output.icon_bitmap):
8232 Use ptrdiff_t, not int, for bitmap indexes.
8233 (x_allocate_bitmap_record): Check for size overflow.
8234 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8235
b081724f
PE
8236 Use ptrdiff_t, not int, for overlay counts.
8237 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8238 * editfns.c (overlays_around, get_pos_property):
8239 * textprop.c (get_char_property_and_overlay):
8240 * xdisp.c (next_overlay_change, note_mouse_highlight):
8241 * xfaces.c (face_at_buffer_position):
21514da7
PE
8242 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8243 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8244 (Fnext_overlay_change, Fprevious_overlay_change)
8245 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8246 Use ptrdiff_t, not int, for sizes.
21514da7 8247 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8248
3de73e5e
PE
8249 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8250
2606c57b
PE
8251 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8252 (x_session_initialize): Do not assume string length fits in int.
8253
aaafe47a
PE
8254 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8255 This is unlikely, but can occur if DPI is outlandish.
8256
2674ddc8 8257 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8258 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8259
28154962
PE
8260 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8261 * xrdb.c (magic_file_p, search_magic_path):
8262 Omit last arg SUFFIX; it was always 0. All callers changed.
8263 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8264
7de51af5
PE
8265 * xfont.c (xfont_match): Avoid need for strlen.
8266
25ed6cc3
PE
8267 * xfns.c: Don't assume strlen fits in int.
8268 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8269
4eab31dd
PE
8270 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8271 not unsigned long, as we prefer signed integers. All callers changed.
8272 Detect integer overflow in repeat count.
8273 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8274 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8275
171e2a58
PE
8276 * termcap.c: Don't assume sizes fit in int and never overflow.
8277 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8278 (gobble_line): Check for size-calculation overflow.
8279
ad39faca 8280 * minibuf.c (Fread_buffer):
6e5bb2dc 8281 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8282 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8283 Don't assume string length fits in int.
8284
52c61c22 8285 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8286 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8287
b5b8c9e5
PE
8288 * font.c: Don't assume string length fits in int.
8289 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8290 Use ptrdiff_t, not int.
ccd6111c
PE
8291 (font_intern_prop): Don't assume string length fits in int.
8292 Don't assume integer property fits in fixnum.
8293 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8294
882f0d81 8295 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8296 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8297 Reformulate so as not to need the command string.
8298 Invoke gzip -cd rather than gunzip, as it's more portable.
8299 (lock_info_type, lock_file_1, lock_file):
8300 Don't assume pid_t and time_t fit in unsigned long.
8301 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8302 (current_lock_owner): Prefer signed type for sizes.
8303 Use memcpy, not strncpy, where memcpy is what is really wanted.
8304 Don't assume (via atoi) that time_t and pid_t fit in int.
8305 Check for time_t and/or pid_t out of range, e.g., via a network share.
8306 Don't alloca where an auto var works fine.
8307
93f4cf88
PE
8308 * fileio.c: Fix some integer overflow issues.
8309 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8310 Don't assume string length fits in int.
8311 (directory_file_name): Don't assume string length fits in long.
8312 (make_temp_name): Don't assume pid fits in int, or that its print
8313 length is less than 20.
8314
f3e92b69
PE
8315 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8316
1bfdaf10
PE
8317 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8318
35016e9a
PE
8319 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8320
3d1e65a1
PE
8321 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8322 We prefer signed integers, even for size calculations.
8323
0b963a93
PE
8324 * emacs.c: Don't assume string length fits in 'int'.
8325 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8326 (main): Don't invoke strlen when not needed.
8327
573f4b54
PE
8328 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8329 (XD_DEBUG_MESSAGE): Don't waste a byte.
8330
989f33ba
PE
8331 * callproc.c (getenv_internal_1, getenv_internal)
8332 (Fgetenv_internal):
965d34eb
PE
8333 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8334
e4d29b33
PE
8335 * lread.c (invalid_syntax): Omit length argument.
8336 All uses changed. This doesn't fix a bug, but it simplifies the
8337 code away from its former Hollerith-constant appearance, and it's
8338 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8339 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8340
eb49b136
PE
8341 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8342 This didn't break anything, but it didn't help either.
8343 It's confusing to put a bogus integer in a place where the actual
8344 value does not matter.
9f62aeb1 8345 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8346 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8347
15375a22
PE
8348 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8349 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8350 implementation.
b61cc01c
PE
8351 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8352 We prefer signed types, and the value cannot exceed the EMACS_INT
8353 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8354 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8355 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8356 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8357
53b2623d
PE
8358 * indent.c (sane_tab_width): New function.
8359 (current_column, scan_for_column, Findent_to, position_indentation)
8360 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8361 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8362
51cab52b 8363 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8364
f2ed8a70
PE
8365 * lisp.h (lint_assume): New macro.
8366 * composite.c (composition_gstring_put_cache):
8367 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8368
abe80cc6
PE
8369 * editfns.c, insdel.c:
8370 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8371
b02c740e
PE
8372 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8373
ebc96716
PE
8374 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8375
b4e50fa0 8376 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8377 Use much-faster test for byte-length change.
311d5d7c 8378 Don't assume string byte-length fits in 'int'.
a4cf38e4 8379 Check that character arg fits in 'int'.
85461888 8380 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8381
c0c1ee9f
PE
8382 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8383
a498d7f4
PE
8384 * fns.c (concat): Catch string overflow earlier.
8385 Do not rely on integer wraparound.
8386
51cab52b
PE
8387 * dispextern.h (struct it.overlay_strings_charpos)
8388 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8389 * xdisp.c (forward_to_next_line_start)
8390 (back_to_previous_visible_line_start)
8391 (reseat_at_next_visible_line_start, next_element_from_buffer):
8392 Don't arbitrarily truncate the value of 'selective' to int.
8393
76031fad
PE
8394 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8395
5eb55db9
PE
8396 * composite.c: Don't truncate sizes to 'int'.
8397 (composition_gstring_p, composition_reseat_it)
8398 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8399 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8400 not EMACS_UINT, for indexes.
5eb55db9 8401
0703a717
PE
8402 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8403
d6202519
PE
8404 * buffer.c: Include <verify.h>.
8405 (struct sortvec.priority, struct sortstr.priority):
8961a454 8406 Now EMACS_INT, not int.
c20998a7 8407 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8408 (struct sortstr.size, record_overlay_string)
8409 (struct sortstrlist.size, struct sortlist.used):
8410 Don't truncate size to int.
8411 (record_overlay_string): Check for size-calculation overflow.
d6202519 8412 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8413
d5a19415
JM
84142011-06-22 Jim Meyering <meyering@redhat.com>
8415
029529ac 8416 Don't leak an XBM-image-sized buffer
d5a19415
JM
8417 * image.c (xbm_load): Free the image buffer after using it.
8418
a9041e6c
PE
84192011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8420
8421 Port to Sun C.
8422 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8423 that Sun C diagnosed.
8424 * fns.c (secure_hash): Fix pointer signedness issue.
8425 * intervals.c (static_offset_intervals): New function.
8426 (offset_intervals): Use it.
8427
7f3f739f
LL
84282011-06-21 Leo Liu <sdl.web@gmail.com>
8429
8430 * deps.mk (fns.o):
8431 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8432 sha512.h.
8433
8434 * fns.c (secure_hash): Rename from crypto_hash_function and change
8435 the first arg to accept symbols.
5b66d427 8436 (Fsecure_hash): New primitive.
7f3f739f
LL
8437 (syms_of_fns): New symbols.
8438
76147d94
DD
84392011-06-20 Deniz Dogan <deniz@dogan.se>
8440
8441 * process.c (Fset_process_buffer): Clarify return value in
8442 docstring.
8443
7d7d0045
CY
84442011-06-18 Chong Yidong <cyd@stupidchicken.com>
8445
8446 * dispnew.c (add_window_display_history): Use BVAR.
8447
8448 * xdisp.c (debug_method_add): Use BVAR.
8449 (check_window_end, dump_glyph_matrix, dump_glyph)
8450 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8451
8452 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8453 Likewise.
8454
8455 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8456 check till after the cache is created in init_frame_faces.
8457
ff2bc410
SM
84582011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8459
8460 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8461
28177add
PE
84622011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8463
dd3482fe
PE
8464 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8465 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8466 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8467
393d71f3 8468 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8469 * fileio.c (Finsert_file_contents):
8470 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8471 Remove the old (too-loose) buffer overflow checks.
8472 They weren't needed, since make_gap checks for buffer overflow.
8473 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8474 The old code merely checked for Emacs fixnum overflow, and relied
8475 on undefined (wraparound) behavior. The new code avoids undefined
8476 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8477
2e6813b0 8478 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8479 Tune. Don't use wider integers than needed. Don't use alloca.
8480 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8481
599a9e4f
PE
8482 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8483
99561444
PE
8484 * insdel.c, lisp.h (buffer_overflow): New function.
8485 (insert_from_buffer_1, replace_range, replace_range_2):
8486 * insdel.c (make_gap_larger):
8487 * editfns.c (Finsert_char):
8488 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8489
28177add
PE
8490 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8491
e69dafad
PE
84922011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8493
4baa020d 8494 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8495
b1c46f02
PE
8496 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8497 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8498
e69dafad
PE
8499 * fileio.c: Don't assume EMACS_INT fits in off_t.
8500 (emacs_lseek): New static function.
8501 (Finsert_file_contents, Fwrite_region): Use it.
8502 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8503
566684ea
PE
8504 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8505
e6966cd6
PE
8506 * fns.c: Don't overflow int when computing a list length.
8507 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8508 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8509 truncation on 64-bit hosts. Check for QUIT every
8510 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8511 faster and is responsive enough.
8512 (Flength): Report an error instead of overflowing an integer.
8513 (Fsafe_length): Return a float if the value is not representable
8514 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8515 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8516 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8517
dd0b0efb
PE
8518 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8519 (header_size, word_size): New constants.
8520 (allocate_vectorlike): Don't check size overflow here.
8521 (allocate_vector): Check it here instead, since this is the only
8522 caller of allocate_vectorlike that could cause overflow.
8523 Check that the new vector's length is representable as a fixnum.
8524
86fe5cfe
PE
8525 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8526 The previous code was bogus. For example, next_almost_prime (32)
8527 returned 39, which is undesirable as it is a multiple of 3; and
8528 next_almost_prime (24) returned 25, which is a multiple of 5 so
8529 why was the code bothering to check for multiples of 7?
8530
80e88859
PE
8531 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8532
4a2f0ad6
PE
8533 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8534
f66c7cf8
PE
8535 Variadic C functions now count arguments with ptrdiff_t.
8536 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8537 Back then I didn't know that the Emacs coding style prefers signed int.
8538 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8539 were being counted with int, which may truncate counts on 64-bit
8540 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8541 * lisp.h (struct Lisp_Subr.function.aMANY)
8542 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8543 Arg counts are now ptrdiff_t, not size_t.
8544 All variadic functions and their callers changed accordingly.
8545 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8546 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8547 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8548 * callint.c (Fcall_interactively): Check arg count for overflow,
8549 to avoid potential buffer overrun. Use signed char, not 'int',
8550 for 'varies' array, so that we needn't bother to check its size
8551 calculation for overflow.
8552 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8553 * eval.c (apply_lambda):
8554 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8555 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8556 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8557
a1759b76
PE
8558 * callint.c (Fcall_interactively): Don't use index var as event count.
8559
d96be9fc
PE
8560 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8561 * mem-limits.h (SIZE): Remove; no longer used.
8562
a690a978 8563 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8564
578c21e6
PE
8565 Remove unnecessary casts.
8566 * xterm.c (x_term_init):
8567 * xfns.c (x_set_border_pixel):
8568 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8569 These aren't needed now that we assume ANSI C.
8570
96f53c6c
PE
8571 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8572 It's more likely to cause problems (due to unsigned overflow)
8573 than to cure them.
8574
83c77d31
PE
8575 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8576
ee2079f1
PE
8577 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8578
6da65536
PE
8579 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8580
7147c4a4
PE
8581 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8582
193e32d9
PE
8583 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8584
e5533da6
PE
8585 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8586
9910e595
PE
8587 GLYPH_CODE_FACE returns EMACS_INT, not int.
8588 * dispextern.h (merge_faces):
8589 * xfaces.c (merge_faces):
01103c44
PE
8590 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8591 Don't assume EMACS_INT fits in int.
9910e595 8592
2638320e
PE
8593 * character.h (CHAR_VALID_P): Remove unused parameter.
8594 * fontset.c, lisp.h, xdisp.c: All uses changed.
8595
045eb8d9
PE
8596 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8597
c1f134b5
PE
8598 * fns.c (concat): Minor tuning based on overflow analysis.
8599 This doesn't fix any bugs. Use int to hold character, instead
8600 of constantly refetching from Emacs object. Use XFASTINT, not
8601 XINT, for value known to be a character. Don't bother comparing
8602 a single byte to 0400, as it's always less.
8603
395fcb93 8604 * floatfns.c (Fexpt):
327eeec8
PE
8605 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8606
abbd3d23
PE
8607 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8608 for characters.
8609
684a03ef
PE
8610 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8611
0fed43f3
PE
8612 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8613 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8614 incorrectly succeed when S was a string, because 4294967386 was
8615 truncated before it was used.
8616
8fd02eb7
PE
8617 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8618 Otherwise, an out-of-range integer could cause undefined behavior
8619 on a 64-bit host.
8620
f8c86b69
PE
8621 * composite.c: Use int, not EMACS_INT, for characters.
8622 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8623 EMACS_INT, for values that are known to be in character range.
8624 This doesn't fix any bugs but is the usual style inside Emacs and
8625 may generate better code on 32-bit machines.
8626
34206dd2
PE
8627 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8628 This is for reasons similar to the recent CHAR_STRING fix.
8629 * charset.c (Fencode_char): Check that character arg is actually
8630 a character. Pass an int to ENCODE_CHAR.
8631 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8632 wider than 'int', as a compile-time check to prevent future regressions
8633 in this area.
8634
c5958d4c 8635 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8636
8637 Make sure a 64-bit char is never passed to CHAR_STRING.
8638 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8639 by silently ignoring the top 32 bits, allowing some values
8640 that were far too large to be valid characters.
8641 * character.h: Include <verify.h>.
8642 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8643 arguments are no wider than unsigned, as a compile-time check
8644 to prevent future regressions in this area.
8645 * data.c (Faset):
01103c44 8646 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8647 (Fsubst_char_in_region):
8648 * fns.c (concat):
8649 * xdisp.c (decode_mode_spec_coding):
8650 Adjust to CHAR_STRING's new requirement.
8651 * editfns.c (Finsert_char, Fsubst_char_in_region):
8652 * fns.c (concat): Check that character args are actually
8653 characters. Without this test, these functions did the wrong
8654 thing with wildly out-of-range values on 64-bit hosts.
8655
d37ca623
PE
8656 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8657 These casts should not be needed on 32-bit hosts, either.
8658 * keyboard.c (read_char):
8659 * lread.c (Fload): Remove casts to unsigned.
8660
ea204efb
PE
8661 * lisp.h (UNSIGNED_CMP): New macro.
8662 This fixes comparison bugs on 64-bit hosts.
8663 (ASCII_CHAR_P): Use it.
8664 * casefiddle.c (casify_object):
01103c44 8665 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8666 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8667 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8668 * dispextern.h (FACE_FROM_ID):
8669 * keyboard.c (read_char): Use UNSIGNED_CMP.
8670
41cb286c
PE
8671 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8672 not to EMACS_INT, to avoid GCC warning.
8673
4a1b9832
PE
8674 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8675
55daad71
PE
8676 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8677 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8678 isn't needed on 32-bit machines.
8f95c75c 8679
01103c44
PE
8680 * buffer.c (Fgenerate_new_buffer_name):
8681 Use EMACS_INT for count, not int.
0ceccced 8682 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8683
8684 * data.c (Qcompiled_function): Now static.
8685
c6f072e7
PE
8686 * window.c (window_body_lines): Now static.
8687
20ce5912
PE
8688 * image.c (gif_load): Rename local to avoid shadowing.
8689
9c4c5f81
PE
8690 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8691 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8692 * alloc.c (make_save_value): Integer argument is now of type
8693 ptrdiff_t, not int.
8694 (mark_object): Use ptrdiff_t, not int.
8695 * lisp.h (pD): New macro.
8696 * print.c (print_object): Use it.
8697
c0c5c8ae
PE
8698 * alloc.c: Use EMACS_INT, not int, to count objects.
8699 (total_conses, total_markers, total_symbols, total_vector_size)
8700 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8701 (total_free_floats, total_floats, total_free_intervals)
8702 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8703 Now EMACS_INT, not int. All uses changed.
8704 (Fgarbage_collect): Compute overall total using a double, so that
8705 integer overflow is less likely to be a problem. Check for overflow
8706 when converting back to an integer.
5a25e253
PE
8707 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8708 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8709 These were 'int' variables that could overflow on 64-bit hosts;
8710 they were never used, so remove them instead of repairing them.
211a0b2a 8711 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8712 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8713 Previously, this ceilinged at INT_MAX, but that doesn't work on
8714 64-bit machines.
e46bb31a 8715 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8716
c78baabf 8717 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8718 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8719 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8720 when a (possibly-narrower) signed value would do just as well.
8721 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8722
c9d624c6
PE
8723 * alloc.c: Catch some string size overflows that we were missing.
8724 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8725 for convenience in STRING_BYTES_MAX.
8726 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8727 The definition here is exact; the one in lisp.h was approximate.
8728 (allocate_string_data): Check for string overflow. This catches
8729 some instances we weren't catching before. Also, it catches
8730 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8731 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8732 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8733
c9d624c6
PE
8734 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8735 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8736 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8737
353032ce
PE
8738 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8739
2bccce07
PE
8740 * alloc.c (Fmake_string): Check for out-of-range init.
8741
0ac30604
SM
87422011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8743
8744 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8745
c195f2de
JD
87462011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8747
8748 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8749 xg_get_default_scrollbar_width.
8750
8751 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8752 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8753 (style_changed_cb): Call update_theme_scrollbar_width and call
8754 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8755 all frames (Bug#8505).
8756 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8757 Call gtk_window_set_resizable if HAVE_GTK3.
8758 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8759 and height if HAVE_GTK3 (Bug#8505).
8760 (scroll_bar_width_for_theme): New variable.
8761 (update_theme_scrollbar_width): New function.
8762 (xg_get_default_scrollbar_width): Move code to
8763 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8764 (xg_initialize): Call update_theme_scrollbar_width.
8765
8766 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8767
8768 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8769
e10ac9f1
MR
87702011-06-12 Martin Rudalics <rudalics@gmx.at>
8771
8772 * frame.c (make_frame): Call other_buffer_safely instead of
8773 other_buffer.
8774
8775 * window.c (temp_output_buffer_show): Call display_buffer with
8776 second argument Vtemp_buffer_show_specifiers and reset latter
8777 immediately after the call.
8778 (Vtemp_buffer_show_specifiers): New variable.
8779 (auto_window_vscroll_p, next_screen_context_lines)
8780 (Vscroll_preserve_screen_position): Remove leading asterisks from
8781 doc-strings.
8782
2d3c217e 87832011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8784
7b7f97e8 8785 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8786 * buffer.c (Qclone_number): Remove for now, as it's unused.
8787 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8788 (record_buffer): Remove unused local.
8789 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8790 (set_frame_buffer_list): Remove; unused.
8791 * frame.h (other_visible_frames): Remove decl.
8792 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8793 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8794 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8795 if HAVE_GPM.
8796 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8797 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8798 Define only if HAVE_GPM.
8799 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8800 (update_hints_inhibit): Remove; never set. All uses removed.
8801 * widgetprv.h (emacsFrameClassRec): Remove decl.
8802 * window.c (delete_deletable_window): Now returns void, since it
8803 wasn't returning anything.
8804 (compare_window_configurations): Remove unused locals.
8805 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8806 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8807 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8808 the same widths as pointers. This follows up on the 2011-05-06 patch.
8809 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8810 * xterm.h: Likewise.
8811 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8812
1384b89e
JB
88132011-06-12 Juanma Barranquero <lekktu@gmail.com>
8814
8815 * makefile.w32-in: Update dependencies.
8816 (LISP_H): Add lib/intprops.h.
8817
1100a63c
CY
88182011-06-11 Chong Yidong <cyd@stupidchicken.com>
8819
8820 * image.c (gif_load): Add animation frame delay to the metadata.
8821 (syms_of_image): Use DEFSYM. New symbol `delay'.
8822
6198ccd0
MR
88232011-06-11 Martin Rudalics <rudalics@gmx.at>
8824
8825 * window.c (delete_deletable_window): Re-add.
8826 (Fset_window_configuration): Rewrite to handle dead buffers and
8827 consequently deletable windows.
8828 (window_tree, Fwindow_tree): Remove. Supply functionality in
8829 window.el.
8830 (compare_window_configurations): Simplify code.
8831
b6e3633c
AS
88322011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8833
1ab0dee5
AS
8834 * image.c (imagemagick_load_image): Fix type mismatch.
8835 (Fimagemagick_types): Likewise.
8836
b6e3633c
AS
8837 * window.h (replace_buffer_in_windows): Declare.
8838
9397e56f
MR
88392011-06-11 Martin Rudalics <rudalics@gmx.at>
8840
8841 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8842 Qclone_number. Remove external declaration of Qdelete_window.
8843 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8844 code.
640c8776
SM
8845 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8846 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8847 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8848 buffer list implementation.
8849 (other_buffer_safely): New function.
8850 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8851 calls to replace_buffer_in_windows and
8852 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8853 if allowed.
8854 (record_buffer): Inhibit quitting and rewrite using quittable
8855 functions. Run Qbuffer_list_update_hook if allowed.
8856 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8857 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8858 Move switch-to-buffer to window.el.
9397e56f
MR
8859 (bury-buffer): Move to window.el.
8860 (Vbuffer_list_update_hook): New variable.
8861
8862 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8863 section.
8864
8865 * window.h (resize_frame_windows): Move up in code.
8866 (Fwindow_frame): Remove EXFUN.
8867 (replace_buffer_in_all_windows): Remove prototype.
8868 (replace_buffer_in_windows_safely): Add prototype.
8869
8870 * window.c: Declare Qdelete_window static again. Move down
8871 declaration of select_count.
8872 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8873 (Fother_window): Move to window.el.
8874 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8875 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8876 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8877 window.el.
8878 (replace_buffer_in_windows): Implement by calling
8879 Qreplace_buffer_in_windows.
8880 (replace_buffer_in_all_windows): Remove with some functionality
8881 moved into replace_buffer_in_windows_safely.
8882 (replace_buffer_in_windows_safely): New function.
8883 (select_window_norecord, select_frame_norecord): Move in front
8884 of run_window_configuration_change_hook. Remove now obsolete
8885 declarations.
640c8776
SM
8886 (Fset_window_buffer): Rewrite doc-string.
8887 Call Qrecord_window_buffer.
9397e56f
MR
8888 (keys_of_window): Move binding for other-window to window.el.
8889
b50691aa
CY
88902011-06-11 Chong Yidong <cyd@stupidchicken.com>
8891
8892 * dispextern.h (struct image): Replace data member, whose int_val
8893 and ptr_val fields were not used by anything, with a single
8894 lisp_val object.
8895
8896 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8897 (gif_clear_image, gif_load, imagemagick_load_image)
8898 (gs_clear_image, gs_load): Callers changed.
8899
3f754b86
PE
89002011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8901
cca69397
PE
8902 * buffer.h: Include <time.h>, for time_t.
8903 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8904
109e28d0
PE
8905 Fix minor problems found by static checking.
8906
60737f02
PE
8907 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8908
4b66faf3
PE
8909 Make identifiers static if they are not used in other modules.
8910 * data.c (Qcompiled_function, Qframe, Qvector):
8911 * image.c (QimageMagick, Qsvg):
8912 * minibuf.c (Qmetadata):
8913 * window.c (resize_window_check, resize_root_window): Now static.
8914 * window.h (resize_window_check, resize_root_window): Remove decls.
8915
109e28d0
PE
8916 * window.c (window_deletion_count, delete_deletable_window):
8917 Remove; unused.
46a4ce9e
PE
8918 (window_body_lines): Now static.
8919 (Fdelete_other_windows_internal): Mark vars as initialized.
8920 Make sure 'resize_failed' is initialized.
8921 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8922 (resize_window_apply): Remove unused local.
8923 * window.h (delete_deletable_window): Remove decl.
8924
109e28d0 8925 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8926 (imagemagick_load_image): Fix pointer signedness problem by changing
8927 last arg from unsigned char * to char *. All uses changed.
8928 Also, fix a local for similar reasons.
8929 Remove unused locals. Remove locals to avoid shadowing.
8930 (fn_rsvg_handle_free): Remove; unused.
8931 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8932 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8933
3f754b86
PE
8934 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8935
2547adb1
CY
89362011-06-10 Chong Yidong <cyd@stupidchicken.com>
8937
8938 * image.c (gif_load): Fix omitted cast error introduced by
8939 2011-06-06 change.
8940
2c8e37d4
MR
89412011-06-10 Martin Rudalics <rudalics@gmx.at>
8942
8943 * window.h (resize_proportionally, orig_total_lines)
8944 (orig_top_line): Remove from window structure.
8945 (set_window_height, set_window_width, change_window_heights)
8946 (Fdelete_window): Remove prototypes.
8947 (resize_frame_windows): Remove duplicate declaration.
8948
440a42e3
EZ
89492011-06-10 Eli Zaretskii <eliz@gnu.org>
8950
8951 * window.h (resize_frame_windows, resize_window_check)
8952 (delete_deletable_window, resize_root_window)
8953 (resize_frame_windows): Declare prototypes.
8954
8955 * window.c (resize_window_apply): Make definition be "static" to
8956 match the prototype.
8957
562dd5e9
MR
89582011-06-10 Martin Rudalics <rudalics@gmx.at>
8959
8960 * window.c: Remove declarations of Qwindow_size_fixed,
8961 window_min_size_1, window_min_size_2, window_min_size,
8962 size_window, window_fixed_size_p, enlarge_window, delete_window.
8963 Remove static from declaration of Qdelete_window, it's
8964 temporarily needed by Fbury_buffer.
8965 (replace_window): Don't assign orig_top_line and
8966 orig_total_lines.
8967 (Fdelete_window, delete_window): Remove. Window deletion is
8968 handled by window.el.
640c8776
SM
8969 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8970 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8971 (Fdelete_other_windows): Remove. Deleting other windows is
8972 handled by window.el.
8973 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8974 handled in window.el.
8975 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8976 Window minimum sizes are handled in window.el.
8977 (shrink_windows, size_window, set_window_height)
8978 (set_window_width, change_window_heights, window_height)
8979 (window_width, CURBEG, CURSIZE, enlarge_window)
8980 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8981 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8982 handled in window.el.
8983 (make_dummy_parent): Rename to make_parent_window and give it a
8984 second argument horflag.
8985 (make_window): Don't set resize_proportionally any more.
8986 (Fsplit_window): Remove. Windows are split in window.el.
8987 (save_restore_action, save_restore_orig_size)
8988 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8989 Resize mini windows in window.el.
8990 (grow_mini_window, shrink_mini_window): Implement by calling
8991 Qresize_root_window_vertically, resize_window_check and
8992 resize_window_apply.
640c8776
SM
8993 (saved_window, Fset_window_configuration, save_window_save):
8994 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8995 resize_proportionally.
8996 (window_min_height, window_min_width): Move to window.el.
8997 (keys_of_window): Move bindings for delete-other-windows,
8998 split-window, delete-window and enlarge-window to window.el.
8999
9000 * buffer.c: Temporarily extern Qdelete_window.
9001 (Fbury_buffer): Temporarily call Qdelete_window instead of
9002 Fdelete_window (Fbury_buffer will move to window.el soon).
9003
9004 * frame.c (set_menu_bar_lines_1): Remove code handling
9005 orig_top_line and orig_total_lines.
9006
9007 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9008 set_window_height but set heights directly.
9009 (change_frame_size_1): Use resize_frame_windows.
9010
9011 * xdisp.c (init_xdisp): Don't use set_window_height but set
9012 heights directly.
9013
640c8776
SM
9014 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9015 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9016 run_window_configuration_change_hook.
9017
9018 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9019 instead of change_window_heights and run
9020 run_window_configuration_change_hook.
9021
1a13852e
MR
90222011-06-09 Martin Rudalics <rudalics@gmx.at>
9023
9024 * window.c (replace_window): Rename second argument REPLACEMENT to
9025 NEW. New third argument SETFLAG. Rewrite.
9026 (delete_window, make_dummy_parent): Call replace_window with
9027 third argument 1.
9028 (window_list_1): Move down in code.
9029 (run_window_configuration_change_hook): Move set_buffer part
9030 before select_frame_norecord part in order to unwind correctly.
9031 Rename count1 to count.
9032 (recombine_windows, delete_deletable_window, resize_root_window)
9033 (Fdelete_other_windows_internal)
9034 (Frun_window_configuration_change_hook, make_parent_window)
9035 (resize_window_check, resize_window_apply, Fresize_window_apply)
9036 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9037 (Fdelete_window_internal, Fresize_mini_window_internal):
9038 New functions.
1a13852e
MR
9039 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9040
f3d1777e
MR
90412011-06-08 Martin Rudalics <rudalics@gmx.at>
9042
496e208e
MR
9043 * window.h (window): Add some new members to window structure -
9044 normal_lines, normal_cols, new_total, new_normal, clone_number,
9045 splits, nest, prev_buffers, next_buffers.
9046 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9047 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9048
f3d1777e
MR
9049 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9050 Remove.
496e208e
MR
9051 (make_dummy_parent): Set new members of windows structure.
9052 (make_window): Move down in code. Handle new members of window
9053 structure.
9054 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9055 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9056 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9057 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9058 (Fset_window_next_buffers, Fset_window_clone_number):
9059 New functions.
496e208e
MR
9060 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9061 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9062 Doc-string fixes.
9063 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9064 Argument WINDOW can be now internal window too.
9065 (Fwindow_use_time): Move up in code.
9066 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9067 Rewrite doc-string.
9068 (Fset_window_configuration, saved_window)
9069 (Fcurrent_window_configuration, save_window_save): Handle new
9070 members of window structure.
b9e809c2
MR
9071 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9072 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9073 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9074 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9075 Qget_mru_window, Qresize_root_window,
9076 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9077 Qauto_buffer_name; staticpro them.
f3d1777e 9078
abde8f8c
MR
90792011-06-07 Martin Rudalics <rudalics@gmx.at>
9080
9081 * window.c (Fwindow_total_size, Fwindow_left_column)
9082 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9083 (Fwindow_list_1): New functions.
9084 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9085 (Fwindow_width, Fscroll_left, Fscroll_right):
9086 Use window_body_cols instead of window_box_text_cols.
9087 (delete_window, Fset_window_configuration):
9088 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9089 (delete_all_subwindows): Take a window as argument and not a
9090 structure. Rewrite.
190b47e6
MR
9091 (window_loop): Remove handling of GET_LRU_WINDOW and
9092 GET_LARGEST_WINDOW.
9093 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9094
9095 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9096 window_box_text_cols. delete_all_subwindows now takes a
9097 Lisp_Object as argument.
abde8f8c 9098
640c8776
SM
9099 * indent.c (compute_motion, Fcompute_motion):
9100 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9101
fa8a67e6
MR
9102 * frame.c (delete_frame): Call delete_all_subwindows with root
9103 window as argument.
9104
a54e3482
DC
91052011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9106
9107 * fns.c (Fputhash): Document return value.
9108
60002bf5
CY
91092011-06-06 Chong Yidong <cyd@stupidchicken.com>
9110
9111 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9112
0c671da6 91132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9114
b862a52a 9115 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9116
be44ca6c
PE
9117 Check for overflow when converting integer to cons and back.
9118 * charset.c (Fdefine_charset_internal, Fdecode_char):
9119 Use cons_to_unsigned to catch overflow.
9120 (Fencode_char): Use INTEGER_TO_CONS.
9121 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9122 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9123 * data.c (long_to_cons, cons_to_long): Remove.
9124 (cons_to_unsigned, cons_to_signed): New functions.
9125 These signal an error for invalid or out-of-range values.
9126 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9127 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9128 * font.c (Ffont_variation_glyphs):
9129 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9130 * lisp.h: Include <intprops.h>.
9131 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9132 (cons_to_signed, cons_to_unsigned): New decls.
9133 (long_to_cons, cons_to_long): Remove decls.
9134 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9135 (Fprimitive_undo): Use CONS_TO_INTEGER.
9136 * xfns.c (Fx_window_property): Likewise.
9137 * xselect.c: Include <limits.h>.
9138 (x_own_selection, selection_data_to_lisp_data):
9139 Use INTEGER_TO_CONS.
9140 (x_handle_selection_request, x_handle_selection_clear)
9141 (x_get_foreign_selection, Fx_disown_selection_internal)
9142 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9143 (lisp_data_to_selection_data): Use cons_to_unsigned.
9144 (x_fill_property_data): Use cons_to_signed.
9145 Report values out of range.
9146
d1f3d2af
PE
9147 Check for buffer and string overflow more precisely.
9148 * buffer.h (BUF_BYTES_MAX): New macro.
9149 * lisp.h (STRING_BYTES_MAX): New macro.
9150 * alloc.c (Fmake_string):
9151 * character.c (string_escape_byte8):
9152 * coding.c (coding_alloc_by_realloc):
9153 * doprnt.c (doprnt):
9154 * editfns.c (Fformat):
9155 * eval.c (verror):
9156 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9157 since they may not be the same number.
9158 * editfns.c (Finsert_char):
9159 * fileio.c (Finsert_file_contents):
9160 Likewise for BUF_BYTES_MAX.
9161
dd52fcea
PE
9162 * image.c: Use ptrdiff_t, not int, for sizes.
9163 (slurp_file): Switch from int to ptrdiff_t.
9164 All uses changed.
9165 (slurp_file): Check that file size fits in both size_t (for
9166 malloc) and ptrdiff_t (for sanity and safety).
9167
7f9bbdbb
PE
9168 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9169 if b->modtime has its maximal value.
9170
dfe18f82
PE
9171 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9172
84acfcf0
PE
9173 Don't assume time_t can fit into int.
9174 * buffer.h (struct buffer.modtime): Now time_t, not int.
9175 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9176 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9177
ccd9a01a
PE
9178 Minor fixes for signed vs unsigned integers.
9179 * character.h (MAYBE_UNIFY_CHAR):
9180 * charset.c (maybe_unify_char):
9181 * keyboard.c (read_char, reorder_modifiers):
9182 XINT -> XFASTINT, since the integer must be nonnegative.
9183 * ftfont.c (ftfont_spec_pattern):
9184 * keymap.c (access_keymap, silly_event_symbol_error):
9185 XUINT -> XFASTINT, since the integer must be nonnegative.
9186 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9187 since it makes no difference and we prefer signed.
9188 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9189 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9190 nonnegative.
9191
d6d100dd
SM
91922011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9193
9194 * window.h (Fwindow_frame): Declare.
9195
2b6148e4
PE
91962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9197
9198 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9199 (SPARE_MEMORY): Always define.
9200 (LARGE_REQUEST): Remove.
9201 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9202
f230ecc9
MR
92032011-06-06 Martin Rudalics <rudalics@gmx.at>
9204
727e958e
MR
9205 * lisp.h: Move EXFUNS for Fframe_root_window,
9206 Fframe_first_window and Fset_frame_selected_window to window.h.
9207
9208 * window.h: Move EXFUNS for Fframe_root_window,
9209 Fframe_first_window and Fset_frame_selected_window here from
9210 lisp.h.
9211
9212 * frame.c (Fwindow_frame, Fframe_first_window)
9213 (Fframe_root_window, Fframe_selected_window)
9214 (Fset_frame_selected_window): Move to window.c.
9215 (Factive_minibuffer_window): Move to minibuf.c.
9216 (Fother_visible_frames_p): New function.
9217
9218 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9219
f230ecc9
MR
9220 * window.c (decode_window, decode_any_window): Move up in code.
9221 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9222 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9223 (Fwindow_buffer): Move up and rewrite doc-string.
9224 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9225 (Fwindow_prev): New functions.
727e958e
MR
9226 (Fwindow_frame): Move here from frame.c. Accept any window as
9227 argument.
9228 (Fframe_root_window, Fframe_first_window)
9229 (Fframe_selected_window): Move here from frame.c. Accept frame
9230 or arbitrary window as argument. Update doc-strings.
9231 (Fminibuffer_window): Move up in code.
9232 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9233 (Fset_frame_selected_window): Move here from frame.c.
9234 Marginal rewrite.
727e958e
MR
9235 (Fselected_window, select_window, Fselect_window): Move up in
9236 code. Minor doc-string fixes.
f230ecc9 9237
4d09bcf6
PE
92382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9239
9240 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9241 Do not assume that spare memory exists; that assumption is valid
9242 only if SYSTEM_MALLOC.
9243 (LARGE_REQUEST): New macro, so that the issue of large requests
9244 is separated from the issue of spare memory.
9245
810928a2
AS
92462011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9247
172418ad
AS
9248 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9249 format. (Bug#8806)
9250
43f862f7
AS
9251 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9252
810928a2
AS
9253 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9254 before statements.
9255
a059fe24
JD
92562011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9257
9258 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9259
9260 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9261
9262 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9263 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9264
989bf368
JB
92652011-06-05 Juanma Barranquero <lekktu@gmail.com>
9266
9267 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9268
4b80f674
CY
92692011-06-04 Chong Yidong <cyd@stupidchicken.com>
9270
9271 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9272 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9273 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9274 New error handlers.
4b80f674
CY
9275 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9276 Obey Vx_select_enable_clipboard_manager. Catch errors in
9277 x_clipboard_manager_save (Bug#8779).
9278 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9279 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9280
99a33b77 92812011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9282
9283 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9284
99a33b77 92852011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9286
9287 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9288 in the current matrix if keep_current_p is non-zero.
9289
8264569d
EZ
92902011-06-04 Eli Zaretskii <eliz@gnu.org>
9291
9292 * bidi.c (bidi_level_of_next_char): Fix last change.
9293
57f97249
EZ
92942011-06-03 Eli Zaretskii <eliz@gnu.org>
9295
fec2107c 9296 Support bidi reordering of text covered by display properties.
57f97249 9297
fec2107c
EZ
9298 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9299 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9300 (bidi_cache_search, bidi_cache_iterator_state)
9301 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9302 (bidi_level_of_next_char, bidi_move_to_visually_next):
9303 Support character positions inside a run of characters covered by a
fec2107c
EZ
9304 display string.
9305 (bidi_paragraph_init, bidi_resolve_explicit_1)
9306 (bidi_level_of_next_char): Call bidi_fetch_char and
9307 bidi_fetch_char_advance instead of FETCH_CHAR and
9308 FETCH_CHAR_ADVANCE.
9309 (bidi_init_it): Initialize new members.
9310 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9311 definitions.
9312 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9313 instead of using explicit *_CHAR codes.
d6d100dd
SM
9314 (bidi_resolve_explicit, bidi_resolve_weak):
9315 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9316 bidirectional text is supported only in multibyte buffers.
9317 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9318 it to initialize the frame_window_p member of struct bidi_it.
9319 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9320 (bidi_resolve_explicit, bidi_resolve_weak)
9321 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9322 bidi_it->nchars is non-positive.
9323 (bidi_level_of_next_char): Don't try to lookup the cache for the
9324 next/previous character if nothing is cached there yet, or if we
9325 were just reseat()'ed to a new position.
c40e2fb2 9326
0e14fe90
EZ
9327 * xdisp.c (set_cursor_from_row): Set start and stop points
9328 according to the row's direction when priming the loop that looks
9329 for the glyph on which to display cursor.
9330 (single_display_spec_intangible_p): Function deleted.
9331 (display_prop_intangible_p): Reimplement to call
9332 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9333 Accept 3 additional arguments needed by handle_display_spec.
9334 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9335 values: lists, `(when COND...)' forms, etc.
9336 (single_display_spec_string_p): Support property values that are
9337 lists with the argument STRING its top-level element.
9338 (display_prop_string_p): Fix the condition for processing a
9339 property that is a list to be consistent with handle_display_spec.
fec2107c 9340 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9341 last portion of handle_display_prop.
9342 (compute_display_string_pos): Accept additional argument
9343 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9344 value of a `display' property is a "replacing spec".
9345 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9346 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9347 the display property, but just return a value indicating whether
9348 the display property will replace the characters it covers.
9349 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9350 frame_window_p members of struct bidi_it.
d6d100dd
SM
9351 (compute_display_string_pos, compute_display_string_end):
9352 New functions.
fec2107c
EZ
9353 (push_it): Accept second argument POSITION, where pop_it should
9354 jump to continue iteration.
9355 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9356
fec2107c
EZ
9357 * keyboard.c (adjust_point_for_property): Adjust the call to
9358 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9359
9360 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9361 (bidi_init_it): Update prototypes.
9362 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9363 (compute_display_string_pos, compute_display_string_end):
9364 Declare prototypes.
fec2107c
EZ
9365 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9366 EMACS_INT.
fc6f18ce 9367
40087514 93682011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9369
57f53182
PE
9370 Malloc failure behavior now depends on size of allocation.
9371 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9372 * lisp.h: Change signatures accordingly.
9373 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9374 All callers changed. (Bug#8762)
9375
9376 * gnutls.c: Use Emacs's memory allocators.
9377 Without this change, the gnutls library would invoke malloc etc.
9378 directly, which causes problems on non-SYNC_INPUT hosts, and which
9379 runs afoul of improving memory_full behavior. (Bug#8761)
9380 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9381 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9382 xfree instead of the default malloc, realloc, free.
9383 (Fgnutls_boot): No need to check for memory allocation failure,
9384 since xmalloc does that for us.
9385
ac32cd99 9386 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9387 * category.c (hash_get_category_set):
9388 * ccl.c (ccl_driver):
9389 * charset.c (Fdefine_charset_internal):
9390 * charset.h (struct charset.hash_index):
9391 * composite.c (get_composition_id, gstring_lookup_cache)
9392 (composition_gstring_put_cache):
9393 * composite.h (struct composition.hash_index):
9394 * dispextern.h (struct image.hash):
9395 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9396 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9397 (hashfn_equal, hashfn_user_defined, make_hash_table)
9398 (maybe_resize_hash_table, hash_lookup, hash_put)
9399 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9400 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9401 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9402 * image.c (make_image, search_image_cache, lookup_image)
9403 (xpm_put_color_table_h):
9404 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9405 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9406 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9407 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9408 * alloc.c (allocate_vectorlike):
9409 Check for overflow in vector size calculations.
9410 * ccl.c (ccl_driver):
9411 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9412 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9413 need to be updated by these changes.
40087514
PE
9414 * fns.c (make_hash_table, maybe_resize_hash_table):
9415 Check for integer overflow with large hash tables.
0de4bb68
PE
9416 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9417 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9418 (SXHASH_REDUCE): New macro.
9419 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9420 Use it instead of discarding useful hash info with large hash values.
9421 (sxhash_float): New function.
9422 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9423 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9424 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9425 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9426 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9427 Adjust signatures to match updated version of code.
9428 (consing_since_gc): Now EMACS_INT, since a single hash table can
9429 use more than INT_MAX bytes.
9430
698d32e2
DN
94312011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9432
9433 Make it possible to build with GCC-4.6+ -O2 -flto.
9434
9435 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9436
fd6fa53f
SM
94372011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9438
9439 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9440 Call minibuffer-inactive-mode.
9441
864db017
JB
94422011-05-31 Juanma Barranquero <lekktu@gmail.com>
9443
9444 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9445 Update dependencies.
9446
2ad0baf4
DN
94472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9448
9449 * data.c (init_data): Remove code for UTS, this system is not
9450 supported anymore.
9451
4fcc2638
DN
94522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9453
9454 Don't force ./temacs to start in terminal mode.
9455
9456 * frame.c (make_initial_frame): Initialize faces in all cases, not
9457 only when CANNOT_DUMP is defined.
9458 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9459
c56e0fd5
DN
94602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9461
9462 * dispnew.c (add_window_display_history): Use const for the string
9463 pointer. Remove declaration, not needed.
9464
333d54da 94652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9466
55d4c1b2 9467 Use 'inline', not 'INLINE'.
333d54da 9468 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9469 * alloc.c, fontset.c (INLINE): Remove.
9470 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9471 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9472 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9473 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9474 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9475
738db178
DN
94762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9477
9478 Make it possible to run ./temacs.
9479
9480 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9481 syms_of_callproc does the same thing. Remove test for
9482 "initialized", do it in the caller.
9483 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9484
620c53a6
SM
94852011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9486
9487 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9488 (read_minibuf): Use get_minibuffer.
9489 (syms_of_minibuf): Use DEFSYM.
9490 (Qmetadata): New var.
9491 * data.c (Qbuffer): Don't make it static.
9492 (syms_of_data): Use DEFSYM.
9493
e003a292
PE
94942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9495
9496 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9497 (CCL_CODE_MIN): New macro.
9498
ed008a6d
PE
94992011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9500
3687c2ef
PE
9501 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9502
ed008a6d
PE
9503 * eval.c (Qdebug): Now static.
9504 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9505 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9506 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9507
d66c4c7c
CY
95082011-05-29 Chong Yidong <cyd@stupidchicken.com>
9509
9510 * image.c: Various fixes to ImageMagick code comments.
9511 (Fimagemagick_types): Doc fix.
9512
5fbc2025
PE
95132011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9514
0196f88a
PE
9515 Minor fixes prompted by GCC 4.6.0 warnings.
9516
9517 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9518
5fbc2025
PE
9519 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9520 (x_clipboard_manager_save_all): Move extern decl to ...
9521 * xterm.h: ... here, so that it can be checked for consistency.
9522
1dd3c2d9
CY
95232011-05-29 Chong Yidong <cyd@stupidchicken.com>
9524
9525 * xselect.c (x_clipboard_manager_save_frame)
9526 (x_clipboard_manager_save_all): New functions.
9527 (Fx_clipboard_manager_save): Lisp function deleted.
9528
9529 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9530 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9531
9532 * xterm.h: Update prototype.
9533
5ba6571d
WX
95342011-05-28 William Xu <william.xwl@gmail.com>
9535
9536 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9537 exiting (Bug#8239).
9538
3eaff834
JM
95392011-05-28 Jim Meyering <meyering@redhat.com>
9540
e1900994 9541 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9542 * fns.c (to_uchar): Define.
9543 (crypto_hash_function): Use it to convert some newly-signed
9544 variables to unsigned, to avoid sign-extension bugs. For example,
9545 without this change, (md5 "truc") would evaluate to
9546 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9547 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9548 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9549
0f6990a7
PE
95502011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9551
9552 Integer overflow fixes.
c8a9ca5a 9553
08686060
PE
9554 * dbusbind.c: Serial number integer overflow fixes.
9555 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9556 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9557 to hold a serial number that is too large for a fixnum.
9558 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9559 Check for serial numbers out of range. Decode any serial number
59568bf0 9560 that was so large that it became a float. (Bug#8722)
08686060 9561
2d1fc3c7
PE
9562 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9563 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9564 Use XFASTINT rather than XUINT when numbers are nonnegative.
9565 (xd_append_arg, Fdbus_method_return_internal):
9566 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9567 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9568 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9569 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9570 (Bug#8722)
2d1fc3c7 9571
c8a9ca5a
PE
9572 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9573
519e1d69
PE
9574 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9575
6df6ae42 9576 ccl: Add integer overflow checks.
30569699
PE
9577 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9578 (IN_INT_RANGE): New macros.
9579 (ccl_driver): Use them to check for integer overflow when
9580 decoding a CCL program. Many of the new checks are whether XINT (x)
9581 fits in int; it doesn't always, on 64-bit hosts. The new version
9582 doesn't catch all possible integer overflows, but it's an
847044ea 9583 improvement. (Bug#8719)
30569699 9584
c11285dc
PE
9585 * alloc.c (make_event_array): Use XINT, not XUINT.
9586 There's no need for unsigned here.
9587
fdccd48e
PE
9588 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9589 This follows up to the 2011-05-06 change that substituted uintptr_t
9590 for EMACS_INT. This case wasn't caught back then.
9591
37910ab2
PE
9592 Rework Fformat to avoid integer overflow issues.
9593 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9594 now (part of C89). Include <verify.h>.
9595 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9596 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9597 (Fformat): Avoid the prepass trying to compute sizes; it was only
9598 approximate and thus did not catch overflow reliably. Instead, walk
9599 through the format just once, formatting and computing sizes as we go,
9600 checking for integer overflow at every step, and allocating a larger
9601 buffer as needed. Keep track separately whether the format is
9602 multibyte. Keep only the most-recently calculated precision, rather
9603 than them all. Record whether each argument has been converted to
9604 string. Use EMACS_INT, not int, for byte and char and arg counts.
9605 Support field widths and precisions larger than INT_MAX. Avoid
9606 sprintf's undefined behavior with conversion specifications such as %#d
9607 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9608 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9609 formatting out-of-range floating point numbers with int
9173deec 9610 formats. (Bug#8668)
37910ab2 9611
2e6578fb
PE
9612 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9613
0ae6bdee
PE
9614 * data.c: Avoid integer truncation in expressions involving floats.
9615 * data.c: Include <intprops.h>.
9616 (arith_driver): When there's an integer overflow in an expression
9617 involving floating point, convert the integers to floating point
9618 so that the resulting value does not suffer from catastrophic
9619 integer truncation. For example, on a 64-bit host (* 4
9620 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9621 Do not rely on undefined behavior after integer overflow.
9622
de883a70
PE
9623 merge count_size_as_multibyte, parse_str_to_multibyte
9624 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9625 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9626 Check for integer overflow.
9627 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9628 since it's now a duplicate of the other. This is more of
9629 a character than a buffer op, so better that it's in character.c.
9630 * fns.c, print.c: Adjust to above changes.
9631
2ff916cb
PE
96322011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9633
9634 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9635
f1b54466
PE
96362011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9637
fb1ac845
PE
9638 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9639 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9640 (x_clipboard_manager_save): Now static.
9641 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9642
f1b54466
PE
9643 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9644 (crypto_hash_function): Now static.
9645 Fix pointer signedness problems. Avoid unnecessary initializations.
9646
a9f737ee
CY
96472011-05-27 Chong Yidong <cyd@stupidchicken.com>
9648
9649 * termhooks.h (Vselection_alist): Make it terminal-local.
9650
9651 * terminal.c (create_terminal): Initialize it.
9652
9653 * xselect.c: Support for clipboard managers.
9654 (Vselection_alist): Move to termhooks.h as terminal-local var.
9655 (LOCAL_SELECTION): New macro.
9656 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9657 (symbol_to_x_atom): Remove gratuitous arg.
9658 (x_handle_selection_request, lisp_data_to_selection_data)
9659 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9660 (x_own_selection, x_get_local_selection, x_convert_selection):
9661 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9662 (some_frame_on_display): Delete unused function.
9663 (Fx_own_selection_internal, Fx_get_selection_internal)
9664 (Fx_disown_selection_internal, Fx_selection_owner_p)
9665 (Fx_selection_exists_p): New optional frame arg.
9666 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9667 (x_handle_selection_clear): Don't treat other terminals with the
9668 same keyboard specially. Use the terminal-local Vselection_alist.
9669 (x_clear_frame_selections): Use Frun_hook_with_args.
9670
9671 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9672
9673 * xterm.h: Add support for those atoms.
9674
e067f0c1
CY
96752011-05-26 Chong Yidong <cyd@stupidchicken.com>
9676
9677 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9678 (converted_selections, conversion_fail_tag): New global variables.
9679 (x_selection_request_lisp_error): Free the above.
9680 (x_get_local_selection): Remove unnecessary code.
9681 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9682 of converted selections stored in converted_selections.
9683 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9684 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9685 (x_convert_selection): New function.
9686 (x_handle_selection_event): Simplify.
9687 (x_get_foreign_selection): Don't ignore incoming requests while
9688 waiting for an answer; this will fail when we implement
9689 SAVE_TARGETS, and seems unnecessary anyway.
9690 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9691 (Vx_sent_selection_functions): Doc fix.
9692
0f4aebc0
LL
96932011-05-26 Leo Liu <sdl.web@gmail.com>
9694
9695 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9696
e61124cd
YM
96972011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9698
9699 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9700
9701 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9702 for fringe update if it has periodic bitmap.
ac389d0c 9703 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9704 and fringe_bitmap_periodic_p.
9705
9706 * fringe.c (get_fringe_bitmap_data): New function.
9707 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9708 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9709 row. Mark glyph row for fringe update if periodicity changed.
9710
9711 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9712 for fringe update unless it has periodic bitmap.
9713
f16d9837
KH
97142011-05-25 Kenichi Handa <handa@m17n.org>
9715
9716 * xdisp.c (get_next_display_element): Set correct it->face_id for
9717 a static composition.
9718
e1b90ef6
LL
97192011-05-24 Leo Liu <sdl.web@gmail.com>
9720
9721 * deps.mk (fns.o):
9722 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9723
9724 * fns.c (crypto_hash_function, Fsha1): New function.
9725 (Fmd5): Use crypto_hash_function.
9726 (syms_of_fns): Add Ssha1.
9727
7400048f
PE
97282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9729
9730 * gnutls.c: Remove unused macros.
9731 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9732 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9733 Remove macros that are defined and never used.
9734 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9735
abb71cf4
CY
97362011-05-22 Chong Yidong <cyd@stupidchicken.com>
9737
9738 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9739 (Fx_get_selection_internal): Minor cleanup.
9740 (Fx_own_selection_internal): Rename arguments for consistency with
9741 select.el.
9742
6307db39
PE
97432011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9744
9745 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9746
f3d4e0a4
CY
97472011-05-22 Chong Yidong <cyd@stupidchicken.com>
9748
9749 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9750
4d8ade89
YM
97512011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9752
9753 * dispnew.c (scrolling_window): Don't exclude the case that the
9754 last enabled row in the desired matrix touches the bottom boundary.
9755
32078c8d
GM
97562011-05-21 Glenn Morris <rgm@gnu.org>
9757
9758 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9759 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9760 and add some more files.
32078c8d 9761
7285dc67
EZ
97622011-05-20 Eli Zaretskii <eliz@gnu.org>
9763
9764 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9765 report_file_error introduced by the change from 2011-05-07.
9766
89d1bd22
PE
97672011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9768
9769 * systime.h (Time): Define only if emacs is defined.
9770 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9771 where the include path doesn't have X11/X.h by default. See
9772 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9773
cd394be1 97742011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9775
9776 * composite.c (find_automatic_composition): Fix previous change.
9777
b9704ad9
GM
97782011-05-20 Glenn Morris <rgm@gnu.org>
9779
9780 * lisp.mk: New file, split from Makefile.in.
9781 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9782 (shortlisp): Remove.
9783 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9784
4a720484
GM
97852011-05-19 Glenn Morris <rgm@gnu.org>
9786
9787 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9788 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9789 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9790 (lisp): Set the order to that of loadup.el.
9791 (shortlisp): Make it a copy of $lisp.
9792 (SOME_MACHINE_LISP): Remove.
9793 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9794 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9795
a28d4396
KH
97962011-05-18 Kenichi Handa <handa@m17n.org>
9797
9798 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9799 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9800 (find_automatic_composition): Mostly rewrite for efficiency.
9801
a2b1fa8e
JB
98022011-05-18 Juanma Barranquero <lekktu@gmail.com>
9803
9804 * makefile.w32-in: Update dependencies.
9805
8e1f5610
CS
98062011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9807
9808 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9809 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9810
7025ee00 98112011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9812
cdfa6eab
PE
9813 Fix some integer overflow issues, such as string length overflow.
9814
06d6db33
PE
9815 * insdel.c (count_size_as_multibyte): Check for string overflow.
9816
2b4560a8
PE
9817 * character.c (lisp_string_width): Check for string overflow.
9818 Use EMACS_INT, not int, for string indexes and lengths; in
9819 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9820 the resulting string length overflows an EMACS_INT; instead,
9821 report a string overflow if no precision given. When checking for
9822 precision exhaustion, use a check that cannot possibly have
9823 integer overflow. (Bug#8675)
9824 * character.h (lisp_string_width): Adjust to new signature.
9825
cb93f9be
PE
9826 * alloc.c (string_overflow): New function.
9827 (Fmake_string): Use it. This doesn't change behavior, but saves
9828 a few bytes and will simplify future changes.
9829 * character.c (string_escape_byte8): Likewise.
9830 * lisp.h (string_overflow): New decl.
9831
1a1f3366
PE
9832 Fixups, following up to the user-interface timestamp change.
9833 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9834 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9835 * msdos.c (mouse_get_pos): Likewise.
9836 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9837 * w32gui.h (Time): Define by including "systime.h" rather than by
9838 declaring it ourselves. (Bug#8664)
9839
d4e3e4d3
PE
9840 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9841 * image.c (clear_image_cache): Likewise.
9842
f6a24d19
PE
9843 * term.c (term_mouse_position): Don't assume time_t wraparound.
9844
08dc5ae6
PE
9845 Be more systematic about user-interface timestamps.
9846 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9847 and sometimes 'EMACS_UINT', to represent these timestamps.
9848 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9849 This makes the code easier to follow, and makes it easier to catch
9850 integer overflow bugs such as Bug#8664.
9851 * frame.c (Fmouse_position, Fmouse_pixel_position):
9852 Use Time, not unsigned long, for user-interface timestamps.
9853 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9854 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9855 * keyboard.h (last_event_timestamp): Likewise.
9856 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9857 * menu.h (xmenu_show): Likewise.
9858 * term.c (term_mouse_position): Likewise.
9859 * termhooks.h (struct input_event.timestamp): Likewise.
9860 (struct terminal.mouse_position_hook): Likewise.
9861 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9862 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9863 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9864 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9865 what it was before.
9866 * menu.h, termhooks.h: Include "systime.h", for Time.
9867
8e55734a
PE
9868 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9869 Don't assume that the difference between two unsigned long values
9870 can fit into an integer. At this point, we know button_down_time
9871 <= event->timestamp, so the difference must be nonnegative, so
9872 there's no need to cast the result if double-click-time is
9873 nonnegative, as it should be; check that it's nonnegative, just in
9874 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9875 apart (about 25 days). (Bug#8664)
8e55734a 9876
841f1b75 9877 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9878 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9879
3e26f69c
PE
9880 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9881 that always fit in int. Use a sentinel instead of a counter, to
9882 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9883 * frame.h (struct frame): Use int for menu_bar_items_used
9884 instead of EMACS_INT, since it always fits in int.
3e26f69c 9885
5cc152c0
PE
9886 * menu.c (grow_menu_items): Check for int overflow.
9887
d89eb65e
PE
9888 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9889
5235bd3e
PE
9890 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9891 Before, the code was not consistent. These values cannot exceed
9892 2**31 - 1 so there's no need to make them unsigned.
9893 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9894 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9895 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9896 as modifiers.
9897 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9898
bc827e23
PE
9899 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9900 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9901 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9902 presumably because the widths might not match.
9903
78eb494e
PE
9904 * window.c (size_window): Avoid needless test at loop start.
9905
04f2d78b
CB
99062011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9907
9908 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9909
d2fc7e3d 99102011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9911
9912 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9913
d2fc7e3d 99142011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9915
9916 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9917 `width' to `bar_area_x' and `bar_area_width', respectively.
9918 (x_scroll_run): Take account of fringe background extension.
9919
04f2d78b
CB
9920 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9921 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9922 `bar_area_width', respectively.
9923 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9924 background extension.
9925
79b70037
GM
99262011-05-10 Jim Meyering <meyering@redhat.com>
9927
9928 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9929
2f142cc5
JB
99302011-05-10 Juanma Barranquero <lekktu@gmail.com>
9931
9932 * image.c (Finit_image_library): Return t for built-in image types,
9933 like pbm and xbm. (Bug#8640)
9934
57679c86
AS
99352011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9936
9937 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9938
888c9e86
EZ
99392011-05-07 Eli Zaretskii <eliz@gnu.org>
9940
b0512a1d
EZ
9941 * w32console.c (Fset_screen_color): Doc fix.
9942 (Fget_screen_color): New function.
9943 (syms_of_ntterm): Defsubr it.
9944
7285dc67
EZ
9945 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9946 unlink the temporary file if Fcall_process didn't create it in the
9947 first place.
9948 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9949 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9950 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9951 cue to call_process_cleanup not to close that handle.
9952
4d3fcc8e
BK
99532011-05-07 Ben Key <bkey76@gmail.com>
9954
9955 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9956 one of two shell specific rules, either bootstrap-temacs-CMD or
9957 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9958 to the previous implementation of the bootstrap-temacs rule.
9959 The bootstrap-temacs-CMD rule is similar to the previous
9960 implementation of the bootstrap-temacs rule except that it
9961 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9962 variable.
9963
9964 These changes, along with some changes to nt/configure.bat,
9965 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9966 earlier fix to add support for --cflags and --ldflags options
9967 that include quotes so that it works whether make uses cmd or
9968 sh as the shell.
9969
b4289b64
MA
99702011-05-06 Michael Albinus <michael.albinus@gmx.de>
9971
9972 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9973 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9974 is a constant.
9975 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9976 a string. Handle both cases.
9977 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9978 (Fdbus_register_method): Use Qinvalid_function.
9979
af4c0e28
JB
99802011-05-06 Juanma Barranquero <lekktu@gmail.com>
9981
9982 * makefile.w32-in: Update dependencies.
9983 (LISP_H): Add inttypes.h and stdin.h.
9984 (PROCESS_H): Add unistd.h.
9985
c51453d9
EZ
99862011-05-06 Eli Zaretskii <eliz@gnu.org>
9987
9988 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9989 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9990
8ff0ac3c 99912011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9992
4c4b566b
PE
9993 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9994
aab2b9b5
PE
9995 * term.c (vfatal): Remove stray call to va_end.
9996 It's not needed and the C Standard doesn't allow it here anyway.
9997
c378da0b
PE
9998 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9999 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10000
288b08c7
PE
10001 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10002 bytes.
10003
e3601888
PE
10004 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10005
db6c0e74
PE
10006 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10007
dd5963ea
PE
10008 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10009
88c9450f
PE
10010 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10011
2f9442b8
PE
10012 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10013
c032b5f8
PE
10014 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10015 * charset.c (Fdefine_charset_internal): Don't initialize
10016 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10017 32-bit int (Bug#8600).
a108c10b
PE
10018
10019 * lread.c (read_integer): Be more consistent with string-to-number.
10020 Use string_to_number to do the actual conversion; this avoids
10021 rounding errors and fixes some other screwups. Without this fix,
10022 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10023 (digit_to_number): Move earlier, for benefit of read_integer.
10024 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10025 not a digit in any supported base. (Bug#8602)
a108c10b 10026
ad5f9eea
PE
10027 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10028
aec1708a
PE
10029 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10030 to match comment at start of function. This also removes a
10031 GCC warning about overflow in a 32+64-bit port.
10032
47be4ab5
PE
10033 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10034
371cac43
PE
10035 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10036 Reported by Stefan Monnier in
10037 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10038 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10039 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10040
d01a7826
PE
10041 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10042 (EMACS_UINTPTR): Likewise, with uintptr_t.
10043
7fd47d5c
PE
10044 * lisp.h: Prefer 64-bit EMACS_INT if available.
10045 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10046 on 32-bit hosts that have 64-bit int, so that they can access
10047 large files.
122b0c86
PE
10048 However, temporarily disable this change unless the temporary
10049 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10050
8727937b
PE
10051 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10052
8ac068ac
PE
10053 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10054 This removes an assumption that EMACS_INT and long are the same
10055 width as pointers. The assumption is true for Emacs porting targets
10056 now, but we want to make other targets possible.
10057 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10058 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10059 In the rest of the code, change types of integers that hold casted
10060 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10061 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10062 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10063 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10064 No need to cast type when ORing.
10065 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10066 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10067 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10068 assume EMACS_INT is the same width as char *.
10069 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10070 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10071 Remove no-longer-needed casts.
10072 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10073 (xg_tool_bar_help_callback, xg_make_tool_item):
10074 Use EMACS_INTPTR to hold an integer
10075 that will be cast to void *; this can avoid a GCC warning
10076 if EMACS_INT is not the same width as void *.
10077 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10078 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10079 (current_message_1, set_message_1):
10080 Use a local to convert to proper width without a cast.
10081 * xmenu.c (dialog_selection_callback): Likewise.
10082
ede49d71
PE
10083 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10084 Also, don't assume VALBITS / RAND_BITS is less than 5,
10085 and don't rely on undefined behavior when shifting a 1 left into
10086 the sign bit.
10087 * lisp.h (get_random): Change signature to match.
10088
2f30ecd0
PE
10089 * lread.c (hash_string): Use size_t, not int, for hash computation.
10090 Normally we prefer signed values; but hashing is special, because
10091 it's better to use unsigned division on hash table sizes so that
10092 the remainder is nonnegative. Also, size_t is the natural width
10093 for hashing into memory. The previous code used 'int', which doesn't
10094 retain enough info to hash well into very large tables.
10095 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10096
2a866e7b
PE
10097 * dbusbind.c: Don't possibly lose pointer info when converting.
10098 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10099 Use XPNTR rather than XHASH, so that the high-order bits of
10100 the pointer aren't lost when converting through void *.
10101
51639eac
PE
10102 * eval.c (Fautoload): Don't double-shift a pointer.
10103
92394119
PE
10104 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10105
dbdb9a7c
JB
101062011-05-06 Juanma Barranquero <lekktu@gmail.com>
10107
10108 * gnutls.c (DEF_GNUTLS_FN):
10109 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10110
db7a0b4f
AS
101112011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10112
10113 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10114 marker. (Bug#8610)
10115
cd394be1 101162011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10117
10118 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10119 New version that can reserve upto 2GB of heap space.
10120
f7ff1b0f 101212011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10122
10123 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10124
639c109b
TZ
101252011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10126
10127 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10128 `gnutls_certificate_set_x509_key_file'.
10129
d2127135
JB
101302011-05-05 Juanma Barranquero <lekktu@gmail.com>
10131
10132 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10133 Update dependencies.
10134
e968f4f3
JB
101352011-05-04 Juanma Barranquero <lekktu@gmail.com>
10136
10137 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10138 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10139 Remove unused parameter `fildes'.
10140 * process.c (read_process_output, send_process): Don't pass it.
10141
84d358f0
JB
101422011-05-04 Juanma Barranquero <lekktu@gmail.com>
10143
10144 Fix previous change: the library cache is defined in w32.c.
10145 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10146 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10147
0898ca10
JB
101482011-05-04 Juanma Barranquero <lekktu@gmail.com>
10149
10150 Implement dynamic loading of GnuTLS on Windows.
10151
10152 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10153 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10154 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10155 Declare.
10156
10157 * gnutls.c (Qgnutls_dll): Define.
10158 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10159 (gnutls_*): Declare function pointers.
10160 (init_gnutls_functions): New function to initialize function pointers.
10161 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10162 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10163 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10164 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10165 (emacs_gnutls_write, emacs_gnutls_read)
10166 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10167 (Fgnutls_available_p): New function.
10168 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10169 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10170 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10171
10172 * image.c: Include w32.h.
10173 (Vimage_type_cache): Delete.
10174 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10175 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10176 (w32_delayed_load): Move to w32.c.
10177
10178 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10179
10180 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10181 (w32_delayed_load): Move from image.c. When loading a library, record
10182 its filename in the :loaded-from property of the library id.
10183 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10184 Initialize and staticpro them.
10185 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10186
10187 * process.c: Include lisp.h before w32.h, not after.
10188 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10189 instead of gnutls_record_check_pending.
10190
10191 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10192
ff4de4aa
TZ
101932011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10194
10195 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10196 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10197 as passed in.
10198
abe95abb
JD
101992011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10200
10201 * xterm.c (x_set_frame_alpha): Do not set property on anything
10202 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10203
e16e55d4
JB
102042011-05-02 Juanma Barranquero <lekktu@gmail.com>
10205
10206 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10207
bafcf6a5
JB
102082011-05-02 Juanma Barranquero <lekktu@gmail.com>
10209
10210 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10211 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10212 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10213 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10214 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10215 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10216 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10217 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10218 (Qgnutls_bootprop_callbacks_verify): Make static.
10219
e7a6747f
AS
102202011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10221
19ed11ba
AS
10222 * callproc.c: Indentation fixup.
10223
e7a6747f 10224 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10225 (wait_for_termination, interruptible_wait_for_termination):
10226 Move after wait_for_termination_1.
e7a6747f 10227
1ef14cb4
LMI
102282011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10229
10230 * sysdep.c (interruptible_wait_for_termination): New function
10231 which is like wait_for_termination, but allows keyboard
10232 interruptions.
10233
10234 * callproc.c (Fcall_process): Add (:file "file") as an option for
10235 the STDOUT buffer.
10236 (Fcall_process_region): Ditto.
10237
330d880c
EZ
102382011-04-30 Eli Zaretskii <eliz@gnu.org>
10239
8db90b73
EZ
10240 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10241 rather than `XVECTOR (FOO)->size'.
10242
330d880c
EZ
10243 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10244 inttypes.h, as a gnulib replacement is used if it not available in
10245 system headers.
10246
15cbd324
EZ
102472011-04-21 Eli Zaretskii <eliz@gnu.org>
10248
10249 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10250 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10251 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10252
10253 * coding.c (coding_alloc_by_realloc): Error out if destination
10254 will grow beyond MOST_POSITIVE_FIXNUM.
10255 (decode_coding_emacs_mule): Abort if there isn't enough place in
10256 charbuf for the composition carryover bytes. Reserve an extra
10257 space for up to 2 characters produced in a loop.
10258 (decode_coding_iso_2022): Abort if there isn't enough place in
10259 charbuf for the composition carryover bytes.
10260
102612011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10262
ae940cca
EZ
10263 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10264 aborting when %lld or %lll format is passed.
10265 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10266 %llo or %llx format is passed. (Bug#8545)
10267
03ab8921
EZ
10268 * window.c (window_scroll_line_based): Use a marker instead of
10269 simple variables to record original value of point. (Bug#7952)
10270
afda1437
EZ
10271 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10272 produced by %s or %c overflows available buffer space. (Bug#8545)
10273
f76dee0c
PE
102742011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10275
10276 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10277 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10278
fdc5744d
JB
102792011-04-28 Juanma Barranquero <lekktu@gmail.com>
10280
10281 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10282
638f053a
JB
102832011-04-28 Juanma Barranquero <lekktu@gmail.com>
10284
10285 * keyboard.c (Qdelayed_warnings_hook): Define.
10286 (command_loop_1): Run `delayed-warnings-hook'
10287 if Vdelayed_warnings_list is non-nil.
10288 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10289 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10290
d178f871
EZ
102912011-04-28 Eli Zaretskii <eliz@gnu.org>
10292
10293 * doprnt.c (doprnt): Don't return value smaller than the buffer
10294 size if the message was truncated. (Bug#8545).
10295
b124fd93
JB
102962011-04-28 Juanma Barranquero <lekktu@gmail.com>
10297
10298 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10299 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10300
e810457d
PE
103012011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10302
10303 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10304
ea51cceb
JB
103052011-04-27 Juanma Barranquero <lekktu@gmail.com>
10306
10307 * makefile.w32-in: Update dependencies.
10308
94dcfacf
EZ
103092011-04-27 Eli Zaretskii <eliz@gnu.org>
10310
10311 Improve `doprnt' and its usage. (Bug#8545)
10312 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10313 `format_end'. Remove support for %l as a conversion specifier.
10314 Don't use xrealloc. Improve diagnostics when the %l size modifier
10315 is used. Update the commentary.
10316
10317 * eval.c (verror): Simplify calculation of size_t.
10318
10319 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10320 messages.
10321
f61f41d7
PE
103222011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10323
10324 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10325 change.
10326
96fb4434
PE
103272011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10328
10329 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10330 This makes this file independent of the recent pseudovector change.
10331
671875da 103322011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10333
69e9b5a3
PE
10334 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10335
b5f869a7 10336 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10337 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10338 Remove unused local.
c8926152 10339 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10340
841a1577 10341 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10342 GCC 4.6.0 optimizes based on type-based alias analysis.
10343 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10344 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10345 != &v->size, and therefore "v->size = 1; b->size = 2; return
10346 v->size;" must therefore return 1. This assumption is incorrect
10347 for Emacs, since it type-puns struct Lisp_Vector * with many other
10348 types. To fix this problem, this patch adds a new type struct
f904488f 10349 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10350 and pseudovectors, and helps optimizing compilers not get fooled
10351 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10352 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10353 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10354 the size member.
eab3844f
PE
10355 (XSETPVECTYPE): Rewrite in terms of new macro.
10356 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10357 This is a bit clearer, and further avoids the possibility of
10358 undesirable aliasing.
10359 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10360 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10361 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10362 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10363 (ASIZE): Now uses header.size rather than size.
10364 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10365 to avoid the hassle of writing XVECTOR (foo)->header.size.
10366 (struct vectorlike_header): New type.
eab3844f
PE
10367 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10368 object, to help avoid aliasing.
10369 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10370 (SUBRP): Likewise, since Lisp_Subr is a special case.
10371 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10372 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10373 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10374 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10375 changed to be "header.size" and "header.next".
10376 * buffer.h (struct buffer): Likewise.
10377 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10378 * frame.h (struct frame): Likewise.
10379 * process.h (struct Lisp_Process): Likewise.
10380 * termhooks.h (struct terminal): Likewise.
10381 * window.c (struct save_window_data, struct saved_window): Likewise.
10382 * window.h (struct window): Likewise.
10383 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10384 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10385 * buffer.c (init_buffer_once): Likewise.
10386 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10387 special case.
10388 * process.c (Fformat_network_address): Use local var for size,
10389 for brevity.
10390
0df1eac5
PE
10391 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10392
847ab9d1 10393 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10394 * data.c (atof): Remove decl; no longer used or needed.
10395 (digit_to_number): Move to lread.c.
10396 (Fstring_to_number): Use new string_to_number function, to be
10397 consistent with how the Lisp reader treats infinities and NaNs.
10398 Do not assume that floating-point numbers represent EMACS_INT
10399 without losing information; this is not true on most 64-bit hosts.
10400 Avoid double-rounding errors, by insisting on integers when
10401 parsing non-base-10 numbers, as the documentation specifies.
10402 * lisp.h (string_to_number): New decl, replacing ...
10403 (isfloat_string): Remove.
bc0a5c13 10404 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10405 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10406 appears to have been a coding error. Similarly, do not accept
10407 strings like +-1e0 as floating point numbers. Do not report
10408 overflow for integer overflows unless the base is not 10 which
10409 means we have no simple and reliable way to continue.
10410 Break out the floating-point parsing into a new
10411 function string_to_number, so that Fstring_to_number parses
10412 floating point numbers consistently with the Lisp reader.
04f2d78b 10413 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10414 (E_CHAR, EXP_INT): Remove, replacing with ...
10415 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10416 (string_to_number): New function, replacing isfloat_string.
10417 This function checks for valid syntax and produces the resulting
10418 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10419 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10420 so that overflow for non-base-10 numbers is reported only when
10421 there's no portable and simple way to convert to floating point.
452f4150 10422
67769ffc
PE
10423 * textprop.c (set_text_properties_1): Rewrite for clarity,
10424 and to avoid GCC warning about integer overflow.
10425
c20db43f
PE
10426 * intervals.h (struct interval): Use EMACS_INT for members
10427 where EMACS_UINT might cause problems. See
10428 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10429 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10430 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10431 All uses changed.
37aa2f85
PE
10432 (offset_intervals): Tell GCC not to worry about length overflow
10433 when negating a negative length.
c20db43f 10434
2538aa2f
PE
10435 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10436 (overrun_check_free): Likewise.
10437
f2d3008d
PE
10438 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10439 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10440 word size.
10441
ec8df744
PE
10442 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10443 (gnutls_make_error): Rename local to avoid shadowing.
10444 (gnutls_emacs_global_deinit): ifdef out; not used.
10445 (Fgnutls_boot): Use const for pointer to readonly storage.
10446 Comment out unused local. Fix pointer signedness problems.
10447
640ee02d
PE
10448 * lread.c (openp): Don't stuff size_t into an 'int'.
10449 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10450 about possible signed overflow.
10451
6048fb2a
PE
10452 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10453 (GDK_KEY_g): Don't define if already defined.
10454 (xg_prepare_tooltip): Avoid pointer signedness problem.
10455 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10456
fa3c87e1
PE
10457 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10458 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10459
2172544b
PE
10460 * xfns.c (Fx_window_property): Simplify a bit,
10461 to make a bit faster and to avoid GCC 4.6.0 warning.
10462 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10463
9b821a21
PE
10464 * fns.c (internal_equal): Don't assume size_t fits in int.
10465
3c616cfa
PE
10466 * alloc.c (compact_small_strings): Tighten assertion a little.
10467
c2982e87
PE
10468 Replace pEd with more-general pI, and fix some printf arg casts.
10469 * lisp.h (pI): New macro, generalizing old pEd macro to other
10470 conversion specifiers. For example, use "...%"pI"d..." rather
10471 than "...%"pEd"...".
10472 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10473 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10474 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10475 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10476 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10477 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10478 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10479 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10480 64-bit hosts.
10481 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10482 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10483 * print.c (safe_debug_print, print_object): Likewise.
10484 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10485 to int.
6f04d126
PE
10486 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10487 avoiding the 0 flag, which is not portable.
c2982e87
PE
10488 * process.c (Fmake_network_process): Use pI to avoid cast.
10489 * region-cache.c (pp_cache): Likewise.
10490 * xdisp.c (decode_mode_spec): Likewise.
10491 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10492 behavior on 64-bit hosts with printf arg.
6f04d126 10493 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10494 (x_stop_queuing_selection_requests): Likewise.
10495 (x_get_window_property): Don't truncate byte count to an 'int'
10496 when tracing.
0b432f21 10497
5e073ec7
PE
10498 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10499 here, since it parses constructs like leading '-' and spaces,
10500 which are not wanted; and it overflows with large numbers.
10501 Instead, simply match F[0-9]+, which is what is wanted anyway.
10502
36372bf9
PE
10503 * alloc.c: Remove unportable assumptions about struct layout.
10504 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10505 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10506 (allocate_vectorlike, make_pure_vector): Use the new macros,
10507 plus offsetof, to remove unportable assumptions about struct layout.
10508 These assumptions hold on all porting targets that I know of, but
10509 they are not guaranteed, they're easy to remove, and removing them
10510 makes further changes easier.
10511
0b432f21
PE
10512 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10513 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10514 (string_overrun_cookie): Now const. Use initializers that
10515 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10516 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10517 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10518 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10519 multiple of sizeof (EMACS_INT); it need not be, if
10520 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10521 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10522
895009e1
JB
105232011-04-26 Juanma Barranquero <lekktu@gmail.com>
10524
10525 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10526
6a7a1b0b
TZ
105272011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10528
10529 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10530 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10531 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10532
841a1577 105332011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10534
10535 * lisp.h (Qdebug): List symbol.
895009e1 10536 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10537 * keyboard.c (debug-on-event): New variable.
10538 (handle_user_signal): Break into debugger when debug-on-event
10539 matches the current signal symbol.
10540
f2d3ba6f
DN
105412011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10542
10543 * alloc.c (check_sblock, check_string_bytes)
10544 (check_string_free_list): Convert to standard C.
10545
42ce4c63
TZ
105462011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10547
10548 * w32.c (emacs_gnutls_push): Fix typo.
10549
825cd63c
EZ
105502011-04-25 Eli Zaretskii <eliz@gnu.org>
10551
fb11d64d
EZ
10552 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10553 "cast to pointer from integer of different size".
10554
825cd63c
EZ
10555 Improve doprnt and its use in verror. (Bug#8545)
10556 * doprnt.c (doprnt): Document the set of format control sequences
10557 supported by the function. Use SAFE_ALLOCA instead of always
10558 using `alloca'.
10559
10560 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10561 is one byte too soon. Don't use xrealloc; instead xfree and
10562 xmalloc anew.
10563
e061a11b
TZ
105642011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10565
10566 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10567 callbacks stage.
10568
10569 * gnutls.c: Renamed global_initialized to
10570 gnutls_global_initialized. Added internals for the
10571 :verify-hostname-error, :verify-error, and :verify-flags
10572 parameters of `gnutls-boot' and documented those parameters in the
10573 docstring. Start callback support.
9173deec
JB
10574 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10575 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10576 on error. Return error code.
e061a11b
TZ
10577 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10578 (emacs_gnutls_read): Likewise.
10579 (Fgnutls_boot): Return handshake error code.
10580 (emacs_gnutls_handle_error): New function.
10581 (wsaerror_to_errno): Likewise.
10582
10583 * w32.h (emacs_gnutls_pull): Add prototype.
10584 (emacs_gnutls_push): Likewise.
10585
10586 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10587 (emacs_gnutls_push): Likewise.
10588
105892011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10590
10591 * process.c (wait_reading_process_output): Check if GnuTLS
10592 buffered some data internally if no FDs are set for TLS
10593 connections.
10594
10595 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10596 (LIBS): Link to USER_LIBS.
10597 ($(BLD)/gnutls.$(0)): New target.
10598
fa6996bc
EZ
105992011-04-24 Eli Zaretskii <eliz@gnu.org>
10600
eb35682e
EZ
10601 * xdisp.c (handle_single_display_spec): Rename the
10602 display_replaced_before_p argument into display_replaced_p, to
10603 make it consistent with the commentary. Fix typos in the
10604 commentary.
10605
e2ad650c
EZ
10606 * textprop.c (syms_of_textprop): Remove dead code.
10607 (copy_text_properties): Delete obsolete commentary about an
10608 interface that was deleted long ago. Fix typos in the description
10609 of arguments.
10610
1b2de274
EZ
10611 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10612 to changes in oldXMenu/XMenu.h from 2011-04-16.
10613 <menu_help_message, prev_menu_help_message>: Constify.
10614 (IT_menu_make_room): menu->help_text is now `const char **';
10615 adjust.
10616
10617 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10618 to changes in oldXMenu/XMenu.h from 2011-04-16.
10619 (struct XMenu): Declare `help_text' `const char **'.
10620
10621 * xfaces.c <Qunspecified>: Make extern again.
10622
10623 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10624 required by POSIX.
1b2de274 10625
762b15be
EZ
10626 * doc.c (get_doc_string): Improve the format passed to `error'.
10627
10628 * doprnt.c (doprnt): Improve commentary.
10629
10630 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10631
10632 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10633 them with etags.
10634
f1052e5d
EZ
10635 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10636 changes in globals.h immediately force recompilation.
762b15be
EZ
10637 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10638 $(CURDIR)/s/ms-w32.h.
10639 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10640
fa6996bc
EZ
10641 * character.c (Fchar_direction): Function deleted.
10642 (syms_of_character): Don't defsubr it.
10643 <char-direction-table>: Deleted.
10644
e6c3da20
EZ
106452011-04-23 Eli Zaretskii <eliz@gnu.org>
10646
10647 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10648 * doprnt.c: Include limits.h.
10649 (SIZE_MAX): New macro.
04f2d78b
CB
10650 (doprnt): Return a size_t value. 2nd arg is now size_t.
10651 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10652 Improve overflow protection. Support `l' modifier for integer
10653 conversions. Support %l conversion. Don't assume an EMACS_INT
10654 argument for integer conversions and for %c.
10655
10656 * lisp.h (doprnt): Restore prototype.
10657
10658 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10659 $(SRC)/character.h.
10660
10661 * Makefile.in (base_obj): Add back doprnt.o.
10662
10663 * deps.mk (doprnt.o): Add back prerequisites.
10664 (callint.o): Depend on character.h.
10665
10666 * eval.c (internal_lisp_condition_case): Include the handler
10667 representation in the error message.
10668 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10669 when breaking from the loop.
10670
10671 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10672
10673 * callint.c (Fcall_interactively): When displaying error message
10674 about invalid control letter, pass the character's codepoint, not
10675 a pointer to its multibyte form. Improve display of the character
10676 in octal and display also its hex code.
10677
10678 * character.c (char_string): Use %x to display the (unsigned)
10679 codepoint of an invalid character, to avoid displaying a bogus
10680 negative value.
10681
10682 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10683 `error', not SYMBOL_NAME itself.
10684
10685 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10686 character arguments to `error'.
10687
10688 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10689 to `error' in error message about FINAL_CHAR argument. Make sure
10690 FINAL_CHAR is a character, and use %c when it is passed as
10691 argument to `error'.
10692
4ffd0d6b 106932011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10694
10695 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10696
10697 * w32.c: Include <time.h>.
10698 (sys_localtime): New function.
10699
4ffd0d6b 107002011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10701
10702 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10703
4ffd0d6b 10704 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10705
4ffd0d6b 107062011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10707
4ffd0d6b
GM
10708 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10709 zombies (Bug#8467).
aac0c6e3 10710
04c56954
EZ
107112011-04-19 Eli Zaretskii <eliz@gnu.org>
10712
10713 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10714 gl_state.e_property when gl_state.object is Qt.
10715
10716 * insdel.c (make_gap_larger): Remove limitation of buffer size
10717 to <= INT_MAX.
10718
16a43933
CY
107192011-04-18 Chong Yidong <cyd@stupidchicken.com>
10720
10721 * xdisp.c (lookup_glyphless_char_display)
10722 (produce_glyphless_glyph): Handle cons cell entry in
10723 glyphless-char-display.
10724 (Vglyphless_char_display): Document it.
10725
10726 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10727 glyphless-char-display.
10728
4581706e
CY
107292011-04-17 Chong Yidong <cyd@stupidchicken.com>
10730
10731 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10732
10733 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10734
10735 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10736 definition for no-X builds.
10737
4887c6e2 107382011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10739
fd35b6f9
PE
10740 Static checks with GCC 4.6.0 and non-default toolkits.
10741
5c1ccb01
PE
10742 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10743
006c5daa
PE
10744 * process.c (keyboard_bit_set): Define only if SIGIO.
10745 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10746 (send_process): Repair possible setjmp clobbering.
10747
efc736d3
PE
10748 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10749
4e2fe2e6
PE
10750 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10751
f97334a2
PE
10752 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10753
4e75f29d
PE
10754 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10755 Define only if needed.
10756
90efadd1
PE
10757 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10758 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10759 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10760
3c647824
PE
10761 * dispextern.h (struct redisplay_interface): Rename param
10762 to avoid shadowing.
e264f262 10763 * termhooks.h (struct terminal): Likewise.
761383f4 10764 * xterm.c (xembed_send_message): Likewise.
3c647824 10765
b58c5c4a
PE
10766 * insdel.c (make_gap_smaller): Define only if
10767 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10768
cad59032
PE
10769 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10770 it.
10771
c339dc2e
PE
10772 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10773 so that we aren't warned about unused symbols.
10774
91a3e27b
PE
10775 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10776
399c71d3 10777 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10778
8ffc96f5
PE
10779 * xfns.c (x_real_positions): Mark locals as initialized.
10780
eef9bc79
PE
10781 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10782
098db9dd
PE
10783 * xterm.c: Fix problems found by static analysis with other toolkits.
10784 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10785 (x_dispatch_event): Declare static if USE_GTK, and
10786 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10787 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10788 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10789 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10790 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10791
eb18f6cc
PE
10792 * xmenu.c (menu_help_callback): Pointer type fixes.
10793 Use const pointers when pointing at readonly data. Avoid pointer
10794 signedness clashes.
10795 (FALSE): Remove unused macro.
10796 (update_frame_menubar): Remove unused decl.
10797
1fe72bf8
PE
10798 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10799
60d9e1db
PE
10800 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10801 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10802 (single_menu_item): Rename local to avoid shadowing.
10803
39261c26
PE
10804 * keyboard.c (make_lispy_event): Remove unused local var.
10805
018c5e19
PE
10806 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10807 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10808
63d2b86e
PE
10809 * bitmaps: Change bitmaps from unsigned char back to the X11
10810 compatible char. Avoid the old compiler warnings about
10811 out-of-range initializers by using, for example, '\xab' rather
10812 than 0xab.
10813
aefd87e1
PE
10814 * xgselect.c (xgselect_initialize): Check vs interface
10815 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10816
bf501fb9
PE
10817 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10818
e9829fdf
PE
10819 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10820 to read-only memory.
10821
1086c095
PE
10822 * fns.c (vector): Remove; this old hack is no longer needed.
10823
2baccd04 10824 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10825 Remove unused var.
dde42981 10826 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10827
72391843 10828 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10829
436c16df 10830 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10831 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10832 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10833
92bb796d 10834 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10835 (x_term_init): Remove local to avoid shadowing.
92bb796d 10836
764430a3 10837 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10838
10839 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10840 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10841
d1dfb56c
EZ
108422011-04-16 Eli Zaretskii <eliz@gnu.org>
10843
c4354cb4
EZ
10844 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10845
d1dfb56c
EZ
10846 Fix regex.c, syntax.c and friends for buffers > 2GB.
10847 * syntax.h (struct gl_state_s): Declare character position members
10848 EMACS_INT.
10849
10850 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10851
04f2d78b
CB
10852 * textprop.c (verify_interval_modification, interval_of):
10853 Declare arguments EMACS_INT.
d1dfb56c
EZ
10854
10855 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10856 EMACS_INT.
10857
10858 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10859
10860 * indent.c (Fvertical_motion): Local variable it_start is now
10861 EMACS_INT.
10862
10863 * regex.c (re_match, re_match_2, re_match_2_internal)
10864 (bcmp_translate, regcomp, regexec, print_double_string)
10865 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10866 (re_compile_pattern, re_exec): Declare arguments and local
10867 variables `size_t' and `ssize_t' and return values `regoff_t', as
10868 appropriate.
10869 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10870 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10871 <compile_stack_type>: `size' and `avail' are now `size_t'.
10872
10873 * regex.h <regoff_t>: Use ssize_t, not int.
10874 (re_search, re_search_2, re_match, re_match_2): Arguments that
10875 specify buffer/string position and length are now ssize_t and
10876 size_t. Return type is regoff_t.
10877
613052cd
BK
108782011-04-16 Ben Key <bkey76@gmail.com>
10879
10880 * nsfont.m: Fixed bugs in ns_get_family and
10881 ns_descriptor_to_entity that were caused by using free to
10882 deallocate memory blocks that were allocated by xmalloc (via
10883 xstrdup). This caused Emacs to crash when compiled with
10884 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10885 --enable-checking=xmallocoverrun). xfree is now used to
10886 deallocate these memory blocks.
10887
4170f62f 108882011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10889
71b41406
PE
10890 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10891
9587a89d
PE
10892 emacs_write: Accept and return EMACS_INT for sizes.
10893 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10894 et seq.
10895 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10896 Accept and return EMACS_INT.
10897 (emacs_gnutls_write): Return the number of bytes written on
10898 partial writes.
10899 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10900 (emacs_read, emacs_write): Remove check for negative size, as the
10901 Emacs source code has been audited now.
9587a89d
PE
10902 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10903 (emacs_read, emacs_write): Use it.
273a5f82
PE
10904 * process.c (send_process): Adjust to the new signatures of
10905 emacs_write and emacs_gnutls_write. Do not attempt to store
10906 a byte offset into an 'int'; it might overflow.
9587a89d 10907 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10908
3e047f51
PE
10909 * sound.c: Don't assume sizes fit in 'int'.
10910 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10911 Return EMACS_INT, not int.
3e047f51 10912 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10913 Accept EMACS_INT, not int.
10914 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10915 record read return values.
10916
cc39a9db
BK
109172011-04-15 Ben Key <bkey76@gmail.com>
10918
c9d0ec6d
JB
10919 * keyboard.c (Qundefined): Don't declare static since it is used
10920 in nsfns.m.
10921 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10922 static since they are used in nsfont.m.
cc39a9db 10923
6c60eb9f
SM
109242011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10925
10926 * process.c (Qprocessp): Don't declare static.
10927 * lisp.h (Qprocessp): Declare again.
10928
7990b61a
JB
109292011-04-15 Juanma Barranquero <lekktu@gmail.com>
10930
10931 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10932
5d4cb038
PE
109332011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10934
8bd7b830 10935 Improve C-level modularity by making more things 'static'.
cd64ea1d 10936
e3b27b31
PE
10937 Don't publish debugger-only interfaces to other modules.
10938 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10939 (verify_bytepos, count_markers): Move decls to the only modules
10940 that need them.
10941 * region-cache.h (pp_cache): Likewise.
10942 * window.h (check_all_windows): Likewise.
10943 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10944
5d4cb038
PE
10945 * sysdep.c (croak): Now static, if
10946 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10947 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10948
10949 * alloc.c (refill_memory_reserve): Now static if
10950 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10951 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10952
e87b6180
PE
10953 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10954 Define only if USE_LUCID.
10955
ac64929e
PE
10956 * xrdb.c (x_customization_string, x_rm_string): Now static.
10957
6f37259d
PE
10958 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10959 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10960
1683e3ab
PE
10961 * xdisp.c (draw_row_with_mouse_face): Now static.
10962 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10963
de9c2632
PE
10964 * window.h (check_all_windows): Mark externally visible.
10965
2b96acb7
PE
10966 * window.c (window_deletion_count): Now static.
10967
10968 * undo.c: Make symbols static if they're not exported.
10969 (last_undo_buffer, last_boundary_position, pending_boundary):
10970 Now static.
10971
50436f33
PE
10972 * textprop.c (interval_insert_behind_hooks): Now static.
10973 (interval_insert_in_front_hooks): Likewise.
10974
64520e5c
PE
10975 * term.c: Make symbols static if they're not exported.
10976 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10977 (max_frame_lines, tty_set_terminal_modes):
10978 (tty_reset_terminal_modes, tty_turn_off_highlight):
10979 (get_tty_terminal): Now static.
10980 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10981 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10982 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10983 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10984 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10985
1fa53021
PE
10986 * sysdep.c: Make symbols static if they're not exported.
10987 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10988 Now static.
10989 (sigprocmask_set, full_mask): Remove; unused.
10990 (wait_debugging): Mark as visible.
10991 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10992 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10993
d4b43b22
PE
10994 * syntax.c (syntax_temp): Define only if !__GNUC__.
10995
b7c513d0
PE
10996 * sound.c (current_sound_device, current_sound): Now static.
10997
989b29ad
PE
10998 * search.c (searchbufs, searchbuf_head): Now static.
10999
13a55a78
PE
11000 * scroll.c (scroll_cost): Remove; unused.
11001 * dispextern.h (scroll_cost): Remove decl.
11002
de68a1fc
PE
11003 * region-cache.h (pp_cache): Mark as externally visible.
11004
40ccffa6
PE
11005 * process.c: Make symbols static if they're not exported.
11006 (process_tick, update_tick, create_process, chan_process):
11007 (Vprocess_alist, proc_buffered_char, datagram_access):
11008 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11009 (deactivate_process): Mark defn as static, as well as decl.
11010 * lisp.h (create_process): Remove decl.
11011 * process.h (chan_process, Vprocess_alist): Remove decls.
11012
ad64fc97
PE
11013 * print.c: Make symbols static if they're not exported.
11014 (print_depth, new_backquote_output, being_printed, print_buffer):
11015 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11016 (print_interval, print_number_index, initial_stderr_stream):
11017 Now static.
11018 * lisp.h (Fprinc): Remove decl.
11019 (debug_output_compilation_hack): Mark as externally visible.
11020
adddb265
PE
11021 * sysdep.c (croak): Move decl from here to syssignal.h.
11022 * syssignal.h (croak): Put it here, so the API can be checked when
11023 'croak' is called from dissociate_if_controlling_tty.
11024
1717ede2
PE
11025 * minibuf.c: Make symbols static if they're not exported.
11026 (minibuf_save_list, choose_minibuf_frame): Now static.
11027 * lisp.h (choose_minibuf_frame): Remove decl.
11028
fa5fb2bc
PE
11029 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11030
1e3890d1
PE
11031 * lread.c: Make symbols static if they're not exported.
11032 (read_objects, initial_obarray, oblookup_last_bucket_number):
11033 Now static.
11034 (make_symbol): Remove; unused.
11035 * lisp.h (initial_obarray, make_symbol): Remove decls.
11036
8a1414fa
PE
11037 * keyboard.c: Make symbols static if they're not exported.
11038 (single_kboard, recent_keys_index, total_keys, recent_keys):
11039 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11040 (this_single_command_key_start, echoing, last_auto_save):
11041 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11042 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11043 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11044 (Vlispy_mouse_stem, double_click_count):
11045 Now static.
11046 (force_auto_save_soon): Define only if SIGDANGER.
11047 (ignore_mouse_drag_p): Now static if
11048 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11049 (print_help): Remove; unused.
11050 (stop_character, last_timer_event): Mark as externally visible.
11051 * keyboard.h (ignore_mouse_drag_p): Declare only if
11052 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11053 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11054 * lisp.h (echoing): Remove decl.
11055 (force_auto_save_soon): Declare only if SIGDANGER.
11056 * xdisp.c (redisplay_window): Simplify code, to make it more
11057 obvious that ignore_mouse_drag_p is not accessed if !defined
11058 USE_GTK && !defined HAVE_NS.
11059
93ea6e8f
PE
11060 * intervals.c: Make symbols static if they're not exported.
11061 (merge_properties_sticky, merge_interval_right, delete_interval):
11062 Now static.
11063 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11064
77382fcc
PE
11065 * insdel.c: Make symbols static if they're not exported.
11066 However, leave prepare_to_modify_buffer alone. It's never
11067 called from outside this function, but that appears to be a bug.
11068 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11069 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11070 (adjust_after_replace_noundo): Remove; unused.
11071 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11072 (signal_before_change): Remove decls.
77382fcc 11073
9306c32e
PE
11074 * indent.c (val_compute_motion, val_vmotion): Now static.
11075
cd44d2eb
PE
11076 * image.c: Make symbols static if they're not exported.
11077 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11078 if USE_GTK.
11079 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11080 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11081
ad9a7a06
PE
11082 * fringe.c (standard_bitmaps): Now static.
11083 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11084
81626931
PE
11085 * frame.c: Make symbols static if they're not exported.
11086 (x_report_frame_params, make_terminal_frame): Now static.
11087 (get_frame_param): Now static, unless HAVE_NS.
11088 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11089 (x_get_resource_string): Remove; not used.
11090 * frame.h (make_terminal_frame, x_report_frame_params):
11091 (x_get_resource_string); Remove decls.
11092 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11093 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11094
239f9db9
PE
11095 * font.c, fontset.c: Make symbols static if they're not exported.
11096 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11097 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11098 * font.c (font_close_object): Now static.
11099 * font.h (font_close_object): Remove.
11100 * fontset.c (FONTSET_OBJLIST): Remove.
11101 (free_realized_fontset) #if-0 the body, which does nothing.
11102 (face_suitable_for_char_p): #if-0, as it's never called.
11103 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11104 * xfaces.c (face_at_string_position):
11105 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11106 since 0 is always ASCII.
11107
dfcf3579
PE
11108 * fns.c (weak_hash_tables): Now static.
11109
5045092b
PE
11110 * fileio.c: Make symbols static if they're not exported.
11111 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11112 (Vwrite_region_annotation_buffers): Now static.
11113
57a96f5c
PE
11114 * eval.c: Make symbols static if they're not exported.
11115 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11116 * lisp.h (backtrace_list): Remove decl.
11117
35f08c38
PE
11118 * emacs.c: Make symbols static if they're not exported.
11119 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11120 (fatal_error_code, fatal_error_signal_hook, standard_args):
11121 Now static.
11122 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11123 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11124 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11125 * lisp.h (fatal_error_signal_hook): Remove decl.
11126 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11127
f44bd759
PE
11128 * editfns.c: Move a (normally-unused) function to its only use.
11129 * editfns.c, lisp.h (get_operating_system_release): Remove.
11130 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11131 worth the hassle of breaking this out.
11132
b532497d
PE
11133 * xterm.c: Make symbols static if they're not exported.
11134 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11135 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11136 (x_destroy_window, x_delete_display):
11137 Now static.
11138 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11139 (x_mouse_leave): Remove; unused.
11140 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11141 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11142 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11143 Remove decls.
11144 (x_mouse_leave): Declare only if WINDOWSNT.
11145 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11146 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11147 USE_X_TOOLKIT.
11148
1675728f
PE
11149 * ftxfont.c: Make symbols static if they're not exported.
11150 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11151 HAVE_FREETYPE.
11152 * font.h (ftxfont_driver): Likewise.
11153
e4cebfca
PE
11154 * xfns.c: Make symbols static if they're not exported.
11155 (x_last_font_name, x_display_info_for_name):
11156 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11157 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11158 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11159 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11160 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11161 (last_show_tip_args): Now static.
11162 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11163 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11164 (x_screen_planes): Remove; unused.
11165 * dispextern.h (x_screen_planes): Remove decl.
11166
5bf46f05
PE
11167 * dispnew.c: Make symbols static if they're not exported.
11168 * dispextern.h (redraw_garbaged_frames, scrolling):
11169 (increment_row_positions): Remove.
11170 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11171 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11172 Now static.
11173 (redraw_garbaged_frames): Remove; unused.
11174
435f4c28
PE
11175 * xfaces.c: Make symbols static if they're not exported.
11176 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11177 Remove decls.
11178 * xterm.h (defined_color): Remove decls.
11179 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11180 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11181 (menu_face_changed_default, defined_color, free_realized_face):
11182 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11183 (ascii_face_of_lisp_face): Remove; unused.
11184
8524aef3
PE
11185 * xdisp.c: Make symbols static if they're not exported.
11186 * dispextern.h (scratch_glyph_row, window_box_edges):
11187 (glyph_to_pixel_coords, set_cursor_from_row):
11188 (get_next_display_element, set_iterator_to_next):
11189 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11190 (show_mouse_face): Remove decls
11191 * frame.h (message_buf_print): Likewise.
11192 * lisp.h (pop_message, set_message, check_point_in_composition):
11193 Likewise.
11194 * xterm.h (set_vertical_scroll_bar): Likewise.
11195 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11196 (message_buf_print, scratch_glyph_row, displayed_buffer):
11197 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11198 (get_next_display_element, show_mouse_face, window_box_edges):
11199 (frame_to_window_pixel_xy, check_point_in_composition):
11200 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11201 (glyph_to_pixel_coords): Remove; unused.
11202
16390cd2
PE
11203 * dired.c (file_name_completion): Now static.
11204
11205 * dbusbind.c (xd_in_read_queued_messages): Now static.
11206
a25f4dfa
PE
11207 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11208 * data.c (circular_list_error): Remove.
11209
14a9c8df
PE
11210 * commands.h (last_point_position, last_point_position_buffer):
11211 (last_point_position_window): Remove decls.
11212 * keyboard.c: Make these variables static.
11213
04f2d78b
CB
11214 * coding.h (coding, code_convert_region, encode_coding_gap):
11215 Remove decls.
74ab6df5
PE
11216 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11217 (iso_code_class, detect_coding, code_convert_region): Now static.
11218 (encode_coding_gap): Remove; unused.
11219
38dfbee1
PE
11220 * chartab.c (chartab_chars, chartab_bits): Now static.
11221
a2cb4e63
PE
11222 * charset.h (charset_iso_8859_1): Remove decl.
11223 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11224 Now static.
11225
127198fd
PE
11226 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11227 * ccl.c (Vccl_program_table): Now static.
11228 (check_ccl_update): Remove; unused.
11229
d85b608f
PE
11230 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11231 * category.h: ... from here.
11232 * category.c (check_category_table, set_category_set): Now static.
11233
31cd66f3
PE
11234 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11235 * lisp.h: Remove these decls.
11236
c358e587
PE
11237 * buffer.c (buffer_count): Remove unused var.
11238
e78aecca
PE
11239 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11240 so that it's not optimized away.
11241 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11242 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11243 exported only to the debugger.
11244
e192d7d3 11245 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11246 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11247
92470028
PE
11248 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11249 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11250 was inaccessible from Lisp.
11251 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11252 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11253
244ed907
PE
11254 alloc.c: Import and export fewer symbols, and remove unused items.
11255 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11256 is defined.
11257 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11258 it's not optimized away by whole-program optimization.
11259 (message_enable_multibyte, free_misc): Remove.
11260 (catchlist, handlerlist, mark_backtrace):
11261 Declare only if BYTE_MARK_STACK.
11262 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11263 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11264 (message_enable_multibyte): Remove decl.
11265 (free_misc, interval_free_list, float_block, float_block_index):
11266 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11267 (cons_free_list, last_marked_index):
11268 Now static.
11269 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11270 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11271 (mark_backtrace): Define only if BYTE_MARK_STACK.
11272 * xdisp.c (message_enable_multibyte): Now static.
11273
61c2b50e 11274 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11275 This makes it easier for human readers (and static analyzers)
11276 to see whether these variables are used from other modules.
11277 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11278 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11279 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11280 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11281 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11282 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11283 * xmenu.c, xselect.c:
11284 Declare Q* vars static if they are not used in other modules.
11285 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11286 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11287 Remove decls of unexported vars.
11288 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11289
95c82688
PE
11290 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11291
16a97296
PE
11292 Make Emacs functions such as Fatom 'static' by default.
11293 This makes it easier for human readers (and static analyzers)
11294 to see whether these functions can be called from other modules.
11295 DEFUN now defines a static function. To make the function external
11296 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11297 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11298 (Finit_image_library):
16a97296
PE
11299 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11300 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11301 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11302 Remove decls, since these functions are now static.
11303 (Funintern, Fget_internal_run_time): New decls, since these functions
11304 were already external.
95c82688 11305
16a97296
PE
11306 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11307 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11308 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11309 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11310 * keyboard.c, keymap.c, lread.c:
11311 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11312 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11313 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11314 Mark functions with DEFUE instead of DEFUN,
11315 if they are used in other modules.
11316 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11317 decls for now-static functions.
11318 * buffer.h (Fdelete_overlay): Remove decl.
11319 * callproc.c (Fgetenv_internal): Mark as internal.
11320 * composite.c (Fremove_list_of_text_properties): Remove decl.
11321 (Fcomposition_get_gstring): New forward static decl.
11322 * composite.h (Fcomposite_get_gstring): Remove decl.
11323 * dired.c (Ffile_attributes): New forward static decl.
11324 * doc.c (Fdocumntation_property): New forward static decl.
11325 * eval.c (Ffetch_bytecode): New forward static decl.
11326 (Funintern): Remove extern decl; now in .h file where it belongs.
11327 * fileio.c (Fmake_symbolic_link): New forward static decl.
11328 * image.c (Finit_image_library): New forward static decl.
11329 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11330 * intervals.h (Fprevious_property_change):
11331 (Fremove_list_of_text_properties): Remove decls.
11332 * keyboard.c (Fthis_command_keys): Remove decl.
11333 (Fcommand_execute): New forward static decl.
11334 * keymap.c (Flookup_key): New forward static decl.
11335 (Fcopy_keymap): Now static.
11336 * keymap.h (Flookup_key): Remove decl.
11337 * process.c (Fget_process): New forward static decl.
11338 (Fprocess_datagram_address): Mark as internal.
11339 * syntax.c (Fsyntax_table_p): New forward static decl.
11340 (skip_chars): Remove duplicate decl.
11341 * textprop.c (Fprevious_property_change): New forward static decl.
11342 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11343 Now internal.
11344 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11345 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11346
785bbd42
PE
11347 * editfns.c (Fformat): Remove unreachable code.
11348
8b913b57
AS
113492011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11350
11351 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11352 change. (Bug#8496)
11353
a6744a35
EZ
113542011-04-13 Eli Zaretskii <eliz@gnu.org>
11355
11356 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11357 when at ZV. (Bug#8487)
11358
e7974947
AS
113592011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11360
baad03f0
AS
11361 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11362 (Bug#8437)
11363 * keyboard.c (parse_tool_bar_item): Likewise.
11364 * sound.c (sound_cleanup, alsa_close): Likewise.
11365 * termcap.c (tgetent): Likewise.
11366 * xfns.c (x_default_font_parameter): Likewise.
11367 * xsettings.c (read_and_apply_settings): Likewise.
11368
e7974947
AS
11369 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11370 (overrun_check_free): Protoize.
11371
28272684
PE
113722011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11373
11374 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11375 since callers should never pass a negative size.
11376 Change the signature to match that of plain 'read' and 'write'; see
11377 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11378 * lisp.h: Update prototypes of emacs_write and emacs_read.
11379
11997c76
EZ
113802011-04-11 Eli Zaretskii <eliz@gnu.org>
11381
11382 * xdisp.c (redisplay_window): Don't try to determine the character
11383 position of the scroll margin if the window start point w->startp
e896f03c 11384 is outside the buffer's accessible region. (Bug#8468)
11997c76 11385
8a2cbd72
EZ
113862011-04-10 Eli Zaretskii <eliz@gnu.org>
11387
11388 Fix write-region and its subroutines for buffers > 2GB.
11389 * fileio.c (a_write, e_write): Modify declaration of arguments and
11390 local variables to support buffers larger than 2GB.
11391 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11392
11393 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11394 argument, local variables, and return value.
11395
11396 * lisp.h: Update prototypes of emacs_write and emacs_read.
11397
11398 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11399
4073e537 114002011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11401
1ebfdcb6
PE
11402 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11403
b2ded58d
PE
11404 Fix more problems found by GCC 4.6.0's static checks.
11405
7d66342c
PE
11406 * xdisp.c (vmessage): Use a better test for character truncation.
11407
bbf47d44
PE
11408 * charset.c (load_charset_map): <, not <=, for optimization,
11409 and to avoid potential problems with integer overflow.
9248994d 11410 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11411 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11412 * editfns.c (Fformat): Likewise.
1e69125e 11413 * syntax.c (skip_chars): Likewise.
3befa583 11414
e3019616
PE
11415 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11416 This also lets GCC 4.6.0 generate slightly better loop code.
11417
becfa255
PE
11418 * callint.c (Fcall_interactively): <, not <=, for optimization.
11419 (Fcall_interactively): Count the number of arguments produced,
11420 not the number of arguments given. This is simpler and lets GCC
11421 4.6.0 generate slightly better code.
11422
dae0cd48
PE
11423 * ftfont.c: Distingish more carefully between FcChar8 and char.
11424 The previous code passed unsigned char * to a functions like
11425 strlen and xstrcasecmp that expect char *, which does not
11426 conform to the C standard.
11427 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11428 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11429 char * when the C standard requires it.
11430
76032d70
PE
11431 * keyboard.c (read_char): Remove unused var.
11432
eb3f1cc8
PE
11433 * eval.c: Port to Windows vsnprintf (Bug#8435).
11434 Include <limits.h>.
11435 (SIZE_MAX): Define if the headers do not.
11436 (verror): Do not give up if vsnprintf returns a negative count.
11437 Instead, grow the buffer. This ports to Windows vsnprintf, which
11438 does not conform to C99. Problem reported by Eli Zaretskii.
11439 Also, simplify the allocation scheme, by avoiding the need for
11440 calling realloc, and removing the ALLOCATED variable.
11441
70476b54
PE
11442 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11443
12020a9e
PE
11444 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11445 But keep the doprint source code for now, as we might revamp it
11446 and use it again (Bug#8435).
ea6c7ae6
PE
11447 * lisp.h (doprnt): Remove.
11448 * Makefile.in (base_obj): Remove doprnt.o.
11449 * deps.mk (doprnt.o): Remove.
11450
5fdb398c
PE
11451 error: Print 32- and 64-bit integers portably (Bug#8435).
11452 Without this change, on typical 64-bit hosts error ("...%d...", N)
11453 was used to print both 32- and 64-bit integers N, which relied on
11454 undefined behavior.
61bdb816 11455 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11456 * lisp.h (error, verror): Mark as printf-like functions.
11457 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11458 Report overflow in size calculations when allocating printf buffer.
11459 Do not truncate output string at its first null byte.
11460 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11461 Truncate the output at a character boundary, since vsnprintf does not
11462 do that.
11463 * charset.c (check_iso_charset_parameter): Convert internal
11464 character to string before calling 'error', since %c now has the
11465 printf meaning.
11466 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11467 overflow when computing char to be passed to 'error'. Do not
11468 pass Lisp_Object to 'error'; pass the integer instead.
11469 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11470 formatted with plain %d.
11471
b189fa66
PE
11472 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11473
bff87ef0
PE
11474 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11475
7e2cac20
PE
11476 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11477
ce4d90b5
PE
11478 * xterm.c (x_catch_errors): Remove duplicate declaration.
11479
266c9547
PE
11480 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11481
79c49ad2
PE
11482 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11483
368f4090
JM
114842011-04-10 Jim Meyering <meyering@redhat.com>
11485
11486 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11487 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11488 return ssize_t not "int", and use size_t as the buffer length.
11489 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11490 * gnutls.h: Update declarations.
11491 * process.c (read_process_output): Use ssize_t, to match.
11492 (send_process): Likewise.
11493
a32d4040
CY
114942011-04-09 Chong Yidong <cyd@stupidchicken.com>
11495
11496 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11497
8546720e 114982011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11499
04f2d78b
CB
11500 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11501 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11502
8546720e
GM
11503 * xterm.c (handle_one_xevent):
11504 * xmenu.c (create_and_show_popup_menu):
11505 * xselect.c (x_decline_selection_request)
11506 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11507
0a2f5c1a 115082011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11509
11510 Fix some uses of `int' instead of EMACS_INT.
11511 * search.c (string_match_1, fast_string_match)
11512 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11513 (scan_buffer, find_next_newline_no_quit)
11514 (find_before_next_newline, search_command, Freplace_match)
11515 (Fmatch_data): Make some `int' variables be EMACS_INT.
11516
11517 * xdisp.c (display_count_lines): 3rd argument and return value now
11518 EMACS_INT. All callers changed.
11519 (pint2hrstr): Last argument is now EMACS_INT.
11520
11521 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11522 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11523 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11524 (decode_coding_utf_16, decode_coding_emacs_mule)
11525 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11526 (decode_coding_ccl, decode_coding_charset)
11527 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11528 (decode_coding_iso_2022, decode_coding_emacs_mule)
11529 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11530 <char_offset, last_offset>: Declare EMACS_INT.
11531 (encode_coding_utf_8, encode_coding_utf_16)
11532 (encode_coding_emacs_mule, encode_invocation_designation)
11533 (encode_designation_at_bol, encode_coding_iso_2022)
11534 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11535 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11536 Declare EMACS_INT.
11537 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11538 (encode_invocation_designation): Last argument P_NCHARS is now
11539 EMACS_INT.
11540 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11541 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11542
11543 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11544 All users changed.
11545
11546 * ccl.c (Fccl_execute_on_string): Declare some variables
11547 EMACS_INT.
11548
8546720e 115492011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11550
11551 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11552
4e19a977
CS
115532011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11554
11555 * process.c (Fformat_network_address): Doc fix.
11556
87302331
R
115572011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11558
ee7683eb 11559 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11560
cbb59342
CY
115612011-04-08 Chong Yidong <cyd@stupidchicken.com>
11562
11563 * keyboard.c (read_char): Call Lisp function help-form-show,
11564 instead of using internal_with_output_to_temp_buffer.
11565 (Qhelp_form_show): New var.
e0d38eeb 11566 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11567
11568 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11569
11570 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11571
e67a13ab
CY
115722011-04-06 Chong Yidong <cyd@stupidchicken.com>
11573
04f2d78b
CB
11574 * process.c (Flist_processes): Remove to Lisp.
11575 (list_processes_1): Delete.
e67a13ab 11576
973f782d
EZ
115772011-04-06 Eli Zaretskii <eliz@gnu.org>
11578
7c106b1e
EZ
11579 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11580
973f782d
EZ
11581 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11582
41cf7d1a 115832011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11584
ca23cc88
PE
11585 Fix more problems found by GCC 4.6.0's static checks.
11586
f390e2d5
PE
11587 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11588
42eea0d0
PE
11589 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11590
b69769da 11591 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11592
f9541e84
PE
11593 * xdisp.c (vmessage): Mark as a printf-like function.
11594
13841b55
PE
11595 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11596
c136c10f
PE
11597 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11598
5e2d4a30
PE
11599 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11600 printf-like functions.
11601 (tiff_load): Add casts to remove these marks before passing them
11602 to system-supplied API.
11603
583f48b9
PE
11604 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11605
b25d760e
PE
11606 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11607 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11608 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11609 directly, rather than having caller test rule sign. This avoids
11610 some unnecessary tests.
11611 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11612 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11613 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11614
bc7b6697 11615 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11616 (xfont_open): Avoid unnecessary tests.
bc7b6697 11617
27ccc379
PE
11618 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11619
dcd5c89a
PE
11620 * composite.h, composite.c (composition_gstring_put_cache):
11621 Use EMACS_INT, not int, for length.
11622
b13a45c6
PE
11623 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11624 breaking out part of COMPOSITION_DECODE_RULE.
11625 (COMPOSITION_DECODE_RULE): Use it.
11626 * composite.c (get_composition_id): Remove unused local vars,
11627 by using the new macro.
11628
1e792e4d
PE
11629 * textprop.c (set_text_properties_1): Change while to do-while,
11630 since the condition is always true at first.
11631
dc6c6455 11632 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11633 (interval_deletion_adjustment): Return unsigned value.
11634 All uses changed.
dc6c6455 11635
aba7731a
PE
11636 * process.c (list_processes_1, create_pty, read_process_output):
11637 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11638 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11639 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11640 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11641 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11642
fdfc4bf3
PE
11643 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11644
fca8fe46 11645 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11646 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11647
06a0259a 11648 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11649 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11650 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11651
e7b9e80f
PE
11652 * print.c (print_error_message): Avoid int overflow.
11653
56201685
PE
11654 * font.c (font_list_entities): Redo for clarity,
11655 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11656
78834453 11657 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11658 (font_score): Avoid potential overflow in diff calculation.
78834453 11659
0bc0b309 11660 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11661 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11662
e610eaca
PE
11663 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11664
b895abce
PE
11665 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11666 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11667 can always succeed if overflow has undefined behavior.
11668
1f1d9321 11669 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11670 (wordify): Omit three unnecessary tests.
1f1d9321 11671
c59478bc
PE
11672 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11673 All callers changed. This avoids the need for an unused var.
11674
79b73827
PE
11675 * casefiddle.c (casify_region): Remove var that is set but not used.
11676
a4db5dfe
PE
11677 * dired.c (file_name_completion): Remove var that is set but not used.
11678
43aae36e
PE
11679 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11680
2a47c44d 11681 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11682 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11683
a37c69bf
PE
11684 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11685 Check for integer overflow on size calculations.
11686
328ab8e7
PE
11687 * buffer.c (Fprevious_overlay_change): Remove var that is set
11688 but not used.
11689
e5a2a5cb
PE
11690 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11691 Remove vars that are set but not used.
8d84a6eb 11692 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11693 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11694
a60e5f68
PE
11695 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11696
f661cb61 11697 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11698 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11699
f0397f5a
PE
11700 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11701 that are set but not used.
11702
8664db06 11703 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11704 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11705
6abdaa4a
PE
11706 * xselect.c (x_get_local_selection, x_handle_property_notify):
11707 Remove vars that are set but not used.
11708
0ce7538d 11709 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11710 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11711
9ae848fc
PE
11712 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11713 Remove var that is set but not used.
0b918413
PE
11714 (scroll_bar_windows_size): Now size_t, not int.
11715 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11716 Check for overflow.
9ae848fc 11717
a5a62657
PE
11718 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11719 (map_tty_color) [!defined MSDOS]: Likewise.
11720
5c5cdd39
PE
11721 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11722
66ebf983
PE
11723 * coding.c: Remove vars that are set but not used.
11724 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11725 All callers changed.
11726 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11727 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11728 (decode_coding_charset): Remove vars that are set but not used.
11729
1be4d761
PE
11730 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11731 that is set but not used.
11732
47553fa8
PE
11733 * print.c (print_object): Remove var that is set but not used.
11734
1f7196bf 11735 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11736 The gnulib version avoids calling malloc in the usual case,
11737 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11738 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11739 * filelock.c (current_lock_owner): Likewise.
11740 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11741 * sysdep.c: Include allocator.h, careadlinkat.h.
11742 (emacs_no_realloc_allocator): New static constant.
11743 (emacs_readlink): New function.
fdb61804
PE
11744 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11745 ../lib/careadlinkat.h.
d1fdcab7 11746
f84c17c7
SM
117472011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11748
11749 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11750 first non-nil return value).
11751
ef3862ad
JD
117522011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11753
11754 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11755 if not defined (Bug#8403).
11756
376a7006
JB
117572011-04-02 Juanma Barranquero <lekktu@gmail.com>
11758
11759 * xdisp.c (display_count_lines): Remove parameter `start',
11760 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11761 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11762 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11763 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11764 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11765 and thereabouts. All callers changed.
11766 (get_per_char_metric): Remove parameter `f', unused since
11767 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11768
6ca3801d
JM
117692011-04-02 Jim Meyering <meyering@redhat.com>
11770
11771 do not dereference NULL upon failed strdup
11772 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11773 (ns_get_family): Likewise.
11774
d8e2b5ba
JB
117752011-04-02 Juanma Barranquero <lekktu@gmail.com>
11776
11777 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11778
8c74fcbd
JD
117792011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11780
11781 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11782 later (Bug#8403).
11783
7200d79c
SM
117842011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11785
03408648 11786 Add lexical binding.
7200d79c 11787
03408648
SM
11788 * window.c (Ftemp_output_buffer_show): New fun.
11789 (Fsave_window_excursion):
11790 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11791
11792 * lread.c (lisp_file_lexically_bound_p): New function.
11793 (Fload): Bind Qlexical_binding.
11794 (readevalloop): Remove `evalfun' arg.
11795 Bind Qinternal_interpreter_environment.
11796 (Feval_buffer): Bind Qlexical_binding.
11797 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11798 Mark as dynamic.
11799 (syms_of_lread): Declare `lexical-binding'.
11800
11801 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11802
11803 * keyboard.c (eval_dyn): New fun.
11804 (menu_item_eval_property): Use it.
ca105506
SM
11805
11806 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11807
03408648
SM
11808 * fns.c (concat, mapcar1): Accept byte-code-functions.
11809
11810 * eval.c (Fsetq): Handle lexical vars.
11811 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11812 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11813 (FletX, Flet): Obey lexical binding.
11814 (Fcommandp): Handle closures.
11815 (Feval): New `lexical' arg.
11816 (eval_sub): New function extracted from Feval. Use it almost
11817 everywhere where Feval was used. Look up vars in lexical env.
11818 Handle closures.
11819 (Ffunctionp): Move from subr.el.
11820 (Ffuncall): Handle closures.
11821 (apply_lambda): Remove `eval_flags'.
11822 (funcall_lambda): Handle closures and new byte-code-functions.
11823 (Fspecial_variable_p): New function.
11824 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11825 but without exporting it to Lisp.
23aba0ea 11826
23aba0ea 11827 * doc.c (Fdocumentation, store_function_docstring):
03408648 11828 * data.c (Finteractive_form): Handle closures.
23aba0ea 11829
03408648
SM
11830 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11831 interactive spec.
ba83908c 11832
04f2d78b
CB
11833 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11834 New byte-codes.
03408648
SM
11835 (exec_byte_code): New function extracted from Fbyte_code to handle new
11836 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11837
03408648 11838 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11839
03408648 11840 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11841
e2abce01
JB
118422011-03-31 Juanma Barranquero <lekktu@gmail.com>
11843
11844 * xdisp.c (redisplay_internal): Fix prototype.
11845
63696a73 118462011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11847
63696a73 11848 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11849 (try_scrolling): Use it when setting scroll_limit.
11850 Limit scrolling to 100 screen lines.
63696a73
EZ
11851 (redisplay_window): Even when falling back on "recentering",
11852 position point in the window according to scroll-conservatively,
11853 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11854
11855 (try_scrolling): When point is above the window, allow searching
11856 as far as scroll_max, or one screenful, to compute vertical
11857 distance from PT to the scroll margin position. This prevents
11858 try_scrolling from unnecessarily failing when
11859 scroll-conservatively is set to a value slightly larger than the
11860 window height. Clean up the case of PT below the margin at bottom
11861 of window: scroll_max can no longer be INT_MAX. When aggressive
11862 scrolling is in use, don't let point enter the opposite scroll
11863 margin as result of the scroll.
11864 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11865 threshold of 100 lines for never-recentering scrolling.
11866
e4cc2dfc
JB
118672011-03-31 Juanma Barranquero <lekktu@gmail.com>
11868
11869 * dispextern.h (move_it_by_lines):
11870 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11871 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11872 (message_log_check_duplicate): Remove parameters `prev_bol' and
11873 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11874 (redisplay_internal): Remove parameter `preserve_echo_area',
11875 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11876
11877 * indent.c (Fvertical_motion):
11878 * window.c (window_scroll_pixel_based, Frecenter):
11879 Don't pass `need_y_p' to `move_it_by_lines'.
11880
1c470562
SM
118812011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11882
44f230aa
SM
11883 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11884 steal a few bits to be more compact.
11885 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11886 Remove unneeded casts.
11887
1c470562
SM
11888 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11889
888adce9
ZK
118902011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11891
11892 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11893 binding" message (bug#7967).
11894
f838ed7b
PE
118952011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11896
77861b95
PE
11897 Fix more problems found by GCC 4.6.0's static checks.
11898
de6dbc14
PE
11899 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11900 Remove unused local var.
11901
f838ed7b
PE
11902 * editfns.c (Fmessage_box): Remove unused local var.
11903
792c7b2b
PE
11904 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11905 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11906 Omit unused local vars.
c499e557 11907 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11908 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11909 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11910 Omit unused local var.
11911
ba0165e1
PE
11912 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11913 Don't assume string length fits in int.
32ad8845 11914 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11915 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11916
3c59b4c9
PE
11917 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11918 instead of alloca (Bug#8344).
11919
a3eed478 11920 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11921 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11922
eb4d412d
PE
11923 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11924
1658b401
PE
11925 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11926 concerns.
11927
11928 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11929
11930 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11931
9a2c6e05
PE
11932 * keyboard.c (syms_of_keyboard): Use the same style as later
11933 in this function when indexing through an array. This also
11934 works around GCC bug 48267.
11935
03d0a109
PE
11936 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11937
44f730c8
PE
11938 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11939
fe75f926
PE
11940 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11941 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11942
ffa8c828
PE
11943 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11944 This avoids undefined behavior on integer overflow, and is a bit
11945 more convenient anyway since it is compared to a size_t variable.
11946
c5101a77
PE
11947 Variadic C functions now count arguments with size_t, not int.
11948 This avoids an unnecessary limitation on 64-bit machines, which
11949 caused (substring ...) to crash on large vectors (Bug#8344).
11950 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11951 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11952 All variadic functions and their callers changed accordingly.
c5101a77
PE
11953 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11954 * data.c (arith_driver, float_arith_driver): Likewise.
11955 * editfns.c (general_insert_function): Likewise.
11956 * eval.c (struct backtrace.nargs, interactive_p)
11957 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11958 (funcall_lambda, mark_backtrace): Likewise.
11959 * fns.c (concat): Likewise.
11960 * frame.c (x_set_frame_parameters): Likewise.
11961 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11962 0 if not found, not -1. All callers changed.
11963
dd3f25f7
PE
11964 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11965 (stack_copy_size): Now size_t, not int.
11966 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11967
461c2ab9
JB
119682011-03-28 Juanma Barranquero <lekktu@gmail.com>
11969
11970 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11971 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11972 All callers changed.
11973
11974 * lisp.h (multibyte_char_to_unibyte):
11975 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11976 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11977 * character.h (CHAR_TO_BYTE8):
11978 * cmds.c (internal_self_insert):
11979 * editfns.c (general_insert_function):
11980 * keymap.c (push_key_description):
11981 * search.c (Freplace_match):
11982 * xdisp.c (message_dolog, set_message_1): All callers changed.
11983
f6d62986
SM
119842011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11985
11986 * keyboard.c (safe_run_hook_funcall): New function.
11987 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11988 don't set the hook to nil, but remove the offending function instead.
11989 (Qcommand_hook_internal): Remove, unused.
11990 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11991 Vcommand_hook_internal.
11992
11993 * eval.c (enum run_hooks_condition): Remove.
11994 (funcall_nil, funcall_not): New functions.
11995 (run_hook_with_args): Call each function through a `funcall' argument.
11996 Remove `cond' argument, now redundant.
11997 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11998 (Frun_hook_with_args_until_failure): Adjust accordingly.
11999 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12000
1db5b1ad
JB
120012011-03-28 Juanma Barranquero <lekktu@gmail.com>
12002
12003 * dispextern.h (string_buffer_position): Remove declaration.
12004
12005 * print.c (strout): Remove parameter `multibyte', unused since
12006 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12007
12008 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12009 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12010 All callers changed.
12011
12012 * w32.c (_wsa_errlist): Use braces for struct initializers.
12013
12014 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12015 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12016 All callers changed.
12017 (string_buffer_position): Likewise. Also, make static (it's never
12018 used outside xdisp.c).
12019 (cursor_row_p): Remove parameter `w', unused since
12020 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12021 (decode_mode_spec): Remove parameter `precision', introduced during
12022 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12023 All callers changed.
12024
5ffb62aa
JD
120252011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12026
12027 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12028
461c2ab9 120292011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12030
12031 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12032 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12033 (ns_update_auto_hide_menu_bar): New functions.
12034 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12035 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12036 ns_constrain_all_frames.
12037 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12038 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12039
5c380ffb
JD
120402011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12041
12042 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12043
9af30bdf
GM
120442011-03-27 Glenn Morris <rgm@gnu.org>
12045
12046 * syssignal.h: Replace RETSIGTYPE with void.
12047 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12048 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12049 Replace SIGTYPE with void everywhere.
12050 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12051 * s/template.h (SIGTYPE): Remove commented out definition.
12052
e2abce01
JB
120532011-03-26 Eli Zaretskii <eliz@gnu.org>
12054
12055 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12056 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12057
f868cd8a
JB
120582011-03-26 Juanma Barranquero <lekktu@gmail.com>
12059
59eb0929
JB
12060 * w32.c (read_unc_volume): Use parameter `henum', instead of
12061 global variable `wget_enum_handle'.
12062
12063 * keymap.c (describe_vector): Remove parameters `indices' and
12064 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12065 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12066
f868cd8a
JB
12067 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12068
12069 * keyboard.c (timer_check): Remove parameter `do_it_now',
12070 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12071 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12072 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12073
12074 * keyboard.c (read_char):
12075 * w32menu.c (w32_menu_display_help):
12076 * xmenu.c (show_help_event, menu_help_callback):
12077 Adjust calls to `show_help_echo'.
12078
12079 * gtkutil.c (xg_maybe_add_timer):
12080 * keyboard.c (readable_events):
12081 * process.c (wait_reading_process_output):
12082 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12083
12084 * insdel.c (adjust_markers_gap_motion):
12085 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12086 (gap_left, gap_right): Don't call it.
12087
2ecf6fdb
CY
120882011-03-25 Chong Yidong <cyd@stupidchicken.com>
12089
12090 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12091 incurred during fontification.
12092
6b1f9ba4
JB
120932011-03-25 Juanma Barranquero <lekktu@gmail.com>
12094
12095 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12096 (DEFVAR_PER_BUFFER): Don't pass it.
12097
12098 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12099 (scrolling_window): Don't pass it.
12100
0f4a96b5
JB
121012011-03-25 Juanma Barranquero <lekktu@gmail.com>
12102
12103 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12104
12105 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12106 and `suffix'.
12107 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12108 of variables specific to SELinux and computation of `encoded_absname'.
12109
12110 * image.c (XPutPixel): Remove unused variable `height'.
12111
12112 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12113
12114 * unexw32.c (get_section_info): Remove unused variable `section'.
12115
12116 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12117 (system_process_attributes): Remove unused variable `sess'.
12118 (sys_read): Remove unused variable `err'.
12119
12120 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12121 (w32_wnd_proc): Remove unused variable `isdead'.
12122 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12123 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12124 (x_create_tip_frame): Remove unused variable `tem'.
12125
12126 * w32inevt.c (w32_console_read_socket):
12127 Remove unused variable `no_events'.
12128
12129 * w32term.c (x_draw_composite_glyph_string_foreground):
12130 Remove unused variable `width'.
12131
1149507c
JB
121322011-03-24 Juanma Barranquero <lekktu@gmail.com>
12133
12134 * w32term.c (x_set_glyph_string_clipping):
12135 Don't pass uninitialized region to CombineRgn.
12136
9c88f339
JB
121372011-03-23 Juanma Barranquero <lekktu@gmail.com>
12138
12139 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12140 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12141 (Fx_close_connection): Remove unused variable `i'.
12142
12143 * w32font.c (w32font_draw): Return number of glyphs.
12144 (w32font_open_internal): Remove unused variable `i'.
12145 (w32font_driver): Add missing initializer.
12146
12147 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12148 (fill_in_menu): Remove unused variable `items_added'.
12149
12150 * w32term.c (last_mouse_press_frame): Remove static global variable.
12151 (w32_clip_to_row): Remove unused variable `f'.
12152 (x_delete_terminal): Remove unused variable `i'.
12153
12154 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12155 (NOTHING): Remove unused static global variable.
12156 (uniscribe_check_otf): Remove unused variable `table'.
12157 (uniscribe_font_driver): Add missing initializers.
12158
dee091a3
JD
121592011-03-23 Julien Danjou <julien@danjou.info>
12160
12161 * term.c (Fsuspend_tty, Fresume_tty):
12162 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12163 * window.c (temp_output_buffer_show):
12164 * insdel.c (signal_before_change):
12165 * frame.c (Fhandle_switch_frame):
12166 * fileio.c (Fdo_auto_save):
12167 * emacs.c (Fkill_emacs):
12168 * editfns.c (save_excursion_restore):
12169 * cmds.c (internal_self_insert):
12170 * callint.c (Fcall_interactively):
12171 * buffer.c (Fkill_all_local_variables):
12172 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12173 Use Frun_hooks.
0f4a96b5 12174 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12175 unconditionally since it does the check itself.
dee091a3 12176
2c520ab5 121772011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12178
c9c49752
PE
12179 Fix more problems found by GCC 4.5.2's static checks.
12180
8abc3f12
PE
12181 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12182 the first time through the loop, since we know p0 < p1 then.
12183 This also avoids a gcc -Wstrict-overflow warning.
12184
a2d26660
PE
12185 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12186 leading to a memory leak, possible in functions like
12187 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12188 of objects (Bug#8318).
a2d26660 12189
916c72e9
PE
12190 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12191 that could (at least in theory) be that large.
12192
19ab8a18
PE
12193 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12194 This is less likely to overflow, and avoids undefined behavior if
12195 overflow does occur. All callers changed. Use strtoul to scan
12196 for the unsigned long integer.
b7cbbd6f
PE
12197 (pint2hrstr): Simplify and tune code slightly.
12198 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12199
f0641eff
PE
12200 * scroll.c (do_scrolling): Work around GCC bug 48228.
12201 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12202
7f650bb9
PE
12203 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12204 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12205 (validate_x_resource_name): Simplify count usage.
12206 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12207
37dd57d1
PE
12208 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12209 fail (Bug#8306).
81e56e61 12210
699979fc 12211 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12212
401bf9b4
PE
12213 * process.c (Fmake_network_process): Use socklen_t, not int,
12214 where POSIX says socklen_t is required in portable programs.
12215 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12216 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12217 (Fmake_network_process, server_accept_connection):
12218 (wait_reading_process_output, read_process_output):
12219 Likewise.
12220
b93aacde
PE
12221 * process.c: Rename or move locals to avoid shadowing.
12222 (list_processes_1, Fmake_network_process):
12223 (read_process_output_error_handler, exec_sentinel_error_handler):
12224 Rename or move locals.
4dc343ee 12225 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12226 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12227 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12228 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12229 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12230
af8a867c 12231 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12232 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12233 Include tparam.h instead, since it declares them.
af8a867c
PE
12234 * cm.h (PC): Remove extern decl; tparam.h now does this.
12235 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12236 * terminfo.c: Include tparam.h, to check interfaces.
12237 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12238 (tparam): Adjust signature to match interface in tparam.h;
12239 this removes some undefined behavior. Check that outstring and len
12240 are zero, which they always are with Emacs.
12241 * tparam.h (PC, BC, UP): New extern decls.
12242
0248044d 12243 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12244 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12245
8ff096c1 12246 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12247 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12248 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12249 (ftfont_list): Remove unused local.
49eaafba
PE
12250 (get_adstyle_property, ftfont_pattern_entity):
12251 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12252 Rename locals to avoid shadowing.
8ff096c1 12253
e2be39f6
PE
12254 * xfont.c (xfont_list_family): Mark var as initialized.
12255
c9735e30
PE
12256 * xml.c (make_dom): Now static.
12257
8f5201ae
PE
12258 * composite.c (composition_compute_stop_pos): Rename local to
12259 avoid shadowing.
b246f932
PE
12260 (composition_reseat_it): Remove unused locals.
12261 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12262 (composition_update_it): Mark var as initialized.
11b61122
PE
12263 (find_automatic_composition): Mark vars as initialized,
12264 with a FIXME (Bug#8290).
8f5201ae 12265
760fbc2c
PE
12266 character.h: Rename locals to avoid shadowing.
12267 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12268 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12269 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12270 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12271 to avoid shadowing.
12272
ff08eb85
PE
12273 * textprop.c (property_change_between_p): Remove; unused.
12274
fc7bf025
PE
12275 * intervals.c (interval_start_pos): Now static.
12276
235d7abc
PE
12277 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12278
44f230aa
SM
12279 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12280 Rename locals to avoid shadowing.
3e7d6594 12281
50060332
PE
12282 * sound.c (wav_play, au_play, Fplay_sound_internal):
12283 Fix pointer signedness.
d01f234b 12284 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12285 (wav_play): Initialize a variable to 0, to prevent undefined
12286 behavior (Bug#8278).
50060332 12287
c4fc4e30
PE
12288 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12289
918436ed
PE
12290 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12291
c939f91b
PE
12292 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12293 clobbering (Bug#8298).
b9c7f648
PE
12294 * sysdep.c (sys_subshell): Likewise.
12295 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12296
6bd8c144
PE
12297 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12298 This should get cleaned up, so that child_setup has the
12299 same signature on all platforms.
12300
7710357c 12301 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12302 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12303
c59da222
CY
123042011-03-22 Chong Yidong <cyd@stupidchicken.com>
12305
12306 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12307 not to be necessary, and produces flickering.
12308
66b87493
GM
123092011-03-20 Glenn Morris <rgm@gnu.org>
12310
12311 * config.in: Remove file.
12312
45b6f6d5
JB
123132011-03-20 Juanma Barranquero <lekktu@gmail.com>
12314
12315 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12316 are now in src/globals.h.
12317 (syms_of_minibuf): Remove spurious & from previous change.
12318
cd394be1 123192011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12320
12321 * minibuf.c (completing-read-function): New variable.
12322 (completing-read-default): Rename from completing-read.
12323 (completing-read): Call completing-read-function.
12324
b14e3e21
CY
123252011-03-19 Juanma Barranquero <lekktu@gmail.com>
12326
12327 * xfaces.c (Fx_load_color_file):
12328 Read color file from absolute filename (bug#8250).
12329
f2b726e6
JB
123302011-03-19 Juanma Barranquero <lekktu@gmail.com>
12331
12332 * makefile.w32-in: Update dependencies.
12333
09f6ff02
EZ
123342011-03-17 Eli Zaretskii <eliz@gnu.org>
12335
12336 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12337
29a6015a
PE
123382011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12339
a3a6c54e
PE
12340 Fix more problems found by GCC 4.5.2's static checks.
12341
b766f867
PE
12342 * process.c (make_serial_process_unwind, send_process_trap):
12343 (sigchld_handler): Now static.
12344
be02381c
PE
12345 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12346 That way, the code declares only the vars that it needs.
12347 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12348 * s/cygwin.h (PTY_ITERATION): Likewise.
12349 * s/darwin.h (PTY_ITERATION): Likewise.
12350 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12351
57048744
PE
12352 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12353 * process.c (allocate_pty): Don't declare stb unless it's needed.
12354
7914961c 12355 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12356 (CONSTANTLIM): Remove; unused.
12357 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12358 Define only if needed.
7914961c 12359
b3967b18
PE
12360 * unexelf.c (unexec): Name an expression,
12361 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12362 Use a different way to cause a compilation error if anyone uses
12363 n rather than nn, a way that does not involve shadowing.
73366a00 12364 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12365
29a6015a
PE
12366 * deps.mk (unexalpha.o): Remove; unused.
12367
43cfc33e 12368 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12369 * unexec.h: New file.
ce701a33
PE
12370 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12371 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12372 Depend on unexec.h.
12373 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12374 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12375 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12376 Change as necessary to match prototype in unexec.h.
ce701a33 12377
01f44d5a
PE
12378 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12379 shadowing.
4f63c6bb 12380 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12381
a6670b0b
PE
12382 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12383 Rename locals to avoid shadowing.
12384
cef2010d 12385 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12386 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12387
d4d7173a
PE
12388 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12389
f08b802a
PE
12390 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12391 warning when compiling print.c.
12392
3ddb0639
PE
12393 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12394 instead of using an uninitialized var.
5ad03b97 12395 (font_sort_entities): Mark var as initialized.
3ddb0639 12396
170a2692
PE
12397 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12398
e663c700
PE
12399 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12400 pointers to constants.
89bc529a 12401 (font_parse_fcname): Remove unused vars.
7b81e2d0 12402 (font_delete_unmatched): Now static.
ea838e10 12403 (font_get_spec): Remove; unused.
13a547c6
PE
12404 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12405 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12406 Rename or move locals to avoid shadowing.
e663c700 12407
2a80c887 12408 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12409 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12410
1384fa33 12411 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12412 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12413
8b2c52e9
PE
12414 * alloc.c (mark_backtrace): Move decl from here ...
12415 * lisp.h: ... to here, so that it can be checked.
12416
475545b5 12417 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12418 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12419 (lisp_indirect_variable): Name an expression,
12420 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12421 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12422
b1349114 12423 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12424 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12425 Use const pointer when appropriate.
b1349114 12426
a2928364
PE
12427 * lisp.h (get_system_name, get_operating_system_release):
12428 Move decls here, to check interfaces.
12429 * process.c (get_operating_system_release): Move decl to lisp.h.
12430 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12431 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12432 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12433 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12434 (Fformat_time_string, Fencode_time, Finsert_char):
12435 (Ftranslate_region_internal, Fformat):
12436 Rename or remove local vars to avoid shadowing.
9710023e 12437 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12438
a415e694
PE
12439 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12440 avoid shadowing.
12441
8ef4622d
PE
12442 * lisp.h (eassert): Check that the argument compiles, even if
12443 ENABLE_CHECKING is not defined.
12444
946f9a5b
PE
12445 * data.c (Findirect_variable): Name an expression, to avoid
12446 gcc -Wbad-function-cast warning.
112396d6 12447 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12448 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12449 (Fmake_variable_buffer_local, Fmake_local_variable):
12450 Mark variables as initialized.
52746918 12451 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12452
e5aab7e7 12453 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12454 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12455 Rename locals to avoid shadowing.
dff45157
PE
12456 (mark_stack): Move local variables into the #ifdef region where
12457 they're used.
7bc26fdb
PE
12458 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12459 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12460 needed otherwise.
12461 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12462 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12463 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12464
e5aab7e7
PE
12465 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12466 avoids undefined behavior in theory.
12467
4da60324
PE
12468 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12469
88043301
PE
12470 Use functions, not macros, for up- and down-casing (Bug#8254).
12471 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12472 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12473 to use the following functions instead of these macros.
12474 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12475 EMACS_INT, since callers assume the returned value fits in int.
12476 (upcase1): Likewise, for UPCASE_TABLE.
12477 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12478 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12479 the race-condition problem in the old DOWNCASE.
88043301 12480
19ed5445
PE
12481 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12482 Rename locals to avoid shadowing.
12483 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12484 (regex_compile, re_search_2, re_match_2_internal):
12485 Remove unused local vars.
952db0d7
PE
12486 (FREE_VAR): Rewrite so as not to use empty "else",
12487 which gcc can warn about.
da053e48 12488 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12489 (RETALLOC_IF): Define only if needed.
12490 (WORDCHAR_P): Likewise. This one is never needed, but is used
12491 only in a comment talking about a compiler bug, so put inside
12492 the #if 0 of that comment.
12493 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12494 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12495 Remove; unused.
19ed5445 12496
1f3561e4 12497 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12498 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12499 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12500
ded6f8f7
PE
12501 * search.c (simple_search): Remove unused var.
12502
dbd37a95
PE
12503 * dired.c (compile_pattern): Move decl from here ...
12504 * lisp.h: ... to here, so that it can be checked.
12505 (struct re_registers): New forward decl.
12506
7e47afad
PE
12507 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12508
85f24f61
PE
12509 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12510 All uses changed.
12511 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12512 Rename locals to avoid shadowing.
5671df8f 12513 (Fvertical_motion): Mark locals as initialized.
85f24f61 12514
181aa2be 12515 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12516 (casify_region): Mark local as initialized.
181aa2be 12517
930d429c
PE
12518 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12519
7082eac6
PE
12520 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12521 New macros, so that the caller can use some names other than
12522 gcpro1, gcpro2, etc.
12523 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12524 of the new macros.
12525 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12526 argument, for consistency with GCPRO2_VAR, etc: it is now the
12527 prefix of the variable, not the variable itself. All uses
12528 changed.
38b2c076
PE
12529 * dired.c (directory_files_internal, file_name_completion):
12530 Rename locals to avoid shadowing.
12531
15206ed9
PE
12532 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12533 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12534 dired.c's scmp function, had undefined behavior.
12535 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12536 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12537 * buffer.h: ... to here, because these macros use current_buffer,
12538 and the new implementation with inline functions needs to have
12539 current_buffer in scope now, rather than later when the macros
12540 are used.
12541 (downcase, upcase1): New static inline functions.
12542 (DOWNCASE, UPCASE1): Reimplement using these functions.
12543 This avoids undefined behavior in expressions like
12544 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12545 from race conditions in accessing the global variables
12546 case_temp1 and case_temp2.
12547 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12548 * lisp.h (case_temp1, case_temp2): Remove their decls.
12549 * character.h (ASCII_CHAR_P): Move from here ...
12550 * lisp.h: ... to here, so that the inline functions mentioned
12551 above can use them.
12552
4a6bea26
PE
12553 * dired.c (directory_files_internal_unwind): Now static.
12554
f14b7e14
PE
12555 * fileio.c (file_name_as_directory, directory_file_name):
12556 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12557 Now static.
2893f146
PE
12558 (file_name_as_directory): Use const pointers when appropriate.
12559 (Fexpand_file_name): Likewise. In particular, newdir might
12560 point at constant storage, so make it a const pointer.
fd4ead52 12561 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12562 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12563 signedness issues.
f839df0c
PE
12564 (Fset_file_times, Finsert_file_contents, auto_save_error):
12565 Rename locals to avoid shadowing.
f14b7e14 12566
5716756e 12567 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12568 (Ftry_completion, Fall_completions): Rename or remove locals
12569 to avoid shadowing.
5716756e 12570
b4c3046a
PE
12571 * marker.c (bytepos_to_charpos): Remove; unused.
12572
b45db522
PE
12573 * lisp.h (verify_bytepos, count_markers): New decls,
12574 so that gcc does not warn that these functions aren't declared.
12575
85876d07
PE
12576 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12577 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12578 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12579 (copy_text): Remove unused local var.
85876d07 12580
03d78a21 12581 * filelock.c (within_one_second): Now static.
b3dd38ab 12582 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12583
5df8f01b
PE
12584 * buffer.c (fix_overlays_before): Mark locals as initialized.
12585 (fix_start_end_in_overlays): Likewise. This function should be
12586 simplified by using pointers-to-pointers, but that's a different
12587 matter.
b1d876f1 12588 (switch_to_buffer_1): Now static.
8f54f30a
PE
12589 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12590 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12591
a70072c9 12592 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12593 Fix pointer signedness issue.
edced198
PE
12594 (sys_subshell): Mark local as volatile if checking for lint,
12595 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12596 (MAXPATHLEN): Define only if needed.
a70072c9 12597
a0977c44
PE
12598 * process.c (serial_open, serial_configure): Move decls from here ...
12599 * systty.h: ... to here, so that they can be checked.
12600
a884fdcc
PE
12601 * fns.c (get_random, seed_random): Move extern decls from here ...
12602 * lisp.h: ... to here, so that they can be checked.
12603
604efe86 12604 * sysdep.c (reset_io): Now static.
b8950c94 12605 (wait_for_termination_signal): Remove; unused.
604efe86 12606
38fc62d9
PE
12607 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12608 (copy_keymap_item, append_key, push_text_char_description):
12609 Now static.
1004a21a 12610 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12611 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12612 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12613 (describe_map_tree):
12614 Rename locals to avoid shadowing.
38fc62d9 12615
2f2650da
PE
12616 * keyboard.c: Declare functions static if they are not used elsewhere.
12617 (echo_char, echo_dash, cmd_error, top_level_2):
12618 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12619 (read_char, kbd_buffer_get_event, make_lispy_position):
12620 (make_lispy_event, make_lispy_movement, apply_modifiers):
12621 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12622 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12623 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12624 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12625 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12626
a053e86c 12627 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12628 (mark_kboards): Move decl here ...
12629 * alloc.c (mark_kboards): ... from here.
a053e86c 12630
4752793e
PE
12631 * lisp.h (force_auto_save_soon): New decl.
12632
74f10ca7 12633 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12634 (DEFINE_DUMMY_FUNCTION): New macro.
12635 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12636 Use it.
c03cd23f
PE
12637 (main): Add casts to avoid warnings
12638 if GCC considers string literals to be constants.
74f10ca7 12639
022e70d4
PE
12640 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12641
59d6fe83
PE
12642 * dbusbind.c: Pointer signedness fixes.
12643 (xd_signature, xd_append_arg, xd_initialize):
12644 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12645 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12646 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12647 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12648
78320123
PE
12649 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12650 if GCC considers string literals to be constants.
49cebcca 12651 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12652
35ac2a97
SM
126532011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12654
fb103ca9
SM
12655 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12656 (print_preprocess, print_object): New macro to fix last change.
12657
35ac2a97
SM
12658 * print.c (print_preprocess): Don't forget font objects.
12659
62973b41
JB
126602011-03-16 Juanma Barranquero <lekktu@gmail.com>
12661
12662 * emacs.c (USAGE3): Doc fixes.
12663
0e48bb22
AS
126642011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12665
12666 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12667 structure.
12668
7684e57b
JB
126692011-03-14 Juanma Barranquero <lekktu@gmail.com>
12670
12671 * lisp.h (VWindow_system, Qfile_name_history):
12672 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12673 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12674 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12675
12676 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12677 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12678
12679 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12680 * w32console.c (detect_input_pending, read_input_pending)
12681 (encode_terminal_code):
12682 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12683 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12684 (w32_system_caret_y, Qfile_name_history):
12685 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12686 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12687 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12688 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12689 * w32proc.c (Qlocal, report_file_error):
12690 * w32term.c (Vwindow_system, updating_frame):
12691 * w32uniscribe.c (initialized, uniscribe_font_driver):
12692 Remove unneeded extern declarations.
12693
2aa46d6c
CY
126942011-03-14 Chong Yidong <cyd@stupidchicken.com>
12695
c96bbc66 12696 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12697
cffc6f3b
CY
126982011-03-13 Chong Yidong <cyd@stupidchicken.com>
12699
12700 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12701 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12702 These macros can no longer be used for assignment.
12703
44f230aa
SM
12704 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12705 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12706 (record_buffer_markers, fetch_buffer_markers): New functions for
12707 recording and fetching special buffer markers.
12708 (set_buffer_internal_1, set_buffer_temp): Use them.
12709
12710 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12711
12712 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12713
12714 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12715 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12716
12717 * xdisp.c (hscroll_window_tree):
12718 (reconsider_clip_changes): Use PT instead of BUF_PT.
12719
d251f04b
EZ
127202011-03-13 Eli Zaretskii <eliz@gnu.org>
12721
12722 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12723 $(EMACS_ROOT)/lib/intprops.h.
12724
f0c77cd1
PE
127252011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12726
3eca4629
PE
12727 Fix more problems found by GCC 4.5.2's static checks.
12728
7c86ee98
PE
12729 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12730 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12731 (xg_free_frame_widgets): Make it clear that a local variable is
12732 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12733 (gdk_window_get_screen): Make it clear that this macro is needed
12734 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12735 (int_gtk_range_get_value): New function, which avoids a diagnostic
12736 from gcc -Wbad-function-cast.
12737 (xg_set_toolkit_scroll_bar_thumb): Use it.
12738 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12739 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12740 (get_utf8_string, xg_get_file_with_chooser):
12741 Rename locals to avoid shadowing.
12742 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12743
41729b81
PE
12744 * xgselect.c (xg_select): Remove unused var.
12745
f0c77cd1
PE
12746 * image.c (four_corners_best): Mark locals as initialized.
12747 (gif_load): Initialize transparent_p to zero (Bug#8238).
12748 Mark another local as initialized.
ec6cf4c6 12749 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12750
ce0ad53d 12751 * image.c (clear_image_cache): Now static.
d5d5a617 12752 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12753 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12754 (x_edge_detection): Remove unnecessary cast that
12755 gcc -Wbad-function-cast diagnoses.
2037898d 12756 (gif_load): Fix pointer signedness.
6ae141d6
PE
12757 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12758 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12759
33383987 127602011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12761
d32df629
PE
12762 Improve quality of tests for time stamp overflow.
12763 For example, without this patch (encode-time 0 0 0 1 1
12764 1152921504606846976) returns the obviously-bogus value (-948597
12765 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12766 reports time overflow. See
12767 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12768 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12769 * editfns.c: Include limits.h and intprops.h.
12770 (TIME_T_MIN, TIME_T_MAX): New macros.
12771 (time_overflow): Move earlier, to before first use.
12772 (hi_time, lo_time): New functions, for an accurate test for
12773 out-of-range times.
12774 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12775 (Fget_internal_run_time): Don't assume time_t fits in int.
12776 (make_time): Use list2 instead of Fcons twice.
12777 (Fdecode_time): More accurate test for out-of-range times.
12778 (check_tm_member): New function.
12779 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12780 (lisp_time_argument): Don't rely on undefined left-shift and
12781 right-shift behavior when checking for time stamp overflow.
8be6f318 12782
fe31d94c
PE
12783 * editfns.c (time_overflow): New function, refactoring common code.
12784 (Fformat_time_string, Fdecode_time, Fencode_time):
12785 (Fcurrent_time_string): Use it.
12786
8be6f318
PE
12787 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12788 * dired.c (make_time): Move to ...
12789 * editfns.c (make_time): ... here.
12790 * systime.h: Note the move.
12791
09d9db2c 127922011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12793
126bc0dc
YM
12794 * fringe.c (update_window_fringes): Remove unused variables.
12795
c47cbdfd
YM
12796 * unexmacosx.c (copy_data_segment): Also copy __got section.
12797 (Bug#8223)
12798
7ac80be9
EZ
127992011-03-12 Eli Zaretskii <eliz@gnu.org>
12800
c96bbc66 12801 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12802 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12803 Constify `char *' arguments and their references according to
12804 prototypes in tparam.h.
12805
ecb0f94d 12806 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12807
7ac80be9
EZ
12808 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12809 Adapt all references accordingly.
12810
12811 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12812
ef1fd07e
TT
128132011-03-11 Tom Tromey <tromey@redhat.com>
12814
12815 * buffer.c (syms_of_buffer): Remove obsolete comment.
12816
7ef4b50c
EZ
128172011-03-11 Eli Zaretskii <eliz@gnu.org>
12818
12819 * termhooks.h (encode_terminal_code): Declare prototype.
12820
12821 * msdos.c (encode_terminal_code): Don't declare prototype.
12822
12823 * term.c (encode_terminal_code): Now external again, used by
12824 w32console.c and msdos.c.
12825
44f230aa
SM
12826 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12827 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12828
4b1ec863 128292011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12830
1714f52b 12831 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12832
4b1ec863
PE
12833 * fringe.c (update_window_fringes): Mark locals as initialized
12834 (Bug#8227).
12835 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12836
524c7aa6
PE
12837 * alloc.c (mark_fringe_data): Move decl from here ...
12838 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12839 to check its interface.
12840 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12841
a5c0af81 12842 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12843 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12844 (fontset_font): Mark local as initialized.
a9a06e0b 12845 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12846
b4716021
PE
12847 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12848
811e9bac 12849 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12850 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12851 (x_own_selection, Fx_disown_selection_internal): Rename locals
12852 to avoid shadowing.
12853 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12854
7e3ab302
PE
12855 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12856 so that the caller can use some name other than gcpro1.
12857 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12858 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12859 (Fx_backspace_delete_keys_p):
12860 Use them to avoid shadowing, and rename vars to avoid shadowing.
12861 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12862 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12863 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12864 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12865 Remove unused locals.
7e3ab302
PE
12866 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12867 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12868 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12869 macros.
f78faa98 12870
e2b13473
PE
12871 * xterm.h (x_mouse_leave): New decl.
12872
77f23912
PE
12873 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12874 Remove unused functions.
cdf4ba58
PE
12875 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12876 (x_calc_absolute_position): Now static.
7411c686 12877 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12878 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12879 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12880 unless they are used.
38d0b34a
PE
12881 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12882 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12883 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12884 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12885 (x_error_catcher, x_connection_closed, x_error_handler):
12886 (x_error_quitter, xembed_send_message, x_iconify_frame):
12887 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12888 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12889 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12890
44f230aa
SM
12891 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12892 Rename or move locals to avoid shadowing.
6b463e58 12893 (tty_defined_color, merge_face_heights): Now static.
5967d051 12894 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12895 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12896 does not deduce is never used uninitialized.
73719eba
PE
12897 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12898 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12899
426994c3 12900 * terminal.c (store_terminal_param): Now static.
5489860b 12901
032f1620 12902 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12903 (set_frame_menubar): Remove unused local.
d4323972 12904 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12905 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12906 since they might point to immutable storage.
281585b0
PE
12907 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12908 since it's unused otherwise.
032f1620 12909
367c19e5 12910 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12911 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12912 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12913 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12914 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12915 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12916 does not deduce are never used uninitialized.
70739cbe 12917
07b48fa9
PE
12918 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12919
8868a238 12920 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12921 * window.c (window_loop, size_window):
12922 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12923
7e5cf297 12924 * window.c (display_buffer): Now static.
d6550a9f
PE
12925 (size_window): Mark variables that gcc -Wuninitialized
12926 does not deduce are never used uninitialized.
a586633d
PE
12927 * window.h (check_all_windows): New decl, to forestall
12928 gcc -Wmissing-prototypes diagnostic.
5b555da1 12929 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12930
f6095868
PE
12931 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12932 shadowing.
12933 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12934 Include <limits.h>.
12935 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12936 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12937 (load_charset_map): Mark variables that gcc -Wuninitialized
12938 does not deduce are never used uninitialized.
53df7c11 12939 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12940
f38b440c
PE
12941 * coding.c (coding_set_source, coding_set_destination):
12942 Use "else { /* comment */ }" rather than "else /* comment */;"
12943 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12944 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12945 a block, when the outer 'i' will do.
12946 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12947 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12948 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12949 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12950 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12951 Rename locals to avoid shadowing.
12952 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12953 * coding.c (emacs_mule_char, encode_invocation_designation):
12954 Now static, since they're not used elsewhere.
413bb2db 12955 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12956 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12957 (decode_coding_emacs_mule): Mark variables that gcc
12958 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12959 (detect_coding_iso_2022): Initialize a local variable that might
12960 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12961 this initialization is needed. (Bug#8211)
5f58e762
PE
12962 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12963 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12964 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12965 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12966 Remove unused macros.
f38b440c 12967
232b38b9 12968 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12969 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12970 * character.c (string_count_byte8): Likewise.
232b38b9 12971
fb90da1b
PE
12972 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12973 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12974
fb93dbc2
PE
12975 * chartab.c (copy_sub_char_table): Now static, since it's not used
12976 elsewhere.
5c156ace
PE
12977 (sub_char_table_ref_and_range, char_table_ref_and_range):
12978 Rename locals to avoid shadowing.
bbcd0949 12979 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12980
7d3b3862 12981 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12982 (BIDI_BOB): Remove unused macro.
7d3b3862 12983
6be7d3da
PE
12984 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12985 deduce are never used uninitialized.
c2ed9c8b 12986 * term.c (encode_terminal_code): Likewise.
6be7d3da 12987
75f8807f 12988 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12989
50938595
PE
12990 * tparam.h: New file.
12991 * term.c, tparam.h: Include it.
12992 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12993 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12994 Move these decls to tparam.h, and make them agree with what
12995 is actually in tparam.c. The previous trick of using incompatible
12996 decls in different modules does not conform to the C standard.
12997 All callers of tparam changed to use tparam's actual API.
12998 * tparam.c (tparam1, tparam, tgoto):
12999 Use const pointers where appropriate.
13000
fbceeba2
PE
13001 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13002 * cm.h (struct cm): Likewise.
13003 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13004 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13005 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13006 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13007 (turn_on_face, init_tty): Likewise.
13008 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13009
7f3f1250
PE
13010 * term.c (term_mouse_position): Rename local to avoid shadowing.
13011
e6ca6543
PE
13012 * alloc.c (mark_ttys): Move decl from here ...
13013 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13014
c40f8d15
AS
130152011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13016
13017 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13018
cfe0661d
JB
130192011-03-09 Juanma Barranquero <lekktu@gmail.com>
13020
13021 * search.c (compile_pattern_1): Remove argument regp, unused since
13022 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13023 (compile_pattern): Don't pass it.
13024
0afb4571
J
130252011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13026
13027 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13028 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13029 for ! HAVE_GTK3.
13030 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13031
13032 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13033
13034 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13035 gdk_window_get_screen, gdk_window_get_geometry,
13036 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13037 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13038 (xg_get_pixbuf_from_pixmap): New function.
13039 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13040 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13041 Call xg_get_pixbuf_from_pixmap instead of
13042 gdk_pixbuf_get_from_drawable.
13043 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13044 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13045 (xg_check_special_colors): Use GtkStyleContext and its functions
13046 for HAVE_GTK3.
13047 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13048 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13049 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13050 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13051 Call gtk_widget_get_preferred_size.
0afb4571
J
13052 (xg_frame_resized): gdk_window_get_geometry only takes 5
13053 parameters.
44f230aa
SM
13054 (xg_win_to_widget, xg_event_is_for_menubar):
13055 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13056 (xg_set_widget_bg): New function.
13057 (delete_cb): New function.
895009e1 13058 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13059 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13060 (xg_set_background_color): Call xg_set_widget_bg.
13061 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13062 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13063 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13064 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13065 if ! HAVE_GTK3.
13066 (update_frame_tool_bar): Call gtk_widget_hide.
13067 (xg_initialize): Use GDK_KEY_g.
13068
13069 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13070 if ! HAVE_GTK3
13071 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13072
13073 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13074 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13075 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13076
1c2cc4ef
JB
130772011-03-08 Juanma Barranquero <lekktu@gmail.com>
13078
13079 * w32xfns.c (select_palette): Check success of RealizePalette against
13080 GDI_ERROR, not zero.
13081
33383987 13082See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13083
13084;; Local Variables:
13085;; coding: utf-8
aac0c6e3
MR
13086;; End:
13087
2f097256 13088 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13089
13090 This file is part of GNU Emacs.
13091
13092 GNU Emacs is free software: you can redistribute it and/or modify
13093 it under the terms of the GNU General Public License as published by
13094 the Free Software Foundation, either version 3 of the License, or
13095 (at your option) any later version.
13096
13097 GNU Emacs is distributed in the hope that it will be useful,
13098 but WITHOUT ANY WARRANTY; without even the implied warranty of
13099 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13100 GNU General Public License for more details.
13101
13102 You should have received a copy of the GNU General Public License
13103 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.