* sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
db7b8d06
PE
12012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2
3 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
4 Privately reported by Herbert J. Skuhra.
5 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
6 All uses changed.
7 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
8 not make_lisp_timeval, when the argument is of type EMACS_TIME.
9
0bd8297f
EZ
102012-06-23 Eli Zaretskii <eliz@gnu.org>
11
96512555
EZ
12 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
13 last argument of make_unibyte_string.
14
0bd8297f
EZ
15 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
16 language ID in the event parameters.
17
18 * w32term.c (w32_read_socket): Put the new keyboard codepage into
19 event.code, not the obscure "character set ID".
20
63def6b6
CY
212012-06-23 Chong Yidong <cyd@gnu.org>
22
23 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
24
e8a02204
EZ
252012-06-23 Eli Zaretskii <eliz@gnu.org>
26
388cdec0
EZ
27 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
28 * w32.c (fdutimens): New function.
29
30 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
31
32 * s/ms-w32.h (pselect): Redirect to sys_select.
33
34 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
35
e8a02204
EZ
36 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
37 in the logic of incrementing and decrementing the value of
38 use_relocatable_buffers.
39
d054f3fb
PE
402012-06-23 Paul Eggert <eggert@cs.ucla.edu>
41
42 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
43 Privately reported by Herbert J. Skuhra.
44 [__FreeBSD__]: Remove "*/" typo after "#include".
45 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
46 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
47 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
48 Don't assume EMACS_TIME and struct timeval are the same type.
49
d35af63c
PE
502012-06-22 Paul Eggert <eggert@cs.ucla.edu>
51
52 Support higher-resolution time stamps (Bug#9000).
53 The time stamps are only nanosecond-resolution at the C level,
54 since that's the best that any real-world system supports now.
55 But they are picosecond-resolution at the Lisp level, as that's
56 easy, and leaves room for future OS improvements.
57
58 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
59 (LIBES): Use it.
60
61 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
62 Don't get current time unless it's needed.
63
64 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
65 now provides it if it's absent.
66 (start_atimer): Port to higher-res time stamps.
67 Check for time stamp overflow. Don't get current time more
68 often than is needed.
69
70 * buffer.h (struct buffer): Buffer modtime now has high resolution.
71 Include systime.h, not time.h.
72 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
73
74 * dired.c: Include stat-time.h.
75 (Ffile-attributes): File times now have higher resolution.
76
77 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
78 (struct image): Timestamp now has higher resolution.
79
80 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
81 has at least microseconds now. All uses removed.
82 (update_frame, update_single_window, update_window, update_frame_1)
83 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
84
85 * editfns.c (time_overflow): Now extern.
86 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
87 (float-time, Fformat_time_string, Fcurrent_time_string)
88 (Fcurrent_time_zone): Accept and generate higher-resolution
89 time stamps.
90 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
91 (decode_time_components, lisp_seconds_argument): New functions.
92 (make_time): Now static.
93 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
94 Report an error if the time is invalid, rather than having the caller
95 do that.
96
97 * fileio.c: Include <stat-time.h>
98 (Fcopy_file): Copy higher-resolution time stamps.
99 Prefer to set the time stamp via a file descriptor if that works.
100 (Fset_file_times, Finsert_file_contents, Fwrite_region)
101 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
102 (Fvisited_file_modtime, Fset_visited_file_modtime):
103 Support higher-resolution time stamps.
104
105 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
106
107 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
108
109 * image.c (prepare_image_for_display, clear_image_cache)
110 (lookup_image): Port to higer-resolution time stamps.
111
112 * keyboard.c (start_polling, bind_polling_period):
113 Check for time stamp overflow.
114 (read_char, kbd_buffer_get_event, timer_start_idle)
115 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
116 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
117 Port to higher-resolution time stamps. Do not assume time_t is signed.
118 (decode_timer): New function. Timers are now vectors of length 9,
119 not 8, to accommodate the picosecond component.
120 (timer_check_2): Use it.
121
122 * nsterm.m (select_timeout, timeval_subtract): Remove.
123 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
124 as they're a bit more accurate and handle overflow better.
125 (ns_select): Change prototype to be compatible with pselect.
126 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
127 * nsterm.h (ns_select): Adjust prototype.
128
129 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
130 us-resolution time stamps.
131 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
132
133 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
134
135 * lisp.h (time_overflow): New decl.
136 (wait_reading_process_output): First arg is now intmax_t, not int,
137 to accommodate larger waits.
138
139 * process.h (struct Lisp_Process.read_output_delay):
140 Now counts nanoseconds, not microseconds.
141 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
142 EMACS_HAS_USECS.
143 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
144 (wait_reading_process_output):
145 Port to ns-resolution time stamps.
146 (Faccept_process_output, wait_reading_process_output):
147 Check for time stamp overflow. Do not assume time_t is signed.
148 (select_wrapper): Remove; we now use pselect.
149 (Fprocess_attributes): Now generates ns-resolution time stamps.
150
151 * sysdep.c: Include utimens.h. Don't include utime.h
152 or worry about struct utimbuf; gnulib does that for us now.
153 (gettimeofday): Remove; gnulib provides a substitute.
154 (make_timeval): New function.
155 (set_file_times): Now sets ns-resolution time stamps.
156 New arg FD; all uses changed.
157 (time_from_jiffies, ltime_from_jiffies, get_up_time)
158 (system_process_attributes):
159 Now returns ns-resolution time stamp. All uses changed.
160 Check for time stamp overflow.
161
162 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
163 provides a substitute now.
164
165 * systime.h: Include timespec.h rather than sys/time.h and time.h,
166 since it guarantees struct timespec.
167 (EMACS_TIME): Now struct timespec, so that we can support
168 ns-resolution time stamps.
169 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
170 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
171 (EMACS_USECS): Remove.
172 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
173 so multiply the arg by 1000 before storing it.
174 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
175 New macros.
176 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
177 Port to ns-resolution time stamps.
178 (EMACS_TIME_NEG_P): Remove; replaced by....
179 (EMACS_TIME_SIGN): New macro.
180 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
181 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
182 (set_file_times, make_time, lisp_time_argument): Adjust signature.
183 (make_timeval, make_lisp_time, decode_time_components): New decls.
184 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
185 that it mishandled time_t overflow. You can't compare by subtracting!
186 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
187 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
188
189 * term.c: Include <sys/time.h>.
190 (timeval_to_Time): New function, for proper overflow wraparound.
191 (term_mouse_position, term_mouse_click): Use it.
192
193 * undo.c (record_first_change): Support higher-resolution time stamps
194 in the undo buffer.
195 (Fprimitive_undo): Use them when restoring time stamps.
196
197 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
198 (w32_get_internal_run_time):
199 Port to higher-resolution Emacs time stamps.
200 (ltime): Now accepts single 64-bit integer, as that's more convenient
201 for callers.
202
203 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
204
205 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
206 for compatibility with pselect. Support ns-resolution time stamps.
207
208 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
209
210 * xselect.c (wait_for_property_change, x_get_foreign_selection):
211 Check for time stamp overflow, and support ns-resolution time stamps.
212
213 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
214 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
215 (timeval_subtract): Remove; no longer needed.
216 (XTflash, XTring_bell, x_wait_for_event):
217 Port to ns-resolution time stamps. Don't assume time_t is signed.
218
b6a92dfe
CY
2192012-06-22 Chong Yidong <cyd@gnu.org>
220
221 * xdisp.c (x_consider_frame_title): Revert last change.
222
d251c37c
EZ
2232012-06-22 Eli Zaretskii <eliz@gnu.org>
224
225 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
226 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
227 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
228 staticidx goes up to 1597 out of 1600 = 0x640.)
229
f10deafb
PE
2302012-06-20 Paul Eggert <eggert@cs.ucla.edu>
231
232 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
233 Otherwise, the umask might be mistakenly 0 while handling input signals.
234
ec6de1e2
SM
2352012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
236
237 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
238
28be1ada
DA
2392012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
240
241 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
242 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
243 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
244 access to `contents' member of Lisp_Vector objects with AREF and ASET
245 where appropriate.
246
c6bf3022
CY
2472012-06-19 Chong Yidong <cyd@gnu.org>
248
249 * frame.c (delete_frame): When selecting a frame on a different
250 text terminal, do not alter the terminal's top-frame.
251
252 * xdisp.c (format_mode_line_unwind_data): Record the target
253 frame's selected window and its terminal's top-frame.
254 (unwind_format_mode_line): Restore them.
255 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
256 Callers changed.
257 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
258 since tty frames can be explicitly named.
259 (prepare_menu_bars): Likewise.
260
261 * term.c (Ftty_top_frame): New function.
262
defd4196
PE
2632012-06-18 Paul Eggert <eggert@cs.ucla.edu>
264
265 Port byte-code-meter to modern targets.
266 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
267 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 268 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
269 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
270 (METER_1, METER_2): Simplify.
271
1053a871
SM
2722012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
273
274 * data.c (Fdefalias): Return `symbol' (bug#11686).
275
b7e8d081
MR
2762012-06-18 Martin Rudalics <rudalics@gmx.at>
277
278 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
279 gets killed during executing of this function (Bug#11665).
280 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
281 (Vkill_buffer_query_functions): In doc-string say that functions
282 run by this hook should not change the current buffer.
283
7ea2b339
PE
2842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
285
286 Fix recently-introduced process.c problems found by static checking.
287 * process.c (write_queue_push, write_queue_pop, send_process):
288 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
289 (write_queue_pop): Fix pointer signedness problem.
290 (send_process): Remove unused local.
291
96a313a1
CY
2922012-06-17 Chong Yidong <cyd@gnu.org>
293
294 * xdisp.c (redisplay_internal): No need to redisplay terminal
295 frames that are not on top.
296
20ca2e94
TN
2972012-06-17 Troels Nielsen <bn.troels@gmail.com>
298
299 * process.c (make_process): Initialize write_queue.
300 (write_queue_push, write_queue_pop): New functions.
301 (send_process): Use them to maintain correct ordering of process
302 writes (Bug#10815).
303
9a900ca9
PE
3042012-06-17 Paul Eggert <eggert@cs.ucla.edu>
305
310fbfa8
PE
306 * lisp.h (eassert): Assume C89 or later.
307 This removes the need for CHECK.
308 (CHECK): Remove. Its comments about always evaluating its
309 argument were confusing, as 'eassert' typically does not evaluate
310 its argument.
311
27bb1ca4
PE
312 * coding.c (produce_chars): Use ptrdiff_t, not int.
313
9a900ca9
PE
314 * xterm.c (x_draw_underwave): Check for integer overflow.
315 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
316
41b7f8bc 3172012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
318
319 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
320 referenced (Bug#11583).
321
9b0e3eba
AA
3222012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
323
324 Implement wave-style variant of underlining.
325 * dispextern.h (face_underline_type): New enum.
326 (face): Add field for underline type.
327 * nsterm.m (ns_draw_underwave): New function.
328 (ns_draw_text_decoration): Use it.
329 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
330 New functions.
331 (x_draw_glyph_string): Use them.
332 * xfaces.c (Qline, Qwave): New Lisp objects.
333 (check_lface_attrs, merge_face_ref)
1053a871
SM
334 (Finternal_set_lisp_face_attribute, realize_x_face):
335 Handle wave-style underline face attributes.
9b0e3eba
AA
336 * xterm.c (x_draw_underwave): New function.
337 (x_draw_glyph_string): Use it.
338
0fb52f11
JB
3392012-06-16 Juanma Barranquero <lekktu@gmail.com>
340
341 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
342 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
343 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
344 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
345 ($(BLD)/w32select.$(O)): Update dependencies.
346
e5560ff7
AS
3472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
348
349 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
350 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
351 * character.c (_fetch_multibyte_char_p): Remove.
352 * alloc.c: Include "character.h" before "buffer.h".
353 * bidi.c: Likewise.
354 * buffer.c: Likewise.
355 * bytecode.c: Likewise.
356 * callint.c: Likewise.
357 * callproc.c: Likewise.
358 * casefiddle.c: Likewise.
359 * casetab.c: Likewise.
360 * category.c: Likewise.
361 * cmds.c: Likewise.
362 * coding.c: Likewise.
363 * composite.c: Likewise.
364 * dired.c: Likewise.
365 * dispnew.c: Likewise.
366 * doc.c: Likewise.
367 * dosfns.c: Likewise.
368 * editfns.c: Likewise.
369 * emacs.c: Likewise.
370 * fileio.c: Likewise.
371 * filelock.c: Likewise.
372 * font.c: Likewise.
373 * fontset.c: Likewise.
374 * fringe.c: Likewise.
375 * indent.c: Likewise.
376 * insdel.c: Likewise.
377 * intervals.c: Likewise.
378 * keyboard.c: Likewise.
379 * keymap.c: Likewise.
380 * lread.c: Likewise.
381 * macros.c: Likewise.
382 * marker.c: Likewise.
383 * minibuf.c: Likewise.
384 * nsfns.m: Likewise.
385 * nsmenu.m: Likewise.
386 * print.c: Likewise.
387 * process.c: Likewise.
388 * regex.c: Likewise.
389 * region-cache.c: Likewise.
390 * search.c: Likewise.
391 * syntax.c: Likewise.
392 * term.c: Likewise.
393 * textprop.c: Likewise.
394 * undo.c: Likewise.
395 * unexsol.c: Likewise.
396 * w16select.c: Likewise.
397 * w32fns.c: Likewise.
398 * w32menu.c: Likewise.
399 * window.c: Likewise.
400 * xdisp.c: Likewise.
401 * xfns.c: Likewise.
402 * xmenu.c: Likewise.
403 * xml.c: Likewise.
404 * xselect.c: Likewise.
405
2f07e6af
EZ
4062012-06-16 Eli Zaretskii <eliz@gnu.org>
407
1053a871
SM
408 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
409 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 410 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
411 row.
412 (handle_face_prop): Use chunk-relative overlay string index when
413 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
414 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
415 the rightmost. (Bug#11720)
2f07e6af 416
29b83cec
AS
4172012-06-16 Andreas Schwab <schwab@linux-m68k.org>
418
419 * category.h (CHAR_HAS_CATEGORY): Define as inline.
420 (CATEGORY_MEMBER): Enforce 1/0 value.
421 * category.c (_temp_category_set): Remove.
422
4c5501e9
EZ
4232012-06-16 Eli Zaretskii <eliz@gnu.org>
424
425 * window.c (Fdelete_other_windows_internal)
426 (Fdelete_window_internal): Don't access frame's mouse highlight
427 info of the initial frame. (Bug#11677)
428
2b570124
PE
4292012-06-14 Paul Eggert <eggert@cs.ucla.edu>
430
e93864f9
PE
431 * .gdbinit (xgetint): Fix recently-introduced paren typo.
432 Assume USE_2_TAGS_FOR_INTS.
433 (xreload): Adjust $tagmask width to match recent lisp.h change.
434
2b570124
PE
435 Simplify lisp.h in minor ways that should not affect code.
436 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
437 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
438 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
439 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
440 (INTTYPEBITS): New macro, for clarity.
441 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
442 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
443 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
444 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
445 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
446
81755f69
JB
4472012-06-13 Juanma Barranquero <lekktu@gmail.com>
448
449 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
450
16192a57
GM
4512012-06-13 Glenn Morris <rgm@gnu.org>
452
453 * s/bsd-common.h (BSD4_3):
454 * s/usg5-4-common.h (USG5_4): No longer define; unused.
455
646b5f55
AS
4562012-06-13 Andreas Schwab <schwab@linux-m68k.org>
457
458 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
459 instead of union.
460 (XLI, XIL): Define.
1053a871
SM
461 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
462 Use them.
463 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 464 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 465 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
466 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
467 * frame.c (delete_frame): Remove outdated comment.
468 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
469 USE_LISP_UNION_TYPE.
470 (Fw32_unregister_hot_key): Likewise.
471 (Fw32_toggle_lock_key): Likewise.
472 * w32menu.c (add_menu_item): Likewise.
473 (w32_menu_display_help): Use XIL instead of checking
474 USE_LISP_UNION_TYPE.
475 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
476 (init_heap): Likewise.
477 * w32term.c (w32_read_socket): Update comment.
478
1d3823c9
GM
4792012-06-13 Glenn Morris <rgm@gnu.org>
480
c62ff706
GM
481 * s/usg5-4-common.h, src/s/unixware.h:
482 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
483
1d3823c9
GM
484 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
485
bfe3e0a2
PE
4862012-06-13 Paul Eggert <eggert@cs.ucla.edu>
487
488 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
489 * alloc.c (make_number) [!defined make_number]:
490 Remove, as lisp.h always defines this now.
491 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
492 (roundup_size): Verify that it is a power of 2.
493 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
494 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
495 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
496 -DUSE_LSB_TAG=0, to override the automatically-selected default.
497 USE_LSB_TAG now is always defined to be either 0 or 1.
498 All uses changed.
499 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
500 code works fine either way, and efficiency is not a concern here,
501 as the union type is for debugging, not for production.
502 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
503 Use an inline function on all platforms when using the union type,
504 since this is simpler and 'static inline' can be used portably
505 within Emacs now.
506 (LISP_INITIALLY_ZERO): New macro.
507 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
508 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
509
45fa9c0f
GM
5102012-06-12 Glenn Morris <rgm@gnu.org>
511
b4492cba
GM
512 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
513
514 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 515
45fa9c0f
GM
516 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
517 Move BROKEN_SIGIO to configure.
518
519 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
520 Move NO_TERMIO to configure.
521
0e25d334
CY
5222012-06-12 Chong Yidong <cyd@gnu.org>
523
524 * image.c (imagemagick_load_image): Use MagickFlattenImage if
525 MagickMergeImageLayers is undefined. Use pixel pusher loop if
526 MagickExportImagePixels is undefined.
527
43682bb6
PE
5282012-06-12 Paul Eggert <eggert@cs.ucla.edu>
529
530 * image.c (imagemagick_load_image): Remove unused label.
531
a9be7d2b
GM
5322012-06-11 Glenn Morris <rgm@gnu.org>
533
534 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
535 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
536 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
537 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
538
3017f87f
SM
5392012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
540
541 * alloc.c (make_byte_code): New function.
542 (Fmake_byte_code): Use it. Don't purify here.
543 * lread.c (read1): Use it as well to avoid extra allocation.
544
1b9b4cf4
CY
5452012-06-11 Chong Yidong <cyd@gnu.org>
546
547 * image.c (imagemagick_load_image): Implement transparency.
548
95988fcf
AS
5492012-06-10 Andreas Schwab <schwab@linux-m68k.org>
550
551 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
552 account for preceding backslashes. (Bug#11663)
553
cd4eb164
CY
5542012-06-09 Chong Yidong <cyd@gnu.org>
555
556 * term.c: Support italics in capable terminals (Bug#9652).
557 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
558 (turn_on_face): Output using TS_enter_italic_mode if available.
559 Don't handle unused blinking and alt-charset cases.
560 (turn_off_face): Handle italic case; discard unused tty_blinking_p
561 and tty_alt_charset_p cases.
562 (tty_capable_p, init_tty): Support italics.
563
564 * termchar.h (struct tty_display_info): Add field for italics.
565 Remove unused blink field.
566
567 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
568 Handle slant.
569
570 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
571 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
572 tty_alt_charset_p. Add tty_italic_p.
573
ff88beb8
MA
5742012-06-09 Michael Albinus <michael.albinus@gmx.de>
575
576 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
577 dbus_type_is_basic if available.
578 (xd_extract_signed, xd_extract_unsigned): Rename from
579 extract_signed and extract_unsigned, respectively. Adapt callers.
580
44286096
CY
5812012-06-09 Chong Yidong <cyd@gnu.org>
582
1682701f
CY
583 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
584
44286096
CY
585 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
586 case (Bug#9752).
587
d86feb17
PE
5882012-06-08 Paul Eggert <eggert@cs.ucla.edu>
589
590 * xdisp.c (vmessage): Treat frame message as multibyte.
591 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
592 would generate the diagnostic "Making \302\247 buffer-local while
593 let-bound!".
594
d5c20fe8
EZ
5952012-06-08 Eli Zaretskii <eliz@gnu.org>
596
597 * dispnew.c (showing_window_margins_p): Undo last change, which
598 was done due to an inadvertent commit.
599 (adjust_frame_glyphs_for_frame_redisplay): Do call
600 showing_window_margins_p.
601
513749ee
SM
6022012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
603
604 * eval.c (Fmake_var_non_special): New primitive.
605 (syms_of_eval): Defsubr it.
606 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
607
d4a8f5c1
JB
6082012-06-08 Juanma Barranquero <lekktu@gmail.com>
609
610 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
611 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
612
8bbbc977
EZ
6132012-06-08 Eli Zaretskii <eliz@gnu.org>
614
615 * alloc.c (allocate_vectorlike): Fix last change.
616
f3372c87
DA
6172012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
618
619 Block-based vector allocation of small vectors.
620 * lisp.h (struct vectorlike_header): New field `nbytes',
621 adjust comment accordingly.
622 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
623 to denote vector blocks. Adjust users (live_vector_p,
624 mark_maybe_pointer, valid_lisp_object_p) accordingly.
625 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
626 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
627 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
628 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
629 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
630 (roundup_size): New constant.
631 (struct vector_block): New data type.
632 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 633 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
634 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
635 (sweep_vectors): New functions.
636 (allocate_vectorlike): Return `zero_vector' as the only vector of
637 0 items. Allocate new vector from block if vector size is less than
638 or equal to VBLOCK_BYTES_MAX.
639 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
640 (init_alloc_once): Add call to init_vectors.
641
4f18a4ed
SM
6422012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
643
644 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
645
86f158bc
PE
6462012-06-07 Paul Eggert <eggert@cs.ucla.edu>
647
648 * doprnt.c (doprnt): Truncate multibyte char correctly.
649 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
650 would mishandle a string argument "Xc" if X was a multibyte
651 character of length 2: it would truncate after X's first byte
652 rather than including all of X.
653
c5cfcbe0
CY
6542012-06-06 Chong Yidong <cyd@gnu.org>
655
656 * buffer.c (word_wrap): Doc fix.
657
c05cf390
PE
6582012-06-04 Paul Eggert <eggert@cs.ucla.edu>
659
660 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
661
0c3461de
GM
6622012-06-03 Glenn Morris <rgm@gnu.org>
663
664 * xdisp.c (tool-bar-style): Doc fix.
665
c71232db
UM
6662012-06-03 Ulrich Müller <ulm@gentoo.org>
667
668 * Makefile.in (PAXCTL): Define.
669 (temacs$(EXEEXT)): Disable memory randomization for the temacs
670 binary via PaX flags if the paxctl utility is available.
671 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
672 Restore PaX flags to their default. (Bug#11398)
673
383f7350
CY
6742012-06-03 Chong Yidong <cyd@gnu.org>
675
676 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
677 buffer (Bug#11226).
678
5f2c76c6
CY
6792012-06-03 Chong Yidong <cyd@gnu.org>
680
681 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
682 (note_mode_line_or_margin_highlight): If there is no help echo,
683 use mode-line-default-help-echo. Handle the case where the mouse
684 position is past the end of the mode line string.
685
686 * buffer.c (buffer_local_value_1): New function, split from
687 Fbuffer_local_value; can return Qunbound.
688 (Fbuffer_local_value): Use it.
689 (Vmode_line_format): Docstring tweaks.
690
773d47f6
PE
6912012-06-02 Paul Eggert <eggert@cs.ucla.edu>
692
693 * sysdep.c (system_process_attributes): Improve comment.
694
f2d6a3df
SM
6952012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
696
697 * keyboard.c: Export real-this-command to Elisp.
698 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
699 and DEFVAR it. Update all users.
700
63810350
PE
7012012-06-02 Paul Eggert <eggert@cs.ucla.edu>
702
7bd5c1f4
PE
703 * minibuf.c (Fassoc_string): Remove duplicate declaration.
704
63810350
PE
705 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
706 Convert pctcpu and pctmem to Lisp float properly.
707 Let the compiler fold better, as 100.0/0x8000 is exact.
708
a2821611
AS
7092012-06-02 Andreas Schwab <schwab@linux-m68k.org>
710
711 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
712 cons_block.
713
5fceba1d
PE
7142012-06-01 Paul Eggert <eggert@cs.ucla.edu>
715
716 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
717
c98ff5dd
DA
7182012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
719
720 For a 'struct window', replace some Lisp_Object fields to
721 bitfields where appropriate, remove unused fields.
722 * window.h (struct window): Remove unused 'last_mark_x' and
723 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
724 change it's type from Lisp_Object to bitfield.
725 Change type of 'force_start', 'optional_new_start',
726 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
727 fields from Lisp_Object to bitfield. Adjust users accordingly.
728
ca34e0be
PE
7292012-05-31 Paul Eggert <eggert@cs.ucla.edu>
730
731 Pacify gcc -Wdouble-precision when using Xaw.
732 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
733 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
734 Use 'float' consistently, rather than 'float' in most places
735 and 'double' in a couple of places.
736
efc00ab1 7372012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
738
739 * xdisp.c (handle_stop): Detect whether we have overlay strings
740 loaded by testing it->current.overlay_string_index to be
741 non-negative, instead of checking whether n_overlay_strings is
742 positive. (Bug#11587)
743
efc00ab1 7442012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
745
746 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
747
748 * doc.c (Fsubstitute_command_keys): Doc fix.
749
efc00ab1 7502012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
751
752 * search.c (search_buffer): Remove calls to
753 r_alloc_inhibit_buffer_relocation, as it is now called by
754 maybe_unify_char, which was the cause of relocation of buffer text
755 in bug#11519.
756
efc00ab1 7572012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
758
759 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
760 for the duration of call to load_charset, to avoid problems with
761 callers of maybe_unify_char that access buffer text through C
762 pointers.
763
764 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
765 decrement the inhibition flag, instead of just setting or
766 resetting it.
767
ba93a187
PE
7682012-05-31 Paul Eggert <eggert@cs.ucla.edu>
769
770 Remove obsolete '#define static' cruft.
771 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
772 This #undef was "temporary" in 2000; it is no longer needed
773 now that '#define static' has gone away.
774 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
775 (gray_bitmap_bits): Remove; no longer needed.
776 All uses replaced with definiens.
777 * xterm.c: Include "bitmaps/gray.xbm".
778
9e4bf381
PE
7792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
780
781 Clean up __executable_start, monstartup when --enable-profiling.
782 The following changes affect the code only when profiling.
783 * dispnew.c (__executable_start): Rename from safe_bcopy.
784 Define only on platforms that need it.
785 * emacs.c: Include <sys/gmon.h> when profiling.
786 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
787 (__executable_start): Remove decl, since lisp.h does it now.
788 (safe_bcopy): Remove decl; no longer has that name.
789 (main): Coalesce #if into single bit of code, for simplicity.
790 Cast pointers to uintptr_t, since standard libraries want integers
791 and not pointers.
792 * lisp.h (__executable_start): New decl.
793
32d72c2f
GM
7942012-05-31 Glenn Morris <rgm@gnu.org>
795
796 * image.c (Fimagemagick_types): Doc fix.
797
baac5bc7
JM
7982012-05-30 Jim Meyering <meyering@redhat.com>
799
800 * callproc.c (Fcall_process_region): Include directory component
801 in mkstemp error message (Bug#11586).
802
72cb32cf
PE
8032012-05-30 Paul Eggert <eggert@cs.ucla.edu>
804
805 * alloc.c, lisp.h (make_pure_vector): Now static.
806
61b108cc
SM
8072012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
808
809 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
810 Move to byte-run.el.
811 (Fautoload): Do the hash-doc more carefully.
812 * data.c (Fdefalias): Purify definition, except for keymaps.
813 (Qdefun): Move from eval.c.
814 * lisp.h (Qdefun): Remove.
815 * lread.c (read1): Tiny simplification.
816
471fe23d
TN
8172012-05-29 Troels Nielsen <bn.troels@gmail.com>
818
934f3f58 819 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
820 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
821 Bug#9642, but explicitly check that the buffer the overlay would
822 be moved to is live and rearrange lines to make sure that errors
823 will not put the overlay in an inconsistent state.
824 (Fdelete_overlay): Cosmetics.
825
85d0efd1
EZ
8262012-05-28 Eli Zaretskii <eliz@gnu.org>
827
828 * w32term.c (my_bring_window_to_top): New function.
829 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
830 could be different from the original one.
831 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
832 (Bug#11513)
833
834 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
835 by calling BringWindowToTop.
836
837 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
838 (WM_EMACS_END): Increase by one.
839
da92a98c
PE
8402012-05-28 Paul Eggert <eggert@cs.ucla.edu>
841
842 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
843 This avoids undefined behavior that might cause the eassert
844 to not catch an out-of-range value.
845
74d1f848
JB
8462012-05-28 Juanma Barranquero <lekktu@gmail.com>
847
848 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
849 Update dependencies.
850
9e1a06fc
EZ
8512012-05-27 Eli Zaretskii <eliz@gnu.org>
852
853 * bidi.c (bidi_mirror_char): Fix last change.
854
f3dd7312
AS
8552012-05-27 Andreas Schwab <schwab@linux-m68k.org>
856
857 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
858 when referring to sectname field in printf format.
859
81899c91
PE
8602012-05-27 Paul Eggert <eggert@cs.ucla.edu>
861
57b81a9f
PE
862 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
863 Only r_alloc_inhibit_buffer_relocation needed to be added;
864 the others were already declared.
865
81899c91
PE
866 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
867 before checking whether it's out of range. Put the check inside
868 eassert. See
869 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
870
33017faf 8712012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
872
873 * callproc.c (Fcall_process): Restore a line that was accidentally
874 commented out in the 2011-02-13 change (bug#11547).
875
33017faf 8762012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
877
878 * lisp.h [REL_ALLOC]: Add prototypes for external functions
879 defined on ralloc.c.
880
881 * buffer.c [REL_ALLOC]: Remove prototypes of
882 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
883 they are now on lisp.h.
884
885 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
886
887 * search.c (search_buffer): Use it to inhibit relocation of buffer
888 text while re_search_2 is doing its job, because re_search_2 is
889 passed C pointers to buffer text. (Bug#11519)
890
23415acf
EZ
891 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
892 Update value to 24.
893
44e27368
EZ
894 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
895 state after an additional call to move_it_in_display_line_to, keep
896 the values of it->max_ascent and it->max_descent found for the
897 entire line.
898 (pos_visible_p): Revert the comparison against bottom_y to what it
899 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
900 (Bug#11464)
901
c1892f11
PE
9022012-05-26 Paul Eggert <eggert@cs.ucla.edu>
903
904 Fix coding-related core dumps with gcc -ftrapv.
905 The code was computing A - B, where A and B are pointers, and B is
906 random garbage. This can lead to core dumps on platforms that
907 have special pointer registers, and it also leads to core dumps on
908 x86-64 when compiled with gcc -ftrapv. The fix is to compute
909 A - B only when B is initialized properly.
910 * coding.c (coding_set_source, coding_set_destination): Return void.
911 (coding_change_source, coding_change_destinations): New functions,
912 with the old behaviors of coding_set_source and coding_set_destination.
913 All callers that need an offset changed to use these new functions.
914
eb7afdad
GM
9152012-05-26 Glenn Morris <rgm@gnu.org>
916
917 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
918
f12fdf02
EZ
9192012-05-26 Eli Zaretskii <eliz@gnu.org>
920
53a63be6 921 Extend mouse support on W32 text-mode console.
61b108cc
SM
922 * xdisp.c (draw_row_with_mouse_face):
923 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 924
eb3f6f01 925 * w32console.c: Include window.h.
61b108cc
SM
926 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
927 New functions.
eb3f6f01
EZ
928 (initialize_w32_display): Initialize mouse-highlight data.
929
53a63be6
EZ
930 * w32inevt.c: Include termchar.h and window.h.
931 (do_mouse_event): Support mouse-autoselect-window. When the mouse
932 moves, call note_mouse_highlight. If help_echo changed, call
933 gen_help_event to produce help-echo message in the echo area.
934 Call clear_mouse_face if mouse_face_hidden is set in the mouse
935 highlight info.
936
4cfd81f6
PE
9372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
938
939 * lread.c (read1): Simplify slightly to avoid an overflow warning
940 with GCC 4.7.0 on x86-64.
941
4446092a
EZ
9422012-05-26 Eli Zaretskii <eliz@gnu.org>
943
944 * bidi.c (bidi_mirror_char): Revert last change: an int is
945 definitely wide enough here.
946
42b2a986 9472012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 948
42b2a986 949 Fix integer width and related bugs (Bug#9874).
eb106a49 950 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
951 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
952 (string_bytes, check_sblock, allocate_string_data):
953 (compact_small_strings, Fmake_bool_vector, make_string)
954 (make_unibyte_string, make_multibyte_string)
955 (make_string_from_bytes, make_specified_string)
956 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
957 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
958 (mark_vectorlike):
959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
960 (allocate_pseudovector):
961 Use int, not EMACS_INT, where int is wide enough.
962 (inhibit_garbage_collection, Fgarbage_collect):
963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
964 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
965 int might not be wide enough.
966 (bidi_cache_search, bidi_cache_find, bidi_init_it)
967 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
968 (bidi_at_paragraph_end, bidi_find_paragraph_start)
969 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
970 (bidi_level_of_next_char, bidi_move_to_visually_next):
971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
972 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
973 (Fkill_buffer, Fset_buffer_major_mode)
974 (advance_to_char_boundary, Fbuffer_swap_text)
975 (Fset_buffer_multibyte, overlays_at, overlays_in)
976 (overlay_touches_p, struct sortvec, record_overlay_string)
977 (overlay_strings, recenter_overlay_lists)
978 (adjust_overlays_for_insert, adjust_overlays_for_delete)
979 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
980 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
981 (Foverlay_recenter, last_overlay_modification_hooks_used)
982 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
984 (validate_region): Omit unnecessary test for b <= e,
985 since that's guaranteed by the previous test.
d311d28c
PE
986 (adjust_overlays_for_delete): Avoid pos + length overflow.
987 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
988 (report_overlay_modification):
989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
990 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
991 Omit pointer cast, which isn't needed anyway, and doesn't work
992 after the EMACS_INT -> ptrdiff_t change.
02481186 993 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
994 * buffer.h: Adjust decls to match defn changes elsewhere.
995 (struct buffer_text, struct buffer):
996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
997 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
998 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
999 not int, to avoid needless 32-bit limit on 64-bit hosts.
1000 (exec_byte_code): Use tighter memory-full test, one that checks
1001 for alloca overflow. Don't compute the address of the object just
1002 before an array, as that's not portable. Use EMACS_INT, not
1003 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1004 * callint.c (Fcall_interactively):
1005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1006 * callproc.c (call_process_kill, Fcall_process):
1007 Don't assume pid_t fits into an Emacs fixnum.
1008 (call_process_cleanup, Fcall_process, child_setup):
1009 Don't assume pid_t fits into int.
1010 (call_process_cleanup, Fcall_process, delete_temp_file)
1011 (Fcall_process_region):
1012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1013 (Fcall_process): Simplify handling of volatile integers.
1014 Use int, not EMACS_INT, where int will do.
1015 * casefiddle.c (casify_object, casify_region, operate_on_word)
1016 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1018 (casify_object): Avoid integer overflow when overallocating buffer.
1019 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1020 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1021 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1022 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1023 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1024 integers are now checked earlier. All uses replaced with XINT.
1025 (ccl_driver):
1026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1027 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1028 (ccl_driver, Fregister_code_conversion_map):
1029 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1030 (resolve_symbol_ccl_program): Check that vector header is in range.
1031 Always copy the vector, so that we can check its contents reliably
1032 now rather than having to recheck each instruction as it's being
1033 executed. Check that vector words fit in 'int'.
1034 (ccl_get_compiled_code, Fregister_ccl_program)
1035 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1036 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1037 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1038 contents are in range.
1039 (Fccl_execute_on_string): Check that status is in range.
1040 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1041 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1042 Accept and return EMACS_INT, not int, because callers can pass values
1043 out of 'int' range.
1044 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1045 (multibyte_chars_in_text, parse_str_as_multibyte)
1046 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1047 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1048 (string_escape_byte8, Fget_byte):
1049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1050 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1051 avoid mishandling large integers.
1052 * character.h: Adjust decls to match defn changes elsewhere.
1053 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1054 (Ffind_charset_region):
1055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1056 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1057 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1058 Don't assume fixnum fits in int.
d311d28c
PE
1059 (load_charset_map_from_vector, Fmap_charset_chars):
1060 Remove now-unnecessary CHECK_NATNUMs.
1061 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1062 Don't rely on undefined behavior with signed left shift overflow.
1063 Don't assume unsigned int fits into fixnum, or that fixnum fits
1064 into unsigned int. Don't require max_code to be a valid fixnum;
1065 that's not true for gb10830 4-byte on a 32-bit host. Allow
1066 invalid_code to be a cons, for the same reason. Require code_offset
1067 to be a character. Avoid int overflow if max_char is close
1068 to INT_MAX.
1069 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1070 this is intended anyway and avoids some undefined behavior.
1071 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1072 INDEX_TO_CODE_POINT, as that's what it expects.
1073 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1074 * charset.h (DECODE_CHAR): Return int, not unsigned;
1075 this is what was intended anyway, and it avoids undefined behavior.
1076 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1077 integer-overflow issues.
1078 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1079 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1080 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1081 * chartab.c (Fmake_char_table, Fset_char_table_range)
1082 (uniprop_get_decoder, uniprop_get_encoder):
1083 Don't assume fixnum fits in int.
1084 * cmds.c (move_point): New function, that does the gist of
1085 Fforward_char and Fbackward_char, but does so while checking
1086 for integer overflow more accurately.
c96e5d6a 1087 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1088 (Fforward_line, Fend_of_line, internal_self_insert)
1089 (internal_self_insert):
1090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1091 Fix a FIXME, by checking for integer overflow when calculating
1092 target_clm and actual_clm.
1093 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1094 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1095 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1096 (coding_alloc_by_making_gap, alloc_destination)
1097 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1098 (encode_coding_utf_16, detect_coding_emacs_mule)
1099 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1100 (detect_coding_iso_2022, decode_coding_iso_2022)
1101 (encode_invocation_designation, encode_designation_at_bol)
1102 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1103 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1104 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1105 (encode_coding_ccl, encode_coding_raw_text)
1106 (detect_coding_charset, decode_coding_charset)
1107 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1108 (produce_composition, produce_charset, produce_annotation)
1109 (decode_coding, handle_composition_annotation)
1110 (handle_charset_annotation, consume_chars, decode_coding_gap)
1111 (decode_coding_object, encode_coding_object, detect_coding_system)
1112 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1113 (code_convert_region, code_convert_string)
8f50130c
PE
1114 (Fdefine_coding_system_internal)
1115 (coding_set_source, coding_set_destination):
d311d28c
PE
1116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1117 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1118 (Fdefine_coding_system_internal):
1119 Don't assume fixnums fit in int.
1120 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1121 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1122 (Funencodable_char_position, Fcheck_coding_systems_region)
1123 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1125 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1126 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1127 Don't access memory outside of the args array.
d311d28c 1128 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1129 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1130 result of ENCODE_CHAR.
d311d28c
PE
1131 * coding.h: Adjust decls to match defn changes elsewhere.
1132 (struct coding_system):
1133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1134 * composite.c (get_composition_id, find_composition)
1135 (run_composition_function, update_compositions)
1136 (compose_text, composition_gstring_put_cache)
1137 (composition_gstring_p, composition_gstring_width)
1138 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1139 (composition_compute_stop_pos, composition_reseat_it)
1140 (composition_update_it, struct position_record)
1141 (find_automatic_composition, composition_adjust_point)
1142 (Fcomposition_get_gstring, Ffind_composition_internal):
1143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1144 (update_compositions):
1145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1146 * composite.h: Adjust decls to match defn changes elsewhere.
1147 (struct composition):
1148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1149 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1150 Do not attempt to compute the address of the object just before a
1151 buffer; this is not portable.
1152 (Faref, Faset):
1153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1154 (Faset): Use int, not EMACS_INT, where int is wide enough.
1155 (Fstring_to_number): Don't assume fixnums fit in int.
1156 (Frem): Don't assume arg is nonnegative.
1157 * dbusbind.c (xd_append_arg): Check for integers out of range.
1158 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1159 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1160 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1161 (xd_get_connection_references): Return ptrdiff_t, not int.
1162 All uses changed.
1163 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1164 (xd_read_message_1):
1165 Use int, not unsigned, where the dbus API uses int.
1166 (Fdbus_message_internal): Don't overflow mtype.
1167 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1168 * dired.c (directory_files_internal, file_name_completion, scmp)
1169 (file_name_completion_stat):
1170 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1171 (file_name_completion): Don't overflow matchcount.
1172 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1173 * dispextern.h: Adjust decls to match defn changes elsewhere.
1174 (struct text_pos, struct glyph, struct bidi_saved_info)
1175 (struct bidi_string_data, struct bidi_it, struct composition_it)
1176 (struct it):
1177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1178 (struct display_pos, struct composition_it, struct it):
1179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1180 * dispnew.c (increment_matrix_positions)
1181 (increment_row_positions, mode_line_string)
1182 (marginal_area_string):
1183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1184 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1186 (duration_to_sec_usec): New function, to check for overflow better.
1187 (Fsleep_for, sit_for): Use it.
1188 * doc.c (get_doc_string, store_function_docstring):
1189 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1190 (get_doc_string, Fsnarf_documentation):
1191 Use int, not EMACS_INT, where int is wide enough.
1192 (get_doc_string):
1193 Use SAFE_ALLOCA, not alloca.
1194 Check for overflow when converting EMACS_INT to off_t.
1195 * doprnt.c (doprnt):
1196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1197 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1198 Don't assume uid_t fits into fixnum.
1199 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1200 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1201 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1202 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1203 (general_insert_function)
1204 (Finsert_char, make_buffer_string, make_buffer_string_both)
1205 (update_buffer_properties, Fbuffer_substring)
1206 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1207 (Fsubst_char_in_region, check_translation)
1208 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1209 (transpose_markers, Ftranspose_regions):
1210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1211 (clip_to_bounds): Move to lisp.h as an inline function).
1212 (Fconstrain_to_field): Don't assume integers are nonnegative.
1213 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1214 (Fsubst_char_in_region, Fsave_restriction):
1215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1216 (Femacs_pid): Don't assume pid_t fits into fixnum.
1217 (lo_time): Use int, not EMACS_INT, when int suffices.
1218 (lisp_time_argument): Check for usec out of range.
1219 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1220 (Fuser_login_name, Fuser_full_name): Signal an error
1221 if a uid argument is out of range, rather than relying on
1222 undefined behavior.
c8d5c857
PE
1223 (Fformat_time_string): Remove now-unnecessary check.
1224 lisp_time_argument checks for out-of-range usec now.
243e0530 1225 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1226 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1227 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1228 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1229 (init_cmdargs, Fdump_emacs):
1230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1231 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1232 the bottom (typically) 32 bits of the fixnum.
1233 * eval.c (specpdl_size, call_debugger):
1234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1235 (when_entered_debugger, Fbacktrace_debug):
1236 Don't assume fixnum can fit in int.
1237 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1238 the object just before a buffer; this is not portable.
1239 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1240 (grow_specpdl, unbind_to):
1241 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1242 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1243 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1244 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1245 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1246 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1248 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1249 (a_write, e_write):
1250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1251 (Fcopy_file, non_regular_nbytes, read_non_regular)
1252 (Finsert_file_contents):
1253 Use int, not EMACS_INT, where int is wide enough.
1254 (READ_BUF_SIZE): Verify that it fits in int.
1255 (Finsert_file_contents): Check that counts are in proper range,
1256 rather than assuming fixnums fit into ptrdiff_t etc.
1257 Don't assume fixnums fit into int.
125b3835 1258 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1259 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1260 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1261 (string_char_to_byte, string_byte_to_char)
1262 (string_make_multibyte, string_to_multibyte)
1263 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1264 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1265 (substring_both, Fdelete, internal_equal, Ffillarray)
1266 (Fclear_string, mapcar1)
1267 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1268 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1269 (larger_vector, make_hash_table, maybe_resize_hash_table)
1270 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1271 (Fmaphash, secure_hash):
1272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1273 (concat): Check for string index and length overflow.
1274 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1275 (Frequire):
1276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1277 (larger_vector): New API (vec, incr_min, size_max) replaces old
1278 one (vec, new_size, init). This catches size overflow.
1279 INIT was removed because it was always Qnil.
1280 All callers changed.
1281 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1282 the upper bound on a hash table index size.
1283 (make_hash_table, maybe_resize_hash_table): Use it.
1284 (secure_hash): Computer start_byte and end_byte only after
1285 they're known to be in ptrdiff_t range.
1286 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1287 (Ffont_get_glyphs, Ffont_at):
1288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1289 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1290 (Flist_fonts, Fopen_font):
1291 Don't assume fixnum can fit in int.
1292 (check_gstring): Don't assume index can fit in int.
1293 (font_match_p): Check that fixnum is a character, not a nonnegative
1294 fixnum, since the later code needs to stuff it into an int.
1295 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1296 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1297 conversion overflow issues.
1298 (Fopen_font): Check for integer out of range.
1299 (Ffont_get_glyphs): Don't assume index can fit in int.
1300 * font.h: Adjust decls to match defn changes elsewhere.
1301 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1302 integer overflow.
1303 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1304 printmax_t, where ptrdiff_t is wide enough.
1305 (Finternal_char_font):
1306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1307 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1308 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1309 (Fset_frame_position, x_set_frame_parameters)
1310 (x_set_line_spacing, x_set_border_width)
1311 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1312 Check that fixnums are in proper range for system types.
1313 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1315 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1316 Use SAFE_ALLOCA_LISP, not alloca.
1317 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1318 intptr_t is wide enough.
1319 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1320 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1321 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1322 Check for fixnum out of range.
1323 * ftfont.c (ftfont_list): Don't assume index fits in int.
1324 Check that fixnums are in proper range for system types.
1325 (ftfont_shape_by_flt):
1326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1327 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1328 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1329 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1330 Check that fixnums are in proper range for system types.
1331 * gnutls.h: Adjust decls to match defn changes elsewhere.
1332 * gtkutil.c (xg_dialog_run):
1333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1334 (update_frame_tool_bar):
1335 Check that fixnums are in proper range for system types.
1336 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1337 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1338 * indent.c (last_known_column, last_known_column_point):
1339 (current_column_bol_cache):
1340 (skip_invisible, current_column, check_display_width):
1341 (check_display_width, scan_for_column, current_column_1)
1342 (Findent_to, Fcurrent_indentation, position_indentation)
1343 (indented_beyond_p, Fmove_to_column, compute_motion):
1344 (Fcompute_motion, Fvertical_motion):
1345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1346 (last_known_column_modified): Use EMACS_INT, not int.
1347 (check_display_width):
1348 (Fcompute_motion):
1349 Check that fixnums and floats are in proper range for system types.
1350 (compute_motion): Don't assume index or fixnum fits in int.
1351 (compute_motion, Fcompute_motion):
1352 Use int, not EMACS_INT, when it is wide enough.
1353 (vmotion): Omit local var start_hpos that is always 0; that way
1354 we don't need to worry about overflow in expressions involving it.
1355 * indent.h: Adjust decls to match defn changes elsewhere.
1356 (struct position):
1357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1358 Use int, not EMACS_INT, where int is wide enough.
1359 Remove unused members ovstring_chars_done and tab_offset;
1360 all uses removed.
1361 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1362 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1363 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1364 (make_gap, copy_text, insert, insert_and_inherit)
1365 (insert_before_markers, insert_before_markers_and_inherit)
1366 (insert_1, count_combining_before, count_combining_after)
1367 (insert_1_both, insert_from_string)
1368 (insert_from_string_before_markers, insert_from_string_1)
1369 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1370 (adjust_after_replace, adjust_after_insert, replace_range)
1371 (replace_range_2, del_range, del_range_1, del_range_byte)
1372 (del_range_both, del_range_2, modify_region)
1373 (prepare_to_modify_buffer, signal_before_change)
1374 (signal_after_change, Fcombine_after_change_execute):
1375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1376 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1377 (balance_an_interval, split_interval_right, split_interval_left)
1378 (find_interval, next_interval, update_interval)
1379 (adjust_intervals_for_insertion, delete_node, delete_interval)
1380 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1381 (static_offset_intervals, offset_intervals)
1382 (merge_interval_right, merge_interval_left, make_new_interval)
1383 (graft_intervals_into_buffer, temp_set_point_both)
1384 (temp_set_point, set_point, adjust_for_invis_intang)
1385 (set_point_both, move_if_not_intangible, get_property_and_range)
1386 (get_local_map, copy_intervals, copy_intervals_to_string)
1387 (compare_string_intervals, set_intervals_multibyte_1):
1388 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1389 * intervals.h: Adjust decls to match defn changes elsewhere.
1390 (struct interval):
1391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1392 * keyboard.c (this_command_key_count, this_single_command_key_start)
1393 (before_command_key_count, before_command_echo_length, echo_now)
1394 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1395 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1396 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1397 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1398 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1399 (last_non_minibuf_size, last_point_position, echo_truncate)
1400 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1401 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1402 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1403 (stuff_buffered_input):
1404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1405 (last_auto_save, command_loop_1, read_char):
1406 Use EMACS_INT, not int, to avoid integer overflow.
1407 (record_char): Avoid overflow in total_keys computation.
1408 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1409 * keyboard.h: Adjust decls to match defn changes elsewhere.
1410 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1411 (Fkey_description, Fdescribe_vector, Flookup_key):
1412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1413 (click_position): New function, to check that positions are in range.
1414 (Fcurrent_active_maps):
1415 (describe_command):
1416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1417 (Faccessible_keymaps, Fkey_description):
1418 (preferred_sequence_p):
1419 Don't assume fixnum can fit into int.
1420 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1421 Check for integer overflow in size calculations.
1422 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1423 avoid mishandling large integers.
1424 * lisp.h: Adjust decls to match defn changes elsewhere.
1425 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1426 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1427 (struct Lisp_Marker):
1428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1429 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1430 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1431 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1432 All callers changed.
1433 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1434 Assume the arg has valid form, since it always does.
1435 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1436 unsigned integer system type.
1437 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1438 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1439 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1440 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1441 (duration_to_sec_usec): New decl.
1442 * lread.c (read_from_string_index, read_from_string_index_byte)
1443 (read_from_string_limit, readchar, unreadchar, openp)
1444 (read_internal_start, read1, oblookup):
1445 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1446 (Fload, readevalloop, Feval_buffer, Feval_region):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 (openp): Check for out-of-range argument to 'access'.
1449 (read1): Use int, not EMACS_INT, where int is wide enough.
1450 Don't assume fixnum fits into int.
6efdadfd 1451 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1452 (read_filtered_event): Use duration_to_sec_usec
1453 to do proper overflow checking on durations.
d311d28c
PE
1454 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1455 in size calculation.
1456 (Fexecute_kbd_macro):
1457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1458 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1459 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1460 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1461 (set_marker_both, set_marker_restricted_both, marker_position)
1462 (marker_byte_position, Fbuffer_has_markers_at):
1463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1464 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1465 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1466 It now merely ensures that the menu is large enough, without
1467 necessarily growing it, as this avoids some integer overflow issues.
1468 All callers changed.
1469 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1471 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1472 Use SAFE_ALLOCA_LISP, not alloca.
1473 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1474 to EMACS_INT. Check that fixnums are in proper range for system types.
1475 * minibuf.c (minibuf_prompt_width, string_to_object)
1476 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1477 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1479 (get_minibuffer, read_minibuf_unwind):
1480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1481 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1482 this simplifies overflow checking. All callers changed.
1483 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1484 (Ftest_completion):
1485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1486 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1487 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1488 Check that fixnums are in proper range for system types.
1489 (Fx_create_frame, Fx_show_tip):
1490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1491 * nsfont.m (ns_findfonts, nsfont_list_family):
1492 Don't assume fixnum fits in long.
1493 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1495 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1496 wide enough.
17fdb222 1497 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1499 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1500 (PRINTDECLARE, PRINTPREPARE):
1501 (strout, print_string):
1502 (print, print_preprocess, print_check_string_charset_prop)
1503 (print_object):
1504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1505 (PRINTDECLARE):
1506 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1508 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1509 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1510 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1511 (print_error_message): Use SAFE_ALLOCA, not alloca.
1512 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1513 (print_depth, new_backquote_output, print_number_index):
1514 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1515 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1516 (Fset_process_window_size, Fformat_network_address)
1517 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1518 (sigchld_handler):
d311d28c 1519 Check that fixnums are in proper range for system types.
d44287d4 1520 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1521 Check for process-ids out of pid_t range rather than relying on
1522 undefined behavior.
e4d81efc 1523 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1524 (Fformat_network_address, read_process_output, send_process)
1525 (Fprocess_send_region, status_notify):
1526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1527 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1528 (wait_reading_process_output, read_process_output, exec_sentinel):
1529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1530 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1531 (Faccept_process_output): Use duration_to_sec_usec to do proper
1532 overflow checking on durations.
dde14581
PE
1533 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1534 Don't assume pid_t fits in int.
02481186
PE
1535 * process.h (struct Lisp_Process): Members tick and update_tick
1536 are now of type EMACS_INT, not int.
b62b53e8
PE
1537 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1538 configured --with-wide-int.
d311d28c
PE
1539 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1540 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1541 * search.c (looking_at_1, string_match_1):
1542 (fast_string_match, fast_c_string_match_ignore_case)
1543 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1544 (scan_newline, find_before_next_newline, search_command)
1545 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1546 (set_search_regs, wordify):
1547 (Freplace_match):
1548 (Fmatch_data):
1549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1550 (string_match_1, search_buffer, set_search_regs):
1551 (Fmatch_data):
1552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1553 (wordify): Check for overflow in size calculation.
1554 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1555 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1556 Check that fixnums are in proper range for system types.
1557 * sound.c (struct sound_device)
1558 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1560 (Fplay_sound_internal):
1561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1562 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1563 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1564 (Fparse_partial_sexp):
1565 Don't assume fixnums can fit in int.
1566 (struct lisp_parse_state, find_start_pos, find_start_value)
1567 (find_start_value_byte, find_start_begv)
1568 (update_syntax_table, char_quoted, dec_bytepos)
1569 (find_defun_start, prev_char_comend_first, back_comment):
1570 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1571 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1573 (Finternal_describe_syntax_value): Check that match_lisp is a
1574 character, not an integer, since the code stuffs it into int.
1575 (scan_words, scan_sexps_forward):
1576 Check that fixnums are in proper range for system types.
1577 (Fforward_word):
1578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1579 (scan_sexps_forward):
1580 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1581 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1582 * syntax.h: Adjust decls to match defn changes elsewhere.
1583 (struct gl_state_s):
1584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1585 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1586 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1587 * sysdep.c (wait_for_termination_1, wait_for_termination)
1588 (interruptible_wait_for_termination, mkdir):
1589 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1590 (emacs_read, emacs_write):
1591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1592 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1593 and double all fit in int.
d311d28c
PE
1594 * term.c (set_tty_color_mode):
1595 Check that fixnums are in proper range for system types.
1596 * termhooks.h (struct input_event):
1597 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1598 * textprop.c (validate_interval_range, interval_of)
1599 (Fadd_text_properties, set_text_properties_1)
1600 (Fremove_text_properties, Fremove_list_of_text_properties)
1601 (Ftext_property_any, Ftext_property_not_all)
1602 (copy_text_properties, text_property_list, extend_property_ranges)
1603 (verify_interval_modification):
1604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1605 (Fnext_single_char_property_change)
1606 (Fprevious_single_char_property_change):
1607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1608 (copy_text_properties):
1609 Check for integer overflow in index calculation.
d311d28c
PE
1610 * undo.c (last_boundary_position, record_point, record_insert)
1611 (record_delete, record_marker_adjustment, record_change)
1612 (record_property_change):
1613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1614 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1616 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1617 (Fx_hide_tip, Fx_file_dialog):
1618 * w32menu.c (set_frame_menubar):
1619 Use ptrdiff_t, not int, for consistency with rest of code.
1620 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1621 (select_window, Fdelete_other_windows_internal)
1622 (window_scroll_pixel_based, window_scroll_line_based)
1623 (Frecenter, Fset_window_configuration):
1624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1625 (Fset_window_hscroll, run_window_configuration_change_hook)
1626 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1627 (Fscroll_other_window, Frecenter):
d311d28c
PE
1628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1629 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1630 Don't assume fixnum fits in int.
1631 (Fset_window_scroll_bars):
1632 Check that fixnums are in proper range for system types.
1633 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1634 (string_pos, c_string_pos, number_of_chars, init_iterator)
1635 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1636 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1637 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1638 (face_before_or_after_it_pos, handle_invisible_prop)
1639 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1640 (display_prop_intangible_p, string_buffer_position_lim)
1641 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1642 (get_overlay_strings_1, get_overlay_strings)
1643 (iterate_out_of_display_property, forward_to_next_line_start)
1644 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1645 (get_next_display_element, set_iterator_to_next)
1646 (get_visually_first_element, compute_stop_pos_backwards)
1647 (handle_stop_backwards, next_element_from_buffer)
1648 (move_it_in_display_line_to, move_it_in_display_line)
1649 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1650 (add_to_log, message_dolog, message_log_check_duplicate)
1651 (message2, message2_nolog, message3, message3_nolog
1652 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1653 (current_message_1, truncate_echo_area, truncate_message_1)
1654 (set_message, set_message_1, store_mode_line_noprop)
1655 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1656 (text_outside_line_unchanged_p, check_point_in_composition)
1657 (reconsider_clip_changes)
1658 (redisplay_internal, set_cursor_from_row, try_scrolling)
1659 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1660 (redisplay_window, find_last_unchanged_at_beg_row)
1661 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1662 (trailing_whitespace_p, find_row_edges, display_line)
1663 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1664 (display_mode_element, store_mode_line_string)
1665 (pint2str, pint2hrstr, decode_mode_spec)
1666 (display_count_lines, display_string, draw_glyphs)
1667 (x_produce_glyphs, x_insert_glyphs)
1668 (rows_from_pos_range, mouse_face_from_buffer_pos)
1669 (fast_find_string_pos, mouse_face_from_string_pos)
1670 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1672 (safe_call, init_from_display_pos, handle_fontified_prop)
1673 (handle_single_display_spec, load_overlay_strings)
1674 (with_echo_area_buffer, setup_echo_area_for_printing)
1675 (display_echo_area, echo_area_display)
1676 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1677 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1678 (redisplay_window, dump_glyph_row, display_mode_line)
1679 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1680 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1682 (handle_single_display_spec, build_desired_tool_bar_string)
1683 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1684 (get_specified_cursor_type):
1685 Check that fixnums are in proper range for system types.
1686 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1687 (Flookup_image_map):
1688 Don't assume fixnums fit in int.
1689 (compare_overlay_entries):
1690 Avoid mishandling comparisons due to subtraction overflow.
1691 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1692 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1693 (handle_tool_bar_click):
1694 Use int, not unsigned, since we prefer signed and the signedness
1695 doesn't matter here.
1696 (get_next_display_element, next_element_from_display_vector):
1697 Use int, not EMACS_INT, when int is wide enough.
1698 (start_hourglass): Use duration_to_sec_usec to do proper
1699 overflow checking on durations.
1700 * xfaces.c (Fbitmap_spec_p):
1701 Check that fixnums are in proper range for system types.
1702 (compare_fonts_by_sort_order):
1703 Avoid mishandling comparisons due to subtraction overflow.
1704 (Fx_family_fonts, realize_basic_faces):
1705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1706 (Fx_family_fonts):
1707 Don't assume fixnum fits in int.
1708 Use SAFE_ALLOCA_LISP, not alloca.
1709 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1710 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1711 (face_at_buffer_position, face_for_overlay_string)
1712 (face_at_string_position):
1713 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1714 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1715 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1716 (Fx_show_tip):
1717 Check that fixnums are in proper range for system types.
1718 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1719 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1721 (Fx_change_window_property): Don't assume fixnums fit in int.
1722 * xfont.c (xfont_chars_supported):
1723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1724 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1725 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1727 * xml.c (parse_region):
1728 * xrdb.c (magic_file_p):
1729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1730 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1731 (x_get_local_selection, x_reply_selection_request)
1732 (x_handle_selection_request, wait_for_property_change):
1733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1734 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1735 short is wide enough.
1736 (x_send_client_event): Don't assume fixnum fits in int.
1737 * xterm.c (x_x_to_emacs_modifiers):
1738 Don't assume EMACS_INT overflows nicely into int.
1739 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1740 may come from Lisp.
1741 (handle_one_xevent): NATNUMP can eval its arg twice.
1742 (x_connection_closed):
1743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1744 * xterm.h: Adjust decls to match defn changes elsewhere.
1745 (struct scroll_bar): Use struct vectorlike_header
1746 rather than rolling our own approximation.
1747 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1748
c6574eb5
GM
17492012-05-25 Glenn Morris <rgm@gnu.org>
1750
1751 * lisp.mk (lisp): Update for more files being compiled now.
1752
e8d32c7e
SM
17532012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1754
48def666
SM
1755 * lread.c: Remove `read_pure' which makes no difference.
1756 (read_pure): Remove var.
1757 (unreadpure): Remove function.
1758 (readevalloop): Don't call read_list with -1 flag.
1759 (read1, read_vector): Don't test read_pure any more.
1760 (read_list): Simplify.
1761
e8d32c7e
SM
1762 * fileio.c, character.h: Minor style tweaks.
1763
4b2addb7
DA
17642012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1765
1766 * window.h (clip_changed): Remove useless declaration.
1767
584461b2
JB
17682012-05-22 Juanma Barranquero <lekktu@gmail.com>
1769
1770 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1771 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1772
34374650
PE
17732012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 Remove src/m/*.
1776 This directory predates autoconf and is no longer needed nowadays.
1777 Move its few remaining bits of functionality to where they're needed.
1778 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1779 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1780 * m/template.h: Remove.
1781 * Makefile.in (M_FILE): Remove. All uses removed.
1782 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1783 * lisp.h (USE_LSB_TAG):
1784 * mem-limits.h (EXCEEDS_LISP_PTR):
1785 Use VAL_MAX, not VALBITS, in #if.
1786 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1787 (EMACS_UINT): Define unconditionally now.
1788 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1789 (BITS_PER_EMACS_INT): New constants, replacing
1790 what used to be in config.h, but not useful in #if.
1791 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1792 define them any more.
1793 (VAL_MAX): New macro.
1794 (VALMASK): Use it.
1795 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1796 BITS_PER_EMACS_INT, in #if.
1797 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1798 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1799 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1800 * s/ms-w32.h (DATA_START):
1801 Move here from removed file m/intel386.h.
1802 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1803 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1804
261cb4bb
PE
18052012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1806
1807 Assume C89 or later.
1808 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1809 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1810 (xrealloc):
1811 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1812 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1813 * textprop.c, tparam.c (NULL): Remove.
1814 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1815 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1816 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1817 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1818 * xterm.c (input_signal_count): Assume volatile works.
1819
ff23cd9f
KB
18202012-05-21 Ken Brown <kbrown@cornell.edu>
1821
1822 * xgselect.c (xg_select): Fix first argument in call to 'select'
1823 (bug#11508).
1824
1b170bc6
KB
18252012-05-20 Ken Brown <kbrown@cornell.edu>
1826
1827 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1828 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1829
b2f4d39f
KB
18302012-05-19 Ken Brown <kbrown@cornell.edu>
1831
1832 * xfns.c (x_in_use): Remove `static' qualifier.
1833 * xterm.h (x_in_use): Declare.
1834 * xgselect.c: Include xterm.h.
1835 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1836 and `display_arg' (bug#9754).
1837
003fdae2
PE
18382012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1839
9232a6d9
PE
1840 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1841
003fdae2
PE
1842 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1843 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1844
784b56e2
EZ
18452012-05-18 Eli Zaretskii <eliz@gnu.org>
1846
1847 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1848
1849 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1850 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1851
1852 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1853 reference to image_cache->refcount.
1854 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1855
a0a79cde
JL
18562012-05-17 Juri Linkov <juri@jurta.org>
1857
1858 * search.c (Fword_search_regexp, Fword_search_backward)
1859 (Fword_search_forward, Fword_search_backward_lax)
1860 (Fword_search_forward_lax): Move functions to isearch.el
1861 (bug#10145, bug#11381).
1862
b0572523
PE
18632012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1864
1865 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1866
9660f5fc
SM
18672012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1868
1869 * lread.c (init_obarray): Declare Qt and Qnil as special.
1870
4374de83
GM
18712012-05-14 Glenn Morris <rgm@gnu.org>
1872
1873 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1874 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1875
dc44c39a
PE
18762012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1877
078c97cb
PE
1878 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1879
dc44c39a
PE
1880 * unexaix.c: Port to more-recent AIX compilers.
1881 (report_error, report_error_1, make_hdr, copy_sym)
1882 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1883 Make arguments const char *, not char *, to avoid violations of C
1884 standard and to fix some AIX warnings reported by Gilles Pion.
1885
e18afed7 18862012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1887
1888 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1889 already have overlays loaded.
1890 (handle_single_display_spec): Before returning without displaying
1891 fringe bitmap, synchronize the bidi iterator with the main display
1892 iterator, by calling iterate_out_of_display_property.
1893 (iterate_out_of_display_property): Detect buffer iteration by
1894 testing that it->string is a Lisp string.
1895 (get_next_display_element): When the current object is exhausted,
1896 and there's something on it->stack, call set_iterator_to_next to
1897 proceed with what's on the stack, instead of returning zero.
1898 (set_iterator_to_next): If called at the end of a Lisp string,
1899 proceed to consider_string_end without incrementing string
1900 position. Don't increment display vector index past the end of
1901 the display vector. (Bug#11417)
c8fb9dc6
EZ
1902 (pos_visible_p): Don't report a position visible when move_it_to
1903 stopped at the last line of window, which happens to be scanned
1904 backwards by the bidi iteration. (Bug#11464)
ac268e67 1905
e18afed7 19062012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1907
1908 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1909 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1910 are on a TTY, and thus unable to display on the fringes.
1911 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1912 so we need to signal to the caller that this is a "replacing"
1913 display spec. This fixes display when the spec is invalid or we
1914 are on a TTY.
1915
e18afed7 19162012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1917
1918 * unexaix.c (make_hdr): Fix typo in prototype.
1919 This bug broke the build on AIX. Problem reported by Gilles Pion.
1920
9d0a235a
MA
19212012-05-14 Michael Albinus <michael.albinus@gmx.de>
1922
1923 * keyboard.c (kbd_buffer_get_event): Read special events also in
1924 batch mode. (Bug#11415)
1925
9e6b06ed
GM
19262012-05-12 Glenn Morris <rgm@gnu.org>
1927
1928 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1929
c1a1d7a3
EZ
19302012-05-12 Eli Zaretskii <eliz@gnu.org>
1931
1932 * lisp.mk (lisp): Add newcomment.elc.
1933
3fe7cdc8
GM
19342012-05-12 Glenn Morris <rgm@gnu.org>
1935
1936 * Makefile.in (MKDIR_P): New, set by configure.
1937 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1938
53f7d2c0
PE
19392012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1940
1941 Remove unused function hourglass_started.
1942 * dispextern.h (hourglass_started):
1943 * w32fns.c (hourglass_started):
1944 * xdisp.c (hourglass_started): Remove.
1945
75aafb17
JB
19462012-05-10 Juanma Barranquero <lekktu@gmail.com>
1947
1948 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1949 Update dependencies.
1950
12959e8e
PE
19512012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1952
97107e2e
PE
1953 * xgselect.c (xg_select): Put maxfds+1 into a var.
1954 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1955
12959e8e
PE
1956 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1957
836d29b3
DA
19582012-05-10 Dave Abrahams <dave@boostpro.com>
1959
1960 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1961 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1962
5cb67954
MA
19632012-05-09 Michael Albinus <michael.albinus@gmx.de>
1964
1965 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1966 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1967 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1968 Initialize xd_registered_buses.
1969
3478ec45
PE
19702012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1971
b263a6b0
PE
1972 Untag more efficiently if USE_LSB_TAG.
1973 This is based on a proposal by YAMAMOTO Mitsuharu in
1974 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1975 For an admittedly artificial (nth 8000 longlist) benchmark on
1976 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1977 Emacs's overall text size by 1%.
1978 * lisp.h (XUNTAG): New macro.
1979 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1980 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1981 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1982 * eval.c (Fautoload):
1983 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1984 * frame.h (XFRAME): Use XUNTAG.
1985
3478ec45
PE
1986 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1987 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1988 Remove unportable assumptions about print widths of types like
1989 dbus_uint32_t.
1990 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1991 intptr_t when converting between pointer and integer, to avoid GCC
1992 warnings about wrong width.
1993
666b903b 19942012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1995
1996 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1997 stack for each reader_thread, instead of defaulting to 8MB
1998 determined by the linker. This avoids failures in creating
1999 subprocesses on Windows 7, see the discussion in this thread:
2000 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2001
b120cc17
JC
20022012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2003
2004 Fix up display of the *Minibuf-0* buffer in the mini window.
2005 * keyboard.c (read_char): Don't clear the echo area if there's no
2006 message to clear.
2007 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2008 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2009
9a4b36f8
MA
20102012-05-07 Michael Albinus <michael.albinus@gmx.de>
2011
2012 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2013 batch mode.
2014
e5f9458f
CY
20152012-05-06 Chong Yidong <cyd@gnu.org>
2016
2017 * lisp.mk (lisp): Update.
2018
eceeb5fc 20192012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2020
2021 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2022
71873e2b
SM
20232012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2024
2025 * data.c (PUT_ERROR): New macro.
2026 (syms_of_data): Use it. Add new error type `user-error'.
2027 * undo.c (user_error): New function.
2028 (Fprimitive_undo): Use it.
2029 * print.c (print_error_message): Adjust print style for `user-error'.
2030 * keyboard.c (user_error): New function.
2031 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2032
ab0fa4e4
PE
20332012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 Do not limit current-time-string to years 1000..9999.
2036 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2037 (Fcurrent_time_string): Support any year that is supported by the
2038 underlying localtime representation. Don't use asctime, as it
2039 has undefined behavior for years outside the range -999..9999.
2040
7ed806a7
PE
20412012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2042
2043 Fix race conditions involving setenv, gmtime, localtime, asctime.
2044 Without this fix, interrupts could mess up code that uses these
2045 nonreentrant functions, since setting TZ invalidates existing
2046 tm_zone or tzname values, and since most of these functions return
2047 pointers to static storage.
2048 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2049 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2050 Grow the critical sections to include not just invoking
2051 localtime/gmtime, but also accessing these functions' results
2052 including their tm_zone values if any, and any related TZ setting.
2053 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2054 so that the struct tm is saved in the critical section.
2055 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2056 motivated by the fact that memory allocation needs to be outside
2057 the critical section.
2058
0c16dfed
DA
20592012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2060
2061 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2062 with RESET_INTERVAL.
2063
2064 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2065 Remove duplicated buffer name initialization.
2066
3f83ace8
JM
20672012-05-02 Jim Meyering <jim@meyering.net>
2068
2069 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2070
c7b8541e
JM
2071 * xfns.c (x_window): Use xstrdup (Bug#11375).
2072
90207a15 20732012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2074
2075 * xdisp.c (pos_visible_p): If already at a newline from the
2076 display string before the 'while' loop, don't walk back the glyphs
2077 from it3.glyph_row. Solves assertion violation when the display
2078 string begins with a newline (egg.el). (Bug#11367)
2079
b593d6a9
AH
20802012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2081
2082 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2083 Move to simple.el.
2084
4737362e
GM
20852012-05-01 Glenn Morris <rgm@gnu.org>
2086
99cf43f9
GM
2087 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2088 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2089 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2090 All were removed before 23.1.
2091
9311dcff
GM
2092 * dispnew.c: Remove HAVE_LIBNCURSES test;
2093 it is always true on relevant platforms.
2094
4d5c6349
GM
2095 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2096 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2097
4737362e
GM
2098 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2099
74dd3a6b
AS
21002012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2101
2102 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2103 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2104 Remove.
2105
13c379ee
PE
21062012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2107
2108 Do not avoid creating empty evaporating overlays (Bug#9642).
2109 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2110 That is, do not delete an evaporating overlay if it becomes
2111 empty after its bounds are adjusted to fit within its buffer.
2112 This fix caused other problems, and I'm reverting it until we get
2113 to the bottom of them.
2114
a8e7d6d7 21152012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2116
2117 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2118
a8e7d6d7 21192012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2120
2121 * xdisp.c (pos_visible_p): If the window start position is beyond
2122 ZV, start the display from buffer beginning. Prevents assertion
2123 violation in init_iterator when the minibuffer window is scrolled
2124 via the scroll bar.
2125
2126 * window.c (window_scroll_pixel_based): Likewise.
2127
a8e7d6d7 21282012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2129
2130 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2131
a8e7d6d7 21322012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2133
2134 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2135 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2136
a8e7d6d7 21372012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2138
b593d6a9
AH
2139 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2140 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2141
1c6900d9
EZ
21422012-04-26 Eli Zaretskii <eliz@gnu.org>
2143
4c3fa1d9
EZ
2144 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2145 display element, check also the underlying string or buffer
2146 character. (Bug#11341)
2147
1c6900d9
EZ
2148 * w32menu.c: Include w32heap.h.
2149 (add_menu_item): If the call to AppendMenuW (via
2150 unicode_append_menu) fails, disable Unicode menus only if we are
2151 running on Windows 9X/Me.
2152
42bf8205
AS
21532012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2154
2155 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2156 (xgetint): Add missing shift for LSB tags.
2157
b1bac16e
MR
21582012-04-24 Martin Rudalics <rudalics@gmx.at>
2159
2160 * keyboard.c (read_char): Don't wipe echo area for select window
2161 events: These might get delayed via `mouse-autoselect-window'
2162 (Bug#11304).
2163
d69621cc
JB
21642012-04-24 Juanma Barranquero <lekktu@gmail.com>
2165
2166 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2167 manipulation of :loaded-from data.
2168
02fd101b
JB
21692012-04-23 Juanma Barranquero <lekktu@gmail.com>
2170
2171 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2172 now a cons (bug#11311).
2173
888bec30
PE
21742012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2175
89a438bd
PE
2176 Do not create empty overlays with the evaporate property (Bug#9642).
2177 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2178 if it becomes empty after its bounds are adjusted to fit within
2179 its buffer. Without this fix, in a nonempty buffer (let ((o
2180 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2181 yields an empty overlay that has the evaporate property, which is
2182 not supposed to happen.
2183
1068fe4d
PE
2184 Fix minor GTK3 problems found by static checking.
2185 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2186 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2187 (struct _EmacsFixedClass, emacs_fixed_get_type):
2188 Move decls here from emacsgtkfixed.h, since they needn't be public.
2189 (emacs_fixed_get_type): Now static.
2190 (emacs_fixed_class_init): Omit unused local.
2191 (emacs_fixed_child_type): Remove; unused.
2192 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2193 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2194 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2195 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2196 (EMACS_FIXED_GET_CLASS): Remove; unused.
2197 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2198
888bec30
PE
2199 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2200 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2201
de85e130
PE
22022012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2203
d0baac98 2204 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2205 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2206 (__malloc_size_t, __malloc_ptrdiff_t):
2207 Remove. All uses removed, replaced by the definiens if needed,
2208 since we can assume C89 or better now.
2209 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2210 (protect_malloc_state, align, get_contiguous_space)
2211 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2212 (malloc_atfork_handler_child, malloc_enable_thread)
2213 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2214 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2215 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2216 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2217 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2218 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2219 Define using prototypes, not old style.
2220 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2221 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2222 (align): Don't assume that signed integer overflow wraps around.
2223 Omit unused local var.
2224 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2225 (_free_internal_nolock, memalign, mallochook, reallochook):
2226 Omit no-longer-needed casts.
2227 (valloc): Use getpagesize, not __getpagesize.
2228 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2229 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2230
de85e130
PE
2231 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2232
dcbf5805
MA
22332012-04-22 Michael Albinus <michael.albinus@gmx.de>
2234
2235 Move functions from C to Lisp. Make non-blocking method calls
2236 the default. Implement further D-Bus standard interfaces.
2237
2238 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2239 (QCdbus_request_name_allow_replacement)
2240 (QCdbus_request_name_replace_existing)
2241 (QCdbus_request_name_do_not_queue)
2242 (QCdbus_request_name_reply_primary_owner)
2243 (QCdbus_request_name_reply_in_queue)
2244 (QCdbus_request_name_reply_exists)
2245 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2246 (QCdbus_registered_serial, QCdbus_registered_method)
2247 (QCdbus_registered_signal): New Lisp objects.
2248 (XD_DEBUG_MESSAGE): Use sizeof.
2249 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2250 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2251 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2252 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2253 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2254 (xd_signature, xd_append_arg): Allow float for integer types.
2255 (xd_get_connection_references): New function.
b593d6a9
AH
2256 (xd_get_connection_address): Rename from xd_initialize.
2257 Return cached address.
dcbf5805
MA
2258 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2259 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2260 level.
2261 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2262 Return number of refcounts.
dcbf5805
MA
2263 (Fdbus_get_unique_name): Make stronger parameter check.
2264 (Fdbus_message_internal): New defun.
2265 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2266 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2267 (Fdbus_send_signal, Fdbus_register_service)
2268 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2269 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2270 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2271 (Vdbus_compiled_version, Vdbus_runtime_version)
2272 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2273 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2274 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2275 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2276 Adapt docstring.
dcbf5805 2277
52828e02
PE
22782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2279
da05bc4c
PE
2280 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2281 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2282 Do not assume ptrdiff_t is the same width as 'int'.
2283
52828e02
PE
2284 * alloc.c: Handle unusual debugging option combinations.
2285 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2286 since the two debugging options are incompatible.
2287 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2288 is defined.
2289 (mem_init, mem_insert, mem_insert_fixup):
2290 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2291 (NEED_MEM_INSERT): Remove; no longer needed.
2292
f01769f9
LL
22932012-04-22 Leo Liu <sdl.web@gmail.com>
2294
2295 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2296
5790543d
PE
22972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2298
2299 * sysdep.c [__FreeBSD__]: Minor cleanups.
2300 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2301 Use Emacs indenting style more consistently. Avoid some casts.
2302 Use 'double' consistently rather than mixing 'float' and 'double'.
2303
b91b7e4d
EW
23042012-04-21 Eduard Wiebe <usenet@pusto.de>
2305
b593d6a9
AH
2306 * sysdep.c (list_system_processes, system_process_attributes):
2307 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2308
6114eb15
AS
23092012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2310
2311 * lisp.mk (lisp): Update.
2312
2f38dff7
PE
23132012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2316 It is never used otherwise.
2317
4ae29f89
SM
23182012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2319
2320 * print.c (print_preprocess): Only check print_depth if print-circle
2321 is nil.
2322 (print_object): Check for cycles even when print-circle is nil and
2323 print-gensym is t, but only check print_depth if print-circle is nil.
2324
f30d612a
CY
23252012-04-20 Chong Yidong <cyd@gnu.org>
2326
2327 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2328 set the status to "failed" and ensure that sentinel is run.
2329
c07a4c0b 23302012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2331
2332 * process.c (Fset_process_inherit_coding_system_flag)
2333 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2334 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2335
c07a4c0b 23362012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2337
2338 * xdisp.c (string_buffer_position_lim): Limit starting position to
2339 BEGV.
2340 (set_cursor_from_row): If called for a mode-line or header-line
2341 row, return zero immediately.
2342 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2343 farther than the first row after the header line, if any.
2344 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2345 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2346
c07a4c0b 23472012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2348
4ae29f89
SM
2349 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2350 (bug#11238).
ad3a2b41 2351
c07a4c0b 23522012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 23532012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2354
2355 configure: new option --enable-gcc-warnings (Bug#11207)
2356 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2357 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2358 (ALL_CFLAGS): Use new macros rather than old.
2359 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2360 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2361 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2362 -Wunused-result, -Wunused-variable. This should go away once
2363 the Emacs and Gnulib regex code is merged.
2364 (xmalloc, xrealloc): Now static.
2365
aba027e8
PE
23662012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2367
2368 * dired.c (Fsystem_groups): Remove unused local.
2369
e5a36063
GM
23702012-04-17 Glenn Morris <rgm@gnu.org>
2371
2372 * dired.c (Fsystem_users): Doc fix.
2373
316411f0
DA
23742012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2375
2376 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2377 (syms_of_dired): Add them.
2378
9426aba4
PE
23792012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2380
b62a57be
PE
2381 Fix minor alloc.c problems found by static checking.
2382 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2383 New extern decls, to avoid calling undeclared functions.
2384 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2385 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2386 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2387 (NEED_MEM_INSERT): New macro.
2388 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2389 Remove one incorrect comment and fix another.
b62a57be 2390
3539f31f
PE
2391 Fix minor ralloc.c problems found by static checking.
2392 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2393 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2394 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2395 (r_alloc_sbrk): Now static.
2396
a041960a
PE
2397 Improve ralloc.c interface checking.
2398 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2399 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2400 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2401 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2402 [REL_ALLOC]: ... to here, to check interface.
2403 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2404 Remove decls. This fixes an "It stinks!".
2405
9426aba4
PE
2406 * alloc.c (which_symbols): Fix alignment issue / type clash.
2407
d55c12ed
AS
24082012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2409
2410 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2411 (struct Lisp_Misc_Any): Likewise.
2412 (struct Lisp_Free): Likewise.
2413 * alloc.c (union aligned_Lisp_Symbol): Define.
2414 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2415 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2416 (union aligned_Lisp_Misc): Define.
2417 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2418 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2419 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2420
b948ce8b
PE
24212012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2424 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2425 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2426 * s/netbsd.h, s/sol2-6.h:
2427 Remove definition of GC_MARK_STACK, since the default now works.
2428 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2429 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2430 no longer the default.
2431 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2432
35dc09a1 24332012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2434
35dc09a1
GM
2435 * lread.c (lisp_file_lexically_bound_p):
2436 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2437
35dc09a1
GM
24382012-04-14 Eli Zaretskii <eliz@gnu.org>
2439
2440 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2441 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2442
24432012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2444
2445 * nsterm.m (constrainFrameRect): Always constrain when there is only
2446 one screen (Bug#10962).
2447
bcd86815
KB
24482012-04-13 Ken Brown <kbrown@cornell.edu>
2449
2450 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2451
c25df26e
RT
24522012-04-13 Reuben Thomas <rrt@sc3d.org>
2453
2454 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2455
0fc59f1e
DC
24562012-04-11 Daniel Colascione <dancol@dancol.org>
2457
2458 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2459 against is gone. It's better to use vfork now so that when Cygwin
2460 gains a new, working vfork, we use it automatically (bug#10398).
2461
de8c03dc
SM
24622012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2463
2464 * window.c (save_window_save): Obey window-point-insertion-type.
2465
2f097256
GM
24662012-04-11 Glenn Morris <rgm@gnu.org>
2467
2468 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2469
453b951e
SM
24702012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2471
2472 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2473
75f1671a 24742012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2475
2476 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2477 (force_quit_count): New var.
2478 (handle_interrupt): Use it.
2479
2a8ce227
JB
24802012-04-10 Juanma Barranquero <lekktu@gmail.com>
2481
2482 * w32.c (w32_delayed_load): Record the full path of the library
2483 being loaded (bug#10424).
2484
935396c0
GM
24852012-04-09 Glenn Morris <rgm@gnu.org>
2486
05920a43
GM
2487 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2488 not just in the obarray, before snarfing them. (Bug#11036)
2489
935396c0
GM
2490 * Makefile.in ($(leimdir)/leim-list.el):
2491 Pass EMACS rather than BUILT_EMACS.
2492
a18ecafa
TZ
24932012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2494
2495 * process.c (make_process):
2496 * process.h: Add integer `gnutls_handshakes_tried' member to
2497 process struct.
2498
6bbef4e5
JC
2499 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2500 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2501
2502 * gnutls.c (gnutls_log_function2i): Convenience log function.
2503 (emacs_gnutls_read): Use new log functions,
2504 `gnutls_handshakes_tried' process member, and
2505 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2506 attempts per process (connection).
2507
b4d3bc10
CY
25082012-04-09 Chong Yidong <cyd@gnu.org>
2509
2510 * eval.c (Fuser_variable_p, user_variable_p_eh)
2511 (lisp_indirect_variable): Functions deleted.
2512 (Fdefvar): Caller changed.
2513
2514 * callint.c (Finteractive, Fcall_interactively):
2515 * minibuf.c (Fread_variable): Callers changed.
2516
70f4d973
EZ
25172012-04-09 Eli Zaretskii <eliz@gnu.org>
2518
2519 * xdisp.c (set_cursor_from_row): If the display string appears in
2520 the buffer at position that is closer to point than the position
2521 after the display string, display the cursor on the first glyph of
2522 the display string. Fixes cursor display when a 'display' text
2523 property immediately follows invisible text. (Bug#11094)
2524
cb3c2e3e
PE
25252012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 composite.c: use 'double' consistently
2528 * composite.c (get_composition_id): Use 'double' consistently
2529 instead of converting 'float' to 'double' and vice versa; this is
2530 easier to understand and avoids a GCC warning.
2531
fd06db5d
GM
25322012-04-09 Glenn Morris <rgm@gnu.org>
2533
50fe702a
GM
2534 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2535 preparation for dumping it with emacs. (Bug#4789)
2536 (leimdir): New variable.
2537 ($(leimdir)/leim-list.el): New rule.
2538 (emacs$(EXEEXT)): Depend on leim-list.el.
2539
fd06db5d
GM
2540 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2541 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2542 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2543
55c131ee
AS
25442012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2545
2546 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2547 proper alignment.
2548
9209588f
JB
25492012-04-07 Juanma Barranquero <lekktu@gmail.com>
2550
2551 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2552 Remove unused local variable.
2553
e3fb2efb
PE
25542012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2555
2556 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2557 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2558 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2559 objects, as mark_maybe_pointer will catch them otherwise.
2560 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2561 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2562
b5385551
PE
25632012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2564
2565 Fix typo that broke non-Windows builds.
2566 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2567
9078ead6
EZ
25682012-04-07 Eli Zaretskii <eliz@gnu.org>
2569
2570 Support building on MS-Windows with libxml2.
2571
2572 * makefile.w32-in (OBJ2): Add xml.$(O).
2573 (GLOBAL_SOURCES): Add xml.c.
2574 ($(BLD)/xml.$(O)): New dependency list.
2575
2576 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2577 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2578 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2579 [!WINDOWSNT]: New macros.
2580 (init_libxml2_functions, libxml2_loaded_p): New functions.
2581 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2582 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2583 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2584 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2585 linked in).
6bbef4e5
JC
2586 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2587 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2588 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2589
2590 * emacs.c: Don't include libxml/parser.h.
2591 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2592 xmlCleanupParser directly.
2593
2594 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2595
3811fdf3
EZ
25962012-04-07 Eli Zaretskii <eliz@gnu.org>
2597
2598 * indent.c (Fvertical_motion): If there is a display string at
2599 point, use it.vpos to compute how many lines to backtrack after
2600 move_it_to point. (Bug#11133)
2601
2f8e16b2
EZ
26022012-04-06 Eli Zaretskii <eliz@gnu.org>
2603
2604 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2605 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2606 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2607 macros related to unification of CJK characters. For the details,
2608 see the discussion following the message here:
2609 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2610
3d439cd1
CY
26112012-04-04 Chong Yidong <cyd@gnu.org>
2612
2613 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2614
8bc53d00
EZ
26152012-04-01 Eli Zaretskii <eliz@gnu.org>
2616
2617 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2618 instead of alloca. (Bug#11138)
2619
3b0512a3
AS
26202012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2621
2622 * w32menu.c (is_simple_dialog): Properly check lisp types.
2623 (Bug#11141)
2624
8427ddd2
EZ
26252012-03-31 Eli Zaretskii <eliz@gnu.org>
2626
979022ef
EZ
2627 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2628 position we get to after a call to move_it_to fails the
2629 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2630 only if we wind up in a string from display property. (Bug#11063)
2631
a6b1c7cc
EZ
2632 * window.c (Fdelete_other_windows_internal): Invalidate the row
2633 and column information about mouse highlight, so that redisplay
2634 restores it after reallocating the glyph matrices. (Bug#7464)
2635
8427ddd2
EZ
2636 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2637 string comes from a `display' text property, use the buffer
2638 position of that property as if we actually saw that position in
2639 the row's glyphs.
697ba24b
EZ
2640 (move_it_by_lines): Remove the assertion that
2641 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2642 violated when there's a before-string at the beginning of a line.
2643 (Bug#11063)
8427ddd2 2644
65a0a738
EZ
26452012-03-30 Eli Zaretskii <eliz@gnu.org>
2646
2647 * xdisp.c (append_space_for_newline): If the default face was
2648 remapped, use the remapped face for the appended newline.
2649 (extend_face_to_end_of_line): Use the remapped default face for
2650 extending the face to the end of the line.
2651 (display_line): Call extend_face_to_end_of_line when the default
2652 face was remapped. (Bug#11068)
2653
581355cc
EZ
26542012-03-29 Eli Zaretskii <eliz@gnu.org>
2655
2656 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2657
e8fc049f
SM
26582012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2659
2660 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2661
4fb9a543
GM
26622012-03-27 Glenn Morris <rgm@gnu.org>
2663
2664 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2665 Doc fixes.
2666
679910f1
KH
26672012-03-26 Kenichi Handa <handa@m17n.org>
2668
2669 * dispextern.h (struct glyph): Fix previous change. Change the
2670 bit length of glyphless.ch to 25 (Bug#11082).
2671
90d49b7f
CY
26722012-03-26 Chong Yidong <cyd@gnu.org>
2673
2674 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2675 (command_loop_1): Use it; inhibit selection update for
2676 handle-select-window too (Bug#8996).
2677
f514f6f0
FP
26782012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2679
e8fc049f 2680 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2681
bf43fa51
KH
26822012-03-25 Kenichi Handa <handa@m17n.org>
2683
2684 * dispextern.h (struct glyph): Change the bit length of
2685 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2686
8a0c01dd
EZ
26872012-03-24 Eli Zaretskii <eliz@gnu.org>
2688
2689 * s/ms-w32.h (tzname): Include time.h before redirecting to
2690 _tzname. Fixes the MSVC build. (Bug#9960)
2691
7d1c3a76
AS
26922012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2693
8ed79523
AS
2694 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2695 characters.
2696
7d1c3a76
AS
2697 * xterm.c (XTread_socket): Only modify handling_signal if
2698 !SYNC_INPUT. (Bug#11080)
2699
e99a9b8b
EZ
27002012-03-23 Eli Zaretskii <eliz@gnu.org>
2701
2702 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2703 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2704 when fetching a multibyte character consumes more bytes than
2705 CHAR_BYTES returns, due to unification of CJK characters in
2706 string_char. (Bug#11073)
2707
5063c0e1
TN
27082012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2709
2710 * process.c (wait_reading_process_output): Handle pty disconnect
2711 by refraining from sending oneself a SIGCHLD (bug#10933).
2712
9f851fbd
CY
27132012-03-22 Chong Yidong <cyd@gnu.org>
2714
2715 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2716
5063c0e1 2717 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2718 Mark string as coming from a prefix property.
2719 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2720 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2721
fb5b8aca
CY
27222012-03-21 Chong Yidong <cyd@gnu.org>
2723
2724 * xfaces.c (Vface_remapping_alist): Doc fix.
2725
62356a1b
EZ
27262012-03-20 Eli Zaretskii <eliz@gnu.org>
2727
2728 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2729 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2730 Doc fixes.
62356a1b 2731
025de85b
CY
27322012-03-20 Chong Yidong <cyd@gnu.org>
2733
2734 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2735 to reflect default non-nil value of redisplay-dont-pause.
2736
4827f94e
KH
27372012-03-19 Kenichi Handa <handa@m17n.org>
2738
2739 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2740 it fit in a valid range (Bug#11003).
2741
e50a24a2
EZ
27422012-03-18 Eli Zaretskii <eliz@gnu.org>
2743
2744 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2745 that is not from display property, accept the row as a "cursor
2746 row" if one of the string's character has a non-nil `cursor'
2747 property. Fixes cursor positioning when there are newlines in
2748 overlay strings, e.g. in icomplete.el. (Bug#11035)
2749
9af5ed87
PE
27502012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2751
2752 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2753
d1f55f16
CY
27542012-03-12 Chong Yidong <cyd@gnu.org>
2755
2756 * eval.c (inhibit_lisp_code): Rename from
2757 inhibit_window_configuration_change_hook; move from window.c.
2758
2759 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2760 * window.c (run_window_configuration_change_hook)
2761 (syms_of_window): Callers changed.
2762
66c5eebd
CY
27632012-03-11 Chong Yidong <cyd@gnu.org>
2764
413df973
CY
2765 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2766
66c5eebd
CY
2767 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2768
1de11f56
CY
27692012-03-10 Chong Yidong <cyd@gnu.org>
2770
2771 * frame.c (other_visible_frames): Don't assume the selected frame
2772 is visible (Bug#10955).
2773
cae07000
SM
27742012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2775
2776 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2777
89c94350
JD
27782012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2779
2780 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2781 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2782 zero (Bug#10954).
2783
999dd333
GM
27842012-03-03 Glenn Morris <rgm@gnu.org>
2785
01a6dcc8 2786 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2787
de0100f2
EZ
27882012-03-02 Eli Zaretskii <eliz@gnu.org>
2789
2790 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2791 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2792 (redisplay_window, next_element_from_string): Fix typos in
2793 comments.
3e441275
EZ
2794 (redisplay_window): Pass to move_it_vertically the margin in
2795 pixels, not in screen lines.
de0100f2 2796
96a72ee9
GM
27972012-03-02 Glenn Morris <rgm@gnu.org>
2798
2799 * buffer.c (buffer-list-update-hook): Doc fix.
2800
312508d7
EZ
28012012-02-29 Eli Zaretskii <eliz@gnu.org>
2802
2803 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2804 push_it before setting up the iterator for the first overlay
2805 string, even if we have an empty string loaded.
2806 (next_overlay_string): If there's an empty string on the iterator
2807 stack, pop the stack. (Bug#10903)
2808
27f3c637
PE
28092012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2812 Suggested by Stefan Monnier in
2813 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2814 * alloc.c (widen_to_Lisp_Object): New static function.
2815 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2816 and widening them to Lisp_Objects. This would work even if
2817 USE_LSB_TAG is defined and wide integers are used, which might
2818 happen in a future version of Emacs.
2819
3c9dfce6
CY
28202012-02-25 Chong Yidong <cyd@gnu.org>
2821
fa74b241
CY
2822 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2823 Doc fix.
2824
3c9dfce6
CY
2825 * xselect.c (Fx_selection_exists_p): Doc fix.
2826 (x_clipboard_manager_save_all): Print an informative message
2827 before saving to clipboard manager.
2828
9486df08
CY
28292012-02-24 Chong Yidong <cyd@gnu.org>
2830
2831 * keyboard.c (process_special_events): Handle all X selection
2832 requests in kbd_buffer, not just the next one (Bug#8869).
2833
f01d3321
CY
28342012-02-23 Chong Yidong <cyd@gnu.org>
2835
2836 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2837 call when setting menu-bar-lines and tool-bar-lines parameters.
2838 (unwind_create_frame_1): New helper function.
2839
2840 * window.c (inhibit_window_configuration_change_hook): New var.
2841 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2842 (syms_of_window): Initialize it.
f01d3321 2843
86b847b6
CY
28442012-02-22 Chong Yidong <cyd@gnu.org>
2845
2846 * xterm.c (x_draw_image_relief): Add missing type check for
2847 Vtool_bar_button_margin (Bug#10743).
2848
a59225b1
CY
28492012-02-21 Chong Yidong <cyd@gnu.org>
2850
2851 * fileio.c (Vfile_name_handler_alist): Doc fix.
2852
2853 * buffer.c (Fget_file_buffer): Protect against invalid file
2854 handler return value.
2855
310f5bd4
PE
28562012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2857
cb3a28cc
PE
2858 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2859 when computing $valmask.
2860
310f5bd4
PE
2861 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2862 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2863 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2864 It's useless in that case, and it can cause problems on hosts
2865 that allocate halves of EMACS_INT values separately.
2866 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2867 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2868 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2869 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2870 it avoids undefined behavior on hosts where shifting right by more
2871 than the word width has undefined behavior.
2872
2375c96a
CY
28732012-02-19 Chong Yidong <cyd@gnu.org>
2874
2875 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2876 (Funhandled_file_name_directory, Ffile_name_as_directory)
2877 (Fdirectory_file_name, Fexpand_file_name)
2878 (Fsubstitute_in_file_name): Protect against invalid file handler
2879 return values (Bug#10845).
2880
3eb49e71
EZ
28812012-02-18 Eli Zaretskii <eliz@gnu.org>
2882
2883 * .gdbinit (pitx): Fix incorrect references to fields of the
2884 iterator stack.
2885
7b926f3f
CY
28862012-02-17 Chong Yidong <cyd@gnu.org>
2887
2888 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2889
11273115
PE
28902012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2891
2892 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2893 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2894
c3a70e2b
CY
28952012-02-15 Chong Yidong <cyd@gnu.org>
2896
2897 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2898 marked as special. Also, starting docstrings with * is obsolete.
2899
0ca43699
AS
29002012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2901
2902 * gnutls.c (emacs_gnutls_write): Fix last change.
2903
2e8f3c56
LI
29042012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2905
2906 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2907 send_process.
2908
af70074f
SM
29092012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2910
2911 * keymap.c (Fsingle_key_description): Handle char ranges.
2912
95986d52
CY
29132012-02-12 Chong Yidong <cyd@gnu.org>
2914
afd83bd1
CY
2915 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2916 as that creates a dangerous corner case.
2917
95986d52
CY
2918 * window.c (Fdelete_window_internal): Invalidate the mouse
2919 highlight (Bug#9904).
2920
bd7da63e
GM
29212012-02-12 Glenn Morris <rgm@gnu.org>
2922
2923 * xselect.c (Fx_own_selection_internal)
2924 (Fx_get_selection_internal, Fx_disown_selection_internal)
2925 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2926 * nsselect.m (Fx_own_selection_internal)
2927 (Fx_disown_selection_internal, Fx_selection_exists_p)
2928 (Fx_selection_owner_p, Fx_get_selection_internal):
2929 Sync docs and argument specs with the xselect.c versions.
2930
77abcbc2
LI
29312012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2932
2933 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2934
90b671e2
EZ
29352012-02-11 Eli Zaretskii <eliz@gnu.org>
2936
1c0ca0b7
EZ
2937 * w32select.c (Fx_selection_exists_p): Sync doc string and
2938 argument list with xselect.c. (Bug#10783)
2939
2940 * w16select.c (Fx_selection_exists_p): Sync doc string and
2941 argument list with xselect.c. (Bug#10783)
90b671e2 2942
49241268
GM
29432012-02-10 Glenn Morris <rgm@gnu.org>
2944
2945 * fns.c (Fsecure_hash): Doc fix.
2946
f998bbe7 29472012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2948
2949 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2950
0992bd9c
CY
29512012-02-07 Chong Yidong <cyd@gnu.org>
2952
2953 * buffer.c (Fbuffer_local_variables)
2954 (buffer_lisp_local_variables): Handle unbound vars correctly;
2955 don't let Qunbound leak into Lisp.
2956
af008560
GM
29572012-02-07 Glenn Morris <rgm@gnu.org>
2958
dd605cc4
GM
2959 * image.c (Fimagemagick_types): Doc fix.
2960
af008560
GM
2961 * image.c (imagemagick-render-type): Change it from a lisp object
2962 to an integer. Move the doc here from the lisp manual.
2963 Treat all values not equal to 0 the same.
2964
1449fa1d
CY
29652012-02-06 Chong Yidong <cyd@gnu.org>
2966
2967 * doc.c (store_function_docstring): Avoid applying docstring of
2968 alias to base function (Bug#2603).
2969
3723ec07
AS
29702012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2971
2972 * .gdbinit (pp1, pv1): Remove redundant defines.
2973 (pr): Use pp.
2974
79c1cc1e
CY
29752012-02-04 Chong Yidong <cyd@gnu.org>
2976
2977 * nsterm.m: Declare a global (Bug#10694).
2978
d7f29f8e
EZ
29792012-02-04 Eli Zaretskii <eliz@gnu.org>
2980
cae07000
SM
2981 * w32.c (get_emacs_configuration_options):
2982 Include --enable-checking, if specified, in the return value.
d7f29f8e 2983
3b95a6f9
MR
29842012-02-04 Martin Rudalics <rudalics@gmx.at>
2985
2986 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2987 after rounding frame sizes. (Bug#9723)
2988
d6fa96a6
EZ
29892012-02-04 Eli Zaretskii <eliz@gnu.org>
2990
2991 * keyboard.c (adjust_point_for_property): Don't position point
2992 before BEGV. (Bug#10696)
2993
df0b2940
PE
29942012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2995
2996 Handle overflow when computing char display width (Bug#9496).
2997 * character.c (char_width): Return EMACS_INT, not int.
2998 (char_width, c_string_width): Check for overflow when
2999 computing the width; this is possible now that individual
3000 characters can have unbounded width. Problem introduced
3001 by merge from Emacs 23 on 2012-01-19.
3002
6bee44d6
MA
30032012-02-02 Michael Albinus <michael.albinus@gmx.de>
3004
3005 * dbusbind.c (Fdbus_register_method): Mention the return value
3006 :ignore in the docstring.
3007
44f92739
GM
30082012-02-02 Glenn Morris <rgm@gnu.org>
3009
1b9f60cc
GM
3010 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3011
44f92739
GM
3012 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3013 Unconditionally set to t. (Bug#10673)
3014 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3015 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3016 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3017
c5d3843c
KH
30182012-02-02 Kenichi Handa <handa@m17n.org>
3019
3020 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3021 0, do not call append_composite_glyph.
3022
159462d4 30232012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3024
3025 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3026 NULL (Bug#6988).
3027 (x_produce_glyphs): If the component of a composition is a null
3028 string, set it->pixel_width to 1 to avoid zero-width glyph.
3029
78cef877
EZ
30302012-02-01 Eli Zaretskii <eliz@gnu.org>
3031
3032 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3033 first 2 arguments are identical. This makes inserting large
3034 output from a subprocess an order of magnitude faster on
3035 MS-Windows, where all sbrk'ed memory is always contiguous.
3036
97897668
GM
30372012-01-31 Glenn Morris <rgm@gnu.org>
3038
3039 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3040 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3041 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3042
31fd3586
GM
30432012-01-29 Glenn Morris <rgm@gnu.org>
3044
3045 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3046
0e24a8b2
CY
30472012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3048
3049 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3050
cc0adcb0
CY
30512012-01-28 Chong Yidong <cyd@gnu.org>
3052
3053 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3054
acc28cb9
CY
30552012-01-26 Chong Yidong <cyd@gnu.org>
3056
9c69cfb7
CY
3057 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3058
acc28cb9
CY
3059 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3060 repeat counts (Bug#10507).
3061
48da7392
GM
30622012-01-26 Glenn Morris <rgm@gnu.org>
3063
3064 * lread.c (syms_of_lread): Doc fix.
3065
14af5f7f
CY
30662012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3067
3068 * coding.c (encode_designation_at_bol): Change return value to
3069 EMACS_INT.
3070
0b21c100
CY
30712012-01-25 Chong Yidong <cyd@gnu.org>
3072
3073 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3074
3c2907f7
CY
30752012-01-21 Chong Yidong <cyd@gnu.org>
3076
3077 * floatfns.c (Fcopysign): Make the second argument non-optional,
3078 since nil is not allowed anyway.
3079
959ad23f
AS
30802012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3081
3082 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3083 (send_process): Likewise.
3084
34a02f46
MR
30852012-01-19 Martin Rudalics <rudalics@gmx.at>
3086
3087 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3088 (Vwindow_persistent_parameters): Do not use Qstate.
3089 Rewrite doc-strings.
34a02f46 3090
1259009a 30912012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3092
3093 * character.c (char_width): New function.
70d4fdf6
GM
3094 (Fchar_width, c_string_width, lisp_string_width):
3095 Use char_width (Bug#9496).
25ed9e61 3096
6a6ee00d
MR
30972012-01-16 Martin Rudalics <rudalics@gmx.at>
3098
3099 * window.c (Vwindow_persistent_parameters): New variable.
3100 (Fset_window_configuration, save_window_save): Handle persistent
3101 window parameters.
3102
c85efaf7
EZ
31032012-01-14 Eli Zaretskii <eliz@gnu.org>
3104
3105 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3106 thrashing the stack of the thread. (Bug#9087)
3107
5944709e
PE
31082012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3109
3110 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3111
e71f5d99
EZ
31122012-01-11 Eli Zaretskii <eliz@gnu.org>
3113
3114 * xdisp.c (rows_from_pos_range): Handle the case where the
3115 highlight ends on a newline. (Bug#10464)
3116 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3117 he end column for display of highlight that ends on a newline
3118 before a R2L line.
3119
ce316182
GM
31202012-01-11 Glenn Morris <rgm@gnu.org>
3121
3122 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3123 from load-path also when installation-directory is nil. (Bug#10208)
3124
5b43da69
GM
31252012-01-10 Glenn Morris <rgm@gnu.org>
3126
74cc8ff9
GM
3127 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3128
7d8d6e4e
GM
3129 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3130 Update template values to be closer to their typical values these days.
5b43da69 3131
a0db8d43
EZ
31322012-01-09 Eli Zaretskii <eliz@gnu.org>
3133
3134 * xdisp.c (rows_from_pos_range): Accept additional argument
3135 DISP_STRING, and accept any glyph in a row whose object is that
3136 string as eligible for mouse highlight. Fixes mouse highlight of
3137 display strings from overlays. (Bug#10464)
3138
9a0115ab 31392012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3140
b9110d6a 3141 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3142 * fileio.c (auto_saving_dir_umask): New static var.
3143 (Fmake_directory_internal): Use it.
3144 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3145 creating the directory. The old code temporarily assigns
3146 too-generous permissions to the directory.
3147 (do_auto_save_eh): Clear it.
b9110d6a 3148 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3149 that the var is always cleared.
3150
6c1bd3f3
EZ
31512012-01-07 Eli Zaretskii <eliz@gnu.org>
3152
3153 * search.c (scan_buffer): Pass character positions to
3154 know_region_cache, not byte positions. (Bug#6540)
3155
069d2b50
L
31562012-01-07 LynX <_LynX@bk.ru> (tiny change)
3157
3158 * w32.c (sys_rename): Report EXDEV when rename of a directory
3159 fails because the target is on another logical disk. (Bug#10284)
3160
75bf0d33
DB
31612012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3162
3163 * xterm.c (x_embed_request_focus): New function.
3164
3165 * xterm.h: Add prototype.
3166
3167 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3168
1c6e5a32
GM
31692012-01-05 Glenn Morris <rgm@gnu.org>
3170
3171 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3172
651e947e
EZ
31732012-01-01 Eli Zaretskii <eliz@gnu.org>
3174
3175 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3176 Load gnutls_transport_set_lowat only if GnuTLS version is below
3177 2.11.1.
3178 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3179 GnuTLS versions below 2.11.1.
3180
3778cdd8
AL
31812011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3182
3183 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3184 to the doc string advising against its use for altering the way
3185 windows are scrolled.
3186
0e5317f7
KH
31872011-12-28 Kenichi Handa <handa@m17n.org>
3188
3189 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3190 coding-system ASCII compatible only when it does not produce BOM
3191 on encoding (Bug#10383).
3192
93d5ca1f
JD
31932011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3194
3195 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3196 can scroll.
3197 (create_and_show_popup_menu): Always use menu_position_func for
3198 Gtk3 (Bug#10361).
3199
ca22b785
AS
32002011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3201
3202 * callint.c (Fcall_interactively): Don't truncate prompt string.
3203
d048e1e6
EZ
32042011-12-23 Eli Zaretskii <eliz@gnu.org>
3205
3206 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3207 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3208 resumed from there (after widening). (Bug#10360)
d048e1e6 3209
5ccaba1f
JD
32102011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3211
3212 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3213
204ee57f
JD
32142011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3215
b81d40f0
JB
3216 * nsterm.m (x_free_frame_resources):
3217 Release f->output_data.ns->miniimage.
204ee57f
JD
3218 (ns_index_color): Fix indentation. Do not retain
3219 color_table->colors[i].
3220
3221 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3222 before returning.
3223
3224 * nsfns.m (x_set_background_color): Assign return value from
3225 ns_index_color to face-background instead of NSColor*.
3226 (ns_implicitly_set_icon_type): Fix indentation.
3227 Change assignment in for loop to comparison.
3228
3229 * emacs.c (ns_pool): New variable.
3230 (main): Assign ns_pool.
3231 (Fkill_emacs): Call ns_release_autorelease_pool.
3232
3233 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3234 autorelease fdesc, release fdAttrs and tdict.
3235 (ns_get_covering_families): Release charset.
3236 (ns_findfonts): Release NSFontDescriptor created with new.
3237 (ns_uni_to_glyphs): Fix indentation.
3238 (setString): Release attrStr before assigning new value.
3239
c803b2b7
JD
32402011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3241
678f4426
JD
3242 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3243 and NS_IMPL_COCOA.
3244 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3245 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3246
cd394be1 32472011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3248
5fecd5fc
JD
3249 * nsterm.m (ns_term_init): Subscribe for notifications
3250 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3251 to method trackingNotification in EmacsMenu.
3252
3253 * nsmenu.m (trackingMenu): New variable.
3771cb17 3254 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3255 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3256 from Aquamacs (Bug#7030).
678f4426
JD
3257
32582011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3259
c803b2b7
JD
3260 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3261 (symbol_to_nsstring): Fix indentation.
3262 (ns_symbol_to_pb): New function.
cae07000
SM
3263 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3264 (Fns_rotate_cut_buffers_internal): Remove.
3265 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3266 Fns_store_cut_buffer_internal.
3267 (ns_get_foreign_selection, Fx_own_selection_internal)
3268 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3269 (Fns_get_selection_internal, Fns_store_selection_internal):
3270 Use ns_symbol_to_pb and check if return value is nil.
3271 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3272 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3273 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3274 renamed to Sns_store_selection_internal.
3275 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3276 and remove this function.
3277 (ns_handle_selection_clear): Remove, never used.
3278 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3279 here.
3280
e1b01a3a
KB
32812011-12-17 Ken Brown <kbrown@cornell.edu>
3282
3283 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3284 GID is unknown (Bug#10257).
3285
2adb6e85
PE
32862011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3289 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3290 which caused a build failure on GNU/Linux IA-64. This problem was
3291 introduced by my 2011-10-07 patch.
3292
d1d7b339
JL
32932011-12-15 Juri Linkov <juri@jurta.org>
3294
3295 * image.c (imagemagick_error): New function. (Bug#10112)
3296 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3297 Use `imagemagick_error' where ImageMagick functions return
3298 `MagickFalse'.
3299 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3300 proper order.
3301
100d5755
KH
33022011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3303
3304 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3305 fill background (Bug#8992).
3306
454592a6
MR
33072011-12-13 Martin Rudalics <rudalics@gmx.at>
3308
3309 * window.c (Vwindow_combination_resize)
3310 (Vwindow_combination_limit): Use t instead of non-nil in
3311 doc-strings.
61d4b438
MR
3312 (Vrecenter_redisplay): Add first sentence of doc-string on
3313 separate line.
53524d93 3314 (Frecenter): Fix doc-string typo.
454592a6 3315
3633e3aa
KH
33162011-12-11 Kenichi Handa <handa@m17n.org>
3317
3318 * coding.c (Funencodable_char_position): Pay attention to the
3319 buffer text relocation (Bug#9389).
3320
7b9d523a 33212011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3322
7b9d523a
JD
3323 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3324 gtk_init (Bug#10100).
3325
b73189c6
EZ
33262011-12-10 Eli Zaretskii <eliz@gnu.org>
3327
3328 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3329 IT->string is nil. (Bug#10263)
3330
f7dfe5d6
JD
33312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3332
83faebb4
JD
3333 * nsterm.h (x_free_frame_resources): Declare.
3334
f7dfe5d6
JD
3335 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3336 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3337
3338 * nsterm.h (ns_get_defaults_value): Declare.
3339
3340 * nsterm.m (ns_default): Call ns_get_defaults_value.
3341
7cd4e72c
EZ
33422011-12-09 Eli Zaretskii <eliz@gnu.org>
3343
3344 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3345 (Bug#10170)
3346
b34d7317
YM
33472011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3348
3349 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3350 that where the value of an _OBJC_* symbol points to is in the .bss
3351 section (Bug#10240).
3352
76470ad1
KH
33532011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3354
3355 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3356 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3357
745fff94
KH
33582011-12-08 Kenichi Handa <handa@m17n.org>
3359
3360 * ftfont.c (get_adstyle_property): Fix previous change
3361 (Bug#10233).
3362
6e44397c
JB
33632011-12-07 Juanma Barranquero <lekktu@gmail.com>
3364
3365 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3366 dirs from the default value of EMACSLOADPATH (bug#10208).
3367
7efa6272
GM
33682011-12-07 Glenn Morris <rgm@gnu.org>
3369
3370 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3371 installation and source directories as well. (Bug#10208)
3372
f6fc4d87
CY
33732011-12-06 Chong Yidong <cyd@gnu.org>
3374
3375 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3376
2bf26180
GM
33772011-12-06 Glenn Morris <rgm@gnu.org>
3378
3379 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3380 as an error, not just -1. (Bug#10217)
3381
3a6ad4f0
CY
33822011-12-05 Chong Yidong <cyd@gnu.org>
3383
3384 * keyboard.c (process_special_events): New function.
3385 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3386
75a3b399
PE
33872011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 * coding.c (encode_designation_at_bol): Don't use uninitialized
3390 local variable (Bug#9318).
3391
c3c9e25e
KH
33922011-12-05 Kenichi Handa <handa@m17n.org>
3393
3394 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3395 return Qnil (Bug#8046, Bug#10193).
3396
5eb05ea3
KH
33972011-12-05 Kenichi Handa <handa@m17n.org>
3398
3399 * coding.c (encode_designation_at_bol): New args charbuf_end and
3400 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3401 (coding_set_source): Return how many bytes coding->source was
3402 relocated.
3403 (coding_set_destination): Return how many bytes
3404 coding->destination was relocated.
3405 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3406 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3407
34082011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3409
3410 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3411 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3412 macro (Bug#9318).
3413
34142011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3415
3416 The following changes are to fix Bug#9318.
3417
a79703f5 3418 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3419 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3420 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3421 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3422
7dbda6df
JB
34232011-12-05 Juanma Barranquero <lekktu@gmail.com>
3424
3425 * lisp.h (process_quit_flag): Fix external declaration.
3426
6d5eb5b0
SM
34272011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3428
3429 Don't macro-inline non-performance-critical code.
3430 * eval.c (process_quit_flag): New function.
3431 * lisp.h (QUIT): Use it.
3432
a0c3fad0
JD
34332011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3434
3435 * nsfns.m (get_geometry_from_preferences): New function.
3436 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3437
6c07aac2
AS
34382011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3439
3440 * emacs.c (Qkill_emacs): Define.
3441 (syms_of_emacs): Initialize it.
3442 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3443 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3444 (quit_throw_to_read_char): Add parameter `from_signal'.
3445 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3446 * lisp.h (QUIT): Call Fkill_emacs if requested.
3447
c052ead4
JD
34482011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3449
3450 * widget.c (update_wm_hints): Return if wmshell is null.
3451 (widget_update_wm_size_hints): New function.
3452
3453 * widget.h (widget_update_wm_size_hints): Declare.
3454
3455 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3456 widget_update_wm_size_hints (Bug#10104).
3457
9e49252b
EZ
34582011-12-03 Eli Zaretskii <eliz@gnu.org>
3459
3460 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3461 before a newline, prepare the bidi iterator for consuming the
3462 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3463 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3464
02b16839
JL
34652011-12-02 Juri Linkov <juri@jurta.org>
3466
3467 * search.c (Fword_search_regexp): New Lisp function created from
3468 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3469 (Fword_search_backward, Fword_search_forward)
3470 (Fword_search_backward_lax, Fword_search_forward_lax):
3471 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3472 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3473
0068070e
SM
34742011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3475
3476 * fileio.c (Finsert_file_contents): Move after-change-function call
3477 to before the "handled:" label, since all "goto handled" appear in
3478 cases where the *-change-functions have already been properly called
3479 (bug#10117).
3480
3360a3fc
AS
34812011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3482
3483 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3484 waiting for input. (Bug#10169)
3485
73d6c093
EZ
34862011-11-30 Eli Zaretskii <eliz@gnu.org>
3487
3488 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3489 verifies glyph row's hash code--we have just reallocated the
3490 glyphs, so their contents can be complete garbage. (Bug#10164)
3491
febe6bea
JB
34922011-11-30 Juanma Barranquero <lekktu@gmail.com>
3493
3494 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3495
801a4313
EZ
34962011-11-30 Eli Zaretskii <eliz@gnu.org>
3497
3498 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3499 attributes are tested _before_ calling verify_row_hash, to protect
3500 against GCC re-ordering of the tests. (Bug#10164)
3501
2b56b87e
JD
35022011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3503
3504 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3505
3506 * xterm.c (handle_one_xevent): Only set async_visible and friends
3507 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3508 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3509 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3510
dbf31225
PE
35112011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3512
3513 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3514 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3515 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3516 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3517 All uses changed to use GCPRO1 etc.
3518 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3519 Revert to old implementation (i.e., before 2011-03-11).
3520
1305621b
YM
35212011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3522
3523 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3524 of scroll runs so as to avoid assigning disabled bogus rows and
3525 unnecessary graphics copy operations.
3526
8c9afb46
EZ
35272011-11-27 Eli Zaretskii <eliz@gnu.org>
3528
3529 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3530 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3531 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3532 (malloc, free, realloc, calloc): Redirect to e_* only when
3533 compiling Emacs.
3534
3535 * lisp.h (GCTYPEBITS): Move before first use.
3536 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3537 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3538 this macro definition.
3539
3540 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3541 _MSC_VER.
3542
54e9e3bf
JD
35432011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3544
6d5eb5b0
SM
3545 * gtkutil.c (xg_create_frame_widgets):
3546 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3547 present with Gtk+ 2.0.
3548
83aca1cb
PE
35492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 * fileio.c (Finsert_file_contents): Undo previous change; see
3552 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3553
5b76caa4
PE
35542011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3555
3556 Rename locals to avoid shadowing.
3557 * fileio.c (Finsert_file_contents):
3558 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3559 * process.c (wait_reading_process_output):
3560 Rename inner 'proc' to 'p' to avoid shadowing.
3561 Indent for consistency with usual Emacs style.
3562
8c535114
EZ
35632011-11-25 Eli Zaretskii <eliz@gnu.org>
3564
3565 * xdisp.c (redisplay_window): If cursor row is not fully visible
3566 after recentering, and scroll-conservatively is set to a large
3567 number, scroll window by a few more lines to make the cursor fully
3568 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3569 (start_display): Don't move to the next line if the display should
3570 start at a newline that is part of a display vector or an overlay
3571 string. (Bug#10119)
8c535114 3572
fa4fdb5c
JL
35732011-11-24 Juri Linkov <juri@jurta.org>
3574
3575 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3576 after the `MagickPingImage' call. (Bug#10112)
3577
90ec88df
CY
35782011-11-23 Chong Yidong <cyd@gnu.org>
3579
3580 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3581
56e2e794
MR
35822011-11-23 Martin Rudalics <rudalics@gmx.at>
3583
3584 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3585 making another buffer current. (Bug#10114)
3586
b6e64c41
GM
35872011-11-23 Glenn Morris <rgm@gnu.org>
3588
3589 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3590
6b21de18
CY
35912011-11-23 Chong Yidong <cyd@gnu.org>
3592
3593 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3594 using it (Bug#5984).
3595
b12cd789
EZ
35962011-11-22 Eli Zaretskii <eliz@gnu.org>
3597
3598 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3599 and header-lines, as they don't have one computed for them.
3600 (Bug#10098)
3601
3602 * .gdbinit (prow): Make displayed values more self-explaining.
3603 Add row's hash code.
3604
261b6fd4
LMI
36052011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3606
3607 * process.c (wait_reading_process_output): Fix asynchrounous
3608 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3609 (wait_reading_process_output): Add comment and URL.
261b6fd4 3610
e7cfd277
JD
36112011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3612
3613 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3614
a9b9b7f5
CY
36152011-11-21 Chong Yidong <cyd@gnu.org>
3616
3617 * window.c (Fnext_window, Fprevious_window): Doc fix.
3618
b0d15b4f
SM
36192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3620
3621 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3622
fe7a3057
JB
36232011-11-20 Juanma Barranquero <lekktu@gmail.com>
3624
3625 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3626
d2999b1a
MR
36272011-11-20 Martin Rudalics <rudalics@gmx.at>
3628
3629 * window.c (Fset_window_combination_limit): Rename argument
3630 STATUS to LIMIT.
3631 (Vwindow_combination_limit): Remove "status" from doc-string.
3632
d5ff9cd0
AS
36332011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3634
3635 * m/ibms390.h: Remove.
3636 * m/ibms390x.h: Don't include "ibms390.h".
3637
a5bb9bd3
SM
36382011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3639
3640 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3641 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3642
cd1181db
JB
36432011-11-20 Juanma Barranquero <lekktu@gmail.com>
3644
3645 * casetab.c (Fset_case_table):
3646 * charset.c (Fcharset_after): Fix typos.
3647
615a3b8d 36482011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3649
17e845af
PE
3650 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3651 Otherwise, valgrind does not work on some platforms.
3652 Problem reported by Andreas Schwab in
6a0bf43d
PE
3653 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3654 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3655 is set, removing the need for VIRT_ADDRESS_VARIES.
3656 (PURE_P): Use a more-efficient implementation that needs just one
3657 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3658 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3659 to 4 (xorl, subq, cmpq, setbe).
3660 * alloc.c (pure): Always extern now, since that's the
3661 VIRT_ADDR_VARIES behavior.
3662 (PURE_POINTER_P): Use a single comparison, not two, for
3663 consistency with the new puresize.h.
3664 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3665 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3666 Remove VIRT_ADDR_VARIES no longer needed.
3667
f8fe6f96
EZ
36682011-11-19 Eli Zaretskii <eliz@gnu.org>
3669
3670 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3671 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3672 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3673 behave as if the cursor position were at the window margin.
3674
3675 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3676 and the cursor position is out of bounds, behave as if the cursor
3677 position were at the window margin. (Bug#10075)
3678
df05a53c
CY
36792011-11-18 Chong Yidong <cyd@gnu.org>
3680
3681 * window.c (Fwindow_combination_limit): Make first argument
3682 non-optional, since it is meaningless for live windows like the
3683 selected window.
61ccba97 3684
2071918e
DA
36852011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3686
3687 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3688
b50a28de
SM
36892011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3690
3691 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3692 (graft_intervals_into_buffer): Simplify.
3693
015137db
EZ
36942011-11-18 Eli Zaretskii <eliz@gnu.org>
3695
3696 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3697 hash values of the two rows.
3698 (copy_row_except_pointers): Preserve the used[] arrays and the
3699 hash values of the two rows. (Bug#10035)
68c95424 3700 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3701
3702 * xdisp.c (row_hash): New function, body extracted from
3703 compute_line_metrics.
3704 (compute_line_metrics): Call row_hash, instead of computing the
3705 hash code inline.
3706
3707 * dispnew.c (verify_row_hash): Call row_hash for computing the
3708 hash code of a row, instead of duplicating code from xdisp.c.
3709
3710 * dispextern.h (row_hash): Add prototype.
3711
a2addb04
TH
37122011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3713
3714 * frame.c (delete_frame): Don't delete the terminal when the last
3715 X frame is closed if emacs is built with GTK toolkit.
3716
df85d315
JB
37172011-11-17 Juanma Barranquero <lekktu@gmail.com>
3718
3719 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3720
a0c2d0ae
MR
37212011-11-17 Martin Rudalics <rudalics@gmx.at>
3722
3723 * window.c (Vwindow_splits): Rename to
3724 Vwindow_combination_resize. Suggested by Juri Linkov.
3725 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3726 of Vwindow_splits.
3727
58179cce
JB
37282011-11-16 Juanma Barranquero <lekktu@gmail.com>
3729
7877f373
JB
3730 * nsfns.m (Fns_font_name):
3731 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3732
b6f67890
MR
37332011-11-16 Martin Rudalics <rudalics@gmx.at>
3734
3735 * window.h (window): Rename slot "nest" to "combination_limit".
3736 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3737 (Fset_window_nest): Rename to Fset_window_combination_limit.
3738 (Vwindow_nest): Rename to Vwindow_combination_limit.
3739 (recombine_windows, make_parent_window, make_window)
3740 (Fsplit_window_internal, saved_window)
3741 (Fset_window_configuration, save_window_save): Rename all
3742 occurrences of window_nest to window_combination_limit.
3743
c7015153
JB
37442011-11-15 Juanma Barranquero <lekktu@gmail.com>
3745
3746 * image.c (imagemagick_load_image): Fix typo.
3747
322ad6ec
EZ
37482011-11-14 Eli Zaretskii <eliz@gnu.org>
3749
3750 * xdisp.c (display_line): Move the call to
3751 highlight_trailing_whitespace before the call to
3752 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3753 faces of all the glyphs to compute ROW's hash value.
3754 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3755
f067b8ec
JB
37562011-11-14 Juanma Barranquero <lekktu@gmail.com>
3757
3758 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3759 just return (bug#10044).
3760
1e5b2111
EZ
37612011-11-12 Eli Zaretskii <eliz@gnu.org>
3762
7ef3cbd5
EZ
3763 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3764 with user-defined heap size. Bump the default size of the temacs
3765 heap to 27MB, to avoid memory warning when running temacs.
3766 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3767
1e5b2111
EZ
3768 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3769 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3770 (verify_row_hash) [XASSERTS]: New function.
3771 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3772 that the hash value of glyph rows is correct.
1e5b2111 3773
89d61221
MR
37742011-11-12 Martin Rudalics <rudalics@gmx.at>
3775
3776 * window.h (window): Remove splits slot.
3777 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3778 (Fdelete_other_windows_internal, make_parent_window)
3779 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3780 (Fset_window_configuration, save_window_save): Don't deal with
3781 split status of windows.
3782 (saved_window): Remove splits slot.
3783 (Vwindow_splits): Rewrite doc-string.
3784
97f18cc8
JD
37852011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3786
3787 * xfns.c (unwind_create_frame):
3788 * nsfns.m (unwind_create_frame):
3789 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3790 Vframe_list (Bug#9999).
3791
22a648b4
DA
37922011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3793
0b381c7e 3794 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3795
659afede
KH
37962011-11-11 Kenichi Handa <handa@m17n.org>
3797
3798 * callproc.c (Fcall_process): Set the member dst_multibyte of
3799 process_coding.
3800
9ac0394b
KH
38012011-11-11 Johan Bockgård <bojohan@gnu.org>
3802
3803 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3804 avoid a crash (bug#9496).
3805
2fbdc249
CY
38062011-11-09 Chong Yidong <cyd@gnu.org>
3807
3808 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3809 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3810
ac6b1f81
PE
38112011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3812
3813 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3814
09db192c
PE
38152011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3816
3817 Avoid some portability problems by eschewing 'extern inline' functions.
3818 The trivial performance wins aren't worth the portability hassles; see
3819 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3820 et seq.
3821 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3822 (window_box_width, window_box_left, window_box_left_offset)
3823 (window_box_right, window_box_right_offset): Undo previous change,
3824 by removing the "extern"s.
3825 * intervals.c (adjust_intervals_for_insertion)
3826 (adjust_intervals_for_deletion): Undo previous change,
3827 making these static again.
3828 (offset_intervals, temp_set_point_both, temp_set_point)
3829 (copy_intervals_to_string): No longer inline.
3830 * xdisp.c (window_text_bottom_y, window_box_width)
3831 (window_box_height, window_box_left_offset)
3832 (window_box_right_offset, window_box_left, window_box_right)
3833 (window_box): No longer inline.
3834
105216ed
CY
38352011-11-08 Chong Yidong <cyd@gnu.org>
3836
3837 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3838 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3839 Signal an error if not a live window.
105216ed
CY
3840 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3841 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3842
ae9e237f
JB
38432011-11-07 Juanma Barranquero <lekktu@gmail.com>
3844
3845 * lisp.h (syms_of_abbrev): Remove declaration.
3846 Reported by CHENG Gao <chenggao@royau.me>.
3847
c7aa8333
EZ
38482011-11-07 Eli Zaretskii <eliz@gnu.org>
3849
3850 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3851 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3852 of temacs in GUI mode.
3853
be7f5545
MR
38542011-11-07 Martin Rudalics <rudalics@gmx.at>
3855
3856 * window.h: Declare delete_all_child_windows instead of
3857 delete_all_subwindows.
3858 * window.c (Fwindow_nest, Fset_window_nest)
3859 (Fset_window_new_total, Fset_window_new_normal)
3860 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3861 (delete_all_subwindows): Rename to delete_all_child_windows.
3862 (Fdelete_other_windows_internal, Fset_window_configuration):
3863 Call delete_all_child_windows instead of delete_all_subwindows.
3864 * frame.c (delete_frame): Call delete_all_child_windows instead
3865 of delete_all_subwindows.
3866
ca78dc43
PE
38672011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3868
3869 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3870 This is also needed for porting to any host where GC_MARK_STACK is
3871 not GC_MAKE_GCPROS_NOOPS.
3872 (which_symbols): Use it.
3873
a0241d01
KH
38742011-11-07 Kenichi Handa <handa@m17n.org>
3875
3876 * coding.c (coding_set_destination): Check coding->src_pos only
3877 when coding->src_object is a buffer (bug#9910).
3878
3879 * process.c (send_process): Set the member src_multibyte of coding
3880 to 0 (bug#9911) when sending a unibyte text.
3881
3882 * callproc.c (Fcall_process): Set the member src_multibyte of
3883 process_coding to 0 (bug#9912).
3884
a64bfdfa 38852011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3886
3887 * xmenu.c (cleanup_widget_value_tree): New function.
3888 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3889 calling free_menubar_widget_value_tree directly (Bug#9830).
3890
cb41b32a
PE
38912011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3892
3893 Fix some portability problems with 'inline'.
3894 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3895 (window_box_width, window_box_left, window_box_left_offset)
3896 (window_box_right, window_box_right_offset): Declare extern.
3897 Otherwise, these inline functions do not conform to C99 and
3898 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3899 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3900 * intervals.c (adjust_intervals_for_insertion)
3901 (adjust_intervals_for_deletion): Now extern, because otherwise the
3902 extern inline functions 'offset_intervals' couldn't refer to it.
3903 (static_offset_intervals): Remove.
3904 (offset_intervals): Rewrite using the old contents of
3905 static_offset_intervals. The old version didn't conform to C99
3906 because an extern inline function contained a reference to an
3907 identifier with static linkage.
3908
b7041366
AS
39092011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3910
3911 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3912 GC.
3913
88a37c4d
EZ
39142011-11-06 Eli Zaretskii <eliz@gnu.org>
3915
3916 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3917 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3918 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3919 return Qleft_to_right.
3920
49745b39
CY
39212011-11-06 Chong Yidong <cyd@gnu.org>
3922
3923 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3924 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3925 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3926 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3927 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3928 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3929 (Fwindow_vscroll): Doc fix.
3930 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3931 argument, since it makes no sense to pass a live window and for
3932 consistency with window-child.
3933
1f05cd82
CS
39342011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3935
3936 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3937 support MSVC.
3938
22610910
JR
39392011-11-05 Jason Rumney <jasonr@gnu.org>
3940
3941 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3942 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3943 fonts (Bug#6029).
3944 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3945 bitwise arithmetic preventing use of unicode-sip and non-truetype
3946 opentype fonts.
3947
a06776b2
EZ
39482011-11-05 Eli Zaretskii <eliz@gnu.org>
3949
3ad924ba
EZ
3950 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3951 "emacs"-only part.
3952
a06776b2
EZ
3953 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3954 initialization code to keep similarity to xfns.c after changes
3955 from 2011-11-05.
3956
c9e7db78
JD
39572011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3958
a97f8f3f
JD
3959 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3960 (unwind_create_frame): New function (Bug#9943).
3961 (Fx_create_frame): Restructure code to be more similar to the one in
3962 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3963 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3964 Move terminal->reference_count++ just before making the frame official
3965 (Bug#9943).
3966
3967 * nsterm.m (x_free_frame_resources): New function.
3968 (x_destroy_window): Move code to x_free_frame_resources.
3969
c9e7db78 3970 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3971 (Fx_create_frame, x_create_tip_frame):
3972 Move terminal->reference_count++ just before making the frame
75f1671a 3973 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3974 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3975
a6fc3b5c
EZ
39762011-11-05 Eli Zaretskii <eliz@gnu.org>
3977
3978 Support MSVC build with newer versions of Visual Studio.
3979 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3980 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3981 nt/gmake.defs.
3982
3983 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3984 which are not supported by MSVC.
3985 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3986 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3987 bitfields.
3988 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3989 types in bitfields.
3990 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3991
3992 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3993
58179cce 39942011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3995
3996 Support MSVC build with newer versions of Visual Studio.
3997 * w32.c: Don't include w32api.h for MSVC.
3998 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3999
4000 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4001 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4002 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4003 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4004 e_* cousins.
4005 (alloca) [_MSC_VER]: Define to _alloca.
4006
4007 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4008
4009 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4010
a58c13ed
EZ
40112011-11-04 Eli Zaretskii <eliz@gnu.org>
4012
4013 * xdisp.c (note_mouse_highlight): If either of
4014 previous/next-single-property-change returns nil, treat that as
4015 the beginning or the end of the buffer. (Bug#9955)
4016
fe0b6370
JD
40172011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4018
a58c13ed 4019 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4020 label is not null (Bug#9951).
4021 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4022 may be NULL.
4023
89bd5ee1
EZ
40242011-11-04 Eli Zaretskii <eliz@gnu.org>
4025
4026 * window.c (Fwindow_body_size): Mention in the doc string that the
4027 return value is in frame's canonical units. (Bug#9949)
4028
84c3edb9
EZ
40292011-11-03 Eli Zaretskii <eliz@gnu.org>
4030
4e2fb5c7
EZ
4031 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4032
84c3edb9 4033 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4034 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4035 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4036
bc17a887
EZ
40372011-11-01 Eli Zaretskii <eliz@gnu.org>
4038
4039 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4040 Don't stop backward scan on the continuation glyph, even though
4041 its CHARPOS is positive.
6d5eb5b0
SM
4042 (mouse_face_from_buffer_pos, note_mouse_highlight):
4043 Rename cover_string to disp_string.
bc17a887 4044
4ee88440
MR
40452011-11-01 Martin Rudalics <rudalics@gmx.at>
4046
4047 * window.c (temp_output_buffer_show): Don't use
4048 Vtemp_buffer_show_specifiers.
4049 (Vtemp_buffer_show_specifiers): Remove unused variable.
4050
c2ff3c02
EZ
40512011-10-30 Eli Zaretskii <eliz@gnu.org>
4052
4053 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4054 past the beginning of the current glyph matrix.
4055
58179cce 40562011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4057
4058 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4059 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4060 HAVE_GTK3 (Bug#9869).
b77a6a7f 4061
3b574623
JD
4062 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4063 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4064
b77a6a7f
JD
4065 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4066
4067 * xterm.c: Declare x_handle_net_wm_state to return int.
4068 (handle_one_xevent): Check if we are iconified but don't have
4069 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4070 (get_current_wm_state): Return non-zero if not hidden,
4071 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4072 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4073 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4074 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4075
196e41e4
PE
40762011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4077
4078 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4079 so that this new function doesn't get optimized away by a
4080 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4081
021f2e1a
AS
40822011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4083
4084 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4085
8b058d44
EZ
40862011-10-29 Eli Zaretskii <eliz@gnu.org>
4087
4088 Fix the `xbytecode' command.
4089 * .gdbinit (xprintbytestr): New command.
b50a28de 4090 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4091 (xbytecode): Print the byte-code string as well.
4092
4452fb80
EZ
40932011-10-29 Kim Storm <storm@cua.dk>
4094
8b058d44
EZ
4095 * alloc.c (which_symbols): New function.
4096
21b72067
AS
40972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4098
4099 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4100 line. (Bug#9903)
4101
83ed7b5c
GM
41022011-10-29 Glenn Morris <rgm@gnu.org>
4103
4104 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4105 Not clear what it was for, and it causes various bugs. (Bug#9839)
4106
5a7a728b
EZ
41072011-10-28 Eli Zaretskii <eliz@gnu.org>
4108
4109 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4110 possible random value that matches one of those tested as
4111 condition to clear the mouse face.
4112
d3d0842f
CY
41132011-10-28 Chong Yidong <cyd@gnu.org>
4114
4115 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4116
31b39d13
DN
41172011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4118
4119 * window.c (make_window): Initialize phys_cursor_on_p.
4120
9aba6043
SM
41212011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4122
4123 * lisp.h (struct Lisp_Symbol): Update comments.
4124
c20992f4
JB
41252011-10-28 Juanma Barranquero <lekktu@gmail.com>
4126
4127 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4128
db4f02f2
EZ
41292011-10-28 Eli Zaretskii <eliz@gnu.org>
4130
4131 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4132 <oslsachem@gmail.com> for helping to debug this.
4133
4134 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4135 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4136 (g_b_init_get_glyph_outline_w): New static variables.
4137 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4138 (GetGlyphOutlineW_Proc): New typedefs.
4139 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4140 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4141 New functions.
4142 (w32font_open_internal, compute_metrics):
4143 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4144 instead of calling the "wide" APIs directly.
4145
4146 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4147
4148 * w32.h (syms_of_w32font): Add prototype.
4149
87e68db4
JB
41502011-10-27 Juanma Barranquero <lekktu@gmail.com>
4151
4152 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4153 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4154 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4155 (Fmove_to_window_line): Doc fix.
4156
435c1d67
CY
41572011-10-27 Chong Yidong <cyd@gnu.org>
4158
4159 * process.c (make_process): Set gnutls_state to NULL.
4160
4161 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4162 non-NULL, regardless of GNUTLS_INITSTAGE.
4163 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4164 an error. Set process slots as soon as we allocate them.
4165
4166 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4167
9c6c6f49
CY
41682011-10-27 Chong Yidong <cyd@gnu.org>
4169
9aba6043
SM
4170 * gnutls.c (emacs_gnutls_deinit): New function.
4171 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4172 (Fgnutls_deinit, Fgnutls_boot): Use it.
4173
4174 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4175 (deactivate_process): Call emacs_gnutls_deinit.
4176
657d08d3
JB
41772011-10-27 Juanma Barranquero <lekktu@gmail.com>
4178
4179 * image.c (x_create_x_image_and_pixmap):
4180 * w32.c (sys_rename, w32_delayed_load):
4181 * w32font.c (fill_in_logfont):
4182 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4183
5430d399
JB
41842011-10-26 Juanma Barranquero <lekktu@gmail.com>
4185
4186 * w32fns.c (w32_default_color_map): New function,
4187 extracted from Fw32_default_color_map.
a7ef684b 4188 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4189
fe0055fa
PE
41902011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4191
4192 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4193
e6346438
SM
41942011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4195
4196 * keyboard.c (test_undefined): New function (bug#9751).
4197 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4198
e112cc37
ET
41992011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4200
4201 * sysdep.c (init_sys_modes): Fix the check for the controlling
4202 terminal (Bug#6649).
4203
7b5d6677
EZ
42042011-10-20 Eli Zaretskii <eliz@gnu.org>
4205
4206 * dispextern.h (struct bidi_it): New member next_en_type.
4207
4208 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4209 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4210 current character, check also for next_en_type being WEAK_EN.
4211 (bidi_resolve_weak): Don't enter the expensive loop if the current
4212 position is before next_en_pos. Record the bidi type of the first
4213 non-ET, non-BN character we find, in addition to its position.
4214 (bidi_level_of_next_char): Invalidate next_en_type when
4215 next_en_pos is over-stepped.
4216
7da0b018
PE
42172011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4218
4219 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4220 * editfns.c: Rewrite current-time-zone so that it invokes
4221 the equivalent of (format-time-string "%Z") to get the time zone name.
4222 This fixes a bug when the time zone name contains characters that
4223 need converting from the system time locale to Emacs internal format.
4224 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4225 that patch fixed format-time-string to do the conversion, but
4226 I forgot to fix current-time-zone.
4227 (format_time_string): New function, containing most of
4228 what Fformat_time_string used to contain.
4229 (Fformat_time_string): Rewrite in terms of format_time_string.
4230 This doesn't change this function's behavior.
4231 (current-time-zone): Rewrite to use format_time_string.
4232 This fixes the bug reported by Michael Schierl in
4233 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4234 Jason Rumney's 2007-06-07 change worked around this bug, but
4235 didn't fix it.
4236 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4237
8547b010
EZ
42382011-10-19 Eli Zaretskii <eliz@gnu.org>
4239
4240 * xdisp.c (start_display): If the character at POS is displayed
4241 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4242 (try_window_reusing_current_matrix): If a line ends in a display
4243 vector or the next line starts in a display vector, continue
4244 redrawing the window even though the character position of
4245 start_row was reached.
8547b010
EZ
4246 (Bug#9771, part 2)
4247
4e948d15
CY
42482011-10-18 Chong Yidong <cyd@gnu.org>
4249
4250 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4251 with nobreak-char-display too.
4252
4787455f
EZ
42532011-10-18 Eli Zaretskii <eliz@gnu.org>
4254
4255 Fix part 3 of bug#9771.
4256 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4257 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4258 non-neutral characters if the current character is a paragraph
4259 separator (a.k.a. Newline). This avoids running the same
4260 expensive loop twice, once when we consume the preceding newline
4261 and the other time when the line actually needs to be displayed.
4262 Avoid the loop when we see neutrals on the base embedding level
4263 following a character whose directionality is the same as the
4264 paragraph's. This avoids running the expensive loop when a line
4265 ends in a long sequence of neutrals, like control characters.
4266 Add assertion against STRONG_AL type. Slightly rearrange code
4267 that determines the type of a neutral given the first non-neutral
4268 that follows it.
4269 (bidi_level_of_next_char): Set next_en_pos to zero when
4270 invalidating its info.
4271
2c91f553
EZ
42722011-10-17 Eli Zaretskii <eliz@gnu.org>
4273
4274 * xdisp.c (push_display_prop): Determine whether to record string
4275 or buffer position by IT->string, not by IT->method. Allow
4276 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4277 (move_it_vertically_backward): Don't look for character position
4278 immediately after the newline when in a continuation line.
4279 (Bug#9771, part 1)
2c91f553 4280
c7b08b0d
MR
42812011-10-15 Martin Rudalics <rudalics@gmx.at>
4282
4283 * window.c (coordinates_in_window): Rewrite and delabelize
4284 vertical border check. (Bug#5357) (Bug#9618)
4285
6b02f655
SM
42862011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4287
4288 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4289 errors in XSetWindowBorder (bug#9310).
4290
81d40c92
DA
42912011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4292
4293 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4294 avoid crash when xmalloc overrun checking is enabled.
4295
d4172c3b
EZ
42962011-10-13 Eli Zaretskii <eliz@gnu.org>
4297
4298 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4299 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4300 cursor motion with <left> and <right> arrow keys.
4301
4302 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4303 some callers set that themselves.
4304
b00eea75
EZ
43052011-10-12 Eli Zaretskii <eliz@gnu.org>
4306
4307 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4308 display string and the previous row comes from the same string and
4309 is empty. (Bug#9739) (Bug#9738)
4310
8fe012c4
SM
43112011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4312
4313 * doc.c (get_doc_string): Encode file name (bug#9735).
4314
0074aef2
EZ
43152011-10-12 Eli Zaretskii <eliz@gnu.org>
4316
79beb178
EZ
4317 * bidi.c (bidi_level_of_next_char):
4318 * xdisp.c (get_visually_first_element): Remove old incorrect
4319 comments regarding the Unicode Line Separator character.
4320
0074aef2
EZ
4321 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4322
6e4b3fbe
DA
43232011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4324
4325 * alloc.c (Fgc_status): Do not access beyond zombies array
4326 boundary if nzombies > MAX_ZOMBIES.
4327 * alloc.c (dump_zombies): Add missing format specifier.
4328
0324f3af
PE
43292011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4330
b5525cac
PE
4331 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4332 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4333
0324f3af
PE
4334 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4335 Some packages use them to denote characters with modifiers.
4336
e9b5f888
AS
43372011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4338
4339 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4340 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4341 matching a pp-number. Rename parameter var to var1.
4342
127827c0
SM
43432011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4344
4345 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4346
c8fd3bd0
GM
43472011-10-08 Glenn Morris <rgm@gnu.org>
4348
4349 * callint.c (Fcall_interactively): Give a more explicit error for the
4350 'c' case with a non-character input. (Bug#8479)
4351
352ec8ff
EZ
43522011-10-08 Eli Zaretskii <eliz@gnu.org>
4353
03669ccb
EZ
4354 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4355 lines.
7061c986
EZ
4356 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4357 lines that are hscrolled on the left.
03669ccb 4358
352ec8ff
EZ
4359 * dispnew.c (buffer_posn_from_coords): Account for a possible
4360 presence of header-line. (Bug#4426)
4361
a66cfb1c
SM
43622011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4363
6b02f655
SM
4364 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4365 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4366
7c5ee88e
PE
43672011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4368
4369 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4370 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4371 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4372 this makes Emacs dump core during garbage collection on rare
4373 occasions. sizeof is obviously inferior to offsetof here, so
4374 stick with offsetof.
4375 (GC_POINTER_ALIGNMENT): New macro.
4376 (mark_memory): Omit 3rd (offset) arg; caller changed.
4377 Don't assume EMACS_INT alignment is the same as pointer alignment.
4378
df1bbe5b
SM
43792011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4380
4381 * keyboard.c (read_key_sequence_remapped): New var.
4382 (read_key_sequence): Compute remapping in the right buffer.
4383 (command_loop_1): Use read_key_sequence's remapping directly.
4384
51553db6
SM
43852011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4386
32c1fffd
SM
4387 * dired.c (file_name_completion): Don't expand file name.
4388 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4389 before checking file name handler.
4390
51553db6
SM
4391 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4392 they've been requested explicitly (bug#9591).
4393
b6bd1599 43942011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4395
4396 * keymap.c (Fsingle_key_description): Use make_specified_string
4397 instead of build_string to build string from push_key_description.
4398 (Bug#5193)
4399
f701dc2a
PE
44002011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4401
4222c55d
PE
4402 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4403 This fixes a Y2038 bug on 64-bit hosts.
4404 * buffer.c (reset_buffer):
4405 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4406 (Fclear_buffer_auto_save_failure):
4407 Use 0, not -1, to represent an unset failure time, since time_t
4408 might not be signed.
4409
f701dc2a
PE
4410 Remove dependency on glibc malloc internals.
4411 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4412 Move back here from lisp.h, but with their new implementations.
4413 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4414 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4415 * charset.c (charset_table_init): New static var.
4416 (syms_of_charset): Use it instead of xmalloc. This removes a
4417 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4418 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4419 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4420 Move back to alloc.c.
4421 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4422 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4423
9ceebf39
JD
44242011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4425
4426 * nsterm.m (windowDidResize): Call x_set_window_size only when
4427 ns_in_resize is true. Otherwise set pixelwidth/height and
4428 call change_frame_size (Bug#9628).
4429
cb993c58
PE
44302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4431
3930c88b
PE
4432 Port --enable-checking=all to Fedora 14 x86-64.
4433 * charset.c (syms_of_charset): Also account for glibc malloc's
4434 internal overhead when calculating the initial malloc maximum.
4435
cb993c58
PE
4436 Port --enable-checking=all to Fedora 14 x86.
4437 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4438 Move to lisp.h.
4439 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4440 (overrun_check_realloc, overrun_check_free):
4441 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4442 That way, xmalloc returns a properly-aligned pointer even if
4443 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4444 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4445 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4446 into account when calculating the initial malloc maximum.
4447 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4448 Move here from alloc.c, so that charset.c can use it too.
4449 Properly align; the old code wasn't right for common 32-bit hosts
4450 when configured with --enable-checking=all.
4451 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4452 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4453
31bed486
EZ
44542011-09-29 Eli Zaretskii <eliz@gnu.org>
4455
04c70788 4456 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4457 use EDOM.
4458
fbcaa2f3
EZ
44592011-09-28 Eli Zaretskii <eliz@gnu.org>
4460
4461 * xdisp.c (compute_display_string_end): If there's no display
4462 string at CHARPOS, return -1.
4463
4464 * bidi.c (bidi_fetch_char): When compute_display_string_end
4465 returns a negative value, treat the character as a normal
4466 character not covered by a display string. (Bug#9624)
4467
a239d4e9
JB
44682011-09-28 Juanma Barranquero <lekktu@gmail.com>
4469
4470 * lread.c (Fread_from_string): Fix typo in docstring.
4471
88652fd5
EZ
44722011-09-27 Eli Zaretskii <eliz@gnu.org>
4473
4474 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4475 newline, reseat the iterator instead of bidi-iterating there one
4476 character at a time. (Bug#9610)
32c1fffd
SM
4477 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4478 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4479
ed497dd4
AS
44802011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4481
4482 * lread.c (readevalloop): Use correct code for NBSP.
4483 (read1): Likewise. (Bug#9608)
4484
b2bf61aa
MA
44852011-09-25 Michael Albinus <michael.albinus@gmx.de>
4486
4487 * dbusbind.c (Fdbus_register_signal): When service is not
4488 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4489
32bbb17c
GM
44902011-09-25 Glenn Morris <rgm@gnu.org>
4491
4492 * buffer.c (truncate-lines): Doc fix.
4493
94e0933e
CY
44942011-09-24 Chong Yidong <cyd@stupidchicken.com>
4495
4496 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4497 (Fset_window_next_buffers): Doc fix.
4498
cddde921
GM
44992011-09-24 Glenn Morris <rgm@gnu.org>
4500
4501 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4502
1260aef1
PE
45032011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4504
25b4bfa0
PE
4505 Fix minor problems found by static checking.
4506 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4507 * indent.c (Fvertical_motion): Fix == vs = typo.
4508
e3cbd34b
EZ
45092011-09-24 Eli Zaretskii <eliz@gnu.org>
4510
a66cfb1c
SM
4511 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4512 Default value is now t. Doc fix.
6bf7006f 4513
e3cbd34b 4514 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4515 logic when moving up, not only when moving down. Fix the
e3cbd34b 4516 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4517 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4518
4519 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4520 CHARPOS is covered by a display string which includes newlines.
4521 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4522 is covered by a display string with embedded newlines.
4523
a3de0cbd
MA
45242011-09-24 Michael Albinus <michael.albinus@gmx.de>
4525
4526 * dbusbind.c (Fdbus_register_signal): Add match rule to
4527 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4528 (Fdbus_register_method, Vdbus_registered_objects_table):
4529 Fix docstring.
a3de0cbd 4530
b260039d
JM
45312011-09-24 Jim Meyering <meyering@redhat.com>
4532
32c1fffd 4533 do not ignore write error for any output size
b260039d
JM
4534 The previous change was incomplete.
4535 While it makes emacs --batch detect the vast majority of stdout
4536 write failures, errors were still ignored whenever the output size is
4537 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4538 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4539 && echo FAIL: ignored write error
4540 FAIL: ignored write error
4541 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4542 && echo FAIL: ignored write error
4543 FAIL: ignored write error
4544 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4545
8eca8a7c
AS
45462011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4547
4548 * emacs.c (Fkill_emacs): In noninteractive mode exit
4549 non-successfully if a write error occurred on stdout. (Bug#9574)
4550
3341db62
EZ
45512011-09-21 Eli Zaretskii <eliz@gnu.org>
4552
4553 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4554 the xassert test.
4555
4556 * dispextern.h (struct it): Update the comment documenting what
4557 can it->OBJECT be.
4558
8c203dbf
EZ
45592011-09-20 Eli Zaretskii <eliz@gnu.org>
4560
4561 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4562 a display string, extend search for cursor position to end of row.
4563 (find_row_edges): If the row ends in a newline from a display
4564 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4565 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4566 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4567 non-empty line. Fixes confusing cursor motion with arrow keys at
4568 the beginning of a line that starts with whitespace.
8c203dbf 4569
a4824228
LMI
45702011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4571
4572 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4573 (bug#9493).
4574
33ed493b
CY
45752011-09-18 Chong Yidong <cyd@stupidchicken.com>
4576
4577 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4578 boolean (Bug#9154).
4579
56cd55c8
EZ
45802011-09-18 Eli Zaretskii <eliz@gnu.org>
4581
4582 * xdisp.c (display_line): Record maximum and minimum buffer
4583 positions even if no glyphs were produced (e.g., by a zero-width
4584 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4585 buffer positions that will be removed from the glyph row because
4586 they don't fit.
c02dcedf
EZ
4587 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4588 column is beyond frame width: don't subtract 1 "pixel" when
4589 computing width of the stretch.
3e62b7e0
EZ
4590 (reseat_at_next_visible_line_start): Undo the change made on
4591 2011-09-17 that saved paragraph information and restored it after
4592 the call to `reseat'. (Bug#9545)
56cd55c8 4593
5ed99d36 45942011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4595
4596 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4597 and turn window cursor on if cleared (Bug#9415).
4598
5ed99d36 45992011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4600
4601 * search.c (boyer_moore): Take unibyte characters from pattern
4602 literally. (Bug#9458)
4603
9bade7b2
EZ
46042011-09-18 Eli Zaretskii <eliz@gnu.org>
4605
4606 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4607
e5e9d610
PE
46082011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4609
87e4427a
PE
4610 Fix minor problem found by static checking.
4611 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4612 initialized, to pacify gcc -Wuninitialized.
4613
e5e9d610
PE
4614 * fileio.c: Report proper errno when syscall falls.
4615 (Finsert_file_contents): Save and restore errno,
4616 so that report_file_error outputs the correct diagnostic.
4617 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4618
a1674f0b
EZ
46192011-09-18 Eli Zaretskii <eliz@gnu.org>
4620
4621 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4622
fbfb6dd4
EZ
46232011-09-17 Eli Zaretskii <eliz@gnu.org>
4624
4625 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4626 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4627
bb187662
EZ
46282011-09-17 Eli Zaretskii <eliz@gnu.org>
4629
1137e8b8 4630 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4631 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4632
4633 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4634 (bidi_find_paragraph_start): Search back for paragraph beginning
4635 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4636 (bidi_move_to_visually_next): Only trigger paragraph-related
4637 computations when the last character is a newline or at EOB, not
4638 just any NEUTRAL_B. (Bug#9470)
4639
bb187662
EZ
4640 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4641 truncated lines if point is covered by a display string. (Bug#9524)
4642
2e621251
PE
46432011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4644
4645 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4646 (cons_to_x_long): New function.
4647 (lisp_data_to_selection_data): Use it. Correct the test for
4648 short-versus-long data; it was negated. Break out of vector
4649 loop, for efficiency, when a long datum is discovered.
4650
91a15bc6
SM
46512011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4652
4653 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4654
b41c3a35
EZ
46552011-09-16 Eli Zaretskii <eliz@gnu.org>
4656
4657 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4658 GCC PR/17406) by declaring this function with external scope.
4659
7812ba2d
PE
46602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4661
4662 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4663 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4664
cf7edc2a
AS
46652011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4666
4667 * editfns.c (Fformat): Correctly handle text properties on "%%".
4668
bd01620e
EZ
46692011-09-15 Eli Zaretskii <eliz@gnu.org>
4670
4671 * xterm.c (x_draw_composite_glyph_string_foreground):
4672 * w32term.c (x_draw_composite_glyph_string_foreground):
4673 * term.c (encode_terminal_code):
4674 * composite.c (composition_update_it, get_composition_id):
4675 * xdisp.c (get_next_display_element)
4676 (fill_composite_glyph_string): Add comments about special meaning
4677 of TAB characters in a composition.
4678
a02719a3
PE
46792011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4680
4681 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4682 This occurs when processing a multibyte format.
4683 Problem reported by Wolfgang Jenker.
a02719a3 4684
72589a3c
JB
46852011-09-15 Johan Bockgård <bojohan@gnu.org>
4686
4687 * xdisp.c (try_cursor_movement): Only check for exact match if
4688 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4689
1c14176c
PE
46902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4691
4692 Remove unused external symbols.
4693 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4694 * xdisp.c (calc_pixel_width_or_height): Now static.
4695 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4696 * indent.c (check_display_width):
4697 * w32term.c: Fix comment to match code.
4698 * xterm.c, xterm.h (x_catching_errors): Remove.
4699
d2eea5b5
PE
47002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4701
4702 * xselect.c: Use signed conversions more consistently (Bug#9498).
4703 (selection_data_to_lisp_data): Assume incoming selection data are
4704 signed integers, not unsigned. This is to be consistent with
4705 outgoing selection data, which was modified to use signed integers
4706 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4707 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4708 expects long, not unsigned long.
4709
46888499
EZ
47102011-09-14 Eli Zaretskii <eliz@gnu.org>
4711
4712 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4713 computation of loop end. Reported by Johan Bockgård
4714 <bojohan@gnu.org>.
4715
ef8ef9fb
CY
47162011-09-13 Chong Yidong <cyd@stupidchicken.com>
4717
4718 * frame.c (Fother_visible_frames_p): Function deleted.
4719
fa819fed
EZ
47202011-09-12 Eli Zaretskii <eliz@gnu.org>
4721
4722 * indent.c (compute_motion): Process display vector front to back
4723 rather than the other way around. (Bug#2496)
4724
2ba8e008
SM
47252011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4726
4727 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4728
20f53c69
CY
47292011-09-11 Chong Yidong <cyd@stupidchicken.com>
4730
4731 * minibuf.c (Fread_from_minibuffer): Doc fix.
4732
d562d7a4
EZ
47332011-09-11 Eli Zaretskii <eliz@gnu.org>
4734
4735 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4736 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4737
1c4d7f3d
LMI
47382011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4739
4740 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4741 value for non-existent files.
4742
b885bf36
EZ
47432011-09-11 Eli Zaretskii <eliz@gnu.org>
4744
4745 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4746 set its "size" to -1. This will set the modtime_size field of
4747 the corresponding buffer to -1, which is what
4748 verify-visited-file-modtime expects for files that do not exist.
4749 (Bug#9139)
4750
6612f0bf
PE
47512011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4754 here ...
4755 * lisp.h: ... from here. push_key_description is no longer
4756 defined in keyboard.c, so its declaration should not be in
4757 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4758 logically belongs with push_key_description.
4759
dfb3f755
PE
47602011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4761
4762 * buffer.h: Include <sys/types.h> instead of <time.h>.
4763 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4764 Problem reported by Herbert J. Skuhra.
4765
3134906c
LMI
47662011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4767
4768 * xml.c (parse_region): Make the parsing work for
4769 non-comment-starting XML files again (bug#9144).
4770
8d903f4e
AS
47712011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4772
4773 * image.c (gif_load): Fix calculation of bottom and right corner.
4774 (Bug#9468)
4775
80ad64f4
EZ
47762011-09-10 Eli Zaretskii <eliz@gnu.org>
4777
4778 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4779 redisplay in small windows.
4780
208a048d
EZ
47812011-09-09 Eli Zaretskii <eliz@gnu.org>
4782
4783 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4784
9b1c252e
MR
47852011-09-08 Martin Rudalics <rudalics@gmx.at>
4786
4787 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4788 Operate on live windows only.
4789
2949f33b
JB
47902011-09-08 Juanma Barranquero <lekktu@gmail.com>
4791
4792 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4793
e08dcafd
EZ
47942011-09-07 Eli Zaretskii <eliz@gnu.org>
4795
4796 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4797 only under bidi iteration.
4798
115b96bd
JD
47992011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4800
4801 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4802
c8199d0f
PE
48032011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4804
4805 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4806 Without this fix, the command to link temacs failed due to an
4807 undefined symbol __builtin_isnan. This is because
4808 /usr/include/iso/math_c99.h #defines isnan(x) to
4809 __builtin_isnan(x), but the bundled gcc, which identifies itself
4810 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4811 a __builtin_isnan.
4812 * floatfns.c (isnan): #undef, and then #define to a clone of
4813 what's in data.c.
4814 (Fisnan): Always define, since it's always available now.
4815 (syms_of_floatfns): Always define isnan at the Lisp level.
4816
e39b275c 48172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4818
4819 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4820
b2db44d9 48212011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4822
f4af5137 4823 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4824 The previous code assumed that file offsets (off_t values) fit in
4825 EMACS_INT variables, which is not true on typical 32-bit hosts.
4826 The code messed up by falsely reporting buffer overflow in cases
4827 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4828 when "big" contains more than 2**29 bytes, even though this
4829 inserts just one byte and does not overflow the buffer.
4830 (Finsert_file_contents): Store file offsets as off_t
4831 values, not as EMACS_INT values. Check for overflow when
4832 converting between EMACS_INT and off_t. When checking for
4833 buffer overflow or for overlap, take the offsets into account.
4834 Don't use EMACS_INT for small values where int suffices.
4835 When checking for overlap, fix a typo: ZV was used where
4836 ZV_BYTE was intended.
4837 (Fwrite_region): Don't assume off_t fits into 'long'.
4838 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4839
ecfc0a49
MA
48402011-09-05 Michael Albinus <michael.albinus@gmx.de>
4841
4842 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4843
6511acf2 48442011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4845
0999621a 4846 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4847
4848 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4849 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4850 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4851 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4852 (modify_event_symbol): Do not assume that the length of
4853 name_alist_or_stem is safe to alloca and fits in int.
4854 (Fexecute_extended_command): Likewise for function name and binding.
4855 (Frecursion_depth): Wrap around reliably on integer overflow.
4856 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4857 since some callers pass EMACS_INT values.
4858 (Fsingle_key_description): Don't crash if symbol name contains more
4859 than MAX_ALLOCA bytes.
4860 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4861 (get_minibuffer): Arg is now EMACS_INT, not int.
4862 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4863 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4864 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4865
2be7d702
PE
4866 * dbusbind.c (signature_cat): New function.
4867 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4868 Do not overrun buffer; instead, report string overflow.
4869
9d1df220
PE
4870 * dispnew.c (add_window_display_history): Don't overrun buffer.
4871 Truncate instead; this is OK since it's just a log.
4872
33ef5c64
PE
4873 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4874 even if the time zone offset is outlandishly large.
4875 Don't mishandle offset == INT_MIN.
4876
66c6fdd5
PE
4877 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4878 when creating daemon; the previous buffer-overflow check was incorrect.
4879
d749b01b
PE
4880 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4881 which has the guts of the old verror function.
4882
b5cd1905
PE
4883 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4884 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4885
6e1a67fb
PE
4886 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4887 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4888 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4889 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4890 length of string rather than counting it via multiple sprintfs;
4891 that's simpler and more reliable.
c21721cc
PE
4892 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4893 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4894 sprintf, in case result does not fit in int.
4895
c57b67fc
PE
4896 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4897 (fontset_from_font): Print it.
4898
8a401434
PE
4899 * frame.c (tty_frame_count): Now printmax_t, not int.
4900 (make_terminal_frame, set_term_frame_name): Print it.
4901 (x_report_frame_params): In X, window IDs are unsigned long,
4902 not signed long, so print them as unsigned.
4903 (validate_x_resource_name): Check for implausibly long names,
4904 and don't assume name length fits in 'int'.
4905 (x_get_resource_string): Don't blindly alloca invocation name;
4906 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4907 not fit in int.
4908
6e1a67fb
PE
4909 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4910 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4911 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4912
0df02bf3
PE
4913 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4914 Use esprintf, not sprintf, in case result does not fit in int.
4915
48e30793
PE
4916 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4917 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4918 it as a large positive number.
4919 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4920 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4921
a66ff6d8
PE
4922 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4923 in case result does not fit in int.
4924
aca216ff
PE
4925 * print.c (float_to_string): Detect width overflow more reliably.
4926 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4927 buffer overrun. Don't assume list length fits in 'int'. Treat
4928 print length of 0 as 0, not as infinity; to be consistent with other
4929 uses of print length in this function. Don't overflow print length
4930 index. Don't assume hash table size fits in 'long', or that
4931 vectorlike size fits in 'unsigned long'.
4932
31c286f7
PE
4933 * process.c (make_process): Use printmax_t, not int, to format
4934 process-name gensyms.
4935
55e5faa1
PE
4936 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4937
80f2e268
PE
4938 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4939 to avoid potential buffer overrun.
4940
670741ab
PE
4941 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4942 if X resource line is longer than 512 bytes.
4943
b7163a50
PE
4944 * xfns.c (x_window): Make sprintf buffer a bit bigger
4945 to avoid potential buffer overrun.
4946
ae58ff1f
PE
4947 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4948
c43c8a6a
PE
4949 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4950
3f8236f4
PE
49512011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4952
53e9fe90 4953 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4954 Without these, Emacs silently mishandles large integers sometimes.
4955 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4956 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4957
6511acf2
PE
4958 * xdisp.c (try_window_id): Check Emacs fixnum range before
4959 converting to 'int'.
806add1d 4960
6511acf2 4961 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4962 Check that an Emacs fixnum is in range before assigning it to 'int'.
4963 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4964 values converted from Emacs fixnums.
4965 (Frecenter): Don't wrap around a line count if it is out of 'int'
4966 range; instead, treat it as an extreme value.
4967 (Fset_window_configuration, compare_window_configurations):
4968 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4969
6511acf2
PE
4970 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4971 that can exceed INT_MAX. Check that EMACS_INT value is in range
4972 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4973 (match_limit): Don't assume that a fixnum can fit in 'int'.
4974
6511acf2 4975 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4976 exceed INT_MAX.
4977
6511acf2 4978 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4979 (Fvertical_motion): Don't wrap around LINES values that don't fit
4980 in 'int'. Instead, treat them as extreme values. This is good
4981 enough for windows, which can't have more than INT_MAX lines anyway.
4982
fcb901a7
LMI
49832011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4984
0f2f6b6d
LMI
4985 * Require libxml/parser.h to avoid compilation warning.
4986
fcb901a7
LMI
4987 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4988
4989 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4990 since this reportedly can destroy thread storage.
4991
6e20a0d4
CY
49922011-08-30 Chong Yidong <cyd@stupidchicken.com>
4993
4994 * syntax.c (find_defun_start): Update all cache variables if
4995 exiting early (Bug#9401).
4996
148ae00e
EZ
49972011-08-30 Eli Zaretskii <eliz@gnu.org>
4998
f6cfbd8f
EZ
4999 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5000
148ae00e
EZ
5001 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5002 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5003 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5004
5005 * term.c (tty_append_glyph): New function.
5006 (produce_stretch_glyph): Static function and its prototype deleted.
5007
a66cfb1c
SM
5008 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5009 Add prototypes.
148ae00e 5010
c4a07a4c
PE
50112011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5012
5013 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5014 when checking :margin (Bug#9390).
5015 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5016 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5017 so that the name doesn't mislead. All uses changed.
5018
6bc8cd65
JB
50192011-08-28 Johan Bockgård <bojohan@gnu.org>
5020
5021 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5022 set_tty_hooks.
5023
dca4927e
EZ
50242011-08-27 Eli Zaretskii <eliz@gnu.org>
5025
5026 * xdisp.c (move_it_to): Don't bail out early when reaching
5027 position beyond to_charpos, if we are scanning backwards.
5028 (move_it_vertically_backward): When DY == 0, make sure we get to
5029 the first character in the line after the newline.
5030
f2cad773
PE
50312011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5032
5033 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5034 (ccl_driver): Do not generate an out-of-range pointer.
5035 (Fccl_execute_on_string): Remove unnecessary check for
5036 integer overflow, noted by Stefan Monnier in
5037 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5038 Remove a FIXME that didn't need fixing.
5039 Simplify the newly-introduced buffer reallocation code.
5040
0cae2cdb
JB
50412011-08-27 Juanma Barranquero <lekktu@gmail.com>
5042
5043 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5044
5fc295a4 50452011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5046
70c60eb2 5047 Integer and memory overflow issues (Bug#9196).
726e0ab1 5048
d31850da
PE
5049 * doc.c (get_doc_string): Rework so that
5050 get_doc_string_buffer_size is the actual buffer size, rather than
5051 being 1 less than the actual buffer size; this makes xpalloc more
5052 convenient.
5053
a69fbedb
PE
5054 * image.c (x_allocate_bitmap_record, cache_image):
5055 * xselect.c (Fx_register_dnd_atom):
5056 Simplify previous changes by using xpalloc.
5057
fe5c5d37
PE
5058 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5059 since either will do and ptrdiff_t is convenient with xpalloc.
5060
0065d054
PE
5061 * charset.c (charset_table_size)
5062 (struct charset_sort_data.priority): Now ptrdiff_t.
5063 (charset_compare): Don't overflow if priorities differ greatly.
5064 (Fsort_charsets): Don't assume list length fits in int.
5065 Check for size-calculation overflow when allocating sort data.
5066 (syms_of_charset): Allocate an initial charset table that is
5067 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5068
5069 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5070
5071 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5072 The actual value is always <= INT_MAX, and leaving it unsigned made
5073 overflow checking harder.
5074
5075 * dispextern.h (struct glyph_matrix.rows_allocated)
5076 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5077 with xpalloc. The values are still always <= INT_MAX.
5078
5079 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5080
5081 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5082 (SAFE_NALLOCA): New macro.
5083
5084 * region-cache.c (struct boundary.pos, find_cache_boundary)
5085 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5086 (set_cache_region, invalidate_region_cache)
5087 (revalidate_region_cache, know_region_cache, region_cache_forward)
5088 (region_cache_backward, pp_cache):
5089 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5090 so that ptrdiff_t * can be passed to xpalloc.
5091 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5092 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5093 (pp_cache): Don't assume cache_len fits in int.
5094 * region-cache.h: Adjust extern decls to match.
5095
5096 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5097 EMACS_INT, since either will do, for xpalloc.
5098
5099 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5100 (xnmalloc, xnrealloc, xpalloc): New functions.
5101
726e0ab1
PE
5102 * bidi.c (bidi_shelve_header_size): New constant.
5103 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5104 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5105
51f30bc5 5106 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5107 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5108 (overlay_strings):
5109 Don't update size of array until after memory allocation succeeds,
5110 because xmalloc/xrealloc may not return.
0065d054
PE
5111 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5112 now that we have proper integer overflow checking.
5113 (record_overlay_string, overlay_strings): Catch overflows when
5114 calculating size of overlay_str_buf.
726e0ab1 5115
0065d054
PE
5116 * callproc.c (Fcall_process): Check for size overflow when
5117 calculating size of args2.
5118 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5119 Normally we prefer signed values, but sticking with ptrdiff_t would
5120 require adding more-complicated checks.
726e0ab1
PE
5121
5122 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5123 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5124 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5125 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5126
5127 * character.c (Fstring): Check for size-calculation overflow.
5128
5129 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5130 unnecessary integer overflow. Check for size overflow.
5131 (encode_coding_object): Don't update size until xmalloc succeeds.
5132
5133 * composite.c (get_composition_id): Check for overflow in glyph
5134 length calculations.
5135
5136 Integer and memory overflow fixes for display code.
5137 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5138 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5139 (scrolling_window): Check for overflow in size calculations.
5140 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5141 Don't assume glyph table len fits in int.
5142 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5143 (row_table_size): Now ptrdiff_t, not int.
5144 (scrolling_window): Avoid overflow in size calculations.
5145 Don't update size until allocation succeeds.
5146 * fns.c (concat): Check for overflow in size calculations.
5147 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5148 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5149 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5150
5151 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5152 (get_doc_string): Check for size calculation overflow.
5153 Don't update size until allocation succeeds.
5154 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5155 EMACS_INT, where ptrdiff_t will do.
5156 (Fsubstitute_command_keys): Check for string overflow.
5157
5158 * editfns.c (set_time_zone_rule): Don't assume environment length
5159 fits in int.
5160 (message_length): Now ptrdiff_t, not int.
5161 (Fmessage_box): Don't update size until allocation succeeds.
5162 Don't assume message length fits in int.
5163 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5164
0065d054
PE
5165 * emacs.c (main): Do not reallocate argv, since there is a null at
5166 the end that can be overwritten, and this way there's no need to
5167 worry about size-calculation overflow.
5168 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5169
5170 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5171 alloc succeeds.
5172 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5173
5174 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5175 (x_set_scroll_bar_width, x_figure_window_size):
5176 Check for integer overflow.
5177 (x_set_alpha): Do not assume XINT fits in int.
5178
5179 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5180 This is for the members text_lines, text_cols, total_lines, total_cols,
5181 where the system imposes an 'int' limit.
5182
5183 * fringe.c (Fdefine_fringe_bitmap):
5184 Don't update size until alloc works.
5185
5186 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5187 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5188
5189 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5190 Check for size-calculation overflow.
5191 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5192 do, as we prefer signed integers.
5193 (id_to_widget.max_size, id_to_widget.used)
5194 (xg_store_widget_in_map, xg_remove_widget_from_map)
5195 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5196 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5197 Use and return ptrdiff_t, not int.
5198 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5199 * gtkutil.h: Change prototypes to match the above.
5200
5201 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5202 are duplicate now that they've been promoted to lisp.h.
5203 (x_allocate_bitmap_record, x_alloc_image_color)
5204 (make_image_cache, cache_image, xpm_load):
5205 Don't update size until alloc is done.
5206 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5207 (x_detect_edges):
3256efce 5208 Check for size calculation overflow.
726e0ab1
PE
5209 (ct_colors_allocated_max): New constant.
5210 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5211 overflow.
3256efce 5212
726e0ab1
PE
5213 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5214 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5215 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5216 Use ptrdiff_t, not int, to count maps.
5217 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5218 calculations. Don't update size until allocation succeeds.
5219 Redo calculations to avoid overflow.
726e0ab1
PE
5220 * keyboard.h: Change prototypes to match the above.
5221
5222 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5223 to count maps.
5224 (current_minor_maps): Check for size calculation overflow.
5225 * keymap.h: Change prototypes to match the above.
5226
5227 * lread.c (read1, init_obarray): Don't update size until alloc done.
5228
5229 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5230 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5231
726e0ab1
PE
5232 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5233 Now ptrdiff_t, not int.
5234 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5235 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5236
5237 * process.c (Fnetwork_interface_list): Check for overflow
5238 in size calculation.
5239
5240 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5241
5242 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5243 overflow. Don't bother calling xmalloc when xrealloc will do.
5244
5245 * search.c (Freplace_match): Check for size calculation overflow.
5246 (Fset_match_data): Don't assume list lengths fit in 'int'.
5247
5248 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5249 for command line length. Do not attempt to address one before the
5250 beginning of an array, as that's not portable.
5251
5252 * term.c (max_frame_lines): Remove; unused.
5253 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5254 not int.
5255 (encode_terminal_code, calculate_costs): Check for size
5256 calculation overflow.
5257 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5258 table lengths and related sizes. Don't update size until alloc
5259 done. Redo calculations to avoid overflow.
5260 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5261
5262 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5263 subtracting pointers.
5264 (gobble_line): Check for overflow more carefully. Don't update size
5265 until alloc done.
5266
5267 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5268 Don't update size until alloc done.
5269 Redo size calculations to avoid overflow.
5270 Check for size calculation overflow.
0065d054 5271 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5272
5273 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5274 Use ptrdiff_t, not int, for sizes.
5275 (store_mode_line_noprop_char): Don't update size until alloc done.
5276
0065d054
PE
5277 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5278 Use ptrdiff_t, not int, for sizes.
5279 (Finternal_make_lisp_face, cache_face):
5280 Check for size calculation overflow.
5281 (cache_face): Treat size calculation overflows as if they were
5282 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5283
5284 * xfns.c (x_encode_text, x_set_name_internal)
5285 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5286 sizes, since they can exceed INT_MAX in size. Check for size
5287 calculation overflow.
5288
0065d054
PE
5289 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5290 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5291 Don't update size until alloc done.
5292
0065d054 5293 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5294 as sprintf is limited to int lengths.
1d526e2f 5295
252c5ee1
PE
5296 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5297 (X_LONG_MIN): New macros.
864d7ce7
PE
5298 Use them to make the following changes clearer.
5299 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5300 This change doesn't affect the value now, but it may help remind
5301 future maintainers not to raise the value too much later.
5302 (SELECTION_QUANTUM): Remove, replacing with ...
5303 (selection_quantum): ... new function, which avoids overflow.
5304 All uses changed.
5305 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5306 assumption that selection length fits in 'int'.
5307 (x_reply_selection_request, x_handle_selection_request)
5308 (x_get_window_property, receive_incremental_selection)
5309 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5310 (lisp_data_to_selection_data, clean_local_selection_data):
5311 Use ptrdiff_t, not int, to record length of selection.
5312 (x_reply_selection_request, x_get_window_property)
5313 (receive_incremental_selection, x_property_data_to_lisp):
5314 Redo calculations to avoid overflow.
5315 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5316 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5317 something.
5318 (x_get_window_property, receive_incremental_selection)
5319 (lisp_data_to_selection_data, x_property_data_to_lisp):
5320 Check for size-calculation overflow.
5321 (x_get_window_property, receive_incremental_selection)
5322 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5323 Don't store size until memory allocation succeeds.
5324 (x_get_window_property): Plug memory leak on memory exhaustion.
5325 Don't double-block input; malloc is safe here. Don't assume 2**34
5326 - 4 fits in unsigned long. Add an xassert to check
5327 XGetWindowProperty overflow. Be more careful about overflow
5328 calculations, and distinguish size from memory overflow better.
5329 (receive_incremental_selection): When tracing, don't assume
5330 unsigned int is less than INT_MAX.
5331 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5332 harmful) conversions of unsigned short to int.
5333 (lisp_data_to_selection_data): Don't assume that integers
5334 in the range -65535 through -1 fit in an X unsigned short.
5335 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5336 result parameters unless successful. Rely on cons_to_unsigned
5337 to report problems with elements; the old code wasn't right anyway.
5338 (x_check_property_data): Check for int overflow; we cannot use
5339 a wider type due to X limits.
5340 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5341
726e0ab1 5342 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5343
0065d054
PE
5344 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5345 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5346 (x_color_cells): Don't store size until memory allocation succeeds.
5347 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5348 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5349 (x_term_init): Don't assume length fits in int (sprintf is limited
5350 to int size).
bc18e09d 5351
ebfa62c0
PE
5352 Use ptrdiff_t for composition IDs.
5353 * character.c (lisp_string_width):
5354 * composite.c (composition_table_size, n_compositions)
5355 (get_composition_id, composition_gstring_from_id):
5356 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5357 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5358 * window.c (Frecenter):
5359 Use ptrdiff_t, not int, for composition IDs.
5360 * composite.c (get_composition_id): Check for integer overflow.
5361 * composite.h: Adjust prototypes to match the above changes.
5362
d3411f89
PE
5363 Use ptrdiff_t for hash table indexes.
5364 * category.c (hash_get_category_set):
5365 * ccl.c (ccl_driver):
5366 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5367 * coding.c (coding_system_charset_list, detect_coding_system):
5368 * coding.h (struct coding_system.id):
5369 * composite.c (get_composition_id, gstring_lookup_cache):
5370 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5371 * image.c (xpm_get_color_table_h):
5372 * lisp.h (hash_lookup, hash_put):
5373 * minibuf.c (Ftest_completion):
5374 Use ptrdiff_t for hash table indexes, not int (which is too
5375 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5376 32-bit --with-wide-int hosts).
5377
e097a6fa
PE
5378 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5379 Add a FIXME comment about memory leaks.
5380 (syms_of_charset): Don't assume xmalloc returns.
5381
5637687f
PE
5382 Don't assume that stated character widths fit in int.
5383 * character.c (Fchar_width, c_string_width, lisp_string_width):
5384 * character.h (CHAR_WIDTH):
5385 * indent.c (MULTIBYTE_BYTES_WIDTH):
5386 Use sanitize_char_width to avoid undefined and/or bad behavior
5387 with outlandish widths.
a66cfb1c 5388 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5389 now that we have two such functions. All uses changed.
5390 (sanitize_char_width): New inline function.
5391
a2271ba2
PE
5392 Don't assume that tab-width fits in int.
5393 * character.h (sanitize_width): New inline function.
5394 (SANE_TAB_WIDTH): New macro.
5395 (ASCII_CHAR_WIDTH): Use it.
5396 * indent.c (sane_tab_width): Remove. All uses replaced by
5397 SANE_TAB_WIDTH (current_buffer).
5398 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5399
18c52557
PE
5400 * fileio.c: Integer overflow issues with file modes.
5401 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5402
caeeedc1
PE
5403 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5404 Remove unreachable code.
5405 (read_hex, load_charset_map_from_file): Check for integer overflow.
5406
6df6ae42 5407 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5408 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5409 (x_send_scroll_bar_event): Likewise. Check that the size does not
5410 exceed limits imposed by XClientMessageEvent, as well as the usual
5411 ptrdiff_t and size_t limits.
5412
b13995db
PE
5413 * keyboard.c: Overflow, signedness and related fixes.
5414 (make_lispy_movement): Use same integer type in forward decl
5415 that is used in the definition.
5416 (read_key_sequence, keyremap_step):
5417 Change bufsize argument back to int, undoing my 2011-03-30 change.
5418 We prefer signed types, and int is wide enough here.
5419 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5420 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5421 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5422 length, not size_t. Use ptrdiff_t for index, not int.
5423 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5424 possibility of integer overflow.
5425
13464394
PE
5426 Overflow, signedness and related fixes for images.
5427
5428 * dispextern.h (struct it.stack[0].u.image.image_id)
5429 (struct_it.image_id, struct image.id, struct image_cache.size)
5430 (struct image_cache.used, struct image_cache.ref_count):
5431 * gtkutil.c (update_frame_tool_bar):
5432 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5433 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5434 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5435 * nsmenu.m (update_frame_tool_bar):
5436 * xdisp.c (calc_pixel_width_or_height):
5437 * xfns.c (image_cache_refcount):
5438 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5439 on typical 64-bit hosts.
5440
5441 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5442 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5443 Omit unnecessary casts to int.
5444 (parse_image_spec): Check that integers fall into 'int' range
5445 when the callers expect that.
5446 (image_ascent): Redo ascent calculation to avoid int overflow.
5447 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5448 (lookup_image): Remove unnecessary tests.
5449 (xbm_image_p): Locals are now of int, not EMACS_INT,
5450 since parse_image_check makes sure they fit into int.
5451 (png_load, gif_load, svg_load_image):
5452 Prefer int to unsigned where either will do.
5453 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5454 old tiff_error_handler and tiff_warning_handler.
5455 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5456 stack buffer overflows. It uses only the features of vsnprintf
5457 that are common to both POSIX and native Microsoft.
5458 (tiff_error_handler, tiff_warning_handler): Use it.
5459 (tiff_load, gif_load, imagemagick_load_image):
5460 Don't assume :index value fits in 'int'.
5461 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5462 (imagemagick_load_image): Check that crop parameters fit into
5463 the integer types that MagickCropImage accepts. Don't assume
5464 Vimagemagick_render_type has a nonnegative value. Don't assume
5465 size_t fits in 'long'.
5466 (gs_load): Use printmax_t to print the widest integers possible.
5467 Check for integer overflow when computing image height and width.
5468
c11821d4
EZ
54692011-08-26 Eli Zaretskii <eliz@gnu.org>
5470
5471 * xdisp.c (redisplay_window): Don't force window start if point
5472 will be invisible in the resulting window. (Bug#9324)
5473
0c95fcf7
EZ
54742011-08-25 Eli Zaretskii <eliz@gnu.org>
5475
5476 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5477 the display spec is of the form `(space ...)'.
5478 (handle_display_spec): Return the value returned by
5479 handle_single_display_spec, not just 1 or zero.
5480 (handle_single_display_spec): If the display spec is of the form
5481 `(space ...)', and specifies display in the text area, return 2
5482 rather than 1.
fee65a97 5483 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5484 accurately, and prefer exact match for point under bidi.
5485 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5486
5487 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5488 into disp_prop; all users changed.
5489
5490 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5491 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5492 for the text covered by the display property.
5493
e4ed06f1
CY
54942011-08-25 Chong Yidong <cyd@stupidchicken.com>
5495
5496 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5497 Change return value to nil.
5498 (Frecord_buffer): Delete unused function.
5499
f67cdd7f
EZ
55002011-08-24 Eli Zaretskii <eliz@gnu.org>
5501
5980d4c6
EZ
5502 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5503 buffers, return left-to-right.
8610fe8b
EZ
5504 (set_cursor_from_row): Consider candidate row a win if its glyph
5505 represents a newline and point is on that newline. Fixes cursor
5506 positioning on the newline at EOL of R2L text within L2R
5507 paragraph, and vice versa.
5508 (try_cursor_movement): Check continued rows, in addition to
5509 continuation rows. Fixes unwarranted scroll when point enters a
5510 continued line of R2L text within an L2R paragraph, or vice versa.
5511 (cursor_row_p): Consider the case of point being equal to
5512 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5513 from the end of a short line to the beginning of a continued line
5514 of R2L text within L2R paragraph.
5515 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5516 composed characters.
5980d4c6 5517
f67cdd7f
EZ
5518 * bidi.c (bidi_check_type): Use xassert.
5519 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5520 members.
5521
bca633fb
EZ
55222011-08-23 Eli Zaretskii <eliz@gnu.org>
5523
5524 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5525 a character.
5526
4a5885a7
CY
55272011-08-23 Chong Yidong <cyd@stupidchicken.com>
5528
5529 * nsfont.m (ns_otf_to_script): Fix typo.
5530
0902a04e
KH
55312011-08-22 Kenichi Handa <handa@m17n.org>
5532
5533 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5534 extra slot even if the purpose is char-code-property-table.
5535
1a2e6670
EZ
55362011-08-23 Eli Zaretskii <eliz@gnu.org>
5537
8ddde651
EZ
5538 * xdisp.c (redisplay_window): When computing centering_position,
5539 account for the height of the header line. (Bug#8874)
5540
425cc014
EZ
5541 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5542 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5543 candidate is selected by the mouse, and that candidate has a
5544 composed character under the mouse.
5545
1a2e6670
EZ
5546 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5547 coordinates reported by pos-visible-in-window-p for a composed
5548 character in column zero.
5549
8b76d6f8
SM
55502011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5551
5552 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5553
dac347dd
EZ
55542011-08-22 Eli Zaretskii <eliz@gnu.org>
5555
5556 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5557 consider it a hit if to_charpos is anywhere in the range of the
5558 composed buffer positions.
5559
e013fb34
CY
55602011-08-22 Chong Yidong <cyd@stupidchicken.com>
5561
5562 * image.c (gif_load): Don't assume that each subimage has the same
5563 dimensions as the base image. Handle disposal method that is
5564 "undefined" by the gif spec (Bug#9335).
5565
bd1ba3e8
CY
55662011-08-20 Chong Yidong <cyd@stupidchicken.com>
5567
5568 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5569 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5570
54a1215b
EZ
55712011-08-19 Eli Zaretskii <eliz@gnu.org>
5572
823564e5
EZ
5573 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5574 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5575 from an Org mode buffer to a Speedbar frame.
5576
54a1215b
EZ
5577 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5578 a composition, take its buffer position from IT->cmp_it.charpos.
5579 Fixes cursor positioning at the beginning of a line that begins
5580 with a composed character.
5581
9778ebcc
EZ
55822011-08-18 Eli Zaretskii <eliz@gnu.org>
5583
0be6ee06
EZ
5584 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5585 character bidirectional type, use STRONG_L instead. Fixes crashes
5586 in a buffer produced by `describe-categories'.
5587
9778ebcc
EZ
5588 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5589 members before the level stack, so they would be saved and
5590 restored when copying iterator state. Fixes incorrect reordering
5591 around TABs covered by display properties.
5592
156bffbe
AS
55932011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5594
6b02f655 5595 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5596
72ad093b
CY
55972011-08-17 Chong Yidong <cyd@stupidchicken.com>
5598
5599 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5600 (internal_condition_case_2, internal_condition_case_n):
5601 Remove unnecessary aborts (Bug#9081).
72ad093b 5602
35774242
EZ
56032011-08-17 Eli Zaretskii <eliz@gnu.org>
5604
5605 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5606 has no `load' handler, try opening the file locally. (Bug#9311)
5607
db76dd85
KB
56082011-08-16 Ken Brown <kbrown@cornell.edu>
5609
5610 * gmalloc.c: Expand comment.
5611
b215eee5
EZ
56122011-08-16 Eli Zaretskii <eliz@gnu.org>
5613
5614 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5615 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5616
a4579d33
KB
56172011-08-16 Ken Brown <kbrown@cornell.edu>
5618
5619 Fix memory allocation problems in Cygwin build (Bug#9273).
5620
5621 * unexcw.c ( __malloc_initialized): Declare external variable.
5622 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5623
8b76d6f8
SM
5624 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5625 New variables.
a4579d33
KB
5626 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5627 dumped emacs.
5628 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5629 in the static heap.
5630 [CYGWIN] (special_realloc): New function.
5631 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5632 requests to realloc storage in the static heap.
5633
3ebec551
PE
56342011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5635
5636 * bidi.c (bidi_initialize): Remove unused local.
5637
9fd8be00
EZ
56382011-08-15 Eli Zaretskii <eliz@gnu.org>
5639
6b02f655
SM
5640 * bidimirror.h:
5641 * biditype.h: Remove file.
5642 * makefile.w32-in ($(BLD)/bidi.$(O)):
5643 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5644
5645 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5646
5647 * chartab.c: Improve commentary for the uniprop_table API.
5648
32413314
EZ
5649 * bidi.c (bidi_paragraph_init): Support zero value of
5650 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5651 (bidi_initialize): Use uniprop_table instead of including
5652 biditype.h and bidimirror.h.
32413314 5653
9fd8be00
EZ
5654 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5655 coordinates of the iterator when restoring from ppos_it.
5656 (Bug#9296)
5657
5cf2b69b
KH
56582011-08-14 Kenichi Handa <handa@m17n.org>
5659
5660 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5661 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5662
daf17d00
EZ
56632011-08-14 Eli Zaretskii <eliz@gnu.org>
5664
5665 * xdisp.c (move_it_in_display_line_to): Don't invoke
5666 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5667 ppos_it. Fixes vertical cursor motion when line beginning is
5668 covered by an image. (Bug#9296)
5669
08e3161a
JD
56702011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5671
5672 * nsterm.h (ns_run_ascript): Declare.
5673 (NSAPP_DATA2_RUNASSCRIPT): Define.
5674
5675 * nsfns.m (as_script, as_result, as_status): New static variables.
5676 (ns_run_ascript): New function.
5e617bc2 5677 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5678 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5679 the event loop. Get status from as_status (Bug#7276).
5680
5681 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5682 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5683 the event loop (Bug#7276).
5684
a3720aa2
AS
56852011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5686
5687 * gnutls.c (QCgnutls_bootprop_priority)
5688 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5689 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5690 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5691 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5692 (QCgnutls_bootprop_verify_hostname_error)
5693 (QCgnutls_bootprop_callbacks_verify): Rename from
5694 Qgnutls_bootprop_..., all uses changed.
5695
5696 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5697 uses changed.
5698
0a0d27fb
PE
56992011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5700
19d5c50c
PE
5701 * xfaces.c (Qframe_set_background_mode): Now static.
5702 * dispextern.h (Qframe_set_background_mode): Remove decl.
5703
0a0d27fb
PE
5704 * process.c (Fnetwork_interface_info): Declare local only if needed.
5705
377538cb
JD
57062011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5707
5708 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5709 (Fnetwork_interface_list): Allocate in increments of bytes instead
5710 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5711 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5712 sockaddr.
5713 (struct ifflag_def): notrailers is smart on OSX.
5714 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5715 Get hardware address with getifaddrs if available.
5716
08fff70c
EZ
57172011-08-12 Eli Zaretskii <eliz@gnu.org>
5718
5719 * xdisp.c (iterate_out_of_display_property): xassert that
5720 IT->position is set to within IT->object's boundaries. Break from
5721 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5722 when IT->position is set up wrongly due to some bug.
5723 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5724 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5725 entry. Force push_it to save on the stack the current
5726 buffer/string position, to be restored by pop_it. Fix flags in
5727 the iterator structure wrt the object coming from a display
5728 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5729 properties. (Bug#9284)
5730
7be1c708 57312011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5732
7be1c708
CY
5733 * fontset.c (fontset_get_font_group): Add proper type checks.
5734 (Bug#9172)
aac0c6e3 5735
7be1c708 57362011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5737
7be1c708
CY
5738 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5739 and LC_VERSION_MIN_MACOSX.
5740 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5741 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5742
97bb72a6
EZ
57432011-08-08 Eli Zaretskii <eliz@gnu.org>
5744
5745 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5746 no-display-properties-and-no-overlays under bidi display.
5747 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5748 properties and overlays.
97bb72a6 5749
d5617611
CY
57502011-08-08 Chong Yidong <cyd@stupidchicken.com>
5751
37e11a63
CY
5752 * editfns.c (Fset_time_zone_rule): Document relationship with the
5753 setenv function.
5754
d5617611
CY
5755 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5756 the font entity extracted from the cache (Bug#8109).
5757
58872834
CY
57582011-08-07 Chong Yidong <cyd@stupidchicken.com>
5759
5760 * composite.c (autocmp_chars): Don't reset point. That is done by
5761 restore_point_unwind (Bug#5984).
5762
75bfc667
JL
57632011-08-07 Juri Linkov <juri@jurta.org>
5764
5765 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5766 to show the arg `TIME' instead of `TIMEVAL'.
5767
d1410150
EZ
57682011-08-06 Eli Zaretskii <eliz@gnu.org>
5769
5770 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5771 display property strides EOL and includes a newline, as in
5772 longlines-mode. (Bug#9254)
75b771e4
EZ
5773 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5774 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5775
5776 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5777 is non-zero, even if the data buffer is NULL. Fixes a crash in
5778 vertical-motion with longlines-mode. (Bug#9254)
5779
35928349
EZ
57802011-08-05 Eli Zaretskii <eliz@gnu.org>
5781
ec7cc85b
EZ
5782 * bidi.c <bidi_cache_total_alloc>: Now static.
5783 (bidi_initialize): Initialize bidi_cache_total_alloc.
5784
8b76d6f8 5785 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5786 cache. (Bug#9221)
5787
5788 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5789 amount allocated this far in `bidi_cache_total_alloc'.
5790 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5791 non-zero, only free the data buffer without restoring the cache
5792 contents. All callers changed.
5793
5794 * dispextern.h (bidi_unshelve_cache): Update prototype.
5795
5796 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5797 (move_it_in_display_line, move_it_to)
5798 (move_it_vertically_backward, move_it_by_lines): Replace the call
5799 to xfree to an equivalent call to bidi_unshelve_cache.
5800 (move_it_in_display_line_to): Fix logic of returning
412b6358 5801 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5802
e2e2423b
EZ
58032011-08-05 Eli Zaretskii <eliz@gnu.org>
5804
5805 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5806 came from a string character with a `cursor' property. (Bug#9229)
5807
ae9e757a
JD
58082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5809
5810 * Makefile.in (LIB_PTHREAD): New variable.
5811 (LIBES): Add LIB_PTHREAD (Bug#9216).
5812
5813 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5814 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5815
213bd7f2
AS
58162011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5817
6b02f655 5818 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5819
99aaf75f
JD
58202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5821
5822 * xterm.c (x_find_topmost_parent): New function.
5823 (x_set_frame_alpha): Find topmost parent window with
5824 x_find_topmost_parent and set the property there also (bug#9181).
5825 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5826
c74e9d86
PE
58272011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5828
5829 * callproc.c (Fcall_process): Avoid vfork clobbering
5830 the local vars buffer, coding_systems, current_dir.
5831
640c8776
SM
58322011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5833
5834 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5835
f26d0e4c
PE
58362011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5837
8a10d76c
PE
5838 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5839 so that it is not optimized away.
5840
f26d0e4c
PE
5841 * xdisp.c (compute_display_string_pos): Remove unused local.
5842
55439c61
EZ
58432011-08-02 Eli Zaretskii <eliz@gnu.org>
5844
5845 Fix slow cursor motion and scrolling in large buffers with
5846 selective display, like Org Mode buffers. (Bug#9218)
5847
5848 * dispextern.h (struct bidi_it): New member disp_prop_p.
5849
5850 * xdisp.c: Remove one-slot cache of display string positions.
5851 (compute_display_string_pos): Accept an additional argument
5e617bc2 5852 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5853 for a display string or property. If found, set DISP_PROP_P
5854 non-zero.
5855
5856 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5857 DISP_PROP_P, and pass it to compute_display_string_pos.
5858 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5859 non-zero. All callers of bidi_fetch_char changed.
5860
fb33fa43
SM
58612011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5862
5863 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5864
b099e063
DM
58652010-12-03 Don March <don@ohspite.net>
5866
5867 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5868 last character M-[char] is translated to ESC [char] (bug#7541).
5869
5cc7f7af
KH
58702011-08-02 Kenichi Handa <handa@m17n.org>
5871
d0fffa3f 5872 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5873
5874 * chartab.c (uniprop_table): Make it non-static.
5875
525d5e6e
EZ
58762011-08-01 Eli Zaretskii <eliz@gnu.org>
5877
5878 * xdisp.c (forward_to_next_line_start): Accept additional argument
5879 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5880 on the newline.
5881 (reseat_at_next_visible_line_start): Use the bidi iterator state
5882 returned by forward_to_next_line_start to restore the state of
5883 it->bidi_it after backing up to previous newline. (Bug#9212)
5884
31011111
AS
58852011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5886
5887 * regex.c (re_comp): Protoize.
5888 (re_exec): Fix return type.
5889 (regexec): Fix type of `ret'. (Bug#9203)
5890
476371c4
PE
58912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5892
e5d76069
PE
5893 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5894 This is needed if max-image-size is a floating-point number.
5895
9a79b20c
AS
58962011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5897
5898 * print.c (print_object): Print empty symbol as ##.
5899
5900 * lread.c (read1): Read ## as empty symbol.
5901
d8c2fa78
AA
59022011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5903
5904 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5905 setting frame foreground color (Bug#9175).
5906 (x_set_background_color): Likewise.
5907
ffe57a7a
AA
5908 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5909 contents (Bug#9176).
5910 (EmacsTooltip -init): Remove bezels and add shadows to
5911 tooltip windows.
5912
bf3492a5
AA
5913 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5914 or scroll bar (Bug#8470).
5915
d55e9c53
AA
5916 * nsfont.m (nsfont_open): Remove assignment to voffset and
5917 unnecessary vars hshink, expand, hd, full_height, min_height.
5918 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5919
5920 * nsterm.h (nsfont_info): Remove voffset field.
5921
d8c2fa78 59222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5923
5924 Implement strike-through and overline on NextStep (Bug#8863).
5925
5926 * nsfont.m (nsfont_open): Use underline position provided by font,
5927 instead of hard-coded value of 2.
5928 (nsfont_draw): Call ns_draw_text_decoration instead.
5929
5930 * nsterm.h: Add declaration for ns_draw_text_decoration.
5931
5932 * nsterm.m (ns_draw_text_decoration): New function for drawing
5933 underline, overline, and strike-through.
5934 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5935 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5936 accommodate underlining, etc.
4843aac3 5937
4cc60b9b
EZ
59382011-07-28 Eli Zaretskii <eliz@gnu.org>
5939
bc7ece87
EZ
5940 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5941 default.
4cc60b9b 5942
476371c4
PE
59432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5944
66606eea
PE
5945 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5946 Without this fix, if a signal arrives just after memory fills up,
5947 'malloc' might be invoked reentrantly.
5948
476371c4
PE
5949 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5950 In other words, assume that every image size is allowed, on non-X
5951 hosts. This assumption is probably wrong, but it lets Emacs compile.
5952
f3fcc40d
AS
59532011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5954
5955 * regex.c (re_iswctype): Convert return values to boolean.
5956
350c992f
EZ
59572011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5958
5959 * xdisp.c (compute_display_string_pos): Don't use cached display
5960 string position if the buffer had its restriction changed.
5961 (Bug#9184)
5962
5266b4bb
PE
59632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5964
5965 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5966
2573a837 59672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5968
41f55ccd 5969 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5970
39e378da
PE
5971 * bidi.c: Integer size and overflow fixes.
5972 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5973 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5974 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5975 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5976 (bidi_find_other_level_edge):
5977 Use ptrdiff_t instead of EMACS_INT where either will do.
5978 This works better on 32-bit hosts configured --with-wide-int.
5979 (bidi_cache_ensure_space): Check for size-calculation overflow.
5980 Use % rather than repeated addition, for better worst-case speed.
5981 Don't set bidi_cache_size until after xrealloc returns, because it
5982 might not return.
5983 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5984 (bidi_cache_ensure_space): Also check that the bidi cache size
5985 does not exceed that of the largest Lisp string or buffer. See Eli
5986 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5987
5e927815
PE
5988 * alloc.c (__malloc_size_t): Remove.
5989 All uses replaced by size_t. See Andreas Schwab's note
5990 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5991
ca4aa935
PE
5992 * image.c: Improve checking for integer overflow.
5993 (check_image_size): Assume that f is nonnull, since
5994 it is always nonnull in practice. This is one less thing to
5995 worry about when checking for integer overflow later.
5996 (x_check_image_size): New function, which checks for integer
5997 overflow issues inside X.
5998 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5999 This removes the need for a memory_full check.
6000 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6001 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6002 (xbm_read_bitmap_data): Change locals back to 'int', since
6003 their values must fit in 'int'.
6004 (xpm_load_image, png_load, tiff_load):
6005 Invoke x_create_x_image_and_pixmap earlier,
6006 to avoid much needless work if the image is too large.
6007 (tiff_load): Treat overly large images as if
6008 x_create_x_image_and_pixmap failed, not as malloc failures.
6009 (gs_load): Use x_check_image_size.
6010
5f8f9cc2
PE
6011 * gtkutil.c: Omit integer casts.
6012 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6013 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6014
5adf60bc
PE
6015 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6016
c8907a93
PE
6017 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6018 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6019 would wrongly return t on a 64-bit host.
6020
e3c25c68
PE
6021 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6022 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6023 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6024 and therefore cause GCC to emit a bogus diagnostic in some cases.
6025
3f791afe
PE
6026 * image.c: Integer signedness and overflow and related fixes.
6027 This is not an exhaustive set of fixes, but it's time to
6028 record what I've got.
6029 (lookup_pixel_color, check_image_size): Remove redundant decls.
6030 (check_image_size): Don't assume that arbitrary EMACS_INT values
6031 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6032 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6033 (tiff_load, imagemagick_load_image):
6034 Check for overflow in size calculations.
6035 (x_create_x_image_and_pixmap): Remove unnecessary test for
6036 xmalloc returning NULL; that can't happen.
6037 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6038 (xpm_color_bucket): Use better integer hashing function.
6039 (xpm_cache_color): Don't possibly over-allocate memory.
6040 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6041 (gif_memory_source):
6042 Use ptrdiff_t, not int or size_t, to record sizes.
6043 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6044 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6045 either works, as we prefer signed integers.
6046 (tiff_read_from_memory, tiff_write_from_memory):
6047 Return tsize_t, not size_t, since that's what the TIFF API wants.
6048 (tiff_read_from_memory): Don't fail simply because the read would
6049 go past EOF; instead, return a short read.
6050 (tiff_load): Omit no-longer-needed casts.
6051 (Fimagemagick_types): Don't assume size fits into 'int'.
6052
3cc5a532
PE
6053 Improve hashing quality when configured --with-wide-int.
6054 * fns.c (hash_string): New function, taken from sxhash_string.
6055 Do not discard information about ASCII character case; this
6056 discarding is no longer needed.
6057 (sxhash-string): Use it. Change sig to match it. Caller changed.
6058 * lisp.h: Declare it.
6059 * lread.c (hash_string): Remove, since we now use fns.c's version.
6060 The fns.c version returns a wider integer if --with-wide-int is
6061 specified, so this should help the quality of the hashing a bit.
6062
b312a492
PE
6063 * emacs.c: Integer overflow minor fix.
6064 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6065 Define only if GNU_LINUX.
6066 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6067
dfd153ae
PE
6068 * dispnew.c: Integer signedness and overflow fixes.
6069 Remove unnecessary forward decls, that were a maintenance hassle.
6070 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6071 All uses changed.
6072 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6073 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6074 (prepare_desired_row, line_draw_cost):
6075 Use int, not unsigned, where either works.
6076 (save_current_matrix, restore_current_matrix):
6077 Use ptrdiff_t, not size_t, where either works.
6078 (init_display): Check for overflow more accurately, and without
6079 relying on undefined behavior.
6080
a81d11a3
PE
6081 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6082 Remove, replacing with the new symbols in lisp.h. All uses changed.
6083 * fileio.c (make_temp_name):
6084 * filelock.c (lock_file_1, lock_file):
6085 * xdisp.c (message_dolog):
6086 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6087 Use pMd etc. instead.
6088 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6089 replacing the pWIDE etc. symbols removed from editfns.c.
6090
3300e6fd
PE
6091 * keyboard.h (num_input_events): Now uintmax_t.
6092 This is (very slightly) less likely to mess up due to wraparound.
6093 All uses changed.
6094
fd05c7e9
PE
6095 * buffer.c: Integer signedness fixes.
6096 (alloc_buffer_text, enlarge_buffer_text):
6097 Use ptrdiff_t rather than size_t when either will do, as we prefer
6098 signed integers.
6099
903fe15d
PE
6100 * alloc.c: Integer signedness and overflow fixes.
6101 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6102 (__malloc_size_t): Default to size_t, not to int.
6103 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6104 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6105 Prefer ptrdiff_t to size_t when either would do, as we prefer
6106 signed integers.
6107 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6108 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6109 Now const. Initialize with values that are in range even if char
6110 is signed.
6111 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6112 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6113 These functions do the right thing with sizes > 2**32.
6114 (check_depth): Now ptrdiff_t, not int.
6115 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6116 Adjust to new way of storing sizes. Check for size overflow bugs
6117 in rest of code.
6118 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6119 slightly wrong anyway, as it missed one instance of
6120 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6121 (refill_memory_reserve): Omit needless cast to size_t.
6122 (mark_object_loop_halt): Mark as externally visible.
6123
ac82cc6a
PE
6124 * xselect.c: Integer signedness and overflow fixes.
6125 (Fx_register_dnd_atom, x_handle_dnd_message):
6126 Use ptrdiff_t, not size_t, since we prefer signed.
6127 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6128 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6129 x_dnd_atoms_size and x_dnd_atoms_length.
6130
c2d1e36d
PE
6131 * doprnt.c: Prefer signed to unsigned when either works.
6132 * eval.c (verror):
6133 * doprnt.c (doprnt):
6134 * lisp.h (doprnt):
6135 * xdisp.c (vmessage):
6136 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6137 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6138 prefer signed arithmetic to avoid comparison confusion.
6139 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6140 but is a bit tricky.
6141
0e926e56
PE
6142 Assume freestanding C89 headers, string.h, stdlib.h.
6143 * data.c, doprnt.c, floatfns.c, print.c:
6144 Include float.h unconditionally.
6145 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6146 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6147 * regex.c: Likewise for stddef.h, string.h.
6148 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6149 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6150 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6151 (STDC_HEADERS): Remove obsolete defines.
6152 * sysdep.c: Include limits.h unconditionally.
6153
9cfdb3ec
PE
6154 Assume support for memcmp, memcpy, memmove, memset.
6155 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6156 * regex.c (memcmp, memcpy):
6157 Remove; we assume C89 now.
6158
6159 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6160 (__malloc_safe_bcopy): Remove; no longer needed.
6161
cf950e6b 6162 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6163 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6164 well either way, and we prefer signed to unsigned.
6165
dbf38e02
LMI
61662011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6167
6168 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6169 closes the connection while we're reading (bug#9182).
6170
d6f0886c 61712011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6172
d6f0886c
JD
6173 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6174 are specified (Bug#9168).
24e0f6b1 6175
2eb1f9e6
PE
61762011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6177
6178 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6179 Found by GCC static checking and --with-wide-int on a 32-bit host.
6180
22381272 61812011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6182
6183 * xdisp.c (compute_display_string_pos): Fix logic of caching
6184 previous display string position. Initialize cached_prev_pos to
6185 -1. Fixes slow-down at the beginning of a buffer.
6186
f25e39b4
EZ
61872011-07-24 Eli Zaretskii <eliz@gnu.org>
6188
6189 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6190 for attrs[LFACE_FONTSET_INDEX].
6191
04c4b52e
PE
61922011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6193
6194 * xml.c (parse_region): Remove unused local
6195 that was recently introduced.
6196
c1734fbd
EZ
61972011-07-23 Eli Zaretskii <eliz@gnu.org>
6198
be18c5a5
EZ
6199 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6200 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6201
c1734fbd
EZ
6202 * xdisp.c (move_it_in_display_line_to): Record the best matching
6203 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6204 exit if none of the characters scanned was an exact match.
6205 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6206 when exact match is impossible due to invisible text, and the
6207 lines are truncated.
6208
a258d627
JD
62092011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6210
6211 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6212 for OSX >= 10.7.
6213
b6d5a689
EZ
62142011-07-22 Eli Zaretskii <eliz@gnu.org>
6215
0f74f785
EZ
6216 Fix a significant slow-down of cursor motion with C-n, C-p,
6217 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6218 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6219 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6220 (next_element_from_buffer): Call compute_stop_pos_backwards to
6221 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6222 base_level_stop.
6223 (reseat): Don't look for prev_stop, as that could mean a very long
6224 run.
6225 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6226 <cached_disp_overlay_modiff>: Cache for last found display string
6227 position.
551918c1 6228 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6229 about the same buffer in the same area of character positions, and
6230 the buffer wasn't changed since the time the display string
6231 position was cached.
551918c1 6232
b2d0c91a
EZ
62332011-07-22 Eli Zaretskii <eliz@gnu.org>
6234
6235 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6236 is an integer, which is important for empty lines. (Bug#9149)
6237
043604ee
CY
62382011-07-22 Chong Yidong <cyd@stupidchicken.com>
6239
6240 * frame.c (Fmodify_frame_parameters): In tty case, update the
6241 default face if necessary (Bug#4238).
6242
da4adb04
CY
62432011-07-21 Chong Yidong <cyd@stupidchicken.com>
6244
6245 * editfns.c (Fstring_to_char): No need to explain what a character
6246 is in the docstring (Bug#6576).
6247
9abd0532
LMI
62482011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6249
6250 * xml.c (parse_region): Make sure we always return a tree.
6251
36881d16
HK
62522011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6253
6254 * xml.c (parse_region): If a document contains only comments,
6255 return that, too.
6256
1e98674d
LMI
62572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6258
6259 * xml.c (make_dom): Return comments, too.
6260
590bd467
PE
62612011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6262
6263 Port to OpenBSD.
6264 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6265 and the surrounding thread.
6266 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6267 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6268 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6269 timer goes off.
6270 * s/openbsd.h (BROKEN_SIGIO): Define.
6271 * unexelf.c (unexec) [__OpenBSD__]:
6272 Don't update the .mdebug section of the Alpha COFF symbol table.
6273
f41628b2
LMI
62742011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6275
6276 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6277 (bug#8460).
6278
b59b67c5
PE
62792011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6280
15e3a074
PE
6281 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6282 This fixes some race conditions on the permissions of any newly
6283 created file.
6284
41bed37d
PE
6285 * alloc.c (valid_pointer_p): Use pipe, not open.
6286 This fixes some permissions issues when debugging.
6287
b59b67c5
PE
6288 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6289 If fchown fails to set both uid and gid, try to set just gid,
6290 as that is sometimes allowed. Adjust the file's mode to eliminate
6291 setuid or setgid bits that are inappropriate if fchown fails.
6292
925a6be7
SM
62932011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6294
6295 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6296 to compare Lisp_Objects.
6297 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6298 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6299 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6300
52968808
AS
63012011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6302
0a6a104b
AS
6303 * lread.c (read_integer): Unread even EOF character.
6304 (read1): Likewise. Properly record start position of symbol.
6305
52968808
AS
6306 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6307 symbol character follows.
6308
9e381cdd
PE
63092011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6310
6311 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6312 This works around a problem with the previous change to Fcopy_file.
6313 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6314 and without this change, GCC might complain about discarding
6315 fchown's return value.
6316
b5641435
JB
63172011-07-16 Juanma Barranquero <lekktu@gmail.com>
6318
6319 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6320
a8031457
PE
63212011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6322
6323 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6324
dd889327
LMI
63252011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6326
750c33f7
LMI
6327 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6328 it's used from the C level.
6329
dd889327
LMI
6330 * process.c: Use the same condition for POLL_FOR_INPUT in both
6331 keyboard.c and process.c (bug#1858).
6332
87e86684
LM
63332011-07-09 Lawrence Mitchell <wence@gmx.li>
6334
6335 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6336 (Fgnutls_boot): Use it.
6337
64348f40
AS
63382011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6339
6340 * doc.c (Fsubstitute_command_keys): Revert last change.
6341
1d698799
LMI
63422011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6343
f863868c
LMI
6344 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6345 quotes the next character, and doesn't affect other longer
6346 sequences (bug#8935).
6347
1d698799
LMI
6348 * lread.c (syms_of_lread): Clarify that is isn't only
6349 `eval-buffer' and `eval-defun' that's affected by
6350 `lexical-binding' (bug#8460).
6351
aa4b6df6
EZ
63522011-07-15 Eli Zaretskii <eliz@gnu.org>
6353
6354 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6355 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6356
5d856da6
PE
63572011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6358
ad6042bb
PE
6359 Fix minor problems found by static checking.
6360 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6361 (elsz): Now a signed constant, not a size_t var. We prefer signed
6362 types to unsigned, to avoid integer comparison confusion. Without
6363 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6364 "cannot optimize loop, the loop counter may overflow", a symptom
6365 of the confusion.
f00bbb22 6366 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6367 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6368
6468f31c
LMI
63692011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6370
49080b10
LMI
6371 * search.c (Fre_search_backward): Mention `case-fold-search' in
6372 all the re_search_* functions (bug#8138).
6373
6468f31c
LMI
6374 * keyboard.c (Fopen_dribble_file): Document when the file is
6375 closed (bug#8056).
6376
c965adc5
EZ
63772011-07-14 Eli Zaretskii <eliz@gnu.org>
6378
df9733bf
EZ
6379 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6380 bidi_cache_idx.
6381
0bb23927
EZ
6382 Support bidi reordering of display and overlay strings.
6383 * xdisp.c (compute_display_string_pos)
6384 (compute_display_string_end): Accept additional argument STRING.
6385 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6386 (reseat_to_string): Initialize bidi_it->string.s and
6387 bidi_it->string.schars.
6388 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6389 NULL (avoids a crash in bidi_paragraph_init).
6390 Initialize itb.string.lstring.
0bb23927
EZ
6391 (init_iterator): Call bidi_init_it only of a valid
6392 buffer position was specified. Initialize paragraph_embedding to
6393 L2R.
6394 (reseat_to_string): Initialize the bidi iterator.
6395 (display_string): If we need to ignore text properties of
6396 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6397 original value of -1 will not work with bidi.)
6398 (compute_display_string_pos): First arg is now struct
6399 `text_pos *'; all callers changed. Support display properties on
6400 Lisp strings.
6401 (compute_display_string_end): Support display properties on Lisp
6402 strings.
6403 (init_iterator, reseat_1, reseat_to_string): Initialize the
6404 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6405 when iterating on a string not from display properties).
640c8776
SM
6406 (compute_display_string_pos, compute_display_string_end):
6407 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6408 arrow keys.
6409 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6410 base_level_stop; instead, set base_level_stop to BEGV.
6411 Fixes crashes in vertical-motion.
0bb23927
EZ
6412 (next_element_from_buffer): Improve commentary for when
6413 the iterator is before prev_stop.
6414 (init_iterator): Initialize bidi_p from the default value of
6415 bidi-display-reordering, not from buffer-local value. Use the
6416 buffer-local value only if initializing for buffer iteration.
6417 (handle_invisible_prop): Support invisible properties on strings
6418 that are being bidi-reordered.
6419 (set_iterator_to_next): Support bidi reordering of C strings and
6420 Lisp strings.
6421 (next_element_from_string): Support bidi reordering of Lisp
6422 strings.
6423 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6424 (display_string): Support display of R2L glyph rows.
6425 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6426 (init_iterator): Don't initialize it->bidi_p for strings
6427 here.
6428 (reseat_to_string): Initialize it->bidi_p for strings here.
6429 (next_element_from_string, next_element_from_c_string)
6430 (next_element_from_buffer): Add xassert's for correspondence
6431 between IT's object being iterated and it->bidi_it.string
6432 structure.
6433 (face_before_or_after_it_pos): Support bidi iteration.
6434 (next_element_from_c_string): Handle the case of the first string
6435 character that is not the first one in the visual order.
6436 (get_visually_first_element): New function, refactored from common
6437 parts of next_element_from_buffer, next_element_from_string, and
6438 next_element_from_c_string.
6439 (tool_bar_lines_needed, redisplay_tool_bar)
6440 (display_menu_bar): Force left-to-right direction. Add a FIXME
6441 comment for making that be controlled by a user option.
6442 (push_it, pop_it): Save and restore the state of the
6443 bidi iterator. Save and restore the bidi_p flag.
6444 (pop_it): Iterate out of display property for string iteration as
6445 well.
6446 (iterate_out_of_display_property): Support iteration over strings.
6447 (handle_single_display_spec): Set up it->bidi_it for iteration
6448 over a display string, and call bidi_init_it.
6449 (handle_single_display_spec, next_overlay_string)
6450 (get_overlay_strings_1, push_display_prop): Set up the bidi
6451 iterator for displaying display or overlay strings.
6452 (forward_to_next_line_start): Don't use the shortcut if
6453 bidi-iterating.
6454 (back_to_previous_visible_line_start): If handle_display_prop
6455 pushed the iterator stack, restore the internal state of the bidi
6456 iterator by calling bidi_pop_it same number of times.
6457 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6458 and we are bidi-iterating, don't decrement the iterator position;
6459 instead, set the first_elt flag in the bidi iterator, to produce
6460 the same effect.
6461 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6462 (push_display_prop): xassert that we are iterating a buffer.
6463 (push_it, pop_it): Save and restore paragraph_embedding member.
6464 (handle_single_display_spec, next_overlay_string)
6465 (get_overlay_strings_1, reseat_1, reseat_to_string)
6466 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6467 correctly. Don't assume unibyte strings are not bidi-reordered.
6468 (compute_display_string_pos)
6469 (compute_display_string_end): Fix handling the case of C string.
6470 (push_it, pop_it): Save and restore from_disp_prop_p.
6471 (handle_single_display_spec, push_display_prop): Set the
6472 from_disp_prop_p flag.
6473 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6474 (pop_it): Call iterate_out_of_display_property only if we are
6475 popping after iteration over a string that came from a display
6476 property. Fix a typo in popping stretch info. Add an assertion
6477 for verifying that the iterator position is in sync with the bidi
6478 iterator.
6479 (handle_single_display_spec, get_overlay_strings_1)
6480 (push_display_prop): Fix initialization of paragraph direction for
6481 string when that of the parent object is not yet determined.
6482 (reseat_1): Call bidi_init_it to resync the bidi
6483 iterator with IT's position. (Bug#7616)
6484 (find_row_edges): If ROW->start.pos gives position
6485 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6486 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6487 Reset the from_disp_prop_p flag.
6488 (SAVE_IT, RESTORE_IT): New macros.
6489 (pos_visible_p, face_before_or_after_it_pos)
6490 (back_to_previous_visible_line_start)
6491 (move_it_in_display_line_to, move_it_in_display_line)
6492 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6493 (try_scrolling, redisplay_window, display_line): Use them when
6494 saving a temporary copy of the iterator and restoring it back.
6495 (back_to_previous_visible_line_start, reseat_1)
6496 (init_iterator): Empty the bidi cache "stack".
6497 (move_it_in_display_line_to): If iterator ended up at
6498 EOL, but we never saw any buffer positions smaller than
6499 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6500 motion in bidi-reordered lines.
6501 (move_it_in_display_line_to): Record prev_method and prev_pos
6502 immediately before the call to set_iterator_to_next. Fixes cursor
6503 motion in bidi-reordered lines with stretch glyphs and strings
6504 displayed in margins. (Bug#8133) (Bug#8867)
6505 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6506 TO_CHARPOS.
640c8776
SM
6507 (pos_visible_p): Support positions in bidi-reordered lines.
6508 Save and restore bidi cache.
0bb23927
EZ
6509
6510 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6511 (bidi_paragraph_info): Delete unused struct.
6512 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6513 (bidi_cache_start): New variable.
6514 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6515 to zero.
6516 (bidi_cache_fetch_state, bidi_cache_search)
6517 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6518 (bidi_cache_find, bidi_peek_at_next_level)
6519 (bidi_level_of_next_char, bidi_find_other_level_edge)
6520 (bidi_move_to_visually_next): Compare cache index with
6521 bidi_cache_start rather than with zero.
6522 (bidi_fetch_char): Accept new argument STRING; all callers
6523 changed. Support iteration over a string. Support strings with
6524 display properties. Support unibyte strings. Fix the type of
6525 `len' according to what STRING_CHAR_AND_LENGTH expects.
6526 (bidi_paragraph_init, bidi_resolve_explicit_1)
6527 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6528 (bidi_level_of_next_char, bidi_move_to_visually_next):
6529 Support iteration over a string.
0bb23927
EZ
6530 (bidi_set_sor_type, bidi_resolve_explicit_1)
6531 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6532 can now be zero (for strings); special values 0 and -1 were
6533 changed to -1 and -2, respectively.
6534 (bidi_char_at_pos): New function.
6535 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6536 Call it instead of FETCH_MULTIBYTE_CHAR.
6537 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6538 initialized to valid values.
6539 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6540 values.
6541 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6542 the test for valid cached positions. Fix the logic for looking up
6543 the sentinel state in the cache. GCPRO the Lisp string we are
6544 iterating.
6545 (bidi_push_it, bidi_pop_it): New functions.
6546 (bidi_initialize): Initialize the bidi cache start stack pointer.
6547 (bidi_cache_ensure_space): New function, refactored from part of
6548 bidi_cache_iterator_state. Don't assume the required size is just
6549 one BIDI_CACHE_CHUNK away.
6550 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6551 (bidi_count_bytes, bidi_char_at_pos): New functions.
6552 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6553 always valid if bidi_cache_idx is valid.
6554 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6555 is valid if it's going to be used.
6556 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6557 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6558 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6559 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6560 (bidi_find_other_level_edge, bidi_cache_start_stack):
6561 All variables related to cache indices are now EMACS_INT.
c965adc5 6562
0bb23927
EZ
6563 * dispextern.h (struct bidi_string_data): New structure.
6564 (struct bidi_it): New member `string'. Make flag members be 1-bit
6565 fields, and put them last in the struct.
640c8776
SM
6566 (compute_display_string_pos, compute_display_string_end):
6567 Update prototypes.
0bb23927
EZ
6568 (bidi_push_it, bidi_pop_it): Add prototypes.
6569 (struct iterator_stack_entry): New members bidi_p,
6570 paragraph_embedding, and from_disp_prop_p.
6571 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6572 (bidi_shelve_cache, bidi_unshelve_cache):
6573 Declare prototypes.
0bb23927
EZ
6574
6575 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6576 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6577 and vector-like objects.
6578
6579 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6580 cache around display iteration.
6581
6582 * window.c (Fwindow_end, window_scroll_pixel_based)
6583 (displayed_window_lines, Frecenter): Save and restore the bidi
6584 cache around display iteration.
6585
3bbd2265
LMI
65862011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6587
6588 * editfns.c (Fdelete_region): Clarify the use of the named
6589 parameters (bug#6788).
6590
adc47434
MR
65912011-07-14 Martin Rudalics <rudalics@gmx.at>
6592
6593 * indent.c (Fvertical_motion): Set and restore w->pointm when
6594 saving and restoring the window's buffer (Bug#9006).
6595
837c31f8
LMI
65962011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6597
6598 * editfns.c (Fstring_to_char): Clarify just what is returned
6599 (bug#6576). Text by Eli Zaretskii.
6600
ac389d0c
JB
66012011-07-13 Juanma Barranquero <lekktu@gmail.com>
6602
6603 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6604
0be0ce47
EZ
66052011-07-13 Eli Zaretskii <eliz@gnu.org>
6606
6607 * buffer.c (mmap_find): Fix a typo.
6608
cd18e7e3
JB
66092011-07-13 Johan Bockgård <bojohan@gnu.org>
6610
6611 Fix execution of x selection hooks.
6612 * xselect.c (Qx_lost_selection_functions)
6613 (Qx_sent_selection_functions): New vars.
6614 (syms_of_xselect): DEFSYM them.
6615 (x_handle_selection_request): Pass Qx_sent_selection_functions
6616 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6617 (x_handle_selection_clear,x_clear_frame_selections):
6618 Pass Qx_lost_selection_functions rather than
6619 Vx_lost_selection_functions to Frun_hook_with_args.
6620
47ea7f44
PE
66212011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6622
ac389d0c 6623 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6624 The old code sometimes used this field without initializing it.
6625
47ea7f44
PE
6626 * alloc.c (gc_sweep): Don't read past end of array.
6627 In theory, the old code could also have corrupted Emacs internals,
6628 though it'd be very unlikely.
6629
bc985c87
AS
66302011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6631
6632 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6633 argument. (Bug#4026)
bc985c87 6634
0cf34688
LMI
66352011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6636
b3dadd76
LMI
6637 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6638 key" (bug#4257).
6639
0cf34688
LMI
6640 * window.c (Fset_window_start): Doc fix (bug#4199).
6641 (Fset_window_hscroll): Ditto.
6642
270768cd
PE
66432011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6644
077e3dda 6645 Fix minor new problems caught by GCC 4.6.1.
270768cd 6646 * term.c (init_tty): Remove unused local.
490011a6 6647 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6648 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6649 not used otherwise.
270768cd 6650
b1f58454
CY
66512011-07-12 Chong Yidong <cyd@stupidchicken.com>
6652
6653 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6654
22b9578d
LMI
66552011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6656
6e70ab07
LMI
6657 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6658 are the mini-buffer and the echo area (bug#3320).
6659
22b9578d
LMI
6660 * term.c (init_tty): Remove support for supdup, c10 and perq
6661 terminals, which are no longer supported (bug#1482).
6662
8974cc9f
JB
66632011-07-10 Johan Bockgård <bojohan@gnu.org>
6664
6665 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6666
a560d974
JD
66672011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6668
6669 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6670 for non-popups (Bug#3642).
6671
1dae0f0a
AS
66722011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6673
268c2c36 6674 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6675 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6676 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6677 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6678 * data.c (fmod): Likewise.
6679 * dispnew.c (swap_glyphs_in_rows): Likewise.
6680 * emacs.c (memory_warning_signal): Likewise.
6681 * floatfns.c (float_error): Likewise.
6682 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6683 (otf_open, font_otf_capability, generate_otf_features)
6684 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6685 Likewise.
6686 * image.c (pbm_read_file): Likewise.
6687 * indent.c (string_display_width): Likewise.
6688 * intervals.c (check_for_interval, search_for_interval)
6689 (inc_interval_count, count_intervals, root_interval)
6690 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6691 * lread.c (defalias): Likewise.
268c2c36 6692 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6693 * regex.c (set_image_of_range_1, set_image_of_range)
6694 (regex_grow_registers): Likewise.
6695 * sysdep.c (strerror): Likewise.
6696 * termcap.c (valid_filename_p, tprint, main): Likewise.
6697 * tparam.c (main): Likewise.
6698 * unexhp9k800.c (run_time_remap, save_data_space)
6699 (update_file_ptrs, read_header, write_header, calculate_checksum)
6700 (copy_file, copy_rest, display_header): Likewise.
6701 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6702 Likewise.
6703 * xdisp.c (check_it): Likewise.
6704 * xfaces.c (register_color, unregister_color, unregister_colors):
6705 Likewise.
6706 * xfns.c (print_fontset_result): Likewise.
6707 * xrdb.c (member, fatal, main): Likewise.
6708
99033785
PE
67092011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6710
6711 Fix minor problems found by static checking (Bug#9031).
6712 * chartab.c (char_table_set_range, map_sub_char_table):
6713 Remove unused locals.
6714 (uniprop_table): Now static.
6715 * composite.c (_work_char): Remove unused static var.
6716
9cb2ac56
JB
67172011-07-09 Juanma Barranquero <lekktu@gmail.com>
6718
6719 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6720
f25661f0
JD
67212011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6722
6723 * gtkutil.c (qttip_cb): Remove code without function.
6724
8278c4fe
EZ
67252011-07-09 Eli Zaretskii <eliz@gnu.org>
6726
6727 * w32.c (pthread_sigmask): New stub.
6728
1692ae2d 67292011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6730
8a6ebd58 6731 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6732 sigprocmask is portable only for single-threaded applications, and
6733 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6734 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6735 (LIBES): Use it.
6736 * callproc.c (Fcall_process):
6737 * process.c (create_process):
6738 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6739 Use pthread_sigmask, not sigprocmask.
123403e4 6740
1b854618
JD
67412011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6742
6743 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6744 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6745 wrong (Bug#8591).
6746
3fe4b549
JD
67472011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6748
0ce7e563
JD
6749 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6750 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6751 (xg_hide_tooltip): Fix comment.
6752
3fe4b549
JD
6753 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6754 in registerServicesMenuSendTypes.
6755 (validRequestorForSendType): Don't check ns_return_types.
6756
6757 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6758 ns_return_type.
6759
5df75e47
JR
67602011-07-08 Jason Rumney <jasonr@gnu.org>
6761
22610910
JR
6762 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6763 SH_SHOW for hidden windows (Bug#5482).
6764
5df75e47
JR
6765 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6766 frame struct members of non-existent frames (Bug#6284).
6767
699c10bd
JD
67682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6769
4393663b
JD
6770 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6771 variable firstTime not needed on OSX >= 10.6.
6772 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6773 >= 10.5. Use setKnobProportion, setDoubleValue.
6774
6775 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6776 (MAC_OS_X_VERSION_10_5): Define if not defined.
6777 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6778 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6779 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6780
6781 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6782 cString and lossyCString on OSX >= 10.4
6783
58179cce 6784 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6785 sizeToFit on OSX >= 10.2.
6786
6787 * nsimage.m (allocInitFromFile): Don't use deprecated method
6788 bestRepresentationForDevice on OSX >= 10.6.
6789
6790 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6791 to avoid warning.
6792
6793 * emacs.c: Declare unexec_init_emacs_zone.
6794
a63e0781
JD
6795 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6796
699c10bd
JD
6797 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6798
6799 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6800 on svcsMenu (Bug#8842).
6801
6802 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6803 ns_return_types.
6804 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6805
6806 * nsterm.m (QUTF8_STRING): Declare.
6807 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6808 (validRequestorForSendType): Return type is (id).
6809 Change indexOfObjectIdenticalTo to indexOfObject.
6810 Check if we have local selection before returning self (Bug#8842).
6811 (writeSelectionToPasteboard): Put local selection into paste board
6812 if we have a local selection (Bug#8842).
6813 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6814
6815 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6816 (ns_get_local_selection): Declare.
6817
54e10184
LMI
68182011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6819
9888ff71
LMI
6820 * keymap.c (describe_map_tree): Don't insert a double newline at
6821 the end of the buffer (bug#1169) and return whether we inserted
6822 something.
6823
54e10184
LMI
6824 * callint.c (Fcall_interactively): Change "reading args" to
6825 "providing args" to try to clarify what it does (bug#1010).
6826
15fa4783
KH
68272011-07-07 Kenichi Handa <handa@m17n.org>
6828
6829 * composite.c (composition_compute_stop_pos): Ignore a static
6830 composition starting before CHARPOS (Bug#8915).
6831
6832 * xdisp.c (handle_composition_prop): Likewise.
6833
a8815b00
EZ
68342011-07-07 Eli Zaretskii <eliz@gnu.org>
6835
6836 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6837 (Bug#9015)
6838
ef7b981d 68392011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6840
6841 * character.h (unicode_category_t): New enum type.
6842
6843 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6844 (Qchar_code_property_table): New variable.
6845 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6846 (UNIPROP_COMPRESSED_FORM_P): New macros.
6847 (char_table_ascii): Uncompress the compressed values.
6848 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6849 Uncompress the compressed values.
ac389d0c 6850 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6851 (char_table_ref_and_range): Uncompress the compressed values.
6852 (sub_char_table_set): New arg is_uniprop. Callers changed.
6853 Uncompress the compressed values.
6854 (sub_char_table_set_range): Args changed. Callers changed.
6855 (char_table_set_range): Adjuted for the above change.
6856 (map_sub_char_table): Delete args default_val and parent. Add arg
6857 top. Give decoded values to a Lisp function.
640c8776 6858 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6859 values to a Lisp function. Gcpro more variables.
6860 (uniprop_table_uncompress)
6861 (uniprop_decode_value_run_length): New functions.
6862 (uniprop_decoder, uniprop_decoder_count): New variables.
6863 (uniprop_get_decoder, uniprop_encode_value_character)
6864 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6865 New functions.
6866 (uniprop_encoder, uniprop_encoder_count): New variables.
6867 (uniprop_get_encoder, uniprop_table)
6868 (Funicode_property_table_internal, Fget_unicode_property_internal)
6869 (Fput_unicode_property_internal): New functions.
6870 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6871 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6872 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6873 char-code-property-alist.
6874
640c8776 6875 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6876 Vunicode_category_table.
6877
640c8776 6878 * font.c (font_range): Adjust for the change of
c805dec0
KH
6879 Vunicode_category_table.
6880
76b397fb
DN
68812011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6882
6883 * m/iris4d.h: Remove file, move contents ...
6884 * s/irix6-5.h: ... here.
6885
22b4128e
PE
68862011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6887
6888 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6889 * alloc.c (mark_buffer):
6890 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6891 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6892 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6893 This isn't true in general, and it's particularly not true
6894 if Emacs is configured with --with-wide-int.
6895 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6896 New macros, used in the buffer.c change.
6897
869795d6
JD
68982011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6899
6900 * xsettings.c: Use both GConf and GSettings if both are available.
6901 (store_config_changed_event): Add comment.
6902 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6903 (store_tool_bar_style_changed): New functions.
5e617bc2 6904 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6905 (struct xsettings): Move font inside HAVE_XFT.
6906 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6907 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6908 Move inside HAVE_XFT.
640c8776 6909 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6910 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6911 also.
6912 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6913 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6914 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6915 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6916 (parse_settings): Move check for font inside HAVE_XFT.
6917 (read_settings, apply_xft_settings): Add comment.
6918 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6919 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6920 call store_font_name_changed.
6921 (xft_settings_event): Add comment.
6922 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6923 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6924 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6925 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6926 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6927 (xsettings_get_system_font, xsettings_get_system_normal_font):
6928 Add comment.
869795d6 6929
d8ed26bd
PE
69302011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6931
6932 Random fixes. E.g., (random) never returned negative values.
6933 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6934 subseconds part to the entropy, as that's a bit more random.
6935 Prefer signed to unsigned, since the signedness doesn't matter and
6936 in general we prefer signed. When given a limit, use a
6937 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6938 latter isn't right if USE_2_TAGS_FOR_INTS.
6939 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6940 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6941
cabf1cac
SM
69422011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6943
6944 * textprop.c (text_property_stickiness):
6945 Obey Vtext_property_default_nonsticky.
6946 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6947 * w32fns.c (syms_of_w32fns):
6948 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6949
6e9b2be9
PE
69502011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6951
6952 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6953 This is more efficient than Ffile_directory_p and avoids a minor race.
6954
90186c68
LMI
69552011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6956
7c301272
LMI
6957 * buffer.c (Foverlay_put): Say what the return value is
6958 (bug#7835).
6959
c4f2d8d4
LMI
6960 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6961 is a directory before asking whether to use the file name
6962 (bug#7564).
ad637907
LMI
6963 (barf_or_query_if_file_exists): Make the "File is a directory"
6964 error be more correct.
c4f2d8d4 6965
90186c68
LMI
6966 * fns.c (Frequire): Remove the mention of the .gz files, since
6967 that's installation-specific, but keep the mention of
6968 `get-load-suffixes'.
6969
da64016e
PE
69702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6971
6972 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6973 Report string overflow if the output is too long.
6974
7d47b580
JB
69752011-07-04 Juanma Barranquero <lekktu@gmail.com>
6976
a555cb87
JB
6977 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6978 (syms_of_gnutls): Remove duplicate DEFSYM for
6979 Qgnutls_bootprop_verify_hostname_error, an error for
6980 Qgnutls_bootprop_verify_error (which is no longer used).
6981
7d47b580
JB
6982 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6983 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6984 Also (re)move comments that are misplaced or no longer relevant.
6985
1e49bfab
LMI
69862011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6987
6988 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6989
1485f4c0
CY
69902011-07-03 Chong Yidong <cyd@stupidchicken.com>
6991
6992 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6993 and background color parameters if they have been changed.
6994
a9ab721e
LMI
69952011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6996
6997 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6998
cf7cff57
PE
69992011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7000
2e13213d
PE
7001 * xsettings.c (SYSTEM_FONT): Define only when used.
7002 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7003
cf7cff57
PE
7004 * keymap.c (access_keymap_1): Now static.
7005
7a8e04f7
CY
70062011-07-02 Chong Yidong <cyd@stupidchicken.com>
7007
7008 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7009 leave any prefix arg for the up event (Bug#1586).
7010
61352f62
LMI
70112011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7012
69bb1ef7
LMI
7013 * lread.c (syms_of_lread): Mention single symbols defined by
7014 `defvar' or `defconst' (bug#7154).
7015
61352f62 7016 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7017 (Frequire): Mention get-load-suffixes.
61352f62 7018
28545e04
MR
70192011-07-02 Martin Rudalics <rudalics@gmx.at>
7020
7021 * window.h (window): Remove clone_number slot.
7022 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7023 Remove.
7024 (make_parent_window, make_window, saved_window)
7025 (Fset_window_configuration, save_window_save): Don't deal with
7026 clone numbers.
7027 * buffer.c (Qclone_number): Remove declaration.
7028 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7029
3349e122
SM
70302011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7031
7032 Add multiple inheritance to keymaps.
7033 * keymap.c (Fmake_composed_keymap): New function.
7034 (Fset_keymap_parent): Simplify.
7035 (fix_submap_inheritance): Remove.
7036 (access_keymap_1): New function extracted from access_keymap to handle
7037 embedded parents and handle lists of maps.
7038 (access_keymap): Use it.
7039 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7040 (Fcopy_keymap): Handle embedded parents.
7041 (Fcommand_remapping, define_as_prefix): Simplify.
7042 (Fkey_binding): Simplify.
7043 (syms_of_keymap): Move minibuffer-local-completion-map,
7044 minibuffer-local-filename-completion-map,
7045 minibuffer-local-must-match-map, and
7046 minibuffer-local-filename-must-match-map to Elisp.
7047 (syms_of_keymap): Defsubr make-composed-keymap.
7048 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7049 (parse_menu_item): Trivial simplification.
7050
3279eb87
GM
70512011-07-01 Glenn Morris <rgm@gnu.org>
7052
7053 * Makefile.in (SETTINGS_LIBS): Fix typo.
7054
4550efdf
KI
70552011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7056
7057 * coding.c (Fencode_coding_string): Record the last coding system
7058 used, as the function doc string says (bug#8738).
7059
0949d2b6
JD
70602011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7061
7062 * xsettings.c (store_monospaced_changed): Take new font as arg and
7063 check for change against current_mono_font.
7064 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7065 (emacs_settings_constructor, emacs_settings_get_property)
7066 (emacs_settings_set_property, emacs_settings_class_init)
7067 (emacs_settings_init, gsettings_obj): Remove.
7068 (something_changedCB): New function for HAVE_GSETTINGS.
7069 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7070 with value as argument.
7071 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7072 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7073 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7074 "changed".
7075
7076 * xgselect.c: Add defined (HAVE_GSETTINGS).
7077 (xgselect_initialize): Ditto.
7078
7079 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7080 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7081 xg_select.
7082
bbc6b304
PE
70832011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7084
7085 * eval.c (struct backtrace): Simplify and port the data structure.
7086 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7087 signed bit field, as this assumption is not portable and it makes
7088 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7089 "char debug_on_exit : 1" as this is not portable either; instead,
7090 use the portable "unsigned int debug_on_exit : 1". Remove unused
7091 member evalargs. Remove obsolete comments about cc bombing out.
7092
9851bfc5
JD
70932011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7094
51bb811f 7095 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7096 Let HAVE_GSETTINGS override HAVE_GCONF.
7097 (store_monospaced_changed): New function.
7098 (EMACS_SETTINGS): A new type derived from GObject to handle
7099 GSettings notifications.
7100 (emacs_settings_constructor, emacs_settings_get_property)
7101 (emacs_settings_set_property, emacs_settings_class_init):
7102 New functions.
7103 (gsettings_client, gsettings_obj): New variables.
7104 (GSETTINGS_SCHEMA): New define.
7105 (something_changedCB): Call store_monospaced_changed.
7106 (init_gsettings): New function.
7107 (xsettings_initialize): Call init_gsettings.
7108 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7109 to NULL.
7110
640c8776 7111 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7112 GCONF_CFLAGS/LIBS.
7113
5386012d
MR
71142011-06-29 Martin Rudalics <rudalics@gmx.at>
7115
7116 * window.c (resize_root_window, grow_mini_window)
7117 (shrink_mini_window): Rename Qresize_root_window to
7118 Qwindow_resize_root_window and Qresize_root_window_vertically to
7119 Qwindow_resize_root_window_vertically.
7120
f13e0b08
PE
71212011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7122
7123 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7124
94515237
JB
71252011-06-27 Juanma Barranquero <lekktu@gmail.com>
7126
7127 * makefile.w32-in: Redesign dependencies so they reflect more
7128 clearly which files are directly included by each source file,
7129 and not through other includes.
7130
e43b6e43
MR
71312011-06-27 Martin Rudalics <rudalics@gmx.at>
7132
7133 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7134 (sort_overlays, overlay_strings): When an overlay's clone number
7135 matches the window's clone number process the overlay even if
7136 the overlay's window property doesn't match the current window.
7137
d68443dc
MR
7138 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7139 (Fwindow_hchild): Rename to Fwindow_left_child.
7140 (Fwindow_next): Rename to Fwindow_next_sibling.
7141 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7142 (resize_window_check): Rename to window_resize_check.
7143 (resize_window_apply): Rename to window_resize_apply.
7144 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7145 (Fdelete_other_windows_internal, resize_frame_windows)
7146 (Fsplit_window_internal, Fdelete_window_internal)
7147 (grow_mini_window, shrink_mini_window)
7148 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7149
c7e73be5
JD
71502011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7151
7152 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7153 (emacs_fixed_set_min_size): Remove.
7154 (emacs_fixed_new): Take frame as argument.
7155
7156 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7157 (_EmacsFixedPrivate): Remove minwidth/height.
7158 Add struct frame *f.
7159 (emacs_fixed_init): Initialize priv->f.
7160 (get_parent_class, emacs_fixed_set_min_size): Remove.
7161 (emacs_fixed_new): Set priv->f to argument.
7162 (emacs_fixed_get_preferred_width)
7163 (emacs_fixed_get_preferred_height): Use min_width/height from
7164 frames size_hint to set minimum and natural (Bug#8919).
7165 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7166 and use min_width/height from frames size_hint to set
7167 min_width/height (Bug#8919).
7168
7169 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7170 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7171 Fix indentation.
c7e73be5 7172
cf99dcf8
EZ
71732011-06-26 Eli Zaretskii <eliz@gnu.org>
7174
7175 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7176 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7177 called at ZV.
7178
029529ac
CY
71792011-06-26 Chong Yidong <cyd@stupidchicken.com>
7180
7181 * process.c (wait_reading_process_output): Bypass select if
7182 waiting for a cell while ignoring keyboard input, and input is
7183 pending. Suggested by Jan Djärv (Bug#8869).
7184
7a7ef429
PE
71852011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7186
7187 Use gnulib's dup2 module instead of rolling our own.
7188 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7189
11fdef7d 71902011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7191
7192 * dispnew.c (scrolling_window): Before scrolling, turn off a
7193 mouse-highlight in the window being scrolled.
7194
cd3520a4
JB
71952011-06-24 Juanma Barranquero <lekktu@gmail.com>
7196
7197 Move DEFSYM to lisp.h and use everywhere.
7198
7199 * character.h (DEFSYM): Move declaration...
7200 * lisp.h (DEFSYM): ...here.
7201
7202 * gnutls.c:
7203 * minibuf.c:
7204 * w32menu.c:
7205 * w32proc.c:
7206 * w32select.c: Don't include character.h.
7207
7208 * alloc.c (syms_of_alloc):
7209 * buffer.c (syms_of_buffer):
7210 * bytecode.c (syms_of_bytecode):
7211 * callint.c (syms_of_callint):
7212 * casefiddle.c (syms_of_casefiddle):
7213 * casetab.c (init_casetab_once):
7214 * category.c (init_category_once, syms_of_category):
7215 * ccl.c (syms_of_ccl):
7216 * cmds.c (syms_of_cmds):
7217 * composite.c (syms_of_composite):
7218 * dbusbind.c (syms_of_dbusbind):
7219 * dired.c (syms_of_dired):
7220 * dispnew.c (syms_of_display):
7221 * doc.c (syms_of_doc):
7222 * editfns.c (syms_of_editfns):
7223 * emacs.c (syms_of_emacs):
7224 * eval.c (syms_of_eval):
7225 * fileio.c (syms_of_fileio):
7226 * fns.c (syms_of_fns):
7227 * frame.c (syms_of_frame):
7228 * fringe.c (syms_of_fringe):
7229 * insdel.c (syms_of_insdel):
7230 * keymap.c (syms_of_keymap):
7231 * lread.c (init_obarray, syms_of_lread):
7232 * macros.c (syms_of_macros):
7233 * msdos.c (syms_of_msdos):
7234 * print.c (syms_of_print):
7235 * process.c (syms_of_process):
7236 * search.c (syms_of_search):
7237 * sound.c (syms_of_sound):
7238 * syntax.c (init_syntax_once, syms_of_syntax):
7239 * terminal.c (syms_of_terminal):
7240 * textprop.c (syms_of_textprop):
7241 * undo.c (syms_of_undo):
7242 * w32.c (globals_of_w32):
7243 * window.c (syms_of_window):
7244 * xdisp.c (syms_of_xdisp):
7245 * xfaces.c (syms_of_xfaces):
7246 * xfns.c (syms_of_xfns):
7247 * xmenu.c (syms_of_xmenu):
7248 * xsettings.c (syms_of_xsettings):
7249 * xterm.c (syms_of_xterm): Use DEFSYM.
7250
4228cf16
TZ
72512011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7252
cd3520a4 7253 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7254
7fcccf1e
PE
72552011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7256
7efb4e0e
PE
7257 Integer and buffer overflow fixes (Bug#8873).
7258
ff5844ad
PE
7259 * print.c (printchar, strout): Check for string overflow.
7260 (PRINTPREPARE, printchar, strout):
7261 Don't set size unless allocation succeeds.
7262
90532f02
PE
7263 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7264 for sizes. Check for string overflow more accurately.
7265 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7266
6d84508d
PE
7267 * macros.c: Integer and buffer overflow fixes.
7268 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7269 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7270 Use ptrdiff_t, not int, for sizes.
7271 Don't increment bufsize until after realloc succeeds.
7272 Check for size-calculation overflow.
7273 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7274
437b2cb4
PE
7275 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7276
8b9ac8b4
PE
7277 * lread.c: Integer overflow fixes.
7278 (read_integer): Radix is now EMACS_INT, not int,
7279 to improve quality of diagnostics for out-of-range radices.
7280 Calculate buffer size correctly for out-of-range radices.
7281 (read1): Check for integer overflow in radices, and in
7282 read-circle numbers.
82cb60d3
PE
7283 (read_escape): Avoid int overflow.
7284 (Fload, openp, read_buffer_size, read1)
7285 (substitute_object_recurse, read_vector, read_list, map_obarray):
7286 Use ptrdiff_t, not int, for sizes.
7287 (read1): Use EMACS_INT, not int, for sizes.
20270765 7288 Check for size overflow.
8b9ac8b4 7289
7fcccf1e
PE
7290 * image.c (cache_image): Check for size arithmetic overflow.
7291
bfbbd7e7
PE
7292 * lread.c: Integer overflow issues.
7293 (saved_doc_string_size, saved_doc_string_length)
7294 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7295 Now ptrdiff_t, not int.
7296 (read1): Don't assume doc string length fits in int. Check for
7297 out-of-range doc string lengths.
7298 (read_list): Don't assume file position fits in int.
39019e54 7299 (read_escape): Check for hex character overflow.
bfbbd7e7 7300
4e323265
LL
73012011-06-22 Leo Liu <sdl.web@gmail.com>
7302
7303 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7304 Move to minibuffer.el.
7305
85fece3e
PE
73062011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7307
20b84ce9 7308 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7309 The following patches are for when GLYPH_DEBUG && !XASSERT.
7310 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7311 * dispnew.c (flush_stdout):
7312 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7313 Mark as externally visible.
7314 * dispnew.c (check_window_matrix_pointers): Now static.
7315 * dispnew.c (window_to_frame_vpos):
7316 * xfns.c (unwind_create_frame):
7317 * xterm.c (x_check_font): Remove unused local.
7318 * scroll.c (CHECK_BOUNDS):
7319 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7320 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7321 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7322 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7323 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7324 Now static.
7325 (debug_method_add): Use va_list and vsprintf rather than relying
7326 on undefined behavior with wrong number of arguments.
7327 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7328 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7329 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7330 since we're not interested in debugging glyphs with old libraries.
7331 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7332 GCC 4.6.0's static checking.
7333
0766b489
PE
73342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7335
31fd4b32
PE
7336 Integer overflow and signedness fixes (Bug#8873).
7337 A few related buffer overrun fixes, too.
7338
b79e8648
PE
7339 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7340
0766b489
PE
7341 * dispextern.h (struct face.stipple):
7342 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7343 (x_bitmap_mask, x_allocate_bitmap_record)
7344 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7345 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7346 (x_create_bitmap_from_xpm_data):
7347 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7348 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7349 (.bitmaps_last):
7350 * xfaces.c (load_pixmap):
7351 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7352 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7353 (.bitmaps_last, struct x_output.icon_bitmap):
7354 Use ptrdiff_t, not int, for bitmap indexes.
7355 (x_allocate_bitmap_record): Check for size overflow.
7356 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7357
b081724f
PE
7358 Use ptrdiff_t, not int, for overlay counts.
7359 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7360 * editfns.c (overlays_around, get_pos_property):
7361 * textprop.c (get_char_property_and_overlay):
7362 * xdisp.c (next_overlay_change, note_mouse_highlight):
7363 * xfaces.c (face_at_buffer_position):
21514da7
PE
7364 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7365 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7366 (Fnext_overlay_change, Fprevious_overlay_change)
7367 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7368 Use ptrdiff_t, not int, for sizes.
21514da7 7369 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7370
3de73e5e
PE
7371 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7372
2606c57b
PE
7373 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7374 (x_session_initialize): Do not assume string length fits in int.
7375
aaafe47a
PE
7376 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7377 This is unlikely, but can occur if DPI is outlandish.
7378
2674ddc8 7379 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7380 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7381
28154962
PE
7382 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7383 * xrdb.c (magic_file_p, search_magic_path):
7384 Omit last arg SUFFIX; it was always 0. All callers changed.
7385 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7386
7de51af5
PE
7387 * xfont.c (xfont_match): Avoid need for strlen.
7388
25ed6cc3
PE
7389 * xfns.c: Don't assume strlen fits in int.
7390 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7391
4eab31dd
PE
7392 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7393 not unsigned long, as we prefer signed integers. All callers changed.
7394 Detect integer overflow in repeat count.
7395 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7396 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7397
171e2a58
PE
7398 * termcap.c: Don't assume sizes fit in int and never overflow.
7399 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7400 (gobble_line): Check for size-calculation overflow.
7401
ad39faca 7402 * minibuf.c (Fread_buffer):
6e5bb2dc 7403 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7404 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7405 Don't assume string length fits in int.
7406
52c61c22 7407 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7408 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7409
b5b8c9e5
PE
7410 * font.c: Don't assume string length fits in int.
7411 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7412 Use ptrdiff_t, not int.
ccd6111c
PE
7413 (font_intern_prop): Don't assume string length fits in int.
7414 Don't assume integer property fits in fixnum.
7415 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7416
882f0d81 7417 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7418 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7419 Reformulate so as not to need the command string.
7420 Invoke gzip -cd rather than gunzip, as it's more portable.
7421 (lock_info_type, lock_file_1, lock_file):
7422 Don't assume pid_t and time_t fit in unsigned long.
7423 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7424 (current_lock_owner): Prefer signed type for sizes.
7425 Use memcpy, not strncpy, where memcpy is what is really wanted.
7426 Don't assume (via atoi) that time_t and pid_t fit in int.
7427 Check for time_t and/or pid_t out of range, e.g., via a network share.
7428 Don't alloca where an auto var works fine.
7429
93f4cf88
PE
7430 * fileio.c: Fix some integer overflow issues.
7431 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7432 Don't assume string length fits in int.
7433 (directory_file_name): Don't assume string length fits in long.
7434 (make_temp_name): Don't assume pid fits in int, or that its print
7435 length is less than 20.
7436
f3e92b69
PE
7437 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7438
1bfdaf10
PE
7439 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7440
35016e9a
PE
7441 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7442
3d1e65a1
PE
7443 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7444 We prefer signed integers, even for size calculations.
7445
0b963a93
PE
7446 * emacs.c: Don't assume string length fits in 'int'.
7447 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7448 (main): Don't invoke strlen when not needed.
7449
573f4b54
PE
7450 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7451 (XD_DEBUG_MESSAGE): Don't waste a byte.
7452
989f33ba
PE
7453 * callproc.c (getenv_internal_1, getenv_internal)
7454 (Fgetenv_internal):
965d34eb
PE
7455 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7456
e4d29b33
PE
7457 * lread.c (invalid_syntax): Omit length argument.
7458 All uses changed. This doesn't fix a bug, but it simplifies the
7459 code away from its former Hollerith-constant appearance, and it's
7460 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7461 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7462
eb49b136
PE
7463 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7464 This didn't break anything, but it didn't help either.
7465 It's confusing to put a bogus integer in a place where the actual
7466 value does not matter.
9f62aeb1 7467 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7468 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7469
15375a22
PE
7470 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7471 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7472 implementation.
b61cc01c
PE
7473 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7474 We prefer signed types, and the value cannot exceed the EMACS_INT
7475 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7476 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7477 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7478 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7479
53b2623d
PE
7480 * indent.c (sane_tab_width): New function.
7481 (current_column, scan_for_column, Findent_to, position_indentation)
7482 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7483 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7484
51cab52b 7485 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7486
f2ed8a70
PE
7487 * lisp.h (lint_assume): New macro.
7488 * composite.c (composition_gstring_put_cache):
7489 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7490
abe80cc6
PE
7491 * editfns.c, insdel.c:
7492 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7493
b02c740e
PE
7494 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7495
ebc96716
PE
7496 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7497
b4e50fa0 7498 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7499 Use much-faster test for byte-length change.
311d5d7c 7500 Don't assume string byte-length fits in 'int'.
a4cf38e4 7501 Check that character arg fits in 'int'.
85461888 7502 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7503
c0c1ee9f
PE
7504 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7505
a498d7f4
PE
7506 * fns.c (concat): Catch string overflow earlier.
7507 Do not rely on integer wraparound.
7508
51cab52b
PE
7509 * dispextern.h (struct it.overlay_strings_charpos)
7510 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7511 * xdisp.c (forward_to_next_line_start)
7512 (back_to_previous_visible_line_start)
7513 (reseat_at_next_visible_line_start, next_element_from_buffer):
7514 Don't arbitrarily truncate the value of 'selective' to int.
7515
76031fad
PE
7516 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7517
5eb55db9
PE
7518 * composite.c: Don't truncate sizes to 'int'.
7519 (composition_gstring_p, composition_reseat_it)
7520 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7521 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7522 not EMACS_UINT, for indexes.
5eb55db9 7523
0703a717
PE
7524 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7525
d6202519
PE
7526 * buffer.c: Include <verify.h>.
7527 (struct sortvec.priority, struct sortstr.priority):
8961a454 7528 Now EMACS_INT, not int.
c20998a7 7529 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7530 (struct sortstr.size, record_overlay_string)
7531 (struct sortstrlist.size, struct sortlist.used):
7532 Don't truncate size to int.
7533 (record_overlay_string): Check for size-calculation overflow.
d6202519 7534 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7535
d5a19415
JM
75362011-06-22 Jim Meyering <meyering@redhat.com>
7537
029529ac 7538 Don't leak an XBM-image-sized buffer
d5a19415
JM
7539 * image.c (xbm_load): Free the image buffer after using it.
7540
a9041e6c
PE
75412011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7542
7543 Port to Sun C.
7544 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7545 that Sun C diagnosed.
7546 * fns.c (secure_hash): Fix pointer signedness issue.
7547 * intervals.c (static_offset_intervals): New function.
7548 (offset_intervals): Use it.
7549
7f3f739f
LL
75502011-06-21 Leo Liu <sdl.web@gmail.com>
7551
7552 * deps.mk (fns.o):
7553 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7554 sha512.h.
7555
7556 * fns.c (secure_hash): Rename from crypto_hash_function and change
7557 the first arg to accept symbols.
5b66d427 7558 (Fsecure_hash): New primitive.
7f3f739f
LL
7559 (syms_of_fns): New symbols.
7560
76147d94
DD
75612011-06-20 Deniz Dogan <deniz@dogan.se>
7562
7563 * process.c (Fset_process_buffer): Clarify return value in
7564 docstring.
7565
7d7d0045
CY
75662011-06-18 Chong Yidong <cyd@stupidchicken.com>
7567
7568 * dispnew.c (add_window_display_history): Use BVAR.
7569
7570 * xdisp.c (debug_method_add): Use BVAR.
7571 (check_window_end, dump_glyph_matrix, dump_glyph)
7572 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7573
7574 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7575 Likewise.
7576
7577 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7578 check till after the cache is created in init_frame_faces.
7579
ff2bc410
SM
75802011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7581
7582 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7583
28177add
PE
75842011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7585
dd3482fe
PE
7586 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7587 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7588 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7589
393d71f3 7590 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7591 * fileio.c (Finsert_file_contents):
7592 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7593 Remove the old (too-loose) buffer overflow checks.
7594 They weren't needed, since make_gap checks for buffer overflow.
7595 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7596 The old code merely checked for Emacs fixnum overflow, and relied
7597 on undefined (wraparound) behavior. The new code avoids undefined
7598 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7599
2e6813b0 7600 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7601 Tune. Don't use wider integers than needed. Don't use alloca.
7602 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7603
599a9e4f
PE
7604 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7605
99561444
PE
7606 * insdel.c, lisp.h (buffer_overflow): New function.
7607 (insert_from_buffer_1, replace_range, replace_range_2):
7608 * insdel.c (make_gap_larger):
7609 * editfns.c (Finsert_char):
7610 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7611
28177add
PE
7612 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7613
e69dafad
PE
76142011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7615
4baa020d 7616 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7617
b1c46f02
PE
7618 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7619 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7620
e69dafad
PE
7621 * fileio.c: Don't assume EMACS_INT fits in off_t.
7622 (emacs_lseek): New static function.
7623 (Finsert_file_contents, Fwrite_region): Use it.
7624 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7625
566684ea
PE
7626 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7627
e6966cd6
PE
7628 * fns.c: Don't overflow int when computing a list length.
7629 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7630 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7631 truncation on 64-bit hosts. Check for QUIT every
7632 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7633 faster and is responsive enough.
7634 (Flength): Report an error instead of overflowing an integer.
7635 (Fsafe_length): Return a float if the value is not representable
7636 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7637 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7638 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7639
dd0b0efb
PE
7640 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7641 (header_size, word_size): New constants.
7642 (allocate_vectorlike): Don't check size overflow here.
7643 (allocate_vector): Check it here instead, since this is the only
7644 caller of allocate_vectorlike that could cause overflow.
7645 Check that the new vector's length is representable as a fixnum.
7646
86fe5cfe
PE
7647 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7648 The previous code was bogus. For example, next_almost_prime (32)
7649 returned 39, which is undesirable as it is a multiple of 3; and
7650 next_almost_prime (24) returned 25, which is a multiple of 5 so
7651 why was the code bothering to check for multiples of 7?
7652
80e88859
PE
7653 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7654
4a2f0ad6
PE
7655 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7656
f66c7cf8
PE
7657 Variadic C functions now count arguments with ptrdiff_t.
7658 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7659 Back then I didn't know that the Emacs coding style prefers signed int.
7660 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7661 were being counted with int, which may truncate counts on 64-bit
7662 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7663 * lisp.h (struct Lisp_Subr.function.aMANY)
7664 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7665 Arg counts are now ptrdiff_t, not size_t.
7666 All variadic functions and their callers changed accordingly.
7667 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7668 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7669 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7670 * callint.c (Fcall_interactively): Check arg count for overflow,
7671 to avoid potential buffer overrun. Use signed char, not 'int',
7672 for 'varies' array, so that we needn't bother to check its size
7673 calculation for overflow.
7674 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7675 * eval.c (apply_lambda):
7676 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7677 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7678 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7679
a1759b76
PE
7680 * callint.c (Fcall_interactively): Don't use index var as event count.
7681
d96be9fc
PE
7682 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7683 * mem-limits.h (SIZE): Remove; no longer used.
7684
a690a978 7685 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7686
578c21e6
PE
7687 Remove unnecessary casts.
7688 * xterm.c (x_term_init):
7689 * xfns.c (x_set_border_pixel):
7690 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7691 These aren't needed now that we assume ANSI C.
7692
96f53c6c
PE
7693 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7694 It's more likely to cause problems (due to unsigned overflow)
7695 than to cure them.
7696
83c77d31
PE
7697 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7698
ee2079f1
PE
7699 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7700
6da65536
PE
7701 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7702
7147c4a4
PE
7703 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7704
193e32d9
PE
7705 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7706
e5533da6
PE
7707 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7708
9910e595
PE
7709 GLYPH_CODE_FACE returns EMACS_INT, not int.
7710 * dispextern.h (merge_faces):
7711 * xfaces.c (merge_faces):
01103c44
PE
7712 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7713 Don't assume EMACS_INT fits in int.
9910e595 7714
2638320e
PE
7715 * character.h (CHAR_VALID_P): Remove unused parameter.
7716 * fontset.c, lisp.h, xdisp.c: All uses changed.
7717
045eb8d9
PE
7718 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7719
c1f134b5
PE
7720 * fns.c (concat): Minor tuning based on overflow analysis.
7721 This doesn't fix any bugs. Use int to hold character, instead
7722 of constantly refetching from Emacs object. Use XFASTINT, not
7723 XINT, for value known to be a character. Don't bother comparing
7724 a single byte to 0400, as it's always less.
7725
395fcb93 7726 * floatfns.c (Fexpt):
327eeec8
PE
7727 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7728
abbd3d23
PE
7729 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7730 for characters.
7731
684a03ef
PE
7732 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7733
0fed43f3
PE
7734 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7735 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7736 incorrectly succeed when S was a string, because 4294967386 was
7737 truncated before it was used.
7738
8fd02eb7
PE
7739 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7740 Otherwise, an out-of-range integer could cause undefined behavior
7741 on a 64-bit host.
7742
f8c86b69
PE
7743 * composite.c: Use int, not EMACS_INT, for characters.
7744 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7745 EMACS_INT, for values that are known to be in character range.
7746 This doesn't fix any bugs but is the usual style inside Emacs and
7747 may generate better code on 32-bit machines.
7748
34206dd2
PE
7749 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7750 This is for reasons similar to the recent CHAR_STRING fix.
7751 * charset.c (Fencode_char): Check that character arg is actually
7752 a character. Pass an int to ENCODE_CHAR.
7753 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7754 wider than 'int', as a compile-time check to prevent future regressions
7755 in this area.
7756
c5958d4c 7757 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7758
7759 Make sure a 64-bit char is never passed to CHAR_STRING.
7760 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7761 by silently ignoring the top 32 bits, allowing some values
7762 that were far too large to be valid characters.
7763 * character.h: Include <verify.h>.
7764 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7765 arguments are no wider than unsigned, as a compile-time check
7766 to prevent future regressions in this area.
7767 * data.c (Faset):
01103c44 7768 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7769 (Fsubst_char_in_region):
7770 * fns.c (concat):
7771 * xdisp.c (decode_mode_spec_coding):
7772 Adjust to CHAR_STRING's new requirement.
7773 * editfns.c (Finsert_char, Fsubst_char_in_region):
7774 * fns.c (concat): Check that character args are actually
7775 characters. Without this test, these functions did the wrong
7776 thing with wildly out-of-range values on 64-bit hosts.
7777
d37ca623
PE
7778 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7779 These casts should not be needed on 32-bit hosts, either.
7780 * keyboard.c (read_char):
7781 * lread.c (Fload): Remove casts to unsigned.
7782
ea204efb
PE
7783 * lisp.h (UNSIGNED_CMP): New macro.
7784 This fixes comparison bugs on 64-bit hosts.
7785 (ASCII_CHAR_P): Use it.
7786 * casefiddle.c (casify_object):
01103c44 7787 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7788 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7789 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7790 * dispextern.h (FACE_FROM_ID):
7791 * keyboard.c (read_char): Use UNSIGNED_CMP.
7792
41cb286c
PE
7793 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7794 not to EMACS_INT, to avoid GCC warning.
7795
4a1b9832
PE
7796 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7797
55daad71
PE
7798 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7799 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7800 isn't needed on 32-bit machines.
8f95c75c 7801
01103c44
PE
7802 * buffer.c (Fgenerate_new_buffer_name):
7803 Use EMACS_INT for count, not int.
0ceccced 7804 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7805
7806 * data.c (Qcompiled_function): Now static.
7807
c6f072e7
PE
7808 * window.c (window_body_lines): Now static.
7809
20ce5912
PE
7810 * image.c (gif_load): Rename local to avoid shadowing.
7811
9c4c5f81
PE
7812 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7813 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7814 * alloc.c (make_save_value): Integer argument is now of type
7815 ptrdiff_t, not int.
7816 (mark_object): Use ptrdiff_t, not int.
7817 * lisp.h (pD): New macro.
7818 * print.c (print_object): Use it.
7819
c0c5c8ae
PE
7820 * alloc.c: Use EMACS_INT, not int, to count objects.
7821 (total_conses, total_markers, total_symbols, total_vector_size)
7822 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7823 (total_free_floats, total_floats, total_free_intervals)
7824 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7825 Now EMACS_INT, not int. All uses changed.
7826 (Fgarbage_collect): Compute overall total using a double, so that
7827 integer overflow is less likely to be a problem. Check for overflow
7828 when converting back to an integer.
5a25e253
PE
7829 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7830 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7831 These were 'int' variables that could overflow on 64-bit hosts;
7832 they were never used, so remove them instead of repairing them.
211a0b2a 7833 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7834 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7835 Previously, this ceilinged at INT_MAX, but that doesn't work on
7836 64-bit machines.
e46bb31a 7837 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7838
c78baabf 7839 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7840 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7841 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7842 when a (possibly-narrower) signed value would do just as well.
7843 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7844
c9d624c6
PE
7845 * alloc.c: Catch some string size overflows that we were missing.
7846 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7847 for convenience in STRING_BYTES_MAX.
7848 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7849 The definition here is exact; the one in lisp.h was approximate.
7850 (allocate_string_data): Check for string overflow. This catches
7851 some instances we weren't catching before. Also, it catches
7852 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7853 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7854 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7855
c9d624c6
PE
7856 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7857 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7858 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7859
353032ce
PE
7860 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7861
2bccce07
PE
7862 * alloc.c (Fmake_string): Check for out-of-range init.
7863
0ac30604
SM
78642011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7865
7866 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7867
c195f2de
JD
78682011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7869
7870 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7871 xg_get_default_scrollbar_width.
7872
7873 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7874 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7875 (style_changed_cb): Call update_theme_scrollbar_width and call
7876 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7877 all frames (Bug#8505).
7878 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7879 Call gtk_window_set_resizable if HAVE_GTK3.
7880 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7881 and height if HAVE_GTK3 (Bug#8505).
7882 (scroll_bar_width_for_theme): New variable.
7883 (update_theme_scrollbar_width): New function.
7884 (xg_get_default_scrollbar_width): Move code to
7885 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7886 (xg_initialize): Call update_theme_scrollbar_width.
7887
7888 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7889
7890 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7891
e10ac9f1
MR
78922011-06-12 Martin Rudalics <rudalics@gmx.at>
7893
7894 * frame.c (make_frame): Call other_buffer_safely instead of
7895 other_buffer.
7896
7897 * window.c (temp_output_buffer_show): Call display_buffer with
7898 second argument Vtemp_buffer_show_specifiers and reset latter
7899 immediately after the call.
7900 (Vtemp_buffer_show_specifiers): New variable.
7901 (auto_window_vscroll_p, next_screen_context_lines)
7902 (Vscroll_preserve_screen_position): Remove leading asterisks from
7903 doc-strings.
7904
2d3c217e 79052011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7906
7b7f97e8 7907 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7908 * buffer.c (Qclone_number): Remove for now, as it's unused.
7909 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7910 (record_buffer): Remove unused local.
7911 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7912 (set_frame_buffer_list): Remove; unused.
7913 * frame.h (other_visible_frames): Remove decl.
7914 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7915 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7916 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7917 if HAVE_GPM.
7918 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7919 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7920 Define only if HAVE_GPM.
7921 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7922 (update_hints_inhibit): Remove; never set. All uses removed.
7923 * widgetprv.h (emacsFrameClassRec): Remove decl.
7924 * window.c (delete_deletable_window): Now returns void, since it
7925 wasn't returning anything.
7926 (compare_window_configurations): Remove unused locals.
7927 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7928 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7929 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7930 the same widths as pointers. This follows up on the 2011-05-06 patch.
7931 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7932 * xterm.h: Likewise.
7933 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7934
1384b89e
JB
79352011-06-12 Juanma Barranquero <lekktu@gmail.com>
7936
7937 * makefile.w32-in: Update dependencies.
7938 (LISP_H): Add lib/intprops.h.
7939
1100a63c
CY
79402011-06-11 Chong Yidong <cyd@stupidchicken.com>
7941
7942 * image.c (gif_load): Add animation frame delay to the metadata.
7943 (syms_of_image): Use DEFSYM. New symbol `delay'.
7944
6198ccd0
MR
79452011-06-11 Martin Rudalics <rudalics@gmx.at>
7946
7947 * window.c (delete_deletable_window): Re-add.
7948 (Fset_window_configuration): Rewrite to handle dead buffers and
7949 consequently deletable windows.
7950 (window_tree, Fwindow_tree): Remove. Supply functionality in
7951 window.el.
7952 (compare_window_configurations): Simplify code.
7953
b6e3633c
AS
79542011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7955
1ab0dee5
AS
7956 * image.c (imagemagick_load_image): Fix type mismatch.
7957 (Fimagemagick_types): Likewise.
7958
b6e3633c
AS
7959 * window.h (replace_buffer_in_windows): Declare.
7960
9397e56f
MR
79612011-06-11 Martin Rudalics <rudalics@gmx.at>
7962
7963 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7964 Qclone_number. Remove external declaration of Qdelete_window.
7965 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7966 code.
640c8776
SM
7967 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7968 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7969 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7970 buffer list implementation.
7971 (other_buffer_safely): New function.
7972 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7973 calls to replace_buffer_in_windows and
7974 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7975 if allowed.
7976 (record_buffer): Inhibit quitting and rewrite using quittable
7977 functions. Run Qbuffer_list_update_hook if allowed.
7978 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7979 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7980 Move switch-to-buffer to window.el.
9397e56f
MR
7981 (bury-buffer): Move to window.el.
7982 (Vbuffer_list_update_hook): New variable.
7983
7984 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7985 section.
7986
7987 * window.h (resize_frame_windows): Move up in code.
7988 (Fwindow_frame): Remove EXFUN.
7989 (replace_buffer_in_all_windows): Remove prototype.
7990 (replace_buffer_in_windows_safely): Add prototype.
7991
7992 * window.c: Declare Qdelete_window static again. Move down
7993 declaration of select_count.
7994 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7995 (Fother_window): Move to window.el.
7996 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7997 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7998 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7999 window.el.
8000 (replace_buffer_in_windows): Implement by calling
8001 Qreplace_buffer_in_windows.
8002 (replace_buffer_in_all_windows): Remove with some functionality
8003 moved into replace_buffer_in_windows_safely.
8004 (replace_buffer_in_windows_safely): New function.
8005 (select_window_norecord, select_frame_norecord): Move in front
8006 of run_window_configuration_change_hook. Remove now obsolete
8007 declarations.
640c8776
SM
8008 (Fset_window_buffer): Rewrite doc-string.
8009 Call Qrecord_window_buffer.
9397e56f
MR
8010 (keys_of_window): Move binding for other-window to window.el.
8011
b50691aa
CY
80122011-06-11 Chong Yidong <cyd@stupidchicken.com>
8013
8014 * dispextern.h (struct image): Replace data member, whose int_val
8015 and ptr_val fields were not used by anything, with a single
8016 lisp_val object.
8017
8018 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8019 (gif_clear_image, gif_load, imagemagick_load_image)
8020 (gs_clear_image, gs_load): Callers changed.
8021
3f754b86
PE
80222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8023
cca69397
PE
8024 * buffer.h: Include <time.h>, for time_t.
8025 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8026
109e28d0
PE
8027 Fix minor problems found by static checking.
8028
60737f02
PE
8029 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8030
4b66faf3
PE
8031 Make identifiers static if they are not used in other modules.
8032 * data.c (Qcompiled_function, Qframe, Qvector):
8033 * image.c (QimageMagick, Qsvg):
8034 * minibuf.c (Qmetadata):
8035 * window.c (resize_window_check, resize_root_window): Now static.
8036 * window.h (resize_window_check, resize_root_window): Remove decls.
8037
109e28d0
PE
8038 * window.c (window_deletion_count, delete_deletable_window):
8039 Remove; unused.
46a4ce9e
PE
8040 (window_body_lines): Now static.
8041 (Fdelete_other_windows_internal): Mark vars as initialized.
8042 Make sure 'resize_failed' is initialized.
8043 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8044 (resize_window_apply): Remove unused local.
8045 * window.h (delete_deletable_window): Remove decl.
8046
109e28d0 8047 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8048 (imagemagick_load_image): Fix pointer signedness problem by changing
8049 last arg from unsigned char * to char *. All uses changed.
8050 Also, fix a local for similar reasons.
8051 Remove unused locals. Remove locals to avoid shadowing.
8052 (fn_rsvg_handle_free): Remove; unused.
8053 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8054 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8055
3f754b86
PE
8056 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8057
2547adb1
CY
80582011-06-10 Chong Yidong <cyd@stupidchicken.com>
8059
8060 * image.c (gif_load): Fix omitted cast error introduced by
8061 2011-06-06 change.
8062
2c8e37d4
MR
80632011-06-10 Martin Rudalics <rudalics@gmx.at>
8064
8065 * window.h (resize_proportionally, orig_total_lines)
8066 (orig_top_line): Remove from window structure.
8067 (set_window_height, set_window_width, change_window_heights)
8068 (Fdelete_window): Remove prototypes.
8069 (resize_frame_windows): Remove duplicate declaration.
8070
440a42e3
EZ
80712011-06-10 Eli Zaretskii <eliz@gnu.org>
8072
8073 * window.h (resize_frame_windows, resize_window_check)
8074 (delete_deletable_window, resize_root_window)
8075 (resize_frame_windows): Declare prototypes.
8076
8077 * window.c (resize_window_apply): Make definition be "static" to
8078 match the prototype.
8079
562dd5e9
MR
80802011-06-10 Martin Rudalics <rudalics@gmx.at>
8081
8082 * window.c: Remove declarations of Qwindow_size_fixed,
8083 window_min_size_1, window_min_size_2, window_min_size,
8084 size_window, window_fixed_size_p, enlarge_window, delete_window.
8085 Remove static from declaration of Qdelete_window, it's
8086 temporarily needed by Fbury_buffer.
8087 (replace_window): Don't assign orig_top_line and
8088 orig_total_lines.
8089 (Fdelete_window, delete_window): Remove. Window deletion is
8090 handled by window.el.
640c8776
SM
8091 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8092 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8093 (Fdelete_other_windows): Remove. Deleting other windows is
8094 handled by window.el.
8095 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8096 handled in window.el.
8097 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8098 Window minimum sizes are handled in window.el.
8099 (shrink_windows, size_window, set_window_height)
8100 (set_window_width, change_window_heights, window_height)
8101 (window_width, CURBEG, CURSIZE, enlarge_window)
8102 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8103 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8104 handled in window.el.
8105 (make_dummy_parent): Rename to make_parent_window and give it a
8106 second argument horflag.
8107 (make_window): Don't set resize_proportionally any more.
8108 (Fsplit_window): Remove. Windows are split in window.el.
8109 (save_restore_action, save_restore_orig_size)
8110 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8111 Resize mini windows in window.el.
8112 (grow_mini_window, shrink_mini_window): Implement by calling
8113 Qresize_root_window_vertically, resize_window_check and
8114 resize_window_apply.
640c8776
SM
8115 (saved_window, Fset_window_configuration, save_window_save):
8116 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8117 resize_proportionally.
8118 (window_min_height, window_min_width): Move to window.el.
8119 (keys_of_window): Move bindings for delete-other-windows,
8120 split-window, delete-window and enlarge-window to window.el.
8121
8122 * buffer.c: Temporarily extern Qdelete_window.
8123 (Fbury_buffer): Temporarily call Qdelete_window instead of
8124 Fdelete_window (Fbury_buffer will move to window.el soon).
8125
8126 * frame.c (set_menu_bar_lines_1): Remove code handling
8127 orig_top_line and orig_total_lines.
8128
8129 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8130 set_window_height but set heights directly.
8131 (change_frame_size_1): Use resize_frame_windows.
8132
8133 * xdisp.c (init_xdisp): Don't use set_window_height but set
8134 heights directly.
8135
640c8776
SM
8136 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8137 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8138 run_window_configuration_change_hook.
8139
8140 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8141 instead of change_window_heights and run
8142 run_window_configuration_change_hook.
8143
1a13852e
MR
81442011-06-09 Martin Rudalics <rudalics@gmx.at>
8145
8146 * window.c (replace_window): Rename second argument REPLACEMENT to
8147 NEW. New third argument SETFLAG. Rewrite.
8148 (delete_window, make_dummy_parent): Call replace_window with
8149 third argument 1.
8150 (window_list_1): Move down in code.
8151 (run_window_configuration_change_hook): Move set_buffer part
8152 before select_frame_norecord part in order to unwind correctly.
8153 Rename count1 to count.
8154 (recombine_windows, delete_deletable_window, resize_root_window)
8155 (Fdelete_other_windows_internal)
8156 (Frun_window_configuration_change_hook, make_parent_window)
8157 (resize_window_check, resize_window_apply, Fresize_window_apply)
8158 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8159 (Fdelete_window_internal, Fresize_mini_window_internal):
8160 New functions.
1a13852e
MR
8161 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8162
f3d1777e
MR
81632011-06-08 Martin Rudalics <rudalics@gmx.at>
8164
496e208e
MR
8165 * window.h (window): Add some new members to window structure -
8166 normal_lines, normal_cols, new_total, new_normal, clone_number,
8167 splits, nest, prev_buffers, next_buffers.
8168 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8169 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8170
f3d1777e
MR
8171 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8172 Remove.
496e208e
MR
8173 (make_dummy_parent): Set new members of windows structure.
8174 (make_window): Move down in code. Handle new members of window
8175 structure.
8176 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8177 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8178 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8179 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8180 (Fset_window_next_buffers, Fset_window_clone_number):
8181 New functions.
496e208e
MR
8182 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8183 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8184 Doc-string fixes.
8185 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8186 Argument WINDOW can be now internal window too.
8187 (Fwindow_use_time): Move up in code.
8188 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8189 Rewrite doc-string.
8190 (Fset_window_configuration, saved_window)
8191 (Fcurrent_window_configuration, save_window_save): Handle new
8192 members of window structure.
b9e809c2
MR
8193 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8194 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8195 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8196 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8197 Qget_mru_window, Qresize_root_window,
8198 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8199 Qauto_buffer_name; staticpro them.
f3d1777e 8200
abde8f8c
MR
82012011-06-07 Martin Rudalics <rudalics@gmx.at>
8202
8203 * window.c (Fwindow_total_size, Fwindow_left_column)
8204 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8205 (Fwindow_list_1): New functions.
8206 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8207 (Fwindow_width, Fscroll_left, Fscroll_right):
8208 Use window_body_cols instead of window_box_text_cols.
8209 (delete_window, Fset_window_configuration):
8210 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8211 (delete_all_subwindows): Take a window as argument and not a
8212 structure. Rewrite.
190b47e6
MR
8213 (window_loop): Remove handling of GET_LRU_WINDOW and
8214 GET_LARGEST_WINDOW.
8215 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8216
8217 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8218 window_box_text_cols. delete_all_subwindows now takes a
8219 Lisp_Object as argument.
abde8f8c 8220
640c8776
SM
8221 * indent.c (compute_motion, Fcompute_motion):
8222 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8223
fa8a67e6
MR
8224 * frame.c (delete_frame): Call delete_all_subwindows with root
8225 window as argument.
8226
a54e3482
DC
82272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8228
8229 * fns.c (Fputhash): Document return value.
8230
60002bf5
CY
82312011-06-06 Chong Yidong <cyd@stupidchicken.com>
8232
8233 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8234
0c671da6 82352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8236
b862a52a 8237 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8238
be44ca6c
PE
8239 Check for overflow when converting integer to cons and back.
8240 * charset.c (Fdefine_charset_internal, Fdecode_char):
8241 Use cons_to_unsigned to catch overflow.
8242 (Fencode_char): Use INTEGER_TO_CONS.
8243 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8244 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8245 * data.c (long_to_cons, cons_to_long): Remove.
8246 (cons_to_unsigned, cons_to_signed): New functions.
8247 These signal an error for invalid or out-of-range values.
8248 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8249 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8250 * font.c (Ffont_variation_glyphs):
8251 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8252 * lisp.h: Include <intprops.h>.
8253 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8254 (cons_to_signed, cons_to_unsigned): New decls.
8255 (long_to_cons, cons_to_long): Remove decls.
8256 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8257 (Fprimitive_undo): Use CONS_TO_INTEGER.
8258 * xfns.c (Fx_window_property): Likewise.
8259 * xselect.c: Include <limits.h>.
8260 (x_own_selection, selection_data_to_lisp_data):
8261 Use INTEGER_TO_CONS.
8262 (x_handle_selection_request, x_handle_selection_clear)
8263 (x_get_foreign_selection, Fx_disown_selection_internal)
8264 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8265 (lisp_data_to_selection_data): Use cons_to_unsigned.
8266 (x_fill_property_data): Use cons_to_signed.
8267 Report values out of range.
8268
d1f3d2af
PE
8269 Check for buffer and string overflow more precisely.
8270 * buffer.h (BUF_BYTES_MAX): New macro.
8271 * lisp.h (STRING_BYTES_MAX): New macro.
8272 * alloc.c (Fmake_string):
8273 * character.c (string_escape_byte8):
8274 * coding.c (coding_alloc_by_realloc):
8275 * doprnt.c (doprnt):
8276 * editfns.c (Fformat):
8277 * eval.c (verror):
8278 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8279 since they may not be the same number.
8280 * editfns.c (Finsert_char):
8281 * fileio.c (Finsert_file_contents):
8282 Likewise for BUF_BYTES_MAX.
8283
dd52fcea
PE
8284 * image.c: Use ptrdiff_t, not int, for sizes.
8285 (slurp_file): Switch from int to ptrdiff_t.
8286 All uses changed.
8287 (slurp_file): Check that file size fits in both size_t (for
8288 malloc) and ptrdiff_t (for sanity and safety).
8289
7f9bbdbb
PE
8290 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8291 if b->modtime has its maximal value.
8292
dfe18f82
PE
8293 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8294
84acfcf0
PE
8295 Don't assume time_t can fit into int.
8296 * buffer.h (struct buffer.modtime): Now time_t, not int.
8297 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8298 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8299
ccd9a01a
PE
8300 Minor fixes for signed vs unsigned integers.
8301 * character.h (MAYBE_UNIFY_CHAR):
8302 * charset.c (maybe_unify_char):
8303 * keyboard.c (read_char, reorder_modifiers):
8304 XINT -> XFASTINT, since the integer must be nonnegative.
8305 * ftfont.c (ftfont_spec_pattern):
8306 * keymap.c (access_keymap, silly_event_symbol_error):
8307 XUINT -> XFASTINT, since the integer must be nonnegative.
8308 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8309 since it makes no difference and we prefer signed.
8310 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8311 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8312 nonnegative.
8313
d6d100dd
SM
83142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8315
8316 * window.h (Fwindow_frame): Declare.
8317
2b6148e4
PE
83182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8319
8320 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8321 (SPARE_MEMORY): Always define.
8322 (LARGE_REQUEST): Remove.
8323 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8324
f230ecc9
MR
83252011-06-06 Martin Rudalics <rudalics@gmx.at>
8326
727e958e
MR
8327 * lisp.h: Move EXFUNS for Fframe_root_window,
8328 Fframe_first_window and Fset_frame_selected_window to window.h.
8329
8330 * window.h: Move EXFUNS for Fframe_root_window,
8331 Fframe_first_window and Fset_frame_selected_window here from
8332 lisp.h.
8333
8334 * frame.c (Fwindow_frame, Fframe_first_window)
8335 (Fframe_root_window, Fframe_selected_window)
8336 (Fset_frame_selected_window): Move to window.c.
8337 (Factive_minibuffer_window): Move to minibuf.c.
8338 (Fother_visible_frames_p): New function.
8339
8340 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8341
f230ecc9
MR
8342 * window.c (decode_window, decode_any_window): Move up in code.
8343 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8344 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8345 (Fwindow_buffer): Move up and rewrite doc-string.
8346 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8347 (Fwindow_prev): New functions.
727e958e
MR
8348 (Fwindow_frame): Move here from frame.c. Accept any window as
8349 argument.
8350 (Fframe_root_window, Fframe_first_window)
8351 (Fframe_selected_window): Move here from frame.c. Accept frame
8352 or arbitrary window as argument. Update doc-strings.
8353 (Fminibuffer_window): Move up in code.
8354 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8355 (Fset_frame_selected_window): Move here from frame.c.
8356 Marginal rewrite.
727e958e
MR
8357 (Fselected_window, select_window, Fselect_window): Move up in
8358 code. Minor doc-string fixes.
f230ecc9 8359
4d09bcf6
PE
83602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8361
8362 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8363 Do not assume that spare memory exists; that assumption is valid
8364 only if SYSTEM_MALLOC.
8365 (LARGE_REQUEST): New macro, so that the issue of large requests
8366 is separated from the issue of spare memory.
8367
810928a2
AS
83682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8369
172418ad
AS
8370 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8371 format. (Bug#8806)
8372
43f862f7
AS
8373 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8374
810928a2
AS
8375 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8376 before statements.
8377
a059fe24
JD
83782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8379
8380 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8381
8382 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8383
8384 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8385 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8386
989bf368
JB
83872011-06-05 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8390
4b80f674
CY
83912011-06-04 Chong Yidong <cyd@stupidchicken.com>
8392
8393 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8394 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8395 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8396 New error handlers.
4b80f674
CY
8397 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8398 Obey Vx_select_enable_clipboard_manager. Catch errors in
8399 x_clipboard_manager_save (Bug#8779).
8400 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8401 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8402
99a33b77 84032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8404
8405 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8406
99a33b77 84072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8408
8409 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8410 in the current matrix if keep_current_p is non-zero.
8411
8264569d
EZ
84122011-06-04 Eli Zaretskii <eliz@gnu.org>
8413
8414 * bidi.c (bidi_level_of_next_char): Fix last change.
8415
57f97249
EZ
84162011-06-03 Eli Zaretskii <eliz@gnu.org>
8417
fec2107c 8418 Support bidi reordering of text covered by display properties.
57f97249 8419
fec2107c
EZ
8420 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8421 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8422 (bidi_cache_search, bidi_cache_iterator_state)
8423 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8424 (bidi_level_of_next_char, bidi_move_to_visually_next):
8425 Support character positions inside a run of characters covered by a
fec2107c
EZ
8426 display string.
8427 (bidi_paragraph_init, bidi_resolve_explicit_1)
8428 (bidi_level_of_next_char): Call bidi_fetch_char and
8429 bidi_fetch_char_advance instead of FETCH_CHAR and
8430 FETCH_CHAR_ADVANCE.
8431 (bidi_init_it): Initialize new members.
8432 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8433 definitions.
8434 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8435 instead of using explicit *_CHAR codes.
d6d100dd
SM
8436 (bidi_resolve_explicit, bidi_resolve_weak):
8437 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8438 bidirectional text is supported only in multibyte buffers.
8439 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8440 it to initialize the frame_window_p member of struct bidi_it.
8441 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8442 (bidi_resolve_explicit, bidi_resolve_weak)
8443 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8444 bidi_it->nchars is non-positive.
8445 (bidi_level_of_next_char): Don't try to lookup the cache for the
8446 next/previous character if nothing is cached there yet, or if we
8447 were just reseat()'ed to a new position.
c40e2fb2 8448
0e14fe90
EZ
8449 * xdisp.c (set_cursor_from_row): Set start and stop points
8450 according to the row's direction when priming the loop that looks
8451 for the glyph on which to display cursor.
8452 (single_display_spec_intangible_p): Function deleted.
8453 (display_prop_intangible_p): Reimplement to call
8454 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8455 Accept 3 additional arguments needed by handle_display_spec.
8456 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8457 values: lists, `(when COND...)' forms, etc.
8458 (single_display_spec_string_p): Support property values that are
8459 lists with the argument STRING its top-level element.
8460 (display_prop_string_p): Fix the condition for processing a
8461 property that is a list to be consistent with handle_display_spec.
fec2107c 8462 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8463 last portion of handle_display_prop.
8464 (compute_display_string_pos): Accept additional argument
8465 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8466 value of a `display' property is a "replacing spec".
8467 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8468 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8469 the display property, but just return a value indicating whether
8470 the display property will replace the characters it covers.
8471 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8472 frame_window_p members of struct bidi_it.
d6d100dd
SM
8473 (compute_display_string_pos, compute_display_string_end):
8474 New functions.
fec2107c
EZ
8475 (push_it): Accept second argument POSITION, where pop_it should
8476 jump to continue iteration.
8477 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8478
fec2107c
EZ
8479 * keyboard.c (adjust_point_for_property): Adjust the call to
8480 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8481
8482 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8483 (bidi_init_it): Update prototypes.
8484 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8485 (compute_display_string_pos, compute_display_string_end):
8486 Declare prototypes.
fec2107c
EZ
8487 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8488 EMACS_INT.
fc6f18ce 8489
40087514 84902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8491
57f53182
PE
8492 Malloc failure behavior now depends on size of allocation.
8493 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8494 * lisp.h: Change signatures accordingly.
8495 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8496 All callers changed. (Bug#8762)
8497
8498 * gnutls.c: Use Emacs's memory allocators.
8499 Without this change, the gnutls library would invoke malloc etc.
8500 directly, which causes problems on non-SYNC_INPUT hosts, and which
8501 runs afoul of improving memory_full behavior. (Bug#8761)
8502 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8503 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8504 xfree instead of the default malloc, realloc, free.
8505 (Fgnutls_boot): No need to check for memory allocation failure,
8506 since xmalloc does that for us.
8507
ac32cd99 8508 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8509 * category.c (hash_get_category_set):
8510 * ccl.c (ccl_driver):
8511 * charset.c (Fdefine_charset_internal):
8512 * charset.h (struct charset.hash_index):
8513 * composite.c (get_composition_id, gstring_lookup_cache)
8514 (composition_gstring_put_cache):
8515 * composite.h (struct composition.hash_index):
8516 * dispextern.h (struct image.hash):
8517 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8518 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8519 (hashfn_equal, hashfn_user_defined, make_hash_table)
8520 (maybe_resize_hash_table, hash_lookup, hash_put)
8521 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8522 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8523 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8524 * image.c (make_image, search_image_cache, lookup_image)
8525 (xpm_put_color_table_h):
8526 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8527 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8528 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8529 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8530 * alloc.c (allocate_vectorlike):
8531 Check for overflow in vector size calculations.
8532 * ccl.c (ccl_driver):
8533 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8534 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8535 need to be updated by these changes.
40087514
PE
8536 * fns.c (make_hash_table, maybe_resize_hash_table):
8537 Check for integer overflow with large hash tables.
0de4bb68
PE
8538 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8539 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8540 (SXHASH_REDUCE): New macro.
8541 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8542 Use it instead of discarding useful hash info with large hash values.
8543 (sxhash_float): New function.
8544 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8545 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8546 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8547 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8548 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8549 Adjust signatures to match updated version of code.
8550 (consing_since_gc): Now EMACS_INT, since a single hash table can
8551 use more than INT_MAX bytes.
8552
698d32e2
DN
85532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8554
8555 Make it possible to build with GCC-4.6+ -O2 -flto.
8556
8557 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8558
fd6fa53f
SM
85592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8560
8561 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8562 Call minibuffer-inactive-mode.
8563
864db017
JB
85642011-05-31 Juanma Barranquero <lekktu@gmail.com>
8565
8566 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8567 Update dependencies.
8568
2ad0baf4
DN
85692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8570
8571 * data.c (init_data): Remove code for UTS, this system is not
8572 supported anymore.
8573
4fcc2638
DN
85742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8575
8576 Don't force ./temacs to start in terminal mode.
8577
8578 * frame.c (make_initial_frame): Initialize faces in all cases, not
8579 only when CANNOT_DUMP is defined.
8580 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8581
c56e0fd5
DN
85822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8583
8584 * dispnew.c (add_window_display_history): Use const for the string
8585 pointer. Remove declaration, not needed.
8586
333d54da 85872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8588
55d4c1b2 8589 Use 'inline', not 'INLINE'.
333d54da 8590 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8591 * alloc.c, fontset.c (INLINE): Remove.
8592 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8593 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8594 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8595 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8596 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8597
738db178
DN
85982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8599
8600 Make it possible to run ./temacs.
8601
8602 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8603 syms_of_callproc does the same thing. Remove test for
8604 "initialized", do it in the caller.
8605 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8606
620c53a6
SM
86072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8608
8609 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8610 (read_minibuf): Use get_minibuffer.
8611 (syms_of_minibuf): Use DEFSYM.
8612 (Qmetadata): New var.
8613 * data.c (Qbuffer): Don't make it static.
8614 (syms_of_data): Use DEFSYM.
8615
e003a292
PE
86162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8617
8618 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8619 (CCL_CODE_MIN): New macro.
8620
ed008a6d
PE
86212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8622
3687c2ef
PE
8623 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8624
ed008a6d
PE
8625 * eval.c (Qdebug): Now static.
8626 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8627 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8628 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8629
d66c4c7c
CY
86302011-05-29 Chong Yidong <cyd@stupidchicken.com>
8631
8632 * image.c: Various fixes to ImageMagick code comments.
8633 (Fimagemagick_types): Doc fix.
8634
5fbc2025
PE
86352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8636
0196f88a
PE
8637 Minor fixes prompted by GCC 4.6.0 warnings.
8638
8639 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8640
5fbc2025
PE
8641 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8642 (x_clipboard_manager_save_all): Move extern decl to ...
8643 * xterm.h: ... here, so that it can be checked for consistency.
8644
1dd3c2d9
CY
86452011-05-29 Chong Yidong <cyd@stupidchicken.com>
8646
8647 * xselect.c (x_clipboard_manager_save_frame)
8648 (x_clipboard_manager_save_all): New functions.
8649 (Fx_clipboard_manager_save): Lisp function deleted.
8650
8651 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8652 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8653
8654 * xterm.h: Update prototype.
8655
5ba6571d
WX
86562011-05-28 William Xu <william.xwl@gmail.com>
8657
8658 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8659 exiting (Bug#8239).
8660
3eaff834
JM
86612011-05-28 Jim Meyering <meyering@redhat.com>
8662
e1900994 8663 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8664 * fns.c (to_uchar): Define.
8665 (crypto_hash_function): Use it to convert some newly-signed
8666 variables to unsigned, to avoid sign-extension bugs. For example,
8667 without this change, (md5 "truc") would evaluate to
8668 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8669 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8670 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8671
0f6990a7
PE
86722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8673
8674 Integer overflow fixes.
c8a9ca5a 8675
08686060
PE
8676 * dbusbind.c: Serial number integer overflow fixes.
8677 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8678 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8679 to hold a serial number that is too large for a fixnum.
8680 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8681 Check for serial numbers out of range. Decode any serial number
59568bf0 8682 that was so large that it became a float. (Bug#8722)
08686060 8683
2d1fc3c7
PE
8684 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8685 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8686 Use XFASTINT rather than XUINT when numbers are nonnegative.
8687 (xd_append_arg, Fdbus_method_return_internal):
8688 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8689 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8690 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8691 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8692 (Bug#8722)
2d1fc3c7 8693
c8a9ca5a
PE
8694 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8695
519e1d69
PE
8696 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8697
6df6ae42 8698 ccl: Add integer overflow checks.
30569699
PE
8699 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8700 (IN_INT_RANGE): New macros.
8701 (ccl_driver): Use them to check for integer overflow when
8702 decoding a CCL program. Many of the new checks are whether XINT (x)
8703 fits in int; it doesn't always, on 64-bit hosts. The new version
8704 doesn't catch all possible integer overflows, but it's an
847044ea 8705 improvement. (Bug#8719)
30569699 8706
c11285dc
PE
8707 * alloc.c (make_event_array): Use XINT, not XUINT.
8708 There's no need for unsigned here.
8709
fdccd48e
PE
8710 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8711 This follows up to the 2011-05-06 change that substituted uintptr_t
8712 for EMACS_INT. This case wasn't caught back then.
8713
37910ab2
PE
8714 Rework Fformat to avoid integer overflow issues.
8715 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8716 now (part of C89). Include <verify.h>.
8717 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8718 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8719 (Fformat): Avoid the prepass trying to compute sizes; it was only
8720 approximate and thus did not catch overflow reliably. Instead, walk
8721 through the format just once, formatting and computing sizes as we go,
8722 checking for integer overflow at every step, and allocating a larger
8723 buffer as needed. Keep track separately whether the format is
8724 multibyte. Keep only the most-recently calculated precision, rather
8725 than them all. Record whether each argument has been converted to
8726 string. Use EMACS_INT, not int, for byte and char and arg counts.
8727 Support field widths and precisions larger than INT_MAX. Avoid
8728 sprintf's undefined behavior with conversion specifications such as %#d
8729 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8730 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8731 formatting out-of-range floating point numbers with int
9173deec 8732 formats. (Bug#8668)
37910ab2 8733
2e6578fb
PE
8734 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8735
0ae6bdee
PE
8736 * data.c: Avoid integer truncation in expressions involving floats.
8737 * data.c: Include <intprops.h>.
8738 (arith_driver): When there's an integer overflow in an expression
8739 involving floating point, convert the integers to floating point
8740 so that the resulting value does not suffer from catastrophic
8741 integer truncation. For example, on a 64-bit host (* 4
8742 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8743 Do not rely on undefined behavior after integer overflow.
8744
de883a70
PE
8745 merge count_size_as_multibyte, parse_str_to_multibyte
8746 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8747 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8748 Check for integer overflow.
8749 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8750 since it's now a duplicate of the other. This is more of
8751 a character than a buffer op, so better that it's in character.c.
8752 * fns.c, print.c: Adjust to above changes.
8753
2ff916cb
PE
87542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8755
8756 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8757
f1b54466
PE
87582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8759
fb1ac845
PE
8760 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8761 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8762 (x_clipboard_manager_save): Now static.
8763 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8764
f1b54466
PE
8765 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8766 (crypto_hash_function): Now static.
8767 Fix pointer signedness problems. Avoid unnecessary initializations.
8768
a9f737ee
CY
87692011-05-27 Chong Yidong <cyd@stupidchicken.com>
8770
8771 * termhooks.h (Vselection_alist): Make it terminal-local.
8772
8773 * terminal.c (create_terminal): Initialize it.
8774
8775 * xselect.c: Support for clipboard managers.
8776 (Vselection_alist): Move to termhooks.h as terminal-local var.
8777 (LOCAL_SELECTION): New macro.
8778 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8779 (symbol_to_x_atom): Remove gratuitous arg.
8780 (x_handle_selection_request, lisp_data_to_selection_data)
8781 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8782 (x_own_selection, x_get_local_selection, x_convert_selection):
8783 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8784 (some_frame_on_display): Delete unused function.
8785 (Fx_own_selection_internal, Fx_get_selection_internal)
8786 (Fx_disown_selection_internal, Fx_selection_owner_p)
8787 (Fx_selection_exists_p): New optional frame arg.
8788 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8789 (x_handle_selection_clear): Don't treat other terminals with the
8790 same keyboard specially. Use the terminal-local Vselection_alist.
8791 (x_clear_frame_selections): Use Frun_hook_with_args.
8792
8793 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8794
8795 * xterm.h: Add support for those atoms.
8796
e067f0c1
CY
87972011-05-26 Chong Yidong <cyd@stupidchicken.com>
8798
8799 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8800 (converted_selections, conversion_fail_tag): New global variables.
8801 (x_selection_request_lisp_error): Free the above.
8802 (x_get_local_selection): Remove unnecessary code.
8803 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8804 of converted selections stored in converted_selections.
8805 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8806 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8807 (x_convert_selection): New function.
8808 (x_handle_selection_event): Simplify.
8809 (x_get_foreign_selection): Don't ignore incoming requests while
8810 waiting for an answer; this will fail when we implement
8811 SAVE_TARGETS, and seems unnecessary anyway.
8812 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8813 (Vx_sent_selection_functions): Doc fix.
8814
0f4aebc0
LL
88152011-05-26 Leo Liu <sdl.web@gmail.com>
8816
8817 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8818
e61124cd
YM
88192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8820
8821 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8822
8823 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8824 for fringe update if it has periodic bitmap.
ac389d0c 8825 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8826 and fringe_bitmap_periodic_p.
8827
8828 * fringe.c (get_fringe_bitmap_data): New function.
8829 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8830 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8831 row. Mark glyph row for fringe update if periodicity changed.
8832
8833 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8834 for fringe update unless it has periodic bitmap.
8835
f16d9837
KH
88362011-05-25 Kenichi Handa <handa@m17n.org>
8837
8838 * xdisp.c (get_next_display_element): Set correct it->face_id for
8839 a static composition.
8840
e1b90ef6
LL
88412011-05-24 Leo Liu <sdl.web@gmail.com>
8842
8843 * deps.mk (fns.o):
8844 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8845
8846 * fns.c (crypto_hash_function, Fsha1): New function.
8847 (Fmd5): Use crypto_hash_function.
8848 (syms_of_fns): Add Ssha1.
8849
7400048f
PE
88502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8851
8852 * gnutls.c: Remove unused macros.
8853 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8854 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8855 Remove macros that are defined and never used.
8856 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8857
abb71cf4
CY
88582011-05-22 Chong Yidong <cyd@stupidchicken.com>
8859
8860 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8861 (Fx_get_selection_internal): Minor cleanup.
8862 (Fx_own_selection_internal): Rename arguments for consistency with
8863 select.el.
8864
6307db39
PE
88652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8866
8867 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8868
f3d4e0a4
CY
88692011-05-22 Chong Yidong <cyd@stupidchicken.com>
8870
8871 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8872
4d8ade89
YM
88732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8874
8875 * dispnew.c (scrolling_window): Don't exclude the case that the
8876 last enabled row in the desired matrix touches the bottom boundary.
8877
32078c8d
GM
88782011-05-21 Glenn Morris <rgm@gnu.org>
8879
8880 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8881 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8882 and add some more files.
32078c8d 8883
7285dc67
EZ
88842011-05-20 Eli Zaretskii <eliz@gnu.org>
8885
8886 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8887 report_file_error introduced by the change from 2011-05-07.
8888
89d1bd22
PE
88892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8890
8891 * systime.h (Time): Define only if emacs is defined.
8892 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8893 where the include path doesn't have X11/X.h by default. See
8894 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8895
cd394be1 88962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8897
8898 * composite.c (find_automatic_composition): Fix previous change.
8899
b9704ad9
GM
89002011-05-20 Glenn Morris <rgm@gnu.org>
8901
8902 * lisp.mk: New file, split from Makefile.in.
8903 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8904 (shortlisp): Remove.
8905 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8906
4a720484
GM
89072011-05-19 Glenn Morris <rgm@gnu.org>
8908
8909 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8910 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8911 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8912 (lisp): Set the order to that of loadup.el.
8913 (shortlisp): Make it a copy of $lisp.
8914 (SOME_MACHINE_LISP): Remove.
8915 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8916 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8917
a28d4396
KH
89182011-05-18 Kenichi Handa <handa@m17n.org>
8919
8920 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8921 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8922 (find_automatic_composition): Mostly rewrite for efficiency.
8923
a2b1fa8e
JB
89242011-05-18 Juanma Barranquero <lekktu@gmail.com>
8925
8926 * makefile.w32-in: Update dependencies.
8927
8e1f5610
CS
89282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8929
8930 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8931 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8932
7025ee00 89332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8934
cdfa6eab
PE
8935 Fix some integer overflow issues, such as string length overflow.
8936
06d6db33
PE
8937 * insdel.c (count_size_as_multibyte): Check for string overflow.
8938
2b4560a8
PE
8939 * character.c (lisp_string_width): Check for string overflow.
8940 Use EMACS_INT, not int, for string indexes and lengths; in
8941 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8942 the resulting string length overflows an EMACS_INT; instead,
8943 report a string overflow if no precision given. When checking for
8944 precision exhaustion, use a check that cannot possibly have
8945 integer overflow. (Bug#8675)
8946 * character.h (lisp_string_width): Adjust to new signature.
8947
cb93f9be
PE
8948 * alloc.c (string_overflow): New function.
8949 (Fmake_string): Use it. This doesn't change behavior, but saves
8950 a few bytes and will simplify future changes.
8951 * character.c (string_escape_byte8): Likewise.
8952 * lisp.h (string_overflow): New decl.
8953
1a1f3366
PE
8954 Fixups, following up to the user-interface timestamp change.
8955 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8956 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8957 * msdos.c (mouse_get_pos): Likewise.
8958 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8959 * w32gui.h (Time): Define by including "systime.h" rather than by
8960 declaring it ourselves. (Bug#8664)
8961
d4e3e4d3
PE
8962 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8963 * image.c (clear_image_cache): Likewise.
8964
f6a24d19
PE
8965 * term.c (term_mouse_position): Don't assume time_t wraparound.
8966
08dc5ae6
PE
8967 Be more systematic about user-interface timestamps.
8968 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8969 and sometimes 'EMACS_UINT', to represent these timestamps.
8970 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8971 This makes the code easier to follow, and makes it easier to catch
8972 integer overflow bugs such as Bug#8664.
8973 * frame.c (Fmouse_position, Fmouse_pixel_position):
8974 Use Time, not unsigned long, for user-interface timestamps.
8975 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8976 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8977 * keyboard.h (last_event_timestamp): Likewise.
8978 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8979 * menu.h (xmenu_show): Likewise.
8980 * term.c (term_mouse_position): Likewise.
8981 * termhooks.h (struct input_event.timestamp): Likewise.
8982 (struct terminal.mouse_position_hook): Likewise.
8983 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8984 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8985 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8986 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8987 what it was before.
8988 * menu.h, termhooks.h: Include "systime.h", for Time.
8989
8e55734a
PE
8990 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8991 Don't assume that the difference between two unsigned long values
8992 can fit into an integer. At this point, we know button_down_time
8993 <= event->timestamp, so the difference must be nonnegative, so
8994 there's no need to cast the result if double-click-time is
8995 nonnegative, as it should be; check that it's nonnegative, just in
8996 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8997 apart (about 25 days). (Bug#8664)
8e55734a 8998
841f1b75 8999 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9000 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9001
3e26f69c
PE
9002 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9003 that always fit in int. Use a sentinel instead of a counter, to
9004 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9005 * frame.h (struct frame): Use int for menu_bar_items_used
9006 instead of EMACS_INT, since it always fits in int.
3e26f69c 9007
5cc152c0
PE
9008 * menu.c (grow_menu_items): Check for int overflow.
9009
d89eb65e
PE
9010 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9011
5235bd3e
PE
9012 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9013 Before, the code was not consistent. These values cannot exceed
9014 2**31 - 1 so there's no need to make them unsigned.
9015 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9016 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9017 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9018 as modifiers.
9019 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9020
bc827e23
PE
9021 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9022 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9023 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9024 presumably because the widths might not match.
9025
78eb494e
PE
9026 * window.c (size_window): Avoid needless test at loop start.
9027
04f2d78b
CB
90282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9029
9030 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9031
d2fc7e3d 90322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9033
9034 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9035
d2fc7e3d 90362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9037
9038 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9039 `width' to `bar_area_x' and `bar_area_width', respectively.
9040 (x_scroll_run): Take account of fringe background extension.
9041
04f2d78b
CB
9042 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9043 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9044 `bar_area_width', respectively.
9045 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9046 background extension.
9047
79b70037
GM
90482011-05-10 Jim Meyering <meyering@redhat.com>
9049
9050 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9051
2f142cc5
JB
90522011-05-10 Juanma Barranquero <lekktu@gmail.com>
9053
9054 * image.c (Finit_image_library): Return t for built-in image types,
9055 like pbm and xbm. (Bug#8640)
9056
57679c86
AS
90572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9058
9059 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9060
888c9e86
EZ
90612011-05-07 Eli Zaretskii <eliz@gnu.org>
9062
b0512a1d
EZ
9063 * w32console.c (Fset_screen_color): Doc fix.
9064 (Fget_screen_color): New function.
9065 (syms_of_ntterm): Defsubr it.
9066
7285dc67
EZ
9067 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9068 unlink the temporary file if Fcall_process didn't create it in the
9069 first place.
9070 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9071 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9072 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9073 cue to call_process_cleanup not to close that handle.
9074
4d3fcc8e
BK
90752011-05-07 Ben Key <bkey76@gmail.com>
9076
9077 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9078 one of two shell specific rules, either bootstrap-temacs-CMD or
9079 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9080 to the previous implementation of the bootstrap-temacs rule.
9081 The bootstrap-temacs-CMD rule is similar to the previous
9082 implementation of the bootstrap-temacs rule except that it
9083 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9084 variable.
9085
9086 These changes, along with some changes to nt/configure.bat,
9087 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9088 earlier fix to add support for --cflags and --ldflags options
9089 that include quotes so that it works whether make uses cmd or
9090 sh as the shell.
9091
b4289b64
MA
90922011-05-06 Michael Albinus <michael.albinus@gmx.de>
9093
9094 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9095 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9096 is a constant.
9097 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9098 a string. Handle both cases.
9099 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9100 (Fdbus_register_method): Use Qinvalid_function.
9101
af4c0e28
JB
91022011-05-06 Juanma Barranquero <lekktu@gmail.com>
9103
9104 * makefile.w32-in: Update dependencies.
9105 (LISP_H): Add inttypes.h and stdin.h.
9106 (PROCESS_H): Add unistd.h.
9107
c51453d9
EZ
91082011-05-06 Eli Zaretskii <eliz@gnu.org>
9109
9110 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9111 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9112
8ff0ac3c 91132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9114
4c4b566b
PE
9115 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9116
aab2b9b5
PE
9117 * term.c (vfatal): Remove stray call to va_end.
9118 It's not needed and the C Standard doesn't allow it here anyway.
9119
c378da0b
PE
9120 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9121 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9122
288b08c7
PE
9123 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9124 bytes.
9125
e3601888
PE
9126 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9127
db6c0e74
PE
9128 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9129
dd5963ea
PE
9130 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9131
88c9450f
PE
9132 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9133
2f9442b8
PE
9134 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9135
c032b5f8
PE
9136 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9137 * charset.c (Fdefine_charset_internal): Don't initialize
9138 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9139 32-bit int (Bug#8600).
a108c10b
PE
9140
9141 * lread.c (read_integer): Be more consistent with string-to-number.
9142 Use string_to_number to do the actual conversion; this avoids
9143 rounding errors and fixes some other screwups. Without this fix,
9144 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9145 (digit_to_number): Move earlier, for benefit of read_integer.
9146 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9147 not a digit in any supported base. (Bug#8602)
a108c10b 9148
ad5f9eea
PE
9149 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9150
aec1708a
PE
9151 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9152 to match comment at start of function. This also removes a
9153 GCC warning about overflow in a 32+64-bit port.
9154
47be4ab5
PE
9155 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9156
371cac43
PE
9157 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9158 Reported by Stefan Monnier in
9159 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9160 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9161 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9162
d01a7826
PE
9163 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9164 (EMACS_UINTPTR): Likewise, with uintptr_t.
9165
7fd47d5c
PE
9166 * lisp.h: Prefer 64-bit EMACS_INT if available.
9167 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9168 on 32-bit hosts that have 64-bit int, so that they can access
9169 large files.
122b0c86
PE
9170 However, temporarily disable this change unless the temporary
9171 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9172
8727937b
PE
9173 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9174
8ac068ac
PE
9175 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9176 This removes an assumption that EMACS_INT and long are the same
9177 width as pointers. The assumption is true for Emacs porting targets
9178 now, but we want to make other targets possible.
9179 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9180 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9181 In the rest of the code, change types of integers that hold casted
9182 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9183 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9184 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9185 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9186 No need to cast type when ORing.
9187 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9188 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9189 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9190 assume EMACS_INT is the same width as char *.
9191 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9192 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9193 Remove no-longer-needed casts.
9194 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9195 (xg_tool_bar_help_callback, xg_make_tool_item):
9196 Use EMACS_INTPTR to hold an integer
9197 that will be cast to void *; this can avoid a GCC warning
9198 if EMACS_INT is not the same width as void *.
9199 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9200 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9201 (current_message_1, set_message_1):
9202 Use a local to convert to proper width without a cast.
9203 * xmenu.c (dialog_selection_callback): Likewise.
9204
ede49d71
PE
9205 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9206 Also, don't assume VALBITS / RAND_BITS is less than 5,
9207 and don't rely on undefined behavior when shifting a 1 left into
9208 the sign bit.
9209 * lisp.h (get_random): Change signature to match.
9210
2f30ecd0
PE
9211 * lread.c (hash_string): Use size_t, not int, for hash computation.
9212 Normally we prefer signed values; but hashing is special, because
9213 it's better to use unsigned division on hash table sizes so that
9214 the remainder is nonnegative. Also, size_t is the natural width
9215 for hashing into memory. The previous code used 'int', which doesn't
9216 retain enough info to hash well into very large tables.
9217 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9218
2a866e7b
PE
9219 * dbusbind.c: Don't possibly lose pointer info when converting.
9220 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9221 Use XPNTR rather than XHASH, so that the high-order bits of
9222 the pointer aren't lost when converting through void *.
9223
51639eac
PE
9224 * eval.c (Fautoload): Don't double-shift a pointer.
9225
92394119
PE
9226 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9227
dbdb9a7c
JB
92282011-05-06 Juanma Barranquero <lekktu@gmail.com>
9229
9230 * gnutls.c (DEF_GNUTLS_FN):
9231 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9232
db7a0b4f
AS
92332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9234
9235 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9236 marker. (Bug#8610)
9237
cd394be1 92382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9239
9240 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9241 New version that can reserve upto 2GB of heap space.
9242
f7ff1b0f 92432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9244
9245 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9246
639c109b
TZ
92472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9248
9249 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9250 `gnutls_certificate_set_x509_key_file'.
9251
d2127135
JB
92522011-05-05 Juanma Barranquero <lekktu@gmail.com>
9253
9254 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9255 Update dependencies.
9256
e968f4f3
JB
92572011-05-04 Juanma Barranquero <lekktu@gmail.com>
9258
9259 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9260 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9261 Remove unused parameter `fildes'.
9262 * process.c (read_process_output, send_process): Don't pass it.
9263
84d358f0
JB
92642011-05-04 Juanma Barranquero <lekktu@gmail.com>
9265
9266 Fix previous change: the library cache is defined in w32.c.
9267 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9268 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9269
0898ca10
JB
92702011-05-04 Juanma Barranquero <lekktu@gmail.com>
9271
9272 Implement dynamic loading of GnuTLS on Windows.
9273
9274 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9275 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9276 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9277 Declare.
9278
9279 * gnutls.c (Qgnutls_dll): Define.
9280 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9281 (gnutls_*): Declare function pointers.
9282 (init_gnutls_functions): New function to initialize function pointers.
9283 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9284 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9285 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9286 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9287 (emacs_gnutls_write, emacs_gnutls_read)
9288 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9289 (Fgnutls_available_p): New function.
9290 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9291 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9292 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9293
9294 * image.c: Include w32.h.
9295 (Vimage_type_cache): Delete.
9296 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9297 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9298 (w32_delayed_load): Move to w32.c.
9299
9300 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9301
9302 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9303 (w32_delayed_load): Move from image.c. When loading a library, record
9304 its filename in the :loaded-from property of the library id.
9305 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9306 Initialize and staticpro them.
9307 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9308
9309 * process.c: Include lisp.h before w32.h, not after.
9310 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9311 instead of gnutls_record_check_pending.
9312
9313 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9314
ff4de4aa
TZ
93152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9316
9317 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9318 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9319 as passed in.
9320
abe95abb
JD
93212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9322
9323 * xterm.c (x_set_frame_alpha): Do not set property on anything
9324 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9325
e16e55d4
JB
93262011-05-02 Juanma Barranquero <lekktu@gmail.com>
9327
9328 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9329
bafcf6a5
JB
93302011-05-02 Juanma Barranquero <lekktu@gmail.com>
9331
9332 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9333 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9334 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9335 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9336 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9337 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9338 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9339 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9340 (Qgnutls_bootprop_callbacks_verify): Make static.
9341
e7a6747f
AS
93422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9343
19ed11ba
AS
9344 * callproc.c: Indentation fixup.
9345
e7a6747f 9346 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9347 (wait_for_termination, interruptible_wait_for_termination):
9348 Move after wait_for_termination_1.
e7a6747f 9349
1ef14cb4
LMI
93502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9351
9352 * sysdep.c (interruptible_wait_for_termination): New function
9353 which is like wait_for_termination, but allows keyboard
9354 interruptions.
9355
9356 * callproc.c (Fcall_process): Add (:file "file") as an option for
9357 the STDOUT buffer.
9358 (Fcall_process_region): Ditto.
9359
330d880c
EZ
93602011-04-30 Eli Zaretskii <eliz@gnu.org>
9361
8db90b73
EZ
9362 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9363 rather than `XVECTOR (FOO)->size'.
9364
330d880c
EZ
9365 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9366 inttypes.h, as a gnulib replacement is used if it not available in
9367 system headers.
9368
15cbd324
EZ
93692011-04-21 Eli Zaretskii <eliz@gnu.org>
9370
9371 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9372 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9373 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9374
9375 * coding.c (coding_alloc_by_realloc): Error out if destination
9376 will grow beyond MOST_POSITIVE_FIXNUM.
9377 (decode_coding_emacs_mule): Abort if there isn't enough place in
9378 charbuf for the composition carryover bytes. Reserve an extra
9379 space for up to 2 characters produced in a loop.
9380 (decode_coding_iso_2022): Abort if there isn't enough place in
9381 charbuf for the composition carryover bytes.
9382
93832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9384
ae940cca
EZ
9385 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9386 aborting when %lld or %lll format is passed.
9387 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9388 %llo or %llx format is passed. (Bug#8545)
9389
03ab8921
EZ
9390 * window.c (window_scroll_line_based): Use a marker instead of
9391 simple variables to record original value of point. (Bug#7952)
9392
afda1437
EZ
9393 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9394 produced by %s or %c overflows available buffer space. (Bug#8545)
9395
f76dee0c
PE
93962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9397
9398 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9399 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9400
fdc5744d
JB
94012011-04-28 Juanma Barranquero <lekktu@gmail.com>
9402
9403 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9404
638f053a
JB
94052011-04-28 Juanma Barranquero <lekktu@gmail.com>
9406
9407 * keyboard.c (Qdelayed_warnings_hook): Define.
9408 (command_loop_1): Run `delayed-warnings-hook'
9409 if Vdelayed_warnings_list is non-nil.
9410 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9411 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9412
d178f871
EZ
94132011-04-28 Eli Zaretskii <eliz@gnu.org>
9414
9415 * doprnt.c (doprnt): Don't return value smaller than the buffer
9416 size if the message was truncated. (Bug#8545).
9417
b124fd93
JB
94182011-04-28 Juanma Barranquero <lekktu@gmail.com>
9419
9420 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9421 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9422
e810457d
PE
94232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9424
9425 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9426
ea51cceb
JB
94272011-04-27 Juanma Barranquero <lekktu@gmail.com>
9428
9429 * makefile.w32-in: Update dependencies.
9430
94dcfacf
EZ
94312011-04-27 Eli Zaretskii <eliz@gnu.org>
9432
9433 Improve `doprnt' and its usage. (Bug#8545)
9434 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9435 `format_end'. Remove support for %l as a conversion specifier.
9436 Don't use xrealloc. Improve diagnostics when the %l size modifier
9437 is used. Update the commentary.
9438
9439 * eval.c (verror): Simplify calculation of size_t.
9440
9441 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9442 messages.
9443
f61f41d7
PE
94442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9445
9446 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9447 change.
9448
96fb4434
PE
94492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9450
9451 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9452 This makes this file independent of the recent pseudovector change.
9453
671875da 94542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9455
69e9b5a3
PE
9456 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9457
b5f869a7 9458 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9459 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9460 Remove unused local.
c8926152 9461 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9462
841a1577 9463 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9464 GCC 4.6.0 optimizes based on type-based alias analysis.
9465 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9466 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9467 != &v->size, and therefore "v->size = 1; b->size = 2; return
9468 v->size;" must therefore return 1. This assumption is incorrect
9469 for Emacs, since it type-puns struct Lisp_Vector * with many other
9470 types. To fix this problem, this patch adds a new type struct
f904488f 9471 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9472 and pseudovectors, and helps optimizing compilers not get fooled
9473 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9474 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9475 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9476 the size member.
eab3844f
PE
9477 (XSETPVECTYPE): Rewrite in terms of new macro.
9478 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9479 This is a bit clearer, and further avoids the possibility of
9480 undesirable aliasing.
9481 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9482 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9483 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9484 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9485 (ASIZE): Now uses header.size rather than size.
9486 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9487 to avoid the hassle of writing XVECTOR (foo)->header.size.
9488 (struct vectorlike_header): New type.
eab3844f
PE
9489 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9490 object, to help avoid aliasing.
9491 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9492 (SUBRP): Likewise, since Lisp_Subr is a special case.
9493 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9494 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9495 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9496 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9497 changed to be "header.size" and "header.next".
9498 * buffer.h (struct buffer): Likewise.
9499 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9500 * frame.h (struct frame): Likewise.
9501 * process.h (struct Lisp_Process): Likewise.
9502 * termhooks.h (struct terminal): Likewise.
9503 * window.c (struct save_window_data, struct saved_window): Likewise.
9504 * window.h (struct window): Likewise.
9505 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9506 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9507 * buffer.c (init_buffer_once): Likewise.
9508 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9509 special case.
9510 * process.c (Fformat_network_address): Use local var for size,
9511 for brevity.
9512
0df1eac5
PE
9513 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9514
847ab9d1 9515 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9516 * data.c (atof): Remove decl; no longer used or needed.
9517 (digit_to_number): Move to lread.c.
9518 (Fstring_to_number): Use new string_to_number function, to be
9519 consistent with how the Lisp reader treats infinities and NaNs.
9520 Do not assume that floating-point numbers represent EMACS_INT
9521 without losing information; this is not true on most 64-bit hosts.
9522 Avoid double-rounding errors, by insisting on integers when
9523 parsing non-base-10 numbers, as the documentation specifies.
9524 * lisp.h (string_to_number): New decl, replacing ...
9525 (isfloat_string): Remove.
bc0a5c13 9526 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9527 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9528 appears to have been a coding error. Similarly, do not accept
9529 strings like +-1e0 as floating point numbers. Do not report
9530 overflow for integer overflows unless the base is not 10 which
9531 means we have no simple and reliable way to continue.
9532 Break out the floating-point parsing into a new
9533 function string_to_number, so that Fstring_to_number parses
9534 floating point numbers consistently with the Lisp reader.
04f2d78b 9535 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9536 (E_CHAR, EXP_INT): Remove, replacing with ...
9537 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9538 (string_to_number): New function, replacing isfloat_string.
9539 This function checks for valid syntax and produces the resulting
9540 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9541 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9542 so that overflow for non-base-10 numbers is reported only when
9543 there's no portable and simple way to convert to floating point.
452f4150 9544
67769ffc
PE
9545 * textprop.c (set_text_properties_1): Rewrite for clarity,
9546 and to avoid GCC warning about integer overflow.
9547
c20db43f
PE
9548 * intervals.h (struct interval): Use EMACS_INT for members
9549 where EMACS_UINT might cause problems. See
9550 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9551 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9552 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9553 All uses changed.
37aa2f85
PE
9554 (offset_intervals): Tell GCC not to worry about length overflow
9555 when negating a negative length.
c20db43f 9556
2538aa2f
PE
9557 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9558 (overrun_check_free): Likewise.
9559
f2d3008d
PE
9560 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9561 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9562 word size.
9563
ec8df744
PE
9564 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9565 (gnutls_make_error): Rename local to avoid shadowing.
9566 (gnutls_emacs_global_deinit): ifdef out; not used.
9567 (Fgnutls_boot): Use const for pointer to readonly storage.
9568 Comment out unused local. Fix pointer signedness problems.
9569
640ee02d
PE
9570 * lread.c (openp): Don't stuff size_t into an 'int'.
9571 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9572 about possible signed overflow.
9573
6048fb2a
PE
9574 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9575 (GDK_KEY_g): Don't define if already defined.
9576 (xg_prepare_tooltip): Avoid pointer signedness problem.
9577 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9578
fa3c87e1
PE
9579 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9580 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9581
2172544b
PE
9582 * xfns.c (Fx_window_property): Simplify a bit,
9583 to make a bit faster and to avoid GCC 4.6.0 warning.
9584 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9585
9b821a21
PE
9586 * fns.c (internal_equal): Don't assume size_t fits in int.
9587
3c616cfa
PE
9588 * alloc.c (compact_small_strings): Tighten assertion a little.
9589
c2982e87
PE
9590 Replace pEd with more-general pI, and fix some printf arg casts.
9591 * lisp.h (pI): New macro, generalizing old pEd macro to other
9592 conversion specifiers. For example, use "...%"pI"d..." rather
9593 than "...%"pEd"...".
9594 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9595 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9596 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9597 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9598 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9599 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9600 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9601 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9602 64-bit hosts.
9603 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9604 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9605 * print.c (safe_debug_print, print_object): Likewise.
9606 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9607 to int.
6f04d126
PE
9608 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9609 avoiding the 0 flag, which is not portable.
c2982e87
PE
9610 * process.c (Fmake_network_process): Use pI to avoid cast.
9611 * region-cache.c (pp_cache): Likewise.
9612 * xdisp.c (decode_mode_spec): Likewise.
9613 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9614 behavior on 64-bit hosts with printf arg.
6f04d126 9615 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9616 (x_stop_queuing_selection_requests): Likewise.
9617 (x_get_window_property): Don't truncate byte count to an 'int'
9618 when tracing.
0b432f21 9619
5e073ec7
PE
9620 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9621 here, since it parses constructs like leading '-' and spaces,
9622 which are not wanted; and it overflows with large numbers.
9623 Instead, simply match F[0-9]+, which is what is wanted anyway.
9624
36372bf9
PE
9625 * alloc.c: Remove unportable assumptions about struct layout.
9626 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9627 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9628 (allocate_vectorlike, make_pure_vector): Use the new macros,
9629 plus offsetof, to remove unportable assumptions about struct layout.
9630 These assumptions hold on all porting targets that I know of, but
9631 they are not guaranteed, they're easy to remove, and removing them
9632 makes further changes easier.
9633
0b432f21
PE
9634 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9635 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9636 (string_overrun_cookie): Now const. Use initializers that
9637 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9638 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9639 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9640 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9641 multiple of sizeof (EMACS_INT); it need not be, if
9642 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9643 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9644
895009e1
JB
96452011-04-26 Juanma Barranquero <lekktu@gmail.com>
9646
9647 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9648
6a7a1b0b
TZ
96492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9650
9651 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9652 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9653 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9654
841a1577 96552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9656
9657 * lisp.h (Qdebug): List symbol.
895009e1 9658 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9659 * keyboard.c (debug-on-event): New variable.
9660 (handle_user_signal): Break into debugger when debug-on-event
9661 matches the current signal symbol.
9662
f2d3ba6f
DN
96632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9664
9665 * alloc.c (check_sblock, check_string_bytes)
9666 (check_string_free_list): Convert to standard C.
9667
42ce4c63
TZ
96682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9669
9670 * w32.c (emacs_gnutls_push): Fix typo.
9671
825cd63c
EZ
96722011-04-25 Eli Zaretskii <eliz@gnu.org>
9673
fb11d64d
EZ
9674 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9675 "cast to pointer from integer of different size".
9676
825cd63c
EZ
9677 Improve doprnt and its use in verror. (Bug#8545)
9678 * doprnt.c (doprnt): Document the set of format control sequences
9679 supported by the function. Use SAFE_ALLOCA instead of always
9680 using `alloca'.
9681
9682 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9683 is one byte too soon. Don't use xrealloc; instead xfree and
9684 xmalloc anew.
9685
e061a11b
TZ
96862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9687
9688 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9689 callbacks stage.
9690
9691 * gnutls.c: Renamed global_initialized to
9692 gnutls_global_initialized. Added internals for the
9693 :verify-hostname-error, :verify-error, and :verify-flags
9694 parameters of `gnutls-boot' and documented those parameters in the
9695 docstring. Start callback support.
9173deec
JB
9696 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9697 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9698 on error. Return error code.
e061a11b
TZ
9699 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9700 (emacs_gnutls_read): Likewise.
9701 (Fgnutls_boot): Return handshake error code.
9702 (emacs_gnutls_handle_error): New function.
9703 (wsaerror_to_errno): Likewise.
9704
9705 * w32.h (emacs_gnutls_pull): Add prototype.
9706 (emacs_gnutls_push): Likewise.
9707
9708 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9709 (emacs_gnutls_push): Likewise.
9710
97112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9712
9713 * process.c (wait_reading_process_output): Check if GnuTLS
9714 buffered some data internally if no FDs are set for TLS
9715 connections.
9716
9717 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9718 (LIBS): Link to USER_LIBS.
9719 ($(BLD)/gnutls.$(0)): New target.
9720
fa6996bc
EZ
97212011-04-24 Eli Zaretskii <eliz@gnu.org>
9722
eb35682e
EZ
9723 * xdisp.c (handle_single_display_spec): Rename the
9724 display_replaced_before_p argument into display_replaced_p, to
9725 make it consistent with the commentary. Fix typos in the
9726 commentary.
9727
e2ad650c
EZ
9728 * textprop.c (syms_of_textprop): Remove dead code.
9729 (copy_text_properties): Delete obsolete commentary about an
9730 interface that was deleted long ago. Fix typos in the description
9731 of arguments.
9732
1b2de274
EZ
9733 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9734 to changes in oldXMenu/XMenu.h from 2011-04-16.
9735 <menu_help_message, prev_menu_help_message>: Constify.
9736 (IT_menu_make_room): menu->help_text is now `const char **';
9737 adjust.
9738
9739 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9740 to changes in oldXMenu/XMenu.h from 2011-04-16.
9741 (struct XMenu): Declare `help_text' `const char **'.
9742
9743 * xfaces.c <Qunspecified>: Make extern again.
9744
9745 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9746 required by POSIX.
1b2de274 9747
762b15be
EZ
9748 * doc.c (get_doc_string): Improve the format passed to `error'.
9749
9750 * doprnt.c (doprnt): Improve commentary.
9751
9752 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9753
9754 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9755 them with etags.
9756
f1052e5d
EZ
9757 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9758 changes in globals.h immediately force recompilation.
762b15be
EZ
9759 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9760 $(CURDIR)/s/ms-w32.h.
9761 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9762
fa6996bc
EZ
9763 * character.c (Fchar_direction): Function deleted.
9764 (syms_of_character): Don't defsubr it.
9765 <char-direction-table>: Deleted.
9766
e6c3da20
EZ
97672011-04-23 Eli Zaretskii <eliz@gnu.org>
9768
9769 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9770 * doprnt.c: Include limits.h.
9771 (SIZE_MAX): New macro.
04f2d78b
CB
9772 (doprnt): Return a size_t value. 2nd arg is now size_t.
9773 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9774 Improve overflow protection. Support `l' modifier for integer
9775 conversions. Support %l conversion. Don't assume an EMACS_INT
9776 argument for integer conversions and for %c.
9777
9778 * lisp.h (doprnt): Restore prototype.
9779
9780 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9781 $(SRC)/character.h.
9782
9783 * Makefile.in (base_obj): Add back doprnt.o.
9784
9785 * deps.mk (doprnt.o): Add back prerequisites.
9786 (callint.o): Depend on character.h.
9787
9788 * eval.c (internal_lisp_condition_case): Include the handler
9789 representation in the error message.
9790 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9791 when breaking from the loop.
9792
9793 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9794
9795 * callint.c (Fcall_interactively): When displaying error message
9796 about invalid control letter, pass the character's codepoint, not
9797 a pointer to its multibyte form. Improve display of the character
9798 in octal and display also its hex code.
9799
9800 * character.c (char_string): Use %x to display the (unsigned)
9801 codepoint of an invalid character, to avoid displaying a bogus
9802 negative value.
9803
9804 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9805 `error', not SYMBOL_NAME itself.
9806
9807 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9808 character arguments to `error'.
9809
9810 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9811 to `error' in error message about FINAL_CHAR argument. Make sure
9812 FINAL_CHAR is a character, and use %c when it is passed as
9813 argument to `error'.
9814
4ffd0d6b 98152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9816
9817 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9818
9819 * w32.c: Include <time.h>.
9820 (sys_localtime): New function.
9821
4ffd0d6b 98222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9823
9824 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9825
4ffd0d6b 9826 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9827
4ffd0d6b 98282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9829
4ffd0d6b
GM
9830 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9831 zombies (Bug#8467).
aac0c6e3 9832
04c56954
EZ
98332011-04-19 Eli Zaretskii <eliz@gnu.org>
9834
9835 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9836 gl_state.e_property when gl_state.object is Qt.
9837
9838 * insdel.c (make_gap_larger): Remove limitation of buffer size
9839 to <= INT_MAX.
9840
16a43933
CY
98412011-04-18 Chong Yidong <cyd@stupidchicken.com>
9842
9843 * xdisp.c (lookup_glyphless_char_display)
9844 (produce_glyphless_glyph): Handle cons cell entry in
9845 glyphless-char-display.
9846 (Vglyphless_char_display): Document it.
9847
9848 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9849 glyphless-char-display.
9850
4581706e
CY
98512011-04-17 Chong Yidong <cyd@stupidchicken.com>
9852
9853 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9854
9855 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9856
9857 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9858 definition for no-X builds.
9859
4887c6e2 98602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9861
fd35b6f9
PE
9862 Static checks with GCC 4.6.0 and non-default toolkits.
9863
5c1ccb01
PE
9864 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9865
006c5daa
PE
9866 * process.c (keyboard_bit_set): Define only if SIGIO.
9867 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9868 (send_process): Repair possible setjmp clobbering.
9869
efc736d3
PE
9870 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9871
4e2fe2e6
PE
9872 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9873
f97334a2
PE
9874 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9875
4e75f29d
PE
9876 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9877 Define only if needed.
9878
90efadd1
PE
9879 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9880 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9881 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9882
3c647824
PE
9883 * dispextern.h (struct redisplay_interface): Rename param
9884 to avoid shadowing.
e264f262 9885 * termhooks.h (struct terminal): Likewise.
761383f4 9886 * xterm.c (xembed_send_message): Likewise.
3c647824 9887
b58c5c4a
PE
9888 * insdel.c (make_gap_smaller): Define only if
9889 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9890
cad59032
PE
9891 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9892 it.
9893
c339dc2e
PE
9894 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9895 so that we aren't warned about unused symbols.
9896
91a3e27b
PE
9897 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9898
399c71d3 9899 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9900
8ffc96f5
PE
9901 * xfns.c (x_real_positions): Mark locals as initialized.
9902
eef9bc79
PE
9903 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9904
098db9dd
PE
9905 * xterm.c: Fix problems found by static analysis with other toolkits.
9906 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9907 (x_dispatch_event): Declare static if USE_GTK, and
9908 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9909 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9910 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9911 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9912 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9913
eb18f6cc
PE
9914 * xmenu.c (menu_help_callback): Pointer type fixes.
9915 Use const pointers when pointing at readonly data. Avoid pointer
9916 signedness clashes.
9917 (FALSE): Remove unused macro.
9918 (update_frame_menubar): Remove unused decl.
9919
1fe72bf8
PE
9920 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9921
60d9e1db
PE
9922 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9923 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9924 (single_menu_item): Rename local to avoid shadowing.
9925
39261c26
PE
9926 * keyboard.c (make_lispy_event): Remove unused local var.
9927
018c5e19
PE
9928 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9929 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9930
63d2b86e
PE
9931 * bitmaps: Change bitmaps from unsigned char back to the X11
9932 compatible char. Avoid the old compiler warnings about
9933 out-of-range initializers by using, for example, '\xab' rather
9934 than 0xab.
9935
aefd87e1
PE
9936 * xgselect.c (xgselect_initialize): Check vs interface
9937 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9938
bf501fb9
PE
9939 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9940
e9829fdf
PE
9941 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9942 to read-only memory.
9943
1086c095
PE
9944 * fns.c (vector): Remove; this old hack is no longer needed.
9945
2baccd04 9946 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9947 Remove unused var.
dde42981 9948 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9949
72391843 9950 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9951
436c16df 9952 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9953 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9954 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9955
92bb796d 9956 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9957 (x_term_init): Remove local to avoid shadowing.
92bb796d 9958
764430a3 9959 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9960
9961 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9962 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9963
d1dfb56c
EZ
99642011-04-16 Eli Zaretskii <eliz@gnu.org>
9965
c4354cb4
EZ
9966 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9967
d1dfb56c
EZ
9968 Fix regex.c, syntax.c and friends for buffers > 2GB.
9969 * syntax.h (struct gl_state_s): Declare character position members
9970 EMACS_INT.
9971
9972 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9973
04f2d78b
CB
9974 * textprop.c (verify_interval_modification, interval_of):
9975 Declare arguments EMACS_INT.
d1dfb56c
EZ
9976
9977 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9978 EMACS_INT.
9979
9980 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9981
9982 * indent.c (Fvertical_motion): Local variable it_start is now
9983 EMACS_INT.
9984
9985 * regex.c (re_match, re_match_2, re_match_2_internal)
9986 (bcmp_translate, regcomp, regexec, print_double_string)
9987 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9988 (re_compile_pattern, re_exec): Declare arguments and local
9989 variables `size_t' and `ssize_t' and return values `regoff_t', as
9990 appropriate.
9991 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9992 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9993 <compile_stack_type>: `size' and `avail' are now `size_t'.
9994
9995 * regex.h <regoff_t>: Use ssize_t, not int.
9996 (re_search, re_search_2, re_match, re_match_2): Arguments that
9997 specify buffer/string position and length are now ssize_t and
9998 size_t. Return type is regoff_t.
9999
613052cd
BK
100002011-04-16 Ben Key <bkey76@gmail.com>
10001
10002 * nsfont.m: Fixed bugs in ns_get_family and
10003 ns_descriptor_to_entity that were caused by using free to
10004 deallocate memory blocks that were allocated by xmalloc (via
10005 xstrdup). This caused Emacs to crash when compiled with
10006 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10007 --enable-checking=xmallocoverrun). xfree is now used to
10008 deallocate these memory blocks.
10009
4170f62f 100102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10011
71b41406
PE
10012 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10013
9587a89d
PE
10014 emacs_write: Accept and return EMACS_INT for sizes.
10015 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10016 et seq.
10017 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10018 Accept and return EMACS_INT.
10019 (emacs_gnutls_write): Return the number of bytes written on
10020 partial writes.
10021 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10022 (emacs_read, emacs_write): Remove check for negative size, as the
10023 Emacs source code has been audited now.
9587a89d
PE
10024 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10025 (emacs_read, emacs_write): Use it.
273a5f82
PE
10026 * process.c (send_process): Adjust to the new signatures of
10027 emacs_write and emacs_gnutls_write. Do not attempt to store
10028 a byte offset into an 'int'; it might overflow.
9587a89d 10029 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10030
3e047f51
PE
10031 * sound.c: Don't assume sizes fit in 'int'.
10032 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10033 Return EMACS_INT, not int.
3e047f51 10034 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10035 Accept EMACS_INT, not int.
10036 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10037 record read return values.
10038
cc39a9db
BK
100392011-04-15 Ben Key <bkey76@gmail.com>
10040
c9d0ec6d
JB
10041 * keyboard.c (Qundefined): Don't declare static since it is used
10042 in nsfns.m.
10043 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10044 static since they are used in nsfont.m.
cc39a9db 10045
6c60eb9f
SM
100462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10047
10048 * process.c (Qprocessp): Don't declare static.
10049 * lisp.h (Qprocessp): Declare again.
10050
7990b61a
JB
100512011-04-15 Juanma Barranquero <lekktu@gmail.com>
10052
10053 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10054
5d4cb038
PE
100552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10056
8bd7b830 10057 Improve C-level modularity by making more things 'static'.
cd64ea1d 10058
e3b27b31
PE
10059 Don't publish debugger-only interfaces to other modules.
10060 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10061 (verify_bytepos, count_markers): Move decls to the only modules
10062 that need them.
10063 * region-cache.h (pp_cache): Likewise.
10064 * window.h (check_all_windows): Likewise.
10065 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10066
5d4cb038
PE
10067 * sysdep.c (croak): Now static, if
10068 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10069 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10070
10071 * alloc.c (refill_memory_reserve): Now static if
10072 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10073 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10074
e87b6180
PE
10075 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10076 Define only if USE_LUCID.
10077
ac64929e
PE
10078 * xrdb.c (x_customization_string, x_rm_string): Now static.
10079
6f37259d
PE
10080 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10081 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10082
1683e3ab
PE
10083 * xdisp.c (draw_row_with_mouse_face): Now static.
10084 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10085
de9c2632
PE
10086 * window.h (check_all_windows): Mark externally visible.
10087
2b96acb7
PE
10088 * window.c (window_deletion_count): Now static.
10089
10090 * undo.c: Make symbols static if they're not exported.
10091 (last_undo_buffer, last_boundary_position, pending_boundary):
10092 Now static.
10093
50436f33
PE
10094 * textprop.c (interval_insert_behind_hooks): Now static.
10095 (interval_insert_in_front_hooks): Likewise.
10096
64520e5c
PE
10097 * term.c: Make symbols static if they're not exported.
10098 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10099 (max_frame_lines, tty_set_terminal_modes):
10100 (tty_reset_terminal_modes, tty_turn_off_highlight):
10101 (get_tty_terminal): Now static.
10102 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10103 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10104 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10105 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10106 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10107
1fa53021
PE
10108 * sysdep.c: Make symbols static if they're not exported.
10109 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10110 Now static.
10111 (sigprocmask_set, full_mask): Remove; unused.
10112 (wait_debugging): Mark as visible.
10113 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10114 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10115
d4b43b22
PE
10116 * syntax.c (syntax_temp): Define only if !__GNUC__.
10117
b7c513d0
PE
10118 * sound.c (current_sound_device, current_sound): Now static.
10119
989b29ad
PE
10120 * search.c (searchbufs, searchbuf_head): Now static.
10121
13a55a78
PE
10122 * scroll.c (scroll_cost): Remove; unused.
10123 * dispextern.h (scroll_cost): Remove decl.
10124
de68a1fc
PE
10125 * region-cache.h (pp_cache): Mark as externally visible.
10126
40ccffa6
PE
10127 * process.c: Make symbols static if they're not exported.
10128 (process_tick, update_tick, create_process, chan_process):
10129 (Vprocess_alist, proc_buffered_char, datagram_access):
10130 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10131 (deactivate_process): Mark defn as static, as well as decl.
10132 * lisp.h (create_process): Remove decl.
10133 * process.h (chan_process, Vprocess_alist): Remove decls.
10134
ad64fc97
PE
10135 * print.c: Make symbols static if they're not exported.
10136 (print_depth, new_backquote_output, being_printed, print_buffer):
10137 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10138 (print_interval, print_number_index, initial_stderr_stream):
10139 Now static.
10140 * lisp.h (Fprinc): Remove decl.
10141 (debug_output_compilation_hack): Mark as externally visible.
10142
adddb265
PE
10143 * sysdep.c (croak): Move decl from here to syssignal.h.
10144 * syssignal.h (croak): Put it here, so the API can be checked when
10145 'croak' is called from dissociate_if_controlling_tty.
10146
1717ede2
PE
10147 * minibuf.c: Make symbols static if they're not exported.
10148 (minibuf_save_list, choose_minibuf_frame): Now static.
10149 * lisp.h (choose_minibuf_frame): Remove decl.
10150
fa5fb2bc
PE
10151 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10152
1e3890d1
PE
10153 * lread.c: Make symbols static if they're not exported.
10154 (read_objects, initial_obarray, oblookup_last_bucket_number):
10155 Now static.
10156 (make_symbol): Remove; unused.
10157 * lisp.h (initial_obarray, make_symbol): Remove decls.
10158
8a1414fa
PE
10159 * keyboard.c: Make symbols static if they're not exported.
10160 (single_kboard, recent_keys_index, total_keys, recent_keys):
10161 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10162 (this_single_command_key_start, echoing, last_auto_save):
10163 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10164 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10165 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10166 (Vlispy_mouse_stem, double_click_count):
10167 Now static.
10168 (force_auto_save_soon): Define only if SIGDANGER.
10169 (ignore_mouse_drag_p): Now static if
10170 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10171 (print_help): Remove; unused.
10172 (stop_character, last_timer_event): Mark as externally visible.
10173 * keyboard.h (ignore_mouse_drag_p): Declare only if
10174 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10175 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10176 * lisp.h (echoing): Remove decl.
10177 (force_auto_save_soon): Declare only if SIGDANGER.
10178 * xdisp.c (redisplay_window): Simplify code, to make it more
10179 obvious that ignore_mouse_drag_p is not accessed if !defined
10180 USE_GTK && !defined HAVE_NS.
10181
93ea6e8f
PE
10182 * intervals.c: Make symbols static if they're not exported.
10183 (merge_properties_sticky, merge_interval_right, delete_interval):
10184 Now static.
10185 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10186
77382fcc
PE
10187 * insdel.c: Make symbols static if they're not exported.
10188 However, leave prepare_to_modify_buffer alone. It's never
10189 called from outside this function, but that appears to be a bug.
10190 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10191 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10192 (adjust_after_replace_noundo): Remove; unused.
10193 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10194 (signal_before_change): Remove decls.
77382fcc 10195
9306c32e
PE
10196 * indent.c (val_compute_motion, val_vmotion): Now static.
10197
cd44d2eb
PE
10198 * image.c: Make symbols static if they're not exported.
10199 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10200 if USE_GTK.
10201 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10202 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10203
ad9a7a06
PE
10204 * fringe.c (standard_bitmaps): Now static.
10205 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10206
81626931
PE
10207 * frame.c: Make symbols static if they're not exported.
10208 (x_report_frame_params, make_terminal_frame): Now static.
10209 (get_frame_param): Now static, unless HAVE_NS.
10210 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10211 (x_get_resource_string): Remove; not used.
10212 * frame.h (make_terminal_frame, x_report_frame_params):
10213 (x_get_resource_string); Remove decls.
10214 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10215 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10216
239f9db9
PE
10217 * font.c, fontset.c: Make symbols static if they're not exported.
10218 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10219 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10220 * font.c (font_close_object): Now static.
10221 * font.h (font_close_object): Remove.
10222 * fontset.c (FONTSET_OBJLIST): Remove.
10223 (free_realized_fontset) #if-0 the body, which does nothing.
10224 (face_suitable_for_char_p): #if-0, as it's never called.
10225 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10226 * xfaces.c (face_at_string_position):
10227 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10228 since 0 is always ASCII.
10229
dfcf3579
PE
10230 * fns.c (weak_hash_tables): Now static.
10231
5045092b
PE
10232 * fileio.c: Make symbols static if they're not exported.
10233 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10234 (Vwrite_region_annotation_buffers): Now static.
10235
57a96f5c
PE
10236 * eval.c: Make symbols static if they're not exported.
10237 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10238 * lisp.h (backtrace_list): Remove decl.
10239
35f08c38
PE
10240 * emacs.c: Make symbols static if they're not exported.
10241 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10242 (fatal_error_code, fatal_error_signal_hook, standard_args):
10243 Now static.
10244 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10245 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10246 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10247 * lisp.h (fatal_error_signal_hook): Remove decl.
10248 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10249
f44bd759
PE
10250 * editfns.c: Move a (normally-unused) function to its only use.
10251 * editfns.c, lisp.h (get_operating_system_release): Remove.
10252 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10253 worth the hassle of breaking this out.
10254
b532497d
PE
10255 * xterm.c: Make symbols static if they're not exported.
10256 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10257 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10258 (x_destroy_window, x_delete_display):
10259 Now static.
10260 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10261 (x_mouse_leave): Remove; unused.
10262 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10263 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10264 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10265 Remove decls.
10266 (x_mouse_leave): Declare only if WINDOWSNT.
10267 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10268 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10269 USE_X_TOOLKIT.
10270
1675728f
PE
10271 * ftxfont.c: Make symbols static if they're not exported.
10272 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10273 HAVE_FREETYPE.
10274 * font.h (ftxfont_driver): Likewise.
10275
e4cebfca
PE
10276 * xfns.c: Make symbols static if they're not exported.
10277 (x_last_font_name, x_display_info_for_name):
10278 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10279 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10280 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10281 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10282 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10283 (last_show_tip_args): Now static.
10284 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10285 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10286 (x_screen_planes): Remove; unused.
10287 * dispextern.h (x_screen_planes): Remove decl.
10288
5bf46f05
PE
10289 * dispnew.c: Make symbols static if they're not exported.
10290 * dispextern.h (redraw_garbaged_frames, scrolling):
10291 (increment_row_positions): Remove.
10292 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10293 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10294 Now static.
10295 (redraw_garbaged_frames): Remove; unused.
10296
435f4c28
PE
10297 * xfaces.c: Make symbols static if they're not exported.
10298 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10299 Remove decls.
10300 * xterm.h (defined_color): Remove decls.
10301 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10302 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10303 (menu_face_changed_default, defined_color, free_realized_face):
10304 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10305 (ascii_face_of_lisp_face): Remove; unused.
10306
8524aef3
PE
10307 * xdisp.c: Make symbols static if they're not exported.
10308 * dispextern.h (scratch_glyph_row, window_box_edges):
10309 (glyph_to_pixel_coords, set_cursor_from_row):
10310 (get_next_display_element, set_iterator_to_next):
10311 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10312 (show_mouse_face): Remove decls
10313 * frame.h (message_buf_print): Likewise.
10314 * lisp.h (pop_message, set_message, check_point_in_composition):
10315 Likewise.
10316 * xterm.h (set_vertical_scroll_bar): Likewise.
10317 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10318 (message_buf_print, scratch_glyph_row, displayed_buffer):
10319 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10320 (get_next_display_element, show_mouse_face, window_box_edges):
10321 (frame_to_window_pixel_xy, check_point_in_composition):
10322 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10323 (glyph_to_pixel_coords): Remove; unused.
10324
16390cd2
PE
10325 * dired.c (file_name_completion): Now static.
10326
10327 * dbusbind.c (xd_in_read_queued_messages): Now static.
10328
a25f4dfa
PE
10329 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10330 * data.c (circular_list_error): Remove.
10331
14a9c8df
PE
10332 * commands.h (last_point_position, last_point_position_buffer):
10333 (last_point_position_window): Remove decls.
10334 * keyboard.c: Make these variables static.
10335
04f2d78b
CB
10336 * coding.h (coding, code_convert_region, encode_coding_gap):
10337 Remove decls.
74ab6df5
PE
10338 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10339 (iso_code_class, detect_coding, code_convert_region): Now static.
10340 (encode_coding_gap): Remove; unused.
10341
38dfbee1
PE
10342 * chartab.c (chartab_chars, chartab_bits): Now static.
10343
a2cb4e63
PE
10344 * charset.h (charset_iso_8859_1): Remove decl.
10345 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10346 Now static.
10347
127198fd
PE
10348 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10349 * ccl.c (Vccl_program_table): Now static.
10350 (check_ccl_update): Remove; unused.
10351
d85b608f
PE
10352 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10353 * category.h: ... from here.
10354 * category.c (check_category_table, set_category_set): Now static.
10355
31cd66f3
PE
10356 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10357 * lisp.h: Remove these decls.
10358
c358e587
PE
10359 * buffer.c (buffer_count): Remove unused var.
10360
e78aecca
PE
10361 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10362 so that it's not optimized away.
10363 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10364 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10365 exported only to the debugger.
10366
e192d7d3 10367 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10368 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10369
92470028
PE
10370 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10371 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10372 was inaccessible from Lisp.
10373 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10374 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10375
244ed907
PE
10376 alloc.c: Import and export fewer symbols, and remove unused items.
10377 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10378 is defined.
10379 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10380 it's not optimized away by whole-program optimization.
10381 (message_enable_multibyte, free_misc): Remove.
10382 (catchlist, handlerlist, mark_backtrace):
10383 Declare only if BYTE_MARK_STACK.
10384 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10385 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10386 (message_enable_multibyte): Remove decl.
10387 (free_misc, interval_free_list, float_block, float_block_index):
10388 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10389 (cons_free_list, last_marked_index):
10390 Now static.
10391 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10392 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10393 (mark_backtrace): Define only if BYTE_MARK_STACK.
10394 * xdisp.c (message_enable_multibyte): Now static.
10395
61c2b50e 10396 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10397 This makes it easier for human readers (and static analyzers)
10398 to see whether these variables are used from other modules.
10399 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10400 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10401 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10402 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10403 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10404 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10405 * xmenu.c, xselect.c:
10406 Declare Q* vars static if they are not used in other modules.
10407 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10408 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10409 Remove decls of unexported vars.
10410 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10411
95c82688
PE
10412 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10413
16a97296
PE
10414 Make Emacs functions such as Fatom 'static' by default.
10415 This makes it easier for human readers (and static analyzers)
10416 to see whether these functions can be called from other modules.
10417 DEFUN now defines a static function. To make the function external
10418 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10419 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10420 (Finit_image_library):
16a97296
PE
10421 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10422 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10423 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10424 Remove decls, since these functions are now static.
10425 (Funintern, Fget_internal_run_time): New decls, since these functions
10426 were already external.
95c82688 10427
16a97296
PE
10428 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10429 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10430 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10431 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10432 * keyboard.c, keymap.c, lread.c:
10433 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10434 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10435 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10436 Mark functions with DEFUE instead of DEFUN,
10437 if they are used in other modules.
10438 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10439 decls for now-static functions.
10440 * buffer.h (Fdelete_overlay): Remove decl.
10441 * callproc.c (Fgetenv_internal): Mark as internal.
10442 * composite.c (Fremove_list_of_text_properties): Remove decl.
10443 (Fcomposition_get_gstring): New forward static decl.
10444 * composite.h (Fcomposite_get_gstring): Remove decl.
10445 * dired.c (Ffile_attributes): New forward static decl.
10446 * doc.c (Fdocumntation_property): New forward static decl.
10447 * eval.c (Ffetch_bytecode): New forward static decl.
10448 (Funintern): Remove extern decl; now in .h file where it belongs.
10449 * fileio.c (Fmake_symbolic_link): New forward static decl.
10450 * image.c (Finit_image_library): New forward static decl.
10451 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10452 * intervals.h (Fprevious_property_change):
10453 (Fremove_list_of_text_properties): Remove decls.
10454 * keyboard.c (Fthis_command_keys): Remove decl.
10455 (Fcommand_execute): New forward static decl.
10456 * keymap.c (Flookup_key): New forward static decl.
10457 (Fcopy_keymap): Now static.
10458 * keymap.h (Flookup_key): Remove decl.
10459 * process.c (Fget_process): New forward static decl.
10460 (Fprocess_datagram_address): Mark as internal.
10461 * syntax.c (Fsyntax_table_p): New forward static decl.
10462 (skip_chars): Remove duplicate decl.
10463 * textprop.c (Fprevious_property_change): New forward static decl.
10464 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10465 Now internal.
10466 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10467 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10468
785bbd42
PE
10469 * editfns.c (Fformat): Remove unreachable code.
10470
8b913b57
AS
104712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10472
10473 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10474 change. (Bug#8496)
10475
a6744a35
EZ
104762011-04-13 Eli Zaretskii <eliz@gnu.org>
10477
10478 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10479 when at ZV. (Bug#8487)
10480
e7974947
AS
104812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10482
baad03f0
AS
10483 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10484 (Bug#8437)
10485 * keyboard.c (parse_tool_bar_item): Likewise.
10486 * sound.c (sound_cleanup, alsa_close): Likewise.
10487 * termcap.c (tgetent): Likewise.
10488 * xfns.c (x_default_font_parameter): Likewise.
10489 * xsettings.c (read_and_apply_settings): Likewise.
10490
e7974947
AS
10491 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10492 (overrun_check_free): Protoize.
10493
28272684
PE
104942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10495
10496 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10497 since callers should never pass a negative size.
10498 Change the signature to match that of plain 'read' and 'write'; see
10499 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10500 * lisp.h: Update prototypes of emacs_write and emacs_read.
10501
11997c76
EZ
105022011-04-11 Eli Zaretskii <eliz@gnu.org>
10503
10504 * xdisp.c (redisplay_window): Don't try to determine the character
10505 position of the scroll margin if the window start point w->startp
e896f03c 10506 is outside the buffer's accessible region. (Bug#8468)
11997c76 10507
8a2cbd72
EZ
105082011-04-10 Eli Zaretskii <eliz@gnu.org>
10509
10510 Fix write-region and its subroutines for buffers > 2GB.
10511 * fileio.c (a_write, e_write): Modify declaration of arguments and
10512 local variables to support buffers larger than 2GB.
10513 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10514
10515 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10516 argument, local variables, and return value.
10517
10518 * lisp.h: Update prototypes of emacs_write and emacs_read.
10519
10520 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10521
4073e537 105222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10523
1ebfdcb6
PE
10524 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10525
b2ded58d
PE
10526 Fix more problems found by GCC 4.6.0's static checks.
10527
7d66342c
PE
10528 * xdisp.c (vmessage): Use a better test for character truncation.
10529
bbf47d44
PE
10530 * charset.c (load_charset_map): <, not <=, for optimization,
10531 and to avoid potential problems with integer overflow.
9248994d 10532 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10533 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10534 * editfns.c (Fformat): Likewise.
1e69125e 10535 * syntax.c (skip_chars): Likewise.
3befa583 10536
e3019616
PE
10537 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10538 This also lets GCC 4.6.0 generate slightly better loop code.
10539
becfa255
PE
10540 * callint.c (Fcall_interactively): <, not <=, for optimization.
10541 (Fcall_interactively): Count the number of arguments produced,
10542 not the number of arguments given. This is simpler and lets GCC
10543 4.6.0 generate slightly better code.
10544
dae0cd48
PE
10545 * ftfont.c: Distingish more carefully between FcChar8 and char.
10546 The previous code passed unsigned char * to a functions like
10547 strlen and xstrcasecmp that expect char *, which does not
10548 conform to the C standard.
10549 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10550 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10551 char * when the C standard requires it.
10552
76032d70
PE
10553 * keyboard.c (read_char): Remove unused var.
10554
eb3f1cc8
PE
10555 * eval.c: Port to Windows vsnprintf (Bug#8435).
10556 Include <limits.h>.
10557 (SIZE_MAX): Define if the headers do not.
10558 (verror): Do not give up if vsnprintf returns a negative count.
10559 Instead, grow the buffer. This ports to Windows vsnprintf, which
10560 does not conform to C99. Problem reported by Eli Zaretskii.
10561 Also, simplify the allocation scheme, by avoiding the need for
10562 calling realloc, and removing the ALLOCATED variable.
10563
70476b54
PE
10564 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10565
12020a9e
PE
10566 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10567 But keep the doprint source code for now, as we might revamp it
10568 and use it again (Bug#8435).
ea6c7ae6
PE
10569 * lisp.h (doprnt): Remove.
10570 * Makefile.in (base_obj): Remove doprnt.o.
10571 * deps.mk (doprnt.o): Remove.
10572
5fdb398c
PE
10573 error: Print 32- and 64-bit integers portably (Bug#8435).
10574 Without this change, on typical 64-bit hosts error ("...%d...", N)
10575 was used to print both 32- and 64-bit integers N, which relied on
10576 undefined behavior.
61bdb816 10577 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10578 * lisp.h (error, verror): Mark as printf-like functions.
10579 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10580 Report overflow in size calculations when allocating printf buffer.
10581 Do not truncate output string at its first null byte.
10582 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10583 Truncate the output at a character boundary, since vsnprintf does not
10584 do that.
10585 * charset.c (check_iso_charset_parameter): Convert internal
10586 character to string before calling 'error', since %c now has the
10587 printf meaning.
10588 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10589 overflow when computing char to be passed to 'error'. Do not
10590 pass Lisp_Object to 'error'; pass the integer instead.
10591 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10592 formatted with plain %d.
10593
b189fa66
PE
10594 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10595
bff87ef0
PE
10596 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10597
7e2cac20
PE
10598 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10599
ce4d90b5
PE
10600 * xterm.c (x_catch_errors): Remove duplicate declaration.
10601
266c9547
PE
10602 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10603
79c49ad2
PE
10604 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10605
368f4090
JM
106062011-04-10 Jim Meyering <meyering@redhat.com>
10607
10608 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10609 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10610 return ssize_t not "int", and use size_t as the buffer length.
10611 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10612 * gnutls.h: Update declarations.
10613 * process.c (read_process_output): Use ssize_t, to match.
10614 (send_process): Likewise.
10615
a32d4040
CY
106162011-04-09 Chong Yidong <cyd@stupidchicken.com>
10617
10618 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10619
8546720e 106202011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10621
04f2d78b
CB
10622 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10623 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10624
8546720e
GM
10625 * xterm.c (handle_one_xevent):
10626 * xmenu.c (create_and_show_popup_menu):
10627 * xselect.c (x_decline_selection_request)
10628 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10629
0a2f5c1a 106302011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10631
10632 Fix some uses of `int' instead of EMACS_INT.
10633 * search.c (string_match_1, fast_string_match)
10634 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10635 (scan_buffer, find_next_newline_no_quit)
10636 (find_before_next_newline, search_command, Freplace_match)
10637 (Fmatch_data): Make some `int' variables be EMACS_INT.
10638
10639 * xdisp.c (display_count_lines): 3rd argument and return value now
10640 EMACS_INT. All callers changed.
10641 (pint2hrstr): Last argument is now EMACS_INT.
10642
10643 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10644 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10645 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10646 (decode_coding_utf_16, decode_coding_emacs_mule)
10647 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10648 (decode_coding_ccl, decode_coding_charset)
10649 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10650 (decode_coding_iso_2022, decode_coding_emacs_mule)
10651 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10652 <char_offset, last_offset>: Declare EMACS_INT.
10653 (encode_coding_utf_8, encode_coding_utf_16)
10654 (encode_coding_emacs_mule, encode_invocation_designation)
10655 (encode_designation_at_bol, encode_coding_iso_2022)
10656 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10657 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10658 Declare EMACS_INT.
10659 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10660 (encode_invocation_designation): Last argument P_NCHARS is now
10661 EMACS_INT.
10662 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10663 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10664
10665 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10666 All users changed.
10667
10668 * ccl.c (Fccl_execute_on_string): Declare some variables
10669 EMACS_INT.
10670
8546720e 106712011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10672
10673 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10674
4e19a977
CS
106752011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10676
10677 * process.c (Fformat_network_address): Doc fix.
10678
87302331
R
106792011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10680
ee7683eb 10681 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10682
cbb59342
CY
106832011-04-08 Chong Yidong <cyd@stupidchicken.com>
10684
10685 * keyboard.c (read_char): Call Lisp function help-form-show,
10686 instead of using internal_with_output_to_temp_buffer.
10687 (Qhelp_form_show): New var.
e0d38eeb 10688 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10689
10690 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10691
10692 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10693
e67a13ab
CY
106942011-04-06 Chong Yidong <cyd@stupidchicken.com>
10695
04f2d78b
CB
10696 * process.c (Flist_processes): Remove to Lisp.
10697 (list_processes_1): Delete.
e67a13ab 10698
973f782d
EZ
106992011-04-06 Eli Zaretskii <eliz@gnu.org>
10700
7c106b1e
EZ
10701 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10702
973f782d
EZ
10703 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10704
41cf7d1a 107052011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10706
ca23cc88
PE
10707 Fix more problems found by GCC 4.6.0's static checks.
10708
f390e2d5
PE
10709 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10710
42eea0d0
PE
10711 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10712
b69769da 10713 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10714
f9541e84
PE
10715 * xdisp.c (vmessage): Mark as a printf-like function.
10716
13841b55
PE
10717 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10718
c136c10f
PE
10719 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10720
5e2d4a30
PE
10721 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10722 printf-like functions.
10723 (tiff_load): Add casts to remove these marks before passing them
10724 to system-supplied API.
10725
583f48b9
PE
10726 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10727
b25d760e
PE
10728 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10729 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10730 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10731 directly, rather than having caller test rule sign. This avoids
10732 some unnecessary tests.
10733 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10734 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10735 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10736
bc7b6697 10737 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10738 (xfont_open): Avoid unnecessary tests.
bc7b6697 10739
27ccc379
PE
10740 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10741
dcd5c89a
PE
10742 * composite.h, composite.c (composition_gstring_put_cache):
10743 Use EMACS_INT, not int, for length.
10744
b13a45c6
PE
10745 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10746 breaking out part of COMPOSITION_DECODE_RULE.
10747 (COMPOSITION_DECODE_RULE): Use it.
10748 * composite.c (get_composition_id): Remove unused local vars,
10749 by using the new macro.
10750
1e792e4d
PE
10751 * textprop.c (set_text_properties_1): Change while to do-while,
10752 since the condition is always true at first.
10753
dc6c6455 10754 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10755 (interval_deletion_adjustment): Return unsigned value.
10756 All uses changed.
dc6c6455 10757
aba7731a
PE
10758 * process.c (list_processes_1, create_pty, read_process_output):
10759 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10760 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10761 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10762 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10763 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10764
fdfc4bf3
PE
10765 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10766
fca8fe46 10767 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10768 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10769
06a0259a 10770 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10771 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10772 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10773
e7b9e80f
PE
10774 * print.c (print_error_message): Avoid int overflow.
10775
56201685
PE
10776 * font.c (font_list_entities): Redo for clarity,
10777 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10778
78834453 10779 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10780 (font_score): Avoid potential overflow in diff calculation.
78834453 10781
0bc0b309 10782 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10783 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10784
e610eaca
PE
10785 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10786
b895abce
PE
10787 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10788 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10789 can always succeed if overflow has undefined behavior.
10790
1f1d9321 10791 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10792 (wordify): Omit three unnecessary tests.
1f1d9321 10793
c59478bc
PE
10794 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10795 All callers changed. This avoids the need for an unused var.
10796
79b73827
PE
10797 * casefiddle.c (casify_region): Remove var that is set but not used.
10798
a4db5dfe
PE
10799 * dired.c (file_name_completion): Remove var that is set but not used.
10800
43aae36e
PE
10801 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10802
2a47c44d 10803 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10804 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10805
a37c69bf
PE
10806 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10807 Check for integer overflow on size calculations.
10808
328ab8e7
PE
10809 * buffer.c (Fprevious_overlay_change): Remove var that is set
10810 but not used.
10811
e5a2a5cb
PE
10812 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10813 Remove vars that are set but not used.
8d84a6eb 10814 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10815 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10816
a60e5f68
PE
10817 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10818
f661cb61 10819 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10820 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10821
f0397f5a
PE
10822 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10823 that are set but not used.
10824
8664db06 10825 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10826 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10827
6abdaa4a
PE
10828 * xselect.c (x_get_local_selection, x_handle_property_notify):
10829 Remove vars that are set but not used.
10830
0ce7538d 10831 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10832 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10833
9ae848fc
PE
10834 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10835 Remove var that is set but not used.
0b918413
PE
10836 (scroll_bar_windows_size): Now size_t, not int.
10837 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10838 Check for overflow.
9ae848fc 10839
a5a62657
PE
10840 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10841 (map_tty_color) [!defined MSDOS]: Likewise.
10842
5c5cdd39
PE
10843 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10844
66ebf983
PE
10845 * coding.c: Remove vars that are set but not used.
10846 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10847 All callers changed.
10848 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10849 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10850 (decode_coding_charset): Remove vars that are set but not used.
10851
1be4d761
PE
10852 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10853 that is set but not used.
10854
47553fa8
PE
10855 * print.c (print_object): Remove var that is set but not used.
10856
1f7196bf 10857 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10858 The gnulib version avoids calling malloc in the usual case,
10859 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10860 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10861 * filelock.c (current_lock_owner): Likewise.
10862 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10863 * sysdep.c: Include allocator.h, careadlinkat.h.
10864 (emacs_no_realloc_allocator): New static constant.
10865 (emacs_readlink): New function.
fdb61804
PE
10866 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10867 ../lib/careadlinkat.h.
d1fdcab7 10868
f84c17c7
SM
108692011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10870
10871 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10872 first non-nil return value).
10873
ef3862ad
JD
108742011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10875
10876 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10877 if not defined (Bug#8403).
10878
376a7006
JB
108792011-04-02 Juanma Barranquero <lekktu@gmail.com>
10880
10881 * xdisp.c (display_count_lines): Remove parameter `start',
10882 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10883 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10884 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10885 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10886 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10887 and thereabouts. All callers changed.
10888 (get_per_char_metric): Remove parameter `f', unused since
10889 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10890
6ca3801d
JM
108912011-04-02 Jim Meyering <meyering@redhat.com>
10892
10893 do not dereference NULL upon failed strdup
10894 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10895 (ns_get_family): Likewise.
10896
d8e2b5ba
JB
108972011-04-02 Juanma Barranquero <lekktu@gmail.com>
10898
10899 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10900
8c74fcbd
JD
109012011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10902
10903 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10904 later (Bug#8403).
10905
7200d79c
SM
109062011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10907
03408648 10908 Add lexical binding.
7200d79c 10909
03408648
SM
10910 * window.c (Ftemp_output_buffer_show): New fun.
10911 (Fsave_window_excursion):
10912 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10913
10914 * lread.c (lisp_file_lexically_bound_p): New function.
10915 (Fload): Bind Qlexical_binding.
10916 (readevalloop): Remove `evalfun' arg.
10917 Bind Qinternal_interpreter_environment.
10918 (Feval_buffer): Bind Qlexical_binding.
10919 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10920 Mark as dynamic.
10921 (syms_of_lread): Declare `lexical-binding'.
10922
10923 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10924
10925 * keyboard.c (eval_dyn): New fun.
10926 (menu_item_eval_property): Use it.
ca105506
SM
10927
10928 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10929
03408648
SM
10930 * fns.c (concat, mapcar1): Accept byte-code-functions.
10931
10932 * eval.c (Fsetq): Handle lexical vars.
10933 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10934 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10935 (FletX, Flet): Obey lexical binding.
10936 (Fcommandp): Handle closures.
10937 (Feval): New `lexical' arg.
10938 (eval_sub): New function extracted from Feval. Use it almost
10939 everywhere where Feval was used. Look up vars in lexical env.
10940 Handle closures.
10941 (Ffunctionp): Move from subr.el.
10942 (Ffuncall): Handle closures.
10943 (apply_lambda): Remove `eval_flags'.
10944 (funcall_lambda): Handle closures and new byte-code-functions.
10945 (Fspecial_variable_p): New function.
10946 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10947 but without exporting it to Lisp.
23aba0ea 10948
23aba0ea 10949 * doc.c (Fdocumentation, store_function_docstring):
03408648 10950 * data.c (Finteractive_form): Handle closures.
23aba0ea 10951
03408648
SM
10952 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10953 interactive spec.
ba83908c 10954
04f2d78b
CB
10955 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10956 New byte-codes.
03408648
SM
10957 (exec_byte_code): New function extracted from Fbyte_code to handle new
10958 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10959
03408648 10960 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10961
03408648 10962 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10963
e2abce01
JB
109642011-03-31 Juanma Barranquero <lekktu@gmail.com>
10965
10966 * xdisp.c (redisplay_internal): Fix prototype.
10967
63696a73 109682011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10969
63696a73 10970 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10971 (try_scrolling): Use it when setting scroll_limit.
10972 Limit scrolling to 100 screen lines.
63696a73
EZ
10973 (redisplay_window): Even when falling back on "recentering",
10974 position point in the window according to scroll-conservatively,
10975 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10976
10977 (try_scrolling): When point is above the window, allow searching
10978 as far as scroll_max, or one screenful, to compute vertical
10979 distance from PT to the scroll margin position. This prevents
10980 try_scrolling from unnecessarily failing when
10981 scroll-conservatively is set to a value slightly larger than the
10982 window height. Clean up the case of PT below the margin at bottom
10983 of window: scroll_max can no longer be INT_MAX. When aggressive
10984 scrolling is in use, don't let point enter the opposite scroll
10985 margin as result of the scroll.
10986 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10987 threshold of 100 lines for never-recentering scrolling.
10988
e4cc2dfc
JB
109892011-03-31 Juanma Barranquero <lekktu@gmail.com>
10990
10991 * dispextern.h (move_it_by_lines):
10992 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10993 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10994 (message_log_check_duplicate): Remove parameters `prev_bol' and
10995 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10996 (redisplay_internal): Remove parameter `preserve_echo_area',
10997 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10998
10999 * indent.c (Fvertical_motion):
11000 * window.c (window_scroll_pixel_based, Frecenter):
11001 Don't pass `need_y_p' to `move_it_by_lines'.
11002
1c470562
SM
110032011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11004
44f230aa
SM
11005 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11006 steal a few bits to be more compact.
11007 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11008 Remove unneeded casts.
11009
1c470562
SM
11010 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11011
888adce9
ZK
110122011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11013
11014 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11015 binding" message (bug#7967).
11016
f838ed7b
PE
110172011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11018
77861b95
PE
11019 Fix more problems found by GCC 4.6.0's static checks.
11020
de6dbc14
PE
11021 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11022 Remove unused local var.
11023
f838ed7b
PE
11024 * editfns.c (Fmessage_box): Remove unused local var.
11025
792c7b2b
PE
11026 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11027 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11028 Omit unused local vars.
c499e557 11029 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11030 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11031 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11032 Omit unused local var.
11033
ba0165e1
PE
11034 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11035 Don't assume string length fits in int.
32ad8845 11036 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11037 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11038
3c59b4c9
PE
11039 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11040 instead of alloca (Bug#8344).
11041
a3eed478 11042 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11043 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11044
eb4d412d
PE
11045 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11046
1658b401
PE
11047 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11048 concerns.
11049
11050 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11051
11052 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11053
9a2c6e05
PE
11054 * keyboard.c (syms_of_keyboard): Use the same style as later
11055 in this function when indexing through an array. This also
11056 works around GCC bug 48267.
11057
03d0a109
PE
11058 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11059
44f730c8
PE
11060 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11061
fe75f926
PE
11062 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11063 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11064
ffa8c828
PE
11065 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11066 This avoids undefined behavior on integer overflow, and is a bit
11067 more convenient anyway since it is compared to a size_t variable.
11068
c5101a77
PE
11069 Variadic C functions now count arguments with size_t, not int.
11070 This avoids an unnecessary limitation on 64-bit machines, which
11071 caused (substring ...) to crash on large vectors (Bug#8344).
11072 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11073 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11074 All variadic functions and their callers changed accordingly.
c5101a77
PE
11075 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11076 * data.c (arith_driver, float_arith_driver): Likewise.
11077 * editfns.c (general_insert_function): Likewise.
11078 * eval.c (struct backtrace.nargs, interactive_p)
11079 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11080 (funcall_lambda, mark_backtrace): Likewise.
11081 * fns.c (concat): Likewise.
11082 * frame.c (x_set_frame_parameters): Likewise.
11083 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11084 0 if not found, not -1. All callers changed.
11085
dd3f25f7
PE
11086 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11087 (stack_copy_size): Now size_t, not int.
11088 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11089
461c2ab9
JB
110902011-03-28 Juanma Barranquero <lekktu@gmail.com>
11091
11092 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11093 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11094 All callers changed.
11095
11096 * lisp.h (multibyte_char_to_unibyte):
11097 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11098 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11099 * character.h (CHAR_TO_BYTE8):
11100 * cmds.c (internal_self_insert):
11101 * editfns.c (general_insert_function):
11102 * keymap.c (push_key_description):
11103 * search.c (Freplace_match):
11104 * xdisp.c (message_dolog, set_message_1): All callers changed.
11105
f6d62986
SM
111062011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11107
11108 * keyboard.c (safe_run_hook_funcall): New function.
11109 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11110 don't set the hook to nil, but remove the offending function instead.
11111 (Qcommand_hook_internal): Remove, unused.
11112 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11113 Vcommand_hook_internal.
11114
11115 * eval.c (enum run_hooks_condition): Remove.
11116 (funcall_nil, funcall_not): New functions.
11117 (run_hook_with_args): Call each function through a `funcall' argument.
11118 Remove `cond' argument, now redundant.
11119 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11120 (Frun_hook_with_args_until_failure): Adjust accordingly.
11121 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11122
1db5b1ad
JB
111232011-03-28 Juanma Barranquero <lekktu@gmail.com>
11124
11125 * dispextern.h (string_buffer_position): Remove declaration.
11126
11127 * print.c (strout): Remove parameter `multibyte', unused since
11128 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11129
11130 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11131 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11132 All callers changed.
11133
11134 * w32.c (_wsa_errlist): Use braces for struct initializers.
11135
11136 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11137 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11138 All callers changed.
11139 (string_buffer_position): Likewise. Also, make static (it's never
11140 used outside xdisp.c).
11141 (cursor_row_p): Remove parameter `w', unused since
11142 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11143 (decode_mode_spec): Remove parameter `precision', introduced during
11144 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11145 All callers changed.
11146
5ffb62aa
JD
111472011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11148
11149 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11150
461c2ab9 111512011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11152
11153 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11154 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11155 (ns_update_auto_hide_menu_bar): New functions.
11156 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11157 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11158 ns_constrain_all_frames.
11159 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11160 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11161
5c380ffb
JD
111622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11163
11164 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11165
9af30bdf
GM
111662011-03-27 Glenn Morris <rgm@gnu.org>
11167
11168 * syssignal.h: Replace RETSIGTYPE with void.
11169 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11170 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11171 Replace SIGTYPE with void everywhere.
11172 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11173 * s/template.h (SIGTYPE): Remove commented out definition.
11174
e2abce01
JB
111752011-03-26 Eli Zaretskii <eliz@gnu.org>
11176
11177 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11178 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11179
f868cd8a
JB
111802011-03-26 Juanma Barranquero <lekktu@gmail.com>
11181
59eb0929
JB
11182 * w32.c (read_unc_volume): Use parameter `henum', instead of
11183 global variable `wget_enum_handle'.
11184
11185 * keymap.c (describe_vector): Remove parameters `indices' and
11186 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11187 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11188
f868cd8a
JB
11189 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11190
11191 * keyboard.c (timer_check): Remove parameter `do_it_now',
11192 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11193 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11194 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11195
11196 * keyboard.c (read_char):
11197 * w32menu.c (w32_menu_display_help):
11198 * xmenu.c (show_help_event, menu_help_callback):
11199 Adjust calls to `show_help_echo'.
11200
11201 * gtkutil.c (xg_maybe_add_timer):
11202 * keyboard.c (readable_events):
11203 * process.c (wait_reading_process_output):
11204 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11205
11206 * insdel.c (adjust_markers_gap_motion):
11207 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11208 (gap_left, gap_right): Don't call it.
11209
2ecf6fdb
CY
112102011-03-25 Chong Yidong <cyd@stupidchicken.com>
11211
11212 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11213 incurred during fontification.
11214
6b1f9ba4
JB
112152011-03-25 Juanma Barranquero <lekktu@gmail.com>
11216
11217 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11218 (DEFVAR_PER_BUFFER): Don't pass it.
11219
11220 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11221 (scrolling_window): Don't pass it.
11222
0f4a96b5
JB
112232011-03-25 Juanma Barranquero <lekktu@gmail.com>
11224
11225 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11226
11227 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11228 and `suffix'.
11229 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11230 of variables specific to SELinux and computation of `encoded_absname'.
11231
11232 * image.c (XPutPixel): Remove unused variable `height'.
11233
11234 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11235
11236 * unexw32.c (get_section_info): Remove unused variable `section'.
11237
11238 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11239 (system_process_attributes): Remove unused variable `sess'.
11240 (sys_read): Remove unused variable `err'.
11241
11242 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11243 (w32_wnd_proc): Remove unused variable `isdead'.
11244 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11245 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11246 (x_create_tip_frame): Remove unused variable `tem'.
11247
11248 * w32inevt.c (w32_console_read_socket):
11249 Remove unused variable `no_events'.
11250
11251 * w32term.c (x_draw_composite_glyph_string_foreground):
11252 Remove unused variable `width'.
11253
1149507c
JB
112542011-03-24 Juanma Barranquero <lekktu@gmail.com>
11255
11256 * w32term.c (x_set_glyph_string_clipping):
11257 Don't pass uninitialized region to CombineRgn.
11258
9c88f339
JB
112592011-03-23 Juanma Barranquero <lekktu@gmail.com>
11260
11261 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11262 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11263 (Fx_close_connection): Remove unused variable `i'.
11264
11265 * w32font.c (w32font_draw): Return number of glyphs.
11266 (w32font_open_internal): Remove unused variable `i'.
11267 (w32font_driver): Add missing initializer.
11268
11269 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11270 (fill_in_menu): Remove unused variable `items_added'.
11271
11272 * w32term.c (last_mouse_press_frame): Remove static global variable.
11273 (w32_clip_to_row): Remove unused variable `f'.
11274 (x_delete_terminal): Remove unused variable `i'.
11275
11276 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11277 (NOTHING): Remove unused static global variable.
11278 (uniscribe_check_otf): Remove unused variable `table'.
11279 (uniscribe_font_driver): Add missing initializers.
11280
dee091a3
JD
112812011-03-23 Julien Danjou <julien@danjou.info>
11282
11283 * term.c (Fsuspend_tty, Fresume_tty):
11284 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11285 * window.c (temp_output_buffer_show):
11286 * insdel.c (signal_before_change):
11287 * frame.c (Fhandle_switch_frame):
11288 * fileio.c (Fdo_auto_save):
11289 * emacs.c (Fkill_emacs):
11290 * editfns.c (save_excursion_restore):
11291 * cmds.c (internal_self_insert):
11292 * callint.c (Fcall_interactively):
11293 * buffer.c (Fkill_all_local_variables):
11294 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11295 Use Frun_hooks.
0f4a96b5 11296 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11297 unconditionally since it does the check itself.
dee091a3 11298
2c520ab5 112992011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11300
c9c49752
PE
11301 Fix more problems found by GCC 4.5.2's static checks.
11302
8abc3f12
PE
11303 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11304 the first time through the loop, since we know p0 < p1 then.
11305 This also avoids a gcc -Wstrict-overflow warning.
11306
a2d26660
PE
11307 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11308 leading to a memory leak, possible in functions like
11309 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11310 of objects (Bug#8318).
a2d26660 11311
916c72e9
PE
11312 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11313 that could (at least in theory) be that large.
11314
19ab8a18
PE
11315 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11316 This is less likely to overflow, and avoids undefined behavior if
11317 overflow does occur. All callers changed. Use strtoul to scan
11318 for the unsigned long integer.
b7cbbd6f
PE
11319 (pint2hrstr): Simplify and tune code slightly.
11320 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11321
f0641eff
PE
11322 * scroll.c (do_scrolling): Work around GCC bug 48228.
11323 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11324
7f650bb9
PE
11325 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11326 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11327 (validate_x_resource_name): Simplify count usage.
11328 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11329
37dd57d1
PE
11330 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11331 fail (Bug#8306).
81e56e61 11332
699979fc 11333 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11334
401bf9b4
PE
11335 * process.c (Fmake_network_process): Use socklen_t, not int,
11336 where POSIX says socklen_t is required in portable programs.
11337 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11338 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11339 (Fmake_network_process, server_accept_connection):
11340 (wait_reading_process_output, read_process_output):
11341 Likewise.
11342
b93aacde
PE
11343 * process.c: Rename or move locals to avoid shadowing.
11344 (list_processes_1, Fmake_network_process):
11345 (read_process_output_error_handler, exec_sentinel_error_handler):
11346 Rename or move locals.
4dc343ee 11347 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11348 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11349 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11350 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11351 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11352
af8a867c 11353 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11354 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11355 Include tparam.h instead, since it declares them.
af8a867c
PE
11356 * cm.h (PC): Remove extern decl; tparam.h now does this.
11357 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11358 * terminfo.c: Include tparam.h, to check interfaces.
11359 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11360 (tparam): Adjust signature to match interface in tparam.h;
11361 this removes some undefined behavior. Check that outstring and len
11362 are zero, which they always are with Emacs.
11363 * tparam.h (PC, BC, UP): New extern decls.
11364
0248044d 11365 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11366 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11367
8ff096c1 11368 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11369 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11370 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11371 (ftfont_list): Remove unused local.
49eaafba
PE
11372 (get_adstyle_property, ftfont_pattern_entity):
11373 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11374 Rename locals to avoid shadowing.
8ff096c1 11375
e2be39f6
PE
11376 * xfont.c (xfont_list_family): Mark var as initialized.
11377
c9735e30
PE
11378 * xml.c (make_dom): Now static.
11379
8f5201ae
PE
11380 * composite.c (composition_compute_stop_pos): Rename local to
11381 avoid shadowing.
b246f932
PE
11382 (composition_reseat_it): Remove unused locals.
11383 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11384 (composition_update_it): Mark var as initialized.
11b61122
PE
11385 (find_automatic_composition): Mark vars as initialized,
11386 with a FIXME (Bug#8290).
8f5201ae 11387
760fbc2c
PE
11388 character.h: Rename locals to avoid shadowing.
11389 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11390 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11391 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11392 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11393 to avoid shadowing.
11394
ff08eb85
PE
11395 * textprop.c (property_change_between_p): Remove; unused.
11396
fc7bf025
PE
11397 * intervals.c (interval_start_pos): Now static.
11398
235d7abc
PE
11399 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11400
44f230aa
SM
11401 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11402 Rename locals to avoid shadowing.
3e7d6594 11403
50060332
PE
11404 * sound.c (wav_play, au_play, Fplay_sound_internal):
11405 Fix pointer signedness.
d01f234b 11406 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11407 (wav_play): Initialize a variable to 0, to prevent undefined
11408 behavior (Bug#8278).
50060332 11409
c4fc4e30
PE
11410 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11411
918436ed
PE
11412 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11413
c939f91b
PE
11414 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11415 clobbering (Bug#8298).
b9c7f648
PE
11416 * sysdep.c (sys_subshell): Likewise.
11417 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11418
6bd8c144
PE
11419 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11420 This should get cleaned up, so that child_setup has the
11421 same signature on all platforms.
11422
7710357c 11423 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11424 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11425
c59da222
CY
114262011-03-22 Chong Yidong <cyd@stupidchicken.com>
11427
11428 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11429 not to be necessary, and produces flickering.
11430
66b87493
GM
114312011-03-20 Glenn Morris <rgm@gnu.org>
11432
11433 * config.in: Remove file.
11434
45b6f6d5
JB
114352011-03-20 Juanma Barranquero <lekktu@gmail.com>
11436
11437 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11438 are now in src/globals.h.
11439 (syms_of_minibuf): Remove spurious & from previous change.
11440
cd394be1 114412011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11442
11443 * minibuf.c (completing-read-function): New variable.
11444 (completing-read-default): Rename from completing-read.
11445 (completing-read): Call completing-read-function.
11446
b14e3e21
CY
114472011-03-19 Juanma Barranquero <lekktu@gmail.com>
11448
11449 * xfaces.c (Fx_load_color_file):
11450 Read color file from absolute filename (bug#8250).
11451
f2b726e6
JB
114522011-03-19 Juanma Barranquero <lekktu@gmail.com>
11453
11454 * makefile.w32-in: Update dependencies.
11455
09f6ff02
EZ
114562011-03-17 Eli Zaretskii <eliz@gnu.org>
11457
11458 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11459
29a6015a
PE
114602011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11461
a3a6c54e
PE
11462 Fix more problems found by GCC 4.5.2's static checks.
11463
b766f867
PE
11464 * process.c (make_serial_process_unwind, send_process_trap):
11465 (sigchld_handler): Now static.
11466
be02381c
PE
11467 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11468 That way, the code declares only the vars that it needs.
11469 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11470 * s/cygwin.h (PTY_ITERATION): Likewise.
11471 * s/darwin.h (PTY_ITERATION): Likewise.
11472 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11473
57048744
PE
11474 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11475 * process.c (allocate_pty): Don't declare stb unless it's needed.
11476
7914961c 11477 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11478 (CONSTANTLIM): Remove; unused.
11479 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11480 Define only if needed.
7914961c 11481
b3967b18
PE
11482 * unexelf.c (unexec): Name an expression,
11483 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11484 Use a different way to cause a compilation error if anyone uses
11485 n rather than nn, a way that does not involve shadowing.
73366a00 11486 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11487
29a6015a
PE
11488 * deps.mk (unexalpha.o): Remove; unused.
11489
43cfc33e 11490 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11491 * unexec.h: New file.
ce701a33
PE
11492 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11493 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11494 Depend on unexec.h.
11495 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11496 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11497 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11498 Change as necessary to match prototype in unexec.h.
ce701a33 11499
01f44d5a
PE
11500 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11501 shadowing.
4f63c6bb 11502 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11503
a6670b0b
PE
11504 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11505 Rename locals to avoid shadowing.
11506
cef2010d 11507 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11508 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11509
d4d7173a
PE
11510 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11511
f08b802a
PE
11512 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11513 warning when compiling print.c.
11514
3ddb0639
PE
11515 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11516 instead of using an uninitialized var.
5ad03b97 11517 (font_sort_entities): Mark var as initialized.
3ddb0639 11518
170a2692
PE
11519 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11520
e663c700
PE
11521 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11522 pointers to constants.
89bc529a 11523 (font_parse_fcname): Remove unused vars.
7b81e2d0 11524 (font_delete_unmatched): Now static.
ea838e10 11525 (font_get_spec): Remove; unused.
13a547c6
PE
11526 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11527 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11528 Rename or move locals to avoid shadowing.
e663c700 11529
2a80c887 11530 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11531 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11532
1384fa33 11533 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11534 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11535
8b2c52e9
PE
11536 * alloc.c (mark_backtrace): Move decl from here ...
11537 * lisp.h: ... to here, so that it can be checked.
11538
475545b5 11539 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11540 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11541 (lisp_indirect_variable): Name an expression,
11542 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11543 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11544
b1349114 11545 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11546 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11547 Use const pointer when appropriate.
b1349114 11548
a2928364
PE
11549 * lisp.h (get_system_name, get_operating_system_release):
11550 Move decls here, to check interfaces.
11551 * process.c (get_operating_system_release): Move decl to lisp.h.
11552 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11553 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11554 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11555 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11556 (Fformat_time_string, Fencode_time, Finsert_char):
11557 (Ftranslate_region_internal, Fformat):
11558 Rename or remove local vars to avoid shadowing.
9710023e 11559 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11560
a415e694
PE
11561 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11562 avoid shadowing.
11563
8ef4622d
PE
11564 * lisp.h (eassert): Check that the argument compiles, even if
11565 ENABLE_CHECKING is not defined.
11566
946f9a5b
PE
11567 * data.c (Findirect_variable): Name an expression, to avoid
11568 gcc -Wbad-function-cast warning.
112396d6 11569 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11570 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11571 (Fmake_variable_buffer_local, Fmake_local_variable):
11572 Mark variables as initialized.
52746918 11573 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11574
e5aab7e7 11575 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11576 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11577 Rename locals to avoid shadowing.
dff45157
PE
11578 (mark_stack): Move local variables into the #ifdef region where
11579 they're used.
7bc26fdb
PE
11580 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11581 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11582 needed otherwise.
11583 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11584 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11585 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11586
e5aab7e7
PE
11587 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11588 avoids undefined behavior in theory.
11589
4da60324
PE
11590 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11591
88043301
PE
11592 Use functions, not macros, for up- and down-casing (Bug#8254).
11593 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11594 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11595 to use the following functions instead of these macros.
11596 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11597 EMACS_INT, since callers assume the returned value fits in int.
11598 (upcase1): Likewise, for UPCASE_TABLE.
11599 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11600 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11601 the race-condition problem in the old DOWNCASE.
88043301 11602
19ed5445
PE
11603 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11604 Rename locals to avoid shadowing.
11605 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11606 (regex_compile, re_search_2, re_match_2_internal):
11607 Remove unused local vars.
952db0d7
PE
11608 (FREE_VAR): Rewrite so as not to use empty "else",
11609 which gcc can warn about.
da053e48 11610 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11611 (RETALLOC_IF): Define only if needed.
11612 (WORDCHAR_P): Likewise. This one is never needed, but is used
11613 only in a comment talking about a compiler bug, so put inside
11614 the #if 0 of that comment.
11615 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11616 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11617 Remove; unused.
19ed5445 11618
1f3561e4 11619 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11620 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11621 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11622
ded6f8f7
PE
11623 * search.c (simple_search): Remove unused var.
11624
dbd37a95
PE
11625 * dired.c (compile_pattern): Move decl from here ...
11626 * lisp.h: ... to here, so that it can be checked.
11627 (struct re_registers): New forward decl.
11628
7e47afad
PE
11629 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11630
85f24f61
PE
11631 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11632 All uses changed.
11633 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11634 Rename locals to avoid shadowing.
5671df8f 11635 (Fvertical_motion): Mark locals as initialized.
85f24f61 11636
181aa2be 11637 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11638 (casify_region): Mark local as initialized.
181aa2be 11639
930d429c
PE
11640 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11641
7082eac6
PE
11642 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11643 New macros, so that the caller can use some names other than
11644 gcpro1, gcpro2, etc.
11645 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11646 of the new macros.
11647 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11648 argument, for consistency with GCPRO2_VAR, etc: it is now the
11649 prefix of the variable, not the variable itself. All uses
11650 changed.
38b2c076
PE
11651 * dired.c (directory_files_internal, file_name_completion):
11652 Rename locals to avoid shadowing.
11653
15206ed9
PE
11654 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11655 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11656 dired.c's scmp function, had undefined behavior.
11657 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11658 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11659 * buffer.h: ... to here, because these macros use current_buffer,
11660 and the new implementation with inline functions needs to have
11661 current_buffer in scope now, rather than later when the macros
11662 are used.
11663 (downcase, upcase1): New static inline functions.
11664 (DOWNCASE, UPCASE1): Reimplement using these functions.
11665 This avoids undefined behavior in expressions like
11666 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11667 from race conditions in accessing the global variables
11668 case_temp1 and case_temp2.
11669 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11670 * lisp.h (case_temp1, case_temp2): Remove their decls.
11671 * character.h (ASCII_CHAR_P): Move from here ...
11672 * lisp.h: ... to here, so that the inline functions mentioned
11673 above can use them.
11674
4a6bea26
PE
11675 * dired.c (directory_files_internal_unwind): Now static.
11676
f14b7e14
PE
11677 * fileio.c (file_name_as_directory, directory_file_name):
11678 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11679 Now static.
2893f146
PE
11680 (file_name_as_directory): Use const pointers when appropriate.
11681 (Fexpand_file_name): Likewise. In particular, newdir might
11682 point at constant storage, so make it a const pointer.
fd4ead52 11683 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11684 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11685 signedness issues.
f839df0c
PE
11686 (Fset_file_times, Finsert_file_contents, auto_save_error):
11687 Rename locals to avoid shadowing.
f14b7e14 11688
5716756e 11689 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11690 (Ftry_completion, Fall_completions): Rename or remove locals
11691 to avoid shadowing.
5716756e 11692
b4c3046a
PE
11693 * marker.c (bytepos_to_charpos): Remove; unused.
11694
b45db522
PE
11695 * lisp.h (verify_bytepos, count_markers): New decls,
11696 so that gcc does not warn that these functions aren't declared.
11697
85876d07
PE
11698 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11699 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11700 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11701 (copy_text): Remove unused local var.
85876d07 11702
03d78a21 11703 * filelock.c (within_one_second): Now static.
b3dd38ab 11704 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11705
5df8f01b
PE
11706 * buffer.c (fix_overlays_before): Mark locals as initialized.
11707 (fix_start_end_in_overlays): Likewise. This function should be
11708 simplified by using pointers-to-pointers, but that's a different
11709 matter.
b1d876f1 11710 (switch_to_buffer_1): Now static.
8f54f30a
PE
11711 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11712 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11713
a70072c9 11714 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11715 Fix pointer signedness issue.
edced198
PE
11716 (sys_subshell): Mark local as volatile if checking for lint,
11717 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11718 (MAXPATHLEN): Define only if needed.
a70072c9 11719
a0977c44
PE
11720 * process.c (serial_open, serial_configure): Move decls from here ...
11721 * systty.h: ... to here, so that they can be checked.
11722
a884fdcc
PE
11723 * fns.c (get_random, seed_random): Move extern decls from here ...
11724 * lisp.h: ... to here, so that they can be checked.
11725
604efe86 11726 * sysdep.c (reset_io): Now static.
b8950c94 11727 (wait_for_termination_signal): Remove; unused.
604efe86 11728
38fc62d9
PE
11729 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11730 (copy_keymap_item, append_key, push_text_char_description):
11731 Now static.
1004a21a 11732 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11733 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11734 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11735 (describe_map_tree):
11736 Rename locals to avoid shadowing.
38fc62d9 11737
2f2650da
PE
11738 * keyboard.c: Declare functions static if they are not used elsewhere.
11739 (echo_char, echo_dash, cmd_error, top_level_2):
11740 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11741 (read_char, kbd_buffer_get_event, make_lispy_position):
11742 (make_lispy_event, make_lispy_movement, apply_modifiers):
11743 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11744 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11745 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11746 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11747 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11748
a053e86c 11749 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11750 (mark_kboards): Move decl here ...
11751 * alloc.c (mark_kboards): ... from here.
a053e86c 11752
4752793e
PE
11753 * lisp.h (force_auto_save_soon): New decl.
11754
74f10ca7 11755 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11756 (DEFINE_DUMMY_FUNCTION): New macro.
11757 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11758 Use it.
c03cd23f
PE
11759 (main): Add casts to avoid warnings
11760 if GCC considers string literals to be constants.
74f10ca7 11761
022e70d4
PE
11762 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11763
59d6fe83
PE
11764 * dbusbind.c: Pointer signedness fixes.
11765 (xd_signature, xd_append_arg, xd_initialize):
11766 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11767 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11768 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11769 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11770
78320123
PE
11771 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11772 if GCC considers string literals to be constants.
49cebcca 11773 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11774
35ac2a97
SM
117752011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11776
fb103ca9
SM
11777 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11778 (print_preprocess, print_object): New macro to fix last change.
11779
35ac2a97
SM
11780 * print.c (print_preprocess): Don't forget font objects.
11781
62973b41
JB
117822011-03-16 Juanma Barranquero <lekktu@gmail.com>
11783
11784 * emacs.c (USAGE3): Doc fixes.
11785
0e48bb22
AS
117862011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11787
11788 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11789 structure.
11790
7684e57b
JB
117912011-03-14 Juanma Barranquero <lekktu@gmail.com>
11792
11793 * lisp.h (VWindow_system, Qfile_name_history):
11794 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11795 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11796 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11797
11798 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11799 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11800
11801 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11802 * w32console.c (detect_input_pending, read_input_pending)
11803 (encode_terminal_code):
11804 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11805 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11806 (w32_system_caret_y, Qfile_name_history):
11807 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11808 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11809 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11810 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11811 * w32proc.c (Qlocal, report_file_error):
11812 * w32term.c (Vwindow_system, updating_frame):
11813 * w32uniscribe.c (initialized, uniscribe_font_driver):
11814 Remove unneeded extern declarations.
11815
2aa46d6c
CY
118162011-03-14 Chong Yidong <cyd@stupidchicken.com>
11817
c96bbc66 11818 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11819
cffc6f3b
CY
118202011-03-13 Chong Yidong <cyd@stupidchicken.com>
11821
11822 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11823 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11824 These macros can no longer be used for assignment.
11825
44f230aa
SM
11826 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11827 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11828 (record_buffer_markers, fetch_buffer_markers): New functions for
11829 recording and fetching special buffer markers.
11830 (set_buffer_internal_1, set_buffer_temp): Use them.
11831
11832 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11833
11834 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11835
11836 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11837 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11838
11839 * xdisp.c (hscroll_window_tree):
11840 (reconsider_clip_changes): Use PT instead of BUF_PT.
11841
d251f04b
EZ
118422011-03-13 Eli Zaretskii <eliz@gnu.org>
11843
11844 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11845 $(EMACS_ROOT)/lib/intprops.h.
11846
f0c77cd1
PE
118472011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11848
3eca4629
PE
11849 Fix more problems found by GCC 4.5.2's static checks.
11850
7c86ee98
PE
11851 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11852 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11853 (xg_free_frame_widgets): Make it clear that a local variable is
11854 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11855 (gdk_window_get_screen): Make it clear that this macro is needed
11856 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11857 (int_gtk_range_get_value): New function, which avoids a diagnostic
11858 from gcc -Wbad-function-cast.
11859 (xg_set_toolkit_scroll_bar_thumb): Use it.
11860 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11861 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11862 (get_utf8_string, xg_get_file_with_chooser):
11863 Rename locals to avoid shadowing.
11864 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11865
41729b81
PE
11866 * xgselect.c (xg_select): Remove unused var.
11867
f0c77cd1
PE
11868 * image.c (four_corners_best): Mark locals as initialized.
11869 (gif_load): Initialize transparent_p to zero (Bug#8238).
11870 Mark another local as initialized.
ec6cf4c6 11871 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11872
ce0ad53d 11873 * image.c (clear_image_cache): Now static.
d5d5a617 11874 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11875 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11876 (x_edge_detection): Remove unnecessary cast that
11877 gcc -Wbad-function-cast diagnoses.
2037898d 11878 (gif_load): Fix pointer signedness.
6ae141d6
PE
11879 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11880 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11881
33383987 118822011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11883
d32df629
PE
11884 Improve quality of tests for time stamp overflow.
11885 For example, without this patch (encode-time 0 0 0 1 1
11886 1152921504606846976) returns the obviously-bogus value (-948597
11887 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11888 reports time overflow. See
11889 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11890 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11891 * editfns.c: Include limits.h and intprops.h.
11892 (TIME_T_MIN, TIME_T_MAX): New macros.
11893 (time_overflow): Move earlier, to before first use.
11894 (hi_time, lo_time): New functions, for an accurate test for
11895 out-of-range times.
11896 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11897 (Fget_internal_run_time): Don't assume time_t fits in int.
11898 (make_time): Use list2 instead of Fcons twice.
11899 (Fdecode_time): More accurate test for out-of-range times.
11900 (check_tm_member): New function.
11901 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11902 (lisp_time_argument): Don't rely on undefined left-shift and
11903 right-shift behavior when checking for time stamp overflow.
8be6f318 11904
fe31d94c
PE
11905 * editfns.c (time_overflow): New function, refactoring common code.
11906 (Fformat_time_string, Fdecode_time, Fencode_time):
11907 (Fcurrent_time_string): Use it.
11908
8be6f318
PE
11909 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11910 * dired.c (make_time): Move to ...
11911 * editfns.c (make_time): ... here.
11912 * systime.h: Note the move.
11913
09d9db2c 119142011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11915
126bc0dc
YM
11916 * fringe.c (update_window_fringes): Remove unused variables.
11917
c47cbdfd
YM
11918 * unexmacosx.c (copy_data_segment): Also copy __got section.
11919 (Bug#8223)
11920
7ac80be9
EZ
119212011-03-12 Eli Zaretskii <eliz@gnu.org>
11922
c96bbc66 11923 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11924 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11925 Constify `char *' arguments and their references according to
11926 prototypes in tparam.h.
11927
ecb0f94d 11928 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11929
7ac80be9
EZ
11930 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11931 Adapt all references accordingly.
11932
11933 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11934
ef1fd07e
TT
119352011-03-11 Tom Tromey <tromey@redhat.com>
11936
11937 * buffer.c (syms_of_buffer): Remove obsolete comment.
11938
7ef4b50c
EZ
119392011-03-11 Eli Zaretskii <eliz@gnu.org>
11940
11941 * termhooks.h (encode_terminal_code): Declare prototype.
11942
11943 * msdos.c (encode_terminal_code): Don't declare prototype.
11944
11945 * term.c (encode_terminal_code): Now external again, used by
11946 w32console.c and msdos.c.
11947
44f230aa
SM
11948 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11949 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11950
4b1ec863 119512011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11952
1714f52b 11953 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11954
4b1ec863
PE
11955 * fringe.c (update_window_fringes): Mark locals as initialized
11956 (Bug#8227).
11957 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11958
524c7aa6
PE
11959 * alloc.c (mark_fringe_data): Move decl from here ...
11960 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11961 to check its interface.
11962 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11963
a5c0af81 11964 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11965 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11966 (fontset_font): Mark local as initialized.
a9a06e0b 11967 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11968
b4716021
PE
11969 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11970
811e9bac 11971 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11972 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11973 (x_own_selection, Fx_disown_selection_internal): Rename locals
11974 to avoid shadowing.
11975 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11976
7e3ab302
PE
11977 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11978 so that the caller can use some name other than gcpro1.
11979 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11980 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11981 (Fx_backspace_delete_keys_p):
11982 Use them to avoid shadowing, and rename vars to avoid shadowing.
11983 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11984 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11985 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11986 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11987 Remove unused locals.
7e3ab302
PE
11988 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11989 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11990 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11991 macros.
f78faa98 11992
e2b13473
PE
11993 * xterm.h (x_mouse_leave): New decl.
11994
77f23912
PE
11995 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11996 Remove unused functions.
cdf4ba58
PE
11997 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11998 (x_calc_absolute_position): Now static.
7411c686 11999 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12000 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12001 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12002 unless they are used.
38d0b34a
PE
12003 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12004 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12005 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12006 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12007 (x_error_catcher, x_connection_closed, x_error_handler):
12008 (x_error_quitter, xembed_send_message, x_iconify_frame):
12009 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12010 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12011 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12012
44f230aa
SM
12013 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12014 Rename or move locals to avoid shadowing.
6b463e58 12015 (tty_defined_color, merge_face_heights): Now static.
5967d051 12016 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12017 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12018 does not deduce is never used uninitialized.
73719eba
PE
12019 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12020 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12021
426994c3 12022 * terminal.c (store_terminal_param): Now static.
5489860b 12023
032f1620 12024 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12025 (set_frame_menubar): Remove unused local.
d4323972 12026 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12027 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12028 since they might point to immutable storage.
281585b0
PE
12029 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12030 since it's unused otherwise.
032f1620 12031
367c19e5 12032 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12033 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12034 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12035 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12036 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12037 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12038 does not deduce are never used uninitialized.
70739cbe 12039
07b48fa9
PE
12040 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12041
8868a238 12042 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12043 * window.c (window_loop, size_window):
12044 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12045
7e5cf297 12046 * window.c (display_buffer): Now static.
d6550a9f
PE
12047 (size_window): Mark variables that gcc -Wuninitialized
12048 does not deduce are never used uninitialized.
a586633d
PE
12049 * window.h (check_all_windows): New decl, to forestall
12050 gcc -Wmissing-prototypes diagnostic.
5b555da1 12051 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12052
f6095868
PE
12053 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12054 shadowing.
12055 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12056 Include <limits.h>.
12057 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12058 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12059 (load_charset_map): Mark variables that gcc -Wuninitialized
12060 does not deduce are never used uninitialized.
53df7c11 12061 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12062
f38b440c
PE
12063 * coding.c (coding_set_source, coding_set_destination):
12064 Use "else { /* comment */ }" rather than "else /* comment */;"
12065 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12066 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12067 a block, when the outer 'i' will do.
12068 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12069 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12071 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12072 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12073 Rename locals to avoid shadowing.
12074 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12075 * coding.c (emacs_mule_char, encode_invocation_designation):
12076 Now static, since they're not used elsewhere.
413bb2db 12077 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12078 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12079 (decode_coding_emacs_mule): Mark variables that gcc
12080 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12081 (detect_coding_iso_2022): Initialize a local variable that might
12082 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12083 this initialization is needed. (Bug#8211)
5f58e762
PE
12084 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12085 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12086 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12087 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12088 Remove unused macros.
f38b440c 12089
232b38b9 12090 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12091 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12092 * character.c (string_count_byte8): Likewise.
232b38b9 12093
fb90da1b
PE
12094 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12095 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12096
fb93dbc2
PE
12097 * chartab.c (copy_sub_char_table): Now static, since it's not used
12098 elsewhere.
5c156ace
PE
12099 (sub_char_table_ref_and_range, char_table_ref_and_range):
12100 Rename locals to avoid shadowing.
bbcd0949 12101 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12102
7d3b3862 12103 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12104 (BIDI_BOB): Remove unused macro.
7d3b3862 12105
6be7d3da
PE
12106 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12107 deduce are never used uninitialized.
c2ed9c8b 12108 * term.c (encode_terminal_code): Likewise.
6be7d3da 12109
75f8807f 12110 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12111
50938595
PE
12112 * tparam.h: New file.
12113 * term.c, tparam.h: Include it.
12114 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12115 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12116 Move these decls to tparam.h, and make them agree with what
12117 is actually in tparam.c. The previous trick of using incompatible
12118 decls in different modules does not conform to the C standard.
12119 All callers of tparam changed to use tparam's actual API.
12120 * tparam.c (tparam1, tparam, tgoto):
12121 Use const pointers where appropriate.
12122
fbceeba2
PE
12123 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12124 * cm.h (struct cm): Likewise.
12125 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12126 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12127 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12128 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12129 (turn_on_face, init_tty): Likewise.
12130 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12131
7f3f1250
PE
12132 * term.c (term_mouse_position): Rename local to avoid shadowing.
12133
e6ca6543
PE
12134 * alloc.c (mark_ttys): Move decl from here ...
12135 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12136
c40f8d15
AS
121372011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12138
12139 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12140
cfe0661d
JB
121412011-03-09 Juanma Barranquero <lekktu@gmail.com>
12142
12143 * search.c (compile_pattern_1): Remove argument regp, unused since
12144 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12145 (compile_pattern): Don't pass it.
12146
0afb4571
J
121472011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12148
12149 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12150 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12151 for ! HAVE_GTK3.
12152 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12153
12154 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12155
12156 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12157 gdk_window_get_screen, gdk_window_get_geometry,
12158 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12159 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12160 (xg_get_pixbuf_from_pixmap): New function.
12161 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12162 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12163 Call xg_get_pixbuf_from_pixmap instead of
12164 gdk_pixbuf_get_from_drawable.
12165 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12166 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12167 (xg_check_special_colors): Use GtkStyleContext and its functions
12168 for HAVE_GTK3.
12169 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12170 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12171 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12172 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12173 Call gtk_widget_get_preferred_size.
0afb4571
J
12174 (xg_frame_resized): gdk_window_get_geometry only takes 5
12175 parameters.
44f230aa
SM
12176 (xg_win_to_widget, xg_event_is_for_menubar):
12177 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12178 (xg_set_widget_bg): New function.
12179 (delete_cb): New function.
895009e1 12180 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12181 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12182 (xg_set_background_color): Call xg_set_widget_bg.
12183 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12184 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12185 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12186 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12187 if ! HAVE_GTK3.
12188 (update_frame_tool_bar): Call gtk_widget_hide.
12189 (xg_initialize): Use GDK_KEY_g.
12190
12191 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12192 if ! HAVE_GTK3
12193 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12194
12195 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12196 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12197 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12198
1c2cc4ef
JB
121992011-03-08 Juanma Barranquero <lekktu@gmail.com>
12200
12201 * w32xfns.c (select_palette): Check success of RealizePalette against
12202 GDI_ERROR, not zero.
12203
33383987 12204See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12205
12206;; Local Variables:
12207;; coding: utf-8
aac0c6e3
MR
12208;; End:
12209
2f097256 12210 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12211
12212 This file is part of GNU Emacs.
12213
12214 GNU Emacs is free software: you can redistribute it and/or modify
12215 it under the terms of the GNU General Public License as published by
12216 the Free Software Foundation, either version 3 of the License, or
12217 (at your option) any later version.
12218
12219 GNU Emacs is distributed in the hope that it will be useful,
12220 but WITHOUT ANY WARRANTY; without even the implied warranty of
12221 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12222 GNU General Public License for more details.
12223
12224 You should have received a copy of the GNU General Public License
12225 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.