When the .authinfo file has a user name but not a password, prompt
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d5a19415
JM
12011-06-22 Jim Meyering <meyering@redhat.com>
2
3 don't leak an XBM-image-sized buffer
4 * image.c (xbm_load): Free the image buffer after using it.
5
a9041e6c
PE
62011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7
8 Port to Sun C.
9 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10 that Sun C diagnosed.
11 * fns.c (secure_hash): Fix pointer signedness issue.
12 * intervals.c (static_offset_intervals): New function.
13 (offset_intervals): Use it.
14
7f3f739f
LL
152011-06-21 Leo Liu <sdl.web@gmail.com>
16
17 * deps.mk (fns.o):
18 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
19 sha512.h.
20
21 * fns.c (secure_hash): Rename from crypto_hash_function and change
22 the first arg to accept symbols.
23 (Fsecure_hash): New primtive.
24 (syms_of_fns): New symbols.
25
76147d94
DD
262011-06-20 Deniz Dogan <deniz@dogan.se>
27
28 * process.c (Fset_process_buffer): Clarify return value in
29 docstring.
30
7d7d0045
CY
312011-06-18 Chong Yidong <cyd@stupidchicken.com>
32
33 * dispnew.c (add_window_display_history): Use BVAR.
34
35 * xdisp.c (debug_method_add): Use BVAR.
36 (check_window_end, dump_glyph_matrix, dump_glyph)
37 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
38
39 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
40 Likewise.
41
42 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
43 check till after the cache is created in init_frame_faces.
44
ff2bc410
SM
452011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
46
47 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
48
28177add
PE
492011-06-16 Paul Eggert <eggert@cs.ucla.edu>
50
dd3482fe
PE
51 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
52 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
53 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
54
393d71f3 55 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
56 * fileio.c (Finsert_file_contents):
57 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
58 Remove the old (too-loose) buffer overflow checks.
59 They weren't needed, since make_gap checks for buffer overflow.
60 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
61 The old code merely checked for Emacs fixnum overflow, and relied
62 on undefined (wraparound) behavior. The new code avoids undefined
63 behavior, and also checks for ptrdiff_t and/or size_t overflow.
64
2e6813b0 65 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
66 Tune. Don't use wider integers than needed. Don't use alloca.
67 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 68
599a9e4f
PE
69 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
70
99561444
PE
71 * insdel.c, lisp.h (buffer_overflow): New function.
72 (insert_from_buffer_1, replace_range, replace_range_2):
73 * insdel.c (make_gap_larger):
74 * editfns.c (Finsert_char):
75 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
76
28177add
PE
77 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
78
e69dafad
PE
792011-06-15 Paul Eggert <eggert@cs.ucla.edu>
80
a7af7fde 81 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 82
b1c46f02
PE
83 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
84 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
85
e69dafad
PE
86 * fileio.c: Don't assume EMACS_INT fits in off_t.
87 (emacs_lseek): New static function.
88 (Finsert_file_contents, Fwrite_region): Use it.
89 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
90
566684ea
PE
91 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
92
e6966cd6
PE
93 * fns.c: Don't overflow int when computing a list length.
94 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
95 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
96 truncation on 64-bit hosts. Check for QUIT every
97 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
98 faster and is responsive enough.
99 (Flength): Report an error instead of overflowing an integer.
100 (Fsafe_length): Return a float if the value is not representable
101 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 102 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 103 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 104
dd0b0efb
PE
105 * alloc.c: Check that resized vectors' lengths fit in fixnums.
106 (header_size, word_size): New constants.
107 (allocate_vectorlike): Don't check size overflow here.
108 (allocate_vector): Check it here instead, since this is the only
109 caller of allocate_vectorlike that could cause overflow.
110 Check that the new vector's length is representable as a fixnum.
111
86fe5cfe
PE
112 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
113 The previous code was bogus. For example, next_almost_prime (32)
114 returned 39, which is undesirable as it is a multiple of 3; and
115 next_almost_prime (24) returned 25, which is a multiple of 5 so
116 why was the code bothering to check for multiples of 7?
117
80e88859
PE
118 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
119
4a2f0ad6
PE
120 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
121
f66c7cf8
PE
122 Variadic C functions now count arguments with ptrdiff_t.
123 This partly undoes my 2011-03-30 change, which replaced int with size_t.
124 Back then I didn't know that the Emacs coding style prefers signed int.
125 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
126 were being counted with int, which may truncate counts on 64-bit
127 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
128 * lisp.h (struct Lisp_Subr.function.aMANY)
129 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
130 Arg counts are now ptrdiff_t, not size_t.
131 All variadic functions and their callers changed accordingly.
132 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
133 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
134 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
135 * callint.c (Fcall_interactively): Check arg count for overflow,
136 to avoid potential buffer overrun. Use signed char, not 'int',
137 for 'varies' array, so that we needn't bother to check its size
138 calculation for overflow.
139 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
140 * eval.c (apply_lambda):
141 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
142 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
143 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
144
a1759b76
PE
145 * callint.c (Fcall_interactively): Don't use index var as event count.
146
d96be9fc
PE
147 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
148 * mem-limits.h (SIZE): Remove; no longer used.
149
a690a978 150 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 151
578c21e6
PE
152 Remove unnecessary casts.
153 * xterm.c (x_term_init):
154 * xfns.c (x_set_border_pixel):
155 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
156 These aren't needed now that we assume ANSI C.
157
96f53c6c
PE
158 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
159 It's more likely to cause problems (due to unsigned overflow)
160 than to cure them.
161
83c77d31
PE
162 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
163
ee2079f1
PE
164 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
165
6da65536
PE
166 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
167
7147c4a4
PE
168 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
169
193e32d9
PE
170 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
171
e5533da6
PE
172 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
173
9910e595
PE
174 GLYPH_CODE_FACE returns EMACS_INT, not int.
175 * dispextern.h (merge_faces):
176 * xfaces.c (merge_faces):
01103c44
PE
177 * xdisp.c (get_next_display_element, next_element_from_display_vector):
178 Don't assume EMACS_INT fits in int.
9910e595 179
2638320e
PE
180 * character.h (CHAR_VALID_P): Remove unused parameter.
181 * fontset.c, lisp.h, xdisp.c: All uses changed.
182
045eb8d9
PE
183 * editfns.c (Ftranslate_region_internal): Omit redundant test.
184
c1f134b5
PE
185 * fns.c (concat): Minor tuning based on overflow analysis.
186 This doesn't fix any bugs. Use int to hold character, instead
187 of constantly refetching from Emacs object. Use XFASTINT, not
188 XINT, for value known to be a character. Don't bother comparing
189 a single byte to 0400, as it's always less.
190
395fcb93 191 * floatfns.c (Fexpt):
327eeec8
PE
192 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
193
abbd3d23
PE
194 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
195 for characters.
196
684a03ef
PE
197 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
198
0fed43f3
PE
199 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
200 Without this fix, on a 64-bit host (aset S 0 4294967386) would
201 incorrectly succeed when S was a string, because 4294967386 was
202 truncated before it was used.
203
8fd02eb7
PE
204 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
205 Otherwise, an out-of-range integer could cause undefined behavior
206 on a 64-bit host.
207
f8c86b69
PE
208 * composite.c: Use int, not EMACS_INT, for characters.
209 (fill_gstring_body, composition_compute_stop_pos): Use int, not
210 EMACS_INT, for values that are known to be in character range.
211 This doesn't fix any bugs but is the usual style inside Emacs and
212 may generate better code on 32-bit machines.
213
34206dd2
PE
214 Make sure a 64-bit char is never passed to ENCODE_CHAR.
215 This is for reasons similar to the recent CHAR_STRING fix.
216 * charset.c (Fencode_char): Check that character arg is actually
217 a character. Pass an int to ENCODE_CHAR.
218 * charset.h (ENCODE_CHAR): Verify that the character argument is no
219 wider than 'int', as a compile-time check to prevent future regressions
220 in this area.
221
c5958d4c 222 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
223
224 Make sure a 64-bit char is never passed to CHAR_STRING.
225 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
226 by silently ignoring the top 32 bits, allowing some values
227 that were far too large to be valid characters.
228 * character.h: Include <verify.h>.
229 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
230 arguments are no wider than unsigned, as a compile-time check
231 to prevent future regressions in this area.
232 * data.c (Faset):
01103c44 233 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
234 (Fsubst_char_in_region):
235 * fns.c (concat):
236 * xdisp.c (decode_mode_spec_coding):
237 Adjust to CHAR_STRING's new requirement.
238 * editfns.c (Finsert_char, Fsubst_char_in_region):
239 * fns.c (concat): Check that character args are actually
240 characters. Without this test, these functions did the wrong
241 thing with wildly out-of-range values on 64-bit hosts.
242
d37ca623
PE
243 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
244 These casts should not be needed on 32-bit hosts, either.
245 * keyboard.c (read_char):
246 * lread.c (Fload): Remove casts to unsigned.
247
ea204efb
PE
248 * lisp.h (UNSIGNED_CMP): New macro.
249 This fixes comparison bugs on 64-bit hosts.
250 (ASCII_CHAR_P): Use it.
251 * casefiddle.c (casify_object):
01103c44 252 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
253 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
254 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
255 * dispextern.h (FACE_FROM_ID):
256 * keyboard.c (read_char): Use UNSIGNED_CMP.
257
41cb286c
PE
258 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
259 not to EMACS_INT, to avoid GCC warning.
260
4a1b9832
PE
261 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
262
55daad71
PE
263 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
264 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
265 isn't needed on 32-bit machines.
8f95c75c 266
01103c44
PE
267 * buffer.c (Fgenerate_new_buffer_name):
268 Use EMACS_INT for count, not int.
0ceccced 269 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
270
271 * data.c (Qcompiled_function): Now static.
272
c6f072e7
PE
273 * window.c (window_body_lines): Now static.
274
20ce5912
PE
275 * image.c (gif_load): Rename local to avoid shadowing.
276
9c4c5f81
PE
277 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
278 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
279 * alloc.c (make_save_value): Integer argument is now of type
280 ptrdiff_t, not int.
281 (mark_object): Use ptrdiff_t, not int.
282 * lisp.h (pD): New macro.
283 * print.c (print_object): Use it.
284
c0c5c8ae
PE
285 * alloc.c: Use EMACS_INT, not int, to count objects.
286 (total_conses, total_markers, total_symbols, total_vector_size)
287 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
288 (total_free_floats, total_floats, total_free_intervals)
289 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
290 Now EMACS_INT, not int. All uses changed.
291 (Fgarbage_collect): Compute overall total using a double, so that
292 integer overflow is less likely to be a problem. Check for overflow
293 when converting back to an integer.
5a25e253
PE
294 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
295 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
296 These were 'int' variables that could overflow on 64-bit hosts;
297 they were never used, so remove them instead of repairing them.
211a0b2a 298 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
299 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
300 Previously, this ceilinged at INT_MAX, but that doesn't work on
301 64-bit machines.
e46bb31a 302 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 303
c78baabf 304 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 305 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
306 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
307 when a (possibly-narrower) signed value would do just as well.
308 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 309
c9d624c6
PE
310 * alloc.c: Catch some string size overflows that we were missing.
311 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
312 for convenience in STRING_BYTES_MAX.
313 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
314 The definition here is exact; the one in lisp.h was approximate.
315 (allocate_string_data): Check for string overflow. This catches
316 some instances we weren't catching before. Also, it catches
317 size_t overflow on (unusual) hosts where SIZE_MAX <= min
318 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
319 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 320
c9d624c6
PE
321 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
322 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
323 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
324
353032ce
PE
325 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
326
2bccce07
PE
327 * alloc.c (Fmake_string): Check for out-of-range init.
328
0ac30604
SM
3292011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
330
331 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
332
c195f2de
JD
3332011-06-14 Jan Djärv <jan.h.d@swipnet.se>
334
335 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
336 xg_get_default_scrollbar_width.
337
338 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
339 (int_gtk_range_get_value): Move to the scroll bar part of the file.
340 (style_changed_cb): Call update_theme_scrollbar_width and call
341 x_set_scroll_bar_default_width and xg_frame_set_char_size for
342 all frames (Bug#8505).
343 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
344 Call gtk_window_set_resizable if HAVE_GTK3.
345 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
346 and height if HAVE_GTK3 (Bug#8505).
347 (scroll_bar_width_for_theme): New variable.
348 (update_theme_scrollbar_width): New function.
349 (xg_get_default_scrollbar_width): Move code to
350 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
351 (xg_initialize): Call update_theme_scrollbar_width.
352
353 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
354
355 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
356
e10ac9f1
MR
3572011-06-12 Martin Rudalics <rudalics@gmx.at>
358
359 * frame.c (make_frame): Call other_buffer_safely instead of
360 other_buffer.
361
362 * window.c (temp_output_buffer_show): Call display_buffer with
363 second argument Vtemp_buffer_show_specifiers and reset latter
364 immediately after the call.
365 (Vtemp_buffer_show_specifiers): New variable.
366 (auto_window_vscroll_p, next_screen_context_lines)
367 (Vscroll_preserve_screen_position): Remove leading asterisks from
368 doc-strings.
369
2d3c217e 3702011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 371
7b7f97e8 372 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
373 * buffer.c (Qclone_number): Remove for now, as it's unused.
374 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
375 (record_buffer): Remove unused local.
376 * frame.c (other_visible_frames, frame_buffer_list): Now static.
377 (set_frame_buffer_list): Remove; unused.
378 * frame.h (other_visible_frames): Remove decl.
379 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
380 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
381 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
382 if HAVE_GPM.
383 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
384 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
385 Define only if HAVE_GPM.
386 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
387 (update_hints_inhibit): Remove; never set. All uses removed.
388 * widgetprv.h (emacsFrameClassRec): Remove decl.
389 * window.c (delete_deletable_window): Now returns void, since it
390 wasn't returning anything.
391 (compare_window_configurations): Remove unused locals.
392 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
393 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
394 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
395 the same widths as pointers. This follows up on the 2011-05-06 patch.
396 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
397 * xterm.h: Likewise.
398 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
399
1384b89e
JB
4002011-06-12 Juanma Barranquero <lekktu@gmail.com>
401
402 * makefile.w32-in: Update dependencies.
403 (LISP_H): Add lib/intprops.h.
404
1100a63c
CY
4052011-06-11 Chong Yidong <cyd@stupidchicken.com>
406
407 * image.c (gif_load): Add animation frame delay to the metadata.
408 (syms_of_image): Use DEFSYM. New symbol `delay'.
409
6198ccd0
MR
4102011-06-11 Martin Rudalics <rudalics@gmx.at>
411
412 * window.c (delete_deletable_window): Re-add.
413 (Fset_window_configuration): Rewrite to handle dead buffers and
414 consequently deletable windows.
415 (window_tree, Fwindow_tree): Remove. Supply functionality in
416 window.el.
417 (compare_window_configurations): Simplify code.
418
b6e3633c
AS
4192011-06-11 Andreas Schwab <schwab@linux-m68k.org>
420
1ab0dee5
AS
421 * image.c (imagemagick_load_image): Fix type mismatch.
422 (Fimagemagick_types): Likewise.
423
b6e3633c
AS
424 * window.h (replace_buffer_in_windows): Declare.
425
9397e56f
MR
4262011-06-11 Martin Rudalics <rudalics@gmx.at>
427
428 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
429 Qclone_number. Remove external declaration of Qdelete_window.
430 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
431 code.
432 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
433 Qbuffer_list_update_hook if allowed.
434 (Fother_buffer): Rewrite doc-string. Major rewrite for new
435 buffer list implementation.
436 (other_buffer_safely): New function.
437 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
438 calls to replace_buffer_in_windows and
439 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
440 if allowed.
441 (record_buffer): Inhibit quitting and rewrite using quittable
442 functions. Run Qbuffer_list_update_hook if allowed.
443 (Frecord_buffer, Funrecord_buffer): New functions.
444 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
445 switch-to-buffer to window.el.
446 (bury-buffer): Move to window.el.
447 (Vbuffer_list_update_hook): New variable.
448
449 * lisp.h (other_buffer_safely): Add prototype in buffer.c
450 section.
451
452 * window.h (resize_frame_windows): Move up in code.
453 (Fwindow_frame): Remove EXFUN.
454 (replace_buffer_in_all_windows): Remove prototype.
455 (replace_buffer_in_windows_safely): Add prototype.
456
457 * window.c: Declare Qdelete_window static again. Move down
458 declaration of select_count.
459 (Fnext_window, Fprevious_window): Rewrite doc-strings.
460 (Fother_window): Move to window.el.
461 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
462 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
463 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
464 window.el.
465 (replace_buffer_in_windows): Implement by calling
466 Qreplace_buffer_in_windows.
467 (replace_buffer_in_all_windows): Remove with some functionality
468 moved into replace_buffer_in_windows_safely.
469 (replace_buffer_in_windows_safely): New function.
470 (select_window_norecord, select_frame_norecord): Move in front
471 of run_window_configuration_change_hook. Remove now obsolete
472 declarations.
473 (Fset_window_buffer): Rewrite doc-string. Call
474 Qrecord_window_buffer.
475 (keys_of_window): Move binding for other-window to window.el.
476
b50691aa
CY
4772011-06-11 Chong Yidong <cyd@stupidchicken.com>
478
479 * dispextern.h (struct image): Replace data member, whose int_val
480 and ptr_val fields were not used by anything, with a single
481 lisp_val object.
482
483 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
484 (gif_clear_image, gif_load, imagemagick_load_image)
485 (gs_clear_image, gs_load): Callers changed.
486
3f754b86
PE
4872011-06-10 Paul Eggert <eggert@cs.ucla.edu>
488
cca69397
PE
489 * buffer.h: Include <time.h>, for time_t.
490 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
491
109e28d0
PE
492 Fix minor problems found by static checking.
493
60737f02
PE
494 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
495
4b66faf3
PE
496 Make identifiers static if they are not used in other modules.
497 * data.c (Qcompiled_function, Qframe, Qvector):
498 * image.c (QimageMagick, Qsvg):
499 * minibuf.c (Qmetadata):
500 * window.c (resize_window_check, resize_root_window): Now static.
501 * window.h (resize_window_check, resize_root_window): Remove decls.
502
109e28d0
PE
503 * window.c (window_deletion_count, delete_deletable_window):
504 Remove; unused.
46a4ce9e
PE
505 (window_body_lines): Now static.
506 (Fdelete_other_windows_internal): Mark vars as initialized.
507 Make sure 'resize_failed' is initialized.
508 (run_window_configuration_change_hook): Rename local to avoid shadowing.
509 (resize_window_apply): Remove unused local.
510 * window.h (delete_deletable_window): Remove decl.
511
109e28d0 512 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
513 (imagemagick_load_image): Fix pointer signedness problem by changing
514 last arg from unsigned char * to char *. All uses changed.
515 Also, fix a local for similar reasons.
516 Remove unused locals. Remove locals to avoid shadowing.
517 (fn_rsvg_handle_free): Remove; unused.
518 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 519 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 520
3f754b86
PE
521 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
522
2547adb1
CY
5232011-06-10 Chong Yidong <cyd@stupidchicken.com>
524
525 * image.c (gif_load): Fix omitted cast error introduced by
526 2011-06-06 change.
527
2c8e37d4
MR
5282011-06-10 Martin Rudalics <rudalics@gmx.at>
529
530 * window.h (resize_proportionally, orig_total_lines)
531 (orig_top_line): Remove from window structure.
532 (set_window_height, set_window_width, change_window_heights)
533 (Fdelete_window): Remove prototypes.
534 (resize_frame_windows): Remove duplicate declaration.
535
440a42e3
EZ
5362011-06-10 Eli Zaretskii <eliz@gnu.org>
537
538 * window.h (resize_frame_windows, resize_window_check)
539 (delete_deletable_window, resize_root_window)
540 (resize_frame_windows): Declare prototypes.
541
542 * window.c (resize_window_apply): Make definition be "static" to
543 match the prototype.
544
562dd5e9
MR
5452011-06-10 Martin Rudalics <rudalics@gmx.at>
546
547 * window.c: Remove declarations of Qwindow_size_fixed,
548 window_min_size_1, window_min_size_2, window_min_size,
549 size_window, window_fixed_size_p, enlarge_window, delete_window.
550 Remove static from declaration of Qdelete_window, it's
551 temporarily needed by Fbury_buffer.
552 (replace_window): Don't assign orig_top_line and
553 orig_total_lines.
554 (Fdelete_window, delete_window): Remove. Window deletion is
555 handled by window.el.
556 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
557 Fdelete_window calls with calls to Qdelete_window.
558 (Fdelete_other_windows): Remove. Deleting other windows is
559 handled by window.el.
560 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
561 handled in window.el.
562 (window_min_size_2, window_min_size_1, window_min_size): Remove.
563 Window minimum sizes are handled in window.el.
564 (shrink_windows, size_window, set_window_height)
565 (set_window_width, change_window_heights, window_height)
566 (window_width, CURBEG, CURSIZE, enlarge_window)
567 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
568 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
569 handled in window.el.
570 (make_dummy_parent): Rename to make_parent_window and give it a
571 second argument horflag.
572 (make_window): Don't set resize_proportionally any more.
573 (Fsplit_window): Remove. Windows are split in window.el.
574 (save_restore_action, save_restore_orig_size)
575 (shrink_window_lowest_first, save_restore_orig_size): Remove.
576 Resize mini windows in window.el.
577 (grow_mini_window, shrink_mini_window): Implement by calling
578 Qresize_root_window_vertically, resize_window_check and
579 resize_window_apply.
580 (saved_window, Fset_window_configuration, save_window_save): Do
581 not handle orig_top_line, orig_total_lines, and
582 resize_proportionally.
583 (window_min_height, window_min_width): Move to window.el.
584 (keys_of_window): Move bindings for delete-other-windows,
585 split-window, delete-window and enlarge-window to window.el.
586
587 * buffer.c: Temporarily extern Qdelete_window.
588 (Fbury_buffer): Temporarily call Qdelete_window instead of
589 Fdelete_window (Fbury_buffer will move to window.el soon).
590
591 * frame.c (set_menu_bar_lines_1): Remove code handling
592 orig_top_line and orig_total_lines.
593
594 * dispnew.c (adjust_frame_glyphs_initially): Don't use
595 set_window_height but set heights directly.
596 (change_frame_size_1): Use resize_frame_windows.
597
598 * xdisp.c (init_xdisp): Don't use set_window_height but set
599 heights directly.
600
601 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
602 resize_frame_windows instead of change_window_heights and run
603 run_window_configuration_change_hook.
604
605 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
606 instead of change_window_heights and run
607 run_window_configuration_change_hook.
608
1a13852e
MR
6092011-06-09 Martin Rudalics <rudalics@gmx.at>
610
611 * window.c (replace_window): Rename second argument REPLACEMENT to
612 NEW. New third argument SETFLAG. Rewrite.
613 (delete_window, make_dummy_parent): Call replace_window with
614 third argument 1.
615 (window_list_1): Move down in code.
616 (run_window_configuration_change_hook): Move set_buffer part
617 before select_frame_norecord part in order to unwind correctly.
618 Rename count1 to count.
619 (recombine_windows, delete_deletable_window, resize_root_window)
620 (Fdelete_other_windows_internal)
621 (Frun_window_configuration_change_hook, make_parent_window)
622 (resize_window_check, resize_window_apply, Fresize_window_apply)
623 (resize_frame_windows, Fsplit_window_internal)
624 (Fdelete_window_internal, Fresize_mini_window_internal): New
625 functions.
626 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
627
f3d1777e
MR
6282011-06-08 Martin Rudalics <rudalics@gmx.at>
629
496e208e
MR
630 * window.h (window): Add some new members to window structure -
631 normal_lines, normal_cols, new_total, new_normal, clone_number,
632 splits, nest, prev_buffers, next_buffers.
633 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 634 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 635
f3d1777e
MR
636 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
637 Remove.
496e208e
MR
638 (make_dummy_parent): Set new members of windows structure.
639 (make_window): Move down in code. Handle new members of window
640 structure.
641 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
642 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
643 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
644 (Fset_window_prev_buffers, Fwindow_next_buffers)
645 (Fset_window_next_buffers, Fset_window_clone_number): New
646 functions.
647 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
648 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
649 Doc-string fixes.
650 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
651 Argument WINDOW can be now internal window too.
652 (Fwindow_use_time): Move up in code.
653 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
654 Rewrite doc-string.
655 (Fset_window_configuration, saved_window)
656 (Fcurrent_window_configuration, save_window_save): Handle new
657 members of window structure.
b9e809c2
MR
658 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
659 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
660 (syms_of_window): New Lisp objects Qrecord_window_buffer,
661 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
662 Qget_mru_window, Qresize_root_window,
663 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
664 Qauto_buffer_name; staticpro them.
f3d1777e 665
abde8f8c
MR
6662011-06-07 Martin Rudalics <rudalics@gmx.at>
667
668 * window.c (Fwindow_total_size, Fwindow_left_column)
669 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
670 (Fwindow_list_1): New functions.
671 (window_box_text_cols): Replace with window_body_cols.
672 (Fwindow_width, Fscroll_left, Fscroll_right): Use
673 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
674 (delete_window, Fset_window_configuration): Call
675 delete_all_subwindows with window as argument.
676 (delete_all_subwindows): Take a window as argument and not a
677 structure. Rewrite.
190b47e6
MR
678 (window_loop): Remove handling of GET_LRU_WINDOW and
679 GET_LARGEST_WINDOW.
680 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
681
682 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
683 window_box_text_cols. delete_all_subwindows now takes a
684 Lisp_Object as argument.
abde8f8c
MR
685
686 * indent.c (compute_motion, Fcompute_motion): Use
687 window_body_cols instead of window_box_text_cols.
688
fa8a67e6
MR
689 * frame.c (delete_frame): Call delete_all_subwindows with root
690 window as argument.
691
a54e3482
DC
6922011-06-07 Daniel Colascione <dan.colascione@gmail.com>
693
694 * fns.c (Fputhash): Document return value.
695
60002bf5
CY
6962011-06-06 Chong Yidong <cyd@stupidchicken.com>
697
698 * image.c (gif_load): Implement gif89a spec "no disposal" method.
699
0c671da6 7002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 701
b862a52a 702 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 703
be44ca6c
PE
704 Check for overflow when converting integer to cons and back.
705 * charset.c (Fdefine_charset_internal, Fdecode_char):
706 Use cons_to_unsigned to catch overflow.
707 (Fencode_char): Use INTEGER_TO_CONS.
708 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
709 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
710 * data.c (long_to_cons, cons_to_long): Remove.
711 (cons_to_unsigned, cons_to_signed): New functions.
712 These signal an error for invalid or out-of-range values.
713 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
714 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
715 * font.c (Ffont_variation_glyphs):
716 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
717 * lisp.h: Include <intprops.h>.
718 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
719 (cons_to_signed, cons_to_unsigned): New decls.
720 (long_to_cons, cons_to_long): Remove decls.
721 * undo.c (record_first_change): Use INTEGER_TO_CONS.
722 (Fprimitive_undo): Use CONS_TO_INTEGER.
723 * xfns.c (Fx_window_property): Likewise.
724 * xselect.c: Include <limits.h>.
725 (x_own_selection, selection_data_to_lisp_data):
726 Use INTEGER_TO_CONS.
727 (x_handle_selection_request, x_handle_selection_clear)
728 (x_get_foreign_selection, Fx_disown_selection_internal)
729 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
730 (lisp_data_to_selection_data): Use cons_to_unsigned.
731 (x_fill_property_data): Use cons_to_signed.
732 Report values out of range.
733
d1f3d2af
PE
734 Check for buffer and string overflow more precisely.
735 * buffer.h (BUF_BYTES_MAX): New macro.
736 * lisp.h (STRING_BYTES_MAX): New macro.
737 * alloc.c (Fmake_string):
738 * character.c (string_escape_byte8):
739 * coding.c (coding_alloc_by_realloc):
740 * doprnt.c (doprnt):
741 * editfns.c (Fformat):
742 * eval.c (verror):
743 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
744 since they may not be the same number.
745 * editfns.c (Finsert_char):
746 * fileio.c (Finsert_file_contents):
747 Likewise for BUF_BYTES_MAX.
748
dd52fcea
PE
749 * image.c: Use ptrdiff_t, not int, for sizes.
750 (slurp_file): Switch from int to ptrdiff_t.
751 All uses changed.
752 (slurp_file): Check that file size fits in both size_t (for
753 malloc) and ptrdiff_t (for sanity and safety).
754
7f9bbdbb
PE
755 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
756 if b->modtime has its maximal value.
757
dfe18f82
PE
758 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
759
84acfcf0
PE
760 Don't assume time_t can fit into int.
761 * buffer.h (struct buffer.modtime): Now time_t, not int.
762 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
763 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
764
ccd9a01a
PE
765 Minor fixes for signed vs unsigned integers.
766 * character.h (MAYBE_UNIFY_CHAR):
767 * charset.c (maybe_unify_char):
768 * keyboard.c (read_char, reorder_modifiers):
769 XINT -> XFASTINT, since the integer must be nonnegative.
770 * ftfont.c (ftfont_spec_pattern):
771 * keymap.c (access_keymap, silly_event_symbol_error):
772 XUINT -> XFASTINT, since the integer must be nonnegative.
773 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
774 since it makes no difference and we prefer signed.
775 * keyboard.c (record_char): Use XUINT when all the neighbors do.
776 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
777 nonnegative.
778
d6d100dd
SM
7792011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
780
781 * window.h (Fwindow_frame): Declare.
782
2b6148e4
PE
7832011-06-06 Paul Eggert <eggert@cs.ucla.edu>
784
785 * alloc.c: Simplify handling of large-request failures (Bug#8800).
786 (SPARE_MEMORY): Always define.
787 (LARGE_REQUEST): Remove.
788 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
789
f230ecc9
MR
7902011-06-06 Martin Rudalics <rudalics@gmx.at>
791
727e958e
MR
792 * lisp.h: Move EXFUNS for Fframe_root_window,
793 Fframe_first_window and Fset_frame_selected_window to window.h.
794
795 * window.h: Move EXFUNS for Fframe_root_window,
796 Fframe_first_window and Fset_frame_selected_window here from
797 lisp.h.
798
799 * frame.c (Fwindow_frame, Fframe_first_window)
800 (Fframe_root_window, Fframe_selected_window)
801 (Fset_frame_selected_window): Move to window.c.
802 (Factive_minibuffer_window): Move to minibuf.c.
803 (Fother_visible_frames_p): New function.
804
805 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
806
f230ecc9
MR
807 * window.c (decode_window, decode_any_window): Move up in code.
808 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
809 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
810 (Fwindow_buffer): Move up and rewrite doc-string.
811 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
812 (Fwindow_prev): New functions.
727e958e
MR
813 (Fwindow_frame): Move here from frame.c. Accept any window as
814 argument.
815 (Fframe_root_window, Fframe_first_window)
816 (Fframe_selected_window): Move here from frame.c. Accept frame
817 or arbitrary window as argument. Update doc-strings.
818 (Fminibuffer_window): Move up in code.
819 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
820 (Fset_frame_selected_window): Move here from frame.c.
821 Marginal rewrite.
727e958e
MR
822 (Fselected_window, select_window, Fselect_window): Move up in
823 code. Minor doc-string fixes.
f230ecc9 824
4d09bcf6
PE
8252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
826
827 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
828 Do not assume that spare memory exists; that assumption is valid
829 only if SYSTEM_MALLOC.
830 (LARGE_REQUEST): New macro, so that the issue of large requests
831 is separated from the issue of spare memory.
832
810928a2
AS
8332011-06-05 Andreas Schwab <schwab@linux-m68k.org>
834
172418ad
AS
835 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
836 format. (Bug#8806)
837
43f862f7
AS
838 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
839
810928a2
AS
840 * xfns.c (x_set_scroll_bar_default_width): Move declarations
841 before statements.
842
a059fe24
JD
8432011-06-05 Jan Djärv <jan.h.d@swipnet.se>
844
845 * gtkutil.c (xg_get_default_scrollbar_width): New function.
846
847 * gtkutil.h: Declare xg_get_default_scrollbar_width.
848
849 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
850 min width by calling x_set_scroll_bar_default_width (Bug#8505).
851
989bf368
JB
8522011-06-05 Juanma Barranquero <lekktu@gmail.com>
853
854 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
855
4b80f674
CY
8562011-06-04 Chong Yidong <cyd@stupidchicken.com>
857
858 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
859 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
860 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
861 New error handlers.
4b80f674
CY
862 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
863 Obey Vx_select_enable_clipboard_manager. Catch errors in
864 x_clipboard_manager_save (Bug#8779).
865 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 866 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 867
99a33b77 8682011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
869
870 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
871
99a33b77 8722011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
873
874 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
875 in the current matrix if keep_current_p is non-zero.
876
8264569d
EZ
8772011-06-04 Eli Zaretskii <eliz@gnu.org>
878
879 * bidi.c (bidi_level_of_next_char): Fix last change.
880
57f97249
EZ
8812011-06-03 Eli Zaretskii <eliz@gnu.org>
882
fec2107c 883 Support bidi reordering of text covered by display properties.
57f97249 884
fec2107c
EZ
885 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
886 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
887 (bidi_cache_search, bidi_cache_iterator_state)
888 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
889 (bidi_level_of_next_char, bidi_move_to_visually_next):
890 Support character positions inside a run of characters covered by a
fec2107c
EZ
891 display string.
892 (bidi_paragraph_init, bidi_resolve_explicit_1)
893 (bidi_level_of_next_char): Call bidi_fetch_char and
894 bidi_fetch_char_advance instead of FETCH_CHAR and
895 FETCH_CHAR_ADVANCE.
896 (bidi_init_it): Initialize new members.
897 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
898 definitions.
899 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
900 instead of using explicit *_CHAR codes.
d6d100dd
SM
901 (bidi_resolve_explicit, bidi_resolve_weak):
902 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
903 bidirectional text is supported only in multibyte buffers.
904 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
905 it to initialize the frame_window_p member of struct bidi_it.
906 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
907 (bidi_resolve_explicit, bidi_resolve_weak)
908 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
909 bidi_it->nchars is non-positive.
910 (bidi_level_of_next_char): Don't try to lookup the cache for the
911 next/previous character if nothing is cached there yet, or if we
912 were just reseat()'ed to a new position.
c40e2fb2 913
0e14fe90
EZ
914 * xdisp.c (set_cursor_from_row): Set start and stop points
915 according to the row's direction when priming the loop that looks
916 for the glyph on which to display cursor.
917 (single_display_spec_intangible_p): Function deleted.
918 (display_prop_intangible_p): Reimplement to call
919 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
920 Accept 3 additional arguments needed by handle_display_spec.
921 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
922 values: lists, `(when COND...)' forms, etc.
923 (single_display_spec_string_p): Support property values that are
924 lists with the argument STRING its top-level element.
925 (display_prop_string_p): Fix the condition for processing a
926 property that is a list to be consistent with handle_display_spec.
fec2107c 927 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
928 last portion of handle_display_prop.
929 (compute_display_string_pos): Accept additional argument
930 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
931 value of a `display' property is a "replacing spec".
932 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
933 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
934 the display property, but just return a value indicating whether
935 the display property will replace the characters it covers.
936 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
937 frame_window_p members of struct bidi_it.
d6d100dd
SM
938 (compute_display_string_pos, compute_display_string_end):
939 New functions.
fec2107c
EZ
940 (push_it): Accept second argument POSITION, where pop_it should
941 jump to continue iteration.
942 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 943
fec2107c
EZ
944 * keyboard.c (adjust_point_for_property): Adjust the call to
945 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
946
947 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
948 (bidi_init_it): Update prototypes.
949 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
950 (compute_display_string_pos, compute_display_string_end):
951 Declare prototypes.
fec2107c
EZ
952 (struct bidi_it): New members nchars and disp_pos. ch_len is now
953 EMACS_INT.
fc6f18ce 954
40087514 9552011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 956
57f53182
PE
957 Malloc failure behavior now depends on size of allocation.
958 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
959 * lisp.h: Change signatures accordingly.
960 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
961 All callers changed. (Bug#8762)
962
963 * gnutls.c: Use Emacs's memory allocators.
964 Without this change, the gnutls library would invoke malloc etc.
965 directly, which causes problems on non-SYNC_INPUT hosts, and which
966 runs afoul of improving memory_full behavior. (Bug#8761)
967 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
968 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
969 xfree instead of the default malloc, realloc, free.
970 (Fgnutls_boot): No need to check for memory allocation failure,
971 since xmalloc does that for us.
972
ac32cd99 973 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
974 * category.c (hash_get_category_set):
975 * ccl.c (ccl_driver):
976 * charset.c (Fdefine_charset_internal):
977 * charset.h (struct charset.hash_index):
978 * composite.c (get_composition_id, gstring_lookup_cache)
979 (composition_gstring_put_cache):
980 * composite.h (struct composition.hash_index):
981 * dispextern.h (struct image.hash):
982 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
983 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
984 (hashfn_equal, hashfn_user_defined, make_hash_table)
985 (maybe_resize_hash_table, hash_lookup, hash_put)
986 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
987 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
988 (Fsxhash, Fgethash, Fputhash, Fmaphash):
989 * image.c (make_image, search_image_cache, lookup_image)
990 (xpm_put_color_table_h):
991 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 992 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
993 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
994 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
995 * alloc.c (allocate_vectorlike):
996 Check for overflow in vector size calculations.
997 * ccl.c (ccl_driver):
998 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
999 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1000 need to be updated by these changes.
40087514
PE
1001 * fns.c (make_hash_table, maybe_resize_hash_table):
1002 Check for integer overflow with large hash tables.
0de4bb68
PE
1003 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1004 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1005 (SXHASH_REDUCE): New macro.
1006 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1007 Use it instead of discarding useful hash info with large hash values.
1008 (sxhash_float): New function.
1009 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1010 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1011 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1012 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1013 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1014 Adjust signatures to match updated version of code.
1015 (consing_since_gc): Now EMACS_INT, since a single hash table can
1016 use more than INT_MAX bytes.
1017
698d32e2
DN
10182011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1019
1020 Make it possible to build with GCC-4.6+ -O2 -flto.
1021
1022 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1023
fd6fa53f
SM
10242011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1025
1026 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1027 Call minibuffer-inactive-mode.
1028
864db017
JB
10292011-05-31 Juanma Barranquero <lekktu@gmail.com>
1030
1031 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1032 Update dependencies.
1033
2ad0baf4
DN
10342011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1035
1036 * data.c (init_data): Remove code for UTS, this system is not
1037 supported anymore.
1038
4fcc2638
DN
10392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1040
1041 Don't force ./temacs to start in terminal mode.
1042
1043 * frame.c (make_initial_frame): Initialize faces in all cases, not
1044 only when CANNOT_DUMP is defined.
1045 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1046
c56e0fd5
DN
10472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1048
1049 * dispnew.c (add_window_display_history): Use const for the string
1050 pointer. Remove declaration, not needed.
1051
333d54da 10522011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1053
55d4c1b2 1054 Use 'inline', not 'INLINE'.
333d54da 1055 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1056 * alloc.c, fontset.c (INLINE): Remove.
1057 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1058 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1059 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1060 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1061 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1062
738db178
DN
10632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1064
1065 Make it possible to run ./temacs.
1066
1067 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1068 syms_of_callproc does the same thing. Remove test for
1069 "initialized", do it in the caller.
1070 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1071
620c53a6
SM
10722011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1073
1074 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1075 (read_minibuf): Use get_minibuffer.
1076 (syms_of_minibuf): Use DEFSYM.
1077 (Qmetadata): New var.
1078 * data.c (Qbuffer): Don't make it static.
1079 (syms_of_data): Use DEFSYM.
1080
e003a292
PE
10812011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1084 (CCL_CODE_MIN): New macro.
1085
ed008a6d
PE
10862011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1087
3687c2ef
PE
1088 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1089
ed008a6d
PE
1090 * eval.c (Qdebug): Now static.
1091 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1092 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1093 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1094
d66c4c7c
CY
10952011-05-29 Chong Yidong <cyd@stupidchicken.com>
1096
1097 * image.c: Various fixes to ImageMagick code comments.
1098 (Fimagemagick_types): Doc fix.
1099
5fbc2025
PE
11002011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1101
0196f88a
PE
1102 Minor fixes prompted by GCC 4.6.0 warnings.
1103
1104 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1105
5fbc2025
PE
1106 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1107 (x_clipboard_manager_save_all): Move extern decl to ...
1108 * xterm.h: ... here, so that it can be checked for consistency.
1109
1dd3c2d9
CY
11102011-05-29 Chong Yidong <cyd@stupidchicken.com>
1111
1112 * xselect.c (x_clipboard_manager_save_frame)
1113 (x_clipboard_manager_save_all): New functions.
1114 (Fx_clipboard_manager_save): Lisp function deleted.
1115
1116 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1117 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1118
1119 * xterm.h: Update prototype.
1120
5ba6571d
WX
11212011-05-28 William Xu <william.xwl@gmail.com>
1122
1123 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1124 exiting (Bug#8239).
1125
3eaff834
JM
11262011-05-28 Jim Meyering <meyering@redhat.com>
1127
e1900994 1128 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1129 * fns.c (to_uchar): Define.
1130 (crypto_hash_function): Use it to convert some newly-signed
1131 variables to unsigned, to avoid sign-extension bugs. For example,
1132 without this change, (md5 "truc") would evaluate to
1133 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1134 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1135 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1136
0f6990a7
PE
11372011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1138
1139 Integer overflow fixes.
c8a9ca5a 1140
08686060
PE
1141 * dbusbind.c: Serial number integer overflow fixes.
1142 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1143 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1144 to hold a serial number that is too large for a fixnum.
1145 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1146 Check for serial numbers out of range. Decode any serial number
59568bf0 1147 that was so large that it became a float. (Bug#8722)
08686060 1148
2d1fc3c7
PE
1149 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1150 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1151 Use XFASTINT rather than XUINT when numbers are nonnegative.
1152 (xd_append_arg, Fdbus_method_return_internal):
1153 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1154 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1155 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1156 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1157 (Bug#8722)
2d1fc3c7 1158
c8a9ca5a
PE
1159 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1160
519e1d69
PE
1161 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1162
30569699
PE
1163 ccl: add integer overflow checks
1164 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1165 (IN_INT_RANGE): New macros.
1166 (ccl_driver): Use them to check for integer overflow when
1167 decoding a CCL program. Many of the new checks are whether XINT (x)
1168 fits in int; it doesn't always, on 64-bit hosts. The new version
1169 doesn't catch all possible integer overflows, but it's an
847044ea 1170 improvement. (Bug#8719)
30569699 1171
c11285dc
PE
1172 * alloc.c (make_event_array): Use XINT, not XUINT.
1173 There's no need for unsigned here.
1174
fdccd48e
PE
1175 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1176 This follows up to the 2011-05-06 change that substituted uintptr_t
1177 for EMACS_INT. This case wasn't caught back then.
1178
37910ab2
PE
1179 Rework Fformat to avoid integer overflow issues.
1180 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1181 now (part of C89). Include <verify.h>.
1182 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1183 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1184 (Fformat): Avoid the prepass trying to compute sizes; it was only
1185 approximate and thus did not catch overflow reliably. Instead, walk
1186 through the format just once, formatting and computing sizes as we go,
1187 checking for integer overflow at every step, and allocating a larger
1188 buffer as needed. Keep track separately whether the format is
1189 multibyte. Keep only the most-recently calculated precision, rather
1190 than them all. Record whether each argument has been converted to
1191 string. Use EMACS_INT, not int, for byte and char and arg counts.
1192 Support field widths and precisions larger than INT_MAX. Avoid
1193 sprintf's undefined behavior with conversion specifications such as %#d
1194 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1195 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1196 formatting out-of-range floating point numbers with int
1197 formats. (Bug#8668)
1198
2e6578fb
PE
1199 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1200
0ae6bdee
PE
1201 * data.c: Avoid integer truncation in expressions involving floats.
1202 * data.c: Include <intprops.h>.
1203 (arith_driver): When there's an integer overflow in an expression
1204 involving floating point, convert the integers to floating point
1205 so that the resulting value does not suffer from catastrophic
1206 integer truncation. For example, on a 64-bit host (* 4
1207 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1208 Do not rely on undefined behavior after integer overflow.
1209
de883a70
PE
1210 merge count_size_as_multibyte, parse_str_to_multibyte
1211 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1212 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1213 Check for integer overflow.
1214 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1215 since it's now a duplicate of the other. This is more of
1216 a character than a buffer op, so better that it's in character.c.
1217 * fns.c, print.c: Adjust to above changes.
1218
2ff916cb
PE
12192011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1220
1221 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1222
f1b54466
PE
12232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1224
fb1ac845
PE
1225 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1226 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1227 (x_clipboard_manager_save): Now static.
1228 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1229
f1b54466
PE
1230 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1231 (crypto_hash_function): Now static.
1232 Fix pointer signedness problems. Avoid unnecessary initializations.
1233
a9f737ee
CY
12342011-05-27 Chong Yidong <cyd@stupidchicken.com>
1235
1236 * termhooks.h (Vselection_alist): Make it terminal-local.
1237
1238 * terminal.c (create_terminal): Initialize it.
1239
1240 * xselect.c: Support for clipboard managers.
1241 (Vselection_alist): Move to termhooks.h as terminal-local var.
1242 (LOCAL_SELECTION): New macro.
1243 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1244 (symbol_to_x_atom): Remove gratuitous arg.
1245 (x_handle_selection_request, lisp_data_to_selection_data)
1246 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1247 (x_own_selection, x_get_local_selection, x_convert_selection):
1248 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1249 (some_frame_on_display): Delete unused function.
1250 (Fx_own_selection_internal, Fx_get_selection_internal)
1251 (Fx_disown_selection_internal, Fx_selection_owner_p)
1252 (Fx_selection_exists_p): New optional frame arg.
1253 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1254 (x_handle_selection_clear): Don't treat other terminals with the
1255 same keyboard specially. Use the terminal-local Vselection_alist.
1256 (x_clear_frame_selections): Use Frun_hook_with_args.
1257
1258 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1259
1260 * xterm.h: Add support for those atoms.
1261
e067f0c1
CY
12622011-05-26 Chong Yidong <cyd@stupidchicken.com>
1263
1264 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1265 (converted_selections, conversion_fail_tag): New global variables.
1266 (x_selection_request_lisp_error): Free the above.
1267 (x_get_local_selection): Remove unnecessary code.
1268 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1269 of converted selections stored in converted_selections.
1270 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1271 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1272 (x_convert_selection): New function.
1273 (x_handle_selection_event): Simplify.
1274 (x_get_foreign_selection): Don't ignore incoming requests while
1275 waiting for an answer; this will fail when we implement
1276 SAVE_TARGETS, and seems unnecessary anyway.
1277 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1278 (Vx_sent_selection_functions): Doc fix.
1279
0f4aebc0
LL
12802011-05-26 Leo Liu <sdl.web@gmail.com>
1281
1282 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1283
e61124cd
YM
12842011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1285
1286 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1287
1288 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1289 for fringe update if it has periodic bitmap.
1290 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1291 and fringe_bitmap_periodic_p.
1292
1293 * fringe.c (get_fringe_bitmap_data): New function.
1294 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1295 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1296 row. Mark glyph row for fringe update if periodicity changed.
1297
1298 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1299 for fringe update unless it has periodic bitmap.
1300
f16d9837
KH
13012011-05-25 Kenichi Handa <handa@m17n.org>
1302
1303 * xdisp.c (get_next_display_element): Set correct it->face_id for
1304 a static composition.
1305
e1b90ef6
LL
13062011-05-24 Leo Liu <sdl.web@gmail.com>
1307
1308 * deps.mk (fns.o):
1309 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1310
1311 * fns.c (crypto_hash_function, Fsha1): New function.
1312 (Fmd5): Use crypto_hash_function.
1313 (syms_of_fns): Add Ssha1.
1314
7400048f
PE
13152011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 * gnutls.c: Remove unused macros.
1318 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1319 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1320 Remove macros that are defined and never used.
1321 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1322
abb71cf4
CY
13232011-05-22 Chong Yidong <cyd@stupidchicken.com>
1324
1325 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1326 (Fx_get_selection_internal): Minor cleanup.
1327 (Fx_own_selection_internal): Rename arguments for consistency with
1328 select.el.
1329
6307db39
PE
13302011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1331
1332 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1333
f3d4e0a4
CY
13342011-05-22 Chong Yidong <cyd@stupidchicken.com>
1335
1336 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1337
4d8ade89
YM
13382011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1339
1340 * dispnew.c (scrolling_window): Don't exclude the case that the
1341 last enabled row in the desired matrix touches the bottom boundary.
1342
32078c8d
GM
13432011-05-21 Glenn Morris <rgm@gnu.org>
1344
1345 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1346 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1347 and add some more files.
32078c8d 1348
7285dc67
EZ
13492011-05-20 Eli Zaretskii <eliz@gnu.org>
1350
1351 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1352 report_file_error introduced by the change from 2011-05-07.
1353
89d1bd22
PE
13542011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 * systime.h (Time): Define only if emacs is defined.
1357 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1358 where the include path doesn't have X11/X.h by default. See
1359 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1360
e23640bb 13612011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1362
1363 * composite.c (find_automatic_composition): Fix previous change.
1364
b9704ad9
GM
13652011-05-20 Glenn Morris <rgm@gnu.org>
1366
1367 * lisp.mk: New file, split from Makefile.in.
1368 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1369 (shortlisp): Remove.
1370 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1371
4a720484
GM
13722011-05-19 Glenn Morris <rgm@gnu.org>
1373
1374 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1375 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1376 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1377 (lisp): Set the order to that of loadup.el.
1378 (shortlisp): Make it a copy of $lisp.
1379 (SOME_MACHINE_LISP): Remove.
1380 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1381 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1382
a28d4396
KH
13832011-05-18 Kenichi Handa <handa@m17n.org>
1384
1385 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1386 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1387 (find_automatic_composition): Mostly rewrite for efficiency.
1388
a2b1fa8e
JB
13892011-05-18 Juanma Barranquero <lekktu@gmail.com>
1390
1391 * makefile.w32-in: Update dependencies.
1392
8e1f5610
CS
13932011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1394
1395 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1396 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1397
7025ee00 13982011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1399
cdfa6eab
PE
1400 Fix some integer overflow issues, such as string length overflow.
1401
06d6db33
PE
1402 * insdel.c (count_size_as_multibyte): Check for string overflow.
1403
2b4560a8
PE
1404 * character.c (lisp_string_width): Check for string overflow.
1405 Use EMACS_INT, not int, for string indexes and lengths; in
1406 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1407 the resulting string length overflows an EMACS_INT; instead,
1408 report a string overflow if no precision given. When checking for
1409 precision exhaustion, use a check that cannot possibly have
1410 integer overflow. (Bug#8675)
1411 * character.h (lisp_string_width): Adjust to new signature.
1412
cb93f9be
PE
1413 * alloc.c (string_overflow): New function.
1414 (Fmake_string): Use it. This doesn't change behavior, but saves
1415 a few bytes and will simplify future changes.
1416 * character.c (string_escape_byte8): Likewise.
1417 * lisp.h (string_overflow): New decl.
1418
1a1f3366
PE
1419 Fixups, following up to the user-interface timestamp change.
1420 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1421 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1422 * msdos.c (mouse_get_pos): Likewise.
1423 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1424 * w32gui.h (Time): Define by including "systime.h" rather than by
1425 declaring it ourselves. (Bug#8664)
1426
d4e3e4d3
PE
1427 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1428 * image.c (clear_image_cache): Likewise.
1429
f6a24d19
PE
1430 * term.c (term_mouse_position): Don't assume time_t wraparound.
1431
08dc5ae6
PE
1432 Be more systematic about user-interface timestamps.
1433 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1434 and sometimes 'EMACS_UINT', to represent these timestamps.
1435 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1436 This makes the code easier to follow, and makes it easier to catch
1437 integer overflow bugs such as Bug#8664.
1438 * frame.c (Fmouse_position, Fmouse_pixel_position):
1439 Use Time, not unsigned long, for user-interface timestamps.
1440 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1441 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1442 * keyboard.h (last_event_timestamp): Likewise.
1443 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1444 * menu.h (xmenu_show): Likewise.
1445 * term.c (term_mouse_position): Likewise.
1446 * termhooks.h (struct input_event.timestamp): Likewise.
1447 (struct terminal.mouse_position_hook): Likewise.
1448 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1449 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1450 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1451 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1452 what it was before.
1453 * menu.h, termhooks.h: Include "systime.h", for Time.
1454
8e55734a
PE
1455 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1456 Don't assume that the difference between two unsigned long values
1457 can fit into an integer. At this point, we know button_down_time
1458 <= event->timestamp, so the difference must be nonnegative, so
1459 there's no need to cast the result if double-click-time is
1460 nonnegative, as it should be; check that it's nonnegative, just in
1461 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1462 apart (about 25 days). (Bug#8664)
8e55734a 1463
841f1b75 1464 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1465 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1466
3e26f69c
PE
1467 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1468 that always fit in int. Use a sentinel instead of a counter, to
1469 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1470 * frame.h (struct frame): Use int for menu_bar_items_used
1471 instead of EMACS_INT, since it always fits in int.
3e26f69c 1472
5cc152c0
PE
1473 * menu.c (grow_menu_items): Check for int overflow.
1474
d89eb65e
PE
1475 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1476
5235bd3e
PE
1477 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1478 Before, the code was not consistent. These values cannot exceed
1479 2**31 - 1 so there's no need to make them unsigned.
1480 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1481 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1482 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1483 as modifiers.
1484 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1485
bc827e23
PE
1486 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1487 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1488 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1489 presumably because the widths might not match.
1490
78eb494e
PE
1491 * window.c (size_window): Avoid needless test at loop start.
1492
04f2d78b
CB
14932011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1494
1495 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1496
d2fc7e3d 14972011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1498
1499 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1500
d2fc7e3d 15012011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1502
1503 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1504 `width' to `bar_area_x' and `bar_area_width', respectively.
1505 (x_scroll_run): Take account of fringe background extension.
1506
04f2d78b
CB
1507 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1508 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1509 `bar_area_width', respectively.
1510 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1511 background extension.
1512
79b70037
GM
15132011-05-10 Jim Meyering <meyering@redhat.com>
1514
1515 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1516
2f142cc5
JB
15172011-05-10 Juanma Barranquero <lekktu@gmail.com>
1518
1519 * image.c (Finit_image_library): Return t for built-in image types,
1520 like pbm and xbm. (Bug#8640)
1521
57679c86
AS
15222011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1523
1524 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1525
888c9e86
EZ
15262011-05-07 Eli Zaretskii <eliz@gnu.org>
1527
b0512a1d
EZ
1528 * w32console.c (Fset_screen_color): Doc fix.
1529 (Fget_screen_color): New function.
1530 (syms_of_ntterm): Defsubr it.
1531
7285dc67
EZ
1532 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1533 unlink the temporary file if Fcall_process didn't create it in the
1534 first place.
1535 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1536 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1537 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1538 cue to call_process_cleanup not to close that handle.
1539
4d3fcc8e
BK
15402011-05-07 Ben Key <bkey76@gmail.com>
1541
1542 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1543 one of two shell specific rules, either bootstrap-temacs-CMD or
1544 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1545 to the previous implementation of the bootstrap-temacs rule.
1546 The bootstrap-temacs-CMD rule is similar to the previous
1547 implementation of the bootstrap-temacs rule except that it
1548 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1549 variable.
1550
1551 These changes, along with some changes to nt/configure.bat,
1552 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1553 earlier fix to add support for --cflags and --ldflags options
1554 that include quotes so that it works whether make uses cmd or
1555 sh as the shell.
1556
b4289b64
MA
15572011-05-06 Michael Albinus <michael.albinus@gmx.de>
1558
1559 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1560 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1561 is a constant.
1562 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1563 a string. Handle both cases.
1564 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1565 (Fdbus_register_method): Use Qinvalid_function.
1566
af4c0e28
JB
15672011-05-06 Juanma Barranquero <lekktu@gmail.com>
1568
1569 * makefile.w32-in: Update dependencies.
1570 (LISP_H): Add inttypes.h and stdin.h.
1571 (PROCESS_H): Add unistd.h.
1572
c51453d9
EZ
15732011-05-06 Eli Zaretskii <eliz@gnu.org>
1574
1575 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1576 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1577
8ff0ac3c 15782011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1579
4c4b566b
PE
1580 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1581
aab2b9b5
PE
1582 * term.c (vfatal): Remove stray call to va_end.
1583 It's not needed and the C Standard doesn't allow it here anyway.
1584
c378da0b
PE
1585 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1586 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1587
288b08c7
PE
1588 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1589 bytes.
1590
e3601888
PE
1591 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1592
db6c0e74
PE
1593 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1594
dd5963ea
PE
1595 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1596
88c9450f
PE
1597 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1598
2f9442b8
PE
1599 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1600
c032b5f8
PE
1601 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1602 * charset.c (Fdefine_charset_internal): Don't initialize
1603 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1604 32-bit int (Bug#8600).
a108c10b
PE
1605
1606 * lread.c (read_integer): Be more consistent with string-to-number.
1607 Use string_to_number to do the actual conversion; this avoids
1608 rounding errors and fixes some other screwups. Without this fix,
1609 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1610 (digit_to_number): Move earlier, for benefit of read_integer.
1611 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1612 not a digit in any supported base. (Bug#8602)
a108c10b 1613
ad5f9eea
PE
1614 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1615
aec1708a
PE
1616 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1617 to match comment at start of function. This also removes a
1618 GCC warning about overflow in a 32+64-bit port.
1619
47be4ab5
PE
1620 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1621
371cac43
PE
1622 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1623 Reported by Stefan Monnier in
1624 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1625 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1626 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1627
d01a7826
PE
1628 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1629 (EMACS_UINTPTR): Likewise, with uintptr_t.
1630
7fd47d5c
PE
1631 * lisp.h: Prefer 64-bit EMACS_INT if available.
1632 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1633 on 32-bit hosts that have 64-bit int, so that they can access
1634 large files.
122b0c86
PE
1635 However, temporarily disable this change unless the temporary
1636 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1637
8727937b
PE
1638 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1639
8ac068ac
PE
1640 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1641 This removes an assumption that EMACS_INT and long are the same
1642 width as pointers. The assumption is true for Emacs porting targets
1643 now, but we want to make other targets possible.
1644 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1645 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1646 In the rest of the code, change types of integers that hold casted
1647 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1648 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1649 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1650 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1651 No need to cast type when ORing.
1652 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1653 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1654 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1655 assume EMACS_INT is the same width as char *.
1656 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1657 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1658 Remove no-longer-needed casts.
1659 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1660 (xg_tool_bar_help_callback, xg_make_tool_item):
1661 Use EMACS_INTPTR to hold an integer
1662 that will be cast to void *; this can avoid a GCC warning
1663 if EMACS_INT is not the same width as void *.
1664 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1665 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1666 (current_message_1, set_message_1):
1667 Use a local to convert to proper width without a cast.
1668 * xmenu.c (dialog_selection_callback): Likewise.
1669
ede49d71
PE
1670 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1671 Also, don't assume VALBITS / RAND_BITS is less than 5,
1672 and don't rely on undefined behavior when shifting a 1 left into
1673 the sign bit.
1674 * lisp.h (get_random): Change signature to match.
1675
2f30ecd0
PE
1676 * lread.c (hash_string): Use size_t, not int, for hash computation.
1677 Normally we prefer signed values; but hashing is special, because
1678 it's better to use unsigned division on hash table sizes so that
1679 the remainder is nonnegative. Also, size_t is the natural width
1680 for hashing into memory. The previous code used 'int', which doesn't
1681 retain enough info to hash well into very large tables.
1682 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1683
2a866e7b
PE
1684 * dbusbind.c: Don't possibly lose pointer info when converting.
1685 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1686 Use XPNTR rather than XHASH, so that the high-order bits of
1687 the pointer aren't lost when converting through void *.
1688
51639eac
PE
1689 * eval.c (Fautoload): Don't double-shift a pointer.
1690
92394119
PE
1691 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1692
dbdb9a7c
JB
16932011-05-06 Juanma Barranquero <lekktu@gmail.com>
1694
1695 * gnutls.c (DEF_GNUTLS_FN):
1696 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1697
db7a0b4f
AS
16982011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1699
1700 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1701 marker. (Bug#8610)
1702
f7ff1b0f 17032011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1704
1705 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1706 New version that can reserve upto 2GB of heap space.
1707
f7ff1b0f 17082011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1709
1710 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1711
639c109b
TZ
17122011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1713
1714 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1715 `gnutls_certificate_set_x509_key_file'.
1716
d2127135
JB
17172011-05-05 Juanma Barranquero <lekktu@gmail.com>
1718
1719 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1720 Update dependencies.
1721
e968f4f3
JB
17222011-05-04 Juanma Barranquero <lekktu@gmail.com>
1723
1724 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1725 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1726 Remove unused parameter `fildes'.
1727 * process.c (read_process_output, send_process): Don't pass it.
1728
84d358f0
JB
17292011-05-04 Juanma Barranquero <lekktu@gmail.com>
1730
1731 Fix previous change: the library cache is defined in w32.c.
1732 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1733 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1734
0898ca10
JB
17352011-05-04 Juanma Barranquero <lekktu@gmail.com>
1736
1737 Implement dynamic loading of GnuTLS on Windows.
1738
1739 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1740 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1741 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1742 Declare.
1743
1744 * gnutls.c (Qgnutls_dll): Define.
1745 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1746 (gnutls_*): Declare function pointers.
1747 (init_gnutls_functions): New function to initialize function pointers.
1748 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1749 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1750 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1751 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1752 (emacs_gnutls_write, emacs_gnutls_read)
1753 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1754 (Fgnutls_available_p): New function.
1755 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1756 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1757 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1758
1759 * image.c: Include w32.h.
1760 (Vimage_type_cache): Delete.
1761 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1762 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1763 (w32_delayed_load): Move to w32.c.
1764
1765 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1766
1767 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1768 (w32_delayed_load): Move from image.c. When loading a library, record
1769 its filename in the :loaded-from property of the library id.
1770 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1771 Initialize and staticpro them.
1772 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1773
1774 * process.c: Include lisp.h before w32.h, not after.
1775 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1776 instead of gnutls_record_check_pending.
1777
1778 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1779
ff4de4aa
TZ
17802011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1781
1782 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1783 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1784 as passed in.
1785
abe95abb
JD
17862011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1787
1788 * xterm.c (x_set_frame_alpha): Do not set property on anything
1789 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1790
e16e55d4
JB
17912011-05-02 Juanma Barranquero <lekktu@gmail.com>
1792
1793 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1794
bafcf6a5
JB
17952011-05-02 Juanma Barranquero <lekktu@gmail.com>
1796
1797 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1798 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1799 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1800 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1801 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1802 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1803 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1804 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1805 (Qgnutls_bootprop_callbacks_verify): Make static.
1806
e7a6747f
AS
18072011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1808
19ed11ba
AS
1809 * callproc.c: Indentation fixup.
1810
e7a6747f 1811 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1812 (wait_for_termination, interruptible_wait_for_termination):
1813 Move after wait_for_termination_1.
e7a6747f 1814
1ef14cb4
LMI
18152011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1816
1817 * sysdep.c (interruptible_wait_for_termination): New function
1818 which is like wait_for_termination, but allows keyboard
1819 interruptions.
1820
1821 * callproc.c (Fcall_process): Add (:file "file") as an option for
1822 the STDOUT buffer.
1823 (Fcall_process_region): Ditto.
1824
330d880c
EZ
18252011-04-30 Eli Zaretskii <eliz@gnu.org>
1826
8db90b73
EZ
1827 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1828 rather than `XVECTOR (FOO)->size'.
1829
330d880c
EZ
1830 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1831 inttypes.h, as a gnulib replacement is used if it not available in
1832 system headers.
1833
15cbd324
EZ
18342011-04-21 Eli Zaretskii <eliz@gnu.org>
1835
1836 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1837 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1838 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1839
1840 * coding.c (coding_alloc_by_realloc): Error out if destination
1841 will grow beyond MOST_POSITIVE_FIXNUM.
1842 (decode_coding_emacs_mule): Abort if there isn't enough place in
1843 charbuf for the composition carryover bytes. Reserve an extra
1844 space for up to 2 characters produced in a loop.
1845 (decode_coding_iso_2022): Abort if there isn't enough place in
1846 charbuf for the composition carryover bytes.
1847
18482011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1849
ae940cca
EZ
1850 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1851 aborting when %lld or %lll format is passed.
1852 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1853 %llo or %llx format is passed. (Bug#8545)
1854
03ab8921
EZ
1855 * window.c (window_scroll_line_based): Use a marker instead of
1856 simple variables to record original value of point. (Bug#7952)
1857
afda1437
EZ
1858 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1859 produced by %s or %c overflows available buffer space. (Bug#8545)
1860
f76dee0c
PE
18612011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1864 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1865
fdc5744d
JB
18662011-04-28 Juanma Barranquero <lekktu@gmail.com>
1867
1868 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1869
638f053a
JB
18702011-04-28 Juanma Barranquero <lekktu@gmail.com>
1871
1872 * keyboard.c (Qdelayed_warnings_hook): Define.
1873 (command_loop_1): Run `delayed-warnings-hook'
1874 if Vdelayed_warnings_list is non-nil.
1875 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1876 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1877
d178f871
EZ
18782011-04-28 Eli Zaretskii <eliz@gnu.org>
1879
1880 * doprnt.c (doprnt): Don't return value smaller than the buffer
1881 size if the message was truncated. (Bug#8545).
1882
b124fd93
JB
18832011-04-28 Juanma Barranquero <lekktu@gmail.com>
1884
1885 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1886 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1887
e810457d
PE
18882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1891
ea51cceb
JB
18922011-04-27 Juanma Barranquero <lekktu@gmail.com>
1893
1894 * makefile.w32-in: Update dependencies.
1895
94dcfacf
EZ
18962011-04-27 Eli Zaretskii <eliz@gnu.org>
1897
1898 Improve `doprnt' and its usage. (Bug#8545)
1899 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1900 `format_end'. Remove support for %l as a conversion specifier.
1901 Don't use xrealloc. Improve diagnostics when the %l size modifier
1902 is used. Update the commentary.
1903
1904 * eval.c (verror): Simplify calculation of size_t.
1905
1906 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1907 messages.
1908
f61f41d7
PE
19092011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1910
1911 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1912 change.
1913
96fb4434
PE
19142011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1915
1916 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1917 This makes this file independent of the recent pseudovector change.
1918
671875da 19192011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1920
69e9b5a3
PE
1921 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1922
b5f869a7 1923 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1924 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1925 Remove unused local.
c8926152 1926 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1927
841a1577 1928 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1929 GCC 4.6.0 optimizes based on type-based alias analysis.
1930 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1931 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1932 != &v->size, and therefore "v->size = 1; b->size = 2; return
1933 v->size;" must therefore return 1. This assumption is incorrect
1934 for Emacs, since it type-puns struct Lisp_Vector * with many other
1935 types. To fix this problem, this patch adds a new type struct
f904488f 1936 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1937 and pseudovectors, and helps optimizing compilers not get fooled
1938 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1939 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1940 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1941 the size member.
eab3844f
PE
1942 (XSETPVECTYPE): Rewrite in terms of new macro.
1943 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1944 This is a bit clearer, and further avoids the possibility of
1945 undesirable aliasing.
1946 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1947 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1948 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1949 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1950 (ASIZE): Now uses header.size rather than size.
1951 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1952 to avoid the hassle of writing XVECTOR (foo)->header.size.
1953 (struct vectorlike_header): New type.
eab3844f
PE
1954 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1955 object, to help avoid aliasing.
1956 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1957 (SUBRP): Likewise, since Lisp_Subr is a special case.
1958 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1959 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1960 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1961 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1962 changed to be "header.size" and "header.next".
1963 * buffer.h (struct buffer): Likewise.
1964 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1965 * frame.h (struct frame): Likewise.
1966 * process.h (struct Lisp_Process): Likewise.
1967 * termhooks.h (struct terminal): Likewise.
1968 * window.c (struct save_window_data, struct saved_window): Likewise.
1969 * window.h (struct window): Likewise.
1970 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1971 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1972 * buffer.c (init_buffer_once): Likewise.
1973 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1974 special case.
1975 * process.c (Fformat_network_address): Use local var for size,
1976 for brevity.
1977
0df1eac5
PE
1978 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1979
847ab9d1 1980 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1981 * data.c (atof): Remove decl; no longer used or needed.
1982 (digit_to_number): Move to lread.c.
1983 (Fstring_to_number): Use new string_to_number function, to be
1984 consistent with how the Lisp reader treats infinities and NaNs.
1985 Do not assume that floating-point numbers represent EMACS_INT
1986 without losing information; this is not true on most 64-bit hosts.
1987 Avoid double-rounding errors, by insisting on integers when
1988 parsing non-base-10 numbers, as the documentation specifies.
1989 * lisp.h (string_to_number): New decl, replacing ...
1990 (isfloat_string): Remove.
bc0a5c13 1991 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1992 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1993 appears to have been a coding error. Similarly, do not accept
1994 strings like +-1e0 as floating point numbers. Do not report
1995 overflow for integer overflows unless the base is not 10 which
1996 means we have no simple and reliable way to continue.
1997 Break out the floating-point parsing into a new
1998 function string_to_number, so that Fstring_to_number parses
1999 floating point numbers consistently with the Lisp reader.
04f2d78b 2000 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2001 (E_CHAR, EXP_INT): Remove, replacing with ...
2002 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2003 (string_to_number): New function, replacing isfloat_string.
2004 This function checks for valid syntax and produces the resulting
2005 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2006 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2007 so that overflow for non-base-10 numbers is reported only when
2008 there's no portable and simple way to convert to floating point.
452f4150 2009
67769ffc
PE
2010 * textprop.c (set_text_properties_1): Rewrite for clarity,
2011 and to avoid GCC warning about integer overflow.
2012
c20db43f
PE
2013 * intervals.h (struct interval): Use EMACS_INT for members
2014 where EMACS_UINT might cause problems. See
2015 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2016 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2017 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2018 All uses changed.
37aa2f85
PE
2019 (offset_intervals): Tell GCC not to worry about length overflow
2020 when negating a negative length.
c20db43f 2021
2538aa2f
PE
2022 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2023 (overrun_check_free): Likewise.
2024
f2d3008d
PE
2025 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2026 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2027 word size.
2028
ec8df744
PE
2029 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2030 (gnutls_make_error): Rename local to avoid shadowing.
2031 (gnutls_emacs_global_deinit): ifdef out; not used.
2032 (Fgnutls_boot): Use const for pointer to readonly storage.
2033 Comment out unused local. Fix pointer signedness problems.
2034
640ee02d
PE
2035 * lread.c (openp): Don't stuff size_t into an 'int'.
2036 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2037 about possible signed overflow.
2038
6048fb2a
PE
2039 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2040 (GDK_KEY_g): Don't define if already defined.
2041 (xg_prepare_tooltip): Avoid pointer signedness problem.
2042 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2043
fa3c87e1
PE
2044 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2045 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2046
2172544b
PE
2047 * xfns.c (Fx_window_property): Simplify a bit,
2048 to make a bit faster and to avoid GCC 4.6.0 warning.
2049 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2050
9b821a21
PE
2051 * fns.c (internal_equal): Don't assume size_t fits in int.
2052
3c616cfa
PE
2053 * alloc.c (compact_small_strings): Tighten assertion a little.
2054
c2982e87
PE
2055 Replace pEd with more-general pI, and fix some printf arg casts.
2056 * lisp.h (pI): New macro, generalizing old pEd macro to other
2057 conversion specifiers. For example, use "...%"pI"d..." rather
2058 than "...%"pEd"...".
2059 (pEd): Remove. All uses replaced with similar uses of pI.
2060 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2061 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2062 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2063 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2064 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2065 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2066 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2067 64-bit hosts.
2068 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2069 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2070 * print.c (safe_debug_print, print_object): Likewise.
2071 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2072 to int.
6f04d126
PE
2073 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2074 avoiding the 0 flag, which is not portable.
c2982e87
PE
2075 * process.c (Fmake_network_process): Use pI to avoid cast.
2076 * region-cache.c (pp_cache): Likewise.
2077 * xdisp.c (decode_mode_spec): Likewise.
2078 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2079 behavior on 64-bit hosts with printf arg.
6f04d126 2080 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2081 (x_stop_queuing_selection_requests): Likewise.
2082 (x_get_window_property): Don't truncate byte count to an 'int'
2083 when tracing.
0b432f21 2084
5e073ec7
PE
2085 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2086 here, since it parses constructs like leading '-' and spaces,
2087 which are not wanted; and it overflows with large numbers.
2088 Instead, simply match F[0-9]+, which is what is wanted anyway.
2089
36372bf9
PE
2090 * alloc.c: Remove unportable assumptions about struct layout.
2091 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2092 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2093 (allocate_vectorlike, make_pure_vector): Use the new macros,
2094 plus offsetof, to remove unportable assumptions about struct layout.
2095 These assumptions hold on all porting targets that I know of, but
2096 they are not guaranteed, they're easy to remove, and removing them
2097 makes further changes easier.
2098
0b432f21
PE
2099 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2100 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2101 (string_overrun_cookie): Now const. Use initializers that
2102 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2103 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2104 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2105 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2106 multiple of sizeof (EMACS_INT); it need not be, if
2107 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2108 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2109
895009e1
JB
21102011-04-26 Juanma Barranquero <lekktu@gmail.com>
2111
2112 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2113
6a7a1b0b
TZ
21142011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2115
2116 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2117 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2118 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2119
841a1577 21202011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2121
2122 * lisp.h (Qdebug): List symbol.
895009e1 2123 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2124 * keyboard.c (debug-on-event): New variable.
2125 (handle_user_signal): Break into debugger when debug-on-event
2126 matches the current signal symbol.
2127
f2d3ba6f
DN
21282011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2129
2130 * alloc.c (check_sblock, check_string_bytes)
2131 (check_string_free_list): Convert to standard C.
2132
42ce4c63
TZ
21332011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2134
2135 * w32.c (emacs_gnutls_push): Fix typo.
2136
825cd63c
EZ
21372011-04-25 Eli Zaretskii <eliz@gnu.org>
2138
fb11d64d
EZ
2139 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2140 "cast to pointer from integer of different size".
2141
825cd63c
EZ
2142 Improve doprnt and its use in verror. (Bug#8545)
2143 * doprnt.c (doprnt): Document the set of format control sequences
2144 supported by the function. Use SAFE_ALLOCA instead of always
2145 using `alloca'.
2146
2147 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2148 is one byte too soon. Don't use xrealloc; instead xfree and
2149 xmalloc anew.
2150
e061a11b
TZ
21512011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2152
2153 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2154 callbacks stage.
2155
2156 * gnutls.c: Renamed global_initialized to
2157 gnutls_global_initialized. Added internals for the
2158 :verify-hostname-error, :verify-error, and :verify-flags
2159 parameters of `gnutls-boot' and documented those parameters in the
2160 docstring. Start callback support.
2161 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2162 unless a fatal error occured. Call gnutls_alert_send_appropriate
2163 on error. Return error code.
2164 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2165 (emacs_gnutls_read): Likewise.
2166 (Fgnutls_boot): Return handshake error code.
2167 (emacs_gnutls_handle_error): New function.
2168 (wsaerror_to_errno): Likewise.
2169
2170 * w32.h (emacs_gnutls_pull): Add prototype.
2171 (emacs_gnutls_push): Likewise.
2172
2173 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2174 (emacs_gnutls_push): Likewise.
2175
21762011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2177
2178 * process.c (wait_reading_process_output): Check if GnuTLS
2179 buffered some data internally if no FDs are set for TLS
2180 connections.
2181
2182 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2183 (LIBS): Link to USER_LIBS.
2184 ($(BLD)/gnutls.$(0)): New target.
2185
fa6996bc
EZ
21862011-04-24 Eli Zaretskii <eliz@gnu.org>
2187
eb35682e
EZ
2188 * xdisp.c (handle_single_display_spec): Rename the
2189 display_replaced_before_p argument into display_replaced_p, to
2190 make it consistent with the commentary. Fix typos in the
2191 commentary.
2192
e2ad650c
EZ
2193 * textprop.c (syms_of_textprop): Remove dead code.
2194 (copy_text_properties): Delete obsolete commentary about an
2195 interface that was deleted long ago. Fix typos in the description
2196 of arguments.
2197
1b2de274
EZ
2198 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2199 to changes in oldXMenu/XMenu.h from 2011-04-16.
2200 <menu_help_message, prev_menu_help_message>: Constify.
2201 (IT_menu_make_room): menu->help_text is now `const char **';
2202 adjust.
2203
2204 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2205 to changes in oldXMenu/XMenu.h from 2011-04-16.
2206 (struct XMenu): Declare `help_text' `const char **'.
2207
2208 * xfaces.c <Qunspecified>: Make extern again.
2209
2210 * syntax.c: Include sys/types.h before including regex.h, as
2211 required by Posix.
2212
762b15be
EZ
2213 * doc.c (get_doc_string): Improve the format passed to `error'.
2214
2215 * doprnt.c (doprnt): Improve commentary.
2216
2217 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2218
2219 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2220 them with etags.
2221
f1052e5d
EZ
2222 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2223 changes in globals.h immediately force recompilation.
762b15be
EZ
2224 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2225 $(CURDIR)/s/ms-w32.h.
2226 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2227
fa6996bc
EZ
2228 * character.c (Fchar_direction): Function deleted.
2229 (syms_of_character): Don't defsubr it.
2230 <char-direction-table>: Deleted.
2231
e6c3da20
EZ
22322011-04-23 Eli Zaretskii <eliz@gnu.org>
2233
2234 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2235 * doprnt.c: Include limits.h.
2236 (SIZE_MAX): New macro.
04f2d78b
CB
2237 (doprnt): Return a size_t value. 2nd arg is now size_t.
2238 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2239 Improve overflow protection. Support `l' modifier for integer
2240 conversions. Support %l conversion. Don't assume an EMACS_INT
2241 argument for integer conversions and for %c.
2242
2243 * lisp.h (doprnt): Restore prototype.
2244
2245 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2246 $(SRC)/character.h.
2247
2248 * Makefile.in (base_obj): Add back doprnt.o.
2249
2250 * deps.mk (doprnt.o): Add back prerequisites.
2251 (callint.o): Depend on character.h.
2252
2253 * eval.c (internal_lisp_condition_case): Include the handler
2254 representation in the error message.
2255 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2256 when breaking from the loop.
2257
2258 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2259
2260 * callint.c (Fcall_interactively): When displaying error message
2261 about invalid control letter, pass the character's codepoint, not
2262 a pointer to its multibyte form. Improve display of the character
2263 in octal and display also its hex code.
2264
2265 * character.c (char_string): Use %x to display the (unsigned)
2266 codepoint of an invalid character, to avoid displaying a bogus
2267 negative value.
2268
2269 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2270 `error', not SYMBOL_NAME itself.
2271
2272 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2273 character arguments to `error'.
2274
2275 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2276 to `error' in error message about FINAL_CHAR argument. Make sure
2277 FINAL_CHAR is a character, and use %c when it is passed as
2278 argument to `error'.
2279
4ffd0d6b 22802011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2281
2282 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2283
2284 * w32.c: Include <time.h>.
2285 (sys_localtime): New function.
2286
4ffd0d6b 22872011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2288
2289 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2290
4ffd0d6b 2291 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2292
4ffd0d6b 22932011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2294
4ffd0d6b
GM
2295 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2296 zombies (Bug#8467).
aac0c6e3 2297
04c56954
EZ
22982011-04-19 Eli Zaretskii <eliz@gnu.org>
2299
2300 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2301 gl_state.e_property when gl_state.object is Qt.
2302
2303 * insdel.c (make_gap_larger): Remove limitation of buffer size
2304 to <= INT_MAX.
2305
16a43933
CY
23062011-04-18 Chong Yidong <cyd@stupidchicken.com>
2307
2308 * xdisp.c (lookup_glyphless_char_display)
2309 (produce_glyphless_glyph): Handle cons cell entry in
2310 glyphless-char-display.
2311 (Vglyphless_char_display): Document it.
2312
2313 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2314 glyphless-char-display.
2315
4581706e
CY
23162011-04-17 Chong Yidong <cyd@stupidchicken.com>
2317
2318 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2319
2320 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2321
2322 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2323 definition for no-X builds.
2324
4887c6e2 23252011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2326
fd35b6f9
PE
2327 Static checks with GCC 4.6.0 and non-default toolkits.
2328
5c1ccb01
PE
2329 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2330
006c5daa
PE
2331 * process.c (keyboard_bit_set): Define only if SIGIO.
2332 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2333 (send_process): Repair possible setjmp clobbering.
2334
efc736d3
PE
2335 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2336
4e2fe2e6
PE
2337 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2338
f97334a2
PE
2339 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2340
4e75f29d
PE
2341 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2342 Define only if needed.
2343
90efadd1
PE
2344 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2345 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2346 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2347
3c647824
PE
2348 * dispextern.h (struct redisplay_interface): Rename param
2349 to avoid shadowing.
e264f262 2350 * termhooks.h (struct terminal): Likewise.
761383f4 2351 * xterm.c (xembed_send_message): Likewise.
3c647824 2352
b58c5c4a
PE
2353 * insdel.c (make_gap_smaller): Define only if
2354 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2355
cad59032
PE
2356 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2357 it.
2358
c339dc2e
PE
2359 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2360 so that we aren't warned about unused symbols.
2361
91a3e27b
PE
2362 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2363
399c71d3 2364 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2365
8ffc96f5
PE
2366 * xfns.c (x_real_positions): Mark locals as initialized.
2367
eef9bc79
PE
2368 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2369
098db9dd
PE
2370 * xterm.c: Fix problems found by static analysis with other toolkits.
2371 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2372 (x_dispatch_event): Declare static if USE_GTK, and
2373 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2374 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2375 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2376 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2377 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2378
eb18f6cc
PE
2379 * xmenu.c (menu_help_callback): Pointer type fixes.
2380 Use const pointers when pointing at readonly data. Avoid pointer
2381 signedness clashes.
2382 (FALSE): Remove unused macro.
2383 (update_frame_menubar): Remove unused decl.
2384
1fe72bf8
PE
2385 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2386
60d9e1db
PE
2387 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2388 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2389 (single_menu_item): Rename local to avoid shadowing.
2390
39261c26
PE
2391 * keyboard.c (make_lispy_event): Remove unused local var.
2392
018c5e19
PE
2393 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2394 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2395
63d2b86e
PE
2396 * bitmaps: Change bitmaps from unsigned char back to the X11
2397 compatible char. Avoid the old compiler warnings about
2398 out-of-range initializers by using, for example, '\xab' rather
2399 than 0xab.
2400
aefd87e1
PE
2401 * xgselect.c (xgselect_initialize): Check vs interface
2402 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2403
bf501fb9
PE
2404 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2405
e9829fdf
PE
2406 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2407 to read-only memory.
2408
1086c095
PE
2409 * fns.c (vector): Remove; this old hack is no longer needed.
2410
2baccd04 2411 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2412 Remove unused var.
dde42981 2413 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2414
72391843 2415 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2416
436c16df 2417 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2418 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2419 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2420
92bb796d 2421 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2422 (x_term_init): Remove local to avoid shadowing.
92bb796d 2423
764430a3 2424 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2425
2426 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2427 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2428
d1dfb56c
EZ
24292011-04-16 Eli Zaretskii <eliz@gnu.org>
2430
c4354cb4
EZ
2431 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2432
d1dfb56c
EZ
2433 Fix regex.c, syntax.c and friends for buffers > 2GB.
2434 * syntax.h (struct gl_state_s): Declare character position members
2435 EMACS_INT.
2436
2437 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2438
04f2d78b
CB
2439 * textprop.c (verify_interval_modification, interval_of):
2440 Declare arguments EMACS_INT.
d1dfb56c
EZ
2441
2442 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2443 EMACS_INT.
2444
2445 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2446
2447 * indent.c (Fvertical_motion): Local variable it_start is now
2448 EMACS_INT.
2449
2450 * regex.c (re_match, re_match_2, re_match_2_internal)
2451 (bcmp_translate, regcomp, regexec, print_double_string)
2452 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2453 (re_compile_pattern, re_exec): Declare arguments and local
2454 variables `size_t' and `ssize_t' and return values `regoff_t', as
2455 appropriate.
2456 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2457 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2458 <compile_stack_type>: `size' and `avail' are now `size_t'.
2459
2460 * regex.h <regoff_t>: Use ssize_t, not int.
2461 (re_search, re_search_2, re_match, re_match_2): Arguments that
2462 specify buffer/string position and length are now ssize_t and
2463 size_t. Return type is regoff_t.
2464
613052cd
BK
24652011-04-16 Ben Key <bkey76@gmail.com>
2466
2467 * nsfont.m: Fixed bugs in ns_get_family and
2468 ns_descriptor_to_entity that were caused by using free to
2469 deallocate memory blocks that were allocated by xmalloc (via
2470 xstrdup). This caused Emacs to crash when compiled with
2471 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2472 --enable-checking=xmallocoverrun). xfree is now used to
2473 deallocate these memory blocks.
2474
4170f62f 24752011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2476
71b41406
PE
2477 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2478
9587a89d
PE
2479 emacs_write: Accept and return EMACS_INT for sizes.
2480 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2481 et seq.
2482 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2483 Accept and return EMACS_INT.
2484 (emacs_gnutls_write): Return the number of bytes written on
2485 partial writes.
2486 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2487 (emacs_read, emacs_write): Remove check for negative size, as the
2488 Emacs source code has been audited now.
9587a89d
PE
2489 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2490 (emacs_read, emacs_write): Use it.
273a5f82
PE
2491 * process.c (send_process): Adjust to the new signatures of
2492 emacs_write and emacs_gnutls_write. Do not attempt to store
2493 a byte offset into an 'int'; it might overflow.
9587a89d 2494 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2495
3e047f51
PE
2496 * sound.c: Don't assume sizes fit in 'int'.
2497 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2498 Return EMACS_INT, not int.
3e047f51 2499 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2500 Accept EMACS_INT, not int.
2501 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2502 record read return values.
2503
cc39a9db
BK
25042011-04-15 Ben Key <bkey76@gmail.com>
2505
c9d0ec6d
JB
2506 * keyboard.c (Qundefined): Don't declare static since it is used
2507 in nsfns.m.
2508 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2509 static since they are used in nsfont.m.
cc39a9db 2510
6c60eb9f
SM
25112011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2512
2513 * process.c (Qprocessp): Don't declare static.
2514 * lisp.h (Qprocessp): Declare again.
2515
7990b61a
JB
25162011-04-15 Juanma Barranquero <lekktu@gmail.com>
2517
2518 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2519
5d4cb038
PE
25202011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2521
8bd7b830 2522 Improve C-level modularity by making more things 'static'.
cd64ea1d 2523
e3b27b31
PE
2524 Don't publish debugger-only interfaces to other modules.
2525 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2526 (verify_bytepos, count_markers): Move decls to the only modules
2527 that need them.
2528 * region-cache.h (pp_cache): Likewise.
2529 * window.h (check_all_windows): Likewise.
2530 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2531
5d4cb038
PE
2532 * sysdep.c (croak): Now static, if
2533 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2534 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2535
2536 * alloc.c (refill_memory_reserve): Now static if
2537 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2538 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2539
e87b6180
PE
2540 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2541 Define only if USE_LUCID.
2542
ac64929e
PE
2543 * xrdb.c (x_customization_string, x_rm_string): Now static.
2544
6f37259d
PE
2545 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2546 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2547
1683e3ab
PE
2548 * xdisp.c (draw_row_with_mouse_face): Now static.
2549 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2550
de9c2632
PE
2551 * window.h (check_all_windows): Mark externally visible.
2552
2b96acb7
PE
2553 * window.c (window_deletion_count): Now static.
2554
2555 * undo.c: Make symbols static if they're not exported.
2556 (last_undo_buffer, last_boundary_position, pending_boundary):
2557 Now static.
2558
50436f33
PE
2559 * textprop.c (interval_insert_behind_hooks): Now static.
2560 (interval_insert_in_front_hooks): Likewise.
2561
64520e5c
PE
2562 * term.c: Make symbols static if they're not exported.
2563 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2564 (max_frame_lines, tty_set_terminal_modes):
2565 (tty_reset_terminal_modes, tty_turn_off_highlight):
2566 (get_tty_terminal): Now static.
2567 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2568 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2569 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2570 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2571 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2572
1fa53021
PE
2573 * sysdep.c: Make symbols static if they're not exported.
2574 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2575 Now static.
2576 (sigprocmask_set, full_mask): Remove; unused.
2577 (wait_debugging): Mark as visible.
2578 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2579 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2580
d4b43b22
PE
2581 * syntax.c (syntax_temp): Define only if !__GNUC__.
2582
b7c513d0
PE
2583 * sound.c (current_sound_device, current_sound): Now static.
2584
989b29ad
PE
2585 * search.c (searchbufs, searchbuf_head): Now static.
2586
13a55a78
PE
2587 * scroll.c (scroll_cost): Remove; unused.
2588 * dispextern.h (scroll_cost): Remove decl.
2589
de68a1fc
PE
2590 * region-cache.h (pp_cache): Mark as externally visible.
2591
40ccffa6
PE
2592 * process.c: Make symbols static if they're not exported.
2593 (process_tick, update_tick, create_process, chan_process):
2594 (Vprocess_alist, proc_buffered_char, datagram_access):
2595 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2596 (deactivate_process): Mark defn as static, as well as decl.
2597 * lisp.h (create_process): Remove decl.
2598 * process.h (chan_process, Vprocess_alist): Remove decls.
2599
ad64fc97
PE
2600 * print.c: Make symbols static if they're not exported.
2601 (print_depth, new_backquote_output, being_printed, print_buffer):
2602 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2603 (print_interval, print_number_index, initial_stderr_stream):
2604 Now static.
2605 * lisp.h (Fprinc): Remove decl.
2606 (debug_output_compilation_hack): Mark as externally visible.
2607
adddb265
PE
2608 * sysdep.c (croak): Move decl from here to syssignal.h.
2609 * syssignal.h (croak): Put it here, so the API can be checked when
2610 'croak' is called from dissociate_if_controlling_tty.
2611
1717ede2
PE
2612 * minibuf.c: Make symbols static if they're not exported.
2613 (minibuf_save_list, choose_minibuf_frame): Now static.
2614 * lisp.h (choose_minibuf_frame): Remove decl.
2615
fa5fb2bc
PE
2616 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2617
1e3890d1
PE
2618 * lread.c: Make symbols static if they're not exported.
2619 (read_objects, initial_obarray, oblookup_last_bucket_number):
2620 Now static.
2621 (make_symbol): Remove; unused.
2622 * lisp.h (initial_obarray, make_symbol): Remove decls.
2623
8a1414fa
PE
2624 * keyboard.c: Make symbols static if they're not exported.
2625 (single_kboard, recent_keys_index, total_keys, recent_keys):
2626 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2627 (this_single_command_key_start, echoing, last_auto_save):
2628 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2629 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2630 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2631 (Vlispy_mouse_stem, double_click_count):
2632 Now static.
2633 (force_auto_save_soon): Define only if SIGDANGER.
2634 (ignore_mouse_drag_p): Now static if
2635 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2636 (print_help): Remove; unused.
2637 (stop_character, last_timer_event): Mark as externally visible.
2638 * keyboard.h (ignore_mouse_drag_p): Declare only if
2639 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2640 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2641 * lisp.h (echoing): Remove decl.
2642 (force_auto_save_soon): Declare only if SIGDANGER.
2643 * xdisp.c (redisplay_window): Simplify code, to make it more
2644 obvious that ignore_mouse_drag_p is not accessed if !defined
2645 USE_GTK && !defined HAVE_NS.
2646
93ea6e8f
PE
2647 * intervals.c: Make symbols static if they're not exported.
2648 (merge_properties_sticky, merge_interval_right, delete_interval):
2649 Now static.
2650 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2651
77382fcc
PE
2652 * insdel.c: Make symbols static if they're not exported.
2653 However, leave prepare_to_modify_buffer alone. It's never
2654 called from outside this function, but that appears to be a bug.
2655 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2656 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2657 (adjust_after_replace_noundo): Remove; unused.
2658 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2659 (signal_before_change): Remove decls.
77382fcc 2660
9306c32e
PE
2661 * indent.c (val_compute_motion, val_vmotion): Now static.
2662
cd44d2eb
PE
2663 * image.c: Make symbols static if they're not exported.
2664 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2665 if USE_GTK.
2666 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2667 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2668
ad9a7a06
PE
2669 * fringe.c (standard_bitmaps): Now static.
2670 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2671
81626931
PE
2672 * frame.c: Make symbols static if they're not exported.
2673 (x_report_frame_params, make_terminal_frame): Now static.
2674 (get_frame_param): Now static, unless HAVE_NS.
2675 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2676 (x_get_resource_string): Remove; not used.
2677 * frame.h (make_terminal_frame, x_report_frame_params):
2678 (x_get_resource_string); Remove decls.
2679 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2680 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2681
239f9db9
PE
2682 * font.c, fontset.c: Make symbols static if they're not exported.
2683 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2684 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2685 * font.c (font_close_object): Now static.
2686 * font.h (font_close_object): Remove.
2687 * fontset.c (FONTSET_OBJLIST): Remove.
2688 (free_realized_fontset) #if-0 the body, which does nothing.
2689 (face_suitable_for_char_p): #if-0, as it's never called.
2690 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2691 * xfaces.c (face_at_string_position):
2692 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2693 since 0 is always ASCII.
2694
dfcf3579
PE
2695 * fns.c (weak_hash_tables): Now static.
2696
5045092b
PE
2697 * fileio.c: Make symbols static if they're not exported.
2698 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2699 (Vwrite_region_annotation_buffers): Now static.
2700
57a96f5c
PE
2701 * eval.c: Make symbols static if they're not exported.
2702 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2703 * lisp.h (backtrace_list): Remove decl.
2704
35f08c38
PE
2705 * emacs.c: Make symbols static if they're not exported.
2706 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2707 (fatal_error_code, fatal_error_signal_hook, standard_args):
2708 Now static.
2709 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2710 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2711 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2712 * lisp.h (fatal_error_signal_hook): Remove decl.
2713 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2714
f44bd759
PE
2715 * editfns.c: Move a (normally-unused) function to its only use.
2716 * editfns.c, lisp.h (get_operating_system_release): Remove.
2717 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2718 worth the hassle of breaking this out.
2719
b532497d
PE
2720 * xterm.c: Make symbols static if they're not exported.
2721 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2722 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2723 (x_destroy_window, x_delete_display):
2724 Now static.
2725 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2726 (x_mouse_leave): Remove; unused.
2727 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2728 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2729 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2730 Remove decls.
2731 (x_mouse_leave): Declare only if WINDOWSNT.
2732 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2733 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2734 USE_X_TOOLKIT.
2735
1675728f
PE
2736 * ftxfont.c: Make symbols static if they're not exported.
2737 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2738 HAVE_FREETYPE.
2739 * font.h (ftxfont_driver): Likewise.
2740
e4cebfca
PE
2741 * xfns.c: Make symbols static if they're not exported.
2742 (x_last_font_name, x_display_info_for_name):
2743 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2744 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2745 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2746 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2747 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2748 (last_show_tip_args): Now static.
2749 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2750 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2751 (x_screen_planes): Remove; unused.
2752 * dispextern.h (x_screen_planes): Remove decl.
2753
5bf46f05
PE
2754 * dispnew.c: Make symbols static if they're not exported.
2755 * dispextern.h (redraw_garbaged_frames, scrolling):
2756 (increment_row_positions): Remove.
2757 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2758 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2759 Now static.
2760 (redraw_garbaged_frames): Remove; unused.
2761
435f4c28
PE
2762 * xfaces.c: Make symbols static if they're not exported.
2763 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2764 Remove decls.
2765 * xterm.h (defined_color): Remove decls.
2766 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2767 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2768 (menu_face_changed_default, defined_color, free_realized_face):
2769 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2770 (ascii_face_of_lisp_face): Remove; unused.
2771
8524aef3
PE
2772 * xdisp.c: Make symbols static if they're not exported.
2773 * dispextern.h (scratch_glyph_row, window_box_edges):
2774 (glyph_to_pixel_coords, set_cursor_from_row):
2775 (get_next_display_element, set_iterator_to_next):
2776 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2777 (show_mouse_face): Remove decls
2778 * frame.h (message_buf_print): Likewise.
2779 * lisp.h (pop_message, set_message, check_point_in_composition):
2780 Likewise.
2781 * xterm.h (set_vertical_scroll_bar): Likewise.
2782 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2783 (message_buf_print, scratch_glyph_row, displayed_buffer):
2784 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2785 (get_next_display_element, show_mouse_face, window_box_edges):
2786 (frame_to_window_pixel_xy, check_point_in_composition):
2787 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2788 (glyph_to_pixel_coords): Remove; unused.
2789
16390cd2
PE
2790 * dired.c (file_name_completion): Now static.
2791
2792 * dbusbind.c (xd_in_read_queued_messages): Now static.
2793
a25f4dfa
PE
2794 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2795 * data.c (circular_list_error): Remove.
2796
14a9c8df
PE
2797 * commands.h (last_point_position, last_point_position_buffer):
2798 (last_point_position_window): Remove decls.
2799 * keyboard.c: Make these variables static.
2800
04f2d78b
CB
2801 * coding.h (coding, code_convert_region, encode_coding_gap):
2802 Remove decls.
74ab6df5
PE
2803 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2804 (iso_code_class, detect_coding, code_convert_region): Now static.
2805 (encode_coding_gap): Remove; unused.
2806
38dfbee1
PE
2807 * chartab.c (chartab_chars, chartab_bits): Now static.
2808
a2cb4e63
PE
2809 * charset.h (charset_iso_8859_1): Remove decl.
2810 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2811 Now static.
2812
127198fd
PE
2813 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2814 * ccl.c (Vccl_program_table): Now static.
2815 (check_ccl_update): Remove; unused.
2816
d85b608f
PE
2817 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2818 * category.h: ... from here.
2819 * category.c (check_category_table, set_category_set): Now static.
2820
31cd66f3
PE
2821 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2822 * lisp.h: Remove these decls.
2823
c358e587
PE
2824 * buffer.c (buffer_count): Remove unused var.
2825
e78aecca
PE
2826 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2827 so that it's not optimized away.
2828 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2829 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2830 exported only to the debugger.
2831
e192d7d3 2832 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2833 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2834
92470028
PE
2835 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2836 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2837 was inaccessible from Lisp.
2838 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2839 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2840
244ed907
PE
2841 alloc.c: Import and export fewer symbols, and remove unused items.
2842 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2843 is defined.
2844 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2845 it's not optimized away by whole-program optimization.
2846 (message_enable_multibyte, free_misc): Remove.
2847 (catchlist, handlerlist, mark_backtrace):
2848 Declare only if BYTE_MARK_STACK.
2849 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2850 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2851 (message_enable_multibyte): Remove decl.
2852 (free_misc, interval_free_list, float_block, float_block_index):
2853 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2854 (cons_free_list, last_marked_index):
2855 Now static.
2856 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2857 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2858 (mark_backtrace): Define only if BYTE_MARK_STACK.
2859 * xdisp.c (message_enable_multibyte): Now static.
2860
61c2b50e 2861 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2862 This makes it easier for human readers (and static analyzers)
2863 to see whether these variables are used from other modules.
2864 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2865 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2866 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2867 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2868 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2869 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2870 * xmenu.c, xselect.c:
2871 Declare Q* vars static if they are not used in other modules.
2872 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2873 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2874 Remove decls of unexported vars.
2875 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2876
95c82688
PE
2877 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2878
16a97296
PE
2879 Make Emacs functions such as Fatom 'static' by default.
2880 This makes it easier for human readers (and static analyzers)
2881 to see whether these functions can be called from other modules.
2882 DEFUN now defines a static function. To make the function external
2883 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2884 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2885 (Finit_image_library):
16a97296
PE
2886 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2887 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2888 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2889 Remove decls, since these functions are now static.
2890 (Funintern, Fget_internal_run_time): New decls, since these functions
2891 were already external.
95c82688 2892
16a97296
PE
2893 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2894 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2895 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2896 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2897 * keyboard.c, keymap.c, lread.c:
2898 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2899 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2900 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2901 Mark functions with DEFUE instead of DEFUN,
2902 if they are used in other modules.
2903 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2904 decls for now-static functions.
2905 * buffer.h (Fdelete_overlay): Remove decl.
2906 * callproc.c (Fgetenv_internal): Mark as internal.
2907 * composite.c (Fremove_list_of_text_properties): Remove decl.
2908 (Fcomposition_get_gstring): New forward static decl.
2909 * composite.h (Fcomposite_get_gstring): Remove decl.
2910 * dired.c (Ffile_attributes): New forward static decl.
2911 * doc.c (Fdocumntation_property): New forward static decl.
2912 * eval.c (Ffetch_bytecode): New forward static decl.
2913 (Funintern): Remove extern decl; now in .h file where it belongs.
2914 * fileio.c (Fmake_symbolic_link): New forward static decl.
2915 * image.c (Finit_image_library): New forward static decl.
2916 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2917 * intervals.h (Fprevious_property_change):
2918 (Fremove_list_of_text_properties): Remove decls.
2919 * keyboard.c (Fthis_command_keys): Remove decl.
2920 (Fcommand_execute): New forward static decl.
2921 * keymap.c (Flookup_key): New forward static decl.
2922 (Fcopy_keymap): Now static.
2923 * keymap.h (Flookup_key): Remove decl.
2924 * process.c (Fget_process): New forward static decl.
2925 (Fprocess_datagram_address): Mark as internal.
2926 * syntax.c (Fsyntax_table_p): New forward static decl.
2927 (skip_chars): Remove duplicate decl.
2928 * textprop.c (Fprevious_property_change): New forward static decl.
2929 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2930 Now internal.
2931 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2932 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2933
785bbd42
PE
2934 * editfns.c (Fformat): Remove unreachable code.
2935
8b913b57
AS
29362011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2937
2938 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2939 change. (Bug#8496)
2940
a6744a35
EZ
29412011-04-13 Eli Zaretskii <eliz@gnu.org>
2942
2943 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2944 when at ZV. (Bug#8487)
2945
e7974947
AS
29462011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2947
baad03f0
AS
2948 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2949 (Bug#8437)
2950 * keyboard.c (parse_tool_bar_item): Likewise.
2951 * sound.c (sound_cleanup, alsa_close): Likewise.
2952 * termcap.c (tgetent): Likewise.
2953 * xfns.c (x_default_font_parameter): Likewise.
2954 * xsettings.c (read_and_apply_settings): Likewise.
2955
e7974947
AS
2956 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2957 (overrun_check_free): Protoize.
2958
28272684
PE
29592011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2962 since callers should never pass a negative size.
2963 Change the signature to match that of plain 'read' and 'write'; see
2964 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2965 * lisp.h: Update prototypes of emacs_write and emacs_read.
2966
11997c76
EZ
29672011-04-11 Eli Zaretskii <eliz@gnu.org>
2968
2969 * xdisp.c (redisplay_window): Don't try to determine the character
2970 position of the scroll margin if the window start point w->startp
e896f03c 2971 is outside the buffer's accessible region. (Bug#8468)
11997c76 2972
8a2cbd72
EZ
29732011-04-10 Eli Zaretskii <eliz@gnu.org>
2974
2975 Fix write-region and its subroutines for buffers > 2GB.
2976 * fileio.c (a_write, e_write): Modify declaration of arguments and
2977 local variables to support buffers larger than 2GB.
2978 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2979
2980 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2981 argument, local variables, and return value.
2982
2983 * lisp.h: Update prototypes of emacs_write and emacs_read.
2984
2985 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2986
4073e537 29872011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2988
1ebfdcb6
PE
2989 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2990
b2ded58d
PE
2991 Fix more problems found by GCC 4.6.0's static checks.
2992
7d66342c
PE
2993 * xdisp.c (vmessage): Use a better test for character truncation.
2994
bbf47d44
PE
2995 * charset.c (load_charset_map): <, not <=, for optimization,
2996 and to avoid potential problems with integer overflow.
9248994d 2997 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2998 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2999 * editfns.c (Fformat): Likewise.
1e69125e 3000 * syntax.c (skip_chars): Likewise.
3befa583 3001
e3019616
PE
3002 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3003 This also lets GCC 4.6.0 generate slightly better loop code.
3004
becfa255
PE
3005 * callint.c (Fcall_interactively): <, not <=, for optimization.
3006 (Fcall_interactively): Count the number of arguments produced,
3007 not the number of arguments given. This is simpler and lets GCC
3008 4.6.0 generate slightly better code.
3009
dae0cd48
PE
3010 * ftfont.c: Distingish more carefully between FcChar8 and char.
3011 The previous code passed unsigned char * to a functions like
3012 strlen and xstrcasecmp that expect char *, which does not
3013 conform to the C standard.
3014 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3015 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3016 char * when the C standard requires it.
3017
76032d70
PE
3018 * keyboard.c (read_char): Remove unused var.
3019
eb3f1cc8
PE
3020 * eval.c: Port to Windows vsnprintf (Bug#8435).
3021 Include <limits.h>.
3022 (SIZE_MAX): Define if the headers do not.
3023 (verror): Do not give up if vsnprintf returns a negative count.
3024 Instead, grow the buffer. This ports to Windows vsnprintf, which
3025 does not conform to C99. Problem reported by Eli Zaretskii.
3026 Also, simplify the allocation scheme, by avoiding the need for
3027 calling realloc, and removing the ALLOCATED variable.
3028
70476b54
PE
3029 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3030
12020a9e
PE
3031 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3032 But keep the doprint source code for now, as we might revamp it
3033 and use it again (Bug#8435).
ea6c7ae6
PE
3034 * lisp.h (doprnt): Remove.
3035 * Makefile.in (base_obj): Remove doprnt.o.
3036 * deps.mk (doprnt.o): Remove.
3037
5fdb398c
PE
3038 error: Print 32- and 64-bit integers portably (Bug#8435).
3039 Without this change, on typical 64-bit hosts error ("...%d...", N)
3040 was used to print both 32- and 64-bit integers N, which relied on
3041 undefined behavior.
3042 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3043 New macro.
3044 * lisp.h (error, verror): Mark as printf-like functions.
3045 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3046 Report overflow in size calculations when allocating printf buffer.
3047 Do not truncate output string at its first null byte.
3048 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3049 Truncate the output at a character boundary, since vsnprintf does not
3050 do that.
3051 * charset.c (check_iso_charset_parameter): Convert internal
3052 character to string before calling 'error', since %c now has the
3053 printf meaning.
3054 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3055 overflow when computing char to be passed to 'error'. Do not
3056 pass Lisp_Object to 'error'; pass the integer instead.
3057 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3058 formatted with plain %d.
3059
b189fa66
PE
3060 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3061
bff87ef0
PE
3062 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3063
7e2cac20
PE
3064 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3065
ce4d90b5
PE
3066 * xterm.c (x_catch_errors): Remove duplicate declaration.
3067
266c9547
PE
3068 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3069
79c49ad2
PE
3070 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3071
368f4090
JM
30722011-04-10 Jim Meyering <meyering@redhat.com>
3073
3074 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3075 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3076 return ssize_t not "int", and use size_t as the buffer length.
3077 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3078 * gnutls.h: Update declarations.
3079 * process.c (read_process_output): Use ssize_t, to match.
3080 (send_process): Likewise.
3081
a32d4040
CY
30822011-04-09 Chong Yidong <cyd@stupidchicken.com>
3083
3084 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3085
8546720e 30862011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3087
04f2d78b
CB
3088 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3089 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3090
8546720e
GM
3091 * xterm.c (handle_one_xevent):
3092 * xmenu.c (create_and_show_popup_menu):
3093 * xselect.c (x_decline_selection_request)
3094 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3095
0a2f5c1a 30962011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3097
3098 Fix some uses of `int' instead of EMACS_INT.
3099 * search.c (string_match_1, fast_string_match)
3100 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3101 (scan_buffer, find_next_newline_no_quit)
3102 (find_before_next_newline, search_command, Freplace_match)
3103 (Fmatch_data): Make some `int' variables be EMACS_INT.
3104
3105 * xdisp.c (display_count_lines): 3rd argument and return value now
3106 EMACS_INT. All callers changed.
3107 (pint2hrstr): Last argument is now EMACS_INT.
3108
3109 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3110 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3111 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3112 (decode_coding_utf_16, decode_coding_emacs_mule)
3113 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3114 (decode_coding_ccl, decode_coding_charset)
3115 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3116 (decode_coding_iso_2022, decode_coding_emacs_mule)
3117 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3118 <char_offset, last_offset>: Declare EMACS_INT.
3119 (encode_coding_utf_8, encode_coding_utf_16)
3120 (encode_coding_emacs_mule, encode_invocation_designation)
3121 (encode_designation_at_bol, encode_coding_iso_2022)
3122 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3123 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3124 Declare EMACS_INT.
3125 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3126 (encode_invocation_designation): Last argument P_NCHARS is now
3127 EMACS_INT.
3128 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3129 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3130
3131 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3132 All users changed.
3133
3134 * ccl.c (Fccl_execute_on_string): Declare some variables
3135 EMACS_INT.
3136
8546720e 31372011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3138
3139 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3140
4e19a977
CS
31412011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3142
3143 * process.c (Fformat_network_address): Doc fix.
3144
87302331
R
31452011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3146
3147 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3148
cbb59342
CY
31492011-04-08 Chong Yidong <cyd@stupidchicken.com>
3150
3151 * keyboard.c (read_char): Call Lisp function help-form-show,
3152 instead of using internal_with_output_to_temp_buffer.
3153 (Qhelp_form_show): New var.
e0d38eeb 3154 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3155
3156 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3157
3158 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3159
e67a13ab
CY
31602011-04-06 Chong Yidong <cyd@stupidchicken.com>
3161
04f2d78b
CB
3162 * process.c (Flist_processes): Remove to Lisp.
3163 (list_processes_1): Delete.
e67a13ab 3164
973f782d
EZ
31652011-04-06 Eli Zaretskii <eliz@gnu.org>
3166
7c106b1e
EZ
3167 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3168
973f782d
EZ
3169 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3170
41cf7d1a 31712011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3172
ca23cc88
PE
3173 Fix more problems found by GCC 4.6.0's static checks.
3174
f390e2d5
PE
3175 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3176
42eea0d0
PE
3177 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3178
b69769da 3179 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3180
f9541e84
PE
3181 * xdisp.c (vmessage): Mark as a printf-like function.
3182
13841b55
PE
3183 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3184
c136c10f
PE
3185 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3186
5e2d4a30
PE
3187 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3188 printf-like functions.
3189 (tiff_load): Add casts to remove these marks before passing them
3190 to system-supplied API.
3191
583f48b9
PE
3192 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3193
b25d760e
PE
3194 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3195 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3196 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3197 directly, rather than having caller test rule sign. This avoids
3198 some unnecessary tests.
3199 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3200 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3201 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3202
bc7b6697 3203 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3204 (xfont_open): Avoid unnecessary tests.
bc7b6697 3205
27ccc379
PE
3206 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3207
dcd5c89a
PE
3208 * composite.h, composite.c (composition_gstring_put_cache):
3209 Use EMACS_INT, not int, for length.
3210
b13a45c6
PE
3211 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3212 breaking out part of COMPOSITION_DECODE_RULE.
3213 (COMPOSITION_DECODE_RULE): Use it.
3214 * composite.c (get_composition_id): Remove unused local vars,
3215 by using the new macro.
3216
1e792e4d
PE
3217 * textprop.c (set_text_properties_1): Change while to do-while,
3218 since the condition is always true at first.
3219
dc6c6455 3220 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3221 (interval_deletion_adjustment): Return unsigned value.
3222 All uses changed.
dc6c6455 3223
aba7731a
PE
3224 * process.c (list_processes_1, create_pty, read_process_output):
3225 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3226 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3227 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3228 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3229 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3230
fdfc4bf3
PE
3231 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3232
fca8fe46 3233 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3234 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3235
06a0259a 3236 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3237 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3238 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3239
e7b9e80f
PE
3240 * print.c (print_error_message): Avoid int overflow.
3241
56201685
PE
3242 * font.c (font_list_entities): Redo for clarity,
3243 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3244
78834453 3245 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3246 (font_score): Avoid potential overflow in diff calculation.
78834453 3247
0bc0b309 3248 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3249 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3250
e610eaca
PE
3251 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3252
b895abce
PE
3253 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3254 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3255 can always succeed if overflow has undefined behavior.
3256
1f1d9321 3257 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3258 (wordify): Omit three unnecessary tests.
1f1d9321 3259
c59478bc
PE
3260 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3261 All callers changed. This avoids the need for an unused var.
3262
79b73827
PE
3263 * casefiddle.c (casify_region): Remove var that is set but not used.
3264
a4db5dfe
PE
3265 * dired.c (file_name_completion): Remove var that is set but not used.
3266
43aae36e
PE
3267 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3268
2a47c44d 3269 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3270 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3271
a37c69bf
PE
3272 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3273 Check for integer overflow on size calculations.
3274
328ab8e7
PE
3275 * buffer.c (Fprevious_overlay_change): Remove var that is set
3276 but not used.
3277
e5a2a5cb
PE
3278 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3279 Remove vars that are set but not used.
8d84a6eb 3280 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3281 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3282
a60e5f68
PE
3283 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3284
f661cb61 3285 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3286 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3287
f0397f5a
PE
3288 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3289 that are set but not used.
3290
8664db06 3291 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3292 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3293
6abdaa4a
PE
3294 * xselect.c (x_get_local_selection, x_handle_property_notify):
3295 Remove vars that are set but not used.
3296
0ce7538d 3297 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3298 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3299
9ae848fc
PE
3300 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3301 Remove var that is set but not used.
0b918413
PE
3302 (scroll_bar_windows_size): Now size_t, not int.
3303 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3304 Check for overflow.
9ae848fc 3305
a5a62657
PE
3306 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3307 (map_tty_color) [!defined MSDOS]: Likewise.
3308
5c5cdd39
PE
3309 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3310
66ebf983
PE
3311 * coding.c: Remove vars that are set but not used.
3312 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3313 All callers changed.
3314 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3315 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3316 (decode_coding_charset): Remove vars that are set but not used.
3317
1be4d761
PE
3318 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3319 that is set but not used.
3320
47553fa8
PE
3321 * print.c (print_object): Remove var that is set but not used.
3322
1f7196bf 3323 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3324 The gnulib version avoids calling malloc in the usual case,
3325 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3326 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3327 * filelock.c (current_lock_owner): Likewise.
3328 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3329 * sysdep.c: Include allocator.h, careadlinkat.h.
3330 (emacs_no_realloc_allocator): New static constant.
3331 (emacs_readlink): New function.
fdb61804
PE
3332 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3333 ../lib/careadlinkat.h.
d1fdcab7 3334
f84c17c7
SM
33352011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3336
3337 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3338 first non-nil return value).
3339
ef3862ad
JD
33402011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3341
3342 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3343 if not defined (Bug#8403).
3344
376a7006
JB
33452011-04-02 Juanma Barranquero <lekktu@gmail.com>
3346
3347 * xdisp.c (display_count_lines): Remove parameter `start',
3348 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3349 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3350 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3351 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3352 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3353 and thereabouts. All callers changed.
3354 (get_per_char_metric): Remove parameter `f', unused since
3355 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3356
6ca3801d
JM
33572011-04-02 Jim Meyering <meyering@redhat.com>
3358
3359 do not dereference NULL upon failed strdup
3360 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3361 (ns_get_family): Likewise.
3362
d8e2b5ba
JB
33632011-04-02 Juanma Barranquero <lekktu@gmail.com>
3364
3365 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3366
8c74fcbd
JD
33672011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3368
3369 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3370 later (Bug#8403).
3371
7200d79c
SM
33722011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3373
03408648 3374 Add lexical binding.
7200d79c 3375
03408648
SM
3376 * window.c (Ftemp_output_buffer_show): New fun.
3377 (Fsave_window_excursion):
3378 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3379
3380 * lread.c (lisp_file_lexically_bound_p): New function.
3381 (Fload): Bind Qlexical_binding.
3382 (readevalloop): Remove `evalfun' arg.
3383 Bind Qinternal_interpreter_environment.
3384 (Feval_buffer): Bind Qlexical_binding.
3385 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3386 Mark as dynamic.
3387 (syms_of_lread): Declare `lexical-binding'.
3388
3389 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3390
3391 * keyboard.c (eval_dyn): New fun.
3392 (menu_item_eval_property): Use it.
ca105506
SM
3393
3394 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3395
03408648
SM
3396 * fns.c (concat, mapcar1): Accept byte-code-functions.
3397
3398 * eval.c (Fsetq): Handle lexical vars.
3399 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3400 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3401 (FletX, Flet): Obey lexical binding.
3402 (Fcommandp): Handle closures.
3403 (Feval): New `lexical' arg.
3404 (eval_sub): New function extracted from Feval. Use it almost
3405 everywhere where Feval was used. Look up vars in lexical env.
3406 Handle closures.
3407 (Ffunctionp): Move from subr.el.
3408 (Ffuncall): Handle closures.
3409 (apply_lambda): Remove `eval_flags'.
3410 (funcall_lambda): Handle closures and new byte-code-functions.
3411 (Fspecial_variable_p): New function.
3412 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3413 but without exporting it to Lisp.
23aba0ea 3414
23aba0ea 3415 * doc.c (Fdocumentation, store_function_docstring):
03408648 3416 * data.c (Finteractive_form): Handle closures.
23aba0ea 3417
03408648
SM
3418 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3419 interactive spec.
ba83908c 3420
04f2d78b
CB
3421 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3422 New byte-codes.
03408648
SM
3423 (exec_byte_code): New function extracted from Fbyte_code to handle new
3424 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3425
03408648 3426 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3427
03408648 3428 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3429
e2abce01
JB
34302011-03-31 Juanma Barranquero <lekktu@gmail.com>
3431
3432 * xdisp.c (redisplay_internal): Fix prototype.
3433
63696a73 34342011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3435
63696a73 3436 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3437 (try_scrolling): Use it when setting scroll_limit.
3438 Limit scrolling to 100 screen lines.
63696a73
EZ
3439 (redisplay_window): Even when falling back on "recentering",
3440 position point in the window according to scroll-conservatively,
3441 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3442
3443 (try_scrolling): When point is above the window, allow searching
3444 as far as scroll_max, or one screenful, to compute vertical
3445 distance from PT to the scroll margin position. This prevents
3446 try_scrolling from unnecessarily failing when
3447 scroll-conservatively is set to a value slightly larger than the
3448 window height. Clean up the case of PT below the margin at bottom
3449 of window: scroll_max can no longer be INT_MAX. When aggressive
3450 scrolling is in use, don't let point enter the opposite scroll
3451 margin as result of the scroll.
3452 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3453 threshold of 100 lines for never-recentering scrolling.
3454
e4cc2dfc
JB
34552011-03-31 Juanma Barranquero <lekktu@gmail.com>
3456
3457 * dispextern.h (move_it_by_lines):
3458 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3459 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3460 (message_log_check_duplicate): Remove parameters `prev_bol' and
3461 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3462 (redisplay_internal): Remove parameter `preserve_echo_area',
3463 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3464
3465 * indent.c (Fvertical_motion):
3466 * window.c (window_scroll_pixel_based, Frecenter):
3467 Don't pass `need_y_p' to `move_it_by_lines'.
3468
1c470562
SM
34692011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3470
44f230aa
SM
3471 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3472 steal a few bits to be more compact.
3473 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3474 Remove unneeded casts.
3475
1c470562
SM
3476 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3477
888adce9
ZK
34782011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3479
3480 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3481 binding" message (bug#7967).
3482
f838ed7b
PE
34832011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3484
77861b95
PE
3485 Fix more problems found by GCC 4.6.0's static checks.
3486
de6dbc14
PE
3487 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3488 Remove unused local var.
3489
f838ed7b
PE
3490 * editfns.c (Fmessage_box): Remove unused local var.
3491
792c7b2b
PE
3492 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3493 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3494 Omit unused local vars.
c499e557 3495 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3496 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3497 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3498 Omit unused local var.
3499
ba0165e1
PE
3500 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3501 Don't assume string length fits in int.
32ad8845 3502 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3503 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3504
3c59b4c9
PE
3505 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3506 instead of alloca (Bug#8344).
3507
a3eed478 3508 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3509 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3510
eb4d412d
PE
3511 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3512
1658b401
PE
3513 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3514 concerns.
3515
3516 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3517
3518 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3519
9a2c6e05
PE
3520 * keyboard.c (syms_of_keyboard): Use the same style as later
3521 in this function when indexing through an array. This also
3522 works around GCC bug 48267.
3523
03d0a109
PE
3524 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3525
44f730c8
PE
3526 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3527
fe75f926
PE
3528 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3529 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3530
ffa8c828
PE
3531 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3532 This avoids undefined behavior on integer overflow, and is a bit
3533 more convenient anyway since it is compared to a size_t variable.
3534
c5101a77
PE
3535 Variadic C functions now count arguments with size_t, not int.
3536 This avoids an unnecessary limitation on 64-bit machines, which
3537 caused (substring ...) to crash on large vectors (Bug#8344).
3538 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3539 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3540 All variadic functions and their callers changed accordingly.
c5101a77
PE
3541 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3542 * data.c (arith_driver, float_arith_driver): Likewise.
3543 * editfns.c (general_insert_function): Likewise.
3544 * eval.c (struct backtrace.nargs, interactive_p)
3545 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3546 (funcall_lambda, mark_backtrace): Likewise.
3547 * fns.c (concat): Likewise.
3548 * frame.c (x_set_frame_parameters): Likewise.
3549 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3550 0 if not found, not -1. All callers changed.
3551
dd3f25f7
PE
3552 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3553 (stack_copy_size): Now size_t, not int.
3554 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3555
461c2ab9
JB
35562011-03-28 Juanma Barranquero <lekktu@gmail.com>
3557
3558 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3559 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3560 All callers changed.
3561
3562 * lisp.h (multibyte_char_to_unibyte):
3563 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3564 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3565 * character.h (CHAR_TO_BYTE8):
3566 * cmds.c (internal_self_insert):
3567 * editfns.c (general_insert_function):
3568 * keymap.c (push_key_description):
3569 * search.c (Freplace_match):
3570 * xdisp.c (message_dolog, set_message_1): All callers changed.
3571
f6d62986
SM
35722011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3573
3574 * keyboard.c (safe_run_hook_funcall): New function.
3575 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3576 don't set the hook to nil, but remove the offending function instead.
3577 (Qcommand_hook_internal): Remove, unused.
3578 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3579 Vcommand_hook_internal.
3580
3581 * eval.c (enum run_hooks_condition): Remove.
3582 (funcall_nil, funcall_not): New functions.
3583 (run_hook_with_args): Call each function through a `funcall' argument.
3584 Remove `cond' argument, now redundant.
3585 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3586 (Frun_hook_with_args_until_failure): Adjust accordingly.
3587 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3588
1db5b1ad
JB
35892011-03-28 Juanma Barranquero <lekktu@gmail.com>
3590
3591 * dispextern.h (string_buffer_position): Remove declaration.
3592
3593 * print.c (strout): Remove parameter `multibyte', unused since
3594 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3595
3596 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3597 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3598 All callers changed.
3599
3600 * w32.c (_wsa_errlist): Use braces for struct initializers.
3601
3602 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3603 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3604 All callers changed.
3605 (string_buffer_position): Likewise. Also, make static (it's never
3606 used outside xdisp.c).
3607 (cursor_row_p): Remove parameter `w', unused since
3608 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3609 (decode_mode_spec): Remove parameter `precision', introduced during
3610 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3611 All callers changed.
3612
5ffb62aa
JD
36132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3614
3615 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3616
461c2ab9 36172011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3618
3619 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3620 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3621 (ns_update_auto_hide_menu_bar): New functions.
3622 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3623 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3624 ns_constrain_all_frames.
3625 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3626 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3627
5c380ffb
JD
36282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3629
3630 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3631
9af30bdf
GM
36322011-03-27 Glenn Morris <rgm@gnu.org>
3633
3634 * syssignal.h: Replace RETSIGTYPE with void.
3635 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3636 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3637 Replace SIGTYPE with void everywhere.
3638 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3639 * s/template.h (SIGTYPE): Remove commented out definition.
3640
e2abce01
JB
36412011-03-26 Eli Zaretskii <eliz@gnu.org>
3642
3643 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3644 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3645
f868cd8a
JB
36462011-03-26 Juanma Barranquero <lekktu@gmail.com>
3647
59eb0929
JB
3648 * w32.c (read_unc_volume): Use parameter `henum', instead of
3649 global variable `wget_enum_handle'.
3650
3651 * keymap.c (describe_vector): Remove parameters `indices' and
3652 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3653 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3654
f868cd8a
JB
3655 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3656
3657 * keyboard.c (timer_check): Remove parameter `do_it_now',
3658 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3659 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3660 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3661
3662 * keyboard.c (read_char):
3663 * w32menu.c (w32_menu_display_help):
3664 * xmenu.c (show_help_event, menu_help_callback):
3665 Adjust calls to `show_help_echo'.
3666
3667 * gtkutil.c (xg_maybe_add_timer):
3668 * keyboard.c (readable_events):
3669 * process.c (wait_reading_process_output):
3670 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3671
3672 * insdel.c (adjust_markers_gap_motion):
3673 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3674 (gap_left, gap_right): Don't call it.
3675
2ecf6fdb
CY
36762011-03-25 Chong Yidong <cyd@stupidchicken.com>
3677
3678 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3679 incurred during fontification.
3680
6b1f9ba4
JB
36812011-03-25 Juanma Barranquero <lekktu@gmail.com>
3682
3683 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3684 (DEFVAR_PER_BUFFER): Don't pass it.
3685
3686 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3687 (scrolling_window): Don't pass it.
3688
0f4a96b5
JB
36892011-03-25 Juanma Barranquero <lekktu@gmail.com>
3690
3691 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3692
3693 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3694 and `suffix'.
3695 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3696 of variables specific to SELinux and computation of `encoded_absname'.
3697
3698 * image.c (XPutPixel): Remove unused variable `height'.
3699
3700 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3701
3702 * unexw32.c (get_section_info): Remove unused variable `section'.
3703
3704 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3705 (system_process_attributes): Remove unused variable `sess'.
3706 (sys_read): Remove unused variable `err'.
3707
3708 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3709 (w32_wnd_proc): Remove unused variable `isdead'.
3710 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3711 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3712 (x_create_tip_frame): Remove unused variable `tem'.
3713
3714 * w32inevt.c (w32_console_read_socket):
3715 Remove unused variable `no_events'.
3716
3717 * w32term.c (x_draw_composite_glyph_string_foreground):
3718 Remove unused variable `width'.
3719
1149507c
JB
37202011-03-24 Juanma Barranquero <lekktu@gmail.com>
3721
3722 * w32term.c (x_set_glyph_string_clipping):
3723 Don't pass uninitialized region to CombineRgn.
3724
9c88f339
JB
37252011-03-23 Juanma Barranquero <lekktu@gmail.com>
3726
3727 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3728 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3729 (Fx_close_connection): Remove unused variable `i'.
3730
3731 * w32font.c (w32font_draw): Return number of glyphs.
3732 (w32font_open_internal): Remove unused variable `i'.
3733 (w32font_driver): Add missing initializer.
3734
3735 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3736 (fill_in_menu): Remove unused variable `items_added'.
3737
3738 * w32term.c (last_mouse_press_frame): Remove static global variable.
3739 (w32_clip_to_row): Remove unused variable `f'.
3740 (x_delete_terminal): Remove unused variable `i'.
3741
3742 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3743 (NOTHING): Remove unused static global variable.
3744 (uniscribe_check_otf): Remove unused variable `table'.
3745 (uniscribe_font_driver): Add missing initializers.
3746
dee091a3
JD
37472011-03-23 Julien Danjou <julien@danjou.info>
3748
3749 * term.c (Fsuspend_tty, Fresume_tty):
3750 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3751 * window.c (temp_output_buffer_show):
3752 * insdel.c (signal_before_change):
3753 * frame.c (Fhandle_switch_frame):
3754 * fileio.c (Fdo_auto_save):
3755 * emacs.c (Fkill_emacs):
3756 * editfns.c (save_excursion_restore):
3757 * cmds.c (internal_self_insert):
3758 * callint.c (Fcall_interactively):
3759 * buffer.c (Fkill_all_local_variables):
3760 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3761 Use Frun_hooks.
0f4a96b5 3762 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3763 unconditionnaly since it does the check itself.
3764
2c520ab5 37652011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3766
c9c49752
PE
3767 Fix more problems found by GCC 4.5.2's static checks.
3768
8abc3f12
PE
3769 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3770 the first time through the loop, since we know p0 < p1 then.
3771 This also avoids a gcc -Wstrict-overflow warning.
3772
a2d26660
PE
3773 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3774 leading to a memory leak, possible in functions like
3775 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3776 of objects (Bug#8318).
a2d26660 3777
916c72e9
PE
3778 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3779 that could (at least in theory) be that large.
3780
19ab8a18
PE
3781 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3782 This is less likely to overflow, and avoids undefined behavior if
3783 overflow does occur. All callers changed. Use strtoul to scan
3784 for the unsigned long integer.
b7cbbd6f
PE
3785 (pint2hrstr): Simplify and tune code slightly.
3786 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3787
f0641eff
PE
3788 * scroll.c (do_scrolling): Work around GCC bug 48228.
3789 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3790
7f650bb9
PE
3791 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3792 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3793 (validate_x_resource_name): Simplify count usage.
3794 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3795
37dd57d1
PE
3796 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3797 fail (Bug#8306).
81e56e61 3798
699979fc 3799 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3800
401bf9b4
PE
3801 * process.c (Fmake_network_process): Use socklen_t, not int,
3802 where POSIX says socklen_t is required in portable programs.
3803 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3804 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3805 (Fmake_network_process, server_accept_connection):
3806 (wait_reading_process_output, read_process_output):
3807 Likewise.
3808
b93aacde
PE
3809 * process.c: Rename or move locals to avoid shadowing.
3810 (list_processes_1, Fmake_network_process):
3811 (read_process_output_error_handler, exec_sentinel_error_handler):
3812 Rename or move locals.
4dc343ee 3813 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3814 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3815 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3816 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3817 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3818
af8a867c 3819 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3820 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3821 Include tparam.h instead, since it declares them.
af8a867c
PE
3822 * cm.h (PC): Remove extern decl; tparam.h now does this.
3823 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3824 * terminfo.c: Include tparam.h, to check interfaces.
3825 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3826 (tparam): Adjust signature to match interface in tparam.h;
3827 this removes some undefined behavior. Check that outstring and len
3828 are zero, which they always are with Emacs.
3829 * tparam.h (PC, BC, UP): New extern decls.
3830
0248044d 3831 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3832 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3833
8ff096c1 3834 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3835 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3836 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3837 (ftfont_list): Remove unused local.
49eaafba
PE
3838 (get_adstyle_property, ftfont_pattern_entity):
3839 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3840 Rename locals to avoid shadowing.
8ff096c1 3841
e2be39f6
PE
3842 * xfont.c (xfont_list_family): Mark var as initialized.
3843
c9735e30
PE
3844 * xml.c (make_dom): Now static.
3845
8f5201ae
PE
3846 * composite.c (composition_compute_stop_pos): Rename local to
3847 avoid shadowing.
b246f932
PE
3848 (composition_reseat_it): Remove unused locals.
3849 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3850 (composition_update_it): Mark var as initialized.
11b61122
PE
3851 (find_automatic_composition): Mark vars as initialized,
3852 with a FIXME (Bug#8290).
8f5201ae 3853
760fbc2c
PE
3854 character.h: Rename locals to avoid shadowing.
3855 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3856 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3857 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3858 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3859 to avoid shadowing.
3860
ff08eb85
PE
3861 * textprop.c (property_change_between_p): Remove; unused.
3862
fc7bf025
PE
3863 * intervals.c (interval_start_pos): Now static.
3864
235d7abc
PE
3865 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3866
44f230aa
SM
3867 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3868 Rename locals to avoid shadowing.
3e7d6594 3869
50060332
PE
3870 * sound.c (wav_play, au_play, Fplay_sound_internal):
3871 Fix pointer signedness.
d01f234b 3872 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3873 (wav_play): Initialize a variable to 0, to prevent undefined
3874 behavior (Bug#8278).
50060332 3875
c4fc4e30
PE
3876 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3877
918436ed
PE
3878 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3879
c939f91b
PE
3880 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3881 clobbering (Bug#8298).
b9c7f648
PE
3882 * sysdep.c (sys_subshell): Likewise.
3883 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3884
6bd8c144
PE
3885 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3886 This should get cleaned up, so that child_setup has the
3887 same signature on all platforms.
3888
7710357c 3889 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3890 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3891
c59da222
CY
38922011-03-22 Chong Yidong <cyd@stupidchicken.com>
3893
3894 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3895 not to be necessary, and produces flickering.
3896
66b87493
GM
38972011-03-20 Glenn Morris <rgm@gnu.org>
3898
3899 * config.in: Remove file.
3900
45b6f6d5
JB
39012011-03-20 Juanma Barranquero <lekktu@gmail.com>
3902
3903 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3904 are now in src/globals.h.
3905 (syms_of_minibuf): Remove spurious & from previous change.
3906
3ec03f7e
LL
39072011-03-20 Leo <sdl.web@gmail.com>
3908
3909 * minibuf.c (completing-read-function): New variable.
3910 (completing-read-default): Rename from completing-read.
3911 (completing-read): Call completing-read-function.
3912
b14e3e21
CY
39132011-03-19 Juanma Barranquero <lekktu@gmail.com>
3914
3915 * xfaces.c (Fx_load_color_file):
3916 Read color file from absolute filename (bug#8250).
3917
f2b726e6
JB
39182011-03-19 Juanma Barranquero <lekktu@gmail.com>
3919
3920 * makefile.w32-in: Update dependencies.
3921
09f6ff02
EZ
39222011-03-17 Eli Zaretskii <eliz@gnu.org>
3923
3924 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3925
29a6015a
PE
39262011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3927
a3a6c54e
PE
3928 Fix more problems found by GCC 4.5.2's static checks.
3929
b766f867
PE
3930 * process.c (make_serial_process_unwind, send_process_trap):
3931 (sigchld_handler): Now static.
3932
be02381c
PE
3933 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3934 That way, the code declares only the vars that it needs.
3935 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3936 * s/cygwin.h (PTY_ITERATION): Likewise.
3937 * s/darwin.h (PTY_ITERATION): Likewise.
3938 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3939
57048744
PE
3940 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3941 * process.c (allocate_pty): Don't declare stb unless it's needed.
3942
7914961c 3943 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3944 (CONSTANTLIM): Remove; unused.
3945 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3946 Define only if needed.
7914961c 3947
b3967b18
PE
3948 * unexelf.c (unexec): Name an expression,
3949 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3950 Use a different way to cause a compilation error if anyone uses
3951 n rather than nn, a way that does not involve shadowing.
73366a00 3952 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3953
29a6015a
PE
3954 * deps.mk (unexalpha.o): Remove; unused.
3955
43cfc33e 3956 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3957 * unexec.h: New file.
ce701a33
PE
3958 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3959 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3960 Depend on unexec.h.
3961 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3962 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3963 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3964 Change as necessary to match prototype in unexec.h.
ce701a33 3965
01f44d5a
PE
3966 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3967 shadowing.
4f63c6bb 3968 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3969
a6670b0b
PE
3970 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3971 Rename locals to avoid shadowing.
3972
cef2010d 3973 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3974 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3975
d4d7173a
PE
3976 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3977
f08b802a
PE
3978 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3979 warning when compiling print.c.
3980
3ddb0639
PE
3981 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3982 instead of using an uninitialized var.
5ad03b97 3983 (font_sort_entities): Mark var as initialized.
3ddb0639 3984
170a2692
PE
3985 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3986
e663c700
PE
3987 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3988 pointers to constants.
89bc529a 3989 (font_parse_fcname): Remove unused vars.
7b81e2d0 3990 (font_delete_unmatched): Now static.
ea838e10 3991 (font_get_spec): Remove; unused.
13a547c6
PE
3992 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3993 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3994 Rename or move locals to avoid shadowing.
e663c700 3995
2a80c887 3996 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3997 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3998
1384fa33 3999 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4000 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4001
8b2c52e9
PE
4002 * alloc.c (mark_backtrace): Move decl from here ...
4003 * lisp.h: ... to here, so that it can be checked.
4004
475545b5 4005 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4006 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4007 (lisp_indirect_variable): Name an expression,
4008 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4009 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4010
b1349114 4011 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4012 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4013 Use const pointer when appropriate.
b1349114 4014
a2928364
PE
4015 * lisp.h (get_system_name, get_operating_system_release):
4016 Move decls here, to check interfaces.
4017 * process.c (get_operating_system_release): Move decl to lisp.h.
4018 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4019 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4020 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4021 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4022 (Fformat_time_string, Fencode_time, Finsert_char):
4023 (Ftranslate_region_internal, Fformat):
4024 Rename or remove local vars to avoid shadowing.
9710023e 4025 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4026
a415e694
PE
4027 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4028 avoid shadowing.
4029
8ef4622d
PE
4030 * lisp.h (eassert): Check that the argument compiles, even if
4031 ENABLE_CHECKING is not defined.
4032
946f9a5b
PE
4033 * data.c (Findirect_variable): Name an expression, to avoid
4034 gcc -Wbad-function-cast warning.
112396d6 4035 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4036 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4037 (Fmake_variable_buffer_local, Fmake_local_variable):
4038 Mark variables as initialized.
52746918 4039 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4040
e5aab7e7 4041 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4042 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4043 Rename locals to avoid shadowing.
dff45157
PE
4044 (mark_stack): Move local variables into the #ifdef region where
4045 they're used.
7bc26fdb
PE
4046 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4047 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4048 needed otherwise.
4049 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4050 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4051 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4052
e5aab7e7
PE
4053 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4054 avoids undefined behavior in theory.
4055
4da60324
PE
4056 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4057
88043301
PE
4058 Use functions, not macros, for up- and down-casing (Bug#8254).
4059 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4060 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4061 to use the following functions instead of these macros.
4062 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4063 EMACS_INT, since callers assume the returned value fits in int.
4064 (upcase1): Likewise, for UPCASE_TABLE.
4065 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4066 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4067 the race-condition problem in the old DOWNCASE.
88043301 4068
19ed5445
PE
4069 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4070 Rename locals to avoid shadowing.
4071 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4072 (regex_compile, re_search_2, re_match_2_internal):
4073 Remove unused local vars.
952db0d7
PE
4074 (FREE_VAR): Rewrite so as not to use empty "else",
4075 which gcc can warn about.
da053e48 4076 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4077 (RETALLOC_IF): Define only if needed.
4078 (WORDCHAR_P): Likewise. This one is never needed, but is used
4079 only in a comment talking about a compiler bug, so put inside
4080 the #if 0 of that comment.
4081 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4082 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4083 Remove; unused.
19ed5445 4084
1f3561e4 4085 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4086 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4087 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4088
ded6f8f7
PE
4089 * search.c (simple_search): Remove unused var.
4090
dbd37a95
PE
4091 * dired.c (compile_pattern): Move decl from here ...
4092 * lisp.h: ... to here, so that it can be checked.
4093 (struct re_registers): New forward decl.
4094
7e47afad
PE
4095 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4096
85f24f61
PE
4097 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4098 All uses changed.
4099 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4100 Rename locals to avoid shadowing.
5671df8f 4101 (Fvertical_motion): Mark locals as initialized.
85f24f61 4102
181aa2be 4103 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4104 (casify_region): Mark local as initialized.
181aa2be 4105
930d429c
PE
4106 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4107
7082eac6
PE
4108 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4109 New macros, so that the caller can use some names other than
4110 gcpro1, gcpro2, etc.
4111 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4112 of the new macros.
4113 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4114 argument, for consistency with GCPRO2_VAR, etc: it is now the
4115 prefix of the variable, not the variable itself. All uses
4116 changed.
38b2c076
PE
4117 * dired.c (directory_files_internal, file_name_completion):
4118 Rename locals to avoid shadowing.
4119
15206ed9
PE
4120 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4121 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4122 dired.c's scmp function, had undefined behavior.
4123 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4124 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4125 * buffer.h: ... to here, because these macros use current_buffer,
4126 and the new implementation with inline functions needs to have
4127 current_buffer in scope now, rather than later when the macros
4128 are used.
4129 (downcase, upcase1): New static inline functions.
4130 (DOWNCASE, UPCASE1): Reimplement using these functions.
4131 This avoids undefined behavior in expressions like
4132 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4133 from race conditions in accessing the global variables
4134 case_temp1 and case_temp2.
4135 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4136 * lisp.h (case_temp1, case_temp2): Remove their decls.
4137 * character.h (ASCII_CHAR_P): Move from here ...
4138 * lisp.h: ... to here, so that the inline functions mentioned
4139 above can use them.
4140
4a6bea26
PE
4141 * dired.c (directory_files_internal_unwind): Now static.
4142
f14b7e14
PE
4143 * fileio.c (file_name_as_directory, directory_file_name):
4144 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4145 Now static.
2893f146
PE
4146 (file_name_as_directory): Use const pointers when appropriate.
4147 (Fexpand_file_name): Likewise. In particular, newdir might
4148 point at constant storage, so make it a const pointer.
fd4ead52 4149 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4150 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4151 signedness issues.
f839df0c
PE
4152 (Fset_file_times, Finsert_file_contents, auto_save_error):
4153 Rename locals to avoid shadowing.
f14b7e14 4154
5716756e 4155 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4156 (Ftry_completion, Fall_completions): Rename or remove locals
4157 to avoid shadowing.
5716756e 4158
b4c3046a
PE
4159 * marker.c (bytepos_to_charpos): Remove; unused.
4160
b45db522
PE
4161 * lisp.h (verify_bytepos, count_markers): New decls,
4162 so that gcc does not warn that these functions aren't declared.
4163
85876d07
PE
4164 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4165 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4166 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4167 (copy_text): Remove unused local var.
85876d07 4168
03d78a21 4169 * filelock.c (within_one_second): Now static.
b3dd38ab 4170 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4171
5df8f01b
PE
4172 * buffer.c (fix_overlays_before): Mark locals as initialized.
4173 (fix_start_end_in_overlays): Likewise. This function should be
4174 simplified by using pointers-to-pointers, but that's a different
4175 matter.
b1d876f1 4176 (switch_to_buffer_1): Now static.
8f54f30a
PE
4177 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4178 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4179
a70072c9 4180 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4181 Fix pointer signedness issue.
edced198
PE
4182 (sys_subshell): Mark local as volatile if checking for lint,
4183 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4184 (MAXPATHLEN): Define only if needed.
a70072c9 4185
a0977c44
PE
4186 * process.c (serial_open, serial_configure): Move decls from here ...
4187 * systty.h: ... to here, so that they can be checked.
4188
a884fdcc
PE
4189 * fns.c (get_random, seed_random): Move extern decls from here ...
4190 * lisp.h: ... to here, so that they can be checked.
4191
604efe86 4192 * sysdep.c (reset_io): Now static.
b8950c94 4193 (wait_for_termination_signal): Remove; unused.
604efe86 4194
38fc62d9
PE
4195 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4196 (copy_keymap_item, append_key, push_text_char_description):
4197 Now static.
1004a21a 4198 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4199 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4200 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4201 (describe_map_tree):
4202 Rename locals to avoid shadowing.
38fc62d9 4203
2f2650da
PE
4204 * keyboard.c: Declare functions static if they are not used elsewhere.
4205 (echo_char, echo_dash, cmd_error, top_level_2):
4206 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4207 (read_char, kbd_buffer_get_event, make_lispy_position):
4208 (make_lispy_event, make_lispy_movement, apply_modifiers):
4209 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4210 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4211 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4212 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4213 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4214
a053e86c 4215 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4216 (mark_kboards): Move decl here ...
4217 * alloc.c (mark_kboards): ... from here.
a053e86c 4218
4752793e
PE
4219 * lisp.h (force_auto_save_soon): New decl.
4220
74f10ca7 4221 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4222 (DEFINE_DUMMY_FUNCTION): New macro.
4223 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4224 Use it.
c03cd23f
PE
4225 (main): Add casts to avoid warnings
4226 if GCC considers string literals to be constants.
74f10ca7 4227
022e70d4
PE
4228 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4229
59d6fe83
PE
4230 * dbusbind.c: Pointer signedness fixes.
4231 (xd_signature, xd_append_arg, xd_initialize):
4232 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4233 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4234 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4235 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4236
78320123
PE
4237 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4238 if GCC considers string literals to be constants.
49cebcca 4239 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4240
35ac2a97
SM
42412011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4242
fb103ca9
SM
4243 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4244 (print_preprocess, print_object): New macro to fix last change.
4245
35ac2a97
SM
4246 * print.c (print_preprocess): Don't forget font objects.
4247
62973b41
JB
42482011-03-16 Juanma Barranquero <lekktu@gmail.com>
4249
4250 * emacs.c (USAGE3): Doc fixes.
4251
0e48bb22
AS
42522011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4253
4254 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4255 structure.
4256
7684e57b
JB
42572011-03-14 Juanma Barranquero <lekktu@gmail.com>
4258
4259 * lisp.h (VWindow_system, Qfile_name_history):
4260 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4261 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4262 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4263
4264 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4265 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4266
4267 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4268 * w32console.c (detect_input_pending, read_input_pending)
4269 (encode_terminal_code):
4270 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4271 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4272 (w32_system_caret_y, Qfile_name_history):
4273 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4274 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4275 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4276 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4277 * w32proc.c (Qlocal, report_file_error):
4278 * w32term.c (Vwindow_system, updating_frame):
4279 * w32uniscribe.c (initialized, uniscribe_font_driver):
4280 Remove unneeded extern declarations.
4281
2aa46d6c
CY
42822011-03-14 Chong Yidong <cyd@stupidchicken.com>
4283
c96bbc66 4284 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4285
cffc6f3b
CY
42862011-03-13 Chong Yidong <cyd@stupidchicken.com>
4287
4288 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4289 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4290 These macros can no longer be used for assignment.
4291
44f230aa
SM
4292 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4293 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4294 (record_buffer_markers, fetch_buffer_markers): New functions for
4295 recording and fetching special buffer markers.
4296 (set_buffer_internal_1, set_buffer_temp): Use them.
4297
4298 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4299
4300 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4301
4302 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4303 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4304
4305 * xdisp.c (hscroll_window_tree):
4306 (reconsider_clip_changes): Use PT instead of BUF_PT.
4307
d251f04b
EZ
43082011-03-13 Eli Zaretskii <eliz@gnu.org>
4309
4310 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4311 $(EMACS_ROOT)/lib/intprops.h.
4312
f0c77cd1
PE
43132011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4314
3eca4629
PE
4315 Fix more problems found by GCC 4.5.2's static checks.
4316
7c86ee98
PE
4317 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4318 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4319 (xg_free_frame_widgets): Make it clear that a local variable is
4320 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4321 (gdk_window_get_screen): Make it clear that this macro is needed
4322 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4323 (int_gtk_range_get_value): New function, which avoids a diagnostic
4324 from gcc -Wbad-function-cast.
4325 (xg_set_toolkit_scroll_bar_thumb): Use it.
4326 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4327 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4328 (get_utf8_string, xg_get_file_with_chooser):
4329 Rename locals to avoid shadowing.
4330 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4331
41729b81
PE
4332 * xgselect.c (xg_select): Remove unused var.
4333
f0c77cd1
PE
4334 * image.c (four_corners_best): Mark locals as initialized.
4335 (gif_load): Initialize transparent_p to zero (Bug#8238).
4336 Mark another local as initialized.
ec6cf4c6 4337 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4338
ce0ad53d 4339 * image.c (clear_image_cache): Now static.
d5d5a617 4340 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4341 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4342 (x_edge_detection): Remove unnecessary cast that
4343 gcc -Wbad-function-cast diagnoses.
2037898d 4344 (gif_load): Fix pointer signedness.
6ae141d6
PE
4345 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4346 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4347
33383987 43482011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4349
d32df629
PE
4350 Improve quality of tests for time stamp overflow.
4351 For example, without this patch (encode-time 0 0 0 1 1
4352 1152921504606846976) returns the obviously-bogus value (-948597
4353 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4354 reports time overflow. See
4355 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4356 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4357 * editfns.c: Include limits.h and intprops.h.
4358 (TIME_T_MIN, TIME_T_MAX): New macros.
4359 (time_overflow): Move earlier, to before first use.
4360 (hi_time, lo_time): New functions, for an accurate test for
4361 out-of-range times.
4362 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4363 (Fget_internal_run_time): Don't assume time_t fits in int.
4364 (make_time): Use list2 instead of Fcons twice.
4365 (Fdecode_time): More accurate test for out-of-range times.
4366 (check_tm_member): New function.
4367 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4368 (lisp_time_argument): Don't rely on undefined left-shift and
4369 right-shift behavior when checking for time stamp overflow.
8be6f318 4370
fe31d94c
PE
4371 * editfns.c (time_overflow): New function, refactoring common code.
4372 (Fformat_time_string, Fdecode_time, Fencode_time):
4373 (Fcurrent_time_string): Use it.
4374
8be6f318
PE
4375 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4376 * dired.c (make_time): Move to ...
4377 * editfns.c (make_time): ... here.
4378 * systime.h: Note the move.
4379
09d9db2c 43802011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4381
126bc0dc
YM
4382 * fringe.c (update_window_fringes): Remove unused variables.
4383
c47cbdfd
YM
4384 * unexmacosx.c (copy_data_segment): Also copy __got section.
4385 (Bug#8223)
4386
7ac80be9
EZ
43872011-03-12 Eli Zaretskii <eliz@gnu.org>
4388
c96bbc66 4389 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4390 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4391 Constify `char *' arguments and their references according to
4392 prototypes in tparam.h.
4393
ecb0f94d 4394 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4395
7ac80be9
EZ
4396 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4397 Adapt all references accordingly.
4398
4399 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4400
ef1fd07e
TT
44012011-03-11 Tom Tromey <tromey@redhat.com>
4402
4403 * buffer.c (syms_of_buffer): Remove obsolete comment.
4404
7ef4b50c
EZ
44052011-03-11 Eli Zaretskii <eliz@gnu.org>
4406
4407 * termhooks.h (encode_terminal_code): Declare prototype.
4408
4409 * msdos.c (encode_terminal_code): Don't declare prototype.
4410
4411 * term.c (encode_terminal_code): Now external again, used by
4412 w32console.c and msdos.c.
4413
44f230aa
SM
4414 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4415 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4416
4b1ec863 44172011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4418
1714f52b 4419 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4420
4b1ec863
PE
4421 * fringe.c (update_window_fringes): Mark locals as initialized
4422 (Bug#8227).
4423 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4424
524c7aa6
PE
4425 * alloc.c (mark_fringe_data): Move decl from here ...
4426 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4427 to check its interface.
4428 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4429
a5c0af81 4430 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4431 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4432 (fontset_font): Mark local as initialized.
a9a06e0b 4433 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4434
b4716021
PE
4435 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4436
811e9bac 4437 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4438 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4439 (x_own_selection, Fx_disown_selection_internal): Rename locals
4440 to avoid shadowing.
4441 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4442
7e3ab302
PE
4443 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4444 so that the caller can use some name other than gcpro1.
4445 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4446 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4447 (Fx_backspace_delete_keys_p):
4448 Use them to avoid shadowing, and rename vars to avoid shadowing.
4449 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4450 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4451 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4452 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4453 Remove unused locals.
7e3ab302
PE
4454 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4455 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4456 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4457 macros.
f78faa98 4458
e2b13473
PE
4459 * xterm.h (x_mouse_leave): New decl.
4460
77f23912
PE
4461 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4462 Remove unused functions.
cdf4ba58
PE
4463 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4464 (x_calc_absolute_position): Now static.
7411c686 4465 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4466 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4467 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4468 unless they are used.
38d0b34a
PE
4469 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4470 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4471 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4472 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4473 (x_error_catcher, x_connection_closed, x_error_handler):
4474 (x_error_quitter, xembed_send_message, x_iconify_frame):
4475 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4476 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4477 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4478
44f230aa
SM
4479 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4480 Rename or move locals to avoid shadowing.
6b463e58 4481 (tty_defined_color, merge_face_heights): Now static.
5967d051 4482 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4483 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4484 does not deduce is never used uninitialized.
73719eba
PE
4485 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4486 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4487
426994c3 4488 * terminal.c (store_terminal_param): Now static.
5489860b 4489
032f1620 4490 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4491 (set_frame_menubar): Remove unused local.
d4323972 4492 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4493 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4494 since they might point to immutable storage.
281585b0
PE
4495 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4496 since it's unused otherwise.
032f1620 4497
367c19e5 4498 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4499 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4500 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4501 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4502 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4503 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4504 does not deduce are never used uninitialized.
70739cbe 4505
07b48fa9
PE
4506 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4507
8868a238 4508 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4509 * window.c (window_loop, size_window):
4510 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4511
7e5cf297 4512 * window.c (display_buffer): Now static.
d6550a9f
PE
4513 (size_window): Mark variables that gcc -Wuninitialized
4514 does not deduce are never used uninitialized.
a586633d
PE
4515 * window.h (check_all_windows): New decl, to forestall
4516 gcc -Wmissing-prototypes diagnostic.
5b555da1 4517 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4518
f6095868
PE
4519 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4520 shadowing.
4521 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4522 Include <limits.h>.
4523 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4524 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4525 (load_charset_map): Mark variables that gcc -Wuninitialized
4526 does not deduce are never used uninitialized.
53df7c11 4527 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4528
f38b440c
PE
4529 * coding.c (coding_set_source, coding_set_destination):
4530 Use "else { /* comment */ }" rather than "else /* comment */;"
4531 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4532 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4533 a block, when the outer 'i' will do.
4534 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4535 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4536 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4537 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4538 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4539 Rename locals to avoid shadowing.
4540 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4541 * coding.c (emacs_mule_char, encode_invocation_designation):
4542 Now static, since they're not used elsewhere.
413bb2db 4543 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4544 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4545 (decode_coding_emacs_mule): Mark variables that gcc
4546 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4547 (detect_coding_iso_2022): Initialize a local variable that might
4548 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4549 this initialization is needed. (Bug#8211)
5f58e762
PE
4550 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4551 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4552 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4553 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4554 Remove unused macros.
f38b440c 4555
232b38b9 4556 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4557 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4558 * character.c (string_count_byte8): Likewise.
232b38b9 4559
fb90da1b
PE
4560 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4561 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4562
fb93dbc2
PE
4563 * chartab.c (copy_sub_char_table): Now static, since it's not used
4564 elsewhere.
5c156ace
PE
4565 (sub_char_table_ref_and_range, char_table_ref_and_range):
4566 Rename locals to avoid shadowing.
bbcd0949 4567 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4568
7d3b3862 4569 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4570 (BIDI_BOB): Remove unused macro.
7d3b3862 4571
6be7d3da
PE
4572 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4573 deduce are never used uninitialized.
c2ed9c8b 4574 * term.c (encode_terminal_code): Likewise.
6be7d3da 4575
75f8807f 4576 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4577
50938595
PE
4578 * tparam.h: New file.
4579 * term.c, tparam.h: Include it.
4580 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4581 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4582 Move these decls to tparam.h, and make them agree with what
4583 is actually in tparam.c. The previous trick of using incompatible
4584 decls in different modules does not conform to the C standard.
4585 All callers of tparam changed to use tparam's actual API.
4586 * tparam.c (tparam1, tparam, tgoto):
4587 Use const pointers where appropriate.
4588
fbceeba2
PE
4589 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4590 * cm.h (struct cm): Likewise.
4591 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4592 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4593 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4594 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4595 (turn_on_face, init_tty): Likewise.
4596 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4597
7f3f1250
PE
4598 * term.c (term_mouse_position): Rename local to avoid shadowing.
4599
e6ca6543
PE
4600 * alloc.c (mark_ttys): Move decl from here ...
4601 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4602
c40f8d15
AS
46032011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4604
4605 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4606
cfe0661d
JB
46072011-03-09 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * search.c (compile_pattern_1): Remove argument regp, unused since
4610 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4611 (compile_pattern): Don't pass it.
4612
0afb4571
J
46132011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4614
4615 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4616 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4617 for ! HAVE_GTK3.
4618 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4619
4620 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4621
4622 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4623 gdk_window_get_screen, gdk_window_get_geometry,
4624 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4625 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4626 (xg_get_pixbuf_from_pixmap): New function.
4627 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4628 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4629 Call xg_get_pixbuf_from_pixmap instead of
4630 gdk_pixbuf_get_from_drawable.
4631 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4632 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4633 (xg_check_special_colors): Use GtkStyleContext and its functions
4634 for HAVE_GTK3.
4635 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4636 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4637 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4638 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4639 Call gtk_widget_get_preferred_size.
0afb4571
J
4640 (xg_frame_resized): gdk_window_get_geometry only takes 5
4641 parameters.
44f230aa
SM
4642 (xg_win_to_widget, xg_event_is_for_menubar):
4643 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4644 (xg_set_widget_bg): New function.
4645 (delete_cb): New function.
895009e1 4646 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4647 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4648 (xg_set_background_color): Call xg_set_widget_bg.
4649 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4650 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4651 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4652 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4653 if ! HAVE_GTK3.
4654 (update_frame_tool_bar): Call gtk_widget_hide.
4655 (xg_initialize): Use GDK_KEY_g.
4656
4657 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4658 if ! HAVE_GTK3
4659 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4660
4661 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4662 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4663 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4664
1c2cc4ef
JB
46652011-03-08 Juanma Barranquero <lekktu@gmail.com>
4666
4667 * w32xfns.c (select_palette): Check success of RealizePalette against
4668 GDI_ERROR, not zero.
4669
33383987 4670See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4671
4672;; Local Variables:
4673;; coding: utf-8
aac0c6e3
MR
4674;; End:
4675
33383987 4676 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4677
4678 This file is part of GNU Emacs.
4679
4680 GNU Emacs is free software: you can redistribute it and/or modify
4681 it under the terms of the GNU General Public License as published by
4682 the Free Software Foundation, either version 3 of the License, or
4683 (at your option) any later version.
4684
4685 GNU Emacs is distributed in the hope that it will be useful,
4686 but WITHOUT ANY WARRANTY; without even the implied warranty of
4687 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4688 GNU General Public License for more details.
4689
4690 You should have received a copy of the GNU General Public License
4691 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.