* xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
78eb494e
PE
12011-05-11 Paul Eggert <eggert@cs.ucla.edu>
2
5235bd3e
PE
3 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4 Before, the code was not consistent. These values cannot exceed
5 2**31 - 1 so there's no need to make them unsigned.
6 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9 as modifiers.
10 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11
bc827e23
PE
12 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
13 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
15 presumably because the widths might not match.
16
78eb494e
PE
17 * window.c (size_window): Avoid needless test at loop start.
18
2f142cc5
JB
192011-05-10 Juanma Barranquero <lekktu@gmail.com>
20
21 * image.c (Finit_image_library): Return t for built-in image types,
22 like pbm and xbm. (Bug#8640)
23
57679c86
AS
242011-05-09 Andreas Schwab <schwab@linux-m68k.org>
25
26 * w32menu.c (set_frame_menubar): Fix submenu allocation.
27
888c9e86
EZ
282011-05-07 Eli Zaretskii <eliz@gnu.org>
29
b0512a1d
EZ
30 * w32console.c (Fset_screen_color): Doc fix.
31 (Fget_screen_color): New function.
32 (syms_of_ntterm): Defsubr it.
33
888c9e86
EZ
34 * callproc.c (call_process_cleanup): Don't close and unlink the
35 temporary file if Fcall_process didn't create it in the first
36 place.
37 (Fcall_process): Don't create tempfile if stdout of the child
38 process will be redirected to a file specified with `:file'.
39 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
40 cue to call_process_cleanup not to close that handle.
41
4d3fcc8e
BK
422011-05-07 Ben Key <bkey76@gmail.com>
43
44 * makefile.w32-in: The bootstrap-temacs rule now makes use of
45 one of two shell specific rules, either bootstrap-temacs-CMD or
46 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
47 to the previous implementation of the bootstrap-temacs rule.
48 The bootstrap-temacs-CMD rule is similar to the previous
49 implementation of the bootstrap-temacs rule except that it
50 makes use of the ESC_CFLAGS variable instead of the CFLAGS
51 variable.
52
53 These changes, along with some changes to nt/configure.bat,
54 nt/gmake.defs, and nt/nmake.defs, are required to extend my
55 earlier fix to add support for --cflags and --ldflags options
56 that include quotes so that it works whether make uses cmd or
57 sh as the shell.
58
b4289b64
MA
592011-05-06 Michael Albinus <michael.albinus@gmx.de>
60
61 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
62 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
63 is a constant.
64 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
65 a string. Handle both cases.
66 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
67 (Fdbus_register_method): Use Qinvalid_function.
68
af4c0e28
JB
692011-05-06 Juanma Barranquero <lekktu@gmail.com>
70
71 * makefile.w32-in: Update dependencies.
72 (LISP_H): Add inttypes.h and stdin.h.
73 (PROCESS_H): Add unistd.h.
74
c51453d9
EZ
752011-05-06 Eli Zaretskii <eliz@gnu.org>
76
77 * lread.c: Include limits.h (fixes the MS-Windows build broken by
78 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
79
8ff0ac3c 802011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 81
4c4b566b
PE
82 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
83
aab2b9b5
PE
84 * term.c (vfatal): Remove stray call to va_end.
85 It's not needed and the C Standard doesn't allow it here anyway.
86
c378da0b
PE
87 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
88 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
89
288b08c7
PE
90 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
91 bytes.
92
e3601888
PE
93 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
94
db6c0e74
PE
95 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
96
dd5963ea
PE
97 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
98
88c9450f
PE
99 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
100
2f9442b8
PE
101 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
102
c032b5f8
PE
103 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
104 * charset.c (Fdefine_charset_internal): Don't initialize
105 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 106 32-bit int (Bug#8600).
a108c10b
PE
107
108 * lread.c (read_integer): Be more consistent with string-to-number.
109 Use string_to_number to do the actual conversion; this avoids
110 rounding errors and fixes some other screwups. Without this fix,
111 for example, #x1fffffffffffffff was misread as -2305843009213693952.
112 (digit_to_number): Move earlier, for benefit of read_integer.
113 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 114 not a digit in any supported base. (Bug#8602)
a108c10b 115
ad5f9eea
PE
116 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
117
aec1708a
PE
118 * dispnew.c (scrolling_window): Return 1 if we scrolled,
119 to match comment at start of function. This also removes a
120 GCC warning about overflow in a 32+64-bit port.
121
47be4ab5
PE
122 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
123
371cac43
PE
124 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
125 Reported by Stefan Monnier in
126 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
127 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
128 SYMBOLP-guarded XSYMBOL, not XPNTR.
129
d01a7826
PE
130 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
131 (EMACS_UINTPTR): Likewise, with uintptr_t.
132
7fd47d5c
PE
133 * lisp.h: Prefer 64-bit EMACS_INT if available.
134 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
135 on 32-bit hosts that have 64-bit int, so that they can access
136 large files.
122b0c86
PE
137 However, temporarily disable this change unless the temporary
138 symbol WIDE_EMACS_INT is defined.
7fd47d5c 139
8727937b
PE
140 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
141
8ac068ac
PE
142 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
143 This removes an assumption that EMACS_INT and long are the same
144 width as pointers. The assumption is true for Emacs porting targets
145 now, but we want to make other targets possible.
146 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
147 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
148 In the rest of the code, change types of integers that hold casted
149 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
150 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
151 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
152 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
153 No need to cast type when ORing.
154 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
155 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
156 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
157 assume EMACS_INT is the same width as char *.
158 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
159 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
160 Remove no-longer-needed casts.
161 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
162 (xg_tool_bar_help_callback, xg_make_tool_item):
163 Use EMACS_INTPTR to hold an integer
164 that will be cast to void *; this can avoid a GCC warning
165 if EMACS_INT is not the same width as void *.
166 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
167 * xdisp.c (display_echo_area_1, resize_mini_window_1):
168 (current_message_1, set_message_1):
169 Use a local to convert to proper width without a cast.
170 * xmenu.c (dialog_selection_callback): Likewise.
171
ede49d71
PE
172 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
173 Also, don't assume VALBITS / RAND_BITS is less than 5,
174 and don't rely on undefined behavior when shifting a 1 left into
175 the sign bit.
176 * lisp.h (get_random): Change signature to match.
177
2f30ecd0
PE
178 * lread.c (hash_string): Use size_t, not int, for hash computation.
179 Normally we prefer signed values; but hashing is special, because
180 it's better to use unsigned division on hash table sizes so that
181 the remainder is nonnegative. Also, size_t is the natural width
182 for hashing into memory. The previous code used 'int', which doesn't
183 retain enough info to hash well into very large tables.
184 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
185
2a866e7b
PE
186 * dbusbind.c: Don't possibly lose pointer info when converting.
187 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
188 Use XPNTR rather than XHASH, so that the high-order bits of
189 the pointer aren't lost when converting through void *.
190
51639eac
PE
191 * eval.c (Fautoload): Don't double-shift a pointer.
192
92394119
PE
193 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
194
dbdb9a7c
JB
1952011-05-06 Juanma Barranquero <lekktu@gmail.com>
196
197 * gnutls.c (DEF_GNUTLS_FN):
198 * image.c (DEF_IMGLIB_FN): Make function pointers static.
199
db7a0b4f
AS
2002011-05-05 Andreas Schwab <schwab@linux-m68k.org>
201
202 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
203 marker. (Bug#8610)
204
f7ff1b0f 2052011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
206
207 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
208 New version that can reserve upto 2GB of heap space.
209
f7ff1b0f 2102011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
211
212 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
213
639c109b
TZ
2142011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
215
216 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
217 `gnutls_certificate_set_x509_key_file'.
218
d2127135
JB
2192011-05-05 Juanma Barranquero <lekktu@gmail.com>
220
221 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
222 Update dependencies.
223
e968f4f3
JB
2242011-05-04 Juanma Barranquero <lekktu@gmail.com>
225
226 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
227 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
228 Remove unused parameter `fildes'.
229 * process.c (read_process_output, send_process): Don't pass it.
230
84d358f0
JB
2312011-05-04 Juanma Barranquero <lekktu@gmail.com>
232
233 Fix previous change: the library cache is defined in w32.c.
234 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
235 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
236
0898ca10
JB
2372011-05-04 Juanma Barranquero <lekktu@gmail.com>
238
239 Implement dynamic loading of GnuTLS on Windows.
240
241 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
242 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
243 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
244 Declare.
245
246 * gnutls.c (Qgnutls_dll): Define.
247 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
248 (gnutls_*): Declare function pointers.
249 (init_gnutls_functions): New function to initialize function pointers.
250 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
251 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
252 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
253 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
254 (emacs_gnutls_write, emacs_gnutls_read)
255 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
256 (Fgnutls_available_p): New function.
257 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
258 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
259 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
260
261 * image.c: Include w32.h.
262 (Vimage_type_cache): Delete.
263 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
264 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
265 (w32_delayed_load): Move to w32.c.
266
267 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
268
269 * w32.c (QCloaded_from, Vlibrary_cache): Define.
270 (w32_delayed_load): Move from image.c. When loading a library, record
271 its filename in the :loaded-from property of the library id.
272 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
273 Initialize and staticpro them.
274 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
275
276 * process.c: Include lisp.h before w32.h, not after.
277 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
278 instead of gnutls_record_check_pending.
279
280 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
281
ff4de4aa
TZ
2822011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
283
284 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
285 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
286 as passed in.
287
abe95abb
JD
2882011-05-03 Jan Djärv <jan.h.d@swipnet.se>
289
290 * xterm.c (x_set_frame_alpha): Do not set property on anything
291 else than FRAME_X_OUTER_WINDOW (Bug#8608).
292
e16e55d4
JB
2932011-05-02 Juanma Barranquero <lekktu@gmail.com>
294
295 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
296
bafcf6a5
JB
2972011-05-02 Juanma Barranquero <lekktu@gmail.com>
298
299 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
300 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
301 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
302 (gnutls_global_initialized, Qgnutls_bootprop_priority)
303 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
304 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
305 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
306 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
307 (Qgnutls_bootprop_callbacks_verify): Make static.
308
e7a6747f
AS
3092011-05-01 Andreas Schwab <schwab@linux-m68k.org>
310
19ed11ba
AS
311 * callproc.c: Indentation fixup.
312
e7a6747f
AS
313 * sysdep.c (wait_for_termination_1): Make static.
314 (wait_for_termination, interruptible_wait_for_termination): Move
315 after wait_for_termination_1.
316
1ef14cb4
LMI
3172011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
318
319 * sysdep.c (interruptible_wait_for_termination): New function
320 which is like wait_for_termination, but allows keyboard
321 interruptions.
322
323 * callproc.c (Fcall_process): Add (:file "file") as an option for
324 the STDOUT buffer.
325 (Fcall_process_region): Ditto.
326
330d880c
EZ
3272011-04-30 Eli Zaretskii <eliz@gnu.org>
328
8db90b73
EZ
329 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
330 rather than `XVECTOR (FOO)->size'.
331
330d880c
EZ
332 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
333 inttypes.h, as a gnulib replacement is used if it not available in
334 system headers.
335
15cbd324
EZ
3362011-04-21 Eli Zaretskii <eliz@gnu.org>
337
338 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
339 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
340 of MOST_POSITIVE_FIXNUM. (Bug#8528)
341
342 * coding.c (coding_alloc_by_realloc): Error out if destination
343 will grow beyond MOST_POSITIVE_FIXNUM.
344 (decode_coding_emacs_mule): Abort if there isn't enough place in
345 charbuf for the composition carryover bytes. Reserve an extra
346 space for up to 2 characters produced in a loop.
347 (decode_coding_iso_2022): Abort if there isn't enough place in
348 charbuf for the composition carryover bytes.
349
3502011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 351
ae940cca
EZ
352 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
353 aborting when %lld or %lll format is passed.
354 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
355 %llo or %llx format is passed. (Bug#8545)
356
03ab8921
EZ
357 * window.c (window_scroll_line_based): Use a marker instead of
358 simple variables to record original value of point. (Bug#7952)
359
afda1437
EZ
360 * doprnt.c (doprnt): Fix the case where a multibyte sequence
361 produced by %s or %c overflows available buffer space. (Bug#8545)
362
f76dee0c
PE
3632011-04-28 Paul Eggert <eggert@cs.ucla.edu>
364
365 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 366 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 367
fdc5744d
JB
3682011-04-28 Juanma Barranquero <lekktu@gmail.com>
369
370 * w32.c (init_environment): Warn about defaulting HOME to C:\.
371
638f053a
JB
3722011-04-28 Juanma Barranquero <lekktu@gmail.com>
373
374 * keyboard.c (Qdelayed_warnings_hook): Define.
375 (command_loop_1): Run `delayed-warnings-hook'
376 if Vdelayed_warnings_list is non-nil.
377 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
378 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
379
d178f871
EZ
3802011-04-28 Eli Zaretskii <eliz@gnu.org>
381
382 * doprnt.c (doprnt): Don't return value smaller than the buffer
383 size if the message was truncated. (Bug#8545).
384
b124fd93
JB
3852011-04-28 Juanma Barranquero <lekktu@gmail.com>
386
387 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
388 (Fx_window_property): #if-0 the whole functions, not just the bodies.
389
e810457d
PE
3902011-04-27 Paul Eggert <eggert@cs.ucla.edu>
391
392 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
393
ea51cceb
JB
3942011-04-27 Juanma Barranquero <lekktu@gmail.com>
395
396 * makefile.w32-in: Update dependencies.
397
94dcfacf
EZ
3982011-04-27 Eli Zaretskii <eliz@gnu.org>
399
400 Improve `doprnt' and its usage. (Bug#8545)
401 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
402 `format_end'. Remove support for %l as a conversion specifier.
403 Don't use xrealloc. Improve diagnostics when the %l size modifier
404 is used. Update the commentary.
405
406 * eval.c (verror): Simplify calculation of size_t.
407
408 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
409 messages.
410
f61f41d7
PE
4112011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
412
413 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
414 change.
415
96fb4434
PE
4162011-04-27 Paul Eggert <eggert@cs.ucla.edu>
417
418 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
419 This makes this file independent of the recent pseudovector change.
420
671875da 4212011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 422
69e9b5a3
PE
423 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
424
b5f869a7 425 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 426 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 427 Remove unused local.
c8926152 428 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 429
841a1577 430 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
431 GCC 4.6.0 optimizes based on type-based alias analysis. For
432 example, if b is of type struct buffer * and v of type struct
433 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
434 != &v->size, and therefore "v->size = 1; b->size = 2; return
435 v->size;" must therefore return 1. This assumption is incorrect
436 for Emacs, since it type-puns struct Lisp_Vector * with many other
437 types. To fix this problem, this patch adds a new type struct
f904488f 438 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
439 and pseudovectors, and helps optimizing compilers not get fooled
440 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
441 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
442 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
443 the size member.
eab3844f
PE
444 (XSETPVECTYPE): Rewrite in terms of new macro.
445 (XSETPVECTYPESIZE): New macro, specifying both type and size.
446 This is a bit clearer, and further avoids the possibility of
447 undesirable aliasing.
448 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 449 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
450 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
451 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
452 (ASIZE): Now uses header.size rather than size. All
453 previous uses of XVECTOR (foo)->size replaced to use this macro,
454 to avoid the hassle of writing XVECTOR (foo)->header.size.
455 (struct vectorlike_header): New type.
eab3844f
PE
456 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
457 object, to help avoid aliasing.
458 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
459 (SUBRP): Likewise, since Lisp_Subr is a special case.
460 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
461 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
462 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 463 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
464 changed to be "header.size" and "header.next".
465 * buffer.h (struct buffer): Likewise.
466 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
467 * frame.h (struct frame): Likewise.
468 * process.h (struct Lisp_Process): Likewise.
469 * termhooks.h (struct terminal): Likewise.
470 * window.c (struct save_window_data, struct saved_window): Likewise.
471 * window.h (struct window): Likewise.
472 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
473 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
474 * buffer.c (init_buffer_once): Likewise.
475 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
476 special case.
477 * process.c (Fformat_network_address): Use local var for size,
478 for brevity.
479
0df1eac5
PE
480 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
481
847ab9d1 482 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
483 * data.c (atof): Remove decl; no longer used or needed.
484 (digit_to_number): Move to lread.c.
485 (Fstring_to_number): Use new string_to_number function, to be
486 consistent with how the Lisp reader treats infinities and NaNs.
487 Do not assume that floating-point numbers represent EMACS_INT
488 without losing information; this is not true on most 64-bit hosts.
489 Avoid double-rounding errors, by insisting on integers when
490 parsing non-base-10 numbers, as the documentation specifies.
491 * lisp.h (string_to_number): New decl, replacing ...
492 (isfloat_string): Remove.
bc0a5c13 493 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 494 (read1): Do not accept +. and -. as integers; this
452f4150
PE
495 appears to have been a coding error. Similarly, do not accept
496 strings like +-1e0 as floating point numbers. Do not report
497 overflow for integer overflows unless the base is not 10 which
498 means we have no simple and reliable way to continue.
499 Break out the floating-point parsing into a new
500 function string_to_number, so that Fstring_to_number parses
501 floating point numbers consistently with the Lisp reader.
502 (digit_to_number): Moved here from data.c. Make it static inline.
503 (E_CHAR, EXP_INT): Remove, replacing with ...
504 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
505 (string_to_number): New function, replacing isfloat_string.
506 This function checks for valid syntax and produces the resulting
507 Lisp float number too. Rework it so that string-to-number
bc0a5c13 508 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
509 so that overflow for non-base-10 numbers is reported only when
510 there's no portable and simple way to convert to floating point.
452f4150 511
67769ffc
PE
512 * textprop.c (set_text_properties_1): Rewrite for clarity,
513 and to avoid GCC warning about integer overflow.
514
c20db43f
PE
515 * intervals.h (struct interval): Use EMACS_INT for members
516 where EMACS_UINT might cause problems. See
517 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
518 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
519 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
520 All uses changed.
37aa2f85
PE
521 (offset_intervals): Tell GCC not to worry about length overflow
522 when negating a negative length.
c20db43f 523
2538aa2f
PE
524 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
525 (overrun_check_free): Likewise.
526
f2d3008d
PE
527 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
528 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
529 word size.
530
ec8df744
PE
531 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
532 (gnutls_make_error): Rename local to avoid shadowing.
533 (gnutls_emacs_global_deinit): ifdef out; not used.
534 (Fgnutls_boot): Use const for pointer to readonly storage.
535 Comment out unused local. Fix pointer signedness problems.
536
640ee02d
PE
537 * lread.c (openp): Don't stuff size_t into an 'int'.
538 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
539 about possible signed overflow.
540
6048fb2a
PE
541 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
542 (GDK_KEY_g): Don't define if already defined.
543 (xg_prepare_tooltip): Avoid pointer signedness problem.
544 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
545
fa3c87e1
PE
546 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
547 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
548
2172544b
PE
549 * xfns.c (Fx_window_property): Simplify a bit,
550 to make a bit faster and to avoid GCC 4.6.0 warning.
551 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
552
9b821a21
PE
553 * fns.c (internal_equal): Don't assume size_t fits in int.
554
3c616cfa
PE
555 * alloc.c (compact_small_strings): Tighten assertion a little.
556
c2982e87
PE
557 Replace pEd with more-general pI, and fix some printf arg casts.
558 * lisp.h (pI): New macro, generalizing old pEd macro to other
559 conversion specifiers. For example, use "...%"pI"d..." rather
560 than "...%"pEd"...".
561 (pEd): Remove. All uses replaced with similar uses of pI.
562 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
563 * alloc.c (check_pure_size): Don't overflow by converting size to int.
564 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
565 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
566 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
567 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
568 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
569 64-bit hosts.
570 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
571 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
572 * print.c (safe_debug_print, print_object): Likewise.
573 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
574 to int.
6f04d126
PE
575 Use pI instead of if-then-else-abort. Use %p to avoid casts,
576 avoiding the 0 flag, which is not portable.
c2982e87
PE
577 * process.c (Fmake_network_process): Use pI to avoid cast.
578 * region-cache.c (pp_cache): Likewise.
579 * xdisp.c (decode_mode_spec): Likewise.
580 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
581 behavior on 64-bit hosts with printf arg.
6f04d126 582 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
583 (x_stop_queuing_selection_requests): Likewise.
584 (x_get_window_property): Don't truncate byte count to an 'int'
585 when tracing.
0b432f21 586
5e073ec7
PE
587 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
588 here, since it parses constructs like leading '-' and spaces,
589 which are not wanted; and it overflows with large numbers.
590 Instead, simply match F[0-9]+, which is what is wanted anyway.
591
36372bf9
PE
592 * alloc.c: Remove unportable assumptions about struct layout.
593 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
594 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
595 (allocate_vectorlike, make_pure_vector): Use the new macros,
596 plus offsetof, to remove unportable assumptions about struct layout.
597 These assumptions hold on all porting targets that I know of, but
598 they are not guaranteed, they're easy to remove, and removing them
599 makes further changes easier.
600
0b432f21
PE
601 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
602 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
603 (string_overrun_cookie): Now const. Use initializers that
604 don't formally overflow signed char, to avoid warnings.
000098c1
PE
605 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
606 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
607 (allocate_buffer): Don't assume sizeof (struct buffer) is a
608 multiple of sizeof (EMACS_INT); it need not be, if
609 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 610 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 611
895009e1
JB
6122011-04-26 Juanma Barranquero <lekktu@gmail.com>
613
614 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
615
6a7a1b0b
TZ
6162011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
617
618 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 619 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
620 Reported by Paul Eggert <eggert@cs.ucla.edu>.
621
841a1577 6222011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
623
624 * lisp.h (Qdebug): List symbol.
895009e1 625 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
626 * keyboard.c (debug-on-event): New variable.
627 (handle_user_signal): Break into debugger when debug-on-event
628 matches the current signal symbol.
629
f2d3ba6f
DN
6302011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
631
632 * alloc.c (check_sblock, check_string_bytes)
633 (check_string_free_list): Convert to standard C.
634
42ce4c63
TZ
6352011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
636
637 * w32.c (emacs_gnutls_push): Fix typo.
638
825cd63c
EZ
6392011-04-25 Eli Zaretskii <eliz@gnu.org>
640
fb11d64d
EZ
641 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
642 "cast to pointer from integer of different size".
643
825cd63c
EZ
644 Improve doprnt and its use in verror. (Bug#8545)
645 * doprnt.c (doprnt): Document the set of format control sequences
646 supported by the function. Use SAFE_ALLOCA instead of always
647 using `alloca'.
648
649 * eval.c (verror): Don't limit the buffer size at size_max-1, that
650 is one byte too soon. Don't use xrealloc; instead xfree and
651 xmalloc anew.
652
e061a11b
TZ
6532011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
654
655 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
656 callbacks stage.
657
658 * gnutls.c: Renamed global_initialized to
659 gnutls_global_initialized. Added internals for the
660 :verify-hostname-error, :verify-error, and :verify-flags
661 parameters of `gnutls-boot' and documented those parameters in the
662 docstring. Start callback support.
663 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
664 unless a fatal error occured. Call gnutls_alert_send_appropriate
665 on error. Return error code.
666 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
667 (emacs_gnutls_read): Likewise.
668 (Fgnutls_boot): Return handshake error code.
669 (emacs_gnutls_handle_error): New function.
670 (wsaerror_to_errno): Likewise.
671
672 * w32.h (emacs_gnutls_pull): Add prototype.
673 (emacs_gnutls_push): Likewise.
674
675 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
676 (emacs_gnutls_push): Likewise.
677
6782011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
679
680 * process.c (wait_reading_process_output): Check if GnuTLS
681 buffered some data internally if no FDs are set for TLS
682 connections.
683
684 * makefile.w32-in (OBJ2): Add gnutls.$(O).
685 (LIBS): Link to USER_LIBS.
686 ($(BLD)/gnutls.$(0)): New target.
687
fa6996bc
EZ
6882011-04-24 Eli Zaretskii <eliz@gnu.org>
689
eb35682e
EZ
690 * xdisp.c (handle_single_display_spec): Rename the
691 display_replaced_before_p argument into display_replaced_p, to
692 make it consistent with the commentary. Fix typos in the
693 commentary.
694
e2ad650c
EZ
695 * textprop.c (syms_of_textprop): Remove dead code.
696 (copy_text_properties): Delete obsolete commentary about an
697 interface that was deleted long ago. Fix typos in the description
698 of arguments.
699
1b2de274
EZ
700 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
701 to changes in oldXMenu/XMenu.h from 2011-04-16.
702 <menu_help_message, prev_menu_help_message>: Constify.
703 (IT_menu_make_room): menu->help_text is now `const char **';
704 adjust.
705
706 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
707 to changes in oldXMenu/XMenu.h from 2011-04-16.
708 (struct XMenu): Declare `help_text' `const char **'.
709
710 * xfaces.c <Qunspecified>: Make extern again.
711
712 * syntax.c: Include sys/types.h before including regex.h, as
713 required by Posix.
714
762b15be
EZ
715 * doc.c (get_doc_string): Improve the format passed to `error'.
716
717 * doprnt.c (doprnt): Improve commentary.
718
719 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
720
721 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
722 them with etags.
723
f1052e5d
EZ
724 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
725 changes in globals.h immediately force recompilation.
762b15be
EZ
726 (TAGS): Depend on $(CURDIR)/m/intel386.h and
727 $(CURDIR)/s/ms-w32.h.
728 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 729
fa6996bc
EZ
730 * character.c (Fchar_direction): Function deleted.
731 (syms_of_character): Don't defsubr it.
732 <char-direction-table>: Deleted.
733
e6c3da20
EZ
7342011-04-23 Eli Zaretskii <eliz@gnu.org>
735
736 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
737 * doprnt.c: Include limits.h.
738 (SIZE_MAX): New macro.
739 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
740 local variables are now size_t instead of int or unsigned.
741 Improve overflow protection. Support `l' modifier for integer
742 conversions. Support %l conversion. Don't assume an EMACS_INT
743 argument for integer conversions and for %c.
744
745 * lisp.h (doprnt): Restore prototype.
746
747 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
748 $(SRC)/character.h.
749
750 * Makefile.in (base_obj): Add back doprnt.o.
751
752 * deps.mk (doprnt.o): Add back prerequisites.
753 (callint.o): Depend on character.h.
754
755 * eval.c (internal_lisp_condition_case): Include the handler
756 representation in the error message.
757 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
758 when breaking from the loop.
759
760 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
761
762 * callint.c (Fcall_interactively): When displaying error message
763 about invalid control letter, pass the character's codepoint, not
764 a pointer to its multibyte form. Improve display of the character
765 in octal and display also its hex code.
766
767 * character.c (char_string): Use %x to display the (unsigned)
768 codepoint of an invalid character, to avoid displaying a bogus
769 negative value.
770
771 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
772 `error', not SYMBOL_NAME itself.
773
774 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
775 character arguments to `error'.
776
777 * charset.c (check_iso_charset_parameter): Fix incorrect argument
778 to `error' in error message about FINAL_CHAR argument. Make sure
779 FINAL_CHAR is a character, and use %c when it is passed as
780 argument to `error'.
781
4ffd0d6b 7822011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
783
784 * s/ms-w32.h (localtime): Redirect to sys_localtime.
785
786 * w32.c: Include <time.h>.
787 (sys_localtime): New function.
788
4ffd0d6b 7892011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
790
791 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
792
4ffd0d6b 793 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 794
4ffd0d6b 7952011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 796
4ffd0d6b
GM
797 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
798 zombies (Bug#8467).
aac0c6e3 799
04c56954
EZ
8002011-04-19 Eli Zaretskii <eliz@gnu.org>
801
802 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
803 gl_state.e_property when gl_state.object is Qt.
804
805 * insdel.c (make_gap_larger): Remove limitation of buffer size
806 to <= INT_MAX.
807
16a43933
CY
8082011-04-18 Chong Yidong <cyd@stupidchicken.com>
809
810 * xdisp.c (lookup_glyphless_char_display)
811 (produce_glyphless_glyph): Handle cons cell entry in
812 glyphless-char-display.
813 (Vglyphless_char_display): Document it.
814
815 * term.c (produce_glyphless_glyph): Handle cons cell entry in
816 glyphless-char-display.
817
4581706e
CY
8182011-04-17 Chong Yidong <cyd@stupidchicken.com>
819
820 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
821
822 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
823
824 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
825 definition for no-X builds.
826
4887c6e2 8272011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 828
fd35b6f9
PE
829 Static checks with GCC 4.6.0 and non-default toolkits.
830
5c1ccb01
PE
831 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
832
006c5daa
PE
833 * process.c (keyboard_bit_set): Define only if SIGIO.
834 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
835 (send_process): Repair possible setjmp clobbering.
836
efc736d3
PE
837 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
838
4e2fe2e6
PE
839 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
840
f97334a2
PE
841 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
842
4e75f29d
PE
843 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
844 Define only if needed.
845
90efadd1
PE
846 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
847 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 848 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 849
3c647824
PE
850 * dispextern.h (struct redisplay_interface): Rename param
851 to avoid shadowing.
e264f262 852 * termhooks.h (struct terminal): Likewise.
761383f4 853 * xterm.c (xembed_send_message): Likewise.
3c647824 854
b58c5c4a
PE
855 * insdel.c (make_gap_smaller): Define only if
856 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
857
cad59032
PE
858 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
859 it.
860
c339dc2e
PE
861 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
862 so that we aren't warned about unused symbols.
863
91a3e27b
PE
864 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
865
399c71d3 866 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 867
8ffc96f5
PE
868 * xfns.c (x_real_positions): Mark locals as initialized.
869
eef9bc79
PE
870 * xmenu.c (xmenu_show): Don't use uninitialized vars.
871
098db9dd
PE
872 * xterm.c: Fix problems found by static analysis with other toolkits.
873 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
874 (x_dispatch_event): Declare static if USE_GTK, and
875 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 876 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 877 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
878 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
879 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 880
eb18f6cc
PE
881 * xmenu.c (menu_help_callback): Pointer type fixes.
882 Use const pointers when pointing at readonly data. Avoid pointer
883 signedness clashes.
884 (FALSE): Remove unused macro.
885 (update_frame_menubar): Remove unused decl.
886
1fe72bf8
PE
887 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
888
60d9e1db
PE
889 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
890 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
891 (single_menu_item): Rename local to avoid shadowing.
892
39261c26
PE
893 * keyboard.c (make_lispy_event): Remove unused local var.
894
018c5e19
PE
895 * frame.c, frame.h (x_get_resource_string): Bring this back, but
896 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
897
63d2b86e
PE
898 * bitmaps: Change bitmaps from unsigned char back to the X11
899 compatible char. Avoid the old compiler warnings about
900 out-of-range initializers by using, for example, '\xab' rather
901 than 0xab.
902
aefd87e1
PE
903 * xgselect.c (xgselect_initialize): Check vs interface
904 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
905
bf501fb9
PE
906 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
907
e9829fdf
PE
908 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
909 to read-only memory.
910
1086c095
PE
911 * fns.c (vector): Remove; this old hack is no longer needed.
912
2baccd04 913 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 914 Remove unused var.
dde42981 915 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 916
72391843 917 * xrdb.c (x_load_resources): Omit unused local.
3565b346 918
436c16df 919 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 920 (x_window): Rename locals to avoid shadowing.
dc5ddd85 921 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 922
92bb796d 923 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 924 (x_term_init): Remove local to avoid shadowing.
92bb796d 925
764430a3 926 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
927
928 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
929 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
930
d1dfb56c
EZ
9312011-04-16 Eli Zaretskii <eliz@gnu.org>
932
c4354cb4
EZ
933 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
934
d1dfb56c
EZ
935 Fix regex.c, syntax.c and friends for buffers > 2GB.
936 * syntax.h (struct gl_state_s): Declare character position members
937 EMACS_INT.
938
939 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
940
941 * textprop.c (verify_interval_modification, interval_of): Declare
942 arguments EMACS_INT.
943
944 * intervals.c (adjust_intervals_for_insertion): Declare arguments
945 EMACS_INT.
946
947 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
948
949 * indent.c (Fvertical_motion): Local variable it_start is now
950 EMACS_INT.
951
952 * regex.c (re_match, re_match_2, re_match_2_internal)
953 (bcmp_translate, regcomp, regexec, print_double_string)
954 (group_in_compile_stack, re_search, re_search_2, regex_compile)
955 (re_compile_pattern, re_exec): Declare arguments and local
956 variables `size_t' and `ssize_t' and return values `regoff_t', as
957 appropriate.
958 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
959 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
960 <compile_stack_type>: `size' and `avail' are now `size_t'.
961
962 * regex.h <regoff_t>: Use ssize_t, not int.
963 (re_search, re_search_2, re_match, re_match_2): Arguments that
964 specify buffer/string position and length are now ssize_t and
965 size_t. Return type is regoff_t.
966
613052cd
BK
9672011-04-16 Ben Key <bkey76@gmail.com>
968
969 * nsfont.m: Fixed bugs in ns_get_family and
970 ns_descriptor_to_entity that were caused by using free to
971 deallocate memory blocks that were allocated by xmalloc (via
972 xstrdup). This caused Emacs to crash when compiled with
973 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
974 --enable-checking=xmallocoverrun). xfree is now used to
975 deallocate these memory blocks.
976
4170f62f 9772011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 978
71b41406
PE
979 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
980
9587a89d
PE
981 emacs_write: Accept and return EMACS_INT for sizes.
982 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
983 et seq.
984 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
985 Accept and return EMACS_INT.
986 (emacs_gnutls_write): Return the number of bytes written on
987 partial writes.
988 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
989 (emacs_read, emacs_write): Remove check for negative size, as the
990 Emacs source code has been audited now.
9587a89d
PE
991 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
992 (emacs_read, emacs_write): Use it.
273a5f82
PE
993 * process.c (send_process): Adjust to the new signatures of
994 emacs_write and emacs_gnutls_write. Do not attempt to store
995 a byte offset into an 'int'; it might overflow.
9587a89d 996 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 997
3e047f51
PE
998 * sound.c: Don't assume sizes fit in 'int'.
999 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1000 Return EMACS_INT, not int.
3e047f51 1001 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1002 Accept EMACS_INT, not int.
1003 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1004 record read return values.
1005
cc39a9db
BK
10062011-04-15 Ben Key <bkey76@gmail.com>
1007
c9d0ec6d
JB
1008 * keyboard.c (Qundefined): Don't declare static since it is used
1009 in nsfns.m.
1010 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1011 static since they are used in nsfont.m.
cc39a9db 1012
6c60eb9f
SM
10132011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1014
1015 * process.c (Qprocessp): Don't declare static.
1016 * lisp.h (Qprocessp): Declare again.
1017
7990b61a
JB
10182011-04-15 Juanma Barranquero <lekktu@gmail.com>
1019
1020 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1021
5d4cb038
PE
10222011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1023
8bd7b830 1024 Improve C-level modularity by making more things 'static'.
cd64ea1d 1025
e3b27b31
PE
1026 Don't publish debugger-only interfaces to other modules.
1027 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1028 (verify_bytepos, count_markers): Move decls to the only modules
1029 that need them.
1030 * region-cache.h (pp_cache): Likewise.
1031 * window.h (check_all_windows): Likewise.
1032 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1033
5d4cb038
PE
1034 * sysdep.c (croak): Now static, if
1035 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1036 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1037
1038 * alloc.c (refill_memory_reserve): Now static if
1039 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1040 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1041
e87b6180
PE
1042 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1043 Define only if USE_LUCID.
1044
ac64929e
PE
1045 * xrdb.c (x_customization_string, x_rm_string): Now static.
1046
6f37259d
PE
1047 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1048 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1049
1683e3ab
PE
1050 * xdisp.c (draw_row_with_mouse_face): Now static.
1051 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1052
de9c2632
PE
1053 * window.h (check_all_windows): Mark externally visible.
1054
2b96acb7
PE
1055 * window.c (window_deletion_count): Now static.
1056
1057 * undo.c: Make symbols static if they're not exported.
1058 (last_undo_buffer, last_boundary_position, pending_boundary):
1059 Now static.
1060
50436f33
PE
1061 * textprop.c (interval_insert_behind_hooks): Now static.
1062 (interval_insert_in_front_hooks): Likewise.
1063
64520e5c
PE
1064 * term.c: Make symbols static if they're not exported.
1065 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1066 (max_frame_lines, tty_set_terminal_modes):
1067 (tty_reset_terminal_modes, tty_turn_off_highlight):
1068 (get_tty_terminal): Now static.
1069 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1070 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1071 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1072 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1073 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1074
1fa53021
PE
1075 * sysdep.c: Make symbols static if they're not exported.
1076 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1077 Now static.
1078 (sigprocmask_set, full_mask): Remove; unused.
1079 (wait_debugging): Mark as visible.
1080 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1081 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1082
d4b43b22
PE
1083 * syntax.c (syntax_temp): Define only if !__GNUC__.
1084
b7c513d0
PE
1085 * sound.c (current_sound_device, current_sound): Now static.
1086
989b29ad
PE
1087 * search.c (searchbufs, searchbuf_head): Now static.
1088
13a55a78
PE
1089 * scroll.c (scroll_cost): Remove; unused.
1090 * dispextern.h (scroll_cost): Remove decl.
1091
de68a1fc
PE
1092 * region-cache.h (pp_cache): Mark as externally visible.
1093
40ccffa6
PE
1094 * process.c: Make symbols static if they're not exported.
1095 (process_tick, update_tick, create_process, chan_process):
1096 (Vprocess_alist, proc_buffered_char, datagram_access):
1097 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1098 (deactivate_process): Mark defn as static, as well as decl.
1099 * lisp.h (create_process): Remove decl.
1100 * process.h (chan_process, Vprocess_alist): Remove decls.
1101
ad64fc97
PE
1102 * print.c: Make symbols static if they're not exported.
1103 (print_depth, new_backquote_output, being_printed, print_buffer):
1104 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1105 (print_interval, print_number_index, initial_stderr_stream):
1106 Now static.
1107 * lisp.h (Fprinc): Remove decl.
1108 (debug_output_compilation_hack): Mark as externally visible.
1109
adddb265
PE
1110 * sysdep.c (croak): Move decl from here to syssignal.h.
1111 * syssignal.h (croak): Put it here, so the API can be checked when
1112 'croak' is called from dissociate_if_controlling_tty.
1113
1717ede2
PE
1114 * minibuf.c: Make symbols static if they're not exported.
1115 (minibuf_save_list, choose_minibuf_frame): Now static.
1116 * lisp.h (choose_minibuf_frame): Remove decl.
1117
fa5fb2bc
PE
1118 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1119
1e3890d1
PE
1120 * lread.c: Make symbols static if they're not exported.
1121 (read_objects, initial_obarray, oblookup_last_bucket_number):
1122 Now static.
1123 (make_symbol): Remove; unused.
1124 * lisp.h (initial_obarray, make_symbol): Remove decls.
1125
8a1414fa
PE
1126 * keyboard.c: Make symbols static if they're not exported.
1127 (single_kboard, recent_keys_index, total_keys, recent_keys):
1128 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1129 (this_single_command_key_start, echoing, last_auto_save):
1130 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1131 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1132 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1133 (Vlispy_mouse_stem, double_click_count):
1134 Now static.
1135 (force_auto_save_soon): Define only if SIGDANGER.
1136 (ignore_mouse_drag_p): Now static if
1137 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1138 (print_help): Remove; unused.
1139 (stop_character, last_timer_event): Mark as externally visible.
1140 * keyboard.h (ignore_mouse_drag_p): Declare only if
1141 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1142 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1143 * lisp.h (echoing): Remove decl.
1144 (force_auto_save_soon): Declare only if SIGDANGER.
1145 * xdisp.c (redisplay_window): Simplify code, to make it more
1146 obvious that ignore_mouse_drag_p is not accessed if !defined
1147 USE_GTK && !defined HAVE_NS.
1148
93ea6e8f
PE
1149 * intervals.c: Make symbols static if they're not exported.
1150 (merge_properties_sticky, merge_interval_right, delete_interval):
1151 Now static.
1152 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1153
77382fcc
PE
1154 * insdel.c: Make symbols static if they're not exported.
1155 However, leave prepare_to_modify_buffer alone. It's never
1156 called from outside this function, but that appears to be a bug.
1157 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1158 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1159 (adjust_after_replace_noundo): Remove; unused.
1160 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1161 (signal_before_change): Remove decls.
77382fcc 1162
9306c32e
PE
1163 * indent.c (val_compute_motion, val_vmotion): Now static.
1164
cd44d2eb
PE
1165 * image.c: Make symbols static if they're not exported.
1166 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1167 if USE_GTK.
1168 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1169 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1170
ad9a7a06
PE
1171 * fringe.c (standard_bitmaps): Now static.
1172 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1173
81626931
PE
1174 * frame.c: Make symbols static if they're not exported.
1175 (x_report_frame_params, make_terminal_frame): Now static.
1176 (get_frame_param): Now static, unless HAVE_NS.
1177 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1178 (x_get_resource_string): Remove; not used.
1179 * frame.h (make_terminal_frame, x_report_frame_params):
1180 (x_get_resource_string); Remove decls.
1181 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1182 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1183
239f9db9
PE
1184 * font.c, fontset.c: Make symbols static if they're not exported.
1185 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1186 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1187 * font.c (font_close_object): Now static.
1188 * font.h (font_close_object): Remove.
1189 * fontset.c (FONTSET_OBJLIST): Remove.
1190 (free_realized_fontset) #if-0 the body, which does nothing.
1191 (face_suitable_for_char_p): #if-0, as it's never called.
1192 * fontset.h (face_suitable_for_char_p): Remove decl.
1193 * xfaces.c (face_at_string_position): Use
1194 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1195 since 0 is always ASCII.
1196
dfcf3579
PE
1197 * fns.c (weak_hash_tables): Now static.
1198
5045092b
PE
1199 * fileio.c: Make symbols static if they're not exported.
1200 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1201 (Vwrite_region_annotation_buffers): Now static.
1202
57a96f5c
PE
1203 * eval.c: Make symbols static if they're not exported.
1204 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1205 * lisp.h (backtrace_list): Remove decl.
1206
35f08c38
PE
1207 * emacs.c: Make symbols static if they're not exported.
1208 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1209 (fatal_error_code, fatal_error_signal_hook, standard_args):
1210 Now static.
1211 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1212 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1213 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1214 * lisp.h (fatal_error_signal_hook): Remove decl.
1215 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1216
f44bd759
PE
1217 * editfns.c: Move a (normally-unused) function to its only use.
1218 * editfns.c, lisp.h (get_operating_system_release): Remove.
1219 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1220 worth the hassle of breaking this out.
1221
b532497d
PE
1222 * xterm.c: Make symbols static if they're not exported.
1223 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1224 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1225 (x_destroy_window, x_delete_display):
1226 Now static.
1227 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1228 (x_mouse_leave): Remove; unused.
1229 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1230 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1231 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1232 Remove decls.
1233 (x_mouse_leave): Declare only if WINDOWSNT.
1234 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1235 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1236 USE_X_TOOLKIT.
1237
1675728f
PE
1238 * ftxfont.c: Make symbols static if they're not exported.
1239 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1240 HAVE_FREETYPE.
1241 * font.h (ftxfont_driver): Likewise.
1242
e4cebfca
PE
1243 * xfns.c: Make symbols static if they're not exported.
1244 (x_last_font_name, x_display_info_for_name):
1245 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1246 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1247 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1248 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1249 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1250 (last_show_tip_args): Now static.
1251 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1252 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1253 (x_screen_planes): Remove; unused.
1254 * dispextern.h (x_screen_planes): Remove decl.
1255
5bf46f05
PE
1256 * dispnew.c: Make symbols static if they're not exported.
1257 * dispextern.h (redraw_garbaged_frames, scrolling):
1258 (increment_row_positions): Remove.
1259 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1260 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1261 Now static.
1262 (redraw_garbaged_frames): Remove; unused.
1263
435f4c28
PE
1264 * xfaces.c: Make symbols static if they're not exported.
1265 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1266 Remove decls.
1267 * xterm.h (defined_color): Remove decls.
1268 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1269 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1270 (menu_face_changed_default, defined_color, free_realized_face):
1271 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1272 (ascii_face_of_lisp_face): Remove; unused.
1273
8524aef3
PE
1274 * xdisp.c: Make symbols static if they're not exported.
1275 * dispextern.h (scratch_glyph_row, window_box_edges):
1276 (glyph_to_pixel_coords, set_cursor_from_row):
1277 (get_next_display_element, set_iterator_to_next):
1278 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1279 (show_mouse_face): Remove decls
1280 * frame.h (message_buf_print): Likewise.
1281 * lisp.h (pop_message, set_message, check_point_in_composition):
1282 Likewise.
1283 * xterm.h (set_vertical_scroll_bar): Likewise.
1284 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1285 (message_buf_print, scratch_glyph_row, displayed_buffer):
1286 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1287 (get_next_display_element, show_mouse_face, window_box_edges):
1288 (frame_to_window_pixel_xy, check_point_in_composition):
1289 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1290 (glyph_to_pixel_coords): Remove; unused.
1291
16390cd2
PE
1292 * dired.c (file_name_completion): Now static.
1293
1294 * dbusbind.c (xd_in_read_queued_messages): Now static.
1295
a25f4dfa
PE
1296 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1297 * data.c (circular_list_error): Remove.
1298
14a9c8df
PE
1299 * commands.h (last_point_position, last_point_position_buffer):
1300 (last_point_position_window): Remove decls.
1301 * keyboard.c: Make these variables static.
1302
74ab6df5
PE
1303 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1304 decls.
1305 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1306 (iso_code_class, detect_coding, code_convert_region): Now static.
1307 (encode_coding_gap): Remove; unused.
1308
38dfbee1
PE
1309 * chartab.c (chartab_chars, chartab_bits): Now static.
1310
a2cb4e63
PE
1311 * charset.h (charset_iso_8859_1): Remove decl.
1312 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1313 Now static.
1314
127198fd
PE
1315 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1316 * ccl.c (Vccl_program_table): Now static.
1317 (check_ccl_update): Remove; unused.
1318
d85b608f
PE
1319 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1320 * category.h: ... from here.
1321 * category.c (check_category_table, set_category_set): Now static.
1322
31cd66f3
PE
1323 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1324 * lisp.h: Remove these decls.
1325
c358e587
PE
1326 * buffer.c (buffer_count): Remove unused var.
1327
e78aecca
PE
1328 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1329 so that it's not optimized away.
1330 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1331 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1332 exported only to the debugger.
1333
e192d7d3
PE
1334 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1335 * atimer.h (run_all_atimers): Removed; not exported.
1336
92470028
PE
1337 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1338 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1339 was inaccessible from Lisp.
1340 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1341 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1342
244ed907
PE
1343 alloc.c: Import and export fewer symbols, and remove unused items.
1344 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1345 is defined.
1346 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1347 it's not optimized away by whole-program optimization.
1348 (message_enable_multibyte, free_misc): Remove.
1349 (catchlist, handlerlist, mark_backtrace):
1350 Declare only if BYTE_MARK_STACK.
1351 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1352 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1353 (message_enable_multibyte): Remove decl.
1354 (free_misc, interval_free_list, float_block, float_block_index):
1355 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1356 (cons_free_list, last_marked_index):
1357 Now static.
1358 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1359 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1360 (mark_backtrace): Define only if BYTE_MARK_STACK.
1361 * xdisp.c (message_enable_multibyte): Now static.
1362
61c2b50e 1363 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1364 This makes it easier for human readers (and static analyzers)
1365 to see whether these variables are used from other modules.
1366 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1367 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1368 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1369 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1370 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1371 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1372 * xmenu.c, xselect.c:
1373 Declare Q* vars static if they are not used in other modules.
1374 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1375 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1376 Remove decls of unexported vars.
1377 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1378
95c82688
PE
1379 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1380
16a97296
PE
1381 Make Emacs functions such as Fatom 'static' by default.
1382 This makes it easier for human readers (and static analyzers)
1383 to see whether these functions can be called from other modules.
1384 DEFUN now defines a static function. To make the function external
1385 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1386 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1387 (Finit_image_library):
16a97296
PE
1388 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1389 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1390 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1391 Remove decls, since these functions are now static.
1392 (Funintern, Fget_internal_run_time): New decls, since these functions
1393 were already external.
95c82688 1394
16a97296
PE
1395 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1396 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1397 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1398 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1399 * keyboard.c, keymap.c, lread.c:
1400 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1401 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1402 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1403 Mark functions with DEFUE instead of DEFUN,
1404 if they are used in other modules.
1405 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1406 decls for now-static functions.
1407 * buffer.h (Fdelete_overlay): Remove decl.
1408 * callproc.c (Fgetenv_internal): Mark as internal.
1409 * composite.c (Fremove_list_of_text_properties): Remove decl.
1410 (Fcomposition_get_gstring): New forward static decl.
1411 * composite.h (Fcomposite_get_gstring): Remove decl.
1412 * dired.c (Ffile_attributes): New forward static decl.
1413 * doc.c (Fdocumntation_property): New forward static decl.
1414 * eval.c (Ffetch_bytecode): New forward static decl.
1415 (Funintern): Remove extern decl; now in .h file where it belongs.
1416 * fileio.c (Fmake_symbolic_link): New forward static decl.
1417 * image.c (Finit_image_library): New forward static decl.
1418 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1419 * intervals.h (Fprevious_property_change):
1420 (Fremove_list_of_text_properties): Remove decls.
1421 * keyboard.c (Fthis_command_keys): Remove decl.
1422 (Fcommand_execute): New forward static decl.
1423 * keymap.c (Flookup_key): New forward static decl.
1424 (Fcopy_keymap): Now static.
1425 * keymap.h (Flookup_key): Remove decl.
1426 * process.c (Fget_process): New forward static decl.
1427 (Fprocess_datagram_address): Mark as internal.
1428 * syntax.c (Fsyntax_table_p): New forward static decl.
1429 (skip_chars): Remove duplicate decl.
1430 * textprop.c (Fprevious_property_change): New forward static decl.
1431 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1432 Now internal.
1433 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1434 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1435
785bbd42
PE
1436 * editfns.c (Fformat): Remove unreachable code.
1437
8b913b57
AS
14382011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1439
1440 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1441 change. (Bug#8496)
1442
a6744a35
EZ
14432011-04-13 Eli Zaretskii <eliz@gnu.org>
1444
1445 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1446 when at ZV. (Bug#8487)
1447
e7974947
AS
14482011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1449
baad03f0
AS
1450 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1451 (Bug#8437)
1452 * keyboard.c (parse_tool_bar_item): Likewise.
1453 * sound.c (sound_cleanup, alsa_close): Likewise.
1454 * termcap.c (tgetent): Likewise.
1455 * xfns.c (x_default_font_parameter): Likewise.
1456 * xsettings.c (read_and_apply_settings): Likewise.
1457
e7974947
AS
1458 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1459 (overrun_check_free): Protoize.
1460
28272684
PE
14612011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1464 since callers should never pass a negative size.
1465 Change the signature to match that of plain 'read' and 'write'; see
1466 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1467 * lisp.h: Update prototypes of emacs_write and emacs_read.
1468
11997c76
EZ
14692011-04-11 Eli Zaretskii <eliz@gnu.org>
1470
1471 * xdisp.c (redisplay_window): Don't try to determine the character
1472 position of the scroll margin if the window start point w->startp
e896f03c 1473 is outside the buffer's accessible region. (Bug#8468)
11997c76 1474
8a2cbd72
EZ
14752011-04-10 Eli Zaretskii <eliz@gnu.org>
1476
1477 Fix write-region and its subroutines for buffers > 2GB.
1478 * fileio.c (a_write, e_write): Modify declaration of arguments and
1479 local variables to support buffers larger than 2GB.
1480 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1481
1482 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1483 argument, local variables, and return value.
1484
1485 * lisp.h: Update prototypes of emacs_write and emacs_read.
1486
1487 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1488
4073e537 14892011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1490
1ebfdcb6
PE
1491 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1492
b2ded58d
PE
1493 Fix more problems found by GCC 4.6.0's static checks.
1494
7d66342c
PE
1495 * xdisp.c (vmessage): Use a better test for character truncation.
1496
bbf47d44
PE
1497 * charset.c (load_charset_map): <, not <=, for optimization,
1498 and to avoid potential problems with integer overflow.
9248994d 1499 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1500 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1501 * editfns.c (Fformat): Likewise.
1e69125e 1502 * syntax.c (skip_chars): Likewise.
3befa583 1503
e3019616
PE
1504 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1505 This also lets GCC 4.6.0 generate slightly better loop code.
1506
becfa255
PE
1507 * callint.c (Fcall_interactively): <, not <=, for optimization.
1508 (Fcall_interactively): Count the number of arguments produced,
1509 not the number of arguments given. This is simpler and lets GCC
1510 4.6.0 generate slightly better code.
1511
dae0cd48
PE
1512 * ftfont.c: Distingish more carefully between FcChar8 and char.
1513 The previous code passed unsigned char * to a functions like
1514 strlen and xstrcasecmp that expect char *, which does not
1515 conform to the C standard.
1516 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1517 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1518 char * when the C standard requires it.
1519
76032d70
PE
1520 * keyboard.c (read_char): Remove unused var.
1521
eb3f1cc8
PE
1522 * eval.c: Port to Windows vsnprintf (Bug#8435).
1523 Include <limits.h>.
1524 (SIZE_MAX): Define if the headers do not.
1525 (verror): Do not give up if vsnprintf returns a negative count.
1526 Instead, grow the buffer. This ports to Windows vsnprintf, which
1527 does not conform to C99. Problem reported by Eli Zaretskii.
1528 Also, simplify the allocation scheme, by avoiding the need for
1529 calling realloc, and removing the ALLOCATED variable.
1530
70476b54
PE
1531 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1532
12020a9e
PE
1533 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1534 But keep the doprint source code for now, as we might revamp it
1535 and use it again (Bug#8435).
ea6c7ae6
PE
1536 * lisp.h (doprnt): Remove.
1537 * Makefile.in (base_obj): Remove doprnt.o.
1538 * deps.mk (doprnt.o): Remove.
1539
5fdb398c
PE
1540 error: Print 32- and 64-bit integers portably (Bug#8435).
1541 Without this change, on typical 64-bit hosts error ("...%d...", N)
1542 was used to print both 32- and 64-bit integers N, which relied on
1543 undefined behavior.
1544 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1545 New macro.
1546 * lisp.h (error, verror): Mark as printf-like functions.
1547 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1548 Report overflow in size calculations when allocating printf buffer.
1549 Do not truncate output string at its first null byte.
1550 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1551 Truncate the output at a character boundary, since vsnprintf does not
1552 do that.
1553 * charset.c (check_iso_charset_parameter): Convert internal
1554 character to string before calling 'error', since %c now has the
1555 printf meaning.
1556 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1557 overflow when computing char to be passed to 'error'. Do not
1558 pass Lisp_Object to 'error'; pass the integer instead.
1559 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1560 formatted with plain %d.
1561
b189fa66
PE
1562 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1563
bff87ef0
PE
1564 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1565
7e2cac20
PE
1566 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1567
ce4d90b5
PE
1568 * xterm.c (x_catch_errors): Remove duplicate declaration.
1569
266c9547
PE
1570 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1571
79c49ad2
PE
1572 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1573
368f4090
JM
15742011-04-10 Jim Meyering <meyering@redhat.com>
1575
1576 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1577 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1578 return ssize_t not "int", and use size_t as the buffer length.
1579 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1580 * gnutls.h: Update declarations.
1581 * process.c (read_process_output): Use ssize_t, to match.
1582 (send_process): Likewise.
1583
a32d4040
CY
15842011-04-09 Chong Yidong <cyd@stupidchicken.com>
1585
1586 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1587
8546720e 15882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1589
8546720e
GM
1590 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1591 unsigned char, to match FcChar8 type definition.
aac0c6e3 1592
8546720e
GM
1593 * xterm.c (handle_one_xevent):
1594 * xmenu.c (create_and_show_popup_menu):
1595 * xselect.c (x_decline_selection_request)
1596 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1597
0a2f5c1a 15982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1599
1600 Fix some uses of `int' instead of EMACS_INT.
1601 * search.c (string_match_1, fast_string_match)
1602 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1603 (scan_buffer, find_next_newline_no_quit)
1604 (find_before_next_newline, search_command, Freplace_match)
1605 (Fmatch_data): Make some `int' variables be EMACS_INT.
1606
1607 * xdisp.c (display_count_lines): 3rd argument and return value now
1608 EMACS_INT. All callers changed.
1609 (pint2hrstr): Last argument is now EMACS_INT.
1610
1611 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1612 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1613 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1614 (decode_coding_utf_16, decode_coding_emacs_mule)
1615 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1616 (decode_coding_ccl, decode_coding_charset)
1617 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1618 (decode_coding_iso_2022, decode_coding_emacs_mule)
1619 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1620 <char_offset, last_offset>: Declare EMACS_INT.
1621 (encode_coding_utf_8, encode_coding_utf_16)
1622 (encode_coding_emacs_mule, encode_invocation_designation)
1623 (encode_designation_at_bol, encode_coding_iso_2022)
1624 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1625 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1626 Declare EMACS_INT.
1627 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1628 (encode_invocation_designation): Last argument P_NCHARS is now
1629 EMACS_INT.
1630 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1631 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1632
1633 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1634 All users changed.
1635
1636 * ccl.c (Fccl_execute_on_string): Declare some variables
1637 EMACS_INT.
1638
8546720e 16392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1640
1641 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1642
4e19a977
CS
16432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1644
1645 * process.c (Fformat_network_address): Doc fix.
1646
87302331
R
16472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1648
1649 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1650
cbb59342
CY
16512011-04-08 Chong Yidong <cyd@stupidchicken.com>
1652
1653 * keyboard.c (read_char): Call Lisp function help-form-show,
1654 instead of using internal_with_output_to_temp_buffer.
1655 (Qhelp_form_show): New var.
e0d38eeb 1656 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1657
1658 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1659
1660 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1661
e67a13ab
CY
16622011-04-06 Chong Yidong <cyd@stupidchicken.com>
1663
1664 * process.c (Flist_processes): Removed to Lisp.
1665 (list_processes_1): Deleted.
1666
973f782d
EZ
16672011-04-06 Eli Zaretskii <eliz@gnu.org>
1668
7c106b1e
EZ
1669 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1670
973f782d
EZ
1671 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1672
41cf7d1a 16732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1674
ca23cc88
PE
1675 Fix more problems found by GCC 4.6.0's static checks.
1676
f390e2d5
PE
1677 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1678
42eea0d0
PE
1679 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1680
b69769da 1681 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1682
f9541e84
PE
1683 * xdisp.c (vmessage): Mark as a printf-like function.
1684
13841b55
PE
1685 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1686
c136c10f
PE
1687 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1688
5e2d4a30
PE
1689 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1690 printf-like functions.
1691 (tiff_load): Add casts to remove these marks before passing them
1692 to system-supplied API.
1693
583f48b9
PE
1694 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1695
b25d760e
PE
1696 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1697 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1698 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1699 directly, rather than having caller test rule sign. This avoids
1700 some unnecessary tests.
1701 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1702 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1703 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1704
bc7b6697 1705 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1706 (xfont_open): Avoid unnecessary tests.
bc7b6697 1707
27ccc379
PE
1708 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1709
dcd5c89a
PE
1710 * composite.h, composite.c (composition_gstring_put_cache):
1711 Use EMACS_INT, not int, for length.
1712
b13a45c6
PE
1713 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1714 breaking out part of COMPOSITION_DECODE_RULE.
1715 (COMPOSITION_DECODE_RULE): Use it.
1716 * composite.c (get_composition_id): Remove unused local vars,
1717 by using the new macro.
1718
1e792e4d
PE
1719 * textprop.c (set_text_properties_1): Change while to do-while,
1720 since the condition is always true at first.
1721
dc6c6455 1722 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1723 (interval_deletion_adjustment): Return unsigned value.
1724 All uses changed.
dc6c6455 1725
aba7731a
PE
1726 * process.c (list_processes_1, create_pty, read_process_output):
1727 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1728 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1729 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1730 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1731 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1732
fdfc4bf3
PE
1733 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1734
fca8fe46 1735 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1736 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1737
06a0259a 1738 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1739 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1740 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1741
e7b9e80f
PE
1742 * print.c (print_error_message): Avoid int overflow.
1743
56201685
PE
1744 * font.c (font_list_entities): Redo for clarity,
1745 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1746
78834453 1747 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1748 (font_score): Avoid potential overflow in diff calculation.
78834453 1749
0bc0b309 1750 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1751 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1752
e610eaca
PE
1753 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1754
b895abce
PE
1755 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1756 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1757 can always succeed if overflow has undefined behavior.
1758
1f1d9321 1759 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1760 (wordify): Omit three unnecessary tests.
1f1d9321 1761
c59478bc
PE
1762 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1763 All callers changed. This avoids the need for an unused var.
1764
79b73827
PE
1765 * casefiddle.c (casify_region): Remove var that is set but not used.
1766
a4db5dfe
PE
1767 * dired.c (file_name_completion): Remove var that is set but not used.
1768
43aae36e
PE
1769 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1770
2a47c44d 1771 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1772 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1773
a37c69bf
PE
1774 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1775 Check for integer overflow on size calculations.
1776
328ab8e7
PE
1777 * buffer.c (Fprevious_overlay_change): Remove var that is set
1778 but not used.
1779
e5a2a5cb
PE
1780 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1781 Remove vars that are set but not used.
8d84a6eb 1782 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1783 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1784
a60e5f68
PE
1785 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1786
f661cb61 1787 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1788 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1789
f0397f5a
PE
1790 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1791 that are set but not used.
1792
8664db06 1793 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1794 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1795
6abdaa4a
PE
1796 * xselect.c (x_get_local_selection, x_handle_property_notify):
1797 Remove vars that are set but not used.
1798
0ce7538d 1799 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1800 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1801
9ae848fc
PE
1802 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1803 Remove var that is set but not used.
0b918413
PE
1804 (scroll_bar_windows_size): Now size_t, not int.
1805 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1806 Check for overflow.
9ae848fc 1807
a5a62657
PE
1808 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1809 (map_tty_color) [!defined MSDOS]: Likewise.
1810
5c5cdd39
PE
1811 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1812
66ebf983
PE
1813 * coding.c: Remove vars that are set but not used.
1814 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1815 All callers changed.
1816 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1817 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1818 (decode_coding_charset): Remove vars that are set but not used.
1819
1be4d761
PE
1820 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1821 that is set but not used.
1822
47553fa8
PE
1823 * print.c (print_object): Remove var that is set but not used.
1824
1f7196bf 1825 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1826 The gnulib version avoids calling malloc in the usual case,
1827 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1828 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1829 * filelock.c (current_lock_owner): Likewise.
1830 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1831 * sysdep.c: Include allocator.h, careadlinkat.h.
1832 (emacs_no_realloc_allocator): New static constant.
1833 (emacs_readlink): New function.
fdb61804
PE
1834 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1835 ../lib/careadlinkat.h.
d1fdcab7 1836
f84c17c7
SM
18372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1838
1839 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1840 first non-nil return value).
1841
ef3862ad
JD
18422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1843
1844 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1845 if not defined (Bug#8403).
1846
376a7006
JB
18472011-04-02 Juanma Barranquero <lekktu@gmail.com>
1848
1849 * xdisp.c (display_count_lines): Remove parameter `start',
1850 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1851 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1852 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1853 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1854 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1855 and thereabouts. All callers changed.
1856 (get_per_char_metric): Remove parameter `f', unused since
1857 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1858
6ca3801d
JM
18592011-04-02 Jim Meyering <meyering@redhat.com>
1860
1861 do not dereference NULL upon failed strdup
1862 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1863 (ns_get_family): Likewise.
1864
d8e2b5ba
JB
18652011-04-02 Juanma Barranquero <lekktu@gmail.com>
1866
1867 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1868
8c74fcbd
JD
18692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1870
1871 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1872 later (Bug#8403).
1873
7200d79c
SM
18742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1875
03408648 1876 Add lexical binding.
7200d79c 1877
03408648
SM
1878 * window.c (Ftemp_output_buffer_show): New fun.
1879 (Fsave_window_excursion):
1880 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1881
1882 * lread.c (lisp_file_lexically_bound_p): New function.
1883 (Fload): Bind Qlexical_binding.
1884 (readevalloop): Remove `evalfun' arg.
1885 Bind Qinternal_interpreter_environment.
1886 (Feval_buffer): Bind Qlexical_binding.
1887 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1888 Mark as dynamic.
1889 (syms_of_lread): Declare `lexical-binding'.
1890
1891 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1892
1893 * keyboard.c (eval_dyn): New fun.
1894 (menu_item_eval_property): Use it.
ca105506
SM
1895
1896 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1897
03408648
SM
1898 * fns.c (concat, mapcar1): Accept byte-code-functions.
1899
1900 * eval.c (Fsetq): Handle lexical vars.
1901 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1902 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1903 (FletX, Flet): Obey lexical binding.
1904 (Fcommandp): Handle closures.
1905 (Feval): New `lexical' arg.
1906 (eval_sub): New function extracted from Feval. Use it almost
1907 everywhere where Feval was used. Look up vars in lexical env.
1908 Handle closures.
1909 (Ffunctionp): Move from subr.el.
1910 (Ffuncall): Handle closures.
1911 (apply_lambda): Remove `eval_flags'.
1912 (funcall_lambda): Handle closures and new byte-code-functions.
1913 (Fspecial_variable_p): New function.
1914 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1915 but without exporting it to Lisp.
23aba0ea 1916
23aba0ea 1917 * doc.c (Fdocumentation, store_function_docstring):
03408648 1918 * data.c (Finteractive_form): Handle closures.
23aba0ea 1919
03408648
SM
1920 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1921 interactive spec.
ba83908c 1922
03408648
SM
1923 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1924 byte-codes.
1925 (exec_byte_code): New function extracted from Fbyte_code to handle new
1926 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1927
03408648 1928 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1929
03408648 1930 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1931
e2abce01
JB
19322011-03-31 Juanma Barranquero <lekktu@gmail.com>
1933
1934 * xdisp.c (redisplay_internal): Fix prototype.
1935
63696a73 19362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1937
63696a73
EZ
1938 * xdisp.c (SCROLL_LIMIT): New macro.
1939 (try_scrolling): Use it when setting scroll_limit. Limit
1940 scrolling to 100 screen lines.
1941 (redisplay_window): Even when falling back on "recentering",
1942 position point in the window according to scroll-conservatively,
1943 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1944
1945 (try_scrolling): When point is above the window, allow searching
1946 as far as scroll_max, or one screenful, to compute vertical
1947 distance from PT to the scroll margin position. This prevents
1948 try_scrolling from unnecessarily failing when
1949 scroll-conservatively is set to a value slightly larger than the
1950 window height. Clean up the case of PT below the margin at bottom
1951 of window: scroll_max can no longer be INT_MAX. When aggressive
1952 scrolling is in use, don't let point enter the opposite scroll
1953 margin as result of the scroll.
1954 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1955 threshold of 100 lines for never-recentering scrolling.
1956
e4cc2dfc
JB
19572011-03-31 Juanma Barranquero <lekktu@gmail.com>
1958
1959 * dispextern.h (move_it_by_lines):
1960 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1961 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1962 (message_log_check_duplicate): Remove parameters `prev_bol' and
1963 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1964 (redisplay_internal): Remove parameter `preserve_echo_area',
1965 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1966
1967 * indent.c (Fvertical_motion):
1968 * window.c (window_scroll_pixel_based, Frecenter):
1969 Don't pass `need_y_p' to `move_it_by_lines'.
1970
1c470562
SM
19712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1972
44f230aa
SM
1973 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1974 steal a few bits to be more compact.
1975 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1976 Remove unneeded casts.
1977
1c470562
SM
1978 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1979
888adce9
ZK
19802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1981
1982 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1983 binding" message (bug#7967).
1984
f838ed7b
PE
19852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1986
77861b95
PE
1987 Fix more problems found by GCC 4.6.0's static checks.
1988
de6dbc14
PE
1989 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1990 Remove unused local var.
1991
f838ed7b
PE
1992 * editfns.c (Fmessage_box): Remove unused local var.
1993
792c7b2b
PE
1994 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1995 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1996 Omit unused local vars.
c499e557 1997 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1998 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1999 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2000 Omit unused local var.
2001
ba0165e1
PE
2002 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2003 Don't assume string length fits in int.
32ad8845 2004 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2005 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2006
3c59b4c9
PE
2007 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2008 instead of alloca (Bug#8344).
2009
a3eed478 2010 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2011 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2012
eb4d412d
PE
2013 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2014
1658b401
PE
2015 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2016 concerns.
2017
2018 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2019
2020 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2021
9a2c6e05
PE
2022 * keyboard.c (syms_of_keyboard): Use the same style as later
2023 in this function when indexing through an array. This also
2024 works around GCC bug 48267.
2025
03d0a109
PE
2026 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2027
44f730c8
PE
2028 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2029
fe75f926
PE
2030 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2031 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2032
ffa8c828
PE
2033 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2034 This avoids undefined behavior on integer overflow, and is a bit
2035 more convenient anyway since it is compared to a size_t variable.
2036
c5101a77
PE
2037 Variadic C functions now count arguments with size_t, not int.
2038 This avoids an unnecessary limitation on 64-bit machines, which
2039 caused (substring ...) to crash on large vectors (Bug#8344).
2040 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2041 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2042 All variadic functions and their callers changed accordingly.
c5101a77
PE
2043 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2044 * data.c (arith_driver, float_arith_driver): Likewise.
2045 * editfns.c (general_insert_function): Likewise.
2046 * eval.c (struct backtrace.nargs, interactive_p)
2047 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2048 (funcall_lambda, mark_backtrace): Likewise.
2049 * fns.c (concat): Likewise.
2050 * frame.c (x_set_frame_parameters): Likewise.
2051 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2052 0 if not found, not -1. All callers changed.
2053
dd3f25f7
PE
2054 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2055 (stack_copy_size): Now size_t, not int.
2056 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2057
461c2ab9
JB
20582011-03-28 Juanma Barranquero <lekktu@gmail.com>
2059
2060 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2061 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2062 All callers changed.
2063
2064 * lisp.h (multibyte_char_to_unibyte):
2065 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2066 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2067 * character.h (CHAR_TO_BYTE8):
2068 * cmds.c (internal_self_insert):
2069 * editfns.c (general_insert_function):
2070 * keymap.c (push_key_description):
2071 * search.c (Freplace_match):
2072 * xdisp.c (message_dolog, set_message_1): All callers changed.
2073
f6d62986
SM
20742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2075
2076 * keyboard.c (safe_run_hook_funcall): New function.
2077 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2078 don't set the hook to nil, but remove the offending function instead.
2079 (Qcommand_hook_internal): Remove, unused.
2080 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2081 Vcommand_hook_internal.
2082
2083 * eval.c (enum run_hooks_condition): Remove.
2084 (funcall_nil, funcall_not): New functions.
2085 (run_hook_with_args): Call each function through a `funcall' argument.
2086 Remove `cond' argument, now redundant.
2087 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2088 (Frun_hook_with_args_until_failure): Adjust accordingly.
2089 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2090
1db5b1ad
JB
20912011-03-28 Juanma Barranquero <lekktu@gmail.com>
2092
2093 * dispextern.h (string_buffer_position): Remove declaration.
2094
2095 * print.c (strout): Remove parameter `multibyte', unused since
2096 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2097
2098 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2099 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2100 All callers changed.
2101
2102 * w32.c (_wsa_errlist): Use braces for struct initializers.
2103
2104 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2105 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2106 All callers changed.
2107 (string_buffer_position): Likewise. Also, make static (it's never
2108 used outside xdisp.c).
2109 (cursor_row_p): Remove parameter `w', unused since
2110 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2111 (decode_mode_spec): Remove parameter `precision', introduced during
2112 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2113 All callers changed.
2114
5ffb62aa
JD
21152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2116
2117 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2118
461c2ab9 21192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2120
2121 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2122 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2123 (ns_update_auto_hide_menu_bar): New functions.
2124 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2125 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2126 ns_constrain_all_frames.
2127 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2128 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2129
5c380ffb
JD
21302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2131
2132 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2133
9af30bdf
GM
21342011-03-27 Glenn Morris <rgm@gnu.org>
2135
2136 * syssignal.h: Replace RETSIGTYPE with void.
2137 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2138 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2139 Replace SIGTYPE with void everywhere.
2140 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2141 * s/template.h (SIGTYPE): Remove commented out definition.
2142
e2abce01
JB
21432011-03-26 Eli Zaretskii <eliz@gnu.org>
2144
2145 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2146 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2147
f868cd8a
JB
21482011-03-26 Juanma Barranquero <lekktu@gmail.com>
2149
59eb0929
JB
2150 * w32.c (read_unc_volume): Use parameter `henum', instead of
2151 global variable `wget_enum_handle'.
2152
2153 * keymap.c (describe_vector): Remove parameters `indices' and
2154 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2155 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2156
f868cd8a
JB
2157 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2158
2159 * keyboard.c (timer_check): Remove parameter `do_it_now',
2160 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2161 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2162 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2163
2164 * keyboard.c (read_char):
2165 * w32menu.c (w32_menu_display_help):
2166 * xmenu.c (show_help_event, menu_help_callback):
2167 Adjust calls to `show_help_echo'.
2168
2169 * gtkutil.c (xg_maybe_add_timer):
2170 * keyboard.c (readable_events):
2171 * process.c (wait_reading_process_output):
2172 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2173
2174 * insdel.c (adjust_markers_gap_motion):
2175 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2176 (gap_left, gap_right): Don't call it.
2177
2ecf6fdb
CY
21782011-03-25 Chong Yidong <cyd@stupidchicken.com>
2179
2180 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2181 incurred during fontification.
2182
6b1f9ba4
JB
21832011-03-25 Juanma Barranquero <lekktu@gmail.com>
2184
2185 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2186 (DEFVAR_PER_BUFFER): Don't pass it.
2187
2188 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2189 (scrolling_window): Don't pass it.
2190
0f4a96b5
JB
21912011-03-25 Juanma Barranquero <lekktu@gmail.com>
2192
2193 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2194
2195 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2196 and `suffix'.
2197 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2198 of variables specific to SELinux and computation of `encoded_absname'.
2199
2200 * image.c (XPutPixel): Remove unused variable `height'.
2201
2202 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2203
2204 * unexw32.c (get_section_info): Remove unused variable `section'.
2205
2206 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2207 (system_process_attributes): Remove unused variable `sess'.
2208 (sys_read): Remove unused variable `err'.
2209
2210 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2211 (w32_wnd_proc): Remove unused variable `isdead'.
2212 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2213 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2214 (x_create_tip_frame): Remove unused variable `tem'.
2215
2216 * w32inevt.c (w32_console_read_socket):
2217 Remove unused variable `no_events'.
2218
2219 * w32term.c (x_draw_composite_glyph_string_foreground):
2220 Remove unused variable `width'.
2221
1149507c
JB
22222011-03-24 Juanma Barranquero <lekktu@gmail.com>
2223
2224 * w32term.c (x_set_glyph_string_clipping):
2225 Don't pass uninitialized region to CombineRgn.
2226
9c88f339
JB
22272011-03-23 Juanma Barranquero <lekktu@gmail.com>
2228
2229 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2230 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2231 (Fx_close_connection): Remove unused variable `i'.
2232
2233 * w32font.c (w32font_draw): Return number of glyphs.
2234 (w32font_open_internal): Remove unused variable `i'.
2235 (w32font_driver): Add missing initializer.
2236
2237 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2238 (fill_in_menu): Remove unused variable `items_added'.
2239
2240 * w32term.c (last_mouse_press_frame): Remove static global variable.
2241 (w32_clip_to_row): Remove unused variable `f'.
2242 (x_delete_terminal): Remove unused variable `i'.
2243
2244 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2245 (NOTHING): Remove unused static global variable.
2246 (uniscribe_check_otf): Remove unused variable `table'.
2247 (uniscribe_font_driver): Add missing initializers.
2248
dee091a3
JD
22492011-03-23 Julien Danjou <julien@danjou.info>
2250
2251 * term.c (Fsuspend_tty, Fresume_tty):
2252 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2253 * window.c (temp_output_buffer_show):
2254 * insdel.c (signal_before_change):
2255 * frame.c (Fhandle_switch_frame):
2256 * fileio.c (Fdo_auto_save):
2257 * emacs.c (Fkill_emacs):
2258 * editfns.c (save_excursion_restore):
2259 * cmds.c (internal_self_insert):
2260 * callint.c (Fcall_interactively):
2261 * buffer.c (Fkill_all_local_variables):
2262 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2263 Use Frun_hooks.
0f4a96b5 2264 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2265 unconditionnaly since it does the check itself.
2266
2c520ab5 22672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2268
c9c49752
PE
2269 Fix more problems found by GCC 4.5.2's static checks.
2270
8abc3f12
PE
2271 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2272 the first time through the loop, since we know p0 < p1 then.
2273 This also avoids a gcc -Wstrict-overflow warning.
2274
a2d26660
PE
2275 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2276 leading to a memory leak, possible in functions like
2277 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2278 of objects (Bug#8318).
a2d26660 2279
916c72e9
PE
2280 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2281 that could (at least in theory) be that large.
2282
19ab8a18
PE
2283 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2284 This is less likely to overflow, and avoids undefined behavior if
2285 overflow does occur. All callers changed. Use strtoul to scan
2286 for the unsigned long integer.
b7cbbd6f
PE
2287 (pint2hrstr): Simplify and tune code slightly.
2288 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2289
f0641eff
PE
2290 * scroll.c (do_scrolling): Work around GCC bug 48228.
2291 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2292
7f650bb9
PE
2293 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2294 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2295 (validate_x_resource_name): Simplify count usage.
2296 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2297
37dd57d1
PE
2298 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2299 fail (Bug#8306).
81e56e61 2300
699979fc 2301 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2302
401bf9b4
PE
2303 * process.c (Fmake_network_process): Use socklen_t, not int,
2304 where POSIX says socklen_t is required in portable programs.
2305 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2306 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2307 (Fmake_network_process, server_accept_connection):
2308 (wait_reading_process_output, read_process_output):
2309 Likewise.
2310
b93aacde
PE
2311 * process.c: Rename or move locals to avoid shadowing.
2312 (list_processes_1, Fmake_network_process):
2313 (read_process_output_error_handler, exec_sentinel_error_handler):
2314 Rename or move locals.
4dc343ee 2315 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2316 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2317 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2318 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2319 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2320
af8a867c 2321 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2322 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2323 Include tparam.h instead, since it declares them.
af8a867c
PE
2324 * cm.h (PC): Remove extern decl; tparam.h now does this.
2325 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2326 * terminfo.c: Include tparam.h, to check interfaces.
2327 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2328 (tparam): Adjust signature to match interface in tparam.h;
2329 this removes some undefined behavior. Check that outstring and len
2330 are zero, which they always are with Emacs.
2331 * tparam.h (PC, BC, UP): New extern decls.
2332
0248044d 2333 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2334 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2335
8ff096c1 2336 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2337 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2338 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2339 (ftfont_list): Remove unused local.
49eaafba
PE
2340 (get_adstyle_property, ftfont_pattern_entity):
2341 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2342 Rename locals to avoid shadowing.
8ff096c1 2343
e2be39f6
PE
2344 * xfont.c (xfont_list_family): Mark var as initialized.
2345
c9735e30
PE
2346 * xml.c (make_dom): Now static.
2347
8f5201ae
PE
2348 * composite.c (composition_compute_stop_pos): Rename local to
2349 avoid shadowing.
b246f932
PE
2350 (composition_reseat_it): Remove unused locals.
2351 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2352 (composition_update_it): Mark var as initialized.
11b61122
PE
2353 (find_automatic_composition): Mark vars as initialized,
2354 with a FIXME (Bug#8290).
8f5201ae 2355
760fbc2c
PE
2356 character.h: Rename locals to avoid shadowing.
2357 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2358 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2359 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2360 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2361 to avoid shadowing.
2362
ff08eb85
PE
2363 * textprop.c (property_change_between_p): Remove; unused.
2364
fc7bf025
PE
2365 * intervals.c (interval_start_pos): Now static.
2366
235d7abc
PE
2367 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2368
44f230aa
SM
2369 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2370 Rename locals to avoid shadowing.
3e7d6594 2371
50060332
PE
2372 * sound.c (wav_play, au_play, Fplay_sound_internal):
2373 Fix pointer signedness.
d01f234b 2374 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2375 (wav_play): Initialize a variable to 0, to prevent undefined
2376 behavior (Bug#8278).
50060332 2377
c4fc4e30
PE
2378 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2379
918436ed
PE
2380 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2381
c939f91b
PE
2382 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2383 clobbering (Bug#8298).
b9c7f648
PE
2384 * sysdep.c (sys_subshell): Likewise.
2385 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2386
6bd8c144
PE
2387 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2388 This should get cleaned up, so that child_setup has the
2389 same signature on all platforms.
2390
7710357c 2391 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2392 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2393
c59da222
CY
23942011-03-22 Chong Yidong <cyd@stupidchicken.com>
2395
2396 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2397 not to be necessary, and produces flickering.
2398
66b87493
GM
23992011-03-20 Glenn Morris <rgm@gnu.org>
2400
2401 * config.in: Remove file.
2402
45b6f6d5
JB
24032011-03-20 Juanma Barranquero <lekktu@gmail.com>
2404
2405 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2406 are now in src/globals.h.
2407 (syms_of_minibuf): Remove spurious & from previous change.
2408
3ec03f7e
LL
24092011-03-20 Leo <sdl.web@gmail.com>
2410
2411 * minibuf.c (completing-read-function): New variable.
2412 (completing-read-default): Rename from completing-read.
2413 (completing-read): Call completing-read-function.
2414
b14e3e21
CY
24152011-03-19 Juanma Barranquero <lekktu@gmail.com>
2416
2417 * xfaces.c (Fx_load_color_file):
2418 Read color file from absolute filename (bug#8250).
2419
f2b726e6
JB
24202011-03-19 Juanma Barranquero <lekktu@gmail.com>
2421
2422 * makefile.w32-in: Update dependencies.
2423
09f6ff02
EZ
24242011-03-17 Eli Zaretskii <eliz@gnu.org>
2425
2426 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2427
29a6015a
PE
24282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2429
a3a6c54e
PE
2430 Fix more problems found by GCC 4.5.2's static checks.
2431
b766f867
PE
2432 * process.c (make_serial_process_unwind, send_process_trap):
2433 (sigchld_handler): Now static.
2434
be02381c
PE
2435 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2436 That way, the code declares only the vars that it needs.
2437 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2438 * s/cygwin.h (PTY_ITERATION): Likewise.
2439 * s/darwin.h (PTY_ITERATION): Likewise.
2440 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2441
57048744
PE
2442 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2443 * process.c (allocate_pty): Don't declare stb unless it's needed.
2444
7914961c 2445 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2446 (CONSTANTLIM): Remove; unused.
2447 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2448 Define only if needed.
7914961c 2449
b3967b18
PE
2450 * unexelf.c (unexec): Name an expression,
2451 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2452 Use a different way to cause a compilation error if anyone uses
2453 n rather than nn, a way that does not involve shadowing.
73366a00 2454 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2455
29a6015a
PE
2456 * deps.mk (unexalpha.o): Remove; unused.
2457
43cfc33e 2458 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2459 * unexec.h: New file.
ce701a33
PE
2460 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2461 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2462 Depend on unexec.h.
2463 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2464 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2465 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2466 Change as necessary to match prototype in unexec.h.
ce701a33 2467
01f44d5a
PE
2468 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2469 shadowing.
4f63c6bb 2470 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2471
a6670b0b
PE
2472 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2473 Rename locals to avoid shadowing.
2474
cef2010d 2475 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2476 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2477
d4d7173a
PE
2478 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2479
f08b802a
PE
2480 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2481 warning when compiling print.c.
2482
3ddb0639
PE
2483 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2484 instead of using an uninitialized var.
5ad03b97 2485 (font_sort_entities): Mark var as initialized.
3ddb0639 2486
170a2692
PE
2487 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2488
e663c700
PE
2489 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2490 pointers to constants.
89bc529a 2491 (font_parse_fcname): Remove unused vars.
7b81e2d0 2492 (font_delete_unmatched): Now static.
ea838e10 2493 (font_get_spec): Remove; unused.
13a547c6
PE
2494 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2495 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2496 Rename or move locals to avoid shadowing.
e663c700 2497
2a80c887 2498 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2499 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2500
1384fa33 2501 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2502 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2503
8b2c52e9
PE
2504 * alloc.c (mark_backtrace): Move decl from here ...
2505 * lisp.h: ... to here, so that it can be checked.
2506
475545b5 2507 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2508 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2509 (lisp_indirect_variable): Name an expression,
2510 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2511 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2512
b1349114 2513 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2514 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2515 Use const pointer when appropriate.
b1349114 2516
a2928364
PE
2517 * lisp.h (get_system_name, get_operating_system_release):
2518 Move decls here, to check interfaces.
2519 * process.c (get_operating_system_release): Move decl to lisp.h.
2520 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2521 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2522 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2523 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2524 (Fformat_time_string, Fencode_time, Finsert_char):
2525 (Ftranslate_region_internal, Fformat):
2526 Rename or remove local vars to avoid shadowing.
9710023e 2527 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2528
a415e694
PE
2529 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2530 avoid shadowing.
2531
8ef4622d
PE
2532 * lisp.h (eassert): Check that the argument compiles, even if
2533 ENABLE_CHECKING is not defined.
2534
946f9a5b
PE
2535 * data.c (Findirect_variable): Name an expression, to avoid
2536 gcc -Wbad-function-cast warning.
112396d6 2537 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2538 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2539 (Fmake_variable_buffer_local, Fmake_local_variable):
2540 Mark variables as initialized.
52746918 2541 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2542
e5aab7e7 2543 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2544 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2545 Rename locals to avoid shadowing.
dff45157
PE
2546 (mark_stack): Move local variables into the #ifdef region where
2547 they're used.
7bc26fdb
PE
2548 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2549 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2550 needed otherwise.
2551 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2552 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2553 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2554
e5aab7e7
PE
2555 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2556 avoids undefined behavior in theory.
2557
4da60324
PE
2558 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2559
88043301
PE
2560 Use functions, not macros, for up- and down-casing (Bug#8254).
2561 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2562 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2563 to use the following functions instead of these macros.
2564 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2565 EMACS_INT, since callers assume the returned value fits in int.
2566 (upcase1): Likewise, for UPCASE_TABLE.
2567 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2568 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2569 the race-condition problem in the old DOWNCASE.
88043301 2570
19ed5445
PE
2571 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2572 Rename locals to avoid shadowing.
2573 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2574 (regex_compile, re_search_2, re_match_2_internal):
2575 Remove unused local vars.
952db0d7
PE
2576 (FREE_VAR): Rewrite so as not to use empty "else",
2577 which gcc can warn about.
da053e48 2578 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2579 (RETALLOC_IF): Define only if needed.
2580 (WORDCHAR_P): Likewise. This one is never needed, but is used
2581 only in a comment talking about a compiler bug, so put inside
2582 the #if 0 of that comment.
2583 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2584 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2585 Remove; unused.
19ed5445 2586
1f3561e4 2587 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2588 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2589 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2590
ded6f8f7
PE
2591 * search.c (simple_search): Remove unused var.
2592
dbd37a95
PE
2593 * dired.c (compile_pattern): Move decl from here ...
2594 * lisp.h: ... to here, so that it can be checked.
2595 (struct re_registers): New forward decl.
2596
7e47afad
PE
2597 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2598
85f24f61
PE
2599 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2600 All uses changed.
2601 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2602 Rename locals to avoid shadowing.
5671df8f 2603 (Fvertical_motion): Mark locals as initialized.
85f24f61 2604
181aa2be 2605 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2606 (casify_region): Mark local as initialized.
181aa2be 2607
930d429c
PE
2608 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2609
7082eac6
PE
2610 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2611 New macros, so that the caller can use some names other than
2612 gcpro1, gcpro2, etc.
2613 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2614 of the new macros.
2615 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2616 argument, for consistency with GCPRO2_VAR, etc: it is now the
2617 prefix of the variable, not the variable itself. All uses
2618 changed.
38b2c076
PE
2619 * dired.c (directory_files_internal, file_name_completion):
2620 Rename locals to avoid shadowing.
2621
15206ed9
PE
2622 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2623 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2624 dired.c's scmp function, had undefined behavior.
2625 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2626 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2627 * buffer.h: ... to here, because these macros use current_buffer,
2628 and the new implementation with inline functions needs to have
2629 current_buffer in scope now, rather than later when the macros
2630 are used.
2631 (downcase, upcase1): New static inline functions.
2632 (DOWNCASE, UPCASE1): Reimplement using these functions.
2633 This avoids undefined behavior in expressions like
2634 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2635 from race conditions in accessing the global variables
2636 case_temp1 and case_temp2.
2637 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2638 * lisp.h (case_temp1, case_temp2): Remove their decls.
2639 * character.h (ASCII_CHAR_P): Move from here ...
2640 * lisp.h: ... to here, so that the inline functions mentioned
2641 above can use them.
2642
4a6bea26
PE
2643 * dired.c (directory_files_internal_unwind): Now static.
2644
f14b7e14
PE
2645 * fileio.c (file_name_as_directory, directory_file_name):
2646 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2647 Now static.
2893f146
PE
2648 (file_name_as_directory): Use const pointers when appropriate.
2649 (Fexpand_file_name): Likewise. In particular, newdir might
2650 point at constant storage, so make it a const pointer.
fd4ead52 2651 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2652 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2653 signedness issues.
f839df0c
PE
2654 (Fset_file_times, Finsert_file_contents, auto_save_error):
2655 Rename locals to avoid shadowing.
f14b7e14 2656
5716756e 2657 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2658 (Ftry_completion, Fall_completions): Rename or remove locals
2659 to avoid shadowing.
5716756e 2660
b4c3046a
PE
2661 * marker.c (bytepos_to_charpos): Remove; unused.
2662
b45db522
PE
2663 * lisp.h (verify_bytepos, count_markers): New decls,
2664 so that gcc does not warn that these functions aren't declared.
2665
85876d07
PE
2666 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2667 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2668 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2669 (copy_text): Remove unused local var.
85876d07 2670
03d78a21 2671 * filelock.c (within_one_second): Now static.
b3dd38ab 2672 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2673
5df8f01b
PE
2674 * buffer.c (fix_overlays_before): Mark locals as initialized.
2675 (fix_start_end_in_overlays): Likewise. This function should be
2676 simplified by using pointers-to-pointers, but that's a different
2677 matter.
b1d876f1 2678 (switch_to_buffer_1): Now static.
8f54f30a
PE
2679 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2680 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2681
a70072c9 2682 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2683 Fix pointer signedness issue.
edced198
PE
2684 (sys_subshell): Mark local as volatile if checking for lint,
2685 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2686 (MAXPATHLEN): Define only if needed.
a70072c9 2687
a0977c44
PE
2688 * process.c (serial_open, serial_configure): Move decls from here ...
2689 * systty.h: ... to here, so that they can be checked.
2690
a884fdcc
PE
2691 * fns.c (get_random, seed_random): Move extern decls from here ...
2692 * lisp.h: ... to here, so that they can be checked.
2693
604efe86 2694 * sysdep.c (reset_io): Now static.
b8950c94 2695 (wait_for_termination_signal): Remove; unused.
604efe86 2696
38fc62d9
PE
2697 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2698 (copy_keymap_item, append_key, push_text_char_description):
2699 Now static.
1004a21a 2700 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2701 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2702 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2703 (describe_map_tree):
2704 Rename locals to avoid shadowing.
38fc62d9 2705
2f2650da
PE
2706 * keyboard.c: Declare functions static if they are not used elsewhere.
2707 (echo_char, echo_dash, cmd_error, top_level_2):
2708 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2709 (read_char, kbd_buffer_get_event, make_lispy_position):
2710 (make_lispy_event, make_lispy_movement, apply_modifiers):
2711 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2712 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2713 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2714 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2715 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2716
a053e86c 2717 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2718 (mark_kboards): Move decl here ...
2719 * alloc.c (mark_kboards): ... from here.
a053e86c 2720
4752793e
PE
2721 * lisp.h (force_auto_save_soon): New decl.
2722
74f10ca7 2723 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2724 (DEFINE_DUMMY_FUNCTION): New macro.
2725 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2726 Use it.
c03cd23f
PE
2727 (main): Add casts to avoid warnings
2728 if GCC considers string literals to be constants.
74f10ca7 2729
022e70d4
PE
2730 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2731
59d6fe83
PE
2732 * dbusbind.c: Pointer signedness fixes.
2733 (xd_signature, xd_append_arg, xd_initialize):
2734 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2735 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2736 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2737 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2738
78320123
PE
2739 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2740 if GCC considers string literals to be constants.
49cebcca 2741 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2742
35ac2a97
SM
27432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2744
fb103ca9
SM
2745 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2746 (print_preprocess, print_object): New macro to fix last change.
2747
35ac2a97
SM
2748 * print.c (print_preprocess): Don't forget font objects.
2749
62973b41
JB
27502011-03-16 Juanma Barranquero <lekktu@gmail.com>
2751
2752 * emacs.c (USAGE3): Doc fixes.
2753
0e48bb22
AS
27542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2755
2756 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2757 structure.
2758
7684e57b
JB
27592011-03-14 Juanma Barranquero <lekktu@gmail.com>
2760
2761 * lisp.h (VWindow_system, Qfile_name_history):
2762 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2763 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2764 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2765
2766 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2767 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2768
2769 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2770 * w32console.c (detect_input_pending, read_input_pending)
2771 (encode_terminal_code):
2772 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2773 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2774 (w32_system_caret_y, Qfile_name_history):
2775 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2776 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2777 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2778 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2779 * w32proc.c (Qlocal, report_file_error):
2780 * w32term.c (Vwindow_system, updating_frame):
2781 * w32uniscribe.c (initialized, uniscribe_font_driver):
2782 Remove unneeded extern declarations.
2783
2aa46d6c
CY
27842011-03-14 Chong Yidong <cyd@stupidchicken.com>
2785
c96bbc66 2786 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2787
cffc6f3b
CY
27882011-03-13 Chong Yidong <cyd@stupidchicken.com>
2789
2790 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2791 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2792 These macros can no longer be used for assignment.
2793
44f230aa
SM
2794 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2795 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2796 (record_buffer_markers, fetch_buffer_markers): New functions for
2797 recording and fetching special buffer markers.
2798 (set_buffer_internal_1, set_buffer_temp): Use them.
2799
2800 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2801
2802 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2803
2804 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2805 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2806
2807 * xdisp.c (hscroll_window_tree):
2808 (reconsider_clip_changes): Use PT instead of BUF_PT.
2809
d251f04b
EZ
28102011-03-13 Eli Zaretskii <eliz@gnu.org>
2811
2812 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2813 $(EMACS_ROOT)/lib/intprops.h.
2814
f0c77cd1
PE
28152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2816
3eca4629
PE
2817 Fix more problems found by GCC 4.5.2's static checks.
2818
7c86ee98
PE
2819 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2820 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2821 (xg_free_frame_widgets): Make it clear that a local variable is
2822 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2823 (gdk_window_get_screen): Make it clear that this macro is needed
2824 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2825 (int_gtk_range_get_value): New function, which avoids a diagnostic
2826 from gcc -Wbad-function-cast.
2827 (xg_set_toolkit_scroll_bar_thumb): Use it.
2828 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2829 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2830 (get_utf8_string, xg_get_file_with_chooser):
2831 Rename locals to avoid shadowing.
2832 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2833
41729b81
PE
2834 * xgselect.c (xg_select): Remove unused var.
2835
f0c77cd1
PE
2836 * image.c (four_corners_best): Mark locals as initialized.
2837 (gif_load): Initialize transparent_p to zero (Bug#8238).
2838 Mark another local as initialized.
ec6cf4c6 2839 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2840
ce0ad53d 2841 * image.c (clear_image_cache): Now static.
d5d5a617 2842 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2843 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2844 (x_edge_detection): Remove unnecessary cast that
2845 gcc -Wbad-function-cast diagnoses.
2037898d 2846 (gif_load): Fix pointer signedness.
6ae141d6
PE
2847 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2848 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2849
33383987 28502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2851
d32df629
PE
2852 Improve quality of tests for time stamp overflow.
2853 For example, without this patch (encode-time 0 0 0 1 1
2854 1152921504606846976) returns the obviously-bogus value (-948597
2855 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2856 reports time overflow. See
2857 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2858 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2859 * editfns.c: Include limits.h and intprops.h.
2860 (TIME_T_MIN, TIME_T_MAX): New macros.
2861 (time_overflow): Move earlier, to before first use.
2862 (hi_time, lo_time): New functions, for an accurate test for
2863 out-of-range times.
2864 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2865 (Fget_internal_run_time): Don't assume time_t fits in int.
2866 (make_time): Use list2 instead of Fcons twice.
2867 (Fdecode_time): More accurate test for out-of-range times.
2868 (check_tm_member): New function.
2869 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2870 (lisp_time_argument): Don't rely on undefined left-shift and
2871 right-shift behavior when checking for time stamp overflow.
8be6f318 2872
fe31d94c
PE
2873 * editfns.c (time_overflow): New function, refactoring common code.
2874 (Fformat_time_string, Fdecode_time, Fencode_time):
2875 (Fcurrent_time_string): Use it.
2876
8be6f318
PE
2877 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2878 * dired.c (make_time): Move to ...
2879 * editfns.c (make_time): ... here.
2880 * systime.h: Note the move.
2881
09d9db2c 28822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2883
126bc0dc
YM
2884 * fringe.c (update_window_fringes): Remove unused variables.
2885
c47cbdfd
YM
2886 * unexmacosx.c (copy_data_segment): Also copy __got section.
2887 (Bug#8223)
2888
7ac80be9
EZ
28892011-03-12 Eli Zaretskii <eliz@gnu.org>
2890
c96bbc66 2891 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2892 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2893 Constify `char *' arguments and their references according to
2894 prototypes in tparam.h.
2895
ecb0f94d 2896 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2897
7ac80be9
EZ
2898 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2899 Adapt all references accordingly.
2900
2901 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2902
ef1fd07e
TT
29032011-03-11 Tom Tromey <tromey@redhat.com>
2904
2905 * buffer.c (syms_of_buffer): Remove obsolete comment.
2906
7ef4b50c
EZ
29072011-03-11 Eli Zaretskii <eliz@gnu.org>
2908
2909 * termhooks.h (encode_terminal_code): Declare prototype.
2910
2911 * msdos.c (encode_terminal_code): Don't declare prototype.
2912
2913 * term.c (encode_terminal_code): Now external again, used by
2914 w32console.c and msdos.c.
2915
44f230aa
SM
2916 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2917 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2918
4b1ec863 29192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2920
1714f52b 2921 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2922
4b1ec863
PE
2923 * fringe.c (update_window_fringes): Mark locals as initialized
2924 (Bug#8227).
2925 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2926
524c7aa6
PE
2927 * alloc.c (mark_fringe_data): Move decl from here ...
2928 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2929 to check its interface.
2930 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2931
a5c0af81 2932 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2933 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2934 (fontset_font): Mark local as initialized.
a9a06e0b 2935 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2936
b4716021
PE
2937 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2938
811e9bac 2939 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2940 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2941 (x_own_selection, Fx_disown_selection_internal): Rename locals
2942 to avoid shadowing.
2943 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2944
7e3ab302
PE
2945 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2946 so that the caller can use some name other than gcpro1.
2947 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2948 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2949 (Fx_backspace_delete_keys_p):
2950 Use them to avoid shadowing, and rename vars to avoid shadowing.
2951 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2952 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2953 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2954 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2955 Remove unused locals.
7e3ab302
PE
2956 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2957 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2958 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2959 macros.
f78faa98 2960
e2b13473
PE
2961 * xterm.h (x_mouse_leave): New decl.
2962
77f23912
PE
2963 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2964 Remove unused functions.
cdf4ba58
PE
2965 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2966 (x_calc_absolute_position): Now static.
7411c686 2967 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2968 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2969 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2970 unless they are used.
38d0b34a
PE
2971 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2972 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2973 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2974 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2975 (x_error_catcher, x_connection_closed, x_error_handler):
2976 (x_error_quitter, xembed_send_message, x_iconify_frame):
2977 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2978 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2979 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2980
44f230aa
SM
2981 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2982 Rename or move locals to avoid shadowing.
6b463e58 2983 (tty_defined_color, merge_face_heights): Now static.
5967d051 2984 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2985 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2986 does not deduce is never used uninitialized.
73719eba
PE
2987 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2988 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2989
426994c3 2990 * terminal.c (store_terminal_param): Now static.
5489860b 2991
032f1620 2992 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2993 (set_frame_menubar): Remove unused local.
d4323972 2994 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2995 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2996 since they might point to immutable storage.
281585b0
PE
2997 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2998 since it's unused otherwise.
032f1620 2999
367c19e5 3000 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3001 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3002 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3003 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3004 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3005 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3006 does not deduce are never used uninitialized.
70739cbe 3007
07b48fa9
PE
3008 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3009
8868a238 3010 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3011 * window.c (window_loop, size_window):
3012 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3013
7e5cf297 3014 * window.c (display_buffer): Now static.
d6550a9f
PE
3015 (size_window): Mark variables that gcc -Wuninitialized
3016 does not deduce are never used uninitialized.
a586633d
PE
3017 * window.h (check_all_windows): New decl, to forestall
3018 gcc -Wmissing-prototypes diagnostic.
5b555da1 3019 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3020
f6095868
PE
3021 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3022 shadowing.
3023 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3024 Include <limits.h>.
3025 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3026 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3027 (load_charset_map): Mark variables that gcc -Wuninitialized
3028 does not deduce are never used uninitialized.
53df7c11 3029 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3030
f38b440c
PE
3031 * coding.c (coding_set_source, coding_set_destination):
3032 Use "else { /* comment */ }" rather than "else /* comment */;"
3033 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3034 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3035 a block, when the outer 'i' will do.
3036 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3037 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3038 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3039 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3040 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3041 Rename locals to avoid shadowing.
3042 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3043 * coding.c (emacs_mule_char, encode_invocation_designation):
3044 Now static, since they're not used elsewhere.
413bb2db 3045 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3046 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3047 (decode_coding_emacs_mule): Mark variables that gcc
3048 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3049 (detect_coding_iso_2022): Initialize a local variable that might
3050 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3051 this initialization is needed. (Bug#8211)
5f58e762
PE
3052 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3053 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3054 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3055 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3056 Remove unused macros.
f38b440c 3057
232b38b9 3058 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3059 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3060 * character.c (string_count_byte8): Likewise.
232b38b9 3061
fb90da1b
PE
3062 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3063 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3064
fb93dbc2
PE
3065 * chartab.c (copy_sub_char_table): Now static, since it's not used
3066 elsewhere.
5c156ace
PE
3067 (sub_char_table_ref_and_range, char_table_ref_and_range):
3068 Rename locals to avoid shadowing.
bbcd0949 3069 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3070
7d3b3862 3071 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3072 (BIDI_BOB): Remove unused macro.
7d3b3862 3073
6be7d3da
PE
3074 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3075 deduce are never used uninitialized.
c2ed9c8b 3076 * term.c (encode_terminal_code): Likewise.
6be7d3da 3077
75f8807f 3078 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3079
50938595
PE
3080 * tparam.h: New file.
3081 * term.c, tparam.h: Include it.
3082 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3083 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3084 Move these decls to tparam.h, and make them agree with what
3085 is actually in tparam.c. The previous trick of using incompatible
3086 decls in different modules does not conform to the C standard.
3087 All callers of tparam changed to use tparam's actual API.
3088 * tparam.c (tparam1, tparam, tgoto):
3089 Use const pointers where appropriate.
3090
fbceeba2
PE
3091 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3092 * cm.h (struct cm): Likewise.
3093 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3094 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3095 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3096 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3097 (turn_on_face, init_tty): Likewise.
3098 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3099
7f3f1250
PE
3100 * term.c (term_mouse_position): Rename local to avoid shadowing.
3101
e6ca6543
PE
3102 * alloc.c (mark_ttys): Move decl from here ...
3103 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3104
c40f8d15
AS
31052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3106
3107 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3108
cfe0661d
JB
31092011-03-09 Juanma Barranquero <lekktu@gmail.com>
3110
3111 * search.c (compile_pattern_1): Remove argument regp, unused since
3112 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3113 (compile_pattern): Don't pass it.
3114
0afb4571
J
31152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3116
3117 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3118 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3119 for ! HAVE_GTK3.
3120 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3121
3122 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3123
3124 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3125 gdk_window_get_screen, gdk_window_get_geometry,
3126 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3127 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3128 (xg_get_pixbuf_from_pixmap): New function.
3129 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3130 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3131 Call xg_get_pixbuf_from_pixmap instead of
3132 gdk_pixbuf_get_from_drawable.
3133 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3134 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3135 (xg_check_special_colors): Use GtkStyleContext and its functions
3136 for HAVE_GTK3.
3137 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3138 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3139 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3140 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3141 Call gtk_widget_get_preferred_size.
0afb4571
J
3142 (xg_frame_resized): gdk_window_get_geometry only takes 5
3143 parameters.
44f230aa
SM
3144 (xg_win_to_widget, xg_event_is_for_menubar):
3145 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3146 (xg_set_widget_bg): New function.
3147 (delete_cb): New function.
895009e1 3148 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3149 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3150 (xg_set_background_color): Call xg_set_widget_bg.
3151 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3152 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3153 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3154 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3155 if ! HAVE_GTK3.
3156 (update_frame_tool_bar): Call gtk_widget_hide.
3157 (xg_initialize): Use GDK_KEY_g.
3158
3159 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3160 if ! HAVE_GTK3
3161 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3162
3163 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3164 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3165 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3166
1c2cc4ef
JB
31672011-03-08 Juanma Barranquero <lekktu@gmail.com>
3168
3169 * w32xfns.c (select_palette): Check success of RealizePalette against
3170 GDI_ERROR, not zero.
3171
33383987 3172See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3173
3174;; Local Variables:
3175;; coding: utf-8
aac0c6e3
MR
3176;; End:
3177
33383987 3178 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3179
3180 This file is part of GNU Emacs.
3181
3182 GNU Emacs is free software: you can redistribute it and/or modify
3183 it under the terms of the GNU General Public License as published by
3184 the Free Software Foundation, either version 3 of the License, or
3185 (at your option) any later version.
3186
3187 GNU Emacs is distributed in the hope that it will be useful,
3188 but WITHOUT ANY WARRANTY; without even the implied warranty of
3189 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3190 GNU General Public License for more details.
3191
3192 You should have received a copy of the GNU General Public License
3193 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.