More updates to Programs chapter of Emacs manual.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
75a3b399
PE
12011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2
3 * coding.c (encode_designation_at_bol): Don't use uninitialized
4 local variable (Bug#9318).
5
c3c9e25e
KH
62011-12-05 Kenichi Handa <handa@m17n.org>
7
8 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9 return Qnil (Bug#8046, Bug#10193).
10
5eb05ea3
KH
112011-12-05 Kenichi Handa <handa@m17n.org>
12
13 * coding.c (encode_designation_at_bol): New args charbuf_end and
14 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
15 (coding_set_source): Return how many bytes coding->source was
16 relocated.
17 (coding_set_destination): Return how many bytes
18 coding->destination was relocated.
19 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
20 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
21
222011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
23
24 * coding.c (CODING_CHAR_CHARSET_P): New macro.
25 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
26 macro (Bug#9318).
27
282011-12-05 Andreas Schwab <schwab@linux-m68k.org>
29
30 The following changes are to fix Bug#9318.
31
a79703f5 32 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
33 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
34 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 35 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 36
7dbda6df
JB
372011-12-05 Juanma Barranquero <lekktu@gmail.com>
38
39 * lisp.h (process_quit_flag): Fix external declaration.
40
6d5eb5b0
SM
412011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
42
43 Don't macro-inline non-performance-critical code.
44 * eval.c (process_quit_flag): New function.
45 * lisp.h (QUIT): Use it.
46
a0c3fad0
JD
472011-12-04 Jan Djärv <jan.h.d@swipnet.se>
48
49 * nsfns.m (get_geometry_from_preferences): New function.
50 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
51
6c07aac2
AS
522011-12-04 Andreas Schwab <schwab@linux-m68k.org>
53
54 * emacs.c (Qkill_emacs): Define.
55 (syms_of_emacs): Initialize it.
56 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
57 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
58 (quit_throw_to_read_char): Add parameter `from_signal'.
59 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
60 * lisp.h (QUIT): Call Fkill_emacs if requested.
61
c052ead4
JD
622011-12-03 Jan Djärv <jan.h.d@swipnet.se>
63
64 * widget.c (update_wm_hints): Return if wmshell is null.
65 (widget_update_wm_size_hints): New function.
66
67 * widget.h (widget_update_wm_size_hints): Declare.
68
69 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
70 widget_update_wm_size_hints (Bug#10104).
71
9e49252b
EZ
722011-12-03 Eli Zaretskii <eliz@gnu.org>
73
74 * xdisp.c (handle_invisible_prop): If the invisible text ends just
75 before a newline, prepare the bidi iterator for consuming the
76 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 77 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 78
02b16839
JL
792011-12-02 Juri Linkov <juri@jurta.org>
80
81 * search.c (Fword_search_regexp): New Lisp function created from
82 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
83 (Fword_search_backward, Fword_search_forward)
84 (Fword_search_backward_lax, Fword_search_forward_lax):
85 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
86 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
87
0068070e
SM
882011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
89
90 * fileio.c (Finsert_file_contents): Move after-change-function call
91 to before the "handled:" label, since all "goto handled" appear in
92 cases where the *-change-functions have already been properly called
93 (bug#10117).
94
3360a3fc
AS
952011-12-01 Andreas Schwab <schwab@linux-m68k.org>
96
97 * keyboard.c (interrupt_signal): Don't call kill-emacs when
98 waiting for input. (Bug#10169)
99
73d6c093
EZ
1002011-11-30 Eli Zaretskii <eliz@gnu.org>
101
102 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
103 verifies glyph row's hash code--we have just reallocated the
104 glyphs, so their contents can be complete garbage. (Bug#10164)
105
febe6bea
JB
1062011-11-30 Juanma Barranquero <lekktu@gmail.com>
107
108 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
109
801a4313
EZ
1102011-11-30 Eli Zaretskii <eliz@gnu.org>
111
112 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
113 attributes are tested _before_ calling verify_row_hash, to protect
114 against GCC re-ordering of the tests. (Bug#10164)
115
2b56b87e
JD
1162011-11-29 Jan Djärv <jan.h.d@swipnet.se>
117
118 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
119
120 * xterm.c (handle_one_xevent): Only set async_visible and friends
121 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 122 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
123 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
124
dbf31225
PE
1252011-11-28 Paul Eggert <eggert@cs.ucla.edu>
126
127 Remove GCPRO-related macros that exist only to avoid shadowing locals.
128 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
129 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
130 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
131 All uses changed to use GCPRO1 etc.
132 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
133 Revert to old implementation (i.e., before 2011-03-11).
134
1305621b
YM
1352011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
136
137 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
138 of scroll runs so as to avoid assigning disabled bogus rows and
139 unnecessary graphics copy operations.
140
8c9afb46
EZ
1412011-11-27 Eli Zaretskii <eliz@gnu.org>
142
143 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
144 (snprintf) [_MSC_VER]: Redirect to _snprintf.
145 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
146 (malloc, free, realloc, calloc): Redirect to e_* only when
147 compiling Emacs.
148
149 * lisp.h (GCTYPEBITS): Move before first use.
150 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
151 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
152 this macro definition.
153
154 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
155 _MSC_VER.
156
54e9e3bf
JD
1572011-11-27 Jan Djärv <jan.h.d@swipnet.se>
158
6d5eb5b0
SM
159 * gtkutil.c (xg_create_frame_widgets):
160 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
161 present with Gtk+ 2.0.
162
83aca1cb
PE
1632011-11-26 Paul Eggert <eggert@cs.ucla.edu>
164
165 * fileio.c (Finsert_file_contents): Undo previous change; see
166 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
167
5b76caa4
PE
1682011-11-26 Paul Eggert <eggert@cs.ucla.edu>
169
170 Rename locals to avoid shadowing.
171 * fileio.c (Finsert_file_contents):
172 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
173 * process.c (wait_reading_process_output):
174 Rename inner 'proc' to 'p' to avoid shadowing.
175 Indent for consistency with usual Emacs style.
176
8c535114
EZ
1772011-11-25 Eli Zaretskii <eliz@gnu.org>
178
179 * xdisp.c (redisplay_window): If cursor row is not fully visible
180 after recentering, and scroll-conservatively is set to a large
181 number, scroll window by a few more lines to make the cursor fully
182 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
183 (start_display): Don't move to the next line if the display should
184 start at a newline that is part of a display vector or an overlay
185 string. (Bug#10119)
8c535114 186
fa4fdb5c
JL
1872011-11-24 Juri Linkov <juri@jurta.org>
188
189 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
190 after the `MagickPingImage' call. (Bug#10112)
191
90ec88df
CY
1922011-11-23 Chong Yidong <cyd@gnu.org>
193
194 * window.c (Fcoordinates_in_window_p): Accept only live windows.
195
56e2e794
MR
1962011-11-23 Martin Rudalics <rudalics@gmx.at>
197
198 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
199 making another buffer current. (Bug#10114)
200
b6e64c41
GM
2012011-11-23 Glenn Morris <rgm@gnu.org>
202
203 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
204
6b21de18
CY
2052011-11-23 Chong Yidong <cyd@gnu.org>
206
207 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
208 using it (Bug#5984).
209
b12cd789
EZ
2102011-11-22 Eli Zaretskii <eliz@gnu.org>
211
212 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
213 and header-lines, as they don't have one computed for them.
214 (Bug#10098)
215
216 * .gdbinit (prow): Make displayed values more self-explaining.
217 Add row's hash code.
218
261b6fd4
LMI
2192011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
220
221 * process.c (wait_reading_process_output): Fix asynchrounous
222 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 223 (wait_reading_process_output): Add comment and URL.
261b6fd4 224
e7cfd277
JD
2252011-11-21 Jan Djärv <jan.h.d@swipnet.se>
226
227 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
228
a9b9b7f5
CY
2292011-11-21 Chong Yidong <cyd@gnu.org>
230
231 * window.c (Fnext_window, Fprevious_window): Doc fix.
232
b0d15b4f
SM
2332011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
234
235 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
236
fe7a3057
JB
2372011-11-20 Juanma Barranquero <lekktu@gmail.com>
238
239 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
240
d2999b1a
MR
2412011-11-20 Martin Rudalics <rudalics@gmx.at>
242
243 * window.c (Fset_window_combination_limit): Rename argument
244 STATUS to LIMIT.
245 (Vwindow_combination_limit): Remove "status" from doc-string.
246
d5ff9cd0
AS
2472011-11-20 Andreas Schwab <schwab@linux-m68k.org>
248
249 * m/ibms390.h: Remove.
250 * m/ibms390x.h: Don't include "ibms390.h".
251
a5bb9bd3
SM
2522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
253
254 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
255 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
256
cd1181db
JB
2572011-11-20 Juanma Barranquero <lekktu@gmail.com>
258
259 * casetab.c (Fset_case_table):
260 * charset.c (Fcharset_after): Fix typos.
261
615a3b8d 2622011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 263
17e845af
PE
264 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
265 Otherwise, valgrind does not work on some platforms.
266 Problem reported by Andreas Schwab in
6a0bf43d
PE
267 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
268 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
269 is set, removing the need for VIRT_ADDRESS_VARIES.
270 (PURE_P): Use a more-efficient implementation that needs just one
271 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
272 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
273 to 4 (xorl, subq, cmpq, setbe).
274 * alloc.c (pure): Always extern now, since that's the
275 VIRT_ADDR_VARIES behavior.
276 (PURE_POINTER_P): Use a single comparison, not two, for
277 consistency with the new puresize.h.
278 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
279 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
280 Remove VIRT_ADDR_VARIES no longer needed.
281
f8fe6f96
EZ
2822011-11-19 Eli Zaretskii <eliz@gnu.org>
283
284 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
285 (erase_phys_cursor, update_window_cursor, show_mouse_face)
286 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
287 behave as if the cursor position were at the window margin.
288
289 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
290 and the cursor position is out of bounds, behave as if the cursor
291 position were at the window margin. (Bug#10075)
292
df05a53c
CY
2932011-11-18 Chong Yidong <cyd@gnu.org>
294
295 * window.c (Fwindow_combination_limit): Make first argument
296 non-optional, since it is meaningless for live windows like the
297 selected window.
298
2071918e
DA
2992011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
300
301 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
302
b50a28de
SM
3032011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
304
305 * intervals.c: Fix grafting over the whole buffer (bug#10071).
306 (graft_intervals_into_buffer): Simplify.
307
015137db
EZ
3082011-11-18 Eli Zaretskii <eliz@gnu.org>
309
310 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
311 hash values of the two rows.
312 (copy_row_except_pointers): Preserve the used[] arrays and the
313 hash values of the two rows. (Bug#10035)
68c95424 314 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
315
316 * xdisp.c (row_hash): New function, body extracted from
317 compute_line_metrics.
318 (compute_line_metrics): Call row_hash, instead of computing the
319 hash code inline.
320
321 * dispnew.c (verify_row_hash): Call row_hash for computing the
322 hash code of a row, instead of duplicating code from xdisp.c.
323
324 * dispextern.h (row_hash): Add prototype.
325
a2addb04
TH
3262011-11-18 Tassilo Horn <tassilo@member.fsf.org>
327
328 * frame.c (delete_frame): Don't delete the terminal when the last
329 X frame is closed if emacs is built with GTK toolkit.
330
df85d315
JB
3312011-11-17 Juanma Barranquero <lekktu@gmail.com>
332
333 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
334
a0c2d0ae
MR
3352011-11-17 Martin Rudalics <rudalics@gmx.at>
336
337 * window.c (Vwindow_splits): Rename to
338 Vwindow_combination_resize. Suggested by Juri Linkov.
339 (Fsplit_window_internal): Use Vwindow_combination_resize instead
340 of Vwindow_splits.
341
58179cce
JB
3422011-11-16 Juanma Barranquero <lekktu@gmail.com>
343
7877f373
JB
344 * nsfns.m (Fns_font_name):
345 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 346
b6f67890
MR
3472011-11-16 Martin Rudalics <rudalics@gmx.at>
348
349 * window.h (window): Rename slot "nest" to "combination_limit".
350 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
351 (Fset_window_nest): Rename to Fset_window_combination_limit.
352 (Vwindow_nest): Rename to Vwindow_combination_limit.
353 (recombine_windows, make_parent_window, make_window)
354 (Fsplit_window_internal, saved_window)
355 (Fset_window_configuration, save_window_save): Rename all
356 occurrences of window_nest to window_combination_limit.
357
c7015153
JB
3582011-11-15 Juanma Barranquero <lekktu@gmail.com>
359
360 * image.c (imagemagick_load_image): Fix typo.
361
322ad6ec
EZ
3622011-11-14 Eli Zaretskii <eliz@gnu.org>
363
364 * xdisp.c (display_line): Move the call to
365 highlight_trailing_whitespace before the call to
366 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
367 faces of all the glyphs to compute ROW's hash value.
368 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 369
f067b8ec
JB
3702011-11-14 Juanma Barranquero <lekktu@gmail.com>
371
372 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
373 just return (bug#10044).
374
1e5b2111
EZ
3752011-11-12 Eli Zaretskii <eliz@gnu.org>
376
7ef3cbd5
EZ
377 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
378 with user-defined heap size. Bump the default size of the temacs
379 heap to 27MB, to avoid memory warning when running temacs.
380 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
381
1e5b2111
EZ
382 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
383 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
384 (verify_row_hash) [XASSERTS]: New function.
385 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
386 that the hash value of glyph rows is correct.
1e5b2111 387
89d61221
MR
3882011-11-12 Martin Rudalics <rudalics@gmx.at>
389
390 * window.h (window): Remove splits slot.
391 * window.c (Fwindow_splits, Fset_window_splits): Remove.
392 (Fdelete_other_windows_internal, make_parent_window)
393 (make_window, Fsplit_window_internal, Fdelete_window_internal)
394 (Fset_window_configuration, save_window_save): Don't deal with
395 split status of windows.
396 (saved_window): Remove splits slot.
397 (Vwindow_splits): Rewrite doc-string.
398
97f18cc8
JD
3992011-11-11 Jan Djärv <jan.h.d@swipnet.se>
400
401 * xfns.c (unwind_create_frame):
402 * nsfns.m (unwind_create_frame):
403 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
404 Vframe_list (Bug#9999).
405
22a648b4
DA
4062011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
407
0b381c7e 408 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 409
659afede
KH
4102011-11-11 Kenichi Handa <handa@m17n.org>
411
412 * callproc.c (Fcall_process): Set the member dst_multibyte of
413 process_coding.
414
9ac0394b
KH
4152011-11-11 Johan Bockgård <bojohan@gnu.org>
416
417 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
418 avoid a crash (bug#9496).
419
2fbdc249
CY
4202011-11-09 Chong Yidong <cyd@gnu.org>
421
422 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
423 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
424
ac6b1f81
PE
4252011-11-08 Paul Eggert <eggert@cs.ucla.edu>
426
427 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
428
09db192c
PE
4292011-11-08 Paul Eggert <eggert@cs.ucla.edu>
430
431 Avoid some portability problems by eschewing 'extern inline' functions.
432 The trivial performance wins aren't worth the portability hassles; see
433 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
434 et seq.
435 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
436 (window_box_width, window_box_left, window_box_left_offset)
437 (window_box_right, window_box_right_offset): Undo previous change,
438 by removing the "extern"s.
439 * intervals.c (adjust_intervals_for_insertion)
440 (adjust_intervals_for_deletion): Undo previous change,
441 making these static again.
442 (offset_intervals, temp_set_point_both, temp_set_point)
443 (copy_intervals_to_string): No longer inline.
444 * xdisp.c (window_text_bottom_y, window_box_width)
445 (window_box_height, window_box_left_offset)
446 (window_box_right_offset, window_box_left, window_box_right)
447 (window_box): No longer inline.
448
105216ed
CY
4492011-11-08 Chong Yidong <cyd@gnu.org>
450
451 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
452 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
453 Signal an error if not a live window.
105216ed
CY
454 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
455 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
456
ae9e237f
JB
4572011-11-07 Juanma Barranquero <lekktu@gmail.com>
458
459 * lisp.h (syms_of_abbrev): Remove declaration.
460 Reported by CHENG Gao <chenggao@royau.me>.
461
c7aa8333
EZ
4622011-11-07 Eli Zaretskii <eliz@gnu.org>
463
464 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
465 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
466 of temacs in GUI mode.
467
be7f5545
MR
4682011-11-07 Martin Rudalics <rudalics@gmx.at>
469
470 * window.h: Declare delete_all_child_windows instead of
471 delete_all_subwindows.
472 * window.c (Fwindow_nest, Fset_window_nest)
473 (Fset_window_new_total, Fset_window_new_normal)
474 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
475 (delete_all_subwindows): Rename to delete_all_child_windows.
476 (Fdelete_other_windows_internal, Fset_window_configuration):
477 Call delete_all_child_windows instead of delete_all_subwindows.
478 * frame.c (delete_frame): Call delete_all_child_windows instead
479 of delete_all_subwindows.
480
ca78dc43
PE
4812011-11-07 Paul Eggert <eggert@cs.ucla.edu>
482
483 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
484 This is also needed for porting to any host where GC_MARK_STACK is
485 not GC_MAKE_GCPROS_NOOPS.
486 (which_symbols): Use it.
487
a0241d01
KH
4882011-11-07 Kenichi Handa <handa@m17n.org>
489
490 * coding.c (coding_set_destination): Check coding->src_pos only
491 when coding->src_object is a buffer (bug#9910).
492
493 * process.c (send_process): Set the member src_multibyte of coding
494 to 0 (bug#9911) when sending a unibyte text.
495
496 * callproc.c (Fcall_process): Set the member src_multibyte of
497 process_coding to 0 (bug#9912).
498
a64bfdfa 4992011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
500
501 * xmenu.c (cleanup_widget_value_tree): New function.
502 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
503 calling free_menubar_widget_value_tree directly (Bug#9830).
504
cb41b32a
PE
5052011-11-06 Paul Eggert <eggert@cs.ucla.edu>
506
507 Fix some portability problems with 'inline'.
508 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
509 (window_box_width, window_box_left, window_box_left_offset)
510 (window_box_right, window_box_right_offset): Declare extern.
511 Otherwise, these inline functions do not conform to C99 and
512 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
513 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
514 * intervals.c (adjust_intervals_for_insertion)
515 (adjust_intervals_for_deletion): Now extern, because otherwise the
516 extern inline functions 'offset_intervals' couldn't refer to it.
517 (static_offset_intervals): Remove.
518 (offset_intervals): Rewrite using the old contents of
519 static_offset_intervals. The old version didn't conform to C99
520 because an extern inline function contained a reference to an
521 identifier with static linkage.
522
b7041366
AS
5232011-11-06 Andreas Schwab <schwab@linux-m68k.org>
524
525 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
526 GC.
527
88a37c4d
EZ
5282011-11-06 Eli Zaretskii <eliz@gnu.org>
529
530 * xdisp.c (init_iterator, reseat_to_string): Don't set the
531 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
532 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
533 return Qleft_to_right.
534
49745b39
CY
5352011-11-06 Chong Yidong <cyd@gnu.org>
536
537 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
538 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
539 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
540 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
541 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
542 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
543 (Fwindow_vscroll): Doc fix.
544 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
545 argument, since it makes no sense to pass a live window and for
546 consistency with window-child.
547
1f05cd82
CS
5482011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
549
550 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
551 support MSVC.
552
22610910
JR
5532011-11-05 Jason Rumney <jasonr@gnu.org>
554
555 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
556 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
557 fonts (Bug#6029).
558 (add_font_entity_to_list): Fix logic errors in mixed boolean and
559 bitwise arithmetic preventing use of unicode-sip and non-truetype
560 opentype fonts.
561
a06776b2
EZ
5622011-11-05 Eli Zaretskii <eliz@gnu.org>
563
3ad924ba
EZ
564 * s/ms-w32.h (fstat, stat, utime): Move redirections to
565 "emacs"-only part.
566
a06776b2
EZ
567 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
568 initialization code to keep similarity to xfns.c after changes
569 from 2011-11-05.
570
c9e7db78
JD
5712011-11-05 Jan Djärv <jan.h.d@swipnet.se>
572
a97f8f3f
JD
573 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
574 (unwind_create_frame): New function (Bug#9943).
575 (Fx_create_frame): Restructure code to be more similar to the one in
576 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
577 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
578 Move terminal->reference_count++ just before making the frame official
579 (Bug#9943).
580
581 * nsterm.m (x_free_frame_resources): New function.
582 (x_destroy_window): Move code to x_free_frame_resources.
583
c9e7db78 584 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
585 (Fx_create_frame, x_create_tip_frame):
586 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
587 official. Move initialization of image_cache_refcount and
588 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
589
a6fc3b5c
EZ
5902011-11-05 Eli Zaretskii <eliz@gnu.org>
591
592 Support MSVC build with newer versions of Visual Studio.
593 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
594 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
595 nt/gmake.defs.
596
597 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
598 which are not supported by MSVC.
599 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
600 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
601 bitfields.
602 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
603 types in bitfields.
604 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
605
606 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
607
58179cce 6082011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
609
610 Support MSVC build with newer versions of Visual Studio.
611 * w32.c: Don't include w32api.h for MSVC.
612 (init_environment) [_MSC_VER]: Call sys_access, not _access.
613
614 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
615 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
616 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
617 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
618 e_* cousins.
619 (alloca) [_MSC_VER]: Define to _alloca.
620
621 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
622
623 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
624
a58c13ed
EZ
6252011-11-04 Eli Zaretskii <eliz@gnu.org>
626
627 * xdisp.c (note_mouse_highlight): If either of
628 previous/next-single-property-change returns nil, treat that as
629 the beginning or the end of the buffer. (Bug#9955)
630
fe0b6370
JD
6312011-11-04 Jan Djärv <jan.h.d@swipnet.se>
632
a58c13ed 633 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
634 label is not null (Bug#9951).
635 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
636 may be NULL.
637
89bd5ee1
EZ
6382011-11-04 Eli Zaretskii <eliz@gnu.org>
639
640 * window.c (Fwindow_body_size): Mention in the doc string that the
641 return value is in frame's canonical units. (Bug#9949)
642
84c3edb9
EZ
6432011-11-03 Eli Zaretskii <eliz@gnu.org>
644
4e2fb5c7
EZ
645 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
646
84c3edb9 647 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 648 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 649 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 650
bc17a887
EZ
6512011-11-01 Eli Zaretskii <eliz@gnu.org>
652
653 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
654 Don't stop backward scan on the continuation glyph, even though
655 its CHARPOS is positive.
6d5eb5b0
SM
656 (mouse_face_from_buffer_pos, note_mouse_highlight):
657 Rename cover_string to disp_string.
bc17a887 658
4ee88440
MR
6592011-11-01 Martin Rudalics <rudalics@gmx.at>
660
661 * window.c (temp_output_buffer_show): Don't use
662 Vtemp_buffer_show_specifiers.
663 (Vtemp_buffer_show_specifiers): Remove unused variable.
664
c2ff3c02
EZ
6652011-10-30 Eli Zaretskii <eliz@gnu.org>
666
667 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
668 past the beginning of the current glyph matrix.
669
58179cce 6702011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
671
672 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
673 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
674 HAVE_GTK3 (Bug#9869).
b77a6a7f 675
3b574623
JD
676 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
677 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
678
b77a6a7f
JD
679 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
680
681 * xterm.c: Declare x_handle_net_wm_state to return int.
682 (handle_one_xevent): Check if we are iconified but don't have
683 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
684 (get_current_wm_state): Return non-zero if not hidden,
685 check for _NET_WM_STATE_HIDDEN (Bug#9893).
686 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
687 (x_handle_net_wm_state): Return what get_current_wm_state returns.
688 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
689
196e41e4
PE
6902011-10-29 Paul Eggert <eggert@cs.ucla.edu>
691
692 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
693 so that this new function doesn't get optimized away by a
694 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
695
021f2e1a
AS
6962011-10-29 Andreas Schwab <schwab@linux-m68k.org>
697
698 * frame.h (MOUSE_HL_INFO): Remove excess parens.
699
8b058d44
EZ
7002011-10-29 Eli Zaretskii <eliz@gnu.org>
701
702 Fix the `xbytecode' command.
703 * .gdbinit (xprintbytestr): New command.
b50a28de 704 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
705 (xbytecode): Print the byte-code string as well.
706
4452fb80
EZ
7072011-10-29 Kim Storm <storm@cua.dk>
708
8b058d44
EZ
709 * alloc.c (which_symbols): New function.
710
21b72067
AS
7112011-10-29 Andreas Schwab <schwab@linux-m68k.org>
712
713 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
714 line. (Bug#9903)
715
83ed7b5c
GM
7162011-10-29 Glenn Morris <rgm@gnu.org>
717
718 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
719 Not clear what it was for, and it causes various bugs. (Bug#9839)
720
5a7a728b
EZ
7212011-10-28 Eli Zaretskii <eliz@gnu.org>
722
723 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
724 possible random value that matches one of those tested as
725 condition to clear the mouse face.
726
d3d0842f
CY
7272011-10-28 Chong Yidong <cyd@gnu.org>
728
729 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
730
31b39d13
DN
7312011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
732
733 * window.c (make_window): Initialize phys_cursor_on_p.
734
9aba6043
SM
7352011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
736
737 * lisp.h (struct Lisp_Symbol): Update comments.
738
c20992f4
JB
7392011-10-28 Juanma Barranquero <lekktu@gmail.com>
740
741 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
742
db4f02f2
EZ
7432011-10-28 Eli Zaretskii <eliz@gnu.org>
744
745 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
746 <oslsachem@gmail.com> for helping to debug this.
747
748 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
749 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
750 (g_b_init_get_glyph_outline_w): New static variables.
751 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
752 (GetGlyphOutlineW_Proc): New typedefs.
753 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
754 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
755 New functions.
756 (w32font_open_internal, compute_metrics):
757 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
758 instead of calling the "wide" APIs directly.
759
760 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
761
762 * w32.h (syms_of_w32font): Add prototype.
763
87e68db4
JB
7642011-10-27 Juanma Barranquero <lekktu@gmail.com>
765
766 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
767 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
768 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
769 (Fmove_to_window_line): Doc fix.
770
435c1d67
CY
7712011-10-27 Chong Yidong <cyd@gnu.org>
772
773 * process.c (make_process): Set gnutls_state to NULL.
774
775 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
776 non-NULL, regardless of GNUTLS_INITSTAGE.
777 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
778 an error. Set process slots as soon as we allocate them.
779
780 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
781
9c6c6f49
CY
7822011-10-27 Chong Yidong <cyd@gnu.org>
783
9aba6043
SM
784 * gnutls.c (emacs_gnutls_deinit): New function.
785 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
786 (Fgnutls_deinit, Fgnutls_boot): Use it.
787
788 * process.c (make_process): Initialize GnuTLS credentials to NULL.
789 (deactivate_process): Call emacs_gnutls_deinit.
790
657d08d3
JB
7912011-10-27 Juanma Barranquero <lekktu@gmail.com>
792
793 * image.c (x_create_x_image_and_pixmap):
794 * w32.c (sys_rename, w32_delayed_load):
795 * w32font.c (fill_in_logfont):
796 * w32reg.c (x_get_string_resource): Silence compiler warnings.
797
5430d399
JB
7982011-10-26 Juanma Barranquero <lekktu@gmail.com>
799
800 * w32fns.c (w32_default_color_map): New function,
801 extracted from Fw32_default_color_map.
a7ef684b 802 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 803
fe0055fa
PE
8042011-10-25 Paul Eggert <eggert@cs.ucla.edu>
805
806 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
807
e6346438
SM
8082011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
809
810 * keyboard.c (test_undefined): New function (bug#9751).
811 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
812
e112cc37
ET
8132011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
814
815 * sysdep.c (init_sys_modes): Fix the check for the controlling
816 terminal (Bug#6649).
817
7b5d6677
EZ
8182011-10-20 Eli Zaretskii <eliz@gnu.org>
819
820 * dispextern.h (struct bidi_it): New member next_en_type.
821
822 * bidi.c (bidi_line_init): Initialize the next_en_type member.
823 (bidi_resolve_explicit_1): When next_en_pos is valid for the
824 current character, check also for next_en_type being WEAK_EN.
825 (bidi_resolve_weak): Don't enter the expensive loop if the current
826 position is before next_en_pos. Record the bidi type of the first
827 non-ET, non-BN character we find, in addition to its position.
828 (bidi_level_of_next_char): Invalidate next_en_type when
829 next_en_pos is over-stepped.
830
7da0b018
PE
8312011-10-20 Paul Eggert <eggert@cs.ucla.edu>
832
833 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
834 * editfns.c: Rewrite current-time-zone so that it invokes
835 the equivalent of (format-time-string "%Z") to get the time zone name.
836 This fixes a bug when the time zone name contains characters that
837 need converting from the system time locale to Emacs internal format.
838 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
839 that patch fixed format-time-string to do the conversion, but
840 I forgot to fix current-time-zone.
841 (format_time_string): New function, containing most of
842 what Fformat_time_string used to contain.
843 (Fformat_time_string): Rewrite in terms of format_time_string.
844 This doesn't change this function's behavior.
845 (current-time-zone): Rewrite to use format_time_string.
846 This fixes the bug reported by Michael Schierl in
847 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
848 Jason Rumney's 2007-06-07 change worked around this bug, but
849 didn't fix it.
850 * systime.h (tzname, timezone): Remove no-longer-used declarations.
851
8547b010
EZ
8522011-10-19 Eli Zaretskii <eliz@gnu.org>
853
854 * xdisp.c (start_display): If the character at POS is displayed
855 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
856 (try_window_reusing_current_matrix): If a line ends in a display
857 vector or the next line starts in a display vector, continue
858 redrawing the window even though the character position of
859 start_row was reached.
8547b010
EZ
860 (Bug#9771, part 2)
861
4e948d15
CY
8622011-10-18 Chong Yidong <cyd@gnu.org>
863
864 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
865 with nobreak-char-display too.
866
4787455f
EZ
8672011-10-18 Eli Zaretskii <eliz@gnu.org>
868
869 Fix part 3 of bug#9771.
870 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
871 (bidi_resolve_neutral): Don't enter the expensive loop looking for
872 non-neutral characters if the current character is a paragraph
873 separator (a.k.a. Newline). This avoids running the same
874 expensive loop twice, once when we consume the preceding newline
875 and the other time when the line actually needs to be displayed.
876 Avoid the loop when we see neutrals on the base embedding level
877 following a character whose directionality is the same as the
878 paragraph's. This avoids running the expensive loop when a line
879 ends in a long sequence of neutrals, like control characters.
880 Add assertion against STRONG_AL type. Slightly rearrange code
881 that determines the type of a neutral given the first non-neutral
882 that follows it.
883 (bidi_level_of_next_char): Set next_en_pos to zero when
884 invalidating its info.
885
2c91f553
EZ
8862011-10-17 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (push_display_prop): Determine whether to record string
889 or buffer position by IT->string, not by IT->method. Allow
890 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
891 (move_it_vertically_backward): Don't look for character position
892 immediately after the newline when in a continuation line.
893 (Bug#9771, part 1)
2c91f553 894
c7b08b0d
MR
8952011-10-15 Martin Rudalics <rudalics@gmx.at>
896
897 * window.c (coordinates_in_window): Rewrite and delabelize
898 vertical border check. (Bug#5357) (Bug#9618)
899
6b02f655
SM
9002011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
901
902 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
903 errors in XSetWindowBorder (bug#9310).
904
81d40c92
DA
9052011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
906
907 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
908 avoid crash when xmalloc overrun checking is enabled.
909
d4172c3b
EZ
9102011-10-13 Eli Zaretskii <eliz@gnu.org>
911
912 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
913 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
914 cursor motion with <left> and <right> arrow keys.
915
916 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
917 some callers set that themselves.
918
b00eea75
EZ
9192011-10-12 Eli Zaretskii <eliz@gnu.org>
920
921 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
922 display string and the previous row comes from the same string and
923 is empty. (Bug#9739) (Bug#9738)
924
8fe012c4
SM
9252011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
926
927 * doc.c (get_doc_string): Encode file name (bug#9735).
928
0074aef2
EZ
9292011-10-12 Eli Zaretskii <eliz@gnu.org>
930
79beb178
EZ
931 * bidi.c (bidi_level_of_next_char):
932 * xdisp.c (get_visually_first_element): Remove old incorrect
933 comments regarding the Unicode Line Separator character.
934
0074aef2
EZ
935 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
936
6e4b3fbe
DA
9372011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
938
939 * alloc.c (Fgc_status): Do not access beyond zombies array
940 boundary if nzombies > MAX_ZOMBIES.
941 * alloc.c (dump_zombies): Add missing format specifier.
942
0324f3af
PE
9432011-10-12 Paul Eggert <eggert@cs.ucla.edu>
944
b5525cac
PE
945 * xdisp.c (set_cursor_from_row): Simplify conditionals,
946 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
947
0324f3af
PE
948 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
949 Some packages use them to denote characters with modifiers.
950
e9b5f888
AS
9512011-10-11 Andreas Schwab <schwab@linux-m68k.org>
952
953 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
954 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
955 matching a pp-number. Rename parameter var to var1.
956
127827c0
SM
9572011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
958
959 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
960
c8fd3bd0
GM
9612011-10-08 Glenn Morris <rgm@gnu.org>
962
963 * callint.c (Fcall_interactively): Give a more explicit error for the
964 'c' case with a non-character input. (Bug#8479)
965
352ec8ff
EZ
9662011-10-08 Eli Zaretskii <eliz@gnu.org>
967
03669ccb
EZ
968 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
969 lines.
7061c986
EZ
970 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
971 lines that are hscrolled on the left.
03669ccb 972
352ec8ff
EZ
973 * dispnew.c (buffer_posn_from_coords): Account for a possible
974 presence of header-line. (Bug#4426)
975
a66cfb1c
SM
9762011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
977
6b02f655
SM
978 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
979 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 980
7c5ee88e
PE
9812011-10-07 Paul Eggert <eggert@cs.ucla.edu>
982
983 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
984 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
985 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
986 this makes Emacs dump core during garbage collection on rare
987 occasions. sizeof is obviously inferior to offsetof here, so
988 stick with offsetof.
989 (GC_POINTER_ALIGNMENT): New macro.
990 (mark_memory): Omit 3rd (offset) arg; caller changed.
991 Don't assume EMACS_INT alignment is the same as pointer alignment.
992
df1bbe5b
SM
9932011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
994
995 * keyboard.c (read_key_sequence_remapped): New var.
996 (read_key_sequence): Compute remapping in the right buffer.
997 (command_loop_1): Use read_key_sequence's remapping directly.
998
51553db6
SM
9992011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1000
32c1fffd
SM
1001 * dired.c (file_name_completion): Don't expand file name.
1002 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1003 before checking file name handler.
1004
51553db6
SM
1005 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1006 they've been requested explicitly (bug#9591).
1007
b6bd1599 10082011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1009
1010 * keymap.c (Fsingle_key_description): Use make_specified_string
1011 instead of build_string to build string from push_key_description.
1012 (Bug#5193)
1013
f701dc2a
PE
10142011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1015
4222c55d
PE
1016 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1017 This fixes a Y2038 bug on 64-bit hosts.
1018 * buffer.c (reset_buffer):
1019 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1020 (Fclear_buffer_auto_save_failure):
1021 Use 0, not -1, to represent an unset failure time, since time_t
1022 might not be signed.
1023
f701dc2a
PE
1024 Remove dependency on glibc malloc internals.
1025 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1026 Move back here from lisp.h, but with their new implementations.
1027 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1028 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1029 * charset.c (charset_table_init): New static var.
1030 (syms_of_charset): Use it instead of xmalloc. This removes a
1031 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1032 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1033 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1034 Move back to alloc.c.
1035 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1036 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1037
9ceebf39
JD
10382011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1039
1040 * nsterm.m (windowDidResize): Call x_set_window_size only when
1041 ns_in_resize is true. Otherwise set pixelwidth/height and
1042 call change_frame_size (Bug#9628).
1043
cb993c58
PE
10442011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1045
3930c88b
PE
1046 Port --enable-checking=all to Fedora 14 x86-64.
1047 * charset.c (syms_of_charset): Also account for glibc malloc's
1048 internal overhead when calculating the initial malloc maximum.
1049
cb993c58
PE
1050 Port --enable-checking=all to Fedora 14 x86.
1051 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1052 Move to lisp.h.
1053 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1054 (overrun_check_realloc, overrun_check_free):
1055 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1056 That way, xmalloc returns a properly-aligned pointer even if
1057 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1058 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1059 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1060 into account when calculating the initial malloc maximum.
1061 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1062 Move here from alloc.c, so that charset.c can use it too.
1063 Properly align; the old code wasn't right for common 32-bit hosts
1064 when configured with --enable-checking=all.
1065 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1066 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1067
31bed486
EZ
10682011-09-29 Eli Zaretskii <eliz@gnu.org>
1069
04c70788 1070 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1071 use EDOM.
1072
fbcaa2f3
EZ
10732011-09-28 Eli Zaretskii <eliz@gnu.org>
1074
1075 * xdisp.c (compute_display_string_end): If there's no display
1076 string at CHARPOS, return -1.
1077
1078 * bidi.c (bidi_fetch_char): When compute_display_string_end
1079 returns a negative value, treat the character as a normal
1080 character not covered by a display string. (Bug#9624)
1081
a239d4e9
JB
10822011-09-28 Juanma Barranquero <lekktu@gmail.com>
1083
1084 * lread.c (Fread_from_string): Fix typo in docstring.
1085
88652fd5
EZ
10862011-09-27 Eli Zaretskii <eliz@gnu.org>
1087
1088 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1089 newline, reseat the iterator instead of bidi-iterating there one
1090 character at a time. (Bug#9610)
32c1fffd
SM
1091 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1092 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1093
ed497dd4
AS
10942011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1095
1096 * lread.c (readevalloop): Use correct code for NBSP.
1097 (read1): Likewise. (Bug#9608)
1098
b2bf61aa
MA
10992011-09-25 Michael Albinus <michael.albinus@gmx.de>
1100
1101 * dbusbind.c (Fdbus_register_signal): When service is not
1102 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1103
32bbb17c
GM
11042011-09-25 Glenn Morris <rgm@gnu.org>
1105
1106 * buffer.c (truncate-lines): Doc fix.
1107
94e0933e
CY
11082011-09-24 Chong Yidong <cyd@stupidchicken.com>
1109
1110 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1111 (Fset_window_next_buffers): Doc fix.
1112
cddde921
GM
11132011-09-24 Glenn Morris <rgm@gnu.org>
1114
1115 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1116
1260aef1
PE
11172011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1118
25b4bfa0
PE
1119 Fix minor problems found by static checking.
1120 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1121 * indent.c (Fvertical_motion): Fix == vs = typo.
1122
e3cbd34b
EZ
11232011-09-24 Eli Zaretskii <eliz@gnu.org>
1124
a66cfb1c
SM
1125 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1126 Default value is now t. Doc fix.
6bf7006f 1127
e3cbd34b 1128 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1129 logic when moving up, not only when moving down. Fix the
e3cbd34b 1130 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1131 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1132
1133 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1134 CHARPOS is covered by a display string which includes newlines.
1135 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1136 is covered by a display string with embedded newlines.
1137
a3de0cbd
MA
11382011-09-24 Michael Albinus <michael.albinus@gmx.de>
1139
1140 * dbusbind.c (Fdbus_register_signal): Add match rule to
1141 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1142 (Fdbus_register_method, Vdbus_registered_objects_table):
1143 Fix docstring.
a3de0cbd 1144
b260039d
JM
11452011-09-24 Jim Meyering <meyering@redhat.com>
1146
32c1fffd 1147 do not ignore write error for any output size
b260039d
JM
1148 The previous change was incomplete.
1149 While it makes emacs --batch detect the vast majority of stdout
1150 write failures, errors were still ignored whenever the output size is
1151 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1152 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1153 && echo FAIL: ignored write error
1154 FAIL: ignored write error
1155 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1156 && echo FAIL: ignored write error
1157 FAIL: ignored write error
1158 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1159
8eca8a7c
AS
11602011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1161
1162 * emacs.c (Fkill_emacs): In noninteractive mode exit
1163 non-successfully if a write error occurred on stdout. (Bug#9574)
1164
3341db62
EZ
11652011-09-21 Eli Zaretskii <eliz@gnu.org>
1166
1167 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1168 the xassert test.
1169
1170 * dispextern.h (struct it): Update the comment documenting what
1171 can it->OBJECT be.
1172
8c203dbf
EZ
11732011-09-20 Eli Zaretskii <eliz@gnu.org>
1174
1175 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1176 a display string, extend search for cursor position to end of row.
1177 (find_row_edges): If the row ends in a newline from a display
1178 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1179 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1180 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1181 non-empty line. Fixes confusing cursor motion with arrow keys at
1182 the beginning of a line that starts with whitespace.
8c203dbf 1183
a4824228
LMI
11842011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1185
1186 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1187 (bug#9493).
1188
33ed493b
CY
11892011-09-18 Chong Yidong <cyd@stupidchicken.com>
1190
1191 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1192 boolean (Bug#9154).
1193
56cd55c8
EZ
11942011-09-18 Eli Zaretskii <eliz@gnu.org>
1195
1196 * xdisp.c (display_line): Record maximum and minimum buffer
1197 positions even if no glyphs were produced (e.g., by a zero-width
1198 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1199 buffer positions that will be removed from the glyph row because
1200 they don't fit.
c02dcedf
EZ
1201 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1202 column is beyond frame width: don't subtract 1 "pixel" when
1203 computing width of the stretch.
3e62b7e0
EZ
1204 (reseat_at_next_visible_line_start): Undo the change made on
1205 2011-09-17 that saved paragraph information and restored it after
1206 the call to `reseat'. (Bug#9545)
56cd55c8 1207
5ed99d36 12082011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1209
1210 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1211 and turn window cursor on if cleared (Bug#9415).
1212
5ed99d36 12132011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1214
1215 * search.c (boyer_moore): Take unibyte characters from pattern
1216 literally. (Bug#9458)
1217
9bade7b2
EZ
12182011-09-18 Eli Zaretskii <eliz@gnu.org>
1219
1220 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1221
e5e9d610
PE
12222011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1223
87e4427a
PE
1224 Fix minor problem found by static checking.
1225 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1226 initialized, to pacify gcc -Wuninitialized.
1227
e5e9d610
PE
1228 * fileio.c: Report proper errno when syscall falls.
1229 (Finsert_file_contents): Save and restore errno,
1230 so that report_file_error outputs the correct diagnostic.
1231 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1232
a1674f0b
EZ
12332011-09-18 Eli Zaretskii <eliz@gnu.org>
1234
1235 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1236
fbfb6dd4
EZ
12372011-09-17 Eli Zaretskii <eliz@gnu.org>
1238
1239 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1240 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1241
bb187662
EZ
12422011-09-17 Eli Zaretskii <eliz@gnu.org>
1243
1137e8b8 1244 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1245 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1246
1247 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1248 (bidi_find_paragraph_start): Search back for paragraph beginning
1249 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1250 (bidi_move_to_visually_next): Only trigger paragraph-related
1251 computations when the last character is a newline or at EOB, not
1252 just any NEUTRAL_B. (Bug#9470)
1253
bb187662
EZ
1254 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1255 truncated lines if point is covered by a display string. (Bug#9524)
1256
2e621251
PE
12572011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1260 (cons_to_x_long): New function.
1261 (lisp_data_to_selection_data): Use it. Correct the test for
1262 short-versus-long data; it was negated. Break out of vector
1263 loop, for efficiency, when a long datum is discovered.
1264
91a15bc6
SM
12652011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1266
1267 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1268
b41c3a35
EZ
12692011-09-16 Eli Zaretskii <eliz@gnu.org>
1270
1271 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1272 GCC PR/17406) by declaring this function with external scope.
1273
7812ba2d
PE
12742011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1275
1276 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1277 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1278
cf7edc2a
AS
12792011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1280
1281 * editfns.c (Fformat): Correctly handle text properties on "%%".
1282
bd01620e
EZ
12832011-09-15 Eli Zaretskii <eliz@gnu.org>
1284
1285 * xterm.c (x_draw_composite_glyph_string_foreground):
1286 * w32term.c (x_draw_composite_glyph_string_foreground):
1287 * term.c (encode_terminal_code):
1288 * composite.c (composition_update_it, get_composition_id):
1289 * xdisp.c (get_next_display_element)
1290 (fill_composite_glyph_string): Add comments about special meaning
1291 of TAB characters in a composition.
1292
a02719a3
PE
12932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1296 This occurs when processing a multibyte format.
1297 Problem reported by Wolfgang Jenker.
a02719a3 1298
72589a3c
JB
12992011-09-15 Johan Bockgård <bojohan@gnu.org>
1300
1301 * xdisp.c (try_cursor_movement): Only check for exact match if
1302 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1303
1c14176c
PE
13042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 Remove unused external symbols.
1307 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1308 * xdisp.c (calc_pixel_width_or_height): Now static.
1309 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1310 * indent.c (check_display_width):
1311 * w32term.c: Fix comment to match code.
1312 * xterm.c, xterm.h (x_catching_errors): Remove.
1313
d2eea5b5
PE
13142011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * xselect.c: Use signed conversions more consistently (Bug#9498).
1317 (selection_data_to_lisp_data): Assume incoming selection data are
1318 signed integers, not unsigned. This is to be consistent with
1319 outgoing selection data, which was modified to use signed integers
1320 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1321 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1322 expects long, not unsigned long.
1323
46888499
EZ
13242011-09-14 Eli Zaretskii <eliz@gnu.org>
1325
1326 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1327 computation of loop end. Reported by Johan Bockgård
1328 <bojohan@gnu.org>.
1329
ef8ef9fb
CY
13302011-09-13 Chong Yidong <cyd@stupidchicken.com>
1331
1332 * frame.c (Fother_visible_frames_p): Function deleted.
1333
fa819fed
EZ
13342011-09-12 Eli Zaretskii <eliz@gnu.org>
1335
1336 * indent.c (compute_motion): Process display vector front to back
1337 rather than the other way around. (Bug#2496)
1338
2ba8e008
SM
13392011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1340
1341 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1342
20f53c69
CY
13432011-09-11 Chong Yidong <cyd@stupidchicken.com>
1344
1345 * minibuf.c (Fread_from_minibuffer): Doc fix.
1346
d562d7a4
EZ
13472011-09-11 Eli Zaretskii <eliz@gnu.org>
1348
1349 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1350 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1351
1c4d7f3d
LMI
13522011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1353
1354 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1355 value for non-existent files.
1356
b885bf36
EZ
13572011-09-11 Eli Zaretskii <eliz@gnu.org>
1358
1359 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1360 set its "size" to -1. This will set the modtime_size field of
1361 the corresponding buffer to -1, which is what
1362 verify-visited-file-modtime expects for files that do not exist.
1363 (Bug#9139)
1364
6612f0bf
PE
13652011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1366
1367 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1368 here ...
1369 * lisp.h: ... from here. push_key_description is no longer
1370 defined in keyboard.c, so its declaration should not be in
1371 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1372 logically belongs with push_key_description.
1373
dfb3f755
PE
13742011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 * buffer.h: Include <sys/types.h> instead of <time.h>.
1377 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1378 Problem reported by Herbert J. Skuhra.
1379
3134906c
LMI
13802011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1381
1382 * xml.c (parse_region): Make the parsing work for
1383 non-comment-starting XML files again (bug#9144).
1384
8d903f4e
AS
13852011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1386
1387 * image.c (gif_load): Fix calculation of bottom and right corner.
1388 (Bug#9468)
1389
80ad64f4
EZ
13902011-09-10 Eli Zaretskii <eliz@gnu.org>
1391
1392 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1393 redisplay in small windows.
1394
208a048d
EZ
13952011-09-09 Eli Zaretskii <eliz@gnu.org>
1396
1397 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1398
9b1c252e
MR
13992011-09-08 Martin Rudalics <rudalics@gmx.at>
1400
1401 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1402 Operate on live windows only.
1403
2949f33b
JB
14042011-09-08 Juanma Barranquero <lekktu@gmail.com>
1405
1406 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1407
e08dcafd
EZ
14082011-09-07 Eli Zaretskii <eliz@gnu.org>
1409
1410 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1411 only under bidi iteration.
1412
115b96bd
JD
14132011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1414
1415 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1416
c8199d0f
PE
14172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1418
1419 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1420 Without this fix, the command to link temacs failed due to an
1421 undefined symbol __builtin_isnan. This is because
1422 /usr/include/iso/math_c99.h #defines isnan(x) to
1423 __builtin_isnan(x), but the bundled gcc, which identifies itself
1424 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1425 a __builtin_isnan.
1426 * floatfns.c (isnan): #undef, and then #define to a clone of
1427 what's in data.c.
1428 (Fisnan): Always define, since it's always available now.
1429 (syms_of_floatfns): Always define isnan at the Lisp level.
1430
e39b275c 14312011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1432
1433 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1434
b2db44d9 14352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1436
f4af5137 1437 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1438 The previous code assumed that file offsets (off_t values) fit in
1439 EMACS_INT variables, which is not true on typical 32-bit hosts.
1440 The code messed up by falsely reporting buffer overflow in cases
1441 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1442 when "big" contains more than 2**29 bytes, even though this
1443 inserts just one byte and does not overflow the buffer.
1444 (Finsert_file_contents): Store file offsets as off_t
1445 values, not as EMACS_INT values. Check for overflow when
1446 converting between EMACS_INT and off_t. When checking for
1447 buffer overflow or for overlap, take the offsets into account.
1448 Don't use EMACS_INT for small values where int suffices.
1449 When checking for overlap, fix a typo: ZV was used where
1450 ZV_BYTE was intended.
1451 (Fwrite_region): Don't assume off_t fits into 'long'.
1452 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1453
ecfc0a49
MA
14542011-09-05 Michael Albinus <michael.albinus@gmx.de>
1455
1456 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1457
6511acf2 14582011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1459
0999621a 1460 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1461
1462 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1463 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1464 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1465 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1466 (modify_event_symbol): Do not assume that the length of
1467 name_alist_or_stem is safe to alloca and fits in int.
1468 (Fexecute_extended_command): Likewise for function name and binding.
1469 (Frecursion_depth): Wrap around reliably on integer overflow.
1470 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1471 since some callers pass EMACS_INT values.
1472 (Fsingle_key_description): Don't crash if symbol name contains more
1473 than MAX_ALLOCA bytes.
1474 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1475 (get_minibuffer): Arg is now EMACS_INT, not int.
1476 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1477 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1478 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1479
2be7d702
PE
1480 * dbusbind.c (signature_cat): New function.
1481 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1482 Do not overrun buffer; instead, report string overflow.
1483
9d1df220
PE
1484 * dispnew.c (add_window_display_history): Don't overrun buffer.
1485 Truncate instead; this is OK since it's just a log.
1486
33ef5c64
PE
1487 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1488 even if the time zone offset is outlandishly large.
1489 Don't mishandle offset == INT_MIN.
1490
66c6fdd5
PE
1491 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1492 when creating daemon; the previous buffer-overflow check was incorrect.
1493
d749b01b
PE
1494 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1495 which has the guts of the old verror function.
1496
b5cd1905
PE
1497 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1498 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1499
6e1a67fb
PE
1500 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1501 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1502 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1503 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1504 length of string rather than counting it via multiple sprintfs;
1505 that's simpler and more reliable.
c21721cc
PE
1506 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1507 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1508 sprintf, in case result does not fit in int.
1509
c57b67fc
PE
1510 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1511 (fontset_from_font): Print it.
1512
8a401434
PE
1513 * frame.c (tty_frame_count): Now printmax_t, not int.
1514 (make_terminal_frame, set_term_frame_name): Print it.
1515 (x_report_frame_params): In X, window IDs are unsigned long,
1516 not signed long, so print them as unsigned.
1517 (validate_x_resource_name): Check for implausibly long names,
1518 and don't assume name length fits in 'int'.
1519 (x_get_resource_string): Don't blindly alloca invocation name;
1520 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1521 not fit in int.
1522
6e1a67fb
PE
1523 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1524 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1525 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1526
0df02bf3
PE
1527 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1528 Use esprintf, not sprintf, in case result does not fit in int.
1529
48e30793
PE
1530 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1531 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1532 it as a large positive number.
1533 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1534 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1535
a66ff6d8
PE
1536 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1537 in case result does not fit in int.
1538
aca216ff
PE
1539 * print.c (float_to_string): Detect width overflow more reliably.
1540 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1541 buffer overrun. Don't assume list length fits in 'int'. Treat
1542 print length of 0 as 0, not as infinity; to be consistent with other
1543 uses of print length in this function. Don't overflow print length
1544 index. Don't assume hash table size fits in 'long', or that
1545 vectorlike size fits in 'unsigned long'.
1546
31c286f7
PE
1547 * process.c (make_process): Use printmax_t, not int, to format
1548 process-name gensyms.
1549
55e5faa1
PE
1550 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1551
80f2e268
PE
1552 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1553 to avoid potential buffer overrun.
1554
670741ab
PE
1555 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1556 if X resource line is longer than 512 bytes.
1557
b7163a50
PE
1558 * xfns.c (x_window): Make sprintf buffer a bit bigger
1559 to avoid potential buffer overrun.
1560
ae58ff1f
PE
1561 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1562
c43c8a6a
PE
1563 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1564
3f8236f4
PE
15652011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1566
53e9fe90 1567 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1568 Without these, Emacs silently mishandles large integers sometimes.
1569 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1570 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1571
6511acf2
PE
1572 * xdisp.c (try_window_id): Check Emacs fixnum range before
1573 converting to 'int'.
806add1d 1574
6511acf2 1575 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1576 Check that an Emacs fixnum is in range before assigning it to 'int'.
1577 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1578 values converted from Emacs fixnums.
1579 (Frecenter): Don't wrap around a line count if it is out of 'int'
1580 range; instead, treat it as an extreme value.
1581 (Fset_window_configuration, compare_window_configurations):
1582 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1583
6511acf2
PE
1584 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1585 that can exceed INT_MAX. Check that EMACS_INT value is in range
1586 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1587 (match_limit): Don't assume that a fixnum can fit in 'int'.
1588
6511acf2 1589 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1590 exceed INT_MAX.
1591
6511acf2 1592 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1593 (Fvertical_motion): Don't wrap around LINES values that don't fit
1594 in 'int'. Instead, treat them as extreme values. This is good
1595 enough for windows, which can't have more than INT_MAX lines anyway.
1596
fcb901a7
LMI
15972011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1598
0f2f6b6d
LMI
1599 * Require libxml/parser.h to avoid compilation warning.
1600
fcb901a7
LMI
1601 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1602
1603 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1604 since this reportedly can destroy thread storage.
1605
6e20a0d4
CY
16062011-08-30 Chong Yidong <cyd@stupidchicken.com>
1607
1608 * syntax.c (find_defun_start): Update all cache variables if
1609 exiting early (Bug#9401).
1610
148ae00e
EZ
16112011-08-30 Eli Zaretskii <eliz@gnu.org>
1612
f6cfbd8f
EZ
1613 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1614
148ae00e
EZ
1615 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1616 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1617 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1618
1619 * term.c (tty_append_glyph): New function.
1620 (produce_stretch_glyph): Static function and its prototype deleted.
1621
a66cfb1c
SM
1622 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1623 Add prototypes.
148ae00e 1624
c4a07a4c
PE
16252011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1628 when checking :margin (Bug#9390).
1629 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1630 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1631 so that the name doesn't mislead. All uses changed.
1632
6bc8cd65
JB
16332011-08-28 Johan Bockgård <bojohan@gnu.org>
1634
1635 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1636 set_tty_hooks.
1637
dca4927e
EZ
16382011-08-27 Eli Zaretskii <eliz@gnu.org>
1639
1640 * xdisp.c (move_it_to): Don't bail out early when reaching
1641 position beyond to_charpos, if we are scanning backwards.
1642 (move_it_vertically_backward): When DY == 0, make sure we get to
1643 the first character in the line after the newline.
1644
f2cad773
PE
16452011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1646
1647 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1648 (ccl_driver): Do not generate an out-of-range pointer.
1649 (Fccl_execute_on_string): Remove unnecessary check for
1650 integer overflow, noted by Stefan Monnier in
1651 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1652 Remove a FIXME that didn't need fixing.
1653 Simplify the newly-introduced buffer reallocation code.
1654
0cae2cdb
JB
16552011-08-27 Juanma Barranquero <lekktu@gmail.com>
1656
1657 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1658
5fc295a4 16592011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1660
70c60eb2 1661 Integer and memory overflow issues (Bug#9196).
726e0ab1 1662
d31850da
PE
1663 * doc.c (get_doc_string): Rework so that
1664 get_doc_string_buffer_size is the actual buffer size, rather than
1665 being 1 less than the actual buffer size; this makes xpalloc more
1666 convenient.
1667
a69fbedb
PE
1668 * image.c (x_allocate_bitmap_record, cache_image):
1669 * xselect.c (Fx_register_dnd_atom):
1670 Simplify previous changes by using xpalloc.
1671
fe5c5d37
PE
1672 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1673 since either will do and ptrdiff_t is convenient with xpalloc.
1674
0065d054
PE
1675 * charset.c (charset_table_size)
1676 (struct charset_sort_data.priority): Now ptrdiff_t.
1677 (charset_compare): Don't overflow if priorities differ greatly.
1678 (Fsort_charsets): Don't assume list length fits in int.
1679 Check for size-calculation overflow when allocating sort data.
1680 (syms_of_charset): Allocate an initial charset table that is
1681 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1682
1683 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1684
1685 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1686 The actual value is always <= INT_MAX, and leaving it unsigned made
1687 overflow checking harder.
1688
1689 * dispextern.h (struct glyph_matrix.rows_allocated)
1690 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1691 with xpalloc. The values are still always <= INT_MAX.
1692
1693 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1694
1695 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1696 (SAFE_NALLOCA): New macro.
1697
1698 * region-cache.c (struct boundary.pos, find_cache_boundary)
1699 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1700 (set_cache_region, invalidate_region_cache)
1701 (revalidate_region_cache, know_region_cache, region_cache_forward)
1702 (region_cache_backward, pp_cache):
1703 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1704 so that ptrdiff_t * can be passed to xpalloc.
1705 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1706 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1707 (pp_cache): Don't assume cache_len fits in int.
1708 * region-cache.h: Adjust extern decls to match.
1709
1710 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1711 EMACS_INT, since either will do, for xpalloc.
1712
1713 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1714 (xnmalloc, xnrealloc, xpalloc): New functions.
1715
726e0ab1
PE
1716 * bidi.c (bidi_shelve_header_size): New constant.
1717 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1718 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1719
51f30bc5 1720 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1721 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1722 (overlay_strings):
1723 Don't update size of array until after memory allocation succeeds,
1724 because xmalloc/xrealloc may not return.
0065d054
PE
1725 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1726 now that we have proper integer overflow checking.
1727 (record_overlay_string, overlay_strings): Catch overflows when
1728 calculating size of overlay_str_buf.
726e0ab1 1729
0065d054
PE
1730 * callproc.c (Fcall_process): Check for size overflow when
1731 calculating size of args2.
1732 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1733 Normally we prefer signed values, but sticking with ptrdiff_t would
1734 require adding more-complicated checks.
726e0ab1
PE
1735
1736 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1737 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1738 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1739 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1740
1741 * character.c (Fstring): Check for size-calculation overflow.
1742
1743 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1744 unnecessary integer overflow. Check for size overflow.
1745 (encode_coding_object): Don't update size until xmalloc succeeds.
1746
1747 * composite.c (get_composition_id): Check for overflow in glyph
1748 length calculations.
1749
1750 Integer and memory overflow fixes for display code.
1751 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1752 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1753 (scrolling_window): Check for overflow in size calculations.
1754 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1755 Don't assume glyph table len fits in int.
1756 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1757 (row_table_size): Now ptrdiff_t, not int.
1758 (scrolling_window): Avoid overflow in size calculations.
1759 Don't update size until allocation succeeds.
1760 * fns.c (concat): Check for overflow in size calculations.
1761 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1762 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1763 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1764
1765 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1766 (get_doc_string): Check for size calculation overflow.
1767 Don't update size until allocation succeeds.
1768 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1769 EMACS_INT, where ptrdiff_t will do.
1770 (Fsubstitute_command_keys): Check for string overflow.
1771
1772 * editfns.c (set_time_zone_rule): Don't assume environment length
1773 fits in int.
1774 (message_length): Now ptrdiff_t, not int.
1775 (Fmessage_box): Don't update size until allocation succeeds.
1776 Don't assume message length fits in int.
1777 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1778
0065d054
PE
1779 * emacs.c (main): Do not reallocate argv, since there is a null at
1780 the end that can be overwritten, and this way there's no need to
1781 worry about size-calculation overflow.
1782 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1783
1784 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1785 alloc succeeds.
1786 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1787
1788 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1789 (x_set_scroll_bar_width, x_figure_window_size):
1790 Check for integer overflow.
1791 (x_set_alpha): Do not assume XINT fits in int.
1792
1793 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1794 This is for the members text_lines, text_cols, total_lines, total_cols,
1795 where the system imposes an 'int' limit.
1796
1797 * fringe.c (Fdefine_fringe_bitmap):
1798 Don't update size until alloc works.
1799
1800 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1801 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1802
1803 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1804 Check for size-calculation overflow.
1805 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1806 do, as we prefer signed integers.
1807 (id_to_widget.max_size, id_to_widget.used)
1808 (xg_store_widget_in_map, xg_remove_widget_from_map)
1809 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1810 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1811 Use and return ptrdiff_t, not int.
1812 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1813 * gtkutil.h: Change prototypes to match the above.
1814
1815 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1816 are duplicate now that they've been promoted to lisp.h.
1817 (x_allocate_bitmap_record, x_alloc_image_color)
1818 (make_image_cache, cache_image, xpm_load):
1819 Don't update size until alloc is done.
1820 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1821 (x_detect_edges):
3256efce 1822 Check for size calculation overflow.
726e0ab1
PE
1823 (ct_colors_allocated_max): New constant.
1824 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1825 overflow.
3256efce 1826
726e0ab1
PE
1827 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1828 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1829 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1830 Use ptrdiff_t, not int, to count maps.
1831 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1832 calculations. Don't update size until allocation succeeds.
1833 Redo calculations to avoid overflow.
726e0ab1
PE
1834 * keyboard.h: Change prototypes to match the above.
1835
1836 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1837 to count maps.
1838 (current_minor_maps): Check for size calculation overflow.
1839 * keymap.h: Change prototypes to match the above.
1840
1841 * lread.c (read1, init_obarray): Don't update size until alloc done.
1842
1843 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1844 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1845
726e0ab1
PE
1846 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1847 Now ptrdiff_t, not int.
1848 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1849 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1850
1851 * process.c (Fnetwork_interface_list): Check for overflow
1852 in size calculation.
1853
1854 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1855
1856 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1857 overflow. Don't bother calling xmalloc when xrealloc will do.
1858
1859 * search.c (Freplace_match): Check for size calculation overflow.
1860 (Fset_match_data): Don't assume list lengths fit in 'int'.
1861
1862 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1863 for command line length. Do not attempt to address one before the
1864 beginning of an array, as that's not portable.
1865
1866 * term.c (max_frame_lines): Remove; unused.
1867 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1868 not int.
1869 (encode_terminal_code, calculate_costs): Check for size
1870 calculation overflow.
1871 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1872 table lengths and related sizes. Don't update size until alloc
1873 done. Redo calculations to avoid overflow.
1874 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1875
1876 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1877 subtracting pointers.
1878 (gobble_line): Check for overflow more carefully. Don't update size
1879 until alloc done.
1880
1881 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1882 Don't update size until alloc done.
1883 Redo size calculations to avoid overflow.
1884 Check for size calculation overflow.
0065d054 1885 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1886
1887 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1888 Use ptrdiff_t, not int, for sizes.
1889 (store_mode_line_noprop_char): Don't update size until alloc done.
1890
0065d054
PE
1891 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1892 Use ptrdiff_t, not int, for sizes.
1893 (Finternal_make_lisp_face, cache_face):
1894 Check for size calculation overflow.
1895 (cache_face): Treat size calculation overflows as if they were
1896 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1897
1898 * xfns.c (x_encode_text, x_set_name_internal)
1899 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1900 sizes, since they can exceed INT_MAX in size. Check for size
1901 calculation overflow.
1902
0065d054
PE
1903 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1904 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1905 Don't update size until alloc done.
1906
0065d054 1907 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1908 as sprintf is limited to int lengths.
1d526e2f 1909
252c5ee1
PE
1910 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1911 (X_LONG_MIN): New macros.
864d7ce7
PE
1912 Use them to make the following changes clearer.
1913 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1914 This change doesn't affect the value now, but it may help remind
1915 future maintainers not to raise the value too much later.
1916 (SELECTION_QUANTUM): Remove, replacing with ...
1917 (selection_quantum): ... new function, which avoids overflow.
1918 All uses changed.
1919 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1920 assumption that selection length fits in 'int'.
1921 (x_reply_selection_request, x_handle_selection_request)
1922 (x_get_window_property, receive_incremental_selection)
1923 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1924 (lisp_data_to_selection_data, clean_local_selection_data):
1925 Use ptrdiff_t, not int, to record length of selection.
1926 (x_reply_selection_request, x_get_window_property)
1927 (receive_incremental_selection, x_property_data_to_lisp):
1928 Redo calculations to avoid overflow.
1929 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1930 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1931 something.
1932 (x_get_window_property, receive_incremental_selection)
1933 (lisp_data_to_selection_data, x_property_data_to_lisp):
1934 Check for size-calculation overflow.
1935 (x_get_window_property, receive_incremental_selection)
1936 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1937 Don't store size until memory allocation succeeds.
1938 (x_get_window_property): Plug memory leak on memory exhaustion.
1939 Don't double-block input; malloc is safe here. Don't assume 2**34
1940 - 4 fits in unsigned long. Add an xassert to check
1941 XGetWindowProperty overflow. Be more careful about overflow
1942 calculations, and distinguish size from memory overflow better.
1943 (receive_incremental_selection): When tracing, don't assume
1944 unsigned int is less than INT_MAX.
1945 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1946 harmful) conversions of unsigned short to int.
1947 (lisp_data_to_selection_data): Don't assume that integers
1948 in the range -65535 through -1 fit in an X unsigned short.
1949 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1950 result parameters unless successful. Rely on cons_to_unsigned
1951 to report problems with elements; the old code wasn't right anyway.
1952 (x_check_property_data): Check for int overflow; we cannot use
1953 a wider type due to X limits.
1954 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1955
726e0ab1 1956 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1957
0065d054
PE
1958 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1959 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1960 (x_color_cells): Don't store size until memory allocation succeeds.
1961 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1962 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1963 (x_term_init): Don't assume length fits in int (sprintf is limited
1964 to int size).
bc18e09d 1965
ebfa62c0
PE
1966 Use ptrdiff_t for composition IDs.
1967 * character.c (lisp_string_width):
1968 * composite.c (composition_table_size, n_compositions)
1969 (get_composition_id, composition_gstring_from_id):
1970 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1971 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1972 * window.c (Frecenter):
1973 Use ptrdiff_t, not int, for composition IDs.
1974 * composite.c (get_composition_id): Check for integer overflow.
1975 * composite.h: Adjust prototypes to match the above changes.
1976
d3411f89
PE
1977 Use ptrdiff_t for hash table indexes.
1978 * category.c (hash_get_category_set):
1979 * ccl.c (ccl_driver):
1980 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1981 * coding.c (coding_system_charset_list, detect_coding_system):
1982 * coding.h (struct coding_system.id):
1983 * composite.c (get_composition_id, gstring_lookup_cache):
1984 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1985 * image.c (xpm_get_color_table_h):
1986 * lisp.h (hash_lookup, hash_put):
1987 * minibuf.c (Ftest_completion):
1988 Use ptrdiff_t for hash table indexes, not int (which is too
1989 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1990 32-bit --with-wide-int hosts).
1991
e097a6fa
PE
1992 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1993 Add a FIXME comment about memory leaks.
1994 (syms_of_charset): Don't assume xmalloc returns.
1995
5637687f
PE
1996 Don't assume that stated character widths fit in int.
1997 * character.c (Fchar_width, c_string_width, lisp_string_width):
1998 * character.h (CHAR_WIDTH):
1999 * indent.c (MULTIBYTE_BYTES_WIDTH):
2000 Use sanitize_char_width to avoid undefined and/or bad behavior
2001 with outlandish widths.
a66cfb1c 2002 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2003 now that we have two such functions. All uses changed.
2004 (sanitize_char_width): New inline function.
2005
a2271ba2
PE
2006 Don't assume that tab-width fits in int.
2007 * character.h (sanitize_width): New inline function.
2008 (SANE_TAB_WIDTH): New macro.
2009 (ASCII_CHAR_WIDTH): Use it.
2010 * indent.c (sane_tab_width): Remove. All uses replaced by
2011 SANE_TAB_WIDTH (current_buffer).
2012 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2013
18c52557
PE
2014 * fileio.c: Integer overflow issues with file modes.
2015 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2016
caeeedc1
PE
2017 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2018 Remove unreachable code.
2019 (read_hex, load_charset_map_from_file): Check for integer overflow.
2020
50849c52
PE
2021 * xterm.c: don't go over XClientMessageEvent limit
2022 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2023 (x_send_scroll_bar_event): Likewise. Check that the size does not
2024 exceed limits imposed by XClientMessageEvent, as well as the usual
2025 ptrdiff_t and size_t limits.
2026
b13995db
PE
2027 * keyboard.c: Overflow, signedness and related fixes.
2028 (make_lispy_movement): Use same integer type in forward decl
2029 that is used in the definition.
2030 (read_key_sequence, keyremap_step):
2031 Change bufsize argument back to int, undoing my 2011-03-30 change.
2032 We prefer signed types, and int is wide enough here.
2033 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2034 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2035 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2036 length, not size_t. Use ptrdiff_t for index, not int.
2037 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2038 possibility of integer overflow.
2039
13464394
PE
2040 Overflow, signedness and related fixes for images.
2041
2042 * dispextern.h (struct it.stack[0].u.image.image_id)
2043 (struct_it.image_id, struct image.id, struct image_cache.size)
2044 (struct image_cache.used, struct image_cache.ref_count):
2045 * gtkutil.c (update_frame_tool_bar):
2046 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2047 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2048 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2049 * nsmenu.m (update_frame_tool_bar):
2050 * xdisp.c (calc_pixel_width_or_height):
2051 * xfns.c (image_cache_refcount):
2052 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2053 on typical 64-bit hosts.
2054
2055 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2056 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2057 Omit unnecessary casts to int.
2058 (parse_image_spec): Check that integers fall into 'int' range
2059 when the callers expect that.
2060 (image_ascent): Redo ascent calculation to avoid int overflow.
2061 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2062 (lookup_image): Remove unnecessary tests.
2063 (xbm_image_p): Locals are now of int, not EMACS_INT,
2064 since parse_image_check makes sure they fit into int.
2065 (png_load, gif_load, svg_load_image):
2066 Prefer int to unsigned where either will do.
2067 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2068 old tiff_error_handler and tiff_warning_handler.
2069 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2070 stack buffer overflows. It uses only the features of vsnprintf
2071 that are common to both POSIX and native Microsoft.
2072 (tiff_error_handler, tiff_warning_handler): Use it.
2073 (tiff_load, gif_load, imagemagick_load_image):
2074 Don't assume :index value fits in 'int'.
2075 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2076 (imagemagick_load_image): Check that crop parameters fit into
2077 the integer types that MagickCropImage accepts. Don't assume
2078 Vimagemagick_render_type has a nonnegative value. Don't assume
2079 size_t fits in 'long'.
2080 (gs_load): Use printmax_t to print the widest integers possible.
2081 Check for integer overflow when computing image height and width.
2082
c11821d4
EZ
20832011-08-26 Eli Zaretskii <eliz@gnu.org>
2084
2085 * xdisp.c (redisplay_window): Don't force window start if point
2086 will be invisible in the resulting window. (Bug#9324)
2087
0c95fcf7
EZ
20882011-08-25 Eli Zaretskii <eliz@gnu.org>
2089
2090 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2091 the display spec is of the form `(space ...)'.
2092 (handle_display_spec): Return the value returned by
2093 handle_single_display_spec, not just 1 or zero.
2094 (handle_single_display_spec): If the display spec is of the form
2095 `(space ...)', and specifies display in the text area, return 2
2096 rather than 1.
fee65a97 2097 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2098 accurately, and prefer exact match for point under bidi.
2099 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2100
2101 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2102 into disp_prop; all users changed.
2103
2104 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2105 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2106 for the text covered by the display property.
2107
e4ed06f1
CY
21082011-08-25 Chong Yidong <cyd@stupidchicken.com>
2109
2110 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2111 Change return value to nil.
2112 (Frecord_buffer): Delete unused function.
2113
f67cdd7f
EZ
21142011-08-24 Eli Zaretskii <eliz@gnu.org>
2115
5980d4c6
EZ
2116 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2117 buffers, return left-to-right.
8610fe8b
EZ
2118 (set_cursor_from_row): Consider candidate row a win if its glyph
2119 represents a newline and point is on that newline. Fixes cursor
2120 positioning on the newline at EOL of R2L text within L2R
2121 paragraph, and vice versa.
2122 (try_cursor_movement): Check continued rows, in addition to
2123 continuation rows. Fixes unwarranted scroll when point enters a
2124 continued line of R2L text within an L2R paragraph, or vice versa.
2125 (cursor_row_p): Consider the case of point being equal to
2126 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2127 from the end of a short line to the beginning of a continued line
2128 of R2L text within L2R paragraph.
2129 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2130 composed characters.
5980d4c6 2131
f67cdd7f
EZ
2132 * bidi.c (bidi_check_type): Use xassert.
2133 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2134 members.
2135
bca633fb
EZ
21362011-08-23 Eli Zaretskii <eliz@gnu.org>
2137
2138 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2139 a character.
2140
4a5885a7
CY
21412011-08-23 Chong Yidong <cyd@stupidchicken.com>
2142
2143 * nsfont.m (ns_otf_to_script): Fix typo.
2144
0902a04e
KH
21452011-08-22 Kenichi Handa <handa@m17n.org>
2146
2147 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2148 extra slot even if the purpose is char-code-property-table.
2149
1a2e6670
EZ
21502011-08-23 Eli Zaretskii <eliz@gnu.org>
2151
8ddde651
EZ
2152 * xdisp.c (redisplay_window): When computing centering_position,
2153 account for the height of the header line. (Bug#8874)
2154
425cc014
EZ
2155 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2156 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2157 candidate is selected by the mouse, and that candidate has a
2158 composed character under the mouse.
2159
1a2e6670
EZ
2160 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2161 coordinates reported by pos-visible-in-window-p for a composed
2162 character in column zero.
2163
8b76d6f8
SM
21642011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2165
2166 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2167
dac347dd
EZ
21682011-08-22 Eli Zaretskii <eliz@gnu.org>
2169
2170 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2171 consider it a hit if to_charpos is anywhere in the range of the
2172 composed buffer positions.
2173
e013fb34
CY
21742011-08-22 Chong Yidong <cyd@stupidchicken.com>
2175
2176 * image.c (gif_load): Don't assume that each subimage has the same
2177 dimensions as the base image. Handle disposal method that is
2178 "undefined" by the gif spec (Bug#9335).
2179
bd1ba3e8
CY
21802011-08-20 Chong Yidong <cyd@stupidchicken.com>
2181
2182 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2183 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2184
54a1215b
EZ
21852011-08-19 Eli Zaretskii <eliz@gnu.org>
2186
823564e5
EZ
2187 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2188 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2189 from an Org mode buffer to a Speedbar frame.
2190
54a1215b
EZ
2191 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2192 a composition, take its buffer position from IT->cmp_it.charpos.
2193 Fixes cursor positioning at the beginning of a line that begins
2194 with a composed character.
2195
9778ebcc
EZ
21962011-08-18 Eli Zaretskii <eliz@gnu.org>
2197
0be6ee06
EZ
2198 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2199 character bidirectional type, use STRONG_L instead. Fixes crashes
2200 in a buffer produced by `describe-categories'.
2201
9778ebcc
EZ
2202 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2203 members before the level stack, so they would be saved and
2204 restored when copying iterator state. Fixes incorrect reordering
2205 around TABs covered by display properties.
2206
156bffbe
AS
22072011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2208
6b02f655 2209 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2210
72ad093b
CY
22112011-08-17 Chong Yidong <cyd@stupidchicken.com>
2212
2213 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2214 (internal_condition_case_2, internal_condition_case_n):
2215 Remove unnecessary aborts (Bug#9081).
72ad093b 2216
35774242
EZ
22172011-08-17 Eli Zaretskii <eliz@gnu.org>
2218
2219 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2220 has no `load' handler, try opening the file locally. (Bug#9311)
2221
db76dd85
KB
22222011-08-16 Ken Brown <kbrown@cornell.edu>
2223
2224 * gmalloc.c: Expand comment.
2225
b215eee5
EZ
22262011-08-16 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2229 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2230
a4579d33
KB
22312011-08-16 Ken Brown <kbrown@cornell.edu>
2232
2233 Fix memory allocation problems in Cygwin build (Bug#9273).
2234
2235 * unexcw.c ( __malloc_initialized): Declare external variable.
2236 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2237
8b76d6f8
SM
2238 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2239 New variables.
a4579d33
KB
2240 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2241 dumped emacs.
2242 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2243 in the static heap.
2244 [CYGWIN] (special_realloc): New function.
2245 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2246 requests to realloc storage in the static heap.
2247
3ebec551
PE
22482011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2249
2250 * bidi.c (bidi_initialize): Remove unused local.
2251
9fd8be00
EZ
22522011-08-15 Eli Zaretskii <eliz@gnu.org>
2253
6b02f655
SM
2254 * bidimirror.h:
2255 * biditype.h: Remove file.
2256 * makefile.w32-in ($(BLD)/bidi.$(O)):
2257 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2258
2259 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2260
2261 * chartab.c: Improve commentary for the uniprop_table API.
2262
32413314
EZ
2263 * bidi.c (bidi_paragraph_init): Support zero value of
2264 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2265 (bidi_initialize): Use uniprop_table instead of including
2266 biditype.h and bidimirror.h.
32413314 2267
9fd8be00
EZ
2268 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2269 coordinates of the iterator when restoring from ppos_it.
2270 (Bug#9296)
2271
5cf2b69b
KH
22722011-08-14 Kenichi Handa <handa@m17n.org>
2273
2274 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2275 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2276
daf17d00
EZ
22772011-08-14 Eli Zaretskii <eliz@gnu.org>
2278
2279 * xdisp.c (move_it_in_display_line_to): Don't invoke
2280 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2281 ppos_it. Fixes vertical cursor motion when line beginning is
2282 covered by an image. (Bug#9296)
2283
08e3161a
JD
22842011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2285
2286 * nsterm.h (ns_run_ascript): Declare.
2287 (NSAPP_DATA2_RUNASSCRIPT): Define.
2288
2289 * nsfns.m (as_script, as_result, as_status): New static variables.
2290 (ns_run_ascript): New function.
5e617bc2 2291 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2292 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2293 the event loop. Get status from as_status (Bug#7276).
2294
2295 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2296 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2297 the event loop (Bug#7276).
2298
a3720aa2
AS
22992011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2300
2301 * gnutls.c (QCgnutls_bootprop_priority)
2302 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2303 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2304 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2305 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2306 (QCgnutls_bootprop_verify_hostname_error)
2307 (QCgnutls_bootprop_callbacks_verify): Rename from
2308 Qgnutls_bootprop_..., all uses changed.
2309
2310 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2311 uses changed.
2312
0a0d27fb
PE
23132011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2314
19d5c50c
PE
2315 * xfaces.c (Qframe_set_background_mode): Now static.
2316 * dispextern.h (Qframe_set_background_mode): Remove decl.
2317
0a0d27fb
PE
2318 * process.c (Fnetwork_interface_info): Declare local only if needed.
2319
377538cb
JD
23202011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2321
2322 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2323 (Fnetwork_interface_list): Allocate in increments of bytes instead
2324 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2325 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2326 sockaddr.
2327 (struct ifflag_def): notrailers is smart on OSX.
2328 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2329 Get hardware address with getifaddrs if available.
2330
08fff70c
EZ
23312011-08-12 Eli Zaretskii <eliz@gnu.org>
2332
2333 * xdisp.c (iterate_out_of_display_property): xassert that
2334 IT->position is set to within IT->object's boundaries. Break from
2335 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2336 when IT->position is set up wrongly due to some bug.
2337 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2338 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2339 entry. Force push_it to save on the stack the current
2340 buffer/string position, to be restored by pop_it. Fix flags in
2341 the iterator structure wrt the object coming from a display
2342 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2343 properties. (Bug#9284)
2344
7be1c708 23452011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2346
7be1c708
CY
2347 * fontset.c (fontset_get_font_group): Add proper type checks.
2348 (Bug#9172)
aac0c6e3 2349
7be1c708 23502011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2351
7be1c708
CY
2352 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2353 and LC_VERSION_MIN_MACOSX.
2354 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2355 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2356
97bb72a6
EZ
23572011-08-08 Eli Zaretskii <eliz@gnu.org>
2358
2359 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2360 no-display-properties-and-no-overlays under bidi display.
2361 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2362 properties and overlays.
97bb72a6 2363
d5617611
CY
23642011-08-08 Chong Yidong <cyd@stupidchicken.com>
2365
37e11a63
CY
2366 * editfns.c (Fset_time_zone_rule): Document relationship with the
2367 setenv function.
2368
d5617611
CY
2369 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2370 the font entity extracted from the cache (Bug#8109).
2371
58872834
CY
23722011-08-07 Chong Yidong <cyd@stupidchicken.com>
2373
2374 * composite.c (autocmp_chars): Don't reset point. That is done by
2375 restore_point_unwind (Bug#5984).
2376
75bfc667
JL
23772011-08-07 Juri Linkov <juri@jurta.org>
2378
2379 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2380 to show the arg `TIME' instead of `TIMEVAL'.
2381
d1410150
EZ
23822011-08-06 Eli Zaretskii <eliz@gnu.org>
2383
2384 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2385 display property strides EOL and includes a newline, as in
2386 longlines-mode. (Bug#9254)
75b771e4
EZ
2387 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2388 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2389
2390 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2391 is non-zero, even if the data buffer is NULL. Fixes a crash in
2392 vertical-motion with longlines-mode. (Bug#9254)
2393
35928349
EZ
23942011-08-05 Eli Zaretskii <eliz@gnu.org>
2395
ec7cc85b
EZ
2396 * bidi.c <bidi_cache_total_alloc>: Now static.
2397 (bidi_initialize): Initialize bidi_cache_total_alloc.
2398
8b76d6f8 2399 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2400 cache. (Bug#9221)
2401
2402 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2403 amount allocated this far in `bidi_cache_total_alloc'.
2404 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2405 non-zero, only free the data buffer without restoring the cache
2406 contents. All callers changed.
2407
2408 * dispextern.h (bidi_unshelve_cache): Update prototype.
2409
2410 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2411 (move_it_in_display_line, move_it_to)
2412 (move_it_vertically_backward, move_it_by_lines): Replace the call
2413 to xfree to an equivalent call to bidi_unshelve_cache.
2414 (move_it_in_display_line_to): Fix logic of returning
412b6358 2415 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2416
e2e2423b
EZ
24172011-08-05 Eli Zaretskii <eliz@gnu.org>
2418
2419 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2420 came from a string character with a `cursor' property. (Bug#9229)
2421
ae9e757a
JD
24222011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2423
2424 * Makefile.in (LIB_PTHREAD): New variable.
2425 (LIBES): Add LIB_PTHREAD (Bug#9216).
2426
2427 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2428 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2429
213bd7f2
AS
24302011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2431
6b02f655 2432 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2433
99aaf75f
JD
24342011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2435
2436 * xterm.c (x_find_topmost_parent): New function.
2437 (x_set_frame_alpha): Find topmost parent window with
2438 x_find_topmost_parent and set the property there also (bug#9181).
2439 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2440
c74e9d86
PE
24412011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2442
2443 * callproc.c (Fcall_process): Avoid vfork clobbering
2444 the local vars buffer, coding_systems, current_dir.
2445
640c8776
SM
24462011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2447
2448 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2449
f26d0e4c
PE
24502011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2451
8a10d76c
PE
2452 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2453 so that it is not optimized away.
2454
f26d0e4c
PE
2455 * xdisp.c (compute_display_string_pos): Remove unused local.
2456
55439c61
EZ
24572011-08-02 Eli Zaretskii <eliz@gnu.org>
2458
2459 Fix slow cursor motion and scrolling in large buffers with
2460 selective display, like Org Mode buffers. (Bug#9218)
2461
2462 * dispextern.h (struct bidi_it): New member disp_prop_p.
2463
2464 * xdisp.c: Remove one-slot cache of display string positions.
2465 (compute_display_string_pos): Accept an additional argument
5e617bc2 2466 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2467 for a display string or property. If found, set DISP_PROP_P
2468 non-zero.
2469
2470 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2471 DISP_PROP_P, and pass it to compute_display_string_pos.
2472 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2473 non-zero. All callers of bidi_fetch_char changed.
2474
fb33fa43
SM
24752011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2476
2477 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2478
b099e063
DM
24792010-12-03 Don March <don@ohspite.net>
2480
2481 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2482 last character M-[char] is translated to ESC [char] (bug#7541).
2483
5cc7f7af
KH
24842011-08-02 Kenichi Handa <handa@m17n.org>
2485
d0fffa3f 2486 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2487
2488 * chartab.c (uniprop_table): Make it non-static.
2489
525d5e6e
EZ
24902011-08-01 Eli Zaretskii <eliz@gnu.org>
2491
2492 * xdisp.c (forward_to_next_line_start): Accept additional argument
2493 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2494 on the newline.
2495 (reseat_at_next_visible_line_start): Use the bidi iterator state
2496 returned by forward_to_next_line_start to restore the state of
2497 it->bidi_it after backing up to previous newline. (Bug#9212)
2498
31011111
AS
24992011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2500
2501 * regex.c (re_comp): Protoize.
2502 (re_exec): Fix return type.
2503 (regexec): Fix type of `ret'. (Bug#9203)
2504
476371c4
PE
25052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2506
e5d76069
PE
2507 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2508 This is needed if max-image-size is a floating-point number.
2509
9a79b20c
AS
25102011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2511
2512 * print.c (print_object): Print empty symbol as ##.
2513
2514 * lread.c (read1): Read ## as empty symbol.
2515
d8c2fa78
AA
25162011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2517
2518 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2519 setting frame foreground color (Bug#9175).
2520 (x_set_background_color): Likewise.
2521
ffe57a7a
AA
2522 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2523 contents (Bug#9176).
2524 (EmacsTooltip -init): Remove bezels and add shadows to
2525 tooltip windows.
2526
bf3492a5
AA
2527 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2528 or scroll bar (Bug#8470).
2529
d55e9c53
AA
2530 * nsfont.m (nsfont_open): Remove assignment to voffset and
2531 unnecessary vars hshink, expand, hd, full_height, min_height.
2532 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2533
2534 * nsterm.h (nsfont_info): Remove voffset field.
2535
d8c2fa78 25362011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2537
2538 Implement strike-through and overline on NextStep (Bug#8863).
2539
2540 * nsfont.m (nsfont_open): Use underline position provided by font,
2541 instead of hard-coded value of 2.
2542 (nsfont_draw): Call ns_draw_text_decoration instead.
2543
2544 * nsterm.h: Add declaration for ns_draw_text_decoration.
2545
2546 * nsterm.m (ns_draw_text_decoration): New function for drawing
2547 underline, overline, and strike-through.
2548 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2549 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2550 accommodate underlining, etc.
4843aac3 2551
4cc60b9b
EZ
25522011-07-28 Eli Zaretskii <eliz@gnu.org>
2553
bc7ece87
EZ
2554 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2555 default.
4cc60b9b 2556
476371c4
PE
25572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2558
66606eea
PE
2559 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2560 Without this fix, if a signal arrives just after memory fills up,
2561 'malloc' might be invoked reentrantly.
2562
476371c4
PE
2563 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2564 In other words, assume that every image size is allowed, on non-X
2565 hosts. This assumption is probably wrong, but it lets Emacs compile.
2566
f3fcc40d
AS
25672011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2568
2569 * regex.c (re_iswctype): Convert return values to boolean.
2570
350c992f
EZ
25712011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2572
2573 * xdisp.c (compute_display_string_pos): Don't use cached display
2574 string position if the buffer had its restriction changed.
2575 (Bug#9184)
2576
5266b4bb
PE
25772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2578
2579 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2580
2573a837 25812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2582
41f55ccd 2583 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2584
39e378da
PE
2585 * bidi.c: Integer size and overflow fixes.
2586 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2587 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2588 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2589 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2590 (bidi_find_other_level_edge):
2591 Use ptrdiff_t instead of EMACS_INT where either will do.
2592 This works better on 32-bit hosts configured --with-wide-int.
2593 (bidi_cache_ensure_space): Check for size-calculation overflow.
2594 Use % rather than repeated addition, for better worst-case speed.
2595 Don't set bidi_cache_size until after xrealloc returns, because it
2596 might not return.
2597 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2598 (bidi_cache_ensure_space): Also check that the bidi cache size
2599 does not exceed that of the largest Lisp string or buffer. See Eli
2600 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2601
5e927815
PE
2602 * alloc.c (__malloc_size_t): Remove.
2603 All uses replaced by size_t. See Andreas Schwab's note
2604 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2605
ca4aa935
PE
2606 * image.c: Improve checking for integer overflow.
2607 (check_image_size): Assume that f is nonnull, since
2608 it is always nonnull in practice. This is one less thing to
2609 worry about when checking for integer overflow later.
2610 (x_check_image_size): New function, which checks for integer
2611 overflow issues inside X.
2612 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2613 This removes the need for a memory_full check.
2614 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2615 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2616 (xbm_read_bitmap_data): Change locals back to 'int', since
2617 their values must fit in 'int'.
2618 (xpm_load_image, png_load, tiff_load):
2619 Invoke x_create_x_image_and_pixmap earlier,
2620 to avoid much needless work if the image is too large.
2621 (tiff_load): Treat overly large images as if
2622 x_create_x_image_and_pixmap failed, not as malloc failures.
2623 (gs_load): Use x_check_image_size.
2624
5f8f9cc2
PE
2625 * gtkutil.c: Omit integer casts.
2626 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2627 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2628
5adf60bc
PE
2629 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2630
c8907a93
PE
2631 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2632 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2633 would wrongly return t on a 64-bit host.
2634
e3c25c68
PE
2635 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2636 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2637 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2638 and therefore cause GCC to emit a bogus diagnostic in some cases.
2639
3f791afe
PE
2640 * image.c: Integer signedness and overflow and related fixes.
2641 This is not an exhaustive set of fixes, but it's time to
2642 record what I've got.
2643 (lookup_pixel_color, check_image_size): Remove redundant decls.
2644 (check_image_size): Don't assume that arbitrary EMACS_INT values
2645 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2646 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2647 (tiff_load, imagemagick_load_image):
2648 Check for overflow in size calculations.
2649 (x_create_x_image_and_pixmap): Remove unnecessary test for
2650 xmalloc returning NULL; that can't happen.
2651 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2652 (xpm_color_bucket): Use better integer hashing function.
2653 (xpm_cache_color): Don't possibly over-allocate memory.
2654 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2655 (gif_memory_source):
2656 Use ptrdiff_t, not int or size_t, to record sizes.
2657 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2658 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2659 either works, as we prefer signed integers.
2660 (tiff_read_from_memory, tiff_write_from_memory):
2661 Return tsize_t, not size_t, since that's what the TIFF API wants.
2662 (tiff_read_from_memory): Don't fail simply because the read would
2663 go past EOF; instead, return a short read.
2664 (tiff_load): Omit no-longer-needed casts.
2665 (Fimagemagick_types): Don't assume size fits into 'int'.
2666
3cc5a532
PE
2667 Improve hashing quality when configured --with-wide-int.
2668 * fns.c (hash_string): New function, taken from sxhash_string.
2669 Do not discard information about ASCII character case; this
2670 discarding is no longer needed.
2671 (sxhash-string): Use it. Change sig to match it. Caller changed.
2672 * lisp.h: Declare it.
2673 * lread.c (hash_string): Remove, since we now use fns.c's version.
2674 The fns.c version returns a wider integer if --with-wide-int is
2675 specified, so this should help the quality of the hashing a bit.
2676
b312a492
PE
2677 * emacs.c: Integer overflow minor fix.
2678 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2679 Define only if GNU_LINUX.
2680 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2681
dfd153ae
PE
2682 * dispnew.c: Integer signedness and overflow fixes.
2683 Remove unnecessary forward decls, that were a maintenance hassle.
2684 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2685 All uses changed.
2686 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2687 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2688 (prepare_desired_row, line_draw_cost):
2689 Use int, not unsigned, where either works.
2690 (save_current_matrix, restore_current_matrix):
2691 Use ptrdiff_t, not size_t, where either works.
2692 (init_display): Check for overflow more accurately, and without
2693 relying on undefined behavior.
2694
a81d11a3
PE
2695 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2696 Remove, replacing with the new symbols in lisp.h. All uses changed.
2697 * fileio.c (make_temp_name):
2698 * filelock.c (lock_file_1, lock_file):
2699 * xdisp.c (message_dolog):
2700 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2701 Use pMd etc. instead.
2702 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2703 replacing the pWIDE etc. symbols removed from editfns.c.
2704
3300e6fd
PE
2705 * keyboard.h (num_input_events): Now uintmax_t.
2706 This is (very slightly) less likely to mess up due to wraparound.
2707 All uses changed.
2708
fd05c7e9
PE
2709 * buffer.c: Integer signedness fixes.
2710 (alloc_buffer_text, enlarge_buffer_text):
2711 Use ptrdiff_t rather than size_t when either will do, as we prefer
2712 signed integers.
2713
903fe15d
PE
2714 * alloc.c: Integer signedness and overflow fixes.
2715 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2716 (__malloc_size_t): Default to size_t, not to int.
2717 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2718 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2719 Prefer ptrdiff_t to size_t when either would do, as we prefer
2720 signed integers.
2721 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2722 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2723 Now const. Initialize with values that are in range even if char
2724 is signed.
2725 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2726 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2727 These functions do the right thing with sizes > 2**32.
2728 (check_depth): Now ptrdiff_t, not int.
2729 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2730 Adjust to new way of storing sizes. Check for size overflow bugs
2731 in rest of code.
2732 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2733 slightly wrong anyway, as it missed one instance of
2734 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2735 (refill_memory_reserve): Omit needless cast to size_t.
2736 (mark_object_loop_halt): Mark as externally visible.
2737
ac82cc6a
PE
2738 * xselect.c: Integer signedness and overflow fixes.
2739 (Fx_register_dnd_atom, x_handle_dnd_message):
2740 Use ptrdiff_t, not size_t, since we prefer signed.
2741 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2742 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2743 x_dnd_atoms_size and x_dnd_atoms_length.
2744
c2d1e36d
PE
2745 * doprnt.c: Prefer signed to unsigned when either works.
2746 * eval.c (verror):
2747 * doprnt.c (doprnt):
2748 * lisp.h (doprnt):
2749 * xdisp.c (vmessage):
2750 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2751 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2752 prefer signed arithmetic to avoid comparison confusion.
2753 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2754 but is a bit tricky.
2755
0e926e56
PE
2756 Assume freestanding C89 headers, string.h, stdlib.h.
2757 * data.c, doprnt.c, floatfns.c, print.c:
2758 Include float.h unconditionally.
2759 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2760 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2761 * regex.c: Likewise for stddef.h, string.h.
2762 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2763 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2764 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2765 (STDC_HEADERS): Remove obsolete defines.
2766 * sysdep.c: Include limits.h unconditionally.
2767
9cfdb3ec
PE
2768 Assume support for memcmp, memcpy, memmove, memset.
2769 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2770 * regex.c (memcmp, memcpy):
2771 Remove; we assume C89 now.
2772
2773 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2774 (__malloc_safe_bcopy): Remove; no longer needed.
2775
cf950e6b 2776 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2777 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2778 well either way, and we prefer signed to unsigned.
2779
dbf38e02
LMI
27802011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2781
2782 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2783 closes the connection while we're reading (bug#9182).
2784
d6f0886c 27852011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2786
d6f0886c
JD
2787 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2788 are specified (Bug#9168).
24e0f6b1 2789
2eb1f9e6
PE
27902011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2791
2792 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2793 Found by GCC static checking and --with-wide-int on a 32-bit host.
2794
22381272 27952011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2796
2797 * xdisp.c (compute_display_string_pos): Fix logic of caching
2798 previous display string position. Initialize cached_prev_pos to
2799 -1. Fixes slow-down at the beginning of a buffer.
2800
f25e39b4
EZ
28012011-07-24 Eli Zaretskii <eliz@gnu.org>
2802
2803 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2804 for attrs[LFACE_FONTSET_INDEX].
2805
04c4b52e
PE
28062011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2807
2808 * xml.c (parse_region): Remove unused local
2809 that was recently introduced.
2810
c1734fbd
EZ
28112011-07-23 Eli Zaretskii <eliz@gnu.org>
2812
be18c5a5
EZ
2813 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2814 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2815
c1734fbd
EZ
2816 * xdisp.c (move_it_in_display_line_to): Record the best matching
2817 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2818 exit if none of the characters scanned was an exact match.
2819 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2820 when exact match is impossible due to invisible text, and the
2821 lines are truncated.
2822
a258d627
JD
28232011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2824
2825 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2826 for OSX >= 10.7.
2827
b6d5a689
EZ
28282011-07-22 Eli Zaretskii <eliz@gnu.org>
2829
0f74f785
EZ
2830 Fix a significant slow-down of cursor motion with C-n, C-p,
2831 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2832 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2833 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2834 (next_element_from_buffer): Call compute_stop_pos_backwards to
2835 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2836 base_level_stop.
2837 (reseat): Don't look for prev_stop, as that could mean a very long
2838 run.
2839 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2840 <cached_disp_overlay_modiff>: Cache for last found display string
2841 position.
551918c1 2842 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2843 about the same buffer in the same area of character positions, and
2844 the buffer wasn't changed since the time the display string
2845 position was cached.
551918c1 2846
b2d0c91a
EZ
28472011-07-22 Eli Zaretskii <eliz@gnu.org>
2848
2849 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2850 is an integer, which is important for empty lines. (Bug#9149)
2851
043604ee
CY
28522011-07-22 Chong Yidong <cyd@stupidchicken.com>
2853
2854 * frame.c (Fmodify_frame_parameters): In tty case, update the
2855 default face if necessary (Bug#4238).
2856
da4adb04
CY
28572011-07-21 Chong Yidong <cyd@stupidchicken.com>
2858
2859 * editfns.c (Fstring_to_char): No need to explain what a character
2860 is in the docstring (Bug#6576).
2861
9abd0532
LMI
28622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2863
2864 * xml.c (parse_region): Make sure we always return a tree.
2865
36881d16
HK
28662011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2867
2868 * xml.c (parse_region): If a document contains only comments,
2869 return that, too.
2870
1e98674d
LMI
28712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2872
2873 * xml.c (make_dom): Return comments, too.
2874
590bd467
PE
28752011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2876
2877 Port to OpenBSD.
2878 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2879 and the surrounding thread.
2880 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2881 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2882 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2883 timer goes off.
2884 * s/openbsd.h (BROKEN_SIGIO): Define.
2885 * unexelf.c (unexec) [__OpenBSD__]:
2886 Don't update the .mdebug section of the Alpha COFF symbol table.
2887
f41628b2
LMI
28882011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2889
2890 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2891 (bug#8460).
2892
b59b67c5
PE
28932011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2894
15e3a074
PE
2895 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2896 This fixes some race conditions on the permissions of any newly
2897 created file.
2898
41bed37d
PE
2899 * alloc.c (valid_pointer_p): Use pipe, not open.
2900 This fixes some permissions issues when debugging.
2901
b59b67c5
PE
2902 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2903 If fchown fails to set both uid and gid, try to set just gid,
2904 as that is sometimes allowed. Adjust the file's mode to eliminate
2905 setuid or setgid bits that are inappropriate if fchown fails.
2906
925a6be7
SM
29072011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2908
2909 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2910 to compare Lisp_Objects.
2911 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2912 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2913 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2914
52968808
AS
29152011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2916
0a6a104b
AS
2917 * lread.c (read_integer): Unread even EOF character.
2918 (read1): Likewise. Properly record start position of symbol.
2919
52968808
AS
2920 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2921 symbol character follows.
2922
9e381cdd
PE
29232011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2924
2925 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2926 This works around a problem with the previous change to Fcopy_file.
2927 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2928 and without this change, GCC might complain about discarding
2929 fchown's return value.
2930
b5641435
JB
29312011-07-16 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2934
a8031457
PE
29352011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2938
dd889327
LMI
29392011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2940
750c33f7
LMI
2941 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2942 it's used from the C level.
2943
dd889327
LMI
2944 * process.c: Use the same condition for POLL_FOR_INPUT in both
2945 keyboard.c and process.c (bug#1858).
2946
87e86684
LM
29472011-07-09 Lawrence Mitchell <wence@gmx.li>
2948
2949 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2950 (Fgnutls_boot): Use it.
2951
64348f40
AS
29522011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2953
2954 * doc.c (Fsubstitute_command_keys): Revert last change.
2955
1d698799
LMI
29562011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2957
f863868c
LMI
2958 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2959 quotes the next character, and doesn't affect other longer
2960 sequences (bug#8935).
2961
1d698799
LMI
2962 * lread.c (syms_of_lread): Clarify that is isn't only
2963 `eval-buffer' and `eval-defun' that's affected by
2964 `lexical-binding' (bug#8460).
2965
aa4b6df6
EZ
29662011-07-15 Eli Zaretskii <eliz@gnu.org>
2967
2968 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2969 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2970
5d856da6
PE
29712011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2972
ad6042bb
PE
2973 Fix minor problems found by static checking.
2974 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2975 (elsz): Now a signed constant, not a size_t var. We prefer signed
2976 types to unsigned, to avoid integer comparison confusion. Without
2977 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2978 "cannot optimize loop, the loop counter may overflow", a symptom
2979 of the confusion.
f00bbb22 2980 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2981 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2982
6468f31c
LMI
29832011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2984
49080b10
LMI
2985 * search.c (Fre_search_backward): Mention `case-fold-search' in
2986 all the re_search_* functions (bug#8138).
2987
6468f31c
LMI
2988 * keyboard.c (Fopen_dribble_file): Document when the file is
2989 closed (bug#8056).
2990
c965adc5
EZ
29912011-07-14 Eli Zaretskii <eliz@gnu.org>
2992
df9733bf
EZ
2993 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2994 bidi_cache_idx.
2995
0bb23927
EZ
2996 Support bidi reordering of display and overlay strings.
2997 * xdisp.c (compute_display_string_pos)
2998 (compute_display_string_end): Accept additional argument STRING.
2999 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3000 (reseat_to_string): Initialize bidi_it->string.s and
3001 bidi_it->string.schars.
3002 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3003 NULL (avoids a crash in bidi_paragraph_init).
3004 Initialize itb.string.lstring.
0bb23927
EZ
3005 (init_iterator): Call bidi_init_it only of a valid
3006 buffer position was specified. Initialize paragraph_embedding to
3007 L2R.
3008 (reseat_to_string): Initialize the bidi iterator.
3009 (display_string): If we need to ignore text properties of
3010 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3011 original value of -1 will not work with bidi.)
3012 (compute_display_string_pos): First arg is now struct
3013 `text_pos *'; all callers changed. Support display properties on
3014 Lisp strings.
3015 (compute_display_string_end): Support display properties on Lisp
3016 strings.
3017 (init_iterator, reseat_1, reseat_to_string): Initialize the
3018 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3019 when iterating on a string not from display properties).
640c8776
SM
3020 (compute_display_string_pos, compute_display_string_end):
3021 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3022 arrow keys.
3023 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3024 base_level_stop; instead, set base_level_stop to BEGV.
3025 Fixes crashes in vertical-motion.
0bb23927
EZ
3026 (next_element_from_buffer): Improve commentary for when
3027 the iterator is before prev_stop.
3028 (init_iterator): Initialize bidi_p from the default value of
3029 bidi-display-reordering, not from buffer-local value. Use the
3030 buffer-local value only if initializing for buffer iteration.
3031 (handle_invisible_prop): Support invisible properties on strings
3032 that are being bidi-reordered.
3033 (set_iterator_to_next): Support bidi reordering of C strings and
3034 Lisp strings.
3035 (next_element_from_string): Support bidi reordering of Lisp
3036 strings.
3037 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3038 (display_string): Support display of R2L glyph rows.
3039 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3040 (init_iterator): Don't initialize it->bidi_p for strings
3041 here.
3042 (reseat_to_string): Initialize it->bidi_p for strings here.
3043 (next_element_from_string, next_element_from_c_string)
3044 (next_element_from_buffer): Add xassert's for correspondence
3045 between IT's object being iterated and it->bidi_it.string
3046 structure.
3047 (face_before_or_after_it_pos): Support bidi iteration.
3048 (next_element_from_c_string): Handle the case of the first string
3049 character that is not the first one in the visual order.
3050 (get_visually_first_element): New function, refactored from common
3051 parts of next_element_from_buffer, next_element_from_string, and
3052 next_element_from_c_string.
3053 (tool_bar_lines_needed, redisplay_tool_bar)
3054 (display_menu_bar): Force left-to-right direction. Add a FIXME
3055 comment for making that be controlled by a user option.
3056 (push_it, pop_it): Save and restore the state of the
3057 bidi iterator. Save and restore the bidi_p flag.
3058 (pop_it): Iterate out of display property for string iteration as
3059 well.
3060 (iterate_out_of_display_property): Support iteration over strings.
3061 (handle_single_display_spec): Set up it->bidi_it for iteration
3062 over a display string, and call bidi_init_it.
3063 (handle_single_display_spec, next_overlay_string)
3064 (get_overlay_strings_1, push_display_prop): Set up the bidi
3065 iterator for displaying display or overlay strings.
3066 (forward_to_next_line_start): Don't use the shortcut if
3067 bidi-iterating.
3068 (back_to_previous_visible_line_start): If handle_display_prop
3069 pushed the iterator stack, restore the internal state of the bidi
3070 iterator by calling bidi_pop_it same number of times.
3071 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3072 and we are bidi-iterating, don't decrement the iterator position;
3073 instead, set the first_elt flag in the bidi iterator, to produce
3074 the same effect.
3075 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3076 (push_display_prop): xassert that we are iterating a buffer.
3077 (push_it, pop_it): Save and restore paragraph_embedding member.
3078 (handle_single_display_spec, next_overlay_string)
3079 (get_overlay_strings_1, reseat_1, reseat_to_string)
3080 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3081 correctly. Don't assume unibyte strings are not bidi-reordered.
3082 (compute_display_string_pos)
3083 (compute_display_string_end): Fix handling the case of C string.
3084 (push_it, pop_it): Save and restore from_disp_prop_p.
3085 (handle_single_display_spec, push_display_prop): Set the
3086 from_disp_prop_p flag.
3087 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3088 (pop_it): Call iterate_out_of_display_property only if we are
3089 popping after iteration over a string that came from a display
3090 property. Fix a typo in popping stretch info. Add an assertion
3091 for verifying that the iterator position is in sync with the bidi
3092 iterator.
3093 (handle_single_display_spec, get_overlay_strings_1)
3094 (push_display_prop): Fix initialization of paragraph direction for
3095 string when that of the parent object is not yet determined.
3096 (reseat_1): Call bidi_init_it to resync the bidi
3097 iterator with IT's position. (Bug#7616)
3098 (find_row_edges): If ROW->start.pos gives position
3099 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3100 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3101 Reset the from_disp_prop_p flag.
3102 (SAVE_IT, RESTORE_IT): New macros.
3103 (pos_visible_p, face_before_or_after_it_pos)
3104 (back_to_previous_visible_line_start)
3105 (move_it_in_display_line_to, move_it_in_display_line)
3106 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3107 (try_scrolling, redisplay_window, display_line): Use them when
3108 saving a temporary copy of the iterator and restoring it back.
3109 (back_to_previous_visible_line_start, reseat_1)
3110 (init_iterator): Empty the bidi cache "stack".
3111 (move_it_in_display_line_to): If iterator ended up at
3112 EOL, but we never saw any buffer positions smaller than
3113 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3114 motion in bidi-reordered lines.
3115 (move_it_in_display_line_to): Record prev_method and prev_pos
3116 immediately before the call to set_iterator_to_next. Fixes cursor
3117 motion in bidi-reordered lines with stretch glyphs and strings
3118 displayed in margins. (Bug#8133) (Bug#8867)
3119 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3120 TO_CHARPOS.
640c8776
SM
3121 (pos_visible_p): Support positions in bidi-reordered lines.
3122 Save and restore bidi cache.
0bb23927
EZ
3123
3124 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3125 (bidi_paragraph_info): Delete unused struct.
3126 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3127 (bidi_cache_start): New variable.
3128 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3129 to zero.
3130 (bidi_cache_fetch_state, bidi_cache_search)
3131 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3132 (bidi_cache_find, bidi_peek_at_next_level)
3133 (bidi_level_of_next_char, bidi_find_other_level_edge)
3134 (bidi_move_to_visually_next): Compare cache index with
3135 bidi_cache_start rather than with zero.
3136 (bidi_fetch_char): Accept new argument STRING; all callers
3137 changed. Support iteration over a string. Support strings with
3138 display properties. Support unibyte strings. Fix the type of
3139 `len' according to what STRING_CHAR_AND_LENGTH expects.
3140 (bidi_paragraph_init, bidi_resolve_explicit_1)
3141 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3142 (bidi_level_of_next_char, bidi_move_to_visually_next):
3143 Support iteration over a string.
0bb23927
EZ
3144 (bidi_set_sor_type, bidi_resolve_explicit_1)
3145 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3146 can now be zero (for strings); special values 0 and -1 were
3147 changed to -1 and -2, respectively.
3148 (bidi_char_at_pos): New function.
3149 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3150 Call it instead of FETCH_MULTIBYTE_CHAR.
3151 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3152 initialized to valid values.
3153 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3154 values.
3155 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3156 the test for valid cached positions. Fix the logic for looking up
3157 the sentinel state in the cache. GCPRO the Lisp string we are
3158 iterating.
3159 (bidi_push_it, bidi_pop_it): New functions.
3160 (bidi_initialize): Initialize the bidi cache start stack pointer.
3161 (bidi_cache_ensure_space): New function, refactored from part of
3162 bidi_cache_iterator_state. Don't assume the required size is just
3163 one BIDI_CACHE_CHUNK away.
3164 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3165 (bidi_count_bytes, bidi_char_at_pos): New functions.
3166 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3167 always valid if bidi_cache_idx is valid.
3168 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3169 is valid if it's going to be used.
3170 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3171 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3172 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3173 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3174 (bidi_find_other_level_edge, bidi_cache_start_stack):
3175 All variables related to cache indices are now EMACS_INT.
c965adc5 3176
0bb23927
EZ
3177 * dispextern.h (struct bidi_string_data): New structure.
3178 (struct bidi_it): New member `string'. Make flag members be 1-bit
3179 fields, and put them last in the struct.
640c8776
SM
3180 (compute_display_string_pos, compute_display_string_end):
3181 Update prototypes.
0bb23927
EZ
3182 (bidi_push_it, bidi_pop_it): Add prototypes.
3183 (struct iterator_stack_entry): New members bidi_p,
3184 paragraph_embedding, and from_disp_prop_p.
3185 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3186 (bidi_shelve_cache, bidi_unshelve_cache):
3187 Declare prototypes.
0bb23927
EZ
3188
3189 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3190 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3191 and vector-like objects.
3192
3193 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3194 cache around display iteration.
3195
3196 * window.c (Fwindow_end, window_scroll_pixel_based)
3197 (displayed_window_lines, Frecenter): Save and restore the bidi
3198 cache around display iteration.
3199
3bbd2265
LMI
32002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3201
3202 * editfns.c (Fdelete_region): Clarify the use of the named
3203 parameters (bug#6788).
3204
adc47434
MR
32052011-07-14 Martin Rudalics <rudalics@gmx.at>
3206
3207 * indent.c (Fvertical_motion): Set and restore w->pointm when
3208 saving and restoring the window's buffer (Bug#9006).
3209
837c31f8
LMI
32102011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3211
3212 * editfns.c (Fstring_to_char): Clarify just what is returned
3213 (bug#6576). Text by Eli Zaretskii.
3214
ac389d0c
JB
32152011-07-13 Juanma Barranquero <lekktu@gmail.com>
3216
3217 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3218
0be0ce47
EZ
32192011-07-13 Eli Zaretskii <eliz@gnu.org>
3220
3221 * buffer.c (mmap_find): Fix a typo.
3222
cd18e7e3
JB
32232011-07-13 Johan Bockgård <bojohan@gnu.org>
3224
3225 Fix execution of x selection hooks.
3226 * xselect.c (Qx_lost_selection_functions)
3227 (Qx_sent_selection_functions): New vars.
3228 (syms_of_xselect): DEFSYM them.
3229 (x_handle_selection_request): Pass Qx_sent_selection_functions
3230 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3231 (x_handle_selection_clear,x_clear_frame_selections):
3232 Pass Qx_lost_selection_functions rather than
3233 Vx_lost_selection_functions to Frun_hook_with_args.
3234
47ea7f44
PE
32352011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3236
ac389d0c 3237 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3238 The old code sometimes used this field without initializing it.
3239
47ea7f44
PE
3240 * alloc.c (gc_sweep): Don't read past end of array.
3241 In theory, the old code could also have corrupted Emacs internals,
3242 though it'd be very unlikely.
3243
bc985c87
AS
32442011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3245
3246 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3247 argument. (Bug#4026)
bc985c87 3248
0cf34688
LMI
32492011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3250
b3dadd76
LMI
3251 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3252 key" (bug#4257).
3253
0cf34688
LMI
3254 * window.c (Fset_window_start): Doc fix (bug#4199).
3255 (Fset_window_hscroll): Ditto.
3256
270768cd
PE
32572011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3258
077e3dda 3259 Fix minor new problems caught by GCC 4.6.1.
270768cd 3260 * term.c (init_tty): Remove unused local.
490011a6 3261 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3262 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3263 not used otherwise.
270768cd 3264
b1f58454
CY
32652011-07-12 Chong Yidong <cyd@stupidchicken.com>
3266
3267 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3268
22b9578d
LMI
32692011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3270
6e70ab07
LMI
3271 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3272 are the mini-buffer and the echo area (bug#3320).
3273
22b9578d
LMI
3274 * term.c (init_tty): Remove support for supdup, c10 and perq
3275 terminals, which are no longer supported (bug#1482).
3276
8974cc9f
JB
32772011-07-10 Johan Bockgård <bojohan@gnu.org>
3278
3279 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3280
a560d974
JD
32812011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3282
3283 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3284 for non-popups (Bug#3642).
3285
1dae0f0a
AS
32862011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3287
268c2c36 3288 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3289 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3290 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3291 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3292 * data.c (fmod): Likewise.
3293 * dispnew.c (swap_glyphs_in_rows): Likewise.
3294 * emacs.c (memory_warning_signal): Likewise.
3295 * floatfns.c (float_error): Likewise.
3296 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3297 (otf_open, font_otf_capability, generate_otf_features)
3298 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3299 Likewise.
3300 * image.c (pbm_read_file): Likewise.
3301 * indent.c (string_display_width): Likewise.
3302 * intervals.c (check_for_interval, search_for_interval)
3303 (inc_interval_count, count_intervals, root_interval)
3304 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3305 * lread.c (defalias): Likewise.
268c2c36 3306 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3307 * regex.c (set_image_of_range_1, set_image_of_range)
3308 (regex_grow_registers): Likewise.
3309 * sysdep.c (strerror): Likewise.
3310 * termcap.c (valid_filename_p, tprint, main): Likewise.
3311 * tparam.c (main): Likewise.
3312 * unexhp9k800.c (run_time_remap, save_data_space)
3313 (update_file_ptrs, read_header, write_header, calculate_checksum)
3314 (copy_file, copy_rest, display_header): Likewise.
3315 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3316 Likewise.
3317 * xdisp.c (check_it): Likewise.
3318 * xfaces.c (register_color, unregister_color, unregister_colors):
3319 Likewise.
3320 * xfns.c (print_fontset_result): Likewise.
3321 * xrdb.c (member, fatal, main): Likewise.
3322
99033785
PE
33232011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 Fix minor problems found by static checking (Bug#9031).
3326 * chartab.c (char_table_set_range, map_sub_char_table):
3327 Remove unused locals.
3328 (uniprop_table): Now static.
3329 * composite.c (_work_char): Remove unused static var.
3330
9cb2ac56
JB
33312011-07-09 Juanma Barranquero <lekktu@gmail.com>
3332
3333 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3334
f25661f0
JD
33352011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3336
3337 * gtkutil.c (qttip_cb): Remove code without function.
3338
8278c4fe
EZ
33392011-07-09 Eli Zaretskii <eliz@gnu.org>
3340
3341 * w32.c (pthread_sigmask): New stub.
3342
1692ae2d 33432011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3344
8a6ebd58 3345 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3346 sigprocmask is portable only for single-threaded applications, and
3347 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3348 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3349 (LIBES): Use it.
3350 * callproc.c (Fcall_process):
3351 * process.c (create_process):
3352 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3353 Use pthread_sigmask, not sigprocmask.
123403e4 3354
1b854618
JD
33552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3356
3357 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3358 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3359 wrong (Bug#8591).
3360
3fe4b549
JD
33612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3362
0ce7e563
JD
3363 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3364 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3365 (xg_hide_tooltip): Fix comment.
3366
3fe4b549
JD
3367 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3368 in registerServicesMenuSendTypes.
3369 (validRequestorForSendType): Don't check ns_return_types.
3370
3371 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3372 ns_return_type.
3373
5df75e47
JR
33742011-07-08 Jason Rumney <jasonr@gnu.org>
3375
22610910
JR
3376 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3377 SH_SHOW for hidden windows (Bug#5482).
3378
5df75e47
JR
3379 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3380 frame struct members of non-existent frames (Bug#6284).
3381
699c10bd
JD
33822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3383
4393663b
JD
3384 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3385 variable firstTime not needed on OSX >= 10.6.
3386 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3387 >= 10.5. Use setKnobProportion, setDoubleValue.
3388
3389 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3390 (MAC_OS_X_VERSION_10_5): Define if not defined.
3391 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3392 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3393 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3394
3395 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3396 cString and lossyCString on OSX >= 10.4
3397
58179cce 3398 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3399 sizeToFit on OSX >= 10.2.
3400
3401 * nsimage.m (allocInitFromFile): Don't use deprecated method
3402 bestRepresentationForDevice on OSX >= 10.6.
3403
3404 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3405 to avoid warning.
3406
3407 * emacs.c: Declare unexec_init_emacs_zone.
3408
a63e0781
JD
3409 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3410
699c10bd
JD
3411 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3412
3413 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3414 on svcsMenu (Bug#8842).
3415
3416 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3417 ns_return_types.
3418 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3419
3420 * nsterm.m (QUTF8_STRING): Declare.
3421 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3422 (validRequestorForSendType): Return type is (id).
3423 Change indexOfObjectIdenticalTo to indexOfObject.
3424 Check if we have local selection before returning self (Bug#8842).
3425 (writeSelectionToPasteboard): Put local selection into paste board
3426 if we have a local selection (Bug#8842).
3427 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3428
3429 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3430 (ns_get_local_selection): Declare.
3431
54e10184
LMI
34322011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3433
9888ff71
LMI
3434 * keymap.c (describe_map_tree): Don't insert a double newline at
3435 the end of the buffer (bug#1169) and return whether we inserted
3436 something.
3437
54e10184
LMI
3438 * callint.c (Fcall_interactively): Change "reading args" to
3439 "providing args" to try to clarify what it does (bug#1010).
3440
15fa4783
KH
34412011-07-07 Kenichi Handa <handa@m17n.org>
3442
3443 * composite.c (composition_compute_stop_pos): Ignore a static
3444 composition starting before CHARPOS (Bug#8915).
3445
3446 * xdisp.c (handle_composition_prop): Likewise.
3447
a8815b00
EZ
34482011-07-07 Eli Zaretskii <eliz@gnu.org>
3449
3450 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3451 (Bug#9015)
3452
ef7b981d 34532011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3454
3455 * character.h (unicode_category_t): New enum type.
3456
3457 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3458 (Qchar_code_property_table): New variable.
3459 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3460 (UNIPROP_COMPRESSED_FORM_P): New macros.
3461 (char_table_ascii): Uncompress the compressed values.
3462 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3463 Uncompress the compressed values.
ac389d0c 3464 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3465 (char_table_ref_and_range): Uncompress the compressed values.
3466 (sub_char_table_set): New arg is_uniprop. Callers changed.
3467 Uncompress the compressed values.
3468 (sub_char_table_set_range): Args changed. Callers changed.
3469 (char_table_set_range): Adjuted for the above change.
3470 (map_sub_char_table): Delete args default_val and parent. Add arg
3471 top. Give decoded values to a Lisp function.
640c8776 3472 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3473 values to a Lisp function. Gcpro more variables.
3474 (uniprop_table_uncompress)
3475 (uniprop_decode_value_run_length): New functions.
3476 (uniprop_decoder, uniprop_decoder_count): New variables.
3477 (uniprop_get_decoder, uniprop_encode_value_character)
3478 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3479 New functions.
3480 (uniprop_encoder, uniprop_encoder_count): New variables.
3481 (uniprop_get_encoder, uniprop_table)
3482 (Funicode_property_table_internal, Fget_unicode_property_internal)
3483 (Fput_unicode_property_internal): New functions.
3484 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3485 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3486 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3487 char-code-property-alist.
3488
640c8776 3489 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3490 Vunicode_category_table.
3491
640c8776 3492 * font.c (font_range): Adjust for the change of
c805dec0
KH
3493 Vunicode_category_table.
3494
76b397fb
DN
34952011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3496
3497 * m/iris4d.h: Remove file, move contents ...
3498 * s/irix6-5.h: ... here.
3499
22b4128e
PE
35002011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3501
3502 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3503 * alloc.c (mark_buffer):
3504 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3505 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3506 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3507 This isn't true in general, and it's particularly not true
3508 if Emacs is configured with --with-wide-int.
3509 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3510 New macros, used in the buffer.c change.
3511
869795d6
JD
35122011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3513
3514 * xsettings.c: Use both GConf and GSettings if both are available.
3515 (store_config_changed_event): Add comment.
3516 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3517 (store_tool_bar_style_changed): New functions.
5e617bc2 3518 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3519 (struct xsettings): Move font inside HAVE_XFT.
3520 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3521 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3522 Move inside HAVE_XFT.
640c8776 3523 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3524 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3525 also.
3526 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3527 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3528 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3529 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3530 (parse_settings): Move check for font inside HAVE_XFT.
3531 (read_settings, apply_xft_settings): Add comment.
3532 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3533 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3534 call store_font_name_changed.
3535 (xft_settings_event): Add comment.
3536 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3537 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3538 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3539 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3540 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3541 (xsettings_get_system_font, xsettings_get_system_normal_font):
3542 Add comment.
869795d6 3543
d8ed26bd
PE
35442011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 Random fixes. E.g., (random) never returned negative values.
3547 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3548 subseconds part to the entropy, as that's a bit more random.
3549 Prefer signed to unsigned, since the signedness doesn't matter and
3550 in general we prefer signed. When given a limit, use a
3551 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3552 latter isn't right if USE_2_TAGS_FOR_INTS.
3553 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3554 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3555
cabf1cac
SM
35562011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3557
3558 * textprop.c (text_property_stickiness):
3559 Obey Vtext_property_default_nonsticky.
3560 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3561 * w32fns.c (syms_of_w32fns):
3562 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3563
6e9b2be9
PE
35642011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3565
3566 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3567 This is more efficient than Ffile_directory_p and avoids a minor race.
3568
90186c68
LMI
35692011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3570
7c301272
LMI
3571 * buffer.c (Foverlay_put): Say what the return value is
3572 (bug#7835).
3573
c4f2d8d4
LMI
3574 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3575 is a directory before asking whether to use the file name
3576 (bug#7564).
ad637907
LMI
3577 (barf_or_query_if_file_exists): Make the "File is a directory"
3578 error be more correct.
c4f2d8d4 3579
90186c68
LMI
3580 * fns.c (Frequire): Remove the mention of the .gz files, since
3581 that's installation-specific, but keep the mention of
3582 `get-load-suffixes'.
3583
da64016e
PE
35842011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3585
3586 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3587 Report string overflow if the output is too long.
3588
7d47b580
JB
35892011-07-04 Juanma Barranquero <lekktu@gmail.com>
3590
a555cb87
JB
3591 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3592 (syms_of_gnutls): Remove duplicate DEFSYM for
3593 Qgnutls_bootprop_verify_hostname_error, an error for
3594 Qgnutls_bootprop_verify_error (which is no longer used).
3595
7d47b580
JB
3596 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3597 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3598 Also (re)move comments that are misplaced or no longer relevant.
3599
1e49bfab
LMI
36002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3601
3602 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3603
1485f4c0
CY
36042011-07-03 Chong Yidong <cyd@stupidchicken.com>
3605
3606 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3607 and background color parameters if they have been changed.
3608
a9ab721e
LMI
36092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3610
3611 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3612
cf7cff57
PE
36132011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3614
2e13213d
PE
3615 * xsettings.c (SYSTEM_FONT): Define only when used.
3616 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3617
cf7cff57
PE
3618 * keymap.c (access_keymap_1): Now static.
3619
7a8e04f7
CY
36202011-07-02 Chong Yidong <cyd@stupidchicken.com>
3621
3622 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3623 leave any prefix arg for the up event (Bug#1586).
3624
61352f62
LMI
36252011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3626
69bb1ef7
LMI
3627 * lread.c (syms_of_lread): Mention single symbols defined by
3628 `defvar' or `defconst' (bug#7154).
3629
61352f62 3630 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3631 (Frequire): Mention get-load-suffixes.
61352f62 3632
28545e04
MR
36332011-07-02 Martin Rudalics <rudalics@gmx.at>
3634
3635 * window.h (window): Remove clone_number slot.
3636 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3637 Remove.
3638 (make_parent_window, make_window, saved_window)
3639 (Fset_window_configuration, save_window_save): Don't deal with
3640 clone numbers.
3641 * buffer.c (Qclone_number): Remove declaration.
3642 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3643
3349e122
SM
36442011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3645
3646 Add multiple inheritance to keymaps.
3647 * keymap.c (Fmake_composed_keymap): New function.
3648 (Fset_keymap_parent): Simplify.
3649 (fix_submap_inheritance): Remove.
3650 (access_keymap_1): New function extracted from access_keymap to handle
3651 embedded parents and handle lists of maps.
3652 (access_keymap): Use it.
3653 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3654 (Fcopy_keymap): Handle embedded parents.
3655 (Fcommand_remapping, define_as_prefix): Simplify.
3656 (Fkey_binding): Simplify.
3657 (syms_of_keymap): Move minibuffer-local-completion-map,
3658 minibuffer-local-filename-completion-map,
3659 minibuffer-local-must-match-map, and
3660 minibuffer-local-filename-must-match-map to Elisp.
3661 (syms_of_keymap): Defsubr make-composed-keymap.
3662 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3663 (parse_menu_item): Trivial simplification.
3664
3279eb87
GM
36652011-07-01 Glenn Morris <rgm@gnu.org>
3666
3667 * Makefile.in (SETTINGS_LIBS): Fix typo.
3668
4550efdf
KI
36692011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3670
3671 * coding.c (Fencode_coding_string): Record the last coding system
3672 used, as the function doc string says (bug#8738).
3673
0949d2b6
JD
36742011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3675
3676 * xsettings.c (store_monospaced_changed): Take new font as arg and
3677 check for change against current_mono_font.
3678 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3679 (emacs_settings_constructor, emacs_settings_get_property)
3680 (emacs_settings_set_property, emacs_settings_class_init)
3681 (emacs_settings_init, gsettings_obj): Remove.
3682 (something_changedCB): New function for HAVE_GSETTINGS.
3683 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3684 with value as argument.
3685 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3686 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3687 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3688 "changed".
3689
3690 * xgselect.c: Add defined (HAVE_GSETTINGS).
3691 (xgselect_initialize): Ditto.
3692
3693 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3694 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3695 xg_select.
3696
bbc6b304
PE
36972011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 * eval.c (struct backtrace): Simplify and port the data structure.
3700 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3701 signed bit field, as this assumption is not portable and it makes
3702 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3703 "char debug_on_exit : 1" as this is not portable either; instead,
3704 use the portable "unsigned int debug_on_exit : 1". Remove unused
3705 member evalargs. Remove obsolete comments about cc bombing out.
3706
9851bfc5
JD
37072011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3708
51bb811f 3709 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3710 Let HAVE_GSETTINGS override HAVE_GCONF.
3711 (store_monospaced_changed): New function.
3712 (EMACS_SETTINGS): A new type derived from GObject to handle
3713 GSettings notifications.
3714 (emacs_settings_constructor, emacs_settings_get_property)
3715 (emacs_settings_set_property, emacs_settings_class_init):
3716 New functions.
3717 (gsettings_client, gsettings_obj): New variables.
3718 (GSETTINGS_SCHEMA): New define.
3719 (something_changedCB): Call store_monospaced_changed.
3720 (init_gsettings): New function.
3721 (xsettings_initialize): Call init_gsettings.
3722 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3723 to NULL.
3724
640c8776 3725 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3726 GCONF_CFLAGS/LIBS.
3727
5386012d
MR
37282011-06-29 Martin Rudalics <rudalics@gmx.at>
3729
3730 * window.c (resize_root_window, grow_mini_window)
3731 (shrink_mini_window): Rename Qresize_root_window to
3732 Qwindow_resize_root_window and Qresize_root_window_vertically to
3733 Qwindow_resize_root_window_vertically.
3734
f13e0b08
PE
37352011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3736
3737 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3738
94515237
JB
37392011-06-27 Juanma Barranquero <lekktu@gmail.com>
3740
3741 * makefile.w32-in: Redesign dependencies so they reflect more
3742 clearly which files are directly included by each source file,
3743 and not through other includes.
3744
e43b6e43
MR
37452011-06-27 Martin Rudalics <rudalics@gmx.at>
3746
3747 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3748 (sort_overlays, overlay_strings): When an overlay's clone number
3749 matches the window's clone number process the overlay even if
3750 the overlay's window property doesn't match the current window.
3751
d68443dc
MR
3752 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3753 (Fwindow_hchild): Rename to Fwindow_left_child.
3754 (Fwindow_next): Rename to Fwindow_next_sibling.
3755 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3756 (resize_window_check): Rename to window_resize_check.
3757 (resize_window_apply): Rename to window_resize_apply.
3758 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3759 (Fdelete_other_windows_internal, resize_frame_windows)
3760 (Fsplit_window_internal, Fdelete_window_internal)
3761 (grow_mini_window, shrink_mini_window)
3762 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3763
c7e73be5
JD
37642011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3765
3766 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3767 (emacs_fixed_set_min_size): Remove.
3768 (emacs_fixed_new): Take frame as argument.
3769
3770 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3771 (_EmacsFixedPrivate): Remove minwidth/height.
3772 Add struct frame *f.
3773 (emacs_fixed_init): Initialize priv->f.
3774 (get_parent_class, emacs_fixed_set_min_size): Remove.
3775 (emacs_fixed_new): Set priv->f to argument.
3776 (emacs_fixed_get_preferred_width)
3777 (emacs_fixed_get_preferred_height): Use min_width/height from
3778 frames size_hint to set minimum and natural (Bug#8919).
3779 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3780 and use min_width/height from frames size_hint to set
3781 min_width/height (Bug#8919).
3782
3783 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3784 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3785 Fix indentation.
c7e73be5 3786
cf99dcf8
EZ
37872011-06-26 Eli Zaretskii <eliz@gnu.org>
3788
3789 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3790 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3791 called at ZV.
3792
029529ac
CY
37932011-06-26 Chong Yidong <cyd@stupidchicken.com>
3794
3795 * process.c (wait_reading_process_output): Bypass select if
3796 waiting for a cell while ignoring keyboard input, and input is
3797 pending. Suggested by Jan Djärv (Bug#8869).
3798
7a7ef429
PE
37992011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3800
3801 Use gnulib's dup2 module instead of rolling our own.
3802 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3803
11fdef7d 38042011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3805
3806 * dispnew.c (scrolling_window): Before scrolling, turn off a
3807 mouse-highlight in the window being scrolled.
3808
cd3520a4
JB
38092011-06-24 Juanma Barranquero <lekktu@gmail.com>
3810
3811 Move DEFSYM to lisp.h and use everywhere.
3812
3813 * character.h (DEFSYM): Move declaration...
3814 * lisp.h (DEFSYM): ...here.
3815
3816 * gnutls.c:
3817 * minibuf.c:
3818 * w32menu.c:
3819 * w32proc.c:
3820 * w32select.c: Don't include character.h.
3821
3822 * alloc.c (syms_of_alloc):
3823 * buffer.c (syms_of_buffer):
3824 * bytecode.c (syms_of_bytecode):
3825 * callint.c (syms_of_callint):
3826 * casefiddle.c (syms_of_casefiddle):
3827 * casetab.c (init_casetab_once):
3828 * category.c (init_category_once, syms_of_category):
3829 * ccl.c (syms_of_ccl):
3830 * cmds.c (syms_of_cmds):
3831 * composite.c (syms_of_composite):
3832 * dbusbind.c (syms_of_dbusbind):
3833 * dired.c (syms_of_dired):
3834 * dispnew.c (syms_of_display):
3835 * doc.c (syms_of_doc):
3836 * editfns.c (syms_of_editfns):
3837 * emacs.c (syms_of_emacs):
3838 * eval.c (syms_of_eval):
3839 * fileio.c (syms_of_fileio):
3840 * fns.c (syms_of_fns):
3841 * frame.c (syms_of_frame):
3842 * fringe.c (syms_of_fringe):
3843 * insdel.c (syms_of_insdel):
3844 * keymap.c (syms_of_keymap):
3845 * lread.c (init_obarray, syms_of_lread):
3846 * macros.c (syms_of_macros):
3847 * msdos.c (syms_of_msdos):
3848 * print.c (syms_of_print):
3849 * process.c (syms_of_process):
3850 * search.c (syms_of_search):
3851 * sound.c (syms_of_sound):
3852 * syntax.c (init_syntax_once, syms_of_syntax):
3853 * terminal.c (syms_of_terminal):
3854 * textprop.c (syms_of_textprop):
3855 * undo.c (syms_of_undo):
3856 * w32.c (globals_of_w32):
3857 * window.c (syms_of_window):
3858 * xdisp.c (syms_of_xdisp):
3859 * xfaces.c (syms_of_xfaces):
3860 * xfns.c (syms_of_xfns):
3861 * xmenu.c (syms_of_xmenu):
3862 * xsettings.c (syms_of_xsettings):
3863 * xterm.c (syms_of_xterm): Use DEFSYM.
3864
4228cf16
TZ
38652011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3866
cd3520a4 3867 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3868
7fcccf1e
PE
38692011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3870
7efb4e0e
PE
3871 Integer and buffer overflow fixes (Bug#8873).
3872
ff5844ad
PE
3873 * print.c (printchar, strout): Check for string overflow.
3874 (PRINTPREPARE, printchar, strout):
3875 Don't set size unless allocation succeeds.
3876
90532f02
PE
3877 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3878 for sizes. Check for string overflow more accurately.
3879 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3880
6d84508d
PE
3881 * macros.c: Integer and buffer overflow fixes.
3882 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3883 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3884 Use ptrdiff_t, not int, for sizes.
3885 Don't increment bufsize until after realloc succeeds.
3886 Check for size-calculation overflow.
3887 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3888
437b2cb4
PE
3889 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3890
8b9ac8b4
PE
3891 * lread.c: Integer overflow fixes.
3892 (read_integer): Radix is now EMACS_INT, not int,
3893 to improve quality of diagnostics for out-of-range radices.
3894 Calculate buffer size correctly for out-of-range radices.
3895 (read1): Check for integer overflow in radices, and in
3896 read-circle numbers.
82cb60d3
PE
3897 (read_escape): Avoid int overflow.
3898 (Fload, openp, read_buffer_size, read1)
3899 (substitute_object_recurse, read_vector, read_list, map_obarray):
3900 Use ptrdiff_t, not int, for sizes.
3901 (read1): Use EMACS_INT, not int, for sizes.
20270765 3902 Check for size overflow.
8b9ac8b4 3903
7fcccf1e
PE
3904 * image.c (cache_image): Check for size arithmetic overflow.
3905
bfbbd7e7
PE
3906 * lread.c: Integer overflow issues.
3907 (saved_doc_string_size, saved_doc_string_length)
3908 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3909 Now ptrdiff_t, not int.
3910 (read1): Don't assume doc string length fits in int. Check for
3911 out-of-range doc string lengths.
3912 (read_list): Don't assume file position fits in int.
39019e54 3913 (read_escape): Check for hex character overflow.
bfbbd7e7 3914
4e323265
LL
39152011-06-22 Leo Liu <sdl.web@gmail.com>
3916
3917 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3918 Move to minibuffer.el.
3919
85fece3e
PE
39202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3921
20b84ce9 3922 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3923 The following patches are for when GLYPH_DEBUG && !XASSERT.
3924 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3925 * dispnew.c (flush_stdout):
3926 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3927 Mark as externally visible.
3928 * dispnew.c (check_window_matrix_pointers): Now static.
3929 * dispnew.c (window_to_frame_vpos):
3930 * xfns.c (unwind_create_frame):
3931 * xterm.c (x_check_font): Remove unused local.
3932 * scroll.c (CHECK_BOUNDS):
3933 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3934 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3935 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3936 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3937 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3938 Now static.
3939 (debug_method_add): Use va_list and vsprintf rather than relying
3940 on undefined behavior with wrong number of arguments.
3941 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3942 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3943 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3944 since we're not interested in debugging glyphs with old libraries.
3945 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3946 GCC 4.6.0's static checking.
3947
0766b489
PE
39482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3949
31fd4b32
PE
3950 Integer overflow and signedness fixes (Bug#8873).
3951 A few related buffer overrun fixes, too.
3952
b79e8648
PE
3953 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3954
0766b489
PE
3955 * dispextern.h (struct face.stipple):
3956 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3957 (x_bitmap_mask, x_allocate_bitmap_record)
3958 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3959 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3960 (x_create_bitmap_from_xpm_data):
3961 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3962 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3963 (.bitmaps_last):
3964 * xfaces.c (load_pixmap):
3965 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3966 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3967 (.bitmaps_last, struct x_output.icon_bitmap):
3968 Use ptrdiff_t, not int, for bitmap indexes.
3969 (x_allocate_bitmap_record): Check for size overflow.
3970 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3971
b081724f
PE
3972 Use ptrdiff_t, not int, for overlay counts.
3973 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3974 * editfns.c (overlays_around, get_pos_property):
3975 * textprop.c (get_char_property_and_overlay):
3976 * xdisp.c (next_overlay_change, note_mouse_highlight):
3977 * xfaces.c (face_at_buffer_position):
21514da7
PE
3978 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3979 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3980 (Fnext_overlay_change, Fprevious_overlay_change)
3981 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3982 Use ptrdiff_t, not int, for sizes.
21514da7 3983 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3984
3de73e5e
PE
3985 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3986
2606c57b
PE
3987 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3988 (x_session_initialize): Do not assume string length fits in int.
3989
aaafe47a
PE
3990 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3991 This is unlikely, but can occur if DPI is outlandish.
3992
2674ddc8 3993 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3994 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3995
28154962
PE
3996 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3997 * xrdb.c (magic_file_p, search_magic_path):
3998 Omit last arg SUFFIX; it was always 0. All callers changed.
3999 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4000
7de51af5
PE
4001 * xfont.c (xfont_match): Avoid need for strlen.
4002
25ed6cc3
PE
4003 * xfns.c: Don't assume strlen fits in int.
4004 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4005
4eab31dd
PE
4006 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4007 not unsigned long, as we prefer signed integers. All callers changed.
4008 Detect integer overflow in repeat count.
4009 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4010 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4011
171e2a58
PE
4012 * termcap.c: Don't assume sizes fit in int and never overflow.
4013 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4014 (gobble_line): Check for size-calculation overflow.
4015
ad39faca 4016 * minibuf.c (Fread_buffer):
6e5bb2dc 4017 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4018 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4019 Don't assume string length fits in int.
4020
52c61c22 4021 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4022 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4023
b5b8c9e5
PE
4024 * font.c: Don't assume string length fits in int.
4025 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4026 Use ptrdiff_t, not int.
ccd6111c
PE
4027 (font_intern_prop): Don't assume string length fits in int.
4028 Don't assume integer property fits in fixnum.
4029 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4030
882f0d81 4031 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4032 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4033 Reformulate so as not to need the command string.
4034 Invoke gzip -cd rather than gunzip, as it's more portable.
4035 (lock_info_type, lock_file_1, lock_file):
4036 Don't assume pid_t and time_t fit in unsigned long.
4037 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4038 (current_lock_owner): Prefer signed type for sizes.
4039 Use memcpy, not strncpy, where memcpy is what is really wanted.
4040 Don't assume (via atoi) that time_t and pid_t fit in int.
4041 Check for time_t and/or pid_t out of range, e.g., via a network share.
4042 Don't alloca where an auto var works fine.
4043
93f4cf88
PE
4044 * fileio.c: Fix some integer overflow issues.
4045 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4046 Don't assume string length fits in int.
4047 (directory_file_name): Don't assume string length fits in long.
4048 (make_temp_name): Don't assume pid fits in int, or that its print
4049 length is less than 20.
4050
f3e92b69
PE
4051 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4052
1bfdaf10
PE
4053 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4054
35016e9a
PE
4055 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4056
3d1e65a1
PE
4057 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4058 We prefer signed integers, even for size calculations.
4059
0b963a93
PE
4060 * emacs.c: Don't assume string length fits in 'int'.
4061 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4062 (main): Don't invoke strlen when not needed.
4063
573f4b54
PE
4064 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4065 (XD_DEBUG_MESSAGE): Don't waste a byte.
4066
989f33ba
PE
4067 * callproc.c (getenv_internal_1, getenv_internal)
4068 (Fgetenv_internal):
965d34eb
PE
4069 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4070
e4d29b33
PE
4071 * lread.c (invalid_syntax): Omit length argument.
4072 All uses changed. This doesn't fix a bug, but it simplifies the
4073 code away from its former Hollerith-constant appearance, and it's
4074 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4075 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4076
eb49b136
PE
4077 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4078 This didn't break anything, but it didn't help either.
4079 It's confusing to put a bogus integer in a place where the actual
4080 value does not matter.
9f62aeb1 4081 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4082 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4083
15375a22
PE
4084 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4085 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4086 implementation.
b61cc01c
PE
4087 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4088 We prefer signed types, and the value cannot exceed the EMACS_INT
4089 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4090 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4091 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4092 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4093
53b2623d
PE
4094 * indent.c (sane_tab_width): New function.
4095 (current_column, scan_for_column, Findent_to, position_indentation)
4096 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4097 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4098
51cab52b 4099 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4100
f2ed8a70
PE
4101 * lisp.h (lint_assume): New macro.
4102 * composite.c (composition_gstring_put_cache):
4103 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4104
abe80cc6
PE
4105 * editfns.c, insdel.c:
4106 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4107
b02c740e
PE
4108 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4109
ebc96716
PE
4110 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4111
b4e50fa0 4112 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4113 Use much-faster test for byte-length change.
311d5d7c 4114 Don't assume string byte-length fits in 'int'.
a4cf38e4 4115 Check that character arg fits in 'int'.
85461888 4116 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4117
c0c1ee9f
PE
4118 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4119
a498d7f4
PE
4120 * fns.c (concat): Catch string overflow earlier.
4121 Do not rely on integer wraparound.
4122
51cab52b
PE
4123 * dispextern.h (struct it.overlay_strings_charpos)
4124 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4125 * xdisp.c (forward_to_next_line_start)
4126 (back_to_previous_visible_line_start)
4127 (reseat_at_next_visible_line_start, next_element_from_buffer):
4128 Don't arbitrarily truncate the value of 'selective' to int.
4129
76031fad
PE
4130 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4131
5eb55db9
PE
4132 * composite.c: Don't truncate sizes to 'int'.
4133 (composition_gstring_p, composition_reseat_it)
4134 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4135 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4136 not EMACS_UINT, for indexes.
5eb55db9 4137
0703a717
PE
4138 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4139
d6202519
PE
4140 * buffer.c: Include <verify.h>.
4141 (struct sortvec.priority, struct sortstr.priority):
8961a454 4142 Now EMACS_INT, not int.
c20998a7 4143 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4144 (struct sortstr.size, record_overlay_string)
4145 (struct sortstrlist.size, struct sortlist.used):
4146 Don't truncate size to int.
4147 (record_overlay_string): Check for size-calculation overflow.
d6202519 4148 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4149
d5a19415
JM
41502011-06-22 Jim Meyering <meyering@redhat.com>
4151
029529ac 4152 Don't leak an XBM-image-sized buffer
d5a19415
JM
4153 * image.c (xbm_load): Free the image buffer after using it.
4154
a9041e6c
PE
41552011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4156
4157 Port to Sun C.
4158 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4159 that Sun C diagnosed.
4160 * fns.c (secure_hash): Fix pointer signedness issue.
4161 * intervals.c (static_offset_intervals): New function.
4162 (offset_intervals): Use it.
4163
7f3f739f
LL
41642011-06-21 Leo Liu <sdl.web@gmail.com>
4165
4166 * deps.mk (fns.o):
4167 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4168 sha512.h.
4169
4170 * fns.c (secure_hash): Rename from crypto_hash_function and change
4171 the first arg to accept symbols.
5b66d427 4172 (Fsecure_hash): New primitive.
7f3f739f
LL
4173 (syms_of_fns): New symbols.
4174
76147d94
DD
41752011-06-20 Deniz Dogan <deniz@dogan.se>
4176
4177 * process.c (Fset_process_buffer): Clarify return value in
4178 docstring.
4179
7d7d0045
CY
41802011-06-18 Chong Yidong <cyd@stupidchicken.com>
4181
4182 * dispnew.c (add_window_display_history): Use BVAR.
4183
4184 * xdisp.c (debug_method_add): Use BVAR.
4185 (check_window_end, dump_glyph_matrix, dump_glyph)
4186 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4187
4188 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4189 Likewise.
4190
4191 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4192 check till after the cache is created in init_frame_faces.
4193
ff2bc410
SM
41942011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4195
4196 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4197
28177add
PE
41982011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4199
dd3482fe
PE
4200 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4201 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4202 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4203
393d71f3 4204 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4205 * fileio.c (Finsert_file_contents):
4206 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4207 Remove the old (too-loose) buffer overflow checks.
4208 They weren't needed, since make_gap checks for buffer overflow.
4209 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4210 The old code merely checked for Emacs fixnum overflow, and relied
4211 on undefined (wraparound) behavior. The new code avoids undefined
4212 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4213
2e6813b0 4214 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4215 Tune. Don't use wider integers than needed. Don't use alloca.
4216 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4217
599a9e4f
PE
4218 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4219
99561444
PE
4220 * insdel.c, lisp.h (buffer_overflow): New function.
4221 (insert_from_buffer_1, replace_range, replace_range_2):
4222 * insdel.c (make_gap_larger):
4223 * editfns.c (Finsert_char):
4224 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4225
28177add
PE
4226 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4227
e69dafad
PE
42282011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4229
a7af7fde 4230 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4231
b1c46f02
PE
4232 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4233 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4234
e69dafad
PE
4235 * fileio.c: Don't assume EMACS_INT fits in off_t.
4236 (emacs_lseek): New static function.
4237 (Finsert_file_contents, Fwrite_region): Use it.
4238 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4239
566684ea
PE
4240 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4241
e6966cd6
PE
4242 * fns.c: Don't overflow int when computing a list length.
4243 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4244 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4245 truncation on 64-bit hosts. Check for QUIT every
4246 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4247 faster and is responsive enough.
4248 (Flength): Report an error instead of overflowing an integer.
4249 (Fsafe_length): Return a float if the value is not representable
4250 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4251 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4252 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4253
dd0b0efb
PE
4254 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4255 (header_size, word_size): New constants.
4256 (allocate_vectorlike): Don't check size overflow here.
4257 (allocate_vector): Check it here instead, since this is the only
4258 caller of allocate_vectorlike that could cause overflow.
4259 Check that the new vector's length is representable as a fixnum.
4260
86fe5cfe
PE
4261 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4262 The previous code was bogus. For example, next_almost_prime (32)
4263 returned 39, which is undesirable as it is a multiple of 3; and
4264 next_almost_prime (24) returned 25, which is a multiple of 5 so
4265 why was the code bothering to check for multiples of 7?
4266
80e88859
PE
4267 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4268
4a2f0ad6
PE
4269 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4270
f66c7cf8
PE
4271 Variadic C functions now count arguments with ptrdiff_t.
4272 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4273 Back then I didn't know that the Emacs coding style prefers signed int.
4274 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4275 were being counted with int, which may truncate counts on 64-bit
4276 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4277 * lisp.h (struct Lisp_Subr.function.aMANY)
4278 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4279 Arg counts are now ptrdiff_t, not size_t.
4280 All variadic functions and their callers changed accordingly.
4281 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4282 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4283 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4284 * callint.c (Fcall_interactively): Check arg count for overflow,
4285 to avoid potential buffer overrun. Use signed char, not 'int',
4286 for 'varies' array, so that we needn't bother to check its size
4287 calculation for overflow.
4288 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4289 * eval.c (apply_lambda):
4290 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4291 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4292 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4293
a1759b76
PE
4294 * callint.c (Fcall_interactively): Don't use index var as event count.
4295
d96be9fc
PE
4296 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4297 * mem-limits.h (SIZE): Remove; no longer used.
4298
a690a978 4299 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4300
578c21e6
PE
4301 Remove unnecessary casts.
4302 * xterm.c (x_term_init):
4303 * xfns.c (x_set_border_pixel):
4304 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4305 These aren't needed now that we assume ANSI C.
4306
96f53c6c
PE
4307 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4308 It's more likely to cause problems (due to unsigned overflow)
4309 than to cure them.
4310
83c77d31
PE
4311 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4312
ee2079f1
PE
4313 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4314
6da65536
PE
4315 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4316
7147c4a4
PE
4317 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4318
193e32d9
PE
4319 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4320
e5533da6
PE
4321 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4322
9910e595
PE
4323 GLYPH_CODE_FACE returns EMACS_INT, not int.
4324 * dispextern.h (merge_faces):
4325 * xfaces.c (merge_faces):
01103c44
PE
4326 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4327 Don't assume EMACS_INT fits in int.
9910e595 4328
2638320e
PE
4329 * character.h (CHAR_VALID_P): Remove unused parameter.
4330 * fontset.c, lisp.h, xdisp.c: All uses changed.
4331
045eb8d9
PE
4332 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4333
c1f134b5
PE
4334 * fns.c (concat): Minor tuning based on overflow analysis.
4335 This doesn't fix any bugs. Use int to hold character, instead
4336 of constantly refetching from Emacs object. Use XFASTINT, not
4337 XINT, for value known to be a character. Don't bother comparing
4338 a single byte to 0400, as it's always less.
4339
395fcb93 4340 * floatfns.c (Fexpt):
327eeec8
PE
4341 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4342
abbd3d23
PE
4343 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4344 for characters.
4345
684a03ef
PE
4346 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4347
0fed43f3
PE
4348 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4349 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4350 incorrectly succeed when S was a string, because 4294967386 was
4351 truncated before it was used.
4352
8fd02eb7
PE
4353 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4354 Otherwise, an out-of-range integer could cause undefined behavior
4355 on a 64-bit host.
4356
f8c86b69
PE
4357 * composite.c: Use int, not EMACS_INT, for characters.
4358 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4359 EMACS_INT, for values that are known to be in character range.
4360 This doesn't fix any bugs but is the usual style inside Emacs and
4361 may generate better code on 32-bit machines.
4362
34206dd2
PE
4363 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4364 This is for reasons similar to the recent CHAR_STRING fix.
4365 * charset.c (Fencode_char): Check that character arg is actually
4366 a character. Pass an int to ENCODE_CHAR.
4367 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4368 wider than 'int', as a compile-time check to prevent future regressions
4369 in this area.
4370
c5958d4c 4371 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4372
4373 Make sure a 64-bit char is never passed to CHAR_STRING.
4374 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4375 by silently ignoring the top 32 bits, allowing some values
4376 that were far too large to be valid characters.
4377 * character.h: Include <verify.h>.
4378 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4379 arguments are no wider than unsigned, as a compile-time check
4380 to prevent future regressions in this area.
4381 * data.c (Faset):
01103c44 4382 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4383 (Fsubst_char_in_region):
4384 * fns.c (concat):
4385 * xdisp.c (decode_mode_spec_coding):
4386 Adjust to CHAR_STRING's new requirement.
4387 * editfns.c (Finsert_char, Fsubst_char_in_region):
4388 * fns.c (concat): Check that character args are actually
4389 characters. Without this test, these functions did the wrong
4390 thing with wildly out-of-range values on 64-bit hosts.
4391
d37ca623
PE
4392 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4393 These casts should not be needed on 32-bit hosts, either.
4394 * keyboard.c (read_char):
4395 * lread.c (Fload): Remove casts to unsigned.
4396
ea204efb
PE
4397 * lisp.h (UNSIGNED_CMP): New macro.
4398 This fixes comparison bugs on 64-bit hosts.
4399 (ASCII_CHAR_P): Use it.
4400 * casefiddle.c (casify_object):
01103c44 4401 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4402 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4403 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4404 * dispextern.h (FACE_FROM_ID):
4405 * keyboard.c (read_char): Use UNSIGNED_CMP.
4406
41cb286c
PE
4407 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4408 not to EMACS_INT, to avoid GCC warning.
4409
4a1b9832
PE
4410 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4411
55daad71
PE
4412 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4413 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4414 isn't needed on 32-bit machines.
8f95c75c 4415
01103c44
PE
4416 * buffer.c (Fgenerate_new_buffer_name):
4417 Use EMACS_INT for count, not int.
0ceccced 4418 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4419
4420 * data.c (Qcompiled_function): Now static.
4421
c6f072e7
PE
4422 * window.c (window_body_lines): Now static.
4423
20ce5912
PE
4424 * image.c (gif_load): Rename local to avoid shadowing.
4425
9c4c5f81
PE
4426 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4427 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4428 * alloc.c (make_save_value): Integer argument is now of type
4429 ptrdiff_t, not int.
4430 (mark_object): Use ptrdiff_t, not int.
4431 * lisp.h (pD): New macro.
4432 * print.c (print_object): Use it.
4433
c0c5c8ae
PE
4434 * alloc.c: Use EMACS_INT, not int, to count objects.
4435 (total_conses, total_markers, total_symbols, total_vector_size)
4436 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4437 (total_free_floats, total_floats, total_free_intervals)
4438 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4439 Now EMACS_INT, not int. All uses changed.
4440 (Fgarbage_collect): Compute overall total using a double, so that
4441 integer overflow is less likely to be a problem. Check for overflow
4442 when converting back to an integer.
5a25e253
PE
4443 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4444 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4445 These were 'int' variables that could overflow on 64-bit hosts;
4446 they were never used, so remove them instead of repairing them.
211a0b2a 4447 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4448 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4449 Previously, this ceilinged at INT_MAX, but that doesn't work on
4450 64-bit machines.
e46bb31a 4451 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4452
c78baabf 4453 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4454 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4455 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4456 when a (possibly-narrower) signed value would do just as well.
4457 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4458
c9d624c6
PE
4459 * alloc.c: Catch some string size overflows that we were missing.
4460 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4461 for convenience in STRING_BYTES_MAX.
4462 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4463 The definition here is exact; the one in lisp.h was approximate.
4464 (allocate_string_data): Check for string overflow. This catches
4465 some instances we weren't catching before. Also, it catches
4466 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4467 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4468 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4469
c9d624c6
PE
4470 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4471 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4472 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4473
353032ce
PE
4474 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4475
2bccce07
PE
4476 * alloc.c (Fmake_string): Check for out-of-range init.
4477
0ac30604
SM
44782011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4479
4480 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4481
c195f2de
JD
44822011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4483
4484 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4485 xg_get_default_scrollbar_width.
4486
4487 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4488 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4489 (style_changed_cb): Call update_theme_scrollbar_width and call
4490 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4491 all frames (Bug#8505).
4492 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4493 Call gtk_window_set_resizable if HAVE_GTK3.
4494 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4495 and height if HAVE_GTK3 (Bug#8505).
4496 (scroll_bar_width_for_theme): New variable.
4497 (update_theme_scrollbar_width): New function.
4498 (xg_get_default_scrollbar_width): Move code to
4499 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4500 (xg_initialize): Call update_theme_scrollbar_width.
4501
4502 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4503
4504 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4505
e10ac9f1
MR
45062011-06-12 Martin Rudalics <rudalics@gmx.at>
4507
4508 * frame.c (make_frame): Call other_buffer_safely instead of
4509 other_buffer.
4510
4511 * window.c (temp_output_buffer_show): Call display_buffer with
4512 second argument Vtemp_buffer_show_specifiers and reset latter
4513 immediately after the call.
4514 (Vtemp_buffer_show_specifiers): New variable.
4515 (auto_window_vscroll_p, next_screen_context_lines)
4516 (Vscroll_preserve_screen_position): Remove leading asterisks from
4517 doc-strings.
4518
2d3c217e 45192011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4520
7b7f97e8 4521 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4522 * buffer.c (Qclone_number): Remove for now, as it's unused.
4523 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4524 (record_buffer): Remove unused local.
4525 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4526 (set_frame_buffer_list): Remove; unused.
4527 * frame.h (other_visible_frames): Remove decl.
4528 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4529 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4530 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4531 if HAVE_GPM.
4532 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4533 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4534 Define only if HAVE_GPM.
4535 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4536 (update_hints_inhibit): Remove; never set. All uses removed.
4537 * widgetprv.h (emacsFrameClassRec): Remove decl.
4538 * window.c (delete_deletable_window): Now returns void, since it
4539 wasn't returning anything.
4540 (compare_window_configurations): Remove unused locals.
4541 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4542 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4543 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4544 the same widths as pointers. This follows up on the 2011-05-06 patch.
4545 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4546 * xterm.h: Likewise.
4547 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4548
1384b89e
JB
45492011-06-12 Juanma Barranquero <lekktu@gmail.com>
4550
4551 * makefile.w32-in: Update dependencies.
4552 (LISP_H): Add lib/intprops.h.
4553
1100a63c
CY
45542011-06-11 Chong Yidong <cyd@stupidchicken.com>
4555
4556 * image.c (gif_load): Add animation frame delay to the metadata.
4557 (syms_of_image): Use DEFSYM. New symbol `delay'.
4558
6198ccd0
MR
45592011-06-11 Martin Rudalics <rudalics@gmx.at>
4560
4561 * window.c (delete_deletable_window): Re-add.
4562 (Fset_window_configuration): Rewrite to handle dead buffers and
4563 consequently deletable windows.
4564 (window_tree, Fwindow_tree): Remove. Supply functionality in
4565 window.el.
4566 (compare_window_configurations): Simplify code.
4567
b6e3633c
AS
45682011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4569
1ab0dee5
AS
4570 * image.c (imagemagick_load_image): Fix type mismatch.
4571 (Fimagemagick_types): Likewise.
4572
b6e3633c
AS
4573 * window.h (replace_buffer_in_windows): Declare.
4574
9397e56f
MR
45752011-06-11 Martin Rudalics <rudalics@gmx.at>
4576
4577 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4578 Qclone_number. Remove external declaration of Qdelete_window.
4579 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4580 code.
640c8776
SM
4581 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4582 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4583 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4584 buffer list implementation.
4585 (other_buffer_safely): New function.
4586 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4587 calls to replace_buffer_in_windows and
4588 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4589 if allowed.
4590 (record_buffer): Inhibit quitting and rewrite using quittable
4591 functions. Run Qbuffer_list_update_hook if allowed.
4592 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4593 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4594 Move switch-to-buffer to window.el.
9397e56f
MR
4595 (bury-buffer): Move to window.el.
4596 (Vbuffer_list_update_hook): New variable.
4597
4598 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4599 section.
4600
4601 * window.h (resize_frame_windows): Move up in code.
4602 (Fwindow_frame): Remove EXFUN.
4603 (replace_buffer_in_all_windows): Remove prototype.
4604 (replace_buffer_in_windows_safely): Add prototype.
4605
4606 * window.c: Declare Qdelete_window static again. Move down
4607 declaration of select_count.
4608 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4609 (Fother_window): Move to window.el.
4610 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4611 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4612 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4613 window.el.
4614 (replace_buffer_in_windows): Implement by calling
4615 Qreplace_buffer_in_windows.
4616 (replace_buffer_in_all_windows): Remove with some functionality
4617 moved into replace_buffer_in_windows_safely.
4618 (replace_buffer_in_windows_safely): New function.
4619 (select_window_norecord, select_frame_norecord): Move in front
4620 of run_window_configuration_change_hook. Remove now obsolete
4621 declarations.
640c8776
SM
4622 (Fset_window_buffer): Rewrite doc-string.
4623 Call Qrecord_window_buffer.
9397e56f
MR
4624 (keys_of_window): Move binding for other-window to window.el.
4625
b50691aa
CY
46262011-06-11 Chong Yidong <cyd@stupidchicken.com>
4627
4628 * dispextern.h (struct image): Replace data member, whose int_val
4629 and ptr_val fields were not used by anything, with a single
4630 lisp_val object.
4631
4632 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4633 (gif_clear_image, gif_load, imagemagick_load_image)
4634 (gs_clear_image, gs_load): Callers changed.
4635
3f754b86
PE
46362011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4637
cca69397
PE
4638 * buffer.h: Include <time.h>, for time_t.
4639 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4640
109e28d0
PE
4641 Fix minor problems found by static checking.
4642
60737f02
PE
4643 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4644
4b66faf3
PE
4645 Make identifiers static if they are not used in other modules.
4646 * data.c (Qcompiled_function, Qframe, Qvector):
4647 * image.c (QimageMagick, Qsvg):
4648 * minibuf.c (Qmetadata):
4649 * window.c (resize_window_check, resize_root_window): Now static.
4650 * window.h (resize_window_check, resize_root_window): Remove decls.
4651
109e28d0
PE
4652 * window.c (window_deletion_count, delete_deletable_window):
4653 Remove; unused.
46a4ce9e
PE
4654 (window_body_lines): Now static.
4655 (Fdelete_other_windows_internal): Mark vars as initialized.
4656 Make sure 'resize_failed' is initialized.
4657 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4658 (resize_window_apply): Remove unused local.
4659 * window.h (delete_deletable_window): Remove decl.
4660
109e28d0 4661 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4662 (imagemagick_load_image): Fix pointer signedness problem by changing
4663 last arg from unsigned char * to char *. All uses changed.
4664 Also, fix a local for similar reasons.
4665 Remove unused locals. Remove locals to avoid shadowing.
4666 (fn_rsvg_handle_free): Remove; unused.
4667 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4668 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4669
3f754b86
PE
4670 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4671
2547adb1
CY
46722011-06-10 Chong Yidong <cyd@stupidchicken.com>
4673
4674 * image.c (gif_load): Fix omitted cast error introduced by
4675 2011-06-06 change.
4676
2c8e37d4
MR
46772011-06-10 Martin Rudalics <rudalics@gmx.at>
4678
4679 * window.h (resize_proportionally, orig_total_lines)
4680 (orig_top_line): Remove from window structure.
4681 (set_window_height, set_window_width, change_window_heights)
4682 (Fdelete_window): Remove prototypes.
4683 (resize_frame_windows): Remove duplicate declaration.
4684
440a42e3
EZ
46852011-06-10 Eli Zaretskii <eliz@gnu.org>
4686
4687 * window.h (resize_frame_windows, resize_window_check)
4688 (delete_deletable_window, resize_root_window)
4689 (resize_frame_windows): Declare prototypes.
4690
4691 * window.c (resize_window_apply): Make definition be "static" to
4692 match the prototype.
4693
562dd5e9
MR
46942011-06-10 Martin Rudalics <rudalics@gmx.at>
4695
4696 * window.c: Remove declarations of Qwindow_size_fixed,
4697 window_min_size_1, window_min_size_2, window_min_size,
4698 size_window, window_fixed_size_p, enlarge_window, delete_window.
4699 Remove static from declaration of Qdelete_window, it's
4700 temporarily needed by Fbury_buffer.
4701 (replace_window): Don't assign orig_top_line and
4702 orig_total_lines.
4703 (Fdelete_window, delete_window): Remove. Window deletion is
4704 handled by window.el.
640c8776
SM
4705 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4706 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4707 (Fdelete_other_windows): Remove. Deleting other windows is
4708 handled by window.el.
4709 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4710 handled in window.el.
4711 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4712 Window minimum sizes are handled in window.el.
4713 (shrink_windows, size_window, set_window_height)
4714 (set_window_width, change_window_heights, window_height)
4715 (window_width, CURBEG, CURSIZE, enlarge_window)
4716 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4717 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4718 handled in window.el.
4719 (make_dummy_parent): Rename to make_parent_window and give it a
4720 second argument horflag.
4721 (make_window): Don't set resize_proportionally any more.
4722 (Fsplit_window): Remove. Windows are split in window.el.
4723 (save_restore_action, save_restore_orig_size)
4724 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4725 Resize mini windows in window.el.
4726 (grow_mini_window, shrink_mini_window): Implement by calling
4727 Qresize_root_window_vertically, resize_window_check and
4728 resize_window_apply.
640c8776
SM
4729 (saved_window, Fset_window_configuration, save_window_save):
4730 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4731 resize_proportionally.
4732 (window_min_height, window_min_width): Move to window.el.
4733 (keys_of_window): Move bindings for delete-other-windows,
4734 split-window, delete-window and enlarge-window to window.el.
4735
4736 * buffer.c: Temporarily extern Qdelete_window.
4737 (Fbury_buffer): Temporarily call Qdelete_window instead of
4738 Fdelete_window (Fbury_buffer will move to window.el soon).
4739
4740 * frame.c (set_menu_bar_lines_1): Remove code handling
4741 orig_top_line and orig_total_lines.
4742
4743 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4744 set_window_height but set heights directly.
4745 (change_frame_size_1): Use resize_frame_windows.
4746
4747 * xdisp.c (init_xdisp): Don't use set_window_height but set
4748 heights directly.
4749
640c8776
SM
4750 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4751 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4752 run_window_configuration_change_hook.
4753
4754 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4755 instead of change_window_heights and run
4756 run_window_configuration_change_hook.
4757
1a13852e
MR
47582011-06-09 Martin Rudalics <rudalics@gmx.at>
4759
4760 * window.c (replace_window): Rename second argument REPLACEMENT to
4761 NEW. New third argument SETFLAG. Rewrite.
4762 (delete_window, make_dummy_parent): Call replace_window with
4763 third argument 1.
4764 (window_list_1): Move down in code.
4765 (run_window_configuration_change_hook): Move set_buffer part
4766 before select_frame_norecord part in order to unwind correctly.
4767 Rename count1 to count.
4768 (recombine_windows, delete_deletable_window, resize_root_window)
4769 (Fdelete_other_windows_internal)
4770 (Frun_window_configuration_change_hook, make_parent_window)
4771 (resize_window_check, resize_window_apply, Fresize_window_apply)
4772 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4773 (Fdelete_window_internal, Fresize_mini_window_internal):
4774 New functions.
1a13852e
MR
4775 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4776
f3d1777e
MR
47772011-06-08 Martin Rudalics <rudalics@gmx.at>
4778
496e208e
MR
4779 * window.h (window): Add some new members to window structure -
4780 normal_lines, normal_cols, new_total, new_normal, clone_number,
4781 splits, nest, prev_buffers, next_buffers.
4782 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4783 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4784
f3d1777e
MR
4785 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4786 Remove.
496e208e
MR
4787 (make_dummy_parent): Set new members of windows structure.
4788 (make_window): Move down in code. Handle new members of window
4789 structure.
4790 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4791 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4792 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4793 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4794 (Fset_window_next_buffers, Fset_window_clone_number):
4795 New functions.
496e208e
MR
4796 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4797 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4798 Doc-string fixes.
4799 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4800 Argument WINDOW can be now internal window too.
4801 (Fwindow_use_time): Move up in code.
4802 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4803 Rewrite doc-string.
4804 (Fset_window_configuration, saved_window)
4805 (Fcurrent_window_configuration, save_window_save): Handle new
4806 members of window structure.
b9e809c2
MR
4807 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4808 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4809 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4810 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4811 Qget_mru_window, Qresize_root_window,
4812 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4813 Qauto_buffer_name; staticpro them.
f3d1777e 4814
abde8f8c
MR
48152011-06-07 Martin Rudalics <rudalics@gmx.at>
4816
4817 * window.c (Fwindow_total_size, Fwindow_left_column)
4818 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4819 (Fwindow_list_1): New functions.
4820 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4821 (Fwindow_width, Fscroll_left, Fscroll_right):
4822 Use window_body_cols instead of window_box_text_cols.
4823 (delete_window, Fset_window_configuration):
4824 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4825 (delete_all_subwindows): Take a window as argument and not a
4826 structure. Rewrite.
190b47e6
MR
4827 (window_loop): Remove handling of GET_LRU_WINDOW and
4828 GET_LARGEST_WINDOW.
4829 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4830
4831 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4832 window_box_text_cols. delete_all_subwindows now takes a
4833 Lisp_Object as argument.
abde8f8c 4834
640c8776
SM
4835 * indent.c (compute_motion, Fcompute_motion):
4836 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4837
fa8a67e6
MR
4838 * frame.c (delete_frame): Call delete_all_subwindows with root
4839 window as argument.
4840
a54e3482
DC
48412011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4842
4843 * fns.c (Fputhash): Document return value.
4844
60002bf5
CY
48452011-06-06 Chong Yidong <cyd@stupidchicken.com>
4846
4847 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4848
0c671da6 48492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4850
b862a52a 4851 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4852
be44ca6c
PE
4853 Check for overflow when converting integer to cons and back.
4854 * charset.c (Fdefine_charset_internal, Fdecode_char):
4855 Use cons_to_unsigned to catch overflow.
4856 (Fencode_char): Use INTEGER_TO_CONS.
4857 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4858 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4859 * data.c (long_to_cons, cons_to_long): Remove.
4860 (cons_to_unsigned, cons_to_signed): New functions.
4861 These signal an error for invalid or out-of-range values.
4862 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4863 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4864 * font.c (Ffont_variation_glyphs):
4865 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4866 * lisp.h: Include <intprops.h>.
4867 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4868 (cons_to_signed, cons_to_unsigned): New decls.
4869 (long_to_cons, cons_to_long): Remove decls.
4870 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4871 (Fprimitive_undo): Use CONS_TO_INTEGER.
4872 * xfns.c (Fx_window_property): Likewise.
4873 * xselect.c: Include <limits.h>.
4874 (x_own_selection, selection_data_to_lisp_data):
4875 Use INTEGER_TO_CONS.
4876 (x_handle_selection_request, x_handle_selection_clear)
4877 (x_get_foreign_selection, Fx_disown_selection_internal)
4878 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4879 (lisp_data_to_selection_data): Use cons_to_unsigned.
4880 (x_fill_property_data): Use cons_to_signed.
4881 Report values out of range.
4882
d1f3d2af
PE
4883 Check for buffer and string overflow more precisely.
4884 * buffer.h (BUF_BYTES_MAX): New macro.
4885 * lisp.h (STRING_BYTES_MAX): New macro.
4886 * alloc.c (Fmake_string):
4887 * character.c (string_escape_byte8):
4888 * coding.c (coding_alloc_by_realloc):
4889 * doprnt.c (doprnt):
4890 * editfns.c (Fformat):
4891 * eval.c (verror):
4892 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4893 since they may not be the same number.
4894 * editfns.c (Finsert_char):
4895 * fileio.c (Finsert_file_contents):
4896 Likewise for BUF_BYTES_MAX.
4897
dd52fcea
PE
4898 * image.c: Use ptrdiff_t, not int, for sizes.
4899 (slurp_file): Switch from int to ptrdiff_t.
4900 All uses changed.
4901 (slurp_file): Check that file size fits in both size_t (for
4902 malloc) and ptrdiff_t (for sanity and safety).
4903
7f9bbdbb
PE
4904 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4905 if b->modtime has its maximal value.
4906
dfe18f82
PE
4907 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4908
84acfcf0
PE
4909 Don't assume time_t can fit into int.
4910 * buffer.h (struct buffer.modtime): Now time_t, not int.
4911 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4912 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4913
ccd9a01a
PE
4914 Minor fixes for signed vs unsigned integers.
4915 * character.h (MAYBE_UNIFY_CHAR):
4916 * charset.c (maybe_unify_char):
4917 * keyboard.c (read_char, reorder_modifiers):
4918 XINT -> XFASTINT, since the integer must be nonnegative.
4919 * ftfont.c (ftfont_spec_pattern):
4920 * keymap.c (access_keymap, silly_event_symbol_error):
4921 XUINT -> XFASTINT, since the integer must be nonnegative.
4922 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4923 since it makes no difference and we prefer signed.
4924 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4925 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4926 nonnegative.
4927
d6d100dd
SM
49282011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4929
4930 * window.h (Fwindow_frame): Declare.
4931
2b6148e4
PE
49322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4933
4934 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4935 (SPARE_MEMORY): Always define.
4936 (LARGE_REQUEST): Remove.
4937 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4938
f230ecc9
MR
49392011-06-06 Martin Rudalics <rudalics@gmx.at>
4940
727e958e
MR
4941 * lisp.h: Move EXFUNS for Fframe_root_window,
4942 Fframe_first_window and Fset_frame_selected_window to window.h.
4943
4944 * window.h: Move EXFUNS for Fframe_root_window,
4945 Fframe_first_window and Fset_frame_selected_window here from
4946 lisp.h.
4947
4948 * frame.c (Fwindow_frame, Fframe_first_window)
4949 (Fframe_root_window, Fframe_selected_window)
4950 (Fset_frame_selected_window): Move to window.c.
4951 (Factive_minibuffer_window): Move to minibuf.c.
4952 (Fother_visible_frames_p): New function.
4953
4954 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4955
f230ecc9
MR
4956 * window.c (decode_window, decode_any_window): Move up in code.
4957 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4958 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4959 (Fwindow_buffer): Move up and rewrite doc-string.
4960 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4961 (Fwindow_prev): New functions.
727e958e
MR
4962 (Fwindow_frame): Move here from frame.c. Accept any window as
4963 argument.
4964 (Fframe_root_window, Fframe_first_window)
4965 (Fframe_selected_window): Move here from frame.c. Accept frame
4966 or arbitrary window as argument. Update doc-strings.
4967 (Fminibuffer_window): Move up in code.
4968 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4969 (Fset_frame_selected_window): Move here from frame.c.
4970 Marginal rewrite.
727e958e
MR
4971 (Fselected_window, select_window, Fselect_window): Move up in
4972 code. Minor doc-string fixes.
f230ecc9 4973
4d09bcf6
PE
49742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4975
4976 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4977 Do not assume that spare memory exists; that assumption is valid
4978 only if SYSTEM_MALLOC.
4979 (LARGE_REQUEST): New macro, so that the issue of large requests
4980 is separated from the issue of spare memory.
4981
810928a2
AS
49822011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4983
172418ad
AS
4984 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4985 format. (Bug#8806)
4986
43f862f7
AS
4987 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4988
810928a2
AS
4989 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4990 before statements.
4991
a059fe24
JD
49922011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4993
4994 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4995
4996 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4997
4998 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4999 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5000
989bf368
JB
50012011-06-05 Juanma Barranquero <lekktu@gmail.com>
5002
5003 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5004
4b80f674
CY
50052011-06-04 Chong Yidong <cyd@stupidchicken.com>
5006
5007 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5008 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5009 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5010 New error handlers.
4b80f674
CY
5011 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5012 Obey Vx_select_enable_clipboard_manager. Catch errors in
5013 x_clipboard_manager_save (Bug#8779).
5014 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5015 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5016
99a33b77 50172011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5018
5019 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5020
99a33b77 50212011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5022
5023 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5024 in the current matrix if keep_current_p is non-zero.
5025
8264569d
EZ
50262011-06-04 Eli Zaretskii <eliz@gnu.org>
5027
5028 * bidi.c (bidi_level_of_next_char): Fix last change.
5029
57f97249
EZ
50302011-06-03 Eli Zaretskii <eliz@gnu.org>
5031
fec2107c 5032 Support bidi reordering of text covered by display properties.
57f97249 5033
fec2107c
EZ
5034 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5035 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5036 (bidi_cache_search, bidi_cache_iterator_state)
5037 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5038 (bidi_level_of_next_char, bidi_move_to_visually_next):
5039 Support character positions inside a run of characters covered by a
fec2107c
EZ
5040 display string.
5041 (bidi_paragraph_init, bidi_resolve_explicit_1)
5042 (bidi_level_of_next_char): Call bidi_fetch_char and
5043 bidi_fetch_char_advance instead of FETCH_CHAR and
5044 FETCH_CHAR_ADVANCE.
5045 (bidi_init_it): Initialize new members.
5046 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5047 definitions.
5048 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5049 instead of using explicit *_CHAR codes.
d6d100dd
SM
5050 (bidi_resolve_explicit, bidi_resolve_weak):
5051 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5052 bidirectional text is supported only in multibyte buffers.
5053 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5054 it to initialize the frame_window_p member of struct bidi_it.
5055 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5056 (bidi_resolve_explicit, bidi_resolve_weak)
5057 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5058 bidi_it->nchars is non-positive.
5059 (bidi_level_of_next_char): Don't try to lookup the cache for the
5060 next/previous character if nothing is cached there yet, or if we
5061 were just reseat()'ed to a new position.
c40e2fb2 5062
0e14fe90
EZ
5063 * xdisp.c (set_cursor_from_row): Set start and stop points
5064 according to the row's direction when priming the loop that looks
5065 for the glyph on which to display cursor.
5066 (single_display_spec_intangible_p): Function deleted.
5067 (display_prop_intangible_p): Reimplement to call
5068 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5069 Accept 3 additional arguments needed by handle_display_spec.
5070 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5071 values: lists, `(when COND...)' forms, etc.
5072 (single_display_spec_string_p): Support property values that are
5073 lists with the argument STRING its top-level element.
5074 (display_prop_string_p): Fix the condition for processing a
5075 property that is a list to be consistent with handle_display_spec.
fec2107c 5076 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5077 last portion of handle_display_prop.
5078 (compute_display_string_pos): Accept additional argument
5079 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5080 value of a `display' property is a "replacing spec".
5081 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5082 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5083 the display property, but just return a value indicating whether
5084 the display property will replace the characters it covers.
5085 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5086 frame_window_p members of struct bidi_it.
d6d100dd
SM
5087 (compute_display_string_pos, compute_display_string_end):
5088 New functions.
fec2107c
EZ
5089 (push_it): Accept second argument POSITION, where pop_it should
5090 jump to continue iteration.
5091 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5092
fec2107c
EZ
5093 * keyboard.c (adjust_point_for_property): Adjust the call to
5094 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5095
5096 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5097 (bidi_init_it): Update prototypes.
5098 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5099 (compute_display_string_pos, compute_display_string_end):
5100 Declare prototypes.
fec2107c
EZ
5101 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5102 EMACS_INT.
fc6f18ce 5103
40087514 51042011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5105
57f53182
PE
5106 Malloc failure behavior now depends on size of allocation.
5107 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5108 * lisp.h: Change signatures accordingly.
5109 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5110 All callers changed. (Bug#8762)
5111
5112 * gnutls.c: Use Emacs's memory allocators.
5113 Without this change, the gnutls library would invoke malloc etc.
5114 directly, which causes problems on non-SYNC_INPUT hosts, and which
5115 runs afoul of improving memory_full behavior. (Bug#8761)
5116 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5117 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5118 xfree instead of the default malloc, realloc, free.
5119 (Fgnutls_boot): No need to check for memory allocation failure,
5120 since xmalloc does that for us.
5121
ac32cd99 5122 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5123 * category.c (hash_get_category_set):
5124 * ccl.c (ccl_driver):
5125 * charset.c (Fdefine_charset_internal):
5126 * charset.h (struct charset.hash_index):
5127 * composite.c (get_composition_id, gstring_lookup_cache)
5128 (composition_gstring_put_cache):
5129 * composite.h (struct composition.hash_index):
5130 * dispextern.h (struct image.hash):
5131 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5132 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5133 (hashfn_equal, hashfn_user_defined, make_hash_table)
5134 (maybe_resize_hash_table, hash_lookup, hash_put)
5135 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5136 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5137 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5138 * image.c (make_image, search_image_cache, lookup_image)
5139 (xpm_put_color_table_h):
5140 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5141 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5142 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5143 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5144 * alloc.c (allocate_vectorlike):
5145 Check for overflow in vector size calculations.
5146 * ccl.c (ccl_driver):
5147 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5148 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5149 need to be updated by these changes.
40087514
PE
5150 * fns.c (make_hash_table, maybe_resize_hash_table):
5151 Check for integer overflow with large hash tables.
0de4bb68
PE
5152 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5153 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5154 (SXHASH_REDUCE): New macro.
5155 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5156 Use it instead of discarding useful hash info with large hash values.
5157 (sxhash_float): New function.
5158 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5159 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5160 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5161 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5162 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5163 Adjust signatures to match updated version of code.
5164 (consing_since_gc): Now EMACS_INT, since a single hash table can
5165 use more than INT_MAX bytes.
5166
698d32e2
DN
51672011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5168
5169 Make it possible to build with GCC-4.6+ -O2 -flto.
5170
5171 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5172
fd6fa53f
SM
51732011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5174
5175 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5176 Call minibuffer-inactive-mode.
5177
864db017
JB
51782011-05-31 Juanma Barranquero <lekktu@gmail.com>
5179
5180 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5181 Update dependencies.
5182
2ad0baf4
DN
51832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5184
5185 * data.c (init_data): Remove code for UTS, this system is not
5186 supported anymore.
5187
4fcc2638
DN
51882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5189
5190 Don't force ./temacs to start in terminal mode.
5191
5192 * frame.c (make_initial_frame): Initialize faces in all cases, not
5193 only when CANNOT_DUMP is defined.
5194 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5195
c56e0fd5
DN
51962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5197
5198 * dispnew.c (add_window_display_history): Use const for the string
5199 pointer. Remove declaration, not needed.
5200
333d54da 52012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5202
55d4c1b2 5203 Use 'inline', not 'INLINE'.
333d54da 5204 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5205 * alloc.c, fontset.c (INLINE): Remove.
5206 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5207 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5208 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5209 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5210 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5211
738db178
DN
52122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5213
5214 Make it possible to run ./temacs.
5215
5216 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5217 syms_of_callproc does the same thing. Remove test for
5218 "initialized", do it in the caller.
5219 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5220
620c53a6
SM
52212011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5222
5223 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5224 (read_minibuf): Use get_minibuffer.
5225 (syms_of_minibuf): Use DEFSYM.
5226 (Qmetadata): New var.
5227 * data.c (Qbuffer): Don't make it static.
5228 (syms_of_data): Use DEFSYM.
5229
e003a292
PE
52302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5231
5232 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5233 (CCL_CODE_MIN): New macro.
5234
ed008a6d
PE
52352011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5236
3687c2ef
PE
5237 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5238
ed008a6d
PE
5239 * eval.c (Qdebug): Now static.
5240 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5241 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5242 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5243
d66c4c7c
CY
52442011-05-29 Chong Yidong <cyd@stupidchicken.com>
5245
5246 * image.c: Various fixes to ImageMagick code comments.
5247 (Fimagemagick_types): Doc fix.
5248
5fbc2025
PE
52492011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5250
0196f88a
PE
5251 Minor fixes prompted by GCC 4.6.0 warnings.
5252
5253 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5254
5fbc2025
PE
5255 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5256 (x_clipboard_manager_save_all): Move extern decl to ...
5257 * xterm.h: ... here, so that it can be checked for consistency.
5258
1dd3c2d9
CY
52592011-05-29 Chong Yidong <cyd@stupidchicken.com>
5260
5261 * xselect.c (x_clipboard_manager_save_frame)
5262 (x_clipboard_manager_save_all): New functions.
5263 (Fx_clipboard_manager_save): Lisp function deleted.
5264
5265 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5266 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5267
5268 * xterm.h: Update prototype.
5269
5ba6571d
WX
52702011-05-28 William Xu <william.xwl@gmail.com>
5271
5272 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5273 exiting (Bug#8239).
5274
3eaff834
JM
52752011-05-28 Jim Meyering <meyering@redhat.com>
5276
e1900994 5277 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5278 * fns.c (to_uchar): Define.
5279 (crypto_hash_function): Use it to convert some newly-signed
5280 variables to unsigned, to avoid sign-extension bugs. For example,
5281 without this change, (md5 "truc") would evaluate to
5282 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5283 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5284 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5285
0f6990a7
PE
52862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5287
5288 Integer overflow fixes.
c8a9ca5a 5289
08686060
PE
5290 * dbusbind.c: Serial number integer overflow fixes.
5291 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5292 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5293 to hold a serial number that is too large for a fixnum.
5294 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5295 Check for serial numbers out of range. Decode any serial number
59568bf0 5296 that was so large that it became a float. (Bug#8722)
08686060 5297
2d1fc3c7
PE
5298 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5299 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5300 Use XFASTINT rather than XUINT when numbers are nonnegative.
5301 (xd_append_arg, Fdbus_method_return_internal):
5302 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5303 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5304 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5305 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5306 (Bug#8722)
2d1fc3c7 5307
c8a9ca5a
PE
5308 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5309
519e1d69
PE
5310 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5311
30569699
PE
5312 ccl: add integer overflow checks
5313 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5314 (IN_INT_RANGE): New macros.
5315 (ccl_driver): Use them to check for integer overflow when
5316 decoding a CCL program. Many of the new checks are whether XINT (x)
5317 fits in int; it doesn't always, on 64-bit hosts. The new version
5318 doesn't catch all possible integer overflows, but it's an
847044ea 5319 improvement. (Bug#8719)
30569699 5320
c11285dc
PE
5321 * alloc.c (make_event_array): Use XINT, not XUINT.
5322 There's no need for unsigned here.
5323
fdccd48e
PE
5324 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5325 This follows up to the 2011-05-06 change that substituted uintptr_t
5326 for EMACS_INT. This case wasn't caught back then.
5327
37910ab2
PE
5328 Rework Fformat to avoid integer overflow issues.
5329 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5330 now (part of C89). Include <verify.h>.
5331 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5332 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5333 (Fformat): Avoid the prepass trying to compute sizes; it was only
5334 approximate and thus did not catch overflow reliably. Instead, walk
5335 through the format just once, formatting and computing sizes as we go,
5336 checking for integer overflow at every step, and allocating a larger
5337 buffer as needed. Keep track separately whether the format is
5338 multibyte. Keep only the most-recently calculated precision, rather
5339 than them all. Record whether each argument has been converted to
5340 string. Use EMACS_INT, not int, for byte and char and arg counts.
5341 Support field widths and precisions larger than INT_MAX. Avoid
5342 sprintf's undefined behavior with conversion specifications such as %#d
5343 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5344 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5345 formatting out-of-range floating point numbers with int
9173deec 5346 formats. (Bug#8668)
37910ab2 5347
2e6578fb
PE
5348 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5349
0ae6bdee
PE
5350 * data.c: Avoid integer truncation in expressions involving floats.
5351 * data.c: Include <intprops.h>.
5352 (arith_driver): When there's an integer overflow in an expression
5353 involving floating point, convert the integers to floating point
5354 so that the resulting value does not suffer from catastrophic
5355 integer truncation. For example, on a 64-bit host (* 4
5356 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5357 Do not rely on undefined behavior after integer overflow.
5358
de883a70
PE
5359 merge count_size_as_multibyte, parse_str_to_multibyte
5360 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5361 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5362 Check for integer overflow.
5363 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5364 since it's now a duplicate of the other. This is more of
5365 a character than a buffer op, so better that it's in character.c.
5366 * fns.c, print.c: Adjust to above changes.
5367
2ff916cb
PE
53682011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5369
5370 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5371
f1b54466
PE
53722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5373
fb1ac845
PE
5374 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5375 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5376 (x_clipboard_manager_save): Now static.
5377 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5378
f1b54466
PE
5379 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5380 (crypto_hash_function): Now static.
5381 Fix pointer signedness problems. Avoid unnecessary initializations.
5382
a9f737ee
CY
53832011-05-27 Chong Yidong <cyd@stupidchicken.com>
5384
5385 * termhooks.h (Vselection_alist): Make it terminal-local.
5386
5387 * terminal.c (create_terminal): Initialize it.
5388
5389 * xselect.c: Support for clipboard managers.
5390 (Vselection_alist): Move to termhooks.h as terminal-local var.
5391 (LOCAL_SELECTION): New macro.
5392 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5393 (symbol_to_x_atom): Remove gratuitous arg.
5394 (x_handle_selection_request, lisp_data_to_selection_data)
5395 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5396 (x_own_selection, x_get_local_selection, x_convert_selection):
5397 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5398 (some_frame_on_display): Delete unused function.
5399 (Fx_own_selection_internal, Fx_get_selection_internal)
5400 (Fx_disown_selection_internal, Fx_selection_owner_p)
5401 (Fx_selection_exists_p): New optional frame arg.
5402 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5403 (x_handle_selection_clear): Don't treat other terminals with the
5404 same keyboard specially. Use the terminal-local Vselection_alist.
5405 (x_clear_frame_selections): Use Frun_hook_with_args.
5406
5407 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5408
5409 * xterm.h: Add support for those atoms.
5410
e067f0c1
CY
54112011-05-26 Chong Yidong <cyd@stupidchicken.com>
5412
5413 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5414 (converted_selections, conversion_fail_tag): New global variables.
5415 (x_selection_request_lisp_error): Free the above.
5416 (x_get_local_selection): Remove unnecessary code.
5417 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5418 of converted selections stored in converted_selections.
5419 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5420 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5421 (x_convert_selection): New function.
5422 (x_handle_selection_event): Simplify.
5423 (x_get_foreign_selection): Don't ignore incoming requests while
5424 waiting for an answer; this will fail when we implement
5425 SAVE_TARGETS, and seems unnecessary anyway.
5426 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5427 (Vx_sent_selection_functions): Doc fix.
5428
0f4aebc0
LL
54292011-05-26 Leo Liu <sdl.web@gmail.com>
5430
5431 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5432
e61124cd
YM
54332011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5434
5435 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5436
5437 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5438 for fringe update if it has periodic bitmap.
ac389d0c 5439 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5440 and fringe_bitmap_periodic_p.
5441
5442 * fringe.c (get_fringe_bitmap_data): New function.
5443 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5444 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5445 row. Mark glyph row for fringe update if periodicity changed.
5446
5447 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5448 for fringe update unless it has periodic bitmap.
5449
f16d9837
KH
54502011-05-25 Kenichi Handa <handa@m17n.org>
5451
5452 * xdisp.c (get_next_display_element): Set correct it->face_id for
5453 a static composition.
5454
e1b90ef6
LL
54552011-05-24 Leo Liu <sdl.web@gmail.com>
5456
5457 * deps.mk (fns.o):
5458 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5459
5460 * fns.c (crypto_hash_function, Fsha1): New function.
5461 (Fmd5): Use crypto_hash_function.
5462 (syms_of_fns): Add Ssha1.
5463
7400048f
PE
54642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5465
5466 * gnutls.c: Remove unused macros.
5467 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5468 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5469 Remove macros that are defined and never used.
5470 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5471
abb71cf4
CY
54722011-05-22 Chong Yidong <cyd@stupidchicken.com>
5473
5474 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5475 (Fx_get_selection_internal): Minor cleanup.
5476 (Fx_own_selection_internal): Rename arguments for consistency with
5477 select.el.
5478
6307db39
PE
54792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5480
5481 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5482
f3d4e0a4
CY
54832011-05-22 Chong Yidong <cyd@stupidchicken.com>
5484
5485 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5486
4d8ade89
YM
54872011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5488
5489 * dispnew.c (scrolling_window): Don't exclude the case that the
5490 last enabled row in the desired matrix touches the bottom boundary.
5491
32078c8d
GM
54922011-05-21 Glenn Morris <rgm@gnu.org>
5493
5494 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5495 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5496 and add some more files.
32078c8d 5497
7285dc67
EZ
54982011-05-20 Eli Zaretskii <eliz@gnu.org>
5499
5500 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5501 report_file_error introduced by the change from 2011-05-07.
5502
89d1bd22
PE
55032011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5504
5505 * systime.h (Time): Define only if emacs is defined.
5506 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5507 where the include path doesn't have X11/X.h by default. See
5508 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5509
e23640bb 55102011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5511
5512 * composite.c (find_automatic_composition): Fix previous change.
5513
b9704ad9
GM
55142011-05-20 Glenn Morris <rgm@gnu.org>
5515
5516 * lisp.mk: New file, split from Makefile.in.
5517 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5518 (shortlisp): Remove.
5519 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5520
4a720484
GM
55212011-05-19 Glenn Morris <rgm@gnu.org>
5522
5523 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5524 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5525 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5526 (lisp): Set the order to that of loadup.el.
5527 (shortlisp): Make it a copy of $lisp.
5528 (SOME_MACHINE_LISP): Remove.
5529 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5530 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5531
a28d4396
KH
55322011-05-18 Kenichi Handa <handa@m17n.org>
5533
5534 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5535 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5536 (find_automatic_composition): Mostly rewrite for efficiency.
5537
a2b1fa8e
JB
55382011-05-18 Juanma Barranquero <lekktu@gmail.com>
5539
5540 * makefile.w32-in: Update dependencies.
5541
8e1f5610
CS
55422011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5543
5544 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5545 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5546
7025ee00 55472011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5548
cdfa6eab
PE
5549 Fix some integer overflow issues, such as string length overflow.
5550
06d6db33
PE
5551 * insdel.c (count_size_as_multibyte): Check for string overflow.
5552
2b4560a8
PE
5553 * character.c (lisp_string_width): Check for string overflow.
5554 Use EMACS_INT, not int, for string indexes and lengths; in
5555 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5556 the resulting string length overflows an EMACS_INT; instead,
5557 report a string overflow if no precision given. When checking for
5558 precision exhaustion, use a check that cannot possibly have
5559 integer overflow. (Bug#8675)
5560 * character.h (lisp_string_width): Adjust to new signature.
5561
cb93f9be
PE
5562 * alloc.c (string_overflow): New function.
5563 (Fmake_string): Use it. This doesn't change behavior, but saves
5564 a few bytes and will simplify future changes.
5565 * character.c (string_escape_byte8): Likewise.
5566 * lisp.h (string_overflow): New decl.
5567
1a1f3366
PE
5568 Fixups, following up to the user-interface timestamp change.
5569 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5570 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5571 * msdos.c (mouse_get_pos): Likewise.
5572 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5573 * w32gui.h (Time): Define by including "systime.h" rather than by
5574 declaring it ourselves. (Bug#8664)
5575
d4e3e4d3
PE
5576 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5577 * image.c (clear_image_cache): Likewise.
5578
f6a24d19
PE
5579 * term.c (term_mouse_position): Don't assume time_t wraparound.
5580
08dc5ae6
PE
5581 Be more systematic about user-interface timestamps.
5582 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5583 and sometimes 'EMACS_UINT', to represent these timestamps.
5584 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5585 This makes the code easier to follow, and makes it easier to catch
5586 integer overflow bugs such as Bug#8664.
5587 * frame.c (Fmouse_position, Fmouse_pixel_position):
5588 Use Time, not unsigned long, for user-interface timestamps.
5589 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5590 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5591 * keyboard.h (last_event_timestamp): Likewise.
5592 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5593 * menu.h (xmenu_show): Likewise.
5594 * term.c (term_mouse_position): Likewise.
5595 * termhooks.h (struct input_event.timestamp): Likewise.
5596 (struct terminal.mouse_position_hook): Likewise.
5597 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5598 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5599 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5600 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5601 what it was before.
5602 * menu.h, termhooks.h: Include "systime.h", for Time.
5603
8e55734a
PE
5604 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5605 Don't assume that the difference between two unsigned long values
5606 can fit into an integer. At this point, we know button_down_time
5607 <= event->timestamp, so the difference must be nonnegative, so
5608 there's no need to cast the result if double-click-time is
5609 nonnegative, as it should be; check that it's nonnegative, just in
5610 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5611 apart (about 25 days). (Bug#8664)
8e55734a 5612
841f1b75 5613 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5614 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5615
3e26f69c
PE
5616 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5617 that always fit in int. Use a sentinel instead of a counter, to
5618 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5619 * frame.h (struct frame): Use int for menu_bar_items_used
5620 instead of EMACS_INT, since it always fits in int.
3e26f69c 5621
5cc152c0
PE
5622 * menu.c (grow_menu_items): Check for int overflow.
5623
d89eb65e
PE
5624 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5625
5235bd3e
PE
5626 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5627 Before, the code was not consistent. These values cannot exceed
5628 2**31 - 1 so there's no need to make them unsigned.
5629 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5630 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5631 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5632 as modifiers.
5633 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5634
bc827e23
PE
5635 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5636 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5637 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5638 presumably because the widths might not match.
5639
78eb494e
PE
5640 * window.c (size_window): Avoid needless test at loop start.
5641
04f2d78b
CB
56422011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5643
5644 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5645
d2fc7e3d 56462011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5647
5648 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5649
d2fc7e3d 56502011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5651
5652 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5653 `width' to `bar_area_x' and `bar_area_width', respectively.
5654 (x_scroll_run): Take account of fringe background extension.
5655
04f2d78b
CB
5656 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5657 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5658 `bar_area_width', respectively.
5659 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5660 background extension.
5661
79b70037
GM
56622011-05-10 Jim Meyering <meyering@redhat.com>
5663
5664 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5665
2f142cc5
JB
56662011-05-10 Juanma Barranquero <lekktu@gmail.com>
5667
5668 * image.c (Finit_image_library): Return t for built-in image types,
5669 like pbm and xbm. (Bug#8640)
5670
57679c86
AS
56712011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5672
5673 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5674
888c9e86
EZ
56752011-05-07 Eli Zaretskii <eliz@gnu.org>
5676
b0512a1d
EZ
5677 * w32console.c (Fset_screen_color): Doc fix.
5678 (Fget_screen_color): New function.
5679 (syms_of_ntterm): Defsubr it.
5680
7285dc67
EZ
5681 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5682 unlink the temporary file if Fcall_process didn't create it in the
5683 first place.
5684 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5685 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5686 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5687 cue to call_process_cleanup not to close that handle.
5688
4d3fcc8e
BK
56892011-05-07 Ben Key <bkey76@gmail.com>
5690
5691 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5692 one of two shell specific rules, either bootstrap-temacs-CMD or
5693 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5694 to the previous implementation of the bootstrap-temacs rule.
5695 The bootstrap-temacs-CMD rule is similar to the previous
5696 implementation of the bootstrap-temacs rule except that it
5697 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5698 variable.
5699
5700 These changes, along with some changes to nt/configure.bat,
5701 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5702 earlier fix to add support for --cflags and --ldflags options
5703 that include quotes so that it works whether make uses cmd or
5704 sh as the shell.
5705
b4289b64
MA
57062011-05-06 Michael Albinus <michael.albinus@gmx.de>
5707
5708 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5709 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5710 is a constant.
5711 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5712 a string. Handle both cases.
5713 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5714 (Fdbus_register_method): Use Qinvalid_function.
5715
af4c0e28
JB
57162011-05-06 Juanma Barranquero <lekktu@gmail.com>
5717
5718 * makefile.w32-in: Update dependencies.
5719 (LISP_H): Add inttypes.h and stdin.h.
5720 (PROCESS_H): Add unistd.h.
5721
c51453d9
EZ
57222011-05-06 Eli Zaretskii <eliz@gnu.org>
5723
5724 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5725 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5726
8ff0ac3c 57272011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5728
4c4b566b
PE
5729 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5730
aab2b9b5
PE
5731 * term.c (vfatal): Remove stray call to va_end.
5732 It's not needed and the C Standard doesn't allow it here anyway.
5733
c378da0b
PE
5734 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5735 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5736
288b08c7
PE
5737 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5738 bytes.
5739
e3601888
PE
5740 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5741
db6c0e74
PE
5742 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5743
dd5963ea
PE
5744 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5745
88c9450f
PE
5746 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5747
2f9442b8
PE
5748 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5749
c032b5f8
PE
5750 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5751 * charset.c (Fdefine_charset_internal): Don't initialize
5752 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5753 32-bit int (Bug#8600).
a108c10b
PE
5754
5755 * lread.c (read_integer): Be more consistent with string-to-number.
5756 Use string_to_number to do the actual conversion; this avoids
5757 rounding errors and fixes some other screwups. Without this fix,
5758 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5759 (digit_to_number): Move earlier, for benefit of read_integer.
5760 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5761 not a digit in any supported base. (Bug#8602)
a108c10b 5762
ad5f9eea
PE
5763 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5764
aec1708a
PE
5765 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5766 to match comment at start of function. This also removes a
5767 GCC warning about overflow in a 32+64-bit port.
5768
47be4ab5
PE
5769 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5770
371cac43
PE
5771 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5772 Reported by Stefan Monnier in
5773 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5774 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5775 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5776
d01a7826
PE
5777 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5778 (EMACS_UINTPTR): Likewise, with uintptr_t.
5779
7fd47d5c
PE
5780 * lisp.h: Prefer 64-bit EMACS_INT if available.
5781 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5782 on 32-bit hosts that have 64-bit int, so that they can access
5783 large files.
122b0c86
PE
5784 However, temporarily disable this change unless the temporary
5785 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5786
8727937b
PE
5787 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5788
8ac068ac
PE
5789 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5790 This removes an assumption that EMACS_INT and long are the same
5791 width as pointers. The assumption is true for Emacs porting targets
5792 now, but we want to make other targets possible.
5793 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5794 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5795 In the rest of the code, change types of integers that hold casted
5796 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5797 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5798 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5799 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5800 No need to cast type when ORing.
5801 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5802 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5803 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5804 assume EMACS_INT is the same width as char *.
5805 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5806 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5807 Remove no-longer-needed casts.
5808 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5809 (xg_tool_bar_help_callback, xg_make_tool_item):
5810 Use EMACS_INTPTR to hold an integer
5811 that will be cast to void *; this can avoid a GCC warning
5812 if EMACS_INT is not the same width as void *.
5813 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5814 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5815 (current_message_1, set_message_1):
5816 Use a local to convert to proper width without a cast.
5817 * xmenu.c (dialog_selection_callback): Likewise.
5818
ede49d71
PE
5819 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5820 Also, don't assume VALBITS / RAND_BITS is less than 5,
5821 and don't rely on undefined behavior when shifting a 1 left into
5822 the sign bit.
5823 * lisp.h (get_random): Change signature to match.
5824
2f30ecd0
PE
5825 * lread.c (hash_string): Use size_t, not int, for hash computation.
5826 Normally we prefer signed values; but hashing is special, because
5827 it's better to use unsigned division on hash table sizes so that
5828 the remainder is nonnegative. Also, size_t is the natural width
5829 for hashing into memory. The previous code used 'int', which doesn't
5830 retain enough info to hash well into very large tables.
5831 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5832
2a866e7b
PE
5833 * dbusbind.c: Don't possibly lose pointer info when converting.
5834 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5835 Use XPNTR rather than XHASH, so that the high-order bits of
5836 the pointer aren't lost when converting through void *.
5837
51639eac
PE
5838 * eval.c (Fautoload): Don't double-shift a pointer.
5839
92394119
PE
5840 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5841
dbdb9a7c
JB
58422011-05-06 Juanma Barranquero <lekktu@gmail.com>
5843
5844 * gnutls.c (DEF_GNUTLS_FN):
5845 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5846
db7a0b4f
AS
58472011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5848
5849 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5850 marker. (Bug#8610)
5851
f7ff1b0f 58522011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5853
5854 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5855 New version that can reserve upto 2GB of heap space.
5856
f7ff1b0f 58572011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5858
5859 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5860
639c109b
TZ
58612011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5862
5863 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5864 `gnutls_certificate_set_x509_key_file'.
5865
d2127135
JB
58662011-05-05 Juanma Barranquero <lekktu@gmail.com>
5867
5868 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5869 Update dependencies.
5870
e968f4f3
JB
58712011-05-04 Juanma Barranquero <lekktu@gmail.com>
5872
5873 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5874 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5875 Remove unused parameter `fildes'.
5876 * process.c (read_process_output, send_process): Don't pass it.
5877
84d358f0
JB
58782011-05-04 Juanma Barranquero <lekktu@gmail.com>
5879
5880 Fix previous change: the library cache is defined in w32.c.
5881 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5882 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5883
0898ca10
JB
58842011-05-04 Juanma Barranquero <lekktu@gmail.com>
5885
5886 Implement dynamic loading of GnuTLS on Windows.
5887
5888 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5889 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5890 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5891 Declare.
5892
5893 * gnutls.c (Qgnutls_dll): Define.
5894 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5895 (gnutls_*): Declare function pointers.
5896 (init_gnutls_functions): New function to initialize function pointers.
5897 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5898 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5899 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5900 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5901 (emacs_gnutls_write, emacs_gnutls_read)
5902 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5903 (Fgnutls_available_p): New function.
5904 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5905 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5906 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5907
5908 * image.c: Include w32.h.
5909 (Vimage_type_cache): Delete.
5910 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5911 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5912 (w32_delayed_load): Move to w32.c.
5913
5914 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5915
5916 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5917 (w32_delayed_load): Move from image.c. When loading a library, record
5918 its filename in the :loaded-from property of the library id.
5919 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5920 Initialize and staticpro them.
5921 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5922
5923 * process.c: Include lisp.h before w32.h, not after.
5924 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5925 instead of gnutls_record_check_pending.
5926
5927 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5928
ff4de4aa
TZ
59292011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5930
5931 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5932 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5933 as passed in.
5934
abe95abb
JD
59352011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5936
5937 * xterm.c (x_set_frame_alpha): Do not set property on anything
5938 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5939
e16e55d4
JB
59402011-05-02 Juanma Barranquero <lekktu@gmail.com>
5941
5942 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5943
bafcf6a5
JB
59442011-05-02 Juanma Barranquero <lekktu@gmail.com>
5945
5946 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5947 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5948 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5949 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5950 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5951 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5952 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5953 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5954 (Qgnutls_bootprop_callbacks_verify): Make static.
5955
e7a6747f
AS
59562011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5957
19ed11ba
AS
5958 * callproc.c: Indentation fixup.
5959
e7a6747f 5960 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5961 (wait_for_termination, interruptible_wait_for_termination):
5962 Move after wait_for_termination_1.
e7a6747f 5963
1ef14cb4
LMI
59642011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5965
5966 * sysdep.c (interruptible_wait_for_termination): New function
5967 which is like wait_for_termination, but allows keyboard
5968 interruptions.
5969
5970 * callproc.c (Fcall_process): Add (:file "file") as an option for
5971 the STDOUT buffer.
5972 (Fcall_process_region): Ditto.
5973
330d880c
EZ
59742011-04-30 Eli Zaretskii <eliz@gnu.org>
5975
8db90b73
EZ
5976 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5977 rather than `XVECTOR (FOO)->size'.
5978
330d880c
EZ
5979 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5980 inttypes.h, as a gnulib replacement is used if it not available in
5981 system headers.
5982
15cbd324
EZ
59832011-04-21 Eli Zaretskii <eliz@gnu.org>
5984
5985 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5986 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5987 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5988
5989 * coding.c (coding_alloc_by_realloc): Error out if destination
5990 will grow beyond MOST_POSITIVE_FIXNUM.
5991 (decode_coding_emacs_mule): Abort if there isn't enough place in
5992 charbuf for the composition carryover bytes. Reserve an extra
5993 space for up to 2 characters produced in a loop.
5994 (decode_coding_iso_2022): Abort if there isn't enough place in
5995 charbuf for the composition carryover bytes.
5996
59972011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5998
ae940cca
EZ
5999 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6000 aborting when %lld or %lll format is passed.
6001 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6002 %llo or %llx format is passed. (Bug#8545)
6003
03ab8921
EZ
6004 * window.c (window_scroll_line_based): Use a marker instead of
6005 simple variables to record original value of point. (Bug#7952)
6006
afda1437
EZ
6007 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6008 produced by %s or %c overflows available buffer space. (Bug#8545)
6009
f76dee0c
PE
60102011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6011
6012 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6013 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6014
fdc5744d
JB
60152011-04-28 Juanma Barranquero <lekktu@gmail.com>
6016
6017 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6018
638f053a
JB
60192011-04-28 Juanma Barranquero <lekktu@gmail.com>
6020
6021 * keyboard.c (Qdelayed_warnings_hook): Define.
6022 (command_loop_1): Run `delayed-warnings-hook'
6023 if Vdelayed_warnings_list is non-nil.
6024 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6025 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6026
d178f871
EZ
60272011-04-28 Eli Zaretskii <eliz@gnu.org>
6028
6029 * doprnt.c (doprnt): Don't return value smaller than the buffer
6030 size if the message was truncated. (Bug#8545).
6031
b124fd93
JB
60322011-04-28 Juanma Barranquero <lekktu@gmail.com>
6033
6034 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6035 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6036
e810457d
PE
60372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6038
6039 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6040
ea51cceb
JB
60412011-04-27 Juanma Barranquero <lekktu@gmail.com>
6042
6043 * makefile.w32-in: Update dependencies.
6044
94dcfacf
EZ
60452011-04-27 Eli Zaretskii <eliz@gnu.org>
6046
6047 Improve `doprnt' and its usage. (Bug#8545)
6048 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6049 `format_end'. Remove support for %l as a conversion specifier.
6050 Don't use xrealloc. Improve diagnostics when the %l size modifier
6051 is used. Update the commentary.
6052
6053 * eval.c (verror): Simplify calculation of size_t.
6054
6055 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6056 messages.
6057
f61f41d7
PE
60582011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6059
6060 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6061 change.
6062
96fb4434
PE
60632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6066 This makes this file independent of the recent pseudovector change.
6067
671875da 60682011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6069
69e9b5a3
PE
6070 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6071
b5f869a7 6072 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6073 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6074 Remove unused local.
c8926152 6075 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6076
841a1577 6077 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6078 GCC 4.6.0 optimizes based on type-based alias analysis.
6079 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6080 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6081 != &v->size, and therefore "v->size = 1; b->size = 2; return
6082 v->size;" must therefore return 1. This assumption is incorrect
6083 for Emacs, since it type-puns struct Lisp_Vector * with many other
6084 types. To fix this problem, this patch adds a new type struct
f904488f 6085 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6086 and pseudovectors, and helps optimizing compilers not get fooled
6087 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6088 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6089 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6090 the size member.
eab3844f
PE
6091 (XSETPVECTYPE): Rewrite in terms of new macro.
6092 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6093 This is a bit clearer, and further avoids the possibility of
6094 undesirable aliasing.
6095 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6096 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6097 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6098 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6099 (ASIZE): Now uses header.size rather than size.
6100 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6101 to avoid the hassle of writing XVECTOR (foo)->header.size.
6102 (struct vectorlike_header): New type.
eab3844f
PE
6103 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6104 object, to help avoid aliasing.
6105 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6106 (SUBRP): Likewise, since Lisp_Subr is a special case.
6107 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6108 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6109 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6110 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6111 changed to be "header.size" and "header.next".
6112 * buffer.h (struct buffer): Likewise.
6113 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6114 * frame.h (struct frame): Likewise.
6115 * process.h (struct Lisp_Process): Likewise.
6116 * termhooks.h (struct terminal): Likewise.
6117 * window.c (struct save_window_data, struct saved_window): Likewise.
6118 * window.h (struct window): Likewise.
6119 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6120 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6121 * buffer.c (init_buffer_once): Likewise.
6122 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6123 special case.
6124 * process.c (Fformat_network_address): Use local var for size,
6125 for brevity.
6126
0df1eac5
PE
6127 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6128
847ab9d1 6129 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6130 * data.c (atof): Remove decl; no longer used or needed.
6131 (digit_to_number): Move to lread.c.
6132 (Fstring_to_number): Use new string_to_number function, to be
6133 consistent with how the Lisp reader treats infinities and NaNs.
6134 Do not assume that floating-point numbers represent EMACS_INT
6135 without losing information; this is not true on most 64-bit hosts.
6136 Avoid double-rounding errors, by insisting on integers when
6137 parsing non-base-10 numbers, as the documentation specifies.
6138 * lisp.h (string_to_number): New decl, replacing ...
6139 (isfloat_string): Remove.
bc0a5c13 6140 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6141 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6142 appears to have been a coding error. Similarly, do not accept
6143 strings like +-1e0 as floating point numbers. Do not report
6144 overflow for integer overflows unless the base is not 10 which
6145 means we have no simple and reliable way to continue.
6146 Break out the floating-point parsing into a new
6147 function string_to_number, so that Fstring_to_number parses
6148 floating point numbers consistently with the Lisp reader.
04f2d78b 6149 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6150 (E_CHAR, EXP_INT): Remove, replacing with ...
6151 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6152 (string_to_number): New function, replacing isfloat_string.
6153 This function checks for valid syntax and produces the resulting
6154 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6155 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6156 so that overflow for non-base-10 numbers is reported only when
6157 there's no portable and simple way to convert to floating point.
452f4150 6158
67769ffc
PE
6159 * textprop.c (set_text_properties_1): Rewrite for clarity,
6160 and to avoid GCC warning about integer overflow.
6161
c20db43f
PE
6162 * intervals.h (struct interval): Use EMACS_INT for members
6163 where EMACS_UINT might cause problems. See
6164 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6165 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6166 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6167 All uses changed.
37aa2f85
PE
6168 (offset_intervals): Tell GCC not to worry about length overflow
6169 when negating a negative length.
c20db43f 6170
2538aa2f
PE
6171 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6172 (overrun_check_free): Likewise.
6173
f2d3008d
PE
6174 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6175 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6176 word size.
6177
ec8df744
PE
6178 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6179 (gnutls_make_error): Rename local to avoid shadowing.
6180 (gnutls_emacs_global_deinit): ifdef out; not used.
6181 (Fgnutls_boot): Use const for pointer to readonly storage.
6182 Comment out unused local. Fix pointer signedness problems.
6183
640ee02d
PE
6184 * lread.c (openp): Don't stuff size_t into an 'int'.
6185 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6186 about possible signed overflow.
6187
6048fb2a
PE
6188 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6189 (GDK_KEY_g): Don't define if already defined.
6190 (xg_prepare_tooltip): Avoid pointer signedness problem.
6191 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6192
fa3c87e1
PE
6193 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6194 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6195
2172544b
PE
6196 * xfns.c (Fx_window_property): Simplify a bit,
6197 to make a bit faster and to avoid GCC 4.6.0 warning.
6198 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6199
9b821a21
PE
6200 * fns.c (internal_equal): Don't assume size_t fits in int.
6201
3c616cfa
PE
6202 * alloc.c (compact_small_strings): Tighten assertion a little.
6203
c2982e87
PE
6204 Replace pEd with more-general pI, and fix some printf arg casts.
6205 * lisp.h (pI): New macro, generalizing old pEd macro to other
6206 conversion specifiers. For example, use "...%"pI"d..." rather
6207 than "...%"pEd"...".
6208 (pEd): Remove. All uses replaced with similar uses of pI.
6209 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6210 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6211 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6212 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6213 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6214 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6215 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6216 64-bit hosts.
6217 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6218 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6219 * print.c (safe_debug_print, print_object): Likewise.
6220 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6221 to int.
6f04d126
PE
6222 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6223 avoiding the 0 flag, which is not portable.
c2982e87
PE
6224 * process.c (Fmake_network_process): Use pI to avoid cast.
6225 * region-cache.c (pp_cache): Likewise.
6226 * xdisp.c (decode_mode_spec): Likewise.
6227 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6228 behavior on 64-bit hosts with printf arg.
6f04d126 6229 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6230 (x_stop_queuing_selection_requests): Likewise.
6231 (x_get_window_property): Don't truncate byte count to an 'int'
6232 when tracing.
0b432f21 6233
5e073ec7
PE
6234 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6235 here, since it parses constructs like leading '-' and spaces,
6236 which are not wanted; and it overflows with large numbers.
6237 Instead, simply match F[0-9]+, which is what is wanted anyway.
6238
36372bf9
PE
6239 * alloc.c: Remove unportable assumptions about struct layout.
6240 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6241 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6242 (allocate_vectorlike, make_pure_vector): Use the new macros,
6243 plus offsetof, to remove unportable assumptions about struct layout.
6244 These assumptions hold on all porting targets that I know of, but
6245 they are not guaranteed, they're easy to remove, and removing them
6246 makes further changes easier.
6247
0b432f21
PE
6248 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6249 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6250 (string_overrun_cookie): Now const. Use initializers that
6251 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6252 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6253 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6254 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6255 multiple of sizeof (EMACS_INT); it need not be, if
6256 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6257 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6258
895009e1
JB
62592011-04-26 Juanma Barranquero <lekktu@gmail.com>
6260
6261 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6262
6a7a1b0b
TZ
62632011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6264
6265 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6266 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6267 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6268
841a1577 62692011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6270
6271 * lisp.h (Qdebug): List symbol.
895009e1 6272 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6273 * keyboard.c (debug-on-event): New variable.
6274 (handle_user_signal): Break into debugger when debug-on-event
6275 matches the current signal symbol.
6276
f2d3ba6f
DN
62772011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6278
6279 * alloc.c (check_sblock, check_string_bytes)
6280 (check_string_free_list): Convert to standard C.
6281
42ce4c63
TZ
62822011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6283
6284 * w32.c (emacs_gnutls_push): Fix typo.
6285
825cd63c
EZ
62862011-04-25 Eli Zaretskii <eliz@gnu.org>
6287
fb11d64d
EZ
6288 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6289 "cast to pointer from integer of different size".
6290
825cd63c
EZ
6291 Improve doprnt and its use in verror. (Bug#8545)
6292 * doprnt.c (doprnt): Document the set of format control sequences
6293 supported by the function. Use SAFE_ALLOCA instead of always
6294 using `alloca'.
6295
6296 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6297 is one byte too soon. Don't use xrealloc; instead xfree and
6298 xmalloc anew.
6299
e061a11b
TZ
63002011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6301
6302 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6303 callbacks stage.
6304
6305 * gnutls.c: Renamed global_initialized to
6306 gnutls_global_initialized. Added internals for the
6307 :verify-hostname-error, :verify-error, and :verify-flags
6308 parameters of `gnutls-boot' and documented those parameters in the
6309 docstring. Start callback support.
9173deec
JB
6310 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6311 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6312 on error. Return error code.
e061a11b
TZ
6313 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6314 (emacs_gnutls_read): Likewise.
6315 (Fgnutls_boot): Return handshake error code.
6316 (emacs_gnutls_handle_error): New function.
6317 (wsaerror_to_errno): Likewise.
6318
6319 * w32.h (emacs_gnutls_pull): Add prototype.
6320 (emacs_gnutls_push): Likewise.
6321
6322 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6323 (emacs_gnutls_push): Likewise.
6324
63252011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6326
6327 * process.c (wait_reading_process_output): Check if GnuTLS
6328 buffered some data internally if no FDs are set for TLS
6329 connections.
6330
6331 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6332 (LIBS): Link to USER_LIBS.
6333 ($(BLD)/gnutls.$(0)): New target.
6334
fa6996bc
EZ
63352011-04-24 Eli Zaretskii <eliz@gnu.org>
6336
eb35682e
EZ
6337 * xdisp.c (handle_single_display_spec): Rename the
6338 display_replaced_before_p argument into display_replaced_p, to
6339 make it consistent with the commentary. Fix typos in the
6340 commentary.
6341
e2ad650c
EZ
6342 * textprop.c (syms_of_textprop): Remove dead code.
6343 (copy_text_properties): Delete obsolete commentary about an
6344 interface that was deleted long ago. Fix typos in the description
6345 of arguments.
6346
1b2de274
EZ
6347 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6348 to changes in oldXMenu/XMenu.h from 2011-04-16.
6349 <menu_help_message, prev_menu_help_message>: Constify.
6350 (IT_menu_make_room): menu->help_text is now `const char **';
6351 adjust.
6352
6353 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6354 to changes in oldXMenu/XMenu.h from 2011-04-16.
6355 (struct XMenu): Declare `help_text' `const char **'.
6356
6357 * xfaces.c <Qunspecified>: Make extern again.
6358
6359 * syntax.c: Include sys/types.h before including regex.h, as
6360 required by Posix.
6361
762b15be
EZ
6362 * doc.c (get_doc_string): Improve the format passed to `error'.
6363
6364 * doprnt.c (doprnt): Improve commentary.
6365
6366 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6367
6368 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6369 them with etags.
6370
f1052e5d
EZ
6371 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6372 changes in globals.h immediately force recompilation.
762b15be
EZ
6373 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6374 $(CURDIR)/s/ms-w32.h.
6375 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6376
fa6996bc
EZ
6377 * character.c (Fchar_direction): Function deleted.
6378 (syms_of_character): Don't defsubr it.
6379 <char-direction-table>: Deleted.
6380
e6c3da20
EZ
63812011-04-23 Eli Zaretskii <eliz@gnu.org>
6382
6383 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6384 * doprnt.c: Include limits.h.
6385 (SIZE_MAX): New macro.
04f2d78b
CB
6386 (doprnt): Return a size_t value. 2nd arg is now size_t.
6387 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6388 Improve overflow protection. Support `l' modifier for integer
6389 conversions. Support %l conversion. Don't assume an EMACS_INT
6390 argument for integer conversions and for %c.
6391
6392 * lisp.h (doprnt): Restore prototype.
6393
6394 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6395 $(SRC)/character.h.
6396
6397 * Makefile.in (base_obj): Add back doprnt.o.
6398
6399 * deps.mk (doprnt.o): Add back prerequisites.
6400 (callint.o): Depend on character.h.
6401
6402 * eval.c (internal_lisp_condition_case): Include the handler
6403 representation in the error message.
6404 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6405 when breaking from the loop.
6406
6407 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6408
6409 * callint.c (Fcall_interactively): When displaying error message
6410 about invalid control letter, pass the character's codepoint, not
6411 a pointer to its multibyte form. Improve display of the character
6412 in octal and display also its hex code.
6413
6414 * character.c (char_string): Use %x to display the (unsigned)
6415 codepoint of an invalid character, to avoid displaying a bogus
6416 negative value.
6417
6418 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6419 `error', not SYMBOL_NAME itself.
6420
6421 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6422 character arguments to `error'.
6423
6424 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6425 to `error' in error message about FINAL_CHAR argument. Make sure
6426 FINAL_CHAR is a character, and use %c when it is passed as
6427 argument to `error'.
6428
4ffd0d6b 64292011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6430
6431 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6432
6433 * w32.c: Include <time.h>.
6434 (sys_localtime): New function.
6435
4ffd0d6b 64362011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6437
6438 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6439
4ffd0d6b 6440 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6441
4ffd0d6b 64422011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6443
4ffd0d6b
GM
6444 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6445 zombies (Bug#8467).
aac0c6e3 6446
04c56954
EZ
64472011-04-19 Eli Zaretskii <eliz@gnu.org>
6448
6449 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6450 gl_state.e_property when gl_state.object is Qt.
6451
6452 * insdel.c (make_gap_larger): Remove limitation of buffer size
6453 to <= INT_MAX.
6454
16a43933
CY
64552011-04-18 Chong Yidong <cyd@stupidchicken.com>
6456
6457 * xdisp.c (lookup_glyphless_char_display)
6458 (produce_glyphless_glyph): Handle cons cell entry in
6459 glyphless-char-display.
6460 (Vglyphless_char_display): Document it.
6461
6462 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6463 glyphless-char-display.
6464
4581706e
CY
64652011-04-17 Chong Yidong <cyd@stupidchicken.com>
6466
6467 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6468
6469 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6470
6471 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6472 definition for no-X builds.
6473
4887c6e2 64742011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6475
fd35b6f9
PE
6476 Static checks with GCC 4.6.0 and non-default toolkits.
6477
5c1ccb01
PE
6478 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6479
006c5daa
PE
6480 * process.c (keyboard_bit_set): Define only if SIGIO.
6481 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6482 (send_process): Repair possible setjmp clobbering.
6483
efc736d3
PE
6484 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6485
4e2fe2e6
PE
6486 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6487
f97334a2
PE
6488 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6489
4e75f29d
PE
6490 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6491 Define only if needed.
6492
90efadd1
PE
6493 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6494 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6495 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6496
3c647824
PE
6497 * dispextern.h (struct redisplay_interface): Rename param
6498 to avoid shadowing.
e264f262 6499 * termhooks.h (struct terminal): Likewise.
761383f4 6500 * xterm.c (xembed_send_message): Likewise.
3c647824 6501
b58c5c4a
PE
6502 * insdel.c (make_gap_smaller): Define only if
6503 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6504
cad59032
PE
6505 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6506 it.
6507
c339dc2e
PE
6508 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6509 so that we aren't warned about unused symbols.
6510
91a3e27b
PE
6511 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6512
399c71d3 6513 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6514
8ffc96f5
PE
6515 * xfns.c (x_real_positions): Mark locals as initialized.
6516
eef9bc79
PE
6517 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6518
098db9dd
PE
6519 * xterm.c: Fix problems found by static analysis with other toolkits.
6520 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6521 (x_dispatch_event): Declare static if USE_GTK, and
6522 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6523 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6524 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6525 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6526 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6527
eb18f6cc
PE
6528 * xmenu.c (menu_help_callback): Pointer type fixes.
6529 Use const pointers when pointing at readonly data. Avoid pointer
6530 signedness clashes.
6531 (FALSE): Remove unused macro.
6532 (update_frame_menubar): Remove unused decl.
6533
1fe72bf8
PE
6534 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6535
60d9e1db
PE
6536 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6537 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6538 (single_menu_item): Rename local to avoid shadowing.
6539
39261c26
PE
6540 * keyboard.c (make_lispy_event): Remove unused local var.
6541
018c5e19
PE
6542 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6543 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6544
63d2b86e
PE
6545 * bitmaps: Change bitmaps from unsigned char back to the X11
6546 compatible char. Avoid the old compiler warnings about
6547 out-of-range initializers by using, for example, '\xab' rather
6548 than 0xab.
6549
aefd87e1
PE
6550 * xgselect.c (xgselect_initialize): Check vs interface
6551 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6552
bf501fb9
PE
6553 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6554
e9829fdf
PE
6555 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6556 to read-only memory.
6557
1086c095
PE
6558 * fns.c (vector): Remove; this old hack is no longer needed.
6559
2baccd04 6560 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6561 Remove unused var.
dde42981 6562 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6563
72391843 6564 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6565
436c16df 6566 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6567 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6568 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6569
92bb796d 6570 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6571 (x_term_init): Remove local to avoid shadowing.
92bb796d 6572
764430a3 6573 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6574
6575 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6576 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6577
d1dfb56c
EZ
65782011-04-16 Eli Zaretskii <eliz@gnu.org>
6579
c4354cb4
EZ
6580 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6581
d1dfb56c
EZ
6582 Fix regex.c, syntax.c and friends for buffers > 2GB.
6583 * syntax.h (struct gl_state_s): Declare character position members
6584 EMACS_INT.
6585
6586 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6587
04f2d78b
CB
6588 * textprop.c (verify_interval_modification, interval_of):
6589 Declare arguments EMACS_INT.
d1dfb56c
EZ
6590
6591 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6592 EMACS_INT.
6593
6594 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6595
6596 * indent.c (Fvertical_motion): Local variable it_start is now
6597 EMACS_INT.
6598
6599 * regex.c (re_match, re_match_2, re_match_2_internal)
6600 (bcmp_translate, regcomp, regexec, print_double_string)
6601 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6602 (re_compile_pattern, re_exec): Declare arguments and local
6603 variables `size_t' and `ssize_t' and return values `regoff_t', as
6604 appropriate.
6605 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6606 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6607 <compile_stack_type>: `size' and `avail' are now `size_t'.
6608
6609 * regex.h <regoff_t>: Use ssize_t, not int.
6610 (re_search, re_search_2, re_match, re_match_2): Arguments that
6611 specify buffer/string position and length are now ssize_t and
6612 size_t. Return type is regoff_t.
6613
613052cd
BK
66142011-04-16 Ben Key <bkey76@gmail.com>
6615
6616 * nsfont.m: Fixed bugs in ns_get_family and
6617 ns_descriptor_to_entity that were caused by using free to
6618 deallocate memory blocks that were allocated by xmalloc (via
6619 xstrdup). This caused Emacs to crash when compiled with
6620 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6621 --enable-checking=xmallocoverrun). xfree is now used to
6622 deallocate these memory blocks.
6623
4170f62f 66242011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6625
71b41406
PE
6626 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6627
9587a89d
PE
6628 emacs_write: Accept and return EMACS_INT for sizes.
6629 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6630 et seq.
6631 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6632 Accept and return EMACS_INT.
6633 (emacs_gnutls_write): Return the number of bytes written on
6634 partial writes.
6635 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6636 (emacs_read, emacs_write): Remove check for negative size, as the
6637 Emacs source code has been audited now.
9587a89d
PE
6638 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6639 (emacs_read, emacs_write): Use it.
273a5f82
PE
6640 * process.c (send_process): Adjust to the new signatures of
6641 emacs_write and emacs_gnutls_write. Do not attempt to store
6642 a byte offset into an 'int'; it might overflow.
9587a89d 6643 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6644
3e047f51
PE
6645 * sound.c: Don't assume sizes fit in 'int'.
6646 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6647 Return EMACS_INT, not int.
3e047f51 6648 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6649 Accept EMACS_INT, not int.
6650 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6651 record read return values.
6652
cc39a9db
BK
66532011-04-15 Ben Key <bkey76@gmail.com>
6654
c9d0ec6d
JB
6655 * keyboard.c (Qundefined): Don't declare static since it is used
6656 in nsfns.m.
6657 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6658 static since they are used in nsfont.m.
cc39a9db 6659
6c60eb9f
SM
66602011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6661
6662 * process.c (Qprocessp): Don't declare static.
6663 * lisp.h (Qprocessp): Declare again.
6664
7990b61a
JB
66652011-04-15 Juanma Barranquero <lekktu@gmail.com>
6666
6667 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6668
5d4cb038
PE
66692011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6670
8bd7b830 6671 Improve C-level modularity by making more things 'static'.
cd64ea1d 6672
e3b27b31
PE
6673 Don't publish debugger-only interfaces to other modules.
6674 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6675 (verify_bytepos, count_markers): Move decls to the only modules
6676 that need them.
6677 * region-cache.h (pp_cache): Likewise.
6678 * window.h (check_all_windows): Likewise.
6679 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6680
5d4cb038
PE
6681 * sysdep.c (croak): Now static, if
6682 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6683 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6684
6685 * alloc.c (refill_memory_reserve): Now static if
6686 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6687 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6688
e87b6180
PE
6689 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6690 Define only if USE_LUCID.
6691
ac64929e
PE
6692 * xrdb.c (x_customization_string, x_rm_string): Now static.
6693
6f37259d
PE
6694 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6695 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6696
1683e3ab
PE
6697 * xdisp.c (draw_row_with_mouse_face): Now static.
6698 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6699
de9c2632
PE
6700 * window.h (check_all_windows): Mark externally visible.
6701
2b96acb7
PE
6702 * window.c (window_deletion_count): Now static.
6703
6704 * undo.c: Make symbols static if they're not exported.
6705 (last_undo_buffer, last_boundary_position, pending_boundary):
6706 Now static.
6707
50436f33
PE
6708 * textprop.c (interval_insert_behind_hooks): Now static.
6709 (interval_insert_in_front_hooks): Likewise.
6710
64520e5c
PE
6711 * term.c: Make symbols static if they're not exported.
6712 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6713 (max_frame_lines, tty_set_terminal_modes):
6714 (tty_reset_terminal_modes, tty_turn_off_highlight):
6715 (get_tty_terminal): Now static.
6716 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6717 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6718 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6719 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6720 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6721
1fa53021
PE
6722 * sysdep.c: Make symbols static if they're not exported.
6723 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6724 Now static.
6725 (sigprocmask_set, full_mask): Remove; unused.
6726 (wait_debugging): Mark as visible.
6727 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6728 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6729
d4b43b22
PE
6730 * syntax.c (syntax_temp): Define only if !__GNUC__.
6731
b7c513d0
PE
6732 * sound.c (current_sound_device, current_sound): Now static.
6733
989b29ad
PE
6734 * search.c (searchbufs, searchbuf_head): Now static.
6735
13a55a78
PE
6736 * scroll.c (scroll_cost): Remove; unused.
6737 * dispextern.h (scroll_cost): Remove decl.
6738
de68a1fc
PE
6739 * region-cache.h (pp_cache): Mark as externally visible.
6740
40ccffa6
PE
6741 * process.c: Make symbols static if they're not exported.
6742 (process_tick, update_tick, create_process, chan_process):
6743 (Vprocess_alist, proc_buffered_char, datagram_access):
6744 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6745 (deactivate_process): Mark defn as static, as well as decl.
6746 * lisp.h (create_process): Remove decl.
6747 * process.h (chan_process, Vprocess_alist): Remove decls.
6748
ad64fc97
PE
6749 * print.c: Make symbols static if they're not exported.
6750 (print_depth, new_backquote_output, being_printed, print_buffer):
6751 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6752 (print_interval, print_number_index, initial_stderr_stream):
6753 Now static.
6754 * lisp.h (Fprinc): Remove decl.
6755 (debug_output_compilation_hack): Mark as externally visible.
6756
adddb265
PE
6757 * sysdep.c (croak): Move decl from here to syssignal.h.
6758 * syssignal.h (croak): Put it here, so the API can be checked when
6759 'croak' is called from dissociate_if_controlling_tty.
6760
1717ede2
PE
6761 * minibuf.c: Make symbols static if they're not exported.
6762 (minibuf_save_list, choose_minibuf_frame): Now static.
6763 * lisp.h (choose_minibuf_frame): Remove decl.
6764
fa5fb2bc
PE
6765 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6766
1e3890d1
PE
6767 * lread.c: Make symbols static if they're not exported.
6768 (read_objects, initial_obarray, oblookup_last_bucket_number):
6769 Now static.
6770 (make_symbol): Remove; unused.
6771 * lisp.h (initial_obarray, make_symbol): Remove decls.
6772
8a1414fa
PE
6773 * keyboard.c: Make symbols static if they're not exported.
6774 (single_kboard, recent_keys_index, total_keys, recent_keys):
6775 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6776 (this_single_command_key_start, echoing, last_auto_save):
6777 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6778 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6779 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6780 (Vlispy_mouse_stem, double_click_count):
6781 Now static.
6782 (force_auto_save_soon): Define only if SIGDANGER.
6783 (ignore_mouse_drag_p): Now static if
6784 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6785 (print_help): Remove; unused.
6786 (stop_character, last_timer_event): Mark as externally visible.
6787 * keyboard.h (ignore_mouse_drag_p): Declare only if
6788 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6789 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6790 * lisp.h (echoing): Remove decl.
6791 (force_auto_save_soon): Declare only if SIGDANGER.
6792 * xdisp.c (redisplay_window): Simplify code, to make it more
6793 obvious that ignore_mouse_drag_p is not accessed if !defined
6794 USE_GTK && !defined HAVE_NS.
6795
93ea6e8f
PE
6796 * intervals.c: Make symbols static if they're not exported.
6797 (merge_properties_sticky, merge_interval_right, delete_interval):
6798 Now static.
6799 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6800
77382fcc
PE
6801 * insdel.c: Make symbols static if they're not exported.
6802 However, leave prepare_to_modify_buffer alone. It's never
6803 called from outside this function, but that appears to be a bug.
6804 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6805 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6806 (adjust_after_replace_noundo): Remove; unused.
6807 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6808 (signal_before_change): Remove decls.
77382fcc 6809
9306c32e
PE
6810 * indent.c (val_compute_motion, val_vmotion): Now static.
6811
cd44d2eb
PE
6812 * image.c: Make symbols static if they're not exported.
6813 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6814 if USE_GTK.
6815 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6816 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6817
ad9a7a06
PE
6818 * fringe.c (standard_bitmaps): Now static.
6819 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6820
81626931
PE
6821 * frame.c: Make symbols static if they're not exported.
6822 (x_report_frame_params, make_terminal_frame): Now static.
6823 (get_frame_param): Now static, unless HAVE_NS.
6824 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6825 (x_get_resource_string): Remove; not used.
6826 * frame.h (make_terminal_frame, x_report_frame_params):
6827 (x_get_resource_string); Remove decls.
6828 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6829 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6830
239f9db9
PE
6831 * font.c, fontset.c: Make symbols static if they're not exported.
6832 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6833 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6834 * font.c (font_close_object): Now static.
6835 * font.h (font_close_object): Remove.
6836 * fontset.c (FONTSET_OBJLIST): Remove.
6837 (free_realized_fontset) #if-0 the body, which does nothing.
6838 (face_suitable_for_char_p): #if-0, as it's never called.
6839 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6840 * xfaces.c (face_at_string_position):
6841 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6842 since 0 is always ASCII.
6843
dfcf3579
PE
6844 * fns.c (weak_hash_tables): Now static.
6845
5045092b
PE
6846 * fileio.c: Make symbols static if they're not exported.
6847 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6848 (Vwrite_region_annotation_buffers): Now static.
6849
57a96f5c
PE
6850 * eval.c: Make symbols static if they're not exported.
6851 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6852 * lisp.h (backtrace_list): Remove decl.
6853
35f08c38
PE
6854 * emacs.c: Make symbols static if they're not exported.
6855 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6856 (fatal_error_code, fatal_error_signal_hook, standard_args):
6857 Now static.
6858 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6859 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6860 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6861 * lisp.h (fatal_error_signal_hook): Remove decl.
6862 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6863
f44bd759
PE
6864 * editfns.c: Move a (normally-unused) function to its only use.
6865 * editfns.c, lisp.h (get_operating_system_release): Remove.
6866 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6867 worth the hassle of breaking this out.
6868
b532497d
PE
6869 * xterm.c: Make symbols static if they're not exported.
6870 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6871 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6872 (x_destroy_window, x_delete_display):
6873 Now static.
6874 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6875 (x_mouse_leave): Remove; unused.
6876 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6877 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6878 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6879 Remove decls.
6880 (x_mouse_leave): Declare only if WINDOWSNT.
6881 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6882 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6883 USE_X_TOOLKIT.
6884
1675728f
PE
6885 * ftxfont.c: Make symbols static if they're not exported.
6886 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6887 HAVE_FREETYPE.
6888 * font.h (ftxfont_driver): Likewise.
6889
e4cebfca
PE
6890 * xfns.c: Make symbols static if they're not exported.
6891 (x_last_font_name, x_display_info_for_name):
6892 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6893 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6894 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6895 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6896 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6897 (last_show_tip_args): Now static.
6898 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6899 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6900 (x_screen_planes): Remove; unused.
6901 * dispextern.h (x_screen_planes): Remove decl.
6902
5bf46f05
PE
6903 * dispnew.c: Make symbols static if they're not exported.
6904 * dispextern.h (redraw_garbaged_frames, scrolling):
6905 (increment_row_positions): Remove.
6906 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6907 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6908 Now static.
6909 (redraw_garbaged_frames): Remove; unused.
6910
435f4c28
PE
6911 * xfaces.c: Make symbols static if they're not exported.
6912 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6913 Remove decls.
6914 * xterm.h (defined_color): Remove decls.
6915 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6916 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6917 (menu_face_changed_default, defined_color, free_realized_face):
6918 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6919 (ascii_face_of_lisp_face): Remove; unused.
6920
8524aef3
PE
6921 * xdisp.c: Make symbols static if they're not exported.
6922 * dispextern.h (scratch_glyph_row, window_box_edges):
6923 (glyph_to_pixel_coords, set_cursor_from_row):
6924 (get_next_display_element, set_iterator_to_next):
6925 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6926 (show_mouse_face): Remove decls
6927 * frame.h (message_buf_print): Likewise.
6928 * lisp.h (pop_message, set_message, check_point_in_composition):
6929 Likewise.
6930 * xterm.h (set_vertical_scroll_bar): Likewise.
6931 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6932 (message_buf_print, scratch_glyph_row, displayed_buffer):
6933 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6934 (get_next_display_element, show_mouse_face, window_box_edges):
6935 (frame_to_window_pixel_xy, check_point_in_composition):
6936 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6937 (glyph_to_pixel_coords): Remove; unused.
6938
16390cd2
PE
6939 * dired.c (file_name_completion): Now static.
6940
6941 * dbusbind.c (xd_in_read_queued_messages): Now static.
6942
a25f4dfa
PE
6943 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6944 * data.c (circular_list_error): Remove.
6945
14a9c8df
PE
6946 * commands.h (last_point_position, last_point_position_buffer):
6947 (last_point_position_window): Remove decls.
6948 * keyboard.c: Make these variables static.
6949
04f2d78b
CB
6950 * coding.h (coding, code_convert_region, encode_coding_gap):
6951 Remove decls.
74ab6df5
PE
6952 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6953 (iso_code_class, detect_coding, code_convert_region): Now static.
6954 (encode_coding_gap): Remove; unused.
6955
38dfbee1
PE
6956 * chartab.c (chartab_chars, chartab_bits): Now static.
6957
a2cb4e63
PE
6958 * charset.h (charset_iso_8859_1): Remove decl.
6959 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6960 Now static.
6961
127198fd
PE
6962 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6963 * ccl.c (Vccl_program_table): Now static.
6964 (check_ccl_update): Remove; unused.
6965
d85b608f
PE
6966 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6967 * category.h: ... from here.
6968 * category.c (check_category_table, set_category_set): Now static.
6969
31cd66f3
PE
6970 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6971 * lisp.h: Remove these decls.
6972
c358e587
PE
6973 * buffer.c (buffer_count): Remove unused var.
6974
e78aecca
PE
6975 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6976 so that it's not optimized away.
6977 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6978 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6979 exported only to the debugger.
6980
e192d7d3 6981 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6982 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6983
92470028
PE
6984 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6985 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6986 was inaccessible from Lisp.
6987 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6988 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6989
244ed907
PE
6990 alloc.c: Import and export fewer symbols, and remove unused items.
6991 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6992 is defined.
6993 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6994 it's not optimized away by whole-program optimization.
6995 (message_enable_multibyte, free_misc): Remove.
6996 (catchlist, handlerlist, mark_backtrace):
6997 Declare only if BYTE_MARK_STACK.
6998 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6999 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7000 (message_enable_multibyte): Remove decl.
7001 (free_misc, interval_free_list, float_block, float_block_index):
7002 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7003 (cons_free_list, last_marked_index):
7004 Now static.
7005 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7006 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7007 (mark_backtrace): Define only if BYTE_MARK_STACK.
7008 * xdisp.c (message_enable_multibyte): Now static.
7009
61c2b50e 7010 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7011 This makes it easier for human readers (and static analyzers)
7012 to see whether these variables are used from other modules.
7013 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7014 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7015 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7016 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7017 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7018 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7019 * xmenu.c, xselect.c:
7020 Declare Q* vars static if they are not used in other modules.
7021 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7022 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7023 Remove decls of unexported vars.
7024 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7025
95c82688
PE
7026 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7027
16a97296
PE
7028 Make Emacs functions such as Fatom 'static' by default.
7029 This makes it easier for human readers (and static analyzers)
7030 to see whether these functions can be called from other modules.
7031 DEFUN now defines a static function. To make the function external
7032 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7033 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7034 (Finit_image_library):
16a97296
PE
7035 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7036 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7037 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7038 Remove decls, since these functions are now static.
7039 (Funintern, Fget_internal_run_time): New decls, since these functions
7040 were already external.
95c82688 7041
16a97296
PE
7042 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7043 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7044 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7045 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7046 * keyboard.c, keymap.c, lread.c:
7047 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7048 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7049 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7050 Mark functions with DEFUE instead of DEFUN,
7051 if they are used in other modules.
7052 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7053 decls for now-static functions.
7054 * buffer.h (Fdelete_overlay): Remove decl.
7055 * callproc.c (Fgetenv_internal): Mark as internal.
7056 * composite.c (Fremove_list_of_text_properties): Remove decl.
7057 (Fcomposition_get_gstring): New forward static decl.
7058 * composite.h (Fcomposite_get_gstring): Remove decl.
7059 * dired.c (Ffile_attributes): New forward static decl.
7060 * doc.c (Fdocumntation_property): New forward static decl.
7061 * eval.c (Ffetch_bytecode): New forward static decl.
7062 (Funintern): Remove extern decl; now in .h file where it belongs.
7063 * fileio.c (Fmake_symbolic_link): New forward static decl.
7064 * image.c (Finit_image_library): New forward static decl.
7065 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7066 * intervals.h (Fprevious_property_change):
7067 (Fremove_list_of_text_properties): Remove decls.
7068 * keyboard.c (Fthis_command_keys): Remove decl.
7069 (Fcommand_execute): New forward static decl.
7070 * keymap.c (Flookup_key): New forward static decl.
7071 (Fcopy_keymap): Now static.
7072 * keymap.h (Flookup_key): Remove decl.
7073 * process.c (Fget_process): New forward static decl.
7074 (Fprocess_datagram_address): Mark as internal.
7075 * syntax.c (Fsyntax_table_p): New forward static decl.
7076 (skip_chars): Remove duplicate decl.
7077 * textprop.c (Fprevious_property_change): New forward static decl.
7078 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7079 Now internal.
7080 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7081 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7082
785bbd42
PE
7083 * editfns.c (Fformat): Remove unreachable code.
7084
8b913b57
AS
70852011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7086
7087 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7088 change. (Bug#8496)
7089
a6744a35
EZ
70902011-04-13 Eli Zaretskii <eliz@gnu.org>
7091
7092 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7093 when at ZV. (Bug#8487)
7094
e7974947
AS
70952011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7096
baad03f0
AS
7097 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7098 (Bug#8437)
7099 * keyboard.c (parse_tool_bar_item): Likewise.
7100 * sound.c (sound_cleanup, alsa_close): Likewise.
7101 * termcap.c (tgetent): Likewise.
7102 * xfns.c (x_default_font_parameter): Likewise.
7103 * xsettings.c (read_and_apply_settings): Likewise.
7104
e7974947
AS
7105 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7106 (overrun_check_free): Protoize.
7107
28272684
PE
71082011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7109
7110 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7111 since callers should never pass a negative size.
7112 Change the signature to match that of plain 'read' and 'write'; see
7113 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7114 * lisp.h: Update prototypes of emacs_write and emacs_read.
7115
11997c76
EZ
71162011-04-11 Eli Zaretskii <eliz@gnu.org>
7117
7118 * xdisp.c (redisplay_window): Don't try to determine the character
7119 position of the scroll margin if the window start point w->startp
e896f03c 7120 is outside the buffer's accessible region. (Bug#8468)
11997c76 7121
8a2cbd72
EZ
71222011-04-10 Eli Zaretskii <eliz@gnu.org>
7123
7124 Fix write-region and its subroutines for buffers > 2GB.
7125 * fileio.c (a_write, e_write): Modify declaration of arguments and
7126 local variables to support buffers larger than 2GB.
7127 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7128
7129 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7130 argument, local variables, and return value.
7131
7132 * lisp.h: Update prototypes of emacs_write and emacs_read.
7133
7134 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7135
4073e537 71362011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7137
1ebfdcb6
PE
7138 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7139
b2ded58d
PE
7140 Fix more problems found by GCC 4.6.0's static checks.
7141
7d66342c
PE
7142 * xdisp.c (vmessage): Use a better test for character truncation.
7143
bbf47d44
PE
7144 * charset.c (load_charset_map): <, not <=, for optimization,
7145 and to avoid potential problems with integer overflow.
9248994d 7146 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7147 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7148 * editfns.c (Fformat): Likewise.
1e69125e 7149 * syntax.c (skip_chars): Likewise.
3befa583 7150
e3019616
PE
7151 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7152 This also lets GCC 4.6.0 generate slightly better loop code.
7153
becfa255
PE
7154 * callint.c (Fcall_interactively): <, not <=, for optimization.
7155 (Fcall_interactively): Count the number of arguments produced,
7156 not the number of arguments given. This is simpler and lets GCC
7157 4.6.0 generate slightly better code.
7158
dae0cd48
PE
7159 * ftfont.c: Distingish more carefully between FcChar8 and char.
7160 The previous code passed unsigned char * to a functions like
7161 strlen and xstrcasecmp that expect char *, which does not
7162 conform to the C standard.
7163 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7164 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7165 char * when the C standard requires it.
7166
76032d70
PE
7167 * keyboard.c (read_char): Remove unused var.
7168
eb3f1cc8
PE
7169 * eval.c: Port to Windows vsnprintf (Bug#8435).
7170 Include <limits.h>.
7171 (SIZE_MAX): Define if the headers do not.
7172 (verror): Do not give up if vsnprintf returns a negative count.
7173 Instead, grow the buffer. This ports to Windows vsnprintf, which
7174 does not conform to C99. Problem reported by Eli Zaretskii.
7175 Also, simplify the allocation scheme, by avoiding the need for
7176 calling realloc, and removing the ALLOCATED variable.
7177
70476b54
PE
7178 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7179
12020a9e
PE
7180 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7181 But keep the doprint source code for now, as we might revamp it
7182 and use it again (Bug#8435).
ea6c7ae6
PE
7183 * lisp.h (doprnt): Remove.
7184 * Makefile.in (base_obj): Remove doprnt.o.
7185 * deps.mk (doprnt.o): Remove.
7186
5fdb398c
PE
7187 error: Print 32- and 64-bit integers portably (Bug#8435).
7188 Without this change, on typical 64-bit hosts error ("...%d...", N)
7189 was used to print both 32- and 64-bit integers N, which relied on
7190 undefined behavior.
7191 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7192 New macro.
7193 * lisp.h (error, verror): Mark as printf-like functions.
7194 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7195 Report overflow in size calculations when allocating printf buffer.
7196 Do not truncate output string at its first null byte.
7197 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7198 Truncate the output at a character boundary, since vsnprintf does not
7199 do that.
7200 * charset.c (check_iso_charset_parameter): Convert internal
7201 character to string before calling 'error', since %c now has the
7202 printf meaning.
7203 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7204 overflow when computing char to be passed to 'error'. Do not
7205 pass Lisp_Object to 'error'; pass the integer instead.
7206 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7207 formatted with plain %d.
7208
b189fa66
PE
7209 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7210
bff87ef0
PE
7211 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7212
7e2cac20
PE
7213 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7214
ce4d90b5
PE
7215 * xterm.c (x_catch_errors): Remove duplicate declaration.
7216
266c9547
PE
7217 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7218
79c49ad2
PE
7219 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7220
368f4090
JM
72212011-04-10 Jim Meyering <meyering@redhat.com>
7222
7223 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7224 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7225 return ssize_t not "int", and use size_t as the buffer length.
7226 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7227 * gnutls.h: Update declarations.
7228 * process.c (read_process_output): Use ssize_t, to match.
7229 (send_process): Likewise.
7230
a32d4040
CY
72312011-04-09 Chong Yidong <cyd@stupidchicken.com>
7232
7233 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7234
8546720e 72352011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7236
04f2d78b
CB
7237 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7238 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7239
8546720e
GM
7240 * xterm.c (handle_one_xevent):
7241 * xmenu.c (create_and_show_popup_menu):
7242 * xselect.c (x_decline_selection_request)
7243 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7244
0a2f5c1a 72452011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7246
7247 Fix some uses of `int' instead of EMACS_INT.
7248 * search.c (string_match_1, fast_string_match)
7249 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7250 (scan_buffer, find_next_newline_no_quit)
7251 (find_before_next_newline, search_command, Freplace_match)
7252 (Fmatch_data): Make some `int' variables be EMACS_INT.
7253
7254 * xdisp.c (display_count_lines): 3rd argument and return value now
7255 EMACS_INT. All callers changed.
7256 (pint2hrstr): Last argument is now EMACS_INT.
7257
7258 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7259 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7260 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7261 (decode_coding_utf_16, decode_coding_emacs_mule)
7262 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7263 (decode_coding_ccl, decode_coding_charset)
7264 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7265 (decode_coding_iso_2022, decode_coding_emacs_mule)
7266 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7267 <char_offset, last_offset>: Declare EMACS_INT.
7268 (encode_coding_utf_8, encode_coding_utf_16)
7269 (encode_coding_emacs_mule, encode_invocation_designation)
7270 (encode_designation_at_bol, encode_coding_iso_2022)
7271 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7272 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7273 Declare EMACS_INT.
7274 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7275 (encode_invocation_designation): Last argument P_NCHARS is now
7276 EMACS_INT.
7277 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7278 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7279
7280 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7281 All users changed.
7282
7283 * ccl.c (Fccl_execute_on_string): Declare some variables
7284 EMACS_INT.
7285
8546720e 72862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7287
7288 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7289
4e19a977
CS
72902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7291
7292 * process.c (Fformat_network_address): Doc fix.
7293
87302331
R
72942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7295
ee7683eb 7296 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7297
cbb59342
CY
72982011-04-08 Chong Yidong <cyd@stupidchicken.com>
7299
7300 * keyboard.c (read_char): Call Lisp function help-form-show,
7301 instead of using internal_with_output_to_temp_buffer.
7302 (Qhelp_form_show): New var.
e0d38eeb 7303 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7304
7305 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7306
7307 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7308
e67a13ab
CY
73092011-04-06 Chong Yidong <cyd@stupidchicken.com>
7310
04f2d78b
CB
7311 * process.c (Flist_processes): Remove to Lisp.
7312 (list_processes_1): Delete.
e67a13ab 7313
973f782d
EZ
73142011-04-06 Eli Zaretskii <eliz@gnu.org>
7315
7c106b1e
EZ
7316 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7317
973f782d
EZ
7318 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7319
41cf7d1a 73202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7321
ca23cc88
PE
7322 Fix more problems found by GCC 4.6.0's static checks.
7323
f390e2d5
PE
7324 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7325
42eea0d0
PE
7326 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7327
b69769da 7328 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7329
f9541e84
PE
7330 * xdisp.c (vmessage): Mark as a printf-like function.
7331
13841b55
PE
7332 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7333
c136c10f
PE
7334 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7335
5e2d4a30
PE
7336 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7337 printf-like functions.
7338 (tiff_load): Add casts to remove these marks before passing them
7339 to system-supplied API.
7340
583f48b9
PE
7341 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7342
b25d760e
PE
7343 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7344 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7345 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7346 directly, rather than having caller test rule sign. This avoids
7347 some unnecessary tests.
7348 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7349 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7350 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7351
bc7b6697 7352 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7353 (xfont_open): Avoid unnecessary tests.
bc7b6697 7354
27ccc379
PE
7355 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7356
dcd5c89a
PE
7357 * composite.h, composite.c (composition_gstring_put_cache):
7358 Use EMACS_INT, not int, for length.
7359
b13a45c6
PE
7360 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7361 breaking out part of COMPOSITION_DECODE_RULE.
7362 (COMPOSITION_DECODE_RULE): Use it.
7363 * composite.c (get_composition_id): Remove unused local vars,
7364 by using the new macro.
7365
1e792e4d
PE
7366 * textprop.c (set_text_properties_1): Change while to do-while,
7367 since the condition is always true at first.
7368
dc6c6455 7369 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7370 (interval_deletion_adjustment): Return unsigned value.
7371 All uses changed.
dc6c6455 7372
aba7731a
PE
7373 * process.c (list_processes_1, create_pty, read_process_output):
7374 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7375 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7376 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7377 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7378 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7379
fdfc4bf3
PE
7380 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7381
fca8fe46 7382 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7383 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7384
06a0259a 7385 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7386 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7387 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7388
e7b9e80f
PE
7389 * print.c (print_error_message): Avoid int overflow.
7390
56201685
PE
7391 * font.c (font_list_entities): Redo for clarity,
7392 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7393
78834453 7394 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7395 (font_score): Avoid potential overflow in diff calculation.
78834453 7396
0bc0b309 7397 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7398 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7399
e610eaca
PE
7400 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7401
b895abce
PE
7402 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7403 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7404 can always succeed if overflow has undefined behavior.
7405
1f1d9321 7406 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7407 (wordify): Omit three unnecessary tests.
1f1d9321 7408
c59478bc
PE
7409 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7410 All callers changed. This avoids the need for an unused var.
7411
79b73827
PE
7412 * casefiddle.c (casify_region): Remove var that is set but not used.
7413
a4db5dfe
PE
7414 * dired.c (file_name_completion): Remove var that is set but not used.
7415
43aae36e
PE
7416 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7417
2a47c44d 7418 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7419 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7420
a37c69bf
PE
7421 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7422 Check for integer overflow on size calculations.
7423
328ab8e7
PE
7424 * buffer.c (Fprevious_overlay_change): Remove var that is set
7425 but not used.
7426
e5a2a5cb
PE
7427 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7428 Remove vars that are set but not used.
8d84a6eb 7429 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7430 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7431
a60e5f68
PE
7432 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7433
f661cb61 7434 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7435 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7436
f0397f5a
PE
7437 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7438 that are set but not used.
7439
8664db06 7440 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7441 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7442
6abdaa4a
PE
7443 * xselect.c (x_get_local_selection, x_handle_property_notify):
7444 Remove vars that are set but not used.
7445
0ce7538d 7446 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7447 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7448
9ae848fc
PE
7449 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7450 Remove var that is set but not used.
0b918413
PE
7451 (scroll_bar_windows_size): Now size_t, not int.
7452 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7453 Check for overflow.
9ae848fc 7454
a5a62657
PE
7455 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7456 (map_tty_color) [!defined MSDOS]: Likewise.
7457
5c5cdd39
PE
7458 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7459
66ebf983
PE
7460 * coding.c: Remove vars that are set but not used.
7461 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7462 All callers changed.
7463 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7464 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7465 (decode_coding_charset): Remove vars that are set but not used.
7466
1be4d761
PE
7467 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7468 that is set but not used.
7469
47553fa8
PE
7470 * print.c (print_object): Remove var that is set but not used.
7471
1f7196bf 7472 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7473 The gnulib version avoids calling malloc in the usual case,
7474 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7475 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7476 * filelock.c (current_lock_owner): Likewise.
7477 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7478 * sysdep.c: Include allocator.h, careadlinkat.h.
7479 (emacs_no_realloc_allocator): New static constant.
7480 (emacs_readlink): New function.
fdb61804
PE
7481 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7482 ../lib/careadlinkat.h.
d1fdcab7 7483
f84c17c7
SM
74842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7485
7486 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7487 first non-nil return value).
7488
ef3862ad
JD
74892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7490
7491 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7492 if not defined (Bug#8403).
7493
376a7006
JB
74942011-04-02 Juanma Barranquero <lekktu@gmail.com>
7495
7496 * xdisp.c (display_count_lines): Remove parameter `start',
7497 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7498 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7499 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7500 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7501 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7502 and thereabouts. All callers changed.
7503 (get_per_char_metric): Remove parameter `f', unused since
7504 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7505
6ca3801d
JM
75062011-04-02 Jim Meyering <meyering@redhat.com>
7507
7508 do not dereference NULL upon failed strdup
7509 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7510 (ns_get_family): Likewise.
7511
d8e2b5ba
JB
75122011-04-02 Juanma Barranquero <lekktu@gmail.com>
7513
7514 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7515
8c74fcbd
JD
75162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7517
7518 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7519 later (Bug#8403).
7520
7200d79c
SM
75212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7522
03408648 7523 Add lexical binding.
7200d79c 7524
03408648
SM
7525 * window.c (Ftemp_output_buffer_show): New fun.
7526 (Fsave_window_excursion):
7527 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7528
7529 * lread.c (lisp_file_lexically_bound_p): New function.
7530 (Fload): Bind Qlexical_binding.
7531 (readevalloop): Remove `evalfun' arg.
7532 Bind Qinternal_interpreter_environment.
7533 (Feval_buffer): Bind Qlexical_binding.
7534 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7535 Mark as dynamic.
7536 (syms_of_lread): Declare `lexical-binding'.
7537
7538 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7539
7540 * keyboard.c (eval_dyn): New fun.
7541 (menu_item_eval_property): Use it.
ca105506
SM
7542
7543 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7544
03408648
SM
7545 * fns.c (concat, mapcar1): Accept byte-code-functions.
7546
7547 * eval.c (Fsetq): Handle lexical vars.
7548 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7549 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7550 (FletX, Flet): Obey lexical binding.
7551 (Fcommandp): Handle closures.
7552 (Feval): New `lexical' arg.
7553 (eval_sub): New function extracted from Feval. Use it almost
7554 everywhere where Feval was used. Look up vars in lexical env.
7555 Handle closures.
7556 (Ffunctionp): Move from subr.el.
7557 (Ffuncall): Handle closures.
7558 (apply_lambda): Remove `eval_flags'.
7559 (funcall_lambda): Handle closures and new byte-code-functions.
7560 (Fspecial_variable_p): New function.
7561 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7562 but without exporting it to Lisp.
23aba0ea 7563
23aba0ea 7564 * doc.c (Fdocumentation, store_function_docstring):
03408648 7565 * data.c (Finteractive_form): Handle closures.
23aba0ea 7566
03408648
SM
7567 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7568 interactive spec.
ba83908c 7569
04f2d78b
CB
7570 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7571 New byte-codes.
03408648
SM
7572 (exec_byte_code): New function extracted from Fbyte_code to handle new
7573 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7574
03408648 7575 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7576
03408648 7577 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7578
e2abce01
JB
75792011-03-31 Juanma Barranquero <lekktu@gmail.com>
7580
7581 * xdisp.c (redisplay_internal): Fix prototype.
7582
63696a73 75832011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7584
63696a73 7585 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7586 (try_scrolling): Use it when setting scroll_limit.
7587 Limit scrolling to 100 screen lines.
63696a73
EZ
7588 (redisplay_window): Even when falling back on "recentering",
7589 position point in the window according to scroll-conservatively,
7590 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7591
7592 (try_scrolling): When point is above the window, allow searching
7593 as far as scroll_max, or one screenful, to compute vertical
7594 distance from PT to the scroll margin position. This prevents
7595 try_scrolling from unnecessarily failing when
7596 scroll-conservatively is set to a value slightly larger than the
7597 window height. Clean up the case of PT below the margin at bottom
7598 of window: scroll_max can no longer be INT_MAX. When aggressive
7599 scrolling is in use, don't let point enter the opposite scroll
7600 margin as result of the scroll.
7601 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7602 threshold of 100 lines for never-recentering scrolling.
7603
e4cc2dfc
JB
76042011-03-31 Juanma Barranquero <lekktu@gmail.com>
7605
7606 * dispextern.h (move_it_by_lines):
7607 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7608 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7609 (message_log_check_duplicate): Remove parameters `prev_bol' and
7610 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7611 (redisplay_internal): Remove parameter `preserve_echo_area',
7612 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7613
7614 * indent.c (Fvertical_motion):
7615 * window.c (window_scroll_pixel_based, Frecenter):
7616 Don't pass `need_y_p' to `move_it_by_lines'.
7617
1c470562
SM
76182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7619
44f230aa
SM
7620 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7621 steal a few bits to be more compact.
7622 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7623 Remove unneeded casts.
7624
1c470562
SM
7625 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7626
888adce9
ZK
76272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7628
7629 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7630 binding" message (bug#7967).
7631
f838ed7b
PE
76322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7633
77861b95
PE
7634 Fix more problems found by GCC 4.6.0's static checks.
7635
de6dbc14
PE
7636 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7637 Remove unused local var.
7638
f838ed7b
PE
7639 * editfns.c (Fmessage_box): Remove unused local var.
7640
792c7b2b
PE
7641 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7642 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7643 Omit unused local vars.
c499e557 7644 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7645 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7646 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7647 Omit unused local var.
7648
ba0165e1
PE
7649 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7650 Don't assume string length fits in int.
32ad8845 7651 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7652 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7653
3c59b4c9
PE
7654 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7655 instead of alloca (Bug#8344).
7656
a3eed478 7657 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7658 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7659
eb4d412d
PE
7660 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7661
1658b401
PE
7662 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7663 concerns.
7664
7665 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7666
7667 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7668
9a2c6e05
PE
7669 * keyboard.c (syms_of_keyboard): Use the same style as later
7670 in this function when indexing through an array. This also
7671 works around GCC bug 48267.
7672
03d0a109
PE
7673 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7674
44f730c8
PE
7675 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7676
fe75f926
PE
7677 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7678 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7679
ffa8c828
PE
7680 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7681 This avoids undefined behavior on integer overflow, and is a bit
7682 more convenient anyway since it is compared to a size_t variable.
7683
c5101a77
PE
7684 Variadic C functions now count arguments with size_t, not int.
7685 This avoids an unnecessary limitation on 64-bit machines, which
7686 caused (substring ...) to crash on large vectors (Bug#8344).
7687 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7688 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7689 All variadic functions and their callers changed accordingly.
c5101a77
PE
7690 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7691 * data.c (arith_driver, float_arith_driver): Likewise.
7692 * editfns.c (general_insert_function): Likewise.
7693 * eval.c (struct backtrace.nargs, interactive_p)
7694 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7695 (funcall_lambda, mark_backtrace): Likewise.
7696 * fns.c (concat): Likewise.
7697 * frame.c (x_set_frame_parameters): Likewise.
7698 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7699 0 if not found, not -1. All callers changed.
7700
dd3f25f7
PE
7701 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7702 (stack_copy_size): Now size_t, not int.
7703 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7704
461c2ab9
JB
77052011-03-28 Juanma Barranquero <lekktu@gmail.com>
7706
7707 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7708 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7709 All callers changed.
7710
7711 * lisp.h (multibyte_char_to_unibyte):
7712 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7713 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7714 * character.h (CHAR_TO_BYTE8):
7715 * cmds.c (internal_self_insert):
7716 * editfns.c (general_insert_function):
7717 * keymap.c (push_key_description):
7718 * search.c (Freplace_match):
7719 * xdisp.c (message_dolog, set_message_1): All callers changed.
7720
f6d62986
SM
77212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7722
7723 * keyboard.c (safe_run_hook_funcall): New function.
7724 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7725 don't set the hook to nil, but remove the offending function instead.
7726 (Qcommand_hook_internal): Remove, unused.
7727 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7728 Vcommand_hook_internal.
7729
7730 * eval.c (enum run_hooks_condition): Remove.
7731 (funcall_nil, funcall_not): New functions.
7732 (run_hook_with_args): Call each function through a `funcall' argument.
7733 Remove `cond' argument, now redundant.
7734 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7735 (Frun_hook_with_args_until_failure): Adjust accordingly.
7736 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7737
1db5b1ad
JB
77382011-03-28 Juanma Barranquero <lekktu@gmail.com>
7739
7740 * dispextern.h (string_buffer_position): Remove declaration.
7741
7742 * print.c (strout): Remove parameter `multibyte', unused since
7743 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7744
7745 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7746 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7747 All callers changed.
7748
7749 * w32.c (_wsa_errlist): Use braces for struct initializers.
7750
7751 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7752 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7753 All callers changed.
7754 (string_buffer_position): Likewise. Also, make static (it's never
7755 used outside xdisp.c).
7756 (cursor_row_p): Remove parameter `w', unused since
7757 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7758 (decode_mode_spec): Remove parameter `precision', introduced during
7759 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7760 All callers changed.
7761
5ffb62aa
JD
77622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7763
7764 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7765
461c2ab9 77662011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7767
7768 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7769 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7770 (ns_update_auto_hide_menu_bar): New functions.
7771 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7772 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7773 ns_constrain_all_frames.
7774 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7775 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7776
5c380ffb
JD
77772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7778
7779 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7780
9af30bdf
GM
77812011-03-27 Glenn Morris <rgm@gnu.org>
7782
7783 * syssignal.h: Replace RETSIGTYPE with void.
7784 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7785 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7786 Replace SIGTYPE with void everywhere.
7787 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7788 * s/template.h (SIGTYPE): Remove commented out definition.
7789
e2abce01
JB
77902011-03-26 Eli Zaretskii <eliz@gnu.org>
7791
7792 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7793 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7794
f868cd8a
JB
77952011-03-26 Juanma Barranquero <lekktu@gmail.com>
7796
59eb0929
JB
7797 * w32.c (read_unc_volume): Use parameter `henum', instead of
7798 global variable `wget_enum_handle'.
7799
7800 * keymap.c (describe_vector): Remove parameters `indices' and
7801 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7802 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7803
f868cd8a
JB
7804 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7805
7806 * keyboard.c (timer_check): Remove parameter `do_it_now',
7807 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7808 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7809 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7810
7811 * keyboard.c (read_char):
7812 * w32menu.c (w32_menu_display_help):
7813 * xmenu.c (show_help_event, menu_help_callback):
7814 Adjust calls to `show_help_echo'.
7815
7816 * gtkutil.c (xg_maybe_add_timer):
7817 * keyboard.c (readable_events):
7818 * process.c (wait_reading_process_output):
7819 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7820
7821 * insdel.c (adjust_markers_gap_motion):
7822 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7823 (gap_left, gap_right): Don't call it.
7824
2ecf6fdb
CY
78252011-03-25 Chong Yidong <cyd@stupidchicken.com>
7826
7827 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7828 incurred during fontification.
7829
6b1f9ba4
JB
78302011-03-25 Juanma Barranquero <lekktu@gmail.com>
7831
7832 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7833 (DEFVAR_PER_BUFFER): Don't pass it.
7834
7835 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7836 (scrolling_window): Don't pass it.
7837
0f4a96b5
JB
78382011-03-25 Juanma Barranquero <lekktu@gmail.com>
7839
7840 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7841
7842 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7843 and `suffix'.
7844 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7845 of variables specific to SELinux and computation of `encoded_absname'.
7846
7847 * image.c (XPutPixel): Remove unused variable `height'.
7848
7849 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7850
7851 * unexw32.c (get_section_info): Remove unused variable `section'.
7852
7853 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7854 (system_process_attributes): Remove unused variable `sess'.
7855 (sys_read): Remove unused variable `err'.
7856
7857 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7858 (w32_wnd_proc): Remove unused variable `isdead'.
7859 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7860 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7861 (x_create_tip_frame): Remove unused variable `tem'.
7862
7863 * w32inevt.c (w32_console_read_socket):
7864 Remove unused variable `no_events'.
7865
7866 * w32term.c (x_draw_composite_glyph_string_foreground):
7867 Remove unused variable `width'.
7868
1149507c
JB
78692011-03-24 Juanma Barranquero <lekktu@gmail.com>
7870
7871 * w32term.c (x_set_glyph_string_clipping):
7872 Don't pass uninitialized region to CombineRgn.
7873
9c88f339
JB
78742011-03-23 Juanma Barranquero <lekktu@gmail.com>
7875
7876 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7877 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7878 (Fx_close_connection): Remove unused variable `i'.
7879
7880 * w32font.c (w32font_draw): Return number of glyphs.
7881 (w32font_open_internal): Remove unused variable `i'.
7882 (w32font_driver): Add missing initializer.
7883
7884 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7885 (fill_in_menu): Remove unused variable `items_added'.
7886
7887 * w32term.c (last_mouse_press_frame): Remove static global variable.
7888 (w32_clip_to_row): Remove unused variable `f'.
7889 (x_delete_terminal): Remove unused variable `i'.
7890
7891 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7892 (NOTHING): Remove unused static global variable.
7893 (uniscribe_check_otf): Remove unused variable `table'.
7894 (uniscribe_font_driver): Add missing initializers.
7895
dee091a3
JD
78962011-03-23 Julien Danjou <julien@danjou.info>
7897
7898 * term.c (Fsuspend_tty, Fresume_tty):
7899 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7900 * window.c (temp_output_buffer_show):
7901 * insdel.c (signal_before_change):
7902 * frame.c (Fhandle_switch_frame):
7903 * fileio.c (Fdo_auto_save):
7904 * emacs.c (Fkill_emacs):
7905 * editfns.c (save_excursion_restore):
7906 * cmds.c (internal_self_insert):
7907 * callint.c (Fcall_interactively):
7908 * buffer.c (Fkill_all_local_variables):
7909 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7910 Use Frun_hooks.
0f4a96b5 7911 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7912 unconditionally since it does the check itself.
dee091a3 7913
2c520ab5 79142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7915
c9c49752
PE
7916 Fix more problems found by GCC 4.5.2's static checks.
7917
8abc3f12
PE
7918 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7919 the first time through the loop, since we know p0 < p1 then.
7920 This also avoids a gcc -Wstrict-overflow warning.
7921
a2d26660
PE
7922 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7923 leading to a memory leak, possible in functions like
7924 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7925 of objects (Bug#8318).
a2d26660 7926
916c72e9
PE
7927 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7928 that could (at least in theory) be that large.
7929
19ab8a18
PE
7930 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7931 This is less likely to overflow, and avoids undefined behavior if
7932 overflow does occur. All callers changed. Use strtoul to scan
7933 for the unsigned long integer.
b7cbbd6f
PE
7934 (pint2hrstr): Simplify and tune code slightly.
7935 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7936
f0641eff
PE
7937 * scroll.c (do_scrolling): Work around GCC bug 48228.
7938 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7939
7f650bb9
PE
7940 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7941 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7942 (validate_x_resource_name): Simplify count usage.
7943 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7944
37dd57d1
PE
7945 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7946 fail (Bug#8306).
81e56e61 7947
699979fc 7948 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7949
401bf9b4
PE
7950 * process.c (Fmake_network_process): Use socklen_t, not int,
7951 where POSIX says socklen_t is required in portable programs.
7952 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7953 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7954 (Fmake_network_process, server_accept_connection):
7955 (wait_reading_process_output, read_process_output):
7956 Likewise.
7957
b93aacde
PE
7958 * process.c: Rename or move locals to avoid shadowing.
7959 (list_processes_1, Fmake_network_process):
7960 (read_process_output_error_handler, exec_sentinel_error_handler):
7961 Rename or move locals.
4dc343ee 7962 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7963 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7964 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7965 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7966 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7967
af8a867c 7968 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7969 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7970 Include tparam.h instead, since it declares them.
af8a867c
PE
7971 * cm.h (PC): Remove extern decl; tparam.h now does this.
7972 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7973 * terminfo.c: Include tparam.h, to check interfaces.
7974 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7975 (tparam): Adjust signature to match interface in tparam.h;
7976 this removes some undefined behavior. Check that outstring and len
7977 are zero, which they always are with Emacs.
7978 * tparam.h (PC, BC, UP): New extern decls.
7979
0248044d 7980 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7981 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7982
8ff096c1 7983 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7984 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7985 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7986 (ftfont_list): Remove unused local.
49eaafba
PE
7987 (get_adstyle_property, ftfont_pattern_entity):
7988 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7989 Rename locals to avoid shadowing.
8ff096c1 7990
e2be39f6
PE
7991 * xfont.c (xfont_list_family): Mark var as initialized.
7992
c9735e30
PE
7993 * xml.c (make_dom): Now static.
7994
8f5201ae
PE
7995 * composite.c (composition_compute_stop_pos): Rename local to
7996 avoid shadowing.
b246f932
PE
7997 (composition_reseat_it): Remove unused locals.
7998 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7999 (composition_update_it): Mark var as initialized.
11b61122
PE
8000 (find_automatic_composition): Mark vars as initialized,
8001 with a FIXME (Bug#8290).
8f5201ae 8002
760fbc2c
PE
8003 character.h: Rename locals to avoid shadowing.
8004 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8005 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8006 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8007 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8008 to avoid shadowing.
8009
ff08eb85
PE
8010 * textprop.c (property_change_between_p): Remove; unused.
8011
fc7bf025
PE
8012 * intervals.c (interval_start_pos): Now static.
8013
235d7abc
PE
8014 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8015
44f230aa
SM
8016 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8017 Rename locals to avoid shadowing.
3e7d6594 8018
50060332
PE
8019 * sound.c (wav_play, au_play, Fplay_sound_internal):
8020 Fix pointer signedness.
d01f234b 8021 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8022 (wav_play): Initialize a variable to 0, to prevent undefined
8023 behavior (Bug#8278).
50060332 8024
c4fc4e30
PE
8025 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8026
918436ed
PE
8027 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8028
c939f91b
PE
8029 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8030 clobbering (Bug#8298).
b9c7f648
PE
8031 * sysdep.c (sys_subshell): Likewise.
8032 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8033
6bd8c144
PE
8034 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8035 This should get cleaned up, so that child_setup has the
8036 same signature on all platforms.
8037
7710357c 8038 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8039 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8040
c59da222
CY
80412011-03-22 Chong Yidong <cyd@stupidchicken.com>
8042
8043 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8044 not to be necessary, and produces flickering.
8045
66b87493
GM
80462011-03-20 Glenn Morris <rgm@gnu.org>
8047
8048 * config.in: Remove file.
8049
45b6f6d5
JB
80502011-03-20 Juanma Barranquero <lekktu@gmail.com>
8051
8052 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8053 are now in src/globals.h.
8054 (syms_of_minibuf): Remove spurious & from previous change.
8055
3ec03f7e
LL
80562011-03-20 Leo <sdl.web@gmail.com>
8057
8058 * minibuf.c (completing-read-function): New variable.
8059 (completing-read-default): Rename from completing-read.
8060 (completing-read): Call completing-read-function.
8061
b14e3e21
CY
80622011-03-19 Juanma Barranquero <lekktu@gmail.com>
8063
8064 * xfaces.c (Fx_load_color_file):
8065 Read color file from absolute filename (bug#8250).
8066
f2b726e6
JB
80672011-03-19 Juanma Barranquero <lekktu@gmail.com>
8068
8069 * makefile.w32-in: Update dependencies.
8070
09f6ff02
EZ
80712011-03-17 Eli Zaretskii <eliz@gnu.org>
8072
8073 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8074
29a6015a
PE
80752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8076
a3a6c54e
PE
8077 Fix more problems found by GCC 4.5.2's static checks.
8078
b766f867
PE
8079 * process.c (make_serial_process_unwind, send_process_trap):
8080 (sigchld_handler): Now static.
8081
be02381c
PE
8082 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8083 That way, the code declares only the vars that it needs.
8084 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8085 * s/cygwin.h (PTY_ITERATION): Likewise.
8086 * s/darwin.h (PTY_ITERATION): Likewise.
8087 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8088
57048744
PE
8089 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8090 * process.c (allocate_pty): Don't declare stb unless it's needed.
8091
7914961c 8092 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8093 (CONSTANTLIM): Remove; unused.
8094 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8095 Define only if needed.
7914961c 8096
b3967b18
PE
8097 * unexelf.c (unexec): Name an expression,
8098 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8099 Use a different way to cause a compilation error if anyone uses
8100 n rather than nn, a way that does not involve shadowing.
73366a00 8101 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8102
29a6015a
PE
8103 * deps.mk (unexalpha.o): Remove; unused.
8104
43cfc33e 8105 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8106 * unexec.h: New file.
ce701a33
PE
8107 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8108 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8109 Depend on unexec.h.
8110 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8111 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8112 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8113 Change as necessary to match prototype in unexec.h.
ce701a33 8114
01f44d5a
PE
8115 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8116 shadowing.
4f63c6bb 8117 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8118
a6670b0b
PE
8119 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8120 Rename locals to avoid shadowing.
8121
cef2010d 8122 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8123 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8124
d4d7173a
PE
8125 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8126
f08b802a
PE
8127 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8128 warning when compiling print.c.
8129
3ddb0639
PE
8130 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8131 instead of using an uninitialized var.
5ad03b97 8132 (font_sort_entities): Mark var as initialized.
3ddb0639 8133
170a2692
PE
8134 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8135
e663c700
PE
8136 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8137 pointers to constants.
89bc529a 8138 (font_parse_fcname): Remove unused vars.
7b81e2d0 8139 (font_delete_unmatched): Now static.
ea838e10 8140 (font_get_spec): Remove; unused.
13a547c6
PE
8141 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8142 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8143 Rename or move locals to avoid shadowing.
e663c700 8144
2a80c887 8145 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8146 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8147
1384fa33 8148 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8149 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8150
8b2c52e9
PE
8151 * alloc.c (mark_backtrace): Move decl from here ...
8152 * lisp.h: ... to here, so that it can be checked.
8153
475545b5 8154 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8155 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8156 (lisp_indirect_variable): Name an expression,
8157 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8158 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8159
b1349114 8160 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8161 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8162 Use const pointer when appropriate.
b1349114 8163
a2928364
PE
8164 * lisp.h (get_system_name, get_operating_system_release):
8165 Move decls here, to check interfaces.
8166 * process.c (get_operating_system_release): Move decl to lisp.h.
8167 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8168 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8169 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8170 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8171 (Fformat_time_string, Fencode_time, Finsert_char):
8172 (Ftranslate_region_internal, Fformat):
8173 Rename or remove local vars to avoid shadowing.
9710023e 8174 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8175
a415e694
PE
8176 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8177 avoid shadowing.
8178
8ef4622d
PE
8179 * lisp.h (eassert): Check that the argument compiles, even if
8180 ENABLE_CHECKING is not defined.
8181
946f9a5b
PE
8182 * data.c (Findirect_variable): Name an expression, to avoid
8183 gcc -Wbad-function-cast warning.
112396d6 8184 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8185 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8186 (Fmake_variable_buffer_local, Fmake_local_variable):
8187 Mark variables as initialized.
52746918 8188 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8189
e5aab7e7 8190 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8191 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8192 Rename locals to avoid shadowing.
dff45157
PE
8193 (mark_stack): Move local variables into the #ifdef region where
8194 they're used.
7bc26fdb
PE
8195 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8196 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8197 needed otherwise.
8198 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8199 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8200 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8201
e5aab7e7
PE
8202 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8203 avoids undefined behavior in theory.
8204
4da60324
PE
8205 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8206
88043301
PE
8207 Use functions, not macros, for up- and down-casing (Bug#8254).
8208 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8209 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8210 to use the following functions instead of these macros.
8211 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8212 EMACS_INT, since callers assume the returned value fits in int.
8213 (upcase1): Likewise, for UPCASE_TABLE.
8214 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8215 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8216 the race-condition problem in the old DOWNCASE.
88043301 8217
19ed5445
PE
8218 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8219 Rename locals to avoid shadowing.
8220 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8221 (regex_compile, re_search_2, re_match_2_internal):
8222 Remove unused local vars.
952db0d7
PE
8223 (FREE_VAR): Rewrite so as not to use empty "else",
8224 which gcc can warn about.
da053e48 8225 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8226 (RETALLOC_IF): Define only if needed.
8227 (WORDCHAR_P): Likewise. This one is never needed, but is used
8228 only in a comment talking about a compiler bug, so put inside
8229 the #if 0 of that comment.
8230 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8231 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8232 Remove; unused.
19ed5445 8233
1f3561e4 8234 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8235 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8236 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8237
ded6f8f7
PE
8238 * search.c (simple_search): Remove unused var.
8239
dbd37a95
PE
8240 * dired.c (compile_pattern): Move decl from here ...
8241 * lisp.h: ... to here, so that it can be checked.
8242 (struct re_registers): New forward decl.
8243
7e47afad
PE
8244 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8245
85f24f61
PE
8246 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8247 All uses changed.
8248 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8249 Rename locals to avoid shadowing.
5671df8f 8250 (Fvertical_motion): Mark locals as initialized.
85f24f61 8251
181aa2be 8252 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8253 (casify_region): Mark local as initialized.
181aa2be 8254
930d429c
PE
8255 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8256
7082eac6
PE
8257 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8258 New macros, so that the caller can use some names other than
8259 gcpro1, gcpro2, etc.
8260 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8261 of the new macros.
8262 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8263 argument, for consistency with GCPRO2_VAR, etc: it is now the
8264 prefix of the variable, not the variable itself. All uses
8265 changed.
38b2c076
PE
8266 * dired.c (directory_files_internal, file_name_completion):
8267 Rename locals to avoid shadowing.
8268
15206ed9
PE
8269 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8270 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8271 dired.c's scmp function, had undefined behavior.
8272 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8273 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8274 * buffer.h: ... to here, because these macros use current_buffer,
8275 and the new implementation with inline functions needs to have
8276 current_buffer in scope now, rather than later when the macros
8277 are used.
8278 (downcase, upcase1): New static inline functions.
8279 (DOWNCASE, UPCASE1): Reimplement using these functions.
8280 This avoids undefined behavior in expressions like
8281 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8282 from race conditions in accessing the global variables
8283 case_temp1 and case_temp2.
8284 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8285 * lisp.h (case_temp1, case_temp2): Remove their decls.
8286 * character.h (ASCII_CHAR_P): Move from here ...
8287 * lisp.h: ... to here, so that the inline functions mentioned
8288 above can use them.
8289
4a6bea26
PE
8290 * dired.c (directory_files_internal_unwind): Now static.
8291
f14b7e14
PE
8292 * fileio.c (file_name_as_directory, directory_file_name):
8293 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8294 Now static.
2893f146
PE
8295 (file_name_as_directory): Use const pointers when appropriate.
8296 (Fexpand_file_name): Likewise. In particular, newdir might
8297 point at constant storage, so make it a const pointer.
fd4ead52 8298 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8299 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8300 signedness issues.
f839df0c
PE
8301 (Fset_file_times, Finsert_file_contents, auto_save_error):
8302 Rename locals to avoid shadowing.
f14b7e14 8303
5716756e 8304 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8305 (Ftry_completion, Fall_completions): Rename or remove locals
8306 to avoid shadowing.
5716756e 8307
b4c3046a
PE
8308 * marker.c (bytepos_to_charpos): Remove; unused.
8309
b45db522
PE
8310 * lisp.h (verify_bytepos, count_markers): New decls,
8311 so that gcc does not warn that these functions aren't declared.
8312
85876d07
PE
8313 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8314 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8315 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8316 (copy_text): Remove unused local var.
85876d07 8317
03d78a21 8318 * filelock.c (within_one_second): Now static.
b3dd38ab 8319 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8320
5df8f01b
PE
8321 * buffer.c (fix_overlays_before): Mark locals as initialized.
8322 (fix_start_end_in_overlays): Likewise. This function should be
8323 simplified by using pointers-to-pointers, but that's a different
8324 matter.
b1d876f1 8325 (switch_to_buffer_1): Now static.
8f54f30a
PE
8326 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8327 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8328
a70072c9 8329 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8330 Fix pointer signedness issue.
edced198
PE
8331 (sys_subshell): Mark local as volatile if checking for lint,
8332 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8333 (MAXPATHLEN): Define only if needed.
a70072c9 8334
a0977c44
PE
8335 * process.c (serial_open, serial_configure): Move decls from here ...
8336 * systty.h: ... to here, so that they can be checked.
8337
a884fdcc
PE
8338 * fns.c (get_random, seed_random): Move extern decls from here ...
8339 * lisp.h: ... to here, so that they can be checked.
8340
604efe86 8341 * sysdep.c (reset_io): Now static.
b8950c94 8342 (wait_for_termination_signal): Remove; unused.
604efe86 8343
38fc62d9
PE
8344 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8345 (copy_keymap_item, append_key, push_text_char_description):
8346 Now static.
1004a21a 8347 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8348 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8349 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8350 (describe_map_tree):
8351 Rename locals to avoid shadowing.
38fc62d9 8352
2f2650da
PE
8353 * keyboard.c: Declare functions static if they are not used elsewhere.
8354 (echo_char, echo_dash, cmd_error, top_level_2):
8355 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8356 (read_char, kbd_buffer_get_event, make_lispy_position):
8357 (make_lispy_event, make_lispy_movement, apply_modifiers):
8358 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8359 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8360 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8361 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8362 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8363
a053e86c 8364 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8365 (mark_kboards): Move decl here ...
8366 * alloc.c (mark_kboards): ... from here.
a053e86c 8367
4752793e
PE
8368 * lisp.h (force_auto_save_soon): New decl.
8369
74f10ca7 8370 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8371 (DEFINE_DUMMY_FUNCTION): New macro.
8372 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8373 Use it.
c03cd23f
PE
8374 (main): Add casts to avoid warnings
8375 if GCC considers string literals to be constants.
74f10ca7 8376
022e70d4
PE
8377 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8378
59d6fe83
PE
8379 * dbusbind.c: Pointer signedness fixes.
8380 (xd_signature, xd_append_arg, xd_initialize):
8381 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8382 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8383 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8384 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8385
78320123
PE
8386 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8387 if GCC considers string literals to be constants.
49cebcca 8388 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8389
35ac2a97
SM
83902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8391
fb103ca9
SM
8392 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8393 (print_preprocess, print_object): New macro to fix last change.
8394
35ac2a97
SM
8395 * print.c (print_preprocess): Don't forget font objects.
8396
62973b41
JB
83972011-03-16 Juanma Barranquero <lekktu@gmail.com>
8398
8399 * emacs.c (USAGE3): Doc fixes.
8400
0e48bb22
AS
84012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8402
8403 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8404 structure.
8405
7684e57b
JB
84062011-03-14 Juanma Barranquero <lekktu@gmail.com>
8407
8408 * lisp.h (VWindow_system, Qfile_name_history):
8409 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8410 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8411 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8412
8413 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8414 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8415
8416 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8417 * w32console.c (detect_input_pending, read_input_pending)
8418 (encode_terminal_code):
8419 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8420 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8421 (w32_system_caret_y, Qfile_name_history):
8422 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8423 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8424 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8425 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8426 * w32proc.c (Qlocal, report_file_error):
8427 * w32term.c (Vwindow_system, updating_frame):
8428 * w32uniscribe.c (initialized, uniscribe_font_driver):
8429 Remove unneeded extern declarations.
8430
2aa46d6c
CY
84312011-03-14 Chong Yidong <cyd@stupidchicken.com>
8432
c96bbc66 8433 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8434
cffc6f3b
CY
84352011-03-13 Chong Yidong <cyd@stupidchicken.com>
8436
8437 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8438 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8439 These macros can no longer be used for assignment.
8440
44f230aa
SM
8441 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8442 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8443 (record_buffer_markers, fetch_buffer_markers): New functions for
8444 recording and fetching special buffer markers.
8445 (set_buffer_internal_1, set_buffer_temp): Use them.
8446
8447 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8448
8449 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8450
8451 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8452 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8453
8454 * xdisp.c (hscroll_window_tree):
8455 (reconsider_clip_changes): Use PT instead of BUF_PT.
8456
d251f04b
EZ
84572011-03-13 Eli Zaretskii <eliz@gnu.org>
8458
8459 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8460 $(EMACS_ROOT)/lib/intprops.h.
8461
f0c77cd1
PE
84622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8463
3eca4629
PE
8464 Fix more problems found by GCC 4.5.2's static checks.
8465
7c86ee98
PE
8466 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8467 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8468 (xg_free_frame_widgets): Make it clear that a local variable is
8469 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8470 (gdk_window_get_screen): Make it clear that this macro is needed
8471 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8472 (int_gtk_range_get_value): New function, which avoids a diagnostic
8473 from gcc -Wbad-function-cast.
8474 (xg_set_toolkit_scroll_bar_thumb): Use it.
8475 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8476 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8477 (get_utf8_string, xg_get_file_with_chooser):
8478 Rename locals to avoid shadowing.
8479 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8480
41729b81
PE
8481 * xgselect.c (xg_select): Remove unused var.
8482
f0c77cd1
PE
8483 * image.c (four_corners_best): Mark locals as initialized.
8484 (gif_load): Initialize transparent_p to zero (Bug#8238).
8485 Mark another local as initialized.
ec6cf4c6 8486 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8487
ce0ad53d 8488 * image.c (clear_image_cache): Now static.
d5d5a617 8489 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8490 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8491 (x_edge_detection): Remove unnecessary cast that
8492 gcc -Wbad-function-cast diagnoses.
2037898d 8493 (gif_load): Fix pointer signedness.
6ae141d6
PE
8494 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8495 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8496
33383987 84972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8498
d32df629
PE
8499 Improve quality of tests for time stamp overflow.
8500 For example, without this patch (encode-time 0 0 0 1 1
8501 1152921504606846976) returns the obviously-bogus value (-948597
8502 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8503 reports time overflow. See
8504 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8505 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8506 * editfns.c: Include limits.h and intprops.h.
8507 (TIME_T_MIN, TIME_T_MAX): New macros.
8508 (time_overflow): Move earlier, to before first use.
8509 (hi_time, lo_time): New functions, for an accurate test for
8510 out-of-range times.
8511 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8512 (Fget_internal_run_time): Don't assume time_t fits in int.
8513 (make_time): Use list2 instead of Fcons twice.
8514 (Fdecode_time): More accurate test for out-of-range times.
8515 (check_tm_member): New function.
8516 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8517 (lisp_time_argument): Don't rely on undefined left-shift and
8518 right-shift behavior when checking for time stamp overflow.
8be6f318 8519
fe31d94c
PE
8520 * editfns.c (time_overflow): New function, refactoring common code.
8521 (Fformat_time_string, Fdecode_time, Fencode_time):
8522 (Fcurrent_time_string): Use it.
8523
8be6f318
PE
8524 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8525 * dired.c (make_time): Move to ...
8526 * editfns.c (make_time): ... here.
8527 * systime.h: Note the move.
8528
09d9db2c 85292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8530
126bc0dc
YM
8531 * fringe.c (update_window_fringes): Remove unused variables.
8532
c47cbdfd
YM
8533 * unexmacosx.c (copy_data_segment): Also copy __got section.
8534 (Bug#8223)
8535
7ac80be9
EZ
85362011-03-12 Eli Zaretskii <eliz@gnu.org>
8537
c96bbc66 8538 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8539 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8540 Constify `char *' arguments and their references according to
8541 prototypes in tparam.h.
8542
ecb0f94d 8543 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8544
7ac80be9
EZ
8545 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8546 Adapt all references accordingly.
8547
8548 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8549
ef1fd07e
TT
85502011-03-11 Tom Tromey <tromey@redhat.com>
8551
8552 * buffer.c (syms_of_buffer): Remove obsolete comment.
8553
7ef4b50c
EZ
85542011-03-11 Eli Zaretskii <eliz@gnu.org>
8555
8556 * termhooks.h (encode_terminal_code): Declare prototype.
8557
8558 * msdos.c (encode_terminal_code): Don't declare prototype.
8559
8560 * term.c (encode_terminal_code): Now external again, used by
8561 w32console.c and msdos.c.
8562
44f230aa
SM
8563 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8564 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8565
4b1ec863 85662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8567
1714f52b 8568 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8569
4b1ec863
PE
8570 * fringe.c (update_window_fringes): Mark locals as initialized
8571 (Bug#8227).
8572 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8573
524c7aa6
PE
8574 * alloc.c (mark_fringe_data): Move decl from here ...
8575 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8576 to check its interface.
8577 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8578
a5c0af81 8579 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8580 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8581 (fontset_font): Mark local as initialized.
a9a06e0b 8582 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8583
b4716021
PE
8584 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8585
811e9bac 8586 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8587 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8588 (x_own_selection, Fx_disown_selection_internal): Rename locals
8589 to avoid shadowing.
8590 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8591
7e3ab302
PE
8592 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8593 so that the caller can use some name other than gcpro1.
8594 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8595 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8596 (Fx_backspace_delete_keys_p):
8597 Use them to avoid shadowing, and rename vars to avoid shadowing.
8598 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8599 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8600 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8601 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8602 Remove unused locals.
7e3ab302
PE
8603 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8604 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8605 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8606 macros.
f78faa98 8607
e2b13473
PE
8608 * xterm.h (x_mouse_leave): New decl.
8609
77f23912
PE
8610 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8611 Remove unused functions.
cdf4ba58
PE
8612 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8613 (x_calc_absolute_position): Now static.
7411c686 8614 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8615 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8616 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8617 unless they are used.
38d0b34a
PE
8618 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8619 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8620 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8621 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8622 (x_error_catcher, x_connection_closed, x_error_handler):
8623 (x_error_quitter, xembed_send_message, x_iconify_frame):
8624 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8625 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8626 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8627
44f230aa
SM
8628 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8629 Rename or move locals to avoid shadowing.
6b463e58 8630 (tty_defined_color, merge_face_heights): Now static.
5967d051 8631 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8632 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8633 does not deduce is never used uninitialized.
73719eba
PE
8634 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8635 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8636
426994c3 8637 * terminal.c (store_terminal_param): Now static.
5489860b 8638
032f1620 8639 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8640 (set_frame_menubar): Remove unused local.
d4323972 8641 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8642 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8643 since they might point to immutable storage.
281585b0
PE
8644 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8645 since it's unused otherwise.
032f1620 8646
367c19e5 8647 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8648 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8649 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8650 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8651 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8652 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8653 does not deduce are never used uninitialized.
70739cbe 8654
07b48fa9
PE
8655 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8656
8868a238 8657 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8658 * window.c (window_loop, size_window):
8659 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8660
7e5cf297 8661 * window.c (display_buffer): Now static.
d6550a9f
PE
8662 (size_window): Mark variables that gcc -Wuninitialized
8663 does not deduce are never used uninitialized.
a586633d
PE
8664 * window.h (check_all_windows): New decl, to forestall
8665 gcc -Wmissing-prototypes diagnostic.
5b555da1 8666 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8667
f6095868
PE
8668 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8669 shadowing.
8670 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8671 Include <limits.h>.
8672 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8673 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8674 (load_charset_map): Mark variables that gcc -Wuninitialized
8675 does not deduce are never used uninitialized.
53df7c11 8676 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8677
f38b440c
PE
8678 * coding.c (coding_set_source, coding_set_destination):
8679 Use "else { /* comment */ }" rather than "else /* comment */;"
8680 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8681 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8682 a block, when the outer 'i' will do.
8683 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8684 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8685 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8686 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8687 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8688 Rename locals to avoid shadowing.
8689 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8690 * coding.c (emacs_mule_char, encode_invocation_designation):
8691 Now static, since they're not used elsewhere.
413bb2db 8692 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8693 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8694 (decode_coding_emacs_mule): Mark variables that gcc
8695 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8696 (detect_coding_iso_2022): Initialize a local variable that might
8697 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8698 this initialization is needed. (Bug#8211)
5f58e762
PE
8699 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8700 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8701 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8702 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8703 Remove unused macros.
f38b440c 8704
232b38b9 8705 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8706 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8707 * character.c (string_count_byte8): Likewise.
232b38b9 8708
fb90da1b
PE
8709 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8710 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8711
fb93dbc2
PE
8712 * chartab.c (copy_sub_char_table): Now static, since it's not used
8713 elsewhere.
5c156ace
PE
8714 (sub_char_table_ref_and_range, char_table_ref_and_range):
8715 Rename locals to avoid shadowing.
bbcd0949 8716 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8717
7d3b3862 8718 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8719 (BIDI_BOB): Remove unused macro.
7d3b3862 8720
6be7d3da
PE
8721 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8722 deduce are never used uninitialized.
c2ed9c8b 8723 * term.c (encode_terminal_code): Likewise.
6be7d3da 8724
75f8807f 8725 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8726
50938595
PE
8727 * tparam.h: New file.
8728 * term.c, tparam.h: Include it.
8729 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8730 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8731 Move these decls to tparam.h, and make them agree with what
8732 is actually in tparam.c. The previous trick of using incompatible
8733 decls in different modules does not conform to the C standard.
8734 All callers of tparam changed to use tparam's actual API.
8735 * tparam.c (tparam1, tparam, tgoto):
8736 Use const pointers where appropriate.
8737
fbceeba2
PE
8738 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8739 * cm.h (struct cm): Likewise.
8740 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8741 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8742 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8743 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8744 (turn_on_face, init_tty): Likewise.
8745 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8746
7f3f1250
PE
8747 * term.c (term_mouse_position): Rename local to avoid shadowing.
8748
e6ca6543
PE
8749 * alloc.c (mark_ttys): Move decl from here ...
8750 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8751
c40f8d15
AS
87522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8753
8754 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8755
cfe0661d
JB
87562011-03-09 Juanma Barranquero <lekktu@gmail.com>
8757
8758 * search.c (compile_pattern_1): Remove argument regp, unused since
8759 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8760 (compile_pattern): Don't pass it.
8761
0afb4571
J
87622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8763
8764 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8765 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8766 for ! HAVE_GTK3.
8767 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8768
8769 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8770
8771 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8772 gdk_window_get_screen, gdk_window_get_geometry,
8773 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8774 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8775 (xg_get_pixbuf_from_pixmap): New function.
8776 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8777 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8778 Call xg_get_pixbuf_from_pixmap instead of
8779 gdk_pixbuf_get_from_drawable.
8780 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8781 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8782 (xg_check_special_colors): Use GtkStyleContext and its functions
8783 for HAVE_GTK3.
8784 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8785 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8786 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8787 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8788 Call gtk_widget_get_preferred_size.
0afb4571
J
8789 (xg_frame_resized): gdk_window_get_geometry only takes 5
8790 parameters.
44f230aa
SM
8791 (xg_win_to_widget, xg_event_is_for_menubar):
8792 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8793 (xg_set_widget_bg): New function.
8794 (delete_cb): New function.
895009e1 8795 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8796 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8797 (xg_set_background_color): Call xg_set_widget_bg.
8798 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8799 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8800 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8801 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8802 if ! HAVE_GTK3.
8803 (update_frame_tool_bar): Call gtk_widget_hide.
8804 (xg_initialize): Use GDK_KEY_g.
8805
8806 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8807 if ! HAVE_GTK3
8808 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8809
8810 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8811 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8812 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8813
1c2cc4ef
JB
88142011-03-08 Juanma Barranquero <lekktu@gmail.com>
8815
8816 * w32xfns.c (select_palette): Check success of RealizePalette against
8817 GDI_ERROR, not zero.
8818
33383987 8819See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8820
8821;; Local Variables:
8822;; coding: utf-8
aac0c6e3
MR
8823;; End:
8824
33383987 8825 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8826
8827 This file is part of GNU Emacs.
8828
8829 GNU Emacs is free software: you can redistribute it and/or modify
8830 it under the terms of the GNU General Public License as published by
8831 the Free Software Foundation, either version 3 of the License, or
8832 (at your option) any later version.
8833
8834 GNU Emacs is distributed in the hope that it will be useful,
8835 but WITHOUT ANY WARRANTY; without even the implied warranty of
8836 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8837 GNU General Public License for more details.
8838
8839 You should have received a copy of the GNU General Public License
8840 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.