* src/xgselect.c (xg_select): Fix first argument in call to 'select' (bug#11508).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ff23cd9f
KB
12012-05-21 Ken Brown <kbrown@cornell.edu>
2
3 * xgselect.c (xg_select): Fix first argument in call to 'select'
4 (bug#11508).
5
1b170bc6
KB
62012-05-20 Ken Brown <kbrown@cornell.edu>
7
8 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
9 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
10
b2f4d39f
KB
112012-05-19 Ken Brown <kbrown@cornell.edu>
12
13 * xfns.c (x_in_use): Remove `static' qualifier.
14 * xterm.h (x_in_use): Declare.
15 * xgselect.c: Include xterm.h.
16 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
17 and `display_arg' (bug#9754).
18
003fdae2
PE
192012-05-19 Paul Eggert <eggert@cs.ucla.edu>
20
9232a6d9
PE
21 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
22
003fdae2
PE
23 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
24 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
25
784b56e2
EZ
262012-05-18 Eli Zaretskii <eliz@gnu.org>
27
28 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
29
30 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
31 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
32
33 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
34 reference to image_cache->refcount.
35 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
36
a0a79cde
JL
372012-05-17 Juri Linkov <juri@jurta.org>
38
39 * search.c (Fword_search_regexp, Fword_search_backward)
40 (Fword_search_forward, Fword_search_backward_lax)
41 (Fword_search_forward_lax): Move functions to isearch.el
42 (bug#10145, bug#11381).
43
b0572523
PE
442012-05-16 Paul Eggert <eggert@cs.ucla.edu>
45
46 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
47
9660f5fc
SM
482012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
49
50 * lread.c (init_obarray): Declare Qt and Qnil as special.
51
4374de83
GM
522012-05-14 Glenn Morris <rgm@gnu.org>
53
54 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 55 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 56
dc44c39a
PE
572012-05-14 Paul Eggert <eggert@cs.ucla.edu>
58
078c97cb
PE
59 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
60
dc44c39a
PE
61 * unexaix.c: Port to more-recent AIX compilers.
62 (report_error, report_error_1, make_hdr, copy_sym)
63 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
64 Make arguments const char *, not char *, to avoid violations of C
65 standard and to fix some AIX warnings reported by Gilles Pion.
66
e18afed7 672012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
68
69 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
70 already have overlays loaded.
71 (handle_single_display_spec): Before returning without displaying
72 fringe bitmap, synchronize the bidi iterator with the main display
73 iterator, by calling iterate_out_of_display_property.
74 (iterate_out_of_display_property): Detect buffer iteration by
75 testing that it->string is a Lisp string.
76 (get_next_display_element): When the current object is exhausted,
77 and there's something on it->stack, call set_iterator_to_next to
78 proceed with what's on the stack, instead of returning zero.
79 (set_iterator_to_next): If called at the end of a Lisp string,
80 proceed to consider_string_end without incrementing string
81 position. Don't increment display vector index past the end of
82 the display vector. (Bug#11417)
c8fb9dc6
EZ
83 (pos_visible_p): Don't report a position visible when move_it_to
84 stopped at the last line of window, which happens to be scanned
85 backwards by the bidi iteration. (Bug#11464)
ac268e67 86
e18afed7 872012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
88
89 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
90 and right-margin display specs even if the spec is invalid or we
91 are on a TTY, and thus unable to display on the fringes. That's
92 because the text with the property will not be displayed anyway,
93 so we need to signal to the caller that this is a "replacing"
94 display spec. This fixes display when the spec is invalid or we
95 are on a TTY.
96
e18afed7 972012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
98
99 * unexaix.c (make_hdr): Fix typo in prototype.
100 This bug broke the build on AIX. Problem reported by Gilles Pion.
101
9d0a235a
MA
1022012-05-14 Michael Albinus <michael.albinus@gmx.de>
103
104 * keyboard.c (kbd_buffer_get_event): Read special events also in
105 batch mode. (Bug#11415)
106
9e6b06ed
GM
1072012-05-12 Glenn Morris <rgm@gnu.org>
108
109 * ns.mk: Update for ns_appbindir no longer having trailing "/".
110
c1a1d7a3
EZ
1112012-05-12 Eli Zaretskii <eliz@gnu.org>
112
113 * lisp.mk (lisp): Add newcomment.elc.
114
3fe7cdc8
GM
1152012-05-12 Glenn Morris <rgm@gnu.org>
116
117 * Makefile.in (MKDIR_P): New, set by configure.
118 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
119
53f7d2c0
PE
1202012-05-11 Paul Eggert <eggert@cs.ucla.edu>
121
122 Remove unused function hourglass_started.
123 * dispextern.h (hourglass_started):
124 * w32fns.c (hourglass_started):
125 * xdisp.c (hourglass_started): Remove.
126
75aafb17
JB
1272012-05-10 Juanma Barranquero <lekktu@gmail.com>
128
129 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
130 Update dependencies.
131
12959e8e
PE
1322012-05-10 Paul Eggert <eggert@cs.ucla.edu>
133
97107e2e
PE
134 * xgselect.c (xg_select): Put maxfds+1 into a var.
135 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
136
12959e8e
PE
137 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
138
836d29b3
DA
1392012-05-10 Dave Abrahams <dave@boostpro.com>
140
141 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
142 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
143
5cb67954
MA
1442012-05-09 Michael Albinus <michael.albinus@gmx.de>
145
146 * dbusbind.c (xd_registered_buses): New internal Lisp object.
147 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
148 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
149 Initialize xd_registered_buses.
150
3478ec45
PE
1512012-05-09 Paul Eggert <eggert@cs.ucla.edu>
152
b263a6b0
PE
153 Untag more efficiently if USE_LSB_TAG.
154 This is based on a proposal by YAMAMOTO Mitsuharu in
155 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
156 For an admittedly artificial (nth 8000 longlist) benchmark on
157 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
158 Emacs's overall text size by 1%.
159 * lisp.h (XUNTAG): New macro.
160 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
161 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
162 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
163 * eval.c (Fautoload):
164 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
165 * frame.h (XFRAME): Use XUNTAG.
166
3478ec45
PE
167 Port recent dbusbind.c changes to 32-bit --with-wide-int.
168 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
169 Remove unportable assumptions about print widths of types like
170 dbus_uint32_t.
171 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
172 intptr_t when converting between pointer and integer, to avoid GCC
173 warnings about wrong width.
174
666b903b 1752012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
176
177 * w32proc.c (new_child): Force Windows to reserve only 64KB of
178 stack for each reader_thread, instead of defaulting to 8MB
179 determined by the linker. This avoids failures in creating
180 subprocesses on Windows 7, see the discussion in this thread:
181 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
182
b120cc17
JC
1832012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
184
185 Fix up display of the *Minibuf-0* buffer in the mini window.
186 * keyboard.c (read_char): Don't clear the echo area if there's no
187 message to clear.
188 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 189 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 190
9a4b36f8
MA
1912012-05-07 Michael Albinus <michael.albinus@gmx.de>
192
193 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
194 batch mode.
195
e5f9458f
CY
1962012-05-06 Chong Yidong <cyd@gnu.org>
197
198 * lisp.mk (lisp): Update.
199
eceeb5fc 2002012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
201
202 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
203
71873e2b
SM
2042012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
205
206 * data.c (PUT_ERROR): New macro.
207 (syms_of_data): Use it. Add new error type `user-error'.
208 * undo.c (user_error): New function.
209 (Fprimitive_undo): Use it.
210 * print.c (print_error_message): Adjust print style for `user-error'.
211 * keyboard.c (user_error): New function.
212 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
213
ab0fa4e4
PE
2142012-05-03 Paul Eggert <eggert@cs.ucla.edu>
215
216 Do not limit current-time-string to years 1000..9999.
217 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
218 (Fcurrent_time_string): Support any year that is supported by the
219 underlying localtime representation. Don't use asctime, as it
220 has undefined behavior for years outside the range -999..9999.
221
7ed806a7
PE
2222012-05-02 Paul Eggert <eggert@cs.ucla.edu>
223
224 Fix race conditions involving setenv, gmtime, localtime, asctime.
225 Without this fix, interrupts could mess up code that uses these
226 nonreentrant functions, since setting TZ invalidates existing
227 tm_zone or tzname values, and since most of these functions return
228 pointers to static storage.
229 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
230 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
231 Grow the critical sections to include not just invoking
232 localtime/gmtime, but also accessing these functions' results
233 including their tm_zone values if any, and any related TZ setting.
234 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
235 so that the struct tm is saved in the critical section.
236 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
237 motivated by the fact that memory allocation needs to be outside
238 the critical section.
239
0c16dfed
DA
2402012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
241
242 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
243 with RESET_INTERVAL.
244
245 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
246 Remove duplicated buffer name initialization.
247
3f83ace8
JM
2482012-05-02 Jim Meyering <jim@meyering.net>
249
250 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
251
c7b8541e
JM
252 * xfns.c (x_window): Use xstrdup (Bug#11375).
253
90207a15 2542012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
255
256 * xdisp.c (pos_visible_p): If already at a newline from the
257 display string before the 'while' loop, don't walk back the glyphs
258 from it3.glyph_row. Solves assertion violation when the display
259 string begins with a newline (egg.el). (Bug#11367)
260
b593d6a9
AH
2612012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
262
263 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
264 Move to simple.el.
265
4737362e
GM
2662012-05-01 Glenn Morris <rgm@gnu.org>
267
99cf43f9
GM
268 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
269 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
270 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
271 All were removed before 23.1.
272
9311dcff
GM
273 * dispnew.c: Remove HAVE_LIBNCURSES test;
274 it is always true on relevant platforms.
275
4d5c6349
GM
276 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
277 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
278
4737362e
GM
279 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
280
74dd3a6b
AS
2812012-04-30 Andreas Schwab <schwab@linux-m68k.org>
282
283 * .gdbinit (xpr): Remove checks for no longer existing misc types.
284 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
285 Remove.
286
13c379ee
PE
2872012-04-28 Paul Eggert <eggert@cs.ucla.edu>
288
289 Do not avoid creating empty evaporating overlays (Bug#9642).
290 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
291 That is, do not delete an evaporating overlay if it becomes
292 empty after its bounds are adjusted to fit within its buffer.
293 This fix caused other problems, and I'm reverting it until we get
294 to the bottom of them.
295
a8e7d6d7 2962012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
297
298 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
299
a8e7d6d7 3002012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
301
302 * xdisp.c (pos_visible_p): If the window start position is beyond
303 ZV, start the display from buffer beginning. Prevents assertion
304 violation in init_iterator when the minibuffer window is scrolled
305 via the scroll bar.
306
307 * window.c (window_scroll_pixel_based): Likewise.
308
a8e7d6d7 3092012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
310
311 * keymap.c (where_is_internal): Doc fix (Bug#10872).
312
a8e7d6d7 3132012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
314
315 * fileio.c (Fcopy_file, Fset_file_selinux_context):
316 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
317
a8e7d6d7 3182012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 319
b593d6a9
AH
320 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
321 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 322
1c6900d9
EZ
3232012-04-26 Eli Zaretskii <eliz@gnu.org>
324
4c3fa1d9
EZ
325 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
326 display element, check also the underlying string or buffer
327 character. (Bug#11341)
328
1c6900d9
EZ
329 * w32menu.c: Include w32heap.h.
330 (add_menu_item): If the call to AppendMenuW (via
331 unicode_append_menu) fails, disable Unicode menus only if we are
332 running on Windows 9X/Me.
333
42bf8205
AS
3342012-04-24 Andreas Schwab <schwab@linux-m68k.org>
335
336 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
337 (xgetint): Add missing shift for LSB tags.
338
b1bac16e
MR
3392012-04-24 Martin Rudalics <rudalics@gmx.at>
340
341 * keyboard.c (read_char): Don't wipe echo area for select window
342 events: These might get delayed via `mouse-autoselect-window'
343 (Bug#11304).
344
d69621cc
JB
3452012-04-24 Juanma Barranquero <lekktu@gmail.com>
346
347 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
348 manipulation of :loaded-from data.
349
02fd101b
JB
3502012-04-23 Juanma Barranquero <lekktu@gmail.com>
351
352 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
353 now a cons (bug#11311).
354
888bec30
PE
3552012-04-23 Paul Eggert <eggert@cs.ucla.edu>
356
89a438bd
PE
357 Do not create empty overlays with the evaporate property (Bug#9642).
358 * buffer.c (Fmove_overlay): Delete an evaporating overlay
359 if it becomes empty after its bounds are adjusted to fit within
360 its buffer. Without this fix, in a nonempty buffer (let ((o
361 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
362 yields an empty overlay that has the evaporate property, which is
363 not supposed to happen.
364
1068fe4d
PE
365 Fix minor GTK3 problems found by static checking.
366 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
367 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
368 (struct _EmacsFixedClass, emacs_fixed_get_type):
369 Move decls here from emacsgtkfixed.h, since they needn't be public.
370 (emacs_fixed_get_type): Now static.
371 (emacs_fixed_class_init): Omit unused local.
372 (emacs_fixed_child_type): Remove; unused.
373 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
374 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
375 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
376 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
377 (EMACS_FIXED_GET_CLASS): Remove; unused.
378 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
379
888bec30
PE
380 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
381 Problem reported by Juanma Barranquero for Windows -Wunused-function.
382
de85e130
PE
3832012-04-22 Paul Eggert <eggert@cs.ucla.edu>
384
d0baac98
PE
385 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
386 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
387 (__malloc_size_t, __malloc_ptrdiff_t):
388 Remove. All uses removed, replaced by the definiens if needed,
389 since we can assume C89 or better now.
390 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
391 (protect_malloc_state, align, get_contiguous_space)
392 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
393 (malloc_atfork_handler_child, malloc_enable_thread)
394 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
395 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
396 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
397 (special_realloc, _realloc_internal_nolock, _realloc_internal)
398 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
399 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
400 Define using prototypes, not old style.
401 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
402 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
403 (align): Don't assume that signed integer overflow wraps around.
404 Omit unused local var.
405 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
406 (_free_internal_nolock, memalign, mallochook, reallochook):
407 Omit no-longer-needed casts.
408 (valloc): Use getpagesize, not __getpagesize.
409 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
410 (struct hdr): The 'magic' member is now size_t, not unsigned long.
411
de85e130
PE
412 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
413
dcbf5805
MA
4142012-04-22 Michael Albinus <michael.albinus@gmx.de>
415
416 Move functions from C to Lisp. Make non-blocking method calls
417 the default. Implement further D-Bus standard interfaces.
418
419 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
420 (QCdbus_request_name_allow_replacement)
421 (QCdbus_request_name_replace_existing)
422 (QCdbus_request_name_do_not_queue)
423 (QCdbus_request_name_reply_primary_owner)
424 (QCdbus_request_name_reply_in_queue)
425 (QCdbus_request_name_reply_exists)
426 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
427 (QCdbus_registered_serial, QCdbus_registered_method)
428 (QCdbus_registered_signal): New Lisp objects.
429 (XD_DEBUG_MESSAGE): Use sizeof.
430 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
431 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
432 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
433 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
434 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
435 (xd_signature, xd_append_arg): Allow float for integer types.
436 (xd_get_connection_references): New function.
b593d6a9
AH
437 (xd_get_connection_address): Rename from xd_initialize.
438 Return cached address.
dcbf5805
MA
439 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
440 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
441 level.
442 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 443 Return number of refcounts.
dcbf5805
MA
444 (Fdbus_get_unique_name): Make stronger parameter check.
445 (Fdbus_message_internal): New defun.
446 (Fdbus_call_method, Fdbus_call_method_asynchronously)
447 (Fdbus_method_return_internal, Fdbus_method_error_internal)
448 (Fdbus_send_signal, Fdbus_register_service)
449 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
450 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
451 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
452 (Vdbus_compiled_version, Vdbus_runtime_version)
453 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
454 (Vdbus_message_type_method_return, Vdbus_message_type_error)
455 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
456 (Vdbus_registered_buses, Vdbus_registered_objects_table):
457 Adapt docstring.
dcbf5805 458
52828e02
PE
4592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
460
da05bc4c
PE
461 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
462 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
463 Do not assume ptrdiff_t is the same width as 'int'.
464
52828e02
PE
465 * alloc.c: Handle unusual debugging option combinations.
466 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
467 since the two debugging options are incompatible.
468 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
469 is defined.
470 (mem_init, mem_insert, mem_insert_fixup):
471 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
472 (NEED_MEM_INSERT): Remove; no longer needed.
473
f01769f9
LL
4742012-04-22 Leo Liu <sdl.web@gmail.com>
475
476 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
477
5790543d
PE
4782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
479
480 * sysdep.c [__FreeBSD__]: Minor cleanups.
481 (list_system_processes, system_process_attributes) [__FreeBSD__]:
482 Use Emacs indenting style more consistently. Avoid some casts.
483 Use 'double' consistently rather than mixing 'float' and 'double'.
484
b91b7e4d
EW
4852012-04-21 Eduard Wiebe <usenet@pusto.de>
486
b593d6a9
AH
487 * sysdep.c (list_system_processes, system_process_attributes):
488 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 489
6114eb15
AS
4902012-04-21 Andreas Schwab <schwab@linux-m68k.org>
491
492 * lisp.mk (lisp): Update.
493
2f38dff7
PE
4942012-04-20 Paul Eggert <eggert@cs.ucla.edu>
495
496 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
497 It is never used otherwise.
498
4ae29f89
SM
4992012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
500
501 * print.c (print_preprocess): Only check print_depth if print-circle
502 is nil.
503 (print_object): Check for cycles even when print-circle is nil and
504 print-gensym is t, but only check print_depth if print-circle is nil.
505
f30d612a
CY
5062012-04-20 Chong Yidong <cyd@gnu.org>
507
508 * process.c (wait_reading_process_output): If EIO occurs on a pty,
509 set the status to "failed" and ensure that sentinel is run.
510
c07a4c0b 5112012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
512
513 * process.c (Fset_process_inherit_coding_system_flag)
514 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 515 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 516
c07a4c0b 5172012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
518
519 * xdisp.c (string_buffer_position_lim): Limit starting position to
520 BEGV.
521 (set_cursor_from_row): If called for a mode-line or header-line
522 row, return zero immediately.
523 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
524 farther than the first row after the header line, if any.
525 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
526 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
527
c07a4c0b 5282012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 529
4ae29f89
SM
530 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
531 (bug#11238).
ad3a2b41 532
c07a4c0b 5332012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 5342012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
535
536 configure: new option --enable-gcc-warnings (Bug#11207)
537 * Makefile.in (C_WARNINGS_SWITCH): Remove.
538 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
539 (ALL_CFLAGS): Use new macros rather than old.
540 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
541 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
542 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
543 -Wunused-result, -Wunused-variable. This should go away once
544 the Emacs and Gnulib regex code is merged.
545 (xmalloc, xrealloc): Now static.
546
aba027e8
PE
5472012-04-17 Paul Eggert <eggert@cs.ucla.edu>
548
549 * dired.c (Fsystem_groups): Remove unused local.
550
e5a36063
GM
5512012-04-17 Glenn Morris <rgm@gnu.org>
552
553 * dired.c (Fsystem_users): Doc fix.
554
316411f0
DA
5552012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
556
557 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
558 (syms_of_dired): Add them.
559
9426aba4
PE
5602012-04-16 Paul Eggert <eggert@cs.ucla.edu>
561
b62a57be
PE
562 Fix minor alloc.c problems found by static checking.
563 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
564 New extern decls, to avoid calling undeclared functions.
565 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
566 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
567 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
568 (NEED_MEM_INSERT): New macro.
569 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 570 Remove one incorrect comment and fix another.
b62a57be 571
3539f31f
PE
572 Fix minor ralloc.c problems found by static checking.
573 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
574 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
575 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
576 (r_alloc_sbrk): Now static.
577
a041960a
PE
578 Improve ralloc.c interface checking.
579 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
580 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
581 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
582 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
583 [REL_ALLOC]: ... to here, to check interface.
584 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
585 Remove decls. This fixes an "It stinks!".
586
9426aba4
PE
587 * alloc.c (which_symbols): Fix alignment issue / type clash.
588
d55c12ed
AS
5892012-04-15 Andreas Schwab <schwab@linux-m68k.org>
590
591 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
592 (struct Lisp_Misc_Any): Likewise.
593 (struct Lisp_Free): Likewise.
594 * alloc.c (union aligned_Lisp_Symbol): Define.
595 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
596 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
597 (union aligned_Lisp_Misc): Define.
598 (MARKER_BLOCK_SIZE, struct marker_block): Use union
599 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 600 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 601
b948ce8b
PE
6022012-04-14 Paul Eggert <eggert@cs.ucla.edu>
603
604 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
605 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
606 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
607 * s/netbsd.h, s/sol2-6.h:
608 Remove definition of GC_MARK_STACK, since the default now works.
609 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
610 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
611 no longer the default.
612 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
613
35dc09a1 6142012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 615
35dc09a1
GM
616 * lread.c (lisp_file_lexically_bound_p):
617 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 618
35dc09a1
GM
6192012-04-14 Eli Zaretskii <eliz@gnu.org>
620
621 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
622 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
623
6242012-04-14 Jan Djärv <jan.h.d@swipnet.se>
625
626 * nsterm.m (constrainFrameRect): Always constrain when there is only
627 one screen (Bug#10962).
628
bcd86815
KB
6292012-04-13 Ken Brown <kbrown@cornell.edu>
630
631 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
632
c25df26e
RT
6332012-04-13 Reuben Thomas <rrt@sc3d.org>
634
635 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
636
0fc59f1e
DC
6372012-04-11 Daniel Colascione <dancol@dancol.org>
638
639 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
640 against is gone. It's better to use vfork now so that when Cygwin
641 gains a new, working vfork, we use it automatically (bug#10398).
642
de8c03dc
SM
6432012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
644
645 * window.c (save_window_save): Obey window-point-insertion-type.
646
2f097256
GM
6472012-04-11 Glenn Morris <rgm@gnu.org>
648
649 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
650
453b951e
SM
6512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
652
653 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
654
75f1671a 6552012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
656
657 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
658 (force_quit_count): New var.
659 (handle_interrupt): Use it.
660
2a8ce227
JB
6612012-04-10 Juanma Barranquero <lekktu@gmail.com>
662
663 * w32.c (w32_delayed_load): Record the full path of the library
664 being loaded (bug#10424).
665
935396c0
GM
6662012-04-09 Glenn Morris <rgm@gnu.org>
667
05920a43
GM
668 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
669 not just in the obarray, before snarfing them. (Bug#11036)
670
935396c0
GM
671 * Makefile.in ($(leimdir)/leim-list.el):
672 Pass EMACS rather than BUILT_EMACS.
673
a18ecafa
TZ
6742012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
675
676 * process.c (make_process):
677 * process.h: Add integer `gnutls_handshakes_tried' member to
678 process struct.
679
6bbef4e5
JC
680 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
681 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
682
683 * gnutls.c (gnutls_log_function2i): Convenience log function.
684 (emacs_gnutls_read): Use new log functions,
685 `gnutls_handshakes_tried' process member, and
686 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
687 attempts per process (connection).
688
b4d3bc10
CY
6892012-04-09 Chong Yidong <cyd@gnu.org>
690
691 * eval.c (Fuser_variable_p, user_variable_p_eh)
692 (lisp_indirect_variable): Functions deleted.
693 (Fdefvar): Caller changed.
694
695 * callint.c (Finteractive, Fcall_interactively):
696 * minibuf.c (Fread_variable): Callers changed.
697
70f4d973
EZ
6982012-04-09 Eli Zaretskii <eliz@gnu.org>
699
700 * xdisp.c (set_cursor_from_row): If the display string appears in
701 the buffer at position that is closer to point than the position
702 after the display string, display the cursor on the first glyph of
703 the display string. Fixes cursor display when a 'display' text
704 property immediately follows invisible text. (Bug#11094)
705
cb3c2e3e
PE
7062012-04-09 Paul Eggert <eggert@cs.ucla.edu>
707
708 composite.c: use 'double' consistently
709 * composite.c (get_composition_id): Use 'double' consistently
710 instead of converting 'float' to 'double' and vice versa; this is
711 easier to understand and avoids a GCC warning.
712
fd06db5d
GM
7132012-04-09 Glenn Morris <rgm@gnu.org>
714
50fe702a
GM
715 * Makefile.in: Generate leim-list with bootstrap-emacs, in
716 preparation for dumping it with emacs. (Bug#4789)
717 (leimdir): New variable.
718 ($(leimdir)/leim-list.el): New rule.
719 (emacs$(EXEEXT)): Depend on leim-list.el.
720
fd06db5d
GM
721 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
722 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
723 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
724
55c131ee
AS
7252012-04-08 Andreas Schwab <schwab@linux-m68k.org>
726
727 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
728 proper alignment.
729
9209588f
JB
7302012-04-07 Juanma Barranquero <lekktu@gmail.com>
731
732 * xml.c (init_libxml2_functions) [WINDOWSNT]:
733 Remove unused local variable.
734
e3fb2efb
PE
7352012-04-07 Paul Eggert <eggert@cs.ucla.edu>
736
737 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
738 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
739 (mark_memory): Mark Lisp_Objects only if pointers might hide in
740 objects, as mark_maybe_pointer will catch them otherwise.
741 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
742 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
743
b5385551
PE
7442012-04-07 Paul Eggert <eggert@cs.ucla.edu>
745
746 Fix typo that broke non-Windows builds.
747 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
748
9078ead6
EZ
7492012-04-07 Eli Zaretskii <eliz@gnu.org>
750
751 Support building on MS-Windows with libxml2.
752
753 * makefile.w32-in (OBJ2): Add xml.$(O).
754 (GLOBAL_SOURCES): Add xml.c.
755 ($(BLD)/xml.$(O)): New dependency list.
756
757 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
758 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
759 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
760 [!WINDOWSNT]: New macros.
761 (init_libxml2_functions, libxml2_loaded_p): New functions.
762 (parse_region): Call fn_xmlCheckVersion instead of using the macro
763 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
764 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
765 Calls xmlCleanupParser only if libxml2 was loaded (or statically
766 linked in).
6bbef4e5
JC
767 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
768 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
769 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
770
771 * emacs.c: Don't include libxml/parser.h.
772 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
773 xmlCleanupParser directly.
774
775 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
776
3811fdf3
EZ
7772012-04-07 Eli Zaretskii <eliz@gnu.org>
778
779 * indent.c (Fvertical_motion): If there is a display string at
780 point, use it.vpos to compute how many lines to backtrack after
781 move_it_to point. (Bug#11133)
782
2f8e16b2
EZ
7832012-04-06 Eli Zaretskii <eliz@gnu.org>
784
785 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
786 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
787 about subtle differences between FETCH_CHAR* and STRING_CHAR*
788 macros related to unification of CJK characters. For the details,
789 see the discussion following the message here:
790 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
791
3d439cd1
CY
7922012-04-04 Chong Yidong <cyd@gnu.org>
793
794 * keyboard.c (Vdelayed_warnings_list): Doc fix.
795
8bc53d00
EZ
7962012-04-01 Eli Zaretskii <eliz@gnu.org>
797
798 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
799 instead of alloca. (Bug#11138)
800
3b0512a3
AS
8012012-04-01 Andreas Schwab <schwab@linux-m68k.org>
802
803 * w32menu.c (is_simple_dialog): Properly check lisp types.
804 (Bug#11141)
805
8427ddd2
EZ
8062012-03-31 Eli Zaretskii <eliz@gnu.org>
807
979022ef
EZ
808 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
809 position we get to after a call to move_it_to fails the
810 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
811 only if we wind up in a string from display property. (Bug#11063)
812
a6b1c7cc
EZ
813 * window.c (Fdelete_other_windows_internal): Invalidate the row
814 and column information about mouse highlight, so that redisplay
815 restores it after reallocating the glyph matrices. (Bug#7464)
816
8427ddd2
EZ
817 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
818 string comes from a `display' text property, use the buffer
819 position of that property as if we actually saw that position in
820 the row's glyphs.
697ba24b
EZ
821 (move_it_by_lines): Remove the assertion that
822 "it->current_x == 0 && it->hpos == 0" which can be legitimately
823 violated when there's a before-string at the beginning of a line.
824 (Bug#11063)
8427ddd2 825
65a0a738
EZ
8262012-03-30 Eli Zaretskii <eliz@gnu.org>
827
828 * xdisp.c (append_space_for_newline): If the default face was
829 remapped, use the remapped face for the appended newline.
830 (extend_face_to_end_of_line): Use the remapped default face for
831 extending the face to the end of the line.
832 (display_line): Call extend_face_to_end_of_line when the default
833 face was remapped. (Bug#11068)
834
581355cc
EZ
8352012-03-29 Eli Zaretskii <eliz@gnu.org>
836
837 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
838
e8fc049f
SM
8392012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
840
841 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
842
4fb9a543
GM
8432012-03-27 Glenn Morris <rgm@gnu.org>
844
845 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
846 Doc fixes.
847
679910f1
KH
8482012-03-26 Kenichi Handa <handa@m17n.org>
849
850 * dispextern.h (struct glyph): Fix previous change. Change the
851 bit length of glyphless.ch to 25 (Bug#11082).
852
90d49b7f
CY
8532012-03-26 Chong Yidong <cyd@gnu.org>
854
855 * keyboard.c (Vselection_inhibit_update_commands): New variable.
856 (command_loop_1): Use it; inhibit selection update for
857 handle-select-window too (Bug#8996).
858
f514f6f0
FP
8592012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
860
e8fc049f 861 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 862
bf43fa51
KH
8632012-03-25 Kenichi Handa <handa@m17n.org>
864
865 * dispextern.h (struct glyph): Change the bit length of
866 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
867
8a0c01dd
EZ
8682012-03-24 Eli Zaretskii <eliz@gnu.org>
869
870 * s/ms-w32.h (tzname): Include time.h before redirecting to
871 _tzname. Fixes the MSVC build. (Bug#9960)
872
7d1c3a76
AS
8732012-03-24 Andreas Schwab <schwab@linux-m68k.org>
874
8ed79523
AS
875 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
876 characters.
877
7d1c3a76
AS
878 * xterm.c (XTread_socket): Only modify handling_signal if
879 !SYNC_INPUT. (Bug#11080)
880
e99a9b8b
EZ
8812012-03-23 Eli Zaretskii <eliz@gnu.org>
882
883 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
884 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
885 when fetching a multibyte character consumes more bytes than
886 CHAR_BYTES returns, due to unification of CJK characters in
887 string_char. (Bug#11073)
888
5063c0e1
TN
8892012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
890
891 * process.c (wait_reading_process_output): Handle pty disconnect
892 by refraining from sending oneself a SIGCHLD (bug#10933).
893
9f851fbd
CY
8942012-03-22 Chong Yidong <cyd@gnu.org>
895
896 * dispextern.h (struct it): New member string_from_prefix_prop_p.
897
5063c0e1 898 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
899 Mark string as coming from a prefix property.
900 (handle_face_prop): Use default face for prefix strings (Bug#4281).
901 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
902
fb5b8aca
CY
9032012-03-21 Chong Yidong <cyd@gnu.org>
904
905 * xfaces.c (Vface_remapping_alist): Doc fix.
906
62356a1b
EZ
9072012-03-20 Eli Zaretskii <eliz@gnu.org>
908
909 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
910 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
911 Doc fixes.
62356a1b 912
025de85b
CY
9132012-03-20 Chong Yidong <cyd@gnu.org>
914
915 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
916 to reflect default non-nil value of redisplay-dont-pause.
917
4827f94e
KH
9182012-03-19 Kenichi Handa <handa@m17n.org>
919
920 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
921 it fit in a valid range (Bug#11003).
922
e50a24a2
EZ
9232012-03-18 Eli Zaretskii <eliz@gnu.org>
924
925 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
926 that is not from display property, accept the row as a "cursor
927 row" if one of the string's character has a non-nil `cursor'
928 property. Fixes cursor positioning when there are newlines in
929 overlay strings, e.g. in icomplete.el. (Bug#11035)
930
9af5ed87
PE
9312012-03-12 Paul Eggert <eggert@cs.ucla.edu>
932
933 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
934
d1f55f16
CY
9352012-03-12 Chong Yidong <cyd@gnu.org>
936
937 * eval.c (inhibit_lisp_code): Rename from
938 inhibit_window_configuration_change_hook; move from window.c.
939
940 * xfns.c (unwind_create_frame_1, Fx_create_frame):
941 * window.c (run_window_configuration_change_hook)
942 (syms_of_window): Callers changed.
943
66c5eebd
CY
9442012-03-11 Chong Yidong <cyd@gnu.org>
945
413df973
CY
946 * keymap.c (Fkey_description): Doc fix (Bug#9700).
947
66c5eebd
CY
948 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
949
1de11f56
CY
9502012-03-10 Chong Yidong <cyd@gnu.org>
951
952 * frame.c (other_visible_frames): Don't assume the selected frame
953 is visible (Bug#10955).
954
cae07000
SM
9552012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
956
957 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
958
89c94350
JD
9592012-03-08 Jan Djärv <jan.h.d@swipnet.se>
960
961 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
962 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
963 zero (Bug#10954).
964
999dd333
GM
9652012-03-03 Glenn Morris <rgm@gnu.org>
966
01a6dcc8 967 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 968
de0100f2
EZ
9692012-03-02 Eli Zaretskii <eliz@gnu.org>
970
971 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
972 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
973 (redisplay_window, next_element_from_string): Fix typos in
974 comments.
3e441275
EZ
975 (redisplay_window): Pass to move_it_vertically the margin in
976 pixels, not in screen lines.
de0100f2 977
96a72ee9
GM
9782012-03-02 Glenn Morris <rgm@gnu.org>
979
980 * buffer.c (buffer-list-update-hook): Doc fix.
981
312508d7
EZ
9822012-02-29 Eli Zaretskii <eliz@gnu.org>
983
984 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
985 push_it before setting up the iterator for the first overlay
986 string, even if we have an empty string loaded.
987 (next_overlay_string): If there's an empty string on the iterator
988 stack, pop the stack. (Bug#10903)
989
27f3c637
PE
9902012-02-25 Paul Eggert <eggert@cs.ucla.edu>
991
992 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
993 Suggested by Stefan Monnier in
994 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
995 * alloc.c (widen_to_Lisp_Object): New static function.
996 (mark_memory): Also mark Lisp_Objects by fetching pointer words
997 and widening them to Lisp_Objects. This would work even if
998 USE_LSB_TAG is defined and wide integers are used, which might
999 happen in a future version of Emacs.
1000
3c9dfce6
CY
10012012-02-25 Chong Yidong <cyd@gnu.org>
1002
fa74b241
CY
1003 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1004 Doc fix.
1005
3c9dfce6
CY
1006 * xselect.c (Fx_selection_exists_p): Doc fix.
1007 (x_clipboard_manager_save_all): Print an informative message
1008 before saving to clipboard manager.
1009
9486df08
CY
10102012-02-24 Chong Yidong <cyd@gnu.org>
1011
1012 * keyboard.c (process_special_events): Handle all X selection
1013 requests in kbd_buffer, not just the next one (Bug#8869).
1014
f01d3321
CY
10152012-02-23 Chong Yidong <cyd@gnu.org>
1016
1017 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1018 call when setting menu-bar-lines and tool-bar-lines parameters.
1019 (unwind_create_frame_1): New helper function.
1020
1021 * window.c (inhibit_window_configuration_change_hook): New var.
1022 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 1023 (syms_of_window): Initialize it.
f01d3321 1024
86b847b6
CY
10252012-02-22 Chong Yidong <cyd@gnu.org>
1026
1027 * xterm.c (x_draw_image_relief): Add missing type check for
1028 Vtool_bar_button_margin (Bug#10743).
1029
a59225b1
CY
10302012-02-21 Chong Yidong <cyd@gnu.org>
1031
1032 * fileio.c (Vfile_name_handler_alist): Doc fix.
1033
1034 * buffer.c (Fget_file_buffer): Protect against invalid file
1035 handler return value.
1036
310f5bd4
PE
10372012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1038
cb3a28cc
PE
1039 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1040 when computing $valmask.
1041
310f5bd4
PE
1042 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1043 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1044 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1045 It's useless in that case, and it can cause problems on hosts
1046 that allocate halves of EMACS_INT values separately.
1047 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1048 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1049 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1050 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1051 it avoids undefined behavior on hosts where shifting right by more
1052 than the word width has undefined behavior.
1053
2375c96a
CY
10542012-02-19 Chong Yidong <cyd@gnu.org>
1055
1056 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1057 (Funhandled_file_name_directory, Ffile_name_as_directory)
1058 (Fdirectory_file_name, Fexpand_file_name)
1059 (Fsubstitute_in_file_name): Protect against invalid file handler
1060 return values (Bug#10845).
1061
3eb49e71
EZ
10622012-02-18 Eli Zaretskii <eliz@gnu.org>
1063
1064 * .gdbinit (pitx): Fix incorrect references to fields of the
1065 iterator stack.
1066
7b926f3f
CY
10672012-02-17 Chong Yidong <cyd@gnu.org>
1068
1069 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1070
11273115
PE
10712012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1074 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1075
c3a70e2b
CY
10762012-02-15 Chong Yidong <cyd@gnu.org>
1077
1078 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1079 marked as special. Also, starting docstrings with * is obsolete.
1080
0ca43699
AS
10812012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1082
1083 * gnutls.c (emacs_gnutls_write): Fix last change.
1084
2e8f3c56
LI
10852012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1086
1087 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1088 send_process.
1089
af70074f
SM
10902012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1091
1092 * keymap.c (Fsingle_key_description): Handle char ranges.
1093
95986d52
CY
10942012-02-12 Chong Yidong <cyd@gnu.org>
1095
afd83bd1
CY
1096 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1097 as that creates a dangerous corner case.
1098
95986d52
CY
1099 * window.c (Fdelete_window_internal): Invalidate the mouse
1100 highlight (Bug#9904).
1101
bd7da63e
GM
11022012-02-12 Glenn Morris <rgm@gnu.org>
1103
1104 * xselect.c (Fx_own_selection_internal)
1105 (Fx_get_selection_internal, Fx_disown_selection_internal)
1106 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1107 * nsselect.m (Fx_own_selection_internal)
1108 (Fx_disown_selection_internal, Fx_selection_exists_p)
1109 (Fx_selection_owner_p, Fx_get_selection_internal):
1110 Sync docs and argument specs with the xselect.c versions.
1111
77abcbc2
LI
11122012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1113
1114 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1115
90b671e2
EZ
11162012-02-11 Eli Zaretskii <eliz@gnu.org>
1117
1c0ca0b7
EZ
1118 * w32select.c (Fx_selection_exists_p): Sync doc string and
1119 argument list with xselect.c. (Bug#10783)
1120
1121 * w16select.c (Fx_selection_exists_p): Sync doc string and
1122 argument list with xselect.c. (Bug#10783)
90b671e2 1123
49241268
GM
11242012-02-10 Glenn Morris <rgm@gnu.org>
1125
1126 * fns.c (Fsecure_hash): Doc fix.
1127
f998bbe7 11282012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
1129
1130 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1131
0992bd9c
CY
11322012-02-07 Chong Yidong <cyd@gnu.org>
1133
1134 * buffer.c (Fbuffer_local_variables)
1135 (buffer_lisp_local_variables): Handle unbound vars correctly;
1136 don't let Qunbound leak into Lisp.
1137
af008560
GM
11382012-02-07 Glenn Morris <rgm@gnu.org>
1139
dd605cc4
GM
1140 * image.c (Fimagemagick_types): Doc fix.
1141
af008560
GM
1142 * image.c (imagemagick-render-type): Change it from a lisp object
1143 to an integer. Move the doc here from the lisp manual.
1144 Treat all values not equal to 0 the same.
1145
1449fa1d
CY
11462012-02-06 Chong Yidong <cyd@gnu.org>
1147
1148 * doc.c (store_function_docstring): Avoid applying docstring of
1149 alias to base function (Bug#2603).
1150
3723ec07
AS
11512012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1152
1153 * .gdbinit (pp1, pv1): Remove redundant defines.
1154 (pr): Use pp.
1155
79c1cc1e
CY
11562012-02-04 Chong Yidong <cyd@gnu.org>
1157
1158 * nsterm.m: Declare a global (Bug#10694).
1159
d7f29f8e
EZ
11602012-02-04 Eli Zaretskii <eliz@gnu.org>
1161
cae07000
SM
1162 * w32.c (get_emacs_configuration_options):
1163 Include --enable-checking, if specified, in the return value.
d7f29f8e 1164
3b95a6f9
MR
11652012-02-04 Martin Rudalics <rudalics@gmx.at>
1166
1167 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1168 after rounding frame sizes. (Bug#9723)
1169
d6fa96a6
EZ
11702012-02-04 Eli Zaretskii <eliz@gnu.org>
1171
1172 * keyboard.c (adjust_point_for_property): Don't position point
1173 before BEGV. (Bug#10696)
1174
df0b2940
PE
11752012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 Handle overflow when computing char display width (Bug#9496).
1178 * character.c (char_width): Return EMACS_INT, not int.
1179 (char_width, c_string_width): Check for overflow when
1180 computing the width; this is possible now that individual
1181 characters can have unbounded width. Problem introduced
1182 by merge from Emacs 23 on 2012-01-19.
1183
6bee44d6
MA
11842012-02-02 Michael Albinus <michael.albinus@gmx.de>
1185
1186 * dbusbind.c (Fdbus_register_method): Mention the return value
1187 :ignore in the docstring.
1188
44f92739
GM
11892012-02-02 Glenn Morris <rgm@gnu.org>
1190
1b9f60cc
GM
1191 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1192
44f92739
GM
1193 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1194 Unconditionally set to t. (Bug#10673)
1195 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1196 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1197 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1198
c5d3843c
KH
11992012-02-02 Kenichi Handa <handa@m17n.org>
1200
1201 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1202 0, do not call append_composite_glyph.
1203
159462d4 12042012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
1205
1206 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1207 NULL (Bug#6988).
1208 (x_produce_glyphs): If the component of a composition is a null
1209 string, set it->pixel_width to 1 to avoid zero-width glyph.
1210
78cef877
EZ
12112012-02-01 Eli Zaretskii <eliz@gnu.org>
1212
1213 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1214 first 2 arguments are identical. This makes inserting large
1215 output from a subprocess an order of magnitude faster on
1216 MS-Windows, where all sbrk'ed memory is always contiguous.
1217
97897668
GM
12182012-01-31 Glenn Morris <rgm@gnu.org>
1219
1220 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 1221 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
1222 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1223
31fd3586
GM
12242012-01-29 Glenn Morris <rgm@gnu.org>
1225
1226 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1227
0e24a8b2
CY
12282012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1229
1230 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1231
cc0adcb0
CY
12322012-01-28 Chong Yidong <cyd@gnu.org>
1233
1234 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1235
acc28cb9
CY
12362012-01-26 Chong Yidong <cyd@gnu.org>
1237
9c69cfb7
CY
1238 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1239
acc28cb9
CY
1240 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1241 repeat counts (Bug#10507).
1242
48da7392
GM
12432012-01-26 Glenn Morris <rgm@gnu.org>
1244
1245 * lread.c (syms_of_lread): Doc fix.
1246
14af5f7f
CY
12472012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1248
1249 * coding.c (encode_designation_at_bol): Change return value to
1250 EMACS_INT.
1251
0b21c100
CY
12522012-01-25 Chong Yidong <cyd@gnu.org>
1253
1254 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1255
3c2907f7
CY
12562012-01-21 Chong Yidong <cyd@gnu.org>
1257
1258 * floatfns.c (Fcopysign): Make the second argument non-optional,
1259 since nil is not allowed anyway.
1260
959ad23f
AS
12612012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1262
1263 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1264 (send_process): Likewise.
1265
34a02f46
MR
12662012-01-19 Martin Rudalics <rudalics@gmx.at>
1267
1268 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
1269 (Vwindow_persistent_parameters): Do not use Qstate.
1270 Rewrite doc-strings.
34a02f46 1271
1259009a 12722012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
1273
1274 * character.c (char_width): New function.
70d4fdf6
GM
1275 (Fchar_width, c_string_width, lisp_string_width):
1276 Use char_width (Bug#9496).
25ed9e61 1277
6a6ee00d
MR
12782012-01-16 Martin Rudalics <rudalics@gmx.at>
1279
1280 * window.c (Vwindow_persistent_parameters): New variable.
1281 (Fset_window_configuration, save_window_save): Handle persistent
1282 window parameters.
1283
c85efaf7
EZ
12842012-01-14 Eli Zaretskii <eliz@gnu.org>
1285
1286 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1287 thrashing the stack of the thread. (Bug#9087)
1288
5944709e
PE
12892012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1290
1291 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1292
e71f5d99
EZ
12932012-01-11 Eli Zaretskii <eliz@gnu.org>
1294
1295 * xdisp.c (rows_from_pos_range): Handle the case where the
1296 highlight ends on a newline. (Bug#10464)
1297 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1298 he end column for display of highlight that ends on a newline
1299 before a R2L line.
1300
ce316182
GM
13012012-01-11 Glenn Morris <rgm@gnu.org>
1302
1303 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1304 from load-path also when installation-directory is nil. (Bug#10208)
1305
5b43da69
GM
13062012-01-10 Glenn Morris <rgm@gnu.org>
1307
74cc8ff9
GM
1308 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1309
7d8d6e4e
GM
1310 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1311 Update template values to be closer to their typical values these days.
5b43da69 1312
a0db8d43
EZ
13132012-01-09 Eli Zaretskii <eliz@gnu.org>
1314
1315 * xdisp.c (rows_from_pos_range): Accept additional argument
1316 DISP_STRING, and accept any glyph in a row whose object is that
1317 string as eligible for mouse highlight. Fixes mouse highlight of
1318 display strings from overlays. (Bug#10464)
1319
9a0115ab 13202012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 1321
b9110d6a 1322 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
1323 * fileio.c (auto_saving_dir_umask): New static var.
1324 (Fmake_directory_internal): Use it.
1325 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1326 creating the directory. The old code temporarily assigns
1327 too-generous permissions to the directory.
1328 (do_auto_save_eh): Clear it.
b9110d6a 1329 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
1330 that the var is always cleared.
1331
6c1bd3f3
EZ
13322012-01-07 Eli Zaretskii <eliz@gnu.org>
1333
1334 * search.c (scan_buffer): Pass character positions to
1335 know_region_cache, not byte positions. (Bug#6540)
1336
069d2b50
L
13372012-01-07 LynX <_LynX@bk.ru> (tiny change)
1338
1339 * w32.c (sys_rename): Report EXDEV when rename of a directory
1340 fails because the target is on another logical disk. (Bug#10284)
1341
75bf0d33
DB
13422012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1343
1344 * xterm.c (x_embed_request_focus): New function.
1345
1346 * xterm.h: Add prototype.
1347
1348 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1349
1c6e5a32
GM
13502012-01-05 Glenn Morris <rgm@gnu.org>
1351
1352 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1353
651e947e
EZ
13542012-01-01 Eli Zaretskii <eliz@gnu.org>
1355
1356 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1357 Load gnutls_transport_set_lowat only if GnuTLS version is below
1358 2.11.1.
1359 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1360 GnuTLS versions below 2.11.1.
1361
3778cdd8
AL
13622011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1363
1364 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1365 to the doc string advising against its use for altering the way
1366 windows are scrolled.
1367
0e5317f7
KH
13682011-12-28 Kenichi Handa <handa@m17n.org>
1369
1370 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1371 coding-system ASCII compatible only when it does not produce BOM
1372 on encoding (Bug#10383).
1373
93d5ca1f
JD
13742011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1375
1376 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1377 can scroll.
1378 (create_and_show_popup_menu): Always use menu_position_func for
1379 Gtk3 (Bug#10361).
1380
ca22b785
AS
13812011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1382
1383 * callint.c (Fcall_interactively): Don't truncate prompt string.
1384
d048e1e6
EZ
13852011-12-23 Eli Zaretskii <eliz@gnu.org>
1386
1387 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1388 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 1389 resumed from there (after widening). (Bug#10360)
d048e1e6 1390
5ccaba1f
JD
13912011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1392
1393 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1394
204ee57f
JD
13952011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1396
b81d40f0
JB
1397 * nsterm.m (x_free_frame_resources):
1398 Release f->output_data.ns->miniimage.
204ee57f
JD
1399 (ns_index_color): Fix indentation. Do not retain
1400 color_table->colors[i].
1401
1402 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1403 before returning.
1404
1405 * nsfns.m (x_set_background_color): Assign return value from
1406 ns_index_color to face-background instead of NSColor*.
1407 (ns_implicitly_set_icon_type): Fix indentation.
1408 Change assignment in for loop to comparison.
1409
1410 * emacs.c (ns_pool): New variable.
1411 (main): Assign ns_pool.
1412 (Fkill_emacs): Call ns_release_autorelease_pool.
1413
1414 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1415 autorelease fdesc, release fdAttrs and tdict.
1416 (ns_get_covering_families): Release charset.
1417 (ns_findfonts): Release NSFontDescriptor created with new.
1418 (ns_uni_to_glyphs): Fix indentation.
1419 (setString): Release attrStr before assigning new value.
1420
c803b2b7
JD
14212011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1422
678f4426
JD
1423 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1424 and NS_IMPL_COCOA.
1425 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1426 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1427
cd394be1 14282011-12-18 David Reitter <reitter@cmu.edu>
678f4426 1429
5fecd5fc
JD
1430 * nsterm.m (ns_term_init): Subscribe for notifications
1431 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1432 to method trackingNotification in EmacsMenu.
1433
1434 * nsmenu.m (trackingMenu): New variable.
3771cb17 1435 (trackingNotification): New method (from Aquamacs).
5fecd5fc 1436 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 1437 from Aquamacs (Bug#7030).
678f4426
JD
1438
14392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 1440
c803b2b7
JD
1441 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1442 (symbol_to_nsstring): Fix indentation.
1443 (ns_symbol_to_pb): New function.
cae07000
SM
1444 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1445 (Fns_rotate_cut_buffers_internal): Remove.
1446 (Fns_store_selection_internal): Rename from
c803b2b7
JD
1447 Fns_store_cut_buffer_internal.
1448 (ns_get_foreign_selection, Fx_own_selection_internal)
1449 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1450 (Fns_get_selection_internal, Fns_store_selection_internal):
1451 Use ns_symbol_to_pb and check if return value is nil.
1452 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1453 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1454 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1455 renamed to Sns_store_selection_internal.
1456 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1457 and remove this function.
1458 (ns_handle_selection_clear): Remove, never used.
1459 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1460 here.
1461
e1b01a3a
KB
14622011-12-17 Ken Brown <kbrown@cornell.edu>
1463
1464 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1465 GID is unknown (Bug#10257).
1466
2adb6e85
PE
14672011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1468
1469 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1470 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1471 which caused a build failure on GNU/Linux IA-64. This problem was
1472 introduced by my 2011-10-07 patch.
1473
d1d7b339
JL
14742011-12-15 Juri Linkov <juri@jurta.org>
1475
1476 * image.c (imagemagick_error): New function. (Bug#10112)
1477 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1478 Use `imagemagick_error' where ImageMagick functions return
1479 `MagickFalse'.
1480 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1481 proper order.
1482
100d5755
KH
14832011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1484
1485 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1486 fill background (Bug#8992).
1487
454592a6
MR
14882011-12-13 Martin Rudalics <rudalics@gmx.at>
1489
1490 * window.c (Vwindow_combination_resize)
1491 (Vwindow_combination_limit): Use t instead of non-nil in
1492 doc-strings.
61d4b438
MR
1493 (Vrecenter_redisplay): Add first sentence of doc-string on
1494 separate line.
53524d93 1495 (Frecenter): Fix doc-string typo.
454592a6 1496
3633e3aa
KH
14972011-12-11 Kenichi Handa <handa@m17n.org>
1498
1499 * coding.c (Funencodable_char_position): Pay attention to the
1500 buffer text relocation (Bug#9389).
1501
7b9d523a
JD
15022011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1503
1504 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1505 gtk_init (Bug#10100).
1506
b73189c6
EZ
15072011-12-10 Eli Zaretskii <eliz@gnu.org>
1508
1509 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1510 IT->string is nil. (Bug#10263)
1511
f7dfe5d6
JD
15122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1513
83faebb4
JD
1514 * nsterm.h (x_free_frame_resources): Declare.
1515
f7dfe5d6
JD
1516 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1517 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1518
1519 * nsterm.h (ns_get_defaults_value): Declare.
1520
1521 * nsterm.m (ns_default): Call ns_get_defaults_value.
1522
7cd4e72c
EZ
15232011-12-09 Eli Zaretskii <eliz@gnu.org>
1524
1525 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1526 (Bug#10170)
1527
b34d7317
YM
15282011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1529
1530 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1531 that where the value of an _OBJC_* symbol points to is in the .bss
1532 section (Bug#10240).
1533
76470ad1
KH
15342011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1535
1536 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1537 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1538
745fff94
KH
15392011-12-08 Kenichi Handa <handa@m17n.org>
1540
1541 * ftfont.c (get_adstyle_property): Fix previous change
1542 (Bug#10233).
1543
6e44397c
JB
15442011-12-07 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1547 dirs from the default value of EMACSLOADPATH (bug#10208).
1548
7efa6272
GM
15492011-12-07 Glenn Morris <rgm@gnu.org>
1550
1551 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1552 installation and source directories as well. (Bug#10208)
1553
f6fc4d87
CY
15542011-12-06 Chong Yidong <cyd@gnu.org>
1555
1556 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1557
2bf26180
GM
15582011-12-06 Glenn Morris <rgm@gnu.org>
1559
1560 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1561 as an error, not just -1. (Bug#10217)
1562
3a6ad4f0
CY
15632011-12-05 Chong Yidong <cyd@gnu.org>
1564
1565 * keyboard.c (process_special_events): New function.
1566 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1567
75a3b399
PE
15682011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1569
1570 * coding.c (encode_designation_at_bol): Don't use uninitialized
1571 local variable (Bug#9318).
1572
c3c9e25e
KH
15732011-12-05 Kenichi Handa <handa@m17n.org>
1574
1575 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1576 return Qnil (Bug#8046, Bug#10193).
1577
5eb05ea3
KH
15782011-12-05 Kenichi Handa <handa@m17n.org>
1579
1580 * coding.c (encode_designation_at_bol): New args charbuf_end and
1581 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1582 (coding_set_source): Return how many bytes coding->source was
1583 relocated.
1584 (coding_set_destination): Return how many bytes
1585 coding->destination was relocated.
1586 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1587 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1588
15892011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1590
1591 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1592 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1593 macro (Bug#9318).
1594
15952011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1596
1597 The following changes are to fix Bug#9318.
1598
a79703f5 1599 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1600 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1601 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1602 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1603
7dbda6df
JB
16042011-12-05 Juanma Barranquero <lekktu@gmail.com>
1605
1606 * lisp.h (process_quit_flag): Fix external declaration.
1607
6d5eb5b0
SM
16082011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1609
1610 Don't macro-inline non-performance-critical code.
1611 * eval.c (process_quit_flag): New function.
1612 * lisp.h (QUIT): Use it.
1613
a0c3fad0
JD
16142011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1615
1616 * nsfns.m (get_geometry_from_preferences): New function.
1617 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1618
6c07aac2
AS
16192011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1620
1621 * emacs.c (Qkill_emacs): Define.
1622 (syms_of_emacs): Initialize it.
1623 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1624 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1625 (quit_throw_to_read_char): Add parameter `from_signal'.
1626 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1627 * lisp.h (QUIT): Call Fkill_emacs if requested.
1628
c052ead4
JD
16292011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1630
1631 * widget.c (update_wm_hints): Return if wmshell is null.
1632 (widget_update_wm_size_hints): New function.
1633
1634 * widget.h (widget_update_wm_size_hints): Declare.
1635
1636 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1637 widget_update_wm_size_hints (Bug#10104).
1638
9e49252b
EZ
16392011-12-03 Eli Zaretskii <eliz@gnu.org>
1640
1641 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1642 before a newline, prepare the bidi iterator for consuming the
1643 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1644 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1645
02b16839
JL
16462011-12-02 Juri Linkov <juri@jurta.org>
1647
1648 * search.c (Fword_search_regexp): New Lisp function created from
1649 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1650 (Fword_search_backward, Fword_search_forward)
1651 (Fword_search_backward_lax, Fword_search_forward_lax):
1652 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1653 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1654
0068070e
SM
16552011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1656
1657 * fileio.c (Finsert_file_contents): Move after-change-function call
1658 to before the "handled:" label, since all "goto handled" appear in
1659 cases where the *-change-functions have already been properly called
1660 (bug#10117).
1661
3360a3fc
AS
16622011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1663
1664 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1665 waiting for input. (Bug#10169)
1666
73d6c093
EZ
16672011-11-30 Eli Zaretskii <eliz@gnu.org>
1668
1669 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1670 verifies glyph row's hash code--we have just reallocated the
1671 glyphs, so their contents can be complete garbage. (Bug#10164)
1672
febe6bea
JB
16732011-11-30 Juanma Barranquero <lekktu@gmail.com>
1674
1675 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1676
801a4313
EZ
16772011-11-30 Eli Zaretskii <eliz@gnu.org>
1678
1679 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1680 attributes are tested _before_ calling verify_row_hash, to protect
1681 against GCC re-ordering of the tests. (Bug#10164)
1682
2b56b87e
JD
16832011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1684
1685 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1686
1687 * xterm.c (handle_one_xevent): Only set async_visible and friends
1688 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1689 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1690 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1691
dbf31225
PE
16922011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1693
1694 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1695 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1696 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1697 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1698 All uses changed to use GCPRO1 etc.
1699 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1700 Revert to old implementation (i.e., before 2011-03-11).
1701
1305621b
YM
17022011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1703
1704 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1705 of scroll runs so as to avoid assigning disabled bogus rows and
1706 unnecessary graphics copy operations.
1707
8c9afb46
EZ
17082011-11-27 Eli Zaretskii <eliz@gnu.org>
1709
1710 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1711 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1712 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1713 (malloc, free, realloc, calloc): Redirect to e_* only when
1714 compiling Emacs.
1715
1716 * lisp.h (GCTYPEBITS): Move before first use.
1717 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1718 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1719 this macro definition.
1720
1721 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1722 _MSC_VER.
1723
54e9e3bf
JD
17242011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1725
6d5eb5b0
SM
1726 * gtkutil.c (xg_create_frame_widgets):
1727 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1728 present with Gtk+ 2.0.
1729
83aca1cb
PE
17302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1731
1732 * fileio.c (Finsert_file_contents): Undo previous change; see
1733 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1734
5b76caa4
PE
17352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 Rename locals to avoid shadowing.
1738 * fileio.c (Finsert_file_contents):
1739 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1740 * process.c (wait_reading_process_output):
1741 Rename inner 'proc' to 'p' to avoid shadowing.
1742 Indent for consistency with usual Emacs style.
1743
8c535114
EZ
17442011-11-25 Eli Zaretskii <eliz@gnu.org>
1745
1746 * xdisp.c (redisplay_window): If cursor row is not fully visible
1747 after recentering, and scroll-conservatively is set to a large
1748 number, scroll window by a few more lines to make the cursor fully
1749 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1750 (start_display): Don't move to the next line if the display should
1751 start at a newline that is part of a display vector or an overlay
1752 string. (Bug#10119)
8c535114 1753
fa4fdb5c
JL
17542011-11-24 Juri Linkov <juri@jurta.org>
1755
1756 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1757 after the `MagickPingImage' call. (Bug#10112)
1758
90ec88df
CY
17592011-11-23 Chong Yidong <cyd@gnu.org>
1760
1761 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1762
56e2e794
MR
17632011-11-23 Martin Rudalics <rudalics@gmx.at>
1764
1765 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1766 making another buffer current. (Bug#10114)
1767
b6e64c41
GM
17682011-11-23 Glenn Morris <rgm@gnu.org>
1769
1770 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1771
6b21de18
CY
17722011-11-23 Chong Yidong <cyd@gnu.org>
1773
1774 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1775 using it (Bug#5984).
1776
b12cd789
EZ
17772011-11-22 Eli Zaretskii <eliz@gnu.org>
1778
1779 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1780 and header-lines, as they don't have one computed for them.
1781 (Bug#10098)
1782
1783 * .gdbinit (prow): Make displayed values more self-explaining.
1784 Add row's hash code.
1785
261b6fd4
LMI
17862011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1787
1788 * process.c (wait_reading_process_output): Fix asynchrounous
1789 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1790 (wait_reading_process_output): Add comment and URL.
261b6fd4 1791
e7cfd277
JD
17922011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1793
1794 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1795
a9b9b7f5
CY
17962011-11-21 Chong Yidong <cyd@gnu.org>
1797
1798 * window.c (Fnext_window, Fprevious_window): Doc fix.
1799
b0d15b4f
SM
18002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1801
1802 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1803
fe7a3057
JB
18042011-11-20 Juanma Barranquero <lekktu@gmail.com>
1805
1806 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1807
d2999b1a
MR
18082011-11-20 Martin Rudalics <rudalics@gmx.at>
1809
1810 * window.c (Fset_window_combination_limit): Rename argument
1811 STATUS to LIMIT.
1812 (Vwindow_combination_limit): Remove "status" from doc-string.
1813
d5ff9cd0
AS
18142011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1815
1816 * m/ibms390.h: Remove.
1817 * m/ibms390x.h: Don't include "ibms390.h".
1818
a5bb9bd3
SM
18192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1820
1821 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1822 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1823
cd1181db
JB
18242011-11-20 Juanma Barranquero <lekktu@gmail.com>
1825
1826 * casetab.c (Fset_case_table):
1827 * charset.c (Fcharset_after): Fix typos.
1828
615a3b8d 18292011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1830
17e845af
PE
1831 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1832 Otherwise, valgrind does not work on some platforms.
1833 Problem reported by Andreas Schwab in
6a0bf43d
PE
1834 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1835 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1836 is set, removing the need for VIRT_ADDRESS_VARIES.
1837 (PURE_P): Use a more-efficient implementation that needs just one
1838 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1839 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1840 to 4 (xorl, subq, cmpq, setbe).
1841 * alloc.c (pure): Always extern now, since that's the
1842 VIRT_ADDR_VARIES behavior.
1843 (PURE_POINTER_P): Use a single comparison, not two, for
1844 consistency with the new puresize.h.
1845 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1846 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1847 Remove VIRT_ADDR_VARIES no longer needed.
1848
f8fe6f96
EZ
18492011-11-19 Eli Zaretskii <eliz@gnu.org>
1850
1851 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1852 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1853 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1854 behave as if the cursor position were at the window margin.
1855
1856 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1857 and the cursor position is out of bounds, behave as if the cursor
1858 position were at the window margin. (Bug#10075)
1859
df05a53c
CY
18602011-11-18 Chong Yidong <cyd@gnu.org>
1861
1862 * window.c (Fwindow_combination_limit): Make first argument
1863 non-optional, since it is meaningless for live windows like the
1864 selected window.
1865
2071918e
DA
18662011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1867
1868 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1869
b50a28de
SM
18702011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1871
1872 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1873 (graft_intervals_into_buffer): Simplify.
1874
015137db
EZ
18752011-11-18 Eli Zaretskii <eliz@gnu.org>
1876
1877 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1878 hash values of the two rows.
1879 (copy_row_except_pointers): Preserve the used[] arrays and the
1880 hash values of the two rows. (Bug#10035)
68c95424 1881 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1882
1883 * xdisp.c (row_hash): New function, body extracted from
1884 compute_line_metrics.
1885 (compute_line_metrics): Call row_hash, instead of computing the
1886 hash code inline.
1887
1888 * dispnew.c (verify_row_hash): Call row_hash for computing the
1889 hash code of a row, instead of duplicating code from xdisp.c.
1890
1891 * dispextern.h (row_hash): Add prototype.
1892
a2addb04
TH
18932011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1894
1895 * frame.c (delete_frame): Don't delete the terminal when the last
1896 X frame is closed if emacs is built with GTK toolkit.
1897
df85d315
JB
18982011-11-17 Juanma Barranquero <lekktu@gmail.com>
1899
1900 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1901
a0c2d0ae
MR
19022011-11-17 Martin Rudalics <rudalics@gmx.at>
1903
1904 * window.c (Vwindow_splits): Rename to
1905 Vwindow_combination_resize. Suggested by Juri Linkov.
1906 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1907 of Vwindow_splits.
1908
58179cce
JB
19092011-11-16 Juanma Barranquero <lekktu@gmail.com>
1910
7877f373
JB
1911 * nsfns.m (Fns_font_name):
1912 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1913
b6f67890
MR
19142011-11-16 Martin Rudalics <rudalics@gmx.at>
1915
1916 * window.h (window): Rename slot "nest" to "combination_limit".
1917 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1918 (Fset_window_nest): Rename to Fset_window_combination_limit.
1919 (Vwindow_nest): Rename to Vwindow_combination_limit.
1920 (recombine_windows, make_parent_window, make_window)
1921 (Fsplit_window_internal, saved_window)
1922 (Fset_window_configuration, save_window_save): Rename all
1923 occurrences of window_nest to window_combination_limit.
1924
c7015153
JB
19252011-11-15 Juanma Barranquero <lekktu@gmail.com>
1926
1927 * image.c (imagemagick_load_image): Fix typo.
1928
322ad6ec
EZ
19292011-11-14 Eli Zaretskii <eliz@gnu.org>
1930
1931 * xdisp.c (display_line): Move the call to
1932 highlight_trailing_whitespace before the call to
1933 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1934 faces of all the glyphs to compute ROW's hash value.
1935 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1936
f067b8ec
JB
19372011-11-14 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1940 just return (bug#10044).
1941
1e5b2111
EZ
19422011-11-12 Eli Zaretskii <eliz@gnu.org>
1943
7ef3cbd5
EZ
1944 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1945 with user-defined heap size. Bump the default size of the temacs
1946 heap to 27MB, to avoid memory warning when running temacs.
1947 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1948
1e5b2111
EZ
1949 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1950 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1951 (verify_row_hash) [XASSERTS]: New function.
1952 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1953 that the hash value of glyph rows is correct.
1e5b2111 1954
89d61221
MR
19552011-11-12 Martin Rudalics <rudalics@gmx.at>
1956
1957 * window.h (window): Remove splits slot.
1958 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1959 (Fdelete_other_windows_internal, make_parent_window)
1960 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1961 (Fset_window_configuration, save_window_save): Don't deal with
1962 split status of windows.
1963 (saved_window): Remove splits slot.
1964 (Vwindow_splits): Rewrite doc-string.
1965
97f18cc8
JD
19662011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1967
1968 * xfns.c (unwind_create_frame):
1969 * nsfns.m (unwind_create_frame):
1970 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1971 Vframe_list (Bug#9999).
1972
22a648b4
DA
19732011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1974
0b381c7e 1975 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1976
659afede
KH
19772011-11-11 Kenichi Handa <handa@m17n.org>
1978
1979 * callproc.c (Fcall_process): Set the member dst_multibyte of
1980 process_coding.
1981
9ac0394b
KH
19822011-11-11 Johan Bockgård <bojohan@gnu.org>
1983
1984 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1985 avoid a crash (bug#9496).
1986
2fbdc249
CY
19872011-11-09 Chong Yidong <cyd@gnu.org>
1988
1989 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1990 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1991
ac6b1f81
PE
19922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1995
09db192c
PE
19962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1997
1998 Avoid some portability problems by eschewing 'extern inline' functions.
1999 The trivial performance wins aren't worth the portability hassles; see
2000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2001 et seq.
2002 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2003 (window_box_width, window_box_left, window_box_left_offset)
2004 (window_box_right, window_box_right_offset): Undo previous change,
2005 by removing the "extern"s.
2006 * intervals.c (adjust_intervals_for_insertion)
2007 (adjust_intervals_for_deletion): Undo previous change,
2008 making these static again.
2009 (offset_intervals, temp_set_point_both, temp_set_point)
2010 (copy_intervals_to_string): No longer inline.
2011 * xdisp.c (window_text_bottom_y, window_box_width)
2012 (window_box_height, window_box_left_offset)
2013 (window_box_right_offset, window_box_left, window_box_right)
2014 (window_box): No longer inline.
2015
105216ed
CY
20162011-11-08 Chong Yidong <cyd@gnu.org>
2017
2018 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
2019 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2020 Signal an error if not a live window.
105216ed
CY
2021 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2022 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2023
ae9e237f
JB
20242011-11-07 Juanma Barranquero <lekktu@gmail.com>
2025
2026 * lisp.h (syms_of_abbrev): Remove declaration.
2027 Reported by CHENG Gao <chenggao@royau.me>.
2028
c7aa8333
EZ
20292011-11-07 Eli Zaretskii <eliz@gnu.org>
2030
2031 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2032 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2033 of temacs in GUI mode.
2034
be7f5545
MR
20352011-11-07 Martin Rudalics <rudalics@gmx.at>
2036
2037 * window.h: Declare delete_all_child_windows instead of
2038 delete_all_subwindows.
2039 * window.c (Fwindow_nest, Fset_window_nest)
2040 (Fset_window_new_total, Fset_window_new_normal)
2041 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2042 (delete_all_subwindows): Rename to delete_all_child_windows.
2043 (Fdelete_other_windows_internal, Fset_window_configuration):
2044 Call delete_all_child_windows instead of delete_all_subwindows.
2045 * frame.c (delete_frame): Call delete_all_child_windows instead
2046 of delete_all_subwindows.
2047
ca78dc43
PE
20482011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2051 This is also needed for porting to any host where GC_MARK_STACK is
2052 not GC_MAKE_GCPROS_NOOPS.
2053 (which_symbols): Use it.
2054
a0241d01
KH
20552011-11-07 Kenichi Handa <handa@m17n.org>
2056
2057 * coding.c (coding_set_destination): Check coding->src_pos only
2058 when coding->src_object is a buffer (bug#9910).
2059
2060 * process.c (send_process): Set the member src_multibyte of coding
2061 to 0 (bug#9911) when sending a unibyte text.
2062
2063 * callproc.c (Fcall_process): Set the member src_multibyte of
2064 process_coding to 0 (bug#9912).
2065
a64bfdfa 20662011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
2067
2068 * xmenu.c (cleanup_widget_value_tree): New function.
2069 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2070 calling free_menubar_widget_value_tree directly (Bug#9830).
2071
cb41b32a
PE
20722011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 Fix some portability problems with 'inline'.
2075 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2076 (window_box_width, window_box_left, window_box_left_offset)
2077 (window_box_right, window_box_right_offset): Declare extern.
2078 Otherwise, these inline functions do not conform to C99 and
2079 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2080 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2081 * intervals.c (adjust_intervals_for_insertion)
2082 (adjust_intervals_for_deletion): Now extern, because otherwise the
2083 extern inline functions 'offset_intervals' couldn't refer to it.
2084 (static_offset_intervals): Remove.
2085 (offset_intervals): Rewrite using the old contents of
2086 static_offset_intervals. The old version didn't conform to C99
2087 because an extern inline function contained a reference to an
2088 identifier with static linkage.
2089
b7041366
AS
20902011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2091
2092 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2093 GC.
2094
88a37c4d
EZ
20952011-11-06 Eli Zaretskii <eliz@gnu.org>
2096
2097 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2098 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2099 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2100 return Qleft_to_right.
2101
49745b39
CY
21022011-11-06 Chong Yidong <cyd@gnu.org>
2103
2104 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2105 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2106 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2107 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2108 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2109 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2110 (Fwindow_vscroll): Doc fix.
2111 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2112 argument, since it makes no sense to pass a live window and for
2113 consistency with window-child.
2114
1f05cd82
CS
21152011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2116
2117 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2118 support MSVC.
2119
22610910
JR
21202011-11-05 Jason Rumney <jasonr@gnu.org>
2121
2122 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2123 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2124 fonts (Bug#6029).
2125 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2126 bitwise arithmetic preventing use of unicode-sip and non-truetype
2127 opentype fonts.
2128
a06776b2
EZ
21292011-11-05 Eli Zaretskii <eliz@gnu.org>
2130
3ad924ba
EZ
2131 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2132 "emacs"-only part.
2133
a06776b2
EZ
2134 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2135 initialization code to keep similarity to xfns.c after changes
2136 from 2011-11-05.
2137
c9e7db78
JD
21382011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2139
a97f8f3f
JD
2140 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2141 (unwind_create_frame): New function (Bug#9943).
2142 (Fx_create_frame): Restructure code to be more similar to the one in
2143 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2144 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2145 Move terminal->reference_count++ just before making the frame official
2146 (Bug#9943).
2147
2148 * nsterm.m (x_free_frame_resources): New function.
2149 (x_destroy_window): Move code to x_free_frame_resources.
2150
c9e7db78 2151 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
2152 (Fx_create_frame, x_create_tip_frame):
2153 Move terminal->reference_count++ just before making the frame
75f1671a 2154 official. Move initialization of image_cache_refcount and
c9e7db78
JD
2155 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2156
a6fc3b5c
EZ
21572011-11-05 Eli Zaretskii <eliz@gnu.org>
2158
2159 Support MSVC build with newer versions of Visual Studio.
2160 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2161 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2162 nt/gmake.defs.
2163
2164 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2165 which are not supported by MSVC.
2166 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2167 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2168 bitfields.
2169 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2170 types in bitfields.
2171 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2172
2173 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2174
58179cce 21752011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
2176
2177 Support MSVC build with newer versions of Visual Studio.
2178 * w32.c: Don't include w32api.h for MSVC.
2179 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2180
2181 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2182 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2183 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2184 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2185 e_* cousins.
2186 (alloca) [_MSC_VER]: Define to _alloca.
2187
2188 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2189
2190 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2191
a58c13ed
EZ
21922011-11-04 Eli Zaretskii <eliz@gnu.org>
2193
2194 * xdisp.c (note_mouse_highlight): If either of
2195 previous/next-single-property-change returns nil, treat that as
2196 the beginning or the end of the buffer. (Bug#9955)
2197
fe0b6370
JD
21982011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2199
a58c13ed 2200 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
2201 label is not null (Bug#9951).
2202 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2203 may be NULL.
2204
89bd5ee1
EZ
22052011-11-04 Eli Zaretskii <eliz@gnu.org>
2206
2207 * window.c (Fwindow_body_size): Mention in the doc string that the
2208 return value is in frame's canonical units. (Bug#9949)
2209
84c3edb9
EZ
22102011-11-03 Eli Zaretskii <eliz@gnu.org>
2211
4e2fb5c7
EZ
2212 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2213
84c3edb9 2214 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 2215 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 2216 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 2217
bc17a887
EZ
22182011-11-01 Eli Zaretskii <eliz@gnu.org>
2219
2220 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2221 Don't stop backward scan on the continuation glyph, even though
2222 its CHARPOS is positive.
6d5eb5b0
SM
2223 (mouse_face_from_buffer_pos, note_mouse_highlight):
2224 Rename cover_string to disp_string.
bc17a887 2225
4ee88440
MR
22262011-11-01 Martin Rudalics <rudalics@gmx.at>
2227
2228 * window.c (temp_output_buffer_show): Don't use
2229 Vtemp_buffer_show_specifiers.
2230 (Vtemp_buffer_show_specifiers): Remove unused variable.
2231
c2ff3c02
EZ
22322011-10-30 Eli Zaretskii <eliz@gnu.org>
2233
2234 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2235 past the beginning of the current glyph matrix.
2236
58179cce 22372011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
2238
2239 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2240 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2241 HAVE_GTK3 (Bug#9869).
b77a6a7f 2242
3b574623
JD
2243 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2244 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2245
b77a6a7f
JD
2246 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2247
2248 * xterm.c: Declare x_handle_net_wm_state to return int.
2249 (handle_one_xevent): Check if we are iconified but don't have
2250 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2251 (get_current_wm_state): Return non-zero if not hidden,
2252 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2253 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2254 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2255 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2256
196e41e4
PE
22572011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2258
2259 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2260 so that this new function doesn't get optimized away by a
2261 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2262
021f2e1a
AS
22632011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2264
2265 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2266
8b058d44
EZ
22672011-10-29 Eli Zaretskii <eliz@gnu.org>
2268
2269 Fix the `xbytecode' command.
2270 * .gdbinit (xprintbytestr): New command.
b50a28de 2271 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
2272 (xbytecode): Print the byte-code string as well.
2273
4452fb80
EZ
22742011-10-29 Kim Storm <storm@cua.dk>
2275
8b058d44
EZ
2276 * alloc.c (which_symbols): New function.
2277
21b72067
AS
22782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2279
2280 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2281 line. (Bug#9903)
2282
83ed7b5c
GM
22832011-10-29 Glenn Morris <rgm@gnu.org>
2284
2285 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2286 Not clear what it was for, and it causes various bugs. (Bug#9839)
2287
5a7a728b
EZ
22882011-10-28 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2291 possible random value that matches one of those tested as
2292 condition to clear the mouse face.
2293
d3d0842f
CY
22942011-10-28 Chong Yidong <cyd@gnu.org>
2295
2296 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2297
31b39d13
DN
22982011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2299
2300 * window.c (make_window): Initialize phys_cursor_on_p.
2301
9aba6043
SM
23022011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2303
2304 * lisp.h (struct Lisp_Symbol): Update comments.
2305
c20992f4
JB
23062011-10-28 Juanma Barranquero <lekktu@gmail.com>
2307
2308 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2309
db4f02f2
EZ
23102011-10-28 Eli Zaretskii <eliz@gnu.org>
2311
2312 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2313 <oslsachem@gmail.com> for helping to debug this.
2314
2315 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2316 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2317 (g_b_init_get_glyph_outline_w): New static variables.
2318 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2319 (GetGlyphOutlineW_Proc): New typedefs.
2320 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
2321 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2322 New functions.
2323 (w32font_open_internal, compute_metrics):
2324 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
2325 instead of calling the "wide" APIs directly.
2326
2327 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2328
2329 * w32.h (syms_of_w32font): Add prototype.
2330
87e68db4
JB
23312011-10-27 Juanma Barranquero <lekktu@gmail.com>
2332
2333 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2334 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2335 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2336 (Fmove_to_window_line): Doc fix.
2337
435c1d67
CY
23382011-10-27 Chong Yidong <cyd@gnu.org>
2339
2340 * process.c (make_process): Set gnutls_state to NULL.
2341
2342 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2343 non-NULL, regardless of GNUTLS_INITSTAGE.
2344 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2345 an error. Set process slots as soon as we allocate them.
2346
2347 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2348
9c6c6f49
CY
23492011-10-27 Chong Yidong <cyd@gnu.org>
2350
9aba6043
SM
2351 * gnutls.c (emacs_gnutls_deinit): New function.
2352 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
2353 (Fgnutls_deinit, Fgnutls_boot): Use it.
2354
2355 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2356 (deactivate_process): Call emacs_gnutls_deinit.
2357
657d08d3
JB
23582011-10-27 Juanma Barranquero <lekktu@gmail.com>
2359
2360 * image.c (x_create_x_image_and_pixmap):
2361 * w32.c (sys_rename, w32_delayed_load):
2362 * w32font.c (fill_in_logfont):
2363 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2364
5430d399
JB
23652011-10-26 Juanma Barranquero <lekktu@gmail.com>
2366
2367 * w32fns.c (w32_default_color_map): New function,
2368 extracted from Fw32_default_color_map.
a7ef684b 2369 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 2370
fe0055fa
PE
23712011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2372
2373 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2374
e6346438
SM
23752011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2376
2377 * keyboard.c (test_undefined): New function (bug#9751).
2378 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2379
e112cc37
ET
23802011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2381
2382 * sysdep.c (init_sys_modes): Fix the check for the controlling
2383 terminal (Bug#6649).
2384
7b5d6677
EZ
23852011-10-20 Eli Zaretskii <eliz@gnu.org>
2386
2387 * dispextern.h (struct bidi_it): New member next_en_type.
2388
2389 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2390 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2391 current character, check also for next_en_type being WEAK_EN.
2392 (bidi_resolve_weak): Don't enter the expensive loop if the current
2393 position is before next_en_pos. Record the bidi type of the first
2394 non-ET, non-BN character we find, in addition to its position.
2395 (bidi_level_of_next_char): Invalidate next_en_type when
2396 next_en_pos is over-stepped.
2397
7da0b018
PE
23982011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2401 * editfns.c: Rewrite current-time-zone so that it invokes
2402 the equivalent of (format-time-string "%Z") to get the time zone name.
2403 This fixes a bug when the time zone name contains characters that
2404 need converting from the system time locale to Emacs internal format.
2405 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2406 that patch fixed format-time-string to do the conversion, but
2407 I forgot to fix current-time-zone.
2408 (format_time_string): New function, containing most of
2409 what Fformat_time_string used to contain.
2410 (Fformat_time_string): Rewrite in terms of format_time_string.
2411 This doesn't change this function's behavior.
2412 (current-time-zone): Rewrite to use format_time_string.
2413 This fixes the bug reported by Michael Schierl in
2414 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2415 Jason Rumney's 2007-06-07 change worked around this bug, but
2416 didn't fix it.
2417 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2418
8547b010
EZ
24192011-10-19 Eli Zaretskii <eliz@gnu.org>
2420
2421 * xdisp.c (start_display): If the character at POS is displayed
2422 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
2423 (try_window_reusing_current_matrix): If a line ends in a display
2424 vector or the next line starts in a display vector, continue
2425 redrawing the window even though the character position of
2426 start_row was reached.
8547b010
EZ
2427 (Bug#9771, part 2)
2428
4e948d15
CY
24292011-10-18 Chong Yidong <cyd@gnu.org>
2430
2431 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2432 with nobreak-char-display too.
2433
4787455f
EZ
24342011-10-18 Eli Zaretskii <eliz@gnu.org>
2435
2436 Fix part 3 of bug#9771.
2437 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2438 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2439 non-neutral characters if the current character is a paragraph
2440 separator (a.k.a. Newline). This avoids running the same
2441 expensive loop twice, once when we consume the preceding newline
2442 and the other time when the line actually needs to be displayed.
2443 Avoid the loop when we see neutrals on the base embedding level
2444 following a character whose directionality is the same as the
2445 paragraph's. This avoids running the expensive loop when a line
2446 ends in a long sequence of neutrals, like control characters.
2447 Add assertion against STRONG_AL type. Slightly rearrange code
2448 that determines the type of a neutral given the first non-neutral
2449 that follows it.
2450 (bidi_level_of_next_char): Set next_en_pos to zero when
2451 invalidating its info.
2452
2c91f553
EZ
24532011-10-17 Eli Zaretskii <eliz@gnu.org>
2454
2455 * xdisp.c (push_display_prop): Determine whether to record string
2456 or buffer position by IT->string, not by IT->method. Allow
2457 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2458 (move_it_vertically_backward): Don't look for character position
2459 immediately after the newline when in a continuation line.
2460 (Bug#9771, part 1)
2c91f553 2461
c7b08b0d
MR
24622011-10-15 Martin Rudalics <rudalics@gmx.at>
2463
2464 * window.c (coordinates_in_window): Rewrite and delabelize
2465 vertical border check. (Bug#5357) (Bug#9618)
2466
6b02f655
SM
24672011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2468
2469 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2470 errors in XSetWindowBorder (bug#9310).
2471
81d40c92
DA
24722011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2473
2474 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2475 avoid crash when xmalloc overrun checking is enabled.
2476
d4172c3b
EZ
24772011-10-13 Eli Zaretskii <eliz@gnu.org>
2478
2479 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2480 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2481 cursor motion with <left> and <right> arrow keys.
2482
2483 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2484 some callers set that themselves.
2485
b00eea75
EZ
24862011-10-12 Eli Zaretskii <eliz@gnu.org>
2487
2488 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2489 display string and the previous row comes from the same string and
2490 is empty. (Bug#9739) (Bug#9738)
2491
8fe012c4
SM
24922011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2493
2494 * doc.c (get_doc_string): Encode file name (bug#9735).
2495
0074aef2
EZ
24962011-10-12 Eli Zaretskii <eliz@gnu.org>
2497
79beb178
EZ
2498 * bidi.c (bidi_level_of_next_char):
2499 * xdisp.c (get_visually_first_element): Remove old incorrect
2500 comments regarding the Unicode Line Separator character.
2501
0074aef2
EZ
2502 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2503
6e4b3fbe
DA
25042011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2505
2506 * alloc.c (Fgc_status): Do not access beyond zombies array
2507 boundary if nzombies > MAX_ZOMBIES.
2508 * alloc.c (dump_zombies): Add missing format specifier.
2509
0324f3af
PE
25102011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2511
b5525cac
PE
2512 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2513 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2514
0324f3af
PE
2515 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2516 Some packages use them to denote characters with modifiers.
2517
e9b5f888
AS
25182011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2519
2520 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2521 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2522 matching a pp-number. Rename parameter var to var1.
2523
127827c0
SM
25242011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2525
2526 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2527
c8fd3bd0
GM
25282011-10-08 Glenn Morris <rgm@gnu.org>
2529
2530 * callint.c (Fcall_interactively): Give a more explicit error for the
2531 'c' case with a non-character input. (Bug#8479)
2532
352ec8ff
EZ
25332011-10-08 Eli Zaretskii <eliz@gnu.org>
2534
03669ccb
EZ
2535 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2536 lines.
7061c986
EZ
2537 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2538 lines that are hscrolled on the left.
03669ccb 2539
352ec8ff
EZ
2540 * dispnew.c (buffer_posn_from_coords): Account for a possible
2541 presence of header-line. (Bug#4426)
2542
a66cfb1c
SM
25432011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2544
6b02f655
SM
2545 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2546 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2547
7c5ee88e
PE
25482011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2551 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2552 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2553 this makes Emacs dump core during garbage collection on rare
2554 occasions. sizeof is obviously inferior to offsetof here, so
2555 stick with offsetof.
2556 (GC_POINTER_ALIGNMENT): New macro.
2557 (mark_memory): Omit 3rd (offset) arg; caller changed.
2558 Don't assume EMACS_INT alignment is the same as pointer alignment.
2559
df1bbe5b
SM
25602011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2561
2562 * keyboard.c (read_key_sequence_remapped): New var.
2563 (read_key_sequence): Compute remapping in the right buffer.
2564 (command_loop_1): Use read_key_sequence's remapping directly.
2565
51553db6
SM
25662011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2567
32c1fffd
SM
2568 * dired.c (file_name_completion): Don't expand file name.
2569 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2570 before checking file name handler.
2571
51553db6
SM
2572 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2573 they've been requested explicitly (bug#9591).
2574
b6bd1599 25752011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2576
2577 * keymap.c (Fsingle_key_description): Use make_specified_string
2578 instead of build_string to build string from push_key_description.
2579 (Bug#5193)
2580
f701dc2a
PE
25812011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2582
4222c55d
PE
2583 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2584 This fixes a Y2038 bug on 64-bit hosts.
2585 * buffer.c (reset_buffer):
2586 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2587 (Fclear_buffer_auto_save_failure):
2588 Use 0, not -1, to represent an unset failure time, since time_t
2589 might not be signed.
2590
f701dc2a
PE
2591 Remove dependency on glibc malloc internals.
2592 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2593 Move back here from lisp.h, but with their new implementations.
2594 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2595 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2596 * charset.c (charset_table_init): New static var.
2597 (syms_of_charset): Use it instead of xmalloc. This removes a
2598 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2599 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2600 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2601 Move back to alloc.c.
2602 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2603 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2604
9ceebf39
JD
26052011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2606
2607 * nsterm.m (windowDidResize): Call x_set_window_size only when
2608 ns_in_resize is true. Otherwise set pixelwidth/height and
2609 call change_frame_size (Bug#9628).
2610
cb993c58
PE
26112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2612
3930c88b
PE
2613 Port --enable-checking=all to Fedora 14 x86-64.
2614 * charset.c (syms_of_charset): Also account for glibc malloc's
2615 internal overhead when calculating the initial malloc maximum.
2616
cb993c58
PE
2617 Port --enable-checking=all to Fedora 14 x86.
2618 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2619 Move to lisp.h.
2620 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2621 (overrun_check_realloc, overrun_check_free):
2622 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2623 That way, xmalloc returns a properly-aligned pointer even if
2624 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2625 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2626 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2627 into account when calculating the initial malloc maximum.
2628 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2629 Move here from alloc.c, so that charset.c can use it too.
2630 Properly align; the old code wasn't right for common 32-bit hosts
2631 when configured with --enable-checking=all.
2632 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2633 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2634
31bed486
EZ
26352011-09-29 Eli Zaretskii <eliz@gnu.org>
2636
04c70788 2637 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2638 use EDOM.
2639
fbcaa2f3
EZ
26402011-09-28 Eli Zaretskii <eliz@gnu.org>
2641
2642 * xdisp.c (compute_display_string_end): If there's no display
2643 string at CHARPOS, return -1.
2644
2645 * bidi.c (bidi_fetch_char): When compute_display_string_end
2646 returns a negative value, treat the character as a normal
2647 character not covered by a display string. (Bug#9624)
2648
a239d4e9
JB
26492011-09-28 Juanma Barranquero <lekktu@gmail.com>
2650
2651 * lread.c (Fread_from_string): Fix typo in docstring.
2652
88652fd5
EZ
26532011-09-27 Eli Zaretskii <eliz@gnu.org>
2654
2655 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2656 newline, reseat the iterator instead of bidi-iterating there one
2657 character at a time. (Bug#9610)
32c1fffd
SM
2658 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2659 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2660
ed497dd4
AS
26612011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2662
2663 * lread.c (readevalloop): Use correct code for NBSP.
2664 (read1): Likewise. (Bug#9608)
2665
b2bf61aa
MA
26662011-09-25 Michael Albinus <michael.albinus@gmx.de>
2667
2668 * dbusbind.c (Fdbus_register_signal): When service is not
2669 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2670
32bbb17c
GM
26712011-09-25 Glenn Morris <rgm@gnu.org>
2672
2673 * buffer.c (truncate-lines): Doc fix.
2674
94e0933e
CY
26752011-09-24 Chong Yidong <cyd@stupidchicken.com>
2676
2677 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2678 (Fset_window_next_buffers): Doc fix.
2679
cddde921
GM
26802011-09-24 Glenn Morris <rgm@gnu.org>
2681
2682 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2683
1260aef1
PE
26842011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2685
25b4bfa0
PE
2686 Fix minor problems found by static checking.
2687 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2688 * indent.c (Fvertical_motion): Fix == vs = typo.
2689
e3cbd34b
EZ
26902011-09-24 Eli Zaretskii <eliz@gnu.org>
2691
a66cfb1c
SM
2692 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2693 Default value is now t. Doc fix.
6bf7006f 2694
e3cbd34b 2695 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2696 logic when moving up, not only when moving down. Fix the
e3cbd34b 2697 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2698 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2699
2700 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2701 CHARPOS is covered by a display string which includes newlines.
2702 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2703 is covered by a display string with embedded newlines.
2704
a3de0cbd
MA
27052011-09-24 Michael Albinus <michael.albinus@gmx.de>
2706
2707 * dbusbind.c (Fdbus_register_signal): Add match rule to
2708 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2709 (Fdbus_register_method, Vdbus_registered_objects_table):
2710 Fix docstring.
a3de0cbd 2711
b260039d
JM
27122011-09-24 Jim Meyering <meyering@redhat.com>
2713
32c1fffd 2714 do not ignore write error for any output size
b260039d
JM
2715 The previous change was incomplete.
2716 While it makes emacs --batch detect the vast majority of stdout
2717 write failures, errors were still ignored whenever the output size is
2718 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2719 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2720 && echo FAIL: ignored write error
2721 FAIL: ignored write error
2722 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2723 && echo FAIL: ignored write error
2724 FAIL: ignored write error
2725 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2726
8eca8a7c
AS
27272011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2728
2729 * emacs.c (Fkill_emacs): In noninteractive mode exit
2730 non-successfully if a write error occurred on stdout. (Bug#9574)
2731
3341db62
EZ
27322011-09-21 Eli Zaretskii <eliz@gnu.org>
2733
2734 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2735 the xassert test.
2736
2737 * dispextern.h (struct it): Update the comment documenting what
2738 can it->OBJECT be.
2739
8c203dbf
EZ
27402011-09-20 Eli Zaretskii <eliz@gnu.org>
2741
2742 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2743 a display string, extend search for cursor position to end of row.
2744 (find_row_edges): If the row ends in a newline from a display
2745 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2746 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2747 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2748 non-empty line. Fixes confusing cursor motion with arrow keys at
2749 the beginning of a line that starts with whitespace.
8c203dbf 2750
a4824228
LMI
27512011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2752
2753 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2754 (bug#9493).
2755
33ed493b
CY
27562011-09-18 Chong Yidong <cyd@stupidchicken.com>
2757
2758 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2759 boolean (Bug#9154).
2760
56cd55c8
EZ
27612011-09-18 Eli Zaretskii <eliz@gnu.org>
2762
2763 * xdisp.c (display_line): Record maximum and minimum buffer
2764 positions even if no glyphs were produced (e.g., by a zero-width
2765 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2766 buffer positions that will be removed from the glyph row because
2767 they don't fit.
c02dcedf
EZ
2768 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2769 column is beyond frame width: don't subtract 1 "pixel" when
2770 computing width of the stretch.
3e62b7e0
EZ
2771 (reseat_at_next_visible_line_start): Undo the change made on
2772 2011-09-17 that saved paragraph information and restored it after
2773 the call to `reseat'. (Bug#9545)
56cd55c8 2774
5ed99d36 27752011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2776
2777 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2778 and turn window cursor on if cleared (Bug#9415).
2779
5ed99d36 27802011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2781
2782 * search.c (boyer_moore): Take unibyte characters from pattern
2783 literally. (Bug#9458)
2784
9bade7b2
EZ
27852011-09-18 Eli Zaretskii <eliz@gnu.org>
2786
2787 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2788
e5e9d610
PE
27892011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2790
87e4427a
PE
2791 Fix minor problem found by static checking.
2792 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2793 initialized, to pacify gcc -Wuninitialized.
2794
e5e9d610
PE
2795 * fileio.c: Report proper errno when syscall falls.
2796 (Finsert_file_contents): Save and restore errno,
2797 so that report_file_error outputs the correct diagnostic.
2798 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2799
a1674f0b
EZ
28002011-09-18 Eli Zaretskii <eliz@gnu.org>
2801
2802 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2803
fbfb6dd4
EZ
28042011-09-17 Eli Zaretskii <eliz@gnu.org>
2805
2806 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2807 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2808
bb187662
EZ
28092011-09-17 Eli Zaretskii <eliz@gnu.org>
2810
1137e8b8 2811 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2812 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2813
2814 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2815 (bidi_find_paragraph_start): Search back for paragraph beginning
2816 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2817 (bidi_move_to_visually_next): Only trigger paragraph-related
2818 computations when the last character is a newline or at EOB, not
2819 just any NEUTRAL_B. (Bug#9470)
2820
bb187662
EZ
2821 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2822 truncated lines if point is covered by a display string. (Bug#9524)
2823
2e621251
PE
28242011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2825
2826 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2827 (cons_to_x_long): New function.
2828 (lisp_data_to_selection_data): Use it. Correct the test for
2829 short-versus-long data; it was negated. Break out of vector
2830 loop, for efficiency, when a long datum is discovered.
2831
91a15bc6
SM
28322011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2833
2834 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2835
b41c3a35
EZ
28362011-09-16 Eli Zaretskii <eliz@gnu.org>
2837
2838 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2839 GCC PR/17406) by declaring this function with external scope.
2840
7812ba2d
PE
28412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2844 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2845
cf7edc2a
AS
28462011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2847
2848 * editfns.c (Fformat): Correctly handle text properties on "%%".
2849
bd01620e
EZ
28502011-09-15 Eli Zaretskii <eliz@gnu.org>
2851
2852 * xterm.c (x_draw_composite_glyph_string_foreground):
2853 * w32term.c (x_draw_composite_glyph_string_foreground):
2854 * term.c (encode_terminal_code):
2855 * composite.c (composition_update_it, get_composition_id):
2856 * xdisp.c (get_next_display_element)
2857 (fill_composite_glyph_string): Add comments about special meaning
2858 of TAB characters in a composition.
2859
a02719a3
PE
28602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2861
2862 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2863 This occurs when processing a multibyte format.
2864 Problem reported by Wolfgang Jenker.
a02719a3 2865
72589a3c
JB
28662011-09-15 Johan Bockgård <bojohan@gnu.org>
2867
2868 * xdisp.c (try_cursor_movement): Only check for exact match if
2869 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2870
1c14176c
PE
28712011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 Remove unused external symbols.
2874 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2875 * xdisp.c (calc_pixel_width_or_height): Now static.
2876 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2877 * indent.c (check_display_width):
2878 * w32term.c: Fix comment to match code.
2879 * xterm.c, xterm.h (x_catching_errors): Remove.
2880
d2eea5b5
PE
28812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2882
2883 * xselect.c: Use signed conversions more consistently (Bug#9498).
2884 (selection_data_to_lisp_data): Assume incoming selection data are
2885 signed integers, not unsigned. This is to be consistent with
2886 outgoing selection data, which was modified to use signed integers
2887 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2888 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2889 expects long, not unsigned long.
2890
46888499
EZ
28912011-09-14 Eli Zaretskii <eliz@gnu.org>
2892
2893 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2894 computation of loop end. Reported by Johan Bockgård
2895 <bojohan@gnu.org>.
2896
ef8ef9fb
CY
28972011-09-13 Chong Yidong <cyd@stupidchicken.com>
2898
2899 * frame.c (Fother_visible_frames_p): Function deleted.
2900
fa819fed
EZ
29012011-09-12 Eli Zaretskii <eliz@gnu.org>
2902
2903 * indent.c (compute_motion): Process display vector front to back
2904 rather than the other way around. (Bug#2496)
2905
2ba8e008
SM
29062011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2907
2908 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2909
20f53c69
CY
29102011-09-11 Chong Yidong <cyd@stupidchicken.com>
2911
2912 * minibuf.c (Fread_from_minibuffer): Doc fix.
2913
d562d7a4
EZ
29142011-09-11 Eli Zaretskii <eliz@gnu.org>
2915
2916 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2917 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2918
1c4d7f3d
LMI
29192011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2920
2921 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2922 value for non-existent files.
2923
b885bf36
EZ
29242011-09-11 Eli Zaretskii <eliz@gnu.org>
2925
2926 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2927 set its "size" to -1. This will set the modtime_size field of
2928 the corresponding buffer to -1, which is what
2929 verify-visited-file-modtime expects for files that do not exist.
2930 (Bug#9139)
2931
6612f0bf
PE
29322011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2933
2934 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2935 here ...
2936 * lisp.h: ... from here. push_key_description is no longer
2937 defined in keyboard.c, so its declaration should not be in
2938 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2939 logically belongs with push_key_description.
2940
dfb3f755
PE
29412011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 * buffer.h: Include <sys/types.h> instead of <time.h>.
2944 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2945 Problem reported by Herbert J. Skuhra.
2946
3134906c
LMI
29472011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2948
2949 * xml.c (parse_region): Make the parsing work for
2950 non-comment-starting XML files again (bug#9144).
2951
8d903f4e
AS
29522011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2953
2954 * image.c (gif_load): Fix calculation of bottom and right corner.
2955 (Bug#9468)
2956
80ad64f4
EZ
29572011-09-10 Eli Zaretskii <eliz@gnu.org>
2958
2959 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2960 redisplay in small windows.
2961
208a048d
EZ
29622011-09-09 Eli Zaretskii <eliz@gnu.org>
2963
2964 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2965
9b1c252e
MR
29662011-09-08 Martin Rudalics <rudalics@gmx.at>
2967
2968 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2969 Operate on live windows only.
2970
2949f33b
JB
29712011-09-08 Juanma Barranquero <lekktu@gmail.com>
2972
2973 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2974
e08dcafd
EZ
29752011-09-07 Eli Zaretskii <eliz@gnu.org>
2976
2977 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2978 only under bidi iteration.
2979
115b96bd
JD
29802011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2981
2982 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2983
c8199d0f
PE
29842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2985
2986 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2987 Without this fix, the command to link temacs failed due to an
2988 undefined symbol __builtin_isnan. This is because
2989 /usr/include/iso/math_c99.h #defines isnan(x) to
2990 __builtin_isnan(x), but the bundled gcc, which identifies itself
2991 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2992 a __builtin_isnan.
2993 * floatfns.c (isnan): #undef, and then #define to a clone of
2994 what's in data.c.
2995 (Fisnan): Always define, since it's always available now.
2996 (syms_of_floatfns): Always define isnan at the Lisp level.
2997
e39b275c 29982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2999
3000 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3001
b2db44d9 30022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 3003
f4af5137 3004 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
3005 The previous code assumed that file offsets (off_t values) fit in
3006 EMACS_INT variables, which is not true on typical 32-bit hosts.
3007 The code messed up by falsely reporting buffer overflow in cases
3008 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3009 when "big" contains more than 2**29 bytes, even though this
3010 inserts just one byte and does not overflow the buffer.
3011 (Finsert_file_contents): Store file offsets as off_t
3012 values, not as EMACS_INT values. Check for overflow when
3013 converting between EMACS_INT and off_t. When checking for
3014 buffer overflow or for overlap, take the offsets into account.
3015 Don't use EMACS_INT for small values where int suffices.
3016 When checking for overlap, fix a typo: ZV was used where
3017 ZV_BYTE was intended.
3018 (Fwrite_region): Don't assume off_t fits into 'long'.
3019 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3020
ecfc0a49
MA
30212011-09-05 Michael Albinus <michael.albinus@gmx.de>
3022
3023 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3024
6511acf2 30252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 3026
0999621a 3027 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
3028
3029 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 3030 (esprintf, exprintf, evxprintf): New functions.
62f19c19 3031 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 3032 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
3033 (modify_event_symbol): Do not assume that the length of
3034 name_alist_or_stem is safe to alloca and fits in int.
3035 (Fexecute_extended_command): Likewise for function name and binding.
3036 (Frecursion_depth): Wrap around reliably on integer overflow.
3037 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3038 since some callers pass EMACS_INT values.
3039 (Fsingle_key_description): Don't crash if symbol name contains more
3040 than MAX_ALLOCA bytes.
3041 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3042 (get_minibuffer): Arg is now EMACS_INT, not int.
3043 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 3044 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
3045 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3046
2be7d702
PE
3047 * dbusbind.c (signature_cat): New function.
3048 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
3049 Do not overrun buffer; instead, report string overflow.
3050
9d1df220
PE
3051 * dispnew.c (add_window_display_history): Don't overrun buffer.
3052 Truncate instead; this is OK since it's just a log.
3053
33ef5c64
PE
3054 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3055 even if the time zone offset is outlandishly large.
3056 Don't mishandle offset == INT_MIN.
3057
66c6fdd5
PE
3058 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3059 when creating daemon; the previous buffer-overflow check was incorrect.
3060
d749b01b
PE
3061 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3062 which has the guts of the old verror function.
3063
b5cd1905
PE
3064 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3065 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3066
6e1a67fb
PE
3067 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3068 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 3069 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 3070 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
3071 length of string rather than counting it via multiple sprintfs;
3072 that's simpler and more reliable.
c21721cc
PE
3073 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3074 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3075 sprintf, in case result does not fit in int.
3076
c57b67fc
PE
3077 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3078 (fontset_from_font): Print it.
3079
8a401434
PE
3080 * frame.c (tty_frame_count): Now printmax_t, not int.
3081 (make_terminal_frame, set_term_frame_name): Print it.
3082 (x_report_frame_params): In X, window IDs are unsigned long,
3083 not signed long, so print them as unsigned.
3084 (validate_x_resource_name): Check for implausibly long names,
3085 and don't assume name length fits in 'int'.
3086 (x_get_resource_string): Don't blindly alloca invocation name;
3087 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3088 not fit in int.
3089
6e1a67fb
PE
3090 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3091 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
3092 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3093
0df02bf3
PE
3094 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3095 Use esprintf, not sprintf, in case result does not fit in int.
3096
48e30793
PE
3097 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3098 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3099 it as a large positive number.
3100 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3101 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3102
a66ff6d8
PE
3103 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3104 in case result does not fit in int.
3105
aca216ff
PE
3106 * print.c (float_to_string): Detect width overflow more reliably.
3107 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3108 buffer overrun. Don't assume list length fits in 'int'. Treat
3109 print length of 0 as 0, not as infinity; to be consistent with other
3110 uses of print length in this function. Don't overflow print length
3111 index. Don't assume hash table size fits in 'long', or that
3112 vectorlike size fits in 'unsigned long'.
3113
31c286f7
PE
3114 * process.c (make_process): Use printmax_t, not int, to format
3115 process-name gensyms.
3116
55e5faa1
PE
3117 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3118
80f2e268
PE
3119 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3120 to avoid potential buffer overrun.
3121
670741ab
PE
3122 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3123 if X resource line is longer than 512 bytes.
3124
b7163a50
PE
3125 * xfns.c (x_window): Make sprintf buffer a bit bigger
3126 to avoid potential buffer overrun.
3127
ae58ff1f
PE
3128 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3129
c43c8a6a
PE
3130 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3131
3f8236f4
PE
31322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3133
53e9fe90 3134 Integer overflow fixes for scrolling, etc.
6511acf2
PE
3135 Without these, Emacs silently mishandles large integers sometimes.
3136 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
3137 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3138
6511acf2
PE
3139 * xdisp.c (try_window_id): Check Emacs fixnum range before
3140 converting to 'int'.
806add1d 3141
6511acf2 3142 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
3143 Check that an Emacs fixnum is in range before assigning it to 'int'.
3144 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3145 values converted from Emacs fixnums.
3146 (Frecenter): Don't wrap around a line count if it is out of 'int'
3147 range; instead, treat it as an extreme value.
3148 (Fset_window_configuration, compare_window_configurations):
3149 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3150
6511acf2
PE
3151 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3152 that can exceed INT_MAX. Check that EMACS_INT value is in range
3153 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
3154 (match_limit): Don't assume that a fixnum can fit in 'int'.
3155
6511acf2 3156 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
3157 exceed INT_MAX.
3158
6511acf2 3159 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
3160 (Fvertical_motion): Don't wrap around LINES values that don't fit
3161 in 'int'. Instead, treat them as extreme values. This is good
3162 enough for windows, which can't have more than INT_MAX lines anyway.
3163
fcb901a7
LMI
31642011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3165
0f2f6b6d
LMI
3166 * Require libxml/parser.h to avoid compilation warning.
3167
fcb901a7
LMI
3168 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3169
3170 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3171 since this reportedly can destroy thread storage.
3172
6e20a0d4
CY
31732011-08-30 Chong Yidong <cyd@stupidchicken.com>
3174
3175 * syntax.c (find_defun_start): Update all cache variables if
3176 exiting early (Bug#9401).
3177
148ae00e
EZ
31782011-08-30 Eli Zaretskii <eliz@gnu.org>
3179
f6cfbd8f
EZ
3180 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3181
148ae00e
EZ
3182 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3183 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3184 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3185
3186 * term.c (tty_append_glyph): New function.
3187 (produce_stretch_glyph): Static function and its prototype deleted.
3188
a66cfb1c
SM
3189 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3190 Add prototypes.
148ae00e 3191
c4a07a4c
PE
31922011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3195 when checking :margin (Bug#9390).
3196 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 3197 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
3198 so that the name doesn't mislead. All uses changed.
3199
6bc8cd65
JB
32002011-08-28 Johan Bockgård <bojohan@gnu.org>
3201
3202 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3203 set_tty_hooks.
3204
dca4927e
EZ
32052011-08-27 Eli Zaretskii <eliz@gnu.org>
3206
3207 * xdisp.c (move_it_to): Don't bail out early when reaching
3208 position beyond to_charpos, if we are scanning backwards.
3209 (move_it_vertically_backward): When DY == 0, make sure we get to
3210 the first character in the line after the newline.
3211
f2cad773
PE
32122011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3213
3214 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3215 (ccl_driver): Do not generate an out-of-range pointer.
3216 (Fccl_execute_on_string): Remove unnecessary check for
3217 integer overflow, noted by Stefan Monnier in
3218 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3219 Remove a FIXME that didn't need fixing.
3220 Simplify the newly-introduced buffer reallocation code.
3221
0cae2cdb
JB
32222011-08-27 Juanma Barranquero <lekktu@gmail.com>
3223
3224 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3225
5fc295a4 32262011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 3227
70c60eb2 3228 Integer and memory overflow issues (Bug#9196).
726e0ab1 3229
d31850da
PE
3230 * doc.c (get_doc_string): Rework so that
3231 get_doc_string_buffer_size is the actual buffer size, rather than
3232 being 1 less than the actual buffer size; this makes xpalloc more
3233 convenient.
3234
a69fbedb
PE
3235 * image.c (x_allocate_bitmap_record, cache_image):
3236 * xselect.c (Fx_register_dnd_atom):
3237 Simplify previous changes by using xpalloc.
3238
fe5c5d37
PE
3239 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3240 since either will do and ptrdiff_t is convenient with xpalloc.
3241
0065d054
PE
3242 * charset.c (charset_table_size)
3243 (struct charset_sort_data.priority): Now ptrdiff_t.
3244 (charset_compare): Don't overflow if priorities differ greatly.
3245 (Fsort_charsets): Don't assume list length fits in int.
3246 Check for size-calculation overflow when allocating sort data.
3247 (syms_of_charset): Allocate an initial charset table that is
3248 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3249
3250 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3251
3252 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3253 The actual value is always <= INT_MAX, and leaving it unsigned made
3254 overflow checking harder.
3255
3256 * dispextern.h (struct glyph_matrix.rows_allocated)
3257 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3258 with xpalloc. The values are still always <= INT_MAX.
3259
3260 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3261
3262 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3263 (SAFE_NALLOCA): New macro.
3264
3265 * region-cache.c (struct boundary.pos, find_cache_boundary)
3266 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3267 (set_cache_region, invalidate_region_cache)
3268 (revalidate_region_cache, know_region_cache, region_cache_forward)
3269 (region_cache_backward, pp_cache):
3270 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3271 so that ptrdiff_t * can be passed to xpalloc.
3272 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3273 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3274 (pp_cache): Don't assume cache_len fits in int.
3275 * region-cache.h: Adjust extern decls to match.
3276
3277 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3278 EMACS_INT, since either will do, for xpalloc.
3279
3280 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3281 (xnmalloc, xnrealloc, xpalloc): New functions.
3282
726e0ab1
PE
3283 * bidi.c (bidi_shelve_header_size): New constant.
3284 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3285 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3286
51f30bc5 3287 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
3288 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3289 (overlay_strings):
3290 Don't update size of array until after memory allocation succeeds,
3291 because xmalloc/xrealloc may not return.
0065d054
PE
3292 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3293 now that we have proper integer overflow checking.
3294 (record_overlay_string, overlay_strings): Catch overflows when
3295 calculating size of overlay_str_buf.
726e0ab1 3296
0065d054
PE
3297 * callproc.c (Fcall_process): Check for size overflow when
3298 calculating size of args2.
3299 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3300 Normally we prefer signed values, but sticking with ptrdiff_t would
3301 require adding more-complicated checks.
726e0ab1
PE
3302
3303 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3304 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3305 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 3306 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
3307
3308 * character.c (Fstring): Check for size-calculation overflow.
3309
3310 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3311 unnecessary integer overflow. Check for size overflow.
3312 (encode_coding_object): Don't update size until xmalloc succeeds.
3313
3314 * composite.c (get_composition_id): Check for overflow in glyph
3315 length calculations.
3316
3317 Integer and memory overflow fixes for display code.
3318 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3319 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3320 (scrolling_window): Check for overflow in size calculations.
3321 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3322 Don't assume glyph table len fits in int.
3323 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3324 (row_table_size): Now ptrdiff_t, not int.
3325 (scrolling_window): Avoid overflow in size calculations.
3326 Don't update size until allocation succeeds.
3327 * fns.c (concat): Check for overflow in size calculations.
3328 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3329 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3330 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3331
3332 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3333 (get_doc_string): Check for size calculation overflow.
3334 Don't update size until allocation succeeds.
3335 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3336 EMACS_INT, where ptrdiff_t will do.
3337 (Fsubstitute_command_keys): Check for string overflow.
3338
3339 * editfns.c (set_time_zone_rule): Don't assume environment length
3340 fits in int.
3341 (message_length): Now ptrdiff_t, not int.
3342 (Fmessage_box): Don't update size until allocation succeeds.
3343 Don't assume message length fits in int.
3344 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3345
0065d054
PE
3346 * emacs.c (main): Do not reallocate argv, since there is a null at
3347 the end that can be overwritten, and this way there's no need to
3348 worry about size-calculation overflow.
3349 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
3350
3351 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3352 alloc succeeds.
3353 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3354
3355 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3356 (x_set_scroll_bar_width, x_figure_window_size):
3357 Check for integer overflow.
3358 (x_set_alpha): Do not assume XINT fits in int.
3359
3360 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3361 This is for the members text_lines, text_cols, total_lines, total_cols,
3362 where the system imposes an 'int' limit.
3363
3364 * fringe.c (Fdefine_fringe_bitmap):
3365 Don't update size until alloc works.
3366
3367 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3368 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3369
3370 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3371 Check for size-calculation overflow.
3372 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3373 do, as we prefer signed integers.
3374 (id_to_widget.max_size, id_to_widget.used)
3375 (xg_store_widget_in_map, xg_remove_widget_from_map)
3376 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3377 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3378 Use and return ptrdiff_t, not int.
3379 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3380 * gtkutil.h: Change prototypes to match the above.
3381
3382 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3383 are duplicate now that they've been promoted to lisp.h.
3384 (x_allocate_bitmap_record, x_alloc_image_color)
3385 (make_image_cache, cache_image, xpm_load):
3386 Don't update size until alloc is done.
3387 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3388 (x_detect_edges):
3256efce 3389 Check for size calculation overflow.
726e0ab1
PE
3390 (ct_colors_allocated_max): New constant.
3391 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3392 overflow.
3256efce 3393
726e0ab1
PE
3394 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3395 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3396 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3397 Use ptrdiff_t, not int, to count maps.
3398 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
3399 calculations. Don't update size until allocation succeeds.
3400 Redo calculations to avoid overflow.
726e0ab1
PE
3401 * keyboard.h: Change prototypes to match the above.
3402
3403 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3404 to count maps.
3405 (current_minor_maps): Check for size calculation overflow.
3406 * keymap.h: Change prototypes to match the above.
3407
3408 * lread.c (read1, init_obarray): Don't update size until alloc done.
3409
3410 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3411 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3412
726e0ab1
PE
3413 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3414 Now ptrdiff_t, not int.
3415 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3416 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3417
3418 * process.c (Fnetwork_interface_list): Check for overflow
3419 in size calculation.
3420
3421 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3422
3423 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3424 overflow. Don't bother calling xmalloc when xrealloc will do.
3425
3426 * search.c (Freplace_match): Check for size calculation overflow.
3427 (Fset_match_data): Don't assume list lengths fit in 'int'.
3428
3429 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3430 for command line length. Do not attempt to address one before the
3431 beginning of an array, as that's not portable.
3432
3433 * term.c (max_frame_lines): Remove; unused.
3434 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3435 not int.
3436 (encode_terminal_code, calculate_costs): Check for size
3437 calculation overflow.
3438 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3439 table lengths and related sizes. Don't update size until alloc
3440 done. Redo calculations to avoid overflow.
3441 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3442
3443 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3444 subtracting pointers.
3445 (gobble_line): Check for overflow more carefully. Don't update size
3446 until alloc done.
3447
3448 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3449 Don't update size until alloc done.
3450 Redo size calculations to avoid overflow.
3451 Check for size calculation overflow.
0065d054 3452 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3453
3454 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3455 Use ptrdiff_t, not int, for sizes.
3456 (store_mode_line_noprop_char): Don't update size until alloc done.
3457
0065d054
PE
3458 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3459 Use ptrdiff_t, not int, for sizes.
3460 (Finternal_make_lisp_face, cache_face):
3461 Check for size calculation overflow.
3462 (cache_face): Treat size calculation overflows as if they were
3463 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3464
3465 * xfns.c (x_encode_text, x_set_name_internal)
3466 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3467 sizes, since they can exceed INT_MAX in size. Check for size
3468 calculation overflow.
3469
0065d054
PE
3470 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3471 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3472 Don't update size until alloc done.
3473
0065d054 3474 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3475 as sprintf is limited to int lengths.
1d526e2f 3476
252c5ee1
PE
3477 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3478 (X_LONG_MIN): New macros.
864d7ce7
PE
3479 Use them to make the following changes clearer.
3480 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3481 This change doesn't affect the value now, but it may help remind
3482 future maintainers not to raise the value too much later.
3483 (SELECTION_QUANTUM): Remove, replacing with ...
3484 (selection_quantum): ... new function, which avoids overflow.
3485 All uses changed.
3486 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3487 assumption that selection length fits in 'int'.
3488 (x_reply_selection_request, x_handle_selection_request)
3489 (x_get_window_property, receive_incremental_selection)
3490 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3491 (lisp_data_to_selection_data, clean_local_selection_data):
3492 Use ptrdiff_t, not int, to record length of selection.
3493 (x_reply_selection_request, x_get_window_property)
3494 (receive_incremental_selection, x_property_data_to_lisp):
3495 Redo calculations to avoid overflow.
3496 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3497 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3498 something.
3499 (x_get_window_property, receive_incremental_selection)
3500 (lisp_data_to_selection_data, x_property_data_to_lisp):
3501 Check for size-calculation overflow.
3502 (x_get_window_property, receive_incremental_selection)
3503 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3504 Don't store size until memory allocation succeeds.
3505 (x_get_window_property): Plug memory leak on memory exhaustion.
3506 Don't double-block input; malloc is safe here. Don't assume 2**34
3507 - 4 fits in unsigned long. Add an xassert to check
3508 XGetWindowProperty overflow. Be more careful about overflow
3509 calculations, and distinguish size from memory overflow better.
3510 (receive_incremental_selection): When tracing, don't assume
3511 unsigned int is less than INT_MAX.
3512 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3513 harmful) conversions of unsigned short to int.
3514 (lisp_data_to_selection_data): Don't assume that integers
3515 in the range -65535 through -1 fit in an X unsigned short.
3516 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3517 result parameters unless successful. Rely on cons_to_unsigned
3518 to report problems with elements; the old code wasn't right anyway.
3519 (x_check_property_data): Check for int overflow; we cannot use
3520 a wider type due to X limits.
3521 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3522
726e0ab1 3523 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3524
0065d054
PE
3525 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3526 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3527 (x_color_cells): Don't store size until memory allocation succeeds.
3528 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3529 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3530 (x_term_init): Don't assume length fits in int (sprintf is limited
3531 to int size).
bc18e09d 3532
ebfa62c0
PE
3533 Use ptrdiff_t for composition IDs.
3534 * character.c (lisp_string_width):
3535 * composite.c (composition_table_size, n_compositions)
3536 (get_composition_id, composition_gstring_from_id):
3537 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3538 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3539 * window.c (Frecenter):
3540 Use ptrdiff_t, not int, for composition IDs.
3541 * composite.c (get_composition_id): Check for integer overflow.
3542 * composite.h: Adjust prototypes to match the above changes.
3543
d3411f89
PE
3544 Use ptrdiff_t for hash table indexes.
3545 * category.c (hash_get_category_set):
3546 * ccl.c (ccl_driver):
3547 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3548 * coding.c (coding_system_charset_list, detect_coding_system):
3549 * coding.h (struct coding_system.id):
3550 * composite.c (get_composition_id, gstring_lookup_cache):
3551 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3552 * image.c (xpm_get_color_table_h):
3553 * lisp.h (hash_lookup, hash_put):
3554 * minibuf.c (Ftest_completion):
3555 Use ptrdiff_t for hash table indexes, not int (which is too
3556 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3557 32-bit --with-wide-int hosts).
3558
e097a6fa
PE
3559 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3560 Add a FIXME comment about memory leaks.
3561 (syms_of_charset): Don't assume xmalloc returns.
3562
5637687f
PE
3563 Don't assume that stated character widths fit in int.
3564 * character.c (Fchar_width, c_string_width, lisp_string_width):
3565 * character.h (CHAR_WIDTH):
3566 * indent.c (MULTIBYTE_BYTES_WIDTH):
3567 Use sanitize_char_width to avoid undefined and/or bad behavior
3568 with outlandish widths.
a66cfb1c 3569 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3570 now that we have two such functions. All uses changed.
3571 (sanitize_char_width): New inline function.
3572
a2271ba2
PE
3573 Don't assume that tab-width fits in int.
3574 * character.h (sanitize_width): New inline function.
3575 (SANE_TAB_WIDTH): New macro.
3576 (ASCII_CHAR_WIDTH): Use it.
3577 * indent.c (sane_tab_width): Remove. All uses replaced by
3578 SANE_TAB_WIDTH (current_buffer).
3579 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3580
18c52557
PE
3581 * fileio.c: Integer overflow issues with file modes.
3582 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3583
caeeedc1
PE
3584 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3585 Remove unreachable code.
3586 (read_hex, load_charset_map_from_file): Check for integer overflow.
3587
6df6ae42 3588 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3589 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3590 (x_send_scroll_bar_event): Likewise. Check that the size does not
3591 exceed limits imposed by XClientMessageEvent, as well as the usual
3592 ptrdiff_t and size_t limits.
3593
b13995db
PE
3594 * keyboard.c: Overflow, signedness and related fixes.
3595 (make_lispy_movement): Use same integer type in forward decl
3596 that is used in the definition.
3597 (read_key_sequence, keyremap_step):
3598 Change bufsize argument back to int, undoing my 2011-03-30 change.
3599 We prefer signed types, and int is wide enough here.
3600 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3601 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3602 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3603 length, not size_t. Use ptrdiff_t for index, not int.
3604 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3605 possibility of integer overflow.
3606
13464394
PE
3607 Overflow, signedness and related fixes for images.
3608
3609 * dispextern.h (struct it.stack[0].u.image.image_id)
3610 (struct_it.image_id, struct image.id, struct image_cache.size)
3611 (struct image_cache.used, struct image_cache.ref_count):
3612 * gtkutil.c (update_frame_tool_bar):
3613 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3614 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3615 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3616 * nsmenu.m (update_frame_tool_bar):
3617 * xdisp.c (calc_pixel_width_or_height):
3618 * xfns.c (image_cache_refcount):
3619 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3620 on typical 64-bit hosts.
3621
3622 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3623 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3624 Omit unnecessary casts to int.
3625 (parse_image_spec): Check that integers fall into 'int' range
3626 when the callers expect that.
3627 (image_ascent): Redo ascent calculation to avoid int overflow.
3628 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3629 (lookup_image): Remove unnecessary tests.
3630 (xbm_image_p): Locals are now of int, not EMACS_INT,
3631 since parse_image_check makes sure they fit into int.
3632 (png_load, gif_load, svg_load_image):
3633 Prefer int to unsigned where either will do.
3634 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3635 old tiff_error_handler and tiff_warning_handler.
3636 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3637 stack buffer overflows. It uses only the features of vsnprintf
3638 that are common to both POSIX and native Microsoft.
3639 (tiff_error_handler, tiff_warning_handler): Use it.
3640 (tiff_load, gif_load, imagemagick_load_image):
3641 Don't assume :index value fits in 'int'.
3642 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3643 (imagemagick_load_image): Check that crop parameters fit into
3644 the integer types that MagickCropImage accepts. Don't assume
3645 Vimagemagick_render_type has a nonnegative value. Don't assume
3646 size_t fits in 'long'.
3647 (gs_load): Use printmax_t to print the widest integers possible.
3648 Check for integer overflow when computing image height and width.
3649
c11821d4
EZ
36502011-08-26 Eli Zaretskii <eliz@gnu.org>
3651
3652 * xdisp.c (redisplay_window): Don't force window start if point
3653 will be invisible in the resulting window. (Bug#9324)
3654
0c95fcf7
EZ
36552011-08-25 Eli Zaretskii <eliz@gnu.org>
3656
3657 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3658 the display spec is of the form `(space ...)'.
3659 (handle_display_spec): Return the value returned by
3660 handle_single_display_spec, not just 1 or zero.
3661 (handle_single_display_spec): If the display spec is of the form
3662 `(space ...)', and specifies display in the text area, return 2
3663 rather than 1.
fee65a97 3664 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3665 accurately, and prefer exact match for point under bidi.
3666 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3667
3668 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3669 into disp_prop; all users changed.
3670
3671 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3672 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3673 for the text covered by the display property.
3674
e4ed06f1
CY
36752011-08-25 Chong Yidong <cyd@stupidchicken.com>
3676
3677 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3678 Change return value to nil.
3679 (Frecord_buffer): Delete unused function.
3680
f67cdd7f
EZ
36812011-08-24 Eli Zaretskii <eliz@gnu.org>
3682
5980d4c6
EZ
3683 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3684 buffers, return left-to-right.
8610fe8b
EZ
3685 (set_cursor_from_row): Consider candidate row a win if its glyph
3686 represents a newline and point is on that newline. Fixes cursor
3687 positioning on the newline at EOL of R2L text within L2R
3688 paragraph, and vice versa.
3689 (try_cursor_movement): Check continued rows, in addition to
3690 continuation rows. Fixes unwarranted scroll when point enters a
3691 continued line of R2L text within an L2R paragraph, or vice versa.
3692 (cursor_row_p): Consider the case of point being equal to
3693 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3694 from the end of a short line to the beginning of a continued line
3695 of R2L text within L2R paragraph.
3696 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3697 composed characters.
5980d4c6 3698
f67cdd7f
EZ
3699 * bidi.c (bidi_check_type): Use xassert.
3700 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3701 members.
3702
bca633fb
EZ
37032011-08-23 Eli Zaretskii <eliz@gnu.org>
3704
3705 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3706 a character.
3707
4a5885a7
CY
37082011-08-23 Chong Yidong <cyd@stupidchicken.com>
3709
3710 * nsfont.m (ns_otf_to_script): Fix typo.
3711
0902a04e
KH
37122011-08-22 Kenichi Handa <handa@m17n.org>
3713
3714 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3715 extra slot even if the purpose is char-code-property-table.
3716
1a2e6670
EZ
37172011-08-23 Eli Zaretskii <eliz@gnu.org>
3718
8ddde651
EZ
3719 * xdisp.c (redisplay_window): When computing centering_position,
3720 account for the height of the header line. (Bug#8874)
3721
425cc014
EZ
3722 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3723 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3724 candidate is selected by the mouse, and that candidate has a
3725 composed character under the mouse.
3726
1a2e6670
EZ
3727 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3728 coordinates reported by pos-visible-in-window-p for a composed
3729 character in column zero.
3730
8b76d6f8
SM
37312011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3732
3733 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3734
dac347dd
EZ
37352011-08-22 Eli Zaretskii <eliz@gnu.org>
3736
3737 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3738 consider it a hit if to_charpos is anywhere in the range of the
3739 composed buffer positions.
3740
e013fb34
CY
37412011-08-22 Chong Yidong <cyd@stupidchicken.com>
3742
3743 * image.c (gif_load): Don't assume that each subimage has the same
3744 dimensions as the base image. Handle disposal method that is
3745 "undefined" by the gif spec (Bug#9335).
3746
bd1ba3e8
CY
37472011-08-20 Chong Yidong <cyd@stupidchicken.com>
3748
3749 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3750 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3751
54a1215b
EZ
37522011-08-19 Eli Zaretskii <eliz@gnu.org>
3753
823564e5
EZ
3754 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3755 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3756 from an Org mode buffer to a Speedbar frame.
3757
54a1215b
EZ
3758 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3759 a composition, take its buffer position from IT->cmp_it.charpos.
3760 Fixes cursor positioning at the beginning of a line that begins
3761 with a composed character.
3762
9778ebcc
EZ
37632011-08-18 Eli Zaretskii <eliz@gnu.org>
3764
0be6ee06
EZ
3765 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3766 character bidirectional type, use STRONG_L instead. Fixes crashes
3767 in a buffer produced by `describe-categories'.
3768
9778ebcc
EZ
3769 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3770 members before the level stack, so they would be saved and
3771 restored when copying iterator state. Fixes incorrect reordering
3772 around TABs covered by display properties.
3773
156bffbe
AS
37742011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3775
6b02f655 3776 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3777
72ad093b
CY
37782011-08-17 Chong Yidong <cyd@stupidchicken.com>
3779
3780 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3781 (internal_condition_case_2, internal_condition_case_n):
3782 Remove unnecessary aborts (Bug#9081).
72ad093b 3783
35774242
EZ
37842011-08-17 Eli Zaretskii <eliz@gnu.org>
3785
3786 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3787 has no `load' handler, try opening the file locally. (Bug#9311)
3788
db76dd85
KB
37892011-08-16 Ken Brown <kbrown@cornell.edu>
3790
3791 * gmalloc.c: Expand comment.
3792
b215eee5
EZ
37932011-08-16 Eli Zaretskii <eliz@gnu.org>
3794
3795 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3796 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3797
a4579d33
KB
37982011-08-16 Ken Brown <kbrown@cornell.edu>
3799
3800 Fix memory allocation problems in Cygwin build (Bug#9273).
3801
3802 * unexcw.c ( __malloc_initialized): Declare external variable.
3803 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3804
8b76d6f8
SM
3805 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3806 New variables.
a4579d33
KB
3807 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3808 dumped emacs.
3809 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3810 in the static heap.
3811 [CYGWIN] (special_realloc): New function.
3812 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3813 requests to realloc storage in the static heap.
3814
3ebec551
PE
38152011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3816
3817 * bidi.c (bidi_initialize): Remove unused local.
3818
9fd8be00
EZ
38192011-08-15 Eli Zaretskii <eliz@gnu.org>
3820
6b02f655
SM
3821 * bidimirror.h:
3822 * biditype.h: Remove file.
3823 * makefile.w32-in ($(BLD)/bidi.$(O)):
3824 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3825
3826 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3827
3828 * chartab.c: Improve commentary for the uniprop_table API.
3829
32413314
EZ
3830 * bidi.c (bidi_paragraph_init): Support zero value of
3831 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3832 (bidi_initialize): Use uniprop_table instead of including
3833 biditype.h and bidimirror.h.
32413314 3834
9fd8be00
EZ
3835 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3836 coordinates of the iterator when restoring from ppos_it.
3837 (Bug#9296)
3838
5cf2b69b
KH
38392011-08-14 Kenichi Handa <handa@m17n.org>
3840
3841 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3842 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3843
daf17d00
EZ
38442011-08-14 Eli Zaretskii <eliz@gnu.org>
3845
3846 * xdisp.c (move_it_in_display_line_to): Don't invoke
3847 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3848 ppos_it. Fixes vertical cursor motion when line beginning is
3849 covered by an image. (Bug#9296)
3850
08e3161a
JD
38512011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3852
3853 * nsterm.h (ns_run_ascript): Declare.
3854 (NSAPP_DATA2_RUNASSCRIPT): Define.
3855
3856 * nsfns.m (as_script, as_result, as_status): New static variables.
3857 (ns_run_ascript): New function.
5e617bc2 3858 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3859 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3860 the event loop. Get status from as_status (Bug#7276).
3861
3862 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3863 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3864 the event loop (Bug#7276).
3865
a3720aa2
AS
38662011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3867
3868 * gnutls.c (QCgnutls_bootprop_priority)
3869 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3870 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3871 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3872 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3873 (QCgnutls_bootprop_verify_hostname_error)
3874 (QCgnutls_bootprop_callbacks_verify): Rename from
3875 Qgnutls_bootprop_..., all uses changed.
3876
3877 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3878 uses changed.
3879
0a0d27fb
PE
38802011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3881
19d5c50c
PE
3882 * xfaces.c (Qframe_set_background_mode): Now static.
3883 * dispextern.h (Qframe_set_background_mode): Remove decl.
3884
0a0d27fb
PE
3885 * process.c (Fnetwork_interface_info): Declare local only if needed.
3886
377538cb
JD
38872011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3888
3889 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3890 (Fnetwork_interface_list): Allocate in increments of bytes instead
3891 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3892 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3893 sockaddr.
3894 (struct ifflag_def): notrailers is smart on OSX.
3895 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3896 Get hardware address with getifaddrs if available.
3897
08fff70c
EZ
38982011-08-12 Eli Zaretskii <eliz@gnu.org>
3899
3900 * xdisp.c (iterate_out_of_display_property): xassert that
3901 IT->position is set to within IT->object's boundaries. Break from
3902 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3903 when IT->position is set up wrongly due to some bug.
3904 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3905 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3906 entry. Force push_it to save on the stack the current
3907 buffer/string position, to be restored by pop_it. Fix flags in
3908 the iterator structure wrt the object coming from a display
3909 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3910 properties. (Bug#9284)
3911
7be1c708 39122011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3913
7be1c708
CY
3914 * fontset.c (fontset_get_font_group): Add proper type checks.
3915 (Bug#9172)
aac0c6e3 3916
7be1c708 39172011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3918
7be1c708
CY
3919 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3920 and LC_VERSION_MIN_MACOSX.
3921 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3922 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3923
97bb72a6
EZ
39242011-08-08 Eli Zaretskii <eliz@gnu.org>
3925
3926 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3927 no-display-properties-and-no-overlays under bidi display.
3928 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3929 properties and overlays.
97bb72a6 3930
d5617611
CY
39312011-08-08 Chong Yidong <cyd@stupidchicken.com>
3932
37e11a63
CY
3933 * editfns.c (Fset_time_zone_rule): Document relationship with the
3934 setenv function.
3935
d5617611
CY
3936 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3937 the font entity extracted from the cache (Bug#8109).
3938
58872834
CY
39392011-08-07 Chong Yidong <cyd@stupidchicken.com>
3940
3941 * composite.c (autocmp_chars): Don't reset point. That is done by
3942 restore_point_unwind (Bug#5984).
3943
75bfc667
JL
39442011-08-07 Juri Linkov <juri@jurta.org>
3945
3946 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3947 to show the arg `TIME' instead of `TIMEVAL'.
3948
d1410150
EZ
39492011-08-06 Eli Zaretskii <eliz@gnu.org>
3950
3951 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3952 display property strides EOL and includes a newline, as in
3953 longlines-mode. (Bug#9254)
75b771e4
EZ
3954 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3955 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3956
3957 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3958 is non-zero, even if the data buffer is NULL. Fixes a crash in
3959 vertical-motion with longlines-mode. (Bug#9254)
3960
35928349
EZ
39612011-08-05 Eli Zaretskii <eliz@gnu.org>
3962
ec7cc85b
EZ
3963 * bidi.c <bidi_cache_total_alloc>: Now static.
3964 (bidi_initialize): Initialize bidi_cache_total_alloc.
3965
8b76d6f8 3966 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3967 cache. (Bug#9221)
3968
3969 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3970 amount allocated this far in `bidi_cache_total_alloc'.
3971 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3972 non-zero, only free the data buffer without restoring the cache
3973 contents. All callers changed.
3974
3975 * dispextern.h (bidi_unshelve_cache): Update prototype.
3976
3977 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3978 (move_it_in_display_line, move_it_to)
3979 (move_it_vertically_backward, move_it_by_lines): Replace the call
3980 to xfree to an equivalent call to bidi_unshelve_cache.
3981 (move_it_in_display_line_to): Fix logic of returning
412b6358 3982 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3983
e2e2423b
EZ
39842011-08-05 Eli Zaretskii <eliz@gnu.org>
3985
3986 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3987 came from a string character with a `cursor' property. (Bug#9229)
3988
ae9e757a
JD
39892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3990
3991 * Makefile.in (LIB_PTHREAD): New variable.
3992 (LIBES): Add LIB_PTHREAD (Bug#9216).
3993
3994 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3995 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3996
213bd7f2
AS
39972011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3998
6b02f655 3999 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 4000
99aaf75f
JD
40012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4002
4003 * xterm.c (x_find_topmost_parent): New function.
4004 (x_set_frame_alpha): Find topmost parent window with
4005 x_find_topmost_parent and set the property there also (bug#9181).
4006 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4007
c74e9d86
PE
40082011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4009
4010 * callproc.c (Fcall_process): Avoid vfork clobbering
4011 the local vars buffer, coding_systems, current_dir.
4012
640c8776
SM
40132011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4014
4015 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4016
f26d0e4c
PE
40172011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4018
8a10d76c
PE
4019 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4020 so that it is not optimized away.
4021
f26d0e4c
PE
4022 * xdisp.c (compute_display_string_pos): Remove unused local.
4023
55439c61
EZ
40242011-08-02 Eli Zaretskii <eliz@gnu.org>
4025
4026 Fix slow cursor motion and scrolling in large buffers with
4027 selective display, like Org Mode buffers. (Bug#9218)
4028
4029 * dispextern.h (struct bidi_it): New member disp_prop_p.
4030
4031 * xdisp.c: Remove one-slot cache of display string positions.
4032 (compute_display_string_pos): Accept an additional argument
5e617bc2 4033 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
4034 for a display string or property. If found, set DISP_PROP_P
4035 non-zero.
4036
4037 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
4038 DISP_PROP_P, and pass it to compute_display_string_pos.
4039 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
4040 non-zero. All callers of bidi_fetch_char changed.
4041
fb33fa43
SM
40422011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4043
4044 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4045
b099e063
DM
40462010-12-03 Don March <don@ohspite.net>
4047
4048 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4049 last character M-[char] is translated to ESC [char] (bug#7541).
4050
5cc7f7af
KH
40512011-08-02 Kenichi Handa <handa@m17n.org>
4052
d0fffa3f 4053 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
4054
4055 * chartab.c (uniprop_table): Make it non-static.
4056
525d5e6e
EZ
40572011-08-01 Eli Zaretskii <eliz@gnu.org>
4058
4059 * xdisp.c (forward_to_next_line_start): Accept additional argument
4060 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4061 on the newline.
4062 (reseat_at_next_visible_line_start): Use the bidi iterator state
4063 returned by forward_to_next_line_start to restore the state of
4064 it->bidi_it after backing up to previous newline. (Bug#9212)
4065
31011111
AS
40662011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4067
4068 * regex.c (re_comp): Protoize.
4069 (re_exec): Fix return type.
4070 (regexec): Fix type of `ret'. (Bug#9203)
4071
476371c4
PE
40722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4073
e5d76069
PE
4074 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4075 This is needed if max-image-size is a floating-point number.
4076
9a79b20c
AS
40772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4078
4079 * print.c (print_object): Print empty symbol as ##.
4080
4081 * lread.c (read1): Read ## as empty symbol.
4082
d8c2fa78
AA
40832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4084
4085 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4086 setting frame foreground color (Bug#9175).
4087 (x_set_background_color): Likewise.
4088
ffe57a7a
AA
4089 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4090 contents (Bug#9176).
4091 (EmacsTooltip -init): Remove bezels and add shadows to
4092 tooltip windows.
4093
bf3492a5
AA
4094 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4095 or scroll bar (Bug#8470).
4096
d55e9c53
AA
4097 * nsfont.m (nsfont_open): Remove assignment to voffset and
4098 unnecessary vars hshink, expand, hd, full_height, min_height.
4099 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4100
4101 * nsterm.h (nsfont_info): Remove voffset field.
4102
d8c2fa78 41032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
4104
4105 Implement strike-through and overline on NextStep (Bug#8863).
4106
4107 * nsfont.m (nsfont_open): Use underline position provided by font,
4108 instead of hard-coded value of 2.
4109 (nsfont_draw): Call ns_draw_text_decoration instead.
4110
4111 * nsterm.h: Add declaration for ns_draw_text_decoration.
4112
4113 * nsterm.m (ns_draw_text_decoration): New function for drawing
4114 underline, overline, and strike-through.
4115 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4116 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 4117 accommodate underlining, etc.
4843aac3 4118
4cc60b9b
EZ
41192011-07-28 Eli Zaretskii <eliz@gnu.org>
4120
bc7ece87
EZ
4121 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4122 default.
4cc60b9b 4123
476371c4
PE
41242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4125
66606eea
PE
4126 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4127 Without this fix, if a signal arrives just after memory fills up,
4128 'malloc' might be invoked reentrantly.
4129
476371c4
PE
4130 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4131 In other words, assume that every image size is allowed, on non-X
4132 hosts. This assumption is probably wrong, but it lets Emacs compile.
4133
f3fcc40d
AS
41342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4135
4136 * regex.c (re_iswctype): Convert return values to boolean.
4137
350c992f
EZ
41382011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4139
4140 * xdisp.c (compute_display_string_pos): Don't use cached display
4141 string position if the buffer had its restriction changed.
4142 (Bug#9184)
4143
5266b4bb
PE
41442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4147
2573a837 41482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 4149
41f55ccd 4150 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4151
39e378da
PE
4152 * bidi.c: Integer size and overflow fixes.
4153 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4154 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4155 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4156 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4157 (bidi_find_other_level_edge):
4158 Use ptrdiff_t instead of EMACS_INT where either will do.
4159 This works better on 32-bit hosts configured --with-wide-int.
4160 (bidi_cache_ensure_space): Check for size-calculation overflow.
4161 Use % rather than repeated addition, for better worst-case speed.
4162 Don't set bidi_cache_size until after xrealloc returns, because it
4163 might not return.
4164 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
4165 (bidi_cache_ensure_space): Also check that the bidi cache size
4166 does not exceed that of the largest Lisp string or buffer. See Eli
4167 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 4168
5e927815
PE
4169 * alloc.c (__malloc_size_t): Remove.
4170 All uses replaced by size_t. See Andreas Schwab's note
4171 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4172
ca4aa935
PE
4173 * image.c: Improve checking for integer overflow.
4174 (check_image_size): Assume that f is nonnull, since
4175 it is always nonnull in practice. This is one less thing to
4176 worry about when checking for integer overflow later.
4177 (x_check_image_size): New function, which checks for integer
4178 overflow issues inside X.
4179 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4180 This removes the need for a memory_full check.
4181 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4182 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4183 (xbm_read_bitmap_data): Change locals back to 'int', since
4184 their values must fit in 'int'.
4185 (xpm_load_image, png_load, tiff_load):
4186 Invoke x_create_x_image_and_pixmap earlier,
4187 to avoid much needless work if the image is too large.
4188 (tiff_load): Treat overly large images as if
4189 x_create_x_image_and_pixmap failed, not as malloc failures.
4190 (gs_load): Use x_check_image_size.
4191
5f8f9cc2
PE
4192 * gtkutil.c: Omit integer casts.
4193 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4194 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4195
5adf60bc
PE
4196 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4197
c8907a93
PE
4198 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4199 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4200 would wrongly return t on a 64-bit host.
4201
e3c25c68
PE
4202 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4203 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4204 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4205 and therefore cause GCC to emit a bogus diagnostic in some cases.
4206
3f791afe
PE
4207 * image.c: Integer signedness and overflow and related fixes.
4208 This is not an exhaustive set of fixes, but it's time to
4209 record what I've got.
4210 (lookup_pixel_color, check_image_size): Remove redundant decls.
4211 (check_image_size): Don't assume that arbitrary EMACS_INT values
4212 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4213 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4214 (tiff_load, imagemagick_load_image):
4215 Check for overflow in size calculations.
4216 (x_create_x_image_and_pixmap): Remove unnecessary test for
4217 xmalloc returning NULL; that can't happen.
4218 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4219 (xpm_color_bucket): Use better integer hashing function.
4220 (xpm_cache_color): Don't possibly over-allocate memory.
4221 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4222 (gif_memory_source):
4223 Use ptrdiff_t, not int or size_t, to record sizes.
4224 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4225 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4226 either works, as we prefer signed integers.
4227 (tiff_read_from_memory, tiff_write_from_memory):
4228 Return tsize_t, not size_t, since that's what the TIFF API wants.
4229 (tiff_read_from_memory): Don't fail simply because the read would
4230 go past EOF; instead, return a short read.
4231 (tiff_load): Omit no-longer-needed casts.
4232 (Fimagemagick_types): Don't assume size fits into 'int'.
4233
3cc5a532
PE
4234 Improve hashing quality when configured --with-wide-int.
4235 * fns.c (hash_string): New function, taken from sxhash_string.
4236 Do not discard information about ASCII character case; this
4237 discarding is no longer needed.
4238 (sxhash-string): Use it. Change sig to match it. Caller changed.
4239 * lisp.h: Declare it.
4240 * lread.c (hash_string): Remove, since we now use fns.c's version.
4241 The fns.c version returns a wider integer if --with-wide-int is
4242 specified, so this should help the quality of the hashing a bit.
4243
b312a492
PE
4244 * emacs.c: Integer overflow minor fix.
4245 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4246 Define only if GNU_LINUX.
4247 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4248
dfd153ae
PE
4249 * dispnew.c: Integer signedness and overflow fixes.
4250 Remove unnecessary forward decls, that were a maintenance hassle.
4251 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4252 All uses changed.
4253 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4254 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4255 (prepare_desired_row, line_draw_cost):
4256 Use int, not unsigned, where either works.
4257 (save_current_matrix, restore_current_matrix):
4258 Use ptrdiff_t, not size_t, where either works.
4259 (init_display): Check for overflow more accurately, and without
4260 relying on undefined behavior.
4261
a81d11a3
PE
4262 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4263 Remove, replacing with the new symbols in lisp.h. All uses changed.
4264 * fileio.c (make_temp_name):
4265 * filelock.c (lock_file_1, lock_file):
4266 * xdisp.c (message_dolog):
4267 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4268 Use pMd etc. instead.
4269 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4270 replacing the pWIDE etc. symbols removed from editfns.c.
4271
3300e6fd
PE
4272 * keyboard.h (num_input_events): Now uintmax_t.
4273 This is (very slightly) less likely to mess up due to wraparound.
4274 All uses changed.
4275
fd05c7e9
PE
4276 * buffer.c: Integer signedness fixes.
4277 (alloc_buffer_text, enlarge_buffer_text):
4278 Use ptrdiff_t rather than size_t when either will do, as we prefer
4279 signed integers.
4280
903fe15d
PE
4281 * alloc.c: Integer signedness and overflow fixes.
4282 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4283 (__malloc_size_t): Default to size_t, not to int.
4284 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4285 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4286 Prefer ptrdiff_t to size_t when either would do, as we prefer
4287 signed integers.
4288 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4289 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4290 Now const. Initialize with values that are in range even if char
4291 is signed.
4292 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4293 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4294 These functions do the right thing with sizes > 2**32.
4295 (check_depth): Now ptrdiff_t, not int.
4296 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4297 Adjust to new way of storing sizes. Check for size overflow bugs
4298 in rest of code.
4299 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4300 slightly wrong anyway, as it missed one instance of
4301 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4302 (refill_memory_reserve): Omit needless cast to size_t.
4303 (mark_object_loop_halt): Mark as externally visible.
4304
ac82cc6a
PE
4305 * xselect.c: Integer signedness and overflow fixes.
4306 (Fx_register_dnd_atom, x_handle_dnd_message):
4307 Use ptrdiff_t, not size_t, since we prefer signed.
4308 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4309 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4310 x_dnd_atoms_size and x_dnd_atoms_length.
4311
c2d1e36d
PE
4312 * doprnt.c: Prefer signed to unsigned when either works.
4313 * eval.c (verror):
4314 * doprnt.c (doprnt):
4315 * lisp.h (doprnt):
4316 * xdisp.c (vmessage):
4317 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4318 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4319 prefer signed arithmetic to avoid comparison confusion.
4320 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4321 but is a bit tricky.
4322
0e926e56
PE
4323 Assume freestanding C89 headers, string.h, stdlib.h.
4324 * data.c, doprnt.c, floatfns.c, print.c:
4325 Include float.h unconditionally.
4326 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4327 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4328 * regex.c: Likewise for stddef.h, string.h.
4329 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4330 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4331 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4332 (STDC_HEADERS): Remove obsolete defines.
4333 * sysdep.c: Include limits.h unconditionally.
4334
9cfdb3ec
PE
4335 Assume support for memcmp, memcpy, memmove, memset.
4336 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4337 * regex.c (memcmp, memcpy):
4338 Remove; we assume C89 now.
4339
4340 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4341 (__malloc_safe_bcopy): Remove; no longer needed.
4342
cf950e6b 4343 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
4344 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4345 well either way, and we prefer signed to unsigned.
4346
dbf38e02
LMI
43472011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4348
4349 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4350 closes the connection while we're reading (bug#9182).
4351
d6f0886c 43522011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 4353
d6f0886c
JD
4354 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4355 are specified (Bug#9168).
24e0f6b1 4356
2eb1f9e6
PE
43572011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4358
4359 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4360 Found by GCC static checking and --with-wide-int on a 32-bit host.
4361
22381272 43622011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
4363
4364 * xdisp.c (compute_display_string_pos): Fix logic of caching
4365 previous display string position. Initialize cached_prev_pos to
4366 -1. Fixes slow-down at the beginning of a buffer.
4367
f25e39b4
EZ
43682011-07-24 Eli Zaretskii <eliz@gnu.org>
4369
4370 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4371 for attrs[LFACE_FONTSET_INDEX].
4372
04c4b52e
PE
43732011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4374
4375 * xml.c (parse_region): Remove unused local
4376 that was recently introduced.
4377
c1734fbd
EZ
43782011-07-23 Eli Zaretskii <eliz@gnu.org>
4379
be18c5a5
EZ
4380 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4381 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4382
c1734fbd
EZ
4383 * xdisp.c (move_it_in_display_line_to): Record the best matching
4384 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
4385 exit if none of the characters scanned was an exact match.
4386 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
4387 when exact match is impossible due to invisible text, and the
4388 lines are truncated.
4389
a258d627
JD
43902011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4391
4392 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4393 for OSX >= 10.7.
4394
b6d5a689
EZ
43952011-07-22 Eli Zaretskii <eliz@gnu.org>
4396
0f74f785
EZ
4397 Fix a significant slow-down of cursor motion with C-n, C-p,
4398 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4399 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 4400 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
4401 (next_element_from_buffer): Call compute_stop_pos_backwards to
4402 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
4403 base_level_stop.
4404 (reseat): Don't look for prev_stop, as that could mean a very long
4405 run.
4406 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4407 <cached_disp_overlay_modiff>: Cache for last found display string
4408 position.
551918c1 4409 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
4410 about the same buffer in the same area of character positions, and
4411 the buffer wasn't changed since the time the display string
4412 position was cached.
551918c1 4413
b2d0c91a
EZ
44142011-07-22 Eli Zaretskii <eliz@gnu.org>
4415
4416 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4417 is an integer, which is important for empty lines. (Bug#9149)
4418
043604ee
CY
44192011-07-22 Chong Yidong <cyd@stupidchicken.com>
4420
4421 * frame.c (Fmodify_frame_parameters): In tty case, update the
4422 default face if necessary (Bug#4238).
4423
da4adb04
CY
44242011-07-21 Chong Yidong <cyd@stupidchicken.com>
4425
4426 * editfns.c (Fstring_to_char): No need to explain what a character
4427 is in the docstring (Bug#6576).
4428
9abd0532
LMI
44292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4430
4431 * xml.c (parse_region): Make sure we always return a tree.
4432
36881d16
HK
44332011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4434
4435 * xml.c (parse_region): If a document contains only comments,
4436 return that, too.
4437
1e98674d
LMI
44382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4439
4440 * xml.c (make_dom): Return comments, too.
4441
590bd467
PE
44422011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4443
4444 Port to OpenBSD.
4445 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4446 and the surrounding thread.
4447 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4448 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4449 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4450 timer goes off.
4451 * s/openbsd.h (BROKEN_SIGIO): Define.
4452 * unexelf.c (unexec) [__OpenBSD__]:
4453 Don't update the .mdebug section of the Alpha COFF symbol table.
4454
f41628b2
LMI
44552011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4456
4457 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4458 (bug#8460).
4459
b59b67c5
PE
44602011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4461
15e3a074
PE
4462 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4463 This fixes some race conditions on the permissions of any newly
4464 created file.
4465
41bed37d
PE
4466 * alloc.c (valid_pointer_p): Use pipe, not open.
4467 This fixes some permissions issues when debugging.
4468
b59b67c5
PE
4469 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4470 If fchown fails to set both uid and gid, try to set just gid,
4471 as that is sometimes allowed. Adjust the file's mode to eliminate
4472 setuid or setgid bits that are inappropriate if fchown fails.
4473
925a6be7
SM
44742011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4475
4476 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4477 to compare Lisp_Objects.
4478 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4479 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4480 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4481
52968808
AS
44822011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4483
0a6a104b
AS
4484 * lread.c (read_integer): Unread even EOF character.
4485 (read1): Likewise. Properly record start position of symbol.
4486
52968808
AS
4487 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4488 symbol character follows.
4489
9e381cdd
PE
44902011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4491
4492 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4493 This works around a problem with the previous change to Fcopy_file.
4494 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4495 and without this change, GCC might complain about discarding
4496 fchown's return value.
4497
b5641435
JB
44982011-07-16 Juanma Barranquero <lekktu@gmail.com>
4499
4500 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4501
a8031457
PE
45022011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4503
4504 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4505
dd889327
LMI
45062011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4507
750c33f7
LMI
4508 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4509 it's used from the C level.
4510
dd889327
LMI
4511 * process.c: Use the same condition for POLL_FOR_INPUT in both
4512 keyboard.c and process.c (bug#1858).
4513
87e86684
LM
45142011-07-09 Lawrence Mitchell <wence@gmx.li>
4515
4516 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4517 (Fgnutls_boot): Use it.
4518
64348f40
AS
45192011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4520
4521 * doc.c (Fsubstitute_command_keys): Revert last change.
4522
1d698799
LMI
45232011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4524
f863868c
LMI
4525 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4526 quotes the next character, and doesn't affect other longer
4527 sequences (bug#8935).
4528
1d698799
LMI
4529 * lread.c (syms_of_lread): Clarify that is isn't only
4530 `eval-buffer' and `eval-defun' that's affected by
4531 `lexical-binding' (bug#8460).
4532
aa4b6df6
EZ
45332011-07-15 Eli Zaretskii <eliz@gnu.org>
4534
4535 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4536 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4537
5d856da6
PE
45382011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4539
ad6042bb
PE
4540 Fix minor problems found by static checking.
4541 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4542 (elsz): Now a signed constant, not a size_t var. We prefer signed
4543 types to unsigned, to avoid integer comparison confusion. Without
4544 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4545 "cannot optimize loop, the loop counter may overflow", a symptom
4546 of the confusion.
f00bbb22 4547 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4548 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4549
6468f31c
LMI
45502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4551
49080b10
LMI
4552 * search.c (Fre_search_backward): Mention `case-fold-search' in
4553 all the re_search_* functions (bug#8138).
4554
6468f31c
LMI
4555 * keyboard.c (Fopen_dribble_file): Document when the file is
4556 closed (bug#8056).
4557
c965adc5
EZ
45582011-07-14 Eli Zaretskii <eliz@gnu.org>
4559
df9733bf
EZ
4560 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4561 bidi_cache_idx.
4562
0bb23927
EZ
4563 Support bidi reordering of display and overlay strings.
4564 * xdisp.c (compute_display_string_pos)
4565 (compute_display_string_end): Accept additional argument STRING.
4566 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4567 (reseat_to_string): Initialize bidi_it->string.s and
4568 bidi_it->string.schars.
4569 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4570 NULL (avoids a crash in bidi_paragraph_init).
4571 Initialize itb.string.lstring.
0bb23927
EZ
4572 (init_iterator): Call bidi_init_it only of a valid
4573 buffer position was specified. Initialize paragraph_embedding to
4574 L2R.
4575 (reseat_to_string): Initialize the bidi iterator.
4576 (display_string): If we need to ignore text properties of
4577 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4578 original value of -1 will not work with bidi.)
4579 (compute_display_string_pos): First arg is now struct
4580 `text_pos *'; all callers changed. Support display properties on
4581 Lisp strings.
4582 (compute_display_string_end): Support display properties on Lisp
4583 strings.
4584 (init_iterator, reseat_1, reseat_to_string): Initialize the
4585 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4586 when iterating on a string not from display properties).
640c8776
SM
4587 (compute_display_string_pos, compute_display_string_end):
4588 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4589 arrow keys.
4590 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4591 base_level_stop; instead, set base_level_stop to BEGV.
4592 Fixes crashes in vertical-motion.
0bb23927
EZ
4593 (next_element_from_buffer): Improve commentary for when
4594 the iterator is before prev_stop.
4595 (init_iterator): Initialize bidi_p from the default value of
4596 bidi-display-reordering, not from buffer-local value. Use the
4597 buffer-local value only if initializing for buffer iteration.
4598 (handle_invisible_prop): Support invisible properties on strings
4599 that are being bidi-reordered.
4600 (set_iterator_to_next): Support bidi reordering of C strings and
4601 Lisp strings.
4602 (next_element_from_string): Support bidi reordering of Lisp
4603 strings.
4604 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4605 (display_string): Support display of R2L glyph rows.
4606 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4607 (init_iterator): Don't initialize it->bidi_p for strings
4608 here.
4609 (reseat_to_string): Initialize it->bidi_p for strings here.
4610 (next_element_from_string, next_element_from_c_string)
4611 (next_element_from_buffer): Add xassert's for correspondence
4612 between IT's object being iterated and it->bidi_it.string
4613 structure.
4614 (face_before_or_after_it_pos): Support bidi iteration.
4615 (next_element_from_c_string): Handle the case of the first string
4616 character that is not the first one in the visual order.
4617 (get_visually_first_element): New function, refactored from common
4618 parts of next_element_from_buffer, next_element_from_string, and
4619 next_element_from_c_string.
4620 (tool_bar_lines_needed, redisplay_tool_bar)
4621 (display_menu_bar): Force left-to-right direction. Add a FIXME
4622 comment for making that be controlled by a user option.
4623 (push_it, pop_it): Save and restore the state of the
4624 bidi iterator. Save and restore the bidi_p flag.
4625 (pop_it): Iterate out of display property for string iteration as
4626 well.
4627 (iterate_out_of_display_property): Support iteration over strings.
4628 (handle_single_display_spec): Set up it->bidi_it for iteration
4629 over a display string, and call bidi_init_it.
4630 (handle_single_display_spec, next_overlay_string)
4631 (get_overlay_strings_1, push_display_prop): Set up the bidi
4632 iterator for displaying display or overlay strings.
4633 (forward_to_next_line_start): Don't use the shortcut if
4634 bidi-iterating.
4635 (back_to_previous_visible_line_start): If handle_display_prop
4636 pushed the iterator stack, restore the internal state of the bidi
4637 iterator by calling bidi_pop_it same number of times.
4638 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4639 and we are bidi-iterating, don't decrement the iterator position;
4640 instead, set the first_elt flag in the bidi iterator, to produce
4641 the same effect.
4642 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4643 (push_display_prop): xassert that we are iterating a buffer.
4644 (push_it, pop_it): Save and restore paragraph_embedding member.
4645 (handle_single_display_spec, next_overlay_string)
4646 (get_overlay_strings_1, reseat_1, reseat_to_string)
4647 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4648 correctly. Don't assume unibyte strings are not bidi-reordered.
4649 (compute_display_string_pos)
4650 (compute_display_string_end): Fix handling the case of C string.
4651 (push_it, pop_it): Save and restore from_disp_prop_p.
4652 (handle_single_display_spec, push_display_prop): Set the
4653 from_disp_prop_p flag.
4654 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4655 (pop_it): Call iterate_out_of_display_property only if we are
4656 popping after iteration over a string that came from a display
4657 property. Fix a typo in popping stretch info. Add an assertion
4658 for verifying that the iterator position is in sync with the bidi
4659 iterator.
4660 (handle_single_display_spec, get_overlay_strings_1)
4661 (push_display_prop): Fix initialization of paragraph direction for
4662 string when that of the parent object is not yet determined.
4663 (reseat_1): Call bidi_init_it to resync the bidi
4664 iterator with IT's position. (Bug#7616)
4665 (find_row_edges): If ROW->start.pos gives position
4666 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4667 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4668 Reset the from_disp_prop_p flag.
4669 (SAVE_IT, RESTORE_IT): New macros.
4670 (pos_visible_p, face_before_or_after_it_pos)
4671 (back_to_previous_visible_line_start)
4672 (move_it_in_display_line_to, move_it_in_display_line)
4673 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4674 (try_scrolling, redisplay_window, display_line): Use them when
4675 saving a temporary copy of the iterator and restoring it back.
4676 (back_to_previous_visible_line_start, reseat_1)
4677 (init_iterator): Empty the bidi cache "stack".
4678 (move_it_in_display_line_to): If iterator ended up at
4679 EOL, but we never saw any buffer positions smaller than
4680 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4681 motion in bidi-reordered lines.
4682 (move_it_in_display_line_to): Record prev_method and prev_pos
4683 immediately before the call to set_iterator_to_next. Fixes cursor
4684 motion in bidi-reordered lines with stretch glyphs and strings
4685 displayed in margins. (Bug#8133) (Bug#8867)
4686 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4687 TO_CHARPOS.
640c8776
SM
4688 (pos_visible_p): Support positions in bidi-reordered lines.
4689 Save and restore bidi cache.
0bb23927
EZ
4690
4691 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4692 (bidi_paragraph_info): Delete unused struct.
4693 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4694 (bidi_cache_start): New variable.
4695 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4696 to zero.
4697 (bidi_cache_fetch_state, bidi_cache_search)
4698 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4699 (bidi_cache_find, bidi_peek_at_next_level)
4700 (bidi_level_of_next_char, bidi_find_other_level_edge)
4701 (bidi_move_to_visually_next): Compare cache index with
4702 bidi_cache_start rather than with zero.
4703 (bidi_fetch_char): Accept new argument STRING; all callers
4704 changed. Support iteration over a string. Support strings with
4705 display properties. Support unibyte strings. Fix the type of
4706 `len' according to what STRING_CHAR_AND_LENGTH expects.
4707 (bidi_paragraph_init, bidi_resolve_explicit_1)
4708 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4709 (bidi_level_of_next_char, bidi_move_to_visually_next):
4710 Support iteration over a string.
0bb23927
EZ
4711 (bidi_set_sor_type, bidi_resolve_explicit_1)
4712 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4713 can now be zero (for strings); special values 0 and -1 were
4714 changed to -1 and -2, respectively.
4715 (bidi_char_at_pos): New function.
4716 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4717 Call it instead of FETCH_MULTIBYTE_CHAR.
4718 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4719 initialized to valid values.
4720 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4721 values.
4722 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4723 the test for valid cached positions. Fix the logic for looking up
4724 the sentinel state in the cache. GCPRO the Lisp string we are
4725 iterating.
4726 (bidi_push_it, bidi_pop_it): New functions.
4727 (bidi_initialize): Initialize the bidi cache start stack pointer.
4728 (bidi_cache_ensure_space): New function, refactored from part of
4729 bidi_cache_iterator_state. Don't assume the required size is just
4730 one BIDI_CACHE_CHUNK away.
4731 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4732 (bidi_count_bytes, bidi_char_at_pos): New functions.
4733 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4734 always valid if bidi_cache_idx is valid.
4735 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4736 is valid if it's going to be used.
4737 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4738 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4739 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4740 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4741 (bidi_find_other_level_edge, bidi_cache_start_stack):
4742 All variables related to cache indices are now EMACS_INT.
c965adc5 4743
0bb23927
EZ
4744 * dispextern.h (struct bidi_string_data): New structure.
4745 (struct bidi_it): New member `string'. Make flag members be 1-bit
4746 fields, and put them last in the struct.
640c8776
SM
4747 (compute_display_string_pos, compute_display_string_end):
4748 Update prototypes.
0bb23927
EZ
4749 (bidi_push_it, bidi_pop_it): Add prototypes.
4750 (struct iterator_stack_entry): New members bidi_p,
4751 paragraph_embedding, and from_disp_prop_p.
4752 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4753 (bidi_shelve_cache, bidi_unshelve_cache):
4754 Declare prototypes.
0bb23927
EZ
4755
4756 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4757 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4758 and vector-like objects.
4759
4760 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4761 cache around display iteration.
4762
4763 * window.c (Fwindow_end, window_scroll_pixel_based)
4764 (displayed_window_lines, Frecenter): Save and restore the bidi
4765 cache around display iteration.
4766
3bbd2265
LMI
47672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4768
4769 * editfns.c (Fdelete_region): Clarify the use of the named
4770 parameters (bug#6788).
4771
adc47434
MR
47722011-07-14 Martin Rudalics <rudalics@gmx.at>
4773
4774 * indent.c (Fvertical_motion): Set and restore w->pointm when
4775 saving and restoring the window's buffer (Bug#9006).
4776
837c31f8
LMI
47772011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4778
4779 * editfns.c (Fstring_to_char): Clarify just what is returned
4780 (bug#6576). Text by Eli Zaretskii.
4781
ac389d0c
JB
47822011-07-13 Juanma Barranquero <lekktu@gmail.com>
4783
4784 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4785
0be0ce47
EZ
47862011-07-13 Eli Zaretskii <eliz@gnu.org>
4787
4788 * buffer.c (mmap_find): Fix a typo.
4789
cd18e7e3
JB
47902011-07-13 Johan Bockgård <bojohan@gnu.org>
4791
4792 Fix execution of x selection hooks.
4793 * xselect.c (Qx_lost_selection_functions)
4794 (Qx_sent_selection_functions): New vars.
4795 (syms_of_xselect): DEFSYM them.
4796 (x_handle_selection_request): Pass Qx_sent_selection_functions
4797 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4798 (x_handle_selection_clear,x_clear_frame_selections):
4799 Pass Qx_lost_selection_functions rather than
4800 Vx_lost_selection_functions to Frun_hook_with_args.
4801
47ea7f44
PE
48022011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4803
ac389d0c 4804 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4805 The old code sometimes used this field without initializing it.
4806
47ea7f44
PE
4807 * alloc.c (gc_sweep): Don't read past end of array.
4808 In theory, the old code could also have corrupted Emacs internals,
4809 though it'd be very unlikely.
4810
bc985c87
AS
48112011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4812
4813 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4814 argument. (Bug#4026)
bc985c87 4815
0cf34688
LMI
48162011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4817
b3dadd76
LMI
4818 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4819 key" (bug#4257).
4820
0cf34688
LMI
4821 * window.c (Fset_window_start): Doc fix (bug#4199).
4822 (Fset_window_hscroll): Ditto.
4823
270768cd
PE
48242011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4825
077e3dda 4826 Fix minor new problems caught by GCC 4.6.1.
270768cd 4827 * term.c (init_tty): Remove unused local.
490011a6 4828 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4829 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4830 not used otherwise.
270768cd 4831
b1f58454
CY
48322011-07-12 Chong Yidong <cyd@stupidchicken.com>
4833
4834 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4835
22b9578d
LMI
48362011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4837
6e70ab07
LMI
4838 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4839 are the mini-buffer and the echo area (bug#3320).
4840
22b9578d
LMI
4841 * term.c (init_tty): Remove support for supdup, c10 and perq
4842 terminals, which are no longer supported (bug#1482).
4843
8974cc9f
JB
48442011-07-10 Johan Bockgård <bojohan@gnu.org>
4845
4846 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4847
a560d974
JD
48482011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4849
4850 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4851 for non-popups (Bug#3642).
4852
1dae0f0a
AS
48532011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4854
268c2c36 4855 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4856 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4857 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4858 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4859 * data.c (fmod): Likewise.
4860 * dispnew.c (swap_glyphs_in_rows): Likewise.
4861 * emacs.c (memory_warning_signal): Likewise.
4862 * floatfns.c (float_error): Likewise.
4863 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4864 (otf_open, font_otf_capability, generate_otf_features)
4865 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4866 Likewise.
4867 * image.c (pbm_read_file): Likewise.
4868 * indent.c (string_display_width): Likewise.
4869 * intervals.c (check_for_interval, search_for_interval)
4870 (inc_interval_count, count_intervals, root_interval)
4871 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4872 * lread.c (defalias): Likewise.
268c2c36 4873 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4874 * regex.c (set_image_of_range_1, set_image_of_range)
4875 (regex_grow_registers): Likewise.
4876 * sysdep.c (strerror): Likewise.
4877 * termcap.c (valid_filename_p, tprint, main): Likewise.
4878 * tparam.c (main): Likewise.
4879 * unexhp9k800.c (run_time_remap, save_data_space)
4880 (update_file_ptrs, read_header, write_header, calculate_checksum)
4881 (copy_file, copy_rest, display_header): Likewise.
4882 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4883 Likewise.
4884 * xdisp.c (check_it): Likewise.
4885 * xfaces.c (register_color, unregister_color, unregister_colors):
4886 Likewise.
4887 * xfns.c (print_fontset_result): Likewise.
4888 * xrdb.c (member, fatal, main): Likewise.
4889
99033785
PE
48902011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4891
4892 Fix minor problems found by static checking (Bug#9031).
4893 * chartab.c (char_table_set_range, map_sub_char_table):
4894 Remove unused locals.
4895 (uniprop_table): Now static.
4896 * composite.c (_work_char): Remove unused static var.
4897
9cb2ac56
JB
48982011-07-09 Juanma Barranquero <lekktu@gmail.com>
4899
4900 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4901
f25661f0
JD
49022011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4903
4904 * gtkutil.c (qttip_cb): Remove code without function.
4905
8278c4fe
EZ
49062011-07-09 Eli Zaretskii <eliz@gnu.org>
4907
4908 * w32.c (pthread_sigmask): New stub.
4909
1692ae2d 49102011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4911
8a6ebd58 4912 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4913 sigprocmask is portable only for single-threaded applications, and
4914 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4915 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4916 (LIBES): Use it.
4917 * callproc.c (Fcall_process):
4918 * process.c (create_process):
4919 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4920 Use pthread_sigmask, not sigprocmask.
123403e4 4921
1b854618
JD
49222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4923
4924 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4925 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4926 wrong (Bug#8591).
4927
3fe4b549
JD
49282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4929
0ce7e563
JD
4930 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4931 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4932 (xg_hide_tooltip): Fix comment.
4933
3fe4b549
JD
4934 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4935 in registerServicesMenuSendTypes.
4936 (validRequestorForSendType): Don't check ns_return_types.
4937
4938 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4939 ns_return_type.
4940
5df75e47
JR
49412011-07-08 Jason Rumney <jasonr@gnu.org>
4942
22610910
JR
4943 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4944 SH_SHOW for hidden windows (Bug#5482).
4945
5df75e47
JR
4946 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4947 frame struct members of non-existent frames (Bug#6284).
4948
699c10bd
JD
49492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4950
4393663b
JD
4951 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4952 variable firstTime not needed on OSX >= 10.6.
4953 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4954 >= 10.5. Use setKnobProportion, setDoubleValue.
4955
4956 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4957 (MAC_OS_X_VERSION_10_5): Define if not defined.
4958 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4959 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4960 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4961
4962 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4963 cString and lossyCString on OSX >= 10.4
4964
58179cce 4965 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4966 sizeToFit on OSX >= 10.2.
4967
4968 * nsimage.m (allocInitFromFile): Don't use deprecated method
4969 bestRepresentationForDevice on OSX >= 10.6.
4970
4971 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4972 to avoid warning.
4973
4974 * emacs.c: Declare unexec_init_emacs_zone.
4975
a63e0781
JD
4976 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4977
699c10bd
JD
4978 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4979
4980 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4981 on svcsMenu (Bug#8842).
4982
4983 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4984 ns_return_types.
4985 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4986
4987 * nsterm.m (QUTF8_STRING): Declare.
4988 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4989 (validRequestorForSendType): Return type is (id).
4990 Change indexOfObjectIdenticalTo to indexOfObject.
4991 Check if we have local selection before returning self (Bug#8842).
4992 (writeSelectionToPasteboard): Put local selection into paste board
4993 if we have a local selection (Bug#8842).
4994 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4995
4996 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4997 (ns_get_local_selection): Declare.
4998
54e10184
LMI
49992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5000
9888ff71
LMI
5001 * keymap.c (describe_map_tree): Don't insert a double newline at
5002 the end of the buffer (bug#1169) and return whether we inserted
5003 something.
5004
54e10184
LMI
5005 * callint.c (Fcall_interactively): Change "reading args" to
5006 "providing args" to try to clarify what it does (bug#1010).
5007
15fa4783
KH
50082011-07-07 Kenichi Handa <handa@m17n.org>
5009
5010 * composite.c (composition_compute_stop_pos): Ignore a static
5011 composition starting before CHARPOS (Bug#8915).
5012
5013 * xdisp.c (handle_composition_prop): Likewise.
5014
a8815b00
EZ
50152011-07-07 Eli Zaretskii <eliz@gnu.org>
5016
5017 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5018 (Bug#9015)
5019
ef7b981d 50202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
5021
5022 * character.h (unicode_category_t): New enum type.
5023
5024 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5025 (Qchar_code_property_table): New variable.
5026 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5027 (UNIPROP_COMPRESSED_FORM_P): New macros.
5028 (char_table_ascii): Uncompress the compressed values.
5029 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5030 Uncompress the compressed values.
ac389d0c 5031 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
5032 (char_table_ref_and_range): Uncompress the compressed values.
5033 (sub_char_table_set): New arg is_uniprop. Callers changed.
5034 Uncompress the compressed values.
5035 (sub_char_table_set_range): Args changed. Callers changed.
5036 (char_table_set_range): Adjuted for the above change.
5037 (map_sub_char_table): Delete args default_val and parent. Add arg
5038 top. Give decoded values to a Lisp function.
640c8776 5039 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
5040 values to a Lisp function. Gcpro more variables.
5041 (uniprop_table_uncompress)
5042 (uniprop_decode_value_run_length): New functions.
5043 (uniprop_decoder, uniprop_decoder_count): New variables.
5044 (uniprop_get_decoder, uniprop_encode_value_character)
5045 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5046 New functions.
5047 (uniprop_encoder, uniprop_encoder_count): New variables.
5048 (uniprop_get_encoder, uniprop_table)
5049 (Funicode_property_table_internal, Fget_unicode_property_internal)
5050 (Fput_unicode_property_internal): New functions.
5051 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5052 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 5053 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
5054 char-code-property-alist.
5055
640c8776 5056 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
5057 Vunicode_category_table.
5058
640c8776 5059 * font.c (font_range): Adjust for the change of
c805dec0
KH
5060 Vunicode_category_table.
5061
76b397fb
DN
50622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5063
5064 * m/iris4d.h: Remove file, move contents ...
5065 * s/irix6-5.h: ... here.
5066
22b4128e
PE
50672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
5070 * alloc.c (mark_buffer):
5071 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5072 (clone_per_buffer_values): Don't assume that
22b4128e
PE
5073 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5074 This isn't true in general, and it's particularly not true
5075 if Emacs is configured with --with-wide-int.
5076 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5077 New macros, used in the buffer.c change.
5078
869795d6
JD
50792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5080
5081 * xsettings.c: Use both GConf and GSettings if both are available.
5082 (store_config_changed_event): Add comment.
5083 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5084 (store_tool_bar_style_changed): New functions.
5e617bc2 5085 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
5086 (struct xsettings): Move font inside HAVE_XFT.
5087 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 5088 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 5089 Move inside HAVE_XFT.
640c8776 5090 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
5091 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5092 also.
5093 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 5094 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 5095 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
5096 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5097 (parse_settings): Move check for font inside HAVE_XFT.
5098 (read_settings, apply_xft_settings): Add comment.
5099 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5100 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5101 call store_font_name_changed.
5102 (xft_settings_event): Add comment.
5103 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5104 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5105 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5106 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5107 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
5108 (xsettings_get_system_font, xsettings_get_system_normal_font):
5109 Add comment.
869795d6 5110
d8ed26bd
PE
51112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5112
5113 Random fixes. E.g., (random) never returned negative values.
5114 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5115 subseconds part to the entropy, as that's a bit more random.
5116 Prefer signed to unsigned, since the signedness doesn't matter and
5117 in general we prefer signed. When given a limit, use a
5118 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5119 latter isn't right if USE_2_TAGS_FOR_INTS.
5120 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5121 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5122
cabf1cac
SM
51232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5124
5125 * textprop.c (text_property_stickiness):
5126 Obey Vtext_property_default_nonsticky.
5127 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5128 * w32fns.c (syms_of_w32fns):
5129 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5130
6e9b2be9
PE
51312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5132
5133 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5134 This is more efficient than Ffile_directory_p and avoids a minor race.
5135
90186c68
LMI
51362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5137
7c301272
LMI
5138 * buffer.c (Foverlay_put): Say what the return value is
5139 (bug#7835).
5140
c4f2d8d4
LMI
5141 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5142 is a directory before asking whether to use the file name
5143 (bug#7564).
ad637907
LMI
5144 (barf_or_query_if_file_exists): Make the "File is a directory"
5145 error be more correct.
c4f2d8d4 5146
90186c68
LMI
5147 * fns.c (Frequire): Remove the mention of the .gz files, since
5148 that's installation-specific, but keep the mention of
5149 `get-load-suffixes'.
5150
da64016e
PE
51512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5152
5153 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5154 Report string overflow if the output is too long.
5155
7d47b580
JB
51562011-07-04 Juanma Barranquero <lekktu@gmail.com>
5157
a555cb87
JB
5158 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5159 (syms_of_gnutls): Remove duplicate DEFSYM for
5160 Qgnutls_bootprop_verify_hostname_error, an error for
5161 Qgnutls_bootprop_verify_error (which is no longer used).
5162
7d47b580
JB
5163 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5164 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5165 Also (re)move comments that are misplaced or no longer relevant.
5166
1e49bfab
LMI
51672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5168
5169 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5170
1485f4c0
CY
51712011-07-03 Chong Yidong <cyd@stupidchicken.com>
5172
5173 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5174 and background color parameters if they have been changed.
5175
a9ab721e
LMI
51762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5177
5178 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5179
cf7cff57
PE
51802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5181
2e13213d
PE
5182 * xsettings.c (SYSTEM_FONT): Define only when used.
5183 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5184
cf7cff57
PE
5185 * keymap.c (access_keymap_1): Now static.
5186
7a8e04f7
CY
51872011-07-02 Chong Yidong <cyd@stupidchicken.com>
5188
5189 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5190 leave any prefix arg for the up event (Bug#1586).
5191
61352f62
LMI
51922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5193
69bb1ef7
LMI
5194 * lread.c (syms_of_lread): Mention single symbols defined by
5195 `defvar' or `defconst' (bug#7154).
5196
61352f62 5197 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 5198 (Frequire): Mention get-load-suffixes.
61352f62 5199
28545e04
MR
52002011-07-02 Martin Rudalics <rudalics@gmx.at>
5201
5202 * window.h (window): Remove clone_number slot.
5203 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5204 Remove.
5205 (make_parent_window, make_window, saved_window)
5206 (Fset_window_configuration, save_window_save): Don't deal with
5207 clone numbers.
5208 * buffer.c (Qclone_number): Remove declaration.
5209 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5210
3349e122
SM
52112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5212
5213 Add multiple inheritance to keymaps.
5214 * keymap.c (Fmake_composed_keymap): New function.
5215 (Fset_keymap_parent): Simplify.
5216 (fix_submap_inheritance): Remove.
5217 (access_keymap_1): New function extracted from access_keymap to handle
5218 embedded parents and handle lists of maps.
5219 (access_keymap): Use it.
5220 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5221 (Fcopy_keymap): Handle embedded parents.
5222 (Fcommand_remapping, define_as_prefix): Simplify.
5223 (Fkey_binding): Simplify.
5224 (syms_of_keymap): Move minibuffer-local-completion-map,
5225 minibuffer-local-filename-completion-map,
5226 minibuffer-local-must-match-map, and
5227 minibuffer-local-filename-must-match-map to Elisp.
5228 (syms_of_keymap): Defsubr make-composed-keymap.
5229 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5230 (parse_menu_item): Trivial simplification.
5231
3279eb87
GM
52322011-07-01 Glenn Morris <rgm@gnu.org>
5233
5234 * Makefile.in (SETTINGS_LIBS): Fix typo.
5235
4550efdf
KI
52362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5237
5238 * coding.c (Fencode_coding_string): Record the last coding system
5239 used, as the function doc string says (bug#8738).
5240
0949d2b6
JD
52412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5242
5243 * xsettings.c (store_monospaced_changed): Take new font as arg and
5244 check for change against current_mono_font.
5245 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5246 (emacs_settings_constructor, emacs_settings_get_property)
5247 (emacs_settings_set_property, emacs_settings_class_init)
5248 (emacs_settings_init, gsettings_obj): Remove.
5249 (something_changedCB): New function for HAVE_GSETTINGS.
5250 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5251 with value as argument.
5252 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5253 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 5254 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
5255 "changed".
5256
5257 * xgselect.c: Add defined (HAVE_GSETTINGS).
5258 (xgselect_initialize): Ditto.
5259
5260 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5261 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5262 xg_select.
5263
bbc6b304
PE
52642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5265
5266 * eval.c (struct backtrace): Simplify and port the data structure.
5267 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5268 signed bit field, as this assumption is not portable and it makes
5269 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5270 "char debug_on_exit : 1" as this is not portable either; instead,
5271 use the portable "unsigned int debug_on_exit : 1". Remove unused
5272 member evalargs. Remove obsolete comments about cc bombing out.
5273
9851bfc5
JD
52742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5275
51bb811f 5276 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
5277 Let HAVE_GSETTINGS override HAVE_GCONF.
5278 (store_monospaced_changed): New function.
5279 (EMACS_SETTINGS): A new type derived from GObject to handle
5280 GSettings notifications.
5281 (emacs_settings_constructor, emacs_settings_get_property)
5282 (emacs_settings_set_property, emacs_settings_class_init):
5283 New functions.
5284 (gsettings_client, gsettings_obj): New variables.
5285 (GSETTINGS_SCHEMA): New define.
5286 (something_changedCB): Call store_monospaced_changed.
5287 (init_gsettings): New function.
5288 (xsettings_initialize): Call init_gsettings.
5289 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5290 to NULL.
5291
640c8776 5292 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
5293 GCONF_CFLAGS/LIBS.
5294
5386012d
MR
52952011-06-29 Martin Rudalics <rudalics@gmx.at>
5296
5297 * window.c (resize_root_window, grow_mini_window)
5298 (shrink_mini_window): Rename Qresize_root_window to
5299 Qwindow_resize_root_window and Qresize_root_window_vertically to
5300 Qwindow_resize_root_window_vertically.
5301
f13e0b08
PE
53022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5303
5304 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5305
94515237
JB
53062011-06-27 Juanma Barranquero <lekktu@gmail.com>
5307
5308 * makefile.w32-in: Redesign dependencies so they reflect more
5309 clearly which files are directly included by each source file,
5310 and not through other includes.
5311
e43b6e43
MR
53122011-06-27 Martin Rudalics <rudalics@gmx.at>
5313
5314 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5315 (sort_overlays, overlay_strings): When an overlay's clone number
5316 matches the window's clone number process the overlay even if
5317 the overlay's window property doesn't match the current window.
5318
d68443dc
MR
5319 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5320 (Fwindow_hchild): Rename to Fwindow_left_child.
5321 (Fwindow_next): Rename to Fwindow_next_sibling.
5322 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
5323 (resize_window_check): Rename to window_resize_check.
5324 (resize_window_apply): Rename to window_resize_apply.
5325 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5326 (Fdelete_other_windows_internal, resize_frame_windows)
5327 (Fsplit_window_internal, Fdelete_window_internal)
5328 (grow_mini_window, shrink_mini_window)
5329 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 5330
c7e73be5
JD
53312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5332
5333 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5334 (emacs_fixed_set_min_size): Remove.
5335 (emacs_fixed_new): Take frame as argument.
5336
5337 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5338 (_EmacsFixedPrivate): Remove minwidth/height.
5339 Add struct frame *f.
5340 (emacs_fixed_init): Initialize priv->f.
5341 (get_parent_class, emacs_fixed_set_min_size): Remove.
5342 (emacs_fixed_new): Set priv->f to argument.
5343 (emacs_fixed_get_preferred_width)
5344 (emacs_fixed_get_preferred_height): Use min_width/height from
5345 frames size_hint to set minimum and natural (Bug#8919).
5346 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5347 and use min_width/height from frames size_hint to set
5348 min_width/height (Bug#8919).
5349
5350 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
5351 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5352 Fix indentation.
c7e73be5 5353
cf99dcf8
EZ
53542011-06-26 Eli Zaretskii <eliz@gnu.org>
5355
5356 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5357 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5358 called at ZV.
5359
029529ac
CY
53602011-06-26 Chong Yidong <cyd@stupidchicken.com>
5361
5362 * process.c (wait_reading_process_output): Bypass select if
5363 waiting for a cell while ignoring keyboard input, and input is
5364 pending. Suggested by Jan Djärv (Bug#8869).
5365
7a7ef429
PE
53662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5367
5368 Use gnulib's dup2 module instead of rolling our own.
5369 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5370
11fdef7d 53712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
5372
5373 * dispnew.c (scrolling_window): Before scrolling, turn off a
5374 mouse-highlight in the window being scrolled.
5375
cd3520a4
JB
53762011-06-24 Juanma Barranquero <lekktu@gmail.com>
5377
5378 Move DEFSYM to lisp.h and use everywhere.
5379
5380 * character.h (DEFSYM): Move declaration...
5381 * lisp.h (DEFSYM): ...here.
5382
5383 * gnutls.c:
5384 * minibuf.c:
5385 * w32menu.c:
5386 * w32proc.c:
5387 * w32select.c: Don't include character.h.
5388
5389 * alloc.c (syms_of_alloc):
5390 * buffer.c (syms_of_buffer):
5391 * bytecode.c (syms_of_bytecode):
5392 * callint.c (syms_of_callint):
5393 * casefiddle.c (syms_of_casefiddle):
5394 * casetab.c (init_casetab_once):
5395 * category.c (init_category_once, syms_of_category):
5396 * ccl.c (syms_of_ccl):
5397 * cmds.c (syms_of_cmds):
5398 * composite.c (syms_of_composite):
5399 * dbusbind.c (syms_of_dbusbind):
5400 * dired.c (syms_of_dired):
5401 * dispnew.c (syms_of_display):
5402 * doc.c (syms_of_doc):
5403 * editfns.c (syms_of_editfns):
5404 * emacs.c (syms_of_emacs):
5405 * eval.c (syms_of_eval):
5406 * fileio.c (syms_of_fileio):
5407 * fns.c (syms_of_fns):
5408 * frame.c (syms_of_frame):
5409 * fringe.c (syms_of_fringe):
5410 * insdel.c (syms_of_insdel):
5411 * keymap.c (syms_of_keymap):
5412 * lread.c (init_obarray, syms_of_lread):
5413 * macros.c (syms_of_macros):
5414 * msdos.c (syms_of_msdos):
5415 * print.c (syms_of_print):
5416 * process.c (syms_of_process):
5417 * search.c (syms_of_search):
5418 * sound.c (syms_of_sound):
5419 * syntax.c (init_syntax_once, syms_of_syntax):
5420 * terminal.c (syms_of_terminal):
5421 * textprop.c (syms_of_textprop):
5422 * undo.c (syms_of_undo):
5423 * w32.c (globals_of_w32):
5424 * window.c (syms_of_window):
5425 * xdisp.c (syms_of_xdisp):
5426 * xfaces.c (syms_of_xfaces):
5427 * xfns.c (syms_of_xfns):
5428 * xmenu.c (syms_of_xmenu):
5429 * xsettings.c (syms_of_xsettings):
5430 * xterm.c (syms_of_xterm): Use DEFSYM.
5431
4228cf16
TZ
54322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5433
cd3520a4 5434 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 5435
7fcccf1e
PE
54362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5437
7efb4e0e
PE
5438 Integer and buffer overflow fixes (Bug#8873).
5439
ff5844ad
PE
5440 * print.c (printchar, strout): Check for string overflow.
5441 (PRINTPREPARE, printchar, strout):
5442 Don't set size unless allocation succeeds.
5443
90532f02
PE
5444 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5445 for sizes. Check for string overflow more accurately.
5446 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5447
6d84508d
PE
5448 * macros.c: Integer and buffer overflow fixes.
5449 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5450 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5451 Use ptrdiff_t, not int, for sizes.
5452 Don't increment bufsize until after realloc succeeds.
5453 Check for size-calculation overflow.
5454 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5455
437b2cb4
PE
5456 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5457
8b9ac8b4
PE
5458 * lread.c: Integer overflow fixes.
5459 (read_integer): Radix is now EMACS_INT, not int,
5460 to improve quality of diagnostics for out-of-range radices.
5461 Calculate buffer size correctly for out-of-range radices.
5462 (read1): Check for integer overflow in radices, and in
5463 read-circle numbers.
82cb60d3
PE
5464 (read_escape): Avoid int overflow.
5465 (Fload, openp, read_buffer_size, read1)
5466 (substitute_object_recurse, read_vector, read_list, map_obarray):
5467 Use ptrdiff_t, not int, for sizes.
5468 (read1): Use EMACS_INT, not int, for sizes.
20270765 5469 Check for size overflow.
8b9ac8b4 5470
7fcccf1e
PE
5471 * image.c (cache_image): Check for size arithmetic overflow.
5472
bfbbd7e7
PE
5473 * lread.c: Integer overflow issues.
5474 (saved_doc_string_size, saved_doc_string_length)
5475 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5476 Now ptrdiff_t, not int.
5477 (read1): Don't assume doc string length fits in int. Check for
5478 out-of-range doc string lengths.
5479 (read_list): Don't assume file position fits in int.
39019e54 5480 (read_escape): Check for hex character overflow.
bfbbd7e7 5481
4e323265
LL
54822011-06-22 Leo Liu <sdl.web@gmail.com>
5483
5484 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5485 Move to minibuffer.el.
5486
85fece3e
PE
54872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5488
20b84ce9 5489 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5490 The following patches are for when GLYPH_DEBUG && !XASSERT.
5491 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5492 * dispnew.c (flush_stdout):
5493 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5494 Mark as externally visible.
5495 * dispnew.c (check_window_matrix_pointers): Now static.
5496 * dispnew.c (window_to_frame_vpos):
5497 * xfns.c (unwind_create_frame):
5498 * xterm.c (x_check_font): Remove unused local.
5499 * scroll.c (CHECK_BOUNDS):
5500 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5501 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5502 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5503 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5504 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5505 Now static.
5506 (debug_method_add): Use va_list and vsprintf rather than relying
5507 on undefined behavior with wrong number of arguments.
5508 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5509 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5510 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5511 since we're not interested in debugging glyphs with old libraries.
5512 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5513 GCC 4.6.0's static checking.
5514
0766b489
PE
55152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5516
31fd4b32
PE
5517 Integer overflow and signedness fixes (Bug#8873).
5518 A few related buffer overrun fixes, too.
5519
b79e8648
PE
5520 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5521
0766b489
PE
5522 * dispextern.h (struct face.stipple):
5523 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5524 (x_bitmap_mask, x_allocate_bitmap_record)
5525 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5526 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5527 (x_create_bitmap_from_xpm_data):
5528 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5529 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5530 (.bitmaps_last):
5531 * xfaces.c (load_pixmap):
5532 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5533 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5534 (.bitmaps_last, struct x_output.icon_bitmap):
5535 Use ptrdiff_t, not int, for bitmap indexes.
5536 (x_allocate_bitmap_record): Check for size overflow.
5537 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5538
b081724f
PE
5539 Use ptrdiff_t, not int, for overlay counts.
5540 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5541 * editfns.c (overlays_around, get_pos_property):
5542 * textprop.c (get_char_property_and_overlay):
5543 * xdisp.c (next_overlay_change, note_mouse_highlight):
5544 * xfaces.c (face_at_buffer_position):
21514da7
PE
5545 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5546 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5547 (Fnext_overlay_change, Fprevious_overlay_change)
5548 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5549 Use ptrdiff_t, not int, for sizes.
21514da7 5550 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5551
3de73e5e
PE
5552 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5553
2606c57b
PE
5554 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5555 (x_session_initialize): Do not assume string length fits in int.
5556
aaafe47a
PE
5557 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5558 This is unlikely, but can occur if DPI is outlandish.
5559
2674ddc8 5560 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5561 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5562
28154962
PE
5563 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5564 * xrdb.c (magic_file_p, search_magic_path):
5565 Omit last arg SUFFIX; it was always 0. All callers changed.
5566 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5567
7de51af5
PE
5568 * xfont.c (xfont_match): Avoid need for strlen.
5569
25ed6cc3
PE
5570 * xfns.c: Don't assume strlen fits in int.
5571 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5572
4eab31dd
PE
5573 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5574 not unsigned long, as we prefer signed integers. All callers changed.
5575 Detect integer overflow in repeat count.
5576 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5577 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5578
171e2a58
PE
5579 * termcap.c: Don't assume sizes fit in int and never overflow.
5580 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5581 (gobble_line): Check for size-calculation overflow.
5582
ad39faca 5583 * minibuf.c (Fread_buffer):
6e5bb2dc 5584 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5585 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5586 Don't assume string length fits in int.
5587
52c61c22 5588 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5589 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5590
b5b8c9e5
PE
5591 * font.c: Don't assume string length fits in int.
5592 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5593 Use ptrdiff_t, not int.
ccd6111c
PE
5594 (font_intern_prop): Don't assume string length fits in int.
5595 Don't assume integer property fits in fixnum.
5596 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5597
882f0d81 5598 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5599 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5600 Reformulate so as not to need the command string.
5601 Invoke gzip -cd rather than gunzip, as it's more portable.
5602 (lock_info_type, lock_file_1, lock_file):
5603 Don't assume pid_t and time_t fit in unsigned long.
5604 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5605 (current_lock_owner): Prefer signed type for sizes.
5606 Use memcpy, not strncpy, where memcpy is what is really wanted.
5607 Don't assume (via atoi) that time_t and pid_t fit in int.
5608 Check for time_t and/or pid_t out of range, e.g., via a network share.
5609 Don't alloca where an auto var works fine.
5610
93f4cf88
PE
5611 * fileio.c: Fix some integer overflow issues.
5612 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5613 Don't assume string length fits in int.
5614 (directory_file_name): Don't assume string length fits in long.
5615 (make_temp_name): Don't assume pid fits in int, or that its print
5616 length is less than 20.
5617
f3e92b69
PE
5618 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5619
1bfdaf10
PE
5620 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5621
35016e9a
PE
5622 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5623
3d1e65a1
PE
5624 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5625 We prefer signed integers, even for size calculations.
5626
0b963a93
PE
5627 * emacs.c: Don't assume string length fits in 'int'.
5628 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5629 (main): Don't invoke strlen when not needed.
5630
573f4b54
PE
5631 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5632 (XD_DEBUG_MESSAGE): Don't waste a byte.
5633
989f33ba
PE
5634 * callproc.c (getenv_internal_1, getenv_internal)
5635 (Fgetenv_internal):
965d34eb
PE
5636 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5637
e4d29b33
PE
5638 * lread.c (invalid_syntax): Omit length argument.
5639 All uses changed. This doesn't fix a bug, but it simplifies the
5640 code away from its former Hollerith-constant appearance, and it's
5641 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5642 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5643
eb49b136
PE
5644 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5645 This didn't break anything, but it didn't help either.
5646 It's confusing to put a bogus integer in a place where the actual
5647 value does not matter.
9f62aeb1 5648 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5649 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5650
15375a22
PE
5651 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5652 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5653 implementation.
b61cc01c
PE
5654 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5655 We prefer signed types, and the value cannot exceed the EMACS_INT
5656 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5657 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5658 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5659 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5660
53b2623d
PE
5661 * indent.c (sane_tab_width): New function.
5662 (current_column, scan_for_column, Findent_to, position_indentation)
5663 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5664 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5665
51cab52b 5666 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5667
f2ed8a70
PE
5668 * lisp.h (lint_assume): New macro.
5669 * composite.c (composition_gstring_put_cache):
5670 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5671
abe80cc6
PE
5672 * editfns.c, insdel.c:
5673 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5674
b02c740e
PE
5675 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5676
ebc96716
PE
5677 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5678
b4e50fa0 5679 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5680 Use much-faster test for byte-length change.
311d5d7c 5681 Don't assume string byte-length fits in 'int'.
a4cf38e4 5682 Check that character arg fits in 'int'.
85461888 5683 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5684
c0c1ee9f
PE
5685 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5686
a498d7f4
PE
5687 * fns.c (concat): Catch string overflow earlier.
5688 Do not rely on integer wraparound.
5689
51cab52b
PE
5690 * dispextern.h (struct it.overlay_strings_charpos)
5691 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5692 * xdisp.c (forward_to_next_line_start)
5693 (back_to_previous_visible_line_start)
5694 (reseat_at_next_visible_line_start, next_element_from_buffer):
5695 Don't arbitrarily truncate the value of 'selective' to int.
5696
76031fad
PE
5697 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5698
5eb55db9
PE
5699 * composite.c: Don't truncate sizes to 'int'.
5700 (composition_gstring_p, composition_reseat_it)
5701 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5702 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5703 not EMACS_UINT, for indexes.
5eb55db9 5704
0703a717
PE
5705 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5706
d6202519
PE
5707 * buffer.c: Include <verify.h>.
5708 (struct sortvec.priority, struct sortstr.priority):
8961a454 5709 Now EMACS_INT, not int.
c20998a7 5710 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5711 (struct sortstr.size, record_overlay_string)
5712 (struct sortstrlist.size, struct sortlist.used):
5713 Don't truncate size to int.
5714 (record_overlay_string): Check for size-calculation overflow.
d6202519 5715 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5716
d5a19415
JM
57172011-06-22 Jim Meyering <meyering@redhat.com>
5718
029529ac 5719 Don't leak an XBM-image-sized buffer
d5a19415
JM
5720 * image.c (xbm_load): Free the image buffer after using it.
5721
a9041e6c
PE
57222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5723
5724 Port to Sun C.
5725 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5726 that Sun C diagnosed.
5727 * fns.c (secure_hash): Fix pointer signedness issue.
5728 * intervals.c (static_offset_intervals): New function.
5729 (offset_intervals): Use it.
5730
7f3f739f
LL
57312011-06-21 Leo Liu <sdl.web@gmail.com>
5732
5733 * deps.mk (fns.o):
5734 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5735 sha512.h.
5736
5737 * fns.c (secure_hash): Rename from crypto_hash_function and change
5738 the first arg to accept symbols.
5b66d427 5739 (Fsecure_hash): New primitive.
7f3f739f
LL
5740 (syms_of_fns): New symbols.
5741
76147d94
DD
57422011-06-20 Deniz Dogan <deniz@dogan.se>
5743
5744 * process.c (Fset_process_buffer): Clarify return value in
5745 docstring.
5746
7d7d0045
CY
57472011-06-18 Chong Yidong <cyd@stupidchicken.com>
5748
5749 * dispnew.c (add_window_display_history): Use BVAR.
5750
5751 * xdisp.c (debug_method_add): Use BVAR.
5752 (check_window_end, dump_glyph_matrix, dump_glyph)
5753 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5754
5755 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5756 Likewise.
5757
5758 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5759 check till after the cache is created in init_frame_faces.
5760
ff2bc410
SM
57612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5762
5763 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5764
28177add
PE
57652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5766
dd3482fe
PE
5767 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5768 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5769 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5770
393d71f3 5771 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5772 * fileio.c (Finsert_file_contents):
5773 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5774 Remove the old (too-loose) buffer overflow checks.
5775 They weren't needed, since make_gap checks for buffer overflow.
5776 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5777 The old code merely checked for Emacs fixnum overflow, and relied
5778 on undefined (wraparound) behavior. The new code avoids undefined
5779 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5780
2e6813b0 5781 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5782 Tune. Don't use wider integers than needed. Don't use alloca.
5783 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5784
599a9e4f
PE
5785 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5786
99561444
PE
5787 * insdel.c, lisp.h (buffer_overflow): New function.
5788 (insert_from_buffer_1, replace_range, replace_range_2):
5789 * insdel.c (make_gap_larger):
5790 * editfns.c (Finsert_char):
5791 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5792
28177add
PE
5793 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5794
e69dafad
PE
57952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5796
4baa020d 5797 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5798
b1c46f02
PE
5799 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5800 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5801
e69dafad
PE
5802 * fileio.c: Don't assume EMACS_INT fits in off_t.
5803 (emacs_lseek): New static function.
5804 (Finsert_file_contents, Fwrite_region): Use it.
5805 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5806
566684ea
PE
5807 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5808
e6966cd6
PE
5809 * fns.c: Don't overflow int when computing a list length.
5810 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5811 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5812 truncation on 64-bit hosts. Check for QUIT every
5813 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5814 faster and is responsive enough.
5815 (Flength): Report an error instead of overflowing an integer.
5816 (Fsafe_length): Return a float if the value is not representable
5817 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5818 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5819 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5820
dd0b0efb
PE
5821 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5822 (header_size, word_size): New constants.
5823 (allocate_vectorlike): Don't check size overflow here.
5824 (allocate_vector): Check it here instead, since this is the only
5825 caller of allocate_vectorlike that could cause overflow.
5826 Check that the new vector's length is representable as a fixnum.
5827
86fe5cfe
PE
5828 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5829 The previous code was bogus. For example, next_almost_prime (32)
5830 returned 39, which is undesirable as it is a multiple of 3; and
5831 next_almost_prime (24) returned 25, which is a multiple of 5 so
5832 why was the code bothering to check for multiples of 7?
5833
80e88859
PE
5834 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5835
4a2f0ad6
PE
5836 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5837
f66c7cf8
PE
5838 Variadic C functions now count arguments with ptrdiff_t.
5839 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5840 Back then I didn't know that the Emacs coding style prefers signed int.
5841 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5842 were being counted with int, which may truncate counts on 64-bit
5843 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5844 * lisp.h (struct Lisp_Subr.function.aMANY)
5845 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5846 Arg counts are now ptrdiff_t, not size_t.
5847 All variadic functions and their callers changed accordingly.
5848 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5849 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5850 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5851 * callint.c (Fcall_interactively): Check arg count for overflow,
5852 to avoid potential buffer overrun. Use signed char, not 'int',
5853 for 'varies' array, so that we needn't bother to check its size
5854 calculation for overflow.
5855 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5856 * eval.c (apply_lambda):
5857 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5858 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5859 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5860
a1759b76
PE
5861 * callint.c (Fcall_interactively): Don't use index var as event count.
5862
d96be9fc
PE
5863 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5864 * mem-limits.h (SIZE): Remove; no longer used.
5865
a690a978 5866 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5867
578c21e6
PE
5868 Remove unnecessary casts.
5869 * xterm.c (x_term_init):
5870 * xfns.c (x_set_border_pixel):
5871 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5872 These aren't needed now that we assume ANSI C.
5873
96f53c6c
PE
5874 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5875 It's more likely to cause problems (due to unsigned overflow)
5876 than to cure them.
5877
83c77d31
PE
5878 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5879
ee2079f1
PE
5880 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5881
6da65536
PE
5882 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5883
7147c4a4
PE
5884 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5885
193e32d9
PE
5886 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5887
e5533da6
PE
5888 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5889
9910e595
PE
5890 GLYPH_CODE_FACE returns EMACS_INT, not int.
5891 * dispextern.h (merge_faces):
5892 * xfaces.c (merge_faces):
01103c44
PE
5893 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5894 Don't assume EMACS_INT fits in int.
9910e595 5895
2638320e
PE
5896 * character.h (CHAR_VALID_P): Remove unused parameter.
5897 * fontset.c, lisp.h, xdisp.c: All uses changed.
5898
045eb8d9
PE
5899 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5900
c1f134b5
PE
5901 * fns.c (concat): Minor tuning based on overflow analysis.
5902 This doesn't fix any bugs. Use int to hold character, instead
5903 of constantly refetching from Emacs object. Use XFASTINT, not
5904 XINT, for value known to be a character. Don't bother comparing
5905 a single byte to 0400, as it's always less.
5906
395fcb93 5907 * floatfns.c (Fexpt):
327eeec8
PE
5908 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5909
abbd3d23
PE
5910 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5911 for characters.
5912
684a03ef
PE
5913 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5914
0fed43f3
PE
5915 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5916 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5917 incorrectly succeed when S was a string, because 4294967386 was
5918 truncated before it was used.
5919
8fd02eb7
PE
5920 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5921 Otherwise, an out-of-range integer could cause undefined behavior
5922 on a 64-bit host.
5923
f8c86b69
PE
5924 * composite.c: Use int, not EMACS_INT, for characters.
5925 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5926 EMACS_INT, for values that are known to be in character range.
5927 This doesn't fix any bugs but is the usual style inside Emacs and
5928 may generate better code on 32-bit machines.
5929
34206dd2
PE
5930 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5931 This is for reasons similar to the recent CHAR_STRING fix.
5932 * charset.c (Fencode_char): Check that character arg is actually
5933 a character. Pass an int to ENCODE_CHAR.
5934 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5935 wider than 'int', as a compile-time check to prevent future regressions
5936 in this area.
5937
c5958d4c 5938 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5939
5940 Make sure a 64-bit char is never passed to CHAR_STRING.
5941 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5942 by silently ignoring the top 32 bits, allowing some values
5943 that were far too large to be valid characters.
5944 * character.h: Include <verify.h>.
5945 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5946 arguments are no wider than unsigned, as a compile-time check
5947 to prevent future regressions in this area.
5948 * data.c (Faset):
01103c44 5949 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5950 (Fsubst_char_in_region):
5951 * fns.c (concat):
5952 * xdisp.c (decode_mode_spec_coding):
5953 Adjust to CHAR_STRING's new requirement.
5954 * editfns.c (Finsert_char, Fsubst_char_in_region):
5955 * fns.c (concat): Check that character args are actually
5956 characters. Without this test, these functions did the wrong
5957 thing with wildly out-of-range values on 64-bit hosts.
5958
d37ca623
PE
5959 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5960 These casts should not be needed on 32-bit hosts, either.
5961 * keyboard.c (read_char):
5962 * lread.c (Fload): Remove casts to unsigned.
5963
ea204efb
PE
5964 * lisp.h (UNSIGNED_CMP): New macro.
5965 This fixes comparison bugs on 64-bit hosts.
5966 (ASCII_CHAR_P): Use it.
5967 * casefiddle.c (casify_object):
01103c44 5968 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5969 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5970 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5971 * dispextern.h (FACE_FROM_ID):
5972 * keyboard.c (read_char): Use UNSIGNED_CMP.
5973
41cb286c
PE
5974 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5975 not to EMACS_INT, to avoid GCC warning.
5976
4a1b9832
PE
5977 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5978
55daad71
PE
5979 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5980 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5981 isn't needed on 32-bit machines.
8f95c75c 5982
01103c44
PE
5983 * buffer.c (Fgenerate_new_buffer_name):
5984 Use EMACS_INT for count, not int.
0ceccced 5985 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5986
5987 * data.c (Qcompiled_function): Now static.
5988
c6f072e7
PE
5989 * window.c (window_body_lines): Now static.
5990
20ce5912
PE
5991 * image.c (gif_load): Rename local to avoid shadowing.
5992
9c4c5f81
PE
5993 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5994 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5995 * alloc.c (make_save_value): Integer argument is now of type
5996 ptrdiff_t, not int.
5997 (mark_object): Use ptrdiff_t, not int.
5998 * lisp.h (pD): New macro.
5999 * print.c (print_object): Use it.
6000
c0c5c8ae
PE
6001 * alloc.c: Use EMACS_INT, not int, to count objects.
6002 (total_conses, total_markers, total_symbols, total_vector_size)
6003 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
6004 (total_free_floats, total_floats, total_free_intervals)
6005 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
6006 Now EMACS_INT, not int. All uses changed.
6007 (Fgarbage_collect): Compute overall total using a double, so that
6008 integer overflow is less likely to be a problem. Check for overflow
6009 when converting back to an integer.
5a25e253
PE
6010 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6011 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6012 These were 'int' variables that could overflow on 64-bit hosts;
6013 they were never used, so remove them instead of repairing them.
211a0b2a 6014 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
6015 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6016 Previously, this ceilinged at INT_MAX, but that doesn't work on
6017 64-bit machines.
e46bb31a 6018 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 6019
c78baabf 6020 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 6021 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
6022 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6023 when a (possibly-narrower) signed value would do just as well.
6024 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 6025
c9d624c6
PE
6026 * alloc.c: Catch some string size overflows that we were missing.
6027 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6028 for convenience in STRING_BYTES_MAX.
6029 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6030 The definition here is exact; the one in lisp.h was approximate.
6031 (allocate_string_data): Check for string overflow. This catches
6032 some instances we weren't catching before. Also, it catches
6033 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6034 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6035 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 6036
c9d624c6
PE
6037 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6038 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 6039 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 6040
353032ce
PE
6041 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6042
2bccce07
PE
6043 * alloc.c (Fmake_string): Check for out-of-range init.
6044
0ac30604
SM
60452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6046
6047 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6048
c195f2de
JD
60492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6050
6051 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6052 xg_get_default_scrollbar_width.
6053
6054 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6055 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6056 (style_changed_cb): Call update_theme_scrollbar_width and call
6057 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6058 all frames (Bug#8505).
6059 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6060 Call gtk_window_set_resizable if HAVE_GTK3.
6061 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6062 and height if HAVE_GTK3 (Bug#8505).
6063 (scroll_bar_width_for_theme): New variable.
6064 (update_theme_scrollbar_width): New function.
6065 (xg_get_default_scrollbar_width): Move code to
6066 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6067 (xg_initialize): Call update_theme_scrollbar_width.
6068
6069 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6070
6071 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6072
e10ac9f1
MR
60732011-06-12 Martin Rudalics <rudalics@gmx.at>
6074
6075 * frame.c (make_frame): Call other_buffer_safely instead of
6076 other_buffer.
6077
6078 * window.c (temp_output_buffer_show): Call display_buffer with
6079 second argument Vtemp_buffer_show_specifiers and reset latter
6080 immediately after the call.
6081 (Vtemp_buffer_show_specifiers): New variable.
6082 (auto_window_vscroll_p, next_screen_context_lines)
6083 (Vscroll_preserve_screen_position): Remove leading asterisks from
6084 doc-strings.
6085
2d3c217e 60862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 6087
7b7f97e8 6088 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
6089 * buffer.c (Qclone_number): Remove for now, as it's unused.
6090 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6091 (record_buffer): Remove unused local.
6092 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6093 (set_frame_buffer_list): Remove; unused.
6094 * frame.h (other_visible_frames): Remove decl.
6095 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6096 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6097 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6098 if HAVE_GPM.
6099 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6100 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6101 Define only if HAVE_GPM.
6102 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6103 (update_hints_inhibit): Remove; never set. All uses removed.
6104 * widgetprv.h (emacsFrameClassRec): Remove decl.
6105 * window.c (delete_deletable_window): Now returns void, since it
6106 wasn't returning anything.
6107 (compare_window_configurations): Remove unused locals.
6108 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6109 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
6110 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6111 the same widths as pointers. This follows up on the 2011-05-06 patch.
6112 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6113 * xterm.h: Likewise.
6114 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6115
1384b89e
JB
61162011-06-12 Juanma Barranquero <lekktu@gmail.com>
6117
6118 * makefile.w32-in: Update dependencies.
6119 (LISP_H): Add lib/intprops.h.
6120
1100a63c
CY
61212011-06-11 Chong Yidong <cyd@stupidchicken.com>
6122
6123 * image.c (gif_load): Add animation frame delay to the metadata.
6124 (syms_of_image): Use DEFSYM. New symbol `delay'.
6125
6198ccd0
MR
61262011-06-11 Martin Rudalics <rudalics@gmx.at>
6127
6128 * window.c (delete_deletable_window): Re-add.
6129 (Fset_window_configuration): Rewrite to handle dead buffers and
6130 consequently deletable windows.
6131 (window_tree, Fwindow_tree): Remove. Supply functionality in
6132 window.el.
6133 (compare_window_configurations): Simplify code.
6134
b6e3633c
AS
61352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6136
1ab0dee5
AS
6137 * image.c (imagemagick_load_image): Fix type mismatch.
6138 (Fimagemagick_types): Likewise.
6139
b6e3633c
AS
6140 * window.h (replace_buffer_in_windows): Declare.
6141
9397e56f
MR
61422011-06-11 Martin Rudalics <rudalics@gmx.at>
6143
6144 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6145 Qclone_number. Remove external declaration of Qdelete_window.
6146 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6147 code.
640c8776
SM
6148 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6149 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
6150 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6151 buffer list implementation.
6152 (other_buffer_safely): New function.
6153 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6154 calls to replace_buffer_in_windows and
6155 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6156 if allowed.
6157 (record_buffer): Inhibit quitting and rewrite using quittable
6158 functions. Run Qbuffer_list_update_hook if allowed.
6159 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
6160 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6161 Move switch-to-buffer to window.el.
9397e56f
MR
6162 (bury-buffer): Move to window.el.
6163 (Vbuffer_list_update_hook): New variable.
6164
6165 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6166 section.
6167
6168 * window.h (resize_frame_windows): Move up in code.
6169 (Fwindow_frame): Remove EXFUN.
6170 (replace_buffer_in_all_windows): Remove prototype.
6171 (replace_buffer_in_windows_safely): Add prototype.
6172
6173 * window.c: Declare Qdelete_window static again. Move down
6174 declaration of select_count.
6175 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6176 (Fother_window): Move to window.el.
6177 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6178 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6179 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6180 window.el.
6181 (replace_buffer_in_windows): Implement by calling
6182 Qreplace_buffer_in_windows.
6183 (replace_buffer_in_all_windows): Remove with some functionality
6184 moved into replace_buffer_in_windows_safely.
6185 (replace_buffer_in_windows_safely): New function.
6186 (select_window_norecord, select_frame_norecord): Move in front
6187 of run_window_configuration_change_hook. Remove now obsolete
6188 declarations.
640c8776
SM
6189 (Fset_window_buffer): Rewrite doc-string.
6190 Call Qrecord_window_buffer.
9397e56f
MR
6191 (keys_of_window): Move binding for other-window to window.el.
6192
b50691aa
CY
61932011-06-11 Chong Yidong <cyd@stupidchicken.com>
6194
6195 * dispextern.h (struct image): Replace data member, whose int_val
6196 and ptr_val fields were not used by anything, with a single
6197 lisp_val object.
6198
6199 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6200 (gif_clear_image, gif_load, imagemagick_load_image)
6201 (gs_clear_image, gs_load): Callers changed.
6202
3f754b86
PE
62032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6204
cca69397
PE
6205 * buffer.h: Include <time.h>, for time_t.
6206 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6207
109e28d0
PE
6208 Fix minor problems found by static checking.
6209
60737f02
PE
6210 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6211
4b66faf3
PE
6212 Make identifiers static if they are not used in other modules.
6213 * data.c (Qcompiled_function, Qframe, Qvector):
6214 * image.c (QimageMagick, Qsvg):
6215 * minibuf.c (Qmetadata):
6216 * window.c (resize_window_check, resize_root_window): Now static.
6217 * window.h (resize_window_check, resize_root_window): Remove decls.
6218
109e28d0
PE
6219 * window.c (window_deletion_count, delete_deletable_window):
6220 Remove; unused.
46a4ce9e
PE
6221 (window_body_lines): Now static.
6222 (Fdelete_other_windows_internal): Mark vars as initialized.
6223 Make sure 'resize_failed' is initialized.
6224 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6225 (resize_window_apply): Remove unused local.
6226 * window.h (delete_deletable_window): Remove decl.
6227
109e28d0 6228 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
6229 (imagemagick_load_image): Fix pointer signedness problem by changing
6230 last arg from unsigned char * to char *. All uses changed.
6231 Also, fix a local for similar reasons.
6232 Remove unused locals. Remove locals to avoid shadowing.
6233 (fn_rsvg_handle_free): Remove; unused.
6234 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 6235 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 6236
3f754b86
PE
6237 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6238
2547adb1
CY
62392011-06-10 Chong Yidong <cyd@stupidchicken.com>
6240
6241 * image.c (gif_load): Fix omitted cast error introduced by
6242 2011-06-06 change.
6243
2c8e37d4
MR
62442011-06-10 Martin Rudalics <rudalics@gmx.at>
6245
6246 * window.h (resize_proportionally, orig_total_lines)
6247 (orig_top_line): Remove from window structure.
6248 (set_window_height, set_window_width, change_window_heights)
6249 (Fdelete_window): Remove prototypes.
6250 (resize_frame_windows): Remove duplicate declaration.
6251
440a42e3
EZ
62522011-06-10 Eli Zaretskii <eliz@gnu.org>
6253
6254 * window.h (resize_frame_windows, resize_window_check)
6255 (delete_deletable_window, resize_root_window)
6256 (resize_frame_windows): Declare prototypes.
6257
6258 * window.c (resize_window_apply): Make definition be "static" to
6259 match the prototype.
6260
562dd5e9
MR
62612011-06-10 Martin Rudalics <rudalics@gmx.at>
6262
6263 * window.c: Remove declarations of Qwindow_size_fixed,
6264 window_min_size_1, window_min_size_2, window_min_size,
6265 size_window, window_fixed_size_p, enlarge_window, delete_window.
6266 Remove static from declaration of Qdelete_window, it's
6267 temporarily needed by Fbury_buffer.
6268 (replace_window): Don't assign orig_top_line and
6269 orig_total_lines.
6270 (Fdelete_window, delete_window): Remove. Window deletion is
6271 handled by window.el.
640c8776
SM
6272 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6273 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
6274 (Fdelete_other_windows): Remove. Deleting other windows is
6275 handled by window.el.
6276 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6277 handled in window.el.
6278 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6279 Window minimum sizes are handled in window.el.
6280 (shrink_windows, size_window, set_window_height)
6281 (set_window_width, change_window_heights, window_height)
6282 (window_width, CURBEG, CURSIZE, enlarge_window)
6283 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6284 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6285 handled in window.el.
6286 (make_dummy_parent): Rename to make_parent_window and give it a
6287 second argument horflag.
6288 (make_window): Don't set resize_proportionally any more.
6289 (Fsplit_window): Remove. Windows are split in window.el.
6290 (save_restore_action, save_restore_orig_size)
6291 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6292 Resize mini windows in window.el.
6293 (grow_mini_window, shrink_mini_window): Implement by calling
6294 Qresize_root_window_vertically, resize_window_check and
6295 resize_window_apply.
640c8776
SM
6296 (saved_window, Fset_window_configuration, save_window_save):
6297 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
6298 resize_proportionally.
6299 (window_min_height, window_min_width): Move to window.el.
6300 (keys_of_window): Move bindings for delete-other-windows,
6301 split-window, delete-window and enlarge-window to window.el.
6302
6303 * buffer.c: Temporarily extern Qdelete_window.
6304 (Fbury_buffer): Temporarily call Qdelete_window instead of
6305 Fdelete_window (Fbury_buffer will move to window.el soon).
6306
6307 * frame.c (set_menu_bar_lines_1): Remove code handling
6308 orig_top_line and orig_total_lines.
6309
6310 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6311 set_window_height but set heights directly.
6312 (change_frame_size_1): Use resize_frame_windows.
6313
6314 * xdisp.c (init_xdisp): Don't use set_window_height but set
6315 heights directly.
6316
640c8776
SM
6317 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6318 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
6319 run_window_configuration_change_hook.
6320
6321 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6322 instead of change_window_heights and run
6323 run_window_configuration_change_hook.
6324
1a13852e
MR
63252011-06-09 Martin Rudalics <rudalics@gmx.at>
6326
6327 * window.c (replace_window): Rename second argument REPLACEMENT to
6328 NEW. New third argument SETFLAG. Rewrite.
6329 (delete_window, make_dummy_parent): Call replace_window with
6330 third argument 1.
6331 (window_list_1): Move down in code.
6332 (run_window_configuration_change_hook): Move set_buffer part
6333 before select_frame_norecord part in order to unwind correctly.
6334 Rename count1 to count.
6335 (recombine_windows, delete_deletable_window, resize_root_window)
6336 (Fdelete_other_windows_internal)
6337 (Frun_window_configuration_change_hook, make_parent_window)
6338 (resize_window_check, resize_window_apply, Fresize_window_apply)
6339 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
6340 (Fdelete_window_internal, Fresize_mini_window_internal):
6341 New functions.
1a13852e
MR
6342 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6343
f3d1777e
MR
63442011-06-08 Martin Rudalics <rudalics@gmx.at>
6345
496e208e
MR
6346 * window.h (window): Add some new members to window structure -
6347 normal_lines, normal_cols, new_total, new_normal, clone_number,
6348 splits, nest, prev_buffers, next_buffers.
6349 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 6350 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 6351
f3d1777e
MR
6352 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6353 Remove.
496e208e
MR
6354 (make_dummy_parent): Set new members of windows structure.
6355 (make_window): Move down in code. Handle new members of window
6356 structure.
6357 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6358 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6359 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6360 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
6361 (Fset_window_next_buffers, Fset_window_clone_number):
6362 New functions.
496e208e
MR
6363 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6364 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6365 Doc-string fixes.
6366 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6367 Argument WINDOW can be now internal window too.
6368 (Fwindow_use_time): Move up in code.
6369 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6370 Rewrite doc-string.
6371 (Fset_window_configuration, saved_window)
6372 (Fcurrent_window_configuration, save_window_save): Handle new
6373 members of window structure.
b9e809c2
MR
6374 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6375 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6376 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6377 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6378 Qget_mru_window, Qresize_root_window,
6379 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6380 Qauto_buffer_name; staticpro them.
f3d1777e 6381
abde8f8c
MR
63822011-06-07 Martin Rudalics <rudalics@gmx.at>
6383
6384 * window.c (Fwindow_total_size, Fwindow_left_column)
6385 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6386 (Fwindow_list_1): New functions.
6387 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
6388 (Fwindow_width, Fscroll_left, Fscroll_right):
6389 Use window_body_cols instead of window_box_text_cols.
6390 (delete_window, Fset_window_configuration):
6391 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
6392 (delete_all_subwindows): Take a window as argument and not a
6393 structure. Rewrite.
190b47e6
MR
6394 (window_loop): Remove handling of GET_LRU_WINDOW and
6395 GET_LARGEST_WINDOW.
6396 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
6397
6398 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
6399 window_box_text_cols. delete_all_subwindows now takes a
6400 Lisp_Object as argument.
abde8f8c 6401
640c8776
SM
6402 * indent.c (compute_motion, Fcompute_motion):
6403 Use window_body_cols instead of window_box_text_cols.
abde8f8c 6404
fa8a67e6
MR
6405 * frame.c (delete_frame): Call delete_all_subwindows with root
6406 window as argument.
6407
a54e3482
DC
64082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6409
6410 * fns.c (Fputhash): Document return value.
6411
60002bf5
CY
64122011-06-06 Chong Yidong <cyd@stupidchicken.com>
6413
6414 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6415
0c671da6 64162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 6417
b862a52a 6418 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 6419
be44ca6c
PE
6420 Check for overflow when converting integer to cons and back.
6421 * charset.c (Fdefine_charset_internal, Fdecode_char):
6422 Use cons_to_unsigned to catch overflow.
6423 (Fencode_char): Use INTEGER_TO_CONS.
6424 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6425 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6426 * data.c (long_to_cons, cons_to_long): Remove.
6427 (cons_to_unsigned, cons_to_signed): New functions.
6428 These signal an error for invalid or out-of-range values.
6429 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6430 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6431 * font.c (Ffont_variation_glyphs):
6432 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6433 * lisp.h: Include <intprops.h>.
6434 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6435 (cons_to_signed, cons_to_unsigned): New decls.
6436 (long_to_cons, cons_to_long): Remove decls.
6437 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6438 (Fprimitive_undo): Use CONS_TO_INTEGER.
6439 * xfns.c (Fx_window_property): Likewise.
6440 * xselect.c: Include <limits.h>.
6441 (x_own_selection, selection_data_to_lisp_data):
6442 Use INTEGER_TO_CONS.
6443 (x_handle_selection_request, x_handle_selection_clear)
6444 (x_get_foreign_selection, Fx_disown_selection_internal)
6445 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6446 (lisp_data_to_selection_data): Use cons_to_unsigned.
6447 (x_fill_property_data): Use cons_to_signed.
6448 Report values out of range.
6449
d1f3d2af
PE
6450 Check for buffer and string overflow more precisely.
6451 * buffer.h (BUF_BYTES_MAX): New macro.
6452 * lisp.h (STRING_BYTES_MAX): New macro.
6453 * alloc.c (Fmake_string):
6454 * character.c (string_escape_byte8):
6455 * coding.c (coding_alloc_by_realloc):
6456 * doprnt.c (doprnt):
6457 * editfns.c (Fformat):
6458 * eval.c (verror):
6459 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6460 since they may not be the same number.
6461 * editfns.c (Finsert_char):
6462 * fileio.c (Finsert_file_contents):
6463 Likewise for BUF_BYTES_MAX.
6464
dd52fcea
PE
6465 * image.c: Use ptrdiff_t, not int, for sizes.
6466 (slurp_file): Switch from int to ptrdiff_t.
6467 All uses changed.
6468 (slurp_file): Check that file size fits in both size_t (for
6469 malloc) and ptrdiff_t (for sanity and safety).
6470
7f9bbdbb
PE
6471 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6472 if b->modtime has its maximal value.
6473
dfe18f82
PE
6474 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6475
84acfcf0
PE
6476 Don't assume time_t can fit into int.
6477 * buffer.h (struct buffer.modtime): Now time_t, not int.
6478 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6479 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6480
ccd9a01a
PE
6481 Minor fixes for signed vs unsigned integers.
6482 * character.h (MAYBE_UNIFY_CHAR):
6483 * charset.c (maybe_unify_char):
6484 * keyboard.c (read_char, reorder_modifiers):
6485 XINT -> XFASTINT, since the integer must be nonnegative.
6486 * ftfont.c (ftfont_spec_pattern):
6487 * keymap.c (access_keymap, silly_event_symbol_error):
6488 XUINT -> XFASTINT, since the integer must be nonnegative.
6489 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6490 since it makes no difference and we prefer signed.
6491 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6492 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6493 nonnegative.
6494
d6d100dd
SM
64952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6496
6497 * window.h (Fwindow_frame): Declare.
6498
2b6148e4
PE
64992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6500
6501 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6502 (SPARE_MEMORY): Always define.
6503 (LARGE_REQUEST): Remove.
6504 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6505
f230ecc9
MR
65062011-06-06 Martin Rudalics <rudalics@gmx.at>
6507
727e958e
MR
6508 * lisp.h: Move EXFUNS for Fframe_root_window,
6509 Fframe_first_window and Fset_frame_selected_window to window.h.
6510
6511 * window.h: Move EXFUNS for Fframe_root_window,
6512 Fframe_first_window and Fset_frame_selected_window here from
6513 lisp.h.
6514
6515 * frame.c (Fwindow_frame, Fframe_first_window)
6516 (Fframe_root_window, Fframe_selected_window)
6517 (Fset_frame_selected_window): Move to window.c.
6518 (Factive_minibuffer_window): Move to minibuf.c.
6519 (Fother_visible_frames_p): New function.
6520
6521 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6522
f230ecc9
MR
6523 * window.c (decode_window, decode_any_window): Move up in code.
6524 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6525 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6526 (Fwindow_buffer): Move up and rewrite doc-string.
6527 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6528 (Fwindow_prev): New functions.
727e958e
MR
6529 (Fwindow_frame): Move here from frame.c. Accept any window as
6530 argument.
6531 (Fframe_root_window, Fframe_first_window)
6532 (Fframe_selected_window): Move here from frame.c. Accept frame
6533 or arbitrary window as argument. Update doc-strings.
6534 (Fminibuffer_window): Move up in code.
6535 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6536 (Fset_frame_selected_window): Move here from frame.c.
6537 Marginal rewrite.
727e958e
MR
6538 (Fselected_window, select_window, Fselect_window): Move up in
6539 code. Minor doc-string fixes.
f230ecc9 6540
4d09bcf6
PE
65412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6544 Do not assume that spare memory exists; that assumption is valid
6545 only if SYSTEM_MALLOC.
6546 (LARGE_REQUEST): New macro, so that the issue of large requests
6547 is separated from the issue of spare memory.
6548
810928a2
AS
65492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6550
172418ad
AS
6551 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6552 format. (Bug#8806)
6553
43f862f7
AS
6554 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6555
810928a2
AS
6556 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6557 before statements.
6558
a059fe24
JD
65592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6560
6561 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6562
6563 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6564
6565 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6566 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6567
989bf368
JB
65682011-06-05 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6571
4b80f674
CY
65722011-06-04 Chong Yidong <cyd@stupidchicken.com>
6573
6574 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6575 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6576 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6577 New error handlers.
4b80f674
CY
6578 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6579 Obey Vx_select_enable_clipboard_manager. Catch errors in
6580 x_clipboard_manager_save (Bug#8779).
6581 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6582 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6583
99a33b77 65842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6585
6586 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6587
99a33b77 65882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6589
6590 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6591 in the current matrix if keep_current_p is non-zero.
6592
8264569d
EZ
65932011-06-04 Eli Zaretskii <eliz@gnu.org>
6594
6595 * bidi.c (bidi_level_of_next_char): Fix last change.
6596
57f97249
EZ
65972011-06-03 Eli Zaretskii <eliz@gnu.org>
6598
fec2107c 6599 Support bidi reordering of text covered by display properties.
57f97249 6600
fec2107c
EZ
6601 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6602 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6603 (bidi_cache_search, bidi_cache_iterator_state)
6604 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6605 (bidi_level_of_next_char, bidi_move_to_visually_next):
6606 Support character positions inside a run of characters covered by a
fec2107c
EZ
6607 display string.
6608 (bidi_paragraph_init, bidi_resolve_explicit_1)
6609 (bidi_level_of_next_char): Call bidi_fetch_char and
6610 bidi_fetch_char_advance instead of FETCH_CHAR and
6611 FETCH_CHAR_ADVANCE.
6612 (bidi_init_it): Initialize new members.
6613 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6614 definitions.
6615 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6616 instead of using explicit *_CHAR codes.
d6d100dd
SM
6617 (bidi_resolve_explicit, bidi_resolve_weak):
6618 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6619 bidirectional text is supported only in multibyte buffers.
6620 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6621 it to initialize the frame_window_p member of struct bidi_it.
6622 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6623 (bidi_resolve_explicit, bidi_resolve_weak)
6624 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6625 bidi_it->nchars is non-positive.
6626 (bidi_level_of_next_char): Don't try to lookup the cache for the
6627 next/previous character if nothing is cached there yet, or if we
6628 were just reseat()'ed to a new position.
c40e2fb2 6629
0e14fe90
EZ
6630 * xdisp.c (set_cursor_from_row): Set start and stop points
6631 according to the row's direction when priming the loop that looks
6632 for the glyph on which to display cursor.
6633 (single_display_spec_intangible_p): Function deleted.
6634 (display_prop_intangible_p): Reimplement to call
6635 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6636 Accept 3 additional arguments needed by handle_display_spec.
6637 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6638 values: lists, `(when COND...)' forms, etc.
6639 (single_display_spec_string_p): Support property values that are
6640 lists with the argument STRING its top-level element.
6641 (display_prop_string_p): Fix the condition for processing a
6642 property that is a list to be consistent with handle_display_spec.
fec2107c 6643 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6644 last portion of handle_display_prop.
6645 (compute_display_string_pos): Accept additional argument
6646 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6647 value of a `display' property is a "replacing spec".
6648 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6649 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6650 the display property, but just return a value indicating whether
6651 the display property will replace the characters it covers.
6652 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6653 frame_window_p members of struct bidi_it.
d6d100dd
SM
6654 (compute_display_string_pos, compute_display_string_end):
6655 New functions.
fec2107c
EZ
6656 (push_it): Accept second argument POSITION, where pop_it should
6657 jump to continue iteration.
6658 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6659
fec2107c
EZ
6660 * keyboard.c (adjust_point_for_property): Adjust the call to
6661 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6662
6663 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6664 (bidi_init_it): Update prototypes.
6665 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6666 (compute_display_string_pos, compute_display_string_end):
6667 Declare prototypes.
fec2107c
EZ
6668 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6669 EMACS_INT.
fc6f18ce 6670
40087514 66712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6672
57f53182
PE
6673 Malloc failure behavior now depends on size of allocation.
6674 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6675 * lisp.h: Change signatures accordingly.
6676 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6677 All callers changed. (Bug#8762)
6678
6679 * gnutls.c: Use Emacs's memory allocators.
6680 Without this change, the gnutls library would invoke malloc etc.
6681 directly, which causes problems on non-SYNC_INPUT hosts, and which
6682 runs afoul of improving memory_full behavior. (Bug#8761)
6683 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6684 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6685 xfree instead of the default malloc, realloc, free.
6686 (Fgnutls_boot): No need to check for memory allocation failure,
6687 since xmalloc does that for us.
6688
ac32cd99 6689 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6690 * category.c (hash_get_category_set):
6691 * ccl.c (ccl_driver):
6692 * charset.c (Fdefine_charset_internal):
6693 * charset.h (struct charset.hash_index):
6694 * composite.c (get_composition_id, gstring_lookup_cache)
6695 (composition_gstring_put_cache):
6696 * composite.h (struct composition.hash_index):
6697 * dispextern.h (struct image.hash):
6698 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6699 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6700 (hashfn_equal, hashfn_user_defined, make_hash_table)
6701 (maybe_resize_hash_table, hash_lookup, hash_put)
6702 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6703 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6704 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6705 * image.c (make_image, search_image_cache, lookup_image)
6706 (xpm_put_color_table_h):
6707 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6708 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6709 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6710 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6711 * alloc.c (allocate_vectorlike):
6712 Check for overflow in vector size calculations.
6713 * ccl.c (ccl_driver):
6714 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6715 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6716 need to be updated by these changes.
40087514
PE
6717 * fns.c (make_hash_table, maybe_resize_hash_table):
6718 Check for integer overflow with large hash tables.
0de4bb68
PE
6719 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6720 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6721 (SXHASH_REDUCE): New macro.
6722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6723 Use it instead of discarding useful hash info with large hash values.
6724 (sxhash_float): New function.
6725 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6726 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6727 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6728 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6729 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6730 Adjust signatures to match updated version of code.
6731 (consing_since_gc): Now EMACS_INT, since a single hash table can
6732 use more than INT_MAX bytes.
6733
698d32e2
DN
67342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6735
6736 Make it possible to build with GCC-4.6+ -O2 -flto.
6737
6738 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6739
fd6fa53f
SM
67402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6741
6742 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6743 Call minibuffer-inactive-mode.
6744
864db017
JB
67452011-05-31 Juanma Barranquero <lekktu@gmail.com>
6746
6747 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6748 Update dependencies.
6749
2ad0baf4
DN
67502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6751
6752 * data.c (init_data): Remove code for UTS, this system is not
6753 supported anymore.
6754
4fcc2638
DN
67552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6756
6757 Don't force ./temacs to start in terminal mode.
6758
6759 * frame.c (make_initial_frame): Initialize faces in all cases, not
6760 only when CANNOT_DUMP is defined.
6761 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6762
c56e0fd5
DN
67632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6764
6765 * dispnew.c (add_window_display_history): Use const for the string
6766 pointer. Remove declaration, not needed.
6767
333d54da 67682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6769
55d4c1b2 6770 Use 'inline', not 'INLINE'.
333d54da 6771 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6772 * alloc.c, fontset.c (INLINE): Remove.
6773 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6774 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6775 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6776 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6777 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6778
738db178
DN
67792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6780
6781 Make it possible to run ./temacs.
6782
6783 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6784 syms_of_callproc does the same thing. Remove test for
6785 "initialized", do it in the caller.
6786 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6787
620c53a6
SM
67882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6789
6790 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6791 (read_minibuf): Use get_minibuffer.
6792 (syms_of_minibuf): Use DEFSYM.
6793 (Qmetadata): New var.
6794 * data.c (Qbuffer): Don't make it static.
6795 (syms_of_data): Use DEFSYM.
6796
e003a292
PE
67972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6798
6799 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6800 (CCL_CODE_MIN): New macro.
6801
ed008a6d
PE
68022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6803
3687c2ef
PE
6804 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6805
ed008a6d
PE
6806 * eval.c (Qdebug): Now static.
6807 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6808 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6809 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6810
d66c4c7c
CY
68112011-05-29 Chong Yidong <cyd@stupidchicken.com>
6812
6813 * image.c: Various fixes to ImageMagick code comments.
6814 (Fimagemagick_types): Doc fix.
6815
5fbc2025
PE
68162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6817
0196f88a
PE
6818 Minor fixes prompted by GCC 4.6.0 warnings.
6819
6820 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6821
5fbc2025
PE
6822 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6823 (x_clipboard_manager_save_all): Move extern decl to ...
6824 * xterm.h: ... here, so that it can be checked for consistency.
6825
1dd3c2d9
CY
68262011-05-29 Chong Yidong <cyd@stupidchicken.com>
6827
6828 * xselect.c (x_clipboard_manager_save_frame)
6829 (x_clipboard_manager_save_all): New functions.
6830 (Fx_clipboard_manager_save): Lisp function deleted.
6831
6832 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6833 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6834
6835 * xterm.h: Update prototype.
6836
5ba6571d
WX
68372011-05-28 William Xu <william.xwl@gmail.com>
6838
6839 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6840 exiting (Bug#8239).
6841
3eaff834
JM
68422011-05-28 Jim Meyering <meyering@redhat.com>
6843
e1900994 6844 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6845 * fns.c (to_uchar): Define.
6846 (crypto_hash_function): Use it to convert some newly-signed
6847 variables to unsigned, to avoid sign-extension bugs. For example,
6848 without this change, (md5 "truc") would evaluate to
6849 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6850 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6851 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6852
0f6990a7
PE
68532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6854
6855 Integer overflow fixes.
c8a9ca5a 6856
08686060
PE
6857 * dbusbind.c: Serial number integer overflow fixes.
6858 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6859 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6860 to hold a serial number that is too large for a fixnum.
6861 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6862 Check for serial numbers out of range. Decode any serial number
59568bf0 6863 that was so large that it became a float. (Bug#8722)
08686060 6864
2d1fc3c7
PE
6865 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6866 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6867 Use XFASTINT rather than XUINT when numbers are nonnegative.
6868 (xd_append_arg, Fdbus_method_return_internal):
6869 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6870 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6871 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6872 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6873 (Bug#8722)
2d1fc3c7 6874
c8a9ca5a
PE
6875 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6876
519e1d69
PE
6877 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6878
6df6ae42 6879 ccl: Add integer overflow checks.
30569699
PE
6880 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6881 (IN_INT_RANGE): New macros.
6882 (ccl_driver): Use them to check for integer overflow when
6883 decoding a CCL program. Many of the new checks are whether XINT (x)
6884 fits in int; it doesn't always, on 64-bit hosts. The new version
6885 doesn't catch all possible integer overflows, but it's an
847044ea 6886 improvement. (Bug#8719)
30569699 6887
c11285dc
PE
6888 * alloc.c (make_event_array): Use XINT, not XUINT.
6889 There's no need for unsigned here.
6890
fdccd48e
PE
6891 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6892 This follows up to the 2011-05-06 change that substituted uintptr_t
6893 for EMACS_INT. This case wasn't caught back then.
6894
37910ab2
PE
6895 Rework Fformat to avoid integer overflow issues.
6896 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6897 now (part of C89). Include <verify.h>.
6898 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6899 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6900 (Fformat): Avoid the prepass trying to compute sizes; it was only
6901 approximate and thus did not catch overflow reliably. Instead, walk
6902 through the format just once, formatting and computing sizes as we go,
6903 checking for integer overflow at every step, and allocating a larger
6904 buffer as needed. Keep track separately whether the format is
6905 multibyte. Keep only the most-recently calculated precision, rather
6906 than them all. Record whether each argument has been converted to
6907 string. Use EMACS_INT, not int, for byte and char and arg counts.
6908 Support field widths and precisions larger than INT_MAX. Avoid
6909 sprintf's undefined behavior with conversion specifications such as %#d
6910 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6911 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6912 formatting out-of-range floating point numbers with int
9173deec 6913 formats. (Bug#8668)
37910ab2 6914
2e6578fb
PE
6915 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6916
0ae6bdee
PE
6917 * data.c: Avoid integer truncation in expressions involving floats.
6918 * data.c: Include <intprops.h>.
6919 (arith_driver): When there's an integer overflow in an expression
6920 involving floating point, convert the integers to floating point
6921 so that the resulting value does not suffer from catastrophic
6922 integer truncation. For example, on a 64-bit host (* 4
6923 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6924 Do not rely on undefined behavior after integer overflow.
6925
de883a70
PE
6926 merge count_size_as_multibyte, parse_str_to_multibyte
6927 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6928 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6929 Check for integer overflow.
6930 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6931 since it's now a duplicate of the other. This is more of
6932 a character than a buffer op, so better that it's in character.c.
6933 * fns.c, print.c: Adjust to above changes.
6934
2ff916cb
PE
69352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6936
6937 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6938
f1b54466
PE
69392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6940
fb1ac845
PE
6941 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6942 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6943 (x_clipboard_manager_save): Now static.
6944 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6945
f1b54466
PE
6946 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6947 (crypto_hash_function): Now static.
6948 Fix pointer signedness problems. Avoid unnecessary initializations.
6949
a9f737ee
CY
69502011-05-27 Chong Yidong <cyd@stupidchicken.com>
6951
6952 * termhooks.h (Vselection_alist): Make it terminal-local.
6953
6954 * terminal.c (create_terminal): Initialize it.
6955
6956 * xselect.c: Support for clipboard managers.
6957 (Vselection_alist): Move to termhooks.h as terminal-local var.
6958 (LOCAL_SELECTION): New macro.
6959 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6960 (symbol_to_x_atom): Remove gratuitous arg.
6961 (x_handle_selection_request, lisp_data_to_selection_data)
6962 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6963 (x_own_selection, x_get_local_selection, x_convert_selection):
6964 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6965 (some_frame_on_display): Delete unused function.
6966 (Fx_own_selection_internal, Fx_get_selection_internal)
6967 (Fx_disown_selection_internal, Fx_selection_owner_p)
6968 (Fx_selection_exists_p): New optional frame arg.
6969 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6970 (x_handle_selection_clear): Don't treat other terminals with the
6971 same keyboard specially. Use the terminal-local Vselection_alist.
6972 (x_clear_frame_selections): Use Frun_hook_with_args.
6973
6974 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6975
6976 * xterm.h: Add support for those atoms.
6977
e067f0c1
CY
69782011-05-26 Chong Yidong <cyd@stupidchicken.com>
6979
6980 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6981 (converted_selections, conversion_fail_tag): New global variables.
6982 (x_selection_request_lisp_error): Free the above.
6983 (x_get_local_selection): Remove unnecessary code.
6984 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6985 of converted selections stored in converted_selections.
6986 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6987 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6988 (x_convert_selection): New function.
6989 (x_handle_selection_event): Simplify.
6990 (x_get_foreign_selection): Don't ignore incoming requests while
6991 waiting for an answer; this will fail when we implement
6992 SAVE_TARGETS, and seems unnecessary anyway.
6993 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6994 (Vx_sent_selection_functions): Doc fix.
6995
0f4aebc0
LL
69962011-05-26 Leo Liu <sdl.web@gmail.com>
6997
6998 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6999
e61124cd
YM
70002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7001
7002 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7003
7004 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7005 for fringe update if it has periodic bitmap.
ac389d0c 7006 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
7007 and fringe_bitmap_periodic_p.
7008
7009 * fringe.c (get_fringe_bitmap_data): New function.
7010 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7011 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7012 row. Mark glyph row for fringe update if periodicity changed.
7013
7014 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7015 for fringe update unless it has periodic bitmap.
7016
f16d9837
KH
70172011-05-25 Kenichi Handa <handa@m17n.org>
7018
7019 * xdisp.c (get_next_display_element): Set correct it->face_id for
7020 a static composition.
7021
e1b90ef6
LL
70222011-05-24 Leo Liu <sdl.web@gmail.com>
7023
7024 * deps.mk (fns.o):
7025 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7026
7027 * fns.c (crypto_hash_function, Fsha1): New function.
7028 (Fmd5): Use crypto_hash_function.
7029 (syms_of_fns): Add Ssha1.
7030
7400048f
PE
70312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7032
7033 * gnutls.c: Remove unused macros.
7034 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7035 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7036 Remove macros that are defined and never used.
7037 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7038
abb71cf4
CY
70392011-05-22 Chong Yidong <cyd@stupidchicken.com>
7040
7041 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7042 (Fx_get_selection_internal): Minor cleanup.
7043 (Fx_own_selection_internal): Rename arguments for consistency with
7044 select.el.
7045
6307db39
PE
70462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7047
7048 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7049
f3d4e0a4
CY
70502011-05-22 Chong Yidong <cyd@stupidchicken.com>
7051
7052 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7053
4d8ade89
YM
70542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7055
7056 * dispnew.c (scrolling_window): Don't exclude the case that the
7057 last enabled row in the desired matrix touches the bottom boundary.
7058
32078c8d
GM
70592011-05-21 Glenn Morris <rgm@gnu.org>
7060
7061 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
7062 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7063 and add some more files.
32078c8d 7064
7285dc67
EZ
70652011-05-20 Eli Zaretskii <eliz@gnu.org>
7066
7067 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7068 report_file_error introduced by the change from 2011-05-07.
7069
89d1bd22
PE
70702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7071
7072 * systime.h (Time): Define only if emacs is defined.
7073 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7074 where the include path doesn't have X11/X.h by default. See
7075 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7076
cd394be1 70772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
7078
7079 * composite.c (find_automatic_composition): Fix previous change.
7080
b9704ad9
GM
70812011-05-20 Glenn Morris <rgm@gnu.org>
7082
7083 * lisp.mk: New file, split from Makefile.in.
7084 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7085 (shortlisp): Remove.
7086 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7087
4a720484
GM
70882011-05-19 Glenn Morris <rgm@gnu.org>
7089
7090 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7091 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7092 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7093 (lisp): Set the order to that of loadup.el.
7094 (shortlisp): Make it a copy of $lisp.
7095 (SOME_MACHINE_LISP): Remove.
7096 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7097 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7098
a28d4396
KH
70992011-05-18 Kenichi Handa <handa@m17n.org>
7100
7101 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7102 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7103 (find_automatic_composition): Mostly rewrite for efficiency.
7104
a2b1fa8e
JB
71052011-05-18 Juanma Barranquero <lekktu@gmail.com>
7106
7107 * makefile.w32-in: Update dependencies.
7108
8e1f5610
CS
71092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7110
7111 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 7112 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 7113
7025ee00 71142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 7115
cdfa6eab
PE
7116 Fix some integer overflow issues, such as string length overflow.
7117
06d6db33
PE
7118 * insdel.c (count_size_as_multibyte): Check for string overflow.
7119
2b4560a8
PE
7120 * character.c (lisp_string_width): Check for string overflow.
7121 Use EMACS_INT, not int, for string indexes and lengths; in
7122 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7123 the resulting string length overflows an EMACS_INT; instead,
7124 report a string overflow if no precision given. When checking for
7125 precision exhaustion, use a check that cannot possibly have
7126 integer overflow. (Bug#8675)
7127 * character.h (lisp_string_width): Adjust to new signature.
7128
cb93f9be
PE
7129 * alloc.c (string_overflow): New function.
7130 (Fmake_string): Use it. This doesn't change behavior, but saves
7131 a few bytes and will simplify future changes.
7132 * character.c (string_escape_byte8): Likewise.
7133 * lisp.h (string_overflow): New decl.
7134
1a1f3366
PE
7135 Fixups, following up to the user-interface timestamp change.
7136 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7137 for UI timestamps, instead of unsigned long.
9fbd6841
PE
7138 * msdos.c (mouse_get_pos): Likewise.
7139 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
7140 * w32gui.h (Time): Define by including "systime.h" rather than by
7141 declaring it ourselves. (Bug#8664)
7142
d4e3e4d3
PE
7143 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7144 * image.c (clear_image_cache): Likewise.
7145
f6a24d19
PE
7146 * term.c (term_mouse_position): Don't assume time_t wraparound.
7147
08dc5ae6
PE
7148 Be more systematic about user-interface timestamps.
7149 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
7150 and sometimes 'EMACS_UINT', to represent these timestamps.
7151 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
7152 This makes the code easier to follow, and makes it easier to catch
7153 integer overflow bugs such as Bug#8664.
7154 * frame.c (Fmouse_position, Fmouse_pixel_position):
7155 Use Time, not unsigned long, for user-interface timestamps.
7156 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7157 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7158 * keyboard.h (last_event_timestamp): Likewise.
7159 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7160 * menu.h (xmenu_show): Likewise.
7161 * term.c (term_mouse_position): Likewise.
7162 * termhooks.h (struct input_event.timestamp): Likewise.
7163 (struct terminal.mouse_position_hook): Likewise.
7164 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7165 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7166 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7167 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7168 what it was before.
7169 * menu.h, termhooks.h: Include "systime.h", for Time.
7170
8e55734a
PE
7171 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7172 Don't assume that the difference between two unsigned long values
7173 can fit into an integer. At this point, we know button_down_time
7174 <= event->timestamp, so the difference must be nonnegative, so
7175 there's no need to cast the result if double-click-time is
7176 nonnegative, as it should be; check that it's nonnegative, just in
7177 case. This bug is triggered when events are more than 2**31 ms
86db42d2 7178 apart (about 25 days). (Bug#8664)
8e55734a 7179
841f1b75 7180 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 7181 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 7182
3e26f69c
PE
7183 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7184 that always fit in int. Use a sentinel instead of a counter, to
7185 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
7186 * frame.h (struct frame): Use int for menu_bar_items_used
7187 instead of EMACS_INT, since it always fits in int.
3e26f69c 7188
5cc152c0
PE
7189 * menu.c (grow_menu_items): Check for int overflow.
7190
d89eb65e
PE
7191 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7192
5235bd3e
PE
7193 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7194 Before, the code was not consistent. These values cannot exceed
7195 2**31 - 1 so there's no need to make them unsigned.
7196 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7197 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7198 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7199 as modifiers.
7200 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7201
bc827e23
PE
7202 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7203 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7204 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7205 presumably because the widths might not match.
7206
78eb494e
PE
7207 * window.c (size_window): Avoid needless test at loop start.
7208
04f2d78b
CB
72092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7210
7211 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7212
d2fc7e3d 72132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
7214
7215 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7216
d2fc7e3d 72172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
7218
7219 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7220 `width' to `bar_area_x' and `bar_area_width', respectively.
7221 (x_scroll_run): Take account of fringe background extension.
7222
04f2d78b
CB
7223 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7224 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
7225 `bar_area_width', respectively.
7226 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7227 background extension.
7228
79b70037
GM
72292011-05-10 Jim Meyering <meyering@redhat.com>
7230
7231 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7232
2f142cc5
JB
72332011-05-10 Juanma Barranquero <lekktu@gmail.com>
7234
7235 * image.c (Finit_image_library): Return t for built-in image types,
7236 like pbm and xbm. (Bug#8640)
7237
57679c86
AS
72382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7239
7240 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7241
888c9e86
EZ
72422011-05-07 Eli Zaretskii <eliz@gnu.org>
7243
b0512a1d
EZ
7244 * w32console.c (Fset_screen_color): Doc fix.
7245 (Fget_screen_color): New function.
7246 (syms_of_ntterm): Defsubr it.
7247
7285dc67
EZ
7248 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7249 unlink the temporary file if Fcall_process didn't create it in the
7250 first place.
7251 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7252 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
7253 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7254 cue to call_process_cleanup not to close that handle.
7255
4d3fcc8e
BK
72562011-05-07 Ben Key <bkey76@gmail.com>
7257
7258 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7259 one of two shell specific rules, either bootstrap-temacs-CMD or
7260 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7261 to the previous implementation of the bootstrap-temacs rule.
7262 The bootstrap-temacs-CMD rule is similar to the previous
7263 implementation of the bootstrap-temacs rule except that it
7264 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7265 variable.
7266
7267 These changes, along with some changes to nt/configure.bat,
7268 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7269 earlier fix to add support for --cflags and --ldflags options
7270 that include quotes so that it works whether make uses cmd or
7271 sh as the shell.
7272
b4289b64
MA
72732011-05-06 Michael Albinus <michael.albinus@gmx.de>
7274
7275 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7276 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7277 is a constant.
7278 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7279 a string. Handle both cases.
7280 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7281 (Fdbus_register_method): Use Qinvalid_function.
7282
af4c0e28
JB
72832011-05-06 Juanma Barranquero <lekktu@gmail.com>
7284
7285 * makefile.w32-in: Update dependencies.
7286 (LISP_H): Add inttypes.h and stdin.h.
7287 (PROCESS_H): Add unistd.h.
7288
c51453d9
EZ
72892011-05-06 Eli Zaretskii <eliz@gnu.org>
7290
7291 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7292 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7293
8ff0ac3c 72942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 7295
4c4b566b
PE
7296 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7297
aab2b9b5
PE
7298 * term.c (vfatal): Remove stray call to va_end.
7299 It's not needed and the C Standard doesn't allow it here anyway.
7300
c378da0b
PE
7301 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7302 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7303
288b08c7
PE
7304 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7305 bytes.
7306
e3601888
PE
7307 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7308
db6c0e74
PE
7309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7310
dd5963ea
PE
7311 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7312
88c9450f
PE
7313 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7314
2f9442b8
PE
7315 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7316
c032b5f8
PE
7317 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7318 * charset.c (Fdefine_charset_internal): Don't initialize
7319 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 7320 32-bit int (Bug#8600).
a108c10b
PE
7321
7322 * lread.c (read_integer): Be more consistent with string-to-number.
7323 Use string_to_number to do the actual conversion; this avoids
7324 rounding errors and fixes some other screwups. Without this fix,
7325 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7326 (digit_to_number): Move earlier, for benefit of read_integer.
7327 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 7328 not a digit in any supported base. (Bug#8602)
a108c10b 7329
ad5f9eea
PE
7330 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7331
aec1708a
PE
7332 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7333 to match comment at start of function. This also removes a
7334 GCC warning about overflow in a 32+64-bit port.
7335
47be4ab5
PE
7336 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7337
371cac43
PE
7338 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7339 Reported by Stefan Monnier in
7340 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
7341 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7342 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 7343
d01a7826
PE
7344 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7345 (EMACS_UINTPTR): Likewise, with uintptr_t.
7346
7fd47d5c
PE
7347 * lisp.h: Prefer 64-bit EMACS_INT if available.
7348 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7349 on 32-bit hosts that have 64-bit int, so that they can access
7350 large files.
122b0c86
PE
7351 However, temporarily disable this change unless the temporary
7352 symbol WIDE_EMACS_INT is defined.
7fd47d5c 7353
8727937b
PE
7354 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7355
8ac068ac
PE
7356 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7357 This removes an assumption that EMACS_INT and long are the same
7358 width as pointers. The assumption is true for Emacs porting targets
7359 now, but we want to make other targets possible.
7360 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7361 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7362 In the rest of the code, change types of integers that hold casted
7363 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7364 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7365 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7366 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7367 No need to cast type when ORing.
7368 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7369 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7370 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7371 assume EMACS_INT is the same width as char *.
7372 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7373 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7374 Remove no-longer-needed casts.
7375 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7376 (xg_tool_bar_help_callback, xg_make_tool_item):
7377 Use EMACS_INTPTR to hold an integer
7378 that will be cast to void *; this can avoid a GCC warning
7379 if EMACS_INT is not the same width as void *.
7380 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7381 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7382 (current_message_1, set_message_1):
7383 Use a local to convert to proper width without a cast.
7384 * xmenu.c (dialog_selection_callback): Likewise.
7385
ede49d71
PE
7386 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7387 Also, don't assume VALBITS / RAND_BITS is less than 5,
7388 and don't rely on undefined behavior when shifting a 1 left into
7389 the sign bit.
7390 * lisp.h (get_random): Change signature to match.
7391
2f30ecd0
PE
7392 * lread.c (hash_string): Use size_t, not int, for hash computation.
7393 Normally we prefer signed values; but hashing is special, because
7394 it's better to use unsigned division on hash table sizes so that
7395 the remainder is nonnegative. Also, size_t is the natural width
7396 for hashing into memory. The previous code used 'int', which doesn't
7397 retain enough info to hash well into very large tables.
7398 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7399
2a866e7b
PE
7400 * dbusbind.c: Don't possibly lose pointer info when converting.
7401 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7402 Use XPNTR rather than XHASH, so that the high-order bits of
7403 the pointer aren't lost when converting through void *.
7404
51639eac
PE
7405 * eval.c (Fautoload): Don't double-shift a pointer.
7406
92394119
PE
7407 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7408
dbdb9a7c
JB
74092011-05-06 Juanma Barranquero <lekktu@gmail.com>
7410
7411 * gnutls.c (DEF_GNUTLS_FN):
7412 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7413
db7a0b4f
AS
74142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7415
7416 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7417 marker. (Bug#8610)
7418
cd394be1 74192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
7420
7421 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7422 New version that can reserve upto 2GB of heap space.
7423
f7ff1b0f 74242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
7425
7426 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7427
639c109b
TZ
74282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7429
7430 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7431 `gnutls_certificate_set_x509_key_file'.
7432
d2127135
JB
74332011-05-05 Juanma Barranquero <lekktu@gmail.com>
7434
7435 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7436 Update dependencies.
7437
e968f4f3
JB
74382011-05-04 Juanma Barranquero <lekktu@gmail.com>
7439
7440 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7441 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7442 Remove unused parameter `fildes'.
7443 * process.c (read_process_output, send_process): Don't pass it.
7444
84d358f0
JB
74452011-05-04 Juanma Barranquero <lekktu@gmail.com>
7446
7447 Fix previous change: the library cache is defined in w32.c.
7448 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7449 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7450
0898ca10
JB
74512011-05-04 Juanma Barranquero <lekktu@gmail.com>
7452
7453 Implement dynamic loading of GnuTLS on Windows.
7454
7455 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7456 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7457 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7458 Declare.
7459
7460 * gnutls.c (Qgnutls_dll): Define.
7461 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7462 (gnutls_*): Declare function pointers.
7463 (init_gnutls_functions): New function to initialize function pointers.
7464 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7465 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7466 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7467 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7468 (emacs_gnutls_write, emacs_gnutls_read)
7469 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7470 (Fgnutls_available_p): New function.
7471 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7472 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7473 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7474
7475 * image.c: Include w32.h.
7476 (Vimage_type_cache): Delete.
7477 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7478 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7479 (w32_delayed_load): Move to w32.c.
7480
7481 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7482
7483 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7484 (w32_delayed_load): Move from image.c. When loading a library, record
7485 its filename in the :loaded-from property of the library id.
7486 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7487 Initialize and staticpro them.
7488 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7489
7490 * process.c: Include lisp.h before w32.h, not after.
7491 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7492 instead of gnutls_record_check_pending.
7493
7494 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7495
ff4de4aa
TZ
74962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7497
7498 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7499 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7500 as passed in.
7501
abe95abb
JD
75022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7503
7504 * xterm.c (x_set_frame_alpha): Do not set property on anything
7505 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7506
e16e55d4
JB
75072011-05-02 Juanma Barranquero <lekktu@gmail.com>
7508
7509 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7510
bafcf6a5
JB
75112011-05-02 Juanma Barranquero <lekktu@gmail.com>
7512
7513 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7514 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7515 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7516 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7517 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7518 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7519 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7520 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7521 (Qgnutls_bootprop_callbacks_verify): Make static.
7522
e7a6747f
AS
75232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7524
19ed11ba
AS
7525 * callproc.c: Indentation fixup.
7526
e7a6747f 7527 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7528 (wait_for_termination, interruptible_wait_for_termination):
7529 Move after wait_for_termination_1.
e7a6747f 7530
1ef14cb4
LMI
75312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7532
7533 * sysdep.c (interruptible_wait_for_termination): New function
7534 which is like wait_for_termination, but allows keyboard
7535 interruptions.
7536
7537 * callproc.c (Fcall_process): Add (:file "file") as an option for
7538 the STDOUT buffer.
7539 (Fcall_process_region): Ditto.
7540
330d880c
EZ
75412011-04-30 Eli Zaretskii <eliz@gnu.org>
7542
8db90b73
EZ
7543 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7544 rather than `XVECTOR (FOO)->size'.
7545
330d880c
EZ
7546 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7547 inttypes.h, as a gnulib replacement is used if it not available in
7548 system headers.
7549
15cbd324
EZ
75502011-04-21 Eli Zaretskii <eliz@gnu.org>
7551
7552 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7553 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7554 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7555
7556 * coding.c (coding_alloc_by_realloc): Error out if destination
7557 will grow beyond MOST_POSITIVE_FIXNUM.
7558 (decode_coding_emacs_mule): Abort if there isn't enough place in
7559 charbuf for the composition carryover bytes. Reserve an extra
7560 space for up to 2 characters produced in a loop.
7561 (decode_coding_iso_2022): Abort if there isn't enough place in
7562 charbuf for the composition carryover bytes.
7563
75642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7565
ae940cca
EZ
7566 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7567 aborting when %lld or %lll format is passed.
7568 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7569 %llo or %llx format is passed. (Bug#8545)
7570
03ab8921
EZ
7571 * window.c (window_scroll_line_based): Use a marker instead of
7572 simple variables to record original value of point. (Bug#7952)
7573
afda1437
EZ
7574 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7575 produced by %s or %c overflows available buffer space. (Bug#8545)
7576
f76dee0c
PE
75772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7578
7579 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7580 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7581
fdc5744d
JB
75822011-04-28 Juanma Barranquero <lekktu@gmail.com>
7583
7584 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7585
638f053a
JB
75862011-04-28 Juanma Barranquero <lekktu@gmail.com>
7587
7588 * keyboard.c (Qdelayed_warnings_hook): Define.
7589 (command_loop_1): Run `delayed-warnings-hook'
7590 if Vdelayed_warnings_list is non-nil.
7591 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7592 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7593
d178f871
EZ
75942011-04-28 Eli Zaretskii <eliz@gnu.org>
7595
7596 * doprnt.c (doprnt): Don't return value smaller than the buffer
7597 size if the message was truncated. (Bug#8545).
7598
b124fd93
JB
75992011-04-28 Juanma Barranquero <lekktu@gmail.com>
7600
7601 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7602 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7603
e810457d
PE
76042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7605
7606 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7607
ea51cceb
JB
76082011-04-27 Juanma Barranquero <lekktu@gmail.com>
7609
7610 * makefile.w32-in: Update dependencies.
7611
94dcfacf
EZ
76122011-04-27 Eli Zaretskii <eliz@gnu.org>
7613
7614 Improve `doprnt' and its usage. (Bug#8545)
7615 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7616 `format_end'. Remove support for %l as a conversion specifier.
7617 Don't use xrealloc. Improve diagnostics when the %l size modifier
7618 is used. Update the commentary.
7619
7620 * eval.c (verror): Simplify calculation of size_t.
7621
7622 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7623 messages.
7624
f61f41d7
PE
76252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7626
7627 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7628 change.
7629
96fb4434
PE
76302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7631
7632 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7633 This makes this file independent of the recent pseudovector change.
7634
671875da 76352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7636
69e9b5a3
PE
7637 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7638
b5f869a7 7639 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7640 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7641 Remove unused local.
c8926152 7642 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7643
841a1577 7644 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7645 GCC 4.6.0 optimizes based on type-based alias analysis.
7646 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7647 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7648 != &v->size, and therefore "v->size = 1; b->size = 2; return
7649 v->size;" must therefore return 1. This assumption is incorrect
7650 for Emacs, since it type-puns struct Lisp_Vector * with many other
7651 types. To fix this problem, this patch adds a new type struct
f904488f 7652 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7653 and pseudovectors, and helps optimizing compilers not get fooled
7654 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7655 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7656 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7657 the size member.
eab3844f
PE
7658 (XSETPVECTYPE): Rewrite in terms of new macro.
7659 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7660 This is a bit clearer, and further avoids the possibility of
7661 undesirable aliasing.
7662 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7663 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7664 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7665 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7666 (ASIZE): Now uses header.size rather than size.
7667 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7668 to avoid the hassle of writing XVECTOR (foo)->header.size.
7669 (struct vectorlike_header): New type.
eab3844f
PE
7670 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7671 object, to help avoid aliasing.
7672 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7673 (SUBRP): Likewise, since Lisp_Subr is a special case.
7674 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7675 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7676 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7677 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7678 changed to be "header.size" and "header.next".
7679 * buffer.h (struct buffer): Likewise.
7680 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7681 * frame.h (struct frame): Likewise.
7682 * process.h (struct Lisp_Process): Likewise.
7683 * termhooks.h (struct terminal): Likewise.
7684 * window.c (struct save_window_data, struct saved_window): Likewise.
7685 * window.h (struct window): Likewise.
7686 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7687 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7688 * buffer.c (init_buffer_once): Likewise.
7689 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7690 special case.
7691 * process.c (Fformat_network_address): Use local var for size,
7692 for brevity.
7693
0df1eac5
PE
7694 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7695
847ab9d1 7696 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7697 * data.c (atof): Remove decl; no longer used or needed.
7698 (digit_to_number): Move to lread.c.
7699 (Fstring_to_number): Use new string_to_number function, to be
7700 consistent with how the Lisp reader treats infinities and NaNs.
7701 Do not assume that floating-point numbers represent EMACS_INT
7702 without losing information; this is not true on most 64-bit hosts.
7703 Avoid double-rounding errors, by insisting on integers when
7704 parsing non-base-10 numbers, as the documentation specifies.
7705 * lisp.h (string_to_number): New decl, replacing ...
7706 (isfloat_string): Remove.
bc0a5c13 7707 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7708 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7709 appears to have been a coding error. Similarly, do not accept
7710 strings like +-1e0 as floating point numbers. Do not report
7711 overflow for integer overflows unless the base is not 10 which
7712 means we have no simple and reliable way to continue.
7713 Break out the floating-point parsing into a new
7714 function string_to_number, so that Fstring_to_number parses
7715 floating point numbers consistently with the Lisp reader.
04f2d78b 7716 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7717 (E_CHAR, EXP_INT): Remove, replacing with ...
7718 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7719 (string_to_number): New function, replacing isfloat_string.
7720 This function checks for valid syntax and produces the resulting
7721 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7722 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7723 so that overflow for non-base-10 numbers is reported only when
7724 there's no portable and simple way to convert to floating point.
452f4150 7725
67769ffc
PE
7726 * textprop.c (set_text_properties_1): Rewrite for clarity,
7727 and to avoid GCC warning about integer overflow.
7728
c20db43f
PE
7729 * intervals.h (struct interval): Use EMACS_INT for members
7730 where EMACS_UINT might cause problems. See
7731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7732 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7733 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7734 All uses changed.
37aa2f85
PE
7735 (offset_intervals): Tell GCC not to worry about length overflow
7736 when negating a negative length.
c20db43f 7737
2538aa2f
PE
7738 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7739 (overrun_check_free): Likewise.
7740
f2d3008d
PE
7741 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7742 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7743 word size.
7744
ec8df744
PE
7745 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7746 (gnutls_make_error): Rename local to avoid shadowing.
7747 (gnutls_emacs_global_deinit): ifdef out; not used.
7748 (Fgnutls_boot): Use const for pointer to readonly storage.
7749 Comment out unused local. Fix pointer signedness problems.
7750
640ee02d
PE
7751 * lread.c (openp): Don't stuff size_t into an 'int'.
7752 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7753 about possible signed overflow.
7754
6048fb2a
PE
7755 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7756 (GDK_KEY_g): Don't define if already defined.
7757 (xg_prepare_tooltip): Avoid pointer signedness problem.
7758 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7759
fa3c87e1
PE
7760 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7761 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7762
2172544b
PE
7763 * xfns.c (Fx_window_property): Simplify a bit,
7764 to make a bit faster and to avoid GCC 4.6.0 warning.
7765 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7766
9b821a21
PE
7767 * fns.c (internal_equal): Don't assume size_t fits in int.
7768
3c616cfa
PE
7769 * alloc.c (compact_small_strings): Tighten assertion a little.
7770
c2982e87
PE
7771 Replace pEd with more-general pI, and fix some printf arg casts.
7772 * lisp.h (pI): New macro, generalizing old pEd macro to other
7773 conversion specifiers. For example, use "...%"pI"d..." rather
7774 than "...%"pEd"...".
7775 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7776 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7777 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7778 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7779 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7780 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7781 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7782 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7783 64-bit hosts.
7784 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7785 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7786 * print.c (safe_debug_print, print_object): Likewise.
7787 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7788 to int.
6f04d126
PE
7789 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7790 avoiding the 0 flag, which is not portable.
c2982e87
PE
7791 * process.c (Fmake_network_process): Use pI to avoid cast.
7792 * region-cache.c (pp_cache): Likewise.
7793 * xdisp.c (decode_mode_spec): Likewise.
7794 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7795 behavior on 64-bit hosts with printf arg.
6f04d126 7796 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7797 (x_stop_queuing_selection_requests): Likewise.
7798 (x_get_window_property): Don't truncate byte count to an 'int'
7799 when tracing.
0b432f21 7800
5e073ec7
PE
7801 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7802 here, since it parses constructs like leading '-' and spaces,
7803 which are not wanted; and it overflows with large numbers.
7804 Instead, simply match F[0-9]+, which is what is wanted anyway.
7805
36372bf9
PE
7806 * alloc.c: Remove unportable assumptions about struct layout.
7807 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7808 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7809 (allocate_vectorlike, make_pure_vector): Use the new macros,
7810 plus offsetof, to remove unportable assumptions about struct layout.
7811 These assumptions hold on all porting targets that I know of, but
7812 they are not guaranteed, they're easy to remove, and removing them
7813 makes further changes easier.
7814
0b432f21
PE
7815 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7816 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7817 (string_overrun_cookie): Now const. Use initializers that
7818 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7819 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7820 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7821 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7822 multiple of sizeof (EMACS_INT); it need not be, if
7823 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7824 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7825
895009e1
JB
78262011-04-26 Juanma Barranquero <lekktu@gmail.com>
7827
7828 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7829
6a7a1b0b
TZ
78302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7831
7832 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7833 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7834 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7835
841a1577 78362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7837
7838 * lisp.h (Qdebug): List symbol.
895009e1 7839 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7840 * keyboard.c (debug-on-event): New variable.
7841 (handle_user_signal): Break into debugger when debug-on-event
7842 matches the current signal symbol.
7843
f2d3ba6f
DN
78442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7845
7846 * alloc.c (check_sblock, check_string_bytes)
7847 (check_string_free_list): Convert to standard C.
7848
42ce4c63
TZ
78492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7850
7851 * w32.c (emacs_gnutls_push): Fix typo.
7852
825cd63c
EZ
78532011-04-25 Eli Zaretskii <eliz@gnu.org>
7854
fb11d64d
EZ
7855 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7856 "cast to pointer from integer of different size".
7857
825cd63c
EZ
7858 Improve doprnt and its use in verror. (Bug#8545)
7859 * doprnt.c (doprnt): Document the set of format control sequences
7860 supported by the function. Use SAFE_ALLOCA instead of always
7861 using `alloca'.
7862
7863 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7864 is one byte too soon. Don't use xrealloc; instead xfree and
7865 xmalloc anew.
7866
e061a11b
TZ
78672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7868
7869 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7870 callbacks stage.
7871
7872 * gnutls.c: Renamed global_initialized to
7873 gnutls_global_initialized. Added internals for the
7874 :verify-hostname-error, :verify-error, and :verify-flags
7875 parameters of `gnutls-boot' and documented those parameters in the
7876 docstring. Start callback support.
9173deec
JB
7877 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7878 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7879 on error. Return error code.
e061a11b
TZ
7880 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7881 (emacs_gnutls_read): Likewise.
7882 (Fgnutls_boot): Return handshake error code.
7883 (emacs_gnutls_handle_error): New function.
7884 (wsaerror_to_errno): Likewise.
7885
7886 * w32.h (emacs_gnutls_pull): Add prototype.
7887 (emacs_gnutls_push): Likewise.
7888
7889 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7890 (emacs_gnutls_push): Likewise.
7891
78922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7893
7894 * process.c (wait_reading_process_output): Check if GnuTLS
7895 buffered some data internally if no FDs are set for TLS
7896 connections.
7897
7898 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7899 (LIBS): Link to USER_LIBS.
7900 ($(BLD)/gnutls.$(0)): New target.
7901
fa6996bc
EZ
79022011-04-24 Eli Zaretskii <eliz@gnu.org>
7903
eb35682e
EZ
7904 * xdisp.c (handle_single_display_spec): Rename the
7905 display_replaced_before_p argument into display_replaced_p, to
7906 make it consistent with the commentary. Fix typos in the
7907 commentary.
7908
e2ad650c
EZ
7909 * textprop.c (syms_of_textprop): Remove dead code.
7910 (copy_text_properties): Delete obsolete commentary about an
7911 interface that was deleted long ago. Fix typos in the description
7912 of arguments.
7913
1b2de274
EZ
7914 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7915 to changes in oldXMenu/XMenu.h from 2011-04-16.
7916 <menu_help_message, prev_menu_help_message>: Constify.
7917 (IT_menu_make_room): menu->help_text is now `const char **';
7918 adjust.
7919
7920 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7921 to changes in oldXMenu/XMenu.h from 2011-04-16.
7922 (struct XMenu): Declare `help_text' `const char **'.
7923
7924 * xfaces.c <Qunspecified>: Make extern again.
7925
7926 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 7927 required by POSIX.
1b2de274 7928
762b15be
EZ
7929 * doc.c (get_doc_string): Improve the format passed to `error'.
7930
7931 * doprnt.c (doprnt): Improve commentary.
7932
7933 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7934
7935 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7936 them with etags.
7937
f1052e5d
EZ
7938 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7939 changes in globals.h immediately force recompilation.
762b15be
EZ
7940 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7941 $(CURDIR)/s/ms-w32.h.
7942 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7943
fa6996bc
EZ
7944 * character.c (Fchar_direction): Function deleted.
7945 (syms_of_character): Don't defsubr it.
7946 <char-direction-table>: Deleted.
7947
e6c3da20
EZ
79482011-04-23 Eli Zaretskii <eliz@gnu.org>
7949
7950 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7951 * doprnt.c: Include limits.h.
7952 (SIZE_MAX): New macro.
04f2d78b
CB
7953 (doprnt): Return a size_t value. 2nd arg is now size_t.
7954 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7955 Improve overflow protection. Support `l' modifier for integer
7956 conversions. Support %l conversion. Don't assume an EMACS_INT
7957 argument for integer conversions and for %c.
7958
7959 * lisp.h (doprnt): Restore prototype.
7960
7961 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7962 $(SRC)/character.h.
7963
7964 * Makefile.in (base_obj): Add back doprnt.o.
7965
7966 * deps.mk (doprnt.o): Add back prerequisites.
7967 (callint.o): Depend on character.h.
7968
7969 * eval.c (internal_lisp_condition_case): Include the handler
7970 representation in the error message.
7971 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7972 when breaking from the loop.
7973
7974 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7975
7976 * callint.c (Fcall_interactively): When displaying error message
7977 about invalid control letter, pass the character's codepoint, not
7978 a pointer to its multibyte form. Improve display of the character
7979 in octal and display also its hex code.
7980
7981 * character.c (char_string): Use %x to display the (unsigned)
7982 codepoint of an invalid character, to avoid displaying a bogus
7983 negative value.
7984
7985 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7986 `error', not SYMBOL_NAME itself.
7987
7988 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7989 character arguments to `error'.
7990
7991 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7992 to `error' in error message about FINAL_CHAR argument. Make sure
7993 FINAL_CHAR is a character, and use %c when it is passed as
7994 argument to `error'.
7995
4ffd0d6b 79962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7997
7998 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7999
8000 * w32.c: Include <time.h>.
8001 (sys_localtime): New function.
8002
4ffd0d6b 80032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
8004
8005 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8006
4ffd0d6b 8007 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 8008
4ffd0d6b 80092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 8010
4ffd0d6b
GM
8011 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8012 zombies (Bug#8467).
aac0c6e3 8013
04c56954
EZ
80142011-04-19 Eli Zaretskii <eliz@gnu.org>
8015
8016 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8017 gl_state.e_property when gl_state.object is Qt.
8018
8019 * insdel.c (make_gap_larger): Remove limitation of buffer size
8020 to <= INT_MAX.
8021
16a43933
CY
80222011-04-18 Chong Yidong <cyd@stupidchicken.com>
8023
8024 * xdisp.c (lookup_glyphless_char_display)
8025 (produce_glyphless_glyph): Handle cons cell entry in
8026 glyphless-char-display.
8027 (Vglyphless_char_display): Document it.
8028
8029 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8030 glyphless-char-display.
8031
4581706e
CY
80322011-04-17 Chong Yidong <cyd@stupidchicken.com>
8033
8034 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8035
8036 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8037
8038 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8039 definition for no-X builds.
8040
4887c6e2 80412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 8042
fd35b6f9
PE
8043 Static checks with GCC 4.6.0 and non-default toolkits.
8044
5c1ccb01
PE
8045 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8046
006c5daa
PE
8047 * process.c (keyboard_bit_set): Define only if SIGIO.
8048 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8049 (send_process): Repair possible setjmp clobbering.
8050
efc736d3
PE
8051 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8052
4e2fe2e6
PE
8053 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8054
f97334a2
PE
8055 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8056
4e75f29d
PE
8057 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8058 Define only if needed.
8059
90efadd1
PE
8060 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8061 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 8062 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 8063
3c647824
PE
8064 * dispextern.h (struct redisplay_interface): Rename param
8065 to avoid shadowing.
e264f262 8066 * termhooks.h (struct terminal): Likewise.
761383f4 8067 * xterm.c (xembed_send_message): Likewise.
3c647824 8068
b58c5c4a
PE
8069 * insdel.c (make_gap_smaller): Define only if
8070 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8071
cad59032
PE
8072 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8073 it.
8074
c339dc2e
PE
8075 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8076 so that we aren't warned about unused symbols.
8077
91a3e27b
PE
8078 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8079
399c71d3 8080 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 8081
8ffc96f5
PE
8082 * xfns.c (x_real_positions): Mark locals as initialized.
8083
eef9bc79
PE
8084 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8085
098db9dd
PE
8086 * xterm.c: Fix problems found by static analysis with other toolkits.
8087 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
8088 (x_dispatch_event): Declare static if USE_GTK, and
8089 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 8090 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 8091 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
8092 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8093 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 8094
eb18f6cc
PE
8095 * xmenu.c (menu_help_callback): Pointer type fixes.
8096 Use const pointers when pointing at readonly data. Avoid pointer
8097 signedness clashes.
8098 (FALSE): Remove unused macro.
8099 (update_frame_menubar): Remove unused decl.
8100
1fe72bf8
PE
8101 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8102
60d9e1db
PE
8103 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8104 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8105 (single_menu_item): Rename local to avoid shadowing.
8106
39261c26
PE
8107 * keyboard.c (make_lispy_event): Remove unused local var.
8108
018c5e19
PE
8109 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8110 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8111
63d2b86e
PE
8112 * bitmaps: Change bitmaps from unsigned char back to the X11
8113 compatible char. Avoid the old compiler warnings about
8114 out-of-range initializers by using, for example, '\xab' rather
8115 than 0xab.
8116
aefd87e1
PE
8117 * xgselect.c (xgselect_initialize): Check vs interface
8118 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8119
bf501fb9
PE
8120 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8121
e9829fdf
PE
8122 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8123 to read-only memory.
8124
1086c095
PE
8125 * fns.c (vector): Remove; this old hack is no longer needed.
8126
2baccd04 8127 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 8128 Remove unused var.
dde42981 8129 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8130
72391843 8131 * xrdb.c (x_load_resources): Omit unused local.
3565b346 8132
436c16df 8133 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 8134 (x_window): Rename locals to avoid shadowing.
dc5ddd85 8135 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 8136
92bb796d 8137 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 8138 (x_term_init): Remove local to avoid shadowing.
92bb796d 8139
764430a3 8140 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
8141
8142 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8143 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8144
d1dfb56c
EZ
81452011-04-16 Eli Zaretskii <eliz@gnu.org>
8146
c4354cb4
EZ
8147 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8148
d1dfb56c
EZ
8149 Fix regex.c, syntax.c and friends for buffers > 2GB.
8150 * syntax.h (struct gl_state_s): Declare character position members
8151 EMACS_INT.
8152
8153 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8154
04f2d78b
CB
8155 * textprop.c (verify_interval_modification, interval_of):
8156 Declare arguments EMACS_INT.
d1dfb56c
EZ
8157
8158 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8159 EMACS_INT.
8160
8161 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8162
8163 * indent.c (Fvertical_motion): Local variable it_start is now
8164 EMACS_INT.
8165
8166 * regex.c (re_match, re_match_2, re_match_2_internal)
8167 (bcmp_translate, regcomp, regexec, print_double_string)
8168 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8169 (re_compile_pattern, re_exec): Declare arguments and local
8170 variables `size_t' and `ssize_t' and return values `regoff_t', as
8171 appropriate.
8172 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8173 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8174 <compile_stack_type>: `size' and `avail' are now `size_t'.
8175
8176 * regex.h <regoff_t>: Use ssize_t, not int.
8177 (re_search, re_search_2, re_match, re_match_2): Arguments that
8178 specify buffer/string position and length are now ssize_t and
8179 size_t. Return type is regoff_t.
8180
613052cd
BK
81812011-04-16 Ben Key <bkey76@gmail.com>
8182
8183 * nsfont.m: Fixed bugs in ns_get_family and
8184 ns_descriptor_to_entity that were caused by using free to
8185 deallocate memory blocks that were allocated by xmalloc (via
8186 xstrdup). This caused Emacs to crash when compiled with
8187 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8188 --enable-checking=xmallocoverrun). xfree is now used to
8189 deallocate these memory blocks.
8190
4170f62f 81912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 8192
71b41406
PE
8193 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8194
9587a89d
PE
8195 emacs_write: Accept and return EMACS_INT for sizes.
8196 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8197 et seq.
8198 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8199 Accept and return EMACS_INT.
8200 (emacs_gnutls_write): Return the number of bytes written on
8201 partial writes.
8202 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
8203 (emacs_read, emacs_write): Remove check for negative size, as the
8204 Emacs source code has been audited now.
9587a89d
PE
8205 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8206 (emacs_read, emacs_write): Use it.
273a5f82
PE
8207 * process.c (send_process): Adjust to the new signatures of
8208 emacs_write and emacs_gnutls_write. Do not attempt to store
8209 a byte offset into an 'int'; it might overflow.
9587a89d 8210 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 8211
3e047f51
PE
8212 * sound.c: Don't assume sizes fit in 'int'.
8213 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 8214 Return EMACS_INT, not int.
3e047f51 8215 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
8216 Accept EMACS_INT, not int.
8217 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
8218 record read return values.
8219
cc39a9db
BK
82202011-04-15 Ben Key <bkey76@gmail.com>
8221
c9d0ec6d
JB
8222 * keyboard.c (Qundefined): Don't declare static since it is used
8223 in nsfns.m.
8224 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8225 static since they are used in nsfont.m.
cc39a9db 8226
6c60eb9f
SM
82272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8228
8229 * process.c (Qprocessp): Don't declare static.
8230 * lisp.h (Qprocessp): Declare again.
8231
7990b61a
JB
82322011-04-15 Juanma Barranquero <lekktu@gmail.com>
8233
8234 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8235
5d4cb038
PE
82362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8237
8bd7b830 8238 Improve C-level modularity by making more things 'static'.
cd64ea1d 8239
e3b27b31
PE
8240 Don't publish debugger-only interfaces to other modules.
8241 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8242 (verify_bytepos, count_markers): Move decls to the only modules
8243 that need them.
8244 * region-cache.h (pp_cache): Likewise.
8245 * window.h (check_all_windows): Likewise.
8246 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8247
5d4cb038
PE
8248 * sysdep.c (croak): Now static, if
8249 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8250 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
8251
8252 * alloc.c (refill_memory_reserve): Now static if
8253 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8254 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 8255
e87b6180
PE
8256 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8257 Define only if USE_LUCID.
8258
ac64929e
PE
8259 * xrdb.c (x_customization_string, x_rm_string): Now static.
8260
6f37259d
PE
8261 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8262 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8263
1683e3ab
PE
8264 * xdisp.c (draw_row_with_mouse_face): Now static.
8265 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8266
de9c2632
PE
8267 * window.h (check_all_windows): Mark externally visible.
8268
2b96acb7
PE
8269 * window.c (window_deletion_count): Now static.
8270
8271 * undo.c: Make symbols static if they're not exported.
8272 (last_undo_buffer, last_boundary_position, pending_boundary):
8273 Now static.
8274
50436f33
PE
8275 * textprop.c (interval_insert_behind_hooks): Now static.
8276 (interval_insert_in_front_hooks): Likewise.
8277
64520e5c
PE
8278 * term.c: Make symbols static if they're not exported.
8279 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8280 (max_frame_lines, tty_set_terminal_modes):
8281 (tty_reset_terminal_modes, tty_turn_off_highlight):
8282 (get_tty_terminal): Now static.
8283 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8284 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 8285 HAVE_WINDOW_SYSTEM.
64520e5c
PE
8286 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8287 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8288
1fa53021
PE
8289 * sysdep.c: Make symbols static if they're not exported.
8290 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8291 Now static.
8292 (sigprocmask_set, full_mask): Remove; unused.
8293 (wait_debugging): Mark as visible.
8294 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8295 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8296
d4b43b22
PE
8297 * syntax.c (syntax_temp): Define only if !__GNUC__.
8298
b7c513d0
PE
8299 * sound.c (current_sound_device, current_sound): Now static.
8300
989b29ad
PE
8301 * search.c (searchbufs, searchbuf_head): Now static.
8302
13a55a78
PE
8303 * scroll.c (scroll_cost): Remove; unused.
8304 * dispextern.h (scroll_cost): Remove decl.
8305
de68a1fc
PE
8306 * region-cache.h (pp_cache): Mark as externally visible.
8307
40ccffa6
PE
8308 * process.c: Make symbols static if they're not exported.
8309 (process_tick, update_tick, create_process, chan_process):
8310 (Vprocess_alist, proc_buffered_char, datagram_access):
8311 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8312 (deactivate_process): Mark defn as static, as well as decl.
8313 * lisp.h (create_process): Remove decl.
8314 * process.h (chan_process, Vprocess_alist): Remove decls.
8315
ad64fc97
PE
8316 * print.c: Make symbols static if they're not exported.
8317 (print_depth, new_backquote_output, being_printed, print_buffer):
8318 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8319 (print_interval, print_number_index, initial_stderr_stream):
8320 Now static.
8321 * lisp.h (Fprinc): Remove decl.
8322 (debug_output_compilation_hack): Mark as externally visible.
8323
adddb265
PE
8324 * sysdep.c (croak): Move decl from here to syssignal.h.
8325 * syssignal.h (croak): Put it here, so the API can be checked when
8326 'croak' is called from dissociate_if_controlling_tty.
8327
1717ede2
PE
8328 * minibuf.c: Make symbols static if they're not exported.
8329 (minibuf_save_list, choose_minibuf_frame): Now static.
8330 * lisp.h (choose_minibuf_frame): Remove decl.
8331
fa5fb2bc
PE
8332 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8333
1e3890d1
PE
8334 * lread.c: Make symbols static if they're not exported.
8335 (read_objects, initial_obarray, oblookup_last_bucket_number):
8336 Now static.
8337 (make_symbol): Remove; unused.
8338 * lisp.h (initial_obarray, make_symbol): Remove decls.
8339
8a1414fa
PE
8340 * keyboard.c: Make symbols static if they're not exported.
8341 (single_kboard, recent_keys_index, total_keys, recent_keys):
8342 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8343 (this_single_command_key_start, echoing, last_auto_save):
8344 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8345 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8346 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8347 (Vlispy_mouse_stem, double_click_count):
8348 Now static.
8349 (force_auto_save_soon): Define only if SIGDANGER.
8350 (ignore_mouse_drag_p): Now static if
8351 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8352 (print_help): Remove; unused.
8353 (stop_character, last_timer_event): Mark as externally visible.
8354 * keyboard.h (ignore_mouse_drag_p): Declare only if
8355 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8356 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8357 * lisp.h (echoing): Remove decl.
8358 (force_auto_save_soon): Declare only if SIGDANGER.
8359 * xdisp.c (redisplay_window): Simplify code, to make it more
8360 obvious that ignore_mouse_drag_p is not accessed if !defined
8361 USE_GTK && !defined HAVE_NS.
8362
93ea6e8f
PE
8363 * intervals.c: Make symbols static if they're not exported.
8364 (merge_properties_sticky, merge_interval_right, delete_interval):
8365 Now static.
8366 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8367
77382fcc
PE
8368 * insdel.c: Make symbols static if they're not exported.
8369 However, leave prepare_to_modify_buffer alone. It's never
8370 called from outside this function, but that appears to be a bug.
8371 (combine_after_change_list, combine_after_change_buffer):
4889fc82 8372 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
8373 (adjust_after_replace_noundo): Remove; unused.
8374 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 8375 (signal_before_change): Remove decls.
77382fcc 8376
9306c32e
PE
8377 * indent.c (val_compute_motion, val_vmotion): Now static.
8378
cd44d2eb
PE
8379 * image.c: Make symbols static if they're not exported.
8380 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8381 if USE_GTK.
8382 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8383 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8384
ad9a7a06
PE
8385 * fringe.c (standard_bitmaps): Now static.
8386 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8387
81626931
PE
8388 * frame.c: Make symbols static if they're not exported.
8389 (x_report_frame_params, make_terminal_frame): Now static.
8390 (get_frame_param): Now static, unless HAVE_NS.
8391 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8392 (x_get_resource_string): Remove; not used.
8393 * frame.h (make_terminal_frame, x_report_frame_params):
8394 (x_get_resource_string); Remove decls.
8395 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8396 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8397
239f9db9
PE
8398 * font.c, fontset.c: Make symbols static if they're not exported.
8399 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8400 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8401 * font.c (font_close_object): Now static.
8402 * font.h (font_close_object): Remove.
8403 * fontset.c (FONTSET_OBJLIST): Remove.
8404 (free_realized_fontset) #if-0 the body, which does nothing.
8405 (face_suitable_for_char_p): #if-0, as it's never called.
8406 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
8407 * xfaces.c (face_at_string_position):
8408 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
8409 since 0 is always ASCII.
8410
dfcf3579
PE
8411 * fns.c (weak_hash_tables): Now static.
8412
5045092b
PE
8413 * fileio.c: Make symbols static if they're not exported.
8414 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8415 (Vwrite_region_annotation_buffers): Now static.
8416
57a96f5c
PE
8417 * eval.c: Make symbols static if they're not exported.
8418 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8419 * lisp.h (backtrace_list): Remove decl.
8420
35f08c38
PE
8421 * emacs.c: Make symbols static if they're not exported.
8422 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8423 (fatal_error_code, fatal_error_signal_hook, standard_args):
8424 Now static.
8425 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8426 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8427 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8428 * lisp.h (fatal_error_signal_hook): Remove decl.
8429 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8430
f44bd759
PE
8431 * editfns.c: Move a (normally-unused) function to its only use.
8432 * editfns.c, lisp.h (get_operating_system_release): Remove.
8433 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8434 worth the hassle of breaking this out.
8435
b532497d
PE
8436 * xterm.c: Make symbols static if they're not exported.
8437 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8438 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8439 (x_destroy_window, x_delete_display):
8440 Now static.
8441 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8442 (x_mouse_leave): Remove; unused.
8443 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8444 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8445 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8446 Remove decls.
8447 (x_mouse_leave): Declare only if WINDOWSNT.
8448 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8449 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8450 USE_X_TOOLKIT.
8451
1675728f
PE
8452 * ftxfont.c: Make symbols static if they're not exported.
8453 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8454 HAVE_FREETYPE.
8455 * font.h (ftxfont_driver): Likewise.
8456
e4cebfca
PE
8457 * xfns.c: Make symbols static if they're not exported.
8458 (x_last_font_name, x_display_info_for_name):
8459 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8460 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8461 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8462 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8463 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8464 (last_show_tip_args): Now static.
8465 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8466 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8467 (x_screen_planes): Remove; unused.
8468 * dispextern.h (x_screen_planes): Remove decl.
8469
5bf46f05
PE
8470 * dispnew.c: Make symbols static if they're not exported.
8471 * dispextern.h (redraw_garbaged_frames, scrolling):
8472 (increment_row_positions): Remove.
8473 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8474 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8475 Now static.
8476 (redraw_garbaged_frames): Remove; unused.
8477
435f4c28
PE
8478 * xfaces.c: Make symbols static if they're not exported.
8479 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8480 Remove decls.
8481 * xterm.h (defined_color): Remove decls.
8482 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8483 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8484 (menu_face_changed_default, defined_color, free_realized_face):
8485 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8486 (ascii_face_of_lisp_face): Remove; unused.
8487
8524aef3
PE
8488 * xdisp.c: Make symbols static if they're not exported.
8489 * dispextern.h (scratch_glyph_row, window_box_edges):
8490 (glyph_to_pixel_coords, set_cursor_from_row):
8491 (get_next_display_element, set_iterator_to_next):
8492 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8493 (show_mouse_face): Remove decls
8494 * frame.h (message_buf_print): Likewise.
8495 * lisp.h (pop_message, set_message, check_point_in_composition):
8496 Likewise.
8497 * xterm.h (set_vertical_scroll_bar): Likewise.
8498 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8499 (message_buf_print, scratch_glyph_row, displayed_buffer):
8500 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8501 (get_next_display_element, show_mouse_face, window_box_edges):
8502 (frame_to_window_pixel_xy, check_point_in_composition):
8503 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8504 (glyph_to_pixel_coords): Remove; unused.
8505
16390cd2
PE
8506 * dired.c (file_name_completion): Now static.
8507
8508 * dbusbind.c (xd_in_read_queued_messages): Now static.
8509
a25f4dfa
PE
8510 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8511 * data.c (circular_list_error): Remove.
8512
14a9c8df
PE
8513 * commands.h (last_point_position, last_point_position_buffer):
8514 (last_point_position_window): Remove decls.
8515 * keyboard.c: Make these variables static.
8516
04f2d78b
CB
8517 * coding.h (coding, code_convert_region, encode_coding_gap):
8518 Remove decls.
74ab6df5
PE
8519 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8520 (iso_code_class, detect_coding, code_convert_region): Now static.
8521 (encode_coding_gap): Remove; unused.
8522
38dfbee1
PE
8523 * chartab.c (chartab_chars, chartab_bits): Now static.
8524
a2cb4e63
PE
8525 * charset.h (charset_iso_8859_1): Remove decl.
8526 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8527 Now static.
8528
127198fd
PE
8529 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8530 * ccl.c (Vccl_program_table): Now static.
8531 (check_ccl_update): Remove; unused.
8532
d85b608f
PE
8533 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8534 * category.h: ... from here.
8535 * category.c (check_category_table, set_category_set): Now static.
8536
31cd66f3
PE
8537 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8538 * lisp.h: Remove these decls.
8539
c358e587
PE
8540 * buffer.c (buffer_count): Remove unused var.
8541
e78aecca
PE
8542 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8543 so that it's not optimized away.
8544 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8545 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8546 exported only to the debugger.
8547
e192d7d3 8548 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8549 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8550
92470028
PE
8551 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8552 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8553 was inaccessible from Lisp.
8554 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8555 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8556
244ed907
PE
8557 alloc.c: Import and export fewer symbols, and remove unused items.
8558 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8559 is defined.
8560 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8561 it's not optimized away by whole-program optimization.
8562 (message_enable_multibyte, free_misc): Remove.
8563 (catchlist, handlerlist, mark_backtrace):
8564 Declare only if BYTE_MARK_STACK.
8565 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8566 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8567 (message_enable_multibyte): Remove decl.
8568 (free_misc, interval_free_list, float_block, float_block_index):
8569 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8570 (cons_free_list, last_marked_index):
8571 Now static.
8572 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8573 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8574 (mark_backtrace): Define only if BYTE_MARK_STACK.
8575 * xdisp.c (message_enable_multibyte): Now static.
8576
61c2b50e 8577 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8578 This makes it easier for human readers (and static analyzers)
8579 to see whether these variables are used from other modules.
8580 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8581 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8582 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8583 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8584 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8585 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8586 * xmenu.c, xselect.c:
8587 Declare Q* vars static if they are not used in other modules.
8588 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8589 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8590 Remove decls of unexported vars.
8591 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8592
95c82688
PE
8593 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8594
16a97296
PE
8595 Make Emacs functions such as Fatom 'static' by default.
8596 This makes it easier for human readers (and static analyzers)
8597 to see whether these functions can be called from other modules.
8598 DEFUN now defines a static function. To make the function external
8599 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8600 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8601 (Finit_image_library):
16a97296
PE
8602 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8603 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8604 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8605 Remove decls, since these functions are now static.
8606 (Funintern, Fget_internal_run_time): New decls, since these functions
8607 were already external.
95c82688 8608
16a97296
PE
8609 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8610 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8611 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8612 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8613 * keyboard.c, keymap.c, lread.c:
8614 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8615 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8616 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8617 Mark functions with DEFUE instead of DEFUN,
8618 if they are used in other modules.
8619 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8620 decls for now-static functions.
8621 * buffer.h (Fdelete_overlay): Remove decl.
8622 * callproc.c (Fgetenv_internal): Mark as internal.
8623 * composite.c (Fremove_list_of_text_properties): Remove decl.
8624 (Fcomposition_get_gstring): New forward static decl.
8625 * composite.h (Fcomposite_get_gstring): Remove decl.
8626 * dired.c (Ffile_attributes): New forward static decl.
8627 * doc.c (Fdocumntation_property): New forward static decl.
8628 * eval.c (Ffetch_bytecode): New forward static decl.
8629 (Funintern): Remove extern decl; now in .h file where it belongs.
8630 * fileio.c (Fmake_symbolic_link): New forward static decl.
8631 * image.c (Finit_image_library): New forward static decl.
8632 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8633 * intervals.h (Fprevious_property_change):
8634 (Fremove_list_of_text_properties): Remove decls.
8635 * keyboard.c (Fthis_command_keys): Remove decl.
8636 (Fcommand_execute): New forward static decl.
8637 * keymap.c (Flookup_key): New forward static decl.
8638 (Fcopy_keymap): Now static.
8639 * keymap.h (Flookup_key): Remove decl.
8640 * process.c (Fget_process): New forward static decl.
8641 (Fprocess_datagram_address): Mark as internal.
8642 * syntax.c (Fsyntax_table_p): New forward static decl.
8643 (skip_chars): Remove duplicate decl.
8644 * textprop.c (Fprevious_property_change): New forward static decl.
8645 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8646 Now internal.
8647 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8648 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8649
785bbd42
PE
8650 * editfns.c (Fformat): Remove unreachable code.
8651
8b913b57
AS
86522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8653
8654 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8655 change. (Bug#8496)
8656
a6744a35
EZ
86572011-04-13 Eli Zaretskii <eliz@gnu.org>
8658
8659 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8660 when at ZV. (Bug#8487)
8661
e7974947
AS
86622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8663
baad03f0
AS
8664 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8665 (Bug#8437)
8666 * keyboard.c (parse_tool_bar_item): Likewise.
8667 * sound.c (sound_cleanup, alsa_close): Likewise.
8668 * termcap.c (tgetent): Likewise.
8669 * xfns.c (x_default_font_parameter): Likewise.
8670 * xsettings.c (read_and_apply_settings): Likewise.
8671
e7974947
AS
8672 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8673 (overrun_check_free): Protoize.
8674
28272684
PE
86752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8676
8677 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8678 since callers should never pass a negative size.
8679 Change the signature to match that of plain 'read' and 'write'; see
8680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8681 * lisp.h: Update prototypes of emacs_write and emacs_read.
8682
11997c76
EZ
86832011-04-11 Eli Zaretskii <eliz@gnu.org>
8684
8685 * xdisp.c (redisplay_window): Don't try to determine the character
8686 position of the scroll margin if the window start point w->startp
e896f03c 8687 is outside the buffer's accessible region. (Bug#8468)
11997c76 8688
8a2cbd72
EZ
86892011-04-10 Eli Zaretskii <eliz@gnu.org>
8690
8691 Fix write-region and its subroutines for buffers > 2GB.
8692 * fileio.c (a_write, e_write): Modify declaration of arguments and
8693 local variables to support buffers larger than 2GB.
8694 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8695
8696 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8697 argument, local variables, and return value.
8698
8699 * lisp.h: Update prototypes of emacs_write and emacs_read.
8700
8701 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8702
4073e537 87032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8704
1ebfdcb6
PE
8705 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8706
b2ded58d
PE
8707 Fix more problems found by GCC 4.6.0's static checks.
8708
7d66342c
PE
8709 * xdisp.c (vmessage): Use a better test for character truncation.
8710
bbf47d44
PE
8711 * charset.c (load_charset_map): <, not <=, for optimization,
8712 and to avoid potential problems with integer overflow.
9248994d 8713 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8714 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8715 * editfns.c (Fformat): Likewise.
1e69125e 8716 * syntax.c (skip_chars): Likewise.
3befa583 8717
e3019616
PE
8718 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8719 This also lets GCC 4.6.0 generate slightly better loop code.
8720
becfa255
PE
8721 * callint.c (Fcall_interactively): <, not <=, for optimization.
8722 (Fcall_interactively): Count the number of arguments produced,
8723 not the number of arguments given. This is simpler and lets GCC
8724 4.6.0 generate slightly better code.
8725
dae0cd48
PE
8726 * ftfont.c: Distingish more carefully between FcChar8 and char.
8727 The previous code passed unsigned char * to a functions like
8728 strlen and xstrcasecmp that expect char *, which does not
8729 conform to the C standard.
8730 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8731 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8732 char * when the C standard requires it.
8733
76032d70
PE
8734 * keyboard.c (read_char): Remove unused var.
8735
eb3f1cc8
PE
8736 * eval.c: Port to Windows vsnprintf (Bug#8435).
8737 Include <limits.h>.
8738 (SIZE_MAX): Define if the headers do not.
8739 (verror): Do not give up if vsnprintf returns a negative count.
8740 Instead, grow the buffer. This ports to Windows vsnprintf, which
8741 does not conform to C99. Problem reported by Eli Zaretskii.
8742 Also, simplify the allocation scheme, by avoiding the need for
8743 calling realloc, and removing the ALLOCATED variable.
8744
70476b54
PE
8745 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8746
12020a9e
PE
8747 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8748 But keep the doprint source code for now, as we might revamp it
8749 and use it again (Bug#8435).
ea6c7ae6
PE
8750 * lisp.h (doprnt): Remove.
8751 * Makefile.in (base_obj): Remove doprnt.o.
8752 * deps.mk (doprnt.o): Remove.
8753
5fdb398c
PE
8754 error: Print 32- and 64-bit integers portably (Bug#8435).
8755 Without this change, on typical 64-bit hosts error ("...%d...", N)
8756 was used to print both 32- and 64-bit integers N, which relied on
8757 undefined behavior.
61bdb816 8758 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8759 * lisp.h (error, verror): Mark as printf-like functions.
8760 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8761 Report overflow in size calculations when allocating printf buffer.
8762 Do not truncate output string at its first null byte.
8763 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8764 Truncate the output at a character boundary, since vsnprintf does not
8765 do that.
8766 * charset.c (check_iso_charset_parameter): Convert internal
8767 character to string before calling 'error', since %c now has the
8768 printf meaning.
8769 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8770 overflow when computing char to be passed to 'error'. Do not
8771 pass Lisp_Object to 'error'; pass the integer instead.
8772 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8773 formatted with plain %d.
8774
b189fa66
PE
8775 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8776
bff87ef0
PE
8777 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8778
7e2cac20
PE
8779 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8780
ce4d90b5
PE
8781 * xterm.c (x_catch_errors): Remove duplicate declaration.
8782
266c9547
PE
8783 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8784
79c49ad2
PE
8785 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8786
368f4090
JM
87872011-04-10 Jim Meyering <meyering@redhat.com>
8788
8789 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8790 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8791 return ssize_t not "int", and use size_t as the buffer length.
8792 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8793 * gnutls.h: Update declarations.
8794 * process.c (read_process_output): Use ssize_t, to match.
8795 (send_process): Likewise.
8796
a32d4040
CY
87972011-04-09 Chong Yidong <cyd@stupidchicken.com>
8798
8799 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8800
8546720e 88012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8802
04f2d78b
CB
8803 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8804 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8805
8546720e
GM
8806 * xterm.c (handle_one_xevent):
8807 * xmenu.c (create_and_show_popup_menu):
8808 * xselect.c (x_decline_selection_request)
8809 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8810
0a2f5c1a 88112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8812
8813 Fix some uses of `int' instead of EMACS_INT.
8814 * search.c (string_match_1, fast_string_match)
8815 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8816 (scan_buffer, find_next_newline_no_quit)
8817 (find_before_next_newline, search_command, Freplace_match)
8818 (Fmatch_data): Make some `int' variables be EMACS_INT.
8819
8820 * xdisp.c (display_count_lines): 3rd argument and return value now
8821 EMACS_INT. All callers changed.
8822 (pint2hrstr): Last argument is now EMACS_INT.
8823
8824 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8825 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8826 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8827 (decode_coding_utf_16, decode_coding_emacs_mule)
8828 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8829 (decode_coding_ccl, decode_coding_charset)
8830 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8831 (decode_coding_iso_2022, decode_coding_emacs_mule)
8832 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8833 <char_offset, last_offset>: Declare EMACS_INT.
8834 (encode_coding_utf_8, encode_coding_utf_16)
8835 (encode_coding_emacs_mule, encode_invocation_designation)
8836 (encode_designation_at_bol, encode_coding_iso_2022)
8837 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8838 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8839 Declare EMACS_INT.
8840 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8841 (encode_invocation_designation): Last argument P_NCHARS is now
8842 EMACS_INT.
8843 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8844 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8845
8846 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8847 All users changed.
8848
8849 * ccl.c (Fccl_execute_on_string): Declare some variables
8850 EMACS_INT.
8851
8546720e 88522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8853
8854 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8855
4e19a977
CS
88562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8857
8858 * process.c (Fformat_network_address): Doc fix.
8859
87302331
R
88602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8861
ee7683eb 8862 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8863
cbb59342
CY
88642011-04-08 Chong Yidong <cyd@stupidchicken.com>
8865
8866 * keyboard.c (read_char): Call Lisp function help-form-show,
8867 instead of using internal_with_output_to_temp_buffer.
8868 (Qhelp_form_show): New var.
e0d38eeb 8869 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8870
8871 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8872
8873 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8874
e67a13ab
CY
88752011-04-06 Chong Yidong <cyd@stupidchicken.com>
8876
04f2d78b
CB
8877 * process.c (Flist_processes): Remove to Lisp.
8878 (list_processes_1): Delete.
e67a13ab 8879
973f782d
EZ
88802011-04-06 Eli Zaretskii <eliz@gnu.org>
8881
7c106b1e
EZ
8882 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8883
973f782d
EZ
8884 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8885
41cf7d1a 88862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8887
ca23cc88
PE
8888 Fix more problems found by GCC 4.6.0's static checks.
8889
f390e2d5
PE
8890 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8891
42eea0d0
PE
8892 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8893
b69769da 8894 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8895
f9541e84
PE
8896 * xdisp.c (vmessage): Mark as a printf-like function.
8897
13841b55
PE
8898 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8899
c136c10f
PE
8900 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8901
5e2d4a30
PE
8902 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8903 printf-like functions.
8904 (tiff_load): Add casts to remove these marks before passing them
8905 to system-supplied API.
8906
583f48b9
PE
8907 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8908
b25d760e
PE
8909 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8910 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8911 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8912 directly, rather than having caller test rule sign. This avoids
8913 some unnecessary tests.
8914 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8915 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8916 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8917
bc7b6697 8918 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8919 (xfont_open): Avoid unnecessary tests.
bc7b6697 8920
27ccc379
PE
8921 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8922
dcd5c89a
PE
8923 * composite.h, composite.c (composition_gstring_put_cache):
8924 Use EMACS_INT, not int, for length.
8925
b13a45c6
PE
8926 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8927 breaking out part of COMPOSITION_DECODE_RULE.
8928 (COMPOSITION_DECODE_RULE): Use it.
8929 * composite.c (get_composition_id): Remove unused local vars,
8930 by using the new macro.
8931
1e792e4d
PE
8932 * textprop.c (set_text_properties_1): Change while to do-while,
8933 since the condition is always true at first.
8934
dc6c6455 8935 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8936 (interval_deletion_adjustment): Return unsigned value.
8937 All uses changed.
dc6c6455 8938
aba7731a
PE
8939 * process.c (list_processes_1, create_pty, read_process_output):
8940 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8941 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8942 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8943 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8944 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8945
fdfc4bf3
PE
8946 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8947
fca8fe46 8948 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8949 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8950
06a0259a 8951 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8952 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8953 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8954
e7b9e80f
PE
8955 * print.c (print_error_message): Avoid int overflow.
8956
56201685
PE
8957 * font.c (font_list_entities): Redo for clarity,
8958 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8959
78834453 8960 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8961 (font_score): Avoid potential overflow in diff calculation.
78834453 8962
0bc0b309 8963 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8964 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8965
e610eaca
PE
8966 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8967
b895abce
PE
8968 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8969 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8970 can always succeed if overflow has undefined behavior.
8971
1f1d9321 8972 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8973 (wordify): Omit three unnecessary tests.
1f1d9321 8974
c59478bc
PE
8975 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8976 All callers changed. This avoids the need for an unused var.
8977
79b73827
PE
8978 * casefiddle.c (casify_region): Remove var that is set but not used.
8979
a4db5dfe
PE
8980 * dired.c (file_name_completion): Remove var that is set but not used.
8981
43aae36e
PE
8982 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8983
2a47c44d 8984 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8985 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8986
a37c69bf
PE
8987 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8988 Check for integer overflow on size calculations.
8989
328ab8e7
PE
8990 * buffer.c (Fprevious_overlay_change): Remove var that is set
8991 but not used.
8992
e5a2a5cb
PE
8993 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8994 Remove vars that are set but not used.
8d84a6eb 8995 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8996 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8997
a60e5f68
PE
8998 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8999
f661cb61 9000 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 9001 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 9002
f0397f5a
PE
9003 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9004 that are set but not used.
9005
8664db06 9006 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 9007 if XCreateBitmapFromData fails (Bug#8410).
8664db06 9008
6abdaa4a
PE
9009 * xselect.c (x_get_local_selection, x_handle_property_notify):
9010 Remove vars that are set but not used.
9011
0ce7538d 9012 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 9013 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 9014
9ae848fc
PE
9015 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9016 Remove var that is set but not used.
0b918413
PE
9017 (scroll_bar_windows_size): Now size_t, not int.
9018 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9019 Check for overflow.
9ae848fc 9020
a5a62657
PE
9021 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9022 (map_tty_color) [!defined MSDOS]: Likewise.
9023
5c5cdd39
PE
9024 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9025
66ebf983
PE
9026 * coding.c: Remove vars that are set but not used.
9027 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9028 All callers changed.
9029 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9030 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9031 (decode_coding_charset): Remove vars that are set but not used.
9032
1be4d761
PE
9033 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9034 that is set but not used.
9035
47553fa8
PE
9036 * print.c (print_object): Remove var that is set but not used.
9037
1f7196bf 9038 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
9039 The gnulib version avoids calling malloc in the usual case,
9040 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9041 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9042 * filelock.c (current_lock_owner): Likewise.
9043 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9044 * sysdep.c: Include allocator.h, careadlinkat.h.
9045 (emacs_no_realloc_allocator): New static constant.
9046 (emacs_readlink): New function.
fdb61804
PE
9047 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9048 ../lib/careadlinkat.h.
d1fdcab7 9049
f84c17c7
SM
90502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9051
9052 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9053 first non-nil return value).
9054
ef3862ad
JD
90552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9056
9057 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9058 if not defined (Bug#8403).
9059
376a7006
JB
90602011-04-02 Juanma Barranquero <lekktu@gmail.com>
9061
9062 * xdisp.c (display_count_lines): Remove parameter `start',
9063 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9064 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9065 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9066 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9067 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9068 and thereabouts. All callers changed.
9069 (get_per_char_metric): Remove parameter `f', unused since
9070 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9071
6ca3801d
JM
90722011-04-02 Jim Meyering <meyering@redhat.com>
9073
9074 do not dereference NULL upon failed strdup
9075 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9076 (ns_get_family): Likewise.
9077
d8e2b5ba
JB
90782011-04-02 Juanma Barranquero <lekktu@gmail.com>
9079
9080 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9081
8c74fcbd
JD
90822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9083
9084 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9085 later (Bug#8403).
9086
7200d79c
SM
90872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9088
03408648 9089 Add lexical binding.
7200d79c 9090
03408648
SM
9091 * window.c (Ftemp_output_buffer_show): New fun.
9092 (Fsave_window_excursion):
9093 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9094
9095 * lread.c (lisp_file_lexically_bound_p): New function.
9096 (Fload): Bind Qlexical_binding.
9097 (readevalloop): Remove `evalfun' arg.
9098 Bind Qinternal_interpreter_environment.
9099 (Feval_buffer): Bind Qlexical_binding.
9100 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9101 Mark as dynamic.
9102 (syms_of_lread): Declare `lexical-binding'.
9103
9104 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9105
9106 * keyboard.c (eval_dyn): New fun.
9107 (menu_item_eval_property): Use it.
ca105506
SM
9108
9109 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 9110
03408648
SM
9111 * fns.c (concat, mapcar1): Accept byte-code-functions.
9112
9113 * eval.c (Fsetq): Handle lexical vars.
9114 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9115 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9116 (FletX, Flet): Obey lexical binding.
9117 (Fcommandp): Handle closures.
9118 (Feval): New `lexical' arg.
9119 (eval_sub): New function extracted from Feval. Use it almost
9120 everywhere where Feval was used. Look up vars in lexical env.
9121 Handle closures.
9122 (Ffunctionp): Move from subr.el.
9123 (Ffuncall): Handle closures.
9124 (apply_lambda): Remove `eval_flags'.
9125 (funcall_lambda): Handle closures and new byte-code-functions.
9126 (Fspecial_variable_p): New function.
9127 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9128 but without exporting it to Lisp.
23aba0ea 9129
23aba0ea 9130 * doc.c (Fdocumentation, store_function_docstring):
03408648 9131 * data.c (Finteractive_form): Handle closures.
23aba0ea 9132
03408648
SM
9133 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9134 interactive spec.
ba83908c 9135
04f2d78b
CB
9136 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9137 New byte-codes.
03408648
SM
9138 (exec_byte_code): New function extracted from Fbyte_code to handle new
9139 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 9140
03408648 9141 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 9142
03408648 9143 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 9144
e2abce01
JB
91452011-03-31 Juanma Barranquero <lekktu@gmail.com>
9146
9147 * xdisp.c (redisplay_internal): Fix prototype.
9148
63696a73 91492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 9150
63696a73 9151 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
9152 (try_scrolling): Use it when setting scroll_limit.
9153 Limit scrolling to 100 screen lines.
63696a73
EZ
9154 (redisplay_window): Even when falling back on "recentering",
9155 position point in the window according to scroll-conservatively,
9156 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9157
9158 (try_scrolling): When point is above the window, allow searching
9159 as far as scroll_max, or one screenful, to compute vertical
9160 distance from PT to the scroll margin position. This prevents
9161 try_scrolling from unnecessarily failing when
9162 scroll-conservatively is set to a value slightly larger than the
9163 window height. Clean up the case of PT below the margin at bottom
9164 of window: scroll_max can no longer be INT_MAX. When aggressive
9165 scrolling is in use, don't let point enter the opposite scroll
9166 margin as result of the scroll.
9167 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
9168 threshold of 100 lines for never-recentering scrolling.
9169
e4cc2dfc
JB
91702011-03-31 Juanma Barranquero <lekktu@gmail.com>
9171
9172 * dispextern.h (move_it_by_lines):
9173 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9174 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9175 (message_log_check_duplicate): Remove parameters `prev_bol' and
9176 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9177 (redisplay_internal): Remove parameter `preserve_echo_area',
9178 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9179
9180 * indent.c (Fvertical_motion):
9181 * window.c (window_scroll_pixel_based, Frecenter):
9182 Don't pass `need_y_p' to `move_it_by_lines'.
9183
1c470562
SM
91842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9185
44f230aa
SM
9186 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9187 steal a few bits to be more compact.
9188 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9189 Remove unneeded casts.
9190
1c470562
SM
9191 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9192
888adce9
ZK
91932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9194
9195 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9196 binding" message (bug#7967).
9197
f838ed7b
PE
91982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9199
77861b95
PE
9200 Fix more problems found by GCC 4.6.0's static checks.
9201
de6dbc14
PE
9202 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9203 Remove unused local var.
9204
f838ed7b
PE
9205 * editfns.c (Fmessage_box): Remove unused local var.
9206
792c7b2b
PE
9207 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9208 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9209 Omit unused local vars.
c499e557 9210 * window.c (shrink_windows): Omit unused local var.
b01a1c29 9211 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
9212 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9213 Omit unused local var.
9214
ba0165e1
PE
9215 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9216 Don't assume string length fits in int.
32ad8845 9217 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 9218 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 9219
3c59b4c9
PE
9220 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9221 instead of alloca (Bug#8344).
9222
a3eed478 9223 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 9224 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 9225
eb4d412d
PE
9226 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9227
1658b401
PE
9228 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9229 concerns.
9230
9231 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9232
9233 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 9234
9a2c6e05
PE
9235 * keyboard.c (syms_of_keyboard): Use the same style as later
9236 in this function when indexing through an array. This also
9237 works around GCC bug 48267.
9238
03d0a109
PE
9239 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9240
44f730c8
PE
9241 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9242
fe75f926
PE
9243 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9244 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9245
ffa8c828
PE
9246 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9247 This avoids undefined behavior on integer overflow, and is a bit
9248 more convenient anyway since it is compared to a size_t variable.
9249
c5101a77
PE
9250 Variadic C functions now count arguments with size_t, not int.
9251 This avoids an unnecessary limitation on 64-bit machines, which
9252 caused (substring ...) to crash on large vectors (Bug#8344).
9253 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9254 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 9255 All variadic functions and their callers changed accordingly.
c5101a77
PE
9256 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9257 * data.c (arith_driver, float_arith_driver): Likewise.
9258 * editfns.c (general_insert_function): Likewise.
9259 * eval.c (struct backtrace.nargs, interactive_p)
9260 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9261 (funcall_lambda, mark_backtrace): Likewise.
9262 * fns.c (concat): Likewise.
9263 * frame.c (x_set_frame_parameters): Likewise.
9264 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9265 0 if not found, not -1. All callers changed.
9266
dd3f25f7
PE
9267 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9268 (stack_copy_size): Now size_t, not int.
9269 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9270
461c2ab9
JB
92712011-03-28 Juanma Barranquero <lekktu@gmail.com>
9272
9273 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9274 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9275 All callers changed.
9276
9277 * lisp.h (multibyte_char_to_unibyte):
9278 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9279 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9280 * character.h (CHAR_TO_BYTE8):
9281 * cmds.c (internal_self_insert):
9282 * editfns.c (general_insert_function):
9283 * keymap.c (push_key_description):
9284 * search.c (Freplace_match):
9285 * xdisp.c (message_dolog, set_message_1): All callers changed.
9286
f6d62986
SM
92872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9288
9289 * keyboard.c (safe_run_hook_funcall): New function.
9290 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9291 don't set the hook to nil, but remove the offending function instead.
9292 (Qcommand_hook_internal): Remove, unused.
9293 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9294 Vcommand_hook_internal.
9295
9296 * eval.c (enum run_hooks_condition): Remove.
9297 (funcall_nil, funcall_not): New functions.
9298 (run_hook_with_args): Call each function through a `funcall' argument.
9299 Remove `cond' argument, now redundant.
9300 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9301 (Frun_hook_with_args_until_failure): Adjust accordingly.
9302 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9303
1db5b1ad
JB
93042011-03-28 Juanma Barranquero <lekktu@gmail.com>
9305
9306 * dispextern.h (string_buffer_position): Remove declaration.
9307
9308 * print.c (strout): Remove parameter `multibyte', unused since
9309 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9310
9311 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9312 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9313 All callers changed.
9314
9315 * w32.c (_wsa_errlist): Use braces for struct initializers.
9316
9317 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9318 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9319 All callers changed.
9320 (string_buffer_position): Likewise. Also, make static (it's never
9321 used outside xdisp.c).
9322 (cursor_row_p): Remove parameter `w', unused since
9323 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9324 (decode_mode_spec): Remove parameter `precision', introduced during
9325 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9326 All callers changed.
9327
5ffb62aa
JD
93282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9329
9330 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9331
461c2ab9 93322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
9333
9334 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9335 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9336 (ns_update_auto_hide_menu_bar): New functions.
9337 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9338 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9339 ns_constrain_all_frames.
9340 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9341 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9342
5c380ffb
JD
93432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9344
9345 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9346
9af30bdf
GM
93472011-03-27 Glenn Morris <rgm@gnu.org>
9348
9349 * syssignal.h: Replace RETSIGTYPE with void.
9350 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9351 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9352 Replace SIGTYPE with void everywhere.
9353 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9354 * s/template.h (SIGTYPE): Remove commented out definition.
9355
e2abce01
JB
93562011-03-26 Eli Zaretskii <eliz@gnu.org>
9357
9358 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9359 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9360
f868cd8a
JB
93612011-03-26 Juanma Barranquero <lekktu@gmail.com>
9362
59eb0929
JB
9363 * w32.c (read_unc_volume): Use parameter `henum', instead of
9364 global variable `wget_enum_handle'.
9365
9366 * keymap.c (describe_vector): Remove parameters `indices' and
9367 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9368 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9369
f868cd8a
JB
9370 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9371
9372 * keyboard.c (timer_check): Remove parameter `do_it_now',
9373 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9374 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9375 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9376
9377 * keyboard.c (read_char):
9378 * w32menu.c (w32_menu_display_help):
9379 * xmenu.c (show_help_event, menu_help_callback):
9380 Adjust calls to `show_help_echo'.
9381
9382 * gtkutil.c (xg_maybe_add_timer):
9383 * keyboard.c (readable_events):
9384 * process.c (wait_reading_process_output):
9385 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9386
9387 * insdel.c (adjust_markers_gap_motion):
9388 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9389 (gap_left, gap_right): Don't call it.
9390
2ecf6fdb
CY
93912011-03-25 Chong Yidong <cyd@stupidchicken.com>
9392
9393 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9394 incurred during fontification.
9395
6b1f9ba4
JB
93962011-03-25 Juanma Barranquero <lekktu@gmail.com>
9397
9398 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9399 (DEFVAR_PER_BUFFER): Don't pass it.
9400
9401 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9402 (scrolling_window): Don't pass it.
9403
0f4a96b5
JB
94042011-03-25 Juanma Barranquero <lekktu@gmail.com>
9405
9406 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9407
9408 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9409 and `suffix'.
9410 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9411 of variables specific to SELinux and computation of `encoded_absname'.
9412
9413 * image.c (XPutPixel): Remove unused variable `height'.
9414
9415 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9416
9417 * unexw32.c (get_section_info): Remove unused variable `section'.
9418
9419 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9420 (system_process_attributes): Remove unused variable `sess'.
9421 (sys_read): Remove unused variable `err'.
9422
9423 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9424 (w32_wnd_proc): Remove unused variable `isdead'.
9425 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9426 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9427 (x_create_tip_frame): Remove unused variable `tem'.
9428
9429 * w32inevt.c (w32_console_read_socket):
9430 Remove unused variable `no_events'.
9431
9432 * w32term.c (x_draw_composite_glyph_string_foreground):
9433 Remove unused variable `width'.
9434
1149507c
JB
94352011-03-24 Juanma Barranquero <lekktu@gmail.com>
9436
9437 * w32term.c (x_set_glyph_string_clipping):
9438 Don't pass uninitialized region to CombineRgn.
9439
9c88f339
JB
94402011-03-23 Juanma Barranquero <lekktu@gmail.com>
9441
9442 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9443 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9444 (Fx_close_connection): Remove unused variable `i'.
9445
9446 * w32font.c (w32font_draw): Return number of glyphs.
9447 (w32font_open_internal): Remove unused variable `i'.
9448 (w32font_driver): Add missing initializer.
9449
9450 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9451 (fill_in_menu): Remove unused variable `items_added'.
9452
9453 * w32term.c (last_mouse_press_frame): Remove static global variable.
9454 (w32_clip_to_row): Remove unused variable `f'.
9455 (x_delete_terminal): Remove unused variable `i'.
9456
9457 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9458 (NOTHING): Remove unused static global variable.
9459 (uniscribe_check_otf): Remove unused variable `table'.
9460 (uniscribe_font_driver): Add missing initializers.
9461
dee091a3
JD
94622011-03-23 Julien Danjou <julien@danjou.info>
9463
9464 * term.c (Fsuspend_tty, Fresume_tty):
9465 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9466 * window.c (temp_output_buffer_show):
9467 * insdel.c (signal_before_change):
9468 * frame.c (Fhandle_switch_frame):
9469 * fileio.c (Fdo_auto_save):
9470 * emacs.c (Fkill_emacs):
9471 * editfns.c (save_excursion_restore):
9472 * cmds.c (internal_self_insert):
9473 * callint.c (Fcall_interactively):
9474 * buffer.c (Fkill_all_local_variables):
9475 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9476 Use Frun_hooks.
0f4a96b5 9477 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9478 unconditionally since it does the check itself.
dee091a3 9479
2c520ab5 94802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9481
c9c49752
PE
9482 Fix more problems found by GCC 4.5.2's static checks.
9483
8abc3f12
PE
9484 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9485 the first time through the loop, since we know p0 < p1 then.
9486 This also avoids a gcc -Wstrict-overflow warning.
9487
a2d26660
PE
9488 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9489 leading to a memory leak, possible in functions like
9490 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9491 of objects (Bug#8318).
a2d26660 9492
916c72e9
PE
9493 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9494 that could (at least in theory) be that large.
9495
19ab8a18
PE
9496 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9497 This is less likely to overflow, and avoids undefined behavior if
9498 overflow does occur. All callers changed. Use strtoul to scan
9499 for the unsigned long integer.
b7cbbd6f
PE
9500 (pint2hrstr): Simplify and tune code slightly.
9501 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9502
f0641eff
PE
9503 * scroll.c (do_scrolling): Work around GCC bug 48228.
9504 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9505
7f650bb9
PE
9506 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9507 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9508 (validate_x_resource_name): Simplify count usage.
9509 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9510
37dd57d1
PE
9511 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9512 fail (Bug#8306).
81e56e61 9513
699979fc 9514 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9515
401bf9b4
PE
9516 * process.c (Fmake_network_process): Use socklen_t, not int,
9517 where POSIX says socklen_t is required in portable programs.
9518 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9519 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9520 (Fmake_network_process, server_accept_connection):
9521 (wait_reading_process_output, read_process_output):
9522 Likewise.
9523
b93aacde
PE
9524 * process.c: Rename or move locals to avoid shadowing.
9525 (list_processes_1, Fmake_network_process):
9526 (read_process_output_error_handler, exec_sentinel_error_handler):
9527 Rename or move locals.
4dc343ee 9528 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9529 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9530 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9531 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9532 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9533
af8a867c 9534 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9535 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9536 Include tparam.h instead, since it declares them.
af8a867c
PE
9537 * cm.h (PC): Remove extern decl; tparam.h now does this.
9538 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9539 * terminfo.c: Include tparam.h, to check interfaces.
9540 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9541 (tparam): Adjust signature to match interface in tparam.h;
9542 this removes some undefined behavior. Check that outstring and len
9543 are zero, which they always are with Emacs.
9544 * tparam.h (PC, BC, UP): New extern decls.
9545
0248044d 9546 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9547 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9548
8ff096c1 9549 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9550 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9551 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9552 (ftfont_list): Remove unused local.
49eaafba
PE
9553 (get_adstyle_property, ftfont_pattern_entity):
9554 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9555 Rename locals to avoid shadowing.
8ff096c1 9556
e2be39f6
PE
9557 * xfont.c (xfont_list_family): Mark var as initialized.
9558
c9735e30
PE
9559 * xml.c (make_dom): Now static.
9560
8f5201ae
PE
9561 * composite.c (composition_compute_stop_pos): Rename local to
9562 avoid shadowing.
b246f932
PE
9563 (composition_reseat_it): Remove unused locals.
9564 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9565 (composition_update_it): Mark var as initialized.
11b61122
PE
9566 (find_automatic_composition): Mark vars as initialized,
9567 with a FIXME (Bug#8290).
8f5201ae 9568
760fbc2c
PE
9569 character.h: Rename locals to avoid shadowing.
9570 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9571 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9572 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9573 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9574 to avoid shadowing.
9575
ff08eb85
PE
9576 * textprop.c (property_change_between_p): Remove; unused.
9577
fc7bf025
PE
9578 * intervals.c (interval_start_pos): Now static.
9579
235d7abc
PE
9580 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9581
44f230aa
SM
9582 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9583 Rename locals to avoid shadowing.
3e7d6594 9584
50060332
PE
9585 * sound.c (wav_play, au_play, Fplay_sound_internal):
9586 Fix pointer signedness.
d01f234b 9587 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9588 (wav_play): Initialize a variable to 0, to prevent undefined
9589 behavior (Bug#8278).
50060332 9590
c4fc4e30
PE
9591 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9592
918436ed
PE
9593 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9594
c939f91b
PE
9595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9596 clobbering (Bug#8298).
b9c7f648
PE
9597 * sysdep.c (sys_subshell): Likewise.
9598 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9599
6bd8c144
PE
9600 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9601 This should get cleaned up, so that child_setup has the
9602 same signature on all platforms.
9603
7710357c 9604 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9605 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9606
c59da222
CY
96072011-03-22 Chong Yidong <cyd@stupidchicken.com>
9608
9609 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9610 not to be necessary, and produces flickering.
9611
66b87493
GM
96122011-03-20 Glenn Morris <rgm@gnu.org>
9613
9614 * config.in: Remove file.
9615
45b6f6d5
JB
96162011-03-20 Juanma Barranquero <lekktu@gmail.com>
9617
9618 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9619 are now in src/globals.h.
9620 (syms_of_minibuf): Remove spurious & from previous change.
9621
cd394be1 96222011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9623
9624 * minibuf.c (completing-read-function): New variable.
9625 (completing-read-default): Rename from completing-read.
9626 (completing-read): Call completing-read-function.
9627
b14e3e21
CY
96282011-03-19 Juanma Barranquero <lekktu@gmail.com>
9629
9630 * xfaces.c (Fx_load_color_file):
9631 Read color file from absolute filename (bug#8250).
9632
f2b726e6
JB
96332011-03-19 Juanma Barranquero <lekktu@gmail.com>
9634
9635 * makefile.w32-in: Update dependencies.
9636
09f6ff02
EZ
96372011-03-17 Eli Zaretskii <eliz@gnu.org>
9638
9639 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9640
29a6015a
PE
96412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9642
a3a6c54e
PE
9643 Fix more problems found by GCC 4.5.2's static checks.
9644
b766f867
PE
9645 * process.c (make_serial_process_unwind, send_process_trap):
9646 (sigchld_handler): Now static.
9647
be02381c
PE
9648 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9649 That way, the code declares only the vars that it needs.
9650 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9651 * s/cygwin.h (PTY_ITERATION): Likewise.
9652 * s/darwin.h (PTY_ITERATION): Likewise.
9653 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9654
57048744
PE
9655 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9656 * process.c (allocate_pty): Don't declare stb unless it's needed.
9657
7914961c 9658 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9659 (CONSTANTLIM): Remove; unused.
9660 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9661 Define only if needed.
7914961c 9662
b3967b18
PE
9663 * unexelf.c (unexec): Name an expression,
9664 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9665 Use a different way to cause a compilation error if anyone uses
9666 n rather than nn, a way that does not involve shadowing.
73366a00 9667 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9668
29a6015a
PE
9669 * deps.mk (unexalpha.o): Remove; unused.
9670
43cfc33e 9671 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9672 * unexec.h: New file.
ce701a33
PE
9673 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9674 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9675 Depend on unexec.h.
9676 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9677 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9678 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9679 Change as necessary to match prototype in unexec.h.
ce701a33 9680
01f44d5a
PE
9681 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9682 shadowing.
4f63c6bb 9683 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9684
a6670b0b
PE
9685 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9686 Rename locals to avoid shadowing.
9687
cef2010d 9688 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9689 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9690
d4d7173a
PE
9691 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9692
f08b802a
PE
9693 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9694 warning when compiling print.c.
9695
3ddb0639
PE
9696 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9697 instead of using an uninitialized var.
5ad03b97 9698 (font_sort_entities): Mark var as initialized.
3ddb0639 9699
170a2692
PE
9700 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9701
e663c700
PE
9702 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9703 pointers to constants.
89bc529a 9704 (font_parse_fcname): Remove unused vars.
7b81e2d0 9705 (font_delete_unmatched): Now static.
ea838e10 9706 (font_get_spec): Remove; unused.
13a547c6
PE
9707 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9708 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9709 Rename or move locals to avoid shadowing.
e663c700 9710
2a80c887 9711 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9712 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9713
1384fa33 9714 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9715 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9716
8b2c52e9
PE
9717 * alloc.c (mark_backtrace): Move decl from here ...
9718 * lisp.h: ... to here, so that it can be checked.
9719
475545b5 9720 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9721 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9722 (lisp_indirect_variable): Name an expression,
9723 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9724 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9725
b1349114 9726 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9727 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9728 Use const pointer when appropriate.
b1349114 9729
a2928364
PE
9730 * lisp.h (get_system_name, get_operating_system_release):
9731 Move decls here, to check interfaces.
9732 * process.c (get_operating_system_release): Move decl to lisp.h.
9733 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9734 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9735 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9736 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9737 (Fformat_time_string, Fencode_time, Finsert_char):
9738 (Ftranslate_region_internal, Fformat):
9739 Rename or remove local vars to avoid shadowing.
9710023e 9740 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9741
a415e694
PE
9742 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9743 avoid shadowing.
9744
8ef4622d
PE
9745 * lisp.h (eassert): Check that the argument compiles, even if
9746 ENABLE_CHECKING is not defined.
9747
946f9a5b
PE
9748 * data.c (Findirect_variable): Name an expression, to avoid
9749 gcc -Wbad-function-cast warning.
112396d6 9750 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9751 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9752 (Fmake_variable_buffer_local, Fmake_local_variable):
9753 Mark variables as initialized.
52746918 9754 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9755
e5aab7e7 9756 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9757 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9758 Rename locals to avoid shadowing.
dff45157
PE
9759 (mark_stack): Move local variables into the #ifdef region where
9760 they're used.
7bc26fdb
PE
9761 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9762 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9763 needed otherwise.
9764 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9765 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9766 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9767
e5aab7e7
PE
9768 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9769 avoids undefined behavior in theory.
9770
4da60324
PE
9771 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9772
88043301
PE
9773 Use functions, not macros, for up- and down-casing (Bug#8254).
9774 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9775 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9776 to use the following functions instead of these macros.
9777 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9778 EMACS_INT, since callers assume the returned value fits in int.
9779 (upcase1): Likewise, for UPCASE_TABLE.
9780 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9781 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9782 the race-condition problem in the old DOWNCASE.
88043301 9783
19ed5445
PE
9784 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9785 Rename locals to avoid shadowing.
9786 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9787 (regex_compile, re_search_2, re_match_2_internal):
9788 Remove unused local vars.
952db0d7
PE
9789 (FREE_VAR): Rewrite so as not to use empty "else",
9790 which gcc can warn about.
da053e48 9791 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9792 (RETALLOC_IF): Define only if needed.
9793 (WORDCHAR_P): Likewise. This one is never needed, but is used
9794 only in a comment talking about a compiler bug, so put inside
9795 the #if 0 of that comment.
9796 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9797 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9798 Remove; unused.
19ed5445 9799
1f3561e4 9800 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9801 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9802 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9803
ded6f8f7
PE
9804 * search.c (simple_search): Remove unused var.
9805
dbd37a95
PE
9806 * dired.c (compile_pattern): Move decl from here ...
9807 * lisp.h: ... to here, so that it can be checked.
9808 (struct re_registers): New forward decl.
9809
7e47afad
PE
9810 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9811
85f24f61
PE
9812 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9813 All uses changed.
9814 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9815 Rename locals to avoid shadowing.
5671df8f 9816 (Fvertical_motion): Mark locals as initialized.
85f24f61 9817
181aa2be 9818 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9819 (casify_region): Mark local as initialized.
181aa2be 9820
930d429c
PE
9821 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9822
7082eac6
PE
9823 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9824 New macros, so that the caller can use some names other than
9825 gcpro1, gcpro2, etc.
9826 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9827 of the new macros.
9828 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9829 argument, for consistency with GCPRO2_VAR, etc: it is now the
9830 prefix of the variable, not the variable itself. All uses
9831 changed.
38b2c076
PE
9832 * dired.c (directory_files_internal, file_name_completion):
9833 Rename locals to avoid shadowing.
9834
15206ed9
PE
9835 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9836 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9837 dired.c's scmp function, had undefined behavior.
9838 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9839 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9840 * buffer.h: ... to here, because these macros use current_buffer,
9841 and the new implementation with inline functions needs to have
9842 current_buffer in scope now, rather than later when the macros
9843 are used.
9844 (downcase, upcase1): New static inline functions.
9845 (DOWNCASE, UPCASE1): Reimplement using these functions.
9846 This avoids undefined behavior in expressions like
9847 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9848 from race conditions in accessing the global variables
9849 case_temp1 and case_temp2.
9850 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9851 * lisp.h (case_temp1, case_temp2): Remove their decls.
9852 * character.h (ASCII_CHAR_P): Move from here ...
9853 * lisp.h: ... to here, so that the inline functions mentioned
9854 above can use them.
9855
4a6bea26
PE
9856 * dired.c (directory_files_internal_unwind): Now static.
9857
f14b7e14
PE
9858 * fileio.c (file_name_as_directory, directory_file_name):
9859 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9860 Now static.
2893f146
PE
9861 (file_name_as_directory): Use const pointers when appropriate.
9862 (Fexpand_file_name): Likewise. In particular, newdir might
9863 point at constant storage, so make it a const pointer.
fd4ead52 9864 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9865 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9866 signedness issues.
f839df0c
PE
9867 (Fset_file_times, Finsert_file_contents, auto_save_error):
9868 Rename locals to avoid shadowing.
f14b7e14 9869
5716756e 9870 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9871 (Ftry_completion, Fall_completions): Rename or remove locals
9872 to avoid shadowing.
5716756e 9873
b4c3046a
PE
9874 * marker.c (bytepos_to_charpos): Remove; unused.
9875
b45db522
PE
9876 * lisp.h (verify_bytepos, count_markers): New decls,
9877 so that gcc does not warn that these functions aren't declared.
9878
85876d07
PE
9879 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9880 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9881 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9882 (copy_text): Remove unused local var.
85876d07 9883
03d78a21 9884 * filelock.c (within_one_second): Now static.
b3dd38ab 9885 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9886
5df8f01b
PE
9887 * buffer.c (fix_overlays_before): Mark locals as initialized.
9888 (fix_start_end_in_overlays): Likewise. This function should be
9889 simplified by using pointers-to-pointers, but that's a different
9890 matter.
b1d876f1 9891 (switch_to_buffer_1): Now static.
8f54f30a
PE
9892 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9893 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9894
a70072c9 9895 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9896 Fix pointer signedness issue.
edced198
PE
9897 (sys_subshell): Mark local as volatile if checking for lint,
9898 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9899 (MAXPATHLEN): Define only if needed.
a70072c9 9900
a0977c44
PE
9901 * process.c (serial_open, serial_configure): Move decls from here ...
9902 * systty.h: ... to here, so that they can be checked.
9903
a884fdcc
PE
9904 * fns.c (get_random, seed_random): Move extern decls from here ...
9905 * lisp.h: ... to here, so that they can be checked.
9906
604efe86 9907 * sysdep.c (reset_io): Now static.
b8950c94 9908 (wait_for_termination_signal): Remove; unused.
604efe86 9909
38fc62d9
PE
9910 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9911 (copy_keymap_item, append_key, push_text_char_description):
9912 Now static.
1004a21a 9913 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9914 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9915 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9916 (describe_map_tree):
9917 Rename locals to avoid shadowing.
38fc62d9 9918
2f2650da
PE
9919 * keyboard.c: Declare functions static if they are not used elsewhere.
9920 (echo_char, echo_dash, cmd_error, top_level_2):
9921 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9922 (read_char, kbd_buffer_get_event, make_lispy_position):
9923 (make_lispy_event, make_lispy_movement, apply_modifiers):
9924 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9925 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9926 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9927 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9928 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9929
a053e86c 9930 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9931 (mark_kboards): Move decl here ...
9932 * alloc.c (mark_kboards): ... from here.
a053e86c 9933
4752793e
PE
9934 * lisp.h (force_auto_save_soon): New decl.
9935
74f10ca7 9936 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9937 (DEFINE_DUMMY_FUNCTION): New macro.
9938 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9939 Use it.
c03cd23f
PE
9940 (main): Add casts to avoid warnings
9941 if GCC considers string literals to be constants.
74f10ca7 9942
022e70d4
PE
9943 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9944
59d6fe83
PE
9945 * dbusbind.c: Pointer signedness fixes.
9946 (xd_signature, xd_append_arg, xd_initialize):
9947 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9949 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9950 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9951
78320123
PE
9952 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9953 if GCC considers string literals to be constants.
49cebcca 9954 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9955
35ac2a97
SM
99562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9957
fb103ca9
SM
9958 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9959 (print_preprocess, print_object): New macro to fix last change.
9960
35ac2a97
SM
9961 * print.c (print_preprocess): Don't forget font objects.
9962
62973b41
JB
99632011-03-16 Juanma Barranquero <lekktu@gmail.com>
9964
9965 * emacs.c (USAGE3): Doc fixes.
9966
0e48bb22
AS
99672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9968
9969 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9970 structure.
9971
7684e57b
JB
99722011-03-14 Juanma Barranquero <lekktu@gmail.com>
9973
9974 * lisp.h (VWindow_system, Qfile_name_history):
9975 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9976 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9977 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9978
9979 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9980 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9981
9982 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9983 * w32console.c (detect_input_pending, read_input_pending)
9984 (encode_terminal_code):
9985 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9986 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9987 (w32_system_caret_y, Qfile_name_history):
9988 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9989 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9990 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9991 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9992 * w32proc.c (Qlocal, report_file_error):
9993 * w32term.c (Vwindow_system, updating_frame):
9994 * w32uniscribe.c (initialized, uniscribe_font_driver):
9995 Remove unneeded extern declarations.
9996
2aa46d6c
CY
99972011-03-14 Chong Yidong <cyd@stupidchicken.com>
9998
c96bbc66 9999 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 10000
cffc6f3b
CY
100012011-03-13 Chong Yidong <cyd@stupidchicken.com>
10002
10003 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10004 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10005 These macros can no longer be used for assignment.
10006
44f230aa
SM
10007 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10008 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
10009 (record_buffer_markers, fetch_buffer_markers): New functions for
10010 recording and fetching special buffer markers.
10011 (set_buffer_internal_1, set_buffer_temp): Use them.
10012
10013 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10014
10015 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10016
10017 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10018 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10019
10020 * xdisp.c (hscroll_window_tree):
10021 (reconsider_clip_changes): Use PT instead of BUF_PT.
10022
d251f04b
EZ
100232011-03-13 Eli Zaretskii <eliz@gnu.org>
10024
10025 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10026 $(EMACS_ROOT)/lib/intprops.h.
10027
f0c77cd1
PE
100282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10029
3eca4629
PE
10030 Fix more problems found by GCC 4.5.2's static checks.
10031
7c86ee98
PE
10032 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10033 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
10034 (xg_free_frame_widgets): Make it clear that a local variable is
10035 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
10036 (gdk_window_get_screen): Make it clear that this macro is needed
10037 only if USE_GTK_TOOLTIP.
1e5524e7
PE
10038 (int_gtk_range_get_value): New function, which avoids a diagnostic
10039 from gcc -Wbad-function-cast.
10040 (xg_set_toolkit_scroll_bar_thumb): Use it.
10041 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10042 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
10043 (get_utf8_string, xg_get_file_with_chooser):
10044 Rename locals to avoid shadowing.
10045 (create_dialog): Move locals to avoid shadowing.
7c86ee98 10046
41729b81
PE
10047 * xgselect.c (xg_select): Remove unused var.
10048
f0c77cd1
PE
10049 * image.c (four_corners_best): Mark locals as initialized.
10050 (gif_load): Initialize transparent_p to zero (Bug#8238).
10051 Mark another local as initialized.
ec6cf4c6 10052 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 10053
ce0ad53d 10054 * image.c (clear_image_cache): Now static.
d5d5a617 10055 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 10056 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
10057 (x_edge_detection): Remove unnecessary cast that
10058 gcc -Wbad-function-cast diagnoses.
2037898d 10059 (gif_load): Fix pointer signedness.
6ae141d6
PE
10060 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10061 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 10062
33383987 100632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 10064
d32df629
PE
10065 Improve quality of tests for time stamp overflow.
10066 For example, without this patch (encode-time 0 0 0 1 1
10067 1152921504606846976) returns the obviously-bogus value (-948597
10068 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10069 reports time overflow. See
10070 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
10071 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10072 * editfns.c: Include limits.h and intprops.h.
10073 (TIME_T_MIN, TIME_T_MAX): New macros.
10074 (time_overflow): Move earlier, to before first use.
10075 (hi_time, lo_time): New functions, for an accurate test for
10076 out-of-range times.
10077 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10078 (Fget_internal_run_time): Don't assume time_t fits in int.
10079 (make_time): Use list2 instead of Fcons twice.
10080 (Fdecode_time): More accurate test for out-of-range times.
10081 (check_tm_member): New function.
10082 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
10083 (lisp_time_argument): Don't rely on undefined left-shift and
10084 right-shift behavior when checking for time stamp overflow.
8be6f318 10085
fe31d94c
PE
10086 * editfns.c (time_overflow): New function, refactoring common code.
10087 (Fformat_time_string, Fdecode_time, Fencode_time):
10088 (Fcurrent_time_string): Use it.
10089
8be6f318
PE
10090 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10091 * dired.c (make_time): Move to ...
10092 * editfns.c (make_time): ... here.
10093 * systime.h: Note the move.
10094
09d9db2c 100952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 10096
126bc0dc
YM
10097 * fringe.c (update_window_fringes): Remove unused variables.
10098
c47cbdfd
YM
10099 * unexmacosx.c (copy_data_segment): Also copy __got section.
10100 (Bug#8223)
10101
7ac80be9
EZ
101022011-03-12 Eli Zaretskii <eliz@gnu.org>
10103
c96bbc66 10104 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
10105 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10106 Constify `char *' arguments and their references according to
10107 prototypes in tparam.h.
10108
ecb0f94d 10109 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 10110
7ac80be9
EZ
10111 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10112 Adapt all references accordingly.
10113
10114 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10115
ef1fd07e
TT
101162011-03-11 Tom Tromey <tromey@redhat.com>
10117
10118 * buffer.c (syms_of_buffer): Remove obsolete comment.
10119
7ef4b50c
EZ
101202011-03-11 Eli Zaretskii <eliz@gnu.org>
10121
10122 * termhooks.h (encode_terminal_code): Declare prototype.
10123
10124 * msdos.c (encode_terminal_code): Don't declare prototype.
10125
10126 * term.c (encode_terminal_code): Now external again, used by
10127 w32console.c and msdos.c.
10128
44f230aa
SM
10129 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10130 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 10131
4b1ec863 101322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 10133
1714f52b 10134 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 10135
4b1ec863
PE
10136 * fringe.c (update_window_fringes): Mark locals as initialized
10137 (Bug#8227).
10138 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 10139
524c7aa6
PE
10140 * alloc.c (mark_fringe_data): Move decl from here ...
10141 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10142 to check its interface.
10143 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10144
a5c0af81 10145 * fontset.c (free_realized_fontset): Now static.
7519b8cd 10146 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 10147 (fontset_font): Mark local as initialized.
a9a06e0b 10148 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 10149
b4716021
PE
10150 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10151
811e9bac 10152 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 10153 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
10154 (x_own_selection, Fx_disown_selection_internal): Rename locals
10155 to avoid shadowing.
10156 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 10157
7e3ab302
PE
10158 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10159 so that the caller can use some name other than gcpro1.
10160 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
10161 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10162 (Fx_backspace_delete_keys_p):
10163 Use them to avoid shadowing, and rename vars to avoid shadowing.
10164 (x_decode_color, x_set_name, x_window): Now static.
6b437900 10165 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 10166 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
10167 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10168 Remove unused locals.
7e3ab302
PE
10169 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10170 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10171 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10172 macros.
f78faa98 10173
e2b13473
PE
10174 * xterm.h (x_mouse_leave): New decl.
10175
77f23912
PE
10176 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10177 Remove unused functions.
cdf4ba58
PE
10178 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10179 (x_calc_absolute_position): Now static.
7411c686 10180 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 10181 Don't declare local "event" unless it's used.
ed7bf3a5
PE
10182 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10183 unless they are used.
38d0b34a
PE
10184 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10185 (x_fatal_error_signal): Remove; not used.
a6067996
PE
10186 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10187 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10188 (x_error_catcher, x_connection_closed, x_error_handler):
10189 (x_error_quitter, xembed_send_message, x_iconify_frame):
10190 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 10191 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 10192 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 10193
44f230aa
SM
10194 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10195 Rename or move locals to avoid shadowing.
6b463e58 10196 (tty_defined_color, merge_face_heights): Now static.
5967d051 10197 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
10198 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10199 does not deduce is never used uninitialized.
73719eba
PE
10200 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10201 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 10202
426994c3 10203 * terminal.c (store_terminal_param): Now static.
5489860b 10204
032f1620 10205 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 10206 (set_frame_menubar): Remove unused local.
d4323972 10207 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
10208 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10209 since they might point to immutable storage.
281585b0
PE
10210 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10211 since it's unused otherwise.
032f1620 10212
367c19e5 10213 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 10214 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
10215 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10216 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 10217 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
10218 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10219 does not deduce are never used uninitialized.
70739cbe 10220
07b48fa9
PE
10221 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10222
8868a238 10223 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
10224 * window.c (window_loop, size_window):
10225 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 10226
7e5cf297 10227 * window.c (display_buffer): Now static.
d6550a9f
PE
10228 (size_window): Mark variables that gcc -Wuninitialized
10229 does not deduce are never used uninitialized.
a586633d
PE
10230 * window.h (check_all_windows): New decl, to forestall
10231 gcc -Wmissing-prototypes diagnostic.
5b555da1 10232 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 10233
f6095868
PE
10234 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10235 shadowing.
10236 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
10237 Include <limits.h>.
10238 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10239 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
10240 (load_charset_map): Mark variables that gcc -Wuninitialized
10241 does not deduce are never used uninitialized.
53df7c11 10242 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 10243
f38b440c
PE
10244 * coding.c (coding_set_source, coding_set_destination):
10245 Use "else { /* comment */ }" rather than "else /* comment */;"
10246 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
10247 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10248 a block, when the outer 'i' will do.
10249 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10250 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10251 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10252 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10253 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10254 Rename locals to avoid shadowing.
10255 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
10256 * coding.c (emacs_mule_char, encode_invocation_designation):
10257 Now static, since they're not used elsewhere.
413bb2db 10258 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 10259 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
10260 (decode_coding_emacs_mule): Mark variables that gcc
10261 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
10262 (detect_coding_iso_2022): Initialize a local variable that might
10263 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 10264 this initialization is needed. (Bug#8211)
5f58e762
PE
10265 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10266 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10267 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10268 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10269 Remove unused macros.
f38b440c 10270
232b38b9 10271 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 10272 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 10273 * character.c (string_count_byte8): Likewise.
232b38b9 10274
fb90da1b
PE
10275 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10276 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10277
fb93dbc2
PE
10278 * chartab.c (copy_sub_char_table): Now static, since it's not used
10279 elsewhere.
5c156ace
PE
10280 (sub_char_table_ref_and_range, char_table_ref_and_range):
10281 Rename locals to avoid shadowing.
bbcd0949 10282 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 10283
7d3b3862 10284 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 10285 (BIDI_BOB): Remove unused macro.
7d3b3862 10286
6be7d3da
PE
10287 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10288 deduce are never used uninitialized.
c2ed9c8b 10289 * term.c (encode_terminal_code): Likewise.
6be7d3da 10290
75f8807f 10291 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 10292
50938595
PE
10293 * tparam.h: New file.
10294 * term.c, tparam.h: Include it.
10295 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10296 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10297 Move these decls to tparam.h, and make them agree with what
10298 is actually in tparam.c. The previous trick of using incompatible
10299 decls in different modules does not conform to the C standard.
10300 All callers of tparam changed to use tparam's actual API.
10301 * tparam.c (tparam1, tparam, tgoto):
10302 Use const pointers where appropriate.
10303
fbceeba2
PE
10304 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10305 * cm.h (struct cm): Likewise.
10306 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10307 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10308 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10309 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10310 (turn_on_face, init_tty): Likewise.
10311 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 10312
7f3f1250
PE
10313 * term.c (term_mouse_position): Rename local to avoid shadowing.
10314
e6ca6543
PE
10315 * alloc.c (mark_ttys): Move decl from here ...
10316 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10317
c40f8d15
AS
103182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10319
10320 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10321
cfe0661d
JB
103222011-03-09 Juanma Barranquero <lekktu@gmail.com>
10323
10324 * search.c (compile_pattern_1): Remove argument regp, unused since
10325 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10326 (compile_pattern): Don't pass it.
10327
0afb4571
J
103282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10329
10330 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10331 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10332 for ! HAVE_GTK3.
10333 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10334
10335 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10336
10337 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10338 gdk_window_get_screen, gdk_window_get_geometry,
10339 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10340 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10341 (xg_get_pixbuf_from_pixmap): New function.
10342 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10343 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10344 Call xg_get_pixbuf_from_pixmap instead of
10345 gdk_pixbuf_get_from_drawable.
10346 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10347 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10348 (xg_check_special_colors): Use GtkStyleContext and its functions
10349 for HAVE_GTK3.
10350 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10351 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10352 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
10353 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10354 Call gtk_widget_get_preferred_size.
0afb4571
J
10355 (xg_frame_resized): gdk_window_get_geometry only takes 5
10356 parameters.
44f230aa
SM
10357 (xg_win_to_widget, xg_event_is_for_menubar):
10358 Call gdk_x11_window_lookup_for_display.
0afb4571
J
10359 (xg_set_widget_bg): New function.
10360 (delete_cb): New function.
895009e1 10361 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 10362 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
10363 (xg_set_background_color): Call xg_set_widget_bg.
10364 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10365 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10366 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10367 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10368 if ! HAVE_GTK3.
10369 (update_frame_tool_bar): Call gtk_widget_hide.
10370 (xg_initialize): Use GDK_KEY_g.
10371
10372 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10373 if ! HAVE_GTK3
10374 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10375
10376 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10377 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10378 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10379
1c2cc4ef
JB
103802011-03-08 Juanma Barranquero <lekktu@gmail.com>
10381
10382 * w32xfns.c (select_palette): Check success of RealizePalette against
10383 GDI_ERROR, not zero.
10384
33383987 10385See ChangeLog.11 for earlier changes.
aac0c6e3
MR
10386
10387;; Local Variables:
10388;; coding: utf-8
aac0c6e3
MR
10389;; End:
10390
2f097256 10391 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
10392
10393 This file is part of GNU Emacs.
10394
10395 GNU Emacs is free software: you can redistribute it and/or modify
10396 it under the terms of the GNU General Public License as published by
10397 the Free Software Foundation, either version 3 of the License, or
10398 (at your option) any later version.
10399
10400 GNU Emacs is distributed in the hope that it will be useful,
10401 but WITHOUT ANY WARRANTY; without even the implied warranty of
10402 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10403 GNU General Public License for more details.
10404
10405 You should have received a copy of the GNU General Public License
10406 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.